Fix up xmlCleanupParser sequence.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4
5 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6 since this reportedly can destroy thread storage.
7
8 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
9
10 * syntax.c (find_defun_start): Update all cache variables if
11 exiting early (Bug#9401).
12
13 2011-08-30 Eli Zaretskii <eliz@gnu.org>
14
15 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
16
17 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
18 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
19 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
20
21 * term.c (tty_append_glyph): New function.
22 (produce_stretch_glyph): Static function and its prototype deleted.
23
24 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
25 prototypes.
26
27 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
28
29 * image.c (parse_image_spec): Check for nonnegative, not for positive,
30 when checking :margin (Bug#9390).
31 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
32 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
33 so that the name doesn't mislead. All uses changed.
34
35 2011-08-28 Johan Bockgård <bojohan@gnu.org>
36
37 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
38 set_tty_hooks.
39
40 2011-08-27 Eli Zaretskii <eliz@gnu.org>
41
42 * xdisp.c (move_it_to): Don't bail out early when reaching
43 position beyond to_charpos, if we are scanning backwards.
44 (move_it_vertically_backward): When DY == 0, make sure we get to
45 the first character in the line after the newline.
46
47 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
48
49 * ccl.c: Improve and simplify overflow checking (Bug#9196).
50 (ccl_driver): Do not generate an out-of-range pointer.
51 (Fccl_execute_on_string): Remove unnecessary check for
52 integer overflow, noted by Stefan Monnier in
53 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
54 Remove a FIXME that didn't need fixing.
55 Simplify the newly-introduced buffer reallocation code.
56
57 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
58
59 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
60
61 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
62
63 Integer and memory overflow issues (Bug#9196).
64
65 * doc.c (get_doc_string): Rework so that
66 get_doc_string_buffer_size is the actual buffer size, rather than
67 being 1 less than the actual buffer size; this makes xpalloc more
68 convenient.
69
70 * image.c (x_allocate_bitmap_record, cache_image):
71 * xselect.c (Fx_register_dnd_atom):
72 Simplify previous changes by using xpalloc.
73
74 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
75 since either will do and ptrdiff_t is convenient with xpalloc.
76
77 * charset.c (charset_table_size)
78 (struct charset_sort_data.priority): Now ptrdiff_t.
79 (charset_compare): Don't overflow if priorities differ greatly.
80 (Fsort_charsets): Don't assume list length fits in int.
81 Check for size-calculation overflow when allocating sort data.
82 (syms_of_charset): Allocate an initial charset table that is
83 just under 64 KiB, to avoid problems with glibc malloc and mmap.
84
85 * cmds.c (internal_self_insert): Check for size-calculation overflow.
86
87 * composite.h (struct composition.glyph_len): Now int, not unsigned.
88 The actual value is always <= INT_MAX, and leaving it unsigned made
89 overflow checking harder.
90
91 * dispextern.h (struct glyph_matrix.rows_allocated)
92 (struct face_cache.size): Now ptrdiff_t, for convenience in use
93 with xpalloc. The values are still always <= INT_MAX.
94
95 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
96
97 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
98 (SAFE_NALLOCA): New macro.
99
100 * region-cache.c (struct boundary.pos, find_cache_boundary)
101 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
102 (set_cache_region, invalidate_region_cache)
103 (revalidate_region_cache, know_region_cache, region_cache_forward)
104 (region_cache_backward, pp_cache):
105 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
106 so that ptrdiff_t * can be passed to xpalloc.
107 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
108 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
109 (pp_cache): Don't assume cache_len fits in int.
110 * region-cache.h: Adjust extern decls to match.
111
112 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
113 EMACS_INT, since either will do, for xpalloc.
114
115 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
116 (xnmalloc, xnrealloc, xpalloc): New functions.
117
118 * bidi.c (bidi_shelve_header_size): New constant.
119 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
120 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
121
122 * bidi.c (bidi_cache_shrink):
123 * buffer.c (overlays_at, overlays_in, record_overlay_string)
124 (overlay_strings):
125 Don't update size of array until after memory allocation succeeds,
126 because xmalloc/xrealloc may not return.
127 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
128 now that we have proper integer overflow checking.
129 (record_overlay_string, overlay_strings): Catch overflows when
130 calculating size of overlay_str_buf.
131
132 * callproc.c (Fcall_process): Check for size overflow when
133 calculating size of args2.
134 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
135 Normally we prefer signed values, but sticking with ptrdiff_t would
136 require adding more-complicated checks.
137
138 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
139 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
140 Redo buffer-overflow calculations to avoid integer overflow.
141 Add a FIXME comment where memory seems to be over-allocated.
142
143 * character.c (Fstring): Check for size-calculation overflow.
144
145 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
146 unnecessary integer overflow. Check for size overflow.
147 (encode_coding_object): Don't update size until xmalloc succeeds.
148
149 * composite.c (get_composition_id): Check for overflow in glyph
150 length calculations.
151
152 Integer and memory overflow fixes for display code.
153 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
154 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
155 (scrolling_window): Check for overflow in size calculations.
156 (line_draw_cost, realloc_glyph_pool, add_row_entry):
157 Don't assume glyph table len fits in int.
158 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
159 (row_table_size): Now ptrdiff_t, not int.
160 (scrolling_window): Avoid overflow in size calculations.
161 Don't update size until allocation succeeds.
162 * fns.c (concat): Check for overflow in size calculations.
163 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
164 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
165 (NEXT_ALMOST_PRIME_LIMIT): New constant.
166
167 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
168 (get_doc_string): Check for size calculation overflow.
169 Don't update size until allocation succeeds.
170 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
171 EMACS_INT, where ptrdiff_t will do.
172 (Fsubstitute_command_keys): Check for string overflow.
173
174 * editfns.c (set_time_zone_rule): Don't assume environment length
175 fits in int.
176 (message_length): Now ptrdiff_t, not int.
177 (Fmessage_box): Don't update size until allocation succeeds.
178 Don't assume message length fits in int.
179 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
180
181 * emacs.c (main): Do not reallocate argv, since there is a null at
182 the end that can be overwritten, and this way there's no need to
183 worry about size-calculation overflow.
184 (sort_args): Check for size-calculation overflow.
185
186 * eval.c (init_eval_once, grow_specpdl): Don't update size until
187 alloc succeeds.
188 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
189
190 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
191 (x_set_scroll_bar_width, x_figure_window_size):
192 Check for integer overflow.
193 (x_set_alpha): Do not assume XINT fits in int.
194
195 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
196 This is for the members text_lines, text_cols, total_lines, total_cols,
197 where the system imposes an 'int' limit.
198
199 * fringe.c (Fdefine_fringe_bitmap):
200 Don't update size until alloc works.
201
202 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
203 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
204
205 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
206 Check for size-calculation overflow.
207 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
208 do, as we prefer signed integers.
209 (id_to_widget.max_size, id_to_widget.used)
210 (xg_store_widget_in_map, xg_remove_widget_from_map)
211 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
212 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
213 Use and return ptrdiff_t, not int.
214 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
215 * gtkutil.h: Change prototypes to match the above.
216
217 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
218 are duplicate now that they've been promoted to lisp.h.
219 (x_allocate_bitmap_record, x_alloc_image_color)
220 (make_image_cache, cache_image, xpm_load):
221 Don't update size until alloc is done.
222 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
223 (x_detect_edges):
224 Check for size calculation overflow.
225 (ct_colors_allocated_max): New constant.
226 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
227 overflow.
228
229 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
230 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
231 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
232 Use ptrdiff_t, not int, to count maps.
233 (read_char_minibuf_menu_prompt): Check for overflow in size
234 calculations. Don't update size until allocation succeeds. Redo
235 calculations to avoid overflow.
236 * keyboard.h: Change prototypes to match the above.
237
238 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
239 to count maps.
240 (current_minor_maps): Check for size calculation overflow.
241 * keymap.h: Change prototypes to match the above.
242
243 * lread.c (read1, init_obarray): Don't update size until alloc done.
244
245 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
246 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
247
248 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
249 Now ptrdiff_t, not int.
250 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
251 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
252
253 * process.c (Fnetwork_interface_list): Check for overflow
254 in size calculation.
255
256 * region-cache.c (move_cache_gap): Check for size calculation overflow.
257
258 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
259 overflow. Don't bother calling xmalloc when xrealloc will do.
260
261 * search.c (Freplace_match): Check for size calculation overflow.
262 (Fset_match_data): Don't assume list lengths fit in 'int'.
263
264 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
265 for command line length. Do not attempt to address one before the
266 beginning of an array, as that's not portable.
267
268 * term.c (max_frame_lines): Remove; unused.
269 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
270 not int.
271 (encode_terminal_code, calculate_costs): Check for size
272 calculation overflow.
273 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
274 table lengths and related sizes. Don't update size until alloc
275 done. Redo calculations to avoid overflow.
276 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
277
278 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
279 subtracting pointers.
280 (gobble_line): Check for overflow more carefully. Don't update size
281 until alloc done.
282
283 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
284 Don't update size until alloc done.
285 Redo size calculations to avoid overflow.
286 Check for size calculation overflow.
287 (main) [DEBUG]: Fix typo in invoking tparam1.
288
289 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
290 Use ptrdiff_t, not int, for sizes.
291 (store_mode_line_noprop_char): Don't update size until alloc done.
292
293 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
294 Use ptrdiff_t, not int, for sizes.
295 (Finternal_make_lisp_face, cache_face):
296 Check for size calculation overflow.
297 (cache_face): Treat size calculation overflows as if they were
298 memory exhaustion (the usual treatment), rather than aborting.
299
300 * xfns.c (x_encode_text, x_set_name_internal)
301 (Fx_change_window_property): Use ptrdiff_t, not int, to count
302 sizes, since they can exceed INT_MAX in size. Check for size
303 calculation overflow.
304
305 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
306 (xg_select): Check for size calculation overflow.
307 Don't update size until alloc done.
308
309 * xrdb.c (get_environ_db): Don't assume path length fits in int,
310 as sprintf is limited to int lengths.
311
312 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
313 (X_LONG_MIN): New macros.
314 Use them to make the following changes clearer.
315 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
316 This change doesn't affect the value now, but it may help remind
317 future maintainers not to raise the value too much later.
318 (SELECTION_QUANTUM): Remove, replacing with ...
319 (selection_quantum): ... new function, which avoids overflow.
320 All uses changed.
321 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
322 assumption that selection length fits in 'int'.
323 (x_reply_selection_request, x_handle_selection_request)
324 (x_get_window_property, receive_incremental_selection)
325 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
326 (lisp_data_to_selection_data, clean_local_selection_data):
327 Use ptrdiff_t, not int, to record length of selection.
328 (x_reply_selection_request, x_get_window_property)
329 (receive_incremental_selection, x_property_data_to_lisp):
330 Redo calculations to avoid overflow.
331 (x_reply_selection_request): When sending hint, ceiling it at
332 X_LONG_MAX rather than relying on wraparound overflow to send
333 something.
334 (x_get_window_property, receive_incremental_selection)
335 (lisp_data_to_selection_data, x_property_data_to_lisp):
336 Check for size-calculation overflow.
337 (x_get_window_property, receive_incremental_selection)
338 (lisp_data_to_selection_data, Fx_register_dnd_atom):
339 Don't store size until memory allocation succeeds.
340 (x_get_window_property): Plug memory leak on memory exhaustion.
341 Don't double-block input; malloc is safe here. Don't assume 2**34
342 - 4 fits in unsigned long. Add an xassert to check
343 XGetWindowProperty overflow. Be more careful about overflow
344 calculations, and distinguish size from memory overflow better.
345 (receive_incremental_selection): When tracing, don't assume
346 unsigned int is less than INT_MAX.
347 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
348 harmful) conversions of unsigned short to int.
349 (lisp_data_to_selection_data): Don't assume that integers
350 in the range -65535 through -1 fit in an X unsigned short.
351 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
352 result parameters unless successful. Rely on cons_to_unsigned
353 to report problems with elements; the old code wasn't right anyway.
354 (x_check_property_data): Check for int overflow; we cannot use
355 a wider type due to X limits.
356 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
357
358 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
359
360 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
361 (x_term_init): Check for size calculation overflow.
362 (x_color_cells): Don't store size until memory allocation succeeds.
363 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
364 Don't assume alloca size is less than MAX_ALLOCA.
365 (x_term_init): Don't assume length fits in int (sprintf is limited
366 to int size).
367
368 Use ptrdiff_t for composition IDs.
369 * character.c (lisp_string_width):
370 * composite.c (composition_table_size, n_compositions)
371 (get_composition_id, composition_gstring_from_id):
372 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
373 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
374 * window.c (Frecenter):
375 Use ptrdiff_t, not int, for composition IDs.
376 * composite.c (get_composition_id): Check for integer overflow.
377 * composite.h: Adjust prototypes to match the above changes.
378
379 Use ptrdiff_t for hash table indexes.
380 * category.c (hash_get_category_set):
381 * ccl.c (ccl_driver):
382 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
383 * coding.c (coding_system_charset_list, detect_coding_system):
384 * coding.h (struct coding_system.id):
385 * composite.c (get_composition_id, gstring_lookup_cache):
386 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
387 * image.c (xpm_get_color_table_h):
388 * lisp.h (hash_lookup, hash_put):
389 * minibuf.c (Ftest_completion):
390 Use ptrdiff_t for hash table indexes, not int (which is too
391 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
392 32-bit --with-wide-int hosts).
393
394 * charset.c (Fdefine_charset_internal): Check for integer overflow.
395 Add a FIXME comment about memory leaks.
396 (syms_of_charset): Don't assume xmalloc returns.
397
398 Don't assume that stated character widths fit in int.
399 * character.c (Fchar_width, c_string_width, lisp_string_width):
400 * character.h (CHAR_WIDTH):
401 * indent.c (MULTIBYTE_BYTES_WIDTH):
402 Use sanitize_char_width to avoid undefined and/or bad behavior
403 with outlandish widths.
404 * character.h (sanitize_tab_width): Renamed from sanitize_width,
405 now that we have two such functions. All uses changed.
406 (sanitize_char_width): New inline function.
407
408 Don't assume that tab-width fits in int.
409 * character.h (sanitize_width): New inline function.
410 (SANE_TAB_WIDTH): New macro.
411 (ASCII_CHAR_WIDTH): Use it.
412 * indent.c (sane_tab_width): Remove. All uses replaced by
413 SANE_TAB_WIDTH (current_buffer).
414 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
415
416 * fileio.c: Integer overflow issues with file modes.
417 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
418
419 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
420 Remove unreachable code.
421 (read_hex, load_charset_map_from_file): Check for integer overflow.
422
423 * xterm.c: don't go over XClientMessageEvent limit
424 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
425 (x_send_scroll_bar_event): Likewise. Check that the size does not
426 exceed limits imposed by XClientMessageEvent, as well as the usual
427 ptrdiff_t and size_t limits.
428
429 * keyboard.c: Overflow, signedness and related fixes.
430 (make_lispy_movement): Use same integer type in forward decl
431 that is used in the definition.
432 (read_key_sequence, keyremap_step):
433 Change bufsize argument back to int, undoing my 2011-03-30 change.
434 We prefer signed types, and int is wide enough here.
435 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
436 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
437 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
438 length, not size_t. Use ptrdiff_t for index, not int.
439 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
440 possibility of integer overflow.
441
442 Overflow, signedness and related fixes for images.
443
444 * dispextern.h (struct it.stack[0].u.image.image_id)
445 (struct_it.image_id, struct image.id, struct image_cache.size)
446 (struct image_cache.used, struct image_cache.ref_count):
447 * gtkutil.c (update_frame_tool_bar):
448 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
449 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
450 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
451 * nsmenu.m (update_frame_tool_bar):
452 * xdisp.c (calc_pixel_width_or_height):
453 * xfns.c (image_cache_refcount):
454 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
455 on typical 64-bit hosts.
456
457 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
458 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
459 Omit unnecessary casts to int.
460 (parse_image_spec): Check that integers fall into 'int' range
461 when the callers expect that.
462 (image_ascent): Redo ascent calculation to avoid int overflow.
463 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
464 (lookup_image): Remove unnecessary tests.
465 (xbm_image_p): Locals are now of int, not EMACS_INT,
466 since parse_image_check makes sure they fit into int.
467 (png_load, gif_load, svg_load_image):
468 Prefer int to unsigned where either will do.
469 (tiff_handler): New function, combining the cores of the
470 old tiff_error_handler and tiff_warning_handler. This
471 function is rewritten to use vsnprintf and thereby avoid
472 stack buffer overflows. It uses only the features of vsnprintf
473 that are common to both POSIX and native Microsoft.
474 (tiff_error_handler, tiff_warning_handler): Use it.
475 (tiff_load, gif_load, imagemagick_load_image):
476 Don't assume :index value fits in 'int'.
477 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
478 (imagemagick_load_image): Check that crop parameters fit into
479 the integer types that MagickCropImage accepts. Don't assume
480 Vimagemagick_render_type has a nonnegative value. Don't assume
481 size_t fits in 'long'.
482 (gs_load): Use printmax_t to print the widest integers possible.
483 Check for integer overflow when computing image height and width.
484
485 2011-08-26 Eli Zaretskii <eliz@gnu.org>
486
487 * xdisp.c (redisplay_window): Don't force window start if point
488 will be invisible in the resulting window. (Bug#9324)
489
490 2011-08-25 Eli Zaretskii <eliz@gnu.org>
491
492 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
493 the display spec is of the form `(space ...)'.
494 (handle_display_spec): Return the value returned by
495 handle_single_display_spec, not just 1 or zero.
496 (handle_single_display_spec): If the display spec is of the form
497 `(space ...)', and specifies display in the text area, return 2
498 rather than 1.
499 (try_cursor_movement): Check for the need to scroll more
500 accurately, and prefer exact match for point under bidi. Don't
501 advance `row' beyond the last row of the window.
502
503 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
504 into disp_prop; all users changed.
505
506 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
507 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
508 for the text covered by the display property.
509
510 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
511
512 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
513 Change return value to nil.
514 (Frecord_buffer): Delete unused function.
515
516 2011-08-24 Eli Zaretskii <eliz@gnu.org>
517
518 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
519 buffers, return left-to-right.
520 (set_cursor_from_row): Consider candidate row a win if its glyph
521 represents a newline and point is on that newline. Fixes cursor
522 positioning on the newline at EOL of R2L text within L2R
523 paragraph, and vice versa.
524 (try_cursor_movement): Check continued rows, in addition to
525 continuation rows. Fixes unwarranted scroll when point enters a
526 continued line of R2L text within an L2R paragraph, or vice versa.
527 (cursor_row_p): Consider the case of point being equal to
528 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
529 from the end of a short line to the beginning of a continued line
530 of R2L text within L2R paragraph.
531 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
532 composed characters.
533
534 * bidi.c (bidi_check_type): Use xassert.
535 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
536 members.
537
538 2011-08-23 Eli Zaretskii <eliz@gnu.org>
539
540 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
541 a character.
542
543 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
544
545 * nsfont.m (ns_otf_to_script): Fix typo.
546
547 2011-08-22 Kenichi Handa <handa@m17n.org>
548
549 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
550 extra slot even if the purpose is char-code-property-table.
551
552 2011-08-23 Eli Zaretskii <eliz@gnu.org>
553
554 * xdisp.c (redisplay_window): When computing centering_position,
555 account for the height of the header line. (Bug#8874)
556
557 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
558 instead of CHAR_TO_BYTE. Fixes a crash when a completion
559 candidate is selected by the mouse, and that candidate has a
560 composed character under the mouse.
561
562 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
563 coordinates reported by pos-visible-in-window-p for a composed
564 character in column zero.
565
566 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
567
568 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
569
570 2011-08-22 Eli Zaretskii <eliz@gnu.org>
571
572 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
573 consider it a hit if to_charpos is anywhere in the range of the
574 composed buffer positions.
575
576 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
577
578 * image.c (gif_load): Don't assume that each subimage has the same
579 dimensions as the base image. Handle disposal method that is
580 "undefined" by the gif spec (Bug#9335).
581
582 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
583
584 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
585 (Fcondition_case): Document `debug' symbol in error handler.
586
587 2011-08-19 Eli Zaretskii <eliz@gnu.org>
588
589 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
590 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
591 from an Org mode buffer to a Speedbar frame.
592
593 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
594 a composition, take its buffer position from IT->cmp_it.charpos.
595 Fixes cursor positioning at the beginning of a line that begins
596 with a composed character.
597
598 2011-08-18 Eli Zaretskii <eliz@gnu.org>
599
600 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
601 character bidirectional type, use STRONG_L instead. Fixes crashes
602 in a buffer produced by `describe-categories'.
603
604 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
605 members before the level stack, so they would be saved and
606 restored when copying iterator state. Fixes incorrect reordering
607 around TABs covered by display properties.
608
609 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
610
611 * process.c (Fnetwork_interface_list): Correctly determine buffer
612 size.
613
614 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
615
616 * eval.c (internal_condition_case, internal_condition_case_1)
617 (internal_condition_case_2, internal_condition_case_n):
618 Remove unnecessary aborts (Bug#9081).
619
620 2011-08-17 Eli Zaretskii <eliz@gnu.org>
621
622 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
623 has no `load' handler, try opening the file locally. (Bug#9311)
624
625 2011-08-16 Ken Brown <kbrown@cornell.edu>
626
627 * gmalloc.c: Expand comment.
628
629 2011-08-16 Eli Zaretskii <eliz@gnu.org>
630
631 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
632 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
633
634 2011-08-16 Ken Brown <kbrown@cornell.edu>
635
636 Fix memory allocation problems in Cygwin build (Bug#9273).
637
638 * unexcw.c ( __malloc_initialized): Declare external variable.
639 (fixup_executable): Force the dumped emacs to reinitialize malloc.
640
641 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
642 New variables.
643 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
644 dumped emacs.
645 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
646 in the static heap.
647 [CYGWIN] (special_realloc): New function.
648 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
649 requests to realloc storage in the static heap.
650
651 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
652
653 * bidi.c (bidi_initialize): Remove unused local.
654
655 2011-08-15 Eli Zaretskii <eliz@gnu.org>
656
657 * biditype.h: File removed.
658
659 * bidimirror.h: File removed.
660
661 * deps.mk (bidi.o): Remove biditype.h and
662 bidimirror.h.
663
664 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
665 bidimirror.h.
666
667 * dispextern.h: Fix a typo in the comment to bidi_type_t.
668
669 * chartab.c: Improve commentary for the uniprop_table API.
670
671 * bidi.c (bidi_paragraph_init): Support zero value of
672 bidi_ignore_explicit_marks_for_paragraph_level.
673 (bidi_initialize): Use uniprop_table instead of including
674 biditype.h and bidimirror.h.
675
676 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
677 coordinates of the iterator when restoring from ppos_it.
678 (Bug#9296)
679
680 2011-08-14 Kenichi Handa <handa@m17n.org>
681
682 * process.c (create_process): Call setup_process_coding_systems
683 after the pid of the process is set to -1 (Bug#8162).
684
685 2011-08-14 Eli Zaretskii <eliz@gnu.org>
686
687 * xdisp.c (move_it_in_display_line_to): Don't invoke
688 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
689 ppos_it. Fixes vertical cursor motion when line beginning is
690 covered by an image. (Bug#9296)
691
692 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
693
694 * nsterm.h (ns_run_ascript): Declare.
695 (NSAPP_DATA2_RUNASSCRIPT): Define.
696
697 * nsfns.m (as_script, as_result, as_status): New static variables.
698 (ns_run_ascript): New function.
699 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
700 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
701 the event loop. Get status from as_status (Bug#7276).
702
703 * nsterm.m (sendEvent): If event is NSApplicationDefined and
704 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
705 the event loop (Bug#7276).
706
707 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
708
709 * gnutls.c (QCgnutls_bootprop_priority)
710 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
711 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
712 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
713 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
714 (QCgnutls_bootprop_verify_hostname_error)
715 (QCgnutls_bootprop_callbacks_verify): Rename from
716 Qgnutls_bootprop_..., all uses changed.
717
718 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
719 uses changed.
720
721 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
722
723 * xfaces.c (Qframe_set_background_mode): Now static.
724 * dispextern.h (Qframe_set_background_mode): Remove decl.
725
726 * process.c (Fnetwork_interface_info): Declare local only if needed.
727
728 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
729
730 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
731 (Fnetwork_interface_list): Allocate in increments of bytes instead
732 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
733 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
734 sockaddr.
735 (struct ifflag_def): notrailers is smart on OSX.
736 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
737 Get hardware address with getifaddrs if available.
738
739 2011-08-12 Eli Zaretskii <eliz@gnu.org>
740
741 * xdisp.c (iterate_out_of_display_property): xassert that
742 IT->position is set to within IT->object's boundaries. Break from
743 the loop as soon as EOB is reached; avoids infloops in redisplay
744 when IT->position is set up wrongly due to some bug.
745 Set IT->current to match the bidi iterator unconditionally.
746 (push_display_prop): Allow GET_FROM_STRING as IT->method on
747 entry. Force push_it to save on the stack the current
748 buffer/string position, to be restored by pop_it. Fix flags in
749 the iterator structure wrt the object coming from a display
750 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
751 properties. (Bug#9284)
752
753 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
754
755 * fontset.c (fontset_get_font_group): Add proper type checks.
756 (Bug#9172)
757
758 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
759
760 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
761 and LC_VERSION_MIN_MACOSX.
762 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
763 (dump_it) [LC_FUNCTION_STARTS]: Use it.
764
765 2011-08-08 Eli Zaretskii <eliz@gnu.org>
766
767 * xdisp.c (forward_to_next_line_start): Allow to use the
768 no-display-properties-and-no-overlays under bidi display.
769 Set disp_pos in the bidi iterator to avoid searches for display
770 properties and overlays.
771
772 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
773
774 * editfns.c (Fset_time_zone_rule): Document relationship with the
775 setenv function.
776
777 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
778 the font entity extracted from the cache (Bug#8109).
779
780 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
781
782 * composite.c (autocmp_chars): Don't reset point. That is done by
783 restore_point_unwind (Bug#5984).
784
785 2011-08-07 Juri Linkov <juri@jurta.org>
786
787 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
788 to show the arg `TIME' instead of `TIMEVAL'.
789
790 2011-08-06 Eli Zaretskii <eliz@gnu.org>
791
792 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
793 display property strides EOL and includes a newline, as in
794 longlines-mode. (Bug#9254)
795 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
796 word-wrap under bidirectional display. (Bug#9224)
797
798 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
799 is non-zero, even if the data buffer is NULL. Fixes a crash in
800 vertical-motion with longlines-mode. (Bug#9254)
801
802 2011-08-05 Eli Zaretskii <eliz@gnu.org>
803
804 * bidi.c <bidi_cache_total_alloc>: Now static.
805 (bidi_initialize): Initialize bidi_cache_total_alloc.
806
807 * xdisp.c (display_line): Release buffer allocated for shelved bidi
808 cache. (Bug#9221)
809
810 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
811 amount allocated this far in `bidi_cache_total_alloc'.
812 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
813 non-zero, only free the data buffer without restoring the cache
814 contents. All callers changed.
815
816 * dispextern.h (bidi_unshelve_cache): Update prototype.
817
818 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
819 (move_it_in_display_line, move_it_to)
820 (move_it_vertically_backward, move_it_by_lines): Replace the call
821 to xfree to an equivalent call to bidi_unshelve_cache.
822 (move_it_in_display_line_to): Fix logic of returning
823 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
824
825 2011-08-05 Eli Zaretskii <eliz@gnu.org>
826
827 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
828 came from a string character with a `cursor' property. (Bug#9229)
829
830 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
831
832 * Makefile.in (LIB_PTHREAD): New variable.
833 (LIBES): Add LIB_PTHREAD (Bug#9216).
834
835 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
836 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
837
838 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
839
840 * regex.c (re_iswctype): Remove some redundant boolean
841 conversions.
842
843 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
844
845 * xterm.c (x_find_topmost_parent): New function.
846 (x_set_frame_alpha): Find topmost parent window with
847 x_find_topmost_parent and set the property there also (bug#9181).
848 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
849
850 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
851
852 * callproc.c (Fcall_process): Avoid vfork clobbering
853 the local vars buffer, coding_systems, current_dir.
854
855 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
856
857 * keymap.c (Fmake_composed_keymap): Move to subr.el.
858
859 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
860
861 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
862 so that it is not optimized away.
863
864 * xdisp.c (compute_display_string_pos): Remove unused local.
865
866 2011-08-02 Eli Zaretskii <eliz@gnu.org>
867
868 Fix slow cursor motion and scrolling in large buffers with
869 selective display, like Org Mode buffers. (Bug#9218)
870
871 * dispextern.h (struct bidi_it): New member disp_prop_p.
872
873 * xdisp.c: Remove one-slot cache of display string positions.
874 (compute_display_string_pos): Accept an additional argument
875 DISP_PROP_P; callers changed. Scan at most 5K characters forward
876 for a display string or property. If found, set DISP_PROP_P
877 non-zero.
878
879 * bidi.c (bidi_fetch_char): Accept an additional argument
880 DISP_PROP_P, and pass it to compute_display_string_pos.
881 Only handle text covered by a display string if DISP_PROP_P is returned
882 non-zero. All callers of bidi_fetch_char changed.
883
884 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
885
886 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
887
888 2010-12-03 Don March <don@ohspite.net>
889
890 * keymap.c (Fdefine_key): Fix non-prefix key error message when
891 last character M-[char] is translated to ESC [char] (bug#7541).
892
893 2011-08-02 Kenichi Handa <handa@m17n.org>
894
895 * lisp.h (uniprop_table): Extern it.
896
897 * chartab.c (uniprop_table): Make it non-static.
898
899 2011-08-01 Eli Zaretskii <eliz@gnu.org>
900
901 * xdisp.c (forward_to_next_line_start): Accept additional argument
902 BIDI_IT_PREV, and store into it the state of the bidi iterator had
903 on the newline.
904 (reseat_at_next_visible_line_start): Use the bidi iterator state
905 returned by forward_to_next_line_start to restore the state of
906 it->bidi_it after backing up to previous newline. (Bug#9212)
907
908 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
909
910 * regex.c (re_comp): Protoize.
911 (re_exec): Fix return type.
912 (regexec): Fix type of `ret'. (Bug#9203)
913
914 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
915
916 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
917 This is needed if max-image-size is a floating-point number.
918
919 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
920
921 * print.c (print_object): Print empty symbol as ##.
922
923 * lread.c (read1): Read ## as empty symbol.
924
925 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
926
927 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
928 setting frame foreground color (Bug#9175).
929 (x_set_background_color): Likewise.
930
931 * nsmenu.m (-setText): Size tooltip dimensions precisely to
932 contents (Bug#9176).
933 (EmacsTooltip -init): Remove bezels and add shadows to
934 tooltip windows.
935
936 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
937 or scroll bar (Bug#8470).
938
939 * nsfont.m (nsfont_open): Remove assignment to voffset and
940 unnecessary vars hshink, expand, hd, full_height, min_height.
941 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
942
943 * nsterm.h (nsfont_info): Remove voffset field.
944
945 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
946
947 Implement strike-through and overline on NextStep (Bug#8863).
948
949 * nsfont.m (nsfont_open): Use underline position provided by font,
950 instead of hard-coded value of 2.
951 (nsfont_draw): Call ns_draw_text_decoration instead.
952
953 * nsterm.h: Add declaration for ns_draw_text_decoration.
954
955 * nsterm.m (ns_draw_text_decoration): New function for drawing
956 underline, overline, and strike-through.
957 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
958 ns_draw_text_decoration. Change treatment of cursor drawing to
959 accomodate underlining, etc.
960
961 2011-07-28 Eli Zaretskii <eliz@gnu.org>
962
963 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
964 default.
965
966 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
967
968 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
969 Without this fix, if a signal arrives just after memory fills up,
970 'malloc' might be invoked reentrantly.
971
972 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
973 In other words, assume that every image size is allowed, on non-X
974 hosts. This assumption is probably wrong, but it lets Emacs compile.
975
976 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
977
978 * regex.c (re_iswctype): Convert return values to boolean.
979
980 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
981
982 * xdisp.c (compute_display_string_pos): Don't use cached display
983 string position if the buffer had its restriction changed.
984 (Bug#9184)
985
986 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
987
988 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
989
990 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
991
992 Integer signedness and overflow and related fixes. (Bug#9079)
993
994 * bidi.c: Integer size and overflow fixes.
995 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
996 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
997 (bidi_cache_find_level_change, bidi_cache_ensure_space)
998 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
999 (bidi_find_other_level_edge):
1000 Use ptrdiff_t instead of EMACS_INT where either will do.
1001 This works better on 32-bit hosts configured --with-wide-int.
1002 (bidi_cache_ensure_space): Check for size-calculation overflow.
1003 Use % rather than repeated addition, for better worst-case speed.
1004 Don't set bidi_cache_size until after xrealloc returns, because it
1005 might not return.
1006 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1007 (bidi_cache_ensure_space): Also check that the bidi cache size
1008 does not exceed that of the largest Lisp string or buffer. See Eli
1009 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1010
1011 * alloc.c (__malloc_size_t): Remove.
1012 All uses replaced by size_t. See Andreas Schwab's note
1013 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1014
1015 * image.c: Improve checking for integer overflow.
1016 (check_image_size): Assume that f is nonnull, since
1017 it is always nonnull in practice. This is one less thing to
1018 worry about when checking for integer overflow later.
1019 (x_check_image_size): New function, which checks for integer
1020 overflow issues inside X.
1021 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1022 This removes the need for a memory_full check.
1023 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1024 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1025 (xbm_read_bitmap_data): Change locals back to 'int', since
1026 their values must fit in 'int'.
1027 (xpm_load_image, png_load, tiff_load):
1028 Invoke x_create_x_image_and_pixmap earlier,
1029 to avoid much needless work if the image is too large.
1030 (tiff_load): Treat overly large images as if
1031 x_create_x_image_and_pixmap failed, not as malloc failures.
1032 (gs_load): Use x_check_image_size.
1033
1034 * gtkutil.c: Omit integer casts.
1035 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1036 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1037
1038 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1039
1040 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1041 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1042 would wrongly return t on a 64-bit host.
1043
1044 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1045 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1046 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1047 and therefore cause GCC to emit a bogus diagnostic in some cases.
1048
1049 * image.c: Integer signedness and overflow and related fixes.
1050 This is not an exhaustive set of fixes, but it's time to
1051 record what I've got.
1052 (lookup_pixel_color, check_image_size): Remove redundant decls.
1053 (check_image_size): Don't assume that arbitrary EMACS_INT values
1054 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1055 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1056 (tiff_load, imagemagick_load_image):
1057 Check for overflow in size calculations.
1058 (x_create_x_image_and_pixmap): Remove unnecessary test for
1059 xmalloc returning NULL; that can't happen.
1060 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1061 (xpm_color_bucket): Use better integer hashing function.
1062 (xpm_cache_color): Don't possibly over-allocate memory.
1063 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1064 (gif_memory_source):
1065 Use ptrdiff_t, not int or size_t, to record sizes.
1066 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1067 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1068 either works, as we prefer signed integers.
1069 (tiff_read_from_memory, tiff_write_from_memory):
1070 Return tsize_t, not size_t, since that's what the TIFF API wants.
1071 (tiff_read_from_memory): Don't fail simply because the read would
1072 go past EOF; instead, return a short read.
1073 (tiff_load): Omit no-longer-needed casts.
1074 (Fimagemagick_types): Don't assume size fits into 'int'.
1075
1076 Improve hashing quality when configured --with-wide-int.
1077 * fns.c (hash_string): New function, taken from sxhash_string.
1078 Do not discard information about ASCII character case; this
1079 discarding is no longer needed.
1080 (sxhash-string): Use it. Change sig to match it. Caller changed.
1081 * lisp.h: Declare it.
1082 * lread.c (hash_string): Remove, since we now use fns.c's version.
1083 The fns.c version returns a wider integer if --with-wide-int is
1084 specified, so this should help the quality of the hashing a bit.
1085
1086 * emacs.c: Integer overflow minor fix.
1087 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1088 Define only if GNU_LINUX.
1089 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1090
1091 * dispnew.c: Integer signedness and overflow fixes.
1092 Remove unnecessary forward decls, that were a maintenance hassle.
1093 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1094 All uses changed.
1095 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1096 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1097 (prepare_desired_row, line_draw_cost):
1098 Use int, not unsigned, where either works.
1099 (save_current_matrix, restore_current_matrix):
1100 Use ptrdiff_t, not size_t, where either works.
1101 (init_display): Check for overflow more accurately, and without
1102 relying on undefined behavior.
1103
1104 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1105 Remove, replacing with the new symbols in lisp.h. All uses changed.
1106 * fileio.c (make_temp_name):
1107 * filelock.c (lock_file_1, lock_file):
1108 * xdisp.c (message_dolog):
1109 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1110 Use pMd etc. instead.
1111 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1112 replacing the pWIDE etc. symbols removed from editfns.c.
1113
1114 * keyboard.h (num_input_events): Now uintmax_t.
1115 This is (very slightly) less likely to mess up due to wraparound.
1116 All uses changed.
1117
1118 * buffer.c: Integer signedness fixes.
1119 (alloc_buffer_text, enlarge_buffer_text):
1120 Use ptrdiff_t rather than size_t when either will do, as we prefer
1121 signed integers.
1122
1123 * alloc.c: Integer signedness and overflow fixes.
1124 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1125 (__malloc_size_t): Default to size_t, not to int.
1126 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1127 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1128 Prefer ptrdiff_t to size_t when either would do, as we prefer
1129 signed integers.
1130 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1131 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1132 Now const. Initialize with values that are in range even if char
1133 is signed.
1134 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1135 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1136 These functions do the right thing with sizes > 2**32.
1137 (check_depth): Now ptrdiff_t, not int.
1138 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1139 Adjust to new way of storing sizes. Check for size overflow bugs
1140 in rest of code.
1141 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1142 slightly wrong anyway, as it missed one instance of
1143 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1144 (refill_memory_reserve): Omit needless cast to size_t.
1145 (mark_object_loop_halt): Mark as externally visible.
1146
1147 * xselect.c: Integer signedness and overflow fixes.
1148 (Fx_register_dnd_atom, x_handle_dnd_message):
1149 Use ptrdiff_t, not size_t, since we prefer signed.
1150 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1151 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1152 x_dnd_atoms_size and x_dnd_atoms_length.
1153
1154 * doprnt.c: Prefer signed to unsigned when either works.
1155 * eval.c (verror):
1156 * doprnt.c (doprnt):
1157 * lisp.h (doprnt):
1158 * xdisp.c (vmessage):
1159 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1160 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1161 prefer signed arithmetic to avoid comparison confusion.
1162 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1163 but is a bit tricky.
1164
1165 Assume freestanding C89 headers, string.h, stdlib.h.
1166 * data.c, doprnt.c, floatfns.c, print.c:
1167 Include float.h unconditionally.
1168 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1169 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1170 * regex.c: Likewise for stddef.h, string.h.
1171 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1172 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1173 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1174 (STDC_HEADERS): Remove obsolete defines.
1175 * sysdep.c: Include limits.h unconditionally.
1176
1177 Assume support for memcmp, memcpy, memmove, memset.
1178 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1179 * regex.c (memcmp, memcpy):
1180 Remove; we assume C89 now.
1181
1182 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1183 (__malloc_safe_bcopy): Remove; no longer needed.
1184
1185 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1186 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1187 well either way, and we prefer signed to unsigned.
1188
1189 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1190
1191 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1192 closes the connection while we're reading (bug#9182).
1193
1194 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1195
1196 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1197 are specified (Bug#9168).
1198
1199 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1202 Found by GCC static checking and --with-wide-int on a 32-bit host.
1203
1204 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1205
1206 * xdisp.c (compute_display_string_pos): Fix logic of caching
1207 previous display string position. Initialize cached_prev_pos to
1208 -1. Fixes slow-down at the beginning of a buffer.
1209
1210 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1211
1212 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1213 for attrs[LFACE_FONTSET_INDEX].
1214
1215 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1216
1217 * xml.c (parse_region): Remove unused local
1218 that was recently introduced.
1219
1220 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1221
1222 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1223 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1224
1225 * xdisp.c (move_it_in_display_line_to): Record the best matching
1226 position for TO_CHARPOS while scanning the line, and restore it on
1227 exit if none of the characters scanned was an exact match.
1228 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1229 when exact match is impossible due to invisible text, and the
1230 lines are truncated.
1231
1232 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1233
1234 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1235 for OSX >= 10.7.
1236
1237 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1238
1239 Fix a significant slow-down of cursor motion with C-n, C-p,
1240 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1241 auto-repeat under bidi redisplay in fontified buffers.
1242 * xdisp.c (compute_stop_pos_backwards): New function.
1243 (next_element_from_buffer): Call compute_stop_pos_backwards to
1244 find a suitable prev_stop when we find ourselves before
1245 base_level_stop.
1246 (reseat): Don't look for prev_stop, as that could mean a very long
1247 run.
1248 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1249 <cached_disp_overlay_modiff>: Cache for last found display string
1250 position.
1251 (compute_display_string_pos): Return the cached position if asked
1252 about the same buffer in the same area of character positions, and
1253 the buffer wasn't changed since the time the display string
1254 position was cached.
1255
1256 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1257
1258 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1259 is an integer, which is important for empty lines. (Bug#9149)
1260
1261 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1262
1263 * frame.c (Fmodify_frame_parameters): In tty case, update the
1264 default face if necessary (Bug#4238).
1265
1266 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1267
1268 * editfns.c (Fstring_to_char): No need to explain what a character
1269 is in the docstring (Bug#6576).
1270
1271 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1272
1273 * xml.c (parse_region): Make sure we always return a tree.
1274
1275 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1276
1277 * xml.c (parse_region): If a document contains only comments,
1278 return that, too.
1279
1280 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1281
1282 * xml.c (make_dom): Return comments, too.
1283
1284 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 Port to OpenBSD.
1287 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1288 and the surrounding thread.
1289 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1290 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1291 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1292 timer goes off.
1293 * s/openbsd.h (BROKEN_SIGIO): Define.
1294 * unexelf.c (unexec) [__OpenBSD__]:
1295 Don't update the .mdebug section of the Alpha COFF symbol table.
1296
1297 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1298
1299 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1300 (bug#8460).
1301
1302 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1305 This fixes some race conditions on the permissions of any newly
1306 created file.
1307
1308 * alloc.c (valid_pointer_p): Use pipe, not open.
1309 This fixes some permissions issues when debugging.
1310
1311 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1312 If fchown fails to set both uid and gid, try to set just gid,
1313 as that is sometimes allowed. Adjust the file's mode to eliminate
1314 setuid or setgid bits that are inappropriate if fchown fails.
1315
1316 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1317
1318 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1319 to compare Lisp_Objects.
1320 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1321 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1322 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1323
1324 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1325
1326 * lread.c (read_integer): Unread even EOF character.
1327 (read1): Likewise. Properly record start position of symbol.
1328
1329 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1330 symbol character follows.
1331
1332 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1335 This works around a problem with the previous change to Fcopy_file.
1336 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1337 and without this change, GCC might complain about discarding
1338 fchown's return value.
1339
1340 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1341
1342 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1343
1344 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1345
1346 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1347
1348 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1349
1350 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1351 it's used from the C level.
1352
1353 * process.c: Use the same condition for POLL_FOR_INPUT in both
1354 keyboard.c and process.c (bug#1858).
1355
1356 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1357
1358 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1359 (Fgnutls_boot): Use it.
1360
1361 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1362
1363 * doc.c (Fsubstitute_command_keys): Revert last change.
1364
1365 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1366
1367 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1368 quotes the next character, and doesn't affect other longer
1369 sequences (bug#8935).
1370
1371 * lread.c (syms_of_lread): Clarify that is isn't only
1372 `eval-buffer' and `eval-defun' that's affected by
1373 `lexical-binding' (bug#8460).
1374
1375 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1376
1377 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1378 bidi redisplay when a line includes both an image and is
1379 truncated.
1380
1381 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1382
1383 Fix minor problems found by static checking.
1384 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1385 (elsz): Now a signed constant, not a size_t var. We prefer signed
1386 types to unsigned, to avoid integer comparison confusion. Without
1387 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1388 "cannot optimize loop, the loop counter may overflow", a symptom
1389 of the confusion.
1390 * indent.c (Fvertical_motion): Mark locals as initialized.
1391 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1392
1393 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1394
1395 * search.c (Fre_search_backward): Mention `case-fold-search' in
1396 all the re_search_* functions (bug#8138).
1397
1398 * keyboard.c (Fopen_dribble_file): Document when the file is
1399 closed (bug#8056).
1400
1401 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1402
1403 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1404 bidi_cache_idx.
1405
1406 Support bidi reordering of display and overlay strings.
1407 * xdisp.c (compute_display_string_pos)
1408 (compute_display_string_end): Accept additional argument STRING.
1409 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1410 (reseat_to_string): Initialize bidi_it->string.s and
1411 bidi_it->string.schars.
1412 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1413 NULL (avoids a crash in bidi_paragraph_init).
1414 Initialize itb.string.lstring.
1415 (init_iterator): Call bidi_init_it only of a valid
1416 buffer position was specified. Initialize paragraph_embedding to
1417 L2R.
1418 (reseat_to_string): Initialize the bidi iterator.
1419 (display_string): If we need to ignore text properties of
1420 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1421 original value of -1 will not work with bidi.)
1422 (compute_display_string_pos): First arg is now struct
1423 `text_pos *'; all callers changed. Support display properties on
1424 Lisp strings.
1425 (compute_display_string_end): Support display properties on Lisp
1426 strings.
1427 (init_iterator, reseat_1, reseat_to_string): Initialize the
1428 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1429 when iterating on a string not from display properties).
1430 (compute_display_string_pos, compute_display_string_end):
1431 Fix calculation of the object to scan. Fixes an error when using
1432 arrow keys.
1433 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1434 base_level_stop; instead, set base_level_stop to BEGV.
1435 Fixes crashes in vertical-motion.
1436 (next_element_from_buffer): Improve commentary for when
1437 the iterator is before prev_stop.
1438 (init_iterator): Initialize bidi_p from the default value of
1439 bidi-display-reordering, not from buffer-local value. Use the
1440 buffer-local value only if initializing for buffer iteration.
1441 (handle_invisible_prop): Support invisible properties on strings
1442 that are being bidi-reordered.
1443 (set_iterator_to_next): Support bidi reordering of C strings and
1444 Lisp strings.
1445 (next_element_from_string): Support bidi reordering of Lisp
1446 strings.
1447 (handle_stop_backwards): Support Lisp strings as well.
1448 (display_string): Support display of R2L glyph rows.
1449 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1450 (init_iterator): Don't initialize it->bidi_p for strings
1451 here.
1452 (reseat_to_string): Initialize it->bidi_p for strings here.
1453 (next_element_from_string, next_element_from_c_string)
1454 (next_element_from_buffer): Add xassert's for correspondence
1455 between IT's object being iterated and it->bidi_it.string
1456 structure.
1457 (face_before_or_after_it_pos): Support bidi iteration.
1458 (next_element_from_c_string): Handle the case of the first string
1459 character that is not the first one in the visual order.
1460 (get_visually_first_element): New function, refactored from common
1461 parts of next_element_from_buffer, next_element_from_string, and
1462 next_element_from_c_string.
1463 (tool_bar_lines_needed, redisplay_tool_bar)
1464 (display_menu_bar): Force left-to-right direction. Add a FIXME
1465 comment for making that be controlled by a user option.
1466 (push_it, pop_it): Save and restore the state of the
1467 bidi iterator. Save and restore the bidi_p flag.
1468 (pop_it): Iterate out of display property for string iteration as
1469 well.
1470 (iterate_out_of_display_property): Support iteration over strings.
1471 (handle_single_display_spec): Set up it->bidi_it for iteration
1472 over a display string, and call bidi_init_it.
1473 (handle_single_display_spec, next_overlay_string)
1474 (get_overlay_strings_1, push_display_prop): Set up the bidi
1475 iterator for displaying display or overlay strings.
1476 (forward_to_next_line_start): Don't use the shortcut if
1477 bidi-iterating.
1478 (back_to_previous_visible_line_start): If handle_display_prop
1479 pushed the iterator stack, restore the internal state of the bidi
1480 iterator by calling bidi_pop_it same number of times.
1481 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1482 and we are bidi-iterating, don't decrement the iterator position;
1483 instead, set the first_elt flag in the bidi iterator, to produce
1484 the same effect.
1485 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1486 (push_display_prop): xassert that we are iterating a buffer.
1487 (push_it, pop_it): Save and restore paragraph_embedding member.
1488 (handle_single_display_spec, next_overlay_string)
1489 (get_overlay_strings_1, reseat_1, reseat_to_string)
1490 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1491 correctly. Don't assume unibyte strings are not bidi-reordered.
1492 (compute_display_string_pos)
1493 (compute_display_string_end): Fix handling the case of C string.
1494 (push_it, pop_it): Save and restore from_disp_prop_p.
1495 (handle_single_display_spec, push_display_prop): Set the
1496 from_disp_prop_p flag.
1497 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1498 (pop_it): Call iterate_out_of_display_property only if we are
1499 popping after iteration over a string that came from a display
1500 property. Fix a typo in popping stretch info. Add an assertion
1501 for verifying that the iterator position is in sync with the bidi
1502 iterator.
1503 (handle_single_display_spec, get_overlay_strings_1)
1504 (push_display_prop): Fix initialization of paragraph direction for
1505 string when that of the parent object is not yet determined.
1506 (reseat_1): Call bidi_init_it to resync the bidi
1507 iterator with IT's position. (Bug#7616)
1508 (find_row_edges): If ROW->start.pos gives position
1509 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1510 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1511 Reset the from_disp_prop_p flag.
1512 (SAVE_IT, RESTORE_IT): New macros.
1513 (pos_visible_p, face_before_or_after_it_pos)
1514 (back_to_previous_visible_line_start)
1515 (move_it_in_display_line_to, move_it_in_display_line)
1516 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1517 (try_scrolling, redisplay_window, display_line): Use them when
1518 saving a temporary copy of the iterator and restoring it back.
1519 (back_to_previous_visible_line_start, reseat_1)
1520 (init_iterator): Empty the bidi cache "stack".
1521 (move_it_in_display_line_to): If iterator ended up at
1522 EOL, but we never saw any buffer positions smaller than
1523 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1524 motion in bidi-reordered lines.
1525 (move_it_in_display_line_to): Record prev_method and prev_pos
1526 immediately before the call to set_iterator_to_next. Fixes cursor
1527 motion in bidi-reordered lines with stretch glyphs and strings
1528 displayed in margins. (Bug#8133) (Bug#8867)
1529 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1530 TO_CHARPOS.
1531 (pos_visible_p): Support positions in bidi-reordered lines.
1532 Save and restore bidi cache.
1533
1534 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1535 (bidi_paragraph_info): Delete unused struct.
1536 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1537 (bidi_cache_start): New variable.
1538 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1539 to zero.
1540 (bidi_cache_fetch_state, bidi_cache_search)
1541 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1542 (bidi_cache_find, bidi_peek_at_next_level)
1543 (bidi_level_of_next_char, bidi_find_other_level_edge)
1544 (bidi_move_to_visually_next): Compare cache index with
1545 bidi_cache_start rather than with zero.
1546 (bidi_fetch_char): Accept new argument STRING; all callers
1547 changed. Support iteration over a string. Support strings with
1548 display properties. Support unibyte strings. Fix the type of
1549 `len' according to what STRING_CHAR_AND_LENGTH expects.
1550 (bidi_paragraph_init, bidi_resolve_explicit_1)
1551 (bidi_resolve_explicit, bidi_resolve_weak)
1552 (bidi_level_of_next_char, bidi_move_to_visually_next):
1553 Support iteration over a string.
1554 (bidi_set_sor_type, bidi_resolve_explicit_1)
1555 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1556 can now be zero (for strings); special values 0 and -1 were
1557 changed to -1 and -2, respectively.
1558 (bidi_char_at_pos): New function.
1559 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1560 Call it instead of FETCH_MULTIBYTE_CHAR.
1561 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1562 initialized to valid values.
1563 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1564 values.
1565 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1566 the test for valid cached positions. Fix the logic for looking up
1567 the sentinel state in the cache. GCPRO the Lisp string we are
1568 iterating.
1569 (bidi_push_it, bidi_pop_it): New functions.
1570 (bidi_initialize): Initialize the bidi cache start stack pointer.
1571 (bidi_cache_ensure_space): New function, refactored from part of
1572 bidi_cache_iterator_state. Don't assume the required size is just
1573 one BIDI_CACHE_CHUNK away.
1574 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1575 (bidi_count_bytes, bidi_char_at_pos): New functions.
1576 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1577 always valid if bidi_cache_idx is valid.
1578 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1579 is valid if it's going to be used.
1580 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1581 (bidi_cache_fetch_state, bidi_cache_search)
1582 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1583 (bidi_cache_iterator_state, bidi_cache_find)
1584 (bidi_find_other_level_edge, bidi_cache_start_stack):
1585 All variables related to cache indices are now EMACS_INT.
1586
1587 * dispextern.h (struct bidi_string_data): New structure.
1588 (struct bidi_it): New member `string'. Make flag members be 1-bit
1589 fields, and put them last in the struct.
1590 (compute_display_string_pos, compute_display_string_end):
1591 Update prototypes.
1592 (bidi_push_it, bidi_pop_it): Add prototypes.
1593 (struct iterator_stack_entry): New members bidi_p,
1594 paragraph_embedding, and from_disp_prop_p.
1595 (struct it): Member bidi_p is now a bit field 1 bit wide.
1596 (bidi_shelve_cache, bidi_unshelve_cache):
1597 Declare prototypes.
1598
1599 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1600 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1601 and vector-like objects.
1602
1603 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1604 cache around display iteration.
1605
1606 * window.c (Fwindow_end, window_scroll_pixel_based)
1607 (displayed_window_lines, Frecenter): Save and restore the bidi
1608 cache around display iteration.
1609
1610 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1611
1612 * editfns.c (Fdelete_region): Clarify the use of the named
1613 parameters (bug#6788).
1614
1615 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1616
1617 * indent.c (Fvertical_motion): Set and restore w->pointm when
1618 saving and restoring the window's buffer (Bug#9006).
1619
1620 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1621
1622 * editfns.c (Fstring_to_char): Clarify just what is returned
1623 (bug#6576). Text by Eli Zaretskii.
1624
1625 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1626
1627 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1628
1629 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1630
1631 * buffer.c (mmap_find): Fix a typo.
1632
1633 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1634
1635 Fix execution of x selection hooks.
1636 * xselect.c (Qx_lost_selection_functions)
1637 (Qx_sent_selection_functions): New vars.
1638 (syms_of_xselect): DEFSYM them.
1639 (x_handle_selection_request): Pass Qx_sent_selection_functions
1640 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1641 (x_handle_selection_clear,x_clear_frame_selections):
1642 Pass Qx_lost_selection_functions rather than
1643 Vx_lost_selection_functions to Frun_hook_with_args.
1644
1645 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1646
1647 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1648 The old code sometimes used this field without initializing it.
1649
1650 * alloc.c (gc_sweep): Don't read past end of array.
1651 In theory, the old code could also have corrupted Emacs internals,
1652 though it'd be very unlikely.
1653
1654 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1655
1656 * character.c (Fcharacterp): Don't advertise optional ignored
1657 argument. (Bug#4026)
1658
1659 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1660
1661 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1662 key" (bug#4257).
1663
1664 * window.c (Fset_window_start): Doc fix (bug#4199).
1665 (Fset_window_hscroll): Ditto.
1666
1667 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1668
1669 Fix minor new problems caught by GCC 4.6.1.
1670 * term.c (init_tty): Remove unused local.
1671 * xsettings.c (store_monospaced_changed): Define this function only
1672 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1673 not used otherwise.
1674
1675 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1676
1677 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1678
1679 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1680
1681 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1682 are the mini-buffer and the echo area (bug#3320).
1683
1684 * term.c (init_tty): Remove support for supdup, c10 and perq
1685 terminals, which are no longer supported (bug#1482).
1686
1687 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1688
1689 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1690
1691 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1692
1693 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1694 for non-popups (Bug#3642).
1695
1696 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1697
1698 * alloc.c (reset_malloc_hooks): Protoize.
1699 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1700 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1701 * cm.c (losecursor): Likewise.
1702 * data.c (fmod): Likewise.
1703 * dispnew.c (swap_glyphs_in_rows): Likewise.
1704 * emacs.c (memory_warning_signal): Likewise.
1705 * floatfns.c (float_error): Likewise.
1706 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1707 (otf_open, font_otf_capability, generate_otf_features)
1708 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1709 Likewise.
1710 * image.c (pbm_read_file): Likewise.
1711 * indent.c (string_display_width): Likewise.
1712 * intervals.c (check_for_interval, search_for_interval)
1713 (inc_interval_count, count_intervals, root_interval)
1714 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1715 * lread.c (defalias): Likewise.
1716 * ralloc.c (r_alloc_check): Likewise.
1717 * regex.c (set_image_of_range_1, set_image_of_range)
1718 (regex_grow_registers): Likewise.
1719 * sysdep.c (strerror): Likewise.
1720 * termcap.c (valid_filename_p, tprint, main): Likewise.
1721 * tparam.c (main): Likewise.
1722 * unexhp9k800.c (run_time_remap, save_data_space)
1723 (update_file_ptrs, read_header, write_header, calculate_checksum)
1724 (copy_file, copy_rest, display_header): Likewise.
1725 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1726 Likewise.
1727 * xdisp.c (check_it): Likewise.
1728 * xfaces.c (register_color, unregister_color, unregister_colors):
1729 Likewise.
1730 * xfns.c (print_fontset_result): Likewise.
1731 * xrdb.c (member, fatal, main): Likewise.
1732
1733 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1734
1735 Fix minor problems found by static checking (Bug#9031).
1736 * chartab.c (char_table_set_range, map_sub_char_table):
1737 Remove unused locals.
1738 (uniprop_table): Now static.
1739 * composite.c (_work_char): Remove unused static var.
1740
1741 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1742
1743 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1744
1745 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1746
1747 * gtkutil.c (qttip_cb): Remove code without function.
1748
1749 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1750
1751 * w32.c (pthread_sigmask): New stub.
1752
1753 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1754
1755 Use pthread_sigmask, not sigprocmask (Bug#9010).
1756 sigprocmask is portable only for single-threaded applications, and
1757 Emacs can be multi-threaded when it uses GTK.
1758 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1759 (LIBES): Use it.
1760 * callproc.c (Fcall_process):
1761 * process.c (create_process):
1762 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1763 Use pthread_sigmask, not sigprocmask.
1764
1765 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1766
1767 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1768 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1769 wrong (Bug#8591).
1770
1771 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1772
1773 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1774 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1775 (xg_hide_tooltip): Fix comment.
1776
1777 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1778 in registerServicesMenuSendTypes.
1779 (validRequestorForSendType): Don't check ns_return_types.
1780
1781 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1782 ns_return_type.
1783
1784 2011-07-08 Jason Rumney <jasonr@gnu.org>
1785
1786 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1787 frame struct members of non-existent frames (Bug#6284).
1788
1789 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1790
1791 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1792 variable firstTime not needed on OSX >= 10.6.
1793 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1794 >= 10.5. Use setKnobProportion, setDoubleValue.
1795
1796 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1797 (MAC_OS_X_VERSION_10_5): Define if not defined.
1798 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1799 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1800 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1801
1802 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1803 cString and lossyCString on OSX >= 10.4
1804
1805 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1806 sizeToFit on OSX >= 10.2.
1807
1808 * nsimage.m (allocInitFromFile): Don't use deprecated method
1809 bestRepresentationForDevice on OSX >= 10.6.
1810
1811 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1812 to avoid warning.
1813
1814 * emacs.c: Declare unexec_init_emacs_zone.
1815
1816 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1817
1818 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1819
1820 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1821 on svcsMenu (Bug#8842).
1822
1823 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1824 ns_return_types.
1825 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1826
1827 * nsterm.m (QUTF8_STRING): Declare.
1828 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1829 (validRequestorForSendType): Return type is (id).
1830 Change indexOfObjectIdenticalTo to indexOfObject.
1831 Check if we have local selection before returning self (Bug#8842).
1832 (writeSelectionToPasteboard): Put local selection into paste board
1833 if we have a local selection (Bug#8842).
1834 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1835
1836 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1837 (ns_get_local_selection): Declare.
1838
1839 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1840
1841 * keymap.c (describe_map_tree): Don't insert a double newline at
1842 the end of the buffer (bug#1169) and return whether we inserted
1843 something.
1844
1845 * callint.c (Fcall_interactively): Change "reading args" to
1846 "providing args" to try to clarify what it does (bug#1010).
1847
1848 2011-07-07 Kenichi Handa <handa@m17n.org>
1849
1850 * composite.c (composition_compute_stop_pos): Ignore a static
1851 composition starting before CHARPOS (Bug#8915).
1852
1853 * xdisp.c (handle_composition_prop): Likewise.
1854
1855 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1856
1857 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1858 (Bug#9015)
1859
1860 2011-07-07 Kenichi Handa <handa@m17n.org>
1861
1862 * character.h (unicode_category_t): New enum type.
1863
1864 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1865 (Qchar_code_property_table): New variable.
1866 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1867 (UNIPROP_COMPRESSED_FORM_P): New macros.
1868 (char_table_ascii): Uncompress the compressed values.
1869 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1870 Uncompress the compressed values.
1871 (sub_char_table_ref_and_range): Likewise.
1872 (char_table_ref_and_range): Uncompress the compressed values.
1873 (sub_char_table_set): New arg is_uniprop. Callers changed.
1874 Uncompress the compressed values.
1875 (sub_char_table_set_range): Args changed. Callers changed.
1876 (char_table_set_range): Adjuted for the above change.
1877 (map_sub_char_table): Delete args default_val and parent. Add arg
1878 top. Give decoded values to a Lisp function.
1879 (map_char_table): Adjust for the above change. Give decoded
1880 values to a Lisp function. Gcpro more variables.
1881 (uniprop_table_uncompress)
1882 (uniprop_decode_value_run_length): New functions.
1883 (uniprop_decoder, uniprop_decoder_count): New variables.
1884 (uniprop_get_decoder, uniprop_encode_value_character)
1885 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1886 New functions.
1887 (uniprop_encoder, uniprop_encoder_count): New variables.
1888 (uniprop_get_encoder, uniprop_table)
1889 (Funicode_property_table_internal, Fget_unicode_property_internal)
1890 (Fput_unicode_property_internal): New functions.
1891 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1892 Sunicode_property_table_internal, Sget_unicode_property_internal,
1893 and Sput_unicode_property_internal. Defvar_lisp
1894 char-code-property-alist.
1895
1896 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1897 Vunicode_category_table.
1898
1899 * font.c (font_range): Adjust for the change of
1900 Vunicode_category_table.
1901
1902 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1903
1904 * m/iris4d.h: Remove file, move contents ...
1905 * s/irix6-5.h: ... here.
1906
1907 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1908
1909 Remove unportable assumption about struct layout (Bug#8884).
1910 * alloc.c (mark_buffer):
1911 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1912 (clone_per_buffer_values): Don't assume that
1913 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1914 This isn't true in general, and it's particularly not true
1915 if Emacs is configured with --with-wide-int.
1916 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1917 New macros, used in the buffer.c change.
1918
1919 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1920
1921 * xsettings.c: Use both GConf and GSettings if both are available.
1922 (store_config_changed_event): Add comment.
1923 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1924 (store_tool_bar_style_changed): New functions.
1925 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1926 (struct xsettings): Move font inside HAVE_XFT.
1927 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1928 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1929 Move inside HAVE_XFT.
1930 (something_changed_gsettingsCB): Rename from something_changedCB.
1931 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1932 also.
1933 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1934 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1935 (something_changed_gconfCB): Rename from something_changedCB.
1936 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1937 (parse_settings): Move check for font inside HAVE_XFT.
1938 (read_settings, apply_xft_settings): Add comment.
1939 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1940 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1941 call store_font_name_changed.
1942 (xft_settings_event): Add comment.
1943 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1944 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1945 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1946 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1947 (xsettings_initialize): Call init_gsettings last.
1948 (xsettings_get_system_font, xsettings_get_system_normal_font):
1949 Add comment.
1950
1951 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 Random fixes. E.g., (random) never returned negative values.
1954 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1955 subseconds part to the entropy, as that's a bit more random.
1956 Prefer signed to unsigned, since the signedness doesn't matter and
1957 in general we prefer signed. When given a limit, use a
1958 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1959 latter isn't right if USE_2_TAGS_FOR_INTS.
1960 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1961 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1962
1963 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1964
1965 * textprop.c (text_property_stickiness):
1966 Obey Vtext_property_default_nonsticky.
1967 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1968 * w32fns.c (syms_of_w32fns):
1969 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1970
1971 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1972
1973 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1974 This is more efficient than Ffile_directory_p and avoids a minor race.
1975
1976 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1977
1978 * buffer.c (Foverlay_put): Say what the return value is
1979 (bug#7835).
1980
1981 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1982 is a directory before asking whether to use the file name
1983 (bug#7564).
1984 (barf_or_query_if_file_exists): Make the "File is a directory"
1985 error be more correct.
1986
1987 * fns.c (Frequire): Remove the mention of the .gz files, since
1988 that's installation-specific, but keep the mention of
1989 `get-load-suffixes'.
1990
1991 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1992
1993 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1994 Report string overflow if the output is too long.
1995
1996 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1997
1998 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1999 (syms_of_gnutls): Remove duplicate DEFSYM for
2000 Qgnutls_bootprop_verify_hostname_error, an error for
2001 Qgnutls_bootprop_verify_error (which is no longer used).
2002
2003 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2004 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2005 Also (re)move comments that are misplaced or no longer relevant.
2006
2007 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2008
2009 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2010
2011 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2012
2013 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2014 and background color parameters if they have been changed.
2015
2016 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2017
2018 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2019
2020 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2021
2022 * xsettings.c (SYSTEM_FONT): Define only when used.
2023 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2024
2025 * keymap.c (access_keymap_1): Now static.
2026
2027 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2028
2029 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2030 leave any prefix arg for the up event (Bug#1586).
2031
2032 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2033
2034 * lread.c (syms_of_lread): Mention single symbols defined by
2035 `defvar' or `defconst' (bug#7154).
2036
2037 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2038 (Frequire): Mention get-load-suffixes.
2039
2040 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2041
2042 * window.h (window): Remove clone_number slot.
2043 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2044 Remove.
2045 (make_parent_window, make_window, saved_window)
2046 (Fset_window_configuration, save_window_save): Don't deal with
2047 clone numbers.
2048 * buffer.c (Qclone_number): Remove declaration.
2049 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2050
2051 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2052
2053 Add multiple inheritance to keymaps.
2054 * keymap.c (Fmake_composed_keymap): New function.
2055 (Fset_keymap_parent): Simplify.
2056 (fix_submap_inheritance): Remove.
2057 (access_keymap_1): New function extracted from access_keymap to handle
2058 embedded parents and handle lists of maps.
2059 (access_keymap): Use it.
2060 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2061 (Fcopy_keymap): Handle embedded parents.
2062 (Fcommand_remapping, define_as_prefix): Simplify.
2063 (Fkey_binding): Simplify.
2064 (syms_of_keymap): Move minibuffer-local-completion-map,
2065 minibuffer-local-filename-completion-map,
2066 minibuffer-local-must-match-map, and
2067 minibuffer-local-filename-must-match-map to Elisp.
2068 (syms_of_keymap): Defsubr make-composed-keymap.
2069 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2070 (parse_menu_item): Trivial simplification.
2071
2072 2011-07-01 Glenn Morris <rgm@gnu.org>
2073
2074 * Makefile.in (SETTINGS_LIBS): Fix typo.
2075
2076 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2077
2078 * coding.c (Fencode_coding_string): Record the last coding system
2079 used, as the function doc string says (bug#8738).
2080
2081 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2082
2083 * xsettings.c (store_monospaced_changed): Take new font as arg and
2084 check for change against current_mono_font.
2085 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2086 (emacs_settings_constructor, emacs_settings_get_property)
2087 (emacs_settings_set_property, emacs_settings_class_init)
2088 (emacs_settings_init, gsettings_obj): Remove.
2089 (something_changedCB): New function for HAVE_GSETTINGS.
2090 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2091 with value as argument.
2092 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2093 g_settings_new (Bug#8967). Do not create gsettings_obj.
2094 Remove calls to g_settings_bind. Connect something_changedCB to
2095 "changed".
2096
2097 * xgselect.c: Add defined (HAVE_GSETTINGS).
2098 (xgselect_initialize): Ditto.
2099
2100 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2101 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2102 xg_select.
2103
2104 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2105
2106 * eval.c (struct backtrace): Simplify and port the data structure.
2107 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2108 signed bit field, as this assumption is not portable and it makes
2109 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2110 "char debug_on_exit : 1" as this is not portable either; instead,
2111 use the portable "unsigned int debug_on_exit : 1". Remove unused
2112 member evalargs. Remove obsolete comments about cc bombing out.
2113
2114 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2115
2116 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2117 Let HAVE_GSETTINGS override HAVE_GCONF.
2118 (store_monospaced_changed): New function.
2119 (EMACS_SETTINGS): A new type derived from GObject to handle
2120 GSettings notifications.
2121 (emacs_settings_constructor, emacs_settings_get_property)
2122 (emacs_settings_set_property, emacs_settings_class_init):
2123 New functions.
2124 (gsettings_client, gsettings_obj): New variables.
2125 (GSETTINGS_SCHEMA): New define.
2126 (something_changedCB): Call store_monospaced_changed.
2127 (init_gsettings): New function.
2128 (xsettings_initialize): Call init_gsettings.
2129 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2130 to NULL.
2131
2132 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2133 GCONF_CFLAGS/LIBS.
2134
2135 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2136
2137 * window.c (resize_root_window, grow_mini_window)
2138 (shrink_mini_window): Rename Qresize_root_window to
2139 Qwindow_resize_root_window and Qresize_root_window_vertically to
2140 Qwindow_resize_root_window_vertically.
2141
2142 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2143
2144 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2145
2146 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2147
2148 * makefile.w32-in: Redesign dependencies so they reflect more
2149 clearly which files are directly included by each source file,
2150 and not through other includes.
2151
2152 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2153
2154 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2155 (sort_overlays, overlay_strings): When an overlay's clone number
2156 matches the window's clone number process the overlay even if
2157 the overlay's window property doesn't match the current window.
2158
2159 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2160 (Fwindow_hchild): Rename to Fwindow_left_child.
2161 (Fwindow_next): Rename to Fwindow_next_sibling.
2162 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2163 (resize_window_check): Rename to window_resize_check.
2164 (resize_window_apply): Rename to window_resize_apply.
2165 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2166 (Fdelete_other_windows_internal, resize_frame_windows)
2167 (Fsplit_window_internal, Fdelete_window_internal)
2168 (grow_mini_window, shrink_mini_window)
2169 (Fresize_mini_window_internal): Fix callers accordingly.
2170
2171 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2172
2173 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2174 (emacs_fixed_set_min_size): Remove.
2175 (emacs_fixed_new): Take frame as argument.
2176
2177 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2178 (_EmacsFixedPrivate): Remove minwidth/height.
2179 Add struct frame *f.
2180 (emacs_fixed_init): Initialize priv->f.
2181 (get_parent_class, emacs_fixed_set_min_size): Remove.
2182 (emacs_fixed_new): Set priv->f to argument.
2183 (emacs_fixed_get_preferred_width)
2184 (emacs_fixed_get_preferred_height): Use min_width/height from
2185 frames size_hint to set minimum and natural (Bug#8919).
2186 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2187 and use min_width/height from frames size_hint to set
2188 min_width/height (Bug#8919).
2189
2190 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2191 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2192 Fix indentation.
2193
2194 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2195
2196 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2197 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2198 called at ZV.
2199
2200 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2201
2202 * process.c (wait_reading_process_output): Bypass select if
2203 waiting for a cell while ignoring keyboard input, and input is
2204 pending. Suggested by Jan Djärv (Bug#8869).
2205
2206 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2207
2208 Use gnulib's dup2 module instead of rolling our own.
2209 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2210
2211 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2212
2213 * dispnew.c (scrolling_window): Before scrolling, turn off a
2214 mouse-highlight in the window being scrolled.
2215
2216 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2217
2218 Move DEFSYM to lisp.h and use everywhere.
2219
2220 * character.h (DEFSYM): Move declaration...
2221 * lisp.h (DEFSYM): ...here.
2222
2223 * gnutls.c:
2224 * minibuf.c:
2225 * w32menu.c:
2226 * w32proc.c:
2227 * w32select.c: Don't include character.h.
2228
2229 * alloc.c (syms_of_alloc):
2230 * buffer.c (syms_of_buffer):
2231 * bytecode.c (syms_of_bytecode):
2232 * callint.c (syms_of_callint):
2233 * casefiddle.c (syms_of_casefiddle):
2234 * casetab.c (init_casetab_once):
2235 * category.c (init_category_once, syms_of_category):
2236 * ccl.c (syms_of_ccl):
2237 * cmds.c (syms_of_cmds):
2238 * composite.c (syms_of_composite):
2239 * dbusbind.c (syms_of_dbusbind):
2240 * dired.c (syms_of_dired):
2241 * dispnew.c (syms_of_display):
2242 * doc.c (syms_of_doc):
2243 * editfns.c (syms_of_editfns):
2244 * emacs.c (syms_of_emacs):
2245 * eval.c (syms_of_eval):
2246 * fileio.c (syms_of_fileio):
2247 * fns.c (syms_of_fns):
2248 * frame.c (syms_of_frame):
2249 * fringe.c (syms_of_fringe):
2250 * insdel.c (syms_of_insdel):
2251 * keymap.c (syms_of_keymap):
2252 * lread.c (init_obarray, syms_of_lread):
2253 * macros.c (syms_of_macros):
2254 * msdos.c (syms_of_msdos):
2255 * print.c (syms_of_print):
2256 * process.c (syms_of_process):
2257 * search.c (syms_of_search):
2258 * sound.c (syms_of_sound):
2259 * syntax.c (init_syntax_once, syms_of_syntax):
2260 * terminal.c (syms_of_terminal):
2261 * textprop.c (syms_of_textprop):
2262 * undo.c (syms_of_undo):
2263 * w32.c (globals_of_w32):
2264 * window.c (syms_of_window):
2265 * xdisp.c (syms_of_xdisp):
2266 * xfaces.c (syms_of_xfaces):
2267 * xfns.c (syms_of_xfns):
2268 * xmenu.c (syms_of_xmenu):
2269 * xsettings.c (syms_of_xsettings):
2270 * xterm.c (syms_of_xterm): Use DEFSYM.
2271
2272 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2273
2274 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2275
2276 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2277
2278 Integer and buffer overflow fixes (Bug#8873).
2279
2280 * print.c (printchar, strout): Check for string overflow.
2281 (PRINTPREPARE, printchar, strout):
2282 Don't set size unless allocation succeeds.
2283
2284 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2285 for sizes. Check for string overflow more accurately.
2286 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2287
2288 * macros.c: Integer and buffer overflow fixes.
2289 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2290 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2291 Use ptrdiff_t, not int, for sizes.
2292 Don't increment bufsize until after realloc succeeds.
2293 Check for size-calculation overflow.
2294 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2295
2296 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2297
2298 * lread.c: Integer overflow fixes.
2299 (read_integer): Radix is now EMACS_INT, not int,
2300 to improve quality of diagnostics for out-of-range radices.
2301 Calculate buffer size correctly for out-of-range radices.
2302 (read1): Check for integer overflow in radices, and in
2303 read-circle numbers.
2304 (read_escape): Avoid int overflow.
2305 (Fload, openp, read_buffer_size, read1)
2306 (substitute_object_recurse, read_vector, read_list, map_obarray):
2307 Use ptrdiff_t, not int, for sizes.
2308 (read1): Use EMACS_INT, not int, for sizes.
2309 Check for size overflow.
2310
2311 * image.c (cache_image): Check for size arithmetic overflow.
2312
2313 * lread.c: Integer overflow issues.
2314 (saved_doc_string_size, saved_doc_string_length)
2315 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2316 Now ptrdiff_t, not int.
2317 (read1): Don't assume doc string length fits in int. Check for
2318 out-of-range doc string lengths.
2319 (read_list): Don't assume file position fits in int.
2320 (read_escape): Check for hex character overflow.
2321
2322 2011-06-22 Leo Liu <sdl.web@gmail.com>
2323
2324 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2325 Move to minibuffer.el.
2326
2327 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2328
2329 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2330 The following patches are for when GLYPH_DEBUG && !XASSERT.
2331 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2332 * dispnew.c (flush_stdout):
2333 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2334 Mark as externally visible.
2335 * dispnew.c (check_window_matrix_pointers): Now static.
2336 * dispnew.c (window_to_frame_vpos):
2337 * xfns.c (unwind_create_frame):
2338 * xterm.c (x_check_font): Remove unused local.
2339 * scroll.c (CHECK_BOUNDS):
2340 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2341 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2342 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2343 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2344 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2345 Now static.
2346 (debug_method_add): Use va_list and vsprintf rather than relying
2347 on undefined behavior with wrong number of arguments.
2348 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2349 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2350 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2351 since we're not interested in debugging glyphs with old libraries.
2352 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2353 GCC 4.6.0's static checking.
2354
2355 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2356
2357 Integer overflow and signedness fixes (Bug#8873).
2358 A few related buffer overrun fixes, too.
2359
2360 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2361
2362 * dispextern.h (struct face.stipple):
2363 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2364 (x_bitmap_mask, x_allocate_bitmap_record)
2365 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2366 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2367 (x_create_bitmap_from_xpm_data):
2368 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2369 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2370 (.bitmaps_last):
2371 * xfaces.c (load_pixmap):
2372 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2373 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2374 (.bitmaps_last, struct x_output.icon_bitmap):
2375 Use ptrdiff_t, not int, for bitmap indexes.
2376 (x_allocate_bitmap_record): Check for size overflow.
2377 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2378
2379 Use ptrdiff_t, not int, for overlay counts.
2380 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2381 * editfns.c (overlays_around, get_pos_property):
2382 * textprop.c (get_char_property_and_overlay):
2383 * xdisp.c (next_overlay_change, note_mouse_highlight):
2384 * xfaces.c (face_at_buffer_position):
2385 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2386 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2387 (Fnext_overlay_change, Fprevious_overlay_change)
2388 (mouse_face_overlay_overlaps, Foverlays_in):
2389 Use ptrdiff_t, not int, for sizes.
2390 (overlays_at, overlays_in): Check for size-calculation overflow.
2391
2392 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2393
2394 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2395 (x_session_initialize): Do not assume string length fits in int.
2396
2397 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2398 This is unlikely, but can occur if DPI is outlandish.
2399
2400 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2401 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2402
2403 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2404 * xrdb.c (magic_file_p, search_magic_path):
2405 Omit last arg SUFFIX; it was always 0. All callers changed.
2406 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2407
2408 * xfont.c (xfont_match): Avoid need for strlen.
2409
2410 * xfns.c: Don't assume strlen fits in int.
2411 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2412
2413 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2414 not unsigned long, as we prefer signed integers. All callers changed.
2415 Detect integer overflow in repeat count.
2416 (message_dolog): Don't assume print length fits in 39 bytes.
2417 (display_mode_element): Don't assume strlen fits in int.
2418
2419 * termcap.c: Don't assume sizes fit in int and never overflow.
2420 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2421 (gobble_line): Check for size-calculation overflow.
2422
2423 * minibuf.c (Fread_buffer):
2424 * lread.c (intern, intern_c_string):
2425 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2426 Don't assume string length fits in int.
2427
2428 * keyboard.c (parse_tool_bar_item):
2429 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2430
2431 * font.c: Don't assume string length fits in int.
2432 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2433 Use ptrdiff_t, not int.
2434 (font_intern_prop): Don't assume string length fits in int.
2435 Don't assume integer property fits in fixnum.
2436 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2437
2438 * filelock.c: Fix some buffer overrun and integer overflow issues.
2439 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2440 Reformulate so as not to need the command string.
2441 Invoke gzip -cd rather than gunzip, as it's more portable.
2442 (lock_info_type, lock_file_1, lock_file):
2443 Don't assume pid_t and time_t fit in unsigned long.
2444 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2445 (current_lock_owner): Prefer signed type for sizes.
2446 Use memcpy, not strncpy, where memcpy is what is really wanted.
2447 Don't assume (via atoi) that time_t and pid_t fit in int.
2448 Check for time_t and/or pid_t out of range, e.g., via a network share.
2449 Don't alloca where an auto var works fine.
2450
2451 * fileio.c: Fix some integer overflow issues.
2452 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2453 Don't assume string length fits in int.
2454 (directory_file_name): Don't assume string length fits in long.
2455 (make_temp_name): Don't assume pid fits in int, or that its print
2456 length is less than 20.
2457
2458 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2459
2460 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2461
2462 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2463
2464 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2465 We prefer signed integers, even for size calculations.
2466
2467 * emacs.c: Don't assume string length fits in 'int'.
2468 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2469 (main): Don't invoke strlen when not needed.
2470
2471 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2472 (XD_DEBUG_MESSAGE): Don't waste a byte.
2473
2474 * callproc.c (getenv_internal_1, getenv_internal)
2475 (Fgetenv_internal):
2476 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2477
2478 * lread.c (invalid_syntax): Omit length argument.
2479 All uses changed. This doesn't fix a bug, but it simplifies the
2480 code away from its former Hollerith-constant appearance, and it's
2481 one less 'int' to worry about when looking at integer-overflow issues.
2482 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2483
2484 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2485 This didn't break anything, but it didn't help either.
2486 It's confusing to put a bogus integer in a place where the actual
2487 value does not matter.
2488 (LIST_END_P): Remove unused macro and its bogus comment.
2489 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2490
2491 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2492 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2493 implementation.
2494 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2495 We prefer signed types, and the value cannot exceed the EMACS_INT
2496 range anyway (because otherwise the length would not be representable).
2497 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2498 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2499 This avoids a GCC warning when WIDE_EMACS_INT.
2500
2501 * indent.c (sane_tab_width): New function.
2502 (current_column, scan_for_column, Findent_to, position_indentation)
2503 (compute_motion): Use it. This is just for clarity.
2504 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2505
2506 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2507
2508 * lisp.h (lint_assume): New macro.
2509 * composite.c (composition_gstring_put_cache):
2510 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2511
2512 * editfns.c, insdel.c:
2513 Omit unnecessary forward decls, to simplify future changes.
2514
2515 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2516
2517 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2518
2519 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2520 Use much-faster test for byte-length change.
2521 Don't assume string byte-length fits in 'int'.
2522 Check that character arg fits in 'int'.
2523 (mapcar1): Declare byte as byte, for clarity.
2524
2525 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2526
2527 * fns.c (concat): Catch string overflow earlier.
2528 Do not rely on integer wraparound.
2529
2530 * dispextern.h (struct it.overlay_strings_charpos)
2531 (struct it.selective): Now EMACS_INT, not int.
2532 * xdisp.c (forward_to_next_line_start)
2533 (back_to_previous_visible_line_start)
2534 (reseat_at_next_visible_line_start, next_element_from_buffer):
2535 Don't arbitrarily truncate the value of 'selective' to int.
2536
2537 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2538
2539 * composite.c: Don't truncate sizes to 'int'.
2540 (composition_gstring_p, composition_reseat_it)
2541 (composition_adjust_point): Use EMACS_INT, not int.
2542 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2543 not EMACS_UINT, for indexes.
2544
2545 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2546
2547 * buffer.c: Include <verify.h>.
2548 (struct sortvec.priority, struct sortstr.priority):
2549 Now EMACS_INT, not int.
2550 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2551 (struct sortstr.size, record_overlay_string)
2552 (struct sortstrlist.size, struct sortlist.used):
2553 Don't truncate size to int.
2554 (record_overlay_string): Check for size-calculation overflow.
2555 (init_buffer_once): Check at compile-time, not run-time.
2556
2557 2011-06-22 Jim Meyering <meyering@redhat.com>
2558
2559 Don't leak an XBM-image-sized buffer
2560 * image.c (xbm_load): Free the image buffer after using it.
2561
2562 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 Port to Sun C.
2565 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2566 that Sun C diagnosed.
2567 * fns.c (secure_hash): Fix pointer signedness issue.
2568 * intervals.c (static_offset_intervals): New function.
2569 (offset_intervals): Use it.
2570
2571 2011-06-21 Leo Liu <sdl.web@gmail.com>
2572
2573 * deps.mk (fns.o):
2574 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2575 sha512.h.
2576
2577 * fns.c (secure_hash): Rename from crypto_hash_function and change
2578 the first arg to accept symbols.
2579 (Fsecure_hash): New primitive.
2580 (syms_of_fns): New symbols.
2581
2582 2011-06-20 Deniz Dogan <deniz@dogan.se>
2583
2584 * process.c (Fset_process_buffer): Clarify return value in
2585 docstring.
2586
2587 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2588
2589 * dispnew.c (add_window_display_history): Use BVAR.
2590
2591 * xdisp.c (debug_method_add): Use BVAR.
2592 (check_window_end, dump_glyph_matrix, dump_glyph)
2593 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2594
2595 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2596 Likewise.
2597
2598 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2599 check till after the cache is created in init_frame_faces.
2600
2601 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2602
2603 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2604
2605 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2606
2607 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2608 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2609 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2610
2611 Improve buffer-overflow checking (Bug#8873).
2612 * fileio.c (Finsert_file_contents):
2613 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2614 Remove the old (too-loose) buffer overflow checks.
2615 They weren't needed, since make_gap checks for buffer overflow.
2616 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2617 The old code merely checked for Emacs fixnum overflow, and relied
2618 on undefined (wraparound) behavior. The new code avoids undefined
2619 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2620
2621 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2622 Tune. Don't use wider integers than needed. Don't use alloca.
2623 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2624
2625 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2626
2627 * insdel.c, lisp.h (buffer_overflow): New function.
2628 (insert_from_buffer_1, replace_range, replace_range_2):
2629 * insdel.c (make_gap_larger):
2630 * editfns.c (Finsert_char):
2631 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2632
2633 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2634
2635 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2636
2637 Integer overflow and signedness fixes (Bug#8873).
2638
2639 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2640 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2641
2642 * fileio.c: Don't assume EMACS_INT fits in off_t.
2643 (emacs_lseek): New static function.
2644 (Finsert_file_contents, Fwrite_region): Use it.
2645 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2646
2647 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2648
2649 * fns.c: Don't overflow int when computing a list length.
2650 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2651 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2652 truncation on 64-bit hosts. Check for QUIT every
2653 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2654 faster and is responsive enough.
2655 (Flength): Report an error instead of overflowing an integer.
2656 (Fsafe_length): Return a float if the value is not representable
2657 as a fixnum. This shouldn't happen except in contrived situations.
2658 (Fnthcdr, Fsort): Don't assume list length fits in int.
2659 (Fcopy_sequence): Don't assume vector length fits in int.
2660
2661 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2662 (header_size, word_size): New constants.
2663 (allocate_vectorlike): Don't check size overflow here.
2664 (allocate_vector): Check it here instead, since this is the only
2665 caller of allocate_vectorlike that could cause overflow.
2666 Check that the new vector's length is representable as a fixnum.
2667
2668 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2669 The previous code was bogus. For example, next_almost_prime (32)
2670 returned 39, which is undesirable as it is a multiple of 3; and
2671 next_almost_prime (24) returned 25, which is a multiple of 5 so
2672 why was the code bothering to check for multiples of 7?
2673
2674 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2675
2676 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2677
2678 Variadic C functions now count arguments with ptrdiff_t.
2679 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2680 Back then I didn't know that the Emacs coding style prefers signed int.
2681 Also, in the meantime I found a few more instances where arguments
2682 were being counted with int, which may truncate counts on 64-bit
2683 machines, or EMACS_INT, which may be unnecessarily wide.
2684 * lisp.h (struct Lisp_Subr.function.aMANY)
2685 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2686 Arg counts are now ptrdiff_t, not size_t.
2687 All variadic functions and their callers changed accordingly.
2688 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2689 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2690 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2691 * callint.c (Fcall_interactively): Check arg count for overflow,
2692 to avoid potential buffer overrun. Use signed char, not 'int',
2693 for 'varies' array, so that we needn't bother to check its size
2694 calculation for overflow.
2695 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2696 * eval.c (apply_lambda):
2697 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2698 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2699 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2700
2701 * callint.c (Fcall_interactively): Don't use index var as event count.
2702
2703 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2704 * mem-limits.h (SIZE): Remove; no longer used.
2705
2706 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2707
2708 Remove unnecessary casts.
2709 * xterm.c (x_term_init):
2710 * xfns.c (x_set_border_pixel):
2711 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2712 These aren't needed now that we assume ANSI C.
2713
2714 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2715 It's more likely to cause problems (due to unsigned overflow)
2716 than to cure them.
2717
2718 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2719
2720 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2721
2722 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2723
2724 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2725
2726 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2727
2728 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2729
2730 GLYPH_CODE_FACE returns EMACS_INT, not int.
2731 * dispextern.h (merge_faces):
2732 * xfaces.c (merge_faces):
2733 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2734 Don't assume EMACS_INT fits in int.
2735
2736 * character.h (CHAR_VALID_P): Remove unused parameter.
2737 * fontset.c, lisp.h, xdisp.c: All uses changed.
2738
2739 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2740
2741 * fns.c (concat): Minor tuning based on overflow analysis.
2742 This doesn't fix any bugs. Use int to hold character, instead
2743 of constantly refetching from Emacs object. Use XFASTINT, not
2744 XINT, for value known to be a character. Don't bother comparing
2745 a single byte to 0400, as it's always less.
2746
2747 * floatfns.c (Fexpt):
2748 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2749
2750 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2751 for characters.
2752
2753 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2754
2755 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2756 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2757 incorrectly succeed when S was a string, because 4294967386 was
2758 truncated before it was used.
2759
2760 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2761 Otherwise, an out-of-range integer could cause undefined behavior
2762 on a 64-bit host.
2763
2764 * composite.c: Use int, not EMACS_INT, for characters.
2765 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2766 EMACS_INT, for values that are known to be in character range.
2767 This doesn't fix any bugs but is the usual style inside Emacs and
2768 may generate better code on 32-bit machines.
2769
2770 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2771 This is for reasons similar to the recent CHAR_STRING fix.
2772 * charset.c (Fencode_char): Check that character arg is actually
2773 a character. Pass an int to ENCODE_CHAR.
2774 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2775 wider than 'int', as a compile-time check to prevent future regressions
2776 in this area.
2777
2778 * character.c (char_string): Remove unnecessary casts.
2779
2780 Make sure a 64-bit char is never passed to CHAR_STRING.
2781 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2782 by silently ignoring the top 32 bits, allowing some values
2783 that were far too large to be valid characters.
2784 * character.h: Include <verify.h>.
2785 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2786 arguments are no wider than unsigned, as a compile-time check
2787 to prevent future regressions in this area.
2788 * data.c (Faset):
2789 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2790 (Fsubst_char_in_region):
2791 * fns.c (concat):
2792 * xdisp.c (decode_mode_spec_coding):
2793 Adjust to CHAR_STRING's new requirement.
2794 * editfns.c (Finsert_char, Fsubst_char_in_region):
2795 * fns.c (concat): Check that character args are actually
2796 characters. Without this test, these functions did the wrong
2797 thing with wildly out-of-range values on 64-bit hosts.
2798
2799 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2800 These casts should not be needed on 32-bit hosts, either.
2801 * keyboard.c (read_char):
2802 * lread.c (Fload): Remove casts to unsigned.
2803
2804 * lisp.h (UNSIGNED_CMP): New macro.
2805 This fixes comparison bugs on 64-bit hosts.
2806 (ASCII_CHAR_P): Use it.
2807 * casefiddle.c (casify_object):
2808 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2809 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2810 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2811 * dispextern.h (FACE_FROM_ID):
2812 * keyboard.c (read_char): Use UNSIGNED_CMP.
2813
2814 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2815 not to EMACS_INT, to avoid GCC warning.
2816
2817 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2818
2819 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2820 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2821 isn't needed on 32-bit machines.
2822
2823 * buffer.c (Fgenerate_new_buffer_name):
2824 Use EMACS_INT for count, not int.
2825 (advance_to_char_boundary): Return EMACS_INT, not int.
2826
2827 * data.c (Qcompiled_function): Now static.
2828
2829 * window.c (window_body_lines): Now static.
2830
2831 * image.c (gif_load): Rename local to avoid shadowing.
2832
2833 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2834 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2835 * alloc.c (make_save_value): Integer argument is now of type
2836 ptrdiff_t, not int.
2837 (mark_object): Use ptrdiff_t, not int.
2838 * lisp.h (pD): New macro.
2839 * print.c (print_object): Use it.
2840
2841 * alloc.c: Use EMACS_INT, not int, to count objects.
2842 (total_conses, total_markers, total_symbols, total_vector_size)
2843 (total_free_conses, total_free_markers, total_free_symbols)
2844 (total_free_floats, total_floats, total_free_intervals)
2845 (total_intervals, total_strings, total_free_strings):
2846 Now EMACS_INT, not int. All uses changed.
2847 (Fgarbage_collect): Compute overall total using a double, so that
2848 integer overflow is less likely to be a problem. Check for overflow
2849 when converting back to an integer.
2850 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2851 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2852 These were 'int' variables that could overflow on 64-bit hosts;
2853 they were never used, so remove them instead of repairing them.
2854 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2855 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2856 Previously, this ceilinged at INT_MAX, but that doesn't work on
2857 64-bit machines.
2858 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2859
2860 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2861 (allocate_vectorlike): Check for ptrdiff_t overflow.
2862 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2863 when a (possibly-narrower) signed value would do just as well.
2864 We prefer using signed arithmetic, to avoid comparison confusion.
2865
2866 * alloc.c: Catch some string size overflows that we were missing.
2867 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2868 for convenience in STRING_BYTES_MAX.
2869 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2870 The definition here is exact; the one in lisp.h was approximate.
2871 (allocate_string_data): Check for string overflow. This catches
2872 some instances we weren't catching before. Also, it catches
2873 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2874 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2875 and ptrdiff_t and EMACS_INT are both 64 bits.
2876
2877 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2878 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2879 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2880
2881 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2882
2883 * alloc.c (Fmake_string): Check for out-of-range init.
2884
2885 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2886
2887 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2888
2889 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2890
2891 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2892 xg_get_default_scrollbar_width.
2893
2894 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2895 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2896 (style_changed_cb): Call update_theme_scrollbar_width and call
2897 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2898 all frames (Bug#8505).
2899 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2900 Call gtk_window_set_resizable if HAVE_GTK3.
2901 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2902 and height if HAVE_GTK3 (Bug#8505).
2903 (scroll_bar_width_for_theme): New variable.
2904 (update_theme_scrollbar_width): New function.
2905 (xg_get_default_scrollbar_width): Move code to
2906 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2907 (xg_initialize): Call update_theme_scrollbar_width.
2908
2909 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2910
2911 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2912
2913 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2914
2915 * frame.c (make_frame): Call other_buffer_safely instead of
2916 other_buffer.
2917
2918 * window.c (temp_output_buffer_show): Call display_buffer with
2919 second argument Vtemp_buffer_show_specifiers and reset latter
2920 immediately after the call.
2921 (Vtemp_buffer_show_specifiers): New variable.
2922 (auto_window_vscroll_p, next_screen_context_lines)
2923 (Vscroll_preserve_screen_position): Remove leading asterisks from
2924 doc-strings.
2925
2926 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2927
2928 Fix minor problems found by GCC 4.6.0 static checking.
2929 * buffer.c (Qclone_number): Remove for now, as it's unused.
2930 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2931 (record_buffer): Remove unused local.
2932 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2933 (set_frame_buffer_list): Remove; unused.
2934 * frame.h (other_visible_frames): Remove decl.
2935 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2936 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2937 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2938 if HAVE_GPM.
2939 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2940 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2941 Define only if HAVE_GPM.
2942 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2943 (update_hints_inhibit): Remove; never set. All uses removed.
2944 * widgetprv.h (emacsFrameClassRec): Remove decl.
2945 * window.c (delete_deletable_window): Now returns void, since it
2946 wasn't returning anything.
2947 (compare_window_configurations): Remove unused locals.
2948 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2949 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2950 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2951 the same widths as pointers. This follows up on the 2011-05-06 patch.
2952 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2953 * xterm.h: Likewise.
2954 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2955
2956 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2957
2958 * makefile.w32-in: Update dependencies.
2959 (LISP_H): Add lib/intprops.h.
2960
2961 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2962
2963 * image.c (gif_load): Add animation frame delay to the metadata.
2964 (syms_of_image): Use DEFSYM. New symbol `delay'.
2965
2966 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2967
2968 * window.c (delete_deletable_window): Re-add.
2969 (Fset_window_configuration): Rewrite to handle dead buffers and
2970 consequently deletable windows.
2971 (window_tree, Fwindow_tree): Remove. Supply functionality in
2972 window.el.
2973 (compare_window_configurations): Simplify code.
2974
2975 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2976
2977 * image.c (imagemagick_load_image): Fix type mismatch.
2978 (Fimagemagick_types): Likewise.
2979
2980 * window.h (replace_buffer_in_windows): Declare.
2981
2982 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2983
2984 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2985 Qclone_number. Remove external declaration of Qdelete_window.
2986 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2987 code.
2988 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2989 Run Qbuffer_list_update_hook if allowed.
2990 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2991 buffer list implementation.
2992 (other_buffer_safely): New function.
2993 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2994 calls to replace_buffer_in_windows and
2995 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2996 if allowed.
2997 (record_buffer): Inhibit quitting and rewrite using quittable
2998 functions. Run Qbuffer_list_update_hook if allowed.
2999 (Frecord_buffer, Funrecord_buffer): New functions.
3000 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3001 Move switch-to-buffer to window.el.
3002 (bury-buffer): Move to window.el.
3003 (Vbuffer_list_update_hook): New variable.
3004
3005 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3006 section.
3007
3008 * window.h (resize_frame_windows): Move up in code.
3009 (Fwindow_frame): Remove EXFUN.
3010 (replace_buffer_in_all_windows): Remove prototype.
3011 (replace_buffer_in_windows_safely): Add prototype.
3012
3013 * window.c: Declare Qdelete_window static again. Move down
3014 declaration of select_count.
3015 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3016 (Fother_window): Move to window.el.
3017 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3018 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3019 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3020 window.el.
3021 (replace_buffer_in_windows): Implement by calling
3022 Qreplace_buffer_in_windows.
3023 (replace_buffer_in_all_windows): Remove with some functionality
3024 moved into replace_buffer_in_windows_safely.
3025 (replace_buffer_in_windows_safely): New function.
3026 (select_window_norecord, select_frame_norecord): Move in front
3027 of run_window_configuration_change_hook. Remove now obsolete
3028 declarations.
3029 (Fset_window_buffer): Rewrite doc-string.
3030 Call Qrecord_window_buffer.
3031 (keys_of_window): Move binding for other-window to window.el.
3032
3033 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3034
3035 * dispextern.h (struct image): Replace data member, whose int_val
3036 and ptr_val fields were not used by anything, with a single
3037 lisp_val object.
3038
3039 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3040 (gif_clear_image, gif_load, imagemagick_load_image)
3041 (gs_clear_image, gs_load): Callers changed.
3042
3043 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3044
3045 * buffer.h: Include <time.h>, for time_t.
3046 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3047
3048 Fix minor problems found by static checking.
3049
3050 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3051
3052 Make identifiers static if they are not used in other modules.
3053 * data.c (Qcompiled_function, Qframe, Qvector):
3054 * image.c (QimageMagick, Qsvg):
3055 * minibuf.c (Qmetadata):
3056 * window.c (resize_window_check, resize_root_window): Now static.
3057 * window.h (resize_window_check, resize_root_window): Remove decls.
3058
3059 * window.c (window_deletion_count, delete_deletable_window):
3060 Remove; unused.
3061 (window_body_lines): Now static.
3062 (Fdelete_other_windows_internal): Mark vars as initialized.
3063 Make sure 'resize_failed' is initialized.
3064 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3065 (resize_window_apply): Remove unused local.
3066 * window.h (delete_deletable_window): Remove decl.
3067
3068 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3069 (imagemagick_load_image): Fix pointer signedness problem by changing
3070 last arg from unsigned char * to char *. All uses changed.
3071 Also, fix a local for similar reasons.
3072 Remove unused locals. Remove locals to avoid shadowing.
3073 (fn_rsvg_handle_free): Remove; unused.
3074 (svg_load, svg_load_image): Fix pointer signedness problem.
3075 (imagemagick_load_image): Don't use garbage pointer image_wand.
3076
3077 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3078
3079 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3080
3081 * image.c (gif_load): Fix omitted cast error introduced by
3082 2011-06-06 change.
3083
3084 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3085
3086 * window.h (resize_proportionally, orig_total_lines)
3087 (orig_top_line): Remove from window structure.
3088 (set_window_height, set_window_width, change_window_heights)
3089 (Fdelete_window): Remove prototypes.
3090 (resize_frame_windows): Remove duplicate declaration.
3091
3092 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3093
3094 * window.h (resize_frame_windows, resize_window_check)
3095 (delete_deletable_window, resize_root_window)
3096 (resize_frame_windows): Declare prototypes.
3097
3098 * window.c (resize_window_apply): Make definition be "static" to
3099 match the prototype.
3100
3101 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3102
3103 * window.c: Remove declarations of Qwindow_size_fixed,
3104 window_min_size_1, window_min_size_2, window_min_size,
3105 size_window, window_fixed_size_p, enlarge_window, delete_window.
3106 Remove static from declaration of Qdelete_window, it's
3107 temporarily needed by Fbury_buffer.
3108 (replace_window): Don't assign orig_top_line and
3109 orig_total_lines.
3110 (Fdelete_window, delete_window): Remove. Window deletion is
3111 handled by window.el.
3112 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3113 Replace Fdelete_window calls with calls to Qdelete_window.
3114 (Fdelete_other_windows): Remove. Deleting other windows is
3115 handled by window.el.
3116 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3117 handled in window.el.
3118 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3119 Window minimum sizes are handled in window.el.
3120 (shrink_windows, size_window, set_window_height)
3121 (set_window_width, change_window_heights, window_height)
3122 (window_width, CURBEG, CURSIZE, enlarge_window)
3123 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3124 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3125 handled in window.el.
3126 (make_dummy_parent): Rename to make_parent_window and give it a
3127 second argument horflag.
3128 (make_window): Don't set resize_proportionally any more.
3129 (Fsplit_window): Remove. Windows are split in window.el.
3130 (save_restore_action, save_restore_orig_size)
3131 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3132 Resize mini windows in window.el.
3133 (grow_mini_window, shrink_mini_window): Implement by calling
3134 Qresize_root_window_vertically, resize_window_check and
3135 resize_window_apply.
3136 (saved_window, Fset_window_configuration, save_window_save):
3137 Do not handle orig_top_line, orig_total_lines, and
3138 resize_proportionally.
3139 (window_min_height, window_min_width): Move to window.el.
3140 (keys_of_window): Move bindings for delete-other-windows,
3141 split-window, delete-window and enlarge-window to window.el.
3142
3143 * buffer.c: Temporarily extern Qdelete_window.
3144 (Fbury_buffer): Temporarily call Qdelete_window instead of
3145 Fdelete_window (Fbury_buffer will move to window.el soon).
3146
3147 * frame.c (set_menu_bar_lines_1): Remove code handling
3148 orig_top_line and orig_total_lines.
3149
3150 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3151 set_window_height but set heights directly.
3152 (change_frame_size_1): Use resize_frame_windows.
3153
3154 * xdisp.c (init_xdisp): Don't use set_window_height but set
3155 heights directly.
3156
3157 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3158 Use resize_frame_windows instead of change_window_heights and run
3159 run_window_configuration_change_hook.
3160
3161 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3162 instead of change_window_heights and run
3163 run_window_configuration_change_hook.
3164
3165 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3166
3167 * window.c (replace_window): Rename second argument REPLACEMENT to
3168 NEW. New third argument SETFLAG. Rewrite.
3169 (delete_window, make_dummy_parent): Call replace_window with
3170 third argument 1.
3171 (window_list_1): Move down in code.
3172 (run_window_configuration_change_hook): Move set_buffer part
3173 before select_frame_norecord part in order to unwind correctly.
3174 Rename count1 to count.
3175 (recombine_windows, delete_deletable_window, resize_root_window)
3176 (Fdelete_other_windows_internal)
3177 (Frun_window_configuration_change_hook, make_parent_window)
3178 (resize_window_check, resize_window_apply, Fresize_window_apply)
3179 (resize_frame_windows, Fsplit_window_internal)
3180 (Fdelete_window_internal, Fresize_mini_window_internal):
3181 New functions.
3182 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3183
3184 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3185
3186 * window.h (window): Add some new members to window structure -
3187 normal_lines, normal_cols, new_total, new_normal, clone_number,
3188 splits, nest, prev_buffers, next_buffers.
3189 (WINDOW_TOTAL_SIZE): Move here from window.c.
3190 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3191
3192 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3193 Remove.
3194 (make_dummy_parent): Set new members of windows structure.
3195 (make_window): Move down in code. Handle new members of window
3196 structure.
3197 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3198 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3199 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3200 (Fset_window_prev_buffers, Fwindow_next_buffers)
3201 (Fset_window_next_buffers, Fset_window_clone_number):
3202 New functions.
3203 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3204 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3205 Doc-string fixes.
3206 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3207 Argument WINDOW can be now internal window too.
3208 (Fwindow_use_time): Move up in code.
3209 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3210 Rewrite doc-string.
3211 (Fset_window_configuration, saved_window)
3212 (Fcurrent_window_configuration, save_window_save): Handle new
3213 members of window structure.
3214 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3215 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3216 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3217 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3218 Qget_mru_window, Qresize_root_window,
3219 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3220 Qauto_buffer_name; staticpro them.
3221
3222 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3223
3224 * window.c (Fwindow_total_size, Fwindow_left_column)
3225 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3226 (Fwindow_list_1): New functions.
3227 (window_box_text_cols): Replace with window_body_cols.
3228 (Fwindow_width, Fscroll_left, Fscroll_right):
3229 Use window_body_cols instead of window_box_text_cols.
3230 (delete_window, Fset_window_configuration):
3231 Call delete_all_subwindows with window as argument.
3232 (delete_all_subwindows): Take a window as argument and not a
3233 structure. Rewrite.
3234 (window_loop): Remove handling of GET_LRU_WINDOW and
3235 GET_LARGEST_WINDOW.
3236 (Fget_lru_window, Fget_largest_window): Move to window.el.
3237
3238 * window.h: Extern window_body_cols instead of
3239 window_box_text_cols. delete_all_subwindows now takes a
3240 Lisp_Object as argument.
3241
3242 * indent.c (compute_motion, Fcompute_motion):
3243 Use window_body_cols instead of window_box_text_cols.
3244
3245 * frame.c (delete_frame): Call delete_all_subwindows with root
3246 window as argument.
3247
3248 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3249
3250 * fns.c (Fputhash): Document return value.
3251
3252 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3253
3254 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3255
3256 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3257
3258 Cons<->int and similar integer overflow fixes (Bug#8794).
3259
3260 Check for overflow when converting integer to cons and back.
3261 * charset.c (Fdefine_charset_internal, Fdecode_char):
3262 Use cons_to_unsigned to catch overflow.
3263 (Fencode_char): Use INTEGER_TO_CONS.
3264 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3265 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3266 * data.c (long_to_cons, cons_to_long): Remove.
3267 (cons_to_unsigned, cons_to_signed): New functions.
3268 These signal an error for invalid or out-of-range values.
3269 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3270 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3271 * font.c (Ffont_variation_glyphs):
3272 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3273 * lisp.h: Include <intprops.h>.
3274 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3275 (cons_to_signed, cons_to_unsigned): New decls.
3276 (long_to_cons, cons_to_long): Remove decls.
3277 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3278 (Fprimitive_undo): Use CONS_TO_INTEGER.
3279 * xfns.c (Fx_window_property): Likewise.
3280 * xselect.c: Include <limits.h>.
3281 (x_own_selection, selection_data_to_lisp_data):
3282 Use INTEGER_TO_CONS.
3283 (x_handle_selection_request, x_handle_selection_clear)
3284 (x_get_foreign_selection, Fx_disown_selection_internal)
3285 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3286 (lisp_data_to_selection_data): Use cons_to_unsigned.
3287 (x_fill_property_data): Use cons_to_signed.
3288 Report values out of range.
3289
3290 Check for buffer and string overflow more precisely.
3291 * buffer.h (BUF_BYTES_MAX): New macro.
3292 * lisp.h (STRING_BYTES_MAX): New macro.
3293 * alloc.c (Fmake_string):
3294 * character.c (string_escape_byte8):
3295 * coding.c (coding_alloc_by_realloc):
3296 * doprnt.c (doprnt):
3297 * editfns.c (Fformat):
3298 * eval.c (verror):
3299 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3300 since they may not be the same number.
3301 * editfns.c (Finsert_char):
3302 * fileio.c (Finsert_file_contents):
3303 Likewise for BUF_BYTES_MAX.
3304
3305 * image.c: Use ptrdiff_t, not int, for sizes.
3306 (slurp_file): Switch from int to ptrdiff_t.
3307 All uses changed.
3308 (slurp_file): Check that file size fits in both size_t (for
3309 malloc) and ptrdiff_t (for sanity and safety).
3310
3311 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3312 if b->modtime has its maximal value.
3313
3314 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3315
3316 Don't assume time_t can fit into int.
3317 * buffer.h (struct buffer.modtime): Now time_t, not int.
3318 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3319 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3320
3321 Minor fixes for signed vs unsigned integers.
3322 * character.h (MAYBE_UNIFY_CHAR):
3323 * charset.c (maybe_unify_char):
3324 * keyboard.c (read_char, reorder_modifiers):
3325 XINT -> XFASTINT, since the integer must be nonnegative.
3326 * ftfont.c (ftfont_spec_pattern):
3327 * keymap.c (access_keymap, silly_event_symbol_error):
3328 XUINT -> XFASTINT, since the integer must be nonnegative.
3329 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3330 since it makes no difference and we prefer signed.
3331 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3332 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3333 nonnegative.
3334
3335 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3336
3337 * window.h (Fwindow_frame): Declare.
3338
3339 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3340
3341 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3342 (SPARE_MEMORY): Always define.
3343 (LARGE_REQUEST): Remove.
3344 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3345
3346 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3347
3348 * lisp.h: Move EXFUNS for Fframe_root_window,
3349 Fframe_first_window and Fset_frame_selected_window to window.h.
3350
3351 * window.h: Move EXFUNS for Fframe_root_window,
3352 Fframe_first_window and Fset_frame_selected_window here from
3353 lisp.h.
3354
3355 * frame.c (Fwindow_frame, Fframe_first_window)
3356 (Fframe_root_window, Fframe_selected_window)
3357 (Fset_frame_selected_window): Move to window.c.
3358 (Factive_minibuffer_window): Move to minibuf.c.
3359 (Fother_visible_frames_p): New function.
3360
3361 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3362
3363 * window.c (decode_window, decode_any_window): Move up in code.
3364 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3365 (inhibit_frame_unsplittable): Remove unused variable.
3366 (Fwindow_buffer): Move up and rewrite doc-string.
3367 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3368 (Fwindow_prev): New functions.
3369 (Fwindow_frame): Move here from frame.c. Accept any window as
3370 argument.
3371 (Fframe_root_window, Fframe_first_window)
3372 (Fframe_selected_window): Move here from frame.c. Accept frame
3373 or arbitrary window as argument. Update doc-strings.
3374 (Fminibuffer_window): Move up in code.
3375 (Fwindow_minibuffer_p): Move up in code and simplify.
3376 (Fset_frame_selected_window): Move here from frame.c.
3377 Marginal rewrite.
3378 (Fselected_window, select_window, Fselect_window): Move up in
3379 code. Minor doc-string fixes.
3380
3381 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3382
3383 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3384 Do not assume that spare memory exists; that assumption is valid
3385 only if SYSTEM_MALLOC.
3386 (LARGE_REQUEST): New macro, so that the issue of large requests
3387 is separated from the issue of spare memory.
3388
3389 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3390
3391 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3392 format. (Bug#8806)
3393
3394 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3395
3396 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3397 before statements.
3398
3399 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3400
3401 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3402
3403 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3404
3405 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3406 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3407
3408 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3409
3410 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3411
3412 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3413
3414 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3415 (x_clipboard_manager_save): Add return value.
3416 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3417 New error handlers.
3418 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3419 Obey Vx_select_enable_clipboard_manager. Catch errors in
3420 x_clipboard_manager_save (Bug#8779).
3421 (Vx_select_enable_clipboard_manager): New variable.
3422 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3423
3424 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3425
3426 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3427
3428 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3429
3430 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3431 in the current matrix if keep_current_p is non-zero.
3432
3433 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3434
3435 * bidi.c (bidi_level_of_next_char): Fix last change.
3436
3437 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3438
3439 Support bidi reordering of text covered by display properties.
3440
3441 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3442 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3443 (bidi_cache_search, bidi_cache_iterator_state)
3444 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3445 (bidi_level_of_next_char, bidi_move_to_visually_next):
3446 Support character positions inside a run of characters covered by a
3447 display string.
3448 (bidi_paragraph_init, bidi_resolve_explicit_1)
3449 (bidi_level_of_next_char): Call bidi_fetch_char and
3450 bidi_fetch_char_advance instead of FETCH_CHAR and
3451 FETCH_CHAR_ADVANCE.
3452 (bidi_init_it): Initialize new members.
3453 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3454 definitions.
3455 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3456 instead of using explicit *_CHAR codes.
3457 (bidi_resolve_explicit, bidi_resolve_weak):
3458 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3459 bidirectional text is supported only in multibyte buffers.
3460 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3461 it to initialize the frame_window_p member of struct bidi_it.
3462 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3463 (bidi_resolve_explicit, bidi_resolve_weak)
3464 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3465 bidi_it->nchars is non-positive.
3466 (bidi_level_of_next_char): Don't try to lookup the cache for the
3467 next/previous character if nothing is cached there yet, or if we
3468 were just reseat()'ed to a new position.
3469
3470 * xdisp.c (set_cursor_from_row): Set start and stop points
3471 according to the row's direction when priming the loop that looks
3472 for the glyph on which to display cursor.
3473 (single_display_spec_intangible_p): Function deleted.
3474 (display_prop_intangible_p): Reimplement to call
3475 handle_display_spec instead of single_display_spec_intangible_p.
3476 Accept 3 additional arguments needed by handle_display_spec.
3477 This fixes incorrect cursor motion across display property with complex
3478 values: lists, `(when COND...)' forms, etc.
3479 (single_display_spec_string_p): Support property values that are
3480 lists with the argument STRING its top-level element.
3481 (display_prop_string_p): Fix the condition for processing a
3482 property that is a list to be consistent with handle_display_spec.
3483 (handle_display_spec): New function, refactored from the
3484 last portion of handle_display_prop.
3485 (compute_display_string_pos): Accept additional argument
3486 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3487 value of a `display' property is a "replacing spec".
3488 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3489 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3490 the display property, but just return a value indicating whether
3491 the display property will replace the characters it covers.
3492 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3493 frame_window_p members of struct bidi_it.
3494 (compute_display_string_pos, compute_display_string_end):
3495 New functions.
3496 (push_it): Accept second argument POSITION, where pop_it should
3497 jump to continue iteration.
3498 (reseat_1): Initialize bidi_it.disp_pos.
3499
3500 * keyboard.c (adjust_point_for_property): Adjust the call to
3501 display_prop_intangible_p to its new signature.
3502
3503 * dispextern.h (struct bidi_it): New member frame_window_p.
3504 (bidi_init_it): Update prototypes.
3505 (display_prop_intangible_p): Update prototype.
3506 (compute_display_string_pos, compute_display_string_end):
3507 Declare prototypes.
3508 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3509 EMACS_INT.
3510
3511 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3512
3513 Malloc failure behavior now depends on size of allocation.
3514 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3515 * lisp.h: Change signatures accordingly.
3516 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3517 All callers changed. (Bug#8762)
3518
3519 * gnutls.c: Use Emacs's memory allocators.
3520 Without this change, the gnutls library would invoke malloc etc.
3521 directly, which causes problems on non-SYNC_INPUT hosts, and which
3522 runs afoul of improving memory_full behavior. (Bug#8761)
3523 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3524 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3525 xfree instead of the default malloc, realloc, free.
3526 (Fgnutls_boot): No need to check for memory allocation failure,
3527 since xmalloc does that for us.
3528
3529 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3530 * category.c (hash_get_category_set):
3531 * ccl.c (ccl_driver):
3532 * charset.c (Fdefine_charset_internal):
3533 * charset.h (struct charset.hash_index):
3534 * composite.c (get_composition_id, gstring_lookup_cache)
3535 (composition_gstring_put_cache):
3536 * composite.h (struct composition.hash_index):
3537 * dispextern.h (struct image.hash):
3538 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3539 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3540 (hashfn_equal, hashfn_user_defined, make_hash_table)
3541 (maybe_resize_hash_table, hash_lookup, hash_put)
3542 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3543 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3544 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3545 * image.c (make_image, search_image_cache, lookup_image)
3546 (xpm_put_color_table_h):
3547 * lisp.h (struct Lisp_Hash_Table):
3548 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3549 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3550 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3551 * alloc.c (allocate_vectorlike):
3552 Check for overflow in vector size calculations.
3553 * ccl.c (ccl_driver):
3554 Check for overflow when converting EMACS_INT to int.
3555 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3556 need to be updated by these changes.
3557 * fns.c (make_hash_table, maybe_resize_hash_table):
3558 Check for integer overflow with large hash tables.
3559 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3560 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3561 (SXHASH_REDUCE): New macro.
3562 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3563 Use it instead of discarding useful hash info with large hash values.
3564 (sxhash_float): New function.
3565 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3566 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3567 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3568 Rewrite to use FIXNUM_BITS, as this simplifies things.
3569 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3570 Adjust signatures to match updated version of code.
3571 (consing_since_gc): Now EMACS_INT, since a single hash table can
3572 use more than INT_MAX bytes.
3573
3574 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3575
3576 Make it possible to build with GCC-4.6+ -O2 -flto.
3577
3578 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3579
3580 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3581
3582 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3583 Call minibuffer-inactive-mode.
3584
3585 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3586
3587 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3588 Update dependencies.
3589
3590 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3591
3592 * data.c (init_data): Remove code for UTS, this system is not
3593 supported anymore.
3594
3595 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3596
3597 Don't force ./temacs to start in terminal mode.
3598
3599 * frame.c (make_initial_frame): Initialize faces in all cases, not
3600 only when CANNOT_DUMP is defined.
3601 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3602
3603 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3604
3605 * dispnew.c (add_window_display_history): Use const for the string
3606 pointer. Remove declaration, not needed.
3607
3608 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3609
3610 Use 'inline', not 'INLINE'.
3611 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3612 * alloc.c, fontset.c (INLINE): Remove.
3613 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3614 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3615 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3616 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3617 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3618
3619 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3620
3621 Make it possible to run ./temacs.
3622
3623 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3624 syms_of_callproc does the same thing. Remove test for
3625 "initialized", do it in the caller.
3626 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3627
3628 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3629
3630 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3631 (read_minibuf): Use get_minibuffer.
3632 (syms_of_minibuf): Use DEFSYM.
3633 (Qmetadata): New var.
3634 * data.c (Qbuffer): Don't make it static.
3635 (syms_of_data): Use DEFSYM.
3636
3637 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3638
3639 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3640 (CCL_CODE_MIN): New macro.
3641
3642 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3643
3644 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3645
3646 * eval.c (Qdebug): Now static.
3647 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3648 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3649 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3650
3651 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3652
3653 * image.c: Various fixes to ImageMagick code comments.
3654 (Fimagemagick_types): Doc fix.
3655
3656 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3657
3658 Minor fixes prompted by GCC 4.6.0 warnings.
3659
3660 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3661
3662 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3663 (x_clipboard_manager_save_all): Move extern decl to ...
3664 * xterm.h: ... here, so that it can be checked for consistency.
3665
3666 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3667
3668 * xselect.c (x_clipboard_manager_save_frame)
3669 (x_clipboard_manager_save_all): New functions.
3670 (Fx_clipboard_manager_save): Lisp function deleted.
3671
3672 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3673 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3674
3675 * xterm.h: Update prototype.
3676
3677 2011-05-28 William Xu <william.xwl@gmail.com>
3678
3679 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3680 exiting (Bug#8239).
3681
3682 2011-05-28 Jim Meyering <meyering@redhat.com>
3683
3684 Avoid a sign-extension bug in crypto_hash_function.
3685 * fns.c (to_uchar): Define.
3686 (crypto_hash_function): Use it to convert some newly-signed
3687 variables to unsigned, to avoid sign-extension bugs. For example,
3688 without this change, (md5 "truc") would evaluate to
3689 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3690 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3691 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3692
3693 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3694
3695 Integer overflow fixes.
3696
3697 * dbusbind.c: Serial number integer overflow fixes.
3698 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3699 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3700 to hold a serial number that is too large for a fixnum.
3701 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3702 Check for serial numbers out of range. Decode any serial number
3703 that was so large that it became a float. (Bug#8722)
3704
3705 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3706 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3707 Use XFASTINT rather than XUINT when numbers are nonnegative.
3708 (xd_append_arg, Fdbus_method_return_internal):
3709 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3710 arguments, check that Lisp number is nonnegative, rather than
3711 silently wrapping negative numbers around. (Bug#8722)
3712 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3713 (Bug#8722)
3714
3715 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3716
3717 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3718
3719 ccl: add integer overflow checks
3720 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3721 (IN_INT_RANGE): New macros.
3722 (ccl_driver): Use them to check for integer overflow when
3723 decoding a CCL program. Many of the new checks are whether XINT (x)
3724 fits in int; it doesn't always, on 64-bit hosts. The new version
3725 doesn't catch all possible integer overflows, but it's an
3726 improvement. (Bug#8719)
3727
3728 * alloc.c (make_event_array): Use XINT, not XUINT.
3729 There's no need for unsigned here.
3730
3731 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3732 This follows up to the 2011-05-06 change that substituted uintptr_t
3733 for EMACS_INT. This case wasn't caught back then.
3734
3735 Rework Fformat to avoid integer overflow issues.
3736 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3737 now (part of C89). Include <verify.h>.
3738 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3739 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3740 (Fformat): Avoid the prepass trying to compute sizes; it was only
3741 approximate and thus did not catch overflow reliably. Instead, walk
3742 through the format just once, formatting and computing sizes as we go,
3743 checking for integer overflow at every step, and allocating a larger
3744 buffer as needed. Keep track separately whether the format is
3745 multibyte. Keep only the most-recently calculated precision, rather
3746 than them all. Record whether each argument has been converted to
3747 string. Use EMACS_INT, not int, for byte and char and arg counts.
3748 Support field widths and precisions larger than INT_MAX. Avoid
3749 sprintf's undefined behavior with conversion specifications such as %#d
3750 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3751 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3752 formatting out-of-range floating point numbers with int
3753 formats. (Bug#8668)
3754
3755 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3756
3757 * data.c: Avoid integer truncation in expressions involving floats.
3758 * data.c: Include <intprops.h>.
3759 (arith_driver): When there's an integer overflow in an expression
3760 involving floating point, convert the integers to floating point
3761 so that the resulting value does not suffer from catastrophic
3762 integer truncation. For example, on a 64-bit host (* 4
3763 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3764 Do not rely on undefined behavior after integer overflow.
3765
3766 merge count_size_as_multibyte, parse_str_to_multibyte
3767 * character.c, character.h (count_size_as_multibyte):
3768 Rename from parse_str_to_multibyte; all uses changed.
3769 Check for integer overflow.
3770 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3771 since it's now a duplicate of the other. This is more of
3772 a character than a buffer op, so better that it's in character.c.
3773 * fns.c, print.c: Adjust to above changes.
3774
3775 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3776
3777 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3778
3779 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3780
3781 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3782 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3783 (x_clipboard_manager_save): Now static.
3784 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3785
3786 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3787 (crypto_hash_function): Now static.
3788 Fix pointer signedness problems. Avoid unnecessary initializations.
3789
3790 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3791
3792 * termhooks.h (Vselection_alist): Make it terminal-local.
3793
3794 * terminal.c (create_terminal): Initialize it.
3795
3796 * xselect.c: Support for clipboard managers.
3797 (Vselection_alist): Move to termhooks.h as terminal-local var.
3798 (LOCAL_SELECTION): New macro.
3799 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3800 (symbol_to_x_atom): Remove gratuitous arg.
3801 (x_handle_selection_request, lisp_data_to_selection_data)
3802 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3803 (x_own_selection, x_get_local_selection, x_convert_selection):
3804 New arg, specifying work frame. Use terminal-local Vselection_alist.
3805 (some_frame_on_display): Delete unused function.
3806 (Fx_own_selection_internal, Fx_get_selection_internal)
3807 (Fx_disown_selection_internal, Fx_selection_owner_p)
3808 (Fx_selection_exists_p): New optional frame arg.
3809 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3810 (x_handle_selection_clear): Don't treat other terminals with the
3811 same keyboard specially. Use the terminal-local Vselection_alist.
3812 (x_clear_frame_selections): Use Frun_hook_with_args.
3813
3814 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3815
3816 * xterm.h: Add support for those atoms.
3817
3818 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3819
3820 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3821 (converted_selections, conversion_fail_tag): New global variables.
3822 (x_selection_request_lisp_error): Free the above.
3823 (x_get_local_selection): Remove unnecessary code.
3824 (x_reply_selection_request): Args changed; handle arbitrary array
3825 of converted selections stored in converted_selections.
3826 Separate the XChangeProperty and SelectionNotify steps.
3827 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3828 (x_convert_selection): New function.
3829 (x_handle_selection_event): Simplify.
3830 (x_get_foreign_selection): Don't ignore incoming requests while
3831 waiting for an answer; this will fail when we implement
3832 SAVE_TARGETS, and seems unnecessary anyway.
3833 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3834 (Vx_sent_selection_functions): Doc fix.
3835
3836 2011-05-26 Leo Liu <sdl.web@gmail.com>
3837
3838 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3839
3840 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3841
3842 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3843
3844 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3845 for fringe update if it has periodic bitmap.
3846 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3847 and fringe_bitmap_periodic_p.
3848
3849 * fringe.c (get_fringe_bitmap_data): New function.
3850 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3851 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3852 row. Mark glyph row for fringe update if periodicity changed.
3853
3854 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3855 for fringe update unless it has periodic bitmap.
3856
3857 2011-05-25 Kenichi Handa <handa@m17n.org>
3858
3859 * xdisp.c (get_next_display_element): Set correct it->face_id for
3860 a static composition.
3861
3862 2011-05-24 Leo Liu <sdl.web@gmail.com>
3863
3864 * deps.mk (fns.o):
3865 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3866
3867 * fns.c (crypto_hash_function, Fsha1): New function.
3868 (Fmd5): Use crypto_hash_function.
3869 (syms_of_fns): Add Ssha1.
3870
3871 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 * gnutls.c: Remove unused macros.
3874 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3875 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3876 Remove macros that are defined and never used.
3877 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3878
3879 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3880
3881 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3882 (Fx_get_selection_internal): Minor cleanup.
3883 (Fx_own_selection_internal): Rename arguments for consistency with
3884 select.el.
3885
3886 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3887
3888 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3889
3890 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3891
3892 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3893
3894 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3895
3896 * dispnew.c (scrolling_window): Don't exclude the case that the
3897 last enabled row in the desired matrix touches the bottom boundary.
3898
3899 2011-05-21 Glenn Morris <rgm@gnu.org>
3900
3901 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3902 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3903 and add some more files.
3904
3905 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3906
3907 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3908 report_file_error introduced by the change from 2011-05-07.
3909
3910 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3911
3912 * systime.h (Time): Define only if emacs is defined.
3913 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3914 where the include path doesn't have X11/X.h by default. See
3915 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3916
3917 2011-05-20 Kenichi Handa <handa@m17n.org>
3918
3919 * composite.c (find_automatic_composition): Fix previous change.
3920
3921 2011-05-20 Glenn Morris <rgm@gnu.org>
3922
3923 * lisp.mk: New file, split from Makefile.in.
3924 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3925 (shortlisp): Remove.
3926 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3927
3928 2011-05-19 Glenn Morris <rgm@gnu.org>
3929
3930 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3931 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3932 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3933 (lisp): Set the order to that of loadup.el.
3934 (shortlisp): Make it a copy of $lisp.
3935 (SOME_MACHINE_LISP): Remove.
3936 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3937 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3938
3939 2011-05-18 Kenichi Handa <handa@m17n.org>
3940
3941 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3942 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3943 (find_automatic_composition): Mostly rewrite for efficiency.
3944
3945 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3946
3947 * makefile.w32-in: Update dependencies.
3948
3949 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3950
3951 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3952 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3953
3954 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3955
3956 Fix some integer overflow issues, such as string length overflow.
3957
3958 * insdel.c (count_size_as_multibyte): Check for string overflow.
3959
3960 * character.c (lisp_string_width): Check for string overflow.
3961 Use EMACS_INT, not int, for string indexes and lengths; in
3962 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3963 the resulting string length overflows an EMACS_INT; instead,
3964 report a string overflow if no precision given. When checking for
3965 precision exhaustion, use a check that cannot possibly have
3966 integer overflow. (Bug#8675)
3967 * character.h (lisp_string_width): Adjust to new signature.
3968
3969 * alloc.c (string_overflow): New function.
3970 (Fmake_string): Use it. This doesn't change behavior, but saves
3971 a few bytes and will simplify future changes.
3972 * character.c (string_escape_byte8): Likewise.
3973 * lisp.h (string_overflow): New decl.
3974
3975 Fixups, following up to the user-interface timestamp change.
3976 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3977 for UI timestamps, instead of unsigned long.
3978 * msdos.c (mouse_get_pos): Likewise.
3979 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3980 * w32gui.h (Time): Define by including "systime.h" rather than by
3981 declaring it ourselves. (Bug#8664)
3982
3983 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3984 * image.c (clear_image_cache): Likewise.
3985
3986 * term.c (term_mouse_position): Don't assume time_t wraparound.
3987
3988 Be more systematic about user-interface timestamps.
3989 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3990 and sometimes 'EMACS_UINT', to represent these timestamps.
3991 This change causes it to use 'Time' uniformly, as that's what X uses.
3992 This makes the code easier to follow, and makes it easier to catch
3993 integer overflow bugs such as Bug#8664.
3994 * frame.c (Fmouse_position, Fmouse_pixel_position):
3995 Use Time, not unsigned long, for user-interface timestamps.
3996 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3997 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3998 * keyboard.h (last_event_timestamp): Likewise.
3999 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4000 * menu.h (xmenu_show): Likewise.
4001 * term.c (term_mouse_position): Likewise.
4002 * termhooks.h (struct input_event.timestamp): Likewise.
4003 (struct terminal.mouse_position_hook): Likewise.
4004 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4005 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4006 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4007 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4008 what it was before.
4009 * menu.h, termhooks.h: Include "systime.h", for Time.
4010
4011 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4012 Don't assume that the difference between two unsigned long values
4013 can fit into an integer. At this point, we know button_down_time
4014 <= event->timestamp, so the difference must be nonnegative, so
4015 there's no need to cast the result if double-click-time is
4016 nonnegative, as it should be; check that it's nonnegative, just in
4017 case. This bug is triggered when events are more than 2**31 ms
4018 apart (about 25 days). (Bug#8664)
4019
4020 * xselect.c (last_event_timestamp): Remove duplicate decl.
4021 (x_own_selection): Remove needless cast to unsigned long.
4022
4023 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4024 that always fit in int. Use a sentinel instead of a counter, to
4025 avoid a temp and to allay GCC's concerns about possible int overflow.
4026 * frame.h (struct frame): Use int for menu_bar_items_used
4027 instead of EMACS_INT, since it always fits in int.
4028
4029 * menu.c (grow_menu_items): Check for int overflow.
4030
4031 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4032
4033 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4034 Before, the code was not consistent. These values cannot exceed
4035 2**31 - 1 so there's no need to make them unsigned.
4036 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4037 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4038 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4039 as modifiers.
4040 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4041
4042 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4043 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4044 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4045 presumably because the widths might not match.
4046
4047 * window.c (size_window): Avoid needless test at loop start.
4048
4049 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4050
4051 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4052
4053 2011-05-12 Drew Adams <drew.adams@oracle.com>
4054
4055 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4056
4057 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4058
4059 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4060 `width' to `bar_area_x' and `bar_area_width', respectively.
4061 (x_scroll_run): Take account of fringe background extension.
4062
4063 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4064 Rename local vars `left' and `width' to `bar_area_x' and
4065 `bar_area_width', respectively.
4066 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4067 background extension.
4068
4069 2011-05-10 Jim Meyering <meyering@redhat.com>
4070
4071 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4072
4073 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4074
4075 * image.c (Finit_image_library): Return t for built-in image types,
4076 like pbm and xbm. (Bug#8640)
4077
4078 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4079
4080 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4081
4082 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4083
4084 * w32console.c (Fset_screen_color): Doc fix.
4085 (Fget_screen_color): New function.
4086 (syms_of_ntterm): Defsubr it.
4087
4088 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4089 unlink the temporary file if Fcall_process didn't create it in the
4090 first place.
4091 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4092 child process will be redirected to a file specified with `:file'.
4093 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4094 cue to call_process_cleanup not to close that handle.
4095
4096 2011-05-07 Ben Key <bkey76@gmail.com>
4097
4098 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4099 one of two shell specific rules, either bootstrap-temacs-CMD or
4100 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4101 to the previous implementation of the bootstrap-temacs rule.
4102 The bootstrap-temacs-CMD rule is similar to the previous
4103 implementation of the bootstrap-temacs rule except that it
4104 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4105 variable.
4106
4107 These changes, along with some changes to nt/configure.bat,
4108 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4109 earlier fix to add support for --cflags and --ldflags options
4110 that include quotes so that it works whether make uses cmd or
4111 sh as the shell.
4112
4113 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4114
4115 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4116 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4117 is a constant.
4118 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4119 a string. Handle both cases.
4120 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4121 (Fdbus_register_method): Use Qinvalid_function.
4122
4123 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4124
4125 * makefile.w32-in: Update dependencies.
4126 (LISP_H): Add inttypes.h and stdin.h.
4127 (PROCESS_H): Add unistd.h.
4128
4129 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4130
4131 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4132 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4133
4134 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4135
4136 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4137
4138 * term.c (vfatal): Remove stray call to va_end.
4139 It's not needed and the C Standard doesn't allow it here anyway.
4140
4141 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4142 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4143
4144 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4145 bytes.
4146
4147 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4148
4149 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4150
4151 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4152
4153 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4154
4155 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4156
4157 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4158 * charset.c (Fdefine_charset_internal): Don't initialize
4159 charset.code_space[15]. The value was garbage, on hosts with
4160 32-bit int (Bug#8600).
4161
4162 * lread.c (read_integer): Be more consistent with string-to-number.
4163 Use string_to_number to do the actual conversion; this avoids
4164 rounding errors and fixes some other screwups. Without this fix,
4165 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4166 (digit_to_number): Move earlier, for benefit of read_integer.
4167 Return -1 if the digit is out of range for the base, -2 if it is
4168 not a digit in any supported base. (Bug#8602)
4169
4170 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4171
4172 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4173 to match comment at start of function. This also removes a
4174 GCC warning about overflow in a 32+64-bit port.
4175
4176 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4177
4178 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4179 Reported by Stefan Monnier in
4180 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4181 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4182 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4183
4184 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4185 (EMACS_UINTPTR): Likewise, with uintptr_t.
4186
4187 * lisp.h: Prefer 64-bit EMACS_INT if available.
4188 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4189 on 32-bit hosts that have 64-bit int, so that they can access
4190 large files.
4191 However, temporarily disable this change unless the temporary
4192 symbol WIDE_EMACS_INT is defined.
4193
4194 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4195
4196 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4197 This removes an assumption that EMACS_INT and long are the same
4198 width as pointers. The assumption is true for Emacs porting targets
4199 now, but we want to make other targets possible.
4200 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4201 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4202 In the rest of the code, change types of integers that hold casted
4203 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4204 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4205 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4206 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4207 No need to cast type when ORing.
4208 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4209 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4210 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4211 assume EMACS_INT is the same width as char *.
4212 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4213 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4214 Remove no-longer-needed casts.
4215 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4216 (xg_tool_bar_help_callback, xg_make_tool_item):
4217 Use EMACS_INTPTR to hold an integer
4218 that will be cast to void *; this can avoid a GCC warning
4219 if EMACS_INT is not the same width as void *.
4220 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4221 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4222 (current_message_1, set_message_1):
4223 Use a local to convert to proper width without a cast.
4224 * xmenu.c (dialog_selection_callback): Likewise.
4225
4226 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4227 Also, don't assume VALBITS / RAND_BITS is less than 5,
4228 and don't rely on undefined behavior when shifting a 1 left into
4229 the sign bit.
4230 * lisp.h (get_random): Change signature to match.
4231
4232 * lread.c (hash_string): Use size_t, not int, for hash computation.
4233 Normally we prefer signed values; but hashing is special, because
4234 it's better to use unsigned division on hash table sizes so that
4235 the remainder is nonnegative. Also, size_t is the natural width
4236 for hashing into memory. The previous code used 'int', which doesn't
4237 retain enough info to hash well into very large tables.
4238 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4239
4240 * dbusbind.c: Don't possibly lose pointer info when converting.
4241 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4242 Use XPNTR rather than XHASH, so that the high-order bits of
4243 the pointer aren't lost when converting through void *.
4244
4245 * eval.c (Fautoload): Don't double-shift a pointer.
4246
4247 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4248
4249 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4250
4251 * gnutls.c (DEF_GNUTLS_FN):
4252 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4253
4254 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4255
4256 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4257 marker. (Bug#8610)
4258
4259 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4260
4261 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4262 New version that can reserve upto 2GB of heap space.
4263
4264 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4265
4266 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4267
4268 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4269
4270 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4271 `gnutls_certificate_set_x509_key_file'.
4272
4273 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4274
4275 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4276 Update dependencies.
4277
4278 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4279
4280 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4281 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4282 Remove unused parameter `fildes'.
4283 * process.c (read_process_output, send_process): Don't pass it.
4284
4285 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4286
4287 Fix previous change: the library cache is defined in w32.c.
4288 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4289 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4290
4291 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4292
4293 Implement dynamic loading of GnuTLS on Windows.
4294
4295 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4296 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4297 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4298 Declare.
4299
4300 * gnutls.c (Qgnutls_dll): Define.
4301 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4302 (gnutls_*): Declare function pointers.
4303 (init_gnutls_functions): New function to initialize function pointers.
4304 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4305 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4306 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4307 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4308 (emacs_gnutls_write, emacs_gnutls_read)
4309 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4310 (Fgnutls_available_p): New function.
4311 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4312 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4313 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4314
4315 * image.c: Include w32.h.
4316 (Vimage_type_cache): Delete.
4317 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4318 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4319 (w32_delayed_load): Move to w32.c.
4320
4321 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4322
4323 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4324 (w32_delayed_load): Move from image.c. When loading a library, record
4325 its filename in the :loaded-from property of the library id.
4326 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4327 Initialize and staticpro them.
4328 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4329
4330 * process.c: Include lisp.h before w32.h, not after.
4331 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4332 instead of gnutls_record_check_pending.
4333
4334 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4335
4336 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4337
4338 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4339 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4340 as passed in.
4341
4342 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4343
4344 * xterm.c (x_set_frame_alpha): Do not set property on anything
4345 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4346
4347 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4348
4349 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4350
4351 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4352
4353 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4354 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4355 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4356 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4357 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4358 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4359 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4360 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4361 (Qgnutls_bootprop_callbacks_verify): Make static.
4362
4363 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4364
4365 * callproc.c: Indentation fixup.
4366
4367 * sysdep.c (wait_for_termination_1): Make static.
4368 (wait_for_termination, interruptible_wait_for_termination):
4369 Move after wait_for_termination_1.
4370
4371 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4372
4373 * sysdep.c (interruptible_wait_for_termination): New function
4374 which is like wait_for_termination, but allows keyboard
4375 interruptions.
4376
4377 * callproc.c (Fcall_process): Add (:file "file") as an option for
4378 the STDOUT buffer.
4379 (Fcall_process_region): Ditto.
4380
4381 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4382
4383 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4384 rather than `XVECTOR (FOO)->size'.
4385
4386 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4387 inttypes.h, as a gnulib replacement is used if it not available in
4388 system headers.
4389
4390 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4391
4392 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4393 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4394 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4395
4396 * coding.c (coding_alloc_by_realloc): Error out if destination
4397 will grow beyond MOST_POSITIVE_FIXNUM.
4398 (decode_coding_emacs_mule): Abort if there isn't enough place in
4399 charbuf for the composition carryover bytes. Reserve an extra
4400 space for up to 2 characters produced in a loop.
4401 (decode_coding_iso_2022): Abort if there isn't enough place in
4402 charbuf for the composition carryover bytes.
4403
4404 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4405
4406 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4407 aborting when %lld or %lll format is passed.
4408 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4409 %llo or %llx format is passed. (Bug#8545)
4410
4411 * window.c (window_scroll_line_based): Use a marker instead of
4412 simple variables to record original value of point. (Bug#7952)
4413
4414 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4415 produced by %s or %c overflows available buffer space. (Bug#8545)
4416
4417 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4418
4419 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4420 (SIZE_MAX): Move defn after all includes, as they might #define it.
4421
4422 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4423
4424 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4425
4426 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4427
4428 * keyboard.c (Qdelayed_warnings_hook): Define.
4429 (command_loop_1): Run `delayed-warnings-hook'
4430 if Vdelayed_warnings_list is non-nil.
4431 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4432 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4433
4434 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4435
4436 * doprnt.c (doprnt): Don't return value smaller than the buffer
4437 size if the message was truncated. (Bug#8545).
4438
4439 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4440
4441 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4442 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4443
4444 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4445
4446 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4447
4448 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4449
4450 * makefile.w32-in: Update dependencies.
4451
4452 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4453
4454 Improve `doprnt' and its usage. (Bug#8545)
4455 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4456 `format_end'. Remove support for %l as a conversion specifier.
4457 Don't use xrealloc. Improve diagnostics when the %l size modifier
4458 is used. Update the commentary.
4459
4460 * eval.c (verror): Simplify calculation of size_t.
4461
4462 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4463 messages.
4464
4465 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4466
4467 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4468 change.
4469
4470 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4471
4472 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4473 This makes this file independent of the recent pseudovector change.
4474
4475 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4476
4477 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4478
4479 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4480 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4481 Remove unused local.
4482 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4483
4484 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4485 GCC 4.6.0 optimizes based on type-based alias analysis.
4486 For example, if b is of type struct buffer * and v of type struct
4487 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4488 != &v->size, and therefore "v->size = 1; b->size = 2; return
4489 v->size;" must therefore return 1. This assumption is incorrect
4490 for Emacs, since it type-puns struct Lisp_Vector * with many other
4491 types. To fix this problem, this patch adds a new type struct
4492 vectorlike_header that documents the constraints on layout of vectors
4493 and pseudovectors, and helps optimizing compilers not get fooled
4494 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4495 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4496 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4497 the size member.
4498 (XSETPVECTYPE): Rewrite in terms of new macro.
4499 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4500 This is a bit clearer, and further avoids the possibility of
4501 undesirable aliasing.
4502 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4503 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4504 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4505 since Lisp_Subr is a special case (no "next" field).
4506 (ASIZE): Now uses header.size rather than size.
4507 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4508 to avoid the hassle of writing XVECTOR (foo)->header.size.
4509 (struct vectorlike_header): New type.
4510 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4511 object, to help avoid aliasing.
4512 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4513 (SUBRP): Likewise, since Lisp_Subr is a special case.
4514 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4515 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4516 (struct Lisp_Hash_Table): Combine first two members into a single
4517 struct vectorlike_header member. All uses of "size" and "next" members
4518 changed to be "header.size" and "header.next".
4519 * buffer.h (struct buffer): Likewise.
4520 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4521 * frame.h (struct frame): Likewise.
4522 * process.h (struct Lisp_Process): Likewise.
4523 * termhooks.h (struct terminal): Likewise.
4524 * window.c (struct save_window_data, struct saved_window): Likewise.
4525 * window.h (struct window): Likewise.
4526 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4527 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4528 * buffer.c (init_buffer_once): Likewise.
4529 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4530 special case.
4531 * process.c (Fformat_network_address): Use local var for size,
4532 for brevity.
4533
4534 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4535
4536 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4537 * data.c (atof): Remove decl; no longer used or needed.
4538 (digit_to_number): Move to lread.c.
4539 (Fstring_to_number): Use new string_to_number function, to be
4540 consistent with how the Lisp reader treats infinities and NaNs.
4541 Do not assume that floating-point numbers represent EMACS_INT
4542 without losing information; this is not true on most 64-bit hosts.
4543 Avoid double-rounding errors, by insisting on integers when
4544 parsing non-base-10 numbers, as the documentation specifies.
4545 * lisp.h (string_to_number): New decl, replacing ...
4546 (isfloat_string): Remove.
4547 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4548 (read1): Do not accept +. and -. as integers; this
4549 appears to have been a coding error. Similarly, do not accept
4550 strings like +-1e0 as floating point numbers. Do not report
4551 overflow for integer overflows unless the base is not 10 which
4552 means we have no simple and reliable way to continue.
4553 Break out the floating-point parsing into a new
4554 function string_to_number, so that Fstring_to_number parses
4555 floating point numbers consistently with the Lisp reader.
4556 (digit_to_number): Move here from data.c. Make it static inline.
4557 (E_CHAR, EXP_INT): Remove, replacing with ...
4558 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4559 (string_to_number): New function, replacing isfloat_string.
4560 This function checks for valid syntax and produces the resulting
4561 Lisp float number too. Rework it so that string-to-number
4562 no longer mishandles examples like "1.0e+". Use strtoumax,
4563 so that overflow for non-base-10 numbers is reported only when
4564 there's no portable and simple way to convert to floating point.
4565
4566 * textprop.c (set_text_properties_1): Rewrite for clarity,
4567 and to avoid GCC warning about integer overflow.
4568
4569 * intervals.h (struct interval): Use EMACS_INT for members
4570 where EMACS_UINT might cause problems. See
4571 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4572 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4573 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4574 All uses changed.
4575 (offset_intervals): Tell GCC not to worry about length overflow
4576 when negating a negative length.
4577
4578 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4579 (overrun_check_free): Likewise.
4580
4581 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4582 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4583 word size.
4584
4585 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4586 (gnutls_make_error): Rename local to avoid shadowing.
4587 (gnutls_emacs_global_deinit): ifdef out; not used.
4588 (Fgnutls_boot): Use const for pointer to readonly storage.
4589 Comment out unused local. Fix pointer signedness problems.
4590
4591 * lread.c (openp): Don't stuff size_t into an 'int'.
4592 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4593 about possible signed overflow.
4594
4595 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4596 (GDK_KEY_g): Don't define if already defined.
4597 (xg_prepare_tooltip): Avoid pointer signedness problem.
4598 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4599
4600 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4601 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4602
4603 * xfns.c (Fx_window_property): Simplify a bit,
4604 to make a bit faster and to avoid GCC 4.6.0 warning.
4605 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4606
4607 * fns.c (internal_equal): Don't assume size_t fits in int.
4608
4609 * alloc.c (compact_small_strings): Tighten assertion a little.
4610
4611 Replace pEd with more-general pI, and fix some printf arg casts.
4612 * lisp.h (pI): New macro, generalizing old pEd macro to other
4613 conversion specifiers. For example, use "...%"pI"d..." rather
4614 than "...%"pEd"...".
4615 (pEd): Remove. All uses replaced with similar uses of pI.
4616 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4617 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4618 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4619 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4620 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4621 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4622 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4623 64-bit hosts.
4624 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4625 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4626 * print.c (safe_debug_print, print_object): Likewise.
4627 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4628 to int.
4629 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4630 avoiding the 0 flag, which is not portable.
4631 * process.c (Fmake_network_process): Use pI to avoid cast.
4632 * region-cache.c (pp_cache): Likewise.
4633 * xdisp.c (decode_mode_spec): Likewise.
4634 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4635 behavior on 64-bit hosts with printf arg.
4636 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4637 (x_stop_queuing_selection_requests): Likewise.
4638 (x_get_window_property): Don't truncate byte count to an 'int'
4639 when tracing.
4640
4641 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4642 here, since it parses constructs like leading '-' and spaces,
4643 which are not wanted; and it overflows with large numbers.
4644 Instead, simply match F[0-9]+, which is what is wanted anyway.
4645
4646 * alloc.c: Remove unportable assumptions about struct layout.
4647 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4648 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4649 (allocate_vectorlike, make_pure_vector): Use the new macros,
4650 plus offsetof, to remove unportable assumptions about struct layout.
4651 These assumptions hold on all porting targets that I know of, but
4652 they are not guaranteed, they're easy to remove, and removing them
4653 makes further changes easier.
4654
4655 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4656 This doesn't fix a bug but makes the code clearer.
4657 (string_overrun_cookie): Now const. Use initializers that
4658 don't formally overflow signed char, to avoid warnings.
4659 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4660 can cause Emacs to crash when string overrun checking is enabled.
4661 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4662 multiple of sizeof (EMACS_INT); it need not be, if
4663 alignof(EMACS_INT) < sizeof (EMACS_INT).
4664 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4665
4666 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4667
4668 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4669
4670 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4671
4672 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4673 supposed to be handshaking. (Bug#8556)
4674 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4675
4676 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4677
4678 * lisp.h (Qdebug): List symbol.
4679 * eval.c (Qdebug): Restore global linkage.
4680 * keyboard.c (debug-on-event): New variable.
4681 (handle_user_signal): Break into debugger when debug-on-event
4682 matches the current signal symbol.
4683
4684 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4685
4686 * alloc.c (check_sblock, check_string_bytes)
4687 (check_string_free_list): Convert to standard C.
4688
4689 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4690
4691 * w32.c (emacs_gnutls_push): Fix typo.
4692
4693 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4694
4695 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4696 "cast to pointer from integer of different size".
4697
4698 Improve doprnt and its use in verror. (Bug#8545)
4699 * doprnt.c (doprnt): Document the set of format control sequences
4700 supported by the function. Use SAFE_ALLOCA instead of always
4701 using `alloca'.
4702
4703 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4704 is one byte too soon. Don't use xrealloc; instead xfree and
4705 xmalloc anew.
4706
4707 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4708
4709 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4710 callbacks stage.
4711
4712 * gnutls.c: Renamed global_initialized to
4713 gnutls_global_initialized. Added internals for the
4714 :verify-hostname-error, :verify-error, and :verify-flags
4715 parameters of `gnutls-boot' and documented those parameters in the
4716 docstring. Start callback support.
4717 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4718 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4719 on error. Return error code.
4720 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4721 (emacs_gnutls_read): Likewise.
4722 (Fgnutls_boot): Return handshake error code.
4723 (emacs_gnutls_handle_error): New function.
4724 (wsaerror_to_errno): Likewise.
4725
4726 * w32.h (emacs_gnutls_pull): Add prototype.
4727 (emacs_gnutls_push): Likewise.
4728
4729 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4730 (emacs_gnutls_push): Likewise.
4731
4732 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4733
4734 * process.c (wait_reading_process_output): Check if GnuTLS
4735 buffered some data internally if no FDs are set for TLS
4736 connections.
4737
4738 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4739 (LIBS): Link to USER_LIBS.
4740 ($(BLD)/gnutls.$(0)): New target.
4741
4742 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4743
4744 * xdisp.c (handle_single_display_spec): Rename the
4745 display_replaced_before_p argument into display_replaced_p, to
4746 make it consistent with the commentary. Fix typos in the
4747 commentary.
4748
4749 * textprop.c (syms_of_textprop): Remove dead code.
4750 (copy_text_properties): Delete obsolete commentary about an
4751 interface that was deleted long ago. Fix typos in the description
4752 of arguments.
4753
4754 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4755 to changes in oldXMenu/XMenu.h from 2011-04-16.
4756 <menu_help_message, prev_menu_help_message>: Constify.
4757 (IT_menu_make_room): menu->help_text is now `const char **';
4758 adjust.
4759
4760 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4761 to changes in oldXMenu/XMenu.h from 2011-04-16.
4762 (struct XMenu): Declare `help_text' `const char **'.
4763
4764 * xfaces.c <Qunspecified>: Make extern again.
4765
4766 * syntax.c: Include sys/types.h before including regex.h, as
4767 required by Posix.
4768
4769 * doc.c (get_doc_string): Improve the format passed to `error'.
4770
4771 * doprnt.c (doprnt): Improve commentary.
4772
4773 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4774
4775 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4776 them with etags.
4777
4778 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4779 changes in globals.h immediately force recompilation.
4780 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4781 $(CURDIR)/s/ms-w32.h.
4782 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4783
4784 * character.c (Fchar_direction): Function deleted.
4785 (syms_of_character): Don't defsubr it.
4786 <char-direction-table>: Deleted.
4787
4788 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4789
4790 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4791 * doprnt.c: Include limits.h.
4792 (SIZE_MAX): New macro.
4793 (doprnt): Return a size_t value. 2nd arg is now size_t.
4794 Many local variables are now size_t instead of int or unsigned.
4795 Improve overflow protection. Support `l' modifier for integer
4796 conversions. Support %l conversion. Don't assume an EMACS_INT
4797 argument for integer conversions and for %c.
4798
4799 * lisp.h (doprnt): Restore prototype.
4800
4801 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4802 $(SRC)/character.h.
4803
4804 * Makefile.in (base_obj): Add back doprnt.o.
4805
4806 * deps.mk (doprnt.o): Add back prerequisites.
4807 (callint.o): Depend on character.h.
4808
4809 * eval.c (internal_lisp_condition_case): Include the handler
4810 representation in the error message.
4811 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4812 when breaking from the loop.
4813
4814 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4815
4816 * callint.c (Fcall_interactively): When displaying error message
4817 about invalid control letter, pass the character's codepoint, not
4818 a pointer to its multibyte form. Improve display of the character
4819 in octal and display also its hex code.
4820
4821 * character.c (char_string): Use %x to display the (unsigned)
4822 codepoint of an invalid character, to avoid displaying a bogus
4823 negative value.
4824
4825 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4826 `error', not SYMBOL_NAME itself.
4827
4828 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4829 character arguments to `error'.
4830
4831 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4832 to `error' in error message about FINAL_CHAR argument. Make sure
4833 FINAL_CHAR is a character, and use %c when it is passed as
4834 argument to `error'.
4835
4836 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4837
4838 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4839
4840 * w32.c: Include <time.h>.
4841 (sys_localtime): New function.
4842
4843 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4844
4845 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4846
4847 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4848
4849 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4850
4851 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4852 zombies (Bug#8467).
4853
4854 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4855
4856 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4857 gl_state.e_property when gl_state.object is Qt.
4858
4859 * insdel.c (make_gap_larger): Remove limitation of buffer size
4860 to <= INT_MAX.
4861
4862 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4863
4864 * xdisp.c (lookup_glyphless_char_display)
4865 (produce_glyphless_glyph): Handle cons cell entry in
4866 glyphless-char-display.
4867 (Vglyphless_char_display): Document it.
4868
4869 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4870 glyphless-char-display.
4871
4872 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4873
4874 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4875
4876 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4877
4878 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4879 definition for no-X builds.
4880
4881 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4882
4883 Static checks with GCC 4.6.0 and non-default toolkits.
4884
4885 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4886
4887 * process.c (keyboard_bit_set): Define only if SIGIO.
4888 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4889 (send_process): Repair possible setjmp clobbering.
4890
4891 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4892
4893 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4894
4895 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4896
4897 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4898 Define only if needed.
4899
4900 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4901 by pacifying GCC about it. Maybe it's time to retire it?
4902 * xfaces.c (USG, __TIMEVAL__): Likewise.
4903
4904 * dispextern.h (struct redisplay_interface): Rename param
4905 to avoid shadowing.
4906 * termhooks.h (struct terminal): Likewise.
4907 * xterm.c (xembed_send_message): Likewise.
4908
4909 * insdel.c (make_gap_smaller): Define only if
4910 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4911
4912 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4913 it.
4914
4915 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4916 so that we aren't warned about unused symbols.
4917
4918 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4919
4920 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4921
4922 * xfns.c (x_real_positions): Mark locals as initialized.
4923
4924 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4925
4926 * xterm.c: Fix problems found by static analysis with other toolkits.
4927 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4928 (x_dispatch_event): Declare static if USE_GTK, and
4929 define if USE_GTK || USE_X_TOOLKIT.
4930 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4931 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4932 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4933 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4934
4935 * xmenu.c (menu_help_callback): Pointer type fixes.
4936 Use const pointers when pointing at readonly data. Avoid pointer
4937 signedness clashes.
4938 (FALSE): Remove unused macro.
4939 (update_frame_menubar): Remove unused decl.
4940
4941 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4942
4943 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4944 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4945 (single_menu_item): Rename local to avoid shadowing.
4946
4947 * keyboard.c (make_lispy_event): Remove unused local var.
4948
4949 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4950 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4951
4952 * bitmaps: Change bitmaps from unsigned char back to the X11
4953 compatible char. Avoid the old compiler warnings about
4954 out-of-range initializers by using, for example, '\xab' rather
4955 than 0xab.
4956
4957 * xgselect.c (xgselect_initialize): Check vs interface
4958 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4959
4960 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4961
4962 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4963 to read-only memory.
4964
4965 * fns.c (vector): Remove; this old hack is no longer needed.
4966
4967 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4968 Remove unused var.
4969 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4970
4971 * xrdb.c (x_load_resources): Omit unused local.
4972
4973 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4974 (x_window): Rename locals to avoid shadowing.
4975 (USG): Use the kludged USG macro, to pacify gcc.
4976
4977 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4978 (x_term_init): Remove local to avoid shadowing.
4979
4980 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4981
4982 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4983 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4984
4985 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4986
4987 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4988
4989 Fix regex.c, syntax.c and friends for buffers > 2GB.
4990 * syntax.h (struct gl_state_s): Declare character position members
4991 EMACS_INT.
4992
4993 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4994
4995 * textprop.c (verify_interval_modification, interval_of):
4996 Declare arguments EMACS_INT.
4997
4998 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4999 EMACS_INT.
5000
5001 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5002
5003 * indent.c (Fvertical_motion): Local variable it_start is now
5004 EMACS_INT.
5005
5006 * regex.c (re_match, re_match_2, re_match_2_internal)
5007 (bcmp_translate, regcomp, regexec, print_double_string)
5008 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5009 (re_compile_pattern, re_exec): Declare arguments and local
5010 variables `size_t' and `ssize_t' and return values `regoff_t', as
5011 appropriate.
5012 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5013 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5014 <compile_stack_type>: `size' and `avail' are now `size_t'.
5015
5016 * regex.h <regoff_t>: Use ssize_t, not int.
5017 (re_search, re_search_2, re_match, re_match_2): Arguments that
5018 specify buffer/string position and length are now ssize_t and
5019 size_t. Return type is regoff_t.
5020
5021 2011-04-16 Ben Key <bkey76@gmail.com>
5022
5023 * nsfont.m: Fixed bugs in ns_get_family and
5024 ns_descriptor_to_entity that were caused by using free to
5025 deallocate memory blocks that were allocated by xmalloc (via
5026 xstrdup). This caused Emacs to crash when compiled with
5027 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5028 --enable-checking=xmallocoverrun). xfree is now used to
5029 deallocate these memory blocks.
5030
5031 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5032
5033 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5034
5035 emacs_write: Accept and return EMACS_INT for sizes.
5036 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5037 et seq.
5038 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5039 Accept and return EMACS_INT.
5040 (emacs_gnutls_write): Return the number of bytes written on
5041 partial writes.
5042 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5043 (emacs_read, emacs_write): Remove check for negative size, as the
5044 Emacs source code has been audited now.
5045 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5046 (emacs_read, emacs_write): Use it.
5047 * process.c (send_process): Adjust to the new signatures of
5048 emacs_write and emacs_gnutls_write. Do not attempt to store
5049 a byte offset into an 'int'; it might overflow.
5050 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5051
5052 * sound.c: Don't assume sizes fit in 'int'.
5053 (struct sound_device.period_size, alsa_period_size):
5054 Return EMACS_INT, not int.
5055 (struct sound_device.write, vox_write, alsa_write):
5056 Accept EMACS_INT, not int.
5057 (wav_play, au_play): Use EMACS_INT to store sizes and to
5058 record read return values.
5059
5060 2011-04-15 Ben Key <bkey76@gmail.com>
5061
5062 * keyboard.c (Qundefined): Don't declare static since it is used
5063 in nsfns.m.
5064 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5065 static since they are used in nsfont.m.
5066
5067 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5068
5069 * process.c (Qprocessp): Don't declare static.
5070 * lisp.h (Qprocessp): Declare again.
5071
5072 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5073
5074 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5075
5076 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5077
5078 Improve C-level modularity by making more things 'static'.
5079
5080 Don't publish debugger-only interfaces to other modules.
5081 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5082 (verify_bytepos, count_markers): Move decls to the only modules
5083 that need them.
5084 * region-cache.h (pp_cache): Likewise.
5085 * window.h (check_all_windows): Likewise.
5086 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5087
5088 * sysdep.c (croak): Now static, if
5089 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5090 * syssignal.h (croak): Declare only if not static.
5091
5092 * alloc.c (refill_memory_reserve): Now static if
5093 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5094 * lisp.h (refill_memory_reserve): Declare only if not static.
5095
5096 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5097 Define only if USE_LUCID.
5098
5099 * xrdb.c (x_customization_string, x_rm_string): Now static.
5100
5101 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5102 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5103
5104 * xdisp.c (draw_row_with_mouse_face): Now static.
5105 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5106
5107 * window.h (check_all_windows): Mark externally visible.
5108
5109 * window.c (window_deletion_count): Now static.
5110
5111 * undo.c: Make symbols static if they're not exported.
5112 (last_undo_buffer, last_boundary_position, pending_boundary):
5113 Now static.
5114
5115 * textprop.c (interval_insert_behind_hooks): Now static.
5116 (interval_insert_in_front_hooks): Likewise.
5117
5118 * term.c: Make symbols static if they're not exported.
5119 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5120 (max_frame_lines, tty_set_terminal_modes):
5121 (tty_reset_terminal_modes, tty_turn_off_highlight):
5122 (get_tty_terminal): Now static.
5123 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5124 * termhooks.h (term_mouse_moveto): Do not declare if
5125 HAVE_WINDOW_SYSTEM.
5126 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5127 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5128
5129 * sysdep.c: Make symbols static if they're not exported.
5130 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5131 Now static.
5132 (sigprocmask_set, full_mask): Remove; unused.
5133 (wait_debugging): Mark as visible.
5134 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5135 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5136
5137 * syntax.c (syntax_temp): Define only if !__GNUC__.
5138
5139 * sound.c (current_sound_device, current_sound): Now static.
5140
5141 * search.c (searchbufs, searchbuf_head): Now static.
5142
5143 * scroll.c (scroll_cost): Remove; unused.
5144 * dispextern.h (scroll_cost): Remove decl.
5145
5146 * region-cache.h (pp_cache): Mark as externally visible.
5147
5148 * process.c: Make symbols static if they're not exported.
5149 (process_tick, update_tick, create_process, chan_process):
5150 (Vprocess_alist, proc_buffered_char, datagram_access):
5151 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5152 (deactivate_process): Mark defn as static, as well as decl.
5153 * lisp.h (create_process): Remove decl.
5154 * process.h (chan_process, Vprocess_alist): Remove decls.
5155
5156 * print.c: Make symbols static if they're not exported.
5157 (print_depth, new_backquote_output, being_printed, print_buffer):
5158 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5159 (print_interval, print_number_index, initial_stderr_stream):
5160 Now static.
5161 * lisp.h (Fprinc): Remove decl.
5162 (debug_output_compilation_hack): Mark as externally visible.
5163
5164 * sysdep.c (croak): Move decl from here to syssignal.h.
5165 * syssignal.h (croak): Put it here, so the API can be checked when
5166 'croak' is called from dissociate_if_controlling_tty.
5167
5168 * minibuf.c: Make symbols static if they're not exported.
5169 (minibuf_save_list, choose_minibuf_frame): Now static.
5170 * lisp.h (choose_minibuf_frame): Remove decl.
5171
5172 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5173
5174 * lread.c: Make symbols static if they're not exported.
5175 (read_objects, initial_obarray, oblookup_last_bucket_number):
5176 Now static.
5177 (make_symbol): Remove; unused.
5178 * lisp.h (initial_obarray, make_symbol): Remove decls.
5179
5180 * keyboard.c: Make symbols static if they're not exported.
5181 (single_kboard, recent_keys_index, total_keys, recent_keys):
5182 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5183 (this_single_command_key_start, echoing, last_auto_save):
5184 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5185 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5186 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5187 (Vlispy_mouse_stem, double_click_count):
5188 Now static.
5189 (force_auto_save_soon): Define only if SIGDANGER.
5190 (ignore_mouse_drag_p): Now static if
5191 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5192 (print_help): Remove; unused.
5193 (stop_character, last_timer_event): Mark as externally visible.
5194 * keyboard.h (ignore_mouse_drag_p): Declare only if
5195 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5196 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5197 * lisp.h (echoing): Remove decl.
5198 (force_auto_save_soon): Declare only if SIGDANGER.
5199 * xdisp.c (redisplay_window): Simplify code, to make it more
5200 obvious that ignore_mouse_drag_p is not accessed if !defined
5201 USE_GTK && !defined HAVE_NS.
5202
5203 * intervals.c: Make symbols static if they're not exported.
5204 (merge_properties_sticky, merge_interval_right, delete_interval):
5205 Now static.
5206 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5207
5208 * insdel.c: Make symbols static if they're not exported.
5209 However, leave prepare_to_modify_buffer alone. It's never
5210 called from outside this function, but that appears to be a bug.
5211 (combine_after_change_list, combine_after_change_buffer):
5212 (adjust_after_replace, signal_before_change): Now static.
5213 (adjust_after_replace_noundo): Remove; unused.
5214 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5215 (signal_before_change): Remove decls.
5216
5217 * indent.c (val_compute_motion, val_vmotion): Now static.
5218
5219 * image.c: Make symbols static if they're not exported.
5220 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5221 if USE_GTK.
5222 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5223 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5224
5225 * fringe.c (standard_bitmaps): Now static.
5226 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5227
5228 * frame.c: Make symbols static if they're not exported.
5229 (x_report_frame_params, make_terminal_frame): Now static.
5230 (get_frame_param): Now static, unless HAVE_NS.
5231 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5232 (x_get_resource_string): Remove; not used.
5233 * frame.h (make_terminal_frame, x_report_frame_params):
5234 (x_get_resource_string); Remove decls.
5235 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5236 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5237
5238 * font.c, fontset.c: Make symbols static if they're not exported.
5239 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5240 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5241 * font.c (font_close_object): Now static.
5242 * font.h (font_close_object): Remove.
5243 * fontset.c (FONTSET_OBJLIST): Remove.
5244 (free_realized_fontset) #if-0 the body, which does nothing.
5245 (face_suitable_for_char_p): #if-0, as it's never called.
5246 * fontset.h (face_suitable_for_char_p): Remove decl.
5247 * xfaces.c (face_at_string_position):
5248 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5249 since 0 is always ASCII.
5250
5251 * fns.c (weak_hash_tables): Now static.
5252
5253 * fileio.c: Make symbols static if they're not exported.
5254 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5255 (Vwrite_region_annotation_buffers): Now static.
5256
5257 * eval.c: Make symbols static if they're not exported.
5258 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5259 * lisp.h (backtrace_list): Remove decl.
5260
5261 * emacs.c: Make symbols static if they're not exported.
5262 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5263 (fatal_error_code, fatal_error_signal_hook, standard_args):
5264 Now static.
5265 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5266 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5267 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5268 * lisp.h (fatal_error_signal_hook): Remove decl.
5269 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5270
5271 * editfns.c: Move a (normally-unused) function to its only use.
5272 * editfns.c, lisp.h (get_operating_system_release): Remove.
5273 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5274 worth the hassle of breaking this out.
5275
5276 * xterm.c: Make symbols static if they're not exported.
5277 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5278 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5279 (x_destroy_window, x_delete_display):
5280 Now static.
5281 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5282 (x_mouse_leave): Remove; unused.
5283 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5284 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5285 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5286 Remove decls.
5287 (x_mouse_leave): Declare only if WINDOWSNT.
5288 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5289 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5290 USE_X_TOOLKIT.
5291
5292 * ftxfont.c: Make symbols static if they're not exported.
5293 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5294 HAVE_FREETYPE.
5295 * font.h (ftxfont_driver): Likewise.
5296
5297 * xfns.c: Make symbols static if they're not exported.
5298 (x_last_font_name, x_display_info_for_name):
5299 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5300 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5301 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5302 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5303 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5304 (last_show_tip_args): Now static.
5305 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5306 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5307 (x_screen_planes): Remove; unused.
5308 * dispextern.h (x_screen_planes): Remove decl.
5309
5310 * dispnew.c: Make symbols static if they're not exported.
5311 * dispextern.h (redraw_garbaged_frames, scrolling):
5312 (increment_row_positions): Remove.
5313 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5314 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5315 Now static.
5316 (redraw_garbaged_frames): Remove; unused.
5317
5318 * xfaces.c: Make symbols static if they're not exported.
5319 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5320 Remove decls.
5321 * xterm.h (defined_color): Remove decls.
5322 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5323 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5324 (menu_face_changed_default, defined_color, free_realized_face):
5325 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5326 (ascii_face_of_lisp_face): Remove; unused.
5327
5328 * xdisp.c: Make symbols static if they're not exported.
5329 * dispextern.h (scratch_glyph_row, window_box_edges):
5330 (glyph_to_pixel_coords, set_cursor_from_row):
5331 (get_next_display_element, set_iterator_to_next):
5332 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5333 (show_mouse_face): Remove decls
5334 * frame.h (message_buf_print): Likewise.
5335 * lisp.h (pop_message, set_message, check_point_in_composition):
5336 Likewise.
5337 * xterm.h (set_vertical_scroll_bar): Likewise.
5338 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5339 (message_buf_print, scratch_glyph_row, displayed_buffer):
5340 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5341 (get_next_display_element, show_mouse_face, window_box_edges):
5342 (frame_to_window_pixel_xy, check_point_in_composition):
5343 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5344 (glyph_to_pixel_coords): Remove; unused.
5345
5346 * dired.c (file_name_completion): Now static.
5347
5348 * dbusbind.c (xd_in_read_queued_messages): Now static.
5349
5350 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5351 * data.c (circular_list_error): Remove.
5352
5353 * commands.h (last_point_position, last_point_position_buffer):
5354 (last_point_position_window): Remove decls.
5355 * keyboard.c: Make these variables static.
5356
5357 * coding.h (coding, code_convert_region, encode_coding_gap):
5358 Remove decls.
5359 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5360 (iso_code_class, detect_coding, code_convert_region): Now static.
5361 (encode_coding_gap): Remove; unused.
5362
5363 * chartab.c (chartab_chars, chartab_bits): Now static.
5364
5365 * charset.h (charset_iso_8859_1): Remove decl.
5366 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5367 Now static.
5368
5369 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5370 * ccl.c (Vccl_program_table): Now static.
5371 (check_ccl_update): Remove; unused.
5372
5373 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5374 * category.h: ... from here.
5375 * category.c (check_category_table, set_category_set): Now static.
5376
5377 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5378 * lisp.h: Remove these decls.
5379
5380 * buffer.c (buffer_count): Remove unused var.
5381
5382 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5383 so that it's not optimized away.
5384 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5385 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5386 exported only to the debugger.
5387
5388 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5389 * atimer.h (run_all_atimers): Remove; not exported.
5390
5391 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5392 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5393 was inaccessible from Lisp.
5394 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5395 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5396
5397 alloc.c: Import and export fewer symbols, and remove unused items.
5398 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5399 is defined.
5400 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5401 it's not optimized away by whole-program optimization.
5402 (message_enable_multibyte, free_misc): Remove.
5403 (catchlist, handlerlist, mark_backtrace):
5404 Declare only if BYTE_MARK_STACK.
5405 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5406 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5407 (message_enable_multibyte): Remove decl.
5408 (free_misc, interval_free_list, float_block, float_block_index):
5409 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5410 (cons_free_list, last_marked_index):
5411 Now static.
5412 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5413 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5414 (mark_backtrace): Define only if BYTE_MARK_STACK.
5415 * xdisp.c (message_enable_multibyte): Now static.
5416
5417 Declare Lisp_Object Q* variables to be 'static' if not exported.
5418 This makes it easier for human readers (and static analyzers)
5419 to see whether these variables are used from other modules.
5420 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5421 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5422 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5423 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5424 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5425 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5426 * xmenu.c, xselect.c:
5427 Declare Q* vars static if they are not used in other modules.
5428 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5429 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5430 Remove decls of unexported vars.
5431 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5432
5433 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5434
5435 Make Emacs functions such as Fatom 'static' by default.
5436 This makes it easier for human readers (and static analyzers)
5437 to see whether these functions can be called from other modules.
5438 DEFUN now defines a static function. To make the function external
5439 so that it can be used in other C modules, use the new macro DEFUE.
5440 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5441 (Finit_image_library):
5442 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5443 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5444 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5445 Remove decls, since these functions are now static.
5446 (Funintern, Fget_internal_run_time): New decls, since these functions
5447 were already external.
5448
5449 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5450 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5451 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5452 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5453 * keyboard.c, keymap.c, lread.c:
5454 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5455 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5456 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5457 Mark functions with DEFUE instead of DEFUN,
5458 if they are used in other modules.
5459 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5460 decls for now-static functions.
5461 * buffer.h (Fdelete_overlay): Remove decl.
5462 * callproc.c (Fgetenv_internal): Mark as internal.
5463 * composite.c (Fremove_list_of_text_properties): Remove decl.
5464 (Fcomposition_get_gstring): New forward static decl.
5465 * composite.h (Fcomposite_get_gstring): Remove decl.
5466 * dired.c (Ffile_attributes): New forward static decl.
5467 * doc.c (Fdocumntation_property): New forward static decl.
5468 * eval.c (Ffetch_bytecode): New forward static decl.
5469 (Funintern): Remove extern decl; now in .h file where it belongs.
5470 * fileio.c (Fmake_symbolic_link): New forward static decl.
5471 * image.c (Finit_image_library): New forward static decl.
5472 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5473 * intervals.h (Fprevious_property_change):
5474 (Fremove_list_of_text_properties): Remove decls.
5475 * keyboard.c (Fthis_command_keys): Remove decl.
5476 (Fcommand_execute): New forward static decl.
5477 * keymap.c (Flookup_key): New forward static decl.
5478 (Fcopy_keymap): Now static.
5479 * keymap.h (Flookup_key): Remove decl.
5480 * process.c (Fget_process): New forward static decl.
5481 (Fprocess_datagram_address): Mark as internal.
5482 * syntax.c (Fsyntax_table_p): New forward static decl.
5483 (skip_chars): Remove duplicate decl.
5484 * textprop.c (Fprevious_property_change): New forward static decl.
5485 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5486 Now internal.
5487 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5488 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5489
5490 * editfns.c (Fformat): Remove unreachable code.
5491
5492 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5493
5494 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5495 change. (Bug#8496)
5496
5497 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5498
5499 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5500 when at ZV. (Bug#8487)
5501
5502 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5503
5504 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5505 (Bug#8437)
5506 * keyboard.c (parse_tool_bar_item): Likewise.
5507 * sound.c (sound_cleanup, alsa_close): Likewise.
5508 * termcap.c (tgetent): Likewise.
5509 * xfns.c (x_default_font_parameter): Likewise.
5510 * xsettings.c (read_and_apply_settings): Likewise.
5511
5512 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5513 (overrun_check_free): Protoize.
5514
5515 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5516
5517 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5518 since callers should never pass a negative size.
5519 Change the signature to match that of plain 'read' and 'write'; see
5520 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5521 * lisp.h: Update prototypes of emacs_write and emacs_read.
5522
5523 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5524
5525 * xdisp.c (redisplay_window): Don't try to determine the character
5526 position of the scroll margin if the window start point w->startp
5527 is outside the buffer's accessible region. (Bug#8468)
5528
5529 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5530
5531 Fix write-region and its subroutines for buffers > 2GB.
5532 * fileio.c (a_write, e_write): Modify declaration of arguments and
5533 local variables to support buffers larger than 2GB.
5534 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5535
5536 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5537 argument, local variables, and return value.
5538
5539 * lisp.h: Update prototypes of emacs_write and emacs_read.
5540
5541 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5542
5543 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5544
5545 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5546
5547 Fix more problems found by GCC 4.6.0's static checks.
5548
5549 * xdisp.c (vmessage): Use a better test for character truncation.
5550
5551 * charset.c (load_charset_map): <, not <=, for optimization,
5552 and to avoid potential problems with integer overflow.
5553 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5554 * casetab.c (set_identity, shuffle): Likewise.
5555 * editfns.c (Fformat): Likewise.
5556 * syntax.c (skip_chars): Likewise.
5557
5558 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5559 This also lets GCC 4.6.0 generate slightly better loop code.
5560
5561 * callint.c (Fcall_interactively): <, not <=, for optimization.
5562 (Fcall_interactively): Count the number of arguments produced,
5563 not the number of arguments given. This is simpler and lets GCC
5564 4.6.0 generate slightly better code.
5565
5566 * ftfont.c: Distingish more carefully between FcChar8 and char.
5567 The previous code passed unsigned char * to a functions like
5568 strlen and xstrcasecmp that expect char *, which does not
5569 conform to the C standard.
5570 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5571 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5572 char * when the C standard requires it.
5573
5574 * keyboard.c (read_char): Remove unused var.
5575
5576 * eval.c: Port to Windows vsnprintf (Bug#8435).
5577 Include <limits.h>.
5578 (SIZE_MAX): Define if the headers do not.
5579 (verror): Do not give up if vsnprintf returns a negative count.
5580 Instead, grow the buffer. This ports to Windows vsnprintf, which
5581 does not conform to C99. Problem reported by Eli Zaretskii.
5582 Also, simplify the allocation scheme, by avoiding the need for
5583 calling realloc, and removing the ALLOCATED variable.
5584
5585 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5586
5587 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5588 But keep the doprint source code for now, as we might revamp it
5589 and use it again (Bug#8435).
5590 * lisp.h (doprnt): Remove.
5591 * Makefile.in (base_obj): Remove doprnt.o.
5592 * deps.mk (doprnt.o): Remove.
5593
5594 error: Print 32- and 64-bit integers portably (Bug#8435).
5595 Without this change, on typical 64-bit hosts error ("...%d...", N)
5596 was used to print both 32- and 64-bit integers N, which relied on
5597 undefined behavior.
5598 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5599 New macro.
5600 * lisp.h (error, verror): Mark as printf-like functions.
5601 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5602 Report overflow in size calculations when allocating printf buffer.
5603 Do not truncate output string at its first null byte.
5604 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5605 Truncate the output at a character boundary, since vsnprintf does not
5606 do that.
5607 * charset.c (check_iso_charset_parameter): Convert internal
5608 character to string before calling 'error', since %c now has the
5609 printf meaning.
5610 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5611 overflow when computing char to be passed to 'error'. Do not
5612 pass Lisp_Object to 'error'; pass the integer instead.
5613 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5614 formatted with plain %d.
5615
5616 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5617
5618 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5619
5620 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5621
5622 * xterm.c (x_catch_errors): Remove duplicate declaration.
5623
5624 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5625
5626 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5627
5628 2011-04-10 Jim Meyering <meyering@redhat.com>
5629
5630 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5631 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5632 return ssize_t not "int", and use size_t as the buffer length.
5633 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5634 * gnutls.h: Update declarations.
5635 * process.c (read_process_output): Use ssize_t, to match.
5636 (send_process): Likewise.
5637
5638 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5639
5640 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5641
5642 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5643
5644 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5645 Use unsigned char, to match FcChar8 type definition.
5646
5647 * xterm.c (handle_one_xevent):
5648 * xmenu.c (create_and_show_popup_menu):
5649 * xselect.c (x_decline_selection_request)
5650 (x_reply_selection_request): Avoid type-punned deref of X events.
5651
5652 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5653
5654 Fix some uses of `int' instead of EMACS_INT.
5655 * search.c (string_match_1, fast_string_match)
5656 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5657 (scan_buffer, find_next_newline_no_quit)
5658 (find_before_next_newline, search_command, Freplace_match)
5659 (Fmatch_data): Make some `int' variables be EMACS_INT.
5660
5661 * xdisp.c (display_count_lines): 3rd argument and return value now
5662 EMACS_INT. All callers changed.
5663 (pint2hrstr): Last argument is now EMACS_INT.
5664
5665 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5666 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5667 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5668 (decode_coding_utf_16, decode_coding_emacs_mule)
5669 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5670 (decode_coding_ccl, decode_coding_charset)
5671 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5672 (decode_coding_iso_2022, decode_coding_emacs_mule)
5673 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5674 <char_offset, last_offset>: Declare EMACS_INT.
5675 (encode_coding_utf_8, encode_coding_utf_16)
5676 (encode_coding_emacs_mule, encode_invocation_designation)
5677 (encode_designation_at_bol, encode_coding_iso_2022)
5678 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5679 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5680 Declare EMACS_INT.
5681 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5682 (encode_invocation_designation): Last argument P_NCHARS is now
5683 EMACS_INT.
5684 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5685 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5686
5687 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5688 All users changed.
5689
5690 * ccl.c (Fccl_execute_on_string): Declare some variables
5691 EMACS_INT.
5692
5693 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5694
5695 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5696
5697 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5698
5699 * process.c (Fformat_network_address): Doc fix.
5700
5701 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5702
5703 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5704
5705 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5706
5707 * keyboard.c (read_char): Call Lisp function help-form-show,
5708 instead of using internal_with_output_to_temp_buffer.
5709 (Qhelp_form_show): New var.
5710 (syms_of_keyboard): Use DEFSYM macro.
5711
5712 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5713
5714 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5715
5716 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5717
5718 * process.c (Flist_processes): Remove to Lisp.
5719 (list_processes_1): Delete.
5720
5721 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5722
5723 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5724
5725 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5726
5727 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5728
5729 Fix more problems found by GCC 4.6.0's static checks.
5730
5731 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5732
5733 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5734
5735 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5736
5737 * xdisp.c (vmessage): Mark as a printf-like function.
5738
5739 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5740
5741 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5742
5743 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5744 printf-like functions.
5745 (tiff_load): Add casts to remove these marks before passing them
5746 to system-supplied API.
5747
5748 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5749
5750 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5751 This avoids several warnings with gcc -Wstrict-overflow.
5752 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5753 directly, rather than having caller test rule sign. This avoids
5754 some unnecessary tests.
5755 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5756 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5757 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5758
5759 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5760 (xfont_open): Avoid unnecessary tests.
5761
5762 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5763
5764 * composite.h, composite.c (composition_gstring_put_cache):
5765 Use EMACS_INT, not int, for length.
5766
5767 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5768 breaking out part of COMPOSITION_DECODE_RULE.
5769 (COMPOSITION_DECODE_RULE): Use it.
5770 * composite.c (get_composition_id): Remove unused local vars,
5771 by using the new macro.
5772
5773 * textprop.c (set_text_properties_1): Change while to do-while,
5774 since the condition is always true at first.
5775
5776 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5777 (interval_deletion_adjustment): Return unsigned value.
5778 All uses changed.
5779
5780 * process.c (list_processes_1, create_pty, read_process_output):
5781 (exec_sentinel): Remove vars that were set but not used.
5782 (create_pty): Remove unnecessary "volatile"s.
5783 (Fnetwork_interface_info): Avoid possibility of int overflow.
5784 (read_process_output): Do adaptive read buffering even if carryover.
5785 (read_process_output): Simplify nbytes computation if buffered.
5786
5787 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5788
5789 * syntax.c (scan_words): Remove var that was set but not used.
5790 (update_syntax_table): Use unsigned instead of int.
5791
5792 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5793 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5794 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5795
5796 * print.c (print_error_message): Avoid int overflow.
5797
5798 * font.c (font_list_entities): Redo for clarity,
5799 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5800
5801 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5802 (font_score): Avoid potential overflow in diff calculation.
5803
5804 * fns.c (substring_both): Remove var that is set but not used.
5805 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5806
5807 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5808
5809 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5810 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5811 can always succeed if overflow has undefined behavior.
5812
5813 * search.c (boyer_moore, wordify): Remove vars set but not used.
5814 (wordify): Omit three unnecessary tests.
5815
5816 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5817 All callers changed. This avoids the need for an unused var.
5818
5819 * casefiddle.c (casify_region): Remove var that is set but not used.
5820
5821 * dired.c (file_name_completion): Remove var that is set but not used.
5822
5823 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5824
5825 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5826 (Finsert_file_contents): Remove unnecessary code checking fd.
5827
5828 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5829 Check for integer overflow on size calculations.
5830
5831 * buffer.c (Fprevious_overlay_change): Remove var that is set
5832 but not used.
5833
5834 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5835 Remove vars that are set but not used.
5836 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5837 (timer_check_2): Mark vars as initialized.
5838
5839 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5840
5841 * image.c (lookup_image): Remove var that is set but not used.
5842 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5843
5844 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5845 that are set but not used.
5846
5847 * xfns.c (make_invisible_cursor): Don't return garbage
5848 if XCreateBitmapFromData fails (Bug#8410).
5849
5850 * xselect.c (x_get_local_selection, x_handle_property_notify):
5851 Remove vars that are set but not used.
5852
5853 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5854 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5855
5856 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5857 Remove var that is set but not used.
5858 (scroll_bar_windows_size): Now size_t, not int.
5859 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5860 Check for overflow.
5861
5862 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5863 (map_tty_color) [!defined MSDOS]: Likewise.
5864
5865 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5866
5867 * coding.c: Remove vars that are set but not used.
5868 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5869 All callers changed.
5870 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5871 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5872 (decode_coding_charset): Remove vars that are set but not used.
5873
5874 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5875 that is set but not used.
5876
5877 * print.c (print_object): Remove var that is set but not used.
5878
5879 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5880 The gnulib version avoids calling malloc in the usual case,
5881 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5882 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5883 * filelock.c (current_lock_owner): Likewise.
5884 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5885 * sysdep.c: Include allocator.h, careadlinkat.h.
5886 (emacs_no_realloc_allocator): New static constant.
5887 (emacs_readlink): New function.
5888 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5889 ../lib/careadlinkat.h.
5890
5891 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5892
5893 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5894 first non-nil return value).
5895
5896 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5897
5898 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5899 if not defined (Bug#8403).
5900
5901 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5902
5903 * xdisp.c (display_count_lines): Remove parameter `start',
5904 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5905 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5906 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5907 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5908 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5909 and thereabouts. All callers changed.
5910 (get_per_char_metric): Remove parameter `f', unused since
5911 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5912
5913 2011-04-02 Jim Meyering <meyering@redhat.com>
5914
5915 do not dereference NULL upon failed strdup
5916 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5917 (ns_get_family): Likewise.
5918
5919 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5920
5921 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5922
5923 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5924
5925 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5926 later (Bug#8403).
5927
5928 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5929
5930 Add lexical binding.
5931
5932 * window.c (Ftemp_output_buffer_show): New fun.
5933 (Fsave_window_excursion):
5934 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5935
5936 * lread.c (lisp_file_lexically_bound_p): New function.
5937 (Fload): Bind Qlexical_binding.
5938 (readevalloop): Remove `evalfun' arg.
5939 Bind Qinternal_interpreter_environment.
5940 (Feval_buffer): Bind Qlexical_binding.
5941 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5942 Mark as dynamic.
5943 (syms_of_lread): Declare `lexical-binding'.
5944
5945 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5946
5947 * keyboard.c (eval_dyn): New fun.
5948 (menu_item_eval_property): Use it.
5949
5950 * image.c (parse_image_spec): Use Ffunctionp.
5951
5952 * fns.c (concat, mapcar1): Accept byte-code-functions.
5953
5954 * eval.c (Fsetq): Handle lexical vars.
5955 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5956 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5957 (FletX, Flet): Obey lexical binding.
5958 (Fcommandp): Handle closures.
5959 (Feval): New `lexical' arg.
5960 (eval_sub): New function extracted from Feval. Use it almost
5961 everywhere where Feval was used. Look up vars in lexical env.
5962 Handle closures.
5963 (Ffunctionp): Move from subr.el.
5964 (Ffuncall): Handle closures.
5965 (apply_lambda): Remove `eval_flags'.
5966 (funcall_lambda): Handle closures and new byte-code-functions.
5967 (Fspecial_variable_p): New function.
5968 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5969 but without exporting it to Lisp.
5970
5971 * doc.c (Fdocumentation, store_function_docstring):
5972 * data.c (Finteractive_form): Handle closures.
5973
5974 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5975 interactive spec.
5976
5977 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5978 New byte-codes.
5979 (exec_byte_code): New function extracted from Fbyte_code to handle new
5980 calling convention for byte-code-functions. Add new byte-codes.
5981
5982 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5983
5984 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5985
5986 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5987
5988 * xdisp.c (redisplay_internal): Fix prototype.
5989
5990 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5991
5992 * xdisp.c (SCROLL_LIMIT): New macro.
5993 (try_scrolling): Use it when setting scroll_limit.
5994 Limit scrolling to 100 screen lines.
5995 (redisplay_window): Even when falling back on "recentering",
5996 position point in the window according to scroll-conservatively,
5997 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5998
5999 (try_scrolling): When point is above the window, allow searching
6000 as far as scroll_max, or one screenful, to compute vertical
6001 distance from PT to the scroll margin position. This prevents
6002 try_scrolling from unnecessarily failing when
6003 scroll-conservatively is set to a value slightly larger than the
6004 window height. Clean up the case of PT below the margin at bottom
6005 of window: scroll_max can no longer be INT_MAX. When aggressive
6006 scrolling is in use, don't let point enter the opposite scroll
6007 margin as result of the scroll.
6008 (syms_of_xdisp) <scroll-conservatively>: Document the
6009 threshold of 100 lines for never-recentering scrolling.
6010
6011 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6012
6013 * dispextern.h (move_it_by_lines):
6014 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6015 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6016 (message_log_check_duplicate): Remove parameters `prev_bol' and
6017 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6018 (redisplay_internal): Remove parameter `preserve_echo_area',
6019 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6020
6021 * indent.c (Fvertical_motion):
6022 * window.c (window_scroll_pixel_based, Frecenter):
6023 Don't pass `need_y_p' to `move_it_by_lines'.
6024
6025 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6026
6027 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6028 steal a few bits to be more compact.
6029 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6030 Remove unneeded casts.
6031
6032 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6033
6034 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6035
6036 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6037 binding" message (bug#7967).
6038
6039 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6040
6041 Fix more problems found by GCC 4.6.0's static checks.
6042
6043 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6044 Remove unused local var.
6045
6046 * editfns.c (Fmessage_box): Remove unused local var.
6047
6048 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6049 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6050 Omit unused local vars.
6051 * window.c (shrink_windows): Omit unused local var.
6052 * menu.c (digest_single_submenu): Omit unused local var.
6053 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6054 Omit unused local var.
6055
6056 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6057 Don't assume string length fits in int.
6058 (keyremap_step, read_key_sequence): Use size_t for sizes.
6059 (read_key_sequence): Don't check last_real_key_start redundantly.
6060
6061 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6062 instead of alloca (Bug#8344).
6063
6064 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6065 (Fbacktrace_frame): Don't assume nframes fits in int.
6066
6067 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6068
6069 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6070 concerns.
6071
6072 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6073
6074 * cm.c (calccost): Turn while-do into do-while, for clarity.
6075
6076 * keyboard.c (syms_of_keyboard): Use the same style as later
6077 in this function when indexing through an array. This also
6078 works around GCC bug 48267.
6079
6080 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6081
6082 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6083
6084 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6085 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6086
6087 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6088 This avoids undefined behavior on integer overflow, and is a bit
6089 more convenient anyway since it is compared to a size_t variable.
6090
6091 Variadic C functions now count arguments with size_t, not int.
6092 This avoids an unnecessary limitation on 64-bit machines, which
6093 caused (substring ...) to crash on large vectors (Bug#8344).
6094 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6095 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6096 All variadic functions and their callers changed accordingly.
6097 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6098 * data.c (arith_driver, float_arith_driver): Likewise.
6099 * editfns.c (general_insert_function): Likewise.
6100 * eval.c (struct backtrace.nargs, interactive_p)
6101 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6102 (funcall_lambda, mark_backtrace): Likewise.
6103 * fns.c (concat): Likewise.
6104 * frame.c (x_set_frame_parameters): Likewise.
6105 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6106 0 if not found, not -1. All callers changed.
6107
6108 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6109 (stack_copy_size): Now size_t, not int.
6110 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6111
6112 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6113
6114 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6115 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6116 All callers changed.
6117
6118 * lisp.h (multibyte_char_to_unibyte):
6119 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6120 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6121 * character.h (CHAR_TO_BYTE8):
6122 * cmds.c (internal_self_insert):
6123 * editfns.c (general_insert_function):
6124 * keymap.c (push_key_description):
6125 * search.c (Freplace_match):
6126 * xdisp.c (message_dolog, set_message_1): All callers changed.
6127
6128 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6129
6130 * keyboard.c (safe_run_hook_funcall): New function.
6131 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6132 don't set the hook to nil, but remove the offending function instead.
6133 (Qcommand_hook_internal): Remove, unused.
6134 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6135 Vcommand_hook_internal.
6136
6137 * eval.c (enum run_hooks_condition): Remove.
6138 (funcall_nil, funcall_not): New functions.
6139 (run_hook_with_args): Call each function through a `funcall' argument.
6140 Remove `cond' argument, now redundant.
6141 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6142 (Frun_hook_with_args_until_failure): Adjust accordingly.
6143 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6144
6145 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6146
6147 * dispextern.h (string_buffer_position): Remove declaration.
6148
6149 * print.c (strout): Remove parameter `multibyte', unused since
6150 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6151
6152 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6153 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6154 All callers changed.
6155
6156 * w32.c (_wsa_errlist): Use braces for struct initializers.
6157
6158 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6159 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6160 All callers changed.
6161 (string_buffer_position): Likewise. Also, make static (it's never
6162 used outside xdisp.c).
6163 (cursor_row_p): Remove parameter `w', unused since
6164 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6165 (decode_mode_spec): Remove parameter `precision', introduced during
6166 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6167 All callers changed.
6168
6169 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6170
6171 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6172
6173 2011-03-27 Anders Lindgren <andlind@gmail.com>
6174
6175 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6176 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6177 (ns_update_auto_hide_menu_bar): New functions.
6178 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6179 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6180 ns_constrain_all_frames.
6181 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6182 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6183
6184 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6185
6186 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6187
6188 2011-03-27 Glenn Morris <rgm@gnu.org>
6189
6190 * syssignal.h: Replace RETSIGTYPE with void.
6191 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6192 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6193 Replace SIGTYPE with void everywhere.
6194 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6195 * s/template.h (SIGTYPE): Remove commented out definition.
6196
6197 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6198
6199 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6200 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6201
6202 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6203
6204 * w32.c (read_unc_volume): Use parameter `henum', instead of
6205 global variable `wget_enum_handle'.
6206
6207 * keymap.c (describe_vector): Remove parameters `indices' and
6208 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6209 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6210
6211 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6212
6213 * keyboard.c (timer_check): Remove parameter `do_it_now',
6214 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6215 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6216 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6217
6218 * keyboard.c (read_char):
6219 * w32menu.c (w32_menu_display_help):
6220 * xmenu.c (show_help_event, menu_help_callback):
6221 Adjust calls to `show_help_echo'.
6222
6223 * gtkutil.c (xg_maybe_add_timer):
6224 * keyboard.c (readable_events):
6225 * process.c (wait_reading_process_output):
6226 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6227
6228 * insdel.c (adjust_markers_gap_motion):
6229 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6230 (gap_left, gap_right): Don't call it.
6231
6232 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6233
6234 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6235 incurred during fontification.
6236
6237 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6238
6239 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6240 (DEFVAR_PER_BUFFER): Don't pass it.
6241
6242 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6243 (scrolling_window): Don't pass it.
6244
6245 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6246
6247 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6248
6249 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6250 and `suffix'.
6251 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6252 of variables specific to SELinux and computation of `encoded_absname'.
6253
6254 * image.c (XPutPixel): Remove unused variable `height'.
6255
6256 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6257
6258 * unexw32.c (get_section_info): Remove unused variable `section'.
6259
6260 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6261 (system_process_attributes): Remove unused variable `sess'.
6262 (sys_read): Remove unused variable `err'.
6263
6264 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6265 (w32_wnd_proc): Remove unused variable `isdead'.
6266 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6267 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6268 (x_create_tip_frame): Remove unused variable `tem'.
6269
6270 * w32inevt.c (w32_console_read_socket):
6271 Remove unused variable `no_events'.
6272
6273 * w32term.c (x_draw_composite_glyph_string_foreground):
6274 Remove unused variable `width'.
6275
6276 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6277
6278 * w32term.c (x_set_glyph_string_clipping):
6279 Don't pass uninitialized region to CombineRgn.
6280
6281 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6282
6283 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6284 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6285 (Fx_close_connection): Remove unused variable `i'.
6286
6287 * w32font.c (w32font_draw): Return number of glyphs.
6288 (w32font_open_internal): Remove unused variable `i'.
6289 (w32font_driver): Add missing initializer.
6290
6291 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6292 (fill_in_menu): Remove unused variable `items_added'.
6293
6294 * w32term.c (last_mouse_press_frame): Remove static global variable.
6295 (w32_clip_to_row): Remove unused variable `f'.
6296 (x_delete_terminal): Remove unused variable `i'.
6297
6298 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6299 (NOTHING): Remove unused static global variable.
6300 (uniscribe_check_otf): Remove unused variable `table'.
6301 (uniscribe_font_driver): Add missing initializers.
6302
6303 2011-03-23 Julien Danjou <julien@danjou.info>
6304
6305 * term.c (Fsuspend_tty, Fresume_tty):
6306 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6307 * window.c (temp_output_buffer_show):
6308 * insdel.c (signal_before_change):
6309 * frame.c (Fhandle_switch_frame):
6310 * fileio.c (Fdo_auto_save):
6311 * emacs.c (Fkill_emacs):
6312 * editfns.c (save_excursion_restore):
6313 * cmds.c (internal_self_insert):
6314 * callint.c (Fcall_interactively):
6315 * buffer.c (Fkill_all_local_variables):
6316 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6317 Use Frun_hooks.
6318 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6319 unconditionnaly since it does the check itself.
6320
6321 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6322
6323 Fix more problems found by GCC 4.5.2's static checks.
6324
6325 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6326 the first time through the loop, since we know p0 < p1 then.
6327 This also avoids a gcc -Wstrict-overflow warning.
6328
6329 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6330 leading to a memory leak, possible in functions like
6331 load_charset_map_from_file that can allocate an unbounded number
6332 of objects (Bug#8318).
6333
6334 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6335 that could (at least in theory) be that large.
6336
6337 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6338 This is less likely to overflow, and avoids undefined behavior if
6339 overflow does occur. All callers changed. Use strtoul to scan
6340 for the unsigned long integer.
6341 (pint2hrstr): Simplify and tune code slightly.
6342 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6343
6344 * scroll.c (do_scrolling): Work around GCC bug 48228.
6345 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6346
6347 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6348 This also avoids a warning with gcc -Wstrict-overflow.
6349 (validate_x_resource_name): Simplify count usage.
6350 This also avoids a warning with gcc -Wstrict-overflow.
6351
6352 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6353 fail (Bug#8306).
6354
6355 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6356
6357 * process.c (Fmake_network_process): Use socklen_t, not int,
6358 where POSIX says socklen_t is required in portable programs.
6359 This fixes a porting bug on hosts like 64-bit HP-UX, where
6360 socklen_t is wider than int (Bug#8277).
6361 (Fmake_network_process, server_accept_connection):
6362 (wait_reading_process_output, read_process_output):
6363 Likewise.
6364
6365 * process.c: Rename or move locals to avoid shadowing.
6366 (list_processes_1, Fmake_network_process):
6367 (read_process_output_error_handler, exec_sentinel_error_handler):
6368 Rename or move locals.
6369 (Fmake_network_process): Define label "retry_connect" only if needed.
6370 (Fnetwork_interface_info): Fix pointer signedness.
6371 (process_send_signal): Add cast to avoid pointer signedness problem.
6372 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6373 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6374
6375 Make tparam.h and terminfo.c consistent.
6376 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6377 Include tparam.h instead, since it declares them.
6378 * cm.h (PC): Remove extern decl; tparam.h now does this.
6379 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6380 * terminfo.c: Include tparam.h, to check interfaces.
6381 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6382 (tparam): Adjust signature to match interface in tparam.h;
6383 this removes some undefined behavior. Check that outstring and len
6384 are zero, which they always are with Emacs.
6385 * tparam.h (PC, BC, UP): New extern decls.
6386
6387 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6388 (xftfont_open): Rename locals to avoid shadowing.
6389
6390 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6391 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6392 (OTF_TAG_SYM): Omit macro if not needed.
6393 (ftfont_list): Remove unused local.
6394 (get_adstyle_property, ftfont_pattern_entity):
6395 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6396 Rename locals to avoid shadowing.
6397
6398 * xfont.c (xfont_list_family): Mark var as initialized.
6399
6400 * xml.c (make_dom): Now static.
6401
6402 * composite.c (composition_compute_stop_pos): Rename local to
6403 avoid shadowing.
6404 (composition_reseat_it): Remove unused locals.
6405 (find_automatic_composition, composition_adjust_point): Likewise.
6406 (composition_update_it): Mark var as initialized.
6407 (find_automatic_composition): Mark vars as initialized,
6408 with a FIXME (Bug#8290).
6409
6410 character.h: Rename locals to avoid shadowing.
6411 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6412 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6413 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6414 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6415 to avoid shadowing.
6416
6417 * textprop.c (property_change_between_p): Remove; unused.
6418
6419 * intervals.c (interval_start_pos): Now static.
6420
6421 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6422
6423 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6424 Rename locals to avoid shadowing.
6425
6426 * sound.c (wav_play, au_play, Fplay_sound_internal):
6427 Fix pointer signedness.
6428 (alsa_choose_format): Remove unused local var.
6429 (wav_play): Initialize a variable to 0, to prevent undefined
6430 behavior (Bug#8278).
6431
6432 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6433
6434 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6435
6436 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6437 clobbering (Bug#8298).
6438 * sysdep.c (sys_subshell): Likewise.
6439 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6440
6441 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6442 This should get cleaned up, so that child_setup has the
6443 same signature on all platforms.
6444
6445 * callproc.c (call_process_cleanup): Now static.
6446 (relocate_fd): Rename locals to avoid shadowing.
6447
6448 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6449
6450 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6451 not to be necessary, and produces flickering.
6452
6453 2011-03-20 Glenn Morris <rgm@gnu.org>
6454
6455 * config.in: Remove file.
6456
6457 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6458
6459 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6460 are now in src/globals.h.
6461 (syms_of_minibuf): Remove spurious & from previous change.
6462
6463 2011-03-20 Leo <sdl.web@gmail.com>
6464
6465 * minibuf.c (completing-read-function): New variable.
6466 (completing-read-default): Rename from completing-read.
6467 (completing-read): Call completing-read-function.
6468
6469 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6470
6471 * xfaces.c (Fx_load_color_file):
6472 Read color file from absolute filename (bug#8250).
6473
6474 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6475
6476 * makefile.w32-in: Update dependencies.
6477
6478 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6479
6480 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6481
6482 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6483
6484 Fix more problems found by GCC 4.5.2's static checks.
6485
6486 * process.c (make_serial_process_unwind, send_process_trap):
6487 (sigchld_handler): Now static.
6488
6489 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6490 That way, the code declares only the vars that it needs.
6491 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6492 * s/cygwin.h (PTY_ITERATION): Likewise.
6493 * s/darwin.h (PTY_ITERATION): Likewise.
6494 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6495
6496 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6497 * process.c (allocate_pty): Don't declare stb unless it's needed.
6498
6499 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6500 (CONSTANTLIM): Remove; unused.
6501 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6502 Define only if needed.
6503
6504 * unexelf.c (unexec): Name an expression,
6505 to avoid gcc -Wbad-function-cast warning.
6506 Use a different way to cause a compilation error if anyone uses
6507 n rather than nn, a way that does not involve shadowing.
6508 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6509
6510 * deps.mk (unexalpha.o): Remove; unused.
6511
6512 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6513 * unexec.h: New file.
6514 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6515 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6516 Depend on unexec.h.
6517 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6518 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6519 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6520 Change as necessary to match prototype in unexec.h.
6521
6522 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6523 shadowing.
6524 (back_comment, skip_chars): Mark vars as initialized.
6525
6526 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6527 Rename locals to avoid shadowing.
6528
6529 * lread.c (read1): Rewrite so as not to use empty "else".
6530 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6531
6532 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6533
6534 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6535 warning when compiling print.c.
6536
6537 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6538 instead of using an uninitialized var.
6539 (font_sort_entities): Mark var as initialized.
6540
6541 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6542
6543 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6544 pointers to constants.
6545 (font_parse_fcname): Remove unused vars.
6546 (font_delete_unmatched): Now static.
6547 (font_get_spec): Remove; unused.
6548 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6549 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6550 Rename or move locals to avoid shadowing.
6551
6552 * fns.c (require_nesting_list, require_unwind): Now static.
6553 (Ffillarray): Rename locals to avoid shadowing.
6554
6555 * floatfns.c (domain_error2): Define only if needed.
6556 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6557
6558 * alloc.c (mark_backtrace): Move decl from here ...
6559 * lisp.h: ... to here, so that it can be checked.
6560
6561 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6562 (Fdefvar): Rewrite so as not to use empty "else".
6563 (lisp_indirect_variable): Name an expression,
6564 to avoid gcc -Wbad-function-cast warning.
6565 (Fdefvar): Rename locals to avoid shadowing.
6566
6567 * callint.c (quotify_arg, quotify_args): Now static.
6568 (Fcall_interactively): Rename locals to avoid shadowing.
6569 Use const pointer when appropriate.
6570
6571 * lisp.h (get_system_name, get_operating_system_release):
6572 Move decls here, to check interfaces.
6573 * process.c (get_operating_system_release): Move decl to lisp.h.
6574 * xrdb.c (get_system_name): Likewise.
6575 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6576 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6577 some of which prompt warnings from gcc -Wbad-function-cast.
6578 (Fformat_time_string, Fencode_time, Finsert_char):
6579 (Ftranslate_region_internal, Fformat):
6580 Rename or remove local vars to avoid shadowing.
6581 (Ftranslate_region_internal): Mark var as initialized.
6582
6583 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6584 avoid shadowing.
6585
6586 * lisp.h (eassert): Check that the argument compiles, even if
6587 ENABLE_CHECKING is not defined.
6588
6589 * data.c (Findirect_variable): Name an expression, to avoid
6590 gcc -Wbad-function-cast warning.
6591 (default_value, arithcompare, arith_driver, arith_error): Now static.
6592 (store_symval_forwarding): Rename local to avoid shadowing.
6593 (Fmake_variable_buffer_local, Fmake_local_variable):
6594 Mark variables as initialized.
6595 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6596
6597 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6598 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6599 Rename locals to avoid shadowing.
6600 (mark_stack): Move local variables into the #ifdef region where
6601 they're used.
6602 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6603 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6604 needed otherwise.
6605 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6606 (GC_STRING_CHARS): Remove; not used.
6607 (Fmemory_limit): Cast sbrk's returned value to char *.
6608
6609 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6610 avoids undefined behavior in theory.
6611
6612 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6613
6614 Use functions, not macros, for up- and down-casing (Bug#8254).
6615 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6616 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6617 to use the following functions instead of these macros.
6618 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6619 EMACS_INT, since callers assume the returned value fits in int.
6620 (upcase1): Likewise, for UPCASE_TABLE.
6621 (uppercasep, lowercasep, upcase): New static inline functions.
6622 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6623 the race-condition problem in the old DOWNCASE.
6624
6625 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6626 Rename locals to avoid shadowing.
6627 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6628 (regex_compile, re_search_2, re_match_2_internal):
6629 Remove unused local vars.
6630 (FREE_VAR): Rewrite so as not to use empty "else",
6631 which gcc can warn about.
6632 (regex_compile, re_match_2_internal): Mark locals as initialized.
6633 (RETALLOC_IF): Define only if needed.
6634 (WORDCHAR_P): Likewise. This one is never needed, but is used
6635 only in a comment talking about a compiler bug, so put inside
6636 the #if 0 of that comment.
6637 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6638 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6639 Remove; unused.
6640
6641 * search.c (boyer_moore): Rename locals to avoid shadowing.
6642 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6643 (PREV_CHAR_BOUNDARY): Likewise.
6644
6645 * search.c (simple_search): Remove unused var.
6646
6647 * dired.c (compile_pattern): Move decl from here ...
6648 * lisp.h: ... to here, so that it can be checked.
6649 (struct re_registers): New forward decl.
6650
6651 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6652
6653 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6654 All uses changed.
6655 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6656 Rename locals to avoid shadowing.
6657 (Fvertical_motion): Mark locals as initialized.
6658
6659 * casefiddle.c (casify_object, casify_region): Now static.
6660 (casify_region): Mark local as initialized.
6661
6662 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6663
6664 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6665 New macros, so that the caller can use some names other than
6666 gcpro1, gcpro2, etc.
6667 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6668 of the new macros.
6669 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6670 argument, for consistency with GCPRO2_VAR, etc: it is now the
6671 prefix of the variable, not the variable itself. All uses
6672 changed.
6673 * dired.c (directory_files_internal, file_name_completion):
6674 Rename locals to avoid shadowing.
6675
6676 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6677 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6678 dired.c's scmp function, had undefined behavior.
6679 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6680 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6681 * buffer.h: ... to here, because these macros use current_buffer,
6682 and the new implementation with inline functions needs to have
6683 current_buffer in scope now, rather than later when the macros
6684 are used.
6685 (downcase, upcase1): New static inline functions.
6686 (DOWNCASE, UPCASE1): Reimplement using these functions.
6687 This avoids undefined behavior in expressions like
6688 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6689 from race conditions in accessing the global variables
6690 case_temp1 and case_temp2.
6691 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6692 * lisp.h (case_temp1, case_temp2): Remove their decls.
6693 * character.h (ASCII_CHAR_P): Move from here ...
6694 * lisp.h: ... to here, so that the inline functions mentioned
6695 above can use them.
6696
6697 * dired.c (directory_files_internal_unwind): Now static.
6698
6699 * fileio.c (file_name_as_directory, directory_file_name):
6700 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6701 Now static.
6702 (file_name_as_directory): Use const pointers when appropriate.
6703 (Fexpand_file_name): Likewise. In particular, newdir might
6704 point at constant storage, so make it a const pointer.
6705 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6706 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6707 signedness issues.
6708 (Fset_file_times, Finsert_file_contents, auto_save_error):
6709 Rename locals to avoid shadowing.
6710
6711 * minibuf.c (choose_minibuf_frame_1): Now static.
6712 (Ftry_completion, Fall_completions): Rename or remove locals
6713 to avoid shadowing.
6714
6715 * marker.c (bytepos_to_charpos): Remove; unused.
6716
6717 * lisp.h (verify_bytepos, count_markers): New decls,
6718 so that gcc does not warn that these functions aren't declared.
6719
6720 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6721 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6722 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6723 (copy_text): Remove unused local var.
6724
6725 * filelock.c (within_one_second): Now static.
6726 (lock_file_1): Rename local to avoid shadowing.
6727
6728 * buffer.c (fix_overlays_before): Mark locals as initialized.
6729 (fix_start_end_in_overlays): Likewise. This function should be
6730 simplified by using pointers-to-pointers, but that's a different
6731 matter.
6732 (switch_to_buffer_1): Now static.
6733 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6734 (report_overlay_modification): Rename locals to avoid shadowing.
6735
6736 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6737 Fix pointer signedness issue.
6738 (sys_subshell): Mark local as volatile if checking for lint,
6739 to suppress a gcc -Wclobbered warning that does not seem to be right.
6740 (MAXPATHLEN): Define only if needed.
6741
6742 * process.c (serial_open, serial_configure): Move decls from here ...
6743 * systty.h: ... to here, so that they can be checked.
6744
6745 * fns.c (get_random, seed_random): Move extern decls from here ...
6746 * lisp.h: ... to here, so that they can be checked.
6747
6748 * sysdep.c (reset_io): Now static.
6749 (wait_for_termination_signal): Remove; unused.
6750
6751 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6752 (copy_keymap_item, append_key, push_text_char_description):
6753 Now static.
6754 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6755 (DENSE_TABLE_SIZE): Remove; unused.
6756 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6757 (describe_map_tree):
6758 Rename locals to avoid shadowing.
6759
6760 * keyboard.c: Declare functions static if they are not used elsewhere.
6761 (echo_char, echo_dash, cmd_error, top_level_2):
6762 (poll_for_input, handle_async_input): Now static.
6763 (read_char, kbd_buffer_get_event, make_lispy_position):
6764 (make_lispy_event, make_lispy_movement, apply_modifiers):
6765 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6766 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6767 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6768 (read_key_sequence, read_char): Mark locals as initialized.
6769 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6770
6771 * keyboard.h (make_ctrl_char): New decl.
6772 (mark_kboards): Move decl here ...
6773 * alloc.c (mark_kboards): ... from here.
6774
6775 * lisp.h (force_auto_save_soon): New decl.
6776
6777 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6778 (DEFINE_DUMMY_FUNCTION): New macro.
6779 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6780 Use it.
6781 (main): Add casts to avoid warnings
6782 if GCC considers string literals to be constants.
6783
6784 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6785
6786 * dbusbind.c: Pointer signedness fixes.
6787 (xd_signature, xd_append_arg, xd_initialize):
6788 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6789 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6790 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6791 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6792
6793 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6794 if GCC considers string literals to be constants.
6795 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6796
6797 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6798
6799 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6800 (print_preprocess, print_object): New macro to fix last change.
6801
6802 * print.c (print_preprocess): Don't forget font objects.
6803
6804 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6805
6806 * emacs.c (USAGE3): Doc fixes.
6807
6808 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6809
6810 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6811 structure.
6812
6813 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6814
6815 * lisp.h (VWindow_system, Qfile_name_history):
6816 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6817 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6818 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6819
6820 * w32select.c: Don't #include "keyboard.h".
6821 (run_protected): Add extern declaration for waiting_for_input.
6822
6823 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6824 * w32console.c (detect_input_pending, read_input_pending)
6825 (encode_terminal_code):
6826 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6827 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6828 (w32_system_caret_y, Qfile_name_history):
6829 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6830 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6831 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6832 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6833 * w32proc.c (Qlocal, report_file_error):
6834 * w32term.c (Vwindow_system, updating_frame):
6835 * w32uniscribe.c (initialized, uniscribe_font_driver):
6836 Remove unneeded extern declarations.
6837
6838 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6839
6840 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6841
6842 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6843
6844 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6845 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6846 These macros can no longer be used for assignment.
6847
6848 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6849 Assign struct members directly, instead of using BUF_BEGV etc.
6850 (record_buffer_markers, fetch_buffer_markers): New functions for
6851 recording and fetching special buffer markers.
6852 (set_buffer_internal_1, set_buffer_temp): Use them.
6853
6854 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6855
6856 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6857
6858 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6859 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6860
6861 * xdisp.c (hscroll_window_tree):
6862 (reconsider_clip_changes): Use PT instead of BUF_PT.
6863
6864 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6865
6866 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6867 $(EMACS_ROOT)/lib/intprops.h.
6868
6869 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6870
6871 Fix more problems found by GCC 4.5.2's static checks.
6872
6873 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6874 to unsigned char * to avoid compiler diagnostic.
6875 (xg_free_frame_widgets): Make it clear that a local variable is
6876 needed only if USE_GTK_TOOLTIP.
6877 (gdk_window_get_screen): Make it clear that this macro is needed
6878 only if USE_GTK_TOOLTIP.
6879 (int_gtk_range_get_value): New function, which avoids a diagnostic
6880 from gcc -Wbad-function-cast.
6881 (xg_set_toolkit_scroll_bar_thumb): Use it.
6882 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6883 diagnostic from gcc -Wbad-function-cast.
6884 (get_utf8_string, xg_get_file_with_chooser):
6885 Rename locals to avoid shadowing.
6886 (create_dialog): Move locals to avoid shadowing.
6887
6888 * xgselect.c (xg_select): Remove unused var.
6889
6890 * image.c (four_corners_best): Mark locals as initialized.
6891 (gif_load): Initialize transparent_p to zero (Bug#8238).
6892 Mark another local as initialized.
6893 (my_png_error, my_error_exit): Mark with NO_RETURN.
6894
6895 * image.c (clear_image_cache): Now static.
6896 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6897 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6898 (x_edge_detection): Remove unnecessary cast that
6899 gcc -Wbad-function-cast diagnoses.
6900 (gif_load): Fix pointer signedness.
6901 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6902 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6903
6904 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6905
6906 Improve quality of tests for time stamp overflow.
6907 For example, without this patch (encode-time 0 0 0 1 1
6908 1152921504606846976) returns the obviously-bogus value (-948597
6909 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6910 reports time overflow. See
6911 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6912 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6913 * editfns.c: Include limits.h and intprops.h.
6914 (TIME_T_MIN, TIME_T_MAX): New macros.
6915 (time_overflow): Move earlier, to before first use.
6916 (hi_time, lo_time): New functions, for an accurate test for
6917 out-of-range times.
6918 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6919 (Fget_internal_run_time): Don't assume time_t fits in int.
6920 (make_time): Use list2 instead of Fcons twice.
6921 (Fdecode_time): More accurate test for out-of-range times.
6922 (check_tm_member): New function.
6923 (Fencode_time): Use it, to test for out-of-range times.
6924 (lisp_time_argument): Don't rely on undefined left-shift and
6925 right-shift behavior when checking for time stamp overflow.
6926
6927 * editfns.c (time_overflow): New function, refactoring common code.
6928 (Fformat_time_string, Fdecode_time, Fencode_time):
6929 (Fcurrent_time_string): Use it.
6930
6931 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6932 * dired.c (make_time): Move to ...
6933 * editfns.c (make_time): ... here.
6934 * systime.h: Note the move.
6935
6936 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6937
6938 * fringe.c (update_window_fringes): Remove unused variables.
6939
6940 * unexmacosx.c (copy_data_segment): Also copy __got section.
6941 (Bug#8223)
6942
6943 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6944
6945 * termcap.c [MSDOS]: Include "msdos.h".
6946 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6947 Constify `char *' arguments and their references according to
6948 prototypes in tparam.h.
6949
6950 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6951
6952 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6953 Adapt all references accordingly.
6954
6955 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6956
6957 2011-03-11 Tom Tromey <tromey@redhat.com>
6958
6959 * buffer.c (syms_of_buffer): Remove obsolete comment.
6960
6961 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6962
6963 * termhooks.h (encode_terminal_code): Declare prototype.
6964
6965 * msdos.c (encode_terminal_code): Don't declare prototype.
6966
6967 * term.c (encode_terminal_code): Now external again, used by
6968 w32console.c and msdos.c.
6969
6970 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6971 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6972
6973 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6974
6975 Fix some minor problems found by GCC 4.5.2's static checks.
6976
6977 * fringe.c (update_window_fringes): Mark locals as initialized
6978 (Bug#8227).
6979 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6980
6981 * alloc.c (mark_fringe_data): Move decl from here ...
6982 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6983 to check its interface.
6984 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6985
6986 * fontset.c (free_realized_fontset): Now static.
6987 (Fset_fontset_font): Rename local to avoid shadowing.
6988 (fontset_font): Mark local as initialized.
6989 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6990
6991 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6992
6993 * xselect.c (x_disown_buffer_selections): Remove; not used.
6994 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6995 (x_own_selection, Fx_disown_selection_internal): Rename locals
6996 to avoid shadowing.
6997 (x_handle_dnd_message): Remove local to avoid shadowing.
6998
6999 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7000 so that the caller can use some name other than gcpro1.
7001 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7002 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7003 (Fx_backspace_delete_keys_p):
7004 Use them to avoid shadowing, and rename vars to avoid shadowing.
7005 (x_decode_color, x_set_name, x_window): Now static.
7006 (Fx_create_frame): Add braces to silence GCC warning.
7007 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7008 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7009 Remove unused locals.
7010 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7011 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7012 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7013 macros.
7014
7015 * xterm.h (x_mouse_leave): New decl.
7016
7017 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7018 Remove unused functions.
7019 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7020 (x_calc_absolute_position): Now static.
7021 (XTread_socket): Don't define label "out" unless it's used.
7022 Don't declare local "event" unless it's used.
7023 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7024 unless they are used.
7025 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7026 (x_fatal_error_signal): Remove; not used.
7027 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7028 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7029 (x_error_catcher, x_connection_closed, x_error_handler):
7030 (x_error_quitter, xembed_send_message, x_iconify_frame):
7031 (my_log_handler): Rename locals to avoid shadowing.
7032 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7033 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7034
7035 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7036 Rename or move locals to avoid shadowing.
7037 (tty_defined_color, merge_face_heights): Now static.
7038 (free_realized_faces_for_fontset): Remove; not used.
7039 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7040 does not deduce is never used uninitialized.
7041 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7042 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7043
7044 * terminal.c (store_terminal_param): Now static.
7045
7046 * xmenu.c (menu_highlight_callback): Now static.
7047 (set_frame_menubar): Remove unused local.
7048 (xmenu_show): Rename parameter to avoid shadowing.
7049 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7050 since they might point to immutable storage.
7051 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7052 since it's unused otherwise.
7053
7054 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7055 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7056 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7057 avoids a gcc -Wuninitialized diagnostic.
7058 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7059 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7060 does not deduce are never used uninitialized.
7061
7062 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7063
7064 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7065 * window.c (window_loop, size_window):
7066 (run_window_configuration_change_hook, enlarge_window): Likewise.
7067
7068 * window.c (display_buffer): Now static.
7069 (size_window): Mark variables that gcc -Wuninitialized
7070 does not deduce are never used uninitialized.
7071 * window.h (check_all_windows): New decl, to forestall
7072 gcc -Wmissing-prototypes diagnostic.
7073 * dispextern.h (bidi_dump_cached_states): Likewise.
7074
7075 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7076 shadowing.
7077 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7078 Include <limits.h>.
7079 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7080 and to avoid gcc -Wuninitialized warning.
7081 (load_charset_map): Mark variables that gcc -Wuninitialized
7082 does not deduce are never used uninitialized.
7083 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7084
7085 * coding.c (coding_set_source, coding_set_destination):
7086 Use "else { /* comment */ }" rather than "else /* comment */;"
7087 for clarity, and to avoid gcc -Wempty-body warning.
7088 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7089 a block, when the outer 'i' will do.
7090 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7091 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7092 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7093 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7094 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7095 Rename locals to avoid shadowing.
7096 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7097 * coding.c (emacs_mule_char, encode_invocation_designation):
7098 Now static, since they're not used elsewhere.
7099 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7100 (decode_coding_object, encode_coding_object, detect_coding_system):
7101 (decode_coding_emacs_mule): Mark variables that gcc
7102 -Wuninitialized does not deduce are never used uninitialized.
7103 (detect_coding_iso_2022): Initialize a local variable that might
7104 be used uninitialized. Leave a FIXME because it's not clear that
7105 this initialization is needed. (Bug#8211)
7106 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7107 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7108 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7109 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7110 Remove unused macros.
7111
7112 * category.c (hash_get_category_set): Remove unused local var.
7113 (copy_category_table): Now static, since it's not used elsewhere.
7114 * character.c (string_count_byte8): Likewise.
7115
7116 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7117 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7118
7119 * chartab.c (copy_sub_char_table): Now static, since it's not used
7120 elsewhere.
7121 (sub_char_table_ref_and_range, char_table_ref_and_range):
7122 Rename locals to avoid shadowing.
7123 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7124
7125 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7126 (BIDI_BOB): Remove unused macro.
7127
7128 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7129 deduce are never used uninitialized.
7130 * term.c (encode_terminal_code): Likewise.
7131
7132 * term.c (encode_terminal_code): Now static. Remove unused local.
7133
7134 * tparam.h: New file.
7135 * term.c, tparam.h: Include it.
7136 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7137 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7138 Move these decls to tparam.h, and make them agree with what
7139 is actually in tparam.c. The previous trick of using incompatible
7140 decls in different modules does not conform to the C standard.
7141 All callers of tparam changed to use tparam's actual API.
7142 * tparam.c (tparam1, tparam, tgoto):
7143 Use const pointers where appropriate.
7144
7145 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7146 * cm.h (struct cm): Likewise.
7147 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7148 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7149 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7150 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7151 (turn_on_face, init_tty): Likewise.
7152 * termchar.h (struct tty_display_info): Likewise.
7153
7154 * term.c (term_mouse_position): Rename local to avoid shadowing.
7155
7156 * alloc.c (mark_ttys): Move decl from here ...
7157 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7158
7159 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7160
7161 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7162
7163 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7164
7165 * search.c (compile_pattern_1): Remove argument regp, unused since
7166 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7167 (compile_pattern): Don't pass it.
7168
7169 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7170
7171 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7172 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7173 for ! HAVE_GTK3.
7174 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7175
7176 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7177
7178 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7179 gdk_window_get_screen, gdk_window_get_geometry,
7180 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7181 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7182 (xg_get_pixbuf_from_pixmap): New function.
7183 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7184 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7185 Call xg_get_pixbuf_from_pixmap instead of
7186 gdk_pixbuf_get_from_drawable.
7187 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7188 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7189 (xg_check_special_colors): Use GtkStyleContext and its functions
7190 for HAVE_GTK3.
7191 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7192 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7193 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7194 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7195 Call gtk_widget_get_preferred_size.
7196 (xg_frame_resized): gdk_window_get_geometry only takes 5
7197 parameters.
7198 (xg_win_to_widget, xg_event_is_for_menubar):
7199 Call gdk_x11_window_lookup_for_display.
7200 (xg_set_widget_bg): New function.
7201 (delete_cb): New function.
7202 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7203 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7204 (xg_set_background_color): Call xg_set_widget_bg.
7205 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7206 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7207 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7208 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7209 if ! HAVE_GTK3.
7210 (update_frame_tool_bar): Call gtk_widget_hide.
7211 (xg_initialize): Use GDK_KEY_g.
7212
7213 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7214 if ! HAVE_GTK3
7215 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7216
7217 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7218 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7219 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7220
7221 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7222
7223 * w32xfns.c (select_palette): Check success of RealizePalette against
7224 GDI_ERROR, not zero.
7225
7226 See ChangeLog.11 for earlier changes.
7227
7228 ;; Local Variables:
7229 ;; coding: utf-8
7230 ;; End:
7231
7232 Copyright (C) 2011 Free Software Foundation, Inc.
7233
7234 This file is part of GNU Emacs.
7235
7236 GNU Emacs is free software: you can redistribute it and/or modify
7237 it under the terms of the GNU General Public License as published by
7238 the Free Software Foundation, either version 3 of the License, or
7239 (at your option) any later version.
7240
7241 GNU Emacs is distributed in the hope that it will be useful,
7242 but WITHOUT ANY WARRANTY; without even the implied warranty of
7243 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7244 GNU General Public License for more details.
7245
7246 You should have received a copy of the GNU General Public License
7247 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.