* buffer.c (struct sortvec.priority): Now EMACS_INT, not int.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
2
3 * buffer.c (struct sortvec.priority): Now EMACS_INT, not int.
4
5 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6
7 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10
11 Improve buffer-overflow checking (Bug#8873).
12 * fileio.c (Finsert_file_contents):
13 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
14 Remove the old (too-loose) buffer overflow checks.
15 They weren't needed, since make_gap checks for buffer overflow.
16 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
17 The old code merely checked for Emacs fixnum overflow, and relied
18 on undefined (wraparound) behavior. The new code avoids undefined
19 behavior, and also checks for ptrdiff_t and/or size_t overflow.
20
21 * editfns.c (Finsert_char): Don't dump core with very negative counts.
22 Tune. Don't use wider integers than needed. Don't use alloca.
23 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
24
25 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
26
27 * insdel.c, lisp.h (buffer_overflow): New function.
28 (insert_from_buffer_1, replace_range, replace_range_2):
29 * insdel.c (make_gap_larger):
30 * editfns.c (Finsert_char):
31 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
32
33 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
34
35 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
36
37 Integer overflow and signedness fixes (Bug#8873).
38
39 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
40 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
41
42 * fileio.c: Don't assume EMACS_INT fits in off_t.
43 (emacs_lseek): New static function.
44 (Finsert_file_contents, Fwrite_region): Use it.
45 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
46
47 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
48
49 * fns.c: Don't overflow int when computing a list length.
50 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
51 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
52 truncation on 64-bit hosts. Check for QUIT every
53 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
54 faster and is responsive enough.
55 (Flength): Report an error instead of overflowing an integer.
56 (Fsafe_length): Return a float if the value is not representable
57 as a fixnum. This shouldn't happen except in contrived situations.
58 (Fnthcdr, Fsort): Don't assume list length fits in int.
59 (Fcopy_sequence): Don't assume vector length fits in int.
60
61 * alloc.c: Check that resized vectors' lengths fit in fixnums.
62 (header_size, word_size): New constants.
63 (allocate_vectorlike): Don't check size overflow here.
64 (allocate_vector): Check it here instead, since this is the only
65 caller of allocate_vectorlike that could cause overflow.
66 Check that the new vector's length is representable as a fixnum.
67
68 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
69 The previous code was bogus. For example, next_almost_prime (32)
70 returned 39, which is undesirable as it is a multiple of 3; and
71 next_almost_prime (24) returned 25, which is a multiple of 5 so
72 why was the code bothering to check for multiples of 7?
73
74 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
75
76 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
77
78 Variadic C functions now count arguments with ptrdiff_t.
79 This partly undoes my 2011-03-30 change, which replaced int with size_t.
80 Back then I didn't know that the Emacs coding style prefers signed int.
81 Also, in the meantime I found a few more instances where arguments
82 were being counted with int, which may truncate counts on 64-bit
83 machines, or EMACS_INT, which may be unnecessarily wide.
84 * lisp.h (struct Lisp_Subr.function.aMANY)
85 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
86 Arg counts are now ptrdiff_t, not size_t.
87 All variadic functions and their callers changed accordingly.
88 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
89 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
90 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
91 * callint.c (Fcall_interactively): Check arg count for overflow,
92 to avoid potential buffer overrun. Use signed char, not 'int',
93 for 'varies' array, so that we needn't bother to check its size
94 calculation for overflow.
95 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
96 * eval.c (apply_lambda):
97 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
98 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
99 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
100
101 * callint.c (Fcall_interactively): Don't use index var as event count.
102
103 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
104 * mem-limits.h (SIZE): Remove; no longer used.
105
106 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
107
108 Remove unnecessary casts.
109 * xterm.c (x_term_init):
110 * xfns.c (x_set_border_pixel):
111 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
112 These aren't needed now that we assume ANSI C.
113
114 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
115 It's more likely to cause problems (due to unsigned overflow)
116 than to cure them.
117
118 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
119
120 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
121
122 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
123
124 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
125
126 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
127
128 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
129
130 GLYPH_CODE_FACE returns EMACS_INT, not int.
131 * dispextern.h (merge_faces):
132 * xfaces.c (merge_faces):
133 * xdisp.c (get_next_display_element, next_element_from_display_vector):
134 Don't assume EMACS_INT fits in int.
135
136 * character.h (CHAR_VALID_P): Remove unused parameter.
137 * fontset.c, lisp.h, xdisp.c: All uses changed.
138
139 * editfns.c (Ftranslate_region_internal): Omit redundant test.
140
141 * fns.c (concat): Minor tuning based on overflow analysis.
142 This doesn't fix any bugs. Use int to hold character, instead
143 of constantly refetching from Emacs object. Use XFASTINT, not
144 XINT, for value known to be a character. Don't bother comparing
145 a single byte to 0400, as it's always less.
146
147 * floatfns.c (Fexpt):
148 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
149
150 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
151 for characters.
152
153 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
154
155 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
156 Without this fix, on a 64-bit host (aset S 0 4294967386) would
157 incorrectly succeed when S was a string, because 4294967386 was
158 truncated before it was used.
159
160 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
161 Otherwise, an out-of-range integer could cause undefined behavior
162 on a 64-bit host.
163
164 * composite.c: Use int, not EMACS_INT, for characters.
165 (fill_gstring_body, composition_compute_stop_pos): Use int, not
166 EMACS_INT, for values that are known to be in character range.
167 This doesn't fix any bugs but is the usual style inside Emacs and
168 may generate better code on 32-bit machines.
169
170 Make sure a 64-bit char is never passed to ENCODE_CHAR.
171 This is for reasons similar to the recent CHAR_STRING fix.
172 * charset.c (Fencode_char): Check that character arg is actually
173 a character. Pass an int to ENCODE_CHAR.
174 * charset.h (ENCODE_CHAR): Verify that the character argument is no
175 wider than 'int', as a compile-time check to prevent future regressions
176 in this area.
177
178 * character.c (char_string): Remove unnecessary casts.
179
180 Make sure a 64-bit char is never passed to CHAR_STRING.
181 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
182 by silently ignoring the top 32 bits, allowing some values
183 that were far too large to be valid characters.
184 * character.h: Include <verify.h>.
185 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
186 arguments are no wider than unsigned, as a compile-time check
187 to prevent future regressions in this area.
188 * data.c (Faset):
189 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
190 (Fsubst_char_in_region):
191 * fns.c (concat):
192 * xdisp.c (decode_mode_spec_coding):
193 Adjust to CHAR_STRING's new requirement.
194 * editfns.c (Finsert_char, Fsubst_char_in_region):
195 * fns.c (concat): Check that character args are actually
196 characters. Without this test, these functions did the wrong
197 thing with wildly out-of-range values on 64-bit hosts.
198
199 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
200 These casts should not be needed on 32-bit hosts, either.
201 * keyboard.c (read_char):
202 * lread.c (Fload): Remove casts to unsigned.
203
204 * lisp.h (UNSIGNED_CMP): New macro.
205 This fixes comparison bugs on 64-bit hosts.
206 (ASCII_CHAR_P): Use it.
207 * casefiddle.c (casify_object):
208 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
209 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
210 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
211 * dispextern.h (FACE_FROM_ID):
212 * keyboard.c (read_char): Use UNSIGNED_CMP.
213
214 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
215 not to EMACS_INT, to avoid GCC warning.
216
217 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
218
219 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
220 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
221 isn't needed on 32-bit machines.
222
223 * buffer.c (Fgenerate_new_buffer_name):
224 Use EMACS_INT for count, not int.
225 (advance_to_char_boundary): Return EMACS_INT, not int.
226
227 * data.c (Qcompiled_function): Now static.
228
229 * window.c (window_body_lines): Now static.
230
231 * image.c (gif_load): Rename local to avoid shadowing.
232
233 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
234 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
235 * alloc.c (make_save_value): Integer argument is now of type
236 ptrdiff_t, not int.
237 (mark_object): Use ptrdiff_t, not int.
238 * lisp.h (pD): New macro.
239 * print.c (print_object): Use it.
240
241 * alloc.c: Use EMACS_INT, not int, to count objects.
242 (total_conses, total_markers, total_symbols, total_vector_size)
243 (total_free_conses, total_free_markers, total_free_symbols)
244 (total_free_floats, total_floats, total_free_intervals)
245 (total_intervals, total_strings, total_free_strings):
246 Now EMACS_INT, not int. All uses changed.
247 (Fgarbage_collect): Compute overall total using a double, so that
248 integer overflow is less likely to be a problem. Check for overflow
249 when converting back to an integer.
250 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
251 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
252 These were 'int' variables that could overflow on 64-bit hosts;
253 they were never used, so remove them instead of repairing them.
254 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
255 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
256 Previously, this ceilinged at INT_MAX, but that doesn't work on
257 64-bit machines.
258 (allocate_pseudovector): Don't use EMACS_INT when int would do.
259
260 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
261 (allocate_vectorlike): Check for ptrdiff_t overflow.
262 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
263 when a (possibly-narrower) signed value would do just as well.
264 We prefer using signed arithmetic, to avoid comparison confusion.
265
266 * alloc.c: Catch some string size overflows that we were missing.
267 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
268 for convenience in STRING_BYTES_MAX.
269 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
270 The definition here is exact; the one in lisp.h was approximate.
271 (allocate_string_data): Check for string overflow. This catches
272 some instances we weren't catching before. Also, it catches
273 size_t overflow on (unusual) hosts where SIZE_MAX <= min
274 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
275 and ptrdiff_t and EMACS_INT are both 64 bits.
276
277 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
278 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
279 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
280
281 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
282
283 * alloc.c (Fmake_string): Check for out-of-range init.
284
285 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
286
287 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
288
289 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
290
291 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
292 xg_get_default_scrollbar_width.
293
294 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
295 (int_gtk_range_get_value): Move to the scroll bar part of the file.
296 (style_changed_cb): Call update_theme_scrollbar_width and call
297 x_set_scroll_bar_default_width and xg_frame_set_char_size for
298 all frames (Bug#8505).
299 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
300 Call gtk_window_set_resizable if HAVE_GTK3.
301 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
302 and height if HAVE_GTK3 (Bug#8505).
303 (scroll_bar_width_for_theme): New variable.
304 (update_theme_scrollbar_width): New function.
305 (xg_get_default_scrollbar_width): Move code to
306 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
307 (xg_initialize): Call update_theme_scrollbar_width.
308
309 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
310
311 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
312
313 2011-06-12 Martin Rudalics <rudalics@gmx.at>
314
315 * frame.c (make_frame): Call other_buffer_safely instead of
316 other_buffer.
317
318 * window.c (temp_output_buffer_show): Call display_buffer with
319 second argument Vtemp_buffer_show_specifiers and reset latter
320 immediately after the call.
321 (Vtemp_buffer_show_specifiers): New variable.
322 (auto_window_vscroll_p, next_screen_context_lines)
323 (Vscroll_preserve_screen_position): Remove leading asterisks from
324 doc-strings.
325
326 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
327
328 Fix minor problems found by GCC 4.6.0 static checking.
329 * buffer.c (Qclone_number): Remove for now, as it's unused.
330 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
331 (record_buffer): Remove unused local.
332 * frame.c (other_visible_frames, frame_buffer_list): Now static.
333 (set_frame_buffer_list): Remove; unused.
334 * frame.h (other_visible_frames): Remove decl.
335 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
336 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
337 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
338 if HAVE_GPM.
339 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
340 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
341 Define only if HAVE_GPM.
342 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
343 (update_hints_inhibit): Remove; never set. All uses removed.
344 * widgetprv.h (emacsFrameClassRec): Remove decl.
345 * window.c (delete_deletable_window): Now returns void, since it
346 wasn't returning anything.
347 (compare_window_configurations): Remove unused locals.
348 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
349 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
350 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
351 the same widths as pointers. This follows up on the 2011-05-06 patch.
352 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
353 * xterm.h: Likewise.
354 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
355
356 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
357
358 * makefile.w32-in: Update dependencies.
359 (LISP_H): Add lib/intprops.h.
360
361 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
362
363 * image.c (gif_load): Add animation frame delay to the metadata.
364 (syms_of_image): Use DEFSYM. New symbol `delay'.
365
366 2011-06-11 Martin Rudalics <rudalics@gmx.at>
367
368 * window.c (delete_deletable_window): Re-add.
369 (Fset_window_configuration): Rewrite to handle dead buffers and
370 consequently deletable windows.
371 (window_tree, Fwindow_tree): Remove. Supply functionality in
372 window.el.
373 (compare_window_configurations): Simplify code.
374
375 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
376
377 * image.c (imagemagick_load_image): Fix type mismatch.
378 (Fimagemagick_types): Likewise.
379
380 * window.h (replace_buffer_in_windows): Declare.
381
382 2011-06-11 Martin Rudalics <rudalics@gmx.at>
383
384 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
385 Qclone_number. Remove external declaration of Qdelete_window.
386 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
387 code.
388 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
389 Qbuffer_list_update_hook if allowed.
390 (Fother_buffer): Rewrite doc-string. Major rewrite for new
391 buffer list implementation.
392 (other_buffer_safely): New function.
393 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
394 calls to replace_buffer_in_windows and
395 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
396 if allowed.
397 (record_buffer): Inhibit quitting and rewrite using quittable
398 functions. Run Qbuffer_list_update_hook if allowed.
399 (Frecord_buffer, Funrecord_buffer): New functions.
400 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
401 switch-to-buffer to window.el.
402 (bury-buffer): Move to window.el.
403 (Vbuffer_list_update_hook): New variable.
404
405 * lisp.h (other_buffer_safely): Add prototype in buffer.c
406 section.
407
408 * window.h (resize_frame_windows): Move up in code.
409 (Fwindow_frame): Remove EXFUN.
410 (replace_buffer_in_all_windows): Remove prototype.
411 (replace_buffer_in_windows_safely): Add prototype.
412
413 * window.c: Declare Qdelete_window static again. Move down
414 declaration of select_count.
415 (Fnext_window, Fprevious_window): Rewrite doc-strings.
416 (Fother_window): Move to window.el.
417 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
418 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
419 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
420 window.el.
421 (replace_buffer_in_windows): Implement by calling
422 Qreplace_buffer_in_windows.
423 (replace_buffer_in_all_windows): Remove with some functionality
424 moved into replace_buffer_in_windows_safely.
425 (replace_buffer_in_windows_safely): New function.
426 (select_window_norecord, select_frame_norecord): Move in front
427 of run_window_configuration_change_hook. Remove now obsolete
428 declarations.
429 (Fset_window_buffer): Rewrite doc-string. Call
430 Qrecord_window_buffer.
431 (keys_of_window): Move binding for other-window to window.el.
432
433 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
434
435 * dispextern.h (struct image): Replace data member, whose int_val
436 and ptr_val fields were not used by anything, with a single
437 lisp_val object.
438
439 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
440 (gif_clear_image, gif_load, imagemagick_load_image)
441 (gs_clear_image, gs_load): Callers changed.
442
443 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
444
445 * buffer.h: Include <time.h>, for time_t.
446 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
447
448 Fix minor problems found by static checking.
449
450 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
451
452 Make identifiers static if they are not used in other modules.
453 * data.c (Qcompiled_function, Qframe, Qvector):
454 * image.c (QimageMagick, Qsvg):
455 * minibuf.c (Qmetadata):
456 * window.c (resize_window_check, resize_root_window): Now static.
457 * window.h (resize_window_check, resize_root_window): Remove decls.
458
459 * window.c (window_deletion_count, delete_deletable_window):
460 Remove; unused.
461 (window_body_lines): Now static.
462 (Fdelete_other_windows_internal): Mark vars as initialized.
463 Make sure 'resize_failed' is initialized.
464 (run_window_configuration_change_hook): Rename local to avoid shadowing.
465 (resize_window_apply): Remove unused local.
466 * window.h (delete_deletable_window): Remove decl.
467
468 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
469 (imagemagick_load_image): Fix pointer signedness problem by changing
470 last arg from unsigned char * to char *. All uses changed.
471 Also, fix a local for similar reasons.
472 Remove unused locals. Remove locals to avoid shadowing.
473 (fn_rsvg_handle_free): Remove; unused.
474 (svg_load, svg_load_image): Fix pointer signedness problem.
475 (imagemagick_load_image): Don't use garbage pointer image_wand.
476
477 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
478
479 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
480
481 * image.c (gif_load): Fix omitted cast error introduced by
482 2011-06-06 change.
483
484 2011-06-10 Martin Rudalics <rudalics@gmx.at>
485
486 * window.h (resize_proportionally, orig_total_lines)
487 (orig_top_line): Remove from window structure.
488 (set_window_height, set_window_width, change_window_heights)
489 (Fdelete_window): Remove prototypes.
490 (resize_frame_windows): Remove duplicate declaration.
491
492 2011-06-10 Eli Zaretskii <eliz@gnu.org>
493
494 * window.h (resize_frame_windows, resize_window_check)
495 (delete_deletable_window, resize_root_window)
496 (resize_frame_windows): Declare prototypes.
497
498 * window.c (resize_window_apply): Make definition be "static" to
499 match the prototype.
500
501 2011-06-10 Martin Rudalics <rudalics@gmx.at>
502
503 * window.c: Remove declarations of Qwindow_size_fixed,
504 window_min_size_1, window_min_size_2, window_min_size,
505 size_window, window_fixed_size_p, enlarge_window, delete_window.
506 Remove static from declaration of Qdelete_window, it's
507 temporarily needed by Fbury_buffer.
508 (replace_window): Don't assign orig_top_line and
509 orig_total_lines.
510 (Fdelete_window, delete_window): Remove. Window deletion is
511 handled by window.el.
512 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
513 Fdelete_window calls with calls to Qdelete_window.
514 (Fdelete_other_windows): Remove. Deleting other windows is
515 handled by window.el.
516 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
517 handled in window.el.
518 (window_min_size_2, window_min_size_1, window_min_size): Remove.
519 Window minimum sizes are handled in window.el.
520 (shrink_windows, size_window, set_window_height)
521 (set_window_width, change_window_heights, window_height)
522 (window_width, CURBEG, CURSIZE, enlarge_window)
523 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
524 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
525 handled in window.el.
526 (make_dummy_parent): Rename to make_parent_window and give it a
527 second argument horflag.
528 (make_window): Don't set resize_proportionally any more.
529 (Fsplit_window): Remove. Windows are split in window.el.
530 (save_restore_action, save_restore_orig_size)
531 (shrink_window_lowest_first, save_restore_orig_size): Remove.
532 Resize mini windows in window.el.
533 (grow_mini_window, shrink_mini_window): Implement by calling
534 Qresize_root_window_vertically, resize_window_check and
535 resize_window_apply.
536 (saved_window, Fset_window_configuration, save_window_save): Do
537 not handle orig_top_line, orig_total_lines, and
538 resize_proportionally.
539 (window_min_height, window_min_width): Move to window.el.
540 (keys_of_window): Move bindings for delete-other-windows,
541 split-window, delete-window and enlarge-window to window.el.
542
543 * buffer.c: Temporarily extern Qdelete_window.
544 (Fbury_buffer): Temporarily call Qdelete_window instead of
545 Fdelete_window (Fbury_buffer will move to window.el soon).
546
547 * frame.c (set_menu_bar_lines_1): Remove code handling
548 orig_top_line and orig_total_lines.
549
550 * dispnew.c (adjust_frame_glyphs_initially): Don't use
551 set_window_height but set heights directly.
552 (change_frame_size_1): Use resize_frame_windows.
553
554 * xdisp.c (init_xdisp): Don't use set_window_height but set
555 heights directly.
556
557 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
558 resize_frame_windows instead of change_window_heights and run
559 run_window_configuration_change_hook.
560
561 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
562 instead of change_window_heights and run
563 run_window_configuration_change_hook.
564
565 2011-06-09 Martin Rudalics <rudalics@gmx.at>
566
567 * window.c (replace_window): Rename second argument REPLACEMENT to
568 NEW. New third argument SETFLAG. Rewrite.
569 (delete_window, make_dummy_parent): Call replace_window with
570 third argument 1.
571 (window_list_1): Move down in code.
572 (run_window_configuration_change_hook): Move set_buffer part
573 before select_frame_norecord part in order to unwind correctly.
574 Rename count1 to count.
575 (recombine_windows, delete_deletable_window, resize_root_window)
576 (Fdelete_other_windows_internal)
577 (Frun_window_configuration_change_hook, make_parent_window)
578 (resize_window_check, resize_window_apply, Fresize_window_apply)
579 (resize_frame_windows, Fsplit_window_internal)
580 (Fdelete_window_internal, Fresize_mini_window_internal): New
581 functions.
582 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
583
584 2011-06-08 Martin Rudalics <rudalics@gmx.at>
585
586 * window.h (window): Add some new members to window structure -
587 normal_lines, normal_cols, new_total, new_normal, clone_number,
588 splits, nest, prev_buffers, next_buffers.
589 (WINDOW_TOTAL_SIZE): Move here from window.c.
590 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
591
592 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
593 Remove.
594 (make_dummy_parent): Set new members of windows structure.
595 (make_window): Move down in code. Handle new members of window
596 structure.
597 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
598 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
599 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
600 (Fset_window_prev_buffers, Fwindow_next_buffers)
601 (Fset_window_next_buffers, Fset_window_clone_number): New
602 functions.
603 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
604 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
605 Doc-string fixes.
606 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
607 Argument WINDOW can be now internal window too.
608 (Fwindow_use_time): Move up in code.
609 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
610 Rewrite doc-string.
611 (Fset_window_configuration, saved_window)
612 (Fcurrent_window_configuration, save_window_save): Handle new
613 members of window structure.
614 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
615 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
616 (syms_of_window): New Lisp objects Qrecord_window_buffer,
617 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
618 Qget_mru_window, Qresize_root_window,
619 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
620 Qauto_buffer_name; staticpro them.
621
622 2011-06-07 Martin Rudalics <rudalics@gmx.at>
623
624 * window.c (Fwindow_total_size, Fwindow_left_column)
625 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
626 (Fwindow_list_1): New functions.
627 (window_box_text_cols): Replace with window_body_cols.
628 (Fwindow_width, Fscroll_left, Fscroll_right): Use
629 window_body_cols instead of window_box_text_cols.
630 (delete_window, Fset_window_configuration): Call
631 delete_all_subwindows with window as argument.
632 (delete_all_subwindows): Take a window as argument and not a
633 structure. Rewrite.
634 (window_loop): Remove handling of GET_LRU_WINDOW and
635 GET_LARGEST_WINDOW.
636 (Fget_lru_window, Fget_largest_window): Move to window.el.
637
638 * window.h: Extern window_body_cols instead of
639 window_box_text_cols. delete_all_subwindows now takes a
640 Lisp_Object as argument.
641
642 * indent.c (compute_motion, Fcompute_motion): Use
643 window_body_cols instead of window_box_text_cols.
644
645 * frame.c (delete_frame): Call delete_all_subwindows with root
646 window as argument.
647
648 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
649
650 * fns.c (Fputhash): Document return value.
651
652 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
653
654 * image.c (gif_load): Implement gif89a spec "no disposal" method.
655
656 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
657
658 Cons<->int and similar integer overflow fixes (Bug#8794).
659
660 Check for overflow when converting integer to cons and back.
661 * charset.c (Fdefine_charset_internal, Fdecode_char):
662 Use cons_to_unsigned to catch overflow.
663 (Fencode_char): Use INTEGER_TO_CONS.
664 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
665 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
666 * data.c (long_to_cons, cons_to_long): Remove.
667 (cons_to_unsigned, cons_to_signed): New functions.
668 These signal an error for invalid or out-of-range values.
669 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
670 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
671 * font.c (Ffont_variation_glyphs):
672 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
673 * lisp.h: Include <intprops.h>.
674 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
675 (cons_to_signed, cons_to_unsigned): New decls.
676 (long_to_cons, cons_to_long): Remove decls.
677 * undo.c (record_first_change): Use INTEGER_TO_CONS.
678 (Fprimitive_undo): Use CONS_TO_INTEGER.
679 * xfns.c (Fx_window_property): Likewise.
680 * xselect.c: Include <limits.h>.
681 (x_own_selection, selection_data_to_lisp_data):
682 Use INTEGER_TO_CONS.
683 (x_handle_selection_request, x_handle_selection_clear)
684 (x_get_foreign_selection, Fx_disown_selection_internal)
685 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
686 (lisp_data_to_selection_data): Use cons_to_unsigned.
687 (x_fill_property_data): Use cons_to_signed.
688 Report values out of range.
689
690 Check for buffer and string overflow more precisely.
691 * buffer.h (BUF_BYTES_MAX): New macro.
692 * lisp.h (STRING_BYTES_MAX): New macro.
693 * alloc.c (Fmake_string):
694 * character.c (string_escape_byte8):
695 * coding.c (coding_alloc_by_realloc):
696 * doprnt.c (doprnt):
697 * editfns.c (Fformat):
698 * eval.c (verror):
699 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
700 since they may not be the same number.
701 * editfns.c (Finsert_char):
702 * fileio.c (Finsert_file_contents):
703 Likewise for BUF_BYTES_MAX.
704
705 * image.c: Use ptrdiff_t, not int, for sizes.
706 (slurp_file): Switch from int to ptrdiff_t.
707 All uses changed.
708 (slurp_file): Check that file size fits in both size_t (for
709 malloc) and ptrdiff_t (for sanity and safety).
710
711 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
712 if b->modtime has its maximal value.
713
714 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
715
716 Don't assume time_t can fit into int.
717 * buffer.h (struct buffer.modtime): Now time_t, not int.
718 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
719 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
720
721 Minor fixes for signed vs unsigned integers.
722 * character.h (MAYBE_UNIFY_CHAR):
723 * charset.c (maybe_unify_char):
724 * keyboard.c (read_char, reorder_modifiers):
725 XINT -> XFASTINT, since the integer must be nonnegative.
726 * ftfont.c (ftfont_spec_pattern):
727 * keymap.c (access_keymap, silly_event_symbol_error):
728 XUINT -> XFASTINT, since the integer must be nonnegative.
729 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
730 since it makes no difference and we prefer signed.
731 * keyboard.c (record_char): Use XUINT when all the neighbors do.
732 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
733 nonnegative.
734
735 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
736
737 * window.h (Fwindow_frame): Declare.
738
739 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
740
741 * alloc.c: Simplify handling of large-request failures (Bug#8800).
742 (SPARE_MEMORY): Always define.
743 (LARGE_REQUEST): Remove.
744 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
745
746 2011-06-06 Martin Rudalics <rudalics@gmx.at>
747
748 * lisp.h: Move EXFUNS for Fframe_root_window,
749 Fframe_first_window and Fset_frame_selected_window to window.h.
750
751 * window.h: Move EXFUNS for Fframe_root_window,
752 Fframe_first_window and Fset_frame_selected_window here from
753 lisp.h.
754
755 * frame.c (Fwindow_frame, Fframe_first_window)
756 (Fframe_root_window, Fframe_selected_window)
757 (Fset_frame_selected_window): Move to window.c.
758 (Factive_minibuffer_window): Move to minibuf.c.
759 (Fother_visible_frames_p): New function.
760
761 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
762
763 * window.c (decode_window, decode_any_window): Move up in code.
764 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
765 (inhibit_frame_unsplittable): Remove unused variable.
766 (Fwindow_buffer): Move up and rewrite doc-string.
767 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
768 (Fwindow_prev): New functions.
769 (Fwindow_frame): Move here from frame.c. Accept any window as
770 argument.
771 (Fframe_root_window, Fframe_first_window)
772 (Fframe_selected_window): Move here from frame.c. Accept frame
773 or arbitrary window as argument. Update doc-strings.
774 (Fminibuffer_window): Move up in code.
775 (Fwindow_minibuffer_p): Move up in code and simplify.
776 (Fset_frame_selected_window): Move here from frame.c.
777 Marginal rewrite.
778 (Fselected_window, select_window, Fselect_window): Move up in
779 code. Minor doc-string fixes.
780
781 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
782
783 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
784 Do not assume that spare memory exists; that assumption is valid
785 only if SYSTEM_MALLOC.
786 (LARGE_REQUEST): New macro, so that the issue of large requests
787 is separated from the issue of spare memory.
788
789 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
790
791 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
792 format. (Bug#8806)
793
794 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
795
796 * xfns.c (x_set_scroll_bar_default_width): Move declarations
797 before statements.
798
799 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
800
801 * gtkutil.c (xg_get_default_scrollbar_width): New function.
802
803 * gtkutil.h: Declare xg_get_default_scrollbar_width.
804
805 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
806 min width by calling x_set_scroll_bar_default_width (Bug#8505).
807
808 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
809
810 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
811
812 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
813
814 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
815 (x_clipboard_manager_save): Add return value.
816 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
817 New error handlers.
818 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
819 Obey Vx_select_enable_clipboard_manager. Catch errors in
820 x_clipboard_manager_save (Bug#8779).
821 (Vx_select_enable_clipboard_manager): New variable.
822 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
823
824 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
825
826 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
827
828 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
829
830 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
831 in the current matrix if keep_current_p is non-zero.
832
833 2011-06-04 Eli Zaretskii <eliz@gnu.org>
834
835 * bidi.c (bidi_level_of_next_char): Fix last change.
836
837 2011-06-03 Eli Zaretskii <eliz@gnu.org>
838
839 Support bidi reordering of text covered by display properties.
840
841 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
842 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
843 (bidi_cache_search, bidi_cache_iterator_state)
844 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
845 (bidi_level_of_next_char, bidi_move_to_visually_next):
846 Support character positions inside a run of characters covered by a
847 display string.
848 (bidi_paragraph_init, bidi_resolve_explicit_1)
849 (bidi_level_of_next_char): Call bidi_fetch_char and
850 bidi_fetch_char_advance instead of FETCH_CHAR and
851 FETCH_CHAR_ADVANCE.
852 (bidi_init_it): Initialize new members.
853 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
854 definitions.
855 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
856 instead of using explicit *_CHAR codes.
857 (bidi_resolve_explicit, bidi_resolve_weak):
858 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
859 bidirectional text is supported only in multibyte buffers.
860 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
861 it to initialize the frame_window_p member of struct bidi_it.
862 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
863 (bidi_resolve_explicit, bidi_resolve_weak)
864 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
865 bidi_it->nchars is non-positive.
866 (bidi_level_of_next_char): Don't try to lookup the cache for the
867 next/previous character if nothing is cached there yet, or if we
868 were just reseat()'ed to a new position.
869
870 * xdisp.c (set_cursor_from_row): Set start and stop points
871 according to the row's direction when priming the loop that looks
872 for the glyph on which to display cursor.
873 (single_display_spec_intangible_p): Function deleted.
874 (display_prop_intangible_p): Reimplement to call
875 handle_display_spec instead of single_display_spec_intangible_p.
876 Accept 3 additional arguments needed by handle_display_spec.
877 This fixes incorrect cursor motion across display property with complex
878 values: lists, `(when COND...)' forms, etc.
879 (single_display_spec_string_p): Support property values that are
880 lists with the argument STRING its top-level element.
881 (display_prop_string_p): Fix the condition for processing a
882 property that is a list to be consistent with handle_display_spec.
883 (handle_display_spec): New function, refactored from the
884 last portion of handle_display_prop.
885 (compute_display_string_pos): Accept additional argument
886 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
887 value of a `display' property is a "replacing spec".
888 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
889 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
890 the display property, but just return a value indicating whether
891 the display property will replace the characters it covers.
892 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
893 frame_window_p members of struct bidi_it.
894 (compute_display_string_pos, compute_display_string_end):
895 New functions.
896 (push_it): Accept second argument POSITION, where pop_it should
897 jump to continue iteration.
898 (reseat_1): Initialize bidi_it.disp_pos.
899
900 * keyboard.c (adjust_point_for_property): Adjust the call to
901 display_prop_intangible_p to its new signature.
902
903 * dispextern.h (struct bidi_it): New member frame_window_p.
904 (bidi_init_it): Update prototypes.
905 (display_prop_intangible_p): Update prototype.
906 (compute_display_string_pos, compute_display_string_end):
907 Declare prototypes.
908 (struct bidi_it): New members nchars and disp_pos. ch_len is now
909 EMACS_INT.
910
911 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
912
913 Malloc failure behavior now depends on size of allocation.
914 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
915 * lisp.h: Change signatures accordingly.
916 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
917 All callers changed. (Bug#8762)
918
919 * gnutls.c: Use Emacs's memory allocators.
920 Without this change, the gnutls library would invoke malloc etc.
921 directly, which causes problems on non-SYNC_INPUT hosts, and which
922 runs afoul of improving memory_full behavior. (Bug#8761)
923 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
924 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
925 xfree instead of the default malloc, realloc, free.
926 (Fgnutls_boot): No need to check for memory allocation failure,
927 since xmalloc does that for us.
928
929 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
930 * category.c (hash_get_category_set):
931 * ccl.c (ccl_driver):
932 * charset.c (Fdefine_charset_internal):
933 * charset.h (struct charset.hash_index):
934 * composite.c (get_composition_id, gstring_lookup_cache)
935 (composition_gstring_put_cache):
936 * composite.h (struct composition.hash_index):
937 * dispextern.h (struct image.hash):
938 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
939 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
940 (hashfn_equal, hashfn_user_defined, make_hash_table)
941 (maybe_resize_hash_table, hash_lookup, hash_put)
942 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
943 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
944 (Fsxhash, Fgethash, Fputhash, Fmaphash):
945 * image.c (make_image, search_image_cache, lookup_image)
946 (xpm_put_color_table_h):
947 * lisp.h (struct Lisp_Hash_Table):
948 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
949 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
950 for hashes and hash indexes, instead of 'unsigned' and 'int'.
951 * alloc.c (allocate_vectorlike):
952 Check for overflow in vector size calculations.
953 * ccl.c (ccl_driver):
954 Check for overflow when converting EMACS_INT to int.
955 * fns.c, image.c: Remove unnecessary static decls that would otherwise
956 need to be updated by these changes.
957 * fns.c (make_hash_table, maybe_resize_hash_table):
958 Check for integer overflow with large hash tables.
959 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
960 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
961 (SXHASH_REDUCE): New macro.
962 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
963 Use it instead of discarding useful hash info with large hash values.
964 (sxhash_float): New function.
965 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
966 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
967 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
968 Rewrite to use FIXNUM_BITS, as this simplifies things.
969 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
970 Adjust signatures to match updated version of code.
971 (consing_since_gc): Now EMACS_INT, since a single hash table can
972 use more than INT_MAX bytes.
973
974 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
975
976 Make it possible to build with GCC-4.6+ -O2 -flto.
977
978 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
979
980 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
981
982 * minibuf.c (get_minibuffer, read_minibuf_unwind):
983 Call minibuffer-inactive-mode.
984
985 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
986
987 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
988 Update dependencies.
989
990 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
991
992 * data.c (init_data): Remove code for UTS, this system is not
993 supported anymore.
994
995 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
996
997 Don't force ./temacs to start in terminal mode.
998
999 * frame.c (make_initial_frame): Initialize faces in all cases, not
1000 only when CANNOT_DUMP is defined.
1001 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1002
1003 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1004
1005 * dispnew.c (add_window_display_history): Use const for the string
1006 pointer. Remove declaration, not needed.
1007
1008 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 Use 'inline', not 'INLINE'.
1011 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1012 * alloc.c, fontset.c (INLINE): Remove.
1013 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1014 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1015 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1016 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1017 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1018
1019 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1020
1021 Make it possible to run ./temacs.
1022
1023 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1024 syms_of_callproc does the same thing. Remove test for
1025 "initialized", do it in the caller.
1026 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1027
1028 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1029
1030 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1031 (read_minibuf): Use get_minibuffer.
1032 (syms_of_minibuf): Use DEFSYM.
1033 (Qmetadata): New var.
1034 * data.c (Qbuffer): Don't make it static.
1035 (syms_of_data): Use DEFSYM.
1036
1037 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1038
1039 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1040 (CCL_CODE_MIN): New macro.
1041
1042 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1043
1044 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1045
1046 * eval.c (Qdebug): Now static.
1047 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1048 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1049 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1050
1051 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1052
1053 * image.c: Various fixes to ImageMagick code comments.
1054 (Fimagemagick_types): Doc fix.
1055
1056 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1057
1058 Minor fixes prompted by GCC 4.6.0 warnings.
1059
1060 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1061
1062 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1063 (x_clipboard_manager_save_all): Move extern decl to ...
1064 * xterm.h: ... here, so that it can be checked for consistency.
1065
1066 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1067
1068 * xselect.c (x_clipboard_manager_save_frame)
1069 (x_clipboard_manager_save_all): New functions.
1070 (Fx_clipboard_manager_save): Lisp function deleted.
1071
1072 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1073 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1074
1075 * xterm.h: Update prototype.
1076
1077 2011-05-28 William Xu <william.xwl@gmail.com>
1078
1079 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1080 exiting (Bug#8239).
1081
1082 2011-05-28 Jim Meyering <meyering@redhat.com>
1083
1084 Avoid a sign-extension bug in crypto_hash_function.
1085 * fns.c (to_uchar): Define.
1086 (crypto_hash_function): Use it to convert some newly-signed
1087 variables to unsigned, to avoid sign-extension bugs. For example,
1088 without this change, (md5 "truc") would evaluate to
1089 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1090 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1091 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1092
1093 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 Integer overflow fixes.
1096
1097 * dbusbind.c: Serial number integer overflow fixes.
1098 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1099 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1100 to hold a serial number that is too large for a fixnum.
1101 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1102 Check for serial numbers out of range. Decode any serial number
1103 that was so large that it became a float. (Bug#8722)
1104
1105 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1106 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1107 Use XFASTINT rather than XUINT when numbers are nonnegative.
1108 (xd_append_arg, Fdbus_method_return_internal):
1109 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1110 arguments, check that Lisp number is nonnegative, rather than
1111 silently wrapping negative numbers around. (Bug#8722)
1112 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1113 (Bug#8722)
1114
1115 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1116
1117 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1118
1119 ccl: add integer overflow checks
1120 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1121 (IN_INT_RANGE): New macros.
1122 (ccl_driver): Use them to check for integer overflow when
1123 decoding a CCL program. Many of the new checks are whether XINT (x)
1124 fits in int; it doesn't always, on 64-bit hosts. The new version
1125 doesn't catch all possible integer overflows, but it's an
1126 improvement. (Bug#8719)
1127
1128 * alloc.c (make_event_array): Use XINT, not XUINT.
1129 There's no need for unsigned here.
1130
1131 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1132 This follows up to the 2011-05-06 change that substituted uintptr_t
1133 for EMACS_INT. This case wasn't caught back then.
1134
1135 Rework Fformat to avoid integer overflow issues.
1136 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1137 now (part of C89). Include <verify.h>.
1138 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1139 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1140 (Fformat): Avoid the prepass trying to compute sizes; it was only
1141 approximate and thus did not catch overflow reliably. Instead, walk
1142 through the format just once, formatting and computing sizes as we go,
1143 checking for integer overflow at every step, and allocating a larger
1144 buffer as needed. Keep track separately whether the format is
1145 multibyte. Keep only the most-recently calculated precision, rather
1146 than them all. Record whether each argument has been converted to
1147 string. Use EMACS_INT, not int, for byte and char and arg counts.
1148 Support field widths and precisions larger than INT_MAX. Avoid
1149 sprintf's undefined behavior with conversion specifications such as %#d
1150 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1151 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1152 formatting out-of-range floating point numbers with int
1153 formats. (Bug#8668)
1154
1155 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1156
1157 * data.c: Avoid integer truncation in expressions involving floats.
1158 * data.c: Include <intprops.h>.
1159 (arith_driver): When there's an integer overflow in an expression
1160 involving floating point, convert the integers to floating point
1161 so that the resulting value does not suffer from catastrophic
1162 integer truncation. For example, on a 64-bit host (* 4
1163 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1164 Do not rely on undefined behavior after integer overflow.
1165
1166 merge count_size_as_multibyte, parse_str_to_multibyte
1167 * character.c, character.h (count_size_as_multibyte):
1168 Rename from parse_str_to_multibyte; all uses changed.
1169 Check for integer overflow.
1170 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1171 since it's now a duplicate of the other. This is more of
1172 a character than a buffer op, so better that it's in character.c.
1173 * fns.c, print.c: Adjust to above changes.
1174
1175 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1176
1177 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1178
1179 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1182 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1183 (x_clipboard_manager_save): Now static.
1184 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1185
1186 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1187 (crypto_hash_function): Now static.
1188 Fix pointer signedness problems. Avoid unnecessary initializations.
1189
1190 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1191
1192 * termhooks.h (Vselection_alist): Make it terminal-local.
1193
1194 * terminal.c (create_terminal): Initialize it.
1195
1196 * xselect.c: Support for clipboard managers.
1197 (Vselection_alist): Move to termhooks.h as terminal-local var.
1198 (LOCAL_SELECTION): New macro.
1199 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1200 (symbol_to_x_atom): Remove gratuitous arg.
1201 (x_handle_selection_request, lisp_data_to_selection_data)
1202 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1203 (x_own_selection, x_get_local_selection, x_convert_selection):
1204 New arg, specifying work frame. Use terminal-local Vselection_alist.
1205 (some_frame_on_display): Delete unused function.
1206 (Fx_own_selection_internal, Fx_get_selection_internal)
1207 (Fx_disown_selection_internal, Fx_selection_owner_p)
1208 (Fx_selection_exists_p): New optional frame arg.
1209 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1210 (x_handle_selection_clear): Don't treat other terminals with the
1211 same keyboard specially. Use the terminal-local Vselection_alist.
1212 (x_clear_frame_selections): Use Frun_hook_with_args.
1213
1214 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1215
1216 * xterm.h: Add support for those atoms.
1217
1218 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1219
1220 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1221 (converted_selections, conversion_fail_tag): New global variables.
1222 (x_selection_request_lisp_error): Free the above.
1223 (x_get_local_selection): Remove unnecessary code.
1224 (x_reply_selection_request): Args changed; handle arbitrary array
1225 of converted selections stored in converted_selections.
1226 Separate the XChangeProperty and SelectionNotify steps.
1227 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1228 (x_convert_selection): New function.
1229 (x_handle_selection_event): Simplify.
1230 (x_get_foreign_selection): Don't ignore incoming requests while
1231 waiting for an answer; this will fail when we implement
1232 SAVE_TARGETS, and seems unnecessary anyway.
1233 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1234 (Vx_sent_selection_functions): Doc fix.
1235
1236 2011-05-26 Leo Liu <sdl.web@gmail.com>
1237
1238 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1239
1240 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1241
1242 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1243
1244 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1245 for fringe update if it has periodic bitmap.
1246 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1247 and fringe_bitmap_periodic_p.
1248
1249 * fringe.c (get_fringe_bitmap_data): New function.
1250 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1251 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1252 row. Mark glyph row for fringe update if periodicity changed.
1253
1254 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1255 for fringe update unless it has periodic bitmap.
1256
1257 2011-05-25 Kenichi Handa <handa@m17n.org>
1258
1259 * xdisp.c (get_next_display_element): Set correct it->face_id for
1260 a static composition.
1261
1262 2011-05-24 Leo Liu <sdl.web@gmail.com>
1263
1264 * deps.mk (fns.o):
1265 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1266
1267 * fns.c (crypto_hash_function, Fsha1): New function.
1268 (Fmd5): Use crypto_hash_function.
1269 (syms_of_fns): Add Ssha1.
1270
1271 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 * gnutls.c: Remove unused macros.
1274 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1275 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1276 Remove macros that are defined and never used.
1277 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1278
1279 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1280
1281 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1282 (Fx_get_selection_internal): Minor cleanup.
1283 (Fx_own_selection_internal): Rename arguments for consistency with
1284 select.el.
1285
1286 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1287
1288 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1289
1290 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1291
1292 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1293
1294 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1295
1296 * dispnew.c (scrolling_window): Don't exclude the case that the
1297 last enabled row in the desired matrix touches the bottom boundary.
1298
1299 2011-05-21 Glenn Morris <rgm@gnu.org>
1300
1301 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1302 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1303 and add some more files.
1304
1305 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1306
1307 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1308 report_file_error introduced by the change from 2011-05-07.
1309
1310 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1311
1312 * systime.h (Time): Define only if emacs is defined.
1313 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1314 where the include path doesn't have X11/X.h by default. See
1315 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1316
1317 2011-05-20 Kenichi Handa <handa@m17n.org>
1318
1319 * composite.c (find_automatic_composition): Fix previous change.
1320
1321 2011-05-20 Glenn Morris <rgm@gnu.org>
1322
1323 * lisp.mk: New file, split from Makefile.in.
1324 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1325 (shortlisp): Remove.
1326 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1327
1328 2011-05-19 Glenn Morris <rgm@gnu.org>
1329
1330 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1331 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1332 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1333 (lisp): Set the order to that of loadup.el.
1334 (shortlisp): Make it a copy of $lisp.
1335 (SOME_MACHINE_LISP): Remove.
1336 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1337 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1338
1339 2011-05-18 Kenichi Handa <handa@m17n.org>
1340
1341 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1342 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1343 (find_automatic_composition): Mostly rewrite for efficiency.
1344
1345 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1346
1347 * makefile.w32-in: Update dependencies.
1348
1349 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1350
1351 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1352 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1353
1354 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1355
1356 Fix some integer overflow issues, such as string length overflow.
1357
1358 * insdel.c (count_size_as_multibyte): Check for string overflow.
1359
1360 * character.c (lisp_string_width): Check for string overflow.
1361 Use EMACS_INT, not int, for string indexes and lengths; in
1362 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1363 the resulting string length overflows an EMACS_INT; instead,
1364 report a string overflow if no precision given. When checking for
1365 precision exhaustion, use a check that cannot possibly have
1366 integer overflow. (Bug#8675)
1367 * character.h (lisp_string_width): Adjust to new signature.
1368
1369 * alloc.c (string_overflow): New function.
1370 (Fmake_string): Use it. This doesn't change behavior, but saves
1371 a few bytes and will simplify future changes.
1372 * character.c (string_escape_byte8): Likewise.
1373 * lisp.h (string_overflow): New decl.
1374
1375 Fixups, following up to the user-interface timestamp change.
1376 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1377 for UI timestamps, instead of unsigned long.
1378 * msdos.c (mouse_get_pos): Likewise.
1379 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1380 * w32gui.h (Time): Define by including "systime.h" rather than by
1381 declaring it ourselves. (Bug#8664)
1382
1383 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1384 * image.c (clear_image_cache): Likewise.
1385
1386 * term.c (term_mouse_position): Don't assume time_t wraparound.
1387
1388 Be more systematic about user-interface timestamps.
1389 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1390 and sometimes 'EMACS_UINT', to represent these timestamps.
1391 This change causes it to use 'Time' uniformly, as that's what X uses.
1392 This makes the code easier to follow, and makes it easier to catch
1393 integer overflow bugs such as Bug#8664.
1394 * frame.c (Fmouse_position, Fmouse_pixel_position):
1395 Use Time, not unsigned long, for user-interface timestamps.
1396 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1397 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1398 * keyboard.h (last_event_timestamp): Likewise.
1399 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1400 * menu.h (xmenu_show): Likewise.
1401 * term.c (term_mouse_position): Likewise.
1402 * termhooks.h (struct input_event.timestamp): Likewise.
1403 (struct terminal.mouse_position_hook): Likewise.
1404 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1405 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1406 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1407 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1408 what it was before.
1409 * menu.h, termhooks.h: Include "systime.h", for Time.
1410
1411 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1412 Don't assume that the difference between two unsigned long values
1413 can fit into an integer. At this point, we know button_down_time
1414 <= event->timestamp, so the difference must be nonnegative, so
1415 there's no need to cast the result if double-click-time is
1416 nonnegative, as it should be; check that it's nonnegative, just in
1417 case. This bug is triggered when events are more than 2**31 ms
1418 apart (about 25 days). (Bug#8664)
1419
1420 * xselect.c (last_event_timestamp): Remove duplicate decl.
1421 (x_own_selection): Remove needless cast to unsigned long.
1422
1423 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1424 that always fit in int. Use a sentinel instead of a counter, to
1425 avoid a temp and to allay GCC's concerns about possible int overflow.
1426 * frame.h (struct frame): Use int for menu_bar_items_used
1427 instead of EMACS_INT, since it always fits in int.
1428
1429 * menu.c (grow_menu_items): Check for int overflow.
1430
1431 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1432
1433 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1434 Before, the code was not consistent. These values cannot exceed
1435 2**31 - 1 so there's no need to make them unsigned.
1436 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1437 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1438 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1439 as modifiers.
1440 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1441
1442 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1443 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1444 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1445 presumably because the widths might not match.
1446
1447 * window.c (size_window): Avoid needless test at loop start.
1448
1449 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1450
1451 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1452
1453 2011-05-12 Drew Adams <drew.adams@oracle.com>
1454
1455 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1456
1457 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1458
1459 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1460 `width' to `bar_area_x' and `bar_area_width', respectively.
1461 (x_scroll_run): Take account of fringe background extension.
1462
1463 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1464 Rename local vars `left' and `width' to `bar_area_x' and
1465 `bar_area_width', respectively.
1466 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1467 background extension.
1468
1469 2011-05-10 Jim Meyering <meyering@redhat.com>
1470
1471 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1472
1473 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1474
1475 * image.c (Finit_image_library): Return t for built-in image types,
1476 like pbm and xbm. (Bug#8640)
1477
1478 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1479
1480 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1481
1482 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1483
1484 * w32console.c (Fset_screen_color): Doc fix.
1485 (Fget_screen_color): New function.
1486 (syms_of_ntterm): Defsubr it.
1487
1488 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1489 unlink the temporary file if Fcall_process didn't create it in the
1490 first place.
1491 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1492 child process will be redirected to a file specified with `:file'.
1493 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1494 cue to call_process_cleanup not to close that handle.
1495
1496 2011-05-07 Ben Key <bkey76@gmail.com>
1497
1498 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1499 one of two shell specific rules, either bootstrap-temacs-CMD or
1500 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1501 to the previous implementation of the bootstrap-temacs rule.
1502 The bootstrap-temacs-CMD rule is similar to the previous
1503 implementation of the bootstrap-temacs rule except that it
1504 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1505 variable.
1506
1507 These changes, along with some changes to nt/configure.bat,
1508 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1509 earlier fix to add support for --cflags and --ldflags options
1510 that include quotes so that it works whether make uses cmd or
1511 sh as the shell.
1512
1513 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1514
1515 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1516 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1517 is a constant.
1518 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1519 a string. Handle both cases.
1520 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1521 (Fdbus_register_method): Use Qinvalid_function.
1522
1523 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1524
1525 * makefile.w32-in: Update dependencies.
1526 (LISP_H): Add inttypes.h and stdin.h.
1527 (PROCESS_H): Add unistd.h.
1528
1529 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1530
1531 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1532 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1533
1534 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1537
1538 * term.c (vfatal): Remove stray call to va_end.
1539 It's not needed and the C Standard doesn't allow it here anyway.
1540
1541 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1542 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1543
1544 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1545 bytes.
1546
1547 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1548
1549 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1550
1551 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1552
1553 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1554
1555 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1556
1557 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1558 * charset.c (Fdefine_charset_internal): Don't initialize
1559 charset.code_space[15]. The value was garbage, on hosts with
1560 32-bit int (Bug#8600).
1561
1562 * lread.c (read_integer): Be more consistent with string-to-number.
1563 Use string_to_number to do the actual conversion; this avoids
1564 rounding errors and fixes some other screwups. Without this fix,
1565 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1566 (digit_to_number): Move earlier, for benefit of read_integer.
1567 Return -1 if the digit is out of range for the base, -2 if it is
1568 not a digit in any supported base. (Bug#8602)
1569
1570 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1571
1572 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1573 to match comment at start of function. This also removes a
1574 GCC warning about overflow in a 32+64-bit port.
1575
1576 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1577
1578 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1579 Reported by Stefan Monnier in
1580 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1581 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1582 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1583
1584 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1585 (EMACS_UINTPTR): Likewise, with uintptr_t.
1586
1587 * lisp.h: Prefer 64-bit EMACS_INT if available.
1588 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1589 on 32-bit hosts that have 64-bit int, so that they can access
1590 large files.
1591 However, temporarily disable this change unless the temporary
1592 symbol WIDE_EMACS_INT is defined.
1593
1594 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1595
1596 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1597 This removes an assumption that EMACS_INT and long are the same
1598 width as pointers. The assumption is true for Emacs porting targets
1599 now, but we want to make other targets possible.
1600 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1601 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1602 In the rest of the code, change types of integers that hold casted
1603 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1604 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1605 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1606 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1607 No need to cast type when ORing.
1608 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1609 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1610 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1611 assume EMACS_INT is the same width as char *.
1612 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1613 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1614 Remove no-longer-needed casts.
1615 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1616 (xg_tool_bar_help_callback, xg_make_tool_item):
1617 Use EMACS_INTPTR to hold an integer
1618 that will be cast to void *; this can avoid a GCC warning
1619 if EMACS_INT is not the same width as void *.
1620 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1621 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1622 (current_message_1, set_message_1):
1623 Use a local to convert to proper width without a cast.
1624 * xmenu.c (dialog_selection_callback): Likewise.
1625
1626 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1627 Also, don't assume VALBITS / RAND_BITS is less than 5,
1628 and don't rely on undefined behavior when shifting a 1 left into
1629 the sign bit.
1630 * lisp.h (get_random): Change signature to match.
1631
1632 * lread.c (hash_string): Use size_t, not int, for hash computation.
1633 Normally we prefer signed values; but hashing is special, because
1634 it's better to use unsigned division on hash table sizes so that
1635 the remainder is nonnegative. Also, size_t is the natural width
1636 for hashing into memory. The previous code used 'int', which doesn't
1637 retain enough info to hash well into very large tables.
1638 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1639
1640 * dbusbind.c: Don't possibly lose pointer info when converting.
1641 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1642 Use XPNTR rather than XHASH, so that the high-order bits of
1643 the pointer aren't lost when converting through void *.
1644
1645 * eval.c (Fautoload): Don't double-shift a pointer.
1646
1647 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1648
1649 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1650
1651 * gnutls.c (DEF_GNUTLS_FN):
1652 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1653
1654 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1655
1656 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1657 marker. (Bug#8610)
1658
1659 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1660
1661 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1662 New version that can reserve upto 2GB of heap space.
1663
1664 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1665
1666 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1667
1668 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1669
1670 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1671 `gnutls_certificate_set_x509_key_file'.
1672
1673 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1674
1675 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1676 Update dependencies.
1677
1678 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1679
1680 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1681 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1682 Remove unused parameter `fildes'.
1683 * process.c (read_process_output, send_process): Don't pass it.
1684
1685 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1686
1687 Fix previous change: the library cache is defined in w32.c.
1688 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1689 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1690
1691 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1692
1693 Implement dynamic loading of GnuTLS on Windows.
1694
1695 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1696 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1697 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1698 Declare.
1699
1700 * gnutls.c (Qgnutls_dll): Define.
1701 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1702 (gnutls_*): Declare function pointers.
1703 (init_gnutls_functions): New function to initialize function pointers.
1704 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1705 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1706 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1707 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1708 (emacs_gnutls_write, emacs_gnutls_read)
1709 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1710 (Fgnutls_available_p): New function.
1711 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1712 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1713 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1714
1715 * image.c: Include w32.h.
1716 (Vimage_type_cache): Delete.
1717 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1718 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1719 (w32_delayed_load): Move to w32.c.
1720
1721 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1722
1723 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1724 (w32_delayed_load): Move from image.c. When loading a library, record
1725 its filename in the :loaded-from property of the library id.
1726 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1727 Initialize and staticpro them.
1728 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1729
1730 * process.c: Include lisp.h before w32.h, not after.
1731 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1732 instead of gnutls_record_check_pending.
1733
1734 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1735
1736 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1737
1738 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1739 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1740 as passed in.
1741
1742 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1743
1744 * xterm.c (x_set_frame_alpha): Do not set property on anything
1745 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1746
1747 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1748
1749 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1750
1751 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1752
1753 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1754 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1755 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1756 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1757 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1758 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1759 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1760 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1761 (Qgnutls_bootprop_callbacks_verify): Make static.
1762
1763 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1764
1765 * callproc.c: Indentation fixup.
1766
1767 * sysdep.c (wait_for_termination_1): Make static.
1768 (wait_for_termination, interruptible_wait_for_termination):
1769 Move after wait_for_termination_1.
1770
1771 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1772
1773 * sysdep.c (interruptible_wait_for_termination): New function
1774 which is like wait_for_termination, but allows keyboard
1775 interruptions.
1776
1777 * callproc.c (Fcall_process): Add (:file "file") as an option for
1778 the STDOUT buffer.
1779 (Fcall_process_region): Ditto.
1780
1781 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1782
1783 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1784 rather than `XVECTOR (FOO)->size'.
1785
1786 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1787 inttypes.h, as a gnulib replacement is used if it not available in
1788 system headers.
1789
1790 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1791
1792 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1793 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1794 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1795
1796 * coding.c (coding_alloc_by_realloc): Error out if destination
1797 will grow beyond MOST_POSITIVE_FIXNUM.
1798 (decode_coding_emacs_mule): Abort if there isn't enough place in
1799 charbuf for the composition carryover bytes. Reserve an extra
1800 space for up to 2 characters produced in a loop.
1801 (decode_coding_iso_2022): Abort if there isn't enough place in
1802 charbuf for the composition carryover bytes.
1803
1804 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1805
1806 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1807 aborting when %lld or %lll format is passed.
1808 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1809 %llo or %llx format is passed. (Bug#8545)
1810
1811 * window.c (window_scroll_line_based): Use a marker instead of
1812 simple variables to record original value of point. (Bug#7952)
1813
1814 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1815 produced by %s or %c overflows available buffer space. (Bug#8545)
1816
1817 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1818
1819 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1820 (SIZE_MAX): Move defn after all includes, as they might #define it.
1821
1822 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1823
1824 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1825
1826 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1827
1828 * keyboard.c (Qdelayed_warnings_hook): Define.
1829 (command_loop_1): Run `delayed-warnings-hook'
1830 if Vdelayed_warnings_list is non-nil.
1831 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1832 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1833
1834 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1835
1836 * doprnt.c (doprnt): Don't return value smaller than the buffer
1837 size if the message was truncated. (Bug#8545).
1838
1839 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1840
1841 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1842 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1843
1844 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1847
1848 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1849
1850 * makefile.w32-in: Update dependencies.
1851
1852 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1853
1854 Improve `doprnt' and its usage. (Bug#8545)
1855 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1856 `format_end'. Remove support for %l as a conversion specifier.
1857 Don't use xrealloc. Improve diagnostics when the %l size modifier
1858 is used. Update the commentary.
1859
1860 * eval.c (verror): Simplify calculation of size_t.
1861
1862 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1863 messages.
1864
1865 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1866
1867 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1868 change.
1869
1870 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1871
1872 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1873 This makes this file independent of the recent pseudovector change.
1874
1875 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1878
1879 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1880 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1881 Remove unused local.
1882 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1883
1884 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1885 GCC 4.6.0 optimizes based on type-based alias analysis.
1886 For example, if b is of type struct buffer * and v of type struct
1887 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1888 != &v->size, and therefore "v->size = 1; b->size = 2; return
1889 v->size;" must therefore return 1. This assumption is incorrect
1890 for Emacs, since it type-puns struct Lisp_Vector * with many other
1891 types. To fix this problem, this patch adds a new type struct
1892 vectorlike_header that documents the constraints on layout of vectors
1893 and pseudovectors, and helps optimizing compilers not get fooled
1894 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1895 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1896 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1897 the size member.
1898 (XSETPVECTYPE): Rewrite in terms of new macro.
1899 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1900 This is a bit clearer, and further avoids the possibility of
1901 undesirable aliasing.
1902 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1903 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1904 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1905 since Lisp_Subr is a special case (no "next" field).
1906 (ASIZE): Now uses header.size rather than size.
1907 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1908 to avoid the hassle of writing XVECTOR (foo)->header.size.
1909 (struct vectorlike_header): New type.
1910 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1911 object, to help avoid aliasing.
1912 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1913 (SUBRP): Likewise, since Lisp_Subr is a special case.
1914 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1915 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1916 (struct Lisp_Hash_Table): Combine first two members into a single
1917 struct vectorlike_header member. All uses of "size" and "next" members
1918 changed to be "header.size" and "header.next".
1919 * buffer.h (struct buffer): Likewise.
1920 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1921 * frame.h (struct frame): Likewise.
1922 * process.h (struct Lisp_Process): Likewise.
1923 * termhooks.h (struct terminal): Likewise.
1924 * window.c (struct save_window_data, struct saved_window): Likewise.
1925 * window.h (struct window): Likewise.
1926 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1927 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1928 * buffer.c (init_buffer_once): Likewise.
1929 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1930 special case.
1931 * process.c (Fformat_network_address): Use local var for size,
1932 for brevity.
1933
1934 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1935
1936 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1937 * data.c (atof): Remove decl; no longer used or needed.
1938 (digit_to_number): Move to lread.c.
1939 (Fstring_to_number): Use new string_to_number function, to be
1940 consistent with how the Lisp reader treats infinities and NaNs.
1941 Do not assume that floating-point numbers represent EMACS_INT
1942 without losing information; this is not true on most 64-bit hosts.
1943 Avoid double-rounding errors, by insisting on integers when
1944 parsing non-base-10 numbers, as the documentation specifies.
1945 * lisp.h (string_to_number): New decl, replacing ...
1946 (isfloat_string): Remove.
1947 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1948 (read1): Do not accept +. and -. as integers; this
1949 appears to have been a coding error. Similarly, do not accept
1950 strings like +-1e0 as floating point numbers. Do not report
1951 overflow for integer overflows unless the base is not 10 which
1952 means we have no simple and reliable way to continue.
1953 Break out the floating-point parsing into a new
1954 function string_to_number, so that Fstring_to_number parses
1955 floating point numbers consistently with the Lisp reader.
1956 (digit_to_number): Move here from data.c. Make it static inline.
1957 (E_CHAR, EXP_INT): Remove, replacing with ...
1958 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1959 (string_to_number): New function, replacing isfloat_string.
1960 This function checks for valid syntax and produces the resulting
1961 Lisp float number too. Rework it so that string-to-number
1962 no longer mishandles examples like "1.0e+". Use strtoumax,
1963 so that overflow for non-base-10 numbers is reported only when
1964 there's no portable and simple way to convert to floating point.
1965
1966 * textprop.c (set_text_properties_1): Rewrite for clarity,
1967 and to avoid GCC warning about integer overflow.
1968
1969 * intervals.h (struct interval): Use EMACS_INT for members
1970 where EMACS_UINT might cause problems. See
1971 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1972 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1973 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1974 All uses changed.
1975 (offset_intervals): Tell GCC not to worry about length overflow
1976 when negating a negative length.
1977
1978 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1979 (overrun_check_free): Likewise.
1980
1981 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1982 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1983 word size.
1984
1985 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1986 (gnutls_make_error): Rename local to avoid shadowing.
1987 (gnutls_emacs_global_deinit): ifdef out; not used.
1988 (Fgnutls_boot): Use const for pointer to readonly storage.
1989 Comment out unused local. Fix pointer signedness problems.
1990
1991 * lread.c (openp): Don't stuff size_t into an 'int'.
1992 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1993 about possible signed overflow.
1994
1995 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1996 (GDK_KEY_g): Don't define if already defined.
1997 (xg_prepare_tooltip): Avoid pointer signedness problem.
1998 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1999
2000 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2001 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2002
2003 * xfns.c (Fx_window_property): Simplify a bit,
2004 to make a bit faster and to avoid GCC 4.6.0 warning.
2005 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2006
2007 * fns.c (internal_equal): Don't assume size_t fits in int.
2008
2009 * alloc.c (compact_small_strings): Tighten assertion a little.
2010
2011 Replace pEd with more-general pI, and fix some printf arg casts.
2012 * lisp.h (pI): New macro, generalizing old pEd macro to other
2013 conversion specifiers. For example, use "...%"pI"d..." rather
2014 than "...%"pEd"...".
2015 (pEd): Remove. All uses replaced with similar uses of pI.
2016 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2017 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2018 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2019 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2020 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2021 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2022 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2023 64-bit hosts.
2024 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2025 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2026 * print.c (safe_debug_print, print_object): Likewise.
2027 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2028 to int.
2029 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2030 avoiding the 0 flag, which is not portable.
2031 * process.c (Fmake_network_process): Use pI to avoid cast.
2032 * region-cache.c (pp_cache): Likewise.
2033 * xdisp.c (decode_mode_spec): Likewise.
2034 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2035 behavior on 64-bit hosts with printf arg.
2036 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2037 (x_stop_queuing_selection_requests): Likewise.
2038 (x_get_window_property): Don't truncate byte count to an 'int'
2039 when tracing.
2040
2041 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2042 here, since it parses constructs like leading '-' and spaces,
2043 which are not wanted; and it overflows with large numbers.
2044 Instead, simply match F[0-9]+, which is what is wanted anyway.
2045
2046 * alloc.c: Remove unportable assumptions about struct layout.
2047 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2048 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2049 (allocate_vectorlike, make_pure_vector): Use the new macros,
2050 plus offsetof, to remove unportable assumptions about struct layout.
2051 These assumptions hold on all porting targets that I know of, but
2052 they are not guaranteed, they're easy to remove, and removing them
2053 makes further changes easier.
2054
2055 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2056 This doesn't fix a bug but makes the code clearer.
2057 (string_overrun_cookie): Now const. Use initializers that
2058 don't formally overflow signed char, to avoid warnings.
2059 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2060 can cause Emacs to crash when string overrun checking is enabled.
2061 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2062 multiple of sizeof (EMACS_INT); it need not be, if
2063 alignof(EMACS_INT) < sizeof (EMACS_INT).
2064 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2065
2066 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2067
2068 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2069
2070 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2071
2072 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2073 supposed to be handshaking. (Bug#8556)
2074 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2075
2076 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2077
2078 * lisp.h (Qdebug): List symbol.
2079 * eval.c (Qdebug): Restore global linkage.
2080 * keyboard.c (debug-on-event): New variable.
2081 (handle_user_signal): Break into debugger when debug-on-event
2082 matches the current signal symbol.
2083
2084 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2085
2086 * alloc.c (check_sblock, check_string_bytes)
2087 (check_string_free_list): Convert to standard C.
2088
2089 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2090
2091 * w32.c (emacs_gnutls_push): Fix typo.
2092
2093 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2094
2095 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2096 "cast to pointer from integer of different size".
2097
2098 Improve doprnt and its use in verror. (Bug#8545)
2099 * doprnt.c (doprnt): Document the set of format control sequences
2100 supported by the function. Use SAFE_ALLOCA instead of always
2101 using `alloca'.
2102
2103 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2104 is one byte too soon. Don't use xrealloc; instead xfree and
2105 xmalloc anew.
2106
2107 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2108
2109 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2110 callbacks stage.
2111
2112 * gnutls.c: Renamed global_initialized to
2113 gnutls_global_initialized. Added internals for the
2114 :verify-hostname-error, :verify-error, and :verify-flags
2115 parameters of `gnutls-boot' and documented those parameters in the
2116 docstring. Start callback support.
2117 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2118 unless a fatal error occured. Call gnutls_alert_send_appropriate
2119 on error. Return error code.
2120 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2121 (emacs_gnutls_read): Likewise.
2122 (Fgnutls_boot): Return handshake error code.
2123 (emacs_gnutls_handle_error): New function.
2124 (wsaerror_to_errno): Likewise.
2125
2126 * w32.h (emacs_gnutls_pull): Add prototype.
2127 (emacs_gnutls_push): Likewise.
2128
2129 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2130 (emacs_gnutls_push): Likewise.
2131
2132 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2133
2134 * process.c (wait_reading_process_output): Check if GnuTLS
2135 buffered some data internally if no FDs are set for TLS
2136 connections.
2137
2138 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2139 (LIBS): Link to USER_LIBS.
2140 ($(BLD)/gnutls.$(0)): New target.
2141
2142 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2143
2144 * xdisp.c (handle_single_display_spec): Rename the
2145 display_replaced_before_p argument into display_replaced_p, to
2146 make it consistent with the commentary. Fix typos in the
2147 commentary.
2148
2149 * textprop.c (syms_of_textprop): Remove dead code.
2150 (copy_text_properties): Delete obsolete commentary about an
2151 interface that was deleted long ago. Fix typos in the description
2152 of arguments.
2153
2154 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2155 to changes in oldXMenu/XMenu.h from 2011-04-16.
2156 <menu_help_message, prev_menu_help_message>: Constify.
2157 (IT_menu_make_room): menu->help_text is now `const char **';
2158 adjust.
2159
2160 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2161 to changes in oldXMenu/XMenu.h from 2011-04-16.
2162 (struct XMenu): Declare `help_text' `const char **'.
2163
2164 * xfaces.c <Qunspecified>: Make extern again.
2165
2166 * syntax.c: Include sys/types.h before including regex.h, as
2167 required by Posix.
2168
2169 * doc.c (get_doc_string): Improve the format passed to `error'.
2170
2171 * doprnt.c (doprnt): Improve commentary.
2172
2173 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2174
2175 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2176 them with etags.
2177
2178 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2179 changes in globals.h immediately force recompilation.
2180 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2181 $(CURDIR)/s/ms-w32.h.
2182 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2183
2184 * character.c (Fchar_direction): Function deleted.
2185 (syms_of_character): Don't defsubr it.
2186 <char-direction-table>: Deleted.
2187
2188 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2189
2190 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2191 * doprnt.c: Include limits.h.
2192 (SIZE_MAX): New macro.
2193 (doprnt): Return a size_t value. 2nd arg is now size_t.
2194 Many local variables are now size_t instead of int or unsigned.
2195 Improve overflow protection. Support `l' modifier for integer
2196 conversions. Support %l conversion. Don't assume an EMACS_INT
2197 argument for integer conversions and for %c.
2198
2199 * lisp.h (doprnt): Restore prototype.
2200
2201 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2202 $(SRC)/character.h.
2203
2204 * Makefile.in (base_obj): Add back doprnt.o.
2205
2206 * deps.mk (doprnt.o): Add back prerequisites.
2207 (callint.o): Depend on character.h.
2208
2209 * eval.c (internal_lisp_condition_case): Include the handler
2210 representation in the error message.
2211 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2212 when breaking from the loop.
2213
2214 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2215
2216 * callint.c (Fcall_interactively): When displaying error message
2217 about invalid control letter, pass the character's codepoint, not
2218 a pointer to its multibyte form. Improve display of the character
2219 in octal and display also its hex code.
2220
2221 * character.c (char_string): Use %x to display the (unsigned)
2222 codepoint of an invalid character, to avoid displaying a bogus
2223 negative value.
2224
2225 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2226 `error', not SYMBOL_NAME itself.
2227
2228 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2229 character arguments to `error'.
2230
2231 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2232 to `error' in error message about FINAL_CHAR argument. Make sure
2233 FINAL_CHAR is a character, and use %c when it is passed as
2234 argument to `error'.
2235
2236 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2237
2238 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2239
2240 * w32.c: Include <time.h>.
2241 (sys_localtime): New function.
2242
2243 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2244
2245 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2246
2247 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2248
2249 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2250
2251 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2252 zombies (Bug#8467).
2253
2254 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2255
2256 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2257 gl_state.e_property when gl_state.object is Qt.
2258
2259 * insdel.c (make_gap_larger): Remove limitation of buffer size
2260 to <= INT_MAX.
2261
2262 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2263
2264 * xdisp.c (lookup_glyphless_char_display)
2265 (produce_glyphless_glyph): Handle cons cell entry in
2266 glyphless-char-display.
2267 (Vglyphless_char_display): Document it.
2268
2269 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2270 glyphless-char-display.
2271
2272 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2273
2274 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2275
2276 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2277
2278 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2279 definition for no-X builds.
2280
2281 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2282
2283 Static checks with GCC 4.6.0 and non-default toolkits.
2284
2285 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2286
2287 * process.c (keyboard_bit_set): Define only if SIGIO.
2288 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2289 (send_process): Repair possible setjmp clobbering.
2290
2291 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2292
2293 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2294
2295 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2296
2297 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2298 Define only if needed.
2299
2300 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2301 by pacifying GCC about it. Maybe it's time to retire it?
2302 * xfaces.c (USG, __TIMEVAL__): Likewise.
2303
2304 * dispextern.h (struct redisplay_interface): Rename param
2305 to avoid shadowing.
2306 * termhooks.h (struct terminal): Likewise.
2307 * xterm.c (xembed_send_message): Likewise.
2308
2309 * insdel.c (make_gap_smaller): Define only if
2310 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2311
2312 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2313 it.
2314
2315 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2316 so that we aren't warned about unused symbols.
2317
2318 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2319
2320 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2321
2322 * xfns.c (x_real_positions): Mark locals as initialized.
2323
2324 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2325
2326 * xterm.c: Fix problems found by static analysis with other toolkits.
2327 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2328 (x_dispatch_event): Declare static if USE_GTK, and
2329 define if USE_GTK || USE_X_TOOLKIT.
2330 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2331 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2332 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2333 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2334
2335 * xmenu.c (menu_help_callback): Pointer type fixes.
2336 Use const pointers when pointing at readonly data. Avoid pointer
2337 signedness clashes.
2338 (FALSE): Remove unused macro.
2339 (update_frame_menubar): Remove unused decl.
2340
2341 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2342
2343 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2344 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2345 (single_menu_item): Rename local to avoid shadowing.
2346
2347 * keyboard.c (make_lispy_event): Remove unused local var.
2348
2349 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2350 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2351
2352 * bitmaps: Change bitmaps from unsigned char back to the X11
2353 compatible char. Avoid the old compiler warnings about
2354 out-of-range initializers by using, for example, '\xab' rather
2355 than 0xab.
2356
2357 * xgselect.c (xgselect_initialize): Check vs interface
2358 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2359
2360 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2361
2362 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2363 to read-only memory.
2364
2365 * fns.c (vector): Remove; this old hack is no longer needed.
2366
2367 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2368 Remove unused var.
2369 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2370
2371 * xrdb.c (x_load_resources): Omit unused local.
2372
2373 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2374 (x_window): Rename locals to avoid shadowing.
2375 (USG): Use the kludged USG macro, to pacify gcc.
2376
2377 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2378 (x_term_init): Remove local to avoid shadowing.
2379
2380 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2381
2382 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2383 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2384
2385 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2386
2387 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2388
2389 Fix regex.c, syntax.c and friends for buffers > 2GB.
2390 * syntax.h (struct gl_state_s): Declare character position members
2391 EMACS_INT.
2392
2393 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2394
2395 * textprop.c (verify_interval_modification, interval_of):
2396 Declare arguments EMACS_INT.
2397
2398 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2399 EMACS_INT.
2400
2401 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2402
2403 * indent.c (Fvertical_motion): Local variable it_start is now
2404 EMACS_INT.
2405
2406 * regex.c (re_match, re_match_2, re_match_2_internal)
2407 (bcmp_translate, regcomp, regexec, print_double_string)
2408 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2409 (re_compile_pattern, re_exec): Declare arguments and local
2410 variables `size_t' and `ssize_t' and return values `regoff_t', as
2411 appropriate.
2412 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2413 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2414 <compile_stack_type>: `size' and `avail' are now `size_t'.
2415
2416 * regex.h <regoff_t>: Use ssize_t, not int.
2417 (re_search, re_search_2, re_match, re_match_2): Arguments that
2418 specify buffer/string position and length are now ssize_t and
2419 size_t. Return type is regoff_t.
2420
2421 2011-04-16 Ben Key <bkey76@gmail.com>
2422
2423 * nsfont.m: Fixed bugs in ns_get_family and
2424 ns_descriptor_to_entity that were caused by using free to
2425 deallocate memory blocks that were allocated by xmalloc (via
2426 xstrdup). This caused Emacs to crash when compiled with
2427 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2428 --enable-checking=xmallocoverrun). xfree is now used to
2429 deallocate these memory blocks.
2430
2431 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2432
2433 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2434
2435 emacs_write: Accept and return EMACS_INT for sizes.
2436 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2437 et seq.
2438 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2439 Accept and return EMACS_INT.
2440 (emacs_gnutls_write): Return the number of bytes written on
2441 partial writes.
2442 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2443 (emacs_read, emacs_write): Remove check for negative size, as the
2444 Emacs source code has been audited now.
2445 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2446 (emacs_read, emacs_write): Use it.
2447 * process.c (send_process): Adjust to the new signatures of
2448 emacs_write and emacs_gnutls_write. Do not attempt to store
2449 a byte offset into an 'int'; it might overflow.
2450 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2451
2452 * sound.c: Don't assume sizes fit in 'int'.
2453 (struct sound_device.period_size, alsa_period_size):
2454 Return EMACS_INT, not int.
2455 (struct sound_device.write, vox_write, alsa_write):
2456 Accept EMACS_INT, not int.
2457 (wav_play, au_play): Use EMACS_INT to store sizes and to
2458 record read return values.
2459
2460 2011-04-15 Ben Key <bkey76@gmail.com>
2461
2462 * keyboard.c (Qundefined): Don't declare static since it is used
2463 in nsfns.m.
2464 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2465 static since they are used in nsfont.m.
2466
2467 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2468
2469 * process.c (Qprocessp): Don't declare static.
2470 * lisp.h (Qprocessp): Declare again.
2471
2472 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2473
2474 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2475
2476 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2477
2478 Improve C-level modularity by making more things 'static'.
2479
2480 Don't publish debugger-only interfaces to other modules.
2481 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2482 (verify_bytepos, count_markers): Move decls to the only modules
2483 that need them.
2484 * region-cache.h (pp_cache): Likewise.
2485 * window.h (check_all_windows): Likewise.
2486 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2487
2488 * sysdep.c (croak): Now static, if
2489 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2490 * syssignal.h (croak): Declare only if not static.
2491
2492 * alloc.c (refill_memory_reserve): Now static if
2493 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2494 * lisp.h (refill_memory_reserve): Declare only if not static.
2495
2496 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2497 Define only if USE_LUCID.
2498
2499 * xrdb.c (x_customization_string, x_rm_string): Now static.
2500
2501 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2502 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2503
2504 * xdisp.c (draw_row_with_mouse_face): Now static.
2505 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2506
2507 * window.h (check_all_windows): Mark externally visible.
2508
2509 * window.c (window_deletion_count): Now static.
2510
2511 * undo.c: Make symbols static if they're not exported.
2512 (last_undo_buffer, last_boundary_position, pending_boundary):
2513 Now static.
2514
2515 * textprop.c (interval_insert_behind_hooks): Now static.
2516 (interval_insert_in_front_hooks): Likewise.
2517
2518 * term.c: Make symbols static if they're not exported.
2519 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2520 (max_frame_lines, tty_set_terminal_modes):
2521 (tty_reset_terminal_modes, tty_turn_off_highlight):
2522 (get_tty_terminal): Now static.
2523 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2524 * termhooks.h (term_mouse_moveto): Do not declare if
2525 HAVE_WINDOW_SYSTEM.
2526 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2527 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2528
2529 * sysdep.c: Make symbols static if they're not exported.
2530 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2531 Now static.
2532 (sigprocmask_set, full_mask): Remove; unused.
2533 (wait_debugging): Mark as visible.
2534 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2535 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2536
2537 * syntax.c (syntax_temp): Define only if !__GNUC__.
2538
2539 * sound.c (current_sound_device, current_sound): Now static.
2540
2541 * search.c (searchbufs, searchbuf_head): Now static.
2542
2543 * scroll.c (scroll_cost): Remove; unused.
2544 * dispextern.h (scroll_cost): Remove decl.
2545
2546 * region-cache.h (pp_cache): Mark as externally visible.
2547
2548 * process.c: Make symbols static if they're not exported.
2549 (process_tick, update_tick, create_process, chan_process):
2550 (Vprocess_alist, proc_buffered_char, datagram_access):
2551 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2552 (deactivate_process): Mark defn as static, as well as decl.
2553 * lisp.h (create_process): Remove decl.
2554 * process.h (chan_process, Vprocess_alist): Remove decls.
2555
2556 * print.c: Make symbols static if they're not exported.
2557 (print_depth, new_backquote_output, being_printed, print_buffer):
2558 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2559 (print_interval, print_number_index, initial_stderr_stream):
2560 Now static.
2561 * lisp.h (Fprinc): Remove decl.
2562 (debug_output_compilation_hack): Mark as externally visible.
2563
2564 * sysdep.c (croak): Move decl from here to syssignal.h.
2565 * syssignal.h (croak): Put it here, so the API can be checked when
2566 'croak' is called from dissociate_if_controlling_tty.
2567
2568 * minibuf.c: Make symbols static if they're not exported.
2569 (minibuf_save_list, choose_minibuf_frame): Now static.
2570 * lisp.h (choose_minibuf_frame): Remove decl.
2571
2572 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2573
2574 * lread.c: Make symbols static if they're not exported.
2575 (read_objects, initial_obarray, oblookup_last_bucket_number):
2576 Now static.
2577 (make_symbol): Remove; unused.
2578 * lisp.h (initial_obarray, make_symbol): Remove decls.
2579
2580 * keyboard.c: Make symbols static if they're not exported.
2581 (single_kboard, recent_keys_index, total_keys, recent_keys):
2582 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2583 (this_single_command_key_start, echoing, last_auto_save):
2584 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2585 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2586 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2587 (Vlispy_mouse_stem, double_click_count):
2588 Now static.
2589 (force_auto_save_soon): Define only if SIGDANGER.
2590 (ignore_mouse_drag_p): Now static if
2591 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2592 (print_help): Remove; unused.
2593 (stop_character, last_timer_event): Mark as externally visible.
2594 * keyboard.h (ignore_mouse_drag_p): Declare only if
2595 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2596 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2597 * lisp.h (echoing): Remove decl.
2598 (force_auto_save_soon): Declare only if SIGDANGER.
2599 * xdisp.c (redisplay_window): Simplify code, to make it more
2600 obvious that ignore_mouse_drag_p is not accessed if !defined
2601 USE_GTK && !defined HAVE_NS.
2602
2603 * intervals.c: Make symbols static if they're not exported.
2604 (merge_properties_sticky, merge_interval_right, delete_interval):
2605 Now static.
2606 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2607
2608 * insdel.c: Make symbols static if they're not exported.
2609 However, leave prepare_to_modify_buffer alone. It's never
2610 called from outside this function, but that appears to be a bug.
2611 (combine_after_change_list, combine_after_change_buffer):
2612 (adjust_after_replace, signal_before_change): Now static.
2613 (adjust_after_replace_noundo): Remove; unused.
2614 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2615 (signal_before_change): Remove decls.
2616
2617 * indent.c (val_compute_motion, val_vmotion): Now static.
2618
2619 * image.c: Make symbols static if they're not exported.
2620 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2621 if USE_GTK.
2622 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2623 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2624
2625 * fringe.c (standard_bitmaps): Now static.
2626 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2627
2628 * frame.c: Make symbols static if they're not exported.
2629 (x_report_frame_params, make_terminal_frame): Now static.
2630 (get_frame_param): Now static, unless HAVE_NS.
2631 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2632 (x_get_resource_string): Remove; not used.
2633 * frame.h (make_terminal_frame, x_report_frame_params):
2634 (x_get_resource_string); Remove decls.
2635 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2636 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2637
2638 * font.c, fontset.c: Make symbols static if they're not exported.
2639 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2640 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2641 * font.c (font_close_object): Now static.
2642 * font.h (font_close_object): Remove.
2643 * fontset.c (FONTSET_OBJLIST): Remove.
2644 (free_realized_fontset) #if-0 the body, which does nothing.
2645 (face_suitable_for_char_p): #if-0, as it's never called.
2646 * fontset.h (face_suitable_for_char_p): Remove decl.
2647 * xfaces.c (face_at_string_position):
2648 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2649 since 0 is always ASCII.
2650
2651 * fns.c (weak_hash_tables): Now static.
2652
2653 * fileio.c: Make symbols static if they're not exported.
2654 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2655 (Vwrite_region_annotation_buffers): Now static.
2656
2657 * eval.c: Make symbols static if they're not exported.
2658 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2659 * lisp.h (backtrace_list): Remove decl.
2660
2661 * emacs.c: Make symbols static if they're not exported.
2662 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2663 (fatal_error_code, fatal_error_signal_hook, standard_args):
2664 Now static.
2665 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2666 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2667 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2668 * lisp.h (fatal_error_signal_hook): Remove decl.
2669 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2670
2671 * editfns.c: Move a (normally-unused) function to its only use.
2672 * editfns.c, lisp.h (get_operating_system_release): Remove.
2673 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2674 worth the hassle of breaking this out.
2675
2676 * xterm.c: Make symbols static if they're not exported.
2677 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2678 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2679 (x_destroy_window, x_delete_display):
2680 Now static.
2681 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2682 (x_mouse_leave): Remove; unused.
2683 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2684 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2685 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2686 Remove decls.
2687 (x_mouse_leave): Declare only if WINDOWSNT.
2688 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2689 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2690 USE_X_TOOLKIT.
2691
2692 * ftxfont.c: Make symbols static if they're not exported.
2693 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2694 HAVE_FREETYPE.
2695 * font.h (ftxfont_driver): Likewise.
2696
2697 * xfns.c: Make symbols static if they're not exported.
2698 (x_last_font_name, x_display_info_for_name):
2699 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2700 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2701 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2702 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2703 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2704 (last_show_tip_args): Now static.
2705 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2706 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2707 (x_screen_planes): Remove; unused.
2708 * dispextern.h (x_screen_planes): Remove decl.
2709
2710 * dispnew.c: Make symbols static if they're not exported.
2711 * dispextern.h (redraw_garbaged_frames, scrolling):
2712 (increment_row_positions): Remove.
2713 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2714 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2715 Now static.
2716 (redraw_garbaged_frames): Remove; unused.
2717
2718 * xfaces.c: Make symbols static if they're not exported.
2719 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2720 Remove decls.
2721 * xterm.h (defined_color): Remove decls.
2722 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2723 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2724 (menu_face_changed_default, defined_color, free_realized_face):
2725 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2726 (ascii_face_of_lisp_face): Remove; unused.
2727
2728 * xdisp.c: Make symbols static if they're not exported.
2729 * dispextern.h (scratch_glyph_row, window_box_edges):
2730 (glyph_to_pixel_coords, set_cursor_from_row):
2731 (get_next_display_element, set_iterator_to_next):
2732 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2733 (show_mouse_face): Remove decls
2734 * frame.h (message_buf_print): Likewise.
2735 * lisp.h (pop_message, set_message, check_point_in_composition):
2736 Likewise.
2737 * xterm.h (set_vertical_scroll_bar): Likewise.
2738 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2739 (message_buf_print, scratch_glyph_row, displayed_buffer):
2740 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2741 (get_next_display_element, show_mouse_face, window_box_edges):
2742 (frame_to_window_pixel_xy, check_point_in_composition):
2743 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2744 (glyph_to_pixel_coords): Remove; unused.
2745
2746 * dired.c (file_name_completion): Now static.
2747
2748 * dbusbind.c (xd_in_read_queued_messages): Now static.
2749
2750 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2751 * data.c (circular_list_error): Remove.
2752
2753 * commands.h (last_point_position, last_point_position_buffer):
2754 (last_point_position_window): Remove decls.
2755 * keyboard.c: Make these variables static.
2756
2757 * coding.h (coding, code_convert_region, encode_coding_gap):
2758 Remove decls.
2759 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2760 (iso_code_class, detect_coding, code_convert_region): Now static.
2761 (encode_coding_gap): Remove; unused.
2762
2763 * chartab.c (chartab_chars, chartab_bits): Now static.
2764
2765 * charset.h (charset_iso_8859_1): Remove decl.
2766 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2767 Now static.
2768
2769 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2770 * ccl.c (Vccl_program_table): Now static.
2771 (check_ccl_update): Remove; unused.
2772
2773 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2774 * category.h: ... from here.
2775 * category.c (check_category_table, set_category_set): Now static.
2776
2777 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2778 * lisp.h: Remove these decls.
2779
2780 * buffer.c (buffer_count): Remove unused var.
2781
2782 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2783 so that it's not optimized away.
2784 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2785 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2786 exported only to the debugger.
2787
2788 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2789 * atimer.h (run_all_atimers): Remove; not exported.
2790
2791 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2792 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2793 was inaccessible from Lisp.
2794 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2795 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2796
2797 alloc.c: Import and export fewer symbols, and remove unused items.
2798 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2799 is defined.
2800 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2801 it's not optimized away by whole-program optimization.
2802 (message_enable_multibyte, free_misc): Remove.
2803 (catchlist, handlerlist, mark_backtrace):
2804 Declare only if BYTE_MARK_STACK.
2805 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2806 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2807 (message_enable_multibyte): Remove decl.
2808 (free_misc, interval_free_list, float_block, float_block_index):
2809 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2810 (cons_free_list, last_marked_index):
2811 Now static.
2812 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2813 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2814 (mark_backtrace): Define only if BYTE_MARK_STACK.
2815 * xdisp.c (message_enable_multibyte): Now static.
2816
2817 Declare Lisp_Object Q* variables to be 'static' if not exported.
2818 This makes it easier for human readers (and static analyzers)
2819 to see whether these variables are used from other modules.
2820 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2821 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2822 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2823 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2824 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2825 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2826 * xmenu.c, xselect.c:
2827 Declare Q* vars static if they are not used in other modules.
2828 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2829 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2830 Remove decls of unexported vars.
2831 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2832
2833 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2834
2835 Make Emacs functions such as Fatom 'static' by default.
2836 This makes it easier for human readers (and static analyzers)
2837 to see whether these functions can be called from other modules.
2838 DEFUN now defines a static function. To make the function external
2839 so that it can be used in other C modules, use the new macro DEFUE.
2840 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2841 (Finit_image_library):
2842 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2843 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2844 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2845 Remove decls, since these functions are now static.
2846 (Funintern, Fget_internal_run_time): New decls, since these functions
2847 were already external.
2848
2849 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2850 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2851 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2852 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2853 * keyboard.c, keymap.c, lread.c:
2854 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2855 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2856 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2857 Mark functions with DEFUE instead of DEFUN,
2858 if they are used in other modules.
2859 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2860 decls for now-static functions.
2861 * buffer.h (Fdelete_overlay): Remove decl.
2862 * callproc.c (Fgetenv_internal): Mark as internal.
2863 * composite.c (Fremove_list_of_text_properties): Remove decl.
2864 (Fcomposition_get_gstring): New forward static decl.
2865 * composite.h (Fcomposite_get_gstring): Remove decl.
2866 * dired.c (Ffile_attributes): New forward static decl.
2867 * doc.c (Fdocumntation_property): New forward static decl.
2868 * eval.c (Ffetch_bytecode): New forward static decl.
2869 (Funintern): Remove extern decl; now in .h file where it belongs.
2870 * fileio.c (Fmake_symbolic_link): New forward static decl.
2871 * image.c (Finit_image_library): New forward static decl.
2872 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2873 * intervals.h (Fprevious_property_change):
2874 (Fremove_list_of_text_properties): Remove decls.
2875 * keyboard.c (Fthis_command_keys): Remove decl.
2876 (Fcommand_execute): New forward static decl.
2877 * keymap.c (Flookup_key): New forward static decl.
2878 (Fcopy_keymap): Now static.
2879 * keymap.h (Flookup_key): Remove decl.
2880 * process.c (Fget_process): New forward static decl.
2881 (Fprocess_datagram_address): Mark as internal.
2882 * syntax.c (Fsyntax_table_p): New forward static decl.
2883 (skip_chars): Remove duplicate decl.
2884 * textprop.c (Fprevious_property_change): New forward static decl.
2885 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2886 Now internal.
2887 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2888 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2889
2890 * editfns.c (Fformat): Remove unreachable code.
2891
2892 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2893
2894 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2895 change. (Bug#8496)
2896
2897 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2898
2899 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2900 when at ZV. (Bug#8487)
2901
2902 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2903
2904 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2905 (Bug#8437)
2906 * keyboard.c (parse_tool_bar_item): Likewise.
2907 * sound.c (sound_cleanup, alsa_close): Likewise.
2908 * termcap.c (tgetent): Likewise.
2909 * xfns.c (x_default_font_parameter): Likewise.
2910 * xsettings.c (read_and_apply_settings): Likewise.
2911
2912 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2913 (overrun_check_free): Protoize.
2914
2915 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2916
2917 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2918 since callers should never pass a negative size.
2919 Change the signature to match that of plain 'read' and 'write'; see
2920 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2921 * lisp.h: Update prototypes of emacs_write and emacs_read.
2922
2923 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2924
2925 * xdisp.c (redisplay_window): Don't try to determine the character
2926 position of the scroll margin if the window start point w->startp
2927 is outside the buffer's accessible region. (Bug#8468)
2928
2929 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2930
2931 Fix write-region and its subroutines for buffers > 2GB.
2932 * fileio.c (a_write, e_write): Modify declaration of arguments and
2933 local variables to support buffers larger than 2GB.
2934 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2935
2936 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2937 argument, local variables, and return value.
2938
2939 * lisp.h: Update prototypes of emacs_write and emacs_read.
2940
2941 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2942
2943 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2944
2945 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2946
2947 Fix more problems found by GCC 4.6.0's static checks.
2948
2949 * xdisp.c (vmessage): Use a better test for character truncation.
2950
2951 * charset.c (load_charset_map): <, not <=, for optimization,
2952 and to avoid potential problems with integer overflow.
2953 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2954 * casetab.c (set_identity, shuffle): Likewise.
2955 * editfns.c (Fformat): Likewise.
2956 * syntax.c (skip_chars): Likewise.
2957
2958 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2959 This also lets GCC 4.6.0 generate slightly better loop code.
2960
2961 * callint.c (Fcall_interactively): <, not <=, for optimization.
2962 (Fcall_interactively): Count the number of arguments produced,
2963 not the number of arguments given. This is simpler and lets GCC
2964 4.6.0 generate slightly better code.
2965
2966 * ftfont.c: Distingish more carefully between FcChar8 and char.
2967 The previous code passed unsigned char * to a functions like
2968 strlen and xstrcasecmp that expect char *, which does not
2969 conform to the C standard.
2970 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2971 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2972 char * when the C standard requires it.
2973
2974 * keyboard.c (read_char): Remove unused var.
2975
2976 * eval.c: Port to Windows vsnprintf (Bug#8435).
2977 Include <limits.h>.
2978 (SIZE_MAX): Define if the headers do not.
2979 (verror): Do not give up if vsnprintf returns a negative count.
2980 Instead, grow the buffer. This ports to Windows vsnprintf, which
2981 does not conform to C99. Problem reported by Eli Zaretskii.
2982 Also, simplify the allocation scheme, by avoiding the need for
2983 calling realloc, and removing the ALLOCATED variable.
2984
2985 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2986
2987 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2988 But keep the doprint source code for now, as we might revamp it
2989 and use it again (Bug#8435).
2990 * lisp.h (doprnt): Remove.
2991 * Makefile.in (base_obj): Remove doprnt.o.
2992 * deps.mk (doprnt.o): Remove.
2993
2994 error: Print 32- and 64-bit integers portably (Bug#8435).
2995 Without this change, on typical 64-bit hosts error ("...%d...", N)
2996 was used to print both 32- and 64-bit integers N, which relied on
2997 undefined behavior.
2998 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2999 New macro.
3000 * lisp.h (error, verror): Mark as printf-like functions.
3001 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3002 Report overflow in size calculations when allocating printf buffer.
3003 Do not truncate output string at its first null byte.
3004 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3005 Truncate the output at a character boundary, since vsnprintf does not
3006 do that.
3007 * charset.c (check_iso_charset_parameter): Convert internal
3008 character to string before calling 'error', since %c now has the
3009 printf meaning.
3010 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3011 overflow when computing char to be passed to 'error'. Do not
3012 pass Lisp_Object to 'error'; pass the integer instead.
3013 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3014 formatted with plain %d.
3015
3016 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3017
3018 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3019
3020 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3021
3022 * xterm.c (x_catch_errors): Remove duplicate declaration.
3023
3024 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3025
3026 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3027
3028 2011-04-10 Jim Meyering <meyering@redhat.com>
3029
3030 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3031 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3032 return ssize_t not "int", and use size_t as the buffer length.
3033 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3034 * gnutls.h: Update declarations.
3035 * process.c (read_process_output): Use ssize_t, to match.
3036 (send_process): Likewise.
3037
3038 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3039
3040 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3041
3042 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3043
3044 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3045 Use unsigned char, to match FcChar8 type definition.
3046
3047 * xterm.c (handle_one_xevent):
3048 * xmenu.c (create_and_show_popup_menu):
3049 * xselect.c (x_decline_selection_request)
3050 (x_reply_selection_request): Avoid type-punned deref of X events.
3051
3052 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3053
3054 Fix some uses of `int' instead of EMACS_INT.
3055 * search.c (string_match_1, fast_string_match)
3056 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3057 (scan_buffer, find_next_newline_no_quit)
3058 (find_before_next_newline, search_command, Freplace_match)
3059 (Fmatch_data): Make some `int' variables be EMACS_INT.
3060
3061 * xdisp.c (display_count_lines): 3rd argument and return value now
3062 EMACS_INT. All callers changed.
3063 (pint2hrstr): Last argument is now EMACS_INT.
3064
3065 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3066 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3067 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3068 (decode_coding_utf_16, decode_coding_emacs_mule)
3069 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3070 (decode_coding_ccl, decode_coding_charset)
3071 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3072 (decode_coding_iso_2022, decode_coding_emacs_mule)
3073 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3074 <char_offset, last_offset>: Declare EMACS_INT.
3075 (encode_coding_utf_8, encode_coding_utf_16)
3076 (encode_coding_emacs_mule, encode_invocation_designation)
3077 (encode_designation_at_bol, encode_coding_iso_2022)
3078 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3079 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3080 Declare EMACS_INT.
3081 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3082 (encode_invocation_designation): Last argument P_NCHARS is now
3083 EMACS_INT.
3084 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3085 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3086
3087 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3088 All users changed.
3089
3090 * ccl.c (Fccl_execute_on_string): Declare some variables
3091 EMACS_INT.
3092
3093 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3094
3095 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3096
3097 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3098
3099 * process.c (Fformat_network_address): Doc fix.
3100
3101 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3102
3103 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3104
3105 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3106
3107 * keyboard.c (read_char): Call Lisp function help-form-show,
3108 instead of using internal_with_output_to_temp_buffer.
3109 (Qhelp_form_show): New var.
3110 (syms_of_keyboard): Use DEFSYM macro.
3111
3112 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3113
3114 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3115
3116 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3117
3118 * process.c (Flist_processes): Remove to Lisp.
3119 (list_processes_1): Delete.
3120
3121 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3122
3123 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3124
3125 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3126
3127 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3128
3129 Fix more problems found by GCC 4.6.0's static checks.
3130
3131 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3132
3133 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3134
3135 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3136
3137 * xdisp.c (vmessage): Mark as a printf-like function.
3138
3139 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3140
3141 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3142
3143 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3144 printf-like functions.
3145 (tiff_load): Add casts to remove these marks before passing them
3146 to system-supplied API.
3147
3148 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3149
3150 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3151 This avoids several warnings with gcc -Wstrict-overflow.
3152 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3153 directly, rather than having caller test rule sign. This avoids
3154 some unnecessary tests.
3155 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3156 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3157 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3158
3159 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3160 (xfont_open): Avoid unnecessary tests.
3161
3162 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3163
3164 * composite.h, composite.c (composition_gstring_put_cache):
3165 Use EMACS_INT, not int, for length.
3166
3167 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3168 breaking out part of COMPOSITION_DECODE_RULE.
3169 (COMPOSITION_DECODE_RULE): Use it.
3170 * composite.c (get_composition_id): Remove unused local vars,
3171 by using the new macro.
3172
3173 * textprop.c (set_text_properties_1): Change while to do-while,
3174 since the condition is always true at first.
3175
3176 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3177 (interval_deletion_adjustment): Return unsigned value.
3178 All uses changed.
3179
3180 * process.c (list_processes_1, create_pty, read_process_output):
3181 (exec_sentinel): Remove vars that were set but not used.
3182 (create_pty): Remove unnecessary "volatile"s.
3183 (Fnetwork_interface_info): Avoid possibility of int overflow.
3184 (read_process_output): Do adaptive read buffering even if carryover.
3185 (read_process_output): Simplify nbytes computation if buffered.
3186
3187 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3188
3189 * syntax.c (scan_words): Remove var that was set but not used.
3190 (update_syntax_table): Use unsigned instead of int.
3191
3192 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3193 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3194 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3195
3196 * print.c (print_error_message): Avoid int overflow.
3197
3198 * font.c (font_list_entities): Redo for clarity,
3199 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3200
3201 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3202 (font_score): Avoid potential overflow in diff calculation.
3203
3204 * fns.c (substring_both): Remove var that is set but not used.
3205 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3206
3207 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3208
3209 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3210 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3211 can always succeed if overflow has undefined behavior.
3212
3213 * search.c (boyer_moore, wordify): Remove vars set but not used.
3214 (wordify): Omit three unnecessary tests.
3215
3216 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3217 All callers changed. This avoids the need for an unused var.
3218
3219 * casefiddle.c (casify_region): Remove var that is set but not used.
3220
3221 * dired.c (file_name_completion): Remove var that is set but not used.
3222
3223 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3224
3225 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3226 (Finsert_file_contents): Remove unnecessary code checking fd.
3227
3228 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3229 Check for integer overflow on size calculations.
3230
3231 * buffer.c (Fprevious_overlay_change): Remove var that is set
3232 but not used.
3233
3234 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3235 Remove vars that are set but not used.
3236 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3237 (timer_check_2): Mark vars as initialized.
3238
3239 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3240
3241 * image.c (lookup_image): Remove var that is set but not used.
3242 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3243
3244 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3245 that are set but not used.
3246
3247 * xfns.c (make_invisible_cursor): Don't return garbage
3248 if XCreateBitmapFromData fails (Bug#8410).
3249
3250 * xselect.c (x_get_local_selection, x_handle_property_notify):
3251 Remove vars that are set but not used.
3252
3253 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3254 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3255
3256 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3257 Remove var that is set but not used.
3258 (scroll_bar_windows_size): Now size_t, not int.
3259 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3260 Check for overflow.
3261
3262 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3263 (map_tty_color) [!defined MSDOS]: Likewise.
3264
3265 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3266
3267 * coding.c: Remove vars that are set but not used.
3268 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3269 All callers changed.
3270 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3271 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3272 (decode_coding_charset): Remove vars that are set but not used.
3273
3274 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3275 that is set but not used.
3276
3277 * print.c (print_object): Remove var that is set but not used.
3278
3279 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3280 The gnulib version avoids calling malloc in the usual case,
3281 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3282 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3283 * filelock.c (current_lock_owner): Likewise.
3284 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3285 * sysdep.c: Include allocator.h, careadlinkat.h.
3286 (emacs_no_realloc_allocator): New static constant.
3287 (emacs_readlink): New function.
3288 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3289 ../lib/careadlinkat.h.
3290
3291 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3292
3293 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3294 first non-nil return value).
3295
3296 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3297
3298 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3299 if not defined (Bug#8403).
3300
3301 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3302
3303 * xdisp.c (display_count_lines): Remove parameter `start',
3304 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3305 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3306 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3307 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3308 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3309 and thereabouts. All callers changed.
3310 (get_per_char_metric): Remove parameter `f', unused since
3311 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3312
3313 2011-04-02 Jim Meyering <meyering@redhat.com>
3314
3315 do not dereference NULL upon failed strdup
3316 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3317 (ns_get_family): Likewise.
3318
3319 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3320
3321 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3322
3323 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3324
3325 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3326 later (Bug#8403).
3327
3328 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3329
3330 Add lexical binding.
3331
3332 * window.c (Ftemp_output_buffer_show): New fun.
3333 (Fsave_window_excursion):
3334 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3335
3336 * lread.c (lisp_file_lexically_bound_p): New function.
3337 (Fload): Bind Qlexical_binding.
3338 (readevalloop): Remove `evalfun' arg.
3339 Bind Qinternal_interpreter_environment.
3340 (Feval_buffer): Bind Qlexical_binding.
3341 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3342 Mark as dynamic.
3343 (syms_of_lread): Declare `lexical-binding'.
3344
3345 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3346
3347 * keyboard.c (eval_dyn): New fun.
3348 (menu_item_eval_property): Use it.
3349
3350 * image.c (parse_image_spec): Use Ffunctionp.
3351
3352 * fns.c (concat, mapcar1): Accept byte-code-functions.
3353
3354 * eval.c (Fsetq): Handle lexical vars.
3355 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3356 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3357 (FletX, Flet): Obey lexical binding.
3358 (Fcommandp): Handle closures.
3359 (Feval): New `lexical' arg.
3360 (eval_sub): New function extracted from Feval. Use it almost
3361 everywhere where Feval was used. Look up vars in lexical env.
3362 Handle closures.
3363 (Ffunctionp): Move from subr.el.
3364 (Ffuncall): Handle closures.
3365 (apply_lambda): Remove `eval_flags'.
3366 (funcall_lambda): Handle closures and new byte-code-functions.
3367 (Fspecial_variable_p): New function.
3368 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3369 but without exporting it to Lisp.
3370
3371 * doc.c (Fdocumentation, store_function_docstring):
3372 * data.c (Finteractive_form): Handle closures.
3373
3374 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3375 interactive spec.
3376
3377 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3378 New byte-codes.
3379 (exec_byte_code): New function extracted from Fbyte_code to handle new
3380 calling convention for byte-code-functions. Add new byte-codes.
3381
3382 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3383
3384 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3385
3386 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3387
3388 * xdisp.c (redisplay_internal): Fix prototype.
3389
3390 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3391
3392 * xdisp.c (SCROLL_LIMIT): New macro.
3393 (try_scrolling): Use it when setting scroll_limit.
3394 Limit scrolling to 100 screen lines.
3395 (redisplay_window): Even when falling back on "recentering",
3396 position point in the window according to scroll-conservatively,
3397 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3398
3399 (try_scrolling): When point is above the window, allow searching
3400 as far as scroll_max, or one screenful, to compute vertical
3401 distance from PT to the scroll margin position. This prevents
3402 try_scrolling from unnecessarily failing when
3403 scroll-conservatively is set to a value slightly larger than the
3404 window height. Clean up the case of PT below the margin at bottom
3405 of window: scroll_max can no longer be INT_MAX. When aggressive
3406 scrolling is in use, don't let point enter the opposite scroll
3407 margin as result of the scroll.
3408 (syms_of_xdisp) <scroll-conservatively>: Document the
3409 threshold of 100 lines for never-recentering scrolling.
3410
3411 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3412
3413 * dispextern.h (move_it_by_lines):
3414 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3415 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3416 (message_log_check_duplicate): Remove parameters `prev_bol' and
3417 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3418 (redisplay_internal): Remove parameter `preserve_echo_area',
3419 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3420
3421 * indent.c (Fvertical_motion):
3422 * window.c (window_scroll_pixel_based, Frecenter):
3423 Don't pass `need_y_p' to `move_it_by_lines'.
3424
3425 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3426
3427 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3428 steal a few bits to be more compact.
3429 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3430 Remove unneeded casts.
3431
3432 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3433
3434 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3435
3436 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3437 binding" message (bug#7967).
3438
3439 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3440
3441 Fix more problems found by GCC 4.6.0's static checks.
3442
3443 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3444 Remove unused local var.
3445
3446 * editfns.c (Fmessage_box): Remove unused local var.
3447
3448 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3449 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3450 Omit unused local vars.
3451 * window.c (shrink_windows): Omit unused local var.
3452 * menu.c (digest_single_submenu): Omit unused local var.
3453 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3454 Omit unused local var.
3455
3456 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3457 Don't assume string length fits in int.
3458 (keyremap_step, read_key_sequence): Use size_t for sizes.
3459 (read_key_sequence): Don't check last_real_key_start redundantly.
3460
3461 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3462 instead of alloca (Bug#8344).
3463
3464 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3465 (Fbacktrace_frame): Don't assume nframes fits in int.
3466
3467 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3468
3469 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3470 concerns.
3471
3472 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3473
3474 * cm.c (calccost): Turn while-do into do-while, for clarity.
3475
3476 * keyboard.c (syms_of_keyboard): Use the same style as later
3477 in this function when indexing through an array. This also
3478 works around GCC bug 48267.
3479
3480 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3481
3482 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3483
3484 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3485 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3486
3487 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3488 This avoids undefined behavior on integer overflow, and is a bit
3489 more convenient anyway since it is compared to a size_t variable.
3490
3491 Variadic C functions now count arguments with size_t, not int.
3492 This avoids an unnecessary limitation on 64-bit machines, which
3493 caused (substring ...) to crash on large vectors (Bug#8344).
3494 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3495 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3496 All variadic functions and their callers changed accordingly.
3497 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3498 * data.c (arith_driver, float_arith_driver): Likewise.
3499 * editfns.c (general_insert_function): Likewise.
3500 * eval.c (struct backtrace.nargs, interactive_p)
3501 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3502 (funcall_lambda, mark_backtrace): Likewise.
3503 * fns.c (concat): Likewise.
3504 * frame.c (x_set_frame_parameters): Likewise.
3505 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3506 0 if not found, not -1. All callers changed.
3507
3508 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3509 (stack_copy_size): Now size_t, not int.
3510 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3511
3512 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3513
3514 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3515 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3516 All callers changed.
3517
3518 * lisp.h (multibyte_char_to_unibyte):
3519 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3520 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3521 * character.h (CHAR_TO_BYTE8):
3522 * cmds.c (internal_self_insert):
3523 * editfns.c (general_insert_function):
3524 * keymap.c (push_key_description):
3525 * search.c (Freplace_match):
3526 * xdisp.c (message_dolog, set_message_1): All callers changed.
3527
3528 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3529
3530 * keyboard.c (safe_run_hook_funcall): New function.
3531 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3532 don't set the hook to nil, but remove the offending function instead.
3533 (Qcommand_hook_internal): Remove, unused.
3534 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3535 Vcommand_hook_internal.
3536
3537 * eval.c (enum run_hooks_condition): Remove.
3538 (funcall_nil, funcall_not): New functions.
3539 (run_hook_with_args): Call each function through a `funcall' argument.
3540 Remove `cond' argument, now redundant.
3541 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3542 (Frun_hook_with_args_until_failure): Adjust accordingly.
3543 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3544
3545 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3546
3547 * dispextern.h (string_buffer_position): Remove declaration.
3548
3549 * print.c (strout): Remove parameter `multibyte', unused since
3550 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3551
3552 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3553 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3554 All callers changed.
3555
3556 * w32.c (_wsa_errlist): Use braces for struct initializers.
3557
3558 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3559 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3560 All callers changed.
3561 (string_buffer_position): Likewise. Also, make static (it's never
3562 used outside xdisp.c).
3563 (cursor_row_p): Remove parameter `w', unused since
3564 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3565 (decode_mode_spec): Remove parameter `precision', introduced during
3566 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3567 All callers changed.
3568
3569 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3570
3571 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3572
3573 2011-03-27 Anders Lindgren <andlind@gmail.com>
3574
3575 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3576 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3577 (ns_update_auto_hide_menu_bar): New functions.
3578 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3579 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3580 ns_constrain_all_frames.
3581 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3582 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3583
3584 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3585
3586 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3587
3588 2011-03-27 Glenn Morris <rgm@gnu.org>
3589
3590 * syssignal.h: Replace RETSIGTYPE with void.
3591 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3592 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3593 Replace SIGTYPE with void everywhere.
3594 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3595 * s/template.h (SIGTYPE): Remove commented out definition.
3596
3597 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3598
3599 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3600 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3601
3602 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3603
3604 * w32.c (read_unc_volume): Use parameter `henum', instead of
3605 global variable `wget_enum_handle'.
3606
3607 * keymap.c (describe_vector): Remove parameters `indices' and
3608 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3609 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3610
3611 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3612
3613 * keyboard.c (timer_check): Remove parameter `do_it_now',
3614 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3615 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3616 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3617
3618 * keyboard.c (read_char):
3619 * w32menu.c (w32_menu_display_help):
3620 * xmenu.c (show_help_event, menu_help_callback):
3621 Adjust calls to `show_help_echo'.
3622
3623 * gtkutil.c (xg_maybe_add_timer):
3624 * keyboard.c (readable_events):
3625 * process.c (wait_reading_process_output):
3626 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3627
3628 * insdel.c (adjust_markers_gap_motion):
3629 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3630 (gap_left, gap_right): Don't call it.
3631
3632 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3633
3634 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3635 incurred during fontification.
3636
3637 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3638
3639 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3640 (DEFVAR_PER_BUFFER): Don't pass it.
3641
3642 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3643 (scrolling_window): Don't pass it.
3644
3645 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3646
3647 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3648
3649 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3650 and `suffix'.
3651 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3652 of variables specific to SELinux and computation of `encoded_absname'.
3653
3654 * image.c (XPutPixel): Remove unused variable `height'.
3655
3656 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3657
3658 * unexw32.c (get_section_info): Remove unused variable `section'.
3659
3660 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3661 (system_process_attributes): Remove unused variable `sess'.
3662 (sys_read): Remove unused variable `err'.
3663
3664 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3665 (w32_wnd_proc): Remove unused variable `isdead'.
3666 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3667 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3668 (x_create_tip_frame): Remove unused variable `tem'.
3669
3670 * w32inevt.c (w32_console_read_socket):
3671 Remove unused variable `no_events'.
3672
3673 * w32term.c (x_draw_composite_glyph_string_foreground):
3674 Remove unused variable `width'.
3675
3676 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3677
3678 * w32term.c (x_set_glyph_string_clipping):
3679 Don't pass uninitialized region to CombineRgn.
3680
3681 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3682
3683 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3684 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3685 (Fx_close_connection): Remove unused variable `i'.
3686
3687 * w32font.c (w32font_draw): Return number of glyphs.
3688 (w32font_open_internal): Remove unused variable `i'.
3689 (w32font_driver): Add missing initializer.
3690
3691 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3692 (fill_in_menu): Remove unused variable `items_added'.
3693
3694 * w32term.c (last_mouse_press_frame): Remove static global variable.
3695 (w32_clip_to_row): Remove unused variable `f'.
3696 (x_delete_terminal): Remove unused variable `i'.
3697
3698 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3699 (NOTHING): Remove unused static global variable.
3700 (uniscribe_check_otf): Remove unused variable `table'.
3701 (uniscribe_font_driver): Add missing initializers.
3702
3703 2011-03-23 Julien Danjou <julien@danjou.info>
3704
3705 * term.c (Fsuspend_tty, Fresume_tty):
3706 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3707 * window.c (temp_output_buffer_show):
3708 * insdel.c (signal_before_change):
3709 * frame.c (Fhandle_switch_frame):
3710 * fileio.c (Fdo_auto_save):
3711 * emacs.c (Fkill_emacs):
3712 * editfns.c (save_excursion_restore):
3713 * cmds.c (internal_self_insert):
3714 * callint.c (Fcall_interactively):
3715 * buffer.c (Fkill_all_local_variables):
3716 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3717 Use Frun_hooks.
3718 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3719 unconditionnaly since it does the check itself.
3720
3721 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3722
3723 Fix more problems found by GCC 4.5.2's static checks.
3724
3725 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3726 the first time through the loop, since we know p0 < p1 then.
3727 This also avoids a gcc -Wstrict-overflow warning.
3728
3729 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3730 leading to a memory leak, possible in functions like
3731 load_charset_map_from_file that can allocate an unbounded number
3732 of objects (Bug#8318).
3733
3734 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3735 that could (at least in theory) be that large.
3736
3737 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3738 This is less likely to overflow, and avoids undefined behavior if
3739 overflow does occur. All callers changed. Use strtoul to scan
3740 for the unsigned long integer.
3741 (pint2hrstr): Simplify and tune code slightly.
3742 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3743
3744 * scroll.c (do_scrolling): Work around GCC bug 48228.
3745 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3746
3747 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3748 This also avoids a warning with gcc -Wstrict-overflow.
3749 (validate_x_resource_name): Simplify count usage.
3750 This also avoids a warning with gcc -Wstrict-overflow.
3751
3752 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3753 fail (Bug#8306).
3754
3755 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3756
3757 * process.c (Fmake_network_process): Use socklen_t, not int,
3758 where POSIX says socklen_t is required in portable programs.
3759 This fixes a porting bug on hosts like 64-bit HP-UX, where
3760 socklen_t is wider than int (Bug#8277).
3761 (Fmake_network_process, server_accept_connection):
3762 (wait_reading_process_output, read_process_output):
3763 Likewise.
3764
3765 * process.c: Rename or move locals to avoid shadowing.
3766 (list_processes_1, Fmake_network_process):
3767 (read_process_output_error_handler, exec_sentinel_error_handler):
3768 Rename or move locals.
3769 (Fmake_network_process): Define label "retry_connect" only if needed.
3770 (Fnetwork_interface_info): Fix pointer signedness.
3771 (process_send_signal): Add cast to avoid pointer signedness problem.
3772 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3773 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3774
3775 Make tparam.h and terminfo.c consistent.
3776 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3777 Include tparam.h instead, since it declares them.
3778 * cm.h (PC): Remove extern decl; tparam.h now does this.
3779 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3780 * terminfo.c: Include tparam.h, to check interfaces.
3781 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3782 (tparam): Adjust signature to match interface in tparam.h;
3783 this removes some undefined behavior. Check that outstring and len
3784 are zero, which they always are with Emacs.
3785 * tparam.h (PC, BC, UP): New extern decls.
3786
3787 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3788 (xftfont_open): Rename locals to avoid shadowing.
3789
3790 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3791 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3792 (OTF_TAG_SYM): Omit macro if not needed.
3793 (ftfont_list): Remove unused local.
3794 (get_adstyle_property, ftfont_pattern_entity):
3795 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3796 Rename locals to avoid shadowing.
3797
3798 * xfont.c (xfont_list_family): Mark var as initialized.
3799
3800 * xml.c (make_dom): Now static.
3801
3802 * composite.c (composition_compute_stop_pos): Rename local to
3803 avoid shadowing.
3804 (composition_reseat_it): Remove unused locals.
3805 (find_automatic_composition, composition_adjust_point): Likewise.
3806 (composition_update_it): Mark var as initialized.
3807 (find_automatic_composition): Mark vars as initialized,
3808 with a FIXME (Bug#8290).
3809
3810 character.h: Rename locals to avoid shadowing.
3811 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3812 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3813 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3814 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3815 to avoid shadowing.
3816
3817 * textprop.c (property_change_between_p): Remove; unused.
3818
3819 * intervals.c (interval_start_pos): Now static.
3820
3821 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3822
3823 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3824 Rename locals to avoid shadowing.
3825
3826 * sound.c (wav_play, au_play, Fplay_sound_internal):
3827 Fix pointer signedness.
3828 (alsa_choose_format): Remove unused local var.
3829 (wav_play): Initialize a variable to 0, to prevent undefined
3830 behavior (Bug#8278).
3831
3832 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3833
3834 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3835
3836 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3837 clobbering (Bug#8298).
3838 * sysdep.c (sys_subshell): Likewise.
3839 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3840
3841 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3842 This should get cleaned up, so that child_setup has the
3843 same signature on all platforms.
3844
3845 * callproc.c (call_process_cleanup): Now static.
3846 (relocate_fd): Rename locals to avoid shadowing.
3847
3848 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3849
3850 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3851 not to be necessary, and produces flickering.
3852
3853 2011-03-20 Glenn Morris <rgm@gnu.org>
3854
3855 * config.in: Remove file.
3856
3857 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3858
3859 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3860 are now in src/globals.h.
3861 (syms_of_minibuf): Remove spurious & from previous change.
3862
3863 2011-03-20 Leo <sdl.web@gmail.com>
3864
3865 * minibuf.c (completing-read-function): New variable.
3866 (completing-read-default): Rename from completing-read.
3867 (completing-read): Call completing-read-function.
3868
3869 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3870
3871 * xfaces.c (Fx_load_color_file):
3872 Read color file from absolute filename (bug#8250).
3873
3874 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3875
3876 * makefile.w32-in: Update dependencies.
3877
3878 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3879
3880 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3881
3882 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3883
3884 Fix more problems found by GCC 4.5.2's static checks.
3885
3886 * process.c (make_serial_process_unwind, send_process_trap):
3887 (sigchld_handler): Now static.
3888
3889 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3890 That way, the code declares only the vars that it needs.
3891 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3892 * s/cygwin.h (PTY_ITERATION): Likewise.
3893 * s/darwin.h (PTY_ITERATION): Likewise.
3894 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3895
3896 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3897 * process.c (allocate_pty): Don't declare stb unless it's needed.
3898
3899 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3900 (CONSTANTLIM): Remove; unused.
3901 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3902 Define only if needed.
3903
3904 * unexelf.c (unexec): Name an expression,
3905 to avoid gcc -Wbad-function-cast warning.
3906 Use a different way to cause a compilation error if anyone uses
3907 n rather than nn, a way that does not involve shadowing.
3908 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3909
3910 * deps.mk (unexalpha.o): Remove; unused.
3911
3912 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3913 * unexec.h: New file.
3914 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3915 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3916 Depend on unexec.h.
3917 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3918 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3919 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3920 Change as necessary to match prototype in unexec.h.
3921
3922 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3923 shadowing.
3924 (back_comment, skip_chars): Mark vars as initialized.
3925
3926 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3927 Rename locals to avoid shadowing.
3928
3929 * lread.c (read1): Rewrite so as not to use empty "else".
3930 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3931
3932 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3933
3934 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3935 warning when compiling print.c.
3936
3937 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3938 instead of using an uninitialized var.
3939 (font_sort_entities): Mark var as initialized.
3940
3941 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3942
3943 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3944 pointers to constants.
3945 (font_parse_fcname): Remove unused vars.
3946 (font_delete_unmatched): Now static.
3947 (font_get_spec): Remove; unused.
3948 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3949 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3950 Rename or move locals to avoid shadowing.
3951
3952 * fns.c (require_nesting_list, require_unwind): Now static.
3953 (Ffillarray): Rename locals to avoid shadowing.
3954
3955 * floatfns.c (domain_error2): Define only if needed.
3956 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3957
3958 * alloc.c (mark_backtrace): Move decl from here ...
3959 * lisp.h: ... to here, so that it can be checked.
3960
3961 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3962 (Fdefvar): Rewrite so as not to use empty "else".
3963 (lisp_indirect_variable): Name an expression,
3964 to avoid gcc -Wbad-function-cast warning.
3965 (Fdefvar): Rename locals to avoid shadowing.
3966
3967 * callint.c (quotify_arg, quotify_args): Now static.
3968 (Fcall_interactively): Rename locals to avoid shadowing.
3969 Use const pointer when appropriate.
3970
3971 * lisp.h (get_system_name, get_operating_system_release):
3972 Move decls here, to check interfaces.
3973 * process.c (get_operating_system_release): Move decl to lisp.h.
3974 * xrdb.c (get_system_name): Likewise.
3975 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3976 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3977 some of which prompt warnings from gcc -Wbad-function-cast.
3978 (Fformat_time_string, Fencode_time, Finsert_char):
3979 (Ftranslate_region_internal, Fformat):
3980 Rename or remove local vars to avoid shadowing.
3981 (Ftranslate_region_internal): Mark var as initialized.
3982
3983 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3984 avoid shadowing.
3985
3986 * lisp.h (eassert): Check that the argument compiles, even if
3987 ENABLE_CHECKING is not defined.
3988
3989 * data.c (Findirect_variable): Name an expression, to avoid
3990 gcc -Wbad-function-cast warning.
3991 (default_value, arithcompare, arith_driver, arith_error): Now static.
3992 (store_symval_forwarding): Rename local to avoid shadowing.
3993 (Fmake_variable_buffer_local, Fmake_local_variable):
3994 Mark variables as initialized.
3995 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3996
3997 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3998 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3999 Rename locals to avoid shadowing.
4000 (mark_stack): Move local variables into the #ifdef region where
4001 they're used.
4002 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4003 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4004 needed otherwise.
4005 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4006 (GC_STRING_CHARS): Remove; not used.
4007 (Fmemory_limit): Cast sbrk's returned value to char *.
4008
4009 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4010 avoids undefined behavior in theory.
4011
4012 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4013
4014 Use functions, not macros, for up- and down-casing (Bug#8254).
4015 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4016 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4017 to use the following functions instead of these macros.
4018 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4019 EMACS_INT, since callers assume the returned value fits in int.
4020 (upcase1): Likewise, for UPCASE_TABLE.
4021 (uppercasep, lowercasep, upcase): New static inline functions.
4022 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4023 the race-condition problem in the old DOWNCASE.
4024
4025 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4026 Rename locals to avoid shadowing.
4027 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4028 (regex_compile, re_search_2, re_match_2_internal):
4029 Remove unused local vars.
4030 (FREE_VAR): Rewrite so as not to use empty "else",
4031 which gcc can warn about.
4032 (regex_compile, re_match_2_internal): Mark locals as initialized.
4033 (RETALLOC_IF): Define only if needed.
4034 (WORDCHAR_P): Likewise. This one is never needed, but is used
4035 only in a comment talking about a compiler bug, so put inside
4036 the #if 0 of that comment.
4037 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4038 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4039 Remove; unused.
4040
4041 * search.c (boyer_moore): Rename locals to avoid shadowing.
4042 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4043 (PREV_CHAR_BOUNDARY): Likewise.
4044
4045 * search.c (simple_search): Remove unused var.
4046
4047 * dired.c (compile_pattern): Move decl from here ...
4048 * lisp.h: ... to here, so that it can be checked.
4049 (struct re_registers): New forward decl.
4050
4051 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4052
4053 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4054 All uses changed.
4055 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4056 Rename locals to avoid shadowing.
4057 (Fvertical_motion): Mark locals as initialized.
4058
4059 * casefiddle.c (casify_object, casify_region): Now static.
4060 (casify_region): Mark local as initialized.
4061
4062 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4063
4064 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4065 New macros, so that the caller can use some names other than
4066 gcpro1, gcpro2, etc.
4067 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4068 of the new macros.
4069 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4070 argument, for consistency with GCPRO2_VAR, etc: it is now the
4071 prefix of the variable, not the variable itself. All uses
4072 changed.
4073 * dired.c (directory_files_internal, file_name_completion):
4074 Rename locals to avoid shadowing.
4075
4076 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4077 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4078 dired.c's scmp function, had undefined behavior.
4079 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4080 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4081 * buffer.h: ... to here, because these macros use current_buffer,
4082 and the new implementation with inline functions needs to have
4083 current_buffer in scope now, rather than later when the macros
4084 are used.
4085 (downcase, upcase1): New static inline functions.
4086 (DOWNCASE, UPCASE1): Reimplement using these functions.
4087 This avoids undefined behavior in expressions like
4088 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4089 from race conditions in accessing the global variables
4090 case_temp1 and case_temp2.
4091 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4092 * lisp.h (case_temp1, case_temp2): Remove their decls.
4093 * character.h (ASCII_CHAR_P): Move from here ...
4094 * lisp.h: ... to here, so that the inline functions mentioned
4095 above can use them.
4096
4097 * dired.c (directory_files_internal_unwind): Now static.
4098
4099 * fileio.c (file_name_as_directory, directory_file_name):
4100 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4101 Now static.
4102 (file_name_as_directory): Use const pointers when appropriate.
4103 (Fexpand_file_name): Likewise. In particular, newdir might
4104 point at constant storage, so make it a const pointer.
4105 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4106 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4107 signedness issues.
4108 (Fset_file_times, Finsert_file_contents, auto_save_error):
4109 Rename locals to avoid shadowing.
4110
4111 * minibuf.c (choose_minibuf_frame_1): Now static.
4112 (Ftry_completion, Fall_completions): Rename or remove locals
4113 to avoid shadowing.
4114
4115 * marker.c (bytepos_to_charpos): Remove; unused.
4116
4117 * lisp.h (verify_bytepos, count_markers): New decls,
4118 so that gcc does not warn that these functions aren't declared.
4119
4120 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4121 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4122 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4123 (copy_text): Remove unused local var.
4124
4125 * filelock.c (within_one_second): Now static.
4126 (lock_file_1): Rename local to avoid shadowing.
4127
4128 * buffer.c (fix_overlays_before): Mark locals as initialized.
4129 (fix_start_end_in_overlays): Likewise. This function should be
4130 simplified by using pointers-to-pointers, but that's a different
4131 matter.
4132 (switch_to_buffer_1): Now static.
4133 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4134 (report_overlay_modification): Rename locals to avoid shadowing.
4135
4136 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4137 Fix pointer signedness issue.
4138 (sys_subshell): Mark local as volatile if checking for lint,
4139 to suppress a gcc -Wclobbered warning that does not seem to be right.
4140 (MAXPATHLEN): Define only if needed.
4141
4142 * process.c (serial_open, serial_configure): Move decls from here ...
4143 * systty.h: ... to here, so that they can be checked.
4144
4145 * fns.c (get_random, seed_random): Move extern decls from here ...
4146 * lisp.h: ... to here, so that they can be checked.
4147
4148 * sysdep.c (reset_io): Now static.
4149 (wait_for_termination_signal): Remove; unused.
4150
4151 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4152 (copy_keymap_item, append_key, push_text_char_description):
4153 Now static.
4154 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4155 (DENSE_TABLE_SIZE): Remove; unused.
4156 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4157 (describe_map_tree):
4158 Rename locals to avoid shadowing.
4159
4160 * keyboard.c: Declare functions static if they are not used elsewhere.
4161 (echo_char, echo_dash, cmd_error, top_level_2):
4162 (poll_for_input, handle_async_input): Now static.
4163 (read_char, kbd_buffer_get_event, make_lispy_position):
4164 (make_lispy_event, make_lispy_movement, apply_modifiers):
4165 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4166 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4167 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4168 (read_key_sequence, read_char): Mark locals as initialized.
4169 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4170
4171 * keyboard.h (make_ctrl_char): New decl.
4172 (mark_kboards): Move decl here ...
4173 * alloc.c (mark_kboards): ... from here.
4174
4175 * lisp.h (force_auto_save_soon): New decl.
4176
4177 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4178 (DEFINE_DUMMY_FUNCTION): New macro.
4179 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4180 Use it.
4181 (main): Add casts to avoid warnings
4182 if GCC considers string literals to be constants.
4183
4184 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4185
4186 * dbusbind.c: Pointer signedness fixes.
4187 (xd_signature, xd_append_arg, xd_initialize):
4188 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4189 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4190 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4191 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4192
4193 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4194 if GCC considers string literals to be constants.
4195 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4196
4197 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4198
4199 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4200 (print_preprocess, print_object): New macro to fix last change.
4201
4202 * print.c (print_preprocess): Don't forget font objects.
4203
4204 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4205
4206 * emacs.c (USAGE3): Doc fixes.
4207
4208 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4209
4210 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4211 structure.
4212
4213 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4214
4215 * lisp.h (VWindow_system, Qfile_name_history):
4216 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4217 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4218 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4219
4220 * w32select.c: Don't #include "keyboard.h".
4221 (run_protected): Add extern declaration for waiting_for_input.
4222
4223 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4224 * w32console.c (detect_input_pending, read_input_pending)
4225 (encode_terminal_code):
4226 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4227 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4228 (w32_system_caret_y, Qfile_name_history):
4229 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4230 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4231 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4232 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4233 * w32proc.c (Qlocal, report_file_error):
4234 * w32term.c (Vwindow_system, updating_frame):
4235 * w32uniscribe.c (initialized, uniscribe_font_driver):
4236 Remove unneeded extern declarations.
4237
4238 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4239
4240 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4241
4242 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4243
4244 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4245 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4246 These macros can no longer be used for assignment.
4247
4248 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4249 Assign struct members directly, instead of using BUF_BEGV etc.
4250 (record_buffer_markers, fetch_buffer_markers): New functions for
4251 recording and fetching special buffer markers.
4252 (set_buffer_internal_1, set_buffer_temp): Use them.
4253
4254 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4255
4256 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4257
4258 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4259 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4260
4261 * xdisp.c (hscroll_window_tree):
4262 (reconsider_clip_changes): Use PT instead of BUF_PT.
4263
4264 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4265
4266 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4267 $(EMACS_ROOT)/lib/intprops.h.
4268
4269 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4270
4271 Fix more problems found by GCC 4.5.2's static checks.
4272
4273 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4274 to unsigned char * to avoid compiler diagnostic.
4275 (xg_free_frame_widgets): Make it clear that a local variable is
4276 needed only if USE_GTK_TOOLTIP.
4277 (gdk_window_get_screen): Make it clear that this macro is needed
4278 only if USE_GTK_TOOLTIP.
4279 (int_gtk_range_get_value): New function, which avoids a diagnostic
4280 from gcc -Wbad-function-cast.
4281 (xg_set_toolkit_scroll_bar_thumb): Use it.
4282 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4283 diagnostic from gcc -Wbad-function-cast.
4284 (get_utf8_string, xg_get_file_with_chooser):
4285 Rename locals to avoid shadowing.
4286 (create_dialog): Move locals to avoid shadowing.
4287
4288 * xgselect.c (xg_select): Remove unused var.
4289
4290 * image.c (four_corners_best): Mark locals as initialized.
4291 (gif_load): Initialize transparent_p to zero (Bug#8238).
4292 Mark another local as initialized.
4293 (my_png_error, my_error_exit): Mark with NO_RETURN.
4294
4295 * image.c (clear_image_cache): Now static.
4296 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4297 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4298 (x_edge_detection): Remove unnecessary cast that
4299 gcc -Wbad-function-cast diagnoses.
4300 (gif_load): Fix pointer signedness.
4301 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4302 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4303
4304 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4305
4306 Improve quality of tests for time stamp overflow.
4307 For example, without this patch (encode-time 0 0 0 1 1
4308 1152921504606846976) returns the obviously-bogus value (-948597
4309 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4310 reports time overflow. See
4311 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4312 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4313 * editfns.c: Include limits.h and intprops.h.
4314 (TIME_T_MIN, TIME_T_MAX): New macros.
4315 (time_overflow): Move earlier, to before first use.
4316 (hi_time, lo_time): New functions, for an accurate test for
4317 out-of-range times.
4318 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4319 (Fget_internal_run_time): Don't assume time_t fits in int.
4320 (make_time): Use list2 instead of Fcons twice.
4321 (Fdecode_time): More accurate test for out-of-range times.
4322 (check_tm_member): New function.
4323 (Fencode_time): Use it, to test for out-of-range times.
4324 (lisp_time_argument): Don't rely on undefined left-shift and
4325 right-shift behavior when checking for time stamp overflow.
4326
4327 * editfns.c (time_overflow): New function, refactoring common code.
4328 (Fformat_time_string, Fdecode_time, Fencode_time):
4329 (Fcurrent_time_string): Use it.
4330
4331 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4332 * dired.c (make_time): Move to ...
4333 * editfns.c (make_time): ... here.
4334 * systime.h: Note the move.
4335
4336 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4337
4338 * fringe.c (update_window_fringes): Remove unused variables.
4339
4340 * unexmacosx.c (copy_data_segment): Also copy __got section.
4341 (Bug#8223)
4342
4343 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4344
4345 * termcap.c [MSDOS]: Include "msdos.h".
4346 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4347 Constify `char *' arguments and their references according to
4348 prototypes in tparam.h.
4349
4350 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4351
4352 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4353 Adapt all references accordingly.
4354
4355 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4356
4357 2011-03-11 Tom Tromey <tromey@redhat.com>
4358
4359 * buffer.c (syms_of_buffer): Remove obsolete comment.
4360
4361 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4362
4363 * termhooks.h (encode_terminal_code): Declare prototype.
4364
4365 * msdos.c (encode_terminal_code): Don't declare prototype.
4366
4367 * term.c (encode_terminal_code): Now external again, used by
4368 w32console.c and msdos.c.
4369
4370 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4371 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4372
4373 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4374
4375 Fix some minor problems found by GCC 4.5.2's static checks.
4376
4377 * fringe.c (update_window_fringes): Mark locals as initialized
4378 (Bug#8227).
4379 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4380
4381 * alloc.c (mark_fringe_data): Move decl from here ...
4382 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4383 to check its interface.
4384 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4385
4386 * fontset.c (free_realized_fontset): Now static.
4387 (Fset_fontset_font): Rename local to avoid shadowing.
4388 (fontset_font): Mark local as initialized.
4389 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4390
4391 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4392
4393 * xselect.c (x_disown_buffer_selections): Remove; not used.
4394 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4395 (x_own_selection, Fx_disown_selection_internal): Rename locals
4396 to avoid shadowing.
4397 (x_handle_dnd_message): Remove local to avoid shadowing.
4398
4399 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4400 so that the caller can use some name other than gcpro1.
4401 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4402 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4403 (Fx_backspace_delete_keys_p):
4404 Use them to avoid shadowing, and rename vars to avoid shadowing.
4405 (x_decode_color, x_set_name, x_window): Now static.
4406 (Fx_create_frame): Add braces to silence GCC warning.
4407 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4408 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4409 Remove unused locals.
4410 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4411 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4412 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4413 macros.
4414
4415 * xterm.h (x_mouse_leave): New decl.
4416
4417 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4418 Remove unused functions.
4419 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4420 (x_calc_absolute_position): Now static.
4421 (XTread_socket): Don't define label "out" unless it's used.
4422 Don't declare local "event" unless it's used.
4423 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4424 unless they are used.
4425 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4426 (x_fatal_error_signal): Remove; not used.
4427 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4428 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4429 (x_error_catcher, x_connection_closed, x_error_handler):
4430 (x_error_quitter, xembed_send_message, x_iconify_frame):
4431 (my_log_handler): Rename locals to avoid shadowing.
4432 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4433 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4434
4435 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4436 Rename or move locals to avoid shadowing.
4437 (tty_defined_color, merge_face_heights): Now static.
4438 (free_realized_faces_for_fontset): Remove; not used.
4439 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4440 does not deduce is never used uninitialized.
4441 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4442 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4443
4444 * terminal.c (store_terminal_param): Now static.
4445
4446 * xmenu.c (menu_highlight_callback): Now static.
4447 (set_frame_menubar): Remove unused local.
4448 (xmenu_show): Rename parameter to avoid shadowing.
4449 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4450 since they might point to immutable storage.
4451 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4452 since it's unused otherwise.
4453
4454 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4455 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4456 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4457 avoids a gcc -Wuninitialized diagnostic.
4458 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4459 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4460 does not deduce are never used uninitialized.
4461
4462 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4463
4464 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4465 * window.c (window_loop, size_window):
4466 (run_window_configuration_change_hook, enlarge_window): Likewise.
4467
4468 * window.c (display_buffer): Now static.
4469 (size_window): Mark variables that gcc -Wuninitialized
4470 does not deduce are never used uninitialized.
4471 * window.h (check_all_windows): New decl, to forestall
4472 gcc -Wmissing-prototypes diagnostic.
4473 * dispextern.h (bidi_dump_cached_states): Likewise.
4474
4475 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4476 shadowing.
4477 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4478 Include <limits.h>.
4479 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4480 and to avoid gcc -Wuninitialized warning.
4481 (load_charset_map): Mark variables that gcc -Wuninitialized
4482 does not deduce are never used uninitialized.
4483 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4484
4485 * coding.c (coding_set_source, coding_set_destination):
4486 Use "else { /* comment */ }" rather than "else /* comment */;"
4487 for clarity, and to avoid gcc -Wempty-body warning.
4488 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4489 a block, when the outer 'i' will do.
4490 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4491 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4492 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4493 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4494 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4495 Rename locals to avoid shadowing.
4496 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4497 * coding.c (emacs_mule_char, encode_invocation_designation):
4498 Now static, since they're not used elsewhere.
4499 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4500 (decode_coding_object, encode_coding_object, detect_coding_system):
4501 (decode_coding_emacs_mule): Mark variables that gcc
4502 -Wuninitialized does not deduce are never used uninitialized.
4503 (detect_coding_iso_2022): Initialize a local variable that might
4504 be used uninitialized. Leave a FIXME because it's not clear that
4505 this initialization is needed. (Bug#8211)
4506 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4507 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4508 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4509 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4510 Remove unused macros.
4511
4512 * category.c (hash_get_category_set): Remove unused local var.
4513 (copy_category_table): Now static, since it's not used elsewhere.
4514 * character.c (string_count_byte8): Likewise.
4515
4516 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4517 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4518
4519 * chartab.c (copy_sub_char_table): Now static, since it's not used
4520 elsewhere.
4521 (sub_char_table_ref_and_range, char_table_ref_and_range):
4522 Rename locals to avoid shadowing.
4523 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4524
4525 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4526 (BIDI_BOB): Remove unused macro.
4527
4528 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4529 deduce are never used uninitialized.
4530 * term.c (encode_terminal_code): Likewise.
4531
4532 * term.c (encode_terminal_code): Now static. Remove unused local.
4533
4534 * tparam.h: New file.
4535 * term.c, tparam.h: Include it.
4536 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4537 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4538 Move these decls to tparam.h, and make them agree with what
4539 is actually in tparam.c. The previous trick of using incompatible
4540 decls in different modules does not conform to the C standard.
4541 All callers of tparam changed to use tparam's actual API.
4542 * tparam.c (tparam1, tparam, tgoto):
4543 Use const pointers where appropriate.
4544
4545 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4546 * cm.h (struct cm): Likewise.
4547 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4548 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4549 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4550 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4551 (turn_on_face, init_tty): Likewise.
4552 * termchar.h (struct tty_display_info): Likewise.
4553
4554 * term.c (term_mouse_position): Rename local to avoid shadowing.
4555
4556 * alloc.c (mark_ttys): Move decl from here ...
4557 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4558
4559 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4560
4561 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4562
4563 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4564
4565 * search.c (compile_pattern_1): Remove argument regp, unused since
4566 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4567 (compile_pattern): Don't pass it.
4568
4569 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4570
4571 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4572 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4573 for ! HAVE_GTK3.
4574 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4575
4576 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4577
4578 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4579 gdk_window_get_screen, gdk_window_get_geometry,
4580 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4581 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4582 (xg_get_pixbuf_from_pixmap): New function.
4583 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4584 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4585 Call xg_get_pixbuf_from_pixmap instead of
4586 gdk_pixbuf_get_from_drawable.
4587 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4588 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4589 (xg_check_special_colors): Use GtkStyleContext and its functions
4590 for HAVE_GTK3.
4591 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4592 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4593 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4594 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4595 Call gtk_widget_get_preferred_size.
4596 (xg_frame_resized): gdk_window_get_geometry only takes 5
4597 parameters.
4598 (xg_win_to_widget, xg_event_is_for_menubar):
4599 Call gdk_x11_window_lookup_for_display.
4600 (xg_set_widget_bg): New function.
4601 (delete_cb): New function.
4602 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4603 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4604 (xg_set_background_color): Call xg_set_widget_bg.
4605 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4606 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4607 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4608 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4609 if ! HAVE_GTK3.
4610 (update_frame_tool_bar): Call gtk_widget_hide.
4611 (xg_initialize): Use GDK_KEY_g.
4612
4613 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4614 if ! HAVE_GTK3
4615 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4616
4617 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4618 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4619 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4620
4621 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4622
4623 * w32xfns.c (select_palette): Check success of RealizePalette against
4624 GDI_ERROR, not zero.
4625
4626 See ChangeLog.11 for earlier changes.
4627
4628 ;; Local Variables:
4629 ;; coding: utf-8
4630 ;; End:
4631
4632 Copyright (C) 2011 Free Software Foundation, Inc.
4633
4634 This file is part of GNU Emacs.
4635
4636 GNU Emacs is free software: you can redistribute it and/or modify
4637 it under the terms of the GNU General Public License as published by
4638 the Free Software Foundation, either version 3 of the License, or
4639 (at your option) any later version.
4640
4641 GNU Emacs is distributed in the hope that it will be useful,
4642 but WITHOUT ANY WARRANTY; without even the implied warranty of
4643 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4644 GNU General Public License for more details.
4645
4646 You should have received a copy of the GNU General Public License
4647 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.