Clarify that \= only quotes the next character
[bpt/emacs.git] / src / ChangeLog
1 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4 quotes the next character, and doesn't affect other longer
5 sequences (bug#8935).
6
7 * lread.c (syms_of_lread): Clarify that is isn't only
8 `eval-buffer' and `eval-defun' that's affected by
9 `lexical-binding' (bug#8460).
10
11 2011-07-15 Eli Zaretskii <eliz@gnu.org>
12
13 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
14 bidi redisplay when a line includes both an image and is
15 truncated.
16
17 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
18
19 Fix minor problems found by static checking.
20 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
21 (elsz): Now a signed constant, not a size_t var. We prefer signed
22 types to unsigned, to avoid integer comparison confusion. Without
23 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
24 "cannot optimize loop, the loop counter may overflow", a symptom
25 of the confusion.
26 * indent.c (Fvertical_motion): Mark locals as initialized.
27 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
28
29 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
30
31 * search.c (Fre_search_backward): Mention `case-fold-search' in
32 all the re_search_* functions (bug#8138).
33
34 * keyboard.c (Fopen_dribble_file): Document when the file is
35 closed (bug#8056).
36
37 2011-07-14 Eli Zaretskii <eliz@gnu.org>
38
39 * bidi.c (bidi_dump_cached_states): Fix format of displaying
40 bidi_cache_idx.
41
42 Support bidi reordering of display and overlay strings.
43 * xdisp.c (compute_display_string_pos)
44 (compute_display_string_end): Accept additional argument STRING.
45 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
46 (reseat_to_string): Initialize bidi_it->string.s and
47 bidi_it->string.schars.
48 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
49 NULL (avoids a crash in bidi_paragraph_init). Initialize
50 itb.string.lstring.
51 (init_iterator): Call bidi_init_it only of a valid
52 buffer position was specified. Initialize paragraph_embedding to
53 L2R.
54 (reseat_to_string): Initialize the bidi iterator.
55 (display_string): If we need to ignore text properties of
56 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
57 original value of -1 will not work with bidi.)
58 (compute_display_string_pos): First arg is now struct
59 `text_pos *'; all callers changed. Support display properties on
60 Lisp strings.
61 (compute_display_string_end): Support display properties on Lisp
62 strings.
63 (init_iterator, reseat_1, reseat_to_string): Initialize the
64 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
65 when iterating on a string not from display properties).
66 (compute_display_string_pos, compute_display_string_end): Fix
67 calculation of the object to scan. Fixes an error when using
68 arrow keys.
69 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
70 base_level_stop; instead, set base_level_stop to BEGV. Fixes
71 crashes in vertical-motion.
72 (next_element_from_buffer): Improve commentary for when
73 the iterator is before prev_stop.
74 (init_iterator): Initialize bidi_p from the default value of
75 bidi-display-reordering, not from buffer-local value. Use the
76 buffer-local value only if initializing for buffer iteration.
77 (handle_invisible_prop): Support invisible properties on strings
78 that are being bidi-reordered.
79 (set_iterator_to_next): Support bidi reordering of C strings and
80 Lisp strings.
81 (next_element_from_string): Support bidi reordering of Lisp
82 strings.
83 (handle_stop_backwards): Support Lisp strings as well.
84 (display_string): Support display of R2L glyph rows. Use
85 IT_STRING_CHARPOS when displaying from a Lisp string.
86 (init_iterator): Don't initialize it->bidi_p for strings
87 here.
88 (reseat_to_string): Initialize it->bidi_p for strings here.
89 (next_element_from_string, next_element_from_c_string)
90 (next_element_from_buffer): Add xassert's for correspondence
91 between IT's object being iterated and it->bidi_it.string
92 structure.
93 (face_before_or_after_it_pos): Support bidi iteration.
94 (next_element_from_c_string): Handle the case of the first string
95 character that is not the first one in the visual order.
96 (get_visually_first_element): New function, refactored from common
97 parts of next_element_from_buffer, next_element_from_string, and
98 next_element_from_c_string.
99 (tool_bar_lines_needed, redisplay_tool_bar)
100 (display_menu_bar): Force left-to-right direction. Add a FIXME
101 comment for making that be controlled by a user option.
102 (push_it, pop_it): Save and restore the state of the
103 bidi iterator. Save and restore the bidi_p flag.
104 (pop_it): Iterate out of display property for string iteration as
105 well.
106 (iterate_out_of_display_property): Support iteration over strings.
107 (handle_single_display_spec): Set up it->bidi_it for iteration
108 over a display string, and call bidi_init_it.
109 (handle_single_display_spec, next_overlay_string)
110 (get_overlay_strings_1, push_display_prop): Set up the bidi
111 iterator for displaying display or overlay strings.
112 (forward_to_next_line_start): Don't use the shortcut if
113 bidi-iterating.
114 (back_to_previous_visible_line_start): If handle_display_prop
115 pushed the iterator stack, restore the internal state of the bidi
116 iterator by calling bidi_pop_it same number of times.
117 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
118 and we are bidi-iterating, don't decrement the iterator position;
119 instead, set the first_elt flag in the bidi iterator, to produce
120 the same effect.
121 (reseat_1): Remove redundant setting of string_from_display_prop_p.
122 (push_display_prop): xassert that we are iterating a buffer.
123 (push_it, pop_it): Save and restore paragraph_embedding member.
124 (handle_single_display_spec, next_overlay_string)
125 (get_overlay_strings_1, reseat_1, reseat_to_string)
126 (push_display_prop): Set up the `unibyte' member of bidi_it.string
127 correctly. Don't assume unibyte strings are not bidi-reordered.
128 (compute_display_string_pos)
129 (compute_display_string_end): Fix handling the case of C string.
130 (push_it, pop_it): Save and restore from_disp_prop_p.
131 (handle_single_display_spec, push_display_prop): Set the
132 from_disp_prop_p flag.
133 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
134 (pop_it): Call iterate_out_of_display_property only if we are
135 popping after iteration over a string that came from a display
136 property. Fix a typo in popping stretch info. Add an assertion
137 for verifying that the iterator position is in sync with the bidi
138 iterator.
139 (handle_single_display_spec, get_overlay_strings_1)
140 (push_display_prop): Fix initialization of paragraph direction for
141 string when that of the parent object is not yet determined.
142 (reseat_1): Call bidi_init_it to resync the bidi
143 iterator with IT's position. (Bug#7616)
144 (find_row_edges): If ROW->start.pos gives position
145 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
146 (handle_stop, back_to_previous_visible_line_start, reseat_1):
147 Reset the from_disp_prop_p flag.
148 (SAVE_IT, RESTORE_IT): New macros.
149 (pos_visible_p, face_before_or_after_it_pos)
150 (back_to_previous_visible_line_start)
151 (move_it_in_display_line_to, move_it_in_display_line)
152 (move_it_to, move_it_vertically_backward, move_it_by_lines)
153 (try_scrolling, redisplay_window, display_line): Use them when
154 saving a temporary copy of the iterator and restoring it back.
155 (back_to_previous_visible_line_start, reseat_1)
156 (init_iterator): Empty the bidi cache "stack".
157 (move_it_in_display_line_to): If iterator ended up at
158 EOL, but we never saw any buffer positions smaller than
159 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
160 motion in bidi-reordered lines.
161 (move_it_in_display_line_to): Record prev_method and prev_pos
162 immediately before the call to set_iterator_to_next. Fixes cursor
163 motion in bidi-reordered lines with stretch glyphs and strings
164 displayed in margins. (Bug#8133) (Bug#8867)
165 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
166 TO_CHARPOS.
167 (pos_visible_p): Support positions in bidi-reordered lines. Save
168 and restore bidi cache.
169
170 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
171 (bidi_paragraph_info): Delete unused struct.
172 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
173 (bidi_cache_start): New variable.
174 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
175 to zero.
176 (bidi_cache_fetch_state, bidi_cache_search)
177 (bidi_cache_find_level_change, bidi_cache_iterator_state)
178 (bidi_cache_find, bidi_peek_at_next_level)
179 (bidi_level_of_next_char, bidi_find_other_level_edge)
180 (bidi_move_to_visually_next): Compare cache index with
181 bidi_cache_start rather than with zero.
182 (bidi_fetch_char): Accept new argument STRING; all callers
183 changed. Support iteration over a string. Support strings with
184 display properties. Support unibyte strings. Fix the type of
185 `len' according to what STRING_CHAR_AND_LENGTH expects.
186 (bidi_paragraph_init, bidi_resolve_explicit_1)
187 (bidi_resolve_explicit, bidi_resolve_weak)
188 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
189 iteration over a string.
190 (bidi_set_sor_type, bidi_resolve_explicit_1)
191 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
192 can now be zero (for strings); special values 0 and -1 were
193 changed to -1 and -2, respectively.
194 (bidi_char_at_pos): New function.
195 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
196 Call it instead of FETCH_MULTIBYTE_CHAR.
197 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
198 initialized to valid values.
199 (bidi_init_it): Don't initialize charpos and bytepos with invalid
200 values.
201 (bidi_level_of_next_char): Allow the sentinel "position" to pass
202 the test for valid cached positions. Fix the logic for looking up
203 the sentinel state in the cache. GCPRO the Lisp string we are
204 iterating.
205 (bidi_push_it, bidi_pop_it): New functions.
206 (bidi_initialize): Initialize the bidi cache start stack pointer.
207 (bidi_cache_ensure_space): New function, refactored from part of
208 bidi_cache_iterator_state. Don't assume the required size is just
209 one BIDI_CACHE_CHUNK away.
210 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
211 (bidi_count_bytes, bidi_char_at_pos): New functions.
212 (bidi_cache_search): Don't assume bidi_cache_last_idx is
213 always valid if bidi_cache_idx is valid.
214 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
215 is valid if it's going to be used.
216 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
217 (bidi_cache_fetch_state, bidi_cache_search)
218 (bidi_cache_find_level_change, bidi_cache_ensure_space)
219 (bidi_cache_iterator_state, bidi_cache_find)
220 (bidi_find_other_level_edge, bidi_cache_start_stack): All
221 variables related to cache indices are now EMACS_INT.
222
223 * dispextern.h (struct bidi_string_data): New structure.
224 (struct bidi_it): New member `string'. Make flag members be 1-bit
225 fields, and put them last in the struct.
226 (compute_display_string_pos, compute_display_string_end): Update
227 prototypes.
228 (bidi_push_it, bidi_pop_it): Add prototypes.
229 (struct iterator_stack_entry): New members bidi_p,
230 paragraph_embedding, and from_disp_prop_p.
231 (struct it): Member bidi_p is now a bit field 1 bit wide.
232 (bidi_shelve_cache, bidi_unshelve_cache): Declare
233 prototypes.
234
235 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
236 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
237 and vector-like objects.
238
239 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
240 cache around display iteration.
241
242 * window.c (Fwindow_end, window_scroll_pixel_based)
243 (displayed_window_lines, Frecenter): Save and restore the bidi
244 cache around display iteration.
245
246 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
247
248 * editfns.c (Fdelete_region): Clarify the use of the named
249 parameters (bug#6788).
250
251 2011-07-14 Martin Rudalics <rudalics@gmx.at>
252
253 * indent.c (Fvertical_motion): Set and restore w->pointm when
254 saving and restoring the window's buffer (Bug#9006).
255
256 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
257
258 * editfns.c (Fstring_to_char): Clarify just what is returned
259 (bug#6576). Text by Eli Zaretskii.
260
261 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
262
263 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
264
265 2011-07-13 Eli Zaretskii <eliz@gnu.org>
266
267 * buffer.c (mmap_find): Fix a typo.
268
269 2011-07-13 Johan Bockgård <bojohan@gnu.org>
270
271 Fix execution of x selection hooks.
272 * xselect.c (Qx_lost_selection_functions)
273 (Qx_sent_selection_functions): New vars.
274 (syms_of_xselect): DEFSYM them.
275 (x_handle_selection_request): Pass Qx_sent_selection_functions
276 rather than Vx_sent_selection_functions to Frun_hook_with_args.
277 (x_handle_selection_clear,x_clear_frame_selections):
278 Pass Qx_lost_selection_functions rather than
279 Vx_lost_selection_functions to Frun_hook_with_args.
280
281 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
282
283 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
284 The old code sometimes used this field without initializing it.
285
286 * alloc.c (gc_sweep): Don't read past end of array.
287 In theory, the old code could also have corrupted Emacs internals,
288 though it'd be very unlikely.
289
290 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
291
292 * character.c (Fcharacterp): Don't advertise optional ignored
293 argument. (Bug#4026)
294
295 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
296
297 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
298 key" (bug#4257).
299
300 * window.c (Fset_window_start): Doc fix (bug#4199).
301 (Fset_window_hscroll): Ditto.
302
303 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
304
305 Fix minor new problems caught by GCC 4.6.1.
306 * term.c (init_tty): Remove unused local.
307 * xsettings.c (store_monospaced_changed): Define this function only
308 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
309 not used otherwise.
310
311 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
312
313 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
314
315 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
316
317 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
318 are the mini-buffer and the echo area (bug#3320).
319
320 * term.c (init_tty): Remove support for supdup, c10 and perq
321 terminals, which are no longer supported (bug#1482).
322
323 2011-07-10 Johan Bockgård <bojohan@gnu.org>
324
325 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
326
327 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
328
329 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
330 for non-popups (Bug#3642).
331
332 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
333
334 * alloc.c (reset_malloc_hooks): Protoize.
335 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
336 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
337 * cm.c (losecursor): Likewise.
338 * data.c (fmod): Likewise.
339 * dispnew.c (swap_glyphs_in_rows): Likewise.
340 * emacs.c (memory_warning_signal): Likewise.
341 * floatfns.c (float_error): Likewise.
342 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
343 (otf_open, font_otf_capability, generate_otf_features)
344 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
345 Likewise.
346 * image.c (pbm_read_file): Likewise.
347 * indent.c (string_display_width): Likewise.
348 * intervals.c (check_for_interval, search_for_interval)
349 (inc_interval_count, count_intervals, root_interval)
350 (adjust_intervals_for_insertion, make_new_interval): Likewise.
351 * lread.c (defalias): Likewise.
352 * ralloc.c (r_alloc_check): Likewise.
353 * regex.c (set_image_of_range_1, set_image_of_range)
354 (regex_grow_registers): Likewise.
355 * sysdep.c (strerror): Likewise.
356 * termcap.c (valid_filename_p, tprint, main): Likewise.
357 * tparam.c (main): Likewise.
358 * unexhp9k800.c (run_time_remap, save_data_space)
359 (update_file_ptrs, read_header, write_header, calculate_checksum)
360 (copy_file, copy_rest, display_header): Likewise.
361 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
362 Likewise.
363 * xdisp.c (check_it): Likewise.
364 * xfaces.c (register_color, unregister_color, unregister_colors):
365 Likewise.
366 * xfns.c (print_fontset_result): Likewise.
367 * xrdb.c (member, fatal, main): Likewise.
368
369 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
370
371 Fix minor problems found by static checking (Bug#9031).
372 * chartab.c (char_table_set_range, map_sub_char_table):
373 Remove unused locals.
374 (uniprop_table): Now static.
375 * composite.c (_work_char): Remove unused static var.
376
377 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
378
379 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
380
381 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
382
383 * gtkutil.c (qttip_cb): Remove code without function.
384
385 2011-07-09 Eli Zaretskii <eliz@gnu.org>
386
387 * w32.c (pthread_sigmask): New stub.
388
389 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
390
391 Use pthread_sigmask, not sigprocmask (Bug#9010).
392 sigprocmask is portable only for single-threaded applications, and
393 Emacs can be multi-threaded when it uses GTK.
394 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
395 (LIBES): Use it.
396 * callproc.c (Fcall_process):
397 * process.c (create_process):
398 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
399 Use pthread_sigmask, not sigprocmask.
400
401 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
402
403 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
404 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
405 wrong (Bug#8591).
406
407 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
408
409 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
410 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
411 (xg_hide_tooltip): Fix comment.
412
413 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
414 in registerServicesMenuSendTypes.
415 (validRequestorForSendType): Don't check ns_return_types.
416
417 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
418 ns_return_type.
419
420 2011-07-08 Jason Rumney <jasonr@gnu.org>
421
422 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
423 frame struct members of non-existent frames (Bug#6284).
424
425 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
426
427 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
428 variable firstTime not needed on OSX >= 10.6.
429 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
430 >= 10.5. Use setKnobProportion, setDoubleValue.
431
432 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
433 (MAC_OS_X_VERSION_10_5): Define if not defined.
434 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
435 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
436 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
437
438 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
439 cString and lossyCString on OSX >= 10.4
440
441 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
442 sizeToFit on OSX >= 10.2.
443
444 * nsimage.m (allocInitFromFile): Don't use deprecated method
445 bestRepresentationForDevice on OSX >= 10.6.
446
447 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
448 to avoid warning.
449
450 * emacs.c: Declare unexec_init_emacs_zone.
451
452 * nsgui.h: Fix compiler warning about gnulib redefining verify.
453
454 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
455
456 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
457 on svcsMenu (Bug#8842).
458
459 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
460 ns_return_types.
461 (Fns_list_services): Just return Qnil on 10.6, code not working there.
462
463 * nsterm.m (QUTF8_STRING): Declare.
464 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
465 (validRequestorForSendType): Return type is (id).
466 Change indexOfObjectIdenticalTo to indexOfObject.
467 Check if we have local selection before returning self (Bug#8842).
468 (writeSelectionToPasteboard): Put local selection into paste board
469 if we have a local selection (Bug#8842).
470 (syms_of_nsterm): DEFSYM QUTF8_STRING.
471
472 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
473 (ns_get_local_selection): Declare.
474
475 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
476
477 * keymap.c (describe_map_tree): Don't insert a double newline at
478 the end of the buffer (bug#1169) and return whether we inserted
479 something.
480
481 * callint.c (Fcall_interactively): Change "reading args" to
482 "providing args" to try to clarify what it does (bug#1010).
483
484 2011-07-07 Kenichi Handa <handa@m17n.org>
485
486 * composite.c (composition_compute_stop_pos): Ignore a static
487 composition starting before CHARPOS (Bug#8915).
488
489 * xdisp.c (handle_composition_prop): Likewise.
490
491 2011-07-07 Eli Zaretskii <eliz@gnu.org>
492
493 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
494 (Bug#9015)
495
496 2011-07-07 Kenichi Handa <handa@m17n.org>
497
498 * character.h (unicode_category_t): New enum type.
499
500 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
501 (Qchar_code_property_table): New variable.
502 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
503 (UNIPROP_COMPRESSED_FORM_P): New macros.
504 (char_table_ascii): Uncompress the compressed values.
505 (sub_char_table_ref): New arg is_uniprop. Callers changed.
506 Uncompress the compressed values.
507 (sub_char_table_ref_and_range): Likewise.
508 (char_table_ref_and_range): Uncompress the compressed values.
509 (sub_char_table_set): New arg is_uniprop. Callers changed.
510 Uncompress the compressed values.
511 (sub_char_table_set_range): Args changed. Callers changed.
512 (char_table_set_range): Adjuted for the above change.
513 (map_sub_char_table): Delete args default_val and parent. Add arg
514 top. Give decoded values to a Lisp function.
515 (map_char_table): Adjusted for the above change. Give decoded
516 values to a Lisp function. Gcpro more variables.
517 (uniprop_table_uncompress)
518 (uniprop_decode_value_run_length): New functions.
519 (uniprop_decoder, uniprop_decoder_count): New variables.
520 (uniprop_get_decoder, uniprop_encode_value_character)
521 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
522 New functions.
523 (uniprop_encoder, uniprop_encoder_count): New variables.
524 (uniprop_get_encoder, uniprop_table)
525 (Funicode_property_table_internal, Fget_unicode_property_internal)
526 (Fput_unicode_property_internal): New functions.
527 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
528 Sunicode_property_table_internal, Sget_unicode_property_internal,
529 and Sput_unicode_property_internal. Defvar_lisp
530 char-code-property-alist.
531
532 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
533 Vunicode_category_table.
534
535 * font.c (font_range): Adjusted for the change of
536 Vunicode_category_table.
537
538 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
539
540 * m/iris4d.h: Remove file, move contents ...
541 * s/irix6-5.h: ... here.
542
543 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
544
545 Remove unportable assumption about struct layout (Bug#8884).
546 * alloc.c (mark_buffer):
547 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
548 (clone_per_buffer_values): Don't assume that
549 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
550 This isn't true in general, and it's particularly not true
551 if Emacs is configured with --with-wide-int.
552 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
553 New macros, used in the buffer.c change.
554
555 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
556
557 * xsettings.c: Use both GConf and GSettings if both are available.
558 (store_config_changed_event): Add comment.
559 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
560 (store_tool_bar_style_changed): New functions.
561 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
562 (struct xsettings): Move font inside HAVE_XFT.
563 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
564 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
565 Move inside HAVE_XFT.
566 (something_changed_gsettingsCB): Renamed from something_changedCB.
567 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
568 also.
569 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
570 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
571 (something_changed_gconfCB): Renamed from something_changedCB.
572 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
573 (parse_settings): Move check for font inside HAVE_XFT.
574 (read_settings, apply_xft_settings): Add comment.
575 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
576 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
577 call store_font_name_changed.
578 (xft_settings_event): Add comment.
579 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
580 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
581 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
582 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
583 (xsettings_initialize): Call init_gsettings last.
584 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
585 comment.
586
587 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
588
589 Random fixes. E.g., (random) never returned negative values.
590 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
591 subseconds part to the entropy, as that's a bit more random.
592 Prefer signed to unsigned, since the signedness doesn't matter and
593 in general we prefer signed. When given a limit, use a
594 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
595 latter isn't right if USE_2_TAGS_FOR_INTS.
596 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
597 not 0..VALMASK. Don't discard "excess" bits that random () returns.
598
599 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
600
601 * textprop.c (text_property_stickiness):
602 Obey Vtext_property_default_nonsticky.
603 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
604 * w32fns.c (syms_of_w32fns):
605 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
606
607 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
608
609 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
610 This is more efficient than Ffile_directory_p and avoids a minor race.
611
612 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
613
614 * buffer.c (Foverlay_put): Say what the return value is
615 (bug#7835).
616
617 * fileio.c (barf_or_query_if_file_exists): Check first if the file
618 is a directory before asking whether to use the file name
619 (bug#7564).
620 (barf_or_query_if_file_exists): Make the "File is a directory"
621 error be more correct.
622
623 * fns.c (Frequire): Remove the mention of the .gz files, since
624 that's installation-specific, but keep the mention of
625 `get-load-suffixes'.
626
627 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
628
629 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
630 Report string overflow if the output is too long.
631
632 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
633
634 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
635 (syms_of_gnutls): Remove duplicate DEFSYM for
636 Qgnutls_bootprop_verify_hostname_error, an error for
637 Qgnutls_bootprop_verify_error (which is no longer used).
638
639 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
640 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
641 Also (re)move comments that are misplaced or no longer relevant.
642
643 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
644
645 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
646
647 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
648
649 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
650 and background color parameters if they have been changed.
651
652 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
653
654 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
655
656 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
657
658 * xsettings.c (SYSTEM_FONT): Define only when used.
659 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
660
661 * keymap.c (access_keymap_1): Now static.
662
663 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
664
665 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
666 leave any prefix arg for the up event (Bug#1586).
667
668 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
669
670 * lread.c (syms_of_lread): Mention single symbols defined by
671 `defvar' or `defconst' (bug#7154).
672
673 * fns.c (Frequire): Mention .el.gz files (bug#7314).
674 (Frequire): Mention get-load-suffixes.
675
676 2011-07-02 Martin Rudalics <rudalics@gmx.at>
677
678 * window.h (window): Remove clone_number slot.
679 * window.c (Fwindow_clone_number, Fset_window_clone_number):
680 Remove.
681 (make_parent_window, make_window, saved_window)
682 (Fset_window_configuration, save_window_save): Don't deal with
683 clone numbers.
684 * buffer.c (Qclone_number): Remove declaration.
685 (sort_overlays, overlay_strings): Don't deal with clone numbers.
686
687 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
688
689 Add multiple inheritance to keymaps.
690 * keymap.c (Fmake_composed_keymap): New function.
691 (Fset_keymap_parent): Simplify.
692 (fix_submap_inheritance): Remove.
693 (access_keymap_1): New function extracted from access_keymap to handle
694 embedded parents and handle lists of maps.
695 (access_keymap): Use it.
696 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
697 (Fcopy_keymap): Handle embedded parents.
698 (Fcommand_remapping, define_as_prefix): Simplify.
699 (Fkey_binding): Simplify.
700 (syms_of_keymap): Move minibuffer-local-completion-map,
701 minibuffer-local-filename-completion-map,
702 minibuffer-local-must-match-map, and
703 minibuffer-local-filename-must-match-map to Elisp.
704 (syms_of_keymap): Defsubr make-composed-keymap.
705 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
706 (parse_menu_item): Trivial simplification.
707
708 2011-07-01 Glenn Morris <rgm@gnu.org>
709
710 * Makefile.in (SETTINGS_LIBS): Fix typo.
711
712 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
713
714 * coding.c (Fencode_coding_string): Record the last coding system
715 used, as the function doc string says (bug#8738).
716
717 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
718
719 * xsettings.c (store_monospaced_changed): Take new font as arg and
720 check for change against current_mono_font.
721 (EMACS_TYPE_SETTINGS): Remove this and related defines.
722 (emacs_settings_constructor, emacs_settings_get_property)
723 (emacs_settings_set_property, emacs_settings_class_init)
724 (emacs_settings_init, gsettings_obj): Remove.
725 (something_changedCB): New function for HAVE_GSETTINGS.
726 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
727 with value as argument.
728 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
729 g_settings_new (Bug#8967). Do not create gsettings_obj.
730 Remove calls to g_settings_bind. Connect something_changedCB to
731 "changed".
732
733 * xgselect.c: Add defined (HAVE_GSETTINGS).
734 (xgselect_initialize): Ditto.
735
736 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
737 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
738 xg_select.
739
740 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
741
742 * eval.c (struct backtrace): Simplify and port the data structure.
743 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
744 signed bit field, as this assumption is not portable and it makes
745 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
746 "char debug_on_exit : 1" as this is not portable either; instead,
747 use the portable "unsigned int debug_on_exit : 1". Remove unused
748 member evalargs. Remove obsolete comments about cc bombing out.
749
750 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
751
752 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
753 Let HAVE_GSETTINGS override HAVE_GCONF.
754 (store_monospaced_changed): New function.
755 (EMACS_SETTINGS): A new type derived from GObject to handle
756 GSettings notifications.
757 (emacs_settings_constructor, emacs_settings_get_property)
758 (emacs_settings_set_property, emacs_settings_class_init):
759 New functions.
760 (gsettings_client, gsettings_obj): New variables.
761 (GSETTINGS_SCHEMA): New define.
762 (something_changedCB): Call store_monospaced_changed.
763 (init_gsettings): New function.
764 (xsettings_initialize): Call init_gsettings.
765 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
766 to NULL.
767
768 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
769 GCONF_CFLAGS/LIBS.
770
771 2011-06-29 Martin Rudalics <rudalics@gmx.at>
772
773 * window.c (resize_root_window, grow_mini_window)
774 (shrink_mini_window): Rename Qresize_root_window to
775 Qwindow_resize_root_window and Qresize_root_window_vertically to
776 Qwindow_resize_root_window_vertically.
777
778 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
779
780 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
781
782 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
783
784 * makefile.w32-in: Redesign dependencies so they reflect more
785 clearly which files are directly included by each source file,
786 and not through other includes.
787
788 2011-06-27 Martin Rudalics <rudalics@gmx.at>
789
790 * buffer.c (Qclone_number): Declare static and DEFSYM it.
791 (sort_overlays, overlay_strings): When an overlay's clone number
792 matches the window's clone number process the overlay even if
793 the overlay's window property doesn't match the current window.
794
795 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
796 (Fwindow_hchild): Rename to Fwindow_left_child.
797 (Fwindow_next): Rename to Fwindow_next_sibling.
798 (Fwindow_prev): Rename to Fwindow_prev_sibling.
799 (resize_window_check): Rename to window_resize_check.
800 (resize_window_apply): Rename to window_resize_apply.
801 (Fresize_window_apply): Rename to Fwindow_resize_apply.
802 (Fdelete_other_windows_internal, resize_frame_windows)
803 (Fsplit_window_internal, Fdelete_window_internal)
804 (grow_mini_window, shrink_mini_window)
805 (Fresize_mini_window_internal): Fix callers accordingly.
806
807 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
808
809 * emacsgtkfixed.h: State that this is only used with Gtk+3.
810 (emacs_fixed_set_min_size): Remove.
811 (emacs_fixed_new): Take frame as argument.
812
813 * emacsgtkfixed.c: State that this is only used with Gtk+3.
814 (_EmacsFixedPrivate): Remove minwidth/height.
815 Add struct frame *f.
816 (emacs_fixed_init): Initialize priv->f.
817 (get_parent_class, emacs_fixed_set_min_size): Remove.
818 (emacs_fixed_new): Set priv->f to argument.
819 (emacs_fixed_get_preferred_width)
820 (emacs_fixed_get_preferred_height): Use min_width/height from
821 frames size_hint to set minimum and natural (Bug#8919).
822 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
823 and use min_width/height from frames size_hint to set
824 min_width/height (Bug#8919).
825
826 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
827 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
828 Fix indentation.
829
830 2011-06-26 Eli Zaretskii <eliz@gnu.org>
831
832 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
833 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
834 called at ZV.
835
836 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
837
838 * process.c (wait_reading_process_output): Bypass select if
839 waiting for a cell while ignoring keyboard input, and input is
840 pending. Suggested by Jan Djärv (Bug#8869).
841
842 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
843
844 Use gnulib's dup2 module instead of rolling our own.
845 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
846
847 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
848
849 * dispnew.c (scrolling_window): Before scrolling, turn off a
850 mouse-highlight in the window being scrolled.
851
852 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
853
854 Move DEFSYM to lisp.h and use everywhere.
855
856 * character.h (DEFSYM): Move declaration...
857 * lisp.h (DEFSYM): ...here.
858
859 * gnutls.c:
860 * minibuf.c:
861 * w32menu.c:
862 * w32proc.c:
863 * w32select.c: Don't include character.h.
864
865 * alloc.c (syms_of_alloc):
866 * buffer.c (syms_of_buffer):
867 * bytecode.c (syms_of_bytecode):
868 * callint.c (syms_of_callint):
869 * casefiddle.c (syms_of_casefiddle):
870 * casetab.c (init_casetab_once):
871 * category.c (init_category_once, syms_of_category):
872 * ccl.c (syms_of_ccl):
873 * cmds.c (syms_of_cmds):
874 * composite.c (syms_of_composite):
875 * dbusbind.c (syms_of_dbusbind):
876 * dired.c (syms_of_dired):
877 * dispnew.c (syms_of_display):
878 * doc.c (syms_of_doc):
879 * editfns.c (syms_of_editfns):
880 * emacs.c (syms_of_emacs):
881 * eval.c (syms_of_eval):
882 * fileio.c (syms_of_fileio):
883 * fns.c (syms_of_fns):
884 * frame.c (syms_of_frame):
885 * fringe.c (syms_of_fringe):
886 * insdel.c (syms_of_insdel):
887 * keymap.c (syms_of_keymap):
888 * lread.c (init_obarray, syms_of_lread):
889 * macros.c (syms_of_macros):
890 * msdos.c (syms_of_msdos):
891 * print.c (syms_of_print):
892 * process.c (syms_of_process):
893 * search.c (syms_of_search):
894 * sound.c (syms_of_sound):
895 * syntax.c (init_syntax_once, syms_of_syntax):
896 * terminal.c (syms_of_terminal):
897 * textprop.c (syms_of_textprop):
898 * undo.c (syms_of_undo):
899 * w32.c (globals_of_w32):
900 * window.c (syms_of_window):
901 * xdisp.c (syms_of_xdisp):
902 * xfaces.c (syms_of_xfaces):
903 * xfns.c (syms_of_xfns):
904 * xmenu.c (syms_of_xmenu):
905 * xsettings.c (syms_of_xsettings):
906 * xterm.c (syms_of_xterm): Use DEFSYM.
907
908 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
909
910 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
911
912 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
913
914 Integer and buffer overflow fixes (Bug#8873).
915
916 * print.c (printchar, strout): Check for string overflow.
917 (PRINTPREPARE, printchar, strout):
918 Don't set size unless allocation succeeds.
919
920 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
921 for sizes. Check for string overflow more accurately.
922 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
923
924 * macros.c: Integer and buffer overflow fixes.
925 * keyboard.h (struct keyboard.kbd_macro_bufsize):
926 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
927 Use ptrdiff_t, not int, for sizes.
928 Don't increment bufsize until after realloc succeeds.
929 Check for size-calculation overflow.
930 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
931
932 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
933
934 * lread.c: Integer overflow fixes.
935 (read_integer): Radix is now EMACS_INT, not int,
936 to improve quality of diagnostics for out-of-range radices.
937 Calculate buffer size correctly for out-of-range radices.
938 (read1): Check for integer overflow in radices, and in
939 read-circle numbers.
940 (read_escape): Avoid int overflow.
941 (Fload, openp, read_buffer_size, read1)
942 (substitute_object_recurse, read_vector, read_list, map_obarray):
943 Use ptrdiff_t, not int, for sizes.
944 (read1): Use EMACS_INT, not int, for sizes.
945 Check for size overflow.
946
947 * image.c (cache_image): Check for size arithmetic overflow.
948
949 * lread.c: Integer overflow issues.
950 (saved_doc_string_size, saved_doc_string_length)
951 (prev_saved_doc_string_size, prev_saved_doc_string_length):
952 Now ptrdiff_t, not int.
953 (read1): Don't assume doc string length fits in int. Check for
954 out-of-range doc string lengths.
955 (read_list): Don't assume file position fits in int.
956 (read_escape): Check for hex character overflow.
957
958 2011-06-22 Leo Liu <sdl.web@gmail.com>
959
960 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
961 Move to minibuffer.el.
962
963 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
964
965 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
966 The following patches are for when GLYPH_DEBUG && !XASSERT.
967 * dispextern.h (trace_redisplay_p, dump_glyph_string):
968 * dispnew.c (flush_stdout):
969 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
970 Mark as externally visible.
971 * dispnew.c (check_window_matrix_pointers): Now static.
972 * dispnew.c (window_to_frame_vpos):
973 * xfns.c (unwind_create_frame):
974 * xterm.c (x_check_font): Remove unused local.
975 * scroll.c (CHECK_BOUNDS):
976 * xfaces.c (cache_fache): Rename local to avoid shadowing.
977 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
978 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
979 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
980 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
981 Now static.
982 (debug_method_add): Use va_list and vsprintf rather than relying
983 on undefined behavior with wrong number of arguments.
984 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
985 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
986 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
987 since we're not interested in debugging glyphs with old libraries.
988 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
989 GCC 4.6.0's static checking.
990
991 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
992
993 Integer overflow and signedness fixes (Bug#8873).
994 A few related buffer overrun fixes, too.
995
996 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
997
998 * dispextern.h (struct face.stipple):
999 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1000 (x_bitmap_mask, x_allocate_bitmap_record)
1001 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1002 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1003 (x_create_bitmap_from_xpm_data):
1004 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1005 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1006 (.bitmaps_last):
1007 * xfaces.c (load_pixmap):
1008 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1009 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1010 (.bitmaps_last, struct x_output.icon_bitmap):
1011 Use ptrdiff_t, not int, for bitmap indexes.
1012 (x_allocate_bitmap_record): Check for size overflow.
1013 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1014
1015 Use ptrdiff_t, not int, for overlay counts.
1016 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1017 * editfns.c (overlays_around, get_pos_property):
1018 * textprop.c (get_char_property_and_overlay):
1019 * xdisp.c (next_overlay_change, note_mouse_highlight):
1020 * xfaces.c (face_at_buffer_position):
1021 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1022 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1023 (Fnext_overlay_change, Fprevious_overlay_change)
1024 (mouse_face_overlay_overlaps, Foverlays_in):
1025 Use ptrdiff_t, not int, for sizes.
1026 (overlays_at, overlays_in): Check for size-calculation overflow.
1027
1028 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1029
1030 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1031 (x_session_initialize): Do not assume string length fits in int.
1032
1033 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1034 This is unlikely, but can occur if DPI is outlandish.
1035
1036 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1037 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1038
1039 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1040 * xrdb.c (magic_file_p, search_magic_path):
1041 Omit last arg SUFFIX; it was always 0. All callers changed.
1042 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1043
1044 * xfont.c (xfont_match): Avoid need for strlen.
1045
1046 * xfns.c: Don't assume strlen fits in int.
1047 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1048
1049 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1050 not unsigned long, as we prefer signed integers. All callers changed.
1051 Detect integer overflow in repeat count.
1052 (message_dolog): Don't assume print length fits in 39 bytes.
1053 (display_mode_element): Don't assume strlen fits in int.
1054
1055 * termcap.c: Don't assume sizes fit in int and never overflow.
1056 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1057 (gobble_line): Check for size-calculation overflow.
1058
1059 * minibuf.c (Fread_buffer):
1060 * lread.c (intern, intern_c_string):
1061 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1062 Don't assume string length fits in int.
1063
1064 * keyboard.c (parse_tool_bar_item):
1065 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1066
1067 * font.c: Don't assume string length fits in int.
1068 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1069 Use ptrdiff_t, not int.
1070 (font_intern_prop): Don't assume string length fits in int.
1071 Don't assume integer property fits in fixnum.
1072 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1073
1074 * filelock.c: Fix some buffer overrun and integer overflow issues.
1075 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1076 Reformulate so as not to need the command string.
1077 Invoke gzip -cd rather than gunzip, as it's more portable.
1078 (lock_info_type, lock_file_1, lock_file):
1079 Don't assume pid_t and time_t fit in unsigned long.
1080 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1081 (current_lock_owner): Prefer signed type for sizes.
1082 Use memcpy, not strncpy, where memcpy is what is really wanted.
1083 Don't assume (via atoi) that time_t and pid_t fit in int.
1084 Check for time_t and/or pid_t out of range, e.g., via a network share.
1085 Don't alloca where an auto var works fine.
1086
1087 * fileio.c: Fix some integer overflow issues.
1088 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1089 Don't assume string length fits in int.
1090 (directory_file_name): Don't assume string length fits in long.
1091 (make_temp_name): Don't assume pid fits in int, or that its print
1092 length is less than 20.
1093
1094 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1095
1096 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1097
1098 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1099
1100 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1101 We prefer signed integers, even for size calculations.
1102
1103 * emacs.c: Don't assume string length fits in 'int'.
1104 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1105 (main): Don't invoke strlen when not needed.
1106
1107 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1108 (XD_DEBUG_MESSAGE): Don't waste a byte.
1109
1110 * callproc.c (getenv_internal_1, getenv_internal)
1111 (Fgetenv_internal):
1112 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1113
1114 * lread.c (invalid_syntax): Omit length argument.
1115 All uses changed. This doesn't fix a bug, but it simplifies the
1116 code away from its former Hollerith-constant appearance, and it's
1117 one less 'int' to worry about when looking at integer-overflow issues.
1118 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1119
1120 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1121 This didn't break anything, but it didn't help either.
1122 It's confusing to put a bogus integer in a place where the actual
1123 value does not matter.
1124 (LIST_END_P): Remove unused macro and its bogus comment.
1125 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1126
1127 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1128 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1129 implementation.
1130 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1131 We prefer signed types, and the value cannot exceed the EMACS_INT
1132 range anyway (because otherwise the length would not be representable).
1133 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1134 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1135 This avoids a GCC warning when WIDE_EMACS_INT.
1136
1137 * indent.c (sane_tab_width): New function.
1138 (current_column, scan_for_column, Findent_to, position_indentation)
1139 (compute_motion): Use it. This is just for clarity.
1140 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1141
1142 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1143
1144 * lisp.h (lint_assume): New macro.
1145 * composite.c (composition_gstring_put_cache):
1146 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1147
1148 * editfns.c, insdel.c:
1149 Omit unnecessary forward decls, to simplify future changes.
1150
1151 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1152
1153 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1154
1155 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1156 Use much-faster test for byte-length change.
1157 Don't assume string byte-length fits in 'int'.
1158 Check that character arg fits in 'int'.
1159 (mapcar1): Declare byte as byte, for clarity.
1160
1161 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1162
1163 * fns.c (concat): Catch string overflow earlier.
1164 Do not rely on integer wraparound.
1165
1166 * dispextern.h (struct it.overlay_strings_charpos)
1167 (struct it.selective): Now EMACS_INT, not int.
1168 * xdisp.c (forward_to_next_line_start)
1169 (back_to_previous_visible_line_start)
1170 (reseat_at_next_visible_line_start, next_element_from_buffer):
1171 Don't arbitrarily truncate the value of 'selective' to int.
1172
1173 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1174
1175 * composite.c: Don't truncate sizes to 'int'.
1176 (composition_gstring_p, composition_reseat_it)
1177 (composition_adjust_point): Use EMACS_INT, not int.
1178 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1179 not EMACS_UINT, for indexes.
1180
1181 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1182
1183 * buffer.c: Include <verify.h>.
1184 (struct sortvec.priority, struct sortstr.priority):
1185 Now EMACS_INT, not int.
1186 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1187 (struct sortstr.size, record_overlay_string)
1188 (struct sortstrlist.size, struct sortlist.used):
1189 Don't truncate size to int.
1190 (record_overlay_string): Check for size-calculation overflow.
1191 (init_buffer_once): Check at compile-time, not run-time.
1192
1193 2011-06-22 Jim Meyering <meyering@redhat.com>
1194
1195 Don't leak an XBM-image-sized buffer
1196 * image.c (xbm_load): Free the image buffer after using it.
1197
1198 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1199
1200 Port to Sun C.
1201 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1202 that Sun C diagnosed.
1203 * fns.c (secure_hash): Fix pointer signedness issue.
1204 * intervals.c (static_offset_intervals): New function.
1205 (offset_intervals): Use it.
1206
1207 2011-06-21 Leo Liu <sdl.web@gmail.com>
1208
1209 * deps.mk (fns.o):
1210 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1211 sha512.h.
1212
1213 * fns.c (secure_hash): Rename from crypto_hash_function and change
1214 the first arg to accept symbols.
1215 (Fsecure_hash): New primitive.
1216 (syms_of_fns): New symbols.
1217
1218 2011-06-20 Deniz Dogan <deniz@dogan.se>
1219
1220 * process.c (Fset_process_buffer): Clarify return value in
1221 docstring.
1222
1223 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1224
1225 * dispnew.c (add_window_display_history): Use BVAR.
1226
1227 * xdisp.c (debug_method_add): Use BVAR.
1228 (check_window_end, dump_glyph_matrix, dump_glyph)
1229 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1230
1231 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1232 Likewise.
1233
1234 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1235 check till after the cache is created in init_frame_faces.
1236
1237 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1238
1239 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1240
1241 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1242
1243 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1244 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1245 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1246
1247 Improve buffer-overflow checking (Bug#8873).
1248 * fileio.c (Finsert_file_contents):
1249 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1250 Remove the old (too-loose) buffer overflow checks.
1251 They weren't needed, since make_gap checks for buffer overflow.
1252 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1253 The old code merely checked for Emacs fixnum overflow, and relied
1254 on undefined (wraparound) behavior. The new code avoids undefined
1255 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1256
1257 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1258 Tune. Don't use wider integers than needed. Don't use alloca.
1259 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1260
1261 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1262
1263 * insdel.c, lisp.h (buffer_overflow): New function.
1264 (insert_from_buffer_1, replace_range, replace_range_2):
1265 * insdel.c (make_gap_larger):
1266 * editfns.c (Finsert_char):
1267 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1268
1269 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1270
1271 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 Integer overflow and signedness fixes (Bug#8873).
1274
1275 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1276 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1277
1278 * fileio.c: Don't assume EMACS_INT fits in off_t.
1279 (emacs_lseek): New static function.
1280 (Finsert_file_contents, Fwrite_region): Use it.
1281 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1282
1283 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1284
1285 * fns.c: Don't overflow int when computing a list length.
1286 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1287 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1288 truncation on 64-bit hosts. Check for QUIT every
1289 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1290 faster and is responsive enough.
1291 (Flength): Report an error instead of overflowing an integer.
1292 (Fsafe_length): Return a float if the value is not representable
1293 as a fixnum. This shouldn't happen except in contrived situations.
1294 (Fnthcdr, Fsort): Don't assume list length fits in int.
1295 (Fcopy_sequence): Don't assume vector length fits in int.
1296
1297 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1298 (header_size, word_size): New constants.
1299 (allocate_vectorlike): Don't check size overflow here.
1300 (allocate_vector): Check it here instead, since this is the only
1301 caller of allocate_vectorlike that could cause overflow.
1302 Check that the new vector's length is representable as a fixnum.
1303
1304 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1305 The previous code was bogus. For example, next_almost_prime (32)
1306 returned 39, which is undesirable as it is a multiple of 3; and
1307 next_almost_prime (24) returned 25, which is a multiple of 5 so
1308 why was the code bothering to check for multiples of 7?
1309
1310 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1311
1312 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1313
1314 Variadic C functions now count arguments with ptrdiff_t.
1315 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1316 Back then I didn't know that the Emacs coding style prefers signed int.
1317 Also, in the meantime I found a few more instances where arguments
1318 were being counted with int, which may truncate counts on 64-bit
1319 machines, or EMACS_INT, which may be unnecessarily wide.
1320 * lisp.h (struct Lisp_Subr.function.aMANY)
1321 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1322 Arg counts are now ptrdiff_t, not size_t.
1323 All variadic functions and their callers changed accordingly.
1324 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1325 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1326 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1327 * callint.c (Fcall_interactively): Check arg count for overflow,
1328 to avoid potential buffer overrun. Use signed char, not 'int',
1329 for 'varies' array, so that we needn't bother to check its size
1330 calculation for overflow.
1331 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1332 * eval.c (apply_lambda):
1333 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1334 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1335 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1336
1337 * callint.c (Fcall_interactively): Don't use index var as event count.
1338
1339 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1340 * mem-limits.h (SIZE): Remove; no longer used.
1341
1342 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1343
1344 Remove unnecessary casts.
1345 * xterm.c (x_term_init):
1346 * xfns.c (x_set_border_pixel):
1347 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1348 These aren't needed now that we assume ANSI C.
1349
1350 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1351 It's more likely to cause problems (due to unsigned overflow)
1352 than to cure them.
1353
1354 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1355
1356 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1357
1358 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1359
1360 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1361
1362 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1363
1364 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1365
1366 GLYPH_CODE_FACE returns EMACS_INT, not int.
1367 * dispextern.h (merge_faces):
1368 * xfaces.c (merge_faces):
1369 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1370 Don't assume EMACS_INT fits in int.
1371
1372 * character.h (CHAR_VALID_P): Remove unused parameter.
1373 * fontset.c, lisp.h, xdisp.c: All uses changed.
1374
1375 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1376
1377 * fns.c (concat): Minor tuning based on overflow analysis.
1378 This doesn't fix any bugs. Use int to hold character, instead
1379 of constantly refetching from Emacs object. Use XFASTINT, not
1380 XINT, for value known to be a character. Don't bother comparing
1381 a single byte to 0400, as it's always less.
1382
1383 * floatfns.c (Fexpt):
1384 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1385
1386 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1387 for characters.
1388
1389 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1390
1391 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1392 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1393 incorrectly succeed when S was a string, because 4294967386 was
1394 truncated before it was used.
1395
1396 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1397 Otherwise, an out-of-range integer could cause undefined behavior
1398 on a 64-bit host.
1399
1400 * composite.c: Use int, not EMACS_INT, for characters.
1401 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1402 EMACS_INT, for values that are known to be in character range.
1403 This doesn't fix any bugs but is the usual style inside Emacs and
1404 may generate better code on 32-bit machines.
1405
1406 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1407 This is for reasons similar to the recent CHAR_STRING fix.
1408 * charset.c (Fencode_char): Check that character arg is actually
1409 a character. Pass an int to ENCODE_CHAR.
1410 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1411 wider than 'int', as a compile-time check to prevent future regressions
1412 in this area.
1413
1414 * character.c (char_string): Remove unnecessary casts.
1415
1416 Make sure a 64-bit char is never passed to CHAR_STRING.
1417 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1418 by silently ignoring the top 32 bits, allowing some values
1419 that were far too large to be valid characters.
1420 * character.h: Include <verify.h>.
1421 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1422 arguments are no wider than unsigned, as a compile-time check
1423 to prevent future regressions in this area.
1424 * data.c (Faset):
1425 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1426 (Fsubst_char_in_region):
1427 * fns.c (concat):
1428 * xdisp.c (decode_mode_spec_coding):
1429 Adjust to CHAR_STRING's new requirement.
1430 * editfns.c (Finsert_char, Fsubst_char_in_region):
1431 * fns.c (concat): Check that character args are actually
1432 characters. Without this test, these functions did the wrong
1433 thing with wildly out-of-range values on 64-bit hosts.
1434
1435 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1436 These casts should not be needed on 32-bit hosts, either.
1437 * keyboard.c (read_char):
1438 * lread.c (Fload): Remove casts to unsigned.
1439
1440 * lisp.h (UNSIGNED_CMP): New macro.
1441 This fixes comparison bugs on 64-bit hosts.
1442 (ASCII_CHAR_P): Use it.
1443 * casefiddle.c (casify_object):
1444 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1445 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1446 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1447 * dispextern.h (FACE_FROM_ID):
1448 * keyboard.c (read_char): Use UNSIGNED_CMP.
1449
1450 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1451 not to EMACS_INT, to avoid GCC warning.
1452
1453 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1454
1455 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1456 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1457 isn't needed on 32-bit machines.
1458
1459 * buffer.c (Fgenerate_new_buffer_name):
1460 Use EMACS_INT for count, not int.
1461 (advance_to_char_boundary): Return EMACS_INT, not int.
1462
1463 * data.c (Qcompiled_function): Now static.
1464
1465 * window.c (window_body_lines): Now static.
1466
1467 * image.c (gif_load): Rename local to avoid shadowing.
1468
1469 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1470 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1471 * alloc.c (make_save_value): Integer argument is now of type
1472 ptrdiff_t, not int.
1473 (mark_object): Use ptrdiff_t, not int.
1474 * lisp.h (pD): New macro.
1475 * print.c (print_object): Use it.
1476
1477 * alloc.c: Use EMACS_INT, not int, to count objects.
1478 (total_conses, total_markers, total_symbols, total_vector_size)
1479 (total_free_conses, total_free_markers, total_free_symbols)
1480 (total_free_floats, total_floats, total_free_intervals)
1481 (total_intervals, total_strings, total_free_strings):
1482 Now EMACS_INT, not int. All uses changed.
1483 (Fgarbage_collect): Compute overall total using a double, so that
1484 integer overflow is less likely to be a problem. Check for overflow
1485 when converting back to an integer.
1486 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1487 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1488 These were 'int' variables that could overflow on 64-bit hosts;
1489 they were never used, so remove them instead of repairing them.
1490 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1491 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1492 Previously, this ceilinged at INT_MAX, but that doesn't work on
1493 64-bit machines.
1494 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1495
1496 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1497 (allocate_vectorlike): Check for ptrdiff_t overflow.
1498 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1499 when a (possibly-narrower) signed value would do just as well.
1500 We prefer using signed arithmetic, to avoid comparison confusion.
1501
1502 * alloc.c: Catch some string size overflows that we were missing.
1503 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1504 for convenience in STRING_BYTES_MAX.
1505 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1506 The definition here is exact; the one in lisp.h was approximate.
1507 (allocate_string_data): Check for string overflow. This catches
1508 some instances we weren't catching before. Also, it catches
1509 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1510 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1511 and ptrdiff_t and EMACS_INT are both 64 bits.
1512
1513 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1514 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1515 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1516
1517 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1518
1519 * alloc.c (Fmake_string): Check for out-of-range init.
1520
1521 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1522
1523 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1524
1525 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1526
1527 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1528 xg_get_default_scrollbar_width.
1529
1530 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1531 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1532 (style_changed_cb): Call update_theme_scrollbar_width and call
1533 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1534 all frames (Bug#8505).
1535 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1536 Call gtk_window_set_resizable if HAVE_GTK3.
1537 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1538 and height if HAVE_GTK3 (Bug#8505).
1539 (scroll_bar_width_for_theme): New variable.
1540 (update_theme_scrollbar_width): New function.
1541 (xg_get_default_scrollbar_width): Move code to
1542 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1543 (xg_initialize): Call update_theme_scrollbar_width.
1544
1545 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1546
1547 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1548
1549 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1550
1551 * frame.c (make_frame): Call other_buffer_safely instead of
1552 other_buffer.
1553
1554 * window.c (temp_output_buffer_show): Call display_buffer with
1555 second argument Vtemp_buffer_show_specifiers and reset latter
1556 immediately after the call.
1557 (Vtemp_buffer_show_specifiers): New variable.
1558 (auto_window_vscroll_p, next_screen_context_lines)
1559 (Vscroll_preserve_screen_position): Remove leading asterisks from
1560 doc-strings.
1561
1562 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1563
1564 Fix minor problems found by GCC 4.6.0 static checking.
1565 * buffer.c (Qclone_number): Remove for now, as it's unused.
1566 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1567 (record_buffer): Remove unused local.
1568 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1569 (set_frame_buffer_list): Remove; unused.
1570 * frame.h (other_visible_frames): Remove decl.
1571 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1572 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1573 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1574 if HAVE_GPM.
1575 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1576 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1577 Define only if HAVE_GPM.
1578 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1579 (update_hints_inhibit): Remove; never set. All uses removed.
1580 * widgetprv.h (emacsFrameClassRec): Remove decl.
1581 * window.c (delete_deletable_window): Now returns void, since it
1582 wasn't returning anything.
1583 (compare_window_configurations): Remove unused locals.
1584 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1585 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1586 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1587 the same widths as pointers. This follows up on the 2011-05-06 patch.
1588 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1589 * xterm.h: Likewise.
1590 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1591
1592 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1593
1594 * makefile.w32-in: Update dependencies.
1595 (LISP_H): Add lib/intprops.h.
1596
1597 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1598
1599 * image.c (gif_load): Add animation frame delay to the metadata.
1600 (syms_of_image): Use DEFSYM. New symbol `delay'.
1601
1602 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1603
1604 * window.c (delete_deletable_window): Re-add.
1605 (Fset_window_configuration): Rewrite to handle dead buffers and
1606 consequently deletable windows.
1607 (window_tree, Fwindow_tree): Remove. Supply functionality in
1608 window.el.
1609 (compare_window_configurations): Simplify code.
1610
1611 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1612
1613 * image.c (imagemagick_load_image): Fix type mismatch.
1614 (Fimagemagick_types): Likewise.
1615
1616 * window.h (replace_buffer_in_windows): Declare.
1617
1618 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1619
1620 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1621 Qclone_number. Remove external declaration of Qdelete_window.
1622 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1623 code.
1624 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1625 Qbuffer_list_update_hook if allowed.
1626 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1627 buffer list implementation.
1628 (other_buffer_safely): New function.
1629 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1630 calls to replace_buffer_in_windows and
1631 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1632 if allowed.
1633 (record_buffer): Inhibit quitting and rewrite using quittable
1634 functions. Run Qbuffer_list_update_hook if allowed.
1635 (Frecord_buffer, Funrecord_buffer): New functions.
1636 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1637 switch-to-buffer to window.el.
1638 (bury-buffer): Move to window.el.
1639 (Vbuffer_list_update_hook): New variable.
1640
1641 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1642 section.
1643
1644 * window.h (resize_frame_windows): Move up in code.
1645 (Fwindow_frame): Remove EXFUN.
1646 (replace_buffer_in_all_windows): Remove prototype.
1647 (replace_buffer_in_windows_safely): Add prototype.
1648
1649 * window.c: Declare Qdelete_window static again. Move down
1650 declaration of select_count.
1651 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1652 (Fother_window): Move to window.el.
1653 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1654 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1655 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1656 window.el.
1657 (replace_buffer_in_windows): Implement by calling
1658 Qreplace_buffer_in_windows.
1659 (replace_buffer_in_all_windows): Remove with some functionality
1660 moved into replace_buffer_in_windows_safely.
1661 (replace_buffer_in_windows_safely): New function.
1662 (select_window_norecord, select_frame_norecord): Move in front
1663 of run_window_configuration_change_hook. Remove now obsolete
1664 declarations.
1665 (Fset_window_buffer): Rewrite doc-string. Call
1666 Qrecord_window_buffer.
1667 (keys_of_window): Move binding for other-window to window.el.
1668
1669 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1670
1671 * dispextern.h (struct image): Replace data member, whose int_val
1672 and ptr_val fields were not used by anything, with a single
1673 lisp_val object.
1674
1675 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1676 (gif_clear_image, gif_load, imagemagick_load_image)
1677 (gs_clear_image, gs_load): Callers changed.
1678
1679 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1680
1681 * buffer.h: Include <time.h>, for time_t.
1682 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1683
1684 Fix minor problems found by static checking.
1685
1686 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1687
1688 Make identifiers static if they are not used in other modules.
1689 * data.c (Qcompiled_function, Qframe, Qvector):
1690 * image.c (QimageMagick, Qsvg):
1691 * minibuf.c (Qmetadata):
1692 * window.c (resize_window_check, resize_root_window): Now static.
1693 * window.h (resize_window_check, resize_root_window): Remove decls.
1694
1695 * window.c (window_deletion_count, delete_deletable_window):
1696 Remove; unused.
1697 (window_body_lines): Now static.
1698 (Fdelete_other_windows_internal): Mark vars as initialized.
1699 Make sure 'resize_failed' is initialized.
1700 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1701 (resize_window_apply): Remove unused local.
1702 * window.h (delete_deletable_window): Remove decl.
1703
1704 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1705 (imagemagick_load_image): Fix pointer signedness problem by changing
1706 last arg from unsigned char * to char *. All uses changed.
1707 Also, fix a local for similar reasons.
1708 Remove unused locals. Remove locals to avoid shadowing.
1709 (fn_rsvg_handle_free): Remove; unused.
1710 (svg_load, svg_load_image): Fix pointer signedness problem.
1711 (imagemagick_load_image): Don't use garbage pointer image_wand.
1712
1713 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1714
1715 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1716
1717 * image.c (gif_load): Fix omitted cast error introduced by
1718 2011-06-06 change.
1719
1720 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1721
1722 * window.h (resize_proportionally, orig_total_lines)
1723 (orig_top_line): Remove from window structure.
1724 (set_window_height, set_window_width, change_window_heights)
1725 (Fdelete_window): Remove prototypes.
1726 (resize_frame_windows): Remove duplicate declaration.
1727
1728 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1729
1730 * window.h (resize_frame_windows, resize_window_check)
1731 (delete_deletable_window, resize_root_window)
1732 (resize_frame_windows): Declare prototypes.
1733
1734 * window.c (resize_window_apply): Make definition be "static" to
1735 match the prototype.
1736
1737 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1738
1739 * window.c: Remove declarations of Qwindow_size_fixed,
1740 window_min_size_1, window_min_size_2, window_min_size,
1741 size_window, window_fixed_size_p, enlarge_window, delete_window.
1742 Remove static from declaration of Qdelete_window, it's
1743 temporarily needed by Fbury_buffer.
1744 (replace_window): Don't assign orig_top_line and
1745 orig_total_lines.
1746 (Fdelete_window, delete_window): Remove. Window deletion is
1747 handled by window.el.
1748 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1749 Fdelete_window calls with calls to Qdelete_window.
1750 (Fdelete_other_windows): Remove. Deleting other windows is
1751 handled by window.el.
1752 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1753 handled in window.el.
1754 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1755 Window minimum sizes are handled in window.el.
1756 (shrink_windows, size_window, set_window_height)
1757 (set_window_width, change_window_heights, window_height)
1758 (window_width, CURBEG, CURSIZE, enlarge_window)
1759 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1760 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1761 handled in window.el.
1762 (make_dummy_parent): Rename to make_parent_window and give it a
1763 second argument horflag.
1764 (make_window): Don't set resize_proportionally any more.
1765 (Fsplit_window): Remove. Windows are split in window.el.
1766 (save_restore_action, save_restore_orig_size)
1767 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1768 Resize mini windows in window.el.
1769 (grow_mini_window, shrink_mini_window): Implement by calling
1770 Qresize_root_window_vertically, resize_window_check and
1771 resize_window_apply.
1772 (saved_window, Fset_window_configuration, save_window_save): Do
1773 not handle orig_top_line, orig_total_lines, and
1774 resize_proportionally.
1775 (window_min_height, window_min_width): Move to window.el.
1776 (keys_of_window): Move bindings for delete-other-windows,
1777 split-window, delete-window and enlarge-window to window.el.
1778
1779 * buffer.c: Temporarily extern Qdelete_window.
1780 (Fbury_buffer): Temporarily call Qdelete_window instead of
1781 Fdelete_window (Fbury_buffer will move to window.el soon).
1782
1783 * frame.c (set_menu_bar_lines_1): Remove code handling
1784 orig_top_line and orig_total_lines.
1785
1786 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1787 set_window_height but set heights directly.
1788 (change_frame_size_1): Use resize_frame_windows.
1789
1790 * xdisp.c (init_xdisp): Don't use set_window_height but set
1791 heights directly.
1792
1793 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1794 resize_frame_windows instead of change_window_heights and run
1795 run_window_configuration_change_hook.
1796
1797 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1798 instead of change_window_heights and run
1799 run_window_configuration_change_hook.
1800
1801 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1802
1803 * window.c (replace_window): Rename second argument REPLACEMENT to
1804 NEW. New third argument SETFLAG. Rewrite.
1805 (delete_window, make_dummy_parent): Call replace_window with
1806 third argument 1.
1807 (window_list_1): Move down in code.
1808 (run_window_configuration_change_hook): Move set_buffer part
1809 before select_frame_norecord part in order to unwind correctly.
1810 Rename count1 to count.
1811 (recombine_windows, delete_deletable_window, resize_root_window)
1812 (Fdelete_other_windows_internal)
1813 (Frun_window_configuration_change_hook, make_parent_window)
1814 (resize_window_check, resize_window_apply, Fresize_window_apply)
1815 (resize_frame_windows, Fsplit_window_internal)
1816 (Fdelete_window_internal, Fresize_mini_window_internal): New
1817 functions.
1818 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1819
1820 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1821
1822 * window.h (window): Add some new members to window structure -
1823 normal_lines, normal_cols, new_total, new_normal, clone_number,
1824 splits, nest, prev_buffers, next_buffers.
1825 (WINDOW_TOTAL_SIZE): Move here from window.c.
1826 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1827
1828 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1829 Remove.
1830 (make_dummy_parent): Set new members of windows structure.
1831 (make_window): Move down in code. Handle new members of window
1832 structure.
1833 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1834 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1835 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1836 (Fset_window_prev_buffers, Fwindow_next_buffers)
1837 (Fset_window_next_buffers, Fset_window_clone_number): New
1838 functions.
1839 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1840 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1841 Doc-string fixes.
1842 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1843 Argument WINDOW can be now internal window too.
1844 (Fwindow_use_time): Move up in code.
1845 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1846 Rewrite doc-string.
1847 (Fset_window_configuration, saved_window)
1848 (Fcurrent_window_configuration, save_window_save): Handle new
1849 members of window structure.
1850 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1851 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1852 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1853 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1854 Qget_mru_window, Qresize_root_window,
1855 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1856 Qauto_buffer_name; staticpro them.
1857
1858 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1859
1860 * window.c (Fwindow_total_size, Fwindow_left_column)
1861 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1862 (Fwindow_list_1): New functions.
1863 (window_box_text_cols): Replace with window_body_cols.
1864 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1865 window_body_cols instead of window_box_text_cols.
1866 (delete_window, Fset_window_configuration): Call
1867 delete_all_subwindows with window as argument.
1868 (delete_all_subwindows): Take a window as argument and not a
1869 structure. Rewrite.
1870 (window_loop): Remove handling of GET_LRU_WINDOW and
1871 GET_LARGEST_WINDOW.
1872 (Fget_lru_window, Fget_largest_window): Move to window.el.
1873
1874 * window.h: Extern window_body_cols instead of
1875 window_box_text_cols. delete_all_subwindows now takes a
1876 Lisp_Object as argument.
1877
1878 * indent.c (compute_motion, Fcompute_motion): Use
1879 window_body_cols instead of window_box_text_cols.
1880
1881 * frame.c (delete_frame): Call delete_all_subwindows with root
1882 window as argument.
1883
1884 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1885
1886 * fns.c (Fputhash): Document return value.
1887
1888 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1889
1890 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1891
1892 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1893
1894 Cons<->int and similar integer overflow fixes (Bug#8794).
1895
1896 Check for overflow when converting integer to cons and back.
1897 * charset.c (Fdefine_charset_internal, Fdecode_char):
1898 Use cons_to_unsigned to catch overflow.
1899 (Fencode_char): Use INTEGER_TO_CONS.
1900 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1901 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1902 * data.c (long_to_cons, cons_to_long): Remove.
1903 (cons_to_unsigned, cons_to_signed): New functions.
1904 These signal an error for invalid or out-of-range values.
1905 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1906 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1907 * font.c (Ffont_variation_glyphs):
1908 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1909 * lisp.h: Include <intprops.h>.
1910 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1911 (cons_to_signed, cons_to_unsigned): New decls.
1912 (long_to_cons, cons_to_long): Remove decls.
1913 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1914 (Fprimitive_undo): Use CONS_TO_INTEGER.
1915 * xfns.c (Fx_window_property): Likewise.
1916 * xselect.c: Include <limits.h>.
1917 (x_own_selection, selection_data_to_lisp_data):
1918 Use INTEGER_TO_CONS.
1919 (x_handle_selection_request, x_handle_selection_clear)
1920 (x_get_foreign_selection, Fx_disown_selection_internal)
1921 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1922 (lisp_data_to_selection_data): Use cons_to_unsigned.
1923 (x_fill_property_data): Use cons_to_signed.
1924 Report values out of range.
1925
1926 Check for buffer and string overflow more precisely.
1927 * buffer.h (BUF_BYTES_MAX): New macro.
1928 * lisp.h (STRING_BYTES_MAX): New macro.
1929 * alloc.c (Fmake_string):
1930 * character.c (string_escape_byte8):
1931 * coding.c (coding_alloc_by_realloc):
1932 * doprnt.c (doprnt):
1933 * editfns.c (Fformat):
1934 * eval.c (verror):
1935 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1936 since they may not be the same number.
1937 * editfns.c (Finsert_char):
1938 * fileio.c (Finsert_file_contents):
1939 Likewise for BUF_BYTES_MAX.
1940
1941 * image.c: Use ptrdiff_t, not int, for sizes.
1942 (slurp_file): Switch from int to ptrdiff_t.
1943 All uses changed.
1944 (slurp_file): Check that file size fits in both size_t (for
1945 malloc) and ptrdiff_t (for sanity and safety).
1946
1947 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1948 if b->modtime has its maximal value.
1949
1950 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1951
1952 Don't assume time_t can fit into int.
1953 * buffer.h (struct buffer.modtime): Now time_t, not int.
1954 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1955 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1956
1957 Minor fixes for signed vs unsigned integers.
1958 * character.h (MAYBE_UNIFY_CHAR):
1959 * charset.c (maybe_unify_char):
1960 * keyboard.c (read_char, reorder_modifiers):
1961 XINT -> XFASTINT, since the integer must be nonnegative.
1962 * ftfont.c (ftfont_spec_pattern):
1963 * keymap.c (access_keymap, silly_event_symbol_error):
1964 XUINT -> XFASTINT, since the integer must be nonnegative.
1965 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1966 since it makes no difference and we prefer signed.
1967 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1968 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1969 nonnegative.
1970
1971 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1972
1973 * window.h (Fwindow_frame): Declare.
1974
1975 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1978 (SPARE_MEMORY): Always define.
1979 (LARGE_REQUEST): Remove.
1980 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1981
1982 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1983
1984 * lisp.h: Move EXFUNS for Fframe_root_window,
1985 Fframe_first_window and Fset_frame_selected_window to window.h.
1986
1987 * window.h: Move EXFUNS for Fframe_root_window,
1988 Fframe_first_window and Fset_frame_selected_window here from
1989 lisp.h.
1990
1991 * frame.c (Fwindow_frame, Fframe_first_window)
1992 (Fframe_root_window, Fframe_selected_window)
1993 (Fset_frame_selected_window): Move to window.c.
1994 (Factive_minibuffer_window): Move to minibuf.c.
1995 (Fother_visible_frames_p): New function.
1996
1997 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1998
1999 * window.c (decode_window, decode_any_window): Move up in code.
2000 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2001 (inhibit_frame_unsplittable): Remove unused variable.
2002 (Fwindow_buffer): Move up and rewrite doc-string.
2003 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2004 (Fwindow_prev): New functions.
2005 (Fwindow_frame): Move here from frame.c. Accept any window as
2006 argument.
2007 (Fframe_root_window, Fframe_first_window)
2008 (Fframe_selected_window): Move here from frame.c. Accept frame
2009 or arbitrary window as argument. Update doc-strings.
2010 (Fminibuffer_window): Move up in code.
2011 (Fwindow_minibuffer_p): Move up in code and simplify.
2012 (Fset_frame_selected_window): Move here from frame.c.
2013 Marginal rewrite.
2014 (Fselected_window, select_window, Fselect_window): Move up in
2015 code. Minor doc-string fixes.
2016
2017 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2018
2019 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2020 Do not assume that spare memory exists; that assumption is valid
2021 only if SYSTEM_MALLOC.
2022 (LARGE_REQUEST): New macro, so that the issue of large requests
2023 is separated from the issue of spare memory.
2024
2025 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2026
2027 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2028 format. (Bug#8806)
2029
2030 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2031
2032 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2033 before statements.
2034
2035 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2036
2037 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2038
2039 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2040
2041 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2042 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2043
2044 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2045
2046 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2047
2048 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2049
2050 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2051 (x_clipboard_manager_save): Add return value.
2052 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2053 New error handlers.
2054 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2055 Obey Vx_select_enable_clipboard_manager. Catch errors in
2056 x_clipboard_manager_save (Bug#8779).
2057 (Vx_select_enable_clipboard_manager): New variable.
2058 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2059
2060 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2061
2062 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2063
2064 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2065
2066 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2067 in the current matrix if keep_current_p is non-zero.
2068
2069 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2070
2071 * bidi.c (bidi_level_of_next_char): Fix last change.
2072
2073 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2074
2075 Support bidi reordering of text covered by display properties.
2076
2077 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2078 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2079 (bidi_cache_search, bidi_cache_iterator_state)
2080 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2081 (bidi_level_of_next_char, bidi_move_to_visually_next):
2082 Support character positions inside a run of characters covered by a
2083 display string.
2084 (bidi_paragraph_init, bidi_resolve_explicit_1)
2085 (bidi_level_of_next_char): Call bidi_fetch_char and
2086 bidi_fetch_char_advance instead of FETCH_CHAR and
2087 FETCH_CHAR_ADVANCE.
2088 (bidi_init_it): Initialize new members.
2089 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2090 definitions.
2091 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2092 instead of using explicit *_CHAR codes.
2093 (bidi_resolve_explicit, bidi_resolve_weak):
2094 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2095 bidirectional text is supported only in multibyte buffers.
2096 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2097 it to initialize the frame_window_p member of struct bidi_it.
2098 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2099 (bidi_resolve_explicit, bidi_resolve_weak)
2100 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2101 bidi_it->nchars is non-positive.
2102 (bidi_level_of_next_char): Don't try to lookup the cache for the
2103 next/previous character if nothing is cached there yet, or if we
2104 were just reseat()'ed to a new position.
2105
2106 * xdisp.c (set_cursor_from_row): Set start and stop points
2107 according to the row's direction when priming the loop that looks
2108 for the glyph on which to display cursor.
2109 (single_display_spec_intangible_p): Function deleted.
2110 (display_prop_intangible_p): Reimplement to call
2111 handle_display_spec instead of single_display_spec_intangible_p.
2112 Accept 3 additional arguments needed by handle_display_spec.
2113 This fixes incorrect cursor motion across display property with complex
2114 values: lists, `(when COND...)' forms, etc.
2115 (single_display_spec_string_p): Support property values that are
2116 lists with the argument STRING its top-level element.
2117 (display_prop_string_p): Fix the condition for processing a
2118 property that is a list to be consistent with handle_display_spec.
2119 (handle_display_spec): New function, refactored from the
2120 last portion of handle_display_prop.
2121 (compute_display_string_pos): Accept additional argument
2122 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2123 value of a `display' property is a "replacing spec".
2124 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2125 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2126 the display property, but just return a value indicating whether
2127 the display property will replace the characters it covers.
2128 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2129 frame_window_p members of struct bidi_it.
2130 (compute_display_string_pos, compute_display_string_end):
2131 New functions.
2132 (push_it): Accept second argument POSITION, where pop_it should
2133 jump to continue iteration.
2134 (reseat_1): Initialize bidi_it.disp_pos.
2135
2136 * keyboard.c (adjust_point_for_property): Adjust the call to
2137 display_prop_intangible_p to its new signature.
2138
2139 * dispextern.h (struct bidi_it): New member frame_window_p.
2140 (bidi_init_it): Update prototypes.
2141 (display_prop_intangible_p): Update prototype.
2142 (compute_display_string_pos, compute_display_string_end):
2143 Declare prototypes.
2144 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2145 EMACS_INT.
2146
2147 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2148
2149 Malloc failure behavior now depends on size of allocation.
2150 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2151 * lisp.h: Change signatures accordingly.
2152 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2153 All callers changed. (Bug#8762)
2154
2155 * gnutls.c: Use Emacs's memory allocators.
2156 Without this change, the gnutls library would invoke malloc etc.
2157 directly, which causes problems on non-SYNC_INPUT hosts, and which
2158 runs afoul of improving memory_full behavior. (Bug#8761)
2159 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2160 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2161 xfree instead of the default malloc, realloc, free.
2162 (Fgnutls_boot): No need to check for memory allocation failure,
2163 since xmalloc does that for us.
2164
2165 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2166 * category.c (hash_get_category_set):
2167 * ccl.c (ccl_driver):
2168 * charset.c (Fdefine_charset_internal):
2169 * charset.h (struct charset.hash_index):
2170 * composite.c (get_composition_id, gstring_lookup_cache)
2171 (composition_gstring_put_cache):
2172 * composite.h (struct composition.hash_index):
2173 * dispextern.h (struct image.hash):
2174 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2175 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2176 (hashfn_equal, hashfn_user_defined, make_hash_table)
2177 (maybe_resize_hash_table, hash_lookup, hash_put)
2178 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2179 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2180 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2181 * image.c (make_image, search_image_cache, lookup_image)
2182 (xpm_put_color_table_h):
2183 * lisp.h (struct Lisp_Hash_Table):
2184 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2185 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2186 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2187 * alloc.c (allocate_vectorlike):
2188 Check for overflow in vector size calculations.
2189 * ccl.c (ccl_driver):
2190 Check for overflow when converting EMACS_INT to int.
2191 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2192 need to be updated by these changes.
2193 * fns.c (make_hash_table, maybe_resize_hash_table):
2194 Check for integer overflow with large hash tables.
2195 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2196 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2197 (SXHASH_REDUCE): New macro.
2198 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2199 Use it instead of discarding useful hash info with large hash values.
2200 (sxhash_float): New function.
2201 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2202 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2203 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2204 Rewrite to use FIXNUM_BITS, as this simplifies things.
2205 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2206 Adjust signatures to match updated version of code.
2207 (consing_since_gc): Now EMACS_INT, since a single hash table can
2208 use more than INT_MAX bytes.
2209
2210 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2211
2212 Make it possible to build with GCC-4.6+ -O2 -flto.
2213
2214 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2215
2216 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2217
2218 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2219 Call minibuffer-inactive-mode.
2220
2221 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2222
2223 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2224 Update dependencies.
2225
2226 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2227
2228 * data.c (init_data): Remove code for UTS, this system is not
2229 supported anymore.
2230
2231 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2232
2233 Don't force ./temacs to start in terminal mode.
2234
2235 * frame.c (make_initial_frame): Initialize faces in all cases, not
2236 only when CANNOT_DUMP is defined.
2237 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2238
2239 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2240
2241 * dispnew.c (add_window_display_history): Use const for the string
2242 pointer. Remove declaration, not needed.
2243
2244 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2245
2246 Use 'inline', not 'INLINE'.
2247 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2248 * alloc.c, fontset.c (INLINE): Remove.
2249 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2250 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2251 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2252 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2253 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2254
2255 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2256
2257 Make it possible to run ./temacs.
2258
2259 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2260 syms_of_callproc does the same thing. Remove test for
2261 "initialized", do it in the caller.
2262 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2263
2264 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2265
2266 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2267 (read_minibuf): Use get_minibuffer.
2268 (syms_of_minibuf): Use DEFSYM.
2269 (Qmetadata): New var.
2270 * data.c (Qbuffer): Don't make it static.
2271 (syms_of_data): Use DEFSYM.
2272
2273 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2274
2275 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2276 (CCL_CODE_MIN): New macro.
2277
2278 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2279
2280 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2281
2282 * eval.c (Qdebug): Now static.
2283 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2284 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2285 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2286
2287 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2288
2289 * image.c: Various fixes to ImageMagick code comments.
2290 (Fimagemagick_types): Doc fix.
2291
2292 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2293
2294 Minor fixes prompted by GCC 4.6.0 warnings.
2295
2296 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2297
2298 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2299 (x_clipboard_manager_save_all): Move extern decl to ...
2300 * xterm.h: ... here, so that it can be checked for consistency.
2301
2302 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2303
2304 * xselect.c (x_clipboard_manager_save_frame)
2305 (x_clipboard_manager_save_all): New functions.
2306 (Fx_clipboard_manager_save): Lisp function deleted.
2307
2308 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2309 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2310
2311 * xterm.h: Update prototype.
2312
2313 2011-05-28 William Xu <william.xwl@gmail.com>
2314
2315 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2316 exiting (Bug#8239).
2317
2318 2011-05-28 Jim Meyering <meyering@redhat.com>
2319
2320 Avoid a sign-extension bug in crypto_hash_function.
2321 * fns.c (to_uchar): Define.
2322 (crypto_hash_function): Use it to convert some newly-signed
2323 variables to unsigned, to avoid sign-extension bugs. For example,
2324 without this change, (md5 "truc") would evaluate to
2325 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2326 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2327 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2328
2329 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 Integer overflow fixes.
2332
2333 * dbusbind.c: Serial number integer overflow fixes.
2334 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2335 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2336 to hold a serial number that is too large for a fixnum.
2337 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2338 Check for serial numbers out of range. Decode any serial number
2339 that was so large that it became a float. (Bug#8722)
2340
2341 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2342 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2343 Use XFASTINT rather than XUINT when numbers are nonnegative.
2344 (xd_append_arg, Fdbus_method_return_internal):
2345 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2346 arguments, check that Lisp number is nonnegative, rather than
2347 silently wrapping negative numbers around. (Bug#8722)
2348 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2349 (Bug#8722)
2350
2351 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2352
2353 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2354
2355 ccl: add integer overflow checks
2356 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2357 (IN_INT_RANGE): New macros.
2358 (ccl_driver): Use them to check for integer overflow when
2359 decoding a CCL program. Many of the new checks are whether XINT (x)
2360 fits in int; it doesn't always, on 64-bit hosts. The new version
2361 doesn't catch all possible integer overflows, but it's an
2362 improvement. (Bug#8719)
2363
2364 * alloc.c (make_event_array): Use XINT, not XUINT.
2365 There's no need for unsigned here.
2366
2367 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2368 This follows up to the 2011-05-06 change that substituted uintptr_t
2369 for EMACS_INT. This case wasn't caught back then.
2370
2371 Rework Fformat to avoid integer overflow issues.
2372 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2373 now (part of C89). Include <verify.h>.
2374 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2375 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2376 (Fformat): Avoid the prepass trying to compute sizes; it was only
2377 approximate and thus did not catch overflow reliably. Instead, walk
2378 through the format just once, formatting and computing sizes as we go,
2379 checking for integer overflow at every step, and allocating a larger
2380 buffer as needed. Keep track separately whether the format is
2381 multibyte. Keep only the most-recently calculated precision, rather
2382 than them all. Record whether each argument has been converted to
2383 string. Use EMACS_INT, not int, for byte and char and arg counts.
2384 Support field widths and precisions larger than INT_MAX. Avoid
2385 sprintf's undefined behavior with conversion specifications such as %#d
2386 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2387 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2388 formatting out-of-range floating point numbers with int
2389 formats. (Bug#8668)
2390
2391 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2392
2393 * data.c: Avoid integer truncation in expressions involving floats.
2394 * data.c: Include <intprops.h>.
2395 (arith_driver): When there's an integer overflow in an expression
2396 involving floating point, convert the integers to floating point
2397 so that the resulting value does not suffer from catastrophic
2398 integer truncation. For example, on a 64-bit host (* 4
2399 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2400 Do not rely on undefined behavior after integer overflow.
2401
2402 merge count_size_as_multibyte, parse_str_to_multibyte
2403 * character.c, character.h (count_size_as_multibyte):
2404 Rename from parse_str_to_multibyte; all uses changed.
2405 Check for integer overflow.
2406 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2407 since it's now a duplicate of the other. This is more of
2408 a character than a buffer op, so better that it's in character.c.
2409 * fns.c, print.c: Adjust to above changes.
2410
2411 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2412
2413 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2414
2415 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2416
2417 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2418 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2419 (x_clipboard_manager_save): Now static.
2420 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2421
2422 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2423 (crypto_hash_function): Now static.
2424 Fix pointer signedness problems. Avoid unnecessary initializations.
2425
2426 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2427
2428 * termhooks.h (Vselection_alist): Make it terminal-local.
2429
2430 * terminal.c (create_terminal): Initialize it.
2431
2432 * xselect.c: Support for clipboard managers.
2433 (Vselection_alist): Move to termhooks.h as terminal-local var.
2434 (LOCAL_SELECTION): New macro.
2435 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2436 (symbol_to_x_atom): Remove gratuitous arg.
2437 (x_handle_selection_request, lisp_data_to_selection_data)
2438 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2439 (x_own_selection, x_get_local_selection, x_convert_selection):
2440 New arg, specifying work frame. Use terminal-local Vselection_alist.
2441 (some_frame_on_display): Delete unused function.
2442 (Fx_own_selection_internal, Fx_get_selection_internal)
2443 (Fx_disown_selection_internal, Fx_selection_owner_p)
2444 (Fx_selection_exists_p): New optional frame arg.
2445 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2446 (x_handle_selection_clear): Don't treat other terminals with the
2447 same keyboard specially. Use the terminal-local Vselection_alist.
2448 (x_clear_frame_selections): Use Frun_hook_with_args.
2449
2450 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2451
2452 * xterm.h: Add support for those atoms.
2453
2454 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2455
2456 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2457 (converted_selections, conversion_fail_tag): New global variables.
2458 (x_selection_request_lisp_error): Free the above.
2459 (x_get_local_selection): Remove unnecessary code.
2460 (x_reply_selection_request): Args changed; handle arbitrary array
2461 of converted selections stored in converted_selections.
2462 Separate the XChangeProperty and SelectionNotify steps.
2463 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2464 (x_convert_selection): New function.
2465 (x_handle_selection_event): Simplify.
2466 (x_get_foreign_selection): Don't ignore incoming requests while
2467 waiting for an answer; this will fail when we implement
2468 SAVE_TARGETS, and seems unnecessary anyway.
2469 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2470 (Vx_sent_selection_functions): Doc fix.
2471
2472 2011-05-26 Leo Liu <sdl.web@gmail.com>
2473
2474 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2475
2476 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2477
2478 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2479
2480 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2481 for fringe update if it has periodic bitmap.
2482 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2483 and fringe_bitmap_periodic_p.
2484
2485 * fringe.c (get_fringe_bitmap_data): New function.
2486 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2487 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2488 row. Mark glyph row for fringe update if periodicity changed.
2489
2490 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2491 for fringe update unless it has periodic bitmap.
2492
2493 2011-05-25 Kenichi Handa <handa@m17n.org>
2494
2495 * xdisp.c (get_next_display_element): Set correct it->face_id for
2496 a static composition.
2497
2498 2011-05-24 Leo Liu <sdl.web@gmail.com>
2499
2500 * deps.mk (fns.o):
2501 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2502
2503 * fns.c (crypto_hash_function, Fsha1): New function.
2504 (Fmd5): Use crypto_hash_function.
2505 (syms_of_fns): Add Ssha1.
2506
2507 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2508
2509 * gnutls.c: Remove unused macros.
2510 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2511 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2512 Remove macros that are defined and never used.
2513 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2514
2515 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2516
2517 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2518 (Fx_get_selection_internal): Minor cleanup.
2519 (Fx_own_selection_internal): Rename arguments for consistency with
2520 select.el.
2521
2522 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2523
2524 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2525
2526 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2527
2528 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2529
2530 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2531
2532 * dispnew.c (scrolling_window): Don't exclude the case that the
2533 last enabled row in the desired matrix touches the bottom boundary.
2534
2535 2011-05-21 Glenn Morris <rgm@gnu.org>
2536
2537 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2538 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2539 and add some more files.
2540
2541 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2542
2543 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2544 report_file_error introduced by the change from 2011-05-07.
2545
2546 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2547
2548 * systime.h (Time): Define only if emacs is defined.
2549 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2550 where the include path doesn't have X11/X.h by default. See
2551 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2552
2553 2011-05-20 Kenichi Handa <handa@m17n.org>
2554
2555 * composite.c (find_automatic_composition): Fix previous change.
2556
2557 2011-05-20 Glenn Morris <rgm@gnu.org>
2558
2559 * lisp.mk: New file, split from Makefile.in.
2560 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2561 (shortlisp): Remove.
2562 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2563
2564 2011-05-19 Glenn Morris <rgm@gnu.org>
2565
2566 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2567 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2568 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2569 (lisp): Set the order to that of loadup.el.
2570 (shortlisp): Make it a copy of $lisp.
2571 (SOME_MACHINE_LISP): Remove.
2572 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2573 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2574
2575 2011-05-18 Kenichi Handa <handa@m17n.org>
2576
2577 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2578 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2579 (find_automatic_composition): Mostly rewrite for efficiency.
2580
2581 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2582
2583 * makefile.w32-in: Update dependencies.
2584
2585 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2586
2587 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2588 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2589
2590 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 Fix some integer overflow issues, such as string length overflow.
2593
2594 * insdel.c (count_size_as_multibyte): Check for string overflow.
2595
2596 * character.c (lisp_string_width): Check for string overflow.
2597 Use EMACS_INT, not int, for string indexes and lengths; in
2598 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2599 the resulting string length overflows an EMACS_INT; instead,
2600 report a string overflow if no precision given. When checking for
2601 precision exhaustion, use a check that cannot possibly have
2602 integer overflow. (Bug#8675)
2603 * character.h (lisp_string_width): Adjust to new signature.
2604
2605 * alloc.c (string_overflow): New function.
2606 (Fmake_string): Use it. This doesn't change behavior, but saves
2607 a few bytes and will simplify future changes.
2608 * character.c (string_escape_byte8): Likewise.
2609 * lisp.h (string_overflow): New decl.
2610
2611 Fixups, following up to the user-interface timestamp change.
2612 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2613 for UI timestamps, instead of unsigned long.
2614 * msdos.c (mouse_get_pos): Likewise.
2615 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2616 * w32gui.h (Time): Define by including "systime.h" rather than by
2617 declaring it ourselves. (Bug#8664)
2618
2619 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2620 * image.c (clear_image_cache): Likewise.
2621
2622 * term.c (term_mouse_position): Don't assume time_t wraparound.
2623
2624 Be more systematic about user-interface timestamps.
2625 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2626 and sometimes 'EMACS_UINT', to represent these timestamps.
2627 This change causes it to use 'Time' uniformly, as that's what X uses.
2628 This makes the code easier to follow, and makes it easier to catch
2629 integer overflow bugs such as Bug#8664.
2630 * frame.c (Fmouse_position, Fmouse_pixel_position):
2631 Use Time, not unsigned long, for user-interface timestamps.
2632 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2633 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2634 * keyboard.h (last_event_timestamp): Likewise.
2635 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2636 * menu.h (xmenu_show): Likewise.
2637 * term.c (term_mouse_position): Likewise.
2638 * termhooks.h (struct input_event.timestamp): Likewise.
2639 (struct terminal.mouse_position_hook): Likewise.
2640 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2641 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2642 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2643 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2644 what it was before.
2645 * menu.h, termhooks.h: Include "systime.h", for Time.
2646
2647 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2648 Don't assume that the difference between two unsigned long values
2649 can fit into an integer. At this point, we know button_down_time
2650 <= event->timestamp, so the difference must be nonnegative, so
2651 there's no need to cast the result if double-click-time is
2652 nonnegative, as it should be; check that it's nonnegative, just in
2653 case. This bug is triggered when events are more than 2**31 ms
2654 apart (about 25 days). (Bug#8664)
2655
2656 * xselect.c (last_event_timestamp): Remove duplicate decl.
2657 (x_own_selection): Remove needless cast to unsigned long.
2658
2659 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2660 that always fit in int. Use a sentinel instead of a counter, to
2661 avoid a temp and to allay GCC's concerns about possible int overflow.
2662 * frame.h (struct frame): Use int for menu_bar_items_used
2663 instead of EMACS_INT, since it always fits in int.
2664
2665 * menu.c (grow_menu_items): Check for int overflow.
2666
2667 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2668
2669 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2670 Before, the code was not consistent. These values cannot exceed
2671 2**31 - 1 so there's no need to make them unsigned.
2672 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2673 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2674 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2675 as modifiers.
2676 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2677
2678 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2679 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2680 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2681 presumably because the widths might not match.
2682
2683 * window.c (size_window): Avoid needless test at loop start.
2684
2685 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2686
2687 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2688
2689 2011-05-12 Drew Adams <drew.adams@oracle.com>
2690
2691 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2692
2693 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2694
2695 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2696 `width' to `bar_area_x' and `bar_area_width', respectively.
2697 (x_scroll_run): Take account of fringe background extension.
2698
2699 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2700 Rename local vars `left' and `width' to `bar_area_x' and
2701 `bar_area_width', respectively.
2702 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2703 background extension.
2704
2705 2011-05-10 Jim Meyering <meyering@redhat.com>
2706
2707 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2708
2709 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2710
2711 * image.c (Finit_image_library): Return t for built-in image types,
2712 like pbm and xbm. (Bug#8640)
2713
2714 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2715
2716 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2717
2718 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2719
2720 * w32console.c (Fset_screen_color): Doc fix.
2721 (Fget_screen_color): New function.
2722 (syms_of_ntterm): Defsubr it.
2723
2724 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2725 unlink the temporary file if Fcall_process didn't create it in the
2726 first place.
2727 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2728 child process will be redirected to a file specified with `:file'.
2729 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2730 cue to call_process_cleanup not to close that handle.
2731
2732 2011-05-07 Ben Key <bkey76@gmail.com>
2733
2734 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2735 one of two shell specific rules, either bootstrap-temacs-CMD or
2736 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2737 to the previous implementation of the bootstrap-temacs rule.
2738 The bootstrap-temacs-CMD rule is similar to the previous
2739 implementation of the bootstrap-temacs rule except that it
2740 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2741 variable.
2742
2743 These changes, along with some changes to nt/configure.bat,
2744 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2745 earlier fix to add support for --cflags and --ldflags options
2746 that include quotes so that it works whether make uses cmd or
2747 sh as the shell.
2748
2749 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2750
2751 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2752 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2753 is a constant.
2754 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2755 a string. Handle both cases.
2756 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2757 (Fdbus_register_method): Use Qinvalid_function.
2758
2759 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2760
2761 * makefile.w32-in: Update dependencies.
2762 (LISP_H): Add inttypes.h and stdin.h.
2763 (PROCESS_H): Add unistd.h.
2764
2765 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2766
2767 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2768 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2769
2770 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2771
2772 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2773
2774 * term.c (vfatal): Remove stray call to va_end.
2775 It's not needed and the C Standard doesn't allow it here anyway.
2776
2777 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2778 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2779
2780 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2781 bytes.
2782
2783 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2784
2785 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2786
2787 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2788
2789 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2790
2791 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2792
2793 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2794 * charset.c (Fdefine_charset_internal): Don't initialize
2795 charset.code_space[15]. The value was garbage, on hosts with
2796 32-bit int (Bug#8600).
2797
2798 * lread.c (read_integer): Be more consistent with string-to-number.
2799 Use string_to_number to do the actual conversion; this avoids
2800 rounding errors and fixes some other screwups. Without this fix,
2801 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2802 (digit_to_number): Move earlier, for benefit of read_integer.
2803 Return -1 if the digit is out of range for the base, -2 if it is
2804 not a digit in any supported base. (Bug#8602)
2805
2806 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2807
2808 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2809 to match comment at start of function. This also removes a
2810 GCC warning about overflow in a 32+64-bit port.
2811
2812 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2813
2814 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2815 Reported by Stefan Monnier in
2816 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2817 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2818 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2819
2820 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2821 (EMACS_UINTPTR): Likewise, with uintptr_t.
2822
2823 * lisp.h: Prefer 64-bit EMACS_INT if available.
2824 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2825 on 32-bit hosts that have 64-bit int, so that they can access
2826 large files.
2827 However, temporarily disable this change unless the temporary
2828 symbol WIDE_EMACS_INT is defined.
2829
2830 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2831
2832 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2833 This removes an assumption that EMACS_INT and long are the same
2834 width as pointers. The assumption is true for Emacs porting targets
2835 now, but we want to make other targets possible.
2836 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2837 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2838 In the rest of the code, change types of integers that hold casted
2839 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2840 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2841 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2842 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2843 No need to cast type when ORing.
2844 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2845 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2846 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2847 assume EMACS_INT is the same width as char *.
2848 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2849 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2850 Remove no-longer-needed casts.
2851 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2852 (xg_tool_bar_help_callback, xg_make_tool_item):
2853 Use EMACS_INTPTR to hold an integer
2854 that will be cast to void *; this can avoid a GCC warning
2855 if EMACS_INT is not the same width as void *.
2856 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2857 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2858 (current_message_1, set_message_1):
2859 Use a local to convert to proper width without a cast.
2860 * xmenu.c (dialog_selection_callback): Likewise.
2861
2862 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2863 Also, don't assume VALBITS / RAND_BITS is less than 5,
2864 and don't rely on undefined behavior when shifting a 1 left into
2865 the sign bit.
2866 * lisp.h (get_random): Change signature to match.
2867
2868 * lread.c (hash_string): Use size_t, not int, for hash computation.
2869 Normally we prefer signed values; but hashing is special, because
2870 it's better to use unsigned division on hash table sizes so that
2871 the remainder is nonnegative. Also, size_t is the natural width
2872 for hashing into memory. The previous code used 'int', which doesn't
2873 retain enough info to hash well into very large tables.
2874 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2875
2876 * dbusbind.c: Don't possibly lose pointer info when converting.
2877 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2878 Use XPNTR rather than XHASH, so that the high-order bits of
2879 the pointer aren't lost when converting through void *.
2880
2881 * eval.c (Fautoload): Don't double-shift a pointer.
2882
2883 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2884
2885 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2886
2887 * gnutls.c (DEF_GNUTLS_FN):
2888 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2889
2890 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2891
2892 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2893 marker. (Bug#8610)
2894
2895 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2896
2897 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2898 New version that can reserve upto 2GB of heap space.
2899
2900 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2901
2902 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2903
2904 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2905
2906 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2907 `gnutls_certificate_set_x509_key_file'.
2908
2909 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2910
2911 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2912 Update dependencies.
2913
2914 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2915
2916 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2917 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2918 Remove unused parameter `fildes'.
2919 * process.c (read_process_output, send_process): Don't pass it.
2920
2921 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2922
2923 Fix previous change: the library cache is defined in w32.c.
2924 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2925 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2926
2927 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2928
2929 Implement dynamic loading of GnuTLS on Windows.
2930
2931 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2932 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2933 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2934 Declare.
2935
2936 * gnutls.c (Qgnutls_dll): Define.
2937 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2938 (gnutls_*): Declare function pointers.
2939 (init_gnutls_functions): New function to initialize function pointers.
2940 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2941 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2942 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2943 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2944 (emacs_gnutls_write, emacs_gnutls_read)
2945 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2946 (Fgnutls_available_p): New function.
2947 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2948 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2949 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2950
2951 * image.c: Include w32.h.
2952 (Vimage_type_cache): Delete.
2953 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2954 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2955 (w32_delayed_load): Move to w32.c.
2956
2957 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2958
2959 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2960 (w32_delayed_load): Move from image.c. When loading a library, record
2961 its filename in the :loaded-from property of the library id.
2962 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2963 Initialize and staticpro them.
2964 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2965
2966 * process.c: Include lisp.h before w32.h, not after.
2967 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2968 instead of gnutls_record_check_pending.
2969
2970 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2971
2972 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2973
2974 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2975 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2976 as passed in.
2977
2978 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2979
2980 * xterm.c (x_set_frame_alpha): Do not set property on anything
2981 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2982
2983 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2984
2985 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2986
2987 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2988
2989 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2990 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2991 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2992 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2993 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2994 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2995 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2996 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2997 (Qgnutls_bootprop_callbacks_verify): Make static.
2998
2999 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3000
3001 * callproc.c: Indentation fixup.
3002
3003 * sysdep.c (wait_for_termination_1): Make static.
3004 (wait_for_termination, interruptible_wait_for_termination):
3005 Move after wait_for_termination_1.
3006
3007 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3008
3009 * sysdep.c (interruptible_wait_for_termination): New function
3010 which is like wait_for_termination, but allows keyboard
3011 interruptions.
3012
3013 * callproc.c (Fcall_process): Add (:file "file") as an option for
3014 the STDOUT buffer.
3015 (Fcall_process_region): Ditto.
3016
3017 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3018
3019 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3020 rather than `XVECTOR (FOO)->size'.
3021
3022 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3023 inttypes.h, as a gnulib replacement is used if it not available in
3024 system headers.
3025
3026 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3027
3028 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3029 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3030 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3031
3032 * coding.c (coding_alloc_by_realloc): Error out if destination
3033 will grow beyond MOST_POSITIVE_FIXNUM.
3034 (decode_coding_emacs_mule): Abort if there isn't enough place in
3035 charbuf for the composition carryover bytes. Reserve an extra
3036 space for up to 2 characters produced in a loop.
3037 (decode_coding_iso_2022): Abort if there isn't enough place in
3038 charbuf for the composition carryover bytes.
3039
3040 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3041
3042 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3043 aborting when %lld or %lll format is passed.
3044 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3045 %llo or %llx format is passed. (Bug#8545)
3046
3047 * window.c (window_scroll_line_based): Use a marker instead of
3048 simple variables to record original value of point. (Bug#7952)
3049
3050 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3051 produced by %s or %c overflows available buffer space. (Bug#8545)
3052
3053 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3054
3055 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3056 (SIZE_MAX): Move defn after all includes, as they might #define it.
3057
3058 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3059
3060 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3061
3062 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3063
3064 * keyboard.c (Qdelayed_warnings_hook): Define.
3065 (command_loop_1): Run `delayed-warnings-hook'
3066 if Vdelayed_warnings_list is non-nil.
3067 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3068 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3069
3070 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3071
3072 * doprnt.c (doprnt): Don't return value smaller than the buffer
3073 size if the message was truncated. (Bug#8545).
3074
3075 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3076
3077 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3078 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3079
3080 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3083
3084 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3085
3086 * makefile.w32-in: Update dependencies.
3087
3088 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3089
3090 Improve `doprnt' and its usage. (Bug#8545)
3091 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3092 `format_end'. Remove support for %l as a conversion specifier.
3093 Don't use xrealloc. Improve diagnostics when the %l size modifier
3094 is used. Update the commentary.
3095
3096 * eval.c (verror): Simplify calculation of size_t.
3097
3098 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3099 messages.
3100
3101 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3102
3103 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3104 change.
3105
3106 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3107
3108 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3109 This makes this file independent of the recent pseudovector change.
3110
3111 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3112
3113 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3114
3115 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3116 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3117 Remove unused local.
3118 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3119
3120 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3121 GCC 4.6.0 optimizes based on type-based alias analysis.
3122 For example, if b is of type struct buffer * and v of type struct
3123 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3124 != &v->size, and therefore "v->size = 1; b->size = 2; return
3125 v->size;" must therefore return 1. This assumption is incorrect
3126 for Emacs, since it type-puns struct Lisp_Vector * with many other
3127 types. To fix this problem, this patch adds a new type struct
3128 vectorlike_header that documents the constraints on layout of vectors
3129 and pseudovectors, and helps optimizing compilers not get fooled
3130 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3131 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3132 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3133 the size member.
3134 (XSETPVECTYPE): Rewrite in terms of new macro.
3135 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3136 This is a bit clearer, and further avoids the possibility of
3137 undesirable aliasing.
3138 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3139 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3140 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3141 since Lisp_Subr is a special case (no "next" field).
3142 (ASIZE): Now uses header.size rather than size.
3143 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3144 to avoid the hassle of writing XVECTOR (foo)->header.size.
3145 (struct vectorlike_header): New type.
3146 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3147 object, to help avoid aliasing.
3148 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3149 (SUBRP): Likewise, since Lisp_Subr is a special case.
3150 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3151 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3152 (struct Lisp_Hash_Table): Combine first two members into a single
3153 struct vectorlike_header member. All uses of "size" and "next" members
3154 changed to be "header.size" and "header.next".
3155 * buffer.h (struct buffer): Likewise.
3156 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3157 * frame.h (struct frame): Likewise.
3158 * process.h (struct Lisp_Process): Likewise.
3159 * termhooks.h (struct terminal): Likewise.
3160 * window.c (struct save_window_data, struct saved_window): Likewise.
3161 * window.h (struct window): Likewise.
3162 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3163 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3164 * buffer.c (init_buffer_once): Likewise.
3165 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3166 special case.
3167 * process.c (Fformat_network_address): Use local var for size,
3168 for brevity.
3169
3170 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3171
3172 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3173 * data.c (atof): Remove decl; no longer used or needed.
3174 (digit_to_number): Move to lread.c.
3175 (Fstring_to_number): Use new string_to_number function, to be
3176 consistent with how the Lisp reader treats infinities and NaNs.
3177 Do not assume that floating-point numbers represent EMACS_INT
3178 without losing information; this is not true on most 64-bit hosts.
3179 Avoid double-rounding errors, by insisting on integers when
3180 parsing non-base-10 numbers, as the documentation specifies.
3181 * lisp.h (string_to_number): New decl, replacing ...
3182 (isfloat_string): Remove.
3183 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3184 (read1): Do not accept +. and -. as integers; this
3185 appears to have been a coding error. Similarly, do not accept
3186 strings like +-1e0 as floating point numbers. Do not report
3187 overflow for integer overflows unless the base is not 10 which
3188 means we have no simple and reliable way to continue.
3189 Break out the floating-point parsing into a new
3190 function string_to_number, so that Fstring_to_number parses
3191 floating point numbers consistently with the Lisp reader.
3192 (digit_to_number): Move here from data.c. Make it static inline.
3193 (E_CHAR, EXP_INT): Remove, replacing with ...
3194 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3195 (string_to_number): New function, replacing isfloat_string.
3196 This function checks for valid syntax and produces the resulting
3197 Lisp float number too. Rework it so that string-to-number
3198 no longer mishandles examples like "1.0e+". Use strtoumax,
3199 so that overflow for non-base-10 numbers is reported only when
3200 there's no portable and simple way to convert to floating point.
3201
3202 * textprop.c (set_text_properties_1): Rewrite for clarity,
3203 and to avoid GCC warning about integer overflow.
3204
3205 * intervals.h (struct interval): Use EMACS_INT for members
3206 where EMACS_UINT might cause problems. See
3207 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3208 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3209 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3210 All uses changed.
3211 (offset_intervals): Tell GCC not to worry about length overflow
3212 when negating a negative length.
3213
3214 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3215 (overrun_check_free): Likewise.
3216
3217 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3218 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3219 word size.
3220
3221 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3222 (gnutls_make_error): Rename local to avoid shadowing.
3223 (gnutls_emacs_global_deinit): ifdef out; not used.
3224 (Fgnutls_boot): Use const for pointer to readonly storage.
3225 Comment out unused local. Fix pointer signedness problems.
3226
3227 * lread.c (openp): Don't stuff size_t into an 'int'.
3228 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3229 about possible signed overflow.
3230
3231 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3232 (GDK_KEY_g): Don't define if already defined.
3233 (xg_prepare_tooltip): Avoid pointer signedness problem.
3234 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3235
3236 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3237 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3238
3239 * xfns.c (Fx_window_property): Simplify a bit,
3240 to make a bit faster and to avoid GCC 4.6.0 warning.
3241 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3242
3243 * fns.c (internal_equal): Don't assume size_t fits in int.
3244
3245 * alloc.c (compact_small_strings): Tighten assertion a little.
3246
3247 Replace pEd with more-general pI, and fix some printf arg casts.
3248 * lisp.h (pI): New macro, generalizing old pEd macro to other
3249 conversion specifiers. For example, use "...%"pI"d..." rather
3250 than "...%"pEd"...".
3251 (pEd): Remove. All uses replaced with similar uses of pI.
3252 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3253 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3254 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3255 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3256 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3257 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3258 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3259 64-bit hosts.
3260 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3261 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3262 * print.c (safe_debug_print, print_object): Likewise.
3263 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3264 to int.
3265 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3266 avoiding the 0 flag, which is not portable.
3267 * process.c (Fmake_network_process): Use pI to avoid cast.
3268 * region-cache.c (pp_cache): Likewise.
3269 * xdisp.c (decode_mode_spec): Likewise.
3270 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3271 behavior on 64-bit hosts with printf arg.
3272 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3273 (x_stop_queuing_selection_requests): Likewise.
3274 (x_get_window_property): Don't truncate byte count to an 'int'
3275 when tracing.
3276
3277 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3278 here, since it parses constructs like leading '-' and spaces,
3279 which are not wanted; and it overflows with large numbers.
3280 Instead, simply match F[0-9]+, which is what is wanted anyway.
3281
3282 * alloc.c: Remove unportable assumptions about struct layout.
3283 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3284 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3285 (allocate_vectorlike, make_pure_vector): Use the new macros,
3286 plus offsetof, to remove unportable assumptions about struct layout.
3287 These assumptions hold on all porting targets that I know of, but
3288 they are not guaranteed, they're easy to remove, and removing them
3289 makes further changes easier.
3290
3291 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3292 This doesn't fix a bug but makes the code clearer.
3293 (string_overrun_cookie): Now const. Use initializers that
3294 don't formally overflow signed char, to avoid warnings.
3295 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3296 can cause Emacs to crash when string overrun checking is enabled.
3297 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3298 multiple of sizeof (EMACS_INT); it need not be, if
3299 alignof(EMACS_INT) < sizeof (EMACS_INT).
3300 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3301
3302 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3303
3304 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3305
3306 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3307
3308 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3309 supposed to be handshaking. (Bug#8556)
3310 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3311
3312 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3313
3314 * lisp.h (Qdebug): List symbol.
3315 * eval.c (Qdebug): Restore global linkage.
3316 * keyboard.c (debug-on-event): New variable.
3317 (handle_user_signal): Break into debugger when debug-on-event
3318 matches the current signal symbol.
3319
3320 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3321
3322 * alloc.c (check_sblock, check_string_bytes)
3323 (check_string_free_list): Convert to standard C.
3324
3325 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3326
3327 * w32.c (emacs_gnutls_push): Fix typo.
3328
3329 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3330
3331 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3332 "cast to pointer from integer of different size".
3333
3334 Improve doprnt and its use in verror. (Bug#8545)
3335 * doprnt.c (doprnt): Document the set of format control sequences
3336 supported by the function. Use SAFE_ALLOCA instead of always
3337 using `alloca'.
3338
3339 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3340 is one byte too soon. Don't use xrealloc; instead xfree and
3341 xmalloc anew.
3342
3343 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3344
3345 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3346 callbacks stage.
3347
3348 * gnutls.c: Renamed global_initialized to
3349 gnutls_global_initialized. Added internals for the
3350 :verify-hostname-error, :verify-error, and :verify-flags
3351 parameters of `gnutls-boot' and documented those parameters in the
3352 docstring. Start callback support.
3353 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3354 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3355 on error. Return error code.
3356 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3357 (emacs_gnutls_read): Likewise.
3358 (Fgnutls_boot): Return handshake error code.
3359 (emacs_gnutls_handle_error): New function.
3360 (wsaerror_to_errno): Likewise.
3361
3362 * w32.h (emacs_gnutls_pull): Add prototype.
3363 (emacs_gnutls_push): Likewise.
3364
3365 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3366 (emacs_gnutls_push): Likewise.
3367
3368 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3369
3370 * process.c (wait_reading_process_output): Check if GnuTLS
3371 buffered some data internally if no FDs are set for TLS
3372 connections.
3373
3374 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3375 (LIBS): Link to USER_LIBS.
3376 ($(BLD)/gnutls.$(0)): New target.
3377
3378 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3379
3380 * xdisp.c (handle_single_display_spec): Rename the
3381 display_replaced_before_p argument into display_replaced_p, to
3382 make it consistent with the commentary. Fix typos in the
3383 commentary.
3384
3385 * textprop.c (syms_of_textprop): Remove dead code.
3386 (copy_text_properties): Delete obsolete commentary about an
3387 interface that was deleted long ago. Fix typos in the description
3388 of arguments.
3389
3390 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3391 to changes in oldXMenu/XMenu.h from 2011-04-16.
3392 <menu_help_message, prev_menu_help_message>: Constify.
3393 (IT_menu_make_room): menu->help_text is now `const char **';
3394 adjust.
3395
3396 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3397 to changes in oldXMenu/XMenu.h from 2011-04-16.
3398 (struct XMenu): Declare `help_text' `const char **'.
3399
3400 * xfaces.c <Qunspecified>: Make extern again.
3401
3402 * syntax.c: Include sys/types.h before including regex.h, as
3403 required by Posix.
3404
3405 * doc.c (get_doc_string): Improve the format passed to `error'.
3406
3407 * doprnt.c (doprnt): Improve commentary.
3408
3409 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3410
3411 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3412 them with etags.
3413
3414 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3415 changes in globals.h immediately force recompilation.
3416 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3417 $(CURDIR)/s/ms-w32.h.
3418 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3419
3420 * character.c (Fchar_direction): Function deleted.
3421 (syms_of_character): Don't defsubr it.
3422 <char-direction-table>: Deleted.
3423
3424 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3425
3426 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3427 * doprnt.c: Include limits.h.
3428 (SIZE_MAX): New macro.
3429 (doprnt): Return a size_t value. 2nd arg is now size_t.
3430 Many local variables are now size_t instead of int or unsigned.
3431 Improve overflow protection. Support `l' modifier for integer
3432 conversions. Support %l conversion. Don't assume an EMACS_INT
3433 argument for integer conversions and for %c.
3434
3435 * lisp.h (doprnt): Restore prototype.
3436
3437 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3438 $(SRC)/character.h.
3439
3440 * Makefile.in (base_obj): Add back doprnt.o.
3441
3442 * deps.mk (doprnt.o): Add back prerequisites.
3443 (callint.o): Depend on character.h.
3444
3445 * eval.c (internal_lisp_condition_case): Include the handler
3446 representation in the error message.
3447 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3448 when breaking from the loop.
3449
3450 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3451
3452 * callint.c (Fcall_interactively): When displaying error message
3453 about invalid control letter, pass the character's codepoint, not
3454 a pointer to its multibyte form. Improve display of the character
3455 in octal and display also its hex code.
3456
3457 * character.c (char_string): Use %x to display the (unsigned)
3458 codepoint of an invalid character, to avoid displaying a bogus
3459 negative value.
3460
3461 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3462 `error', not SYMBOL_NAME itself.
3463
3464 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3465 character arguments to `error'.
3466
3467 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3468 to `error' in error message about FINAL_CHAR argument. Make sure
3469 FINAL_CHAR is a character, and use %c when it is passed as
3470 argument to `error'.
3471
3472 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3473
3474 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3475
3476 * w32.c: Include <time.h>.
3477 (sys_localtime): New function.
3478
3479 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3480
3481 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3482
3483 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3484
3485 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3486
3487 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3488 zombies (Bug#8467).
3489
3490 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3491
3492 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3493 gl_state.e_property when gl_state.object is Qt.
3494
3495 * insdel.c (make_gap_larger): Remove limitation of buffer size
3496 to <= INT_MAX.
3497
3498 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3499
3500 * xdisp.c (lookup_glyphless_char_display)
3501 (produce_glyphless_glyph): Handle cons cell entry in
3502 glyphless-char-display.
3503 (Vglyphless_char_display): Document it.
3504
3505 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3506 glyphless-char-display.
3507
3508 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3509
3510 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3511
3512 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3513
3514 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3515 definition for no-X builds.
3516
3517 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3518
3519 Static checks with GCC 4.6.0 and non-default toolkits.
3520
3521 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3522
3523 * process.c (keyboard_bit_set): Define only if SIGIO.
3524 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3525 (send_process): Repair possible setjmp clobbering.
3526
3527 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3528
3529 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3530
3531 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3532
3533 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3534 Define only if needed.
3535
3536 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3537 by pacifying GCC about it. Maybe it's time to retire it?
3538 * xfaces.c (USG, __TIMEVAL__): Likewise.
3539
3540 * dispextern.h (struct redisplay_interface): Rename param
3541 to avoid shadowing.
3542 * termhooks.h (struct terminal): Likewise.
3543 * xterm.c (xembed_send_message): Likewise.
3544
3545 * insdel.c (make_gap_smaller): Define only if
3546 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3547
3548 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3549 it.
3550
3551 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3552 so that we aren't warned about unused symbols.
3553
3554 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3555
3556 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3557
3558 * xfns.c (x_real_positions): Mark locals as initialized.
3559
3560 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3561
3562 * xterm.c: Fix problems found by static analysis with other toolkits.
3563 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3564 (x_dispatch_event): Declare static if USE_GTK, and
3565 define if USE_GTK || USE_X_TOOLKIT.
3566 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3567 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3568 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3569 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3570
3571 * xmenu.c (menu_help_callback): Pointer type fixes.
3572 Use const pointers when pointing at readonly data. Avoid pointer
3573 signedness clashes.
3574 (FALSE): Remove unused macro.
3575 (update_frame_menubar): Remove unused decl.
3576
3577 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3578
3579 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3580 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3581 (single_menu_item): Rename local to avoid shadowing.
3582
3583 * keyboard.c (make_lispy_event): Remove unused local var.
3584
3585 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3586 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3587
3588 * bitmaps: Change bitmaps from unsigned char back to the X11
3589 compatible char. Avoid the old compiler warnings about
3590 out-of-range initializers by using, for example, '\xab' rather
3591 than 0xab.
3592
3593 * xgselect.c (xgselect_initialize): Check vs interface
3594 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3595
3596 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3597
3598 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3599 to read-only memory.
3600
3601 * fns.c (vector): Remove; this old hack is no longer needed.
3602
3603 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3604 Remove unused var.
3605 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3606
3607 * xrdb.c (x_load_resources): Omit unused local.
3608
3609 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3610 (x_window): Rename locals to avoid shadowing.
3611 (USG): Use the kludged USG macro, to pacify gcc.
3612
3613 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3614 (x_term_init): Remove local to avoid shadowing.
3615
3616 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3617
3618 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3619 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3620
3621 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3622
3623 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3624
3625 Fix regex.c, syntax.c and friends for buffers > 2GB.
3626 * syntax.h (struct gl_state_s): Declare character position members
3627 EMACS_INT.
3628
3629 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3630
3631 * textprop.c (verify_interval_modification, interval_of):
3632 Declare arguments EMACS_INT.
3633
3634 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3635 EMACS_INT.
3636
3637 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3638
3639 * indent.c (Fvertical_motion): Local variable it_start is now
3640 EMACS_INT.
3641
3642 * regex.c (re_match, re_match_2, re_match_2_internal)
3643 (bcmp_translate, regcomp, regexec, print_double_string)
3644 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3645 (re_compile_pattern, re_exec): Declare arguments and local
3646 variables `size_t' and `ssize_t' and return values `regoff_t', as
3647 appropriate.
3648 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3649 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3650 <compile_stack_type>: `size' and `avail' are now `size_t'.
3651
3652 * regex.h <regoff_t>: Use ssize_t, not int.
3653 (re_search, re_search_2, re_match, re_match_2): Arguments that
3654 specify buffer/string position and length are now ssize_t and
3655 size_t. Return type is regoff_t.
3656
3657 2011-04-16 Ben Key <bkey76@gmail.com>
3658
3659 * nsfont.m: Fixed bugs in ns_get_family and
3660 ns_descriptor_to_entity that were caused by using free to
3661 deallocate memory blocks that were allocated by xmalloc (via
3662 xstrdup). This caused Emacs to crash when compiled with
3663 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3664 --enable-checking=xmallocoverrun). xfree is now used to
3665 deallocate these memory blocks.
3666
3667 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3668
3669 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3670
3671 emacs_write: Accept and return EMACS_INT for sizes.
3672 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3673 et seq.
3674 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3675 Accept and return EMACS_INT.
3676 (emacs_gnutls_write): Return the number of bytes written on
3677 partial writes.
3678 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3679 (emacs_read, emacs_write): Remove check for negative size, as the
3680 Emacs source code has been audited now.
3681 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3682 (emacs_read, emacs_write): Use it.
3683 * process.c (send_process): Adjust to the new signatures of
3684 emacs_write and emacs_gnutls_write. Do not attempt to store
3685 a byte offset into an 'int'; it might overflow.
3686 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3687
3688 * sound.c: Don't assume sizes fit in 'int'.
3689 (struct sound_device.period_size, alsa_period_size):
3690 Return EMACS_INT, not int.
3691 (struct sound_device.write, vox_write, alsa_write):
3692 Accept EMACS_INT, not int.
3693 (wav_play, au_play): Use EMACS_INT to store sizes and to
3694 record read return values.
3695
3696 2011-04-15 Ben Key <bkey76@gmail.com>
3697
3698 * keyboard.c (Qundefined): Don't declare static since it is used
3699 in nsfns.m.
3700 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3701 static since they are used in nsfont.m.
3702
3703 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3704
3705 * process.c (Qprocessp): Don't declare static.
3706 * lisp.h (Qprocessp): Declare again.
3707
3708 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3709
3710 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3711
3712 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3713
3714 Improve C-level modularity by making more things 'static'.
3715
3716 Don't publish debugger-only interfaces to other modules.
3717 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3718 (verify_bytepos, count_markers): Move decls to the only modules
3719 that need them.
3720 * region-cache.h (pp_cache): Likewise.
3721 * window.h (check_all_windows): Likewise.
3722 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3723
3724 * sysdep.c (croak): Now static, if
3725 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3726 * syssignal.h (croak): Declare only if not static.
3727
3728 * alloc.c (refill_memory_reserve): Now static if
3729 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3730 * lisp.h (refill_memory_reserve): Declare only if not static.
3731
3732 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3733 Define only if USE_LUCID.
3734
3735 * xrdb.c (x_customization_string, x_rm_string): Now static.
3736
3737 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3738 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3739
3740 * xdisp.c (draw_row_with_mouse_face): Now static.
3741 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3742
3743 * window.h (check_all_windows): Mark externally visible.
3744
3745 * window.c (window_deletion_count): Now static.
3746
3747 * undo.c: Make symbols static if they're not exported.
3748 (last_undo_buffer, last_boundary_position, pending_boundary):
3749 Now static.
3750
3751 * textprop.c (interval_insert_behind_hooks): Now static.
3752 (interval_insert_in_front_hooks): Likewise.
3753
3754 * term.c: Make symbols static if they're not exported.
3755 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3756 (max_frame_lines, tty_set_terminal_modes):
3757 (tty_reset_terminal_modes, tty_turn_off_highlight):
3758 (get_tty_terminal): Now static.
3759 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3760 * termhooks.h (term_mouse_moveto): Do not declare if
3761 HAVE_WINDOW_SYSTEM.
3762 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3763 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3764
3765 * sysdep.c: Make symbols static if they're not exported.
3766 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3767 Now static.
3768 (sigprocmask_set, full_mask): Remove; unused.
3769 (wait_debugging): Mark as visible.
3770 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3771 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3772
3773 * syntax.c (syntax_temp): Define only if !__GNUC__.
3774
3775 * sound.c (current_sound_device, current_sound): Now static.
3776
3777 * search.c (searchbufs, searchbuf_head): Now static.
3778
3779 * scroll.c (scroll_cost): Remove; unused.
3780 * dispextern.h (scroll_cost): Remove decl.
3781
3782 * region-cache.h (pp_cache): Mark as externally visible.
3783
3784 * process.c: Make symbols static if they're not exported.
3785 (process_tick, update_tick, create_process, chan_process):
3786 (Vprocess_alist, proc_buffered_char, datagram_access):
3787 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3788 (deactivate_process): Mark defn as static, as well as decl.
3789 * lisp.h (create_process): Remove decl.
3790 * process.h (chan_process, Vprocess_alist): Remove decls.
3791
3792 * print.c: Make symbols static if they're not exported.
3793 (print_depth, new_backquote_output, being_printed, print_buffer):
3794 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3795 (print_interval, print_number_index, initial_stderr_stream):
3796 Now static.
3797 * lisp.h (Fprinc): Remove decl.
3798 (debug_output_compilation_hack): Mark as externally visible.
3799
3800 * sysdep.c (croak): Move decl from here to syssignal.h.
3801 * syssignal.h (croak): Put it here, so the API can be checked when
3802 'croak' is called from dissociate_if_controlling_tty.
3803
3804 * minibuf.c: Make symbols static if they're not exported.
3805 (minibuf_save_list, choose_minibuf_frame): Now static.
3806 * lisp.h (choose_minibuf_frame): Remove decl.
3807
3808 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3809
3810 * lread.c: Make symbols static if they're not exported.
3811 (read_objects, initial_obarray, oblookup_last_bucket_number):
3812 Now static.
3813 (make_symbol): Remove; unused.
3814 * lisp.h (initial_obarray, make_symbol): Remove decls.
3815
3816 * keyboard.c: Make symbols static if they're not exported.
3817 (single_kboard, recent_keys_index, total_keys, recent_keys):
3818 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3819 (this_single_command_key_start, echoing, last_auto_save):
3820 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3821 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3822 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3823 (Vlispy_mouse_stem, double_click_count):
3824 Now static.
3825 (force_auto_save_soon): Define only if SIGDANGER.
3826 (ignore_mouse_drag_p): Now static if
3827 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3828 (print_help): Remove; unused.
3829 (stop_character, last_timer_event): Mark as externally visible.
3830 * keyboard.h (ignore_mouse_drag_p): Declare only if
3831 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3832 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3833 * lisp.h (echoing): Remove decl.
3834 (force_auto_save_soon): Declare only if SIGDANGER.
3835 * xdisp.c (redisplay_window): Simplify code, to make it more
3836 obvious that ignore_mouse_drag_p is not accessed if !defined
3837 USE_GTK && !defined HAVE_NS.
3838
3839 * intervals.c: Make symbols static if they're not exported.
3840 (merge_properties_sticky, merge_interval_right, delete_interval):
3841 Now static.
3842 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3843
3844 * insdel.c: Make symbols static if they're not exported.
3845 However, leave prepare_to_modify_buffer alone. It's never
3846 called from outside this function, but that appears to be a bug.
3847 (combine_after_change_list, combine_after_change_buffer):
3848 (adjust_after_replace, signal_before_change): Now static.
3849 (adjust_after_replace_noundo): Remove; unused.
3850 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3851 (signal_before_change): Remove decls.
3852
3853 * indent.c (val_compute_motion, val_vmotion): Now static.
3854
3855 * image.c: Make symbols static if they're not exported.
3856 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3857 if USE_GTK.
3858 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3859 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3860
3861 * fringe.c (standard_bitmaps): Now static.
3862 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3863
3864 * frame.c: Make symbols static if they're not exported.
3865 (x_report_frame_params, make_terminal_frame): Now static.
3866 (get_frame_param): Now static, unless HAVE_NS.
3867 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3868 (x_get_resource_string): Remove; not used.
3869 * frame.h (make_terminal_frame, x_report_frame_params):
3870 (x_get_resource_string); Remove decls.
3871 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3872 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3873
3874 * font.c, fontset.c: Make symbols static if they're not exported.
3875 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3876 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3877 * font.c (font_close_object): Now static.
3878 * font.h (font_close_object): Remove.
3879 * fontset.c (FONTSET_OBJLIST): Remove.
3880 (free_realized_fontset) #if-0 the body, which does nothing.
3881 (face_suitable_for_char_p): #if-0, as it's never called.
3882 * fontset.h (face_suitable_for_char_p): Remove decl.
3883 * xfaces.c (face_at_string_position):
3884 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3885 since 0 is always ASCII.
3886
3887 * fns.c (weak_hash_tables): Now static.
3888
3889 * fileio.c: Make symbols static if they're not exported.
3890 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3891 (Vwrite_region_annotation_buffers): Now static.
3892
3893 * eval.c: Make symbols static if they're not exported.
3894 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3895 * lisp.h (backtrace_list): Remove decl.
3896
3897 * emacs.c: Make symbols static if they're not exported.
3898 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3899 (fatal_error_code, fatal_error_signal_hook, standard_args):
3900 Now static.
3901 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3902 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3903 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3904 * lisp.h (fatal_error_signal_hook): Remove decl.
3905 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3906
3907 * editfns.c: Move a (normally-unused) function to its only use.
3908 * editfns.c, lisp.h (get_operating_system_release): Remove.
3909 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3910 worth the hassle of breaking this out.
3911
3912 * xterm.c: Make symbols static if they're not exported.
3913 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3914 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3915 (x_destroy_window, x_delete_display):
3916 Now static.
3917 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3918 (x_mouse_leave): Remove; unused.
3919 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3920 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3921 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3922 Remove decls.
3923 (x_mouse_leave): Declare only if WINDOWSNT.
3924 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3925 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3926 USE_X_TOOLKIT.
3927
3928 * ftxfont.c: Make symbols static if they're not exported.
3929 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3930 HAVE_FREETYPE.
3931 * font.h (ftxfont_driver): Likewise.
3932
3933 * xfns.c: Make symbols static if they're not exported.
3934 (x_last_font_name, x_display_info_for_name):
3935 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3936 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3937 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3938 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3939 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3940 (last_show_tip_args): Now static.
3941 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3942 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3943 (x_screen_planes): Remove; unused.
3944 * dispextern.h (x_screen_planes): Remove decl.
3945
3946 * dispnew.c: Make symbols static if they're not exported.
3947 * dispextern.h (redraw_garbaged_frames, scrolling):
3948 (increment_row_positions): Remove.
3949 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3950 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3951 Now static.
3952 (redraw_garbaged_frames): Remove; unused.
3953
3954 * xfaces.c: Make symbols static if they're not exported.
3955 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3956 Remove decls.
3957 * xterm.h (defined_color): Remove decls.
3958 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3959 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3960 (menu_face_changed_default, defined_color, free_realized_face):
3961 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3962 (ascii_face_of_lisp_face): Remove; unused.
3963
3964 * xdisp.c: Make symbols static if they're not exported.
3965 * dispextern.h (scratch_glyph_row, window_box_edges):
3966 (glyph_to_pixel_coords, set_cursor_from_row):
3967 (get_next_display_element, set_iterator_to_next):
3968 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3969 (show_mouse_face): Remove decls
3970 * frame.h (message_buf_print): Likewise.
3971 * lisp.h (pop_message, set_message, check_point_in_composition):
3972 Likewise.
3973 * xterm.h (set_vertical_scroll_bar): Likewise.
3974 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3975 (message_buf_print, scratch_glyph_row, displayed_buffer):
3976 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3977 (get_next_display_element, show_mouse_face, window_box_edges):
3978 (frame_to_window_pixel_xy, check_point_in_composition):
3979 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3980 (glyph_to_pixel_coords): Remove; unused.
3981
3982 * dired.c (file_name_completion): Now static.
3983
3984 * dbusbind.c (xd_in_read_queued_messages): Now static.
3985
3986 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3987 * data.c (circular_list_error): Remove.
3988
3989 * commands.h (last_point_position, last_point_position_buffer):
3990 (last_point_position_window): Remove decls.
3991 * keyboard.c: Make these variables static.
3992
3993 * coding.h (coding, code_convert_region, encode_coding_gap):
3994 Remove decls.
3995 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3996 (iso_code_class, detect_coding, code_convert_region): Now static.
3997 (encode_coding_gap): Remove; unused.
3998
3999 * chartab.c (chartab_chars, chartab_bits): Now static.
4000
4001 * charset.h (charset_iso_8859_1): Remove decl.
4002 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4003 Now static.
4004
4005 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4006 * ccl.c (Vccl_program_table): Now static.
4007 (check_ccl_update): Remove; unused.
4008
4009 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4010 * category.h: ... from here.
4011 * category.c (check_category_table, set_category_set): Now static.
4012
4013 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4014 * lisp.h: Remove these decls.
4015
4016 * buffer.c (buffer_count): Remove unused var.
4017
4018 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4019 so that it's not optimized away.
4020 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4021 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4022 exported only to the debugger.
4023
4024 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4025 * atimer.h (run_all_atimers): Remove; not exported.
4026
4027 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4028 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4029 was inaccessible from Lisp.
4030 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4031 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4032
4033 alloc.c: Import and export fewer symbols, and remove unused items.
4034 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4035 is defined.
4036 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4037 it's not optimized away by whole-program optimization.
4038 (message_enable_multibyte, free_misc): Remove.
4039 (catchlist, handlerlist, mark_backtrace):
4040 Declare only if BYTE_MARK_STACK.
4041 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4042 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4043 (message_enable_multibyte): Remove decl.
4044 (free_misc, interval_free_list, float_block, float_block_index):
4045 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4046 (cons_free_list, last_marked_index):
4047 Now static.
4048 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4049 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4050 (mark_backtrace): Define only if BYTE_MARK_STACK.
4051 * xdisp.c (message_enable_multibyte): Now static.
4052
4053 Declare Lisp_Object Q* variables to be 'static' if not exported.
4054 This makes it easier for human readers (and static analyzers)
4055 to see whether these variables are used from other modules.
4056 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4057 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4058 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4059 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4060 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4061 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4062 * xmenu.c, xselect.c:
4063 Declare Q* vars static if they are not used in other modules.
4064 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4065 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4066 Remove decls of unexported vars.
4067 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4068
4069 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4070
4071 Make Emacs functions such as Fatom 'static' by default.
4072 This makes it easier for human readers (and static analyzers)
4073 to see whether these functions can be called from other modules.
4074 DEFUN now defines a static function. To make the function external
4075 so that it can be used in other C modules, use the new macro DEFUE.
4076 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4077 (Finit_image_library):
4078 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4079 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4080 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4081 Remove decls, since these functions are now static.
4082 (Funintern, Fget_internal_run_time): New decls, since these functions
4083 were already external.
4084
4085 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4086 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4087 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4088 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4089 * keyboard.c, keymap.c, lread.c:
4090 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4091 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4092 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4093 Mark functions with DEFUE instead of DEFUN,
4094 if they are used in other modules.
4095 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4096 decls for now-static functions.
4097 * buffer.h (Fdelete_overlay): Remove decl.
4098 * callproc.c (Fgetenv_internal): Mark as internal.
4099 * composite.c (Fremove_list_of_text_properties): Remove decl.
4100 (Fcomposition_get_gstring): New forward static decl.
4101 * composite.h (Fcomposite_get_gstring): Remove decl.
4102 * dired.c (Ffile_attributes): New forward static decl.
4103 * doc.c (Fdocumntation_property): New forward static decl.
4104 * eval.c (Ffetch_bytecode): New forward static decl.
4105 (Funintern): Remove extern decl; now in .h file where it belongs.
4106 * fileio.c (Fmake_symbolic_link): New forward static decl.
4107 * image.c (Finit_image_library): New forward static decl.
4108 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4109 * intervals.h (Fprevious_property_change):
4110 (Fremove_list_of_text_properties): Remove decls.
4111 * keyboard.c (Fthis_command_keys): Remove decl.
4112 (Fcommand_execute): New forward static decl.
4113 * keymap.c (Flookup_key): New forward static decl.
4114 (Fcopy_keymap): Now static.
4115 * keymap.h (Flookup_key): Remove decl.
4116 * process.c (Fget_process): New forward static decl.
4117 (Fprocess_datagram_address): Mark as internal.
4118 * syntax.c (Fsyntax_table_p): New forward static decl.
4119 (skip_chars): Remove duplicate decl.
4120 * textprop.c (Fprevious_property_change): New forward static decl.
4121 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4122 Now internal.
4123 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4124 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4125
4126 * editfns.c (Fformat): Remove unreachable code.
4127
4128 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4129
4130 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4131 change. (Bug#8496)
4132
4133 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4134
4135 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4136 when at ZV. (Bug#8487)
4137
4138 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4139
4140 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4141 (Bug#8437)
4142 * keyboard.c (parse_tool_bar_item): Likewise.
4143 * sound.c (sound_cleanup, alsa_close): Likewise.
4144 * termcap.c (tgetent): Likewise.
4145 * xfns.c (x_default_font_parameter): Likewise.
4146 * xsettings.c (read_and_apply_settings): Likewise.
4147
4148 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4149 (overrun_check_free): Protoize.
4150
4151 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4152
4153 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4154 since callers should never pass a negative size.
4155 Change the signature to match that of plain 'read' and 'write'; see
4156 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4157 * lisp.h: Update prototypes of emacs_write and emacs_read.
4158
4159 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4160
4161 * xdisp.c (redisplay_window): Don't try to determine the character
4162 position of the scroll margin if the window start point w->startp
4163 is outside the buffer's accessible region. (Bug#8468)
4164
4165 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4166
4167 Fix write-region and its subroutines for buffers > 2GB.
4168 * fileio.c (a_write, e_write): Modify declaration of arguments and
4169 local variables to support buffers larger than 2GB.
4170 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4171
4172 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4173 argument, local variables, and return value.
4174
4175 * lisp.h: Update prototypes of emacs_write and emacs_read.
4176
4177 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4178
4179 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4180
4181 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4182
4183 Fix more problems found by GCC 4.6.0's static checks.
4184
4185 * xdisp.c (vmessage): Use a better test for character truncation.
4186
4187 * charset.c (load_charset_map): <, not <=, for optimization,
4188 and to avoid potential problems with integer overflow.
4189 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4190 * casetab.c (set_identity, shuffle): Likewise.
4191 * editfns.c (Fformat): Likewise.
4192 * syntax.c (skip_chars): Likewise.
4193
4194 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4195 This also lets GCC 4.6.0 generate slightly better loop code.
4196
4197 * callint.c (Fcall_interactively): <, not <=, for optimization.
4198 (Fcall_interactively): Count the number of arguments produced,
4199 not the number of arguments given. This is simpler and lets GCC
4200 4.6.0 generate slightly better code.
4201
4202 * ftfont.c: Distingish more carefully between FcChar8 and char.
4203 The previous code passed unsigned char * to a functions like
4204 strlen and xstrcasecmp that expect char *, which does not
4205 conform to the C standard.
4206 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4207 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4208 char * when the C standard requires it.
4209
4210 * keyboard.c (read_char): Remove unused var.
4211
4212 * eval.c: Port to Windows vsnprintf (Bug#8435).
4213 Include <limits.h>.
4214 (SIZE_MAX): Define if the headers do not.
4215 (verror): Do not give up if vsnprintf returns a negative count.
4216 Instead, grow the buffer. This ports to Windows vsnprintf, which
4217 does not conform to C99. Problem reported by Eli Zaretskii.
4218 Also, simplify the allocation scheme, by avoiding the need for
4219 calling realloc, and removing the ALLOCATED variable.
4220
4221 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4222
4223 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4224 But keep the doprint source code for now, as we might revamp it
4225 and use it again (Bug#8435).
4226 * lisp.h (doprnt): Remove.
4227 * Makefile.in (base_obj): Remove doprnt.o.
4228 * deps.mk (doprnt.o): Remove.
4229
4230 error: Print 32- and 64-bit integers portably (Bug#8435).
4231 Without this change, on typical 64-bit hosts error ("...%d...", N)
4232 was used to print both 32- and 64-bit integers N, which relied on
4233 undefined behavior.
4234 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4235 New macro.
4236 * lisp.h (error, verror): Mark as printf-like functions.
4237 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4238 Report overflow in size calculations when allocating printf buffer.
4239 Do not truncate output string at its first null byte.
4240 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4241 Truncate the output at a character boundary, since vsnprintf does not
4242 do that.
4243 * charset.c (check_iso_charset_parameter): Convert internal
4244 character to string before calling 'error', since %c now has the
4245 printf meaning.
4246 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4247 overflow when computing char to be passed to 'error'. Do not
4248 pass Lisp_Object to 'error'; pass the integer instead.
4249 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4250 formatted with plain %d.
4251
4252 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4253
4254 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4255
4256 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4257
4258 * xterm.c (x_catch_errors): Remove duplicate declaration.
4259
4260 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4261
4262 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4263
4264 2011-04-10 Jim Meyering <meyering@redhat.com>
4265
4266 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4267 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4268 return ssize_t not "int", and use size_t as the buffer length.
4269 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4270 * gnutls.h: Update declarations.
4271 * process.c (read_process_output): Use ssize_t, to match.
4272 (send_process): Likewise.
4273
4274 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4275
4276 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4277
4278 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4279
4280 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4281 Use unsigned char, to match FcChar8 type definition.
4282
4283 * xterm.c (handle_one_xevent):
4284 * xmenu.c (create_and_show_popup_menu):
4285 * xselect.c (x_decline_selection_request)
4286 (x_reply_selection_request): Avoid type-punned deref of X events.
4287
4288 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4289
4290 Fix some uses of `int' instead of EMACS_INT.
4291 * search.c (string_match_1, fast_string_match)
4292 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4293 (scan_buffer, find_next_newline_no_quit)
4294 (find_before_next_newline, search_command, Freplace_match)
4295 (Fmatch_data): Make some `int' variables be EMACS_INT.
4296
4297 * xdisp.c (display_count_lines): 3rd argument and return value now
4298 EMACS_INT. All callers changed.
4299 (pint2hrstr): Last argument is now EMACS_INT.
4300
4301 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4302 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4303 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4304 (decode_coding_utf_16, decode_coding_emacs_mule)
4305 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4306 (decode_coding_ccl, decode_coding_charset)
4307 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4308 (decode_coding_iso_2022, decode_coding_emacs_mule)
4309 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4310 <char_offset, last_offset>: Declare EMACS_INT.
4311 (encode_coding_utf_8, encode_coding_utf_16)
4312 (encode_coding_emacs_mule, encode_invocation_designation)
4313 (encode_designation_at_bol, encode_coding_iso_2022)
4314 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4315 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4316 Declare EMACS_INT.
4317 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4318 (encode_invocation_designation): Last argument P_NCHARS is now
4319 EMACS_INT.
4320 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4321 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4322
4323 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4324 All users changed.
4325
4326 * ccl.c (Fccl_execute_on_string): Declare some variables
4327 EMACS_INT.
4328
4329 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4330
4331 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4332
4333 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4334
4335 * process.c (Fformat_network_address): Doc fix.
4336
4337 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4338
4339 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4340
4341 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4342
4343 * keyboard.c (read_char): Call Lisp function help-form-show,
4344 instead of using internal_with_output_to_temp_buffer.
4345 (Qhelp_form_show): New var.
4346 (syms_of_keyboard): Use DEFSYM macro.
4347
4348 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4349
4350 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4351
4352 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4353
4354 * process.c (Flist_processes): Remove to Lisp.
4355 (list_processes_1): Delete.
4356
4357 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4358
4359 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4360
4361 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4362
4363 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4364
4365 Fix more problems found by GCC 4.6.0's static checks.
4366
4367 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4368
4369 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4370
4371 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4372
4373 * xdisp.c (vmessage): Mark as a printf-like function.
4374
4375 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4376
4377 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4378
4379 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4380 printf-like functions.
4381 (tiff_load): Add casts to remove these marks before passing them
4382 to system-supplied API.
4383
4384 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4385
4386 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4387 This avoids several warnings with gcc -Wstrict-overflow.
4388 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4389 directly, rather than having caller test rule sign. This avoids
4390 some unnecessary tests.
4391 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4392 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4393 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4394
4395 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4396 (xfont_open): Avoid unnecessary tests.
4397
4398 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4399
4400 * composite.h, composite.c (composition_gstring_put_cache):
4401 Use EMACS_INT, not int, for length.
4402
4403 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4404 breaking out part of COMPOSITION_DECODE_RULE.
4405 (COMPOSITION_DECODE_RULE): Use it.
4406 * composite.c (get_composition_id): Remove unused local vars,
4407 by using the new macro.
4408
4409 * textprop.c (set_text_properties_1): Change while to do-while,
4410 since the condition is always true at first.
4411
4412 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4413 (interval_deletion_adjustment): Return unsigned value.
4414 All uses changed.
4415
4416 * process.c (list_processes_1, create_pty, read_process_output):
4417 (exec_sentinel): Remove vars that were set but not used.
4418 (create_pty): Remove unnecessary "volatile"s.
4419 (Fnetwork_interface_info): Avoid possibility of int overflow.
4420 (read_process_output): Do adaptive read buffering even if carryover.
4421 (read_process_output): Simplify nbytes computation if buffered.
4422
4423 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4424
4425 * syntax.c (scan_words): Remove var that was set but not used.
4426 (update_syntax_table): Use unsigned instead of int.
4427
4428 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4429 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4430 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4431
4432 * print.c (print_error_message): Avoid int overflow.
4433
4434 * font.c (font_list_entities): Redo for clarity,
4435 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4436
4437 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4438 (font_score): Avoid potential overflow in diff calculation.
4439
4440 * fns.c (substring_both): Remove var that is set but not used.
4441 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4442
4443 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4444
4445 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4446 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4447 can always succeed if overflow has undefined behavior.
4448
4449 * search.c (boyer_moore, wordify): Remove vars set but not used.
4450 (wordify): Omit three unnecessary tests.
4451
4452 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4453 All callers changed. This avoids the need for an unused var.
4454
4455 * casefiddle.c (casify_region): Remove var that is set but not used.
4456
4457 * dired.c (file_name_completion): Remove var that is set but not used.
4458
4459 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4460
4461 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4462 (Finsert_file_contents): Remove unnecessary code checking fd.
4463
4464 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4465 Check for integer overflow on size calculations.
4466
4467 * buffer.c (Fprevious_overlay_change): Remove var that is set
4468 but not used.
4469
4470 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4471 Remove vars that are set but not used.
4472 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4473 (timer_check_2): Mark vars as initialized.
4474
4475 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4476
4477 * image.c (lookup_image): Remove var that is set but not used.
4478 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4479
4480 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4481 that are set but not used.
4482
4483 * xfns.c (make_invisible_cursor): Don't return garbage
4484 if XCreateBitmapFromData fails (Bug#8410).
4485
4486 * xselect.c (x_get_local_selection, x_handle_property_notify):
4487 Remove vars that are set but not used.
4488
4489 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4490 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4491
4492 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4493 Remove var that is set but not used.
4494 (scroll_bar_windows_size): Now size_t, not int.
4495 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4496 Check for overflow.
4497
4498 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4499 (map_tty_color) [!defined MSDOS]: Likewise.
4500
4501 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4502
4503 * coding.c: Remove vars that are set but not used.
4504 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4505 All callers changed.
4506 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4507 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4508 (decode_coding_charset): Remove vars that are set but not used.
4509
4510 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4511 that is set but not used.
4512
4513 * print.c (print_object): Remove var that is set but not used.
4514
4515 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4516 The gnulib version avoids calling malloc in the usual case,
4517 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4518 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4519 * filelock.c (current_lock_owner): Likewise.
4520 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4521 * sysdep.c: Include allocator.h, careadlinkat.h.
4522 (emacs_no_realloc_allocator): New static constant.
4523 (emacs_readlink): New function.
4524 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4525 ../lib/careadlinkat.h.
4526
4527 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4528
4529 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4530 first non-nil return value).
4531
4532 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4533
4534 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4535 if not defined (Bug#8403).
4536
4537 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4538
4539 * xdisp.c (display_count_lines): Remove parameter `start',
4540 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4541 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4542 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4543 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4544 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4545 and thereabouts. All callers changed.
4546 (get_per_char_metric): Remove parameter `f', unused since
4547 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4548
4549 2011-04-02 Jim Meyering <meyering@redhat.com>
4550
4551 do not dereference NULL upon failed strdup
4552 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4553 (ns_get_family): Likewise.
4554
4555 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4556
4557 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4558
4559 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4560
4561 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4562 later (Bug#8403).
4563
4564 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4565
4566 Add lexical binding.
4567
4568 * window.c (Ftemp_output_buffer_show): New fun.
4569 (Fsave_window_excursion):
4570 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4571
4572 * lread.c (lisp_file_lexically_bound_p): New function.
4573 (Fload): Bind Qlexical_binding.
4574 (readevalloop): Remove `evalfun' arg.
4575 Bind Qinternal_interpreter_environment.
4576 (Feval_buffer): Bind Qlexical_binding.
4577 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4578 Mark as dynamic.
4579 (syms_of_lread): Declare `lexical-binding'.
4580
4581 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4582
4583 * keyboard.c (eval_dyn): New fun.
4584 (menu_item_eval_property): Use it.
4585
4586 * image.c (parse_image_spec): Use Ffunctionp.
4587
4588 * fns.c (concat, mapcar1): Accept byte-code-functions.
4589
4590 * eval.c (Fsetq): Handle lexical vars.
4591 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4592 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4593 (FletX, Flet): Obey lexical binding.
4594 (Fcommandp): Handle closures.
4595 (Feval): New `lexical' arg.
4596 (eval_sub): New function extracted from Feval. Use it almost
4597 everywhere where Feval was used. Look up vars in lexical env.
4598 Handle closures.
4599 (Ffunctionp): Move from subr.el.
4600 (Ffuncall): Handle closures.
4601 (apply_lambda): Remove `eval_flags'.
4602 (funcall_lambda): Handle closures and new byte-code-functions.
4603 (Fspecial_variable_p): New function.
4604 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4605 but without exporting it to Lisp.
4606
4607 * doc.c (Fdocumentation, store_function_docstring):
4608 * data.c (Finteractive_form): Handle closures.
4609
4610 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4611 interactive spec.
4612
4613 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4614 New byte-codes.
4615 (exec_byte_code): New function extracted from Fbyte_code to handle new
4616 calling convention for byte-code-functions. Add new byte-codes.
4617
4618 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4619
4620 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4621
4622 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4623
4624 * xdisp.c (redisplay_internal): Fix prototype.
4625
4626 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4627
4628 * xdisp.c (SCROLL_LIMIT): New macro.
4629 (try_scrolling): Use it when setting scroll_limit.
4630 Limit scrolling to 100 screen lines.
4631 (redisplay_window): Even when falling back on "recentering",
4632 position point in the window according to scroll-conservatively,
4633 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4634
4635 (try_scrolling): When point is above the window, allow searching
4636 as far as scroll_max, or one screenful, to compute vertical
4637 distance from PT to the scroll margin position. This prevents
4638 try_scrolling from unnecessarily failing when
4639 scroll-conservatively is set to a value slightly larger than the
4640 window height. Clean up the case of PT below the margin at bottom
4641 of window: scroll_max can no longer be INT_MAX. When aggressive
4642 scrolling is in use, don't let point enter the opposite scroll
4643 margin as result of the scroll.
4644 (syms_of_xdisp) <scroll-conservatively>: Document the
4645 threshold of 100 lines for never-recentering scrolling.
4646
4647 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4648
4649 * dispextern.h (move_it_by_lines):
4650 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4651 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4652 (message_log_check_duplicate): Remove parameters `prev_bol' and
4653 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4654 (redisplay_internal): Remove parameter `preserve_echo_area',
4655 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4656
4657 * indent.c (Fvertical_motion):
4658 * window.c (window_scroll_pixel_based, Frecenter):
4659 Don't pass `need_y_p' to `move_it_by_lines'.
4660
4661 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4662
4663 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4664 steal a few bits to be more compact.
4665 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4666 Remove unneeded casts.
4667
4668 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4669
4670 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4671
4672 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4673 binding" message (bug#7967).
4674
4675 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4676
4677 Fix more problems found by GCC 4.6.0's static checks.
4678
4679 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4680 Remove unused local var.
4681
4682 * editfns.c (Fmessage_box): Remove unused local var.
4683
4684 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4685 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4686 Omit unused local vars.
4687 * window.c (shrink_windows): Omit unused local var.
4688 * menu.c (digest_single_submenu): Omit unused local var.
4689 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4690 Omit unused local var.
4691
4692 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4693 Don't assume string length fits in int.
4694 (keyremap_step, read_key_sequence): Use size_t for sizes.
4695 (read_key_sequence): Don't check last_real_key_start redundantly.
4696
4697 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4698 instead of alloca (Bug#8344).
4699
4700 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4701 (Fbacktrace_frame): Don't assume nframes fits in int.
4702
4703 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4704
4705 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4706 concerns.
4707
4708 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4709
4710 * cm.c (calccost): Turn while-do into do-while, for clarity.
4711
4712 * keyboard.c (syms_of_keyboard): Use the same style as later
4713 in this function when indexing through an array. This also
4714 works around GCC bug 48267.
4715
4716 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4717
4718 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4719
4720 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4721 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4722
4723 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4724 This avoids undefined behavior on integer overflow, and is a bit
4725 more convenient anyway since it is compared to a size_t variable.
4726
4727 Variadic C functions now count arguments with size_t, not int.
4728 This avoids an unnecessary limitation on 64-bit machines, which
4729 caused (substring ...) to crash on large vectors (Bug#8344).
4730 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4731 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4732 All variadic functions and their callers changed accordingly.
4733 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4734 * data.c (arith_driver, float_arith_driver): Likewise.
4735 * editfns.c (general_insert_function): Likewise.
4736 * eval.c (struct backtrace.nargs, interactive_p)
4737 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4738 (funcall_lambda, mark_backtrace): Likewise.
4739 * fns.c (concat): Likewise.
4740 * frame.c (x_set_frame_parameters): Likewise.
4741 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4742 0 if not found, not -1. All callers changed.
4743
4744 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4745 (stack_copy_size): Now size_t, not int.
4746 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4747
4748 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4749
4750 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4751 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4752 All callers changed.
4753
4754 * lisp.h (multibyte_char_to_unibyte):
4755 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4756 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4757 * character.h (CHAR_TO_BYTE8):
4758 * cmds.c (internal_self_insert):
4759 * editfns.c (general_insert_function):
4760 * keymap.c (push_key_description):
4761 * search.c (Freplace_match):
4762 * xdisp.c (message_dolog, set_message_1): All callers changed.
4763
4764 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4765
4766 * keyboard.c (safe_run_hook_funcall): New function.
4767 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4768 don't set the hook to nil, but remove the offending function instead.
4769 (Qcommand_hook_internal): Remove, unused.
4770 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4771 Vcommand_hook_internal.
4772
4773 * eval.c (enum run_hooks_condition): Remove.
4774 (funcall_nil, funcall_not): New functions.
4775 (run_hook_with_args): Call each function through a `funcall' argument.
4776 Remove `cond' argument, now redundant.
4777 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4778 (Frun_hook_with_args_until_failure): Adjust accordingly.
4779 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4780
4781 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4782
4783 * dispextern.h (string_buffer_position): Remove declaration.
4784
4785 * print.c (strout): Remove parameter `multibyte', unused since
4786 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4787
4788 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4789 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4790 All callers changed.
4791
4792 * w32.c (_wsa_errlist): Use braces for struct initializers.
4793
4794 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4795 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4796 All callers changed.
4797 (string_buffer_position): Likewise. Also, make static (it's never
4798 used outside xdisp.c).
4799 (cursor_row_p): Remove parameter `w', unused since
4800 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4801 (decode_mode_spec): Remove parameter `precision', introduced during
4802 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4803 All callers changed.
4804
4805 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4806
4807 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4808
4809 2011-03-27 Anders Lindgren <andlind@gmail.com>
4810
4811 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4812 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4813 (ns_update_auto_hide_menu_bar): New functions.
4814 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4815 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4816 ns_constrain_all_frames.
4817 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4818 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4819
4820 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4821
4822 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4823
4824 2011-03-27 Glenn Morris <rgm@gnu.org>
4825
4826 * syssignal.h: Replace RETSIGTYPE with void.
4827 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4828 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4829 Replace SIGTYPE with void everywhere.
4830 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4831 * s/template.h (SIGTYPE): Remove commented out definition.
4832
4833 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4834
4835 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4836 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4837
4838 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4839
4840 * w32.c (read_unc_volume): Use parameter `henum', instead of
4841 global variable `wget_enum_handle'.
4842
4843 * keymap.c (describe_vector): Remove parameters `indices' and
4844 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4845 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4846
4847 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4848
4849 * keyboard.c (timer_check): Remove parameter `do_it_now',
4850 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4851 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4852 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4853
4854 * keyboard.c (read_char):
4855 * w32menu.c (w32_menu_display_help):
4856 * xmenu.c (show_help_event, menu_help_callback):
4857 Adjust calls to `show_help_echo'.
4858
4859 * gtkutil.c (xg_maybe_add_timer):
4860 * keyboard.c (readable_events):
4861 * process.c (wait_reading_process_output):
4862 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4863
4864 * insdel.c (adjust_markers_gap_motion):
4865 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4866 (gap_left, gap_right): Don't call it.
4867
4868 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4869
4870 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4871 incurred during fontification.
4872
4873 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4874
4875 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4876 (DEFVAR_PER_BUFFER): Don't pass it.
4877
4878 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4879 (scrolling_window): Don't pass it.
4880
4881 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4882
4883 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4884
4885 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4886 and `suffix'.
4887 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4888 of variables specific to SELinux and computation of `encoded_absname'.
4889
4890 * image.c (XPutPixel): Remove unused variable `height'.
4891
4892 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4893
4894 * unexw32.c (get_section_info): Remove unused variable `section'.
4895
4896 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4897 (system_process_attributes): Remove unused variable `sess'.
4898 (sys_read): Remove unused variable `err'.
4899
4900 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4901 (w32_wnd_proc): Remove unused variable `isdead'.
4902 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4903 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4904 (x_create_tip_frame): Remove unused variable `tem'.
4905
4906 * w32inevt.c (w32_console_read_socket):
4907 Remove unused variable `no_events'.
4908
4909 * w32term.c (x_draw_composite_glyph_string_foreground):
4910 Remove unused variable `width'.
4911
4912 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4913
4914 * w32term.c (x_set_glyph_string_clipping):
4915 Don't pass uninitialized region to CombineRgn.
4916
4917 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4918
4919 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4920 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4921 (Fx_close_connection): Remove unused variable `i'.
4922
4923 * w32font.c (w32font_draw): Return number of glyphs.
4924 (w32font_open_internal): Remove unused variable `i'.
4925 (w32font_driver): Add missing initializer.
4926
4927 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4928 (fill_in_menu): Remove unused variable `items_added'.
4929
4930 * w32term.c (last_mouse_press_frame): Remove static global variable.
4931 (w32_clip_to_row): Remove unused variable `f'.
4932 (x_delete_terminal): Remove unused variable `i'.
4933
4934 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4935 (NOTHING): Remove unused static global variable.
4936 (uniscribe_check_otf): Remove unused variable `table'.
4937 (uniscribe_font_driver): Add missing initializers.
4938
4939 2011-03-23 Julien Danjou <julien@danjou.info>
4940
4941 * term.c (Fsuspend_tty, Fresume_tty):
4942 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4943 * window.c (temp_output_buffer_show):
4944 * insdel.c (signal_before_change):
4945 * frame.c (Fhandle_switch_frame):
4946 * fileio.c (Fdo_auto_save):
4947 * emacs.c (Fkill_emacs):
4948 * editfns.c (save_excursion_restore):
4949 * cmds.c (internal_self_insert):
4950 * callint.c (Fcall_interactively):
4951 * buffer.c (Fkill_all_local_variables):
4952 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4953 Use Frun_hooks.
4954 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4955 unconditionnaly since it does the check itself.
4956
4957 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4958
4959 Fix more problems found by GCC 4.5.2's static checks.
4960
4961 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4962 the first time through the loop, since we know p0 < p1 then.
4963 This also avoids a gcc -Wstrict-overflow warning.
4964
4965 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4966 leading to a memory leak, possible in functions like
4967 load_charset_map_from_file that can allocate an unbounded number
4968 of objects (Bug#8318).
4969
4970 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4971 that could (at least in theory) be that large.
4972
4973 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4974 This is less likely to overflow, and avoids undefined behavior if
4975 overflow does occur. All callers changed. Use strtoul to scan
4976 for the unsigned long integer.
4977 (pint2hrstr): Simplify and tune code slightly.
4978 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4979
4980 * scroll.c (do_scrolling): Work around GCC bug 48228.
4981 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4982
4983 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4984 This also avoids a warning with gcc -Wstrict-overflow.
4985 (validate_x_resource_name): Simplify count usage.
4986 This also avoids a warning with gcc -Wstrict-overflow.
4987
4988 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4989 fail (Bug#8306).
4990
4991 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4992
4993 * process.c (Fmake_network_process): Use socklen_t, not int,
4994 where POSIX says socklen_t is required in portable programs.
4995 This fixes a porting bug on hosts like 64-bit HP-UX, where
4996 socklen_t is wider than int (Bug#8277).
4997 (Fmake_network_process, server_accept_connection):
4998 (wait_reading_process_output, read_process_output):
4999 Likewise.
5000
5001 * process.c: Rename or move locals to avoid shadowing.
5002 (list_processes_1, Fmake_network_process):
5003 (read_process_output_error_handler, exec_sentinel_error_handler):
5004 Rename or move locals.
5005 (Fmake_network_process): Define label "retry_connect" only if needed.
5006 (Fnetwork_interface_info): Fix pointer signedness.
5007 (process_send_signal): Add cast to avoid pointer signedness problem.
5008 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5009 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5010
5011 Make tparam.h and terminfo.c consistent.
5012 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5013 Include tparam.h instead, since it declares them.
5014 * cm.h (PC): Remove extern decl; tparam.h now does this.
5015 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5016 * terminfo.c: Include tparam.h, to check interfaces.
5017 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5018 (tparam): Adjust signature to match interface in tparam.h;
5019 this removes some undefined behavior. Check that outstring and len
5020 are zero, which they always are with Emacs.
5021 * tparam.h (PC, BC, UP): New extern decls.
5022
5023 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5024 (xftfont_open): Rename locals to avoid shadowing.
5025
5026 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5027 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5028 (OTF_TAG_SYM): Omit macro if not needed.
5029 (ftfont_list): Remove unused local.
5030 (get_adstyle_property, ftfont_pattern_entity):
5031 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5032 Rename locals to avoid shadowing.
5033
5034 * xfont.c (xfont_list_family): Mark var as initialized.
5035
5036 * xml.c (make_dom): Now static.
5037
5038 * composite.c (composition_compute_stop_pos): Rename local to
5039 avoid shadowing.
5040 (composition_reseat_it): Remove unused locals.
5041 (find_automatic_composition, composition_adjust_point): Likewise.
5042 (composition_update_it): Mark var as initialized.
5043 (find_automatic_composition): Mark vars as initialized,
5044 with a FIXME (Bug#8290).
5045
5046 character.h: Rename locals to avoid shadowing.
5047 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5048 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5049 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5050 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5051 to avoid shadowing.
5052
5053 * textprop.c (property_change_between_p): Remove; unused.
5054
5055 * intervals.c (interval_start_pos): Now static.
5056
5057 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5058
5059 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5060 Rename locals to avoid shadowing.
5061
5062 * sound.c (wav_play, au_play, Fplay_sound_internal):
5063 Fix pointer signedness.
5064 (alsa_choose_format): Remove unused local var.
5065 (wav_play): Initialize a variable to 0, to prevent undefined
5066 behavior (Bug#8278).
5067
5068 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5069
5070 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5071
5072 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5073 clobbering (Bug#8298).
5074 * sysdep.c (sys_subshell): Likewise.
5075 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5076
5077 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5078 This should get cleaned up, so that child_setup has the
5079 same signature on all platforms.
5080
5081 * callproc.c (call_process_cleanup): Now static.
5082 (relocate_fd): Rename locals to avoid shadowing.
5083
5084 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5085
5086 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5087 not to be necessary, and produces flickering.
5088
5089 2011-03-20 Glenn Morris <rgm@gnu.org>
5090
5091 * config.in: Remove file.
5092
5093 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5094
5095 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5096 are now in src/globals.h.
5097 (syms_of_minibuf): Remove spurious & from previous change.
5098
5099 2011-03-20 Leo <sdl.web@gmail.com>
5100
5101 * minibuf.c (completing-read-function): New variable.
5102 (completing-read-default): Rename from completing-read.
5103 (completing-read): Call completing-read-function.
5104
5105 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5106
5107 * xfaces.c (Fx_load_color_file):
5108 Read color file from absolute filename (bug#8250).
5109
5110 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5111
5112 * makefile.w32-in: Update dependencies.
5113
5114 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5115
5116 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5117
5118 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5119
5120 Fix more problems found by GCC 4.5.2's static checks.
5121
5122 * process.c (make_serial_process_unwind, send_process_trap):
5123 (sigchld_handler): Now static.
5124
5125 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5126 That way, the code declares only the vars that it needs.
5127 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5128 * s/cygwin.h (PTY_ITERATION): Likewise.
5129 * s/darwin.h (PTY_ITERATION): Likewise.
5130 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5131
5132 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5133 * process.c (allocate_pty): Don't declare stb unless it's needed.
5134
5135 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5136 (CONSTANTLIM): Remove; unused.
5137 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5138 Define only if needed.
5139
5140 * unexelf.c (unexec): Name an expression,
5141 to avoid gcc -Wbad-function-cast warning.
5142 Use a different way to cause a compilation error if anyone uses
5143 n rather than nn, a way that does not involve shadowing.
5144 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5145
5146 * deps.mk (unexalpha.o): Remove; unused.
5147
5148 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5149 * unexec.h: New file.
5150 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5151 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5152 Depend on unexec.h.
5153 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5154 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5155 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5156 Change as necessary to match prototype in unexec.h.
5157
5158 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5159 shadowing.
5160 (back_comment, skip_chars): Mark vars as initialized.
5161
5162 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5163 Rename locals to avoid shadowing.
5164
5165 * lread.c (read1): Rewrite so as not to use empty "else".
5166 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5167
5168 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5169
5170 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5171 warning when compiling print.c.
5172
5173 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5174 instead of using an uninitialized var.
5175 (font_sort_entities): Mark var as initialized.
5176
5177 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5178
5179 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5180 pointers to constants.
5181 (font_parse_fcname): Remove unused vars.
5182 (font_delete_unmatched): Now static.
5183 (font_get_spec): Remove; unused.
5184 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5185 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5186 Rename or move locals to avoid shadowing.
5187
5188 * fns.c (require_nesting_list, require_unwind): Now static.
5189 (Ffillarray): Rename locals to avoid shadowing.
5190
5191 * floatfns.c (domain_error2): Define only if needed.
5192 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5193
5194 * alloc.c (mark_backtrace): Move decl from here ...
5195 * lisp.h: ... to here, so that it can be checked.
5196
5197 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5198 (Fdefvar): Rewrite so as not to use empty "else".
5199 (lisp_indirect_variable): Name an expression,
5200 to avoid gcc -Wbad-function-cast warning.
5201 (Fdefvar): Rename locals to avoid shadowing.
5202
5203 * callint.c (quotify_arg, quotify_args): Now static.
5204 (Fcall_interactively): Rename locals to avoid shadowing.
5205 Use const pointer when appropriate.
5206
5207 * lisp.h (get_system_name, get_operating_system_release):
5208 Move decls here, to check interfaces.
5209 * process.c (get_operating_system_release): Move decl to lisp.h.
5210 * xrdb.c (get_system_name): Likewise.
5211 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5212 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5213 some of which prompt warnings from gcc -Wbad-function-cast.
5214 (Fformat_time_string, Fencode_time, Finsert_char):
5215 (Ftranslate_region_internal, Fformat):
5216 Rename or remove local vars to avoid shadowing.
5217 (Ftranslate_region_internal): Mark var as initialized.
5218
5219 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5220 avoid shadowing.
5221
5222 * lisp.h (eassert): Check that the argument compiles, even if
5223 ENABLE_CHECKING is not defined.
5224
5225 * data.c (Findirect_variable): Name an expression, to avoid
5226 gcc -Wbad-function-cast warning.
5227 (default_value, arithcompare, arith_driver, arith_error): Now static.
5228 (store_symval_forwarding): Rename local to avoid shadowing.
5229 (Fmake_variable_buffer_local, Fmake_local_variable):
5230 Mark variables as initialized.
5231 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5232
5233 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5234 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5235 Rename locals to avoid shadowing.
5236 (mark_stack): Move local variables into the #ifdef region where
5237 they're used.
5238 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5239 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5240 needed otherwise.
5241 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5242 (GC_STRING_CHARS): Remove; not used.
5243 (Fmemory_limit): Cast sbrk's returned value to char *.
5244
5245 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5246 avoids undefined behavior in theory.
5247
5248 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5249
5250 Use functions, not macros, for up- and down-casing (Bug#8254).
5251 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5252 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5253 to use the following functions instead of these macros.
5254 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5255 EMACS_INT, since callers assume the returned value fits in int.
5256 (upcase1): Likewise, for UPCASE_TABLE.
5257 (uppercasep, lowercasep, upcase): New static inline functions.
5258 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5259 the race-condition problem in the old DOWNCASE.
5260
5261 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5262 Rename locals to avoid shadowing.
5263 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5264 (regex_compile, re_search_2, re_match_2_internal):
5265 Remove unused local vars.
5266 (FREE_VAR): Rewrite so as not to use empty "else",
5267 which gcc can warn about.
5268 (regex_compile, re_match_2_internal): Mark locals as initialized.
5269 (RETALLOC_IF): Define only if needed.
5270 (WORDCHAR_P): Likewise. This one is never needed, but is used
5271 only in a comment talking about a compiler bug, so put inside
5272 the #if 0 of that comment.
5273 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5274 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5275 Remove; unused.
5276
5277 * search.c (boyer_moore): Rename locals to avoid shadowing.
5278 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5279 (PREV_CHAR_BOUNDARY): Likewise.
5280
5281 * search.c (simple_search): Remove unused var.
5282
5283 * dired.c (compile_pattern): Move decl from here ...
5284 * lisp.h: ... to here, so that it can be checked.
5285 (struct re_registers): New forward decl.
5286
5287 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5288
5289 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5290 All uses changed.
5291 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5292 Rename locals to avoid shadowing.
5293 (Fvertical_motion): Mark locals as initialized.
5294
5295 * casefiddle.c (casify_object, casify_region): Now static.
5296 (casify_region): Mark local as initialized.
5297
5298 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5299
5300 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5301 New macros, so that the caller can use some names other than
5302 gcpro1, gcpro2, etc.
5303 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5304 of the new macros.
5305 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5306 argument, for consistency with GCPRO2_VAR, etc: it is now the
5307 prefix of the variable, not the variable itself. All uses
5308 changed.
5309 * dired.c (directory_files_internal, file_name_completion):
5310 Rename locals to avoid shadowing.
5311
5312 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5313 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5314 dired.c's scmp function, had undefined behavior.
5315 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5316 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5317 * buffer.h: ... to here, because these macros use current_buffer,
5318 and the new implementation with inline functions needs to have
5319 current_buffer in scope now, rather than later when the macros
5320 are used.
5321 (downcase, upcase1): New static inline functions.
5322 (DOWNCASE, UPCASE1): Reimplement using these functions.
5323 This avoids undefined behavior in expressions like
5324 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5325 from race conditions in accessing the global variables
5326 case_temp1 and case_temp2.
5327 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5328 * lisp.h (case_temp1, case_temp2): Remove their decls.
5329 * character.h (ASCII_CHAR_P): Move from here ...
5330 * lisp.h: ... to here, so that the inline functions mentioned
5331 above can use them.
5332
5333 * dired.c (directory_files_internal_unwind): Now static.
5334
5335 * fileio.c (file_name_as_directory, directory_file_name):
5336 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5337 Now static.
5338 (file_name_as_directory): Use const pointers when appropriate.
5339 (Fexpand_file_name): Likewise. In particular, newdir might
5340 point at constant storage, so make it a const pointer.
5341 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5342 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5343 signedness issues.
5344 (Fset_file_times, Finsert_file_contents, auto_save_error):
5345 Rename locals to avoid shadowing.
5346
5347 * minibuf.c (choose_minibuf_frame_1): Now static.
5348 (Ftry_completion, Fall_completions): Rename or remove locals
5349 to avoid shadowing.
5350
5351 * marker.c (bytepos_to_charpos): Remove; unused.
5352
5353 * lisp.h (verify_bytepos, count_markers): New decls,
5354 so that gcc does not warn that these functions aren't declared.
5355
5356 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5357 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5358 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5359 (copy_text): Remove unused local var.
5360
5361 * filelock.c (within_one_second): Now static.
5362 (lock_file_1): Rename local to avoid shadowing.
5363
5364 * buffer.c (fix_overlays_before): Mark locals as initialized.
5365 (fix_start_end_in_overlays): Likewise. This function should be
5366 simplified by using pointers-to-pointers, but that's a different
5367 matter.
5368 (switch_to_buffer_1): Now static.
5369 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5370 (report_overlay_modification): Rename locals to avoid shadowing.
5371
5372 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5373 Fix pointer signedness issue.
5374 (sys_subshell): Mark local as volatile if checking for lint,
5375 to suppress a gcc -Wclobbered warning that does not seem to be right.
5376 (MAXPATHLEN): Define only if needed.
5377
5378 * process.c (serial_open, serial_configure): Move decls from here ...
5379 * systty.h: ... to here, so that they can be checked.
5380
5381 * fns.c (get_random, seed_random): Move extern decls from here ...
5382 * lisp.h: ... to here, so that they can be checked.
5383
5384 * sysdep.c (reset_io): Now static.
5385 (wait_for_termination_signal): Remove; unused.
5386
5387 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5388 (copy_keymap_item, append_key, push_text_char_description):
5389 Now static.
5390 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5391 (DENSE_TABLE_SIZE): Remove; unused.
5392 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5393 (describe_map_tree):
5394 Rename locals to avoid shadowing.
5395
5396 * keyboard.c: Declare functions static if they are not used elsewhere.
5397 (echo_char, echo_dash, cmd_error, top_level_2):
5398 (poll_for_input, handle_async_input): Now static.
5399 (read_char, kbd_buffer_get_event, make_lispy_position):
5400 (make_lispy_event, make_lispy_movement, apply_modifiers):
5401 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5402 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5403 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5404 (read_key_sequence, read_char): Mark locals as initialized.
5405 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5406
5407 * keyboard.h (make_ctrl_char): New decl.
5408 (mark_kboards): Move decl here ...
5409 * alloc.c (mark_kboards): ... from here.
5410
5411 * lisp.h (force_auto_save_soon): New decl.
5412
5413 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5414 (DEFINE_DUMMY_FUNCTION): New macro.
5415 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5416 Use it.
5417 (main): Add casts to avoid warnings
5418 if GCC considers string literals to be constants.
5419
5420 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5421
5422 * dbusbind.c: Pointer signedness fixes.
5423 (xd_signature, xd_append_arg, xd_initialize):
5424 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5425 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5426 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5427 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5428
5429 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5430 if GCC considers string literals to be constants.
5431 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5432
5433 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5434
5435 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5436 (print_preprocess, print_object): New macro to fix last change.
5437
5438 * print.c (print_preprocess): Don't forget font objects.
5439
5440 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5441
5442 * emacs.c (USAGE3): Doc fixes.
5443
5444 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5445
5446 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5447 structure.
5448
5449 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5450
5451 * lisp.h (VWindow_system, Qfile_name_history):
5452 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5453 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5454 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5455
5456 * w32select.c: Don't #include "keyboard.h".
5457 (run_protected): Add extern declaration for waiting_for_input.
5458
5459 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5460 * w32console.c (detect_input_pending, read_input_pending)
5461 (encode_terminal_code):
5462 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5463 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5464 (w32_system_caret_y, Qfile_name_history):
5465 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5466 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5467 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5468 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5469 * w32proc.c (Qlocal, report_file_error):
5470 * w32term.c (Vwindow_system, updating_frame):
5471 * w32uniscribe.c (initialized, uniscribe_font_driver):
5472 Remove unneeded extern declarations.
5473
5474 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5475
5476 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5477
5478 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5479
5480 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5481 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5482 These macros can no longer be used for assignment.
5483
5484 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5485 Assign struct members directly, instead of using BUF_BEGV etc.
5486 (record_buffer_markers, fetch_buffer_markers): New functions for
5487 recording and fetching special buffer markers.
5488 (set_buffer_internal_1, set_buffer_temp): Use them.
5489
5490 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5491
5492 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5493
5494 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5495 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5496
5497 * xdisp.c (hscroll_window_tree):
5498 (reconsider_clip_changes): Use PT instead of BUF_PT.
5499
5500 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5501
5502 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5503 $(EMACS_ROOT)/lib/intprops.h.
5504
5505 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5506
5507 Fix more problems found by GCC 4.5.2's static checks.
5508
5509 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5510 to unsigned char * to avoid compiler diagnostic.
5511 (xg_free_frame_widgets): Make it clear that a local variable is
5512 needed only if USE_GTK_TOOLTIP.
5513 (gdk_window_get_screen): Make it clear that this macro is needed
5514 only if USE_GTK_TOOLTIP.
5515 (int_gtk_range_get_value): New function, which avoids a diagnostic
5516 from gcc -Wbad-function-cast.
5517 (xg_set_toolkit_scroll_bar_thumb): Use it.
5518 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5519 diagnostic from gcc -Wbad-function-cast.
5520 (get_utf8_string, xg_get_file_with_chooser):
5521 Rename locals to avoid shadowing.
5522 (create_dialog): Move locals to avoid shadowing.
5523
5524 * xgselect.c (xg_select): Remove unused var.
5525
5526 * image.c (four_corners_best): Mark locals as initialized.
5527 (gif_load): Initialize transparent_p to zero (Bug#8238).
5528 Mark another local as initialized.
5529 (my_png_error, my_error_exit): Mark with NO_RETURN.
5530
5531 * image.c (clear_image_cache): Now static.
5532 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5533 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5534 (x_edge_detection): Remove unnecessary cast that
5535 gcc -Wbad-function-cast diagnoses.
5536 (gif_load): Fix pointer signedness.
5537 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5538 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5539
5540 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5541
5542 Improve quality of tests for time stamp overflow.
5543 For example, without this patch (encode-time 0 0 0 1 1
5544 1152921504606846976) returns the obviously-bogus value (-948597
5545 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5546 reports time overflow. See
5547 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5548 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5549 * editfns.c: Include limits.h and intprops.h.
5550 (TIME_T_MIN, TIME_T_MAX): New macros.
5551 (time_overflow): Move earlier, to before first use.
5552 (hi_time, lo_time): New functions, for an accurate test for
5553 out-of-range times.
5554 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5555 (Fget_internal_run_time): Don't assume time_t fits in int.
5556 (make_time): Use list2 instead of Fcons twice.
5557 (Fdecode_time): More accurate test for out-of-range times.
5558 (check_tm_member): New function.
5559 (Fencode_time): Use it, to test for out-of-range times.
5560 (lisp_time_argument): Don't rely on undefined left-shift and
5561 right-shift behavior when checking for time stamp overflow.
5562
5563 * editfns.c (time_overflow): New function, refactoring common code.
5564 (Fformat_time_string, Fdecode_time, Fencode_time):
5565 (Fcurrent_time_string): Use it.
5566
5567 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5568 * dired.c (make_time): Move to ...
5569 * editfns.c (make_time): ... here.
5570 * systime.h: Note the move.
5571
5572 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5573
5574 * fringe.c (update_window_fringes): Remove unused variables.
5575
5576 * unexmacosx.c (copy_data_segment): Also copy __got section.
5577 (Bug#8223)
5578
5579 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5580
5581 * termcap.c [MSDOS]: Include "msdos.h".
5582 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5583 Constify `char *' arguments and their references according to
5584 prototypes in tparam.h.
5585
5586 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5587
5588 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5589 Adapt all references accordingly.
5590
5591 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5592
5593 2011-03-11 Tom Tromey <tromey@redhat.com>
5594
5595 * buffer.c (syms_of_buffer): Remove obsolete comment.
5596
5597 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5598
5599 * termhooks.h (encode_terminal_code): Declare prototype.
5600
5601 * msdos.c (encode_terminal_code): Don't declare prototype.
5602
5603 * term.c (encode_terminal_code): Now external again, used by
5604 w32console.c and msdos.c.
5605
5606 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5607 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5608
5609 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5610
5611 Fix some minor problems found by GCC 4.5.2's static checks.
5612
5613 * fringe.c (update_window_fringes): Mark locals as initialized
5614 (Bug#8227).
5615 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5616
5617 * alloc.c (mark_fringe_data): Move decl from here ...
5618 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5619 to check its interface.
5620 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5621
5622 * fontset.c (free_realized_fontset): Now static.
5623 (Fset_fontset_font): Rename local to avoid shadowing.
5624 (fontset_font): Mark local as initialized.
5625 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5626
5627 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5628
5629 * xselect.c (x_disown_buffer_selections): Remove; not used.
5630 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5631 (x_own_selection, Fx_disown_selection_internal): Rename locals
5632 to avoid shadowing.
5633 (x_handle_dnd_message): Remove local to avoid shadowing.
5634
5635 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5636 so that the caller can use some name other than gcpro1.
5637 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5638 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5639 (Fx_backspace_delete_keys_p):
5640 Use them to avoid shadowing, and rename vars to avoid shadowing.
5641 (x_decode_color, x_set_name, x_window): Now static.
5642 (Fx_create_frame): Add braces to silence GCC warning.
5643 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5644 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5645 Remove unused locals.
5646 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5647 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5648 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5649 macros.
5650
5651 * xterm.h (x_mouse_leave): New decl.
5652
5653 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5654 Remove unused functions.
5655 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5656 (x_calc_absolute_position): Now static.
5657 (XTread_socket): Don't define label "out" unless it's used.
5658 Don't declare local "event" unless it's used.
5659 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5660 unless they are used.
5661 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5662 (x_fatal_error_signal): Remove; not used.
5663 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5664 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5665 (x_error_catcher, x_connection_closed, x_error_handler):
5666 (x_error_quitter, xembed_send_message, x_iconify_frame):
5667 (my_log_handler): Rename locals to avoid shadowing.
5668 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5669 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5670
5671 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5672 Rename or move locals to avoid shadowing.
5673 (tty_defined_color, merge_face_heights): Now static.
5674 (free_realized_faces_for_fontset): Remove; not used.
5675 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5676 does not deduce is never used uninitialized.
5677 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5678 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5679
5680 * terminal.c (store_terminal_param): Now static.
5681
5682 * xmenu.c (menu_highlight_callback): Now static.
5683 (set_frame_menubar): Remove unused local.
5684 (xmenu_show): Rename parameter to avoid shadowing.
5685 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5686 since they might point to immutable storage.
5687 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5688 since it's unused otherwise.
5689
5690 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5691 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5692 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5693 avoids a gcc -Wuninitialized diagnostic.
5694 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5695 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5696 does not deduce are never used uninitialized.
5697
5698 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5699
5700 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5701 * window.c (window_loop, size_window):
5702 (run_window_configuration_change_hook, enlarge_window): Likewise.
5703
5704 * window.c (display_buffer): Now static.
5705 (size_window): Mark variables that gcc -Wuninitialized
5706 does not deduce are never used uninitialized.
5707 * window.h (check_all_windows): New decl, to forestall
5708 gcc -Wmissing-prototypes diagnostic.
5709 * dispextern.h (bidi_dump_cached_states): Likewise.
5710
5711 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5712 shadowing.
5713 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5714 Include <limits.h>.
5715 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5716 and to avoid gcc -Wuninitialized warning.
5717 (load_charset_map): Mark variables that gcc -Wuninitialized
5718 does not deduce are never used uninitialized.
5719 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5720
5721 * coding.c (coding_set_source, coding_set_destination):
5722 Use "else { /* comment */ }" rather than "else /* comment */;"
5723 for clarity, and to avoid gcc -Wempty-body warning.
5724 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5725 a block, when the outer 'i' will do.
5726 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5727 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5728 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5729 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5730 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5731 Rename locals to avoid shadowing.
5732 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5733 * coding.c (emacs_mule_char, encode_invocation_designation):
5734 Now static, since they're not used elsewhere.
5735 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5736 (decode_coding_object, encode_coding_object, detect_coding_system):
5737 (decode_coding_emacs_mule): Mark variables that gcc
5738 -Wuninitialized does not deduce are never used uninitialized.
5739 (detect_coding_iso_2022): Initialize a local variable that might
5740 be used uninitialized. Leave a FIXME because it's not clear that
5741 this initialization is needed. (Bug#8211)
5742 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5743 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5744 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5745 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5746 Remove unused macros.
5747
5748 * category.c (hash_get_category_set): Remove unused local var.
5749 (copy_category_table): Now static, since it's not used elsewhere.
5750 * character.c (string_count_byte8): Likewise.
5751
5752 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5753 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5754
5755 * chartab.c (copy_sub_char_table): Now static, since it's not used
5756 elsewhere.
5757 (sub_char_table_ref_and_range, char_table_ref_and_range):
5758 Rename locals to avoid shadowing.
5759 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5760
5761 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5762 (BIDI_BOB): Remove unused macro.
5763
5764 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5765 deduce are never used uninitialized.
5766 * term.c (encode_terminal_code): Likewise.
5767
5768 * term.c (encode_terminal_code): Now static. Remove unused local.
5769
5770 * tparam.h: New file.
5771 * term.c, tparam.h: Include it.
5772 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5773 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5774 Move these decls to tparam.h, and make them agree with what
5775 is actually in tparam.c. The previous trick of using incompatible
5776 decls in different modules does not conform to the C standard.
5777 All callers of tparam changed to use tparam's actual API.
5778 * tparam.c (tparam1, tparam, tgoto):
5779 Use const pointers where appropriate.
5780
5781 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5782 * cm.h (struct cm): Likewise.
5783 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5784 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5785 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5786 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5787 (turn_on_face, init_tty): Likewise.
5788 * termchar.h (struct tty_display_info): Likewise.
5789
5790 * term.c (term_mouse_position): Rename local to avoid shadowing.
5791
5792 * alloc.c (mark_ttys): Move decl from here ...
5793 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5794
5795 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5796
5797 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5798
5799 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5800
5801 * search.c (compile_pattern_1): Remove argument regp, unused since
5802 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5803 (compile_pattern): Don't pass it.
5804
5805 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5806
5807 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5808 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5809 for ! HAVE_GTK3.
5810 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5811
5812 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5813
5814 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5815 gdk_window_get_screen, gdk_window_get_geometry,
5816 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5817 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5818 (xg_get_pixbuf_from_pixmap): New function.
5819 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5820 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5821 Call xg_get_pixbuf_from_pixmap instead of
5822 gdk_pixbuf_get_from_drawable.
5823 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5824 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5825 (xg_check_special_colors): Use GtkStyleContext and its functions
5826 for HAVE_GTK3.
5827 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5828 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5829 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5830 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5831 Call gtk_widget_get_preferred_size.
5832 (xg_frame_resized): gdk_window_get_geometry only takes 5
5833 parameters.
5834 (xg_win_to_widget, xg_event_is_for_menubar):
5835 Call gdk_x11_window_lookup_for_display.
5836 (xg_set_widget_bg): New function.
5837 (delete_cb): New function.
5838 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5839 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5840 (xg_set_background_color): Call xg_set_widget_bg.
5841 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5842 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5843 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5844 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5845 if ! HAVE_GTK3.
5846 (update_frame_tool_bar): Call gtk_widget_hide.
5847 (xg_initialize): Use GDK_KEY_g.
5848
5849 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5850 if ! HAVE_GTK3
5851 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5852
5853 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5854 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5855 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5856
5857 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5858
5859 * w32xfns.c (select_palette): Check success of RealizePalette against
5860 GDI_ERROR, not zero.
5861
5862 See ChangeLog.11 for earlier changes.
5863
5864 ;; Local Variables:
5865 ;; coding: utf-8
5866 ;; End:
5867
5868 Copyright (C) 2011 Free Software Foundation, Inc.
5869
5870 This file is part of GNU Emacs.
5871
5872 GNU Emacs is free software: you can redistribute it and/or modify
5873 it under the terms of the GNU General Public License as published by
5874 the Free Software Foundation, either version 3 of the License, or
5875 (at your option) any later version.
5876
5877 GNU Emacs is distributed in the hope that it will be useful,
5878 but WITHOUT ANY WARRANTY; without even the implied warranty of
5879 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5880 GNU General Public License for more details.
5881
5882 You should have received a copy of the GNU General Public License
5883 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.