Merge from emacs-23; up to 2010-06-10T05:17:21Z!rgm@gnu.org.
[bpt/emacs.git] / src / ChangeLog
1 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2
3 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4 New version that can reserve upto 2GB of heap space.
5
6 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7
8 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9
10 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11
12 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
13 `gnutls_certificate_set_x509_key_file'.
14
15 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
16
17 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
18 Update dependencies.
19
20 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
21
22 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
23 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
24 Remove unused parameter `fildes'.
25 * process.c (read_process_output, send_process): Don't pass it.
26
27 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
28
29 Fix previous change: the library cache is defined in w32.c.
30 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
31 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
32
33 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
34
35 Implement dynamic loading of GnuTLS on Windows.
36
37 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
38 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
39 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
40 Declare.
41
42 * gnutls.c (Qgnutls_dll): Define.
43 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
44 (gnutls_*): Declare function pointers.
45 (init_gnutls_functions): New function to initialize function pointers.
46 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
47 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
48 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
49 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
50 (emacs_gnutls_write, emacs_gnutls_read)
51 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
52 (Fgnutls_available_p): New function.
53 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
54 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
55 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
56
57 * image.c: Include w32.h.
58 (Vimage_type_cache): Delete.
59 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
60 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
61 (w32_delayed_load): Move to w32.c.
62
63 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
64
65 * w32.c (QCloaded_from, Vlibrary_cache): Define.
66 (w32_delayed_load): Move from image.c. When loading a library, record
67 its filename in the :loaded-from property of the library id.
68 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
69 Initialize and staticpro them.
70 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
71
72 * process.c: Include lisp.h before w32.h, not after.
73 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
74 instead of gnutls_record_check_pending.
75
76 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
77
78 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
79
80 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
81 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
82 as passed in.
83
84 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
85
86 * xterm.c (x_set_frame_alpha): Do not set property on anything
87 else than FRAME_X_OUTER_WINDOW (Bug#8608).
88
89 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
90
91 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
92
93 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
94
95 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
96 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
97 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
98 (gnutls_global_initialized, Qgnutls_bootprop_priority)
99 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
100 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
101 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
102 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
103 (Qgnutls_bootprop_callbacks_verify): Make static.
104
105 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
106
107 * callproc.c: Indentation fixup.
108
109 * sysdep.c (wait_for_termination_1): Make static.
110 (wait_for_termination, interruptible_wait_for_termination): Move
111 after wait_for_termination_1.
112
113 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
114
115 * sysdep.c (interruptible_wait_for_termination): New function
116 which is like wait_for_termination, but allows keyboard
117 interruptions.
118
119 * callproc.c (Fcall_process): Add (:file "file") as an option for
120 the STDOUT buffer.
121 (Fcall_process_region): Ditto.
122
123 2011-04-30 Eli Zaretskii <eliz@gnu.org>
124
125 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
126 rather than `XVECTOR (FOO)->size'.
127
128 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
129 inttypes.h, as a gnulib replacement is used if it not available in
130 system headers.
131
132 2011-04-21 Eli Zaretskii <eliz@gnu.org>
133
134 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
135 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
136 of MOST_POSITIVE_FIXNUM. (Bug#8528)
137
138 * coding.c (coding_alloc_by_realloc): Error out if destination
139 will grow beyond MOST_POSITIVE_FIXNUM.
140 (decode_coding_emacs_mule): Abort if there isn't enough place in
141 charbuf for the composition carryover bytes. Reserve an extra
142 space for up to 2 characters produced in a loop.
143 (decode_coding_iso_2022): Abort if there isn't enough place in
144 charbuf for the composition carryover bytes.
145
146 2011-04-21 Eli Zaretskii <eliz@gnu.org>
147
148 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
149 aborting when %lld or %lll format is passed.
150 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
151 %llo or %llx format is passed. (Bug#8545)
152
153 * window.c (window_scroll_line_based): Use a marker instead of
154 simple variables to record original value of point. (Bug#7952)
155
156 * doprnt.c (doprnt): Fix the case where a multibyte sequence
157 produced by %s or %c overflows available buffer space. (Bug#8545)
158
159 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
160
161 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
162 (SIZE_MAX): Move defn after all includes, as they might #define it.
163
164 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
165
166 * w32.c (init_environment): Warn about defaulting HOME to C:\.
167
168 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
169
170 * keyboard.c (Qdelayed_warnings_hook): Define.
171 (command_loop_1): Run `delayed-warnings-hook'
172 if Vdelayed_warnings_list is non-nil.
173 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
174 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
175
176 2011-04-28 Eli Zaretskii <eliz@gnu.org>
177
178 * doprnt.c (doprnt): Don't return value smaller than the buffer
179 size if the message was truncated. (Bug#8545).
180
181 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
182
183 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
184 (Fx_window_property): #if-0 the whole functions, not just the bodies.
185
186 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
187
188 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
189
190 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
191
192 * makefile.w32-in: Update dependencies.
193
194 2011-04-27 Eli Zaretskii <eliz@gnu.org>
195
196 Improve `doprnt' and its usage. (Bug#8545)
197 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
198 `format_end'. Remove support for %l as a conversion specifier.
199 Don't use xrealloc. Improve diagnostics when the %l size modifier
200 is used. Update the commentary.
201
202 * eval.c (verror): Simplify calculation of size_t.
203
204 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
205 messages.
206
207 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
208
209 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
210 change.
211
212 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
213
214 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
215 This makes this file independent of the recent pseudovector change.
216
217 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
218
219 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
220
221 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
222 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
223 Remove unused local.
224 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
225
226 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
227 GCC 4.6.0 optimizes based on type-based alias analysis. For
228 example, if b is of type struct buffer * and v of type struct
229 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
230 != &v->size, and therefore "v->size = 1; b->size = 2; return
231 v->size;" must therefore return 1. This assumption is incorrect
232 for Emacs, since it type-puns struct Lisp_Vector * with many other
233 types. To fix this problem, this patch adds a new type struct
234 vectorlike_header that documents the constraints on layout of vectors
235 and pseudovectors, and helps optimizing compilers not get fooled
236 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
237 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
238 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
239 the size member.
240 (XSETPVECTYPE): Rewrite in terms of new macro.
241 (XSETPVECTYPESIZE): New macro, specifying both type and size.
242 This is a bit clearer, and further avoids the possibility of
243 undesirable aliasing.
244 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
245 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
246 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
247 since Lisp_Subr is a special case (no "next" field).
248 (ASIZE): Now uses header.size rather than size. All
249 previous uses of XVECTOR (foo)->size replaced to use this macro,
250 to avoid the hassle of writing XVECTOR (foo)->header.size.
251 (struct vectorlike_header): New type.
252 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
253 object, to help avoid aliasing.
254 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
255 (SUBRP): Likewise, since Lisp_Subr is a special case.
256 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
257 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
258 (struct Lisp_Hash_Table): Combine first two members into a single
259 struct vectorlike_header member. All uses of "size" and "next" members
260 changed to be "header.size" and "header.next".
261 * buffer.h (struct buffer): Likewise.
262 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
263 * frame.h (struct frame): Likewise.
264 * process.h (struct Lisp_Process): Likewise.
265 * termhooks.h (struct terminal): Likewise.
266 * window.c (struct save_window_data, struct saved_window): Likewise.
267 * window.h (struct window): Likewise.
268 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
269 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
270 * buffer.c (init_buffer_once): Likewise.
271 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
272 special case.
273 * process.c (Fformat_network_address): Use local var for size,
274 for brevity.
275
276 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
277
278 Make the Lisp reader and string-to-float more consistent (Bug#8525)
279 * data.c (atof): Remove decl; no longer used or needed.
280 (digit_to_number): Move to lread.c.
281 (Fstring_to_number): Use new string_to_number function, to be
282 consistent with how the Lisp reader treats infinities and NaNs.
283 Do not assume that floating-point numbers represent EMACS_INT
284 without losing information; this is not true on most 64-bit hosts.
285 Avoid double-rounding errors, by insisting on integers when
286 parsing non-base-10 numbers, as the documentation specifies.
287 * lisp.h (string_to_number): New decl, replacing ...
288 (isfloat_string): Remove.
289 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
290 (read1): Do not accept +. and -. as integers; this
291 appears to have been a coding error. Similarly, do not accept
292 strings like +-1e0 as floating point numbers. Do not report
293 overflow for integer overflows unless the base is not 10 which
294 means we have no simple and reliable way to continue.
295 Break out the floating-point parsing into a new
296 function string_to_number, so that Fstring_to_number parses
297 floating point numbers consistently with the Lisp reader.
298 (digit_to_number): Moved here from data.c. Make it static inline.
299 (E_CHAR, EXP_INT): Remove, replacing with ...
300 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
301 (string_to_number): New function, replacing isfloat_string.
302 This function checks for valid syntax and produces the resulting
303 Lisp float number too. Rework it so that string-to-number
304 no longer mishandles examples like "1.0e+". Use strtoumax,
305 so that overflow for non-base-10 numbers is reported only when
306 there's no portable and simple way to convert to floating point.
307
308 * textprop.c (set_text_properties_1): Rewrite for clarity,
309 and to avoid GCC warning about integer overflow.
310
311 * intervals.h (struct interval): Use EMACS_INT for members
312 where EMACS_UINT might cause problems. See
313 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
314 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
315 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
316 All uses changed.
317 (offset_intervals): Tell GCC not to worry about length overflow
318 when negating a negative length.
319
320 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
321 (overrun_check_free): Likewise.
322
323 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
324 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
325 word size.
326
327 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
328 (gnutls_make_error): Rename local to avoid shadowing.
329 (gnutls_emacs_global_deinit): ifdef out; not used.
330 (Fgnutls_boot): Use const for pointer to readonly storage.
331 Comment out unused local. Fix pointer signedness problems.
332
333 * lread.c (openp): Don't stuff size_t into an 'int'.
334 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
335 about possible signed overflow.
336
337 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
338 (GDK_KEY_g): Don't define if already defined.
339 (xg_prepare_tooltip): Avoid pointer signedness problem.
340 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
341
342 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
343 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
344
345 * xfns.c (Fx_window_property): Simplify a bit,
346 to make a bit faster and to avoid GCC 4.6.0 warning.
347 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
348
349 * fns.c (internal_equal): Don't assume size_t fits in int.
350
351 * alloc.c (compact_small_strings): Tighten assertion a little.
352
353 Replace pEd with more-general pI, and fix some printf arg casts.
354 * lisp.h (pI): New macro, generalizing old pEd macro to other
355 conversion specifiers. For example, use "...%"pI"d..." rather
356 than "...%"pEd"...".
357 (pEd): Remove. All uses replaced with similar uses of pI.
358 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
359 * alloc.c (check_pure_size): Don't overflow by converting size to int.
360 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
361 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
362 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
363 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
364 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
365 64-bit hosts.
366 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
367 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
368 * print.c (safe_debug_print, print_object): Likewise.
369 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
370 to int.
371 Use pI instead of if-then-else-abort. Use %p to avoid casts,
372 avoiding the 0 flag, which is not portable.
373 * process.c (Fmake_network_process): Use pI to avoid cast.
374 * region-cache.c (pp_cache): Likewise.
375 * xdisp.c (decode_mode_spec): Likewise.
376 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
377 behavior on 64-bit hosts with printf arg.
378 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
379 (x_stop_queuing_selection_requests): Likewise.
380 (x_get_window_property): Don't truncate byte count to an 'int'
381 when tracing.
382
383 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
384 here, since it parses constructs like leading '-' and spaces,
385 which are not wanted; and it overflows with large numbers.
386 Instead, simply match F[0-9]+, which is what is wanted anyway.
387
388 * alloc.c: Remove unportable assumptions about struct layout.
389 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
390 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
391 (allocate_vectorlike, make_pure_vector): Use the new macros,
392 plus offsetof, to remove unportable assumptions about struct layout.
393 These assumptions hold on all porting targets that I know of, but
394 they are not guaranteed, they're easy to remove, and removing them
395 makes further changes easier.
396
397 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
398 This doesn't fix a bug but makes the code clearer.
399 (string_overrun_cookie): Now const. Use initializers that
400 don't formally overflow signed char, to avoid warnings.
401 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
402 can cause Emacs to crash when string overrun checking is enabled.
403 (allocate_buffer): Don't assume sizeof (struct buffer) is a
404 multiple of sizeof (EMACS_INT); it need not be, if
405 alignof(EMACS_INT) < sizeof (EMACS_INT).
406 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
407
408 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
409
410 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
411
412 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
413
414 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
415 supposed to be handshaking. (Bug#8556)
416 Reported by Paul Eggert <eggert@cs.ucla.edu>.
417
418 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
419
420 * lisp.h (Qdebug): List symbol.
421 * eval.c (Qdebug): Restore global linkage.
422 * keyboard.c (debug-on-event): New variable.
423 (handle_user_signal): Break into debugger when debug-on-event
424 matches the current signal symbol.
425
426 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
427
428 * alloc.c (check_sblock, check_string_bytes)
429 (check_string_free_list): Convert to standard C.
430
431 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
432
433 * w32.c (emacs_gnutls_push): Fix typo.
434
435 2011-04-25 Eli Zaretskii <eliz@gnu.org>
436
437 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
438 "cast to pointer from integer of different size".
439
440 Improve doprnt and its use in verror. (Bug#8545)
441 * doprnt.c (doprnt): Document the set of format control sequences
442 supported by the function. Use SAFE_ALLOCA instead of always
443 using `alloca'.
444
445 * eval.c (verror): Don't limit the buffer size at size_max-1, that
446 is one byte too soon. Don't use xrealloc; instead xfree and
447 xmalloc anew.
448
449 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
450
451 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
452 callbacks stage.
453
454 * gnutls.c: Renamed global_initialized to
455 gnutls_global_initialized. Added internals for the
456 :verify-hostname-error, :verify-error, and :verify-flags
457 parameters of `gnutls-boot' and documented those parameters in the
458 docstring. Start callback support.
459 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
460 unless a fatal error occured. Call gnutls_alert_send_appropriate
461 on error. Return error code.
462 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
463 (emacs_gnutls_read): Likewise.
464 (Fgnutls_boot): Return handshake error code.
465 (emacs_gnutls_handle_error): New function.
466 (wsaerror_to_errno): Likewise.
467
468 * w32.h (emacs_gnutls_pull): Add prototype.
469 (emacs_gnutls_push): Likewise.
470
471 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
472 (emacs_gnutls_push): Likewise.
473
474 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
475
476 * process.c (wait_reading_process_output): Check if GnuTLS
477 buffered some data internally if no FDs are set for TLS
478 connections.
479
480 * makefile.w32-in (OBJ2): Add gnutls.$(O).
481 (LIBS): Link to USER_LIBS.
482 ($(BLD)/gnutls.$(0)): New target.
483
484 2011-04-24 Eli Zaretskii <eliz@gnu.org>
485
486 * xdisp.c (handle_single_display_spec): Rename the
487 display_replaced_before_p argument into display_replaced_p, to
488 make it consistent with the commentary. Fix typos in the
489 commentary.
490
491 * textprop.c (syms_of_textprop): Remove dead code.
492 (copy_text_properties): Delete obsolete commentary about an
493 interface that was deleted long ago. Fix typos in the description
494 of arguments.
495
496 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
497 to changes in oldXMenu/XMenu.h from 2011-04-16.
498 <menu_help_message, prev_menu_help_message>: Constify.
499 (IT_menu_make_room): menu->help_text is now `const char **';
500 adjust.
501
502 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
503 to changes in oldXMenu/XMenu.h from 2011-04-16.
504 (struct XMenu): Declare `help_text' `const char **'.
505
506 * xfaces.c <Qunspecified>: Make extern again.
507
508 * syntax.c: Include sys/types.h before including regex.h, as
509 required by Posix.
510
511 * doc.c (get_doc_string): Improve the format passed to `error'.
512
513 * doprnt.c (doprnt): Improve commentary.
514
515 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
516
517 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
518 them with etags.
519
520 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
521 changes in globals.h immediately force recompilation.
522 (TAGS): Depend on $(CURDIR)/m/intel386.h and
523 $(CURDIR)/s/ms-w32.h.
524 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
525
526 * character.c (Fchar_direction): Function deleted.
527 (syms_of_character): Don't defsubr it.
528 <char-direction-table>: Deleted.
529
530 2011-04-23 Eli Zaretskii <eliz@gnu.org>
531
532 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
533 * doprnt.c: Include limits.h.
534 (SIZE_MAX): New macro.
535 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
536 local variables are now size_t instead of int or unsigned.
537 Improve overflow protection. Support `l' modifier for integer
538 conversions. Support %l conversion. Don't assume an EMACS_INT
539 argument for integer conversions and for %c.
540
541 * lisp.h (doprnt): Restore prototype.
542
543 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
544 $(SRC)/character.h.
545
546 * Makefile.in (base_obj): Add back doprnt.o.
547
548 * deps.mk (doprnt.o): Add back prerequisites.
549 (callint.o): Depend on character.h.
550
551 * eval.c (internal_lisp_condition_case): Include the handler
552 representation in the error message.
553 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
554 when breaking from the loop.
555
556 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
557
558 * callint.c (Fcall_interactively): When displaying error message
559 about invalid control letter, pass the character's codepoint, not
560 a pointer to its multibyte form. Improve display of the character
561 in octal and display also its hex code.
562
563 * character.c (char_string): Use %x to display the (unsigned)
564 codepoint of an invalid character, to avoid displaying a bogus
565 negative value.
566
567 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
568 `error', not SYMBOL_NAME itself.
569
570 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
571 character arguments to `error'.
572
573 * charset.c (check_iso_charset_parameter): Fix incorrect argument
574 to `error' in error message about FINAL_CHAR argument. Make sure
575 FINAL_CHAR is a character, and use %c when it is passed as
576 argument to `error'.
577
578 2011-04-23 Eli Zaretskii <eliz@gnu.org>
579
580 * s/ms-w32.h (localtime): Redirect to sys_localtime.
581
582 * w32.c: Include <time.h>.
583 (sys_localtime): New function.
584
585 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
586
587 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
588
589 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
590
591 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
592
593 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
594 zombies (Bug#8467).
595
596 2011-04-19 Eli Zaretskii <eliz@gnu.org>
597
598 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
599 gl_state.e_property when gl_state.object is Qt.
600
601 * insdel.c (make_gap_larger): Remove limitation of buffer size
602 to <= INT_MAX.
603
604 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
605
606 * xdisp.c (lookup_glyphless_char_display)
607 (produce_glyphless_glyph): Handle cons cell entry in
608 glyphless-char-display.
609 (Vglyphless_char_display): Document it.
610
611 * term.c (produce_glyphless_glyph): Handle cons cell entry in
612 glyphless-char-display.
613
614 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
615
616 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
617
618 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
619
620 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
621 definition for no-X builds.
622
623 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
624
625 Static checks with GCC 4.6.0 and non-default toolkits.
626
627 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
628
629 * process.c (keyboard_bit_set): Define only if SIGIO.
630 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
631 (send_process): Repair possible setjmp clobbering.
632
633 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
634
635 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
636
637 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
638
639 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
640 Define only if needed.
641
642 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
643 by pacifying GCC about it. Maybe it's time to retire it?
644 * xfaces.c (USG, __TIMEVAL__): Likewise.
645
646 * dispextern.h (struct redisplay_interface): Rename param
647 to avoid shadowing.
648 * termhooks.h (struct terminal): Likewise.
649 * xterm.c (xembed_send_message): Likewise.
650
651 * insdel.c (make_gap_smaller): Define only if
652 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
653
654 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
655 it.
656
657 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
658 so that we aren't warned about unused symbols.
659
660 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
661
662 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
663
664 * xfns.c (x_real_positions): Mark locals as initialized.
665
666 * xmenu.c (xmenu_show): Don't use uninitialized vars.
667
668 * xterm.c: Fix problems found by static analysis with other toolkits.
669 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
670 (x_dispatch_event): Declare static if USE_GTK, and
671 define if USE_GTK || USE_X_TOOLKIT.
672 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
673 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
674 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
675 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
676
677 * xmenu.c (menu_help_callback): Pointer type fixes.
678 Use const pointers when pointing at readonly data. Avoid pointer
679 signedness clashes.
680 (FALSE): Remove unused macro.
681 (update_frame_menubar): Remove unused decl.
682
683 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
684
685 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
686 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
687 (single_menu_item): Rename local to avoid shadowing.
688
689 * keyboard.c (make_lispy_event): Remove unused local var.
690
691 * frame.c, frame.h (x_get_resource_string): Bring this back, but
692 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
693
694 * bitmaps: Change bitmaps from unsigned char back to the X11
695 compatible char. Avoid the old compiler warnings about
696 out-of-range initializers by using, for example, '\xab' rather
697 than 0xab.
698
699 * xgselect.c (xgselect_initialize): Check vs interface
700 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
701
702 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
703
704 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
705 to read-only memory.
706
707 * fns.c (vector): Remove; this old hack is no longer needed.
708
709 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
710 Remove unused var.
711 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
712
713 * xrdb.c (x_load_resources): Omit unused local.
714
715 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
716 (x_window): Rename locals to avoid shadowing.
717 (USG): Use the kludged USG macro, to pacify gcc.
718
719 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
720 (x_term_init): Remove local to avoid shadowing.
721
722 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
723
724 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
725 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
726
727 2011-04-16 Eli Zaretskii <eliz@gnu.org>
728
729 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
730
731 Fix regex.c, syntax.c and friends for buffers > 2GB.
732 * syntax.h (struct gl_state_s): Declare character position members
733 EMACS_INT.
734
735 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
736
737 * textprop.c (verify_interval_modification, interval_of): Declare
738 arguments EMACS_INT.
739
740 * intervals.c (adjust_intervals_for_insertion): Declare arguments
741 EMACS_INT.
742
743 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
744
745 * indent.c (Fvertical_motion): Local variable it_start is now
746 EMACS_INT.
747
748 * regex.c (re_match, re_match_2, re_match_2_internal)
749 (bcmp_translate, regcomp, regexec, print_double_string)
750 (group_in_compile_stack, re_search, re_search_2, regex_compile)
751 (re_compile_pattern, re_exec): Declare arguments and local
752 variables `size_t' and `ssize_t' and return values `regoff_t', as
753 appropriate.
754 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
755 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
756 <compile_stack_type>: `size' and `avail' are now `size_t'.
757
758 * regex.h <regoff_t>: Use ssize_t, not int.
759 (re_search, re_search_2, re_match, re_match_2): Arguments that
760 specify buffer/string position and length are now ssize_t and
761 size_t. Return type is regoff_t.
762
763 2011-04-16 Ben Key <bkey76@gmail.com>
764
765 * nsfont.m: Fixed bugs in ns_get_family and
766 ns_descriptor_to_entity that were caused by using free to
767 deallocate memory blocks that were allocated by xmalloc (via
768 xstrdup). This caused Emacs to crash when compiled with
769 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
770 --enable-checking=xmallocoverrun). xfree is now used to
771 deallocate these memory blocks.
772
773 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
774
775 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
776
777 emacs_write: Accept and return EMACS_INT for sizes.
778 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
779 et seq.
780 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
781 Accept and return EMACS_INT.
782 (emacs_gnutls_write): Return the number of bytes written on
783 partial writes.
784 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
785 (emacs_read, emacs_write): Remove check for negative size, as the
786 Emacs source code has been audited now.
787 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
788 (emacs_read, emacs_write): Use it.
789 * process.c (send_process): Adjust to the new signatures of
790 emacs_write and emacs_gnutls_write. Do not attempt to store
791 a byte offset into an 'int'; it might overflow.
792 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
793
794 * sound.c: Don't assume sizes fit in 'int'.
795 (struct sound_device.period_size, alsa_period_size):
796 Return EMACS_INT, not int.
797 (struct sound_device.write, vox_write, alsa_write):
798 Accept EMACS_INT, not int.
799 (wav_play, au_play): Use EMACS_INT to store sizes and to
800 record read return values.
801
802 2011-04-15 Ben Key <bkey76@gmail.com>
803
804 * keyboard.c (Qundefined): Don't declare static since it is used
805 in nsfns.m.
806 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
807 static since they are used in nsfont.m.
808
809 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
810
811 * process.c (Qprocessp): Don't declare static.
812 * lisp.h (Qprocessp): Declare again.
813
814 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
815
816 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
817
818 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
819
820 Improve C-level modularity by making more things 'static'.
821
822 Don't publish debugger-only interfaces to other modules.
823 * lisp.h (safe_debug_print, debug_output_compilation_hack):
824 (verify_bytepos, count_markers): Move decls to the only modules
825 that need them.
826 * region-cache.h (pp_cache): Likewise.
827 * window.h (check_all_windows): Likewise.
828 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
829
830 * sysdep.c (croak): Now static, if
831 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
832 * syssignal.h (croak): Declare only if not static.
833
834 * alloc.c (refill_memory_reserve): Now static if
835 !defined REL_ALLOC || defined SYSTEM_MALLOC.
836 * lisp.h (refill_memory_reserve): Declare only if not static.
837
838 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
839 Define only if USE_LUCID.
840
841 * xrdb.c (x_customization_string, x_rm_string): Now static.
842
843 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
844 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
845
846 * xdisp.c (draw_row_with_mouse_face): Now static.
847 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
848
849 * window.h (check_all_windows): Mark externally visible.
850
851 * window.c (window_deletion_count): Now static.
852
853 * undo.c: Make symbols static if they're not exported.
854 (last_undo_buffer, last_boundary_position, pending_boundary):
855 Now static.
856
857 * textprop.c (interval_insert_behind_hooks): Now static.
858 (interval_insert_in_front_hooks): Likewise.
859
860 * term.c: Make symbols static if they're not exported.
861 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
862 (max_frame_lines, tty_set_terminal_modes):
863 (tty_reset_terminal_modes, tty_turn_off_highlight):
864 (get_tty_terminal): Now static.
865 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
866 * termhooks.h (term_mouse_moveto): Do not declare if
867 HAVE_WINDOW_SYSTEM.
868 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
869 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
870
871 * sysdep.c: Make symbols static if they're not exported.
872 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
873 Now static.
874 (sigprocmask_set, full_mask): Remove; unused.
875 (wait_debugging): Mark as visible.
876 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
877 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
878
879 * syntax.c (syntax_temp): Define only if !__GNUC__.
880
881 * sound.c (current_sound_device, current_sound): Now static.
882
883 * search.c (searchbufs, searchbuf_head): Now static.
884
885 * scroll.c (scroll_cost): Remove; unused.
886 * dispextern.h (scroll_cost): Remove decl.
887
888 * region-cache.h (pp_cache): Mark as externally visible.
889
890 * process.c: Make symbols static if they're not exported.
891 (process_tick, update_tick, create_process, chan_process):
892 (Vprocess_alist, proc_buffered_char, datagram_access):
893 (fd_callback_data, send_process_frame, process_sent_to): Now static.
894 (deactivate_process): Mark defn as static, as well as decl.
895 * lisp.h (create_process): Remove decl.
896 * process.h (chan_process, Vprocess_alist): Remove decls.
897
898 * print.c: Make symbols static if they're not exported.
899 (print_depth, new_backquote_output, being_printed, print_buffer):
900 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
901 (print_interval, print_number_index, initial_stderr_stream):
902 Now static.
903 * lisp.h (Fprinc): Remove decl.
904 (debug_output_compilation_hack): Mark as externally visible.
905
906 * sysdep.c (croak): Move decl from here to syssignal.h.
907 * syssignal.h (croak): Put it here, so the API can be checked when
908 'croak' is called from dissociate_if_controlling_tty.
909
910 * minibuf.c: Make symbols static if they're not exported.
911 (minibuf_save_list, choose_minibuf_frame): Now static.
912 * lisp.h (choose_minibuf_frame): Remove decl.
913
914 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
915
916 * lread.c: Make symbols static if they're not exported.
917 (read_objects, initial_obarray, oblookup_last_bucket_number):
918 Now static.
919 (make_symbol): Remove; unused.
920 * lisp.h (initial_obarray, make_symbol): Remove decls.
921
922 * keyboard.c: Make symbols static if they're not exported.
923 (single_kboard, recent_keys_index, total_keys, recent_keys):
924 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
925 (this_single_command_key_start, echoing, last_auto_save):
926 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
927 (command_loop, echo_now, keyboard_init_hook, help_char_p):
928 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
929 (Vlispy_mouse_stem, double_click_count):
930 Now static.
931 (force_auto_save_soon): Define only if SIGDANGER.
932 (ignore_mouse_drag_p): Now static if
933 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
934 (print_help): Remove; unused.
935 (stop_character, last_timer_event): Mark as externally visible.
936 * keyboard.h (ignore_mouse_drag_p): Declare only if
937 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
938 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
939 * lisp.h (echoing): Remove decl.
940 (force_auto_save_soon): Declare only if SIGDANGER.
941 * xdisp.c (redisplay_window): Simplify code, to make it more
942 obvious that ignore_mouse_drag_p is not accessed if !defined
943 USE_GTK && !defined HAVE_NS.
944
945 * intervals.c: Make symbols static if they're not exported.
946 (merge_properties_sticky, merge_interval_right, delete_interval):
947 Now static.
948 * intervals.h (merge_interval_right, delete_interval): Remove decls.
949
950 * insdel.c: Make symbols static if they're not exported.
951 However, leave prepare_to_modify_buffer alone. It's never
952 called from outside this function, but that appears to be a bug.
953 (combine_after_change_list, combine_after_change_buffer):
954 (adjust_after_replace, signal_before_change): Now static.
955 (adjust_after_replace_noundo): Remove; unused.
956 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
957 (signal_before_change): Remove decls.
958
959 * indent.c (val_compute_motion, val_vmotion): Now static.
960
961 * image.c: Make symbols static if they're not exported.
962 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
963 if USE_GTK.
964 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
965 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
966
967 * fringe.c (standard_bitmaps): Now static.
968 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
969
970 * frame.c: Make symbols static if they're not exported.
971 (x_report_frame_params, make_terminal_frame): Now static.
972 (get_frame_param): Now static, unless HAVE_NS.
973 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
974 (x_get_resource_string): Remove; not used.
975 * frame.h (make_terminal_frame, x_report_frame_params):
976 (x_get_resource_string); Remove decls.
977 (x_fullscreen_adjust): Declare only if WINDOWSNT.
978 * lisp.h (get_frame_param): Declare only if HAVE_NS.
979
980 * font.c, fontset.c: Make symbols static if they're not exported.
981 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
982 (FACE_SUITABLE_FOR_CHAR_P): Use it.
983 * font.c (font_close_object): Now static.
984 * font.h (font_close_object): Remove.
985 * fontset.c (FONTSET_OBJLIST): Remove.
986 (free_realized_fontset) #if-0 the body, which does nothing.
987 (face_suitable_for_char_p): #if-0, as it's never called.
988 * fontset.h (face_suitable_for_char_p): Remove decl.
989 * xfaces.c (face_at_string_position): Use
990 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
991 since 0 is always ASCII.
992
993 * fns.c (weak_hash_tables): Now static.
994
995 * fileio.c: Make symbols static if they're not exported.
996 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
997 (Vwrite_region_annotation_buffers): Now static.
998
999 * eval.c: Make symbols static if they're not exported.
1000 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1001 * lisp.h (backtrace_list): Remove decl.
1002
1003 * emacs.c: Make symbols static if they're not exported.
1004 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1005 (fatal_error_code, fatal_error_signal_hook, standard_args):
1006 Now static.
1007 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1008 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1009 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1010 * lisp.h (fatal_error_signal_hook): Remove decl.
1011 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1012
1013 * editfns.c: Move a (normally-unused) function to its only use.
1014 * editfns.c, lisp.h (get_operating_system_release): Remove.
1015 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1016 worth the hassle of breaking this out.
1017
1018 * xterm.c: Make symbols static if they're not exported.
1019 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1020 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1021 (x_destroy_window, x_delete_display):
1022 Now static.
1023 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1024 (x_mouse_leave): Remove; unused.
1025 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1026 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1027 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1028 Remove decls.
1029 (x_mouse_leave): Declare only if WINDOWSNT.
1030 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1031 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1032 USE_X_TOOLKIT.
1033
1034 * ftxfont.c: Make symbols static if they're not exported.
1035 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1036 HAVE_FREETYPE.
1037 * font.h (ftxfont_driver): Likewise.
1038
1039 * xfns.c: Make symbols static if they're not exported.
1040 (x_last_font_name, x_display_info_for_name):
1041 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1042 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1043 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1044 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1045 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1046 (last_show_tip_args): Now static.
1047 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1048 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1049 (x_screen_planes): Remove; unused.
1050 * dispextern.h (x_screen_planes): Remove decl.
1051
1052 * dispnew.c: Make symbols static if they're not exported.
1053 * dispextern.h (redraw_garbaged_frames, scrolling):
1054 (increment_row_positions): Remove.
1055 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1056 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1057 Now static.
1058 (redraw_garbaged_frames): Remove; unused.
1059
1060 * xfaces.c: Make symbols static if they're not exported.
1061 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1062 Remove decls.
1063 * xterm.h (defined_color): Remove decls.
1064 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1065 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1066 (menu_face_changed_default, defined_color, free_realized_face):
1067 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1068 (ascii_face_of_lisp_face): Remove; unused.
1069
1070 * xdisp.c: Make symbols static if they're not exported.
1071 * dispextern.h (scratch_glyph_row, window_box_edges):
1072 (glyph_to_pixel_coords, set_cursor_from_row):
1073 (get_next_display_element, set_iterator_to_next):
1074 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1075 (show_mouse_face): Remove decls
1076 * frame.h (message_buf_print): Likewise.
1077 * lisp.h (pop_message, set_message, check_point_in_composition):
1078 Likewise.
1079 * xterm.h (set_vertical_scroll_bar): Likewise.
1080 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1081 (message_buf_print, scratch_glyph_row, displayed_buffer):
1082 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1083 (get_next_display_element, show_mouse_face, window_box_edges):
1084 (frame_to_window_pixel_xy, check_point_in_composition):
1085 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1086 (glyph_to_pixel_coords): Remove; unused.
1087
1088 * dired.c (file_name_completion): Now static.
1089
1090 * dbusbind.c (xd_in_read_queued_messages): Now static.
1091
1092 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1093 * data.c (circular_list_error): Remove.
1094
1095 * commands.h (last_point_position, last_point_position_buffer):
1096 (last_point_position_window): Remove decls.
1097 * keyboard.c: Make these variables static.
1098
1099 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1100 decls.
1101 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1102 (iso_code_class, detect_coding, code_convert_region): Now static.
1103 (encode_coding_gap): Remove; unused.
1104
1105 * chartab.c (chartab_chars, chartab_bits): Now static.
1106
1107 * charset.h (charset_iso_8859_1): Remove decl.
1108 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1109 Now static.
1110
1111 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1112 * ccl.c (Vccl_program_table): Now static.
1113 (check_ccl_update): Remove; unused.
1114
1115 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1116 * category.h: ... from here.
1117 * category.c (check_category_table, set_category_set): Now static.
1118
1119 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1120 * lisp.h: Remove these decls.
1121
1122 * buffer.c (buffer_count): Remove unused var.
1123
1124 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1125 so that it's not optimized away.
1126 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1127 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1128 exported only to the debugger.
1129
1130 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1131 * atimer.h (run_all_atimers): Removed; not exported.
1132
1133 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1134 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1135 was inaccessible from Lisp.
1136 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1137 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1138
1139 alloc.c: Import and export fewer symbols, and remove unused items.
1140 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1141 is defined.
1142 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1143 it's not optimized away by whole-program optimization.
1144 (message_enable_multibyte, free_misc): Remove.
1145 (catchlist, handlerlist, mark_backtrace):
1146 Declare only if BYTE_MARK_STACK.
1147 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1148 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1149 (message_enable_multibyte): Remove decl.
1150 (free_misc, interval_free_list, float_block, float_block_index):
1151 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1152 (cons_free_list, last_marked_index):
1153 Now static.
1154 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1155 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1156 (mark_backtrace): Define only if BYTE_MARK_STACK.
1157 * xdisp.c (message_enable_multibyte): Now static.
1158
1159 Declare Lisp_Object Q* variables to be 'static' if not exported.
1160 This makes it easier for human readers (and static analyzers)
1161 to see whether these variables are used from other modules.
1162 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1163 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1164 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1165 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1166 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1167 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1168 * xmenu.c, xselect.c:
1169 Declare Q* vars static if they are not used in other modules.
1170 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1171 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1172 Remove decls of unexported vars.
1173 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1174
1175 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1176
1177 Make Emacs functions such as Fatom 'static' by default.
1178 This makes it easier for human readers (and static analyzers)
1179 to see whether these functions can be called from other modules.
1180 DEFUN now defines a static function. To make the function external
1181 so that it can be used in other C modules, use the new macro DEFUE.
1182 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1183 (Finit_image_library):
1184 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1185 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1186 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1187 Remove decls, since these functions are now static.
1188 (Funintern, Fget_internal_run_time): New decls, since these functions
1189 were already external.
1190
1191 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1192 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1193 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1194 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1195 * keyboard.c, keymap.c, lread.c:
1196 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1197 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1198 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1199 Mark functions with DEFUE instead of DEFUN,
1200 if they are used in other modules.
1201 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1202 decls for now-static functions.
1203 * buffer.h (Fdelete_overlay): Remove decl.
1204 * callproc.c (Fgetenv_internal): Mark as internal.
1205 * composite.c (Fremove_list_of_text_properties): Remove decl.
1206 (Fcomposition_get_gstring): New forward static decl.
1207 * composite.h (Fcomposite_get_gstring): Remove decl.
1208 * dired.c (Ffile_attributes): New forward static decl.
1209 * doc.c (Fdocumntation_property): New forward static decl.
1210 * eval.c (Ffetch_bytecode): New forward static decl.
1211 (Funintern): Remove extern decl; now in .h file where it belongs.
1212 * fileio.c (Fmake_symbolic_link): New forward static decl.
1213 * image.c (Finit_image_library): New forward static decl.
1214 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1215 * intervals.h (Fprevious_property_change):
1216 (Fremove_list_of_text_properties): Remove decls.
1217 * keyboard.c (Fthis_command_keys): Remove decl.
1218 (Fcommand_execute): New forward static decl.
1219 * keymap.c (Flookup_key): New forward static decl.
1220 (Fcopy_keymap): Now static.
1221 * keymap.h (Flookup_key): Remove decl.
1222 * process.c (Fget_process): New forward static decl.
1223 (Fprocess_datagram_address): Mark as internal.
1224 * syntax.c (Fsyntax_table_p): New forward static decl.
1225 (skip_chars): Remove duplicate decl.
1226 * textprop.c (Fprevious_property_change): New forward static decl.
1227 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1228 Now internal.
1229 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1230 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1231
1232 * editfns.c (Fformat): Remove unreachable code.
1233
1234 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1235
1236 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1237 change. (Bug#8496)
1238
1239 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1240
1241 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1242 when at ZV. (Bug#8487)
1243
1244 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1245
1246 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1247 (Bug#8437)
1248 * keyboard.c (parse_tool_bar_item): Likewise.
1249 * sound.c (sound_cleanup, alsa_close): Likewise.
1250 * termcap.c (tgetent): Likewise.
1251 * xfns.c (x_default_font_parameter): Likewise.
1252 * xsettings.c (read_and_apply_settings): Likewise.
1253
1254 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1255 (overrun_check_free): Protoize.
1256
1257 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1258
1259 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1260 since callers should never pass a negative size.
1261 Change the signature to match that of plain 'read' and 'write'; see
1262 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1263 * lisp.h: Update prototypes of emacs_write and emacs_read.
1264
1265 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1266
1267 * xdisp.c (redisplay_window): Don't try to determine the character
1268 position of the scroll margin if the window start point w->startp
1269 is outside the buffer's accessible region. (Bug#8468)
1270
1271 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1272
1273 Fix write-region and its subroutines for buffers > 2GB.
1274 * fileio.c (a_write, e_write): Modify declaration of arguments and
1275 local variables to support buffers larger than 2GB.
1276 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1277
1278 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1279 argument, local variables, and return value.
1280
1281 * lisp.h: Update prototypes of emacs_write and emacs_read.
1282
1283 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1284
1285 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1286
1287 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1288
1289 Fix more problems found by GCC 4.6.0's static checks.
1290
1291 * xdisp.c (vmessage): Use a better test for character truncation.
1292
1293 * charset.c (load_charset_map): <, not <=, for optimization,
1294 and to avoid potential problems with integer overflow.
1295 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1296 * casetab.c (set_identity, shuffle): Likewise.
1297 * editfns.c (Fformat): Likewise.
1298 * syntax.c (skip_chars): Likewise.
1299
1300 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1301 This also lets GCC 4.6.0 generate slightly better loop code.
1302
1303 * callint.c (Fcall_interactively): <, not <=, for optimization.
1304 (Fcall_interactively): Count the number of arguments produced,
1305 not the number of arguments given. This is simpler and lets GCC
1306 4.6.0 generate slightly better code.
1307
1308 * ftfont.c: Distingish more carefully between FcChar8 and char.
1309 The previous code passed unsigned char * to a functions like
1310 strlen and xstrcasecmp that expect char *, which does not
1311 conform to the C standard.
1312 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1313 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1314 char * when the C standard requires it.
1315
1316 * keyboard.c (read_char): Remove unused var.
1317
1318 * eval.c: Port to Windows vsnprintf (Bug#8435).
1319 Include <limits.h>.
1320 (SIZE_MAX): Define if the headers do not.
1321 (verror): Do not give up if vsnprintf returns a negative count.
1322 Instead, grow the buffer. This ports to Windows vsnprintf, which
1323 does not conform to C99. Problem reported by Eli Zaretskii.
1324 Also, simplify the allocation scheme, by avoiding the need for
1325 calling realloc, and removing the ALLOCATED variable.
1326
1327 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1328
1329 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1330 But keep the doprint source code for now, as we might revamp it
1331 and use it again (Bug#8435).
1332 * lisp.h (doprnt): Remove.
1333 * Makefile.in (base_obj): Remove doprnt.o.
1334 * deps.mk (doprnt.o): Remove.
1335
1336 error: Print 32- and 64-bit integers portably (Bug#8435).
1337 Without this change, on typical 64-bit hosts error ("...%d...", N)
1338 was used to print both 32- and 64-bit integers N, which relied on
1339 undefined behavior.
1340 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1341 New macro.
1342 * lisp.h (error, verror): Mark as printf-like functions.
1343 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1344 Report overflow in size calculations when allocating printf buffer.
1345 Do not truncate output string at its first null byte.
1346 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1347 Truncate the output at a character boundary, since vsnprintf does not
1348 do that.
1349 * charset.c (check_iso_charset_parameter): Convert internal
1350 character to string before calling 'error', since %c now has the
1351 printf meaning.
1352 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1353 overflow when computing char to be passed to 'error'. Do not
1354 pass Lisp_Object to 'error'; pass the integer instead.
1355 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1356 formatted with plain %d.
1357
1358 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1359
1360 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1361
1362 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1363
1364 * xterm.c (x_catch_errors): Remove duplicate declaration.
1365
1366 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1367
1368 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1369
1370 2011-04-10 Jim Meyering <meyering@redhat.com>
1371
1372 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1373 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1374 return ssize_t not "int", and use size_t as the buffer length.
1375 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1376 * gnutls.h: Update declarations.
1377 * process.c (read_process_output): Use ssize_t, to match.
1378 (send_process): Likewise.
1379
1380 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1381
1382 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1383
1384 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1385
1386 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1387 unsigned char, to match FcChar8 type definition.
1388
1389 * xterm.c (handle_one_xevent):
1390 * xmenu.c (create_and_show_popup_menu):
1391 * xselect.c (x_decline_selection_request)
1392 (x_reply_selection_request): Avoid type-punned deref of X events.
1393
1394 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1395
1396 Fix some uses of `int' instead of EMACS_INT.
1397 * search.c (string_match_1, fast_string_match)
1398 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1399 (scan_buffer, find_next_newline_no_quit)
1400 (find_before_next_newline, search_command, Freplace_match)
1401 (Fmatch_data): Make some `int' variables be EMACS_INT.
1402
1403 * xdisp.c (display_count_lines): 3rd argument and return value now
1404 EMACS_INT. All callers changed.
1405 (pint2hrstr): Last argument is now EMACS_INT.
1406
1407 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1408 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1409 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1410 (decode_coding_utf_16, decode_coding_emacs_mule)
1411 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1412 (decode_coding_ccl, decode_coding_charset)
1413 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1414 (decode_coding_iso_2022, decode_coding_emacs_mule)
1415 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1416 <char_offset, last_offset>: Declare EMACS_INT.
1417 (encode_coding_utf_8, encode_coding_utf_16)
1418 (encode_coding_emacs_mule, encode_invocation_designation)
1419 (encode_designation_at_bol, encode_coding_iso_2022)
1420 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1421 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1422 Declare EMACS_INT.
1423 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1424 (encode_invocation_designation): Last argument P_NCHARS is now
1425 EMACS_INT.
1426 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1427 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1428
1429 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1430 All users changed.
1431
1432 * ccl.c (Fccl_execute_on_string): Declare some variables
1433 EMACS_INT.
1434
1435 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1436
1437 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1438
1439 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1440
1441 * process.c (Fformat_network_address): Doc fix.
1442
1443 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1444
1445 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1446
1447 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1448
1449 * keyboard.c (read_char): Call Lisp function help-form-show,
1450 instead of using internal_with_output_to_temp_buffer.
1451 (Qhelp_form_show): New var.
1452 (syms_of_keyboard): Use DEFSYM macro.
1453
1454 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1455
1456 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1457
1458 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1459
1460 * process.c (Flist_processes): Removed to Lisp.
1461 (list_processes_1): Deleted.
1462
1463 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1464
1465 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1466
1467 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1468
1469 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1470
1471 Fix more problems found by GCC 4.6.0's static checks.
1472
1473 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1474
1475 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1476
1477 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1478
1479 * xdisp.c (vmessage): Mark as a printf-like function.
1480
1481 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1482
1483 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1484
1485 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1486 printf-like functions.
1487 (tiff_load): Add casts to remove these marks before passing them
1488 to system-supplied API.
1489
1490 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1491
1492 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1493 This avoids several warnings with gcc -Wstrict-overflow.
1494 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1495 directly, rather than having caller test rule sign. This avoids
1496 some unnecessary tests.
1497 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1498 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1499 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1500
1501 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1502 (xfont_open): Avoid unnecessary tests.
1503
1504 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1505
1506 * composite.h, composite.c (composition_gstring_put_cache):
1507 Use EMACS_INT, not int, for length.
1508
1509 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1510 breaking out part of COMPOSITION_DECODE_RULE.
1511 (COMPOSITION_DECODE_RULE): Use it.
1512 * composite.c (get_composition_id): Remove unused local vars,
1513 by using the new macro.
1514
1515 * textprop.c (set_text_properties_1): Change while to do-while,
1516 since the condition is always true at first.
1517
1518 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1519 (interval_deletion_adjustment): Return unsigned value.
1520 All uses changed.
1521
1522 * process.c (list_processes_1, create_pty, read_process_output):
1523 (exec_sentinel): Remove vars that were set but not used.
1524 (create_pty): Remove unnecessary "volatile"s.
1525 (Fnetwork_interface_info): Avoid possibility of int overflow.
1526 (read_process_output): Do adaptive read buffering even if carryover.
1527 (read_process_output): Simplify nbytes computation if buffered.
1528
1529 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1530
1531 * syntax.c (scan_words): Remove var that was set but not used.
1532 (update_syntax_table): Use unsigned instead of int.
1533
1534 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1535 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1536 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1537
1538 * print.c (print_error_message): Avoid int overflow.
1539
1540 * font.c (font_list_entities): Redo for clarity,
1541 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1542
1543 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1544 (font_score): Avoid potential overflow in diff calculation.
1545
1546 * fns.c (substring_both): Remove var that is set but not used.
1547 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1548
1549 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1550
1551 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1552 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1553 can always succeed if overflow has undefined behavior.
1554
1555 * search.c (boyer_moore, wordify): Remove vars set but not used.
1556 (wordify): Omit three unnecessary tests.
1557
1558 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1559 All callers changed. This avoids the need for an unused var.
1560
1561 * casefiddle.c (casify_region): Remove var that is set but not used.
1562
1563 * dired.c (file_name_completion): Remove var that is set but not used.
1564
1565 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1566
1567 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1568 (Finsert_file_contents): Remove unnecessary code checking fd.
1569
1570 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1571 Check for integer overflow on size calculations.
1572
1573 * buffer.c (Fprevious_overlay_change): Remove var that is set
1574 but not used.
1575
1576 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1577 Remove vars that are set but not used.
1578 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1579 (timer_check_2): Mark vars as initialized.
1580
1581 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1582
1583 * image.c (lookup_image): Remove var that is set but not used.
1584 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1585
1586 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1587 that are set but not used.
1588
1589 * xfns.c (make_invisible_cursor): Don't return garbage
1590 if XCreateBitmapFromData fails (Bug#8410).
1591
1592 * xselect.c (x_get_local_selection, x_handle_property_notify):
1593 Remove vars that are set but not used.
1594
1595 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1596 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1597
1598 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1599 Remove var that is set but not used.
1600 (scroll_bar_windows_size): Now size_t, not int.
1601 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1602 Check for overflow.
1603
1604 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1605 (map_tty_color) [!defined MSDOS]: Likewise.
1606
1607 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1608
1609 * coding.c: Remove vars that are set but not used.
1610 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1611 All callers changed.
1612 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1613 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1614 (decode_coding_charset): Remove vars that are set but not used.
1615
1616 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1617 that is set but not used.
1618
1619 * print.c (print_object): Remove var that is set but not used.
1620
1621 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1622 The gnulib version avoids calling malloc in the usual case,
1623 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1624 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1625 * filelock.c (current_lock_owner): Likewise.
1626 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1627 * sysdep.c: Include allocator.h, careadlinkat.h.
1628 (emacs_no_realloc_allocator): New static constant.
1629 (emacs_readlink): New function.
1630 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1631 ../lib/careadlinkat.h.
1632
1633 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1634
1635 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1636 first non-nil return value).
1637
1638 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1639
1640 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1641 if not defined (Bug#8403).
1642
1643 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1644
1645 * xdisp.c (display_count_lines): Remove parameter `start',
1646 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1647 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1648 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1649 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1650 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1651 and thereabouts. All callers changed.
1652 (get_per_char_metric): Remove parameter `f', unused since
1653 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1654
1655 2011-04-02 Jim Meyering <meyering@redhat.com>
1656
1657 do not dereference NULL upon failed strdup
1658 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1659 (ns_get_family): Likewise.
1660
1661 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1662
1663 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1664
1665 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1666
1667 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1668 later (Bug#8403).
1669
1670 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1671
1672 Add lexical binding.
1673
1674 * window.c (Ftemp_output_buffer_show): New fun.
1675 (Fsave_window_excursion):
1676 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1677
1678 * lread.c (lisp_file_lexically_bound_p): New function.
1679 (Fload): Bind Qlexical_binding.
1680 (readevalloop): Remove `evalfun' arg.
1681 Bind Qinternal_interpreter_environment.
1682 (Feval_buffer): Bind Qlexical_binding.
1683 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1684 Mark as dynamic.
1685 (syms_of_lread): Declare `lexical-binding'.
1686
1687 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1688
1689 * keyboard.c (eval_dyn): New fun.
1690 (menu_item_eval_property): Use it.
1691
1692 * image.c (parse_image_spec): Use Ffunctionp.
1693
1694 * fns.c (concat, mapcar1): Accept byte-code-functions.
1695
1696 * eval.c (Fsetq): Handle lexical vars.
1697 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1698 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1699 (FletX, Flet): Obey lexical binding.
1700 (Fcommandp): Handle closures.
1701 (Feval): New `lexical' arg.
1702 (eval_sub): New function extracted from Feval. Use it almost
1703 everywhere where Feval was used. Look up vars in lexical env.
1704 Handle closures.
1705 (Ffunctionp): Move from subr.el.
1706 (Ffuncall): Handle closures.
1707 (apply_lambda): Remove `eval_flags'.
1708 (funcall_lambda): Handle closures and new byte-code-functions.
1709 (Fspecial_variable_p): New function.
1710 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1711 but without exporting it to Lisp.
1712
1713 * doc.c (Fdocumentation, store_function_docstring):
1714 * data.c (Finteractive_form): Handle closures.
1715
1716 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1717 interactive spec.
1718
1719 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1720 byte-codes.
1721 (exec_byte_code): New function extracted from Fbyte_code to handle new
1722 calling convention for byte-code-functions. Add new byte-codes.
1723
1724 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1725
1726 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1727
1728 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1729
1730 * xdisp.c (redisplay_internal): Fix prototype.
1731
1732 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1733
1734 * xdisp.c (SCROLL_LIMIT): New macro.
1735 (try_scrolling): Use it when setting scroll_limit. Limit
1736 scrolling to 100 screen lines.
1737 (redisplay_window): Even when falling back on "recentering",
1738 position point in the window according to scroll-conservatively,
1739 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1740
1741 (try_scrolling): When point is above the window, allow searching
1742 as far as scroll_max, or one screenful, to compute vertical
1743 distance from PT to the scroll margin position. This prevents
1744 try_scrolling from unnecessarily failing when
1745 scroll-conservatively is set to a value slightly larger than the
1746 window height. Clean up the case of PT below the margin at bottom
1747 of window: scroll_max can no longer be INT_MAX. When aggressive
1748 scrolling is in use, don't let point enter the opposite scroll
1749 margin as result of the scroll.
1750 (syms_of_xdisp) <scroll-conservatively>: Document the
1751 threshold of 100 lines for never-recentering scrolling.
1752
1753 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1754
1755 * dispextern.h (move_it_by_lines):
1756 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1757 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1758 (message_log_check_duplicate): Remove parameters `prev_bol' and
1759 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1760 (redisplay_internal): Remove parameter `preserve_echo_area',
1761 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1762
1763 * indent.c (Fvertical_motion):
1764 * window.c (window_scroll_pixel_based, Frecenter):
1765 Don't pass `need_y_p' to `move_it_by_lines'.
1766
1767 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1768
1769 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1770 steal a few bits to be more compact.
1771 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1772 Remove unneeded casts.
1773
1774 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1775
1776 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1777
1778 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1779 binding" message (bug#7967).
1780
1781 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1782
1783 Fix more problems found by GCC 4.6.0's static checks.
1784
1785 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1786 Remove unused local var.
1787
1788 * editfns.c (Fmessage_box): Remove unused local var.
1789
1790 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1791 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1792 Omit unused local vars.
1793 * window.c (shrink_windows): Omit unused local var.
1794 * menu.c (digest_single_submenu): Omit unused local var.
1795 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1796 Omit unused local var.
1797
1798 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1799 Don't assume string length fits in int.
1800 (keyremap_step, read_key_sequence): Use size_t for sizes.
1801 (read_key_sequence): Don't check last_real_key_start redundantly.
1802
1803 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1804 instead of alloca (Bug#8344).
1805
1806 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1807 (Fbacktrace_frame): Don't assume nframes fits in int.
1808
1809 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1810
1811 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1812 concerns.
1813
1814 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1815
1816 * cm.c (calccost): Turn while-do into do-while, for clarity.
1817
1818 * keyboard.c (syms_of_keyboard): Use the same style as later
1819 in this function when indexing through an array. This also
1820 works around GCC bug 48267.
1821
1822 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1823
1824 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1825
1826 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1827 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1828
1829 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1830 This avoids undefined behavior on integer overflow, and is a bit
1831 more convenient anyway since it is compared to a size_t variable.
1832
1833 Variadic C functions now count arguments with size_t, not int.
1834 This avoids an unnecessary limitation on 64-bit machines, which
1835 caused (substring ...) to crash on large vectors (Bug#8344).
1836 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1837 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1838 All variadic functions and their callers changed accordingly.
1839 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1840 * data.c (arith_driver, float_arith_driver): Likewise.
1841 * editfns.c (general_insert_function): Likewise.
1842 * eval.c (struct backtrace.nargs, interactive_p)
1843 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1844 (funcall_lambda, mark_backtrace): Likewise.
1845 * fns.c (concat): Likewise.
1846 * frame.c (x_set_frame_parameters): Likewise.
1847 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1848 0 if not found, not -1. All callers changed.
1849
1850 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1851 (stack_copy_size): Now size_t, not int.
1852 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1853
1854 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1855
1856 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1857 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1858 All callers changed.
1859
1860 * lisp.h (multibyte_char_to_unibyte):
1861 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1862 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1863 * character.h (CHAR_TO_BYTE8):
1864 * cmds.c (internal_self_insert):
1865 * editfns.c (general_insert_function):
1866 * keymap.c (push_key_description):
1867 * search.c (Freplace_match):
1868 * xdisp.c (message_dolog, set_message_1): All callers changed.
1869
1870 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1871
1872 * keyboard.c (safe_run_hook_funcall): New function.
1873 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1874 don't set the hook to nil, but remove the offending function instead.
1875 (Qcommand_hook_internal): Remove, unused.
1876 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1877 Vcommand_hook_internal.
1878
1879 * eval.c (enum run_hooks_condition): Remove.
1880 (funcall_nil, funcall_not): New functions.
1881 (run_hook_with_args): Call each function through a `funcall' argument.
1882 Remove `cond' argument, now redundant.
1883 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1884 (Frun_hook_with_args_until_failure): Adjust accordingly.
1885 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1886
1887 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1888
1889 * dispextern.h (string_buffer_position): Remove declaration.
1890
1891 * print.c (strout): Remove parameter `multibyte', unused since
1892 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1893
1894 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1895 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1896 All callers changed.
1897
1898 * w32.c (_wsa_errlist): Use braces for struct initializers.
1899
1900 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1901 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1902 All callers changed.
1903 (string_buffer_position): Likewise. Also, make static (it's never
1904 used outside xdisp.c).
1905 (cursor_row_p): Remove parameter `w', unused since
1906 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1907 (decode_mode_spec): Remove parameter `precision', introduced during
1908 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1909 All callers changed.
1910
1911 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1912
1913 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1914
1915 2011-03-27 Anders Lindgren <andlind@gmail.com>
1916
1917 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1918 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1919 (ns_update_auto_hide_menu_bar): New functions.
1920 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1921 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1922 ns_constrain_all_frames.
1923 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1924 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1925
1926 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1927
1928 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1929
1930 2011-03-27 Glenn Morris <rgm@gnu.org>
1931
1932 * syssignal.h: Replace RETSIGTYPE with void.
1933 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1934 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1935 Replace SIGTYPE with void everywhere.
1936 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1937 * s/template.h (SIGTYPE): Remove commented out definition.
1938
1939 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1940
1941 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1942 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1943
1944 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1945
1946 * w32.c (read_unc_volume): Use parameter `henum', instead of
1947 global variable `wget_enum_handle'.
1948
1949 * keymap.c (describe_vector): Remove parameters `indices' and
1950 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1951 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1952
1953 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1954
1955 * keyboard.c (timer_check): Remove parameter `do_it_now',
1956 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1957 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1958 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1959
1960 * keyboard.c (read_char):
1961 * w32menu.c (w32_menu_display_help):
1962 * xmenu.c (show_help_event, menu_help_callback):
1963 Adjust calls to `show_help_echo'.
1964
1965 * gtkutil.c (xg_maybe_add_timer):
1966 * keyboard.c (readable_events):
1967 * process.c (wait_reading_process_output):
1968 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1969
1970 * insdel.c (adjust_markers_gap_motion):
1971 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1972 (gap_left, gap_right): Don't call it.
1973
1974 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1975
1976 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1977 incurred during fontification.
1978
1979 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1980
1981 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1982 (DEFVAR_PER_BUFFER): Don't pass it.
1983
1984 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1985 (scrolling_window): Don't pass it.
1986
1987 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1988
1989 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1990
1991 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1992 and `suffix'.
1993 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1994 of variables specific to SELinux and computation of `encoded_absname'.
1995
1996 * image.c (XPutPixel): Remove unused variable `height'.
1997
1998 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1999
2000 * unexw32.c (get_section_info): Remove unused variable `section'.
2001
2002 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2003 (system_process_attributes): Remove unused variable `sess'.
2004 (sys_read): Remove unused variable `err'.
2005
2006 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2007 (w32_wnd_proc): Remove unused variable `isdead'.
2008 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2009 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2010 (x_create_tip_frame): Remove unused variable `tem'.
2011
2012 * w32inevt.c (w32_console_read_socket):
2013 Remove unused variable `no_events'.
2014
2015 * w32term.c (x_draw_composite_glyph_string_foreground):
2016 Remove unused variable `width'.
2017
2018 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2019
2020 * w32term.c (x_set_glyph_string_clipping):
2021 Don't pass uninitialized region to CombineRgn.
2022
2023 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2024
2025 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2026 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2027 (Fx_close_connection): Remove unused variable `i'.
2028
2029 * w32font.c (w32font_draw): Return number of glyphs.
2030 (w32font_open_internal): Remove unused variable `i'.
2031 (w32font_driver): Add missing initializer.
2032
2033 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2034 (fill_in_menu): Remove unused variable `items_added'.
2035
2036 * w32term.c (last_mouse_press_frame): Remove static global variable.
2037 (w32_clip_to_row): Remove unused variable `f'.
2038 (x_delete_terminal): Remove unused variable `i'.
2039
2040 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2041 (NOTHING): Remove unused static global variable.
2042 (uniscribe_check_otf): Remove unused variable `table'.
2043 (uniscribe_font_driver): Add missing initializers.
2044
2045 2011-03-23 Julien Danjou <julien@danjou.info>
2046
2047 * term.c (Fsuspend_tty, Fresume_tty):
2048 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2049 * window.c (temp_output_buffer_show):
2050 * insdel.c (signal_before_change):
2051 * frame.c (Fhandle_switch_frame):
2052 * fileio.c (Fdo_auto_save):
2053 * emacs.c (Fkill_emacs):
2054 * editfns.c (save_excursion_restore):
2055 * cmds.c (internal_self_insert):
2056 * callint.c (Fcall_interactively):
2057 * buffer.c (Fkill_all_local_variables):
2058 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2059 Use Frun_hooks.
2060 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2061 unconditionnaly since it does the check itself.
2062
2063 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 Fix more problems found by GCC 4.5.2's static checks.
2066
2067 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2068 the first time through the loop, since we know p0 < p1 then.
2069 This also avoids a gcc -Wstrict-overflow warning.
2070
2071 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2072 leading to a memory leak, possible in functions like
2073 load_charset_map_from_file that can allocate an unbounded number
2074 of objects (Bug#8318).
2075
2076 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2077 that could (at least in theory) be that large.
2078
2079 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2080 This is less likely to overflow, and avoids undefined behavior if
2081 overflow does occur. All callers changed. Use strtoul to scan
2082 for the unsigned long integer.
2083 (pint2hrstr): Simplify and tune code slightly.
2084 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2085
2086 * scroll.c (do_scrolling): Work around GCC bug 48228.
2087 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2088
2089 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2090 This also avoids a warning with gcc -Wstrict-overflow.
2091 (validate_x_resource_name): Simplify count usage.
2092 This also avoids a warning with gcc -Wstrict-overflow.
2093
2094 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2095 fail (Bug#8306).
2096
2097 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2098
2099 * process.c (Fmake_network_process): Use socklen_t, not int,
2100 where POSIX says socklen_t is required in portable programs.
2101 This fixes a porting bug on hosts like 64-bit HP-UX, where
2102 socklen_t is wider than int (Bug#8277).
2103 (Fmake_network_process, server_accept_connection):
2104 (wait_reading_process_output, read_process_output):
2105 Likewise.
2106
2107 * process.c: Rename or move locals to avoid shadowing.
2108 (list_processes_1, Fmake_network_process):
2109 (read_process_output_error_handler, exec_sentinel_error_handler):
2110 Rename or move locals.
2111 (Fmake_network_process): Define label "retry_connect" only if needed.
2112 (Fnetwork_interface_info): Fix pointer signedness.
2113 (process_send_signal): Add cast to avoid pointer signedness problem.
2114 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2115 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2116
2117 Make tparam.h and terminfo.c consistent.
2118 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2119 Include tparam.h instead, since it declares them.
2120 * cm.h (PC): Remove extern decl; tparam.h now does this.
2121 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2122 * terminfo.c: Include tparam.h, to check interfaces.
2123 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2124 (tparam): Adjust signature to match interface in tparam.h;
2125 this removes some undefined behavior. Check that outstring and len
2126 are zero, which they always are with Emacs.
2127 * tparam.h (PC, BC, UP): New extern decls.
2128
2129 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2130 (xftfont_open): Rename locals to avoid shadowing.
2131
2132 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2133 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2134 (OTF_TAG_SYM): Omit macro if not needed.
2135 (ftfont_list): Remove unused local.
2136 (get_adstyle_property, ftfont_pattern_entity):
2137 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2138 Rename locals to avoid shadowing.
2139
2140 * xfont.c (xfont_list_family): Mark var as initialized.
2141
2142 * xml.c (make_dom): Now static.
2143
2144 * composite.c (composition_compute_stop_pos): Rename local to
2145 avoid shadowing.
2146 (composition_reseat_it): Remove unused locals.
2147 (find_automatic_composition, composition_adjust_point): Likewise.
2148 (composition_update_it): Mark var as initialized.
2149 (find_automatic_composition): Mark vars as initialized,
2150 with a FIXME (Bug#8290).
2151
2152 character.h: Rename locals to avoid shadowing.
2153 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2154 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2155 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2156 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2157 to avoid shadowing.
2158
2159 * textprop.c (property_change_between_p): Remove; unused.
2160
2161 * intervals.c (interval_start_pos): Now static.
2162
2163 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2164
2165 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2166 Rename locals to avoid shadowing.
2167
2168 * sound.c (wav_play, au_play, Fplay_sound_internal):
2169 Fix pointer signedness.
2170 (alsa_choose_format): Remove unused local var.
2171 (wav_play): Initialize a variable to 0, to prevent undefined
2172 behavior (Bug#8278).
2173
2174 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2175
2176 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2177
2178 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2179 clobbering (Bug#8298).
2180 * sysdep.c (sys_subshell): Likewise.
2181 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2182
2183 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2184 This should get cleaned up, so that child_setup has the
2185 same signature on all platforms.
2186
2187 * callproc.c (call_process_cleanup): Now static.
2188 (relocate_fd): Rename locals to avoid shadowing.
2189
2190 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2191
2192 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2193 not to be necessary, and produces flickering.
2194
2195 2011-03-20 Glenn Morris <rgm@gnu.org>
2196
2197 * config.in: Remove file.
2198
2199 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2200
2201 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2202 are now in src/globals.h.
2203 (syms_of_minibuf): Remove spurious & from previous change.
2204
2205 2011-03-20 Leo <sdl.web@gmail.com>
2206
2207 * minibuf.c (completing-read-function): New variable.
2208 (completing-read-default): Rename from completing-read.
2209 (completing-read): Call completing-read-function.
2210
2211 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2212
2213 * xfaces.c (Fx_load_color_file):
2214 Read color file from absolute filename (bug#8250).
2215
2216 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2217
2218 * makefile.w32-in: Update dependencies.
2219
2220 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2221
2222 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2223
2224 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2225
2226 Fix more problems found by GCC 4.5.2's static checks.
2227
2228 * process.c (make_serial_process_unwind, send_process_trap):
2229 (sigchld_handler): Now static.
2230
2231 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2232 That way, the code declares only the vars that it needs.
2233 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2234 * s/cygwin.h (PTY_ITERATION): Likewise.
2235 * s/darwin.h (PTY_ITERATION): Likewise.
2236 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2237
2238 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2239 * process.c (allocate_pty): Don't declare stb unless it's needed.
2240
2241 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2242 (CONSTANTLIM): Remove; unused.
2243 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2244 Define only if needed.
2245
2246 * unexelf.c (unexec): Name an expression,
2247 to avoid gcc -Wbad-function-cast warning.
2248 Use a different way to cause a compilation error if anyone uses
2249 n rather than nn, a way that does not involve shadowing.
2250 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2251
2252 * deps.mk (unexalpha.o): Remove; unused.
2253
2254 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2255 * unexec.h: New file.
2256 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2257 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2258 Depend on unexec.h.
2259 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2260 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2261 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2262 Change as necessary to match prototype in unexec.h.
2263
2264 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2265 shadowing.
2266 (back_comment, skip_chars): Mark vars as initialized.
2267
2268 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2269 Rename locals to avoid shadowing.
2270
2271 * lread.c (read1): Rewrite so as not to use empty "else".
2272 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2273
2274 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2275
2276 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2277 warning when compiling print.c.
2278
2279 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2280 instead of using an uninitialized var.
2281 (font_sort_entities): Mark var as initialized.
2282
2283 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2284
2285 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2286 pointers to constants.
2287 (font_parse_fcname): Remove unused vars.
2288 (font_delete_unmatched): Now static.
2289 (font_get_spec): Remove; unused.
2290 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2291 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2292 Rename or move locals to avoid shadowing.
2293
2294 * fns.c (require_nesting_list, require_unwind): Now static.
2295 (Ffillarray): Rename locals to avoid shadowing.
2296
2297 * floatfns.c (domain_error2): Define only if needed.
2298 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2299
2300 * alloc.c (mark_backtrace): Move decl from here ...
2301 * lisp.h: ... to here, so that it can be checked.
2302
2303 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2304 (Fdefvar): Rewrite so as not to use empty "else".
2305 (lisp_indirect_variable): Name an expression,
2306 to avoid gcc -Wbad-function-cast warning.
2307 (Fdefvar): Rename locals to avoid shadowing.
2308
2309 * callint.c (quotify_arg, quotify_args): Now static.
2310 (Fcall_interactively): Rename locals to avoid shadowing.
2311 Use const pointer when appropriate.
2312
2313 * lisp.h (get_system_name, get_operating_system_release):
2314 Move decls here, to check interfaces.
2315 * process.c (get_operating_system_release): Move decl to lisp.h.
2316 * xrdb.c (get_system_name): Likewise.
2317 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2318 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2319 some of which prompt warnings from gcc -Wbad-function-cast.
2320 (Fformat_time_string, Fencode_time, Finsert_char):
2321 (Ftranslate_region_internal, Fformat):
2322 Rename or remove local vars to avoid shadowing.
2323 (Ftranslate_region_internal): Mark var as initialized.
2324
2325 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2326 avoid shadowing.
2327
2328 * lisp.h (eassert): Check that the argument compiles, even if
2329 ENABLE_CHECKING is not defined.
2330
2331 * data.c (Findirect_variable): Name an expression, to avoid
2332 gcc -Wbad-function-cast warning.
2333 (default_value, arithcompare, arith_driver, arith_error): Now static.
2334 (store_symval_forwarding): Rename local to avoid shadowing.
2335 (Fmake_variable_buffer_local, Fmake_local_variable):
2336 Mark variables as initialized.
2337 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2338
2339 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2340 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2341 Rename locals to avoid shadowing.
2342 (mark_stack): Move local variables into the #ifdef region where
2343 they're used.
2344 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2345 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2346 needed otherwise.
2347 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2348 (GC_STRING_CHARS): Remove; not used.
2349 (Fmemory_limit): Cast sbrk's returned value to char *.
2350
2351 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2352 avoids undefined behavior in theory.
2353
2354 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2355
2356 Use functions, not macros, for up- and down-casing (Bug#8254).
2357 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2358 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2359 to use the following functions instead of these macros.
2360 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2361 EMACS_INT, since callers assume the returned value fits in int.
2362 (upcase1): Likewise, for UPCASE_TABLE.
2363 (uppercasep, lowercasep, upcase): New static inline functions.
2364 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2365 the race-condition problem in the old DOWNCASE.
2366
2367 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2368 Rename locals to avoid shadowing.
2369 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2370 (regex_compile, re_search_2, re_match_2_internal):
2371 Remove unused local vars.
2372 (FREE_VAR): Rewrite so as not to use empty "else",
2373 which gcc can warn about.
2374 (regex_compile, re_match_2_internal): Mark locals as initialized.
2375 (RETALLOC_IF): Define only if needed.
2376 (WORDCHAR_P): Likewise. This one is never needed, but is used
2377 only in a comment talking about a compiler bug, so put inside
2378 the #if 0 of that comment.
2379 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2380 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2381 Remove; unused.
2382
2383 * search.c (boyer_moore): Rename locals to avoid shadowing.
2384 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2385 (PREV_CHAR_BOUNDARY): Likewise.
2386
2387 * search.c (simple_search): Remove unused var.
2388
2389 * dired.c (compile_pattern): Move decl from here ...
2390 * lisp.h: ... to here, so that it can be checked.
2391 (struct re_registers): New forward decl.
2392
2393 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2394
2395 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2396 All uses changed.
2397 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2398 Rename locals to avoid shadowing.
2399 (Fvertical_motion): Mark locals as initialized.
2400
2401 * casefiddle.c (casify_object, casify_region): Now static.
2402 (casify_region): Mark local as initialized.
2403
2404 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2405
2406 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2407 New macros, so that the caller can use some names other than
2408 gcpro1, gcpro2, etc.
2409 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2410 of the new macros.
2411 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2412 argument, for consistency with GCPRO2_VAR, etc: it is now the
2413 prefix of the variable, not the variable itself. All uses
2414 changed.
2415 * dired.c (directory_files_internal, file_name_completion):
2416 Rename locals to avoid shadowing.
2417
2418 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2419 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2420 dired.c's scmp function, had undefined behavior.
2421 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2422 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2423 * buffer.h: ... to here, because these macros use current_buffer,
2424 and the new implementation with inline functions needs to have
2425 current_buffer in scope now, rather than later when the macros
2426 are used.
2427 (downcase, upcase1): New static inline functions.
2428 (DOWNCASE, UPCASE1): Reimplement using these functions.
2429 This avoids undefined behavior in expressions like
2430 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2431 from race conditions in accessing the global variables
2432 case_temp1 and case_temp2.
2433 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2434 * lisp.h (case_temp1, case_temp2): Remove their decls.
2435 * character.h (ASCII_CHAR_P): Move from here ...
2436 * lisp.h: ... to here, so that the inline functions mentioned
2437 above can use them.
2438
2439 * dired.c (directory_files_internal_unwind): Now static.
2440
2441 * fileio.c (file_name_as_directory, directory_file_name):
2442 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2443 Now static.
2444 (file_name_as_directory): Use const pointers when appropriate.
2445 (Fexpand_file_name): Likewise. In particular, newdir might
2446 point at constant storage, so make it a const pointer.
2447 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2448 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2449 signedness issues.
2450 (Fset_file_times, Finsert_file_contents, auto_save_error):
2451 Rename locals to avoid shadowing.
2452
2453 * minibuf.c (choose_minibuf_frame_1): Now static.
2454 (Ftry_completion, Fall_completions): Rename or remove locals
2455 to avoid shadowing.
2456
2457 * marker.c (bytepos_to_charpos): Remove; unused.
2458
2459 * lisp.h (verify_bytepos, count_markers): New decls,
2460 so that gcc does not warn that these functions aren't declared.
2461
2462 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2463 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2464 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2465 (copy_text): Remove unused local var.
2466
2467 * filelock.c (within_one_second): Now static.
2468 (lock_file_1): Rename local to avoid shadowing.
2469
2470 * buffer.c (fix_overlays_before): Mark locals as initialized.
2471 (fix_start_end_in_overlays): Likewise. This function should be
2472 simplified by using pointers-to-pointers, but that's a different
2473 matter.
2474 (switch_to_buffer_1): Now static.
2475 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2476 (report_overlay_modification): Rename locals to avoid shadowing.
2477
2478 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2479 Fix pointer signedness issue.
2480 (sys_subshell): Mark local as volatile if checking for lint,
2481 to suppress a gcc -Wclobbered warning that does not seem to be right.
2482 (MAXPATHLEN): Define only if needed.
2483
2484 * process.c (serial_open, serial_configure): Move decls from here ...
2485 * systty.h: ... to here, so that they can be checked.
2486
2487 * fns.c (get_random, seed_random): Move extern decls from here ...
2488 * lisp.h: ... to here, so that they can be checked.
2489
2490 * sysdep.c (reset_io): Now static.
2491 (wait_for_termination_signal): Remove; unused.
2492
2493 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2494 (copy_keymap_item, append_key, push_text_char_description):
2495 Now static.
2496 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2497 (DENSE_TABLE_SIZE): Remove; unused.
2498 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2499 (describe_map_tree):
2500 Rename locals to avoid shadowing.
2501
2502 * keyboard.c: Declare functions static if they are not used elsewhere.
2503 (echo_char, echo_dash, cmd_error, top_level_2):
2504 (poll_for_input, handle_async_input): Now static.
2505 (read_char, kbd_buffer_get_event, make_lispy_position):
2506 (make_lispy_event, make_lispy_movement, apply_modifiers):
2507 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2508 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2509 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2510 (read_key_sequence, read_char): Mark locals as initialized.
2511 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2512
2513 * keyboard.h (make_ctrl_char): New decl.
2514 (mark_kboards): Move decl here ...
2515 * alloc.c (mark_kboards): ... from here.
2516
2517 * lisp.h (force_auto_save_soon): New decl.
2518
2519 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2520 (DEFINE_DUMMY_FUNCTION): New macro.
2521 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2522 Use it.
2523 (main): Add casts to avoid warnings
2524 if GCC considers string literals to be constants.
2525
2526 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2527
2528 * dbusbind.c: Pointer signedness fixes.
2529 (xd_signature, xd_append_arg, xd_initialize):
2530 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2531 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2532 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2533 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2534
2535 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2536 if GCC considers string literals to be constants.
2537 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2538
2539 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2540
2541 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2542 (print_preprocess, print_object): New macro to fix last change.
2543
2544 * print.c (print_preprocess): Don't forget font objects.
2545
2546 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2547
2548 * emacs.c (USAGE3): Doc fixes.
2549
2550 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2551
2552 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2553 structure.
2554
2555 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2556
2557 * lisp.h (VWindow_system, Qfile_name_history):
2558 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2559 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2560 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2561
2562 * w32select.c: Don't #include "keyboard.h".
2563 (run_protected): Add extern declaration for waiting_for_input.
2564
2565 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2566 * w32console.c (detect_input_pending, read_input_pending)
2567 (encode_terminal_code):
2568 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2569 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2570 (w32_system_caret_y, Qfile_name_history):
2571 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2572 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2573 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2574 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2575 * w32proc.c (Qlocal, report_file_error):
2576 * w32term.c (Vwindow_system, updating_frame):
2577 * w32uniscribe.c (initialized, uniscribe_font_driver):
2578 Remove unneeded extern declarations.
2579
2580 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2581
2582 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2583
2584 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2585
2586 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2587 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2588 These macros can no longer be used for assignment.
2589
2590 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2591 Assign struct members directly, instead of using BUF_BEGV etc.
2592 (record_buffer_markers, fetch_buffer_markers): New functions for
2593 recording and fetching special buffer markers.
2594 (set_buffer_internal_1, set_buffer_temp): Use them.
2595
2596 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2597
2598 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2599
2600 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2601 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2602
2603 * xdisp.c (hscroll_window_tree):
2604 (reconsider_clip_changes): Use PT instead of BUF_PT.
2605
2606 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2607
2608 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2609 $(EMACS_ROOT)/lib/intprops.h.
2610
2611 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 Fix more problems found by GCC 4.5.2's static checks.
2614
2615 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2616 to unsigned char * to avoid compiler diagnostic.
2617 (xg_free_frame_widgets): Make it clear that a local variable is
2618 needed only if USE_GTK_TOOLTIP.
2619 (gdk_window_get_screen): Make it clear that this macro is needed
2620 only if USE_GTK_TOOLTIP.
2621 (int_gtk_range_get_value): New function, which avoids a diagnostic
2622 from gcc -Wbad-function-cast.
2623 (xg_set_toolkit_scroll_bar_thumb): Use it.
2624 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2625 diagnostic from gcc -Wbad-function-cast.
2626 (get_utf8_string, xg_get_file_with_chooser):
2627 Rename locals to avoid shadowing.
2628 (create_dialog): Move locals to avoid shadowing.
2629
2630 * xgselect.c (xg_select): Remove unused var.
2631
2632 * image.c (four_corners_best): Mark locals as initialized.
2633 (gif_load): Initialize transparent_p to zero (Bug#8238).
2634 Mark another local as initialized.
2635 (my_png_error, my_error_exit): Mark with NO_RETURN.
2636
2637 * image.c (clear_image_cache): Now static.
2638 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2639 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2640 (x_edge_detection): Remove unnecessary cast that
2641 gcc -Wbad-function-cast diagnoses.
2642 (gif_load): Fix pointer signedness.
2643 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2644 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2645
2646 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2647
2648 Improve quality of tests for time stamp overflow.
2649 For example, without this patch (encode-time 0 0 0 1 1
2650 1152921504606846976) returns the obviously-bogus value (-948597
2651 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2652 reports time overflow. See
2653 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2654 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2655 * editfns.c: Include limits.h and intprops.h.
2656 (TIME_T_MIN, TIME_T_MAX): New macros.
2657 (time_overflow): Move earlier, to before first use.
2658 (hi_time, lo_time): New functions, for an accurate test for
2659 out-of-range times.
2660 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2661 (Fget_internal_run_time): Don't assume time_t fits in int.
2662 (make_time): Use list2 instead of Fcons twice.
2663 (Fdecode_time): More accurate test for out-of-range times.
2664 (check_tm_member): New function.
2665 (Fencode_time): Use it, to test for out-of-range times.
2666 (lisp_time_argument): Don't rely on undefined left-shift and
2667 right-shift behavior when checking for time stamp overflow.
2668
2669 * editfns.c (time_overflow): New function, refactoring common code.
2670 (Fformat_time_string, Fdecode_time, Fencode_time):
2671 (Fcurrent_time_string): Use it.
2672
2673 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2674 * dired.c (make_time): Move to ...
2675 * editfns.c (make_time): ... here.
2676 * systime.h: Note the move.
2677
2678 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2679
2680 * fringe.c (update_window_fringes): Remove unused variables.
2681
2682 * unexmacosx.c (copy_data_segment): Also copy __got section.
2683 (Bug#8223)
2684
2685 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2686
2687 * termcap.c [MSDOS]: Include "msdos.h".
2688 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2689 Constify `char *' arguments and their references according to
2690 prototypes in tparam.h.
2691
2692 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2693
2694 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2695 Adapt all references accordingly.
2696
2697 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2698
2699 2011-03-11 Tom Tromey <tromey@redhat.com>
2700
2701 * buffer.c (syms_of_buffer): Remove obsolete comment.
2702
2703 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2704
2705 * termhooks.h (encode_terminal_code): Declare prototype.
2706
2707 * msdos.c (encode_terminal_code): Don't declare prototype.
2708
2709 * term.c (encode_terminal_code): Now external again, used by
2710 w32console.c and msdos.c.
2711
2712 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2713 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2714
2715 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2716
2717 Fix some minor problems found by GCC 4.5.2's static checks.
2718
2719 * fringe.c (update_window_fringes): Mark locals as initialized
2720 (Bug#8227).
2721 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2722
2723 * alloc.c (mark_fringe_data): Move decl from here ...
2724 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2725 to check its interface.
2726 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2727
2728 * fontset.c (free_realized_fontset): Now static.
2729 (Fset_fontset_font): Rename local to avoid shadowing.
2730 (fontset_font): Mark local as initialized.
2731 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2732
2733 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2734
2735 * xselect.c (x_disown_buffer_selections): Remove; not used.
2736 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2737 (x_own_selection, Fx_disown_selection_internal): Rename locals
2738 to avoid shadowing.
2739 (x_handle_dnd_message): Remove local to avoid shadowing.
2740
2741 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2742 so that the caller can use some name other than gcpro1.
2743 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2744 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2745 (Fx_backspace_delete_keys_p):
2746 Use them to avoid shadowing, and rename vars to avoid shadowing.
2747 (x_decode_color, x_set_name, x_window): Now static.
2748 (Fx_create_frame): Add braces to silence GCC warning.
2749 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2750 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2751 Remove unused locals.
2752 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2753 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2754 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2755 macros.
2756
2757 * xterm.h (x_mouse_leave): New decl.
2758
2759 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2760 Remove unused functions.
2761 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2762 (x_calc_absolute_position): Now static.
2763 (XTread_socket): Don't define label "out" unless it's used.
2764 Don't declare local "event" unless it's used.
2765 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2766 unless they are used.
2767 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2768 (x_fatal_error_signal): Remove; not used.
2769 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2770 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2771 (x_error_catcher, x_connection_closed, x_error_handler):
2772 (x_error_quitter, xembed_send_message, x_iconify_frame):
2773 (my_log_handler): Rename locals to avoid shadowing.
2774 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2775 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2776
2777 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2778 Rename or move locals to avoid shadowing.
2779 (tty_defined_color, merge_face_heights): Now static.
2780 (free_realized_faces_for_fontset): Remove; not used.
2781 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2782 does not deduce is never used uninitialized.
2783 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2784 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2785
2786 * terminal.c (store_terminal_param): Now static.
2787
2788 * xmenu.c (menu_highlight_callback): Now static.
2789 (set_frame_menubar): Remove unused local.
2790 (xmenu_show): Rename parameter to avoid shadowing.
2791 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2792 since they might point to immutable storage.
2793 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2794 since it's unused otherwise.
2795
2796 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2797 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2798 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2799 avoids a gcc -Wuninitialized diagnostic.
2800 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2801 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2802 does not deduce are never used uninitialized.
2803
2804 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2805
2806 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2807 * window.c (window_loop, size_window):
2808 (run_window_configuration_change_hook, enlarge_window): Likewise.
2809
2810 * window.c (display_buffer): Now static.
2811 (size_window): Mark variables that gcc -Wuninitialized
2812 does not deduce are never used uninitialized.
2813 * window.h (check_all_windows): New decl, to forestall
2814 gcc -Wmissing-prototypes diagnostic.
2815 * dispextern.h (bidi_dump_cached_states): Likewise.
2816
2817 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2818 shadowing.
2819 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2820 Include <limits.h>.
2821 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2822 and to avoid gcc -Wuninitialized warning.
2823 (load_charset_map): Mark variables that gcc -Wuninitialized
2824 does not deduce are never used uninitialized.
2825 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2826
2827 * coding.c (coding_set_source, coding_set_destination):
2828 Use "else { /* comment */ }" rather than "else /* comment */;"
2829 for clarity, and to avoid gcc -Wempty-body warning.
2830 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2831 a block, when the outer 'i' will do.
2832 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2833 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2834 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2835 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2836 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2837 Rename locals to avoid shadowing.
2838 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2839 * coding.c (emacs_mule_char, encode_invocation_designation):
2840 Now static, since they're not used elsewhere.
2841 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2842 (decode_coding_object, encode_coding_object, detect_coding_system):
2843 (decode_coding_emacs_mule): Mark variables that gcc
2844 -Wuninitialized does not deduce are never used uninitialized.
2845 (detect_coding_iso_2022): Initialize a local variable that might
2846 be used uninitialized. Leave a FIXME because it's not clear that
2847 this initialization is needed. (Bug#8211)
2848 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2849 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2850 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2851 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2852 Remove unused macros.
2853
2854 * category.c (hash_get_category_set): Remove unused local var.
2855 (copy_category_table): Now static, since it's not used elsewhere.
2856 * character.c (string_count_byte8): Likewise.
2857
2858 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2859 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2860
2861 * chartab.c (copy_sub_char_table): Now static, since it's not used
2862 elsewhere.
2863 (sub_char_table_ref_and_range, char_table_ref_and_range):
2864 Rename locals to avoid shadowing.
2865 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2866
2867 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2868 (BIDI_BOB): Remove unused macro.
2869
2870 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2871 deduce are never used uninitialized.
2872 * term.c (encode_terminal_code): Likewise.
2873
2874 * term.c (encode_terminal_code): Now static. Remove unused local.
2875
2876 * tparam.h: New file.
2877 * term.c, tparam.h: Include it.
2878 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2879 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2880 Move these decls to tparam.h, and make them agree with what
2881 is actually in tparam.c. The previous trick of using incompatible
2882 decls in different modules does not conform to the C standard.
2883 All callers of tparam changed to use tparam's actual API.
2884 * tparam.c (tparam1, tparam, tgoto):
2885 Use const pointers where appropriate.
2886
2887 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2888 * cm.h (struct cm): Likewise.
2889 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2890 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2891 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2892 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2893 (turn_on_face, init_tty): Likewise.
2894 * termchar.h (struct tty_display_info): Likewise.
2895
2896 * term.c (term_mouse_position): Rename local to avoid shadowing.
2897
2898 * alloc.c (mark_ttys): Move decl from here ...
2899 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2900
2901 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2902
2903 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2904
2905 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2906
2907 * search.c (compile_pattern_1): Remove argument regp, unused since
2908 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2909 (compile_pattern): Don't pass it.
2910
2911 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2912
2913 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2914 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2915 for ! HAVE_GTK3.
2916 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2917
2918 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2919
2920 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2921 gdk_window_get_screen, gdk_window_get_geometry,
2922 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2923 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2924 (xg_get_pixbuf_from_pixmap): New function.
2925 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2926 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2927 Call xg_get_pixbuf_from_pixmap instead of
2928 gdk_pixbuf_get_from_drawable.
2929 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2930 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2931 (xg_check_special_colors): Use GtkStyleContext and its functions
2932 for HAVE_GTK3.
2933 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2934 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2935 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2936 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2937 Call gtk_widget_get_preferred_size.
2938 (xg_frame_resized): gdk_window_get_geometry only takes 5
2939 parameters.
2940 (xg_win_to_widget, xg_event_is_for_menubar):
2941 Call gdk_x11_window_lookup_for_display.
2942 (xg_set_widget_bg): New function.
2943 (delete_cb): New function.
2944 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2945 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2946 (xg_set_background_color): Call xg_set_widget_bg.
2947 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2948 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2949 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2950 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2951 if ! HAVE_GTK3.
2952 (update_frame_tool_bar): Call gtk_widget_hide.
2953 (xg_initialize): Use GDK_KEY_g.
2954
2955 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2956 if ! HAVE_GTK3
2957 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2958
2959 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2960 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2961 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2962
2963 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2964
2965 * w32xfns.c (select_palette): Check success of RealizePalette against
2966 GDI_ERROR, not zero.
2967
2968 See ChangeLog.11 for earlier changes.
2969
2970 ;; Local Variables:
2971 ;; coding: utf-8
2972 ;; End:
2973
2974 Copyright (C) 2011 Free Software Foundation, Inc.
2975
2976 This file is part of GNU Emacs.
2977
2978 GNU Emacs is free software: you can redistribute it and/or modify
2979 it under the terms of the GNU General Public License as published by
2980 the Free Software Foundation, either version 3 of the License, or
2981 (at your option) any later version.
2982
2983 GNU Emacs is distributed in the hope that it will be useful,
2984 but WITHOUT ANY WARRANTY; without even the implied warranty of
2985 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2986 GNU General Public License for more details.
2987
2988 You should have received a copy of the GNU General Public License
2989 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.