1 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3 * keyboard.c: Export real-this-command to Elisp.
4 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
5 and DEFVAR it. Update all users.
7 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
9 * minibuf.c (Fassoc_string): Remove duplicate declaration.
11 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
12 Convert pctcpu and pctmem to Lisp float properly.
13 Let the compiler fold better, as 100.0/0x8000 is exact.
15 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
17 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
20 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
22 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
24 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
26 For a 'struct window', replace some Lisp_Object fields to
27 bitfields where appropriate, remove unused fields.
28 * window.h (struct window): Remove unused 'last_mark_x' and
29 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
30 change it's type from Lisp_Object to bitfield.
31 Change type of 'force_start', 'optional_new_start',
32 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
33 fields from Lisp_Object to bitfield. Adjust users accordingly.
35 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
37 Pacify gcc -Wdouble-precision when using Xaw.
38 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
39 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
40 Use 'float' consistently, rather than 'float' in most places
41 and 'double' in a couple of places.
43 2012-05-31 Eli Zaretskii <eliz@gnu.org>
45 * xdisp.c (handle_stop): Detect whether we have overlay strings
46 loaded by testing it->current.overlay_string_index to be
47 non-negative, instead of checking whether n_overlay_strings is
50 2012-05-31 Chong Yidong <cyd@gnu.org>
52 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
54 * doc.c (Fsubstitute_command_keys): Doc fix.
56 2012-05-31 Eli Zaretskii <eliz@gnu.org>
58 * search.c (search_buffer): Remove calls to
59 r_alloc_inhibit_buffer_relocation, as it is now called by
60 maybe_unify_char, which was the cause of relocation of buffer text
63 2012-05-31 Eli Zaretskii <eliz@gnu.org>
65 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
66 for the duration of call to load_charset, to avoid problems with
67 callers of maybe_unify_char that access buffer text through C
70 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
71 decrement the inhibition flag, instead of just setting or
74 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
76 Remove obsolete '#define static' cruft.
77 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
78 This #undef was "temporary" in 2000; it is no longer needed
79 now that '#define static' has gone away.
80 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
81 (gray_bitmap_bits): Remove; no longer needed.
82 All uses replaced with definiens.
83 * xterm.c: Include "bitmaps/gray.xbm".
85 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
87 Clean up __executable_start, monstartup when --enable-profiling.
88 The following changes affect the code only when profiling.
89 * dispnew.c (__executable_start): Rename from safe_bcopy.
90 Define only on platforms that need it.
91 * emacs.c: Include <sys/gmon.h> when profiling.
92 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
93 (__executable_start): Remove decl, since lisp.h does it now.
94 (safe_bcopy): Remove decl; no longer has that name.
95 (main): Coalesce #if into single bit of code, for simplicity.
96 Cast pointers to uintptr_t, since standard libraries want integers
98 * lisp.h (__executable_start): New decl.
100 2012-05-31 Glenn Morris <rgm@gnu.org>
102 * image.c (Fimagemagick_types): Doc fix.
104 2012-05-30 Jim Meyering <meyering@redhat.com>
106 * callproc.c (Fcall_process_region): Include directory component
107 in mkstemp error message (Bug#11586).
109 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
111 * alloc.c, lisp.h (make_pure_vector): Now static.
113 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
115 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
117 (Fautoload): Do the hash-doc more carefully.
118 * data.c (Fdefalias): Purify definition, except for keymaps.
119 (Qdefun): Move from eval.c.
120 * lisp.h (Qdefun): Remove.
121 * lread.c (read1): Tiny simplification.
123 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
125 Do not create empty overlays with the evaporate property (Bug#9642).
126 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
127 Bug#9642, but explicitly check that the buffer the overlay would
128 be moved to is live and rearrange lines to make sure that errors
129 will not put the overlay in an inconsistent state.
130 (Fdelete_overlay): Cosmetics.
132 2012-05-28 Eli Zaretskii <eliz@gnu.org>
134 * w32term.c (my_bring_window_to_top): New function.
135 (x_raise_frame): Use handle returned by DeferWindowPos, which
136 could be different from the original one.
137 Call my_bring_window_to_top instead of my_set_foreground_window.
140 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
141 by calling BringWindowToTop.
143 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
144 (WM_EMACS_END): Increase by one.
146 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
148 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
149 This avoids undefined behavior that might cause the eassert
150 to not catch an out-of-range value.
152 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
154 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
157 2012-05-27 Eli Zaretskii <eliz@gnu.org>
159 * bidi.c (bidi_mirror_char): Fix last change.
161 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
163 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
164 when referring to sectname field in printf format.
166 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
168 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
169 Only r_alloc_inhibit_buffer_relocation needed to be added;
170 the others were already declared.
172 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
173 before checking whether it's out of range. Put the check inside
175 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
177 2012-05-27 Ken Brown <kbrown@cornell.edu>
179 * callproc.c (Fcall_process): Restore a line that was accidentally
180 commented out in the 2011-02-13 change (bug#11547).
182 2012-05-27 Eli Zaretskii <eliz@gnu.org>
184 * lisp.h [REL_ALLOC]: Add prototypes for external functions
187 * buffer.c [REL_ALLOC]: Remove prototypes of
188 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
189 they are now on lisp.h.
191 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
193 * search.c (search_buffer): Use it to inhibit relocation of buffer
194 text while re_search_2 is doing its job, because re_search_2 is
195 passed C pointers to buffer text. (Bug#11519)
197 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
200 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
201 state after an additional call to move_it_in_display_line_to, keep
202 the values of it->max_ascent and it->max_descent found for the
204 (pos_visible_p): Revert the comparison against bottom_y to what it
205 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
208 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
210 Fix coding-related core dumps with gcc -ftrapv.
211 The code was computing A - B, where A and B are pointers, and B is
212 random garbage. This can lead to core dumps on platforms that
213 have special pointer registers, and it also leads to core dumps on
214 x86-64 when compiled with gcc -ftrapv. The fix is to compute
215 A - B only when B is initialized properly.
216 * coding.c (coding_set_source, coding_set_destination): Return void.
217 (coding_change_source, coding_change_destinations): New functions,
218 with the old behaviors of coding_set_source and coding_set_destination.
219 All callers that need an offset changed to use these new functions.
221 2012-05-26 Glenn Morris <rgm@gnu.org>
223 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
225 2012-05-26 Eli Zaretskii <eliz@gnu.org>
227 Extend mouse support on W32 text-mode console.
228 * xdisp.c (draw_row_with_mouse_face):
229 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
231 * w32console.c: Include window.h.
232 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
234 (initialize_w32_display): Initialize mouse-highlight data.
236 * w32inevt.c: Include termchar.h and window.h.
237 (do_mouse_event): Support mouse-autoselect-window. When the mouse
238 moves, call note_mouse_highlight. If help_echo changed, call
239 gen_help_event to produce help-echo message in the echo area.
240 Call clear_mouse_face if mouse_face_hidden is set in the mouse
243 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
245 * lread.c (read1): Simplify slightly to avoid an overflow warning
246 with GCC 4.7.0 on x86-64.
248 2012-05-26 Eli Zaretskii <eliz@gnu.org>
250 * bidi.c (bidi_mirror_char): Revert last change: an int is
251 definitely wide enough here.
253 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
255 Fix integer width and related bugs (Bug#9874).
256 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
257 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
258 (string_bytes, check_sblock, allocate_string_data):
259 (compact_small_strings, Fmake_bool_vector, make_string)
260 (make_unibyte_string, make_multibyte_string)
261 (make_string_from_bytes, make_specified_string)
262 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
263 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
266 (allocate_pseudovector):
267 Use int, not EMACS_INT, where int is wide enough.
268 (inhibit_garbage_collection, Fgarbage_collect):
269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
270 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
271 int might not be wide enough.
272 (bidi_cache_search, bidi_cache_find, bidi_init_it)
273 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
274 (bidi_at_paragraph_end, bidi_find_paragraph_start)
275 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
276 (bidi_level_of_next_char, bidi_move_to_visually_next):
277 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
278 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
279 (Fkill_buffer, Fset_buffer_major_mode)
280 (advance_to_char_boundary, Fbuffer_swap_text)
281 (Fset_buffer_multibyte, overlays_at, overlays_in)
282 (overlay_touches_p, struct sortvec, record_overlay_string)
283 (overlay_strings, recenter_overlay_lists)
284 (adjust_overlays_for_insert, adjust_overlays_for_delete)
285 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
286 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
287 (Foverlay_recenter, last_overlay_modification_hooks_used)
288 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
289 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
290 (validate_region): Omit unnecessary test for b <= e,
291 since that's guaranteed by the previous test.
292 (adjust_overlays_for_delete): Avoid pos + length overflow.
293 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
294 (report_overlay_modification):
295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
296 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
297 Omit pointer cast, which isn't needed anyway, and doesn't work
298 after the EMACS_INT -> ptrdiff_t change.
299 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
300 * buffer.h: Adjust decls to match defn changes elsewhere.
301 (struct buffer_text, struct buffer):
302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
303 Use EMACS_INT, not int, where int might not be wide enough.
304 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
305 not int, to avoid needless 32-bit limit on 64-bit hosts.
306 (exec_byte_code): Use tighter memory-full test, one that checks
307 for alloca overflow. Don't compute the address of the object just
308 before an array, as that's not portable. Use EMACS_INT, not
309 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
310 * callint.c (Fcall_interactively):
311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
312 * callproc.c (call_process_kill, Fcall_process):
313 Don't assume pid_t fits into an Emacs fixnum.
314 (call_process_cleanup, Fcall_process, child_setup):
315 Don't assume pid_t fits into int.
316 (call_process_cleanup, Fcall_process, delete_temp_file)
317 (Fcall_process_region):
318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
319 (Fcall_process): Simplify handling of volatile integers.
320 Use int, not EMACS_INT, where int will do.
321 * casefiddle.c (casify_object, casify_region, operate_on_word)
322 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
324 (casify_object): Avoid integer overflow when overallocating buffer.
325 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
326 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
327 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
328 * category.h (CATEGORYP): Don't assume arg is nonnegative.
329 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
330 integers are now checked earlier. All uses replaced with XINT.
332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
333 For CCL_MapSingle, check that content and value are in int range.
334 (ccl_driver, Fregister_code_conversion_map):
335 Check that Vcode_version_map_vector is a vector.
336 (resolve_symbol_ccl_program): Check that vector header is in range.
337 Always copy the vector, so that we can check its contents reliably
338 now rather than having to recheck each instruction as it's being
339 executed. Check that vector words fit in 'int'.
340 (ccl_get_compiled_code, Fregister_ccl_program)
341 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
342 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
343 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
344 contents are in range.
345 (Fccl_execute_on_string): Check that status is in range.
346 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
347 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
348 Accept and return EMACS_INT, not int, because callers can pass values
350 (c_string_width, strwidth, lisp_string_width, chars_in_text)
351 (multibyte_chars_in_text, parse_str_as_multibyte)
352 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
353 (str_as_unibyte, str_to_unibyte, string_count_byte8)
354 (string_escape_byte8, Fget_byte):
355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
356 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
357 avoid mishandling large integers.
358 * character.h: Adjust decls to match defn changes elsewhere.
359 * charset.c (load_charset_map_from_file, find_charsets_in_text)
360 (Ffind_charset_region):
361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
362 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
363 (load_charset_map_from_vector, Fdefine_charset_internal):
364 Don't assume fixnum fits in int.
365 (load_charset_map_from_vector, Fmap_charset_chars):
366 Remove now-unnecessary CHECK_NATNUMs.
367 (Fdefine_charset_internal): Check ranges here, more carefully.
368 Don't rely on undefined behavior with signed left shift overflow.
369 Don't assume unsigned int fits into fixnum, or that fixnum fits
370 into unsigned int. Don't require max_code to be a valid fixnum;
371 that's not true for gb10830 4-byte on a 32-bit host. Allow
372 invalid_code to be a cons, for the same reason. Require code_offset
373 to be a character. Avoid int overflow if max_char is close
375 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
376 this is intended anyway and avoids some undefined behavior.
377 (load_charset_map): Pass unsigned, not int, as 2nd arg of
378 INDEX_TO_CODE_POINT, as that's what it expects.
379 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
380 * charset.h (DECODE_CHAR): Return int, not unsigned;
381 this is what was intended anyway, and it avoids undefined behavior.
382 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
383 integer-overflow issues.
384 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
385 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
386 where the argument is EMACS_INT, and this behavior is not intended.
387 * chartab.c (Fmake_char_table, Fset_char_table_range)
388 (uniprop_get_decoder, uniprop_get_encoder):
389 Don't assume fixnum fits in int.
390 * cmds.c (move_point): New function, that does the gist of
391 Fforward_char and Fbackward_char, but does so while checking
392 for integer overflow more accurately.
393 (Fforward_char, Fbackward_char): Use it.
394 (Fforward_line, Fend_of_line, internal_self_insert)
395 (internal_self_insert):
396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
397 Fix a FIXME, by checking for integer overflow when calculating
398 target_clm and actual_clm.
399 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
400 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
401 (ASSURE_DESTINATION, coding_alloc_by_realloc)
402 (coding_alloc_by_making_gap, alloc_destination)
403 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
404 (encode_coding_utf_16, detect_coding_emacs_mule)
405 (decode_coding_emacs_mule, encode_coding_emacs_mule)
406 (detect_coding_iso_2022, decode_coding_iso_2022)
407 (encode_invocation_designation, encode_designation_at_bol)
408 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
409 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
410 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
411 (encode_coding_ccl, encode_coding_raw_text)
412 (detect_coding_charset, decode_coding_charset)
413 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
414 (produce_composition, produce_charset, produce_annotation)
415 (decode_coding, handle_composition_annotation)
416 (handle_charset_annotation, consume_chars, decode_coding_gap)
417 (decode_coding_object, encode_coding_object, detect_coding_system)
418 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
419 (code_convert_region, code_convert_string)
420 (Fdefine_coding_system_internal)
421 (coding_set_source, coding_set_destination):
422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
423 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
424 (Fdefine_coding_system_internal):
425 Don't assume fixnums fit in int.
426 (decode_coding_gap, decode_coding_object, encode_coding_object)
427 (Fread_coding_system, Fdetect_coding_region)
428 (Funencodable_char_position, Fcheck_coding_systems_region)
429 (get_translation, handle_composition_annotation, consume_chars):
430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
431 (consume_chars): Rewrite to not calculate an address outside buffer.
432 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
433 Don't access memory outside of the args array.
434 (Fdefine_coding_system_internal): Check for charset-id overflow.
435 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
436 result of ENCODE_CHAR.
437 * coding.h: Adjust decls to match defn changes elsewhere.
438 (struct coding_system):
439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
440 * composite.c (get_composition_id, find_composition)
441 (run_composition_function, update_compositions)
442 (compose_text, composition_gstring_put_cache)
443 (composition_gstring_p, composition_gstring_width)
444 (fill_gstring_header, fill_gstring_body, autocmp_chars)
445 (composition_compute_stop_pos, composition_reseat_it)
446 (composition_update_it, struct position_record)
447 (find_automatic_composition, composition_adjust_point)
448 (Fcomposition_get_gstring, Ffind_composition_internal):
449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
450 (update_compositions):
451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
452 * composite.h: Adjust decls to match defn changes elsewhere.
453 (struct composition):
454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
455 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
456 Do not attempt to compute the address of the object just before a
457 buffer; this is not portable.
459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
460 (Faset): Use int, not EMACS_INT, where int is wide enough.
461 (Fstring_to_number): Don't assume fixnums fit in int.
462 (Frem): Don't assume arg is nonnegative.
463 * dbusbind.c (xd_append_arg): Check for integers out of range.
464 (Fdbus_call_method): Don't overflow the timeout int.
465 (extract_signed, extract_unsigned): New functions.
466 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
467 (xd_get_connection_references): Return ptrdiff_t, not int.
469 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
471 Use int, not unsigned, where the dbus API uses int.
472 (Fdbus_message_internal): Don't overflow mtype.
473 (syms_of_dbusbind): Allocate right-sized buffer for integers.
474 * dired.c (directory_files_internal, file_name_completion, scmp)
475 (file_name_completion_stat):
476 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
477 (file_name_completion): Don't overflow matchcount.
478 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
479 * dispextern.h: Adjust decls to match defn changes elsewhere.
480 (struct text_pos, struct glyph, struct bidi_saved_info)
481 (struct bidi_string_data, struct bidi_it, struct composition_it)
483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
484 (struct display_pos, struct composition_it, struct it):
485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
486 * dispnew.c (increment_matrix_positions)
487 (increment_row_positions, mode_line_string)
488 (marginal_area_string):
489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
490 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
492 (duration_to_sec_usec): New function, to check for overflow better.
493 (Fsleep_for, sit_for): Use it.
494 * doc.c (get_doc_string, store_function_docstring):
495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
496 (get_doc_string, Fsnarf_documentation):
497 Use int, not EMACS_INT, where int is wide enough.
499 Use SAFE_ALLOCA, not alloca.
500 Check for overflow when converting EMACS_INT to off_t.
502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
503 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
504 Don't assume uid_t fits into fixnum.
505 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
506 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
507 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
508 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
509 (general_insert_function)
510 (Finsert_char, make_buffer_string, make_buffer_string_both)
511 (update_buffer_properties, Fbuffer_substring)
512 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
513 (Fsubst_char_in_region, check_translation)
514 (Ftranslate_region_internal, save_restriction_restore, Fformat)
515 (transpose_markers, Ftranspose_regions):
516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
517 (clip_to_bounds): Move to lisp.h as an inline function).
518 (Fconstrain_to_field): Don't assume integers are nonnegative.
519 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
520 (Fsubst_char_in_region, Fsave_restriction):
521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
522 (Femacs_pid): Don't assume pid_t fits into fixnum.
523 (lo_time): Use int, not EMACS_INT, when int suffices.
524 (lisp_time_argument): Check for usec out of range.
525 (Fencode_time): Don't assume fixnum fits in int.
526 (Fuser_login_name, Fuser_full_name): Signal an error
527 if a uid argument is out of range, rather than relying on
529 (Fformat_time_string): Remove now-unnecessary check.
530 lisp_time_argument checks for out-of-range usec now.
531 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
532 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
533 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
534 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
535 (init_cmdargs, Fdump_emacs):
536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
537 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
538 the bottom (typically) 32 bits of the fixnum.
539 * eval.c (specpdl_size, call_debugger):
540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
541 (when_entered_debugger, Fbacktrace_debug):
542 Don't assume fixnum can fit in int.
543 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
544 the object just before a buffer; this is not portable.
545 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
546 (grow_specpdl, unbind_to):
547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
548 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
549 (grow_specpdl): Simplify allocation by using xpalloc.
550 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
551 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
552 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
554 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
556 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
557 (Fcopy_file, non_regular_nbytes, read_non_regular)
558 (Finsert_file_contents):
559 Use int, not EMACS_INT, where int is wide enough.
560 (READ_BUF_SIZE): Verify that it fits in int.
561 (Finsert_file_contents): Check that counts are in proper range,
562 rather than assuming fixnums fit into ptrdiff_t etc.
563 Don't assume fixnums fit into int.
564 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
565 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
566 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
567 (string_char_to_byte, string_byte_to_char)
568 (string_make_multibyte, string_to_multibyte)
569 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
570 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
571 (substring_both, Fdelete, internal_equal, Ffillarray)
572 (Fclear_string, mapcar1)
573 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
574 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
575 (larger_vector, make_hash_table, maybe_resize_hash_table)
576 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
577 (Fmaphash, secure_hash):
578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
579 (concat): Check for string index and length overflow.
580 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
583 (larger_vector): New API (vec, incr_min, size_max) replaces old
584 one (vec, new_size, init). This catches size overflow.
585 INIT was removed because it was always Qnil.
587 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
588 the upper bound on a hash table index size.
589 (make_hash_table, maybe_resize_hash_table): Use it.
590 (secure_hash): Computer start_byte and end_byte only after
591 they're known to be in ptrdiff_t range.
592 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
593 (Ffont_get_glyphs, Ffont_at):
594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
595 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
596 (Flist_fonts, Fopen_font):
597 Don't assume fixnum can fit in int.
598 (check_gstring): Don't assume index can fit in int.
599 (font_match_p): Check that fixnum is a character, not a nonnegative
600 fixnum, since the later code needs to stuff it into an int.
601 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
602 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
603 conversion overflow issues.
604 (Fopen_font): Check for integer out of range.
605 (Ffont_get_glyphs): Don't assume index can fit in int.
606 * font.h: Adjust decls to match defn changes elsewhere.
607 * fontset.c (reorder_font_vector): Redo score calculation to avoid
609 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
610 printmax_t, where ptrdiff_t is wide enough.
611 (Finternal_char_font):
612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
613 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
614 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
615 (Fset_frame_position, x_set_frame_parameters)
616 (x_set_line_spacing, x_set_border_width)
617 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
618 Check that fixnums are in proper range for system types.
619 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
620 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
621 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
622 Use SAFE_ALLOCA_LISP, not alloca.
623 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
624 intptr_t is wide enough.
625 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
626 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
627 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
628 Check for fixnum out of range.
629 * ftfont.c (ftfont_list): Don't assume index fits in int.
630 Check that fixnums are in proper range for system types.
631 (ftfont_shape_by_flt):
632 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
633 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
635 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
636 Check that fixnums are in proper range for system types.
637 * gnutls.h: Adjust decls to match defn changes elsewhere.
638 * gtkutil.c (xg_dialog_run):
639 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
640 (update_frame_tool_bar):
641 Check that fixnums are in proper range for system types.
642 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
643 (lookup_image): Check that fixnums are in range for system types.
644 * indent.c (last_known_column, last_known_column_point):
645 (current_column_bol_cache):
646 (skip_invisible, current_column, check_display_width):
647 (check_display_width, scan_for_column, current_column_1)
648 (Findent_to, Fcurrent_indentation, position_indentation)
649 (indented_beyond_p, Fmove_to_column, compute_motion):
650 (Fcompute_motion, Fvertical_motion):
651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
652 (last_known_column_modified): Use EMACS_INT, not int.
653 (check_display_width):
655 Check that fixnums and floats are in proper range for system types.
656 (compute_motion): Don't assume index or fixnum fits in int.
657 (compute_motion, Fcompute_motion):
658 Use int, not EMACS_INT, when it is wide enough.
659 (vmotion): Omit local var start_hpos that is always 0; that way
660 we don't need to worry about overflow in expressions involving it.
661 * indent.h: Adjust decls to match defn changes elsewhere.
663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
664 Use int, not EMACS_INT, where int is wide enough.
665 Remove unused members ovstring_chars_done and tab_offset;
667 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
668 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
669 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
670 (make_gap, copy_text, insert, insert_and_inherit)
671 (insert_before_markers, insert_before_markers_and_inherit)
672 (insert_1, count_combining_before, count_combining_after)
673 (insert_1_both, insert_from_string)
674 (insert_from_string_before_markers, insert_from_string_1)
675 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
676 (adjust_after_replace, adjust_after_insert, replace_range)
677 (replace_range_2, del_range, del_range_1, del_range_byte)
678 (del_range_both, del_range_2, modify_region)
679 (prepare_to_modify_buffer, signal_before_change)
680 (signal_after_change, Fcombine_after_change_execute):
681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
682 * intervals.c (traverse_intervals, rotate_right, rotate_left)
683 (balance_an_interval, split_interval_right, split_interval_left)
684 (find_interval, next_interval, update_interval)
685 (adjust_intervals_for_insertion, delete_node, delete_interval)
686 (interval_deletion_adjustment, adjust_intervals_for_deletion)
687 (static_offset_intervals, offset_intervals)
688 (merge_interval_right, merge_interval_left, make_new_interval)
689 (graft_intervals_into_buffer, temp_set_point_both)
690 (temp_set_point, set_point, adjust_for_invis_intang)
691 (set_point_both, move_if_not_intangible, get_property_and_range)
692 (get_local_map, copy_intervals, copy_intervals_to_string)
693 (compare_string_intervals, set_intervals_multibyte_1):
694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
695 * intervals.h: Adjust decls to match defn changes elsewhere.
697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
698 * keyboard.c (this_command_key_count, this_single_command_key_start)
699 (before_command_key_count, before_command_echo_length, echo_now)
700 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
701 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
702 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
703 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
705 (last_non_minibuf_size, last_point_position, echo_truncate)
706 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
707 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
708 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
709 (stuff_buffered_input):
710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
711 (last_auto_save, command_loop_1, read_char):
712 Use EMACS_INT, not int, to avoid integer overflow.
713 (record_char): Avoid overflow in total_keys computation.
714 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
715 * keyboard.h: Adjust decls to match defn changes elsewhere.
716 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
717 (Fkey_description, Fdescribe_vector, Flookup_key):
718 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
719 (click_position): New function, to check that positions are in range.
720 (Fcurrent_active_maps):
722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
723 (Faccessible_keymaps, Fkey_description):
724 (preferred_sequence_p):
725 Don't assume fixnum can fit into int.
726 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
727 Check for integer overflow in size calculations.
728 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
729 avoid mishandling large integers.
730 * lisp.h: Adjust decls to match defn changes elsewhere.
731 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
732 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
733 (struct Lisp_Marker):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 (clip_to_bounds): Now an inline function, moved here from editfns.c.
736 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
737 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
739 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
740 Assume the arg has valid form, since it always does.
741 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
742 unsigned integer system type.
743 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
744 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
746 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
747 (duration_to_sec_usec): New decl.
748 * lread.c (read_from_string_index, read_from_string_index_byte)
749 (read_from_string_limit, readchar, unreadchar, openp)
750 (read_internal_start, read1, oblookup):
751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
752 (Fload, readevalloop, Feval_buffer, Feval_region):
753 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
754 (openp): Check for out-of-range argument to 'access'.
755 (read1): Use int, not EMACS_INT, where int is wide enough.
756 Don't assume fixnum fits into int.
757 Fix off-by-one error that can read outside a buffer.
758 (read_filtered_event): Use duration_to_sec_usec
759 to do proper overflow checking on durations.
760 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
762 (Fexecute_kbd_macro):
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
765 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
766 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
767 (set_marker_both, set_marker_restricted_both, marker_position)
768 (marker_byte_position, Fbuffer_has_markers_at):
769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
770 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
771 * menu.c (ensure_menu_items): Rename from grow_menu_items.
772 It now merely ensures that the menu is large enough, without
773 necessarily growing it, as this avoids some integer overflow issues.
775 (keymap_panes, parse_single_submenu, Fx_popup_menu):
776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
777 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
778 Use SAFE_ALLOCA_LISP, not alloca.
779 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
780 to EMACS_INT. Check that fixnums are in proper range for system types.
781 * minibuf.c (minibuf_prompt_width, string_to_object)
782 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
783 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
785 (get_minibuffer, read_minibuf_unwind):
786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
787 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
788 this simplifies overflow checking. All callers changed.
789 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
792 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
793 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
794 Check that fixnums are in proper range for system types.
795 (Fx_create_frame, Fx_show_tip):
796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
797 * nsfont.m (ns_findfonts, nsfont_list_family):
798 Don't assume fixnum fits in long.
799 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
801 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
803 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
805 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
806 (PRINTDECLARE, PRINTPREPARE):
807 (strout, print_string):
808 (print, print_preprocess, print_check_string_charset_prop)
810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
812 (temp_output_buffer_setup, Fprin1_to_string, print_object):
813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
814 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
815 (printchar, strout): Use xpalloc to catch size calculation overflow.
816 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
817 (print_error_message): Use SAFE_ALLOCA, not alloca.
818 (print_object): Use int, not EMACS_INT, where int is wide enough.
819 (print_depth, new_backquote_output, print_number_index):
820 Use ptrdiff_t, not int, where int might not be wide enough.
821 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
822 (Fset_process_window_size, Fformat_network_address)
823 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
825 Check that fixnums are in proper range for system types.
826 (Fsignal_process): Simplify by avoiding a goto.
827 Check for process-ids out of pid_t range rather than relying on
829 (process_tick, update_tick): Use EMACS_INT, not int.
830 (Fformat_network_address, read_process_output, send_process)
831 (Fprocess_send_region, status_notify):
832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
833 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
834 (wait_reading_process_output, read_process_output, exec_sentinel):
835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
836 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
837 (Faccept_process_output): Use duration_to_sec_usec to do proper
838 overflow checking on durations.
839 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
840 Don't assume pid_t fits in int.
841 * process.h (struct Lisp_Process): Members tick and update_tick
842 are now of type EMACS_INT, not int.
843 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
844 configured --with-wide-int.
845 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
846 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
847 * search.c (looking_at_1, string_match_1):
848 (fast_string_match, fast_c_string_match_ignore_case)
849 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
850 (scan_newline, find_before_next_newline, search_command)
851 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
852 (set_search_regs, wordify):
855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
856 (string_match_1, search_buffer, set_search_regs):
858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
859 (wordify): Check for overflow in size calculation.
860 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
861 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
862 Check that fixnums are in proper range for system types.
863 * sound.c (struct sound_device)
864 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
866 (Fplay_sound_internal):
867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
868 * syntax.c (struct lisp_parse_state, find_start_modiff)
869 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
870 (Fparse_partial_sexp):
871 Don't assume fixnums can fit in int.
872 (struct lisp_parse_state, find_start_pos, find_start_value)
873 (find_start_value_byte, find_start_begv)
874 (update_syntax_table, char_quoted, dec_bytepos)
875 (find_defun_start, prev_char_comend_first, back_comment):
876 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
877 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
878 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
879 (Finternal_describe_syntax_value): Check that match_lisp is a
880 character, not an integer, since the code stuffs it into int.
881 (scan_words, scan_sexps_forward):
882 Check that fixnums are in proper range for system types.
884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
885 (scan_sexps_forward):
886 Use CHARACTERP, not INTEGERP, since the value must fit into int.
887 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
888 * syntax.h: Adjust decls to match defn changes elsewhere.
890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
891 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
892 MOST_POSITIVE_FIXNUM.
893 * sysdep.c (wait_for_termination_1, wait_for_termination)
894 (interruptible_wait_for_termination, mkdir):
895 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
896 (emacs_read, emacs_write):
897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
898 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
899 and double all fit in int.
900 * term.c (set_tty_color_mode):
901 Check that fixnums are in proper range for system types.
902 * termhooks.h (struct input_event):
903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
904 * textprop.c (validate_interval_range, interval_of)
905 (Fadd_text_properties, set_text_properties_1)
906 (Fremove_text_properties, Fremove_list_of_text_properties)
907 (Ftext_property_any, Ftext_property_not_all)
908 (copy_text_properties, text_property_list, extend_property_ranges)
909 (verify_interval_modification):
910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
911 (Fnext_single_char_property_change)
912 (Fprevious_single_char_property_change):
913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
914 (copy_text_properties):
915 Check for integer overflow in index calculation.
916 * undo.c (last_boundary_position, record_point, record_insert)
917 (record_delete, record_marker_adjustment, record_change)
918 (record_property_change):
919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
920 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
922 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
923 (Fx_hide_tip, Fx_file_dialog):
924 * w32menu.c (set_frame_menubar):
925 Use ptrdiff_t, not int, for consistency with rest of code.
926 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
927 (select_window, Fdelete_other_windows_internal)
928 (window_scroll_pixel_based, window_scroll_line_based)
929 (Frecenter, Fset_window_configuration):
930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
931 (Fset_window_hscroll, run_window_configuration_change_hook)
932 (set_window_buffer, temp_output_buffer_show, scroll_command)
933 (Fscroll_other_window, Frecenter):
934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
935 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
936 Don't assume fixnum fits in int.
937 (Fset_window_scroll_bars):
938 Check that fixnums are in proper range for system types.
939 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
940 (string_pos, c_string_pos, number_of_chars, init_iterator)
941 (in_ellipses_for_invisible_text_p, init_from_display_pos)
942 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
943 (compute_display_string_end, handle_face_prop)
944 (face_before_or_after_it_pos, handle_invisible_prop)
945 (handle_display_prop, handle_display_spec, handle_single_display_spec)
946 (display_prop_intangible_p, string_buffer_position_lim)
947 (string_buffer_position, handle_composition_prop, load_overlay_strings)
948 (get_overlay_strings_1, get_overlay_strings)
949 (iterate_out_of_display_property, forward_to_next_line_start)
950 (back_to_previous_visible_line_start, reseat, reseat_to_string)
951 (get_next_display_element, set_iterator_to_next)
952 (get_visually_first_element, compute_stop_pos_backwards)
953 (handle_stop_backwards, next_element_from_buffer)
954 (move_it_in_display_line_to, move_it_in_display_line)
955 (move_it_to, move_it_vertically_backward, move_it_by_lines)
956 (add_to_log, message_dolog, message_log_check_duplicate)
957 (message2, message2_nolog, message3, message3_nolog
958 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
959 (current_message_1, truncate_echo_area, truncate_message_1)
960 (set_message, set_message_1, store_mode_line_noprop)
961 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
962 (text_outside_line_unchanged_p, check_point_in_composition)
963 (reconsider_clip_changes)
964 (redisplay_internal, set_cursor_from_row, try_scrolling)
965 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
966 (redisplay_window, find_last_unchanged_at_beg_row)
967 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
968 (trailing_whitespace_p, find_row_edges, display_line)
969 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
970 (display_mode_element, store_mode_line_string)
971 (pint2str, pint2hrstr, decode_mode_spec)
972 (display_count_lines, display_string, draw_glyphs)
973 (x_produce_glyphs, x_insert_glyphs)
974 (rows_from_pos_range, mouse_face_from_buffer_pos)
975 (fast_find_string_pos, mouse_face_from_string_pos)
976 (note_mode_line_or_margin_highlight, note_mouse_highlight):
977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
978 (safe_call, init_from_display_pos, handle_fontified_prop)
979 (handle_single_display_spec, load_overlay_strings)
980 (with_echo_area_buffer, setup_echo_area_for_printing)
981 (display_echo_area, echo_area_display)
982 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
983 (update_tool_bar, hscroll_window_tree, redisplay_internal)
984 (redisplay_window, dump_glyph_row, display_mode_line)
985 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
986 (handle_display_spec, display_prop_string_p):
987 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
988 (handle_single_display_spec, build_desired_tool_bar_string)
989 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
990 (get_specified_cursor_type):
991 Check that fixnums are in proper range for system types.
992 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
994 Don't assume fixnums fit in int.
995 (compare_overlay_entries):
996 Avoid mishandling comparisons due to subtraction overflow.
997 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
998 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
999 (handle_tool_bar_click):
1000 Use int, not unsigned, since we prefer signed and the signedness
1001 doesn't matter here.
1002 (get_next_display_element, next_element_from_display_vector):
1003 Use int, not EMACS_INT, when int is wide enough.
1004 (start_hourglass): Use duration_to_sec_usec to do proper
1005 overflow checking on durations.
1006 * xfaces.c (Fbitmap_spec_p):
1007 Check that fixnums are in proper range for system types.
1008 (compare_fonts_by_sort_order):
1009 Avoid mishandling comparisons due to subtraction overflow.
1010 (Fx_family_fonts, realize_basic_faces):
1011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1013 Don't assume fixnum fits in int.
1014 Use SAFE_ALLOCA_LISP, not alloca.
1015 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1016 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1017 (face_at_buffer_position, face_for_overlay_string)
1018 (face_at_string_position):
1019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1020 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1021 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1023 Check that fixnums are in proper range for system types.
1024 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1025 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1027 (Fx_change_window_property): Don't assume fixnums fit in int.
1028 * xfont.c (xfont_chars_supported):
1029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1030 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1031 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1032 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1033 * xml.c (parse_region):
1034 * xrdb.c (magic_file_p):
1035 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1036 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1037 (x_get_local_selection, x_reply_selection_request)
1038 (x_handle_selection_request, wait_for_property_change):
1039 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1040 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1041 short is wide enough.
1042 (x_send_client_event): Don't assume fixnum fits in int.
1043 * xterm.c (x_x_to_emacs_modifiers):
1044 Don't assume EMACS_INT overflows nicely into int.
1045 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1047 (handle_one_xevent): NATNUMP can eval its arg twice.
1048 (x_connection_closed):
1049 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1050 * xterm.h: Adjust decls to match defn changes elsewhere.
1051 (struct scroll_bar): Use struct vectorlike_header
1052 rather than rolling our own approximation.
1053 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1055 2012-05-25 Glenn Morris <rgm@gnu.org>
1057 * lisp.mk (lisp): Update for more files being compiled now.
1059 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1061 * lread.c: Remove `read_pure' which makes no difference.
1062 (read_pure): Remove var.
1063 (unreadpure): Remove function.
1064 (readevalloop): Don't call read_list with -1 flag.
1065 (read1, read_vector): Don't test read_pure any more.
1066 (read_list): Simplify.
1068 * fileio.c, character.h: Minor style tweaks.
1070 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1072 * window.h (clip_changed): Remove useless declaration.
1074 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1076 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1077 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1079 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1082 This directory predates autoconf and is no longer needed nowadays.
1083 Move its few remaining bits of functionality to where they're needed.
1084 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1085 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1086 * m/template.h: Remove.
1087 * Makefile.in (M_FILE): Remove. All uses removed.
1088 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1089 * lisp.h (USE_LSB_TAG):
1090 * mem-limits.h (EXCEEDS_LISP_PTR):
1091 Use VAL_MAX, not VALBITS, in #if.
1092 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1093 (EMACS_UINT): Define unconditionally now.
1094 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1095 (BITS_PER_EMACS_INT): New constants, replacing
1096 what used to be in config.h, but not useful in #if.
1097 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1098 define them any more.
1099 (VAL_MAX): New macro.
1101 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1102 BITS_PER_EMACS_INT, in #if.
1103 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1104 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1105 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1106 * s/ms-w32.h (DATA_START):
1107 Move here from removed file m/intel386.h.
1108 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1109 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1111 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1113 Assume C89 or later.
1114 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1115 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1117 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1118 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1119 * textprop.c, tparam.c (NULL): Remove.
1120 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1121 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1122 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1123 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1124 * xterm.c (input_signal_count): Assume volatile works.
1126 2012-05-21 Ken Brown <kbrown@cornell.edu>
1128 * xgselect.c (xg_select): Fix first argument in call to 'select'
1131 2012-05-20 Ken Brown <kbrown@cornell.edu>
1133 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1134 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1136 2012-05-19 Ken Brown <kbrown@cornell.edu>
1138 * xfns.c (x_in_use): Remove `static' qualifier.
1139 * xterm.h (x_in_use): Declare.
1140 * xgselect.c: Include xterm.h.
1141 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1142 and `display_arg' (bug#9754).
1144 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1146 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1148 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1149 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1151 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1153 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1155 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1156 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1158 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1159 reference to image_cache->refcount.
1160 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1162 2012-05-17 Juri Linkov <juri@jurta.org>
1164 * search.c (Fword_search_regexp, Fword_search_backward)
1165 (Fword_search_forward, Fword_search_backward_lax)
1166 (Fword_search_forward_lax): Move functions to isearch.el
1167 (bug#10145, bug#11381).
1169 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1171 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1173 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1175 * lread.c (init_obarray): Declare Qt and Qnil as special.
1177 2012-05-14 Glenn Morris <rgm@gnu.org>
1179 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1180 Put "libexec" before "bin", for the sake of init_callproc_1.
1182 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1184 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1186 * unexaix.c: Port to more-recent AIX compilers.
1187 (report_error, report_error_1, make_hdr, copy_sym)
1188 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1189 Make arguments const char *, not char *, to avoid violations of C
1190 standard and to fix some AIX warnings reported by Gilles Pion.
1192 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1194 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1195 already have overlays loaded.
1196 (handle_single_display_spec): Before returning without displaying
1197 fringe bitmap, synchronize the bidi iterator with the main display
1198 iterator, by calling iterate_out_of_display_property.
1199 (iterate_out_of_display_property): Detect buffer iteration by
1200 testing that it->string is a Lisp string.
1201 (get_next_display_element): When the current object is exhausted,
1202 and there's something on it->stack, call set_iterator_to_next to
1203 proceed with what's on the stack, instead of returning zero.
1204 (set_iterator_to_next): If called at the end of a Lisp string,
1205 proceed to consider_string_end without incrementing string
1206 position. Don't increment display vector index past the end of
1207 the display vector. (Bug#11417)
1208 (pos_visible_p): Don't report a position visible when move_it_to
1209 stopped at the last line of window, which happens to be scanned
1210 backwards by the bidi iteration. (Bug#11464)
1212 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1214 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1215 and right-margin display specs even if the spec is invalid or we
1216 are on a TTY, and thus unable to display on the fringes.
1217 That's because the text with the property will not be displayed anyway,
1218 so we need to signal to the caller that this is a "replacing"
1219 display spec. This fixes display when the spec is invalid or we
1222 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1224 * unexaix.c (make_hdr): Fix typo in prototype.
1225 This bug broke the build on AIX. Problem reported by Gilles Pion.
1227 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1229 * keyboard.c (kbd_buffer_get_event): Read special events also in
1230 batch mode. (Bug#11415)
1232 2012-05-12 Glenn Morris <rgm@gnu.org>
1234 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1236 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1238 * lisp.mk (lisp): Add newcomment.elc.
1240 2012-05-12 Glenn Morris <rgm@gnu.org>
1242 * Makefile.in (MKDIR_P): New, set by configure.
1243 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1245 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1247 Remove unused function hourglass_started.
1248 * dispextern.h (hourglass_started):
1249 * w32fns.c (hourglass_started):
1250 * xdisp.c (hourglass_started): Remove.
1252 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1254 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1255 Update dependencies.
1257 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1259 * xgselect.c (xg_select): Put maxfds+1 into a var.
1260 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1262 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1264 2012-05-10 Dave Abrahams <dave@boostpro.com>
1266 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1267 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1269 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1271 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1272 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1273 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1274 Initialize xd_registered_buses.
1276 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1278 Untag more efficiently if USE_LSB_TAG.
1279 This is based on a proposal by YAMAMOTO Mitsuharu in
1280 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1281 For an admittedly artificial (nth 8000 longlist) benchmark on
1282 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1283 Emacs's overall text size by 1%.
1284 * lisp.h (XUNTAG): New macro.
1285 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1286 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1287 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1288 * eval.c (Fautoload):
1289 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1290 * frame.h (XFRAME): Use XUNTAG.
1292 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1293 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1294 Remove unportable assumptions about print widths of types like
1296 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1297 intptr_t when converting between pointer and integer, to avoid GCC
1298 warnings about wrong width.
1300 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1302 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1303 stack for each reader_thread, instead of defaulting to 8MB
1304 determined by the linker. This avoids failures in creating
1305 subprocesses on Windows 7, see the discussion in this thread:
1306 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1308 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1310 Fix up display of the *Minibuf-0* buffer in the mini window.
1311 * keyboard.c (read_char): Don't clear the echo area if there's no
1313 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1314 contents of *Minibuf-0*) if there's no message displayed in its stead.
1316 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1318 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1321 2012-05-06 Chong Yidong <cyd@gnu.org>
1323 * lisp.mk (lisp): Update.
1325 2012-05-05 Jim Meyering <meyering@redhat.com>
1327 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1329 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1331 * data.c (PUT_ERROR): New macro.
1332 (syms_of_data): Use it. Add new error type `user-error'.
1333 * undo.c (user_error): New function.
1334 (Fprimitive_undo): Use it.
1335 * print.c (print_error_message): Adjust print style for `user-error'.
1336 * keyboard.c (user_error): New function.
1337 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1339 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1341 Do not limit current-time-string to years 1000..9999.
1342 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1343 (Fcurrent_time_string): Support any year that is supported by the
1344 underlying localtime representation. Don't use asctime, as it
1345 has undefined behavior for years outside the range -999..9999.
1347 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1349 Fix race conditions involving setenv, gmtime, localtime, asctime.
1350 Without this fix, interrupts could mess up code that uses these
1351 nonreentrant functions, since setting TZ invalidates existing
1352 tm_zone or tzname values, and since most of these functions return
1353 pointers to static storage.
1354 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1355 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1356 Grow the critical sections to include not just invoking
1357 localtime/gmtime, but also accessing these functions' results
1358 including their tm_zone values if any, and any related TZ setting.
1359 (format_time_string): Last arg is now struct tm *, not struct tm **,
1360 so that the struct tm is saved in the critical section.
1361 All callers changed. Simplify allocation of initial buffer, partly
1362 motivated by the fact that memory allocation needs to be outside
1363 the critical section.
1365 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1367 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1368 with RESET_INTERVAL.
1370 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1371 Remove duplicated buffer name initialization.
1373 2012-05-02 Jim Meyering <jim@meyering.net>
1375 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1377 * xfns.c (x_window): Use xstrdup (Bug#11375).
1379 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1381 * xdisp.c (pos_visible_p): If already at a newline from the
1382 display string before the 'while' loop, don't walk back the glyphs
1383 from it3.glyph_row. Solves assertion violation when the display
1384 string begins with a newline (egg.el). (Bug#11367)
1386 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1388 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1391 2012-05-01 Glenn Morris <rgm@gnu.org>
1393 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1394 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1395 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1396 All were removed before 23.1.
1398 * dispnew.c: Remove HAVE_LIBNCURSES test;
1399 it is always true on relevant platforms.
1401 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1402 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1404 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1406 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1408 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1409 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1412 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1414 Do not avoid creating empty evaporating overlays (Bug#9642).
1415 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1416 That is, do not delete an evaporating overlay if it becomes
1417 empty after its bounds are adjusted to fit within its buffer.
1418 This fix caused other problems, and I'm reverting it until we get
1419 to the bottom of them.
1421 2012-04-27 Chong Yidong <cyd@gnu.org>
1423 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1425 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1427 * xdisp.c (pos_visible_p): If the window start position is beyond
1428 ZV, start the display from buffer beginning. Prevents assertion
1429 violation in init_iterator when the minibuffer window is scrolled
1432 * window.c (window_scroll_pixel_based): Likewise.
1434 2012-04-27 Chong Yidong <cyd@gnu.org>
1436 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1438 2012-04-27 Glenn Morris <rgm@gnu.org>
1440 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1441 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1443 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1445 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1446 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1448 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1450 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1451 display element, check also the underlying string or buffer
1452 character. (Bug#11341)
1454 * w32menu.c: Include w32heap.h.
1455 (add_menu_item): If the call to AppendMenuW (via
1456 unicode_append_menu) fails, disable Unicode menus only if we are
1457 running on Windows 9X/Me.
1459 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1461 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1462 (xgetint): Add missing shift for LSB tags.
1464 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1466 * keyboard.c (read_char): Don't wipe echo area for select window
1467 events: These might get delayed via `mouse-autoselect-window'
1470 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1472 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1473 manipulation of :loaded-from data.
1475 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1477 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1478 now a cons (bug#11311).
1480 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1482 Do not create empty overlays with the evaporate property (Bug#9642).
1483 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1484 if it becomes empty after its bounds are adjusted to fit within
1485 its buffer. Without this fix, in a nonempty buffer (let ((o
1486 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1487 yields an empty overlay that has the evaporate property, which is
1488 not supposed to happen.
1490 Fix minor GTK3 problems found by static checking.
1491 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1492 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1493 (struct _EmacsFixedClass, emacs_fixed_get_type):
1494 Move decls here from emacsgtkfixed.h, since they needn't be public.
1495 (emacs_fixed_get_type): Now static.
1496 (emacs_fixed_class_init): Omit unused local.
1497 (emacs_fixed_child_type): Remove; unused.
1498 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1499 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1500 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1501 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1502 (EMACS_FIXED_GET_CLASS): Remove; unused.
1503 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1505 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1506 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1508 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1510 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1511 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1512 (__malloc_size_t, __malloc_ptrdiff_t):
1513 Remove. All uses removed, replaced by the definiens if needed,
1514 since we can assume C89 or better now.
1515 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1516 (protect_malloc_state, align, get_contiguous_space)
1517 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1518 (malloc_atfork_handler_child, malloc_enable_thread)
1519 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1520 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1521 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1522 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1523 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1524 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1525 Define using prototypes, not old style.
1526 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1527 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1528 (align): Don't assume that signed integer overflow wraps around.
1529 Omit unused local var.
1530 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1531 (_free_internal_nolock, memalign, mallochook, reallochook):
1532 Omit no-longer-needed casts.
1533 (valloc): Use getpagesize, not __getpagesize.
1534 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1535 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1537 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1539 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1541 Move functions from C to Lisp. Make non-blocking method calls
1542 the default. Implement further D-Bus standard interfaces.
1544 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1545 (QCdbus_request_name_allow_replacement)
1546 (QCdbus_request_name_replace_existing)
1547 (QCdbus_request_name_do_not_queue)
1548 (QCdbus_request_name_reply_primary_owner)
1549 (QCdbus_request_name_reply_in_queue)
1550 (QCdbus_request_name_reply_exists)
1551 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1552 (QCdbus_registered_serial, QCdbus_registered_method)
1553 (QCdbus_registered_signal): New Lisp objects.
1554 (XD_DEBUG_MESSAGE): Use sizeof.
1555 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1556 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1557 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1558 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1559 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1560 (xd_signature, xd_append_arg): Allow float for integer types.
1561 (xd_get_connection_references): New function.
1562 (xd_get_connection_address): Rename from xd_initialize.
1563 Return cached address.
1564 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1565 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1567 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1568 Return number of refcounts.
1569 (Fdbus_get_unique_name): Make stronger parameter check.
1570 (Fdbus_message_internal): New defun.
1571 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1572 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1573 (Fdbus_send_signal, Fdbus_register_service)
1574 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1575 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1576 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1577 (Vdbus_compiled_version, Vdbus_runtime_version)
1578 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1579 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1580 (Vdbus_message_type_signal): New defvars.
1581 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1584 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1586 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1587 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1588 Do not assume ptrdiff_t is the same width as 'int'.
1590 * alloc.c: Handle unusual debugging option combinations.
1591 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1592 since the two debugging options are incompatible.
1593 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1595 (mem_init, mem_insert, mem_insert_fixup):
1596 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1597 (NEED_MEM_INSERT): Remove; no longer needed.
1599 2012-04-22 Leo Liu <sdl.web@gmail.com>
1601 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1603 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1605 * sysdep.c [__FreeBSD__]: Minor cleanups.
1606 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1607 Use Emacs indenting style more consistently. Avoid some casts.
1608 Use 'double' consistently rather than mixing 'float' and 'double'.
1610 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1612 * sysdep.c (list_system_processes, system_process_attributes):
1613 Add implementation for FreeBSD (Bug#5243).
1615 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1617 * lisp.mk (lisp): Update.
1619 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1621 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1622 It is never used otherwise.
1624 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1626 * print.c (print_preprocess): Only check print_depth if print-circle
1628 (print_object): Check for cycles even when print-circle is nil and
1629 print-gensym is t, but only check print_depth if print-circle is nil.
1631 2012-04-20 Chong Yidong <cyd@gnu.org>
1633 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1634 set the status to "failed" and ensure that sentinel is run.
1636 2012-04-20 Glenn Morris <rgm@gnu.org>
1638 * process.c (Fset_process_inherit_coding_system_flag)
1639 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1640 (Fmake_network_process, Fmake_serial_process): Doc fix.
1642 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1644 * xdisp.c (string_buffer_position_lim): Limit starting position to
1646 (set_cursor_from_row): If called for a mode-line or header-line
1647 row, return zero immediately.
1648 (try_cursor_movement): If inside continuation line, don't back up
1649 farther than the first row after the header line, if any.
1650 Don't consider the header-line row as "partially visible", even if
1651 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1653 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1655 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1658 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1659 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1661 configure: new option --enable-gcc-warnings (Bug#11207)
1662 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1663 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1664 (ALL_CFLAGS): Use new macros rather than old.
1665 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1666 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1667 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1668 -Wunused-result, -Wunused-variable. This should go away once
1669 the Emacs and Gnulib regex code is merged.
1670 (xmalloc, xrealloc): Now static.
1672 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1674 * dired.c (Fsystem_groups): Remove unused local.
1676 2012-04-17 Glenn Morris <rgm@gnu.org>
1678 * dired.c (Fsystem_users): Doc fix.
1680 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1682 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1683 (syms_of_dired): Add them.
1685 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1687 Fix minor alloc.c problems found by static checking.
1688 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1689 New extern decls, to avoid calling undeclared functions.
1690 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1691 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1692 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1693 (NEED_MEM_INSERT): New macro.
1694 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1695 Remove one incorrect comment and fix another.
1697 Fix minor ralloc.c problems found by static checking.
1698 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1699 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1700 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1701 (r_alloc_sbrk): Now static.
1703 Improve ralloc.c interface checking.
1704 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1705 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1706 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1707 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1708 [REL_ALLOC]: ... to here, to check interface.
1709 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1710 Remove decls. This fixes an "It stinks!".
1712 * alloc.c (which_symbols): Fix alignment issue / type clash.
1714 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1716 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1717 (struct Lisp_Misc_Any): Likewise.
1718 (struct Lisp_Free): Likewise.
1719 * alloc.c (union aligned_Lisp_Symbol): Define.
1720 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1721 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1722 (union aligned_Lisp_Misc): Define.
1723 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1724 aligned_Lisp_Misc instead of union Lisp_Misc.
1725 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1727 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1729 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1730 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1731 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1732 * s/netbsd.h, s/sol2-6.h:
1733 Remove definition of GC_MARK_STACK, since the default now works.
1734 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1735 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1736 no longer the default.
1737 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1739 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1741 * lread.c (lisp_file_lexically_bound_p):
1742 Fix hang at ";-*-\n" (bug#11238).
1744 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1746 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1747 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1749 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1751 * nsterm.m (constrainFrameRect): Always constrain when there is only
1752 one screen (Bug#10962).
1754 2012-04-13 Ken Brown <kbrown@cornell.edu>
1756 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1758 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1760 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1762 2012-04-11 Daniel Colascione <dancol@dancol.org>
1764 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1765 against is gone. It's better to use vfork now so that when Cygwin
1766 gains a new, working vfork, we use it automatically (bug#10398).
1768 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1770 * window.c (save_window_save): Obey window-point-insertion-type.
1772 2012-04-11 Glenn Morris <rgm@gnu.org>
1774 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1776 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1778 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1780 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1782 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1783 (force_quit_count): New var.
1784 (handle_interrupt): Use it.
1786 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1788 * w32.c (w32_delayed_load): Record the full path of the library
1789 being loaded (bug#10424).
1791 2012-04-09 Glenn Morris <rgm@gnu.org>
1793 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1794 not just in the obarray, before snarfing them. (Bug#11036)
1796 * Makefile.in ($(leimdir)/leim-list.el):
1797 Pass EMACS rather than BUILT_EMACS.
1799 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1801 * process.c (make_process):
1802 * process.h: Add integer `gnutls_handshakes_tried' member to
1805 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1806 Add convenience `GNUTLS_LOG2i' macro.
1808 * gnutls.c (gnutls_log_function2i): Convenience log function.
1809 (emacs_gnutls_read): Use new log functions,
1810 `gnutls_handshakes_tried' process member, and
1811 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1812 attempts per process (connection).
1814 2012-04-09 Chong Yidong <cyd@gnu.org>
1816 * eval.c (Fuser_variable_p, user_variable_p_eh)
1817 (lisp_indirect_variable): Functions deleted.
1818 (Fdefvar): Caller changed.
1820 * callint.c (Finteractive, Fcall_interactively):
1821 * minibuf.c (Fread_variable): Callers changed.
1823 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1825 * xdisp.c (set_cursor_from_row): If the display string appears in
1826 the buffer at position that is closer to point than the position
1827 after the display string, display the cursor on the first glyph of
1828 the display string. Fixes cursor display when a 'display' text
1829 property immediately follows invisible text. (Bug#11094)
1831 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1833 composite.c: use 'double' consistently
1834 * composite.c (get_composition_id): Use 'double' consistently
1835 instead of converting 'float' to 'double' and vice versa; this is
1836 easier to understand and avoids a GCC warning.
1838 2012-04-09 Glenn Morris <rgm@gnu.org>
1840 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1841 preparation for dumping it with emacs. (Bug#4789)
1842 (leimdir): New variable.
1843 ($(leimdir)/leim-list.el): New rule.
1844 (emacs$(EXEEXT)): Depend on leim-list.el.
1846 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1847 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1848 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1850 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1852 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1855 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1857 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1858 Remove unused local variable.
1860 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1862 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1863 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1864 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1865 objects, as mark_maybe_pointer will catch them otherwise.
1866 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1867 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1869 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1871 Fix typo that broke non-Windows builds.
1872 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1874 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1876 Support building on MS-Windows with libxml2.
1878 * makefile.w32-in (OBJ2): Add xml.$(O).
1879 (GLOBAL_SOURCES): Add xml.c.
1880 ($(BLD)/xml.$(O)): New dependency list.
1882 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1883 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1884 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1885 [!WINDOWSNT]: New macros.
1886 (init_libxml2_functions, libxml2_loaded_p): New functions.
1887 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1888 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1889 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1890 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1892 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1893 Call init_libxml2_functions before calling libxml2 functions.
1894 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1896 * emacs.c: Don't include libxml/parser.h.
1897 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1898 xmlCleanupParser directly.
1900 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1902 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1904 * indent.c (Fvertical_motion): If there is a display string at
1905 point, use it.vpos to compute how many lines to backtrack after
1906 move_it_to point. (Bug#11133)
1908 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1910 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1911 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1912 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1913 macros related to unification of CJK characters. For the details,
1914 see the discussion following the message here:
1915 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1917 2012-04-04 Chong Yidong <cyd@gnu.org>
1919 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1921 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1923 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1924 instead of alloca. (Bug#11138)
1926 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1928 * w32menu.c (is_simple_dialog): Properly check lisp types.
1931 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1933 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1934 position we get to after a call to move_it_to fails the
1935 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1936 only if we wind up in a string from display property. (Bug#11063)
1938 * window.c (Fdelete_other_windows_internal): Invalidate the row
1939 and column information about mouse highlight, so that redisplay
1940 restores it after reallocating the glyph matrices. (Bug#7464)
1942 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1943 string comes from a `display' text property, use the buffer
1944 position of that property as if we actually saw that position in
1946 (move_it_by_lines): Remove the assertion that
1947 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1948 violated when there's a before-string at the beginning of a line.
1951 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1953 * xdisp.c (append_space_for_newline): If the default face was
1954 remapped, use the remapped face for the appended newline.
1955 (extend_face_to_end_of_line): Use the remapped default face for
1956 extending the face to the end of the line.
1957 (display_line): Call extend_face_to_end_of_line when the default
1958 face was remapped. (Bug#11068)
1960 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1962 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1964 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1966 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1968 2012-03-27 Glenn Morris <rgm@gnu.org>
1970 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1973 2012-03-26 Kenichi Handa <handa@m17n.org>
1975 * dispextern.h (struct glyph): Fix previous change. Change the
1976 bit length of glyphless.ch to 25 (Bug#11082).
1978 2012-03-26 Chong Yidong <cyd@gnu.org>
1980 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1981 (command_loop_1): Use it; inhibit selection update for
1982 handle-select-window too (Bug#8996).
1984 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1986 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1988 2012-03-25 Kenichi Handa <handa@m17n.org>
1990 * dispextern.h (struct glyph): Change the bit length of
1991 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1993 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1995 * s/ms-w32.h (tzname): Include time.h before redirecting to
1996 _tzname. Fixes the MSVC build. (Bug#9960)
1998 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2000 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2003 * xterm.c (XTread_socket): Only modify handling_signal if
2004 !SYNC_INPUT. (Bug#11080)
2006 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2008 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2009 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2010 when fetching a multibyte character consumes more bytes than
2011 CHAR_BYTES returns, due to unification of CJK characters in
2012 string_char. (Bug#11073)
2014 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2016 * process.c (wait_reading_process_output): Handle pty disconnect
2017 by refraining from sending oneself a SIGCHLD (bug#10933).
2019 2012-03-22 Chong Yidong <cyd@gnu.org>
2021 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2023 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2024 Mark string as coming from a prefix property.
2025 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2026 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2028 2012-03-21 Chong Yidong <cyd@gnu.org>
2030 * xfaces.c (Vface_remapping_alist): Doc fix.
2032 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2034 * w32proc.c (Fw32_set_console_codepage)
2035 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2038 2012-03-20 Chong Yidong <cyd@gnu.org>
2040 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2041 to reflect default non-nil value of redisplay-dont-pause.
2043 2012-03-19 Kenichi Handa <handa@m17n.org>
2045 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2046 it fit in a valid range (Bug#11003).
2048 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2050 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2051 that is not from display property, accept the row as a "cursor
2052 row" if one of the string's character has a non-nil `cursor'
2053 property. Fixes cursor positioning when there are newlines in
2054 overlay strings, e.g. in icomplete.el. (Bug#11035)
2056 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2058 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2060 2012-03-12 Chong Yidong <cyd@gnu.org>
2062 * eval.c (inhibit_lisp_code): Rename from
2063 inhibit_window_configuration_change_hook; move from window.c.
2065 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2066 * window.c (run_window_configuration_change_hook)
2067 (syms_of_window): Callers changed.
2069 2012-03-11 Chong Yidong <cyd@gnu.org>
2071 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2073 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2075 2012-03-10 Chong Yidong <cyd@gnu.org>
2077 * frame.c (other_visible_frames): Don't assume the selected frame
2078 is visible (Bug#10955).
2080 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2082 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2084 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2086 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2087 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2090 2012-03-03 Glenn Morris <rgm@gnu.org>
2092 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2094 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2096 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2097 position past the first glyph_row that ends at ZV. (Bug#10902)
2098 (redisplay_window, next_element_from_string): Fix typos in
2100 (redisplay_window): Pass to move_it_vertically the margin in
2101 pixels, not in screen lines.
2103 2012-03-02 Glenn Morris <rgm@gnu.org>
2105 * buffer.c (buffer-list-update-hook): Doc fix.
2107 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2109 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2110 push_it before setting up the iterator for the first overlay
2111 string, even if we have an empty string loaded.
2112 (next_overlay_string): If there's an empty string on the iterator
2113 stack, pop the stack. (Bug#10903)
2115 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2117 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2118 Suggested by Stefan Monnier in
2119 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2120 * alloc.c (widen_to_Lisp_Object): New static function.
2121 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2122 and widening them to Lisp_Objects. This would work even if
2123 USE_LSB_TAG is defined and wide integers are used, which might
2124 happen in a future version of Emacs.
2126 2012-02-25 Chong Yidong <cyd@gnu.org>
2128 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2131 * xselect.c (Fx_selection_exists_p): Doc fix.
2132 (x_clipboard_manager_save_all): Print an informative message
2133 before saving to clipboard manager.
2135 2012-02-24 Chong Yidong <cyd@gnu.org>
2137 * keyboard.c (process_special_events): Handle all X selection
2138 requests in kbd_buffer, not just the next one (Bug#8869).
2140 2012-02-23 Chong Yidong <cyd@gnu.org>
2142 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2143 call when setting menu-bar-lines and tool-bar-lines parameters.
2144 (unwind_create_frame_1): New helper function.
2146 * window.c (inhibit_window_configuration_change_hook): New var.
2147 (run_window_configuration_change_hook): Obey it.
2148 (syms_of_window): Initialize it.
2150 2012-02-22 Chong Yidong <cyd@gnu.org>
2152 * xterm.c (x_draw_image_relief): Add missing type check for
2153 Vtool_bar_button_margin (Bug#10743).
2155 2012-02-21 Chong Yidong <cyd@gnu.org>
2157 * fileio.c (Vfile_name_handler_alist): Doc fix.
2159 * buffer.c (Fget_file_buffer): Protect against invalid file
2160 handler return value.
2162 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2164 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2165 when computing $valmask.
2167 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2168 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2169 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2170 It's useless in that case, and it can cause problems on hosts
2171 that allocate halves of EMACS_INT values separately.
2172 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2173 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2174 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2175 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2176 it avoids undefined behavior on hosts where shifting right by more
2177 than the word width has undefined behavior.
2179 2012-02-19 Chong Yidong <cyd@gnu.org>
2181 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2182 (Funhandled_file_name_directory, Ffile_name_as_directory)
2183 (Fdirectory_file_name, Fexpand_file_name)
2184 (Fsubstitute_in_file_name): Protect against invalid file handler
2185 return values (Bug#10845).
2187 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2189 * .gdbinit (pitx): Fix incorrect references to fields of the
2192 2012-02-17 Chong Yidong <cyd@gnu.org>
2194 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2196 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2198 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2199 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2201 2012-02-15 Chong Yidong <cyd@gnu.org>
2203 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2204 marked as special. Also, starting docstrings with * is obsolete.
2206 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2208 * gnutls.c (emacs_gnutls_write): Fix last change.
2210 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2212 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2215 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2217 * keymap.c (Fsingle_key_description): Handle char ranges.
2219 2012-02-12 Chong Yidong <cyd@gnu.org>
2221 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2222 as that creates a dangerous corner case.
2224 * window.c (Fdelete_window_internal): Invalidate the mouse
2225 highlight (Bug#9904).
2227 2012-02-12 Glenn Morris <rgm@gnu.org>
2229 * xselect.c (Fx_own_selection_internal)
2230 (Fx_get_selection_internal, Fx_disown_selection_internal)
2231 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2232 * nsselect.m (Fx_own_selection_internal)
2233 (Fx_disown_selection_internal, Fx_selection_exists_p)
2234 (Fx_selection_owner_p, Fx_get_selection_internal):
2235 Sync docs and argument specs with the xselect.c versions.
2237 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2239 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2241 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2243 * w32select.c (Fx_selection_exists_p): Sync doc string and
2244 argument list with xselect.c. (Bug#10783)
2246 * w16select.c (Fx_selection_exists_p): Sync doc string and
2247 argument list with xselect.c. (Bug#10783)
2249 2012-02-10 Glenn Morris <rgm@gnu.org>
2251 * fns.c (Fsecure_hash): Doc fix.
2253 2012-02-09 Kenichi Handa <handa@m17n.org>
2255 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2257 2012-02-07 Chong Yidong <cyd@gnu.org>
2259 * buffer.c (Fbuffer_local_variables)
2260 (buffer_lisp_local_variables): Handle unbound vars correctly;
2261 don't let Qunbound leak into Lisp.
2263 2012-02-07 Glenn Morris <rgm@gnu.org>
2265 * image.c (Fimagemagick_types): Doc fix.
2267 * image.c (imagemagick-render-type): Change it from a lisp object
2268 to an integer. Move the doc here from the lisp manual.
2269 Treat all values not equal to 0 the same.
2271 2012-02-06 Chong Yidong <cyd@gnu.org>
2273 * doc.c (store_function_docstring): Avoid applying docstring of
2274 alias to base function (Bug#2603).
2276 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2278 * .gdbinit (pp1, pv1): Remove redundant defines.
2281 2012-02-04 Chong Yidong <cyd@gnu.org>
2283 * nsterm.m: Declare a global (Bug#10694).
2285 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2287 * w32.c (get_emacs_configuration_options):
2288 Include --enable-checking, if specified, in the return value.
2290 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2292 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2293 after rounding frame sizes. (Bug#9723)
2295 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2297 * keyboard.c (adjust_point_for_property): Don't position point
2298 before BEGV. (Bug#10696)
2300 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2302 Handle overflow when computing char display width (Bug#9496).
2303 * character.c (char_width): Return EMACS_INT, not int.
2304 (char_width, c_string_width): Check for overflow when
2305 computing the width; this is possible now that individual
2306 characters can have unbounded width. Problem introduced
2307 by merge from Emacs 23 on 2012-01-19.
2309 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2311 * dbusbind.c (Fdbus_register_method): Mention the return value
2312 :ignore in the docstring.
2314 2012-02-02 Glenn Morris <rgm@gnu.org>
2316 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2318 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2319 Unconditionally set to t. (Bug#10673)
2320 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2321 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2322 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2324 2012-02-02 Kenichi Handa <handa@m17n.org>
2326 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2327 0, do not call append_composite_glyph.
2329 2012-02-02 Kenichi Handa <handa@m17n.org>
2331 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2333 (x_produce_glyphs): If the component of a composition is a null
2334 string, set it->pixel_width to 1 to avoid zero-width glyph.
2336 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2338 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2339 first 2 arguments are identical. This makes inserting large
2340 output from a subprocess an order of magnitude faster on
2341 MS-Windows, where all sbrk'ed memory is always contiguous.
2343 2012-01-31 Glenn Morris <rgm@gnu.org>
2345 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2346 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2347 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2349 2012-01-29 Glenn Morris <rgm@gnu.org>
2351 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2353 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2355 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2357 2012-01-28 Chong Yidong <cyd@gnu.org>
2359 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2361 2012-01-26 Chong Yidong <cyd@gnu.org>
2363 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2365 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2366 repeat counts (Bug#10507).
2368 2012-01-26 Glenn Morris <rgm@gnu.org>
2370 * lread.c (syms_of_lread): Doc fix.
2372 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2374 * coding.c (encode_designation_at_bol): Change return value to
2377 2012-01-25 Chong Yidong <cyd@gnu.org>
2379 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2381 2012-01-21 Chong Yidong <cyd@gnu.org>
2383 * floatfns.c (Fcopysign): Make the second argument non-optional,
2384 since nil is not allowed anyway.
2386 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2388 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2389 (send_process): Likewise.
2391 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2393 * window.c (save_window_save, Fcurrent_window_configuration)
2394 (Vwindow_persistent_parameters): Do not use Qstate.
2395 Rewrite doc-strings.
2397 2012-01-19 Kenichi Handa <handa@m17n.org>
2399 * character.c (char_width): New function.
2400 (Fchar_width, c_string_width, lisp_string_width):
2401 Use char_width (Bug#9496).
2403 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2405 * window.c (Vwindow_persistent_parameters): New variable.
2406 (Fset_window_configuration, save_window_save): Handle persistent
2409 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2411 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2412 thrashing the stack of the thread. (Bug#9087)
2414 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2416 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2418 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2420 * xdisp.c (rows_from_pos_range): Handle the case where the
2421 highlight ends on a newline. (Bug#10464)
2422 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2423 he end column for display of highlight that ends on a newline
2426 2012-01-11 Glenn Morris <rgm@gnu.org>
2428 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2429 from load-path also when installation-directory is nil. (Bug#10208)
2431 2012-01-10 Glenn Morris <rgm@gnu.org>
2433 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2435 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2436 Update template values to be closer to their typical values these days.
2438 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2440 * xdisp.c (rows_from_pos_range): Accept additional argument
2441 DISP_STRING, and accept any glyph in a row whose object is that
2442 string as eligible for mouse highlight. Fixes mouse highlight of
2443 display strings from overlays. (Bug#10464)
2445 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2447 emacs: fix an auto-save permissions race condition (Bug#10400)
2448 * fileio.c (auto_saving_dir_umask): New static var.
2449 (Fmake_directory_internal): Use it.
2450 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2451 creating the directory. The old code temporarily assigns
2452 too-generous permissions to the directory.
2453 (do_auto_save_eh): Clear it.
2454 (Fdo_auto_save): Catch all errors, not just file errors, so
2455 that the var is always cleared.
2457 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2459 * search.c (scan_buffer): Pass character positions to
2460 know_region_cache, not byte positions. (Bug#6540)
2462 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2464 * w32.c (sys_rename): Report EXDEV when rename of a directory
2465 fails because the target is on another logical disk. (Bug#10284)
2467 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2469 * xterm.c (x_embed_request_focus): New function.
2471 * xterm.h: Add prototype.
2473 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2475 2012-01-05 Glenn Morris <rgm@gnu.org>
2477 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2479 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2481 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2482 Load gnutls_transport_set_lowat only if GnuTLS version is below
2484 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2485 GnuTLS versions below 2.11.1.
2487 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2489 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2490 to the doc string advising against its use for altering the way
2491 windows are scrolled.
2493 2011-12-28 Kenichi Handa <handa@m17n.org>
2495 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2496 coding-system ASCII compatible only when it does not produce BOM
2497 on encoding (Bug#10383).
2499 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2501 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2503 (create_and_show_popup_menu): Always use menu_position_func for
2506 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2508 * callint.c (Fcall_interactively): Don't truncate prompt string.
2510 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2512 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2513 property that ends at ZV, so that the bidi iteration could be
2514 resumed from there (after widening). (Bug#10360)
2516 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2518 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2520 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2522 * nsterm.m (x_free_frame_resources):
2523 Release f->output_data.ns->miniimage.
2524 (ns_index_color): Fix indentation. Do not retain
2525 color_table->colors[i].
2527 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2530 * nsfns.m (x_set_background_color): Assign return value from
2531 ns_index_color to face-background instead of NSColor*.
2532 (ns_implicitly_set_icon_type): Fix indentation.
2533 Change assignment in for loop to comparison.
2535 * emacs.c (ns_pool): New variable.
2536 (main): Assign ns_pool.
2537 (Fkill_emacs): Call ns_release_autorelease_pool.
2539 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2540 autorelease fdesc, release fdAttrs and tdict.
2541 (ns_get_covering_families): Release charset.
2542 (ns_findfonts): Release NSFontDescriptor created with new.
2543 (ns_uni_to_glyphs): Fix indentation.
2544 (setString): Release attrStr before assigning new value.
2546 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2548 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2550 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2551 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2553 2011-12-18 David Reitter <reitter@cmu.edu>
2555 * nsterm.m (ns_term_init): Subscribe for notifications
2556 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2557 to method trackingNotification in EmacsMenu.
2559 * nsmenu.m (trackingMenu): New variable.
2560 (trackingNotification): New method (from Aquamacs).
2561 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2562 from Aquamacs (Bug#7030).
2564 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2566 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2567 (symbol_to_nsstring): Fix indentation.
2568 (ns_symbol_to_pb): New function.
2569 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2570 (Fns_rotate_cut_buffers_internal): Remove.
2571 (Fns_store_selection_internal): Rename from
2572 Fns_store_cut_buffer_internal.
2573 (ns_get_foreign_selection, Fx_own_selection_internal)
2574 (Fx_disown_selection_internal, Fx_selection_exists_p)
2575 (Fns_get_selection_internal, Fns_store_selection_internal):
2576 Use ns_symbol_to_pb and check if return value is nil.
2577 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2578 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2579 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2580 renamed to Sns_store_selection_internal.
2581 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2582 and remove this function.
2583 (ns_handle_selection_clear): Remove, never used.
2584 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2587 2011-12-17 Ken Brown <kbrown@cornell.edu>
2589 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2590 GID is unknown (Bug#10257).
2592 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2594 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2595 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2596 which caused a build failure on GNU/Linux IA-64. This problem was
2597 introduced by my 2011-10-07 patch.
2599 2011-12-15 Juri Linkov <juri@jurta.org>
2601 * image.c (imagemagick_error): New function. (Bug#10112)
2602 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2603 Use `imagemagick_error' where ImageMagick functions return
2605 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2608 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2610 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2611 fill background (Bug#8992).
2613 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2615 * window.c (Vwindow_combination_resize)
2616 (Vwindow_combination_limit): Use t instead of non-nil in
2618 (Vrecenter_redisplay): Add first sentence of doc-string on
2620 (Frecenter): Fix doc-string typo.
2622 2011-12-11 Kenichi Handa <handa@m17n.org>
2624 * coding.c (Funencodable_char_position): Pay attention to the
2625 buffer text relocation (Bug#9389).
2627 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2629 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2630 gtk_init (Bug#10100).
2632 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2634 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2635 IT->string is nil. (Bug#10263)
2637 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2639 * nsterm.h (x_free_frame_resources): Declare.
2641 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2642 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2644 * nsterm.h (ns_get_defaults_value): Declare.
2646 * nsterm.m (ns_default): Call ns_get_defaults_value.
2648 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2650 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2653 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2655 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2656 that where the value of an _OBJC_* symbol points to is in the .bss
2657 section (Bug#10240).
2659 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2661 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2662 after the loop to call ccl_driver at least once (Bug#8619).
2664 2011-12-08 Kenichi Handa <handa@m17n.org>
2666 * ftfont.c (get_adstyle_property): Fix previous change
2669 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2671 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2672 dirs from the default value of EMACSLOADPATH (bug#10208).
2674 2011-12-07 Glenn Morris <rgm@gnu.org>
2676 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2677 installation and source directories as well. (Bug#10208)
2679 2011-12-06 Chong Yidong <cyd@gnu.org>
2681 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2683 2011-12-06 Glenn Morris <rgm@gnu.org>
2685 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2686 as an error, not just -1. (Bug#10217)
2688 2011-12-05 Chong Yidong <cyd@gnu.org>
2690 * keyboard.c (process_special_events): New function.
2691 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2693 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2695 * coding.c (encode_designation_at_bol): Don't use uninitialized
2696 local variable (Bug#9318).
2698 2011-12-05 Kenichi Handa <handa@m17n.org>
2700 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2701 return Qnil (Bug#8046, Bug#10193).
2703 2011-12-05 Kenichi Handa <handa@m17n.org>
2705 * coding.c (encode_designation_at_bol): New args charbuf_end and
2706 dst. Return the number of produced bytes. Callers changed.
2707 (coding_set_source): Return how many bytes coding->source was
2709 (coding_set_destination): Return how many bytes
2710 coding->destination was relocated.
2711 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2712 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2714 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2716 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2717 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2720 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2722 The following changes are to fix Bug#9318.
2724 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2725 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2726 (encode_coding_iso_2022, encode_coding_sjis)
2727 (encode_coding_big5, encode_coding_charset): Use the above macros.
2729 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2731 * lisp.h (process_quit_flag): Fix external declaration.
2733 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2735 Don't macro-inline non-performance-critical code.
2736 * eval.c (process_quit_flag): New function.
2737 * lisp.h (QUIT): Use it.
2739 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2741 * nsfns.m (get_geometry_from_preferences): New function.
2742 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2744 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2746 * emacs.c (Qkill_emacs): Define.
2747 (syms_of_emacs): Initialize it.
2748 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2749 Qquit_flag to `kill-emacs' instead.
2750 (quit_throw_to_read_char): Add parameter `from_signal'.
2751 All callers changed. Call Fkill_emacs if requested and safe.
2752 * lisp.h (QUIT): Call Fkill_emacs if requested.
2754 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2756 * widget.c (update_wm_hints): Return if wmshell is null.
2757 (widget_update_wm_size_hints): New function.
2759 * widget.h (widget_update_wm_size_hints): Declare.
2761 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2762 widget_update_wm_size_hints (Bug#10104).
2764 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2766 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2767 before a newline, prepare the bidi iterator for consuming the
2768 newline, and keep the current paragraph direction. (Bug#10183)
2769 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2771 2011-12-02 Juri Linkov <juri@jurta.org>
2773 * search.c (Fword_search_regexp): New Lisp function created from
2774 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2775 (Fword_search_backward, Fword_search_forward)
2776 (Fword_search_backward_lax, Fword_search_forward_lax):
2777 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2778 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2780 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2782 * fileio.c (Finsert_file_contents): Move after-change-function call
2783 to before the "handled:" label, since all "goto handled" appear in
2784 cases where the *-change-functions have already been properly called
2787 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2789 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2790 waiting for input. (Bug#10169)
2792 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2794 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2795 verifies glyph row's hash code--we have just reallocated the
2796 glyphs, so their contents can be complete garbage. (Bug#10164)
2798 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2800 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2802 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2804 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2805 attributes are tested _before_ calling verify_row_hash, to protect
2806 against GCC re-ordering of the tests. (Bug#10164)
2808 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2810 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2812 * xterm.c (handle_one_xevent): Only set async_visible and friends
2813 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2814 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2815 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2817 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2819 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2820 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2821 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2822 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2823 All uses changed to use GCPRO1 etc.
2824 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2825 Revert to old implementation (i.e., before 2011-03-11).
2827 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2829 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2830 of scroll runs so as to avoid assigning disabled bogus rows and
2831 unnecessary graphics copy operations.
2833 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2835 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2836 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2837 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2838 (malloc, free, realloc, calloc): Redirect to e_* only when
2841 * lisp.h (GCTYPEBITS): Move before first use.
2842 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2843 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2844 this macro definition.
2846 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2849 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2851 * gtkutil.c (xg_create_frame_widgets):
2852 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2853 present with Gtk+ 2.0.
2855 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2857 * fileio.c (Finsert_file_contents): Undo previous change; see
2858 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2860 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2862 Rename locals to avoid shadowing.
2863 * fileio.c (Finsert_file_contents):
2864 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2865 * process.c (wait_reading_process_output):
2866 Rename inner 'proc' to 'p' to avoid shadowing.
2867 Indent for consistency with usual Emacs style.
2869 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2871 * xdisp.c (redisplay_window): If cursor row is not fully visible
2872 after recentering, and scroll-conservatively is set to a large
2873 number, scroll window by a few more lines to make the cursor fully
2874 visible and out of scroll-margin. (Bug#10105)
2875 (start_display): Don't move to the next line if the display should
2876 start at a newline that is part of a display vector or an overlay
2879 2011-11-24 Juri Linkov <juri@jurta.org>
2881 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2882 after the `MagickPingImage' call. (Bug#10112)
2884 2011-11-23 Chong Yidong <cyd@gnu.org>
2886 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2888 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2890 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2891 making another buffer current. (Bug#10114)
2893 2011-11-23 Glenn Morris <rgm@gnu.org>
2895 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2897 2011-11-23 Chong Yidong <cyd@gnu.org>
2899 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2900 using it (Bug#5984).
2902 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2904 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2905 and header-lines, as they don't have one computed for them.
2908 * .gdbinit (prow): Make displayed values more self-explaining.
2909 Add row's hash code.
2911 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2913 * process.c (wait_reading_process_output): Fix asynchrounous
2914 GnuTLS socket handling on some versions of the GnuTLS library.
2915 (wait_reading_process_output): Add comment and URL.
2917 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2919 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2921 2011-11-21 Chong Yidong <cyd@gnu.org>
2923 * window.c (Fnext_window, Fprevious_window): Doc fix.
2925 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2927 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2929 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2931 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2933 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2935 * window.c (Fset_window_combination_limit): Rename argument
2937 (Vwindow_combination_limit): Remove "status" from doc-string.
2939 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2941 * m/ibms390.h: Remove.
2942 * m/ibms390x.h: Don't include "ibms390.h".
2944 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2946 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2947 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2949 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2951 * casetab.c (Fset_case_table):
2952 * charset.c (Fcharset_after): Fix typos.
2954 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2956 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2957 Otherwise, valgrind does not work on some platforms.
2958 Problem reported by Andreas Schwab in
2959 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2960 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2961 is set, removing the need for VIRT_ADDRESS_VARIES.
2962 (PURE_P): Use a more-efficient implementation that needs just one
2963 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2964 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2965 to 4 (xorl, subq, cmpq, setbe).
2966 * alloc.c (pure): Always extern now, since that's the
2967 VIRT_ADDR_VARIES behavior.
2968 (PURE_POINTER_P): Use a single comparison, not two, for
2969 consistency with the new puresize.h.
2970 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2971 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2972 Remove VIRT_ADDR_VARIES no longer needed.
2974 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2976 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2977 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2978 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2979 behave as if the cursor position were at the window margin.
2981 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2982 and the cursor position is out of bounds, behave as if the cursor
2983 position were at the window margin. (Bug#10075)
2985 2011-11-18 Chong Yidong <cyd@gnu.org>
2987 * window.c (Fwindow_combination_limit): Make first argument
2988 non-optional, since it is meaningless for live windows like the
2991 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2993 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2995 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2997 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2998 (graft_intervals_into_buffer): Simplify.
3000 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3002 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3003 hash values of the two rows.
3004 (copy_row_except_pointers): Preserve the used[] arrays and the
3005 hash values of the two rows. (Bug#10035)
3006 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3008 * xdisp.c (row_hash): New function, body extracted from
3009 compute_line_metrics.
3010 (compute_line_metrics): Call row_hash, instead of computing the
3013 * dispnew.c (verify_row_hash): Call row_hash for computing the
3014 hash code of a row, instead of duplicating code from xdisp.c.
3016 * dispextern.h (row_hash): Add prototype.
3018 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3020 * frame.c (delete_frame): Don't delete the terminal when the last
3021 X frame is closed if emacs is built with GTK toolkit.
3023 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3025 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3027 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3029 * window.c (Vwindow_splits): Rename to
3030 Vwindow_combination_resize. Suggested by Juri Linkov.
3031 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3034 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3036 * nsfns.m (Fns_font_name):
3037 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3039 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3041 * window.h (window): Rename slot "nest" to "combination_limit".
3042 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3043 (Fset_window_nest): Rename to Fset_window_combination_limit.
3044 (Vwindow_nest): Rename to Vwindow_combination_limit.
3045 (recombine_windows, make_parent_window, make_window)
3046 (Fsplit_window_internal, saved_window)
3047 (Fset_window_configuration, save_window_save): Rename all
3048 occurrences of window_nest to window_combination_limit.
3050 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3052 * image.c (imagemagick_load_image): Fix typo.
3054 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3056 * xdisp.c (display_line): Move the call to
3057 highlight_trailing_whitespace before the call to
3058 compute_line_metrics, since the latter needs to see the final
3059 faces of all the glyphs to compute ROW's hash value.
3060 Fixes assertion violations in row_equal_p. (Bug#10035)
3062 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3064 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3065 just return (bug#10044).
3067 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3069 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3070 with user-defined heap size. Bump the default size of the temacs
3071 heap to 27MB, to avoid memory warning when running temacs.
3072 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3074 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3075 current_matrix and desired_matrix. (Bug#9990)
3076 (verify_row_hash) [XASSERTS]: New function.
3077 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3078 that the hash value of glyph rows is correct.
3080 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3082 * window.h (window): Remove splits slot.
3083 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3084 (Fdelete_other_windows_internal, make_parent_window)
3085 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3086 (Fset_window_configuration, save_window_save): Don't deal with
3087 split status of windows.
3088 (saved_window): Remove splits slot.
3089 (Vwindow_splits): Rewrite doc-string.
3091 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3093 * xfns.c (unwind_create_frame):
3094 * nsfns.m (unwind_create_frame):
3095 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3096 Vframe_list (Bug#9999).
3098 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3100 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3102 2011-11-11 Kenichi Handa <handa@m17n.org>
3104 * callproc.c (Fcall_process): Set the member dst_multibyte of
3107 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3109 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3110 avoid a crash (bug#9496).
3112 2011-11-09 Chong Yidong <cyd@gnu.org>
3114 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3115 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3117 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3119 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3121 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3123 Avoid some portability problems by eschewing 'extern inline' functions.
3124 The trivial performance wins aren't worth the portability hassles; see
3125 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3127 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3128 (window_box_width, window_box_left, window_box_left_offset)
3129 (window_box_right, window_box_right_offset): Undo previous change,
3130 by removing the "extern"s.
3131 * intervals.c (adjust_intervals_for_insertion)
3132 (adjust_intervals_for_deletion): Undo previous change,
3133 making these static again.
3134 (offset_intervals, temp_set_point_both, temp_set_point)
3135 (copy_intervals_to_string): No longer inline.
3136 * xdisp.c (window_text_bottom_y, window_box_width)
3137 (window_box_height, window_box_left_offset)
3138 (window_box_right_offset, window_box_left, window_box_right)
3139 (window_box): No longer inline.
3141 2011-11-08 Chong Yidong <cyd@gnu.org>
3143 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3144 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3145 Signal an error if not a live window.
3146 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3147 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3149 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3151 * lisp.h (syms_of_abbrev): Remove declaration.
3152 Reported by CHENG Gao <chenggao@royau.me>.
3154 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3156 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3157 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3158 of temacs in GUI mode.
3160 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3162 * window.h: Declare delete_all_child_windows instead of
3163 delete_all_subwindows.
3164 * window.c (Fwindow_nest, Fset_window_nest)
3165 (Fset_window_new_total, Fset_window_new_normal)
3166 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3167 (delete_all_subwindows): Rename to delete_all_child_windows.
3168 (Fdelete_other_windows_internal, Fset_window_configuration):
3169 Call delete_all_child_windows instead of delete_all_subwindows.
3170 * frame.c (delete_frame): Call delete_all_child_windows instead
3171 of delete_all_subwindows.
3173 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3175 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3176 This is also needed for porting to any host where GC_MARK_STACK is
3177 not GC_MAKE_GCPROS_NOOPS.
3178 (which_symbols): Use it.
3180 2011-11-07 Kenichi Handa <handa@m17n.org>
3182 * coding.c (coding_set_destination): Check coding->src_pos only
3183 when coding->src_object is a buffer (bug#9910).
3185 * process.c (send_process): Set the member src_multibyte of coding
3186 to 0 (bug#9911) when sending a unibyte text.
3188 * callproc.c (Fcall_process): Set the member src_multibyte of
3189 process_coding to 0 (bug#9912).
3191 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3193 * xmenu.c (cleanup_widget_value_tree): New function.
3194 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3195 calling free_menubar_widget_value_tree directly (Bug#9830).
3197 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3199 Fix some portability problems with 'inline'.
3200 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3201 (window_box_width, window_box_left, window_box_left_offset)
3202 (window_box_right, window_box_right_offset): Declare extern.
3203 Otherwise, these inline functions do not conform to C99 and
3204 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3205 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3206 * intervals.c (adjust_intervals_for_insertion)
3207 (adjust_intervals_for_deletion): Now extern, because otherwise the
3208 extern inline functions 'offset_intervals' couldn't refer to it.
3209 (static_offset_intervals): Remove.
3210 (offset_intervals): Rewrite using the old contents of
3211 static_offset_intervals. The old version didn't conform to C99
3212 because an extern inline function contained a reference to an
3213 identifier with static linkage.
3215 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3217 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3220 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3222 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3223 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3224 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3225 return Qleft_to_right.
3227 2011-11-06 Chong Yidong <cyd@gnu.org>
3229 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3230 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3231 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3232 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3233 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3234 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3235 (Fwindow_vscroll): Doc fix.
3236 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3237 argument, since it makes no sense to pass a live window and for
3238 consistency with window-child.
3240 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3242 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3245 2011-11-05 Jason Rumney <jasonr@gnu.org>
3247 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3248 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3250 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3251 bitwise arithmetic preventing use of unicode-sip and non-truetype
3254 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3256 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3259 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3260 initialization code to keep similarity to xfns.c after changes
3263 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3265 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3266 (unwind_create_frame): New function (Bug#9943).
3267 (Fx_create_frame): Restructure code to be more similar to the one in
3268 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3269 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3270 Move terminal->reference_count++ just before making the frame official
3273 * nsterm.m (x_free_frame_resources): New function.
3274 (x_destroy_window): Move code to x_free_frame_resources.
3276 * xfns.c (unwind_create_frame): Fix comment.
3277 (Fx_create_frame, x_create_tip_frame):
3278 Move terminal->reference_count++ just before making the frame
3279 official. Move initialization of image_cache_refcount and
3280 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3282 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3284 Support MSVC build with newer versions of Visual Studio.
3285 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3286 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3289 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3290 which are not supported by MSVC.
3291 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3292 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3294 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3296 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3298 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3300 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3302 Support MSVC build with newer versions of Visual Studio.
3303 * w32.c: Don't include w32api.h for MSVC.
3304 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3306 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3307 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3308 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3309 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3311 (alloca) [_MSC_VER]: Define to _alloca.
3313 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3315 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3317 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3319 * xdisp.c (note_mouse_highlight): If either of
3320 previous/next-single-property-change returns nil, treat that as
3321 the beginning or the end of the buffer. (Bug#9955)
3323 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3325 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3326 label is not null (Bug#9951).
3327 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3330 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3332 * window.c (Fwindow_body_size): Mention in the doc string that the
3333 return value is in frame's canonical units. (Bug#9949)
3335 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3337 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3339 * w32fns.c (unwind_create_frame): If needed, free the glyph
3340 matrices of the partially constructed frame. (Bug#9943)
3341 * xfns.c (unwind_create_frame): Likewise.
3343 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3345 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3346 Don't stop backward scan on the continuation glyph, even though
3347 its CHARPOS is positive.
3348 (mouse_face_from_buffer_pos, note_mouse_highlight):
3349 Rename cover_string to disp_string.
3351 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3353 * window.c (temp_output_buffer_show): Don't use
3354 Vtemp_buffer_show_specifiers.
3355 (Vtemp_buffer_show_specifiers): Remove unused variable.
3357 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3359 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3360 past the beginning of the current glyph matrix.
3362 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3364 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3365 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3366 HAVE_GTK3 (Bug#9869).
3368 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3369 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3371 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3373 * xterm.c: Declare x_handle_net_wm_state to return int.
3374 (handle_one_xevent): Check if we are iconified but don't have
3375 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3376 (get_current_wm_state): Return non-zero if not hidden,
3377 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3378 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3379 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3380 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3382 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3384 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3385 so that this new function doesn't get optimized away by a
3386 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3388 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3390 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3392 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3394 Fix the `xbytecode' command.
3395 * .gdbinit (xprintbytestr): New command.
3396 (xwhichsymbols): Rename from `which'; all callers changed.
3397 (xbytecode): Print the byte-code string as well.
3399 2011-10-29 Kim Storm <storm@cua.dk>
3401 * alloc.c (which_symbols): New function.
3403 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3405 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3408 2011-10-29 Glenn Morris <rgm@gnu.org>
3410 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3411 Not clear what it was for, and it causes various bugs. (Bug#9839)
3413 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3415 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3416 possible random value that matches one of those tested as
3417 condition to clear the mouse face.
3419 2011-10-28 Chong Yidong <cyd@gnu.org>
3421 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3423 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3425 * window.c (make_window): Initialize phys_cursor_on_p.
3427 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3429 * lisp.h (struct Lisp_Symbol): Update comments.
3431 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3433 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3435 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3437 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3438 <oslsachem@gmail.com> for helping to debug this.
3440 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3441 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3442 (g_b_init_get_glyph_outline_w): New static variables.
3443 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3444 (GetGlyphOutlineW_Proc): New typedefs.
3445 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3446 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3448 (w32font_open_internal, compute_metrics):
3449 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3450 instead of calling the "wide" APIs directly.
3452 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3454 * w32.h (syms_of_w32font): Add prototype.
3456 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3458 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3459 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3460 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3461 (Fmove_to_window_line): Doc fix.
3463 2011-10-27 Chong Yidong <cyd@gnu.org>
3465 * process.c (make_process): Set gnutls_state to NULL.
3467 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3468 non-NULL, regardless of GNUTLS_INITSTAGE.
3469 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3470 an error. Set process slots as soon as we allocate them.
3472 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3474 2011-10-27 Chong Yidong <cyd@gnu.org>
3476 * gnutls.c (emacs_gnutls_deinit): New function.
3477 Deallocate credentials structures as well as calling gnutls_deinit.
3478 (Fgnutls_deinit, Fgnutls_boot): Use it.
3480 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3481 (deactivate_process): Call emacs_gnutls_deinit.
3483 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3485 * image.c (x_create_x_image_and_pixmap):
3486 * w32.c (sys_rename, w32_delayed_load):
3487 * w32font.c (fill_in_logfont):
3488 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3490 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3492 * w32fns.c (w32_default_color_map): New function,
3493 extracted from Fw32_default_color_map.
3494 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3496 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3498 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3500 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3502 * keyboard.c (test_undefined): New function (bug#9751).
3503 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3505 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3507 * sysdep.c (init_sys_modes): Fix the check for the controlling
3508 terminal (Bug#6649).
3510 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3512 * dispextern.h (struct bidi_it): New member next_en_type.
3514 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3515 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3516 current character, check also for next_en_type being WEAK_EN.
3517 (bidi_resolve_weak): Don't enter the expensive loop if the current
3518 position is before next_en_pos. Record the bidi type of the first
3519 non-ET, non-BN character we find, in addition to its position.
3520 (bidi_level_of_next_char): Invalidate next_en_type when
3521 next_en_pos is over-stepped.
3523 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3525 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3526 * editfns.c: Rewrite current-time-zone so that it invokes
3527 the equivalent of (format-time-string "%Z") to get the time zone name.
3528 This fixes a bug when the time zone name contains characters that
3529 need converting from the system time locale to Emacs internal format.
3530 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3531 that patch fixed format-time-string to do the conversion, but
3532 I forgot to fix current-time-zone.
3533 (format_time_string): New function, containing most of
3534 what Fformat_time_string used to contain.
3535 (Fformat_time_string): Rewrite in terms of format_time_string.
3536 This doesn't change this function's behavior.
3537 (current-time-zone): Rewrite to use format_time_string.
3538 This fixes the bug reported by Michael Schierl in
3539 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3540 Jason Rumney's 2007-06-07 change worked around this bug, but
3542 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3544 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3546 * xdisp.c (start_display): If the character at POS is displayed
3547 via a display vector, reset IT->current.dpvec_index to zero.
3548 (try_window_reusing_current_matrix): If a line ends in a display
3549 vector or the next line starts in a display vector, continue
3550 redrawing the window even though the character position of
3551 start_row was reached.
3554 2011-10-18 Chong Yidong <cyd@gnu.org>
3556 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3557 with nobreak-char-display too.
3559 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3561 Fix part 3 of bug#9771.
3562 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3563 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3564 non-neutral characters if the current character is a paragraph
3565 separator (a.k.a. Newline). This avoids running the same
3566 expensive loop twice, once when we consume the preceding newline
3567 and the other time when the line actually needs to be displayed.
3568 Avoid the loop when we see neutrals on the base embedding level
3569 following a character whose directionality is the same as the
3570 paragraph's. This avoids running the expensive loop when a line
3571 ends in a long sequence of neutrals, like control characters.
3572 Add assertion against STRONG_AL type. Slightly rearrange code
3573 that determines the type of a neutral given the first non-neutral
3575 (bidi_level_of_next_char): Set next_en_pos to zero when
3576 invalidating its info.
3578 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3580 * xdisp.c (push_display_prop): Determine whether to record string
3581 or buffer position by IT->string, not by IT->method. Allow
3582 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3583 (move_it_vertically_backward): Don't look for character position
3584 immediately after the newline when in a continuation line.
3587 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3589 * window.c (coordinates_in_window): Rewrite and delabelize
3590 vertical border check. (Bug#5357) (Bug#9618)
3592 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3594 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3595 errors in XSetWindowBorder (bug#9310).
3597 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3599 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3600 avoid crash when xmalloc overrun checking is enabled.
3602 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3604 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3605 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3606 cursor motion with <left> and <right> arrow keys.
3608 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3609 some callers set that themselves.
3611 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3613 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3614 display string and the previous row comes from the same string and
3615 is empty. (Bug#9739) (Bug#9738)
3617 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3619 * doc.c (get_doc_string): Encode file name (bug#9735).
3621 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3623 * bidi.c (bidi_level_of_next_char):
3624 * xdisp.c (get_visually_first_element): Remove old incorrect
3625 comments regarding the Unicode Line Separator character.
3627 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3629 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3631 * alloc.c (Fgc_status): Do not access beyond zombies array
3632 boundary if nzombies > MAX_ZOMBIES.
3633 * alloc.c (dump_zombies): Add missing format specifier.
3635 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3637 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3638 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3640 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3641 Some packages use them to denote characters with modifiers.
3643 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3645 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3646 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3647 matching a pp-number. Rename parameter var to var1.
3649 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3651 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3653 2011-10-08 Glenn Morris <rgm@gnu.org>
3655 * callint.c (Fcall_interactively): Give a more explicit error for the
3656 'c' case with a non-character input. (Bug#8479)
3658 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3660 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3662 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3663 lines that are hscrolled on the left.
3665 * dispnew.c (buffer_posn_from_coords): Account for a possible
3666 presence of header-line. (Bug#4426)
3668 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3670 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3671 Don't advertise functionality which we discourage or doesn't work.
3673 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3675 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3676 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3677 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3678 this makes Emacs dump core during garbage collection on rare
3679 occasions. sizeof is obviously inferior to offsetof here, so
3680 stick with offsetof.
3681 (GC_POINTER_ALIGNMENT): New macro.
3682 (mark_memory): Omit 3rd (offset) arg; caller changed.
3683 Don't assume EMACS_INT alignment is the same as pointer alignment.
3685 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3687 * keyboard.c (read_key_sequence_remapped): New var.
3688 (read_key_sequence): Compute remapping in the right buffer.
3689 (command_loop_1): Use read_key_sequence's remapping directly.
3691 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3693 * dired.c (file_name_completion): Don't expand file name.
3694 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3695 before checking file name handler.
3697 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3698 they've been requested explicitly (bug#9591).
3700 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3702 * keymap.c (Fsingle_key_description): Use make_specified_string
3703 instead of build_string to build string from push_key_description.
3706 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3708 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3709 This fixes a Y2038 bug on 64-bit hosts.
3710 * buffer.c (reset_buffer):
3711 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3712 (Fclear_buffer_auto_save_failure):
3713 Use 0, not -1, to represent an unset failure time, since time_t
3714 might not be signed.
3716 Remove dependency on glibc malloc internals.
3717 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3718 Move back here from lisp.h, but with their new implementations.
3719 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3720 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3721 * charset.c (charset_table_init): New static var.
3722 (syms_of_charset): Use it instead of xmalloc. This removes a
3723 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3724 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3725 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3726 Move back to alloc.c.
3727 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3728 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3730 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3732 * nsterm.m (windowDidResize): Call x_set_window_size only when
3733 ns_in_resize is true. Otherwise set pixelwidth/height and
3734 call change_frame_size (Bug#9628).
3736 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3738 Port --enable-checking=all to Fedora 14 x86-64.
3739 * charset.c (syms_of_charset): Also account for glibc malloc's
3740 internal overhead when calculating the initial malloc maximum.
3742 Port --enable-checking=all to Fedora 14 x86.
3743 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3745 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3746 (overrun_check_realloc, overrun_check_free):
3747 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3748 That way, xmalloc returns a properly-aligned pointer even if
3749 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3750 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3751 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3752 into account when calculating the initial malloc maximum.
3753 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3754 Move here from alloc.c, so that charset.c can use it too.
3755 Properly align; the old code wasn't right for common 32-bit hosts
3756 when configured with --enable-checking=all.
3757 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3758 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3760 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3762 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3765 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3767 * xdisp.c (compute_display_string_end): If there's no display
3768 string at CHARPOS, return -1.
3770 * bidi.c (bidi_fetch_char): When compute_display_string_end
3771 returns a negative value, treat the character as a normal
3772 character not covered by a display string. (Bug#9624)
3774 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3776 * lread.c (Fread_from_string): Fix typo in docstring.
3778 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3780 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3781 newline, reseat the iterator instead of bidi-iterating there one
3782 character at a time. (Bug#9610)
3783 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3784 TO_CHARPOS if the bidi iterator is at base embedding level.
3786 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3788 * lread.c (readevalloop): Use correct code for NBSP.
3789 (read1): Likewise. (Bug#9608)
3791 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3793 * dbusbind.c (Fdbus_register_signal): When service is not
3794 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3796 2011-09-25 Glenn Morris <rgm@gnu.org>
3798 * buffer.c (truncate-lines): Doc fix.
3800 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3802 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3803 (Fset_window_next_buffers): Doc fix.
3805 2011-09-24 Glenn Morris <rgm@gnu.org>
3807 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3809 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3811 Fix minor problems found by static checking.
3812 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3813 * indent.c (Fvertical_motion): Fix == vs = typo.
3815 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3817 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3818 Default value is now t. Doc fix.
3820 * indent.c (Fvertical_motion): Compute and apply the overshoot
3821 logic when moving up, not only when moving down. Fix the
3822 confusing name and values of the it_overshoot_expected variable;
3823 logic changes accordingly. (Bug#9254) (Bug#9549)
3825 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3826 CHARPOS is covered by a display string which includes newlines.
3827 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3828 is covered by a display string with embedded newlines.
3830 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3832 * dbusbind.c (Fdbus_register_signal): Add match rule to
3833 Vdbus_registered_objects_table. (Bug#9581)
3834 (Fdbus_register_method, Vdbus_registered_objects_table):
3837 2011-09-24 Jim Meyering <meyering@redhat.com>
3839 do not ignore write error for any output size
3840 The previous change was incomplete.
3841 While it makes emacs --batch detect the vast majority of stdout
3842 write failures, errors were still ignored whenever the output size is
3843 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3844 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3845 && echo FAIL: ignored write error
3846 FAIL: ignored write error
3847 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3848 && echo FAIL: ignored write error
3849 FAIL: ignored write error
3850 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3852 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3854 * emacs.c (Fkill_emacs): In noninteractive mode exit
3855 non-successfully if a write error occurred on stdout. (Bug#9574)
3857 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3859 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3862 * dispextern.h (struct it): Update the comment documenting what
3865 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3867 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3868 a display string, extend search for cursor position to end of row.
3869 (find_row_edges): If the row ends in a newline from a display
3870 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3871 Handle the case of a display string with multiple newlines.
3872 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3873 non-empty line. Fixes confusing cursor motion with arrow keys at
3874 the beginning of a line that starts with whitespace.
3876 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3878 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3881 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3883 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3886 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3888 * xdisp.c (display_line): Record maximum and minimum buffer
3889 positions even if no glyphs were produced (e.g., by a zero-width
3890 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3891 buffer positions that will be removed from the glyph row because
3893 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3894 column is beyond frame width: don't subtract 1 "pixel" when
3895 computing width of the stretch.
3896 (reseat_at_next_visible_line_start): Undo the change made on
3897 2011-09-17 that saved paragraph information and restored it after
3898 the call to `reseat'. (Bug#9545)
3900 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3902 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3903 and turn window cursor on if cleared (Bug#9415).
3905 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3907 * search.c (boyer_moore): Take unibyte characters from pattern
3908 literally. (Bug#9458)
3910 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3912 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3914 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3916 Fix minor problem found by static checking.
3917 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3918 initialized, to pacify gcc -Wuninitialized.
3920 * fileio.c: Report proper errno when syscall falls.
3921 (Finsert_file_contents): Save and restore errno,
3922 so that report_file_error outputs the correct diagnostic.
3923 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3925 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3927 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3929 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3931 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3932 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3934 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3936 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3937 about the current paragraph and restore it after the call to reseat.
3939 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3940 (bidi_find_paragraph_start): Search back for paragraph beginning
3941 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3942 (bidi_move_to_visually_next): Only trigger paragraph-related
3943 computations when the last character is a newline or at EOB, not
3944 just any NEUTRAL_B. (Bug#9470)
3946 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3947 truncated lines if point is covered by a display string. (Bug#9524)
3949 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3951 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3952 (cons_to_x_long): New function.
3953 (lisp_data_to_selection_data): Use it. Correct the test for
3954 short-versus-long data; it was negated. Break out of vector
3955 loop, for efficiency, when a long datum is discovered.
3957 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3959 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3961 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3963 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3964 GCC PR/17406) by declaring this function with external scope.
3966 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3968 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3969 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3971 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3973 * editfns.c (Fformat): Correctly handle text properties on "%%".
3975 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3977 * xterm.c (x_draw_composite_glyph_string_foreground):
3978 * w32term.c (x_draw_composite_glyph_string_foreground):
3979 * term.c (encode_terminal_code):
3980 * composite.c (composition_update_it, get_composition_id):
3981 * xdisp.c (get_next_display_element)
3982 (fill_composite_glyph_string): Add comments about special meaning
3983 of TAB characters in a composition.
3985 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3987 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3988 This occurs when processing a multibyte format.
3989 Problem reported by Wolfgang Jenker.
3991 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3993 * xdisp.c (try_cursor_movement): Only check for exact match if
3994 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3996 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3998 Remove unused external symbols.
3999 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4000 * xdisp.c (calc_pixel_width_or_height): Now static.
4001 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4002 * indent.c (check_display_width):
4003 * w32term.c: Fix comment to match code.
4004 * xterm.c, xterm.h (x_catching_errors): Remove.
4006 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4008 * xselect.c: Use signed conversions more consistently (Bug#9498).
4009 (selection_data_to_lisp_data): Assume incoming selection data are
4010 signed integers, not unsigned. This is to be consistent with
4011 outgoing selection data, which was modified to use signed integers
4012 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4013 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4014 expects long, not unsigned long.
4016 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4018 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4019 computation of loop end. Reported by Johan Bockgård
4022 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4024 * frame.c (Fother_visible_frames_p): Function deleted.
4026 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4028 * indent.c (compute_motion): Process display vector front to back
4029 rather than the other way around. (Bug#2496)
4031 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4033 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4035 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4037 * minibuf.c (Fread_from_minibuffer): Doc fix.
4039 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4041 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4042 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4044 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4046 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4047 value for non-existent files.
4049 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4051 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4052 set its "size" to -1. This will set the modtime_size field of
4053 the corresponding buffer to -1, which is what
4054 verify-visited-file-modtime expects for files that do not exist.
4057 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4059 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4061 * lisp.h: ... from here. push_key_description is no longer
4062 defined in keyboard.c, so its declaration should not be in
4063 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4064 logically belongs with push_key_description.
4066 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4068 * buffer.h: Include <sys/types.h> instead of <time.h>.
4069 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4070 Problem reported by Herbert J. Skuhra.
4072 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4074 * xml.c (parse_region): Make the parsing work for
4075 non-comment-starting XML files again (bug#9144).
4077 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4079 * image.c (gif_load): Fix calculation of bottom and right corner.
4082 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4084 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4085 redisplay in small windows.
4087 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4089 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4091 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4093 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4094 Operate on live windows only.
4096 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4098 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4100 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4102 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4103 only under bidi iteration.
4105 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4107 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4109 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4111 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4112 Without this fix, the command to link temacs failed due to an
4113 undefined symbol __builtin_isnan. This is because
4114 /usr/include/iso/math_c99.h #defines isnan(x) to
4115 __builtin_isnan(x), but the bundled gcc, which identifies itself
4116 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4118 * floatfns.c (isnan): #undef, and then #define to a clone of
4120 (Fisnan): Always define, since it's always available now.
4121 (syms_of_floatfns): Always define isnan at the Lisp level.
4123 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4125 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4127 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4129 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4130 The previous code assumed that file offsets (off_t values) fit in
4131 EMACS_INT variables, which is not true on typical 32-bit hosts.
4132 The code messed up by falsely reporting buffer overflow in cases
4133 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4134 when "big" contains more than 2**29 bytes, even though this
4135 inserts just one byte and does not overflow the buffer.
4136 (Finsert_file_contents): Store file offsets as off_t
4137 values, not as EMACS_INT values. Check for overflow when
4138 converting between EMACS_INT and off_t. When checking for
4139 buffer overflow or for overlap, take the offsets into account.
4140 Don't use EMACS_INT for small values where int suffices.
4141 When checking for overlap, fix a typo: ZV was used where
4142 ZV_BYTE was intended.
4143 (Fwrite_region): Don't assume off_t fits into 'long'.
4144 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4146 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4148 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4150 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4152 sprintf-related integer and memory overflow issues (Bug#9412).
4154 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4155 (esprintf, exprintf, evxprintf): New functions.
4156 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4157 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4158 (modify_event_symbol): Do not assume that the length of
4159 name_alist_or_stem is safe to alloca and fits in int.
4160 (Fexecute_extended_command): Likewise for function name and binding.
4161 (Frecursion_depth): Wrap around reliably on integer overflow.
4162 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4163 since some callers pass EMACS_INT values.
4164 (Fsingle_key_description): Don't crash if symbol name contains more
4165 than MAX_ALLOCA bytes.
4166 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4167 (get_minibuffer): Arg is now EMACS_INT, not int.
4168 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4169 (esprintf, exprintf, evxprintf): New decls.
4170 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4172 * dbusbind.c (signature_cat): New function.
4173 (xd_signature, Fdbus_register_signal):
4174 Do not overrun buffer; instead, report string overflow.
4176 * dispnew.c (add_window_display_history): Don't overrun buffer.
4177 Truncate instead; this is OK since it's just a log.
4179 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4180 even if the time zone offset is outlandishly large.
4181 Don't mishandle offset == INT_MIN.
4183 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4184 when creating daemon; the previous buffer-overflow check was incorrect.
4186 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4187 which has the guts of the old verror function.
4189 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4190 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4192 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4193 (font_unparse_xlfd): Don't blindly alloca long strings.
4194 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4195 fits in int, when using sprintf. Use single snprintf to count
4196 length of string rather than counting it via multiple sprintfs;
4197 that's simpler and more reliable.
4198 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4199 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4200 sprintf, in case result does not fit in int.
4202 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4203 (fontset_from_font): Print it.
4205 * frame.c (tty_frame_count): Now printmax_t, not int.
4206 (make_terminal_frame, set_term_frame_name): Print it.
4207 (x_report_frame_params): In X, window IDs are unsigned long,
4208 not signed long, so print them as unsigned.
4209 (validate_x_resource_name): Check for implausibly long names,
4210 and don't assume name length fits in 'int'.
4211 (x_get_resource_string): Don't blindly alloca invocation name;
4212 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4215 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4216 (xg_check_special_colors, xg_set_geometry):
4217 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4219 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4220 Use esprintf, not sprintf, in case result does not fit in int.
4222 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4223 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4224 it as a large positive number.
4225 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4226 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4228 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4229 in case result does not fit in int.
4231 * print.c (float_to_string): Detect width overflow more reliably.
4232 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4233 buffer overrun. Don't assume list length fits in 'int'. Treat
4234 print length of 0 as 0, not as infinity; to be consistent with other
4235 uses of print length in this function. Don't overflow print length
4236 index. Don't assume hash table size fits in 'long', or that
4237 vectorlike size fits in 'unsigned long'.
4239 * process.c (make_process): Use printmax_t, not int, to format
4240 process-name gensyms.
4242 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4244 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4245 to avoid potential buffer overrun.
4247 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4248 if X resource line is longer than 512 bytes.
4250 * xfns.c (x_window): Make sprintf buffer a bit bigger
4251 to avoid potential buffer overrun.
4253 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4255 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4257 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4259 Integer overflow fixes for scrolling, etc.
4260 Without these, Emacs silently mishandles large integers sometimes.
4261 For example, "C-u 4294967297 M-x recenter" was treated as if
4262 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4264 * xdisp.c (try_window_id): Check Emacs fixnum range before
4265 converting to 'int'.
4267 * window.c (window_scroll_line_based, Frecenter):
4268 Check that an Emacs fixnum is in range before assigning it to 'int'.
4269 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4270 values converted from Emacs fixnums.
4271 (Frecenter): Don't wrap around a line count if it is out of 'int'
4272 range; instead, treat it as an extreme value.
4273 (Fset_window_configuration, compare_window_configurations):
4274 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4276 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4277 that can exceed INT_MAX. Check that EMACS_INT value is in range
4278 before assigning it to the (possibly-narrower) index.
4279 (match_limit): Don't assume that a fixnum can fit in 'int'.
4281 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4284 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4285 (Fvertical_motion): Don't wrap around LINES values that don't fit
4286 in 'int'. Instead, treat them as extreme values. This is good
4287 enough for windows, which can't have more than INT_MAX lines anyway.
4289 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4291 * Require libxml/parser.h to avoid compilation warning.
4293 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4295 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4296 since this reportedly can destroy thread storage.
4298 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4300 * syntax.c (find_defun_start): Update all cache variables if
4301 exiting early (Bug#9401).
4303 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4305 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4307 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4308 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4309 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4311 * term.c (tty_append_glyph): New function.
4312 (produce_stretch_glyph): Static function and its prototype deleted.
4314 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4317 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4319 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4320 when checking :margin (Bug#9390).
4321 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4322 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4323 so that the name doesn't mislead. All uses changed.
4325 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4327 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4330 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4332 * xdisp.c (move_it_to): Don't bail out early when reaching
4333 position beyond to_charpos, if we are scanning backwards.
4334 (move_it_vertically_backward): When DY == 0, make sure we get to
4335 the first character in the line after the newline.
4337 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4339 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4340 (ccl_driver): Do not generate an out-of-range pointer.
4341 (Fccl_execute_on_string): Remove unnecessary check for
4342 integer overflow, noted by Stefan Monnier in
4343 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4344 Remove a FIXME that didn't need fixing.
4345 Simplify the newly-introduced buffer reallocation code.
4347 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4349 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4351 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4353 Integer and memory overflow issues (Bug#9196).
4355 * doc.c (get_doc_string): Rework so that
4356 get_doc_string_buffer_size is the actual buffer size, rather than
4357 being 1 less than the actual buffer size; this makes xpalloc more
4360 * image.c (x_allocate_bitmap_record, cache_image):
4361 * xselect.c (Fx_register_dnd_atom):
4362 Simplify previous changes by using xpalloc.
4364 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4365 since either will do and ptrdiff_t is convenient with xpalloc.
4367 * charset.c (charset_table_size)
4368 (struct charset_sort_data.priority): Now ptrdiff_t.
4369 (charset_compare): Don't overflow if priorities differ greatly.
4370 (Fsort_charsets): Don't assume list length fits in int.
4371 Check for size-calculation overflow when allocating sort data.
4372 (syms_of_charset): Allocate an initial charset table that is
4373 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4375 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4377 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4378 The actual value is always <= INT_MAX, and leaving it unsigned made
4379 overflow checking harder.
4381 * dispextern.h (struct glyph_matrix.rows_allocated)
4382 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4383 with xpalloc. The values are still always <= INT_MAX.
4385 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4387 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4388 (SAFE_NALLOCA): New macro.
4390 * region-cache.c (struct boundary.pos, find_cache_boundary)
4391 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4392 (set_cache_region, invalidate_region_cache)
4393 (revalidate_region_cache, know_region_cache, region_cache_forward)
4394 (region_cache_backward, pp_cache):
4395 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4396 so that ptrdiff_t * can be passed to xpalloc.
4397 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4398 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4399 (pp_cache): Don't assume cache_len fits in int.
4400 * region-cache.h: Adjust extern decls to match.
4402 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4403 EMACS_INT, since either will do, for xpalloc.
4405 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4406 (xnmalloc, xnrealloc, xpalloc): New functions.
4408 * bidi.c (bidi_shelve_header_size): New constant.
4409 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4410 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4412 * bidi.c (bidi_cache_shrink):
4413 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4415 Don't update size of array until after memory allocation succeeds,
4416 because xmalloc/xrealloc may not return.
4417 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4418 now that we have proper integer overflow checking.
4419 (record_overlay_string, overlay_strings): Catch overflows when
4420 calculating size of overlay_str_buf.
4422 * callproc.c (Fcall_process): Check for size overflow when
4423 calculating size of args2.
4424 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4425 Normally we prefer signed values, but sticking with ptrdiff_t would
4426 require adding more-complicated checks.
4428 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4429 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4430 Redo buffer-overflow calculations to avoid integer overflow.
4431 Add a FIXME comment where memory seems to be over-allocated.
4433 * character.c (Fstring): Check for size-calculation overflow.
4435 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4436 unnecessary integer overflow. Check for size overflow.
4437 (encode_coding_object): Don't update size until xmalloc succeeds.
4439 * composite.c (get_composition_id): Check for overflow in glyph
4440 length calculations.
4442 Integer and memory overflow fixes for display code.
4443 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4444 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4445 (scrolling_window): Check for overflow in size calculations.
4446 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4447 Don't assume glyph table len fits in int.
4448 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4449 (row_table_size): Now ptrdiff_t, not int.
4450 (scrolling_window): Avoid overflow in size calculations.
4451 Don't update size until allocation succeeds.
4452 * fns.c (concat): Check for overflow in size calculations.
4453 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4454 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4455 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4457 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4458 (get_doc_string): Check for size calculation overflow.
4459 Don't update size until allocation succeeds.
4460 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4461 EMACS_INT, where ptrdiff_t will do.
4462 (Fsubstitute_command_keys): Check for string overflow.
4464 * editfns.c (set_time_zone_rule): Don't assume environment length
4466 (message_length): Now ptrdiff_t, not int.
4467 (Fmessage_box): Don't update size until allocation succeeds.
4468 Don't assume message length fits in int.
4469 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4471 * emacs.c (main): Do not reallocate argv, since there is a null at
4472 the end that can be overwritten, and this way there's no need to
4473 worry about size-calculation overflow.
4474 (sort_args): Check for size-calculation overflow.
4476 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4478 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4480 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4481 (x_set_scroll_bar_width, x_figure_window_size):
4482 Check for integer overflow.
4483 (x_set_alpha): Do not assume XINT fits in int.
4485 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4486 This is for the members text_lines, text_cols, total_lines, total_cols,
4487 where the system imposes an 'int' limit.
4489 * fringe.c (Fdefine_fringe_bitmap):
4490 Don't update size until alloc works.
4492 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4493 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4495 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4496 Check for size-calculation overflow.
4497 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4498 do, as we prefer signed integers.
4499 (id_to_widget.max_size, id_to_widget.used)
4500 (xg_store_widget_in_map, xg_remove_widget_from_map)
4501 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4502 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4503 Use and return ptrdiff_t, not int.
4504 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4505 * gtkutil.h: Change prototypes to match the above.
4507 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4508 are duplicate now that they've been promoted to lisp.h.
4509 (x_allocate_bitmap_record, x_alloc_image_color)
4510 (make_image_cache, cache_image, xpm_load):
4511 Don't update size until alloc is done.
4512 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4514 Check for size calculation overflow.
4515 (ct_colors_allocated_max): New constant.
4516 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4519 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4520 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4521 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4522 Use ptrdiff_t, not int, to count maps.
4523 (read_char_minibuf_menu_prompt): Check for overflow in size
4524 calculations. Don't update size until allocation succeeds.
4525 Redo calculations to avoid overflow.
4526 * keyboard.h: Change prototypes to match the above.
4528 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4530 (current_minor_maps): Check for size calculation overflow.
4531 * keymap.h: Change prototypes to match the above.
4533 * lread.c (read1, init_obarray): Don't update size until alloc done.
4535 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4536 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4538 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4539 Now ptrdiff_t, not int.
4540 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4541 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4543 * process.c (Fnetwork_interface_list): Check for overflow
4544 in size calculation.
4546 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4548 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4549 overflow. Don't bother calling xmalloc when xrealloc will do.
4551 * search.c (Freplace_match): Check for size calculation overflow.
4552 (Fset_match_data): Don't assume list lengths fit in 'int'.
4554 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4555 for command line length. Do not attempt to address one before the
4556 beginning of an array, as that's not portable.
4558 * term.c (max_frame_lines): Remove; unused.
4559 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4561 (encode_terminal_code, calculate_costs): Check for size
4562 calculation overflow.
4563 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4564 table lengths and related sizes. Don't update size until alloc
4565 done. Redo calculations to avoid overflow.
4566 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4568 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4569 subtracting pointers.
4570 (gobble_line): Check for overflow more carefully. Don't update size
4573 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4574 Don't update size until alloc done.
4575 Redo size calculations to avoid overflow.
4576 Check for size calculation overflow.
4577 (main) [DEBUG]: Fix typo in invoking tparam1.
4579 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4580 Use ptrdiff_t, not int, for sizes.
4581 (store_mode_line_noprop_char): Don't update size until alloc done.
4583 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4584 Use ptrdiff_t, not int, for sizes.
4585 (Finternal_make_lisp_face, cache_face):
4586 Check for size calculation overflow.
4587 (cache_face): Treat size calculation overflows as if they were
4588 memory exhaustion (the usual treatment), rather than aborting.
4590 * xfns.c (x_encode_text, x_set_name_internal)
4591 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4592 sizes, since they can exceed INT_MAX in size. Check for size
4593 calculation overflow.
4595 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4596 (xg_select): Check for size calculation overflow.
4597 Don't update size until alloc done.
4599 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4600 as sprintf is limited to int lengths.
4602 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4603 (X_LONG_MIN): New macros.
4604 Use them to make the following changes clearer.
4605 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4606 This change doesn't affect the value now, but it may help remind
4607 future maintainers not to raise the value too much later.
4608 (SELECTION_QUANTUM): Remove, replacing with ...
4609 (selection_quantum): ... new function, which avoids overflow.
4611 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4612 assumption that selection length fits in 'int'.
4613 (x_reply_selection_request, x_handle_selection_request)
4614 (x_get_window_property, receive_incremental_selection)
4615 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4616 (lisp_data_to_selection_data, clean_local_selection_data):
4617 Use ptrdiff_t, not int, to record length of selection.
4618 (x_reply_selection_request, x_get_window_property)
4619 (receive_incremental_selection, x_property_data_to_lisp):
4620 Redo calculations to avoid overflow.
4621 (x_reply_selection_request): When sending hint, ceiling it at
4622 X_LONG_MAX rather than relying on wraparound overflow to send
4624 (x_get_window_property, receive_incremental_selection)
4625 (lisp_data_to_selection_data, x_property_data_to_lisp):
4626 Check for size-calculation overflow.
4627 (x_get_window_property, receive_incremental_selection)
4628 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4629 Don't store size until memory allocation succeeds.
4630 (x_get_window_property): Plug memory leak on memory exhaustion.
4631 Don't double-block input; malloc is safe here. Don't assume 2**34
4632 - 4 fits in unsigned long. Add an xassert to check
4633 XGetWindowProperty overflow. Be more careful about overflow
4634 calculations, and distinguish size from memory overflow better.
4635 (receive_incremental_selection): When tracing, don't assume
4636 unsigned int is less than INT_MAX.
4637 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4638 harmful) conversions of unsigned short to int.
4639 (lisp_data_to_selection_data): Don't assume that integers
4640 in the range -65535 through -1 fit in an X unsigned short.
4641 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4642 result parameters unless successful. Rely on cons_to_unsigned
4643 to report problems with elements; the old code wasn't right anyway.
4644 (x_check_property_data): Check for int overflow; we cannot use
4645 a wider type due to X limits.
4646 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4648 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4650 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4651 (x_term_init): Check for size calculation overflow.
4652 (x_color_cells): Don't store size until memory allocation succeeds.
4653 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4654 Don't assume alloca size is less than MAX_ALLOCA.
4655 (x_term_init): Don't assume length fits in int (sprintf is limited
4658 Use ptrdiff_t for composition IDs.
4659 * character.c (lisp_string_width):
4660 * composite.c (composition_table_size, n_compositions)
4661 (get_composition_id, composition_gstring_from_id):
4662 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4663 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4664 * window.c (Frecenter):
4665 Use ptrdiff_t, not int, for composition IDs.
4666 * composite.c (get_composition_id): Check for integer overflow.
4667 * composite.h: Adjust prototypes to match the above changes.
4669 Use ptrdiff_t for hash table indexes.
4670 * category.c (hash_get_category_set):
4671 * ccl.c (ccl_driver):
4672 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4673 * coding.c (coding_system_charset_list, detect_coding_system):
4674 * coding.h (struct coding_system.id):
4675 * composite.c (get_composition_id, gstring_lookup_cache):
4676 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4677 * image.c (xpm_get_color_table_h):
4678 * lisp.h (hash_lookup, hash_put):
4679 * minibuf.c (Ftest_completion):
4680 Use ptrdiff_t for hash table indexes, not int (which is too
4681 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4682 32-bit --with-wide-int hosts).
4684 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4685 Add a FIXME comment about memory leaks.
4686 (syms_of_charset): Don't assume xmalloc returns.
4688 Don't assume that stated character widths fit in int.
4689 * character.c (Fchar_width, c_string_width, lisp_string_width):
4690 * character.h (CHAR_WIDTH):
4691 * indent.c (MULTIBYTE_BYTES_WIDTH):
4692 Use sanitize_char_width to avoid undefined and/or bad behavior
4693 with outlandish widths.
4694 * character.h (sanitize_tab_width): Rename from sanitize_width,
4695 now that we have two such functions. All uses changed.
4696 (sanitize_char_width): New inline function.
4698 Don't assume that tab-width fits in int.
4699 * character.h (sanitize_width): New inline function.
4700 (SANE_TAB_WIDTH): New macro.
4701 (ASCII_CHAR_WIDTH): Use it.
4702 * indent.c (sane_tab_width): Remove. All uses replaced by
4703 SANE_TAB_WIDTH (current_buffer).
4704 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4706 * fileio.c: Integer overflow issues with file modes.
4707 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4709 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4710 Remove unreachable code.
4711 (read_hex, load_charset_map_from_file): Check for integer overflow.
4713 * xterm.c: Don't go over XClientMessageEvent limit.
4714 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4715 (x_send_scroll_bar_event): Likewise. Check that the size does not
4716 exceed limits imposed by XClientMessageEvent, as well as the usual
4717 ptrdiff_t and size_t limits.
4719 * keyboard.c: Overflow, signedness and related fixes.
4720 (make_lispy_movement): Use same integer type in forward decl
4721 that is used in the definition.
4722 (read_key_sequence, keyremap_step):
4723 Change bufsize argument back to int, undoing my 2011-03-30 change.
4724 We prefer signed types, and int is wide enough here.
4725 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4726 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4727 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4728 length, not size_t. Use ptrdiff_t for index, not int.
4729 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4730 possibility of integer overflow.
4732 Overflow, signedness and related fixes for images.
4734 * dispextern.h (struct it.stack[0].u.image.image_id)
4735 (struct_it.image_id, struct image.id, struct image_cache.size)
4736 (struct image_cache.used, struct image_cache.ref_count):
4737 * gtkutil.c (update_frame_tool_bar):
4738 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4739 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4740 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4741 * nsmenu.m (update_frame_tool_bar):
4742 * xdisp.c (calc_pixel_width_or_height):
4743 * xfns.c (image_cache_refcount):
4744 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4745 on typical 64-bit hosts.
4747 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4748 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4749 Omit unnecessary casts to int.
4750 (parse_image_spec): Check that integers fall into 'int' range
4751 when the callers expect that.
4752 (image_ascent): Redo ascent calculation to avoid int overflow.
4753 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4754 (lookup_image): Remove unnecessary tests.
4755 (xbm_image_p): Locals are now of int, not EMACS_INT,
4756 since parse_image_check makes sure they fit into int.
4757 (png_load, gif_load, svg_load_image):
4758 Prefer int to unsigned where either will do.
4759 (tiff_handler): New function, combining the cores of the
4760 old tiff_error_handler and tiff_warning_handler.
4761 This function is rewritten to use vsnprintf and thereby avoid
4762 stack buffer overflows. It uses only the features of vsnprintf
4763 that are common to both POSIX and native Microsoft.
4764 (tiff_error_handler, tiff_warning_handler): Use it.
4765 (tiff_load, gif_load, imagemagick_load_image):
4766 Don't assume :index value fits in 'int'.
4767 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4768 (imagemagick_load_image): Check that crop parameters fit into
4769 the integer types that MagickCropImage accepts. Don't assume
4770 Vimagemagick_render_type has a nonnegative value. Don't assume
4771 size_t fits in 'long'.
4772 (gs_load): Use printmax_t to print the widest integers possible.
4773 Check for integer overflow when computing image height and width.
4775 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4777 * xdisp.c (redisplay_window): Don't force window start if point
4778 will be invisible in the resulting window. (Bug#9324)
4780 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4782 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4783 the display spec is of the form `(space ...)'.
4784 (handle_display_spec): Return the value returned by
4785 handle_single_display_spec, not just 1 or zero.
4786 (handle_single_display_spec): If the display spec is of the form
4787 `(space ...)', and specifies display in the text area, return 2
4789 (try_cursor_movement): Check for the need to scroll more
4790 accurately, and prefer exact match for point under bidi.
4791 Don't advance `row' beyond the last row of the window.
4793 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4794 into disp_prop; all users changed.
4796 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4797 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4798 for the text covered by the display property.
4800 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4802 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4803 Change return value to nil.
4804 (Frecord_buffer): Delete unused function.
4806 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4808 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4809 buffers, return left-to-right.
4810 (set_cursor_from_row): Consider candidate row a win if its glyph
4811 represents a newline and point is on that newline. Fixes cursor
4812 positioning on the newline at EOL of R2L text within L2R
4813 paragraph, and vice versa.
4814 (try_cursor_movement): Check continued rows, in addition to
4815 continuation rows. Fixes unwarranted scroll when point enters a
4816 continued line of R2L text within an L2R paragraph, or vice versa.
4817 (cursor_row_p): Consider the case of point being equal to
4818 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4819 from the end of a short line to the beginning of a continued line
4820 of R2L text within L2R paragraph.
4821 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4822 composed characters.
4824 * bidi.c (bidi_check_type): Use xassert.
4825 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4828 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4830 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4833 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4835 * nsfont.m (ns_otf_to_script): Fix typo.
4837 2011-08-22 Kenichi Handa <handa@m17n.org>
4839 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4840 extra slot even if the purpose is char-code-property-table.
4842 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4844 * xdisp.c (redisplay_window): When computing centering_position,
4845 account for the height of the header line. (Bug#8874)
4847 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4848 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4849 candidate is selected by the mouse, and that candidate has a
4850 composed character under the mouse.
4852 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4853 coordinates reported by pos-visible-in-window-p for a composed
4854 character in column zero.
4856 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4858 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4860 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4862 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4863 consider it a hit if to_charpos is anywhere in the range of the
4864 composed buffer positions.
4866 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4868 * image.c (gif_load): Don't assume that each subimage has the same
4869 dimensions as the base image. Handle disposal method that is
4870 "undefined" by the gif spec (Bug#9335).
4872 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4874 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4875 (Fcondition_case): Document `debug' symbol in error handler.
4877 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4879 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4880 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4881 from an Org mode buffer to a Speedbar frame.
4883 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4884 a composition, take its buffer position from IT->cmp_it.charpos.
4885 Fixes cursor positioning at the beginning of a line that begins
4886 with a composed character.
4888 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4890 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4891 character bidirectional type, use STRONG_L instead. Fixes crashes
4892 in a buffer produced by `describe-categories'.
4894 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4895 members before the level stack, so they would be saved and
4896 restored when copying iterator state. Fixes incorrect reordering
4897 around TABs covered by display properties.
4899 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4901 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4903 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4905 * eval.c (internal_condition_case, internal_condition_case_1)
4906 (internal_condition_case_2, internal_condition_case_n):
4907 Remove unnecessary aborts (Bug#9081).
4909 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4911 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4912 has no `load' handler, try opening the file locally. (Bug#9311)
4914 2011-08-16 Ken Brown <kbrown@cornell.edu>
4916 * gmalloc.c: Expand comment.
4918 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4920 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4921 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4923 2011-08-16 Ken Brown <kbrown@cornell.edu>
4925 Fix memory allocation problems in Cygwin build (Bug#9273).
4927 * unexcw.c ( __malloc_initialized): Declare external variable.
4928 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4930 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4932 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4934 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4936 [CYGWIN] (special_realloc): New function.
4937 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4938 requests to realloc storage in the static heap.
4940 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4942 * bidi.c (bidi_initialize): Remove unused local.
4944 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4947 * biditype.h: Remove file.
4948 * makefile.w32-in ($(BLD)/bidi.$(O)):
4949 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4951 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4953 * chartab.c: Improve commentary for the uniprop_table API.
4955 * bidi.c (bidi_paragraph_init): Support zero value of
4956 bidi_ignore_explicit_marks_for_paragraph_level.
4957 (bidi_initialize): Use uniprop_table instead of including
4958 biditype.h and bidimirror.h.
4960 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4961 coordinates of the iterator when restoring from ppos_it.
4964 2011-08-14 Kenichi Handa <handa@m17n.org>
4966 * process.c (create_process): Call setup_process_coding_systems
4967 after the pid of the process is set to -1 (Bug#8162).
4969 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4971 * xdisp.c (move_it_in_display_line_to): Don't invoke
4972 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4973 ppos_it. Fixes vertical cursor motion when line beginning is
4974 covered by an image. (Bug#9296)
4976 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4978 * nsterm.h (ns_run_ascript): Declare.
4979 (NSAPP_DATA2_RUNASSCRIPT): Define.
4981 * nsfns.m (as_script, as_result, as_status): New static variables.
4982 (ns_run_ascript): New function.
4983 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4984 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4985 the event loop. Get status from as_status (Bug#7276).
4987 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4988 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4989 the event loop (Bug#7276).
4991 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4993 * gnutls.c (QCgnutls_bootprop_priority)
4994 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4995 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4996 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4997 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4998 (QCgnutls_bootprop_verify_hostname_error)
4999 (QCgnutls_bootprop_callbacks_verify): Rename from
5000 Qgnutls_bootprop_..., all uses changed.
5002 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5005 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5007 * xfaces.c (Qframe_set_background_mode): Now static.
5008 * dispextern.h (Qframe_set_background_mode): Remove decl.
5010 * process.c (Fnetwork_interface_info): Declare local only if needed.
5012 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5014 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5015 (Fnetwork_interface_list): Allocate in increments of bytes instead
5016 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5017 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5019 (struct ifflag_def): notrailers is smart on OSX.
5020 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5021 Get hardware address with getifaddrs if available.
5023 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5025 * xdisp.c (iterate_out_of_display_property): xassert that
5026 IT->position is set to within IT->object's boundaries. Break from
5027 the loop as soon as EOB is reached; avoids infloops in redisplay
5028 when IT->position is set up wrongly due to some bug.
5029 Set IT->current to match the bidi iterator unconditionally.
5030 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5031 entry. Force push_it to save on the stack the current
5032 buffer/string position, to be restored by pop_it. Fix flags in
5033 the iterator structure wrt the object coming from a display
5034 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5035 properties. (Bug#9284)
5037 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5039 * fontset.c (fontset_get_font_group): Add proper type checks.
5042 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5044 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5045 and LC_VERSION_MIN_MACOSX.
5046 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5047 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5049 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5051 * xdisp.c (forward_to_next_line_start): Allow to use the
5052 no-display-properties-and-no-overlays under bidi display.
5053 Set disp_pos in the bidi iterator to avoid searches for display
5054 properties and overlays.
5056 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5058 * editfns.c (Fset_time_zone_rule): Document relationship with the
5061 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5062 the font entity extracted from the cache (Bug#8109).
5064 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5066 * composite.c (autocmp_chars): Don't reset point. That is done by
5067 restore_point_unwind (Bug#5984).
5069 2011-08-07 Juri Linkov <juri@jurta.org>
5071 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5072 to show the arg `TIME' instead of `TIMEVAL'.
5074 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5076 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5077 display property strides EOL and includes a newline, as in
5078 longlines-mode. (Bug#9254)
5079 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5080 word-wrap under bidirectional display. (Bug#9224)
5082 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5083 is non-zero, even if the data buffer is NULL. Fixes a crash in
5084 vertical-motion with longlines-mode. (Bug#9254)
5086 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5088 * bidi.c <bidi_cache_total_alloc>: Now static.
5089 (bidi_initialize): Initialize bidi_cache_total_alloc.
5091 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5094 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5095 amount allocated this far in `bidi_cache_total_alloc'.
5096 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5097 non-zero, only free the data buffer without restoring the cache
5098 contents. All callers changed.
5100 * dispextern.h (bidi_unshelve_cache): Update prototype.
5102 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5103 (move_it_in_display_line, move_it_to)
5104 (move_it_vertically_backward, move_it_by_lines): Replace the call
5105 to xfree to an equivalent call to bidi_unshelve_cache.
5106 (move_it_in_display_line_to): Fix logic of returning
5107 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5109 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5111 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5112 came from a string character with a `cursor' property. (Bug#9229)
5114 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5116 * Makefile.in (LIB_PTHREAD): New variable.
5117 (LIBES): Add LIB_PTHREAD (Bug#9216).
5119 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5120 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5122 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5124 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5126 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5128 * xterm.c (x_find_topmost_parent): New function.
5129 (x_set_frame_alpha): Find topmost parent window with
5130 x_find_topmost_parent and set the property there also (bug#9181).
5131 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5133 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5135 * callproc.c (Fcall_process): Avoid vfork clobbering
5136 the local vars buffer, coding_systems, current_dir.
5138 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5140 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5142 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5144 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5145 so that it is not optimized away.
5147 * xdisp.c (compute_display_string_pos): Remove unused local.
5149 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5151 Fix slow cursor motion and scrolling in large buffers with
5152 selective display, like Org Mode buffers. (Bug#9218)
5154 * dispextern.h (struct bidi_it): New member disp_prop_p.
5156 * xdisp.c: Remove one-slot cache of display string positions.
5157 (compute_display_string_pos): Accept an additional argument
5158 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5159 for a display string or property. If found, set DISP_PROP_P
5162 * bidi.c (bidi_fetch_char): Accept an additional argument
5163 DISP_PROP_P, and pass it to compute_display_string_pos.
5164 Only handle text covered by a display string if DISP_PROP_P is returned
5165 non-zero. All callers of bidi_fetch_char changed.
5167 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5169 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5171 2010-12-03 Don March <don@ohspite.net>
5173 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5174 last character M-[char] is translated to ESC [char] (bug#7541).
5176 2011-08-02 Kenichi Handa <handa@m17n.org>
5178 * lisp.h (uniprop_table): Extern it.
5180 * chartab.c (uniprop_table): Make it non-static.
5182 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5184 * xdisp.c (forward_to_next_line_start): Accept additional argument
5185 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5187 (reseat_at_next_visible_line_start): Use the bidi iterator state
5188 returned by forward_to_next_line_start to restore the state of
5189 it->bidi_it after backing up to previous newline. (Bug#9212)
5191 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5193 * regex.c (re_comp): Protoize.
5194 (re_exec): Fix return type.
5195 (regexec): Fix type of `ret'. (Bug#9203)
5197 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5199 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5200 This is needed if max-image-size is a floating-point number.
5202 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5204 * print.c (print_object): Print empty symbol as ##.
5206 * lread.c (read1): Read ## as empty symbol.
5208 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5210 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5211 setting frame foreground color (Bug#9175).
5212 (x_set_background_color): Likewise.
5214 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5215 contents (Bug#9176).
5216 (EmacsTooltip -init): Remove bezels and add shadows to
5219 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5220 or scroll bar (Bug#8470).
5222 * nsfont.m (nsfont_open): Remove assignment to voffset and
5223 unnecessary vars hshink, expand, hd, full_height, min_height.
5224 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5226 * nsterm.h (nsfont_info): Remove voffset field.
5228 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5230 Implement strike-through and overline on NextStep (Bug#8863).
5232 * nsfont.m (nsfont_open): Use underline position provided by font,
5233 instead of hard-coded value of 2.
5234 (nsfont_draw): Call ns_draw_text_decoration instead.
5236 * nsterm.h: Add declaration for ns_draw_text_decoration.
5238 * nsterm.m (ns_draw_text_decoration): New function for drawing
5239 underline, overline, and strike-through.
5240 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5241 ns_draw_text_decoration. Change treatment of cursor drawing to
5242 accommodate underlining, etc.
5244 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5246 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5249 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5251 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5252 Without this fix, if a signal arrives just after memory fills up,
5253 'malloc' might be invoked reentrantly.
5255 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5256 In other words, assume that every image size is allowed, on non-X
5257 hosts. This assumption is probably wrong, but it lets Emacs compile.
5259 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5261 * regex.c (re_iswctype): Convert return values to boolean.
5263 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5265 * xdisp.c (compute_display_string_pos): Don't use cached display
5266 string position if the buffer had its restriction changed.
5269 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5271 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5273 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5275 Integer signedness and overflow and related fixes. (Bug#9079)
5277 * bidi.c: Integer size and overflow fixes.
5278 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5279 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5280 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5281 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5282 (bidi_find_other_level_edge):
5283 Use ptrdiff_t instead of EMACS_INT where either will do.
5284 This works better on 32-bit hosts configured --with-wide-int.
5285 (bidi_cache_ensure_space): Check for size-calculation overflow.
5286 Use % rather than repeated addition, for better worst-case speed.
5287 Don't set bidi_cache_size until after xrealloc returns, because it
5289 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5290 (bidi_cache_ensure_space): Also check that the bidi cache size
5291 does not exceed that of the largest Lisp string or buffer. See Eli
5292 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5294 * alloc.c (__malloc_size_t): Remove.
5295 All uses replaced by size_t. See Andreas Schwab's note
5296 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5298 * image.c: Improve checking for integer overflow.
5299 (check_image_size): Assume that f is nonnull, since
5300 it is always nonnull in practice. This is one less thing to
5301 worry about when checking for integer overflow later.
5302 (x_check_image_size): New function, which checks for integer
5303 overflow issues inside X.
5304 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5305 This removes the need for a memory_full check.
5306 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5307 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5308 (xbm_read_bitmap_data): Change locals back to 'int', since
5309 their values must fit in 'int'.
5310 (xpm_load_image, png_load, tiff_load):
5311 Invoke x_create_x_image_and_pixmap earlier,
5312 to avoid much needless work if the image is too large.
5313 (tiff_load): Treat overly large images as if
5314 x_create_x_image_and_pixmap failed, not as malloc failures.
5315 (gs_load): Use x_check_image_size.
5317 * gtkutil.c: Omit integer casts.
5318 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5319 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5321 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5323 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5324 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5325 would wrongly return t on a 64-bit host.
5327 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5328 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5329 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5330 and therefore cause GCC to emit a bogus diagnostic in some cases.
5332 * image.c: Integer signedness and overflow and related fixes.
5333 This is not an exhaustive set of fixes, but it's time to
5334 record what I've got.
5335 (lookup_pixel_color, check_image_size): Remove redundant decls.
5336 (check_image_size): Don't assume that arbitrary EMACS_INT values
5337 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5338 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5339 (tiff_load, imagemagick_load_image):
5340 Check for overflow in size calculations.
5341 (x_create_x_image_and_pixmap): Remove unnecessary test for
5342 xmalloc returning NULL; that can't happen.
5343 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5344 (xpm_color_bucket): Use better integer hashing function.
5345 (xpm_cache_color): Don't possibly over-allocate memory.
5346 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5347 (gif_memory_source):
5348 Use ptrdiff_t, not int or size_t, to record sizes.
5349 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5350 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5351 either works, as we prefer signed integers.
5352 (tiff_read_from_memory, tiff_write_from_memory):
5353 Return tsize_t, not size_t, since that's what the TIFF API wants.
5354 (tiff_read_from_memory): Don't fail simply because the read would
5355 go past EOF; instead, return a short read.
5356 (tiff_load): Omit no-longer-needed casts.
5357 (Fimagemagick_types): Don't assume size fits into 'int'.
5359 Improve hashing quality when configured --with-wide-int.
5360 * fns.c (hash_string): New function, taken from sxhash_string.
5361 Do not discard information about ASCII character case; this
5362 discarding is no longer needed.
5363 (sxhash-string): Use it. Change sig to match it. Caller changed.
5364 * lisp.h: Declare it.
5365 * lread.c (hash_string): Remove, since we now use fns.c's version.
5366 The fns.c version returns a wider integer if --with-wide-int is
5367 specified, so this should help the quality of the hashing a bit.
5369 * emacs.c: Integer overflow minor fix.
5370 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5371 Define only if GNU_LINUX.
5372 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5374 * dispnew.c: Integer signedness and overflow fixes.
5375 Remove unnecessary forward decls, that were a maintenance hassle.
5376 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5378 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5379 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5380 (prepare_desired_row, line_draw_cost):
5381 Use int, not unsigned, where either works.
5382 (save_current_matrix, restore_current_matrix):
5383 Use ptrdiff_t, not size_t, where either works.
5384 (init_display): Check for overflow more accurately, and without
5385 relying on undefined behavior.
5387 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5388 Remove, replacing with the new symbols in lisp.h. All uses changed.
5389 * fileio.c (make_temp_name):
5390 * filelock.c (lock_file_1, lock_file):
5391 * xdisp.c (message_dolog):
5392 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5393 Use pMd etc. instead.
5394 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5395 replacing the pWIDE etc. symbols removed from editfns.c.
5397 * keyboard.h (num_input_events): Now uintmax_t.
5398 This is (very slightly) less likely to mess up due to wraparound.
5401 * buffer.c: Integer signedness fixes.
5402 (alloc_buffer_text, enlarge_buffer_text):
5403 Use ptrdiff_t rather than size_t when either will do, as we prefer
5406 * alloc.c: Integer signedness and overflow fixes.
5407 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5408 (__malloc_size_t): Default to size_t, not to int.
5409 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5410 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5411 Prefer ptrdiff_t to size_t when either would do, as we prefer
5413 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5414 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5415 Now const. Initialize with values that are in range even if char
5417 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5418 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5419 These functions do the right thing with sizes > 2**32.
5420 (check_depth): Now ptrdiff_t, not int.
5421 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5422 Adjust to new way of storing sizes. Check for size overflow bugs
5424 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5425 slightly wrong anyway, as it missed one instance of
5426 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5427 (refill_memory_reserve): Omit needless cast to size_t.
5428 (mark_object_loop_halt): Mark as externally visible.
5430 * xselect.c: Integer signedness and overflow fixes.
5431 (Fx_register_dnd_atom, x_handle_dnd_message):
5432 Use ptrdiff_t, not size_t, since we prefer signed.
5433 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5434 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5435 x_dnd_atoms_size and x_dnd_atoms_length.
5437 * doprnt.c: Prefer signed to unsigned when either works.
5439 * doprnt.c (doprnt):
5441 * xdisp.c (vmessage):
5442 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5443 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5444 prefer signed arithmetic to avoid comparison confusion.
5445 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5446 but is a bit tricky.
5448 Assume freestanding C89 headers, string.h, stdlib.h.
5449 * data.c, doprnt.c, floatfns.c, print.c:
5450 Include float.h unconditionally.
5451 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5452 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5453 * regex.c: Likewise for stddef.h, string.h.
5454 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5455 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5456 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5457 (STDC_HEADERS): Remove obsolete defines.
5458 * sysdep.c: Include limits.h unconditionally.
5460 Assume support for memcmp, memcpy, memmove, memset.
5461 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5462 * regex.c (memcmp, memcpy):
5463 Remove; we assume C89 now.
5465 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5466 (__malloc_safe_bcopy): Remove; no longer needed.
5468 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5469 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5470 well either way, and we prefer signed to unsigned.
5472 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5474 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5475 closes the connection while we're reading (bug#9182).
5477 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5479 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5480 are specified (Bug#9168).
5482 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5484 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5485 Found by GCC static checking and --with-wide-int on a 32-bit host.
5487 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5489 * xdisp.c (compute_display_string_pos): Fix logic of caching
5490 previous display string position. Initialize cached_prev_pos to
5491 -1. Fixes slow-down at the beginning of a buffer.
5493 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5495 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5496 for attrs[LFACE_FONTSET_INDEX].
5498 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5500 * xml.c (parse_region): Remove unused local
5501 that was recently introduced.
5503 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5505 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5506 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5508 * xdisp.c (move_it_in_display_line_to): Record the best matching
5509 position for TO_CHARPOS while scanning the line, and restore it on
5510 exit if none of the characters scanned was an exact match.
5511 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5512 when exact match is impossible due to invisible text, and the
5513 lines are truncated.
5515 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5517 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5520 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5522 Fix a significant slow-down of cursor motion with C-n, C-p,
5523 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5524 auto-repeat under bidi redisplay in fontified buffers.
5525 * xdisp.c (compute_stop_pos_backwards): New function.
5526 (next_element_from_buffer): Call compute_stop_pos_backwards to
5527 find a suitable prev_stop when we find ourselves before
5529 (reseat): Don't look for prev_stop, as that could mean a very long
5531 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5532 <cached_disp_overlay_modiff>: Cache for last found display string
5534 (compute_display_string_pos): Return the cached position if asked
5535 about the same buffer in the same area of character positions, and
5536 the buffer wasn't changed since the time the display string
5537 position was cached.
5539 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5541 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5542 is an integer, which is important for empty lines. (Bug#9149)
5544 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5546 * frame.c (Fmodify_frame_parameters): In tty case, update the
5547 default face if necessary (Bug#4238).
5549 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5551 * editfns.c (Fstring_to_char): No need to explain what a character
5552 is in the docstring (Bug#6576).
5554 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5556 * xml.c (parse_region): Make sure we always return a tree.
5558 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5560 * xml.c (parse_region): If a document contains only comments,
5563 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5565 * xml.c (make_dom): Return comments, too.
5567 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5570 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5571 and the surrounding thread.
5572 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5573 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5574 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5576 * s/openbsd.h (BROKEN_SIGIO): Define.
5577 * unexelf.c (unexec) [__OpenBSD__]:
5578 Don't update the .mdebug section of the Alpha COFF symbol table.
5580 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5582 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5585 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5587 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5588 This fixes some race conditions on the permissions of any newly
5591 * alloc.c (valid_pointer_p): Use pipe, not open.
5592 This fixes some permissions issues when debugging.
5594 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5595 If fchown fails to set both uid and gid, try to set just gid,
5596 as that is sometimes allowed. Adjust the file's mode to eliminate
5597 setuid or setgid bits that are inappropriate if fchown fails.
5599 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5601 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5602 to compare Lisp_Objects.
5603 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5604 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5605 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5607 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5609 * lread.c (read_integer): Unread even EOF character.
5610 (read1): Likewise. Properly record start position of symbol.
5612 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5613 symbol character follows.
5615 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5617 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5618 This works around a problem with the previous change to Fcopy_file.
5619 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5620 and without this change, GCC might complain about discarding
5621 fchown's return value.
5623 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5625 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5627 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5629 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5631 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5633 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5634 it's used from the C level.
5636 * process.c: Use the same condition for POLL_FOR_INPUT in both
5637 keyboard.c and process.c (bug#1858).
5639 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5641 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5642 (Fgnutls_boot): Use it.
5644 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5646 * doc.c (Fsubstitute_command_keys): Revert last change.
5648 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5650 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5651 quotes the next character, and doesn't affect other longer
5652 sequences (bug#8935).
5654 * lread.c (syms_of_lread): Clarify that is isn't only
5655 `eval-buffer' and `eval-defun' that's affected by
5656 `lexical-binding' (bug#8460).
5658 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5660 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5661 bidi redisplay when a line includes both an image and is truncated.
5663 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5665 Fix minor problems found by static checking.
5666 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5667 (elsz): Now a signed constant, not a size_t var. We prefer signed
5668 types to unsigned, to avoid integer comparison confusion. Without
5669 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5670 "cannot optimize loop, the loop counter may overflow", a symptom
5672 * indent.c (Fvertical_motion): Mark locals as initialized.
5673 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5675 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5677 * search.c (Fre_search_backward): Mention `case-fold-search' in
5678 all the re_search_* functions (bug#8138).
5680 * keyboard.c (Fopen_dribble_file): Document when the file is
5683 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5685 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5688 Support bidi reordering of display and overlay strings.
5689 * xdisp.c (compute_display_string_pos)
5690 (compute_display_string_end): Accept additional argument STRING.
5691 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5692 (reseat_to_string): Initialize bidi_it->string.s and
5693 bidi_it->string.schars.
5694 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5695 NULL (avoids a crash in bidi_paragraph_init).
5696 Initialize itb.string.lstring.
5697 (init_iterator): Call bidi_init_it only of a valid
5698 buffer position was specified. Initialize paragraph_embedding to
5700 (reseat_to_string): Initialize the bidi iterator.
5701 (display_string): If we need to ignore text properties of
5702 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5703 original value of -1 will not work with bidi.)
5704 (compute_display_string_pos): First arg is now struct
5705 `text_pos *'; all callers changed. Support display properties on
5707 (compute_display_string_end): Support display properties on Lisp
5709 (init_iterator, reseat_1, reseat_to_string): Initialize the
5710 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5711 when iterating on a string not from display properties).
5712 (compute_display_string_pos, compute_display_string_end):
5713 Fix calculation of the object to scan. Fixes an error when using
5715 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5716 base_level_stop; instead, set base_level_stop to BEGV.
5717 Fixes crashes in vertical-motion.
5718 (next_element_from_buffer): Improve commentary for when
5719 the iterator is before prev_stop.
5720 (init_iterator): Initialize bidi_p from the default value of
5721 bidi-display-reordering, not from buffer-local value. Use the
5722 buffer-local value only if initializing for buffer iteration.
5723 (handle_invisible_prop): Support invisible properties on strings
5724 that are being bidi-reordered.
5725 (set_iterator_to_next): Support bidi reordering of C strings and
5727 (next_element_from_string): Support bidi reordering of Lisp
5729 (handle_stop_backwards): Support Lisp strings as well.
5730 (display_string): Support display of R2L glyph rows.
5731 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5732 (init_iterator): Don't initialize it->bidi_p for strings
5734 (reseat_to_string): Initialize it->bidi_p for strings here.
5735 (next_element_from_string, next_element_from_c_string)
5736 (next_element_from_buffer): Add xassert's for correspondence
5737 between IT's object being iterated and it->bidi_it.string
5739 (face_before_or_after_it_pos): Support bidi iteration.
5740 (next_element_from_c_string): Handle the case of the first string
5741 character that is not the first one in the visual order.
5742 (get_visually_first_element): New function, refactored from common
5743 parts of next_element_from_buffer, next_element_from_string, and
5744 next_element_from_c_string.
5745 (tool_bar_lines_needed, redisplay_tool_bar)
5746 (display_menu_bar): Force left-to-right direction. Add a FIXME
5747 comment for making that be controlled by a user option.
5748 (push_it, pop_it): Save and restore the state of the
5749 bidi iterator. Save and restore the bidi_p flag.
5750 (pop_it): Iterate out of display property for string iteration as
5752 (iterate_out_of_display_property): Support iteration over strings.
5753 (handle_single_display_spec): Set up it->bidi_it for iteration
5754 over a display string, and call bidi_init_it.
5755 (handle_single_display_spec, next_overlay_string)
5756 (get_overlay_strings_1, push_display_prop): Set up the bidi
5757 iterator for displaying display or overlay strings.
5758 (forward_to_next_line_start): Don't use the shortcut if
5760 (back_to_previous_visible_line_start): If handle_display_prop
5761 pushed the iterator stack, restore the internal state of the bidi
5762 iterator by calling bidi_pop_it same number of times.
5763 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5764 and we are bidi-iterating, don't decrement the iterator position;
5765 instead, set the first_elt flag in the bidi iterator, to produce
5767 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5768 (push_display_prop): xassert that we are iterating a buffer.
5769 (push_it, pop_it): Save and restore paragraph_embedding member.
5770 (handle_single_display_spec, next_overlay_string)
5771 (get_overlay_strings_1, reseat_1, reseat_to_string)
5772 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5773 correctly. Don't assume unibyte strings are not bidi-reordered.
5774 (compute_display_string_pos)
5775 (compute_display_string_end): Fix handling the case of C string.
5776 (push_it, pop_it): Save and restore from_disp_prop_p.
5777 (handle_single_display_spec, push_display_prop): Set the
5778 from_disp_prop_p flag.
5779 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5780 (pop_it): Call iterate_out_of_display_property only if we are
5781 popping after iteration over a string that came from a display
5782 property. Fix a typo in popping stretch info. Add an assertion
5783 for verifying that the iterator position is in sync with the bidi
5785 (handle_single_display_spec, get_overlay_strings_1)
5786 (push_display_prop): Fix initialization of paragraph direction for
5787 string when that of the parent object is not yet determined.
5788 (reseat_1): Call bidi_init_it to resync the bidi
5789 iterator with IT's position. (Bug#7616)
5790 (find_row_edges): If ROW->start.pos gives position
5791 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5792 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5793 Reset the from_disp_prop_p flag.
5794 (SAVE_IT, RESTORE_IT): New macros.
5795 (pos_visible_p, face_before_or_after_it_pos)
5796 (back_to_previous_visible_line_start)
5797 (move_it_in_display_line_to, move_it_in_display_line)
5798 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5799 (try_scrolling, redisplay_window, display_line): Use them when
5800 saving a temporary copy of the iterator and restoring it back.
5801 (back_to_previous_visible_line_start, reseat_1)
5802 (init_iterator): Empty the bidi cache "stack".
5803 (move_it_in_display_line_to): If iterator ended up at
5804 EOL, but we never saw any buffer positions smaller than
5805 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5806 motion in bidi-reordered lines.
5807 (move_it_in_display_line_to): Record prev_method and prev_pos
5808 immediately before the call to set_iterator_to_next. Fixes cursor
5809 motion in bidi-reordered lines with stretch glyphs and strings
5810 displayed in margins. (Bug#8133) (Bug#8867)
5811 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5813 (pos_visible_p): Support positions in bidi-reordered lines.
5814 Save and restore bidi cache.
5816 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5817 (bidi_paragraph_info): Delete unused struct.
5818 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5819 (bidi_cache_start): New variable.
5820 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5822 (bidi_cache_fetch_state, bidi_cache_search)
5823 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5824 (bidi_cache_find, bidi_peek_at_next_level)
5825 (bidi_level_of_next_char, bidi_find_other_level_edge)
5826 (bidi_move_to_visually_next): Compare cache index with
5827 bidi_cache_start rather than with zero.
5828 (bidi_fetch_char): Accept new argument STRING; all callers
5829 changed. Support iteration over a string. Support strings with
5830 display properties. Support unibyte strings. Fix the type of
5831 `len' according to what STRING_CHAR_AND_LENGTH expects.
5832 (bidi_paragraph_init, bidi_resolve_explicit_1)
5833 (bidi_resolve_explicit, bidi_resolve_weak)
5834 (bidi_level_of_next_char, bidi_move_to_visually_next):
5835 Support iteration over a string.
5836 (bidi_set_sor_type, bidi_resolve_explicit_1)
5837 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5838 can now be zero (for strings); special values 0 and -1 were
5839 changed to -1 and -2, respectively.
5840 (bidi_char_at_pos): New function.
5841 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5842 Call it instead of FETCH_MULTIBYTE_CHAR.
5843 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5844 initialized to valid values.
5845 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5847 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5848 the test for valid cached positions. Fix the logic for looking up
5849 the sentinel state in the cache. GCPRO the Lisp string we are
5851 (bidi_push_it, bidi_pop_it): New functions.
5852 (bidi_initialize): Initialize the bidi cache start stack pointer.
5853 (bidi_cache_ensure_space): New function, refactored from part of
5854 bidi_cache_iterator_state. Don't assume the required size is just
5855 one BIDI_CACHE_CHUNK away.
5856 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5857 (bidi_count_bytes, bidi_char_at_pos): New functions.
5858 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5859 always valid if bidi_cache_idx is valid.
5860 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5861 is valid if it's going to be used.
5862 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5863 (bidi_cache_fetch_state, bidi_cache_search)
5864 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5865 (bidi_cache_iterator_state, bidi_cache_find)
5866 (bidi_find_other_level_edge, bidi_cache_start_stack):
5867 All variables related to cache indices are now EMACS_INT.
5869 * dispextern.h (struct bidi_string_data): New structure.
5870 (struct bidi_it): New member `string'. Make flag members be 1-bit
5871 fields, and put them last in the struct.
5872 (compute_display_string_pos, compute_display_string_end):
5874 (bidi_push_it, bidi_pop_it): Add prototypes.
5875 (struct iterator_stack_entry): New members bidi_p,
5876 paragraph_embedding, and from_disp_prop_p.
5877 (struct it): Member bidi_p is now a bit field 1 bit wide.
5878 (bidi_shelve_cache, bidi_unshelve_cache):
5881 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5882 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5883 and vector-like objects.
5885 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5886 cache around display iteration.
5888 * window.c (Fwindow_end, window_scroll_pixel_based)
5889 (displayed_window_lines, Frecenter): Save and restore the bidi
5890 cache around display iteration.
5892 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5894 * editfns.c (Fdelete_region): Clarify the use of the named
5895 parameters (bug#6788).
5897 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5899 * indent.c (Fvertical_motion): Set and restore w->pointm when
5900 saving and restoring the window's buffer (Bug#9006).
5902 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5904 * editfns.c (Fstring_to_char): Clarify just what is returned
5905 (bug#6576). Text by Eli Zaretskii.
5907 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5909 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5911 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5913 * buffer.c (mmap_find): Fix a typo.
5915 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5917 Fix execution of x selection hooks.
5918 * xselect.c (Qx_lost_selection_functions)
5919 (Qx_sent_selection_functions): New vars.
5920 (syms_of_xselect): DEFSYM them.
5921 (x_handle_selection_request): Pass Qx_sent_selection_functions
5922 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5923 (x_handle_selection_clear,x_clear_frame_selections):
5924 Pass Qx_lost_selection_functions rather than
5925 Vx_lost_selection_functions to Frun_hook_with_args.
5927 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5929 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5930 The old code sometimes used this field without initializing it.
5932 * alloc.c (gc_sweep): Don't read past end of array.
5933 In theory, the old code could also have corrupted Emacs internals,
5934 though it'd be very unlikely.
5936 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5938 * character.c (Fcharacterp): Don't advertise optional ignored
5939 argument. (Bug#4026)
5941 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5943 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5946 * window.c (Fset_window_start): Doc fix (bug#4199).
5947 (Fset_window_hscroll): Ditto.
5949 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5951 Fix minor new problems caught by GCC 4.6.1.
5952 * term.c (init_tty): Remove unused local.
5953 * xsettings.c (store_monospaced_changed): Define this function only
5954 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5957 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5959 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5961 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5963 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5964 are the mini-buffer and the echo area (bug#3320).
5966 * term.c (init_tty): Remove support for supdup, c10 and perq
5967 terminals, which are no longer supported (bug#1482).
5969 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5971 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5973 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5975 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5976 for non-popups (Bug#3642).
5978 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5980 * alloc.c (reset_malloc_hooks): Protoize.
5981 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5982 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5983 * cm.c (losecursor): Likewise.
5984 * data.c (fmod): Likewise.
5985 * dispnew.c (swap_glyphs_in_rows): Likewise.
5986 * emacs.c (memory_warning_signal): Likewise.
5987 * floatfns.c (float_error): Likewise.
5988 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5989 (otf_open, font_otf_capability, generate_otf_features)
5990 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5992 * image.c (pbm_read_file): Likewise.
5993 * indent.c (string_display_width): Likewise.
5994 * intervals.c (check_for_interval, search_for_interval)
5995 (inc_interval_count, count_intervals, root_interval)
5996 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5997 * lread.c (defalias): Likewise.
5998 * ralloc.c (r_alloc_check): Likewise.
5999 * regex.c (set_image_of_range_1, set_image_of_range)
6000 (regex_grow_registers): Likewise.
6001 * sysdep.c (strerror): Likewise.
6002 * termcap.c (valid_filename_p, tprint, main): Likewise.
6003 * tparam.c (main): Likewise.
6004 * unexhp9k800.c (run_time_remap, save_data_space)
6005 (update_file_ptrs, read_header, write_header, calculate_checksum)
6006 (copy_file, copy_rest, display_header): Likewise.
6007 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6009 * xdisp.c (check_it): Likewise.
6010 * xfaces.c (register_color, unregister_color, unregister_colors):
6012 * xfns.c (print_fontset_result): Likewise.
6013 * xrdb.c (member, fatal, main): Likewise.
6015 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6017 Fix minor problems found by static checking (Bug#9031).
6018 * chartab.c (char_table_set_range, map_sub_char_table):
6019 Remove unused locals.
6020 (uniprop_table): Now static.
6021 * composite.c (_work_char): Remove unused static var.
6023 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6025 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6027 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6029 * gtkutil.c (qttip_cb): Remove code without function.
6031 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6033 * w32.c (pthread_sigmask): New stub.
6035 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6037 Use pthread_sigmask, not sigprocmask (Bug#9010).
6038 sigprocmask is portable only for single-threaded applications, and
6039 Emacs can be multi-threaded when it uses GTK.
6040 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6042 * callproc.c (Fcall_process):
6043 * process.c (create_process):
6044 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6045 Use pthread_sigmask, not sigprocmask.
6047 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6049 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6050 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6053 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6055 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6056 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6057 (xg_hide_tooltip): Fix comment.
6059 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6060 in registerServicesMenuSendTypes.
6061 (validRequestorForSendType): Don't check ns_return_types.
6063 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6066 2011-07-08 Jason Rumney <jasonr@gnu.org>
6068 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6069 SH_SHOW for hidden windows (Bug#5482).
6071 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6072 frame struct members of non-existent frames (Bug#6284).
6074 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6076 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6077 variable firstTime not needed on OSX >= 10.6.
6078 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6079 >= 10.5. Use setKnobProportion, setDoubleValue.
6081 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6082 (MAC_OS_X_VERSION_10_5): Define if not defined.
6083 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6084 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6085 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6087 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6088 cString and lossyCString on OSX >= 10.4
6090 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6091 sizeToFit on OSX >= 10.2.
6093 * nsimage.m (allocInitFromFile): Don't use deprecated method
6094 bestRepresentationForDevice on OSX >= 10.6.
6096 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6099 * emacs.c: Declare unexec_init_emacs_zone.
6101 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6103 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6105 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6106 on svcsMenu (Bug#8842).
6108 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6110 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6112 * nsterm.m (QUTF8_STRING): Declare.
6113 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6114 (validRequestorForSendType): Return type is (id).
6115 Change indexOfObjectIdenticalTo to indexOfObject.
6116 Check if we have local selection before returning self (Bug#8842).
6117 (writeSelectionToPasteboard): Put local selection into paste board
6118 if we have a local selection (Bug#8842).
6119 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6121 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6122 (ns_get_local_selection): Declare.
6124 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6126 * keymap.c (describe_map_tree): Don't insert a double newline at
6127 the end of the buffer (bug#1169) and return whether we inserted
6130 * callint.c (Fcall_interactively): Change "reading args" to
6131 "providing args" to try to clarify what it does (bug#1010).
6133 2011-07-07 Kenichi Handa <handa@m17n.org>
6135 * composite.c (composition_compute_stop_pos): Ignore a static
6136 composition starting before CHARPOS (Bug#8915).
6138 * xdisp.c (handle_composition_prop): Likewise.
6140 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6142 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6145 2011-07-07 Kenichi Handa <handa@m17n.org>
6147 * character.h (unicode_category_t): New enum type.
6149 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6150 (Qchar_code_property_table): New variable.
6151 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6152 (UNIPROP_COMPRESSED_FORM_P): New macros.
6153 (char_table_ascii): Uncompress the compressed values.
6154 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6155 Uncompress the compressed values.
6156 (sub_char_table_ref_and_range): Likewise.
6157 (char_table_ref_and_range): Uncompress the compressed values.
6158 (sub_char_table_set): New arg is_uniprop. Callers changed.
6159 Uncompress the compressed values.
6160 (sub_char_table_set_range): Args changed. Callers changed.
6161 (char_table_set_range): Adjuted for the above change.
6162 (map_sub_char_table): Delete args default_val and parent. Add arg
6163 top. Give decoded values to a Lisp function.
6164 (map_char_table): Adjust for the above change. Give decoded
6165 values to a Lisp function. Gcpro more variables.
6166 (uniprop_table_uncompress)
6167 (uniprop_decode_value_run_length): New functions.
6168 (uniprop_decoder, uniprop_decoder_count): New variables.
6169 (uniprop_get_decoder, uniprop_encode_value_character)
6170 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6172 (uniprop_encoder, uniprop_encoder_count): New variables.
6173 (uniprop_get_encoder, uniprop_table)
6174 (Funicode_property_table_internal, Fget_unicode_property_internal)
6175 (Fput_unicode_property_internal): New functions.
6176 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6177 Sunicode_property_table_internal, Sget_unicode_property_internal,
6178 and Sput_unicode_property_internal. Defvar_lisp
6179 char-code-property-alist.
6181 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6182 Vunicode_category_table.
6184 * font.c (font_range): Adjust for the change of
6185 Vunicode_category_table.
6187 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6189 * m/iris4d.h: Remove file, move contents ...
6190 * s/irix6-5.h: ... here.
6192 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6194 Remove unportable assumption about struct layout (Bug#8884).
6195 * alloc.c (mark_buffer):
6196 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6197 (clone_per_buffer_values): Don't assume that
6198 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6199 This isn't true in general, and it's particularly not true
6200 if Emacs is configured with --with-wide-int.
6201 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6202 New macros, used in the buffer.c change.
6204 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6206 * xsettings.c: Use both GConf and GSettings if both are available.
6207 (store_config_changed_event): Add comment.
6208 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6209 (store_tool_bar_style_changed): New functions.
6210 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6211 (struct xsettings): Move font inside HAVE_XFT.
6212 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6213 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6214 Move inside HAVE_XFT.
6215 (something_changed_gsettingsCB): Rename from something_changedCB.
6216 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6218 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6219 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6220 (something_changed_gconfCB): Rename from something_changedCB.
6221 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6222 (parse_settings): Move check for font inside HAVE_XFT.
6223 (read_settings, apply_xft_settings): Add comment.
6224 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6225 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6226 call store_font_name_changed.
6227 (xft_settings_event): Add comment.
6228 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6229 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6230 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6231 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6232 (xsettings_initialize): Call init_gsettings last.
6233 (xsettings_get_system_font, xsettings_get_system_normal_font):
6236 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6238 Random fixes. E.g., (random) never returned negative values.
6239 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6240 subseconds part to the entropy, as that's a bit more random.
6241 Prefer signed to unsigned, since the signedness doesn't matter and
6242 in general we prefer signed. When given a limit, use a
6243 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6244 latter isn't right if USE_2_TAGS_FOR_INTS.
6245 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6246 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6248 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6250 * textprop.c (text_property_stickiness):
6251 Obey Vtext_property_default_nonsticky.
6252 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6253 * w32fns.c (syms_of_w32fns):
6254 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6256 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6258 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6259 This is more efficient than Ffile_directory_p and avoids a minor race.
6261 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6263 * buffer.c (Foverlay_put): Say what the return value is
6266 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6267 is a directory before asking whether to use the file name
6269 (barf_or_query_if_file_exists): Make the "File is a directory"
6270 error be more correct.
6272 * fns.c (Frequire): Remove the mention of the .gz files, since
6273 that's installation-specific, but keep the mention of
6274 `get-load-suffixes'.
6276 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6278 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6279 Report string overflow if the output is too long.
6281 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6283 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6284 (syms_of_gnutls): Remove duplicate DEFSYM for
6285 Qgnutls_bootprop_verify_hostname_error, an error for
6286 Qgnutls_bootprop_verify_error (which is no longer used).
6288 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6289 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6290 Also (re)move comments that are misplaced or no longer relevant.
6292 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6294 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6296 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6298 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6299 and background color parameters if they have been changed.
6301 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6303 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6305 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6307 * xsettings.c (SYSTEM_FONT): Define only when used.
6308 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6310 * keymap.c (access_keymap_1): Now static.
6312 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6314 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6315 leave any prefix arg for the up event (Bug#1586).
6317 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6319 * lread.c (syms_of_lread): Mention single symbols defined by
6320 `defvar' or `defconst' (bug#7154).
6322 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6323 (Frequire): Mention get-load-suffixes.
6325 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6327 * window.h (window): Remove clone_number slot.
6328 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6330 (make_parent_window, make_window, saved_window)
6331 (Fset_window_configuration, save_window_save): Don't deal with
6333 * buffer.c (Qclone_number): Remove declaration.
6334 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6336 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6338 Add multiple inheritance to keymaps.
6339 * keymap.c (Fmake_composed_keymap): New function.
6340 (Fset_keymap_parent): Simplify.
6341 (fix_submap_inheritance): Remove.
6342 (access_keymap_1): New function extracted from access_keymap to handle
6343 embedded parents and handle lists of maps.
6344 (access_keymap): Use it.
6345 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6346 (Fcopy_keymap): Handle embedded parents.
6347 (Fcommand_remapping, define_as_prefix): Simplify.
6348 (Fkey_binding): Simplify.
6349 (syms_of_keymap): Move minibuffer-local-completion-map,
6350 minibuffer-local-filename-completion-map,
6351 minibuffer-local-must-match-map, and
6352 minibuffer-local-filename-must-match-map to Elisp.
6353 (syms_of_keymap): Defsubr make-composed-keymap.
6354 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6355 (parse_menu_item): Trivial simplification.
6357 2011-07-01 Glenn Morris <rgm@gnu.org>
6359 * Makefile.in (SETTINGS_LIBS): Fix typo.
6361 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6363 * coding.c (Fencode_coding_string): Record the last coding system
6364 used, as the function doc string says (bug#8738).
6366 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6368 * xsettings.c (store_monospaced_changed): Take new font as arg and
6369 check for change against current_mono_font.
6370 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6371 (emacs_settings_constructor, emacs_settings_get_property)
6372 (emacs_settings_set_property, emacs_settings_class_init)
6373 (emacs_settings_init, gsettings_obj): Remove.
6374 (something_changedCB): New function for HAVE_GSETTINGS.
6375 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6376 with value as argument.
6377 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6378 g_settings_new (Bug#8967). Do not create gsettings_obj.
6379 Remove calls to g_settings_bind. Connect something_changedCB to
6382 * xgselect.c: Add defined (HAVE_GSETTINGS).
6383 (xgselect_initialize): Ditto.
6385 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6386 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6389 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6391 * eval.c (struct backtrace): Simplify and port the data structure.
6392 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6393 signed bit field, as this assumption is not portable and it makes
6394 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6395 "char debug_on_exit : 1" as this is not portable either; instead,
6396 use the portable "unsigned int debug_on_exit : 1". Remove unused
6397 member evalargs. Remove obsolete comments about cc bombing out.
6399 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6401 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6402 Let HAVE_GSETTINGS override HAVE_GCONF.
6403 (store_monospaced_changed): New function.
6404 (EMACS_SETTINGS): A new type derived from GObject to handle
6405 GSettings notifications.
6406 (emacs_settings_constructor, emacs_settings_get_property)
6407 (emacs_settings_set_property, emacs_settings_class_init):
6409 (gsettings_client, gsettings_obj): New variables.
6410 (GSETTINGS_SCHEMA): New define.
6411 (something_changedCB): Call store_monospaced_changed.
6412 (init_gsettings): New function.
6413 (xsettings_initialize): Call init_gsettings.
6414 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6417 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6420 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6422 * window.c (resize_root_window, grow_mini_window)
6423 (shrink_mini_window): Rename Qresize_root_window to
6424 Qwindow_resize_root_window and Qresize_root_window_vertically to
6425 Qwindow_resize_root_window_vertically.
6427 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6429 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6431 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6433 * makefile.w32-in: Redesign dependencies so they reflect more
6434 clearly which files are directly included by each source file,
6435 and not through other includes.
6437 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6439 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6440 (sort_overlays, overlay_strings): When an overlay's clone number
6441 matches the window's clone number process the overlay even if
6442 the overlay's window property doesn't match the current window.
6444 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6445 (Fwindow_hchild): Rename to Fwindow_left_child.
6446 (Fwindow_next): Rename to Fwindow_next_sibling.
6447 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6448 (resize_window_check): Rename to window_resize_check.
6449 (resize_window_apply): Rename to window_resize_apply.
6450 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6451 (Fdelete_other_windows_internal, resize_frame_windows)
6452 (Fsplit_window_internal, Fdelete_window_internal)
6453 (grow_mini_window, shrink_mini_window)
6454 (Fresize_mini_window_internal): Fix callers accordingly.
6456 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6458 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6459 (emacs_fixed_set_min_size): Remove.
6460 (emacs_fixed_new): Take frame as argument.
6462 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6463 (_EmacsFixedPrivate): Remove minwidth/height.
6464 Add struct frame *f.
6465 (emacs_fixed_init): Initialize priv->f.
6466 (get_parent_class, emacs_fixed_set_min_size): Remove.
6467 (emacs_fixed_new): Set priv->f to argument.
6468 (emacs_fixed_get_preferred_width)
6469 (emacs_fixed_get_preferred_height): Use min_width/height from
6470 frames size_hint to set minimum and natural (Bug#8919).
6471 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6472 and use min_width/height from frames size_hint to set
6473 min_width/height (Bug#8919).
6475 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6476 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6479 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6481 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6482 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6485 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6487 * process.c (wait_reading_process_output): Bypass select if
6488 waiting for a cell while ignoring keyboard input, and input is
6489 pending. Suggested by Jan Djärv (Bug#8869).
6491 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6493 Use gnulib's dup2 module instead of rolling our own.
6494 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6496 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6498 * dispnew.c (scrolling_window): Before scrolling, turn off a
6499 mouse-highlight in the window being scrolled.
6501 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6503 Move DEFSYM to lisp.h and use everywhere.
6505 * character.h (DEFSYM): Move declaration...
6506 * lisp.h (DEFSYM): ...here.
6512 * w32select.c: Don't include character.h.
6514 * alloc.c (syms_of_alloc):
6515 * buffer.c (syms_of_buffer):
6516 * bytecode.c (syms_of_bytecode):
6517 * callint.c (syms_of_callint):
6518 * casefiddle.c (syms_of_casefiddle):
6519 * casetab.c (init_casetab_once):
6520 * category.c (init_category_once, syms_of_category):
6521 * ccl.c (syms_of_ccl):
6522 * cmds.c (syms_of_cmds):
6523 * composite.c (syms_of_composite):
6524 * dbusbind.c (syms_of_dbusbind):
6525 * dired.c (syms_of_dired):
6526 * dispnew.c (syms_of_display):
6527 * doc.c (syms_of_doc):
6528 * editfns.c (syms_of_editfns):
6529 * emacs.c (syms_of_emacs):
6530 * eval.c (syms_of_eval):
6531 * fileio.c (syms_of_fileio):
6532 * fns.c (syms_of_fns):
6533 * frame.c (syms_of_frame):
6534 * fringe.c (syms_of_fringe):
6535 * insdel.c (syms_of_insdel):
6536 * keymap.c (syms_of_keymap):
6537 * lread.c (init_obarray, syms_of_lread):
6538 * macros.c (syms_of_macros):
6539 * msdos.c (syms_of_msdos):
6540 * print.c (syms_of_print):
6541 * process.c (syms_of_process):
6542 * search.c (syms_of_search):
6543 * sound.c (syms_of_sound):
6544 * syntax.c (init_syntax_once, syms_of_syntax):
6545 * terminal.c (syms_of_terminal):
6546 * textprop.c (syms_of_textprop):
6547 * undo.c (syms_of_undo):
6548 * w32.c (globals_of_w32):
6549 * window.c (syms_of_window):
6550 * xdisp.c (syms_of_xdisp):
6551 * xfaces.c (syms_of_xfaces):
6552 * xfns.c (syms_of_xfns):
6553 * xmenu.c (syms_of_xmenu):
6554 * xsettings.c (syms_of_xsettings):
6555 * xterm.c (syms_of_xterm): Use DEFSYM.
6557 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6559 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6561 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6563 Integer and buffer overflow fixes (Bug#8873).
6565 * print.c (printchar, strout): Check for string overflow.
6566 (PRINTPREPARE, printchar, strout):
6567 Don't set size unless allocation succeeds.
6569 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6570 for sizes. Check for string overflow more accurately.
6571 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6573 * macros.c: Integer and buffer overflow fixes.
6574 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6575 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6576 Use ptrdiff_t, not int, for sizes.
6577 Don't increment bufsize until after realloc succeeds.
6578 Check for size-calculation overflow.
6579 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6581 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6583 * lread.c: Integer overflow fixes.
6584 (read_integer): Radix is now EMACS_INT, not int,
6585 to improve quality of diagnostics for out-of-range radices.
6586 Calculate buffer size correctly for out-of-range radices.
6587 (read1): Check for integer overflow in radices, and in
6588 read-circle numbers.
6589 (read_escape): Avoid int overflow.
6590 (Fload, openp, read_buffer_size, read1)
6591 (substitute_object_recurse, read_vector, read_list, map_obarray):
6592 Use ptrdiff_t, not int, for sizes.
6593 (read1): Use EMACS_INT, not int, for sizes.
6594 Check for size overflow.
6596 * image.c (cache_image): Check for size arithmetic overflow.
6598 * lread.c: Integer overflow issues.
6599 (saved_doc_string_size, saved_doc_string_length)
6600 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6601 Now ptrdiff_t, not int.
6602 (read1): Don't assume doc string length fits in int. Check for
6603 out-of-range doc string lengths.
6604 (read_list): Don't assume file position fits in int.
6605 (read_escape): Check for hex character overflow.
6607 2011-06-22 Leo Liu <sdl.web@gmail.com>
6609 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6610 Move to minibuffer.el.
6612 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6614 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6615 The following patches are for when GLYPH_DEBUG && !XASSERT.
6616 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6617 * dispnew.c (flush_stdout):
6618 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6619 Mark as externally visible.
6620 * dispnew.c (check_window_matrix_pointers): Now static.
6621 * dispnew.c (window_to_frame_vpos):
6622 * xfns.c (unwind_create_frame):
6623 * xterm.c (x_check_font): Remove unused local.
6624 * scroll.c (CHECK_BOUNDS):
6625 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6626 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6627 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6628 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6629 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6631 (debug_method_add): Use va_list and vsprintf rather than relying
6632 on undefined behavior with wrong number of arguments.
6633 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6634 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6635 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6636 since we're not interested in debugging glyphs with old libraries.
6637 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6638 GCC 4.6.0's static checking.
6640 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6642 Integer overflow and signedness fixes (Bug#8873).
6643 A few related buffer overrun fixes, too.
6645 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6647 * dispextern.h (struct face.stipple):
6648 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6649 (x_bitmap_mask, x_allocate_bitmap_record)
6650 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6651 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6652 (x_create_bitmap_from_xpm_data):
6653 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6654 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6656 * xfaces.c (load_pixmap):
6657 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6658 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6659 (.bitmaps_last, struct x_output.icon_bitmap):
6660 Use ptrdiff_t, not int, for bitmap indexes.
6661 (x_allocate_bitmap_record): Check for size overflow.
6662 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6664 Use ptrdiff_t, not int, for overlay counts.
6665 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6666 * editfns.c (overlays_around, get_pos_property):
6667 * textprop.c (get_char_property_and_overlay):
6668 * xdisp.c (next_overlay_change, note_mouse_highlight):
6669 * xfaces.c (face_at_buffer_position):
6670 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6671 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6672 (Fnext_overlay_change, Fprevious_overlay_change)
6673 (mouse_face_overlay_overlaps, Foverlays_in):
6674 Use ptrdiff_t, not int, for sizes.
6675 (overlays_at, overlays_in): Check for size-calculation overflow.
6677 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6679 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6680 (x_session_initialize): Do not assume string length fits in int.
6682 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6683 This is unlikely, but can occur if DPI is outlandish.
6685 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6686 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6688 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6689 * xrdb.c (magic_file_p, search_magic_path):
6690 Omit last arg SUFFIX; it was always 0. All callers changed.
6691 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6693 * xfont.c (xfont_match): Avoid need for strlen.
6695 * xfns.c: Don't assume strlen fits in int.
6696 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6698 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6699 not unsigned long, as we prefer signed integers. All callers changed.
6700 Detect integer overflow in repeat count.
6701 (message_dolog): Don't assume print length fits in 39 bytes.
6702 (display_mode_element): Don't assume strlen fits in int.
6704 * termcap.c: Don't assume sizes fit in int and never overflow.
6705 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6706 (gobble_line): Check for size-calculation overflow.
6708 * minibuf.c (Fread_buffer):
6709 * lread.c (intern, intern_c_string):
6710 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6711 Don't assume string length fits in int.
6713 * keyboard.c (parse_tool_bar_item):
6714 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6716 * font.c: Don't assume string length fits in int.
6717 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6718 Use ptrdiff_t, not int.
6719 (font_intern_prop): Don't assume string length fits in int.
6720 Don't assume integer property fits in fixnum.
6721 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6723 * filelock.c: Fix some buffer overrun and integer overflow issues.
6724 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6725 Reformulate so as not to need the command string.
6726 Invoke gzip -cd rather than gunzip, as it's more portable.
6727 (lock_info_type, lock_file_1, lock_file):
6728 Don't assume pid_t and time_t fit in unsigned long.
6729 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6730 (current_lock_owner): Prefer signed type for sizes.
6731 Use memcpy, not strncpy, where memcpy is what is really wanted.
6732 Don't assume (via atoi) that time_t and pid_t fit in int.
6733 Check for time_t and/or pid_t out of range, e.g., via a network share.
6734 Don't alloca where an auto var works fine.
6736 * fileio.c: Fix some integer overflow issues.
6737 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6738 Don't assume string length fits in int.
6739 (directory_file_name): Don't assume string length fits in long.
6740 (make_temp_name): Don't assume pid fits in int, or that its print
6741 length is less than 20.
6743 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6745 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6747 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6749 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6750 We prefer signed integers, even for size calculations.
6752 * emacs.c: Don't assume string length fits in 'int'.
6753 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6754 (main): Don't invoke strlen when not needed.
6756 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6757 (XD_DEBUG_MESSAGE): Don't waste a byte.
6759 * callproc.c (getenv_internal_1, getenv_internal)
6761 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6763 * lread.c (invalid_syntax): Omit length argument.
6764 All uses changed. This doesn't fix a bug, but it simplifies the
6765 code away from its former Hollerith-constant appearance, and it's
6766 one less 'int' to worry about when looking at integer-overflow issues.
6767 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6769 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6770 This didn't break anything, but it didn't help either.
6771 It's confusing to put a bogus integer in a place where the actual
6772 value does not matter.
6773 (LIST_END_P): Remove unused macro and its bogus comment.
6774 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6776 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6777 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6779 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6780 We prefer signed types, and the value cannot exceed the EMACS_INT
6781 range anyway (because otherwise the length would not be representable).
6782 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6783 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6784 This avoids a GCC warning when WIDE_EMACS_INT.
6786 * indent.c (sane_tab_width): New function.
6787 (current_column, scan_for_column, Findent_to, position_indentation)
6788 (compute_motion): Use it. This is just for clarity.
6789 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6791 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6793 * lisp.h (lint_assume): New macro.
6794 * composite.c (composition_gstring_put_cache):
6795 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6797 * editfns.c, insdel.c:
6798 Omit unnecessary forward decls, to simplify future changes.
6800 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6802 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6804 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6805 Use much-faster test for byte-length change.
6806 Don't assume string byte-length fits in 'int'.
6807 Check that character arg fits in 'int'.
6808 (mapcar1): Declare byte as byte, for clarity.
6810 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6812 * fns.c (concat): Catch string overflow earlier.
6813 Do not rely on integer wraparound.
6815 * dispextern.h (struct it.overlay_strings_charpos)
6816 (struct it.selective): Now EMACS_INT, not int.
6817 * xdisp.c (forward_to_next_line_start)
6818 (back_to_previous_visible_line_start)
6819 (reseat_at_next_visible_line_start, next_element_from_buffer):
6820 Don't arbitrarily truncate the value of 'selective' to int.
6822 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6824 * composite.c: Don't truncate sizes to 'int'.
6825 (composition_gstring_p, composition_reseat_it)
6826 (composition_adjust_point): Use EMACS_INT, not int.
6827 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6828 not EMACS_UINT, for indexes.
6830 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6832 * buffer.c: Include <verify.h>.
6833 (struct sortvec.priority, struct sortstr.priority):
6834 Now EMACS_INT, not int.
6835 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6836 (struct sortstr.size, record_overlay_string)
6837 (struct sortstrlist.size, struct sortlist.used):
6838 Don't truncate size to int.
6839 (record_overlay_string): Check for size-calculation overflow.
6840 (init_buffer_once): Check at compile-time, not run-time.
6842 2011-06-22 Jim Meyering <meyering@redhat.com>
6844 Don't leak an XBM-image-sized buffer
6845 * image.c (xbm_load): Free the image buffer after using it.
6847 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6850 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6851 that Sun C diagnosed.
6852 * fns.c (secure_hash): Fix pointer signedness issue.
6853 * intervals.c (static_offset_intervals): New function.
6854 (offset_intervals): Use it.
6856 2011-06-21 Leo Liu <sdl.web@gmail.com>
6859 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6862 * fns.c (secure_hash): Rename from crypto_hash_function and change
6863 the first arg to accept symbols.
6864 (Fsecure_hash): New primitive.
6865 (syms_of_fns): New symbols.
6867 2011-06-20 Deniz Dogan <deniz@dogan.se>
6869 * process.c (Fset_process_buffer): Clarify return value in
6872 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6874 * dispnew.c (add_window_display_history): Use BVAR.
6876 * xdisp.c (debug_method_add): Use BVAR.
6877 (check_window_end, dump_glyph_matrix, dump_glyph)
6878 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6880 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6883 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6884 check till after the cache is created in init_frame_faces.
6886 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6888 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6890 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6892 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6893 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6894 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6896 Improve buffer-overflow checking (Bug#8873).
6897 * fileio.c (Finsert_file_contents):
6898 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6899 Remove the old (too-loose) buffer overflow checks.
6900 They weren't needed, since make_gap checks for buffer overflow.
6901 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6902 The old code merely checked for Emacs fixnum overflow, and relied
6903 on undefined (wraparound) behavior. The new code avoids undefined
6904 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6906 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6907 Tune. Don't use wider integers than needed. Don't use alloca.
6908 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6910 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6912 * insdel.c, lisp.h (buffer_overflow): New function.
6913 (insert_from_buffer_1, replace_range, replace_range_2):
6914 * insdel.c (make_gap_larger):
6915 * editfns.c (Finsert_char):
6916 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6918 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6920 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6922 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6924 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6925 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6927 * fileio.c: Don't assume EMACS_INT fits in off_t.
6928 (emacs_lseek): New static function.
6929 (Finsert_file_contents, Fwrite_region): Use it.
6930 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6932 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6934 * fns.c: Don't overflow int when computing a list length.
6935 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6936 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6937 truncation on 64-bit hosts. Check for QUIT every
6938 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6939 faster and is responsive enough.
6940 (Flength): Report an error instead of overflowing an integer.
6941 (Fsafe_length): Return a float if the value is not representable
6942 as a fixnum. This shouldn't happen except in contrived situations.
6943 (Fnthcdr, Fsort): Don't assume list length fits in int.
6944 (Fcopy_sequence): Don't assume vector length fits in int.
6946 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6947 (header_size, word_size): New constants.
6948 (allocate_vectorlike): Don't check size overflow here.
6949 (allocate_vector): Check it here instead, since this is the only
6950 caller of allocate_vectorlike that could cause overflow.
6951 Check that the new vector's length is representable as a fixnum.
6953 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6954 The previous code was bogus. For example, next_almost_prime (32)
6955 returned 39, which is undesirable as it is a multiple of 3; and
6956 next_almost_prime (24) returned 25, which is a multiple of 5 so
6957 why was the code bothering to check for multiples of 7?
6959 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6961 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6963 Variadic C functions now count arguments with ptrdiff_t.
6964 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6965 Back then I didn't know that the Emacs coding style prefers signed int.
6966 Also, in the meantime I found a few more instances where arguments
6967 were being counted with int, which may truncate counts on 64-bit
6968 machines, or EMACS_INT, which may be unnecessarily wide.
6969 * lisp.h (struct Lisp_Subr.function.aMANY)
6970 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6971 Arg counts are now ptrdiff_t, not size_t.
6972 All variadic functions and their callers changed accordingly.
6973 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6974 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6975 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6976 * callint.c (Fcall_interactively): Check arg count for overflow,
6977 to avoid potential buffer overrun. Use signed char, not 'int',
6978 for 'varies' array, so that we needn't bother to check its size
6979 calculation for overflow.
6980 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6981 * eval.c (apply_lambda):
6982 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6983 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6984 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6986 * callint.c (Fcall_interactively): Don't use index var as event count.
6988 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6989 * mem-limits.h (SIZE): Remove; no longer used.
6991 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6993 Remove unnecessary casts.
6994 * xterm.c (x_term_init):
6995 * xfns.c (x_set_border_pixel):
6996 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6997 These aren't needed now that we assume ANSI C.
6999 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7000 It's more likely to cause problems (due to unsigned overflow)
7003 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7005 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7007 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7009 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7011 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7013 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7015 GLYPH_CODE_FACE returns EMACS_INT, not int.
7016 * dispextern.h (merge_faces):
7017 * xfaces.c (merge_faces):
7018 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7019 Don't assume EMACS_INT fits in int.
7021 * character.h (CHAR_VALID_P): Remove unused parameter.
7022 * fontset.c, lisp.h, xdisp.c: All uses changed.
7024 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7026 * fns.c (concat): Minor tuning based on overflow analysis.
7027 This doesn't fix any bugs. Use int to hold character, instead
7028 of constantly refetching from Emacs object. Use XFASTINT, not
7029 XINT, for value known to be a character. Don't bother comparing
7030 a single byte to 0400, as it's always less.
7032 * floatfns.c (Fexpt):
7033 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7035 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7038 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7040 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7041 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7042 incorrectly succeed when S was a string, because 4294967386 was
7043 truncated before it was used.
7045 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7046 Otherwise, an out-of-range integer could cause undefined behavior
7049 * composite.c: Use int, not EMACS_INT, for characters.
7050 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7051 EMACS_INT, for values that are known to be in character range.
7052 This doesn't fix any bugs but is the usual style inside Emacs and
7053 may generate better code on 32-bit machines.
7055 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7056 This is for reasons similar to the recent CHAR_STRING fix.
7057 * charset.c (Fencode_char): Check that character arg is actually
7058 a character. Pass an int to ENCODE_CHAR.
7059 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7060 wider than 'int', as a compile-time check to prevent future regressions
7063 * character.c (char_string): Remove unnecessary casts.
7065 Make sure a 64-bit char is never passed to CHAR_STRING.
7066 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7067 by silently ignoring the top 32 bits, allowing some values
7068 that were far too large to be valid characters.
7069 * character.h: Include <verify.h>.
7070 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7071 arguments are no wider than unsigned, as a compile-time check
7072 to prevent future regressions in this area.
7074 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7075 (Fsubst_char_in_region):
7077 * xdisp.c (decode_mode_spec_coding):
7078 Adjust to CHAR_STRING's new requirement.
7079 * editfns.c (Finsert_char, Fsubst_char_in_region):
7080 * fns.c (concat): Check that character args are actually
7081 characters. Without this test, these functions did the wrong
7082 thing with wildly out-of-range values on 64-bit hosts.
7084 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7085 These casts should not be needed on 32-bit hosts, either.
7086 * keyboard.c (read_char):
7087 * lread.c (Fload): Remove casts to unsigned.
7089 * lisp.h (UNSIGNED_CMP): New macro.
7090 This fixes comparison bugs on 64-bit hosts.
7091 (ASCII_CHAR_P): Use it.
7092 * casefiddle.c (casify_object):
7093 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7094 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7095 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7096 * dispextern.h (FACE_FROM_ID):
7097 * keyboard.c (read_char): Use UNSIGNED_CMP.
7099 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7100 not to EMACS_INT, to avoid GCC warning.
7102 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7104 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7105 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7106 isn't needed on 32-bit machines.
7108 * buffer.c (Fgenerate_new_buffer_name):
7109 Use EMACS_INT for count, not int.
7110 (advance_to_char_boundary): Return EMACS_INT, not int.
7112 * data.c (Qcompiled_function): Now static.
7114 * window.c (window_body_lines): Now static.
7116 * image.c (gif_load): Rename local to avoid shadowing.
7118 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7119 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7120 * alloc.c (make_save_value): Integer argument is now of type
7122 (mark_object): Use ptrdiff_t, not int.
7123 * lisp.h (pD): New macro.
7124 * print.c (print_object): Use it.
7126 * alloc.c: Use EMACS_INT, not int, to count objects.
7127 (total_conses, total_markers, total_symbols, total_vector_size)
7128 (total_free_conses, total_free_markers, total_free_symbols)
7129 (total_free_floats, total_floats, total_free_intervals)
7130 (total_intervals, total_strings, total_free_strings):
7131 Now EMACS_INT, not int. All uses changed.
7132 (Fgarbage_collect): Compute overall total using a double, so that
7133 integer overflow is less likely to be a problem. Check for overflow
7134 when converting back to an integer.
7135 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7136 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7137 These were 'int' variables that could overflow on 64-bit hosts;
7138 they were never used, so remove them instead of repairing them.
7139 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7140 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7141 Previously, this ceilinged at INT_MAX, but that doesn't work on
7143 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7145 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7146 (allocate_vectorlike): Check for ptrdiff_t overflow.
7147 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7148 when a (possibly-narrower) signed value would do just as well.
7149 We prefer using signed arithmetic, to avoid comparison confusion.
7151 * alloc.c: Catch some string size overflows that we were missing.
7152 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7153 for convenience in STRING_BYTES_MAX.
7154 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7155 The definition here is exact; the one in lisp.h was approximate.
7156 (allocate_string_data): Check for string overflow. This catches
7157 some instances we weren't catching before. Also, it catches
7158 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7159 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7160 and ptrdiff_t and EMACS_INT are both 64 bits.
7162 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7163 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7164 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7166 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7168 * alloc.c (Fmake_string): Check for out-of-range init.
7170 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7172 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7174 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7176 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7177 xg_get_default_scrollbar_width.
7179 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7180 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7181 (style_changed_cb): Call update_theme_scrollbar_width and call
7182 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7183 all frames (Bug#8505).
7184 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7185 Call gtk_window_set_resizable if HAVE_GTK3.
7186 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7187 and height if HAVE_GTK3 (Bug#8505).
7188 (scroll_bar_width_for_theme): New variable.
7189 (update_theme_scrollbar_width): New function.
7190 (xg_get_default_scrollbar_width): Move code to
7191 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7192 (xg_initialize): Call update_theme_scrollbar_width.
7194 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7196 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7198 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7200 * frame.c (make_frame): Call other_buffer_safely instead of
7203 * window.c (temp_output_buffer_show): Call display_buffer with
7204 second argument Vtemp_buffer_show_specifiers and reset latter
7205 immediately after the call.
7206 (Vtemp_buffer_show_specifiers): New variable.
7207 (auto_window_vscroll_p, next_screen_context_lines)
7208 (Vscroll_preserve_screen_position): Remove leading asterisks from
7211 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7213 Fix minor problems found by GCC 4.6.0 static checking.
7214 * buffer.c (Qclone_number): Remove for now, as it's unused.
7215 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7216 (record_buffer): Remove unused local.
7217 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7218 (set_frame_buffer_list): Remove; unused.
7219 * frame.h (other_visible_frames): Remove decl.
7220 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7221 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7222 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7224 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7225 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7226 Define only if HAVE_GPM.
7227 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7228 (update_hints_inhibit): Remove; never set. All uses removed.
7229 * widgetprv.h (emacsFrameClassRec): Remove decl.
7230 * window.c (delete_deletable_window): Now returns void, since it
7231 wasn't returning anything.
7232 (compare_window_configurations): Remove unused locals.
7233 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7234 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7235 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7236 the same widths as pointers. This follows up on the 2011-05-06 patch.
7237 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7238 * xterm.h: Likewise.
7239 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7241 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7243 * makefile.w32-in: Update dependencies.
7244 (LISP_H): Add lib/intprops.h.
7246 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7248 * image.c (gif_load): Add animation frame delay to the metadata.
7249 (syms_of_image): Use DEFSYM. New symbol `delay'.
7251 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7253 * window.c (delete_deletable_window): Re-add.
7254 (Fset_window_configuration): Rewrite to handle dead buffers and
7255 consequently deletable windows.
7256 (window_tree, Fwindow_tree): Remove. Supply functionality in
7258 (compare_window_configurations): Simplify code.
7260 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7262 * image.c (imagemagick_load_image): Fix type mismatch.
7263 (Fimagemagick_types): Likewise.
7265 * window.h (replace_buffer_in_windows): Declare.
7267 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7269 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7270 Qclone_number. Remove external declaration of Qdelete_window.
7271 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7273 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7274 Run Qbuffer_list_update_hook if allowed.
7275 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7276 buffer list implementation.
7277 (other_buffer_safely): New function.
7278 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7279 calls to replace_buffer_in_windows and
7280 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7282 (record_buffer): Inhibit quitting and rewrite using quittable
7283 functions. Run Qbuffer_list_update_hook if allowed.
7284 (Frecord_buffer, Funrecord_buffer): New functions.
7285 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7286 Move switch-to-buffer to window.el.
7287 (bury-buffer): Move to window.el.
7288 (Vbuffer_list_update_hook): New variable.
7290 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7293 * window.h (resize_frame_windows): Move up in code.
7294 (Fwindow_frame): Remove EXFUN.
7295 (replace_buffer_in_all_windows): Remove prototype.
7296 (replace_buffer_in_windows_safely): Add prototype.
7298 * window.c: Declare Qdelete_window static again. Move down
7299 declaration of select_count.
7300 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7301 (Fother_window): Move to window.el.
7302 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7303 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7304 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7306 (replace_buffer_in_windows): Implement by calling
7307 Qreplace_buffer_in_windows.
7308 (replace_buffer_in_all_windows): Remove with some functionality
7309 moved into replace_buffer_in_windows_safely.
7310 (replace_buffer_in_windows_safely): New function.
7311 (select_window_norecord, select_frame_norecord): Move in front
7312 of run_window_configuration_change_hook. Remove now obsolete
7314 (Fset_window_buffer): Rewrite doc-string.
7315 Call Qrecord_window_buffer.
7316 (keys_of_window): Move binding for other-window to window.el.
7318 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7320 * dispextern.h (struct image): Replace data member, whose int_val
7321 and ptr_val fields were not used by anything, with a single
7324 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7325 (gif_clear_image, gif_load, imagemagick_load_image)
7326 (gs_clear_image, gs_load): Callers changed.
7328 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7330 * buffer.h: Include <time.h>, for time_t.
7331 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7333 Fix minor problems found by static checking.
7335 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7337 Make identifiers static if they are not used in other modules.
7338 * data.c (Qcompiled_function, Qframe, Qvector):
7339 * image.c (QimageMagick, Qsvg):
7340 * minibuf.c (Qmetadata):
7341 * window.c (resize_window_check, resize_root_window): Now static.
7342 * window.h (resize_window_check, resize_root_window): Remove decls.
7344 * window.c (window_deletion_count, delete_deletable_window):
7346 (window_body_lines): Now static.
7347 (Fdelete_other_windows_internal): Mark vars as initialized.
7348 Make sure 'resize_failed' is initialized.
7349 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7350 (resize_window_apply): Remove unused local.
7351 * window.h (delete_deletable_window): Remove decl.
7353 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7354 (imagemagick_load_image): Fix pointer signedness problem by changing
7355 last arg from unsigned char * to char *. All uses changed.
7356 Also, fix a local for similar reasons.
7357 Remove unused locals. Remove locals to avoid shadowing.
7358 (fn_rsvg_handle_free): Remove; unused.
7359 (svg_load, svg_load_image): Fix pointer signedness problem.
7360 (imagemagick_load_image): Don't use garbage pointer image_wand.
7362 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7364 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7366 * image.c (gif_load): Fix omitted cast error introduced by
7369 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7371 * window.h (resize_proportionally, orig_total_lines)
7372 (orig_top_line): Remove from window structure.
7373 (set_window_height, set_window_width, change_window_heights)
7374 (Fdelete_window): Remove prototypes.
7375 (resize_frame_windows): Remove duplicate declaration.
7377 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7379 * window.h (resize_frame_windows, resize_window_check)
7380 (delete_deletable_window, resize_root_window)
7381 (resize_frame_windows): Declare prototypes.
7383 * window.c (resize_window_apply): Make definition be "static" to
7384 match the prototype.
7386 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7388 * window.c: Remove declarations of Qwindow_size_fixed,
7389 window_min_size_1, window_min_size_2, window_min_size,
7390 size_window, window_fixed_size_p, enlarge_window, delete_window.
7391 Remove static from declaration of Qdelete_window, it's
7392 temporarily needed by Fbury_buffer.
7393 (replace_window): Don't assign orig_top_line and
7395 (Fdelete_window, delete_window): Remove. Window deletion is
7396 handled by window.el.
7397 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7398 Replace Fdelete_window calls with calls to Qdelete_window.
7399 (Fdelete_other_windows): Remove. Deleting other windows is
7400 handled by window.el.
7401 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7402 handled in window.el.
7403 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7404 Window minimum sizes are handled in window.el.
7405 (shrink_windows, size_window, set_window_height)
7406 (set_window_width, change_window_heights, window_height)
7407 (window_width, CURBEG, CURSIZE, enlarge_window)
7408 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7409 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7410 handled in window.el.
7411 (make_dummy_parent): Rename to make_parent_window and give it a
7412 second argument horflag.
7413 (make_window): Don't set resize_proportionally any more.
7414 (Fsplit_window): Remove. Windows are split in window.el.
7415 (save_restore_action, save_restore_orig_size)
7416 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7417 Resize mini windows in window.el.
7418 (grow_mini_window, shrink_mini_window): Implement by calling
7419 Qresize_root_window_vertically, resize_window_check and
7420 resize_window_apply.
7421 (saved_window, Fset_window_configuration, save_window_save):
7422 Do not handle orig_top_line, orig_total_lines, and
7423 resize_proportionally.
7424 (window_min_height, window_min_width): Move to window.el.
7425 (keys_of_window): Move bindings for delete-other-windows,
7426 split-window, delete-window and enlarge-window to window.el.
7428 * buffer.c: Temporarily extern Qdelete_window.
7429 (Fbury_buffer): Temporarily call Qdelete_window instead of
7430 Fdelete_window (Fbury_buffer will move to window.el soon).
7432 * frame.c (set_menu_bar_lines_1): Remove code handling
7433 orig_top_line and orig_total_lines.
7435 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7436 set_window_height but set heights directly.
7437 (change_frame_size_1): Use resize_frame_windows.
7439 * xdisp.c (init_xdisp): Don't use set_window_height but set
7442 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7443 Use resize_frame_windows instead of change_window_heights and run
7444 run_window_configuration_change_hook.
7446 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7447 instead of change_window_heights and run
7448 run_window_configuration_change_hook.
7450 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7452 * window.c (replace_window): Rename second argument REPLACEMENT to
7453 NEW. New third argument SETFLAG. Rewrite.
7454 (delete_window, make_dummy_parent): Call replace_window with
7456 (window_list_1): Move down in code.
7457 (run_window_configuration_change_hook): Move set_buffer part
7458 before select_frame_norecord part in order to unwind correctly.
7459 Rename count1 to count.
7460 (recombine_windows, delete_deletable_window, resize_root_window)
7461 (Fdelete_other_windows_internal)
7462 (Frun_window_configuration_change_hook, make_parent_window)
7463 (resize_window_check, resize_window_apply, Fresize_window_apply)
7464 (resize_frame_windows, Fsplit_window_internal)
7465 (Fdelete_window_internal, Fresize_mini_window_internal):
7467 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7469 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7471 * window.h (window): Add some new members to window structure -
7472 normal_lines, normal_cols, new_total, new_normal, clone_number,
7473 splits, nest, prev_buffers, next_buffers.
7474 (WINDOW_TOTAL_SIZE): Move here from window.c.
7475 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7477 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7479 (make_dummy_parent): Set new members of windows structure.
7480 (make_window): Move down in code. Handle new members of window
7482 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7483 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7484 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7485 (Fset_window_prev_buffers, Fwindow_next_buffers)
7486 (Fset_window_next_buffers, Fset_window_clone_number):
7488 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7489 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7491 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7492 Argument WINDOW can be now internal window too.
7493 (Fwindow_use_time): Move up in code.
7494 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7496 (Fset_window_configuration, saved_window)
7497 (Fcurrent_window_configuration, save_window_save): Handle new
7498 members of window structure.
7499 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7500 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7501 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7502 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7503 Qget_mru_window, Qresize_root_window,
7504 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7505 Qauto_buffer_name; staticpro them.
7507 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7509 * window.c (Fwindow_total_size, Fwindow_left_column)
7510 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7511 (Fwindow_list_1): New functions.
7512 (window_box_text_cols): Replace with window_body_cols.
7513 (Fwindow_width, Fscroll_left, Fscroll_right):
7514 Use window_body_cols instead of window_box_text_cols.
7515 (delete_window, Fset_window_configuration):
7516 Call delete_all_subwindows with window as argument.
7517 (delete_all_subwindows): Take a window as argument and not a
7519 (window_loop): Remove handling of GET_LRU_WINDOW and
7521 (Fget_lru_window, Fget_largest_window): Move to window.el.
7523 * window.h: Extern window_body_cols instead of
7524 window_box_text_cols. delete_all_subwindows now takes a
7525 Lisp_Object as argument.
7527 * indent.c (compute_motion, Fcompute_motion):
7528 Use window_body_cols instead of window_box_text_cols.
7530 * frame.c (delete_frame): Call delete_all_subwindows with root
7533 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7535 * fns.c (Fputhash): Document return value.
7537 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7539 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7541 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7543 Cons<->int and similar integer overflow fixes (Bug#8794).
7545 Check for overflow when converting integer to cons and back.
7546 * charset.c (Fdefine_charset_internal, Fdecode_char):
7547 Use cons_to_unsigned to catch overflow.
7548 (Fencode_char): Use INTEGER_TO_CONS.
7549 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7550 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7551 * data.c (long_to_cons, cons_to_long): Remove.
7552 (cons_to_unsigned, cons_to_signed): New functions.
7553 These signal an error for invalid or out-of-range values.
7554 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7555 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7556 * font.c (Ffont_variation_glyphs):
7557 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7558 * lisp.h: Include <intprops.h>.
7559 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7560 (cons_to_signed, cons_to_unsigned): New decls.
7561 (long_to_cons, cons_to_long): Remove decls.
7562 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7563 (Fprimitive_undo): Use CONS_TO_INTEGER.
7564 * xfns.c (Fx_window_property): Likewise.
7565 * xselect.c: Include <limits.h>.
7566 (x_own_selection, selection_data_to_lisp_data):
7567 Use INTEGER_TO_CONS.
7568 (x_handle_selection_request, x_handle_selection_clear)
7569 (x_get_foreign_selection, Fx_disown_selection_internal)
7570 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7571 (lisp_data_to_selection_data): Use cons_to_unsigned.
7572 (x_fill_property_data): Use cons_to_signed.
7573 Report values out of range.
7575 Check for buffer and string overflow more precisely.
7576 * buffer.h (BUF_BYTES_MAX): New macro.
7577 * lisp.h (STRING_BYTES_MAX): New macro.
7578 * alloc.c (Fmake_string):
7579 * character.c (string_escape_byte8):
7580 * coding.c (coding_alloc_by_realloc):
7581 * doprnt.c (doprnt):
7582 * editfns.c (Fformat):
7584 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7585 since they may not be the same number.
7586 * editfns.c (Finsert_char):
7587 * fileio.c (Finsert_file_contents):
7588 Likewise for BUF_BYTES_MAX.
7590 * image.c: Use ptrdiff_t, not int, for sizes.
7591 (slurp_file): Switch from int to ptrdiff_t.
7593 (slurp_file): Check that file size fits in both size_t (for
7594 malloc) and ptrdiff_t (for sanity and safety).
7596 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7597 if b->modtime has its maximal value.
7599 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7601 Don't assume time_t can fit into int.
7602 * buffer.h (struct buffer.modtime): Now time_t, not int.
7603 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7604 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7606 Minor fixes for signed vs unsigned integers.
7607 * character.h (MAYBE_UNIFY_CHAR):
7608 * charset.c (maybe_unify_char):
7609 * keyboard.c (read_char, reorder_modifiers):
7610 XINT -> XFASTINT, since the integer must be nonnegative.
7611 * ftfont.c (ftfont_spec_pattern):
7612 * keymap.c (access_keymap, silly_event_symbol_error):
7613 XUINT -> XFASTINT, since the integer must be nonnegative.
7614 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7615 since it makes no difference and we prefer signed.
7616 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7617 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7620 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7622 * window.h (Fwindow_frame): Declare.
7624 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7626 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7627 (SPARE_MEMORY): Always define.
7628 (LARGE_REQUEST): Remove.
7629 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7631 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7633 * lisp.h: Move EXFUNS for Fframe_root_window,
7634 Fframe_first_window and Fset_frame_selected_window to window.h.
7636 * window.h: Move EXFUNS for Fframe_root_window,
7637 Fframe_first_window and Fset_frame_selected_window here from
7640 * frame.c (Fwindow_frame, Fframe_first_window)
7641 (Fframe_root_window, Fframe_selected_window)
7642 (Fset_frame_selected_window): Move to window.c.
7643 (Factive_minibuffer_window): Move to minibuf.c.
7644 (Fother_visible_frames_p): New function.
7646 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7648 * window.c (decode_window, decode_any_window): Move up in code.
7649 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7650 (inhibit_frame_unsplittable): Remove unused variable.
7651 (Fwindow_buffer): Move up and rewrite doc-string.
7652 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7653 (Fwindow_prev): New functions.
7654 (Fwindow_frame): Move here from frame.c. Accept any window as
7656 (Fframe_root_window, Fframe_first_window)
7657 (Fframe_selected_window): Move here from frame.c. Accept frame
7658 or arbitrary window as argument. Update doc-strings.
7659 (Fminibuffer_window): Move up in code.
7660 (Fwindow_minibuffer_p): Move up in code and simplify.
7661 (Fset_frame_selected_window): Move here from frame.c.
7663 (Fselected_window, select_window, Fselect_window): Move up in
7664 code. Minor doc-string fixes.
7666 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7668 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7669 Do not assume that spare memory exists; that assumption is valid
7670 only if SYSTEM_MALLOC.
7671 (LARGE_REQUEST): New macro, so that the issue of large requests
7672 is separated from the issue of spare memory.
7674 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7676 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7679 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7681 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7684 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7686 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7688 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7690 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7691 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7693 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7695 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7697 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7699 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7700 (x_clipboard_manager_save): Add return value.
7701 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7703 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7704 Obey Vx_select_enable_clipboard_manager. Catch errors in
7705 x_clipboard_manager_save (Bug#8779).
7706 (Vx_select_enable_clipboard_manager): New variable.
7707 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7709 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7711 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7713 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7715 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7716 in the current matrix if keep_current_p is non-zero.
7718 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7720 * bidi.c (bidi_level_of_next_char): Fix last change.
7722 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7724 Support bidi reordering of text covered by display properties.
7726 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7727 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7728 (bidi_cache_search, bidi_cache_iterator_state)
7729 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7730 (bidi_level_of_next_char, bidi_move_to_visually_next):
7731 Support character positions inside a run of characters covered by a
7733 (bidi_paragraph_init, bidi_resolve_explicit_1)
7734 (bidi_level_of_next_char): Call bidi_fetch_char and
7735 bidi_fetch_char_advance instead of FETCH_CHAR and
7737 (bidi_init_it): Initialize new members.
7738 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7740 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7741 instead of using explicit *_CHAR codes.
7742 (bidi_resolve_explicit, bidi_resolve_weak):
7743 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7744 bidirectional text is supported only in multibyte buffers.
7745 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7746 it to initialize the frame_window_p member of struct bidi_it.
7747 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7748 (bidi_resolve_explicit, bidi_resolve_weak)
7749 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7750 bidi_it->nchars is non-positive.
7751 (bidi_level_of_next_char): Don't try to lookup the cache for the
7752 next/previous character if nothing is cached there yet, or if we
7753 were just reseat()'ed to a new position.
7755 * xdisp.c (set_cursor_from_row): Set start and stop points
7756 according to the row's direction when priming the loop that looks
7757 for the glyph on which to display cursor.
7758 (single_display_spec_intangible_p): Function deleted.
7759 (display_prop_intangible_p): Reimplement to call
7760 handle_display_spec instead of single_display_spec_intangible_p.
7761 Accept 3 additional arguments needed by handle_display_spec.
7762 This fixes incorrect cursor motion across display property with complex
7763 values: lists, `(when COND...)' forms, etc.
7764 (single_display_spec_string_p): Support property values that are
7765 lists with the argument STRING its top-level element.
7766 (display_prop_string_p): Fix the condition for processing a
7767 property that is a list to be consistent with handle_display_spec.
7768 (handle_display_spec): New function, refactored from the
7769 last portion of handle_display_prop.
7770 (compute_display_string_pos): Accept additional argument
7771 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7772 value of a `display' property is a "replacing spec".
7773 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7774 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7775 the display property, but just return a value indicating whether
7776 the display property will replace the characters it covers.
7777 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7778 frame_window_p members of struct bidi_it.
7779 (compute_display_string_pos, compute_display_string_end):
7781 (push_it): Accept second argument POSITION, where pop_it should
7782 jump to continue iteration.
7783 (reseat_1): Initialize bidi_it.disp_pos.
7785 * keyboard.c (adjust_point_for_property): Adjust the call to
7786 display_prop_intangible_p to its new signature.
7788 * dispextern.h (struct bidi_it): New member frame_window_p.
7789 (bidi_init_it): Update prototypes.
7790 (display_prop_intangible_p): Update prototype.
7791 (compute_display_string_pos, compute_display_string_end):
7793 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7796 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7798 Malloc failure behavior now depends on size of allocation.
7799 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7800 * lisp.h: Change signatures accordingly.
7801 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7802 All callers changed. (Bug#8762)
7804 * gnutls.c: Use Emacs's memory allocators.
7805 Without this change, the gnutls library would invoke malloc etc.
7806 directly, which causes problems on non-SYNC_INPUT hosts, and which
7807 runs afoul of improving memory_full behavior. (Bug#8761)
7808 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7809 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7810 xfree instead of the default malloc, realloc, free.
7811 (Fgnutls_boot): No need to check for memory allocation failure,
7812 since xmalloc does that for us.
7814 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7815 * category.c (hash_get_category_set):
7816 * ccl.c (ccl_driver):
7817 * charset.c (Fdefine_charset_internal):
7818 * charset.h (struct charset.hash_index):
7819 * composite.c (get_composition_id, gstring_lookup_cache)
7820 (composition_gstring_put_cache):
7821 * composite.h (struct composition.hash_index):
7822 * dispextern.h (struct image.hash):
7823 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7824 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7825 (hashfn_equal, hashfn_user_defined, make_hash_table)
7826 (maybe_resize_hash_table, hash_lookup, hash_put)
7827 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7828 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7829 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7830 * image.c (make_image, search_image_cache, lookup_image)
7831 (xpm_put_color_table_h):
7832 * lisp.h (struct Lisp_Hash_Table):
7833 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7834 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7835 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7836 * alloc.c (allocate_vectorlike):
7837 Check for overflow in vector size calculations.
7838 * ccl.c (ccl_driver):
7839 Check for overflow when converting EMACS_INT to int.
7840 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7841 need to be updated by these changes.
7842 * fns.c (make_hash_table, maybe_resize_hash_table):
7843 Check for integer overflow with large hash tables.
7844 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7845 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7846 (SXHASH_REDUCE): New macro.
7847 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7848 Use it instead of discarding useful hash info with large hash values.
7849 (sxhash_float): New function.
7850 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7851 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7852 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7853 Rewrite to use FIXNUM_BITS, as this simplifies things.
7854 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7855 Adjust signatures to match updated version of code.
7856 (consing_since_gc): Now EMACS_INT, since a single hash table can
7857 use more than INT_MAX bytes.
7859 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7861 Make it possible to build with GCC-4.6+ -O2 -flto.
7863 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7865 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7867 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7868 Call minibuffer-inactive-mode.
7870 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7872 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7873 Update dependencies.
7875 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7877 * data.c (init_data): Remove code for UTS, this system is not
7880 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7882 Don't force ./temacs to start in terminal mode.
7884 * frame.c (make_initial_frame): Initialize faces in all cases, not
7885 only when CANNOT_DUMP is defined.
7886 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7888 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7890 * dispnew.c (add_window_display_history): Use const for the string
7891 pointer. Remove declaration, not needed.
7893 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7895 Use 'inline', not 'INLINE'.
7896 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7897 * alloc.c, fontset.c (INLINE): Remove.
7898 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7899 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7900 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7901 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7902 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7904 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7906 Make it possible to run ./temacs.
7908 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7909 syms_of_callproc does the same thing. Remove test for
7910 "initialized", do it in the caller.
7911 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7913 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7915 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7916 (read_minibuf): Use get_minibuffer.
7917 (syms_of_minibuf): Use DEFSYM.
7918 (Qmetadata): New var.
7919 * data.c (Qbuffer): Don't make it static.
7920 (syms_of_data): Use DEFSYM.
7922 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7924 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7925 (CCL_CODE_MIN): New macro.
7927 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7929 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7931 * eval.c (Qdebug): Now static.
7932 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7933 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7934 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7936 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7938 * image.c: Various fixes to ImageMagick code comments.
7939 (Fimagemagick_types): Doc fix.
7941 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7943 Minor fixes prompted by GCC 4.6.0 warnings.
7945 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7947 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7948 (x_clipboard_manager_save_all): Move extern decl to ...
7949 * xterm.h: ... here, so that it can be checked for consistency.
7951 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7953 * xselect.c (x_clipboard_manager_save_frame)
7954 (x_clipboard_manager_save_all): New functions.
7955 (Fx_clipboard_manager_save): Lisp function deleted.
7957 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7958 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7960 * xterm.h: Update prototype.
7962 2011-05-28 William Xu <william.xwl@gmail.com>
7964 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7967 2011-05-28 Jim Meyering <meyering@redhat.com>
7969 Avoid a sign-extension bug in crypto_hash_function.
7970 * fns.c (to_uchar): Define.
7971 (crypto_hash_function): Use it to convert some newly-signed
7972 variables to unsigned, to avoid sign-extension bugs. For example,
7973 without this change, (md5 "truc") would evaluate to
7974 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7975 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7976 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7978 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7980 Integer overflow fixes.
7982 * dbusbind.c: Serial number integer overflow fixes.
7983 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7984 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7985 to hold a serial number that is too large for a fixnum.
7986 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7987 Check for serial numbers out of range. Decode any serial number
7988 that was so large that it became a float. (Bug#8722)
7990 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7991 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7992 Use XFASTINT rather than XUINT when numbers are nonnegative.
7993 (xd_append_arg, Fdbus_method_return_internal):
7994 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7995 arguments, check that Lisp number is nonnegative, rather than
7996 silently wrapping negative numbers around. (Bug#8722)
7997 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8000 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8002 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8004 ccl: Add integer overflow checks.
8005 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8006 (IN_INT_RANGE): New macros.
8007 (ccl_driver): Use them to check for integer overflow when
8008 decoding a CCL program. Many of the new checks are whether XINT (x)
8009 fits in int; it doesn't always, on 64-bit hosts. The new version
8010 doesn't catch all possible integer overflows, but it's an
8011 improvement. (Bug#8719)
8013 * alloc.c (make_event_array): Use XINT, not XUINT.
8014 There's no need for unsigned here.
8016 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8017 This follows up to the 2011-05-06 change that substituted uintptr_t
8018 for EMACS_INT. This case wasn't caught back then.
8020 Rework Fformat to avoid integer overflow issues.
8021 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8022 now (part of C89). Include <verify.h>.
8023 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8024 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8025 (Fformat): Avoid the prepass trying to compute sizes; it was only
8026 approximate and thus did not catch overflow reliably. Instead, walk
8027 through the format just once, formatting and computing sizes as we go,
8028 checking for integer overflow at every step, and allocating a larger
8029 buffer as needed. Keep track separately whether the format is
8030 multibyte. Keep only the most-recently calculated precision, rather
8031 than them all. Record whether each argument has been converted to
8032 string. Use EMACS_INT, not int, for byte and char and arg counts.
8033 Support field widths and precisions larger than INT_MAX. Avoid
8034 sprintf's undefined behavior with conversion specifications such as %#d
8035 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8036 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8037 formatting out-of-range floating point numbers with int
8040 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8042 * data.c: Avoid integer truncation in expressions involving floats.
8043 * data.c: Include <intprops.h>.
8044 (arith_driver): When there's an integer overflow in an expression
8045 involving floating point, convert the integers to floating point
8046 so that the resulting value does not suffer from catastrophic
8047 integer truncation. For example, on a 64-bit host (* 4
8048 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8049 Do not rely on undefined behavior after integer overflow.
8051 merge count_size_as_multibyte, parse_str_to_multibyte
8052 * character.c, character.h (count_size_as_multibyte):
8053 Rename from parse_str_to_multibyte; all uses changed.
8054 Check for integer overflow.
8055 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8056 since it's now a duplicate of the other. This is more of
8057 a character than a buffer op, so better that it's in character.c.
8058 * fns.c, print.c: Adjust to above changes.
8060 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8062 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8064 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8066 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8067 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8068 (x_clipboard_manager_save): Now static.
8069 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8071 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8072 (crypto_hash_function): Now static.
8073 Fix pointer signedness problems. Avoid unnecessary initializations.
8075 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8077 * termhooks.h (Vselection_alist): Make it terminal-local.
8079 * terminal.c (create_terminal): Initialize it.
8081 * xselect.c: Support for clipboard managers.
8082 (Vselection_alist): Move to termhooks.h as terminal-local var.
8083 (LOCAL_SELECTION): New macro.
8084 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8085 (symbol_to_x_atom): Remove gratuitous arg.
8086 (x_handle_selection_request, lisp_data_to_selection_data)
8087 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8088 (x_own_selection, x_get_local_selection, x_convert_selection):
8089 New arg, specifying work frame. Use terminal-local Vselection_alist.
8090 (some_frame_on_display): Delete unused function.
8091 (Fx_own_selection_internal, Fx_get_selection_internal)
8092 (Fx_disown_selection_internal, Fx_selection_owner_p)
8093 (Fx_selection_exists_p): New optional frame arg.
8094 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8095 (x_handle_selection_clear): Don't treat other terminals with the
8096 same keyboard specially. Use the terminal-local Vselection_alist.
8097 (x_clear_frame_selections): Use Frun_hook_with_args.
8099 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8101 * xterm.h: Add support for those atoms.
8103 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8105 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8106 (converted_selections, conversion_fail_tag): New global variables.
8107 (x_selection_request_lisp_error): Free the above.
8108 (x_get_local_selection): Remove unnecessary code.
8109 (x_reply_selection_request): Args changed; handle arbitrary array
8110 of converted selections stored in converted_selections.
8111 Separate the XChangeProperty and SelectionNotify steps.
8112 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8113 (x_convert_selection): New function.
8114 (x_handle_selection_event): Simplify.
8115 (x_get_foreign_selection): Don't ignore incoming requests while
8116 waiting for an answer; this will fail when we implement
8117 SAVE_TARGETS, and seems unnecessary anyway.
8118 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8119 (Vx_sent_selection_functions): Doc fix.
8121 2011-05-26 Leo Liu <sdl.web@gmail.com>
8123 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8125 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8127 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8129 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8130 for fringe update if it has periodic bitmap.
8131 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8132 and fringe_bitmap_periodic_p.
8134 * fringe.c (get_fringe_bitmap_data): New function.
8135 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8136 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8137 row. Mark glyph row for fringe update if periodicity changed.
8139 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8140 for fringe update unless it has periodic bitmap.
8142 2011-05-25 Kenichi Handa <handa@m17n.org>
8144 * xdisp.c (get_next_display_element): Set correct it->face_id for
8145 a static composition.
8147 2011-05-24 Leo Liu <sdl.web@gmail.com>
8150 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8152 * fns.c (crypto_hash_function, Fsha1): New function.
8153 (Fmd5): Use crypto_hash_function.
8154 (syms_of_fns): Add Ssha1.
8156 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8158 * gnutls.c: Remove unused macros.
8159 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8160 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8161 Remove macros that are defined and never used.
8162 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8164 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8166 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8167 (Fx_get_selection_internal): Minor cleanup.
8168 (Fx_own_selection_internal): Rename arguments for consistency with
8171 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8173 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8175 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8177 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8179 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8181 * dispnew.c (scrolling_window): Don't exclude the case that the
8182 last enabled row in the desired matrix touches the bottom boundary.
8184 2011-05-21 Glenn Morris <rgm@gnu.org>
8186 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8187 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8188 and add some more files.
8190 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8192 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8193 report_file_error introduced by the change from 2011-05-07.
8195 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8197 * systime.h (Time): Define only if emacs is defined.
8198 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8199 where the include path doesn't have X11/X.h by default. See
8200 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8202 2011-05-20 Kenichi Handa <handa@m17n.org>
8204 * composite.c (find_automatic_composition): Fix previous change.
8206 2011-05-20 Glenn Morris <rgm@gnu.org>
8208 * lisp.mk: New file, split from Makefile.in.
8209 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8210 (shortlisp): Remove.
8211 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8213 2011-05-19 Glenn Morris <rgm@gnu.org>
8215 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8216 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8217 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8218 (lisp): Set the order to that of loadup.el.
8219 (shortlisp): Make it a copy of $lisp.
8220 (SOME_MACHINE_LISP): Remove.
8221 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8222 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8224 2011-05-18 Kenichi Handa <handa@m17n.org>
8226 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8227 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8228 (find_automatic_composition): Mostly rewrite for efficiency.
8230 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8232 * makefile.w32-in: Update dependencies.
8234 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8236 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8237 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8239 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8241 Fix some integer overflow issues, such as string length overflow.
8243 * insdel.c (count_size_as_multibyte): Check for string overflow.
8245 * character.c (lisp_string_width): Check for string overflow.
8246 Use EMACS_INT, not int, for string indexes and lengths; in
8247 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8248 the resulting string length overflows an EMACS_INT; instead,
8249 report a string overflow if no precision given. When checking for
8250 precision exhaustion, use a check that cannot possibly have
8251 integer overflow. (Bug#8675)
8252 * character.h (lisp_string_width): Adjust to new signature.
8254 * alloc.c (string_overflow): New function.
8255 (Fmake_string): Use it. This doesn't change behavior, but saves
8256 a few bytes and will simplify future changes.
8257 * character.c (string_escape_byte8): Likewise.
8258 * lisp.h (string_overflow): New decl.
8260 Fixups, following up to the user-interface timestamp change.
8261 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8262 for UI timestamps, instead of unsigned long.
8263 * msdos.c (mouse_get_pos): Likewise.
8264 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8265 * w32gui.h (Time): Define by including "systime.h" rather than by
8266 declaring it ourselves. (Bug#8664)
8268 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8269 * image.c (clear_image_cache): Likewise.
8271 * term.c (term_mouse_position): Don't assume time_t wraparound.
8273 Be more systematic about user-interface timestamps.
8274 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8275 and sometimes 'EMACS_UINT', to represent these timestamps.
8276 This change causes it to use 'Time' uniformly, as that's what X uses.
8277 This makes the code easier to follow, and makes it easier to catch
8278 integer overflow bugs such as Bug#8664.
8279 * frame.c (Fmouse_position, Fmouse_pixel_position):
8280 Use Time, not unsigned long, for user-interface timestamps.
8281 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8282 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8283 * keyboard.h (last_event_timestamp): Likewise.
8284 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8285 * menu.h (xmenu_show): Likewise.
8286 * term.c (term_mouse_position): Likewise.
8287 * termhooks.h (struct input_event.timestamp): Likewise.
8288 (struct terminal.mouse_position_hook): Likewise.
8289 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8290 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8291 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8292 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8294 * menu.h, termhooks.h: Include "systime.h", for Time.
8296 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8297 Don't assume that the difference between two unsigned long values
8298 can fit into an integer. At this point, we know button_down_time
8299 <= event->timestamp, so the difference must be nonnegative, so
8300 there's no need to cast the result if double-click-time is
8301 nonnegative, as it should be; check that it's nonnegative, just in
8302 case. This bug is triggered when events are more than 2**31 ms
8303 apart (about 25 days). (Bug#8664)
8305 * xselect.c (last_event_timestamp): Remove duplicate decl.
8306 (x_own_selection): Remove needless cast to unsigned long.
8308 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8309 that always fit in int. Use a sentinel instead of a counter, to
8310 avoid a temp and to allay GCC's concerns about possible int overflow.
8311 * frame.h (struct frame): Use int for menu_bar_items_used
8312 instead of EMACS_INT, since it always fits in int.
8314 * menu.c (grow_menu_items): Check for int overflow.
8316 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8318 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8319 Before, the code was not consistent. These values cannot exceed
8320 2**31 - 1 so there's no need to make them unsigned.
8321 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8322 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8323 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8325 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8327 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8328 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8329 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8330 presumably because the widths might not match.
8332 * window.c (size_window): Avoid needless test at loop start.
8334 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8336 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8338 2011-05-12 Drew Adams <drew.adams@oracle.com>
8340 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8342 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8344 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8345 `width' to `bar_area_x' and `bar_area_width', respectively.
8346 (x_scroll_run): Take account of fringe background extension.
8348 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8349 Rename local vars `left' and `width' to `bar_area_x' and
8350 `bar_area_width', respectively.
8351 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8352 background extension.
8354 2011-05-10 Jim Meyering <meyering@redhat.com>
8356 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8358 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8360 * image.c (Finit_image_library): Return t for built-in image types,
8361 like pbm and xbm. (Bug#8640)
8363 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8365 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8367 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8369 * w32console.c (Fset_screen_color): Doc fix.
8370 (Fget_screen_color): New function.
8371 (syms_of_ntterm): Defsubr it.
8373 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8374 unlink the temporary file if Fcall_process didn't create it in the
8376 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8377 child process will be redirected to a file specified with `:file'.
8378 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8379 cue to call_process_cleanup not to close that handle.
8381 2011-05-07 Ben Key <bkey76@gmail.com>
8383 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8384 one of two shell specific rules, either bootstrap-temacs-CMD or
8385 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8386 to the previous implementation of the bootstrap-temacs rule.
8387 The bootstrap-temacs-CMD rule is similar to the previous
8388 implementation of the bootstrap-temacs rule except that it
8389 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8392 These changes, along with some changes to nt/configure.bat,
8393 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8394 earlier fix to add support for --cflags and --ldflags options
8395 that include quotes so that it works whether make uses cmd or
8398 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8400 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8401 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8403 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8404 a string. Handle both cases.
8405 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8406 (Fdbus_register_method): Use Qinvalid_function.
8408 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8410 * makefile.w32-in: Update dependencies.
8411 (LISP_H): Add inttypes.h and stdin.h.
8412 (PROCESS_H): Add unistd.h.
8414 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8416 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8417 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8419 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8421 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8423 * term.c (vfatal): Remove stray call to va_end.
8424 It's not needed and the C Standard doesn't allow it here anyway.
8426 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8427 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8429 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8432 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8434 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8436 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8438 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8440 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8442 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8443 * charset.c (Fdefine_charset_internal): Don't initialize
8444 charset.code_space[15]. The value was garbage, on hosts with
8445 32-bit int (Bug#8600).
8447 * lread.c (read_integer): Be more consistent with string-to-number.
8448 Use string_to_number to do the actual conversion; this avoids
8449 rounding errors and fixes some other screwups. Without this fix,
8450 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8451 (digit_to_number): Move earlier, for benefit of read_integer.
8452 Return -1 if the digit is out of range for the base, -2 if it is
8453 not a digit in any supported base. (Bug#8602)
8455 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8457 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8458 to match comment at start of function. This also removes a
8459 GCC warning about overflow in a 32+64-bit port.
8461 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8463 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8464 Reported by Stefan Monnier in
8465 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8466 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8467 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8469 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8470 (EMACS_UINTPTR): Likewise, with uintptr_t.
8472 * lisp.h: Prefer 64-bit EMACS_INT if available.
8473 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8474 on 32-bit hosts that have 64-bit int, so that they can access
8476 However, temporarily disable this change unless the temporary
8477 symbol WIDE_EMACS_INT is defined.
8479 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8481 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8482 This removes an assumption that EMACS_INT and long are the same
8483 width as pointers. The assumption is true for Emacs porting targets
8484 now, but we want to make other targets possible.
8485 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8486 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8487 In the rest of the code, change types of integers that hold casted
8488 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8489 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8490 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8491 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8492 No need to cast type when ORing.
8493 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8494 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8495 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8496 assume EMACS_INT is the same width as char *.
8497 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8498 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8499 Remove no-longer-needed casts.
8500 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8501 (xg_tool_bar_help_callback, xg_make_tool_item):
8502 Use EMACS_INTPTR to hold an integer
8503 that will be cast to void *; this can avoid a GCC warning
8504 if EMACS_INT is not the same width as void *.
8505 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8506 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8507 (current_message_1, set_message_1):
8508 Use a local to convert to proper width without a cast.
8509 * xmenu.c (dialog_selection_callback): Likewise.
8511 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8512 Also, don't assume VALBITS / RAND_BITS is less than 5,
8513 and don't rely on undefined behavior when shifting a 1 left into
8515 * lisp.h (get_random): Change signature to match.
8517 * lread.c (hash_string): Use size_t, not int, for hash computation.
8518 Normally we prefer signed values; but hashing is special, because
8519 it's better to use unsigned division on hash table sizes so that
8520 the remainder is nonnegative. Also, size_t is the natural width
8521 for hashing into memory. The previous code used 'int', which doesn't
8522 retain enough info to hash well into very large tables.
8523 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8525 * dbusbind.c: Don't possibly lose pointer info when converting.
8526 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8527 Use XPNTR rather than XHASH, so that the high-order bits of
8528 the pointer aren't lost when converting through void *.
8530 * eval.c (Fautoload): Don't double-shift a pointer.
8532 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8534 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8536 * gnutls.c (DEF_GNUTLS_FN):
8537 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8539 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8541 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8544 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8546 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8547 New version that can reserve upto 2GB of heap space.
8549 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8551 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8553 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8555 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8556 `gnutls_certificate_set_x509_key_file'.
8558 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8560 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8561 Update dependencies.
8563 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8565 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8566 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8567 Remove unused parameter `fildes'.
8568 * process.c (read_process_output, send_process): Don't pass it.
8570 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8572 Fix previous change: the library cache is defined in w32.c.
8573 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8574 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8576 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8578 Implement dynamic loading of GnuTLS on Windows.
8580 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8581 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8582 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8585 * gnutls.c (Qgnutls_dll): Define.
8586 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8587 (gnutls_*): Declare function pointers.
8588 (init_gnutls_functions): New function to initialize function pointers.
8589 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8590 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8591 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8592 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8593 (emacs_gnutls_write, emacs_gnutls_read)
8594 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8595 (Fgnutls_available_p): New function.
8596 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8597 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8598 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8600 * image.c: Include w32.h.
8601 (Vimage_type_cache): Delete.
8602 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8603 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8604 (w32_delayed_load): Move to w32.c.
8606 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8608 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8609 (w32_delayed_load): Move from image.c. When loading a library, record
8610 its filename in the :loaded-from property of the library id.
8611 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8612 Initialize and staticpro them.
8613 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8615 * process.c: Include lisp.h before w32.h, not after.
8616 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8617 instead of gnutls_record_check_pending.
8619 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8621 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8623 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8624 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8627 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8629 * xterm.c (x_set_frame_alpha): Do not set property on anything
8630 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8632 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8634 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8636 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8638 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8639 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8640 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8641 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8642 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8643 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8644 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8645 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8646 (Qgnutls_bootprop_callbacks_verify): Make static.
8648 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8650 * callproc.c: Indentation fixup.
8652 * sysdep.c (wait_for_termination_1): Make static.
8653 (wait_for_termination, interruptible_wait_for_termination):
8654 Move after wait_for_termination_1.
8656 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8658 * sysdep.c (interruptible_wait_for_termination): New function
8659 which is like wait_for_termination, but allows keyboard
8662 * callproc.c (Fcall_process): Add (:file "file") as an option for
8664 (Fcall_process_region): Ditto.
8666 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8668 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8669 rather than `XVECTOR (FOO)->size'.
8671 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8672 inttypes.h, as a gnulib replacement is used if it not available in
8675 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8677 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8678 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8679 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8681 * coding.c (coding_alloc_by_realloc): Error out if destination
8682 will grow beyond MOST_POSITIVE_FIXNUM.
8683 (decode_coding_emacs_mule): Abort if there isn't enough place in
8684 charbuf for the composition carryover bytes. Reserve an extra
8685 space for up to 2 characters produced in a loop.
8686 (decode_coding_iso_2022): Abort if there isn't enough place in
8687 charbuf for the composition carryover bytes.
8689 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8691 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8692 aborting when %lld or %lll format is passed.
8693 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8694 %llo or %llx format is passed. (Bug#8545)
8696 * window.c (window_scroll_line_based): Use a marker instead of
8697 simple variables to record original value of point. (Bug#7952)
8699 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8700 produced by %s or %c overflows available buffer space. (Bug#8545)
8702 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8704 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8705 (SIZE_MAX): Move defn after all includes, as they might #define it.
8707 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8709 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8711 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8713 * keyboard.c (Qdelayed_warnings_hook): Define.
8714 (command_loop_1): Run `delayed-warnings-hook'
8715 if Vdelayed_warnings_list is non-nil.
8716 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8717 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8719 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8721 * doprnt.c (doprnt): Don't return value smaller than the buffer
8722 size if the message was truncated. (Bug#8545).
8724 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8726 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8727 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8729 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8731 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8733 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8735 * makefile.w32-in: Update dependencies.
8737 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8739 Improve `doprnt' and its usage. (Bug#8545)
8740 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8741 `format_end'. Remove support for %l as a conversion specifier.
8742 Don't use xrealloc. Improve diagnostics when the %l size modifier
8743 is used. Update the commentary.
8745 * eval.c (verror): Simplify calculation of size_t.
8747 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8750 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8752 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8755 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8757 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8758 This makes this file independent of the recent pseudovector change.
8760 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8762 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8764 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8765 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8766 Remove unused local.
8767 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8769 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8770 GCC 4.6.0 optimizes based on type-based alias analysis.
8771 For example, if b is of type struct buffer * and v of type struct
8772 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8773 != &v->size, and therefore "v->size = 1; b->size = 2; return
8774 v->size;" must therefore return 1. This assumption is incorrect
8775 for Emacs, since it type-puns struct Lisp_Vector * with many other
8776 types. To fix this problem, this patch adds a new type struct
8777 vectorlike_header that documents the constraints on layout of vectors
8778 and pseudovectors, and helps optimizing compilers not get fooled
8779 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8780 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8781 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8783 (XSETPVECTYPE): Rewrite in terms of new macro.
8784 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8785 This is a bit clearer, and further avoids the possibility of
8786 undesirable aliasing.
8787 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8788 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8789 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8790 since Lisp_Subr is a special case (no "next" field).
8791 (ASIZE): Now uses header.size rather than size.
8792 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8793 to avoid the hassle of writing XVECTOR (foo)->header.size.
8794 (struct vectorlike_header): New type.
8795 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8796 object, to help avoid aliasing.
8797 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8798 (SUBRP): Likewise, since Lisp_Subr is a special case.
8799 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8800 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8801 (struct Lisp_Hash_Table): Combine first two members into a single
8802 struct vectorlike_header member. All uses of "size" and "next" members
8803 changed to be "header.size" and "header.next".
8804 * buffer.h (struct buffer): Likewise.
8805 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8806 * frame.h (struct frame): Likewise.
8807 * process.h (struct Lisp_Process): Likewise.
8808 * termhooks.h (struct terminal): Likewise.
8809 * window.c (struct save_window_data, struct saved_window): Likewise.
8810 * window.h (struct window): Likewise.
8811 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8812 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8813 * buffer.c (init_buffer_once): Likewise.
8814 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8816 * process.c (Fformat_network_address): Use local var for size,
8819 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8821 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8822 * data.c (atof): Remove decl; no longer used or needed.
8823 (digit_to_number): Move to lread.c.
8824 (Fstring_to_number): Use new string_to_number function, to be
8825 consistent with how the Lisp reader treats infinities and NaNs.
8826 Do not assume that floating-point numbers represent EMACS_INT
8827 without losing information; this is not true on most 64-bit hosts.
8828 Avoid double-rounding errors, by insisting on integers when
8829 parsing non-base-10 numbers, as the documentation specifies.
8830 * lisp.h (string_to_number): New decl, replacing ...
8831 (isfloat_string): Remove.
8832 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8833 (read1): Do not accept +. and -. as integers; this
8834 appears to have been a coding error. Similarly, do not accept
8835 strings like +-1e0 as floating point numbers. Do not report
8836 overflow for integer overflows unless the base is not 10 which
8837 means we have no simple and reliable way to continue.
8838 Break out the floating-point parsing into a new
8839 function string_to_number, so that Fstring_to_number parses
8840 floating point numbers consistently with the Lisp reader.
8841 (digit_to_number): Move here from data.c. Make it static inline.
8842 (E_CHAR, EXP_INT): Remove, replacing with ...
8843 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8844 (string_to_number): New function, replacing isfloat_string.
8845 This function checks for valid syntax and produces the resulting
8846 Lisp float number too. Rework it so that string-to-number
8847 no longer mishandles examples like "1.0e+". Use strtoumax,
8848 so that overflow for non-base-10 numbers is reported only when
8849 there's no portable and simple way to convert to floating point.
8851 * textprop.c (set_text_properties_1): Rewrite for clarity,
8852 and to avoid GCC warning about integer overflow.
8854 * intervals.h (struct interval): Use EMACS_INT for members
8855 where EMACS_UINT might cause problems. See
8856 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8857 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8858 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8860 (offset_intervals): Tell GCC not to worry about length overflow
8861 when negating a negative length.
8863 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8864 (overrun_check_free): Likewise.
8866 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8867 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8870 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8871 (gnutls_make_error): Rename local to avoid shadowing.
8872 (gnutls_emacs_global_deinit): ifdef out; not used.
8873 (Fgnutls_boot): Use const for pointer to readonly storage.
8874 Comment out unused local. Fix pointer signedness problems.
8876 * lread.c (openp): Don't stuff size_t into an 'int'.
8877 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8878 about possible signed overflow.
8880 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8881 (GDK_KEY_g): Don't define if already defined.
8882 (xg_prepare_tooltip): Avoid pointer signedness problem.
8883 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8885 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8886 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8888 * xfns.c (Fx_window_property): Simplify a bit,
8889 to make a bit faster and to avoid GCC 4.6.0 warning.
8890 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8892 * fns.c (internal_equal): Don't assume size_t fits in int.
8894 * alloc.c (compact_small_strings): Tighten assertion a little.
8896 Replace pEd with more-general pI, and fix some printf arg casts.
8897 * lisp.h (pI): New macro, generalizing old pEd macro to other
8898 conversion specifiers. For example, use "...%"pI"d..." rather
8899 than "...%"pEd"...".
8900 (pEd): Remove. All uses replaced with similar uses of pI.
8901 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8902 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8903 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8904 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8905 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8906 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8907 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8909 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8910 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8911 * print.c (safe_debug_print, print_object): Likewise.
8912 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8914 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8915 avoiding the 0 flag, which is not portable.
8916 * process.c (Fmake_network_process): Use pI to avoid cast.
8917 * region-cache.c (pp_cache): Likewise.
8918 * xdisp.c (decode_mode_spec): Likewise.
8919 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8920 behavior on 64-bit hosts with printf arg.
8921 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8922 (x_stop_queuing_selection_requests): Likewise.
8923 (x_get_window_property): Don't truncate byte count to an 'int'
8926 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8927 here, since it parses constructs like leading '-' and spaces,
8928 which are not wanted; and it overflows with large numbers.
8929 Instead, simply match F[0-9]+, which is what is wanted anyway.
8931 * alloc.c: Remove unportable assumptions about struct layout.
8932 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8933 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8934 (allocate_vectorlike, make_pure_vector): Use the new macros,
8935 plus offsetof, to remove unportable assumptions about struct layout.
8936 These assumptions hold on all porting targets that I know of, but
8937 they are not guaranteed, they're easy to remove, and removing them
8938 makes further changes easier.
8940 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8941 This doesn't fix a bug but makes the code clearer.
8942 (string_overrun_cookie): Now const. Use initializers that
8943 don't formally overflow signed char, to avoid warnings.
8944 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8945 can cause Emacs to crash when string overrun checking is enabled.
8946 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8947 multiple of sizeof (EMACS_INT); it need not be, if
8948 alignof(EMACS_INT) < sizeof (EMACS_INT).
8949 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8951 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8953 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8955 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8957 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8958 supposed to be handshaking. (Bug#8556)
8959 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8961 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8963 * lisp.h (Qdebug): List symbol.
8964 * eval.c (Qdebug): Restore global linkage.
8965 * keyboard.c (debug-on-event): New variable.
8966 (handle_user_signal): Break into debugger when debug-on-event
8967 matches the current signal symbol.
8969 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8971 * alloc.c (check_sblock, check_string_bytes)
8972 (check_string_free_list): Convert to standard C.
8974 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8976 * w32.c (emacs_gnutls_push): Fix typo.
8978 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8980 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8981 "cast to pointer from integer of different size".
8983 Improve doprnt and its use in verror. (Bug#8545)
8984 * doprnt.c (doprnt): Document the set of format control sequences
8985 supported by the function. Use SAFE_ALLOCA instead of always
8988 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8989 is one byte too soon. Don't use xrealloc; instead xfree and
8992 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8994 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8997 * gnutls.c: Renamed global_initialized to
8998 gnutls_global_initialized. Added internals for the
8999 :verify-hostname-error, :verify-error, and :verify-flags
9000 parameters of `gnutls-boot' and documented those parameters in the
9001 docstring. Start callback support.
9002 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9003 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9004 on error. Return error code.
9005 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9006 (emacs_gnutls_read): Likewise.
9007 (Fgnutls_boot): Return handshake error code.
9008 (emacs_gnutls_handle_error): New function.
9009 (wsaerror_to_errno): Likewise.
9011 * w32.h (emacs_gnutls_pull): Add prototype.
9012 (emacs_gnutls_push): Likewise.
9014 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9015 (emacs_gnutls_push): Likewise.
9017 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9019 * process.c (wait_reading_process_output): Check if GnuTLS
9020 buffered some data internally if no FDs are set for TLS
9023 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9024 (LIBS): Link to USER_LIBS.
9025 ($(BLD)/gnutls.$(0)): New target.
9027 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9029 * xdisp.c (handle_single_display_spec): Rename the
9030 display_replaced_before_p argument into display_replaced_p, to
9031 make it consistent with the commentary. Fix typos in the
9034 * textprop.c (syms_of_textprop): Remove dead code.
9035 (copy_text_properties): Delete obsolete commentary about an
9036 interface that was deleted long ago. Fix typos in the description
9039 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9040 to changes in oldXMenu/XMenu.h from 2011-04-16.
9041 <menu_help_message, prev_menu_help_message>: Constify.
9042 (IT_menu_make_room): menu->help_text is now `const char **';
9045 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9046 to changes in oldXMenu/XMenu.h from 2011-04-16.
9047 (struct XMenu): Declare `help_text' `const char **'.
9049 * xfaces.c <Qunspecified>: Make extern again.
9051 * syntax.c: Include sys/types.h before including regex.h, as
9054 * doc.c (get_doc_string): Improve the format passed to `error'.
9056 * doprnt.c (doprnt): Improve commentary.
9058 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9060 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9063 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9064 changes in globals.h immediately force recompilation.
9065 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9066 $(CURDIR)/s/ms-w32.h.
9067 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9069 * character.c (Fchar_direction): Function deleted.
9070 (syms_of_character): Don't defsubr it.
9071 <char-direction-table>: Deleted.
9073 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9075 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9076 * doprnt.c: Include limits.h.
9077 (SIZE_MAX): New macro.
9078 (doprnt): Return a size_t value. 2nd arg is now size_t.
9079 Many local variables are now size_t instead of int or unsigned.
9080 Improve overflow protection. Support `l' modifier for integer
9081 conversions. Support %l conversion. Don't assume an EMACS_INT
9082 argument for integer conversions and for %c.
9084 * lisp.h (doprnt): Restore prototype.
9086 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9089 * Makefile.in (base_obj): Add back doprnt.o.
9091 * deps.mk (doprnt.o): Add back prerequisites.
9092 (callint.o): Depend on character.h.
9094 * eval.c (internal_lisp_condition_case): Include the handler
9095 representation in the error message.
9096 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9097 when breaking from the loop.
9099 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9101 * callint.c (Fcall_interactively): When displaying error message
9102 about invalid control letter, pass the character's codepoint, not
9103 a pointer to its multibyte form. Improve display of the character
9104 in octal and display also its hex code.
9106 * character.c (char_string): Use %x to display the (unsigned)
9107 codepoint of an invalid character, to avoid displaying a bogus
9110 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9111 `error', not SYMBOL_NAME itself.
9113 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9114 character arguments to `error'.
9116 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9117 to `error' in error message about FINAL_CHAR argument. Make sure
9118 FINAL_CHAR is a character, and use %c when it is passed as
9119 argument to `error'.
9121 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9123 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9125 * w32.c: Include <time.h>.
9126 (sys_localtime): New function.
9128 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9130 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9132 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9134 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9136 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9139 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9141 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9142 gl_state.e_property when gl_state.object is Qt.
9144 * insdel.c (make_gap_larger): Remove limitation of buffer size
9147 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9149 * xdisp.c (lookup_glyphless_char_display)
9150 (produce_glyphless_glyph): Handle cons cell entry in
9151 glyphless-char-display.
9152 (Vglyphless_char_display): Document it.
9154 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9155 glyphless-char-display.
9157 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9159 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9161 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9163 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9164 definition for no-X builds.
9166 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9168 Static checks with GCC 4.6.0 and non-default toolkits.
9170 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9172 * process.c (keyboard_bit_set): Define only if SIGIO.
9173 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9174 (send_process): Repair possible setjmp clobbering.
9176 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9178 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9180 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9182 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9183 Define only if needed.
9185 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9186 by pacifying GCC about it. Maybe it's time to retire it?
9187 * xfaces.c (USG, __TIMEVAL__): Likewise.
9189 * dispextern.h (struct redisplay_interface): Rename param
9191 * termhooks.h (struct terminal): Likewise.
9192 * xterm.c (xembed_send_message): Likewise.
9194 * insdel.c (make_gap_smaller): Define only if
9195 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9197 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9200 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9201 so that we aren't warned about unused symbols.
9203 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9205 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9207 * xfns.c (x_real_positions): Mark locals as initialized.
9209 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9211 * xterm.c: Fix problems found by static analysis with other toolkits.
9212 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9213 (x_dispatch_event): Declare static if USE_GTK, and
9214 define if USE_GTK || USE_X_TOOLKIT.
9215 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9216 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9217 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9218 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9220 * xmenu.c (menu_help_callback): Pointer type fixes.
9221 Use const pointers when pointing at readonly data. Avoid pointer
9223 (FALSE): Remove unused macro.
9224 (update_frame_menubar): Remove unused decl.
9226 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9228 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9229 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9230 (single_menu_item): Rename local to avoid shadowing.
9232 * keyboard.c (make_lispy_event): Remove unused local var.
9234 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9235 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9237 * bitmaps: Change bitmaps from unsigned char back to the X11
9238 compatible char. Avoid the old compiler warnings about
9239 out-of-range initializers by using, for example, '\xab' rather
9242 * xgselect.c (xgselect_initialize): Check vs interface
9243 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9245 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9247 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9248 to read-only memory.
9250 * fns.c (vector): Remove; this old hack is no longer needed.
9252 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9254 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9256 * xrdb.c (x_load_resources): Omit unused local.
9258 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9259 (x_window): Rename locals to avoid shadowing.
9260 (USG): Use the kludged USG macro, to pacify gcc.
9262 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9263 (x_term_init): Remove local to avoid shadowing.
9265 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9267 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9268 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9270 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9272 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9274 Fix regex.c, syntax.c and friends for buffers > 2GB.
9275 * syntax.h (struct gl_state_s): Declare character position members
9278 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9280 * textprop.c (verify_interval_modification, interval_of):
9281 Declare arguments EMACS_INT.
9283 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9286 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9288 * indent.c (Fvertical_motion): Local variable it_start is now
9291 * regex.c (re_match, re_match_2, re_match_2_internal)
9292 (bcmp_translate, regcomp, regexec, print_double_string)
9293 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9294 (re_compile_pattern, re_exec): Declare arguments and local
9295 variables `size_t' and `ssize_t' and return values `regoff_t', as
9297 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9298 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9299 <compile_stack_type>: `size' and `avail' are now `size_t'.
9301 * regex.h <regoff_t>: Use ssize_t, not int.
9302 (re_search, re_search_2, re_match, re_match_2): Arguments that
9303 specify buffer/string position and length are now ssize_t and
9304 size_t. Return type is regoff_t.
9306 2011-04-16 Ben Key <bkey76@gmail.com>
9308 * nsfont.m: Fixed bugs in ns_get_family and
9309 ns_descriptor_to_entity that were caused by using free to
9310 deallocate memory blocks that were allocated by xmalloc (via
9311 xstrdup). This caused Emacs to crash when compiled with
9312 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9313 --enable-checking=xmallocoverrun). xfree is now used to
9314 deallocate these memory blocks.
9316 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9318 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9320 emacs_write: Accept and return EMACS_INT for sizes.
9321 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9323 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9324 Accept and return EMACS_INT.
9325 (emacs_gnutls_write): Return the number of bytes written on
9327 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9328 (emacs_read, emacs_write): Remove check for negative size, as the
9329 Emacs source code has been audited now.
9330 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9331 (emacs_read, emacs_write): Use it.
9332 * process.c (send_process): Adjust to the new signatures of
9333 emacs_write and emacs_gnutls_write. Do not attempt to store
9334 a byte offset into an 'int'; it might overflow.
9335 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9337 * sound.c: Don't assume sizes fit in 'int'.
9338 (struct sound_device.period_size, alsa_period_size):
9339 Return EMACS_INT, not int.
9340 (struct sound_device.write, vox_write, alsa_write):
9341 Accept EMACS_INT, not int.
9342 (wav_play, au_play): Use EMACS_INT to store sizes and to
9343 record read return values.
9345 2011-04-15 Ben Key <bkey76@gmail.com>
9347 * keyboard.c (Qundefined): Don't declare static since it is used
9349 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9350 static since they are used in nsfont.m.
9352 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9354 * process.c (Qprocessp): Don't declare static.
9355 * lisp.h (Qprocessp): Declare again.
9357 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9359 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9361 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9363 Improve C-level modularity by making more things 'static'.
9365 Don't publish debugger-only interfaces to other modules.
9366 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9367 (verify_bytepos, count_markers): Move decls to the only modules
9369 * region-cache.h (pp_cache): Likewise.
9370 * window.h (check_all_windows): Likewise.
9371 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9373 * sysdep.c (croak): Now static, if
9374 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9375 * syssignal.h (croak): Declare only if not static.
9377 * alloc.c (refill_memory_reserve): Now static if
9378 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9379 * lisp.h (refill_memory_reserve): Declare only if not static.
9381 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9382 Define only if USE_LUCID.
9384 * xrdb.c (x_customization_string, x_rm_string): Now static.
9386 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9387 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9389 * xdisp.c (draw_row_with_mouse_face): Now static.
9390 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9392 * window.h (check_all_windows): Mark externally visible.
9394 * window.c (window_deletion_count): Now static.
9396 * undo.c: Make symbols static if they're not exported.
9397 (last_undo_buffer, last_boundary_position, pending_boundary):
9400 * textprop.c (interval_insert_behind_hooks): Now static.
9401 (interval_insert_in_front_hooks): Likewise.
9403 * term.c: Make symbols static if they're not exported.
9404 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9405 (max_frame_lines, tty_set_terminal_modes):
9406 (tty_reset_terminal_modes, tty_turn_off_highlight):
9407 (get_tty_terminal): Now static.
9408 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9409 * termhooks.h (term_mouse_moveto): Do not declare if
9411 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9412 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9414 * sysdep.c: Make symbols static if they're not exported.
9415 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9417 (sigprocmask_set, full_mask): Remove; unused.
9418 (wait_debugging): Mark as visible.
9419 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9420 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9422 * syntax.c (syntax_temp): Define only if !__GNUC__.
9424 * sound.c (current_sound_device, current_sound): Now static.
9426 * search.c (searchbufs, searchbuf_head): Now static.
9428 * scroll.c (scroll_cost): Remove; unused.
9429 * dispextern.h (scroll_cost): Remove decl.
9431 * region-cache.h (pp_cache): Mark as externally visible.
9433 * process.c: Make symbols static if they're not exported.
9434 (process_tick, update_tick, create_process, chan_process):
9435 (Vprocess_alist, proc_buffered_char, datagram_access):
9436 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9437 (deactivate_process): Mark defn as static, as well as decl.
9438 * lisp.h (create_process): Remove decl.
9439 * process.h (chan_process, Vprocess_alist): Remove decls.
9441 * print.c: Make symbols static if they're not exported.
9442 (print_depth, new_backquote_output, being_printed, print_buffer):
9443 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9444 (print_interval, print_number_index, initial_stderr_stream):
9446 * lisp.h (Fprinc): Remove decl.
9447 (debug_output_compilation_hack): Mark as externally visible.
9449 * sysdep.c (croak): Move decl from here to syssignal.h.
9450 * syssignal.h (croak): Put it here, so the API can be checked when
9451 'croak' is called from dissociate_if_controlling_tty.
9453 * minibuf.c: Make symbols static if they're not exported.
9454 (minibuf_save_list, choose_minibuf_frame): Now static.
9455 * lisp.h (choose_minibuf_frame): Remove decl.
9457 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9459 * lread.c: Make symbols static if they're not exported.
9460 (read_objects, initial_obarray, oblookup_last_bucket_number):
9462 (make_symbol): Remove; unused.
9463 * lisp.h (initial_obarray, make_symbol): Remove decls.
9465 * keyboard.c: Make symbols static if they're not exported.
9466 (single_kboard, recent_keys_index, total_keys, recent_keys):
9467 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9468 (this_single_command_key_start, echoing, last_auto_save):
9469 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9470 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9471 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9472 (Vlispy_mouse_stem, double_click_count):
9474 (force_auto_save_soon): Define only if SIGDANGER.
9475 (ignore_mouse_drag_p): Now static if
9476 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9477 (print_help): Remove; unused.
9478 (stop_character, last_timer_event): Mark as externally visible.
9479 * keyboard.h (ignore_mouse_drag_p): Declare only if
9480 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9481 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9482 * lisp.h (echoing): Remove decl.
9483 (force_auto_save_soon): Declare only if SIGDANGER.
9484 * xdisp.c (redisplay_window): Simplify code, to make it more
9485 obvious that ignore_mouse_drag_p is not accessed if !defined
9486 USE_GTK && !defined HAVE_NS.
9488 * intervals.c: Make symbols static if they're not exported.
9489 (merge_properties_sticky, merge_interval_right, delete_interval):
9491 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9493 * insdel.c: Make symbols static if they're not exported.
9494 However, leave prepare_to_modify_buffer alone. It's never
9495 called from outside this function, but that appears to be a bug.
9496 (combine_after_change_list, combine_after_change_buffer):
9497 (adjust_after_replace, signal_before_change): Now static.
9498 (adjust_after_replace_noundo): Remove; unused.
9499 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9500 (signal_before_change): Remove decls.
9502 * indent.c (val_compute_motion, val_vmotion): Now static.
9504 * image.c: Make symbols static if they're not exported.
9505 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9507 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9508 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9510 * fringe.c (standard_bitmaps): Now static.
9511 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9513 * frame.c: Make symbols static if they're not exported.
9514 (x_report_frame_params, make_terminal_frame): Now static.
9515 (get_frame_param): Now static, unless HAVE_NS.
9516 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9517 (x_get_resource_string): Remove; not used.
9518 * frame.h (make_terminal_frame, x_report_frame_params):
9519 (x_get_resource_string); Remove decls.
9520 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9521 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9523 * font.c, fontset.c: Make symbols static if they're not exported.
9524 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9525 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9526 * font.c (font_close_object): Now static.
9527 * font.h (font_close_object): Remove.
9528 * fontset.c (FONTSET_OBJLIST): Remove.
9529 (free_realized_fontset) #if-0 the body, which does nothing.
9530 (face_suitable_for_char_p): #if-0, as it's never called.
9531 * fontset.h (face_suitable_for_char_p): Remove decl.
9532 * xfaces.c (face_at_string_position):
9533 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9534 since 0 is always ASCII.
9536 * fns.c (weak_hash_tables): Now static.
9538 * fileio.c: Make symbols static if they're not exported.
9539 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9540 (Vwrite_region_annotation_buffers): Now static.
9542 * eval.c: Make symbols static if they're not exported.
9543 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9544 * lisp.h (backtrace_list): Remove decl.
9546 * emacs.c: Make symbols static if they're not exported.
9547 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9548 (fatal_error_code, fatal_error_signal_hook, standard_args):
9550 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9551 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9552 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9553 * lisp.h (fatal_error_signal_hook): Remove decl.
9554 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9556 * editfns.c: Move a (normally-unused) function to its only use.
9557 * editfns.c, lisp.h (get_operating_system_release): Remove.
9558 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9559 worth the hassle of breaking this out.
9561 * xterm.c: Make symbols static if they're not exported.
9562 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9563 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9564 (x_destroy_window, x_delete_display):
9566 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9567 (x_mouse_leave): Remove; unused.
9568 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9569 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9570 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9572 (x_mouse_leave): Declare only if WINDOWSNT.
9573 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9574 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9577 * ftxfont.c: Make symbols static if they're not exported.
9578 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9580 * font.h (ftxfont_driver): Likewise.
9582 * xfns.c: Make symbols static if they're not exported.
9583 (x_last_font_name, x_display_info_for_name):
9584 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9585 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9586 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9587 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9588 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9589 (last_show_tip_args): Now static.
9590 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9591 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9592 (x_screen_planes): Remove; unused.
9593 * dispextern.h (x_screen_planes): Remove decl.
9595 * dispnew.c: Make symbols static if they're not exported.
9596 * dispextern.h (redraw_garbaged_frames, scrolling):
9597 (increment_row_positions): Remove.
9598 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9599 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9601 (redraw_garbaged_frames): Remove; unused.
9603 * xfaces.c: Make symbols static if they're not exported.
9604 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9606 * xterm.h (defined_color): Remove decls.
9607 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9608 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9609 (menu_face_changed_default, defined_color, free_realized_face):
9610 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9611 (ascii_face_of_lisp_face): Remove; unused.
9613 * xdisp.c: Make symbols static if they're not exported.
9614 * dispextern.h (scratch_glyph_row, window_box_edges):
9615 (glyph_to_pixel_coords, set_cursor_from_row):
9616 (get_next_display_element, set_iterator_to_next):
9617 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9618 (show_mouse_face): Remove decls
9619 * frame.h (message_buf_print): Likewise.
9620 * lisp.h (pop_message, set_message, check_point_in_composition):
9622 * xterm.h (set_vertical_scroll_bar): Likewise.
9623 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9624 (message_buf_print, scratch_glyph_row, displayed_buffer):
9625 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9626 (get_next_display_element, show_mouse_face, window_box_edges):
9627 (frame_to_window_pixel_xy, check_point_in_composition):
9628 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9629 (glyph_to_pixel_coords): Remove; unused.
9631 * dired.c (file_name_completion): Now static.
9633 * dbusbind.c (xd_in_read_queued_messages): Now static.
9635 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9636 * data.c (circular_list_error): Remove.
9638 * commands.h (last_point_position, last_point_position_buffer):
9639 (last_point_position_window): Remove decls.
9640 * keyboard.c: Make these variables static.
9642 * coding.h (coding, code_convert_region, encode_coding_gap):
9644 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9645 (iso_code_class, detect_coding, code_convert_region): Now static.
9646 (encode_coding_gap): Remove; unused.
9648 * chartab.c (chartab_chars, chartab_bits): Now static.
9650 * charset.h (charset_iso_8859_1): Remove decl.
9651 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9654 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9655 * ccl.c (Vccl_program_table): Now static.
9656 (check_ccl_update): Remove; unused.
9658 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9659 * category.h: ... from here.
9660 * category.c (check_category_table, set_category_set): Now static.
9662 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9663 * lisp.h: Remove these decls.
9665 * buffer.c (buffer_count): Remove unused var.
9667 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9668 so that it's not optimized away.
9669 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9670 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9671 exported only to the debugger.
9673 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9674 * atimer.h (run_all_atimers): Remove; not exported.
9676 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9677 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9678 was inaccessible from Lisp.
9679 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9680 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9682 alloc.c: Import and export fewer symbols, and remove unused items.
9683 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9685 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9686 it's not optimized away by whole-program optimization.
9687 (message_enable_multibyte, free_misc): Remove.
9688 (catchlist, handlerlist, mark_backtrace):
9689 Declare only if BYTE_MARK_STACK.
9690 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9691 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9692 (message_enable_multibyte): Remove decl.
9693 (free_misc, interval_free_list, float_block, float_block_index):
9694 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9695 (cons_free_list, last_marked_index):
9697 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9698 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9699 (mark_backtrace): Define only if BYTE_MARK_STACK.
9700 * xdisp.c (message_enable_multibyte): Now static.
9702 Declare Lisp_Object Q* variables to be 'static' if not exported.
9703 This makes it easier for human readers (and static analyzers)
9704 to see whether these variables are used from other modules.
9705 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9706 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9707 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9708 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9709 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9710 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9711 * xmenu.c, xselect.c:
9712 Declare Q* vars static if they are not used in other modules.
9713 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9714 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9715 Remove decls of unexported vars.
9716 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9718 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9720 Make Emacs functions such as Fatom 'static' by default.
9721 This makes it easier for human readers (and static analyzers)
9722 to see whether these functions can be called from other modules.
9723 DEFUN now defines a static function. To make the function external
9724 so that it can be used in other C modules, use the new macro DEFUE.
9725 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9726 (Finit_image_library):
9727 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9728 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9729 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9730 Remove decls, since these functions are now static.
9731 (Funintern, Fget_internal_run_time): New decls, since these functions
9732 were already external.
9734 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9735 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9736 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9737 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9738 * keyboard.c, keymap.c, lread.c:
9739 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9740 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9741 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9742 Mark functions with DEFUE instead of DEFUN,
9743 if they are used in other modules.
9744 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9745 decls for now-static functions.
9746 * buffer.h (Fdelete_overlay): Remove decl.
9747 * callproc.c (Fgetenv_internal): Mark as internal.
9748 * composite.c (Fremove_list_of_text_properties): Remove decl.
9749 (Fcomposition_get_gstring): New forward static decl.
9750 * composite.h (Fcomposite_get_gstring): Remove decl.
9751 * dired.c (Ffile_attributes): New forward static decl.
9752 * doc.c (Fdocumntation_property): New forward static decl.
9753 * eval.c (Ffetch_bytecode): New forward static decl.
9754 (Funintern): Remove extern decl; now in .h file where it belongs.
9755 * fileio.c (Fmake_symbolic_link): New forward static decl.
9756 * image.c (Finit_image_library): New forward static decl.
9757 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9758 * intervals.h (Fprevious_property_change):
9759 (Fremove_list_of_text_properties): Remove decls.
9760 * keyboard.c (Fthis_command_keys): Remove decl.
9761 (Fcommand_execute): New forward static decl.
9762 * keymap.c (Flookup_key): New forward static decl.
9763 (Fcopy_keymap): Now static.
9764 * keymap.h (Flookup_key): Remove decl.
9765 * process.c (Fget_process): New forward static decl.
9766 (Fprocess_datagram_address): Mark as internal.
9767 * syntax.c (Fsyntax_table_p): New forward static decl.
9768 (skip_chars): Remove duplicate decl.
9769 * textprop.c (Fprevious_property_change): New forward static decl.
9770 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9772 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9773 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9775 * editfns.c (Fformat): Remove unreachable code.
9777 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9779 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9782 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9784 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9785 when at ZV. (Bug#8487)
9787 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9789 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9791 * keyboard.c (parse_tool_bar_item): Likewise.
9792 * sound.c (sound_cleanup, alsa_close): Likewise.
9793 * termcap.c (tgetent): Likewise.
9794 * xfns.c (x_default_font_parameter): Likewise.
9795 * xsettings.c (read_and_apply_settings): Likewise.
9797 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9798 (overrun_check_free): Protoize.
9800 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9802 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9803 since callers should never pass a negative size.
9804 Change the signature to match that of plain 'read' and 'write'; see
9805 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9806 * lisp.h: Update prototypes of emacs_write and emacs_read.
9808 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9810 * xdisp.c (redisplay_window): Don't try to determine the character
9811 position of the scroll margin if the window start point w->startp
9812 is outside the buffer's accessible region. (Bug#8468)
9814 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9816 Fix write-region and its subroutines for buffers > 2GB.
9817 * fileio.c (a_write, e_write): Modify declaration of arguments and
9818 local variables to support buffers larger than 2GB.
9819 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9821 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9822 argument, local variables, and return value.
9824 * lisp.h: Update prototypes of emacs_write and emacs_read.
9826 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9828 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9830 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9832 Fix more problems found by GCC 4.6.0's static checks.
9834 * xdisp.c (vmessage): Use a better test for character truncation.
9836 * charset.c (load_charset_map): <, not <=, for optimization,
9837 and to avoid potential problems with integer overflow.
9838 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9839 * casetab.c (set_identity, shuffle): Likewise.
9840 * editfns.c (Fformat): Likewise.
9841 * syntax.c (skip_chars): Likewise.
9843 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9844 This also lets GCC 4.6.0 generate slightly better loop code.
9846 * callint.c (Fcall_interactively): <, not <=, for optimization.
9847 (Fcall_interactively): Count the number of arguments produced,
9848 not the number of arguments given. This is simpler and lets GCC
9849 4.6.0 generate slightly better code.
9851 * ftfont.c: Distingish more carefully between FcChar8 and char.
9852 The previous code passed unsigned char * to a functions like
9853 strlen and xstrcasecmp that expect char *, which does not
9854 conform to the C standard.
9855 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9856 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9857 char * when the C standard requires it.
9859 * keyboard.c (read_char): Remove unused var.
9861 * eval.c: Port to Windows vsnprintf (Bug#8435).
9863 (SIZE_MAX): Define if the headers do not.
9864 (verror): Do not give up if vsnprintf returns a negative count.
9865 Instead, grow the buffer. This ports to Windows vsnprintf, which
9866 does not conform to C99. Problem reported by Eli Zaretskii.
9867 Also, simplify the allocation scheme, by avoiding the need for
9868 calling realloc, and removing the ALLOCATED variable.
9870 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9872 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9873 But keep the doprint source code for now, as we might revamp it
9874 and use it again (Bug#8435).
9875 * lisp.h (doprnt): Remove.
9876 * Makefile.in (base_obj): Remove doprnt.o.
9877 * deps.mk (doprnt.o): Remove.
9879 error: Print 32- and 64-bit integers portably (Bug#8435).
9880 Without this change, on typical 64-bit hosts error ("...%d...", N)
9881 was used to print both 32- and 64-bit integers N, which relied on
9883 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9884 * lisp.h (error, verror): Mark as printf-like functions.
9885 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9886 Report overflow in size calculations when allocating printf buffer.
9887 Do not truncate output string at its first null byte.
9888 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9889 Truncate the output at a character boundary, since vsnprintf does not
9891 * charset.c (check_iso_charset_parameter): Convert internal
9892 character to string before calling 'error', since %c now has the
9894 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9895 overflow when computing char to be passed to 'error'. Do not
9896 pass Lisp_Object to 'error'; pass the integer instead.
9897 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9898 formatted with plain %d.
9900 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9902 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9904 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9906 * xterm.c (x_catch_errors): Remove duplicate declaration.
9908 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9910 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9912 2011-04-10 Jim Meyering <meyering@redhat.com>
9914 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9915 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9916 return ssize_t not "int", and use size_t as the buffer length.
9917 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9918 * gnutls.h: Update declarations.
9919 * process.c (read_process_output): Use ssize_t, to match.
9920 (send_process): Likewise.
9922 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9924 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9926 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9928 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9929 Use unsigned char, to match FcChar8 type definition.
9931 * xterm.c (handle_one_xevent):
9932 * xmenu.c (create_and_show_popup_menu):
9933 * xselect.c (x_decline_selection_request)
9934 (x_reply_selection_request): Avoid type-punned deref of X events.
9936 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9938 Fix some uses of `int' instead of EMACS_INT.
9939 * search.c (string_match_1, fast_string_match)
9940 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9941 (scan_buffer, find_next_newline_no_quit)
9942 (find_before_next_newline, search_command, Freplace_match)
9943 (Fmatch_data): Make some `int' variables be EMACS_INT.
9945 * xdisp.c (display_count_lines): 3rd argument and return value now
9946 EMACS_INT. All callers changed.
9947 (pint2hrstr): Last argument is now EMACS_INT.
9949 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9950 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9951 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9952 (decode_coding_utf_16, decode_coding_emacs_mule)
9953 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9954 (decode_coding_ccl, decode_coding_charset)
9955 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9956 (decode_coding_iso_2022, decode_coding_emacs_mule)
9957 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9958 <char_offset, last_offset>: Declare EMACS_INT.
9959 (encode_coding_utf_8, encode_coding_utf_16)
9960 (encode_coding_emacs_mule, encode_invocation_designation)
9961 (encode_designation_at_bol, encode_coding_iso_2022)
9962 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9963 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9965 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9966 (encode_invocation_designation): Last argument P_NCHARS is now
9968 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9969 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9971 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9974 * ccl.c (Fccl_execute_on_string): Declare some variables
9977 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9979 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9981 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9983 * process.c (Fformat_network_address): Doc fix.
9985 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9987 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9989 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9991 * keyboard.c (read_char): Call Lisp function help-form-show,
9992 instead of using internal_with_output_to_temp_buffer.
9993 (Qhelp_form_show): New var.
9994 (syms_of_keyboard): Use DEFSYM macro.
9996 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9998 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10000 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10002 * process.c (Flist_processes): Remove to Lisp.
10003 (list_processes_1): Delete.
10005 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10007 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10009 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10011 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10013 Fix more problems found by GCC 4.6.0's static checks.
10015 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10017 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10019 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10021 * xdisp.c (vmessage): Mark as a printf-like function.
10023 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10025 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10027 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10028 printf-like functions.
10029 (tiff_load): Add casts to remove these marks before passing them
10030 to system-supplied API.
10032 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10034 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10035 This avoids several warnings with gcc -Wstrict-overflow.
10036 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10037 directly, rather than having caller test rule sign. This avoids
10038 some unnecessary tests.
10039 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10040 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10041 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10043 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10044 (xfont_open): Avoid unnecessary tests.
10046 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10048 * composite.h, composite.c (composition_gstring_put_cache):
10049 Use EMACS_INT, not int, for length.
10051 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10052 breaking out part of COMPOSITION_DECODE_RULE.
10053 (COMPOSITION_DECODE_RULE): Use it.
10054 * composite.c (get_composition_id): Remove unused local vars,
10055 by using the new macro.
10057 * textprop.c (set_text_properties_1): Change while to do-while,
10058 since the condition is always true at first.
10060 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10061 (interval_deletion_adjustment): Return unsigned value.
10064 * process.c (list_processes_1, create_pty, read_process_output):
10065 (exec_sentinel): Remove vars that were set but not used.
10066 (create_pty): Remove unnecessary "volatile"s.
10067 (Fnetwork_interface_info): Avoid possibility of int overflow.
10068 (read_process_output): Do adaptive read buffering even if carryover.
10069 (read_process_output): Simplify nbytes computation if buffered.
10071 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10073 * syntax.c (scan_words): Remove var that was set but not used.
10074 (update_syntax_table): Use unsigned instead of int.
10076 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10077 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10078 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10080 * print.c (print_error_message): Avoid int overflow.
10082 * font.c (font_list_entities): Redo for clarity,
10083 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10085 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10086 (font_score): Avoid potential overflow in diff calculation.
10088 * fns.c (substring_both): Remove var that is set but not used.
10089 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10091 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10093 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10094 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10095 can always succeed if overflow has undefined behavior.
10097 * search.c (boyer_moore, wordify): Remove vars set but not used.
10098 (wordify): Omit three unnecessary tests.
10100 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10101 All callers changed. This avoids the need for an unused var.
10103 * casefiddle.c (casify_region): Remove var that is set but not used.
10105 * dired.c (file_name_completion): Remove var that is set but not used.
10107 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10109 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10110 (Finsert_file_contents): Remove unnecessary code checking fd.
10112 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10113 Check for integer overflow on size calculations.
10115 * buffer.c (Fprevious_overlay_change): Remove var that is set
10118 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10119 Remove vars that are set but not used.
10120 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10121 (timer_check_2): Mark vars as initialized.
10123 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10125 * image.c (lookup_image): Remove var that is set but not used.
10126 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10128 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10129 that are set but not used.
10131 * xfns.c (make_invisible_cursor): Don't return garbage
10132 if XCreateBitmapFromData fails (Bug#8410).
10134 * xselect.c (x_get_local_selection, x_handle_property_notify):
10135 Remove vars that are set but not used.
10137 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10138 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10140 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10141 Remove var that is set but not used.
10142 (scroll_bar_windows_size): Now size_t, not int.
10143 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10144 Check for overflow.
10146 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10147 (map_tty_color) [!defined MSDOS]: Likewise.
10149 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10151 * coding.c: Remove vars that are set but not used.
10152 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10153 All callers changed.
10154 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10155 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10156 (decode_coding_charset): Remove vars that are set but not used.
10158 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10159 that is set but not used.
10161 * print.c (print_object): Remove var that is set but not used.
10163 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10164 The gnulib version avoids calling malloc in the usual case,
10165 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10166 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10167 * filelock.c (current_lock_owner): Likewise.
10168 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10169 * sysdep.c: Include allocator.h, careadlinkat.h.
10170 (emacs_no_realloc_allocator): New static constant.
10171 (emacs_readlink): New function.
10172 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10173 ../lib/careadlinkat.h.
10175 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10177 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10178 first non-nil return value).
10180 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10182 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10183 if not defined (Bug#8403).
10185 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10187 * xdisp.c (display_count_lines): Remove parameter `start',
10188 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10189 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10190 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10191 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10192 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10193 and thereabouts. All callers changed.
10194 (get_per_char_metric): Remove parameter `f', unused since
10195 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10197 2011-04-02 Jim Meyering <meyering@redhat.com>
10199 do not dereference NULL upon failed strdup
10200 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10201 (ns_get_family): Likewise.
10203 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10205 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10207 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10209 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10212 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10214 Add lexical binding.
10216 * window.c (Ftemp_output_buffer_show): New fun.
10217 (Fsave_window_excursion):
10218 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10220 * lread.c (lisp_file_lexically_bound_p): New function.
10221 (Fload): Bind Qlexical_binding.
10222 (readevalloop): Remove `evalfun' arg.
10223 Bind Qinternal_interpreter_environment.
10224 (Feval_buffer): Bind Qlexical_binding.
10225 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10227 (syms_of_lread): Declare `lexical-binding'.
10229 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10231 * keyboard.c (eval_dyn): New fun.
10232 (menu_item_eval_property): Use it.
10234 * image.c (parse_image_spec): Use Ffunctionp.
10236 * fns.c (concat, mapcar1): Accept byte-code-functions.
10238 * eval.c (Fsetq): Handle lexical vars.
10239 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10240 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10241 (FletX, Flet): Obey lexical binding.
10242 (Fcommandp): Handle closures.
10243 (Feval): New `lexical' arg.
10244 (eval_sub): New function extracted from Feval. Use it almost
10245 everywhere where Feval was used. Look up vars in lexical env.
10247 (Ffunctionp): Move from subr.el.
10248 (Ffuncall): Handle closures.
10249 (apply_lambda): Remove `eval_flags'.
10250 (funcall_lambda): Handle closures and new byte-code-functions.
10251 (Fspecial_variable_p): New function.
10252 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10253 but without exporting it to Lisp.
10255 * doc.c (Fdocumentation, store_function_docstring):
10256 * data.c (Finteractive_form): Handle closures.
10258 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10261 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10263 (exec_byte_code): New function extracted from Fbyte_code to handle new
10264 calling convention for byte-code-functions. Add new byte-codes.
10266 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10268 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10270 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10272 * xdisp.c (redisplay_internal): Fix prototype.
10274 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10276 * xdisp.c (SCROLL_LIMIT): New macro.
10277 (try_scrolling): Use it when setting scroll_limit.
10278 Limit scrolling to 100 screen lines.
10279 (redisplay_window): Even when falling back on "recentering",
10280 position point in the window according to scroll-conservatively,
10281 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10283 (try_scrolling): When point is above the window, allow searching
10284 as far as scroll_max, or one screenful, to compute vertical
10285 distance from PT to the scroll margin position. This prevents
10286 try_scrolling from unnecessarily failing when
10287 scroll-conservatively is set to a value slightly larger than the
10288 window height. Clean up the case of PT below the margin at bottom
10289 of window: scroll_max can no longer be INT_MAX. When aggressive
10290 scrolling is in use, don't let point enter the opposite scroll
10291 margin as result of the scroll.
10292 (syms_of_xdisp) <scroll-conservatively>: Document the
10293 threshold of 100 lines for never-recentering scrolling.
10295 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10297 * dispextern.h (move_it_by_lines):
10298 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10299 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10300 (message_log_check_duplicate): Remove parameters `prev_bol' and
10301 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10302 (redisplay_internal): Remove parameter `preserve_echo_area',
10303 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10305 * indent.c (Fvertical_motion):
10306 * window.c (window_scroll_pixel_based, Frecenter):
10307 Don't pass `need_y_p' to `move_it_by_lines'.
10309 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10311 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10312 steal a few bits to be more compact.
10313 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10314 Remove unneeded casts.
10316 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10318 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10320 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10321 binding" message (bug#7967).
10323 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10325 Fix more problems found by GCC 4.6.0's static checks.
10327 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10328 Remove unused local var.
10330 * editfns.c (Fmessage_box): Remove unused local var.
10332 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10333 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10334 Omit unused local vars.
10335 * window.c (shrink_windows): Omit unused local var.
10336 * menu.c (digest_single_submenu): Omit unused local var.
10337 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10338 Omit unused local var.
10340 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10341 Don't assume string length fits in int.
10342 (keyremap_step, read_key_sequence): Use size_t for sizes.
10343 (read_key_sequence): Don't check last_real_key_start redundantly.
10345 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10346 instead of alloca (Bug#8344).
10348 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10349 (Fbacktrace_frame): Don't assume nframes fits in int.
10351 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10353 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10356 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10358 * cm.c (calccost): Turn while-do into do-while, for clarity.
10360 * keyboard.c (syms_of_keyboard): Use the same style as later
10361 in this function when indexing through an array. This also
10362 works around GCC bug 48267.
10364 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10366 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10368 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10369 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10371 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10372 This avoids undefined behavior on integer overflow, and is a bit
10373 more convenient anyway since it is compared to a size_t variable.
10375 Variadic C functions now count arguments with size_t, not int.
10376 This avoids an unnecessary limitation on 64-bit machines, which
10377 caused (substring ...) to crash on large vectors (Bug#8344).
10378 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10379 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10380 All variadic functions and their callers changed accordingly.
10381 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10382 * data.c (arith_driver, float_arith_driver): Likewise.
10383 * editfns.c (general_insert_function): Likewise.
10384 * eval.c (struct backtrace.nargs, interactive_p)
10385 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10386 (funcall_lambda, mark_backtrace): Likewise.
10387 * fns.c (concat): Likewise.
10388 * frame.c (x_set_frame_parameters): Likewise.
10389 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10390 0 if not found, not -1. All callers changed.
10392 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10393 (stack_copy_size): Now size_t, not int.
10394 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10396 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10398 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10399 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10400 All callers changed.
10402 * lisp.h (multibyte_char_to_unibyte):
10403 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10404 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10405 * character.h (CHAR_TO_BYTE8):
10406 * cmds.c (internal_self_insert):
10407 * editfns.c (general_insert_function):
10408 * keymap.c (push_key_description):
10409 * search.c (Freplace_match):
10410 * xdisp.c (message_dolog, set_message_1): All callers changed.
10412 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10414 * keyboard.c (safe_run_hook_funcall): New function.
10415 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10416 don't set the hook to nil, but remove the offending function instead.
10417 (Qcommand_hook_internal): Remove, unused.
10418 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10419 Vcommand_hook_internal.
10421 * eval.c (enum run_hooks_condition): Remove.
10422 (funcall_nil, funcall_not): New functions.
10423 (run_hook_with_args): Call each function through a `funcall' argument.
10424 Remove `cond' argument, now redundant.
10425 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10426 (Frun_hook_with_args_until_failure): Adjust accordingly.
10427 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10429 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10431 * dispextern.h (string_buffer_position): Remove declaration.
10433 * print.c (strout): Remove parameter `multibyte', unused since
10434 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10436 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10437 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10438 All callers changed.
10440 * w32.c (_wsa_errlist): Use braces for struct initializers.
10442 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10443 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10444 All callers changed.
10445 (string_buffer_position): Likewise. Also, make static (it's never
10446 used outside xdisp.c).
10447 (cursor_row_p): Remove parameter `w', unused since
10448 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10449 (decode_mode_spec): Remove parameter `precision', introduced during
10450 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10451 All callers changed.
10453 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10455 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10457 2011-03-27 Anders Lindgren <andlind@gmail.com>
10459 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10460 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10461 (ns_update_auto_hide_menu_bar): New functions.
10462 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10463 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10464 ns_constrain_all_frames.
10465 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10466 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10468 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10470 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10472 2011-03-27 Glenn Morris <rgm@gnu.org>
10474 * syssignal.h: Replace RETSIGTYPE with void.
10475 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10476 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10477 Replace SIGTYPE with void everywhere.
10478 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10479 * s/template.h (SIGTYPE): Remove commented out definition.
10481 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10483 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10484 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10486 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10488 * w32.c (read_unc_volume): Use parameter `henum', instead of
10489 global variable `wget_enum_handle'.
10491 * keymap.c (describe_vector): Remove parameters `indices' and
10492 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10493 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10495 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10497 * keyboard.c (timer_check): Remove parameter `do_it_now',
10498 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10499 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10500 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10502 * keyboard.c (read_char):
10503 * w32menu.c (w32_menu_display_help):
10504 * xmenu.c (show_help_event, menu_help_callback):
10505 Adjust calls to `show_help_echo'.
10507 * gtkutil.c (xg_maybe_add_timer):
10508 * keyboard.c (readable_events):
10509 * process.c (wait_reading_process_output):
10510 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10512 * insdel.c (adjust_markers_gap_motion):
10513 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10514 (gap_left, gap_right): Don't call it.
10516 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10518 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10519 incurred during fontification.
10521 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10523 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10524 (DEFVAR_PER_BUFFER): Don't pass it.
10526 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10527 (scrolling_window): Don't pass it.
10529 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10531 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10533 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10535 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10536 of variables specific to SELinux and computation of `encoded_absname'.
10538 * image.c (XPutPixel): Remove unused variable `height'.
10540 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10542 * unexw32.c (get_section_info): Remove unused variable `section'.
10544 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10545 (system_process_attributes): Remove unused variable `sess'.
10546 (sys_read): Remove unused variable `err'.
10548 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10549 (w32_wnd_proc): Remove unused variable `isdead'.
10550 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10551 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10552 (x_create_tip_frame): Remove unused variable `tem'.
10554 * w32inevt.c (w32_console_read_socket):
10555 Remove unused variable `no_events'.
10557 * w32term.c (x_draw_composite_glyph_string_foreground):
10558 Remove unused variable `width'.
10560 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10562 * w32term.c (x_set_glyph_string_clipping):
10563 Don't pass uninitialized region to CombineRgn.
10565 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10567 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10568 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10569 (Fx_close_connection): Remove unused variable `i'.
10571 * w32font.c (w32font_draw): Return number of glyphs.
10572 (w32font_open_internal): Remove unused variable `i'.
10573 (w32font_driver): Add missing initializer.
10575 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10576 (fill_in_menu): Remove unused variable `items_added'.
10578 * w32term.c (last_mouse_press_frame): Remove static global variable.
10579 (w32_clip_to_row): Remove unused variable `f'.
10580 (x_delete_terminal): Remove unused variable `i'.
10582 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10583 (NOTHING): Remove unused static global variable.
10584 (uniscribe_check_otf): Remove unused variable `table'.
10585 (uniscribe_font_driver): Add missing initializers.
10587 2011-03-23 Julien Danjou <julien@danjou.info>
10589 * term.c (Fsuspend_tty, Fresume_tty):
10590 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10591 * window.c (temp_output_buffer_show):
10592 * insdel.c (signal_before_change):
10593 * frame.c (Fhandle_switch_frame):
10594 * fileio.c (Fdo_auto_save):
10595 * emacs.c (Fkill_emacs):
10596 * editfns.c (save_excursion_restore):
10597 * cmds.c (internal_self_insert):
10598 * callint.c (Fcall_interactively):
10599 * buffer.c (Fkill_all_local_variables):
10600 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10602 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10603 unconditionally since it does the check itself.
10605 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10607 Fix more problems found by GCC 4.5.2's static checks.
10609 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10610 the first time through the loop, since we know p0 < p1 then.
10611 This also avoids a gcc -Wstrict-overflow warning.
10613 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10614 leading to a memory leak, possible in functions like
10615 load_charset_map_from_file that can allocate an unbounded number
10616 of objects (Bug#8318).
10618 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10619 that could (at least in theory) be that large.
10621 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10622 This is less likely to overflow, and avoids undefined behavior if
10623 overflow does occur. All callers changed. Use strtoul to scan
10624 for the unsigned long integer.
10625 (pint2hrstr): Simplify and tune code slightly.
10626 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10628 * scroll.c (do_scrolling): Work around GCC bug 48228.
10629 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10631 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10632 This also avoids a warning with gcc -Wstrict-overflow.
10633 (validate_x_resource_name): Simplify count usage.
10634 This also avoids a warning with gcc -Wstrict-overflow.
10636 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10639 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10641 * process.c (Fmake_network_process): Use socklen_t, not int,
10642 where POSIX says socklen_t is required in portable programs.
10643 This fixes a porting bug on hosts like 64-bit HP-UX, where
10644 socklen_t is wider than int (Bug#8277).
10645 (Fmake_network_process, server_accept_connection):
10646 (wait_reading_process_output, read_process_output):
10649 * process.c: Rename or move locals to avoid shadowing.
10650 (list_processes_1, Fmake_network_process):
10651 (read_process_output_error_handler, exec_sentinel_error_handler):
10652 Rename or move locals.
10653 (Fmake_network_process): Define label "retry_connect" only if needed.
10654 (Fnetwork_interface_info): Fix pointer signedness.
10655 (process_send_signal): Add cast to avoid pointer signedness problem.
10656 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10657 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10659 Make tparam.h and terminfo.c consistent.
10660 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10661 Include tparam.h instead, since it declares them.
10662 * cm.h (PC): Remove extern decl; tparam.h now does this.
10663 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10664 * terminfo.c: Include tparam.h, to check interfaces.
10665 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10666 (tparam): Adjust signature to match interface in tparam.h;
10667 this removes some undefined behavior. Check that outstring and len
10668 are zero, which they always are with Emacs.
10669 * tparam.h (PC, BC, UP): New extern decls.
10671 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10672 (xftfont_open): Rename locals to avoid shadowing.
10674 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10675 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10676 (OTF_TAG_SYM): Omit macro if not needed.
10677 (ftfont_list): Remove unused local.
10678 (get_adstyle_property, ftfont_pattern_entity):
10679 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10680 Rename locals to avoid shadowing.
10682 * xfont.c (xfont_list_family): Mark var as initialized.
10684 * xml.c (make_dom): Now static.
10686 * composite.c (composition_compute_stop_pos): Rename local to
10688 (composition_reseat_it): Remove unused locals.
10689 (find_automatic_composition, composition_adjust_point): Likewise.
10690 (composition_update_it): Mark var as initialized.
10691 (find_automatic_composition): Mark vars as initialized,
10692 with a FIXME (Bug#8290).
10694 character.h: Rename locals to avoid shadowing.
10695 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10696 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10697 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10698 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10699 to avoid shadowing.
10701 * textprop.c (property_change_between_p): Remove; unused.
10703 * intervals.c (interval_start_pos): Now static.
10705 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10707 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10708 Rename locals to avoid shadowing.
10710 * sound.c (wav_play, au_play, Fplay_sound_internal):
10711 Fix pointer signedness.
10712 (alsa_choose_format): Remove unused local var.
10713 (wav_play): Initialize a variable to 0, to prevent undefined
10714 behavior (Bug#8278).
10716 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10718 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10720 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10721 clobbering (Bug#8298).
10722 * sysdep.c (sys_subshell): Likewise.
10723 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10725 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10726 This should get cleaned up, so that child_setup has the
10727 same signature on all platforms.
10729 * callproc.c (call_process_cleanup): Now static.
10730 (relocate_fd): Rename locals to avoid shadowing.
10732 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10734 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10735 not to be necessary, and produces flickering.
10737 2011-03-20 Glenn Morris <rgm@gnu.org>
10739 * config.in: Remove file.
10741 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10743 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10744 are now in src/globals.h.
10745 (syms_of_minibuf): Remove spurious & from previous change.
10747 2011-03-20 Leo Liu <sdl.web@gmail.com>
10749 * minibuf.c (completing-read-function): New variable.
10750 (completing-read-default): Rename from completing-read.
10751 (completing-read): Call completing-read-function.
10753 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10755 * xfaces.c (Fx_load_color_file):
10756 Read color file from absolute filename (bug#8250).
10758 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10760 * makefile.w32-in: Update dependencies.
10762 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10764 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10766 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10768 Fix more problems found by GCC 4.5.2's static checks.
10770 * process.c (make_serial_process_unwind, send_process_trap):
10771 (sigchld_handler): Now static.
10773 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10774 That way, the code declares only the vars that it needs.
10775 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10776 * s/cygwin.h (PTY_ITERATION): Likewise.
10777 * s/darwin.h (PTY_ITERATION): Likewise.
10778 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10780 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10781 * process.c (allocate_pty): Don't declare stb unless it's needed.
10783 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10784 (CONSTANTLIM): Remove; unused.
10785 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10786 Define only if needed.
10788 * unexelf.c (unexec): Name an expression,
10789 to avoid gcc -Wbad-function-cast warning.
10790 Use a different way to cause a compilation error if anyone uses
10791 n rather than nn, a way that does not involve shadowing.
10792 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10794 * deps.mk (unexalpha.o): Remove; unused.
10796 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10797 * unexec.h: New file.
10798 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10799 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10800 Depend on unexec.h.
10801 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10802 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10803 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10804 Change as necessary to match prototype in unexec.h.
10806 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10808 (back_comment, skip_chars): Mark vars as initialized.
10810 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10811 Rename locals to avoid shadowing.
10813 * lread.c (read1): Rewrite so as not to use empty "else".
10814 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10816 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10818 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10819 warning when compiling print.c.
10821 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10822 instead of using an uninitialized var.
10823 (font_sort_entities): Mark var as initialized.
10825 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10827 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10828 pointers to constants.
10829 (font_parse_fcname): Remove unused vars.
10830 (font_delete_unmatched): Now static.
10831 (font_get_spec): Remove; unused.
10832 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10833 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10834 Rename or move locals to avoid shadowing.
10836 * fns.c (require_nesting_list, require_unwind): Now static.
10837 (Ffillarray): Rename locals to avoid shadowing.
10839 * floatfns.c (domain_error2): Define only if needed.
10840 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10842 * alloc.c (mark_backtrace): Move decl from here ...
10843 * lisp.h: ... to here, so that it can be checked.
10845 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10846 (Fdefvar): Rewrite so as not to use empty "else".
10847 (lisp_indirect_variable): Name an expression,
10848 to avoid gcc -Wbad-function-cast warning.
10849 (Fdefvar): Rename locals to avoid shadowing.
10851 * callint.c (quotify_arg, quotify_args): Now static.
10852 (Fcall_interactively): Rename locals to avoid shadowing.
10853 Use const pointer when appropriate.
10855 * lisp.h (get_system_name, get_operating_system_release):
10856 Move decls here, to check interfaces.
10857 * process.c (get_operating_system_release): Move decl to lisp.h.
10858 * xrdb.c (get_system_name): Likewise.
10859 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10860 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10861 some of which prompt warnings from gcc -Wbad-function-cast.
10862 (Fformat_time_string, Fencode_time, Finsert_char):
10863 (Ftranslate_region_internal, Fformat):
10864 Rename or remove local vars to avoid shadowing.
10865 (Ftranslate_region_internal): Mark var as initialized.
10867 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10870 * lisp.h (eassert): Check that the argument compiles, even if
10871 ENABLE_CHECKING is not defined.
10873 * data.c (Findirect_variable): Name an expression, to avoid
10874 gcc -Wbad-function-cast warning.
10875 (default_value, arithcompare, arith_driver, arith_error): Now static.
10876 (store_symval_forwarding): Rename local to avoid shadowing.
10877 (Fmake_variable_buffer_local, Fmake_local_variable):
10878 Mark variables as initialized.
10879 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10881 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10882 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10883 Rename locals to avoid shadowing.
10884 (mark_stack): Move local variables into the #ifdef region where
10886 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10887 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10889 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10890 (GC_STRING_CHARS): Remove; not used.
10891 (Fmemory_limit): Cast sbrk's returned value to char *.
10893 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10894 avoids undefined behavior in theory.
10896 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10898 Use functions, not macros, for up- and down-casing (Bug#8254).
10899 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10900 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10901 to use the following functions instead of these macros.
10902 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10903 EMACS_INT, since callers assume the returned value fits in int.
10904 (upcase1): Likewise, for UPCASE_TABLE.
10905 (uppercasep, lowercasep, upcase): New static inline functions.
10906 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10907 the race-condition problem in the old DOWNCASE.
10909 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10910 Rename locals to avoid shadowing.
10911 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10912 (regex_compile, re_search_2, re_match_2_internal):
10913 Remove unused local vars.
10914 (FREE_VAR): Rewrite so as not to use empty "else",
10915 which gcc can warn about.
10916 (regex_compile, re_match_2_internal): Mark locals as initialized.
10917 (RETALLOC_IF): Define only if needed.
10918 (WORDCHAR_P): Likewise. This one is never needed, but is used
10919 only in a comment talking about a compiler bug, so put inside
10920 the #if 0 of that comment.
10921 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10922 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10925 * search.c (boyer_moore): Rename locals to avoid shadowing.
10926 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10927 (PREV_CHAR_BOUNDARY): Likewise.
10929 * search.c (simple_search): Remove unused var.
10931 * dired.c (compile_pattern): Move decl from here ...
10932 * lisp.h: ... to here, so that it can be checked.
10933 (struct re_registers): New forward decl.
10935 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10937 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10939 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10940 Rename locals to avoid shadowing.
10941 (Fvertical_motion): Mark locals as initialized.
10943 * casefiddle.c (casify_object, casify_region): Now static.
10944 (casify_region): Mark local as initialized.
10946 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10948 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10949 New macros, so that the caller can use some names other than
10950 gcpro1, gcpro2, etc.
10951 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10953 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10954 argument, for consistency with GCPRO2_VAR, etc: it is now the
10955 prefix of the variable, not the variable itself. All uses
10957 * dired.c (directory_files_internal, file_name_completion):
10958 Rename locals to avoid shadowing.
10960 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10961 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10962 dired.c's scmp function, had undefined behavior.
10963 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10964 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10965 * buffer.h: ... to here, because these macros use current_buffer,
10966 and the new implementation with inline functions needs to have
10967 current_buffer in scope now, rather than later when the macros
10969 (downcase, upcase1): New static inline functions.
10970 (DOWNCASE, UPCASE1): Reimplement using these functions.
10971 This avoids undefined behavior in expressions like
10972 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10973 from race conditions in accessing the global variables
10974 case_temp1 and case_temp2.
10975 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10976 * lisp.h (case_temp1, case_temp2): Remove their decls.
10977 * character.h (ASCII_CHAR_P): Move from here ...
10978 * lisp.h: ... to here, so that the inline functions mentioned
10979 above can use them.
10981 * dired.c (directory_files_internal_unwind): Now static.
10983 * fileio.c (file_name_as_directory, directory_file_name):
10984 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10986 (file_name_as_directory): Use const pointers when appropriate.
10987 (Fexpand_file_name): Likewise. In particular, newdir might
10988 point at constant storage, so make it a const pointer.
10989 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10990 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10992 (Fset_file_times, Finsert_file_contents, auto_save_error):
10993 Rename locals to avoid shadowing.
10995 * minibuf.c (choose_minibuf_frame_1): Now static.
10996 (Ftry_completion, Fall_completions): Rename or remove locals
10997 to avoid shadowing.
10999 * marker.c (bytepos_to_charpos): Remove; unused.
11001 * lisp.h (verify_bytepos, count_markers): New decls,
11002 so that gcc does not warn that these functions aren't declared.
11004 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11005 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11006 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11007 (copy_text): Remove unused local var.
11009 * filelock.c (within_one_second): Now static.
11010 (lock_file_1): Rename local to avoid shadowing.
11012 * buffer.c (fix_overlays_before): Mark locals as initialized.
11013 (fix_start_end_in_overlays): Likewise. This function should be
11014 simplified by using pointers-to-pointers, but that's a different
11016 (switch_to_buffer_1): Now static.
11017 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11018 (report_overlay_modification): Rename locals to avoid shadowing.
11020 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11021 Fix pointer signedness issue.
11022 (sys_subshell): Mark local as volatile if checking for lint,
11023 to suppress a gcc -Wclobbered warning that does not seem to be right.
11024 (MAXPATHLEN): Define only if needed.
11026 * process.c (serial_open, serial_configure): Move decls from here ...
11027 * systty.h: ... to here, so that they can be checked.
11029 * fns.c (get_random, seed_random): Move extern decls from here ...
11030 * lisp.h: ... to here, so that they can be checked.
11032 * sysdep.c (reset_io): Now static.
11033 (wait_for_termination_signal): Remove; unused.
11035 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11036 (copy_keymap_item, append_key, push_text_char_description):
11038 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11039 (DENSE_TABLE_SIZE): Remove; unused.
11040 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11041 (describe_map_tree):
11042 Rename locals to avoid shadowing.
11044 * keyboard.c: Declare functions static if they are not used elsewhere.
11045 (echo_char, echo_dash, cmd_error, top_level_2):
11046 (poll_for_input, handle_async_input): Now static.
11047 (read_char, kbd_buffer_get_event, make_lispy_position):
11048 (make_lispy_event, make_lispy_movement, apply_modifiers):
11049 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11050 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11051 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11052 (read_key_sequence, read_char): Mark locals as initialized.
11053 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11055 * keyboard.h (make_ctrl_char): New decl.
11056 (mark_kboards): Move decl here ...
11057 * alloc.c (mark_kboards): ... from here.
11059 * lisp.h (force_auto_save_soon): New decl.
11061 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11062 (DEFINE_DUMMY_FUNCTION): New macro.
11063 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11065 (main): Add casts to avoid warnings
11066 if GCC considers string literals to be constants.
11068 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11070 * dbusbind.c: Pointer signedness fixes.
11071 (xd_signature, xd_append_arg, xd_initialize):
11072 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11073 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11074 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11075 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11077 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11078 if GCC considers string literals to be constants.
11079 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11081 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11083 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11084 (print_preprocess, print_object): New macro to fix last change.
11086 * print.c (print_preprocess): Don't forget font objects.
11088 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11090 * emacs.c (USAGE3): Doc fixes.
11092 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11094 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11097 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11099 * lisp.h (VWindow_system, Qfile_name_history):
11100 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11101 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11102 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11104 * w32select.c: Don't #include "keyboard.h".
11105 (run_protected): Add extern declaration for waiting_for_input.
11107 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11108 * w32console.c (detect_input_pending, read_input_pending)
11109 (encode_terminal_code):
11110 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11111 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11112 (w32_system_caret_y, Qfile_name_history):
11113 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11114 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11115 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11116 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11117 * w32proc.c (Qlocal, report_file_error):
11118 * w32term.c (Vwindow_system, updating_frame):
11119 * w32uniscribe.c (initialized, uniscribe_font_driver):
11120 Remove unneeded extern declarations.
11122 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11124 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11126 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11128 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11129 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11130 These macros can no longer be used for assignment.
11132 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11133 Assign struct members directly, instead of using BUF_BEGV etc.
11134 (record_buffer_markers, fetch_buffer_markers): New functions for
11135 recording and fetching special buffer markers.
11136 (set_buffer_internal_1, set_buffer_temp): Use them.
11138 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11140 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11142 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11143 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11145 * xdisp.c (hscroll_window_tree):
11146 (reconsider_clip_changes): Use PT instead of BUF_PT.
11148 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11150 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11151 $(EMACS_ROOT)/lib/intprops.h.
11153 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11155 Fix more problems found by GCC 4.5.2's static checks.
11157 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11158 to unsigned char * to avoid compiler diagnostic.
11159 (xg_free_frame_widgets): Make it clear that a local variable is
11160 needed only if USE_GTK_TOOLTIP.
11161 (gdk_window_get_screen): Make it clear that this macro is needed
11162 only if USE_GTK_TOOLTIP.
11163 (int_gtk_range_get_value): New function, which avoids a diagnostic
11164 from gcc -Wbad-function-cast.
11165 (xg_set_toolkit_scroll_bar_thumb): Use it.
11166 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11167 diagnostic from gcc -Wbad-function-cast.
11168 (get_utf8_string, xg_get_file_with_chooser):
11169 Rename locals to avoid shadowing.
11170 (create_dialog): Move locals to avoid shadowing.
11172 * xgselect.c (xg_select): Remove unused var.
11174 * image.c (four_corners_best): Mark locals as initialized.
11175 (gif_load): Initialize transparent_p to zero (Bug#8238).
11176 Mark another local as initialized.
11177 (my_png_error, my_error_exit): Mark with NO_RETURN.
11179 * image.c (clear_image_cache): Now static.
11180 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11181 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11182 (x_edge_detection): Remove unnecessary cast that
11183 gcc -Wbad-function-cast diagnoses.
11184 (gif_load): Fix pointer signedness.
11185 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11186 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11188 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11190 Improve quality of tests for time stamp overflow.
11191 For example, without this patch (encode-time 0 0 0 1 1
11192 1152921504606846976) returns the obviously-bogus value (-948597
11193 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11194 reports time overflow. See
11195 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11196 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11197 * editfns.c: Include limits.h and intprops.h.
11198 (TIME_T_MIN, TIME_T_MAX): New macros.
11199 (time_overflow): Move earlier, to before first use.
11200 (hi_time, lo_time): New functions, for an accurate test for
11201 out-of-range times.
11202 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11203 (Fget_internal_run_time): Don't assume time_t fits in int.
11204 (make_time): Use list2 instead of Fcons twice.
11205 (Fdecode_time): More accurate test for out-of-range times.
11206 (check_tm_member): New function.
11207 (Fencode_time): Use it, to test for out-of-range times.
11208 (lisp_time_argument): Don't rely on undefined left-shift and
11209 right-shift behavior when checking for time stamp overflow.
11211 * editfns.c (time_overflow): New function, refactoring common code.
11212 (Fformat_time_string, Fdecode_time, Fencode_time):
11213 (Fcurrent_time_string): Use it.
11215 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11216 * dired.c (make_time): Move to ...
11217 * editfns.c (make_time): ... here.
11218 * systime.h: Note the move.
11220 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11222 * fringe.c (update_window_fringes): Remove unused variables.
11224 * unexmacosx.c (copy_data_segment): Also copy __got section.
11227 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11229 * termcap.c [MSDOS]: Include "msdos.h".
11230 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11231 Constify `char *' arguments and their references according to
11232 prototypes in tparam.h.
11234 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11236 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11237 Adapt all references accordingly.
11239 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11241 2011-03-11 Tom Tromey <tromey@redhat.com>
11243 * buffer.c (syms_of_buffer): Remove obsolete comment.
11245 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11247 * termhooks.h (encode_terminal_code): Declare prototype.
11249 * msdos.c (encode_terminal_code): Don't declare prototype.
11251 * term.c (encode_terminal_code): Now external again, used by
11252 w32console.c and msdos.c.
11254 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11255 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11257 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11259 Fix some minor problems found by GCC 4.5.2's static checks.
11261 * fringe.c (update_window_fringes): Mark locals as initialized
11263 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11265 * alloc.c (mark_fringe_data): Move decl from here ...
11266 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11267 to check its interface.
11268 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11270 * fontset.c (free_realized_fontset): Now static.
11271 (Fset_fontset_font): Rename local to avoid shadowing.
11272 (fontset_font): Mark local as initialized.
11273 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11275 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11277 * xselect.c (x_disown_buffer_selections): Remove; not used.
11278 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11279 (x_own_selection, Fx_disown_selection_internal): Rename locals
11280 to avoid shadowing.
11281 (x_handle_dnd_message): Remove local to avoid shadowing.
11283 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11284 so that the caller can use some name other than gcpro1.
11285 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11286 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11287 (Fx_backspace_delete_keys_p):
11288 Use them to avoid shadowing, and rename vars to avoid shadowing.
11289 (x_decode_color, x_set_name, x_window): Now static.
11290 (Fx_create_frame): Add braces to silence GCC warning.
11291 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11292 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11293 Remove unused locals.
11294 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11295 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11296 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11299 * xterm.h (x_mouse_leave): New decl.
11301 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11302 Remove unused functions.
11303 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11304 (x_calc_absolute_position): Now static.
11305 (XTread_socket): Don't define label "out" unless it's used.
11306 Don't declare local "event" unless it's used.
11307 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11308 unless they are used.
11309 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11310 (x_fatal_error_signal): Remove; not used.
11311 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11312 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11313 (x_error_catcher, x_connection_closed, x_error_handler):
11314 (x_error_quitter, xembed_send_message, x_iconify_frame):
11315 (my_log_handler): Rename locals to avoid shadowing.
11316 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11317 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11319 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11320 Rename or move locals to avoid shadowing.
11321 (tty_defined_color, merge_face_heights): Now static.
11322 (free_realized_faces_for_fontset): Remove; not used.
11323 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11324 does not deduce is never used uninitialized.
11325 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11326 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11328 * terminal.c (store_terminal_param): Now static.
11330 * xmenu.c (menu_highlight_callback): Now static.
11331 (set_frame_menubar): Remove unused local.
11332 (xmenu_show): Rename parameter to avoid shadowing.
11333 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11334 since they might point to immutable storage.
11335 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11336 since it's unused otherwise.
11338 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11339 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11340 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11341 avoids a gcc -Wuninitialized diagnostic.
11342 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11343 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11344 does not deduce are never used uninitialized.
11346 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11348 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11349 * window.c (window_loop, size_window):
11350 (run_window_configuration_change_hook, enlarge_window): Likewise.
11352 * window.c (display_buffer): Now static.
11353 (size_window): Mark variables that gcc -Wuninitialized
11354 does not deduce are never used uninitialized.
11355 * window.h (check_all_windows): New decl, to forestall
11356 gcc -Wmissing-prototypes diagnostic.
11357 * dispextern.h (bidi_dump_cached_states): Likewise.
11359 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11361 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11362 Include <limits.h>.
11363 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11364 and to avoid gcc -Wuninitialized warning.
11365 (load_charset_map): Mark variables that gcc -Wuninitialized
11366 does not deduce are never used uninitialized.
11367 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11369 * coding.c (coding_set_source, coding_set_destination):
11370 Use "else { /* comment */ }" rather than "else /* comment */;"
11371 for clarity, and to avoid gcc -Wempty-body warning.
11372 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11373 a block, when the outer 'i' will do.
11374 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11375 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11376 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11377 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11378 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11379 Rename locals to avoid shadowing.
11380 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11381 * coding.c (emacs_mule_char, encode_invocation_designation):
11382 Now static, since they're not used elsewhere.
11383 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11384 (decode_coding_object, encode_coding_object, detect_coding_system):
11385 (decode_coding_emacs_mule): Mark variables that gcc
11386 -Wuninitialized does not deduce are never used uninitialized.
11387 (detect_coding_iso_2022): Initialize a local variable that might
11388 be used uninitialized. Leave a FIXME because it's not clear that
11389 this initialization is needed. (Bug#8211)
11390 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11391 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11392 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11393 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11394 Remove unused macros.
11396 * category.c (hash_get_category_set): Remove unused local var.
11397 (copy_category_table): Now static, since it's not used elsewhere.
11398 * character.c (string_count_byte8): Likewise.
11400 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11401 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11403 * chartab.c (copy_sub_char_table): Now static, since it's not used
11405 (sub_char_table_ref_and_range, char_table_ref_and_range):
11406 Rename locals to avoid shadowing.
11407 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11409 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11410 (BIDI_BOB): Remove unused macro.
11412 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11413 deduce are never used uninitialized.
11414 * term.c (encode_terminal_code): Likewise.
11416 * term.c (encode_terminal_code): Now static. Remove unused local.
11418 * tparam.h: New file.
11419 * term.c, tparam.h: Include it.
11420 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11421 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11422 Move these decls to tparam.h, and make them agree with what
11423 is actually in tparam.c. The previous trick of using incompatible
11424 decls in different modules does not conform to the C standard.
11425 All callers of tparam changed to use tparam's actual API.
11426 * tparam.c (tparam1, tparam, tgoto):
11427 Use const pointers where appropriate.
11429 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11430 * cm.h (struct cm): Likewise.
11431 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11432 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11433 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11434 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11435 (turn_on_face, init_tty): Likewise.
11436 * termchar.h (struct tty_display_info): Likewise.
11438 * term.c (term_mouse_position): Rename local to avoid shadowing.
11440 * alloc.c (mark_ttys): Move decl from here ...
11441 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11443 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11445 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11447 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11449 * search.c (compile_pattern_1): Remove argument regp, unused since
11450 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11451 (compile_pattern): Don't pass it.
11453 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11455 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11456 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11458 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11460 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11462 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11463 gdk_window_get_screen, gdk_window_get_geometry,
11464 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11465 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11466 (xg_get_pixbuf_from_pixmap): New function.
11467 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11468 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11469 Call xg_get_pixbuf_from_pixmap instead of
11470 gdk_pixbuf_get_from_drawable.
11471 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11472 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11473 (xg_check_special_colors): Use GtkStyleContext and its functions
11475 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11476 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11477 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11478 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11479 Call gtk_widget_get_preferred_size.
11480 (xg_frame_resized): gdk_window_get_geometry only takes 5
11482 (xg_win_to_widget, xg_event_is_for_menubar):
11483 Call gdk_x11_window_lookup_for_display.
11484 (xg_set_widget_bg): New function.
11485 (delete_cb): New function.
11486 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11487 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11488 (xg_set_background_color): Call xg_set_widget_bg.
11489 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11490 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11491 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11492 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11494 (update_frame_tool_bar): Call gtk_widget_hide.
11495 (xg_initialize): Use GDK_KEY_g.
11497 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11499 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11501 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11502 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11503 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11505 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11507 * w32xfns.c (select_palette): Check success of RealizePalette against
11508 GDI_ERROR, not zero.
11510 See ChangeLog.11 for earlier changes.
11512 ;; Local Variables:
11516 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11518 This file is part of GNU Emacs.
11520 GNU Emacs is free software: you can redistribute it and/or modify
11521 it under the terms of the GNU General Public License as published by
11522 the Free Software Foundation, either version 3 of the License, or
11523 (at your option) any later version.
11525 GNU Emacs is distributed in the hope that it will be useful,
11526 but WITHOUT ANY WARRANTY; without even the implied warranty of
11527 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11528 GNU General Public License for more details.
11530 You should have received a copy of the GNU General Public License
11531 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.