* ccl.c: Improve and simplify overflow checking (Bug#9196).
[bpt/emacs.git] / src / ChangeLog
1 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2
3 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4 (ccl_driver): Do not generate an out-of-range pointer.
5 (Fccl_execute_on_string): Remove unnecessary check for
6 integer overflow, noted by Stefan Monnier in
7 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8 Remove a FIXME that didn't need fixing.
9 Simplify the newly-introduced buffer reallocation code.
10
11 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
12
13 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
14
15 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
16
17 Integer and memory overflow issues (Bug#9196).
18
19 * doc.c (get_doc_string): Rework so that
20 get_doc_string_buffer_size is the actual buffer size, rather than
21 being 1 less than the actual buffer size; this makes xpalloc more
22 convenient.
23
24 * image.c (x_allocate_bitmap_record, cache_image):
25 * xselect.c (Fx_register_dnd_atom):
26 Simplify previous changes by using xpalloc.
27
28 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
29 since either will do and ptrdiff_t is convenient with xpalloc.
30
31 * charset.c (charset_table_size)
32 (struct charset_sort_data.priority): Now ptrdiff_t.
33 (charset_compare): Don't overflow if priorities differ greatly.
34 (Fsort_charsets): Don't assume list length fits in int.
35 Check for size-calculation overflow when allocating sort data.
36 (syms_of_charset): Allocate an initial charset table that is
37 just under 64 KiB, to avoid problems with glibc malloc and mmap.
38
39 * cmds.c (internal_self_insert): Check for size-calculation overflow.
40
41 * composite.h (struct composition.glyph_len): Now int, not unsigned.
42 The actual value is always <= INT_MAX, and leaving it unsigned made
43 overflow checking harder.
44
45 * dispextern.h (struct glyph_matrix.rows_allocated)
46 (struct face_cache.size): Now ptrdiff_t, for convenience in use
47 with xpalloc. The values are still always <= INT_MAX.
48
49 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
50
51 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
52 (SAFE_NALLOCA): New macro.
53
54 * region-cache.c (struct boundary.pos, find_cache_boundary)
55 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
56 (set_cache_region, invalidate_region_cache)
57 (revalidate_region_cache, know_region_cache, region_cache_forward)
58 (region_cache_backward, pp_cache):
59 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
60 so that ptrdiff_t * can be passed to xpalloc.
61 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
62 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
63 (pp_cache): Don't assume cache_len fits in int.
64 * region-cache.h: Adjust extern decls to match.
65
66 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
67 EMACS_INT, since either will do, for xpalloc.
68
69 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
70 (xnmalloc, xnrealloc, xpalloc): New functions.
71
72 * bidi.c (bidi_shelve_header_size): New constant.
73 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
74 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
75
76 * bidi.c (bidi_cache_shrink):
77 * buffer.c (overlays_at, overlays_in, record_overlay_string)
78 (overlay_strings):
79 Don't update size of array until after memory allocation succeeds,
80 because xmalloc/xrealloc may not return.
81 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
82 now that we have proper integer overflow checking.
83 (record_overlay_string, overlay_strings): Catch overflows when
84 calculating size of overlay_str_buf.
85
86 * callproc.c (Fcall_process): Check for size overflow when
87 calculating size of args2.
88 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
89 Normally we prefer signed values, but sticking with ptrdiff_t would
90 require adding more-complicated checks.
91
92 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
93 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
94 Redo buffer-overflow calculations to avoid integer overflow.
95 Add a FIXME comment where memory seems to be over-allocated.
96
97 * character.c (Fstring): Check for size-calculation overflow.
98
99 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
100 unnecessary integer overflow. Check for size overflow.
101 (encode_coding_object): Don't update size until xmalloc succeeds.
102
103 * composite.c (get_composition_id): Check for overflow in glyph
104 length calculations.
105
106 Integer and memory overflow fixes for display code.
107 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
108 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
109 (scrolling_window): Check for overflow in size calculations.
110 (line_draw_cost, realloc_glyph_pool, add_row_entry):
111 Don't assume glyph table len fits in int.
112 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
113 (row_table_size): Now ptrdiff_t, not int.
114 (scrolling_window): Avoid overflow in size calculations.
115 Don't update size until allocation succeeds.
116 * fns.c (concat): Check for overflow in size calculations.
117 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
118 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
119 (NEXT_ALMOST_PRIME_LIMIT): New constant.
120
121 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
122 (get_doc_string): Check for size calculation overflow.
123 Don't update size until allocation succeeds.
124 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
125 EMACS_INT, where ptrdiff_t will do.
126 (Fsubstitute_command_keys): Check for string overflow.
127
128 * editfns.c (set_time_zone_rule): Don't assume environment length
129 fits in int.
130 (message_length): Now ptrdiff_t, not int.
131 (Fmessage_box): Don't update size until allocation succeeds.
132 Don't assume message length fits in int.
133 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
134
135 * emacs.c (main): Do not reallocate argv, since there is a null at
136 the end that can be overwritten, and this way there's no need to
137 worry about size-calculation overflow.
138 (sort_args): Check for size-calculation overflow.
139
140 * eval.c (init_eval_once, grow_specpdl): Don't update size until
141 alloc succeeds.
142 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
143
144 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
145 (x_set_scroll_bar_width, x_figure_window_size):
146 Check for integer overflow.
147 (x_set_alpha): Do not assume XINT fits in int.
148
149 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
150 This is for the members text_lines, text_cols, total_lines, total_cols,
151 where the system imposes an 'int' limit.
152
153 * fringe.c (Fdefine_fringe_bitmap):
154 Don't update size until alloc works.
155
156 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
157 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
158
159 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
160 Check for size-calculation overflow.
161 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
162 do, as we prefer signed integers.
163 (id_to_widget.max_size, id_to_widget.used)
164 (xg_store_widget_in_map, xg_remove_widget_from_map)
165 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
166 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
167 Use and return ptrdiff_t, not int.
168 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
169 * gtkutil.h: Change prototypes to match the above.
170
171 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
172 are duplicate now that they've been promoted to lisp.h.
173 (x_allocate_bitmap_record, x_alloc_image_color)
174 (make_image_cache, cache_image, xpm_load):
175 Don't update size until alloc is done.
176 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
177 (x_detect_edges):
178 Check for size calculation overflow.
179 (ct_colors_allocated_max): New constant.
180 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
181 overflow.
182
183 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
184 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
185 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
186 Use ptrdiff_t, not int, to count maps.
187 (read_char_minibuf_menu_prompt): Check for overflow in size
188 calculations. Don't update size until allocation succeeds. Redo
189 calculations to avoid overflow.
190 * keyboard.h: Change prototypes to match the above.
191
192 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
193 to count maps.
194 (current_minor_maps): Check for size calculation overflow.
195 * keymap.h: Change prototypes to match the above.
196
197 * lread.c (read1, init_obarray): Don't update size until alloc done.
198
199 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
200 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
201
202 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
203 Now ptrdiff_t, not int.
204 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
205 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
206
207 * process.c (Fnetwork_interface_list): Check for overflow
208 in size calculation.
209
210 * region-cache.c (move_cache_gap): Check for size calculation overflow.
211
212 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
213 overflow. Don't bother calling xmalloc when xrealloc will do.
214
215 * search.c (Freplace_match): Check for size calculation overflow.
216 (Fset_match_data): Don't assume list lengths fit in 'int'.
217
218 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
219 for command line length. Do not attempt to address one before the
220 beginning of an array, as that's not portable.
221
222 * term.c (max_frame_lines): Remove; unused.
223 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
224 not int.
225 (encode_terminal_code, calculate_costs): Check for size
226 calculation overflow.
227 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
228 table lengths and related sizes. Don't update size until alloc
229 done. Redo calculations to avoid overflow.
230 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
231
232 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
233 subtracting pointers.
234 (gobble_line): Check for overflow more carefully. Don't update size
235 until alloc done.
236
237 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
238 Don't update size until alloc done.
239 Redo size calculations to avoid overflow.
240 Check for size calculation overflow.
241 (main) [DEBUG]: Fix typo in invoking tparam1.
242
243 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
244 Use ptrdiff_t, not int, for sizes.
245 (store_mode_line_noprop_char): Don't update size until alloc done.
246
247 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
248 Use ptrdiff_t, not int, for sizes.
249 (Finternal_make_lisp_face, cache_face):
250 Check for size calculation overflow.
251 (cache_face): Treat size calculation overflows as if they were
252 memory exhaustion (the usual treatment), rather than aborting.
253
254 * xfns.c (x_encode_text, x_set_name_internal)
255 (Fx_change_window_property): Use ptrdiff_t, not int, to count
256 sizes, since they can exceed INT_MAX in size. Check for size
257 calculation overflow.
258
259 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
260 (xg_select): Check for size calculation overflow.
261 Don't update size until alloc done.
262
263 * xrdb.c (get_environ_db): Don't assume path length fits in int,
264 as sprintf is limited to int lengths.
265
266 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
267 (X_LONG_MIN): New macros.
268 Use them to make the following changes clearer.
269 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
270 This change doesn't affect the value now, but it may help remind
271 future maintainers not to raise the value too much later.
272 (SELECTION_QUANTUM): Remove, replacing with ...
273 (selection_quantum): ... new function, which avoids overflow.
274 All uses changed.
275 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
276 assumption that selection length fits in 'int'.
277 (x_reply_selection_request, x_handle_selection_request)
278 (x_get_window_property, receive_incremental_selection)
279 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
280 (lisp_data_to_selection_data, clean_local_selection_data):
281 Use ptrdiff_t, not int, to record length of selection.
282 (x_reply_selection_request, x_get_window_property)
283 (receive_incremental_selection, x_property_data_to_lisp):
284 Redo calculations to avoid overflow.
285 (x_reply_selection_request): When sending hint, ceiling it at
286 X_LONG_MAX rather than relying on wraparound overflow to send
287 something.
288 (x_get_window_property, receive_incremental_selection)
289 (lisp_data_to_selection_data, x_property_data_to_lisp):
290 Check for size-calculation overflow.
291 (x_get_window_property, receive_incremental_selection)
292 (lisp_data_to_selection_data, Fx_register_dnd_atom):
293 Don't store size until memory allocation succeeds.
294 (x_get_window_property): Plug memory leak on memory exhaustion.
295 Don't double-block input; malloc is safe here. Don't assume 2**34
296 - 4 fits in unsigned long. Add an xassert to check
297 XGetWindowProperty overflow. Be more careful about overflow
298 calculations, and distinguish size from memory overflow better.
299 (receive_incremental_selection): When tracing, don't assume
300 unsigned int is less than INT_MAX.
301 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
302 harmful) conversions of unsigned short to int.
303 (lisp_data_to_selection_data): Don't assume that integers
304 in the range -65535 through -1 fit in an X unsigned short.
305 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
306 result parameters unless successful. Rely on cons_to_unsigned
307 to report problems with elements; the old code wasn't right anyway.
308 (x_check_property_data): Check for int overflow; we cannot use
309 a wider type due to X limits.
310 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
311
312 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
313
314 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
315 (x_term_init): Check for size calculation overflow.
316 (x_color_cells): Don't store size until memory allocation succeeds.
317 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
318 Don't assume alloca size is less than MAX_ALLOCA.
319 (x_term_init): Don't assume length fits in int (sprintf is limited
320 to int size).
321
322 Use ptrdiff_t for composition IDs.
323 * character.c (lisp_string_width):
324 * composite.c (composition_table_size, n_compositions)
325 (get_composition_id, composition_gstring_from_id):
326 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
327 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
328 * window.c (Frecenter):
329 Use ptrdiff_t, not int, for composition IDs.
330 * composite.c (get_composition_id): Check for integer overflow.
331 * composite.h: Adjust prototypes to match the above changes.
332
333 Use ptrdiff_t for hash table indexes.
334 * category.c (hash_get_category_set):
335 * ccl.c (ccl_driver):
336 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
337 * coding.c (coding_system_charset_list, detect_coding_system):
338 * coding.h (struct coding_system.id):
339 * composite.c (get_composition_id, gstring_lookup_cache):
340 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
341 * image.c (xpm_get_color_table_h):
342 * lisp.h (hash_lookup, hash_put):
343 * minibuf.c (Ftest_completion):
344 Use ptrdiff_t for hash table indexes, not int (which is too
345 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
346 32-bit --with-wide-int hosts).
347
348 * charset.c (Fdefine_charset_internal): Check for integer overflow.
349 Add a FIXME comment about memory leaks.
350 (syms_of_charset): Don't assume xmalloc returns.
351
352 Don't assume that stated character widths fit in int.
353 * character.c (Fchar_width, c_string_width, lisp_string_width):
354 * character.h (CHAR_WIDTH):
355 * indent.c (MULTIBYTE_BYTES_WIDTH):
356 Use sanitize_char_width to avoid undefined and/or bad behavior
357 with outlandish widths.
358 * character.h (sanitize_tab_width): Renamed from sanitize_width,
359 now that we have two such functions. All uses changed.
360 (sanitize_char_width): New inline function.
361
362 Don't assume that tab-width fits in int.
363 * character.h (sanitize_width): New inline function.
364 (SANE_TAB_WIDTH): New macro.
365 (ASCII_CHAR_WIDTH): Use it.
366 * indent.c (sane_tab_width): Remove. All uses replaced by
367 SANE_TAB_WIDTH (current_buffer).
368 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
369
370 * fileio.c: Integer overflow issues with file modes.
371 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
372
373 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
374 Remove unreachable code.
375 (read_hex, load_charset_map_from_file): Check for integer overflow.
376
377 * xterm.c: don't go over XClientMessageEvent limit
378 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
379 (x_send_scroll_bar_event): Likewise. Check that the size does not
380 exceed limits imposed by XClientMessageEvent, as well as the usual
381 ptrdiff_t and size_t limits.
382
383 * keyboard.c: Overflow, signedness and related fixes.
384 (make_lispy_movement): Use same integer type in forward decl
385 that is used in the definition.
386 (read_key_sequence, keyremap_step):
387 Change bufsize argument back to int, undoing my 2011-03-30 change.
388 We prefer signed types, and int is wide enough here.
389 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
390 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
391 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
392 length, not size_t. Use ptrdiff_t for index, not int.
393 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
394 possibility of integer overflow.
395
396 Overflow, signedness and related fixes for images.
397
398 * dispextern.h (struct it.stack[0].u.image.image_id)
399 (struct_it.image_id, struct image.id, struct image_cache.size)
400 (struct image_cache.used, struct image_cache.ref_count):
401 * gtkutil.c (update_frame_tool_bar):
402 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
403 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
404 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
405 * nsmenu.m (update_frame_tool_bar):
406 * xdisp.c (calc_pixel_width_or_height):
407 * xfns.c (image_cache_refcount):
408 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
409 on typical 64-bit hosts.
410
411 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
412 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
413 Omit unnecessary casts to int.
414 (parse_image_spec): Check that integers fall into 'int' range
415 when the callers expect that.
416 (image_ascent): Redo ascent calculation to avoid int overflow.
417 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
418 (lookup_image): Remove unnecessary tests.
419 (xbm_image_p): Locals are now of int, not EMACS_INT,
420 since parse_image_check makes sure they fit into int.
421 (png_load, gif_load, svg_load_image):
422 Prefer int to unsigned where either will do.
423 (tiff_handler): New function, combining the cores of the
424 old tiff_error_handler and tiff_warning_handler. This
425 function is rewritten to use vsnprintf and thereby avoid
426 stack buffer overflows. It uses only the features of vsnprintf
427 that are common to both POSIX and native Microsoft.
428 (tiff_error_handler, tiff_warning_handler): Use it.
429 (tiff_load, gif_load, imagemagick_load_image):
430 Don't assume :index value fits in 'int'.
431 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
432 (imagemagick_load_image): Check that crop parameters fit into
433 the integer types that MagickCropImage accepts. Don't assume
434 Vimagemagick_render_type has a nonnegative value. Don't assume
435 size_t fits in 'long'.
436 (gs_load): Use printmax_t to print the widest integers possible.
437 Check for integer overflow when computing image height and width.
438
439 2011-08-26 Eli Zaretskii <eliz@gnu.org>
440
441 * xdisp.c (redisplay_window): Don't force window start if point
442 will be invisible in the resulting window. (Bug#9324)
443
444 2011-08-25 Eli Zaretskii <eliz@gnu.org>
445
446 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
447 the display spec is of the form `(space ...)'.
448 (handle_display_spec): Return the value returned by
449 handle_single_display_spec, not just 1 or zero.
450 (handle_single_display_spec): If the display spec is of the form
451 `(space ...)', and specifies display in the text area, return 2
452 rather than 1.
453 (try_cursor_movement): Check for the need to scroll more
454 accurately, and prefer exact match for point under bidi. Don't
455 advance `row' beyond the last row of the window.
456
457 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
458 into disp_prop; all users changed.
459
460 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
461 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
462 for the text covered by the display property.
463
464 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
465
466 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
467 Change return value to nil.
468 (Frecord_buffer): Delete unused function.
469
470 2011-08-24 Eli Zaretskii <eliz@gnu.org>
471
472 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
473 buffers, return left-to-right.
474 (set_cursor_from_row): Consider candidate row a win if its glyph
475 represents a newline and point is on that newline. Fixes cursor
476 positioning on the newline at EOL of R2L text within L2R
477 paragraph, and vice versa.
478 (try_cursor_movement): Check continued rows, in addition to
479 continuation rows. Fixes unwarranted scroll when point enters a
480 continued line of R2L text within an L2R paragraph, or vice versa.
481 (cursor_row_p): Consider the case of point being equal to
482 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
483 from the end of a short line to the beginning of a continued line
484 of R2L text within L2R paragraph.
485 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
486 composed characters.
487
488 * bidi.c (bidi_check_type): Use xassert.
489 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
490 members.
491
492 2011-08-23 Eli Zaretskii <eliz@gnu.org>
493
494 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
495 a character.
496
497 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
498
499 * nsfont.m (ns_otf_to_script): Fix typo.
500
501 2011-08-22 Kenichi Handa <handa@m17n.org>
502
503 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
504 extra slot even if the purpose is char-code-property-table.
505
506 2011-08-23 Eli Zaretskii <eliz@gnu.org>
507
508 * xdisp.c (redisplay_window): When computing centering_position,
509 account for the height of the header line. (Bug#8874)
510
511 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
512 instead of CHAR_TO_BYTE. Fixes a crash when a completion
513 candidate is selected by the mouse, and that candidate has a
514 composed character under the mouse.
515
516 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
517 coordinates reported by pos-visible-in-window-p for a composed
518 character in column zero.
519
520 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
521
522 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
523
524 2011-08-22 Eli Zaretskii <eliz@gnu.org>
525
526 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
527 consider it a hit if to_charpos is anywhere in the range of the
528 composed buffer positions.
529
530 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
531
532 * image.c (gif_load): Don't assume that each subimage has the same
533 dimensions as the base image. Handle disposal method that is
534 "undefined" by the gif spec (Bug#9335).
535
536 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
537
538 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
539 (Fcondition_case): Document `debug' symbol in error handler.
540
541 2011-08-19 Eli Zaretskii <eliz@gnu.org>
542
543 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
544 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
545 from an Org mode buffer to a Speedbar frame.
546
547 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
548 a composition, take its buffer position from IT->cmp_it.charpos.
549 Fixes cursor positioning at the beginning of a line that begins
550 with a composed character.
551
552 2011-08-18 Eli Zaretskii <eliz@gnu.org>
553
554 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
555 character bidirectional type, use STRONG_L instead. Fixes crashes
556 in a buffer produced by `describe-categories'.
557
558 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
559 members before the level stack, so they would be saved and
560 restored when copying iterator state. Fixes incorrect reordering
561 around TABs covered by display properties.
562
563 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
564
565 * process.c (Fnetwork_interface_list): Correctly determine buffer
566 size.
567
568 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
569
570 * eval.c (internal_condition_case, internal_condition_case_1)
571 (internal_condition_case_2, internal_condition_case_n):
572 Remove unnecessary aborts (Bug#9081).
573
574 2011-08-17 Eli Zaretskii <eliz@gnu.org>
575
576 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
577 has no `load' handler, try opening the file locally. (Bug#9311)
578
579 2011-08-16 Ken Brown <kbrown@cornell.edu>
580
581 * gmalloc.c: Expand comment.
582
583 2011-08-16 Eli Zaretskii <eliz@gnu.org>
584
585 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
586 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
587
588 2011-08-16 Ken Brown <kbrown@cornell.edu>
589
590 Fix memory allocation problems in Cygwin build (Bug#9273).
591
592 * unexcw.c ( __malloc_initialized): Declare external variable.
593 (fixup_executable): Force the dumped emacs to reinitialize malloc.
594
595 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
596 New variables.
597 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
598 dumped emacs.
599 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
600 in the static heap.
601 [CYGWIN] (special_realloc): New function.
602 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
603 requests to realloc storage in the static heap.
604
605 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
606
607 * bidi.c (bidi_initialize): Remove unused local.
608
609 2011-08-15 Eli Zaretskii <eliz@gnu.org>
610
611 * biditype.h: File removed.
612
613 * bidimirror.h: File removed.
614
615 * deps.mk (bidi.o): Remove biditype.h and
616 bidimirror.h.
617
618 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
619 bidimirror.h.
620
621 * dispextern.h: Fix a typo in the comment to bidi_type_t.
622
623 * chartab.c: Improve commentary for the uniprop_table API.
624
625 * bidi.c (bidi_paragraph_init): Support zero value of
626 bidi_ignore_explicit_marks_for_paragraph_level.
627 (bidi_initialize): Use uniprop_table instead of including
628 biditype.h and bidimirror.h.
629
630 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
631 coordinates of the iterator when restoring from ppos_it.
632 (Bug#9296)
633
634 2011-08-14 Kenichi Handa <handa@m17n.org>
635
636 * process.c (create_process): Call setup_process_coding_systems
637 after the pid of the process is set to -1 (Bug#8162).
638
639 2011-08-14 Eli Zaretskii <eliz@gnu.org>
640
641 * xdisp.c (move_it_in_display_line_to): Don't invoke
642 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
643 ppos_it. Fixes vertical cursor motion when line beginning is
644 covered by an image. (Bug#9296)
645
646 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
647
648 * nsterm.h (ns_run_ascript): Declare.
649 (NSAPP_DATA2_RUNASSCRIPT): Define.
650
651 * nsfns.m (as_script, as_result, as_status): New static variables.
652 (ns_run_ascript): New function.
653 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
654 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
655 the event loop. Get status from as_status (Bug#7276).
656
657 * nsterm.m (sendEvent): If event is NSApplicationDefined and
658 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
659 the event loop (Bug#7276).
660
661 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
662
663 * gnutls.c (QCgnutls_bootprop_priority)
664 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
665 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
666 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
667 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
668 (QCgnutls_bootprop_verify_hostname_error)
669 (QCgnutls_bootprop_callbacks_verify): Rename from
670 Qgnutls_bootprop_..., all uses changed.
671
672 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
673 uses changed.
674
675 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
676
677 * xfaces.c (Qframe_set_background_mode): Now static.
678 * dispextern.h (Qframe_set_background_mode): Remove decl.
679
680 * process.c (Fnetwork_interface_info): Declare local only if needed.
681
682 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
683
684 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
685 (Fnetwork_interface_list): Allocate in increments of bytes instead
686 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
687 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
688 sockaddr.
689 (struct ifflag_def): notrailers is smart on OSX.
690 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
691 Get hardware address with getifaddrs if available.
692
693 2011-08-12 Eli Zaretskii <eliz@gnu.org>
694
695 * xdisp.c (iterate_out_of_display_property): xassert that
696 IT->position is set to within IT->object's boundaries. Break from
697 the loop as soon as EOB is reached; avoids infloops in redisplay
698 when IT->position is set up wrongly due to some bug.
699 Set IT->current to match the bidi iterator unconditionally.
700 (push_display_prop): Allow GET_FROM_STRING as IT->method on
701 entry. Force push_it to save on the stack the current
702 buffer/string position, to be restored by pop_it. Fix flags in
703 the iterator structure wrt the object coming from a display
704 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
705 properties. (Bug#9284)
706
707 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
708
709 * fontset.c (fontset_get_font_group): Add proper type checks.
710 (Bug#9172)
711
712 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
713
714 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
715 and LC_VERSION_MIN_MACOSX.
716 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
717 (dump_it) [LC_FUNCTION_STARTS]: Use it.
718
719 2011-08-08 Eli Zaretskii <eliz@gnu.org>
720
721 * xdisp.c (forward_to_next_line_start): Allow to use the
722 no-display-properties-and-no-overlays under bidi display.
723 Set disp_pos in the bidi iterator to avoid searches for display
724 properties and overlays.
725
726 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
727
728 * editfns.c (Fset_time_zone_rule): Document relationship with the
729 setenv function.
730
731 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
732 the font entity extracted from the cache (Bug#8109).
733
734 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
735
736 * composite.c (autocmp_chars): Don't reset point. That is done by
737 restore_point_unwind (Bug#5984).
738
739 2011-08-07 Juri Linkov <juri@jurta.org>
740
741 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
742 to show the arg `TIME' instead of `TIMEVAL'.
743
744 2011-08-06 Eli Zaretskii <eliz@gnu.org>
745
746 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
747 display property strides EOL and includes a newline, as in
748 longlines-mode. (Bug#9254)
749 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
750 word-wrap under bidirectional display. (Bug#9224)
751
752 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
753 is non-zero, even if the data buffer is NULL. Fixes a crash in
754 vertical-motion with longlines-mode. (Bug#9254)
755
756 2011-08-05 Eli Zaretskii <eliz@gnu.org>
757
758 * bidi.c <bidi_cache_total_alloc>: Now static.
759 (bidi_initialize): Initialize bidi_cache_total_alloc.
760
761 * xdisp.c (display_line): Release buffer allocated for shelved bidi
762 cache. (Bug#9221)
763
764 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
765 amount allocated this far in `bidi_cache_total_alloc'.
766 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
767 non-zero, only free the data buffer without restoring the cache
768 contents. All callers changed.
769
770 * dispextern.h (bidi_unshelve_cache): Update prototype.
771
772 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
773 (move_it_in_display_line, move_it_to)
774 (move_it_vertically_backward, move_it_by_lines): Replace the call
775 to xfree to an equivalent call to bidi_unshelve_cache.
776 (move_it_in_display_line_to): Fix logic of returning
777 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
778
779 2011-08-05 Eli Zaretskii <eliz@gnu.org>
780
781 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
782 came from a string character with a `cursor' property. (Bug#9229)
783
784 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
785
786 * Makefile.in (LIB_PTHREAD): New variable.
787 (LIBES): Add LIB_PTHREAD (Bug#9216).
788
789 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
790 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
791
792 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
793
794 * regex.c (re_iswctype): Remove some redundant boolean
795 conversions.
796
797 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
798
799 * xterm.c (x_find_topmost_parent): New function.
800 (x_set_frame_alpha): Find topmost parent window with
801 x_find_topmost_parent and set the property there also (bug#9181).
802 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
803
804 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
805
806 * callproc.c (Fcall_process): Avoid vfork clobbering
807 the local vars buffer, coding_systems, current_dir.
808
809 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
810
811 * keymap.c (Fmake_composed_keymap): Move to subr.el.
812
813 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
814
815 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
816 so that it is not optimized away.
817
818 * xdisp.c (compute_display_string_pos): Remove unused local.
819
820 2011-08-02 Eli Zaretskii <eliz@gnu.org>
821
822 Fix slow cursor motion and scrolling in large buffers with
823 selective display, like Org Mode buffers. (Bug#9218)
824
825 * dispextern.h (struct bidi_it): New member disp_prop_p.
826
827 * xdisp.c: Remove one-slot cache of display string positions.
828 (compute_display_string_pos): Accept an additional argument
829 DISP_PROP_P; callers changed. Scan at most 5K characters forward
830 for a display string or property. If found, set DISP_PROP_P
831 non-zero.
832
833 * bidi.c (bidi_fetch_char): Accept an additional argument
834 DISP_PROP_P, and pass it to compute_display_string_pos.
835 Only handle text covered by a display string if DISP_PROP_P is returned
836 non-zero. All callers of bidi_fetch_char changed.
837
838 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
839
840 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
841
842 2010-12-03 Don March <don@ohspite.net>
843
844 * keymap.c (Fdefine_key): Fix non-prefix key error message when
845 last character M-[char] is translated to ESC [char] (bug#7541).
846
847 2011-08-02 Kenichi Handa <handa@m17n.org>
848
849 * lisp.h (uniprop_table): Extern it.
850
851 * chartab.c (uniprop_table): Make it non-static.
852
853 2011-08-01 Eli Zaretskii <eliz@gnu.org>
854
855 * xdisp.c (forward_to_next_line_start): Accept additional argument
856 BIDI_IT_PREV, and store into it the state of the bidi iterator had
857 on the newline.
858 (reseat_at_next_visible_line_start): Use the bidi iterator state
859 returned by forward_to_next_line_start to restore the state of
860 it->bidi_it after backing up to previous newline. (Bug#9212)
861
862 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
863
864 * regex.c (re_comp): Protoize.
865 (re_exec): Fix return type.
866 (regexec): Fix type of `ret'. (Bug#9203)
867
868 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
869
870 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
871 This is needed if max-image-size is a floating-point number.
872
873 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
874
875 * print.c (print_object): Print empty symbol as ##.
876
877 * lread.c (read1): Read ## as empty symbol.
878
879 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
880
881 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
882 setting frame foreground color (Bug#9175).
883 (x_set_background_color): Likewise.
884
885 * nsmenu.m (-setText): Size tooltip dimensions precisely to
886 contents (Bug#9176).
887 (EmacsTooltip -init): Remove bezels and add shadows to
888 tooltip windows.
889
890 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
891 or scroll bar (Bug#8470).
892
893 * nsfont.m (nsfont_open): Remove assignment to voffset and
894 unnecessary vars hshink, expand, hd, full_height, min_height.
895 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
896
897 * nsterm.h (nsfont_info): Remove voffset field.
898
899 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
900
901 Implement strike-through and overline on NextStep (Bug#8863).
902
903 * nsfont.m (nsfont_open): Use underline position provided by font,
904 instead of hard-coded value of 2.
905 (nsfont_draw): Call ns_draw_text_decoration instead.
906
907 * nsterm.h: Add declaration for ns_draw_text_decoration.
908
909 * nsterm.m (ns_draw_text_decoration): New function for drawing
910 underline, overline, and strike-through.
911 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
912 ns_draw_text_decoration. Change treatment of cursor drawing to
913 accomodate underlining, etc.
914
915 2011-07-28 Eli Zaretskii <eliz@gnu.org>
916
917 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
918 default.
919
920 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
921
922 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
923 Without this fix, if a signal arrives just after memory fills up,
924 'malloc' might be invoked reentrantly.
925
926 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
927 In other words, assume that every image size is allowed, on non-X
928 hosts. This assumption is probably wrong, but it lets Emacs compile.
929
930 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
931
932 * regex.c (re_iswctype): Convert return values to boolean.
933
934 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
935
936 * xdisp.c (compute_display_string_pos): Don't use cached display
937 string position if the buffer had its restriction changed.
938 (Bug#9184)
939
940 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
941
942 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
943
944 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
945
946 Integer signedness and overflow and related fixes. (Bug#9079)
947
948 * bidi.c: Integer size and overflow fixes.
949 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
950 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
951 (bidi_cache_find_level_change, bidi_cache_ensure_space)
952 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
953 (bidi_find_other_level_edge):
954 Use ptrdiff_t instead of EMACS_INT where either will do.
955 This works better on 32-bit hosts configured --with-wide-int.
956 (bidi_cache_ensure_space): Check for size-calculation overflow.
957 Use % rather than repeated addition, for better worst-case speed.
958 Don't set bidi_cache_size until after xrealloc returns, because it
959 might not return.
960 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
961 (bidi_cache_ensure_space): Also check that the bidi cache size
962 does not exceed that of the largest Lisp string or buffer. See Eli
963 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
964
965 * alloc.c (__malloc_size_t): Remove.
966 All uses replaced by size_t. See Andreas Schwab's note
967 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
968
969 * image.c: Improve checking for integer overflow.
970 (check_image_size): Assume that f is nonnull, since
971 it is always nonnull in practice. This is one less thing to
972 worry about when checking for integer overflow later.
973 (x_check_image_size): New function, which checks for integer
974 overflow issues inside X.
975 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
976 This removes the need for a memory_full check.
977 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
978 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
979 (xbm_read_bitmap_data): Change locals back to 'int', since
980 their values must fit in 'int'.
981 (xpm_load_image, png_load, tiff_load):
982 Invoke x_create_x_image_and_pixmap earlier,
983 to avoid much needless work if the image is too large.
984 (tiff_load): Treat overly large images as if
985 x_create_x_image_and_pixmap failed, not as malloc failures.
986 (gs_load): Use x_check_image_size.
987
988 * gtkutil.c: Omit integer casts.
989 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
990 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
991
992 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
993
994 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
995 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
996 would wrongly return t on a 64-bit host.
997
998 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
999 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1000 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1001 and therefore cause GCC to emit a bogus diagnostic in some cases.
1002
1003 * image.c: Integer signedness and overflow and related fixes.
1004 This is not an exhaustive set of fixes, but it's time to
1005 record what I've got.
1006 (lookup_pixel_color, check_image_size): Remove redundant decls.
1007 (check_image_size): Don't assume that arbitrary EMACS_INT values
1008 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1009 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1010 (tiff_load, imagemagick_load_image):
1011 Check for overflow in size calculations.
1012 (x_create_x_image_and_pixmap): Remove unnecessary test for
1013 xmalloc returning NULL; that can't happen.
1014 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1015 (xpm_color_bucket): Use better integer hashing function.
1016 (xpm_cache_color): Don't possibly over-allocate memory.
1017 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1018 (gif_memory_source):
1019 Use ptrdiff_t, not int or size_t, to record sizes.
1020 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1021 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1022 either works, as we prefer signed integers.
1023 (tiff_read_from_memory, tiff_write_from_memory):
1024 Return tsize_t, not size_t, since that's what the TIFF API wants.
1025 (tiff_read_from_memory): Don't fail simply because the read would
1026 go past EOF; instead, return a short read.
1027 (tiff_load): Omit no-longer-needed casts.
1028 (Fimagemagick_types): Don't assume size fits into 'int'.
1029
1030 Improve hashing quality when configured --with-wide-int.
1031 * fns.c (hash_string): New function, taken from sxhash_string.
1032 Do not discard information about ASCII character case; this
1033 discarding is no longer needed.
1034 (sxhash-string): Use it. Change sig to match it. Caller changed.
1035 * lisp.h: Declare it.
1036 * lread.c (hash_string): Remove, since we now use fns.c's version.
1037 The fns.c version returns a wider integer if --with-wide-int is
1038 specified, so this should help the quality of the hashing a bit.
1039
1040 * emacs.c: Integer overflow minor fix.
1041 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1042 Define only if GNU_LINUX.
1043 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1044
1045 * dispnew.c: Integer signedness and overflow fixes.
1046 Remove unnecessary forward decls, that were a maintenance hassle.
1047 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1048 All uses changed.
1049 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1050 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1051 (prepare_desired_row, line_draw_cost):
1052 Use int, not unsigned, where either works.
1053 (save_current_matrix, restore_current_matrix):
1054 Use ptrdiff_t, not size_t, where either works.
1055 (init_display): Check for overflow more accurately, and without
1056 relying on undefined behavior.
1057
1058 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1059 Remove, replacing with the new symbols in lisp.h. All uses changed.
1060 * fileio.c (make_temp_name):
1061 * filelock.c (lock_file_1, lock_file):
1062 * xdisp.c (message_dolog):
1063 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1064 Use pMd etc. instead.
1065 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1066 replacing the pWIDE etc. symbols removed from editfns.c.
1067
1068 * keyboard.h (num_input_events): Now uintmax_t.
1069 This is (very slightly) less likely to mess up due to wraparound.
1070 All uses changed.
1071
1072 * buffer.c: Integer signedness fixes.
1073 (alloc_buffer_text, enlarge_buffer_text):
1074 Use ptrdiff_t rather than size_t when either will do, as we prefer
1075 signed integers.
1076
1077 * alloc.c: Integer signedness and overflow fixes.
1078 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1079 (__malloc_size_t): Default to size_t, not to int.
1080 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1081 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1082 Prefer ptrdiff_t to size_t when either would do, as we prefer
1083 signed integers.
1084 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1085 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1086 Now const. Initialize with values that are in range even if char
1087 is signed.
1088 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1089 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1090 These functions do the right thing with sizes > 2**32.
1091 (check_depth): Now ptrdiff_t, not int.
1092 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1093 Adjust to new way of storing sizes. Check for size overflow bugs
1094 in rest of code.
1095 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1096 slightly wrong anyway, as it missed one instance of
1097 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1098 (refill_memory_reserve): Omit needless cast to size_t.
1099 (mark_object_loop_halt): Mark as externally visible.
1100
1101 * xselect.c: Integer signedness and overflow fixes.
1102 (Fx_register_dnd_atom, x_handle_dnd_message):
1103 Use ptrdiff_t, not size_t, since we prefer signed.
1104 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1105 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1106 x_dnd_atoms_size and x_dnd_atoms_length.
1107
1108 * doprnt.c: Prefer signed to unsigned when either works.
1109 * eval.c (verror):
1110 * doprnt.c (doprnt):
1111 * lisp.h (doprnt):
1112 * xdisp.c (vmessage):
1113 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1114 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1115 prefer signed arithmetic to avoid comparison confusion.
1116 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1117 but is a bit tricky.
1118
1119 Assume freestanding C89 headers, string.h, stdlib.h.
1120 * data.c, doprnt.c, floatfns.c, print.c:
1121 Include float.h unconditionally.
1122 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1123 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1124 * regex.c: Likewise for stddef.h, string.h.
1125 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1126 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1127 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1128 (STDC_HEADERS): Remove obsolete defines.
1129 * sysdep.c: Include limits.h unconditionally.
1130
1131 Assume support for memcmp, memcpy, memmove, memset.
1132 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1133 * regex.c (memcmp, memcpy):
1134 Remove; we assume C89 now.
1135
1136 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1137 (__malloc_safe_bcopy): Remove; no longer needed.
1138
1139 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1140 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1141 well either way, and we prefer signed to unsigned.
1142
1143 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1144
1145 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1146 closes the connection while we're reading (bug#9182).
1147
1148 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1149
1150 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1151 are specified (Bug#9168).
1152
1153 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1154
1155 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1156 Found by GCC static checking and --with-wide-int on a 32-bit host.
1157
1158 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1159
1160 * xdisp.c (compute_display_string_pos): Fix logic of caching
1161 previous display string position. Initialize cached_prev_pos to
1162 -1. Fixes slow-down at the beginning of a buffer.
1163
1164 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1165
1166 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1167 for attrs[LFACE_FONTSET_INDEX].
1168
1169 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 * xml.c (parse_region): Remove unused local
1172 that was recently introduced.
1173
1174 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1175
1176 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1177 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1178
1179 * xdisp.c (move_it_in_display_line_to): Record the best matching
1180 position for TO_CHARPOS while scanning the line, and restore it on
1181 exit if none of the characters scanned was an exact match.
1182 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1183 when exact match is impossible due to invisible text, and the
1184 lines are truncated.
1185
1186 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1187
1188 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1189 for OSX >= 10.7.
1190
1191 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1192
1193 Fix a significant slow-down of cursor motion with C-n, C-p,
1194 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1195 auto-repeat under bidi redisplay in fontified buffers.
1196 * xdisp.c (compute_stop_pos_backwards): New function.
1197 (next_element_from_buffer): Call compute_stop_pos_backwards to
1198 find a suitable prev_stop when we find ourselves before
1199 base_level_stop.
1200 (reseat): Don't look for prev_stop, as that could mean a very long
1201 run.
1202 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1203 <cached_disp_overlay_modiff>: Cache for last found display string
1204 position.
1205 (compute_display_string_pos): Return the cached position if asked
1206 about the same buffer in the same area of character positions, and
1207 the buffer wasn't changed since the time the display string
1208 position was cached.
1209
1210 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1211
1212 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1213 is an integer, which is important for empty lines. (Bug#9149)
1214
1215 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1216
1217 * frame.c (Fmodify_frame_parameters): In tty case, update the
1218 default face if necessary (Bug#4238).
1219
1220 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1221
1222 * editfns.c (Fstring_to_char): No need to explain what a character
1223 is in the docstring (Bug#6576).
1224
1225 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1226
1227 * xml.c (parse_region): Make sure we always return a tree.
1228
1229 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1230
1231 * xml.c (parse_region): If a document contains only comments,
1232 return that, too.
1233
1234 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1235
1236 * xml.c (make_dom): Return comments, too.
1237
1238 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1239
1240 Port to OpenBSD.
1241 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1242 and the surrounding thread.
1243 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1244 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1245 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1246 timer goes off.
1247 * s/openbsd.h (BROKEN_SIGIO): Define.
1248 * unexelf.c (unexec) [__OpenBSD__]:
1249 Don't update the .mdebug section of the Alpha COFF symbol table.
1250
1251 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1252
1253 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1254 (bug#8460).
1255
1256 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1257
1258 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1259 This fixes some race conditions on the permissions of any newly
1260 created file.
1261
1262 * alloc.c (valid_pointer_p): Use pipe, not open.
1263 This fixes some permissions issues when debugging.
1264
1265 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1266 If fchown fails to set both uid and gid, try to set just gid,
1267 as that is sometimes allowed. Adjust the file's mode to eliminate
1268 setuid or setgid bits that are inappropriate if fchown fails.
1269
1270 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1271
1272 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1273 to compare Lisp_Objects.
1274 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1275 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1276 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1277
1278 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1279
1280 * lread.c (read_integer): Unread even EOF character.
1281 (read1): Likewise. Properly record start position of symbol.
1282
1283 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1284 symbol character follows.
1285
1286 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1287
1288 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1289 This works around a problem with the previous change to Fcopy_file.
1290 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1291 and without this change, GCC might complain about discarding
1292 fchown's return value.
1293
1294 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1295
1296 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1297
1298 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1299
1300 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1301
1302 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1303
1304 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1305 it's used from the C level.
1306
1307 * process.c: Use the same condition for POLL_FOR_INPUT in both
1308 keyboard.c and process.c (bug#1858).
1309
1310 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1311
1312 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1313 (Fgnutls_boot): Use it.
1314
1315 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1316
1317 * doc.c (Fsubstitute_command_keys): Revert last change.
1318
1319 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1320
1321 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1322 quotes the next character, and doesn't affect other longer
1323 sequences (bug#8935).
1324
1325 * lread.c (syms_of_lread): Clarify that is isn't only
1326 `eval-buffer' and `eval-defun' that's affected by
1327 `lexical-binding' (bug#8460).
1328
1329 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1330
1331 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1332 bidi redisplay when a line includes both an image and is
1333 truncated.
1334
1335 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1336
1337 Fix minor problems found by static checking.
1338 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1339 (elsz): Now a signed constant, not a size_t var. We prefer signed
1340 types to unsigned, to avoid integer comparison confusion. Without
1341 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1342 "cannot optimize loop, the loop counter may overflow", a symptom
1343 of the confusion.
1344 * indent.c (Fvertical_motion): Mark locals as initialized.
1345 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1346
1347 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1348
1349 * search.c (Fre_search_backward): Mention `case-fold-search' in
1350 all the re_search_* functions (bug#8138).
1351
1352 * keyboard.c (Fopen_dribble_file): Document when the file is
1353 closed (bug#8056).
1354
1355 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1356
1357 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1358 bidi_cache_idx.
1359
1360 Support bidi reordering of display and overlay strings.
1361 * xdisp.c (compute_display_string_pos)
1362 (compute_display_string_end): Accept additional argument STRING.
1363 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1364 (reseat_to_string): Initialize bidi_it->string.s and
1365 bidi_it->string.schars.
1366 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1367 NULL (avoids a crash in bidi_paragraph_init).
1368 Initialize itb.string.lstring.
1369 (init_iterator): Call bidi_init_it only of a valid
1370 buffer position was specified. Initialize paragraph_embedding to
1371 L2R.
1372 (reseat_to_string): Initialize the bidi iterator.
1373 (display_string): If we need to ignore text properties of
1374 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1375 original value of -1 will not work with bidi.)
1376 (compute_display_string_pos): First arg is now struct
1377 `text_pos *'; all callers changed. Support display properties on
1378 Lisp strings.
1379 (compute_display_string_end): Support display properties on Lisp
1380 strings.
1381 (init_iterator, reseat_1, reseat_to_string): Initialize the
1382 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1383 when iterating on a string not from display properties).
1384 (compute_display_string_pos, compute_display_string_end):
1385 Fix calculation of the object to scan. Fixes an error when using
1386 arrow keys.
1387 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1388 base_level_stop; instead, set base_level_stop to BEGV.
1389 Fixes crashes in vertical-motion.
1390 (next_element_from_buffer): Improve commentary for when
1391 the iterator is before prev_stop.
1392 (init_iterator): Initialize bidi_p from the default value of
1393 bidi-display-reordering, not from buffer-local value. Use the
1394 buffer-local value only if initializing for buffer iteration.
1395 (handle_invisible_prop): Support invisible properties on strings
1396 that are being bidi-reordered.
1397 (set_iterator_to_next): Support bidi reordering of C strings and
1398 Lisp strings.
1399 (next_element_from_string): Support bidi reordering of Lisp
1400 strings.
1401 (handle_stop_backwards): Support Lisp strings as well.
1402 (display_string): Support display of R2L glyph rows.
1403 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1404 (init_iterator): Don't initialize it->bidi_p for strings
1405 here.
1406 (reseat_to_string): Initialize it->bidi_p for strings here.
1407 (next_element_from_string, next_element_from_c_string)
1408 (next_element_from_buffer): Add xassert's for correspondence
1409 between IT's object being iterated and it->bidi_it.string
1410 structure.
1411 (face_before_or_after_it_pos): Support bidi iteration.
1412 (next_element_from_c_string): Handle the case of the first string
1413 character that is not the first one in the visual order.
1414 (get_visually_first_element): New function, refactored from common
1415 parts of next_element_from_buffer, next_element_from_string, and
1416 next_element_from_c_string.
1417 (tool_bar_lines_needed, redisplay_tool_bar)
1418 (display_menu_bar): Force left-to-right direction. Add a FIXME
1419 comment for making that be controlled by a user option.
1420 (push_it, pop_it): Save and restore the state of the
1421 bidi iterator. Save and restore the bidi_p flag.
1422 (pop_it): Iterate out of display property for string iteration as
1423 well.
1424 (iterate_out_of_display_property): Support iteration over strings.
1425 (handle_single_display_spec): Set up it->bidi_it for iteration
1426 over a display string, and call bidi_init_it.
1427 (handle_single_display_spec, next_overlay_string)
1428 (get_overlay_strings_1, push_display_prop): Set up the bidi
1429 iterator for displaying display or overlay strings.
1430 (forward_to_next_line_start): Don't use the shortcut if
1431 bidi-iterating.
1432 (back_to_previous_visible_line_start): If handle_display_prop
1433 pushed the iterator stack, restore the internal state of the bidi
1434 iterator by calling bidi_pop_it same number of times.
1435 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1436 and we are bidi-iterating, don't decrement the iterator position;
1437 instead, set the first_elt flag in the bidi iterator, to produce
1438 the same effect.
1439 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1440 (push_display_prop): xassert that we are iterating a buffer.
1441 (push_it, pop_it): Save and restore paragraph_embedding member.
1442 (handle_single_display_spec, next_overlay_string)
1443 (get_overlay_strings_1, reseat_1, reseat_to_string)
1444 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1445 correctly. Don't assume unibyte strings are not bidi-reordered.
1446 (compute_display_string_pos)
1447 (compute_display_string_end): Fix handling the case of C string.
1448 (push_it, pop_it): Save and restore from_disp_prop_p.
1449 (handle_single_display_spec, push_display_prop): Set the
1450 from_disp_prop_p flag.
1451 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1452 (pop_it): Call iterate_out_of_display_property only if we are
1453 popping after iteration over a string that came from a display
1454 property. Fix a typo in popping stretch info. Add an assertion
1455 for verifying that the iterator position is in sync with the bidi
1456 iterator.
1457 (handle_single_display_spec, get_overlay_strings_1)
1458 (push_display_prop): Fix initialization of paragraph direction for
1459 string when that of the parent object is not yet determined.
1460 (reseat_1): Call bidi_init_it to resync the bidi
1461 iterator with IT's position. (Bug#7616)
1462 (find_row_edges): If ROW->start.pos gives position
1463 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1464 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1465 Reset the from_disp_prop_p flag.
1466 (SAVE_IT, RESTORE_IT): New macros.
1467 (pos_visible_p, face_before_or_after_it_pos)
1468 (back_to_previous_visible_line_start)
1469 (move_it_in_display_line_to, move_it_in_display_line)
1470 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1471 (try_scrolling, redisplay_window, display_line): Use them when
1472 saving a temporary copy of the iterator and restoring it back.
1473 (back_to_previous_visible_line_start, reseat_1)
1474 (init_iterator): Empty the bidi cache "stack".
1475 (move_it_in_display_line_to): If iterator ended up at
1476 EOL, but we never saw any buffer positions smaller than
1477 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1478 motion in bidi-reordered lines.
1479 (move_it_in_display_line_to): Record prev_method and prev_pos
1480 immediately before the call to set_iterator_to_next. Fixes cursor
1481 motion in bidi-reordered lines with stretch glyphs and strings
1482 displayed in margins. (Bug#8133) (Bug#8867)
1483 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1484 TO_CHARPOS.
1485 (pos_visible_p): Support positions in bidi-reordered lines.
1486 Save and restore bidi cache.
1487
1488 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1489 (bidi_paragraph_info): Delete unused struct.
1490 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1491 (bidi_cache_start): New variable.
1492 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1493 to zero.
1494 (bidi_cache_fetch_state, bidi_cache_search)
1495 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1496 (bidi_cache_find, bidi_peek_at_next_level)
1497 (bidi_level_of_next_char, bidi_find_other_level_edge)
1498 (bidi_move_to_visually_next): Compare cache index with
1499 bidi_cache_start rather than with zero.
1500 (bidi_fetch_char): Accept new argument STRING; all callers
1501 changed. Support iteration over a string. Support strings with
1502 display properties. Support unibyte strings. Fix the type of
1503 `len' according to what STRING_CHAR_AND_LENGTH expects.
1504 (bidi_paragraph_init, bidi_resolve_explicit_1)
1505 (bidi_resolve_explicit, bidi_resolve_weak)
1506 (bidi_level_of_next_char, bidi_move_to_visually_next):
1507 Support iteration over a string.
1508 (bidi_set_sor_type, bidi_resolve_explicit_1)
1509 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1510 can now be zero (for strings); special values 0 and -1 were
1511 changed to -1 and -2, respectively.
1512 (bidi_char_at_pos): New function.
1513 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1514 Call it instead of FETCH_MULTIBYTE_CHAR.
1515 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1516 initialized to valid values.
1517 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1518 values.
1519 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1520 the test for valid cached positions. Fix the logic for looking up
1521 the sentinel state in the cache. GCPRO the Lisp string we are
1522 iterating.
1523 (bidi_push_it, bidi_pop_it): New functions.
1524 (bidi_initialize): Initialize the bidi cache start stack pointer.
1525 (bidi_cache_ensure_space): New function, refactored from part of
1526 bidi_cache_iterator_state. Don't assume the required size is just
1527 one BIDI_CACHE_CHUNK away.
1528 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1529 (bidi_count_bytes, bidi_char_at_pos): New functions.
1530 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1531 always valid if bidi_cache_idx is valid.
1532 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1533 is valid if it's going to be used.
1534 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1535 (bidi_cache_fetch_state, bidi_cache_search)
1536 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1537 (bidi_cache_iterator_state, bidi_cache_find)
1538 (bidi_find_other_level_edge, bidi_cache_start_stack):
1539 All variables related to cache indices are now EMACS_INT.
1540
1541 * dispextern.h (struct bidi_string_data): New structure.
1542 (struct bidi_it): New member `string'. Make flag members be 1-bit
1543 fields, and put them last in the struct.
1544 (compute_display_string_pos, compute_display_string_end):
1545 Update prototypes.
1546 (bidi_push_it, bidi_pop_it): Add prototypes.
1547 (struct iterator_stack_entry): New members bidi_p,
1548 paragraph_embedding, and from_disp_prop_p.
1549 (struct it): Member bidi_p is now a bit field 1 bit wide.
1550 (bidi_shelve_cache, bidi_unshelve_cache):
1551 Declare prototypes.
1552
1553 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1554 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1555 and vector-like objects.
1556
1557 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1558 cache around display iteration.
1559
1560 * window.c (Fwindow_end, window_scroll_pixel_based)
1561 (displayed_window_lines, Frecenter): Save and restore the bidi
1562 cache around display iteration.
1563
1564 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1565
1566 * editfns.c (Fdelete_region): Clarify the use of the named
1567 parameters (bug#6788).
1568
1569 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1570
1571 * indent.c (Fvertical_motion): Set and restore w->pointm when
1572 saving and restoring the window's buffer (Bug#9006).
1573
1574 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1575
1576 * editfns.c (Fstring_to_char): Clarify just what is returned
1577 (bug#6576). Text by Eli Zaretskii.
1578
1579 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1580
1581 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1582
1583 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1584
1585 * buffer.c (mmap_find): Fix a typo.
1586
1587 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1588
1589 Fix execution of x selection hooks.
1590 * xselect.c (Qx_lost_selection_functions)
1591 (Qx_sent_selection_functions): New vars.
1592 (syms_of_xselect): DEFSYM them.
1593 (x_handle_selection_request): Pass Qx_sent_selection_functions
1594 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1595 (x_handle_selection_clear,x_clear_frame_selections):
1596 Pass Qx_lost_selection_functions rather than
1597 Vx_lost_selection_functions to Frun_hook_with_args.
1598
1599 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1600
1601 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1602 The old code sometimes used this field without initializing it.
1603
1604 * alloc.c (gc_sweep): Don't read past end of array.
1605 In theory, the old code could also have corrupted Emacs internals,
1606 though it'd be very unlikely.
1607
1608 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1609
1610 * character.c (Fcharacterp): Don't advertise optional ignored
1611 argument. (Bug#4026)
1612
1613 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1614
1615 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1616 key" (bug#4257).
1617
1618 * window.c (Fset_window_start): Doc fix (bug#4199).
1619 (Fset_window_hscroll): Ditto.
1620
1621 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1622
1623 Fix minor new problems caught by GCC 4.6.1.
1624 * term.c (init_tty): Remove unused local.
1625 * xsettings.c (store_monospaced_changed): Define this function only
1626 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1627 not used otherwise.
1628
1629 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1630
1631 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1632
1633 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1634
1635 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1636 are the mini-buffer and the echo area (bug#3320).
1637
1638 * term.c (init_tty): Remove support for supdup, c10 and perq
1639 terminals, which are no longer supported (bug#1482).
1640
1641 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1642
1643 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1644
1645 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1646
1647 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1648 for non-popups (Bug#3642).
1649
1650 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1651
1652 * alloc.c (reset_malloc_hooks): Protoize.
1653 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1654 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1655 * cm.c (losecursor): Likewise.
1656 * data.c (fmod): Likewise.
1657 * dispnew.c (swap_glyphs_in_rows): Likewise.
1658 * emacs.c (memory_warning_signal): Likewise.
1659 * floatfns.c (float_error): Likewise.
1660 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1661 (otf_open, font_otf_capability, generate_otf_features)
1662 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1663 Likewise.
1664 * image.c (pbm_read_file): Likewise.
1665 * indent.c (string_display_width): Likewise.
1666 * intervals.c (check_for_interval, search_for_interval)
1667 (inc_interval_count, count_intervals, root_interval)
1668 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1669 * lread.c (defalias): Likewise.
1670 * ralloc.c (r_alloc_check): Likewise.
1671 * regex.c (set_image_of_range_1, set_image_of_range)
1672 (regex_grow_registers): Likewise.
1673 * sysdep.c (strerror): Likewise.
1674 * termcap.c (valid_filename_p, tprint, main): Likewise.
1675 * tparam.c (main): Likewise.
1676 * unexhp9k800.c (run_time_remap, save_data_space)
1677 (update_file_ptrs, read_header, write_header, calculate_checksum)
1678 (copy_file, copy_rest, display_header): Likewise.
1679 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1680 Likewise.
1681 * xdisp.c (check_it): Likewise.
1682 * xfaces.c (register_color, unregister_color, unregister_colors):
1683 Likewise.
1684 * xfns.c (print_fontset_result): Likewise.
1685 * xrdb.c (member, fatal, main): Likewise.
1686
1687 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1688
1689 Fix minor problems found by static checking (Bug#9031).
1690 * chartab.c (char_table_set_range, map_sub_char_table):
1691 Remove unused locals.
1692 (uniprop_table): Now static.
1693 * composite.c (_work_char): Remove unused static var.
1694
1695 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1696
1697 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1698
1699 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1700
1701 * gtkutil.c (qttip_cb): Remove code without function.
1702
1703 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1704
1705 * w32.c (pthread_sigmask): New stub.
1706
1707 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 Use pthread_sigmask, not sigprocmask (Bug#9010).
1710 sigprocmask is portable only for single-threaded applications, and
1711 Emacs can be multi-threaded when it uses GTK.
1712 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1713 (LIBES): Use it.
1714 * callproc.c (Fcall_process):
1715 * process.c (create_process):
1716 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1717 Use pthread_sigmask, not sigprocmask.
1718
1719 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1720
1721 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1722 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1723 wrong (Bug#8591).
1724
1725 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1726
1727 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1728 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1729 (xg_hide_tooltip): Fix comment.
1730
1731 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1732 in registerServicesMenuSendTypes.
1733 (validRequestorForSendType): Don't check ns_return_types.
1734
1735 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1736 ns_return_type.
1737
1738 2011-07-08 Jason Rumney <jasonr@gnu.org>
1739
1740 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1741 frame struct members of non-existent frames (Bug#6284).
1742
1743 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1744
1745 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1746 variable firstTime not needed on OSX >= 10.6.
1747 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1748 >= 10.5. Use setKnobProportion, setDoubleValue.
1749
1750 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1751 (MAC_OS_X_VERSION_10_5): Define if not defined.
1752 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1753 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1754 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1755
1756 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1757 cString and lossyCString on OSX >= 10.4
1758
1759 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1760 sizeToFit on OSX >= 10.2.
1761
1762 * nsimage.m (allocInitFromFile): Don't use deprecated method
1763 bestRepresentationForDevice on OSX >= 10.6.
1764
1765 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1766 to avoid warning.
1767
1768 * emacs.c: Declare unexec_init_emacs_zone.
1769
1770 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1771
1772 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1773
1774 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1775 on svcsMenu (Bug#8842).
1776
1777 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1778 ns_return_types.
1779 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1780
1781 * nsterm.m (QUTF8_STRING): Declare.
1782 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1783 (validRequestorForSendType): Return type is (id).
1784 Change indexOfObjectIdenticalTo to indexOfObject.
1785 Check if we have local selection before returning self (Bug#8842).
1786 (writeSelectionToPasteboard): Put local selection into paste board
1787 if we have a local selection (Bug#8842).
1788 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1789
1790 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1791 (ns_get_local_selection): Declare.
1792
1793 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1794
1795 * keymap.c (describe_map_tree): Don't insert a double newline at
1796 the end of the buffer (bug#1169) and return whether we inserted
1797 something.
1798
1799 * callint.c (Fcall_interactively): Change "reading args" to
1800 "providing args" to try to clarify what it does (bug#1010).
1801
1802 2011-07-07 Kenichi Handa <handa@m17n.org>
1803
1804 * composite.c (composition_compute_stop_pos): Ignore a static
1805 composition starting before CHARPOS (Bug#8915).
1806
1807 * xdisp.c (handle_composition_prop): Likewise.
1808
1809 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1810
1811 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1812 (Bug#9015)
1813
1814 2011-07-07 Kenichi Handa <handa@m17n.org>
1815
1816 * character.h (unicode_category_t): New enum type.
1817
1818 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1819 (Qchar_code_property_table): New variable.
1820 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1821 (UNIPROP_COMPRESSED_FORM_P): New macros.
1822 (char_table_ascii): Uncompress the compressed values.
1823 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1824 Uncompress the compressed values.
1825 (sub_char_table_ref_and_range): Likewise.
1826 (char_table_ref_and_range): Uncompress the compressed values.
1827 (sub_char_table_set): New arg is_uniprop. Callers changed.
1828 Uncompress the compressed values.
1829 (sub_char_table_set_range): Args changed. Callers changed.
1830 (char_table_set_range): Adjuted for the above change.
1831 (map_sub_char_table): Delete args default_val and parent. Add arg
1832 top. Give decoded values to a Lisp function.
1833 (map_char_table): Adjust for the above change. Give decoded
1834 values to a Lisp function. Gcpro more variables.
1835 (uniprop_table_uncompress)
1836 (uniprop_decode_value_run_length): New functions.
1837 (uniprop_decoder, uniprop_decoder_count): New variables.
1838 (uniprop_get_decoder, uniprop_encode_value_character)
1839 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1840 New functions.
1841 (uniprop_encoder, uniprop_encoder_count): New variables.
1842 (uniprop_get_encoder, uniprop_table)
1843 (Funicode_property_table_internal, Fget_unicode_property_internal)
1844 (Fput_unicode_property_internal): New functions.
1845 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1846 Sunicode_property_table_internal, Sget_unicode_property_internal,
1847 and Sput_unicode_property_internal. Defvar_lisp
1848 char-code-property-alist.
1849
1850 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1851 Vunicode_category_table.
1852
1853 * font.c (font_range): Adjust for the change of
1854 Vunicode_category_table.
1855
1856 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1857
1858 * m/iris4d.h: Remove file, move contents ...
1859 * s/irix6-5.h: ... here.
1860
1861 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 Remove unportable assumption about struct layout (Bug#8884).
1864 * alloc.c (mark_buffer):
1865 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1866 (clone_per_buffer_values): Don't assume that
1867 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1868 This isn't true in general, and it's particularly not true
1869 if Emacs is configured with --with-wide-int.
1870 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1871 New macros, used in the buffer.c change.
1872
1873 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1874
1875 * xsettings.c: Use both GConf and GSettings if both are available.
1876 (store_config_changed_event): Add comment.
1877 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1878 (store_tool_bar_style_changed): New functions.
1879 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1880 (struct xsettings): Move font inside HAVE_XFT.
1881 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1882 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1883 Move inside HAVE_XFT.
1884 (something_changed_gsettingsCB): Rename from something_changedCB.
1885 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1886 also.
1887 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1888 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1889 (something_changed_gconfCB): Rename from something_changedCB.
1890 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1891 (parse_settings): Move check for font inside HAVE_XFT.
1892 (read_settings, apply_xft_settings): Add comment.
1893 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1894 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1895 call store_font_name_changed.
1896 (xft_settings_event): Add comment.
1897 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1898 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1899 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1900 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1901 (xsettings_initialize): Call init_gsettings last.
1902 (xsettings_get_system_font, xsettings_get_system_normal_font):
1903 Add comment.
1904
1905 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1906
1907 Random fixes. E.g., (random) never returned negative values.
1908 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1909 subseconds part to the entropy, as that's a bit more random.
1910 Prefer signed to unsigned, since the signedness doesn't matter and
1911 in general we prefer signed. When given a limit, use a
1912 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1913 latter isn't right if USE_2_TAGS_FOR_INTS.
1914 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1915 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1916
1917 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1918
1919 * textprop.c (text_property_stickiness):
1920 Obey Vtext_property_default_nonsticky.
1921 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1922 * w32fns.c (syms_of_w32fns):
1923 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1924
1925 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1928 This is more efficient than Ffile_directory_p and avoids a minor race.
1929
1930 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1931
1932 * buffer.c (Foverlay_put): Say what the return value is
1933 (bug#7835).
1934
1935 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1936 is a directory before asking whether to use the file name
1937 (bug#7564).
1938 (barf_or_query_if_file_exists): Make the "File is a directory"
1939 error be more correct.
1940
1941 * fns.c (Frequire): Remove the mention of the .gz files, since
1942 that's installation-specific, but keep the mention of
1943 `get-load-suffixes'.
1944
1945 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1946
1947 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1948 Report string overflow if the output is too long.
1949
1950 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1951
1952 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1953 (syms_of_gnutls): Remove duplicate DEFSYM for
1954 Qgnutls_bootprop_verify_hostname_error, an error for
1955 Qgnutls_bootprop_verify_error (which is no longer used).
1956
1957 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1958 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1959 Also (re)move comments that are misplaced or no longer relevant.
1960
1961 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1962
1963 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1964
1965 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1966
1967 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1968 and background color parameters if they have been changed.
1969
1970 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1971
1972 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1973
1974 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1975
1976 * xsettings.c (SYSTEM_FONT): Define only when used.
1977 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1978
1979 * keymap.c (access_keymap_1): Now static.
1980
1981 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1982
1983 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1984 leave any prefix arg for the up event (Bug#1586).
1985
1986 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1987
1988 * lread.c (syms_of_lread): Mention single symbols defined by
1989 `defvar' or `defconst' (bug#7154).
1990
1991 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1992 (Frequire): Mention get-load-suffixes.
1993
1994 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1995
1996 * window.h (window): Remove clone_number slot.
1997 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1998 Remove.
1999 (make_parent_window, make_window, saved_window)
2000 (Fset_window_configuration, save_window_save): Don't deal with
2001 clone numbers.
2002 * buffer.c (Qclone_number): Remove declaration.
2003 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2004
2005 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2006
2007 Add multiple inheritance to keymaps.
2008 * keymap.c (Fmake_composed_keymap): New function.
2009 (Fset_keymap_parent): Simplify.
2010 (fix_submap_inheritance): Remove.
2011 (access_keymap_1): New function extracted from access_keymap to handle
2012 embedded parents and handle lists of maps.
2013 (access_keymap): Use it.
2014 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2015 (Fcopy_keymap): Handle embedded parents.
2016 (Fcommand_remapping, define_as_prefix): Simplify.
2017 (Fkey_binding): Simplify.
2018 (syms_of_keymap): Move minibuffer-local-completion-map,
2019 minibuffer-local-filename-completion-map,
2020 minibuffer-local-must-match-map, and
2021 minibuffer-local-filename-must-match-map to Elisp.
2022 (syms_of_keymap): Defsubr make-composed-keymap.
2023 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2024 (parse_menu_item): Trivial simplification.
2025
2026 2011-07-01 Glenn Morris <rgm@gnu.org>
2027
2028 * Makefile.in (SETTINGS_LIBS): Fix typo.
2029
2030 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2031
2032 * coding.c (Fencode_coding_string): Record the last coding system
2033 used, as the function doc string says (bug#8738).
2034
2035 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2036
2037 * xsettings.c (store_monospaced_changed): Take new font as arg and
2038 check for change against current_mono_font.
2039 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2040 (emacs_settings_constructor, emacs_settings_get_property)
2041 (emacs_settings_set_property, emacs_settings_class_init)
2042 (emacs_settings_init, gsettings_obj): Remove.
2043 (something_changedCB): New function for HAVE_GSETTINGS.
2044 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2045 with value as argument.
2046 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2047 g_settings_new (Bug#8967). Do not create gsettings_obj.
2048 Remove calls to g_settings_bind. Connect something_changedCB to
2049 "changed".
2050
2051 * xgselect.c: Add defined (HAVE_GSETTINGS).
2052 (xgselect_initialize): Ditto.
2053
2054 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2055 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2056 xg_select.
2057
2058 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2059
2060 * eval.c (struct backtrace): Simplify and port the data structure.
2061 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2062 signed bit field, as this assumption is not portable and it makes
2063 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2064 "char debug_on_exit : 1" as this is not portable either; instead,
2065 use the portable "unsigned int debug_on_exit : 1". Remove unused
2066 member evalargs. Remove obsolete comments about cc bombing out.
2067
2068 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2069
2070 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2071 Let HAVE_GSETTINGS override HAVE_GCONF.
2072 (store_monospaced_changed): New function.
2073 (EMACS_SETTINGS): A new type derived from GObject to handle
2074 GSettings notifications.
2075 (emacs_settings_constructor, emacs_settings_get_property)
2076 (emacs_settings_set_property, emacs_settings_class_init):
2077 New functions.
2078 (gsettings_client, gsettings_obj): New variables.
2079 (GSETTINGS_SCHEMA): New define.
2080 (something_changedCB): Call store_monospaced_changed.
2081 (init_gsettings): New function.
2082 (xsettings_initialize): Call init_gsettings.
2083 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2084 to NULL.
2085
2086 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2087 GCONF_CFLAGS/LIBS.
2088
2089 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2090
2091 * window.c (resize_root_window, grow_mini_window)
2092 (shrink_mini_window): Rename Qresize_root_window to
2093 Qwindow_resize_root_window and Qresize_root_window_vertically to
2094 Qwindow_resize_root_window_vertically.
2095
2096 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2097
2098 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2099
2100 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2101
2102 * makefile.w32-in: Redesign dependencies so they reflect more
2103 clearly which files are directly included by each source file,
2104 and not through other includes.
2105
2106 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2107
2108 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2109 (sort_overlays, overlay_strings): When an overlay's clone number
2110 matches the window's clone number process the overlay even if
2111 the overlay's window property doesn't match the current window.
2112
2113 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2114 (Fwindow_hchild): Rename to Fwindow_left_child.
2115 (Fwindow_next): Rename to Fwindow_next_sibling.
2116 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2117 (resize_window_check): Rename to window_resize_check.
2118 (resize_window_apply): Rename to window_resize_apply.
2119 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2120 (Fdelete_other_windows_internal, resize_frame_windows)
2121 (Fsplit_window_internal, Fdelete_window_internal)
2122 (grow_mini_window, shrink_mini_window)
2123 (Fresize_mini_window_internal): Fix callers accordingly.
2124
2125 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2126
2127 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2128 (emacs_fixed_set_min_size): Remove.
2129 (emacs_fixed_new): Take frame as argument.
2130
2131 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2132 (_EmacsFixedPrivate): Remove minwidth/height.
2133 Add struct frame *f.
2134 (emacs_fixed_init): Initialize priv->f.
2135 (get_parent_class, emacs_fixed_set_min_size): Remove.
2136 (emacs_fixed_new): Set priv->f to argument.
2137 (emacs_fixed_get_preferred_width)
2138 (emacs_fixed_get_preferred_height): Use min_width/height from
2139 frames size_hint to set minimum and natural (Bug#8919).
2140 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2141 and use min_width/height from frames size_hint to set
2142 min_width/height (Bug#8919).
2143
2144 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2145 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2146 Fix indentation.
2147
2148 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2149
2150 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2151 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2152 called at ZV.
2153
2154 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2155
2156 * process.c (wait_reading_process_output): Bypass select if
2157 waiting for a cell while ignoring keyboard input, and input is
2158 pending. Suggested by Jan Djärv (Bug#8869).
2159
2160 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2161
2162 Use gnulib's dup2 module instead of rolling our own.
2163 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2164
2165 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2166
2167 * dispnew.c (scrolling_window): Before scrolling, turn off a
2168 mouse-highlight in the window being scrolled.
2169
2170 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2171
2172 Move DEFSYM to lisp.h and use everywhere.
2173
2174 * character.h (DEFSYM): Move declaration...
2175 * lisp.h (DEFSYM): ...here.
2176
2177 * gnutls.c:
2178 * minibuf.c:
2179 * w32menu.c:
2180 * w32proc.c:
2181 * w32select.c: Don't include character.h.
2182
2183 * alloc.c (syms_of_alloc):
2184 * buffer.c (syms_of_buffer):
2185 * bytecode.c (syms_of_bytecode):
2186 * callint.c (syms_of_callint):
2187 * casefiddle.c (syms_of_casefiddle):
2188 * casetab.c (init_casetab_once):
2189 * category.c (init_category_once, syms_of_category):
2190 * ccl.c (syms_of_ccl):
2191 * cmds.c (syms_of_cmds):
2192 * composite.c (syms_of_composite):
2193 * dbusbind.c (syms_of_dbusbind):
2194 * dired.c (syms_of_dired):
2195 * dispnew.c (syms_of_display):
2196 * doc.c (syms_of_doc):
2197 * editfns.c (syms_of_editfns):
2198 * emacs.c (syms_of_emacs):
2199 * eval.c (syms_of_eval):
2200 * fileio.c (syms_of_fileio):
2201 * fns.c (syms_of_fns):
2202 * frame.c (syms_of_frame):
2203 * fringe.c (syms_of_fringe):
2204 * insdel.c (syms_of_insdel):
2205 * keymap.c (syms_of_keymap):
2206 * lread.c (init_obarray, syms_of_lread):
2207 * macros.c (syms_of_macros):
2208 * msdos.c (syms_of_msdos):
2209 * print.c (syms_of_print):
2210 * process.c (syms_of_process):
2211 * search.c (syms_of_search):
2212 * sound.c (syms_of_sound):
2213 * syntax.c (init_syntax_once, syms_of_syntax):
2214 * terminal.c (syms_of_terminal):
2215 * textprop.c (syms_of_textprop):
2216 * undo.c (syms_of_undo):
2217 * w32.c (globals_of_w32):
2218 * window.c (syms_of_window):
2219 * xdisp.c (syms_of_xdisp):
2220 * xfaces.c (syms_of_xfaces):
2221 * xfns.c (syms_of_xfns):
2222 * xmenu.c (syms_of_xmenu):
2223 * xsettings.c (syms_of_xsettings):
2224 * xterm.c (syms_of_xterm): Use DEFSYM.
2225
2226 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2227
2228 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2229
2230 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2231
2232 Integer and buffer overflow fixes (Bug#8873).
2233
2234 * print.c (printchar, strout): Check for string overflow.
2235 (PRINTPREPARE, printchar, strout):
2236 Don't set size unless allocation succeeds.
2237
2238 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2239 for sizes. Check for string overflow more accurately.
2240 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2241
2242 * macros.c: Integer and buffer overflow fixes.
2243 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2244 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2245 Use ptrdiff_t, not int, for sizes.
2246 Don't increment bufsize until after realloc succeeds.
2247 Check for size-calculation overflow.
2248 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2249
2250 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2251
2252 * lread.c: Integer overflow fixes.
2253 (read_integer): Radix is now EMACS_INT, not int,
2254 to improve quality of diagnostics for out-of-range radices.
2255 Calculate buffer size correctly for out-of-range radices.
2256 (read1): Check for integer overflow in radices, and in
2257 read-circle numbers.
2258 (read_escape): Avoid int overflow.
2259 (Fload, openp, read_buffer_size, read1)
2260 (substitute_object_recurse, read_vector, read_list, map_obarray):
2261 Use ptrdiff_t, not int, for sizes.
2262 (read1): Use EMACS_INT, not int, for sizes.
2263 Check for size overflow.
2264
2265 * image.c (cache_image): Check for size arithmetic overflow.
2266
2267 * lread.c: Integer overflow issues.
2268 (saved_doc_string_size, saved_doc_string_length)
2269 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2270 Now ptrdiff_t, not int.
2271 (read1): Don't assume doc string length fits in int. Check for
2272 out-of-range doc string lengths.
2273 (read_list): Don't assume file position fits in int.
2274 (read_escape): Check for hex character overflow.
2275
2276 2011-06-22 Leo Liu <sdl.web@gmail.com>
2277
2278 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2279 Move to minibuffer.el.
2280
2281 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2282
2283 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2284 The following patches are for when GLYPH_DEBUG && !XASSERT.
2285 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2286 * dispnew.c (flush_stdout):
2287 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2288 Mark as externally visible.
2289 * dispnew.c (check_window_matrix_pointers): Now static.
2290 * dispnew.c (window_to_frame_vpos):
2291 * xfns.c (unwind_create_frame):
2292 * xterm.c (x_check_font): Remove unused local.
2293 * scroll.c (CHECK_BOUNDS):
2294 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2295 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2296 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2297 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2298 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2299 Now static.
2300 (debug_method_add): Use va_list and vsprintf rather than relying
2301 on undefined behavior with wrong number of arguments.
2302 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2303 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2304 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2305 since we're not interested in debugging glyphs with old libraries.
2306 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2307 GCC 4.6.0's static checking.
2308
2309 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2310
2311 Integer overflow and signedness fixes (Bug#8873).
2312 A few related buffer overrun fixes, too.
2313
2314 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2315
2316 * dispextern.h (struct face.stipple):
2317 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2318 (x_bitmap_mask, x_allocate_bitmap_record)
2319 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2320 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2321 (x_create_bitmap_from_xpm_data):
2322 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2323 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2324 (.bitmaps_last):
2325 * xfaces.c (load_pixmap):
2326 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2327 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2328 (.bitmaps_last, struct x_output.icon_bitmap):
2329 Use ptrdiff_t, not int, for bitmap indexes.
2330 (x_allocate_bitmap_record): Check for size overflow.
2331 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2332
2333 Use ptrdiff_t, not int, for overlay counts.
2334 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2335 * editfns.c (overlays_around, get_pos_property):
2336 * textprop.c (get_char_property_and_overlay):
2337 * xdisp.c (next_overlay_change, note_mouse_highlight):
2338 * xfaces.c (face_at_buffer_position):
2339 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2340 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2341 (Fnext_overlay_change, Fprevious_overlay_change)
2342 (mouse_face_overlay_overlaps, Foverlays_in):
2343 Use ptrdiff_t, not int, for sizes.
2344 (overlays_at, overlays_in): Check for size-calculation overflow.
2345
2346 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2347
2348 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2349 (x_session_initialize): Do not assume string length fits in int.
2350
2351 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2352 This is unlikely, but can occur if DPI is outlandish.
2353
2354 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2355 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2356
2357 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2358 * xrdb.c (magic_file_p, search_magic_path):
2359 Omit last arg SUFFIX; it was always 0. All callers changed.
2360 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2361
2362 * xfont.c (xfont_match): Avoid need for strlen.
2363
2364 * xfns.c: Don't assume strlen fits in int.
2365 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2366
2367 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2368 not unsigned long, as we prefer signed integers. All callers changed.
2369 Detect integer overflow in repeat count.
2370 (message_dolog): Don't assume print length fits in 39 bytes.
2371 (display_mode_element): Don't assume strlen fits in int.
2372
2373 * termcap.c: Don't assume sizes fit in int and never overflow.
2374 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2375 (gobble_line): Check for size-calculation overflow.
2376
2377 * minibuf.c (Fread_buffer):
2378 * lread.c (intern, intern_c_string):
2379 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2380 Don't assume string length fits in int.
2381
2382 * keyboard.c (parse_tool_bar_item):
2383 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2384
2385 * font.c: Don't assume string length fits in int.
2386 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2387 Use ptrdiff_t, not int.
2388 (font_intern_prop): Don't assume string length fits in int.
2389 Don't assume integer property fits in fixnum.
2390 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2391
2392 * filelock.c: Fix some buffer overrun and integer overflow issues.
2393 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2394 Reformulate so as not to need the command string.
2395 Invoke gzip -cd rather than gunzip, as it's more portable.
2396 (lock_info_type, lock_file_1, lock_file):
2397 Don't assume pid_t and time_t fit in unsigned long.
2398 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2399 (current_lock_owner): Prefer signed type for sizes.
2400 Use memcpy, not strncpy, where memcpy is what is really wanted.
2401 Don't assume (via atoi) that time_t and pid_t fit in int.
2402 Check for time_t and/or pid_t out of range, e.g., via a network share.
2403 Don't alloca where an auto var works fine.
2404
2405 * fileio.c: Fix some integer overflow issues.
2406 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2407 Don't assume string length fits in int.
2408 (directory_file_name): Don't assume string length fits in long.
2409 (make_temp_name): Don't assume pid fits in int, or that its print
2410 length is less than 20.
2411
2412 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2413
2414 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2415
2416 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2417
2418 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2419 We prefer signed integers, even for size calculations.
2420
2421 * emacs.c: Don't assume string length fits in 'int'.
2422 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2423 (main): Don't invoke strlen when not needed.
2424
2425 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2426 (XD_DEBUG_MESSAGE): Don't waste a byte.
2427
2428 * callproc.c (getenv_internal_1, getenv_internal)
2429 (Fgetenv_internal):
2430 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2431
2432 * lread.c (invalid_syntax): Omit length argument.
2433 All uses changed. This doesn't fix a bug, but it simplifies the
2434 code away from its former Hollerith-constant appearance, and it's
2435 one less 'int' to worry about when looking at integer-overflow issues.
2436 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2437
2438 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2439 This didn't break anything, but it didn't help either.
2440 It's confusing to put a bogus integer in a place where the actual
2441 value does not matter.
2442 (LIST_END_P): Remove unused macro and its bogus comment.
2443 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2444
2445 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2446 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2447 implementation.
2448 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2449 We prefer signed types, and the value cannot exceed the EMACS_INT
2450 range anyway (because otherwise the length would not be representable).
2451 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2452 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2453 This avoids a GCC warning when WIDE_EMACS_INT.
2454
2455 * indent.c (sane_tab_width): New function.
2456 (current_column, scan_for_column, Findent_to, position_indentation)
2457 (compute_motion): Use it. This is just for clarity.
2458 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2459
2460 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2461
2462 * lisp.h (lint_assume): New macro.
2463 * composite.c (composition_gstring_put_cache):
2464 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2465
2466 * editfns.c, insdel.c:
2467 Omit unnecessary forward decls, to simplify future changes.
2468
2469 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2470
2471 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2472
2473 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2474 Use much-faster test for byte-length change.
2475 Don't assume string byte-length fits in 'int'.
2476 Check that character arg fits in 'int'.
2477 (mapcar1): Declare byte as byte, for clarity.
2478
2479 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2480
2481 * fns.c (concat): Catch string overflow earlier.
2482 Do not rely on integer wraparound.
2483
2484 * dispextern.h (struct it.overlay_strings_charpos)
2485 (struct it.selective): Now EMACS_INT, not int.
2486 * xdisp.c (forward_to_next_line_start)
2487 (back_to_previous_visible_line_start)
2488 (reseat_at_next_visible_line_start, next_element_from_buffer):
2489 Don't arbitrarily truncate the value of 'selective' to int.
2490
2491 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2492
2493 * composite.c: Don't truncate sizes to 'int'.
2494 (composition_gstring_p, composition_reseat_it)
2495 (composition_adjust_point): Use EMACS_INT, not int.
2496 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2497 not EMACS_UINT, for indexes.
2498
2499 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2500
2501 * buffer.c: Include <verify.h>.
2502 (struct sortvec.priority, struct sortstr.priority):
2503 Now EMACS_INT, not int.
2504 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2505 (struct sortstr.size, record_overlay_string)
2506 (struct sortstrlist.size, struct sortlist.used):
2507 Don't truncate size to int.
2508 (record_overlay_string): Check for size-calculation overflow.
2509 (init_buffer_once): Check at compile-time, not run-time.
2510
2511 2011-06-22 Jim Meyering <meyering@redhat.com>
2512
2513 Don't leak an XBM-image-sized buffer
2514 * image.c (xbm_load): Free the image buffer after using it.
2515
2516 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 Port to Sun C.
2519 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2520 that Sun C diagnosed.
2521 * fns.c (secure_hash): Fix pointer signedness issue.
2522 * intervals.c (static_offset_intervals): New function.
2523 (offset_intervals): Use it.
2524
2525 2011-06-21 Leo Liu <sdl.web@gmail.com>
2526
2527 * deps.mk (fns.o):
2528 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2529 sha512.h.
2530
2531 * fns.c (secure_hash): Rename from crypto_hash_function and change
2532 the first arg to accept symbols.
2533 (Fsecure_hash): New primitive.
2534 (syms_of_fns): New symbols.
2535
2536 2011-06-20 Deniz Dogan <deniz@dogan.se>
2537
2538 * process.c (Fset_process_buffer): Clarify return value in
2539 docstring.
2540
2541 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2542
2543 * dispnew.c (add_window_display_history): Use BVAR.
2544
2545 * xdisp.c (debug_method_add): Use BVAR.
2546 (check_window_end, dump_glyph_matrix, dump_glyph)
2547 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2548
2549 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2550 Likewise.
2551
2552 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2553 check till after the cache is created in init_frame_faces.
2554
2555 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2556
2557 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2558
2559 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2560
2561 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2562 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2563 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2564
2565 Improve buffer-overflow checking (Bug#8873).
2566 * fileio.c (Finsert_file_contents):
2567 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2568 Remove the old (too-loose) buffer overflow checks.
2569 They weren't needed, since make_gap checks for buffer overflow.
2570 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2571 The old code merely checked for Emacs fixnum overflow, and relied
2572 on undefined (wraparound) behavior. The new code avoids undefined
2573 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2574
2575 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2576 Tune. Don't use wider integers than needed. Don't use alloca.
2577 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2578
2579 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2580
2581 * insdel.c, lisp.h (buffer_overflow): New function.
2582 (insert_from_buffer_1, replace_range, replace_range_2):
2583 * insdel.c (make_gap_larger):
2584 * editfns.c (Finsert_char):
2585 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2586
2587 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2588
2589 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2590
2591 Integer overflow and signedness fixes (Bug#8873).
2592
2593 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2594 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2595
2596 * fileio.c: Don't assume EMACS_INT fits in off_t.
2597 (emacs_lseek): New static function.
2598 (Finsert_file_contents, Fwrite_region): Use it.
2599 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2600
2601 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2602
2603 * fns.c: Don't overflow int when computing a list length.
2604 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2605 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2606 truncation on 64-bit hosts. Check for QUIT every
2607 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2608 faster and is responsive enough.
2609 (Flength): Report an error instead of overflowing an integer.
2610 (Fsafe_length): Return a float if the value is not representable
2611 as a fixnum. This shouldn't happen except in contrived situations.
2612 (Fnthcdr, Fsort): Don't assume list length fits in int.
2613 (Fcopy_sequence): Don't assume vector length fits in int.
2614
2615 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2616 (header_size, word_size): New constants.
2617 (allocate_vectorlike): Don't check size overflow here.
2618 (allocate_vector): Check it here instead, since this is the only
2619 caller of allocate_vectorlike that could cause overflow.
2620 Check that the new vector's length is representable as a fixnum.
2621
2622 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2623 The previous code was bogus. For example, next_almost_prime (32)
2624 returned 39, which is undesirable as it is a multiple of 3; and
2625 next_almost_prime (24) returned 25, which is a multiple of 5 so
2626 why was the code bothering to check for multiples of 7?
2627
2628 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2629
2630 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2631
2632 Variadic C functions now count arguments with ptrdiff_t.
2633 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2634 Back then I didn't know that the Emacs coding style prefers signed int.
2635 Also, in the meantime I found a few more instances where arguments
2636 were being counted with int, which may truncate counts on 64-bit
2637 machines, or EMACS_INT, which may be unnecessarily wide.
2638 * lisp.h (struct Lisp_Subr.function.aMANY)
2639 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2640 Arg counts are now ptrdiff_t, not size_t.
2641 All variadic functions and their callers changed accordingly.
2642 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2643 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2644 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2645 * callint.c (Fcall_interactively): Check arg count for overflow,
2646 to avoid potential buffer overrun. Use signed char, not 'int',
2647 for 'varies' array, so that we needn't bother to check its size
2648 calculation for overflow.
2649 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2650 * eval.c (apply_lambda):
2651 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2652 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2653 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2654
2655 * callint.c (Fcall_interactively): Don't use index var as event count.
2656
2657 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2658 * mem-limits.h (SIZE): Remove; no longer used.
2659
2660 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2661
2662 Remove unnecessary casts.
2663 * xterm.c (x_term_init):
2664 * xfns.c (x_set_border_pixel):
2665 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2666 These aren't needed now that we assume ANSI C.
2667
2668 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2669 It's more likely to cause problems (due to unsigned overflow)
2670 than to cure them.
2671
2672 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2673
2674 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2675
2676 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2677
2678 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2679
2680 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2681
2682 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2683
2684 GLYPH_CODE_FACE returns EMACS_INT, not int.
2685 * dispextern.h (merge_faces):
2686 * xfaces.c (merge_faces):
2687 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2688 Don't assume EMACS_INT fits in int.
2689
2690 * character.h (CHAR_VALID_P): Remove unused parameter.
2691 * fontset.c, lisp.h, xdisp.c: All uses changed.
2692
2693 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2694
2695 * fns.c (concat): Minor tuning based on overflow analysis.
2696 This doesn't fix any bugs. Use int to hold character, instead
2697 of constantly refetching from Emacs object. Use XFASTINT, not
2698 XINT, for value known to be a character. Don't bother comparing
2699 a single byte to 0400, as it's always less.
2700
2701 * floatfns.c (Fexpt):
2702 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2703
2704 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2705 for characters.
2706
2707 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2708
2709 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2710 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2711 incorrectly succeed when S was a string, because 4294967386 was
2712 truncated before it was used.
2713
2714 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2715 Otherwise, an out-of-range integer could cause undefined behavior
2716 on a 64-bit host.
2717
2718 * composite.c: Use int, not EMACS_INT, for characters.
2719 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2720 EMACS_INT, for values that are known to be in character range.
2721 This doesn't fix any bugs but is the usual style inside Emacs and
2722 may generate better code on 32-bit machines.
2723
2724 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2725 This is for reasons similar to the recent CHAR_STRING fix.
2726 * charset.c (Fencode_char): Check that character arg is actually
2727 a character. Pass an int to ENCODE_CHAR.
2728 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2729 wider than 'int', as a compile-time check to prevent future regressions
2730 in this area.
2731
2732 * character.c (char_string): Remove unnecessary casts.
2733
2734 Make sure a 64-bit char is never passed to CHAR_STRING.
2735 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2736 by silently ignoring the top 32 bits, allowing some values
2737 that were far too large to be valid characters.
2738 * character.h: Include <verify.h>.
2739 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2740 arguments are no wider than unsigned, as a compile-time check
2741 to prevent future regressions in this area.
2742 * data.c (Faset):
2743 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2744 (Fsubst_char_in_region):
2745 * fns.c (concat):
2746 * xdisp.c (decode_mode_spec_coding):
2747 Adjust to CHAR_STRING's new requirement.
2748 * editfns.c (Finsert_char, Fsubst_char_in_region):
2749 * fns.c (concat): Check that character args are actually
2750 characters. Without this test, these functions did the wrong
2751 thing with wildly out-of-range values on 64-bit hosts.
2752
2753 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2754 These casts should not be needed on 32-bit hosts, either.
2755 * keyboard.c (read_char):
2756 * lread.c (Fload): Remove casts to unsigned.
2757
2758 * lisp.h (UNSIGNED_CMP): New macro.
2759 This fixes comparison bugs on 64-bit hosts.
2760 (ASCII_CHAR_P): Use it.
2761 * casefiddle.c (casify_object):
2762 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2763 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2764 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2765 * dispextern.h (FACE_FROM_ID):
2766 * keyboard.c (read_char): Use UNSIGNED_CMP.
2767
2768 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2769 not to EMACS_INT, to avoid GCC warning.
2770
2771 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2772
2773 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2774 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2775 isn't needed on 32-bit machines.
2776
2777 * buffer.c (Fgenerate_new_buffer_name):
2778 Use EMACS_INT for count, not int.
2779 (advance_to_char_boundary): Return EMACS_INT, not int.
2780
2781 * data.c (Qcompiled_function): Now static.
2782
2783 * window.c (window_body_lines): Now static.
2784
2785 * image.c (gif_load): Rename local to avoid shadowing.
2786
2787 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2788 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2789 * alloc.c (make_save_value): Integer argument is now of type
2790 ptrdiff_t, not int.
2791 (mark_object): Use ptrdiff_t, not int.
2792 * lisp.h (pD): New macro.
2793 * print.c (print_object): Use it.
2794
2795 * alloc.c: Use EMACS_INT, not int, to count objects.
2796 (total_conses, total_markers, total_symbols, total_vector_size)
2797 (total_free_conses, total_free_markers, total_free_symbols)
2798 (total_free_floats, total_floats, total_free_intervals)
2799 (total_intervals, total_strings, total_free_strings):
2800 Now EMACS_INT, not int. All uses changed.
2801 (Fgarbage_collect): Compute overall total using a double, so that
2802 integer overflow is less likely to be a problem. Check for overflow
2803 when converting back to an integer.
2804 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2805 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2806 These were 'int' variables that could overflow on 64-bit hosts;
2807 they were never used, so remove them instead of repairing them.
2808 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2809 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2810 Previously, this ceilinged at INT_MAX, but that doesn't work on
2811 64-bit machines.
2812 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2813
2814 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2815 (allocate_vectorlike): Check for ptrdiff_t overflow.
2816 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2817 when a (possibly-narrower) signed value would do just as well.
2818 We prefer using signed arithmetic, to avoid comparison confusion.
2819
2820 * alloc.c: Catch some string size overflows that we were missing.
2821 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2822 for convenience in STRING_BYTES_MAX.
2823 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2824 The definition here is exact; the one in lisp.h was approximate.
2825 (allocate_string_data): Check for string overflow. This catches
2826 some instances we weren't catching before. Also, it catches
2827 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2828 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2829 and ptrdiff_t and EMACS_INT are both 64 bits.
2830
2831 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2832 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2833 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2834
2835 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2836
2837 * alloc.c (Fmake_string): Check for out-of-range init.
2838
2839 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2840
2841 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2842
2843 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2844
2845 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2846 xg_get_default_scrollbar_width.
2847
2848 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2849 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2850 (style_changed_cb): Call update_theme_scrollbar_width and call
2851 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2852 all frames (Bug#8505).
2853 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2854 Call gtk_window_set_resizable if HAVE_GTK3.
2855 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2856 and height if HAVE_GTK3 (Bug#8505).
2857 (scroll_bar_width_for_theme): New variable.
2858 (update_theme_scrollbar_width): New function.
2859 (xg_get_default_scrollbar_width): Move code to
2860 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2861 (xg_initialize): Call update_theme_scrollbar_width.
2862
2863 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2864
2865 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2866
2867 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2868
2869 * frame.c (make_frame): Call other_buffer_safely instead of
2870 other_buffer.
2871
2872 * window.c (temp_output_buffer_show): Call display_buffer with
2873 second argument Vtemp_buffer_show_specifiers and reset latter
2874 immediately after the call.
2875 (Vtemp_buffer_show_specifiers): New variable.
2876 (auto_window_vscroll_p, next_screen_context_lines)
2877 (Vscroll_preserve_screen_position): Remove leading asterisks from
2878 doc-strings.
2879
2880 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2881
2882 Fix minor problems found by GCC 4.6.0 static checking.
2883 * buffer.c (Qclone_number): Remove for now, as it's unused.
2884 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2885 (record_buffer): Remove unused local.
2886 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2887 (set_frame_buffer_list): Remove; unused.
2888 * frame.h (other_visible_frames): Remove decl.
2889 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2890 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2891 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2892 if HAVE_GPM.
2893 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2894 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2895 Define only if HAVE_GPM.
2896 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2897 (update_hints_inhibit): Remove; never set. All uses removed.
2898 * widgetprv.h (emacsFrameClassRec): Remove decl.
2899 * window.c (delete_deletable_window): Now returns void, since it
2900 wasn't returning anything.
2901 (compare_window_configurations): Remove unused locals.
2902 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2903 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2904 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2905 the same widths as pointers. This follows up on the 2011-05-06 patch.
2906 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2907 * xterm.h: Likewise.
2908 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2909
2910 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2911
2912 * makefile.w32-in: Update dependencies.
2913 (LISP_H): Add lib/intprops.h.
2914
2915 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2916
2917 * image.c (gif_load): Add animation frame delay to the metadata.
2918 (syms_of_image): Use DEFSYM. New symbol `delay'.
2919
2920 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2921
2922 * window.c (delete_deletable_window): Re-add.
2923 (Fset_window_configuration): Rewrite to handle dead buffers and
2924 consequently deletable windows.
2925 (window_tree, Fwindow_tree): Remove. Supply functionality in
2926 window.el.
2927 (compare_window_configurations): Simplify code.
2928
2929 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2930
2931 * image.c (imagemagick_load_image): Fix type mismatch.
2932 (Fimagemagick_types): Likewise.
2933
2934 * window.h (replace_buffer_in_windows): Declare.
2935
2936 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2937
2938 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2939 Qclone_number. Remove external declaration of Qdelete_window.
2940 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2941 code.
2942 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2943 Run Qbuffer_list_update_hook if allowed.
2944 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2945 buffer list implementation.
2946 (other_buffer_safely): New function.
2947 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2948 calls to replace_buffer_in_windows and
2949 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2950 if allowed.
2951 (record_buffer): Inhibit quitting and rewrite using quittable
2952 functions. Run Qbuffer_list_update_hook if allowed.
2953 (Frecord_buffer, Funrecord_buffer): New functions.
2954 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2955 Move switch-to-buffer to window.el.
2956 (bury-buffer): Move to window.el.
2957 (Vbuffer_list_update_hook): New variable.
2958
2959 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2960 section.
2961
2962 * window.h (resize_frame_windows): Move up in code.
2963 (Fwindow_frame): Remove EXFUN.
2964 (replace_buffer_in_all_windows): Remove prototype.
2965 (replace_buffer_in_windows_safely): Add prototype.
2966
2967 * window.c: Declare Qdelete_window static again. Move down
2968 declaration of select_count.
2969 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2970 (Fother_window): Move to window.el.
2971 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2972 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2973 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2974 window.el.
2975 (replace_buffer_in_windows): Implement by calling
2976 Qreplace_buffer_in_windows.
2977 (replace_buffer_in_all_windows): Remove with some functionality
2978 moved into replace_buffer_in_windows_safely.
2979 (replace_buffer_in_windows_safely): New function.
2980 (select_window_norecord, select_frame_norecord): Move in front
2981 of run_window_configuration_change_hook. Remove now obsolete
2982 declarations.
2983 (Fset_window_buffer): Rewrite doc-string.
2984 Call Qrecord_window_buffer.
2985 (keys_of_window): Move binding for other-window to window.el.
2986
2987 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2988
2989 * dispextern.h (struct image): Replace data member, whose int_val
2990 and ptr_val fields were not used by anything, with a single
2991 lisp_val object.
2992
2993 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2994 (gif_clear_image, gif_load, imagemagick_load_image)
2995 (gs_clear_image, gs_load): Callers changed.
2996
2997 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2998
2999 * buffer.h: Include <time.h>, for time_t.
3000 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3001
3002 Fix minor problems found by static checking.
3003
3004 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3005
3006 Make identifiers static if they are not used in other modules.
3007 * data.c (Qcompiled_function, Qframe, Qvector):
3008 * image.c (QimageMagick, Qsvg):
3009 * minibuf.c (Qmetadata):
3010 * window.c (resize_window_check, resize_root_window): Now static.
3011 * window.h (resize_window_check, resize_root_window): Remove decls.
3012
3013 * window.c (window_deletion_count, delete_deletable_window):
3014 Remove; unused.
3015 (window_body_lines): Now static.
3016 (Fdelete_other_windows_internal): Mark vars as initialized.
3017 Make sure 'resize_failed' is initialized.
3018 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3019 (resize_window_apply): Remove unused local.
3020 * window.h (delete_deletable_window): Remove decl.
3021
3022 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3023 (imagemagick_load_image): Fix pointer signedness problem by changing
3024 last arg from unsigned char * to char *. All uses changed.
3025 Also, fix a local for similar reasons.
3026 Remove unused locals. Remove locals to avoid shadowing.
3027 (fn_rsvg_handle_free): Remove; unused.
3028 (svg_load, svg_load_image): Fix pointer signedness problem.
3029 (imagemagick_load_image): Don't use garbage pointer image_wand.
3030
3031 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3032
3033 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3034
3035 * image.c (gif_load): Fix omitted cast error introduced by
3036 2011-06-06 change.
3037
3038 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3039
3040 * window.h (resize_proportionally, orig_total_lines)
3041 (orig_top_line): Remove from window structure.
3042 (set_window_height, set_window_width, change_window_heights)
3043 (Fdelete_window): Remove prototypes.
3044 (resize_frame_windows): Remove duplicate declaration.
3045
3046 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3047
3048 * window.h (resize_frame_windows, resize_window_check)
3049 (delete_deletable_window, resize_root_window)
3050 (resize_frame_windows): Declare prototypes.
3051
3052 * window.c (resize_window_apply): Make definition be "static" to
3053 match the prototype.
3054
3055 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3056
3057 * window.c: Remove declarations of Qwindow_size_fixed,
3058 window_min_size_1, window_min_size_2, window_min_size,
3059 size_window, window_fixed_size_p, enlarge_window, delete_window.
3060 Remove static from declaration of Qdelete_window, it's
3061 temporarily needed by Fbury_buffer.
3062 (replace_window): Don't assign orig_top_line and
3063 orig_total_lines.
3064 (Fdelete_window, delete_window): Remove. Window deletion is
3065 handled by window.el.
3066 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3067 Replace Fdelete_window calls with calls to Qdelete_window.
3068 (Fdelete_other_windows): Remove. Deleting other windows is
3069 handled by window.el.
3070 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3071 handled in window.el.
3072 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3073 Window minimum sizes are handled in window.el.
3074 (shrink_windows, size_window, set_window_height)
3075 (set_window_width, change_window_heights, window_height)
3076 (window_width, CURBEG, CURSIZE, enlarge_window)
3077 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3078 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3079 handled in window.el.
3080 (make_dummy_parent): Rename to make_parent_window and give it a
3081 second argument horflag.
3082 (make_window): Don't set resize_proportionally any more.
3083 (Fsplit_window): Remove. Windows are split in window.el.
3084 (save_restore_action, save_restore_orig_size)
3085 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3086 Resize mini windows in window.el.
3087 (grow_mini_window, shrink_mini_window): Implement by calling
3088 Qresize_root_window_vertically, resize_window_check and
3089 resize_window_apply.
3090 (saved_window, Fset_window_configuration, save_window_save):
3091 Do not handle orig_top_line, orig_total_lines, and
3092 resize_proportionally.
3093 (window_min_height, window_min_width): Move to window.el.
3094 (keys_of_window): Move bindings for delete-other-windows,
3095 split-window, delete-window and enlarge-window to window.el.
3096
3097 * buffer.c: Temporarily extern Qdelete_window.
3098 (Fbury_buffer): Temporarily call Qdelete_window instead of
3099 Fdelete_window (Fbury_buffer will move to window.el soon).
3100
3101 * frame.c (set_menu_bar_lines_1): Remove code handling
3102 orig_top_line and orig_total_lines.
3103
3104 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3105 set_window_height but set heights directly.
3106 (change_frame_size_1): Use resize_frame_windows.
3107
3108 * xdisp.c (init_xdisp): Don't use set_window_height but set
3109 heights directly.
3110
3111 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3112 Use resize_frame_windows instead of change_window_heights and run
3113 run_window_configuration_change_hook.
3114
3115 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3116 instead of change_window_heights and run
3117 run_window_configuration_change_hook.
3118
3119 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3120
3121 * window.c (replace_window): Rename second argument REPLACEMENT to
3122 NEW. New third argument SETFLAG. Rewrite.
3123 (delete_window, make_dummy_parent): Call replace_window with
3124 third argument 1.
3125 (window_list_1): Move down in code.
3126 (run_window_configuration_change_hook): Move set_buffer part
3127 before select_frame_norecord part in order to unwind correctly.
3128 Rename count1 to count.
3129 (recombine_windows, delete_deletable_window, resize_root_window)
3130 (Fdelete_other_windows_internal)
3131 (Frun_window_configuration_change_hook, make_parent_window)
3132 (resize_window_check, resize_window_apply, Fresize_window_apply)
3133 (resize_frame_windows, Fsplit_window_internal)
3134 (Fdelete_window_internal, Fresize_mini_window_internal):
3135 New functions.
3136 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3137
3138 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3139
3140 * window.h (window): Add some new members to window structure -
3141 normal_lines, normal_cols, new_total, new_normal, clone_number,
3142 splits, nest, prev_buffers, next_buffers.
3143 (WINDOW_TOTAL_SIZE): Move here from window.c.
3144 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3145
3146 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3147 Remove.
3148 (make_dummy_parent): Set new members of windows structure.
3149 (make_window): Move down in code. Handle new members of window
3150 structure.
3151 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3152 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3153 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3154 (Fset_window_prev_buffers, Fwindow_next_buffers)
3155 (Fset_window_next_buffers, Fset_window_clone_number):
3156 New functions.
3157 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3158 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3159 Doc-string fixes.
3160 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3161 Argument WINDOW can be now internal window too.
3162 (Fwindow_use_time): Move up in code.
3163 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3164 Rewrite doc-string.
3165 (Fset_window_configuration, saved_window)
3166 (Fcurrent_window_configuration, save_window_save): Handle new
3167 members of window structure.
3168 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3169 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3170 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3171 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3172 Qget_mru_window, Qresize_root_window,
3173 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3174 Qauto_buffer_name; staticpro them.
3175
3176 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3177
3178 * window.c (Fwindow_total_size, Fwindow_left_column)
3179 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3180 (Fwindow_list_1): New functions.
3181 (window_box_text_cols): Replace with window_body_cols.
3182 (Fwindow_width, Fscroll_left, Fscroll_right):
3183 Use window_body_cols instead of window_box_text_cols.
3184 (delete_window, Fset_window_configuration):
3185 Call delete_all_subwindows with window as argument.
3186 (delete_all_subwindows): Take a window as argument and not a
3187 structure. Rewrite.
3188 (window_loop): Remove handling of GET_LRU_WINDOW and
3189 GET_LARGEST_WINDOW.
3190 (Fget_lru_window, Fget_largest_window): Move to window.el.
3191
3192 * window.h: Extern window_body_cols instead of
3193 window_box_text_cols. delete_all_subwindows now takes a
3194 Lisp_Object as argument.
3195
3196 * indent.c (compute_motion, Fcompute_motion):
3197 Use window_body_cols instead of window_box_text_cols.
3198
3199 * frame.c (delete_frame): Call delete_all_subwindows with root
3200 window as argument.
3201
3202 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3203
3204 * fns.c (Fputhash): Document return value.
3205
3206 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3207
3208 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3209
3210 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3211
3212 Cons<->int and similar integer overflow fixes (Bug#8794).
3213
3214 Check for overflow when converting integer to cons and back.
3215 * charset.c (Fdefine_charset_internal, Fdecode_char):
3216 Use cons_to_unsigned to catch overflow.
3217 (Fencode_char): Use INTEGER_TO_CONS.
3218 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3219 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3220 * data.c (long_to_cons, cons_to_long): Remove.
3221 (cons_to_unsigned, cons_to_signed): New functions.
3222 These signal an error for invalid or out-of-range values.
3223 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3224 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3225 * font.c (Ffont_variation_glyphs):
3226 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3227 * lisp.h: Include <intprops.h>.
3228 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3229 (cons_to_signed, cons_to_unsigned): New decls.
3230 (long_to_cons, cons_to_long): Remove decls.
3231 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3232 (Fprimitive_undo): Use CONS_TO_INTEGER.
3233 * xfns.c (Fx_window_property): Likewise.
3234 * xselect.c: Include <limits.h>.
3235 (x_own_selection, selection_data_to_lisp_data):
3236 Use INTEGER_TO_CONS.
3237 (x_handle_selection_request, x_handle_selection_clear)
3238 (x_get_foreign_selection, Fx_disown_selection_internal)
3239 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3240 (lisp_data_to_selection_data): Use cons_to_unsigned.
3241 (x_fill_property_data): Use cons_to_signed.
3242 Report values out of range.
3243
3244 Check for buffer and string overflow more precisely.
3245 * buffer.h (BUF_BYTES_MAX): New macro.
3246 * lisp.h (STRING_BYTES_MAX): New macro.
3247 * alloc.c (Fmake_string):
3248 * character.c (string_escape_byte8):
3249 * coding.c (coding_alloc_by_realloc):
3250 * doprnt.c (doprnt):
3251 * editfns.c (Fformat):
3252 * eval.c (verror):
3253 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3254 since they may not be the same number.
3255 * editfns.c (Finsert_char):
3256 * fileio.c (Finsert_file_contents):
3257 Likewise for BUF_BYTES_MAX.
3258
3259 * image.c: Use ptrdiff_t, not int, for sizes.
3260 (slurp_file): Switch from int to ptrdiff_t.
3261 All uses changed.
3262 (slurp_file): Check that file size fits in both size_t (for
3263 malloc) and ptrdiff_t (for sanity and safety).
3264
3265 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3266 if b->modtime has its maximal value.
3267
3268 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3269
3270 Don't assume time_t can fit into int.
3271 * buffer.h (struct buffer.modtime): Now time_t, not int.
3272 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3273 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3274
3275 Minor fixes for signed vs unsigned integers.
3276 * character.h (MAYBE_UNIFY_CHAR):
3277 * charset.c (maybe_unify_char):
3278 * keyboard.c (read_char, reorder_modifiers):
3279 XINT -> XFASTINT, since the integer must be nonnegative.
3280 * ftfont.c (ftfont_spec_pattern):
3281 * keymap.c (access_keymap, silly_event_symbol_error):
3282 XUINT -> XFASTINT, since the integer must be nonnegative.
3283 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3284 since it makes no difference and we prefer signed.
3285 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3286 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3287 nonnegative.
3288
3289 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3290
3291 * window.h (Fwindow_frame): Declare.
3292
3293 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3294
3295 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3296 (SPARE_MEMORY): Always define.
3297 (LARGE_REQUEST): Remove.
3298 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3299
3300 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3301
3302 * lisp.h: Move EXFUNS for Fframe_root_window,
3303 Fframe_first_window and Fset_frame_selected_window to window.h.
3304
3305 * window.h: Move EXFUNS for Fframe_root_window,
3306 Fframe_first_window and Fset_frame_selected_window here from
3307 lisp.h.
3308
3309 * frame.c (Fwindow_frame, Fframe_first_window)
3310 (Fframe_root_window, Fframe_selected_window)
3311 (Fset_frame_selected_window): Move to window.c.
3312 (Factive_minibuffer_window): Move to minibuf.c.
3313 (Fother_visible_frames_p): New function.
3314
3315 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3316
3317 * window.c (decode_window, decode_any_window): Move up in code.
3318 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3319 (inhibit_frame_unsplittable): Remove unused variable.
3320 (Fwindow_buffer): Move up and rewrite doc-string.
3321 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3322 (Fwindow_prev): New functions.
3323 (Fwindow_frame): Move here from frame.c. Accept any window as
3324 argument.
3325 (Fframe_root_window, Fframe_first_window)
3326 (Fframe_selected_window): Move here from frame.c. Accept frame
3327 or arbitrary window as argument. Update doc-strings.
3328 (Fminibuffer_window): Move up in code.
3329 (Fwindow_minibuffer_p): Move up in code and simplify.
3330 (Fset_frame_selected_window): Move here from frame.c.
3331 Marginal rewrite.
3332 (Fselected_window, select_window, Fselect_window): Move up in
3333 code. Minor doc-string fixes.
3334
3335 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3336
3337 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3338 Do not assume that spare memory exists; that assumption is valid
3339 only if SYSTEM_MALLOC.
3340 (LARGE_REQUEST): New macro, so that the issue of large requests
3341 is separated from the issue of spare memory.
3342
3343 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3344
3345 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3346 format. (Bug#8806)
3347
3348 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3349
3350 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3351 before statements.
3352
3353 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3354
3355 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3356
3357 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3358
3359 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3360 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3361
3362 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3363
3364 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3365
3366 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3367
3368 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3369 (x_clipboard_manager_save): Add return value.
3370 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3371 New error handlers.
3372 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3373 Obey Vx_select_enable_clipboard_manager. Catch errors in
3374 x_clipboard_manager_save (Bug#8779).
3375 (Vx_select_enable_clipboard_manager): New variable.
3376 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3377
3378 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3379
3380 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3381
3382 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3383
3384 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3385 in the current matrix if keep_current_p is non-zero.
3386
3387 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3388
3389 * bidi.c (bidi_level_of_next_char): Fix last change.
3390
3391 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3392
3393 Support bidi reordering of text covered by display properties.
3394
3395 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3396 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3397 (bidi_cache_search, bidi_cache_iterator_state)
3398 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3399 (bidi_level_of_next_char, bidi_move_to_visually_next):
3400 Support character positions inside a run of characters covered by a
3401 display string.
3402 (bidi_paragraph_init, bidi_resolve_explicit_1)
3403 (bidi_level_of_next_char): Call bidi_fetch_char and
3404 bidi_fetch_char_advance instead of FETCH_CHAR and
3405 FETCH_CHAR_ADVANCE.
3406 (bidi_init_it): Initialize new members.
3407 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3408 definitions.
3409 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3410 instead of using explicit *_CHAR codes.
3411 (bidi_resolve_explicit, bidi_resolve_weak):
3412 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3413 bidirectional text is supported only in multibyte buffers.
3414 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3415 it to initialize the frame_window_p member of struct bidi_it.
3416 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3417 (bidi_resolve_explicit, bidi_resolve_weak)
3418 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3419 bidi_it->nchars is non-positive.
3420 (bidi_level_of_next_char): Don't try to lookup the cache for the
3421 next/previous character if nothing is cached there yet, or if we
3422 were just reseat()'ed to a new position.
3423
3424 * xdisp.c (set_cursor_from_row): Set start and stop points
3425 according to the row's direction when priming the loop that looks
3426 for the glyph on which to display cursor.
3427 (single_display_spec_intangible_p): Function deleted.
3428 (display_prop_intangible_p): Reimplement to call
3429 handle_display_spec instead of single_display_spec_intangible_p.
3430 Accept 3 additional arguments needed by handle_display_spec.
3431 This fixes incorrect cursor motion across display property with complex
3432 values: lists, `(when COND...)' forms, etc.
3433 (single_display_spec_string_p): Support property values that are
3434 lists with the argument STRING its top-level element.
3435 (display_prop_string_p): Fix the condition for processing a
3436 property that is a list to be consistent with handle_display_spec.
3437 (handle_display_spec): New function, refactored from the
3438 last portion of handle_display_prop.
3439 (compute_display_string_pos): Accept additional argument
3440 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3441 value of a `display' property is a "replacing spec".
3442 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3443 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3444 the display property, but just return a value indicating whether
3445 the display property will replace the characters it covers.
3446 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3447 frame_window_p members of struct bidi_it.
3448 (compute_display_string_pos, compute_display_string_end):
3449 New functions.
3450 (push_it): Accept second argument POSITION, where pop_it should
3451 jump to continue iteration.
3452 (reseat_1): Initialize bidi_it.disp_pos.
3453
3454 * keyboard.c (adjust_point_for_property): Adjust the call to
3455 display_prop_intangible_p to its new signature.
3456
3457 * dispextern.h (struct bidi_it): New member frame_window_p.
3458 (bidi_init_it): Update prototypes.
3459 (display_prop_intangible_p): Update prototype.
3460 (compute_display_string_pos, compute_display_string_end):
3461 Declare prototypes.
3462 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3463 EMACS_INT.
3464
3465 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3466
3467 Malloc failure behavior now depends on size of allocation.
3468 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3469 * lisp.h: Change signatures accordingly.
3470 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3471 All callers changed. (Bug#8762)
3472
3473 * gnutls.c: Use Emacs's memory allocators.
3474 Without this change, the gnutls library would invoke malloc etc.
3475 directly, which causes problems on non-SYNC_INPUT hosts, and which
3476 runs afoul of improving memory_full behavior. (Bug#8761)
3477 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3478 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3479 xfree instead of the default malloc, realloc, free.
3480 (Fgnutls_boot): No need to check for memory allocation failure,
3481 since xmalloc does that for us.
3482
3483 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3484 * category.c (hash_get_category_set):
3485 * ccl.c (ccl_driver):
3486 * charset.c (Fdefine_charset_internal):
3487 * charset.h (struct charset.hash_index):
3488 * composite.c (get_composition_id, gstring_lookup_cache)
3489 (composition_gstring_put_cache):
3490 * composite.h (struct composition.hash_index):
3491 * dispextern.h (struct image.hash):
3492 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3493 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3494 (hashfn_equal, hashfn_user_defined, make_hash_table)
3495 (maybe_resize_hash_table, hash_lookup, hash_put)
3496 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3497 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3498 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3499 * image.c (make_image, search_image_cache, lookup_image)
3500 (xpm_put_color_table_h):
3501 * lisp.h (struct Lisp_Hash_Table):
3502 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3503 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3504 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3505 * alloc.c (allocate_vectorlike):
3506 Check for overflow in vector size calculations.
3507 * ccl.c (ccl_driver):
3508 Check for overflow when converting EMACS_INT to int.
3509 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3510 need to be updated by these changes.
3511 * fns.c (make_hash_table, maybe_resize_hash_table):
3512 Check for integer overflow with large hash tables.
3513 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3514 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3515 (SXHASH_REDUCE): New macro.
3516 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3517 Use it instead of discarding useful hash info with large hash values.
3518 (sxhash_float): New function.
3519 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3520 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3521 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3522 Rewrite to use FIXNUM_BITS, as this simplifies things.
3523 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3524 Adjust signatures to match updated version of code.
3525 (consing_since_gc): Now EMACS_INT, since a single hash table can
3526 use more than INT_MAX bytes.
3527
3528 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3529
3530 Make it possible to build with GCC-4.6+ -O2 -flto.
3531
3532 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3533
3534 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3535
3536 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3537 Call minibuffer-inactive-mode.
3538
3539 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3540
3541 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3542 Update dependencies.
3543
3544 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3545
3546 * data.c (init_data): Remove code for UTS, this system is not
3547 supported anymore.
3548
3549 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3550
3551 Don't force ./temacs to start in terminal mode.
3552
3553 * frame.c (make_initial_frame): Initialize faces in all cases, not
3554 only when CANNOT_DUMP is defined.
3555 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3556
3557 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3558
3559 * dispnew.c (add_window_display_history): Use const for the string
3560 pointer. Remove declaration, not needed.
3561
3562 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3563
3564 Use 'inline', not 'INLINE'.
3565 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3566 * alloc.c, fontset.c (INLINE): Remove.
3567 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3568 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3569 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3570 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3571 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3572
3573 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3574
3575 Make it possible to run ./temacs.
3576
3577 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3578 syms_of_callproc does the same thing. Remove test for
3579 "initialized", do it in the caller.
3580 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3581
3582 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3583
3584 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3585 (read_minibuf): Use get_minibuffer.
3586 (syms_of_minibuf): Use DEFSYM.
3587 (Qmetadata): New var.
3588 * data.c (Qbuffer): Don't make it static.
3589 (syms_of_data): Use DEFSYM.
3590
3591 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3592
3593 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3594 (CCL_CODE_MIN): New macro.
3595
3596 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3597
3598 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3599
3600 * eval.c (Qdebug): Now static.
3601 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3602 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3603 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3604
3605 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3606
3607 * image.c: Various fixes to ImageMagick code comments.
3608 (Fimagemagick_types): Doc fix.
3609
3610 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 Minor fixes prompted by GCC 4.6.0 warnings.
3613
3614 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3615
3616 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3617 (x_clipboard_manager_save_all): Move extern decl to ...
3618 * xterm.h: ... here, so that it can be checked for consistency.
3619
3620 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3621
3622 * xselect.c (x_clipboard_manager_save_frame)
3623 (x_clipboard_manager_save_all): New functions.
3624 (Fx_clipboard_manager_save): Lisp function deleted.
3625
3626 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3627 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3628
3629 * xterm.h: Update prototype.
3630
3631 2011-05-28 William Xu <william.xwl@gmail.com>
3632
3633 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3634 exiting (Bug#8239).
3635
3636 2011-05-28 Jim Meyering <meyering@redhat.com>
3637
3638 Avoid a sign-extension bug in crypto_hash_function.
3639 * fns.c (to_uchar): Define.
3640 (crypto_hash_function): Use it to convert some newly-signed
3641 variables to unsigned, to avoid sign-extension bugs. For example,
3642 without this change, (md5 "truc") would evaluate to
3643 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3644 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3645 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3646
3647 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3648
3649 Integer overflow fixes.
3650
3651 * dbusbind.c: Serial number integer overflow fixes.
3652 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3653 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3654 to hold a serial number that is too large for a fixnum.
3655 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3656 Check for serial numbers out of range. Decode any serial number
3657 that was so large that it became a float. (Bug#8722)
3658
3659 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3660 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3661 Use XFASTINT rather than XUINT when numbers are nonnegative.
3662 (xd_append_arg, Fdbus_method_return_internal):
3663 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3664 arguments, check that Lisp number is nonnegative, rather than
3665 silently wrapping negative numbers around. (Bug#8722)
3666 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3667 (Bug#8722)
3668
3669 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3670
3671 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3672
3673 ccl: add integer overflow checks
3674 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3675 (IN_INT_RANGE): New macros.
3676 (ccl_driver): Use them to check for integer overflow when
3677 decoding a CCL program. Many of the new checks are whether XINT (x)
3678 fits in int; it doesn't always, on 64-bit hosts. The new version
3679 doesn't catch all possible integer overflows, but it's an
3680 improvement. (Bug#8719)
3681
3682 * alloc.c (make_event_array): Use XINT, not XUINT.
3683 There's no need for unsigned here.
3684
3685 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3686 This follows up to the 2011-05-06 change that substituted uintptr_t
3687 for EMACS_INT. This case wasn't caught back then.
3688
3689 Rework Fformat to avoid integer overflow issues.
3690 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3691 now (part of C89). Include <verify.h>.
3692 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3693 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3694 (Fformat): Avoid the prepass trying to compute sizes; it was only
3695 approximate and thus did not catch overflow reliably. Instead, walk
3696 through the format just once, formatting and computing sizes as we go,
3697 checking for integer overflow at every step, and allocating a larger
3698 buffer as needed. Keep track separately whether the format is
3699 multibyte. Keep only the most-recently calculated precision, rather
3700 than them all. Record whether each argument has been converted to
3701 string. Use EMACS_INT, not int, for byte and char and arg counts.
3702 Support field widths and precisions larger than INT_MAX. Avoid
3703 sprintf's undefined behavior with conversion specifications such as %#d
3704 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3705 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3706 formatting out-of-range floating point numbers with int
3707 formats. (Bug#8668)
3708
3709 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3710
3711 * data.c: Avoid integer truncation in expressions involving floats.
3712 * data.c: Include <intprops.h>.
3713 (arith_driver): When there's an integer overflow in an expression
3714 involving floating point, convert the integers to floating point
3715 so that the resulting value does not suffer from catastrophic
3716 integer truncation. For example, on a 64-bit host (* 4
3717 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3718 Do not rely on undefined behavior after integer overflow.
3719
3720 merge count_size_as_multibyte, parse_str_to_multibyte
3721 * character.c, character.h (count_size_as_multibyte):
3722 Rename from parse_str_to_multibyte; all uses changed.
3723 Check for integer overflow.
3724 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3725 since it's now a duplicate of the other. This is more of
3726 a character than a buffer op, so better that it's in character.c.
3727 * fns.c, print.c: Adjust to above changes.
3728
3729 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3730
3731 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3732
3733 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3734
3735 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3736 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3737 (x_clipboard_manager_save): Now static.
3738 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3739
3740 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3741 (crypto_hash_function): Now static.
3742 Fix pointer signedness problems. Avoid unnecessary initializations.
3743
3744 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3745
3746 * termhooks.h (Vselection_alist): Make it terminal-local.
3747
3748 * terminal.c (create_terminal): Initialize it.
3749
3750 * xselect.c: Support for clipboard managers.
3751 (Vselection_alist): Move to termhooks.h as terminal-local var.
3752 (LOCAL_SELECTION): New macro.
3753 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3754 (symbol_to_x_atom): Remove gratuitous arg.
3755 (x_handle_selection_request, lisp_data_to_selection_data)
3756 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3757 (x_own_selection, x_get_local_selection, x_convert_selection):
3758 New arg, specifying work frame. Use terminal-local Vselection_alist.
3759 (some_frame_on_display): Delete unused function.
3760 (Fx_own_selection_internal, Fx_get_selection_internal)
3761 (Fx_disown_selection_internal, Fx_selection_owner_p)
3762 (Fx_selection_exists_p): New optional frame arg.
3763 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3764 (x_handle_selection_clear): Don't treat other terminals with the
3765 same keyboard specially. Use the terminal-local Vselection_alist.
3766 (x_clear_frame_selections): Use Frun_hook_with_args.
3767
3768 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3769
3770 * xterm.h: Add support for those atoms.
3771
3772 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3773
3774 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3775 (converted_selections, conversion_fail_tag): New global variables.
3776 (x_selection_request_lisp_error): Free the above.
3777 (x_get_local_selection): Remove unnecessary code.
3778 (x_reply_selection_request): Args changed; handle arbitrary array
3779 of converted selections stored in converted_selections.
3780 Separate the XChangeProperty and SelectionNotify steps.
3781 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3782 (x_convert_selection): New function.
3783 (x_handle_selection_event): Simplify.
3784 (x_get_foreign_selection): Don't ignore incoming requests while
3785 waiting for an answer; this will fail when we implement
3786 SAVE_TARGETS, and seems unnecessary anyway.
3787 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3788 (Vx_sent_selection_functions): Doc fix.
3789
3790 2011-05-26 Leo Liu <sdl.web@gmail.com>
3791
3792 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3793
3794 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3795
3796 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3797
3798 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3799 for fringe update if it has periodic bitmap.
3800 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3801 and fringe_bitmap_periodic_p.
3802
3803 * fringe.c (get_fringe_bitmap_data): New function.
3804 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3805 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3806 row. Mark glyph row for fringe update if periodicity changed.
3807
3808 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3809 for fringe update unless it has periodic bitmap.
3810
3811 2011-05-25 Kenichi Handa <handa@m17n.org>
3812
3813 * xdisp.c (get_next_display_element): Set correct it->face_id for
3814 a static composition.
3815
3816 2011-05-24 Leo Liu <sdl.web@gmail.com>
3817
3818 * deps.mk (fns.o):
3819 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3820
3821 * fns.c (crypto_hash_function, Fsha1): New function.
3822 (Fmd5): Use crypto_hash_function.
3823 (syms_of_fns): Add Ssha1.
3824
3825 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3826
3827 * gnutls.c: Remove unused macros.
3828 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3829 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3830 Remove macros that are defined and never used.
3831 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3832
3833 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3834
3835 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3836 (Fx_get_selection_internal): Minor cleanup.
3837 (Fx_own_selection_internal): Rename arguments for consistency with
3838 select.el.
3839
3840 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3841
3842 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3843
3844 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3845
3846 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3847
3848 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3849
3850 * dispnew.c (scrolling_window): Don't exclude the case that the
3851 last enabled row in the desired matrix touches the bottom boundary.
3852
3853 2011-05-21 Glenn Morris <rgm@gnu.org>
3854
3855 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3856 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3857 and add some more files.
3858
3859 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3860
3861 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3862 report_file_error introduced by the change from 2011-05-07.
3863
3864 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3865
3866 * systime.h (Time): Define only if emacs is defined.
3867 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3868 where the include path doesn't have X11/X.h by default. See
3869 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3870
3871 2011-05-20 Kenichi Handa <handa@m17n.org>
3872
3873 * composite.c (find_automatic_composition): Fix previous change.
3874
3875 2011-05-20 Glenn Morris <rgm@gnu.org>
3876
3877 * lisp.mk: New file, split from Makefile.in.
3878 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3879 (shortlisp): Remove.
3880 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3881
3882 2011-05-19 Glenn Morris <rgm@gnu.org>
3883
3884 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3885 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3886 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3887 (lisp): Set the order to that of loadup.el.
3888 (shortlisp): Make it a copy of $lisp.
3889 (SOME_MACHINE_LISP): Remove.
3890 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3891 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3892
3893 2011-05-18 Kenichi Handa <handa@m17n.org>
3894
3895 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3896 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3897 (find_automatic_composition): Mostly rewrite for efficiency.
3898
3899 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3900
3901 * makefile.w32-in: Update dependencies.
3902
3903 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3904
3905 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3906 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3907
3908 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3909
3910 Fix some integer overflow issues, such as string length overflow.
3911
3912 * insdel.c (count_size_as_multibyte): Check for string overflow.
3913
3914 * character.c (lisp_string_width): Check for string overflow.
3915 Use EMACS_INT, not int, for string indexes and lengths; in
3916 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3917 the resulting string length overflows an EMACS_INT; instead,
3918 report a string overflow if no precision given. When checking for
3919 precision exhaustion, use a check that cannot possibly have
3920 integer overflow. (Bug#8675)
3921 * character.h (lisp_string_width): Adjust to new signature.
3922
3923 * alloc.c (string_overflow): New function.
3924 (Fmake_string): Use it. This doesn't change behavior, but saves
3925 a few bytes and will simplify future changes.
3926 * character.c (string_escape_byte8): Likewise.
3927 * lisp.h (string_overflow): New decl.
3928
3929 Fixups, following up to the user-interface timestamp change.
3930 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3931 for UI timestamps, instead of unsigned long.
3932 * msdos.c (mouse_get_pos): Likewise.
3933 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3934 * w32gui.h (Time): Define by including "systime.h" rather than by
3935 declaring it ourselves. (Bug#8664)
3936
3937 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3938 * image.c (clear_image_cache): Likewise.
3939
3940 * term.c (term_mouse_position): Don't assume time_t wraparound.
3941
3942 Be more systematic about user-interface timestamps.
3943 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3944 and sometimes 'EMACS_UINT', to represent these timestamps.
3945 This change causes it to use 'Time' uniformly, as that's what X uses.
3946 This makes the code easier to follow, and makes it easier to catch
3947 integer overflow bugs such as Bug#8664.
3948 * frame.c (Fmouse_position, Fmouse_pixel_position):
3949 Use Time, not unsigned long, for user-interface timestamps.
3950 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3951 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3952 * keyboard.h (last_event_timestamp): Likewise.
3953 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3954 * menu.h (xmenu_show): Likewise.
3955 * term.c (term_mouse_position): Likewise.
3956 * termhooks.h (struct input_event.timestamp): Likewise.
3957 (struct terminal.mouse_position_hook): Likewise.
3958 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3959 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3960 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3961 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3962 what it was before.
3963 * menu.h, termhooks.h: Include "systime.h", for Time.
3964
3965 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3966 Don't assume that the difference between two unsigned long values
3967 can fit into an integer. At this point, we know button_down_time
3968 <= event->timestamp, so the difference must be nonnegative, so
3969 there's no need to cast the result if double-click-time is
3970 nonnegative, as it should be; check that it's nonnegative, just in
3971 case. This bug is triggered when events are more than 2**31 ms
3972 apart (about 25 days). (Bug#8664)
3973
3974 * xselect.c (last_event_timestamp): Remove duplicate decl.
3975 (x_own_selection): Remove needless cast to unsigned long.
3976
3977 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3978 that always fit in int. Use a sentinel instead of a counter, to
3979 avoid a temp and to allay GCC's concerns about possible int overflow.
3980 * frame.h (struct frame): Use int for menu_bar_items_used
3981 instead of EMACS_INT, since it always fits in int.
3982
3983 * menu.c (grow_menu_items): Check for int overflow.
3984
3985 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3986
3987 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3988 Before, the code was not consistent. These values cannot exceed
3989 2**31 - 1 so there's no need to make them unsigned.
3990 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3991 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3992 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3993 as modifiers.
3994 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3995
3996 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3997 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3998 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3999 presumably because the widths might not match.
4000
4001 * window.c (size_window): Avoid needless test at loop start.
4002
4003 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4004
4005 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4006
4007 2011-05-12 Drew Adams <drew.adams@oracle.com>
4008
4009 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4010
4011 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4012
4013 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4014 `width' to `bar_area_x' and `bar_area_width', respectively.
4015 (x_scroll_run): Take account of fringe background extension.
4016
4017 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4018 Rename local vars `left' and `width' to `bar_area_x' and
4019 `bar_area_width', respectively.
4020 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4021 background extension.
4022
4023 2011-05-10 Jim Meyering <meyering@redhat.com>
4024
4025 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4026
4027 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4028
4029 * image.c (Finit_image_library): Return t for built-in image types,
4030 like pbm and xbm. (Bug#8640)
4031
4032 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4033
4034 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4035
4036 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4037
4038 * w32console.c (Fset_screen_color): Doc fix.
4039 (Fget_screen_color): New function.
4040 (syms_of_ntterm): Defsubr it.
4041
4042 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4043 unlink the temporary file if Fcall_process didn't create it in the
4044 first place.
4045 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4046 child process will be redirected to a file specified with `:file'.
4047 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4048 cue to call_process_cleanup not to close that handle.
4049
4050 2011-05-07 Ben Key <bkey76@gmail.com>
4051
4052 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4053 one of two shell specific rules, either bootstrap-temacs-CMD or
4054 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4055 to the previous implementation of the bootstrap-temacs rule.
4056 The bootstrap-temacs-CMD rule is similar to the previous
4057 implementation of the bootstrap-temacs rule except that it
4058 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4059 variable.
4060
4061 These changes, along with some changes to nt/configure.bat,
4062 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4063 earlier fix to add support for --cflags and --ldflags options
4064 that include quotes so that it works whether make uses cmd or
4065 sh as the shell.
4066
4067 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4068
4069 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4070 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4071 is a constant.
4072 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4073 a string. Handle both cases.
4074 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4075 (Fdbus_register_method): Use Qinvalid_function.
4076
4077 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4078
4079 * makefile.w32-in: Update dependencies.
4080 (LISP_H): Add inttypes.h and stdin.h.
4081 (PROCESS_H): Add unistd.h.
4082
4083 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4084
4085 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4086 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4087
4088 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4089
4090 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4091
4092 * term.c (vfatal): Remove stray call to va_end.
4093 It's not needed and the C Standard doesn't allow it here anyway.
4094
4095 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4096 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4097
4098 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4099 bytes.
4100
4101 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4102
4103 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4104
4105 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4106
4107 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4108
4109 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4110
4111 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4112 * charset.c (Fdefine_charset_internal): Don't initialize
4113 charset.code_space[15]. The value was garbage, on hosts with
4114 32-bit int (Bug#8600).
4115
4116 * lread.c (read_integer): Be more consistent with string-to-number.
4117 Use string_to_number to do the actual conversion; this avoids
4118 rounding errors and fixes some other screwups. Without this fix,
4119 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4120 (digit_to_number): Move earlier, for benefit of read_integer.
4121 Return -1 if the digit is out of range for the base, -2 if it is
4122 not a digit in any supported base. (Bug#8602)
4123
4124 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4125
4126 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4127 to match comment at start of function. This also removes a
4128 GCC warning about overflow in a 32+64-bit port.
4129
4130 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4131
4132 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4133 Reported by Stefan Monnier in
4134 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4135 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4136 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4137
4138 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4139 (EMACS_UINTPTR): Likewise, with uintptr_t.
4140
4141 * lisp.h: Prefer 64-bit EMACS_INT if available.
4142 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4143 on 32-bit hosts that have 64-bit int, so that they can access
4144 large files.
4145 However, temporarily disable this change unless the temporary
4146 symbol WIDE_EMACS_INT is defined.
4147
4148 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4149
4150 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4151 This removes an assumption that EMACS_INT and long are the same
4152 width as pointers. The assumption is true for Emacs porting targets
4153 now, but we want to make other targets possible.
4154 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4155 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4156 In the rest of the code, change types of integers that hold casted
4157 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4158 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4159 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4160 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4161 No need to cast type when ORing.
4162 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4163 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4164 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4165 assume EMACS_INT is the same width as char *.
4166 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4167 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4168 Remove no-longer-needed casts.
4169 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4170 (xg_tool_bar_help_callback, xg_make_tool_item):
4171 Use EMACS_INTPTR to hold an integer
4172 that will be cast to void *; this can avoid a GCC warning
4173 if EMACS_INT is not the same width as void *.
4174 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4175 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4176 (current_message_1, set_message_1):
4177 Use a local to convert to proper width without a cast.
4178 * xmenu.c (dialog_selection_callback): Likewise.
4179
4180 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4181 Also, don't assume VALBITS / RAND_BITS is less than 5,
4182 and don't rely on undefined behavior when shifting a 1 left into
4183 the sign bit.
4184 * lisp.h (get_random): Change signature to match.
4185
4186 * lread.c (hash_string): Use size_t, not int, for hash computation.
4187 Normally we prefer signed values; but hashing is special, because
4188 it's better to use unsigned division on hash table sizes so that
4189 the remainder is nonnegative. Also, size_t is the natural width
4190 for hashing into memory. The previous code used 'int', which doesn't
4191 retain enough info to hash well into very large tables.
4192 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4193
4194 * dbusbind.c: Don't possibly lose pointer info when converting.
4195 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4196 Use XPNTR rather than XHASH, so that the high-order bits of
4197 the pointer aren't lost when converting through void *.
4198
4199 * eval.c (Fautoload): Don't double-shift a pointer.
4200
4201 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4202
4203 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4204
4205 * gnutls.c (DEF_GNUTLS_FN):
4206 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4207
4208 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4209
4210 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4211 marker. (Bug#8610)
4212
4213 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4214
4215 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4216 New version that can reserve upto 2GB of heap space.
4217
4218 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4219
4220 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4221
4222 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4223
4224 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4225 `gnutls_certificate_set_x509_key_file'.
4226
4227 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4228
4229 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4230 Update dependencies.
4231
4232 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4233
4234 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4235 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4236 Remove unused parameter `fildes'.
4237 * process.c (read_process_output, send_process): Don't pass it.
4238
4239 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4240
4241 Fix previous change: the library cache is defined in w32.c.
4242 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4243 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4244
4245 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4246
4247 Implement dynamic loading of GnuTLS on Windows.
4248
4249 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4250 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4251 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4252 Declare.
4253
4254 * gnutls.c (Qgnutls_dll): Define.
4255 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4256 (gnutls_*): Declare function pointers.
4257 (init_gnutls_functions): New function to initialize function pointers.
4258 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4259 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4260 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4261 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4262 (emacs_gnutls_write, emacs_gnutls_read)
4263 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4264 (Fgnutls_available_p): New function.
4265 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4266 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4267 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4268
4269 * image.c: Include w32.h.
4270 (Vimage_type_cache): Delete.
4271 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4272 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4273 (w32_delayed_load): Move to w32.c.
4274
4275 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4276
4277 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4278 (w32_delayed_load): Move from image.c. When loading a library, record
4279 its filename in the :loaded-from property of the library id.
4280 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4281 Initialize and staticpro them.
4282 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4283
4284 * process.c: Include lisp.h before w32.h, not after.
4285 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4286 instead of gnutls_record_check_pending.
4287
4288 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4289
4290 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4291
4292 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4293 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4294 as passed in.
4295
4296 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4297
4298 * xterm.c (x_set_frame_alpha): Do not set property on anything
4299 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4300
4301 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4302
4303 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4304
4305 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4306
4307 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4308 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4309 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4310 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4311 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4312 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4313 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4314 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4315 (Qgnutls_bootprop_callbacks_verify): Make static.
4316
4317 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4318
4319 * callproc.c: Indentation fixup.
4320
4321 * sysdep.c (wait_for_termination_1): Make static.
4322 (wait_for_termination, interruptible_wait_for_termination):
4323 Move after wait_for_termination_1.
4324
4325 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4326
4327 * sysdep.c (interruptible_wait_for_termination): New function
4328 which is like wait_for_termination, but allows keyboard
4329 interruptions.
4330
4331 * callproc.c (Fcall_process): Add (:file "file") as an option for
4332 the STDOUT buffer.
4333 (Fcall_process_region): Ditto.
4334
4335 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4336
4337 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4338 rather than `XVECTOR (FOO)->size'.
4339
4340 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4341 inttypes.h, as a gnulib replacement is used if it not available in
4342 system headers.
4343
4344 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4345
4346 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4347 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4348 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4349
4350 * coding.c (coding_alloc_by_realloc): Error out if destination
4351 will grow beyond MOST_POSITIVE_FIXNUM.
4352 (decode_coding_emacs_mule): Abort if there isn't enough place in
4353 charbuf for the composition carryover bytes. Reserve an extra
4354 space for up to 2 characters produced in a loop.
4355 (decode_coding_iso_2022): Abort if there isn't enough place in
4356 charbuf for the composition carryover bytes.
4357
4358 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4359
4360 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4361 aborting when %lld or %lll format is passed.
4362 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4363 %llo or %llx format is passed. (Bug#8545)
4364
4365 * window.c (window_scroll_line_based): Use a marker instead of
4366 simple variables to record original value of point. (Bug#7952)
4367
4368 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4369 produced by %s or %c overflows available buffer space. (Bug#8545)
4370
4371 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4372
4373 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4374 (SIZE_MAX): Move defn after all includes, as they might #define it.
4375
4376 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4377
4378 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4379
4380 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4381
4382 * keyboard.c (Qdelayed_warnings_hook): Define.
4383 (command_loop_1): Run `delayed-warnings-hook'
4384 if Vdelayed_warnings_list is non-nil.
4385 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4386 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4387
4388 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4389
4390 * doprnt.c (doprnt): Don't return value smaller than the buffer
4391 size if the message was truncated. (Bug#8545).
4392
4393 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4394
4395 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4396 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4397
4398 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4399
4400 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4401
4402 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4403
4404 * makefile.w32-in: Update dependencies.
4405
4406 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4407
4408 Improve `doprnt' and its usage. (Bug#8545)
4409 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4410 `format_end'. Remove support for %l as a conversion specifier.
4411 Don't use xrealloc. Improve diagnostics when the %l size modifier
4412 is used. Update the commentary.
4413
4414 * eval.c (verror): Simplify calculation of size_t.
4415
4416 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4417 messages.
4418
4419 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4420
4421 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4422 change.
4423
4424 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4425
4426 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4427 This makes this file independent of the recent pseudovector change.
4428
4429 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4430
4431 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4432
4433 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4434 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4435 Remove unused local.
4436 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4437
4438 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4439 GCC 4.6.0 optimizes based on type-based alias analysis.
4440 For example, if b is of type struct buffer * and v of type struct
4441 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4442 != &v->size, and therefore "v->size = 1; b->size = 2; return
4443 v->size;" must therefore return 1. This assumption is incorrect
4444 for Emacs, since it type-puns struct Lisp_Vector * with many other
4445 types. To fix this problem, this patch adds a new type struct
4446 vectorlike_header that documents the constraints on layout of vectors
4447 and pseudovectors, and helps optimizing compilers not get fooled
4448 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4449 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4450 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4451 the size member.
4452 (XSETPVECTYPE): Rewrite in terms of new macro.
4453 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4454 This is a bit clearer, and further avoids the possibility of
4455 undesirable aliasing.
4456 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4457 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4458 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4459 since Lisp_Subr is a special case (no "next" field).
4460 (ASIZE): Now uses header.size rather than size.
4461 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4462 to avoid the hassle of writing XVECTOR (foo)->header.size.
4463 (struct vectorlike_header): New type.
4464 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4465 object, to help avoid aliasing.
4466 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4467 (SUBRP): Likewise, since Lisp_Subr is a special case.
4468 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4469 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4470 (struct Lisp_Hash_Table): Combine first two members into a single
4471 struct vectorlike_header member. All uses of "size" and "next" members
4472 changed to be "header.size" and "header.next".
4473 * buffer.h (struct buffer): Likewise.
4474 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4475 * frame.h (struct frame): Likewise.
4476 * process.h (struct Lisp_Process): Likewise.
4477 * termhooks.h (struct terminal): Likewise.
4478 * window.c (struct save_window_data, struct saved_window): Likewise.
4479 * window.h (struct window): Likewise.
4480 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4481 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4482 * buffer.c (init_buffer_once): Likewise.
4483 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4484 special case.
4485 * process.c (Fformat_network_address): Use local var for size,
4486 for brevity.
4487
4488 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4489
4490 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4491 * data.c (atof): Remove decl; no longer used or needed.
4492 (digit_to_number): Move to lread.c.
4493 (Fstring_to_number): Use new string_to_number function, to be
4494 consistent with how the Lisp reader treats infinities and NaNs.
4495 Do not assume that floating-point numbers represent EMACS_INT
4496 without losing information; this is not true on most 64-bit hosts.
4497 Avoid double-rounding errors, by insisting on integers when
4498 parsing non-base-10 numbers, as the documentation specifies.
4499 * lisp.h (string_to_number): New decl, replacing ...
4500 (isfloat_string): Remove.
4501 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4502 (read1): Do not accept +. and -. as integers; this
4503 appears to have been a coding error. Similarly, do not accept
4504 strings like +-1e0 as floating point numbers. Do not report
4505 overflow for integer overflows unless the base is not 10 which
4506 means we have no simple and reliable way to continue.
4507 Break out the floating-point parsing into a new
4508 function string_to_number, so that Fstring_to_number parses
4509 floating point numbers consistently with the Lisp reader.
4510 (digit_to_number): Move here from data.c. Make it static inline.
4511 (E_CHAR, EXP_INT): Remove, replacing with ...
4512 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4513 (string_to_number): New function, replacing isfloat_string.
4514 This function checks for valid syntax and produces the resulting
4515 Lisp float number too. Rework it so that string-to-number
4516 no longer mishandles examples like "1.0e+". Use strtoumax,
4517 so that overflow for non-base-10 numbers is reported only when
4518 there's no portable and simple way to convert to floating point.
4519
4520 * textprop.c (set_text_properties_1): Rewrite for clarity,
4521 and to avoid GCC warning about integer overflow.
4522
4523 * intervals.h (struct interval): Use EMACS_INT for members
4524 where EMACS_UINT might cause problems. See
4525 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4526 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4527 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4528 All uses changed.
4529 (offset_intervals): Tell GCC not to worry about length overflow
4530 when negating a negative length.
4531
4532 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4533 (overrun_check_free): Likewise.
4534
4535 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4536 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4537 word size.
4538
4539 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4540 (gnutls_make_error): Rename local to avoid shadowing.
4541 (gnutls_emacs_global_deinit): ifdef out; not used.
4542 (Fgnutls_boot): Use const for pointer to readonly storage.
4543 Comment out unused local. Fix pointer signedness problems.
4544
4545 * lread.c (openp): Don't stuff size_t into an 'int'.
4546 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4547 about possible signed overflow.
4548
4549 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4550 (GDK_KEY_g): Don't define if already defined.
4551 (xg_prepare_tooltip): Avoid pointer signedness problem.
4552 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4553
4554 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4555 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4556
4557 * xfns.c (Fx_window_property): Simplify a bit,
4558 to make a bit faster and to avoid GCC 4.6.0 warning.
4559 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4560
4561 * fns.c (internal_equal): Don't assume size_t fits in int.
4562
4563 * alloc.c (compact_small_strings): Tighten assertion a little.
4564
4565 Replace pEd with more-general pI, and fix some printf arg casts.
4566 * lisp.h (pI): New macro, generalizing old pEd macro to other
4567 conversion specifiers. For example, use "...%"pI"d..." rather
4568 than "...%"pEd"...".
4569 (pEd): Remove. All uses replaced with similar uses of pI.
4570 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4571 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4572 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4573 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4574 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4575 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4576 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4577 64-bit hosts.
4578 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4579 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4580 * print.c (safe_debug_print, print_object): Likewise.
4581 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4582 to int.
4583 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4584 avoiding the 0 flag, which is not portable.
4585 * process.c (Fmake_network_process): Use pI to avoid cast.
4586 * region-cache.c (pp_cache): Likewise.
4587 * xdisp.c (decode_mode_spec): Likewise.
4588 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4589 behavior on 64-bit hosts with printf arg.
4590 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4591 (x_stop_queuing_selection_requests): Likewise.
4592 (x_get_window_property): Don't truncate byte count to an 'int'
4593 when tracing.
4594
4595 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4596 here, since it parses constructs like leading '-' and spaces,
4597 which are not wanted; and it overflows with large numbers.
4598 Instead, simply match F[0-9]+, which is what is wanted anyway.
4599
4600 * alloc.c: Remove unportable assumptions about struct layout.
4601 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4602 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4603 (allocate_vectorlike, make_pure_vector): Use the new macros,
4604 plus offsetof, to remove unportable assumptions about struct layout.
4605 These assumptions hold on all porting targets that I know of, but
4606 they are not guaranteed, they're easy to remove, and removing them
4607 makes further changes easier.
4608
4609 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4610 This doesn't fix a bug but makes the code clearer.
4611 (string_overrun_cookie): Now const. Use initializers that
4612 don't formally overflow signed char, to avoid warnings.
4613 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4614 can cause Emacs to crash when string overrun checking is enabled.
4615 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4616 multiple of sizeof (EMACS_INT); it need not be, if
4617 alignof(EMACS_INT) < sizeof (EMACS_INT).
4618 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4619
4620 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4621
4622 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4623
4624 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4625
4626 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4627 supposed to be handshaking. (Bug#8556)
4628 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4629
4630 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4631
4632 * lisp.h (Qdebug): List symbol.
4633 * eval.c (Qdebug): Restore global linkage.
4634 * keyboard.c (debug-on-event): New variable.
4635 (handle_user_signal): Break into debugger when debug-on-event
4636 matches the current signal symbol.
4637
4638 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4639
4640 * alloc.c (check_sblock, check_string_bytes)
4641 (check_string_free_list): Convert to standard C.
4642
4643 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4644
4645 * w32.c (emacs_gnutls_push): Fix typo.
4646
4647 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4648
4649 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4650 "cast to pointer from integer of different size".
4651
4652 Improve doprnt and its use in verror. (Bug#8545)
4653 * doprnt.c (doprnt): Document the set of format control sequences
4654 supported by the function. Use SAFE_ALLOCA instead of always
4655 using `alloca'.
4656
4657 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4658 is one byte too soon. Don't use xrealloc; instead xfree and
4659 xmalloc anew.
4660
4661 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4662
4663 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4664 callbacks stage.
4665
4666 * gnutls.c: Renamed global_initialized to
4667 gnutls_global_initialized. Added internals for the
4668 :verify-hostname-error, :verify-error, and :verify-flags
4669 parameters of `gnutls-boot' and documented those parameters in the
4670 docstring. Start callback support.
4671 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4672 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4673 on error. Return error code.
4674 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4675 (emacs_gnutls_read): Likewise.
4676 (Fgnutls_boot): Return handshake error code.
4677 (emacs_gnutls_handle_error): New function.
4678 (wsaerror_to_errno): Likewise.
4679
4680 * w32.h (emacs_gnutls_pull): Add prototype.
4681 (emacs_gnutls_push): Likewise.
4682
4683 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4684 (emacs_gnutls_push): Likewise.
4685
4686 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4687
4688 * process.c (wait_reading_process_output): Check if GnuTLS
4689 buffered some data internally if no FDs are set for TLS
4690 connections.
4691
4692 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4693 (LIBS): Link to USER_LIBS.
4694 ($(BLD)/gnutls.$(0)): New target.
4695
4696 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4697
4698 * xdisp.c (handle_single_display_spec): Rename the
4699 display_replaced_before_p argument into display_replaced_p, to
4700 make it consistent with the commentary. Fix typos in the
4701 commentary.
4702
4703 * textprop.c (syms_of_textprop): Remove dead code.
4704 (copy_text_properties): Delete obsolete commentary about an
4705 interface that was deleted long ago. Fix typos in the description
4706 of arguments.
4707
4708 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4709 to changes in oldXMenu/XMenu.h from 2011-04-16.
4710 <menu_help_message, prev_menu_help_message>: Constify.
4711 (IT_menu_make_room): menu->help_text is now `const char **';
4712 adjust.
4713
4714 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4715 to changes in oldXMenu/XMenu.h from 2011-04-16.
4716 (struct XMenu): Declare `help_text' `const char **'.
4717
4718 * xfaces.c <Qunspecified>: Make extern again.
4719
4720 * syntax.c: Include sys/types.h before including regex.h, as
4721 required by Posix.
4722
4723 * doc.c (get_doc_string): Improve the format passed to `error'.
4724
4725 * doprnt.c (doprnt): Improve commentary.
4726
4727 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4728
4729 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4730 them with etags.
4731
4732 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4733 changes in globals.h immediately force recompilation.
4734 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4735 $(CURDIR)/s/ms-w32.h.
4736 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4737
4738 * character.c (Fchar_direction): Function deleted.
4739 (syms_of_character): Don't defsubr it.
4740 <char-direction-table>: Deleted.
4741
4742 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4743
4744 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4745 * doprnt.c: Include limits.h.
4746 (SIZE_MAX): New macro.
4747 (doprnt): Return a size_t value. 2nd arg is now size_t.
4748 Many local variables are now size_t instead of int or unsigned.
4749 Improve overflow protection. Support `l' modifier for integer
4750 conversions. Support %l conversion. Don't assume an EMACS_INT
4751 argument for integer conversions and for %c.
4752
4753 * lisp.h (doprnt): Restore prototype.
4754
4755 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4756 $(SRC)/character.h.
4757
4758 * Makefile.in (base_obj): Add back doprnt.o.
4759
4760 * deps.mk (doprnt.o): Add back prerequisites.
4761 (callint.o): Depend on character.h.
4762
4763 * eval.c (internal_lisp_condition_case): Include the handler
4764 representation in the error message.
4765 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4766 when breaking from the loop.
4767
4768 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4769
4770 * callint.c (Fcall_interactively): When displaying error message
4771 about invalid control letter, pass the character's codepoint, not
4772 a pointer to its multibyte form. Improve display of the character
4773 in octal and display also its hex code.
4774
4775 * character.c (char_string): Use %x to display the (unsigned)
4776 codepoint of an invalid character, to avoid displaying a bogus
4777 negative value.
4778
4779 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4780 `error', not SYMBOL_NAME itself.
4781
4782 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4783 character arguments to `error'.
4784
4785 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4786 to `error' in error message about FINAL_CHAR argument. Make sure
4787 FINAL_CHAR is a character, and use %c when it is passed as
4788 argument to `error'.
4789
4790 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4791
4792 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4793
4794 * w32.c: Include <time.h>.
4795 (sys_localtime): New function.
4796
4797 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4798
4799 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4800
4801 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4802
4803 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4804
4805 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4806 zombies (Bug#8467).
4807
4808 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4809
4810 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4811 gl_state.e_property when gl_state.object is Qt.
4812
4813 * insdel.c (make_gap_larger): Remove limitation of buffer size
4814 to <= INT_MAX.
4815
4816 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4817
4818 * xdisp.c (lookup_glyphless_char_display)
4819 (produce_glyphless_glyph): Handle cons cell entry in
4820 glyphless-char-display.
4821 (Vglyphless_char_display): Document it.
4822
4823 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4824 glyphless-char-display.
4825
4826 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4827
4828 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4829
4830 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4831
4832 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4833 definition for no-X builds.
4834
4835 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4836
4837 Static checks with GCC 4.6.0 and non-default toolkits.
4838
4839 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4840
4841 * process.c (keyboard_bit_set): Define only if SIGIO.
4842 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4843 (send_process): Repair possible setjmp clobbering.
4844
4845 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4846
4847 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4848
4849 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4850
4851 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4852 Define only if needed.
4853
4854 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4855 by pacifying GCC about it. Maybe it's time to retire it?
4856 * xfaces.c (USG, __TIMEVAL__): Likewise.
4857
4858 * dispextern.h (struct redisplay_interface): Rename param
4859 to avoid shadowing.
4860 * termhooks.h (struct terminal): Likewise.
4861 * xterm.c (xembed_send_message): Likewise.
4862
4863 * insdel.c (make_gap_smaller): Define only if
4864 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4865
4866 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4867 it.
4868
4869 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4870 so that we aren't warned about unused symbols.
4871
4872 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4873
4874 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4875
4876 * xfns.c (x_real_positions): Mark locals as initialized.
4877
4878 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4879
4880 * xterm.c: Fix problems found by static analysis with other toolkits.
4881 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4882 (x_dispatch_event): Declare static if USE_GTK, and
4883 define if USE_GTK || USE_X_TOOLKIT.
4884 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4885 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4886 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4887 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4888
4889 * xmenu.c (menu_help_callback): Pointer type fixes.
4890 Use const pointers when pointing at readonly data. Avoid pointer
4891 signedness clashes.
4892 (FALSE): Remove unused macro.
4893 (update_frame_menubar): Remove unused decl.
4894
4895 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4896
4897 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4898 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4899 (single_menu_item): Rename local to avoid shadowing.
4900
4901 * keyboard.c (make_lispy_event): Remove unused local var.
4902
4903 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4904 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4905
4906 * bitmaps: Change bitmaps from unsigned char back to the X11
4907 compatible char. Avoid the old compiler warnings about
4908 out-of-range initializers by using, for example, '\xab' rather
4909 than 0xab.
4910
4911 * xgselect.c (xgselect_initialize): Check vs interface
4912 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4913
4914 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4915
4916 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4917 to read-only memory.
4918
4919 * fns.c (vector): Remove; this old hack is no longer needed.
4920
4921 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4922 Remove unused var.
4923 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4924
4925 * xrdb.c (x_load_resources): Omit unused local.
4926
4927 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4928 (x_window): Rename locals to avoid shadowing.
4929 (USG): Use the kludged USG macro, to pacify gcc.
4930
4931 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4932 (x_term_init): Remove local to avoid shadowing.
4933
4934 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4935
4936 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4937 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4938
4939 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4940
4941 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4942
4943 Fix regex.c, syntax.c and friends for buffers > 2GB.
4944 * syntax.h (struct gl_state_s): Declare character position members
4945 EMACS_INT.
4946
4947 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4948
4949 * textprop.c (verify_interval_modification, interval_of):
4950 Declare arguments EMACS_INT.
4951
4952 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4953 EMACS_INT.
4954
4955 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4956
4957 * indent.c (Fvertical_motion): Local variable it_start is now
4958 EMACS_INT.
4959
4960 * regex.c (re_match, re_match_2, re_match_2_internal)
4961 (bcmp_translate, regcomp, regexec, print_double_string)
4962 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4963 (re_compile_pattern, re_exec): Declare arguments and local
4964 variables `size_t' and `ssize_t' and return values `regoff_t', as
4965 appropriate.
4966 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4967 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4968 <compile_stack_type>: `size' and `avail' are now `size_t'.
4969
4970 * regex.h <regoff_t>: Use ssize_t, not int.
4971 (re_search, re_search_2, re_match, re_match_2): Arguments that
4972 specify buffer/string position and length are now ssize_t and
4973 size_t. Return type is regoff_t.
4974
4975 2011-04-16 Ben Key <bkey76@gmail.com>
4976
4977 * nsfont.m: Fixed bugs in ns_get_family and
4978 ns_descriptor_to_entity that were caused by using free to
4979 deallocate memory blocks that were allocated by xmalloc (via
4980 xstrdup). This caused Emacs to crash when compiled with
4981 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4982 --enable-checking=xmallocoverrun). xfree is now used to
4983 deallocate these memory blocks.
4984
4985 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4986
4987 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4988
4989 emacs_write: Accept and return EMACS_INT for sizes.
4990 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4991 et seq.
4992 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4993 Accept and return EMACS_INT.
4994 (emacs_gnutls_write): Return the number of bytes written on
4995 partial writes.
4996 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4997 (emacs_read, emacs_write): Remove check for negative size, as the
4998 Emacs source code has been audited now.
4999 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5000 (emacs_read, emacs_write): Use it.
5001 * process.c (send_process): Adjust to the new signatures of
5002 emacs_write and emacs_gnutls_write. Do not attempt to store
5003 a byte offset into an 'int'; it might overflow.
5004 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5005
5006 * sound.c: Don't assume sizes fit in 'int'.
5007 (struct sound_device.period_size, alsa_period_size):
5008 Return EMACS_INT, not int.
5009 (struct sound_device.write, vox_write, alsa_write):
5010 Accept EMACS_INT, not int.
5011 (wav_play, au_play): Use EMACS_INT to store sizes and to
5012 record read return values.
5013
5014 2011-04-15 Ben Key <bkey76@gmail.com>
5015
5016 * keyboard.c (Qundefined): Don't declare static since it is used
5017 in nsfns.m.
5018 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5019 static since they are used in nsfont.m.
5020
5021 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5022
5023 * process.c (Qprocessp): Don't declare static.
5024 * lisp.h (Qprocessp): Declare again.
5025
5026 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5027
5028 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5029
5030 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5031
5032 Improve C-level modularity by making more things 'static'.
5033
5034 Don't publish debugger-only interfaces to other modules.
5035 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5036 (verify_bytepos, count_markers): Move decls to the only modules
5037 that need them.
5038 * region-cache.h (pp_cache): Likewise.
5039 * window.h (check_all_windows): Likewise.
5040 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5041
5042 * sysdep.c (croak): Now static, if
5043 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5044 * syssignal.h (croak): Declare only if not static.
5045
5046 * alloc.c (refill_memory_reserve): Now static if
5047 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5048 * lisp.h (refill_memory_reserve): Declare only if not static.
5049
5050 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5051 Define only if USE_LUCID.
5052
5053 * xrdb.c (x_customization_string, x_rm_string): Now static.
5054
5055 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5056 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5057
5058 * xdisp.c (draw_row_with_mouse_face): Now static.
5059 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5060
5061 * window.h (check_all_windows): Mark externally visible.
5062
5063 * window.c (window_deletion_count): Now static.
5064
5065 * undo.c: Make symbols static if they're not exported.
5066 (last_undo_buffer, last_boundary_position, pending_boundary):
5067 Now static.
5068
5069 * textprop.c (interval_insert_behind_hooks): Now static.
5070 (interval_insert_in_front_hooks): Likewise.
5071
5072 * term.c: Make symbols static if they're not exported.
5073 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5074 (max_frame_lines, tty_set_terminal_modes):
5075 (tty_reset_terminal_modes, tty_turn_off_highlight):
5076 (get_tty_terminal): Now static.
5077 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5078 * termhooks.h (term_mouse_moveto): Do not declare if
5079 HAVE_WINDOW_SYSTEM.
5080 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5081 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5082
5083 * sysdep.c: Make symbols static if they're not exported.
5084 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5085 Now static.
5086 (sigprocmask_set, full_mask): Remove; unused.
5087 (wait_debugging): Mark as visible.
5088 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5089 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5090
5091 * syntax.c (syntax_temp): Define only if !__GNUC__.
5092
5093 * sound.c (current_sound_device, current_sound): Now static.
5094
5095 * search.c (searchbufs, searchbuf_head): Now static.
5096
5097 * scroll.c (scroll_cost): Remove; unused.
5098 * dispextern.h (scroll_cost): Remove decl.
5099
5100 * region-cache.h (pp_cache): Mark as externally visible.
5101
5102 * process.c: Make symbols static if they're not exported.
5103 (process_tick, update_tick, create_process, chan_process):
5104 (Vprocess_alist, proc_buffered_char, datagram_access):
5105 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5106 (deactivate_process): Mark defn as static, as well as decl.
5107 * lisp.h (create_process): Remove decl.
5108 * process.h (chan_process, Vprocess_alist): Remove decls.
5109
5110 * print.c: Make symbols static if they're not exported.
5111 (print_depth, new_backquote_output, being_printed, print_buffer):
5112 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5113 (print_interval, print_number_index, initial_stderr_stream):
5114 Now static.
5115 * lisp.h (Fprinc): Remove decl.
5116 (debug_output_compilation_hack): Mark as externally visible.
5117
5118 * sysdep.c (croak): Move decl from here to syssignal.h.
5119 * syssignal.h (croak): Put it here, so the API can be checked when
5120 'croak' is called from dissociate_if_controlling_tty.
5121
5122 * minibuf.c: Make symbols static if they're not exported.
5123 (minibuf_save_list, choose_minibuf_frame): Now static.
5124 * lisp.h (choose_minibuf_frame): Remove decl.
5125
5126 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5127
5128 * lread.c: Make symbols static if they're not exported.
5129 (read_objects, initial_obarray, oblookup_last_bucket_number):
5130 Now static.
5131 (make_symbol): Remove; unused.
5132 * lisp.h (initial_obarray, make_symbol): Remove decls.
5133
5134 * keyboard.c: Make symbols static if they're not exported.
5135 (single_kboard, recent_keys_index, total_keys, recent_keys):
5136 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5137 (this_single_command_key_start, echoing, last_auto_save):
5138 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5139 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5140 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5141 (Vlispy_mouse_stem, double_click_count):
5142 Now static.
5143 (force_auto_save_soon): Define only if SIGDANGER.
5144 (ignore_mouse_drag_p): Now static if
5145 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5146 (print_help): Remove; unused.
5147 (stop_character, last_timer_event): Mark as externally visible.
5148 * keyboard.h (ignore_mouse_drag_p): Declare only if
5149 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5150 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5151 * lisp.h (echoing): Remove decl.
5152 (force_auto_save_soon): Declare only if SIGDANGER.
5153 * xdisp.c (redisplay_window): Simplify code, to make it more
5154 obvious that ignore_mouse_drag_p is not accessed if !defined
5155 USE_GTK && !defined HAVE_NS.
5156
5157 * intervals.c: Make symbols static if they're not exported.
5158 (merge_properties_sticky, merge_interval_right, delete_interval):
5159 Now static.
5160 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5161
5162 * insdel.c: Make symbols static if they're not exported.
5163 However, leave prepare_to_modify_buffer alone. It's never
5164 called from outside this function, but that appears to be a bug.
5165 (combine_after_change_list, combine_after_change_buffer):
5166 (adjust_after_replace, signal_before_change): Now static.
5167 (adjust_after_replace_noundo): Remove; unused.
5168 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5169 (signal_before_change): Remove decls.
5170
5171 * indent.c (val_compute_motion, val_vmotion): Now static.
5172
5173 * image.c: Make symbols static if they're not exported.
5174 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5175 if USE_GTK.
5176 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5177 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5178
5179 * fringe.c (standard_bitmaps): Now static.
5180 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5181
5182 * frame.c: Make symbols static if they're not exported.
5183 (x_report_frame_params, make_terminal_frame): Now static.
5184 (get_frame_param): Now static, unless HAVE_NS.
5185 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5186 (x_get_resource_string): Remove; not used.
5187 * frame.h (make_terminal_frame, x_report_frame_params):
5188 (x_get_resource_string); Remove decls.
5189 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5190 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5191
5192 * font.c, fontset.c: Make symbols static if they're not exported.
5193 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5194 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5195 * font.c (font_close_object): Now static.
5196 * font.h (font_close_object): Remove.
5197 * fontset.c (FONTSET_OBJLIST): Remove.
5198 (free_realized_fontset) #if-0 the body, which does nothing.
5199 (face_suitable_for_char_p): #if-0, as it's never called.
5200 * fontset.h (face_suitable_for_char_p): Remove decl.
5201 * xfaces.c (face_at_string_position):
5202 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5203 since 0 is always ASCII.
5204
5205 * fns.c (weak_hash_tables): Now static.
5206
5207 * fileio.c: Make symbols static if they're not exported.
5208 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5209 (Vwrite_region_annotation_buffers): Now static.
5210
5211 * eval.c: Make symbols static if they're not exported.
5212 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5213 * lisp.h (backtrace_list): Remove decl.
5214
5215 * emacs.c: Make symbols static if they're not exported.
5216 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5217 (fatal_error_code, fatal_error_signal_hook, standard_args):
5218 Now static.
5219 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5220 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5221 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5222 * lisp.h (fatal_error_signal_hook): Remove decl.
5223 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5224
5225 * editfns.c: Move a (normally-unused) function to its only use.
5226 * editfns.c, lisp.h (get_operating_system_release): Remove.
5227 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5228 worth the hassle of breaking this out.
5229
5230 * xterm.c: Make symbols static if they're not exported.
5231 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5232 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5233 (x_destroy_window, x_delete_display):
5234 Now static.
5235 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5236 (x_mouse_leave): Remove; unused.
5237 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5238 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5239 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5240 Remove decls.
5241 (x_mouse_leave): Declare only if WINDOWSNT.
5242 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5243 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5244 USE_X_TOOLKIT.
5245
5246 * ftxfont.c: Make symbols static if they're not exported.
5247 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5248 HAVE_FREETYPE.
5249 * font.h (ftxfont_driver): Likewise.
5250
5251 * xfns.c: Make symbols static if they're not exported.
5252 (x_last_font_name, x_display_info_for_name):
5253 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5254 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5255 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5256 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5257 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5258 (last_show_tip_args): Now static.
5259 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5260 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5261 (x_screen_planes): Remove; unused.
5262 * dispextern.h (x_screen_planes): Remove decl.
5263
5264 * dispnew.c: Make symbols static if they're not exported.
5265 * dispextern.h (redraw_garbaged_frames, scrolling):
5266 (increment_row_positions): Remove.
5267 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5268 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5269 Now static.
5270 (redraw_garbaged_frames): Remove; unused.
5271
5272 * xfaces.c: Make symbols static if they're not exported.
5273 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5274 Remove decls.
5275 * xterm.h (defined_color): Remove decls.
5276 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5277 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5278 (menu_face_changed_default, defined_color, free_realized_face):
5279 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5280 (ascii_face_of_lisp_face): Remove; unused.
5281
5282 * xdisp.c: Make symbols static if they're not exported.
5283 * dispextern.h (scratch_glyph_row, window_box_edges):
5284 (glyph_to_pixel_coords, set_cursor_from_row):
5285 (get_next_display_element, set_iterator_to_next):
5286 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5287 (show_mouse_face): Remove decls
5288 * frame.h (message_buf_print): Likewise.
5289 * lisp.h (pop_message, set_message, check_point_in_composition):
5290 Likewise.
5291 * xterm.h (set_vertical_scroll_bar): Likewise.
5292 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5293 (message_buf_print, scratch_glyph_row, displayed_buffer):
5294 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5295 (get_next_display_element, show_mouse_face, window_box_edges):
5296 (frame_to_window_pixel_xy, check_point_in_composition):
5297 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5298 (glyph_to_pixel_coords): Remove; unused.
5299
5300 * dired.c (file_name_completion): Now static.
5301
5302 * dbusbind.c (xd_in_read_queued_messages): Now static.
5303
5304 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5305 * data.c (circular_list_error): Remove.
5306
5307 * commands.h (last_point_position, last_point_position_buffer):
5308 (last_point_position_window): Remove decls.
5309 * keyboard.c: Make these variables static.
5310
5311 * coding.h (coding, code_convert_region, encode_coding_gap):
5312 Remove decls.
5313 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5314 (iso_code_class, detect_coding, code_convert_region): Now static.
5315 (encode_coding_gap): Remove; unused.
5316
5317 * chartab.c (chartab_chars, chartab_bits): Now static.
5318
5319 * charset.h (charset_iso_8859_1): Remove decl.
5320 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5321 Now static.
5322
5323 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5324 * ccl.c (Vccl_program_table): Now static.
5325 (check_ccl_update): Remove; unused.
5326
5327 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5328 * category.h: ... from here.
5329 * category.c (check_category_table, set_category_set): Now static.
5330
5331 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5332 * lisp.h: Remove these decls.
5333
5334 * buffer.c (buffer_count): Remove unused var.
5335
5336 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5337 so that it's not optimized away.
5338 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5339 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5340 exported only to the debugger.
5341
5342 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5343 * atimer.h (run_all_atimers): Remove; not exported.
5344
5345 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5346 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5347 was inaccessible from Lisp.
5348 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5349 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5350
5351 alloc.c: Import and export fewer symbols, and remove unused items.
5352 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5353 is defined.
5354 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5355 it's not optimized away by whole-program optimization.
5356 (message_enable_multibyte, free_misc): Remove.
5357 (catchlist, handlerlist, mark_backtrace):
5358 Declare only if BYTE_MARK_STACK.
5359 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5360 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5361 (message_enable_multibyte): Remove decl.
5362 (free_misc, interval_free_list, float_block, float_block_index):
5363 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5364 (cons_free_list, last_marked_index):
5365 Now static.
5366 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5367 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5368 (mark_backtrace): Define only if BYTE_MARK_STACK.
5369 * xdisp.c (message_enable_multibyte): Now static.
5370
5371 Declare Lisp_Object Q* variables to be 'static' if not exported.
5372 This makes it easier for human readers (and static analyzers)
5373 to see whether these variables are used from other modules.
5374 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5375 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5376 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5377 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5378 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5379 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5380 * xmenu.c, xselect.c:
5381 Declare Q* vars static if they are not used in other modules.
5382 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5383 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5384 Remove decls of unexported vars.
5385 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5386
5387 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5388
5389 Make Emacs functions such as Fatom 'static' by default.
5390 This makes it easier for human readers (and static analyzers)
5391 to see whether these functions can be called from other modules.
5392 DEFUN now defines a static function. To make the function external
5393 so that it can be used in other C modules, use the new macro DEFUE.
5394 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5395 (Finit_image_library):
5396 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5397 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5398 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5399 Remove decls, since these functions are now static.
5400 (Funintern, Fget_internal_run_time): New decls, since these functions
5401 were already external.
5402
5403 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5404 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5405 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5406 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5407 * keyboard.c, keymap.c, lread.c:
5408 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5409 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5410 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5411 Mark functions with DEFUE instead of DEFUN,
5412 if they are used in other modules.
5413 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5414 decls for now-static functions.
5415 * buffer.h (Fdelete_overlay): Remove decl.
5416 * callproc.c (Fgetenv_internal): Mark as internal.
5417 * composite.c (Fremove_list_of_text_properties): Remove decl.
5418 (Fcomposition_get_gstring): New forward static decl.
5419 * composite.h (Fcomposite_get_gstring): Remove decl.
5420 * dired.c (Ffile_attributes): New forward static decl.
5421 * doc.c (Fdocumntation_property): New forward static decl.
5422 * eval.c (Ffetch_bytecode): New forward static decl.
5423 (Funintern): Remove extern decl; now in .h file where it belongs.
5424 * fileio.c (Fmake_symbolic_link): New forward static decl.
5425 * image.c (Finit_image_library): New forward static decl.
5426 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5427 * intervals.h (Fprevious_property_change):
5428 (Fremove_list_of_text_properties): Remove decls.
5429 * keyboard.c (Fthis_command_keys): Remove decl.
5430 (Fcommand_execute): New forward static decl.
5431 * keymap.c (Flookup_key): New forward static decl.
5432 (Fcopy_keymap): Now static.
5433 * keymap.h (Flookup_key): Remove decl.
5434 * process.c (Fget_process): New forward static decl.
5435 (Fprocess_datagram_address): Mark as internal.
5436 * syntax.c (Fsyntax_table_p): New forward static decl.
5437 (skip_chars): Remove duplicate decl.
5438 * textprop.c (Fprevious_property_change): New forward static decl.
5439 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5440 Now internal.
5441 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5442 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5443
5444 * editfns.c (Fformat): Remove unreachable code.
5445
5446 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5447
5448 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5449 change. (Bug#8496)
5450
5451 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5452
5453 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5454 when at ZV. (Bug#8487)
5455
5456 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5457
5458 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5459 (Bug#8437)
5460 * keyboard.c (parse_tool_bar_item): Likewise.
5461 * sound.c (sound_cleanup, alsa_close): Likewise.
5462 * termcap.c (tgetent): Likewise.
5463 * xfns.c (x_default_font_parameter): Likewise.
5464 * xsettings.c (read_and_apply_settings): Likewise.
5465
5466 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5467 (overrun_check_free): Protoize.
5468
5469 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5470
5471 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5472 since callers should never pass a negative size.
5473 Change the signature to match that of plain 'read' and 'write'; see
5474 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5475 * lisp.h: Update prototypes of emacs_write and emacs_read.
5476
5477 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5478
5479 * xdisp.c (redisplay_window): Don't try to determine the character
5480 position of the scroll margin if the window start point w->startp
5481 is outside the buffer's accessible region. (Bug#8468)
5482
5483 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5484
5485 Fix write-region and its subroutines for buffers > 2GB.
5486 * fileio.c (a_write, e_write): Modify declaration of arguments and
5487 local variables to support buffers larger than 2GB.
5488 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5489
5490 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5491 argument, local variables, and return value.
5492
5493 * lisp.h: Update prototypes of emacs_write and emacs_read.
5494
5495 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5496
5497 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5498
5499 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5500
5501 Fix more problems found by GCC 4.6.0's static checks.
5502
5503 * xdisp.c (vmessage): Use a better test for character truncation.
5504
5505 * charset.c (load_charset_map): <, not <=, for optimization,
5506 and to avoid potential problems with integer overflow.
5507 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5508 * casetab.c (set_identity, shuffle): Likewise.
5509 * editfns.c (Fformat): Likewise.
5510 * syntax.c (skip_chars): Likewise.
5511
5512 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5513 This also lets GCC 4.6.0 generate slightly better loop code.
5514
5515 * callint.c (Fcall_interactively): <, not <=, for optimization.
5516 (Fcall_interactively): Count the number of arguments produced,
5517 not the number of arguments given. This is simpler and lets GCC
5518 4.6.0 generate slightly better code.
5519
5520 * ftfont.c: Distingish more carefully between FcChar8 and char.
5521 The previous code passed unsigned char * to a functions like
5522 strlen and xstrcasecmp that expect char *, which does not
5523 conform to the C standard.
5524 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5525 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5526 char * when the C standard requires it.
5527
5528 * keyboard.c (read_char): Remove unused var.
5529
5530 * eval.c: Port to Windows vsnprintf (Bug#8435).
5531 Include <limits.h>.
5532 (SIZE_MAX): Define if the headers do not.
5533 (verror): Do not give up if vsnprintf returns a negative count.
5534 Instead, grow the buffer. This ports to Windows vsnprintf, which
5535 does not conform to C99. Problem reported by Eli Zaretskii.
5536 Also, simplify the allocation scheme, by avoiding the need for
5537 calling realloc, and removing the ALLOCATED variable.
5538
5539 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5540
5541 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5542 But keep the doprint source code for now, as we might revamp it
5543 and use it again (Bug#8435).
5544 * lisp.h (doprnt): Remove.
5545 * Makefile.in (base_obj): Remove doprnt.o.
5546 * deps.mk (doprnt.o): Remove.
5547
5548 error: Print 32- and 64-bit integers portably (Bug#8435).
5549 Without this change, on typical 64-bit hosts error ("...%d...", N)
5550 was used to print both 32- and 64-bit integers N, which relied on
5551 undefined behavior.
5552 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5553 New macro.
5554 * lisp.h (error, verror): Mark as printf-like functions.
5555 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5556 Report overflow in size calculations when allocating printf buffer.
5557 Do not truncate output string at its first null byte.
5558 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5559 Truncate the output at a character boundary, since vsnprintf does not
5560 do that.
5561 * charset.c (check_iso_charset_parameter): Convert internal
5562 character to string before calling 'error', since %c now has the
5563 printf meaning.
5564 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5565 overflow when computing char to be passed to 'error'. Do not
5566 pass Lisp_Object to 'error'; pass the integer instead.
5567 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5568 formatted with plain %d.
5569
5570 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5571
5572 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5573
5574 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5575
5576 * xterm.c (x_catch_errors): Remove duplicate declaration.
5577
5578 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5579
5580 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5581
5582 2011-04-10 Jim Meyering <meyering@redhat.com>
5583
5584 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5585 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5586 return ssize_t not "int", and use size_t as the buffer length.
5587 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5588 * gnutls.h: Update declarations.
5589 * process.c (read_process_output): Use ssize_t, to match.
5590 (send_process): Likewise.
5591
5592 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5593
5594 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5595
5596 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5597
5598 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5599 Use unsigned char, to match FcChar8 type definition.
5600
5601 * xterm.c (handle_one_xevent):
5602 * xmenu.c (create_and_show_popup_menu):
5603 * xselect.c (x_decline_selection_request)
5604 (x_reply_selection_request): Avoid type-punned deref of X events.
5605
5606 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5607
5608 Fix some uses of `int' instead of EMACS_INT.
5609 * search.c (string_match_1, fast_string_match)
5610 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5611 (scan_buffer, find_next_newline_no_quit)
5612 (find_before_next_newline, search_command, Freplace_match)
5613 (Fmatch_data): Make some `int' variables be EMACS_INT.
5614
5615 * xdisp.c (display_count_lines): 3rd argument and return value now
5616 EMACS_INT. All callers changed.
5617 (pint2hrstr): Last argument is now EMACS_INT.
5618
5619 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5620 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5621 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5622 (decode_coding_utf_16, decode_coding_emacs_mule)
5623 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5624 (decode_coding_ccl, decode_coding_charset)
5625 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5626 (decode_coding_iso_2022, decode_coding_emacs_mule)
5627 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5628 <char_offset, last_offset>: Declare EMACS_INT.
5629 (encode_coding_utf_8, encode_coding_utf_16)
5630 (encode_coding_emacs_mule, encode_invocation_designation)
5631 (encode_designation_at_bol, encode_coding_iso_2022)
5632 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5633 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5634 Declare EMACS_INT.
5635 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5636 (encode_invocation_designation): Last argument P_NCHARS is now
5637 EMACS_INT.
5638 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5639 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5640
5641 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5642 All users changed.
5643
5644 * ccl.c (Fccl_execute_on_string): Declare some variables
5645 EMACS_INT.
5646
5647 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5648
5649 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5650
5651 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5652
5653 * process.c (Fformat_network_address): Doc fix.
5654
5655 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5656
5657 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5658
5659 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5660
5661 * keyboard.c (read_char): Call Lisp function help-form-show,
5662 instead of using internal_with_output_to_temp_buffer.
5663 (Qhelp_form_show): New var.
5664 (syms_of_keyboard): Use DEFSYM macro.
5665
5666 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5667
5668 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5669
5670 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5671
5672 * process.c (Flist_processes): Remove to Lisp.
5673 (list_processes_1): Delete.
5674
5675 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5676
5677 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5678
5679 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5680
5681 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5682
5683 Fix more problems found by GCC 4.6.0's static checks.
5684
5685 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5686
5687 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5688
5689 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5690
5691 * xdisp.c (vmessage): Mark as a printf-like function.
5692
5693 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5694
5695 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5696
5697 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5698 printf-like functions.
5699 (tiff_load): Add casts to remove these marks before passing them
5700 to system-supplied API.
5701
5702 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5703
5704 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5705 This avoids several warnings with gcc -Wstrict-overflow.
5706 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5707 directly, rather than having caller test rule sign. This avoids
5708 some unnecessary tests.
5709 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5710 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5711 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5712
5713 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5714 (xfont_open): Avoid unnecessary tests.
5715
5716 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5717
5718 * composite.h, composite.c (composition_gstring_put_cache):
5719 Use EMACS_INT, not int, for length.
5720
5721 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5722 breaking out part of COMPOSITION_DECODE_RULE.
5723 (COMPOSITION_DECODE_RULE): Use it.
5724 * composite.c (get_composition_id): Remove unused local vars,
5725 by using the new macro.
5726
5727 * textprop.c (set_text_properties_1): Change while to do-while,
5728 since the condition is always true at first.
5729
5730 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5731 (interval_deletion_adjustment): Return unsigned value.
5732 All uses changed.
5733
5734 * process.c (list_processes_1, create_pty, read_process_output):
5735 (exec_sentinel): Remove vars that were set but not used.
5736 (create_pty): Remove unnecessary "volatile"s.
5737 (Fnetwork_interface_info): Avoid possibility of int overflow.
5738 (read_process_output): Do adaptive read buffering even if carryover.
5739 (read_process_output): Simplify nbytes computation if buffered.
5740
5741 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5742
5743 * syntax.c (scan_words): Remove var that was set but not used.
5744 (update_syntax_table): Use unsigned instead of int.
5745
5746 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5747 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5748 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5749
5750 * print.c (print_error_message): Avoid int overflow.
5751
5752 * font.c (font_list_entities): Redo for clarity,
5753 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5754
5755 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5756 (font_score): Avoid potential overflow in diff calculation.
5757
5758 * fns.c (substring_both): Remove var that is set but not used.
5759 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5760
5761 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5762
5763 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5764 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5765 can always succeed if overflow has undefined behavior.
5766
5767 * search.c (boyer_moore, wordify): Remove vars set but not used.
5768 (wordify): Omit three unnecessary tests.
5769
5770 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5771 All callers changed. This avoids the need for an unused var.
5772
5773 * casefiddle.c (casify_region): Remove var that is set but not used.
5774
5775 * dired.c (file_name_completion): Remove var that is set but not used.
5776
5777 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5778
5779 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5780 (Finsert_file_contents): Remove unnecessary code checking fd.
5781
5782 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5783 Check for integer overflow on size calculations.
5784
5785 * buffer.c (Fprevious_overlay_change): Remove var that is set
5786 but not used.
5787
5788 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5789 Remove vars that are set but not used.
5790 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5791 (timer_check_2): Mark vars as initialized.
5792
5793 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5794
5795 * image.c (lookup_image): Remove var that is set but not used.
5796 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5797
5798 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5799 that are set but not used.
5800
5801 * xfns.c (make_invisible_cursor): Don't return garbage
5802 if XCreateBitmapFromData fails (Bug#8410).
5803
5804 * xselect.c (x_get_local_selection, x_handle_property_notify):
5805 Remove vars that are set but not used.
5806
5807 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5808 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5809
5810 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5811 Remove var that is set but not used.
5812 (scroll_bar_windows_size): Now size_t, not int.
5813 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5814 Check for overflow.
5815
5816 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5817 (map_tty_color) [!defined MSDOS]: Likewise.
5818
5819 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5820
5821 * coding.c: Remove vars that are set but not used.
5822 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5823 All callers changed.
5824 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5825 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5826 (decode_coding_charset): Remove vars that are set but not used.
5827
5828 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5829 that is set but not used.
5830
5831 * print.c (print_object): Remove var that is set but not used.
5832
5833 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5834 The gnulib version avoids calling malloc in the usual case,
5835 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5836 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5837 * filelock.c (current_lock_owner): Likewise.
5838 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5839 * sysdep.c: Include allocator.h, careadlinkat.h.
5840 (emacs_no_realloc_allocator): New static constant.
5841 (emacs_readlink): New function.
5842 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5843 ../lib/careadlinkat.h.
5844
5845 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5846
5847 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5848 first non-nil return value).
5849
5850 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5851
5852 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5853 if not defined (Bug#8403).
5854
5855 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5856
5857 * xdisp.c (display_count_lines): Remove parameter `start',
5858 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5859 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5860 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5861 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5862 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5863 and thereabouts. All callers changed.
5864 (get_per_char_metric): Remove parameter `f', unused since
5865 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5866
5867 2011-04-02 Jim Meyering <meyering@redhat.com>
5868
5869 do not dereference NULL upon failed strdup
5870 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5871 (ns_get_family): Likewise.
5872
5873 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5874
5875 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5876
5877 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5878
5879 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5880 later (Bug#8403).
5881
5882 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5883
5884 Add lexical binding.
5885
5886 * window.c (Ftemp_output_buffer_show): New fun.
5887 (Fsave_window_excursion):
5888 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5889
5890 * lread.c (lisp_file_lexically_bound_p): New function.
5891 (Fload): Bind Qlexical_binding.
5892 (readevalloop): Remove `evalfun' arg.
5893 Bind Qinternal_interpreter_environment.
5894 (Feval_buffer): Bind Qlexical_binding.
5895 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5896 Mark as dynamic.
5897 (syms_of_lread): Declare `lexical-binding'.
5898
5899 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5900
5901 * keyboard.c (eval_dyn): New fun.
5902 (menu_item_eval_property): Use it.
5903
5904 * image.c (parse_image_spec): Use Ffunctionp.
5905
5906 * fns.c (concat, mapcar1): Accept byte-code-functions.
5907
5908 * eval.c (Fsetq): Handle lexical vars.
5909 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5910 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5911 (FletX, Flet): Obey lexical binding.
5912 (Fcommandp): Handle closures.
5913 (Feval): New `lexical' arg.
5914 (eval_sub): New function extracted from Feval. Use it almost
5915 everywhere where Feval was used. Look up vars in lexical env.
5916 Handle closures.
5917 (Ffunctionp): Move from subr.el.
5918 (Ffuncall): Handle closures.
5919 (apply_lambda): Remove `eval_flags'.
5920 (funcall_lambda): Handle closures and new byte-code-functions.
5921 (Fspecial_variable_p): New function.
5922 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5923 but without exporting it to Lisp.
5924
5925 * doc.c (Fdocumentation, store_function_docstring):
5926 * data.c (Finteractive_form): Handle closures.
5927
5928 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5929 interactive spec.
5930
5931 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5932 New byte-codes.
5933 (exec_byte_code): New function extracted from Fbyte_code to handle new
5934 calling convention for byte-code-functions. Add new byte-codes.
5935
5936 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5937
5938 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5939
5940 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5941
5942 * xdisp.c (redisplay_internal): Fix prototype.
5943
5944 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5945
5946 * xdisp.c (SCROLL_LIMIT): New macro.
5947 (try_scrolling): Use it when setting scroll_limit.
5948 Limit scrolling to 100 screen lines.
5949 (redisplay_window): Even when falling back on "recentering",
5950 position point in the window according to scroll-conservatively,
5951 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5952
5953 (try_scrolling): When point is above the window, allow searching
5954 as far as scroll_max, or one screenful, to compute vertical
5955 distance from PT to the scroll margin position. This prevents
5956 try_scrolling from unnecessarily failing when
5957 scroll-conservatively is set to a value slightly larger than the
5958 window height. Clean up the case of PT below the margin at bottom
5959 of window: scroll_max can no longer be INT_MAX. When aggressive
5960 scrolling is in use, don't let point enter the opposite scroll
5961 margin as result of the scroll.
5962 (syms_of_xdisp) <scroll-conservatively>: Document the
5963 threshold of 100 lines for never-recentering scrolling.
5964
5965 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5966
5967 * dispextern.h (move_it_by_lines):
5968 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5969 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5970 (message_log_check_duplicate): Remove parameters `prev_bol' and
5971 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5972 (redisplay_internal): Remove parameter `preserve_echo_area',
5973 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5974
5975 * indent.c (Fvertical_motion):
5976 * window.c (window_scroll_pixel_based, Frecenter):
5977 Don't pass `need_y_p' to `move_it_by_lines'.
5978
5979 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5980
5981 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5982 steal a few bits to be more compact.
5983 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5984 Remove unneeded casts.
5985
5986 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5987
5988 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5989
5990 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5991 binding" message (bug#7967).
5992
5993 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5994
5995 Fix more problems found by GCC 4.6.0's static checks.
5996
5997 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5998 Remove unused local var.
5999
6000 * editfns.c (Fmessage_box): Remove unused local var.
6001
6002 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6003 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6004 Omit unused local vars.
6005 * window.c (shrink_windows): Omit unused local var.
6006 * menu.c (digest_single_submenu): Omit unused local var.
6007 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6008 Omit unused local var.
6009
6010 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6011 Don't assume string length fits in int.
6012 (keyremap_step, read_key_sequence): Use size_t for sizes.
6013 (read_key_sequence): Don't check last_real_key_start redundantly.
6014
6015 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6016 instead of alloca (Bug#8344).
6017
6018 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6019 (Fbacktrace_frame): Don't assume nframes fits in int.
6020
6021 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6022
6023 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6024 concerns.
6025
6026 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6027
6028 * cm.c (calccost): Turn while-do into do-while, for clarity.
6029
6030 * keyboard.c (syms_of_keyboard): Use the same style as later
6031 in this function when indexing through an array. This also
6032 works around GCC bug 48267.
6033
6034 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6035
6036 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6037
6038 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6039 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6040
6041 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6042 This avoids undefined behavior on integer overflow, and is a bit
6043 more convenient anyway since it is compared to a size_t variable.
6044
6045 Variadic C functions now count arguments with size_t, not int.
6046 This avoids an unnecessary limitation on 64-bit machines, which
6047 caused (substring ...) to crash on large vectors (Bug#8344).
6048 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6049 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6050 All variadic functions and their callers changed accordingly.
6051 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6052 * data.c (arith_driver, float_arith_driver): Likewise.
6053 * editfns.c (general_insert_function): Likewise.
6054 * eval.c (struct backtrace.nargs, interactive_p)
6055 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6056 (funcall_lambda, mark_backtrace): Likewise.
6057 * fns.c (concat): Likewise.
6058 * frame.c (x_set_frame_parameters): Likewise.
6059 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6060 0 if not found, not -1. All callers changed.
6061
6062 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6063 (stack_copy_size): Now size_t, not int.
6064 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6065
6066 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6067
6068 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6069 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6070 All callers changed.
6071
6072 * lisp.h (multibyte_char_to_unibyte):
6073 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6074 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6075 * character.h (CHAR_TO_BYTE8):
6076 * cmds.c (internal_self_insert):
6077 * editfns.c (general_insert_function):
6078 * keymap.c (push_key_description):
6079 * search.c (Freplace_match):
6080 * xdisp.c (message_dolog, set_message_1): All callers changed.
6081
6082 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6083
6084 * keyboard.c (safe_run_hook_funcall): New function.
6085 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6086 don't set the hook to nil, but remove the offending function instead.
6087 (Qcommand_hook_internal): Remove, unused.
6088 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6089 Vcommand_hook_internal.
6090
6091 * eval.c (enum run_hooks_condition): Remove.
6092 (funcall_nil, funcall_not): New functions.
6093 (run_hook_with_args): Call each function through a `funcall' argument.
6094 Remove `cond' argument, now redundant.
6095 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6096 (Frun_hook_with_args_until_failure): Adjust accordingly.
6097 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6098
6099 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6100
6101 * dispextern.h (string_buffer_position): Remove declaration.
6102
6103 * print.c (strout): Remove parameter `multibyte', unused since
6104 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6105
6106 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6107 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6108 All callers changed.
6109
6110 * w32.c (_wsa_errlist): Use braces for struct initializers.
6111
6112 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6113 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6114 All callers changed.
6115 (string_buffer_position): Likewise. Also, make static (it's never
6116 used outside xdisp.c).
6117 (cursor_row_p): Remove parameter `w', unused since
6118 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6119 (decode_mode_spec): Remove parameter `precision', introduced during
6120 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6121 All callers changed.
6122
6123 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6124
6125 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6126
6127 2011-03-27 Anders Lindgren <andlind@gmail.com>
6128
6129 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6130 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6131 (ns_update_auto_hide_menu_bar): New functions.
6132 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6133 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6134 ns_constrain_all_frames.
6135 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6136 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6137
6138 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6139
6140 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6141
6142 2011-03-27 Glenn Morris <rgm@gnu.org>
6143
6144 * syssignal.h: Replace RETSIGTYPE with void.
6145 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6146 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6147 Replace SIGTYPE with void everywhere.
6148 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6149 * s/template.h (SIGTYPE): Remove commented out definition.
6150
6151 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6152
6153 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6154 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6155
6156 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6157
6158 * w32.c (read_unc_volume): Use parameter `henum', instead of
6159 global variable `wget_enum_handle'.
6160
6161 * keymap.c (describe_vector): Remove parameters `indices' and
6162 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6163 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6164
6165 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6166
6167 * keyboard.c (timer_check): Remove parameter `do_it_now',
6168 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6169 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6170 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6171
6172 * keyboard.c (read_char):
6173 * w32menu.c (w32_menu_display_help):
6174 * xmenu.c (show_help_event, menu_help_callback):
6175 Adjust calls to `show_help_echo'.
6176
6177 * gtkutil.c (xg_maybe_add_timer):
6178 * keyboard.c (readable_events):
6179 * process.c (wait_reading_process_output):
6180 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6181
6182 * insdel.c (adjust_markers_gap_motion):
6183 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6184 (gap_left, gap_right): Don't call it.
6185
6186 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6187
6188 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6189 incurred during fontification.
6190
6191 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6192
6193 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6194 (DEFVAR_PER_BUFFER): Don't pass it.
6195
6196 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6197 (scrolling_window): Don't pass it.
6198
6199 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6200
6201 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6202
6203 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6204 and `suffix'.
6205 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6206 of variables specific to SELinux and computation of `encoded_absname'.
6207
6208 * image.c (XPutPixel): Remove unused variable `height'.
6209
6210 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6211
6212 * unexw32.c (get_section_info): Remove unused variable `section'.
6213
6214 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6215 (system_process_attributes): Remove unused variable `sess'.
6216 (sys_read): Remove unused variable `err'.
6217
6218 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6219 (w32_wnd_proc): Remove unused variable `isdead'.
6220 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6221 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6222 (x_create_tip_frame): Remove unused variable `tem'.
6223
6224 * w32inevt.c (w32_console_read_socket):
6225 Remove unused variable `no_events'.
6226
6227 * w32term.c (x_draw_composite_glyph_string_foreground):
6228 Remove unused variable `width'.
6229
6230 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6231
6232 * w32term.c (x_set_glyph_string_clipping):
6233 Don't pass uninitialized region to CombineRgn.
6234
6235 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6236
6237 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6238 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6239 (Fx_close_connection): Remove unused variable `i'.
6240
6241 * w32font.c (w32font_draw): Return number of glyphs.
6242 (w32font_open_internal): Remove unused variable `i'.
6243 (w32font_driver): Add missing initializer.
6244
6245 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6246 (fill_in_menu): Remove unused variable `items_added'.
6247
6248 * w32term.c (last_mouse_press_frame): Remove static global variable.
6249 (w32_clip_to_row): Remove unused variable `f'.
6250 (x_delete_terminal): Remove unused variable `i'.
6251
6252 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6253 (NOTHING): Remove unused static global variable.
6254 (uniscribe_check_otf): Remove unused variable `table'.
6255 (uniscribe_font_driver): Add missing initializers.
6256
6257 2011-03-23 Julien Danjou <julien@danjou.info>
6258
6259 * term.c (Fsuspend_tty, Fresume_tty):
6260 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6261 * window.c (temp_output_buffer_show):
6262 * insdel.c (signal_before_change):
6263 * frame.c (Fhandle_switch_frame):
6264 * fileio.c (Fdo_auto_save):
6265 * emacs.c (Fkill_emacs):
6266 * editfns.c (save_excursion_restore):
6267 * cmds.c (internal_self_insert):
6268 * callint.c (Fcall_interactively):
6269 * buffer.c (Fkill_all_local_variables):
6270 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6271 Use Frun_hooks.
6272 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6273 unconditionnaly since it does the check itself.
6274
6275 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6276
6277 Fix more problems found by GCC 4.5.2's static checks.
6278
6279 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6280 the first time through the loop, since we know p0 < p1 then.
6281 This also avoids a gcc -Wstrict-overflow warning.
6282
6283 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6284 leading to a memory leak, possible in functions like
6285 load_charset_map_from_file that can allocate an unbounded number
6286 of objects (Bug#8318).
6287
6288 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6289 that could (at least in theory) be that large.
6290
6291 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6292 This is less likely to overflow, and avoids undefined behavior if
6293 overflow does occur. All callers changed. Use strtoul to scan
6294 for the unsigned long integer.
6295 (pint2hrstr): Simplify and tune code slightly.
6296 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6297
6298 * scroll.c (do_scrolling): Work around GCC bug 48228.
6299 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6300
6301 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6302 This also avoids a warning with gcc -Wstrict-overflow.
6303 (validate_x_resource_name): Simplify count usage.
6304 This also avoids a warning with gcc -Wstrict-overflow.
6305
6306 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6307 fail (Bug#8306).
6308
6309 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6310
6311 * process.c (Fmake_network_process): Use socklen_t, not int,
6312 where POSIX says socklen_t is required in portable programs.
6313 This fixes a porting bug on hosts like 64-bit HP-UX, where
6314 socklen_t is wider than int (Bug#8277).
6315 (Fmake_network_process, server_accept_connection):
6316 (wait_reading_process_output, read_process_output):
6317 Likewise.
6318
6319 * process.c: Rename or move locals to avoid shadowing.
6320 (list_processes_1, Fmake_network_process):
6321 (read_process_output_error_handler, exec_sentinel_error_handler):
6322 Rename or move locals.
6323 (Fmake_network_process): Define label "retry_connect" only if needed.
6324 (Fnetwork_interface_info): Fix pointer signedness.
6325 (process_send_signal): Add cast to avoid pointer signedness problem.
6326 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6327 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6328
6329 Make tparam.h and terminfo.c consistent.
6330 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6331 Include tparam.h instead, since it declares them.
6332 * cm.h (PC): Remove extern decl; tparam.h now does this.
6333 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6334 * terminfo.c: Include tparam.h, to check interfaces.
6335 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6336 (tparam): Adjust signature to match interface in tparam.h;
6337 this removes some undefined behavior. Check that outstring and len
6338 are zero, which they always are with Emacs.
6339 * tparam.h (PC, BC, UP): New extern decls.
6340
6341 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6342 (xftfont_open): Rename locals to avoid shadowing.
6343
6344 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6345 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6346 (OTF_TAG_SYM): Omit macro if not needed.
6347 (ftfont_list): Remove unused local.
6348 (get_adstyle_property, ftfont_pattern_entity):
6349 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6350 Rename locals to avoid shadowing.
6351
6352 * xfont.c (xfont_list_family): Mark var as initialized.
6353
6354 * xml.c (make_dom): Now static.
6355
6356 * composite.c (composition_compute_stop_pos): Rename local to
6357 avoid shadowing.
6358 (composition_reseat_it): Remove unused locals.
6359 (find_automatic_composition, composition_adjust_point): Likewise.
6360 (composition_update_it): Mark var as initialized.
6361 (find_automatic_composition): Mark vars as initialized,
6362 with a FIXME (Bug#8290).
6363
6364 character.h: Rename locals to avoid shadowing.
6365 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6366 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6367 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6368 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6369 to avoid shadowing.
6370
6371 * textprop.c (property_change_between_p): Remove; unused.
6372
6373 * intervals.c (interval_start_pos): Now static.
6374
6375 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6376
6377 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6378 Rename locals to avoid shadowing.
6379
6380 * sound.c (wav_play, au_play, Fplay_sound_internal):
6381 Fix pointer signedness.
6382 (alsa_choose_format): Remove unused local var.
6383 (wav_play): Initialize a variable to 0, to prevent undefined
6384 behavior (Bug#8278).
6385
6386 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6387
6388 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6389
6390 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6391 clobbering (Bug#8298).
6392 * sysdep.c (sys_subshell): Likewise.
6393 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6394
6395 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6396 This should get cleaned up, so that child_setup has the
6397 same signature on all platforms.
6398
6399 * callproc.c (call_process_cleanup): Now static.
6400 (relocate_fd): Rename locals to avoid shadowing.
6401
6402 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6403
6404 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6405 not to be necessary, and produces flickering.
6406
6407 2011-03-20 Glenn Morris <rgm@gnu.org>
6408
6409 * config.in: Remove file.
6410
6411 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6412
6413 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6414 are now in src/globals.h.
6415 (syms_of_minibuf): Remove spurious & from previous change.
6416
6417 2011-03-20 Leo <sdl.web@gmail.com>
6418
6419 * minibuf.c (completing-read-function): New variable.
6420 (completing-read-default): Rename from completing-read.
6421 (completing-read): Call completing-read-function.
6422
6423 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6424
6425 * xfaces.c (Fx_load_color_file):
6426 Read color file from absolute filename (bug#8250).
6427
6428 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6429
6430 * makefile.w32-in: Update dependencies.
6431
6432 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6433
6434 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6435
6436 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6437
6438 Fix more problems found by GCC 4.5.2's static checks.
6439
6440 * process.c (make_serial_process_unwind, send_process_trap):
6441 (sigchld_handler): Now static.
6442
6443 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6444 That way, the code declares only the vars that it needs.
6445 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6446 * s/cygwin.h (PTY_ITERATION): Likewise.
6447 * s/darwin.h (PTY_ITERATION): Likewise.
6448 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6449
6450 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6451 * process.c (allocate_pty): Don't declare stb unless it's needed.
6452
6453 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6454 (CONSTANTLIM): Remove; unused.
6455 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6456 Define only if needed.
6457
6458 * unexelf.c (unexec): Name an expression,
6459 to avoid gcc -Wbad-function-cast warning.
6460 Use a different way to cause a compilation error if anyone uses
6461 n rather than nn, a way that does not involve shadowing.
6462 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6463
6464 * deps.mk (unexalpha.o): Remove; unused.
6465
6466 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6467 * unexec.h: New file.
6468 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6469 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6470 Depend on unexec.h.
6471 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6472 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6473 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6474 Change as necessary to match prototype in unexec.h.
6475
6476 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6477 shadowing.
6478 (back_comment, skip_chars): Mark vars as initialized.
6479
6480 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6481 Rename locals to avoid shadowing.
6482
6483 * lread.c (read1): Rewrite so as not to use empty "else".
6484 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6485
6486 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6487
6488 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6489 warning when compiling print.c.
6490
6491 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6492 instead of using an uninitialized var.
6493 (font_sort_entities): Mark var as initialized.
6494
6495 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6496
6497 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6498 pointers to constants.
6499 (font_parse_fcname): Remove unused vars.
6500 (font_delete_unmatched): Now static.
6501 (font_get_spec): Remove; unused.
6502 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6503 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6504 Rename or move locals to avoid shadowing.
6505
6506 * fns.c (require_nesting_list, require_unwind): Now static.
6507 (Ffillarray): Rename locals to avoid shadowing.
6508
6509 * floatfns.c (domain_error2): Define only if needed.
6510 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6511
6512 * alloc.c (mark_backtrace): Move decl from here ...
6513 * lisp.h: ... to here, so that it can be checked.
6514
6515 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6516 (Fdefvar): Rewrite so as not to use empty "else".
6517 (lisp_indirect_variable): Name an expression,
6518 to avoid gcc -Wbad-function-cast warning.
6519 (Fdefvar): Rename locals to avoid shadowing.
6520
6521 * callint.c (quotify_arg, quotify_args): Now static.
6522 (Fcall_interactively): Rename locals to avoid shadowing.
6523 Use const pointer when appropriate.
6524
6525 * lisp.h (get_system_name, get_operating_system_release):
6526 Move decls here, to check interfaces.
6527 * process.c (get_operating_system_release): Move decl to lisp.h.
6528 * xrdb.c (get_system_name): Likewise.
6529 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6530 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6531 some of which prompt warnings from gcc -Wbad-function-cast.
6532 (Fformat_time_string, Fencode_time, Finsert_char):
6533 (Ftranslate_region_internal, Fformat):
6534 Rename or remove local vars to avoid shadowing.
6535 (Ftranslate_region_internal): Mark var as initialized.
6536
6537 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6538 avoid shadowing.
6539
6540 * lisp.h (eassert): Check that the argument compiles, even if
6541 ENABLE_CHECKING is not defined.
6542
6543 * data.c (Findirect_variable): Name an expression, to avoid
6544 gcc -Wbad-function-cast warning.
6545 (default_value, arithcompare, arith_driver, arith_error): Now static.
6546 (store_symval_forwarding): Rename local to avoid shadowing.
6547 (Fmake_variable_buffer_local, Fmake_local_variable):
6548 Mark variables as initialized.
6549 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6550
6551 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6552 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6553 Rename locals to avoid shadowing.
6554 (mark_stack): Move local variables into the #ifdef region where
6555 they're used.
6556 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6557 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6558 needed otherwise.
6559 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6560 (GC_STRING_CHARS): Remove; not used.
6561 (Fmemory_limit): Cast sbrk's returned value to char *.
6562
6563 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6564 avoids undefined behavior in theory.
6565
6566 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6567
6568 Use functions, not macros, for up- and down-casing (Bug#8254).
6569 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6570 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6571 to use the following functions instead of these macros.
6572 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6573 EMACS_INT, since callers assume the returned value fits in int.
6574 (upcase1): Likewise, for UPCASE_TABLE.
6575 (uppercasep, lowercasep, upcase): New static inline functions.
6576 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6577 the race-condition problem in the old DOWNCASE.
6578
6579 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6580 Rename locals to avoid shadowing.
6581 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6582 (regex_compile, re_search_2, re_match_2_internal):
6583 Remove unused local vars.
6584 (FREE_VAR): Rewrite so as not to use empty "else",
6585 which gcc can warn about.
6586 (regex_compile, re_match_2_internal): Mark locals as initialized.
6587 (RETALLOC_IF): Define only if needed.
6588 (WORDCHAR_P): Likewise. This one is never needed, but is used
6589 only in a comment talking about a compiler bug, so put inside
6590 the #if 0 of that comment.
6591 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6592 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6593 Remove; unused.
6594
6595 * search.c (boyer_moore): Rename locals to avoid shadowing.
6596 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6597 (PREV_CHAR_BOUNDARY): Likewise.
6598
6599 * search.c (simple_search): Remove unused var.
6600
6601 * dired.c (compile_pattern): Move decl from here ...
6602 * lisp.h: ... to here, so that it can be checked.
6603 (struct re_registers): New forward decl.
6604
6605 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6606
6607 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6608 All uses changed.
6609 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6610 Rename locals to avoid shadowing.
6611 (Fvertical_motion): Mark locals as initialized.
6612
6613 * casefiddle.c (casify_object, casify_region): Now static.
6614 (casify_region): Mark local as initialized.
6615
6616 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6617
6618 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6619 New macros, so that the caller can use some names other than
6620 gcpro1, gcpro2, etc.
6621 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6622 of the new macros.
6623 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6624 argument, for consistency with GCPRO2_VAR, etc: it is now the
6625 prefix of the variable, not the variable itself. All uses
6626 changed.
6627 * dired.c (directory_files_internal, file_name_completion):
6628 Rename locals to avoid shadowing.
6629
6630 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6631 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6632 dired.c's scmp function, had undefined behavior.
6633 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6634 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6635 * buffer.h: ... to here, because these macros use current_buffer,
6636 and the new implementation with inline functions needs to have
6637 current_buffer in scope now, rather than later when the macros
6638 are used.
6639 (downcase, upcase1): New static inline functions.
6640 (DOWNCASE, UPCASE1): Reimplement using these functions.
6641 This avoids undefined behavior in expressions like
6642 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6643 from race conditions in accessing the global variables
6644 case_temp1 and case_temp2.
6645 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6646 * lisp.h (case_temp1, case_temp2): Remove their decls.
6647 * character.h (ASCII_CHAR_P): Move from here ...
6648 * lisp.h: ... to here, so that the inline functions mentioned
6649 above can use them.
6650
6651 * dired.c (directory_files_internal_unwind): Now static.
6652
6653 * fileio.c (file_name_as_directory, directory_file_name):
6654 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6655 Now static.
6656 (file_name_as_directory): Use const pointers when appropriate.
6657 (Fexpand_file_name): Likewise. In particular, newdir might
6658 point at constant storage, so make it a const pointer.
6659 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6660 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6661 signedness issues.
6662 (Fset_file_times, Finsert_file_contents, auto_save_error):
6663 Rename locals to avoid shadowing.
6664
6665 * minibuf.c (choose_minibuf_frame_1): Now static.
6666 (Ftry_completion, Fall_completions): Rename or remove locals
6667 to avoid shadowing.
6668
6669 * marker.c (bytepos_to_charpos): Remove; unused.
6670
6671 * lisp.h (verify_bytepos, count_markers): New decls,
6672 so that gcc does not warn that these functions aren't declared.
6673
6674 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6675 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6676 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6677 (copy_text): Remove unused local var.
6678
6679 * filelock.c (within_one_second): Now static.
6680 (lock_file_1): Rename local to avoid shadowing.
6681
6682 * buffer.c (fix_overlays_before): Mark locals as initialized.
6683 (fix_start_end_in_overlays): Likewise. This function should be
6684 simplified by using pointers-to-pointers, but that's a different
6685 matter.
6686 (switch_to_buffer_1): Now static.
6687 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6688 (report_overlay_modification): Rename locals to avoid shadowing.
6689
6690 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6691 Fix pointer signedness issue.
6692 (sys_subshell): Mark local as volatile if checking for lint,
6693 to suppress a gcc -Wclobbered warning that does not seem to be right.
6694 (MAXPATHLEN): Define only if needed.
6695
6696 * process.c (serial_open, serial_configure): Move decls from here ...
6697 * systty.h: ... to here, so that they can be checked.
6698
6699 * fns.c (get_random, seed_random): Move extern decls from here ...
6700 * lisp.h: ... to here, so that they can be checked.
6701
6702 * sysdep.c (reset_io): Now static.
6703 (wait_for_termination_signal): Remove; unused.
6704
6705 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6706 (copy_keymap_item, append_key, push_text_char_description):
6707 Now static.
6708 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6709 (DENSE_TABLE_SIZE): Remove; unused.
6710 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6711 (describe_map_tree):
6712 Rename locals to avoid shadowing.
6713
6714 * keyboard.c: Declare functions static if they are not used elsewhere.
6715 (echo_char, echo_dash, cmd_error, top_level_2):
6716 (poll_for_input, handle_async_input): Now static.
6717 (read_char, kbd_buffer_get_event, make_lispy_position):
6718 (make_lispy_event, make_lispy_movement, apply_modifiers):
6719 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6720 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6721 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6722 (read_key_sequence, read_char): Mark locals as initialized.
6723 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6724
6725 * keyboard.h (make_ctrl_char): New decl.
6726 (mark_kboards): Move decl here ...
6727 * alloc.c (mark_kboards): ... from here.
6728
6729 * lisp.h (force_auto_save_soon): New decl.
6730
6731 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6732 (DEFINE_DUMMY_FUNCTION): New macro.
6733 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6734 Use it.
6735 (main): Add casts to avoid warnings
6736 if GCC considers string literals to be constants.
6737
6738 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6739
6740 * dbusbind.c: Pointer signedness fixes.
6741 (xd_signature, xd_append_arg, xd_initialize):
6742 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6743 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6744 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6745 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6746
6747 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6748 if GCC considers string literals to be constants.
6749 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6750
6751 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6752
6753 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6754 (print_preprocess, print_object): New macro to fix last change.
6755
6756 * print.c (print_preprocess): Don't forget font objects.
6757
6758 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6759
6760 * emacs.c (USAGE3): Doc fixes.
6761
6762 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6763
6764 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6765 structure.
6766
6767 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6768
6769 * lisp.h (VWindow_system, Qfile_name_history):
6770 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6771 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6772 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6773
6774 * w32select.c: Don't #include "keyboard.h".
6775 (run_protected): Add extern declaration for waiting_for_input.
6776
6777 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6778 * w32console.c (detect_input_pending, read_input_pending)
6779 (encode_terminal_code):
6780 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6781 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6782 (w32_system_caret_y, Qfile_name_history):
6783 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6784 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6785 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6786 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6787 * w32proc.c (Qlocal, report_file_error):
6788 * w32term.c (Vwindow_system, updating_frame):
6789 * w32uniscribe.c (initialized, uniscribe_font_driver):
6790 Remove unneeded extern declarations.
6791
6792 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6793
6794 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6795
6796 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6797
6798 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6799 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6800 These macros can no longer be used for assignment.
6801
6802 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6803 Assign struct members directly, instead of using BUF_BEGV etc.
6804 (record_buffer_markers, fetch_buffer_markers): New functions for
6805 recording and fetching special buffer markers.
6806 (set_buffer_internal_1, set_buffer_temp): Use them.
6807
6808 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6809
6810 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6811
6812 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6813 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6814
6815 * xdisp.c (hscroll_window_tree):
6816 (reconsider_clip_changes): Use PT instead of BUF_PT.
6817
6818 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6819
6820 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6821 $(EMACS_ROOT)/lib/intprops.h.
6822
6823 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6824
6825 Fix more problems found by GCC 4.5.2's static checks.
6826
6827 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6828 to unsigned char * to avoid compiler diagnostic.
6829 (xg_free_frame_widgets): Make it clear that a local variable is
6830 needed only if USE_GTK_TOOLTIP.
6831 (gdk_window_get_screen): Make it clear that this macro is needed
6832 only if USE_GTK_TOOLTIP.
6833 (int_gtk_range_get_value): New function, which avoids a diagnostic
6834 from gcc -Wbad-function-cast.
6835 (xg_set_toolkit_scroll_bar_thumb): Use it.
6836 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6837 diagnostic from gcc -Wbad-function-cast.
6838 (get_utf8_string, xg_get_file_with_chooser):
6839 Rename locals to avoid shadowing.
6840 (create_dialog): Move locals to avoid shadowing.
6841
6842 * xgselect.c (xg_select): Remove unused var.
6843
6844 * image.c (four_corners_best): Mark locals as initialized.
6845 (gif_load): Initialize transparent_p to zero (Bug#8238).
6846 Mark another local as initialized.
6847 (my_png_error, my_error_exit): Mark with NO_RETURN.
6848
6849 * image.c (clear_image_cache): Now static.
6850 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6851 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6852 (x_edge_detection): Remove unnecessary cast that
6853 gcc -Wbad-function-cast diagnoses.
6854 (gif_load): Fix pointer signedness.
6855 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6856 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6857
6858 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6859
6860 Improve quality of tests for time stamp overflow.
6861 For example, without this patch (encode-time 0 0 0 1 1
6862 1152921504606846976) returns the obviously-bogus value (-948597
6863 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6864 reports time overflow. See
6865 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6866 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6867 * editfns.c: Include limits.h and intprops.h.
6868 (TIME_T_MIN, TIME_T_MAX): New macros.
6869 (time_overflow): Move earlier, to before first use.
6870 (hi_time, lo_time): New functions, for an accurate test for
6871 out-of-range times.
6872 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6873 (Fget_internal_run_time): Don't assume time_t fits in int.
6874 (make_time): Use list2 instead of Fcons twice.
6875 (Fdecode_time): More accurate test for out-of-range times.
6876 (check_tm_member): New function.
6877 (Fencode_time): Use it, to test for out-of-range times.
6878 (lisp_time_argument): Don't rely on undefined left-shift and
6879 right-shift behavior when checking for time stamp overflow.
6880
6881 * editfns.c (time_overflow): New function, refactoring common code.
6882 (Fformat_time_string, Fdecode_time, Fencode_time):
6883 (Fcurrent_time_string): Use it.
6884
6885 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6886 * dired.c (make_time): Move to ...
6887 * editfns.c (make_time): ... here.
6888 * systime.h: Note the move.
6889
6890 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6891
6892 * fringe.c (update_window_fringes): Remove unused variables.
6893
6894 * unexmacosx.c (copy_data_segment): Also copy __got section.
6895 (Bug#8223)
6896
6897 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6898
6899 * termcap.c [MSDOS]: Include "msdos.h".
6900 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6901 Constify `char *' arguments and their references according to
6902 prototypes in tparam.h.
6903
6904 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6905
6906 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6907 Adapt all references accordingly.
6908
6909 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6910
6911 2011-03-11 Tom Tromey <tromey@redhat.com>
6912
6913 * buffer.c (syms_of_buffer): Remove obsolete comment.
6914
6915 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6916
6917 * termhooks.h (encode_terminal_code): Declare prototype.
6918
6919 * msdos.c (encode_terminal_code): Don't declare prototype.
6920
6921 * term.c (encode_terminal_code): Now external again, used by
6922 w32console.c and msdos.c.
6923
6924 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6925 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6926
6927 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6928
6929 Fix some minor problems found by GCC 4.5.2's static checks.
6930
6931 * fringe.c (update_window_fringes): Mark locals as initialized
6932 (Bug#8227).
6933 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6934
6935 * alloc.c (mark_fringe_data): Move decl from here ...
6936 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6937 to check its interface.
6938 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6939
6940 * fontset.c (free_realized_fontset): Now static.
6941 (Fset_fontset_font): Rename local to avoid shadowing.
6942 (fontset_font): Mark local as initialized.
6943 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6944
6945 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6946
6947 * xselect.c (x_disown_buffer_selections): Remove; not used.
6948 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6949 (x_own_selection, Fx_disown_selection_internal): Rename locals
6950 to avoid shadowing.
6951 (x_handle_dnd_message): Remove local to avoid shadowing.
6952
6953 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6954 so that the caller can use some name other than gcpro1.
6955 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6956 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6957 (Fx_backspace_delete_keys_p):
6958 Use them to avoid shadowing, and rename vars to avoid shadowing.
6959 (x_decode_color, x_set_name, x_window): Now static.
6960 (Fx_create_frame): Add braces to silence GCC warning.
6961 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6962 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6963 Remove unused locals.
6964 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6965 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6966 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6967 macros.
6968
6969 * xterm.h (x_mouse_leave): New decl.
6970
6971 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6972 Remove unused functions.
6973 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6974 (x_calc_absolute_position): Now static.
6975 (XTread_socket): Don't define label "out" unless it's used.
6976 Don't declare local "event" unless it's used.
6977 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6978 unless they are used.
6979 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6980 (x_fatal_error_signal): Remove; not used.
6981 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6982 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6983 (x_error_catcher, x_connection_closed, x_error_handler):
6984 (x_error_quitter, xembed_send_message, x_iconify_frame):
6985 (my_log_handler): Rename locals to avoid shadowing.
6986 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6987 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6988
6989 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6990 Rename or move locals to avoid shadowing.
6991 (tty_defined_color, merge_face_heights): Now static.
6992 (free_realized_faces_for_fontset): Remove; not used.
6993 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6994 does not deduce is never used uninitialized.
6995 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6996 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6997
6998 * terminal.c (store_terminal_param): Now static.
6999
7000 * xmenu.c (menu_highlight_callback): Now static.
7001 (set_frame_menubar): Remove unused local.
7002 (xmenu_show): Rename parameter to avoid shadowing.
7003 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7004 since they might point to immutable storage.
7005 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7006 since it's unused otherwise.
7007
7008 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7009 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7010 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7011 avoids a gcc -Wuninitialized diagnostic.
7012 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7013 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7014 does not deduce are never used uninitialized.
7015
7016 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7017
7018 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7019 * window.c (window_loop, size_window):
7020 (run_window_configuration_change_hook, enlarge_window): Likewise.
7021
7022 * window.c (display_buffer): Now static.
7023 (size_window): Mark variables that gcc -Wuninitialized
7024 does not deduce are never used uninitialized.
7025 * window.h (check_all_windows): New decl, to forestall
7026 gcc -Wmissing-prototypes diagnostic.
7027 * dispextern.h (bidi_dump_cached_states): Likewise.
7028
7029 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7030 shadowing.
7031 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7032 Include <limits.h>.
7033 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7034 and to avoid gcc -Wuninitialized warning.
7035 (load_charset_map): Mark variables that gcc -Wuninitialized
7036 does not deduce are never used uninitialized.
7037 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7038
7039 * coding.c (coding_set_source, coding_set_destination):
7040 Use "else { /* comment */ }" rather than "else /* comment */;"
7041 for clarity, and to avoid gcc -Wempty-body warning.
7042 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7043 a block, when the outer 'i' will do.
7044 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7045 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7046 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7047 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7048 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7049 Rename locals to avoid shadowing.
7050 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7051 * coding.c (emacs_mule_char, encode_invocation_designation):
7052 Now static, since they're not used elsewhere.
7053 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7054 (decode_coding_object, encode_coding_object, detect_coding_system):
7055 (decode_coding_emacs_mule): Mark variables that gcc
7056 -Wuninitialized does not deduce are never used uninitialized.
7057 (detect_coding_iso_2022): Initialize a local variable that might
7058 be used uninitialized. Leave a FIXME because it's not clear that
7059 this initialization is needed. (Bug#8211)
7060 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7061 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7062 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7063 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7064 Remove unused macros.
7065
7066 * category.c (hash_get_category_set): Remove unused local var.
7067 (copy_category_table): Now static, since it's not used elsewhere.
7068 * character.c (string_count_byte8): Likewise.
7069
7070 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7071 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7072
7073 * chartab.c (copy_sub_char_table): Now static, since it's not used
7074 elsewhere.
7075 (sub_char_table_ref_and_range, char_table_ref_and_range):
7076 Rename locals to avoid shadowing.
7077 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7078
7079 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7080 (BIDI_BOB): Remove unused macro.
7081
7082 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7083 deduce are never used uninitialized.
7084 * term.c (encode_terminal_code): Likewise.
7085
7086 * term.c (encode_terminal_code): Now static. Remove unused local.
7087
7088 * tparam.h: New file.
7089 * term.c, tparam.h: Include it.
7090 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7091 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7092 Move these decls to tparam.h, and make them agree with what
7093 is actually in tparam.c. The previous trick of using incompatible
7094 decls in different modules does not conform to the C standard.
7095 All callers of tparam changed to use tparam's actual API.
7096 * tparam.c (tparam1, tparam, tgoto):
7097 Use const pointers where appropriate.
7098
7099 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7100 * cm.h (struct cm): Likewise.
7101 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7102 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7103 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7104 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7105 (turn_on_face, init_tty): Likewise.
7106 * termchar.h (struct tty_display_info): Likewise.
7107
7108 * term.c (term_mouse_position): Rename local to avoid shadowing.
7109
7110 * alloc.c (mark_ttys): Move decl from here ...
7111 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7112
7113 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7114
7115 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7116
7117 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7118
7119 * search.c (compile_pattern_1): Remove argument regp, unused since
7120 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7121 (compile_pattern): Don't pass it.
7122
7123 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7124
7125 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7126 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7127 for ! HAVE_GTK3.
7128 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7129
7130 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7131
7132 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7133 gdk_window_get_screen, gdk_window_get_geometry,
7134 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7135 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7136 (xg_get_pixbuf_from_pixmap): New function.
7137 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7138 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7139 Call xg_get_pixbuf_from_pixmap instead of
7140 gdk_pixbuf_get_from_drawable.
7141 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7142 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7143 (xg_check_special_colors): Use GtkStyleContext and its functions
7144 for HAVE_GTK3.
7145 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7146 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7147 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7148 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7149 Call gtk_widget_get_preferred_size.
7150 (xg_frame_resized): gdk_window_get_geometry only takes 5
7151 parameters.
7152 (xg_win_to_widget, xg_event_is_for_menubar):
7153 Call gdk_x11_window_lookup_for_display.
7154 (xg_set_widget_bg): New function.
7155 (delete_cb): New function.
7156 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7157 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7158 (xg_set_background_color): Call xg_set_widget_bg.
7159 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7160 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7161 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7162 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7163 if ! HAVE_GTK3.
7164 (update_frame_tool_bar): Call gtk_widget_hide.
7165 (xg_initialize): Use GDK_KEY_g.
7166
7167 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7168 if ! HAVE_GTK3
7169 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7170
7171 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7172 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7173 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7174
7175 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7176
7177 * w32xfns.c (select_palette): Check success of RealizePalette against
7178 GDI_ERROR, not zero.
7179
7180 See ChangeLog.11 for earlier changes.
7181
7182 ;; Local Variables:
7183 ;; coding: utf-8
7184 ;; End:
7185
7186 Copyright (C) 2011 Free Software Foundation, Inc.
7187
7188 This file is part of GNU Emacs.
7189
7190 GNU Emacs is free software: you can redistribute it and/or modify
7191 it under the terms of the GNU General Public License as published by
7192 the Free Software Foundation, either version 3 of the License, or
7193 (at your option) any later version.
7194
7195 GNU Emacs is distributed in the hope that it will be useful,
7196 but WITHOUT ANY WARRANTY; without even the implied warranty of
7197 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7198 GNU General Public License for more details.
7199
7200 You should have received a copy of the GNU General Public License
7201 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.