1 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3 * xdisp.c (compute_display_string_pos): Remove unused local.
5 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7 Fix slow cursor motion and scrolling in large buffers with
8 selective display, like Org Mode buffers. (Bug#9218)
10 * dispextern.h (struct bidi_it): New member disp_prop_p.
12 * xdisp.c: Remove one-slot cache of display string positions.
13 (compute_display_string_pos): Accept an additional argument
14 DISP_PROP_P; callers changed. Scan at most 5K characters forward
15 for a display string or property. If found, set DISP_PROP_P
18 * bidi.c (bidi_fetch_char): Accept an additional argument
19 DISP_PROP_P, and pass it to compute_display_string_pos. Only
20 handle text covered by a display string if DISP_PROP_P is returned
21 non-zero. All callers of bidi_fetch_char changed.
23 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
25 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
27 2010-12-03 Don March <don@ohspite.net>
29 * keymap.c (Fdefine_key): Fix non-prefix key error message when
30 last character M-[char] is translated to ESC [char] (bug#7541).
32 2011-08-02 Kenichi Handa <handa@m17n.org>
34 * lisp.h (uniprop_table): Extern it.
36 * chartab.c (uniprop_table): Make it non-static.
38 2011-08-01 Eli Zaretskii <eliz@gnu.org>
40 * xdisp.c (forward_to_next_line_start): Accept additional argument
41 BIDI_IT_PREV, and store into it the state of the bidi iterator had
43 (reseat_at_next_visible_line_start): Use the bidi iterator state
44 returned by forward_to_next_line_start to restore the state of
45 it->bidi_it after backing up to previous newline. (Bug#9212)
47 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
49 * regex.c (re_comp): Protoize.
50 (re_exec): Fix return type.
51 (regexec): Fix type of `ret'. (Bug#9203)
53 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
55 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
56 This is needed if max-image-size is a floating-point number.
58 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
60 * print.c (print_object): Print empty symbol as ##.
62 * lread.c (read1): Read ## as empty symbol.
64 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
66 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
67 setting frame foreground color (Bug#9175).
68 (x_set_background_color): Likewise.
70 * nsmenu.m (-setText): Size tooltip dimensions precisely to
72 (EmacsTooltip -init): Remove bezels and add shadows to
75 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
76 or scroll bar (Bug#8470).
78 * nsfont.m (nsfont_open): Remove assignment to voffset and
79 unnecessary vars hshink, expand, hd, full_height, min_height.
80 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
82 * nsterm.h (nsfont_info): Remove voffset field.
84 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
86 Implement strike-through and overline on NextStep (Bug#8863).
88 * nsfont.m (nsfont_open): Use underline position provided by font,
89 instead of hard-coded value of 2.
90 (nsfont_draw): Call ns_draw_text_decoration instead.
92 * nsterm.h: Add declaration for ns_draw_text_decoration.
94 * nsterm.m (ns_draw_text_decoration): New function for drawing
95 underline, overline, and strike-through.
96 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
97 ns_draw_text_decoration. Change treatment of cursor drawing to
98 accomodate underlining, etc.
100 2011-07-28 Eli Zaretskii <eliz@gnu.org>
102 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
105 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
107 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
108 Without this fix, if a signal arrives just after memory fills up,
109 'malloc' might be invoked reentrantly.
111 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
112 In other words, assume that every image size is allowed, on non-X
113 hosts. This assumption is probably wrong, but it lets Emacs compile.
115 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
117 * regex.c (re_iswctype): Convert return values to boolean.
119 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
121 * xdisp.c (compute_display_string_pos): Don't use cached display
122 string position if the buffer had its restriction changed.
125 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
127 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
129 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
131 Integer signedness and overflow and related fixes. (Bug#9079)
133 * bidi.c: Integer size and overflow fixes.
134 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
135 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
136 (bidi_cache_find_level_change, bidi_cache_ensure_space)
137 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
138 (bidi_find_other_level_edge):
139 Use ptrdiff_t instead of EMACS_INT where either will do.
140 This works better on 32-bit hosts configured --with-wide-int.
141 (bidi_cache_ensure_space): Check for size-calculation overflow.
142 Use % rather than repeated addition, for better worst-case speed.
143 Don't set bidi_cache_size until after xrealloc returns, because it
145 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
146 (bidi_cache_ensure_space): Also check that the bidi cache size
147 does not exceed that of the largest Lisp string or buffer. See Eli
148 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
150 * alloc.c (__malloc_size_t): Remove.
151 All uses replaced by size_t. See Andreas Schwab's note
152 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
154 * image.c: Improve checking for integer overflow.
155 (check_image_size): Assume that f is nonnull, since
156 it is always nonnull in practice. This is one less thing to
157 worry about when checking for integer overflow later.
158 (x_check_image_size): New function, which checks for integer
159 overflow issues inside X.
160 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
161 This removes the need for a memory_full check.
162 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
163 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
164 (xbm_read_bitmap_data): Change locals back to 'int', since
165 their values must fit in 'int'.
166 (xpm_load_image, png_load, tiff_load):
167 Invoke x_create_x_image_and_pixmap earlier,
168 to avoid much needless work if the image is too large.
169 (tiff_load): Treat overly large images as if
170 x_create_x_image_and_pixmap failed, not as malloc failures.
171 (gs_load): Use x_check_image_size.
173 * gtkutil.c: Omit integer casts.
174 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
175 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
177 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
179 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
180 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
181 would wrongly return t on a 64-bit host.
183 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
184 The plain *_OVERFLOW macros run afoul of GCC bug 49705
185 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
186 and therefore cause GCC to emit a bogus diagnostic in some cases.
188 * image.c: Integer signedness and overflow and related fixes.
189 This is not an exhaustive set of fixes, but it's time to
190 record what I've got.
191 (lookup_pixel_color, check_image_size): Remove redundant decls.
192 (check_image_size): Don't assume that arbitrary EMACS_INT values
193 fit in 'int', or that arbitrary 'double' values fit in 'int'.
194 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
195 (tiff_load, imagemagick_load_image):
196 Check for overflow in size calculations.
197 (x_create_x_image_and_pixmap): Remove unnecessary test for
198 xmalloc returning NULL; that can't happen.
199 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
200 (xpm_color_bucket): Use better integer hashing function.
201 (xpm_cache_color): Don't possibly over-allocate memory.
202 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
204 Use ptrdiff_t, not int or size_t, to record sizes.
205 (png_load): Don't assume values greater than 2**31 fit in 'int'.
206 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
207 either works, as we prefer signed integers.
208 (tiff_read_from_memory, tiff_write_from_memory):
209 Return tsize_t, not size_t, since that's what the TIFF API wants.
210 (tiff_read_from_memory): Don't fail simply because the read would
211 go past EOF; instead, return a short read.
212 (tiff_load): Omit no-longer-needed casts.
213 (Fimagemagick_types): Don't assume size fits into 'int'.
215 Improve hashing quality when configured --with-wide-int.
216 * fns.c (hash_string): New function, taken from sxhash_string.
217 Do not discard information about ASCII character case; this
218 discarding is no longer needed.
219 (sxhash-string): Use it. Change sig to match it. Caller changed.
220 * lisp.h: Declare it.
221 * lread.c (hash_string): Remove, since we now use fns.c's version.
222 The fns.c version returns a wider integer if --with-wide-int is
223 specified, so this should help the quality of the hashing a bit.
225 * emacs.c: Integer overflow minor fix.
226 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
227 Define only if GNU_LINUX.
228 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
230 * dispnew.c: Integer signedness and overflow fixes.
231 Remove unnecessary forward decls, that were a maintenance hassle.
232 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
234 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
235 (scrolling_window): Use ptrdiff_t, not int, for byte count.
236 (prepare_desired_row, line_draw_cost):
237 Use int, not unsigned, where either works.
238 (save_current_matrix, restore_current_matrix):
239 Use ptrdiff_t, not size_t, where either works.
240 (init_display): Check for overflow more accurately, and without
241 relying on undefined behavior.
243 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
244 Remove, replacing with the new symbols in lisp.h. All uses changed.
245 * fileio.c (make_temp_name):
246 * filelock.c (lock_file_1, lock_file):
247 * xdisp.c (message_dolog):
248 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
249 Use pMd etc. instead.
250 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
251 replacing the pWIDE etc. symbols removed from editfns.c.
253 * keyboard.h (num_input_events): Now uintmax_t.
254 This is (very slightly) less likely to mess up due to wraparound.
257 * buffer.c: Integer signedness fixes.
258 (alloc_buffer_text, enlarge_buffer_text):
259 Use ptrdiff_t rather than size_t when either will do, as we prefer
262 * alloc.c: Integer signedness and overflow fixes.
263 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
264 (__malloc_size_t): Default to size_t, not to int.
265 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
266 (Fgarbage_collect, mark_object_loop_halt, mark_object):
267 Prefer ptrdiff_t to size_t when either would do, as we prefer
269 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
270 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
271 Now const. Initialize with values that are in range even if char
273 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
274 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
275 These functions do the right thing with sizes > 2**32.
276 (check_depth): Now ptrdiff_t, not int.
277 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
278 Adjust to new way of storing sizes. Check for size overflow bugs
280 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
281 slightly wrong anyway, as it missed one instance of
282 XMALLOC_OVERRUN_CHECK_OVERHEAD.
283 (refill_memory_reserve): Omit needless cast to size_t.
284 (mark_object_loop_halt): Mark as externally visible.
286 * xselect.c: Integer signedness and overflow fixes.
287 (Fx_register_dnd_atom, x_handle_dnd_message):
288 Use ptrdiff_t, not size_t, since we prefer signed.
289 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
290 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
291 x_dnd_atoms_size and x_dnd_atoms_length.
293 * doprnt.c: Prefer signed to unsigned when either works.
297 * xdisp.c (vmessage):
298 Use ptrdiff_t, not size_t, when using or implementing doprnt,
299 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
300 prefer signed arithmetic to avoid comparison confusion.
301 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
304 Assume freestanding C89 headers, string.h, stdlib.h.
305 * data.c, doprnt.c, floatfns.c, print.c:
306 Include float.h unconditionally.
307 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
308 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
309 * regex.c: Likewise for stddef.h, string.h.
310 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
311 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
312 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
313 (STDC_HEADERS): Remove obsolete defines.
314 * sysdep.c: Include limits.h unconditionally.
316 Assume support for memcmp, memcpy, memmove, memset.
317 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
318 * regex.c (memcmp, memcpy):
319 Remove; we assume C89 now.
321 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
322 (__malloc_safe_bcopy): Remove; no longer needed.
324 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
325 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
326 well either way, and we prefer signed to unsigned.
328 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
330 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
331 closes the connection while we're reading (bug#9182).
333 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
335 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
336 are specified (Bug#9168).
338 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
340 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
341 Found by GCC static checking and --with-wide-int on a 32-bit host.
343 2011-07-25 Eli Zaretskii <eliz@gnu.org>
345 * xdisp.c (compute_display_string_pos): Fix logic of caching
346 previous display string position. Initialize cached_prev_pos to
347 -1. Fixes slow-down at the beginning of a buffer.
349 2011-07-24 Eli Zaretskii <eliz@gnu.org>
351 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
352 for attrs[LFACE_FONTSET_INDEX].
354 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
356 * xml.c (parse_region): Remove unused local
357 that was recently introduced.
359 2011-07-23 Eli Zaretskii <eliz@gnu.org>
361 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
362 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
364 * xdisp.c (move_it_in_display_line_to): Record the best matching
365 position for TO_CHARPOS while scanning the line, and restore it on
366 exit if none of the characters scanned was an exact match. Fixes
367 vertical-motion and pos-visible-in-window-p under bidi redisplay
368 when exact match is impossible due to invisible text, and the
371 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
373 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
376 2011-07-22 Eli Zaretskii <eliz@gnu.org>
378 Fix a significant slow-down of cursor motion with C-n, C-p,
379 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
380 auto-repeat under bidi redisplay in fontified buffers.
381 * xdisp.c (compute_stop_pos_backwards): New function.
382 (next_element_from_buffer): Call compute_stop_pos_backwards to
383 find a suitable prev_stop when we find ourselves before
385 (reseat): Don't look for prev_stop, as that could mean a very long
387 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
388 <cached_disp_overlay_modiff>: Cache for last found display string
390 (compute_display_string_pos): Return the cached position if asked
391 about the same buffer in the same area of character positions, and
392 the buffer wasn't changed since the time the display string
395 2011-07-22 Eli Zaretskii <eliz@gnu.org>
397 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
398 is an integer, which is important for empty lines. (Bug#9149)
400 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
402 * frame.c (Fmodify_frame_parameters): In tty case, update the
403 default face if necessary (Bug#4238).
405 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
407 * editfns.c (Fstring_to_char): No need to explain what a character
408 is in the docstring (Bug#6576).
410 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
412 * xml.c (parse_region): Make sure we always return a tree.
414 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
416 * xml.c (parse_region): If a document contains only comments,
419 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
421 * xml.c (make_dom): Return comments, too.
423 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
426 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
427 and the surrounding thread.
428 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
429 rather than fgets, and retry after EINTR. Otherwise, 'emacs
430 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
432 * s/openbsd.h (BROKEN_SIGIO): Define.
433 * unexelf.c (unexec) [__OpenBSD__]:
434 Don't update the .mdebug section of the Alpha COFF symbol table.
436 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
438 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
441 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
443 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
444 This fixes some race conditions on the permissions of any newly
447 * alloc.c (valid_pointer_p): Use pipe, not open.
448 This fixes some permissions issues when debugging.
450 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
451 If fchown fails to set both uid and gid, try to set just gid,
452 as that is sometimes allowed. Adjust the file's mode to eliminate
453 setuid or setgid bits that are inappropriate if fchown fails.
455 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
457 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
458 to compare Lisp_Objects.
459 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
460 global_gnutls_log_level, don't mistake it for a Lisp_Object.
461 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
463 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
465 * lread.c (read_integer): Unread even EOF character.
466 (read1): Likewise. Properly record start position of symbol.
468 * lread.c (read1): Read `#:' as empty uninterned symbol if no
469 symbol character follows.
471 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
473 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
474 This works around a problem with the previous change to Fcopy_file.
475 Recent glibc declares fchown with __attribute__((warn_unused_result)),
476 and without this change, GCC might complain about discarding
477 fchown's return value.
479 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
481 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
483 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
485 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
487 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
489 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
490 it's used from the C level.
492 * process.c: Use the same condition for POLL_FOR_INPUT in both
493 keyboard.c and process.c (bug#1858).
495 2011-07-09 Lawrence Mitchell <wence@gmx.li>
497 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
498 (Fgnutls_boot): Use it.
500 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
502 * doc.c (Fsubstitute_command_keys): Revert last change.
504 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
506 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
507 quotes the next character, and doesn't affect other longer
508 sequences (bug#8935).
510 * lread.c (syms_of_lread): Clarify that is isn't only
511 `eval-buffer' and `eval-defun' that's affected by
512 `lexical-binding' (bug#8460).
514 2011-07-15 Eli Zaretskii <eliz@gnu.org>
516 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
517 bidi redisplay when a line includes both an image and is
520 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
522 Fix minor problems found by static checking.
523 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
524 (elsz): Now a signed constant, not a size_t var. We prefer signed
525 types to unsigned, to avoid integer comparison confusion. Without
526 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
527 "cannot optimize loop, the loop counter may overflow", a symptom
529 * indent.c (Fvertical_motion): Mark locals as initialized.
530 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
532 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
534 * search.c (Fre_search_backward): Mention `case-fold-search' in
535 all the re_search_* functions (bug#8138).
537 * keyboard.c (Fopen_dribble_file): Document when the file is
540 2011-07-14 Eli Zaretskii <eliz@gnu.org>
542 * bidi.c (bidi_dump_cached_states): Fix format of displaying
545 Support bidi reordering of display and overlay strings.
546 * xdisp.c (compute_display_string_pos)
547 (compute_display_string_end): Accept additional argument STRING.
548 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
549 (reseat_to_string): Initialize bidi_it->string.s and
550 bidi_it->string.schars.
551 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
552 NULL (avoids a crash in bidi_paragraph_init). Initialize
554 (init_iterator): Call bidi_init_it only of a valid
555 buffer position was specified. Initialize paragraph_embedding to
557 (reseat_to_string): Initialize the bidi iterator.
558 (display_string): If we need to ignore text properties of
559 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
560 original value of -1 will not work with bidi.)
561 (compute_display_string_pos): First arg is now struct
562 `text_pos *'; all callers changed. Support display properties on
564 (compute_display_string_end): Support display properties on Lisp
566 (init_iterator, reseat_1, reseat_to_string): Initialize the
567 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
568 when iterating on a string not from display properties).
569 (compute_display_string_pos, compute_display_string_end): Fix
570 calculation of the object to scan. Fixes an error when using
572 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
573 base_level_stop; instead, set base_level_stop to BEGV. Fixes
574 crashes in vertical-motion.
575 (next_element_from_buffer): Improve commentary for when
576 the iterator is before prev_stop.
577 (init_iterator): Initialize bidi_p from the default value of
578 bidi-display-reordering, not from buffer-local value. Use the
579 buffer-local value only if initializing for buffer iteration.
580 (handle_invisible_prop): Support invisible properties on strings
581 that are being bidi-reordered.
582 (set_iterator_to_next): Support bidi reordering of C strings and
584 (next_element_from_string): Support bidi reordering of Lisp
586 (handle_stop_backwards): Support Lisp strings as well.
587 (display_string): Support display of R2L glyph rows. Use
588 IT_STRING_CHARPOS when displaying from a Lisp string.
589 (init_iterator): Don't initialize it->bidi_p for strings
591 (reseat_to_string): Initialize it->bidi_p for strings here.
592 (next_element_from_string, next_element_from_c_string)
593 (next_element_from_buffer): Add xassert's for correspondence
594 between IT's object being iterated and it->bidi_it.string
596 (face_before_or_after_it_pos): Support bidi iteration.
597 (next_element_from_c_string): Handle the case of the first string
598 character that is not the first one in the visual order.
599 (get_visually_first_element): New function, refactored from common
600 parts of next_element_from_buffer, next_element_from_string, and
601 next_element_from_c_string.
602 (tool_bar_lines_needed, redisplay_tool_bar)
603 (display_menu_bar): Force left-to-right direction. Add a FIXME
604 comment for making that be controlled by a user option.
605 (push_it, pop_it): Save and restore the state of the
606 bidi iterator. Save and restore the bidi_p flag.
607 (pop_it): Iterate out of display property for string iteration as
609 (iterate_out_of_display_property): Support iteration over strings.
610 (handle_single_display_spec): Set up it->bidi_it for iteration
611 over a display string, and call bidi_init_it.
612 (handle_single_display_spec, next_overlay_string)
613 (get_overlay_strings_1, push_display_prop): Set up the bidi
614 iterator for displaying display or overlay strings.
615 (forward_to_next_line_start): Don't use the shortcut if
617 (back_to_previous_visible_line_start): If handle_display_prop
618 pushed the iterator stack, restore the internal state of the bidi
619 iterator by calling bidi_pop_it same number of times.
620 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
621 and we are bidi-iterating, don't decrement the iterator position;
622 instead, set the first_elt flag in the bidi iterator, to produce
624 (reseat_1): Remove redundant setting of string_from_display_prop_p.
625 (push_display_prop): xassert that we are iterating a buffer.
626 (push_it, pop_it): Save and restore paragraph_embedding member.
627 (handle_single_display_spec, next_overlay_string)
628 (get_overlay_strings_1, reseat_1, reseat_to_string)
629 (push_display_prop): Set up the `unibyte' member of bidi_it.string
630 correctly. Don't assume unibyte strings are not bidi-reordered.
631 (compute_display_string_pos)
632 (compute_display_string_end): Fix handling the case of C string.
633 (push_it, pop_it): Save and restore from_disp_prop_p.
634 (handle_single_display_spec, push_display_prop): Set the
635 from_disp_prop_p flag.
636 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
637 (pop_it): Call iterate_out_of_display_property only if we are
638 popping after iteration over a string that came from a display
639 property. Fix a typo in popping stretch info. Add an assertion
640 for verifying that the iterator position is in sync with the bidi
642 (handle_single_display_spec, get_overlay_strings_1)
643 (push_display_prop): Fix initialization of paragraph direction for
644 string when that of the parent object is not yet determined.
645 (reseat_1): Call bidi_init_it to resync the bidi
646 iterator with IT's position. (Bug#7616)
647 (find_row_edges): If ROW->start.pos gives position
648 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
649 (handle_stop, back_to_previous_visible_line_start, reseat_1):
650 Reset the from_disp_prop_p flag.
651 (SAVE_IT, RESTORE_IT): New macros.
652 (pos_visible_p, face_before_or_after_it_pos)
653 (back_to_previous_visible_line_start)
654 (move_it_in_display_line_to, move_it_in_display_line)
655 (move_it_to, move_it_vertically_backward, move_it_by_lines)
656 (try_scrolling, redisplay_window, display_line): Use them when
657 saving a temporary copy of the iterator and restoring it back.
658 (back_to_previous_visible_line_start, reseat_1)
659 (init_iterator): Empty the bidi cache "stack".
660 (move_it_in_display_line_to): If iterator ended up at
661 EOL, but we never saw any buffer positions smaller than
662 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
663 motion in bidi-reordered lines.
664 (move_it_in_display_line_to): Record prev_method and prev_pos
665 immediately before the call to set_iterator_to_next. Fixes cursor
666 motion in bidi-reordered lines with stretch glyphs and strings
667 displayed in margins. (Bug#8133) (Bug#8867)
668 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
670 (pos_visible_p): Support positions in bidi-reordered lines. Save
671 and restore bidi cache.
673 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
674 (bidi_paragraph_info): Delete unused struct.
675 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
676 (bidi_cache_start): New variable.
677 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
679 (bidi_cache_fetch_state, bidi_cache_search)
680 (bidi_cache_find_level_change, bidi_cache_iterator_state)
681 (bidi_cache_find, bidi_peek_at_next_level)
682 (bidi_level_of_next_char, bidi_find_other_level_edge)
683 (bidi_move_to_visually_next): Compare cache index with
684 bidi_cache_start rather than with zero.
685 (bidi_fetch_char): Accept new argument STRING; all callers
686 changed. Support iteration over a string. Support strings with
687 display properties. Support unibyte strings. Fix the type of
688 `len' according to what STRING_CHAR_AND_LENGTH expects.
689 (bidi_paragraph_init, bidi_resolve_explicit_1)
690 (bidi_resolve_explicit, bidi_resolve_weak)
691 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
692 iteration over a string.
693 (bidi_set_sor_type, bidi_resolve_explicit_1)
694 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
695 can now be zero (for strings); special values 0 and -1 were
696 changed to -1 and -2, respectively.
697 (bidi_char_at_pos): New function.
698 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
699 Call it instead of FETCH_MULTIBYTE_CHAR.
700 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
701 initialized to valid values.
702 (bidi_init_it): Don't initialize charpos and bytepos with invalid
704 (bidi_level_of_next_char): Allow the sentinel "position" to pass
705 the test for valid cached positions. Fix the logic for looking up
706 the sentinel state in the cache. GCPRO the Lisp string we are
708 (bidi_push_it, bidi_pop_it): New functions.
709 (bidi_initialize): Initialize the bidi cache start stack pointer.
710 (bidi_cache_ensure_space): New function, refactored from part of
711 bidi_cache_iterator_state. Don't assume the required size is just
712 one BIDI_CACHE_CHUNK away.
713 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
714 (bidi_count_bytes, bidi_char_at_pos): New functions.
715 (bidi_cache_search): Don't assume bidi_cache_last_idx is
716 always valid if bidi_cache_idx is valid.
717 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
718 is valid if it's going to be used.
719 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
720 (bidi_cache_fetch_state, bidi_cache_search)
721 (bidi_cache_find_level_change, bidi_cache_ensure_space)
722 (bidi_cache_iterator_state, bidi_cache_find)
723 (bidi_find_other_level_edge, bidi_cache_start_stack): All
724 variables related to cache indices are now EMACS_INT.
726 * dispextern.h (struct bidi_string_data): New structure.
727 (struct bidi_it): New member `string'. Make flag members be 1-bit
728 fields, and put them last in the struct.
729 (compute_display_string_pos, compute_display_string_end): Update
731 (bidi_push_it, bidi_pop_it): Add prototypes.
732 (struct iterator_stack_entry): New members bidi_p,
733 paragraph_embedding, and from_disp_prop_p.
734 (struct it): Member bidi_p is now a bit field 1 bit wide.
735 (bidi_shelve_cache, bidi_unshelve_cache): Declare
738 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
739 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
740 and vector-like objects.
742 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
743 cache around display iteration.
745 * window.c (Fwindow_end, window_scroll_pixel_based)
746 (displayed_window_lines, Frecenter): Save and restore the bidi
747 cache around display iteration.
749 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
751 * editfns.c (Fdelete_region): Clarify the use of the named
752 parameters (bug#6788).
754 2011-07-14 Martin Rudalics <rudalics@gmx.at>
756 * indent.c (Fvertical_motion): Set and restore w->pointm when
757 saving and restoring the window's buffer (Bug#9006).
759 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
761 * editfns.c (Fstring_to_char): Clarify just what is returned
762 (bug#6576). Text by Eli Zaretskii.
764 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
766 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
768 2011-07-13 Eli Zaretskii <eliz@gnu.org>
770 * buffer.c (mmap_find): Fix a typo.
772 2011-07-13 Johan Bockgård <bojohan@gnu.org>
774 Fix execution of x selection hooks.
775 * xselect.c (Qx_lost_selection_functions)
776 (Qx_sent_selection_functions): New vars.
777 (syms_of_xselect): DEFSYM them.
778 (x_handle_selection_request): Pass Qx_sent_selection_functions
779 rather than Vx_sent_selection_functions to Frun_hook_with_args.
780 (x_handle_selection_clear,x_clear_frame_selections):
781 Pass Qx_lost_selection_functions rather than
782 Vx_lost_selection_functions to Frun_hook_with_args.
784 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
786 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
787 The old code sometimes used this field without initializing it.
789 * alloc.c (gc_sweep): Don't read past end of array.
790 In theory, the old code could also have corrupted Emacs internals,
791 though it'd be very unlikely.
793 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
795 * character.c (Fcharacterp): Don't advertise optional ignored
798 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
800 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
803 * window.c (Fset_window_start): Doc fix (bug#4199).
804 (Fset_window_hscroll): Ditto.
806 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
808 Fix minor new problems caught by GCC 4.6.1.
809 * term.c (init_tty): Remove unused local.
810 * xsettings.c (store_monospaced_changed): Define this function only
811 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
814 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
816 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
818 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
820 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
821 are the mini-buffer and the echo area (bug#3320).
823 * term.c (init_tty): Remove support for supdup, c10 and perq
824 terminals, which are no longer supported (bug#1482).
826 2011-07-10 Johan Bockgård <bojohan@gnu.org>
828 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
830 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
832 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
833 for non-popups (Bug#3642).
835 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
837 * alloc.c (reset_malloc_hooks): Protoize.
838 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
839 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
840 * cm.c (losecursor): Likewise.
841 * data.c (fmod): Likewise.
842 * dispnew.c (swap_glyphs_in_rows): Likewise.
843 * emacs.c (memory_warning_signal): Likewise.
844 * floatfns.c (float_error): Likewise.
845 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
846 (otf_open, font_otf_capability, generate_otf_features)
847 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
849 * image.c (pbm_read_file): Likewise.
850 * indent.c (string_display_width): Likewise.
851 * intervals.c (check_for_interval, search_for_interval)
852 (inc_interval_count, count_intervals, root_interval)
853 (adjust_intervals_for_insertion, make_new_interval): Likewise.
854 * lread.c (defalias): Likewise.
855 * ralloc.c (r_alloc_check): Likewise.
856 * regex.c (set_image_of_range_1, set_image_of_range)
857 (regex_grow_registers): Likewise.
858 * sysdep.c (strerror): Likewise.
859 * termcap.c (valid_filename_p, tprint, main): Likewise.
860 * tparam.c (main): Likewise.
861 * unexhp9k800.c (run_time_remap, save_data_space)
862 (update_file_ptrs, read_header, write_header, calculate_checksum)
863 (copy_file, copy_rest, display_header): Likewise.
864 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
866 * xdisp.c (check_it): Likewise.
867 * xfaces.c (register_color, unregister_color, unregister_colors):
869 * xfns.c (print_fontset_result): Likewise.
870 * xrdb.c (member, fatal, main): Likewise.
872 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
874 Fix minor problems found by static checking (Bug#9031).
875 * chartab.c (char_table_set_range, map_sub_char_table):
876 Remove unused locals.
877 (uniprop_table): Now static.
878 * composite.c (_work_char): Remove unused static var.
880 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
882 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
884 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
886 * gtkutil.c (qttip_cb): Remove code without function.
888 2011-07-09 Eli Zaretskii <eliz@gnu.org>
890 * w32.c (pthread_sigmask): New stub.
892 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
894 Use pthread_sigmask, not sigprocmask (Bug#9010).
895 sigprocmask is portable only for single-threaded applications, and
896 Emacs can be multi-threaded when it uses GTK.
897 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
899 * callproc.c (Fcall_process):
900 * process.c (create_process):
901 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
902 Use pthread_sigmask, not sigprocmask.
904 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
906 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
907 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
910 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
912 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
913 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
914 (xg_hide_tooltip): Fix comment.
916 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
917 in registerServicesMenuSendTypes.
918 (validRequestorForSendType): Don't check ns_return_types.
920 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
923 2011-07-08 Jason Rumney <jasonr@gnu.org>
925 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
926 frame struct members of non-existent frames (Bug#6284).
928 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
930 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
931 variable firstTime not needed on OSX >= 10.6.
932 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
933 >= 10.5. Use setKnobProportion, setDoubleValue.
935 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
936 (MAC_OS_X_VERSION_10_5): Define if not defined.
937 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
938 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
939 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
941 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
942 cString and lossyCString on OSX >= 10.4
944 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
945 sizeToFit on OSX >= 10.2.
947 * nsimage.m (allocInitFromFile): Don't use deprecated method
948 bestRepresentationForDevice on OSX >= 10.6.
950 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
953 * emacs.c: Declare unexec_init_emacs_zone.
955 * nsgui.h: Fix compiler warning about gnulib redefining verify.
957 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
959 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
960 on svcsMenu (Bug#8842).
962 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
964 (Fns_list_services): Just return Qnil on 10.6, code not working there.
966 * nsterm.m (QUTF8_STRING): Declare.
967 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
968 (validRequestorForSendType): Return type is (id).
969 Change indexOfObjectIdenticalTo to indexOfObject.
970 Check if we have local selection before returning self (Bug#8842).
971 (writeSelectionToPasteboard): Put local selection into paste board
972 if we have a local selection (Bug#8842).
973 (syms_of_nsterm): DEFSYM QUTF8_STRING.
975 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
976 (ns_get_local_selection): Declare.
978 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
980 * keymap.c (describe_map_tree): Don't insert a double newline at
981 the end of the buffer (bug#1169) and return whether we inserted
984 * callint.c (Fcall_interactively): Change "reading args" to
985 "providing args" to try to clarify what it does (bug#1010).
987 2011-07-07 Kenichi Handa <handa@m17n.org>
989 * composite.c (composition_compute_stop_pos): Ignore a static
990 composition starting before CHARPOS (Bug#8915).
992 * xdisp.c (handle_composition_prop): Likewise.
994 2011-07-07 Eli Zaretskii <eliz@gnu.org>
996 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
999 2011-07-07 Kenichi Handa <handa@m17n.org>
1001 * character.h (unicode_category_t): New enum type.
1003 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1004 (Qchar_code_property_table): New variable.
1005 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1006 (UNIPROP_COMPRESSED_FORM_P): New macros.
1007 (char_table_ascii): Uncompress the compressed values.
1008 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1009 Uncompress the compressed values.
1010 (sub_char_table_ref_and_range): Likewise.
1011 (char_table_ref_and_range): Uncompress the compressed values.
1012 (sub_char_table_set): New arg is_uniprop. Callers changed.
1013 Uncompress the compressed values.
1014 (sub_char_table_set_range): Args changed. Callers changed.
1015 (char_table_set_range): Adjuted for the above change.
1016 (map_sub_char_table): Delete args default_val and parent. Add arg
1017 top. Give decoded values to a Lisp function.
1018 (map_char_table): Adjusted for the above change. Give decoded
1019 values to a Lisp function. Gcpro more variables.
1020 (uniprop_table_uncompress)
1021 (uniprop_decode_value_run_length): New functions.
1022 (uniprop_decoder, uniprop_decoder_count): New variables.
1023 (uniprop_get_decoder, uniprop_encode_value_character)
1024 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1026 (uniprop_encoder, uniprop_encoder_count): New variables.
1027 (uniprop_get_encoder, uniprop_table)
1028 (Funicode_property_table_internal, Fget_unicode_property_internal)
1029 (Fput_unicode_property_internal): New functions.
1030 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1031 Sunicode_property_table_internal, Sget_unicode_property_internal,
1032 and Sput_unicode_property_internal. Defvar_lisp
1033 char-code-property-alist.
1035 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
1036 Vunicode_category_table.
1038 * font.c (font_range): Adjusted for the change of
1039 Vunicode_category_table.
1041 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1043 * m/iris4d.h: Remove file, move contents ...
1044 * s/irix6-5.h: ... here.
1046 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1048 Remove unportable assumption about struct layout (Bug#8884).
1049 * alloc.c (mark_buffer):
1050 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1051 (clone_per_buffer_values): Don't assume that
1052 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1053 This isn't true in general, and it's particularly not true
1054 if Emacs is configured with --with-wide-int.
1055 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1056 New macros, used in the buffer.c change.
1058 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1060 * xsettings.c: Use both GConf and GSettings if both are available.
1061 (store_config_changed_event): Add comment.
1062 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1063 (store_tool_bar_style_changed): New functions.
1064 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1065 (struct xsettings): Move font inside HAVE_XFT.
1066 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1067 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
1068 Move inside HAVE_XFT.
1069 (something_changed_gsettingsCB): Renamed from something_changedCB.
1070 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1072 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1073 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1074 (something_changed_gconfCB): Renamed from something_changedCB.
1075 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1076 (parse_settings): Move check for font inside HAVE_XFT.
1077 (read_settings, apply_xft_settings): Add comment.
1078 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1079 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1080 call store_font_name_changed.
1081 (xft_settings_event): Add comment.
1082 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1083 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1084 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1085 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1086 (xsettings_initialize): Call init_gsettings last.
1087 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
1090 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1092 Random fixes. E.g., (random) never returned negative values.
1093 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1094 subseconds part to the entropy, as that's a bit more random.
1095 Prefer signed to unsigned, since the signedness doesn't matter and
1096 in general we prefer signed. When given a limit, use a
1097 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1098 latter isn't right if USE_2_TAGS_FOR_INTS.
1099 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1100 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1102 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1104 * textprop.c (text_property_stickiness):
1105 Obey Vtext_property_default_nonsticky.
1106 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1107 * w32fns.c (syms_of_w32fns):
1108 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1110 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1112 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1113 This is more efficient than Ffile_directory_p and avoids a minor race.
1115 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1117 * buffer.c (Foverlay_put): Say what the return value is
1120 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1121 is a directory before asking whether to use the file name
1123 (barf_or_query_if_file_exists): Make the "File is a directory"
1124 error be more correct.
1126 * fns.c (Frequire): Remove the mention of the .gz files, since
1127 that's installation-specific, but keep the mention of
1128 `get-load-suffixes'.
1130 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1132 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1133 Report string overflow if the output is too long.
1135 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1137 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1138 (syms_of_gnutls): Remove duplicate DEFSYM for
1139 Qgnutls_bootprop_verify_hostname_error, an error for
1140 Qgnutls_bootprop_verify_error (which is no longer used).
1142 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1143 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1144 Also (re)move comments that are misplaced or no longer relevant.
1146 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1148 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1150 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1152 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1153 and background color parameters if they have been changed.
1155 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1157 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1159 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1161 * xsettings.c (SYSTEM_FONT): Define only when used.
1162 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1164 * keymap.c (access_keymap_1): Now static.
1166 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1168 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1169 leave any prefix arg for the up event (Bug#1586).
1171 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1173 * lread.c (syms_of_lread): Mention single symbols defined by
1174 `defvar' or `defconst' (bug#7154).
1176 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1177 (Frequire): Mention get-load-suffixes.
1179 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1181 * window.h (window): Remove clone_number slot.
1182 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1184 (make_parent_window, make_window, saved_window)
1185 (Fset_window_configuration, save_window_save): Don't deal with
1187 * buffer.c (Qclone_number): Remove declaration.
1188 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1190 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1192 Add multiple inheritance to keymaps.
1193 * keymap.c (Fmake_composed_keymap): New function.
1194 (Fset_keymap_parent): Simplify.
1195 (fix_submap_inheritance): Remove.
1196 (access_keymap_1): New function extracted from access_keymap to handle
1197 embedded parents and handle lists of maps.
1198 (access_keymap): Use it.
1199 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1200 (Fcopy_keymap): Handle embedded parents.
1201 (Fcommand_remapping, define_as_prefix): Simplify.
1202 (Fkey_binding): Simplify.
1203 (syms_of_keymap): Move minibuffer-local-completion-map,
1204 minibuffer-local-filename-completion-map,
1205 minibuffer-local-must-match-map, and
1206 minibuffer-local-filename-must-match-map to Elisp.
1207 (syms_of_keymap): Defsubr make-composed-keymap.
1208 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1209 (parse_menu_item): Trivial simplification.
1211 2011-07-01 Glenn Morris <rgm@gnu.org>
1213 * Makefile.in (SETTINGS_LIBS): Fix typo.
1215 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1217 * coding.c (Fencode_coding_string): Record the last coding system
1218 used, as the function doc string says (bug#8738).
1220 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1222 * xsettings.c (store_monospaced_changed): Take new font as arg and
1223 check for change against current_mono_font.
1224 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1225 (emacs_settings_constructor, emacs_settings_get_property)
1226 (emacs_settings_set_property, emacs_settings_class_init)
1227 (emacs_settings_init, gsettings_obj): Remove.
1228 (something_changedCB): New function for HAVE_GSETTINGS.
1229 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1230 with value as argument.
1231 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1232 g_settings_new (Bug#8967). Do not create gsettings_obj.
1233 Remove calls to g_settings_bind. Connect something_changedCB to
1236 * xgselect.c: Add defined (HAVE_GSETTINGS).
1237 (xgselect_initialize): Ditto.
1239 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1240 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1243 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1245 * eval.c (struct backtrace): Simplify and port the data structure.
1246 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1247 signed bit field, as this assumption is not portable and it makes
1248 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1249 "char debug_on_exit : 1" as this is not portable either; instead,
1250 use the portable "unsigned int debug_on_exit : 1". Remove unused
1251 member evalargs. Remove obsolete comments about cc bombing out.
1253 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1255 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1256 Let HAVE_GSETTINGS override HAVE_GCONF.
1257 (store_monospaced_changed): New function.
1258 (EMACS_SETTINGS): A new type derived from GObject to handle
1259 GSettings notifications.
1260 (emacs_settings_constructor, emacs_settings_get_property)
1261 (emacs_settings_set_property, emacs_settings_class_init):
1263 (gsettings_client, gsettings_obj): New variables.
1264 (GSETTINGS_SCHEMA): New define.
1265 (something_changedCB): Call store_monospaced_changed.
1266 (init_gsettings): New function.
1267 (xsettings_initialize): Call init_gsettings.
1268 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1271 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1274 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1276 * window.c (resize_root_window, grow_mini_window)
1277 (shrink_mini_window): Rename Qresize_root_window to
1278 Qwindow_resize_root_window and Qresize_root_window_vertically to
1279 Qwindow_resize_root_window_vertically.
1281 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1283 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1285 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1287 * makefile.w32-in: Redesign dependencies so they reflect more
1288 clearly which files are directly included by each source file,
1289 and not through other includes.
1291 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1293 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1294 (sort_overlays, overlay_strings): When an overlay's clone number
1295 matches the window's clone number process the overlay even if
1296 the overlay's window property doesn't match the current window.
1298 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1299 (Fwindow_hchild): Rename to Fwindow_left_child.
1300 (Fwindow_next): Rename to Fwindow_next_sibling.
1301 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1302 (resize_window_check): Rename to window_resize_check.
1303 (resize_window_apply): Rename to window_resize_apply.
1304 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1305 (Fdelete_other_windows_internal, resize_frame_windows)
1306 (Fsplit_window_internal, Fdelete_window_internal)
1307 (grow_mini_window, shrink_mini_window)
1308 (Fresize_mini_window_internal): Fix callers accordingly.
1310 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1312 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1313 (emacs_fixed_set_min_size): Remove.
1314 (emacs_fixed_new): Take frame as argument.
1316 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1317 (_EmacsFixedPrivate): Remove minwidth/height.
1318 Add struct frame *f.
1319 (emacs_fixed_init): Initialize priv->f.
1320 (get_parent_class, emacs_fixed_set_min_size): Remove.
1321 (emacs_fixed_new): Set priv->f to argument.
1322 (emacs_fixed_get_preferred_width)
1323 (emacs_fixed_get_preferred_height): Use min_width/height from
1324 frames size_hint to set minimum and natural (Bug#8919).
1325 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1326 and use min_width/height from frames size_hint to set
1327 min_width/height (Bug#8919).
1329 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1330 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1333 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1335 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1336 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1339 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1341 * process.c (wait_reading_process_output): Bypass select if
1342 waiting for a cell while ignoring keyboard input, and input is
1343 pending. Suggested by Jan Djärv (Bug#8869).
1345 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1347 Use gnulib's dup2 module instead of rolling our own.
1348 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1350 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1352 * dispnew.c (scrolling_window): Before scrolling, turn off a
1353 mouse-highlight in the window being scrolled.
1355 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1357 Move DEFSYM to lisp.h and use everywhere.
1359 * character.h (DEFSYM): Move declaration...
1360 * lisp.h (DEFSYM): ...here.
1366 * w32select.c: Don't include character.h.
1368 * alloc.c (syms_of_alloc):
1369 * buffer.c (syms_of_buffer):
1370 * bytecode.c (syms_of_bytecode):
1371 * callint.c (syms_of_callint):
1372 * casefiddle.c (syms_of_casefiddle):
1373 * casetab.c (init_casetab_once):
1374 * category.c (init_category_once, syms_of_category):
1375 * ccl.c (syms_of_ccl):
1376 * cmds.c (syms_of_cmds):
1377 * composite.c (syms_of_composite):
1378 * dbusbind.c (syms_of_dbusbind):
1379 * dired.c (syms_of_dired):
1380 * dispnew.c (syms_of_display):
1381 * doc.c (syms_of_doc):
1382 * editfns.c (syms_of_editfns):
1383 * emacs.c (syms_of_emacs):
1384 * eval.c (syms_of_eval):
1385 * fileio.c (syms_of_fileio):
1386 * fns.c (syms_of_fns):
1387 * frame.c (syms_of_frame):
1388 * fringe.c (syms_of_fringe):
1389 * insdel.c (syms_of_insdel):
1390 * keymap.c (syms_of_keymap):
1391 * lread.c (init_obarray, syms_of_lread):
1392 * macros.c (syms_of_macros):
1393 * msdos.c (syms_of_msdos):
1394 * print.c (syms_of_print):
1395 * process.c (syms_of_process):
1396 * search.c (syms_of_search):
1397 * sound.c (syms_of_sound):
1398 * syntax.c (init_syntax_once, syms_of_syntax):
1399 * terminal.c (syms_of_terminal):
1400 * textprop.c (syms_of_textprop):
1401 * undo.c (syms_of_undo):
1402 * w32.c (globals_of_w32):
1403 * window.c (syms_of_window):
1404 * xdisp.c (syms_of_xdisp):
1405 * xfaces.c (syms_of_xfaces):
1406 * xfns.c (syms_of_xfns):
1407 * xmenu.c (syms_of_xmenu):
1408 * xsettings.c (syms_of_xsettings):
1409 * xterm.c (syms_of_xterm): Use DEFSYM.
1411 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1413 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1415 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1417 Integer and buffer overflow fixes (Bug#8873).
1419 * print.c (printchar, strout): Check for string overflow.
1420 (PRINTPREPARE, printchar, strout):
1421 Don't set size unless allocation succeeds.
1423 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1424 for sizes. Check for string overflow more accurately.
1425 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1427 * macros.c: Integer and buffer overflow fixes.
1428 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1429 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1430 Use ptrdiff_t, not int, for sizes.
1431 Don't increment bufsize until after realloc succeeds.
1432 Check for size-calculation overflow.
1433 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1435 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1437 * lread.c: Integer overflow fixes.
1438 (read_integer): Radix is now EMACS_INT, not int,
1439 to improve quality of diagnostics for out-of-range radices.
1440 Calculate buffer size correctly for out-of-range radices.
1441 (read1): Check for integer overflow in radices, and in
1442 read-circle numbers.
1443 (read_escape): Avoid int overflow.
1444 (Fload, openp, read_buffer_size, read1)
1445 (substitute_object_recurse, read_vector, read_list, map_obarray):
1446 Use ptrdiff_t, not int, for sizes.
1447 (read1): Use EMACS_INT, not int, for sizes.
1448 Check for size overflow.
1450 * image.c (cache_image): Check for size arithmetic overflow.
1452 * lread.c: Integer overflow issues.
1453 (saved_doc_string_size, saved_doc_string_length)
1454 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1455 Now ptrdiff_t, not int.
1456 (read1): Don't assume doc string length fits in int. Check for
1457 out-of-range doc string lengths.
1458 (read_list): Don't assume file position fits in int.
1459 (read_escape): Check for hex character overflow.
1461 2011-06-22 Leo Liu <sdl.web@gmail.com>
1463 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1464 Move to minibuffer.el.
1466 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1468 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1469 The following patches are for when GLYPH_DEBUG && !XASSERT.
1470 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1471 * dispnew.c (flush_stdout):
1472 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1473 Mark as externally visible.
1474 * dispnew.c (check_window_matrix_pointers): Now static.
1475 * dispnew.c (window_to_frame_vpos):
1476 * xfns.c (unwind_create_frame):
1477 * xterm.c (x_check_font): Remove unused local.
1478 * scroll.c (CHECK_BOUNDS):
1479 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1480 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1481 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1482 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1483 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1485 (debug_method_add): Use va_list and vsprintf rather than relying
1486 on undefined behavior with wrong number of arguments.
1487 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1488 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1489 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1490 since we're not interested in debugging glyphs with old libraries.
1491 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1492 GCC 4.6.0's static checking.
1494 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1496 Integer overflow and signedness fixes (Bug#8873).
1497 A few related buffer overrun fixes, too.
1499 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1501 * dispextern.h (struct face.stipple):
1502 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1503 (x_bitmap_mask, x_allocate_bitmap_record)
1504 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1505 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1506 (x_create_bitmap_from_xpm_data):
1507 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1508 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1510 * xfaces.c (load_pixmap):
1511 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1512 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1513 (.bitmaps_last, struct x_output.icon_bitmap):
1514 Use ptrdiff_t, not int, for bitmap indexes.
1515 (x_allocate_bitmap_record): Check for size overflow.
1516 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1518 Use ptrdiff_t, not int, for overlay counts.
1519 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1520 * editfns.c (overlays_around, get_pos_property):
1521 * textprop.c (get_char_property_and_overlay):
1522 * xdisp.c (next_overlay_change, note_mouse_highlight):
1523 * xfaces.c (face_at_buffer_position):
1524 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1525 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1526 (Fnext_overlay_change, Fprevious_overlay_change)
1527 (mouse_face_overlay_overlaps, Foverlays_in):
1528 Use ptrdiff_t, not int, for sizes.
1529 (overlays_at, overlays_in): Check for size-calculation overflow.
1531 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1533 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1534 (x_session_initialize): Do not assume string length fits in int.
1536 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1537 This is unlikely, but can occur if DPI is outlandish.
1539 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1540 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1542 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1543 * xrdb.c (magic_file_p, search_magic_path):
1544 Omit last arg SUFFIX; it was always 0. All callers changed.
1545 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1547 * xfont.c (xfont_match): Avoid need for strlen.
1549 * xfns.c: Don't assume strlen fits in int.
1550 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1552 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1553 not unsigned long, as we prefer signed integers. All callers changed.
1554 Detect integer overflow in repeat count.
1555 (message_dolog): Don't assume print length fits in 39 bytes.
1556 (display_mode_element): Don't assume strlen fits in int.
1558 * termcap.c: Don't assume sizes fit in int and never overflow.
1559 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1560 (gobble_line): Check for size-calculation overflow.
1562 * minibuf.c (Fread_buffer):
1563 * lread.c (intern, intern_c_string):
1564 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1565 Don't assume string length fits in int.
1567 * keyboard.c (parse_tool_bar_item):
1568 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1570 * font.c: Don't assume string length fits in int.
1571 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1572 Use ptrdiff_t, not int.
1573 (font_intern_prop): Don't assume string length fits in int.
1574 Don't assume integer property fits in fixnum.
1575 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1577 * filelock.c: Fix some buffer overrun and integer overflow issues.
1578 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1579 Reformulate so as not to need the command string.
1580 Invoke gzip -cd rather than gunzip, as it's more portable.
1581 (lock_info_type, lock_file_1, lock_file):
1582 Don't assume pid_t and time_t fit in unsigned long.
1583 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1584 (current_lock_owner): Prefer signed type for sizes.
1585 Use memcpy, not strncpy, where memcpy is what is really wanted.
1586 Don't assume (via atoi) that time_t and pid_t fit in int.
1587 Check for time_t and/or pid_t out of range, e.g., via a network share.
1588 Don't alloca where an auto var works fine.
1590 * fileio.c: Fix some integer overflow issues.
1591 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1592 Don't assume string length fits in int.
1593 (directory_file_name): Don't assume string length fits in long.
1594 (make_temp_name): Don't assume pid fits in int, or that its print
1595 length is less than 20.
1597 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1599 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1601 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1603 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1604 We prefer signed integers, even for size calculations.
1606 * emacs.c: Don't assume string length fits in 'int'.
1607 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1608 (main): Don't invoke strlen when not needed.
1610 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1611 (XD_DEBUG_MESSAGE): Don't waste a byte.
1613 * callproc.c (getenv_internal_1, getenv_internal)
1615 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1617 * lread.c (invalid_syntax): Omit length argument.
1618 All uses changed. This doesn't fix a bug, but it simplifies the
1619 code away from its former Hollerith-constant appearance, and it's
1620 one less 'int' to worry about when looking at integer-overflow issues.
1621 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1623 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1624 This didn't break anything, but it didn't help either.
1625 It's confusing to put a bogus integer in a place where the actual
1626 value does not matter.
1627 (LIST_END_P): Remove unused macro and its bogus comment.
1628 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1630 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1631 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1633 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1634 We prefer signed types, and the value cannot exceed the EMACS_INT
1635 range anyway (because otherwise the length would not be representable).
1636 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1637 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1638 This avoids a GCC warning when WIDE_EMACS_INT.
1640 * indent.c (sane_tab_width): New function.
1641 (current_column, scan_for_column, Findent_to, position_indentation)
1642 (compute_motion): Use it. This is just for clarity.
1643 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1645 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1647 * lisp.h (lint_assume): New macro.
1648 * composite.c (composition_gstring_put_cache):
1649 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1651 * editfns.c, insdel.c:
1652 Omit unnecessary forward decls, to simplify future changes.
1654 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1656 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1658 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1659 Use much-faster test for byte-length change.
1660 Don't assume string byte-length fits in 'int'.
1661 Check that character arg fits in 'int'.
1662 (mapcar1): Declare byte as byte, for clarity.
1664 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1666 * fns.c (concat): Catch string overflow earlier.
1667 Do not rely on integer wraparound.
1669 * dispextern.h (struct it.overlay_strings_charpos)
1670 (struct it.selective): Now EMACS_INT, not int.
1671 * xdisp.c (forward_to_next_line_start)
1672 (back_to_previous_visible_line_start)
1673 (reseat_at_next_visible_line_start, next_element_from_buffer):
1674 Don't arbitrarily truncate the value of 'selective' to int.
1676 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1678 * composite.c: Don't truncate sizes to 'int'.
1679 (composition_gstring_p, composition_reseat_it)
1680 (composition_adjust_point): Use EMACS_INT, not int.
1681 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1682 not EMACS_UINT, for indexes.
1684 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1686 * buffer.c: Include <verify.h>.
1687 (struct sortvec.priority, struct sortstr.priority):
1688 Now EMACS_INT, not int.
1689 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1690 (struct sortstr.size, record_overlay_string)
1691 (struct sortstrlist.size, struct sortlist.used):
1692 Don't truncate size to int.
1693 (record_overlay_string): Check for size-calculation overflow.
1694 (init_buffer_once): Check at compile-time, not run-time.
1696 2011-06-22 Jim Meyering <meyering@redhat.com>
1698 Don't leak an XBM-image-sized buffer
1699 * image.c (xbm_load): Free the image buffer after using it.
1701 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1704 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1705 that Sun C diagnosed.
1706 * fns.c (secure_hash): Fix pointer signedness issue.
1707 * intervals.c (static_offset_intervals): New function.
1708 (offset_intervals): Use it.
1710 2011-06-21 Leo Liu <sdl.web@gmail.com>
1713 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1716 * fns.c (secure_hash): Rename from crypto_hash_function and change
1717 the first arg to accept symbols.
1718 (Fsecure_hash): New primitive.
1719 (syms_of_fns): New symbols.
1721 2011-06-20 Deniz Dogan <deniz@dogan.se>
1723 * process.c (Fset_process_buffer): Clarify return value in
1726 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1728 * dispnew.c (add_window_display_history): Use BVAR.
1730 * xdisp.c (debug_method_add): Use BVAR.
1731 (check_window_end, dump_glyph_matrix, dump_glyph)
1732 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1734 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1737 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1738 check till after the cache is created in init_frame_faces.
1740 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1742 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1744 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1746 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1747 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1748 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1750 Improve buffer-overflow checking (Bug#8873).
1751 * fileio.c (Finsert_file_contents):
1752 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1753 Remove the old (too-loose) buffer overflow checks.
1754 They weren't needed, since make_gap checks for buffer overflow.
1755 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1756 The old code merely checked for Emacs fixnum overflow, and relied
1757 on undefined (wraparound) behavior. The new code avoids undefined
1758 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1760 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1761 Tune. Don't use wider integers than needed. Don't use alloca.
1762 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1764 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1766 * insdel.c, lisp.h (buffer_overflow): New function.
1767 (insert_from_buffer_1, replace_range, replace_range_2):
1768 * insdel.c (make_gap_larger):
1769 * editfns.c (Finsert_char):
1770 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1772 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1774 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1776 Integer overflow and signedness fixes (Bug#8873).
1778 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1779 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1781 * fileio.c: Don't assume EMACS_INT fits in off_t.
1782 (emacs_lseek): New static function.
1783 (Finsert_file_contents, Fwrite_region): Use it.
1784 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1786 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1788 * fns.c: Don't overflow int when computing a list length.
1789 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1790 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1791 truncation on 64-bit hosts. Check for QUIT every
1792 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1793 faster and is responsive enough.
1794 (Flength): Report an error instead of overflowing an integer.
1795 (Fsafe_length): Return a float if the value is not representable
1796 as a fixnum. This shouldn't happen except in contrived situations.
1797 (Fnthcdr, Fsort): Don't assume list length fits in int.
1798 (Fcopy_sequence): Don't assume vector length fits in int.
1800 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1801 (header_size, word_size): New constants.
1802 (allocate_vectorlike): Don't check size overflow here.
1803 (allocate_vector): Check it here instead, since this is the only
1804 caller of allocate_vectorlike that could cause overflow.
1805 Check that the new vector's length is representable as a fixnum.
1807 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1808 The previous code was bogus. For example, next_almost_prime (32)
1809 returned 39, which is undesirable as it is a multiple of 3; and
1810 next_almost_prime (24) returned 25, which is a multiple of 5 so
1811 why was the code bothering to check for multiples of 7?
1813 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1815 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1817 Variadic C functions now count arguments with ptrdiff_t.
1818 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1819 Back then I didn't know that the Emacs coding style prefers signed int.
1820 Also, in the meantime I found a few more instances where arguments
1821 were being counted with int, which may truncate counts on 64-bit
1822 machines, or EMACS_INT, which may be unnecessarily wide.
1823 * lisp.h (struct Lisp_Subr.function.aMANY)
1824 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1825 Arg counts are now ptrdiff_t, not size_t.
1826 All variadic functions and their callers changed accordingly.
1827 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1828 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1829 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1830 * callint.c (Fcall_interactively): Check arg count for overflow,
1831 to avoid potential buffer overrun. Use signed char, not 'int',
1832 for 'varies' array, so that we needn't bother to check its size
1833 calculation for overflow.
1834 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1835 * eval.c (apply_lambda):
1836 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1837 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1838 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1840 * callint.c (Fcall_interactively): Don't use index var as event count.
1842 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1843 * mem-limits.h (SIZE): Remove; no longer used.
1845 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1847 Remove unnecessary casts.
1848 * xterm.c (x_term_init):
1849 * xfns.c (x_set_border_pixel):
1850 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1851 These aren't needed now that we assume ANSI C.
1853 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1854 It's more likely to cause problems (due to unsigned overflow)
1857 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1859 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1861 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1863 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1865 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1867 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1869 GLYPH_CODE_FACE returns EMACS_INT, not int.
1870 * dispextern.h (merge_faces):
1871 * xfaces.c (merge_faces):
1872 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1873 Don't assume EMACS_INT fits in int.
1875 * character.h (CHAR_VALID_P): Remove unused parameter.
1876 * fontset.c, lisp.h, xdisp.c: All uses changed.
1878 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1880 * fns.c (concat): Minor tuning based on overflow analysis.
1881 This doesn't fix any bugs. Use int to hold character, instead
1882 of constantly refetching from Emacs object. Use XFASTINT, not
1883 XINT, for value known to be a character. Don't bother comparing
1884 a single byte to 0400, as it's always less.
1886 * floatfns.c (Fexpt):
1887 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1889 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1892 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1894 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1895 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1896 incorrectly succeed when S was a string, because 4294967386 was
1897 truncated before it was used.
1899 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1900 Otherwise, an out-of-range integer could cause undefined behavior
1903 * composite.c: Use int, not EMACS_INT, for characters.
1904 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1905 EMACS_INT, for values that are known to be in character range.
1906 This doesn't fix any bugs but is the usual style inside Emacs and
1907 may generate better code on 32-bit machines.
1909 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1910 This is for reasons similar to the recent CHAR_STRING fix.
1911 * charset.c (Fencode_char): Check that character arg is actually
1912 a character. Pass an int to ENCODE_CHAR.
1913 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1914 wider than 'int', as a compile-time check to prevent future regressions
1917 * character.c (char_string): Remove unnecessary casts.
1919 Make sure a 64-bit char is never passed to CHAR_STRING.
1920 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1921 by silently ignoring the top 32 bits, allowing some values
1922 that were far too large to be valid characters.
1923 * character.h: Include <verify.h>.
1924 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1925 arguments are no wider than unsigned, as a compile-time check
1926 to prevent future regressions in this area.
1928 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1929 (Fsubst_char_in_region):
1931 * xdisp.c (decode_mode_spec_coding):
1932 Adjust to CHAR_STRING's new requirement.
1933 * editfns.c (Finsert_char, Fsubst_char_in_region):
1934 * fns.c (concat): Check that character args are actually
1935 characters. Without this test, these functions did the wrong
1936 thing with wildly out-of-range values on 64-bit hosts.
1938 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1939 These casts should not be needed on 32-bit hosts, either.
1940 * keyboard.c (read_char):
1941 * lread.c (Fload): Remove casts to unsigned.
1943 * lisp.h (UNSIGNED_CMP): New macro.
1944 This fixes comparison bugs on 64-bit hosts.
1945 (ASCII_CHAR_P): Use it.
1946 * casefiddle.c (casify_object):
1947 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1948 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1949 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1950 * dispextern.h (FACE_FROM_ID):
1951 * keyboard.c (read_char): Use UNSIGNED_CMP.
1953 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1954 not to EMACS_INT, to avoid GCC warning.
1956 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1958 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1959 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1960 isn't needed on 32-bit machines.
1962 * buffer.c (Fgenerate_new_buffer_name):
1963 Use EMACS_INT for count, not int.
1964 (advance_to_char_boundary): Return EMACS_INT, not int.
1966 * data.c (Qcompiled_function): Now static.
1968 * window.c (window_body_lines): Now static.
1970 * image.c (gif_load): Rename local to avoid shadowing.
1972 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1973 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1974 * alloc.c (make_save_value): Integer argument is now of type
1976 (mark_object): Use ptrdiff_t, not int.
1977 * lisp.h (pD): New macro.
1978 * print.c (print_object): Use it.
1980 * alloc.c: Use EMACS_INT, not int, to count objects.
1981 (total_conses, total_markers, total_symbols, total_vector_size)
1982 (total_free_conses, total_free_markers, total_free_symbols)
1983 (total_free_floats, total_floats, total_free_intervals)
1984 (total_intervals, total_strings, total_free_strings):
1985 Now EMACS_INT, not int. All uses changed.
1986 (Fgarbage_collect): Compute overall total using a double, so that
1987 integer overflow is less likely to be a problem. Check for overflow
1988 when converting back to an integer.
1989 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1990 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1991 These were 'int' variables that could overflow on 64-bit hosts;
1992 they were never used, so remove them instead of repairing them.
1993 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1994 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1995 Previously, this ceilinged at INT_MAX, but that doesn't work on
1997 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1999 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2000 (allocate_vectorlike): Check for ptrdiff_t overflow.
2001 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2002 when a (possibly-narrower) signed value would do just as well.
2003 We prefer using signed arithmetic, to avoid comparison confusion.
2005 * alloc.c: Catch some string size overflows that we were missing.
2006 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2007 for convenience in STRING_BYTES_MAX.
2008 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2009 The definition here is exact; the one in lisp.h was approximate.
2010 (allocate_string_data): Check for string overflow. This catches
2011 some instances we weren't catching before. Also, it catches
2012 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2013 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2014 and ptrdiff_t and EMACS_INT are both 64 bits.
2016 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2017 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2018 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
2020 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2022 * alloc.c (Fmake_string): Check for out-of-range init.
2024 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2026 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2028 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2030 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2031 xg_get_default_scrollbar_width.
2033 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2034 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2035 (style_changed_cb): Call update_theme_scrollbar_width and call
2036 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2037 all frames (Bug#8505).
2038 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2039 Call gtk_window_set_resizable if HAVE_GTK3.
2040 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2041 and height if HAVE_GTK3 (Bug#8505).
2042 (scroll_bar_width_for_theme): New variable.
2043 (update_theme_scrollbar_width): New function.
2044 (xg_get_default_scrollbar_width): Move code to
2045 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2046 (xg_initialize): Call update_theme_scrollbar_width.
2048 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2050 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2052 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2054 * frame.c (make_frame): Call other_buffer_safely instead of
2057 * window.c (temp_output_buffer_show): Call display_buffer with
2058 second argument Vtemp_buffer_show_specifiers and reset latter
2059 immediately after the call.
2060 (Vtemp_buffer_show_specifiers): New variable.
2061 (auto_window_vscroll_p, next_screen_context_lines)
2062 (Vscroll_preserve_screen_position): Remove leading asterisks from
2065 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2067 Fix minor problems found by GCC 4.6.0 static checking.
2068 * buffer.c (Qclone_number): Remove for now, as it's unused.
2069 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2070 (record_buffer): Remove unused local.
2071 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2072 (set_frame_buffer_list): Remove; unused.
2073 * frame.h (other_visible_frames): Remove decl.
2074 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2075 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2076 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2078 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2079 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2080 Define only if HAVE_GPM.
2081 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2082 (update_hints_inhibit): Remove; never set. All uses removed.
2083 * widgetprv.h (emacsFrameClassRec): Remove decl.
2084 * window.c (delete_deletable_window): Now returns void, since it
2085 wasn't returning anything.
2086 (compare_window_configurations): Remove unused locals.
2087 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2088 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2089 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2090 the same widths as pointers. This follows up on the 2011-05-06 patch.
2091 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2092 * xterm.h: Likewise.
2093 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2095 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2097 * makefile.w32-in: Update dependencies.
2098 (LISP_H): Add lib/intprops.h.
2100 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2102 * image.c (gif_load): Add animation frame delay to the metadata.
2103 (syms_of_image): Use DEFSYM. New symbol `delay'.
2105 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2107 * window.c (delete_deletable_window): Re-add.
2108 (Fset_window_configuration): Rewrite to handle dead buffers and
2109 consequently deletable windows.
2110 (window_tree, Fwindow_tree): Remove. Supply functionality in
2112 (compare_window_configurations): Simplify code.
2114 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2116 * image.c (imagemagick_load_image): Fix type mismatch.
2117 (Fimagemagick_types): Likewise.
2119 * window.h (replace_buffer_in_windows): Declare.
2121 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2123 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2124 Qclone_number. Remove external declaration of Qdelete_window.
2125 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2127 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2128 Qbuffer_list_update_hook if allowed.
2129 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2130 buffer list implementation.
2131 (other_buffer_safely): New function.
2132 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2133 calls to replace_buffer_in_windows and
2134 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2136 (record_buffer): Inhibit quitting and rewrite using quittable
2137 functions. Run Qbuffer_list_update_hook if allowed.
2138 (Frecord_buffer, Funrecord_buffer): New functions.
2139 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2140 switch-to-buffer to window.el.
2141 (bury-buffer): Move to window.el.
2142 (Vbuffer_list_update_hook): New variable.
2144 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2147 * window.h (resize_frame_windows): Move up in code.
2148 (Fwindow_frame): Remove EXFUN.
2149 (replace_buffer_in_all_windows): Remove prototype.
2150 (replace_buffer_in_windows_safely): Add prototype.
2152 * window.c: Declare Qdelete_window static again. Move down
2153 declaration of select_count.
2154 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2155 (Fother_window): Move to window.el.
2156 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2157 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2158 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2160 (replace_buffer_in_windows): Implement by calling
2161 Qreplace_buffer_in_windows.
2162 (replace_buffer_in_all_windows): Remove with some functionality
2163 moved into replace_buffer_in_windows_safely.
2164 (replace_buffer_in_windows_safely): New function.
2165 (select_window_norecord, select_frame_norecord): Move in front
2166 of run_window_configuration_change_hook. Remove now obsolete
2168 (Fset_window_buffer): Rewrite doc-string. Call
2169 Qrecord_window_buffer.
2170 (keys_of_window): Move binding for other-window to window.el.
2172 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2174 * dispextern.h (struct image): Replace data member, whose int_val
2175 and ptr_val fields were not used by anything, with a single
2178 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2179 (gif_clear_image, gif_load, imagemagick_load_image)
2180 (gs_clear_image, gs_load): Callers changed.
2182 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2184 * buffer.h: Include <time.h>, for time_t.
2185 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2187 Fix minor problems found by static checking.
2189 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2191 Make identifiers static if they are not used in other modules.
2192 * data.c (Qcompiled_function, Qframe, Qvector):
2193 * image.c (QimageMagick, Qsvg):
2194 * minibuf.c (Qmetadata):
2195 * window.c (resize_window_check, resize_root_window): Now static.
2196 * window.h (resize_window_check, resize_root_window): Remove decls.
2198 * window.c (window_deletion_count, delete_deletable_window):
2200 (window_body_lines): Now static.
2201 (Fdelete_other_windows_internal): Mark vars as initialized.
2202 Make sure 'resize_failed' is initialized.
2203 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2204 (resize_window_apply): Remove unused local.
2205 * window.h (delete_deletable_window): Remove decl.
2207 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2208 (imagemagick_load_image): Fix pointer signedness problem by changing
2209 last arg from unsigned char * to char *. All uses changed.
2210 Also, fix a local for similar reasons.
2211 Remove unused locals. Remove locals to avoid shadowing.
2212 (fn_rsvg_handle_free): Remove; unused.
2213 (svg_load, svg_load_image): Fix pointer signedness problem.
2214 (imagemagick_load_image): Don't use garbage pointer image_wand.
2216 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2218 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2220 * image.c (gif_load): Fix omitted cast error introduced by
2223 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2225 * window.h (resize_proportionally, orig_total_lines)
2226 (orig_top_line): Remove from window structure.
2227 (set_window_height, set_window_width, change_window_heights)
2228 (Fdelete_window): Remove prototypes.
2229 (resize_frame_windows): Remove duplicate declaration.
2231 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2233 * window.h (resize_frame_windows, resize_window_check)
2234 (delete_deletable_window, resize_root_window)
2235 (resize_frame_windows): Declare prototypes.
2237 * window.c (resize_window_apply): Make definition be "static" to
2238 match the prototype.
2240 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2242 * window.c: Remove declarations of Qwindow_size_fixed,
2243 window_min_size_1, window_min_size_2, window_min_size,
2244 size_window, window_fixed_size_p, enlarge_window, delete_window.
2245 Remove static from declaration of Qdelete_window, it's
2246 temporarily needed by Fbury_buffer.
2247 (replace_window): Don't assign orig_top_line and
2249 (Fdelete_window, delete_window): Remove. Window deletion is
2250 handled by window.el.
2251 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2252 Fdelete_window calls with calls to Qdelete_window.
2253 (Fdelete_other_windows): Remove. Deleting other windows is
2254 handled by window.el.
2255 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2256 handled in window.el.
2257 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2258 Window minimum sizes are handled in window.el.
2259 (shrink_windows, size_window, set_window_height)
2260 (set_window_width, change_window_heights, window_height)
2261 (window_width, CURBEG, CURSIZE, enlarge_window)
2262 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2263 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2264 handled in window.el.
2265 (make_dummy_parent): Rename to make_parent_window and give it a
2266 second argument horflag.
2267 (make_window): Don't set resize_proportionally any more.
2268 (Fsplit_window): Remove. Windows are split in window.el.
2269 (save_restore_action, save_restore_orig_size)
2270 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2271 Resize mini windows in window.el.
2272 (grow_mini_window, shrink_mini_window): Implement by calling
2273 Qresize_root_window_vertically, resize_window_check and
2274 resize_window_apply.
2275 (saved_window, Fset_window_configuration, save_window_save): Do
2276 not handle orig_top_line, orig_total_lines, and
2277 resize_proportionally.
2278 (window_min_height, window_min_width): Move to window.el.
2279 (keys_of_window): Move bindings for delete-other-windows,
2280 split-window, delete-window and enlarge-window to window.el.
2282 * buffer.c: Temporarily extern Qdelete_window.
2283 (Fbury_buffer): Temporarily call Qdelete_window instead of
2284 Fdelete_window (Fbury_buffer will move to window.el soon).
2286 * frame.c (set_menu_bar_lines_1): Remove code handling
2287 orig_top_line and orig_total_lines.
2289 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2290 set_window_height but set heights directly.
2291 (change_frame_size_1): Use resize_frame_windows.
2293 * xdisp.c (init_xdisp): Don't use set_window_height but set
2296 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2297 resize_frame_windows instead of change_window_heights and run
2298 run_window_configuration_change_hook.
2300 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2301 instead of change_window_heights and run
2302 run_window_configuration_change_hook.
2304 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2306 * window.c (replace_window): Rename second argument REPLACEMENT to
2307 NEW. New third argument SETFLAG. Rewrite.
2308 (delete_window, make_dummy_parent): Call replace_window with
2310 (window_list_1): Move down in code.
2311 (run_window_configuration_change_hook): Move set_buffer part
2312 before select_frame_norecord part in order to unwind correctly.
2313 Rename count1 to count.
2314 (recombine_windows, delete_deletable_window, resize_root_window)
2315 (Fdelete_other_windows_internal)
2316 (Frun_window_configuration_change_hook, make_parent_window)
2317 (resize_window_check, resize_window_apply, Fresize_window_apply)
2318 (resize_frame_windows, Fsplit_window_internal)
2319 (Fdelete_window_internal, Fresize_mini_window_internal): New
2321 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2323 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2325 * window.h (window): Add some new members to window structure -
2326 normal_lines, normal_cols, new_total, new_normal, clone_number,
2327 splits, nest, prev_buffers, next_buffers.
2328 (WINDOW_TOTAL_SIZE): Move here from window.c.
2329 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2331 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2333 (make_dummy_parent): Set new members of windows structure.
2334 (make_window): Move down in code. Handle new members of window
2336 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2337 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2338 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2339 (Fset_window_prev_buffers, Fwindow_next_buffers)
2340 (Fset_window_next_buffers, Fset_window_clone_number): New
2342 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2343 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2345 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2346 Argument WINDOW can be now internal window too.
2347 (Fwindow_use_time): Move up in code.
2348 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2350 (Fset_window_configuration, saved_window)
2351 (Fcurrent_window_configuration, save_window_save): Handle new
2352 members of window structure.
2353 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2354 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2355 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2356 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2357 Qget_mru_window, Qresize_root_window,
2358 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2359 Qauto_buffer_name; staticpro them.
2361 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2363 * window.c (Fwindow_total_size, Fwindow_left_column)
2364 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2365 (Fwindow_list_1): New functions.
2366 (window_box_text_cols): Replace with window_body_cols.
2367 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2368 window_body_cols instead of window_box_text_cols.
2369 (delete_window, Fset_window_configuration): Call
2370 delete_all_subwindows with window as argument.
2371 (delete_all_subwindows): Take a window as argument and not a
2373 (window_loop): Remove handling of GET_LRU_WINDOW and
2375 (Fget_lru_window, Fget_largest_window): Move to window.el.
2377 * window.h: Extern window_body_cols instead of
2378 window_box_text_cols. delete_all_subwindows now takes a
2379 Lisp_Object as argument.
2381 * indent.c (compute_motion, Fcompute_motion): Use
2382 window_body_cols instead of window_box_text_cols.
2384 * frame.c (delete_frame): Call delete_all_subwindows with root
2387 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2389 * fns.c (Fputhash): Document return value.
2391 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2393 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2395 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2397 Cons<->int and similar integer overflow fixes (Bug#8794).
2399 Check for overflow when converting integer to cons and back.
2400 * charset.c (Fdefine_charset_internal, Fdecode_char):
2401 Use cons_to_unsigned to catch overflow.
2402 (Fencode_char): Use INTEGER_TO_CONS.
2403 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2404 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2405 * data.c (long_to_cons, cons_to_long): Remove.
2406 (cons_to_unsigned, cons_to_signed): New functions.
2407 These signal an error for invalid or out-of-range values.
2408 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2409 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2410 * font.c (Ffont_variation_glyphs):
2411 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2412 * lisp.h: Include <intprops.h>.
2413 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2414 (cons_to_signed, cons_to_unsigned): New decls.
2415 (long_to_cons, cons_to_long): Remove decls.
2416 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2417 (Fprimitive_undo): Use CONS_TO_INTEGER.
2418 * xfns.c (Fx_window_property): Likewise.
2419 * xselect.c: Include <limits.h>.
2420 (x_own_selection, selection_data_to_lisp_data):
2421 Use INTEGER_TO_CONS.
2422 (x_handle_selection_request, x_handle_selection_clear)
2423 (x_get_foreign_selection, Fx_disown_selection_internal)
2424 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2425 (lisp_data_to_selection_data): Use cons_to_unsigned.
2426 (x_fill_property_data): Use cons_to_signed.
2427 Report values out of range.
2429 Check for buffer and string overflow more precisely.
2430 * buffer.h (BUF_BYTES_MAX): New macro.
2431 * lisp.h (STRING_BYTES_MAX): New macro.
2432 * alloc.c (Fmake_string):
2433 * character.c (string_escape_byte8):
2434 * coding.c (coding_alloc_by_realloc):
2435 * doprnt.c (doprnt):
2436 * editfns.c (Fformat):
2438 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2439 since they may not be the same number.
2440 * editfns.c (Finsert_char):
2441 * fileio.c (Finsert_file_contents):
2442 Likewise for BUF_BYTES_MAX.
2444 * image.c: Use ptrdiff_t, not int, for sizes.
2445 (slurp_file): Switch from int to ptrdiff_t.
2447 (slurp_file): Check that file size fits in both size_t (for
2448 malloc) and ptrdiff_t (for sanity and safety).
2450 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2451 if b->modtime has its maximal value.
2453 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2455 Don't assume time_t can fit into int.
2456 * buffer.h (struct buffer.modtime): Now time_t, not int.
2457 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2458 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2460 Minor fixes for signed vs unsigned integers.
2461 * character.h (MAYBE_UNIFY_CHAR):
2462 * charset.c (maybe_unify_char):
2463 * keyboard.c (read_char, reorder_modifiers):
2464 XINT -> XFASTINT, since the integer must be nonnegative.
2465 * ftfont.c (ftfont_spec_pattern):
2466 * keymap.c (access_keymap, silly_event_symbol_error):
2467 XUINT -> XFASTINT, since the integer must be nonnegative.
2468 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2469 since it makes no difference and we prefer signed.
2470 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2471 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2474 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2476 * window.h (Fwindow_frame): Declare.
2478 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2480 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2481 (SPARE_MEMORY): Always define.
2482 (LARGE_REQUEST): Remove.
2483 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2485 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2487 * lisp.h: Move EXFUNS for Fframe_root_window,
2488 Fframe_first_window and Fset_frame_selected_window to window.h.
2490 * window.h: Move EXFUNS for Fframe_root_window,
2491 Fframe_first_window and Fset_frame_selected_window here from
2494 * frame.c (Fwindow_frame, Fframe_first_window)
2495 (Fframe_root_window, Fframe_selected_window)
2496 (Fset_frame_selected_window): Move to window.c.
2497 (Factive_minibuffer_window): Move to minibuf.c.
2498 (Fother_visible_frames_p): New function.
2500 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2502 * window.c (decode_window, decode_any_window): Move up in code.
2503 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2504 (inhibit_frame_unsplittable): Remove unused variable.
2505 (Fwindow_buffer): Move up and rewrite doc-string.
2506 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2507 (Fwindow_prev): New functions.
2508 (Fwindow_frame): Move here from frame.c. Accept any window as
2510 (Fframe_root_window, Fframe_first_window)
2511 (Fframe_selected_window): Move here from frame.c. Accept frame
2512 or arbitrary window as argument. Update doc-strings.
2513 (Fminibuffer_window): Move up in code.
2514 (Fwindow_minibuffer_p): Move up in code and simplify.
2515 (Fset_frame_selected_window): Move here from frame.c.
2517 (Fselected_window, select_window, Fselect_window): Move up in
2518 code. Minor doc-string fixes.
2520 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2522 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2523 Do not assume that spare memory exists; that assumption is valid
2524 only if SYSTEM_MALLOC.
2525 (LARGE_REQUEST): New macro, so that the issue of large requests
2526 is separated from the issue of spare memory.
2528 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2530 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2533 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2535 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2538 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2540 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2542 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2544 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2545 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2547 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2549 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2551 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2553 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2554 (x_clipboard_manager_save): Add return value.
2555 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2557 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2558 Obey Vx_select_enable_clipboard_manager. Catch errors in
2559 x_clipboard_manager_save (Bug#8779).
2560 (Vx_select_enable_clipboard_manager): New variable.
2561 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2563 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2565 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2567 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2569 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2570 in the current matrix if keep_current_p is non-zero.
2572 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2574 * bidi.c (bidi_level_of_next_char): Fix last change.
2576 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2578 Support bidi reordering of text covered by display properties.
2580 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2581 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2582 (bidi_cache_search, bidi_cache_iterator_state)
2583 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2584 (bidi_level_of_next_char, bidi_move_to_visually_next):
2585 Support character positions inside a run of characters covered by a
2587 (bidi_paragraph_init, bidi_resolve_explicit_1)
2588 (bidi_level_of_next_char): Call bidi_fetch_char and
2589 bidi_fetch_char_advance instead of FETCH_CHAR and
2591 (bidi_init_it): Initialize new members.
2592 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2594 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2595 instead of using explicit *_CHAR codes.
2596 (bidi_resolve_explicit, bidi_resolve_weak):
2597 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2598 bidirectional text is supported only in multibyte buffers.
2599 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2600 it to initialize the frame_window_p member of struct bidi_it.
2601 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2602 (bidi_resolve_explicit, bidi_resolve_weak)
2603 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2604 bidi_it->nchars is non-positive.
2605 (bidi_level_of_next_char): Don't try to lookup the cache for the
2606 next/previous character if nothing is cached there yet, or if we
2607 were just reseat()'ed to a new position.
2609 * xdisp.c (set_cursor_from_row): Set start and stop points
2610 according to the row's direction when priming the loop that looks
2611 for the glyph on which to display cursor.
2612 (single_display_spec_intangible_p): Function deleted.
2613 (display_prop_intangible_p): Reimplement to call
2614 handle_display_spec instead of single_display_spec_intangible_p.
2615 Accept 3 additional arguments needed by handle_display_spec.
2616 This fixes incorrect cursor motion across display property with complex
2617 values: lists, `(when COND...)' forms, etc.
2618 (single_display_spec_string_p): Support property values that are
2619 lists with the argument STRING its top-level element.
2620 (display_prop_string_p): Fix the condition for processing a
2621 property that is a list to be consistent with handle_display_spec.
2622 (handle_display_spec): New function, refactored from the
2623 last portion of handle_display_prop.
2624 (compute_display_string_pos): Accept additional argument
2625 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2626 value of a `display' property is a "replacing spec".
2627 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2628 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2629 the display property, but just return a value indicating whether
2630 the display property will replace the characters it covers.
2631 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2632 frame_window_p members of struct bidi_it.
2633 (compute_display_string_pos, compute_display_string_end):
2635 (push_it): Accept second argument POSITION, where pop_it should
2636 jump to continue iteration.
2637 (reseat_1): Initialize bidi_it.disp_pos.
2639 * keyboard.c (adjust_point_for_property): Adjust the call to
2640 display_prop_intangible_p to its new signature.
2642 * dispextern.h (struct bidi_it): New member frame_window_p.
2643 (bidi_init_it): Update prototypes.
2644 (display_prop_intangible_p): Update prototype.
2645 (compute_display_string_pos, compute_display_string_end):
2647 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2650 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2652 Malloc failure behavior now depends on size of allocation.
2653 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2654 * lisp.h: Change signatures accordingly.
2655 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2656 All callers changed. (Bug#8762)
2658 * gnutls.c: Use Emacs's memory allocators.
2659 Without this change, the gnutls library would invoke malloc etc.
2660 directly, which causes problems on non-SYNC_INPUT hosts, and which
2661 runs afoul of improving memory_full behavior. (Bug#8761)
2662 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2663 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2664 xfree instead of the default malloc, realloc, free.
2665 (Fgnutls_boot): No need to check for memory allocation failure,
2666 since xmalloc does that for us.
2668 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2669 * category.c (hash_get_category_set):
2670 * ccl.c (ccl_driver):
2671 * charset.c (Fdefine_charset_internal):
2672 * charset.h (struct charset.hash_index):
2673 * composite.c (get_composition_id, gstring_lookup_cache)
2674 (composition_gstring_put_cache):
2675 * composite.h (struct composition.hash_index):
2676 * dispextern.h (struct image.hash):
2677 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2678 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2679 (hashfn_equal, hashfn_user_defined, make_hash_table)
2680 (maybe_resize_hash_table, hash_lookup, hash_put)
2681 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2682 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2683 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2684 * image.c (make_image, search_image_cache, lookup_image)
2685 (xpm_put_color_table_h):
2686 * lisp.h (struct Lisp_Hash_Table):
2687 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2688 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2689 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2690 * alloc.c (allocate_vectorlike):
2691 Check for overflow in vector size calculations.
2692 * ccl.c (ccl_driver):
2693 Check for overflow when converting EMACS_INT to int.
2694 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2695 need to be updated by these changes.
2696 * fns.c (make_hash_table, maybe_resize_hash_table):
2697 Check for integer overflow with large hash tables.
2698 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2699 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2700 (SXHASH_REDUCE): New macro.
2701 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2702 Use it instead of discarding useful hash info with large hash values.
2703 (sxhash_float): New function.
2704 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2705 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2706 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2707 Rewrite to use FIXNUM_BITS, as this simplifies things.
2708 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2709 Adjust signatures to match updated version of code.
2710 (consing_since_gc): Now EMACS_INT, since a single hash table can
2711 use more than INT_MAX bytes.
2713 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2715 Make it possible to build with GCC-4.6+ -O2 -flto.
2717 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2719 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2721 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2722 Call minibuffer-inactive-mode.
2724 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2726 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2727 Update dependencies.
2729 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2731 * data.c (init_data): Remove code for UTS, this system is not
2734 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2736 Don't force ./temacs to start in terminal mode.
2738 * frame.c (make_initial_frame): Initialize faces in all cases, not
2739 only when CANNOT_DUMP is defined.
2740 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2742 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2744 * dispnew.c (add_window_display_history): Use const for the string
2745 pointer. Remove declaration, not needed.
2747 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2749 Use 'inline', not 'INLINE'.
2750 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2751 * alloc.c, fontset.c (INLINE): Remove.
2752 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2753 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2754 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2755 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2756 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2758 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2760 Make it possible to run ./temacs.
2762 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2763 syms_of_callproc does the same thing. Remove test for
2764 "initialized", do it in the caller.
2765 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2767 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2769 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2770 (read_minibuf): Use get_minibuffer.
2771 (syms_of_minibuf): Use DEFSYM.
2772 (Qmetadata): New var.
2773 * data.c (Qbuffer): Don't make it static.
2774 (syms_of_data): Use DEFSYM.
2776 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2778 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2779 (CCL_CODE_MIN): New macro.
2781 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2783 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2785 * eval.c (Qdebug): Now static.
2786 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2787 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2788 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2790 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2792 * image.c: Various fixes to ImageMagick code comments.
2793 (Fimagemagick_types): Doc fix.
2795 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2797 Minor fixes prompted by GCC 4.6.0 warnings.
2799 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2801 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2802 (x_clipboard_manager_save_all): Move extern decl to ...
2803 * xterm.h: ... here, so that it can be checked for consistency.
2805 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2807 * xselect.c (x_clipboard_manager_save_frame)
2808 (x_clipboard_manager_save_all): New functions.
2809 (Fx_clipboard_manager_save): Lisp function deleted.
2811 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2812 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2814 * xterm.h: Update prototype.
2816 2011-05-28 William Xu <william.xwl@gmail.com>
2818 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2821 2011-05-28 Jim Meyering <meyering@redhat.com>
2823 Avoid a sign-extension bug in crypto_hash_function.
2824 * fns.c (to_uchar): Define.
2825 (crypto_hash_function): Use it to convert some newly-signed
2826 variables to unsigned, to avoid sign-extension bugs. For example,
2827 without this change, (md5 "truc") would evaluate to
2828 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2829 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2830 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2832 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2834 Integer overflow fixes.
2836 * dbusbind.c: Serial number integer overflow fixes.
2837 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2838 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2839 to hold a serial number that is too large for a fixnum.
2840 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2841 Check for serial numbers out of range. Decode any serial number
2842 that was so large that it became a float. (Bug#8722)
2844 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2845 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2846 Use XFASTINT rather than XUINT when numbers are nonnegative.
2847 (xd_append_arg, Fdbus_method_return_internal):
2848 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2849 arguments, check that Lisp number is nonnegative, rather than
2850 silently wrapping negative numbers around. (Bug#8722)
2851 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2854 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2856 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2858 ccl: add integer overflow checks
2859 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2860 (IN_INT_RANGE): New macros.
2861 (ccl_driver): Use them to check for integer overflow when
2862 decoding a CCL program. Many of the new checks are whether XINT (x)
2863 fits in int; it doesn't always, on 64-bit hosts. The new version
2864 doesn't catch all possible integer overflows, but it's an
2865 improvement. (Bug#8719)
2867 * alloc.c (make_event_array): Use XINT, not XUINT.
2868 There's no need for unsigned here.
2870 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2871 This follows up to the 2011-05-06 change that substituted uintptr_t
2872 for EMACS_INT. This case wasn't caught back then.
2874 Rework Fformat to avoid integer overflow issues.
2875 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2876 now (part of C89). Include <verify.h>.
2877 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2878 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2879 (Fformat): Avoid the prepass trying to compute sizes; it was only
2880 approximate and thus did not catch overflow reliably. Instead, walk
2881 through the format just once, formatting and computing sizes as we go,
2882 checking for integer overflow at every step, and allocating a larger
2883 buffer as needed. Keep track separately whether the format is
2884 multibyte. Keep only the most-recently calculated precision, rather
2885 than them all. Record whether each argument has been converted to
2886 string. Use EMACS_INT, not int, for byte and char and arg counts.
2887 Support field widths and precisions larger than INT_MAX. Avoid
2888 sprintf's undefined behavior with conversion specifications such as %#d
2889 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2890 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2891 formatting out-of-range floating point numbers with int
2894 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2896 * data.c: Avoid integer truncation in expressions involving floats.
2897 * data.c: Include <intprops.h>.
2898 (arith_driver): When there's an integer overflow in an expression
2899 involving floating point, convert the integers to floating point
2900 so that the resulting value does not suffer from catastrophic
2901 integer truncation. For example, on a 64-bit host (* 4
2902 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2903 Do not rely on undefined behavior after integer overflow.
2905 merge count_size_as_multibyte, parse_str_to_multibyte
2906 * character.c, character.h (count_size_as_multibyte):
2907 Rename from parse_str_to_multibyte; all uses changed.
2908 Check for integer overflow.
2909 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2910 since it's now a duplicate of the other. This is more of
2911 a character than a buffer op, so better that it's in character.c.
2912 * fns.c, print.c: Adjust to above changes.
2914 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2916 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2918 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2920 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2921 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2922 (x_clipboard_manager_save): Now static.
2923 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2925 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2926 (crypto_hash_function): Now static.
2927 Fix pointer signedness problems. Avoid unnecessary initializations.
2929 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2931 * termhooks.h (Vselection_alist): Make it terminal-local.
2933 * terminal.c (create_terminal): Initialize it.
2935 * xselect.c: Support for clipboard managers.
2936 (Vselection_alist): Move to termhooks.h as terminal-local var.
2937 (LOCAL_SELECTION): New macro.
2938 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2939 (symbol_to_x_atom): Remove gratuitous arg.
2940 (x_handle_selection_request, lisp_data_to_selection_data)
2941 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2942 (x_own_selection, x_get_local_selection, x_convert_selection):
2943 New arg, specifying work frame. Use terminal-local Vselection_alist.
2944 (some_frame_on_display): Delete unused function.
2945 (Fx_own_selection_internal, Fx_get_selection_internal)
2946 (Fx_disown_selection_internal, Fx_selection_owner_p)
2947 (Fx_selection_exists_p): New optional frame arg.
2948 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2949 (x_handle_selection_clear): Don't treat other terminals with the
2950 same keyboard specially. Use the terminal-local Vselection_alist.
2951 (x_clear_frame_selections): Use Frun_hook_with_args.
2953 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2955 * xterm.h: Add support for those atoms.
2957 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2959 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2960 (converted_selections, conversion_fail_tag): New global variables.
2961 (x_selection_request_lisp_error): Free the above.
2962 (x_get_local_selection): Remove unnecessary code.
2963 (x_reply_selection_request): Args changed; handle arbitrary array
2964 of converted selections stored in converted_selections.
2965 Separate the XChangeProperty and SelectionNotify steps.
2966 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2967 (x_convert_selection): New function.
2968 (x_handle_selection_event): Simplify.
2969 (x_get_foreign_selection): Don't ignore incoming requests while
2970 waiting for an answer; this will fail when we implement
2971 SAVE_TARGETS, and seems unnecessary anyway.
2972 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2973 (Vx_sent_selection_functions): Doc fix.
2975 2011-05-26 Leo Liu <sdl.web@gmail.com>
2977 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2979 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2981 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2983 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2984 for fringe update if it has periodic bitmap.
2985 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2986 and fringe_bitmap_periodic_p.
2988 * fringe.c (get_fringe_bitmap_data): New function.
2989 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2990 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2991 row. Mark glyph row for fringe update if periodicity changed.
2993 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2994 for fringe update unless it has periodic bitmap.
2996 2011-05-25 Kenichi Handa <handa@m17n.org>
2998 * xdisp.c (get_next_display_element): Set correct it->face_id for
2999 a static composition.
3001 2011-05-24 Leo Liu <sdl.web@gmail.com>
3004 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3006 * fns.c (crypto_hash_function, Fsha1): New function.
3007 (Fmd5): Use crypto_hash_function.
3008 (syms_of_fns): Add Ssha1.
3010 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3012 * gnutls.c: Remove unused macros.
3013 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3014 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3015 Remove macros that are defined and never used.
3016 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3018 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3020 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3021 (Fx_get_selection_internal): Minor cleanup.
3022 (Fx_own_selection_internal): Rename arguments for consistency with
3025 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3027 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3029 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3031 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3033 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3035 * dispnew.c (scrolling_window): Don't exclude the case that the
3036 last enabled row in the desired matrix touches the bottom boundary.
3038 2011-05-21 Glenn Morris <rgm@gnu.org>
3040 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3041 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3042 and add some more files.
3044 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3046 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3047 report_file_error introduced by the change from 2011-05-07.
3049 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3051 * systime.h (Time): Define only if emacs is defined.
3052 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3053 where the include path doesn't have X11/X.h by default. See
3054 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3056 2011-05-20 Kenichi Handa <handa@m17n.org>
3058 * composite.c (find_automatic_composition): Fix previous change.
3060 2011-05-20 Glenn Morris <rgm@gnu.org>
3062 * lisp.mk: New file, split from Makefile.in.
3063 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3064 (shortlisp): Remove.
3065 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3067 2011-05-19 Glenn Morris <rgm@gnu.org>
3069 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3070 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3071 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3072 (lisp): Set the order to that of loadup.el.
3073 (shortlisp): Make it a copy of $lisp.
3074 (SOME_MACHINE_LISP): Remove.
3075 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3076 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3078 2011-05-18 Kenichi Handa <handa@m17n.org>
3080 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3081 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3082 (find_automatic_composition): Mostly rewrite for efficiency.
3084 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3086 * makefile.w32-in: Update dependencies.
3088 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3090 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3091 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3093 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3095 Fix some integer overflow issues, such as string length overflow.
3097 * insdel.c (count_size_as_multibyte): Check for string overflow.
3099 * character.c (lisp_string_width): Check for string overflow.
3100 Use EMACS_INT, not int, for string indexes and lengths; in
3101 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3102 the resulting string length overflows an EMACS_INT; instead,
3103 report a string overflow if no precision given. When checking for
3104 precision exhaustion, use a check that cannot possibly have
3105 integer overflow. (Bug#8675)
3106 * character.h (lisp_string_width): Adjust to new signature.
3108 * alloc.c (string_overflow): New function.
3109 (Fmake_string): Use it. This doesn't change behavior, but saves
3110 a few bytes and will simplify future changes.
3111 * character.c (string_escape_byte8): Likewise.
3112 * lisp.h (string_overflow): New decl.
3114 Fixups, following up to the user-interface timestamp change.
3115 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3116 for UI timestamps, instead of unsigned long.
3117 * msdos.c (mouse_get_pos): Likewise.
3118 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3119 * w32gui.h (Time): Define by including "systime.h" rather than by
3120 declaring it ourselves. (Bug#8664)
3122 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3123 * image.c (clear_image_cache): Likewise.
3125 * term.c (term_mouse_position): Don't assume time_t wraparound.
3127 Be more systematic about user-interface timestamps.
3128 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3129 and sometimes 'EMACS_UINT', to represent these timestamps.
3130 This change causes it to use 'Time' uniformly, as that's what X uses.
3131 This makes the code easier to follow, and makes it easier to catch
3132 integer overflow bugs such as Bug#8664.
3133 * frame.c (Fmouse_position, Fmouse_pixel_position):
3134 Use Time, not unsigned long, for user-interface timestamps.
3135 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3136 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3137 * keyboard.h (last_event_timestamp): Likewise.
3138 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3139 * menu.h (xmenu_show): Likewise.
3140 * term.c (term_mouse_position): Likewise.
3141 * termhooks.h (struct input_event.timestamp): Likewise.
3142 (struct terminal.mouse_position_hook): Likewise.
3143 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3144 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3145 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3146 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3148 * menu.h, termhooks.h: Include "systime.h", for Time.
3150 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3151 Don't assume that the difference between two unsigned long values
3152 can fit into an integer. At this point, we know button_down_time
3153 <= event->timestamp, so the difference must be nonnegative, so
3154 there's no need to cast the result if double-click-time is
3155 nonnegative, as it should be; check that it's nonnegative, just in
3156 case. This bug is triggered when events are more than 2**31 ms
3157 apart (about 25 days). (Bug#8664)
3159 * xselect.c (last_event_timestamp): Remove duplicate decl.
3160 (x_own_selection): Remove needless cast to unsigned long.
3162 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3163 that always fit in int. Use a sentinel instead of a counter, to
3164 avoid a temp and to allay GCC's concerns about possible int overflow.
3165 * frame.h (struct frame): Use int for menu_bar_items_used
3166 instead of EMACS_INT, since it always fits in int.
3168 * menu.c (grow_menu_items): Check for int overflow.
3170 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3172 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3173 Before, the code was not consistent. These values cannot exceed
3174 2**31 - 1 so there's no need to make them unsigned.
3175 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3176 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3177 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3179 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3181 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3182 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3183 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3184 presumably because the widths might not match.
3186 * window.c (size_window): Avoid needless test at loop start.
3188 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3190 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3192 2011-05-12 Drew Adams <drew.adams@oracle.com>
3194 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3196 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3198 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3199 `width' to `bar_area_x' and `bar_area_width', respectively.
3200 (x_scroll_run): Take account of fringe background extension.
3202 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3203 Rename local vars `left' and `width' to `bar_area_x' and
3204 `bar_area_width', respectively.
3205 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3206 background extension.
3208 2011-05-10 Jim Meyering <meyering@redhat.com>
3210 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3212 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3214 * image.c (Finit_image_library): Return t for built-in image types,
3215 like pbm and xbm. (Bug#8640)
3217 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3219 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3221 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3223 * w32console.c (Fset_screen_color): Doc fix.
3224 (Fget_screen_color): New function.
3225 (syms_of_ntterm): Defsubr it.
3227 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3228 unlink the temporary file if Fcall_process didn't create it in the
3230 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3231 child process will be redirected to a file specified with `:file'.
3232 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3233 cue to call_process_cleanup not to close that handle.
3235 2011-05-07 Ben Key <bkey76@gmail.com>
3237 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3238 one of two shell specific rules, either bootstrap-temacs-CMD or
3239 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3240 to the previous implementation of the bootstrap-temacs rule.
3241 The bootstrap-temacs-CMD rule is similar to the previous
3242 implementation of the bootstrap-temacs rule except that it
3243 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3246 These changes, along with some changes to nt/configure.bat,
3247 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3248 earlier fix to add support for --cflags and --ldflags options
3249 that include quotes so that it works whether make uses cmd or
3252 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3254 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3255 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3257 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3258 a string. Handle both cases.
3259 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3260 (Fdbus_register_method): Use Qinvalid_function.
3262 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3264 * makefile.w32-in: Update dependencies.
3265 (LISP_H): Add inttypes.h and stdin.h.
3266 (PROCESS_H): Add unistd.h.
3268 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3270 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3271 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3273 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3275 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3277 * term.c (vfatal): Remove stray call to va_end.
3278 It's not needed and the C Standard doesn't allow it here anyway.
3280 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3281 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3283 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3286 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3288 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3290 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3292 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3294 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3296 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3297 * charset.c (Fdefine_charset_internal): Don't initialize
3298 charset.code_space[15]. The value was garbage, on hosts with
3299 32-bit int (Bug#8600).
3301 * lread.c (read_integer): Be more consistent with string-to-number.
3302 Use string_to_number to do the actual conversion; this avoids
3303 rounding errors and fixes some other screwups. Without this fix,
3304 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3305 (digit_to_number): Move earlier, for benefit of read_integer.
3306 Return -1 if the digit is out of range for the base, -2 if it is
3307 not a digit in any supported base. (Bug#8602)
3309 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3311 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3312 to match comment at start of function. This also removes a
3313 GCC warning about overflow in a 32+64-bit port.
3315 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3317 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3318 Reported by Stefan Monnier in
3319 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3320 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3321 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3323 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3324 (EMACS_UINTPTR): Likewise, with uintptr_t.
3326 * lisp.h: Prefer 64-bit EMACS_INT if available.
3327 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3328 on 32-bit hosts that have 64-bit int, so that they can access
3330 However, temporarily disable this change unless the temporary
3331 symbol WIDE_EMACS_INT is defined.
3333 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3335 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3336 This removes an assumption that EMACS_INT and long are the same
3337 width as pointers. The assumption is true for Emacs porting targets
3338 now, but we want to make other targets possible.
3339 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3340 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3341 In the rest of the code, change types of integers that hold casted
3342 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3343 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3344 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3345 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3346 No need to cast type when ORing.
3347 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3348 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3349 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3350 assume EMACS_INT is the same width as char *.
3351 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3352 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3353 Remove no-longer-needed casts.
3354 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3355 (xg_tool_bar_help_callback, xg_make_tool_item):
3356 Use EMACS_INTPTR to hold an integer
3357 that will be cast to void *; this can avoid a GCC warning
3358 if EMACS_INT is not the same width as void *.
3359 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3360 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3361 (current_message_1, set_message_1):
3362 Use a local to convert to proper width without a cast.
3363 * xmenu.c (dialog_selection_callback): Likewise.
3365 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3366 Also, don't assume VALBITS / RAND_BITS is less than 5,
3367 and don't rely on undefined behavior when shifting a 1 left into
3369 * lisp.h (get_random): Change signature to match.
3371 * lread.c (hash_string): Use size_t, not int, for hash computation.
3372 Normally we prefer signed values; but hashing is special, because
3373 it's better to use unsigned division on hash table sizes so that
3374 the remainder is nonnegative. Also, size_t is the natural width
3375 for hashing into memory. The previous code used 'int', which doesn't
3376 retain enough info to hash well into very large tables.
3377 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3379 * dbusbind.c: Don't possibly lose pointer info when converting.
3380 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3381 Use XPNTR rather than XHASH, so that the high-order bits of
3382 the pointer aren't lost when converting through void *.
3384 * eval.c (Fautoload): Don't double-shift a pointer.
3386 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3388 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3390 * gnutls.c (DEF_GNUTLS_FN):
3391 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3393 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3395 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3398 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3400 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3401 New version that can reserve upto 2GB of heap space.
3403 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3405 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3407 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3409 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3410 `gnutls_certificate_set_x509_key_file'.
3412 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3414 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3415 Update dependencies.
3417 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3419 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3420 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3421 Remove unused parameter `fildes'.
3422 * process.c (read_process_output, send_process): Don't pass it.
3424 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3426 Fix previous change: the library cache is defined in w32.c.
3427 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3428 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3430 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3432 Implement dynamic loading of GnuTLS on Windows.
3434 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3435 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3436 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3439 * gnutls.c (Qgnutls_dll): Define.
3440 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3441 (gnutls_*): Declare function pointers.
3442 (init_gnutls_functions): New function to initialize function pointers.
3443 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3444 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3445 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3446 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3447 (emacs_gnutls_write, emacs_gnutls_read)
3448 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3449 (Fgnutls_available_p): New function.
3450 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3451 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3452 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3454 * image.c: Include w32.h.
3455 (Vimage_type_cache): Delete.
3456 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3457 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3458 (w32_delayed_load): Move to w32.c.
3460 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3462 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3463 (w32_delayed_load): Move from image.c. When loading a library, record
3464 its filename in the :loaded-from property of the library id.
3465 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3466 Initialize and staticpro them.
3467 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3469 * process.c: Include lisp.h before w32.h, not after.
3470 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3471 instead of gnutls_record_check_pending.
3473 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3475 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3477 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3478 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3481 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3483 * xterm.c (x_set_frame_alpha): Do not set property on anything
3484 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3486 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3488 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3490 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3492 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3493 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3494 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3495 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3496 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3497 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3498 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3499 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3500 (Qgnutls_bootprop_callbacks_verify): Make static.
3502 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3504 * callproc.c: Indentation fixup.
3506 * sysdep.c (wait_for_termination_1): Make static.
3507 (wait_for_termination, interruptible_wait_for_termination):
3508 Move after wait_for_termination_1.
3510 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3512 * sysdep.c (interruptible_wait_for_termination): New function
3513 which is like wait_for_termination, but allows keyboard
3516 * callproc.c (Fcall_process): Add (:file "file") as an option for
3518 (Fcall_process_region): Ditto.
3520 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3522 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3523 rather than `XVECTOR (FOO)->size'.
3525 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3526 inttypes.h, as a gnulib replacement is used if it not available in
3529 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3531 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3532 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3533 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3535 * coding.c (coding_alloc_by_realloc): Error out if destination
3536 will grow beyond MOST_POSITIVE_FIXNUM.
3537 (decode_coding_emacs_mule): Abort if there isn't enough place in
3538 charbuf for the composition carryover bytes. Reserve an extra
3539 space for up to 2 characters produced in a loop.
3540 (decode_coding_iso_2022): Abort if there isn't enough place in
3541 charbuf for the composition carryover bytes.
3543 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3545 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3546 aborting when %lld or %lll format is passed.
3547 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3548 %llo or %llx format is passed. (Bug#8545)
3550 * window.c (window_scroll_line_based): Use a marker instead of
3551 simple variables to record original value of point. (Bug#7952)
3553 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3554 produced by %s or %c overflows available buffer space. (Bug#8545)
3556 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3558 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3559 (SIZE_MAX): Move defn after all includes, as they might #define it.
3561 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3563 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3565 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3567 * keyboard.c (Qdelayed_warnings_hook): Define.
3568 (command_loop_1): Run `delayed-warnings-hook'
3569 if Vdelayed_warnings_list is non-nil.
3570 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3571 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3573 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3575 * doprnt.c (doprnt): Don't return value smaller than the buffer
3576 size if the message was truncated. (Bug#8545).
3578 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3580 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3581 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3583 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3585 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3587 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3589 * makefile.w32-in: Update dependencies.
3591 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3593 Improve `doprnt' and its usage. (Bug#8545)
3594 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3595 `format_end'. Remove support for %l as a conversion specifier.
3596 Don't use xrealloc. Improve diagnostics when the %l size modifier
3597 is used. Update the commentary.
3599 * eval.c (verror): Simplify calculation of size_t.
3601 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3604 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3606 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3609 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3611 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3612 This makes this file independent of the recent pseudovector change.
3614 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3616 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3618 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3619 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3620 Remove unused local.
3621 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3623 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3624 GCC 4.6.0 optimizes based on type-based alias analysis.
3625 For example, if b is of type struct buffer * and v of type struct
3626 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3627 != &v->size, and therefore "v->size = 1; b->size = 2; return
3628 v->size;" must therefore return 1. This assumption is incorrect
3629 for Emacs, since it type-puns struct Lisp_Vector * with many other
3630 types. To fix this problem, this patch adds a new type struct
3631 vectorlike_header that documents the constraints on layout of vectors
3632 and pseudovectors, and helps optimizing compilers not get fooled
3633 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3634 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3635 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3637 (XSETPVECTYPE): Rewrite in terms of new macro.
3638 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3639 This is a bit clearer, and further avoids the possibility of
3640 undesirable aliasing.
3641 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3642 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3643 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3644 since Lisp_Subr is a special case (no "next" field).
3645 (ASIZE): Now uses header.size rather than size.
3646 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3647 to avoid the hassle of writing XVECTOR (foo)->header.size.
3648 (struct vectorlike_header): New type.
3649 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3650 object, to help avoid aliasing.
3651 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3652 (SUBRP): Likewise, since Lisp_Subr is a special case.
3653 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3654 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3655 (struct Lisp_Hash_Table): Combine first two members into a single
3656 struct vectorlike_header member. All uses of "size" and "next" members
3657 changed to be "header.size" and "header.next".
3658 * buffer.h (struct buffer): Likewise.
3659 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3660 * frame.h (struct frame): Likewise.
3661 * process.h (struct Lisp_Process): Likewise.
3662 * termhooks.h (struct terminal): Likewise.
3663 * window.c (struct save_window_data, struct saved_window): Likewise.
3664 * window.h (struct window): Likewise.
3665 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3666 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3667 * buffer.c (init_buffer_once): Likewise.
3668 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3670 * process.c (Fformat_network_address): Use local var for size,
3673 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3675 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3676 * data.c (atof): Remove decl; no longer used or needed.
3677 (digit_to_number): Move to lread.c.
3678 (Fstring_to_number): Use new string_to_number function, to be
3679 consistent with how the Lisp reader treats infinities and NaNs.
3680 Do not assume that floating-point numbers represent EMACS_INT
3681 without losing information; this is not true on most 64-bit hosts.
3682 Avoid double-rounding errors, by insisting on integers when
3683 parsing non-base-10 numbers, as the documentation specifies.
3684 * lisp.h (string_to_number): New decl, replacing ...
3685 (isfloat_string): Remove.
3686 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3687 (read1): Do not accept +. and -. as integers; this
3688 appears to have been a coding error. Similarly, do not accept
3689 strings like +-1e0 as floating point numbers. Do not report
3690 overflow for integer overflows unless the base is not 10 which
3691 means we have no simple and reliable way to continue.
3692 Break out the floating-point parsing into a new
3693 function string_to_number, so that Fstring_to_number parses
3694 floating point numbers consistently with the Lisp reader.
3695 (digit_to_number): Move here from data.c. Make it static inline.
3696 (E_CHAR, EXP_INT): Remove, replacing with ...
3697 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3698 (string_to_number): New function, replacing isfloat_string.
3699 This function checks for valid syntax and produces the resulting
3700 Lisp float number too. Rework it so that string-to-number
3701 no longer mishandles examples like "1.0e+". Use strtoumax,
3702 so that overflow for non-base-10 numbers is reported only when
3703 there's no portable and simple way to convert to floating point.
3705 * textprop.c (set_text_properties_1): Rewrite for clarity,
3706 and to avoid GCC warning about integer overflow.
3708 * intervals.h (struct interval): Use EMACS_INT for members
3709 where EMACS_UINT might cause problems. See
3710 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3711 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3712 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3714 (offset_intervals): Tell GCC not to worry about length overflow
3715 when negating a negative length.
3717 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3718 (overrun_check_free): Likewise.
3720 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3721 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3724 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3725 (gnutls_make_error): Rename local to avoid shadowing.
3726 (gnutls_emacs_global_deinit): ifdef out; not used.
3727 (Fgnutls_boot): Use const for pointer to readonly storage.
3728 Comment out unused local. Fix pointer signedness problems.
3730 * lread.c (openp): Don't stuff size_t into an 'int'.
3731 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3732 about possible signed overflow.
3734 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3735 (GDK_KEY_g): Don't define if already defined.
3736 (xg_prepare_tooltip): Avoid pointer signedness problem.
3737 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3739 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3740 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3742 * xfns.c (Fx_window_property): Simplify a bit,
3743 to make a bit faster and to avoid GCC 4.6.0 warning.
3744 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3746 * fns.c (internal_equal): Don't assume size_t fits in int.
3748 * alloc.c (compact_small_strings): Tighten assertion a little.
3750 Replace pEd with more-general pI, and fix some printf arg casts.
3751 * lisp.h (pI): New macro, generalizing old pEd macro to other
3752 conversion specifiers. For example, use "...%"pI"d..." rather
3753 than "...%"pEd"...".
3754 (pEd): Remove. All uses replaced with similar uses of pI.
3755 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3756 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3757 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3758 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3759 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3760 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3761 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3763 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3764 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3765 * print.c (safe_debug_print, print_object): Likewise.
3766 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3768 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3769 avoiding the 0 flag, which is not portable.
3770 * process.c (Fmake_network_process): Use pI to avoid cast.
3771 * region-cache.c (pp_cache): Likewise.
3772 * xdisp.c (decode_mode_spec): Likewise.
3773 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3774 behavior on 64-bit hosts with printf arg.
3775 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3776 (x_stop_queuing_selection_requests): Likewise.
3777 (x_get_window_property): Don't truncate byte count to an 'int'
3780 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3781 here, since it parses constructs like leading '-' and spaces,
3782 which are not wanted; and it overflows with large numbers.
3783 Instead, simply match F[0-9]+, which is what is wanted anyway.
3785 * alloc.c: Remove unportable assumptions about struct layout.
3786 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3787 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3788 (allocate_vectorlike, make_pure_vector): Use the new macros,
3789 plus offsetof, to remove unportable assumptions about struct layout.
3790 These assumptions hold on all porting targets that I know of, but
3791 they are not guaranteed, they're easy to remove, and removing them
3792 makes further changes easier.
3794 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3795 This doesn't fix a bug but makes the code clearer.
3796 (string_overrun_cookie): Now const. Use initializers that
3797 don't formally overflow signed char, to avoid warnings.
3798 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3799 can cause Emacs to crash when string overrun checking is enabled.
3800 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3801 multiple of sizeof (EMACS_INT); it need not be, if
3802 alignof(EMACS_INT) < sizeof (EMACS_INT).
3803 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3805 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3807 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3809 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3811 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3812 supposed to be handshaking. (Bug#8556)
3813 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3815 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3817 * lisp.h (Qdebug): List symbol.
3818 * eval.c (Qdebug): Restore global linkage.
3819 * keyboard.c (debug-on-event): New variable.
3820 (handle_user_signal): Break into debugger when debug-on-event
3821 matches the current signal symbol.
3823 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3825 * alloc.c (check_sblock, check_string_bytes)
3826 (check_string_free_list): Convert to standard C.
3828 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3830 * w32.c (emacs_gnutls_push): Fix typo.
3832 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3834 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3835 "cast to pointer from integer of different size".
3837 Improve doprnt and its use in verror. (Bug#8545)
3838 * doprnt.c (doprnt): Document the set of format control sequences
3839 supported by the function. Use SAFE_ALLOCA instead of always
3842 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3843 is one byte too soon. Don't use xrealloc; instead xfree and
3846 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3848 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3851 * gnutls.c: Renamed global_initialized to
3852 gnutls_global_initialized. Added internals for the
3853 :verify-hostname-error, :verify-error, and :verify-flags
3854 parameters of `gnutls-boot' and documented those parameters in the
3855 docstring. Start callback support.
3856 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3857 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3858 on error. Return error code.
3859 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3860 (emacs_gnutls_read): Likewise.
3861 (Fgnutls_boot): Return handshake error code.
3862 (emacs_gnutls_handle_error): New function.
3863 (wsaerror_to_errno): Likewise.
3865 * w32.h (emacs_gnutls_pull): Add prototype.
3866 (emacs_gnutls_push): Likewise.
3868 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3869 (emacs_gnutls_push): Likewise.
3871 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3873 * process.c (wait_reading_process_output): Check if GnuTLS
3874 buffered some data internally if no FDs are set for TLS
3877 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3878 (LIBS): Link to USER_LIBS.
3879 ($(BLD)/gnutls.$(0)): New target.
3881 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3883 * xdisp.c (handle_single_display_spec): Rename the
3884 display_replaced_before_p argument into display_replaced_p, to
3885 make it consistent with the commentary. Fix typos in the
3888 * textprop.c (syms_of_textprop): Remove dead code.
3889 (copy_text_properties): Delete obsolete commentary about an
3890 interface that was deleted long ago. Fix typos in the description
3893 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3894 to changes in oldXMenu/XMenu.h from 2011-04-16.
3895 <menu_help_message, prev_menu_help_message>: Constify.
3896 (IT_menu_make_room): menu->help_text is now `const char **';
3899 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3900 to changes in oldXMenu/XMenu.h from 2011-04-16.
3901 (struct XMenu): Declare `help_text' `const char **'.
3903 * xfaces.c <Qunspecified>: Make extern again.
3905 * syntax.c: Include sys/types.h before including regex.h, as
3908 * doc.c (get_doc_string): Improve the format passed to `error'.
3910 * doprnt.c (doprnt): Improve commentary.
3912 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3914 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3917 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3918 changes in globals.h immediately force recompilation.
3919 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3920 $(CURDIR)/s/ms-w32.h.
3921 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3923 * character.c (Fchar_direction): Function deleted.
3924 (syms_of_character): Don't defsubr it.
3925 <char-direction-table>: Deleted.
3927 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3929 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3930 * doprnt.c: Include limits.h.
3931 (SIZE_MAX): New macro.
3932 (doprnt): Return a size_t value. 2nd arg is now size_t.
3933 Many local variables are now size_t instead of int or unsigned.
3934 Improve overflow protection. Support `l' modifier for integer
3935 conversions. Support %l conversion. Don't assume an EMACS_INT
3936 argument for integer conversions and for %c.
3938 * lisp.h (doprnt): Restore prototype.
3940 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3943 * Makefile.in (base_obj): Add back doprnt.o.
3945 * deps.mk (doprnt.o): Add back prerequisites.
3946 (callint.o): Depend on character.h.
3948 * eval.c (internal_lisp_condition_case): Include the handler
3949 representation in the error message.
3950 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3951 when breaking from the loop.
3953 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3955 * callint.c (Fcall_interactively): When displaying error message
3956 about invalid control letter, pass the character's codepoint, not
3957 a pointer to its multibyte form. Improve display of the character
3958 in octal and display also its hex code.
3960 * character.c (char_string): Use %x to display the (unsigned)
3961 codepoint of an invalid character, to avoid displaying a bogus
3964 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3965 `error', not SYMBOL_NAME itself.
3967 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3968 character arguments to `error'.
3970 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3971 to `error' in error message about FINAL_CHAR argument. Make sure
3972 FINAL_CHAR is a character, and use %c when it is passed as
3973 argument to `error'.
3975 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3977 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3979 * w32.c: Include <time.h>.
3980 (sys_localtime): New function.
3982 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3984 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3986 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3988 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3990 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3993 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3995 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3996 gl_state.e_property when gl_state.object is Qt.
3998 * insdel.c (make_gap_larger): Remove limitation of buffer size
4001 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4003 * xdisp.c (lookup_glyphless_char_display)
4004 (produce_glyphless_glyph): Handle cons cell entry in
4005 glyphless-char-display.
4006 (Vglyphless_char_display): Document it.
4008 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4009 glyphless-char-display.
4011 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4013 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4015 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4017 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4018 definition for no-X builds.
4020 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4022 Static checks with GCC 4.6.0 and non-default toolkits.
4024 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4026 * process.c (keyboard_bit_set): Define only if SIGIO.
4027 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4028 (send_process): Repair possible setjmp clobbering.
4030 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4032 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4034 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4036 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4037 Define only if needed.
4039 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4040 by pacifying GCC about it. Maybe it's time to retire it?
4041 * xfaces.c (USG, __TIMEVAL__): Likewise.
4043 * dispextern.h (struct redisplay_interface): Rename param
4045 * termhooks.h (struct terminal): Likewise.
4046 * xterm.c (xembed_send_message): Likewise.
4048 * insdel.c (make_gap_smaller): Define only if
4049 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4051 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4054 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4055 so that we aren't warned about unused symbols.
4057 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4059 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4061 * xfns.c (x_real_positions): Mark locals as initialized.
4063 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4065 * xterm.c: Fix problems found by static analysis with other toolkits.
4066 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4067 (x_dispatch_event): Declare static if USE_GTK, and
4068 define if USE_GTK || USE_X_TOOLKIT.
4069 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4070 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4071 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4072 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4074 * xmenu.c (menu_help_callback): Pointer type fixes.
4075 Use const pointers when pointing at readonly data. Avoid pointer
4077 (FALSE): Remove unused macro.
4078 (update_frame_menubar): Remove unused decl.
4080 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4082 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4083 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4084 (single_menu_item): Rename local to avoid shadowing.
4086 * keyboard.c (make_lispy_event): Remove unused local var.
4088 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4089 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4091 * bitmaps: Change bitmaps from unsigned char back to the X11
4092 compatible char. Avoid the old compiler warnings about
4093 out-of-range initializers by using, for example, '\xab' rather
4096 * xgselect.c (xgselect_initialize): Check vs interface
4097 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4099 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4101 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4102 to read-only memory.
4104 * fns.c (vector): Remove; this old hack is no longer needed.
4106 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4108 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4110 * xrdb.c (x_load_resources): Omit unused local.
4112 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4113 (x_window): Rename locals to avoid shadowing.
4114 (USG): Use the kludged USG macro, to pacify gcc.
4116 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4117 (x_term_init): Remove local to avoid shadowing.
4119 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4121 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4122 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4124 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4126 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4128 Fix regex.c, syntax.c and friends for buffers > 2GB.
4129 * syntax.h (struct gl_state_s): Declare character position members
4132 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4134 * textprop.c (verify_interval_modification, interval_of):
4135 Declare arguments EMACS_INT.
4137 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4140 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4142 * indent.c (Fvertical_motion): Local variable it_start is now
4145 * regex.c (re_match, re_match_2, re_match_2_internal)
4146 (bcmp_translate, regcomp, regexec, print_double_string)
4147 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4148 (re_compile_pattern, re_exec): Declare arguments and local
4149 variables `size_t' and `ssize_t' and return values `regoff_t', as
4151 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4152 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4153 <compile_stack_type>: `size' and `avail' are now `size_t'.
4155 * regex.h <regoff_t>: Use ssize_t, not int.
4156 (re_search, re_search_2, re_match, re_match_2): Arguments that
4157 specify buffer/string position and length are now ssize_t and
4158 size_t. Return type is regoff_t.
4160 2011-04-16 Ben Key <bkey76@gmail.com>
4162 * nsfont.m: Fixed bugs in ns_get_family and
4163 ns_descriptor_to_entity that were caused by using free to
4164 deallocate memory blocks that were allocated by xmalloc (via
4165 xstrdup). This caused Emacs to crash when compiled with
4166 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4167 --enable-checking=xmallocoverrun). xfree is now used to
4168 deallocate these memory blocks.
4170 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4172 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4174 emacs_write: Accept and return EMACS_INT for sizes.
4175 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4177 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4178 Accept and return EMACS_INT.
4179 (emacs_gnutls_write): Return the number of bytes written on
4181 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4182 (emacs_read, emacs_write): Remove check for negative size, as the
4183 Emacs source code has been audited now.
4184 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4185 (emacs_read, emacs_write): Use it.
4186 * process.c (send_process): Adjust to the new signatures of
4187 emacs_write and emacs_gnutls_write. Do not attempt to store
4188 a byte offset into an 'int'; it might overflow.
4189 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4191 * sound.c: Don't assume sizes fit in 'int'.
4192 (struct sound_device.period_size, alsa_period_size):
4193 Return EMACS_INT, not int.
4194 (struct sound_device.write, vox_write, alsa_write):
4195 Accept EMACS_INT, not int.
4196 (wav_play, au_play): Use EMACS_INT to store sizes and to
4197 record read return values.
4199 2011-04-15 Ben Key <bkey76@gmail.com>
4201 * keyboard.c (Qundefined): Don't declare static since it is used
4203 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4204 static since they are used in nsfont.m.
4206 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4208 * process.c (Qprocessp): Don't declare static.
4209 * lisp.h (Qprocessp): Declare again.
4211 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4213 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4215 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4217 Improve C-level modularity by making more things 'static'.
4219 Don't publish debugger-only interfaces to other modules.
4220 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4221 (verify_bytepos, count_markers): Move decls to the only modules
4223 * region-cache.h (pp_cache): Likewise.
4224 * window.h (check_all_windows): Likewise.
4225 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4227 * sysdep.c (croak): Now static, if
4228 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4229 * syssignal.h (croak): Declare only if not static.
4231 * alloc.c (refill_memory_reserve): Now static if
4232 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4233 * lisp.h (refill_memory_reserve): Declare only if not static.
4235 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4236 Define only if USE_LUCID.
4238 * xrdb.c (x_customization_string, x_rm_string): Now static.
4240 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4241 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4243 * xdisp.c (draw_row_with_mouse_face): Now static.
4244 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4246 * window.h (check_all_windows): Mark externally visible.
4248 * window.c (window_deletion_count): Now static.
4250 * undo.c: Make symbols static if they're not exported.
4251 (last_undo_buffer, last_boundary_position, pending_boundary):
4254 * textprop.c (interval_insert_behind_hooks): Now static.
4255 (interval_insert_in_front_hooks): Likewise.
4257 * term.c: Make symbols static if they're not exported.
4258 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4259 (max_frame_lines, tty_set_terminal_modes):
4260 (tty_reset_terminal_modes, tty_turn_off_highlight):
4261 (get_tty_terminal): Now static.
4262 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4263 * termhooks.h (term_mouse_moveto): Do not declare if
4265 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4266 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4268 * sysdep.c: Make symbols static if they're not exported.
4269 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4271 (sigprocmask_set, full_mask): Remove; unused.
4272 (wait_debugging): Mark as visible.
4273 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4274 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4276 * syntax.c (syntax_temp): Define only if !__GNUC__.
4278 * sound.c (current_sound_device, current_sound): Now static.
4280 * search.c (searchbufs, searchbuf_head): Now static.
4282 * scroll.c (scroll_cost): Remove; unused.
4283 * dispextern.h (scroll_cost): Remove decl.
4285 * region-cache.h (pp_cache): Mark as externally visible.
4287 * process.c: Make symbols static if they're not exported.
4288 (process_tick, update_tick, create_process, chan_process):
4289 (Vprocess_alist, proc_buffered_char, datagram_access):
4290 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4291 (deactivate_process): Mark defn as static, as well as decl.
4292 * lisp.h (create_process): Remove decl.
4293 * process.h (chan_process, Vprocess_alist): Remove decls.
4295 * print.c: Make symbols static if they're not exported.
4296 (print_depth, new_backquote_output, being_printed, print_buffer):
4297 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4298 (print_interval, print_number_index, initial_stderr_stream):
4300 * lisp.h (Fprinc): Remove decl.
4301 (debug_output_compilation_hack): Mark as externally visible.
4303 * sysdep.c (croak): Move decl from here to syssignal.h.
4304 * syssignal.h (croak): Put it here, so the API can be checked when
4305 'croak' is called from dissociate_if_controlling_tty.
4307 * minibuf.c: Make symbols static if they're not exported.
4308 (minibuf_save_list, choose_minibuf_frame): Now static.
4309 * lisp.h (choose_minibuf_frame): Remove decl.
4311 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4313 * lread.c: Make symbols static if they're not exported.
4314 (read_objects, initial_obarray, oblookup_last_bucket_number):
4316 (make_symbol): Remove; unused.
4317 * lisp.h (initial_obarray, make_symbol): Remove decls.
4319 * keyboard.c: Make symbols static if they're not exported.
4320 (single_kboard, recent_keys_index, total_keys, recent_keys):
4321 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4322 (this_single_command_key_start, echoing, last_auto_save):
4323 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4324 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4325 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4326 (Vlispy_mouse_stem, double_click_count):
4328 (force_auto_save_soon): Define only if SIGDANGER.
4329 (ignore_mouse_drag_p): Now static if
4330 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4331 (print_help): Remove; unused.
4332 (stop_character, last_timer_event): Mark as externally visible.
4333 * keyboard.h (ignore_mouse_drag_p): Declare only if
4334 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4335 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4336 * lisp.h (echoing): Remove decl.
4337 (force_auto_save_soon): Declare only if SIGDANGER.
4338 * xdisp.c (redisplay_window): Simplify code, to make it more
4339 obvious that ignore_mouse_drag_p is not accessed if !defined
4340 USE_GTK && !defined HAVE_NS.
4342 * intervals.c: Make symbols static if they're not exported.
4343 (merge_properties_sticky, merge_interval_right, delete_interval):
4345 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4347 * insdel.c: Make symbols static if they're not exported.
4348 However, leave prepare_to_modify_buffer alone. It's never
4349 called from outside this function, but that appears to be a bug.
4350 (combine_after_change_list, combine_after_change_buffer):
4351 (adjust_after_replace, signal_before_change): Now static.
4352 (adjust_after_replace_noundo): Remove; unused.
4353 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4354 (signal_before_change): Remove decls.
4356 * indent.c (val_compute_motion, val_vmotion): Now static.
4358 * image.c: Make symbols static if they're not exported.
4359 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4361 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4362 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4364 * fringe.c (standard_bitmaps): Now static.
4365 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4367 * frame.c: Make symbols static if they're not exported.
4368 (x_report_frame_params, make_terminal_frame): Now static.
4369 (get_frame_param): Now static, unless HAVE_NS.
4370 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4371 (x_get_resource_string): Remove; not used.
4372 * frame.h (make_terminal_frame, x_report_frame_params):
4373 (x_get_resource_string); Remove decls.
4374 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4375 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4377 * font.c, fontset.c: Make symbols static if they're not exported.
4378 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4379 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4380 * font.c (font_close_object): Now static.
4381 * font.h (font_close_object): Remove.
4382 * fontset.c (FONTSET_OBJLIST): Remove.
4383 (free_realized_fontset) #if-0 the body, which does nothing.
4384 (face_suitable_for_char_p): #if-0, as it's never called.
4385 * fontset.h (face_suitable_for_char_p): Remove decl.
4386 * xfaces.c (face_at_string_position):
4387 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4388 since 0 is always ASCII.
4390 * fns.c (weak_hash_tables): Now static.
4392 * fileio.c: Make symbols static if they're not exported.
4393 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4394 (Vwrite_region_annotation_buffers): Now static.
4396 * eval.c: Make symbols static if they're not exported.
4397 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4398 * lisp.h (backtrace_list): Remove decl.
4400 * emacs.c: Make symbols static if they're not exported.
4401 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4402 (fatal_error_code, fatal_error_signal_hook, standard_args):
4404 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4405 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4406 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4407 * lisp.h (fatal_error_signal_hook): Remove decl.
4408 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4410 * editfns.c: Move a (normally-unused) function to its only use.
4411 * editfns.c, lisp.h (get_operating_system_release): Remove.
4412 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4413 worth the hassle of breaking this out.
4415 * xterm.c: Make symbols static if they're not exported.
4416 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4417 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4418 (x_destroy_window, x_delete_display):
4420 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4421 (x_mouse_leave): Remove; unused.
4422 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4423 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4424 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4426 (x_mouse_leave): Declare only if WINDOWSNT.
4427 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4428 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4431 * ftxfont.c: Make symbols static if they're not exported.
4432 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4434 * font.h (ftxfont_driver): Likewise.
4436 * xfns.c: Make symbols static if they're not exported.
4437 (x_last_font_name, x_display_info_for_name):
4438 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4439 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4440 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4441 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4442 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4443 (last_show_tip_args): Now static.
4444 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4445 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4446 (x_screen_planes): Remove; unused.
4447 * dispextern.h (x_screen_planes): Remove decl.
4449 * dispnew.c: Make symbols static if they're not exported.
4450 * dispextern.h (redraw_garbaged_frames, scrolling):
4451 (increment_row_positions): Remove.
4452 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4453 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4455 (redraw_garbaged_frames): Remove; unused.
4457 * xfaces.c: Make symbols static if they're not exported.
4458 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4460 * xterm.h (defined_color): Remove decls.
4461 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4462 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4463 (menu_face_changed_default, defined_color, free_realized_face):
4464 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4465 (ascii_face_of_lisp_face): Remove; unused.
4467 * xdisp.c: Make symbols static if they're not exported.
4468 * dispextern.h (scratch_glyph_row, window_box_edges):
4469 (glyph_to_pixel_coords, set_cursor_from_row):
4470 (get_next_display_element, set_iterator_to_next):
4471 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4472 (show_mouse_face): Remove decls
4473 * frame.h (message_buf_print): Likewise.
4474 * lisp.h (pop_message, set_message, check_point_in_composition):
4476 * xterm.h (set_vertical_scroll_bar): Likewise.
4477 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4478 (message_buf_print, scratch_glyph_row, displayed_buffer):
4479 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4480 (get_next_display_element, show_mouse_face, window_box_edges):
4481 (frame_to_window_pixel_xy, check_point_in_composition):
4482 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4483 (glyph_to_pixel_coords): Remove; unused.
4485 * dired.c (file_name_completion): Now static.
4487 * dbusbind.c (xd_in_read_queued_messages): Now static.
4489 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4490 * data.c (circular_list_error): Remove.
4492 * commands.h (last_point_position, last_point_position_buffer):
4493 (last_point_position_window): Remove decls.
4494 * keyboard.c: Make these variables static.
4496 * coding.h (coding, code_convert_region, encode_coding_gap):
4498 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4499 (iso_code_class, detect_coding, code_convert_region): Now static.
4500 (encode_coding_gap): Remove; unused.
4502 * chartab.c (chartab_chars, chartab_bits): Now static.
4504 * charset.h (charset_iso_8859_1): Remove decl.
4505 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4508 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4509 * ccl.c (Vccl_program_table): Now static.
4510 (check_ccl_update): Remove; unused.
4512 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4513 * category.h: ... from here.
4514 * category.c (check_category_table, set_category_set): Now static.
4516 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4517 * lisp.h: Remove these decls.
4519 * buffer.c (buffer_count): Remove unused var.
4521 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4522 so that it's not optimized away.
4523 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4524 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4525 exported only to the debugger.
4527 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4528 * atimer.h (run_all_atimers): Remove; not exported.
4530 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4531 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4532 was inaccessible from Lisp.
4533 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4534 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4536 alloc.c: Import and export fewer symbols, and remove unused items.
4537 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4539 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4540 it's not optimized away by whole-program optimization.
4541 (message_enable_multibyte, free_misc): Remove.
4542 (catchlist, handlerlist, mark_backtrace):
4543 Declare only if BYTE_MARK_STACK.
4544 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4545 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4546 (message_enable_multibyte): Remove decl.
4547 (free_misc, interval_free_list, float_block, float_block_index):
4548 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4549 (cons_free_list, last_marked_index):
4551 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4552 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4553 (mark_backtrace): Define only if BYTE_MARK_STACK.
4554 * xdisp.c (message_enable_multibyte): Now static.
4556 Declare Lisp_Object Q* variables to be 'static' if not exported.
4557 This makes it easier for human readers (and static analyzers)
4558 to see whether these variables are used from other modules.
4559 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4560 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4561 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4562 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4563 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4564 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4565 * xmenu.c, xselect.c:
4566 Declare Q* vars static if they are not used in other modules.
4567 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4568 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4569 Remove decls of unexported vars.
4570 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4572 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4574 Make Emacs functions such as Fatom 'static' by default.
4575 This makes it easier for human readers (and static analyzers)
4576 to see whether these functions can be called from other modules.
4577 DEFUN now defines a static function. To make the function external
4578 so that it can be used in other C modules, use the new macro DEFUE.
4579 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4580 (Finit_image_library):
4581 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4582 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4583 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4584 Remove decls, since these functions are now static.
4585 (Funintern, Fget_internal_run_time): New decls, since these functions
4586 were already external.
4588 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4589 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4590 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4591 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4592 * keyboard.c, keymap.c, lread.c:
4593 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4594 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4595 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4596 Mark functions with DEFUE instead of DEFUN,
4597 if they are used in other modules.
4598 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4599 decls for now-static functions.
4600 * buffer.h (Fdelete_overlay): Remove decl.
4601 * callproc.c (Fgetenv_internal): Mark as internal.
4602 * composite.c (Fremove_list_of_text_properties): Remove decl.
4603 (Fcomposition_get_gstring): New forward static decl.
4604 * composite.h (Fcomposite_get_gstring): Remove decl.
4605 * dired.c (Ffile_attributes): New forward static decl.
4606 * doc.c (Fdocumntation_property): New forward static decl.
4607 * eval.c (Ffetch_bytecode): New forward static decl.
4608 (Funintern): Remove extern decl; now in .h file where it belongs.
4609 * fileio.c (Fmake_symbolic_link): New forward static decl.
4610 * image.c (Finit_image_library): New forward static decl.
4611 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4612 * intervals.h (Fprevious_property_change):
4613 (Fremove_list_of_text_properties): Remove decls.
4614 * keyboard.c (Fthis_command_keys): Remove decl.
4615 (Fcommand_execute): New forward static decl.
4616 * keymap.c (Flookup_key): New forward static decl.
4617 (Fcopy_keymap): Now static.
4618 * keymap.h (Flookup_key): Remove decl.
4619 * process.c (Fget_process): New forward static decl.
4620 (Fprocess_datagram_address): Mark as internal.
4621 * syntax.c (Fsyntax_table_p): New forward static decl.
4622 (skip_chars): Remove duplicate decl.
4623 * textprop.c (Fprevious_property_change): New forward static decl.
4624 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4626 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4627 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4629 * editfns.c (Fformat): Remove unreachable code.
4631 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4633 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4636 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4638 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4639 when at ZV. (Bug#8487)
4641 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4643 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4645 * keyboard.c (parse_tool_bar_item): Likewise.
4646 * sound.c (sound_cleanup, alsa_close): Likewise.
4647 * termcap.c (tgetent): Likewise.
4648 * xfns.c (x_default_font_parameter): Likewise.
4649 * xsettings.c (read_and_apply_settings): Likewise.
4651 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4652 (overrun_check_free): Protoize.
4654 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4656 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4657 since callers should never pass a negative size.
4658 Change the signature to match that of plain 'read' and 'write'; see
4659 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4660 * lisp.h: Update prototypes of emacs_write and emacs_read.
4662 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4664 * xdisp.c (redisplay_window): Don't try to determine the character
4665 position of the scroll margin if the window start point w->startp
4666 is outside the buffer's accessible region. (Bug#8468)
4668 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4670 Fix write-region and its subroutines for buffers > 2GB.
4671 * fileio.c (a_write, e_write): Modify declaration of arguments and
4672 local variables to support buffers larger than 2GB.
4673 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4675 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4676 argument, local variables, and return value.
4678 * lisp.h: Update prototypes of emacs_write and emacs_read.
4680 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4682 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4684 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4686 Fix more problems found by GCC 4.6.0's static checks.
4688 * xdisp.c (vmessage): Use a better test for character truncation.
4690 * charset.c (load_charset_map): <, not <=, for optimization,
4691 and to avoid potential problems with integer overflow.
4692 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4693 * casetab.c (set_identity, shuffle): Likewise.
4694 * editfns.c (Fformat): Likewise.
4695 * syntax.c (skip_chars): Likewise.
4697 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4698 This also lets GCC 4.6.0 generate slightly better loop code.
4700 * callint.c (Fcall_interactively): <, not <=, for optimization.
4701 (Fcall_interactively): Count the number of arguments produced,
4702 not the number of arguments given. This is simpler and lets GCC
4703 4.6.0 generate slightly better code.
4705 * ftfont.c: Distingish more carefully between FcChar8 and char.
4706 The previous code passed unsigned char * to a functions like
4707 strlen and xstrcasecmp that expect char *, which does not
4708 conform to the C standard.
4709 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4710 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4711 char * when the C standard requires it.
4713 * keyboard.c (read_char): Remove unused var.
4715 * eval.c: Port to Windows vsnprintf (Bug#8435).
4717 (SIZE_MAX): Define if the headers do not.
4718 (verror): Do not give up if vsnprintf returns a negative count.
4719 Instead, grow the buffer. This ports to Windows vsnprintf, which
4720 does not conform to C99. Problem reported by Eli Zaretskii.
4721 Also, simplify the allocation scheme, by avoiding the need for
4722 calling realloc, and removing the ALLOCATED variable.
4724 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4726 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4727 But keep the doprint source code for now, as we might revamp it
4728 and use it again (Bug#8435).
4729 * lisp.h (doprnt): Remove.
4730 * Makefile.in (base_obj): Remove doprnt.o.
4731 * deps.mk (doprnt.o): Remove.
4733 error: Print 32- and 64-bit integers portably (Bug#8435).
4734 Without this change, on typical 64-bit hosts error ("...%d...", N)
4735 was used to print both 32- and 64-bit integers N, which relied on
4737 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4739 * lisp.h (error, verror): Mark as printf-like functions.
4740 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4741 Report overflow in size calculations when allocating printf buffer.
4742 Do not truncate output string at its first null byte.
4743 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4744 Truncate the output at a character boundary, since vsnprintf does not
4746 * charset.c (check_iso_charset_parameter): Convert internal
4747 character to string before calling 'error', since %c now has the
4749 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4750 overflow when computing char to be passed to 'error'. Do not
4751 pass Lisp_Object to 'error'; pass the integer instead.
4752 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4753 formatted with plain %d.
4755 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4757 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4759 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4761 * xterm.c (x_catch_errors): Remove duplicate declaration.
4763 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4765 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4767 2011-04-10 Jim Meyering <meyering@redhat.com>
4769 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4770 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4771 return ssize_t not "int", and use size_t as the buffer length.
4772 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4773 * gnutls.h: Update declarations.
4774 * process.c (read_process_output): Use ssize_t, to match.
4775 (send_process): Likewise.
4777 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4779 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4781 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4783 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4784 Use unsigned char, to match FcChar8 type definition.
4786 * xterm.c (handle_one_xevent):
4787 * xmenu.c (create_and_show_popup_menu):
4788 * xselect.c (x_decline_selection_request)
4789 (x_reply_selection_request): Avoid type-punned deref of X events.
4791 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4793 Fix some uses of `int' instead of EMACS_INT.
4794 * search.c (string_match_1, fast_string_match)
4795 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4796 (scan_buffer, find_next_newline_no_quit)
4797 (find_before_next_newline, search_command, Freplace_match)
4798 (Fmatch_data): Make some `int' variables be EMACS_INT.
4800 * xdisp.c (display_count_lines): 3rd argument and return value now
4801 EMACS_INT. All callers changed.
4802 (pint2hrstr): Last argument is now EMACS_INT.
4804 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4805 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4806 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4807 (decode_coding_utf_16, decode_coding_emacs_mule)
4808 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4809 (decode_coding_ccl, decode_coding_charset)
4810 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4811 (decode_coding_iso_2022, decode_coding_emacs_mule)
4812 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4813 <char_offset, last_offset>: Declare EMACS_INT.
4814 (encode_coding_utf_8, encode_coding_utf_16)
4815 (encode_coding_emacs_mule, encode_invocation_designation)
4816 (encode_designation_at_bol, encode_coding_iso_2022)
4817 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4818 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4820 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4821 (encode_invocation_designation): Last argument P_NCHARS is now
4823 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4824 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4826 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4829 * ccl.c (Fccl_execute_on_string): Declare some variables
4832 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4834 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4836 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4838 * process.c (Fformat_network_address): Doc fix.
4840 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4842 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4844 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4846 * keyboard.c (read_char): Call Lisp function help-form-show,
4847 instead of using internal_with_output_to_temp_buffer.
4848 (Qhelp_form_show): New var.
4849 (syms_of_keyboard): Use DEFSYM macro.
4851 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4853 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4855 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4857 * process.c (Flist_processes): Remove to Lisp.
4858 (list_processes_1): Delete.
4860 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4862 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4864 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4866 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4868 Fix more problems found by GCC 4.6.0's static checks.
4870 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4872 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4874 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4876 * xdisp.c (vmessage): Mark as a printf-like function.
4878 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4880 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4882 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4883 printf-like functions.
4884 (tiff_load): Add casts to remove these marks before passing them
4885 to system-supplied API.
4887 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4889 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4890 This avoids several warnings with gcc -Wstrict-overflow.
4891 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4892 directly, rather than having caller test rule sign. This avoids
4893 some unnecessary tests.
4894 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4895 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4896 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4898 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4899 (xfont_open): Avoid unnecessary tests.
4901 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4903 * composite.h, composite.c (composition_gstring_put_cache):
4904 Use EMACS_INT, not int, for length.
4906 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4907 breaking out part of COMPOSITION_DECODE_RULE.
4908 (COMPOSITION_DECODE_RULE): Use it.
4909 * composite.c (get_composition_id): Remove unused local vars,
4910 by using the new macro.
4912 * textprop.c (set_text_properties_1): Change while to do-while,
4913 since the condition is always true at first.
4915 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4916 (interval_deletion_adjustment): Return unsigned value.
4919 * process.c (list_processes_1, create_pty, read_process_output):
4920 (exec_sentinel): Remove vars that were set but not used.
4921 (create_pty): Remove unnecessary "volatile"s.
4922 (Fnetwork_interface_info): Avoid possibility of int overflow.
4923 (read_process_output): Do adaptive read buffering even if carryover.
4924 (read_process_output): Simplify nbytes computation if buffered.
4926 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4928 * syntax.c (scan_words): Remove var that was set but not used.
4929 (update_syntax_table): Use unsigned instead of int.
4931 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4932 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4933 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4935 * print.c (print_error_message): Avoid int overflow.
4937 * font.c (font_list_entities): Redo for clarity,
4938 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4940 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4941 (font_score): Avoid potential overflow in diff calculation.
4943 * fns.c (substring_both): Remove var that is set but not used.
4944 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4946 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4948 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4949 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4950 can always succeed if overflow has undefined behavior.
4952 * search.c (boyer_moore, wordify): Remove vars set but not used.
4953 (wordify): Omit three unnecessary tests.
4955 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4956 All callers changed. This avoids the need for an unused var.
4958 * casefiddle.c (casify_region): Remove var that is set but not used.
4960 * dired.c (file_name_completion): Remove var that is set but not used.
4962 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4964 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4965 (Finsert_file_contents): Remove unnecessary code checking fd.
4967 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4968 Check for integer overflow on size calculations.
4970 * buffer.c (Fprevious_overlay_change): Remove var that is set
4973 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4974 Remove vars that are set but not used.
4975 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4976 (timer_check_2): Mark vars as initialized.
4978 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4980 * image.c (lookup_image): Remove var that is set but not used.
4981 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4983 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4984 that are set but not used.
4986 * xfns.c (make_invisible_cursor): Don't return garbage
4987 if XCreateBitmapFromData fails (Bug#8410).
4989 * xselect.c (x_get_local_selection, x_handle_property_notify):
4990 Remove vars that are set but not used.
4992 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4993 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4995 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4996 Remove var that is set but not used.
4997 (scroll_bar_windows_size): Now size_t, not int.
4998 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5001 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5002 (map_tty_color) [!defined MSDOS]: Likewise.
5004 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5006 * coding.c: Remove vars that are set but not used.
5007 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5008 All callers changed.
5009 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5010 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5011 (decode_coding_charset): Remove vars that are set but not used.
5013 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5014 that is set but not used.
5016 * print.c (print_object): Remove var that is set but not used.
5018 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5019 The gnulib version avoids calling malloc in the usual case,
5020 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5021 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5022 * filelock.c (current_lock_owner): Likewise.
5023 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5024 * sysdep.c: Include allocator.h, careadlinkat.h.
5025 (emacs_no_realloc_allocator): New static constant.
5026 (emacs_readlink): New function.
5027 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5028 ../lib/careadlinkat.h.
5030 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5032 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5033 first non-nil return value).
5035 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5037 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5038 if not defined (Bug#8403).
5040 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5042 * xdisp.c (display_count_lines): Remove parameter `start',
5043 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5044 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5045 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5046 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5047 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5048 and thereabouts. All callers changed.
5049 (get_per_char_metric): Remove parameter `f', unused since
5050 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5052 2011-04-02 Jim Meyering <meyering@redhat.com>
5054 do not dereference NULL upon failed strdup
5055 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5056 (ns_get_family): Likewise.
5058 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5060 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5062 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5064 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5067 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5069 Add lexical binding.
5071 * window.c (Ftemp_output_buffer_show): New fun.
5072 (Fsave_window_excursion):
5073 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5075 * lread.c (lisp_file_lexically_bound_p): New function.
5076 (Fload): Bind Qlexical_binding.
5077 (readevalloop): Remove `evalfun' arg.
5078 Bind Qinternal_interpreter_environment.
5079 (Feval_buffer): Bind Qlexical_binding.
5080 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5082 (syms_of_lread): Declare `lexical-binding'.
5084 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5086 * keyboard.c (eval_dyn): New fun.
5087 (menu_item_eval_property): Use it.
5089 * image.c (parse_image_spec): Use Ffunctionp.
5091 * fns.c (concat, mapcar1): Accept byte-code-functions.
5093 * eval.c (Fsetq): Handle lexical vars.
5094 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5095 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5096 (FletX, Flet): Obey lexical binding.
5097 (Fcommandp): Handle closures.
5098 (Feval): New `lexical' arg.
5099 (eval_sub): New function extracted from Feval. Use it almost
5100 everywhere where Feval was used. Look up vars in lexical env.
5102 (Ffunctionp): Move from subr.el.
5103 (Ffuncall): Handle closures.
5104 (apply_lambda): Remove `eval_flags'.
5105 (funcall_lambda): Handle closures and new byte-code-functions.
5106 (Fspecial_variable_p): New function.
5107 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5108 but without exporting it to Lisp.
5110 * doc.c (Fdocumentation, store_function_docstring):
5111 * data.c (Finteractive_form): Handle closures.
5113 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5116 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5118 (exec_byte_code): New function extracted from Fbyte_code to handle new
5119 calling convention for byte-code-functions. Add new byte-codes.
5121 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5123 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5125 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5127 * xdisp.c (redisplay_internal): Fix prototype.
5129 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5131 * xdisp.c (SCROLL_LIMIT): New macro.
5132 (try_scrolling): Use it when setting scroll_limit.
5133 Limit scrolling to 100 screen lines.
5134 (redisplay_window): Even when falling back on "recentering",
5135 position point in the window according to scroll-conservatively,
5136 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5138 (try_scrolling): When point is above the window, allow searching
5139 as far as scroll_max, or one screenful, to compute vertical
5140 distance from PT to the scroll margin position. This prevents
5141 try_scrolling from unnecessarily failing when
5142 scroll-conservatively is set to a value slightly larger than the
5143 window height. Clean up the case of PT below the margin at bottom
5144 of window: scroll_max can no longer be INT_MAX. When aggressive
5145 scrolling is in use, don't let point enter the opposite scroll
5146 margin as result of the scroll.
5147 (syms_of_xdisp) <scroll-conservatively>: Document the
5148 threshold of 100 lines for never-recentering scrolling.
5150 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5152 * dispextern.h (move_it_by_lines):
5153 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5154 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5155 (message_log_check_duplicate): Remove parameters `prev_bol' and
5156 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5157 (redisplay_internal): Remove parameter `preserve_echo_area',
5158 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5160 * indent.c (Fvertical_motion):
5161 * window.c (window_scroll_pixel_based, Frecenter):
5162 Don't pass `need_y_p' to `move_it_by_lines'.
5164 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5166 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5167 steal a few bits to be more compact.
5168 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5169 Remove unneeded casts.
5171 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5173 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5175 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5176 binding" message (bug#7967).
5178 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5180 Fix more problems found by GCC 4.6.0's static checks.
5182 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5183 Remove unused local var.
5185 * editfns.c (Fmessage_box): Remove unused local var.
5187 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5188 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5189 Omit unused local vars.
5190 * window.c (shrink_windows): Omit unused local var.
5191 * menu.c (digest_single_submenu): Omit unused local var.
5192 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5193 Omit unused local var.
5195 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5196 Don't assume string length fits in int.
5197 (keyremap_step, read_key_sequence): Use size_t for sizes.
5198 (read_key_sequence): Don't check last_real_key_start redundantly.
5200 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5201 instead of alloca (Bug#8344).
5203 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5204 (Fbacktrace_frame): Don't assume nframes fits in int.
5206 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5208 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5211 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5213 * cm.c (calccost): Turn while-do into do-while, for clarity.
5215 * keyboard.c (syms_of_keyboard): Use the same style as later
5216 in this function when indexing through an array. This also
5217 works around GCC bug 48267.
5219 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5221 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5223 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5224 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5226 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5227 This avoids undefined behavior on integer overflow, and is a bit
5228 more convenient anyway since it is compared to a size_t variable.
5230 Variadic C functions now count arguments with size_t, not int.
5231 This avoids an unnecessary limitation on 64-bit machines, which
5232 caused (substring ...) to crash on large vectors (Bug#8344).
5233 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5234 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5235 All variadic functions and their callers changed accordingly.
5236 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5237 * data.c (arith_driver, float_arith_driver): Likewise.
5238 * editfns.c (general_insert_function): Likewise.
5239 * eval.c (struct backtrace.nargs, interactive_p)
5240 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5241 (funcall_lambda, mark_backtrace): Likewise.
5242 * fns.c (concat): Likewise.
5243 * frame.c (x_set_frame_parameters): Likewise.
5244 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5245 0 if not found, not -1. All callers changed.
5247 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5248 (stack_copy_size): Now size_t, not int.
5249 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5251 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5253 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5254 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5255 All callers changed.
5257 * lisp.h (multibyte_char_to_unibyte):
5258 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5259 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5260 * character.h (CHAR_TO_BYTE8):
5261 * cmds.c (internal_self_insert):
5262 * editfns.c (general_insert_function):
5263 * keymap.c (push_key_description):
5264 * search.c (Freplace_match):
5265 * xdisp.c (message_dolog, set_message_1): All callers changed.
5267 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5269 * keyboard.c (safe_run_hook_funcall): New function.
5270 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5271 don't set the hook to nil, but remove the offending function instead.
5272 (Qcommand_hook_internal): Remove, unused.
5273 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5274 Vcommand_hook_internal.
5276 * eval.c (enum run_hooks_condition): Remove.
5277 (funcall_nil, funcall_not): New functions.
5278 (run_hook_with_args): Call each function through a `funcall' argument.
5279 Remove `cond' argument, now redundant.
5280 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5281 (Frun_hook_with_args_until_failure): Adjust accordingly.
5282 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5284 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5286 * dispextern.h (string_buffer_position): Remove declaration.
5288 * print.c (strout): Remove parameter `multibyte', unused since
5289 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5291 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5292 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5293 All callers changed.
5295 * w32.c (_wsa_errlist): Use braces for struct initializers.
5297 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5298 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5299 All callers changed.
5300 (string_buffer_position): Likewise. Also, make static (it's never
5301 used outside xdisp.c).
5302 (cursor_row_p): Remove parameter `w', unused since
5303 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5304 (decode_mode_spec): Remove parameter `precision', introduced during
5305 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5306 All callers changed.
5308 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5310 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5312 2011-03-27 Anders Lindgren <andlind@gmail.com>
5314 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5315 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5316 (ns_update_auto_hide_menu_bar): New functions.
5317 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5318 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5319 ns_constrain_all_frames.
5320 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5321 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5323 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5325 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5327 2011-03-27 Glenn Morris <rgm@gnu.org>
5329 * syssignal.h: Replace RETSIGTYPE with void.
5330 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5331 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5332 Replace SIGTYPE with void everywhere.
5333 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5334 * s/template.h (SIGTYPE): Remove commented out definition.
5336 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5338 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5339 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5341 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5343 * w32.c (read_unc_volume): Use parameter `henum', instead of
5344 global variable `wget_enum_handle'.
5346 * keymap.c (describe_vector): Remove parameters `indices' and
5347 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5348 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5350 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5352 * keyboard.c (timer_check): Remove parameter `do_it_now',
5353 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5354 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5355 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5357 * keyboard.c (read_char):
5358 * w32menu.c (w32_menu_display_help):
5359 * xmenu.c (show_help_event, menu_help_callback):
5360 Adjust calls to `show_help_echo'.
5362 * gtkutil.c (xg_maybe_add_timer):
5363 * keyboard.c (readable_events):
5364 * process.c (wait_reading_process_output):
5365 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5367 * insdel.c (adjust_markers_gap_motion):
5368 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5369 (gap_left, gap_right): Don't call it.
5371 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5373 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5374 incurred during fontification.
5376 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5378 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5379 (DEFVAR_PER_BUFFER): Don't pass it.
5381 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5382 (scrolling_window): Don't pass it.
5384 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5386 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5388 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5390 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5391 of variables specific to SELinux and computation of `encoded_absname'.
5393 * image.c (XPutPixel): Remove unused variable `height'.
5395 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5397 * unexw32.c (get_section_info): Remove unused variable `section'.
5399 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5400 (system_process_attributes): Remove unused variable `sess'.
5401 (sys_read): Remove unused variable `err'.
5403 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5404 (w32_wnd_proc): Remove unused variable `isdead'.
5405 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5406 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5407 (x_create_tip_frame): Remove unused variable `tem'.
5409 * w32inevt.c (w32_console_read_socket):
5410 Remove unused variable `no_events'.
5412 * w32term.c (x_draw_composite_glyph_string_foreground):
5413 Remove unused variable `width'.
5415 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5417 * w32term.c (x_set_glyph_string_clipping):
5418 Don't pass uninitialized region to CombineRgn.
5420 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5422 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5423 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5424 (Fx_close_connection): Remove unused variable `i'.
5426 * w32font.c (w32font_draw): Return number of glyphs.
5427 (w32font_open_internal): Remove unused variable `i'.
5428 (w32font_driver): Add missing initializer.
5430 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5431 (fill_in_menu): Remove unused variable `items_added'.
5433 * w32term.c (last_mouse_press_frame): Remove static global variable.
5434 (w32_clip_to_row): Remove unused variable `f'.
5435 (x_delete_terminal): Remove unused variable `i'.
5437 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5438 (NOTHING): Remove unused static global variable.
5439 (uniscribe_check_otf): Remove unused variable `table'.
5440 (uniscribe_font_driver): Add missing initializers.
5442 2011-03-23 Julien Danjou <julien@danjou.info>
5444 * term.c (Fsuspend_tty, Fresume_tty):
5445 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5446 * window.c (temp_output_buffer_show):
5447 * insdel.c (signal_before_change):
5448 * frame.c (Fhandle_switch_frame):
5449 * fileio.c (Fdo_auto_save):
5450 * emacs.c (Fkill_emacs):
5451 * editfns.c (save_excursion_restore):
5452 * cmds.c (internal_self_insert):
5453 * callint.c (Fcall_interactively):
5454 * buffer.c (Fkill_all_local_variables):
5455 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5457 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5458 unconditionnaly since it does the check itself.
5460 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5462 Fix more problems found by GCC 4.5.2's static checks.
5464 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5465 the first time through the loop, since we know p0 < p1 then.
5466 This also avoids a gcc -Wstrict-overflow warning.
5468 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5469 leading to a memory leak, possible in functions like
5470 load_charset_map_from_file that can allocate an unbounded number
5471 of objects (Bug#8318).
5473 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5474 that could (at least in theory) be that large.
5476 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5477 This is less likely to overflow, and avoids undefined behavior if
5478 overflow does occur. All callers changed. Use strtoul to scan
5479 for the unsigned long integer.
5480 (pint2hrstr): Simplify and tune code slightly.
5481 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5483 * scroll.c (do_scrolling): Work around GCC bug 48228.
5484 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5486 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5487 This also avoids a warning with gcc -Wstrict-overflow.
5488 (validate_x_resource_name): Simplify count usage.
5489 This also avoids a warning with gcc -Wstrict-overflow.
5491 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5494 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5496 * process.c (Fmake_network_process): Use socklen_t, not int,
5497 where POSIX says socklen_t is required in portable programs.
5498 This fixes a porting bug on hosts like 64-bit HP-UX, where
5499 socklen_t is wider than int (Bug#8277).
5500 (Fmake_network_process, server_accept_connection):
5501 (wait_reading_process_output, read_process_output):
5504 * process.c: Rename or move locals to avoid shadowing.
5505 (list_processes_1, Fmake_network_process):
5506 (read_process_output_error_handler, exec_sentinel_error_handler):
5507 Rename or move locals.
5508 (Fmake_network_process): Define label "retry_connect" only if needed.
5509 (Fnetwork_interface_info): Fix pointer signedness.
5510 (process_send_signal): Add cast to avoid pointer signedness problem.
5511 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5512 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5514 Make tparam.h and terminfo.c consistent.
5515 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5516 Include tparam.h instead, since it declares them.
5517 * cm.h (PC): Remove extern decl; tparam.h now does this.
5518 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5519 * terminfo.c: Include tparam.h, to check interfaces.
5520 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5521 (tparam): Adjust signature to match interface in tparam.h;
5522 this removes some undefined behavior. Check that outstring and len
5523 are zero, which they always are with Emacs.
5524 * tparam.h (PC, BC, UP): New extern decls.
5526 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5527 (xftfont_open): Rename locals to avoid shadowing.
5529 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5530 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5531 (OTF_TAG_SYM): Omit macro if not needed.
5532 (ftfont_list): Remove unused local.
5533 (get_adstyle_property, ftfont_pattern_entity):
5534 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5535 Rename locals to avoid shadowing.
5537 * xfont.c (xfont_list_family): Mark var as initialized.
5539 * xml.c (make_dom): Now static.
5541 * composite.c (composition_compute_stop_pos): Rename local to
5543 (composition_reseat_it): Remove unused locals.
5544 (find_automatic_composition, composition_adjust_point): Likewise.
5545 (composition_update_it): Mark var as initialized.
5546 (find_automatic_composition): Mark vars as initialized,
5547 with a FIXME (Bug#8290).
5549 character.h: Rename locals to avoid shadowing.
5550 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5551 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5552 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5553 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5556 * textprop.c (property_change_between_p): Remove; unused.
5558 * intervals.c (interval_start_pos): Now static.
5560 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5562 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5563 Rename locals to avoid shadowing.
5565 * sound.c (wav_play, au_play, Fplay_sound_internal):
5566 Fix pointer signedness.
5567 (alsa_choose_format): Remove unused local var.
5568 (wav_play): Initialize a variable to 0, to prevent undefined
5569 behavior (Bug#8278).
5571 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5573 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5575 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5576 clobbering (Bug#8298).
5577 * sysdep.c (sys_subshell): Likewise.
5578 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5580 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5581 This should get cleaned up, so that child_setup has the
5582 same signature on all platforms.
5584 * callproc.c (call_process_cleanup): Now static.
5585 (relocate_fd): Rename locals to avoid shadowing.
5587 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5589 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5590 not to be necessary, and produces flickering.
5592 2011-03-20 Glenn Morris <rgm@gnu.org>
5594 * config.in: Remove file.
5596 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5598 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5599 are now in src/globals.h.
5600 (syms_of_minibuf): Remove spurious & from previous change.
5602 2011-03-20 Leo <sdl.web@gmail.com>
5604 * minibuf.c (completing-read-function): New variable.
5605 (completing-read-default): Rename from completing-read.
5606 (completing-read): Call completing-read-function.
5608 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5610 * xfaces.c (Fx_load_color_file):
5611 Read color file from absolute filename (bug#8250).
5613 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5615 * makefile.w32-in: Update dependencies.
5617 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5619 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5621 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5623 Fix more problems found by GCC 4.5.2's static checks.
5625 * process.c (make_serial_process_unwind, send_process_trap):
5626 (sigchld_handler): Now static.
5628 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5629 That way, the code declares only the vars that it needs.
5630 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5631 * s/cygwin.h (PTY_ITERATION): Likewise.
5632 * s/darwin.h (PTY_ITERATION): Likewise.
5633 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5635 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5636 * process.c (allocate_pty): Don't declare stb unless it's needed.
5638 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5639 (CONSTANTLIM): Remove; unused.
5640 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5641 Define only if needed.
5643 * unexelf.c (unexec): Name an expression,
5644 to avoid gcc -Wbad-function-cast warning.
5645 Use a different way to cause a compilation error if anyone uses
5646 n rather than nn, a way that does not involve shadowing.
5647 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5649 * deps.mk (unexalpha.o): Remove; unused.
5651 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5652 * unexec.h: New file.
5653 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5654 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5656 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5657 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5658 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5659 Change as necessary to match prototype in unexec.h.
5661 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5663 (back_comment, skip_chars): Mark vars as initialized.
5665 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5666 Rename locals to avoid shadowing.
5668 * lread.c (read1): Rewrite so as not to use empty "else".
5669 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5671 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5673 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5674 warning when compiling print.c.
5676 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5677 instead of using an uninitialized var.
5678 (font_sort_entities): Mark var as initialized.
5680 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5682 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5683 pointers to constants.
5684 (font_parse_fcname): Remove unused vars.
5685 (font_delete_unmatched): Now static.
5686 (font_get_spec): Remove; unused.
5687 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5688 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5689 Rename or move locals to avoid shadowing.
5691 * fns.c (require_nesting_list, require_unwind): Now static.
5692 (Ffillarray): Rename locals to avoid shadowing.
5694 * floatfns.c (domain_error2): Define only if needed.
5695 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5697 * alloc.c (mark_backtrace): Move decl from here ...
5698 * lisp.h: ... to here, so that it can be checked.
5700 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5701 (Fdefvar): Rewrite so as not to use empty "else".
5702 (lisp_indirect_variable): Name an expression,
5703 to avoid gcc -Wbad-function-cast warning.
5704 (Fdefvar): Rename locals to avoid shadowing.
5706 * callint.c (quotify_arg, quotify_args): Now static.
5707 (Fcall_interactively): Rename locals to avoid shadowing.
5708 Use const pointer when appropriate.
5710 * lisp.h (get_system_name, get_operating_system_release):
5711 Move decls here, to check interfaces.
5712 * process.c (get_operating_system_release): Move decl to lisp.h.
5713 * xrdb.c (get_system_name): Likewise.
5714 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5715 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5716 some of which prompt warnings from gcc -Wbad-function-cast.
5717 (Fformat_time_string, Fencode_time, Finsert_char):
5718 (Ftranslate_region_internal, Fformat):
5719 Rename or remove local vars to avoid shadowing.
5720 (Ftranslate_region_internal): Mark var as initialized.
5722 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5725 * lisp.h (eassert): Check that the argument compiles, even if
5726 ENABLE_CHECKING is not defined.
5728 * data.c (Findirect_variable): Name an expression, to avoid
5729 gcc -Wbad-function-cast warning.
5730 (default_value, arithcompare, arith_driver, arith_error): Now static.
5731 (store_symval_forwarding): Rename local to avoid shadowing.
5732 (Fmake_variable_buffer_local, Fmake_local_variable):
5733 Mark variables as initialized.
5734 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5736 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5737 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5738 Rename locals to avoid shadowing.
5739 (mark_stack): Move local variables into the #ifdef region where
5741 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5742 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5744 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5745 (GC_STRING_CHARS): Remove; not used.
5746 (Fmemory_limit): Cast sbrk's returned value to char *.
5748 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5749 avoids undefined behavior in theory.
5751 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5753 Use functions, not macros, for up- and down-casing (Bug#8254).
5754 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5755 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5756 to use the following functions instead of these macros.
5757 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5758 EMACS_INT, since callers assume the returned value fits in int.
5759 (upcase1): Likewise, for UPCASE_TABLE.
5760 (uppercasep, lowercasep, upcase): New static inline functions.
5761 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5762 the race-condition problem in the old DOWNCASE.
5764 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5765 Rename locals to avoid shadowing.
5766 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5767 (regex_compile, re_search_2, re_match_2_internal):
5768 Remove unused local vars.
5769 (FREE_VAR): Rewrite so as not to use empty "else",
5770 which gcc can warn about.
5771 (regex_compile, re_match_2_internal): Mark locals as initialized.
5772 (RETALLOC_IF): Define only if needed.
5773 (WORDCHAR_P): Likewise. This one is never needed, but is used
5774 only in a comment talking about a compiler bug, so put inside
5775 the #if 0 of that comment.
5776 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5777 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5780 * search.c (boyer_moore): Rename locals to avoid shadowing.
5781 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5782 (PREV_CHAR_BOUNDARY): Likewise.
5784 * search.c (simple_search): Remove unused var.
5786 * dired.c (compile_pattern): Move decl from here ...
5787 * lisp.h: ... to here, so that it can be checked.
5788 (struct re_registers): New forward decl.
5790 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5792 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5794 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5795 Rename locals to avoid shadowing.
5796 (Fvertical_motion): Mark locals as initialized.
5798 * casefiddle.c (casify_object, casify_region): Now static.
5799 (casify_region): Mark local as initialized.
5801 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5803 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5804 New macros, so that the caller can use some names other than
5805 gcpro1, gcpro2, etc.
5806 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5808 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5809 argument, for consistency with GCPRO2_VAR, etc: it is now the
5810 prefix of the variable, not the variable itself. All uses
5812 * dired.c (directory_files_internal, file_name_completion):
5813 Rename locals to avoid shadowing.
5815 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5816 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5817 dired.c's scmp function, had undefined behavior.
5818 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5819 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5820 * buffer.h: ... to here, because these macros use current_buffer,
5821 and the new implementation with inline functions needs to have
5822 current_buffer in scope now, rather than later when the macros
5824 (downcase, upcase1): New static inline functions.
5825 (DOWNCASE, UPCASE1): Reimplement using these functions.
5826 This avoids undefined behavior in expressions like
5827 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5828 from race conditions in accessing the global variables
5829 case_temp1 and case_temp2.
5830 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5831 * lisp.h (case_temp1, case_temp2): Remove their decls.
5832 * character.h (ASCII_CHAR_P): Move from here ...
5833 * lisp.h: ... to here, so that the inline functions mentioned
5836 * dired.c (directory_files_internal_unwind): Now static.
5838 * fileio.c (file_name_as_directory, directory_file_name):
5839 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5841 (file_name_as_directory): Use const pointers when appropriate.
5842 (Fexpand_file_name): Likewise. In particular, newdir might
5843 point at constant storage, so make it a const pointer.
5844 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5845 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5847 (Fset_file_times, Finsert_file_contents, auto_save_error):
5848 Rename locals to avoid shadowing.
5850 * minibuf.c (choose_minibuf_frame_1): Now static.
5851 (Ftry_completion, Fall_completions): Rename or remove locals
5854 * marker.c (bytepos_to_charpos): Remove; unused.
5856 * lisp.h (verify_bytepos, count_markers): New decls,
5857 so that gcc does not warn that these functions aren't declared.
5859 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5860 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5861 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5862 (copy_text): Remove unused local var.
5864 * filelock.c (within_one_second): Now static.
5865 (lock_file_1): Rename local to avoid shadowing.
5867 * buffer.c (fix_overlays_before): Mark locals as initialized.
5868 (fix_start_end_in_overlays): Likewise. This function should be
5869 simplified by using pointers-to-pointers, but that's a different
5871 (switch_to_buffer_1): Now static.
5872 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5873 (report_overlay_modification): Rename locals to avoid shadowing.
5875 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5876 Fix pointer signedness issue.
5877 (sys_subshell): Mark local as volatile if checking for lint,
5878 to suppress a gcc -Wclobbered warning that does not seem to be right.
5879 (MAXPATHLEN): Define only if needed.
5881 * process.c (serial_open, serial_configure): Move decls from here ...
5882 * systty.h: ... to here, so that they can be checked.
5884 * fns.c (get_random, seed_random): Move extern decls from here ...
5885 * lisp.h: ... to here, so that they can be checked.
5887 * sysdep.c (reset_io): Now static.
5888 (wait_for_termination_signal): Remove; unused.
5890 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5891 (copy_keymap_item, append_key, push_text_char_description):
5893 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5894 (DENSE_TABLE_SIZE): Remove; unused.
5895 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5896 (describe_map_tree):
5897 Rename locals to avoid shadowing.
5899 * keyboard.c: Declare functions static if they are not used elsewhere.
5900 (echo_char, echo_dash, cmd_error, top_level_2):
5901 (poll_for_input, handle_async_input): Now static.
5902 (read_char, kbd_buffer_get_event, make_lispy_position):
5903 (make_lispy_event, make_lispy_movement, apply_modifiers):
5904 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5905 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5906 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5907 (read_key_sequence, read_char): Mark locals as initialized.
5908 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5910 * keyboard.h (make_ctrl_char): New decl.
5911 (mark_kboards): Move decl here ...
5912 * alloc.c (mark_kboards): ... from here.
5914 * lisp.h (force_auto_save_soon): New decl.
5916 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5917 (DEFINE_DUMMY_FUNCTION): New macro.
5918 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5920 (main): Add casts to avoid warnings
5921 if GCC considers string literals to be constants.
5923 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5925 * dbusbind.c: Pointer signedness fixes.
5926 (xd_signature, xd_append_arg, xd_initialize):
5927 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5928 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5929 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5930 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5932 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5933 if GCC considers string literals to be constants.
5934 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5936 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5938 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5939 (print_preprocess, print_object): New macro to fix last change.
5941 * print.c (print_preprocess): Don't forget font objects.
5943 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5945 * emacs.c (USAGE3): Doc fixes.
5947 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5949 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5952 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5954 * lisp.h (VWindow_system, Qfile_name_history):
5955 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5956 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5957 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5959 * w32select.c: Don't #include "keyboard.h".
5960 (run_protected): Add extern declaration for waiting_for_input.
5962 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5963 * w32console.c (detect_input_pending, read_input_pending)
5964 (encode_terminal_code):
5965 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5966 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5967 (w32_system_caret_y, Qfile_name_history):
5968 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5969 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5970 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5971 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5972 * w32proc.c (Qlocal, report_file_error):
5973 * w32term.c (Vwindow_system, updating_frame):
5974 * w32uniscribe.c (initialized, uniscribe_font_driver):
5975 Remove unneeded extern declarations.
5977 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5979 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5981 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5983 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5984 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5985 These macros can no longer be used for assignment.
5987 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5988 Assign struct members directly, instead of using BUF_BEGV etc.
5989 (record_buffer_markers, fetch_buffer_markers): New functions for
5990 recording and fetching special buffer markers.
5991 (set_buffer_internal_1, set_buffer_temp): Use them.
5993 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5995 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5997 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5998 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6000 * xdisp.c (hscroll_window_tree):
6001 (reconsider_clip_changes): Use PT instead of BUF_PT.
6003 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6005 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6006 $(EMACS_ROOT)/lib/intprops.h.
6008 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6010 Fix more problems found by GCC 4.5.2's static checks.
6012 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6013 to unsigned char * to avoid compiler diagnostic.
6014 (xg_free_frame_widgets): Make it clear that a local variable is
6015 needed only if USE_GTK_TOOLTIP.
6016 (gdk_window_get_screen): Make it clear that this macro is needed
6017 only if USE_GTK_TOOLTIP.
6018 (int_gtk_range_get_value): New function, which avoids a diagnostic
6019 from gcc -Wbad-function-cast.
6020 (xg_set_toolkit_scroll_bar_thumb): Use it.
6021 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6022 diagnostic from gcc -Wbad-function-cast.
6023 (get_utf8_string, xg_get_file_with_chooser):
6024 Rename locals to avoid shadowing.
6025 (create_dialog): Move locals to avoid shadowing.
6027 * xgselect.c (xg_select): Remove unused var.
6029 * image.c (four_corners_best): Mark locals as initialized.
6030 (gif_load): Initialize transparent_p to zero (Bug#8238).
6031 Mark another local as initialized.
6032 (my_png_error, my_error_exit): Mark with NO_RETURN.
6034 * image.c (clear_image_cache): Now static.
6035 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6036 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6037 (x_edge_detection): Remove unnecessary cast that
6038 gcc -Wbad-function-cast diagnoses.
6039 (gif_load): Fix pointer signedness.
6040 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6041 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6043 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6045 Improve quality of tests for time stamp overflow.
6046 For example, without this patch (encode-time 0 0 0 1 1
6047 1152921504606846976) returns the obviously-bogus value (-948597
6048 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6049 reports time overflow. See
6050 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6051 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6052 * editfns.c: Include limits.h and intprops.h.
6053 (TIME_T_MIN, TIME_T_MAX): New macros.
6054 (time_overflow): Move earlier, to before first use.
6055 (hi_time, lo_time): New functions, for an accurate test for
6057 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6058 (Fget_internal_run_time): Don't assume time_t fits in int.
6059 (make_time): Use list2 instead of Fcons twice.
6060 (Fdecode_time): More accurate test for out-of-range times.
6061 (check_tm_member): New function.
6062 (Fencode_time): Use it, to test for out-of-range times.
6063 (lisp_time_argument): Don't rely on undefined left-shift and
6064 right-shift behavior when checking for time stamp overflow.
6066 * editfns.c (time_overflow): New function, refactoring common code.
6067 (Fformat_time_string, Fdecode_time, Fencode_time):
6068 (Fcurrent_time_string): Use it.
6070 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6071 * dired.c (make_time): Move to ...
6072 * editfns.c (make_time): ... here.
6073 * systime.h: Note the move.
6075 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6077 * fringe.c (update_window_fringes): Remove unused variables.
6079 * unexmacosx.c (copy_data_segment): Also copy __got section.
6082 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6084 * termcap.c [MSDOS]: Include "msdos.h".
6085 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6086 Constify `char *' arguments and their references according to
6087 prototypes in tparam.h.
6089 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6091 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6092 Adapt all references accordingly.
6094 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6096 2011-03-11 Tom Tromey <tromey@redhat.com>
6098 * buffer.c (syms_of_buffer): Remove obsolete comment.
6100 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6102 * termhooks.h (encode_terminal_code): Declare prototype.
6104 * msdos.c (encode_terminal_code): Don't declare prototype.
6106 * term.c (encode_terminal_code): Now external again, used by
6107 w32console.c and msdos.c.
6109 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6110 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6112 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6114 Fix some minor problems found by GCC 4.5.2's static checks.
6116 * fringe.c (update_window_fringes): Mark locals as initialized
6118 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6120 * alloc.c (mark_fringe_data): Move decl from here ...
6121 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6122 to check its interface.
6123 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6125 * fontset.c (free_realized_fontset): Now static.
6126 (Fset_fontset_font): Rename local to avoid shadowing.
6127 (fontset_font): Mark local as initialized.
6128 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6130 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6132 * xselect.c (x_disown_buffer_selections): Remove; not used.
6133 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6134 (x_own_selection, Fx_disown_selection_internal): Rename locals
6136 (x_handle_dnd_message): Remove local to avoid shadowing.
6138 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6139 so that the caller can use some name other than gcpro1.
6140 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6141 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6142 (Fx_backspace_delete_keys_p):
6143 Use them to avoid shadowing, and rename vars to avoid shadowing.
6144 (x_decode_color, x_set_name, x_window): Now static.
6145 (Fx_create_frame): Add braces to silence GCC warning.
6146 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6147 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6148 Remove unused locals.
6149 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6150 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6151 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6154 * xterm.h (x_mouse_leave): New decl.
6156 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6157 Remove unused functions.
6158 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6159 (x_calc_absolute_position): Now static.
6160 (XTread_socket): Don't define label "out" unless it's used.
6161 Don't declare local "event" unless it's used.
6162 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6163 unless they are used.
6164 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6165 (x_fatal_error_signal): Remove; not used.
6166 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6167 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6168 (x_error_catcher, x_connection_closed, x_error_handler):
6169 (x_error_quitter, xembed_send_message, x_iconify_frame):
6170 (my_log_handler): Rename locals to avoid shadowing.
6171 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6172 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6174 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6175 Rename or move locals to avoid shadowing.
6176 (tty_defined_color, merge_face_heights): Now static.
6177 (free_realized_faces_for_fontset): Remove; not used.
6178 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6179 does not deduce is never used uninitialized.
6180 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6181 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6183 * terminal.c (store_terminal_param): Now static.
6185 * xmenu.c (menu_highlight_callback): Now static.
6186 (set_frame_menubar): Remove unused local.
6187 (xmenu_show): Rename parameter to avoid shadowing.
6188 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6189 since they might point to immutable storage.
6190 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6191 since it's unused otherwise.
6193 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6194 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6195 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6196 avoids a gcc -Wuninitialized diagnostic.
6197 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6198 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6199 does not deduce are never used uninitialized.
6201 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6203 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6204 * window.c (window_loop, size_window):
6205 (run_window_configuration_change_hook, enlarge_window): Likewise.
6207 * window.c (display_buffer): Now static.
6208 (size_window): Mark variables that gcc -Wuninitialized
6209 does not deduce are never used uninitialized.
6210 * window.h (check_all_windows): New decl, to forestall
6211 gcc -Wmissing-prototypes diagnostic.
6212 * dispextern.h (bidi_dump_cached_states): Likewise.
6214 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6216 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6218 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6219 and to avoid gcc -Wuninitialized warning.
6220 (load_charset_map): Mark variables that gcc -Wuninitialized
6221 does not deduce are never used uninitialized.
6222 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6224 * coding.c (coding_set_source, coding_set_destination):
6225 Use "else { /* comment */ }" rather than "else /* comment */;"
6226 for clarity, and to avoid gcc -Wempty-body warning.
6227 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6228 a block, when the outer 'i' will do.
6229 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6230 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6231 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6232 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6233 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6234 Rename locals to avoid shadowing.
6235 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6236 * coding.c (emacs_mule_char, encode_invocation_designation):
6237 Now static, since they're not used elsewhere.
6238 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6239 (decode_coding_object, encode_coding_object, detect_coding_system):
6240 (decode_coding_emacs_mule): Mark variables that gcc
6241 -Wuninitialized does not deduce are never used uninitialized.
6242 (detect_coding_iso_2022): Initialize a local variable that might
6243 be used uninitialized. Leave a FIXME because it's not clear that
6244 this initialization is needed. (Bug#8211)
6245 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6246 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6247 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6248 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6249 Remove unused macros.
6251 * category.c (hash_get_category_set): Remove unused local var.
6252 (copy_category_table): Now static, since it's not used elsewhere.
6253 * character.c (string_count_byte8): Likewise.
6255 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6256 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6258 * chartab.c (copy_sub_char_table): Now static, since it's not used
6260 (sub_char_table_ref_and_range, char_table_ref_and_range):
6261 Rename locals to avoid shadowing.
6262 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6264 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6265 (BIDI_BOB): Remove unused macro.
6267 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6268 deduce are never used uninitialized.
6269 * term.c (encode_terminal_code): Likewise.
6271 * term.c (encode_terminal_code): Now static. Remove unused local.
6273 * tparam.h: New file.
6274 * term.c, tparam.h: Include it.
6275 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6276 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6277 Move these decls to tparam.h, and make them agree with what
6278 is actually in tparam.c. The previous trick of using incompatible
6279 decls in different modules does not conform to the C standard.
6280 All callers of tparam changed to use tparam's actual API.
6281 * tparam.c (tparam1, tparam, tgoto):
6282 Use const pointers where appropriate.
6284 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6285 * cm.h (struct cm): Likewise.
6286 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6287 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6288 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6289 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6290 (turn_on_face, init_tty): Likewise.
6291 * termchar.h (struct tty_display_info): Likewise.
6293 * term.c (term_mouse_position): Rename local to avoid shadowing.
6295 * alloc.c (mark_ttys): Move decl from here ...
6296 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6298 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6300 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6302 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6304 * search.c (compile_pattern_1): Remove argument regp, unused since
6305 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6306 (compile_pattern): Don't pass it.
6308 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6310 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6311 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6313 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6315 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6317 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6318 gdk_window_get_screen, gdk_window_get_geometry,
6319 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6320 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6321 (xg_get_pixbuf_from_pixmap): New function.
6322 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6323 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6324 Call xg_get_pixbuf_from_pixmap instead of
6325 gdk_pixbuf_get_from_drawable.
6326 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6327 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6328 (xg_check_special_colors): Use GtkStyleContext and its functions
6330 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6331 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6332 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6333 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6334 Call gtk_widget_get_preferred_size.
6335 (xg_frame_resized): gdk_window_get_geometry only takes 5
6337 (xg_win_to_widget, xg_event_is_for_menubar):
6338 Call gdk_x11_window_lookup_for_display.
6339 (xg_set_widget_bg): New function.
6340 (delete_cb): New function.
6341 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6342 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6343 (xg_set_background_color): Call xg_set_widget_bg.
6344 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6345 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6346 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6347 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6349 (update_frame_tool_bar): Call gtk_widget_hide.
6350 (xg_initialize): Use GDK_KEY_g.
6352 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6354 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6356 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6357 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6358 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6360 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6362 * w32xfns.c (select_palette): Check success of RealizePalette against
6363 GDI_ERROR, not zero.
6365 See ChangeLog.11 for earlier changes.
6371 Copyright (C) 2011 Free Software Foundation, Inc.
6373 This file is part of GNU Emacs.
6375 GNU Emacs is free software: you can redistribute it and/or modify
6376 it under the terms of the GNU General Public License as published by
6377 the Free Software Foundation, either version 3 of the License, or
6378 (at your option) any later version.
6380 GNU Emacs is distributed in the hope that it will be useful,
6381 but WITHOUT ANY WARRANTY; without even the implied warranty of
6382 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6383 GNU General Public License for more details.
6385 You should have received a copy of the GNU General Public License
6386 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.