1 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
3 * fileio.c (time_error_value): Rename from special_mtime.
4 The old name's problems were noted by Eli Zaretskii in
5 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
7 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
8 This variable's comment says Emacs needs at least one GDB-visible
9 symbol of type enum pvec_type, to work around GDB problems.
10 The symbol's value doesn't matter.
12 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
13 that causes compilation to fail on pre-C99 compilers.
15 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
17 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
18 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
20 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
22 * buffer.c (init_buffer_once): Fix initialization of
23 headers for buffer_defaults and buffer_local_symbols.
24 Reported by Juanma Barranquero <lekktu@gmail.com>.
26 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
28 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
29 * lisp.h (enum pvec_type): Use fewer bits.
30 (PSEUDOVECTOR_SIZE_BITS): New constant.
31 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
32 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
34 (PSEUDOVECTOR_TYPEP): New macro.
35 (TYPED_PSEUDOVECTORP): Use it.
36 * fns.c (internal_equal): Adapt code to extract pvectype.
37 * emacs.c (gdb_pvec_type): Update type.
38 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
39 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
40 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
41 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
42 (sweep_vectors): Use it. Use local var `total_bytes' instead of
43 abusing vector->header.next.nbytes.
44 (live_vector_p): Use PVEC_TYPE.
45 (mark_object): Adapt code to extract pvectype. Use switch.
47 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
49 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
50 Tighten new eassert a bit.
52 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
54 Fix compilation with --enable-gcc-warnings and -O1
56 * doprnt.c (doprnt): Change type of tem to int, initialize
57 to avoid compiler warning. Add eassert.
58 * search.c (simple_search): Initialize match_byte to avoid
59 compiler warning. Add eassert.
61 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
63 Avoid weird behavior with large horizontal scrolls.
64 Without this change, for example, large hscroll values would
65 mess up Emacs's display on Fedora 15 x86, presumably due to
66 overflows in int calculations in the display code.
67 Also, if buffers had long lines, Emacs would freeze.
68 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
69 (set_window_hscroll): New function, containing the old guts of
70 Fset_window_hscroll. Return the clipped value.
71 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
72 This avoids the need to check against PTRDIFF_MAX.
74 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
76 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
78 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
80 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
82 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
83 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
84 since GCC 4.4.6 issues a bogus warning for them.
86 Fix bugs in file timestamp newness comparisons.
87 * fileio.c (Ffile_newer_than_file_p):
88 * lread.c (Fload): Use full timestamp resolution of files,
89 not just the 1-second resolution, so that files that are only
90 slightly newer still count as newer.
91 * fileio.c (Ffile_newer_than_file_p): Don't assume file
92 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
94 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
96 * fileio.c: Improve handling of file time marker. (Bug#11852)
97 (special_mtime): New function.
98 (Finsert_file_contents, Fverify_visited_file_modtime):
99 Use it to set special mtime values consistently.
101 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
103 * fileio.c (Finsert_file_contents): Properly handle st_mtime
104 marker for non-existing file. (Bug#11852)
106 2012-07-03 Glenn Morris <rgm@gnu.org>
108 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
109 and did not make it into globals.h).
111 2012-07-03 Tom Tromey <tromey@redhat.com>
113 * window.c (Fset_window_margins, Fset_window_fringes)
114 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
115 * textprop.c (Fprevious_property_change): No longer static.
116 * syntax.c (Fsyntax_table_p): No longer static.
117 * process.c (Fget_process, Fprocess_datagram_address): No longer
119 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
120 * keyboard.c (Fcommand_execute): No longer static.
122 * insdel.c (Fcombine_after_change_execute): No longer static.
123 * image.c (Finit_image_library): No longer static.
124 * fileio.c (Fmake_symbolic_link): No longer static.
125 * eval.c (Ffetch_bytecode): No longer static.
126 * editfns.c (Fuser_full_name): No longer static.
127 * doc.c (Fdocumentation_property, Fsnarf_documentation):
129 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
131 * dired.c (Ffile_attributes): No longer static.
132 * composite.c (Fcomposition_get_gstring): No longer static.
133 * callproc.c (Fgetenv_internal): No longer static.
135 * ccl.h: Remove EXFUNs.
136 * buffer.h: Remove EXFUNs.
137 * dispextern.h: Remove EXFUNs.
138 * intervals.h: Remove EXFUNs.
139 * fontset.h: Remove EXFUN.
140 * font.h: Remove EXFUNs.
141 * dosfns.c (system_process_attributes): Remove EXFUN.
142 * keymap.h: Remove EXFUNs.
143 * lisp.h: Remove EXFUNs.
144 * w32term.h: Remove EXFUNs.
145 * window.h: Remove EXFUNs.
146 * xsettings.h: Remove EXFUN.
147 * xterm.h: Remove EXFUN.
149 2012-07-03 Glenn Morris <rgm@gnu.org>
151 * lisp.h (Frandom): Make it visible to C.
152 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
153 buffer for invisible buffers. (Bug#1229)
155 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
157 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
158 values which aren't power of 2.
159 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
160 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
163 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
165 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
167 * alloc.c (mark_object): Revert part of last patch to use `switch'.
169 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
171 * alloc.c (allocate_vector_block): Remove redundant
172 calls to mallopt if DOUG_LEA_MALLOC is defined.
173 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
174 avoid calls to mallopt if zero_vector is returned.
176 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
178 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
179 is enabled, avoid dereferencing NULL current_sblock if
182 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
184 Cleanup basic buffer management.
185 * buffer.h (struct buffer): Change layout to use generic vector
186 marking code. Fix some comments. Change type of 'clip_changed'
187 to bitfield. Remove unused #ifndef old.
188 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
189 (GET_OVERLAYS_AT): Fix indentation.
190 (for_each_per_buffer_object_at): New macro.
191 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
192 (Fbuffer_local_variables): Use it.
193 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
194 * alloc.c (allocate_buffer): Adjust to match new layout of
195 struct buffer. Fix comment.
196 (mark_overlay): New function.
197 (mark_buffer): Use it. Use mark_vectorlike to mark normal
198 Lisp area of struct buffer.
199 (mark_object): Use it. Adjust marking of misc objects
200 and related comments.
202 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
204 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
205 wrapper that is not needed because the wrapped code is a no-op (zero
206 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
207 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
209 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
211 * alloc.c (mark_buffer): Simplify. Remove prototype.
212 (mark_object): Add comment. Reorganize marking of vector-like
213 objects. Use CHECK_LIVE for all vector-like objects except buffers
214 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
215 redundant calls to mark_vectorlike for bool vectors.
217 2012-06-30 Glenn Morris <rgm@gnu.org>
219 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
221 * epaths.in (PATH_SITELOADSEARCH): New.
222 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
223 This is rather than relying on --enable-locallisppath elements
224 having "site-lisp" in their names. (Bug#10208#25, 11658)
226 2012-06-30 Eli Zaretskii <eliz@gnu.org>
228 * w32proc.c (sys_select): Accept and ignore one more argument.
230 * w32.c (emacs_gnutls_pull): Call select with one more argument.
232 * sysselect.h [DOS_NT]: Don't include sys/select.h.
233 (pselect) [!MS_DOS]: Redirect to sys_select.
235 * sysdep.c: Don't include dos.h and dosfns.h.
237 * process.c (sys_select):
238 * msdos.c (sys_select): Accept one more argument and ignore it.
240 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
241 adapt data types and code to that.
244 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
245 which clashes with the gnulib function of the same name.
247 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
249 * font.c (font_style_to_value, font_style_symbolic)
250 (font_prop_validate_style): Add type checks for values in
253 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
255 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
258 2012-06-29 Eli Zaretskii <eliz@gnu.org>
260 * xdisp.c (try_window_id): Undo last change.
262 * w32.c (getwd): Adjust commentary about startup_dir.
263 (init_environment): Always call sys_access, even in non-MSVC
264 builds. Don't chdir to the directory of the Emacs executable.
265 This undoes code from 1997 which was justified by the need to
266 "avoid conflicts when removing and renaming directories". But its
267 downside was that every relative file name was being interpreted
268 relative to the directory of the Emacs executable, which can never
269 be TRT. In particular, it broke sys_access when called with
271 (sys_access): Map GetLastError to errno.
273 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
275 * window.h (struct window): Change type of 'fringes_outside_margins'
276 to bitfield. Fix comment. Adjust users accordingly.
277 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
279 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
282 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
284 * gnutls.c (emacs_gnutls_handshake):
285 Add QUIT to make the loop interruptible.
287 2012-06-29 Glenn Morris <rgm@gnu.org>
289 * charset.c (init_charset): Make lack of etc/charsets fatal.
291 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
293 * editfns.c (region_limit): Fix type mismatch.
295 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
297 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
298 undefined. Convert from xassert to eassert.
299 * nsmenu.m: Convert from xassert to eassert.
300 * nsterm.m: Likewise.
302 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
304 * editfns.c (region_limit): Clip to narrowing (bug#11770).
306 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
308 Avoid integer overflow on scroll-left and scroll-right.
309 * window.c (HSCROLL_MAX): New macro.
310 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
311 overflow when requested scroll falls outside ptrdiff_t range.
313 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
315 * window.h (struct window): Change type of 'hscroll',
316 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
317 'last_modified' and 'last_overlay_modified' to EMACS_INT.
318 Adjust users accordingly.
319 * xdisp.c (try_cursor_movement): Replace type check with eassert.
320 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
321 from EMACS_INT to ptrdiff_t.
322 (make_window): Omit redundant initialization.
324 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
326 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
328 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
330 * window.h (struct window): Change type of 'use_time' and
331 'sequence_number' from Lisp_Object to int.
332 * frame.c (make_frame): Adjust users accordingly.
333 * print.c (print_object): Likewise.
334 * window.c (select_window, Fwindow_use_time, make_parent_window)
335 (make_window): Likewise.
337 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
339 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
340 enabled with --enable-checking=[all,glyphs] configure option.
341 Fix GLYPH_DEBUG usage assuming that it may be undefined,
342 adjust comments accordingly.
343 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
344 undefined, adjust comments accordingly.
346 * scroll.c: Likewise.
347 * w32fns.c: Likewise.
348 * w32term.c: Likewise.
350 * xfaces.c: Likewise.
354 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
356 Generalize run-time debugging checks.
357 * dispextern.h (XASSERTS): Remove.
358 * fontset.c (xassert): Remove.
359 Convert from xassert to eassert.
360 * alloc.c: Convert from xassert to eassert.
362 * dispnew.c: Likewise.
364 * fringe.c: Likewise.
365 * ftfont.c: Likewise.
366 * gtkutil.c: Likewise.
368 * keyboard.c: Likewise.
370 * process.c: Likewise.
371 * scroll.c: Likewise.
374 * w32console.c: Likewise.
375 * w32fns.c: Likewise.
376 * w32term.c: Likewise.
377 * window.c: Likewise.
379 * xfaces.c: Likewise.
381 * xselect.c: Likewise.
384 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
386 * fns.c (maybe_resize_hash_table): Output message when growing the
389 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
391 * alloc.c (allocate_string_data): Remove dead code.
392 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
393 avoid GCC warning about unused macro.
395 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
397 * alloc.c (allocate_string): Omit intervals initialization.
398 * alloc.c (make_uninit_multibyte_string): Initialize intervals
399 as in make_pure_string and make_pure_c_string.
401 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
403 * alloc.c (allocate_string): Fix last change.
405 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
407 * alloc.c (allocate_string): Remove two redundant calls
408 to memset, add explicit initialization where appropriate.
410 2012-06-27 Glenn Morris <rgm@gnu.org>
412 * lisp.mk (lisp): Remove paths.elc.
414 2012-06-27 Chong Yidong <cyd@gnu.org>
416 * doc.c (Fsubstitute_command_keys): Fix punctuation.
418 2012-06-26 John Wiegley <johnw@newartisans.com>
420 * unexmacosx.c (copy_data_segment): Add two section names used
421 on Mac OS X Lion: __mod_init_func and __mod_term_func.
423 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
424 when building with Clang.
426 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
428 * eval.c (Fapply): Allow calling it with a single argument.
430 2012-06-26 Eli Zaretskii <eliz@gnu.org>
432 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
433 _stricmp and _strnicmp.
434 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
436 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
438 * alloc.c (allocate_window): Zero out non-Lisp part of newly
440 (allocate_process): Likewise for new process.
441 (allocate_terminal): Change to use offsetof.
442 (allocate_frame): Likewise.
443 * frame.c (make_frame): Omit redundant initialization.
444 * window.c (make_parent_window): Use memset.
445 (make_window): Omit redundant initialization.
446 * process.c (make_process): Omit redundant initialization.
447 * terminal.c (create_terminal): Likewise.
449 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
451 * term.c (delete_tty): Remove redundant call to memset.
453 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
455 * alloc.c: Remove build_string.
456 * lisp.h: Define build_string as static inline. This provides
457 a better opportunity to optimize away calls to strlen when the
458 function is called with compile-time constant argument.
459 * image.c (imagemagick_error): Convert to build_string.
460 * w32proc.c (sys_spawnve): Likewise.
461 * xterm.c (x_term_init): Likewise.
463 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
465 Use sprintf return value instead of invoking strlen on result.
466 In the old days this wasn't portable, since some sprintf
467 implementations returned char *. But they died out years ago and
468 Emacs already assumes sprintf returns int.
469 Similarly for float_to_string.
470 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
471 * ccl.c (ccl_driver):
472 * character.c (string_escape_byte8):
473 * data.c (Fnumber_to_string):
475 * print.c (print_object):
476 * xdisp.c (message_dolog):
477 * xfns.c (syms_of_xfns):
478 Use sprintf or float_to_string result to avoid need to call strlen.
479 * data.c (Fnumber_to_string):
480 Use make_unibyte_string, since the string must be ASCII.
481 * lisp.h, print.c (float_to_string): Now returns int length.
482 * term.c (produce_glyphless_glyph):
483 Use sprintf result rather than recomputing it.
485 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
486 * Makefile.in (ALL_CFLAGS):
487 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
488 * gmalloc.c, regex.c: Include <config.h> unconditionally.
490 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
492 * dispextern.h (xstrcasecmp): Define to library function
493 strcasecmp if available.
494 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
496 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
498 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
499 Avoid comma operator.
500 * menu.c (push_submenu_start, push_submenu_end)
501 (push_left_right_boundary, push_menu_pane): Likewise.
502 * msdos.c (dos_rawgetc): Likewise.
504 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
506 * xfns.c (xic_create_fontsetname): Remove redundant calls
509 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
511 * gtkutil.c (get_utf8_string): Remove redundant assignment.
512 sprintf already null-terminates its output.
514 * xfns.c (x_window): Remove redundant cast.
516 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
518 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
519 `const char *' to `char *' to avoid compiler warning.
521 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
523 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
524 instead of truncating it to 63 (admittedly a generous limit).
526 * process.c: Fix spelling and caps in comments.
528 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
530 * emacs.c (setpgrp): Remove definition, unused.
531 * sysdep.c (setpgrp): Remove definition, not used in this file.
533 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
535 * makefile.w32-in: Update dependencies.
537 2012-06-24 Eli Zaretskii <eliz@gnu.org>
539 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
540 (SYSTIME_H): Add nt/inc/sys/time.h.
542 * systime.h [WINDOWSNT]: Include sys/time.h.
544 * s/ms-w32.h (struct timespec): Definition moved from
545 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
547 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
549 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
550 * buffer.h (buffer_slot_type_mismatch):
551 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
552 * eval.c (unwind_to_catch):
553 * image.c (my_png_error, my_error_exit):
554 * keyboard.c (quit_throw_to_read_char, user_error)
555 (Fexit_recursive_edit, Fabort_recursive_edit):
556 * lisp.h (die, args_out_of_range, args_out_of_range_3)
557 (wrong_type_argument, buffer_overflow, __executable_start)
558 (memory_full, buffer_memory_full, string_overflow, Fthrow)
559 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
560 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
562 (child_setup) [!DOS_NT]:
563 * lread.c (end_of_file_error, invalid_syntax):
564 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
565 * puresize.h (pure_write_error):
566 * search.c (matcher_overflow):
567 * sound.c (sound_perror, alsa_sound_perror):
568 * sysdep.c, syssignal.h (croak):
569 * term.c (maybe_fatal, vfatal):
570 * textprop.c (text_read_only):
571 * undo.c (user_error):
572 * unexmacosx.c (unexec_error):
573 * xterm.c (x_ins_del_lines, x_delete_glyphs):
574 Use _Noreturn rather than NO_RETURN.
575 No need for separate decl merely because of _Noreturn.
576 * sound.c (sound_warning, parse_sound):
577 Remove unnecessary forward decls.
579 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
581 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
582 * lisp.h (WAIT_READING_MAX): New macro.
583 * dispnew.c (Fsleep_for, sit_for):
584 * keyboard.c (kbd_buffer_get_event):
585 * process.c (Faccept_process_output):
586 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
587 This improves on the previous patch, which introduced a bug
588 when time_t is unsigned and as wide as intmax_t.
589 See <http://bugs.gnu.org/9000#51>.
591 2012-06-23 Eli Zaretskii <eliz@gnu.org>
593 * dispnew.c (sit_for, Fsleep_for):
594 * keyboard.c (kbd_buffer_get_event):
595 * process.c (Faccept_process_output): Avoid compiler warnings when
596 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
598 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
600 * makefile.w32-in: Update dependencies.
602 * w32.c (ltime): Add return type and declare static.
603 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
605 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
607 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
608 Privately reported by Herbert J. Skuhra.
609 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
611 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
612 not make_lisp_timeval, when the argument is of type EMACS_TIME.
614 2012-06-23 Eli Zaretskii <eliz@gnu.org>
616 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
617 last argument of make_unibyte_string.
619 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
620 language ID in the event parameters.
622 * w32term.c (w32_read_socket): Put the new keyboard codepage into
623 event.code, not the obscure "character set ID".
625 2012-06-23 Chong Yidong <cyd@gnu.org>
627 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
629 2012-06-23 Eli Zaretskii <eliz@gnu.org>
631 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
632 * w32.c (fdutimens): New function.
634 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
636 * s/ms-w32.h (pselect): Redirect to sys_select.
638 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
640 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
641 in the logic of incrementing and decrementing the value of
642 use_relocatable_buffers.
644 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
646 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
647 Privately reported by Herbert J. Skuhra.
648 [__FreeBSD__]: Remove "*/" typo after "#include".
649 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
650 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
651 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
652 Don't assume EMACS_TIME and struct timeval are the same type.
654 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
656 Support higher-resolution time stamps (Bug#9000).
657 The time stamps are only nanosecond-resolution at the C level,
658 since that's the best that any real-world system supports now.
659 But they are picosecond-resolution at the Lisp level, as that's
660 easy, and leaves room for future OS improvements.
662 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
665 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
666 Don't get current time unless it's needed.
668 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
669 now provides it if it's absent.
670 (start_atimer): Port to higher-res time stamps.
671 Check for time stamp overflow. Don't get current time more
672 often than is needed.
674 * buffer.h (struct buffer): Buffer modtime now has high resolution.
675 Include systime.h, not time.h.
676 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
678 * dired.c: Include stat-time.h.
679 (Ffile-attributes): File times now have higher resolution.
681 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
682 (struct image): Timestamp now has higher resolution.
684 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
685 has at least microseconds now. All uses removed.
686 (update_frame, update_single_window, update_window, update_frame_1)
687 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
689 * editfns.c (time_overflow): Now extern.
690 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
691 (float-time, Fformat_time_string, Fcurrent_time_string)
692 (Fcurrent_time_zone): Accept and generate higher-resolution
694 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
695 (decode_time_components, lisp_seconds_argument): New functions.
696 (make_time): Now static.
697 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
698 Report an error if the time is invalid, rather than having the caller
701 * fileio.c: Include <stat-time.h>
702 (Fcopy_file): Copy higher-resolution time stamps.
703 Prefer to set the time stamp via a file descriptor if that works.
704 (Fset_file_times, Finsert_file_contents, Fwrite_region)
705 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
706 (Fvisited_file_modtime, Fset_visited_file_modtime):
707 Support higher-resolution time stamps.
709 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
711 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
713 * image.c (prepare_image_for_display, clear_image_cache)
714 (lookup_image): Port to higer-resolution time stamps.
716 * keyboard.c (start_polling, bind_polling_period):
717 Check for time stamp overflow.
718 (read_char, kbd_buffer_get_event, timer_start_idle)
719 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
720 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
721 Port to higher-resolution time stamps. Do not assume time_t is signed.
722 (decode_timer): New function. Timers are now vectors of length 9,
723 not 8, to accommodate the picosecond component.
724 (timer_check_2): Use it.
726 * nsterm.m (select_timeout, timeval_subtract): Remove.
727 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
728 as they're a bit more accurate and handle overflow better.
729 (ns_select): Change prototype to be compatible with pselect.
730 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
731 * nsterm.h (ns_select): Adjust prototype.
733 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
734 us-resolution time stamps.
735 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
737 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
739 * lisp.h (time_overflow): New decl.
740 (wait_reading_process_output): First arg is now intmax_t, not int,
741 to accommodate larger waits.
743 * process.h (struct Lisp_Process.read_output_delay):
744 Now counts nanoseconds, not microseconds.
745 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
747 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
748 (wait_reading_process_output):
749 Port to ns-resolution time stamps.
750 (Faccept_process_output, wait_reading_process_output):
751 Check for time stamp overflow. Do not assume time_t is signed.
752 (select_wrapper): Remove; we now use pselect.
753 (Fprocess_attributes): Now generates ns-resolution time stamps.
755 * sysdep.c: Include utimens.h. Don't include utime.h
756 or worry about struct utimbuf; gnulib does that for us now.
757 (gettimeofday): Remove; gnulib provides a substitute.
758 (make_timeval): New function.
759 (set_file_times): Now sets ns-resolution time stamps.
760 New arg FD; all uses changed.
761 (time_from_jiffies, ltime_from_jiffies, get_up_time)
762 (system_process_attributes):
763 Now returns ns-resolution time stamp. All uses changed.
764 Check for time stamp overflow.
766 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
767 provides a substitute now.
769 * systime.h: Include timespec.h rather than sys/time.h and time.h,
770 since it guarantees struct timespec.
771 (EMACS_TIME): Now struct timespec, so that we can support
772 ns-resolution time stamps.
773 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
774 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
775 (EMACS_USECS): Remove.
776 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
777 so multiply the arg by 1000 before storing it.
778 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
780 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
781 Port to ns-resolution time stamps.
782 (EMACS_TIME_NEG_P): Remove; replaced by....
783 (EMACS_TIME_SIGN): New macro.
784 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
785 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
786 (set_file_times, make_time, lisp_time_argument): Adjust signature.
787 (make_timeval, make_lisp_time, decode_time_components): New decls.
788 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
789 that it mishandled time_t overflow. You can't compare by subtracting!
790 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
791 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
793 * term.c: Include <sys/time.h>.
794 (timeval_to_Time): New function, for proper overflow wraparound.
795 (term_mouse_position, term_mouse_click): Use it.
797 * undo.c (record_first_change): Support higher-resolution time stamps
799 (Fprimitive_undo): Use them when restoring time stamps.
801 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
802 (w32_get_internal_run_time):
803 Port to higher-resolution Emacs time stamps.
804 (ltime): Now accepts single 64-bit integer, as that's more convenient
807 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
809 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
810 for compatibility with pselect. Support ns-resolution time stamps.
812 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
814 * xselect.c (wait_for_property_change, x_get_foreign_selection):
815 Check for time stamp overflow, and support ns-resolution time stamps.
817 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
818 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
819 (timeval_subtract): Remove; no longer needed.
820 (XTflash, XTring_bell, x_wait_for_event):
821 Port to ns-resolution time stamps. Don't assume time_t is signed.
823 2012-06-22 Chong Yidong <cyd@gnu.org>
825 * xdisp.c (x_consider_frame_title): Revert last change.
827 2012-06-22 Eli Zaretskii <eliz@gnu.org>
829 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
830 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
831 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
832 staticidx goes up to 1597 out of 1600 = 0x640.)
834 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
836 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
837 Otherwise, the umask might be mistakenly 0 while handling input signals.
839 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
841 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
843 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
845 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
846 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
847 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
848 access to `contents' member of Lisp_Vector objects with AREF and ASET
851 2012-06-19 Chong Yidong <cyd@gnu.org>
853 * frame.c (delete_frame): When selecting a frame on a different
854 text terminal, do not alter the terminal's top-frame.
856 * xdisp.c (format_mode_line_unwind_data): Record the target
857 frame's selected window and its terminal's top-frame.
858 (unwind_format_mode_line): Restore them.
859 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
861 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
862 since tty frames can be explicitly named.
863 (prepare_menu_bars): Likewise.
865 * term.c (Ftty_top_frame): New function.
867 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
869 Port byte-code-meter to modern targets.
870 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
871 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
872 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
873 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
874 (METER_1, METER_2): Simplify.
876 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
878 * data.c (Fdefalias): Return `symbol' (bug#11686).
880 2012-06-18 Martin Rudalics <rudalics@gmx.at>
882 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
883 gets killed during executing of this function (Bug#11665).
884 Try to always return Qt when the buffer has been actually killed.
885 (Vkill_buffer_query_functions): In doc-string say that functions
886 run by this hook should not change the current buffer.
888 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
890 Fix recently-introduced process.c problems found by static checking.
891 * process.c (write_queue_push, write_queue_pop, send_process):
892 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
893 (write_queue_pop): Fix pointer signedness problem.
894 (send_process): Remove unused local.
896 2012-06-17 Chong Yidong <cyd@gnu.org>
898 * xdisp.c (redisplay_internal): No need to redisplay terminal
899 frames that are not on top.
901 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
903 * process.c (make_process): Initialize write_queue.
904 (write_queue_push, write_queue_pop): New functions.
905 (send_process): Use them to maintain correct ordering of process
908 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
910 * lisp.h (eassert): Assume C89 or later.
911 This removes the need for CHECK.
912 (CHECK): Remove. Its comments about always evaluating its
913 argument were confusing, as 'eassert' typically does not evaluate
916 * coding.c (produce_chars): Use ptrdiff_t, not int.
918 * xterm.c (x_draw_underwave): Check for integer overflow.
919 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
921 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
923 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
924 referenced (Bug#11583).
926 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
928 Implement wave-style variant of underlining.
929 * dispextern.h (face_underline_type): New enum.
930 (face): Add field for underline type.
931 * nsterm.m (ns_draw_underwave): New function.
932 (ns_draw_text_decoration): Use it.
933 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
935 (x_draw_glyph_string): Use them.
936 * xfaces.c (Qline, Qwave): New Lisp objects.
937 (check_lface_attrs, merge_face_ref)
938 (Finternal_set_lisp_face_attribute, realize_x_face):
939 Handle wave-style underline face attributes.
940 * xterm.c (x_draw_underwave): New function.
941 (x_draw_glyph_string): Use it.
943 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
945 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
946 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
947 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
948 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
949 ($(BLD)/w32select.$(O)): Update dependencies.
951 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
953 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
954 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
955 * character.c (_fetch_multibyte_char_p): Remove.
956 * alloc.c: Include "character.h" before "buffer.h".
958 * buffer.c: Likewise.
959 * bytecode.c: Likewise.
960 * callint.c: Likewise.
961 * callproc.c: Likewise.
962 * casefiddle.c: Likewise.
963 * casetab.c: Likewise.
964 * category.c: Likewise.
966 * coding.c: Likewise.
967 * composite.c: Likewise.
969 * dispnew.c: Likewise.
971 * dosfns.c: Likewise.
972 * editfns.c: Likewise.
974 * fileio.c: Likewise.
975 * filelock.c: Likewise.
977 * fontset.c: Likewise.
978 * fringe.c: Likewise.
979 * indent.c: Likewise.
980 * insdel.c: Likewise.
981 * intervals.c: Likewise.
982 * keyboard.c: Likewise.
983 * keymap.c: Likewise.
985 * macros.c: Likewise.
986 * marker.c: Likewise.
987 * minibuf.c: Likewise.
989 * nsmenu.m: Likewise.
991 * process.c: Likewise.
993 * region-cache.c: Likewise.
994 * search.c: Likewise.
995 * syntax.c: Likewise.
997 * textprop.c: Likewise.
999 * unexsol.c: Likewise.
1000 * w16select.c: Likewise.
1001 * w32fns.c: Likewise.
1002 * w32menu.c: Likewise.
1003 * window.c: Likewise.
1004 * xdisp.c: Likewise.
1006 * xmenu.c: Likewise.
1008 * xselect.c: Likewise.
1010 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1012 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1013 If all the glyphs of the glyph row came from strings, and we have no
1014 cursor positioning clues, put the cursor on the first glyph of the
1016 (handle_face_prop): Use chunk-relative overlay string index when
1017 indexing into it->string_overlays array. (Bug#11653)
1018 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1019 the rightmost. (Bug#11720)
1021 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1023 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1024 (CATEGORY_MEMBER): Enforce 1/0 value.
1025 * category.c (_temp_category_set): Remove.
1027 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1029 * window.c (Fdelete_other_windows_internal)
1030 (Fdelete_window_internal): Don't access frame's mouse highlight
1031 info of the initial frame. (Bug#11677)
1033 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1035 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1036 Assume USE_2_TAGS_FOR_INTS.
1037 (xreload): Adjust $tagmask width to match recent lisp.h change.
1039 Simplify lisp.h in minor ways that should not affect code.
1040 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1041 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1042 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1043 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1044 (INTTYPEBITS): New macro, for clarity.
1045 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1046 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1047 Simplify now that USE_LSB_TAG is always defined.
1048 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1049 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1051 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1053 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1055 2012-06-13 Glenn Morris <rgm@gnu.org>
1057 * s/bsd-common.h (BSD4_3):
1058 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1060 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1062 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1065 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1067 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1068 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1069 * alloc.c (widen_to_Lisp_Object): Remove.
1070 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1071 * frame.c (delete_frame): Remove outdated comment.
1072 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1073 USE_LISP_UNION_TYPE.
1074 (Fw32_unregister_hot_key): Likewise.
1075 (Fw32_toggle_lock_key): Likewise.
1076 * w32menu.c (add_menu_item): Likewise.
1077 (w32_menu_display_help): Use XIL instead of checking
1078 USE_LISP_UNION_TYPE.
1079 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1080 (init_heap): Likewise.
1081 * w32term.c (w32_read_socket): Update comment.
1083 2012-06-13 Glenn Morris <rgm@gnu.org>
1085 * s/usg5-4-common.h, src/s/unixware.h:
1086 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1088 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1090 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1092 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1093 * alloc.c (make_number) [!defined make_number]:
1094 Remove, as lisp.h always defines this now.
1095 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1096 (roundup_size): Verify that it is a power of 2.
1097 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1098 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1099 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1100 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1101 USE_LSB_TAG now is always defined to be either 0 or 1.
1103 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1104 code works fine either way, and efficiency is not a concern here,
1105 as the union type is for debugging, not for production.
1106 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1107 Use an inline function on all platforms when using the union type,
1108 since this is simpler and 'static inline' can be used portably
1110 (LISP_INITIALLY_ZERO): New macro.
1111 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1112 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1114 2012-06-12 Glenn Morris <rgm@gnu.org>
1116 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1118 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1120 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1121 Move BROKEN_SIGIO to configure.
1123 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1124 Move NO_TERMIO to configure.
1126 2012-06-12 Chong Yidong <cyd@gnu.org>
1128 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1129 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1130 MagickExportImagePixels is undefined.
1132 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1134 * image.c (imagemagick_load_image): Remove unused label.
1136 2012-06-11 Glenn Morris <rgm@gnu.org>
1138 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1139 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1140 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1141 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1143 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1145 * alloc.c (make_byte_code): New function.
1146 (Fmake_byte_code): Use it. Don't purify here.
1147 * lread.c (read1): Use it as well to avoid extra allocation.
1149 2012-06-11 Chong Yidong <cyd@gnu.org>
1151 * image.c (imagemagick_load_image): Implement transparency.
1153 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1155 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1156 account for preceding backslashes. (Bug#11663)
1158 2012-06-09 Chong Yidong <cyd@gnu.org>
1160 * term.c: Support italics in capable terminals (Bug#9652).
1161 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1162 (turn_on_face): Output using TS_enter_italic_mode if available.
1163 Don't handle unused blinking and alt-charset cases.
1164 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1165 and tty_alt_charset_p cases.
1166 (tty_capable_p, init_tty): Support italics.
1168 * termchar.h (struct tty_display_info): Add field for italics.
1169 Remove unused blink field.
1171 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1174 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1175 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1176 tty_alt_charset_p. Add tty_italic_p.
1178 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1180 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1181 dbus_type_is_basic if available.
1182 (xd_extract_signed, xd_extract_unsigned): Rename from
1183 extract_signed and extract_unsigned, respectively. Adapt callers.
1185 2012-06-09 Chong Yidong <cyd@gnu.org>
1187 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1189 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1192 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1194 * xdisp.c (vmessage): Treat frame message as multibyte.
1195 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1196 would generate the diagnostic "Making \302\247 buffer-local while
1199 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1201 * dispnew.c (showing_window_margins_p): Undo last change, which
1202 was done due to an inadvertent commit.
1203 (adjust_frame_glyphs_for_frame_redisplay): Do call
1204 showing_window_margins_p.
1206 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1208 * eval.c (Fmake_var_non_special): New primitive.
1209 (syms_of_eval): Defsubr it.
1210 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1212 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1214 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1215 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1217 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1219 * alloc.c (allocate_vectorlike): Fix last change.
1221 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1223 Block-based vector allocation of small vectors.
1224 * lisp.h (struct vectorlike_header): New field `nbytes',
1225 adjust comment accordingly.
1226 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1227 to denote vector blocks. Adjust users (live_vector_p,
1228 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1229 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1230 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1231 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1232 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1233 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1234 (roundup_size): New constant.
1235 (struct vector_block): New data type.
1236 (vector_blocks, vector_free_lists, zero_vector): New variables.
1237 (all_vectors): Rename to `large_vectors'.
1238 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1239 (sweep_vectors): New functions.
1240 (allocate_vectorlike): Return `zero_vector' as the only vector of
1241 0 items. Allocate new vector from block if vector size is less than
1242 or equal to VBLOCK_BYTES_MAX.
1243 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1244 (init_alloc_once): Add call to init_vectors.
1246 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1248 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1250 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1252 * doprnt.c (doprnt): Truncate multibyte char correctly.
1253 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1254 would mishandle a string argument "Xc" if X was a multibyte
1255 character of length 2: it would truncate after X's first byte
1256 rather than including all of X.
1258 2012-06-06 Chong Yidong <cyd@gnu.org>
1260 * buffer.c (word_wrap): Doc fix.
1262 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1264 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1266 2012-06-03 Glenn Morris <rgm@gnu.org>
1268 * xdisp.c (tool-bar-style): Doc fix.
1270 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1272 * Makefile.in (PAXCTL): Define.
1273 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1274 binary via PaX flags if the paxctl utility is available.
1275 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1276 Restore PaX flags to their default. (Bug#11398)
1278 2012-06-03 Chong Yidong <cyd@gnu.org>
1280 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1283 2012-06-03 Chong Yidong <cyd@gnu.org>
1285 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1286 (note_mode_line_or_margin_highlight): If there is no help echo,
1287 use mode-line-default-help-echo. Handle the case where the mouse
1288 position is past the end of the mode line string.
1290 * buffer.c (buffer_local_value_1): New function, split from
1291 Fbuffer_local_value; can return Qunbound.
1292 (Fbuffer_local_value): Use it.
1293 (Vmode_line_format): Docstring tweaks.
1295 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1297 * sysdep.c (system_process_attributes): Improve comment.
1299 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1301 * keyboard.c: Export real-this-command to Elisp.
1302 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1303 and DEFVAR it. Update all users.
1305 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1307 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1309 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1310 Convert pctcpu and pctmem to Lisp float properly.
1311 Let the compiler fold better, as 100.0/0x8000 is exact.
1313 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1315 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1318 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1320 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1322 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1324 For a 'struct window', replace some Lisp_Object fields to
1325 bitfields where appropriate, remove unused fields.
1326 * window.h (struct window): Remove unused 'last_mark_x' and
1327 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1328 change it's type from Lisp_Object to bitfield.
1329 Change type of 'force_start', 'optional_new_start',
1330 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1331 fields from Lisp_Object to bitfield. Adjust users accordingly.
1333 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1335 Pacify gcc -Wdouble-precision when using Xaw.
1336 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1337 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1338 Use 'float' consistently, rather than 'float' in most places
1339 and 'double' in a couple of places.
1341 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1343 * xdisp.c (handle_stop): Detect whether we have overlay strings
1344 loaded by testing it->current.overlay_string_index to be
1345 non-negative, instead of checking whether n_overlay_strings is
1346 positive. (Bug#11587)
1348 2012-05-31 Chong Yidong <cyd@gnu.org>
1350 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1352 * doc.c (Fsubstitute_command_keys): Doc fix.
1354 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1356 * search.c (search_buffer): Remove calls to
1357 r_alloc_inhibit_buffer_relocation, as it is now called by
1358 maybe_unify_char, which was the cause of relocation of buffer text
1361 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1363 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1364 for the duration of call to load_charset, to avoid problems with
1365 callers of maybe_unify_char that access buffer text through C
1368 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1369 decrement the inhibition flag, instead of just setting or
1372 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1374 Remove obsolete '#define static' cruft.
1375 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1376 This #undef was "temporary" in 2000; it is no longer needed
1377 now that '#define static' has gone away.
1378 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1379 (gray_bitmap_bits): Remove; no longer needed.
1380 All uses replaced with definiens.
1381 * xterm.c: Include "bitmaps/gray.xbm".
1383 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1385 Clean up __executable_start, monstartup when --enable-profiling.
1386 The following changes affect the code only when profiling.
1387 * dispnew.c (__executable_start): Rename from safe_bcopy.
1388 Define only on platforms that need it.
1389 * emacs.c: Include <sys/gmon.h> when profiling.
1390 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1391 (__executable_start): Remove decl, since lisp.h does it now.
1392 (safe_bcopy): Remove decl; no longer has that name.
1393 (main): Coalesce #if into single bit of code, for simplicity.
1394 Cast pointers to uintptr_t, since standard libraries want integers
1396 * lisp.h (__executable_start): New decl.
1398 2012-05-31 Glenn Morris <rgm@gnu.org>
1400 * image.c (Fimagemagick_types): Doc fix.
1402 2012-05-30 Jim Meyering <meyering@redhat.com>
1404 * callproc.c (Fcall_process_region): Include directory component
1405 in mkstemp error message (Bug#11586).
1407 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1409 * alloc.c, lisp.h (make_pure_vector): Now static.
1411 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1413 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1414 Move to byte-run.el.
1415 (Fautoload): Do the hash-doc more carefully.
1416 * data.c (Fdefalias): Purify definition, except for keymaps.
1417 (Qdefun): Move from eval.c.
1418 * lisp.h (Qdefun): Remove.
1419 * lread.c (read1): Tiny simplification.
1421 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1423 Do not create empty overlays with the evaporate property (Bug#9642).
1424 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1425 Bug#9642, but explicitly check that the buffer the overlay would
1426 be moved to is live and rearrange lines to make sure that errors
1427 will not put the overlay in an inconsistent state.
1428 (Fdelete_overlay): Cosmetics.
1430 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1432 * w32term.c (my_bring_window_to_top): New function.
1433 (x_raise_frame): Use handle returned by DeferWindowPos, which
1434 could be different from the original one.
1435 Call my_bring_window_to_top instead of my_set_foreground_window.
1438 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1439 by calling BringWindowToTop.
1441 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1442 (WM_EMACS_END): Increase by one.
1444 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1446 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1447 This avoids undefined behavior that might cause the eassert
1448 to not catch an out-of-range value.
1450 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1452 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1453 Update dependencies.
1455 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1457 * bidi.c (bidi_mirror_char): Fix last change.
1459 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1461 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1462 when referring to sectname field in printf format.
1464 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1466 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1467 Only r_alloc_inhibit_buffer_relocation needed to be added;
1468 the others were already declared.
1470 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1471 before checking whether it's out of range. Put the check inside
1473 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1475 2012-05-27 Ken Brown <kbrown@cornell.edu>
1477 * callproc.c (Fcall_process): Restore a line that was accidentally
1478 commented out in the 2011-02-13 change (bug#11547).
1480 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1482 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1483 defined on ralloc.c.
1485 * buffer.c [REL_ALLOC]: Remove prototypes of
1486 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1487 they are now on lisp.h.
1489 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1491 * search.c (search_buffer): Use it to inhibit relocation of buffer
1492 text while re_search_2 is doing its job, because re_search_2 is
1493 passed C pointers to buffer text. (Bug#11519)
1495 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1498 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1499 state after an additional call to move_it_in_display_line_to, keep
1500 the values of it->max_ascent and it->max_descent found for the
1502 (pos_visible_p): Revert the comparison against bottom_y to what it
1503 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1506 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1508 Fix coding-related core dumps with gcc -ftrapv.
1509 The code was computing A - B, where A and B are pointers, and B is
1510 random garbage. This can lead to core dumps on platforms that
1511 have special pointer registers, and it also leads to core dumps on
1512 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1513 A - B only when B is initialized properly.
1514 * coding.c (coding_set_source, coding_set_destination): Return void.
1515 (coding_change_source, coding_change_destinations): New functions,
1516 with the old behaviors of coding_set_source and coding_set_destination.
1517 All callers that need an offset changed to use these new functions.
1519 2012-05-26 Glenn Morris <rgm@gnu.org>
1521 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1523 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1525 Extend mouse support on W32 text-mode console.
1526 * xdisp.c (draw_row_with_mouse_face):
1527 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1529 * w32console.c: Include window.h.
1530 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1532 (initialize_w32_display): Initialize mouse-highlight data.
1534 * w32inevt.c: Include termchar.h and window.h.
1535 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1536 moves, call note_mouse_highlight. If help_echo changed, call
1537 gen_help_event to produce help-echo message in the echo area.
1538 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1541 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1543 * lread.c (read1): Simplify slightly to avoid an overflow warning
1544 with GCC 4.7.0 on x86-64.
1546 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1548 * bidi.c (bidi_mirror_char): Revert last change: an int is
1549 definitely wide enough here.
1551 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1553 Fix integer width and related bugs (Bug#9874).
1554 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1555 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1556 (string_bytes, check_sblock, allocate_string_data):
1557 (compact_small_strings, Fmake_bool_vector, make_string)
1558 (make_unibyte_string, make_multibyte_string)
1559 (make_string_from_bytes, make_specified_string)
1560 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1561 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1564 (allocate_pseudovector):
1565 Use int, not EMACS_INT, where int is wide enough.
1566 (inhibit_garbage_collection, Fgarbage_collect):
1567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1568 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1569 int might not be wide enough.
1570 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1571 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1572 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1573 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1574 (bidi_level_of_next_char, bidi_move_to_visually_next):
1575 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1576 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1577 (Fkill_buffer, Fset_buffer_major_mode)
1578 (advance_to_char_boundary, Fbuffer_swap_text)
1579 (Fset_buffer_multibyte, overlays_at, overlays_in)
1580 (overlay_touches_p, struct sortvec, record_overlay_string)
1581 (overlay_strings, recenter_overlay_lists)
1582 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1583 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1584 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1585 (Foverlay_recenter, last_overlay_modification_hooks_used)
1586 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1587 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1588 (validate_region): Omit unnecessary test for b <= e,
1589 since that's guaranteed by the previous test.
1590 (adjust_overlays_for_delete): Avoid pos + length overflow.
1591 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1592 (report_overlay_modification):
1593 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1594 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1595 Omit pointer cast, which isn't needed anyway, and doesn't work
1596 after the EMACS_INT -> ptrdiff_t change.
1597 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1598 * buffer.h: Adjust decls to match defn changes elsewhere.
1599 (struct buffer_text, struct buffer):
1600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1601 Use EMACS_INT, not int, where int might not be wide enough.
1602 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1603 not int, to avoid needless 32-bit limit on 64-bit hosts.
1604 (exec_byte_code): Use tighter memory-full test, one that checks
1605 for alloca overflow. Don't compute the address of the object just
1606 before an array, as that's not portable. Use EMACS_INT, not
1607 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1608 * callint.c (Fcall_interactively):
1609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1610 * callproc.c (call_process_kill, Fcall_process):
1611 Don't assume pid_t fits into an Emacs fixnum.
1612 (call_process_cleanup, Fcall_process, child_setup):
1613 Don't assume pid_t fits into int.
1614 (call_process_cleanup, Fcall_process, delete_temp_file)
1615 (Fcall_process_region):
1616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1617 (Fcall_process): Simplify handling of volatile integers.
1618 Use int, not EMACS_INT, where int will do.
1619 * casefiddle.c (casify_object, casify_region, operate_on_word)
1620 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1622 (casify_object): Avoid integer overflow when overallocating buffer.
1623 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1624 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1625 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1626 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1627 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1628 integers are now checked earlier. All uses replaced with XINT.
1630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1631 For CCL_MapSingle, check that content and value are in int range.
1632 (ccl_driver, Fregister_code_conversion_map):
1633 Check that Vcode_version_map_vector is a vector.
1634 (resolve_symbol_ccl_program): Check that vector header is in range.
1635 Always copy the vector, so that we can check its contents reliably
1636 now rather than having to recheck each instruction as it's being
1637 executed. Check that vector words fit in 'int'.
1638 (ccl_get_compiled_code, Fregister_ccl_program)
1639 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1640 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1641 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1642 contents are in range.
1643 (Fccl_execute_on_string): Check that status is in range.
1644 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1645 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1646 Accept and return EMACS_INT, not int, because callers can pass values
1648 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1649 (multibyte_chars_in_text, parse_str_as_multibyte)
1650 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1651 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1652 (string_escape_byte8, Fget_byte):
1653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1654 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1655 avoid mishandling large integers.
1656 * character.h: Adjust decls to match defn changes elsewhere.
1657 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1658 (Ffind_charset_region):
1659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1660 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1661 (load_charset_map_from_vector, Fdefine_charset_internal):
1662 Don't assume fixnum fits in int.
1663 (load_charset_map_from_vector, Fmap_charset_chars):
1664 Remove now-unnecessary CHECK_NATNUMs.
1665 (Fdefine_charset_internal): Check ranges here, more carefully.
1666 Don't rely on undefined behavior with signed left shift overflow.
1667 Don't assume unsigned int fits into fixnum, or that fixnum fits
1668 into unsigned int. Don't require max_code to be a valid fixnum;
1669 that's not true for gb10830 4-byte on a 32-bit host. Allow
1670 invalid_code to be a cons, for the same reason. Require code_offset
1671 to be a character. Avoid int overflow if max_char is close
1673 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1674 this is intended anyway and avoids some undefined behavior.
1675 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1676 INDEX_TO_CODE_POINT, as that's what it expects.
1677 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1678 * charset.h (DECODE_CHAR): Return int, not unsigned;
1679 this is what was intended anyway, and it avoids undefined behavior.
1680 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1681 integer-overflow issues.
1682 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1683 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1684 where the argument is EMACS_INT, and this behavior is not intended.
1685 * chartab.c (Fmake_char_table, Fset_char_table_range)
1686 (uniprop_get_decoder, uniprop_get_encoder):
1687 Don't assume fixnum fits in int.
1688 * cmds.c (move_point): New function, that does the gist of
1689 Fforward_char and Fbackward_char, but does so while checking
1690 for integer overflow more accurately.
1691 (Fforward_char, Fbackward_char): Use it.
1692 (Fforward_line, Fend_of_line, internal_self_insert)
1693 (internal_self_insert):
1694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1695 Fix a FIXME, by checking for integer overflow when calculating
1696 target_clm and actual_clm.
1697 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1698 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1699 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1700 (coding_alloc_by_making_gap, alloc_destination)
1701 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1702 (encode_coding_utf_16, detect_coding_emacs_mule)
1703 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1704 (detect_coding_iso_2022, decode_coding_iso_2022)
1705 (encode_invocation_designation, encode_designation_at_bol)
1706 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1707 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1708 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1709 (encode_coding_ccl, encode_coding_raw_text)
1710 (detect_coding_charset, decode_coding_charset)
1711 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1712 (produce_composition, produce_charset, produce_annotation)
1713 (decode_coding, handle_composition_annotation)
1714 (handle_charset_annotation, consume_chars, decode_coding_gap)
1715 (decode_coding_object, encode_coding_object, detect_coding_system)
1716 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1717 (code_convert_region, code_convert_string)
1718 (Fdefine_coding_system_internal)
1719 (coding_set_source, coding_set_destination):
1720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1721 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1722 (Fdefine_coding_system_internal):
1723 Don't assume fixnums fit in int.
1724 (decode_coding_gap, decode_coding_object, encode_coding_object)
1725 (Fread_coding_system, Fdetect_coding_region)
1726 (Funencodable_char_position, Fcheck_coding_systems_region)
1727 (get_translation, handle_composition_annotation, consume_chars):
1728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1729 (consume_chars): Rewrite to not calculate an address outside buffer.
1730 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1731 Don't access memory outside of the args array.
1732 (Fdefine_coding_system_internal): Check for charset-id overflow.
1733 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1734 result of ENCODE_CHAR.
1735 * coding.h: Adjust decls to match defn changes elsewhere.
1736 (struct coding_system):
1737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1738 * composite.c (get_composition_id, find_composition)
1739 (run_composition_function, update_compositions)
1740 (compose_text, composition_gstring_put_cache)
1741 (composition_gstring_p, composition_gstring_width)
1742 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1743 (composition_compute_stop_pos, composition_reseat_it)
1744 (composition_update_it, struct position_record)
1745 (find_automatic_composition, composition_adjust_point)
1746 (Fcomposition_get_gstring, Ffind_composition_internal):
1747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1748 (update_compositions):
1749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1750 * composite.h: Adjust decls to match defn changes elsewhere.
1751 (struct composition):
1752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1753 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1754 Do not attempt to compute the address of the object just before a
1755 buffer; this is not portable.
1757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1758 (Faset): Use int, not EMACS_INT, where int is wide enough.
1759 (Fstring_to_number): Don't assume fixnums fit in int.
1760 (Frem): Don't assume arg is nonnegative.
1761 * dbusbind.c (xd_append_arg): Check for integers out of range.
1762 (Fdbus_call_method): Don't overflow the timeout int.
1763 (extract_signed, extract_unsigned): New functions.
1764 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1765 (xd_get_connection_references): Return ptrdiff_t, not int.
1767 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1768 (xd_read_message_1):
1769 Use int, not unsigned, where the dbus API uses int.
1770 (Fdbus_message_internal): Don't overflow mtype.
1771 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1772 * dired.c (directory_files_internal, file_name_completion, scmp)
1773 (file_name_completion_stat):
1774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1775 (file_name_completion): Don't overflow matchcount.
1776 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1777 * dispextern.h: Adjust decls to match defn changes elsewhere.
1778 (struct text_pos, struct glyph, struct bidi_saved_info)
1779 (struct bidi_string_data, struct bidi_it, struct composition_it)
1781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1782 (struct display_pos, struct composition_it, struct it):
1783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1784 * dispnew.c (increment_matrix_positions)
1785 (increment_row_positions, mode_line_string)
1786 (marginal_area_string):
1787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1788 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1790 (duration_to_sec_usec): New function, to check for overflow better.
1791 (Fsleep_for, sit_for): Use it.
1792 * doc.c (get_doc_string, store_function_docstring):
1793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1794 (get_doc_string, Fsnarf_documentation):
1795 Use int, not EMACS_INT, where int is wide enough.
1797 Use SAFE_ALLOCA, not alloca.
1798 Check for overflow when converting EMACS_INT to off_t.
1799 * doprnt.c (doprnt):
1800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1801 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1802 Don't assume uid_t fits into fixnum.
1803 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1804 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1805 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1806 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1807 (general_insert_function)
1808 (Finsert_char, make_buffer_string, make_buffer_string_both)
1809 (update_buffer_properties, Fbuffer_substring)
1810 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1811 (Fsubst_char_in_region, check_translation)
1812 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1813 (transpose_markers, Ftranspose_regions):
1814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1815 (clip_to_bounds): Move to lisp.h as an inline function).
1816 (Fconstrain_to_field): Don't assume integers are nonnegative.
1817 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1818 (Fsubst_char_in_region, Fsave_restriction):
1819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1820 (Femacs_pid): Don't assume pid_t fits into fixnum.
1821 (lo_time): Use int, not EMACS_INT, when int suffices.
1822 (lisp_time_argument): Check for usec out of range.
1823 (Fencode_time): Don't assume fixnum fits in int.
1824 (Fuser_login_name, Fuser_full_name): Signal an error
1825 if a uid argument is out of range, rather than relying on
1827 (Fformat_time_string): Remove now-unnecessary check.
1828 lisp_time_argument checks for out-of-range usec now.
1829 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1830 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1831 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1832 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1833 (init_cmdargs, Fdump_emacs):
1834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1835 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1836 the bottom (typically) 32 bits of the fixnum.
1837 * eval.c (specpdl_size, call_debugger):
1838 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1839 (when_entered_debugger, Fbacktrace_debug):
1840 Don't assume fixnum can fit in int.
1841 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1842 the object just before a buffer; this is not portable.
1843 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1844 (grow_specpdl, unbind_to):
1845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1846 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1847 (grow_specpdl): Simplify allocation by using xpalloc.
1848 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1849 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1850 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1852 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1855 (Fcopy_file, non_regular_nbytes, read_non_regular)
1856 (Finsert_file_contents):
1857 Use int, not EMACS_INT, where int is wide enough.
1858 (READ_BUF_SIZE): Verify that it fits in int.
1859 (Finsert_file_contents): Check that counts are in proper range,
1860 rather than assuming fixnums fit into ptrdiff_t etc.
1861 Don't assume fixnums fit into int.
1862 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1863 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1864 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1865 (string_char_to_byte, string_byte_to_char)
1866 (string_make_multibyte, string_to_multibyte)
1867 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1868 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1869 (substring_both, Fdelete, internal_equal, Ffillarray)
1870 (Fclear_string, mapcar1)
1871 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1872 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1873 (larger_vector, make_hash_table, maybe_resize_hash_table)
1874 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1875 (Fmaphash, secure_hash):
1876 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1877 (concat): Check for string index and length overflow.
1878 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1881 (larger_vector): New API (vec, incr_min, size_max) replaces old
1882 one (vec, new_size, init). This catches size overflow.
1883 INIT was removed because it was always Qnil.
1884 All callers changed.
1885 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1886 the upper bound on a hash table index size.
1887 (make_hash_table, maybe_resize_hash_table): Use it.
1888 (secure_hash): Computer start_byte and end_byte only after
1889 they're known to be in ptrdiff_t range.
1890 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1891 (Ffont_get_glyphs, Ffont_at):
1892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1893 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1894 (Flist_fonts, Fopen_font):
1895 Don't assume fixnum can fit in int.
1896 (check_gstring): Don't assume index can fit in int.
1897 (font_match_p): Check that fixnum is a character, not a nonnegative
1898 fixnum, since the later code needs to stuff it into an int.
1899 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1900 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1901 conversion overflow issues.
1902 (Fopen_font): Check for integer out of range.
1903 (Ffont_get_glyphs): Don't assume index can fit in int.
1904 * font.h: Adjust decls to match defn changes elsewhere.
1905 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1907 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1908 printmax_t, where ptrdiff_t is wide enough.
1909 (Finternal_char_font):
1910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1911 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1912 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1913 (Fset_frame_position, x_set_frame_parameters)
1914 (x_set_line_spacing, x_set_border_width)
1915 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1916 Check that fixnums are in proper range for system types.
1917 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1919 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1920 Use SAFE_ALLOCA_LISP, not alloca.
1921 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1922 intptr_t is wide enough.
1923 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1924 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1925 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1926 Check for fixnum out of range.
1927 * ftfont.c (ftfont_list): Don't assume index fits in int.
1928 Check that fixnums are in proper range for system types.
1929 (ftfont_shape_by_flt):
1930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1931 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1933 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1934 Check that fixnums are in proper range for system types.
1935 * gnutls.h: Adjust decls to match defn changes elsewhere.
1936 * gtkutil.c (xg_dialog_run):
1937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1938 (update_frame_tool_bar):
1939 Check that fixnums are in proper range for system types.
1940 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1941 (lookup_image): Check that fixnums are in range for system types.
1942 * indent.c (last_known_column, last_known_column_point):
1943 (current_column_bol_cache):
1944 (skip_invisible, current_column, check_display_width):
1945 (check_display_width, scan_for_column, current_column_1)
1946 (Findent_to, Fcurrent_indentation, position_indentation)
1947 (indented_beyond_p, Fmove_to_column, compute_motion):
1948 (Fcompute_motion, Fvertical_motion):
1949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1950 (last_known_column_modified): Use EMACS_INT, not int.
1951 (check_display_width):
1953 Check that fixnums and floats are in proper range for system types.
1954 (compute_motion): Don't assume index or fixnum fits in int.
1955 (compute_motion, Fcompute_motion):
1956 Use int, not EMACS_INT, when it is wide enough.
1957 (vmotion): Omit local var start_hpos that is always 0; that way
1958 we don't need to worry about overflow in expressions involving it.
1959 * indent.h: Adjust decls to match defn changes elsewhere.
1961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1962 Use int, not EMACS_INT, where int is wide enough.
1963 Remove unused members ovstring_chars_done and tab_offset;
1965 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1966 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1967 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1968 (make_gap, copy_text, insert, insert_and_inherit)
1969 (insert_before_markers, insert_before_markers_and_inherit)
1970 (insert_1, count_combining_before, count_combining_after)
1971 (insert_1_both, insert_from_string)
1972 (insert_from_string_before_markers, insert_from_string_1)
1973 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1974 (adjust_after_replace, adjust_after_insert, replace_range)
1975 (replace_range_2, del_range, del_range_1, del_range_byte)
1976 (del_range_both, del_range_2, modify_region)
1977 (prepare_to_modify_buffer, signal_before_change)
1978 (signal_after_change, Fcombine_after_change_execute):
1979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1980 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1981 (balance_an_interval, split_interval_right, split_interval_left)
1982 (find_interval, next_interval, update_interval)
1983 (adjust_intervals_for_insertion, delete_node, delete_interval)
1984 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1985 (static_offset_intervals, offset_intervals)
1986 (merge_interval_right, merge_interval_left, make_new_interval)
1987 (graft_intervals_into_buffer, temp_set_point_both)
1988 (temp_set_point, set_point, adjust_for_invis_intang)
1989 (set_point_both, move_if_not_intangible, get_property_and_range)
1990 (get_local_map, copy_intervals, copy_intervals_to_string)
1991 (compare_string_intervals, set_intervals_multibyte_1):
1992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1993 * intervals.h: Adjust decls to match defn changes elsewhere.
1995 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1996 * keyboard.c (this_command_key_count, this_single_command_key_start)
1997 (before_command_key_count, before_command_echo_length, echo_now)
1998 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1999 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2000 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2001 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2003 (last_non_minibuf_size, last_point_position, echo_truncate)
2004 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2005 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2006 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2007 (stuff_buffered_input):
2008 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2009 (last_auto_save, command_loop_1, read_char):
2010 Use EMACS_INT, not int, to avoid integer overflow.
2011 (record_char): Avoid overflow in total_keys computation.
2012 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2013 * keyboard.h: Adjust decls to match defn changes elsewhere.
2014 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2015 (Fkey_description, Fdescribe_vector, Flookup_key):
2016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2017 (click_position): New function, to check that positions are in range.
2018 (Fcurrent_active_maps):
2020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2021 (Faccessible_keymaps, Fkey_description):
2022 (preferred_sequence_p):
2023 Don't assume fixnum can fit into int.
2024 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2025 Check for integer overflow in size calculations.
2026 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2027 avoid mishandling large integers.
2028 * lisp.h: Adjust decls to match defn changes elsewhere.
2029 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2030 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2031 (struct Lisp_Marker):
2032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2033 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2034 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2035 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2036 All callers changed.
2037 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2038 Assume the arg has valid form, since it always does.
2039 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2040 unsigned integer system type.
2041 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2042 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2044 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2045 (duration_to_sec_usec): New decl.
2046 * lread.c (read_from_string_index, read_from_string_index_byte)
2047 (read_from_string_limit, readchar, unreadchar, openp)
2048 (read_internal_start, read1, oblookup):
2049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2050 (Fload, readevalloop, Feval_buffer, Feval_region):
2051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2052 (openp): Check for out-of-range argument to 'access'.
2053 (read1): Use int, not EMACS_INT, where int is wide enough.
2054 Don't assume fixnum fits into int.
2055 Fix off-by-one error that can read outside a buffer.
2056 (read_filtered_event): Use duration_to_sec_usec
2057 to do proper overflow checking on durations.
2058 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2059 in size calculation.
2060 (Fexecute_kbd_macro):
2061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2062 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2063 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2064 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2065 (set_marker_both, set_marker_restricted_both, marker_position)
2066 (marker_byte_position, Fbuffer_has_markers_at):
2067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2068 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2069 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2070 It now merely ensures that the menu is large enough, without
2071 necessarily growing it, as this avoids some integer overflow issues.
2072 All callers changed.
2073 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2075 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2076 Use SAFE_ALLOCA_LISP, not alloca.
2077 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2078 to EMACS_INT. Check that fixnums are in proper range for system types.
2079 * minibuf.c (minibuf_prompt_width, string_to_object)
2080 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2081 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2083 (get_minibuffer, read_minibuf_unwind):
2084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2085 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2086 this simplifies overflow checking. All callers changed.
2087 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2090 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2091 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2092 Check that fixnums are in proper range for system types.
2093 (Fx_create_frame, Fx_show_tip):
2094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2095 * nsfont.m (ns_findfonts, nsfont_list_family):
2096 Don't assume fixnum fits in long.
2097 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2099 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2101 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2103 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2104 (PRINTDECLARE, PRINTPREPARE):
2105 (strout, print_string):
2106 (print, print_preprocess, print_check_string_charset_prop)
2108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2110 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2112 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2113 (printchar, strout): Use xpalloc to catch size calculation overflow.
2114 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2115 (print_error_message): Use SAFE_ALLOCA, not alloca.
2116 (print_object): Use int, not EMACS_INT, where int is wide enough.
2117 (print_depth, new_backquote_output, print_number_index):
2118 Use ptrdiff_t, not int, where int might not be wide enough.
2119 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2120 (Fset_process_window_size, Fformat_network_address)
2121 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2123 Check that fixnums are in proper range for system types.
2124 (Fsignal_process): Simplify by avoiding a goto.
2125 Check for process-ids out of pid_t range rather than relying on
2127 (process_tick, update_tick): Use EMACS_INT, not int.
2128 (Fformat_network_address, read_process_output, send_process)
2129 (Fprocess_send_region, status_notify):
2130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2131 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2132 (wait_reading_process_output, read_process_output, exec_sentinel):
2133 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2134 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2135 (Faccept_process_output): Use duration_to_sec_usec to do proper
2136 overflow checking on durations.
2137 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2138 Don't assume pid_t fits in int.
2139 * process.h (struct Lisp_Process): Members tick and update_tick
2140 are now of type EMACS_INT, not int.
2141 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2142 configured --with-wide-int.
2143 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2144 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2145 * search.c (looking_at_1, string_match_1):
2146 (fast_string_match, fast_c_string_match_ignore_case)
2147 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2148 (scan_newline, find_before_next_newline, search_command)
2149 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2150 (set_search_regs, wordify):
2153 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2154 (string_match_1, search_buffer, set_search_regs):
2156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2157 (wordify): Check for overflow in size calculation.
2158 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2159 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2160 Check that fixnums are in proper range for system types.
2161 * sound.c (struct sound_device)
2162 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2164 (Fplay_sound_internal):
2165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2166 * syntax.c (struct lisp_parse_state, find_start_modiff)
2167 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2168 (Fparse_partial_sexp):
2169 Don't assume fixnums can fit in int.
2170 (struct lisp_parse_state, find_start_pos, find_start_value)
2171 (find_start_value_byte, find_start_begv)
2172 (update_syntax_table, char_quoted, dec_bytepos)
2173 (find_defun_start, prev_char_comend_first, back_comment):
2174 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2175 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2176 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2177 (Finternal_describe_syntax_value): Check that match_lisp is a
2178 character, not an integer, since the code stuffs it into int.
2179 (scan_words, scan_sexps_forward):
2180 Check that fixnums are in proper range for system types.
2182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2183 (scan_sexps_forward):
2184 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2185 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2186 * syntax.h: Adjust decls to match defn changes elsewhere.
2187 (struct gl_state_s):
2188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2189 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2190 MOST_POSITIVE_FIXNUM.
2191 * sysdep.c (wait_for_termination_1, wait_for_termination)
2192 (interruptible_wait_for_termination, mkdir):
2193 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2194 (emacs_read, emacs_write):
2195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2196 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2197 and double all fit in int.
2198 * term.c (set_tty_color_mode):
2199 Check that fixnums are in proper range for system types.
2200 * termhooks.h (struct input_event):
2201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2202 * textprop.c (validate_interval_range, interval_of)
2203 (Fadd_text_properties, set_text_properties_1)
2204 (Fremove_text_properties, Fremove_list_of_text_properties)
2205 (Ftext_property_any, Ftext_property_not_all)
2206 (copy_text_properties, text_property_list, extend_property_ranges)
2207 (verify_interval_modification):
2208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2209 (Fnext_single_char_property_change)
2210 (Fprevious_single_char_property_change):
2211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2212 (copy_text_properties):
2213 Check for integer overflow in index calculation.
2214 * undo.c (last_boundary_position, record_point, record_insert)
2215 (record_delete, record_marker_adjustment, record_change)
2216 (record_property_change):
2217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2218 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2220 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2221 (Fx_hide_tip, Fx_file_dialog):
2222 * w32menu.c (set_frame_menubar):
2223 Use ptrdiff_t, not int, for consistency with rest of code.
2224 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2225 (select_window, Fdelete_other_windows_internal)
2226 (window_scroll_pixel_based, window_scroll_line_based)
2227 (Frecenter, Fset_window_configuration):
2228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2229 (Fset_window_hscroll, run_window_configuration_change_hook)
2230 (set_window_buffer, temp_output_buffer_show, scroll_command)
2231 (Fscroll_other_window, Frecenter):
2232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2233 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2234 Don't assume fixnum fits in int.
2235 (Fset_window_scroll_bars):
2236 Check that fixnums are in proper range for system types.
2237 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2238 (string_pos, c_string_pos, number_of_chars, init_iterator)
2239 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2240 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2241 (compute_display_string_end, handle_face_prop)
2242 (face_before_or_after_it_pos, handle_invisible_prop)
2243 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2244 (display_prop_intangible_p, string_buffer_position_lim)
2245 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2246 (get_overlay_strings_1, get_overlay_strings)
2247 (iterate_out_of_display_property, forward_to_next_line_start)
2248 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2249 (get_next_display_element, set_iterator_to_next)
2250 (get_visually_first_element, compute_stop_pos_backwards)
2251 (handle_stop_backwards, next_element_from_buffer)
2252 (move_it_in_display_line_to, move_it_in_display_line)
2253 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2254 (add_to_log, message_dolog, message_log_check_duplicate)
2255 (message2, message2_nolog, message3, message3_nolog
2256 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2257 (current_message_1, truncate_echo_area, truncate_message_1)
2258 (set_message, set_message_1, store_mode_line_noprop)
2259 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2260 (text_outside_line_unchanged_p, check_point_in_composition)
2261 (reconsider_clip_changes)
2262 (redisplay_internal, set_cursor_from_row, try_scrolling)
2263 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2264 (redisplay_window, find_last_unchanged_at_beg_row)
2265 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2266 (trailing_whitespace_p, find_row_edges, display_line)
2267 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2268 (display_mode_element, store_mode_line_string)
2269 (pint2str, pint2hrstr, decode_mode_spec)
2270 (display_count_lines, display_string, draw_glyphs)
2271 (x_produce_glyphs, x_insert_glyphs)
2272 (rows_from_pos_range, mouse_face_from_buffer_pos)
2273 (fast_find_string_pos, mouse_face_from_string_pos)
2274 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2276 (safe_call, init_from_display_pos, handle_fontified_prop)
2277 (handle_single_display_spec, load_overlay_strings)
2278 (with_echo_area_buffer, setup_echo_area_for_printing)
2279 (display_echo_area, echo_area_display)
2280 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2281 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2282 (redisplay_window, dump_glyph_row, display_mode_line)
2283 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2284 (handle_display_spec, display_prop_string_p):
2285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2286 (handle_single_display_spec, build_desired_tool_bar_string)
2287 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2288 (get_specified_cursor_type):
2289 Check that fixnums are in proper range for system types.
2290 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2291 (Flookup_image_map):
2292 Don't assume fixnums fit in int.
2293 (compare_overlay_entries):
2294 Avoid mishandling comparisons due to subtraction overflow.
2295 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2296 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2297 (handle_tool_bar_click):
2298 Use int, not unsigned, since we prefer signed and the signedness
2299 doesn't matter here.
2300 (get_next_display_element, next_element_from_display_vector):
2301 Use int, not EMACS_INT, when int is wide enough.
2302 (start_hourglass): Use duration_to_sec_usec to do proper
2303 overflow checking on durations.
2304 * xfaces.c (Fbitmap_spec_p):
2305 Check that fixnums are in proper range for system types.
2306 (compare_fonts_by_sort_order):
2307 Avoid mishandling comparisons due to subtraction overflow.
2308 (Fx_family_fonts, realize_basic_faces):
2309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2311 Don't assume fixnum fits in int.
2312 Use SAFE_ALLOCA_LISP, not alloca.
2313 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2314 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2315 (face_at_buffer_position, face_for_overlay_string)
2316 (face_at_string_position):
2317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2318 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2319 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2321 Check that fixnums are in proper range for system types.
2322 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2323 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2325 (Fx_change_window_property): Don't assume fixnums fit in int.
2326 * xfont.c (xfont_chars_supported):
2327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2328 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2329 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2330 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2331 * xml.c (parse_region):
2332 * xrdb.c (magic_file_p):
2333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2334 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2335 (x_get_local_selection, x_reply_selection_request)
2336 (x_handle_selection_request, wait_for_property_change):
2337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2338 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2339 short is wide enough.
2340 (x_send_client_event): Don't assume fixnum fits in int.
2341 * xterm.c (x_x_to_emacs_modifiers):
2342 Don't assume EMACS_INT overflows nicely into int.
2343 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2345 (handle_one_xevent): NATNUMP can eval its arg twice.
2346 (x_connection_closed):
2347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2348 * xterm.h: Adjust decls to match defn changes elsewhere.
2349 (struct scroll_bar): Use struct vectorlike_header
2350 rather than rolling our own approximation.
2351 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2353 2012-05-25 Glenn Morris <rgm@gnu.org>
2355 * lisp.mk (lisp): Update for more files being compiled now.
2357 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2359 * lread.c: Remove `read_pure' which makes no difference.
2360 (read_pure): Remove var.
2361 (unreadpure): Remove function.
2362 (readevalloop): Don't call read_list with -1 flag.
2363 (read1, read_vector): Don't test read_pure any more.
2364 (read_list): Simplify.
2366 * fileio.c, character.h: Minor style tweaks.
2368 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2370 * window.h (clip_changed): Remove useless declaration.
2372 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2374 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2375 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2377 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2380 This directory predates autoconf and is no longer needed nowadays.
2381 Move its few remaining bits of functionality to where they're needed.
2382 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2383 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2384 * m/template.h: Remove.
2385 * Makefile.in (M_FILE): Remove. All uses removed.
2386 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2387 * lisp.h (USE_LSB_TAG):
2388 * mem-limits.h (EXCEEDS_LISP_PTR):
2389 Use VAL_MAX, not VALBITS, in #if.
2390 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2391 (EMACS_UINT): Define unconditionally now.
2392 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2393 (BITS_PER_EMACS_INT): New constants, replacing
2394 what used to be in config.h, but not useful in #if.
2395 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2396 define them any more.
2397 (VAL_MAX): New macro.
2399 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2400 BITS_PER_EMACS_INT, in #if.
2401 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2402 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2403 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2404 * s/ms-w32.h (DATA_START):
2405 Move here from removed file m/intel386.h.
2406 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2407 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2409 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2411 Assume C89 or later.
2412 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2413 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2415 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2416 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2417 * textprop.c, tparam.c (NULL): Remove.
2418 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2419 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2420 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2421 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2422 * xterm.c (input_signal_count): Assume volatile works.
2424 2012-05-21 Ken Brown <kbrown@cornell.edu>
2426 * xgselect.c (xg_select): Fix first argument in call to 'select'
2429 2012-05-20 Ken Brown <kbrown@cornell.edu>
2431 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2432 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2434 2012-05-19 Ken Brown <kbrown@cornell.edu>
2436 * xfns.c (x_in_use): Remove `static' qualifier.
2437 * xterm.h (x_in_use): Declare.
2438 * xgselect.c: Include xterm.h.
2439 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2440 and `display_arg' (bug#9754).
2442 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2444 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2446 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2447 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2449 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2451 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2453 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2454 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2456 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2457 reference to image_cache->refcount.
2458 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2460 2012-05-17 Juri Linkov <juri@jurta.org>
2462 * search.c (Fword_search_regexp, Fword_search_backward)
2463 (Fword_search_forward, Fword_search_backward_lax)
2464 (Fword_search_forward_lax): Move functions to isearch.el
2465 (bug#10145, bug#11381).
2467 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2469 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2471 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2473 * lread.c (init_obarray): Declare Qt and Qnil as special.
2475 2012-05-14 Glenn Morris <rgm@gnu.org>
2477 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2478 Put "libexec" before "bin", for the sake of init_callproc_1.
2480 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2482 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2484 * unexaix.c: Port to more-recent AIX compilers.
2485 (report_error, report_error_1, make_hdr, copy_sym)
2486 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2487 Make arguments const char *, not char *, to avoid violations of C
2488 standard and to fix some AIX warnings reported by Gilles Pion.
2490 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2492 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2493 already have overlays loaded.
2494 (handle_single_display_spec): Before returning without displaying
2495 fringe bitmap, synchronize the bidi iterator with the main display
2496 iterator, by calling iterate_out_of_display_property.
2497 (iterate_out_of_display_property): Detect buffer iteration by
2498 testing that it->string is a Lisp string.
2499 (get_next_display_element): When the current object is exhausted,
2500 and there's something on it->stack, call set_iterator_to_next to
2501 proceed with what's on the stack, instead of returning zero.
2502 (set_iterator_to_next): If called at the end of a Lisp string,
2503 proceed to consider_string_end without incrementing string
2504 position. Don't increment display vector index past the end of
2505 the display vector. (Bug#11417)
2506 (pos_visible_p): Don't report a position visible when move_it_to
2507 stopped at the last line of window, which happens to be scanned
2508 backwards by the bidi iteration. (Bug#11464)
2510 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2512 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2513 and right-margin display specs even if the spec is invalid or we
2514 are on a TTY, and thus unable to display on the fringes.
2515 That's because the text with the property will not be displayed anyway,
2516 so we need to signal to the caller that this is a "replacing"
2517 display spec. This fixes display when the spec is invalid or we
2520 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2522 * unexaix.c (make_hdr): Fix typo in prototype.
2523 This bug broke the build on AIX. Problem reported by Gilles Pion.
2525 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2527 * keyboard.c (kbd_buffer_get_event): Read special events also in
2528 batch mode. (Bug#11415)
2530 2012-05-12 Glenn Morris <rgm@gnu.org>
2532 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2534 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2536 * lisp.mk (lisp): Add newcomment.elc.
2538 2012-05-12 Glenn Morris <rgm@gnu.org>
2540 * Makefile.in (MKDIR_P): New, set by configure.
2541 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2543 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2545 Remove unused function hourglass_started.
2546 * dispextern.h (hourglass_started):
2547 * w32fns.c (hourglass_started):
2548 * xdisp.c (hourglass_started): Remove.
2550 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2552 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2553 Update dependencies.
2555 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2557 * xgselect.c (xg_select): Put maxfds+1 into a var.
2558 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2560 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2562 2012-05-10 Dave Abrahams <dave@boostpro.com>
2564 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2565 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2567 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2569 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2570 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2571 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2572 Initialize xd_registered_buses.
2574 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2576 Untag more efficiently if USE_LSB_TAG.
2577 This is based on a proposal by YAMAMOTO Mitsuharu in
2578 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2579 For an admittedly artificial (nth 8000 longlist) benchmark on
2580 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2581 Emacs's overall text size by 1%.
2582 * lisp.h (XUNTAG): New macro.
2583 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2584 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2585 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2586 * eval.c (Fautoload):
2587 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2588 * frame.h (XFRAME): Use XUNTAG.
2590 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2591 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2592 Remove unportable assumptions about print widths of types like
2594 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2595 intptr_t when converting between pointer and integer, to avoid GCC
2596 warnings about wrong width.
2598 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2600 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2601 stack for each reader_thread, instead of defaulting to 8MB
2602 determined by the linker. This avoids failures in creating
2603 subprocesses on Windows 7, see the discussion in this thread:
2604 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2606 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2608 Fix up display of the *Minibuf-0* buffer in the mini window.
2609 * keyboard.c (read_char): Don't clear the echo area if there's no
2611 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2612 contents of *Minibuf-0*) if there's no message displayed in its stead.
2614 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2616 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2619 2012-05-06 Chong Yidong <cyd@gnu.org>
2621 * lisp.mk (lisp): Update.
2623 2012-05-05 Jim Meyering <meyering@redhat.com>
2625 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2627 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2629 * data.c (PUT_ERROR): New macro.
2630 (syms_of_data): Use it. Add new error type `user-error'.
2631 * undo.c (user_error): New function.
2632 (Fprimitive_undo): Use it.
2633 * print.c (print_error_message): Adjust print style for `user-error'.
2634 * keyboard.c (user_error): New function.
2635 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2637 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2639 Do not limit current-time-string to years 1000..9999.
2640 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2641 (Fcurrent_time_string): Support any year that is supported by the
2642 underlying localtime representation. Don't use asctime, as it
2643 has undefined behavior for years outside the range -999..9999.
2645 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2647 Fix race conditions involving setenv, gmtime, localtime, asctime.
2648 Without this fix, interrupts could mess up code that uses these
2649 nonreentrant functions, since setting TZ invalidates existing
2650 tm_zone or tzname values, and since most of these functions return
2651 pointers to static storage.
2652 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2653 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2654 Grow the critical sections to include not just invoking
2655 localtime/gmtime, but also accessing these functions' results
2656 including their tm_zone values if any, and any related TZ setting.
2657 (format_time_string): Last arg is now struct tm *, not struct tm **,
2658 so that the struct tm is saved in the critical section.
2659 All callers changed. Simplify allocation of initial buffer, partly
2660 motivated by the fact that memory allocation needs to be outside
2661 the critical section.
2663 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2665 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2666 with RESET_INTERVAL.
2668 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2669 Remove duplicated buffer name initialization.
2671 2012-05-02 Jim Meyering <jim@meyering.net>
2673 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2675 * xfns.c (x_window): Use xstrdup (Bug#11375).
2677 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2679 * xdisp.c (pos_visible_p): If already at a newline from the
2680 display string before the 'while' loop, don't walk back the glyphs
2681 from it3.glyph_row. Solves assertion violation when the display
2682 string begins with a newline (egg.el). (Bug#11367)
2684 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2686 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2689 2012-05-01 Glenn Morris <rgm@gnu.org>
2691 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2692 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2693 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2694 All were removed before 23.1.
2696 * dispnew.c: Remove HAVE_LIBNCURSES test;
2697 it is always true on relevant platforms.
2699 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2700 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2702 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2704 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2706 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2707 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2710 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2712 Do not avoid creating empty evaporating overlays (Bug#9642).
2713 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2714 That is, do not delete an evaporating overlay if it becomes
2715 empty after its bounds are adjusted to fit within its buffer.
2716 This fix caused other problems, and I'm reverting it until we get
2717 to the bottom of them.
2719 2012-04-27 Chong Yidong <cyd@gnu.org>
2721 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2723 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2725 * xdisp.c (pos_visible_p): If the window start position is beyond
2726 ZV, start the display from buffer beginning. Prevents assertion
2727 violation in init_iterator when the minibuffer window is scrolled
2730 * window.c (window_scroll_pixel_based): Likewise.
2732 2012-04-27 Chong Yidong <cyd@gnu.org>
2734 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2736 2012-04-27 Glenn Morris <rgm@gnu.org>
2738 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2739 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2741 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2743 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2744 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2746 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2748 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2749 display element, check also the underlying string or buffer
2750 character. (Bug#11341)
2752 * w32menu.c: Include w32heap.h.
2753 (add_menu_item): If the call to AppendMenuW (via
2754 unicode_append_menu) fails, disable Unicode menus only if we are
2755 running on Windows 9X/Me.
2757 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2759 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2760 (xgetint): Add missing shift for LSB tags.
2762 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2764 * keyboard.c (read_char): Don't wipe echo area for select window
2765 events: These might get delayed via `mouse-autoselect-window'
2768 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2770 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2771 manipulation of :loaded-from data.
2773 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2775 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2776 now a cons (bug#11311).
2778 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2780 Do not create empty overlays with the evaporate property (Bug#9642).
2781 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2782 if it becomes empty after its bounds are adjusted to fit within
2783 its buffer. Without this fix, in a nonempty buffer (let ((o
2784 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2785 yields an empty overlay that has the evaporate property, which is
2786 not supposed to happen.
2788 Fix minor GTK3 problems found by static checking.
2789 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2790 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2791 (struct _EmacsFixedClass, emacs_fixed_get_type):
2792 Move decls here from emacsgtkfixed.h, since they needn't be public.
2793 (emacs_fixed_get_type): Now static.
2794 (emacs_fixed_class_init): Omit unused local.
2795 (emacs_fixed_child_type): Remove; unused.
2796 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2797 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2798 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2799 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2800 (EMACS_FIXED_GET_CLASS): Remove; unused.
2801 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2803 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2804 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2806 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2808 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2809 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2810 (__malloc_size_t, __malloc_ptrdiff_t):
2811 Remove. All uses removed, replaced by the definiens if needed,
2812 since we can assume C89 or better now.
2813 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2814 (protect_malloc_state, align, get_contiguous_space)
2815 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2816 (malloc_atfork_handler_child, malloc_enable_thread)
2817 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2818 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2819 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2820 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2821 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2822 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2823 Define using prototypes, not old style.
2824 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2825 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2826 (align): Don't assume that signed integer overflow wraps around.
2827 Omit unused local var.
2828 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2829 (_free_internal_nolock, memalign, mallochook, reallochook):
2830 Omit no-longer-needed casts.
2831 (valloc): Use getpagesize, not __getpagesize.
2832 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2833 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2835 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2837 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2839 Move functions from C to Lisp. Make non-blocking method calls
2840 the default. Implement further D-Bus standard interfaces.
2842 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2843 (QCdbus_request_name_allow_replacement)
2844 (QCdbus_request_name_replace_existing)
2845 (QCdbus_request_name_do_not_queue)
2846 (QCdbus_request_name_reply_primary_owner)
2847 (QCdbus_request_name_reply_in_queue)
2848 (QCdbus_request_name_reply_exists)
2849 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2850 (QCdbus_registered_serial, QCdbus_registered_method)
2851 (QCdbus_registered_signal): New Lisp objects.
2852 (XD_DEBUG_MESSAGE): Use sizeof.
2853 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2854 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2855 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2856 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2857 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2858 (xd_signature, xd_append_arg): Allow float for integer types.
2859 (xd_get_connection_references): New function.
2860 (xd_get_connection_address): Rename from xd_initialize.
2861 Return cached address.
2862 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2863 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2865 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2866 Return number of refcounts.
2867 (Fdbus_get_unique_name): Make stronger parameter check.
2868 (Fdbus_message_internal): New defun.
2869 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2870 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2871 (Fdbus_send_signal, Fdbus_register_service)
2872 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2873 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2874 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2875 (Vdbus_compiled_version, Vdbus_runtime_version)
2876 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2877 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2878 (Vdbus_message_type_signal): New defvars.
2879 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2882 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2884 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2885 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2886 Do not assume ptrdiff_t is the same width as 'int'.
2888 * alloc.c: Handle unusual debugging option combinations.
2889 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2890 since the two debugging options are incompatible.
2891 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2893 (mem_init, mem_insert, mem_insert_fixup):
2894 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2895 (NEED_MEM_INSERT): Remove; no longer needed.
2897 2012-04-22 Leo Liu <sdl.web@gmail.com>
2899 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2901 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2903 * sysdep.c [__FreeBSD__]: Minor cleanups.
2904 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2905 Use Emacs indenting style more consistently. Avoid some casts.
2906 Use 'double' consistently rather than mixing 'float' and 'double'.
2908 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2910 * sysdep.c (list_system_processes, system_process_attributes):
2911 Add implementation for FreeBSD (Bug#5243).
2913 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2915 * lisp.mk (lisp): Update.
2917 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2919 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2920 It is never used otherwise.
2922 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2924 * print.c (print_preprocess): Only check print_depth if print-circle
2926 (print_object): Check for cycles even when print-circle is nil and
2927 print-gensym is t, but only check print_depth if print-circle is nil.
2929 2012-04-20 Chong Yidong <cyd@gnu.org>
2931 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2932 set the status to "failed" and ensure that sentinel is run.
2934 2012-04-20 Glenn Morris <rgm@gnu.org>
2936 * process.c (Fset_process_inherit_coding_system_flag)
2937 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2938 (Fmake_network_process, Fmake_serial_process): Doc fix.
2940 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2942 * xdisp.c (string_buffer_position_lim): Limit starting position to
2944 (set_cursor_from_row): If called for a mode-line or header-line
2945 row, return zero immediately.
2946 (try_cursor_movement): If inside continuation line, don't back up
2947 farther than the first row after the header line, if any.
2948 Don't consider the header-line row as "partially visible", even if
2949 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2951 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2953 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2956 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2957 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2959 configure: new option --enable-gcc-warnings (Bug#11207)
2960 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2961 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2962 (ALL_CFLAGS): Use new macros rather than old.
2963 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2964 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2965 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2966 -Wunused-result, -Wunused-variable. This should go away once
2967 the Emacs and Gnulib regex code is merged.
2968 (xmalloc, xrealloc): Now static.
2970 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2972 * dired.c (Fsystem_groups): Remove unused local.
2974 2012-04-17 Glenn Morris <rgm@gnu.org>
2976 * dired.c (Fsystem_users): Doc fix.
2978 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2980 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2981 (syms_of_dired): Add them.
2983 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2985 Fix minor alloc.c problems found by static checking.
2986 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2987 New extern decls, to avoid calling undeclared functions.
2988 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2989 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2990 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2991 (NEED_MEM_INSERT): New macro.
2992 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2993 Remove one incorrect comment and fix another.
2995 Fix minor ralloc.c problems found by static checking.
2996 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2997 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2998 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2999 (r_alloc_sbrk): Now static.
3001 Improve ralloc.c interface checking.
3002 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3003 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3004 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3005 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3006 [REL_ALLOC]: ... to here, to check interface.
3007 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3008 Remove decls. This fixes an "It stinks!".
3010 * alloc.c (which_symbols): Fix alignment issue / type clash.
3012 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3014 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3015 (struct Lisp_Misc_Any): Likewise.
3016 (struct Lisp_Free): Likewise.
3017 * alloc.c (union aligned_Lisp_Symbol): Define.
3018 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3019 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3020 (union aligned_Lisp_Misc): Define.
3021 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3022 aligned_Lisp_Misc instead of union Lisp_Misc.
3023 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3025 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3027 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3028 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3029 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3030 * s/netbsd.h, s/sol2-6.h:
3031 Remove definition of GC_MARK_STACK, since the default now works.
3032 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3033 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3034 no longer the default.
3035 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3037 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3039 * lread.c (lisp_file_lexically_bound_p):
3040 Fix hang at ";-*-\n" (bug#11238).
3042 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3044 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3045 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3047 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3049 * nsterm.m (constrainFrameRect): Always constrain when there is only
3050 one screen (Bug#10962).
3052 2012-04-13 Ken Brown <kbrown@cornell.edu>
3054 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3056 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3058 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3060 2012-04-11 Daniel Colascione <dancol@dancol.org>
3062 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3063 against is gone. It's better to use vfork now so that when Cygwin
3064 gains a new, working vfork, we use it automatically (bug#10398).
3066 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3068 * window.c (save_window_save): Obey window-point-insertion-type.
3070 2012-04-11 Glenn Morris <rgm@gnu.org>
3072 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3074 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3076 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3078 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3080 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3081 (force_quit_count): New var.
3082 (handle_interrupt): Use it.
3084 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3086 * w32.c (w32_delayed_load): Record the full path of the library
3087 being loaded (bug#10424).
3089 2012-04-09 Glenn Morris <rgm@gnu.org>
3091 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3092 not just in the obarray, before snarfing them. (Bug#11036)
3094 * Makefile.in ($(leimdir)/leim-list.el):
3095 Pass EMACS rather than BUILT_EMACS.
3097 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3099 * process.c (make_process):
3100 * process.h: Add integer `gnutls_handshakes_tried' member to
3103 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3104 Add convenience `GNUTLS_LOG2i' macro.
3106 * gnutls.c (gnutls_log_function2i): Convenience log function.
3107 (emacs_gnutls_read): Use new log functions,
3108 `gnutls_handshakes_tried' process member, and
3109 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3110 attempts per process (connection).
3112 2012-04-09 Chong Yidong <cyd@gnu.org>
3114 * eval.c (Fuser_variable_p, user_variable_p_eh)
3115 (lisp_indirect_variable): Functions deleted.
3116 (Fdefvar): Caller changed.
3118 * callint.c (Finteractive, Fcall_interactively):
3119 * minibuf.c (Fread_variable): Callers changed.
3121 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3123 * xdisp.c (set_cursor_from_row): If the display string appears in
3124 the buffer at position that is closer to point than the position
3125 after the display string, display the cursor on the first glyph of
3126 the display string. Fixes cursor display when a 'display' text
3127 property immediately follows invisible text. (Bug#11094)
3129 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3131 composite.c: use 'double' consistently
3132 * composite.c (get_composition_id): Use 'double' consistently
3133 instead of converting 'float' to 'double' and vice versa; this is
3134 easier to understand and avoids a GCC warning.
3136 2012-04-09 Glenn Morris <rgm@gnu.org>
3138 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3139 preparation for dumping it with emacs. (Bug#4789)
3140 (leimdir): New variable.
3141 ($(leimdir)/leim-list.el): New rule.
3142 (emacs$(EXEEXT)): Depend on leim-list.el.
3144 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3145 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3146 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3148 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3150 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3153 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3155 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3156 Remove unused local variable.
3158 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3160 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3161 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3162 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3163 objects, as mark_maybe_pointer will catch them otherwise.
3164 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3165 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3167 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3169 Fix typo that broke non-Windows builds.
3170 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3172 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3174 Support building on MS-Windows with libxml2.
3176 * makefile.w32-in (OBJ2): Add xml.$(O).
3177 (GLOBAL_SOURCES): Add xml.c.
3178 ($(BLD)/xml.$(O)): New dependency list.
3180 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3181 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3182 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3183 [!WINDOWSNT]: New macros.
3184 (init_libxml2_functions, libxml2_loaded_p): New functions.
3185 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3186 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3187 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3188 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3190 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3191 Call init_libxml2_functions before calling libxml2 functions.
3192 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3194 * emacs.c: Don't include libxml/parser.h.
3195 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3196 xmlCleanupParser directly.
3198 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3200 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3202 * indent.c (Fvertical_motion): If there is a display string at
3203 point, use it.vpos to compute how many lines to backtrack after
3204 move_it_to point. (Bug#11133)
3206 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3208 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3209 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3210 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3211 macros related to unification of CJK characters. For the details,
3212 see the discussion following the message here:
3213 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3215 2012-04-04 Chong Yidong <cyd@gnu.org>
3217 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3219 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3221 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3222 instead of alloca. (Bug#11138)
3224 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3226 * w32menu.c (is_simple_dialog): Properly check lisp types.
3229 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3231 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3232 position we get to after a call to move_it_to fails the
3233 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3234 only if we wind up in a string from display property. (Bug#11063)
3236 * window.c (Fdelete_other_windows_internal): Invalidate the row
3237 and column information about mouse highlight, so that redisplay
3238 restores it after reallocating the glyph matrices. (Bug#7464)
3240 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3241 string comes from a `display' text property, use the buffer
3242 position of that property as if we actually saw that position in
3244 (move_it_by_lines): Remove the assertion that
3245 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3246 violated when there's a before-string at the beginning of a line.
3249 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3251 * xdisp.c (append_space_for_newline): If the default face was
3252 remapped, use the remapped face for the appended newline.
3253 (extend_face_to_end_of_line): Use the remapped default face for
3254 extending the face to the end of the line.
3255 (display_line): Call extend_face_to_end_of_line when the default
3256 face was remapped. (Bug#11068)
3258 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3260 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3262 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3264 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3266 2012-03-27 Glenn Morris <rgm@gnu.org>
3268 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3271 2012-03-26 Kenichi Handa <handa@m17n.org>
3273 * dispextern.h (struct glyph): Fix previous change. Change the
3274 bit length of glyphless.ch to 25 (Bug#11082).
3276 2012-03-26 Chong Yidong <cyd@gnu.org>
3278 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3279 (command_loop_1): Use it; inhibit selection update for
3280 handle-select-window too (Bug#8996).
3282 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3284 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3286 2012-03-25 Kenichi Handa <handa@m17n.org>
3288 * dispextern.h (struct glyph): Change the bit length of
3289 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3291 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3293 * s/ms-w32.h (tzname): Include time.h before redirecting to
3294 _tzname. Fixes the MSVC build. (Bug#9960)
3296 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3298 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3301 * xterm.c (XTread_socket): Only modify handling_signal if
3302 !SYNC_INPUT. (Bug#11080)
3304 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3306 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3307 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3308 when fetching a multibyte character consumes more bytes than
3309 CHAR_BYTES returns, due to unification of CJK characters in
3310 string_char. (Bug#11073)
3312 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3314 * process.c (wait_reading_process_output): Handle pty disconnect
3315 by refraining from sending oneself a SIGCHLD (bug#10933).
3317 2012-03-22 Chong Yidong <cyd@gnu.org>
3319 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3321 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3322 Mark string as coming from a prefix property.
3323 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3324 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3326 2012-03-21 Chong Yidong <cyd@gnu.org>
3328 * xfaces.c (Vface_remapping_alist): Doc fix.
3330 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3332 * w32proc.c (Fw32_set_console_codepage)
3333 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3336 2012-03-20 Chong Yidong <cyd@gnu.org>
3338 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3339 to reflect default non-nil value of redisplay-dont-pause.
3341 2012-03-19 Kenichi Handa <handa@m17n.org>
3343 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3344 it fit in a valid range (Bug#11003).
3346 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3348 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3349 that is not from display property, accept the row as a "cursor
3350 row" if one of the string's character has a non-nil `cursor'
3351 property. Fixes cursor positioning when there are newlines in
3352 overlay strings, e.g. in icomplete.el. (Bug#11035)
3354 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3356 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3358 2012-03-12 Chong Yidong <cyd@gnu.org>
3360 * eval.c (inhibit_lisp_code): Rename from
3361 inhibit_window_configuration_change_hook; move from window.c.
3363 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3364 * window.c (run_window_configuration_change_hook)
3365 (syms_of_window): Callers changed.
3367 2012-03-11 Chong Yidong <cyd@gnu.org>
3369 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3371 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3373 2012-03-10 Chong Yidong <cyd@gnu.org>
3375 * frame.c (other_visible_frames): Don't assume the selected frame
3376 is visible (Bug#10955).
3378 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3380 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3382 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3384 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3385 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3388 2012-03-03 Glenn Morris <rgm@gnu.org>
3390 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3392 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3394 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3395 position past the first glyph_row that ends at ZV. (Bug#10902)
3396 (redisplay_window, next_element_from_string): Fix typos in
3398 (redisplay_window): Pass to move_it_vertically the margin in
3399 pixels, not in screen lines.
3401 2012-03-02 Glenn Morris <rgm@gnu.org>
3403 * buffer.c (buffer-list-update-hook): Doc fix.
3405 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3407 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3408 push_it before setting up the iterator for the first overlay
3409 string, even if we have an empty string loaded.
3410 (next_overlay_string): If there's an empty string on the iterator
3411 stack, pop the stack. (Bug#10903)
3413 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3415 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3416 Suggested by Stefan Monnier in
3417 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3418 * alloc.c (widen_to_Lisp_Object): New static function.
3419 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3420 and widening them to Lisp_Objects. This would work even if
3421 USE_LSB_TAG is defined and wide integers are used, which might
3422 happen in a future version of Emacs.
3424 2012-02-25 Chong Yidong <cyd@gnu.org>
3426 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3429 * xselect.c (Fx_selection_exists_p): Doc fix.
3430 (x_clipboard_manager_save_all): Print an informative message
3431 before saving to clipboard manager.
3433 2012-02-24 Chong Yidong <cyd@gnu.org>
3435 * keyboard.c (process_special_events): Handle all X selection
3436 requests in kbd_buffer, not just the next one (Bug#8869).
3438 2012-02-23 Chong Yidong <cyd@gnu.org>
3440 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3441 call when setting menu-bar-lines and tool-bar-lines parameters.
3442 (unwind_create_frame_1): New helper function.
3444 * window.c (inhibit_window_configuration_change_hook): New var.
3445 (run_window_configuration_change_hook): Obey it.
3446 (syms_of_window): Initialize it.
3448 2012-02-22 Chong Yidong <cyd@gnu.org>
3450 * xterm.c (x_draw_image_relief): Add missing type check for
3451 Vtool_bar_button_margin (Bug#10743).
3453 2012-02-21 Chong Yidong <cyd@gnu.org>
3455 * fileio.c (Vfile_name_handler_alist): Doc fix.
3457 * buffer.c (Fget_file_buffer): Protect against invalid file
3458 handler return value.
3460 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3462 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3463 when computing $valmask.
3465 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3466 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3467 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3468 It's useless in that case, and it can cause problems on hosts
3469 that allocate halves of EMACS_INT values separately.
3470 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3471 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3472 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3473 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3474 it avoids undefined behavior on hosts where shifting right by more
3475 than the word width has undefined behavior.
3477 2012-02-19 Chong Yidong <cyd@gnu.org>
3479 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3480 (Funhandled_file_name_directory, Ffile_name_as_directory)
3481 (Fdirectory_file_name, Fexpand_file_name)
3482 (Fsubstitute_in_file_name): Protect against invalid file handler
3483 return values (Bug#10845).
3485 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3487 * .gdbinit (pitx): Fix incorrect references to fields of the
3490 2012-02-17 Chong Yidong <cyd@gnu.org>
3492 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3494 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3496 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3497 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3499 2012-02-15 Chong Yidong <cyd@gnu.org>
3501 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3502 marked as special. Also, starting docstrings with * is obsolete.
3504 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3506 * gnutls.c (emacs_gnutls_write): Fix last change.
3508 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3510 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3513 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3515 * keymap.c (Fsingle_key_description): Handle char ranges.
3517 2012-02-12 Chong Yidong <cyd@gnu.org>
3519 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3520 as that creates a dangerous corner case.
3522 * window.c (Fdelete_window_internal): Invalidate the mouse
3523 highlight (Bug#9904).
3525 2012-02-12 Glenn Morris <rgm@gnu.org>
3527 * xselect.c (Fx_own_selection_internal)
3528 (Fx_get_selection_internal, Fx_disown_selection_internal)
3529 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3530 * nsselect.m (Fx_own_selection_internal)
3531 (Fx_disown_selection_internal, Fx_selection_exists_p)
3532 (Fx_selection_owner_p, Fx_get_selection_internal):
3533 Sync docs and argument specs with the xselect.c versions.
3535 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3537 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3539 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3541 * w32select.c (Fx_selection_exists_p): Sync doc string and
3542 argument list with xselect.c. (Bug#10783)
3544 * w16select.c (Fx_selection_exists_p): Sync doc string and
3545 argument list with xselect.c. (Bug#10783)
3547 2012-02-10 Glenn Morris <rgm@gnu.org>
3549 * fns.c (Fsecure_hash): Doc fix.
3551 2012-02-09 Kenichi Handa <handa@m17n.org>
3553 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3555 2012-02-07 Chong Yidong <cyd@gnu.org>
3557 * buffer.c (Fbuffer_local_variables)
3558 (buffer_lisp_local_variables): Handle unbound vars correctly;
3559 don't let Qunbound leak into Lisp.
3561 2012-02-07 Glenn Morris <rgm@gnu.org>
3563 * image.c (Fimagemagick_types): Doc fix.
3565 * image.c (imagemagick-render-type): Change it from a lisp object
3566 to an integer. Move the doc here from the lisp manual.
3567 Treat all values not equal to 0 the same.
3569 2012-02-06 Chong Yidong <cyd@gnu.org>
3571 * doc.c (store_function_docstring): Avoid applying docstring of
3572 alias to base function (Bug#2603).
3574 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3576 * .gdbinit (pp1, pv1): Remove redundant defines.
3579 2012-02-04 Chong Yidong <cyd@gnu.org>
3581 * nsterm.m: Declare a global (Bug#10694).
3583 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3585 * w32.c (get_emacs_configuration_options):
3586 Include --enable-checking, if specified, in the return value.
3588 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3590 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3591 after rounding frame sizes. (Bug#9723)
3593 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3595 * keyboard.c (adjust_point_for_property): Don't position point
3596 before BEGV. (Bug#10696)
3598 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3600 Handle overflow when computing char display width (Bug#9496).
3601 * character.c (char_width): Return EMACS_INT, not int.
3602 (char_width, c_string_width): Check for overflow when
3603 computing the width; this is possible now that individual
3604 characters can have unbounded width. Problem introduced
3605 by merge from Emacs 23 on 2012-01-19.
3607 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3609 * dbusbind.c (Fdbus_register_method): Mention the return value
3610 :ignore in the docstring.
3612 2012-02-02 Glenn Morris <rgm@gnu.org>
3614 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3616 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3617 Unconditionally set to t. (Bug#10673)
3618 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3619 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3620 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3622 2012-02-02 Kenichi Handa <handa@m17n.org>
3624 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3625 0, do not call append_composite_glyph.
3627 2012-02-02 Kenichi Handa <handa@m17n.org>
3629 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3631 (x_produce_glyphs): If the component of a composition is a null
3632 string, set it->pixel_width to 1 to avoid zero-width glyph.
3634 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3636 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3637 first 2 arguments are identical. This makes inserting large
3638 output from a subprocess an order of magnitude faster on
3639 MS-Windows, where all sbrk'ed memory is always contiguous.
3641 2012-01-31 Glenn Morris <rgm@gnu.org>
3643 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3644 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3645 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3647 2012-01-29 Glenn Morris <rgm@gnu.org>
3649 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3651 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3653 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3655 2012-01-28 Chong Yidong <cyd@gnu.org>
3657 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3659 2012-01-26 Chong Yidong <cyd@gnu.org>
3661 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3663 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3664 repeat counts (Bug#10507).
3666 2012-01-26 Glenn Morris <rgm@gnu.org>
3668 * lread.c (syms_of_lread): Doc fix.
3670 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3672 * coding.c (encode_designation_at_bol): Change return value to
3675 2012-01-25 Chong Yidong <cyd@gnu.org>
3677 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3679 2012-01-21 Chong Yidong <cyd@gnu.org>
3681 * floatfns.c (Fcopysign): Make the second argument non-optional,
3682 since nil is not allowed anyway.
3684 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3686 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3687 (send_process): Likewise.
3689 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3691 * window.c (save_window_save, Fcurrent_window_configuration)
3692 (Vwindow_persistent_parameters): Do not use Qstate.
3693 Rewrite doc-strings.
3695 2012-01-19 Kenichi Handa <handa@m17n.org>
3697 * character.c (char_width): New function.
3698 (Fchar_width, c_string_width, lisp_string_width):
3699 Use char_width (Bug#9496).
3701 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3703 * window.c (Vwindow_persistent_parameters): New variable.
3704 (Fset_window_configuration, save_window_save): Handle persistent
3707 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3709 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3710 thrashing the stack of the thread. (Bug#9087)
3712 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3714 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3716 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3718 * xdisp.c (rows_from_pos_range): Handle the case where the
3719 highlight ends on a newline. (Bug#10464)
3720 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3721 he end column for display of highlight that ends on a newline
3724 2012-01-11 Glenn Morris <rgm@gnu.org>
3726 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3727 from load-path also when installation-directory is nil. (Bug#10208)
3729 2012-01-10 Glenn Morris <rgm@gnu.org>
3731 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3733 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3734 Update template values to be closer to their typical values these days.
3736 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3738 * xdisp.c (rows_from_pos_range): Accept additional argument
3739 DISP_STRING, and accept any glyph in a row whose object is that
3740 string as eligible for mouse highlight. Fixes mouse highlight of
3741 display strings from overlays. (Bug#10464)
3743 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3745 emacs: fix an auto-save permissions race condition (Bug#10400)
3746 * fileio.c (auto_saving_dir_umask): New static var.
3747 (Fmake_directory_internal): Use it.
3748 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3749 creating the directory. The old code temporarily assigns
3750 too-generous permissions to the directory.
3751 (do_auto_save_eh): Clear it.
3752 (Fdo_auto_save): Catch all errors, not just file errors, so
3753 that the var is always cleared.
3755 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3757 * search.c (scan_buffer): Pass character positions to
3758 know_region_cache, not byte positions. (Bug#6540)
3760 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3762 * w32.c (sys_rename): Report EXDEV when rename of a directory
3763 fails because the target is on another logical disk. (Bug#10284)
3765 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3767 * xterm.c (x_embed_request_focus): New function.
3769 * xterm.h: Add prototype.
3771 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3773 2012-01-05 Glenn Morris <rgm@gnu.org>
3775 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3777 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3779 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3780 Load gnutls_transport_set_lowat only if GnuTLS version is below
3782 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3783 GnuTLS versions below 2.11.1.
3785 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3787 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3788 to the doc string advising against its use for altering the way
3789 windows are scrolled.
3791 2011-12-28 Kenichi Handa <handa@m17n.org>
3793 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3794 coding-system ASCII compatible only when it does not produce BOM
3795 on encoding (Bug#10383).
3797 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3799 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3801 (create_and_show_popup_menu): Always use menu_position_func for
3804 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3806 * callint.c (Fcall_interactively): Don't truncate prompt string.
3808 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3810 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3811 property that ends at ZV, so that the bidi iteration could be
3812 resumed from there (after widening). (Bug#10360)
3814 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3816 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3818 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3820 * nsterm.m (x_free_frame_resources):
3821 Release f->output_data.ns->miniimage.
3822 (ns_index_color): Fix indentation. Do not retain
3823 color_table->colors[i].
3825 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3828 * nsfns.m (x_set_background_color): Assign return value from
3829 ns_index_color to face-background instead of NSColor*.
3830 (ns_implicitly_set_icon_type): Fix indentation.
3831 Change assignment in for loop to comparison.
3833 * emacs.c (ns_pool): New variable.
3834 (main): Assign ns_pool.
3835 (Fkill_emacs): Call ns_release_autorelease_pool.
3837 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3838 autorelease fdesc, release fdAttrs and tdict.
3839 (ns_get_covering_families): Release charset.
3840 (ns_findfonts): Release NSFontDescriptor created with new.
3841 (ns_uni_to_glyphs): Fix indentation.
3842 (setString): Release attrStr before assigning new value.
3844 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3846 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3848 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3849 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3851 2011-12-18 David Reitter <reitter@cmu.edu>
3853 * nsterm.m (ns_term_init): Subscribe for notifications
3854 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3855 to method trackingNotification in EmacsMenu.
3857 * nsmenu.m (trackingMenu): New variable.
3858 (trackingNotification): New method (from Aquamacs).
3859 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3860 from Aquamacs (Bug#7030).
3862 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3864 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3865 (symbol_to_nsstring): Fix indentation.
3866 (ns_symbol_to_pb): New function.
3867 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3868 (Fns_rotate_cut_buffers_internal): Remove.
3869 (Fns_store_selection_internal): Rename from
3870 Fns_store_cut_buffer_internal.
3871 (ns_get_foreign_selection, Fx_own_selection_internal)
3872 (Fx_disown_selection_internal, Fx_selection_exists_p)
3873 (Fns_get_selection_internal, Fns_store_selection_internal):
3874 Use ns_symbol_to_pb and check if return value is nil.
3875 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3876 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3877 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3878 renamed to Sns_store_selection_internal.
3879 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3880 and remove this function.
3881 (ns_handle_selection_clear): Remove, never used.
3882 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3885 2011-12-17 Ken Brown <kbrown@cornell.edu>
3887 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3888 GID is unknown (Bug#10257).
3890 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3892 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3893 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3894 which caused a build failure on GNU/Linux IA-64. This problem was
3895 introduced by my 2011-10-07 patch.
3897 2011-12-15 Juri Linkov <juri@jurta.org>
3899 * image.c (imagemagick_error): New function. (Bug#10112)
3900 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3901 Use `imagemagick_error' where ImageMagick functions return
3903 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3906 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3908 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3909 fill background (Bug#8992).
3911 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3913 * window.c (Vwindow_combination_resize)
3914 (Vwindow_combination_limit): Use t instead of non-nil in
3916 (Vrecenter_redisplay): Add first sentence of doc-string on
3918 (Frecenter): Fix doc-string typo.
3920 2011-12-11 Kenichi Handa <handa@m17n.org>
3922 * coding.c (Funencodable_char_position): Pay attention to the
3923 buffer text relocation (Bug#9389).
3925 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3927 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3928 gtk_init (Bug#10100).
3930 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3932 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3933 IT->string is nil. (Bug#10263)
3935 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3937 * nsterm.h (x_free_frame_resources): Declare.
3939 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3940 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3942 * nsterm.h (ns_get_defaults_value): Declare.
3944 * nsterm.m (ns_default): Call ns_get_defaults_value.
3946 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3948 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3951 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3953 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3954 that where the value of an _OBJC_* symbol points to is in the .bss
3955 section (Bug#10240).
3957 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3959 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3960 after the loop to call ccl_driver at least once (Bug#8619).
3962 2011-12-08 Kenichi Handa <handa@m17n.org>
3964 * ftfont.c (get_adstyle_property): Fix previous change
3967 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3969 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3970 dirs from the default value of EMACSLOADPATH (bug#10208).
3972 2011-12-07 Glenn Morris <rgm@gnu.org>
3974 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3975 installation and source directories as well. (Bug#10208)
3977 2011-12-06 Chong Yidong <cyd@gnu.org>
3979 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3981 2011-12-06 Glenn Morris <rgm@gnu.org>
3983 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3984 as an error, not just -1. (Bug#10217)
3986 2011-12-05 Chong Yidong <cyd@gnu.org>
3988 * keyboard.c (process_special_events): New function.
3989 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3991 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3993 * coding.c (encode_designation_at_bol): Don't use uninitialized
3994 local variable (Bug#9318).
3996 2011-12-05 Kenichi Handa <handa@m17n.org>
3998 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3999 return Qnil (Bug#8046, Bug#10193).
4001 2011-12-05 Kenichi Handa <handa@m17n.org>
4003 * coding.c (encode_designation_at_bol): New args charbuf_end and
4004 dst. Return the number of produced bytes. Callers changed.
4005 (coding_set_source): Return how many bytes coding->source was
4007 (coding_set_destination): Return how many bytes
4008 coding->destination was relocated.
4009 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4010 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4012 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4014 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4015 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4018 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4020 The following changes are to fix Bug#9318.
4022 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4023 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4024 (encode_coding_iso_2022, encode_coding_sjis)
4025 (encode_coding_big5, encode_coding_charset): Use the above macros.
4027 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4029 * lisp.h (process_quit_flag): Fix external declaration.
4031 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4033 Don't macro-inline non-performance-critical code.
4034 * eval.c (process_quit_flag): New function.
4035 * lisp.h (QUIT): Use it.
4037 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4039 * nsfns.m (get_geometry_from_preferences): New function.
4040 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4042 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4044 * emacs.c (Qkill_emacs): Define.
4045 (syms_of_emacs): Initialize it.
4046 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4047 Qquit_flag to `kill-emacs' instead.
4048 (quit_throw_to_read_char): Add parameter `from_signal'.
4049 All callers changed. Call Fkill_emacs if requested and safe.
4050 * lisp.h (QUIT): Call Fkill_emacs if requested.
4052 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4054 * widget.c (update_wm_hints): Return if wmshell is null.
4055 (widget_update_wm_size_hints): New function.
4057 * widget.h (widget_update_wm_size_hints): Declare.
4059 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4060 widget_update_wm_size_hints (Bug#10104).
4062 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4064 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4065 before a newline, prepare the bidi iterator for consuming the
4066 newline, and keep the current paragraph direction. (Bug#10183)
4067 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4069 2011-12-02 Juri Linkov <juri@jurta.org>
4071 * search.c (Fword_search_regexp): New Lisp function created from
4072 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4073 (Fword_search_backward, Fword_search_forward)
4074 (Fword_search_backward_lax, Fword_search_forward_lax):
4075 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4076 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4078 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4080 * fileio.c (Finsert_file_contents): Move after-change-function call
4081 to before the "handled:" label, since all "goto handled" appear in
4082 cases where the *-change-functions have already been properly called
4085 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4087 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4088 waiting for input. (Bug#10169)
4090 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4092 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4093 verifies glyph row's hash code--we have just reallocated the
4094 glyphs, so their contents can be complete garbage. (Bug#10164)
4096 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4098 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4100 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4102 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4103 attributes are tested _before_ calling verify_row_hash, to protect
4104 against GCC re-ordering of the tests. (Bug#10164)
4106 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4108 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4110 * xterm.c (handle_one_xevent): Only set async_visible and friends
4111 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4112 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4113 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4115 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4117 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4118 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4119 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4120 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4121 All uses changed to use GCPRO1 etc.
4122 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4123 Revert to old implementation (i.e., before 2011-03-11).
4125 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4127 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4128 of scroll runs so as to avoid assigning disabled bogus rows and
4129 unnecessary graphics copy operations.
4131 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4133 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4134 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4135 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4136 (malloc, free, realloc, calloc): Redirect to e_* only when
4139 * lisp.h (GCTYPEBITS): Move before first use.
4140 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4141 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4142 this macro definition.
4144 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4147 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4149 * gtkutil.c (xg_create_frame_widgets):
4150 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4151 present with Gtk+ 2.0.
4153 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4155 * fileio.c (Finsert_file_contents): Undo previous change; see
4156 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4158 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4160 Rename locals to avoid shadowing.
4161 * fileio.c (Finsert_file_contents):
4162 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4163 * process.c (wait_reading_process_output):
4164 Rename inner 'proc' to 'p' to avoid shadowing.
4165 Indent for consistency with usual Emacs style.
4167 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4169 * xdisp.c (redisplay_window): If cursor row is not fully visible
4170 after recentering, and scroll-conservatively is set to a large
4171 number, scroll window by a few more lines to make the cursor fully
4172 visible and out of scroll-margin. (Bug#10105)
4173 (start_display): Don't move to the next line if the display should
4174 start at a newline that is part of a display vector or an overlay
4177 2011-11-24 Juri Linkov <juri@jurta.org>
4179 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4180 after the `MagickPingImage' call. (Bug#10112)
4182 2011-11-23 Chong Yidong <cyd@gnu.org>
4184 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4186 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4188 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4189 making another buffer current. (Bug#10114)
4191 2011-11-23 Glenn Morris <rgm@gnu.org>
4193 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4195 2011-11-23 Chong Yidong <cyd@gnu.org>
4197 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4198 using it (Bug#5984).
4200 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4202 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4203 and header-lines, as they don't have one computed for them.
4206 * .gdbinit (prow): Make displayed values more self-explaining.
4207 Add row's hash code.
4209 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4211 * process.c (wait_reading_process_output): Fix asynchrounous
4212 GnuTLS socket handling on some versions of the GnuTLS library.
4213 (wait_reading_process_output): Add comment and URL.
4215 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4217 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4219 2011-11-21 Chong Yidong <cyd@gnu.org>
4221 * window.c (Fnext_window, Fprevious_window): Doc fix.
4223 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4225 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4227 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4229 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4231 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4233 * window.c (Fset_window_combination_limit): Rename argument
4235 (Vwindow_combination_limit): Remove "status" from doc-string.
4237 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4239 * m/ibms390.h: Remove.
4240 * m/ibms390x.h: Don't include "ibms390.h".
4242 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4244 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4245 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4247 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4249 * casetab.c (Fset_case_table):
4250 * charset.c (Fcharset_after): Fix typos.
4252 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4254 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4255 Otherwise, valgrind does not work on some platforms.
4256 Problem reported by Andreas Schwab in
4257 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4258 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4259 is set, removing the need for VIRT_ADDRESS_VARIES.
4260 (PURE_P): Use a more-efficient implementation that needs just one
4261 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4262 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4263 to 4 (xorl, subq, cmpq, setbe).
4264 * alloc.c (pure): Always extern now, since that's the
4265 VIRT_ADDR_VARIES behavior.
4266 (PURE_POINTER_P): Use a single comparison, not two, for
4267 consistency with the new puresize.h.
4268 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4269 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4270 Remove VIRT_ADDR_VARIES no longer needed.
4272 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4274 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4275 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4276 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4277 behave as if the cursor position were at the window margin.
4279 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4280 and the cursor position is out of bounds, behave as if the cursor
4281 position were at the window margin. (Bug#10075)
4283 2011-11-18 Chong Yidong <cyd@gnu.org>
4285 * window.c (Fwindow_combination_limit): Make first argument
4286 non-optional, since it is meaningless for live windows like the
4289 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4291 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4293 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4295 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4296 (graft_intervals_into_buffer): Simplify.
4298 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4300 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4301 hash values of the two rows.
4302 (copy_row_except_pointers): Preserve the used[] arrays and the
4303 hash values of the two rows. (Bug#10035)
4304 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4306 * xdisp.c (row_hash): New function, body extracted from
4307 compute_line_metrics.
4308 (compute_line_metrics): Call row_hash, instead of computing the
4311 * dispnew.c (verify_row_hash): Call row_hash for computing the
4312 hash code of a row, instead of duplicating code from xdisp.c.
4314 * dispextern.h (row_hash): Add prototype.
4316 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4318 * frame.c (delete_frame): Don't delete the terminal when the last
4319 X frame is closed if emacs is built with GTK toolkit.
4321 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4323 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4325 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4327 * window.c (Vwindow_splits): Rename to
4328 Vwindow_combination_resize. Suggested by Juri Linkov.
4329 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4332 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4334 * nsfns.m (Fns_font_name):
4335 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4337 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4339 * window.h (window): Rename slot "nest" to "combination_limit".
4340 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4341 (Fset_window_nest): Rename to Fset_window_combination_limit.
4342 (Vwindow_nest): Rename to Vwindow_combination_limit.
4343 (recombine_windows, make_parent_window, make_window)
4344 (Fsplit_window_internal, saved_window)
4345 (Fset_window_configuration, save_window_save): Rename all
4346 occurrences of window_nest to window_combination_limit.
4348 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4350 * image.c (imagemagick_load_image): Fix typo.
4352 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4354 * xdisp.c (display_line): Move the call to
4355 highlight_trailing_whitespace before the call to
4356 compute_line_metrics, since the latter needs to see the final
4357 faces of all the glyphs to compute ROW's hash value.
4358 Fixes assertion violations in row_equal_p. (Bug#10035)
4360 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4362 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4363 just return (bug#10044).
4365 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4367 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4368 with user-defined heap size. Bump the default size of the temacs
4369 heap to 27MB, to avoid memory warning when running temacs.
4370 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4372 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4373 current_matrix and desired_matrix. (Bug#9990)
4374 (verify_row_hash) [XASSERTS]: New function.
4375 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4376 that the hash value of glyph rows is correct.
4378 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4380 * window.h (window): Remove splits slot.
4381 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4382 (Fdelete_other_windows_internal, make_parent_window)
4383 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4384 (Fset_window_configuration, save_window_save): Don't deal with
4385 split status of windows.
4386 (saved_window): Remove splits slot.
4387 (Vwindow_splits): Rewrite doc-string.
4389 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4391 * xfns.c (unwind_create_frame):
4392 * nsfns.m (unwind_create_frame):
4393 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4394 Vframe_list (Bug#9999).
4396 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4398 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4400 2011-11-11 Kenichi Handa <handa@m17n.org>
4402 * callproc.c (Fcall_process): Set the member dst_multibyte of
4405 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4407 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4408 avoid a crash (bug#9496).
4410 2011-11-09 Chong Yidong <cyd@gnu.org>
4412 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4413 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4415 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4417 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4419 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4421 Avoid some portability problems by eschewing 'extern inline' functions.
4422 The trivial performance wins aren't worth the portability hassles; see
4423 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4425 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4426 (window_box_width, window_box_left, window_box_left_offset)
4427 (window_box_right, window_box_right_offset): Undo previous change,
4428 by removing the "extern"s.
4429 * intervals.c (adjust_intervals_for_insertion)
4430 (adjust_intervals_for_deletion): Undo previous change,
4431 making these static again.
4432 (offset_intervals, temp_set_point_both, temp_set_point)
4433 (copy_intervals_to_string): No longer inline.
4434 * xdisp.c (window_text_bottom_y, window_box_width)
4435 (window_box_height, window_box_left_offset)
4436 (window_box_right_offset, window_box_left, window_box_right)
4437 (window_box): No longer inline.
4439 2011-11-08 Chong Yidong <cyd@gnu.org>
4441 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4442 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4443 Signal an error if not a live window.
4444 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4445 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4447 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4449 * lisp.h (syms_of_abbrev): Remove declaration.
4450 Reported by CHENG Gao <chenggao@royau.me>.
4452 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4454 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4455 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4456 of temacs in GUI mode.
4458 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4460 * window.h: Declare delete_all_child_windows instead of
4461 delete_all_subwindows.
4462 * window.c (Fwindow_nest, Fset_window_nest)
4463 (Fset_window_new_total, Fset_window_new_normal)
4464 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4465 (delete_all_subwindows): Rename to delete_all_child_windows.
4466 (Fdelete_other_windows_internal, Fset_window_configuration):
4467 Call delete_all_child_windows instead of delete_all_subwindows.
4468 * frame.c (delete_frame): Call delete_all_child_windows instead
4469 of delete_all_subwindows.
4471 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4473 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4474 This is also needed for porting to any host where GC_MARK_STACK is
4475 not GC_MAKE_GCPROS_NOOPS.
4476 (which_symbols): Use it.
4478 2011-11-07 Kenichi Handa <handa@m17n.org>
4480 * coding.c (coding_set_destination): Check coding->src_pos only
4481 when coding->src_object is a buffer (bug#9910).
4483 * process.c (send_process): Set the member src_multibyte of coding
4484 to 0 (bug#9911) when sending a unibyte text.
4486 * callproc.c (Fcall_process): Set the member src_multibyte of
4487 process_coding to 0 (bug#9912).
4489 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4491 * xmenu.c (cleanup_widget_value_tree): New function.
4492 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4493 calling free_menubar_widget_value_tree directly (Bug#9830).
4495 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4497 Fix some portability problems with 'inline'.
4498 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4499 (window_box_width, window_box_left, window_box_left_offset)
4500 (window_box_right, window_box_right_offset): Declare extern.
4501 Otherwise, these inline functions do not conform to C99 and
4502 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4503 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4504 * intervals.c (adjust_intervals_for_insertion)
4505 (adjust_intervals_for_deletion): Now extern, because otherwise the
4506 extern inline functions 'offset_intervals' couldn't refer to it.
4507 (static_offset_intervals): Remove.
4508 (offset_intervals): Rewrite using the old contents of
4509 static_offset_intervals. The old version didn't conform to C99
4510 because an extern inline function contained a reference to an
4511 identifier with static linkage.
4513 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4515 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4518 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4520 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4521 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4522 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4523 return Qleft_to_right.
4525 2011-11-06 Chong Yidong <cyd@gnu.org>
4527 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4528 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4529 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4530 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4531 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4532 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4533 (Fwindow_vscroll): Doc fix.
4534 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4535 argument, since it makes no sense to pass a live window and for
4536 consistency with window-child.
4538 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4540 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4543 2011-11-05 Jason Rumney <jasonr@gnu.org>
4545 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4546 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4548 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4549 bitwise arithmetic preventing use of unicode-sip and non-truetype
4552 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4554 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4557 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4558 initialization code to keep similarity to xfns.c after changes
4561 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4563 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4564 (unwind_create_frame): New function (Bug#9943).
4565 (Fx_create_frame): Restructure code to be more similar to the one in
4566 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4567 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4568 Move terminal->reference_count++ just before making the frame official
4571 * nsterm.m (x_free_frame_resources): New function.
4572 (x_destroy_window): Move code to x_free_frame_resources.
4574 * xfns.c (unwind_create_frame): Fix comment.
4575 (Fx_create_frame, x_create_tip_frame):
4576 Move terminal->reference_count++ just before making the frame
4577 official. Move initialization of image_cache_refcount and
4578 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4580 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4582 Support MSVC build with newer versions of Visual Studio.
4583 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4584 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4587 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4588 which are not supported by MSVC.
4589 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4590 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4592 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4594 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4596 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4598 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4600 Support MSVC build with newer versions of Visual Studio.
4601 * w32.c: Don't include w32api.h for MSVC.
4602 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4604 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4605 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4606 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4607 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4609 (alloca) [_MSC_VER]: Define to _alloca.
4611 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4613 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4615 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4617 * xdisp.c (note_mouse_highlight): If either of
4618 previous/next-single-property-change returns nil, treat that as
4619 the beginning or the end of the buffer. (Bug#9955)
4621 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4623 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4624 label is not null (Bug#9951).
4625 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4628 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4630 * window.c (Fwindow_body_size): Mention in the doc string that the
4631 return value is in frame's canonical units. (Bug#9949)
4633 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4635 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4637 * w32fns.c (unwind_create_frame): If needed, free the glyph
4638 matrices of the partially constructed frame. (Bug#9943)
4639 * xfns.c (unwind_create_frame): Likewise.
4641 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4643 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4644 Don't stop backward scan on the continuation glyph, even though
4645 its CHARPOS is positive.
4646 (mouse_face_from_buffer_pos, note_mouse_highlight):
4647 Rename cover_string to disp_string.
4649 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4651 * window.c (temp_output_buffer_show): Don't use
4652 Vtemp_buffer_show_specifiers.
4653 (Vtemp_buffer_show_specifiers): Remove unused variable.
4655 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4657 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4658 past the beginning of the current glyph matrix.
4660 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4662 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4663 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4664 HAVE_GTK3 (Bug#9869).
4666 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4667 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4669 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4671 * xterm.c: Declare x_handle_net_wm_state to return int.
4672 (handle_one_xevent): Check if we are iconified but don't have
4673 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4674 (get_current_wm_state): Return non-zero if not hidden,
4675 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4676 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4677 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4678 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4680 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4682 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4683 so that this new function doesn't get optimized away by a
4684 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4686 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4688 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4690 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4692 Fix the `xbytecode' command.
4693 * .gdbinit (xprintbytestr): New command.
4694 (xwhichsymbols): Rename from `which'; all callers changed.
4695 (xbytecode): Print the byte-code string as well.
4697 2011-10-29 Kim Storm <storm@cua.dk>
4699 * alloc.c (which_symbols): New function.
4701 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4703 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4706 2011-10-29 Glenn Morris <rgm@gnu.org>
4708 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4709 Not clear what it was for, and it causes various bugs. (Bug#9839)
4711 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4713 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4714 possible random value that matches one of those tested as
4715 condition to clear the mouse face.
4717 2011-10-28 Chong Yidong <cyd@gnu.org>
4719 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4721 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4723 * window.c (make_window): Initialize phys_cursor_on_p.
4725 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4727 * lisp.h (struct Lisp_Symbol): Update comments.
4729 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4731 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4733 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4735 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4736 <oslsachem@gmail.com> for helping to debug this.
4738 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4739 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4740 (g_b_init_get_glyph_outline_w): New static variables.
4741 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4742 (GetGlyphOutlineW_Proc): New typedefs.
4743 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4744 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4746 (w32font_open_internal, compute_metrics):
4747 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4748 instead of calling the "wide" APIs directly.
4750 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4752 * w32.h (syms_of_w32font): Add prototype.
4754 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4756 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4757 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4758 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4759 (Fmove_to_window_line): Doc fix.
4761 2011-10-27 Chong Yidong <cyd@gnu.org>
4763 * process.c (make_process): Set gnutls_state to NULL.
4765 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4766 non-NULL, regardless of GNUTLS_INITSTAGE.
4767 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4768 an error. Set process slots as soon as we allocate them.
4770 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4772 2011-10-27 Chong Yidong <cyd@gnu.org>
4774 * gnutls.c (emacs_gnutls_deinit): New function.
4775 Deallocate credentials structures as well as calling gnutls_deinit.
4776 (Fgnutls_deinit, Fgnutls_boot): Use it.
4778 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4779 (deactivate_process): Call emacs_gnutls_deinit.
4781 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4783 * image.c (x_create_x_image_and_pixmap):
4784 * w32.c (sys_rename, w32_delayed_load):
4785 * w32font.c (fill_in_logfont):
4786 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4788 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4790 * w32fns.c (w32_default_color_map): New function,
4791 extracted from Fw32_default_color_map.
4792 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4794 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4796 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4798 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4800 * keyboard.c (test_undefined): New function (bug#9751).
4801 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4803 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4805 * sysdep.c (init_sys_modes): Fix the check for the controlling
4806 terminal (Bug#6649).
4808 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4810 * dispextern.h (struct bidi_it): New member next_en_type.
4812 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4813 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4814 current character, check also for next_en_type being WEAK_EN.
4815 (bidi_resolve_weak): Don't enter the expensive loop if the current
4816 position is before next_en_pos. Record the bidi type of the first
4817 non-ET, non-BN character we find, in addition to its position.
4818 (bidi_level_of_next_char): Invalidate next_en_type when
4819 next_en_pos is over-stepped.
4821 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4823 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4824 * editfns.c: Rewrite current-time-zone so that it invokes
4825 the equivalent of (format-time-string "%Z") to get the time zone name.
4826 This fixes a bug when the time zone name contains characters that
4827 need converting from the system time locale to Emacs internal format.
4828 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4829 that patch fixed format-time-string to do the conversion, but
4830 I forgot to fix current-time-zone.
4831 (format_time_string): New function, containing most of
4832 what Fformat_time_string used to contain.
4833 (Fformat_time_string): Rewrite in terms of format_time_string.
4834 This doesn't change this function's behavior.
4835 (current-time-zone): Rewrite to use format_time_string.
4836 This fixes the bug reported by Michael Schierl in
4837 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4838 Jason Rumney's 2007-06-07 change worked around this bug, but
4840 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4842 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4844 * xdisp.c (start_display): If the character at POS is displayed
4845 via a display vector, reset IT->current.dpvec_index to zero.
4846 (try_window_reusing_current_matrix): If a line ends in a display
4847 vector or the next line starts in a display vector, continue
4848 redrawing the window even though the character position of
4849 start_row was reached.
4852 2011-10-18 Chong Yidong <cyd@gnu.org>
4854 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4855 with nobreak-char-display too.
4857 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4859 Fix part 3 of bug#9771.
4860 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4861 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4862 non-neutral characters if the current character is a paragraph
4863 separator (a.k.a. Newline). This avoids running the same
4864 expensive loop twice, once when we consume the preceding newline
4865 and the other time when the line actually needs to be displayed.
4866 Avoid the loop when we see neutrals on the base embedding level
4867 following a character whose directionality is the same as the
4868 paragraph's. This avoids running the expensive loop when a line
4869 ends in a long sequence of neutrals, like control characters.
4870 Add assertion against STRONG_AL type. Slightly rearrange code
4871 that determines the type of a neutral given the first non-neutral
4873 (bidi_level_of_next_char): Set next_en_pos to zero when
4874 invalidating its info.
4876 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4878 * xdisp.c (push_display_prop): Determine whether to record string
4879 or buffer position by IT->string, not by IT->method. Allow
4880 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4881 (move_it_vertically_backward): Don't look for character position
4882 immediately after the newline when in a continuation line.
4885 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4887 * window.c (coordinates_in_window): Rewrite and delabelize
4888 vertical border check. (Bug#5357) (Bug#9618)
4890 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4892 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4893 errors in XSetWindowBorder (bug#9310).
4895 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4897 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4898 avoid crash when xmalloc overrun checking is enabled.
4900 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4902 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4903 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4904 cursor motion with <left> and <right> arrow keys.
4906 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4907 some callers set that themselves.
4909 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4911 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4912 display string and the previous row comes from the same string and
4913 is empty. (Bug#9739) (Bug#9738)
4915 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4917 * doc.c (get_doc_string): Encode file name (bug#9735).
4919 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4921 * bidi.c (bidi_level_of_next_char):
4922 * xdisp.c (get_visually_first_element): Remove old incorrect
4923 comments regarding the Unicode Line Separator character.
4925 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4927 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4929 * alloc.c (Fgc_status): Do not access beyond zombies array
4930 boundary if nzombies > MAX_ZOMBIES.
4931 * alloc.c (dump_zombies): Add missing format specifier.
4933 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4935 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4936 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4938 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4939 Some packages use them to denote characters with modifiers.
4941 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4943 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4944 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4945 matching a pp-number. Rename parameter var to var1.
4947 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4949 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4951 2011-10-08 Glenn Morris <rgm@gnu.org>
4953 * callint.c (Fcall_interactively): Give a more explicit error for the
4954 'c' case with a non-character input. (Bug#8479)
4956 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4958 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4960 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4961 lines that are hscrolled on the left.
4963 * dispnew.c (buffer_posn_from_coords): Account for a possible
4964 presence of header-line. (Bug#4426)
4966 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4968 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4969 Don't advertise functionality which we discourage or doesn't work.
4971 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4973 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4974 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4975 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4976 this makes Emacs dump core during garbage collection on rare
4977 occasions. sizeof is obviously inferior to offsetof here, so
4978 stick with offsetof.
4979 (GC_POINTER_ALIGNMENT): New macro.
4980 (mark_memory): Omit 3rd (offset) arg; caller changed.
4981 Don't assume EMACS_INT alignment is the same as pointer alignment.
4983 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4985 * keyboard.c (read_key_sequence_remapped): New var.
4986 (read_key_sequence): Compute remapping in the right buffer.
4987 (command_loop_1): Use read_key_sequence's remapping directly.
4989 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4991 * dired.c (file_name_completion): Don't expand file name.
4992 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4993 before checking file name handler.
4995 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4996 they've been requested explicitly (bug#9591).
4998 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5000 * keymap.c (Fsingle_key_description): Use make_specified_string
5001 instead of build_string to build string from push_key_description.
5004 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5006 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5007 This fixes a Y2038 bug on 64-bit hosts.
5008 * buffer.c (reset_buffer):
5009 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5010 (Fclear_buffer_auto_save_failure):
5011 Use 0, not -1, to represent an unset failure time, since time_t
5012 might not be signed.
5014 Remove dependency on glibc malloc internals.
5015 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5016 Move back here from lisp.h, but with their new implementations.
5017 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5018 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5019 * charset.c (charset_table_init): New static var.
5020 (syms_of_charset): Use it instead of xmalloc. This removes a
5021 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5022 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5023 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5024 Move back to alloc.c.
5025 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5026 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5028 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5030 * nsterm.m (windowDidResize): Call x_set_window_size only when
5031 ns_in_resize is true. Otherwise set pixelwidth/height and
5032 call change_frame_size (Bug#9628).
5034 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5036 Port --enable-checking=all to Fedora 14 x86-64.
5037 * charset.c (syms_of_charset): Also account for glibc malloc's
5038 internal overhead when calculating the initial malloc maximum.
5040 Port --enable-checking=all to Fedora 14 x86.
5041 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5043 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5044 (overrun_check_realloc, overrun_check_free):
5045 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5046 That way, xmalloc returns a properly-aligned pointer even if
5047 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5048 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5049 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5050 into account when calculating the initial malloc maximum.
5051 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5052 Move here from alloc.c, so that charset.c can use it too.
5053 Properly align; the old code wasn't right for common 32-bit hosts
5054 when configured with --enable-checking=all.
5055 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5056 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5058 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5060 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5063 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5065 * xdisp.c (compute_display_string_end): If there's no display
5066 string at CHARPOS, return -1.
5068 * bidi.c (bidi_fetch_char): When compute_display_string_end
5069 returns a negative value, treat the character as a normal
5070 character not covered by a display string. (Bug#9624)
5072 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5074 * lread.c (Fread_from_string): Fix typo in docstring.
5076 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5078 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5079 newline, reseat the iterator instead of bidi-iterating there one
5080 character at a time. (Bug#9610)
5081 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5082 TO_CHARPOS if the bidi iterator is at base embedding level.
5084 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5086 * lread.c (readevalloop): Use correct code for NBSP.
5087 (read1): Likewise. (Bug#9608)
5089 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5091 * dbusbind.c (Fdbus_register_signal): When service is not
5092 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5094 2011-09-25 Glenn Morris <rgm@gnu.org>
5096 * buffer.c (truncate-lines): Doc fix.
5098 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5100 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5101 (Fset_window_next_buffers): Doc fix.
5103 2011-09-24 Glenn Morris <rgm@gnu.org>
5105 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5107 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5109 Fix minor problems found by static checking.
5110 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5111 * indent.c (Fvertical_motion): Fix == vs = typo.
5113 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5115 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5116 Default value is now t. Doc fix.
5118 * indent.c (Fvertical_motion): Compute and apply the overshoot
5119 logic when moving up, not only when moving down. Fix the
5120 confusing name and values of the it_overshoot_expected variable;
5121 logic changes accordingly. (Bug#9254) (Bug#9549)
5123 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5124 CHARPOS is covered by a display string which includes newlines.
5125 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5126 is covered by a display string with embedded newlines.
5128 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5130 * dbusbind.c (Fdbus_register_signal): Add match rule to
5131 Vdbus_registered_objects_table. (Bug#9581)
5132 (Fdbus_register_method, Vdbus_registered_objects_table):
5135 2011-09-24 Jim Meyering <meyering@redhat.com>
5137 do not ignore write error for any output size
5138 The previous change was incomplete.
5139 While it makes emacs --batch detect the vast majority of stdout
5140 write failures, errors were still ignored whenever the output size is
5141 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5142 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5143 && echo FAIL: ignored write error
5144 FAIL: ignored write error
5145 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5146 && echo FAIL: ignored write error
5147 FAIL: ignored write error
5148 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5150 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5152 * emacs.c (Fkill_emacs): In noninteractive mode exit
5153 non-successfully if a write error occurred on stdout. (Bug#9574)
5155 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5157 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5160 * dispextern.h (struct it): Update the comment documenting what
5163 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5165 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5166 a display string, extend search for cursor position to end of row.
5167 (find_row_edges): If the row ends in a newline from a display
5168 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5169 Handle the case of a display string with multiple newlines.
5170 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5171 non-empty line. Fixes confusing cursor motion with arrow keys at
5172 the beginning of a line that starts with whitespace.
5174 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5176 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5179 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5181 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5184 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5186 * xdisp.c (display_line): Record maximum and minimum buffer
5187 positions even if no glyphs were produced (e.g., by a zero-width
5188 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5189 buffer positions that will be removed from the glyph row because
5191 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5192 column is beyond frame width: don't subtract 1 "pixel" when
5193 computing width of the stretch.
5194 (reseat_at_next_visible_line_start): Undo the change made on
5195 2011-09-17 that saved paragraph information and restored it after
5196 the call to `reseat'. (Bug#9545)
5198 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5200 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5201 and turn window cursor on if cleared (Bug#9415).
5203 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5205 * search.c (boyer_moore): Take unibyte characters from pattern
5206 literally. (Bug#9458)
5208 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5210 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5212 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5214 Fix minor problem found by static checking.
5215 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5216 initialized, to pacify gcc -Wuninitialized.
5218 * fileio.c: Report proper errno when syscall falls.
5219 (Finsert_file_contents): Save and restore errno,
5220 so that report_file_error outputs the correct diagnostic.
5221 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5223 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5225 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5227 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5229 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5230 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5232 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5234 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5235 about the current paragraph and restore it after the call to reseat.
5237 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5238 (bidi_find_paragraph_start): Search back for paragraph beginning
5239 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5240 (bidi_move_to_visually_next): Only trigger paragraph-related
5241 computations when the last character is a newline or at EOB, not
5242 just any NEUTRAL_B. (Bug#9470)
5244 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5245 truncated lines if point is covered by a display string. (Bug#9524)
5247 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5249 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5250 (cons_to_x_long): New function.
5251 (lisp_data_to_selection_data): Use it. Correct the test for
5252 short-versus-long data; it was negated. Break out of vector
5253 loop, for efficiency, when a long datum is discovered.
5255 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5257 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5259 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5261 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5262 GCC PR/17406) by declaring this function with external scope.
5264 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5266 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5267 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5269 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5271 * editfns.c (Fformat): Correctly handle text properties on "%%".
5273 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5275 * xterm.c (x_draw_composite_glyph_string_foreground):
5276 * w32term.c (x_draw_composite_glyph_string_foreground):
5277 * term.c (encode_terminal_code):
5278 * composite.c (composition_update_it, get_composition_id):
5279 * xdisp.c (get_next_display_element)
5280 (fill_composite_glyph_string): Add comments about special meaning
5281 of TAB characters in a composition.
5283 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5285 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5286 This occurs when processing a multibyte format.
5287 Problem reported by Wolfgang Jenker.
5289 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5291 * xdisp.c (try_cursor_movement): Only check for exact match if
5292 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5294 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5296 Remove unused external symbols.
5297 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5298 * xdisp.c (calc_pixel_width_or_height): Now static.
5299 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5300 * indent.c (check_display_width):
5301 * w32term.c: Fix comment to match code.
5302 * xterm.c, xterm.h (x_catching_errors): Remove.
5304 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5306 * xselect.c: Use signed conversions more consistently (Bug#9498).
5307 (selection_data_to_lisp_data): Assume incoming selection data are
5308 signed integers, not unsigned. This is to be consistent with
5309 outgoing selection data, which was modified to use signed integers
5310 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5311 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5312 expects long, not unsigned long.
5314 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5316 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5317 computation of loop end. Reported by Johan Bockgård
5320 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5322 * frame.c (Fother_visible_frames_p): Function deleted.
5324 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5326 * indent.c (compute_motion): Process display vector front to back
5327 rather than the other way around. (Bug#2496)
5329 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5331 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5333 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5335 * minibuf.c (Fread_from_minibuffer): Doc fix.
5337 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5339 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5340 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5342 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5344 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5345 value for non-existent files.
5347 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5349 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5350 set its "size" to -1. This will set the modtime_size field of
5351 the corresponding buffer to -1, which is what
5352 verify-visited-file-modtime expects for files that do not exist.
5355 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5357 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5359 * lisp.h: ... from here. push_key_description is no longer
5360 defined in keyboard.c, so its declaration should not be in
5361 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5362 logically belongs with push_key_description.
5364 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5366 * buffer.h: Include <sys/types.h> instead of <time.h>.
5367 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5368 Problem reported by Herbert J. Skuhra.
5370 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5372 * xml.c (parse_region): Make the parsing work for
5373 non-comment-starting XML files again (bug#9144).
5375 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5377 * image.c (gif_load): Fix calculation of bottom and right corner.
5380 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5382 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5383 redisplay in small windows.
5385 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5387 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5389 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5391 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5392 Operate on live windows only.
5394 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5396 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5398 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5400 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5401 only under bidi iteration.
5403 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5405 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5407 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5409 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5410 Without this fix, the command to link temacs failed due to an
5411 undefined symbol __builtin_isnan. This is because
5412 /usr/include/iso/math_c99.h #defines isnan(x) to
5413 __builtin_isnan(x), but the bundled gcc, which identifies itself
5414 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5416 * floatfns.c (isnan): #undef, and then #define to a clone of
5418 (Fisnan): Always define, since it's always available now.
5419 (syms_of_floatfns): Always define isnan at the Lisp level.
5421 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5423 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5425 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5427 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5428 The previous code assumed that file offsets (off_t values) fit in
5429 EMACS_INT variables, which is not true on typical 32-bit hosts.
5430 The code messed up by falsely reporting buffer overflow in cases
5431 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5432 when "big" contains more than 2**29 bytes, even though this
5433 inserts just one byte and does not overflow the buffer.
5434 (Finsert_file_contents): Store file offsets as off_t
5435 values, not as EMACS_INT values. Check for overflow when
5436 converting between EMACS_INT and off_t. When checking for
5437 buffer overflow or for overlap, take the offsets into account.
5438 Don't use EMACS_INT for small values where int suffices.
5439 When checking for overlap, fix a typo: ZV was used where
5440 ZV_BYTE was intended.
5441 (Fwrite_region): Don't assume off_t fits into 'long'.
5442 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5444 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5446 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5448 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5450 sprintf-related integer and memory overflow issues (Bug#9412).
5452 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5453 (esprintf, exprintf, evxprintf): New functions.
5454 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5455 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5456 (modify_event_symbol): Do not assume that the length of
5457 name_alist_or_stem is safe to alloca and fits in int.
5458 (Fexecute_extended_command): Likewise for function name and binding.
5459 (Frecursion_depth): Wrap around reliably on integer overflow.
5460 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5461 since some callers pass EMACS_INT values.
5462 (Fsingle_key_description): Don't crash if symbol name contains more
5463 than MAX_ALLOCA bytes.
5464 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5465 (get_minibuffer): Arg is now EMACS_INT, not int.
5466 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5467 (esprintf, exprintf, evxprintf): New decls.
5468 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5470 * dbusbind.c (signature_cat): New function.
5471 (xd_signature, Fdbus_register_signal):
5472 Do not overrun buffer; instead, report string overflow.
5474 * dispnew.c (add_window_display_history): Don't overrun buffer.
5475 Truncate instead; this is OK since it's just a log.
5477 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5478 even if the time zone offset is outlandishly large.
5479 Don't mishandle offset == INT_MIN.
5481 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5482 when creating daemon; the previous buffer-overflow check was incorrect.
5484 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5485 which has the guts of the old verror function.
5487 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5488 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5490 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5491 (font_unparse_xlfd): Don't blindly alloca long strings.
5492 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5493 fits in int, when using sprintf. Use single snprintf to count
5494 length of string rather than counting it via multiple sprintfs;
5495 that's simpler and more reliable.
5496 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5497 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5498 sprintf, in case result does not fit in int.
5500 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5501 (fontset_from_font): Print it.
5503 * frame.c (tty_frame_count): Now printmax_t, not int.
5504 (make_terminal_frame, set_term_frame_name): Print it.
5505 (x_report_frame_params): In X, window IDs are unsigned long,
5506 not signed long, so print them as unsigned.
5507 (validate_x_resource_name): Check for implausibly long names,
5508 and don't assume name length fits in 'int'.
5509 (x_get_resource_string): Don't blindly alloca invocation name;
5510 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5513 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5514 (xg_check_special_colors, xg_set_geometry):
5515 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5517 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5518 Use esprintf, not sprintf, in case result does not fit in int.
5520 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5521 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5522 it as a large positive number.
5523 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5524 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5526 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5527 in case result does not fit in int.
5529 * print.c (float_to_string): Detect width overflow more reliably.
5530 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5531 buffer overrun. Don't assume list length fits in 'int'. Treat
5532 print length of 0 as 0, not as infinity; to be consistent with other
5533 uses of print length in this function. Don't overflow print length
5534 index. Don't assume hash table size fits in 'long', or that
5535 vectorlike size fits in 'unsigned long'.
5537 * process.c (make_process): Use printmax_t, not int, to format
5538 process-name gensyms.
5540 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5542 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5543 to avoid potential buffer overrun.
5545 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5546 if X resource line is longer than 512 bytes.
5548 * xfns.c (x_window): Make sprintf buffer a bit bigger
5549 to avoid potential buffer overrun.
5551 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5553 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5555 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5557 Integer overflow fixes for scrolling, etc.
5558 Without these, Emacs silently mishandles large integers sometimes.
5559 For example, "C-u 4294967297 M-x recenter" was treated as if
5560 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5562 * xdisp.c (try_window_id): Check Emacs fixnum range before
5563 converting to 'int'.
5565 * window.c (window_scroll_line_based, Frecenter):
5566 Check that an Emacs fixnum is in range before assigning it to 'int'.
5567 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5568 values converted from Emacs fixnums.
5569 (Frecenter): Don't wrap around a line count if it is out of 'int'
5570 range; instead, treat it as an extreme value.
5571 (Fset_window_configuration, compare_window_configurations):
5572 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5574 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5575 that can exceed INT_MAX. Check that EMACS_INT value is in range
5576 before assigning it to the (possibly-narrower) index.
5577 (match_limit): Don't assume that a fixnum can fit in 'int'.
5579 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5582 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5583 (Fvertical_motion): Don't wrap around LINES values that don't fit
5584 in 'int'. Instead, treat them as extreme values. This is good
5585 enough for windows, which can't have more than INT_MAX lines anyway.
5587 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5589 * Require libxml/parser.h to avoid compilation warning.
5591 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5593 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5594 since this reportedly can destroy thread storage.
5596 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5598 * syntax.c (find_defun_start): Update all cache variables if
5599 exiting early (Bug#9401).
5601 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5603 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5605 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5606 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5607 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5609 * term.c (tty_append_glyph): New function.
5610 (produce_stretch_glyph): Static function and its prototype deleted.
5612 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5615 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5617 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5618 when checking :margin (Bug#9390).
5619 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5620 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5621 so that the name doesn't mislead. All uses changed.
5623 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5625 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5628 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5630 * xdisp.c (move_it_to): Don't bail out early when reaching
5631 position beyond to_charpos, if we are scanning backwards.
5632 (move_it_vertically_backward): When DY == 0, make sure we get to
5633 the first character in the line after the newline.
5635 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5637 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5638 (ccl_driver): Do not generate an out-of-range pointer.
5639 (Fccl_execute_on_string): Remove unnecessary check for
5640 integer overflow, noted by Stefan Monnier in
5641 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5642 Remove a FIXME that didn't need fixing.
5643 Simplify the newly-introduced buffer reallocation code.
5645 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5647 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5649 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5651 Integer and memory overflow issues (Bug#9196).
5653 * doc.c (get_doc_string): Rework so that
5654 get_doc_string_buffer_size is the actual buffer size, rather than
5655 being 1 less than the actual buffer size; this makes xpalloc more
5658 * image.c (x_allocate_bitmap_record, cache_image):
5659 * xselect.c (Fx_register_dnd_atom):
5660 Simplify previous changes by using xpalloc.
5662 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5663 since either will do and ptrdiff_t is convenient with xpalloc.
5665 * charset.c (charset_table_size)
5666 (struct charset_sort_data.priority): Now ptrdiff_t.
5667 (charset_compare): Don't overflow if priorities differ greatly.
5668 (Fsort_charsets): Don't assume list length fits in int.
5669 Check for size-calculation overflow when allocating sort data.
5670 (syms_of_charset): Allocate an initial charset table that is
5671 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5673 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5675 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5676 The actual value is always <= INT_MAX, and leaving it unsigned made
5677 overflow checking harder.
5679 * dispextern.h (struct glyph_matrix.rows_allocated)
5680 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5681 with xpalloc. The values are still always <= INT_MAX.
5683 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5685 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5686 (SAFE_NALLOCA): New macro.
5688 * region-cache.c (struct boundary.pos, find_cache_boundary)
5689 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5690 (set_cache_region, invalidate_region_cache)
5691 (revalidate_region_cache, know_region_cache, region_cache_forward)
5692 (region_cache_backward, pp_cache):
5693 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5694 so that ptrdiff_t * can be passed to xpalloc.
5695 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5696 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5697 (pp_cache): Don't assume cache_len fits in int.
5698 * region-cache.h: Adjust extern decls to match.
5700 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5701 EMACS_INT, since either will do, for xpalloc.
5703 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5704 (xnmalloc, xnrealloc, xpalloc): New functions.
5706 * bidi.c (bidi_shelve_header_size): New constant.
5707 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5708 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5710 * bidi.c (bidi_cache_shrink):
5711 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5713 Don't update size of array until after memory allocation succeeds,
5714 because xmalloc/xrealloc may not return.
5715 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5716 now that we have proper integer overflow checking.
5717 (record_overlay_string, overlay_strings): Catch overflows when
5718 calculating size of overlay_str_buf.
5720 * callproc.c (Fcall_process): Check for size overflow when
5721 calculating size of args2.
5722 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5723 Normally we prefer signed values, but sticking with ptrdiff_t would
5724 require adding more-complicated checks.
5726 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5727 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5728 Redo buffer-overflow calculations to avoid integer overflow.
5729 Add a FIXME comment where memory seems to be over-allocated.
5731 * character.c (Fstring): Check for size-calculation overflow.
5733 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5734 unnecessary integer overflow. Check for size overflow.
5735 (encode_coding_object): Don't update size until xmalloc succeeds.
5737 * composite.c (get_composition_id): Check for overflow in glyph
5738 length calculations.
5740 Integer and memory overflow fixes for display code.
5741 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5742 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5743 (scrolling_window): Check for overflow in size calculations.
5744 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5745 Don't assume glyph table len fits in int.
5746 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5747 (row_table_size): Now ptrdiff_t, not int.
5748 (scrolling_window): Avoid overflow in size calculations.
5749 Don't update size until allocation succeeds.
5750 * fns.c (concat): Check for overflow in size calculations.
5751 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5752 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5753 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5755 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5756 (get_doc_string): Check for size calculation overflow.
5757 Don't update size until allocation succeeds.
5758 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5759 EMACS_INT, where ptrdiff_t will do.
5760 (Fsubstitute_command_keys): Check for string overflow.
5762 * editfns.c (set_time_zone_rule): Don't assume environment length
5764 (message_length): Now ptrdiff_t, not int.
5765 (Fmessage_box): Don't update size until allocation succeeds.
5766 Don't assume message length fits in int.
5767 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5769 * emacs.c (main): Do not reallocate argv, since there is a null at
5770 the end that can be overwritten, and this way there's no need to
5771 worry about size-calculation overflow.
5772 (sort_args): Check for size-calculation overflow.
5774 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5776 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5778 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5779 (x_set_scroll_bar_width, x_figure_window_size):
5780 Check for integer overflow.
5781 (x_set_alpha): Do not assume XINT fits in int.
5783 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5784 This is for the members text_lines, text_cols, total_lines, total_cols,
5785 where the system imposes an 'int' limit.
5787 * fringe.c (Fdefine_fringe_bitmap):
5788 Don't update size until alloc works.
5790 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5791 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5793 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5794 Check for size-calculation overflow.
5795 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5796 do, as we prefer signed integers.
5797 (id_to_widget.max_size, id_to_widget.used)
5798 (xg_store_widget_in_map, xg_remove_widget_from_map)
5799 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5800 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5801 Use and return ptrdiff_t, not int.
5802 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5803 * gtkutil.h: Change prototypes to match the above.
5805 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5806 are duplicate now that they've been promoted to lisp.h.
5807 (x_allocate_bitmap_record, x_alloc_image_color)
5808 (make_image_cache, cache_image, xpm_load):
5809 Don't update size until alloc is done.
5810 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5812 Check for size calculation overflow.
5813 (ct_colors_allocated_max): New constant.
5814 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5817 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5818 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5819 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5820 Use ptrdiff_t, not int, to count maps.
5821 (read_char_minibuf_menu_prompt): Check for overflow in size
5822 calculations. Don't update size until allocation succeeds.
5823 Redo calculations to avoid overflow.
5824 * keyboard.h: Change prototypes to match the above.
5826 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5828 (current_minor_maps): Check for size calculation overflow.
5829 * keymap.h: Change prototypes to match the above.
5831 * lread.c (read1, init_obarray): Don't update size until alloc done.
5833 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5834 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5836 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5837 Now ptrdiff_t, not int.
5838 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5839 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5841 * process.c (Fnetwork_interface_list): Check for overflow
5842 in size calculation.
5844 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5846 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5847 overflow. Don't bother calling xmalloc when xrealloc will do.
5849 * search.c (Freplace_match): Check for size calculation overflow.
5850 (Fset_match_data): Don't assume list lengths fit in 'int'.
5852 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5853 for command line length. Do not attempt to address one before the
5854 beginning of an array, as that's not portable.
5856 * term.c (max_frame_lines): Remove; unused.
5857 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5859 (encode_terminal_code, calculate_costs): Check for size
5860 calculation overflow.
5861 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5862 table lengths and related sizes. Don't update size until alloc
5863 done. Redo calculations to avoid overflow.
5864 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5866 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5867 subtracting pointers.
5868 (gobble_line): Check for overflow more carefully. Don't update size
5871 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5872 Don't update size until alloc done.
5873 Redo size calculations to avoid overflow.
5874 Check for size calculation overflow.
5875 (main) [DEBUG]: Fix typo in invoking tparam1.
5877 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5878 Use ptrdiff_t, not int, for sizes.
5879 (store_mode_line_noprop_char): Don't update size until alloc done.
5881 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5882 Use ptrdiff_t, not int, for sizes.
5883 (Finternal_make_lisp_face, cache_face):
5884 Check for size calculation overflow.
5885 (cache_face): Treat size calculation overflows as if they were
5886 memory exhaustion (the usual treatment), rather than aborting.
5888 * xfns.c (x_encode_text, x_set_name_internal)
5889 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5890 sizes, since they can exceed INT_MAX in size. Check for size
5891 calculation overflow.
5893 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5894 (xg_select): Check for size calculation overflow.
5895 Don't update size until alloc done.
5897 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5898 as sprintf is limited to int lengths.
5900 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5901 (X_LONG_MIN): New macros.
5902 Use them to make the following changes clearer.
5903 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5904 This change doesn't affect the value now, but it may help remind
5905 future maintainers not to raise the value too much later.
5906 (SELECTION_QUANTUM): Remove, replacing with ...
5907 (selection_quantum): ... new function, which avoids overflow.
5909 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5910 assumption that selection length fits in 'int'.
5911 (x_reply_selection_request, x_handle_selection_request)
5912 (x_get_window_property, receive_incremental_selection)
5913 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5914 (lisp_data_to_selection_data, clean_local_selection_data):
5915 Use ptrdiff_t, not int, to record length of selection.
5916 (x_reply_selection_request, x_get_window_property)
5917 (receive_incremental_selection, x_property_data_to_lisp):
5918 Redo calculations to avoid overflow.
5919 (x_reply_selection_request): When sending hint, ceiling it at
5920 X_LONG_MAX rather than relying on wraparound overflow to send
5922 (x_get_window_property, receive_incremental_selection)
5923 (lisp_data_to_selection_data, x_property_data_to_lisp):
5924 Check for size-calculation overflow.
5925 (x_get_window_property, receive_incremental_selection)
5926 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5927 Don't store size until memory allocation succeeds.
5928 (x_get_window_property): Plug memory leak on memory exhaustion.
5929 Don't double-block input; malloc is safe here. Don't assume 2**34
5930 - 4 fits in unsigned long. Add an xassert to check
5931 XGetWindowProperty overflow. Be more careful about overflow
5932 calculations, and distinguish size from memory overflow better.
5933 (receive_incremental_selection): When tracing, don't assume
5934 unsigned int is less than INT_MAX.
5935 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5936 harmful) conversions of unsigned short to int.
5937 (lisp_data_to_selection_data): Don't assume that integers
5938 in the range -65535 through -1 fit in an X unsigned short.
5939 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5940 result parameters unless successful. Rely on cons_to_unsigned
5941 to report problems with elements; the old code wasn't right anyway.
5942 (x_check_property_data): Check for int overflow; we cannot use
5943 a wider type due to X limits.
5944 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5946 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5948 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5949 (x_term_init): Check for size calculation overflow.
5950 (x_color_cells): Don't store size until memory allocation succeeds.
5951 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5952 Don't assume alloca size is less than MAX_ALLOCA.
5953 (x_term_init): Don't assume length fits in int (sprintf is limited
5956 Use ptrdiff_t for composition IDs.
5957 * character.c (lisp_string_width):
5958 * composite.c (composition_table_size, n_compositions)
5959 (get_composition_id, composition_gstring_from_id):
5960 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5961 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5962 * window.c (Frecenter):
5963 Use ptrdiff_t, not int, for composition IDs.
5964 * composite.c (get_composition_id): Check for integer overflow.
5965 * composite.h: Adjust prototypes to match the above changes.
5967 Use ptrdiff_t for hash table indexes.
5968 * category.c (hash_get_category_set):
5969 * ccl.c (ccl_driver):
5970 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5971 * coding.c (coding_system_charset_list, detect_coding_system):
5972 * coding.h (struct coding_system.id):
5973 * composite.c (get_composition_id, gstring_lookup_cache):
5974 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5975 * image.c (xpm_get_color_table_h):
5976 * lisp.h (hash_lookup, hash_put):
5977 * minibuf.c (Ftest_completion):
5978 Use ptrdiff_t for hash table indexes, not int (which is too
5979 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5980 32-bit --with-wide-int hosts).
5982 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5983 Add a FIXME comment about memory leaks.
5984 (syms_of_charset): Don't assume xmalloc returns.
5986 Don't assume that stated character widths fit in int.
5987 * character.c (Fchar_width, c_string_width, lisp_string_width):
5988 * character.h (CHAR_WIDTH):
5989 * indent.c (MULTIBYTE_BYTES_WIDTH):
5990 Use sanitize_char_width to avoid undefined and/or bad behavior
5991 with outlandish widths.
5992 * character.h (sanitize_tab_width): Rename from sanitize_width,
5993 now that we have two such functions. All uses changed.
5994 (sanitize_char_width): New inline function.
5996 Don't assume that tab-width fits in int.
5997 * character.h (sanitize_width): New inline function.
5998 (SANE_TAB_WIDTH): New macro.
5999 (ASCII_CHAR_WIDTH): Use it.
6000 * indent.c (sane_tab_width): Remove. All uses replaced by
6001 SANE_TAB_WIDTH (current_buffer).
6002 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6004 * fileio.c: Integer overflow issues with file modes.
6005 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6007 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6008 Remove unreachable code.
6009 (read_hex, load_charset_map_from_file): Check for integer overflow.
6011 * xterm.c: Don't go over XClientMessageEvent limit.
6012 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6013 (x_send_scroll_bar_event): Likewise. Check that the size does not
6014 exceed limits imposed by XClientMessageEvent, as well as the usual
6015 ptrdiff_t and size_t limits.
6017 * keyboard.c: Overflow, signedness and related fixes.
6018 (make_lispy_movement): Use same integer type in forward decl
6019 that is used in the definition.
6020 (read_key_sequence, keyremap_step):
6021 Change bufsize argument back to int, undoing my 2011-03-30 change.
6022 We prefer signed types, and int is wide enough here.
6023 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6024 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6025 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6026 length, not size_t. Use ptrdiff_t for index, not int.
6027 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6028 possibility of integer overflow.
6030 Overflow, signedness and related fixes for images.
6032 * dispextern.h (struct it.stack[0].u.image.image_id)
6033 (struct_it.image_id, struct image.id, struct image_cache.size)
6034 (struct image_cache.used, struct image_cache.ref_count):
6035 * gtkutil.c (update_frame_tool_bar):
6036 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6037 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6038 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6039 * nsmenu.m (update_frame_tool_bar):
6040 * xdisp.c (calc_pixel_width_or_height):
6041 * xfns.c (image_cache_refcount):
6042 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6043 on typical 64-bit hosts.
6045 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6046 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6047 Omit unnecessary casts to int.
6048 (parse_image_spec): Check that integers fall into 'int' range
6049 when the callers expect that.
6050 (image_ascent): Redo ascent calculation to avoid int overflow.
6051 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6052 (lookup_image): Remove unnecessary tests.
6053 (xbm_image_p): Locals are now of int, not EMACS_INT,
6054 since parse_image_check makes sure they fit into int.
6055 (png_load, gif_load, svg_load_image):
6056 Prefer int to unsigned where either will do.
6057 (tiff_handler): New function, combining the cores of the
6058 old tiff_error_handler and tiff_warning_handler.
6059 This function is rewritten to use vsnprintf and thereby avoid
6060 stack buffer overflows. It uses only the features of vsnprintf
6061 that are common to both POSIX and native Microsoft.
6062 (tiff_error_handler, tiff_warning_handler): Use it.
6063 (tiff_load, gif_load, imagemagick_load_image):
6064 Don't assume :index value fits in 'int'.
6065 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6066 (imagemagick_load_image): Check that crop parameters fit into
6067 the integer types that MagickCropImage accepts. Don't assume
6068 Vimagemagick_render_type has a nonnegative value. Don't assume
6069 size_t fits in 'long'.
6070 (gs_load): Use printmax_t to print the widest integers possible.
6071 Check for integer overflow when computing image height and width.
6073 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6075 * xdisp.c (redisplay_window): Don't force window start if point
6076 will be invisible in the resulting window. (Bug#9324)
6078 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6080 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6081 the display spec is of the form `(space ...)'.
6082 (handle_display_spec): Return the value returned by
6083 handle_single_display_spec, not just 1 or zero.
6084 (handle_single_display_spec): If the display spec is of the form
6085 `(space ...)', and specifies display in the text area, return 2
6087 (try_cursor_movement): Check for the need to scroll more
6088 accurately, and prefer exact match for point under bidi.
6089 Don't advance `row' beyond the last row of the window.
6091 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6092 into disp_prop; all users changed.
6094 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6095 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6096 for the text covered by the display property.
6098 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6100 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6101 Change return value to nil.
6102 (Frecord_buffer): Delete unused function.
6104 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6106 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6107 buffers, return left-to-right.
6108 (set_cursor_from_row): Consider candidate row a win if its glyph
6109 represents a newline and point is on that newline. Fixes cursor
6110 positioning on the newline at EOL of R2L text within L2R
6111 paragraph, and vice versa.
6112 (try_cursor_movement): Check continued rows, in addition to
6113 continuation rows. Fixes unwarranted scroll when point enters a
6114 continued line of R2L text within an L2R paragraph, or vice versa.
6115 (cursor_row_p): Consider the case of point being equal to
6116 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6117 from the end of a short line to the beginning of a continued line
6118 of R2L text within L2R paragraph.
6119 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6120 composed characters.
6122 * bidi.c (bidi_check_type): Use xassert.
6123 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6126 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6128 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6131 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6133 * nsfont.m (ns_otf_to_script): Fix typo.
6135 2011-08-22 Kenichi Handa <handa@m17n.org>
6137 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6138 extra slot even if the purpose is char-code-property-table.
6140 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6142 * xdisp.c (redisplay_window): When computing centering_position,
6143 account for the height of the header line. (Bug#8874)
6145 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6146 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6147 candidate is selected by the mouse, and that candidate has a
6148 composed character under the mouse.
6150 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6151 coordinates reported by pos-visible-in-window-p for a composed
6152 character in column zero.
6154 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6156 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6158 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6160 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6161 consider it a hit if to_charpos is anywhere in the range of the
6162 composed buffer positions.
6164 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6166 * image.c (gif_load): Don't assume that each subimage has the same
6167 dimensions as the base image. Handle disposal method that is
6168 "undefined" by the gif spec (Bug#9335).
6170 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6172 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6173 (Fcondition_case): Document `debug' symbol in error handler.
6175 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6177 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6178 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6179 from an Org mode buffer to a Speedbar frame.
6181 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6182 a composition, take its buffer position from IT->cmp_it.charpos.
6183 Fixes cursor positioning at the beginning of a line that begins
6184 with a composed character.
6186 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6188 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6189 character bidirectional type, use STRONG_L instead. Fixes crashes
6190 in a buffer produced by `describe-categories'.
6192 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6193 members before the level stack, so they would be saved and
6194 restored when copying iterator state. Fixes incorrect reordering
6195 around TABs covered by display properties.
6197 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6199 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6201 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6203 * eval.c (internal_condition_case, internal_condition_case_1)
6204 (internal_condition_case_2, internal_condition_case_n):
6205 Remove unnecessary aborts (Bug#9081).
6207 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6209 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6210 has no `load' handler, try opening the file locally. (Bug#9311)
6212 2011-08-16 Ken Brown <kbrown@cornell.edu>
6214 * gmalloc.c: Expand comment.
6216 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6218 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6219 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6221 2011-08-16 Ken Brown <kbrown@cornell.edu>
6223 Fix memory allocation problems in Cygwin build (Bug#9273).
6225 * unexcw.c ( __malloc_initialized): Declare external variable.
6226 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6228 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6230 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6232 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6234 [CYGWIN] (special_realloc): New function.
6235 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6236 requests to realloc storage in the static heap.
6238 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6240 * bidi.c (bidi_initialize): Remove unused local.
6242 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6245 * biditype.h: Remove file.
6246 * makefile.w32-in ($(BLD)/bidi.$(O)):
6247 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6249 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6251 * chartab.c: Improve commentary for the uniprop_table API.
6253 * bidi.c (bidi_paragraph_init): Support zero value of
6254 bidi_ignore_explicit_marks_for_paragraph_level.
6255 (bidi_initialize): Use uniprop_table instead of including
6256 biditype.h and bidimirror.h.
6258 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6259 coordinates of the iterator when restoring from ppos_it.
6262 2011-08-14 Kenichi Handa <handa@m17n.org>
6264 * process.c (create_process): Call setup_process_coding_systems
6265 after the pid of the process is set to -1 (Bug#8162).
6267 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6269 * xdisp.c (move_it_in_display_line_to): Don't invoke
6270 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6271 ppos_it. Fixes vertical cursor motion when line beginning is
6272 covered by an image. (Bug#9296)
6274 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6276 * nsterm.h (ns_run_ascript): Declare.
6277 (NSAPP_DATA2_RUNASSCRIPT): Define.
6279 * nsfns.m (as_script, as_result, as_status): New static variables.
6280 (ns_run_ascript): New function.
6281 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6282 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6283 the event loop. Get status from as_status (Bug#7276).
6285 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6286 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6287 the event loop (Bug#7276).
6289 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6291 * gnutls.c (QCgnutls_bootprop_priority)
6292 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6293 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6294 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6295 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6296 (QCgnutls_bootprop_verify_hostname_error)
6297 (QCgnutls_bootprop_callbacks_verify): Rename from
6298 Qgnutls_bootprop_..., all uses changed.
6300 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6303 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6305 * xfaces.c (Qframe_set_background_mode): Now static.
6306 * dispextern.h (Qframe_set_background_mode): Remove decl.
6308 * process.c (Fnetwork_interface_info): Declare local only if needed.
6310 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6312 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6313 (Fnetwork_interface_list): Allocate in increments of bytes instead
6314 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6315 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6317 (struct ifflag_def): notrailers is smart on OSX.
6318 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6319 Get hardware address with getifaddrs if available.
6321 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6323 * xdisp.c (iterate_out_of_display_property): xassert that
6324 IT->position is set to within IT->object's boundaries. Break from
6325 the loop as soon as EOB is reached; avoids infloops in redisplay
6326 when IT->position is set up wrongly due to some bug.
6327 Set IT->current to match the bidi iterator unconditionally.
6328 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6329 entry. Force push_it to save on the stack the current
6330 buffer/string position, to be restored by pop_it. Fix flags in
6331 the iterator structure wrt the object coming from a display
6332 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6333 properties. (Bug#9284)
6335 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6337 * fontset.c (fontset_get_font_group): Add proper type checks.
6340 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6342 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6343 and LC_VERSION_MIN_MACOSX.
6344 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6345 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6347 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6349 * xdisp.c (forward_to_next_line_start): Allow to use the
6350 no-display-properties-and-no-overlays under bidi display.
6351 Set disp_pos in the bidi iterator to avoid searches for display
6352 properties and overlays.
6354 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6356 * editfns.c (Fset_time_zone_rule): Document relationship with the
6359 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6360 the font entity extracted from the cache (Bug#8109).
6362 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6364 * composite.c (autocmp_chars): Don't reset point. That is done by
6365 restore_point_unwind (Bug#5984).
6367 2011-08-07 Juri Linkov <juri@jurta.org>
6369 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6370 to show the arg `TIME' instead of `TIMEVAL'.
6372 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6374 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6375 display property strides EOL and includes a newline, as in
6376 longlines-mode. (Bug#9254)
6377 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6378 word-wrap under bidirectional display. (Bug#9224)
6380 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6381 is non-zero, even if the data buffer is NULL. Fixes a crash in
6382 vertical-motion with longlines-mode. (Bug#9254)
6384 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6386 * bidi.c <bidi_cache_total_alloc>: Now static.
6387 (bidi_initialize): Initialize bidi_cache_total_alloc.
6389 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6392 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6393 amount allocated this far in `bidi_cache_total_alloc'.
6394 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6395 non-zero, only free the data buffer without restoring the cache
6396 contents. All callers changed.
6398 * dispextern.h (bidi_unshelve_cache): Update prototype.
6400 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6401 (move_it_in_display_line, move_it_to)
6402 (move_it_vertically_backward, move_it_by_lines): Replace the call
6403 to xfree to an equivalent call to bidi_unshelve_cache.
6404 (move_it_in_display_line_to): Fix logic of returning
6405 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6407 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6409 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6410 came from a string character with a `cursor' property. (Bug#9229)
6412 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6414 * Makefile.in (LIB_PTHREAD): New variable.
6415 (LIBES): Add LIB_PTHREAD (Bug#9216).
6417 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6418 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6420 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6422 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6424 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6426 * xterm.c (x_find_topmost_parent): New function.
6427 (x_set_frame_alpha): Find topmost parent window with
6428 x_find_topmost_parent and set the property there also (bug#9181).
6429 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6431 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6433 * callproc.c (Fcall_process): Avoid vfork clobbering
6434 the local vars buffer, coding_systems, current_dir.
6436 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6438 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6440 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6442 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6443 so that it is not optimized away.
6445 * xdisp.c (compute_display_string_pos): Remove unused local.
6447 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6449 Fix slow cursor motion and scrolling in large buffers with
6450 selective display, like Org Mode buffers. (Bug#9218)
6452 * dispextern.h (struct bidi_it): New member disp_prop_p.
6454 * xdisp.c: Remove one-slot cache of display string positions.
6455 (compute_display_string_pos): Accept an additional argument
6456 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6457 for a display string or property. If found, set DISP_PROP_P
6460 * bidi.c (bidi_fetch_char): Accept an additional argument
6461 DISP_PROP_P, and pass it to compute_display_string_pos.
6462 Only handle text covered by a display string if DISP_PROP_P is returned
6463 non-zero. All callers of bidi_fetch_char changed.
6465 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6467 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6469 2010-12-03 Don March <don@ohspite.net>
6471 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6472 last character M-[char] is translated to ESC [char] (bug#7541).
6474 2011-08-02 Kenichi Handa <handa@m17n.org>
6476 * lisp.h (uniprop_table): Extern it.
6478 * chartab.c (uniprop_table): Make it non-static.
6480 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6482 * xdisp.c (forward_to_next_line_start): Accept additional argument
6483 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6485 (reseat_at_next_visible_line_start): Use the bidi iterator state
6486 returned by forward_to_next_line_start to restore the state of
6487 it->bidi_it after backing up to previous newline. (Bug#9212)
6489 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6491 * regex.c (re_comp): Protoize.
6492 (re_exec): Fix return type.
6493 (regexec): Fix type of `ret'. (Bug#9203)
6495 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6497 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6498 This is needed if max-image-size is a floating-point number.
6500 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6502 * print.c (print_object): Print empty symbol as ##.
6504 * lread.c (read1): Read ## as empty symbol.
6506 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6508 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6509 setting frame foreground color (Bug#9175).
6510 (x_set_background_color): Likewise.
6512 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6513 contents (Bug#9176).
6514 (EmacsTooltip -init): Remove bezels and add shadows to
6517 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6518 or scroll bar (Bug#8470).
6520 * nsfont.m (nsfont_open): Remove assignment to voffset and
6521 unnecessary vars hshink, expand, hd, full_height, min_height.
6522 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6524 * nsterm.h (nsfont_info): Remove voffset field.
6526 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6528 Implement strike-through and overline on NextStep (Bug#8863).
6530 * nsfont.m (nsfont_open): Use underline position provided by font,
6531 instead of hard-coded value of 2.
6532 (nsfont_draw): Call ns_draw_text_decoration instead.
6534 * nsterm.h: Add declaration for ns_draw_text_decoration.
6536 * nsterm.m (ns_draw_text_decoration): New function for drawing
6537 underline, overline, and strike-through.
6538 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6539 ns_draw_text_decoration. Change treatment of cursor drawing to
6540 accommodate underlining, etc.
6542 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6544 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6547 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6549 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6550 Without this fix, if a signal arrives just after memory fills up,
6551 'malloc' might be invoked reentrantly.
6553 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6554 In other words, assume that every image size is allowed, on non-X
6555 hosts. This assumption is probably wrong, but it lets Emacs compile.
6557 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6559 * regex.c (re_iswctype): Convert return values to boolean.
6561 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6563 * xdisp.c (compute_display_string_pos): Don't use cached display
6564 string position if the buffer had its restriction changed.
6567 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6569 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6571 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6573 Integer signedness and overflow and related fixes. (Bug#9079)
6575 * bidi.c: Integer size and overflow fixes.
6576 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6577 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6578 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6579 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6580 (bidi_find_other_level_edge):
6581 Use ptrdiff_t instead of EMACS_INT where either will do.
6582 This works better on 32-bit hosts configured --with-wide-int.
6583 (bidi_cache_ensure_space): Check for size-calculation overflow.
6584 Use % rather than repeated addition, for better worst-case speed.
6585 Don't set bidi_cache_size until after xrealloc returns, because it
6587 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6588 (bidi_cache_ensure_space): Also check that the bidi cache size
6589 does not exceed that of the largest Lisp string or buffer. See Eli
6590 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6592 * alloc.c (__malloc_size_t): Remove.
6593 All uses replaced by size_t. See Andreas Schwab's note
6594 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6596 * image.c: Improve checking for integer overflow.
6597 (check_image_size): Assume that f is nonnull, since
6598 it is always nonnull in practice. This is one less thing to
6599 worry about when checking for integer overflow later.
6600 (x_check_image_size): New function, which checks for integer
6601 overflow issues inside X.
6602 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6603 This removes the need for a memory_full check.
6604 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6605 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6606 (xbm_read_bitmap_data): Change locals back to 'int', since
6607 their values must fit in 'int'.
6608 (xpm_load_image, png_load, tiff_load):
6609 Invoke x_create_x_image_and_pixmap earlier,
6610 to avoid much needless work if the image is too large.
6611 (tiff_load): Treat overly large images as if
6612 x_create_x_image_and_pixmap failed, not as malloc failures.
6613 (gs_load): Use x_check_image_size.
6615 * gtkutil.c: Omit integer casts.
6616 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6617 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6619 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6621 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6622 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6623 would wrongly return t on a 64-bit host.
6625 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6626 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6627 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6628 and therefore cause GCC to emit a bogus diagnostic in some cases.
6630 * image.c: Integer signedness and overflow and related fixes.
6631 This is not an exhaustive set of fixes, but it's time to
6632 record what I've got.
6633 (lookup_pixel_color, check_image_size): Remove redundant decls.
6634 (check_image_size): Don't assume that arbitrary EMACS_INT values
6635 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6636 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6637 (tiff_load, imagemagick_load_image):
6638 Check for overflow in size calculations.
6639 (x_create_x_image_and_pixmap): Remove unnecessary test for
6640 xmalloc returning NULL; that can't happen.
6641 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6642 (xpm_color_bucket): Use better integer hashing function.
6643 (xpm_cache_color): Don't possibly over-allocate memory.
6644 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6645 (gif_memory_source):
6646 Use ptrdiff_t, not int or size_t, to record sizes.
6647 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6648 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6649 either works, as we prefer signed integers.
6650 (tiff_read_from_memory, tiff_write_from_memory):
6651 Return tsize_t, not size_t, since that's what the TIFF API wants.
6652 (tiff_read_from_memory): Don't fail simply because the read would
6653 go past EOF; instead, return a short read.
6654 (tiff_load): Omit no-longer-needed casts.
6655 (Fimagemagick_types): Don't assume size fits into 'int'.
6657 Improve hashing quality when configured --with-wide-int.
6658 * fns.c (hash_string): New function, taken from sxhash_string.
6659 Do not discard information about ASCII character case; this
6660 discarding is no longer needed.
6661 (sxhash-string): Use it. Change sig to match it. Caller changed.
6662 * lisp.h: Declare it.
6663 * lread.c (hash_string): Remove, since we now use fns.c's version.
6664 The fns.c version returns a wider integer if --with-wide-int is
6665 specified, so this should help the quality of the hashing a bit.
6667 * emacs.c: Integer overflow minor fix.
6668 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6669 Define only if GNU_LINUX.
6670 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6672 * dispnew.c: Integer signedness and overflow fixes.
6673 Remove unnecessary forward decls, that were a maintenance hassle.
6674 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6676 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6677 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6678 (prepare_desired_row, line_draw_cost):
6679 Use int, not unsigned, where either works.
6680 (save_current_matrix, restore_current_matrix):
6681 Use ptrdiff_t, not size_t, where either works.
6682 (init_display): Check for overflow more accurately, and without
6683 relying on undefined behavior.
6685 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6686 Remove, replacing with the new symbols in lisp.h. All uses changed.
6687 * fileio.c (make_temp_name):
6688 * filelock.c (lock_file_1, lock_file):
6689 * xdisp.c (message_dolog):
6690 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6691 Use pMd etc. instead.
6692 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6693 replacing the pWIDE etc. symbols removed from editfns.c.
6695 * keyboard.h (num_input_events): Now uintmax_t.
6696 This is (very slightly) less likely to mess up due to wraparound.
6699 * buffer.c: Integer signedness fixes.
6700 (alloc_buffer_text, enlarge_buffer_text):
6701 Use ptrdiff_t rather than size_t when either will do, as we prefer
6704 * alloc.c: Integer signedness and overflow fixes.
6705 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6706 (__malloc_size_t): Default to size_t, not to int.
6707 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6708 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6709 Prefer ptrdiff_t to size_t when either would do, as we prefer
6711 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6712 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6713 Now const. Initialize with values that are in range even if char
6715 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6716 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6717 These functions do the right thing with sizes > 2**32.
6718 (check_depth): Now ptrdiff_t, not int.
6719 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6720 Adjust to new way of storing sizes. Check for size overflow bugs
6722 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6723 slightly wrong anyway, as it missed one instance of
6724 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6725 (refill_memory_reserve): Omit needless cast to size_t.
6726 (mark_object_loop_halt): Mark as externally visible.
6728 * xselect.c: Integer signedness and overflow fixes.
6729 (Fx_register_dnd_atom, x_handle_dnd_message):
6730 Use ptrdiff_t, not size_t, since we prefer signed.
6731 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6732 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6733 x_dnd_atoms_size and x_dnd_atoms_length.
6735 * doprnt.c: Prefer signed to unsigned when either works.
6737 * doprnt.c (doprnt):
6739 * xdisp.c (vmessage):
6740 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6741 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6742 prefer signed arithmetic to avoid comparison confusion.
6743 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6744 but is a bit tricky.
6746 Assume freestanding C89 headers, string.h, stdlib.h.
6747 * data.c, doprnt.c, floatfns.c, print.c:
6748 Include float.h unconditionally.
6749 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6750 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6751 * regex.c: Likewise for stddef.h, string.h.
6752 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6753 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6754 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6755 (STDC_HEADERS): Remove obsolete defines.
6756 * sysdep.c: Include limits.h unconditionally.
6758 Assume support for memcmp, memcpy, memmove, memset.
6759 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6760 * regex.c (memcmp, memcpy):
6761 Remove; we assume C89 now.
6763 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6764 (__malloc_safe_bcopy): Remove; no longer needed.
6766 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6767 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6768 well either way, and we prefer signed to unsigned.
6770 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6772 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6773 closes the connection while we're reading (bug#9182).
6775 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6777 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6778 are specified (Bug#9168).
6780 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6782 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6783 Found by GCC static checking and --with-wide-int on a 32-bit host.
6785 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6787 * xdisp.c (compute_display_string_pos): Fix logic of caching
6788 previous display string position. Initialize cached_prev_pos to
6789 -1. Fixes slow-down at the beginning of a buffer.
6791 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6793 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6794 for attrs[LFACE_FONTSET_INDEX].
6796 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6798 * xml.c (parse_region): Remove unused local
6799 that was recently introduced.
6801 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6803 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6804 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6806 * xdisp.c (move_it_in_display_line_to): Record the best matching
6807 position for TO_CHARPOS while scanning the line, and restore it on
6808 exit if none of the characters scanned was an exact match.
6809 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6810 when exact match is impossible due to invisible text, and the
6811 lines are truncated.
6813 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6815 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6818 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6820 Fix a significant slow-down of cursor motion with C-n, C-p,
6821 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6822 auto-repeat under bidi redisplay in fontified buffers.
6823 * xdisp.c (compute_stop_pos_backwards): New function.
6824 (next_element_from_buffer): Call compute_stop_pos_backwards to
6825 find a suitable prev_stop when we find ourselves before
6827 (reseat): Don't look for prev_stop, as that could mean a very long
6829 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6830 <cached_disp_overlay_modiff>: Cache for last found display string
6832 (compute_display_string_pos): Return the cached position if asked
6833 about the same buffer in the same area of character positions, and
6834 the buffer wasn't changed since the time the display string
6835 position was cached.
6837 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6839 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6840 is an integer, which is important for empty lines. (Bug#9149)
6842 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6844 * frame.c (Fmodify_frame_parameters): In tty case, update the
6845 default face if necessary (Bug#4238).
6847 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6849 * editfns.c (Fstring_to_char): No need to explain what a character
6850 is in the docstring (Bug#6576).
6852 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6854 * xml.c (parse_region): Make sure we always return a tree.
6856 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6858 * xml.c (parse_region): If a document contains only comments,
6861 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6863 * xml.c (make_dom): Return comments, too.
6865 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6868 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6869 and the surrounding thread.
6870 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6871 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6872 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6874 * s/openbsd.h (BROKEN_SIGIO): Define.
6875 * unexelf.c (unexec) [__OpenBSD__]:
6876 Don't update the .mdebug section of the Alpha COFF symbol table.
6878 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6880 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6883 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6885 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6886 This fixes some race conditions on the permissions of any newly
6889 * alloc.c (valid_pointer_p): Use pipe, not open.
6890 This fixes some permissions issues when debugging.
6892 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6893 If fchown fails to set both uid and gid, try to set just gid,
6894 as that is sometimes allowed. Adjust the file's mode to eliminate
6895 setuid or setgid bits that are inappropriate if fchown fails.
6897 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6899 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6900 to compare Lisp_Objects.
6901 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6902 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6903 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6905 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6907 * lread.c (read_integer): Unread even EOF character.
6908 (read1): Likewise. Properly record start position of symbol.
6910 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6911 symbol character follows.
6913 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6915 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6916 This works around a problem with the previous change to Fcopy_file.
6917 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6918 and without this change, GCC might complain about discarding
6919 fchown's return value.
6921 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6923 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6925 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6927 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6929 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6931 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6932 it's used from the C level.
6934 * process.c: Use the same condition for POLL_FOR_INPUT in both
6935 keyboard.c and process.c (bug#1858).
6937 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6939 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6940 (Fgnutls_boot): Use it.
6942 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6944 * doc.c (Fsubstitute_command_keys): Revert last change.
6946 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6948 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6949 quotes the next character, and doesn't affect other longer
6950 sequences (bug#8935).
6952 * lread.c (syms_of_lread): Clarify that is isn't only
6953 `eval-buffer' and `eval-defun' that's affected by
6954 `lexical-binding' (bug#8460).
6956 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6958 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6959 bidi redisplay when a line includes both an image and is truncated.
6961 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6963 Fix minor problems found by static checking.
6964 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6965 (elsz): Now a signed constant, not a size_t var. We prefer signed
6966 types to unsigned, to avoid integer comparison confusion. Without
6967 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6968 "cannot optimize loop, the loop counter may overflow", a symptom
6970 * indent.c (Fvertical_motion): Mark locals as initialized.
6971 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6973 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6975 * search.c (Fre_search_backward): Mention `case-fold-search' in
6976 all the re_search_* functions (bug#8138).
6978 * keyboard.c (Fopen_dribble_file): Document when the file is
6981 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6983 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6986 Support bidi reordering of display and overlay strings.
6987 * xdisp.c (compute_display_string_pos)
6988 (compute_display_string_end): Accept additional argument STRING.
6989 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6990 (reseat_to_string): Initialize bidi_it->string.s and
6991 bidi_it->string.schars.
6992 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6993 NULL (avoids a crash in bidi_paragraph_init).
6994 Initialize itb.string.lstring.
6995 (init_iterator): Call bidi_init_it only of a valid
6996 buffer position was specified. Initialize paragraph_embedding to
6998 (reseat_to_string): Initialize the bidi iterator.
6999 (display_string): If we need to ignore text properties of
7000 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7001 original value of -1 will not work with bidi.)
7002 (compute_display_string_pos): First arg is now struct
7003 `text_pos *'; all callers changed. Support display properties on
7005 (compute_display_string_end): Support display properties on Lisp
7007 (init_iterator, reseat_1, reseat_to_string): Initialize the
7008 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7009 when iterating on a string not from display properties).
7010 (compute_display_string_pos, compute_display_string_end):
7011 Fix calculation of the object to scan. Fixes an error when using
7013 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7014 base_level_stop; instead, set base_level_stop to BEGV.
7015 Fixes crashes in vertical-motion.
7016 (next_element_from_buffer): Improve commentary for when
7017 the iterator is before prev_stop.
7018 (init_iterator): Initialize bidi_p from the default value of
7019 bidi-display-reordering, not from buffer-local value. Use the
7020 buffer-local value only if initializing for buffer iteration.
7021 (handle_invisible_prop): Support invisible properties on strings
7022 that are being bidi-reordered.
7023 (set_iterator_to_next): Support bidi reordering of C strings and
7025 (next_element_from_string): Support bidi reordering of Lisp
7027 (handle_stop_backwards): Support Lisp strings as well.
7028 (display_string): Support display of R2L glyph rows.
7029 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7030 (init_iterator): Don't initialize it->bidi_p for strings
7032 (reseat_to_string): Initialize it->bidi_p for strings here.
7033 (next_element_from_string, next_element_from_c_string)
7034 (next_element_from_buffer): Add xassert's for correspondence
7035 between IT's object being iterated and it->bidi_it.string
7037 (face_before_or_after_it_pos): Support bidi iteration.
7038 (next_element_from_c_string): Handle the case of the first string
7039 character that is not the first one in the visual order.
7040 (get_visually_first_element): New function, refactored from common
7041 parts of next_element_from_buffer, next_element_from_string, and
7042 next_element_from_c_string.
7043 (tool_bar_lines_needed, redisplay_tool_bar)
7044 (display_menu_bar): Force left-to-right direction. Add a FIXME
7045 comment for making that be controlled by a user option.
7046 (push_it, pop_it): Save and restore the state of the
7047 bidi iterator. Save and restore the bidi_p flag.
7048 (pop_it): Iterate out of display property for string iteration as
7050 (iterate_out_of_display_property): Support iteration over strings.
7051 (handle_single_display_spec): Set up it->bidi_it for iteration
7052 over a display string, and call bidi_init_it.
7053 (handle_single_display_spec, next_overlay_string)
7054 (get_overlay_strings_1, push_display_prop): Set up the bidi
7055 iterator for displaying display or overlay strings.
7056 (forward_to_next_line_start): Don't use the shortcut if
7058 (back_to_previous_visible_line_start): If handle_display_prop
7059 pushed the iterator stack, restore the internal state of the bidi
7060 iterator by calling bidi_pop_it same number of times.
7061 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7062 and we are bidi-iterating, don't decrement the iterator position;
7063 instead, set the first_elt flag in the bidi iterator, to produce
7065 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7066 (push_display_prop): xassert that we are iterating a buffer.
7067 (push_it, pop_it): Save and restore paragraph_embedding member.
7068 (handle_single_display_spec, next_overlay_string)
7069 (get_overlay_strings_1, reseat_1, reseat_to_string)
7070 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7071 correctly. Don't assume unibyte strings are not bidi-reordered.
7072 (compute_display_string_pos)
7073 (compute_display_string_end): Fix handling the case of C string.
7074 (push_it, pop_it): Save and restore from_disp_prop_p.
7075 (handle_single_display_spec, push_display_prop): Set the
7076 from_disp_prop_p flag.
7077 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7078 (pop_it): Call iterate_out_of_display_property only if we are
7079 popping after iteration over a string that came from a display
7080 property. Fix a typo in popping stretch info. Add an assertion
7081 for verifying that the iterator position is in sync with the bidi
7083 (handle_single_display_spec, get_overlay_strings_1)
7084 (push_display_prop): Fix initialization of paragraph direction for
7085 string when that of the parent object is not yet determined.
7086 (reseat_1): Call bidi_init_it to resync the bidi
7087 iterator with IT's position. (Bug#7616)
7088 (find_row_edges): If ROW->start.pos gives position
7089 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7090 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7091 Reset the from_disp_prop_p flag.
7092 (SAVE_IT, RESTORE_IT): New macros.
7093 (pos_visible_p, face_before_or_after_it_pos)
7094 (back_to_previous_visible_line_start)
7095 (move_it_in_display_line_to, move_it_in_display_line)
7096 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7097 (try_scrolling, redisplay_window, display_line): Use them when
7098 saving a temporary copy of the iterator and restoring it back.
7099 (back_to_previous_visible_line_start, reseat_1)
7100 (init_iterator): Empty the bidi cache "stack".
7101 (move_it_in_display_line_to): If iterator ended up at
7102 EOL, but we never saw any buffer positions smaller than
7103 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7104 motion in bidi-reordered lines.
7105 (move_it_in_display_line_to): Record prev_method and prev_pos
7106 immediately before the call to set_iterator_to_next. Fixes cursor
7107 motion in bidi-reordered lines with stretch glyphs and strings
7108 displayed in margins. (Bug#8133) (Bug#8867)
7109 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7111 (pos_visible_p): Support positions in bidi-reordered lines.
7112 Save and restore bidi cache.
7114 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7115 (bidi_paragraph_info): Delete unused struct.
7116 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7117 (bidi_cache_start): New variable.
7118 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7120 (bidi_cache_fetch_state, bidi_cache_search)
7121 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7122 (bidi_cache_find, bidi_peek_at_next_level)
7123 (bidi_level_of_next_char, bidi_find_other_level_edge)
7124 (bidi_move_to_visually_next): Compare cache index with
7125 bidi_cache_start rather than with zero.
7126 (bidi_fetch_char): Accept new argument STRING; all callers
7127 changed. Support iteration over a string. Support strings with
7128 display properties. Support unibyte strings. Fix the type of
7129 `len' according to what STRING_CHAR_AND_LENGTH expects.
7130 (bidi_paragraph_init, bidi_resolve_explicit_1)
7131 (bidi_resolve_explicit, bidi_resolve_weak)
7132 (bidi_level_of_next_char, bidi_move_to_visually_next):
7133 Support iteration over a string.
7134 (bidi_set_sor_type, bidi_resolve_explicit_1)
7135 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7136 can now be zero (for strings); special values 0 and -1 were
7137 changed to -1 and -2, respectively.
7138 (bidi_char_at_pos): New function.
7139 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7140 Call it instead of FETCH_MULTIBYTE_CHAR.
7141 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7142 initialized to valid values.
7143 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7145 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7146 the test for valid cached positions. Fix the logic for looking up
7147 the sentinel state in the cache. GCPRO the Lisp string we are
7149 (bidi_push_it, bidi_pop_it): New functions.
7150 (bidi_initialize): Initialize the bidi cache start stack pointer.
7151 (bidi_cache_ensure_space): New function, refactored from part of
7152 bidi_cache_iterator_state. Don't assume the required size is just
7153 one BIDI_CACHE_CHUNK away.
7154 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7155 (bidi_count_bytes, bidi_char_at_pos): New functions.
7156 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7157 always valid if bidi_cache_idx is valid.
7158 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7159 is valid if it's going to be used.
7160 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7161 (bidi_cache_fetch_state, bidi_cache_search)
7162 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7163 (bidi_cache_iterator_state, bidi_cache_find)
7164 (bidi_find_other_level_edge, bidi_cache_start_stack):
7165 All variables related to cache indices are now EMACS_INT.
7167 * dispextern.h (struct bidi_string_data): New structure.
7168 (struct bidi_it): New member `string'. Make flag members be 1-bit
7169 fields, and put them last in the struct.
7170 (compute_display_string_pos, compute_display_string_end):
7172 (bidi_push_it, bidi_pop_it): Add prototypes.
7173 (struct iterator_stack_entry): New members bidi_p,
7174 paragraph_embedding, and from_disp_prop_p.
7175 (struct it): Member bidi_p is now a bit field 1 bit wide.
7176 (bidi_shelve_cache, bidi_unshelve_cache):
7179 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7180 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7181 and vector-like objects.
7183 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7184 cache around display iteration.
7186 * window.c (Fwindow_end, window_scroll_pixel_based)
7187 (displayed_window_lines, Frecenter): Save and restore the bidi
7188 cache around display iteration.
7190 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7192 * editfns.c (Fdelete_region): Clarify the use of the named
7193 parameters (bug#6788).
7195 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7197 * indent.c (Fvertical_motion): Set and restore w->pointm when
7198 saving and restoring the window's buffer (Bug#9006).
7200 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7202 * editfns.c (Fstring_to_char): Clarify just what is returned
7203 (bug#6576). Text by Eli Zaretskii.
7205 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7207 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7209 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7211 * buffer.c (mmap_find): Fix a typo.
7213 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7215 Fix execution of x selection hooks.
7216 * xselect.c (Qx_lost_selection_functions)
7217 (Qx_sent_selection_functions): New vars.
7218 (syms_of_xselect): DEFSYM them.
7219 (x_handle_selection_request): Pass Qx_sent_selection_functions
7220 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7221 (x_handle_selection_clear,x_clear_frame_selections):
7222 Pass Qx_lost_selection_functions rather than
7223 Vx_lost_selection_functions to Frun_hook_with_args.
7225 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7227 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7228 The old code sometimes used this field without initializing it.
7230 * alloc.c (gc_sweep): Don't read past end of array.
7231 In theory, the old code could also have corrupted Emacs internals,
7232 though it'd be very unlikely.
7234 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7236 * character.c (Fcharacterp): Don't advertise optional ignored
7237 argument. (Bug#4026)
7239 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7241 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7244 * window.c (Fset_window_start): Doc fix (bug#4199).
7245 (Fset_window_hscroll): Ditto.
7247 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7249 Fix minor new problems caught by GCC 4.6.1.
7250 * term.c (init_tty): Remove unused local.
7251 * xsettings.c (store_monospaced_changed): Define this function only
7252 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7255 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7257 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7259 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7261 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7262 are the mini-buffer and the echo area (bug#3320).
7264 * term.c (init_tty): Remove support for supdup, c10 and perq
7265 terminals, which are no longer supported (bug#1482).
7267 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7269 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7271 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7273 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7274 for non-popups (Bug#3642).
7276 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7278 * alloc.c (reset_malloc_hooks): Protoize.
7279 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7280 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7281 * cm.c (losecursor): Likewise.
7282 * data.c (fmod): Likewise.
7283 * dispnew.c (swap_glyphs_in_rows): Likewise.
7284 * emacs.c (memory_warning_signal): Likewise.
7285 * floatfns.c (float_error): Likewise.
7286 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7287 (otf_open, font_otf_capability, generate_otf_features)
7288 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7290 * image.c (pbm_read_file): Likewise.
7291 * indent.c (string_display_width): Likewise.
7292 * intervals.c (check_for_interval, search_for_interval)
7293 (inc_interval_count, count_intervals, root_interval)
7294 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7295 * lread.c (defalias): Likewise.
7296 * ralloc.c (r_alloc_check): Likewise.
7297 * regex.c (set_image_of_range_1, set_image_of_range)
7298 (regex_grow_registers): Likewise.
7299 * sysdep.c (strerror): Likewise.
7300 * termcap.c (valid_filename_p, tprint, main): Likewise.
7301 * tparam.c (main): Likewise.
7302 * unexhp9k800.c (run_time_remap, save_data_space)
7303 (update_file_ptrs, read_header, write_header, calculate_checksum)
7304 (copy_file, copy_rest, display_header): Likewise.
7305 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7307 * xdisp.c (check_it): Likewise.
7308 * xfaces.c (register_color, unregister_color, unregister_colors):
7310 * xfns.c (print_fontset_result): Likewise.
7311 * xrdb.c (member, fatal, main): Likewise.
7313 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7315 Fix minor problems found by static checking (Bug#9031).
7316 * chartab.c (char_table_set_range, map_sub_char_table):
7317 Remove unused locals.
7318 (uniprop_table): Now static.
7319 * composite.c (_work_char): Remove unused static var.
7321 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7323 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7325 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7327 * gtkutil.c (qttip_cb): Remove code without function.
7329 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7331 * w32.c (pthread_sigmask): New stub.
7333 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7335 Use pthread_sigmask, not sigprocmask (Bug#9010).
7336 sigprocmask is portable only for single-threaded applications, and
7337 Emacs can be multi-threaded when it uses GTK.
7338 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7340 * callproc.c (Fcall_process):
7341 * process.c (create_process):
7342 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7343 Use pthread_sigmask, not sigprocmask.
7345 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7347 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7348 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7351 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7353 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7354 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7355 (xg_hide_tooltip): Fix comment.
7357 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7358 in registerServicesMenuSendTypes.
7359 (validRequestorForSendType): Don't check ns_return_types.
7361 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7364 2011-07-08 Jason Rumney <jasonr@gnu.org>
7366 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7367 SH_SHOW for hidden windows (Bug#5482).
7369 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7370 frame struct members of non-existent frames (Bug#6284).
7372 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7374 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7375 variable firstTime not needed on OSX >= 10.6.
7376 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7377 >= 10.5. Use setKnobProportion, setDoubleValue.
7379 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7380 (MAC_OS_X_VERSION_10_5): Define if not defined.
7381 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7382 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7383 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7385 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7386 cString and lossyCString on OSX >= 10.4
7388 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7389 sizeToFit on OSX >= 10.2.
7391 * nsimage.m (allocInitFromFile): Don't use deprecated method
7392 bestRepresentationForDevice on OSX >= 10.6.
7394 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7397 * emacs.c: Declare unexec_init_emacs_zone.
7399 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7401 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7403 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7404 on svcsMenu (Bug#8842).
7406 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7408 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7410 * nsterm.m (QUTF8_STRING): Declare.
7411 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7412 (validRequestorForSendType): Return type is (id).
7413 Change indexOfObjectIdenticalTo to indexOfObject.
7414 Check if we have local selection before returning self (Bug#8842).
7415 (writeSelectionToPasteboard): Put local selection into paste board
7416 if we have a local selection (Bug#8842).
7417 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7419 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7420 (ns_get_local_selection): Declare.
7422 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7424 * keymap.c (describe_map_tree): Don't insert a double newline at
7425 the end of the buffer (bug#1169) and return whether we inserted
7428 * callint.c (Fcall_interactively): Change "reading args" to
7429 "providing args" to try to clarify what it does (bug#1010).
7431 2011-07-07 Kenichi Handa <handa@m17n.org>
7433 * composite.c (composition_compute_stop_pos): Ignore a static
7434 composition starting before CHARPOS (Bug#8915).
7436 * xdisp.c (handle_composition_prop): Likewise.
7438 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7440 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7443 2011-07-07 Kenichi Handa <handa@m17n.org>
7445 * character.h (unicode_category_t): New enum type.
7447 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7448 (Qchar_code_property_table): New variable.
7449 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7450 (UNIPROP_COMPRESSED_FORM_P): New macros.
7451 (char_table_ascii): Uncompress the compressed values.
7452 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7453 Uncompress the compressed values.
7454 (sub_char_table_ref_and_range): Likewise.
7455 (char_table_ref_and_range): Uncompress the compressed values.
7456 (sub_char_table_set): New arg is_uniprop. Callers changed.
7457 Uncompress the compressed values.
7458 (sub_char_table_set_range): Args changed. Callers changed.
7459 (char_table_set_range): Adjuted for the above change.
7460 (map_sub_char_table): Delete args default_val and parent. Add arg
7461 top. Give decoded values to a Lisp function.
7462 (map_char_table): Adjust for the above change. Give decoded
7463 values to a Lisp function. Gcpro more variables.
7464 (uniprop_table_uncompress)
7465 (uniprop_decode_value_run_length): New functions.
7466 (uniprop_decoder, uniprop_decoder_count): New variables.
7467 (uniprop_get_decoder, uniprop_encode_value_character)
7468 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7470 (uniprop_encoder, uniprop_encoder_count): New variables.
7471 (uniprop_get_encoder, uniprop_table)
7472 (Funicode_property_table_internal, Fget_unicode_property_internal)
7473 (Fput_unicode_property_internal): New functions.
7474 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7475 Sunicode_property_table_internal, Sget_unicode_property_internal,
7476 and Sput_unicode_property_internal. Defvar_lisp
7477 char-code-property-alist.
7479 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7480 Vunicode_category_table.
7482 * font.c (font_range): Adjust for the change of
7483 Vunicode_category_table.
7485 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7487 * m/iris4d.h: Remove file, move contents ...
7488 * s/irix6-5.h: ... here.
7490 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7492 Remove unportable assumption about struct layout (Bug#8884).
7493 * alloc.c (mark_buffer):
7494 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7495 (clone_per_buffer_values): Don't assume that
7496 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7497 This isn't true in general, and it's particularly not true
7498 if Emacs is configured with --with-wide-int.
7499 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7500 New macros, used in the buffer.c change.
7502 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7504 * xsettings.c: Use both GConf and GSettings if both are available.
7505 (store_config_changed_event): Add comment.
7506 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7507 (store_tool_bar_style_changed): New functions.
7508 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7509 (struct xsettings): Move font inside HAVE_XFT.
7510 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7511 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7512 Move inside HAVE_XFT.
7513 (something_changed_gsettingsCB): Rename from something_changedCB.
7514 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7516 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7517 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7518 (something_changed_gconfCB): Rename from something_changedCB.
7519 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7520 (parse_settings): Move check for font inside HAVE_XFT.
7521 (read_settings, apply_xft_settings): Add comment.
7522 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7523 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7524 call store_font_name_changed.
7525 (xft_settings_event): Add comment.
7526 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7527 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7528 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7529 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7530 (xsettings_initialize): Call init_gsettings last.
7531 (xsettings_get_system_font, xsettings_get_system_normal_font):
7534 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7536 Random fixes. E.g., (random) never returned negative values.
7537 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7538 subseconds part to the entropy, as that's a bit more random.
7539 Prefer signed to unsigned, since the signedness doesn't matter and
7540 in general we prefer signed. When given a limit, use a
7541 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7542 latter isn't right if USE_2_TAGS_FOR_INTS.
7543 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7544 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7546 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7548 * textprop.c (text_property_stickiness):
7549 Obey Vtext_property_default_nonsticky.
7550 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7551 * w32fns.c (syms_of_w32fns):
7552 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7554 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7556 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7557 This is more efficient than Ffile_directory_p and avoids a minor race.
7559 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7561 * buffer.c (Foverlay_put): Say what the return value is
7564 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7565 is a directory before asking whether to use the file name
7567 (barf_or_query_if_file_exists): Make the "File is a directory"
7568 error be more correct.
7570 * fns.c (Frequire): Remove the mention of the .gz files, since
7571 that's installation-specific, but keep the mention of
7572 `get-load-suffixes'.
7574 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7576 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7577 Report string overflow if the output is too long.
7579 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7581 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7582 (syms_of_gnutls): Remove duplicate DEFSYM for
7583 Qgnutls_bootprop_verify_hostname_error, an error for
7584 Qgnutls_bootprop_verify_error (which is no longer used).
7586 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7587 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7588 Also (re)move comments that are misplaced or no longer relevant.
7590 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7592 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7594 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7596 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7597 and background color parameters if they have been changed.
7599 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7601 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7603 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7605 * xsettings.c (SYSTEM_FONT): Define only when used.
7606 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7608 * keymap.c (access_keymap_1): Now static.
7610 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7612 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7613 leave any prefix arg for the up event (Bug#1586).
7615 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7617 * lread.c (syms_of_lread): Mention single symbols defined by
7618 `defvar' or `defconst' (bug#7154).
7620 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7621 (Frequire): Mention get-load-suffixes.
7623 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7625 * window.h (window): Remove clone_number slot.
7626 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7628 (make_parent_window, make_window, saved_window)
7629 (Fset_window_configuration, save_window_save): Don't deal with
7631 * buffer.c (Qclone_number): Remove declaration.
7632 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7634 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7636 Add multiple inheritance to keymaps.
7637 * keymap.c (Fmake_composed_keymap): New function.
7638 (Fset_keymap_parent): Simplify.
7639 (fix_submap_inheritance): Remove.
7640 (access_keymap_1): New function extracted from access_keymap to handle
7641 embedded parents and handle lists of maps.
7642 (access_keymap): Use it.
7643 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7644 (Fcopy_keymap): Handle embedded parents.
7645 (Fcommand_remapping, define_as_prefix): Simplify.
7646 (Fkey_binding): Simplify.
7647 (syms_of_keymap): Move minibuffer-local-completion-map,
7648 minibuffer-local-filename-completion-map,
7649 minibuffer-local-must-match-map, and
7650 minibuffer-local-filename-must-match-map to Elisp.
7651 (syms_of_keymap): Defsubr make-composed-keymap.
7652 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7653 (parse_menu_item): Trivial simplification.
7655 2011-07-01 Glenn Morris <rgm@gnu.org>
7657 * Makefile.in (SETTINGS_LIBS): Fix typo.
7659 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7661 * coding.c (Fencode_coding_string): Record the last coding system
7662 used, as the function doc string says (bug#8738).
7664 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7666 * xsettings.c (store_monospaced_changed): Take new font as arg and
7667 check for change against current_mono_font.
7668 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7669 (emacs_settings_constructor, emacs_settings_get_property)
7670 (emacs_settings_set_property, emacs_settings_class_init)
7671 (emacs_settings_init, gsettings_obj): Remove.
7672 (something_changedCB): New function for HAVE_GSETTINGS.
7673 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7674 with value as argument.
7675 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7676 g_settings_new (Bug#8967). Do not create gsettings_obj.
7677 Remove calls to g_settings_bind. Connect something_changedCB to
7680 * xgselect.c: Add defined (HAVE_GSETTINGS).
7681 (xgselect_initialize): Ditto.
7683 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7684 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7687 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7689 * eval.c (struct backtrace): Simplify and port the data structure.
7690 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7691 signed bit field, as this assumption is not portable and it makes
7692 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7693 "char debug_on_exit : 1" as this is not portable either; instead,
7694 use the portable "unsigned int debug_on_exit : 1". Remove unused
7695 member evalargs. Remove obsolete comments about cc bombing out.
7697 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7699 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7700 Let HAVE_GSETTINGS override HAVE_GCONF.
7701 (store_monospaced_changed): New function.
7702 (EMACS_SETTINGS): A new type derived from GObject to handle
7703 GSettings notifications.
7704 (emacs_settings_constructor, emacs_settings_get_property)
7705 (emacs_settings_set_property, emacs_settings_class_init):
7707 (gsettings_client, gsettings_obj): New variables.
7708 (GSETTINGS_SCHEMA): New define.
7709 (something_changedCB): Call store_monospaced_changed.
7710 (init_gsettings): New function.
7711 (xsettings_initialize): Call init_gsettings.
7712 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7715 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7718 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7720 * window.c (resize_root_window, grow_mini_window)
7721 (shrink_mini_window): Rename Qresize_root_window to
7722 Qwindow_resize_root_window and Qresize_root_window_vertically to
7723 Qwindow_resize_root_window_vertically.
7725 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7727 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7729 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7731 * makefile.w32-in: Redesign dependencies so they reflect more
7732 clearly which files are directly included by each source file,
7733 and not through other includes.
7735 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7737 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7738 (sort_overlays, overlay_strings): When an overlay's clone number
7739 matches the window's clone number process the overlay even if
7740 the overlay's window property doesn't match the current window.
7742 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7743 (Fwindow_hchild): Rename to Fwindow_left_child.
7744 (Fwindow_next): Rename to Fwindow_next_sibling.
7745 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7746 (resize_window_check): Rename to window_resize_check.
7747 (resize_window_apply): Rename to window_resize_apply.
7748 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7749 (Fdelete_other_windows_internal, resize_frame_windows)
7750 (Fsplit_window_internal, Fdelete_window_internal)
7751 (grow_mini_window, shrink_mini_window)
7752 (Fresize_mini_window_internal): Fix callers accordingly.
7754 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7756 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7757 (emacs_fixed_set_min_size): Remove.
7758 (emacs_fixed_new): Take frame as argument.
7760 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7761 (_EmacsFixedPrivate): Remove minwidth/height.
7762 Add struct frame *f.
7763 (emacs_fixed_init): Initialize priv->f.
7764 (get_parent_class, emacs_fixed_set_min_size): Remove.
7765 (emacs_fixed_new): Set priv->f to argument.
7766 (emacs_fixed_get_preferred_width)
7767 (emacs_fixed_get_preferred_height): Use min_width/height from
7768 frames size_hint to set minimum and natural (Bug#8919).
7769 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7770 and use min_width/height from frames size_hint to set
7771 min_width/height (Bug#8919).
7773 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7774 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7777 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7779 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7780 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7783 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7785 * process.c (wait_reading_process_output): Bypass select if
7786 waiting for a cell while ignoring keyboard input, and input is
7787 pending. Suggested by Jan Djärv (Bug#8869).
7789 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7791 Use gnulib's dup2 module instead of rolling our own.
7792 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7794 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7796 * dispnew.c (scrolling_window): Before scrolling, turn off a
7797 mouse-highlight in the window being scrolled.
7799 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7801 Move DEFSYM to lisp.h and use everywhere.
7803 * character.h (DEFSYM): Move declaration...
7804 * lisp.h (DEFSYM): ...here.
7810 * w32select.c: Don't include character.h.
7812 * alloc.c (syms_of_alloc):
7813 * buffer.c (syms_of_buffer):
7814 * bytecode.c (syms_of_bytecode):
7815 * callint.c (syms_of_callint):
7816 * casefiddle.c (syms_of_casefiddle):
7817 * casetab.c (init_casetab_once):
7818 * category.c (init_category_once, syms_of_category):
7819 * ccl.c (syms_of_ccl):
7820 * cmds.c (syms_of_cmds):
7821 * composite.c (syms_of_composite):
7822 * dbusbind.c (syms_of_dbusbind):
7823 * dired.c (syms_of_dired):
7824 * dispnew.c (syms_of_display):
7825 * doc.c (syms_of_doc):
7826 * editfns.c (syms_of_editfns):
7827 * emacs.c (syms_of_emacs):
7828 * eval.c (syms_of_eval):
7829 * fileio.c (syms_of_fileio):
7830 * fns.c (syms_of_fns):
7831 * frame.c (syms_of_frame):
7832 * fringe.c (syms_of_fringe):
7833 * insdel.c (syms_of_insdel):
7834 * keymap.c (syms_of_keymap):
7835 * lread.c (init_obarray, syms_of_lread):
7836 * macros.c (syms_of_macros):
7837 * msdos.c (syms_of_msdos):
7838 * print.c (syms_of_print):
7839 * process.c (syms_of_process):
7840 * search.c (syms_of_search):
7841 * sound.c (syms_of_sound):
7842 * syntax.c (init_syntax_once, syms_of_syntax):
7843 * terminal.c (syms_of_terminal):
7844 * textprop.c (syms_of_textprop):
7845 * undo.c (syms_of_undo):
7846 * w32.c (globals_of_w32):
7847 * window.c (syms_of_window):
7848 * xdisp.c (syms_of_xdisp):
7849 * xfaces.c (syms_of_xfaces):
7850 * xfns.c (syms_of_xfns):
7851 * xmenu.c (syms_of_xmenu):
7852 * xsettings.c (syms_of_xsettings):
7853 * xterm.c (syms_of_xterm): Use DEFSYM.
7855 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7857 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7859 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7861 Integer and buffer overflow fixes (Bug#8873).
7863 * print.c (printchar, strout): Check for string overflow.
7864 (PRINTPREPARE, printchar, strout):
7865 Don't set size unless allocation succeeds.
7867 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7868 for sizes. Check for string overflow more accurately.
7869 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7871 * macros.c: Integer and buffer overflow fixes.
7872 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7873 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7874 Use ptrdiff_t, not int, for sizes.
7875 Don't increment bufsize until after realloc succeeds.
7876 Check for size-calculation overflow.
7877 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7879 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7881 * lread.c: Integer overflow fixes.
7882 (read_integer): Radix is now EMACS_INT, not int,
7883 to improve quality of diagnostics for out-of-range radices.
7884 Calculate buffer size correctly for out-of-range radices.
7885 (read1): Check for integer overflow in radices, and in
7886 read-circle numbers.
7887 (read_escape): Avoid int overflow.
7888 (Fload, openp, read_buffer_size, read1)
7889 (substitute_object_recurse, read_vector, read_list, map_obarray):
7890 Use ptrdiff_t, not int, for sizes.
7891 (read1): Use EMACS_INT, not int, for sizes.
7892 Check for size overflow.
7894 * image.c (cache_image): Check for size arithmetic overflow.
7896 * lread.c: Integer overflow issues.
7897 (saved_doc_string_size, saved_doc_string_length)
7898 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7899 Now ptrdiff_t, not int.
7900 (read1): Don't assume doc string length fits in int. Check for
7901 out-of-range doc string lengths.
7902 (read_list): Don't assume file position fits in int.
7903 (read_escape): Check for hex character overflow.
7905 2011-06-22 Leo Liu <sdl.web@gmail.com>
7907 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7908 Move to minibuffer.el.
7910 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7912 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7913 The following patches are for when GLYPH_DEBUG && !XASSERT.
7914 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7915 * dispnew.c (flush_stdout):
7916 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7917 Mark as externally visible.
7918 * dispnew.c (check_window_matrix_pointers): Now static.
7919 * dispnew.c (window_to_frame_vpos):
7920 * xfns.c (unwind_create_frame):
7921 * xterm.c (x_check_font): Remove unused local.
7922 * scroll.c (CHECK_BOUNDS):
7923 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7924 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7925 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7926 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7927 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7929 (debug_method_add): Use va_list and vsprintf rather than relying
7930 on undefined behavior with wrong number of arguments.
7931 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7932 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7933 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7934 since we're not interested in debugging glyphs with old libraries.
7935 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7936 GCC 4.6.0's static checking.
7938 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7940 Integer overflow and signedness fixes (Bug#8873).
7941 A few related buffer overrun fixes, too.
7943 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7945 * dispextern.h (struct face.stipple):
7946 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7947 (x_bitmap_mask, x_allocate_bitmap_record)
7948 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7949 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7950 (x_create_bitmap_from_xpm_data):
7951 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7952 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7954 * xfaces.c (load_pixmap):
7955 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7956 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7957 (.bitmaps_last, struct x_output.icon_bitmap):
7958 Use ptrdiff_t, not int, for bitmap indexes.
7959 (x_allocate_bitmap_record): Check for size overflow.
7960 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7962 Use ptrdiff_t, not int, for overlay counts.
7963 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7964 * editfns.c (overlays_around, get_pos_property):
7965 * textprop.c (get_char_property_and_overlay):
7966 * xdisp.c (next_overlay_change, note_mouse_highlight):
7967 * xfaces.c (face_at_buffer_position):
7968 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7969 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7970 (Fnext_overlay_change, Fprevious_overlay_change)
7971 (mouse_face_overlay_overlaps, Foverlays_in):
7972 Use ptrdiff_t, not int, for sizes.
7973 (overlays_at, overlays_in): Check for size-calculation overflow.
7975 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7977 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7978 (x_session_initialize): Do not assume string length fits in int.
7980 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7981 This is unlikely, but can occur if DPI is outlandish.
7983 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7984 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7986 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7987 * xrdb.c (magic_file_p, search_magic_path):
7988 Omit last arg SUFFIX; it was always 0. All callers changed.
7989 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7991 * xfont.c (xfont_match): Avoid need for strlen.
7993 * xfns.c: Don't assume strlen fits in int.
7994 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7996 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7997 not unsigned long, as we prefer signed integers. All callers changed.
7998 Detect integer overflow in repeat count.
7999 (message_dolog): Don't assume print length fits in 39 bytes.
8000 (display_mode_element): Don't assume strlen fits in int.
8002 * termcap.c: Don't assume sizes fit in int and never overflow.
8003 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8004 (gobble_line): Check for size-calculation overflow.
8006 * minibuf.c (Fread_buffer):
8007 * lread.c (intern, intern_c_string):
8008 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8009 Don't assume string length fits in int.
8011 * keyboard.c (parse_tool_bar_item):
8012 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8014 * font.c: Don't assume string length fits in int.
8015 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8016 Use ptrdiff_t, not int.
8017 (font_intern_prop): Don't assume string length fits in int.
8018 Don't assume integer property fits in fixnum.
8019 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8021 * filelock.c: Fix some buffer overrun and integer overflow issues.
8022 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8023 Reformulate so as not to need the command string.
8024 Invoke gzip -cd rather than gunzip, as it's more portable.
8025 (lock_info_type, lock_file_1, lock_file):
8026 Don't assume pid_t and time_t fit in unsigned long.
8027 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8028 (current_lock_owner): Prefer signed type for sizes.
8029 Use memcpy, not strncpy, where memcpy is what is really wanted.
8030 Don't assume (via atoi) that time_t and pid_t fit in int.
8031 Check for time_t and/or pid_t out of range, e.g., via a network share.
8032 Don't alloca where an auto var works fine.
8034 * fileio.c: Fix some integer overflow issues.
8035 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8036 Don't assume string length fits in int.
8037 (directory_file_name): Don't assume string length fits in long.
8038 (make_temp_name): Don't assume pid fits in int, or that its print
8039 length is less than 20.
8041 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8043 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8045 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8047 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8048 We prefer signed integers, even for size calculations.
8050 * emacs.c: Don't assume string length fits in 'int'.
8051 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8052 (main): Don't invoke strlen when not needed.
8054 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8055 (XD_DEBUG_MESSAGE): Don't waste a byte.
8057 * callproc.c (getenv_internal_1, getenv_internal)
8059 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8061 * lread.c (invalid_syntax): Omit length argument.
8062 All uses changed. This doesn't fix a bug, but it simplifies the
8063 code away from its former Hollerith-constant appearance, and it's
8064 one less 'int' to worry about when looking at integer-overflow issues.
8065 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8067 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8068 This didn't break anything, but it didn't help either.
8069 It's confusing to put a bogus integer in a place where the actual
8070 value does not matter.
8071 (LIST_END_P): Remove unused macro and its bogus comment.
8072 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8074 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8075 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8077 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8078 We prefer signed types, and the value cannot exceed the EMACS_INT
8079 range anyway (because otherwise the length would not be representable).
8080 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8081 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8082 This avoids a GCC warning when WIDE_EMACS_INT.
8084 * indent.c (sane_tab_width): New function.
8085 (current_column, scan_for_column, Findent_to, position_indentation)
8086 (compute_motion): Use it. This is just for clarity.
8087 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8089 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8091 * lisp.h (lint_assume): New macro.
8092 * composite.c (composition_gstring_put_cache):
8093 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8095 * editfns.c, insdel.c:
8096 Omit unnecessary forward decls, to simplify future changes.
8098 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8100 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8102 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8103 Use much-faster test for byte-length change.
8104 Don't assume string byte-length fits in 'int'.
8105 Check that character arg fits in 'int'.
8106 (mapcar1): Declare byte as byte, for clarity.
8108 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8110 * fns.c (concat): Catch string overflow earlier.
8111 Do not rely on integer wraparound.
8113 * dispextern.h (struct it.overlay_strings_charpos)
8114 (struct it.selective): Now EMACS_INT, not int.
8115 * xdisp.c (forward_to_next_line_start)
8116 (back_to_previous_visible_line_start)
8117 (reseat_at_next_visible_line_start, next_element_from_buffer):
8118 Don't arbitrarily truncate the value of 'selective' to int.
8120 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8122 * composite.c: Don't truncate sizes to 'int'.
8123 (composition_gstring_p, composition_reseat_it)
8124 (composition_adjust_point): Use EMACS_INT, not int.
8125 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8126 not EMACS_UINT, for indexes.
8128 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8130 * buffer.c: Include <verify.h>.
8131 (struct sortvec.priority, struct sortstr.priority):
8132 Now EMACS_INT, not int.
8133 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8134 (struct sortstr.size, record_overlay_string)
8135 (struct sortstrlist.size, struct sortlist.used):
8136 Don't truncate size to int.
8137 (record_overlay_string): Check for size-calculation overflow.
8138 (init_buffer_once): Check at compile-time, not run-time.
8140 2011-06-22 Jim Meyering <meyering@redhat.com>
8142 Don't leak an XBM-image-sized buffer
8143 * image.c (xbm_load): Free the image buffer after using it.
8145 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8148 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8149 that Sun C diagnosed.
8150 * fns.c (secure_hash): Fix pointer signedness issue.
8151 * intervals.c (static_offset_intervals): New function.
8152 (offset_intervals): Use it.
8154 2011-06-21 Leo Liu <sdl.web@gmail.com>
8157 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8160 * fns.c (secure_hash): Rename from crypto_hash_function and change
8161 the first arg to accept symbols.
8162 (Fsecure_hash): New primitive.
8163 (syms_of_fns): New symbols.
8165 2011-06-20 Deniz Dogan <deniz@dogan.se>
8167 * process.c (Fset_process_buffer): Clarify return value in
8170 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8172 * dispnew.c (add_window_display_history): Use BVAR.
8174 * xdisp.c (debug_method_add): Use BVAR.
8175 (check_window_end, dump_glyph_matrix, dump_glyph)
8176 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8178 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8181 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8182 check till after the cache is created in init_frame_faces.
8184 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8186 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8188 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8190 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8191 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8192 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8194 Improve buffer-overflow checking (Bug#8873).
8195 * fileio.c (Finsert_file_contents):
8196 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8197 Remove the old (too-loose) buffer overflow checks.
8198 They weren't needed, since make_gap checks for buffer overflow.
8199 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8200 The old code merely checked for Emacs fixnum overflow, and relied
8201 on undefined (wraparound) behavior. The new code avoids undefined
8202 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8204 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8205 Tune. Don't use wider integers than needed. Don't use alloca.
8206 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8208 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8210 * insdel.c, lisp.h (buffer_overflow): New function.
8211 (insert_from_buffer_1, replace_range, replace_range_2):
8212 * insdel.c (make_gap_larger):
8213 * editfns.c (Finsert_char):
8214 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8216 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8218 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8220 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8222 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8223 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8225 * fileio.c: Don't assume EMACS_INT fits in off_t.
8226 (emacs_lseek): New static function.
8227 (Finsert_file_contents, Fwrite_region): Use it.
8228 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8230 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8232 * fns.c: Don't overflow int when computing a list length.
8233 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8234 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8235 truncation on 64-bit hosts. Check for QUIT every
8236 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8237 faster and is responsive enough.
8238 (Flength): Report an error instead of overflowing an integer.
8239 (Fsafe_length): Return a float if the value is not representable
8240 as a fixnum. This shouldn't happen except in contrived situations.
8241 (Fnthcdr, Fsort): Don't assume list length fits in int.
8242 (Fcopy_sequence): Don't assume vector length fits in int.
8244 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8245 (header_size, word_size): New constants.
8246 (allocate_vectorlike): Don't check size overflow here.
8247 (allocate_vector): Check it here instead, since this is the only
8248 caller of allocate_vectorlike that could cause overflow.
8249 Check that the new vector's length is representable as a fixnum.
8251 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8252 The previous code was bogus. For example, next_almost_prime (32)
8253 returned 39, which is undesirable as it is a multiple of 3; and
8254 next_almost_prime (24) returned 25, which is a multiple of 5 so
8255 why was the code bothering to check for multiples of 7?
8257 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8259 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8261 Variadic C functions now count arguments with ptrdiff_t.
8262 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8263 Back then I didn't know that the Emacs coding style prefers signed int.
8264 Also, in the meantime I found a few more instances where arguments
8265 were being counted with int, which may truncate counts on 64-bit
8266 machines, or EMACS_INT, which may be unnecessarily wide.
8267 * lisp.h (struct Lisp_Subr.function.aMANY)
8268 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8269 Arg counts are now ptrdiff_t, not size_t.
8270 All variadic functions and their callers changed accordingly.
8271 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8272 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8273 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8274 * callint.c (Fcall_interactively): Check arg count for overflow,
8275 to avoid potential buffer overrun. Use signed char, not 'int',
8276 for 'varies' array, so that we needn't bother to check its size
8277 calculation for overflow.
8278 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8279 * eval.c (apply_lambda):
8280 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8281 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8282 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8284 * callint.c (Fcall_interactively): Don't use index var as event count.
8286 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8287 * mem-limits.h (SIZE): Remove; no longer used.
8289 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8291 Remove unnecessary casts.
8292 * xterm.c (x_term_init):
8293 * xfns.c (x_set_border_pixel):
8294 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8295 These aren't needed now that we assume ANSI C.
8297 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8298 It's more likely to cause problems (due to unsigned overflow)
8301 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8303 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8305 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8307 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8309 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8311 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8313 GLYPH_CODE_FACE returns EMACS_INT, not int.
8314 * dispextern.h (merge_faces):
8315 * xfaces.c (merge_faces):
8316 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8317 Don't assume EMACS_INT fits in int.
8319 * character.h (CHAR_VALID_P): Remove unused parameter.
8320 * fontset.c, lisp.h, xdisp.c: All uses changed.
8322 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8324 * fns.c (concat): Minor tuning based on overflow analysis.
8325 This doesn't fix any bugs. Use int to hold character, instead
8326 of constantly refetching from Emacs object. Use XFASTINT, not
8327 XINT, for value known to be a character. Don't bother comparing
8328 a single byte to 0400, as it's always less.
8330 * floatfns.c (Fexpt):
8331 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8333 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8336 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8338 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8339 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8340 incorrectly succeed when S was a string, because 4294967386 was
8341 truncated before it was used.
8343 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8344 Otherwise, an out-of-range integer could cause undefined behavior
8347 * composite.c: Use int, not EMACS_INT, for characters.
8348 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8349 EMACS_INT, for values that are known to be in character range.
8350 This doesn't fix any bugs but is the usual style inside Emacs and
8351 may generate better code on 32-bit machines.
8353 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8354 This is for reasons similar to the recent CHAR_STRING fix.
8355 * charset.c (Fencode_char): Check that character arg is actually
8356 a character. Pass an int to ENCODE_CHAR.
8357 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8358 wider than 'int', as a compile-time check to prevent future regressions
8361 * character.c (char_string): Remove unnecessary casts.
8363 Make sure a 64-bit char is never passed to CHAR_STRING.
8364 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8365 by silently ignoring the top 32 bits, allowing some values
8366 that were far too large to be valid characters.
8367 * character.h: Include <verify.h>.
8368 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8369 arguments are no wider than unsigned, as a compile-time check
8370 to prevent future regressions in this area.
8372 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8373 (Fsubst_char_in_region):
8375 * xdisp.c (decode_mode_spec_coding):
8376 Adjust to CHAR_STRING's new requirement.
8377 * editfns.c (Finsert_char, Fsubst_char_in_region):
8378 * fns.c (concat): Check that character args are actually
8379 characters. Without this test, these functions did the wrong
8380 thing with wildly out-of-range values on 64-bit hosts.
8382 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8383 These casts should not be needed on 32-bit hosts, either.
8384 * keyboard.c (read_char):
8385 * lread.c (Fload): Remove casts to unsigned.
8387 * lisp.h (UNSIGNED_CMP): New macro.
8388 This fixes comparison bugs on 64-bit hosts.
8389 (ASCII_CHAR_P): Use it.
8390 * casefiddle.c (casify_object):
8391 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8392 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8393 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8394 * dispextern.h (FACE_FROM_ID):
8395 * keyboard.c (read_char): Use UNSIGNED_CMP.
8397 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8398 not to EMACS_INT, to avoid GCC warning.
8400 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8402 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8403 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8404 isn't needed on 32-bit machines.
8406 * buffer.c (Fgenerate_new_buffer_name):
8407 Use EMACS_INT for count, not int.
8408 (advance_to_char_boundary): Return EMACS_INT, not int.
8410 * data.c (Qcompiled_function): Now static.
8412 * window.c (window_body_lines): Now static.
8414 * image.c (gif_load): Rename local to avoid shadowing.
8416 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8417 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8418 * alloc.c (make_save_value): Integer argument is now of type
8420 (mark_object): Use ptrdiff_t, not int.
8421 * lisp.h (pD): New macro.
8422 * print.c (print_object): Use it.
8424 * alloc.c: Use EMACS_INT, not int, to count objects.
8425 (total_conses, total_markers, total_symbols, total_vector_size)
8426 (total_free_conses, total_free_markers, total_free_symbols)
8427 (total_free_floats, total_floats, total_free_intervals)
8428 (total_intervals, total_strings, total_free_strings):
8429 Now EMACS_INT, not int. All uses changed.
8430 (Fgarbage_collect): Compute overall total using a double, so that
8431 integer overflow is less likely to be a problem. Check for overflow
8432 when converting back to an integer.
8433 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8434 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8435 These were 'int' variables that could overflow on 64-bit hosts;
8436 they were never used, so remove them instead of repairing them.
8437 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8438 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8439 Previously, this ceilinged at INT_MAX, but that doesn't work on
8441 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8443 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8444 (allocate_vectorlike): Check for ptrdiff_t overflow.
8445 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8446 when a (possibly-narrower) signed value would do just as well.
8447 We prefer using signed arithmetic, to avoid comparison confusion.
8449 * alloc.c: Catch some string size overflows that we were missing.
8450 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8451 for convenience in STRING_BYTES_MAX.
8452 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8453 The definition here is exact; the one in lisp.h was approximate.
8454 (allocate_string_data): Check for string overflow. This catches
8455 some instances we weren't catching before. Also, it catches
8456 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8457 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8458 and ptrdiff_t and EMACS_INT are both 64 bits.
8460 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8461 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8462 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8464 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8466 * alloc.c (Fmake_string): Check for out-of-range init.
8468 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8470 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8472 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8474 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8475 xg_get_default_scrollbar_width.
8477 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8478 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8479 (style_changed_cb): Call update_theme_scrollbar_width and call
8480 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8481 all frames (Bug#8505).
8482 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8483 Call gtk_window_set_resizable if HAVE_GTK3.
8484 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8485 and height if HAVE_GTK3 (Bug#8505).
8486 (scroll_bar_width_for_theme): New variable.
8487 (update_theme_scrollbar_width): New function.
8488 (xg_get_default_scrollbar_width): Move code to
8489 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8490 (xg_initialize): Call update_theme_scrollbar_width.
8492 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8494 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8496 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8498 * frame.c (make_frame): Call other_buffer_safely instead of
8501 * window.c (temp_output_buffer_show): Call display_buffer with
8502 second argument Vtemp_buffer_show_specifiers and reset latter
8503 immediately after the call.
8504 (Vtemp_buffer_show_specifiers): New variable.
8505 (auto_window_vscroll_p, next_screen_context_lines)
8506 (Vscroll_preserve_screen_position): Remove leading asterisks from
8509 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8511 Fix minor problems found by GCC 4.6.0 static checking.
8512 * buffer.c (Qclone_number): Remove for now, as it's unused.
8513 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8514 (record_buffer): Remove unused local.
8515 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8516 (set_frame_buffer_list): Remove; unused.
8517 * frame.h (other_visible_frames): Remove decl.
8518 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8519 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8520 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8522 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8523 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8524 Define only if HAVE_GPM.
8525 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8526 (update_hints_inhibit): Remove; never set. All uses removed.
8527 * widgetprv.h (emacsFrameClassRec): Remove decl.
8528 * window.c (delete_deletable_window): Now returns void, since it
8529 wasn't returning anything.
8530 (compare_window_configurations): Remove unused locals.
8531 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8532 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8533 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8534 the same widths as pointers. This follows up on the 2011-05-06 patch.
8535 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8536 * xterm.h: Likewise.
8537 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8539 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8541 * makefile.w32-in: Update dependencies.
8542 (LISP_H): Add lib/intprops.h.
8544 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8546 * image.c (gif_load): Add animation frame delay to the metadata.
8547 (syms_of_image): Use DEFSYM. New symbol `delay'.
8549 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8551 * window.c (delete_deletable_window): Re-add.
8552 (Fset_window_configuration): Rewrite to handle dead buffers and
8553 consequently deletable windows.
8554 (window_tree, Fwindow_tree): Remove. Supply functionality in
8556 (compare_window_configurations): Simplify code.
8558 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8560 * image.c (imagemagick_load_image): Fix type mismatch.
8561 (Fimagemagick_types): Likewise.
8563 * window.h (replace_buffer_in_windows): Declare.
8565 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8567 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8568 Qclone_number. Remove external declaration of Qdelete_window.
8569 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8571 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8572 Run Qbuffer_list_update_hook if allowed.
8573 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8574 buffer list implementation.
8575 (other_buffer_safely): New function.
8576 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8577 calls to replace_buffer_in_windows and
8578 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8580 (record_buffer): Inhibit quitting and rewrite using quittable
8581 functions. Run Qbuffer_list_update_hook if allowed.
8582 (Frecord_buffer, Funrecord_buffer): New functions.
8583 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8584 Move switch-to-buffer to window.el.
8585 (bury-buffer): Move to window.el.
8586 (Vbuffer_list_update_hook): New variable.
8588 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8591 * window.h (resize_frame_windows): Move up in code.
8592 (Fwindow_frame): Remove EXFUN.
8593 (replace_buffer_in_all_windows): Remove prototype.
8594 (replace_buffer_in_windows_safely): Add prototype.
8596 * window.c: Declare Qdelete_window static again. Move down
8597 declaration of select_count.
8598 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8599 (Fother_window): Move to window.el.
8600 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8601 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8602 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8604 (replace_buffer_in_windows): Implement by calling
8605 Qreplace_buffer_in_windows.
8606 (replace_buffer_in_all_windows): Remove with some functionality
8607 moved into replace_buffer_in_windows_safely.
8608 (replace_buffer_in_windows_safely): New function.
8609 (select_window_norecord, select_frame_norecord): Move in front
8610 of run_window_configuration_change_hook. Remove now obsolete
8612 (Fset_window_buffer): Rewrite doc-string.
8613 Call Qrecord_window_buffer.
8614 (keys_of_window): Move binding for other-window to window.el.
8616 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8618 * dispextern.h (struct image): Replace data member, whose int_val
8619 and ptr_val fields were not used by anything, with a single
8622 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8623 (gif_clear_image, gif_load, imagemagick_load_image)
8624 (gs_clear_image, gs_load): Callers changed.
8626 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8628 * buffer.h: Include <time.h>, for time_t.
8629 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8631 Fix minor problems found by static checking.
8633 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8635 Make identifiers static if they are not used in other modules.
8636 * data.c (Qcompiled_function, Qframe, Qvector):
8637 * image.c (QimageMagick, Qsvg):
8638 * minibuf.c (Qmetadata):
8639 * window.c (resize_window_check, resize_root_window): Now static.
8640 * window.h (resize_window_check, resize_root_window): Remove decls.
8642 * window.c (window_deletion_count, delete_deletable_window):
8644 (window_body_lines): Now static.
8645 (Fdelete_other_windows_internal): Mark vars as initialized.
8646 Make sure 'resize_failed' is initialized.
8647 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8648 (resize_window_apply): Remove unused local.
8649 * window.h (delete_deletable_window): Remove decl.
8651 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8652 (imagemagick_load_image): Fix pointer signedness problem by changing
8653 last arg from unsigned char * to char *. All uses changed.
8654 Also, fix a local for similar reasons.
8655 Remove unused locals. Remove locals to avoid shadowing.
8656 (fn_rsvg_handle_free): Remove; unused.
8657 (svg_load, svg_load_image): Fix pointer signedness problem.
8658 (imagemagick_load_image): Don't use garbage pointer image_wand.
8660 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8662 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8664 * image.c (gif_load): Fix omitted cast error introduced by
8667 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8669 * window.h (resize_proportionally, orig_total_lines)
8670 (orig_top_line): Remove from window structure.
8671 (set_window_height, set_window_width, change_window_heights)
8672 (Fdelete_window): Remove prototypes.
8673 (resize_frame_windows): Remove duplicate declaration.
8675 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8677 * window.h (resize_frame_windows, resize_window_check)
8678 (delete_deletable_window, resize_root_window)
8679 (resize_frame_windows): Declare prototypes.
8681 * window.c (resize_window_apply): Make definition be "static" to
8682 match the prototype.
8684 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8686 * window.c: Remove declarations of Qwindow_size_fixed,
8687 window_min_size_1, window_min_size_2, window_min_size,
8688 size_window, window_fixed_size_p, enlarge_window, delete_window.
8689 Remove static from declaration of Qdelete_window, it's
8690 temporarily needed by Fbury_buffer.
8691 (replace_window): Don't assign orig_top_line and
8693 (Fdelete_window, delete_window): Remove. Window deletion is
8694 handled by window.el.
8695 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8696 Replace Fdelete_window calls with calls to Qdelete_window.
8697 (Fdelete_other_windows): Remove. Deleting other windows is
8698 handled by window.el.
8699 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8700 handled in window.el.
8701 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8702 Window minimum sizes are handled in window.el.
8703 (shrink_windows, size_window, set_window_height)
8704 (set_window_width, change_window_heights, window_height)
8705 (window_width, CURBEG, CURSIZE, enlarge_window)
8706 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8707 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8708 handled in window.el.
8709 (make_dummy_parent): Rename to make_parent_window and give it a
8710 second argument horflag.
8711 (make_window): Don't set resize_proportionally any more.
8712 (Fsplit_window): Remove. Windows are split in window.el.
8713 (save_restore_action, save_restore_orig_size)
8714 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8715 Resize mini windows in window.el.
8716 (grow_mini_window, shrink_mini_window): Implement by calling
8717 Qresize_root_window_vertically, resize_window_check and
8718 resize_window_apply.
8719 (saved_window, Fset_window_configuration, save_window_save):
8720 Do not handle orig_top_line, orig_total_lines, and
8721 resize_proportionally.
8722 (window_min_height, window_min_width): Move to window.el.
8723 (keys_of_window): Move bindings for delete-other-windows,
8724 split-window, delete-window and enlarge-window to window.el.
8726 * buffer.c: Temporarily extern Qdelete_window.
8727 (Fbury_buffer): Temporarily call Qdelete_window instead of
8728 Fdelete_window (Fbury_buffer will move to window.el soon).
8730 * frame.c (set_menu_bar_lines_1): Remove code handling
8731 orig_top_line and orig_total_lines.
8733 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8734 set_window_height but set heights directly.
8735 (change_frame_size_1): Use resize_frame_windows.
8737 * xdisp.c (init_xdisp): Don't use set_window_height but set
8740 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8741 Use resize_frame_windows instead of change_window_heights and run
8742 run_window_configuration_change_hook.
8744 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8745 instead of change_window_heights and run
8746 run_window_configuration_change_hook.
8748 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8750 * window.c (replace_window): Rename second argument REPLACEMENT to
8751 NEW. New third argument SETFLAG. Rewrite.
8752 (delete_window, make_dummy_parent): Call replace_window with
8754 (window_list_1): Move down in code.
8755 (run_window_configuration_change_hook): Move set_buffer part
8756 before select_frame_norecord part in order to unwind correctly.
8757 Rename count1 to count.
8758 (recombine_windows, delete_deletable_window, resize_root_window)
8759 (Fdelete_other_windows_internal)
8760 (Frun_window_configuration_change_hook, make_parent_window)
8761 (resize_window_check, resize_window_apply, Fresize_window_apply)
8762 (resize_frame_windows, Fsplit_window_internal)
8763 (Fdelete_window_internal, Fresize_mini_window_internal):
8765 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8767 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8769 * window.h (window): Add some new members to window structure -
8770 normal_lines, normal_cols, new_total, new_normal, clone_number,
8771 splits, nest, prev_buffers, next_buffers.
8772 (WINDOW_TOTAL_SIZE): Move here from window.c.
8773 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8775 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8777 (make_dummy_parent): Set new members of windows structure.
8778 (make_window): Move down in code. Handle new members of window
8780 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8781 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8782 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8783 (Fset_window_prev_buffers, Fwindow_next_buffers)
8784 (Fset_window_next_buffers, Fset_window_clone_number):
8786 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8787 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8789 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8790 Argument WINDOW can be now internal window too.
8791 (Fwindow_use_time): Move up in code.
8792 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8794 (Fset_window_configuration, saved_window)
8795 (Fcurrent_window_configuration, save_window_save): Handle new
8796 members of window structure.
8797 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8798 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8799 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8800 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8801 Qget_mru_window, Qresize_root_window,
8802 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8803 Qauto_buffer_name; staticpro them.
8805 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8807 * window.c (Fwindow_total_size, Fwindow_left_column)
8808 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8809 (Fwindow_list_1): New functions.
8810 (window_box_text_cols): Replace with window_body_cols.
8811 (Fwindow_width, Fscroll_left, Fscroll_right):
8812 Use window_body_cols instead of window_box_text_cols.
8813 (delete_window, Fset_window_configuration):
8814 Call delete_all_subwindows with window as argument.
8815 (delete_all_subwindows): Take a window as argument and not a
8817 (window_loop): Remove handling of GET_LRU_WINDOW and
8819 (Fget_lru_window, Fget_largest_window): Move to window.el.
8821 * window.h: Extern window_body_cols instead of
8822 window_box_text_cols. delete_all_subwindows now takes a
8823 Lisp_Object as argument.
8825 * indent.c (compute_motion, Fcompute_motion):
8826 Use window_body_cols instead of window_box_text_cols.
8828 * frame.c (delete_frame): Call delete_all_subwindows with root
8831 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8833 * fns.c (Fputhash): Document return value.
8835 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8837 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8839 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8841 Cons<->int and similar integer overflow fixes (Bug#8794).
8843 Check for overflow when converting integer to cons and back.
8844 * charset.c (Fdefine_charset_internal, Fdecode_char):
8845 Use cons_to_unsigned to catch overflow.
8846 (Fencode_char): Use INTEGER_TO_CONS.
8847 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8848 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8849 * data.c (long_to_cons, cons_to_long): Remove.
8850 (cons_to_unsigned, cons_to_signed): New functions.
8851 These signal an error for invalid or out-of-range values.
8852 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8853 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8854 * font.c (Ffont_variation_glyphs):
8855 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8856 * lisp.h: Include <intprops.h>.
8857 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8858 (cons_to_signed, cons_to_unsigned): New decls.
8859 (long_to_cons, cons_to_long): Remove decls.
8860 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8861 (Fprimitive_undo): Use CONS_TO_INTEGER.
8862 * xfns.c (Fx_window_property): Likewise.
8863 * xselect.c: Include <limits.h>.
8864 (x_own_selection, selection_data_to_lisp_data):
8865 Use INTEGER_TO_CONS.
8866 (x_handle_selection_request, x_handle_selection_clear)
8867 (x_get_foreign_selection, Fx_disown_selection_internal)
8868 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8869 (lisp_data_to_selection_data): Use cons_to_unsigned.
8870 (x_fill_property_data): Use cons_to_signed.
8871 Report values out of range.
8873 Check for buffer and string overflow more precisely.
8874 * buffer.h (BUF_BYTES_MAX): New macro.
8875 * lisp.h (STRING_BYTES_MAX): New macro.
8876 * alloc.c (Fmake_string):
8877 * character.c (string_escape_byte8):
8878 * coding.c (coding_alloc_by_realloc):
8879 * doprnt.c (doprnt):
8880 * editfns.c (Fformat):
8882 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8883 since they may not be the same number.
8884 * editfns.c (Finsert_char):
8885 * fileio.c (Finsert_file_contents):
8886 Likewise for BUF_BYTES_MAX.
8888 * image.c: Use ptrdiff_t, not int, for sizes.
8889 (slurp_file): Switch from int to ptrdiff_t.
8891 (slurp_file): Check that file size fits in both size_t (for
8892 malloc) and ptrdiff_t (for sanity and safety).
8894 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8895 if b->modtime has its maximal value.
8897 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8899 Don't assume time_t can fit into int.
8900 * buffer.h (struct buffer.modtime): Now time_t, not int.
8901 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8902 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8904 Minor fixes for signed vs unsigned integers.
8905 * character.h (MAYBE_UNIFY_CHAR):
8906 * charset.c (maybe_unify_char):
8907 * keyboard.c (read_char, reorder_modifiers):
8908 XINT -> XFASTINT, since the integer must be nonnegative.
8909 * ftfont.c (ftfont_spec_pattern):
8910 * keymap.c (access_keymap, silly_event_symbol_error):
8911 XUINT -> XFASTINT, since the integer must be nonnegative.
8912 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8913 since it makes no difference and we prefer signed.
8914 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8915 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8918 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8920 * window.h (Fwindow_frame): Declare.
8922 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8924 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8925 (SPARE_MEMORY): Always define.
8926 (LARGE_REQUEST): Remove.
8927 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8929 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8931 * lisp.h: Move EXFUNS for Fframe_root_window,
8932 Fframe_first_window and Fset_frame_selected_window to window.h.
8934 * window.h: Move EXFUNS for Fframe_root_window,
8935 Fframe_first_window and Fset_frame_selected_window here from
8938 * frame.c (Fwindow_frame, Fframe_first_window)
8939 (Fframe_root_window, Fframe_selected_window)
8940 (Fset_frame_selected_window): Move to window.c.
8941 (Factive_minibuffer_window): Move to minibuf.c.
8942 (Fother_visible_frames_p): New function.
8944 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8946 * window.c (decode_window, decode_any_window): Move up in code.
8947 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8948 (inhibit_frame_unsplittable): Remove unused variable.
8949 (Fwindow_buffer): Move up and rewrite doc-string.
8950 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8951 (Fwindow_prev): New functions.
8952 (Fwindow_frame): Move here from frame.c. Accept any window as
8954 (Fframe_root_window, Fframe_first_window)
8955 (Fframe_selected_window): Move here from frame.c. Accept frame
8956 or arbitrary window as argument. Update doc-strings.
8957 (Fminibuffer_window): Move up in code.
8958 (Fwindow_minibuffer_p): Move up in code and simplify.
8959 (Fset_frame_selected_window): Move here from frame.c.
8961 (Fselected_window, select_window, Fselect_window): Move up in
8962 code. Minor doc-string fixes.
8964 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8966 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8967 Do not assume that spare memory exists; that assumption is valid
8968 only if SYSTEM_MALLOC.
8969 (LARGE_REQUEST): New macro, so that the issue of large requests
8970 is separated from the issue of spare memory.
8972 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8974 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8977 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8979 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8982 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8984 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8986 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8988 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8989 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8991 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8993 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8995 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8997 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8998 (x_clipboard_manager_save): Add return value.
8999 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9001 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9002 Obey Vx_select_enable_clipboard_manager. Catch errors in
9003 x_clipboard_manager_save (Bug#8779).
9004 (Vx_select_enable_clipboard_manager): New variable.
9005 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9007 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9009 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9011 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9013 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9014 in the current matrix if keep_current_p is non-zero.
9016 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9018 * bidi.c (bidi_level_of_next_char): Fix last change.
9020 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9022 Support bidi reordering of text covered by display properties.
9024 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9025 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9026 (bidi_cache_search, bidi_cache_iterator_state)
9027 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9028 (bidi_level_of_next_char, bidi_move_to_visually_next):
9029 Support character positions inside a run of characters covered by a
9031 (bidi_paragraph_init, bidi_resolve_explicit_1)
9032 (bidi_level_of_next_char): Call bidi_fetch_char and
9033 bidi_fetch_char_advance instead of FETCH_CHAR and
9035 (bidi_init_it): Initialize new members.
9036 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9038 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9039 instead of using explicit *_CHAR codes.
9040 (bidi_resolve_explicit, bidi_resolve_weak):
9041 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9042 bidirectional text is supported only in multibyte buffers.
9043 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9044 it to initialize the frame_window_p member of struct bidi_it.
9045 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9046 (bidi_resolve_explicit, bidi_resolve_weak)
9047 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9048 bidi_it->nchars is non-positive.
9049 (bidi_level_of_next_char): Don't try to lookup the cache for the
9050 next/previous character if nothing is cached there yet, or if we
9051 were just reseat()'ed to a new position.
9053 * xdisp.c (set_cursor_from_row): Set start and stop points
9054 according to the row's direction when priming the loop that looks
9055 for the glyph on which to display cursor.
9056 (single_display_spec_intangible_p): Function deleted.
9057 (display_prop_intangible_p): Reimplement to call
9058 handle_display_spec instead of single_display_spec_intangible_p.
9059 Accept 3 additional arguments needed by handle_display_spec.
9060 This fixes incorrect cursor motion across display property with complex
9061 values: lists, `(when COND...)' forms, etc.
9062 (single_display_spec_string_p): Support property values that are
9063 lists with the argument STRING its top-level element.
9064 (display_prop_string_p): Fix the condition for processing a
9065 property that is a list to be consistent with handle_display_spec.
9066 (handle_display_spec): New function, refactored from the
9067 last portion of handle_display_prop.
9068 (compute_display_string_pos): Accept additional argument
9069 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9070 value of a `display' property is a "replacing spec".
9071 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9072 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9073 the display property, but just return a value indicating whether
9074 the display property will replace the characters it covers.
9075 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9076 frame_window_p members of struct bidi_it.
9077 (compute_display_string_pos, compute_display_string_end):
9079 (push_it): Accept second argument POSITION, where pop_it should
9080 jump to continue iteration.
9081 (reseat_1): Initialize bidi_it.disp_pos.
9083 * keyboard.c (adjust_point_for_property): Adjust the call to
9084 display_prop_intangible_p to its new signature.
9086 * dispextern.h (struct bidi_it): New member frame_window_p.
9087 (bidi_init_it): Update prototypes.
9088 (display_prop_intangible_p): Update prototype.
9089 (compute_display_string_pos, compute_display_string_end):
9091 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9094 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9096 Malloc failure behavior now depends on size of allocation.
9097 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9098 * lisp.h: Change signatures accordingly.
9099 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9100 All callers changed. (Bug#8762)
9102 * gnutls.c: Use Emacs's memory allocators.
9103 Without this change, the gnutls library would invoke malloc etc.
9104 directly, which causes problems on non-SYNC_INPUT hosts, and which
9105 runs afoul of improving memory_full behavior. (Bug#8761)
9106 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9107 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9108 xfree instead of the default malloc, realloc, free.
9109 (Fgnutls_boot): No need to check for memory allocation failure,
9110 since xmalloc does that for us.
9112 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9113 * category.c (hash_get_category_set):
9114 * ccl.c (ccl_driver):
9115 * charset.c (Fdefine_charset_internal):
9116 * charset.h (struct charset.hash_index):
9117 * composite.c (get_composition_id, gstring_lookup_cache)
9118 (composition_gstring_put_cache):
9119 * composite.h (struct composition.hash_index):
9120 * dispextern.h (struct image.hash):
9121 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9122 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9123 (hashfn_equal, hashfn_user_defined, make_hash_table)
9124 (maybe_resize_hash_table, hash_lookup, hash_put)
9125 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9126 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9127 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9128 * image.c (make_image, search_image_cache, lookup_image)
9129 (xpm_put_color_table_h):
9130 * lisp.h (struct Lisp_Hash_Table):
9131 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9132 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9133 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9134 * alloc.c (allocate_vectorlike):
9135 Check for overflow in vector size calculations.
9136 * ccl.c (ccl_driver):
9137 Check for overflow when converting EMACS_INT to int.
9138 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9139 need to be updated by these changes.
9140 * fns.c (make_hash_table, maybe_resize_hash_table):
9141 Check for integer overflow with large hash tables.
9142 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9143 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9144 (SXHASH_REDUCE): New macro.
9145 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9146 Use it instead of discarding useful hash info with large hash values.
9147 (sxhash_float): New function.
9148 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9149 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9150 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9151 Rewrite to use FIXNUM_BITS, as this simplifies things.
9152 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9153 Adjust signatures to match updated version of code.
9154 (consing_since_gc): Now EMACS_INT, since a single hash table can
9155 use more than INT_MAX bytes.
9157 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9159 Make it possible to build with GCC-4.6+ -O2 -flto.
9161 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9163 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9165 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9166 Call minibuffer-inactive-mode.
9168 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9170 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9171 Update dependencies.
9173 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9175 * data.c (init_data): Remove code for UTS, this system is not
9178 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9180 Don't force ./temacs to start in terminal mode.
9182 * frame.c (make_initial_frame): Initialize faces in all cases, not
9183 only when CANNOT_DUMP is defined.
9184 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9186 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9188 * dispnew.c (add_window_display_history): Use const for the string
9189 pointer. Remove declaration, not needed.
9191 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9193 Use 'inline', not 'INLINE'.
9194 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9195 * alloc.c, fontset.c (INLINE): Remove.
9196 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9197 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9198 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9199 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9200 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9202 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9204 Make it possible to run ./temacs.
9206 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9207 syms_of_callproc does the same thing. Remove test for
9208 "initialized", do it in the caller.
9209 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9211 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9213 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9214 (read_minibuf): Use get_minibuffer.
9215 (syms_of_minibuf): Use DEFSYM.
9216 (Qmetadata): New var.
9217 * data.c (Qbuffer): Don't make it static.
9218 (syms_of_data): Use DEFSYM.
9220 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9222 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9223 (CCL_CODE_MIN): New macro.
9225 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9227 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9229 * eval.c (Qdebug): Now static.
9230 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9231 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9232 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9234 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9236 * image.c: Various fixes to ImageMagick code comments.
9237 (Fimagemagick_types): Doc fix.
9239 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9241 Minor fixes prompted by GCC 4.6.0 warnings.
9243 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9245 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9246 (x_clipboard_manager_save_all): Move extern decl to ...
9247 * xterm.h: ... here, so that it can be checked for consistency.
9249 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9251 * xselect.c (x_clipboard_manager_save_frame)
9252 (x_clipboard_manager_save_all): New functions.
9253 (Fx_clipboard_manager_save): Lisp function deleted.
9255 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9256 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9258 * xterm.h: Update prototype.
9260 2011-05-28 William Xu <william.xwl@gmail.com>
9262 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9265 2011-05-28 Jim Meyering <meyering@redhat.com>
9267 Avoid a sign-extension bug in crypto_hash_function.
9268 * fns.c (to_uchar): Define.
9269 (crypto_hash_function): Use it to convert some newly-signed
9270 variables to unsigned, to avoid sign-extension bugs. For example,
9271 without this change, (md5 "truc") would evaluate to
9272 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9273 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9274 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9276 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9278 Integer overflow fixes.
9280 * dbusbind.c: Serial number integer overflow fixes.
9281 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9282 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9283 to hold a serial number that is too large for a fixnum.
9284 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9285 Check for serial numbers out of range. Decode any serial number
9286 that was so large that it became a float. (Bug#8722)
9288 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9289 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9290 Use XFASTINT rather than XUINT when numbers are nonnegative.
9291 (xd_append_arg, Fdbus_method_return_internal):
9292 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9293 arguments, check that Lisp number is nonnegative, rather than
9294 silently wrapping negative numbers around. (Bug#8722)
9295 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9298 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9300 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9302 ccl: Add integer overflow checks.
9303 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9304 (IN_INT_RANGE): New macros.
9305 (ccl_driver): Use them to check for integer overflow when
9306 decoding a CCL program. Many of the new checks are whether XINT (x)
9307 fits in int; it doesn't always, on 64-bit hosts. The new version
9308 doesn't catch all possible integer overflows, but it's an
9309 improvement. (Bug#8719)
9311 * alloc.c (make_event_array): Use XINT, not XUINT.
9312 There's no need for unsigned here.
9314 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9315 This follows up to the 2011-05-06 change that substituted uintptr_t
9316 for EMACS_INT. This case wasn't caught back then.
9318 Rework Fformat to avoid integer overflow issues.
9319 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9320 now (part of C89). Include <verify.h>.
9321 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9322 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9323 (Fformat): Avoid the prepass trying to compute sizes; it was only
9324 approximate and thus did not catch overflow reliably. Instead, walk
9325 through the format just once, formatting and computing sizes as we go,
9326 checking for integer overflow at every step, and allocating a larger
9327 buffer as needed. Keep track separately whether the format is
9328 multibyte. Keep only the most-recently calculated precision, rather
9329 than them all. Record whether each argument has been converted to
9330 string. Use EMACS_INT, not int, for byte and char and arg counts.
9331 Support field widths and precisions larger than INT_MAX. Avoid
9332 sprintf's undefined behavior with conversion specifications such as %#d
9333 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9334 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9335 formatting out-of-range floating point numbers with int
9338 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9340 * data.c: Avoid integer truncation in expressions involving floats.
9341 * data.c: Include <intprops.h>.
9342 (arith_driver): When there's an integer overflow in an expression
9343 involving floating point, convert the integers to floating point
9344 so that the resulting value does not suffer from catastrophic
9345 integer truncation. For example, on a 64-bit host (* 4
9346 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9347 Do not rely on undefined behavior after integer overflow.
9349 merge count_size_as_multibyte, parse_str_to_multibyte
9350 * character.c, character.h (count_size_as_multibyte):
9351 Rename from parse_str_to_multibyte; all uses changed.
9352 Check for integer overflow.
9353 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9354 since it's now a duplicate of the other. This is more of
9355 a character than a buffer op, so better that it's in character.c.
9356 * fns.c, print.c: Adjust to above changes.
9358 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9360 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9362 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9364 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9365 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9366 (x_clipboard_manager_save): Now static.
9367 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9369 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9370 (crypto_hash_function): Now static.
9371 Fix pointer signedness problems. Avoid unnecessary initializations.
9373 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9375 * termhooks.h (Vselection_alist): Make it terminal-local.
9377 * terminal.c (create_terminal): Initialize it.
9379 * xselect.c: Support for clipboard managers.
9380 (Vselection_alist): Move to termhooks.h as terminal-local var.
9381 (LOCAL_SELECTION): New macro.
9382 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9383 (symbol_to_x_atom): Remove gratuitous arg.
9384 (x_handle_selection_request, lisp_data_to_selection_data)
9385 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9386 (x_own_selection, x_get_local_selection, x_convert_selection):
9387 New arg, specifying work frame. Use terminal-local Vselection_alist.
9388 (some_frame_on_display): Delete unused function.
9389 (Fx_own_selection_internal, Fx_get_selection_internal)
9390 (Fx_disown_selection_internal, Fx_selection_owner_p)
9391 (Fx_selection_exists_p): New optional frame arg.
9392 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9393 (x_handle_selection_clear): Don't treat other terminals with the
9394 same keyboard specially. Use the terminal-local Vselection_alist.
9395 (x_clear_frame_selections): Use Frun_hook_with_args.
9397 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9399 * xterm.h: Add support for those atoms.
9401 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9403 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9404 (converted_selections, conversion_fail_tag): New global variables.
9405 (x_selection_request_lisp_error): Free the above.
9406 (x_get_local_selection): Remove unnecessary code.
9407 (x_reply_selection_request): Args changed; handle arbitrary array
9408 of converted selections stored in converted_selections.
9409 Separate the XChangeProperty and SelectionNotify steps.
9410 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9411 (x_convert_selection): New function.
9412 (x_handle_selection_event): Simplify.
9413 (x_get_foreign_selection): Don't ignore incoming requests while
9414 waiting for an answer; this will fail when we implement
9415 SAVE_TARGETS, and seems unnecessary anyway.
9416 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9417 (Vx_sent_selection_functions): Doc fix.
9419 2011-05-26 Leo Liu <sdl.web@gmail.com>
9421 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9423 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9425 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9427 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9428 for fringe update if it has periodic bitmap.
9429 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9430 and fringe_bitmap_periodic_p.
9432 * fringe.c (get_fringe_bitmap_data): New function.
9433 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9434 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9435 row. Mark glyph row for fringe update if periodicity changed.
9437 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9438 for fringe update unless it has periodic bitmap.
9440 2011-05-25 Kenichi Handa <handa@m17n.org>
9442 * xdisp.c (get_next_display_element): Set correct it->face_id for
9443 a static composition.
9445 2011-05-24 Leo Liu <sdl.web@gmail.com>
9448 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9450 * fns.c (crypto_hash_function, Fsha1): New function.
9451 (Fmd5): Use crypto_hash_function.
9452 (syms_of_fns): Add Ssha1.
9454 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9456 * gnutls.c: Remove unused macros.
9457 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9458 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9459 Remove macros that are defined and never used.
9460 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9462 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9464 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9465 (Fx_get_selection_internal): Minor cleanup.
9466 (Fx_own_selection_internal): Rename arguments for consistency with
9469 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9471 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9473 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9475 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9477 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9479 * dispnew.c (scrolling_window): Don't exclude the case that the
9480 last enabled row in the desired matrix touches the bottom boundary.
9482 2011-05-21 Glenn Morris <rgm@gnu.org>
9484 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9485 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9486 and add some more files.
9488 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9490 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9491 report_file_error introduced by the change from 2011-05-07.
9493 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9495 * systime.h (Time): Define only if emacs is defined.
9496 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9497 where the include path doesn't have X11/X.h by default. See
9498 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9500 2011-05-20 Kenichi Handa <handa@m17n.org>
9502 * composite.c (find_automatic_composition): Fix previous change.
9504 2011-05-20 Glenn Morris <rgm@gnu.org>
9506 * lisp.mk: New file, split from Makefile.in.
9507 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9508 (shortlisp): Remove.
9509 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9511 2011-05-19 Glenn Morris <rgm@gnu.org>
9513 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9514 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9515 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9516 (lisp): Set the order to that of loadup.el.
9517 (shortlisp): Make it a copy of $lisp.
9518 (SOME_MACHINE_LISP): Remove.
9519 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9520 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9522 2011-05-18 Kenichi Handa <handa@m17n.org>
9524 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9525 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9526 (find_automatic_composition): Mostly rewrite for efficiency.
9528 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9530 * makefile.w32-in: Update dependencies.
9532 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9534 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9535 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9537 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9539 Fix some integer overflow issues, such as string length overflow.
9541 * insdel.c (count_size_as_multibyte): Check for string overflow.
9543 * character.c (lisp_string_width): Check for string overflow.
9544 Use EMACS_INT, not int, for string indexes and lengths; in
9545 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9546 the resulting string length overflows an EMACS_INT; instead,
9547 report a string overflow if no precision given. When checking for
9548 precision exhaustion, use a check that cannot possibly have
9549 integer overflow. (Bug#8675)
9550 * character.h (lisp_string_width): Adjust to new signature.
9552 * alloc.c (string_overflow): New function.
9553 (Fmake_string): Use it. This doesn't change behavior, but saves
9554 a few bytes and will simplify future changes.
9555 * character.c (string_escape_byte8): Likewise.
9556 * lisp.h (string_overflow): New decl.
9558 Fixups, following up to the user-interface timestamp change.
9559 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9560 for UI timestamps, instead of unsigned long.
9561 * msdos.c (mouse_get_pos): Likewise.
9562 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9563 * w32gui.h (Time): Define by including "systime.h" rather than by
9564 declaring it ourselves. (Bug#8664)
9566 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9567 * image.c (clear_image_cache): Likewise.
9569 * term.c (term_mouse_position): Don't assume time_t wraparound.
9571 Be more systematic about user-interface timestamps.
9572 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9573 and sometimes 'EMACS_UINT', to represent these timestamps.
9574 This change causes it to use 'Time' uniformly, as that's what X uses.
9575 This makes the code easier to follow, and makes it easier to catch
9576 integer overflow bugs such as Bug#8664.
9577 * frame.c (Fmouse_position, Fmouse_pixel_position):
9578 Use Time, not unsigned long, for user-interface timestamps.
9579 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9580 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9581 * keyboard.h (last_event_timestamp): Likewise.
9582 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9583 * menu.h (xmenu_show): Likewise.
9584 * term.c (term_mouse_position): Likewise.
9585 * termhooks.h (struct input_event.timestamp): Likewise.
9586 (struct terminal.mouse_position_hook): Likewise.
9587 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9588 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9589 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9590 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9592 * menu.h, termhooks.h: Include "systime.h", for Time.
9594 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9595 Don't assume that the difference between two unsigned long values
9596 can fit into an integer. At this point, we know button_down_time
9597 <= event->timestamp, so the difference must be nonnegative, so
9598 there's no need to cast the result if double-click-time is
9599 nonnegative, as it should be; check that it's nonnegative, just in
9600 case. This bug is triggered when events are more than 2**31 ms
9601 apart (about 25 days). (Bug#8664)
9603 * xselect.c (last_event_timestamp): Remove duplicate decl.
9604 (x_own_selection): Remove needless cast to unsigned long.
9606 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9607 that always fit in int. Use a sentinel instead of a counter, to
9608 avoid a temp and to allay GCC's concerns about possible int overflow.
9609 * frame.h (struct frame): Use int for menu_bar_items_used
9610 instead of EMACS_INT, since it always fits in int.
9612 * menu.c (grow_menu_items): Check for int overflow.
9614 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9616 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9617 Before, the code was not consistent. These values cannot exceed
9618 2**31 - 1 so there's no need to make them unsigned.
9619 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9620 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9621 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9623 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9625 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9626 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9627 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9628 presumably because the widths might not match.
9630 * window.c (size_window): Avoid needless test at loop start.
9632 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9634 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9636 2011-05-12 Drew Adams <drew.adams@oracle.com>
9638 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9640 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9642 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9643 `width' to `bar_area_x' and `bar_area_width', respectively.
9644 (x_scroll_run): Take account of fringe background extension.
9646 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9647 Rename local vars `left' and `width' to `bar_area_x' and
9648 `bar_area_width', respectively.
9649 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9650 background extension.
9652 2011-05-10 Jim Meyering <meyering@redhat.com>
9654 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9656 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9658 * image.c (Finit_image_library): Return t for built-in image types,
9659 like pbm and xbm. (Bug#8640)
9661 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9663 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9665 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9667 * w32console.c (Fset_screen_color): Doc fix.
9668 (Fget_screen_color): New function.
9669 (syms_of_ntterm): Defsubr it.
9671 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9672 unlink the temporary file if Fcall_process didn't create it in the
9674 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9675 child process will be redirected to a file specified with `:file'.
9676 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9677 cue to call_process_cleanup not to close that handle.
9679 2011-05-07 Ben Key <bkey76@gmail.com>
9681 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9682 one of two shell specific rules, either bootstrap-temacs-CMD or
9683 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9684 to the previous implementation of the bootstrap-temacs rule.
9685 The bootstrap-temacs-CMD rule is similar to the previous
9686 implementation of the bootstrap-temacs rule except that it
9687 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9690 These changes, along with some changes to nt/configure.bat,
9691 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9692 earlier fix to add support for --cflags and --ldflags options
9693 that include quotes so that it works whether make uses cmd or
9696 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9698 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9699 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9701 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9702 a string. Handle both cases.
9703 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9704 (Fdbus_register_method): Use Qinvalid_function.
9706 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9708 * makefile.w32-in: Update dependencies.
9709 (LISP_H): Add inttypes.h and stdin.h.
9710 (PROCESS_H): Add unistd.h.
9712 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9714 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9715 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9717 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9719 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9721 * term.c (vfatal): Remove stray call to va_end.
9722 It's not needed and the C Standard doesn't allow it here anyway.
9724 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9725 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9727 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9730 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9732 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9734 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9736 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9738 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9740 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9741 * charset.c (Fdefine_charset_internal): Don't initialize
9742 charset.code_space[15]. The value was garbage, on hosts with
9743 32-bit int (Bug#8600).
9745 * lread.c (read_integer): Be more consistent with string-to-number.
9746 Use string_to_number to do the actual conversion; this avoids
9747 rounding errors and fixes some other screwups. Without this fix,
9748 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9749 (digit_to_number): Move earlier, for benefit of read_integer.
9750 Return -1 if the digit is out of range for the base, -2 if it is
9751 not a digit in any supported base. (Bug#8602)
9753 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9755 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9756 to match comment at start of function. This also removes a
9757 GCC warning about overflow in a 32+64-bit port.
9759 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9761 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9762 Reported by Stefan Monnier in
9763 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9764 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9765 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9767 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9768 (EMACS_UINTPTR): Likewise, with uintptr_t.
9770 * lisp.h: Prefer 64-bit EMACS_INT if available.
9771 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9772 on 32-bit hosts that have 64-bit int, so that they can access
9774 However, temporarily disable this change unless the temporary
9775 symbol WIDE_EMACS_INT is defined.
9777 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9779 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9780 This removes an assumption that EMACS_INT and long are the same
9781 width as pointers. The assumption is true for Emacs porting targets
9782 now, but we want to make other targets possible.
9783 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9784 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9785 In the rest of the code, change types of integers that hold casted
9786 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9787 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9788 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9789 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9790 No need to cast type when ORing.
9791 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9792 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9793 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9794 assume EMACS_INT is the same width as char *.
9795 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9796 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9797 Remove no-longer-needed casts.
9798 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9799 (xg_tool_bar_help_callback, xg_make_tool_item):
9800 Use EMACS_INTPTR to hold an integer
9801 that will be cast to void *; this can avoid a GCC warning
9802 if EMACS_INT is not the same width as void *.
9803 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9804 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9805 (current_message_1, set_message_1):
9806 Use a local to convert to proper width without a cast.
9807 * xmenu.c (dialog_selection_callback): Likewise.
9809 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9810 Also, don't assume VALBITS / RAND_BITS is less than 5,
9811 and don't rely on undefined behavior when shifting a 1 left into
9813 * lisp.h (get_random): Change signature to match.
9815 * lread.c (hash_string): Use size_t, not int, for hash computation.
9816 Normally we prefer signed values; but hashing is special, because
9817 it's better to use unsigned division on hash table sizes so that
9818 the remainder is nonnegative. Also, size_t is the natural width
9819 for hashing into memory. The previous code used 'int', which doesn't
9820 retain enough info to hash well into very large tables.
9821 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9823 * dbusbind.c: Don't possibly lose pointer info when converting.
9824 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9825 Use XPNTR rather than XHASH, so that the high-order bits of
9826 the pointer aren't lost when converting through void *.
9828 * eval.c (Fautoload): Don't double-shift a pointer.
9830 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9832 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9834 * gnutls.c (DEF_GNUTLS_FN):
9835 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9837 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9839 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9842 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9844 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9845 New version that can reserve upto 2GB of heap space.
9847 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9849 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9851 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9853 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9854 `gnutls_certificate_set_x509_key_file'.
9856 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9858 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9859 Update dependencies.
9861 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9863 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9864 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9865 Remove unused parameter `fildes'.
9866 * process.c (read_process_output, send_process): Don't pass it.
9868 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9870 Fix previous change: the library cache is defined in w32.c.
9871 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9872 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9874 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9876 Implement dynamic loading of GnuTLS on Windows.
9878 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9879 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9880 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9883 * gnutls.c (Qgnutls_dll): Define.
9884 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9885 (gnutls_*): Declare function pointers.
9886 (init_gnutls_functions): New function to initialize function pointers.
9887 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9888 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9889 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9890 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9891 (emacs_gnutls_write, emacs_gnutls_read)
9892 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9893 (Fgnutls_available_p): New function.
9894 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9895 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9896 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9898 * image.c: Include w32.h.
9899 (Vimage_type_cache): Delete.
9900 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9901 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9902 (w32_delayed_load): Move to w32.c.
9904 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9906 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9907 (w32_delayed_load): Move from image.c. When loading a library, record
9908 its filename in the :loaded-from property of the library id.
9909 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9910 Initialize and staticpro them.
9911 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9913 * process.c: Include lisp.h before w32.h, not after.
9914 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9915 instead of gnutls_record_check_pending.
9917 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9919 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9921 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9922 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9925 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9927 * xterm.c (x_set_frame_alpha): Do not set property on anything
9928 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9930 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9932 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9934 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9936 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9937 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9938 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9939 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9940 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9941 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9942 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9943 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9944 (Qgnutls_bootprop_callbacks_verify): Make static.
9946 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9948 * callproc.c: Indentation fixup.
9950 * sysdep.c (wait_for_termination_1): Make static.
9951 (wait_for_termination, interruptible_wait_for_termination):
9952 Move after wait_for_termination_1.
9954 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9956 * sysdep.c (interruptible_wait_for_termination): New function
9957 which is like wait_for_termination, but allows keyboard
9960 * callproc.c (Fcall_process): Add (:file "file") as an option for
9962 (Fcall_process_region): Ditto.
9964 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9966 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9967 rather than `XVECTOR (FOO)->size'.
9969 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9970 inttypes.h, as a gnulib replacement is used if it not available in
9973 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9975 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9976 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9977 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9979 * coding.c (coding_alloc_by_realloc): Error out if destination
9980 will grow beyond MOST_POSITIVE_FIXNUM.
9981 (decode_coding_emacs_mule): Abort if there isn't enough place in
9982 charbuf for the composition carryover bytes. Reserve an extra
9983 space for up to 2 characters produced in a loop.
9984 (decode_coding_iso_2022): Abort if there isn't enough place in
9985 charbuf for the composition carryover bytes.
9987 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9989 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9990 aborting when %lld or %lll format is passed.
9991 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9992 %llo or %llx format is passed. (Bug#8545)
9994 * window.c (window_scroll_line_based): Use a marker instead of
9995 simple variables to record original value of point. (Bug#7952)
9997 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9998 produced by %s or %c overflows available buffer space. (Bug#8545)
10000 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10002 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10003 (SIZE_MAX): Move defn after all includes, as they might #define it.
10005 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10007 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10009 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10011 * keyboard.c (Qdelayed_warnings_hook): Define.
10012 (command_loop_1): Run `delayed-warnings-hook'
10013 if Vdelayed_warnings_list is non-nil.
10014 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10015 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10017 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10019 * doprnt.c (doprnt): Don't return value smaller than the buffer
10020 size if the message was truncated. (Bug#8545).
10022 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10024 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10025 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10027 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10029 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10031 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10033 * makefile.w32-in: Update dependencies.
10035 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10037 Improve `doprnt' and its usage. (Bug#8545)
10038 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10039 `format_end'. Remove support for %l as a conversion specifier.
10040 Don't use xrealloc. Improve diagnostics when the %l size modifier
10041 is used. Update the commentary.
10043 * eval.c (verror): Simplify calculation of size_t.
10045 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10048 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10050 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10053 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10055 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10056 This makes this file independent of the recent pseudovector change.
10058 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10060 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10062 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10063 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10064 Remove unused local.
10065 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10067 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10068 GCC 4.6.0 optimizes based on type-based alias analysis.
10069 For example, if b is of type struct buffer * and v of type struct
10070 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10071 != &v->size, and therefore "v->size = 1; b->size = 2; return
10072 v->size;" must therefore return 1. This assumption is incorrect
10073 for Emacs, since it type-puns struct Lisp_Vector * with many other
10074 types. To fix this problem, this patch adds a new type struct
10075 vectorlike_header that documents the constraints on layout of vectors
10076 and pseudovectors, and helps optimizing compilers not get fooled
10077 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10078 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10079 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10081 (XSETPVECTYPE): Rewrite in terms of new macro.
10082 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10083 This is a bit clearer, and further avoids the possibility of
10084 undesirable aliasing.
10085 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10086 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10087 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10088 since Lisp_Subr is a special case (no "next" field).
10089 (ASIZE): Now uses header.size rather than size.
10090 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10091 to avoid the hassle of writing XVECTOR (foo)->header.size.
10092 (struct vectorlike_header): New type.
10093 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10094 object, to help avoid aliasing.
10095 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10096 (SUBRP): Likewise, since Lisp_Subr is a special case.
10097 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10098 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10099 (struct Lisp_Hash_Table): Combine first two members into a single
10100 struct vectorlike_header member. All uses of "size" and "next" members
10101 changed to be "header.size" and "header.next".
10102 * buffer.h (struct buffer): Likewise.
10103 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10104 * frame.h (struct frame): Likewise.
10105 * process.h (struct Lisp_Process): Likewise.
10106 * termhooks.h (struct terminal): Likewise.
10107 * window.c (struct save_window_data, struct saved_window): Likewise.
10108 * window.h (struct window): Likewise.
10109 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10110 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10111 * buffer.c (init_buffer_once): Likewise.
10112 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10114 * process.c (Fformat_network_address): Use local var for size,
10117 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10119 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10120 * data.c (atof): Remove decl; no longer used or needed.
10121 (digit_to_number): Move to lread.c.
10122 (Fstring_to_number): Use new string_to_number function, to be
10123 consistent with how the Lisp reader treats infinities and NaNs.
10124 Do not assume that floating-point numbers represent EMACS_INT
10125 without losing information; this is not true on most 64-bit hosts.
10126 Avoid double-rounding errors, by insisting on integers when
10127 parsing non-base-10 numbers, as the documentation specifies.
10128 * lisp.h (string_to_number): New decl, replacing ...
10129 (isfloat_string): Remove.
10130 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10131 (read1): Do not accept +. and -. as integers; this
10132 appears to have been a coding error. Similarly, do not accept
10133 strings like +-1e0 as floating point numbers. Do not report
10134 overflow for integer overflows unless the base is not 10 which
10135 means we have no simple and reliable way to continue.
10136 Break out the floating-point parsing into a new
10137 function string_to_number, so that Fstring_to_number parses
10138 floating point numbers consistently with the Lisp reader.
10139 (digit_to_number): Move here from data.c. Make it static inline.
10140 (E_CHAR, EXP_INT): Remove, replacing with ...
10141 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10142 (string_to_number): New function, replacing isfloat_string.
10143 This function checks for valid syntax and produces the resulting
10144 Lisp float number too. Rework it so that string-to-number
10145 no longer mishandles examples like "1.0e+". Use strtoumax,
10146 so that overflow for non-base-10 numbers is reported only when
10147 there's no portable and simple way to convert to floating point.
10149 * textprop.c (set_text_properties_1): Rewrite for clarity,
10150 and to avoid GCC warning about integer overflow.
10152 * intervals.h (struct interval): Use EMACS_INT for members
10153 where EMACS_UINT might cause problems. See
10154 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10155 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10156 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10158 (offset_intervals): Tell GCC not to worry about length overflow
10159 when negating a negative length.
10161 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10162 (overrun_check_free): Likewise.
10164 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10165 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10168 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10169 (gnutls_make_error): Rename local to avoid shadowing.
10170 (gnutls_emacs_global_deinit): ifdef out; not used.
10171 (Fgnutls_boot): Use const for pointer to readonly storage.
10172 Comment out unused local. Fix pointer signedness problems.
10174 * lread.c (openp): Don't stuff size_t into an 'int'.
10175 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10176 about possible signed overflow.
10178 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10179 (GDK_KEY_g): Don't define if already defined.
10180 (xg_prepare_tooltip): Avoid pointer signedness problem.
10181 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10183 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10184 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10186 * xfns.c (Fx_window_property): Simplify a bit,
10187 to make a bit faster and to avoid GCC 4.6.0 warning.
10188 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10190 * fns.c (internal_equal): Don't assume size_t fits in int.
10192 * alloc.c (compact_small_strings): Tighten assertion a little.
10194 Replace pEd with more-general pI, and fix some printf arg casts.
10195 * lisp.h (pI): New macro, generalizing old pEd macro to other
10196 conversion specifiers. For example, use "...%"pI"d..." rather
10197 than "...%"pEd"...".
10198 (pEd): Remove. All uses replaced with similar uses of pI.
10199 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10200 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10201 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10202 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10203 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10204 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10205 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10207 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10208 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10209 * print.c (safe_debug_print, print_object): Likewise.
10210 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10212 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10213 avoiding the 0 flag, which is not portable.
10214 * process.c (Fmake_network_process): Use pI to avoid cast.
10215 * region-cache.c (pp_cache): Likewise.
10216 * xdisp.c (decode_mode_spec): Likewise.
10217 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10218 behavior on 64-bit hosts with printf arg.
10219 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10220 (x_stop_queuing_selection_requests): Likewise.
10221 (x_get_window_property): Don't truncate byte count to an 'int'
10224 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10225 here, since it parses constructs like leading '-' and spaces,
10226 which are not wanted; and it overflows with large numbers.
10227 Instead, simply match F[0-9]+, which is what is wanted anyway.
10229 * alloc.c: Remove unportable assumptions about struct layout.
10230 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10231 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10232 (allocate_vectorlike, make_pure_vector): Use the new macros,
10233 plus offsetof, to remove unportable assumptions about struct layout.
10234 These assumptions hold on all porting targets that I know of, but
10235 they are not guaranteed, they're easy to remove, and removing them
10236 makes further changes easier.
10238 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10239 This doesn't fix a bug but makes the code clearer.
10240 (string_overrun_cookie): Now const. Use initializers that
10241 don't formally overflow signed char, to avoid warnings.
10242 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10243 can cause Emacs to crash when string overrun checking is enabled.
10244 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10245 multiple of sizeof (EMACS_INT); it need not be, if
10246 alignof(EMACS_INT) < sizeof (EMACS_INT).
10247 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10249 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10251 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10253 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10255 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10256 supposed to be handshaking. (Bug#8556)
10257 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10259 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10261 * lisp.h (Qdebug): List symbol.
10262 * eval.c (Qdebug): Restore global linkage.
10263 * keyboard.c (debug-on-event): New variable.
10264 (handle_user_signal): Break into debugger when debug-on-event
10265 matches the current signal symbol.
10267 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10269 * alloc.c (check_sblock, check_string_bytes)
10270 (check_string_free_list): Convert to standard C.
10272 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10274 * w32.c (emacs_gnutls_push): Fix typo.
10276 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10278 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10279 "cast to pointer from integer of different size".
10281 Improve doprnt and its use in verror. (Bug#8545)
10282 * doprnt.c (doprnt): Document the set of format control sequences
10283 supported by the function. Use SAFE_ALLOCA instead of always
10286 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10287 is one byte too soon. Don't use xrealloc; instead xfree and
10290 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10292 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10295 * gnutls.c: Renamed global_initialized to
10296 gnutls_global_initialized. Added internals for the
10297 :verify-hostname-error, :verify-error, and :verify-flags
10298 parameters of `gnutls-boot' and documented those parameters in the
10299 docstring. Start callback support.
10300 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10301 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10302 on error. Return error code.
10303 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10304 (emacs_gnutls_read): Likewise.
10305 (Fgnutls_boot): Return handshake error code.
10306 (emacs_gnutls_handle_error): New function.
10307 (wsaerror_to_errno): Likewise.
10309 * w32.h (emacs_gnutls_pull): Add prototype.
10310 (emacs_gnutls_push): Likewise.
10312 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10313 (emacs_gnutls_push): Likewise.
10315 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10317 * process.c (wait_reading_process_output): Check if GnuTLS
10318 buffered some data internally if no FDs are set for TLS
10321 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10322 (LIBS): Link to USER_LIBS.
10323 ($(BLD)/gnutls.$(0)): New target.
10325 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10327 * xdisp.c (handle_single_display_spec): Rename the
10328 display_replaced_before_p argument into display_replaced_p, to
10329 make it consistent with the commentary. Fix typos in the
10332 * textprop.c (syms_of_textprop): Remove dead code.
10333 (copy_text_properties): Delete obsolete commentary about an
10334 interface that was deleted long ago. Fix typos in the description
10337 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10338 to changes in oldXMenu/XMenu.h from 2011-04-16.
10339 <menu_help_message, prev_menu_help_message>: Constify.
10340 (IT_menu_make_room): menu->help_text is now `const char **';
10343 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10344 to changes in oldXMenu/XMenu.h from 2011-04-16.
10345 (struct XMenu): Declare `help_text' `const char **'.
10347 * xfaces.c <Qunspecified>: Make extern again.
10349 * syntax.c: Include sys/types.h before including regex.h, as
10352 * doc.c (get_doc_string): Improve the format passed to `error'.
10354 * doprnt.c (doprnt): Improve commentary.
10356 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10358 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10361 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10362 changes in globals.h immediately force recompilation.
10363 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10364 $(CURDIR)/s/ms-w32.h.
10365 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10367 * character.c (Fchar_direction): Function deleted.
10368 (syms_of_character): Don't defsubr it.
10369 <char-direction-table>: Deleted.
10371 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10373 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10374 * doprnt.c: Include limits.h.
10375 (SIZE_MAX): New macro.
10376 (doprnt): Return a size_t value. 2nd arg is now size_t.
10377 Many local variables are now size_t instead of int or unsigned.
10378 Improve overflow protection. Support `l' modifier for integer
10379 conversions. Support %l conversion. Don't assume an EMACS_INT
10380 argument for integer conversions and for %c.
10382 * lisp.h (doprnt): Restore prototype.
10384 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10385 $(SRC)/character.h.
10387 * Makefile.in (base_obj): Add back doprnt.o.
10389 * deps.mk (doprnt.o): Add back prerequisites.
10390 (callint.o): Depend on character.h.
10392 * eval.c (internal_lisp_condition_case): Include the handler
10393 representation in the error message.
10394 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10395 when breaking from the loop.
10397 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10399 * callint.c (Fcall_interactively): When displaying error message
10400 about invalid control letter, pass the character's codepoint, not
10401 a pointer to its multibyte form. Improve display of the character
10402 in octal and display also its hex code.
10404 * character.c (char_string): Use %x to display the (unsigned)
10405 codepoint of an invalid character, to avoid displaying a bogus
10408 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10409 `error', not SYMBOL_NAME itself.
10411 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10412 character arguments to `error'.
10414 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10415 to `error' in error message about FINAL_CHAR argument. Make sure
10416 FINAL_CHAR is a character, and use %c when it is passed as
10417 argument to `error'.
10419 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10421 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10423 * w32.c: Include <time.h>.
10424 (sys_localtime): New function.
10426 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10428 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10430 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10432 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10434 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10435 zombies (Bug#8467).
10437 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10439 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10440 gl_state.e_property when gl_state.object is Qt.
10442 * insdel.c (make_gap_larger): Remove limitation of buffer size
10445 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10447 * xdisp.c (lookup_glyphless_char_display)
10448 (produce_glyphless_glyph): Handle cons cell entry in
10449 glyphless-char-display.
10450 (Vglyphless_char_display): Document it.
10452 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10453 glyphless-char-display.
10455 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10457 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10459 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10461 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10462 definition for no-X builds.
10464 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10466 Static checks with GCC 4.6.0 and non-default toolkits.
10468 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10470 * process.c (keyboard_bit_set): Define only if SIGIO.
10471 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10472 (send_process): Repair possible setjmp clobbering.
10474 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10476 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10478 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10480 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10481 Define only if needed.
10483 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10484 by pacifying GCC about it. Maybe it's time to retire it?
10485 * xfaces.c (USG, __TIMEVAL__): Likewise.
10487 * dispextern.h (struct redisplay_interface): Rename param
10488 to avoid shadowing.
10489 * termhooks.h (struct terminal): Likewise.
10490 * xterm.c (xembed_send_message): Likewise.
10492 * insdel.c (make_gap_smaller): Define only if
10493 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10495 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10498 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10499 so that we aren't warned about unused symbols.
10501 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10503 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10505 * xfns.c (x_real_positions): Mark locals as initialized.
10507 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10509 * xterm.c: Fix problems found by static analysis with other toolkits.
10510 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10511 (x_dispatch_event): Declare static if USE_GTK, and
10512 define if USE_GTK || USE_X_TOOLKIT.
10513 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10514 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10515 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10516 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10518 * xmenu.c (menu_help_callback): Pointer type fixes.
10519 Use const pointers when pointing at readonly data. Avoid pointer
10520 signedness clashes.
10521 (FALSE): Remove unused macro.
10522 (update_frame_menubar): Remove unused decl.
10524 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10526 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10527 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10528 (single_menu_item): Rename local to avoid shadowing.
10530 * keyboard.c (make_lispy_event): Remove unused local var.
10532 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10533 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10535 * bitmaps: Change bitmaps from unsigned char back to the X11
10536 compatible char. Avoid the old compiler warnings about
10537 out-of-range initializers by using, for example, '\xab' rather
10540 * xgselect.c (xgselect_initialize): Check vs interface
10541 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10543 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10545 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10546 to read-only memory.
10548 * fns.c (vector): Remove; this old hack is no longer needed.
10550 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10552 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10554 * xrdb.c (x_load_resources): Omit unused local.
10556 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10557 (x_window): Rename locals to avoid shadowing.
10558 (USG): Use the kludged USG macro, to pacify gcc.
10560 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10561 (x_term_init): Remove local to avoid shadowing.
10563 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10565 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10566 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10568 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10570 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10572 Fix regex.c, syntax.c and friends for buffers > 2GB.
10573 * syntax.h (struct gl_state_s): Declare character position members
10576 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10578 * textprop.c (verify_interval_modification, interval_of):
10579 Declare arguments EMACS_INT.
10581 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10584 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10586 * indent.c (Fvertical_motion): Local variable it_start is now
10589 * regex.c (re_match, re_match_2, re_match_2_internal)
10590 (bcmp_translate, regcomp, regexec, print_double_string)
10591 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10592 (re_compile_pattern, re_exec): Declare arguments and local
10593 variables `size_t' and `ssize_t' and return values `regoff_t', as
10595 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10596 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10597 <compile_stack_type>: `size' and `avail' are now `size_t'.
10599 * regex.h <regoff_t>: Use ssize_t, not int.
10600 (re_search, re_search_2, re_match, re_match_2): Arguments that
10601 specify buffer/string position and length are now ssize_t and
10602 size_t. Return type is regoff_t.
10604 2011-04-16 Ben Key <bkey76@gmail.com>
10606 * nsfont.m: Fixed bugs in ns_get_family and
10607 ns_descriptor_to_entity that were caused by using free to
10608 deallocate memory blocks that were allocated by xmalloc (via
10609 xstrdup). This caused Emacs to crash when compiled with
10610 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10611 --enable-checking=xmallocoverrun). xfree is now used to
10612 deallocate these memory blocks.
10614 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10616 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10618 emacs_write: Accept and return EMACS_INT for sizes.
10619 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10621 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10622 Accept and return EMACS_INT.
10623 (emacs_gnutls_write): Return the number of bytes written on
10625 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10626 (emacs_read, emacs_write): Remove check for negative size, as the
10627 Emacs source code has been audited now.
10628 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10629 (emacs_read, emacs_write): Use it.
10630 * process.c (send_process): Adjust to the new signatures of
10631 emacs_write and emacs_gnutls_write. Do not attempt to store
10632 a byte offset into an 'int'; it might overflow.
10633 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10635 * sound.c: Don't assume sizes fit in 'int'.
10636 (struct sound_device.period_size, alsa_period_size):
10637 Return EMACS_INT, not int.
10638 (struct sound_device.write, vox_write, alsa_write):
10639 Accept EMACS_INT, not int.
10640 (wav_play, au_play): Use EMACS_INT to store sizes and to
10641 record read return values.
10643 2011-04-15 Ben Key <bkey76@gmail.com>
10645 * keyboard.c (Qundefined): Don't declare static since it is used
10647 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10648 static since they are used in nsfont.m.
10650 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10652 * process.c (Qprocessp): Don't declare static.
10653 * lisp.h (Qprocessp): Declare again.
10655 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10657 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10659 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10661 Improve C-level modularity by making more things 'static'.
10663 Don't publish debugger-only interfaces to other modules.
10664 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10665 (verify_bytepos, count_markers): Move decls to the only modules
10667 * region-cache.h (pp_cache): Likewise.
10668 * window.h (check_all_windows): Likewise.
10669 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10671 * sysdep.c (croak): Now static, if
10672 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10673 * syssignal.h (croak): Declare only if not static.
10675 * alloc.c (refill_memory_reserve): Now static if
10676 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10677 * lisp.h (refill_memory_reserve): Declare only if not static.
10679 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10680 Define only if USE_LUCID.
10682 * xrdb.c (x_customization_string, x_rm_string): Now static.
10684 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10685 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10687 * xdisp.c (draw_row_with_mouse_face): Now static.
10688 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10690 * window.h (check_all_windows): Mark externally visible.
10692 * window.c (window_deletion_count): Now static.
10694 * undo.c: Make symbols static if they're not exported.
10695 (last_undo_buffer, last_boundary_position, pending_boundary):
10698 * textprop.c (interval_insert_behind_hooks): Now static.
10699 (interval_insert_in_front_hooks): Likewise.
10701 * term.c: Make symbols static if they're not exported.
10702 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10703 (max_frame_lines, tty_set_terminal_modes):
10704 (tty_reset_terminal_modes, tty_turn_off_highlight):
10705 (get_tty_terminal): Now static.
10706 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10707 * termhooks.h (term_mouse_moveto): Do not declare if
10708 HAVE_WINDOW_SYSTEM.
10709 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10710 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10712 * sysdep.c: Make symbols static if they're not exported.
10713 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10715 (sigprocmask_set, full_mask): Remove; unused.
10716 (wait_debugging): Mark as visible.
10717 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10718 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10720 * syntax.c (syntax_temp): Define only if !__GNUC__.
10722 * sound.c (current_sound_device, current_sound): Now static.
10724 * search.c (searchbufs, searchbuf_head): Now static.
10726 * scroll.c (scroll_cost): Remove; unused.
10727 * dispextern.h (scroll_cost): Remove decl.
10729 * region-cache.h (pp_cache): Mark as externally visible.
10731 * process.c: Make symbols static if they're not exported.
10732 (process_tick, update_tick, create_process, chan_process):
10733 (Vprocess_alist, proc_buffered_char, datagram_access):
10734 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10735 (deactivate_process): Mark defn as static, as well as decl.
10736 * lisp.h (create_process): Remove decl.
10737 * process.h (chan_process, Vprocess_alist): Remove decls.
10739 * print.c: Make symbols static if they're not exported.
10740 (print_depth, new_backquote_output, being_printed, print_buffer):
10741 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10742 (print_interval, print_number_index, initial_stderr_stream):
10744 * lisp.h (Fprinc): Remove decl.
10745 (debug_output_compilation_hack): Mark as externally visible.
10747 * sysdep.c (croak): Move decl from here to syssignal.h.
10748 * syssignal.h (croak): Put it here, so the API can be checked when
10749 'croak' is called from dissociate_if_controlling_tty.
10751 * minibuf.c: Make symbols static if they're not exported.
10752 (minibuf_save_list, choose_minibuf_frame): Now static.
10753 * lisp.h (choose_minibuf_frame): Remove decl.
10755 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10757 * lread.c: Make symbols static if they're not exported.
10758 (read_objects, initial_obarray, oblookup_last_bucket_number):
10760 (make_symbol): Remove; unused.
10761 * lisp.h (initial_obarray, make_symbol): Remove decls.
10763 * keyboard.c: Make symbols static if they're not exported.
10764 (single_kboard, recent_keys_index, total_keys, recent_keys):
10765 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10766 (this_single_command_key_start, echoing, last_auto_save):
10767 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10768 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10769 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10770 (Vlispy_mouse_stem, double_click_count):
10772 (force_auto_save_soon): Define only if SIGDANGER.
10773 (ignore_mouse_drag_p): Now static if
10774 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10775 (print_help): Remove; unused.
10776 (stop_character, last_timer_event): Mark as externally visible.
10777 * keyboard.h (ignore_mouse_drag_p): Declare only if
10778 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10779 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10780 * lisp.h (echoing): Remove decl.
10781 (force_auto_save_soon): Declare only if SIGDANGER.
10782 * xdisp.c (redisplay_window): Simplify code, to make it more
10783 obvious that ignore_mouse_drag_p is not accessed if !defined
10784 USE_GTK && !defined HAVE_NS.
10786 * intervals.c: Make symbols static if they're not exported.
10787 (merge_properties_sticky, merge_interval_right, delete_interval):
10789 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10791 * insdel.c: Make symbols static if they're not exported.
10792 However, leave prepare_to_modify_buffer alone. It's never
10793 called from outside this function, but that appears to be a bug.
10794 (combine_after_change_list, combine_after_change_buffer):
10795 (adjust_after_replace, signal_before_change): Now static.
10796 (adjust_after_replace_noundo): Remove; unused.
10797 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10798 (signal_before_change): Remove decls.
10800 * indent.c (val_compute_motion, val_vmotion): Now static.
10802 * image.c: Make symbols static if they're not exported.
10803 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10805 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10806 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10808 * fringe.c (standard_bitmaps): Now static.
10809 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10811 * frame.c: Make symbols static if they're not exported.
10812 (x_report_frame_params, make_terminal_frame): Now static.
10813 (get_frame_param): Now static, unless HAVE_NS.
10814 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10815 (x_get_resource_string): Remove; not used.
10816 * frame.h (make_terminal_frame, x_report_frame_params):
10817 (x_get_resource_string); Remove decls.
10818 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10819 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10821 * font.c, fontset.c: Make symbols static if they're not exported.
10822 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10823 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10824 * font.c (font_close_object): Now static.
10825 * font.h (font_close_object): Remove.
10826 * fontset.c (FONTSET_OBJLIST): Remove.
10827 (free_realized_fontset) #if-0 the body, which does nothing.
10828 (face_suitable_for_char_p): #if-0, as it's never called.
10829 * fontset.h (face_suitable_for_char_p): Remove decl.
10830 * xfaces.c (face_at_string_position):
10831 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10832 since 0 is always ASCII.
10834 * fns.c (weak_hash_tables): Now static.
10836 * fileio.c: Make symbols static if they're not exported.
10837 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10838 (Vwrite_region_annotation_buffers): Now static.
10840 * eval.c: Make symbols static if they're not exported.
10841 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10842 * lisp.h (backtrace_list): Remove decl.
10844 * emacs.c: Make symbols static if they're not exported.
10845 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10846 (fatal_error_code, fatal_error_signal_hook, standard_args):
10848 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10849 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10850 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10851 * lisp.h (fatal_error_signal_hook): Remove decl.
10852 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10854 * editfns.c: Move a (normally-unused) function to its only use.
10855 * editfns.c, lisp.h (get_operating_system_release): Remove.
10856 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10857 worth the hassle of breaking this out.
10859 * xterm.c: Make symbols static if they're not exported.
10860 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10861 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10862 (x_destroy_window, x_delete_display):
10864 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10865 (x_mouse_leave): Remove; unused.
10866 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10867 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10868 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10870 (x_mouse_leave): Declare only if WINDOWSNT.
10871 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10872 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10875 * ftxfont.c: Make symbols static if they're not exported.
10876 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10878 * font.h (ftxfont_driver): Likewise.
10880 * xfns.c: Make symbols static if they're not exported.
10881 (x_last_font_name, x_display_info_for_name):
10882 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10883 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10884 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10885 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10886 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10887 (last_show_tip_args): Now static.
10888 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10889 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10890 (x_screen_planes): Remove; unused.
10891 * dispextern.h (x_screen_planes): Remove decl.
10893 * dispnew.c: Make symbols static if they're not exported.
10894 * dispextern.h (redraw_garbaged_frames, scrolling):
10895 (increment_row_positions): Remove.
10896 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10897 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10899 (redraw_garbaged_frames): Remove; unused.
10901 * xfaces.c: Make symbols static if they're not exported.
10902 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10904 * xterm.h (defined_color): Remove decls.
10905 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10906 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10907 (menu_face_changed_default, defined_color, free_realized_face):
10908 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10909 (ascii_face_of_lisp_face): Remove; unused.
10911 * xdisp.c: Make symbols static if they're not exported.
10912 * dispextern.h (scratch_glyph_row, window_box_edges):
10913 (glyph_to_pixel_coords, set_cursor_from_row):
10914 (get_next_display_element, set_iterator_to_next):
10915 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10916 (show_mouse_face): Remove decls
10917 * frame.h (message_buf_print): Likewise.
10918 * lisp.h (pop_message, set_message, check_point_in_composition):
10920 * xterm.h (set_vertical_scroll_bar): Likewise.
10921 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10922 (message_buf_print, scratch_glyph_row, displayed_buffer):
10923 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10924 (get_next_display_element, show_mouse_face, window_box_edges):
10925 (frame_to_window_pixel_xy, check_point_in_composition):
10926 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10927 (glyph_to_pixel_coords): Remove; unused.
10929 * dired.c (file_name_completion): Now static.
10931 * dbusbind.c (xd_in_read_queued_messages): Now static.
10933 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10934 * data.c (circular_list_error): Remove.
10936 * commands.h (last_point_position, last_point_position_buffer):
10937 (last_point_position_window): Remove decls.
10938 * keyboard.c: Make these variables static.
10940 * coding.h (coding, code_convert_region, encode_coding_gap):
10942 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10943 (iso_code_class, detect_coding, code_convert_region): Now static.
10944 (encode_coding_gap): Remove; unused.
10946 * chartab.c (chartab_chars, chartab_bits): Now static.
10948 * charset.h (charset_iso_8859_1): Remove decl.
10949 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10952 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10953 * ccl.c (Vccl_program_table): Now static.
10954 (check_ccl_update): Remove; unused.
10956 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10957 * category.h: ... from here.
10958 * category.c (check_category_table, set_category_set): Now static.
10960 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10961 * lisp.h: Remove these decls.
10963 * buffer.c (buffer_count): Remove unused var.
10965 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10966 so that it's not optimized away.
10967 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10968 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10969 exported only to the debugger.
10971 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10972 * atimer.h (run_all_atimers): Remove; not exported.
10974 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10975 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10976 was inaccessible from Lisp.
10977 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10978 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10980 alloc.c: Import and export fewer symbols, and remove unused items.
10981 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10983 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10984 it's not optimized away by whole-program optimization.
10985 (message_enable_multibyte, free_misc): Remove.
10986 (catchlist, handlerlist, mark_backtrace):
10987 Declare only if BYTE_MARK_STACK.
10988 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10989 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10990 (message_enable_multibyte): Remove decl.
10991 (free_misc, interval_free_list, float_block, float_block_index):
10992 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10993 (cons_free_list, last_marked_index):
10995 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10996 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10997 (mark_backtrace): Define only if BYTE_MARK_STACK.
10998 * xdisp.c (message_enable_multibyte): Now static.
11000 Declare Lisp_Object Q* variables to be 'static' if not exported.
11001 This makes it easier for human readers (and static analyzers)
11002 to see whether these variables are used from other modules.
11003 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11004 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11005 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11006 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11007 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11008 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11009 * xmenu.c, xselect.c:
11010 Declare Q* vars static if they are not used in other modules.
11011 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11012 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11013 Remove decls of unexported vars.
11014 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11016 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11018 Make Emacs functions such as Fatom 'static' by default.
11019 This makes it easier for human readers (and static analyzers)
11020 to see whether these functions can be called from other modules.
11021 DEFUN now defines a static function. To make the function external
11022 so that it can be used in other C modules, use the new macro DEFUE.
11023 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11024 (Finit_image_library):
11025 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11026 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11027 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11028 Remove decls, since these functions are now static.
11029 (Funintern, Fget_internal_run_time): New decls, since these functions
11030 were already external.
11032 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11033 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11034 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11035 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11036 * keyboard.c, keymap.c, lread.c:
11037 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11038 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11039 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11040 Mark functions with DEFUE instead of DEFUN,
11041 if they are used in other modules.
11042 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11043 decls for now-static functions.
11044 * buffer.h (Fdelete_overlay): Remove decl.
11045 * callproc.c (Fgetenv_internal): Mark as internal.
11046 * composite.c (Fremove_list_of_text_properties): Remove decl.
11047 (Fcomposition_get_gstring): New forward static decl.
11048 * composite.h (Fcomposite_get_gstring): Remove decl.
11049 * dired.c (Ffile_attributes): New forward static decl.
11050 * doc.c (Fdocumntation_property): New forward static decl.
11051 * eval.c (Ffetch_bytecode): New forward static decl.
11052 (Funintern): Remove extern decl; now in .h file where it belongs.
11053 * fileio.c (Fmake_symbolic_link): New forward static decl.
11054 * image.c (Finit_image_library): New forward static decl.
11055 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11056 * intervals.h (Fprevious_property_change):
11057 (Fremove_list_of_text_properties): Remove decls.
11058 * keyboard.c (Fthis_command_keys): Remove decl.
11059 (Fcommand_execute): New forward static decl.
11060 * keymap.c (Flookup_key): New forward static decl.
11061 (Fcopy_keymap): Now static.
11062 * keymap.h (Flookup_key): Remove decl.
11063 * process.c (Fget_process): New forward static decl.
11064 (Fprocess_datagram_address): Mark as internal.
11065 * syntax.c (Fsyntax_table_p): New forward static decl.
11066 (skip_chars): Remove duplicate decl.
11067 * textprop.c (Fprevious_property_change): New forward static decl.
11068 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11070 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11071 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11073 * editfns.c (Fformat): Remove unreachable code.
11075 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11077 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11080 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11082 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11083 when at ZV. (Bug#8487)
11085 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11087 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11089 * keyboard.c (parse_tool_bar_item): Likewise.
11090 * sound.c (sound_cleanup, alsa_close): Likewise.
11091 * termcap.c (tgetent): Likewise.
11092 * xfns.c (x_default_font_parameter): Likewise.
11093 * xsettings.c (read_and_apply_settings): Likewise.
11095 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11096 (overrun_check_free): Protoize.
11098 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11100 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11101 since callers should never pass a negative size.
11102 Change the signature to match that of plain 'read' and 'write'; see
11103 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11104 * lisp.h: Update prototypes of emacs_write and emacs_read.
11106 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11108 * xdisp.c (redisplay_window): Don't try to determine the character
11109 position of the scroll margin if the window start point w->startp
11110 is outside the buffer's accessible region. (Bug#8468)
11112 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11114 Fix write-region and its subroutines for buffers > 2GB.
11115 * fileio.c (a_write, e_write): Modify declaration of arguments and
11116 local variables to support buffers larger than 2GB.
11117 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11119 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11120 argument, local variables, and return value.
11122 * lisp.h: Update prototypes of emacs_write and emacs_read.
11124 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11126 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11128 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11130 Fix more problems found by GCC 4.6.0's static checks.
11132 * xdisp.c (vmessage): Use a better test for character truncation.
11134 * charset.c (load_charset_map): <, not <=, for optimization,
11135 and to avoid potential problems with integer overflow.
11136 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11137 * casetab.c (set_identity, shuffle): Likewise.
11138 * editfns.c (Fformat): Likewise.
11139 * syntax.c (skip_chars): Likewise.
11141 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11142 This also lets GCC 4.6.0 generate slightly better loop code.
11144 * callint.c (Fcall_interactively): <, not <=, for optimization.
11145 (Fcall_interactively): Count the number of arguments produced,
11146 not the number of arguments given. This is simpler and lets GCC
11147 4.6.0 generate slightly better code.
11149 * ftfont.c: Distingish more carefully between FcChar8 and char.
11150 The previous code passed unsigned char * to a functions like
11151 strlen and xstrcasecmp that expect char *, which does not
11152 conform to the C standard.
11153 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11154 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11155 char * when the C standard requires it.
11157 * keyboard.c (read_char): Remove unused var.
11159 * eval.c: Port to Windows vsnprintf (Bug#8435).
11160 Include <limits.h>.
11161 (SIZE_MAX): Define if the headers do not.
11162 (verror): Do not give up if vsnprintf returns a negative count.
11163 Instead, grow the buffer. This ports to Windows vsnprintf, which
11164 does not conform to C99. Problem reported by Eli Zaretskii.
11165 Also, simplify the allocation scheme, by avoiding the need for
11166 calling realloc, and removing the ALLOCATED variable.
11168 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11170 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11171 But keep the doprint source code for now, as we might revamp it
11172 and use it again (Bug#8435).
11173 * lisp.h (doprnt): Remove.
11174 * Makefile.in (base_obj): Remove doprnt.o.
11175 * deps.mk (doprnt.o): Remove.
11177 error: Print 32- and 64-bit integers portably (Bug#8435).
11178 Without this change, on typical 64-bit hosts error ("...%d...", N)
11179 was used to print both 32- and 64-bit integers N, which relied on
11180 undefined behavior.
11181 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11182 * lisp.h (error, verror): Mark as printf-like functions.
11183 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11184 Report overflow in size calculations when allocating printf buffer.
11185 Do not truncate output string at its first null byte.
11186 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11187 Truncate the output at a character boundary, since vsnprintf does not
11189 * charset.c (check_iso_charset_parameter): Convert internal
11190 character to string before calling 'error', since %c now has the
11192 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11193 overflow when computing char to be passed to 'error'. Do not
11194 pass Lisp_Object to 'error'; pass the integer instead.
11195 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11196 formatted with plain %d.
11198 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11200 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11202 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11204 * xterm.c (x_catch_errors): Remove duplicate declaration.
11206 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11208 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11210 2011-04-10 Jim Meyering <meyering@redhat.com>
11212 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11213 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11214 return ssize_t not "int", and use size_t as the buffer length.
11215 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11216 * gnutls.h: Update declarations.
11217 * process.c (read_process_output): Use ssize_t, to match.
11218 (send_process): Likewise.
11220 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11222 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11224 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11226 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11227 Use unsigned char, to match FcChar8 type definition.
11229 * xterm.c (handle_one_xevent):
11230 * xmenu.c (create_and_show_popup_menu):
11231 * xselect.c (x_decline_selection_request)
11232 (x_reply_selection_request): Avoid type-punned deref of X events.
11234 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11236 Fix some uses of `int' instead of EMACS_INT.
11237 * search.c (string_match_1, fast_string_match)
11238 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11239 (scan_buffer, find_next_newline_no_quit)
11240 (find_before_next_newline, search_command, Freplace_match)
11241 (Fmatch_data): Make some `int' variables be EMACS_INT.
11243 * xdisp.c (display_count_lines): 3rd argument and return value now
11244 EMACS_INT. All callers changed.
11245 (pint2hrstr): Last argument is now EMACS_INT.
11247 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11248 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11249 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11250 (decode_coding_utf_16, decode_coding_emacs_mule)
11251 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11252 (decode_coding_ccl, decode_coding_charset)
11253 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11254 (decode_coding_iso_2022, decode_coding_emacs_mule)
11255 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11256 <char_offset, last_offset>: Declare EMACS_INT.
11257 (encode_coding_utf_8, encode_coding_utf_16)
11258 (encode_coding_emacs_mule, encode_invocation_designation)
11259 (encode_designation_at_bol, encode_coding_iso_2022)
11260 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11261 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11263 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11264 (encode_invocation_designation): Last argument P_NCHARS is now
11266 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11267 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11269 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11272 * ccl.c (Fccl_execute_on_string): Declare some variables
11275 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11277 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11279 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11281 * process.c (Fformat_network_address): Doc fix.
11283 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11285 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11287 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11289 * keyboard.c (read_char): Call Lisp function help-form-show,
11290 instead of using internal_with_output_to_temp_buffer.
11291 (Qhelp_form_show): New var.
11292 (syms_of_keyboard): Use DEFSYM macro.
11294 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11296 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11298 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11300 * process.c (Flist_processes): Remove to Lisp.
11301 (list_processes_1): Delete.
11303 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11305 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11307 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11309 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11311 Fix more problems found by GCC 4.6.0's static checks.
11313 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11315 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11317 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11319 * xdisp.c (vmessage): Mark as a printf-like function.
11321 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11323 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11325 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11326 printf-like functions.
11327 (tiff_load): Add casts to remove these marks before passing them
11328 to system-supplied API.
11330 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11332 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11333 This avoids several warnings with gcc -Wstrict-overflow.
11334 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11335 directly, rather than having caller test rule sign. This avoids
11336 some unnecessary tests.
11337 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11338 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11339 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11341 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11342 (xfont_open): Avoid unnecessary tests.
11344 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11346 * composite.h, composite.c (composition_gstring_put_cache):
11347 Use EMACS_INT, not int, for length.
11349 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11350 breaking out part of COMPOSITION_DECODE_RULE.
11351 (COMPOSITION_DECODE_RULE): Use it.
11352 * composite.c (get_composition_id): Remove unused local vars,
11353 by using the new macro.
11355 * textprop.c (set_text_properties_1): Change while to do-while,
11356 since the condition is always true at first.
11358 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11359 (interval_deletion_adjustment): Return unsigned value.
11362 * process.c (list_processes_1, create_pty, read_process_output):
11363 (exec_sentinel): Remove vars that were set but not used.
11364 (create_pty): Remove unnecessary "volatile"s.
11365 (Fnetwork_interface_info): Avoid possibility of int overflow.
11366 (read_process_output): Do adaptive read buffering even if carryover.
11367 (read_process_output): Simplify nbytes computation if buffered.
11369 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11371 * syntax.c (scan_words): Remove var that was set but not used.
11372 (update_syntax_table): Use unsigned instead of int.
11374 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11375 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11376 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11378 * print.c (print_error_message): Avoid int overflow.
11380 * font.c (font_list_entities): Redo for clarity,
11381 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11383 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11384 (font_score): Avoid potential overflow in diff calculation.
11386 * fns.c (substring_both): Remove var that is set but not used.
11387 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11389 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11391 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11392 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11393 can always succeed if overflow has undefined behavior.
11395 * search.c (boyer_moore, wordify): Remove vars set but not used.
11396 (wordify): Omit three unnecessary tests.
11398 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11399 All callers changed. This avoids the need for an unused var.
11401 * casefiddle.c (casify_region): Remove var that is set but not used.
11403 * dired.c (file_name_completion): Remove var that is set but not used.
11405 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11407 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11408 (Finsert_file_contents): Remove unnecessary code checking fd.
11410 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11411 Check for integer overflow on size calculations.
11413 * buffer.c (Fprevious_overlay_change): Remove var that is set
11416 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11417 Remove vars that are set but not used.
11418 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11419 (timer_check_2): Mark vars as initialized.
11421 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11423 * image.c (lookup_image): Remove var that is set but not used.
11424 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11426 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11427 that are set but not used.
11429 * xfns.c (make_invisible_cursor): Don't return garbage
11430 if XCreateBitmapFromData fails (Bug#8410).
11432 * xselect.c (x_get_local_selection, x_handle_property_notify):
11433 Remove vars that are set but not used.
11435 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11436 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11438 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11439 Remove var that is set but not used.
11440 (scroll_bar_windows_size): Now size_t, not int.
11441 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11442 Check for overflow.
11444 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11445 (map_tty_color) [!defined MSDOS]: Likewise.
11447 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11449 * coding.c: Remove vars that are set but not used.
11450 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11451 All callers changed.
11452 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11453 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11454 (decode_coding_charset): Remove vars that are set but not used.
11456 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11457 that is set but not used.
11459 * print.c (print_object): Remove var that is set but not used.
11461 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11462 The gnulib version avoids calling malloc in the usual case,
11463 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11464 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11465 * filelock.c (current_lock_owner): Likewise.
11466 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11467 * sysdep.c: Include allocator.h, careadlinkat.h.
11468 (emacs_no_realloc_allocator): New static constant.
11469 (emacs_readlink): New function.
11470 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11471 ../lib/careadlinkat.h.
11473 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11475 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11476 first non-nil return value).
11478 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11480 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11481 if not defined (Bug#8403).
11483 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11485 * xdisp.c (display_count_lines): Remove parameter `start',
11486 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11487 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11488 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11489 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11490 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11491 and thereabouts. All callers changed.
11492 (get_per_char_metric): Remove parameter `f', unused since
11493 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11495 2011-04-02 Jim Meyering <meyering@redhat.com>
11497 do not dereference NULL upon failed strdup
11498 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11499 (ns_get_family): Likewise.
11501 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11503 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11505 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11507 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11510 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11512 Add lexical binding.
11514 * window.c (Ftemp_output_buffer_show): New fun.
11515 (Fsave_window_excursion):
11516 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11518 * lread.c (lisp_file_lexically_bound_p): New function.
11519 (Fload): Bind Qlexical_binding.
11520 (readevalloop): Remove `evalfun' arg.
11521 Bind Qinternal_interpreter_environment.
11522 (Feval_buffer): Bind Qlexical_binding.
11523 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11525 (syms_of_lread): Declare `lexical-binding'.
11527 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11529 * keyboard.c (eval_dyn): New fun.
11530 (menu_item_eval_property): Use it.
11532 * image.c (parse_image_spec): Use Ffunctionp.
11534 * fns.c (concat, mapcar1): Accept byte-code-functions.
11536 * eval.c (Fsetq): Handle lexical vars.
11537 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11538 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11539 (FletX, Flet): Obey lexical binding.
11540 (Fcommandp): Handle closures.
11541 (Feval): New `lexical' arg.
11542 (eval_sub): New function extracted from Feval. Use it almost
11543 everywhere where Feval was used. Look up vars in lexical env.
11545 (Ffunctionp): Move from subr.el.
11546 (Ffuncall): Handle closures.
11547 (apply_lambda): Remove `eval_flags'.
11548 (funcall_lambda): Handle closures and new byte-code-functions.
11549 (Fspecial_variable_p): New function.
11550 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11551 but without exporting it to Lisp.
11553 * doc.c (Fdocumentation, store_function_docstring):
11554 * data.c (Finteractive_form): Handle closures.
11556 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11559 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11561 (exec_byte_code): New function extracted from Fbyte_code to handle new
11562 calling convention for byte-code-functions. Add new byte-codes.
11564 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11566 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11568 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11570 * xdisp.c (redisplay_internal): Fix prototype.
11572 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11574 * xdisp.c (SCROLL_LIMIT): New macro.
11575 (try_scrolling): Use it when setting scroll_limit.
11576 Limit scrolling to 100 screen lines.
11577 (redisplay_window): Even when falling back on "recentering",
11578 position point in the window according to scroll-conservatively,
11579 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11581 (try_scrolling): When point is above the window, allow searching
11582 as far as scroll_max, or one screenful, to compute vertical
11583 distance from PT to the scroll margin position. This prevents
11584 try_scrolling from unnecessarily failing when
11585 scroll-conservatively is set to a value slightly larger than the
11586 window height. Clean up the case of PT below the margin at bottom
11587 of window: scroll_max can no longer be INT_MAX. When aggressive
11588 scrolling is in use, don't let point enter the opposite scroll
11589 margin as result of the scroll.
11590 (syms_of_xdisp) <scroll-conservatively>: Document the
11591 threshold of 100 lines for never-recentering scrolling.
11593 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11595 * dispextern.h (move_it_by_lines):
11596 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11597 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11598 (message_log_check_duplicate): Remove parameters `prev_bol' and
11599 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11600 (redisplay_internal): Remove parameter `preserve_echo_area',
11601 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11603 * indent.c (Fvertical_motion):
11604 * window.c (window_scroll_pixel_based, Frecenter):
11605 Don't pass `need_y_p' to `move_it_by_lines'.
11607 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11609 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11610 steal a few bits to be more compact.
11611 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11612 Remove unneeded casts.
11614 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11616 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11618 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11619 binding" message (bug#7967).
11621 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11623 Fix more problems found by GCC 4.6.0's static checks.
11625 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11626 Remove unused local var.
11628 * editfns.c (Fmessage_box): Remove unused local var.
11630 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11631 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11632 Omit unused local vars.
11633 * window.c (shrink_windows): Omit unused local var.
11634 * menu.c (digest_single_submenu): Omit unused local var.
11635 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11636 Omit unused local var.
11638 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11639 Don't assume string length fits in int.
11640 (keyremap_step, read_key_sequence): Use size_t for sizes.
11641 (read_key_sequence): Don't check last_real_key_start redundantly.
11643 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11644 instead of alloca (Bug#8344).
11646 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11647 (Fbacktrace_frame): Don't assume nframes fits in int.
11649 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11651 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11654 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11656 * cm.c (calccost): Turn while-do into do-while, for clarity.
11658 * keyboard.c (syms_of_keyboard): Use the same style as later
11659 in this function when indexing through an array. This also
11660 works around GCC bug 48267.
11662 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11664 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11666 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11667 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11669 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11670 This avoids undefined behavior on integer overflow, and is a bit
11671 more convenient anyway since it is compared to a size_t variable.
11673 Variadic C functions now count arguments with size_t, not int.
11674 This avoids an unnecessary limitation on 64-bit machines, which
11675 caused (substring ...) to crash on large vectors (Bug#8344).
11676 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11677 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11678 All variadic functions and their callers changed accordingly.
11679 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11680 * data.c (arith_driver, float_arith_driver): Likewise.
11681 * editfns.c (general_insert_function): Likewise.
11682 * eval.c (struct backtrace.nargs, interactive_p)
11683 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11684 (funcall_lambda, mark_backtrace): Likewise.
11685 * fns.c (concat): Likewise.
11686 * frame.c (x_set_frame_parameters): Likewise.
11687 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11688 0 if not found, not -1. All callers changed.
11690 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11691 (stack_copy_size): Now size_t, not int.
11692 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11694 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11696 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11697 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11698 All callers changed.
11700 * lisp.h (multibyte_char_to_unibyte):
11701 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11702 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11703 * character.h (CHAR_TO_BYTE8):
11704 * cmds.c (internal_self_insert):
11705 * editfns.c (general_insert_function):
11706 * keymap.c (push_key_description):
11707 * search.c (Freplace_match):
11708 * xdisp.c (message_dolog, set_message_1): All callers changed.
11710 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11712 * keyboard.c (safe_run_hook_funcall): New function.
11713 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11714 don't set the hook to nil, but remove the offending function instead.
11715 (Qcommand_hook_internal): Remove, unused.
11716 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11717 Vcommand_hook_internal.
11719 * eval.c (enum run_hooks_condition): Remove.
11720 (funcall_nil, funcall_not): New functions.
11721 (run_hook_with_args): Call each function through a `funcall' argument.
11722 Remove `cond' argument, now redundant.
11723 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11724 (Frun_hook_with_args_until_failure): Adjust accordingly.
11725 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11727 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11729 * dispextern.h (string_buffer_position): Remove declaration.
11731 * print.c (strout): Remove parameter `multibyte', unused since
11732 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11734 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11735 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11736 All callers changed.
11738 * w32.c (_wsa_errlist): Use braces for struct initializers.
11740 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11741 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11742 All callers changed.
11743 (string_buffer_position): Likewise. Also, make static (it's never
11744 used outside xdisp.c).
11745 (cursor_row_p): Remove parameter `w', unused since
11746 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11747 (decode_mode_spec): Remove parameter `precision', introduced during
11748 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11749 All callers changed.
11751 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11753 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11755 2011-03-27 Anders Lindgren <andlind@gmail.com>
11757 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11758 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11759 (ns_update_auto_hide_menu_bar): New functions.
11760 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11761 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11762 ns_constrain_all_frames.
11763 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11764 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11766 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11768 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11770 2011-03-27 Glenn Morris <rgm@gnu.org>
11772 * syssignal.h: Replace RETSIGTYPE with void.
11773 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11774 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11775 Replace SIGTYPE with void everywhere.
11776 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11777 * s/template.h (SIGTYPE): Remove commented out definition.
11779 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11781 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11782 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11784 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11786 * w32.c (read_unc_volume): Use parameter `henum', instead of
11787 global variable `wget_enum_handle'.
11789 * keymap.c (describe_vector): Remove parameters `indices' and
11790 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11791 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11793 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11795 * keyboard.c (timer_check): Remove parameter `do_it_now',
11796 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11797 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11798 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11800 * keyboard.c (read_char):
11801 * w32menu.c (w32_menu_display_help):
11802 * xmenu.c (show_help_event, menu_help_callback):
11803 Adjust calls to `show_help_echo'.
11805 * gtkutil.c (xg_maybe_add_timer):
11806 * keyboard.c (readable_events):
11807 * process.c (wait_reading_process_output):
11808 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11810 * insdel.c (adjust_markers_gap_motion):
11811 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11812 (gap_left, gap_right): Don't call it.
11814 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11816 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11817 incurred during fontification.
11819 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11821 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11822 (DEFVAR_PER_BUFFER): Don't pass it.
11824 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11825 (scrolling_window): Don't pass it.
11827 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11829 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11831 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11833 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11834 of variables specific to SELinux and computation of `encoded_absname'.
11836 * image.c (XPutPixel): Remove unused variable `height'.
11838 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11840 * unexw32.c (get_section_info): Remove unused variable `section'.
11842 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11843 (system_process_attributes): Remove unused variable `sess'.
11844 (sys_read): Remove unused variable `err'.
11846 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11847 (w32_wnd_proc): Remove unused variable `isdead'.
11848 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11849 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11850 (x_create_tip_frame): Remove unused variable `tem'.
11852 * w32inevt.c (w32_console_read_socket):
11853 Remove unused variable `no_events'.
11855 * w32term.c (x_draw_composite_glyph_string_foreground):
11856 Remove unused variable `width'.
11858 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11860 * w32term.c (x_set_glyph_string_clipping):
11861 Don't pass uninitialized region to CombineRgn.
11863 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11865 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11866 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11867 (Fx_close_connection): Remove unused variable `i'.
11869 * w32font.c (w32font_draw): Return number of glyphs.
11870 (w32font_open_internal): Remove unused variable `i'.
11871 (w32font_driver): Add missing initializer.
11873 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11874 (fill_in_menu): Remove unused variable `items_added'.
11876 * w32term.c (last_mouse_press_frame): Remove static global variable.
11877 (w32_clip_to_row): Remove unused variable `f'.
11878 (x_delete_terminal): Remove unused variable `i'.
11880 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11881 (NOTHING): Remove unused static global variable.
11882 (uniscribe_check_otf): Remove unused variable `table'.
11883 (uniscribe_font_driver): Add missing initializers.
11885 2011-03-23 Julien Danjou <julien@danjou.info>
11887 * term.c (Fsuspend_tty, Fresume_tty):
11888 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11889 * window.c (temp_output_buffer_show):
11890 * insdel.c (signal_before_change):
11891 * frame.c (Fhandle_switch_frame):
11892 * fileio.c (Fdo_auto_save):
11893 * emacs.c (Fkill_emacs):
11894 * editfns.c (save_excursion_restore):
11895 * cmds.c (internal_self_insert):
11896 * callint.c (Fcall_interactively):
11897 * buffer.c (Fkill_all_local_variables):
11898 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11900 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11901 unconditionally since it does the check itself.
11903 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11905 Fix more problems found by GCC 4.5.2's static checks.
11907 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11908 the first time through the loop, since we know p0 < p1 then.
11909 This also avoids a gcc -Wstrict-overflow warning.
11911 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11912 leading to a memory leak, possible in functions like
11913 load_charset_map_from_file that can allocate an unbounded number
11914 of objects (Bug#8318).
11916 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11917 that could (at least in theory) be that large.
11919 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11920 This is less likely to overflow, and avoids undefined behavior if
11921 overflow does occur. All callers changed. Use strtoul to scan
11922 for the unsigned long integer.
11923 (pint2hrstr): Simplify and tune code slightly.
11924 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11926 * scroll.c (do_scrolling): Work around GCC bug 48228.
11927 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11929 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11930 This also avoids a warning with gcc -Wstrict-overflow.
11931 (validate_x_resource_name): Simplify count usage.
11932 This also avoids a warning with gcc -Wstrict-overflow.
11934 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11937 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11939 * process.c (Fmake_network_process): Use socklen_t, not int,
11940 where POSIX says socklen_t is required in portable programs.
11941 This fixes a porting bug on hosts like 64-bit HP-UX, where
11942 socklen_t is wider than int (Bug#8277).
11943 (Fmake_network_process, server_accept_connection):
11944 (wait_reading_process_output, read_process_output):
11947 * process.c: Rename or move locals to avoid shadowing.
11948 (list_processes_1, Fmake_network_process):
11949 (read_process_output_error_handler, exec_sentinel_error_handler):
11950 Rename or move locals.
11951 (Fmake_network_process): Define label "retry_connect" only if needed.
11952 (Fnetwork_interface_info): Fix pointer signedness.
11953 (process_send_signal): Add cast to avoid pointer signedness problem.
11954 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11955 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11957 Make tparam.h and terminfo.c consistent.
11958 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11959 Include tparam.h instead, since it declares them.
11960 * cm.h (PC): Remove extern decl; tparam.h now does this.
11961 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11962 * terminfo.c: Include tparam.h, to check interfaces.
11963 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11964 (tparam): Adjust signature to match interface in tparam.h;
11965 this removes some undefined behavior. Check that outstring and len
11966 are zero, which they always are with Emacs.
11967 * tparam.h (PC, BC, UP): New extern decls.
11969 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11970 (xftfont_open): Rename locals to avoid shadowing.
11972 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11973 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11974 (OTF_TAG_SYM): Omit macro if not needed.
11975 (ftfont_list): Remove unused local.
11976 (get_adstyle_property, ftfont_pattern_entity):
11977 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11978 Rename locals to avoid shadowing.
11980 * xfont.c (xfont_list_family): Mark var as initialized.
11982 * xml.c (make_dom): Now static.
11984 * composite.c (composition_compute_stop_pos): Rename local to
11986 (composition_reseat_it): Remove unused locals.
11987 (find_automatic_composition, composition_adjust_point): Likewise.
11988 (composition_update_it): Mark var as initialized.
11989 (find_automatic_composition): Mark vars as initialized,
11990 with a FIXME (Bug#8290).
11992 character.h: Rename locals to avoid shadowing.
11993 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11994 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11995 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11996 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11997 to avoid shadowing.
11999 * textprop.c (property_change_between_p): Remove; unused.
12001 * intervals.c (interval_start_pos): Now static.
12003 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12005 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12006 Rename locals to avoid shadowing.
12008 * sound.c (wav_play, au_play, Fplay_sound_internal):
12009 Fix pointer signedness.
12010 (alsa_choose_format): Remove unused local var.
12011 (wav_play): Initialize a variable to 0, to prevent undefined
12012 behavior (Bug#8278).
12014 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12016 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12018 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12019 clobbering (Bug#8298).
12020 * sysdep.c (sys_subshell): Likewise.
12021 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12023 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12024 This should get cleaned up, so that child_setup has the
12025 same signature on all platforms.
12027 * callproc.c (call_process_cleanup): Now static.
12028 (relocate_fd): Rename locals to avoid shadowing.
12030 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12032 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12033 not to be necessary, and produces flickering.
12035 2011-03-20 Glenn Morris <rgm@gnu.org>
12037 * config.in: Remove file.
12039 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12041 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12042 are now in src/globals.h.
12043 (syms_of_minibuf): Remove spurious & from previous change.
12045 2011-03-20 Leo Liu <sdl.web@gmail.com>
12047 * minibuf.c (completing-read-function): New variable.
12048 (completing-read-default): Rename from completing-read.
12049 (completing-read): Call completing-read-function.
12051 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12053 * xfaces.c (Fx_load_color_file):
12054 Read color file from absolute filename (bug#8250).
12056 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12058 * makefile.w32-in: Update dependencies.
12060 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12062 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12064 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12066 Fix more problems found by GCC 4.5.2's static checks.
12068 * process.c (make_serial_process_unwind, send_process_trap):
12069 (sigchld_handler): Now static.
12071 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12072 That way, the code declares only the vars that it needs.
12073 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12074 * s/cygwin.h (PTY_ITERATION): Likewise.
12075 * s/darwin.h (PTY_ITERATION): Likewise.
12076 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12078 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12079 * process.c (allocate_pty): Don't declare stb unless it's needed.
12081 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12082 (CONSTANTLIM): Remove; unused.
12083 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12084 Define only if needed.
12086 * unexelf.c (unexec): Name an expression,
12087 to avoid gcc -Wbad-function-cast warning.
12088 Use a different way to cause a compilation error if anyone uses
12089 n rather than nn, a way that does not involve shadowing.
12090 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12092 * deps.mk (unexalpha.o): Remove; unused.
12094 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12095 * unexec.h: New file.
12096 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12097 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12098 Depend on unexec.h.
12099 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12100 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12101 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12102 Change as necessary to match prototype in unexec.h.
12104 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12106 (back_comment, skip_chars): Mark vars as initialized.
12108 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12109 Rename locals to avoid shadowing.
12111 * lread.c (read1): Rewrite so as not to use empty "else".
12112 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12114 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12116 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12117 warning when compiling print.c.
12119 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12120 instead of using an uninitialized var.
12121 (font_sort_entities): Mark var as initialized.
12123 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12125 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12126 pointers to constants.
12127 (font_parse_fcname): Remove unused vars.
12128 (font_delete_unmatched): Now static.
12129 (font_get_spec): Remove; unused.
12130 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12131 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12132 Rename or move locals to avoid shadowing.
12134 * fns.c (require_nesting_list, require_unwind): Now static.
12135 (Ffillarray): Rename locals to avoid shadowing.
12137 * floatfns.c (domain_error2): Define only if needed.
12138 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12140 * alloc.c (mark_backtrace): Move decl from here ...
12141 * lisp.h: ... to here, so that it can be checked.
12143 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12144 (Fdefvar): Rewrite so as not to use empty "else".
12145 (lisp_indirect_variable): Name an expression,
12146 to avoid gcc -Wbad-function-cast warning.
12147 (Fdefvar): Rename locals to avoid shadowing.
12149 * callint.c (quotify_arg, quotify_args): Now static.
12150 (Fcall_interactively): Rename locals to avoid shadowing.
12151 Use const pointer when appropriate.
12153 * lisp.h (get_system_name, get_operating_system_release):
12154 Move decls here, to check interfaces.
12155 * process.c (get_operating_system_release): Move decl to lisp.h.
12156 * xrdb.c (get_system_name): Likewise.
12157 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12158 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12159 some of which prompt warnings from gcc -Wbad-function-cast.
12160 (Fformat_time_string, Fencode_time, Finsert_char):
12161 (Ftranslate_region_internal, Fformat):
12162 Rename or remove local vars to avoid shadowing.
12163 (Ftranslate_region_internal): Mark var as initialized.
12165 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12168 * lisp.h (eassert): Check that the argument compiles, even if
12169 ENABLE_CHECKING is not defined.
12171 * data.c (Findirect_variable): Name an expression, to avoid
12172 gcc -Wbad-function-cast warning.
12173 (default_value, arithcompare, arith_driver, arith_error): Now static.
12174 (store_symval_forwarding): Rename local to avoid shadowing.
12175 (Fmake_variable_buffer_local, Fmake_local_variable):
12176 Mark variables as initialized.
12177 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12179 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12180 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12181 Rename locals to avoid shadowing.
12182 (mark_stack): Move local variables into the #ifdef region where
12184 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12185 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12187 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12188 (GC_STRING_CHARS): Remove; not used.
12189 (Fmemory_limit): Cast sbrk's returned value to char *.
12191 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12192 avoids undefined behavior in theory.
12194 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12196 Use functions, not macros, for up- and down-casing (Bug#8254).
12197 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12198 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12199 to use the following functions instead of these macros.
12200 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12201 EMACS_INT, since callers assume the returned value fits in int.
12202 (upcase1): Likewise, for UPCASE_TABLE.
12203 (uppercasep, lowercasep, upcase): New static inline functions.
12204 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12205 the race-condition problem in the old DOWNCASE.
12207 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12208 Rename locals to avoid shadowing.
12209 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12210 (regex_compile, re_search_2, re_match_2_internal):
12211 Remove unused local vars.
12212 (FREE_VAR): Rewrite so as not to use empty "else",
12213 which gcc can warn about.
12214 (regex_compile, re_match_2_internal): Mark locals as initialized.
12215 (RETALLOC_IF): Define only if needed.
12216 (WORDCHAR_P): Likewise. This one is never needed, but is used
12217 only in a comment talking about a compiler bug, so put inside
12218 the #if 0 of that comment.
12219 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12220 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12223 * search.c (boyer_moore): Rename locals to avoid shadowing.
12224 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12225 (PREV_CHAR_BOUNDARY): Likewise.
12227 * search.c (simple_search): Remove unused var.
12229 * dired.c (compile_pattern): Move decl from here ...
12230 * lisp.h: ... to here, so that it can be checked.
12231 (struct re_registers): New forward decl.
12233 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12235 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12237 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12238 Rename locals to avoid shadowing.
12239 (Fvertical_motion): Mark locals as initialized.
12241 * casefiddle.c (casify_object, casify_region): Now static.
12242 (casify_region): Mark local as initialized.
12244 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12246 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12247 New macros, so that the caller can use some names other than
12248 gcpro1, gcpro2, etc.
12249 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12251 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12252 argument, for consistency with GCPRO2_VAR, etc: it is now the
12253 prefix of the variable, not the variable itself. All uses
12255 * dired.c (directory_files_internal, file_name_completion):
12256 Rename locals to avoid shadowing.
12258 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12259 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12260 dired.c's scmp function, had undefined behavior.
12261 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12262 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12263 * buffer.h: ... to here, because these macros use current_buffer,
12264 and the new implementation with inline functions needs to have
12265 current_buffer in scope now, rather than later when the macros
12267 (downcase, upcase1): New static inline functions.
12268 (DOWNCASE, UPCASE1): Reimplement using these functions.
12269 This avoids undefined behavior in expressions like
12270 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12271 from race conditions in accessing the global variables
12272 case_temp1 and case_temp2.
12273 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12274 * lisp.h (case_temp1, case_temp2): Remove their decls.
12275 * character.h (ASCII_CHAR_P): Move from here ...
12276 * lisp.h: ... to here, so that the inline functions mentioned
12277 above can use them.
12279 * dired.c (directory_files_internal_unwind): Now static.
12281 * fileio.c (file_name_as_directory, directory_file_name):
12282 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12284 (file_name_as_directory): Use const pointers when appropriate.
12285 (Fexpand_file_name): Likewise. In particular, newdir might
12286 point at constant storage, so make it a const pointer.
12287 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12288 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12290 (Fset_file_times, Finsert_file_contents, auto_save_error):
12291 Rename locals to avoid shadowing.
12293 * minibuf.c (choose_minibuf_frame_1): Now static.
12294 (Ftry_completion, Fall_completions): Rename or remove locals
12295 to avoid shadowing.
12297 * marker.c (bytepos_to_charpos): Remove; unused.
12299 * lisp.h (verify_bytepos, count_markers): New decls,
12300 so that gcc does not warn that these functions aren't declared.
12302 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12303 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12304 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12305 (copy_text): Remove unused local var.
12307 * filelock.c (within_one_second): Now static.
12308 (lock_file_1): Rename local to avoid shadowing.
12310 * buffer.c (fix_overlays_before): Mark locals as initialized.
12311 (fix_start_end_in_overlays): Likewise. This function should be
12312 simplified by using pointers-to-pointers, but that's a different
12314 (switch_to_buffer_1): Now static.
12315 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12316 (report_overlay_modification): Rename locals to avoid shadowing.
12318 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12319 Fix pointer signedness issue.
12320 (sys_subshell): Mark local as volatile if checking for lint,
12321 to suppress a gcc -Wclobbered warning that does not seem to be right.
12322 (MAXPATHLEN): Define only if needed.
12324 * process.c (serial_open, serial_configure): Move decls from here ...
12325 * systty.h: ... to here, so that they can be checked.
12327 * fns.c (get_random, seed_random): Move extern decls from here ...
12328 * lisp.h: ... to here, so that they can be checked.
12330 * sysdep.c (reset_io): Now static.
12331 (wait_for_termination_signal): Remove; unused.
12333 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12334 (copy_keymap_item, append_key, push_text_char_description):
12336 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12337 (DENSE_TABLE_SIZE): Remove; unused.
12338 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12339 (describe_map_tree):
12340 Rename locals to avoid shadowing.
12342 * keyboard.c: Declare functions static if they are not used elsewhere.
12343 (echo_char, echo_dash, cmd_error, top_level_2):
12344 (poll_for_input, handle_async_input): Now static.
12345 (read_char, kbd_buffer_get_event, make_lispy_position):
12346 (make_lispy_event, make_lispy_movement, apply_modifiers):
12347 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12348 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12349 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12350 (read_key_sequence, read_char): Mark locals as initialized.
12351 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12353 * keyboard.h (make_ctrl_char): New decl.
12354 (mark_kboards): Move decl here ...
12355 * alloc.c (mark_kboards): ... from here.
12357 * lisp.h (force_auto_save_soon): New decl.
12359 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12360 (DEFINE_DUMMY_FUNCTION): New macro.
12361 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12363 (main): Add casts to avoid warnings
12364 if GCC considers string literals to be constants.
12366 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12368 * dbusbind.c: Pointer signedness fixes.
12369 (xd_signature, xd_append_arg, xd_initialize):
12370 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12371 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12372 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12373 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12375 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12376 if GCC considers string literals to be constants.
12377 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12379 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12381 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12382 (print_preprocess, print_object): New macro to fix last change.
12384 * print.c (print_preprocess): Don't forget font objects.
12386 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12388 * emacs.c (USAGE3): Doc fixes.
12390 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12392 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12395 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12397 * lisp.h (VWindow_system, Qfile_name_history):
12398 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12399 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12400 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12402 * w32select.c: Don't #include "keyboard.h".
12403 (run_protected): Add extern declaration for waiting_for_input.
12405 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12406 * w32console.c (detect_input_pending, read_input_pending)
12407 (encode_terminal_code):
12408 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12409 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12410 (w32_system_caret_y, Qfile_name_history):
12411 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12412 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12413 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12414 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12415 * w32proc.c (Qlocal, report_file_error):
12416 * w32term.c (Vwindow_system, updating_frame):
12417 * w32uniscribe.c (initialized, uniscribe_font_driver):
12418 Remove unneeded extern declarations.
12420 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12422 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12424 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12426 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12427 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12428 These macros can no longer be used for assignment.
12430 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12431 Assign struct members directly, instead of using BUF_BEGV etc.
12432 (record_buffer_markers, fetch_buffer_markers): New functions for
12433 recording and fetching special buffer markers.
12434 (set_buffer_internal_1, set_buffer_temp): Use them.
12436 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12438 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12440 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12441 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12443 * xdisp.c (hscroll_window_tree):
12444 (reconsider_clip_changes): Use PT instead of BUF_PT.
12446 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12448 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12449 $(EMACS_ROOT)/lib/intprops.h.
12451 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12453 Fix more problems found by GCC 4.5.2's static checks.
12455 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12456 to unsigned char * to avoid compiler diagnostic.
12457 (xg_free_frame_widgets): Make it clear that a local variable is
12458 needed only if USE_GTK_TOOLTIP.
12459 (gdk_window_get_screen): Make it clear that this macro is needed
12460 only if USE_GTK_TOOLTIP.
12461 (int_gtk_range_get_value): New function, which avoids a diagnostic
12462 from gcc -Wbad-function-cast.
12463 (xg_set_toolkit_scroll_bar_thumb): Use it.
12464 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12465 diagnostic from gcc -Wbad-function-cast.
12466 (get_utf8_string, xg_get_file_with_chooser):
12467 Rename locals to avoid shadowing.
12468 (create_dialog): Move locals to avoid shadowing.
12470 * xgselect.c (xg_select): Remove unused var.
12472 * image.c (four_corners_best): Mark locals as initialized.
12473 (gif_load): Initialize transparent_p to zero (Bug#8238).
12474 Mark another local as initialized.
12475 (my_png_error, my_error_exit): Mark with NO_RETURN.
12477 * image.c (clear_image_cache): Now static.
12478 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12479 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12480 (x_edge_detection): Remove unnecessary cast that
12481 gcc -Wbad-function-cast diagnoses.
12482 (gif_load): Fix pointer signedness.
12483 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12484 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12486 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12488 Improve quality of tests for time stamp overflow.
12489 For example, without this patch (encode-time 0 0 0 1 1
12490 1152921504606846976) returns the obviously-bogus value (-948597
12491 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12492 reports time overflow. See
12493 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12494 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12495 * editfns.c: Include limits.h and intprops.h.
12496 (TIME_T_MIN, TIME_T_MAX): New macros.
12497 (time_overflow): Move earlier, to before first use.
12498 (hi_time, lo_time): New functions, for an accurate test for
12499 out-of-range times.
12500 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12501 (Fget_internal_run_time): Don't assume time_t fits in int.
12502 (make_time): Use list2 instead of Fcons twice.
12503 (Fdecode_time): More accurate test for out-of-range times.
12504 (check_tm_member): New function.
12505 (Fencode_time): Use it, to test for out-of-range times.
12506 (lisp_time_argument): Don't rely on undefined left-shift and
12507 right-shift behavior when checking for time stamp overflow.
12509 * editfns.c (time_overflow): New function, refactoring common code.
12510 (Fformat_time_string, Fdecode_time, Fencode_time):
12511 (Fcurrent_time_string): Use it.
12513 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12514 * dired.c (make_time): Move to ...
12515 * editfns.c (make_time): ... here.
12516 * systime.h: Note the move.
12518 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12520 * fringe.c (update_window_fringes): Remove unused variables.
12522 * unexmacosx.c (copy_data_segment): Also copy __got section.
12525 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12527 * termcap.c [MSDOS]: Include "msdos.h".
12528 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12529 Constify `char *' arguments and their references according to
12530 prototypes in tparam.h.
12532 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12534 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12535 Adapt all references accordingly.
12537 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12539 2011-03-11 Tom Tromey <tromey@redhat.com>
12541 * buffer.c (syms_of_buffer): Remove obsolete comment.
12543 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12545 * termhooks.h (encode_terminal_code): Declare prototype.
12547 * msdos.c (encode_terminal_code): Don't declare prototype.
12549 * term.c (encode_terminal_code): Now external again, used by
12550 w32console.c and msdos.c.
12552 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12553 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12555 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12557 Fix some minor problems found by GCC 4.5.2's static checks.
12559 * fringe.c (update_window_fringes): Mark locals as initialized
12561 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12563 * alloc.c (mark_fringe_data): Move decl from here ...
12564 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12565 to check its interface.
12566 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12568 * fontset.c (free_realized_fontset): Now static.
12569 (Fset_fontset_font): Rename local to avoid shadowing.
12570 (fontset_font): Mark local as initialized.
12571 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12573 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12575 * xselect.c (x_disown_buffer_selections): Remove; not used.
12576 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12577 (x_own_selection, Fx_disown_selection_internal): Rename locals
12578 to avoid shadowing.
12579 (x_handle_dnd_message): Remove local to avoid shadowing.
12581 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12582 so that the caller can use some name other than gcpro1.
12583 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12584 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12585 (Fx_backspace_delete_keys_p):
12586 Use them to avoid shadowing, and rename vars to avoid shadowing.
12587 (x_decode_color, x_set_name, x_window): Now static.
12588 (Fx_create_frame): Add braces to silence GCC warning.
12589 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12590 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12591 Remove unused locals.
12592 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12593 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12594 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12597 * xterm.h (x_mouse_leave): New decl.
12599 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12600 Remove unused functions.
12601 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12602 (x_calc_absolute_position): Now static.
12603 (XTread_socket): Don't define label "out" unless it's used.
12604 Don't declare local "event" unless it's used.
12605 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12606 unless they are used.
12607 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12608 (x_fatal_error_signal): Remove; not used.
12609 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12610 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12611 (x_error_catcher, x_connection_closed, x_error_handler):
12612 (x_error_quitter, xembed_send_message, x_iconify_frame):
12613 (my_log_handler): Rename locals to avoid shadowing.
12614 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12615 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12617 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12618 Rename or move locals to avoid shadowing.
12619 (tty_defined_color, merge_face_heights): Now static.
12620 (free_realized_faces_for_fontset): Remove; not used.
12621 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12622 does not deduce is never used uninitialized.
12623 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12624 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12626 * terminal.c (store_terminal_param): Now static.
12628 * xmenu.c (menu_highlight_callback): Now static.
12629 (set_frame_menubar): Remove unused local.
12630 (xmenu_show): Rename parameter to avoid shadowing.
12631 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12632 since they might point to immutable storage.
12633 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12634 since it's unused otherwise.
12636 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12637 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12638 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12639 avoids a gcc -Wuninitialized diagnostic.
12640 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12641 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12642 does not deduce are never used uninitialized.
12644 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12646 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12647 * window.c (window_loop, size_window):
12648 (run_window_configuration_change_hook, enlarge_window): Likewise.
12650 * window.c (display_buffer): Now static.
12651 (size_window): Mark variables that gcc -Wuninitialized
12652 does not deduce are never used uninitialized.
12653 * window.h (check_all_windows): New decl, to forestall
12654 gcc -Wmissing-prototypes diagnostic.
12655 * dispextern.h (bidi_dump_cached_states): Likewise.
12657 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12659 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12660 Include <limits.h>.
12661 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12662 and to avoid gcc -Wuninitialized warning.
12663 (load_charset_map): Mark variables that gcc -Wuninitialized
12664 does not deduce are never used uninitialized.
12665 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12667 * coding.c (coding_set_source, coding_set_destination):
12668 Use "else { /* comment */ }" rather than "else /* comment */;"
12669 for clarity, and to avoid gcc -Wempty-body warning.
12670 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12671 a block, when the outer 'i' will do.
12672 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12673 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12674 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12675 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12676 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12677 Rename locals to avoid shadowing.
12678 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12679 * coding.c (emacs_mule_char, encode_invocation_designation):
12680 Now static, since they're not used elsewhere.
12681 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12682 (decode_coding_object, encode_coding_object, detect_coding_system):
12683 (decode_coding_emacs_mule): Mark variables that gcc
12684 -Wuninitialized does not deduce are never used uninitialized.
12685 (detect_coding_iso_2022): Initialize a local variable that might
12686 be used uninitialized. Leave a FIXME because it's not clear that
12687 this initialization is needed. (Bug#8211)
12688 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12689 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12690 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12691 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12692 Remove unused macros.
12694 * category.c (hash_get_category_set): Remove unused local var.
12695 (copy_category_table): Now static, since it's not used elsewhere.
12696 * character.c (string_count_byte8): Likewise.
12698 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12699 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12701 * chartab.c (copy_sub_char_table): Now static, since it's not used
12703 (sub_char_table_ref_and_range, char_table_ref_and_range):
12704 Rename locals to avoid shadowing.
12705 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12707 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12708 (BIDI_BOB): Remove unused macro.
12710 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12711 deduce are never used uninitialized.
12712 * term.c (encode_terminal_code): Likewise.
12714 * term.c (encode_terminal_code): Now static. Remove unused local.
12716 * tparam.h: New file.
12717 * term.c, tparam.h: Include it.
12718 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12719 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12720 Move these decls to tparam.h, and make them agree with what
12721 is actually in tparam.c. The previous trick of using incompatible
12722 decls in different modules does not conform to the C standard.
12723 All callers of tparam changed to use tparam's actual API.
12724 * tparam.c (tparam1, tparam, tgoto):
12725 Use const pointers where appropriate.
12727 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12728 * cm.h (struct cm): Likewise.
12729 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12730 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12731 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12732 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12733 (turn_on_face, init_tty): Likewise.
12734 * termchar.h (struct tty_display_info): Likewise.
12736 * term.c (term_mouse_position): Rename local to avoid shadowing.
12738 * alloc.c (mark_ttys): Move decl from here ...
12739 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12741 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12743 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12745 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12747 * search.c (compile_pattern_1): Remove argument regp, unused since
12748 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12749 (compile_pattern): Don't pass it.
12751 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12753 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12754 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12756 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12758 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12760 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12761 gdk_window_get_screen, gdk_window_get_geometry,
12762 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12763 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12764 (xg_get_pixbuf_from_pixmap): New function.
12765 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12766 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12767 Call xg_get_pixbuf_from_pixmap instead of
12768 gdk_pixbuf_get_from_drawable.
12769 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12770 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12771 (xg_check_special_colors): Use GtkStyleContext and its functions
12773 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12774 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12775 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12776 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12777 Call gtk_widget_get_preferred_size.
12778 (xg_frame_resized): gdk_window_get_geometry only takes 5
12780 (xg_win_to_widget, xg_event_is_for_menubar):
12781 Call gdk_x11_window_lookup_for_display.
12782 (xg_set_widget_bg): New function.
12783 (delete_cb): New function.
12784 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12785 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12786 (xg_set_background_color): Call xg_set_widget_bg.
12787 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12788 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12789 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12790 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12792 (update_frame_tool_bar): Call gtk_widget_hide.
12793 (xg_initialize): Use GDK_KEY_g.
12795 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12797 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12799 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12800 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12801 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12803 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12805 * w32xfns.c (select_palette): Check success of RealizePalette against
12806 GDI_ERROR, not zero.
12808 See ChangeLog.11 for earlier changes.
12810 ;; Local Variables:
12814 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12816 This file is part of GNU Emacs.
12818 GNU Emacs is free software: you can redistribute it and/or modify
12819 it under the terms of the GNU General Public License as published by
12820 the Free Software Foundation, either version 3 of the License, or
12821 (at your option) any later version.
12823 GNU Emacs is distributed in the hope that it will be useful,
12824 but WITHOUT ANY WARRANTY; without even the implied warranty of
12825 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12826 GNU General Public License for more details.
12828 You should have received a copy of the GNU General Public License
12829 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.