1 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3 * bidi.c <bidi_cache_total_alloc>: Now static.
4 (bidi_initialize): Initialize bidi_cache_total_alloc.
6 *xdisp.c (display_line): Release buffer allocated for shelved bidi
9 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
10 amount allocated this far in `bidi_cache_total_alloc'.
11 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
12 non-zero, only free the data buffer without restoring the cache
13 contents. All callers changed.
15 * dispextern.h (bidi_unshelve_cache): Update prototype.
17 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
18 (move_it_in_display_line, move_it_to)
19 (move_it_vertically_backward, move_it_by_lines): Replace the call
20 to xfree to an equivalent call to bidi_unshelve_cache.
21 (move_it_in_display_line_to): Fix logic of returning
22 MOVE_POS_MATCH_OR_ZV in the bidi case.
24 2011-08-05 Eli Zaretskii <eliz@gnu.org>
26 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
27 came from a string character with a `cursor' property. (Bug#9229)
29 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
31 * Makefile.in (LIB_PTHREAD): New variable.
32 (LIBES): Add LIB_PTHREAD (Bug#9216).
34 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
35 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
37 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
39 * regex.c (re_iswctype): Remove some redundant boolean
42 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
44 * xterm.c (x_find_topmost_parent): New function.
45 (x_set_frame_alpha): Find topmost parent window with
46 x_find_topmost_parent and set the property there also (bug#9181).
47 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
49 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
51 * callproc.c (Fcall_process): Avoid vfork clobbering
52 the local vars buffer, coding_systems, current_dir.
54 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
56 * keymap.c (Fmake_composed_keymap): Move to subr.el.
58 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
60 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
61 so that it is not optimized away.
63 * xdisp.c (compute_display_string_pos): Remove unused local.
65 2011-08-02 Eli Zaretskii <eliz@gnu.org>
67 Fix slow cursor motion and scrolling in large buffers with
68 selective display, like Org Mode buffers. (Bug#9218)
70 * dispextern.h (struct bidi_it): New member disp_prop_p.
72 * xdisp.c: Remove one-slot cache of display string positions.
73 (compute_display_string_pos): Accept an additional argument
74 DISP_PROP_P; callers changed. Scan at most 5K characters forward
75 for a display string or property. If found, set DISP_PROP_P
78 * bidi.c (bidi_fetch_char): Accept an additional argument
79 DISP_PROP_P, and pass it to compute_display_string_pos.
80 Only handle text covered by a display string if DISP_PROP_P is returned
81 non-zero. All callers of bidi_fetch_char changed.
83 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
85 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
87 2010-12-03 Don March <don@ohspite.net>
89 * keymap.c (Fdefine_key): Fix non-prefix key error message when
90 last character M-[char] is translated to ESC [char] (bug#7541).
92 2011-08-02 Kenichi Handa <handa@m17n.org>
94 * lisp.h (uniprop_table): Extern it.
96 * chartab.c (uniprop_table): Make it non-static.
98 2011-08-01 Eli Zaretskii <eliz@gnu.org>
100 * xdisp.c (forward_to_next_line_start): Accept additional argument
101 BIDI_IT_PREV, and store into it the state of the bidi iterator had
103 (reseat_at_next_visible_line_start): Use the bidi iterator state
104 returned by forward_to_next_line_start to restore the state of
105 it->bidi_it after backing up to previous newline. (Bug#9212)
107 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
109 * regex.c (re_comp): Protoize.
110 (re_exec): Fix return type.
111 (regexec): Fix type of `ret'. (Bug#9203)
113 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
115 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
116 This is needed if max-image-size is a floating-point number.
118 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
120 * print.c (print_object): Print empty symbol as ##.
122 * lread.c (read1): Read ## as empty symbol.
124 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
126 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
127 setting frame foreground color (Bug#9175).
128 (x_set_background_color): Likewise.
130 * nsmenu.m (-setText): Size tooltip dimensions precisely to
132 (EmacsTooltip -init): Remove bezels and add shadows to
135 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
136 or scroll bar (Bug#8470).
138 * nsfont.m (nsfont_open): Remove assignment to voffset and
139 unnecessary vars hshink, expand, hd, full_height, min_height.
140 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
142 * nsterm.h (nsfont_info): Remove voffset field.
144 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
146 Implement strike-through and overline on NextStep (Bug#8863).
148 * nsfont.m (nsfont_open): Use underline position provided by font,
149 instead of hard-coded value of 2.
150 (nsfont_draw): Call ns_draw_text_decoration instead.
152 * nsterm.h: Add declaration for ns_draw_text_decoration.
154 * nsterm.m (ns_draw_text_decoration): New function for drawing
155 underline, overline, and strike-through.
156 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
157 ns_draw_text_decoration. Change treatment of cursor drawing to
158 accomodate underlining, etc.
160 2011-07-28 Eli Zaretskii <eliz@gnu.org>
162 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
165 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
167 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
168 Without this fix, if a signal arrives just after memory fills up,
169 'malloc' might be invoked reentrantly.
171 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
172 In other words, assume that every image size is allowed, on non-X
173 hosts. This assumption is probably wrong, but it lets Emacs compile.
175 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
177 * regex.c (re_iswctype): Convert return values to boolean.
179 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
181 * xdisp.c (compute_display_string_pos): Don't use cached display
182 string position if the buffer had its restriction changed.
185 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
187 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
189 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
191 Integer signedness and overflow and related fixes. (Bug#9079)
193 * bidi.c: Integer size and overflow fixes.
194 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
195 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
196 (bidi_cache_find_level_change, bidi_cache_ensure_space)
197 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
198 (bidi_find_other_level_edge):
199 Use ptrdiff_t instead of EMACS_INT where either will do.
200 This works better on 32-bit hosts configured --with-wide-int.
201 (bidi_cache_ensure_space): Check for size-calculation overflow.
202 Use % rather than repeated addition, for better worst-case speed.
203 Don't set bidi_cache_size until after xrealloc returns, because it
205 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
206 (bidi_cache_ensure_space): Also check that the bidi cache size
207 does not exceed that of the largest Lisp string or buffer. See Eli
208 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
210 * alloc.c (__malloc_size_t): Remove.
211 All uses replaced by size_t. See Andreas Schwab's note
212 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
214 * image.c: Improve checking for integer overflow.
215 (check_image_size): Assume that f is nonnull, since
216 it is always nonnull in practice. This is one less thing to
217 worry about when checking for integer overflow later.
218 (x_check_image_size): New function, which checks for integer
219 overflow issues inside X.
220 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
221 This removes the need for a memory_full check.
222 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
223 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
224 (xbm_read_bitmap_data): Change locals back to 'int', since
225 their values must fit in 'int'.
226 (xpm_load_image, png_load, tiff_load):
227 Invoke x_create_x_image_and_pixmap earlier,
228 to avoid much needless work if the image is too large.
229 (tiff_load): Treat overly large images as if
230 x_create_x_image_and_pixmap failed, not as malloc failures.
231 (gs_load): Use x_check_image_size.
233 * gtkutil.c: Omit integer casts.
234 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
235 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
237 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
239 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
240 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
241 would wrongly return t on a 64-bit host.
243 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
244 The plain *_OVERFLOW macros run afoul of GCC bug 49705
245 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
246 and therefore cause GCC to emit a bogus diagnostic in some cases.
248 * image.c: Integer signedness and overflow and related fixes.
249 This is not an exhaustive set of fixes, but it's time to
250 record what I've got.
251 (lookup_pixel_color, check_image_size): Remove redundant decls.
252 (check_image_size): Don't assume that arbitrary EMACS_INT values
253 fit in 'int', or that arbitrary 'double' values fit in 'int'.
254 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
255 (tiff_load, imagemagick_load_image):
256 Check for overflow in size calculations.
257 (x_create_x_image_and_pixmap): Remove unnecessary test for
258 xmalloc returning NULL; that can't happen.
259 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
260 (xpm_color_bucket): Use better integer hashing function.
261 (xpm_cache_color): Don't possibly over-allocate memory.
262 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
264 Use ptrdiff_t, not int or size_t, to record sizes.
265 (png_load): Don't assume values greater than 2**31 fit in 'int'.
266 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
267 either works, as we prefer signed integers.
268 (tiff_read_from_memory, tiff_write_from_memory):
269 Return tsize_t, not size_t, since that's what the TIFF API wants.
270 (tiff_read_from_memory): Don't fail simply because the read would
271 go past EOF; instead, return a short read.
272 (tiff_load): Omit no-longer-needed casts.
273 (Fimagemagick_types): Don't assume size fits into 'int'.
275 Improve hashing quality when configured --with-wide-int.
276 * fns.c (hash_string): New function, taken from sxhash_string.
277 Do not discard information about ASCII character case; this
278 discarding is no longer needed.
279 (sxhash-string): Use it. Change sig to match it. Caller changed.
280 * lisp.h: Declare it.
281 * lread.c (hash_string): Remove, since we now use fns.c's version.
282 The fns.c version returns a wider integer if --with-wide-int is
283 specified, so this should help the quality of the hashing a bit.
285 * emacs.c: Integer overflow minor fix.
286 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
287 Define only if GNU_LINUX.
288 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
290 * dispnew.c: Integer signedness and overflow fixes.
291 Remove unnecessary forward decls, that were a maintenance hassle.
292 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
294 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
295 (scrolling_window): Use ptrdiff_t, not int, for byte count.
296 (prepare_desired_row, line_draw_cost):
297 Use int, not unsigned, where either works.
298 (save_current_matrix, restore_current_matrix):
299 Use ptrdiff_t, not size_t, where either works.
300 (init_display): Check for overflow more accurately, and without
301 relying on undefined behavior.
303 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
304 Remove, replacing with the new symbols in lisp.h. All uses changed.
305 * fileio.c (make_temp_name):
306 * filelock.c (lock_file_1, lock_file):
307 * xdisp.c (message_dolog):
308 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
309 Use pMd etc. instead.
310 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
311 replacing the pWIDE etc. symbols removed from editfns.c.
313 * keyboard.h (num_input_events): Now uintmax_t.
314 This is (very slightly) less likely to mess up due to wraparound.
317 * buffer.c: Integer signedness fixes.
318 (alloc_buffer_text, enlarge_buffer_text):
319 Use ptrdiff_t rather than size_t when either will do, as we prefer
322 * alloc.c: Integer signedness and overflow fixes.
323 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
324 (__malloc_size_t): Default to size_t, not to int.
325 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
326 (Fgarbage_collect, mark_object_loop_halt, mark_object):
327 Prefer ptrdiff_t to size_t when either would do, as we prefer
329 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
330 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
331 Now const. Initialize with values that are in range even if char
333 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
334 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
335 These functions do the right thing with sizes > 2**32.
336 (check_depth): Now ptrdiff_t, not int.
337 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
338 Adjust to new way of storing sizes. Check for size overflow bugs
340 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
341 slightly wrong anyway, as it missed one instance of
342 XMALLOC_OVERRUN_CHECK_OVERHEAD.
343 (refill_memory_reserve): Omit needless cast to size_t.
344 (mark_object_loop_halt): Mark as externally visible.
346 * xselect.c: Integer signedness and overflow fixes.
347 (Fx_register_dnd_atom, x_handle_dnd_message):
348 Use ptrdiff_t, not size_t, since we prefer signed.
349 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
350 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
351 x_dnd_atoms_size and x_dnd_atoms_length.
353 * doprnt.c: Prefer signed to unsigned when either works.
357 * xdisp.c (vmessage):
358 Use ptrdiff_t, not size_t, when using or implementing doprnt,
359 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
360 prefer signed arithmetic to avoid comparison confusion.
361 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
364 Assume freestanding C89 headers, string.h, stdlib.h.
365 * data.c, doprnt.c, floatfns.c, print.c:
366 Include float.h unconditionally.
367 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
368 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
369 * regex.c: Likewise for stddef.h, string.h.
370 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
371 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
372 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
373 (STDC_HEADERS): Remove obsolete defines.
374 * sysdep.c: Include limits.h unconditionally.
376 Assume support for memcmp, memcpy, memmove, memset.
377 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
378 * regex.c (memcmp, memcpy):
379 Remove; we assume C89 now.
381 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
382 (__malloc_safe_bcopy): Remove; no longer needed.
384 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
385 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
386 well either way, and we prefer signed to unsigned.
388 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
390 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
391 closes the connection while we're reading (bug#9182).
393 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
395 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
396 are specified (Bug#9168).
398 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
400 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
401 Found by GCC static checking and --with-wide-int on a 32-bit host.
403 2011-07-25 Eli Zaretskii <eliz@gnu.org>
405 * xdisp.c (compute_display_string_pos): Fix logic of caching
406 previous display string position. Initialize cached_prev_pos to
407 -1. Fixes slow-down at the beginning of a buffer.
409 2011-07-24 Eli Zaretskii <eliz@gnu.org>
411 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
412 for attrs[LFACE_FONTSET_INDEX].
414 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
416 * xml.c (parse_region): Remove unused local
417 that was recently introduced.
419 2011-07-23 Eli Zaretskii <eliz@gnu.org>
421 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
422 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
424 * xdisp.c (move_it_in_display_line_to): Record the best matching
425 position for TO_CHARPOS while scanning the line, and restore it on
426 exit if none of the characters scanned was an exact match.
427 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
428 when exact match is impossible due to invisible text, and the
431 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
433 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
436 2011-07-22 Eli Zaretskii <eliz@gnu.org>
438 Fix a significant slow-down of cursor motion with C-n, C-p,
439 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
440 auto-repeat under bidi redisplay in fontified buffers.
441 * xdisp.c (compute_stop_pos_backwards): New function.
442 (next_element_from_buffer): Call compute_stop_pos_backwards to
443 find a suitable prev_stop when we find ourselves before
445 (reseat): Don't look for prev_stop, as that could mean a very long
447 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
448 <cached_disp_overlay_modiff>: Cache for last found display string
450 (compute_display_string_pos): Return the cached position if asked
451 about the same buffer in the same area of character positions, and
452 the buffer wasn't changed since the time the display string
455 2011-07-22 Eli Zaretskii <eliz@gnu.org>
457 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
458 is an integer, which is important for empty lines. (Bug#9149)
460 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
462 * frame.c (Fmodify_frame_parameters): In tty case, update the
463 default face if necessary (Bug#4238).
465 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
467 * editfns.c (Fstring_to_char): No need to explain what a character
468 is in the docstring (Bug#6576).
470 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
472 * xml.c (parse_region): Make sure we always return a tree.
474 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
476 * xml.c (parse_region): If a document contains only comments,
479 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
481 * xml.c (make_dom): Return comments, too.
483 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
486 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
487 and the surrounding thread.
488 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
489 rather than fgets, and retry after EINTR. Otherwise, 'emacs
490 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
492 * s/openbsd.h (BROKEN_SIGIO): Define.
493 * unexelf.c (unexec) [__OpenBSD__]:
494 Don't update the .mdebug section of the Alpha COFF symbol table.
496 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
498 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
501 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
503 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
504 This fixes some race conditions on the permissions of any newly
507 * alloc.c (valid_pointer_p): Use pipe, not open.
508 This fixes some permissions issues when debugging.
510 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
511 If fchown fails to set both uid and gid, try to set just gid,
512 as that is sometimes allowed. Adjust the file's mode to eliminate
513 setuid or setgid bits that are inappropriate if fchown fails.
515 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
517 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
518 to compare Lisp_Objects.
519 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
520 global_gnutls_log_level, don't mistake it for a Lisp_Object.
521 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
523 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
525 * lread.c (read_integer): Unread even EOF character.
526 (read1): Likewise. Properly record start position of symbol.
528 * lread.c (read1): Read `#:' as empty uninterned symbol if no
529 symbol character follows.
531 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
533 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
534 This works around a problem with the previous change to Fcopy_file.
535 Recent glibc declares fchown with __attribute__((warn_unused_result)),
536 and without this change, GCC might complain about discarding
537 fchown's return value.
539 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
541 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
543 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
545 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
547 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
549 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
550 it's used from the C level.
552 * process.c: Use the same condition for POLL_FOR_INPUT in both
553 keyboard.c and process.c (bug#1858).
555 2011-07-09 Lawrence Mitchell <wence@gmx.li>
557 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
558 (Fgnutls_boot): Use it.
560 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
562 * doc.c (Fsubstitute_command_keys): Revert last change.
564 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
566 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
567 quotes the next character, and doesn't affect other longer
568 sequences (bug#8935).
570 * lread.c (syms_of_lread): Clarify that is isn't only
571 `eval-buffer' and `eval-defun' that's affected by
572 `lexical-binding' (bug#8460).
574 2011-07-15 Eli Zaretskii <eliz@gnu.org>
576 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
577 bidi redisplay when a line includes both an image and is
580 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
582 Fix minor problems found by static checking.
583 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
584 (elsz): Now a signed constant, not a size_t var. We prefer signed
585 types to unsigned, to avoid integer comparison confusion. Without
586 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
587 "cannot optimize loop, the loop counter may overflow", a symptom
589 * indent.c (Fvertical_motion): Mark locals as initialized.
590 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
592 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
594 * search.c (Fre_search_backward): Mention `case-fold-search' in
595 all the re_search_* functions (bug#8138).
597 * keyboard.c (Fopen_dribble_file): Document when the file is
600 2011-07-14 Eli Zaretskii <eliz@gnu.org>
602 * bidi.c (bidi_dump_cached_states): Fix format of displaying
605 Support bidi reordering of display and overlay strings.
606 * xdisp.c (compute_display_string_pos)
607 (compute_display_string_end): Accept additional argument STRING.
608 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
609 (reseat_to_string): Initialize bidi_it->string.s and
610 bidi_it->string.schars.
611 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
612 NULL (avoids a crash in bidi_paragraph_init).
613 Initialize itb.string.lstring.
614 (init_iterator): Call bidi_init_it only of a valid
615 buffer position was specified. Initialize paragraph_embedding to
617 (reseat_to_string): Initialize the bidi iterator.
618 (display_string): If we need to ignore text properties of
619 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
620 original value of -1 will not work with bidi.)
621 (compute_display_string_pos): First arg is now struct
622 `text_pos *'; all callers changed. Support display properties on
624 (compute_display_string_end): Support display properties on Lisp
626 (init_iterator, reseat_1, reseat_to_string): Initialize the
627 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
628 when iterating on a string not from display properties).
629 (compute_display_string_pos, compute_display_string_end):
630 Fix calculation of the object to scan. Fixes an error when using
632 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
633 base_level_stop; instead, set base_level_stop to BEGV.
634 Fixes crashes in vertical-motion.
635 (next_element_from_buffer): Improve commentary for when
636 the iterator is before prev_stop.
637 (init_iterator): Initialize bidi_p from the default value of
638 bidi-display-reordering, not from buffer-local value. Use the
639 buffer-local value only if initializing for buffer iteration.
640 (handle_invisible_prop): Support invisible properties on strings
641 that are being bidi-reordered.
642 (set_iterator_to_next): Support bidi reordering of C strings and
644 (next_element_from_string): Support bidi reordering of Lisp
646 (handle_stop_backwards): Support Lisp strings as well.
647 (display_string): Support display of R2L glyph rows.
648 Use IT_STRING_CHARPOS when displaying from a Lisp string.
649 (init_iterator): Don't initialize it->bidi_p for strings
651 (reseat_to_string): Initialize it->bidi_p for strings here.
652 (next_element_from_string, next_element_from_c_string)
653 (next_element_from_buffer): Add xassert's for correspondence
654 between IT's object being iterated and it->bidi_it.string
656 (face_before_or_after_it_pos): Support bidi iteration.
657 (next_element_from_c_string): Handle the case of the first string
658 character that is not the first one in the visual order.
659 (get_visually_first_element): New function, refactored from common
660 parts of next_element_from_buffer, next_element_from_string, and
661 next_element_from_c_string.
662 (tool_bar_lines_needed, redisplay_tool_bar)
663 (display_menu_bar): Force left-to-right direction. Add a FIXME
664 comment for making that be controlled by a user option.
665 (push_it, pop_it): Save and restore the state of the
666 bidi iterator. Save and restore the bidi_p flag.
667 (pop_it): Iterate out of display property for string iteration as
669 (iterate_out_of_display_property): Support iteration over strings.
670 (handle_single_display_spec): Set up it->bidi_it for iteration
671 over a display string, and call bidi_init_it.
672 (handle_single_display_spec, next_overlay_string)
673 (get_overlay_strings_1, push_display_prop): Set up the bidi
674 iterator for displaying display or overlay strings.
675 (forward_to_next_line_start): Don't use the shortcut if
677 (back_to_previous_visible_line_start): If handle_display_prop
678 pushed the iterator stack, restore the internal state of the bidi
679 iterator by calling bidi_pop_it same number of times.
680 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
681 and we are bidi-iterating, don't decrement the iterator position;
682 instead, set the first_elt flag in the bidi iterator, to produce
684 (reseat_1): Remove redundant setting of string_from_display_prop_p.
685 (push_display_prop): xassert that we are iterating a buffer.
686 (push_it, pop_it): Save and restore paragraph_embedding member.
687 (handle_single_display_spec, next_overlay_string)
688 (get_overlay_strings_1, reseat_1, reseat_to_string)
689 (push_display_prop): Set up the `unibyte' member of bidi_it.string
690 correctly. Don't assume unibyte strings are not bidi-reordered.
691 (compute_display_string_pos)
692 (compute_display_string_end): Fix handling the case of C string.
693 (push_it, pop_it): Save and restore from_disp_prop_p.
694 (handle_single_display_spec, push_display_prop): Set the
695 from_disp_prop_p flag.
696 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
697 (pop_it): Call iterate_out_of_display_property only if we are
698 popping after iteration over a string that came from a display
699 property. Fix a typo in popping stretch info. Add an assertion
700 for verifying that the iterator position is in sync with the bidi
702 (handle_single_display_spec, get_overlay_strings_1)
703 (push_display_prop): Fix initialization of paragraph direction for
704 string when that of the parent object is not yet determined.
705 (reseat_1): Call bidi_init_it to resync the bidi
706 iterator with IT's position. (Bug#7616)
707 (find_row_edges): If ROW->start.pos gives position
708 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
709 (handle_stop, back_to_previous_visible_line_start, reseat_1):
710 Reset the from_disp_prop_p flag.
711 (SAVE_IT, RESTORE_IT): New macros.
712 (pos_visible_p, face_before_or_after_it_pos)
713 (back_to_previous_visible_line_start)
714 (move_it_in_display_line_to, move_it_in_display_line)
715 (move_it_to, move_it_vertically_backward, move_it_by_lines)
716 (try_scrolling, redisplay_window, display_line): Use them when
717 saving a temporary copy of the iterator and restoring it back.
718 (back_to_previous_visible_line_start, reseat_1)
719 (init_iterator): Empty the bidi cache "stack".
720 (move_it_in_display_line_to): If iterator ended up at
721 EOL, but we never saw any buffer positions smaller than
722 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
723 motion in bidi-reordered lines.
724 (move_it_in_display_line_to): Record prev_method and prev_pos
725 immediately before the call to set_iterator_to_next. Fixes cursor
726 motion in bidi-reordered lines with stretch glyphs and strings
727 displayed in margins. (Bug#8133) (Bug#8867)
728 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
730 (pos_visible_p): Support positions in bidi-reordered lines.
731 Save and restore bidi cache.
733 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
734 (bidi_paragraph_info): Delete unused struct.
735 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
736 (bidi_cache_start): New variable.
737 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
739 (bidi_cache_fetch_state, bidi_cache_search)
740 (bidi_cache_find_level_change, bidi_cache_iterator_state)
741 (bidi_cache_find, bidi_peek_at_next_level)
742 (bidi_level_of_next_char, bidi_find_other_level_edge)
743 (bidi_move_to_visually_next): Compare cache index with
744 bidi_cache_start rather than with zero.
745 (bidi_fetch_char): Accept new argument STRING; all callers
746 changed. Support iteration over a string. Support strings with
747 display properties. Support unibyte strings. Fix the type of
748 `len' according to what STRING_CHAR_AND_LENGTH expects.
749 (bidi_paragraph_init, bidi_resolve_explicit_1)
750 (bidi_resolve_explicit, bidi_resolve_weak)
751 (bidi_level_of_next_char, bidi_move_to_visually_next):
752 Support iteration over a string.
753 (bidi_set_sor_type, bidi_resolve_explicit_1)
754 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
755 can now be zero (for strings); special values 0 and -1 were
756 changed to -1 and -2, respectively.
757 (bidi_char_at_pos): New function.
758 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
759 Call it instead of FETCH_MULTIBYTE_CHAR.
760 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
761 initialized to valid values.
762 (bidi_init_it): Don't initialize charpos and bytepos with invalid
764 (bidi_level_of_next_char): Allow the sentinel "position" to pass
765 the test for valid cached positions. Fix the logic for looking up
766 the sentinel state in the cache. GCPRO the Lisp string we are
768 (bidi_push_it, bidi_pop_it): New functions.
769 (bidi_initialize): Initialize the bidi cache start stack pointer.
770 (bidi_cache_ensure_space): New function, refactored from part of
771 bidi_cache_iterator_state. Don't assume the required size is just
772 one BIDI_CACHE_CHUNK away.
773 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
774 (bidi_count_bytes, bidi_char_at_pos): New functions.
775 (bidi_cache_search): Don't assume bidi_cache_last_idx is
776 always valid if bidi_cache_idx is valid.
777 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
778 is valid if it's going to be used.
779 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
780 (bidi_cache_fetch_state, bidi_cache_search)
781 (bidi_cache_find_level_change, bidi_cache_ensure_space)
782 (bidi_cache_iterator_state, bidi_cache_find)
783 (bidi_find_other_level_edge, bidi_cache_start_stack):
784 All variables related to cache indices are now EMACS_INT.
786 * dispextern.h (struct bidi_string_data): New structure.
787 (struct bidi_it): New member `string'. Make flag members be 1-bit
788 fields, and put them last in the struct.
789 (compute_display_string_pos, compute_display_string_end):
791 (bidi_push_it, bidi_pop_it): Add prototypes.
792 (struct iterator_stack_entry): New members bidi_p,
793 paragraph_embedding, and from_disp_prop_p.
794 (struct it): Member bidi_p is now a bit field 1 bit wide.
795 (bidi_shelve_cache, bidi_unshelve_cache):
798 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
799 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
800 and vector-like objects.
802 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
803 cache around display iteration.
805 * window.c (Fwindow_end, window_scroll_pixel_based)
806 (displayed_window_lines, Frecenter): Save and restore the bidi
807 cache around display iteration.
809 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
811 * editfns.c (Fdelete_region): Clarify the use of the named
812 parameters (bug#6788).
814 2011-07-14 Martin Rudalics <rudalics@gmx.at>
816 * indent.c (Fvertical_motion): Set and restore w->pointm when
817 saving and restoring the window's buffer (Bug#9006).
819 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
821 * editfns.c (Fstring_to_char): Clarify just what is returned
822 (bug#6576). Text by Eli Zaretskii.
824 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
826 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
828 2011-07-13 Eli Zaretskii <eliz@gnu.org>
830 * buffer.c (mmap_find): Fix a typo.
832 2011-07-13 Johan Bockgård <bojohan@gnu.org>
834 Fix execution of x selection hooks.
835 * xselect.c (Qx_lost_selection_functions)
836 (Qx_sent_selection_functions): New vars.
837 (syms_of_xselect): DEFSYM them.
838 (x_handle_selection_request): Pass Qx_sent_selection_functions
839 rather than Vx_sent_selection_functions to Frun_hook_with_args.
840 (x_handle_selection_clear,x_clear_frame_selections):
841 Pass Qx_lost_selection_functions rather than
842 Vx_lost_selection_functions to Frun_hook_with_args.
844 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
846 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
847 The old code sometimes used this field without initializing it.
849 * alloc.c (gc_sweep): Don't read past end of array.
850 In theory, the old code could also have corrupted Emacs internals,
851 though it'd be very unlikely.
853 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
855 * character.c (Fcharacterp): Don't advertise optional ignored
858 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
860 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
863 * window.c (Fset_window_start): Doc fix (bug#4199).
864 (Fset_window_hscroll): Ditto.
866 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
868 Fix minor new problems caught by GCC 4.6.1.
869 * term.c (init_tty): Remove unused local.
870 * xsettings.c (store_monospaced_changed): Define this function only
871 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
874 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
876 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
878 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
880 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
881 are the mini-buffer and the echo area (bug#3320).
883 * term.c (init_tty): Remove support for supdup, c10 and perq
884 terminals, which are no longer supported (bug#1482).
886 2011-07-10 Johan Bockgård <bojohan@gnu.org>
888 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
890 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
892 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
893 for non-popups (Bug#3642).
895 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
897 * alloc.c (reset_malloc_hooks): Protoize.
898 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
899 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
900 * cm.c (losecursor): Likewise.
901 * data.c (fmod): Likewise.
902 * dispnew.c (swap_glyphs_in_rows): Likewise.
903 * emacs.c (memory_warning_signal): Likewise.
904 * floatfns.c (float_error): Likewise.
905 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
906 (otf_open, font_otf_capability, generate_otf_features)
907 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
909 * image.c (pbm_read_file): Likewise.
910 * indent.c (string_display_width): Likewise.
911 * intervals.c (check_for_interval, search_for_interval)
912 (inc_interval_count, count_intervals, root_interval)
913 (adjust_intervals_for_insertion, make_new_interval): Likewise.
914 * lread.c (defalias): Likewise.
915 * ralloc.c (r_alloc_check): Likewise.
916 * regex.c (set_image_of_range_1, set_image_of_range)
917 (regex_grow_registers): Likewise.
918 * sysdep.c (strerror): Likewise.
919 * termcap.c (valid_filename_p, tprint, main): Likewise.
920 * tparam.c (main): Likewise.
921 * unexhp9k800.c (run_time_remap, save_data_space)
922 (update_file_ptrs, read_header, write_header, calculate_checksum)
923 (copy_file, copy_rest, display_header): Likewise.
924 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
926 * xdisp.c (check_it): Likewise.
927 * xfaces.c (register_color, unregister_color, unregister_colors):
929 * xfns.c (print_fontset_result): Likewise.
930 * xrdb.c (member, fatal, main): Likewise.
932 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
934 Fix minor problems found by static checking (Bug#9031).
935 * chartab.c (char_table_set_range, map_sub_char_table):
936 Remove unused locals.
937 (uniprop_table): Now static.
938 * composite.c (_work_char): Remove unused static var.
940 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
942 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
944 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
946 * gtkutil.c (qttip_cb): Remove code without function.
948 2011-07-09 Eli Zaretskii <eliz@gnu.org>
950 * w32.c (pthread_sigmask): New stub.
952 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
954 Use pthread_sigmask, not sigprocmask (Bug#9010).
955 sigprocmask is portable only for single-threaded applications, and
956 Emacs can be multi-threaded when it uses GTK.
957 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
959 * callproc.c (Fcall_process):
960 * process.c (create_process):
961 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
962 Use pthread_sigmask, not sigprocmask.
964 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
966 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
967 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
970 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
972 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
973 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
974 (xg_hide_tooltip): Fix comment.
976 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
977 in registerServicesMenuSendTypes.
978 (validRequestorForSendType): Don't check ns_return_types.
980 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
983 2011-07-08 Jason Rumney <jasonr@gnu.org>
985 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
986 frame struct members of non-existent frames (Bug#6284).
988 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
990 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
991 variable firstTime not needed on OSX >= 10.6.
992 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
993 >= 10.5. Use setKnobProportion, setDoubleValue.
995 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
996 (MAC_OS_X_VERSION_10_5): Define if not defined.
997 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
998 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
999 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1001 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1002 cString and lossyCString on OSX >= 10.4
1004 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1005 sizeToFit on OSX >= 10.2.
1007 * nsimage.m (allocInitFromFile): Don't use deprecated method
1008 bestRepresentationForDevice on OSX >= 10.6.
1010 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1013 * emacs.c: Declare unexec_init_emacs_zone.
1015 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1017 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1019 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1020 on svcsMenu (Bug#8842).
1022 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1024 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1026 * nsterm.m (QUTF8_STRING): Declare.
1027 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1028 (validRequestorForSendType): Return type is (id).
1029 Change indexOfObjectIdenticalTo to indexOfObject.
1030 Check if we have local selection before returning self (Bug#8842).
1031 (writeSelectionToPasteboard): Put local selection into paste board
1032 if we have a local selection (Bug#8842).
1033 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1035 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1036 (ns_get_local_selection): Declare.
1038 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1040 * keymap.c (describe_map_tree): Don't insert a double newline at
1041 the end of the buffer (bug#1169) and return whether we inserted
1044 * callint.c (Fcall_interactively): Change "reading args" to
1045 "providing args" to try to clarify what it does (bug#1010).
1047 2011-07-07 Kenichi Handa <handa@m17n.org>
1049 * composite.c (composition_compute_stop_pos): Ignore a static
1050 composition starting before CHARPOS (Bug#8915).
1052 * xdisp.c (handle_composition_prop): Likewise.
1054 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1056 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1059 2011-07-07 Kenichi Handa <handa@m17n.org>
1061 * character.h (unicode_category_t): New enum type.
1063 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1064 (Qchar_code_property_table): New variable.
1065 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1066 (UNIPROP_COMPRESSED_FORM_P): New macros.
1067 (char_table_ascii): Uncompress the compressed values.
1068 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1069 Uncompress the compressed values.
1070 (sub_char_table_ref_and_range): Likewise.
1071 (char_table_ref_and_range): Uncompress the compressed values.
1072 (sub_char_table_set): New arg is_uniprop. Callers changed.
1073 Uncompress the compressed values.
1074 (sub_char_table_set_range): Args changed. Callers changed.
1075 (char_table_set_range): Adjuted for the above change.
1076 (map_sub_char_table): Delete args default_val and parent. Add arg
1077 top. Give decoded values to a Lisp function.
1078 (map_char_table): Adjust for the above change. Give decoded
1079 values to a Lisp function. Gcpro more variables.
1080 (uniprop_table_uncompress)
1081 (uniprop_decode_value_run_length): New functions.
1082 (uniprop_decoder, uniprop_decoder_count): New variables.
1083 (uniprop_get_decoder, uniprop_encode_value_character)
1084 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1086 (uniprop_encoder, uniprop_encoder_count): New variables.
1087 (uniprop_get_encoder, uniprop_table)
1088 (Funicode_property_table_internal, Fget_unicode_property_internal)
1089 (Fput_unicode_property_internal): New functions.
1090 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1091 Sunicode_property_table_internal, Sget_unicode_property_internal,
1092 and Sput_unicode_property_internal. Defvar_lisp
1093 char-code-property-alist.
1095 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1096 Vunicode_category_table.
1098 * font.c (font_range): Adjust for the change of
1099 Vunicode_category_table.
1101 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1103 * m/iris4d.h: Remove file, move contents ...
1104 * s/irix6-5.h: ... here.
1106 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1108 Remove unportable assumption about struct layout (Bug#8884).
1109 * alloc.c (mark_buffer):
1110 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1111 (clone_per_buffer_values): Don't assume that
1112 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1113 This isn't true in general, and it's particularly not true
1114 if Emacs is configured with --with-wide-int.
1115 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1116 New macros, used in the buffer.c change.
1118 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1120 * xsettings.c: Use both GConf and GSettings if both are available.
1121 (store_config_changed_event): Add comment.
1122 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1123 (store_tool_bar_style_changed): New functions.
1124 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1125 (struct xsettings): Move font inside HAVE_XFT.
1126 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1127 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1128 Move inside HAVE_XFT.
1129 (something_changed_gsettingsCB): Rename from something_changedCB.
1130 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1132 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1133 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1134 (something_changed_gconfCB): Rename from something_changedCB.
1135 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1136 (parse_settings): Move check for font inside HAVE_XFT.
1137 (read_settings, apply_xft_settings): Add comment.
1138 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1139 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1140 call store_font_name_changed.
1141 (xft_settings_event): Add comment.
1142 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1143 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1144 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1145 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1146 (xsettings_initialize): Call init_gsettings last.
1147 (xsettings_get_system_font, xsettings_get_system_normal_font):
1150 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1152 Random fixes. E.g., (random) never returned negative values.
1153 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1154 subseconds part to the entropy, as that's a bit more random.
1155 Prefer signed to unsigned, since the signedness doesn't matter and
1156 in general we prefer signed. When given a limit, use a
1157 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1158 latter isn't right if USE_2_TAGS_FOR_INTS.
1159 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1160 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1162 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1164 * textprop.c (text_property_stickiness):
1165 Obey Vtext_property_default_nonsticky.
1166 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1167 * w32fns.c (syms_of_w32fns):
1168 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1170 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1172 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1173 This is more efficient than Ffile_directory_p and avoids a minor race.
1175 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1177 * buffer.c (Foverlay_put): Say what the return value is
1180 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1181 is a directory before asking whether to use the file name
1183 (barf_or_query_if_file_exists): Make the "File is a directory"
1184 error be more correct.
1186 * fns.c (Frequire): Remove the mention of the .gz files, since
1187 that's installation-specific, but keep the mention of
1188 `get-load-suffixes'.
1190 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1192 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1193 Report string overflow if the output is too long.
1195 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1197 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1198 (syms_of_gnutls): Remove duplicate DEFSYM for
1199 Qgnutls_bootprop_verify_hostname_error, an error for
1200 Qgnutls_bootprop_verify_error (which is no longer used).
1202 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1203 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1204 Also (re)move comments that are misplaced or no longer relevant.
1206 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1208 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1210 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1212 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1213 and background color parameters if they have been changed.
1215 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1217 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1219 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1221 * xsettings.c (SYSTEM_FONT): Define only when used.
1222 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1224 * keymap.c (access_keymap_1): Now static.
1226 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1228 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1229 leave any prefix arg for the up event (Bug#1586).
1231 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1233 * lread.c (syms_of_lread): Mention single symbols defined by
1234 `defvar' or `defconst' (bug#7154).
1236 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1237 (Frequire): Mention get-load-suffixes.
1239 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1241 * window.h (window): Remove clone_number slot.
1242 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1244 (make_parent_window, make_window, saved_window)
1245 (Fset_window_configuration, save_window_save): Don't deal with
1247 * buffer.c (Qclone_number): Remove declaration.
1248 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1250 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1252 Add multiple inheritance to keymaps.
1253 * keymap.c (Fmake_composed_keymap): New function.
1254 (Fset_keymap_parent): Simplify.
1255 (fix_submap_inheritance): Remove.
1256 (access_keymap_1): New function extracted from access_keymap to handle
1257 embedded parents and handle lists of maps.
1258 (access_keymap): Use it.
1259 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1260 (Fcopy_keymap): Handle embedded parents.
1261 (Fcommand_remapping, define_as_prefix): Simplify.
1262 (Fkey_binding): Simplify.
1263 (syms_of_keymap): Move minibuffer-local-completion-map,
1264 minibuffer-local-filename-completion-map,
1265 minibuffer-local-must-match-map, and
1266 minibuffer-local-filename-must-match-map to Elisp.
1267 (syms_of_keymap): Defsubr make-composed-keymap.
1268 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1269 (parse_menu_item): Trivial simplification.
1271 2011-07-01 Glenn Morris <rgm@gnu.org>
1273 * Makefile.in (SETTINGS_LIBS): Fix typo.
1275 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1277 * coding.c (Fencode_coding_string): Record the last coding system
1278 used, as the function doc string says (bug#8738).
1280 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1282 * xsettings.c (store_monospaced_changed): Take new font as arg and
1283 check for change against current_mono_font.
1284 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1285 (emacs_settings_constructor, emacs_settings_get_property)
1286 (emacs_settings_set_property, emacs_settings_class_init)
1287 (emacs_settings_init, gsettings_obj): Remove.
1288 (something_changedCB): New function for HAVE_GSETTINGS.
1289 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1290 with value as argument.
1291 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1292 g_settings_new (Bug#8967). Do not create gsettings_obj.
1293 Remove calls to g_settings_bind. Connect something_changedCB to
1296 * xgselect.c: Add defined (HAVE_GSETTINGS).
1297 (xgselect_initialize): Ditto.
1299 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1300 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1303 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1305 * eval.c (struct backtrace): Simplify and port the data structure.
1306 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1307 signed bit field, as this assumption is not portable and it makes
1308 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1309 "char debug_on_exit : 1" as this is not portable either; instead,
1310 use the portable "unsigned int debug_on_exit : 1". Remove unused
1311 member evalargs. Remove obsolete comments about cc bombing out.
1313 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1315 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1316 Let HAVE_GSETTINGS override HAVE_GCONF.
1317 (store_monospaced_changed): New function.
1318 (EMACS_SETTINGS): A new type derived from GObject to handle
1319 GSettings notifications.
1320 (emacs_settings_constructor, emacs_settings_get_property)
1321 (emacs_settings_set_property, emacs_settings_class_init):
1323 (gsettings_client, gsettings_obj): New variables.
1324 (GSETTINGS_SCHEMA): New define.
1325 (something_changedCB): Call store_monospaced_changed.
1326 (init_gsettings): New function.
1327 (xsettings_initialize): Call init_gsettings.
1328 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1331 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1334 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1336 * window.c (resize_root_window, grow_mini_window)
1337 (shrink_mini_window): Rename Qresize_root_window to
1338 Qwindow_resize_root_window and Qresize_root_window_vertically to
1339 Qwindow_resize_root_window_vertically.
1341 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1343 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1345 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1347 * makefile.w32-in: Redesign dependencies so they reflect more
1348 clearly which files are directly included by each source file,
1349 and not through other includes.
1351 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1353 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1354 (sort_overlays, overlay_strings): When an overlay's clone number
1355 matches the window's clone number process the overlay even if
1356 the overlay's window property doesn't match the current window.
1358 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1359 (Fwindow_hchild): Rename to Fwindow_left_child.
1360 (Fwindow_next): Rename to Fwindow_next_sibling.
1361 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1362 (resize_window_check): Rename to window_resize_check.
1363 (resize_window_apply): Rename to window_resize_apply.
1364 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1365 (Fdelete_other_windows_internal, resize_frame_windows)
1366 (Fsplit_window_internal, Fdelete_window_internal)
1367 (grow_mini_window, shrink_mini_window)
1368 (Fresize_mini_window_internal): Fix callers accordingly.
1370 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1372 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1373 (emacs_fixed_set_min_size): Remove.
1374 (emacs_fixed_new): Take frame as argument.
1376 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1377 (_EmacsFixedPrivate): Remove minwidth/height.
1378 Add struct frame *f.
1379 (emacs_fixed_init): Initialize priv->f.
1380 (get_parent_class, emacs_fixed_set_min_size): Remove.
1381 (emacs_fixed_new): Set priv->f to argument.
1382 (emacs_fixed_get_preferred_width)
1383 (emacs_fixed_get_preferred_height): Use min_width/height from
1384 frames size_hint to set minimum and natural (Bug#8919).
1385 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1386 and use min_width/height from frames size_hint to set
1387 min_width/height (Bug#8919).
1389 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1390 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1393 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1395 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1396 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1399 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1401 * process.c (wait_reading_process_output): Bypass select if
1402 waiting for a cell while ignoring keyboard input, and input is
1403 pending. Suggested by Jan Djärv (Bug#8869).
1405 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1407 Use gnulib's dup2 module instead of rolling our own.
1408 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1410 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1412 * dispnew.c (scrolling_window): Before scrolling, turn off a
1413 mouse-highlight in the window being scrolled.
1415 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1417 Move DEFSYM to lisp.h and use everywhere.
1419 * character.h (DEFSYM): Move declaration...
1420 * lisp.h (DEFSYM): ...here.
1426 * w32select.c: Don't include character.h.
1428 * alloc.c (syms_of_alloc):
1429 * buffer.c (syms_of_buffer):
1430 * bytecode.c (syms_of_bytecode):
1431 * callint.c (syms_of_callint):
1432 * casefiddle.c (syms_of_casefiddle):
1433 * casetab.c (init_casetab_once):
1434 * category.c (init_category_once, syms_of_category):
1435 * ccl.c (syms_of_ccl):
1436 * cmds.c (syms_of_cmds):
1437 * composite.c (syms_of_composite):
1438 * dbusbind.c (syms_of_dbusbind):
1439 * dired.c (syms_of_dired):
1440 * dispnew.c (syms_of_display):
1441 * doc.c (syms_of_doc):
1442 * editfns.c (syms_of_editfns):
1443 * emacs.c (syms_of_emacs):
1444 * eval.c (syms_of_eval):
1445 * fileio.c (syms_of_fileio):
1446 * fns.c (syms_of_fns):
1447 * frame.c (syms_of_frame):
1448 * fringe.c (syms_of_fringe):
1449 * insdel.c (syms_of_insdel):
1450 * keymap.c (syms_of_keymap):
1451 * lread.c (init_obarray, syms_of_lread):
1452 * macros.c (syms_of_macros):
1453 * msdos.c (syms_of_msdos):
1454 * print.c (syms_of_print):
1455 * process.c (syms_of_process):
1456 * search.c (syms_of_search):
1457 * sound.c (syms_of_sound):
1458 * syntax.c (init_syntax_once, syms_of_syntax):
1459 * terminal.c (syms_of_terminal):
1460 * textprop.c (syms_of_textprop):
1461 * undo.c (syms_of_undo):
1462 * w32.c (globals_of_w32):
1463 * window.c (syms_of_window):
1464 * xdisp.c (syms_of_xdisp):
1465 * xfaces.c (syms_of_xfaces):
1466 * xfns.c (syms_of_xfns):
1467 * xmenu.c (syms_of_xmenu):
1468 * xsettings.c (syms_of_xsettings):
1469 * xterm.c (syms_of_xterm): Use DEFSYM.
1471 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1473 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1475 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1477 Integer and buffer overflow fixes (Bug#8873).
1479 * print.c (printchar, strout): Check for string overflow.
1480 (PRINTPREPARE, printchar, strout):
1481 Don't set size unless allocation succeeds.
1483 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1484 for sizes. Check for string overflow more accurately.
1485 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1487 * macros.c: Integer and buffer overflow fixes.
1488 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1489 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1490 Use ptrdiff_t, not int, for sizes.
1491 Don't increment bufsize until after realloc succeeds.
1492 Check for size-calculation overflow.
1493 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1495 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1497 * lread.c: Integer overflow fixes.
1498 (read_integer): Radix is now EMACS_INT, not int,
1499 to improve quality of diagnostics for out-of-range radices.
1500 Calculate buffer size correctly for out-of-range radices.
1501 (read1): Check for integer overflow in radices, and in
1502 read-circle numbers.
1503 (read_escape): Avoid int overflow.
1504 (Fload, openp, read_buffer_size, read1)
1505 (substitute_object_recurse, read_vector, read_list, map_obarray):
1506 Use ptrdiff_t, not int, for sizes.
1507 (read1): Use EMACS_INT, not int, for sizes.
1508 Check for size overflow.
1510 * image.c (cache_image): Check for size arithmetic overflow.
1512 * lread.c: Integer overflow issues.
1513 (saved_doc_string_size, saved_doc_string_length)
1514 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1515 Now ptrdiff_t, not int.
1516 (read1): Don't assume doc string length fits in int. Check for
1517 out-of-range doc string lengths.
1518 (read_list): Don't assume file position fits in int.
1519 (read_escape): Check for hex character overflow.
1521 2011-06-22 Leo Liu <sdl.web@gmail.com>
1523 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1524 Move to minibuffer.el.
1526 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1528 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1529 The following patches are for when GLYPH_DEBUG && !XASSERT.
1530 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1531 * dispnew.c (flush_stdout):
1532 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1533 Mark as externally visible.
1534 * dispnew.c (check_window_matrix_pointers): Now static.
1535 * dispnew.c (window_to_frame_vpos):
1536 * xfns.c (unwind_create_frame):
1537 * xterm.c (x_check_font): Remove unused local.
1538 * scroll.c (CHECK_BOUNDS):
1539 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1540 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1541 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1542 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1543 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1545 (debug_method_add): Use va_list and vsprintf rather than relying
1546 on undefined behavior with wrong number of arguments.
1547 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1548 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1549 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1550 since we're not interested in debugging glyphs with old libraries.
1551 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1552 GCC 4.6.0's static checking.
1554 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1556 Integer overflow and signedness fixes (Bug#8873).
1557 A few related buffer overrun fixes, too.
1559 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1561 * dispextern.h (struct face.stipple):
1562 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1563 (x_bitmap_mask, x_allocate_bitmap_record)
1564 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1565 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1566 (x_create_bitmap_from_xpm_data):
1567 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1568 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1570 * xfaces.c (load_pixmap):
1571 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1572 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1573 (.bitmaps_last, struct x_output.icon_bitmap):
1574 Use ptrdiff_t, not int, for bitmap indexes.
1575 (x_allocate_bitmap_record): Check for size overflow.
1576 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1578 Use ptrdiff_t, not int, for overlay counts.
1579 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1580 * editfns.c (overlays_around, get_pos_property):
1581 * textprop.c (get_char_property_and_overlay):
1582 * xdisp.c (next_overlay_change, note_mouse_highlight):
1583 * xfaces.c (face_at_buffer_position):
1584 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1585 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1586 (Fnext_overlay_change, Fprevious_overlay_change)
1587 (mouse_face_overlay_overlaps, Foverlays_in):
1588 Use ptrdiff_t, not int, for sizes.
1589 (overlays_at, overlays_in): Check for size-calculation overflow.
1591 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1593 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1594 (x_session_initialize): Do not assume string length fits in int.
1596 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1597 This is unlikely, but can occur if DPI is outlandish.
1599 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1600 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1602 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1603 * xrdb.c (magic_file_p, search_magic_path):
1604 Omit last arg SUFFIX; it was always 0. All callers changed.
1605 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1607 * xfont.c (xfont_match): Avoid need for strlen.
1609 * xfns.c: Don't assume strlen fits in int.
1610 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1612 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1613 not unsigned long, as we prefer signed integers. All callers changed.
1614 Detect integer overflow in repeat count.
1615 (message_dolog): Don't assume print length fits in 39 bytes.
1616 (display_mode_element): Don't assume strlen fits in int.
1618 * termcap.c: Don't assume sizes fit in int and never overflow.
1619 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1620 (gobble_line): Check for size-calculation overflow.
1622 * minibuf.c (Fread_buffer):
1623 * lread.c (intern, intern_c_string):
1624 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1625 Don't assume string length fits in int.
1627 * keyboard.c (parse_tool_bar_item):
1628 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1630 * font.c: Don't assume string length fits in int.
1631 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1632 Use ptrdiff_t, not int.
1633 (font_intern_prop): Don't assume string length fits in int.
1634 Don't assume integer property fits in fixnum.
1635 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1637 * filelock.c: Fix some buffer overrun and integer overflow issues.
1638 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1639 Reformulate so as not to need the command string.
1640 Invoke gzip -cd rather than gunzip, as it's more portable.
1641 (lock_info_type, lock_file_1, lock_file):
1642 Don't assume pid_t and time_t fit in unsigned long.
1643 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1644 (current_lock_owner): Prefer signed type for sizes.
1645 Use memcpy, not strncpy, where memcpy is what is really wanted.
1646 Don't assume (via atoi) that time_t and pid_t fit in int.
1647 Check for time_t and/or pid_t out of range, e.g., via a network share.
1648 Don't alloca where an auto var works fine.
1650 * fileio.c: Fix some integer overflow issues.
1651 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1652 Don't assume string length fits in int.
1653 (directory_file_name): Don't assume string length fits in long.
1654 (make_temp_name): Don't assume pid fits in int, or that its print
1655 length is less than 20.
1657 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1659 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1661 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1663 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1664 We prefer signed integers, even for size calculations.
1666 * emacs.c: Don't assume string length fits in 'int'.
1667 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1668 (main): Don't invoke strlen when not needed.
1670 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1671 (XD_DEBUG_MESSAGE): Don't waste a byte.
1673 * callproc.c (getenv_internal_1, getenv_internal)
1675 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1677 * lread.c (invalid_syntax): Omit length argument.
1678 All uses changed. This doesn't fix a bug, but it simplifies the
1679 code away from its former Hollerith-constant appearance, and it's
1680 one less 'int' to worry about when looking at integer-overflow issues.
1681 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1683 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1684 This didn't break anything, but it didn't help either.
1685 It's confusing to put a bogus integer in a place where the actual
1686 value does not matter.
1687 (LIST_END_P): Remove unused macro and its bogus comment.
1688 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1690 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1691 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1693 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1694 We prefer signed types, and the value cannot exceed the EMACS_INT
1695 range anyway (because otherwise the length would not be representable).
1696 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1697 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1698 This avoids a GCC warning when WIDE_EMACS_INT.
1700 * indent.c (sane_tab_width): New function.
1701 (current_column, scan_for_column, Findent_to, position_indentation)
1702 (compute_motion): Use it. This is just for clarity.
1703 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1705 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1707 * lisp.h (lint_assume): New macro.
1708 * composite.c (composition_gstring_put_cache):
1709 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1711 * editfns.c, insdel.c:
1712 Omit unnecessary forward decls, to simplify future changes.
1714 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1716 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1718 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1719 Use much-faster test for byte-length change.
1720 Don't assume string byte-length fits in 'int'.
1721 Check that character arg fits in 'int'.
1722 (mapcar1): Declare byte as byte, for clarity.
1724 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1726 * fns.c (concat): Catch string overflow earlier.
1727 Do not rely on integer wraparound.
1729 * dispextern.h (struct it.overlay_strings_charpos)
1730 (struct it.selective): Now EMACS_INT, not int.
1731 * xdisp.c (forward_to_next_line_start)
1732 (back_to_previous_visible_line_start)
1733 (reseat_at_next_visible_line_start, next_element_from_buffer):
1734 Don't arbitrarily truncate the value of 'selective' to int.
1736 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1738 * composite.c: Don't truncate sizes to 'int'.
1739 (composition_gstring_p, composition_reseat_it)
1740 (composition_adjust_point): Use EMACS_INT, not int.
1741 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1742 not EMACS_UINT, for indexes.
1744 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1746 * buffer.c: Include <verify.h>.
1747 (struct sortvec.priority, struct sortstr.priority):
1748 Now EMACS_INT, not int.
1749 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1750 (struct sortstr.size, record_overlay_string)
1751 (struct sortstrlist.size, struct sortlist.used):
1752 Don't truncate size to int.
1753 (record_overlay_string): Check for size-calculation overflow.
1754 (init_buffer_once): Check at compile-time, not run-time.
1756 2011-06-22 Jim Meyering <meyering@redhat.com>
1758 Don't leak an XBM-image-sized buffer
1759 * image.c (xbm_load): Free the image buffer after using it.
1761 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1764 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1765 that Sun C diagnosed.
1766 * fns.c (secure_hash): Fix pointer signedness issue.
1767 * intervals.c (static_offset_intervals): New function.
1768 (offset_intervals): Use it.
1770 2011-06-21 Leo Liu <sdl.web@gmail.com>
1773 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1776 * fns.c (secure_hash): Rename from crypto_hash_function and change
1777 the first arg to accept symbols.
1778 (Fsecure_hash): New primitive.
1779 (syms_of_fns): New symbols.
1781 2011-06-20 Deniz Dogan <deniz@dogan.se>
1783 * process.c (Fset_process_buffer): Clarify return value in
1786 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1788 * dispnew.c (add_window_display_history): Use BVAR.
1790 * xdisp.c (debug_method_add): Use BVAR.
1791 (check_window_end, dump_glyph_matrix, dump_glyph)
1792 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1794 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1797 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1798 check till after the cache is created in init_frame_faces.
1800 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1802 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1804 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1806 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1807 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1808 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1810 Improve buffer-overflow checking (Bug#8873).
1811 * fileio.c (Finsert_file_contents):
1812 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1813 Remove the old (too-loose) buffer overflow checks.
1814 They weren't needed, since make_gap checks for buffer overflow.
1815 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1816 The old code merely checked for Emacs fixnum overflow, and relied
1817 on undefined (wraparound) behavior. The new code avoids undefined
1818 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1820 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1821 Tune. Don't use wider integers than needed. Don't use alloca.
1822 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1824 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1826 * insdel.c, lisp.h (buffer_overflow): New function.
1827 (insert_from_buffer_1, replace_range, replace_range_2):
1828 * insdel.c (make_gap_larger):
1829 * editfns.c (Finsert_char):
1830 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1832 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1834 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1836 Integer overflow and signedness fixes (Bug#8873).
1838 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1839 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1841 * fileio.c: Don't assume EMACS_INT fits in off_t.
1842 (emacs_lseek): New static function.
1843 (Finsert_file_contents, Fwrite_region): Use it.
1844 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1846 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1848 * fns.c: Don't overflow int when computing a list length.
1849 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1850 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1851 truncation on 64-bit hosts. Check for QUIT every
1852 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1853 faster and is responsive enough.
1854 (Flength): Report an error instead of overflowing an integer.
1855 (Fsafe_length): Return a float if the value is not representable
1856 as a fixnum. This shouldn't happen except in contrived situations.
1857 (Fnthcdr, Fsort): Don't assume list length fits in int.
1858 (Fcopy_sequence): Don't assume vector length fits in int.
1860 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1861 (header_size, word_size): New constants.
1862 (allocate_vectorlike): Don't check size overflow here.
1863 (allocate_vector): Check it here instead, since this is the only
1864 caller of allocate_vectorlike that could cause overflow.
1865 Check that the new vector's length is representable as a fixnum.
1867 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1868 The previous code was bogus. For example, next_almost_prime (32)
1869 returned 39, which is undesirable as it is a multiple of 3; and
1870 next_almost_prime (24) returned 25, which is a multiple of 5 so
1871 why was the code bothering to check for multiples of 7?
1873 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1875 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1877 Variadic C functions now count arguments with ptrdiff_t.
1878 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1879 Back then I didn't know that the Emacs coding style prefers signed int.
1880 Also, in the meantime I found a few more instances where arguments
1881 were being counted with int, which may truncate counts on 64-bit
1882 machines, or EMACS_INT, which may be unnecessarily wide.
1883 * lisp.h (struct Lisp_Subr.function.aMANY)
1884 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1885 Arg counts are now ptrdiff_t, not size_t.
1886 All variadic functions and their callers changed accordingly.
1887 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1888 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1889 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1890 * callint.c (Fcall_interactively): Check arg count for overflow,
1891 to avoid potential buffer overrun. Use signed char, not 'int',
1892 for 'varies' array, so that we needn't bother to check its size
1893 calculation for overflow.
1894 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1895 * eval.c (apply_lambda):
1896 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1897 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1898 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1900 * callint.c (Fcall_interactively): Don't use index var as event count.
1902 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1903 * mem-limits.h (SIZE): Remove; no longer used.
1905 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1907 Remove unnecessary casts.
1908 * xterm.c (x_term_init):
1909 * xfns.c (x_set_border_pixel):
1910 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1911 These aren't needed now that we assume ANSI C.
1913 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1914 It's more likely to cause problems (due to unsigned overflow)
1917 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1919 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1921 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1923 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1925 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1927 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1929 GLYPH_CODE_FACE returns EMACS_INT, not int.
1930 * dispextern.h (merge_faces):
1931 * xfaces.c (merge_faces):
1932 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1933 Don't assume EMACS_INT fits in int.
1935 * character.h (CHAR_VALID_P): Remove unused parameter.
1936 * fontset.c, lisp.h, xdisp.c: All uses changed.
1938 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1940 * fns.c (concat): Minor tuning based on overflow analysis.
1941 This doesn't fix any bugs. Use int to hold character, instead
1942 of constantly refetching from Emacs object. Use XFASTINT, not
1943 XINT, for value known to be a character. Don't bother comparing
1944 a single byte to 0400, as it's always less.
1946 * floatfns.c (Fexpt):
1947 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1949 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1952 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1954 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1955 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1956 incorrectly succeed when S was a string, because 4294967386 was
1957 truncated before it was used.
1959 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1960 Otherwise, an out-of-range integer could cause undefined behavior
1963 * composite.c: Use int, not EMACS_INT, for characters.
1964 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1965 EMACS_INT, for values that are known to be in character range.
1966 This doesn't fix any bugs but is the usual style inside Emacs and
1967 may generate better code on 32-bit machines.
1969 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1970 This is for reasons similar to the recent CHAR_STRING fix.
1971 * charset.c (Fencode_char): Check that character arg is actually
1972 a character. Pass an int to ENCODE_CHAR.
1973 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1974 wider than 'int', as a compile-time check to prevent future regressions
1977 * character.c (char_string): Remove unnecessary casts.
1979 Make sure a 64-bit char is never passed to CHAR_STRING.
1980 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1981 by silently ignoring the top 32 bits, allowing some values
1982 that were far too large to be valid characters.
1983 * character.h: Include <verify.h>.
1984 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1985 arguments are no wider than unsigned, as a compile-time check
1986 to prevent future regressions in this area.
1988 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1989 (Fsubst_char_in_region):
1991 * xdisp.c (decode_mode_spec_coding):
1992 Adjust to CHAR_STRING's new requirement.
1993 * editfns.c (Finsert_char, Fsubst_char_in_region):
1994 * fns.c (concat): Check that character args are actually
1995 characters. Without this test, these functions did the wrong
1996 thing with wildly out-of-range values on 64-bit hosts.
1998 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1999 These casts should not be needed on 32-bit hosts, either.
2000 * keyboard.c (read_char):
2001 * lread.c (Fload): Remove casts to unsigned.
2003 * lisp.h (UNSIGNED_CMP): New macro.
2004 This fixes comparison bugs on 64-bit hosts.
2005 (ASCII_CHAR_P): Use it.
2006 * casefiddle.c (casify_object):
2007 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2008 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2009 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2010 * dispextern.h (FACE_FROM_ID):
2011 * keyboard.c (read_char): Use UNSIGNED_CMP.
2013 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2014 not to EMACS_INT, to avoid GCC warning.
2016 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2018 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2019 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2020 isn't needed on 32-bit machines.
2022 * buffer.c (Fgenerate_new_buffer_name):
2023 Use EMACS_INT for count, not int.
2024 (advance_to_char_boundary): Return EMACS_INT, not int.
2026 * data.c (Qcompiled_function): Now static.
2028 * window.c (window_body_lines): Now static.
2030 * image.c (gif_load): Rename local to avoid shadowing.
2032 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2033 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2034 * alloc.c (make_save_value): Integer argument is now of type
2036 (mark_object): Use ptrdiff_t, not int.
2037 * lisp.h (pD): New macro.
2038 * print.c (print_object): Use it.
2040 * alloc.c: Use EMACS_INT, not int, to count objects.
2041 (total_conses, total_markers, total_symbols, total_vector_size)
2042 (total_free_conses, total_free_markers, total_free_symbols)
2043 (total_free_floats, total_floats, total_free_intervals)
2044 (total_intervals, total_strings, total_free_strings):
2045 Now EMACS_INT, not int. All uses changed.
2046 (Fgarbage_collect): Compute overall total using a double, so that
2047 integer overflow is less likely to be a problem. Check for overflow
2048 when converting back to an integer.
2049 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2050 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2051 These were 'int' variables that could overflow on 64-bit hosts;
2052 they were never used, so remove them instead of repairing them.
2053 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2054 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2055 Previously, this ceilinged at INT_MAX, but that doesn't work on
2057 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2059 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2060 (allocate_vectorlike): Check for ptrdiff_t overflow.
2061 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2062 when a (possibly-narrower) signed value would do just as well.
2063 We prefer using signed arithmetic, to avoid comparison confusion.
2065 * alloc.c: Catch some string size overflows that we were missing.
2066 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2067 for convenience in STRING_BYTES_MAX.
2068 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2069 The definition here is exact; the one in lisp.h was approximate.
2070 (allocate_string_data): Check for string overflow. This catches
2071 some instances we weren't catching before. Also, it catches
2072 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2073 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2074 and ptrdiff_t and EMACS_INT are both 64 bits.
2076 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2077 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2078 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2080 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2082 * alloc.c (Fmake_string): Check for out-of-range init.
2084 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2086 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2088 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2090 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2091 xg_get_default_scrollbar_width.
2093 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2094 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2095 (style_changed_cb): Call update_theme_scrollbar_width and call
2096 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2097 all frames (Bug#8505).
2098 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2099 Call gtk_window_set_resizable if HAVE_GTK3.
2100 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2101 and height if HAVE_GTK3 (Bug#8505).
2102 (scroll_bar_width_for_theme): New variable.
2103 (update_theme_scrollbar_width): New function.
2104 (xg_get_default_scrollbar_width): Move code to
2105 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2106 (xg_initialize): Call update_theme_scrollbar_width.
2108 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2110 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2112 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2114 * frame.c (make_frame): Call other_buffer_safely instead of
2117 * window.c (temp_output_buffer_show): Call display_buffer with
2118 second argument Vtemp_buffer_show_specifiers and reset latter
2119 immediately after the call.
2120 (Vtemp_buffer_show_specifiers): New variable.
2121 (auto_window_vscroll_p, next_screen_context_lines)
2122 (Vscroll_preserve_screen_position): Remove leading asterisks from
2125 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2127 Fix minor problems found by GCC 4.6.0 static checking.
2128 * buffer.c (Qclone_number): Remove for now, as it's unused.
2129 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2130 (record_buffer): Remove unused local.
2131 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2132 (set_frame_buffer_list): Remove; unused.
2133 * frame.h (other_visible_frames): Remove decl.
2134 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2135 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2136 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2138 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2139 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2140 Define only if HAVE_GPM.
2141 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2142 (update_hints_inhibit): Remove; never set. All uses removed.
2143 * widgetprv.h (emacsFrameClassRec): Remove decl.
2144 * window.c (delete_deletable_window): Now returns void, since it
2145 wasn't returning anything.
2146 (compare_window_configurations): Remove unused locals.
2147 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2148 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2149 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2150 the same widths as pointers. This follows up on the 2011-05-06 patch.
2151 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2152 * xterm.h: Likewise.
2153 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2155 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2157 * makefile.w32-in: Update dependencies.
2158 (LISP_H): Add lib/intprops.h.
2160 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2162 * image.c (gif_load): Add animation frame delay to the metadata.
2163 (syms_of_image): Use DEFSYM. New symbol `delay'.
2165 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2167 * window.c (delete_deletable_window): Re-add.
2168 (Fset_window_configuration): Rewrite to handle dead buffers and
2169 consequently deletable windows.
2170 (window_tree, Fwindow_tree): Remove. Supply functionality in
2172 (compare_window_configurations): Simplify code.
2174 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2176 * image.c (imagemagick_load_image): Fix type mismatch.
2177 (Fimagemagick_types): Likewise.
2179 * window.h (replace_buffer_in_windows): Declare.
2181 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2183 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2184 Qclone_number. Remove external declaration of Qdelete_window.
2185 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2187 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2188 Run Qbuffer_list_update_hook if allowed.
2189 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2190 buffer list implementation.
2191 (other_buffer_safely): New function.
2192 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2193 calls to replace_buffer_in_windows and
2194 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2196 (record_buffer): Inhibit quitting and rewrite using quittable
2197 functions. Run Qbuffer_list_update_hook if allowed.
2198 (Frecord_buffer, Funrecord_buffer): New functions.
2199 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2200 Move switch-to-buffer to window.el.
2201 (bury-buffer): Move to window.el.
2202 (Vbuffer_list_update_hook): New variable.
2204 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2207 * window.h (resize_frame_windows): Move up in code.
2208 (Fwindow_frame): Remove EXFUN.
2209 (replace_buffer_in_all_windows): Remove prototype.
2210 (replace_buffer_in_windows_safely): Add prototype.
2212 * window.c: Declare Qdelete_window static again. Move down
2213 declaration of select_count.
2214 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2215 (Fother_window): Move to window.el.
2216 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2217 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2218 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2220 (replace_buffer_in_windows): Implement by calling
2221 Qreplace_buffer_in_windows.
2222 (replace_buffer_in_all_windows): Remove with some functionality
2223 moved into replace_buffer_in_windows_safely.
2224 (replace_buffer_in_windows_safely): New function.
2225 (select_window_norecord, select_frame_norecord): Move in front
2226 of run_window_configuration_change_hook. Remove now obsolete
2228 (Fset_window_buffer): Rewrite doc-string.
2229 Call Qrecord_window_buffer.
2230 (keys_of_window): Move binding for other-window to window.el.
2232 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2234 * dispextern.h (struct image): Replace data member, whose int_val
2235 and ptr_val fields were not used by anything, with a single
2238 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2239 (gif_clear_image, gif_load, imagemagick_load_image)
2240 (gs_clear_image, gs_load): Callers changed.
2242 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2244 * buffer.h: Include <time.h>, for time_t.
2245 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2247 Fix minor problems found by static checking.
2249 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2251 Make identifiers static if they are not used in other modules.
2252 * data.c (Qcompiled_function, Qframe, Qvector):
2253 * image.c (QimageMagick, Qsvg):
2254 * minibuf.c (Qmetadata):
2255 * window.c (resize_window_check, resize_root_window): Now static.
2256 * window.h (resize_window_check, resize_root_window): Remove decls.
2258 * window.c (window_deletion_count, delete_deletable_window):
2260 (window_body_lines): Now static.
2261 (Fdelete_other_windows_internal): Mark vars as initialized.
2262 Make sure 'resize_failed' is initialized.
2263 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2264 (resize_window_apply): Remove unused local.
2265 * window.h (delete_deletable_window): Remove decl.
2267 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2268 (imagemagick_load_image): Fix pointer signedness problem by changing
2269 last arg from unsigned char * to char *. All uses changed.
2270 Also, fix a local for similar reasons.
2271 Remove unused locals. Remove locals to avoid shadowing.
2272 (fn_rsvg_handle_free): Remove; unused.
2273 (svg_load, svg_load_image): Fix pointer signedness problem.
2274 (imagemagick_load_image): Don't use garbage pointer image_wand.
2276 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2278 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2280 * image.c (gif_load): Fix omitted cast error introduced by
2283 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2285 * window.h (resize_proportionally, orig_total_lines)
2286 (orig_top_line): Remove from window structure.
2287 (set_window_height, set_window_width, change_window_heights)
2288 (Fdelete_window): Remove prototypes.
2289 (resize_frame_windows): Remove duplicate declaration.
2291 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2293 * window.h (resize_frame_windows, resize_window_check)
2294 (delete_deletable_window, resize_root_window)
2295 (resize_frame_windows): Declare prototypes.
2297 * window.c (resize_window_apply): Make definition be "static" to
2298 match the prototype.
2300 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2302 * window.c: Remove declarations of Qwindow_size_fixed,
2303 window_min_size_1, window_min_size_2, window_min_size,
2304 size_window, window_fixed_size_p, enlarge_window, delete_window.
2305 Remove static from declaration of Qdelete_window, it's
2306 temporarily needed by Fbury_buffer.
2307 (replace_window): Don't assign orig_top_line and
2309 (Fdelete_window, delete_window): Remove. Window deletion is
2310 handled by window.el.
2311 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2312 Replace Fdelete_window calls with calls to Qdelete_window.
2313 (Fdelete_other_windows): Remove. Deleting other windows is
2314 handled by window.el.
2315 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2316 handled in window.el.
2317 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2318 Window minimum sizes are handled in window.el.
2319 (shrink_windows, size_window, set_window_height)
2320 (set_window_width, change_window_heights, window_height)
2321 (window_width, CURBEG, CURSIZE, enlarge_window)
2322 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2323 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2324 handled in window.el.
2325 (make_dummy_parent): Rename to make_parent_window and give it a
2326 second argument horflag.
2327 (make_window): Don't set resize_proportionally any more.
2328 (Fsplit_window): Remove. Windows are split in window.el.
2329 (save_restore_action, save_restore_orig_size)
2330 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2331 Resize mini windows in window.el.
2332 (grow_mini_window, shrink_mini_window): Implement by calling
2333 Qresize_root_window_vertically, resize_window_check and
2334 resize_window_apply.
2335 (saved_window, Fset_window_configuration, save_window_save):
2336 Do not handle orig_top_line, orig_total_lines, and
2337 resize_proportionally.
2338 (window_min_height, window_min_width): Move to window.el.
2339 (keys_of_window): Move bindings for delete-other-windows,
2340 split-window, delete-window and enlarge-window to window.el.
2342 * buffer.c: Temporarily extern Qdelete_window.
2343 (Fbury_buffer): Temporarily call Qdelete_window instead of
2344 Fdelete_window (Fbury_buffer will move to window.el soon).
2346 * frame.c (set_menu_bar_lines_1): Remove code handling
2347 orig_top_line and orig_total_lines.
2349 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2350 set_window_height but set heights directly.
2351 (change_frame_size_1): Use resize_frame_windows.
2353 * xdisp.c (init_xdisp): Don't use set_window_height but set
2356 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2357 Use resize_frame_windows instead of change_window_heights and run
2358 run_window_configuration_change_hook.
2360 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2361 instead of change_window_heights and run
2362 run_window_configuration_change_hook.
2364 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2366 * window.c (replace_window): Rename second argument REPLACEMENT to
2367 NEW. New third argument SETFLAG. Rewrite.
2368 (delete_window, make_dummy_parent): Call replace_window with
2370 (window_list_1): Move down in code.
2371 (run_window_configuration_change_hook): Move set_buffer part
2372 before select_frame_norecord part in order to unwind correctly.
2373 Rename count1 to count.
2374 (recombine_windows, delete_deletable_window, resize_root_window)
2375 (Fdelete_other_windows_internal)
2376 (Frun_window_configuration_change_hook, make_parent_window)
2377 (resize_window_check, resize_window_apply, Fresize_window_apply)
2378 (resize_frame_windows, Fsplit_window_internal)
2379 (Fdelete_window_internal, Fresize_mini_window_internal):
2381 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2383 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2385 * window.h (window): Add some new members to window structure -
2386 normal_lines, normal_cols, new_total, new_normal, clone_number,
2387 splits, nest, prev_buffers, next_buffers.
2388 (WINDOW_TOTAL_SIZE): Move here from window.c.
2389 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2391 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2393 (make_dummy_parent): Set new members of windows structure.
2394 (make_window): Move down in code. Handle new members of window
2396 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2397 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2398 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2399 (Fset_window_prev_buffers, Fwindow_next_buffers)
2400 (Fset_window_next_buffers, Fset_window_clone_number):
2402 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2403 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2405 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2406 Argument WINDOW can be now internal window too.
2407 (Fwindow_use_time): Move up in code.
2408 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2410 (Fset_window_configuration, saved_window)
2411 (Fcurrent_window_configuration, save_window_save): Handle new
2412 members of window structure.
2413 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2414 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2415 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2416 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2417 Qget_mru_window, Qresize_root_window,
2418 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2419 Qauto_buffer_name; staticpro them.
2421 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2423 * window.c (Fwindow_total_size, Fwindow_left_column)
2424 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2425 (Fwindow_list_1): New functions.
2426 (window_box_text_cols): Replace with window_body_cols.
2427 (Fwindow_width, Fscroll_left, Fscroll_right):
2428 Use window_body_cols instead of window_box_text_cols.
2429 (delete_window, Fset_window_configuration):
2430 Call delete_all_subwindows with window as argument.
2431 (delete_all_subwindows): Take a window as argument and not a
2433 (window_loop): Remove handling of GET_LRU_WINDOW and
2435 (Fget_lru_window, Fget_largest_window): Move to window.el.
2437 * window.h: Extern window_body_cols instead of
2438 window_box_text_cols. delete_all_subwindows now takes a
2439 Lisp_Object as argument.
2441 * indent.c (compute_motion, Fcompute_motion):
2442 Use window_body_cols instead of window_box_text_cols.
2444 * frame.c (delete_frame): Call delete_all_subwindows with root
2447 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2449 * fns.c (Fputhash): Document return value.
2451 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2453 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2455 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2457 Cons<->int and similar integer overflow fixes (Bug#8794).
2459 Check for overflow when converting integer to cons and back.
2460 * charset.c (Fdefine_charset_internal, Fdecode_char):
2461 Use cons_to_unsigned to catch overflow.
2462 (Fencode_char): Use INTEGER_TO_CONS.
2463 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2464 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2465 * data.c (long_to_cons, cons_to_long): Remove.
2466 (cons_to_unsigned, cons_to_signed): New functions.
2467 These signal an error for invalid or out-of-range values.
2468 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2469 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2470 * font.c (Ffont_variation_glyphs):
2471 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2472 * lisp.h: Include <intprops.h>.
2473 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2474 (cons_to_signed, cons_to_unsigned): New decls.
2475 (long_to_cons, cons_to_long): Remove decls.
2476 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2477 (Fprimitive_undo): Use CONS_TO_INTEGER.
2478 * xfns.c (Fx_window_property): Likewise.
2479 * xselect.c: Include <limits.h>.
2480 (x_own_selection, selection_data_to_lisp_data):
2481 Use INTEGER_TO_CONS.
2482 (x_handle_selection_request, x_handle_selection_clear)
2483 (x_get_foreign_selection, Fx_disown_selection_internal)
2484 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2485 (lisp_data_to_selection_data): Use cons_to_unsigned.
2486 (x_fill_property_data): Use cons_to_signed.
2487 Report values out of range.
2489 Check for buffer and string overflow more precisely.
2490 * buffer.h (BUF_BYTES_MAX): New macro.
2491 * lisp.h (STRING_BYTES_MAX): New macro.
2492 * alloc.c (Fmake_string):
2493 * character.c (string_escape_byte8):
2494 * coding.c (coding_alloc_by_realloc):
2495 * doprnt.c (doprnt):
2496 * editfns.c (Fformat):
2498 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2499 since they may not be the same number.
2500 * editfns.c (Finsert_char):
2501 * fileio.c (Finsert_file_contents):
2502 Likewise for BUF_BYTES_MAX.
2504 * image.c: Use ptrdiff_t, not int, for sizes.
2505 (slurp_file): Switch from int to ptrdiff_t.
2507 (slurp_file): Check that file size fits in both size_t (for
2508 malloc) and ptrdiff_t (for sanity and safety).
2510 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2511 if b->modtime has its maximal value.
2513 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2515 Don't assume time_t can fit into int.
2516 * buffer.h (struct buffer.modtime): Now time_t, not int.
2517 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2518 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2520 Minor fixes for signed vs unsigned integers.
2521 * character.h (MAYBE_UNIFY_CHAR):
2522 * charset.c (maybe_unify_char):
2523 * keyboard.c (read_char, reorder_modifiers):
2524 XINT -> XFASTINT, since the integer must be nonnegative.
2525 * ftfont.c (ftfont_spec_pattern):
2526 * keymap.c (access_keymap, silly_event_symbol_error):
2527 XUINT -> XFASTINT, since the integer must be nonnegative.
2528 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2529 since it makes no difference and we prefer signed.
2530 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2531 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2534 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2536 * window.h (Fwindow_frame): Declare.
2538 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2540 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2541 (SPARE_MEMORY): Always define.
2542 (LARGE_REQUEST): Remove.
2543 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2545 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2547 * lisp.h: Move EXFUNS for Fframe_root_window,
2548 Fframe_first_window and Fset_frame_selected_window to window.h.
2550 * window.h: Move EXFUNS for Fframe_root_window,
2551 Fframe_first_window and Fset_frame_selected_window here from
2554 * frame.c (Fwindow_frame, Fframe_first_window)
2555 (Fframe_root_window, Fframe_selected_window)
2556 (Fset_frame_selected_window): Move to window.c.
2557 (Factive_minibuffer_window): Move to minibuf.c.
2558 (Fother_visible_frames_p): New function.
2560 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2562 * window.c (decode_window, decode_any_window): Move up in code.
2563 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2564 (inhibit_frame_unsplittable): Remove unused variable.
2565 (Fwindow_buffer): Move up and rewrite doc-string.
2566 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2567 (Fwindow_prev): New functions.
2568 (Fwindow_frame): Move here from frame.c. Accept any window as
2570 (Fframe_root_window, Fframe_first_window)
2571 (Fframe_selected_window): Move here from frame.c. Accept frame
2572 or arbitrary window as argument. Update doc-strings.
2573 (Fminibuffer_window): Move up in code.
2574 (Fwindow_minibuffer_p): Move up in code and simplify.
2575 (Fset_frame_selected_window): Move here from frame.c.
2577 (Fselected_window, select_window, Fselect_window): Move up in
2578 code. Minor doc-string fixes.
2580 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2582 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2583 Do not assume that spare memory exists; that assumption is valid
2584 only if SYSTEM_MALLOC.
2585 (LARGE_REQUEST): New macro, so that the issue of large requests
2586 is separated from the issue of spare memory.
2588 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2590 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2593 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2595 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2598 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2600 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2602 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2604 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2605 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2607 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2609 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2611 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2613 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2614 (x_clipboard_manager_save): Add return value.
2615 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2617 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2618 Obey Vx_select_enable_clipboard_manager. Catch errors in
2619 x_clipboard_manager_save (Bug#8779).
2620 (Vx_select_enable_clipboard_manager): New variable.
2621 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2623 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2625 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2627 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2629 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2630 in the current matrix if keep_current_p is non-zero.
2632 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2634 * bidi.c (bidi_level_of_next_char): Fix last change.
2636 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2638 Support bidi reordering of text covered by display properties.
2640 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2641 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2642 (bidi_cache_search, bidi_cache_iterator_state)
2643 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2644 (bidi_level_of_next_char, bidi_move_to_visually_next):
2645 Support character positions inside a run of characters covered by a
2647 (bidi_paragraph_init, bidi_resolve_explicit_1)
2648 (bidi_level_of_next_char): Call bidi_fetch_char and
2649 bidi_fetch_char_advance instead of FETCH_CHAR and
2651 (bidi_init_it): Initialize new members.
2652 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2654 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2655 instead of using explicit *_CHAR codes.
2656 (bidi_resolve_explicit, bidi_resolve_weak):
2657 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2658 bidirectional text is supported only in multibyte buffers.
2659 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2660 it to initialize the frame_window_p member of struct bidi_it.
2661 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2662 (bidi_resolve_explicit, bidi_resolve_weak)
2663 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2664 bidi_it->nchars is non-positive.
2665 (bidi_level_of_next_char): Don't try to lookup the cache for the
2666 next/previous character if nothing is cached there yet, or if we
2667 were just reseat()'ed to a new position.
2669 * xdisp.c (set_cursor_from_row): Set start and stop points
2670 according to the row's direction when priming the loop that looks
2671 for the glyph on which to display cursor.
2672 (single_display_spec_intangible_p): Function deleted.
2673 (display_prop_intangible_p): Reimplement to call
2674 handle_display_spec instead of single_display_spec_intangible_p.
2675 Accept 3 additional arguments needed by handle_display_spec.
2676 This fixes incorrect cursor motion across display property with complex
2677 values: lists, `(when COND...)' forms, etc.
2678 (single_display_spec_string_p): Support property values that are
2679 lists with the argument STRING its top-level element.
2680 (display_prop_string_p): Fix the condition for processing a
2681 property that is a list to be consistent with handle_display_spec.
2682 (handle_display_spec): New function, refactored from the
2683 last portion of handle_display_prop.
2684 (compute_display_string_pos): Accept additional argument
2685 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2686 value of a `display' property is a "replacing spec".
2687 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2688 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2689 the display property, but just return a value indicating whether
2690 the display property will replace the characters it covers.
2691 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2692 frame_window_p members of struct bidi_it.
2693 (compute_display_string_pos, compute_display_string_end):
2695 (push_it): Accept second argument POSITION, where pop_it should
2696 jump to continue iteration.
2697 (reseat_1): Initialize bidi_it.disp_pos.
2699 * keyboard.c (adjust_point_for_property): Adjust the call to
2700 display_prop_intangible_p to its new signature.
2702 * dispextern.h (struct bidi_it): New member frame_window_p.
2703 (bidi_init_it): Update prototypes.
2704 (display_prop_intangible_p): Update prototype.
2705 (compute_display_string_pos, compute_display_string_end):
2707 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2710 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2712 Malloc failure behavior now depends on size of allocation.
2713 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2714 * lisp.h: Change signatures accordingly.
2715 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2716 All callers changed. (Bug#8762)
2718 * gnutls.c: Use Emacs's memory allocators.
2719 Without this change, the gnutls library would invoke malloc etc.
2720 directly, which causes problems on non-SYNC_INPUT hosts, and which
2721 runs afoul of improving memory_full behavior. (Bug#8761)
2722 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2723 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2724 xfree instead of the default malloc, realloc, free.
2725 (Fgnutls_boot): No need to check for memory allocation failure,
2726 since xmalloc does that for us.
2728 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2729 * category.c (hash_get_category_set):
2730 * ccl.c (ccl_driver):
2731 * charset.c (Fdefine_charset_internal):
2732 * charset.h (struct charset.hash_index):
2733 * composite.c (get_composition_id, gstring_lookup_cache)
2734 (composition_gstring_put_cache):
2735 * composite.h (struct composition.hash_index):
2736 * dispextern.h (struct image.hash):
2737 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2738 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2739 (hashfn_equal, hashfn_user_defined, make_hash_table)
2740 (maybe_resize_hash_table, hash_lookup, hash_put)
2741 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2742 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2743 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2744 * image.c (make_image, search_image_cache, lookup_image)
2745 (xpm_put_color_table_h):
2746 * lisp.h (struct Lisp_Hash_Table):
2747 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2748 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2749 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2750 * alloc.c (allocate_vectorlike):
2751 Check for overflow in vector size calculations.
2752 * ccl.c (ccl_driver):
2753 Check for overflow when converting EMACS_INT to int.
2754 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2755 need to be updated by these changes.
2756 * fns.c (make_hash_table, maybe_resize_hash_table):
2757 Check for integer overflow with large hash tables.
2758 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2759 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2760 (SXHASH_REDUCE): New macro.
2761 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2762 Use it instead of discarding useful hash info with large hash values.
2763 (sxhash_float): New function.
2764 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2765 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2766 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2767 Rewrite to use FIXNUM_BITS, as this simplifies things.
2768 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2769 Adjust signatures to match updated version of code.
2770 (consing_since_gc): Now EMACS_INT, since a single hash table can
2771 use more than INT_MAX bytes.
2773 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2775 Make it possible to build with GCC-4.6+ -O2 -flto.
2777 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2779 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2781 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2782 Call minibuffer-inactive-mode.
2784 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2786 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2787 Update dependencies.
2789 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2791 * data.c (init_data): Remove code for UTS, this system is not
2794 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2796 Don't force ./temacs to start in terminal mode.
2798 * frame.c (make_initial_frame): Initialize faces in all cases, not
2799 only when CANNOT_DUMP is defined.
2800 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2802 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2804 * dispnew.c (add_window_display_history): Use const for the string
2805 pointer. Remove declaration, not needed.
2807 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2809 Use 'inline', not 'INLINE'.
2810 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2811 * alloc.c, fontset.c (INLINE): Remove.
2812 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2813 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2814 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2815 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2816 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2818 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2820 Make it possible to run ./temacs.
2822 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2823 syms_of_callproc does the same thing. Remove test for
2824 "initialized", do it in the caller.
2825 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2827 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2829 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2830 (read_minibuf): Use get_minibuffer.
2831 (syms_of_minibuf): Use DEFSYM.
2832 (Qmetadata): New var.
2833 * data.c (Qbuffer): Don't make it static.
2834 (syms_of_data): Use DEFSYM.
2836 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2838 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2839 (CCL_CODE_MIN): New macro.
2841 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2843 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2845 * eval.c (Qdebug): Now static.
2846 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2847 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2848 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2850 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2852 * image.c: Various fixes to ImageMagick code comments.
2853 (Fimagemagick_types): Doc fix.
2855 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2857 Minor fixes prompted by GCC 4.6.0 warnings.
2859 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2861 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2862 (x_clipboard_manager_save_all): Move extern decl to ...
2863 * xterm.h: ... here, so that it can be checked for consistency.
2865 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2867 * xselect.c (x_clipboard_manager_save_frame)
2868 (x_clipboard_manager_save_all): New functions.
2869 (Fx_clipboard_manager_save): Lisp function deleted.
2871 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2872 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2874 * xterm.h: Update prototype.
2876 2011-05-28 William Xu <william.xwl@gmail.com>
2878 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2881 2011-05-28 Jim Meyering <meyering@redhat.com>
2883 Avoid a sign-extension bug in crypto_hash_function.
2884 * fns.c (to_uchar): Define.
2885 (crypto_hash_function): Use it to convert some newly-signed
2886 variables to unsigned, to avoid sign-extension bugs. For example,
2887 without this change, (md5 "truc") would evaluate to
2888 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2889 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2890 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2892 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2894 Integer overflow fixes.
2896 * dbusbind.c: Serial number integer overflow fixes.
2897 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2898 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2899 to hold a serial number that is too large for a fixnum.
2900 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2901 Check for serial numbers out of range. Decode any serial number
2902 that was so large that it became a float. (Bug#8722)
2904 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2905 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2906 Use XFASTINT rather than XUINT when numbers are nonnegative.
2907 (xd_append_arg, Fdbus_method_return_internal):
2908 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2909 arguments, check that Lisp number is nonnegative, rather than
2910 silently wrapping negative numbers around. (Bug#8722)
2911 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2914 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2916 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2918 ccl: add integer overflow checks
2919 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2920 (IN_INT_RANGE): New macros.
2921 (ccl_driver): Use them to check for integer overflow when
2922 decoding a CCL program. Many of the new checks are whether XINT (x)
2923 fits in int; it doesn't always, on 64-bit hosts. The new version
2924 doesn't catch all possible integer overflows, but it's an
2925 improvement. (Bug#8719)
2927 * alloc.c (make_event_array): Use XINT, not XUINT.
2928 There's no need for unsigned here.
2930 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2931 This follows up to the 2011-05-06 change that substituted uintptr_t
2932 for EMACS_INT. This case wasn't caught back then.
2934 Rework Fformat to avoid integer overflow issues.
2935 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2936 now (part of C89). Include <verify.h>.
2937 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2938 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2939 (Fformat): Avoid the prepass trying to compute sizes; it was only
2940 approximate and thus did not catch overflow reliably. Instead, walk
2941 through the format just once, formatting and computing sizes as we go,
2942 checking for integer overflow at every step, and allocating a larger
2943 buffer as needed. Keep track separately whether the format is
2944 multibyte. Keep only the most-recently calculated precision, rather
2945 than them all. Record whether each argument has been converted to
2946 string. Use EMACS_INT, not int, for byte and char and arg counts.
2947 Support field widths and precisions larger than INT_MAX. Avoid
2948 sprintf's undefined behavior with conversion specifications such as %#d
2949 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2950 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2951 formatting out-of-range floating point numbers with int
2954 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2956 * data.c: Avoid integer truncation in expressions involving floats.
2957 * data.c: Include <intprops.h>.
2958 (arith_driver): When there's an integer overflow in an expression
2959 involving floating point, convert the integers to floating point
2960 so that the resulting value does not suffer from catastrophic
2961 integer truncation. For example, on a 64-bit host (* 4
2962 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2963 Do not rely on undefined behavior after integer overflow.
2965 merge count_size_as_multibyte, parse_str_to_multibyte
2966 * character.c, character.h (count_size_as_multibyte):
2967 Rename from parse_str_to_multibyte; all uses changed.
2968 Check for integer overflow.
2969 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2970 since it's now a duplicate of the other. This is more of
2971 a character than a buffer op, so better that it's in character.c.
2972 * fns.c, print.c: Adjust to above changes.
2974 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2976 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2978 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2980 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2981 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2982 (x_clipboard_manager_save): Now static.
2983 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2985 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2986 (crypto_hash_function): Now static.
2987 Fix pointer signedness problems. Avoid unnecessary initializations.
2989 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2991 * termhooks.h (Vselection_alist): Make it terminal-local.
2993 * terminal.c (create_terminal): Initialize it.
2995 * xselect.c: Support for clipboard managers.
2996 (Vselection_alist): Move to termhooks.h as terminal-local var.
2997 (LOCAL_SELECTION): New macro.
2998 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2999 (symbol_to_x_atom): Remove gratuitous arg.
3000 (x_handle_selection_request, lisp_data_to_selection_data)
3001 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3002 (x_own_selection, x_get_local_selection, x_convert_selection):
3003 New arg, specifying work frame. Use terminal-local Vselection_alist.
3004 (some_frame_on_display): Delete unused function.
3005 (Fx_own_selection_internal, Fx_get_selection_internal)
3006 (Fx_disown_selection_internal, Fx_selection_owner_p)
3007 (Fx_selection_exists_p): New optional frame arg.
3008 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3009 (x_handle_selection_clear): Don't treat other terminals with the
3010 same keyboard specially. Use the terminal-local Vselection_alist.
3011 (x_clear_frame_selections): Use Frun_hook_with_args.
3013 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3015 * xterm.h: Add support for those atoms.
3017 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3019 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3020 (converted_selections, conversion_fail_tag): New global variables.
3021 (x_selection_request_lisp_error): Free the above.
3022 (x_get_local_selection): Remove unnecessary code.
3023 (x_reply_selection_request): Args changed; handle arbitrary array
3024 of converted selections stored in converted_selections.
3025 Separate the XChangeProperty and SelectionNotify steps.
3026 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3027 (x_convert_selection): New function.
3028 (x_handle_selection_event): Simplify.
3029 (x_get_foreign_selection): Don't ignore incoming requests while
3030 waiting for an answer; this will fail when we implement
3031 SAVE_TARGETS, and seems unnecessary anyway.
3032 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3033 (Vx_sent_selection_functions): Doc fix.
3035 2011-05-26 Leo Liu <sdl.web@gmail.com>
3037 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3039 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3041 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3043 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3044 for fringe update if it has periodic bitmap.
3045 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3046 and fringe_bitmap_periodic_p.
3048 * fringe.c (get_fringe_bitmap_data): New function.
3049 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3050 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3051 row. Mark glyph row for fringe update if periodicity changed.
3053 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3054 for fringe update unless it has periodic bitmap.
3056 2011-05-25 Kenichi Handa <handa@m17n.org>
3058 * xdisp.c (get_next_display_element): Set correct it->face_id for
3059 a static composition.
3061 2011-05-24 Leo Liu <sdl.web@gmail.com>
3064 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3066 * fns.c (crypto_hash_function, Fsha1): New function.
3067 (Fmd5): Use crypto_hash_function.
3068 (syms_of_fns): Add Ssha1.
3070 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3072 * gnutls.c: Remove unused macros.
3073 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3074 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3075 Remove macros that are defined and never used.
3076 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3078 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3080 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3081 (Fx_get_selection_internal): Minor cleanup.
3082 (Fx_own_selection_internal): Rename arguments for consistency with
3085 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3087 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3089 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3091 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3093 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3095 * dispnew.c (scrolling_window): Don't exclude the case that the
3096 last enabled row in the desired matrix touches the bottom boundary.
3098 2011-05-21 Glenn Morris <rgm@gnu.org>
3100 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3101 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3102 and add some more files.
3104 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3106 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3107 report_file_error introduced by the change from 2011-05-07.
3109 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3111 * systime.h (Time): Define only if emacs is defined.
3112 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3113 where the include path doesn't have X11/X.h by default. See
3114 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3116 2011-05-20 Kenichi Handa <handa@m17n.org>
3118 * composite.c (find_automatic_composition): Fix previous change.
3120 2011-05-20 Glenn Morris <rgm@gnu.org>
3122 * lisp.mk: New file, split from Makefile.in.
3123 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3124 (shortlisp): Remove.
3125 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3127 2011-05-19 Glenn Morris <rgm@gnu.org>
3129 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3130 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3131 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3132 (lisp): Set the order to that of loadup.el.
3133 (shortlisp): Make it a copy of $lisp.
3134 (SOME_MACHINE_LISP): Remove.
3135 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3136 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3138 2011-05-18 Kenichi Handa <handa@m17n.org>
3140 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3141 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3142 (find_automatic_composition): Mostly rewrite for efficiency.
3144 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3146 * makefile.w32-in: Update dependencies.
3148 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3150 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3151 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3153 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3155 Fix some integer overflow issues, such as string length overflow.
3157 * insdel.c (count_size_as_multibyte): Check for string overflow.
3159 * character.c (lisp_string_width): Check for string overflow.
3160 Use EMACS_INT, not int, for string indexes and lengths; in
3161 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3162 the resulting string length overflows an EMACS_INT; instead,
3163 report a string overflow if no precision given. When checking for
3164 precision exhaustion, use a check that cannot possibly have
3165 integer overflow. (Bug#8675)
3166 * character.h (lisp_string_width): Adjust to new signature.
3168 * alloc.c (string_overflow): New function.
3169 (Fmake_string): Use it. This doesn't change behavior, but saves
3170 a few bytes and will simplify future changes.
3171 * character.c (string_escape_byte8): Likewise.
3172 * lisp.h (string_overflow): New decl.
3174 Fixups, following up to the user-interface timestamp change.
3175 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3176 for UI timestamps, instead of unsigned long.
3177 * msdos.c (mouse_get_pos): Likewise.
3178 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3179 * w32gui.h (Time): Define by including "systime.h" rather than by
3180 declaring it ourselves. (Bug#8664)
3182 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3183 * image.c (clear_image_cache): Likewise.
3185 * term.c (term_mouse_position): Don't assume time_t wraparound.
3187 Be more systematic about user-interface timestamps.
3188 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3189 and sometimes 'EMACS_UINT', to represent these timestamps.
3190 This change causes it to use 'Time' uniformly, as that's what X uses.
3191 This makes the code easier to follow, and makes it easier to catch
3192 integer overflow bugs such as Bug#8664.
3193 * frame.c (Fmouse_position, Fmouse_pixel_position):
3194 Use Time, not unsigned long, for user-interface timestamps.
3195 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3196 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3197 * keyboard.h (last_event_timestamp): Likewise.
3198 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3199 * menu.h (xmenu_show): Likewise.
3200 * term.c (term_mouse_position): Likewise.
3201 * termhooks.h (struct input_event.timestamp): Likewise.
3202 (struct terminal.mouse_position_hook): Likewise.
3203 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3204 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3205 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3206 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3208 * menu.h, termhooks.h: Include "systime.h", for Time.
3210 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3211 Don't assume that the difference between two unsigned long values
3212 can fit into an integer. At this point, we know button_down_time
3213 <= event->timestamp, so the difference must be nonnegative, so
3214 there's no need to cast the result if double-click-time is
3215 nonnegative, as it should be; check that it's nonnegative, just in
3216 case. This bug is triggered when events are more than 2**31 ms
3217 apart (about 25 days). (Bug#8664)
3219 * xselect.c (last_event_timestamp): Remove duplicate decl.
3220 (x_own_selection): Remove needless cast to unsigned long.
3222 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3223 that always fit in int. Use a sentinel instead of a counter, to
3224 avoid a temp and to allay GCC's concerns about possible int overflow.
3225 * frame.h (struct frame): Use int for menu_bar_items_used
3226 instead of EMACS_INT, since it always fits in int.
3228 * menu.c (grow_menu_items): Check for int overflow.
3230 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3232 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3233 Before, the code was not consistent. These values cannot exceed
3234 2**31 - 1 so there's no need to make them unsigned.
3235 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3236 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3237 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3239 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3241 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3242 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3243 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3244 presumably because the widths might not match.
3246 * window.c (size_window): Avoid needless test at loop start.
3248 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3250 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3252 2011-05-12 Drew Adams <drew.adams@oracle.com>
3254 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3256 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3258 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3259 `width' to `bar_area_x' and `bar_area_width', respectively.
3260 (x_scroll_run): Take account of fringe background extension.
3262 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3263 Rename local vars `left' and `width' to `bar_area_x' and
3264 `bar_area_width', respectively.
3265 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3266 background extension.
3268 2011-05-10 Jim Meyering <meyering@redhat.com>
3270 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3272 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3274 * image.c (Finit_image_library): Return t for built-in image types,
3275 like pbm and xbm. (Bug#8640)
3277 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3279 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3281 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3283 * w32console.c (Fset_screen_color): Doc fix.
3284 (Fget_screen_color): New function.
3285 (syms_of_ntterm): Defsubr it.
3287 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3288 unlink the temporary file if Fcall_process didn't create it in the
3290 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3291 child process will be redirected to a file specified with `:file'.
3292 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3293 cue to call_process_cleanup not to close that handle.
3295 2011-05-07 Ben Key <bkey76@gmail.com>
3297 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3298 one of two shell specific rules, either bootstrap-temacs-CMD or
3299 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3300 to the previous implementation of the bootstrap-temacs rule.
3301 The bootstrap-temacs-CMD rule is similar to the previous
3302 implementation of the bootstrap-temacs rule except that it
3303 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3306 These changes, along with some changes to nt/configure.bat,
3307 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3308 earlier fix to add support for --cflags and --ldflags options
3309 that include quotes so that it works whether make uses cmd or
3312 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3314 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3315 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3317 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3318 a string. Handle both cases.
3319 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3320 (Fdbus_register_method): Use Qinvalid_function.
3322 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3324 * makefile.w32-in: Update dependencies.
3325 (LISP_H): Add inttypes.h and stdin.h.
3326 (PROCESS_H): Add unistd.h.
3328 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3330 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3331 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3333 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3335 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3337 * term.c (vfatal): Remove stray call to va_end.
3338 It's not needed and the C Standard doesn't allow it here anyway.
3340 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3341 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3343 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3346 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3348 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3350 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3352 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3354 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3356 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3357 * charset.c (Fdefine_charset_internal): Don't initialize
3358 charset.code_space[15]. The value was garbage, on hosts with
3359 32-bit int (Bug#8600).
3361 * lread.c (read_integer): Be more consistent with string-to-number.
3362 Use string_to_number to do the actual conversion; this avoids
3363 rounding errors and fixes some other screwups. Without this fix,
3364 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3365 (digit_to_number): Move earlier, for benefit of read_integer.
3366 Return -1 if the digit is out of range for the base, -2 if it is
3367 not a digit in any supported base. (Bug#8602)
3369 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3371 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3372 to match comment at start of function. This also removes a
3373 GCC warning about overflow in a 32+64-bit port.
3375 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3377 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3378 Reported by Stefan Monnier in
3379 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3380 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3381 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3383 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3384 (EMACS_UINTPTR): Likewise, with uintptr_t.
3386 * lisp.h: Prefer 64-bit EMACS_INT if available.
3387 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3388 on 32-bit hosts that have 64-bit int, so that they can access
3390 However, temporarily disable this change unless the temporary
3391 symbol WIDE_EMACS_INT is defined.
3393 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3395 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3396 This removes an assumption that EMACS_INT and long are the same
3397 width as pointers. The assumption is true for Emacs porting targets
3398 now, but we want to make other targets possible.
3399 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3400 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3401 In the rest of the code, change types of integers that hold casted
3402 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3403 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3404 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3405 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3406 No need to cast type when ORing.
3407 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3408 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3409 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3410 assume EMACS_INT is the same width as char *.
3411 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3412 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3413 Remove no-longer-needed casts.
3414 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3415 (xg_tool_bar_help_callback, xg_make_tool_item):
3416 Use EMACS_INTPTR to hold an integer
3417 that will be cast to void *; this can avoid a GCC warning
3418 if EMACS_INT is not the same width as void *.
3419 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3420 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3421 (current_message_1, set_message_1):
3422 Use a local to convert to proper width without a cast.
3423 * xmenu.c (dialog_selection_callback): Likewise.
3425 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3426 Also, don't assume VALBITS / RAND_BITS is less than 5,
3427 and don't rely on undefined behavior when shifting a 1 left into
3429 * lisp.h (get_random): Change signature to match.
3431 * lread.c (hash_string): Use size_t, not int, for hash computation.
3432 Normally we prefer signed values; but hashing is special, because
3433 it's better to use unsigned division on hash table sizes so that
3434 the remainder is nonnegative. Also, size_t is the natural width
3435 for hashing into memory. The previous code used 'int', which doesn't
3436 retain enough info to hash well into very large tables.
3437 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3439 * dbusbind.c: Don't possibly lose pointer info when converting.
3440 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3441 Use XPNTR rather than XHASH, so that the high-order bits of
3442 the pointer aren't lost when converting through void *.
3444 * eval.c (Fautoload): Don't double-shift a pointer.
3446 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3448 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3450 * gnutls.c (DEF_GNUTLS_FN):
3451 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3453 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3455 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3458 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3460 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3461 New version that can reserve upto 2GB of heap space.
3463 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3465 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3467 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3469 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3470 `gnutls_certificate_set_x509_key_file'.
3472 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3474 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3475 Update dependencies.
3477 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3479 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3480 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3481 Remove unused parameter `fildes'.
3482 * process.c (read_process_output, send_process): Don't pass it.
3484 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3486 Fix previous change: the library cache is defined in w32.c.
3487 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3488 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3490 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3492 Implement dynamic loading of GnuTLS on Windows.
3494 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3495 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3496 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3499 * gnutls.c (Qgnutls_dll): Define.
3500 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3501 (gnutls_*): Declare function pointers.
3502 (init_gnutls_functions): New function to initialize function pointers.
3503 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3504 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3505 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3506 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3507 (emacs_gnutls_write, emacs_gnutls_read)
3508 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3509 (Fgnutls_available_p): New function.
3510 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3511 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3512 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3514 * image.c: Include w32.h.
3515 (Vimage_type_cache): Delete.
3516 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3517 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3518 (w32_delayed_load): Move to w32.c.
3520 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3522 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3523 (w32_delayed_load): Move from image.c. When loading a library, record
3524 its filename in the :loaded-from property of the library id.
3525 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3526 Initialize and staticpro them.
3527 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3529 * process.c: Include lisp.h before w32.h, not after.
3530 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3531 instead of gnutls_record_check_pending.
3533 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3535 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3537 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3538 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3541 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3543 * xterm.c (x_set_frame_alpha): Do not set property on anything
3544 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3546 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3548 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3550 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3552 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3553 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3554 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3555 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3556 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3557 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3558 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3559 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3560 (Qgnutls_bootprop_callbacks_verify): Make static.
3562 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3564 * callproc.c: Indentation fixup.
3566 * sysdep.c (wait_for_termination_1): Make static.
3567 (wait_for_termination, interruptible_wait_for_termination):
3568 Move after wait_for_termination_1.
3570 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3572 * sysdep.c (interruptible_wait_for_termination): New function
3573 which is like wait_for_termination, but allows keyboard
3576 * callproc.c (Fcall_process): Add (:file "file") as an option for
3578 (Fcall_process_region): Ditto.
3580 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3582 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3583 rather than `XVECTOR (FOO)->size'.
3585 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3586 inttypes.h, as a gnulib replacement is used if it not available in
3589 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3591 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3592 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3593 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3595 * coding.c (coding_alloc_by_realloc): Error out if destination
3596 will grow beyond MOST_POSITIVE_FIXNUM.
3597 (decode_coding_emacs_mule): Abort if there isn't enough place in
3598 charbuf for the composition carryover bytes. Reserve an extra
3599 space for up to 2 characters produced in a loop.
3600 (decode_coding_iso_2022): Abort if there isn't enough place in
3601 charbuf for the composition carryover bytes.
3603 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3605 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3606 aborting when %lld or %lll format is passed.
3607 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3608 %llo or %llx format is passed. (Bug#8545)
3610 * window.c (window_scroll_line_based): Use a marker instead of
3611 simple variables to record original value of point. (Bug#7952)
3613 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3614 produced by %s or %c overflows available buffer space. (Bug#8545)
3616 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3618 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3619 (SIZE_MAX): Move defn after all includes, as they might #define it.
3621 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3623 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3625 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3627 * keyboard.c (Qdelayed_warnings_hook): Define.
3628 (command_loop_1): Run `delayed-warnings-hook'
3629 if Vdelayed_warnings_list is non-nil.
3630 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3631 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3633 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3635 * doprnt.c (doprnt): Don't return value smaller than the buffer
3636 size if the message was truncated. (Bug#8545).
3638 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3640 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3641 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3643 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3645 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3647 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3649 * makefile.w32-in: Update dependencies.
3651 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3653 Improve `doprnt' and its usage. (Bug#8545)
3654 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3655 `format_end'. Remove support for %l as a conversion specifier.
3656 Don't use xrealloc. Improve diagnostics when the %l size modifier
3657 is used. Update the commentary.
3659 * eval.c (verror): Simplify calculation of size_t.
3661 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3664 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3666 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3669 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3671 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3672 This makes this file independent of the recent pseudovector change.
3674 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3676 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3678 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3679 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3680 Remove unused local.
3681 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3683 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3684 GCC 4.6.0 optimizes based on type-based alias analysis.
3685 For example, if b is of type struct buffer * and v of type struct
3686 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3687 != &v->size, and therefore "v->size = 1; b->size = 2; return
3688 v->size;" must therefore return 1. This assumption is incorrect
3689 for Emacs, since it type-puns struct Lisp_Vector * with many other
3690 types. To fix this problem, this patch adds a new type struct
3691 vectorlike_header that documents the constraints on layout of vectors
3692 and pseudovectors, and helps optimizing compilers not get fooled
3693 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3694 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3695 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3697 (XSETPVECTYPE): Rewrite in terms of new macro.
3698 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3699 This is a bit clearer, and further avoids the possibility of
3700 undesirable aliasing.
3701 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3702 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3703 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3704 since Lisp_Subr is a special case (no "next" field).
3705 (ASIZE): Now uses header.size rather than size.
3706 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3707 to avoid the hassle of writing XVECTOR (foo)->header.size.
3708 (struct vectorlike_header): New type.
3709 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3710 object, to help avoid aliasing.
3711 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3712 (SUBRP): Likewise, since Lisp_Subr is a special case.
3713 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3714 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3715 (struct Lisp_Hash_Table): Combine first two members into a single
3716 struct vectorlike_header member. All uses of "size" and "next" members
3717 changed to be "header.size" and "header.next".
3718 * buffer.h (struct buffer): Likewise.
3719 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3720 * frame.h (struct frame): Likewise.
3721 * process.h (struct Lisp_Process): Likewise.
3722 * termhooks.h (struct terminal): Likewise.
3723 * window.c (struct save_window_data, struct saved_window): Likewise.
3724 * window.h (struct window): Likewise.
3725 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3726 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3727 * buffer.c (init_buffer_once): Likewise.
3728 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3730 * process.c (Fformat_network_address): Use local var for size,
3733 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3735 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3736 * data.c (atof): Remove decl; no longer used or needed.
3737 (digit_to_number): Move to lread.c.
3738 (Fstring_to_number): Use new string_to_number function, to be
3739 consistent with how the Lisp reader treats infinities and NaNs.
3740 Do not assume that floating-point numbers represent EMACS_INT
3741 without losing information; this is not true on most 64-bit hosts.
3742 Avoid double-rounding errors, by insisting on integers when
3743 parsing non-base-10 numbers, as the documentation specifies.
3744 * lisp.h (string_to_number): New decl, replacing ...
3745 (isfloat_string): Remove.
3746 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3747 (read1): Do not accept +. and -. as integers; this
3748 appears to have been a coding error. Similarly, do not accept
3749 strings like +-1e0 as floating point numbers. Do not report
3750 overflow for integer overflows unless the base is not 10 which
3751 means we have no simple and reliable way to continue.
3752 Break out the floating-point parsing into a new
3753 function string_to_number, so that Fstring_to_number parses
3754 floating point numbers consistently with the Lisp reader.
3755 (digit_to_number): Move here from data.c. Make it static inline.
3756 (E_CHAR, EXP_INT): Remove, replacing with ...
3757 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3758 (string_to_number): New function, replacing isfloat_string.
3759 This function checks for valid syntax and produces the resulting
3760 Lisp float number too. Rework it so that string-to-number
3761 no longer mishandles examples like "1.0e+". Use strtoumax,
3762 so that overflow for non-base-10 numbers is reported only when
3763 there's no portable and simple way to convert to floating point.
3765 * textprop.c (set_text_properties_1): Rewrite for clarity,
3766 and to avoid GCC warning about integer overflow.
3768 * intervals.h (struct interval): Use EMACS_INT for members
3769 where EMACS_UINT might cause problems. See
3770 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3771 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3772 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3774 (offset_intervals): Tell GCC not to worry about length overflow
3775 when negating a negative length.
3777 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3778 (overrun_check_free): Likewise.
3780 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3781 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3784 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3785 (gnutls_make_error): Rename local to avoid shadowing.
3786 (gnutls_emacs_global_deinit): ifdef out; not used.
3787 (Fgnutls_boot): Use const for pointer to readonly storage.
3788 Comment out unused local. Fix pointer signedness problems.
3790 * lread.c (openp): Don't stuff size_t into an 'int'.
3791 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3792 about possible signed overflow.
3794 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3795 (GDK_KEY_g): Don't define if already defined.
3796 (xg_prepare_tooltip): Avoid pointer signedness problem.
3797 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3799 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3800 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3802 * xfns.c (Fx_window_property): Simplify a bit,
3803 to make a bit faster and to avoid GCC 4.6.0 warning.
3804 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3806 * fns.c (internal_equal): Don't assume size_t fits in int.
3808 * alloc.c (compact_small_strings): Tighten assertion a little.
3810 Replace pEd with more-general pI, and fix some printf arg casts.
3811 * lisp.h (pI): New macro, generalizing old pEd macro to other
3812 conversion specifiers. For example, use "...%"pI"d..." rather
3813 than "...%"pEd"...".
3814 (pEd): Remove. All uses replaced with similar uses of pI.
3815 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3816 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3817 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3818 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3819 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3820 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3821 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3823 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3824 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3825 * print.c (safe_debug_print, print_object): Likewise.
3826 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3828 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3829 avoiding the 0 flag, which is not portable.
3830 * process.c (Fmake_network_process): Use pI to avoid cast.
3831 * region-cache.c (pp_cache): Likewise.
3832 * xdisp.c (decode_mode_spec): Likewise.
3833 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3834 behavior on 64-bit hosts with printf arg.
3835 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3836 (x_stop_queuing_selection_requests): Likewise.
3837 (x_get_window_property): Don't truncate byte count to an 'int'
3840 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3841 here, since it parses constructs like leading '-' and spaces,
3842 which are not wanted; and it overflows with large numbers.
3843 Instead, simply match F[0-9]+, which is what is wanted anyway.
3845 * alloc.c: Remove unportable assumptions about struct layout.
3846 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3847 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3848 (allocate_vectorlike, make_pure_vector): Use the new macros,
3849 plus offsetof, to remove unportable assumptions about struct layout.
3850 These assumptions hold on all porting targets that I know of, but
3851 they are not guaranteed, they're easy to remove, and removing them
3852 makes further changes easier.
3854 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3855 This doesn't fix a bug but makes the code clearer.
3856 (string_overrun_cookie): Now const. Use initializers that
3857 don't formally overflow signed char, to avoid warnings.
3858 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3859 can cause Emacs to crash when string overrun checking is enabled.
3860 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3861 multiple of sizeof (EMACS_INT); it need not be, if
3862 alignof(EMACS_INT) < sizeof (EMACS_INT).
3863 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3865 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3867 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3869 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3871 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3872 supposed to be handshaking. (Bug#8556)
3873 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3875 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3877 * lisp.h (Qdebug): List symbol.
3878 * eval.c (Qdebug): Restore global linkage.
3879 * keyboard.c (debug-on-event): New variable.
3880 (handle_user_signal): Break into debugger when debug-on-event
3881 matches the current signal symbol.
3883 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3885 * alloc.c (check_sblock, check_string_bytes)
3886 (check_string_free_list): Convert to standard C.
3888 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3890 * w32.c (emacs_gnutls_push): Fix typo.
3892 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3894 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3895 "cast to pointer from integer of different size".
3897 Improve doprnt and its use in verror. (Bug#8545)
3898 * doprnt.c (doprnt): Document the set of format control sequences
3899 supported by the function. Use SAFE_ALLOCA instead of always
3902 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3903 is one byte too soon. Don't use xrealloc; instead xfree and
3906 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3908 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3911 * gnutls.c: Renamed global_initialized to
3912 gnutls_global_initialized. Added internals for the
3913 :verify-hostname-error, :verify-error, and :verify-flags
3914 parameters of `gnutls-boot' and documented those parameters in the
3915 docstring. Start callback support.
3916 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3917 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3918 on error. Return error code.
3919 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3920 (emacs_gnutls_read): Likewise.
3921 (Fgnutls_boot): Return handshake error code.
3922 (emacs_gnutls_handle_error): New function.
3923 (wsaerror_to_errno): Likewise.
3925 * w32.h (emacs_gnutls_pull): Add prototype.
3926 (emacs_gnutls_push): Likewise.
3928 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3929 (emacs_gnutls_push): Likewise.
3931 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3933 * process.c (wait_reading_process_output): Check if GnuTLS
3934 buffered some data internally if no FDs are set for TLS
3937 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3938 (LIBS): Link to USER_LIBS.
3939 ($(BLD)/gnutls.$(0)): New target.
3941 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3943 * xdisp.c (handle_single_display_spec): Rename the
3944 display_replaced_before_p argument into display_replaced_p, to
3945 make it consistent with the commentary. Fix typos in the
3948 * textprop.c (syms_of_textprop): Remove dead code.
3949 (copy_text_properties): Delete obsolete commentary about an
3950 interface that was deleted long ago. Fix typos in the description
3953 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3954 to changes in oldXMenu/XMenu.h from 2011-04-16.
3955 <menu_help_message, prev_menu_help_message>: Constify.
3956 (IT_menu_make_room): menu->help_text is now `const char **';
3959 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3960 to changes in oldXMenu/XMenu.h from 2011-04-16.
3961 (struct XMenu): Declare `help_text' `const char **'.
3963 * xfaces.c <Qunspecified>: Make extern again.
3965 * syntax.c: Include sys/types.h before including regex.h, as
3968 * doc.c (get_doc_string): Improve the format passed to `error'.
3970 * doprnt.c (doprnt): Improve commentary.
3972 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3974 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3977 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3978 changes in globals.h immediately force recompilation.
3979 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3980 $(CURDIR)/s/ms-w32.h.
3981 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3983 * character.c (Fchar_direction): Function deleted.
3984 (syms_of_character): Don't defsubr it.
3985 <char-direction-table>: Deleted.
3987 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3989 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3990 * doprnt.c: Include limits.h.
3991 (SIZE_MAX): New macro.
3992 (doprnt): Return a size_t value. 2nd arg is now size_t.
3993 Many local variables are now size_t instead of int or unsigned.
3994 Improve overflow protection. Support `l' modifier for integer
3995 conversions. Support %l conversion. Don't assume an EMACS_INT
3996 argument for integer conversions and for %c.
3998 * lisp.h (doprnt): Restore prototype.
4000 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4003 * Makefile.in (base_obj): Add back doprnt.o.
4005 * deps.mk (doprnt.o): Add back prerequisites.
4006 (callint.o): Depend on character.h.
4008 * eval.c (internal_lisp_condition_case): Include the handler
4009 representation in the error message.
4010 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4011 when breaking from the loop.
4013 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4015 * callint.c (Fcall_interactively): When displaying error message
4016 about invalid control letter, pass the character's codepoint, not
4017 a pointer to its multibyte form. Improve display of the character
4018 in octal and display also its hex code.
4020 * character.c (char_string): Use %x to display the (unsigned)
4021 codepoint of an invalid character, to avoid displaying a bogus
4024 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4025 `error', not SYMBOL_NAME itself.
4027 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4028 character arguments to `error'.
4030 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4031 to `error' in error message about FINAL_CHAR argument. Make sure
4032 FINAL_CHAR is a character, and use %c when it is passed as
4033 argument to `error'.
4035 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4037 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4039 * w32.c: Include <time.h>.
4040 (sys_localtime): New function.
4042 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4044 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4046 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4048 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4050 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4053 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4055 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4056 gl_state.e_property when gl_state.object is Qt.
4058 * insdel.c (make_gap_larger): Remove limitation of buffer size
4061 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4063 * xdisp.c (lookup_glyphless_char_display)
4064 (produce_glyphless_glyph): Handle cons cell entry in
4065 glyphless-char-display.
4066 (Vglyphless_char_display): Document it.
4068 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4069 glyphless-char-display.
4071 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4073 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4075 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4077 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4078 definition for no-X builds.
4080 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4082 Static checks with GCC 4.6.0 and non-default toolkits.
4084 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4086 * process.c (keyboard_bit_set): Define only if SIGIO.
4087 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4088 (send_process): Repair possible setjmp clobbering.
4090 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4092 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4094 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4096 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4097 Define only if needed.
4099 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4100 by pacifying GCC about it. Maybe it's time to retire it?
4101 * xfaces.c (USG, __TIMEVAL__): Likewise.
4103 * dispextern.h (struct redisplay_interface): Rename param
4105 * termhooks.h (struct terminal): Likewise.
4106 * xterm.c (xembed_send_message): Likewise.
4108 * insdel.c (make_gap_smaller): Define only if
4109 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4111 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4114 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4115 so that we aren't warned about unused symbols.
4117 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4119 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4121 * xfns.c (x_real_positions): Mark locals as initialized.
4123 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4125 * xterm.c: Fix problems found by static analysis with other toolkits.
4126 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4127 (x_dispatch_event): Declare static if USE_GTK, and
4128 define if USE_GTK || USE_X_TOOLKIT.
4129 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4130 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4131 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4132 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4134 * xmenu.c (menu_help_callback): Pointer type fixes.
4135 Use const pointers when pointing at readonly data. Avoid pointer
4137 (FALSE): Remove unused macro.
4138 (update_frame_menubar): Remove unused decl.
4140 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4142 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4143 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4144 (single_menu_item): Rename local to avoid shadowing.
4146 * keyboard.c (make_lispy_event): Remove unused local var.
4148 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4149 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4151 * bitmaps: Change bitmaps from unsigned char back to the X11
4152 compatible char. Avoid the old compiler warnings about
4153 out-of-range initializers by using, for example, '\xab' rather
4156 * xgselect.c (xgselect_initialize): Check vs interface
4157 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4159 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4161 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4162 to read-only memory.
4164 * fns.c (vector): Remove; this old hack is no longer needed.
4166 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4168 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4170 * xrdb.c (x_load_resources): Omit unused local.
4172 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4173 (x_window): Rename locals to avoid shadowing.
4174 (USG): Use the kludged USG macro, to pacify gcc.
4176 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4177 (x_term_init): Remove local to avoid shadowing.
4179 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4181 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4182 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4184 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4186 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4188 Fix regex.c, syntax.c and friends for buffers > 2GB.
4189 * syntax.h (struct gl_state_s): Declare character position members
4192 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4194 * textprop.c (verify_interval_modification, interval_of):
4195 Declare arguments EMACS_INT.
4197 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4200 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4202 * indent.c (Fvertical_motion): Local variable it_start is now
4205 * regex.c (re_match, re_match_2, re_match_2_internal)
4206 (bcmp_translate, regcomp, regexec, print_double_string)
4207 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4208 (re_compile_pattern, re_exec): Declare arguments and local
4209 variables `size_t' and `ssize_t' and return values `regoff_t', as
4211 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4212 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4213 <compile_stack_type>: `size' and `avail' are now `size_t'.
4215 * regex.h <regoff_t>: Use ssize_t, not int.
4216 (re_search, re_search_2, re_match, re_match_2): Arguments that
4217 specify buffer/string position and length are now ssize_t and
4218 size_t. Return type is regoff_t.
4220 2011-04-16 Ben Key <bkey76@gmail.com>
4222 * nsfont.m: Fixed bugs in ns_get_family and
4223 ns_descriptor_to_entity that were caused by using free to
4224 deallocate memory blocks that were allocated by xmalloc (via
4225 xstrdup). This caused Emacs to crash when compiled with
4226 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4227 --enable-checking=xmallocoverrun). xfree is now used to
4228 deallocate these memory blocks.
4230 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4232 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4234 emacs_write: Accept and return EMACS_INT for sizes.
4235 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4237 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4238 Accept and return EMACS_INT.
4239 (emacs_gnutls_write): Return the number of bytes written on
4241 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4242 (emacs_read, emacs_write): Remove check for negative size, as the
4243 Emacs source code has been audited now.
4244 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4245 (emacs_read, emacs_write): Use it.
4246 * process.c (send_process): Adjust to the new signatures of
4247 emacs_write and emacs_gnutls_write. Do not attempt to store
4248 a byte offset into an 'int'; it might overflow.
4249 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4251 * sound.c: Don't assume sizes fit in 'int'.
4252 (struct sound_device.period_size, alsa_period_size):
4253 Return EMACS_INT, not int.
4254 (struct sound_device.write, vox_write, alsa_write):
4255 Accept EMACS_INT, not int.
4256 (wav_play, au_play): Use EMACS_INT to store sizes and to
4257 record read return values.
4259 2011-04-15 Ben Key <bkey76@gmail.com>
4261 * keyboard.c (Qundefined): Don't declare static since it is used
4263 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4264 static since they are used in nsfont.m.
4266 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4268 * process.c (Qprocessp): Don't declare static.
4269 * lisp.h (Qprocessp): Declare again.
4271 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4273 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4275 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4277 Improve C-level modularity by making more things 'static'.
4279 Don't publish debugger-only interfaces to other modules.
4280 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4281 (verify_bytepos, count_markers): Move decls to the only modules
4283 * region-cache.h (pp_cache): Likewise.
4284 * window.h (check_all_windows): Likewise.
4285 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4287 * sysdep.c (croak): Now static, if
4288 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4289 * syssignal.h (croak): Declare only if not static.
4291 * alloc.c (refill_memory_reserve): Now static if
4292 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4293 * lisp.h (refill_memory_reserve): Declare only if not static.
4295 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4296 Define only if USE_LUCID.
4298 * xrdb.c (x_customization_string, x_rm_string): Now static.
4300 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4301 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4303 * xdisp.c (draw_row_with_mouse_face): Now static.
4304 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4306 * window.h (check_all_windows): Mark externally visible.
4308 * window.c (window_deletion_count): Now static.
4310 * undo.c: Make symbols static if they're not exported.
4311 (last_undo_buffer, last_boundary_position, pending_boundary):
4314 * textprop.c (interval_insert_behind_hooks): Now static.
4315 (interval_insert_in_front_hooks): Likewise.
4317 * term.c: Make symbols static if they're not exported.
4318 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4319 (max_frame_lines, tty_set_terminal_modes):
4320 (tty_reset_terminal_modes, tty_turn_off_highlight):
4321 (get_tty_terminal): Now static.
4322 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4323 * termhooks.h (term_mouse_moveto): Do not declare if
4325 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4326 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4328 * sysdep.c: Make symbols static if they're not exported.
4329 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4331 (sigprocmask_set, full_mask): Remove; unused.
4332 (wait_debugging): Mark as visible.
4333 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4334 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4336 * syntax.c (syntax_temp): Define only if !__GNUC__.
4338 * sound.c (current_sound_device, current_sound): Now static.
4340 * search.c (searchbufs, searchbuf_head): Now static.
4342 * scroll.c (scroll_cost): Remove; unused.
4343 * dispextern.h (scroll_cost): Remove decl.
4345 * region-cache.h (pp_cache): Mark as externally visible.
4347 * process.c: Make symbols static if they're not exported.
4348 (process_tick, update_tick, create_process, chan_process):
4349 (Vprocess_alist, proc_buffered_char, datagram_access):
4350 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4351 (deactivate_process): Mark defn as static, as well as decl.
4352 * lisp.h (create_process): Remove decl.
4353 * process.h (chan_process, Vprocess_alist): Remove decls.
4355 * print.c: Make symbols static if they're not exported.
4356 (print_depth, new_backquote_output, being_printed, print_buffer):
4357 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4358 (print_interval, print_number_index, initial_stderr_stream):
4360 * lisp.h (Fprinc): Remove decl.
4361 (debug_output_compilation_hack): Mark as externally visible.
4363 * sysdep.c (croak): Move decl from here to syssignal.h.
4364 * syssignal.h (croak): Put it here, so the API can be checked when
4365 'croak' is called from dissociate_if_controlling_tty.
4367 * minibuf.c: Make symbols static if they're not exported.
4368 (minibuf_save_list, choose_minibuf_frame): Now static.
4369 * lisp.h (choose_minibuf_frame): Remove decl.
4371 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4373 * lread.c: Make symbols static if they're not exported.
4374 (read_objects, initial_obarray, oblookup_last_bucket_number):
4376 (make_symbol): Remove; unused.
4377 * lisp.h (initial_obarray, make_symbol): Remove decls.
4379 * keyboard.c: Make symbols static if they're not exported.
4380 (single_kboard, recent_keys_index, total_keys, recent_keys):
4381 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4382 (this_single_command_key_start, echoing, last_auto_save):
4383 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4384 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4385 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4386 (Vlispy_mouse_stem, double_click_count):
4388 (force_auto_save_soon): Define only if SIGDANGER.
4389 (ignore_mouse_drag_p): Now static if
4390 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4391 (print_help): Remove; unused.
4392 (stop_character, last_timer_event): Mark as externally visible.
4393 * keyboard.h (ignore_mouse_drag_p): Declare only if
4394 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4395 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4396 * lisp.h (echoing): Remove decl.
4397 (force_auto_save_soon): Declare only if SIGDANGER.
4398 * xdisp.c (redisplay_window): Simplify code, to make it more
4399 obvious that ignore_mouse_drag_p is not accessed if !defined
4400 USE_GTK && !defined HAVE_NS.
4402 * intervals.c: Make symbols static if they're not exported.
4403 (merge_properties_sticky, merge_interval_right, delete_interval):
4405 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4407 * insdel.c: Make symbols static if they're not exported.
4408 However, leave prepare_to_modify_buffer alone. It's never
4409 called from outside this function, but that appears to be a bug.
4410 (combine_after_change_list, combine_after_change_buffer):
4411 (adjust_after_replace, signal_before_change): Now static.
4412 (adjust_after_replace_noundo): Remove; unused.
4413 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4414 (signal_before_change): Remove decls.
4416 * indent.c (val_compute_motion, val_vmotion): Now static.
4418 * image.c: Make symbols static if they're not exported.
4419 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4421 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4422 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4424 * fringe.c (standard_bitmaps): Now static.
4425 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4427 * frame.c: Make symbols static if they're not exported.
4428 (x_report_frame_params, make_terminal_frame): Now static.
4429 (get_frame_param): Now static, unless HAVE_NS.
4430 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4431 (x_get_resource_string): Remove; not used.
4432 * frame.h (make_terminal_frame, x_report_frame_params):
4433 (x_get_resource_string); Remove decls.
4434 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4435 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4437 * font.c, fontset.c: Make symbols static if they're not exported.
4438 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4439 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4440 * font.c (font_close_object): Now static.
4441 * font.h (font_close_object): Remove.
4442 * fontset.c (FONTSET_OBJLIST): Remove.
4443 (free_realized_fontset) #if-0 the body, which does nothing.
4444 (face_suitable_for_char_p): #if-0, as it's never called.
4445 * fontset.h (face_suitable_for_char_p): Remove decl.
4446 * xfaces.c (face_at_string_position):
4447 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4448 since 0 is always ASCII.
4450 * fns.c (weak_hash_tables): Now static.
4452 * fileio.c: Make symbols static if they're not exported.
4453 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4454 (Vwrite_region_annotation_buffers): Now static.
4456 * eval.c: Make symbols static if they're not exported.
4457 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4458 * lisp.h (backtrace_list): Remove decl.
4460 * emacs.c: Make symbols static if they're not exported.
4461 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4462 (fatal_error_code, fatal_error_signal_hook, standard_args):
4464 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4465 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4466 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4467 * lisp.h (fatal_error_signal_hook): Remove decl.
4468 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4470 * editfns.c: Move a (normally-unused) function to its only use.
4471 * editfns.c, lisp.h (get_operating_system_release): Remove.
4472 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4473 worth the hassle of breaking this out.
4475 * xterm.c: Make symbols static if they're not exported.
4476 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4477 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4478 (x_destroy_window, x_delete_display):
4480 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4481 (x_mouse_leave): Remove; unused.
4482 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4483 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4484 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4486 (x_mouse_leave): Declare only if WINDOWSNT.
4487 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4488 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4491 * ftxfont.c: Make symbols static if they're not exported.
4492 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4494 * font.h (ftxfont_driver): Likewise.
4496 * xfns.c: Make symbols static if they're not exported.
4497 (x_last_font_name, x_display_info_for_name):
4498 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4499 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4500 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4501 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4502 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4503 (last_show_tip_args): Now static.
4504 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4505 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4506 (x_screen_planes): Remove; unused.
4507 * dispextern.h (x_screen_planes): Remove decl.
4509 * dispnew.c: Make symbols static if they're not exported.
4510 * dispextern.h (redraw_garbaged_frames, scrolling):
4511 (increment_row_positions): Remove.
4512 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4513 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4515 (redraw_garbaged_frames): Remove; unused.
4517 * xfaces.c: Make symbols static if they're not exported.
4518 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4520 * xterm.h (defined_color): Remove decls.
4521 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4522 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4523 (menu_face_changed_default, defined_color, free_realized_face):
4524 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4525 (ascii_face_of_lisp_face): Remove; unused.
4527 * xdisp.c: Make symbols static if they're not exported.
4528 * dispextern.h (scratch_glyph_row, window_box_edges):
4529 (glyph_to_pixel_coords, set_cursor_from_row):
4530 (get_next_display_element, set_iterator_to_next):
4531 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4532 (show_mouse_face): Remove decls
4533 * frame.h (message_buf_print): Likewise.
4534 * lisp.h (pop_message, set_message, check_point_in_composition):
4536 * xterm.h (set_vertical_scroll_bar): Likewise.
4537 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4538 (message_buf_print, scratch_glyph_row, displayed_buffer):
4539 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4540 (get_next_display_element, show_mouse_face, window_box_edges):
4541 (frame_to_window_pixel_xy, check_point_in_composition):
4542 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4543 (glyph_to_pixel_coords): Remove; unused.
4545 * dired.c (file_name_completion): Now static.
4547 * dbusbind.c (xd_in_read_queued_messages): Now static.
4549 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4550 * data.c (circular_list_error): Remove.
4552 * commands.h (last_point_position, last_point_position_buffer):
4553 (last_point_position_window): Remove decls.
4554 * keyboard.c: Make these variables static.
4556 * coding.h (coding, code_convert_region, encode_coding_gap):
4558 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4559 (iso_code_class, detect_coding, code_convert_region): Now static.
4560 (encode_coding_gap): Remove; unused.
4562 * chartab.c (chartab_chars, chartab_bits): Now static.
4564 * charset.h (charset_iso_8859_1): Remove decl.
4565 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4568 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4569 * ccl.c (Vccl_program_table): Now static.
4570 (check_ccl_update): Remove; unused.
4572 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4573 * category.h: ... from here.
4574 * category.c (check_category_table, set_category_set): Now static.
4576 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4577 * lisp.h: Remove these decls.
4579 * buffer.c (buffer_count): Remove unused var.
4581 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4582 so that it's not optimized away.
4583 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4584 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4585 exported only to the debugger.
4587 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4588 * atimer.h (run_all_atimers): Remove; not exported.
4590 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4591 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4592 was inaccessible from Lisp.
4593 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4594 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4596 alloc.c: Import and export fewer symbols, and remove unused items.
4597 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4599 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4600 it's not optimized away by whole-program optimization.
4601 (message_enable_multibyte, free_misc): Remove.
4602 (catchlist, handlerlist, mark_backtrace):
4603 Declare only if BYTE_MARK_STACK.
4604 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4605 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4606 (message_enable_multibyte): Remove decl.
4607 (free_misc, interval_free_list, float_block, float_block_index):
4608 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4609 (cons_free_list, last_marked_index):
4611 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4612 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4613 (mark_backtrace): Define only if BYTE_MARK_STACK.
4614 * xdisp.c (message_enable_multibyte): Now static.
4616 Declare Lisp_Object Q* variables to be 'static' if not exported.
4617 This makes it easier for human readers (and static analyzers)
4618 to see whether these variables are used from other modules.
4619 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4620 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4621 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4622 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4623 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4624 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4625 * xmenu.c, xselect.c:
4626 Declare Q* vars static if they are not used in other modules.
4627 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4628 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4629 Remove decls of unexported vars.
4630 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4632 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4634 Make Emacs functions such as Fatom 'static' by default.
4635 This makes it easier for human readers (and static analyzers)
4636 to see whether these functions can be called from other modules.
4637 DEFUN now defines a static function. To make the function external
4638 so that it can be used in other C modules, use the new macro DEFUE.
4639 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4640 (Finit_image_library):
4641 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4642 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4643 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4644 Remove decls, since these functions are now static.
4645 (Funintern, Fget_internal_run_time): New decls, since these functions
4646 were already external.
4648 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4649 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4650 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4651 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4652 * keyboard.c, keymap.c, lread.c:
4653 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4654 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4655 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4656 Mark functions with DEFUE instead of DEFUN,
4657 if they are used in other modules.
4658 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4659 decls for now-static functions.
4660 * buffer.h (Fdelete_overlay): Remove decl.
4661 * callproc.c (Fgetenv_internal): Mark as internal.
4662 * composite.c (Fremove_list_of_text_properties): Remove decl.
4663 (Fcomposition_get_gstring): New forward static decl.
4664 * composite.h (Fcomposite_get_gstring): Remove decl.
4665 * dired.c (Ffile_attributes): New forward static decl.
4666 * doc.c (Fdocumntation_property): New forward static decl.
4667 * eval.c (Ffetch_bytecode): New forward static decl.
4668 (Funintern): Remove extern decl; now in .h file where it belongs.
4669 * fileio.c (Fmake_symbolic_link): New forward static decl.
4670 * image.c (Finit_image_library): New forward static decl.
4671 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4672 * intervals.h (Fprevious_property_change):
4673 (Fremove_list_of_text_properties): Remove decls.
4674 * keyboard.c (Fthis_command_keys): Remove decl.
4675 (Fcommand_execute): New forward static decl.
4676 * keymap.c (Flookup_key): New forward static decl.
4677 (Fcopy_keymap): Now static.
4678 * keymap.h (Flookup_key): Remove decl.
4679 * process.c (Fget_process): New forward static decl.
4680 (Fprocess_datagram_address): Mark as internal.
4681 * syntax.c (Fsyntax_table_p): New forward static decl.
4682 (skip_chars): Remove duplicate decl.
4683 * textprop.c (Fprevious_property_change): New forward static decl.
4684 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4686 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4687 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4689 * editfns.c (Fformat): Remove unreachable code.
4691 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4693 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4696 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4698 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4699 when at ZV. (Bug#8487)
4701 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4703 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4705 * keyboard.c (parse_tool_bar_item): Likewise.
4706 * sound.c (sound_cleanup, alsa_close): Likewise.
4707 * termcap.c (tgetent): Likewise.
4708 * xfns.c (x_default_font_parameter): Likewise.
4709 * xsettings.c (read_and_apply_settings): Likewise.
4711 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4712 (overrun_check_free): Protoize.
4714 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4716 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4717 since callers should never pass a negative size.
4718 Change the signature to match that of plain 'read' and 'write'; see
4719 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4720 * lisp.h: Update prototypes of emacs_write and emacs_read.
4722 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4724 * xdisp.c (redisplay_window): Don't try to determine the character
4725 position of the scroll margin if the window start point w->startp
4726 is outside the buffer's accessible region. (Bug#8468)
4728 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4730 Fix write-region and its subroutines for buffers > 2GB.
4731 * fileio.c (a_write, e_write): Modify declaration of arguments and
4732 local variables to support buffers larger than 2GB.
4733 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4735 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4736 argument, local variables, and return value.
4738 * lisp.h: Update prototypes of emacs_write and emacs_read.
4740 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4742 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4744 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4746 Fix more problems found by GCC 4.6.0's static checks.
4748 * xdisp.c (vmessage): Use a better test for character truncation.
4750 * charset.c (load_charset_map): <, not <=, for optimization,
4751 and to avoid potential problems with integer overflow.
4752 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4753 * casetab.c (set_identity, shuffle): Likewise.
4754 * editfns.c (Fformat): Likewise.
4755 * syntax.c (skip_chars): Likewise.
4757 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4758 This also lets GCC 4.6.0 generate slightly better loop code.
4760 * callint.c (Fcall_interactively): <, not <=, for optimization.
4761 (Fcall_interactively): Count the number of arguments produced,
4762 not the number of arguments given. This is simpler and lets GCC
4763 4.6.0 generate slightly better code.
4765 * ftfont.c: Distingish more carefully between FcChar8 and char.
4766 The previous code passed unsigned char * to a functions like
4767 strlen and xstrcasecmp that expect char *, which does not
4768 conform to the C standard.
4769 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4770 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4771 char * when the C standard requires it.
4773 * keyboard.c (read_char): Remove unused var.
4775 * eval.c: Port to Windows vsnprintf (Bug#8435).
4777 (SIZE_MAX): Define if the headers do not.
4778 (verror): Do not give up if vsnprintf returns a negative count.
4779 Instead, grow the buffer. This ports to Windows vsnprintf, which
4780 does not conform to C99. Problem reported by Eli Zaretskii.
4781 Also, simplify the allocation scheme, by avoiding the need for
4782 calling realloc, and removing the ALLOCATED variable.
4784 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4786 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4787 But keep the doprint source code for now, as we might revamp it
4788 and use it again (Bug#8435).
4789 * lisp.h (doprnt): Remove.
4790 * Makefile.in (base_obj): Remove doprnt.o.
4791 * deps.mk (doprnt.o): Remove.
4793 error: Print 32- and 64-bit integers portably (Bug#8435).
4794 Without this change, on typical 64-bit hosts error ("...%d...", N)
4795 was used to print both 32- and 64-bit integers N, which relied on
4797 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4799 * lisp.h (error, verror): Mark as printf-like functions.
4800 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4801 Report overflow in size calculations when allocating printf buffer.
4802 Do not truncate output string at its first null byte.
4803 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4804 Truncate the output at a character boundary, since vsnprintf does not
4806 * charset.c (check_iso_charset_parameter): Convert internal
4807 character to string before calling 'error', since %c now has the
4809 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4810 overflow when computing char to be passed to 'error'. Do not
4811 pass Lisp_Object to 'error'; pass the integer instead.
4812 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4813 formatted with plain %d.
4815 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4817 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4819 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4821 * xterm.c (x_catch_errors): Remove duplicate declaration.
4823 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4825 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4827 2011-04-10 Jim Meyering <meyering@redhat.com>
4829 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4830 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4831 return ssize_t not "int", and use size_t as the buffer length.
4832 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4833 * gnutls.h: Update declarations.
4834 * process.c (read_process_output): Use ssize_t, to match.
4835 (send_process): Likewise.
4837 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4839 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4841 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4843 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4844 Use unsigned char, to match FcChar8 type definition.
4846 * xterm.c (handle_one_xevent):
4847 * xmenu.c (create_and_show_popup_menu):
4848 * xselect.c (x_decline_selection_request)
4849 (x_reply_selection_request): Avoid type-punned deref of X events.
4851 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4853 Fix some uses of `int' instead of EMACS_INT.
4854 * search.c (string_match_1, fast_string_match)
4855 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4856 (scan_buffer, find_next_newline_no_quit)
4857 (find_before_next_newline, search_command, Freplace_match)
4858 (Fmatch_data): Make some `int' variables be EMACS_INT.
4860 * xdisp.c (display_count_lines): 3rd argument and return value now
4861 EMACS_INT. All callers changed.
4862 (pint2hrstr): Last argument is now EMACS_INT.
4864 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4865 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4866 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4867 (decode_coding_utf_16, decode_coding_emacs_mule)
4868 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4869 (decode_coding_ccl, decode_coding_charset)
4870 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4871 (decode_coding_iso_2022, decode_coding_emacs_mule)
4872 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4873 <char_offset, last_offset>: Declare EMACS_INT.
4874 (encode_coding_utf_8, encode_coding_utf_16)
4875 (encode_coding_emacs_mule, encode_invocation_designation)
4876 (encode_designation_at_bol, encode_coding_iso_2022)
4877 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4878 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4880 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4881 (encode_invocation_designation): Last argument P_NCHARS is now
4883 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4884 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4886 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4889 * ccl.c (Fccl_execute_on_string): Declare some variables
4892 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4894 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4896 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4898 * process.c (Fformat_network_address): Doc fix.
4900 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4902 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4904 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4906 * keyboard.c (read_char): Call Lisp function help-form-show,
4907 instead of using internal_with_output_to_temp_buffer.
4908 (Qhelp_form_show): New var.
4909 (syms_of_keyboard): Use DEFSYM macro.
4911 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4913 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4915 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4917 * process.c (Flist_processes): Remove to Lisp.
4918 (list_processes_1): Delete.
4920 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4922 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4924 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4926 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4928 Fix more problems found by GCC 4.6.0's static checks.
4930 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4932 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4934 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4936 * xdisp.c (vmessage): Mark as a printf-like function.
4938 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4940 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4942 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4943 printf-like functions.
4944 (tiff_load): Add casts to remove these marks before passing them
4945 to system-supplied API.
4947 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4949 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4950 This avoids several warnings with gcc -Wstrict-overflow.
4951 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4952 directly, rather than having caller test rule sign. This avoids
4953 some unnecessary tests.
4954 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4955 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4956 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4958 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4959 (xfont_open): Avoid unnecessary tests.
4961 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4963 * composite.h, composite.c (composition_gstring_put_cache):
4964 Use EMACS_INT, not int, for length.
4966 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4967 breaking out part of COMPOSITION_DECODE_RULE.
4968 (COMPOSITION_DECODE_RULE): Use it.
4969 * composite.c (get_composition_id): Remove unused local vars,
4970 by using the new macro.
4972 * textprop.c (set_text_properties_1): Change while to do-while,
4973 since the condition is always true at first.
4975 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4976 (interval_deletion_adjustment): Return unsigned value.
4979 * process.c (list_processes_1, create_pty, read_process_output):
4980 (exec_sentinel): Remove vars that were set but not used.
4981 (create_pty): Remove unnecessary "volatile"s.
4982 (Fnetwork_interface_info): Avoid possibility of int overflow.
4983 (read_process_output): Do adaptive read buffering even if carryover.
4984 (read_process_output): Simplify nbytes computation if buffered.
4986 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4988 * syntax.c (scan_words): Remove var that was set but not used.
4989 (update_syntax_table): Use unsigned instead of int.
4991 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4992 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4993 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4995 * print.c (print_error_message): Avoid int overflow.
4997 * font.c (font_list_entities): Redo for clarity,
4998 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5000 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5001 (font_score): Avoid potential overflow in diff calculation.
5003 * fns.c (substring_both): Remove var that is set but not used.
5004 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5006 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5008 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5009 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5010 can always succeed if overflow has undefined behavior.
5012 * search.c (boyer_moore, wordify): Remove vars set but not used.
5013 (wordify): Omit three unnecessary tests.
5015 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5016 All callers changed. This avoids the need for an unused var.
5018 * casefiddle.c (casify_region): Remove var that is set but not used.
5020 * dired.c (file_name_completion): Remove var that is set but not used.
5022 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5024 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5025 (Finsert_file_contents): Remove unnecessary code checking fd.
5027 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5028 Check for integer overflow on size calculations.
5030 * buffer.c (Fprevious_overlay_change): Remove var that is set
5033 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5034 Remove vars that are set but not used.
5035 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5036 (timer_check_2): Mark vars as initialized.
5038 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5040 * image.c (lookup_image): Remove var that is set but not used.
5041 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5043 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5044 that are set but not used.
5046 * xfns.c (make_invisible_cursor): Don't return garbage
5047 if XCreateBitmapFromData fails (Bug#8410).
5049 * xselect.c (x_get_local_selection, x_handle_property_notify):
5050 Remove vars that are set but not used.
5052 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5053 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5055 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5056 Remove var that is set but not used.
5057 (scroll_bar_windows_size): Now size_t, not int.
5058 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5061 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5062 (map_tty_color) [!defined MSDOS]: Likewise.
5064 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5066 * coding.c: Remove vars that are set but not used.
5067 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5068 All callers changed.
5069 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5070 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5071 (decode_coding_charset): Remove vars that are set but not used.
5073 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5074 that is set but not used.
5076 * print.c (print_object): Remove var that is set but not used.
5078 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5079 The gnulib version avoids calling malloc in the usual case,
5080 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5081 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5082 * filelock.c (current_lock_owner): Likewise.
5083 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5084 * sysdep.c: Include allocator.h, careadlinkat.h.
5085 (emacs_no_realloc_allocator): New static constant.
5086 (emacs_readlink): New function.
5087 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5088 ../lib/careadlinkat.h.
5090 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5092 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5093 first non-nil return value).
5095 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5097 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5098 if not defined (Bug#8403).
5100 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5102 * xdisp.c (display_count_lines): Remove parameter `start',
5103 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5104 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5105 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5106 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5107 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5108 and thereabouts. All callers changed.
5109 (get_per_char_metric): Remove parameter `f', unused since
5110 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5112 2011-04-02 Jim Meyering <meyering@redhat.com>
5114 do not dereference NULL upon failed strdup
5115 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5116 (ns_get_family): Likewise.
5118 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5120 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5122 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5124 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5127 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5129 Add lexical binding.
5131 * window.c (Ftemp_output_buffer_show): New fun.
5132 (Fsave_window_excursion):
5133 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5135 * lread.c (lisp_file_lexically_bound_p): New function.
5136 (Fload): Bind Qlexical_binding.
5137 (readevalloop): Remove `evalfun' arg.
5138 Bind Qinternal_interpreter_environment.
5139 (Feval_buffer): Bind Qlexical_binding.
5140 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5142 (syms_of_lread): Declare `lexical-binding'.
5144 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5146 * keyboard.c (eval_dyn): New fun.
5147 (menu_item_eval_property): Use it.
5149 * image.c (parse_image_spec): Use Ffunctionp.
5151 * fns.c (concat, mapcar1): Accept byte-code-functions.
5153 * eval.c (Fsetq): Handle lexical vars.
5154 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5155 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5156 (FletX, Flet): Obey lexical binding.
5157 (Fcommandp): Handle closures.
5158 (Feval): New `lexical' arg.
5159 (eval_sub): New function extracted from Feval. Use it almost
5160 everywhere where Feval was used. Look up vars in lexical env.
5162 (Ffunctionp): Move from subr.el.
5163 (Ffuncall): Handle closures.
5164 (apply_lambda): Remove `eval_flags'.
5165 (funcall_lambda): Handle closures and new byte-code-functions.
5166 (Fspecial_variable_p): New function.
5167 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5168 but without exporting it to Lisp.
5170 * doc.c (Fdocumentation, store_function_docstring):
5171 * data.c (Finteractive_form): Handle closures.
5173 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5176 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5178 (exec_byte_code): New function extracted from Fbyte_code to handle new
5179 calling convention for byte-code-functions. Add new byte-codes.
5181 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5183 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5185 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5187 * xdisp.c (redisplay_internal): Fix prototype.
5189 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5191 * xdisp.c (SCROLL_LIMIT): New macro.
5192 (try_scrolling): Use it when setting scroll_limit.
5193 Limit scrolling to 100 screen lines.
5194 (redisplay_window): Even when falling back on "recentering",
5195 position point in the window according to scroll-conservatively,
5196 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5198 (try_scrolling): When point is above the window, allow searching
5199 as far as scroll_max, or one screenful, to compute vertical
5200 distance from PT to the scroll margin position. This prevents
5201 try_scrolling from unnecessarily failing when
5202 scroll-conservatively is set to a value slightly larger than the
5203 window height. Clean up the case of PT below the margin at bottom
5204 of window: scroll_max can no longer be INT_MAX. When aggressive
5205 scrolling is in use, don't let point enter the opposite scroll
5206 margin as result of the scroll.
5207 (syms_of_xdisp) <scroll-conservatively>: Document the
5208 threshold of 100 lines for never-recentering scrolling.
5210 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5212 * dispextern.h (move_it_by_lines):
5213 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5214 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5215 (message_log_check_duplicate): Remove parameters `prev_bol' and
5216 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5217 (redisplay_internal): Remove parameter `preserve_echo_area',
5218 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5220 * indent.c (Fvertical_motion):
5221 * window.c (window_scroll_pixel_based, Frecenter):
5222 Don't pass `need_y_p' to `move_it_by_lines'.
5224 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5226 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5227 steal a few bits to be more compact.
5228 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5229 Remove unneeded casts.
5231 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5233 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5235 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5236 binding" message (bug#7967).
5238 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5240 Fix more problems found by GCC 4.6.0's static checks.
5242 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5243 Remove unused local var.
5245 * editfns.c (Fmessage_box): Remove unused local var.
5247 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5248 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5249 Omit unused local vars.
5250 * window.c (shrink_windows): Omit unused local var.
5251 * menu.c (digest_single_submenu): Omit unused local var.
5252 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5253 Omit unused local var.
5255 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5256 Don't assume string length fits in int.
5257 (keyremap_step, read_key_sequence): Use size_t for sizes.
5258 (read_key_sequence): Don't check last_real_key_start redundantly.
5260 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5261 instead of alloca (Bug#8344).
5263 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5264 (Fbacktrace_frame): Don't assume nframes fits in int.
5266 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5268 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5271 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5273 * cm.c (calccost): Turn while-do into do-while, for clarity.
5275 * keyboard.c (syms_of_keyboard): Use the same style as later
5276 in this function when indexing through an array. This also
5277 works around GCC bug 48267.
5279 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5281 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5283 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5284 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5286 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5287 This avoids undefined behavior on integer overflow, and is a bit
5288 more convenient anyway since it is compared to a size_t variable.
5290 Variadic C functions now count arguments with size_t, not int.
5291 This avoids an unnecessary limitation on 64-bit machines, which
5292 caused (substring ...) to crash on large vectors (Bug#8344).
5293 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5294 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5295 All variadic functions and their callers changed accordingly.
5296 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5297 * data.c (arith_driver, float_arith_driver): Likewise.
5298 * editfns.c (general_insert_function): Likewise.
5299 * eval.c (struct backtrace.nargs, interactive_p)
5300 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5301 (funcall_lambda, mark_backtrace): Likewise.
5302 * fns.c (concat): Likewise.
5303 * frame.c (x_set_frame_parameters): Likewise.
5304 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5305 0 if not found, not -1. All callers changed.
5307 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5308 (stack_copy_size): Now size_t, not int.
5309 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5311 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5313 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5314 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5315 All callers changed.
5317 * lisp.h (multibyte_char_to_unibyte):
5318 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5319 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5320 * character.h (CHAR_TO_BYTE8):
5321 * cmds.c (internal_self_insert):
5322 * editfns.c (general_insert_function):
5323 * keymap.c (push_key_description):
5324 * search.c (Freplace_match):
5325 * xdisp.c (message_dolog, set_message_1): All callers changed.
5327 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5329 * keyboard.c (safe_run_hook_funcall): New function.
5330 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5331 don't set the hook to nil, but remove the offending function instead.
5332 (Qcommand_hook_internal): Remove, unused.
5333 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5334 Vcommand_hook_internal.
5336 * eval.c (enum run_hooks_condition): Remove.
5337 (funcall_nil, funcall_not): New functions.
5338 (run_hook_with_args): Call each function through a `funcall' argument.
5339 Remove `cond' argument, now redundant.
5340 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5341 (Frun_hook_with_args_until_failure): Adjust accordingly.
5342 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5344 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5346 * dispextern.h (string_buffer_position): Remove declaration.
5348 * print.c (strout): Remove parameter `multibyte', unused since
5349 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5351 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5352 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5353 All callers changed.
5355 * w32.c (_wsa_errlist): Use braces for struct initializers.
5357 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5358 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5359 All callers changed.
5360 (string_buffer_position): Likewise. Also, make static (it's never
5361 used outside xdisp.c).
5362 (cursor_row_p): Remove parameter `w', unused since
5363 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5364 (decode_mode_spec): Remove parameter `precision', introduced during
5365 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5366 All callers changed.
5368 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5370 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5372 2011-03-27 Anders Lindgren <andlind@gmail.com>
5374 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5375 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5376 (ns_update_auto_hide_menu_bar): New functions.
5377 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5378 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5379 ns_constrain_all_frames.
5380 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5381 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5383 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5385 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5387 2011-03-27 Glenn Morris <rgm@gnu.org>
5389 * syssignal.h: Replace RETSIGTYPE with void.
5390 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5391 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5392 Replace SIGTYPE with void everywhere.
5393 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5394 * s/template.h (SIGTYPE): Remove commented out definition.
5396 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5398 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5399 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5401 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5403 * w32.c (read_unc_volume): Use parameter `henum', instead of
5404 global variable `wget_enum_handle'.
5406 * keymap.c (describe_vector): Remove parameters `indices' and
5407 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5408 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5410 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5412 * keyboard.c (timer_check): Remove parameter `do_it_now',
5413 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5414 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5415 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5417 * keyboard.c (read_char):
5418 * w32menu.c (w32_menu_display_help):
5419 * xmenu.c (show_help_event, menu_help_callback):
5420 Adjust calls to `show_help_echo'.
5422 * gtkutil.c (xg_maybe_add_timer):
5423 * keyboard.c (readable_events):
5424 * process.c (wait_reading_process_output):
5425 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5427 * insdel.c (adjust_markers_gap_motion):
5428 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5429 (gap_left, gap_right): Don't call it.
5431 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5433 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5434 incurred during fontification.
5436 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5438 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5439 (DEFVAR_PER_BUFFER): Don't pass it.
5441 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5442 (scrolling_window): Don't pass it.
5444 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5446 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5448 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5450 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5451 of variables specific to SELinux and computation of `encoded_absname'.
5453 * image.c (XPutPixel): Remove unused variable `height'.
5455 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5457 * unexw32.c (get_section_info): Remove unused variable `section'.
5459 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5460 (system_process_attributes): Remove unused variable `sess'.
5461 (sys_read): Remove unused variable `err'.
5463 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5464 (w32_wnd_proc): Remove unused variable `isdead'.
5465 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5466 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5467 (x_create_tip_frame): Remove unused variable `tem'.
5469 * w32inevt.c (w32_console_read_socket):
5470 Remove unused variable `no_events'.
5472 * w32term.c (x_draw_composite_glyph_string_foreground):
5473 Remove unused variable `width'.
5475 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5477 * w32term.c (x_set_glyph_string_clipping):
5478 Don't pass uninitialized region to CombineRgn.
5480 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5482 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5483 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5484 (Fx_close_connection): Remove unused variable `i'.
5486 * w32font.c (w32font_draw): Return number of glyphs.
5487 (w32font_open_internal): Remove unused variable `i'.
5488 (w32font_driver): Add missing initializer.
5490 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5491 (fill_in_menu): Remove unused variable `items_added'.
5493 * w32term.c (last_mouse_press_frame): Remove static global variable.
5494 (w32_clip_to_row): Remove unused variable `f'.
5495 (x_delete_terminal): Remove unused variable `i'.
5497 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5498 (NOTHING): Remove unused static global variable.
5499 (uniscribe_check_otf): Remove unused variable `table'.
5500 (uniscribe_font_driver): Add missing initializers.
5502 2011-03-23 Julien Danjou <julien@danjou.info>
5504 * term.c (Fsuspend_tty, Fresume_tty):
5505 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5506 * window.c (temp_output_buffer_show):
5507 * insdel.c (signal_before_change):
5508 * frame.c (Fhandle_switch_frame):
5509 * fileio.c (Fdo_auto_save):
5510 * emacs.c (Fkill_emacs):
5511 * editfns.c (save_excursion_restore):
5512 * cmds.c (internal_self_insert):
5513 * callint.c (Fcall_interactively):
5514 * buffer.c (Fkill_all_local_variables):
5515 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5517 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5518 unconditionnaly since it does the check itself.
5520 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5522 Fix more problems found by GCC 4.5.2's static checks.
5524 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5525 the first time through the loop, since we know p0 < p1 then.
5526 This also avoids a gcc -Wstrict-overflow warning.
5528 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5529 leading to a memory leak, possible in functions like
5530 load_charset_map_from_file that can allocate an unbounded number
5531 of objects (Bug#8318).
5533 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5534 that could (at least in theory) be that large.
5536 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5537 This is less likely to overflow, and avoids undefined behavior if
5538 overflow does occur. All callers changed. Use strtoul to scan
5539 for the unsigned long integer.
5540 (pint2hrstr): Simplify and tune code slightly.
5541 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5543 * scroll.c (do_scrolling): Work around GCC bug 48228.
5544 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5546 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5547 This also avoids a warning with gcc -Wstrict-overflow.
5548 (validate_x_resource_name): Simplify count usage.
5549 This also avoids a warning with gcc -Wstrict-overflow.
5551 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5554 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5556 * process.c (Fmake_network_process): Use socklen_t, not int,
5557 where POSIX says socklen_t is required in portable programs.
5558 This fixes a porting bug on hosts like 64-bit HP-UX, where
5559 socklen_t is wider than int (Bug#8277).
5560 (Fmake_network_process, server_accept_connection):
5561 (wait_reading_process_output, read_process_output):
5564 * process.c: Rename or move locals to avoid shadowing.
5565 (list_processes_1, Fmake_network_process):
5566 (read_process_output_error_handler, exec_sentinel_error_handler):
5567 Rename or move locals.
5568 (Fmake_network_process): Define label "retry_connect" only if needed.
5569 (Fnetwork_interface_info): Fix pointer signedness.
5570 (process_send_signal): Add cast to avoid pointer signedness problem.
5571 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5572 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5574 Make tparam.h and terminfo.c consistent.
5575 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5576 Include tparam.h instead, since it declares them.
5577 * cm.h (PC): Remove extern decl; tparam.h now does this.
5578 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5579 * terminfo.c: Include tparam.h, to check interfaces.
5580 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5581 (tparam): Adjust signature to match interface in tparam.h;
5582 this removes some undefined behavior. Check that outstring and len
5583 are zero, which they always are with Emacs.
5584 * tparam.h (PC, BC, UP): New extern decls.
5586 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5587 (xftfont_open): Rename locals to avoid shadowing.
5589 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5590 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5591 (OTF_TAG_SYM): Omit macro if not needed.
5592 (ftfont_list): Remove unused local.
5593 (get_adstyle_property, ftfont_pattern_entity):
5594 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5595 Rename locals to avoid shadowing.
5597 * xfont.c (xfont_list_family): Mark var as initialized.
5599 * xml.c (make_dom): Now static.
5601 * composite.c (composition_compute_stop_pos): Rename local to
5603 (composition_reseat_it): Remove unused locals.
5604 (find_automatic_composition, composition_adjust_point): Likewise.
5605 (composition_update_it): Mark var as initialized.
5606 (find_automatic_composition): Mark vars as initialized,
5607 with a FIXME (Bug#8290).
5609 character.h: Rename locals to avoid shadowing.
5610 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5611 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5612 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5613 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5616 * textprop.c (property_change_between_p): Remove; unused.
5618 * intervals.c (interval_start_pos): Now static.
5620 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5622 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5623 Rename locals to avoid shadowing.
5625 * sound.c (wav_play, au_play, Fplay_sound_internal):
5626 Fix pointer signedness.
5627 (alsa_choose_format): Remove unused local var.
5628 (wav_play): Initialize a variable to 0, to prevent undefined
5629 behavior (Bug#8278).
5631 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5633 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5635 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5636 clobbering (Bug#8298).
5637 * sysdep.c (sys_subshell): Likewise.
5638 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5640 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5641 This should get cleaned up, so that child_setup has the
5642 same signature on all platforms.
5644 * callproc.c (call_process_cleanup): Now static.
5645 (relocate_fd): Rename locals to avoid shadowing.
5647 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5649 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5650 not to be necessary, and produces flickering.
5652 2011-03-20 Glenn Morris <rgm@gnu.org>
5654 * config.in: Remove file.
5656 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5658 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5659 are now in src/globals.h.
5660 (syms_of_minibuf): Remove spurious & from previous change.
5662 2011-03-20 Leo <sdl.web@gmail.com>
5664 * minibuf.c (completing-read-function): New variable.
5665 (completing-read-default): Rename from completing-read.
5666 (completing-read): Call completing-read-function.
5668 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5670 * xfaces.c (Fx_load_color_file):
5671 Read color file from absolute filename (bug#8250).
5673 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5675 * makefile.w32-in: Update dependencies.
5677 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5679 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5681 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5683 Fix more problems found by GCC 4.5.2's static checks.
5685 * process.c (make_serial_process_unwind, send_process_trap):
5686 (sigchld_handler): Now static.
5688 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5689 That way, the code declares only the vars that it needs.
5690 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5691 * s/cygwin.h (PTY_ITERATION): Likewise.
5692 * s/darwin.h (PTY_ITERATION): Likewise.
5693 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5695 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5696 * process.c (allocate_pty): Don't declare stb unless it's needed.
5698 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5699 (CONSTANTLIM): Remove; unused.
5700 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5701 Define only if needed.
5703 * unexelf.c (unexec): Name an expression,
5704 to avoid gcc -Wbad-function-cast warning.
5705 Use a different way to cause a compilation error if anyone uses
5706 n rather than nn, a way that does not involve shadowing.
5707 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5709 * deps.mk (unexalpha.o): Remove; unused.
5711 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5712 * unexec.h: New file.
5713 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5714 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5716 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5717 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5718 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5719 Change as necessary to match prototype in unexec.h.
5721 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5723 (back_comment, skip_chars): Mark vars as initialized.
5725 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5726 Rename locals to avoid shadowing.
5728 * lread.c (read1): Rewrite so as not to use empty "else".
5729 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5731 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5733 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5734 warning when compiling print.c.
5736 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5737 instead of using an uninitialized var.
5738 (font_sort_entities): Mark var as initialized.
5740 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5742 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5743 pointers to constants.
5744 (font_parse_fcname): Remove unused vars.
5745 (font_delete_unmatched): Now static.
5746 (font_get_spec): Remove; unused.
5747 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5748 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5749 Rename or move locals to avoid shadowing.
5751 * fns.c (require_nesting_list, require_unwind): Now static.
5752 (Ffillarray): Rename locals to avoid shadowing.
5754 * floatfns.c (domain_error2): Define only if needed.
5755 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5757 * alloc.c (mark_backtrace): Move decl from here ...
5758 * lisp.h: ... to here, so that it can be checked.
5760 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5761 (Fdefvar): Rewrite so as not to use empty "else".
5762 (lisp_indirect_variable): Name an expression,
5763 to avoid gcc -Wbad-function-cast warning.
5764 (Fdefvar): Rename locals to avoid shadowing.
5766 * callint.c (quotify_arg, quotify_args): Now static.
5767 (Fcall_interactively): Rename locals to avoid shadowing.
5768 Use const pointer when appropriate.
5770 * lisp.h (get_system_name, get_operating_system_release):
5771 Move decls here, to check interfaces.
5772 * process.c (get_operating_system_release): Move decl to lisp.h.
5773 * xrdb.c (get_system_name): Likewise.
5774 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5775 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5776 some of which prompt warnings from gcc -Wbad-function-cast.
5777 (Fformat_time_string, Fencode_time, Finsert_char):
5778 (Ftranslate_region_internal, Fformat):
5779 Rename or remove local vars to avoid shadowing.
5780 (Ftranslate_region_internal): Mark var as initialized.
5782 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5785 * lisp.h (eassert): Check that the argument compiles, even if
5786 ENABLE_CHECKING is not defined.
5788 * data.c (Findirect_variable): Name an expression, to avoid
5789 gcc -Wbad-function-cast warning.
5790 (default_value, arithcompare, arith_driver, arith_error): Now static.
5791 (store_symval_forwarding): Rename local to avoid shadowing.
5792 (Fmake_variable_buffer_local, Fmake_local_variable):
5793 Mark variables as initialized.
5794 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5796 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5797 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5798 Rename locals to avoid shadowing.
5799 (mark_stack): Move local variables into the #ifdef region where
5801 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5802 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5804 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5805 (GC_STRING_CHARS): Remove; not used.
5806 (Fmemory_limit): Cast sbrk's returned value to char *.
5808 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5809 avoids undefined behavior in theory.
5811 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5813 Use functions, not macros, for up- and down-casing (Bug#8254).
5814 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5815 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5816 to use the following functions instead of these macros.
5817 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5818 EMACS_INT, since callers assume the returned value fits in int.
5819 (upcase1): Likewise, for UPCASE_TABLE.
5820 (uppercasep, lowercasep, upcase): New static inline functions.
5821 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5822 the race-condition problem in the old DOWNCASE.
5824 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5825 Rename locals to avoid shadowing.
5826 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5827 (regex_compile, re_search_2, re_match_2_internal):
5828 Remove unused local vars.
5829 (FREE_VAR): Rewrite so as not to use empty "else",
5830 which gcc can warn about.
5831 (regex_compile, re_match_2_internal): Mark locals as initialized.
5832 (RETALLOC_IF): Define only if needed.
5833 (WORDCHAR_P): Likewise. This one is never needed, but is used
5834 only in a comment talking about a compiler bug, so put inside
5835 the #if 0 of that comment.
5836 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5837 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5840 * search.c (boyer_moore): Rename locals to avoid shadowing.
5841 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5842 (PREV_CHAR_BOUNDARY): Likewise.
5844 * search.c (simple_search): Remove unused var.
5846 * dired.c (compile_pattern): Move decl from here ...
5847 * lisp.h: ... to here, so that it can be checked.
5848 (struct re_registers): New forward decl.
5850 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5852 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5854 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5855 Rename locals to avoid shadowing.
5856 (Fvertical_motion): Mark locals as initialized.
5858 * casefiddle.c (casify_object, casify_region): Now static.
5859 (casify_region): Mark local as initialized.
5861 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5863 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5864 New macros, so that the caller can use some names other than
5865 gcpro1, gcpro2, etc.
5866 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5868 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5869 argument, for consistency with GCPRO2_VAR, etc: it is now the
5870 prefix of the variable, not the variable itself. All uses
5872 * dired.c (directory_files_internal, file_name_completion):
5873 Rename locals to avoid shadowing.
5875 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5876 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5877 dired.c's scmp function, had undefined behavior.
5878 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5879 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5880 * buffer.h: ... to here, because these macros use current_buffer,
5881 and the new implementation with inline functions needs to have
5882 current_buffer in scope now, rather than later when the macros
5884 (downcase, upcase1): New static inline functions.
5885 (DOWNCASE, UPCASE1): Reimplement using these functions.
5886 This avoids undefined behavior in expressions like
5887 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5888 from race conditions in accessing the global variables
5889 case_temp1 and case_temp2.
5890 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5891 * lisp.h (case_temp1, case_temp2): Remove their decls.
5892 * character.h (ASCII_CHAR_P): Move from here ...
5893 * lisp.h: ... to here, so that the inline functions mentioned
5896 * dired.c (directory_files_internal_unwind): Now static.
5898 * fileio.c (file_name_as_directory, directory_file_name):
5899 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5901 (file_name_as_directory): Use const pointers when appropriate.
5902 (Fexpand_file_name): Likewise. In particular, newdir might
5903 point at constant storage, so make it a const pointer.
5904 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5905 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5907 (Fset_file_times, Finsert_file_contents, auto_save_error):
5908 Rename locals to avoid shadowing.
5910 * minibuf.c (choose_minibuf_frame_1): Now static.
5911 (Ftry_completion, Fall_completions): Rename or remove locals
5914 * marker.c (bytepos_to_charpos): Remove; unused.
5916 * lisp.h (verify_bytepos, count_markers): New decls,
5917 so that gcc does not warn that these functions aren't declared.
5919 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5920 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5921 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5922 (copy_text): Remove unused local var.
5924 * filelock.c (within_one_second): Now static.
5925 (lock_file_1): Rename local to avoid shadowing.
5927 * buffer.c (fix_overlays_before): Mark locals as initialized.
5928 (fix_start_end_in_overlays): Likewise. This function should be
5929 simplified by using pointers-to-pointers, but that's a different
5931 (switch_to_buffer_1): Now static.
5932 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5933 (report_overlay_modification): Rename locals to avoid shadowing.
5935 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5936 Fix pointer signedness issue.
5937 (sys_subshell): Mark local as volatile if checking for lint,
5938 to suppress a gcc -Wclobbered warning that does not seem to be right.
5939 (MAXPATHLEN): Define only if needed.
5941 * process.c (serial_open, serial_configure): Move decls from here ...
5942 * systty.h: ... to here, so that they can be checked.
5944 * fns.c (get_random, seed_random): Move extern decls from here ...
5945 * lisp.h: ... to here, so that they can be checked.
5947 * sysdep.c (reset_io): Now static.
5948 (wait_for_termination_signal): Remove; unused.
5950 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5951 (copy_keymap_item, append_key, push_text_char_description):
5953 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5954 (DENSE_TABLE_SIZE): Remove; unused.
5955 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5956 (describe_map_tree):
5957 Rename locals to avoid shadowing.
5959 * keyboard.c: Declare functions static if they are not used elsewhere.
5960 (echo_char, echo_dash, cmd_error, top_level_2):
5961 (poll_for_input, handle_async_input): Now static.
5962 (read_char, kbd_buffer_get_event, make_lispy_position):
5963 (make_lispy_event, make_lispy_movement, apply_modifiers):
5964 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5965 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5966 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5967 (read_key_sequence, read_char): Mark locals as initialized.
5968 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5970 * keyboard.h (make_ctrl_char): New decl.
5971 (mark_kboards): Move decl here ...
5972 * alloc.c (mark_kboards): ... from here.
5974 * lisp.h (force_auto_save_soon): New decl.
5976 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5977 (DEFINE_DUMMY_FUNCTION): New macro.
5978 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5980 (main): Add casts to avoid warnings
5981 if GCC considers string literals to be constants.
5983 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5985 * dbusbind.c: Pointer signedness fixes.
5986 (xd_signature, xd_append_arg, xd_initialize):
5987 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5988 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5989 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5990 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5992 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5993 if GCC considers string literals to be constants.
5994 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5996 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5998 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5999 (print_preprocess, print_object): New macro to fix last change.
6001 * print.c (print_preprocess): Don't forget font objects.
6003 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6005 * emacs.c (USAGE3): Doc fixes.
6007 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6009 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6012 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6014 * lisp.h (VWindow_system, Qfile_name_history):
6015 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6016 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6017 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6019 * w32select.c: Don't #include "keyboard.h".
6020 (run_protected): Add extern declaration for waiting_for_input.
6022 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6023 * w32console.c (detect_input_pending, read_input_pending)
6024 (encode_terminal_code):
6025 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6026 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6027 (w32_system_caret_y, Qfile_name_history):
6028 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6029 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6030 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6031 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6032 * w32proc.c (Qlocal, report_file_error):
6033 * w32term.c (Vwindow_system, updating_frame):
6034 * w32uniscribe.c (initialized, uniscribe_font_driver):
6035 Remove unneeded extern declarations.
6037 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6039 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6041 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6043 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6044 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6045 These macros can no longer be used for assignment.
6047 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6048 Assign struct members directly, instead of using BUF_BEGV etc.
6049 (record_buffer_markers, fetch_buffer_markers): New functions for
6050 recording and fetching special buffer markers.
6051 (set_buffer_internal_1, set_buffer_temp): Use them.
6053 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6055 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6057 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6058 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6060 * xdisp.c (hscroll_window_tree):
6061 (reconsider_clip_changes): Use PT instead of BUF_PT.
6063 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6065 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6066 $(EMACS_ROOT)/lib/intprops.h.
6068 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6070 Fix more problems found by GCC 4.5.2's static checks.
6072 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6073 to unsigned char * to avoid compiler diagnostic.
6074 (xg_free_frame_widgets): Make it clear that a local variable is
6075 needed only if USE_GTK_TOOLTIP.
6076 (gdk_window_get_screen): Make it clear that this macro is needed
6077 only if USE_GTK_TOOLTIP.
6078 (int_gtk_range_get_value): New function, which avoids a diagnostic
6079 from gcc -Wbad-function-cast.
6080 (xg_set_toolkit_scroll_bar_thumb): Use it.
6081 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6082 diagnostic from gcc -Wbad-function-cast.
6083 (get_utf8_string, xg_get_file_with_chooser):
6084 Rename locals to avoid shadowing.
6085 (create_dialog): Move locals to avoid shadowing.
6087 * xgselect.c (xg_select): Remove unused var.
6089 * image.c (four_corners_best): Mark locals as initialized.
6090 (gif_load): Initialize transparent_p to zero (Bug#8238).
6091 Mark another local as initialized.
6092 (my_png_error, my_error_exit): Mark with NO_RETURN.
6094 * image.c (clear_image_cache): Now static.
6095 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6096 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6097 (x_edge_detection): Remove unnecessary cast that
6098 gcc -Wbad-function-cast diagnoses.
6099 (gif_load): Fix pointer signedness.
6100 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6101 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6103 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6105 Improve quality of tests for time stamp overflow.
6106 For example, without this patch (encode-time 0 0 0 1 1
6107 1152921504606846976) returns the obviously-bogus value (-948597
6108 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6109 reports time overflow. See
6110 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6111 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6112 * editfns.c: Include limits.h and intprops.h.
6113 (TIME_T_MIN, TIME_T_MAX): New macros.
6114 (time_overflow): Move earlier, to before first use.
6115 (hi_time, lo_time): New functions, for an accurate test for
6117 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6118 (Fget_internal_run_time): Don't assume time_t fits in int.
6119 (make_time): Use list2 instead of Fcons twice.
6120 (Fdecode_time): More accurate test for out-of-range times.
6121 (check_tm_member): New function.
6122 (Fencode_time): Use it, to test for out-of-range times.
6123 (lisp_time_argument): Don't rely on undefined left-shift and
6124 right-shift behavior when checking for time stamp overflow.
6126 * editfns.c (time_overflow): New function, refactoring common code.
6127 (Fformat_time_string, Fdecode_time, Fencode_time):
6128 (Fcurrent_time_string): Use it.
6130 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6131 * dired.c (make_time): Move to ...
6132 * editfns.c (make_time): ... here.
6133 * systime.h: Note the move.
6135 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6137 * fringe.c (update_window_fringes): Remove unused variables.
6139 * unexmacosx.c (copy_data_segment): Also copy __got section.
6142 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6144 * termcap.c [MSDOS]: Include "msdos.h".
6145 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6146 Constify `char *' arguments and their references according to
6147 prototypes in tparam.h.
6149 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6151 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6152 Adapt all references accordingly.
6154 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6156 2011-03-11 Tom Tromey <tromey@redhat.com>
6158 * buffer.c (syms_of_buffer): Remove obsolete comment.
6160 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6162 * termhooks.h (encode_terminal_code): Declare prototype.
6164 * msdos.c (encode_terminal_code): Don't declare prototype.
6166 * term.c (encode_terminal_code): Now external again, used by
6167 w32console.c and msdos.c.
6169 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6170 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6172 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6174 Fix some minor problems found by GCC 4.5.2's static checks.
6176 * fringe.c (update_window_fringes): Mark locals as initialized
6178 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6180 * alloc.c (mark_fringe_data): Move decl from here ...
6181 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6182 to check its interface.
6183 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6185 * fontset.c (free_realized_fontset): Now static.
6186 (Fset_fontset_font): Rename local to avoid shadowing.
6187 (fontset_font): Mark local as initialized.
6188 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6190 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6192 * xselect.c (x_disown_buffer_selections): Remove; not used.
6193 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6194 (x_own_selection, Fx_disown_selection_internal): Rename locals
6196 (x_handle_dnd_message): Remove local to avoid shadowing.
6198 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6199 so that the caller can use some name other than gcpro1.
6200 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6201 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6202 (Fx_backspace_delete_keys_p):
6203 Use them to avoid shadowing, and rename vars to avoid shadowing.
6204 (x_decode_color, x_set_name, x_window): Now static.
6205 (Fx_create_frame): Add braces to silence GCC warning.
6206 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6207 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6208 Remove unused locals.
6209 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6210 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6211 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6214 * xterm.h (x_mouse_leave): New decl.
6216 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6217 Remove unused functions.
6218 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6219 (x_calc_absolute_position): Now static.
6220 (XTread_socket): Don't define label "out" unless it's used.
6221 Don't declare local "event" unless it's used.
6222 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6223 unless they are used.
6224 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6225 (x_fatal_error_signal): Remove; not used.
6226 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6227 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6228 (x_error_catcher, x_connection_closed, x_error_handler):
6229 (x_error_quitter, xembed_send_message, x_iconify_frame):
6230 (my_log_handler): Rename locals to avoid shadowing.
6231 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6232 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6234 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6235 Rename or move locals to avoid shadowing.
6236 (tty_defined_color, merge_face_heights): Now static.
6237 (free_realized_faces_for_fontset): Remove; not used.
6238 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6239 does not deduce is never used uninitialized.
6240 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6241 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6243 * terminal.c (store_terminal_param): Now static.
6245 * xmenu.c (menu_highlight_callback): Now static.
6246 (set_frame_menubar): Remove unused local.
6247 (xmenu_show): Rename parameter to avoid shadowing.
6248 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6249 since they might point to immutable storage.
6250 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6251 since it's unused otherwise.
6253 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6254 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6255 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6256 avoids a gcc -Wuninitialized diagnostic.
6257 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6258 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6259 does not deduce are never used uninitialized.
6261 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6263 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6264 * window.c (window_loop, size_window):
6265 (run_window_configuration_change_hook, enlarge_window): Likewise.
6267 * window.c (display_buffer): Now static.
6268 (size_window): Mark variables that gcc -Wuninitialized
6269 does not deduce are never used uninitialized.
6270 * window.h (check_all_windows): New decl, to forestall
6271 gcc -Wmissing-prototypes diagnostic.
6272 * dispextern.h (bidi_dump_cached_states): Likewise.
6274 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6276 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6278 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6279 and to avoid gcc -Wuninitialized warning.
6280 (load_charset_map): Mark variables that gcc -Wuninitialized
6281 does not deduce are never used uninitialized.
6282 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6284 * coding.c (coding_set_source, coding_set_destination):
6285 Use "else { /* comment */ }" rather than "else /* comment */;"
6286 for clarity, and to avoid gcc -Wempty-body warning.
6287 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6288 a block, when the outer 'i' will do.
6289 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6290 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6291 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6292 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6293 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6294 Rename locals to avoid shadowing.
6295 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6296 * coding.c (emacs_mule_char, encode_invocation_designation):
6297 Now static, since they're not used elsewhere.
6298 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6299 (decode_coding_object, encode_coding_object, detect_coding_system):
6300 (decode_coding_emacs_mule): Mark variables that gcc
6301 -Wuninitialized does not deduce are never used uninitialized.
6302 (detect_coding_iso_2022): Initialize a local variable that might
6303 be used uninitialized. Leave a FIXME because it's not clear that
6304 this initialization is needed. (Bug#8211)
6305 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6306 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6307 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6308 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6309 Remove unused macros.
6311 * category.c (hash_get_category_set): Remove unused local var.
6312 (copy_category_table): Now static, since it's not used elsewhere.
6313 * character.c (string_count_byte8): Likewise.
6315 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6316 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6318 * chartab.c (copy_sub_char_table): Now static, since it's not used
6320 (sub_char_table_ref_and_range, char_table_ref_and_range):
6321 Rename locals to avoid shadowing.
6322 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6324 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6325 (BIDI_BOB): Remove unused macro.
6327 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6328 deduce are never used uninitialized.
6329 * term.c (encode_terminal_code): Likewise.
6331 * term.c (encode_terminal_code): Now static. Remove unused local.
6333 * tparam.h: New file.
6334 * term.c, tparam.h: Include it.
6335 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6336 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6337 Move these decls to tparam.h, and make them agree with what
6338 is actually in tparam.c. The previous trick of using incompatible
6339 decls in different modules does not conform to the C standard.
6340 All callers of tparam changed to use tparam's actual API.
6341 * tparam.c (tparam1, tparam, tgoto):
6342 Use const pointers where appropriate.
6344 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6345 * cm.h (struct cm): Likewise.
6346 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6347 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6348 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6349 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6350 (turn_on_face, init_tty): Likewise.
6351 * termchar.h (struct tty_display_info): Likewise.
6353 * term.c (term_mouse_position): Rename local to avoid shadowing.
6355 * alloc.c (mark_ttys): Move decl from here ...
6356 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6358 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6360 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6362 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6364 * search.c (compile_pattern_1): Remove argument regp, unused since
6365 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6366 (compile_pattern): Don't pass it.
6368 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6370 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6371 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6373 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6375 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6377 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6378 gdk_window_get_screen, gdk_window_get_geometry,
6379 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6380 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6381 (xg_get_pixbuf_from_pixmap): New function.
6382 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6383 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6384 Call xg_get_pixbuf_from_pixmap instead of
6385 gdk_pixbuf_get_from_drawable.
6386 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6387 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6388 (xg_check_special_colors): Use GtkStyleContext and its functions
6390 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6391 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6392 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6393 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6394 Call gtk_widget_get_preferred_size.
6395 (xg_frame_resized): gdk_window_get_geometry only takes 5
6397 (xg_win_to_widget, xg_event_is_for_menubar):
6398 Call gdk_x11_window_lookup_for_display.
6399 (xg_set_widget_bg): New function.
6400 (delete_cb): New function.
6401 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6402 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6403 (xg_set_background_color): Call xg_set_widget_bg.
6404 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6405 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6406 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6407 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6409 (update_frame_tool_bar): Call gtk_widget_hide.
6410 (xg_initialize): Use GDK_KEY_g.
6412 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6414 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6416 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6417 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6418 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6420 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6422 * w32xfns.c (select_palette): Check success of RealizePalette against
6423 GDI_ERROR, not zero.
6425 See ChangeLog.11 for earlier changes.
6431 Copyright (C) 2011 Free Software Foundation, Inc.
6433 This file is part of GNU Emacs.
6435 GNU Emacs is free software: you can redistribute it and/or modify
6436 it under the terms of the GNU General Public License as published by
6437 the Free Software Foundation, either version 3 of the License, or
6438 (at your option) any later version.
6440 GNU Emacs is distributed in the hope that it will be useful,
6441 but WITHOUT ANY WARRANTY; without even the implied warranty of
6442 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6443 GNU General Public License for more details.
6445 You should have received a copy of the GNU General Public License
6446 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.