1 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
3 EMACS_TIME simplification (Bug#11875).
4 This replaces macros (which typically do not work in GDB)
5 with functions, typedefs and enums, making the code easier to debug.
6 The functional style also makes code easier to read and maintain.
7 * systime.h: Include <sys/time.h> on all hosts, not just if
8 WINDOWSNT, since 'struct timeval' is needed in general.
9 (EMACS_TIME): Now a typedef, not a macro.
10 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
12 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
13 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
14 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
15 (EMACS_TIME_LE): Now functions, not macros.
16 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
17 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
18 which are not functions. All uses rewritten to use:
19 (make_emacs_time): New function.
20 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
21 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
22 not functions. All uses rewritten to use the following, respectively:
23 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
24 (add_emacs_time, sub_emacs_time): New functions.
25 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
26 * fileio.c (Fcopy_file):
27 * xterm.c (XTflash): Get the current time closer to when it's used.
28 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
30 * bytecode.c (targets): Suppress -Woverride-init warnings.
32 Simplify by avoiding confusing use of strncpy etc.
33 * doc.c (Fsnarf_documentation):
34 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
35 * frame.c (Fmake_terminal_frame):
36 * gtkutil.c (get_utf8_string):
38 * nsmenu.m (ns_update_menubar):
40 Prefer memcpy to strncpy and strncat when either will do.
41 * fileio.c (Fsubstitute_in_file_name):
42 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
43 (menu_separator_name_p):
44 * nsmenu.m (ns_update_menubar):
45 Prefer memcmp to strncmp when either will do.
46 * nsterm.m: Include <ftoastr.h>.
48 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
49 Prefer snprintf to strncpy.
50 * nsterm.m (ns_term_init):
51 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
52 * nsterm.m (ns_term_init):
53 Avoid the need for strncpy, by using build_string or
54 make_unibyte_string directly. Use dtoastr, not snprintf.
55 * process.c (Fmake_network_process): Diagnose service names that
56 are too long, rather than silently truncating them or creating
57 non-null-terminated names.
58 (Fnetwork_interface_info): Likewise, for interface names.
59 * sysdep.c (system_process_attributes) [GNU_LINUX]:
60 Prefer sprintf to strncat.
61 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
62 Prefer vsnprintf to vsprintf + strncpy.
64 2012-07-10 Glenn Morris <rgm@gnu.org>
66 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
67 Clarify fallback case.
69 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
71 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
72 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
73 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
74 * w32menu.c, window.c, xmenu.c: Changed to use XCAR and XCDR
75 where argument type is known to be a Lisp_Cons.
77 2012-07-10 Tom Tromey <tromey@redhat.com>
79 * bytecode.c (BYTE_CODE_THREADED): New macro.
80 (BYTE_CODES): New macro. Replaces all old byte-code defines.
81 (enum byte_code_op): New type.
82 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
83 (exec_byte_code): Use them. Use token threading when applicable.
85 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
87 Optimize pure C strings initialization.
88 * lisp.h (make_pure_string): Fix prototype.
89 (build_pure_c_string): New function, defined as static inline. This
90 provides a better opportunity to optimize away calls to strlen when
91 the function is called with compile-time constant argument.
92 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
93 argument, adjust users accordingly. Use build_pure_c_string where
95 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
96 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
97 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
99 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
101 Avoid calls to strlen in miscellaneous functions.
102 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
103 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
104 * lread.c (openp): Likewise.
106 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
108 Avoid calls to strlen in path processing functions.
109 * fileio.c (file_name_as_directory): Add comment. Change to add
110 srclen argument and return the length of result. Adjust users
112 (directory_file_name): Fix comment. Change to add srclen argument,
113 swap 1st and 2nd arguments to obey the common convention. Adjust
115 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
117 2012-07-10 Glenn Morris <rgm@gnu.org>
119 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
120 Move PENDING_OUTPUT_COUNT definition to configure.
122 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
123 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
124 * s/gnu.h (DATA_START): Move definitions to configure.
126 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
127 We include usg5-4-common.h, which defines them both.
129 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
130 O_RDONLY already includes it).
132 Stop ns builds setting the EMACSLOADPATH environment variable.
133 * nsterm.m (ns_load_path): Rename from ns_init_paths.
134 Now it does not set EMACSLOADPATH, just returns the load-path string.
135 * nsterm.h: Update accordingly.
136 * lread.c [HAVE_NS]: Include nsterm.h.
137 (init_lread) [HAVE_NS]: Use ns_load_path.
138 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
140 2012-07-09 Glenn Morris <rgm@gnu.org>
142 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
143 since the included bsd-common.h does so.
145 Stop ns builds setting the EMACSPATH environment variable.
146 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
147 (ns_init_paths): Do not set EMACSPATH.
148 * nsterm.h (ns_exec_path): Add it.
149 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
152 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
154 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
156 * process.c (wait_reading_process_output): 'waitchannels' was unset
157 when read_kbd || !NILP (wait_for_cell); fix this.
159 Add GCC-style 'const' attribute to functions that can use it.
160 * character.h (char_resolve_modifier_mask):
161 * keyboard.h (make_ctrl_char):
162 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
163 (init_character_once, next_almost_prime, init_fns, init_image)
164 (flush_pending_output, init_sound):
165 * mem-limits.h (start_of_data):
166 * menu.h (finish_menu_items):
168 * emacs.c (DEFINE_DUMMY_FUNCTION):
169 Declare the dummy function with ATTRIBUTE_CONST.
170 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
171 Add decls with ATTRIBUTE_CONST.
173 Minor improvements to make_formatted_string.
174 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
175 where int is good enough, as vsprintf returns an int.
176 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
178 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
180 Use make_formatted_string to avoid double length calculation.
181 * lisp.h (make_formatted_string): New prototype.
182 * alloc.c (make_formatted_string): New function.
183 * buffer.c (Fgenerate_new_buffer_name): Use it.
184 * dbus.c (syms_of_dbusbind): Likewise.
185 * editfns.c (Fcurrent_time_zone): Likewise.
186 * filelock.c (get_boot_time): Likewise.
187 * frame.c (make_terminal_frame, set_term_frame_name)
188 (x_report_frame_params): Likewise.
189 * image.c (gs_load): Likewise.
190 * minibuf.c (get_minibuffer): Likewise.
191 * msdos.c (dos_set_window_size): Likewise.
192 * process.c (make_process): Likewise.
193 * xdisp.c (ensure_echo_area_buffers): Likewise.
194 * xsettings.c (apply_xft_settings): Likewise.
196 2012-07-09 Glenn Morris <rgm@gnu.org>
198 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
199 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
200 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
201 * nsterm.h (ns_etc_directory): Add it.
202 * callproc.c [HAVE_NS]: Include nsterm.h.
203 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
205 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
207 Move marker debugging code under MARKER_DEBUG.
208 * marker.c (MARKER_DEBUG): Move marker debugging code under
209 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
210 for bootstrap with --enable-checking (~3x slowdown reported
211 by Juanma Barranquero <lekktu@gmail.com>).
212 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
214 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
216 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
217 See <http://bugs.gnu.org/11825#29>.
219 2012-07-08 Eli Zaretskii <eliz@gnu.org>
221 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
222 has no font, use the frame's font. (Bug#11813)
223 (display_line): Add commentary about displaying truncation glyphs
225 (produce_special_glyphs): Move here from term.c.
227 * term.c (produce_special_glyphs): Move to xdisp.c.
229 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
232 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
234 * xdisp.c (display_line): Avoid warning about implicit declaration
237 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
239 * lisp.h: Remove empty conditional.
241 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
243 * lread.c (load_path_check): Now static.
245 Fix some minor --with-ns problems found by static checking.
246 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
247 (x_set_font) [!HAVE_X_WINDOWS]:
248 * image.c (xpm_load_image) [HAVE_NS]:
249 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
250 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
252 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
253 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
254 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
255 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
256 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
257 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
258 Fix pointer signedness problem.
259 * xfaces.c (FRAME_X_FONT_TABLE):
260 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
262 2012-07-07 Glenn Morris <rgm@gnu.org>
264 * lread.c (load_path_check): New function, split from init_lread.
265 (init_lread): Reorganize. Motivation:
266 If EMACSLOADPATH is set, check/warn about that rather than the
267 defaults, which we are not going to use. Hence we can remove
268 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
269 Don't warn if site-lisp directories are missing.
270 If not installed, start from a blank load-path, since
271 PATH_LOADSEARCH refers to the eventual installation directories.
273 2012-07-07 Eli Zaretskii <eliz@gnu.org>
275 Support truncation and continuation glyphs on GUI frames, when
276 fringes are disabled. (Bug#11832)
277 * xdisp.c (init_iterator): Get dimensions of truncation and
278 continuation glyphs even if on GUI frames. Adjust
279 it->last_visible_x on GUI frames when the left or right fringes,
281 (start_display, move_it_in_display_line_to): Handle the case of a
282 GUI frame without a fringe to display continuation or truncation
284 (insert_left_trunc_glyphs): Support GUI frames: make sure
285 truncation glyphs overwrite enough glyphs from the current line to
286 have sufficient space in pixels.
287 (display_line): Support truncation and continuation glyphs on GUI
288 frames. If some spare pixels are left on the line after inserting
289 the truncation glyphs, fill that space with a stretch glyph of a
290 suitably computed width.
292 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
293 produce_glyphs, to support GUI sessions.
295 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
297 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
299 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
301 Do not require float-time's arg to fit in time_t (Bug#11825).
302 This works better on hosts where time_t is unsigned, and where
303 float-time is applied to the (negative) difference between two times.
304 * editfns.c (decode_time_components): Last arg is now double *,
305 not int *, and means to store all the result as a double, without
306 worrying about whether the seconds part fits in time_t.
308 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
310 (Ffloat_time): Do not fail merely because the specified time falls
311 outside of time_t range.
313 2012-07-07 Glenn Morris <rgm@gnu.org>
315 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
316 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
317 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
319 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
321 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
324 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
326 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
328 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
329 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
330 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
331 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
332 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
333 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
335 * xfont.c (compare_font_names): Redo to omit the need for casts.
337 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
339 * xfns.c (Fx_change_window_property): Doc fix.
340 * w32fns.c (Fx_change_window_property): Doc fix.
342 * w32fns.c (Fx_window_property): Accept the same arguments as the
343 X Windows version. Doc fix.
344 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
346 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
347 Eli Zaretskii <eliz@gnu.org>
349 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
350 Windows-specific code from nt/config.nt moved here.
351 Obsolete settings removed.
353 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
355 * process.c: Avoid unnecessary calls to gettime.
356 (wait_reading_process_output): Don't get the time of day
357 when gobbling data immediately and not waiting, as there's no need
358 for it in that case. This removes a FIXME.
360 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
362 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
363 is defined (Bug#11768).
365 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
367 Fix marker debugging code.
368 * marker.c (byte_char_debug_check): Do not perform the check
369 if buffer is not multibyte.
370 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
371 Call byte_char_debug_check with correct arguments.
373 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
375 Compile marker debugging code only if ENABLE_CHECKING is defined.
376 * marker.c (byte_char_debug_check, count_markers):
377 Use only if ENABLE_CHECKING is defined.
378 (byte_debug_flag): Remove.
379 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
380 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
382 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
384 Avoid code repetition in marker-related functions.
385 * marker.c (attach_marker): New function.
386 (Fset_marker, set_marker_restricted, set_marker_both)
387 (set_marker_restricted_both): Use it.
388 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
389 Consistently rename charno to charpos.
390 (marker_position): Add eassert.
391 (marker_byte_position): Convert to eassert.
393 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
395 Simplify list operations in unchain_overlay and unchain_marker.
396 * buffer.c (unchain_overlay): Simplify. Add comment.
397 * marker.c (unchain_marker): Simplify. Fix comments.
399 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
401 Introduce fast path for the widely used marker operation.
402 * alloc.c (build_marker): New function.
403 * lisp.h (build_marker): New prototype.
404 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
405 * composite.c (autocmp_chars): Likewise.
406 * editfns.c (buildmark): Remove.
407 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
408 (save_restriction_save): Use build_marker.
409 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
410 * window.c (save_window_save): Likewise.
412 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
414 Do not use Fdelete_overlay in delete_all_overlays
415 to avoid redundant calls to unchain_overlay.
416 * buffer.c (drop_overlay): New function.
417 (delete_all_overlays, Fdelete_overlay): Use it.
418 * minibuf.c (get_minibuffer): Fix comment.
420 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
422 Port to OpenBSD 5.1 amd64.
423 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
424 This is needed for OpenBSD, and should be harmless on all BSD systems.
425 Also, include <sys/sysctl.h>, as it should be available on all
426 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
427 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
428 use p_pid member, not kp_proc.pid.
430 2012-07-06 Glenn Morris <rgm@gnu.org>
432 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
434 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
436 More xmalloc and related cleanup.
437 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
438 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
439 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
440 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
441 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
442 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
443 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
444 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
445 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
447 Omit needless casts involving void * pointers and allocation.
448 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
449 as the former is more robust if P's type is changed.
450 Prefer xzalloc to xmalloc + memset 0.
451 Simplify malloc-or-realloc to realloc.
452 Don't worry about xmalloc returning a null pointer.
453 Prefer xstrdup to xmalloc + strcpy.
454 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
456 * keyboard.c (apply_modifiers_uncached): Prefer local array to
457 alloca of a constant.
459 2012-07-05 Eli Zaretskii <eliz@gnu.org>
461 * xdisp.c (display_line): Fix horizontal pixel coordinates when
462 hscroll is larger than the line width. Fixes long and futile
463 looping inside extend_face_to_end_of_line (on a TTY) producing
464 glyphs that are not needed and thrown away.
466 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
468 * marker.c (set_marker_restricted_both): Simplify by using
471 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
473 * editfns.c (region_limit): Simplify by using clip_to_bounds.
475 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
477 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
478 not defined (Bug#11768).
479 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
480 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
481 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
482 followed by gtk_box_set_homogeneous (Bug#11768).
483 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
484 (update_theme_scrollbar_width, xg_create_scroll_bar):
485 Use gtk_scrollbar_new (Bug#11768).
486 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
487 (is_box_type): New function (Bug#11768).
488 (xg_tool_item_stale_p): Call is_box_type.
489 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
490 with default display (Bug#11768).
492 2012-07-05 Eli Zaretskii <eliz@gnu.org>
494 * xdisp.c (window_hscroll_limited): New function.
495 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
496 coordinates when window's hscroll is set to insanely large
499 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
501 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
502 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
504 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
507 * lisp.h (xzalloc): New prototype. Omit needless casts.
508 * alloc.c (xzalloc): New function. Omit needless casts.
509 * charset.c: Omit needless casts. Convert all calls to
510 xmalloc with following memset to xzalloc.
511 * dispnew.c: Likewise.
512 * fringe.c: Likewise.
516 * w32fns.c: Likewise.
517 * w32font.c: Likewise.
518 * w32term.c: Likewise.
519 * xfaces.c: Likewise.
522 * atimer.c: Omit needless casts.
523 * buffer.c: Likewise.
524 * callproc.c: Likewise.
526 * coding.c: Likewise.
527 * composite.c: Likewise.
529 * doprnt.c: Likewise.
530 * editfns.c: Likewise.
533 * filelock.c: Likewise.
535 * gtkutil.c: Likewise.
536 * keyboard.c: Likewise.
539 * minibuf.c: Likewise.
542 * process.c: Likewise.
543 * region-cache.c: Likewise.
544 * search.c: Likewise.
545 * sysdep.c: Likewise.
546 * termcap.c: Likewise.
547 * terminal.c: Likewise.
548 * tparam.c: Likewise.
549 * w16select.c: Likewise.
551 * w32reg.c: Likewise.
552 * w32select.c: Likewise.
553 * w32uniscribe.c: Likewise.
554 * widget.c: Likewise.
558 * xselect.c: Likewise.
560 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
562 * fileio.c (time_error_value): Check the right error number.
563 Problem reported by Troels Nielsen in
564 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
566 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
568 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
569 This should be fixed in a better way; see Eli Zaretskii in
570 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
571 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
573 * fileio.c (time_error_value): Rename from special_mtime.
574 The old name's problems were noted by Eli Zaretskii in
575 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
577 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
578 This variable's comment says Emacs needs at least one GDB-visible
579 symbol of type enum pvec_type, to work around GDB problems.
580 The symbol's value doesn't matter.
582 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
583 that causes compilation to fail on pre-C99 compilers.
585 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
587 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
588 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
590 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
592 * buffer.c (init_buffer_once): Fix initialization of
593 headers for buffer_defaults and buffer_local_symbols.
594 Reported by Juanma Barranquero <lekktu@gmail.com>.
596 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
598 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
599 * lisp.h (enum pvec_type): Use fewer bits.
600 (PSEUDOVECTOR_SIZE_BITS): New constant.
601 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
602 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
604 (PSEUDOVECTOR_TYPEP): New macro.
605 (TYPED_PSEUDOVECTORP): Use it.
606 * fns.c (internal_equal): Adapt code to extract pvectype.
607 * emacs.c (gdb_pvec_type): Update type.
608 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
609 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
610 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
611 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
612 (sweep_vectors): Use it. Use local var `total_bytes' instead of
613 abusing vector->header.next.nbytes.
614 (live_vector_p): Use PVEC_TYPE.
615 (mark_object): Adapt code to extract pvectype. Use switch.
617 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
619 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
620 Tighten new eassert a bit.
622 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
624 Fix compilation with --enable-gcc-warnings and -O1
626 * doprnt.c (doprnt): Change type of tem to int, initialize
627 to avoid compiler warning. Add eassert.
628 * search.c (simple_search): Initialize match_byte to avoid
629 compiler warning. Add eassert.
631 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
633 Avoid weird behavior with large horizontal scrolls.
634 Without this change, for example, large hscroll values would
635 mess up Emacs's display on Fedora 15 x86, presumably due to
636 overflows in int calculations in the display code.
637 Also, if buffers had long lines, Emacs would freeze.
638 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
639 (set_window_hscroll): New function, containing the old guts of
640 Fset_window_hscroll. Return the clipped value.
641 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
642 This avoids the need to check against PTRDIFF_MAX.
644 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
646 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
648 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
650 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
652 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
653 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
654 since GCC 4.4.6 issues a bogus warning for them.
656 Fix bugs in file timestamp newness comparisons.
657 * fileio.c (Ffile_newer_than_file_p):
658 * lread.c (Fload): Use full timestamp resolution of files,
659 not just the 1-second resolution, so that files that are only
660 slightly newer still count as newer.
661 * fileio.c (Ffile_newer_than_file_p): Don't assume file
662 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
664 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
666 * fileio.c: Improve handling of file time marker. (Bug#11852)
667 (special_mtime): New function.
668 (Finsert_file_contents, Fverify_visited_file_modtime):
669 Use it to set special mtime values consistently.
671 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
673 * fileio.c (Finsert_file_contents): Properly handle st_mtime
674 marker for non-existing file. (Bug#11852)
676 2012-07-03 Glenn Morris <rgm@gnu.org>
678 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
679 and did not make it into globals.h).
681 2012-07-03 Tom Tromey <tromey@redhat.com>
683 * window.c (Fset_window_margins, Fset_window_fringes)
684 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
685 * textprop.c (Fprevious_property_change): No longer static.
686 * syntax.c (Fsyntax_table_p): No longer static.
687 * process.c (Fget_process, Fprocess_datagram_address): No longer
689 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
690 * keyboard.c (Fcommand_execute): No longer static.
692 * insdel.c (Fcombine_after_change_execute): No longer static.
693 * image.c (Finit_image_library): No longer static.
694 * fileio.c (Fmake_symbolic_link): No longer static.
695 * eval.c (Ffetch_bytecode): No longer static.
696 * editfns.c (Fuser_full_name): No longer static.
697 * doc.c (Fdocumentation_property, Fsnarf_documentation):
699 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
701 * dired.c (Ffile_attributes): No longer static.
702 * composite.c (Fcomposition_get_gstring): No longer static.
703 * callproc.c (Fgetenv_internal): No longer static.
705 * ccl.h: Remove EXFUNs.
706 * buffer.h: Remove EXFUNs.
707 * dispextern.h: Remove EXFUNs.
708 * intervals.h: Remove EXFUNs.
709 * fontset.h: Remove EXFUN.
710 * font.h: Remove EXFUNs.
711 * dosfns.c (system_process_attributes): Remove EXFUN.
712 * keymap.h: Remove EXFUNs.
713 * lisp.h: Remove EXFUNs.
714 * w32term.h: Remove EXFUNs.
715 * window.h: Remove EXFUNs.
716 * xsettings.h: Remove EXFUN.
717 * xterm.h: Remove EXFUN.
719 2012-07-03 Glenn Morris <rgm@gnu.org>
721 * lisp.h (Frandom): Make it visible to C.
722 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
723 buffer for invisible buffers. (Bug#1229)
725 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
727 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
728 values which aren't power of 2.
729 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
730 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
733 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
735 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
737 * alloc.c (mark_object): Revert part of last patch to use `switch'.
739 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
741 * alloc.c (allocate_vector_block): Remove redundant
742 calls to mallopt if DOUG_LEA_MALLOC is defined.
743 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
744 avoid calls to mallopt if zero_vector is returned.
746 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
748 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
749 is enabled, avoid dereferencing NULL current_sblock if
752 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
754 Cleanup basic buffer management.
755 * buffer.h (struct buffer): Change layout to use generic vector
756 marking code. Fix some comments. Change type of 'clip_changed'
757 to bitfield. Remove unused #ifndef old.
758 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
759 (GET_OVERLAYS_AT): Fix indentation.
760 (for_each_per_buffer_object_at): New macro.
761 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
762 (Fbuffer_local_variables): Use it.
763 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
764 * alloc.c (allocate_buffer): Adjust to match new layout of
765 struct buffer. Fix comment.
766 (mark_overlay): New function.
767 (mark_buffer): Use it. Use mark_vectorlike to mark normal
768 Lisp area of struct buffer.
769 (mark_object): Use it. Adjust marking of misc objects
770 and related comments.
772 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
774 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
775 wrapper that is not needed because the wrapped code is a no-op (zero
776 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
777 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
779 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
781 * alloc.c (mark_buffer): Simplify. Remove prototype.
782 (mark_object): Add comment. Reorganize marking of vector-like
783 objects. Use CHECK_LIVE for all vector-like objects except buffers
784 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
785 redundant calls to mark_vectorlike for bool vectors.
787 2012-06-30 Glenn Morris <rgm@gnu.org>
789 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
791 * epaths.in (PATH_SITELOADSEARCH): New.
792 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
793 This is rather than relying on --enable-locallisppath elements
794 having "site-lisp" in their names. (Bug#10208#25, 11658)
796 2012-06-30 Eli Zaretskii <eliz@gnu.org>
798 * w32proc.c (sys_select): Accept and ignore one more argument.
800 * w32.c (emacs_gnutls_pull): Call select with one more argument.
802 * sysselect.h [DOS_NT]: Don't include sys/select.h.
803 (pselect) [!MS_DOS]: Redirect to sys_select.
805 * sysdep.c: Don't include dos.h and dosfns.h.
807 * process.c (sys_select):
808 * msdos.c (sys_select): Accept one more argument and ignore it.
810 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
811 adapt data types and code to that.
814 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
815 which clashes with the gnulib function of the same name.
817 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
819 * font.c (font_style_to_value, font_style_symbolic)
820 (font_prop_validate_style): Add type checks for values in
823 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
825 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
828 2012-06-29 Eli Zaretskii <eliz@gnu.org>
830 * xdisp.c (try_window_id): Undo last change.
832 * w32.c (getwd): Adjust commentary about startup_dir.
833 (init_environment): Always call sys_access, even in non-MSVC
834 builds. Don't chdir to the directory of the Emacs executable.
835 This undoes code from 1997 which was justified by the need to
836 "avoid conflicts when removing and renaming directories". But its
837 downside was that every relative file name was being interpreted
838 relative to the directory of the Emacs executable, which can never
839 be TRT. In particular, it broke sys_access when called with
841 (sys_access): Map GetLastError to errno.
843 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
845 * window.h (struct window): Change type of 'fringes_outside_margins'
846 to bitfield. Fix comment. Adjust users accordingly.
847 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
849 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
852 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
854 * gnutls.c (emacs_gnutls_handshake):
855 Add QUIT to make the loop interruptible.
857 2012-06-29 Glenn Morris <rgm@gnu.org>
859 * charset.c (init_charset): Make lack of etc/charsets fatal.
861 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
863 * editfns.c (region_limit): Fix type mismatch.
865 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
867 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
868 undefined. Convert from xassert to eassert.
869 * nsmenu.m: Convert from xassert to eassert.
870 * nsterm.m: Likewise.
872 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
874 * editfns.c (region_limit): Clip to narrowing (bug#11770).
876 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
878 Avoid integer overflow on scroll-left and scroll-right.
879 * window.c (HSCROLL_MAX): New macro.
880 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
881 overflow when requested scroll falls outside ptrdiff_t range.
883 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
885 * window.h (struct window): Change type of 'hscroll',
886 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
887 'last_modified' and 'last_overlay_modified' to EMACS_INT.
888 Adjust users accordingly.
889 * xdisp.c (try_cursor_movement): Replace type check with eassert.
890 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
891 from EMACS_INT to ptrdiff_t.
892 (make_window): Omit redundant initialization.
894 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
896 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
898 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
900 * window.h (struct window): Change type of 'use_time' and
901 'sequence_number' from Lisp_Object to int.
902 * frame.c (make_frame): Adjust users accordingly.
903 * print.c (print_object): Likewise.
904 * window.c (select_window, Fwindow_use_time, make_parent_window)
905 (make_window): Likewise.
907 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
909 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
910 enabled with --enable-checking=[all,glyphs] configure option.
911 Fix GLYPH_DEBUG usage assuming that it may be undefined,
912 adjust comments accordingly.
913 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
914 undefined, adjust comments accordingly.
916 * scroll.c: Likewise.
917 * w32fns.c: Likewise.
918 * w32term.c: Likewise.
920 * xfaces.c: Likewise.
924 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
926 Generalize run-time debugging checks.
927 * dispextern.h (XASSERTS): Remove.
928 * fontset.c (xassert): Remove.
929 Convert from xassert to eassert.
930 * alloc.c: Convert from xassert to eassert.
932 * dispnew.c: Likewise.
934 * fringe.c: Likewise.
935 * ftfont.c: Likewise.
936 * gtkutil.c: Likewise.
938 * keyboard.c: Likewise.
940 * process.c: Likewise.
941 * scroll.c: Likewise.
944 * w32console.c: Likewise.
945 * w32fns.c: Likewise.
946 * w32term.c: Likewise.
947 * window.c: Likewise.
949 * xfaces.c: Likewise.
951 * xselect.c: Likewise.
954 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
956 * fns.c (maybe_resize_hash_table): Output message when growing the
959 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
961 * alloc.c (allocate_string_data): Remove dead code.
962 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
963 avoid GCC warning about unused macro.
965 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
967 * alloc.c (allocate_string): Omit intervals initialization.
968 * alloc.c (make_uninit_multibyte_string): Initialize intervals
969 as in make_pure_string and make_pure_c_string.
971 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
973 * alloc.c (allocate_string): Fix last change.
975 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
977 * alloc.c (allocate_string): Remove two redundant calls
978 to memset, add explicit initialization where appropriate.
980 2012-06-27 Glenn Morris <rgm@gnu.org>
982 * lisp.mk (lisp): Remove paths.elc.
984 2012-06-27 Chong Yidong <cyd@gnu.org>
986 * doc.c (Fsubstitute_command_keys): Fix punctuation.
988 2012-06-26 John Wiegley <johnw@newartisans.com>
990 * unexmacosx.c (copy_data_segment): Add two section names used
991 on Mac OS X Lion: __mod_init_func and __mod_term_func.
993 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
994 when building with Clang.
996 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
998 * eval.c (Fapply): Allow calling it with a single argument.
1000 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1002 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1003 _stricmp and _strnicmp.
1004 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1006 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1008 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1010 (allocate_process): Likewise for new process.
1011 (allocate_terminal): Change to use offsetof.
1012 (allocate_frame): Likewise.
1013 * frame.c (make_frame): Omit redundant initialization.
1014 * window.c (make_parent_window): Use memset.
1015 (make_window): Omit redundant initialization.
1016 * process.c (make_process): Omit redundant initialization.
1017 * terminal.c (create_terminal): Likewise.
1019 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1021 * term.c (delete_tty): Remove redundant call to memset.
1023 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1025 * alloc.c: Remove build_string.
1026 * lisp.h: Define build_string as static inline. This provides
1027 a better opportunity to optimize away calls to strlen when the
1028 function is called with compile-time constant argument.
1029 * image.c (imagemagick_error): Convert to build_string.
1030 * w32proc.c (sys_spawnve): Likewise.
1031 * xterm.c (x_term_init): Likewise.
1033 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1035 Use sprintf return value instead of invoking strlen on result.
1036 In the old days this wasn't portable, since some sprintf
1037 implementations returned char *. But they died out years ago and
1038 Emacs already assumes sprintf returns int.
1039 Similarly for float_to_string.
1040 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1041 * ccl.c (ccl_driver):
1042 * character.c (string_escape_byte8):
1043 * data.c (Fnumber_to_string):
1044 * doprnt.c (doprnt):
1045 * print.c (print_object):
1046 * xdisp.c (message_dolog):
1047 * xfns.c (syms_of_xfns):
1048 Use sprintf or float_to_string result to avoid need to call strlen.
1049 * data.c (Fnumber_to_string):
1050 Use make_unibyte_string, since the string must be ASCII.
1051 * lisp.h, print.c (float_to_string): Now returns int length.
1052 * term.c (produce_glyphless_glyph):
1053 Use sprintf result rather than recomputing it.
1055 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1056 * Makefile.in (ALL_CFLAGS):
1057 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1058 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1060 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1062 * dispextern.h (xstrcasecmp): Define to library function
1063 strcasecmp if available.
1064 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1066 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1068 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1069 Avoid comma operator.
1070 * menu.c (push_submenu_start, push_submenu_end)
1071 (push_left_right_boundary, push_menu_pane): Likewise.
1072 * msdos.c (dos_rawgetc): Likewise.
1074 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1076 * xfns.c (xic_create_fontsetname): Remove redundant calls
1079 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1081 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1082 sprintf already null-terminates its output.
1084 * xfns.c (x_window): Remove redundant cast.
1086 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1088 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1089 `const char *' to `char *' to avoid compiler warning.
1091 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1093 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1094 instead of truncating it to 63 (admittedly a generous limit).
1096 * process.c: Fix spelling and caps in comments.
1098 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1100 * emacs.c (setpgrp): Remove definition, unused.
1101 * sysdep.c (setpgrp): Remove definition, not used in this file.
1103 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1105 * makefile.w32-in: Update dependencies.
1107 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1109 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1110 (SYSTIME_H): Add nt/inc/sys/time.h.
1112 * systime.h [WINDOWSNT]: Include sys/time.h.
1114 * s/ms-w32.h (struct timespec): Definition moved from
1115 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1117 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1119 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1120 * buffer.h (buffer_slot_type_mismatch):
1121 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1122 * eval.c (unwind_to_catch):
1123 * image.c (my_png_error, my_error_exit):
1124 * keyboard.c (quit_throw_to_read_char, user_error)
1125 (Fexit_recursive_edit, Fabort_recursive_edit):
1126 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1127 (wrong_type_argument, buffer_overflow, __executable_start)
1128 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1129 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1130 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1132 (child_setup) [!DOS_NT]:
1133 * lread.c (end_of_file_error, invalid_syntax):
1134 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1135 * puresize.h (pure_write_error):
1136 * search.c (matcher_overflow):
1137 * sound.c (sound_perror, alsa_sound_perror):
1138 * sysdep.c, syssignal.h (croak):
1139 * term.c (maybe_fatal, vfatal):
1140 * textprop.c (text_read_only):
1141 * undo.c (user_error):
1142 * unexmacosx.c (unexec_error):
1143 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1144 Use _Noreturn rather than NO_RETURN.
1145 No need for separate decl merely because of _Noreturn.
1146 * sound.c (sound_warning, parse_sound):
1147 Remove unnecessary forward decls.
1149 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1151 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1152 * lisp.h (WAIT_READING_MAX): New macro.
1153 * dispnew.c (Fsleep_for, sit_for):
1154 * keyboard.c (kbd_buffer_get_event):
1155 * process.c (Faccept_process_output):
1156 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1157 This improves on the previous patch, which introduced a bug
1158 when time_t is unsigned and as wide as intmax_t.
1159 See <http://bugs.gnu.org/9000#51>.
1161 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1163 * dispnew.c (sit_for, Fsleep_for):
1164 * keyboard.c (kbd_buffer_get_event):
1165 * process.c (Faccept_process_output): Avoid compiler warnings when
1166 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1168 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1170 * makefile.w32-in: Update dependencies.
1172 * w32.c (ltime): Add return type and declare static.
1173 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1175 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1177 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1178 Privately reported by Herbert J. Skuhra.
1179 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1181 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1182 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1184 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1186 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1187 last argument of make_unibyte_string.
1189 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1190 language ID in the event parameters.
1192 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1193 event.code, not the obscure "character set ID".
1195 2012-06-23 Chong Yidong <cyd@gnu.org>
1197 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1199 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1201 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1202 * w32.c (fdutimens): New function.
1204 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1206 * s/ms-w32.h (pselect): Redirect to sys_select.
1208 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1210 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1211 in the logic of incrementing and decrementing the value of
1212 use_relocatable_buffers.
1214 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1216 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1217 Privately reported by Herbert J. Skuhra.
1218 [__FreeBSD__]: Remove "*/" typo after "#include".
1219 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1220 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1221 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1222 Don't assume EMACS_TIME and struct timeval are the same type.
1224 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1226 Support higher-resolution time stamps (Bug#9000).
1227 The time stamps are only nanosecond-resolution at the C level,
1228 since that's the best that any real-world system supports now.
1229 But they are picosecond-resolution at the Lisp level, as that's
1230 easy, and leaves room for future OS improvements.
1232 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1235 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1236 Don't get current time unless it's needed.
1238 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1239 now provides it if it's absent.
1240 (start_atimer): Port to higher-res time stamps.
1241 Check for time stamp overflow. Don't get current time more
1242 often than is needed.
1244 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1245 Include systime.h, not time.h.
1246 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1248 * dired.c: Include stat-time.h.
1249 (Ffile-attributes): File times now have higher resolution.
1251 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1252 (struct image): Timestamp now has higher resolution.
1254 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1255 has at least microseconds now. All uses removed.
1256 (update_frame, update_single_window, update_window, update_frame_1)
1257 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1259 * editfns.c (time_overflow): Now extern.
1260 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1261 (float-time, Fformat_time_string, Fcurrent_time_string)
1262 (Fcurrent_time_zone): Accept and generate higher-resolution
1264 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1265 (decode_time_components, lisp_seconds_argument): New functions.
1266 (make_time): Now static.
1267 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1268 Report an error if the time is invalid, rather than having the caller
1271 * fileio.c: Include <stat-time.h>
1272 (Fcopy_file): Copy higher-resolution time stamps.
1273 Prefer to set the time stamp via a file descriptor if that works.
1274 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1275 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1276 (Fvisited_file_modtime, Fset_visited_file_modtime):
1277 Support higher-resolution time stamps.
1279 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1281 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1283 * image.c (prepare_image_for_display, clear_image_cache)
1284 (lookup_image): Port to higer-resolution time stamps.
1286 * keyboard.c (start_polling, bind_polling_period):
1287 Check for time stamp overflow.
1288 (read_char, kbd_buffer_get_event, timer_start_idle)
1289 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1290 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1291 Port to higher-resolution time stamps. Do not assume time_t is signed.
1292 (decode_timer): New function. Timers are now vectors of length 9,
1293 not 8, to accommodate the picosecond component.
1294 (timer_check_2): Use it.
1296 * nsterm.m (select_timeout, timeval_subtract): Remove.
1297 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1298 as they're a bit more accurate and handle overflow better.
1299 (ns_select): Change prototype to be compatible with pselect.
1300 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1301 * nsterm.h (ns_select): Adjust prototype.
1303 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1304 us-resolution time stamps.
1305 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1307 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1309 * lisp.h (time_overflow): New decl.
1310 (wait_reading_process_output): First arg is now intmax_t, not int,
1311 to accommodate larger waits.
1313 * process.h (struct Lisp_Process.read_output_delay):
1314 Now counts nanoseconds, not microseconds.
1315 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1317 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1318 (wait_reading_process_output):
1319 Port to ns-resolution time stamps.
1320 (Faccept_process_output, wait_reading_process_output):
1321 Check for time stamp overflow. Do not assume time_t is signed.
1322 (select_wrapper): Remove; we now use pselect.
1323 (Fprocess_attributes): Now generates ns-resolution time stamps.
1325 * sysdep.c: Include utimens.h. Don't include utime.h
1326 or worry about struct utimbuf; gnulib does that for us now.
1327 (gettimeofday): Remove; gnulib provides a substitute.
1328 (make_timeval): New function.
1329 (set_file_times): Now sets ns-resolution time stamps.
1330 New arg FD; all uses changed.
1331 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1332 (system_process_attributes):
1333 Now returns ns-resolution time stamp. All uses changed.
1334 Check for time stamp overflow.
1336 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1337 provides a substitute now.
1339 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1340 since it guarantees struct timespec.
1341 (EMACS_TIME): Now struct timespec, so that we can support
1342 ns-resolution time stamps.
1343 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1344 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1345 (EMACS_USECS): Remove.
1346 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1347 so multiply the arg by 1000 before storing it.
1348 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1350 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1351 Port to ns-resolution time stamps.
1352 (EMACS_TIME_NEG_P): Remove; replaced by....
1353 (EMACS_TIME_SIGN): New macro.
1354 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1355 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1356 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1357 (make_timeval, make_lisp_time, decode_time_components): New decls.
1358 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1359 that it mishandled time_t overflow. You can't compare by subtracting!
1360 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1361 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1363 * term.c: Include <sys/time.h>.
1364 (timeval_to_Time): New function, for proper overflow wraparound.
1365 (term_mouse_position, term_mouse_click): Use it.
1367 * undo.c (record_first_change): Support higher-resolution time stamps
1369 (Fprimitive_undo): Use them when restoring time stamps.
1371 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1372 (w32_get_internal_run_time):
1373 Port to higher-resolution Emacs time stamps.
1374 (ltime): Now accepts single 64-bit integer, as that's more convenient
1377 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1379 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1380 for compatibility with pselect. Support ns-resolution time stamps.
1382 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1384 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1385 Check for time stamp overflow, and support ns-resolution time stamps.
1387 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1388 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1389 (timeval_subtract): Remove; no longer needed.
1390 (XTflash, XTring_bell, x_wait_for_event):
1391 Port to ns-resolution time stamps. Don't assume time_t is signed.
1393 2012-06-22 Chong Yidong <cyd@gnu.org>
1395 * xdisp.c (x_consider_frame_title): Revert last change.
1397 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1399 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1400 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1401 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1402 staticidx goes up to 1597 out of 1600 = 0x640.)
1404 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1406 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1407 Otherwise, the umask might be mistakenly 0 while handling input signals.
1409 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1411 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1413 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1415 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1416 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1417 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1418 access to `contents' member of Lisp_Vector objects with AREF and ASET
1421 2012-06-19 Chong Yidong <cyd@gnu.org>
1423 * frame.c (delete_frame): When selecting a frame on a different
1424 text terminal, do not alter the terminal's top-frame.
1426 * xdisp.c (format_mode_line_unwind_data): Record the target
1427 frame's selected window and its terminal's top-frame.
1428 (unwind_format_mode_line): Restore them.
1429 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1431 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1432 since tty frames can be explicitly named.
1433 (prepare_menu_bars): Likewise.
1435 * term.c (Ftty_top_frame): New function.
1437 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1439 Port byte-code-meter to modern targets.
1440 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1441 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1442 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1443 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1444 (METER_1, METER_2): Simplify.
1446 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1448 * data.c (Fdefalias): Return `symbol' (bug#11686).
1450 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1452 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1453 gets killed during executing of this function (Bug#11665).
1454 Try to always return Qt when the buffer has been actually killed.
1455 (Vkill_buffer_query_functions): In doc-string say that functions
1456 run by this hook should not change the current buffer.
1458 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1460 Fix recently-introduced process.c problems found by static checking.
1461 * process.c (write_queue_push, write_queue_pop, send_process):
1462 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1463 (write_queue_pop): Fix pointer signedness problem.
1464 (send_process): Remove unused local.
1466 2012-06-17 Chong Yidong <cyd@gnu.org>
1468 * xdisp.c (redisplay_internal): No need to redisplay terminal
1469 frames that are not on top.
1471 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1473 * process.c (make_process): Initialize write_queue.
1474 (write_queue_push, write_queue_pop): New functions.
1475 (send_process): Use them to maintain correct ordering of process
1478 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1480 * lisp.h (eassert): Assume C89 or later.
1481 This removes the need for CHECK.
1482 (CHECK): Remove. Its comments about always evaluating its
1483 argument were confusing, as 'eassert' typically does not evaluate
1486 * coding.c (produce_chars): Use ptrdiff_t, not int.
1488 * xterm.c (x_draw_underwave): Check for integer overflow.
1489 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1491 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1493 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1494 referenced (Bug#11583).
1496 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1498 Implement wave-style variant of underlining.
1499 * dispextern.h (face_underline_type): New enum.
1500 (face): Add field for underline type.
1501 * nsterm.m (ns_draw_underwave): New function.
1502 (ns_draw_text_decoration): Use it.
1503 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1505 (x_draw_glyph_string): Use them.
1506 * xfaces.c (Qline, Qwave): New Lisp objects.
1507 (check_lface_attrs, merge_face_ref)
1508 (Finternal_set_lisp_face_attribute, realize_x_face):
1509 Handle wave-style underline face attributes.
1510 * xterm.c (x_draw_underwave): New function.
1511 (x_draw_glyph_string): Use it.
1513 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1515 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1516 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1517 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1518 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1519 ($(BLD)/w32select.$(O)): Update dependencies.
1521 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1523 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1524 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1525 * character.c (_fetch_multibyte_char_p): Remove.
1526 * alloc.c: Include "character.h" before "buffer.h".
1528 * buffer.c: Likewise.
1529 * bytecode.c: Likewise.
1530 * callint.c: Likewise.
1531 * callproc.c: Likewise.
1532 * casefiddle.c: Likewise.
1533 * casetab.c: Likewise.
1534 * category.c: Likewise.
1536 * coding.c: Likewise.
1537 * composite.c: Likewise.
1538 * dired.c: Likewise.
1539 * dispnew.c: Likewise.
1541 * dosfns.c: Likewise.
1542 * editfns.c: Likewise.
1543 * emacs.c: Likewise.
1544 * fileio.c: Likewise.
1545 * filelock.c: Likewise.
1547 * fontset.c: Likewise.
1548 * fringe.c: Likewise.
1549 * indent.c: Likewise.
1550 * insdel.c: Likewise.
1551 * intervals.c: Likewise.
1552 * keyboard.c: Likewise.
1553 * keymap.c: Likewise.
1554 * lread.c: Likewise.
1555 * macros.c: Likewise.
1556 * marker.c: Likewise.
1557 * minibuf.c: Likewise.
1558 * nsfns.m: Likewise.
1559 * nsmenu.m: Likewise.
1560 * print.c: Likewise.
1561 * process.c: Likewise.
1562 * regex.c: Likewise.
1563 * region-cache.c: Likewise.
1564 * search.c: Likewise.
1565 * syntax.c: Likewise.
1567 * textprop.c: Likewise.
1569 * unexsol.c: Likewise.
1570 * w16select.c: Likewise.
1571 * w32fns.c: Likewise.
1572 * w32menu.c: Likewise.
1573 * window.c: Likewise.
1574 * xdisp.c: Likewise.
1576 * xmenu.c: Likewise.
1578 * xselect.c: Likewise.
1580 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1582 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1583 If all the glyphs of the glyph row came from strings, and we have no
1584 cursor positioning clues, put the cursor on the first glyph of the
1586 (handle_face_prop): Use chunk-relative overlay string index when
1587 indexing into it->string_overlays array. (Bug#11653)
1588 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1589 the rightmost. (Bug#11720)
1591 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1593 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1594 (CATEGORY_MEMBER): Enforce 1/0 value.
1595 * category.c (_temp_category_set): Remove.
1597 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1599 * window.c (Fdelete_other_windows_internal)
1600 (Fdelete_window_internal): Don't access frame's mouse highlight
1601 info of the initial frame. (Bug#11677)
1603 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1605 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1606 Assume USE_2_TAGS_FOR_INTS.
1607 (xreload): Adjust $tagmask width to match recent lisp.h change.
1609 Simplify lisp.h in minor ways that should not affect code.
1610 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1611 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1612 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1613 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1614 (INTTYPEBITS): New macro, for clarity.
1615 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1616 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1617 Simplify now that USE_LSB_TAG is always defined.
1618 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1619 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1621 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1623 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1625 2012-06-13 Glenn Morris <rgm@gnu.org>
1627 * s/bsd-common.h (BSD4_3):
1628 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1630 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1632 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1635 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1637 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1638 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1639 * alloc.c (widen_to_Lisp_Object): Remove.
1640 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1641 * frame.c (delete_frame): Remove outdated comment.
1642 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1643 USE_LISP_UNION_TYPE.
1644 (Fw32_unregister_hot_key): Likewise.
1645 (Fw32_toggle_lock_key): Likewise.
1646 * w32menu.c (add_menu_item): Likewise.
1647 (w32_menu_display_help): Use XIL instead of checking
1648 USE_LISP_UNION_TYPE.
1649 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1650 (init_heap): Likewise.
1651 * w32term.c (w32_read_socket): Update comment.
1653 2012-06-13 Glenn Morris <rgm@gnu.org>
1655 * s/usg5-4-common.h, src/s/unixware.h:
1656 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1658 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1660 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1662 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1663 * alloc.c (make_number) [!defined make_number]:
1664 Remove, as lisp.h always defines this now.
1665 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1666 (roundup_size): Verify that it is a power of 2.
1667 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1668 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1669 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1670 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1671 USE_LSB_TAG now is always defined to be either 0 or 1.
1673 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1674 code works fine either way, and efficiency is not a concern here,
1675 as the union type is for debugging, not for production.
1676 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1677 Use an inline function on all platforms when using the union type,
1678 since this is simpler and 'static inline' can be used portably
1680 (LISP_INITIALLY_ZERO): New macro.
1681 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1682 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1684 2012-06-12 Glenn Morris <rgm@gnu.org>
1686 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1688 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1690 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1691 Move BROKEN_SIGIO to configure.
1693 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1694 Move NO_TERMIO to configure.
1696 2012-06-12 Chong Yidong <cyd@gnu.org>
1698 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1699 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1700 MagickExportImagePixels is undefined.
1702 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1704 * image.c (imagemagick_load_image): Remove unused label.
1706 2012-06-11 Glenn Morris <rgm@gnu.org>
1708 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1709 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1710 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1711 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1713 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1715 * alloc.c (make_byte_code): New function.
1716 (Fmake_byte_code): Use it. Don't purify here.
1717 * lread.c (read1): Use it as well to avoid extra allocation.
1719 2012-06-11 Chong Yidong <cyd@gnu.org>
1721 * image.c (imagemagick_load_image): Implement transparency.
1723 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1725 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1726 account for preceding backslashes. (Bug#11663)
1728 2012-06-09 Chong Yidong <cyd@gnu.org>
1730 * term.c: Support italics in capable terminals (Bug#9652).
1731 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1732 (turn_on_face): Output using TS_enter_italic_mode if available.
1733 Don't handle unused blinking and alt-charset cases.
1734 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1735 and tty_alt_charset_p cases.
1736 (tty_capable_p, init_tty): Support italics.
1738 * termchar.h (struct tty_display_info): Add field for italics.
1739 Remove unused blink field.
1741 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1744 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1745 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1746 tty_alt_charset_p. Add tty_italic_p.
1748 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1750 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1751 dbus_type_is_basic if available.
1752 (xd_extract_signed, xd_extract_unsigned): Rename from
1753 extract_signed and extract_unsigned, respectively. Adapt callers.
1755 2012-06-09 Chong Yidong <cyd@gnu.org>
1757 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1759 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1762 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1764 * xdisp.c (vmessage): Treat frame message as multibyte.
1765 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1766 would generate the diagnostic "Making \302\247 buffer-local while
1769 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1771 * dispnew.c (showing_window_margins_p): Undo last change, which
1772 was done due to an inadvertent commit.
1773 (adjust_frame_glyphs_for_frame_redisplay): Do call
1774 showing_window_margins_p.
1776 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1778 * eval.c (Fmake_var_non_special): New primitive.
1779 (syms_of_eval): Defsubr it.
1780 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1782 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1784 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1785 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1787 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1789 * alloc.c (allocate_vectorlike): Fix last change.
1791 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1793 Block-based vector allocation of small vectors.
1794 * lisp.h (struct vectorlike_header): New field `nbytes',
1795 adjust comment accordingly.
1796 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1797 to denote vector blocks. Adjust users (live_vector_p,
1798 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1799 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1800 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1801 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1802 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1803 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1804 (roundup_size): New constant.
1805 (struct vector_block): New data type.
1806 (vector_blocks, vector_free_lists, zero_vector): New variables.
1807 (all_vectors): Rename to `large_vectors'.
1808 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1809 (sweep_vectors): New functions.
1810 (allocate_vectorlike): Return `zero_vector' as the only vector of
1811 0 items. Allocate new vector from block if vector size is less than
1812 or equal to VBLOCK_BYTES_MAX.
1813 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1814 (init_alloc_once): Add call to init_vectors.
1816 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1818 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1820 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1822 * doprnt.c (doprnt): Truncate multibyte char correctly.
1823 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1824 would mishandle a string argument "Xc" if X was a multibyte
1825 character of length 2: it would truncate after X's first byte
1826 rather than including all of X.
1828 2012-06-06 Chong Yidong <cyd@gnu.org>
1830 * buffer.c (word_wrap): Doc fix.
1832 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1834 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1836 2012-06-03 Glenn Morris <rgm@gnu.org>
1838 * xdisp.c (tool-bar-style): Doc fix.
1840 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1842 * Makefile.in (PAXCTL): Define.
1843 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1844 binary via PaX flags if the paxctl utility is available.
1845 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1846 Restore PaX flags to their default. (Bug#11398)
1848 2012-06-03 Chong Yidong <cyd@gnu.org>
1850 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1853 2012-06-03 Chong Yidong <cyd@gnu.org>
1855 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1856 (note_mode_line_or_margin_highlight): If there is no help echo,
1857 use mode-line-default-help-echo. Handle the case where the mouse
1858 position is past the end of the mode line string.
1860 * buffer.c (buffer_local_value_1): New function, split from
1861 Fbuffer_local_value; can return Qunbound.
1862 (Fbuffer_local_value): Use it.
1863 (Vmode_line_format): Docstring tweaks.
1865 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1867 * sysdep.c (system_process_attributes): Improve comment.
1869 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1871 * keyboard.c: Export real-this-command to Elisp.
1872 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1873 and DEFVAR it. Update all users.
1875 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1877 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1879 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1880 Convert pctcpu and pctmem to Lisp float properly.
1881 Let the compiler fold better, as 100.0/0x8000 is exact.
1883 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1885 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1888 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1890 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1892 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1894 For a 'struct window', replace some Lisp_Object fields to
1895 bitfields where appropriate, remove unused fields.
1896 * window.h (struct window): Remove unused 'last_mark_x' and
1897 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1898 change it's type from Lisp_Object to bitfield.
1899 Change type of 'force_start', 'optional_new_start',
1900 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1901 fields from Lisp_Object to bitfield. Adjust users accordingly.
1903 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1905 Pacify gcc -Wdouble-precision when using Xaw.
1906 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1907 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1908 Use 'float' consistently, rather than 'float' in most places
1909 and 'double' in a couple of places.
1911 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1913 * xdisp.c (handle_stop): Detect whether we have overlay strings
1914 loaded by testing it->current.overlay_string_index to be
1915 non-negative, instead of checking whether n_overlay_strings is
1916 positive. (Bug#11587)
1918 2012-05-31 Chong Yidong <cyd@gnu.org>
1920 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1922 * doc.c (Fsubstitute_command_keys): Doc fix.
1924 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1926 * search.c (search_buffer): Remove calls to
1927 r_alloc_inhibit_buffer_relocation, as it is now called by
1928 maybe_unify_char, which was the cause of relocation of buffer text
1931 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1933 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1934 for the duration of call to load_charset, to avoid problems with
1935 callers of maybe_unify_char that access buffer text through C
1938 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1939 decrement the inhibition flag, instead of just setting or
1942 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1944 Remove obsolete '#define static' cruft.
1945 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1946 This #undef was "temporary" in 2000; it is no longer needed
1947 now that '#define static' has gone away.
1948 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1949 (gray_bitmap_bits): Remove; no longer needed.
1950 All uses replaced with definiens.
1951 * xterm.c: Include "bitmaps/gray.xbm".
1953 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1955 Clean up __executable_start, monstartup when --enable-profiling.
1956 The following changes affect the code only when profiling.
1957 * dispnew.c (__executable_start): Rename from safe_bcopy.
1958 Define only on platforms that need it.
1959 * emacs.c: Include <sys/gmon.h> when profiling.
1960 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1961 (__executable_start): Remove decl, since lisp.h does it now.
1962 (safe_bcopy): Remove decl; no longer has that name.
1963 (main): Coalesce #if into single bit of code, for simplicity.
1964 Cast pointers to uintptr_t, since standard libraries want integers
1966 * lisp.h (__executable_start): New decl.
1968 2012-05-31 Glenn Morris <rgm@gnu.org>
1970 * image.c (Fimagemagick_types): Doc fix.
1972 2012-05-30 Jim Meyering <meyering@redhat.com>
1974 * callproc.c (Fcall_process_region): Include directory component
1975 in mkstemp error message (Bug#11586).
1977 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1979 * alloc.c, lisp.h (make_pure_vector): Now static.
1981 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1983 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1984 Move to byte-run.el.
1985 (Fautoload): Do the hash-doc more carefully.
1986 * data.c (Fdefalias): Purify definition, except for keymaps.
1987 (Qdefun): Move from eval.c.
1988 * lisp.h (Qdefun): Remove.
1989 * lread.c (read1): Tiny simplification.
1991 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1993 Do not create empty overlays with the evaporate property (Bug#9642).
1994 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1995 Bug#9642, but explicitly check that the buffer the overlay would
1996 be moved to is live and rearrange lines to make sure that errors
1997 will not put the overlay in an inconsistent state.
1998 (Fdelete_overlay): Cosmetics.
2000 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2002 * w32term.c (my_bring_window_to_top): New function.
2003 (x_raise_frame): Use handle returned by DeferWindowPos, which
2004 could be different from the original one.
2005 Call my_bring_window_to_top instead of my_set_foreground_window.
2008 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2009 by calling BringWindowToTop.
2011 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2012 (WM_EMACS_END): Increase by one.
2014 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2016 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2017 This avoids undefined behavior that might cause the eassert
2018 to not catch an out-of-range value.
2020 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2022 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2023 Update dependencies.
2025 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2027 * bidi.c (bidi_mirror_char): Fix last change.
2029 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2031 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2032 when referring to sectname field in printf format.
2034 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2036 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2037 Only r_alloc_inhibit_buffer_relocation needed to be added;
2038 the others were already declared.
2040 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2041 before checking whether it's out of range. Put the check inside
2043 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2045 2012-05-27 Ken Brown <kbrown@cornell.edu>
2047 * callproc.c (Fcall_process): Restore a line that was accidentally
2048 commented out in the 2011-02-13 change (bug#11547).
2050 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2052 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2053 defined on ralloc.c.
2055 * buffer.c [REL_ALLOC]: Remove prototypes of
2056 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2057 they are now on lisp.h.
2059 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2061 * search.c (search_buffer): Use it to inhibit relocation of buffer
2062 text while re_search_2 is doing its job, because re_search_2 is
2063 passed C pointers to buffer text. (Bug#11519)
2065 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2068 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2069 state after an additional call to move_it_in_display_line_to, keep
2070 the values of it->max_ascent and it->max_descent found for the
2072 (pos_visible_p): Revert the comparison against bottom_y to what it
2073 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2076 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2078 Fix coding-related core dumps with gcc -ftrapv.
2079 The code was computing A - B, where A and B are pointers, and B is
2080 random garbage. This can lead to core dumps on platforms that
2081 have special pointer registers, and it also leads to core dumps on
2082 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2083 A - B only when B is initialized properly.
2084 * coding.c (coding_set_source, coding_set_destination): Return void.
2085 (coding_change_source, coding_change_destinations): New functions,
2086 with the old behaviors of coding_set_source and coding_set_destination.
2087 All callers that need an offset changed to use these new functions.
2089 2012-05-26 Glenn Morris <rgm@gnu.org>
2091 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2093 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2095 Extend mouse support on W32 text-mode console.
2096 * xdisp.c (draw_row_with_mouse_face):
2097 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2099 * w32console.c: Include window.h.
2100 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2102 (initialize_w32_display): Initialize mouse-highlight data.
2104 * w32inevt.c: Include termchar.h and window.h.
2105 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2106 moves, call note_mouse_highlight. If help_echo changed, call
2107 gen_help_event to produce help-echo message in the echo area.
2108 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2111 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2113 * lread.c (read1): Simplify slightly to avoid an overflow warning
2114 with GCC 4.7.0 on x86-64.
2116 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2118 * bidi.c (bidi_mirror_char): Revert last change: an int is
2119 definitely wide enough here.
2121 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2123 Fix integer width and related bugs (Bug#9874).
2124 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2125 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2126 (string_bytes, check_sblock, allocate_string_data):
2127 (compact_small_strings, Fmake_bool_vector, make_string)
2128 (make_unibyte_string, make_multibyte_string)
2129 (make_string_from_bytes, make_specified_string)
2130 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2131 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2134 (allocate_pseudovector):
2135 Use int, not EMACS_INT, where int is wide enough.
2136 (inhibit_garbage_collection, Fgarbage_collect):
2137 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2138 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2139 int might not be wide enough.
2140 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2141 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2142 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2143 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2144 (bidi_level_of_next_char, bidi_move_to_visually_next):
2145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2146 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2147 (Fkill_buffer, Fset_buffer_major_mode)
2148 (advance_to_char_boundary, Fbuffer_swap_text)
2149 (Fset_buffer_multibyte, overlays_at, overlays_in)
2150 (overlay_touches_p, struct sortvec, record_overlay_string)
2151 (overlay_strings, recenter_overlay_lists)
2152 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2153 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2154 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2155 (Foverlay_recenter, last_overlay_modification_hooks_used)
2156 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2158 (validate_region): Omit unnecessary test for b <= e,
2159 since that's guaranteed by the previous test.
2160 (adjust_overlays_for_delete): Avoid pos + length overflow.
2161 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2162 (report_overlay_modification):
2163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2164 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2165 Omit pointer cast, which isn't needed anyway, and doesn't work
2166 after the EMACS_INT -> ptrdiff_t change.
2167 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2168 * buffer.h: Adjust decls to match defn changes elsewhere.
2169 (struct buffer_text, struct buffer):
2170 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2171 Use EMACS_INT, not int, where int might not be wide enough.
2172 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2173 not int, to avoid needless 32-bit limit on 64-bit hosts.
2174 (exec_byte_code): Use tighter memory-full test, one that checks
2175 for alloca overflow. Don't compute the address of the object just
2176 before an array, as that's not portable. Use EMACS_INT, not
2177 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2178 * callint.c (Fcall_interactively):
2179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2180 * callproc.c (call_process_kill, Fcall_process):
2181 Don't assume pid_t fits into an Emacs fixnum.
2182 (call_process_cleanup, Fcall_process, child_setup):
2183 Don't assume pid_t fits into int.
2184 (call_process_cleanup, Fcall_process, delete_temp_file)
2185 (Fcall_process_region):
2186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2187 (Fcall_process): Simplify handling of volatile integers.
2188 Use int, not EMACS_INT, where int will do.
2189 * casefiddle.c (casify_object, casify_region, operate_on_word)
2190 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2192 (casify_object): Avoid integer overflow when overallocating buffer.
2193 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2194 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2195 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2196 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2197 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2198 integers are now checked earlier. All uses replaced with XINT.
2200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2201 For CCL_MapSingle, check that content and value are in int range.
2202 (ccl_driver, Fregister_code_conversion_map):
2203 Check that Vcode_version_map_vector is a vector.
2204 (resolve_symbol_ccl_program): Check that vector header is in range.
2205 Always copy the vector, so that we can check its contents reliably
2206 now rather than having to recheck each instruction as it's being
2207 executed. Check that vector words fit in 'int'.
2208 (ccl_get_compiled_code, Fregister_ccl_program)
2209 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2210 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2211 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2212 contents are in range.
2213 (Fccl_execute_on_string): Check that status is in range.
2214 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2215 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2216 Accept and return EMACS_INT, not int, because callers can pass values
2218 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2219 (multibyte_chars_in_text, parse_str_as_multibyte)
2220 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2221 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2222 (string_escape_byte8, Fget_byte):
2223 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2224 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2225 avoid mishandling large integers.
2226 * character.h: Adjust decls to match defn changes elsewhere.
2227 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2228 (Ffind_charset_region):
2229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2230 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2231 (load_charset_map_from_vector, Fdefine_charset_internal):
2232 Don't assume fixnum fits in int.
2233 (load_charset_map_from_vector, Fmap_charset_chars):
2234 Remove now-unnecessary CHECK_NATNUMs.
2235 (Fdefine_charset_internal): Check ranges here, more carefully.
2236 Don't rely on undefined behavior with signed left shift overflow.
2237 Don't assume unsigned int fits into fixnum, or that fixnum fits
2238 into unsigned int. Don't require max_code to be a valid fixnum;
2239 that's not true for gb10830 4-byte on a 32-bit host. Allow
2240 invalid_code to be a cons, for the same reason. Require code_offset
2241 to be a character. Avoid int overflow if max_char is close
2243 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2244 this is intended anyway and avoids some undefined behavior.
2245 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2246 INDEX_TO_CODE_POINT, as that's what it expects.
2247 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2248 * charset.h (DECODE_CHAR): Return int, not unsigned;
2249 this is what was intended anyway, and it avoids undefined behavior.
2250 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2251 integer-overflow issues.
2252 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2253 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2254 where the argument is EMACS_INT, and this behavior is not intended.
2255 * chartab.c (Fmake_char_table, Fset_char_table_range)
2256 (uniprop_get_decoder, uniprop_get_encoder):
2257 Don't assume fixnum fits in int.
2258 * cmds.c (move_point): New function, that does the gist of
2259 Fforward_char and Fbackward_char, but does so while checking
2260 for integer overflow more accurately.
2261 (Fforward_char, Fbackward_char): Use it.
2262 (Fforward_line, Fend_of_line, internal_self_insert)
2263 (internal_self_insert):
2264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2265 Fix a FIXME, by checking for integer overflow when calculating
2266 target_clm and actual_clm.
2267 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2268 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2269 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2270 (coding_alloc_by_making_gap, alloc_destination)
2271 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2272 (encode_coding_utf_16, detect_coding_emacs_mule)
2273 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2274 (detect_coding_iso_2022, decode_coding_iso_2022)
2275 (encode_invocation_designation, encode_designation_at_bol)
2276 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2277 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2278 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2279 (encode_coding_ccl, encode_coding_raw_text)
2280 (detect_coding_charset, decode_coding_charset)
2281 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2282 (produce_composition, produce_charset, produce_annotation)
2283 (decode_coding, handle_composition_annotation)
2284 (handle_charset_annotation, consume_chars, decode_coding_gap)
2285 (decode_coding_object, encode_coding_object, detect_coding_system)
2286 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2287 (code_convert_region, code_convert_string)
2288 (Fdefine_coding_system_internal)
2289 (coding_set_source, coding_set_destination):
2290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2291 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2292 (Fdefine_coding_system_internal):
2293 Don't assume fixnums fit in int.
2294 (decode_coding_gap, decode_coding_object, encode_coding_object)
2295 (Fread_coding_system, Fdetect_coding_region)
2296 (Funencodable_char_position, Fcheck_coding_systems_region)
2297 (get_translation, handle_composition_annotation, consume_chars):
2298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2299 (consume_chars): Rewrite to not calculate an address outside buffer.
2300 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2301 Don't access memory outside of the args array.
2302 (Fdefine_coding_system_internal): Check for charset-id overflow.
2303 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2304 result of ENCODE_CHAR.
2305 * coding.h: Adjust decls to match defn changes elsewhere.
2306 (struct coding_system):
2307 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2308 * composite.c (get_composition_id, find_composition)
2309 (run_composition_function, update_compositions)
2310 (compose_text, composition_gstring_put_cache)
2311 (composition_gstring_p, composition_gstring_width)
2312 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2313 (composition_compute_stop_pos, composition_reseat_it)
2314 (composition_update_it, struct position_record)
2315 (find_automatic_composition, composition_adjust_point)
2316 (Fcomposition_get_gstring, Ffind_composition_internal):
2317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2318 (update_compositions):
2319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2320 * composite.h: Adjust decls to match defn changes elsewhere.
2321 (struct composition):
2322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2323 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2324 Do not attempt to compute the address of the object just before a
2325 buffer; this is not portable.
2327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2328 (Faset): Use int, not EMACS_INT, where int is wide enough.
2329 (Fstring_to_number): Don't assume fixnums fit in int.
2330 (Frem): Don't assume arg is nonnegative.
2331 * dbusbind.c (xd_append_arg): Check for integers out of range.
2332 (Fdbus_call_method): Don't overflow the timeout int.
2333 (extract_signed, extract_unsigned): New functions.
2334 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2335 (xd_get_connection_references): Return ptrdiff_t, not int.
2337 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2338 (xd_read_message_1):
2339 Use int, not unsigned, where the dbus API uses int.
2340 (Fdbus_message_internal): Don't overflow mtype.
2341 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2342 * dired.c (directory_files_internal, file_name_completion, scmp)
2343 (file_name_completion_stat):
2344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2345 (file_name_completion): Don't overflow matchcount.
2346 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2347 * dispextern.h: Adjust decls to match defn changes elsewhere.
2348 (struct text_pos, struct glyph, struct bidi_saved_info)
2349 (struct bidi_string_data, struct bidi_it, struct composition_it)
2351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2352 (struct display_pos, struct composition_it, struct it):
2353 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2354 * dispnew.c (increment_matrix_positions)
2355 (increment_row_positions, mode_line_string)
2356 (marginal_area_string):
2357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2358 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2359 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2360 (duration_to_sec_usec): New function, to check for overflow better.
2361 (Fsleep_for, sit_for): Use it.
2362 * doc.c (get_doc_string, store_function_docstring):
2363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2364 (get_doc_string, Fsnarf_documentation):
2365 Use int, not EMACS_INT, where int is wide enough.
2367 Use SAFE_ALLOCA, not alloca.
2368 Check for overflow when converting EMACS_INT to off_t.
2369 * doprnt.c (doprnt):
2370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2371 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2372 Don't assume uid_t fits into fixnum.
2373 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2374 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2375 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2376 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2377 (general_insert_function)
2378 (Finsert_char, make_buffer_string, make_buffer_string_both)
2379 (update_buffer_properties, Fbuffer_substring)
2380 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2381 (Fsubst_char_in_region, check_translation)
2382 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2383 (transpose_markers, Ftranspose_regions):
2384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2385 (clip_to_bounds): Move to lisp.h as an inline function).
2386 (Fconstrain_to_field): Don't assume integers are nonnegative.
2387 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2388 (Fsubst_char_in_region, Fsave_restriction):
2389 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2390 (Femacs_pid): Don't assume pid_t fits into fixnum.
2391 (lo_time): Use int, not EMACS_INT, when int suffices.
2392 (lisp_time_argument): Check for usec out of range.
2393 (Fencode_time): Don't assume fixnum fits in int.
2394 (Fuser_login_name, Fuser_full_name): Signal an error
2395 if a uid argument is out of range, rather than relying on
2397 (Fformat_time_string): Remove now-unnecessary check.
2398 lisp_time_argument checks for out-of-range usec now.
2399 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2400 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2401 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2402 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2403 (init_cmdargs, Fdump_emacs):
2404 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2405 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2406 the bottom (typically) 32 bits of the fixnum.
2407 * eval.c (specpdl_size, call_debugger):
2408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2409 (when_entered_debugger, Fbacktrace_debug):
2410 Don't assume fixnum can fit in int.
2411 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2412 the object just before a buffer; this is not portable.
2413 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2414 (grow_specpdl, unbind_to):
2415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2416 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2417 (grow_specpdl): Simplify allocation by using xpalloc.
2418 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2419 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2420 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2422 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2425 (Fcopy_file, non_regular_nbytes, read_non_regular)
2426 (Finsert_file_contents):
2427 Use int, not EMACS_INT, where int is wide enough.
2428 (READ_BUF_SIZE): Verify that it fits in int.
2429 (Finsert_file_contents): Check that counts are in proper range,
2430 rather than assuming fixnums fit into ptrdiff_t etc.
2431 Don't assume fixnums fit into int.
2432 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2433 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2434 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2435 (string_char_to_byte, string_byte_to_char)
2436 (string_make_multibyte, string_to_multibyte)
2437 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2438 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2439 (substring_both, Fdelete, internal_equal, Ffillarray)
2440 (Fclear_string, mapcar1)
2441 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2442 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2443 (larger_vector, make_hash_table, maybe_resize_hash_table)
2444 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2445 (Fmaphash, secure_hash):
2446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2447 (concat): Check for string index and length overflow.
2448 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2451 (larger_vector): New API (vec, incr_min, size_max) replaces old
2452 one (vec, new_size, init). This catches size overflow.
2453 INIT was removed because it was always Qnil.
2454 All callers changed.
2455 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2456 the upper bound on a hash table index size.
2457 (make_hash_table, maybe_resize_hash_table): Use it.
2458 (secure_hash): Computer start_byte and end_byte only after
2459 they're known to be in ptrdiff_t range.
2460 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2461 (Ffont_get_glyphs, Ffont_at):
2462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2463 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2464 (Flist_fonts, Fopen_font):
2465 Don't assume fixnum can fit in int.
2466 (check_gstring): Don't assume index can fit in int.
2467 (font_match_p): Check that fixnum is a character, not a nonnegative
2468 fixnum, since the later code needs to stuff it into an int.
2469 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2470 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2471 conversion overflow issues.
2472 (Fopen_font): Check for integer out of range.
2473 (Ffont_get_glyphs): Don't assume index can fit in int.
2474 * font.h: Adjust decls to match defn changes elsewhere.
2475 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2477 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2478 printmax_t, where ptrdiff_t is wide enough.
2479 (Finternal_char_font):
2480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2481 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2482 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2483 (Fset_frame_position, x_set_frame_parameters)
2484 (x_set_line_spacing, x_set_border_width)
2485 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2486 Check that fixnums are in proper range for system types.
2487 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2489 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2490 Use SAFE_ALLOCA_LISP, not alloca.
2491 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2492 intptr_t is wide enough.
2493 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2494 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2495 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2496 Check for fixnum out of range.
2497 * ftfont.c (ftfont_list): Don't assume index fits in int.
2498 Check that fixnums are in proper range for system types.
2499 (ftfont_shape_by_flt):
2500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2501 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2503 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2504 Check that fixnums are in proper range for system types.
2505 * gnutls.h: Adjust decls to match defn changes elsewhere.
2506 * gtkutil.c (xg_dialog_run):
2507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2508 (update_frame_tool_bar):
2509 Check that fixnums are in proper range for system types.
2510 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2511 (lookup_image): Check that fixnums are in range for system types.
2512 * indent.c (last_known_column, last_known_column_point):
2513 (current_column_bol_cache):
2514 (skip_invisible, current_column, check_display_width):
2515 (check_display_width, scan_for_column, current_column_1)
2516 (Findent_to, Fcurrent_indentation, position_indentation)
2517 (indented_beyond_p, Fmove_to_column, compute_motion):
2518 (Fcompute_motion, Fvertical_motion):
2519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2520 (last_known_column_modified): Use EMACS_INT, not int.
2521 (check_display_width):
2523 Check that fixnums and floats are in proper range for system types.
2524 (compute_motion): Don't assume index or fixnum fits in int.
2525 (compute_motion, Fcompute_motion):
2526 Use int, not EMACS_INT, when it is wide enough.
2527 (vmotion): Omit local var start_hpos that is always 0; that way
2528 we don't need to worry about overflow in expressions involving it.
2529 * indent.h: Adjust decls to match defn changes elsewhere.
2531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2532 Use int, not EMACS_INT, where int is wide enough.
2533 Remove unused members ovstring_chars_done and tab_offset;
2535 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2536 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2537 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2538 (make_gap, copy_text, insert, insert_and_inherit)
2539 (insert_before_markers, insert_before_markers_and_inherit)
2540 (insert_1, count_combining_before, count_combining_after)
2541 (insert_1_both, insert_from_string)
2542 (insert_from_string_before_markers, insert_from_string_1)
2543 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2544 (adjust_after_replace, adjust_after_insert, replace_range)
2545 (replace_range_2, del_range, del_range_1, del_range_byte)
2546 (del_range_both, del_range_2, modify_region)
2547 (prepare_to_modify_buffer, signal_before_change)
2548 (signal_after_change, Fcombine_after_change_execute):
2549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2550 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2551 (balance_an_interval, split_interval_right, split_interval_left)
2552 (find_interval, next_interval, update_interval)
2553 (adjust_intervals_for_insertion, delete_node, delete_interval)
2554 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2555 (static_offset_intervals, offset_intervals)
2556 (merge_interval_right, merge_interval_left, make_new_interval)
2557 (graft_intervals_into_buffer, temp_set_point_both)
2558 (temp_set_point, set_point, adjust_for_invis_intang)
2559 (set_point_both, move_if_not_intangible, get_property_and_range)
2560 (get_local_map, copy_intervals, copy_intervals_to_string)
2561 (compare_string_intervals, set_intervals_multibyte_1):
2562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2563 * intervals.h: Adjust decls to match defn changes elsewhere.
2565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2566 * keyboard.c (this_command_key_count, this_single_command_key_start)
2567 (before_command_key_count, before_command_echo_length, echo_now)
2568 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2569 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2570 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2571 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2573 (last_non_minibuf_size, last_point_position, echo_truncate)
2574 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2575 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2576 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2577 (stuff_buffered_input):
2578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2579 (last_auto_save, command_loop_1, read_char):
2580 Use EMACS_INT, not int, to avoid integer overflow.
2581 (record_char): Avoid overflow in total_keys computation.
2582 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2583 * keyboard.h: Adjust decls to match defn changes elsewhere.
2584 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2585 (Fkey_description, Fdescribe_vector, Flookup_key):
2586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2587 (click_position): New function, to check that positions are in range.
2588 (Fcurrent_active_maps):
2590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2591 (Faccessible_keymaps, Fkey_description):
2592 (preferred_sequence_p):
2593 Don't assume fixnum can fit into int.
2594 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2595 Check for integer overflow in size calculations.
2596 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2597 avoid mishandling large integers.
2598 * lisp.h: Adjust decls to match defn changes elsewhere.
2599 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2600 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2601 (struct Lisp_Marker):
2602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2603 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2604 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2605 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2606 All callers changed.
2607 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2608 Assume the arg has valid form, since it always does.
2609 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2610 unsigned integer system type.
2611 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2612 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2614 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2615 (duration_to_sec_usec): New decl.
2616 * lread.c (read_from_string_index, read_from_string_index_byte)
2617 (read_from_string_limit, readchar, unreadchar, openp)
2618 (read_internal_start, read1, oblookup):
2619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2620 (Fload, readevalloop, Feval_buffer, Feval_region):
2621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2622 (openp): Check for out-of-range argument to 'access'.
2623 (read1): Use int, not EMACS_INT, where int is wide enough.
2624 Don't assume fixnum fits into int.
2625 Fix off-by-one error that can read outside a buffer.
2626 (read_filtered_event): Use duration_to_sec_usec
2627 to do proper overflow checking on durations.
2628 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2629 in size calculation.
2630 (Fexecute_kbd_macro):
2631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2632 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2633 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2634 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2635 (set_marker_both, set_marker_restricted_both, marker_position)
2636 (marker_byte_position, Fbuffer_has_markers_at):
2637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2638 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2639 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2640 It now merely ensures that the menu is large enough, without
2641 necessarily growing it, as this avoids some integer overflow issues.
2642 All callers changed.
2643 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2645 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2646 Use SAFE_ALLOCA_LISP, not alloca.
2647 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2648 to EMACS_INT. Check that fixnums are in proper range for system types.
2649 * minibuf.c (minibuf_prompt_width, string_to_object)
2650 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2651 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2653 (get_minibuffer, read_minibuf_unwind):
2654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2655 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2656 this simplifies overflow checking. All callers changed.
2657 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2660 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2661 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2662 Check that fixnums are in proper range for system types.
2663 (Fx_create_frame, Fx_show_tip):
2664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2665 * nsfont.m (ns_findfonts, nsfont_list_family):
2666 Don't assume fixnum fits in long.
2667 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2669 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2671 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2673 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2674 (PRINTDECLARE, PRINTPREPARE):
2675 (strout, print_string):
2676 (print, print_preprocess, print_check_string_charset_prop)
2678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2680 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2682 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2683 (printchar, strout): Use xpalloc to catch size calculation overflow.
2684 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2685 (print_error_message): Use SAFE_ALLOCA, not alloca.
2686 (print_object): Use int, not EMACS_INT, where int is wide enough.
2687 (print_depth, new_backquote_output, print_number_index):
2688 Use ptrdiff_t, not int, where int might not be wide enough.
2689 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2690 (Fset_process_window_size, Fformat_network_address)
2691 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2693 Check that fixnums are in proper range for system types.
2694 (Fsignal_process): Simplify by avoiding a goto.
2695 Check for process-ids out of pid_t range rather than relying on
2697 (process_tick, update_tick): Use EMACS_INT, not int.
2698 (Fformat_network_address, read_process_output, send_process)
2699 (Fprocess_send_region, status_notify):
2700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2701 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2702 (wait_reading_process_output, read_process_output, exec_sentinel):
2703 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2704 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2705 (Faccept_process_output): Use duration_to_sec_usec to do proper
2706 overflow checking on durations.
2707 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2708 Don't assume pid_t fits in int.
2709 * process.h (struct Lisp_Process): Members tick and update_tick
2710 are now of type EMACS_INT, not int.
2711 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2712 configured --with-wide-int.
2713 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2714 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2715 * search.c (looking_at_1, string_match_1):
2716 (fast_string_match, fast_c_string_match_ignore_case)
2717 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2718 (scan_newline, find_before_next_newline, search_command)
2719 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2720 (set_search_regs, wordify):
2723 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2724 (string_match_1, search_buffer, set_search_regs):
2726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2727 (wordify): Check for overflow in size calculation.
2728 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2729 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2730 Check that fixnums are in proper range for system types.
2731 * sound.c (struct sound_device)
2732 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2734 (Fplay_sound_internal):
2735 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2736 * syntax.c (struct lisp_parse_state, find_start_modiff)
2737 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2738 (Fparse_partial_sexp):
2739 Don't assume fixnums can fit in int.
2740 (struct lisp_parse_state, find_start_pos, find_start_value)
2741 (find_start_value_byte, find_start_begv)
2742 (update_syntax_table, char_quoted, dec_bytepos)
2743 (find_defun_start, prev_char_comend_first, back_comment):
2744 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2745 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2747 (Finternal_describe_syntax_value): Check that match_lisp is a
2748 character, not an integer, since the code stuffs it into int.
2749 (scan_words, scan_sexps_forward):
2750 Check that fixnums are in proper range for system types.
2752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2753 (scan_sexps_forward):
2754 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2755 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2756 * syntax.h: Adjust decls to match defn changes elsewhere.
2757 (struct gl_state_s):
2758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2759 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2760 MOST_POSITIVE_FIXNUM.
2761 * sysdep.c (wait_for_termination_1, wait_for_termination)
2762 (interruptible_wait_for_termination, mkdir):
2763 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2764 (emacs_read, emacs_write):
2765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2766 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2767 and double all fit in int.
2768 * term.c (set_tty_color_mode):
2769 Check that fixnums are in proper range for system types.
2770 * termhooks.h (struct input_event):
2771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2772 * textprop.c (validate_interval_range, interval_of)
2773 (Fadd_text_properties, set_text_properties_1)
2774 (Fremove_text_properties, Fremove_list_of_text_properties)
2775 (Ftext_property_any, Ftext_property_not_all)
2776 (copy_text_properties, text_property_list, extend_property_ranges)
2777 (verify_interval_modification):
2778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2779 (Fnext_single_char_property_change)
2780 (Fprevious_single_char_property_change):
2781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2782 (copy_text_properties):
2783 Check for integer overflow in index calculation.
2784 * undo.c (last_boundary_position, record_point, record_insert)
2785 (record_delete, record_marker_adjustment, record_change)
2786 (record_property_change):
2787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2788 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2790 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2791 (Fx_hide_tip, Fx_file_dialog):
2792 * w32menu.c (set_frame_menubar):
2793 Use ptrdiff_t, not int, for consistency with rest of code.
2794 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2795 (select_window, Fdelete_other_windows_internal)
2796 (window_scroll_pixel_based, window_scroll_line_based)
2797 (Frecenter, Fset_window_configuration):
2798 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2799 (Fset_window_hscroll, run_window_configuration_change_hook)
2800 (set_window_buffer, temp_output_buffer_show, scroll_command)
2801 (Fscroll_other_window, Frecenter):
2802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2803 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2804 Don't assume fixnum fits in int.
2805 (Fset_window_scroll_bars):
2806 Check that fixnums are in proper range for system types.
2807 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2808 (string_pos, c_string_pos, number_of_chars, init_iterator)
2809 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2810 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2811 (compute_display_string_end, handle_face_prop)
2812 (face_before_or_after_it_pos, handle_invisible_prop)
2813 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2814 (display_prop_intangible_p, string_buffer_position_lim)
2815 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2816 (get_overlay_strings_1, get_overlay_strings)
2817 (iterate_out_of_display_property, forward_to_next_line_start)
2818 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2819 (get_next_display_element, set_iterator_to_next)
2820 (get_visually_first_element, compute_stop_pos_backwards)
2821 (handle_stop_backwards, next_element_from_buffer)
2822 (move_it_in_display_line_to, move_it_in_display_line)
2823 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2824 (add_to_log, message_dolog, message_log_check_duplicate)
2825 (message2, message2_nolog, message3, message3_nolog
2826 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2827 (current_message_1, truncate_echo_area, truncate_message_1)
2828 (set_message, set_message_1, store_mode_line_noprop)
2829 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2830 (text_outside_line_unchanged_p, check_point_in_composition)
2831 (reconsider_clip_changes)
2832 (redisplay_internal, set_cursor_from_row, try_scrolling)
2833 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2834 (redisplay_window, find_last_unchanged_at_beg_row)
2835 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2836 (trailing_whitespace_p, find_row_edges, display_line)
2837 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2838 (display_mode_element, store_mode_line_string)
2839 (pint2str, pint2hrstr, decode_mode_spec)
2840 (display_count_lines, display_string, draw_glyphs)
2841 (x_produce_glyphs, x_insert_glyphs)
2842 (rows_from_pos_range, mouse_face_from_buffer_pos)
2843 (fast_find_string_pos, mouse_face_from_string_pos)
2844 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2846 (safe_call, init_from_display_pos, handle_fontified_prop)
2847 (handle_single_display_spec, load_overlay_strings)
2848 (with_echo_area_buffer, setup_echo_area_for_printing)
2849 (display_echo_area, echo_area_display)
2850 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2851 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2852 (redisplay_window, dump_glyph_row, display_mode_line)
2853 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2854 (handle_display_spec, display_prop_string_p):
2855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2856 (handle_single_display_spec, build_desired_tool_bar_string)
2857 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2858 (get_specified_cursor_type):
2859 Check that fixnums are in proper range for system types.
2860 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2861 (Flookup_image_map):
2862 Don't assume fixnums fit in int.
2863 (compare_overlay_entries):
2864 Avoid mishandling comparisons due to subtraction overflow.
2865 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2866 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2867 (handle_tool_bar_click):
2868 Use int, not unsigned, since we prefer signed and the signedness
2869 doesn't matter here.
2870 (get_next_display_element, next_element_from_display_vector):
2871 Use int, not EMACS_INT, when int is wide enough.
2872 (start_hourglass): Use duration_to_sec_usec to do proper
2873 overflow checking on durations.
2874 * xfaces.c (Fbitmap_spec_p):
2875 Check that fixnums are in proper range for system types.
2876 (compare_fonts_by_sort_order):
2877 Avoid mishandling comparisons due to subtraction overflow.
2878 (Fx_family_fonts, realize_basic_faces):
2879 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2881 Don't assume fixnum fits in int.
2882 Use SAFE_ALLOCA_LISP, not alloca.
2883 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2884 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2885 (face_at_buffer_position, face_for_overlay_string)
2886 (face_at_string_position):
2887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2888 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2889 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2891 Check that fixnums are in proper range for system types.
2892 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2893 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2895 (Fx_change_window_property): Don't assume fixnums fit in int.
2896 * xfont.c (xfont_chars_supported):
2897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2898 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2899 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2901 * xml.c (parse_region):
2902 * xrdb.c (magic_file_p):
2903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2904 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2905 (x_get_local_selection, x_reply_selection_request)
2906 (x_handle_selection_request, wait_for_property_change):
2907 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2908 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2909 short is wide enough.
2910 (x_send_client_event): Don't assume fixnum fits in int.
2911 * xterm.c (x_x_to_emacs_modifiers):
2912 Don't assume EMACS_INT overflows nicely into int.
2913 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2915 (handle_one_xevent): NATNUMP can eval its arg twice.
2916 (x_connection_closed):
2917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2918 * xterm.h: Adjust decls to match defn changes elsewhere.
2919 (struct scroll_bar): Use struct vectorlike_header
2920 rather than rolling our own approximation.
2921 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2923 2012-05-25 Glenn Morris <rgm@gnu.org>
2925 * lisp.mk (lisp): Update for more files being compiled now.
2927 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2929 * lread.c: Remove `read_pure' which makes no difference.
2930 (read_pure): Remove var.
2931 (unreadpure): Remove function.
2932 (readevalloop): Don't call read_list with -1 flag.
2933 (read1, read_vector): Don't test read_pure any more.
2934 (read_list): Simplify.
2936 * fileio.c, character.h: Minor style tweaks.
2938 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2940 * window.h (clip_changed): Remove useless declaration.
2942 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2944 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2945 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2947 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2950 This directory predates autoconf and is no longer needed nowadays.
2951 Move its few remaining bits of functionality to where they're needed.
2952 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2953 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2954 * m/template.h: Remove.
2955 * Makefile.in (M_FILE): Remove. All uses removed.
2956 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2957 * lisp.h (USE_LSB_TAG):
2958 * mem-limits.h (EXCEEDS_LISP_PTR):
2959 Use VAL_MAX, not VALBITS, in #if.
2960 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2961 (EMACS_UINT): Define unconditionally now.
2962 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2963 (BITS_PER_EMACS_INT): New constants, replacing
2964 what used to be in config.h, but not useful in #if.
2965 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2966 define them any more.
2967 (VAL_MAX): New macro.
2969 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2970 BITS_PER_EMACS_INT, in #if.
2971 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2972 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2973 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2974 * s/ms-w32.h (DATA_START):
2975 Move here from removed file m/intel386.h.
2976 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2977 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2979 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2981 Assume C89 or later.
2982 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2983 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2985 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2986 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2987 * textprop.c, tparam.c (NULL): Remove.
2988 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2989 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2990 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2991 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2992 * xterm.c (input_signal_count): Assume volatile works.
2994 2012-05-21 Ken Brown <kbrown@cornell.edu>
2996 * xgselect.c (xg_select): Fix first argument in call to 'select'
2999 2012-05-20 Ken Brown <kbrown@cornell.edu>
3001 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3002 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3004 2012-05-19 Ken Brown <kbrown@cornell.edu>
3006 * xfns.c (x_in_use): Remove `static' qualifier.
3007 * xterm.h (x_in_use): Declare.
3008 * xgselect.c: Include xterm.h.
3009 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3010 and `display_arg' (bug#9754).
3012 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3014 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3016 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3017 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3019 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3021 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3023 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3024 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3026 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3027 reference to image_cache->refcount.
3028 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3030 2012-05-17 Juri Linkov <juri@jurta.org>
3032 * search.c (Fword_search_regexp, Fword_search_backward)
3033 (Fword_search_forward, Fword_search_backward_lax)
3034 (Fword_search_forward_lax): Move functions to isearch.el
3035 (bug#10145, bug#11381).
3037 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3039 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3041 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3043 * lread.c (init_obarray): Declare Qt and Qnil as special.
3045 2012-05-14 Glenn Morris <rgm@gnu.org>
3047 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3048 Put "libexec" before "bin", for the sake of init_callproc_1.
3050 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3052 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3054 * unexaix.c: Port to more-recent AIX compilers.
3055 (report_error, report_error_1, make_hdr, copy_sym)
3056 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3057 Make arguments const char *, not char *, to avoid violations of C
3058 standard and to fix some AIX warnings reported by Gilles Pion.
3060 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3062 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3063 already have overlays loaded.
3064 (handle_single_display_spec): Before returning without displaying
3065 fringe bitmap, synchronize the bidi iterator with the main display
3066 iterator, by calling iterate_out_of_display_property.
3067 (iterate_out_of_display_property): Detect buffer iteration by
3068 testing that it->string is a Lisp string.
3069 (get_next_display_element): When the current object is exhausted,
3070 and there's something on it->stack, call set_iterator_to_next to
3071 proceed with what's on the stack, instead of returning zero.
3072 (set_iterator_to_next): If called at the end of a Lisp string,
3073 proceed to consider_string_end without incrementing string
3074 position. Don't increment display vector index past the end of
3075 the display vector. (Bug#11417)
3076 (pos_visible_p): Don't report a position visible when move_it_to
3077 stopped at the last line of window, which happens to be scanned
3078 backwards by the bidi iteration. (Bug#11464)
3080 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3082 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3083 and right-margin display specs even if the spec is invalid or we
3084 are on a TTY, and thus unable to display on the fringes.
3085 That's because the text with the property will not be displayed anyway,
3086 so we need to signal to the caller that this is a "replacing"
3087 display spec. This fixes display when the spec is invalid or we
3090 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3092 * unexaix.c (make_hdr): Fix typo in prototype.
3093 This bug broke the build on AIX. Problem reported by Gilles Pion.
3095 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3097 * keyboard.c (kbd_buffer_get_event): Read special events also in
3098 batch mode. (Bug#11415)
3100 2012-05-12 Glenn Morris <rgm@gnu.org>
3102 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3104 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3106 * lisp.mk (lisp): Add newcomment.elc.
3108 2012-05-12 Glenn Morris <rgm@gnu.org>
3110 * Makefile.in (MKDIR_P): New, set by configure.
3111 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3113 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3115 Remove unused function hourglass_started.
3116 * dispextern.h (hourglass_started):
3117 * w32fns.c (hourglass_started):
3118 * xdisp.c (hourglass_started): Remove.
3120 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3122 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3123 Update dependencies.
3125 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3127 * xgselect.c (xg_select): Put maxfds+1 into a var.
3128 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3130 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3132 2012-05-10 Dave Abrahams <dave@boostpro.com>
3134 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3135 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3137 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3139 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3140 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3141 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3142 Initialize xd_registered_buses.
3144 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3146 Untag more efficiently if USE_LSB_TAG.
3147 This is based on a proposal by YAMAMOTO Mitsuharu in
3148 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3149 For an admittedly artificial (nth 8000 longlist) benchmark on
3150 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3151 Emacs's overall text size by 1%.
3152 * lisp.h (XUNTAG): New macro.
3153 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3154 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3155 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3156 * eval.c (Fautoload):
3157 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3158 * frame.h (XFRAME): Use XUNTAG.
3160 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3161 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3162 Remove unportable assumptions about print widths of types like
3164 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3165 intptr_t when converting between pointer and integer, to avoid GCC
3166 warnings about wrong width.
3168 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3170 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3171 stack for each reader_thread, instead of defaulting to 8MB
3172 determined by the linker. This avoids failures in creating
3173 subprocesses on Windows 7, see the discussion in this thread:
3174 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3176 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3178 Fix up display of the *Minibuf-0* buffer in the mini window.
3179 * keyboard.c (read_char): Don't clear the echo area if there's no
3181 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3182 contents of *Minibuf-0*) if there's no message displayed in its stead.
3184 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3186 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3189 2012-05-06 Chong Yidong <cyd@gnu.org>
3191 * lisp.mk (lisp): Update.
3193 2012-05-05 Jim Meyering <meyering@redhat.com>
3195 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3197 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3199 * data.c (PUT_ERROR): New macro.
3200 (syms_of_data): Use it. Add new error type `user-error'.
3201 * undo.c (user_error): New function.
3202 (Fprimitive_undo): Use it.
3203 * print.c (print_error_message): Adjust print style for `user-error'.
3204 * keyboard.c (user_error): New function.
3205 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3207 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3209 Do not limit current-time-string to years 1000..9999.
3210 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3211 (Fcurrent_time_string): Support any year that is supported by the
3212 underlying localtime representation. Don't use asctime, as it
3213 has undefined behavior for years outside the range -999..9999.
3215 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3217 Fix race conditions involving setenv, gmtime, localtime, asctime.
3218 Without this fix, interrupts could mess up code that uses these
3219 nonreentrant functions, since setting TZ invalidates existing
3220 tm_zone or tzname values, and since most of these functions return
3221 pointers to static storage.
3222 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3223 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3224 Grow the critical sections to include not just invoking
3225 localtime/gmtime, but also accessing these functions' results
3226 including their tm_zone values if any, and any related TZ setting.
3227 (format_time_string): Last arg is now struct tm *, not struct tm **,
3228 so that the struct tm is saved in the critical section.
3229 All callers changed. Simplify allocation of initial buffer, partly
3230 motivated by the fact that memory allocation needs to be outside
3231 the critical section.
3233 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3235 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3236 with RESET_INTERVAL.
3238 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3239 Remove duplicated buffer name initialization.
3241 2012-05-02 Jim Meyering <jim@meyering.net>
3243 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3245 * xfns.c (x_window): Use xstrdup (Bug#11375).
3247 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3249 * xdisp.c (pos_visible_p): If already at a newline from the
3250 display string before the 'while' loop, don't walk back the glyphs
3251 from it3.glyph_row. Solves assertion violation when the display
3252 string begins with a newline (egg.el). (Bug#11367)
3254 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3256 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3259 2012-05-01 Glenn Morris <rgm@gnu.org>
3261 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3262 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3263 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3264 All were removed before 23.1.
3266 * dispnew.c: Remove HAVE_LIBNCURSES test;
3267 it is always true on relevant platforms.
3269 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3270 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3272 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3274 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3276 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3277 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3280 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3282 Do not avoid creating empty evaporating overlays (Bug#9642).
3283 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3284 That is, do not delete an evaporating overlay if it becomes
3285 empty after its bounds are adjusted to fit within its buffer.
3286 This fix caused other problems, and I'm reverting it until we get
3287 to the bottom of them.
3289 2012-04-27 Chong Yidong <cyd@gnu.org>
3291 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3293 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3295 * xdisp.c (pos_visible_p): If the window start position is beyond
3296 ZV, start the display from buffer beginning. Prevents assertion
3297 violation in init_iterator when the minibuffer window is scrolled
3300 * window.c (window_scroll_pixel_based): Likewise.
3302 2012-04-27 Chong Yidong <cyd@gnu.org>
3304 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3306 2012-04-27 Glenn Morris <rgm@gnu.org>
3308 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3309 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3311 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3313 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3314 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3316 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3318 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3319 display element, check also the underlying string or buffer
3320 character. (Bug#11341)
3322 * w32menu.c: Include w32heap.h.
3323 (add_menu_item): If the call to AppendMenuW (via
3324 unicode_append_menu) fails, disable Unicode menus only if we are
3325 running on Windows 9X/Me.
3327 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3329 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3330 (xgetint): Add missing shift for LSB tags.
3332 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3334 * keyboard.c (read_char): Don't wipe echo area for select window
3335 events: These might get delayed via `mouse-autoselect-window'
3338 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3340 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3341 manipulation of :loaded-from data.
3343 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3345 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3346 now a cons (bug#11311).
3348 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3350 Do not create empty overlays with the evaporate property (Bug#9642).
3351 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3352 if it becomes empty after its bounds are adjusted to fit within
3353 its buffer. Without this fix, in a nonempty buffer (let ((o
3354 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3355 yields an empty overlay that has the evaporate property, which is
3356 not supposed to happen.
3358 Fix minor GTK3 problems found by static checking.
3359 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3360 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3361 (struct _EmacsFixedClass, emacs_fixed_get_type):
3362 Move decls here from emacsgtkfixed.h, since they needn't be public.
3363 (emacs_fixed_get_type): Now static.
3364 (emacs_fixed_class_init): Omit unused local.
3365 (emacs_fixed_child_type): Remove; unused.
3366 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3367 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3368 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3369 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3370 (EMACS_FIXED_GET_CLASS): Remove; unused.
3371 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3373 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3374 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3376 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3378 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3379 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3380 (__malloc_size_t, __malloc_ptrdiff_t):
3381 Remove. All uses removed, replaced by the definiens if needed,
3382 since we can assume C89 or better now.
3383 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3384 (protect_malloc_state, align, get_contiguous_space)
3385 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3386 (malloc_atfork_handler_child, malloc_enable_thread)
3387 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3388 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3389 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3390 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3391 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3392 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3393 Define using prototypes, not old style.
3394 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3395 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3396 (align): Don't assume that signed integer overflow wraps around.
3397 Omit unused local var.
3398 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3399 (_free_internal_nolock, memalign, mallochook, reallochook):
3400 Omit no-longer-needed casts.
3401 (valloc): Use getpagesize, not __getpagesize.
3402 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3403 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3405 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3407 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3409 Move functions from C to Lisp. Make non-blocking method calls
3410 the default. Implement further D-Bus standard interfaces.
3412 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3413 (QCdbus_request_name_allow_replacement)
3414 (QCdbus_request_name_replace_existing)
3415 (QCdbus_request_name_do_not_queue)
3416 (QCdbus_request_name_reply_primary_owner)
3417 (QCdbus_request_name_reply_in_queue)
3418 (QCdbus_request_name_reply_exists)
3419 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3420 (QCdbus_registered_serial, QCdbus_registered_method)
3421 (QCdbus_registered_signal): New Lisp objects.
3422 (XD_DEBUG_MESSAGE): Use sizeof.
3423 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3424 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3425 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3426 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3427 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3428 (xd_signature, xd_append_arg): Allow float for integer types.
3429 (xd_get_connection_references): New function.
3430 (xd_get_connection_address): Rename from xd_initialize.
3431 Return cached address.
3432 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3433 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3435 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3436 Return number of refcounts.
3437 (Fdbus_get_unique_name): Make stronger parameter check.
3438 (Fdbus_message_internal): New defun.
3439 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3440 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3441 (Fdbus_send_signal, Fdbus_register_service)
3442 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3443 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3444 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3445 (Vdbus_compiled_version, Vdbus_runtime_version)
3446 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3447 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3448 (Vdbus_message_type_signal): New defvars.
3449 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3452 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3454 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3455 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3456 Do not assume ptrdiff_t is the same width as 'int'.
3458 * alloc.c: Handle unusual debugging option combinations.
3459 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3460 since the two debugging options are incompatible.
3461 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3463 (mem_init, mem_insert, mem_insert_fixup):
3464 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3465 (NEED_MEM_INSERT): Remove; no longer needed.
3467 2012-04-22 Leo Liu <sdl.web@gmail.com>
3469 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3471 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3473 * sysdep.c [__FreeBSD__]: Minor cleanups.
3474 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3475 Use Emacs indenting style more consistently. Avoid some casts.
3476 Use 'double' consistently rather than mixing 'float' and 'double'.
3478 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3480 * sysdep.c (list_system_processes, system_process_attributes):
3481 Add implementation for FreeBSD (Bug#5243).
3483 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3485 * lisp.mk (lisp): Update.
3487 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3489 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3490 It is never used otherwise.
3492 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3494 * print.c (print_preprocess): Only check print_depth if print-circle
3496 (print_object): Check for cycles even when print-circle is nil and
3497 print-gensym is t, but only check print_depth if print-circle is nil.
3499 2012-04-20 Chong Yidong <cyd@gnu.org>
3501 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3502 set the status to "failed" and ensure that sentinel is run.
3504 2012-04-20 Glenn Morris <rgm@gnu.org>
3506 * process.c (Fset_process_inherit_coding_system_flag)
3507 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3508 (Fmake_network_process, Fmake_serial_process): Doc fix.
3510 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3512 * xdisp.c (string_buffer_position_lim): Limit starting position to
3514 (set_cursor_from_row): If called for a mode-line or header-line
3515 row, return zero immediately.
3516 (try_cursor_movement): If inside continuation line, don't back up
3517 farther than the first row after the header line, if any.
3518 Don't consider the header-line row as "partially visible", even if
3519 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3521 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3523 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3526 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3527 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3529 configure: new option --enable-gcc-warnings (Bug#11207)
3530 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3531 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3532 (ALL_CFLAGS): Use new macros rather than old.
3533 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3534 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3535 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3536 -Wunused-result, -Wunused-variable. This should go away once
3537 the Emacs and Gnulib regex code is merged.
3538 (xmalloc, xrealloc): Now static.
3540 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3542 * dired.c (Fsystem_groups): Remove unused local.
3544 2012-04-17 Glenn Morris <rgm@gnu.org>
3546 * dired.c (Fsystem_users): Doc fix.
3548 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3550 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3551 (syms_of_dired): Add them.
3553 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3555 Fix minor alloc.c problems found by static checking.
3556 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3557 New extern decls, to avoid calling undeclared functions.
3558 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3559 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3560 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3561 (NEED_MEM_INSERT): New macro.
3562 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3563 Remove one incorrect comment and fix another.
3565 Fix minor ralloc.c problems found by static checking.
3566 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3567 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3568 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3569 (r_alloc_sbrk): Now static.
3571 Improve ralloc.c interface checking.
3572 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3573 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3574 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3575 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3576 [REL_ALLOC]: ... to here, to check interface.
3577 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3578 Remove decls. This fixes an "It stinks!".
3580 * alloc.c (which_symbols): Fix alignment issue / type clash.
3582 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3584 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3585 (struct Lisp_Misc_Any): Likewise.
3586 (struct Lisp_Free): Likewise.
3587 * alloc.c (union aligned_Lisp_Symbol): Define.
3588 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3589 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3590 (union aligned_Lisp_Misc): Define.
3591 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3592 aligned_Lisp_Misc instead of union Lisp_Misc.
3593 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3595 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3597 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3598 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3599 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3600 * s/netbsd.h, s/sol2-6.h:
3601 Remove definition of GC_MARK_STACK, since the default now works.
3602 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3603 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3604 no longer the default.
3605 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3607 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3609 * lread.c (lisp_file_lexically_bound_p):
3610 Fix hang at ";-*-\n" (bug#11238).
3612 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3614 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3615 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3617 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3619 * nsterm.m (constrainFrameRect): Always constrain when there is only
3620 one screen (Bug#10962).
3622 2012-04-13 Ken Brown <kbrown@cornell.edu>
3624 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3626 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3628 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3630 2012-04-11 Daniel Colascione <dancol@dancol.org>
3632 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3633 against is gone. It's better to use vfork now so that when Cygwin
3634 gains a new, working vfork, we use it automatically (bug#10398).
3636 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3638 * window.c (save_window_save): Obey window-point-insertion-type.
3640 2012-04-11 Glenn Morris <rgm@gnu.org>
3642 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3644 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3646 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3648 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3650 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3651 (force_quit_count): New var.
3652 (handle_interrupt): Use it.
3654 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3656 * w32.c (w32_delayed_load): Record the full path of the library
3657 being loaded (bug#10424).
3659 2012-04-09 Glenn Morris <rgm@gnu.org>
3661 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3662 not just in the obarray, before snarfing them. (Bug#11036)
3664 * Makefile.in ($(leimdir)/leim-list.el):
3665 Pass EMACS rather than BUILT_EMACS.
3667 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3669 * process.c (make_process):
3670 * process.h: Add integer `gnutls_handshakes_tried' member to
3673 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3674 Add convenience `GNUTLS_LOG2i' macro.
3676 * gnutls.c (gnutls_log_function2i): Convenience log function.
3677 (emacs_gnutls_read): Use new log functions,
3678 `gnutls_handshakes_tried' process member, and
3679 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3680 attempts per process (connection).
3682 2012-04-09 Chong Yidong <cyd@gnu.org>
3684 * eval.c (Fuser_variable_p, user_variable_p_eh)
3685 (lisp_indirect_variable): Functions deleted.
3686 (Fdefvar): Caller changed.
3688 * callint.c (Finteractive, Fcall_interactively):
3689 * minibuf.c (Fread_variable): Callers changed.
3691 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3693 * xdisp.c (set_cursor_from_row): If the display string appears in
3694 the buffer at position that is closer to point than the position
3695 after the display string, display the cursor on the first glyph of
3696 the display string. Fixes cursor display when a 'display' text
3697 property immediately follows invisible text. (Bug#11094)
3699 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3701 composite.c: use 'double' consistently
3702 * composite.c (get_composition_id): Use 'double' consistently
3703 instead of converting 'float' to 'double' and vice versa; this is
3704 easier to understand and avoids a GCC warning.
3706 2012-04-09 Glenn Morris <rgm@gnu.org>
3708 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3709 preparation for dumping it with emacs. (Bug#4789)
3710 (leimdir): New variable.
3711 ($(leimdir)/leim-list.el): New rule.
3712 (emacs$(EXEEXT)): Depend on leim-list.el.
3714 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3715 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3716 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3718 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3720 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3723 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3725 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3726 Remove unused local variable.
3728 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3730 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3731 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3732 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3733 objects, as mark_maybe_pointer will catch them otherwise.
3734 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3735 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3737 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3739 Fix typo that broke non-Windows builds.
3740 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3742 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3744 Support building on MS-Windows with libxml2.
3746 * makefile.w32-in (OBJ2): Add xml.$(O).
3747 (GLOBAL_SOURCES): Add xml.c.
3748 ($(BLD)/xml.$(O)): New dependency list.
3750 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3751 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3752 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3753 [!WINDOWSNT]: New macros.
3754 (init_libxml2_functions, libxml2_loaded_p): New functions.
3755 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3756 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3757 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3758 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3760 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3761 Call init_libxml2_functions before calling libxml2 functions.
3762 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3764 * emacs.c: Don't include libxml/parser.h.
3765 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3766 xmlCleanupParser directly.
3768 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3770 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3772 * indent.c (Fvertical_motion): If there is a display string at
3773 point, use it.vpos to compute how many lines to backtrack after
3774 move_it_to point. (Bug#11133)
3776 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3778 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3779 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3780 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3781 macros related to unification of CJK characters. For the details,
3782 see the discussion following the message here:
3783 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3785 2012-04-04 Chong Yidong <cyd@gnu.org>
3787 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3789 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3791 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3792 instead of alloca. (Bug#11138)
3794 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3796 * w32menu.c (is_simple_dialog): Properly check lisp types.
3799 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3801 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3802 position we get to after a call to move_it_to fails the
3803 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3804 only if we wind up in a string from display property. (Bug#11063)
3806 * window.c (Fdelete_other_windows_internal): Invalidate the row
3807 and column information about mouse highlight, so that redisplay
3808 restores it after reallocating the glyph matrices. (Bug#7464)
3810 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3811 string comes from a `display' text property, use the buffer
3812 position of that property as if we actually saw that position in
3814 (move_it_by_lines): Remove the assertion that
3815 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3816 violated when there's a before-string at the beginning of a line.
3819 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3821 * xdisp.c (append_space_for_newline): If the default face was
3822 remapped, use the remapped face for the appended newline.
3823 (extend_face_to_end_of_line): Use the remapped default face for
3824 extending the face to the end of the line.
3825 (display_line): Call extend_face_to_end_of_line when the default
3826 face was remapped. (Bug#11068)
3828 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3830 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3832 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3834 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3836 2012-03-27 Glenn Morris <rgm@gnu.org>
3838 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3841 2012-03-26 Kenichi Handa <handa@m17n.org>
3843 * dispextern.h (struct glyph): Fix previous change. Change the
3844 bit length of glyphless.ch to 25 (Bug#11082).
3846 2012-03-26 Chong Yidong <cyd@gnu.org>
3848 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3849 (command_loop_1): Use it; inhibit selection update for
3850 handle-select-window too (Bug#8996).
3852 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3854 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3856 2012-03-25 Kenichi Handa <handa@m17n.org>
3858 * dispextern.h (struct glyph): Change the bit length of
3859 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3861 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3863 * s/ms-w32.h (tzname): Include time.h before redirecting to
3864 _tzname. Fixes the MSVC build. (Bug#9960)
3866 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3868 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3871 * xterm.c (XTread_socket): Only modify handling_signal if
3872 !SYNC_INPUT. (Bug#11080)
3874 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3876 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3877 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3878 when fetching a multibyte character consumes more bytes than
3879 CHAR_BYTES returns, due to unification of CJK characters in
3880 string_char. (Bug#11073)
3882 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3884 * process.c (wait_reading_process_output): Handle pty disconnect
3885 by refraining from sending oneself a SIGCHLD (bug#10933).
3887 2012-03-22 Chong Yidong <cyd@gnu.org>
3889 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3891 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3892 Mark string as coming from a prefix property.
3893 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3894 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3896 2012-03-21 Chong Yidong <cyd@gnu.org>
3898 * xfaces.c (Vface_remapping_alist): Doc fix.
3900 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3902 * w32proc.c (Fw32_set_console_codepage)
3903 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3906 2012-03-20 Chong Yidong <cyd@gnu.org>
3908 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3909 to reflect default non-nil value of redisplay-dont-pause.
3911 2012-03-19 Kenichi Handa <handa@m17n.org>
3913 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3914 it fit in a valid range (Bug#11003).
3916 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3918 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3919 that is not from display property, accept the row as a "cursor
3920 row" if one of the string's character has a non-nil `cursor'
3921 property. Fixes cursor positioning when there are newlines in
3922 overlay strings, e.g. in icomplete.el. (Bug#11035)
3924 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3926 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3928 2012-03-12 Chong Yidong <cyd@gnu.org>
3930 * eval.c (inhibit_lisp_code): Rename from
3931 inhibit_window_configuration_change_hook; move from window.c.
3933 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3934 * window.c (run_window_configuration_change_hook)
3935 (syms_of_window): Callers changed.
3937 2012-03-11 Chong Yidong <cyd@gnu.org>
3939 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3941 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3943 2012-03-10 Chong Yidong <cyd@gnu.org>
3945 * frame.c (other_visible_frames): Don't assume the selected frame
3946 is visible (Bug#10955).
3948 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3950 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3952 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3954 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3955 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3958 2012-03-03 Glenn Morris <rgm@gnu.org>
3960 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3962 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3964 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3965 position past the first glyph_row that ends at ZV. (Bug#10902)
3966 (redisplay_window, next_element_from_string): Fix typos in
3968 (redisplay_window): Pass to move_it_vertically the margin in
3969 pixels, not in screen lines.
3971 2012-03-02 Glenn Morris <rgm@gnu.org>
3973 * buffer.c (buffer-list-update-hook): Doc fix.
3975 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3977 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3978 push_it before setting up the iterator for the first overlay
3979 string, even if we have an empty string loaded.
3980 (next_overlay_string): If there's an empty string on the iterator
3981 stack, pop the stack. (Bug#10903)
3983 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3985 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3986 Suggested by Stefan Monnier in
3987 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3988 * alloc.c (widen_to_Lisp_Object): New static function.
3989 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3990 and widening them to Lisp_Objects. This would work even if
3991 USE_LSB_TAG is defined and wide integers are used, which might
3992 happen in a future version of Emacs.
3994 2012-02-25 Chong Yidong <cyd@gnu.org>
3996 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3999 * xselect.c (Fx_selection_exists_p): Doc fix.
4000 (x_clipboard_manager_save_all): Print an informative message
4001 before saving to clipboard manager.
4003 2012-02-24 Chong Yidong <cyd@gnu.org>
4005 * keyboard.c (process_special_events): Handle all X selection
4006 requests in kbd_buffer, not just the next one (Bug#8869).
4008 2012-02-23 Chong Yidong <cyd@gnu.org>
4010 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4011 call when setting menu-bar-lines and tool-bar-lines parameters.
4012 (unwind_create_frame_1): New helper function.
4014 * window.c (inhibit_window_configuration_change_hook): New var.
4015 (run_window_configuration_change_hook): Obey it.
4016 (syms_of_window): Initialize it.
4018 2012-02-22 Chong Yidong <cyd@gnu.org>
4020 * xterm.c (x_draw_image_relief): Add missing type check for
4021 Vtool_bar_button_margin (Bug#10743).
4023 2012-02-21 Chong Yidong <cyd@gnu.org>
4025 * fileio.c (Vfile_name_handler_alist): Doc fix.
4027 * buffer.c (Fget_file_buffer): Protect against invalid file
4028 handler return value.
4030 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4032 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4033 when computing $valmask.
4035 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4036 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4037 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4038 It's useless in that case, and it can cause problems on hosts
4039 that allocate halves of EMACS_INT values separately.
4040 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4041 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4042 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4043 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4044 it avoids undefined behavior on hosts where shifting right by more
4045 than the word width has undefined behavior.
4047 2012-02-19 Chong Yidong <cyd@gnu.org>
4049 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4050 (Funhandled_file_name_directory, Ffile_name_as_directory)
4051 (Fdirectory_file_name, Fexpand_file_name)
4052 (Fsubstitute_in_file_name): Protect against invalid file handler
4053 return values (Bug#10845).
4055 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4057 * .gdbinit (pitx): Fix incorrect references to fields of the
4060 2012-02-17 Chong Yidong <cyd@gnu.org>
4062 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4064 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4066 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4067 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4069 2012-02-15 Chong Yidong <cyd@gnu.org>
4071 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4072 marked as special. Also, starting docstrings with * is obsolete.
4074 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4076 * gnutls.c (emacs_gnutls_write): Fix last change.
4078 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4080 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4083 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4085 * keymap.c (Fsingle_key_description): Handle char ranges.
4087 2012-02-12 Chong Yidong <cyd@gnu.org>
4089 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4090 as that creates a dangerous corner case.
4092 * window.c (Fdelete_window_internal): Invalidate the mouse
4093 highlight (Bug#9904).
4095 2012-02-12 Glenn Morris <rgm@gnu.org>
4097 * xselect.c (Fx_own_selection_internal)
4098 (Fx_get_selection_internal, Fx_disown_selection_internal)
4099 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4100 * nsselect.m (Fx_own_selection_internal)
4101 (Fx_disown_selection_internal, Fx_selection_exists_p)
4102 (Fx_selection_owner_p, Fx_get_selection_internal):
4103 Sync docs and argument specs with the xselect.c versions.
4105 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4107 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4109 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4111 * w32select.c (Fx_selection_exists_p): Sync doc string and
4112 argument list with xselect.c. (Bug#10783)
4114 * w16select.c (Fx_selection_exists_p): Sync doc string and
4115 argument list with xselect.c. (Bug#10783)
4117 2012-02-10 Glenn Morris <rgm@gnu.org>
4119 * fns.c (Fsecure_hash): Doc fix.
4121 2012-02-09 Kenichi Handa <handa@m17n.org>
4123 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4125 2012-02-07 Chong Yidong <cyd@gnu.org>
4127 * buffer.c (Fbuffer_local_variables)
4128 (buffer_lisp_local_variables): Handle unbound vars correctly;
4129 don't let Qunbound leak into Lisp.
4131 2012-02-07 Glenn Morris <rgm@gnu.org>
4133 * image.c (Fimagemagick_types): Doc fix.
4135 * image.c (imagemagick-render-type): Change it from a lisp object
4136 to an integer. Move the doc here from the lisp manual.
4137 Treat all values not equal to 0 the same.
4139 2012-02-06 Chong Yidong <cyd@gnu.org>
4141 * doc.c (store_function_docstring): Avoid applying docstring of
4142 alias to base function (Bug#2603).
4144 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4146 * .gdbinit (pp1, pv1): Remove redundant defines.
4149 2012-02-04 Chong Yidong <cyd@gnu.org>
4151 * nsterm.m: Declare a global (Bug#10694).
4153 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4155 * w32.c (get_emacs_configuration_options):
4156 Include --enable-checking, if specified, in the return value.
4158 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4160 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4161 after rounding frame sizes. (Bug#9723)
4163 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4165 * keyboard.c (adjust_point_for_property): Don't position point
4166 before BEGV. (Bug#10696)
4168 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4170 Handle overflow when computing char display width (Bug#9496).
4171 * character.c (char_width): Return EMACS_INT, not int.
4172 (char_width, c_string_width): Check for overflow when
4173 computing the width; this is possible now that individual
4174 characters can have unbounded width. Problem introduced
4175 by merge from Emacs 23 on 2012-01-19.
4177 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4179 * dbusbind.c (Fdbus_register_method): Mention the return value
4180 :ignore in the docstring.
4182 2012-02-02 Glenn Morris <rgm@gnu.org>
4184 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4186 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4187 Unconditionally set to t. (Bug#10673)
4188 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4189 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4190 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4192 2012-02-02 Kenichi Handa <handa@m17n.org>
4194 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4195 0, do not call append_composite_glyph.
4197 2012-02-02 Kenichi Handa <handa@m17n.org>
4199 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4201 (x_produce_glyphs): If the component of a composition is a null
4202 string, set it->pixel_width to 1 to avoid zero-width glyph.
4204 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4206 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4207 first 2 arguments are identical. This makes inserting large
4208 output from a subprocess an order of magnitude faster on
4209 MS-Windows, where all sbrk'ed memory is always contiguous.
4211 2012-01-31 Glenn Morris <rgm@gnu.org>
4213 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4214 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4215 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4217 2012-01-29 Glenn Morris <rgm@gnu.org>
4219 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4221 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4223 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4225 2012-01-28 Chong Yidong <cyd@gnu.org>
4227 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4229 2012-01-26 Chong Yidong <cyd@gnu.org>
4231 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4233 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4234 repeat counts (Bug#10507).
4236 2012-01-26 Glenn Morris <rgm@gnu.org>
4238 * lread.c (syms_of_lread): Doc fix.
4240 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4242 * coding.c (encode_designation_at_bol): Change return value to
4245 2012-01-25 Chong Yidong <cyd@gnu.org>
4247 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4249 2012-01-21 Chong Yidong <cyd@gnu.org>
4251 * floatfns.c (Fcopysign): Make the second argument non-optional,
4252 since nil is not allowed anyway.
4254 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4256 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4257 (send_process): Likewise.
4259 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4261 * window.c (save_window_save, Fcurrent_window_configuration)
4262 (Vwindow_persistent_parameters): Do not use Qstate.
4263 Rewrite doc-strings.
4265 2012-01-19 Kenichi Handa <handa@m17n.org>
4267 * character.c (char_width): New function.
4268 (Fchar_width, c_string_width, lisp_string_width):
4269 Use char_width (Bug#9496).
4271 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4273 * window.c (Vwindow_persistent_parameters): New variable.
4274 (Fset_window_configuration, save_window_save): Handle persistent
4277 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4279 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4280 thrashing the stack of the thread. (Bug#9087)
4282 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4284 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4286 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4288 * xdisp.c (rows_from_pos_range): Handle the case where the
4289 highlight ends on a newline. (Bug#10464)
4290 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4291 he end column for display of highlight that ends on a newline
4294 2012-01-11 Glenn Morris <rgm@gnu.org>
4296 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4297 from load-path also when installation-directory is nil. (Bug#10208)
4299 2012-01-10 Glenn Morris <rgm@gnu.org>
4301 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4303 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4304 Update template values to be closer to their typical values these days.
4306 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4308 * xdisp.c (rows_from_pos_range): Accept additional argument
4309 DISP_STRING, and accept any glyph in a row whose object is that
4310 string as eligible for mouse highlight. Fixes mouse highlight of
4311 display strings from overlays. (Bug#10464)
4313 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4315 emacs: fix an auto-save permissions race condition (Bug#10400)
4316 * fileio.c (auto_saving_dir_umask): New static var.
4317 (Fmake_directory_internal): Use it.
4318 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4319 creating the directory. The old code temporarily assigns
4320 too-generous permissions to the directory.
4321 (do_auto_save_eh): Clear it.
4322 (Fdo_auto_save): Catch all errors, not just file errors, so
4323 that the var is always cleared.
4325 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4327 * search.c (scan_buffer): Pass character positions to
4328 know_region_cache, not byte positions. (Bug#6540)
4330 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4332 * w32.c (sys_rename): Report EXDEV when rename of a directory
4333 fails because the target is on another logical disk. (Bug#10284)
4335 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4337 * xterm.c (x_embed_request_focus): New function.
4339 * xterm.h: Add prototype.
4341 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4343 2012-01-05 Glenn Morris <rgm@gnu.org>
4345 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4347 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4349 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4350 Load gnutls_transport_set_lowat only if GnuTLS version is below
4352 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4353 GnuTLS versions below 2.11.1.
4355 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4357 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4358 to the doc string advising against its use for altering the way
4359 windows are scrolled.
4361 2011-12-28 Kenichi Handa <handa@m17n.org>
4363 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4364 coding-system ASCII compatible only when it does not produce BOM
4365 on encoding (Bug#10383).
4367 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4369 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4371 (create_and_show_popup_menu): Always use menu_position_func for
4374 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4376 * callint.c (Fcall_interactively): Don't truncate prompt string.
4378 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4380 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4381 property that ends at ZV, so that the bidi iteration could be
4382 resumed from there (after widening). (Bug#10360)
4384 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4386 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4388 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4390 * nsterm.m (x_free_frame_resources):
4391 Release f->output_data.ns->miniimage.
4392 (ns_index_color): Fix indentation. Do not retain
4393 color_table->colors[i].
4395 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4398 * nsfns.m (x_set_background_color): Assign return value from
4399 ns_index_color to face-background instead of NSColor*.
4400 (ns_implicitly_set_icon_type): Fix indentation.
4401 Change assignment in for loop to comparison.
4403 * emacs.c (ns_pool): New variable.
4404 (main): Assign ns_pool.
4405 (Fkill_emacs): Call ns_release_autorelease_pool.
4407 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4408 autorelease fdesc, release fdAttrs and tdict.
4409 (ns_get_covering_families): Release charset.
4410 (ns_findfonts): Release NSFontDescriptor created with new.
4411 (ns_uni_to_glyphs): Fix indentation.
4412 (setString): Release attrStr before assigning new value.
4414 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4416 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4418 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4419 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4421 2011-12-18 David Reitter <reitter@cmu.edu>
4423 * nsterm.m (ns_term_init): Subscribe for notifications
4424 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4425 to method trackingNotification in EmacsMenu.
4427 * nsmenu.m (trackingMenu): New variable.
4428 (trackingNotification): New method (from Aquamacs).
4429 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4430 from Aquamacs (Bug#7030).
4432 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4434 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4435 (symbol_to_nsstring): Fix indentation.
4436 (ns_symbol_to_pb): New function.
4437 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4438 (Fns_rotate_cut_buffers_internal): Remove.
4439 (Fns_store_selection_internal): Rename from
4440 Fns_store_cut_buffer_internal.
4441 (ns_get_foreign_selection, Fx_own_selection_internal)
4442 (Fx_disown_selection_internal, Fx_selection_exists_p)
4443 (Fns_get_selection_internal, Fns_store_selection_internal):
4444 Use ns_symbol_to_pb and check if return value is nil.
4445 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4446 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4447 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4448 renamed to Sns_store_selection_internal.
4449 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4450 and remove this function.
4451 (ns_handle_selection_clear): Remove, never used.
4452 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4455 2011-12-17 Ken Brown <kbrown@cornell.edu>
4457 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4458 GID is unknown (Bug#10257).
4460 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4462 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4463 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4464 which caused a build failure on GNU/Linux IA-64. This problem was
4465 introduced by my 2011-10-07 patch.
4467 2011-12-15 Juri Linkov <juri@jurta.org>
4469 * image.c (imagemagick_error): New function. (Bug#10112)
4470 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4471 Use `imagemagick_error' where ImageMagick functions return
4473 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4476 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4478 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4479 fill background (Bug#8992).
4481 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4483 * window.c (Vwindow_combination_resize)
4484 (Vwindow_combination_limit): Use t instead of non-nil in
4486 (Vrecenter_redisplay): Add first sentence of doc-string on
4488 (Frecenter): Fix doc-string typo.
4490 2011-12-11 Kenichi Handa <handa@m17n.org>
4492 * coding.c (Funencodable_char_position): Pay attention to the
4493 buffer text relocation (Bug#9389).
4495 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4497 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4498 gtk_init (Bug#10100).
4500 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4502 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4503 IT->string is nil. (Bug#10263)
4505 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4507 * nsterm.h (x_free_frame_resources): Declare.
4509 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4510 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4512 * nsterm.h (ns_get_defaults_value): Declare.
4514 * nsterm.m (ns_default): Call ns_get_defaults_value.
4516 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4518 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4521 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4523 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4524 that where the value of an _OBJC_* symbol points to is in the .bss
4525 section (Bug#10240).
4527 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4529 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4530 after the loop to call ccl_driver at least once (Bug#8619).
4532 2011-12-08 Kenichi Handa <handa@m17n.org>
4534 * ftfont.c (get_adstyle_property): Fix previous change
4537 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4539 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4540 dirs from the default value of EMACSLOADPATH (bug#10208).
4542 2011-12-07 Glenn Morris <rgm@gnu.org>
4544 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4545 installation and source directories as well. (Bug#10208)
4547 2011-12-06 Chong Yidong <cyd@gnu.org>
4549 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4551 2011-12-06 Glenn Morris <rgm@gnu.org>
4553 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4554 as an error, not just -1. (Bug#10217)
4556 2011-12-05 Chong Yidong <cyd@gnu.org>
4558 * keyboard.c (process_special_events): New function.
4559 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4561 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4563 * coding.c (encode_designation_at_bol): Don't use uninitialized
4564 local variable (Bug#9318).
4566 2011-12-05 Kenichi Handa <handa@m17n.org>
4568 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4569 return Qnil (Bug#8046, Bug#10193).
4571 2011-12-05 Kenichi Handa <handa@m17n.org>
4573 * coding.c (encode_designation_at_bol): New args charbuf_end and
4574 dst. Return the number of produced bytes. Callers changed.
4575 (coding_set_source): Return how many bytes coding->source was
4577 (coding_set_destination): Return how many bytes
4578 coding->destination was relocated.
4579 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4580 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4582 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4584 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4585 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4588 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4590 The following changes are to fix Bug#9318.
4592 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4593 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4594 (encode_coding_iso_2022, encode_coding_sjis)
4595 (encode_coding_big5, encode_coding_charset): Use the above macros.
4597 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4599 * lisp.h (process_quit_flag): Fix external declaration.
4601 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4603 Don't macro-inline non-performance-critical code.
4604 * eval.c (process_quit_flag): New function.
4605 * lisp.h (QUIT): Use it.
4607 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4609 * nsfns.m (get_geometry_from_preferences): New function.
4610 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4612 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4614 * emacs.c (Qkill_emacs): Define.
4615 (syms_of_emacs): Initialize it.
4616 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4617 Qquit_flag to `kill-emacs' instead.
4618 (quit_throw_to_read_char): Add parameter `from_signal'.
4619 All callers changed. Call Fkill_emacs if requested and safe.
4620 * lisp.h (QUIT): Call Fkill_emacs if requested.
4622 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4624 * widget.c (update_wm_hints): Return if wmshell is null.
4625 (widget_update_wm_size_hints): New function.
4627 * widget.h (widget_update_wm_size_hints): Declare.
4629 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4630 widget_update_wm_size_hints (Bug#10104).
4632 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4634 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4635 before a newline, prepare the bidi iterator for consuming the
4636 newline, and keep the current paragraph direction. (Bug#10183)
4637 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4639 2011-12-02 Juri Linkov <juri@jurta.org>
4641 * search.c (Fword_search_regexp): New Lisp function created from
4642 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4643 (Fword_search_backward, Fword_search_forward)
4644 (Fword_search_backward_lax, Fword_search_forward_lax):
4645 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4646 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4648 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4650 * fileio.c (Finsert_file_contents): Move after-change-function call
4651 to before the "handled:" label, since all "goto handled" appear in
4652 cases where the *-change-functions have already been properly called
4655 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4657 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4658 waiting for input. (Bug#10169)
4660 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4662 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4663 verifies glyph row's hash code--we have just reallocated the
4664 glyphs, so their contents can be complete garbage. (Bug#10164)
4666 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4668 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4670 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4672 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4673 attributes are tested _before_ calling verify_row_hash, to protect
4674 against GCC re-ordering of the tests. (Bug#10164)
4676 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4678 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4680 * xterm.c (handle_one_xevent): Only set async_visible and friends
4681 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4682 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4683 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4685 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4687 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4688 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4689 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4690 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4691 All uses changed to use GCPRO1 etc.
4692 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4693 Revert to old implementation (i.e., before 2011-03-11).
4695 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4697 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4698 of scroll runs so as to avoid assigning disabled bogus rows and
4699 unnecessary graphics copy operations.
4701 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4703 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4704 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4705 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4706 (malloc, free, realloc, calloc): Redirect to e_* only when
4709 * lisp.h (GCTYPEBITS): Move before first use.
4710 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4711 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4712 this macro definition.
4714 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4717 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4719 * gtkutil.c (xg_create_frame_widgets):
4720 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4721 present with Gtk+ 2.0.
4723 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4725 * fileio.c (Finsert_file_contents): Undo previous change; see
4726 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4728 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4730 Rename locals to avoid shadowing.
4731 * fileio.c (Finsert_file_contents):
4732 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4733 * process.c (wait_reading_process_output):
4734 Rename inner 'proc' to 'p' to avoid shadowing.
4735 Indent for consistency with usual Emacs style.
4737 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4739 * xdisp.c (redisplay_window): If cursor row is not fully visible
4740 after recentering, and scroll-conservatively is set to a large
4741 number, scroll window by a few more lines to make the cursor fully
4742 visible and out of scroll-margin. (Bug#10105)
4743 (start_display): Don't move to the next line if the display should
4744 start at a newline that is part of a display vector or an overlay
4747 2011-11-24 Juri Linkov <juri@jurta.org>
4749 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4750 after the `MagickPingImage' call. (Bug#10112)
4752 2011-11-23 Chong Yidong <cyd@gnu.org>
4754 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4756 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4758 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4759 making another buffer current. (Bug#10114)
4761 2011-11-23 Glenn Morris <rgm@gnu.org>
4763 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4765 2011-11-23 Chong Yidong <cyd@gnu.org>
4767 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4768 using it (Bug#5984).
4770 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4772 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4773 and header-lines, as they don't have one computed for them.
4776 * .gdbinit (prow): Make displayed values more self-explaining.
4777 Add row's hash code.
4779 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4781 * process.c (wait_reading_process_output): Fix asynchrounous
4782 GnuTLS socket handling on some versions of the GnuTLS library.
4783 (wait_reading_process_output): Add comment and URL.
4785 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4787 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4789 2011-11-21 Chong Yidong <cyd@gnu.org>
4791 * window.c (Fnext_window, Fprevious_window): Doc fix.
4793 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4795 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4797 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4799 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4801 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4803 * window.c (Fset_window_combination_limit): Rename argument
4805 (Vwindow_combination_limit): Remove "status" from doc-string.
4807 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4809 * m/ibms390.h: Remove.
4810 * m/ibms390x.h: Don't include "ibms390.h".
4812 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4814 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4815 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4817 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4819 * casetab.c (Fset_case_table):
4820 * charset.c (Fcharset_after): Fix typos.
4822 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4824 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4825 Otherwise, valgrind does not work on some platforms.
4826 Problem reported by Andreas Schwab in
4827 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4828 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4829 is set, removing the need for VIRT_ADDRESS_VARIES.
4830 (PURE_P): Use a more-efficient implementation that needs just one
4831 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4832 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4833 to 4 (xorl, subq, cmpq, setbe).
4834 * alloc.c (pure): Always extern now, since that's the
4835 VIRT_ADDR_VARIES behavior.
4836 (PURE_POINTER_P): Use a single comparison, not two, for
4837 consistency with the new puresize.h.
4838 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4839 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4840 Remove VIRT_ADDR_VARIES no longer needed.
4842 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4844 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4845 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4846 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4847 behave as if the cursor position were at the window margin.
4849 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4850 and the cursor position is out of bounds, behave as if the cursor
4851 position were at the window margin. (Bug#10075)
4853 2011-11-18 Chong Yidong <cyd@gnu.org>
4855 * window.c (Fwindow_combination_limit): Make first argument
4856 non-optional, since it is meaningless for live windows like the
4859 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4861 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4863 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4865 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4866 (graft_intervals_into_buffer): Simplify.
4868 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4870 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4871 hash values of the two rows.
4872 (copy_row_except_pointers): Preserve the used[] arrays and the
4873 hash values of the two rows. (Bug#10035)
4874 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4876 * xdisp.c (row_hash): New function, body extracted from
4877 compute_line_metrics.
4878 (compute_line_metrics): Call row_hash, instead of computing the
4881 * dispnew.c (verify_row_hash): Call row_hash for computing the
4882 hash code of a row, instead of duplicating code from xdisp.c.
4884 * dispextern.h (row_hash): Add prototype.
4886 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4888 * frame.c (delete_frame): Don't delete the terminal when the last
4889 X frame is closed if emacs is built with GTK toolkit.
4891 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4893 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4895 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4897 * window.c (Vwindow_splits): Rename to
4898 Vwindow_combination_resize. Suggested by Juri Linkov.
4899 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4902 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4904 * nsfns.m (Fns_font_name):
4905 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4907 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4909 * window.h (window): Rename slot "nest" to "combination_limit".
4910 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4911 (Fset_window_nest): Rename to Fset_window_combination_limit.
4912 (Vwindow_nest): Rename to Vwindow_combination_limit.
4913 (recombine_windows, make_parent_window, make_window)
4914 (Fsplit_window_internal, saved_window)
4915 (Fset_window_configuration, save_window_save): Rename all
4916 occurrences of window_nest to window_combination_limit.
4918 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4920 * image.c (imagemagick_load_image): Fix typo.
4922 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4924 * xdisp.c (display_line): Move the call to
4925 highlight_trailing_whitespace before the call to
4926 compute_line_metrics, since the latter needs to see the final
4927 faces of all the glyphs to compute ROW's hash value.
4928 Fixes assertion violations in row_equal_p. (Bug#10035)
4930 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4932 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4933 just return (bug#10044).
4935 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4937 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4938 with user-defined heap size. Bump the default size of the temacs
4939 heap to 27MB, to avoid memory warning when running temacs.
4940 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4942 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4943 current_matrix and desired_matrix. (Bug#9990)
4944 (verify_row_hash) [XASSERTS]: New function.
4945 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4946 that the hash value of glyph rows is correct.
4948 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4950 * window.h (window): Remove splits slot.
4951 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4952 (Fdelete_other_windows_internal, make_parent_window)
4953 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4954 (Fset_window_configuration, save_window_save): Don't deal with
4955 split status of windows.
4956 (saved_window): Remove splits slot.
4957 (Vwindow_splits): Rewrite doc-string.
4959 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4961 * xfns.c (unwind_create_frame):
4962 * nsfns.m (unwind_create_frame):
4963 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4964 Vframe_list (Bug#9999).
4966 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4968 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4970 2011-11-11 Kenichi Handa <handa@m17n.org>
4972 * callproc.c (Fcall_process): Set the member dst_multibyte of
4975 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4977 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4978 avoid a crash (bug#9496).
4980 2011-11-09 Chong Yidong <cyd@gnu.org>
4982 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4983 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4985 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4987 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4989 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4991 Avoid some portability problems by eschewing 'extern inline' functions.
4992 The trivial performance wins aren't worth the portability hassles; see
4993 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4995 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4996 (window_box_width, window_box_left, window_box_left_offset)
4997 (window_box_right, window_box_right_offset): Undo previous change,
4998 by removing the "extern"s.
4999 * intervals.c (adjust_intervals_for_insertion)
5000 (adjust_intervals_for_deletion): Undo previous change,
5001 making these static again.
5002 (offset_intervals, temp_set_point_both, temp_set_point)
5003 (copy_intervals_to_string): No longer inline.
5004 * xdisp.c (window_text_bottom_y, window_box_width)
5005 (window_box_height, window_box_left_offset)
5006 (window_box_right_offset, window_box_left, window_box_right)
5007 (window_box): No longer inline.
5009 2011-11-08 Chong Yidong <cyd@gnu.org>
5011 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5012 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5013 Signal an error if not a live window.
5014 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5015 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5017 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5019 * lisp.h (syms_of_abbrev): Remove declaration.
5020 Reported by CHENG Gao <chenggao@royau.me>.
5022 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5024 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5025 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5026 of temacs in GUI mode.
5028 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5030 * window.h: Declare delete_all_child_windows instead of
5031 delete_all_subwindows.
5032 * window.c (Fwindow_nest, Fset_window_nest)
5033 (Fset_window_new_total, Fset_window_new_normal)
5034 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5035 (delete_all_subwindows): Rename to delete_all_child_windows.
5036 (Fdelete_other_windows_internal, Fset_window_configuration):
5037 Call delete_all_child_windows instead of delete_all_subwindows.
5038 * frame.c (delete_frame): Call delete_all_child_windows instead
5039 of delete_all_subwindows.
5041 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5043 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5044 This is also needed for porting to any host where GC_MARK_STACK is
5045 not GC_MAKE_GCPROS_NOOPS.
5046 (which_symbols): Use it.
5048 2011-11-07 Kenichi Handa <handa@m17n.org>
5050 * coding.c (coding_set_destination): Check coding->src_pos only
5051 when coding->src_object is a buffer (bug#9910).
5053 * process.c (send_process): Set the member src_multibyte of coding
5054 to 0 (bug#9911) when sending a unibyte text.
5056 * callproc.c (Fcall_process): Set the member src_multibyte of
5057 process_coding to 0 (bug#9912).
5059 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5061 * xmenu.c (cleanup_widget_value_tree): New function.
5062 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5063 calling free_menubar_widget_value_tree directly (Bug#9830).
5065 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5067 Fix some portability problems with 'inline'.
5068 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5069 (window_box_width, window_box_left, window_box_left_offset)
5070 (window_box_right, window_box_right_offset): Declare extern.
5071 Otherwise, these inline functions do not conform to C99 and
5072 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5073 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5074 * intervals.c (adjust_intervals_for_insertion)
5075 (adjust_intervals_for_deletion): Now extern, because otherwise the
5076 extern inline functions 'offset_intervals' couldn't refer to it.
5077 (static_offset_intervals): Remove.
5078 (offset_intervals): Rewrite using the old contents of
5079 static_offset_intervals. The old version didn't conform to C99
5080 because an extern inline function contained a reference to an
5081 identifier with static linkage.
5083 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5085 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5088 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5090 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5091 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5092 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5093 return Qleft_to_right.
5095 2011-11-06 Chong Yidong <cyd@gnu.org>
5097 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5098 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5099 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5100 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5101 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5102 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5103 (Fwindow_vscroll): Doc fix.
5104 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5105 argument, since it makes no sense to pass a live window and for
5106 consistency with window-child.
5108 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5110 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5113 2011-11-05 Jason Rumney <jasonr@gnu.org>
5115 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5116 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5118 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5119 bitwise arithmetic preventing use of unicode-sip and non-truetype
5122 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5124 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5127 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5128 initialization code to keep similarity to xfns.c after changes
5131 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5133 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5134 (unwind_create_frame): New function (Bug#9943).
5135 (Fx_create_frame): Restructure code to be more similar to the one in
5136 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5137 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5138 Move terminal->reference_count++ just before making the frame official
5141 * nsterm.m (x_free_frame_resources): New function.
5142 (x_destroy_window): Move code to x_free_frame_resources.
5144 * xfns.c (unwind_create_frame): Fix comment.
5145 (Fx_create_frame, x_create_tip_frame):
5146 Move terminal->reference_count++ just before making the frame
5147 official. Move initialization of image_cache_refcount and
5148 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5150 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5152 Support MSVC build with newer versions of Visual Studio.
5153 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5154 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5157 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5158 which are not supported by MSVC.
5159 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5160 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5162 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5164 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5166 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5168 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5170 Support MSVC build with newer versions of Visual Studio.
5171 * w32.c: Don't include w32api.h for MSVC.
5172 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5174 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5175 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5176 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5177 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5179 (alloca) [_MSC_VER]: Define to _alloca.
5181 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5183 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5185 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5187 * xdisp.c (note_mouse_highlight): If either of
5188 previous/next-single-property-change returns nil, treat that as
5189 the beginning or the end of the buffer. (Bug#9955)
5191 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5193 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5194 label is not null (Bug#9951).
5195 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5198 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5200 * window.c (Fwindow_body_size): Mention in the doc string that the
5201 return value is in frame's canonical units. (Bug#9949)
5203 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5205 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5207 * w32fns.c (unwind_create_frame): If needed, free the glyph
5208 matrices of the partially constructed frame. (Bug#9943)
5209 * xfns.c (unwind_create_frame): Likewise.
5211 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5213 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5214 Don't stop backward scan on the continuation glyph, even though
5215 its CHARPOS is positive.
5216 (mouse_face_from_buffer_pos, note_mouse_highlight):
5217 Rename cover_string to disp_string.
5219 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5221 * window.c (temp_output_buffer_show): Don't use
5222 Vtemp_buffer_show_specifiers.
5223 (Vtemp_buffer_show_specifiers): Remove unused variable.
5225 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5227 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5228 past the beginning of the current glyph matrix.
5230 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5232 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5233 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5234 HAVE_GTK3 (Bug#9869).
5236 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5237 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5239 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5241 * xterm.c: Declare x_handle_net_wm_state to return int.
5242 (handle_one_xevent): Check if we are iconified but don't have
5243 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5244 (get_current_wm_state): Return non-zero if not hidden,
5245 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5246 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5247 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5248 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5250 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5252 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5253 so that this new function doesn't get optimized away by a
5254 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5256 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5258 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5260 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5262 Fix the `xbytecode' command.
5263 * .gdbinit (xprintbytestr): New command.
5264 (xwhichsymbols): Rename from `which'; all callers changed.
5265 (xbytecode): Print the byte-code string as well.
5267 2011-10-29 Kim Storm <storm@cua.dk>
5269 * alloc.c (which_symbols): New function.
5271 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5273 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5276 2011-10-29 Glenn Morris <rgm@gnu.org>
5278 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5279 Not clear what it was for, and it causes various bugs. (Bug#9839)
5281 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5283 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5284 possible random value that matches one of those tested as
5285 condition to clear the mouse face.
5287 2011-10-28 Chong Yidong <cyd@gnu.org>
5289 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5291 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5293 * window.c (make_window): Initialize phys_cursor_on_p.
5295 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5297 * lisp.h (struct Lisp_Symbol): Update comments.
5299 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5301 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5303 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5305 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5306 <oslsachem@gmail.com> for helping to debug this.
5308 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5309 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5310 (g_b_init_get_glyph_outline_w): New static variables.
5311 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5312 (GetGlyphOutlineW_Proc): New typedefs.
5313 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5314 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5316 (w32font_open_internal, compute_metrics):
5317 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5318 instead of calling the "wide" APIs directly.
5320 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5322 * w32.h (syms_of_w32font): Add prototype.
5324 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5326 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5327 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5328 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5329 (Fmove_to_window_line): Doc fix.
5331 2011-10-27 Chong Yidong <cyd@gnu.org>
5333 * process.c (make_process): Set gnutls_state to NULL.
5335 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5336 non-NULL, regardless of GNUTLS_INITSTAGE.
5337 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5338 an error. Set process slots as soon as we allocate them.
5340 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5342 2011-10-27 Chong Yidong <cyd@gnu.org>
5344 * gnutls.c (emacs_gnutls_deinit): New function.
5345 Deallocate credentials structures as well as calling gnutls_deinit.
5346 (Fgnutls_deinit, Fgnutls_boot): Use it.
5348 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5349 (deactivate_process): Call emacs_gnutls_deinit.
5351 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5353 * image.c (x_create_x_image_and_pixmap):
5354 * w32.c (sys_rename, w32_delayed_load):
5355 * w32font.c (fill_in_logfont):
5356 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5358 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5360 * w32fns.c (w32_default_color_map): New function,
5361 extracted from Fw32_default_color_map.
5362 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5364 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5366 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5368 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5370 * keyboard.c (test_undefined): New function (bug#9751).
5371 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5373 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5375 * sysdep.c (init_sys_modes): Fix the check for the controlling
5376 terminal (Bug#6649).
5378 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5380 * dispextern.h (struct bidi_it): New member next_en_type.
5382 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5383 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5384 current character, check also for next_en_type being WEAK_EN.
5385 (bidi_resolve_weak): Don't enter the expensive loop if the current
5386 position is before next_en_pos. Record the bidi type of the first
5387 non-ET, non-BN character we find, in addition to its position.
5388 (bidi_level_of_next_char): Invalidate next_en_type when
5389 next_en_pos is over-stepped.
5391 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5393 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5394 * editfns.c: Rewrite current-time-zone so that it invokes
5395 the equivalent of (format-time-string "%Z") to get the time zone name.
5396 This fixes a bug when the time zone name contains characters that
5397 need converting from the system time locale to Emacs internal format.
5398 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5399 that patch fixed format-time-string to do the conversion, but
5400 I forgot to fix current-time-zone.
5401 (format_time_string): New function, containing most of
5402 what Fformat_time_string used to contain.
5403 (Fformat_time_string): Rewrite in terms of format_time_string.
5404 This doesn't change this function's behavior.
5405 (current-time-zone): Rewrite to use format_time_string.
5406 This fixes the bug reported by Michael Schierl in
5407 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5408 Jason Rumney's 2007-06-07 change worked around this bug, but
5410 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5412 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5414 * xdisp.c (start_display): If the character at POS is displayed
5415 via a display vector, reset IT->current.dpvec_index to zero.
5416 (try_window_reusing_current_matrix): If a line ends in a display
5417 vector or the next line starts in a display vector, continue
5418 redrawing the window even though the character position of
5419 start_row was reached.
5422 2011-10-18 Chong Yidong <cyd@gnu.org>
5424 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5425 with nobreak-char-display too.
5427 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5429 Fix part 3 of bug#9771.
5430 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5431 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5432 non-neutral characters if the current character is a paragraph
5433 separator (a.k.a. Newline). This avoids running the same
5434 expensive loop twice, once when we consume the preceding newline
5435 and the other time when the line actually needs to be displayed.
5436 Avoid the loop when we see neutrals on the base embedding level
5437 following a character whose directionality is the same as the
5438 paragraph's. This avoids running the expensive loop when a line
5439 ends in a long sequence of neutrals, like control characters.
5440 Add assertion against STRONG_AL type. Slightly rearrange code
5441 that determines the type of a neutral given the first non-neutral
5443 (bidi_level_of_next_char): Set next_en_pos to zero when
5444 invalidating its info.
5446 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5448 * xdisp.c (push_display_prop): Determine whether to record string
5449 or buffer position by IT->string, not by IT->method. Allow
5450 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5451 (move_it_vertically_backward): Don't look for character position
5452 immediately after the newline when in a continuation line.
5455 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5457 * window.c (coordinates_in_window): Rewrite and delabelize
5458 vertical border check. (Bug#5357) (Bug#9618)
5460 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5462 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5463 errors in XSetWindowBorder (bug#9310).
5465 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5467 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5468 avoid crash when xmalloc overrun checking is enabled.
5470 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5472 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5473 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5474 cursor motion with <left> and <right> arrow keys.
5476 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5477 some callers set that themselves.
5479 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5481 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5482 display string and the previous row comes from the same string and
5483 is empty. (Bug#9739) (Bug#9738)
5485 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5487 * doc.c (get_doc_string): Encode file name (bug#9735).
5489 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5491 * bidi.c (bidi_level_of_next_char):
5492 * xdisp.c (get_visually_first_element): Remove old incorrect
5493 comments regarding the Unicode Line Separator character.
5495 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5497 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5499 * alloc.c (Fgc_status): Do not access beyond zombies array
5500 boundary if nzombies > MAX_ZOMBIES.
5501 * alloc.c (dump_zombies): Add missing format specifier.
5503 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5505 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5506 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5508 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5509 Some packages use them to denote characters with modifiers.
5511 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5513 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5514 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5515 matching a pp-number. Rename parameter var to var1.
5517 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5519 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5521 2011-10-08 Glenn Morris <rgm@gnu.org>
5523 * callint.c (Fcall_interactively): Give a more explicit error for the
5524 'c' case with a non-character input. (Bug#8479)
5526 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5528 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5530 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5531 lines that are hscrolled on the left.
5533 * dispnew.c (buffer_posn_from_coords): Account for a possible
5534 presence of header-line. (Bug#4426)
5536 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5538 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5539 Don't advertise functionality which we discourage or doesn't work.
5541 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5543 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5544 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5545 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5546 this makes Emacs dump core during garbage collection on rare
5547 occasions. sizeof is obviously inferior to offsetof here, so
5548 stick with offsetof.
5549 (GC_POINTER_ALIGNMENT): New macro.
5550 (mark_memory): Omit 3rd (offset) arg; caller changed.
5551 Don't assume EMACS_INT alignment is the same as pointer alignment.
5553 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5555 * keyboard.c (read_key_sequence_remapped): New var.
5556 (read_key_sequence): Compute remapping in the right buffer.
5557 (command_loop_1): Use read_key_sequence's remapping directly.
5559 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5561 * dired.c (file_name_completion): Don't expand file name.
5562 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5563 before checking file name handler.
5565 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5566 they've been requested explicitly (bug#9591).
5568 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5570 * keymap.c (Fsingle_key_description): Use make_specified_string
5571 instead of build_string to build string from push_key_description.
5574 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5576 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5577 This fixes a Y2038 bug on 64-bit hosts.
5578 * buffer.c (reset_buffer):
5579 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5580 (Fclear_buffer_auto_save_failure):
5581 Use 0, not -1, to represent an unset failure time, since time_t
5582 might not be signed.
5584 Remove dependency on glibc malloc internals.
5585 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5586 Move back here from lisp.h, but with their new implementations.
5587 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5588 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5589 * charset.c (charset_table_init): New static var.
5590 (syms_of_charset): Use it instead of xmalloc. This removes a
5591 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5592 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5593 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5594 Move back to alloc.c.
5595 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5596 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5598 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5600 * nsterm.m (windowDidResize): Call x_set_window_size only when
5601 ns_in_resize is true. Otherwise set pixelwidth/height and
5602 call change_frame_size (Bug#9628).
5604 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5606 Port --enable-checking=all to Fedora 14 x86-64.
5607 * charset.c (syms_of_charset): Also account for glibc malloc's
5608 internal overhead when calculating the initial malloc maximum.
5610 Port --enable-checking=all to Fedora 14 x86.
5611 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5613 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5614 (overrun_check_realloc, overrun_check_free):
5615 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5616 That way, xmalloc returns a properly-aligned pointer even if
5617 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5618 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5619 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5620 into account when calculating the initial malloc maximum.
5621 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5622 Move here from alloc.c, so that charset.c can use it too.
5623 Properly align; the old code wasn't right for common 32-bit hosts
5624 when configured with --enable-checking=all.
5625 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5626 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5628 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5630 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5633 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5635 * xdisp.c (compute_display_string_end): If there's no display
5636 string at CHARPOS, return -1.
5638 * bidi.c (bidi_fetch_char): When compute_display_string_end
5639 returns a negative value, treat the character as a normal
5640 character not covered by a display string. (Bug#9624)
5642 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5644 * lread.c (Fread_from_string): Fix typo in docstring.
5646 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5648 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5649 newline, reseat the iterator instead of bidi-iterating there one
5650 character at a time. (Bug#9610)
5651 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5652 TO_CHARPOS if the bidi iterator is at base embedding level.
5654 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5656 * lread.c (readevalloop): Use correct code for NBSP.
5657 (read1): Likewise. (Bug#9608)
5659 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5661 * dbusbind.c (Fdbus_register_signal): When service is not
5662 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5664 2011-09-25 Glenn Morris <rgm@gnu.org>
5666 * buffer.c (truncate-lines): Doc fix.
5668 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5670 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5671 (Fset_window_next_buffers): Doc fix.
5673 2011-09-24 Glenn Morris <rgm@gnu.org>
5675 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5677 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5679 Fix minor problems found by static checking.
5680 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5681 * indent.c (Fvertical_motion): Fix == vs = typo.
5683 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5685 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5686 Default value is now t. Doc fix.
5688 * indent.c (Fvertical_motion): Compute and apply the overshoot
5689 logic when moving up, not only when moving down. Fix the
5690 confusing name and values of the it_overshoot_expected variable;
5691 logic changes accordingly. (Bug#9254) (Bug#9549)
5693 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5694 CHARPOS is covered by a display string which includes newlines.
5695 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5696 is covered by a display string with embedded newlines.
5698 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5700 * dbusbind.c (Fdbus_register_signal): Add match rule to
5701 Vdbus_registered_objects_table. (Bug#9581)
5702 (Fdbus_register_method, Vdbus_registered_objects_table):
5705 2011-09-24 Jim Meyering <meyering@redhat.com>
5707 do not ignore write error for any output size
5708 The previous change was incomplete.
5709 While it makes emacs --batch detect the vast majority of stdout
5710 write failures, errors were still ignored whenever the output size is
5711 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5712 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5713 && echo FAIL: ignored write error
5714 FAIL: ignored write error
5715 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5716 && echo FAIL: ignored write error
5717 FAIL: ignored write error
5718 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5720 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5722 * emacs.c (Fkill_emacs): In noninteractive mode exit
5723 non-successfully if a write error occurred on stdout. (Bug#9574)
5725 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5727 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5730 * dispextern.h (struct it): Update the comment documenting what
5733 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5735 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5736 a display string, extend search for cursor position to end of row.
5737 (find_row_edges): If the row ends in a newline from a display
5738 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5739 Handle the case of a display string with multiple newlines.
5740 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5741 non-empty line. Fixes confusing cursor motion with arrow keys at
5742 the beginning of a line that starts with whitespace.
5744 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5746 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5749 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5751 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5754 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5756 * xdisp.c (display_line): Record maximum and minimum buffer
5757 positions even if no glyphs were produced (e.g., by a zero-width
5758 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5759 buffer positions that will be removed from the glyph row because
5761 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5762 column is beyond frame width: don't subtract 1 "pixel" when
5763 computing width of the stretch.
5764 (reseat_at_next_visible_line_start): Undo the change made on
5765 2011-09-17 that saved paragraph information and restored it after
5766 the call to `reseat'. (Bug#9545)
5768 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5770 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5771 and turn window cursor on if cleared (Bug#9415).
5773 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5775 * search.c (boyer_moore): Take unibyte characters from pattern
5776 literally. (Bug#9458)
5778 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5780 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5782 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5784 Fix minor problem found by static checking.
5785 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5786 initialized, to pacify gcc -Wuninitialized.
5788 * fileio.c: Report proper errno when syscall falls.
5789 (Finsert_file_contents): Save and restore errno,
5790 so that report_file_error outputs the correct diagnostic.
5791 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5793 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5795 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5797 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5799 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5800 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5802 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5804 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5805 about the current paragraph and restore it after the call to reseat.
5807 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5808 (bidi_find_paragraph_start): Search back for paragraph beginning
5809 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5810 (bidi_move_to_visually_next): Only trigger paragraph-related
5811 computations when the last character is a newline or at EOB, not
5812 just any NEUTRAL_B. (Bug#9470)
5814 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5815 truncated lines if point is covered by a display string. (Bug#9524)
5817 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5819 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5820 (cons_to_x_long): New function.
5821 (lisp_data_to_selection_data): Use it. Correct the test for
5822 short-versus-long data; it was negated. Break out of vector
5823 loop, for efficiency, when a long datum is discovered.
5825 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5827 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5829 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5831 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5832 GCC PR/17406) by declaring this function with external scope.
5834 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5836 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5837 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5839 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5841 * editfns.c (Fformat): Correctly handle text properties on "%%".
5843 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5845 * xterm.c (x_draw_composite_glyph_string_foreground):
5846 * w32term.c (x_draw_composite_glyph_string_foreground):
5847 * term.c (encode_terminal_code):
5848 * composite.c (composition_update_it, get_composition_id):
5849 * xdisp.c (get_next_display_element)
5850 (fill_composite_glyph_string): Add comments about special meaning
5851 of TAB characters in a composition.
5853 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5855 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5856 This occurs when processing a multibyte format.
5857 Problem reported by Wolfgang Jenker.
5859 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5861 * xdisp.c (try_cursor_movement): Only check for exact match if
5862 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5864 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5866 Remove unused external symbols.
5867 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5868 * xdisp.c (calc_pixel_width_or_height): Now static.
5869 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5870 * indent.c (check_display_width):
5871 * w32term.c: Fix comment to match code.
5872 * xterm.c, xterm.h (x_catching_errors): Remove.
5874 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5876 * xselect.c: Use signed conversions more consistently (Bug#9498).
5877 (selection_data_to_lisp_data): Assume incoming selection data are
5878 signed integers, not unsigned. This is to be consistent with
5879 outgoing selection data, which was modified to use signed integers
5880 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5881 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5882 expects long, not unsigned long.
5884 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5886 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5887 computation of loop end. Reported by Johan Bockgård
5890 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5892 * frame.c (Fother_visible_frames_p): Function deleted.
5894 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5896 * indent.c (compute_motion): Process display vector front to back
5897 rather than the other way around. (Bug#2496)
5899 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5901 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5903 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5905 * minibuf.c (Fread_from_minibuffer): Doc fix.
5907 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5909 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5910 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5912 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5914 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5915 value for non-existent files.
5917 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5919 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5920 set its "size" to -1. This will set the modtime_size field of
5921 the corresponding buffer to -1, which is what
5922 verify-visited-file-modtime expects for files that do not exist.
5925 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5927 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5929 * lisp.h: ... from here. push_key_description is no longer
5930 defined in keyboard.c, so its declaration should not be in
5931 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5932 logically belongs with push_key_description.
5934 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5936 * buffer.h: Include <sys/types.h> instead of <time.h>.
5937 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5938 Problem reported by Herbert J. Skuhra.
5940 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5942 * xml.c (parse_region): Make the parsing work for
5943 non-comment-starting XML files again (bug#9144).
5945 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5947 * image.c (gif_load): Fix calculation of bottom and right corner.
5950 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5952 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5953 redisplay in small windows.
5955 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5957 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5959 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5961 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5962 Operate on live windows only.
5964 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5966 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5968 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5970 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5971 only under bidi iteration.
5973 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5975 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5977 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5979 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5980 Without this fix, the command to link temacs failed due to an
5981 undefined symbol __builtin_isnan. This is because
5982 /usr/include/iso/math_c99.h #defines isnan(x) to
5983 __builtin_isnan(x), but the bundled gcc, which identifies itself
5984 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5986 * floatfns.c (isnan): #undef, and then #define to a clone of
5988 (Fisnan): Always define, since it's always available now.
5989 (syms_of_floatfns): Always define isnan at the Lisp level.
5991 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5993 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5995 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5997 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5998 The previous code assumed that file offsets (off_t values) fit in
5999 EMACS_INT variables, which is not true on typical 32-bit hosts.
6000 The code messed up by falsely reporting buffer overflow in cases
6001 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6002 when "big" contains more than 2**29 bytes, even though this
6003 inserts just one byte and does not overflow the buffer.
6004 (Finsert_file_contents): Store file offsets as off_t
6005 values, not as EMACS_INT values. Check for overflow when
6006 converting between EMACS_INT and off_t. When checking for
6007 buffer overflow or for overlap, take the offsets into account.
6008 Don't use EMACS_INT for small values where int suffices.
6009 When checking for overlap, fix a typo: ZV was used where
6010 ZV_BYTE was intended.
6011 (Fwrite_region): Don't assume off_t fits into 'long'.
6012 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6014 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6016 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6018 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6020 sprintf-related integer and memory overflow issues (Bug#9412).
6022 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6023 (esprintf, exprintf, evxprintf): New functions.
6024 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6025 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6026 (modify_event_symbol): Do not assume that the length of
6027 name_alist_or_stem is safe to alloca and fits in int.
6028 (Fexecute_extended_command): Likewise for function name and binding.
6029 (Frecursion_depth): Wrap around reliably on integer overflow.
6030 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6031 since some callers pass EMACS_INT values.
6032 (Fsingle_key_description): Don't crash if symbol name contains more
6033 than MAX_ALLOCA bytes.
6034 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6035 (get_minibuffer): Arg is now EMACS_INT, not int.
6036 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6037 (esprintf, exprintf, evxprintf): New decls.
6038 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6040 * dbusbind.c (signature_cat): New function.
6041 (xd_signature, Fdbus_register_signal):
6042 Do not overrun buffer; instead, report string overflow.
6044 * dispnew.c (add_window_display_history): Don't overrun buffer.
6045 Truncate instead; this is OK since it's just a log.
6047 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6048 even if the time zone offset is outlandishly large.
6049 Don't mishandle offset == INT_MIN.
6051 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6052 when creating daemon; the previous buffer-overflow check was incorrect.
6054 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6055 which has the guts of the old verror function.
6057 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6058 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6060 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6061 (font_unparse_xlfd): Don't blindly alloca long strings.
6062 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6063 fits in int, when using sprintf. Use single snprintf to count
6064 length of string rather than counting it via multiple sprintfs;
6065 that's simpler and more reliable.
6066 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6067 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6068 sprintf, in case result does not fit in int.
6070 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6071 (fontset_from_font): Print it.
6073 * frame.c (tty_frame_count): Now printmax_t, not int.
6074 (make_terminal_frame, set_term_frame_name): Print it.
6075 (x_report_frame_params): In X, window IDs are unsigned long,
6076 not signed long, so print them as unsigned.
6077 (validate_x_resource_name): Check for implausibly long names,
6078 and don't assume name length fits in 'int'.
6079 (x_get_resource_string): Don't blindly alloca invocation name;
6080 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6083 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6084 (xg_check_special_colors, xg_set_geometry):
6085 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6087 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6088 Use esprintf, not sprintf, in case result does not fit in int.
6090 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6091 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6092 it as a large positive number.
6093 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6094 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6096 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6097 in case result does not fit in int.
6099 * print.c (float_to_string): Detect width overflow more reliably.
6100 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6101 buffer overrun. Don't assume list length fits in 'int'. Treat
6102 print length of 0 as 0, not as infinity; to be consistent with other
6103 uses of print length in this function. Don't overflow print length
6104 index. Don't assume hash table size fits in 'long', or that
6105 vectorlike size fits in 'unsigned long'.
6107 * process.c (make_process): Use printmax_t, not int, to format
6108 process-name gensyms.
6110 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6112 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6113 to avoid potential buffer overrun.
6115 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6116 if X resource line is longer than 512 bytes.
6118 * xfns.c (x_window): Make sprintf buffer a bit bigger
6119 to avoid potential buffer overrun.
6121 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6123 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6125 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6127 Integer overflow fixes for scrolling, etc.
6128 Without these, Emacs silently mishandles large integers sometimes.
6129 For example, "C-u 4294967297 M-x recenter" was treated as if
6130 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6132 * xdisp.c (try_window_id): Check Emacs fixnum range before
6133 converting to 'int'.
6135 * window.c (window_scroll_line_based, Frecenter):
6136 Check that an Emacs fixnum is in range before assigning it to 'int'.
6137 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6138 values converted from Emacs fixnums.
6139 (Frecenter): Don't wrap around a line count if it is out of 'int'
6140 range; instead, treat it as an extreme value.
6141 (Fset_window_configuration, compare_window_configurations):
6142 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6144 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6145 that can exceed INT_MAX. Check that EMACS_INT value is in range
6146 before assigning it to the (possibly-narrower) index.
6147 (match_limit): Don't assume that a fixnum can fit in 'int'.
6149 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6152 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6153 (Fvertical_motion): Don't wrap around LINES values that don't fit
6154 in 'int'. Instead, treat them as extreme values. This is good
6155 enough for windows, which can't have more than INT_MAX lines anyway.
6157 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6159 * Require libxml/parser.h to avoid compilation warning.
6161 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6163 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6164 since this reportedly can destroy thread storage.
6166 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6168 * syntax.c (find_defun_start): Update all cache variables if
6169 exiting early (Bug#9401).
6171 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6173 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6175 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6176 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6177 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6179 * term.c (tty_append_glyph): New function.
6180 (produce_stretch_glyph): Static function and its prototype deleted.
6182 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6185 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6187 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6188 when checking :margin (Bug#9390).
6189 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6190 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6191 so that the name doesn't mislead. All uses changed.
6193 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6195 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6198 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6200 * xdisp.c (move_it_to): Don't bail out early when reaching
6201 position beyond to_charpos, if we are scanning backwards.
6202 (move_it_vertically_backward): When DY == 0, make sure we get to
6203 the first character in the line after the newline.
6205 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6207 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6208 (ccl_driver): Do not generate an out-of-range pointer.
6209 (Fccl_execute_on_string): Remove unnecessary check for
6210 integer overflow, noted by Stefan Monnier in
6211 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6212 Remove a FIXME that didn't need fixing.
6213 Simplify the newly-introduced buffer reallocation code.
6215 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6217 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6219 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6221 Integer and memory overflow issues (Bug#9196).
6223 * doc.c (get_doc_string): Rework so that
6224 get_doc_string_buffer_size is the actual buffer size, rather than
6225 being 1 less than the actual buffer size; this makes xpalloc more
6228 * image.c (x_allocate_bitmap_record, cache_image):
6229 * xselect.c (Fx_register_dnd_atom):
6230 Simplify previous changes by using xpalloc.
6232 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6233 since either will do and ptrdiff_t is convenient with xpalloc.
6235 * charset.c (charset_table_size)
6236 (struct charset_sort_data.priority): Now ptrdiff_t.
6237 (charset_compare): Don't overflow if priorities differ greatly.
6238 (Fsort_charsets): Don't assume list length fits in int.
6239 Check for size-calculation overflow when allocating sort data.
6240 (syms_of_charset): Allocate an initial charset table that is
6241 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6243 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6245 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6246 The actual value is always <= INT_MAX, and leaving it unsigned made
6247 overflow checking harder.
6249 * dispextern.h (struct glyph_matrix.rows_allocated)
6250 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6251 with xpalloc. The values are still always <= INT_MAX.
6253 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6255 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6256 (SAFE_NALLOCA): New macro.
6258 * region-cache.c (struct boundary.pos, find_cache_boundary)
6259 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6260 (set_cache_region, invalidate_region_cache)
6261 (revalidate_region_cache, know_region_cache, region_cache_forward)
6262 (region_cache_backward, pp_cache):
6263 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6264 so that ptrdiff_t * can be passed to xpalloc.
6265 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6266 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6267 (pp_cache): Don't assume cache_len fits in int.
6268 * region-cache.h: Adjust extern decls to match.
6270 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6271 EMACS_INT, since either will do, for xpalloc.
6273 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6274 (xnmalloc, xnrealloc, xpalloc): New functions.
6276 * bidi.c (bidi_shelve_header_size): New constant.
6277 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6278 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6280 * bidi.c (bidi_cache_shrink):
6281 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6283 Don't update size of array until after memory allocation succeeds,
6284 because xmalloc/xrealloc may not return.
6285 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6286 now that we have proper integer overflow checking.
6287 (record_overlay_string, overlay_strings): Catch overflows when
6288 calculating size of overlay_str_buf.
6290 * callproc.c (Fcall_process): Check for size overflow when
6291 calculating size of args2.
6292 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6293 Normally we prefer signed values, but sticking with ptrdiff_t would
6294 require adding more-complicated checks.
6296 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6297 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6298 Redo buffer-overflow calculations to avoid integer overflow.
6299 Add a FIXME comment where memory seems to be over-allocated.
6301 * character.c (Fstring): Check for size-calculation overflow.
6303 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6304 unnecessary integer overflow. Check for size overflow.
6305 (encode_coding_object): Don't update size until xmalloc succeeds.
6307 * composite.c (get_composition_id): Check for overflow in glyph
6308 length calculations.
6310 Integer and memory overflow fixes for display code.
6311 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6312 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6313 (scrolling_window): Check for overflow in size calculations.
6314 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6315 Don't assume glyph table len fits in int.
6316 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6317 (row_table_size): Now ptrdiff_t, not int.
6318 (scrolling_window): Avoid overflow in size calculations.
6319 Don't update size until allocation succeeds.
6320 * fns.c (concat): Check for overflow in size calculations.
6321 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6322 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6323 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6325 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6326 (get_doc_string): Check for size calculation overflow.
6327 Don't update size until allocation succeeds.
6328 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6329 EMACS_INT, where ptrdiff_t will do.
6330 (Fsubstitute_command_keys): Check for string overflow.
6332 * editfns.c (set_time_zone_rule): Don't assume environment length
6334 (message_length): Now ptrdiff_t, not int.
6335 (Fmessage_box): Don't update size until allocation succeeds.
6336 Don't assume message length fits in int.
6337 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6339 * emacs.c (main): Do not reallocate argv, since there is a null at
6340 the end that can be overwritten, and this way there's no need to
6341 worry about size-calculation overflow.
6342 (sort_args): Check for size-calculation overflow.
6344 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6346 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6348 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6349 (x_set_scroll_bar_width, x_figure_window_size):
6350 Check for integer overflow.
6351 (x_set_alpha): Do not assume XINT fits in int.
6353 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6354 This is for the members text_lines, text_cols, total_lines, total_cols,
6355 where the system imposes an 'int' limit.
6357 * fringe.c (Fdefine_fringe_bitmap):
6358 Don't update size until alloc works.
6360 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6361 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6363 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6364 Check for size-calculation overflow.
6365 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6366 do, as we prefer signed integers.
6367 (id_to_widget.max_size, id_to_widget.used)
6368 (xg_store_widget_in_map, xg_remove_widget_from_map)
6369 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6370 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6371 Use and return ptrdiff_t, not int.
6372 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6373 * gtkutil.h: Change prototypes to match the above.
6375 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6376 are duplicate now that they've been promoted to lisp.h.
6377 (x_allocate_bitmap_record, x_alloc_image_color)
6378 (make_image_cache, cache_image, xpm_load):
6379 Don't update size until alloc is done.
6380 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6382 Check for size calculation overflow.
6383 (ct_colors_allocated_max): New constant.
6384 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6387 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6388 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6389 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6390 Use ptrdiff_t, not int, to count maps.
6391 (read_char_minibuf_menu_prompt): Check for overflow in size
6392 calculations. Don't update size until allocation succeeds.
6393 Redo calculations to avoid overflow.
6394 * keyboard.h: Change prototypes to match the above.
6396 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6398 (current_minor_maps): Check for size calculation overflow.
6399 * keymap.h: Change prototypes to match the above.
6401 * lread.c (read1, init_obarray): Don't update size until alloc done.
6403 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6404 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6406 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6407 Now ptrdiff_t, not int.
6408 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6409 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6411 * process.c (Fnetwork_interface_list): Check for overflow
6412 in size calculation.
6414 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6416 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6417 overflow. Don't bother calling xmalloc when xrealloc will do.
6419 * search.c (Freplace_match): Check for size calculation overflow.
6420 (Fset_match_data): Don't assume list lengths fit in 'int'.
6422 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6423 for command line length. Do not attempt to address one before the
6424 beginning of an array, as that's not portable.
6426 * term.c (max_frame_lines): Remove; unused.
6427 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6429 (encode_terminal_code, calculate_costs): Check for size
6430 calculation overflow.
6431 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6432 table lengths and related sizes. Don't update size until alloc
6433 done. Redo calculations to avoid overflow.
6434 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6436 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6437 subtracting pointers.
6438 (gobble_line): Check for overflow more carefully. Don't update size
6441 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6442 Don't update size until alloc done.
6443 Redo size calculations to avoid overflow.
6444 Check for size calculation overflow.
6445 (main) [DEBUG]: Fix typo in invoking tparam1.
6447 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6448 Use ptrdiff_t, not int, for sizes.
6449 (store_mode_line_noprop_char): Don't update size until alloc done.
6451 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6452 Use ptrdiff_t, not int, for sizes.
6453 (Finternal_make_lisp_face, cache_face):
6454 Check for size calculation overflow.
6455 (cache_face): Treat size calculation overflows as if they were
6456 memory exhaustion (the usual treatment), rather than aborting.
6458 * xfns.c (x_encode_text, x_set_name_internal)
6459 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6460 sizes, since they can exceed INT_MAX in size. Check for size
6461 calculation overflow.
6463 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6464 (xg_select): Check for size calculation overflow.
6465 Don't update size until alloc done.
6467 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6468 as sprintf is limited to int lengths.
6470 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6471 (X_LONG_MIN): New macros.
6472 Use them to make the following changes clearer.
6473 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6474 This change doesn't affect the value now, but it may help remind
6475 future maintainers not to raise the value too much later.
6476 (SELECTION_QUANTUM): Remove, replacing with ...
6477 (selection_quantum): ... new function, which avoids overflow.
6479 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6480 assumption that selection length fits in 'int'.
6481 (x_reply_selection_request, x_handle_selection_request)
6482 (x_get_window_property, receive_incremental_selection)
6483 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6484 (lisp_data_to_selection_data, clean_local_selection_data):
6485 Use ptrdiff_t, not int, to record length of selection.
6486 (x_reply_selection_request, x_get_window_property)
6487 (receive_incremental_selection, x_property_data_to_lisp):
6488 Redo calculations to avoid overflow.
6489 (x_reply_selection_request): When sending hint, ceiling it at
6490 X_LONG_MAX rather than relying on wraparound overflow to send
6492 (x_get_window_property, receive_incremental_selection)
6493 (lisp_data_to_selection_data, x_property_data_to_lisp):
6494 Check for size-calculation overflow.
6495 (x_get_window_property, receive_incremental_selection)
6496 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6497 Don't store size until memory allocation succeeds.
6498 (x_get_window_property): Plug memory leak on memory exhaustion.
6499 Don't double-block input; malloc is safe here. Don't assume 2**34
6500 - 4 fits in unsigned long. Add an xassert to check
6501 XGetWindowProperty overflow. Be more careful about overflow
6502 calculations, and distinguish size from memory overflow better.
6503 (receive_incremental_selection): When tracing, don't assume
6504 unsigned int is less than INT_MAX.
6505 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6506 harmful) conversions of unsigned short to int.
6507 (lisp_data_to_selection_data): Don't assume that integers
6508 in the range -65535 through -1 fit in an X unsigned short.
6509 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6510 result parameters unless successful. Rely on cons_to_unsigned
6511 to report problems with elements; the old code wasn't right anyway.
6512 (x_check_property_data): Check for int overflow; we cannot use
6513 a wider type due to X limits.
6514 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6516 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6518 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6519 (x_term_init): Check for size calculation overflow.
6520 (x_color_cells): Don't store size until memory allocation succeeds.
6521 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6522 Don't assume alloca size is less than MAX_ALLOCA.
6523 (x_term_init): Don't assume length fits in int (sprintf is limited
6526 Use ptrdiff_t for composition IDs.
6527 * character.c (lisp_string_width):
6528 * composite.c (composition_table_size, n_compositions)
6529 (get_composition_id, composition_gstring_from_id):
6530 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6531 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6532 * window.c (Frecenter):
6533 Use ptrdiff_t, not int, for composition IDs.
6534 * composite.c (get_composition_id): Check for integer overflow.
6535 * composite.h: Adjust prototypes to match the above changes.
6537 Use ptrdiff_t for hash table indexes.
6538 * category.c (hash_get_category_set):
6539 * ccl.c (ccl_driver):
6540 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6541 * coding.c (coding_system_charset_list, detect_coding_system):
6542 * coding.h (struct coding_system.id):
6543 * composite.c (get_composition_id, gstring_lookup_cache):
6544 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6545 * image.c (xpm_get_color_table_h):
6546 * lisp.h (hash_lookup, hash_put):
6547 * minibuf.c (Ftest_completion):
6548 Use ptrdiff_t for hash table indexes, not int (which is too
6549 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6550 32-bit --with-wide-int hosts).
6552 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6553 Add a FIXME comment about memory leaks.
6554 (syms_of_charset): Don't assume xmalloc returns.
6556 Don't assume that stated character widths fit in int.
6557 * character.c (Fchar_width, c_string_width, lisp_string_width):
6558 * character.h (CHAR_WIDTH):
6559 * indent.c (MULTIBYTE_BYTES_WIDTH):
6560 Use sanitize_char_width to avoid undefined and/or bad behavior
6561 with outlandish widths.
6562 * character.h (sanitize_tab_width): Rename from sanitize_width,
6563 now that we have two such functions. All uses changed.
6564 (sanitize_char_width): New inline function.
6566 Don't assume that tab-width fits in int.
6567 * character.h (sanitize_width): New inline function.
6568 (SANE_TAB_WIDTH): New macro.
6569 (ASCII_CHAR_WIDTH): Use it.
6570 * indent.c (sane_tab_width): Remove. All uses replaced by
6571 SANE_TAB_WIDTH (current_buffer).
6572 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6574 * fileio.c: Integer overflow issues with file modes.
6575 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6577 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6578 Remove unreachable code.
6579 (read_hex, load_charset_map_from_file): Check for integer overflow.
6581 * xterm.c: Don't go over XClientMessageEvent limit.
6582 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6583 (x_send_scroll_bar_event): Likewise. Check that the size does not
6584 exceed limits imposed by XClientMessageEvent, as well as the usual
6585 ptrdiff_t and size_t limits.
6587 * keyboard.c: Overflow, signedness and related fixes.
6588 (make_lispy_movement): Use same integer type in forward decl
6589 that is used in the definition.
6590 (read_key_sequence, keyremap_step):
6591 Change bufsize argument back to int, undoing my 2011-03-30 change.
6592 We prefer signed types, and int is wide enough here.
6593 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6594 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6595 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6596 length, not size_t. Use ptrdiff_t for index, not int.
6597 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6598 possibility of integer overflow.
6600 Overflow, signedness and related fixes for images.
6602 * dispextern.h (struct it.stack[0].u.image.image_id)
6603 (struct_it.image_id, struct image.id, struct image_cache.size)
6604 (struct image_cache.used, struct image_cache.ref_count):
6605 * gtkutil.c (update_frame_tool_bar):
6606 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6607 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6608 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6609 * nsmenu.m (update_frame_tool_bar):
6610 * xdisp.c (calc_pixel_width_or_height):
6611 * xfns.c (image_cache_refcount):
6612 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6613 on typical 64-bit hosts.
6615 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6616 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6617 Omit unnecessary casts to int.
6618 (parse_image_spec): Check that integers fall into 'int' range
6619 when the callers expect that.
6620 (image_ascent): Redo ascent calculation to avoid int overflow.
6621 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6622 (lookup_image): Remove unnecessary tests.
6623 (xbm_image_p): Locals are now of int, not EMACS_INT,
6624 since parse_image_check makes sure they fit into int.
6625 (png_load, gif_load, svg_load_image):
6626 Prefer int to unsigned where either will do.
6627 (tiff_handler): New function, combining the cores of the
6628 old tiff_error_handler and tiff_warning_handler.
6629 This function is rewritten to use vsnprintf and thereby avoid
6630 stack buffer overflows. It uses only the features of vsnprintf
6631 that are common to both POSIX and native Microsoft.
6632 (tiff_error_handler, tiff_warning_handler): Use it.
6633 (tiff_load, gif_load, imagemagick_load_image):
6634 Don't assume :index value fits in 'int'.
6635 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6636 (imagemagick_load_image): Check that crop parameters fit into
6637 the integer types that MagickCropImage accepts. Don't assume
6638 Vimagemagick_render_type has a nonnegative value. Don't assume
6639 size_t fits in 'long'.
6640 (gs_load): Use printmax_t to print the widest integers possible.
6641 Check for integer overflow when computing image height and width.
6643 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6645 * xdisp.c (redisplay_window): Don't force window start if point
6646 will be invisible in the resulting window. (Bug#9324)
6648 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6650 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6651 the display spec is of the form `(space ...)'.
6652 (handle_display_spec): Return the value returned by
6653 handle_single_display_spec, not just 1 or zero.
6654 (handle_single_display_spec): If the display spec is of the form
6655 `(space ...)', and specifies display in the text area, return 2
6657 (try_cursor_movement): Check for the need to scroll more
6658 accurately, and prefer exact match for point under bidi.
6659 Don't advance `row' beyond the last row of the window.
6661 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6662 into disp_prop; all users changed.
6664 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6665 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6666 for the text covered by the display property.
6668 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6670 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6671 Change return value to nil.
6672 (Frecord_buffer): Delete unused function.
6674 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6676 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6677 buffers, return left-to-right.
6678 (set_cursor_from_row): Consider candidate row a win if its glyph
6679 represents a newline and point is on that newline. Fixes cursor
6680 positioning on the newline at EOL of R2L text within L2R
6681 paragraph, and vice versa.
6682 (try_cursor_movement): Check continued rows, in addition to
6683 continuation rows. Fixes unwarranted scroll when point enters a
6684 continued line of R2L text within an L2R paragraph, or vice versa.
6685 (cursor_row_p): Consider the case of point being equal to
6686 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6687 from the end of a short line to the beginning of a continued line
6688 of R2L text within L2R paragraph.
6689 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6690 composed characters.
6692 * bidi.c (bidi_check_type): Use xassert.
6693 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6696 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6698 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6701 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6703 * nsfont.m (ns_otf_to_script): Fix typo.
6705 2011-08-22 Kenichi Handa <handa@m17n.org>
6707 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6708 extra slot even if the purpose is char-code-property-table.
6710 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6712 * xdisp.c (redisplay_window): When computing centering_position,
6713 account for the height of the header line. (Bug#8874)
6715 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6716 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6717 candidate is selected by the mouse, and that candidate has a
6718 composed character under the mouse.
6720 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6721 coordinates reported by pos-visible-in-window-p for a composed
6722 character in column zero.
6724 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6726 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6728 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6730 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6731 consider it a hit if to_charpos is anywhere in the range of the
6732 composed buffer positions.
6734 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6736 * image.c (gif_load): Don't assume that each subimage has the same
6737 dimensions as the base image. Handle disposal method that is
6738 "undefined" by the gif spec (Bug#9335).
6740 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6742 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6743 (Fcondition_case): Document `debug' symbol in error handler.
6745 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6747 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6748 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6749 from an Org mode buffer to a Speedbar frame.
6751 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6752 a composition, take its buffer position from IT->cmp_it.charpos.
6753 Fixes cursor positioning at the beginning of a line that begins
6754 with a composed character.
6756 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6758 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6759 character bidirectional type, use STRONG_L instead. Fixes crashes
6760 in a buffer produced by `describe-categories'.
6762 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6763 members before the level stack, so they would be saved and
6764 restored when copying iterator state. Fixes incorrect reordering
6765 around TABs covered by display properties.
6767 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6769 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6771 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6773 * eval.c (internal_condition_case, internal_condition_case_1)
6774 (internal_condition_case_2, internal_condition_case_n):
6775 Remove unnecessary aborts (Bug#9081).
6777 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6779 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6780 has no `load' handler, try opening the file locally. (Bug#9311)
6782 2011-08-16 Ken Brown <kbrown@cornell.edu>
6784 * gmalloc.c: Expand comment.
6786 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6788 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6789 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6791 2011-08-16 Ken Brown <kbrown@cornell.edu>
6793 Fix memory allocation problems in Cygwin build (Bug#9273).
6795 * unexcw.c ( __malloc_initialized): Declare external variable.
6796 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6798 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6800 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6802 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6804 [CYGWIN] (special_realloc): New function.
6805 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6806 requests to realloc storage in the static heap.
6808 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6810 * bidi.c (bidi_initialize): Remove unused local.
6812 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6815 * biditype.h: Remove file.
6816 * makefile.w32-in ($(BLD)/bidi.$(O)):
6817 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6819 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6821 * chartab.c: Improve commentary for the uniprop_table API.
6823 * bidi.c (bidi_paragraph_init): Support zero value of
6824 bidi_ignore_explicit_marks_for_paragraph_level.
6825 (bidi_initialize): Use uniprop_table instead of including
6826 biditype.h and bidimirror.h.
6828 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6829 coordinates of the iterator when restoring from ppos_it.
6832 2011-08-14 Kenichi Handa <handa@m17n.org>
6834 * process.c (create_process): Call setup_process_coding_systems
6835 after the pid of the process is set to -1 (Bug#8162).
6837 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6839 * xdisp.c (move_it_in_display_line_to): Don't invoke
6840 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6841 ppos_it. Fixes vertical cursor motion when line beginning is
6842 covered by an image. (Bug#9296)
6844 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6846 * nsterm.h (ns_run_ascript): Declare.
6847 (NSAPP_DATA2_RUNASSCRIPT): Define.
6849 * nsfns.m (as_script, as_result, as_status): New static variables.
6850 (ns_run_ascript): New function.
6851 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6852 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6853 the event loop. Get status from as_status (Bug#7276).
6855 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6856 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6857 the event loop (Bug#7276).
6859 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6861 * gnutls.c (QCgnutls_bootprop_priority)
6862 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6863 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6864 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6865 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6866 (QCgnutls_bootprop_verify_hostname_error)
6867 (QCgnutls_bootprop_callbacks_verify): Rename from
6868 Qgnutls_bootprop_..., all uses changed.
6870 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6873 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6875 * xfaces.c (Qframe_set_background_mode): Now static.
6876 * dispextern.h (Qframe_set_background_mode): Remove decl.
6878 * process.c (Fnetwork_interface_info): Declare local only if needed.
6880 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6882 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6883 (Fnetwork_interface_list): Allocate in increments of bytes instead
6884 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6885 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6887 (struct ifflag_def): notrailers is smart on OSX.
6888 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6889 Get hardware address with getifaddrs if available.
6891 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6893 * xdisp.c (iterate_out_of_display_property): xassert that
6894 IT->position is set to within IT->object's boundaries. Break from
6895 the loop as soon as EOB is reached; avoids infloops in redisplay
6896 when IT->position is set up wrongly due to some bug.
6897 Set IT->current to match the bidi iterator unconditionally.
6898 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6899 entry. Force push_it to save on the stack the current
6900 buffer/string position, to be restored by pop_it. Fix flags in
6901 the iterator structure wrt the object coming from a display
6902 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6903 properties. (Bug#9284)
6905 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6907 * fontset.c (fontset_get_font_group): Add proper type checks.
6910 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6912 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6913 and LC_VERSION_MIN_MACOSX.
6914 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6915 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6917 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6919 * xdisp.c (forward_to_next_line_start): Allow to use the
6920 no-display-properties-and-no-overlays under bidi display.
6921 Set disp_pos in the bidi iterator to avoid searches for display
6922 properties and overlays.
6924 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6926 * editfns.c (Fset_time_zone_rule): Document relationship with the
6929 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6930 the font entity extracted from the cache (Bug#8109).
6932 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6934 * composite.c (autocmp_chars): Don't reset point. That is done by
6935 restore_point_unwind (Bug#5984).
6937 2011-08-07 Juri Linkov <juri@jurta.org>
6939 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6940 to show the arg `TIME' instead of `TIMEVAL'.
6942 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6944 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6945 display property strides EOL and includes a newline, as in
6946 longlines-mode. (Bug#9254)
6947 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6948 word-wrap under bidirectional display. (Bug#9224)
6950 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6951 is non-zero, even if the data buffer is NULL. Fixes a crash in
6952 vertical-motion with longlines-mode. (Bug#9254)
6954 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6956 * bidi.c <bidi_cache_total_alloc>: Now static.
6957 (bidi_initialize): Initialize bidi_cache_total_alloc.
6959 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6962 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6963 amount allocated this far in `bidi_cache_total_alloc'.
6964 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6965 non-zero, only free the data buffer without restoring the cache
6966 contents. All callers changed.
6968 * dispextern.h (bidi_unshelve_cache): Update prototype.
6970 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6971 (move_it_in_display_line, move_it_to)
6972 (move_it_vertically_backward, move_it_by_lines): Replace the call
6973 to xfree to an equivalent call to bidi_unshelve_cache.
6974 (move_it_in_display_line_to): Fix logic of returning
6975 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6977 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6979 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6980 came from a string character with a `cursor' property. (Bug#9229)
6982 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6984 * Makefile.in (LIB_PTHREAD): New variable.
6985 (LIBES): Add LIB_PTHREAD (Bug#9216).
6987 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6988 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6990 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6992 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6994 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6996 * xterm.c (x_find_topmost_parent): New function.
6997 (x_set_frame_alpha): Find topmost parent window with
6998 x_find_topmost_parent and set the property there also (bug#9181).
6999 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7001 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7003 * callproc.c (Fcall_process): Avoid vfork clobbering
7004 the local vars buffer, coding_systems, current_dir.
7006 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7008 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7010 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7012 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7013 so that it is not optimized away.
7015 * xdisp.c (compute_display_string_pos): Remove unused local.
7017 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7019 Fix slow cursor motion and scrolling in large buffers with
7020 selective display, like Org Mode buffers. (Bug#9218)
7022 * dispextern.h (struct bidi_it): New member disp_prop_p.
7024 * xdisp.c: Remove one-slot cache of display string positions.
7025 (compute_display_string_pos): Accept an additional argument
7026 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7027 for a display string or property. If found, set DISP_PROP_P
7030 * bidi.c (bidi_fetch_char): Accept an additional argument
7031 DISP_PROP_P, and pass it to compute_display_string_pos.
7032 Only handle text covered by a display string if DISP_PROP_P is returned
7033 non-zero. All callers of bidi_fetch_char changed.
7035 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7037 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7039 2010-12-03 Don March <don@ohspite.net>
7041 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7042 last character M-[char] is translated to ESC [char] (bug#7541).
7044 2011-08-02 Kenichi Handa <handa@m17n.org>
7046 * lisp.h (uniprop_table): Extern it.
7048 * chartab.c (uniprop_table): Make it non-static.
7050 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7052 * xdisp.c (forward_to_next_line_start): Accept additional argument
7053 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7055 (reseat_at_next_visible_line_start): Use the bidi iterator state
7056 returned by forward_to_next_line_start to restore the state of
7057 it->bidi_it after backing up to previous newline. (Bug#9212)
7059 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7061 * regex.c (re_comp): Protoize.
7062 (re_exec): Fix return type.
7063 (regexec): Fix type of `ret'. (Bug#9203)
7065 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7067 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7068 This is needed if max-image-size is a floating-point number.
7070 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7072 * print.c (print_object): Print empty symbol as ##.
7074 * lread.c (read1): Read ## as empty symbol.
7076 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7078 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7079 setting frame foreground color (Bug#9175).
7080 (x_set_background_color): Likewise.
7082 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7083 contents (Bug#9176).
7084 (EmacsTooltip -init): Remove bezels and add shadows to
7087 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7088 or scroll bar (Bug#8470).
7090 * nsfont.m (nsfont_open): Remove assignment to voffset and
7091 unnecessary vars hshink, expand, hd, full_height, min_height.
7092 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7094 * nsterm.h (nsfont_info): Remove voffset field.
7096 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7098 Implement strike-through and overline on NextStep (Bug#8863).
7100 * nsfont.m (nsfont_open): Use underline position provided by font,
7101 instead of hard-coded value of 2.
7102 (nsfont_draw): Call ns_draw_text_decoration instead.
7104 * nsterm.h: Add declaration for ns_draw_text_decoration.
7106 * nsterm.m (ns_draw_text_decoration): New function for drawing
7107 underline, overline, and strike-through.
7108 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7109 ns_draw_text_decoration. Change treatment of cursor drawing to
7110 accommodate underlining, etc.
7112 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7114 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7117 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7119 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7120 Without this fix, if a signal arrives just after memory fills up,
7121 'malloc' might be invoked reentrantly.
7123 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7124 In other words, assume that every image size is allowed, on non-X
7125 hosts. This assumption is probably wrong, but it lets Emacs compile.
7127 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7129 * regex.c (re_iswctype): Convert return values to boolean.
7131 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7133 * xdisp.c (compute_display_string_pos): Don't use cached display
7134 string position if the buffer had its restriction changed.
7137 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7139 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7141 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7143 Integer signedness and overflow and related fixes. (Bug#9079)
7145 * bidi.c: Integer size and overflow fixes.
7146 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7147 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7148 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7149 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7150 (bidi_find_other_level_edge):
7151 Use ptrdiff_t instead of EMACS_INT where either will do.
7152 This works better on 32-bit hosts configured --with-wide-int.
7153 (bidi_cache_ensure_space): Check for size-calculation overflow.
7154 Use % rather than repeated addition, for better worst-case speed.
7155 Don't set bidi_cache_size until after xrealloc returns, because it
7157 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7158 (bidi_cache_ensure_space): Also check that the bidi cache size
7159 does not exceed that of the largest Lisp string or buffer. See Eli
7160 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7162 * alloc.c (__malloc_size_t): Remove.
7163 All uses replaced by size_t. See Andreas Schwab's note
7164 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7166 * image.c: Improve checking for integer overflow.
7167 (check_image_size): Assume that f is nonnull, since
7168 it is always nonnull in practice. This is one less thing to
7169 worry about when checking for integer overflow later.
7170 (x_check_image_size): New function, which checks for integer
7171 overflow issues inside X.
7172 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7173 This removes the need for a memory_full check.
7174 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7175 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7176 (xbm_read_bitmap_data): Change locals back to 'int', since
7177 their values must fit in 'int'.
7178 (xpm_load_image, png_load, tiff_load):
7179 Invoke x_create_x_image_and_pixmap earlier,
7180 to avoid much needless work if the image is too large.
7181 (tiff_load): Treat overly large images as if
7182 x_create_x_image_and_pixmap failed, not as malloc failures.
7183 (gs_load): Use x_check_image_size.
7185 * gtkutil.c: Omit integer casts.
7186 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7187 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7189 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7191 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7192 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7193 would wrongly return t on a 64-bit host.
7195 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7196 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7197 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7198 and therefore cause GCC to emit a bogus diagnostic in some cases.
7200 * image.c: Integer signedness and overflow and related fixes.
7201 This is not an exhaustive set of fixes, but it's time to
7202 record what I've got.
7203 (lookup_pixel_color, check_image_size): Remove redundant decls.
7204 (check_image_size): Don't assume that arbitrary EMACS_INT values
7205 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7206 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7207 (tiff_load, imagemagick_load_image):
7208 Check for overflow in size calculations.
7209 (x_create_x_image_and_pixmap): Remove unnecessary test for
7210 xmalloc returning NULL; that can't happen.
7211 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7212 (xpm_color_bucket): Use better integer hashing function.
7213 (xpm_cache_color): Don't possibly over-allocate memory.
7214 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7215 (gif_memory_source):
7216 Use ptrdiff_t, not int or size_t, to record sizes.
7217 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7218 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7219 either works, as we prefer signed integers.
7220 (tiff_read_from_memory, tiff_write_from_memory):
7221 Return tsize_t, not size_t, since that's what the TIFF API wants.
7222 (tiff_read_from_memory): Don't fail simply because the read would
7223 go past EOF; instead, return a short read.
7224 (tiff_load): Omit no-longer-needed casts.
7225 (Fimagemagick_types): Don't assume size fits into 'int'.
7227 Improve hashing quality when configured --with-wide-int.
7228 * fns.c (hash_string): New function, taken from sxhash_string.
7229 Do not discard information about ASCII character case; this
7230 discarding is no longer needed.
7231 (sxhash-string): Use it. Change sig to match it. Caller changed.
7232 * lisp.h: Declare it.
7233 * lread.c (hash_string): Remove, since we now use fns.c's version.
7234 The fns.c version returns a wider integer if --with-wide-int is
7235 specified, so this should help the quality of the hashing a bit.
7237 * emacs.c: Integer overflow minor fix.
7238 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7239 Define only if GNU_LINUX.
7240 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7242 * dispnew.c: Integer signedness and overflow fixes.
7243 Remove unnecessary forward decls, that were a maintenance hassle.
7244 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7246 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7247 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7248 (prepare_desired_row, line_draw_cost):
7249 Use int, not unsigned, where either works.
7250 (save_current_matrix, restore_current_matrix):
7251 Use ptrdiff_t, not size_t, where either works.
7252 (init_display): Check for overflow more accurately, and without
7253 relying on undefined behavior.
7255 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7256 Remove, replacing with the new symbols in lisp.h. All uses changed.
7257 * fileio.c (make_temp_name):
7258 * filelock.c (lock_file_1, lock_file):
7259 * xdisp.c (message_dolog):
7260 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7261 Use pMd etc. instead.
7262 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7263 replacing the pWIDE etc. symbols removed from editfns.c.
7265 * keyboard.h (num_input_events): Now uintmax_t.
7266 This is (very slightly) less likely to mess up due to wraparound.
7269 * buffer.c: Integer signedness fixes.
7270 (alloc_buffer_text, enlarge_buffer_text):
7271 Use ptrdiff_t rather than size_t when either will do, as we prefer
7274 * alloc.c: Integer signedness and overflow fixes.
7275 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7276 (__malloc_size_t): Default to size_t, not to int.
7277 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7278 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7279 Prefer ptrdiff_t to size_t when either would do, as we prefer
7281 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7282 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7283 Now const. Initialize with values that are in range even if char
7285 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7286 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7287 These functions do the right thing with sizes > 2**32.
7288 (check_depth): Now ptrdiff_t, not int.
7289 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7290 Adjust to new way of storing sizes. Check for size overflow bugs
7292 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7293 slightly wrong anyway, as it missed one instance of
7294 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7295 (refill_memory_reserve): Omit needless cast to size_t.
7296 (mark_object_loop_halt): Mark as externally visible.
7298 * xselect.c: Integer signedness and overflow fixes.
7299 (Fx_register_dnd_atom, x_handle_dnd_message):
7300 Use ptrdiff_t, not size_t, since we prefer signed.
7301 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7302 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7303 x_dnd_atoms_size and x_dnd_atoms_length.
7305 * doprnt.c: Prefer signed to unsigned when either works.
7307 * doprnt.c (doprnt):
7309 * xdisp.c (vmessage):
7310 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7311 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7312 prefer signed arithmetic to avoid comparison confusion.
7313 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7314 but is a bit tricky.
7316 Assume freestanding C89 headers, string.h, stdlib.h.
7317 * data.c, doprnt.c, floatfns.c, print.c:
7318 Include float.h unconditionally.
7319 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7320 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7321 * regex.c: Likewise for stddef.h, string.h.
7322 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7323 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7324 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7325 (STDC_HEADERS): Remove obsolete defines.
7326 * sysdep.c: Include limits.h unconditionally.
7328 Assume support for memcmp, memcpy, memmove, memset.
7329 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7330 * regex.c (memcmp, memcpy):
7331 Remove; we assume C89 now.
7333 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7334 (__malloc_safe_bcopy): Remove; no longer needed.
7336 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7337 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7338 well either way, and we prefer signed to unsigned.
7340 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7342 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7343 closes the connection while we're reading (bug#9182).
7345 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7347 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7348 are specified (Bug#9168).
7350 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7352 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7353 Found by GCC static checking and --with-wide-int on a 32-bit host.
7355 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7357 * xdisp.c (compute_display_string_pos): Fix logic of caching
7358 previous display string position. Initialize cached_prev_pos to
7359 -1. Fixes slow-down at the beginning of a buffer.
7361 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7363 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7364 for attrs[LFACE_FONTSET_INDEX].
7366 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7368 * xml.c (parse_region): Remove unused local
7369 that was recently introduced.
7371 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7373 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7374 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7376 * xdisp.c (move_it_in_display_line_to): Record the best matching
7377 position for TO_CHARPOS while scanning the line, and restore it on
7378 exit if none of the characters scanned was an exact match.
7379 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7380 when exact match is impossible due to invisible text, and the
7381 lines are truncated.
7383 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7385 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7388 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7390 Fix a significant slow-down of cursor motion with C-n, C-p,
7391 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7392 auto-repeat under bidi redisplay in fontified buffers.
7393 * xdisp.c (compute_stop_pos_backwards): New function.
7394 (next_element_from_buffer): Call compute_stop_pos_backwards to
7395 find a suitable prev_stop when we find ourselves before
7397 (reseat): Don't look for prev_stop, as that could mean a very long
7399 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7400 <cached_disp_overlay_modiff>: Cache for last found display string
7402 (compute_display_string_pos): Return the cached position if asked
7403 about the same buffer in the same area of character positions, and
7404 the buffer wasn't changed since the time the display string
7405 position was cached.
7407 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7409 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7410 is an integer, which is important for empty lines. (Bug#9149)
7412 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7414 * frame.c (Fmodify_frame_parameters): In tty case, update the
7415 default face if necessary (Bug#4238).
7417 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7419 * editfns.c (Fstring_to_char): No need to explain what a character
7420 is in the docstring (Bug#6576).
7422 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7424 * xml.c (parse_region): Make sure we always return a tree.
7426 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7428 * xml.c (parse_region): If a document contains only comments,
7431 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7433 * xml.c (make_dom): Return comments, too.
7435 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7438 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7439 and the surrounding thread.
7440 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7441 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7442 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7444 * s/openbsd.h (BROKEN_SIGIO): Define.
7445 * unexelf.c (unexec) [__OpenBSD__]:
7446 Don't update the .mdebug section of the Alpha COFF symbol table.
7448 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7450 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7453 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7455 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7456 This fixes some race conditions on the permissions of any newly
7459 * alloc.c (valid_pointer_p): Use pipe, not open.
7460 This fixes some permissions issues when debugging.
7462 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7463 If fchown fails to set both uid and gid, try to set just gid,
7464 as that is sometimes allowed. Adjust the file's mode to eliminate
7465 setuid or setgid bits that are inappropriate if fchown fails.
7467 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7469 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7470 to compare Lisp_Objects.
7471 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7472 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7473 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7475 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7477 * lread.c (read_integer): Unread even EOF character.
7478 (read1): Likewise. Properly record start position of symbol.
7480 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7481 symbol character follows.
7483 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7485 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7486 This works around a problem with the previous change to Fcopy_file.
7487 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7488 and without this change, GCC might complain about discarding
7489 fchown's return value.
7491 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7493 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7495 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7497 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7499 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7501 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7502 it's used from the C level.
7504 * process.c: Use the same condition for POLL_FOR_INPUT in both
7505 keyboard.c and process.c (bug#1858).
7507 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7509 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7510 (Fgnutls_boot): Use it.
7512 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7514 * doc.c (Fsubstitute_command_keys): Revert last change.
7516 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7518 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7519 quotes the next character, and doesn't affect other longer
7520 sequences (bug#8935).
7522 * lread.c (syms_of_lread): Clarify that is isn't only
7523 `eval-buffer' and `eval-defun' that's affected by
7524 `lexical-binding' (bug#8460).
7526 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7528 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7529 bidi redisplay when a line includes both an image and is truncated.
7531 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7533 Fix minor problems found by static checking.
7534 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7535 (elsz): Now a signed constant, not a size_t var. We prefer signed
7536 types to unsigned, to avoid integer comparison confusion. Without
7537 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7538 "cannot optimize loop, the loop counter may overflow", a symptom
7540 * indent.c (Fvertical_motion): Mark locals as initialized.
7541 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7543 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7545 * search.c (Fre_search_backward): Mention `case-fold-search' in
7546 all the re_search_* functions (bug#8138).
7548 * keyboard.c (Fopen_dribble_file): Document when the file is
7551 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7553 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7556 Support bidi reordering of display and overlay strings.
7557 * xdisp.c (compute_display_string_pos)
7558 (compute_display_string_end): Accept additional argument STRING.
7559 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7560 (reseat_to_string): Initialize bidi_it->string.s and
7561 bidi_it->string.schars.
7562 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7563 NULL (avoids a crash in bidi_paragraph_init).
7564 Initialize itb.string.lstring.
7565 (init_iterator): Call bidi_init_it only of a valid
7566 buffer position was specified. Initialize paragraph_embedding to
7568 (reseat_to_string): Initialize the bidi iterator.
7569 (display_string): If we need to ignore text properties of
7570 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7571 original value of -1 will not work with bidi.)
7572 (compute_display_string_pos): First arg is now struct
7573 `text_pos *'; all callers changed. Support display properties on
7575 (compute_display_string_end): Support display properties on Lisp
7577 (init_iterator, reseat_1, reseat_to_string): Initialize the
7578 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7579 when iterating on a string not from display properties).
7580 (compute_display_string_pos, compute_display_string_end):
7581 Fix calculation of the object to scan. Fixes an error when using
7583 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7584 base_level_stop; instead, set base_level_stop to BEGV.
7585 Fixes crashes in vertical-motion.
7586 (next_element_from_buffer): Improve commentary for when
7587 the iterator is before prev_stop.
7588 (init_iterator): Initialize bidi_p from the default value of
7589 bidi-display-reordering, not from buffer-local value. Use the
7590 buffer-local value only if initializing for buffer iteration.
7591 (handle_invisible_prop): Support invisible properties on strings
7592 that are being bidi-reordered.
7593 (set_iterator_to_next): Support bidi reordering of C strings and
7595 (next_element_from_string): Support bidi reordering of Lisp
7597 (handle_stop_backwards): Support Lisp strings as well.
7598 (display_string): Support display of R2L glyph rows.
7599 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7600 (init_iterator): Don't initialize it->bidi_p for strings
7602 (reseat_to_string): Initialize it->bidi_p for strings here.
7603 (next_element_from_string, next_element_from_c_string)
7604 (next_element_from_buffer): Add xassert's for correspondence
7605 between IT's object being iterated and it->bidi_it.string
7607 (face_before_or_after_it_pos): Support bidi iteration.
7608 (next_element_from_c_string): Handle the case of the first string
7609 character that is not the first one in the visual order.
7610 (get_visually_first_element): New function, refactored from common
7611 parts of next_element_from_buffer, next_element_from_string, and
7612 next_element_from_c_string.
7613 (tool_bar_lines_needed, redisplay_tool_bar)
7614 (display_menu_bar): Force left-to-right direction. Add a FIXME
7615 comment for making that be controlled by a user option.
7616 (push_it, pop_it): Save and restore the state of the
7617 bidi iterator. Save and restore the bidi_p flag.
7618 (pop_it): Iterate out of display property for string iteration as
7620 (iterate_out_of_display_property): Support iteration over strings.
7621 (handle_single_display_spec): Set up it->bidi_it for iteration
7622 over a display string, and call bidi_init_it.
7623 (handle_single_display_spec, next_overlay_string)
7624 (get_overlay_strings_1, push_display_prop): Set up the bidi
7625 iterator for displaying display or overlay strings.
7626 (forward_to_next_line_start): Don't use the shortcut if
7628 (back_to_previous_visible_line_start): If handle_display_prop
7629 pushed the iterator stack, restore the internal state of the bidi
7630 iterator by calling bidi_pop_it same number of times.
7631 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7632 and we are bidi-iterating, don't decrement the iterator position;
7633 instead, set the first_elt flag in the bidi iterator, to produce
7635 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7636 (push_display_prop): xassert that we are iterating a buffer.
7637 (push_it, pop_it): Save and restore paragraph_embedding member.
7638 (handle_single_display_spec, next_overlay_string)
7639 (get_overlay_strings_1, reseat_1, reseat_to_string)
7640 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7641 correctly. Don't assume unibyte strings are not bidi-reordered.
7642 (compute_display_string_pos)
7643 (compute_display_string_end): Fix handling the case of C string.
7644 (push_it, pop_it): Save and restore from_disp_prop_p.
7645 (handle_single_display_spec, push_display_prop): Set the
7646 from_disp_prop_p flag.
7647 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7648 (pop_it): Call iterate_out_of_display_property only if we are
7649 popping after iteration over a string that came from a display
7650 property. Fix a typo in popping stretch info. Add an assertion
7651 for verifying that the iterator position is in sync with the bidi
7653 (handle_single_display_spec, get_overlay_strings_1)
7654 (push_display_prop): Fix initialization of paragraph direction for
7655 string when that of the parent object is not yet determined.
7656 (reseat_1): Call bidi_init_it to resync the bidi
7657 iterator with IT's position. (Bug#7616)
7658 (find_row_edges): If ROW->start.pos gives position
7659 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7660 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7661 Reset the from_disp_prop_p flag.
7662 (SAVE_IT, RESTORE_IT): New macros.
7663 (pos_visible_p, face_before_or_after_it_pos)
7664 (back_to_previous_visible_line_start)
7665 (move_it_in_display_line_to, move_it_in_display_line)
7666 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7667 (try_scrolling, redisplay_window, display_line): Use them when
7668 saving a temporary copy of the iterator and restoring it back.
7669 (back_to_previous_visible_line_start, reseat_1)
7670 (init_iterator): Empty the bidi cache "stack".
7671 (move_it_in_display_line_to): If iterator ended up at
7672 EOL, but we never saw any buffer positions smaller than
7673 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7674 motion in bidi-reordered lines.
7675 (move_it_in_display_line_to): Record prev_method and prev_pos
7676 immediately before the call to set_iterator_to_next. Fixes cursor
7677 motion in bidi-reordered lines with stretch glyphs and strings
7678 displayed in margins. (Bug#8133) (Bug#8867)
7679 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7681 (pos_visible_p): Support positions in bidi-reordered lines.
7682 Save and restore bidi cache.
7684 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7685 (bidi_paragraph_info): Delete unused struct.
7686 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7687 (bidi_cache_start): New variable.
7688 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7690 (bidi_cache_fetch_state, bidi_cache_search)
7691 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7692 (bidi_cache_find, bidi_peek_at_next_level)
7693 (bidi_level_of_next_char, bidi_find_other_level_edge)
7694 (bidi_move_to_visually_next): Compare cache index with
7695 bidi_cache_start rather than with zero.
7696 (bidi_fetch_char): Accept new argument STRING; all callers
7697 changed. Support iteration over a string. Support strings with
7698 display properties. Support unibyte strings. Fix the type of
7699 `len' according to what STRING_CHAR_AND_LENGTH expects.
7700 (bidi_paragraph_init, bidi_resolve_explicit_1)
7701 (bidi_resolve_explicit, bidi_resolve_weak)
7702 (bidi_level_of_next_char, bidi_move_to_visually_next):
7703 Support iteration over a string.
7704 (bidi_set_sor_type, bidi_resolve_explicit_1)
7705 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7706 can now be zero (for strings); special values 0 and -1 were
7707 changed to -1 and -2, respectively.
7708 (bidi_char_at_pos): New function.
7709 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7710 Call it instead of FETCH_MULTIBYTE_CHAR.
7711 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7712 initialized to valid values.
7713 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7715 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7716 the test for valid cached positions. Fix the logic for looking up
7717 the sentinel state in the cache. GCPRO the Lisp string we are
7719 (bidi_push_it, bidi_pop_it): New functions.
7720 (bidi_initialize): Initialize the bidi cache start stack pointer.
7721 (bidi_cache_ensure_space): New function, refactored from part of
7722 bidi_cache_iterator_state. Don't assume the required size is just
7723 one BIDI_CACHE_CHUNK away.
7724 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7725 (bidi_count_bytes, bidi_char_at_pos): New functions.
7726 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7727 always valid if bidi_cache_idx is valid.
7728 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7729 is valid if it's going to be used.
7730 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7731 (bidi_cache_fetch_state, bidi_cache_search)
7732 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7733 (bidi_cache_iterator_state, bidi_cache_find)
7734 (bidi_find_other_level_edge, bidi_cache_start_stack):
7735 All variables related to cache indices are now EMACS_INT.
7737 * dispextern.h (struct bidi_string_data): New structure.
7738 (struct bidi_it): New member `string'. Make flag members be 1-bit
7739 fields, and put them last in the struct.
7740 (compute_display_string_pos, compute_display_string_end):
7742 (bidi_push_it, bidi_pop_it): Add prototypes.
7743 (struct iterator_stack_entry): New members bidi_p,
7744 paragraph_embedding, and from_disp_prop_p.
7745 (struct it): Member bidi_p is now a bit field 1 bit wide.
7746 (bidi_shelve_cache, bidi_unshelve_cache):
7749 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7750 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7751 and vector-like objects.
7753 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7754 cache around display iteration.
7756 * window.c (Fwindow_end, window_scroll_pixel_based)
7757 (displayed_window_lines, Frecenter): Save and restore the bidi
7758 cache around display iteration.
7760 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7762 * editfns.c (Fdelete_region): Clarify the use of the named
7763 parameters (bug#6788).
7765 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7767 * indent.c (Fvertical_motion): Set and restore w->pointm when
7768 saving and restoring the window's buffer (Bug#9006).
7770 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7772 * editfns.c (Fstring_to_char): Clarify just what is returned
7773 (bug#6576). Text by Eli Zaretskii.
7775 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7777 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7779 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7781 * buffer.c (mmap_find): Fix a typo.
7783 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7785 Fix execution of x selection hooks.
7786 * xselect.c (Qx_lost_selection_functions)
7787 (Qx_sent_selection_functions): New vars.
7788 (syms_of_xselect): DEFSYM them.
7789 (x_handle_selection_request): Pass Qx_sent_selection_functions
7790 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7791 (x_handle_selection_clear,x_clear_frame_selections):
7792 Pass Qx_lost_selection_functions rather than
7793 Vx_lost_selection_functions to Frun_hook_with_args.
7795 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7797 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7798 The old code sometimes used this field without initializing it.
7800 * alloc.c (gc_sweep): Don't read past end of array.
7801 In theory, the old code could also have corrupted Emacs internals,
7802 though it'd be very unlikely.
7804 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7806 * character.c (Fcharacterp): Don't advertise optional ignored
7807 argument. (Bug#4026)
7809 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7811 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7814 * window.c (Fset_window_start): Doc fix (bug#4199).
7815 (Fset_window_hscroll): Ditto.
7817 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7819 Fix minor new problems caught by GCC 4.6.1.
7820 * term.c (init_tty): Remove unused local.
7821 * xsettings.c (store_monospaced_changed): Define this function only
7822 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7825 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7827 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7829 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7831 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7832 are the mini-buffer and the echo area (bug#3320).
7834 * term.c (init_tty): Remove support for supdup, c10 and perq
7835 terminals, which are no longer supported (bug#1482).
7837 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7839 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7841 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7843 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7844 for non-popups (Bug#3642).
7846 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7848 * alloc.c (reset_malloc_hooks): Protoize.
7849 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7850 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7851 * cm.c (losecursor): Likewise.
7852 * data.c (fmod): Likewise.
7853 * dispnew.c (swap_glyphs_in_rows): Likewise.
7854 * emacs.c (memory_warning_signal): Likewise.
7855 * floatfns.c (float_error): Likewise.
7856 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7857 (otf_open, font_otf_capability, generate_otf_features)
7858 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7860 * image.c (pbm_read_file): Likewise.
7861 * indent.c (string_display_width): Likewise.
7862 * intervals.c (check_for_interval, search_for_interval)
7863 (inc_interval_count, count_intervals, root_interval)
7864 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7865 * lread.c (defalias): Likewise.
7866 * ralloc.c (r_alloc_check): Likewise.
7867 * regex.c (set_image_of_range_1, set_image_of_range)
7868 (regex_grow_registers): Likewise.
7869 * sysdep.c (strerror): Likewise.
7870 * termcap.c (valid_filename_p, tprint, main): Likewise.
7871 * tparam.c (main): Likewise.
7872 * unexhp9k800.c (run_time_remap, save_data_space)
7873 (update_file_ptrs, read_header, write_header, calculate_checksum)
7874 (copy_file, copy_rest, display_header): Likewise.
7875 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7877 * xdisp.c (check_it): Likewise.
7878 * xfaces.c (register_color, unregister_color, unregister_colors):
7880 * xfns.c (print_fontset_result): Likewise.
7881 * xrdb.c (member, fatal, main): Likewise.
7883 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7885 Fix minor problems found by static checking (Bug#9031).
7886 * chartab.c (char_table_set_range, map_sub_char_table):
7887 Remove unused locals.
7888 (uniprop_table): Now static.
7889 * composite.c (_work_char): Remove unused static var.
7891 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7893 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7895 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7897 * gtkutil.c (qttip_cb): Remove code without function.
7899 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7901 * w32.c (pthread_sigmask): New stub.
7903 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7905 Use pthread_sigmask, not sigprocmask (Bug#9010).
7906 sigprocmask is portable only for single-threaded applications, and
7907 Emacs can be multi-threaded when it uses GTK.
7908 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7910 * callproc.c (Fcall_process):
7911 * process.c (create_process):
7912 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7913 Use pthread_sigmask, not sigprocmask.
7915 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7917 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7918 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7921 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7923 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7924 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7925 (xg_hide_tooltip): Fix comment.
7927 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7928 in registerServicesMenuSendTypes.
7929 (validRequestorForSendType): Don't check ns_return_types.
7931 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7934 2011-07-08 Jason Rumney <jasonr@gnu.org>
7936 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7937 SH_SHOW for hidden windows (Bug#5482).
7939 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7940 frame struct members of non-existent frames (Bug#6284).
7942 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7944 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7945 variable firstTime not needed on OSX >= 10.6.
7946 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7947 >= 10.5. Use setKnobProportion, setDoubleValue.
7949 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7950 (MAC_OS_X_VERSION_10_5): Define if not defined.
7951 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7952 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7953 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7955 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7956 cString and lossyCString on OSX >= 10.4.
7958 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7959 sizeToFit on OSX >= 10.2.
7961 * nsimage.m (allocInitFromFile): Don't use deprecated method
7962 bestRepresentationForDevice on OSX >= 10.6.
7964 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7967 * emacs.c: Declare unexec_init_emacs_zone.
7969 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7971 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7973 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7974 on svcsMenu (Bug#8842).
7976 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7978 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7980 * nsterm.m (QUTF8_STRING): Declare.
7981 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7982 (validRequestorForSendType): Return type is (id).
7983 Change indexOfObjectIdenticalTo to indexOfObject.
7984 Check if we have local selection before returning self (Bug#8842).
7985 (writeSelectionToPasteboard): Put local selection into paste board
7986 if we have a local selection (Bug#8842).
7987 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7989 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7990 (ns_get_local_selection): Declare.
7992 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7994 * keymap.c (describe_map_tree): Don't insert a double newline at
7995 the end of the buffer (bug#1169) and return whether we inserted
7998 * callint.c (Fcall_interactively): Change "reading args" to
7999 "providing args" to try to clarify what it does (bug#1010).
8001 2011-07-07 Kenichi Handa <handa@m17n.org>
8003 * composite.c (composition_compute_stop_pos): Ignore a static
8004 composition starting before CHARPOS (Bug#8915).
8006 * xdisp.c (handle_composition_prop): Likewise.
8008 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8010 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8013 2011-07-07 Kenichi Handa <handa@m17n.org>
8015 * character.h (unicode_category_t): New enum type.
8017 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8018 (Qchar_code_property_table): New variable.
8019 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8020 (UNIPROP_COMPRESSED_FORM_P): New macros.
8021 (char_table_ascii): Uncompress the compressed values.
8022 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8023 Uncompress the compressed values.
8024 (sub_char_table_ref_and_range): Likewise.
8025 (char_table_ref_and_range): Uncompress the compressed values.
8026 (sub_char_table_set): New arg is_uniprop. Callers changed.
8027 Uncompress the compressed values.
8028 (sub_char_table_set_range): Args changed. Callers changed.
8029 (char_table_set_range): Adjuted for the above change.
8030 (map_sub_char_table): Delete args default_val and parent. Add arg
8031 top. Give decoded values to a Lisp function.
8032 (map_char_table): Adjust for the above change. Give decoded
8033 values to a Lisp function. Gcpro more variables.
8034 (uniprop_table_uncompress)
8035 (uniprop_decode_value_run_length): New functions.
8036 (uniprop_decoder, uniprop_decoder_count): New variables.
8037 (uniprop_get_decoder, uniprop_encode_value_character)
8038 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8040 (uniprop_encoder, uniprop_encoder_count): New variables.
8041 (uniprop_get_encoder, uniprop_table)
8042 (Funicode_property_table_internal, Fget_unicode_property_internal)
8043 (Fput_unicode_property_internal): New functions.
8044 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8045 Sunicode_property_table_internal, Sget_unicode_property_internal,
8046 and Sput_unicode_property_internal. Defvar_lisp
8047 char-code-property-alist.
8049 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8050 Vunicode_category_table.
8052 * font.c (font_range): Adjust for the change of
8053 Vunicode_category_table.
8055 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8057 * m/iris4d.h: Remove file, move contents ...
8058 * s/irix6-5.h: ... here.
8060 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8062 Remove unportable assumption about struct layout (Bug#8884).
8063 * alloc.c (mark_buffer):
8064 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8065 (clone_per_buffer_values): Don't assume that
8066 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8067 This isn't true in general, and it's particularly not true
8068 if Emacs is configured with --with-wide-int.
8069 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8070 New macros, used in the buffer.c change.
8072 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8074 * xsettings.c: Use both GConf and GSettings if both are available.
8075 (store_config_changed_event): Add comment.
8076 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8077 (store_tool_bar_style_changed): New functions.
8078 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8079 (struct xsettings): Move font inside HAVE_XFT.
8080 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8081 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8082 Move inside HAVE_XFT.
8083 (something_changed_gsettingsCB): Rename from something_changedCB.
8084 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8086 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8087 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8088 (something_changed_gconfCB): Rename from something_changedCB.
8089 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8090 (parse_settings): Move check for font inside HAVE_XFT.
8091 (read_settings, apply_xft_settings): Add comment.
8092 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8093 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8094 call store_font_name_changed.
8095 (xft_settings_event): Add comment.
8096 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8097 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8098 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8099 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8100 (xsettings_initialize): Call init_gsettings last.
8101 (xsettings_get_system_font, xsettings_get_system_normal_font):
8104 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8106 Random fixes. E.g., (random) never returned negative values.
8107 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8108 subseconds part to the entropy, as that's a bit more random.
8109 Prefer signed to unsigned, since the signedness doesn't matter and
8110 in general we prefer signed. When given a limit, use a
8111 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8112 latter isn't right if USE_2_TAGS_FOR_INTS.
8113 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8114 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8116 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8118 * textprop.c (text_property_stickiness):
8119 Obey Vtext_property_default_nonsticky.
8120 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8121 * w32fns.c (syms_of_w32fns):
8122 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8124 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8126 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8127 This is more efficient than Ffile_directory_p and avoids a minor race.
8129 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8131 * buffer.c (Foverlay_put): Say what the return value is
8134 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8135 is a directory before asking whether to use the file name
8137 (barf_or_query_if_file_exists): Make the "File is a directory"
8138 error be more correct.
8140 * fns.c (Frequire): Remove the mention of the .gz files, since
8141 that's installation-specific, but keep the mention of
8142 `get-load-suffixes'.
8144 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8146 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8147 Report string overflow if the output is too long.
8149 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8151 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8152 (syms_of_gnutls): Remove duplicate DEFSYM for
8153 Qgnutls_bootprop_verify_hostname_error, an error for
8154 Qgnutls_bootprop_verify_error (which is no longer used).
8156 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8157 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8158 Also (re)move comments that are misplaced or no longer relevant.
8160 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8162 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8164 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8166 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8167 and background color parameters if they have been changed.
8169 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8171 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8173 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8175 * xsettings.c (SYSTEM_FONT): Define only when used.
8176 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8178 * keymap.c (access_keymap_1): Now static.
8180 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8182 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8183 leave any prefix arg for the up event (Bug#1586).
8185 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8187 * lread.c (syms_of_lread): Mention single symbols defined by
8188 `defvar' or `defconst' (bug#7154).
8190 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8191 (Frequire): Mention get-load-suffixes.
8193 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8195 * window.h (window): Remove clone_number slot.
8196 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8198 (make_parent_window, make_window, saved_window)
8199 (Fset_window_configuration, save_window_save): Don't deal with
8201 * buffer.c (Qclone_number): Remove declaration.
8202 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8204 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8206 Add multiple inheritance to keymaps.
8207 * keymap.c (Fmake_composed_keymap): New function.
8208 (Fset_keymap_parent): Simplify.
8209 (fix_submap_inheritance): Remove.
8210 (access_keymap_1): New function extracted from access_keymap to handle
8211 embedded parents and handle lists of maps.
8212 (access_keymap): Use it.
8213 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8214 (Fcopy_keymap): Handle embedded parents.
8215 (Fcommand_remapping, define_as_prefix): Simplify.
8216 (Fkey_binding): Simplify.
8217 (syms_of_keymap): Move minibuffer-local-completion-map,
8218 minibuffer-local-filename-completion-map,
8219 minibuffer-local-must-match-map, and
8220 minibuffer-local-filename-must-match-map to Elisp.
8221 (syms_of_keymap): Defsubr make-composed-keymap.
8222 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8223 (parse_menu_item): Trivial simplification.
8225 2011-07-01 Glenn Morris <rgm@gnu.org>
8227 * Makefile.in (SETTINGS_LIBS): Fix typo.
8229 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8231 * coding.c (Fencode_coding_string): Record the last coding system
8232 used, as the function doc string says (bug#8738).
8234 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8236 * xsettings.c (store_monospaced_changed): Take new font as arg and
8237 check for change against current_mono_font.
8238 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8239 (emacs_settings_constructor, emacs_settings_get_property)
8240 (emacs_settings_set_property, emacs_settings_class_init)
8241 (emacs_settings_init, gsettings_obj): Remove.
8242 (something_changedCB): New function for HAVE_GSETTINGS.
8243 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8244 with value as argument.
8245 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8246 g_settings_new (Bug#8967). Do not create gsettings_obj.
8247 Remove calls to g_settings_bind. Connect something_changedCB to
8250 * xgselect.c: Add defined (HAVE_GSETTINGS).
8251 (xgselect_initialize): Ditto.
8253 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8254 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8257 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8259 * eval.c (struct backtrace): Simplify and port the data structure.
8260 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8261 signed bit field, as this assumption is not portable and it makes
8262 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8263 "char debug_on_exit : 1" as this is not portable either; instead,
8264 use the portable "unsigned int debug_on_exit : 1". Remove unused
8265 member evalargs. Remove obsolete comments about cc bombing out.
8267 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8269 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8270 Let HAVE_GSETTINGS override HAVE_GCONF.
8271 (store_monospaced_changed): New function.
8272 (EMACS_SETTINGS): A new type derived from GObject to handle
8273 GSettings notifications.
8274 (emacs_settings_constructor, emacs_settings_get_property)
8275 (emacs_settings_set_property, emacs_settings_class_init):
8277 (gsettings_client, gsettings_obj): New variables.
8278 (GSETTINGS_SCHEMA): New define.
8279 (something_changedCB): Call store_monospaced_changed.
8280 (init_gsettings): New function.
8281 (xsettings_initialize): Call init_gsettings.
8282 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8285 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8288 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8290 * window.c (resize_root_window, grow_mini_window)
8291 (shrink_mini_window): Rename Qresize_root_window to
8292 Qwindow_resize_root_window and Qresize_root_window_vertically to
8293 Qwindow_resize_root_window_vertically.
8295 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8297 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8299 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8301 * makefile.w32-in: Redesign dependencies so they reflect more
8302 clearly which files are directly included by each source file,
8303 and not through other includes.
8305 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8307 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8308 (sort_overlays, overlay_strings): When an overlay's clone number
8309 matches the window's clone number process the overlay even if
8310 the overlay's window property doesn't match the current window.
8312 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8313 (Fwindow_hchild): Rename to Fwindow_left_child.
8314 (Fwindow_next): Rename to Fwindow_next_sibling.
8315 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8316 (resize_window_check): Rename to window_resize_check.
8317 (resize_window_apply): Rename to window_resize_apply.
8318 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8319 (Fdelete_other_windows_internal, resize_frame_windows)
8320 (Fsplit_window_internal, Fdelete_window_internal)
8321 (grow_mini_window, shrink_mini_window)
8322 (Fresize_mini_window_internal): Fix callers accordingly.
8324 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8326 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8327 (emacs_fixed_set_min_size): Remove.
8328 (emacs_fixed_new): Take frame as argument.
8330 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8331 (_EmacsFixedPrivate): Remove minwidth/height.
8332 Add struct frame *f.
8333 (emacs_fixed_init): Initialize priv->f.
8334 (get_parent_class, emacs_fixed_set_min_size): Remove.
8335 (emacs_fixed_new): Set priv->f to argument.
8336 (emacs_fixed_get_preferred_width)
8337 (emacs_fixed_get_preferred_height): Use min_width/height from
8338 frames size_hint to set minimum and natural (Bug#8919).
8339 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8340 and use min_width/height from frames size_hint to set
8341 min_width/height (Bug#8919).
8343 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8344 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8347 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8349 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8350 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8353 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8355 * process.c (wait_reading_process_output): Bypass select if
8356 waiting for a cell while ignoring keyboard input, and input is
8357 pending. Suggested by Jan Djärv (Bug#8869).
8359 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8361 Use gnulib's dup2 module instead of rolling our own.
8362 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8364 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8366 * dispnew.c (scrolling_window): Before scrolling, turn off a
8367 mouse-highlight in the window being scrolled.
8369 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8371 Move DEFSYM to lisp.h and use everywhere.
8373 * character.h (DEFSYM): Move declaration...
8374 * lisp.h (DEFSYM): ...here.
8380 * w32select.c: Don't include character.h.
8382 * alloc.c (syms_of_alloc):
8383 * buffer.c (syms_of_buffer):
8384 * bytecode.c (syms_of_bytecode):
8385 * callint.c (syms_of_callint):
8386 * casefiddle.c (syms_of_casefiddle):
8387 * casetab.c (init_casetab_once):
8388 * category.c (init_category_once, syms_of_category):
8389 * ccl.c (syms_of_ccl):
8390 * cmds.c (syms_of_cmds):
8391 * composite.c (syms_of_composite):
8392 * dbusbind.c (syms_of_dbusbind):
8393 * dired.c (syms_of_dired):
8394 * dispnew.c (syms_of_display):
8395 * doc.c (syms_of_doc):
8396 * editfns.c (syms_of_editfns):
8397 * emacs.c (syms_of_emacs):
8398 * eval.c (syms_of_eval):
8399 * fileio.c (syms_of_fileio):
8400 * fns.c (syms_of_fns):
8401 * frame.c (syms_of_frame):
8402 * fringe.c (syms_of_fringe):
8403 * insdel.c (syms_of_insdel):
8404 * keymap.c (syms_of_keymap):
8405 * lread.c (init_obarray, syms_of_lread):
8406 * macros.c (syms_of_macros):
8407 * msdos.c (syms_of_msdos):
8408 * print.c (syms_of_print):
8409 * process.c (syms_of_process):
8410 * search.c (syms_of_search):
8411 * sound.c (syms_of_sound):
8412 * syntax.c (init_syntax_once, syms_of_syntax):
8413 * terminal.c (syms_of_terminal):
8414 * textprop.c (syms_of_textprop):
8415 * undo.c (syms_of_undo):
8416 * w32.c (globals_of_w32):
8417 * window.c (syms_of_window):
8418 * xdisp.c (syms_of_xdisp):
8419 * xfaces.c (syms_of_xfaces):
8420 * xfns.c (syms_of_xfns):
8421 * xmenu.c (syms_of_xmenu):
8422 * xsettings.c (syms_of_xsettings):
8423 * xterm.c (syms_of_xterm): Use DEFSYM.
8425 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8427 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8429 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8431 Integer and buffer overflow fixes (Bug#8873).
8433 * print.c (printchar, strout): Check for string overflow.
8434 (PRINTPREPARE, printchar, strout):
8435 Don't set size unless allocation succeeds.
8437 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8438 for sizes. Check for string overflow more accurately.
8439 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8441 * macros.c: Integer and buffer overflow fixes.
8442 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8443 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8444 Use ptrdiff_t, not int, for sizes.
8445 Don't increment bufsize until after realloc succeeds.
8446 Check for size-calculation overflow.
8447 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8449 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8451 * lread.c: Integer overflow fixes.
8452 (read_integer): Radix is now EMACS_INT, not int,
8453 to improve quality of diagnostics for out-of-range radices.
8454 Calculate buffer size correctly for out-of-range radices.
8455 (read1): Check for integer overflow in radices, and in
8456 read-circle numbers.
8457 (read_escape): Avoid int overflow.
8458 (Fload, openp, read_buffer_size, read1)
8459 (substitute_object_recurse, read_vector, read_list, map_obarray):
8460 Use ptrdiff_t, not int, for sizes.
8461 (read1): Use EMACS_INT, not int, for sizes.
8462 Check for size overflow.
8464 * image.c (cache_image): Check for size arithmetic overflow.
8466 * lread.c: Integer overflow issues.
8467 (saved_doc_string_size, saved_doc_string_length)
8468 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8469 Now ptrdiff_t, not int.
8470 (read1): Don't assume doc string length fits in int. Check for
8471 out-of-range doc string lengths.
8472 (read_list): Don't assume file position fits in int.
8473 (read_escape): Check for hex character overflow.
8475 2011-06-22 Leo Liu <sdl.web@gmail.com>
8477 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8478 Move to minibuffer.el.
8480 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8482 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8483 The following patches are for when GLYPH_DEBUG && !XASSERT.
8484 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8485 * dispnew.c (flush_stdout):
8486 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8487 Mark as externally visible.
8488 * dispnew.c (check_window_matrix_pointers): Now static.
8489 * dispnew.c (window_to_frame_vpos):
8490 * xfns.c (unwind_create_frame):
8491 * xterm.c (x_check_font): Remove unused local.
8492 * scroll.c (CHECK_BOUNDS):
8493 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8494 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8495 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8496 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8497 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8499 (debug_method_add): Use va_list and vsprintf rather than relying
8500 on undefined behavior with wrong number of arguments.
8501 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8502 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8503 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8504 since we're not interested in debugging glyphs with old libraries.
8505 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8506 GCC 4.6.0's static checking.
8508 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8510 Integer overflow and signedness fixes (Bug#8873).
8511 A few related buffer overrun fixes, too.
8513 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8515 * dispextern.h (struct face.stipple):
8516 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8517 (x_bitmap_mask, x_allocate_bitmap_record)
8518 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8519 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8520 (x_create_bitmap_from_xpm_data):
8521 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8522 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8524 * xfaces.c (load_pixmap):
8525 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8526 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8527 (.bitmaps_last, struct x_output.icon_bitmap):
8528 Use ptrdiff_t, not int, for bitmap indexes.
8529 (x_allocate_bitmap_record): Check for size overflow.
8530 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8532 Use ptrdiff_t, not int, for overlay counts.
8533 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8534 * editfns.c (overlays_around, get_pos_property):
8535 * textprop.c (get_char_property_and_overlay):
8536 * xdisp.c (next_overlay_change, note_mouse_highlight):
8537 * xfaces.c (face_at_buffer_position):
8538 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8539 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8540 (Fnext_overlay_change, Fprevious_overlay_change)
8541 (mouse_face_overlay_overlaps, Foverlays_in):
8542 Use ptrdiff_t, not int, for sizes.
8543 (overlays_at, overlays_in): Check for size-calculation overflow.
8545 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8547 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8548 (x_session_initialize): Do not assume string length fits in int.
8550 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8551 This is unlikely, but can occur if DPI is outlandish.
8553 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8554 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8556 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8557 * xrdb.c (magic_file_p, search_magic_path):
8558 Omit last arg SUFFIX; it was always 0. All callers changed.
8559 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8561 * xfont.c (xfont_match): Avoid need for strlen.
8563 * xfns.c: Don't assume strlen fits in int.
8564 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8566 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8567 not unsigned long, as we prefer signed integers. All callers changed.
8568 Detect integer overflow in repeat count.
8569 (message_dolog): Don't assume print length fits in 39 bytes.
8570 (display_mode_element): Don't assume strlen fits in int.
8572 * termcap.c: Don't assume sizes fit in int and never overflow.
8573 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8574 (gobble_line): Check for size-calculation overflow.
8576 * minibuf.c (Fread_buffer):
8577 * lread.c (intern, intern_c_string):
8578 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8579 Don't assume string length fits in int.
8581 * keyboard.c (parse_tool_bar_item):
8582 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8584 * font.c: Don't assume string length fits in int.
8585 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8586 Use ptrdiff_t, not int.
8587 (font_intern_prop): Don't assume string length fits in int.
8588 Don't assume integer property fits in fixnum.
8589 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8591 * filelock.c: Fix some buffer overrun and integer overflow issues.
8592 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8593 Reformulate so as not to need the command string.
8594 Invoke gzip -cd rather than gunzip, as it's more portable.
8595 (lock_info_type, lock_file_1, lock_file):
8596 Don't assume pid_t and time_t fit in unsigned long.
8597 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8598 (current_lock_owner): Prefer signed type for sizes.
8599 Use memcpy, not strncpy, where memcpy is what is really wanted.
8600 Don't assume (via atoi) that time_t and pid_t fit in int.
8601 Check for time_t and/or pid_t out of range, e.g., via a network share.
8602 Don't alloca where an auto var works fine.
8604 * fileio.c: Fix some integer overflow issues.
8605 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8606 Don't assume string length fits in int.
8607 (directory_file_name): Don't assume string length fits in long.
8608 (make_temp_name): Don't assume pid fits in int, or that its print
8609 length is less than 20.
8611 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8613 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8615 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8617 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8618 We prefer signed integers, even for size calculations.
8620 * emacs.c: Don't assume string length fits in 'int'.
8621 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8622 (main): Don't invoke strlen when not needed.
8624 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8625 (XD_DEBUG_MESSAGE): Don't waste a byte.
8627 * callproc.c (getenv_internal_1, getenv_internal)
8629 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8631 * lread.c (invalid_syntax): Omit length argument.
8632 All uses changed. This doesn't fix a bug, but it simplifies the
8633 code away from its former Hollerith-constant appearance, and it's
8634 one less 'int' to worry about when looking at integer-overflow issues.
8635 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8637 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8638 This didn't break anything, but it didn't help either.
8639 It's confusing to put a bogus integer in a place where the actual
8640 value does not matter.
8641 (LIST_END_P): Remove unused macro and its bogus comment.
8642 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8644 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8645 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8647 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8648 We prefer signed types, and the value cannot exceed the EMACS_INT
8649 range anyway (because otherwise the length would not be representable).
8650 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8651 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8652 This avoids a GCC warning when WIDE_EMACS_INT.
8654 * indent.c (sane_tab_width): New function.
8655 (current_column, scan_for_column, Findent_to, position_indentation)
8656 (compute_motion): Use it. This is just for clarity.
8657 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8659 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8661 * lisp.h (lint_assume): New macro.
8662 * composite.c (composition_gstring_put_cache):
8663 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8665 * editfns.c, insdel.c:
8666 Omit unnecessary forward decls, to simplify future changes.
8668 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8670 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8672 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8673 Use much-faster test for byte-length change.
8674 Don't assume string byte-length fits in 'int'.
8675 Check that character arg fits in 'int'.
8676 (mapcar1): Declare byte as byte, for clarity.
8678 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8680 * fns.c (concat): Catch string overflow earlier.
8681 Do not rely on integer wraparound.
8683 * dispextern.h (struct it.overlay_strings_charpos)
8684 (struct it.selective): Now EMACS_INT, not int.
8685 * xdisp.c (forward_to_next_line_start)
8686 (back_to_previous_visible_line_start)
8687 (reseat_at_next_visible_line_start, next_element_from_buffer):
8688 Don't arbitrarily truncate the value of 'selective' to int.
8690 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8692 * composite.c: Don't truncate sizes to 'int'.
8693 (composition_gstring_p, composition_reseat_it)
8694 (composition_adjust_point): Use EMACS_INT, not int.
8695 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8696 not EMACS_UINT, for indexes.
8698 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8700 * buffer.c: Include <verify.h>.
8701 (struct sortvec.priority, struct sortstr.priority):
8702 Now EMACS_INT, not int.
8703 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8704 (struct sortstr.size, record_overlay_string)
8705 (struct sortstrlist.size, struct sortlist.used):
8706 Don't truncate size to int.
8707 (record_overlay_string): Check for size-calculation overflow.
8708 (init_buffer_once): Check at compile-time, not run-time.
8710 2011-06-22 Jim Meyering <meyering@redhat.com>
8712 Don't leak an XBM-image-sized buffer
8713 * image.c (xbm_load): Free the image buffer after using it.
8715 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8718 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8719 that Sun C diagnosed.
8720 * fns.c (secure_hash): Fix pointer signedness issue.
8721 * intervals.c (static_offset_intervals): New function.
8722 (offset_intervals): Use it.
8724 2011-06-21 Leo Liu <sdl.web@gmail.com>
8727 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8730 * fns.c (secure_hash): Rename from crypto_hash_function and change
8731 the first arg to accept symbols.
8732 (Fsecure_hash): New primitive.
8733 (syms_of_fns): New symbols.
8735 2011-06-20 Deniz Dogan <deniz@dogan.se>
8737 * process.c (Fset_process_buffer): Clarify return value in
8740 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8742 * dispnew.c (add_window_display_history): Use BVAR.
8744 * xdisp.c (debug_method_add): Use BVAR.
8745 (check_window_end, dump_glyph_matrix, dump_glyph)
8746 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8748 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8751 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8752 check till after the cache is created in init_frame_faces.
8754 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8756 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8758 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8760 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8761 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8762 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8764 Improve buffer-overflow checking (Bug#8873).
8765 * fileio.c (Finsert_file_contents):
8766 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8767 Remove the old (too-loose) buffer overflow checks.
8768 They weren't needed, since make_gap checks for buffer overflow.
8769 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8770 The old code merely checked for Emacs fixnum overflow, and relied
8771 on undefined (wraparound) behavior. The new code avoids undefined
8772 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8774 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8775 Tune. Don't use wider integers than needed. Don't use alloca.
8776 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8778 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8780 * insdel.c, lisp.h (buffer_overflow): New function.
8781 (insert_from_buffer_1, replace_range, replace_range_2):
8782 * insdel.c (make_gap_larger):
8783 * editfns.c (Finsert_char):
8784 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8786 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8788 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8790 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8792 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8793 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8795 * fileio.c: Don't assume EMACS_INT fits in off_t.
8796 (emacs_lseek): New static function.
8797 (Finsert_file_contents, Fwrite_region): Use it.
8798 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8800 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8802 * fns.c: Don't overflow int when computing a list length.
8803 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8804 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8805 truncation on 64-bit hosts. Check for QUIT every
8806 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8807 faster and is responsive enough.
8808 (Flength): Report an error instead of overflowing an integer.
8809 (Fsafe_length): Return a float if the value is not representable
8810 as a fixnum. This shouldn't happen except in contrived situations.
8811 (Fnthcdr, Fsort): Don't assume list length fits in int.
8812 (Fcopy_sequence): Don't assume vector length fits in int.
8814 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8815 (header_size, word_size): New constants.
8816 (allocate_vectorlike): Don't check size overflow here.
8817 (allocate_vector): Check it here instead, since this is the only
8818 caller of allocate_vectorlike that could cause overflow.
8819 Check that the new vector's length is representable as a fixnum.
8821 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8822 The previous code was bogus. For example, next_almost_prime (32)
8823 returned 39, which is undesirable as it is a multiple of 3; and
8824 next_almost_prime (24) returned 25, which is a multiple of 5 so
8825 why was the code bothering to check for multiples of 7?
8827 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8829 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8831 Variadic C functions now count arguments with ptrdiff_t.
8832 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8833 Back then I didn't know that the Emacs coding style prefers signed int.
8834 Also, in the meantime I found a few more instances where arguments
8835 were being counted with int, which may truncate counts on 64-bit
8836 machines, or EMACS_INT, which may be unnecessarily wide.
8837 * lisp.h (struct Lisp_Subr.function.aMANY)
8838 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8839 Arg counts are now ptrdiff_t, not size_t.
8840 All variadic functions and their callers changed accordingly.
8841 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8842 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8843 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8844 * callint.c (Fcall_interactively): Check arg count for overflow,
8845 to avoid potential buffer overrun. Use signed char, not 'int',
8846 for 'varies' array, so that we needn't bother to check its size
8847 calculation for overflow.
8848 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8849 * eval.c (apply_lambda):
8850 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8851 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8852 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8854 * callint.c (Fcall_interactively): Don't use index var as event count.
8856 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8857 * mem-limits.h (SIZE): Remove; no longer used.
8859 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8861 Remove unnecessary casts.
8862 * xterm.c (x_term_init):
8863 * xfns.c (x_set_border_pixel):
8864 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8865 These aren't needed now that we assume ANSI C.
8867 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8868 It's more likely to cause problems (due to unsigned overflow)
8871 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8873 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8875 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8877 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8879 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8881 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8883 GLYPH_CODE_FACE returns EMACS_INT, not int.
8884 * dispextern.h (merge_faces):
8885 * xfaces.c (merge_faces):
8886 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8887 Don't assume EMACS_INT fits in int.
8889 * character.h (CHAR_VALID_P): Remove unused parameter.
8890 * fontset.c, lisp.h, xdisp.c: All uses changed.
8892 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8894 * fns.c (concat): Minor tuning based on overflow analysis.
8895 This doesn't fix any bugs. Use int to hold character, instead
8896 of constantly refetching from Emacs object. Use XFASTINT, not
8897 XINT, for value known to be a character. Don't bother comparing
8898 a single byte to 0400, as it's always less.
8900 * floatfns.c (Fexpt):
8901 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8903 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8906 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8908 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8909 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8910 incorrectly succeed when S was a string, because 4294967386 was
8911 truncated before it was used.
8913 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8914 Otherwise, an out-of-range integer could cause undefined behavior
8917 * composite.c: Use int, not EMACS_INT, for characters.
8918 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8919 EMACS_INT, for values that are known to be in character range.
8920 This doesn't fix any bugs but is the usual style inside Emacs and
8921 may generate better code on 32-bit machines.
8923 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8924 This is for reasons similar to the recent CHAR_STRING fix.
8925 * charset.c (Fencode_char): Check that character arg is actually
8926 a character. Pass an int to ENCODE_CHAR.
8927 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8928 wider than 'int', as a compile-time check to prevent future regressions
8931 * character.c (char_string): Remove unnecessary casts.
8933 Make sure a 64-bit char is never passed to CHAR_STRING.
8934 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8935 by silently ignoring the top 32 bits, allowing some values
8936 that were far too large to be valid characters.
8937 * character.h: Include <verify.h>.
8938 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8939 arguments are no wider than unsigned, as a compile-time check
8940 to prevent future regressions in this area.
8942 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8943 (Fsubst_char_in_region):
8945 * xdisp.c (decode_mode_spec_coding):
8946 Adjust to CHAR_STRING's new requirement.
8947 * editfns.c (Finsert_char, Fsubst_char_in_region):
8948 * fns.c (concat): Check that character args are actually
8949 characters. Without this test, these functions did the wrong
8950 thing with wildly out-of-range values on 64-bit hosts.
8952 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8953 These casts should not be needed on 32-bit hosts, either.
8954 * keyboard.c (read_char):
8955 * lread.c (Fload): Remove casts to unsigned.
8957 * lisp.h (UNSIGNED_CMP): New macro.
8958 This fixes comparison bugs on 64-bit hosts.
8959 (ASCII_CHAR_P): Use it.
8960 * casefiddle.c (casify_object):
8961 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8962 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8963 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8964 * dispextern.h (FACE_FROM_ID):
8965 * keyboard.c (read_char): Use UNSIGNED_CMP.
8967 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8968 not to EMACS_INT, to avoid GCC warning.
8970 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8972 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8973 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8974 isn't needed on 32-bit machines.
8976 * buffer.c (Fgenerate_new_buffer_name):
8977 Use EMACS_INT for count, not int.
8978 (advance_to_char_boundary): Return EMACS_INT, not int.
8980 * data.c (Qcompiled_function): Now static.
8982 * window.c (window_body_lines): Now static.
8984 * image.c (gif_load): Rename local to avoid shadowing.
8986 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8987 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8988 * alloc.c (make_save_value): Integer argument is now of type
8990 (mark_object): Use ptrdiff_t, not int.
8991 * lisp.h (pD): New macro.
8992 * print.c (print_object): Use it.
8994 * alloc.c: Use EMACS_INT, not int, to count objects.
8995 (total_conses, total_markers, total_symbols, total_vector_size)
8996 (total_free_conses, total_free_markers, total_free_symbols)
8997 (total_free_floats, total_floats, total_free_intervals)
8998 (total_intervals, total_strings, total_free_strings):
8999 Now EMACS_INT, not int. All uses changed.
9000 (Fgarbage_collect): Compute overall total using a double, so that
9001 integer overflow is less likely to be a problem. Check for overflow
9002 when converting back to an integer.
9003 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9004 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9005 These were 'int' variables that could overflow on 64-bit hosts;
9006 they were never used, so remove them instead of repairing them.
9007 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9008 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9009 Previously, this ceilinged at INT_MAX, but that doesn't work on
9011 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9013 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9014 (allocate_vectorlike): Check for ptrdiff_t overflow.
9015 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9016 when a (possibly-narrower) signed value would do just as well.
9017 We prefer using signed arithmetic, to avoid comparison confusion.
9019 * alloc.c: Catch some string size overflows that we were missing.
9020 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9021 for convenience in STRING_BYTES_MAX.
9022 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9023 The definition here is exact; the one in lisp.h was approximate.
9024 (allocate_string_data): Check for string overflow. This catches
9025 some instances we weren't catching before. Also, it catches
9026 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9027 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9028 and ptrdiff_t and EMACS_INT are both 64 bits.
9030 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9031 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9032 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9034 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9036 * alloc.c (Fmake_string): Check for out-of-range init.
9038 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9040 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9042 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9044 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9045 xg_get_default_scrollbar_width.
9047 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9048 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9049 (style_changed_cb): Call update_theme_scrollbar_width and call
9050 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9051 all frames (Bug#8505).
9052 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9053 Call gtk_window_set_resizable if HAVE_GTK3.
9054 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9055 and height if HAVE_GTK3 (Bug#8505).
9056 (scroll_bar_width_for_theme): New variable.
9057 (update_theme_scrollbar_width): New function.
9058 (xg_get_default_scrollbar_width): Move code to
9059 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9060 (xg_initialize): Call update_theme_scrollbar_width.
9062 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9064 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9066 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9068 * frame.c (make_frame): Call other_buffer_safely instead of
9071 * window.c (temp_output_buffer_show): Call display_buffer with
9072 second argument Vtemp_buffer_show_specifiers and reset latter
9073 immediately after the call.
9074 (Vtemp_buffer_show_specifiers): New variable.
9075 (auto_window_vscroll_p, next_screen_context_lines)
9076 (Vscroll_preserve_screen_position): Remove leading asterisks from
9079 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9081 Fix minor problems found by GCC 4.6.0 static checking.
9082 * buffer.c (Qclone_number): Remove for now, as it's unused.
9083 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9084 (record_buffer): Remove unused local.
9085 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9086 (set_frame_buffer_list): Remove; unused.
9087 * frame.h (other_visible_frames): Remove decl.
9088 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9089 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9090 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9092 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9093 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9094 Define only if HAVE_GPM.
9095 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9096 (update_hints_inhibit): Remove; never set. All uses removed.
9097 * widgetprv.h (emacsFrameClassRec): Remove decl.
9098 * window.c (delete_deletable_window): Now returns void, since it
9099 wasn't returning anything.
9100 (compare_window_configurations): Remove unused locals.
9101 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9102 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9103 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9104 the same widths as pointers. This follows up on the 2011-05-06 patch.
9105 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9106 * xterm.h: Likewise.
9107 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9109 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9111 * makefile.w32-in: Update dependencies.
9112 (LISP_H): Add lib/intprops.h.
9114 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9116 * image.c (gif_load): Add animation frame delay to the metadata.
9117 (syms_of_image): Use DEFSYM. New symbol `delay'.
9119 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9121 * window.c (delete_deletable_window): Re-add.
9122 (Fset_window_configuration): Rewrite to handle dead buffers and
9123 consequently deletable windows.
9124 (window_tree, Fwindow_tree): Remove. Supply functionality in
9126 (compare_window_configurations): Simplify code.
9128 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9130 * image.c (imagemagick_load_image): Fix type mismatch.
9131 (Fimagemagick_types): Likewise.
9133 * window.h (replace_buffer_in_windows): Declare.
9135 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9137 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9138 Qclone_number. Remove external declaration of Qdelete_window.
9139 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9141 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9142 Run Qbuffer_list_update_hook if allowed.
9143 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9144 buffer list implementation.
9145 (other_buffer_safely): New function.
9146 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9147 calls to replace_buffer_in_windows and
9148 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9150 (record_buffer): Inhibit quitting and rewrite using quittable
9151 functions. Run Qbuffer_list_update_hook if allowed.
9152 (Frecord_buffer, Funrecord_buffer): New functions.
9153 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9154 Move switch-to-buffer to window.el.
9155 (bury-buffer): Move to window.el.
9156 (Vbuffer_list_update_hook): New variable.
9158 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9161 * window.h (resize_frame_windows): Move up in code.
9162 (Fwindow_frame): Remove EXFUN.
9163 (replace_buffer_in_all_windows): Remove prototype.
9164 (replace_buffer_in_windows_safely): Add prototype.
9166 * window.c: Declare Qdelete_window static again. Move down
9167 declaration of select_count.
9168 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9169 (Fother_window): Move to window.el.
9170 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9171 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9172 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9174 (replace_buffer_in_windows): Implement by calling
9175 Qreplace_buffer_in_windows.
9176 (replace_buffer_in_all_windows): Remove with some functionality
9177 moved into replace_buffer_in_windows_safely.
9178 (replace_buffer_in_windows_safely): New function.
9179 (select_window_norecord, select_frame_norecord): Move in front
9180 of run_window_configuration_change_hook. Remove now obsolete
9182 (Fset_window_buffer): Rewrite doc-string.
9183 Call Qrecord_window_buffer.
9184 (keys_of_window): Move binding for other-window to window.el.
9186 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9188 * dispextern.h (struct image): Replace data member, whose int_val
9189 and ptr_val fields were not used by anything, with a single
9192 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9193 (gif_clear_image, gif_load, imagemagick_load_image)
9194 (gs_clear_image, gs_load): Callers changed.
9196 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9198 * buffer.h: Include <time.h>, for time_t.
9199 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9201 Fix minor problems found by static checking.
9203 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9205 Make identifiers static if they are not used in other modules.
9206 * data.c (Qcompiled_function, Qframe, Qvector):
9207 * image.c (QimageMagick, Qsvg):
9208 * minibuf.c (Qmetadata):
9209 * window.c (resize_window_check, resize_root_window): Now static.
9210 * window.h (resize_window_check, resize_root_window): Remove decls.
9212 * window.c (window_deletion_count, delete_deletable_window):
9214 (window_body_lines): Now static.
9215 (Fdelete_other_windows_internal): Mark vars as initialized.
9216 Make sure 'resize_failed' is initialized.
9217 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9218 (resize_window_apply): Remove unused local.
9219 * window.h (delete_deletable_window): Remove decl.
9221 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9222 (imagemagick_load_image): Fix pointer signedness problem by changing
9223 last arg from unsigned char * to char *. All uses changed.
9224 Also, fix a local for similar reasons.
9225 Remove unused locals. Remove locals to avoid shadowing.
9226 (fn_rsvg_handle_free): Remove; unused.
9227 (svg_load, svg_load_image): Fix pointer signedness problem.
9228 (imagemagick_load_image): Don't use garbage pointer image_wand.
9230 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9232 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9234 * image.c (gif_load): Fix omitted cast error introduced by
9237 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9239 * window.h (resize_proportionally, orig_total_lines)
9240 (orig_top_line): Remove from window structure.
9241 (set_window_height, set_window_width, change_window_heights)
9242 (Fdelete_window): Remove prototypes.
9243 (resize_frame_windows): Remove duplicate declaration.
9245 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9247 * window.h (resize_frame_windows, resize_window_check)
9248 (delete_deletable_window, resize_root_window)
9249 (resize_frame_windows): Declare prototypes.
9251 * window.c (resize_window_apply): Make definition be "static" to
9252 match the prototype.
9254 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9256 * window.c: Remove declarations of Qwindow_size_fixed,
9257 window_min_size_1, window_min_size_2, window_min_size,
9258 size_window, window_fixed_size_p, enlarge_window, delete_window.
9259 Remove static from declaration of Qdelete_window, it's
9260 temporarily needed by Fbury_buffer.
9261 (replace_window): Don't assign orig_top_line and
9263 (Fdelete_window, delete_window): Remove. Window deletion is
9264 handled by window.el.
9265 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9266 Replace Fdelete_window calls with calls to Qdelete_window.
9267 (Fdelete_other_windows): Remove. Deleting other windows is
9268 handled by window.el.
9269 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9270 handled in window.el.
9271 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9272 Window minimum sizes are handled in window.el.
9273 (shrink_windows, size_window, set_window_height)
9274 (set_window_width, change_window_heights, window_height)
9275 (window_width, CURBEG, CURSIZE, enlarge_window)
9276 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9277 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9278 handled in window.el.
9279 (make_dummy_parent): Rename to make_parent_window and give it a
9280 second argument horflag.
9281 (make_window): Don't set resize_proportionally any more.
9282 (Fsplit_window): Remove. Windows are split in window.el.
9283 (save_restore_action, save_restore_orig_size)
9284 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9285 Resize mini windows in window.el.
9286 (grow_mini_window, shrink_mini_window): Implement by calling
9287 Qresize_root_window_vertically, resize_window_check and
9288 resize_window_apply.
9289 (saved_window, Fset_window_configuration, save_window_save):
9290 Do not handle orig_top_line, orig_total_lines, and
9291 resize_proportionally.
9292 (window_min_height, window_min_width): Move to window.el.
9293 (keys_of_window): Move bindings for delete-other-windows,
9294 split-window, delete-window and enlarge-window to window.el.
9296 * buffer.c: Temporarily extern Qdelete_window.
9297 (Fbury_buffer): Temporarily call Qdelete_window instead of
9298 Fdelete_window (Fbury_buffer will move to window.el soon).
9300 * frame.c (set_menu_bar_lines_1): Remove code handling
9301 orig_top_line and orig_total_lines.
9303 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9304 set_window_height but set heights directly.
9305 (change_frame_size_1): Use resize_frame_windows.
9307 * xdisp.c (init_xdisp): Don't use set_window_height but set
9310 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9311 Use resize_frame_windows instead of change_window_heights and run
9312 run_window_configuration_change_hook.
9314 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9315 instead of change_window_heights and run
9316 run_window_configuration_change_hook.
9318 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9320 * window.c (replace_window): Rename second argument REPLACEMENT to
9321 NEW. New third argument SETFLAG. Rewrite.
9322 (delete_window, make_dummy_parent): Call replace_window with
9324 (window_list_1): Move down in code.
9325 (run_window_configuration_change_hook): Move set_buffer part
9326 before select_frame_norecord part in order to unwind correctly.
9327 Rename count1 to count.
9328 (recombine_windows, delete_deletable_window, resize_root_window)
9329 (Fdelete_other_windows_internal)
9330 (Frun_window_configuration_change_hook, make_parent_window)
9331 (resize_window_check, resize_window_apply, Fresize_window_apply)
9332 (resize_frame_windows, Fsplit_window_internal)
9333 (Fdelete_window_internal, Fresize_mini_window_internal):
9335 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9337 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9339 * window.h (window): Add some new members to window structure -
9340 normal_lines, normal_cols, new_total, new_normal, clone_number,
9341 splits, nest, prev_buffers, next_buffers.
9342 (WINDOW_TOTAL_SIZE): Move here from window.c.
9343 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9345 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9347 (make_dummy_parent): Set new members of windows structure.
9348 (make_window): Move down in code. Handle new members of window
9350 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9351 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9352 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9353 (Fset_window_prev_buffers, Fwindow_next_buffers)
9354 (Fset_window_next_buffers, Fset_window_clone_number):
9356 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9357 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9359 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9360 Argument WINDOW can be now internal window too.
9361 (Fwindow_use_time): Move up in code.
9362 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9364 (Fset_window_configuration, saved_window)
9365 (Fcurrent_window_configuration, save_window_save): Handle new
9366 members of window structure.
9367 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9368 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9369 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9370 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9371 Qget_mru_window, Qresize_root_window,
9372 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9373 Qauto_buffer_name; staticpro them.
9375 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9377 * window.c (Fwindow_total_size, Fwindow_left_column)
9378 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9379 (Fwindow_list_1): New functions.
9380 (window_box_text_cols): Replace with window_body_cols.
9381 (Fwindow_width, Fscroll_left, Fscroll_right):
9382 Use window_body_cols instead of window_box_text_cols.
9383 (delete_window, Fset_window_configuration):
9384 Call delete_all_subwindows with window as argument.
9385 (delete_all_subwindows): Take a window as argument and not a
9387 (window_loop): Remove handling of GET_LRU_WINDOW and
9389 (Fget_lru_window, Fget_largest_window): Move to window.el.
9391 * window.h: Extern window_body_cols instead of
9392 window_box_text_cols. delete_all_subwindows now takes a
9393 Lisp_Object as argument.
9395 * indent.c (compute_motion, Fcompute_motion):
9396 Use window_body_cols instead of window_box_text_cols.
9398 * frame.c (delete_frame): Call delete_all_subwindows with root
9401 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9403 * fns.c (Fputhash): Document return value.
9405 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9407 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9409 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9411 Cons<->int and similar integer overflow fixes (Bug#8794).
9413 Check for overflow when converting integer to cons and back.
9414 * charset.c (Fdefine_charset_internal, Fdecode_char):
9415 Use cons_to_unsigned to catch overflow.
9416 (Fencode_char): Use INTEGER_TO_CONS.
9417 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9418 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9419 * data.c (long_to_cons, cons_to_long): Remove.
9420 (cons_to_unsigned, cons_to_signed): New functions.
9421 These signal an error for invalid or out-of-range values.
9422 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9423 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9424 * font.c (Ffont_variation_glyphs):
9425 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9426 * lisp.h: Include <intprops.h>.
9427 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9428 (cons_to_signed, cons_to_unsigned): New decls.
9429 (long_to_cons, cons_to_long): Remove decls.
9430 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9431 (Fprimitive_undo): Use CONS_TO_INTEGER.
9432 * xfns.c (Fx_window_property): Likewise.
9433 * xselect.c: Include <limits.h>.
9434 (x_own_selection, selection_data_to_lisp_data):
9435 Use INTEGER_TO_CONS.
9436 (x_handle_selection_request, x_handle_selection_clear)
9437 (x_get_foreign_selection, Fx_disown_selection_internal)
9438 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9439 (lisp_data_to_selection_data): Use cons_to_unsigned.
9440 (x_fill_property_data): Use cons_to_signed.
9441 Report values out of range.
9443 Check for buffer and string overflow more precisely.
9444 * buffer.h (BUF_BYTES_MAX): New macro.
9445 * lisp.h (STRING_BYTES_MAX): New macro.
9446 * alloc.c (Fmake_string):
9447 * character.c (string_escape_byte8):
9448 * coding.c (coding_alloc_by_realloc):
9449 * doprnt.c (doprnt):
9450 * editfns.c (Fformat):
9452 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9453 since they may not be the same number.
9454 * editfns.c (Finsert_char):
9455 * fileio.c (Finsert_file_contents):
9456 Likewise for BUF_BYTES_MAX.
9458 * image.c: Use ptrdiff_t, not int, for sizes.
9459 (slurp_file): Switch from int to ptrdiff_t.
9461 (slurp_file): Check that file size fits in both size_t (for
9462 malloc) and ptrdiff_t (for sanity and safety).
9464 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9465 if b->modtime has its maximal value.
9467 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9469 Don't assume time_t can fit into int.
9470 * buffer.h (struct buffer.modtime): Now time_t, not int.
9471 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9472 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9474 Minor fixes for signed vs unsigned integers.
9475 * character.h (MAYBE_UNIFY_CHAR):
9476 * charset.c (maybe_unify_char):
9477 * keyboard.c (read_char, reorder_modifiers):
9478 XINT -> XFASTINT, since the integer must be nonnegative.
9479 * ftfont.c (ftfont_spec_pattern):
9480 * keymap.c (access_keymap, silly_event_symbol_error):
9481 XUINT -> XFASTINT, since the integer must be nonnegative.
9482 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9483 since it makes no difference and we prefer signed.
9484 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9485 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9488 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9490 * window.h (Fwindow_frame): Declare.
9492 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9494 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9495 (SPARE_MEMORY): Always define.
9496 (LARGE_REQUEST): Remove.
9497 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9499 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9501 * lisp.h: Move EXFUNS for Fframe_root_window,
9502 Fframe_first_window and Fset_frame_selected_window to window.h.
9504 * window.h: Move EXFUNS for Fframe_root_window,
9505 Fframe_first_window and Fset_frame_selected_window here from
9508 * frame.c (Fwindow_frame, Fframe_first_window)
9509 (Fframe_root_window, Fframe_selected_window)
9510 (Fset_frame_selected_window): Move to window.c.
9511 (Factive_minibuffer_window): Move to minibuf.c.
9512 (Fother_visible_frames_p): New function.
9514 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9516 * window.c (decode_window, decode_any_window): Move up in code.
9517 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9518 (inhibit_frame_unsplittable): Remove unused variable.
9519 (Fwindow_buffer): Move up and rewrite doc-string.
9520 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9521 (Fwindow_prev): New functions.
9522 (Fwindow_frame): Move here from frame.c. Accept any window as
9524 (Fframe_root_window, Fframe_first_window)
9525 (Fframe_selected_window): Move here from frame.c. Accept frame
9526 or arbitrary window as argument. Update doc-strings.
9527 (Fminibuffer_window): Move up in code.
9528 (Fwindow_minibuffer_p): Move up in code and simplify.
9529 (Fset_frame_selected_window): Move here from frame.c.
9531 (Fselected_window, select_window, Fselect_window): Move up in
9532 code. Minor doc-string fixes.
9534 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9536 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9537 Do not assume that spare memory exists; that assumption is valid
9538 only if SYSTEM_MALLOC.
9539 (LARGE_REQUEST): New macro, so that the issue of large requests
9540 is separated from the issue of spare memory.
9542 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9544 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9547 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9549 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9552 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9554 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9556 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9558 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9559 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9561 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9563 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9565 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9567 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9568 (x_clipboard_manager_save): Add return value.
9569 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9571 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9572 Obey Vx_select_enable_clipboard_manager. Catch errors in
9573 x_clipboard_manager_save (Bug#8779).
9574 (Vx_select_enable_clipboard_manager): New variable.
9575 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9577 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9579 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9581 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9583 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9584 in the current matrix if keep_current_p is non-zero.
9586 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9588 * bidi.c (bidi_level_of_next_char): Fix last change.
9590 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9592 Support bidi reordering of text covered by display properties.
9594 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9595 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9596 (bidi_cache_search, bidi_cache_iterator_state)
9597 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9598 (bidi_level_of_next_char, bidi_move_to_visually_next):
9599 Support character positions inside a run of characters covered by a
9601 (bidi_paragraph_init, bidi_resolve_explicit_1)
9602 (bidi_level_of_next_char): Call bidi_fetch_char and
9603 bidi_fetch_char_advance instead of FETCH_CHAR and
9605 (bidi_init_it): Initialize new members.
9606 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9608 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9609 instead of using explicit *_CHAR codes.
9610 (bidi_resolve_explicit, bidi_resolve_weak):
9611 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9612 bidirectional text is supported only in multibyte buffers.
9613 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9614 it to initialize the frame_window_p member of struct bidi_it.
9615 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9616 (bidi_resolve_explicit, bidi_resolve_weak)
9617 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9618 bidi_it->nchars is non-positive.
9619 (bidi_level_of_next_char): Don't try to lookup the cache for the
9620 next/previous character if nothing is cached there yet, or if we
9621 were just reseat()'ed to a new position.
9623 * xdisp.c (set_cursor_from_row): Set start and stop points
9624 according to the row's direction when priming the loop that looks
9625 for the glyph on which to display cursor.
9626 (single_display_spec_intangible_p): Function deleted.
9627 (display_prop_intangible_p): Reimplement to call
9628 handle_display_spec instead of single_display_spec_intangible_p.
9629 Accept 3 additional arguments needed by handle_display_spec.
9630 This fixes incorrect cursor motion across display property with complex
9631 values: lists, `(when COND...)' forms, etc.
9632 (single_display_spec_string_p): Support property values that are
9633 lists with the argument STRING its top-level element.
9634 (display_prop_string_p): Fix the condition for processing a
9635 property that is a list to be consistent with handle_display_spec.
9636 (handle_display_spec): New function, refactored from the
9637 last portion of handle_display_prop.
9638 (compute_display_string_pos): Accept additional argument
9639 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9640 value of a `display' property is a "replacing spec".
9641 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9642 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9643 the display property, but just return a value indicating whether
9644 the display property will replace the characters it covers.
9645 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9646 frame_window_p members of struct bidi_it.
9647 (compute_display_string_pos, compute_display_string_end):
9649 (push_it): Accept second argument POSITION, where pop_it should
9650 jump to continue iteration.
9651 (reseat_1): Initialize bidi_it.disp_pos.
9653 * keyboard.c (adjust_point_for_property): Adjust the call to
9654 display_prop_intangible_p to its new signature.
9656 * dispextern.h (struct bidi_it): New member frame_window_p.
9657 (bidi_init_it): Update prototypes.
9658 (display_prop_intangible_p): Update prototype.
9659 (compute_display_string_pos, compute_display_string_end):
9661 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9664 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9666 Malloc failure behavior now depends on size of allocation.
9667 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9668 * lisp.h: Change signatures accordingly.
9669 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9670 All callers changed. (Bug#8762)
9672 * gnutls.c: Use Emacs's memory allocators.
9673 Without this change, the gnutls library would invoke malloc etc.
9674 directly, which causes problems on non-SYNC_INPUT hosts, and which
9675 runs afoul of improving memory_full behavior. (Bug#8761)
9676 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9677 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9678 xfree instead of the default malloc, realloc, free.
9679 (Fgnutls_boot): No need to check for memory allocation failure,
9680 since xmalloc does that for us.
9682 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9683 * category.c (hash_get_category_set):
9684 * ccl.c (ccl_driver):
9685 * charset.c (Fdefine_charset_internal):
9686 * charset.h (struct charset.hash_index):
9687 * composite.c (get_composition_id, gstring_lookup_cache)
9688 (composition_gstring_put_cache):
9689 * composite.h (struct composition.hash_index):
9690 * dispextern.h (struct image.hash):
9691 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9692 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9693 (hashfn_equal, hashfn_user_defined, make_hash_table)
9694 (maybe_resize_hash_table, hash_lookup, hash_put)
9695 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9696 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9697 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9698 * image.c (make_image, search_image_cache, lookup_image)
9699 (xpm_put_color_table_h):
9700 * lisp.h (struct Lisp_Hash_Table):
9701 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9702 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9703 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9704 * alloc.c (allocate_vectorlike):
9705 Check for overflow in vector size calculations.
9706 * ccl.c (ccl_driver):
9707 Check for overflow when converting EMACS_INT to int.
9708 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9709 need to be updated by these changes.
9710 * fns.c (make_hash_table, maybe_resize_hash_table):
9711 Check for integer overflow with large hash tables.
9712 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9713 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9714 (SXHASH_REDUCE): New macro.
9715 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9716 Use it instead of discarding useful hash info with large hash values.
9717 (sxhash_float): New function.
9718 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9719 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9720 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9721 Rewrite to use FIXNUM_BITS, as this simplifies things.
9722 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9723 Adjust signatures to match updated version of code.
9724 (consing_since_gc): Now EMACS_INT, since a single hash table can
9725 use more than INT_MAX bytes.
9727 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9729 Make it possible to build with GCC-4.6+ -O2 -flto.
9731 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9733 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9735 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9736 Call minibuffer-inactive-mode.
9738 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9740 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9741 Update dependencies.
9743 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9745 * data.c (init_data): Remove code for UTS, this system is not
9748 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9750 Don't force ./temacs to start in terminal mode.
9752 * frame.c (make_initial_frame): Initialize faces in all cases, not
9753 only when CANNOT_DUMP is defined.
9754 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9756 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9758 * dispnew.c (add_window_display_history): Use const for the string
9759 pointer. Remove declaration, not needed.
9761 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9763 Use 'inline', not 'INLINE'.
9764 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9765 * alloc.c, fontset.c (INLINE): Remove.
9766 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9767 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9768 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9769 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9770 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9772 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9774 Make it possible to run ./temacs.
9776 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9777 syms_of_callproc does the same thing. Remove test for
9778 "initialized", do it in the caller.
9779 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9781 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9783 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9784 (read_minibuf): Use get_minibuffer.
9785 (syms_of_minibuf): Use DEFSYM.
9786 (Qmetadata): New var.
9787 * data.c (Qbuffer): Don't make it static.
9788 (syms_of_data): Use DEFSYM.
9790 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9792 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9793 (CCL_CODE_MIN): New macro.
9795 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9797 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9799 * eval.c (Qdebug): Now static.
9800 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9801 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9802 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9804 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9806 * image.c: Various fixes to ImageMagick code comments.
9807 (Fimagemagick_types): Doc fix.
9809 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9811 Minor fixes prompted by GCC 4.6.0 warnings.
9813 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9815 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9816 (x_clipboard_manager_save_all): Move extern decl to ...
9817 * xterm.h: ... here, so that it can be checked for consistency.
9819 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9821 * xselect.c (x_clipboard_manager_save_frame)
9822 (x_clipboard_manager_save_all): New functions.
9823 (Fx_clipboard_manager_save): Lisp function deleted.
9825 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9826 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9828 * xterm.h: Update prototype.
9830 2011-05-28 William Xu <william.xwl@gmail.com>
9832 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9835 2011-05-28 Jim Meyering <meyering@redhat.com>
9837 Avoid a sign-extension bug in crypto_hash_function.
9838 * fns.c (to_uchar): Define.
9839 (crypto_hash_function): Use it to convert some newly-signed
9840 variables to unsigned, to avoid sign-extension bugs. For example,
9841 without this change, (md5 "truc") would evaluate to
9842 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9843 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9844 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9846 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9848 Integer overflow fixes.
9850 * dbusbind.c: Serial number integer overflow fixes.
9851 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9852 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9853 to hold a serial number that is too large for a fixnum.
9854 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9855 Check for serial numbers out of range. Decode any serial number
9856 that was so large that it became a float. (Bug#8722)
9858 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9859 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9860 Use XFASTINT rather than XUINT when numbers are nonnegative.
9861 (xd_append_arg, Fdbus_method_return_internal):
9862 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9863 arguments, check that Lisp number is nonnegative, rather than
9864 silently wrapping negative numbers around. (Bug#8722)
9865 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9868 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9870 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9872 ccl: Add integer overflow checks.
9873 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9874 (IN_INT_RANGE): New macros.
9875 (ccl_driver): Use them to check for integer overflow when
9876 decoding a CCL program. Many of the new checks are whether XINT (x)
9877 fits in int; it doesn't always, on 64-bit hosts. The new version
9878 doesn't catch all possible integer overflows, but it's an
9879 improvement. (Bug#8719)
9881 * alloc.c (make_event_array): Use XINT, not XUINT.
9882 There's no need for unsigned here.
9884 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9885 This follows up to the 2011-05-06 change that substituted uintptr_t
9886 for EMACS_INT. This case wasn't caught back then.
9888 Rework Fformat to avoid integer overflow issues.
9889 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9890 now (part of C89). Include <verify.h>.
9891 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9892 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9893 (Fformat): Avoid the prepass trying to compute sizes; it was only
9894 approximate and thus did not catch overflow reliably. Instead, walk
9895 through the format just once, formatting and computing sizes as we go,
9896 checking for integer overflow at every step, and allocating a larger
9897 buffer as needed. Keep track separately whether the format is
9898 multibyte. Keep only the most-recently calculated precision, rather
9899 than them all. Record whether each argument has been converted to
9900 string. Use EMACS_INT, not int, for byte and char and arg counts.
9901 Support field widths and precisions larger than INT_MAX. Avoid
9902 sprintf's undefined behavior with conversion specifications such as %#d
9903 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9904 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9905 formatting out-of-range floating point numbers with int
9908 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9910 * data.c: Avoid integer truncation in expressions involving floats.
9911 * data.c: Include <intprops.h>.
9912 (arith_driver): When there's an integer overflow in an expression
9913 involving floating point, convert the integers to floating point
9914 so that the resulting value does not suffer from catastrophic
9915 integer truncation. For example, on a 64-bit host (* 4
9916 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9917 Do not rely on undefined behavior after integer overflow.
9919 merge count_size_as_multibyte, parse_str_to_multibyte
9920 * character.c, character.h (count_size_as_multibyte):
9921 Rename from parse_str_to_multibyte; all uses changed.
9922 Check for integer overflow.
9923 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9924 since it's now a duplicate of the other. This is more of
9925 a character than a buffer op, so better that it's in character.c.
9926 * fns.c, print.c: Adjust to above changes.
9928 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9930 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9932 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9934 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9935 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9936 (x_clipboard_manager_save): Now static.
9937 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9939 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9940 (crypto_hash_function): Now static.
9941 Fix pointer signedness problems. Avoid unnecessary initializations.
9943 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9945 * termhooks.h (Vselection_alist): Make it terminal-local.
9947 * terminal.c (create_terminal): Initialize it.
9949 * xselect.c: Support for clipboard managers.
9950 (Vselection_alist): Move to termhooks.h as terminal-local var.
9951 (LOCAL_SELECTION): New macro.
9952 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9953 (symbol_to_x_atom): Remove gratuitous arg.
9954 (x_handle_selection_request, lisp_data_to_selection_data)
9955 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9956 (x_own_selection, x_get_local_selection, x_convert_selection):
9957 New arg, specifying work frame. Use terminal-local Vselection_alist.
9958 (some_frame_on_display): Delete unused function.
9959 (Fx_own_selection_internal, Fx_get_selection_internal)
9960 (Fx_disown_selection_internal, Fx_selection_owner_p)
9961 (Fx_selection_exists_p): New optional frame arg.
9962 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9963 (x_handle_selection_clear): Don't treat other terminals with the
9964 same keyboard specially. Use the terminal-local Vselection_alist.
9965 (x_clear_frame_selections): Use Frun_hook_with_args.
9967 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9969 * xterm.h: Add support for those atoms.
9971 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9973 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9974 (converted_selections, conversion_fail_tag): New global variables.
9975 (x_selection_request_lisp_error): Free the above.
9976 (x_get_local_selection): Remove unnecessary code.
9977 (x_reply_selection_request): Args changed; handle arbitrary array
9978 of converted selections stored in converted_selections.
9979 Separate the XChangeProperty and SelectionNotify steps.
9980 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9981 (x_convert_selection): New function.
9982 (x_handle_selection_event): Simplify.
9983 (x_get_foreign_selection): Don't ignore incoming requests while
9984 waiting for an answer; this will fail when we implement
9985 SAVE_TARGETS, and seems unnecessary anyway.
9986 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9987 (Vx_sent_selection_functions): Doc fix.
9989 2011-05-26 Leo Liu <sdl.web@gmail.com>
9991 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9993 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9995 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9997 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9998 for fringe update if it has periodic bitmap.
9999 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10000 and fringe_bitmap_periodic_p.
10002 * fringe.c (get_fringe_bitmap_data): New function.
10003 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10004 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10005 row. Mark glyph row for fringe update if periodicity changed.
10007 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10008 for fringe update unless it has periodic bitmap.
10010 2011-05-25 Kenichi Handa <handa@m17n.org>
10012 * xdisp.c (get_next_display_element): Set correct it->face_id for
10013 a static composition.
10015 2011-05-24 Leo Liu <sdl.web@gmail.com>
10018 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10020 * fns.c (crypto_hash_function, Fsha1): New function.
10021 (Fmd5): Use crypto_hash_function.
10022 (syms_of_fns): Add Ssha1.
10024 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10026 * gnutls.c: Remove unused macros.
10027 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10028 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10029 Remove macros that are defined and never used.
10030 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10032 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10034 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10035 (Fx_get_selection_internal): Minor cleanup.
10036 (Fx_own_selection_internal): Rename arguments for consistency with
10039 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10041 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10043 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10045 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10047 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10049 * dispnew.c (scrolling_window): Don't exclude the case that the
10050 last enabled row in the desired matrix touches the bottom boundary.
10052 2011-05-21 Glenn Morris <rgm@gnu.org>
10054 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10055 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10056 and add some more files.
10058 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10060 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10061 report_file_error introduced by the change from 2011-05-07.
10063 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10065 * systime.h (Time): Define only if emacs is defined.
10066 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10067 where the include path doesn't have X11/X.h by default. See
10068 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10070 2011-05-20 Kenichi Handa <handa@m17n.org>
10072 * composite.c (find_automatic_composition): Fix previous change.
10074 2011-05-20 Glenn Morris <rgm@gnu.org>
10076 * lisp.mk: New file, split from Makefile.in.
10077 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10078 (shortlisp): Remove.
10079 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10081 2011-05-19 Glenn Morris <rgm@gnu.org>
10083 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10084 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10085 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10086 (lisp): Set the order to that of loadup.el.
10087 (shortlisp): Make it a copy of $lisp.
10088 (SOME_MACHINE_LISP): Remove.
10089 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10090 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10092 2011-05-18 Kenichi Handa <handa@m17n.org>
10094 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10095 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10096 (find_automatic_composition): Mostly rewrite for efficiency.
10098 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10100 * makefile.w32-in: Update dependencies.
10102 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10104 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10105 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10107 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10109 Fix some integer overflow issues, such as string length overflow.
10111 * insdel.c (count_size_as_multibyte): Check for string overflow.
10113 * character.c (lisp_string_width): Check for string overflow.
10114 Use EMACS_INT, not int, for string indexes and lengths; in
10115 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10116 the resulting string length overflows an EMACS_INT; instead,
10117 report a string overflow if no precision given. When checking for
10118 precision exhaustion, use a check that cannot possibly have
10119 integer overflow. (Bug#8675)
10120 * character.h (lisp_string_width): Adjust to new signature.
10122 * alloc.c (string_overflow): New function.
10123 (Fmake_string): Use it. This doesn't change behavior, but saves
10124 a few bytes and will simplify future changes.
10125 * character.c (string_escape_byte8): Likewise.
10126 * lisp.h (string_overflow): New decl.
10128 Fixups, following up to the user-interface timestamp change.
10129 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10130 for UI timestamps, instead of unsigned long.
10131 * msdos.c (mouse_get_pos): Likewise.
10132 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10133 * w32gui.h (Time): Define by including "systime.h" rather than by
10134 declaring it ourselves. (Bug#8664)
10136 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10137 * image.c (clear_image_cache): Likewise.
10139 * term.c (term_mouse_position): Don't assume time_t wraparound.
10141 Be more systematic about user-interface timestamps.
10142 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10143 and sometimes 'EMACS_UINT', to represent these timestamps.
10144 This change causes it to use 'Time' uniformly, as that's what X uses.
10145 This makes the code easier to follow, and makes it easier to catch
10146 integer overflow bugs such as Bug#8664.
10147 * frame.c (Fmouse_position, Fmouse_pixel_position):
10148 Use Time, not unsigned long, for user-interface timestamps.
10149 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10150 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10151 * keyboard.h (last_event_timestamp): Likewise.
10152 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10153 * menu.h (xmenu_show): Likewise.
10154 * term.c (term_mouse_position): Likewise.
10155 * termhooks.h (struct input_event.timestamp): Likewise.
10156 (struct terminal.mouse_position_hook): Likewise.
10157 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10158 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10159 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10160 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10161 what it was before.
10162 * menu.h, termhooks.h: Include "systime.h", for Time.
10164 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10165 Don't assume that the difference between two unsigned long values
10166 can fit into an integer. At this point, we know button_down_time
10167 <= event->timestamp, so the difference must be nonnegative, so
10168 there's no need to cast the result if double-click-time is
10169 nonnegative, as it should be; check that it's nonnegative, just in
10170 case. This bug is triggered when events are more than 2**31 ms
10171 apart (about 25 days). (Bug#8664)
10173 * xselect.c (last_event_timestamp): Remove duplicate decl.
10174 (x_own_selection): Remove needless cast to unsigned long.
10176 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10177 that always fit in int. Use a sentinel instead of a counter, to
10178 avoid a temp and to allay GCC's concerns about possible int overflow.
10179 * frame.h (struct frame): Use int for menu_bar_items_used
10180 instead of EMACS_INT, since it always fits in int.
10182 * menu.c (grow_menu_items): Check for int overflow.
10184 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10186 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10187 Before, the code was not consistent. These values cannot exceed
10188 2**31 - 1 so there's no need to make them unsigned.
10189 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10190 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10191 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10193 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10195 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10196 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10197 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10198 presumably because the widths might not match.
10200 * window.c (size_window): Avoid needless test at loop start.
10202 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10204 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10206 2011-05-12 Drew Adams <drew.adams@oracle.com>
10208 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10210 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10212 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10213 `width' to `bar_area_x' and `bar_area_width', respectively.
10214 (x_scroll_run): Take account of fringe background extension.
10216 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10217 Rename local vars `left' and `width' to `bar_area_x' and
10218 `bar_area_width', respectively.
10219 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10220 background extension.
10222 2011-05-10 Jim Meyering <meyering@redhat.com>
10224 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10226 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10228 * image.c (Finit_image_library): Return t for built-in image types,
10229 like pbm and xbm. (Bug#8640)
10231 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10233 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10235 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10237 * w32console.c (Fset_screen_color): Doc fix.
10238 (Fget_screen_color): New function.
10239 (syms_of_ntterm): Defsubr it.
10241 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10242 unlink the temporary file if Fcall_process didn't create it in the
10244 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10245 child process will be redirected to a file specified with `:file'.
10246 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10247 cue to call_process_cleanup not to close that handle.
10249 2011-05-07 Ben Key <bkey76@gmail.com>
10251 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10252 one of two shell specific rules, either bootstrap-temacs-CMD or
10253 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10254 to the previous implementation of the bootstrap-temacs rule.
10255 The bootstrap-temacs-CMD rule is similar to the previous
10256 implementation of the bootstrap-temacs rule except that it
10257 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10260 These changes, along with some changes to nt/configure.bat,
10261 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10262 earlier fix to add support for --cflags and --ldflags options
10263 that include quotes so that it works whether make uses cmd or
10266 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10268 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10269 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10271 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10272 a string. Handle both cases.
10273 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10274 (Fdbus_register_method): Use Qinvalid_function.
10276 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10278 * makefile.w32-in: Update dependencies.
10279 (LISP_H): Add inttypes.h and stdin.h.
10280 (PROCESS_H): Add unistd.h.
10282 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10284 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10285 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10287 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10289 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10291 * term.c (vfatal): Remove stray call to va_end.
10292 It's not needed and the C Standard doesn't allow it here anyway.
10294 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10295 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10297 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10300 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10302 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10304 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10306 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10308 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10310 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10311 * charset.c (Fdefine_charset_internal): Don't initialize
10312 charset.code_space[15]. The value was garbage, on hosts with
10313 32-bit int (Bug#8600).
10315 * lread.c (read_integer): Be more consistent with string-to-number.
10316 Use string_to_number to do the actual conversion; this avoids
10317 rounding errors and fixes some other screwups. Without this fix,
10318 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10319 (digit_to_number): Move earlier, for benefit of read_integer.
10320 Return -1 if the digit is out of range for the base, -2 if it is
10321 not a digit in any supported base. (Bug#8602)
10323 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10325 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10326 to match comment at start of function. This also removes a
10327 GCC warning about overflow in a 32+64-bit port.
10329 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10331 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10332 Reported by Stefan Monnier in
10333 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10334 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10335 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10337 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10338 (EMACS_UINTPTR): Likewise, with uintptr_t.
10340 * lisp.h: Prefer 64-bit EMACS_INT if available.
10341 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10342 on 32-bit hosts that have 64-bit int, so that they can access
10344 However, temporarily disable this change unless the temporary
10345 symbol WIDE_EMACS_INT is defined.
10347 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10349 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10350 This removes an assumption that EMACS_INT and long are the same
10351 width as pointers. The assumption is true for Emacs porting targets
10352 now, but we want to make other targets possible.
10353 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10354 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10355 In the rest of the code, change types of integers that hold casted
10356 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10357 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10358 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10359 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10360 No need to cast type when ORing.
10361 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10362 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10363 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10364 assume EMACS_INT is the same width as char *.
10365 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10366 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10367 Remove no-longer-needed casts.
10368 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10369 (xg_tool_bar_help_callback, xg_make_tool_item):
10370 Use EMACS_INTPTR to hold an integer
10371 that will be cast to void *; this can avoid a GCC warning
10372 if EMACS_INT is not the same width as void *.
10373 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10374 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10375 (current_message_1, set_message_1):
10376 Use a local to convert to proper width without a cast.
10377 * xmenu.c (dialog_selection_callback): Likewise.
10379 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10380 Also, don't assume VALBITS / RAND_BITS is less than 5,
10381 and don't rely on undefined behavior when shifting a 1 left into
10383 * lisp.h (get_random): Change signature to match.
10385 * lread.c (hash_string): Use size_t, not int, for hash computation.
10386 Normally we prefer signed values; but hashing is special, because
10387 it's better to use unsigned division on hash table sizes so that
10388 the remainder is nonnegative. Also, size_t is the natural width
10389 for hashing into memory. The previous code used 'int', which doesn't
10390 retain enough info to hash well into very large tables.
10391 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10393 * dbusbind.c: Don't possibly lose pointer info when converting.
10394 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10395 Use XPNTR rather than XHASH, so that the high-order bits of
10396 the pointer aren't lost when converting through void *.
10398 * eval.c (Fautoload): Don't double-shift a pointer.
10400 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10402 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10404 * gnutls.c (DEF_GNUTLS_FN):
10405 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10407 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10409 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10412 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10414 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10415 New version that can reserve upto 2GB of heap space.
10417 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10419 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10421 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10423 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10424 `gnutls_certificate_set_x509_key_file'.
10426 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10428 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10429 Update dependencies.
10431 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10433 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10434 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10435 Remove unused parameter `fildes'.
10436 * process.c (read_process_output, send_process): Don't pass it.
10438 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10440 Fix previous change: the library cache is defined in w32.c.
10441 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10442 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10444 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10446 Implement dynamic loading of GnuTLS on Windows.
10448 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10449 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10450 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10453 * gnutls.c (Qgnutls_dll): Define.
10454 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10455 (gnutls_*): Declare function pointers.
10456 (init_gnutls_functions): New function to initialize function pointers.
10457 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10458 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10459 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10460 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10461 (emacs_gnutls_write, emacs_gnutls_read)
10462 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10463 (Fgnutls_available_p): New function.
10464 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10465 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10466 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10468 * image.c: Include w32.h.
10469 (Vimage_type_cache): Delete.
10470 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10471 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10472 (w32_delayed_load): Move to w32.c.
10474 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10476 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10477 (w32_delayed_load): Move from image.c. When loading a library, record
10478 its filename in the :loaded-from property of the library id.
10479 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10480 Initialize and staticpro them.
10481 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10483 * process.c: Include lisp.h before w32.h, not after.
10484 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10485 instead of gnutls_record_check_pending.
10487 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10489 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10491 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10492 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10495 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10497 * xterm.c (x_set_frame_alpha): Do not set property on anything
10498 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10500 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10502 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10504 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10506 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10507 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10508 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10509 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10510 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10511 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10512 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10513 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10514 (Qgnutls_bootprop_callbacks_verify): Make static.
10516 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10518 * callproc.c: Indentation fixup.
10520 * sysdep.c (wait_for_termination_1): Make static.
10521 (wait_for_termination, interruptible_wait_for_termination):
10522 Move after wait_for_termination_1.
10524 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10526 * sysdep.c (interruptible_wait_for_termination): New function
10527 which is like wait_for_termination, but allows keyboard
10530 * callproc.c (Fcall_process): Add (:file "file") as an option for
10532 (Fcall_process_region): Ditto.
10534 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10536 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10537 rather than `XVECTOR (FOO)->size'.
10539 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10540 inttypes.h, as a gnulib replacement is used if it not available in
10543 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10545 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10546 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10547 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10549 * coding.c (coding_alloc_by_realloc): Error out if destination
10550 will grow beyond MOST_POSITIVE_FIXNUM.
10551 (decode_coding_emacs_mule): Abort if there isn't enough place in
10552 charbuf for the composition carryover bytes. Reserve an extra
10553 space for up to 2 characters produced in a loop.
10554 (decode_coding_iso_2022): Abort if there isn't enough place in
10555 charbuf for the composition carryover bytes.
10557 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10559 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10560 aborting when %lld or %lll format is passed.
10561 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10562 %llo or %llx format is passed. (Bug#8545)
10564 * window.c (window_scroll_line_based): Use a marker instead of
10565 simple variables to record original value of point. (Bug#7952)
10567 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10568 produced by %s or %c overflows available buffer space. (Bug#8545)
10570 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10572 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10573 (SIZE_MAX): Move defn after all includes, as they might #define it.
10575 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10577 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10579 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10581 * keyboard.c (Qdelayed_warnings_hook): Define.
10582 (command_loop_1): Run `delayed-warnings-hook'
10583 if Vdelayed_warnings_list is non-nil.
10584 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10585 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10587 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10589 * doprnt.c (doprnt): Don't return value smaller than the buffer
10590 size if the message was truncated. (Bug#8545).
10592 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10594 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10595 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10597 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10599 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10601 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10603 * makefile.w32-in: Update dependencies.
10605 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10607 Improve `doprnt' and its usage. (Bug#8545)
10608 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10609 `format_end'. Remove support for %l as a conversion specifier.
10610 Don't use xrealloc. Improve diagnostics when the %l size modifier
10611 is used. Update the commentary.
10613 * eval.c (verror): Simplify calculation of size_t.
10615 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10618 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10620 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10623 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10625 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10626 This makes this file independent of the recent pseudovector change.
10628 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10630 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10632 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10633 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10634 Remove unused local.
10635 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10637 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10638 GCC 4.6.0 optimizes based on type-based alias analysis.
10639 For example, if b is of type struct buffer * and v of type struct
10640 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10641 != &v->size, and therefore "v->size = 1; b->size = 2; return
10642 v->size;" must therefore return 1. This assumption is incorrect
10643 for Emacs, since it type-puns struct Lisp_Vector * with many other
10644 types. To fix this problem, this patch adds a new type struct
10645 vectorlike_header that documents the constraints on layout of vectors
10646 and pseudovectors, and helps optimizing compilers not get fooled
10647 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10648 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10649 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10651 (XSETPVECTYPE): Rewrite in terms of new macro.
10652 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10653 This is a bit clearer, and further avoids the possibility of
10654 undesirable aliasing.
10655 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10656 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10657 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10658 since Lisp_Subr is a special case (no "next" field).
10659 (ASIZE): Now uses header.size rather than size.
10660 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10661 to avoid the hassle of writing XVECTOR (foo)->header.size.
10662 (struct vectorlike_header): New type.
10663 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10664 object, to help avoid aliasing.
10665 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10666 (SUBRP): Likewise, since Lisp_Subr is a special case.
10667 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10668 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10669 (struct Lisp_Hash_Table): Combine first two members into a single
10670 struct vectorlike_header member. All uses of "size" and "next" members
10671 changed to be "header.size" and "header.next".
10672 * buffer.h (struct buffer): Likewise.
10673 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10674 * frame.h (struct frame): Likewise.
10675 * process.h (struct Lisp_Process): Likewise.
10676 * termhooks.h (struct terminal): Likewise.
10677 * window.c (struct save_window_data, struct saved_window): Likewise.
10678 * window.h (struct window): Likewise.
10679 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10680 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10681 * buffer.c (init_buffer_once): Likewise.
10682 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10684 * process.c (Fformat_network_address): Use local var for size,
10687 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10689 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10690 * data.c (atof): Remove decl; no longer used or needed.
10691 (digit_to_number): Move to lread.c.
10692 (Fstring_to_number): Use new string_to_number function, to be
10693 consistent with how the Lisp reader treats infinities and NaNs.
10694 Do not assume that floating-point numbers represent EMACS_INT
10695 without losing information; this is not true on most 64-bit hosts.
10696 Avoid double-rounding errors, by insisting on integers when
10697 parsing non-base-10 numbers, as the documentation specifies.
10698 * lisp.h (string_to_number): New decl, replacing ...
10699 (isfloat_string): Remove.
10700 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10701 (read1): Do not accept +. and -. as integers; this
10702 appears to have been a coding error. Similarly, do not accept
10703 strings like +-1e0 as floating point numbers. Do not report
10704 overflow for integer overflows unless the base is not 10 which
10705 means we have no simple and reliable way to continue.
10706 Break out the floating-point parsing into a new
10707 function string_to_number, so that Fstring_to_number parses
10708 floating point numbers consistently with the Lisp reader.
10709 (digit_to_number): Move here from data.c. Make it static inline.
10710 (E_CHAR, EXP_INT): Remove, replacing with ...
10711 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10712 (string_to_number): New function, replacing isfloat_string.
10713 This function checks for valid syntax and produces the resulting
10714 Lisp float number too. Rework it so that string-to-number
10715 no longer mishandles examples like "1.0e+". Use strtoumax,
10716 so that overflow for non-base-10 numbers is reported only when
10717 there's no portable and simple way to convert to floating point.
10719 * textprop.c (set_text_properties_1): Rewrite for clarity,
10720 and to avoid GCC warning about integer overflow.
10722 * intervals.h (struct interval): Use EMACS_INT for members
10723 where EMACS_UINT might cause problems. See
10724 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10725 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10726 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10728 (offset_intervals): Tell GCC not to worry about length overflow
10729 when negating a negative length.
10731 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10732 (overrun_check_free): Likewise.
10734 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10735 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10738 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10739 (gnutls_make_error): Rename local to avoid shadowing.
10740 (gnutls_emacs_global_deinit): ifdef out; not used.
10741 (Fgnutls_boot): Use const for pointer to readonly storage.
10742 Comment out unused local. Fix pointer signedness problems.
10744 * lread.c (openp): Don't stuff size_t into an 'int'.
10745 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10746 about possible signed overflow.
10748 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10749 (GDK_KEY_g): Don't define if already defined.
10750 (xg_prepare_tooltip): Avoid pointer signedness problem.
10751 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10753 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10754 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10756 * xfns.c (Fx_window_property): Simplify a bit,
10757 to make a bit faster and to avoid GCC 4.6.0 warning.
10758 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10760 * fns.c (internal_equal): Don't assume size_t fits in int.
10762 * alloc.c (compact_small_strings): Tighten assertion a little.
10764 Replace pEd with more-general pI, and fix some printf arg casts.
10765 * lisp.h (pI): New macro, generalizing old pEd macro to other
10766 conversion specifiers. For example, use "...%"pI"d..." rather
10767 than "...%"pEd"...".
10768 (pEd): Remove. All uses replaced with similar uses of pI.
10769 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10770 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10771 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10772 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10773 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10774 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10775 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10777 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10778 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10779 * print.c (safe_debug_print, print_object): Likewise.
10780 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10782 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10783 avoiding the 0 flag, which is not portable.
10784 * process.c (Fmake_network_process): Use pI to avoid cast.
10785 * region-cache.c (pp_cache): Likewise.
10786 * xdisp.c (decode_mode_spec): Likewise.
10787 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10788 behavior on 64-bit hosts with printf arg.
10789 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10790 (x_stop_queuing_selection_requests): Likewise.
10791 (x_get_window_property): Don't truncate byte count to an 'int'
10794 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10795 here, since it parses constructs like leading '-' and spaces,
10796 which are not wanted; and it overflows with large numbers.
10797 Instead, simply match F[0-9]+, which is what is wanted anyway.
10799 * alloc.c: Remove unportable assumptions about struct layout.
10800 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10801 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10802 (allocate_vectorlike, make_pure_vector): Use the new macros,
10803 plus offsetof, to remove unportable assumptions about struct layout.
10804 These assumptions hold on all porting targets that I know of, but
10805 they are not guaranteed, they're easy to remove, and removing them
10806 makes further changes easier.
10808 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10809 This doesn't fix a bug but makes the code clearer.
10810 (string_overrun_cookie): Now const. Use initializers that
10811 don't formally overflow signed char, to avoid warnings.
10812 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10813 can cause Emacs to crash when string overrun checking is enabled.
10814 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10815 multiple of sizeof (EMACS_INT); it need not be, if
10816 alignof(EMACS_INT) < sizeof (EMACS_INT).
10817 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10819 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10821 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10823 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10825 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10826 supposed to be handshaking. (Bug#8556)
10827 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10829 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10831 * lisp.h (Qdebug): List symbol.
10832 * eval.c (Qdebug): Restore global linkage.
10833 * keyboard.c (debug-on-event): New variable.
10834 (handle_user_signal): Break into debugger when debug-on-event
10835 matches the current signal symbol.
10837 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10839 * alloc.c (check_sblock, check_string_bytes)
10840 (check_string_free_list): Convert to standard C.
10842 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10844 * w32.c (emacs_gnutls_push): Fix typo.
10846 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10848 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10849 "cast to pointer from integer of different size".
10851 Improve doprnt and its use in verror. (Bug#8545)
10852 * doprnt.c (doprnt): Document the set of format control sequences
10853 supported by the function. Use SAFE_ALLOCA instead of always
10856 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10857 is one byte too soon. Don't use xrealloc; instead xfree and
10860 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10862 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10865 * gnutls.c: Renamed global_initialized to
10866 gnutls_global_initialized. Added internals for the
10867 :verify-hostname-error, :verify-error, and :verify-flags
10868 parameters of `gnutls-boot' and documented those parameters in the
10869 docstring. Start callback support.
10870 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10871 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10872 on error. Return error code.
10873 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10874 (emacs_gnutls_read): Likewise.
10875 (Fgnutls_boot): Return handshake error code.
10876 (emacs_gnutls_handle_error): New function.
10877 (wsaerror_to_errno): Likewise.
10879 * w32.h (emacs_gnutls_pull): Add prototype.
10880 (emacs_gnutls_push): Likewise.
10882 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10883 (emacs_gnutls_push): Likewise.
10885 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10887 * process.c (wait_reading_process_output): Check if GnuTLS
10888 buffered some data internally if no FDs are set for TLS
10891 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10892 (LIBS): Link to USER_LIBS.
10893 ($(BLD)/gnutls.$(0)): New target.
10895 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10897 * xdisp.c (handle_single_display_spec): Rename the
10898 display_replaced_before_p argument into display_replaced_p, to
10899 make it consistent with the commentary. Fix typos in the
10902 * textprop.c (syms_of_textprop): Remove dead code.
10903 (copy_text_properties): Delete obsolete commentary about an
10904 interface that was deleted long ago. Fix typos in the description
10907 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10908 to changes in oldXMenu/XMenu.h from 2011-04-16.
10909 <menu_help_message, prev_menu_help_message>: Constify.
10910 (IT_menu_make_room): menu->help_text is now `const char **';
10913 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10914 to changes in oldXMenu/XMenu.h from 2011-04-16.
10915 (struct XMenu): Declare `help_text' `const char **'.
10917 * xfaces.c <Qunspecified>: Make extern again.
10919 * syntax.c: Include sys/types.h before including regex.h, as
10922 * doc.c (get_doc_string): Improve the format passed to `error'.
10924 * doprnt.c (doprnt): Improve commentary.
10926 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10928 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10931 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10932 changes in globals.h immediately force recompilation.
10933 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10934 $(CURDIR)/s/ms-w32.h.
10935 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10937 * character.c (Fchar_direction): Function deleted.
10938 (syms_of_character): Don't defsubr it.
10939 <char-direction-table>: Deleted.
10941 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10943 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10944 * doprnt.c: Include limits.h.
10945 (SIZE_MAX): New macro.
10946 (doprnt): Return a size_t value. 2nd arg is now size_t.
10947 Many local variables are now size_t instead of int or unsigned.
10948 Improve overflow protection. Support `l' modifier for integer
10949 conversions. Support %l conversion. Don't assume an EMACS_INT
10950 argument for integer conversions and for %c.
10952 * lisp.h (doprnt): Restore prototype.
10954 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10955 $(SRC)/character.h.
10957 * Makefile.in (base_obj): Add back doprnt.o.
10959 * deps.mk (doprnt.o): Add back prerequisites.
10960 (callint.o): Depend on character.h.
10962 * eval.c (internal_lisp_condition_case): Include the handler
10963 representation in the error message.
10964 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10965 when breaking from the loop.
10967 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10969 * callint.c (Fcall_interactively): When displaying error message
10970 about invalid control letter, pass the character's codepoint, not
10971 a pointer to its multibyte form. Improve display of the character
10972 in octal and display also its hex code.
10974 * character.c (char_string): Use %x to display the (unsigned)
10975 codepoint of an invalid character, to avoid displaying a bogus
10978 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10979 `error', not SYMBOL_NAME itself.
10981 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10982 character arguments to `error'.
10984 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10985 to `error' in error message about FINAL_CHAR argument. Make sure
10986 FINAL_CHAR is a character, and use %c when it is passed as
10987 argument to `error'.
10989 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10991 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10993 * w32.c: Include <time.h>.
10994 (sys_localtime): New function.
10996 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10998 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11000 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11002 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11004 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11005 zombies (Bug#8467).
11007 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11009 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11010 gl_state.e_property when gl_state.object is Qt.
11012 * insdel.c (make_gap_larger): Remove limitation of buffer size
11015 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11017 * xdisp.c (lookup_glyphless_char_display)
11018 (produce_glyphless_glyph): Handle cons cell entry in
11019 glyphless-char-display.
11020 (Vglyphless_char_display): Document it.
11022 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11023 glyphless-char-display.
11025 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11027 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11029 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11031 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11032 definition for no-X builds.
11034 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11036 Static checks with GCC 4.6.0 and non-default toolkits.
11038 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11040 * process.c (keyboard_bit_set): Define only if SIGIO.
11041 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11042 (send_process): Repair possible setjmp clobbering.
11044 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11046 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11048 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11050 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11051 Define only if needed.
11053 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11054 by pacifying GCC about it. Maybe it's time to retire it?
11055 * xfaces.c (USG, __TIMEVAL__): Likewise.
11057 * dispextern.h (struct redisplay_interface): Rename param
11058 to avoid shadowing.
11059 * termhooks.h (struct terminal): Likewise.
11060 * xterm.c (xembed_send_message): Likewise.
11062 * insdel.c (make_gap_smaller): Define only if
11063 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11065 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11068 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11069 so that we aren't warned about unused symbols.
11071 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11073 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11075 * xfns.c (x_real_positions): Mark locals as initialized.
11077 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11079 * xterm.c: Fix problems found by static analysis with other toolkits.
11080 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11081 (x_dispatch_event): Declare static if USE_GTK, and
11082 define if USE_GTK || USE_X_TOOLKIT.
11083 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11084 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11085 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11086 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11088 * xmenu.c (menu_help_callback): Pointer type fixes.
11089 Use const pointers when pointing at readonly data. Avoid pointer
11090 signedness clashes.
11091 (FALSE): Remove unused macro.
11092 (update_frame_menubar): Remove unused decl.
11094 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11096 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11097 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11098 (single_menu_item): Rename local to avoid shadowing.
11100 * keyboard.c (make_lispy_event): Remove unused local var.
11102 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11103 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11105 * bitmaps: Change bitmaps from unsigned char back to the X11
11106 compatible char. Avoid the old compiler warnings about
11107 out-of-range initializers by using, for example, '\xab' rather
11110 * xgselect.c (xgselect_initialize): Check vs interface
11111 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11113 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11115 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11116 to read-only memory.
11118 * fns.c (vector): Remove; this old hack is no longer needed.
11120 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11122 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11124 * xrdb.c (x_load_resources): Omit unused local.
11126 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11127 (x_window): Rename locals to avoid shadowing.
11128 (USG): Use the kludged USG macro, to pacify gcc.
11130 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11131 (x_term_init): Remove local to avoid shadowing.
11133 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11135 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11136 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11138 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11140 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11142 Fix regex.c, syntax.c and friends for buffers > 2GB.
11143 * syntax.h (struct gl_state_s): Declare character position members
11146 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11148 * textprop.c (verify_interval_modification, interval_of):
11149 Declare arguments EMACS_INT.
11151 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11154 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11156 * indent.c (Fvertical_motion): Local variable it_start is now
11159 * regex.c (re_match, re_match_2, re_match_2_internal)
11160 (bcmp_translate, regcomp, regexec, print_double_string)
11161 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11162 (re_compile_pattern, re_exec): Declare arguments and local
11163 variables `size_t' and `ssize_t' and return values `regoff_t', as
11165 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11166 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11167 <compile_stack_type>: `size' and `avail' are now `size_t'.
11169 * regex.h <regoff_t>: Use ssize_t, not int.
11170 (re_search, re_search_2, re_match, re_match_2): Arguments that
11171 specify buffer/string position and length are now ssize_t and
11172 size_t. Return type is regoff_t.
11174 2011-04-16 Ben Key <bkey76@gmail.com>
11176 * nsfont.m: Fixed bugs in ns_get_family and
11177 ns_descriptor_to_entity that were caused by using free to
11178 deallocate memory blocks that were allocated by xmalloc (via
11179 xstrdup). This caused Emacs to crash when compiled with
11180 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11181 --enable-checking=xmallocoverrun). xfree is now used to
11182 deallocate these memory blocks.
11184 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11186 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11188 emacs_write: Accept and return EMACS_INT for sizes.
11189 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11191 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11192 Accept and return EMACS_INT.
11193 (emacs_gnutls_write): Return the number of bytes written on
11195 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11196 (emacs_read, emacs_write): Remove check for negative size, as the
11197 Emacs source code has been audited now.
11198 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11199 (emacs_read, emacs_write): Use it.
11200 * process.c (send_process): Adjust to the new signatures of
11201 emacs_write and emacs_gnutls_write. Do not attempt to store
11202 a byte offset into an 'int'; it might overflow.
11203 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11205 * sound.c: Don't assume sizes fit in 'int'.
11206 (struct sound_device.period_size, alsa_period_size):
11207 Return EMACS_INT, not int.
11208 (struct sound_device.write, vox_write, alsa_write):
11209 Accept EMACS_INT, not int.
11210 (wav_play, au_play): Use EMACS_INT to store sizes and to
11211 record read return values.
11213 2011-04-15 Ben Key <bkey76@gmail.com>
11215 * keyboard.c (Qundefined): Don't declare static since it is used
11217 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11218 static since they are used in nsfont.m.
11220 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11222 * process.c (Qprocessp): Don't declare static.
11223 * lisp.h (Qprocessp): Declare again.
11225 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11227 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11229 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11231 Improve C-level modularity by making more things 'static'.
11233 Don't publish debugger-only interfaces to other modules.
11234 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11235 (verify_bytepos, count_markers): Move decls to the only modules
11237 * region-cache.h (pp_cache): Likewise.
11238 * window.h (check_all_windows): Likewise.
11239 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11241 * sysdep.c (croak): Now static, if
11242 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11243 * syssignal.h (croak): Declare only if not static.
11245 * alloc.c (refill_memory_reserve): Now static if
11246 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11247 * lisp.h (refill_memory_reserve): Declare only if not static.
11249 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11250 Define only if USE_LUCID.
11252 * xrdb.c (x_customization_string, x_rm_string): Now static.
11254 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11255 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11257 * xdisp.c (draw_row_with_mouse_face): Now static.
11258 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11260 * window.h (check_all_windows): Mark externally visible.
11262 * window.c (window_deletion_count): Now static.
11264 * undo.c: Make symbols static if they're not exported.
11265 (last_undo_buffer, last_boundary_position, pending_boundary):
11268 * textprop.c (interval_insert_behind_hooks): Now static.
11269 (interval_insert_in_front_hooks): Likewise.
11271 * term.c: Make symbols static if they're not exported.
11272 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11273 (max_frame_lines, tty_set_terminal_modes):
11274 (tty_reset_terminal_modes, tty_turn_off_highlight):
11275 (get_tty_terminal): Now static.
11276 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11277 * termhooks.h (term_mouse_moveto): Do not declare if
11278 HAVE_WINDOW_SYSTEM.
11279 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11280 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11282 * sysdep.c: Make symbols static if they're not exported.
11283 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11285 (sigprocmask_set, full_mask): Remove; unused.
11286 (wait_debugging): Mark as visible.
11287 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11288 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11290 * syntax.c (syntax_temp): Define only if !__GNUC__.
11292 * sound.c (current_sound_device, current_sound): Now static.
11294 * search.c (searchbufs, searchbuf_head): Now static.
11296 * scroll.c (scroll_cost): Remove; unused.
11297 * dispextern.h (scroll_cost): Remove decl.
11299 * region-cache.h (pp_cache): Mark as externally visible.
11301 * process.c: Make symbols static if they're not exported.
11302 (process_tick, update_tick, create_process, chan_process):
11303 (Vprocess_alist, proc_buffered_char, datagram_access):
11304 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11305 (deactivate_process): Mark defn as static, as well as decl.
11306 * lisp.h (create_process): Remove decl.
11307 * process.h (chan_process, Vprocess_alist): Remove decls.
11309 * print.c: Make symbols static if they're not exported.
11310 (print_depth, new_backquote_output, being_printed, print_buffer):
11311 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11312 (print_interval, print_number_index, initial_stderr_stream):
11314 * lisp.h (Fprinc): Remove decl.
11315 (debug_output_compilation_hack): Mark as externally visible.
11317 * sysdep.c (croak): Move decl from here to syssignal.h.
11318 * syssignal.h (croak): Put it here, so the API can be checked when
11319 'croak' is called from dissociate_if_controlling_tty.
11321 * minibuf.c: Make symbols static if they're not exported.
11322 (minibuf_save_list, choose_minibuf_frame): Now static.
11323 * lisp.h (choose_minibuf_frame): Remove decl.
11325 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11327 * lread.c: Make symbols static if they're not exported.
11328 (read_objects, initial_obarray, oblookup_last_bucket_number):
11330 (make_symbol): Remove; unused.
11331 * lisp.h (initial_obarray, make_symbol): Remove decls.
11333 * keyboard.c: Make symbols static if they're not exported.
11334 (single_kboard, recent_keys_index, total_keys, recent_keys):
11335 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11336 (this_single_command_key_start, echoing, last_auto_save):
11337 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11338 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11339 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11340 (Vlispy_mouse_stem, double_click_count):
11342 (force_auto_save_soon): Define only if SIGDANGER.
11343 (ignore_mouse_drag_p): Now static if
11344 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11345 (print_help): Remove; unused.
11346 (stop_character, last_timer_event): Mark as externally visible.
11347 * keyboard.h (ignore_mouse_drag_p): Declare only if
11348 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11349 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11350 * lisp.h (echoing): Remove decl.
11351 (force_auto_save_soon): Declare only if SIGDANGER.
11352 * xdisp.c (redisplay_window): Simplify code, to make it more
11353 obvious that ignore_mouse_drag_p is not accessed if !defined
11354 USE_GTK && !defined HAVE_NS.
11356 * intervals.c: Make symbols static if they're not exported.
11357 (merge_properties_sticky, merge_interval_right, delete_interval):
11359 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11361 * insdel.c: Make symbols static if they're not exported.
11362 However, leave prepare_to_modify_buffer alone. It's never
11363 called from outside this function, but that appears to be a bug.
11364 (combine_after_change_list, combine_after_change_buffer):
11365 (adjust_after_replace, signal_before_change): Now static.
11366 (adjust_after_replace_noundo): Remove; unused.
11367 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11368 (signal_before_change): Remove decls.
11370 * indent.c (val_compute_motion, val_vmotion): Now static.
11372 * image.c: Make symbols static if they're not exported.
11373 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11375 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11376 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11378 * fringe.c (standard_bitmaps): Now static.
11379 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11381 * frame.c: Make symbols static if they're not exported.
11382 (x_report_frame_params, make_terminal_frame): Now static.
11383 (get_frame_param): Now static, unless HAVE_NS.
11384 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11385 (x_get_resource_string): Remove; not used.
11386 * frame.h (make_terminal_frame, x_report_frame_params):
11387 (x_get_resource_string); Remove decls.
11388 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11389 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11391 * font.c, fontset.c: Make symbols static if they're not exported.
11392 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11393 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11394 * font.c (font_close_object): Now static.
11395 * font.h (font_close_object): Remove.
11396 * fontset.c (FONTSET_OBJLIST): Remove.
11397 (free_realized_fontset) #if-0 the body, which does nothing.
11398 (face_suitable_for_char_p): #if-0, as it's never called.
11399 * fontset.h (face_suitable_for_char_p): Remove decl.
11400 * xfaces.c (face_at_string_position):
11401 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11402 since 0 is always ASCII.
11404 * fns.c (weak_hash_tables): Now static.
11406 * fileio.c: Make symbols static if they're not exported.
11407 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11408 (Vwrite_region_annotation_buffers): Now static.
11410 * eval.c: Make symbols static if they're not exported.
11411 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11412 * lisp.h (backtrace_list): Remove decl.
11414 * emacs.c: Make symbols static if they're not exported.
11415 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11416 (fatal_error_code, fatal_error_signal_hook, standard_args):
11418 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11419 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11420 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11421 * lisp.h (fatal_error_signal_hook): Remove decl.
11422 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11424 * editfns.c: Move a (normally-unused) function to its only use.
11425 * editfns.c, lisp.h (get_operating_system_release): Remove.
11426 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11427 worth the hassle of breaking this out.
11429 * xterm.c: Make symbols static if they're not exported.
11430 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11431 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11432 (x_destroy_window, x_delete_display):
11434 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11435 (x_mouse_leave): Remove; unused.
11436 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11437 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11438 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11440 (x_mouse_leave): Declare only if WINDOWSNT.
11441 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11442 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11445 * ftxfont.c: Make symbols static if they're not exported.
11446 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11448 * font.h (ftxfont_driver): Likewise.
11450 * xfns.c: Make symbols static if they're not exported.
11451 (x_last_font_name, x_display_info_for_name):
11452 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11453 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11454 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11455 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11456 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11457 (last_show_tip_args): Now static.
11458 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11459 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11460 (x_screen_planes): Remove; unused.
11461 * dispextern.h (x_screen_planes): Remove decl.
11463 * dispnew.c: Make symbols static if they're not exported.
11464 * dispextern.h (redraw_garbaged_frames, scrolling):
11465 (increment_row_positions): Remove.
11466 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11467 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11469 (redraw_garbaged_frames): Remove; unused.
11471 * xfaces.c: Make symbols static if they're not exported.
11472 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11474 * xterm.h (defined_color): Remove decls.
11475 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11476 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11477 (menu_face_changed_default, defined_color, free_realized_face):
11478 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11479 (ascii_face_of_lisp_face): Remove; unused.
11481 * xdisp.c: Make symbols static if they're not exported.
11482 * dispextern.h (scratch_glyph_row, window_box_edges):
11483 (glyph_to_pixel_coords, set_cursor_from_row):
11484 (get_next_display_element, set_iterator_to_next):
11485 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11486 (show_mouse_face): Remove decls
11487 * frame.h (message_buf_print): Likewise.
11488 * lisp.h (pop_message, set_message, check_point_in_composition):
11490 * xterm.h (set_vertical_scroll_bar): Likewise.
11491 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11492 (message_buf_print, scratch_glyph_row, displayed_buffer):
11493 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11494 (get_next_display_element, show_mouse_face, window_box_edges):
11495 (frame_to_window_pixel_xy, check_point_in_composition):
11496 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11497 (glyph_to_pixel_coords): Remove; unused.
11499 * dired.c (file_name_completion): Now static.
11501 * dbusbind.c (xd_in_read_queued_messages): Now static.
11503 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11504 * data.c (circular_list_error): Remove.
11506 * commands.h (last_point_position, last_point_position_buffer):
11507 (last_point_position_window): Remove decls.
11508 * keyboard.c: Make these variables static.
11510 * coding.h (coding, code_convert_region, encode_coding_gap):
11512 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11513 (iso_code_class, detect_coding, code_convert_region): Now static.
11514 (encode_coding_gap): Remove; unused.
11516 * chartab.c (chartab_chars, chartab_bits): Now static.
11518 * charset.h (charset_iso_8859_1): Remove decl.
11519 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11522 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11523 * ccl.c (Vccl_program_table): Now static.
11524 (check_ccl_update): Remove; unused.
11526 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11527 * category.h: ... from here.
11528 * category.c (check_category_table, set_category_set): Now static.
11530 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11531 * lisp.h: Remove these decls.
11533 * buffer.c (buffer_count): Remove unused var.
11535 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11536 so that it's not optimized away.
11537 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11538 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11539 exported only to the debugger.
11541 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11542 * atimer.h (run_all_atimers): Remove; not exported.
11544 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11545 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11546 was inaccessible from Lisp.
11547 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11548 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11550 alloc.c: Import and export fewer symbols, and remove unused items.
11551 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11553 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11554 it's not optimized away by whole-program optimization.
11555 (message_enable_multibyte, free_misc): Remove.
11556 (catchlist, handlerlist, mark_backtrace):
11557 Declare only if BYTE_MARK_STACK.
11558 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11559 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11560 (message_enable_multibyte): Remove decl.
11561 (free_misc, interval_free_list, float_block, float_block_index):
11562 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11563 (cons_free_list, last_marked_index):
11565 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11566 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11567 (mark_backtrace): Define only if BYTE_MARK_STACK.
11568 * xdisp.c (message_enable_multibyte): Now static.
11570 Declare Lisp_Object Q* variables to be 'static' if not exported.
11571 This makes it easier for human readers (and static analyzers)
11572 to see whether these variables are used from other modules.
11573 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11574 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11575 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11576 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11577 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11578 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11579 * xmenu.c, xselect.c:
11580 Declare Q* vars static if they are not used in other modules.
11581 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11582 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11583 Remove decls of unexported vars.
11584 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11586 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11588 Make Emacs functions such as Fatom 'static' by default.
11589 This makes it easier for human readers (and static analyzers)
11590 to see whether these functions can be called from other modules.
11591 DEFUN now defines a static function. To make the function external
11592 so that it can be used in other C modules, use the new macro DEFUE.
11593 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11594 (Finit_image_library):
11595 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11596 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11597 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11598 Remove decls, since these functions are now static.
11599 (Funintern, Fget_internal_run_time): New decls, since these functions
11600 were already external.
11602 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11603 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11604 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11605 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11606 * keyboard.c, keymap.c, lread.c:
11607 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11608 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11609 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11610 Mark functions with DEFUE instead of DEFUN,
11611 if they are used in other modules.
11612 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11613 decls for now-static functions.
11614 * buffer.h (Fdelete_overlay): Remove decl.
11615 * callproc.c (Fgetenv_internal): Mark as internal.
11616 * composite.c (Fremove_list_of_text_properties): Remove decl.
11617 (Fcomposition_get_gstring): New forward static decl.
11618 * composite.h (Fcomposite_get_gstring): Remove decl.
11619 * dired.c (Ffile_attributes): New forward static decl.
11620 * doc.c (Fdocumntation_property): New forward static decl.
11621 * eval.c (Ffetch_bytecode): New forward static decl.
11622 (Funintern): Remove extern decl; now in .h file where it belongs.
11623 * fileio.c (Fmake_symbolic_link): New forward static decl.
11624 * image.c (Finit_image_library): New forward static decl.
11625 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11626 * intervals.h (Fprevious_property_change):
11627 (Fremove_list_of_text_properties): Remove decls.
11628 * keyboard.c (Fthis_command_keys): Remove decl.
11629 (Fcommand_execute): New forward static decl.
11630 * keymap.c (Flookup_key): New forward static decl.
11631 (Fcopy_keymap): Now static.
11632 * keymap.h (Flookup_key): Remove decl.
11633 * process.c (Fget_process): New forward static decl.
11634 (Fprocess_datagram_address): Mark as internal.
11635 * syntax.c (Fsyntax_table_p): New forward static decl.
11636 (skip_chars): Remove duplicate decl.
11637 * textprop.c (Fprevious_property_change): New forward static decl.
11638 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11640 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11641 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11643 * editfns.c (Fformat): Remove unreachable code.
11645 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11647 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11650 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11652 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11653 when at ZV. (Bug#8487)
11655 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11657 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11659 * keyboard.c (parse_tool_bar_item): Likewise.
11660 * sound.c (sound_cleanup, alsa_close): Likewise.
11661 * termcap.c (tgetent): Likewise.
11662 * xfns.c (x_default_font_parameter): Likewise.
11663 * xsettings.c (read_and_apply_settings): Likewise.
11665 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11666 (overrun_check_free): Protoize.
11668 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11670 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11671 since callers should never pass a negative size.
11672 Change the signature to match that of plain 'read' and 'write'; see
11673 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11674 * lisp.h: Update prototypes of emacs_write and emacs_read.
11676 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11678 * xdisp.c (redisplay_window): Don't try to determine the character
11679 position of the scroll margin if the window start point w->startp
11680 is outside the buffer's accessible region. (Bug#8468)
11682 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11684 Fix write-region and its subroutines for buffers > 2GB.
11685 * fileio.c (a_write, e_write): Modify declaration of arguments and
11686 local variables to support buffers larger than 2GB.
11687 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11689 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11690 argument, local variables, and return value.
11692 * lisp.h: Update prototypes of emacs_write and emacs_read.
11694 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11696 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11698 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11700 Fix more problems found by GCC 4.6.0's static checks.
11702 * xdisp.c (vmessage): Use a better test for character truncation.
11704 * charset.c (load_charset_map): <, not <=, for optimization,
11705 and to avoid potential problems with integer overflow.
11706 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11707 * casetab.c (set_identity, shuffle): Likewise.
11708 * editfns.c (Fformat): Likewise.
11709 * syntax.c (skip_chars): Likewise.
11711 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11712 This also lets GCC 4.6.0 generate slightly better loop code.
11714 * callint.c (Fcall_interactively): <, not <=, for optimization.
11715 (Fcall_interactively): Count the number of arguments produced,
11716 not the number of arguments given. This is simpler and lets GCC
11717 4.6.0 generate slightly better code.
11719 * ftfont.c: Distingish more carefully between FcChar8 and char.
11720 The previous code passed unsigned char * to a functions like
11721 strlen and xstrcasecmp that expect char *, which does not
11722 conform to the C standard.
11723 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11724 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11725 char * when the C standard requires it.
11727 * keyboard.c (read_char): Remove unused var.
11729 * eval.c: Port to Windows vsnprintf (Bug#8435).
11730 Include <limits.h>.
11731 (SIZE_MAX): Define if the headers do not.
11732 (verror): Do not give up if vsnprintf returns a negative count.
11733 Instead, grow the buffer. This ports to Windows vsnprintf, which
11734 does not conform to C99. Problem reported by Eli Zaretskii.
11735 Also, simplify the allocation scheme, by avoiding the need for
11736 calling realloc, and removing the ALLOCATED variable.
11738 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11740 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11741 But keep the doprint source code for now, as we might revamp it
11742 and use it again (Bug#8435).
11743 * lisp.h (doprnt): Remove.
11744 * Makefile.in (base_obj): Remove doprnt.o.
11745 * deps.mk (doprnt.o): Remove.
11747 error: Print 32- and 64-bit integers portably (Bug#8435).
11748 Without this change, on typical 64-bit hosts error ("...%d...", N)
11749 was used to print both 32- and 64-bit integers N, which relied on
11750 undefined behavior.
11751 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11752 * lisp.h (error, verror): Mark as printf-like functions.
11753 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11754 Report overflow in size calculations when allocating printf buffer.
11755 Do not truncate output string at its first null byte.
11756 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11757 Truncate the output at a character boundary, since vsnprintf does not
11759 * charset.c (check_iso_charset_parameter): Convert internal
11760 character to string before calling 'error', since %c now has the
11762 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11763 overflow when computing char to be passed to 'error'. Do not
11764 pass Lisp_Object to 'error'; pass the integer instead.
11765 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11766 formatted with plain %d.
11768 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11770 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11772 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11774 * xterm.c (x_catch_errors): Remove duplicate declaration.
11776 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11778 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11780 2011-04-10 Jim Meyering <meyering@redhat.com>
11782 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11783 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11784 return ssize_t not "int", and use size_t as the buffer length.
11785 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11786 * gnutls.h: Update declarations.
11787 * process.c (read_process_output): Use ssize_t, to match.
11788 (send_process): Likewise.
11790 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11792 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11794 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11796 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11797 Use unsigned char, to match FcChar8 type definition.
11799 * xterm.c (handle_one_xevent):
11800 * xmenu.c (create_and_show_popup_menu):
11801 * xselect.c (x_decline_selection_request)
11802 (x_reply_selection_request): Avoid type-punned deref of X events.
11804 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11806 Fix some uses of `int' instead of EMACS_INT.
11807 * search.c (string_match_1, fast_string_match)
11808 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11809 (scan_buffer, find_next_newline_no_quit)
11810 (find_before_next_newline, search_command, Freplace_match)
11811 (Fmatch_data): Make some `int' variables be EMACS_INT.
11813 * xdisp.c (display_count_lines): 3rd argument and return value now
11814 EMACS_INT. All callers changed.
11815 (pint2hrstr): Last argument is now EMACS_INT.
11817 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11818 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11819 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11820 (decode_coding_utf_16, decode_coding_emacs_mule)
11821 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11822 (decode_coding_ccl, decode_coding_charset)
11823 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11824 (decode_coding_iso_2022, decode_coding_emacs_mule)
11825 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11826 <char_offset, last_offset>: Declare EMACS_INT.
11827 (encode_coding_utf_8, encode_coding_utf_16)
11828 (encode_coding_emacs_mule, encode_invocation_designation)
11829 (encode_designation_at_bol, encode_coding_iso_2022)
11830 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11831 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11833 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11834 (encode_invocation_designation): Last argument P_NCHARS is now
11836 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11837 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11839 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11842 * ccl.c (Fccl_execute_on_string): Declare some variables
11845 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11847 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11849 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11851 * process.c (Fformat_network_address): Doc fix.
11853 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11855 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11857 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11859 * keyboard.c (read_char): Call Lisp function help-form-show,
11860 instead of using internal_with_output_to_temp_buffer.
11861 (Qhelp_form_show): New var.
11862 (syms_of_keyboard): Use DEFSYM macro.
11864 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11866 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11868 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11870 * process.c (Flist_processes): Remove to Lisp.
11871 (list_processes_1): Delete.
11873 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11875 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11877 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11879 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11881 Fix more problems found by GCC 4.6.0's static checks.
11883 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11885 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11887 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11889 * xdisp.c (vmessage): Mark as a printf-like function.
11891 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11893 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11895 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11896 printf-like functions.
11897 (tiff_load): Add casts to remove these marks before passing them
11898 to system-supplied API.
11900 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11902 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11903 This avoids several warnings with gcc -Wstrict-overflow.
11904 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11905 directly, rather than having caller test rule sign. This avoids
11906 some unnecessary tests.
11907 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11908 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11909 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11911 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11912 (xfont_open): Avoid unnecessary tests.
11914 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11916 * composite.h, composite.c (composition_gstring_put_cache):
11917 Use EMACS_INT, not int, for length.
11919 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11920 breaking out part of COMPOSITION_DECODE_RULE.
11921 (COMPOSITION_DECODE_RULE): Use it.
11922 * composite.c (get_composition_id): Remove unused local vars,
11923 by using the new macro.
11925 * textprop.c (set_text_properties_1): Change while to do-while,
11926 since the condition is always true at first.
11928 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11929 (interval_deletion_adjustment): Return unsigned value.
11932 * process.c (list_processes_1, create_pty, read_process_output):
11933 (exec_sentinel): Remove vars that were set but not used.
11934 (create_pty): Remove unnecessary "volatile"s.
11935 (Fnetwork_interface_info): Avoid possibility of int overflow.
11936 (read_process_output): Do adaptive read buffering even if carryover.
11937 (read_process_output): Simplify nbytes computation if buffered.
11939 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11941 * syntax.c (scan_words): Remove var that was set but not used.
11942 (update_syntax_table): Use unsigned instead of int.
11944 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11945 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11946 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11948 * print.c (print_error_message): Avoid int overflow.
11950 * font.c (font_list_entities): Redo for clarity,
11951 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11953 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11954 (font_score): Avoid potential overflow in diff calculation.
11956 * fns.c (substring_both): Remove var that is set but not used.
11957 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11959 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11961 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11962 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11963 can always succeed if overflow has undefined behavior.
11965 * search.c (boyer_moore, wordify): Remove vars set but not used.
11966 (wordify): Omit three unnecessary tests.
11968 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11969 All callers changed. This avoids the need for an unused var.
11971 * casefiddle.c (casify_region): Remove var that is set but not used.
11973 * dired.c (file_name_completion): Remove var that is set but not used.
11975 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11977 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11978 (Finsert_file_contents): Remove unnecessary code checking fd.
11980 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11981 Check for integer overflow on size calculations.
11983 * buffer.c (Fprevious_overlay_change): Remove var that is set
11986 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11987 Remove vars that are set but not used.
11988 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11989 (timer_check_2): Mark vars as initialized.
11991 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11993 * image.c (lookup_image): Remove var that is set but not used.
11994 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11996 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11997 that are set but not used.
11999 * xfns.c (make_invisible_cursor): Don't return garbage
12000 if XCreateBitmapFromData fails (Bug#8410).
12002 * xselect.c (x_get_local_selection, x_handle_property_notify):
12003 Remove vars that are set but not used.
12005 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12006 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12008 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12009 Remove var that is set but not used.
12010 (scroll_bar_windows_size): Now size_t, not int.
12011 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12012 Check for overflow.
12014 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12015 (map_tty_color) [!defined MSDOS]: Likewise.
12017 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12019 * coding.c: Remove vars that are set but not used.
12020 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12021 All callers changed.
12022 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12023 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12024 (decode_coding_charset): Remove vars that are set but not used.
12026 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12027 that is set but not used.
12029 * print.c (print_object): Remove var that is set but not used.
12031 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12032 The gnulib version avoids calling malloc in the usual case,
12033 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12034 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12035 * filelock.c (current_lock_owner): Likewise.
12036 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12037 * sysdep.c: Include allocator.h, careadlinkat.h.
12038 (emacs_no_realloc_allocator): New static constant.
12039 (emacs_readlink): New function.
12040 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12041 ../lib/careadlinkat.h.
12043 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12045 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12046 first non-nil return value).
12048 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12050 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12051 if not defined (Bug#8403).
12053 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12055 * xdisp.c (display_count_lines): Remove parameter `start',
12056 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12057 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12058 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12059 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12060 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12061 and thereabouts. All callers changed.
12062 (get_per_char_metric): Remove parameter `f', unused since
12063 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12065 2011-04-02 Jim Meyering <meyering@redhat.com>
12067 do not dereference NULL upon failed strdup
12068 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12069 (ns_get_family): Likewise.
12071 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12073 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12075 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12077 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12080 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12082 Add lexical binding.
12084 * window.c (Ftemp_output_buffer_show): New fun.
12085 (Fsave_window_excursion):
12086 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12088 * lread.c (lisp_file_lexically_bound_p): New function.
12089 (Fload): Bind Qlexical_binding.
12090 (readevalloop): Remove `evalfun' arg.
12091 Bind Qinternal_interpreter_environment.
12092 (Feval_buffer): Bind Qlexical_binding.
12093 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12095 (syms_of_lread): Declare `lexical-binding'.
12097 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12099 * keyboard.c (eval_dyn): New fun.
12100 (menu_item_eval_property): Use it.
12102 * image.c (parse_image_spec): Use Ffunctionp.
12104 * fns.c (concat, mapcar1): Accept byte-code-functions.
12106 * eval.c (Fsetq): Handle lexical vars.
12107 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12108 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12109 (FletX, Flet): Obey lexical binding.
12110 (Fcommandp): Handle closures.
12111 (Feval): New `lexical' arg.
12112 (eval_sub): New function extracted from Feval. Use it almost
12113 everywhere where Feval was used. Look up vars in lexical env.
12115 (Ffunctionp): Move from subr.el.
12116 (Ffuncall): Handle closures.
12117 (apply_lambda): Remove `eval_flags'.
12118 (funcall_lambda): Handle closures and new byte-code-functions.
12119 (Fspecial_variable_p): New function.
12120 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12121 but without exporting it to Lisp.
12123 * doc.c (Fdocumentation, store_function_docstring):
12124 * data.c (Finteractive_form): Handle closures.
12126 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12129 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12131 (exec_byte_code): New function extracted from Fbyte_code to handle new
12132 calling convention for byte-code-functions. Add new byte-codes.
12134 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12136 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12138 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12140 * xdisp.c (redisplay_internal): Fix prototype.
12142 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12144 * xdisp.c (SCROLL_LIMIT): New macro.
12145 (try_scrolling): Use it when setting scroll_limit.
12146 Limit scrolling to 100 screen lines.
12147 (redisplay_window): Even when falling back on "recentering",
12148 position point in the window according to scroll-conservatively,
12149 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12151 (try_scrolling): When point is above the window, allow searching
12152 as far as scroll_max, or one screenful, to compute vertical
12153 distance from PT to the scroll margin position. This prevents
12154 try_scrolling from unnecessarily failing when
12155 scroll-conservatively is set to a value slightly larger than the
12156 window height. Clean up the case of PT below the margin at bottom
12157 of window: scroll_max can no longer be INT_MAX. When aggressive
12158 scrolling is in use, don't let point enter the opposite scroll
12159 margin as result of the scroll.
12160 (syms_of_xdisp) <scroll-conservatively>: Document the
12161 threshold of 100 lines for never-recentering scrolling.
12163 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12165 * dispextern.h (move_it_by_lines):
12166 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12167 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12168 (message_log_check_duplicate): Remove parameters `prev_bol' and
12169 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12170 (redisplay_internal): Remove parameter `preserve_echo_area',
12171 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12173 * indent.c (Fvertical_motion):
12174 * window.c (window_scroll_pixel_based, Frecenter):
12175 Don't pass `need_y_p' to `move_it_by_lines'.
12177 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12179 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12180 steal a few bits to be more compact.
12181 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12182 Remove unneeded casts.
12184 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12186 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12188 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12189 binding" message (bug#7967).
12191 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12193 Fix more problems found by GCC 4.6.0's static checks.
12195 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12196 Remove unused local var.
12198 * editfns.c (Fmessage_box): Remove unused local var.
12200 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12201 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12202 Omit unused local vars.
12203 * window.c (shrink_windows): Omit unused local var.
12204 * menu.c (digest_single_submenu): Omit unused local var.
12205 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12206 Omit unused local var.
12208 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12209 Don't assume string length fits in int.
12210 (keyremap_step, read_key_sequence): Use size_t for sizes.
12211 (read_key_sequence): Don't check last_real_key_start redundantly.
12213 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12214 instead of alloca (Bug#8344).
12216 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12217 (Fbacktrace_frame): Don't assume nframes fits in int.
12219 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12221 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12224 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12226 * cm.c (calccost): Turn while-do into do-while, for clarity.
12228 * keyboard.c (syms_of_keyboard): Use the same style as later
12229 in this function when indexing through an array. This also
12230 works around GCC bug 48267.
12232 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12234 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12236 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12237 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12239 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12240 This avoids undefined behavior on integer overflow, and is a bit
12241 more convenient anyway since it is compared to a size_t variable.
12243 Variadic C functions now count arguments with size_t, not int.
12244 This avoids an unnecessary limitation on 64-bit machines, which
12245 caused (substring ...) to crash on large vectors (Bug#8344).
12246 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12247 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12248 All variadic functions and their callers changed accordingly.
12249 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12250 * data.c (arith_driver, float_arith_driver): Likewise.
12251 * editfns.c (general_insert_function): Likewise.
12252 * eval.c (struct backtrace.nargs, interactive_p)
12253 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12254 (funcall_lambda, mark_backtrace): Likewise.
12255 * fns.c (concat): Likewise.
12256 * frame.c (x_set_frame_parameters): Likewise.
12257 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12258 0 if not found, not -1. All callers changed.
12260 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12261 (stack_copy_size): Now size_t, not int.
12262 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12264 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12266 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12267 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12268 All callers changed.
12270 * lisp.h (multibyte_char_to_unibyte):
12271 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12272 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12273 * character.h (CHAR_TO_BYTE8):
12274 * cmds.c (internal_self_insert):
12275 * editfns.c (general_insert_function):
12276 * keymap.c (push_key_description):
12277 * search.c (Freplace_match):
12278 * xdisp.c (message_dolog, set_message_1): All callers changed.
12280 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12282 * keyboard.c (safe_run_hook_funcall): New function.
12283 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12284 don't set the hook to nil, but remove the offending function instead.
12285 (Qcommand_hook_internal): Remove, unused.
12286 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12287 Vcommand_hook_internal.
12289 * eval.c (enum run_hooks_condition): Remove.
12290 (funcall_nil, funcall_not): New functions.
12291 (run_hook_with_args): Call each function through a `funcall' argument.
12292 Remove `cond' argument, now redundant.
12293 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12294 (Frun_hook_with_args_until_failure): Adjust accordingly.
12295 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12297 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12299 * dispextern.h (string_buffer_position): Remove declaration.
12301 * print.c (strout): Remove parameter `multibyte', unused since
12302 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12304 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12305 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12306 All callers changed.
12308 * w32.c (_wsa_errlist): Use braces for struct initializers.
12310 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12311 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12312 All callers changed.
12313 (string_buffer_position): Likewise. Also, make static (it's never
12314 used outside xdisp.c).
12315 (cursor_row_p): Remove parameter `w', unused since
12316 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12317 (decode_mode_spec): Remove parameter `precision', introduced during
12318 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12319 All callers changed.
12321 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12323 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12325 2011-03-27 Anders Lindgren <andlind@gmail.com>
12327 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12328 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12329 (ns_update_auto_hide_menu_bar): New functions.
12330 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12331 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12332 ns_constrain_all_frames.
12333 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12334 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12336 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12338 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12340 2011-03-27 Glenn Morris <rgm@gnu.org>
12342 * syssignal.h: Replace RETSIGTYPE with void.
12343 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12344 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12345 Replace SIGTYPE with void everywhere.
12346 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12347 * s/template.h (SIGTYPE): Remove commented out definition.
12349 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12351 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12352 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12354 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12356 * w32.c (read_unc_volume): Use parameter `henum', instead of
12357 global variable `wget_enum_handle'.
12359 * keymap.c (describe_vector): Remove parameters `indices' and
12360 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12361 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12363 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12365 * keyboard.c (timer_check): Remove parameter `do_it_now',
12366 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12367 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12368 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12370 * keyboard.c (read_char):
12371 * w32menu.c (w32_menu_display_help):
12372 * xmenu.c (show_help_event, menu_help_callback):
12373 Adjust calls to `show_help_echo'.
12375 * gtkutil.c (xg_maybe_add_timer):
12376 * keyboard.c (readable_events):
12377 * process.c (wait_reading_process_output):
12378 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12380 * insdel.c (adjust_markers_gap_motion):
12381 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12382 (gap_left, gap_right): Don't call it.
12384 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12386 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12387 incurred during fontification.
12389 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12391 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12392 (DEFVAR_PER_BUFFER): Don't pass it.
12394 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12395 (scrolling_window): Don't pass it.
12397 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12399 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12401 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12403 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12404 of variables specific to SELinux and computation of `encoded_absname'.
12406 * image.c (XPutPixel): Remove unused variable `height'.
12408 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12410 * unexw32.c (get_section_info): Remove unused variable `section'.
12412 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12413 (system_process_attributes): Remove unused variable `sess'.
12414 (sys_read): Remove unused variable `err'.
12416 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12417 (w32_wnd_proc): Remove unused variable `isdead'.
12418 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12419 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12420 (x_create_tip_frame): Remove unused variable `tem'.
12422 * w32inevt.c (w32_console_read_socket):
12423 Remove unused variable `no_events'.
12425 * w32term.c (x_draw_composite_glyph_string_foreground):
12426 Remove unused variable `width'.
12428 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12430 * w32term.c (x_set_glyph_string_clipping):
12431 Don't pass uninitialized region to CombineRgn.
12433 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12435 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12436 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12437 (Fx_close_connection): Remove unused variable `i'.
12439 * w32font.c (w32font_draw): Return number of glyphs.
12440 (w32font_open_internal): Remove unused variable `i'.
12441 (w32font_driver): Add missing initializer.
12443 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12444 (fill_in_menu): Remove unused variable `items_added'.
12446 * w32term.c (last_mouse_press_frame): Remove static global variable.
12447 (w32_clip_to_row): Remove unused variable `f'.
12448 (x_delete_terminal): Remove unused variable `i'.
12450 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12451 (NOTHING): Remove unused static global variable.
12452 (uniscribe_check_otf): Remove unused variable `table'.
12453 (uniscribe_font_driver): Add missing initializers.
12455 2011-03-23 Julien Danjou <julien@danjou.info>
12457 * term.c (Fsuspend_tty, Fresume_tty):
12458 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12459 * window.c (temp_output_buffer_show):
12460 * insdel.c (signal_before_change):
12461 * frame.c (Fhandle_switch_frame):
12462 * fileio.c (Fdo_auto_save):
12463 * emacs.c (Fkill_emacs):
12464 * editfns.c (save_excursion_restore):
12465 * cmds.c (internal_self_insert):
12466 * callint.c (Fcall_interactively):
12467 * buffer.c (Fkill_all_local_variables):
12468 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12470 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12471 unconditionally since it does the check itself.
12473 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12475 Fix more problems found by GCC 4.5.2's static checks.
12477 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12478 the first time through the loop, since we know p0 < p1 then.
12479 This also avoids a gcc -Wstrict-overflow warning.
12481 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12482 leading to a memory leak, possible in functions like
12483 load_charset_map_from_file that can allocate an unbounded number
12484 of objects (Bug#8318).
12486 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12487 that could (at least in theory) be that large.
12489 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12490 This is less likely to overflow, and avoids undefined behavior if
12491 overflow does occur. All callers changed. Use strtoul to scan
12492 for the unsigned long integer.
12493 (pint2hrstr): Simplify and tune code slightly.
12494 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12496 * scroll.c (do_scrolling): Work around GCC bug 48228.
12497 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12499 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12500 This also avoids a warning with gcc -Wstrict-overflow.
12501 (validate_x_resource_name): Simplify count usage.
12502 This also avoids a warning with gcc -Wstrict-overflow.
12504 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12507 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12509 * process.c (Fmake_network_process): Use socklen_t, not int,
12510 where POSIX says socklen_t is required in portable programs.
12511 This fixes a porting bug on hosts like 64-bit HP-UX, where
12512 socklen_t is wider than int (Bug#8277).
12513 (Fmake_network_process, server_accept_connection):
12514 (wait_reading_process_output, read_process_output):
12517 * process.c: Rename or move locals to avoid shadowing.
12518 (list_processes_1, Fmake_network_process):
12519 (read_process_output_error_handler, exec_sentinel_error_handler):
12520 Rename or move locals.
12521 (Fmake_network_process): Define label "retry_connect" only if needed.
12522 (Fnetwork_interface_info): Fix pointer signedness.
12523 (process_send_signal): Add cast to avoid pointer signedness problem.
12524 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12525 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12527 Make tparam.h and terminfo.c consistent.
12528 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12529 Include tparam.h instead, since it declares them.
12530 * cm.h (PC): Remove extern decl; tparam.h now does this.
12531 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12532 * terminfo.c: Include tparam.h, to check interfaces.
12533 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12534 (tparam): Adjust signature to match interface in tparam.h;
12535 this removes some undefined behavior. Check that outstring and len
12536 are zero, which they always are with Emacs.
12537 * tparam.h (PC, BC, UP): New extern decls.
12539 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12540 (xftfont_open): Rename locals to avoid shadowing.
12542 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12543 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12544 (OTF_TAG_SYM): Omit macro if not needed.
12545 (ftfont_list): Remove unused local.
12546 (get_adstyle_property, ftfont_pattern_entity):
12547 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12548 Rename locals to avoid shadowing.
12550 * xfont.c (xfont_list_family): Mark var as initialized.
12552 * xml.c (make_dom): Now static.
12554 * composite.c (composition_compute_stop_pos): Rename local to
12556 (composition_reseat_it): Remove unused locals.
12557 (find_automatic_composition, composition_adjust_point): Likewise.
12558 (composition_update_it): Mark var as initialized.
12559 (find_automatic_composition): Mark vars as initialized,
12560 with a FIXME (Bug#8290).
12562 character.h: Rename locals to avoid shadowing.
12563 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12564 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12565 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12566 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12567 to avoid shadowing.
12569 * textprop.c (property_change_between_p): Remove; unused.
12571 * intervals.c (interval_start_pos): Now static.
12573 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12575 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12576 Rename locals to avoid shadowing.
12578 * sound.c (wav_play, au_play, Fplay_sound_internal):
12579 Fix pointer signedness.
12580 (alsa_choose_format): Remove unused local var.
12581 (wav_play): Initialize a variable to 0, to prevent undefined
12582 behavior (Bug#8278).
12584 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12586 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12588 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12589 clobbering (Bug#8298).
12590 * sysdep.c (sys_subshell): Likewise.
12591 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12593 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12594 This should get cleaned up, so that child_setup has the
12595 same signature on all platforms.
12597 * callproc.c (call_process_cleanup): Now static.
12598 (relocate_fd): Rename locals to avoid shadowing.
12600 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12602 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12603 not to be necessary, and produces flickering.
12605 2011-03-20 Glenn Morris <rgm@gnu.org>
12607 * config.in: Remove file.
12609 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12611 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12612 are now in src/globals.h.
12613 (syms_of_minibuf): Remove spurious & from previous change.
12615 2011-03-20 Leo Liu <sdl.web@gmail.com>
12617 * minibuf.c (completing-read-function): New variable.
12618 (completing-read-default): Rename from completing-read.
12619 (completing-read): Call completing-read-function.
12621 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12623 * xfaces.c (Fx_load_color_file):
12624 Read color file from absolute filename (bug#8250).
12626 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12628 * makefile.w32-in: Update dependencies.
12630 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12632 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12634 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12636 Fix more problems found by GCC 4.5.2's static checks.
12638 * process.c (make_serial_process_unwind, send_process_trap):
12639 (sigchld_handler): Now static.
12641 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12642 That way, the code declares only the vars that it needs.
12643 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12644 * s/cygwin.h (PTY_ITERATION): Likewise.
12645 * s/darwin.h (PTY_ITERATION): Likewise.
12646 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12648 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12649 * process.c (allocate_pty): Don't declare stb unless it's needed.
12651 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12652 (CONSTANTLIM): Remove; unused.
12653 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12654 Define only if needed.
12656 * unexelf.c (unexec): Name an expression,
12657 to avoid gcc -Wbad-function-cast warning.
12658 Use a different way to cause a compilation error if anyone uses
12659 n rather than nn, a way that does not involve shadowing.
12660 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12662 * deps.mk (unexalpha.o): Remove; unused.
12664 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12665 * unexec.h: New file.
12666 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12667 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12668 Depend on unexec.h.
12669 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12670 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12671 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12672 Change as necessary to match prototype in unexec.h.
12674 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12676 (back_comment, skip_chars): Mark vars as initialized.
12678 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12679 Rename locals to avoid shadowing.
12681 * lread.c (read1): Rewrite so as not to use empty "else".
12682 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12684 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12686 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12687 warning when compiling print.c.
12689 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12690 instead of using an uninitialized var.
12691 (font_sort_entities): Mark var as initialized.
12693 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12695 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12696 pointers to constants.
12697 (font_parse_fcname): Remove unused vars.
12698 (font_delete_unmatched): Now static.
12699 (font_get_spec): Remove; unused.
12700 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12701 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12702 Rename or move locals to avoid shadowing.
12704 * fns.c (require_nesting_list, require_unwind): Now static.
12705 (Ffillarray): Rename locals to avoid shadowing.
12707 * floatfns.c (domain_error2): Define only if needed.
12708 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12710 * alloc.c (mark_backtrace): Move decl from here ...
12711 * lisp.h: ... to here, so that it can be checked.
12713 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12714 (Fdefvar): Rewrite so as not to use empty "else".
12715 (lisp_indirect_variable): Name an expression,
12716 to avoid gcc -Wbad-function-cast warning.
12717 (Fdefvar): Rename locals to avoid shadowing.
12719 * callint.c (quotify_arg, quotify_args): Now static.
12720 (Fcall_interactively): Rename locals to avoid shadowing.
12721 Use const pointer when appropriate.
12723 * lisp.h (get_system_name, get_operating_system_release):
12724 Move decls here, to check interfaces.
12725 * process.c (get_operating_system_release): Move decl to lisp.h.
12726 * xrdb.c (get_system_name): Likewise.
12727 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12728 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12729 some of which prompt warnings from gcc -Wbad-function-cast.
12730 (Fformat_time_string, Fencode_time, Finsert_char):
12731 (Ftranslate_region_internal, Fformat):
12732 Rename or remove local vars to avoid shadowing.
12733 (Ftranslate_region_internal): Mark var as initialized.
12735 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12738 * lisp.h (eassert): Check that the argument compiles, even if
12739 ENABLE_CHECKING is not defined.
12741 * data.c (Findirect_variable): Name an expression, to avoid
12742 gcc -Wbad-function-cast warning.
12743 (default_value, arithcompare, arith_driver, arith_error): Now static.
12744 (store_symval_forwarding): Rename local to avoid shadowing.
12745 (Fmake_variable_buffer_local, Fmake_local_variable):
12746 Mark variables as initialized.
12747 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12749 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12750 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12751 Rename locals to avoid shadowing.
12752 (mark_stack): Move local variables into the #ifdef region where
12754 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12755 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12757 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12758 (GC_STRING_CHARS): Remove; not used.
12759 (Fmemory_limit): Cast sbrk's returned value to char *.
12761 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12762 avoids undefined behavior in theory.
12764 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12766 Use functions, not macros, for up- and down-casing (Bug#8254).
12767 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12768 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12769 to use the following functions instead of these macros.
12770 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12771 EMACS_INT, since callers assume the returned value fits in int.
12772 (upcase1): Likewise, for UPCASE_TABLE.
12773 (uppercasep, lowercasep, upcase): New static inline functions.
12774 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12775 the race-condition problem in the old DOWNCASE.
12777 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12778 Rename locals to avoid shadowing.
12779 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12780 (regex_compile, re_search_2, re_match_2_internal):
12781 Remove unused local vars.
12782 (FREE_VAR): Rewrite so as not to use empty "else",
12783 which gcc can warn about.
12784 (regex_compile, re_match_2_internal): Mark locals as initialized.
12785 (RETALLOC_IF): Define only if needed.
12786 (WORDCHAR_P): Likewise. This one is never needed, but is used
12787 only in a comment talking about a compiler bug, so put inside
12788 the #if 0 of that comment.
12789 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12790 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12793 * search.c (boyer_moore): Rename locals to avoid shadowing.
12794 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12795 (PREV_CHAR_BOUNDARY): Likewise.
12797 * search.c (simple_search): Remove unused var.
12799 * dired.c (compile_pattern): Move decl from here ...
12800 * lisp.h: ... to here, so that it can be checked.
12801 (struct re_registers): New forward decl.
12803 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12805 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12807 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12808 Rename locals to avoid shadowing.
12809 (Fvertical_motion): Mark locals as initialized.
12811 * casefiddle.c (casify_object, casify_region): Now static.
12812 (casify_region): Mark local as initialized.
12814 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12816 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12817 New macros, so that the caller can use some names other than
12818 gcpro1, gcpro2, etc.
12819 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12821 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12822 argument, for consistency with GCPRO2_VAR, etc: it is now the
12823 prefix of the variable, not the variable itself. All uses
12825 * dired.c (directory_files_internal, file_name_completion):
12826 Rename locals to avoid shadowing.
12828 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12829 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12830 dired.c's scmp function, had undefined behavior.
12831 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12832 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12833 * buffer.h: ... to here, because these macros use current_buffer,
12834 and the new implementation with inline functions needs to have
12835 current_buffer in scope now, rather than later when the macros
12837 (downcase, upcase1): New static inline functions.
12838 (DOWNCASE, UPCASE1): Reimplement using these functions.
12839 This avoids undefined behavior in expressions like
12840 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12841 from race conditions in accessing the global variables
12842 case_temp1 and case_temp2.
12843 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12844 * lisp.h (case_temp1, case_temp2): Remove their decls.
12845 * character.h (ASCII_CHAR_P): Move from here ...
12846 * lisp.h: ... to here, so that the inline functions mentioned
12847 above can use them.
12849 * dired.c (directory_files_internal_unwind): Now static.
12851 * fileio.c (file_name_as_directory, directory_file_name):
12852 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12854 (file_name_as_directory): Use const pointers when appropriate.
12855 (Fexpand_file_name): Likewise. In particular, newdir might
12856 point at constant storage, so make it a const pointer.
12857 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12858 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12860 (Fset_file_times, Finsert_file_contents, auto_save_error):
12861 Rename locals to avoid shadowing.
12863 * minibuf.c (choose_minibuf_frame_1): Now static.
12864 (Ftry_completion, Fall_completions): Rename or remove locals
12865 to avoid shadowing.
12867 * marker.c (bytepos_to_charpos): Remove; unused.
12869 * lisp.h (verify_bytepos, count_markers): New decls,
12870 so that gcc does not warn that these functions aren't declared.
12872 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12873 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12874 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12875 (copy_text): Remove unused local var.
12877 * filelock.c (within_one_second): Now static.
12878 (lock_file_1): Rename local to avoid shadowing.
12880 * buffer.c (fix_overlays_before): Mark locals as initialized.
12881 (fix_start_end_in_overlays): Likewise. This function should be
12882 simplified by using pointers-to-pointers, but that's a different
12884 (switch_to_buffer_1): Now static.
12885 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12886 (report_overlay_modification): Rename locals to avoid shadowing.
12888 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12889 Fix pointer signedness issue.
12890 (sys_subshell): Mark local as volatile if checking for lint,
12891 to suppress a gcc -Wclobbered warning that does not seem to be right.
12892 (MAXPATHLEN): Define only if needed.
12894 * process.c (serial_open, serial_configure): Move decls from here ...
12895 * systty.h: ... to here, so that they can be checked.
12897 * fns.c (get_random, seed_random): Move extern decls from here ...
12898 * lisp.h: ... to here, so that they can be checked.
12900 * sysdep.c (reset_io): Now static.
12901 (wait_for_termination_signal): Remove; unused.
12903 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12904 (copy_keymap_item, append_key, push_text_char_description):
12906 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12907 (DENSE_TABLE_SIZE): Remove; unused.
12908 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12909 (describe_map_tree):
12910 Rename locals to avoid shadowing.
12912 * keyboard.c: Declare functions static if they are not used elsewhere.
12913 (echo_char, echo_dash, cmd_error, top_level_2):
12914 (poll_for_input, handle_async_input): Now static.
12915 (read_char, kbd_buffer_get_event, make_lispy_position):
12916 (make_lispy_event, make_lispy_movement, apply_modifiers):
12917 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12918 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12919 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12920 (read_key_sequence, read_char): Mark locals as initialized.
12921 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12923 * keyboard.h (make_ctrl_char): New decl.
12924 (mark_kboards): Move decl here ...
12925 * alloc.c (mark_kboards): ... from here.
12927 * lisp.h (force_auto_save_soon): New decl.
12929 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12930 (DEFINE_DUMMY_FUNCTION): New macro.
12931 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12933 (main): Add casts to avoid warnings
12934 if GCC considers string literals to be constants.
12936 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12938 * dbusbind.c: Pointer signedness fixes.
12939 (xd_signature, xd_append_arg, xd_initialize):
12940 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12941 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12942 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12943 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12945 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12946 if GCC considers string literals to be constants.
12947 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12949 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12951 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12952 (print_preprocess, print_object): New macro to fix last change.
12954 * print.c (print_preprocess): Don't forget font objects.
12956 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12958 * emacs.c (USAGE3): Doc fixes.
12960 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12962 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12965 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12967 * lisp.h (VWindow_system, Qfile_name_history):
12968 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12969 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12970 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12972 * w32select.c: Don't #include "keyboard.h".
12973 (run_protected): Add extern declaration for waiting_for_input.
12975 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12976 * w32console.c (detect_input_pending, read_input_pending)
12977 (encode_terminal_code):
12978 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12979 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12980 (w32_system_caret_y, Qfile_name_history):
12981 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12982 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12983 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12984 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12985 * w32proc.c (Qlocal, report_file_error):
12986 * w32term.c (Vwindow_system, updating_frame):
12987 * w32uniscribe.c (initialized, uniscribe_font_driver):
12988 Remove unneeded extern declarations.
12990 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12992 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12994 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12996 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12997 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12998 These macros can no longer be used for assignment.
13000 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13001 Assign struct members directly, instead of using BUF_BEGV etc.
13002 (record_buffer_markers, fetch_buffer_markers): New functions for
13003 recording and fetching special buffer markers.
13004 (set_buffer_internal_1, set_buffer_temp): Use them.
13006 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13008 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13010 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13011 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13013 * xdisp.c (hscroll_window_tree):
13014 (reconsider_clip_changes): Use PT instead of BUF_PT.
13016 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13018 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13019 $(EMACS_ROOT)/lib/intprops.h.
13021 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13023 Fix more problems found by GCC 4.5.2's static checks.
13025 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13026 to unsigned char * to avoid compiler diagnostic.
13027 (xg_free_frame_widgets): Make it clear that a local variable is
13028 needed only if USE_GTK_TOOLTIP.
13029 (gdk_window_get_screen): Make it clear that this macro is needed
13030 only if USE_GTK_TOOLTIP.
13031 (int_gtk_range_get_value): New function, which avoids a diagnostic
13032 from gcc -Wbad-function-cast.
13033 (xg_set_toolkit_scroll_bar_thumb): Use it.
13034 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13035 diagnostic from gcc -Wbad-function-cast.
13036 (get_utf8_string, xg_get_file_with_chooser):
13037 Rename locals to avoid shadowing.
13038 (create_dialog): Move locals to avoid shadowing.
13040 * xgselect.c (xg_select): Remove unused var.
13042 * image.c (four_corners_best): Mark locals as initialized.
13043 (gif_load): Initialize transparent_p to zero (Bug#8238).
13044 Mark another local as initialized.
13045 (my_png_error, my_error_exit): Mark with NO_RETURN.
13047 * image.c (clear_image_cache): Now static.
13048 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13049 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13050 (x_edge_detection): Remove unnecessary cast that
13051 gcc -Wbad-function-cast diagnoses.
13052 (gif_load): Fix pointer signedness.
13053 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13054 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13056 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13058 Improve quality of tests for time stamp overflow.
13059 For example, without this patch (encode-time 0 0 0 1 1
13060 1152921504606846976) returns the obviously-bogus value (-948597
13061 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13062 reports time overflow. See
13063 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13064 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13065 * editfns.c: Include limits.h and intprops.h.
13066 (TIME_T_MIN, TIME_T_MAX): New macros.
13067 (time_overflow): Move earlier, to before first use.
13068 (hi_time, lo_time): New functions, for an accurate test for
13069 out-of-range times.
13070 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13071 (Fget_internal_run_time): Don't assume time_t fits in int.
13072 (make_time): Use list2 instead of Fcons twice.
13073 (Fdecode_time): More accurate test for out-of-range times.
13074 (check_tm_member): New function.
13075 (Fencode_time): Use it, to test for out-of-range times.
13076 (lisp_time_argument): Don't rely on undefined left-shift and
13077 right-shift behavior when checking for time stamp overflow.
13079 * editfns.c (time_overflow): New function, refactoring common code.
13080 (Fformat_time_string, Fdecode_time, Fencode_time):
13081 (Fcurrent_time_string): Use it.
13083 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13084 * dired.c (make_time): Move to ...
13085 * editfns.c (make_time): ... here.
13086 * systime.h: Note the move.
13088 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13090 * fringe.c (update_window_fringes): Remove unused variables.
13092 * unexmacosx.c (copy_data_segment): Also copy __got section.
13095 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13097 * termcap.c [MSDOS]: Include "msdos.h".
13098 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13099 Constify `char *' arguments and their references according to
13100 prototypes in tparam.h.
13102 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13104 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13105 Adapt all references accordingly.
13107 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13109 2011-03-11 Tom Tromey <tromey@redhat.com>
13111 * buffer.c (syms_of_buffer): Remove obsolete comment.
13113 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13115 * termhooks.h (encode_terminal_code): Declare prototype.
13117 * msdos.c (encode_terminal_code): Don't declare prototype.
13119 * term.c (encode_terminal_code): Now external again, used by
13120 w32console.c and msdos.c.
13122 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13123 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13125 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13127 Fix some minor problems found by GCC 4.5.2's static checks.
13129 * fringe.c (update_window_fringes): Mark locals as initialized
13131 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13133 * alloc.c (mark_fringe_data): Move decl from here ...
13134 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13135 to check its interface.
13136 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13138 * fontset.c (free_realized_fontset): Now static.
13139 (Fset_fontset_font): Rename local to avoid shadowing.
13140 (fontset_font): Mark local as initialized.
13141 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13143 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13145 * xselect.c (x_disown_buffer_selections): Remove; not used.
13146 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13147 (x_own_selection, Fx_disown_selection_internal): Rename locals
13148 to avoid shadowing.
13149 (x_handle_dnd_message): Remove local to avoid shadowing.
13151 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13152 so that the caller can use some name other than gcpro1.
13153 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13154 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13155 (Fx_backspace_delete_keys_p):
13156 Use them to avoid shadowing, and rename vars to avoid shadowing.
13157 (x_decode_color, x_set_name, x_window): Now static.
13158 (Fx_create_frame): Add braces to silence GCC warning.
13159 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13160 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13161 Remove unused locals.
13162 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13163 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13164 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13167 * xterm.h (x_mouse_leave): New decl.
13169 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13170 Remove unused functions.
13171 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13172 (x_calc_absolute_position): Now static.
13173 (XTread_socket): Don't define label "out" unless it's used.
13174 Don't declare local "event" unless it's used.
13175 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13176 unless they are used.
13177 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13178 (x_fatal_error_signal): Remove; not used.
13179 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13180 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13181 (x_error_catcher, x_connection_closed, x_error_handler):
13182 (x_error_quitter, xembed_send_message, x_iconify_frame):
13183 (my_log_handler): Rename locals to avoid shadowing.
13184 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13185 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13187 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13188 Rename or move locals to avoid shadowing.
13189 (tty_defined_color, merge_face_heights): Now static.
13190 (free_realized_faces_for_fontset): Remove; not used.
13191 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13192 does not deduce is never used uninitialized.
13193 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13194 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13196 * terminal.c (store_terminal_param): Now static.
13198 * xmenu.c (menu_highlight_callback): Now static.
13199 (set_frame_menubar): Remove unused local.
13200 (xmenu_show): Rename parameter to avoid shadowing.
13201 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13202 since they might point to immutable storage.
13203 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13204 since it's unused otherwise.
13206 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13207 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13208 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13209 avoids a gcc -Wuninitialized diagnostic.
13210 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13211 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13212 does not deduce are never used uninitialized.
13214 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13216 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13217 * window.c (window_loop, size_window):
13218 (run_window_configuration_change_hook, enlarge_window): Likewise.
13220 * window.c (display_buffer): Now static.
13221 (size_window): Mark variables that gcc -Wuninitialized
13222 does not deduce are never used uninitialized.
13223 * window.h (check_all_windows): New decl, to forestall
13224 gcc -Wmissing-prototypes diagnostic.
13225 * dispextern.h (bidi_dump_cached_states): Likewise.
13227 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13229 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13230 Include <limits.h>.
13231 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13232 and to avoid gcc -Wuninitialized warning.
13233 (load_charset_map): Mark variables that gcc -Wuninitialized
13234 does not deduce are never used uninitialized.
13235 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13237 * coding.c (coding_set_source, coding_set_destination):
13238 Use "else { /* comment */ }" rather than "else /* comment */;"
13239 for clarity, and to avoid gcc -Wempty-body warning.
13240 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13241 a block, when the outer 'i' will do.
13242 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13243 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13244 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13245 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13246 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13247 Rename locals to avoid shadowing.
13248 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13249 * coding.c (emacs_mule_char, encode_invocation_designation):
13250 Now static, since they're not used elsewhere.
13251 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13252 (decode_coding_object, encode_coding_object, detect_coding_system):
13253 (decode_coding_emacs_mule): Mark variables that gcc
13254 -Wuninitialized does not deduce are never used uninitialized.
13255 (detect_coding_iso_2022): Initialize a local variable that might
13256 be used uninitialized. Leave a FIXME because it's not clear that
13257 this initialization is needed. (Bug#8211)
13258 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13259 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13260 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13261 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13262 Remove unused macros.
13264 * category.c (hash_get_category_set): Remove unused local var.
13265 (copy_category_table): Now static, since it's not used elsewhere.
13266 * character.c (string_count_byte8): Likewise.
13268 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13269 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13271 * chartab.c (copy_sub_char_table): Now static, since it's not used
13273 (sub_char_table_ref_and_range, char_table_ref_and_range):
13274 Rename locals to avoid shadowing.
13275 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13277 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13278 (BIDI_BOB): Remove unused macro.
13280 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13281 deduce are never used uninitialized.
13282 * term.c (encode_terminal_code): Likewise.
13284 * term.c (encode_terminal_code): Now static. Remove unused local.
13286 * tparam.h: New file.
13287 * term.c, tparam.h: Include it.
13288 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13289 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13290 Move these decls to tparam.h, and make them agree with what
13291 is actually in tparam.c. The previous trick of using incompatible
13292 decls in different modules does not conform to the C standard.
13293 All callers of tparam changed to use tparam's actual API.
13294 * tparam.c (tparam1, tparam, tgoto):
13295 Use const pointers where appropriate.
13297 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13298 * cm.h (struct cm): Likewise.
13299 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13300 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13301 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13302 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13303 (turn_on_face, init_tty): Likewise.
13304 * termchar.h (struct tty_display_info): Likewise.
13306 * term.c (term_mouse_position): Rename local to avoid shadowing.
13308 * alloc.c (mark_ttys): Move decl from here ...
13309 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13311 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13313 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13315 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13317 * search.c (compile_pattern_1): Remove argument regp, unused since
13318 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13319 (compile_pattern): Don't pass it.
13321 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13323 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13324 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13326 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13328 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13330 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13331 gdk_window_get_screen, gdk_window_get_geometry,
13332 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13333 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13334 (xg_get_pixbuf_from_pixmap): New function.
13335 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13336 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13337 Call xg_get_pixbuf_from_pixmap instead of
13338 gdk_pixbuf_get_from_drawable.
13339 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13340 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13341 (xg_check_special_colors): Use GtkStyleContext and its functions
13343 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13344 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13345 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13346 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13347 Call gtk_widget_get_preferred_size.
13348 (xg_frame_resized): gdk_window_get_geometry only takes 5
13350 (xg_win_to_widget, xg_event_is_for_menubar):
13351 Call gdk_x11_window_lookup_for_display.
13352 (xg_set_widget_bg): New function.
13353 (delete_cb): New function.
13354 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13355 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13356 (xg_set_background_color): Call xg_set_widget_bg.
13357 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13358 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13359 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13360 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13362 (update_frame_tool_bar): Call gtk_widget_hide.
13363 (xg_initialize): Use GDK_KEY_g.
13365 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13367 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13369 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13370 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13371 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13373 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13375 * w32xfns.c (select_palette): Check success of RealizePalette against
13376 GDI_ERROR, not zero.
13378 See ChangeLog.11 for earlier changes.
13380 ;; Local Variables:
13384 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13386 This file is part of GNU Emacs.
13388 GNU Emacs is free software: you can redistribute it and/or modify
13389 it under the terms of the GNU General Public License as published by
13390 the Free Software Foundation, either version 3 of the License, or
13391 (at your option) any later version.
13393 GNU Emacs is distributed in the hope that it will be useful,
13394 but WITHOUT ANY WARRANTY; without even the implied warranty of
13395 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13396 GNU General Public License for more details.
13398 You should have received a copy of the GNU General Public License
13399 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.