* src/keyboard.c (safe_run_hooks_error): Don't unquote strings.
[bpt/emacs.git] / src / ChangeLog
1 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4
5 2012-03-27 Glenn Morris <rgm@gnu.org>
6
7 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
8 Doc fixes.
9
10 2012-03-26 Kenichi Handa <handa@m17n.org>
11
12 * dispextern.h (struct glyph): Fix previous change. Change the
13 bit length of glyphless.ch to 25 (Bug#11082).
14
15 2012-03-26 Chong Yidong <cyd@gnu.org>
16
17 * keyboard.c (Vselection_inhibit_update_commands): New variable.
18 (command_loop_1): Use it; inhibit selection update for
19 handle-select-window too (Bug#8996).
20
21 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
22
23 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
24
25 2012-03-25 Kenichi Handa <handa@m17n.org>
26
27 * dispextern.h (struct glyph): Change the bit length of
28 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
29
30 2012-03-24 Eli Zaretskii <eliz@gnu.org>
31
32 * s/ms-w32.h (tzname): Include time.h before redirecting to
33 _tzname. Fixes the MSVC build. (Bug#9960)
34
35 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
36
37 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
38 characters.
39
40 * xterm.c (XTread_socket): Only modify handling_signal if
41 !SYNC_INPUT. (Bug#11080)
42
43 2012-03-23 Eli Zaretskii <eliz@gnu.org>
44
45 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
46 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
47 when fetching a multibyte character consumes more bytes than
48 CHAR_BYTES returns, due to unification of CJK characters in
49 string_char. (Bug#11073)
50
51 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
52
53 * process.c (wait_reading_process_output): Handle pty disconnect
54 by refraining from sending oneself a SIGCHLD (bug#10933).
55
56 2012-03-22 Chong Yidong <cyd@gnu.org>
57
58 * dispextern.h (struct it): New member string_from_prefix_prop_p.
59
60 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
61 Mark string as coming from a prefix property.
62 (handle_face_prop): Use default face for prefix strings (Bug#4281).
63 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
64
65 2012-03-21 Chong Yidong <cyd@gnu.org>
66
67 * xfaces.c (Vface_remapping_alist): Doc fix.
68
69 2012-03-20 Eli Zaretskii <eliz@gnu.org>
70
71 * w32proc.c (Fw32_set_console_codepage)
72 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
73 Doc fixes.
74
75 2012-03-20 Chong Yidong <cyd@gnu.org>
76
77 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
78 to reflect default non-nil value of redisplay-dont-pause.
79
80 2012-03-19 Kenichi Handa <handa@m17n.org>
81
82 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
83 it fit in a valid range (Bug#11003).
84
85 2012-03-18 Eli Zaretskii <eliz@gnu.org>
86
87 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
88 that is not from display property, accept the row as a "cursor
89 row" if one of the string's character has a non-nil `cursor'
90 property. Fixes cursor positioning when there are newlines in
91 overlay strings, e.g. in icomplete.el. (Bug#11035)
92
93 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
94
95 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
96
97 2012-03-12 Chong Yidong <cyd@gnu.org>
98
99 * eval.c (inhibit_lisp_code): Rename from
100 inhibit_window_configuration_change_hook; move from window.c.
101
102 * xfns.c (unwind_create_frame_1, Fx_create_frame):
103 * window.c (run_window_configuration_change_hook)
104 (syms_of_window): Callers changed.
105
106 2012-03-11 Chong Yidong <cyd@gnu.org>
107
108 * keymap.c (Fkey_description): Doc fix (Bug#9700).
109
110 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
111
112 2012-03-10 Chong Yidong <cyd@gnu.org>
113
114 * frame.c (other_visible_frames): Don't assume the selected frame
115 is visible (Bug#10955).
116
117 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
118
119 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
120
121 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
122
123 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
124 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
125 zero (Bug#10954).
126
127 2012-03-03 Glenn Morris <rgm@gnu.org>
128
129 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
130
131 2012-03-02 Eli Zaretskii <eliz@gnu.org>
132
133 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
134 position past the first glyph_row that ends at ZV. (Bug#10902)
135 (redisplay_window, next_element_from_string): Fix typos in
136 comments.
137 (redisplay_window): Pass to move_it_vertically the margin in
138 pixels, not in screen lines.
139
140 2012-03-02 Glenn Morris <rgm@gnu.org>
141
142 * buffer.c (buffer-list-update-hook): Doc fix.
143
144 2012-02-29 Eli Zaretskii <eliz@gnu.org>
145
146 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
147 push_it before setting up the iterator for the first overlay
148 string, even if we have an empty string loaded.
149 (next_overlay_string): If there's an empty string on the iterator
150 stack, pop the stack. (Bug#10903)
151
152 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
153
154 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
155 Suggested by Stefan Monnier in
156 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
157 * alloc.c (widen_to_Lisp_Object): New static function.
158 (mark_memory): Also mark Lisp_Objects by fetching pointer words
159 and widening them to Lisp_Objects. This would work even if
160 USE_LSB_TAG is defined and wide integers are used, which might
161 happen in a future version of Emacs.
162
163 2012-02-25 Chong Yidong <cyd@gnu.org>
164
165 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
166 Doc fix.
167
168 * xselect.c (Fx_selection_exists_p): Doc fix.
169 (x_clipboard_manager_save_all): Print an informative message
170 before saving to clipboard manager.
171
172 2012-02-24 Chong Yidong <cyd@gnu.org>
173
174 * keyboard.c (process_special_events): Handle all X selection
175 requests in kbd_buffer, not just the next one (Bug#8869).
176
177 2012-02-23 Chong Yidong <cyd@gnu.org>
178
179 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
180 call when setting menu-bar-lines and tool-bar-lines parameters.
181 (unwind_create_frame_1): New helper function.
182
183 * window.c (inhibit_window_configuration_change_hook): New var.
184 (run_window_configuration_change_hook): Obey it.
185 (syms_of_window): Initialize it.
186
187 2012-02-22 Chong Yidong <cyd@gnu.org>
188
189 * xterm.c (x_draw_image_relief): Add missing type check for
190 Vtool_bar_button_margin (Bug#10743).
191
192 2012-02-21 Chong Yidong <cyd@gnu.org>
193
194 * fileio.c (Vfile_name_handler_alist): Doc fix.
195
196 * buffer.c (Fget_file_buffer): Protect against invalid file
197 handler return value.
198
199 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
200
201 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
202 when computing $valmask.
203
204 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
205 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
206 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
207 It's useless in that case, and it can cause problems on hosts
208 that allocate halves of EMACS_INT values separately.
209 Reported by Dan Horák. Diagnosed by Andreas Schwab in
210 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
211 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
212 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
213 it avoids undefined behavior on hosts where shifting right by more
214 than the word width has undefined behavior.
215
216 2012-02-19 Chong Yidong <cyd@gnu.org>
217
218 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
219 (Funhandled_file_name_directory, Ffile_name_as_directory)
220 (Fdirectory_file_name, Fexpand_file_name)
221 (Fsubstitute_in_file_name): Protect against invalid file handler
222 return values (Bug#10845).
223
224 2012-02-18 Eli Zaretskii <eliz@gnu.org>
225
226 * .gdbinit (pitx): Fix incorrect references to fields of the
227 iterator stack.
228
229 2012-02-17 Chong Yidong <cyd@gnu.org>
230
231 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
232
233 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
234
235 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
236 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
237
238 2012-02-15 Chong Yidong <cyd@gnu.org>
239
240 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
241 marked as special. Also, starting docstrings with * is obsolete.
242
243 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
244
245 * gnutls.c (emacs_gnutls_write): Fix last change.
246
247 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
248
249 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
250 send_process.
251
252 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
253
254 * keymap.c (Fsingle_key_description): Handle char ranges.
255
256 2012-02-12 Chong Yidong <cyd@gnu.org>
257
258 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
259 as that creates a dangerous corner case.
260
261 * window.c (Fdelete_window_internal): Invalidate the mouse
262 highlight (Bug#9904).
263
264 2012-02-12 Glenn Morris <rgm@gnu.org>
265
266 * xselect.c (Fx_own_selection_internal)
267 (Fx_get_selection_internal, Fx_disown_selection_internal)
268 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
269 * nsselect.m (Fx_own_selection_internal)
270 (Fx_disown_selection_internal, Fx_selection_exists_p)
271 (Fx_selection_owner_p, Fx_get_selection_internal):
272 Sync docs and argument specs with the xselect.c versions.
273
274 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
275
276 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
277
278 2012-02-11 Eli Zaretskii <eliz@gnu.org>
279
280 * w32select.c (Fx_selection_exists_p): Sync doc string and
281 argument list with xselect.c. (Bug#10783)
282
283 * w16select.c (Fx_selection_exists_p): Sync doc string and
284 argument list with xselect.c. (Bug#10783)
285
286 2012-02-10 Glenn Morris <rgm@gnu.org>
287
288 * fns.c (Fsecure_hash): Doc fix.
289
290 2012-02-09 Kenichi Handa <handa@m17n.org>
291
292 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
293
294 2012-02-07 Chong Yidong <cyd@gnu.org>
295
296 * buffer.c (Fbuffer_local_variables)
297 (buffer_lisp_local_variables): Handle unbound vars correctly;
298 don't let Qunbound leak into Lisp.
299
300 2012-02-07 Glenn Morris <rgm@gnu.org>
301
302 * image.c (Fimagemagick_types): Doc fix.
303
304 * image.c (imagemagick-render-type): Change it from a lisp object
305 to an integer. Move the doc here from the lisp manual.
306 Treat all values not equal to 0 the same.
307
308 2012-02-06 Chong Yidong <cyd@gnu.org>
309
310 * doc.c (store_function_docstring): Avoid applying docstring of
311 alias to base function (Bug#2603).
312
313 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
314
315 * .gdbinit (pp1, pv1): Remove redundant defines.
316 (pr): Use pp.
317
318 2012-02-04 Chong Yidong <cyd@gnu.org>
319
320 * nsterm.m: Declare a global (Bug#10694).
321
322 2012-02-04 Eli Zaretskii <eliz@gnu.org>
323
324 * w32.c (get_emacs_configuration_options):
325 Include --enable-checking, if specified, in the return value.
326
327 2012-02-04 Martin Rudalics <rudalics@gmx.at>
328
329 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
330 after rounding frame sizes. (Bug#9723)
331
332 2012-02-04 Eli Zaretskii <eliz@gnu.org>
333
334 * keyboard.c (adjust_point_for_property): Don't position point
335 before BEGV. (Bug#10696)
336
337 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
338
339 Handle overflow when computing char display width (Bug#9496).
340 * character.c (char_width): Return EMACS_INT, not int.
341 (char_width, c_string_width): Check for overflow when
342 computing the width; this is possible now that individual
343 characters can have unbounded width. Problem introduced
344 by merge from Emacs 23 on 2012-01-19.
345
346 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
347
348 * dbusbind.c (Fdbus_register_method): Mention the return value
349 :ignore in the docstring.
350
351 2012-02-02 Glenn Morris <rgm@gnu.org>
352
353 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
354
355 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
356 Unconditionally set to t. (Bug#10673)
357 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
358 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
359 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
360
361 2012-02-02 Kenichi Handa <handa@m17n.org>
362
363 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
364 0, do not call append_composite_glyph.
365
366 2012-02-02 Kenichi Handa <handa@m17n.org>
367
368 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
369 NULL (Bug#6988).
370 (x_produce_glyphs): If the component of a composition is a null
371 string, set it->pixel_width to 1 to avoid zero-width glyph.
372
373 2012-02-01 Eli Zaretskii <eliz@gnu.org>
374
375 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
376 first 2 arguments are identical. This makes inserting large
377 output from a subprocess an order of magnitude faster on
378 MS-Windows, where all sbrk'ed memory is always contiguous.
379
380 2012-01-31 Glenn Morris <rgm@gnu.org>
381
382 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
383 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
384 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
385
386 2012-01-29 Glenn Morris <rgm@gnu.org>
387
388 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
389
390 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
391
392 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
393
394 2012-01-28 Chong Yidong <cyd@gnu.org>
395
396 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
397
398 2012-01-26 Chong Yidong <cyd@gnu.org>
399
400 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
401
402 * search.c (Fsearch_forward, Fsearch_backward): Document negative
403 repeat counts (Bug#10507).
404
405 2012-01-26 Glenn Morris <rgm@gnu.org>
406
407 * lread.c (syms_of_lread): Doc fix.
408
409 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
410
411 * coding.c (encode_designation_at_bol): Change return value to
412 EMACS_INT.
413
414 2012-01-25 Chong Yidong <cyd@gnu.org>
415
416 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
417
418 2012-01-21 Chong Yidong <cyd@gnu.org>
419
420 * floatfns.c (Fcopysign): Make the second argument non-optional,
421 since nil is not allowed anyway.
422
423 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
424
425 * process.c (read_process_output): Use p instead of XPROCESS (proc).
426 (send_process): Likewise.
427
428 2012-01-19 Martin Rudalics <rudalics@gmx.at>
429
430 * window.c (save_window_save, Fcurrent_window_configuration)
431 (Vwindow_persistent_parameters): Do not use Qstate.
432 Rewrite doc-strings.
433
434 2012-01-19 Kenichi Handa <handa@m17n.org>
435
436 * character.c (char_width): New function.
437 (Fchar_width, c_string_width, lisp_string_width):
438 Use char_width (Bug#9496).
439
440 2012-01-16 Martin Rudalics <rudalics@gmx.at>
441
442 * window.c (Vwindow_persistent_parameters): New variable.
443 (Fset_window_configuration, save_window_save): Handle persistent
444 window parameters.
445
446 2012-01-14 Eli Zaretskii <eliz@gnu.org>
447
448 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
449 thrashing the stack of the thread. (Bug#9087)
450
451 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
452
453 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
454
455 2012-01-11 Eli Zaretskii <eliz@gnu.org>
456
457 * xdisp.c (rows_from_pos_range): Handle the case where the
458 highlight ends on a newline. (Bug#10464)
459 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
460 he end column for display of highlight that ends on a newline
461 before a R2L line.
462
463 2012-01-11 Glenn Morris <rgm@gnu.org>
464
465 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
466 from load-path also when installation-directory is nil. (Bug#10208)
467
468 2012-01-10 Glenn Morris <rgm@gnu.org>
469
470 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
471
472 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
473 Update template values to be closer to their typical values these days.
474
475 2012-01-09 Eli Zaretskii <eliz@gnu.org>
476
477 * xdisp.c (rows_from_pos_range): Accept additional argument
478 DISP_STRING, and accept any glyph in a row whose object is that
479 string as eligible for mouse highlight. Fixes mouse highlight of
480 display strings from overlays. (Bug#10464)
481
482 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
483
484 emacs: fix an auto-save permissions race condition (Bug#10400)
485 * fileio.c (auto_saving_dir_umask): New static var.
486 (Fmake_directory_internal): Use it.
487 (do_auto_save_make_dir): Set it, instead of invoking chmod after
488 creating the directory. The old code temporarily assigns
489 too-generous permissions to the directory.
490 (do_auto_save_eh): Clear it.
491 (Fdo_auto_save): Catch all errors, not just file errors, so
492 that the var is always cleared.
493
494 2012-01-07 Eli Zaretskii <eliz@gnu.org>
495
496 * search.c (scan_buffer): Pass character positions to
497 know_region_cache, not byte positions. (Bug#6540)
498
499 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
500
501 * w32.c (sys_rename): Report EXDEV when rename of a directory
502 fails because the target is on another logical disk. (Bug#10284)
503
504 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
505
506 * xterm.c (x_embed_request_focus): New function.
507
508 * xterm.h: Add prototype.
509
510 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
511
512 2012-01-05 Glenn Morris <rgm@gnu.org>
513
514 * emacs.c (emacs_copyright): Update short copyright year to 2012.
515
516 2012-01-01 Eli Zaretskii <eliz@gnu.org>
517
518 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
519 Load gnutls_transport_set_lowat only if GnuTLS version is below
520 2.11.1.
521 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
522 GnuTLS versions below 2.11.1.
523
524 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
525
526 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
527 to the doc string advising against its use for altering the way
528 windows are scrolled.
529
530 2011-12-28 Kenichi Handa <handa@m17n.org>
531
532 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
533 coding-system ASCII compatible only when it does not produce BOM
534 on encoding (Bug#10383).
535
536 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
537
538 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
539 can scroll.
540 (create_and_show_popup_menu): Always use menu_position_func for
541 Gtk3 (Bug#10361).
542
543 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
544
545 * callint.c (Fcall_interactively): Don't truncate prompt string.
546
547 2011-12-23 Eli Zaretskii <eliz@gnu.org>
548
549 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
550 property that ends at ZV, so that the bidi iteration could be
551 resumed from there (after widening). (Bug#10360)
552
553 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
554
555 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
556
557 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
558
559 * nsterm.m (x_free_frame_resources):
560 Release f->output_data.ns->miniimage.
561 (ns_index_color): Fix indentation. Do not retain
562 color_table->colors[i].
563
564 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
565 before returning.
566
567 * nsfns.m (x_set_background_color): Assign return value from
568 ns_index_color to face-background instead of NSColor*.
569 (ns_implicitly_set_icon_type): Fix indentation.
570 Change assignment in for loop to comparison.
571
572 * emacs.c (ns_pool): New variable.
573 (main): Assign ns_pool.
574 (Fkill_emacs): Call ns_release_autorelease_pool.
575
576 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
577 autorelease fdesc, release fdAttrs and tdict.
578 (ns_get_covering_families): Release charset.
579 (ns_findfonts): Release NSFontDescriptor created with new.
580 (ns_uni_to_glyphs): Fix indentation.
581 (setString): Release attrStr before assigning new value.
582
583 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
584
585 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
586 and NS_IMPL_COCOA.
587 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
588 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
589
590 2011-12-18 David Reitter <reitter@cmu.edu>
591
592 * nsterm.m (ns_term_init): Subscribe for notifications
593 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
594 to method trackingNotification in EmacsMenu.
595
596 * nsmenu.m (trackingMenu): New variable.
597 (trackingNotification): New method (from Aquamacs).
598 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
599 from Aquamacs (Bug#7030).
600
601 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
602
603 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
604 (symbol_to_nsstring): Fix indentation.
605 (ns_symbol_to_pb): New function.
606 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
607 (Fns_rotate_cut_buffers_internal): Remove.
608 (Fns_store_selection_internal): Rename from
609 Fns_store_cut_buffer_internal.
610 (ns_get_foreign_selection, Fx_own_selection_internal)
611 (Fx_disown_selection_internal, Fx_selection_exists_p)
612 (Fns_get_selection_internal, Fns_store_selection_internal):
613 Use ns_symbol_to_pb and check if return value is nil.
614 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
615 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
616 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
617 renamed to Sns_store_selection_internal.
618 (ns_handle_selection_request): Move code to Fx_own_selection_internal
619 and remove this function.
620 (ns_handle_selection_clear): Remove, never used.
621 (Fx_own_selection_internal): Move code from ns_handle_selection_request
622 here.
623
624 2011-12-17 Ken Brown <kbrown@cornell.edu>
625
626 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
627 GID is unknown (Bug#10257).
628
629 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
630
631 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
632 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
633 which caused a build failure on GNU/Linux IA-64. This problem was
634 introduced by my 2011-10-07 patch.
635
636 2011-12-15 Juri Linkov <juri@jurta.org>
637
638 * image.c (imagemagick_error): New function. (Bug#10112)
639 (imagemagick_load_image): Comment out `MagickSetResolution' call.
640 Use `imagemagick_error' where ImageMagick functions return
641 `MagickFalse'.
642 (Fimagemagick_types): Add `Fnreverse' to return the list in the
643 proper order.
644
645 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
646
647 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
648 fill background (Bug#8992).
649
650 2011-12-13 Martin Rudalics <rudalics@gmx.at>
651
652 * window.c (Vwindow_combination_resize)
653 (Vwindow_combination_limit): Use t instead of non-nil in
654 doc-strings.
655 (Vrecenter_redisplay): Add first sentence of doc-string on
656 separate line.
657 (Frecenter): Fix doc-string typo.
658
659 2011-12-11 Kenichi Handa <handa@m17n.org>
660
661 * coding.c (Funencodable_char_position): Pay attention to the
662 buffer text relocation (Bug#9389).
663
664 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
665
666 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
667 gtk_init (Bug#10100).
668
669 2011-12-10 Eli Zaretskii <eliz@gnu.org>
670
671 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
672 IT->string is nil. (Bug#10263)
673
674 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
675
676 * nsterm.h (x_free_frame_resources): Declare.
677
678 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
679 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
680
681 * nsterm.h (ns_get_defaults_value): Declare.
682
683 * nsterm.m (ns_default): Call ns_get_defaults_value.
684
685 2011-12-09 Eli Zaretskii <eliz@gnu.org>
686
687 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
688 (Bug#10170)
689
690 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
691
692 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
693 that where the value of an _OBJC_* symbol points to is in the .bss
694 section (Bug#10240).
695
696 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
697
698 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
699 after the loop to call ccl_driver at least once (Bug#8619).
700
701 2011-12-08 Kenichi Handa <handa@m17n.org>
702
703 * ftfont.c (get_adstyle_property): Fix previous change
704 (Bug#10233).
705
706 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
707
708 * w32.c (init_environment): If no_site_lisp, remove site-lisp
709 dirs from the default value of EMACSLOADPATH (bug#10208).
710
711 2011-12-07 Glenn Morris <rgm@gnu.org>
712
713 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
714 installation and source directories as well. (Bug#10208)
715
716 2011-12-06 Chong Yidong <cyd@gnu.org>
717
718 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
719
720 2011-12-06 Glenn Morris <rgm@gnu.org>
721
722 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
723 as an error, not just -1. (Bug#10217)
724
725 2011-12-05 Chong Yidong <cyd@gnu.org>
726
727 * keyboard.c (process_special_events): New function.
728 (swallow_events, Finput_pending_p): Use it (Bug#10195).
729
730 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
731
732 * coding.c (encode_designation_at_bol): Don't use uninitialized
733 local variable (Bug#9318).
734
735 2011-12-05 Kenichi Handa <handa@m17n.org>
736
737 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
738 return Qnil (Bug#8046, Bug#10193).
739
740 2011-12-05 Kenichi Handa <handa@m17n.org>
741
742 * coding.c (encode_designation_at_bol): New args charbuf_end and
743 dst. Return the number of produced bytes. Callers changed.
744 (coding_set_source): Return how many bytes coding->source was
745 relocated.
746 (coding_set_destination): Return how many bytes
747 coding->destination was relocated.
748 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
749 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
750
751 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
752
753 * coding.c (CODING_CHAR_CHARSET_P): New macro.
754 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
755 macro (Bug#9318).
756
757 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
758
759 The following changes are to fix Bug#9318.
760
761 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
762 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
763 (encode_coding_iso_2022, encode_coding_sjis)
764 (encode_coding_big5, encode_coding_charset): Use the above macros.
765
766 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
767
768 * lisp.h (process_quit_flag): Fix external declaration.
769
770 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
771
772 Don't macro-inline non-performance-critical code.
773 * eval.c (process_quit_flag): New function.
774 * lisp.h (QUIT): Use it.
775
776 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
777
778 * nsfns.m (get_geometry_from_preferences): New function.
779 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
780
781 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
782
783 * emacs.c (Qkill_emacs): Define.
784 (syms_of_emacs): Initialize it.
785 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
786 Qquit_flag to `kill-emacs' instead.
787 (quit_throw_to_read_char): Add parameter `from_signal'.
788 All callers changed. Call Fkill_emacs if requested and safe.
789 * lisp.h (QUIT): Call Fkill_emacs if requested.
790
791 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
792
793 * widget.c (update_wm_hints): Return if wmshell is null.
794 (widget_update_wm_size_hints): New function.
795
796 * widget.h (widget_update_wm_size_hints): Declare.
797
798 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
799 widget_update_wm_size_hints (Bug#10104).
800
801 2011-12-03 Eli Zaretskii <eliz@gnu.org>
802
803 * xdisp.c (handle_invisible_prop): If the invisible text ends just
804 before a newline, prepare the bidi iterator for consuming the
805 newline, and keep the current paragraph direction. (Bug#10183)
806 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
807
808 2011-12-02 Juri Linkov <juri@jurta.org>
809
810 * search.c (Fword_search_regexp): New Lisp function created from
811 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
812 (Fword_search_backward, Fword_search_forward)
813 (Fword_search_backward_lax, Fword_search_forward_lax):
814 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
815 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
816
817 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
818
819 * fileio.c (Finsert_file_contents): Move after-change-function call
820 to before the "handled:" label, since all "goto handled" appear in
821 cases where the *-change-functions have already been properly called
822 (bug#10117).
823
824 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
825
826 * keyboard.c (interrupt_signal): Don't call kill-emacs when
827 waiting for input. (Bug#10169)
828
829 2011-11-30 Eli Zaretskii <eliz@gnu.org>
830
831 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
832 verifies glyph row's hash code--we have just reallocated the
833 glyphs, so their contents can be complete garbage. (Bug#10164)
834
835 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
836
837 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
838
839 2011-11-30 Eli Zaretskii <eliz@gnu.org>
840
841 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
842 attributes are tested _before_ calling verify_row_hash, to protect
843 against GCC re-ordering of the tests. (Bug#10164)
844
845 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
846
847 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
848
849 * xterm.c (handle_one_xevent): Only set async_visible and friends
850 if net_wm_state_hidden_seen is non-zero (Bug#10002)
851 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
852 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
853
854 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
855
856 Remove GCPRO-related macros that exist only to avoid shadowing locals.
857 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
858 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
859 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
860 All uses changed to use GCPRO1 etc.
861 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
862 Revert to old implementation (i.e., before 2011-03-11).
863
864 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
865
866 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
867 of scroll runs so as to avoid assigning disabled bogus rows and
868 unnecessary graphics copy operations.
869
870 2011-11-27 Eli Zaretskii <eliz@gnu.org>
871
872 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
873 (snprintf) [_MSC_VER]: Redirect to _snprintf.
874 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
875 (malloc, free, realloc, calloc): Redirect to e_* only when
876 compiling Emacs.
877
878 * lisp.h (GCTYPEBITS): Move before first use.
879 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
880 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
881 this macro definition.
882
883 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
884 _MSC_VER.
885
886 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
887
888 * gtkutil.c (xg_create_frame_widgets):
889 Call gtk_window_set_has_resize_grip (FALSE) if that function is
890 present with Gtk+ 2.0.
891
892 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
893
894 * fileio.c (Finsert_file_contents): Undo previous change; see
895 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
896
897 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
898
899 Rename locals to avoid shadowing.
900 * fileio.c (Finsert_file_contents):
901 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
902 * process.c (wait_reading_process_output):
903 Rename inner 'proc' to 'p' to avoid shadowing.
904 Indent for consistency with usual Emacs style.
905
906 2011-11-25 Eli Zaretskii <eliz@gnu.org>
907
908 * xdisp.c (redisplay_window): If cursor row is not fully visible
909 after recentering, and scroll-conservatively is set to a large
910 number, scroll window by a few more lines to make the cursor fully
911 visible and out of scroll-margin. (Bug#10105)
912 (start_display): Don't move to the next line if the display should
913 start at a newline that is part of a display vector or an overlay
914 string. (Bug#10119)
915
916 2011-11-24 Juri Linkov <juri@jurta.org>
917
918 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
919 after the `MagickPingImage' call. (Bug#10112)
920
921 2011-11-23 Chong Yidong <cyd@gnu.org>
922
923 * window.c (Fcoordinates_in_window_p): Accept only live windows.
924
925 2011-11-23 Martin Rudalics <rudalics@gmx.at>
926
927 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
928 making another buffer current. (Bug#10114)
929
930 2011-11-23 Glenn Morris <rgm@gnu.org>
931
932 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
933
934 2011-11-23 Chong Yidong <cyd@gnu.org>
935
936 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
937 using it (Bug#5984).
938
939 2011-11-22 Eli Zaretskii <eliz@gnu.org>
940
941 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
942 and header-lines, as they don't have one computed for them.
943 (Bug#10098)
944
945 * .gdbinit (prow): Make displayed values more self-explaining.
946 Add row's hash code.
947
948 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
949
950 * process.c (wait_reading_process_output): Fix asynchrounous
951 GnuTLS socket handling on some versions of the GnuTLS library.
952 (wait_reading_process_output): Add comment and URL.
953
954 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
955
956 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
957
958 2011-11-21 Chong Yidong <cyd@gnu.org>
959
960 * window.c (Fnext_window, Fprevious_window): Doc fix.
961
962 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
963
964 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
965
966 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
967
968 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
969
970 2011-11-20 Martin Rudalics <rudalics@gmx.at>
971
972 * window.c (Fset_window_combination_limit): Rename argument
973 STATUS to LIMIT.
974 (Vwindow_combination_limit): Remove "status" from doc-string.
975
976 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
977
978 * m/ibms390.h: Remove.
979 * m/ibms390x.h: Don't include "ibms390.h".
980
981 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
982
983 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
984 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
985
986 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
987
988 * casetab.c (Fset_case_table):
989 * charset.c (Fcharset_after): Fix typos.
990
991 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
992
993 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
994 Otherwise, valgrind does not work on some platforms.
995 Problem reported by Andreas Schwab in
996 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
997 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
998 is set, removing the need for VIRT_ADDRESS_VARIES.
999 (PURE_P): Use a more-efficient implementation that needs just one
1000 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1001 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1002 to 4 (xorl, subq, cmpq, setbe).
1003 * alloc.c (pure): Always extern now, since that's the
1004 VIRT_ADDR_VARIES behavior.
1005 (PURE_POINTER_P): Use a single comparison, not two, for
1006 consistency with the new puresize.h.
1007 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1008 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1009 Remove VIRT_ADDR_VARIES no longer needed.
1010
1011 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1012
1013 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1014 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1015 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1016 behave as if the cursor position were at the window margin.
1017
1018 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1019 and the cursor position is out of bounds, behave as if the cursor
1020 position were at the window margin. (Bug#10075)
1021
1022 2011-11-18 Chong Yidong <cyd@gnu.org>
1023
1024 * window.c (Fwindow_combination_limit): Make first argument
1025 non-optional, since it is meaningless for live windows like the
1026 selected window.
1027
1028 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1029
1030 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1031
1032 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1033
1034 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1035 (graft_intervals_into_buffer): Simplify.
1036
1037 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1038
1039 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1040 hash values of the two rows.
1041 (copy_row_except_pointers): Preserve the used[] arrays and the
1042 hash values of the two rows. (Bug#10035)
1043 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1044
1045 * xdisp.c (row_hash): New function, body extracted from
1046 compute_line_metrics.
1047 (compute_line_metrics): Call row_hash, instead of computing the
1048 hash code inline.
1049
1050 * dispnew.c (verify_row_hash): Call row_hash for computing the
1051 hash code of a row, instead of duplicating code from xdisp.c.
1052
1053 * dispextern.h (row_hash): Add prototype.
1054
1055 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1056
1057 * frame.c (delete_frame): Don't delete the terminal when the last
1058 X frame is closed if emacs is built with GTK toolkit.
1059
1060 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1061
1062 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1063
1064 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1065
1066 * window.c (Vwindow_splits): Rename to
1067 Vwindow_combination_resize. Suggested by Juri Linkov.
1068 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1069 of Vwindow_splits.
1070
1071 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1072
1073 * nsfns.m (Fns_font_name):
1074 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1075
1076 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1077
1078 * window.h (window): Rename slot "nest" to "combination_limit".
1079 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1080 (Fset_window_nest): Rename to Fset_window_combination_limit.
1081 (Vwindow_nest): Rename to Vwindow_combination_limit.
1082 (recombine_windows, make_parent_window, make_window)
1083 (Fsplit_window_internal, saved_window)
1084 (Fset_window_configuration, save_window_save): Rename all
1085 occurrences of window_nest to window_combination_limit.
1086
1087 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1088
1089 * image.c (imagemagick_load_image): Fix typo.
1090
1091 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1092
1093 * xdisp.c (display_line): Move the call to
1094 highlight_trailing_whitespace before the call to
1095 compute_line_metrics, since the latter needs to see the final
1096 faces of all the glyphs to compute ROW's hash value.
1097 Fixes assertion violations in row_equal_p. (Bug#10035)
1098
1099 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1100
1101 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1102 just return (bug#10044).
1103
1104 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1105
1106 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1107 with user-defined heap size. Bump the default size of the temacs
1108 heap to 27MB, to avoid memory warning when running temacs.
1109 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1110
1111 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1112 current_matrix and desired_matrix. (Bug#9990)
1113 (verify_row_hash) [XASSERTS]: New function.
1114 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1115 that the hash value of glyph rows is correct.
1116
1117 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1118
1119 * window.h (window): Remove splits slot.
1120 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1121 (Fdelete_other_windows_internal, make_parent_window)
1122 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1123 (Fset_window_configuration, save_window_save): Don't deal with
1124 split status of windows.
1125 (saved_window): Remove splits slot.
1126 (Vwindow_splits): Rewrite doc-string.
1127
1128 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1129
1130 * xfns.c (unwind_create_frame):
1131 * nsfns.m (unwind_create_frame):
1132 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1133 Vframe_list (Bug#9999).
1134
1135 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1136
1137 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1138
1139 2011-11-11 Kenichi Handa <handa@m17n.org>
1140
1141 * callproc.c (Fcall_process): Set the member dst_multibyte of
1142 process_coding.
1143
1144 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1145
1146 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1147 avoid a crash (bug#9496).
1148
1149 2011-11-09 Chong Yidong <cyd@gnu.org>
1150
1151 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1152 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1153
1154 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1155
1156 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1157
1158 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1159
1160 Avoid some portability problems by eschewing 'extern inline' functions.
1161 The trivial performance wins aren't worth the portability hassles; see
1162 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1163 et seq.
1164 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1165 (window_box_width, window_box_left, window_box_left_offset)
1166 (window_box_right, window_box_right_offset): Undo previous change,
1167 by removing the "extern"s.
1168 * intervals.c (adjust_intervals_for_insertion)
1169 (adjust_intervals_for_deletion): Undo previous change,
1170 making these static again.
1171 (offset_intervals, temp_set_point_both, temp_set_point)
1172 (copy_intervals_to_string): No longer inline.
1173 * xdisp.c (window_text_bottom_y, window_box_width)
1174 (window_box_height, window_box_left_offset)
1175 (window_box_right_offset, window_box_left, window_box_right)
1176 (window_box): No longer inline.
1177
1178 2011-11-08 Chong Yidong <cyd@gnu.org>
1179
1180 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1181 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1182 Signal an error if not a live window.
1183 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1184 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1185
1186 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1187
1188 * lisp.h (syms_of_abbrev): Remove declaration.
1189 Reported by CHENG Gao <chenggao@royau.me>.
1190
1191 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1192
1193 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1194 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1195 of temacs in GUI mode.
1196
1197 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1198
1199 * window.h: Declare delete_all_child_windows instead of
1200 delete_all_subwindows.
1201 * window.c (Fwindow_nest, Fset_window_nest)
1202 (Fset_window_new_total, Fset_window_new_normal)
1203 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1204 (delete_all_subwindows): Rename to delete_all_child_windows.
1205 (Fdelete_other_windows_internal, Fset_window_configuration):
1206 Call delete_all_child_windows instead of delete_all_subwindows.
1207 * frame.c (delete_frame): Call delete_all_child_windows instead
1208 of delete_all_subwindows.
1209
1210 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1213 This is also needed for porting to any host where GC_MARK_STACK is
1214 not GC_MAKE_GCPROS_NOOPS.
1215 (which_symbols): Use it.
1216
1217 2011-11-07 Kenichi Handa <handa@m17n.org>
1218
1219 * coding.c (coding_set_destination): Check coding->src_pos only
1220 when coding->src_object is a buffer (bug#9910).
1221
1222 * process.c (send_process): Set the member src_multibyte of coding
1223 to 0 (bug#9911) when sending a unibyte text.
1224
1225 * callproc.c (Fcall_process): Set the member src_multibyte of
1226 process_coding to 0 (bug#9912).
1227
1228 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1229
1230 * xmenu.c (cleanup_widget_value_tree): New function.
1231 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1232 calling free_menubar_widget_value_tree directly (Bug#9830).
1233
1234 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1235
1236 Fix some portability problems with 'inline'.
1237 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1238 (window_box_width, window_box_left, window_box_left_offset)
1239 (window_box_right, window_box_right_offset): Declare extern.
1240 Otherwise, these inline functions do not conform to C99 and
1241 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1242 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1243 * intervals.c (adjust_intervals_for_insertion)
1244 (adjust_intervals_for_deletion): Now extern, because otherwise the
1245 extern inline functions 'offset_intervals' couldn't refer to it.
1246 (static_offset_intervals): Remove.
1247 (offset_intervals): Rewrite using the old contents of
1248 static_offset_intervals. The old version didn't conform to C99
1249 because an extern inline function contained a reference to an
1250 identifier with static linkage.
1251
1252 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1253
1254 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1255 GC.
1256
1257 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1258
1259 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1260 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1261 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1262 return Qleft_to_right.
1263
1264 2011-11-06 Chong Yidong <cyd@gnu.org>
1265
1266 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1267 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1268 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1269 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1270 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1271 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1272 (Fwindow_vscroll): Doc fix.
1273 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1274 argument, since it makes no sense to pass a live window and for
1275 consistency with window-child.
1276
1277 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1278
1279 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1280 support MSVC.
1281
1282 2011-11-05 Jason Rumney <jasonr@gnu.org>
1283
1284 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1285 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1286 fonts (Bug#6029).
1287 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1288 bitwise arithmetic preventing use of unicode-sip and non-truetype
1289 opentype fonts.
1290
1291 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1292
1293 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1294 "emacs"-only part.
1295
1296 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1297 initialization code to keep similarity to xfns.c after changes
1298 from 2011-11-05.
1299
1300 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1301
1302 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1303 (unwind_create_frame): New function (Bug#9943).
1304 (Fx_create_frame): Restructure code to be more similar to the one in
1305 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1306 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1307 Move terminal->reference_count++ just before making the frame official
1308 (Bug#9943).
1309
1310 * nsterm.m (x_free_frame_resources): New function.
1311 (x_destroy_window): Move code to x_free_frame_resources.
1312
1313 * xfns.c (unwind_create_frame): Fix comment.
1314 (Fx_create_frame, x_create_tip_frame):
1315 Move terminal->reference_count++ just before making the frame
1316 official. Move initialization of image_cache_refcount and
1317 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1318
1319 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1320
1321 Support MSVC build with newer versions of Visual Studio.
1322 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1323 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1324 nt/gmake.defs.
1325
1326 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1327 which are not supported by MSVC.
1328 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1329 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1330 bitfields.
1331 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1332 types in bitfields.
1333 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1334
1335 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1336
1337 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1338
1339 Support MSVC build with newer versions of Visual Studio.
1340 * w32.c: Don't include w32api.h for MSVC.
1341 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1342
1343 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1344 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1345 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1346 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1347 e_* cousins.
1348 (alloca) [_MSC_VER]: Define to _alloca.
1349
1350 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1351
1352 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1353
1354 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1355
1356 * xdisp.c (note_mouse_highlight): If either of
1357 previous/next-single-property-change returns nil, treat that as
1358 the beginning or the end of the buffer. (Bug#9955)
1359
1360 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1361
1362 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1363 label is not null (Bug#9951).
1364 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1365 may be NULL.
1366
1367 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1368
1369 * window.c (Fwindow_body_size): Mention in the doc string that the
1370 return value is in frame's canonical units. (Bug#9949)
1371
1372 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1373
1374 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1375
1376 * w32fns.c (unwind_create_frame): If needed, free the glyph
1377 matrices of the partially constructed frame. (Bug#9943)
1378 * xfns.c (unwind_create_frame): Likewise.
1379
1380 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1381
1382 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1383 Don't stop backward scan on the continuation glyph, even though
1384 its CHARPOS is positive.
1385 (mouse_face_from_buffer_pos, note_mouse_highlight):
1386 Rename cover_string to disp_string.
1387
1388 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1389
1390 * window.c (temp_output_buffer_show): Don't use
1391 Vtemp_buffer_show_specifiers.
1392 (Vtemp_buffer_show_specifiers): Remove unused variable.
1393
1394 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1395
1396 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1397 past the beginning of the current glyph matrix.
1398
1399 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1400
1401 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1402 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1403 HAVE_GTK3 (Bug#9869).
1404
1405 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1406 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1407
1408 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1409
1410 * xterm.c: Declare x_handle_net_wm_state to return int.
1411 (handle_one_xevent): Check if we are iconified but don't have
1412 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1413 (get_current_wm_state): Return non-zero if not hidden,
1414 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1415 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1416 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1417 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1418
1419 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1420
1421 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1422 so that this new function doesn't get optimized away by a
1423 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1424
1425 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1426
1427 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1428
1429 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1430
1431 Fix the `xbytecode' command.
1432 * .gdbinit (xprintbytestr): New command.
1433 (xwhichsymbols): Rename from `which'; all callers changed.
1434 (xbytecode): Print the byte-code string as well.
1435
1436 2011-10-29 Kim Storm <storm@cua.dk>
1437
1438 * alloc.c (which_symbols): New function.
1439
1440 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1441
1442 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1443 line. (Bug#9903)
1444
1445 2011-10-29 Glenn Morris <rgm@gnu.org>
1446
1447 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1448 Not clear what it was for, and it causes various bugs. (Bug#9839)
1449
1450 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1451
1452 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1453 possible random value that matches one of those tested as
1454 condition to clear the mouse face.
1455
1456 2011-10-28 Chong Yidong <cyd@gnu.org>
1457
1458 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1459
1460 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1461
1462 * window.c (make_window): Initialize phys_cursor_on_p.
1463
1464 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1465
1466 * lisp.h (struct Lisp_Symbol): Update comments.
1467
1468 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1469
1470 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1471
1472 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1473
1474 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1475 <oslsachem@gmail.com> for helping to debug this.
1476
1477 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1478 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1479 (g_b_init_get_glyph_outline_w): New static variables.
1480 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1481 (GetGlyphOutlineW_Proc): New typedefs.
1482 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1483 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1484 New functions.
1485 (w32font_open_internal, compute_metrics):
1486 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1487 instead of calling the "wide" APIs directly.
1488
1489 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1490
1491 * w32.h (syms_of_w32font): Add prototype.
1492
1493 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1494
1495 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1496 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1497 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1498 (Fmove_to_window_line): Doc fix.
1499
1500 2011-10-27 Chong Yidong <cyd@gnu.org>
1501
1502 * process.c (make_process): Set gnutls_state to NULL.
1503
1504 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1505 non-NULL, regardless of GNUTLS_INITSTAGE.
1506 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1507 an error. Set process slots as soon as we allocate them.
1508
1509 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1510
1511 2011-10-27 Chong Yidong <cyd@gnu.org>
1512
1513 * gnutls.c (emacs_gnutls_deinit): New function.
1514 Deallocate credentials structures as well as calling gnutls_deinit.
1515 (Fgnutls_deinit, Fgnutls_boot): Use it.
1516
1517 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1518 (deactivate_process): Call emacs_gnutls_deinit.
1519
1520 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1521
1522 * image.c (x_create_x_image_and_pixmap):
1523 * w32.c (sys_rename, w32_delayed_load):
1524 * w32font.c (fill_in_logfont):
1525 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1526
1527 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1528
1529 * w32fns.c (w32_default_color_map): New function,
1530 extracted from Fw32_default_color_map.
1531 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1532
1533 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1534
1535 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1536
1537 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1538
1539 * keyboard.c (test_undefined): New function (bug#9751).
1540 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1541
1542 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1543
1544 * sysdep.c (init_sys_modes): Fix the check for the controlling
1545 terminal (Bug#6649).
1546
1547 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1548
1549 * dispextern.h (struct bidi_it): New member next_en_type.
1550
1551 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1552 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1553 current character, check also for next_en_type being WEAK_EN.
1554 (bidi_resolve_weak): Don't enter the expensive loop if the current
1555 position is before next_en_pos. Record the bidi type of the first
1556 non-ET, non-BN character we find, in addition to its position.
1557 (bidi_level_of_next_char): Invalidate next_en_type when
1558 next_en_pos is over-stepped.
1559
1560 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1563 * editfns.c: Rewrite current-time-zone so that it invokes
1564 the equivalent of (format-time-string "%Z") to get the time zone name.
1565 This fixes a bug when the time zone name contains characters that
1566 need converting from the system time locale to Emacs internal format.
1567 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1568 that patch fixed format-time-string to do the conversion, but
1569 I forgot to fix current-time-zone.
1570 (format_time_string): New function, containing most of
1571 what Fformat_time_string used to contain.
1572 (Fformat_time_string): Rewrite in terms of format_time_string.
1573 This doesn't change this function's behavior.
1574 (current-time-zone): Rewrite to use format_time_string.
1575 This fixes the bug reported by Michael Schierl in
1576 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1577 Jason Rumney's 2007-06-07 change worked around this bug, but
1578 didn't fix it.
1579 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1580
1581 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1582
1583 * xdisp.c (start_display): If the character at POS is displayed
1584 via a display vector, reset IT->current.dpvec_index to zero.
1585 (try_window_reusing_current_matrix): If a line ends in a display
1586 vector or the next line starts in a display vector, continue
1587 redrawing the window even though the character position of
1588 start_row was reached.
1589 (Bug#9771, part 2)
1590
1591 2011-10-18 Chong Yidong <cyd@gnu.org>
1592
1593 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1594 with nobreak-char-display too.
1595
1596 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1597
1598 Fix part 3 of bug#9771.
1599 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1600 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1601 non-neutral characters if the current character is a paragraph
1602 separator (a.k.a. Newline). This avoids running the same
1603 expensive loop twice, once when we consume the preceding newline
1604 and the other time when the line actually needs to be displayed.
1605 Avoid the loop when we see neutrals on the base embedding level
1606 following a character whose directionality is the same as the
1607 paragraph's. This avoids running the expensive loop when a line
1608 ends in a long sequence of neutrals, like control characters.
1609 Add assertion against STRONG_AL type. Slightly rearrange code
1610 that determines the type of a neutral given the first non-neutral
1611 that follows it.
1612 (bidi_level_of_next_char): Set next_en_pos to zero when
1613 invalidating its info.
1614
1615 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1616
1617 * xdisp.c (push_display_prop): Determine whether to record string
1618 or buffer position by IT->string, not by IT->method. Allow
1619 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1620 (move_it_vertically_backward): Don't look for character position
1621 immediately after the newline when in a continuation line.
1622 (Bug#9771, part 1)
1623
1624 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1625
1626 * window.c (coordinates_in_window): Rewrite and delabelize
1627 vertical border check. (Bug#5357) (Bug#9618)
1628
1629 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1630
1631 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1632 errors in XSetWindowBorder (bug#9310).
1633
1634 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1635
1636 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1637 avoid crash when xmalloc overrun checking is enabled.
1638
1639 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1640
1641 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1642 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1643 cursor motion with <left> and <right> arrow keys.
1644
1645 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1646 some callers set that themselves.
1647
1648 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1649
1650 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1651 display string and the previous row comes from the same string and
1652 is empty. (Bug#9739) (Bug#9738)
1653
1654 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1655
1656 * doc.c (get_doc_string): Encode file name (bug#9735).
1657
1658 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1659
1660 * bidi.c (bidi_level_of_next_char):
1661 * xdisp.c (get_visually_first_element): Remove old incorrect
1662 comments regarding the Unicode Line Separator character.
1663
1664 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1665
1666 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1667
1668 * alloc.c (Fgc_status): Do not access beyond zombies array
1669 boundary if nzombies > MAX_ZOMBIES.
1670 * alloc.c (dump_zombies): Add missing format specifier.
1671
1672 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1675 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1676
1677 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1678 Some packages use them to denote characters with modifiers.
1679
1680 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1681
1682 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1683 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1684 matching a pp-number. Rename parameter var to var1.
1685
1686 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1687
1688 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1689
1690 2011-10-08 Glenn Morris <rgm@gnu.org>
1691
1692 * callint.c (Fcall_interactively): Give a more explicit error for the
1693 'c' case with a non-character input. (Bug#8479)
1694
1695 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1696
1697 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1698 lines.
1699 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1700 lines that are hscrolled on the left.
1701
1702 * dispnew.c (buffer_posn_from_coords): Account for a possible
1703 presence of header-line. (Bug#4426)
1704
1705 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1706
1707 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1708 Don't advertise functionality which we discourage or doesn't work.
1709
1710 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1713 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1714 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1715 this makes Emacs dump core during garbage collection on rare
1716 occasions. sizeof is obviously inferior to offsetof here, so
1717 stick with offsetof.
1718 (GC_POINTER_ALIGNMENT): New macro.
1719 (mark_memory): Omit 3rd (offset) arg; caller changed.
1720 Don't assume EMACS_INT alignment is the same as pointer alignment.
1721
1722 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1723
1724 * keyboard.c (read_key_sequence_remapped): New var.
1725 (read_key_sequence): Compute remapping in the right buffer.
1726 (command_loop_1): Use read_key_sequence's remapping directly.
1727
1728 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1729
1730 * dired.c (file_name_completion): Don't expand file name.
1731 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1732 before checking file name handler.
1733
1734 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1735 they've been requested explicitly (bug#9591).
1736
1737 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1738
1739 * keymap.c (Fsingle_key_description): Use make_specified_string
1740 instead of build_string to build string from push_key_description.
1741 (Bug#5193)
1742
1743 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1746 This fixes a Y2038 bug on 64-bit hosts.
1747 * buffer.c (reset_buffer):
1748 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1749 (Fclear_buffer_auto_save_failure):
1750 Use 0, not -1, to represent an unset failure time, since time_t
1751 might not be signed.
1752
1753 Remove dependency on glibc malloc internals.
1754 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1755 Move back here from lisp.h, but with their new implementations.
1756 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1757 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1758 * charset.c (charset_table_init): New static var.
1759 (syms_of_charset): Use it instead of xmalloc. This removes a
1760 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1761 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1762 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1763 Move back to alloc.c.
1764 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1765 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1766
1767 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1768
1769 * nsterm.m (windowDidResize): Call x_set_window_size only when
1770 ns_in_resize is true. Otherwise set pixelwidth/height and
1771 call change_frame_size (Bug#9628).
1772
1773 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1774
1775 Port --enable-checking=all to Fedora 14 x86-64.
1776 * charset.c (syms_of_charset): Also account for glibc malloc's
1777 internal overhead when calculating the initial malloc maximum.
1778
1779 Port --enable-checking=all to Fedora 14 x86.
1780 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1781 Move to lisp.h.
1782 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1783 (overrun_check_realloc, overrun_check_free):
1784 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1785 That way, xmalloc returns a properly-aligned pointer even if
1786 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1787 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1788 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1789 into account when calculating the initial malloc maximum.
1790 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1791 Move here from alloc.c, so that charset.c can use it too.
1792 Properly align; the old code wasn't right for common 32-bit hosts
1793 when configured with --enable-checking=all.
1794 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1795 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1796
1797 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1798
1799 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1800 use EDOM.
1801
1802 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1803
1804 * xdisp.c (compute_display_string_end): If there's no display
1805 string at CHARPOS, return -1.
1806
1807 * bidi.c (bidi_fetch_char): When compute_display_string_end
1808 returns a negative value, treat the character as a normal
1809 character not covered by a display string. (Bug#9624)
1810
1811 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1812
1813 * lread.c (Fread_from_string): Fix typo in docstring.
1814
1815 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1816
1817 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1818 newline, reseat the iterator instead of bidi-iterating there one
1819 character at a time. (Bug#9610)
1820 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1821 TO_CHARPOS if the bidi iterator is at base embedding level.
1822
1823 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1824
1825 * lread.c (readevalloop): Use correct code for NBSP.
1826 (read1): Likewise. (Bug#9608)
1827
1828 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1829
1830 * dbusbind.c (Fdbus_register_signal): When service is not
1831 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1832
1833 2011-09-25 Glenn Morris <rgm@gnu.org>
1834
1835 * buffer.c (truncate-lines): Doc fix.
1836
1837 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1838
1839 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1840 (Fset_window_next_buffers): Doc fix.
1841
1842 2011-09-24 Glenn Morris <rgm@gnu.org>
1843
1844 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1845
1846 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1847
1848 Fix minor problems found by static checking.
1849 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1850 * indent.c (Fvertical_motion): Fix == vs = typo.
1851
1852 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1853
1854 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1855 Default value is now t. Doc fix.
1856
1857 * indent.c (Fvertical_motion): Compute and apply the overshoot
1858 logic when moving up, not only when moving down. Fix the
1859 confusing name and values of the it_overshoot_expected variable;
1860 logic changes accordingly. (Bug#9254) (Bug#9549)
1861
1862 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1863 CHARPOS is covered by a display string which includes newlines.
1864 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1865 is covered by a display string with embedded newlines.
1866
1867 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1868
1869 * dbusbind.c (Fdbus_register_signal): Add match rule to
1870 Vdbus_registered_objects_table. (Bug#9581)
1871 (Fdbus_register_method, Vdbus_registered_objects_table):
1872 Fix docstring.
1873
1874 2011-09-24 Jim Meyering <meyering@redhat.com>
1875
1876 do not ignore write error for any output size
1877 The previous change was incomplete.
1878 While it makes emacs --batch detect the vast majority of stdout
1879 write failures, errors were still ignored whenever the output size is
1880 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1881 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1882 && echo FAIL: ignored write error
1883 FAIL: ignored write error
1884 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1885 && echo FAIL: ignored write error
1886 FAIL: ignored write error
1887 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1888
1889 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1890
1891 * emacs.c (Fkill_emacs): In noninteractive mode exit
1892 non-successfully if a write error occurred on stdout. (Bug#9574)
1893
1894 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1895
1896 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1897 the xassert test.
1898
1899 * dispextern.h (struct it): Update the comment documenting what
1900 can it->OBJECT be.
1901
1902 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1903
1904 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1905 a display string, extend search for cursor position to end of row.
1906 (find_row_edges): If the row ends in a newline from a display
1907 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1908 Handle the case of a display string with multiple newlines.
1909 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1910 non-empty line. Fixes confusing cursor motion with arrow keys at
1911 the beginning of a line that starts with whitespace.
1912
1913 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1914
1915 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1916 (bug#9493).
1917
1918 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1919
1920 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1921 boolean (Bug#9154).
1922
1923 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1924
1925 * xdisp.c (display_line): Record maximum and minimum buffer
1926 positions even if no glyphs were produced (e.g., by a zero-width
1927 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1928 buffer positions that will be removed from the glyph row because
1929 they don't fit.
1930 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1931 column is beyond frame width: don't subtract 1 "pixel" when
1932 computing width of the stretch.
1933 (reseat_at_next_visible_line_start): Undo the change made on
1934 2011-09-17 that saved paragraph information and restored it after
1935 the call to `reseat'. (Bug#9545)
1936
1937 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1938
1939 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1940 and turn window cursor on if cleared (Bug#9415).
1941
1942 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1943
1944 * search.c (boyer_moore): Take unibyte characters from pattern
1945 literally. (Bug#9458)
1946
1947 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1948
1949 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1950
1951 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1952
1953 Fix minor problem found by static checking.
1954 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1955 initialized, to pacify gcc -Wuninitialized.
1956
1957 * fileio.c: Report proper errno when syscall falls.
1958 (Finsert_file_contents): Save and restore errno,
1959 so that report_file_error outputs the correct diagnostic.
1960 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1961
1962 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1963
1964 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1965
1966 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1967
1968 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1969 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1970
1971 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1972
1973 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1974 about the current paragraph and restore it after the call to reseat.
1975
1976 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1977 (bidi_find_paragraph_start): Search back for paragraph beginning
1978 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1979 (bidi_move_to_visually_next): Only trigger paragraph-related
1980 computations when the last character is a newline or at EOB, not
1981 just any NEUTRAL_B. (Bug#9470)
1982
1983 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1984 truncated lines if point is covered by a display string. (Bug#9524)
1985
1986 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1987
1988 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1989 (cons_to_x_long): New function.
1990 (lisp_data_to_selection_data): Use it. Correct the test for
1991 short-versus-long data; it was negated. Break out of vector
1992 loop, for efficiency, when a long datum is discovered.
1993
1994 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1995
1996 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1997
1998 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1999
2000 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2001 GCC PR/17406) by declaring this function with external scope.
2002
2003 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2006 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2007
2008 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2009
2010 * editfns.c (Fformat): Correctly handle text properties on "%%".
2011
2012 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2013
2014 * xterm.c (x_draw_composite_glyph_string_foreground):
2015 * w32term.c (x_draw_composite_glyph_string_foreground):
2016 * term.c (encode_terminal_code):
2017 * composite.c (composition_update_it, get_composition_id):
2018 * xdisp.c (get_next_display_element)
2019 (fill_composite_glyph_string): Add comments about special meaning
2020 of TAB characters in a composition.
2021
2022 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2025 This occurs when processing a multibyte format.
2026 Problem reported by Wolfgang Jenker.
2027
2028 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2029
2030 * xdisp.c (try_cursor_movement): Only check for exact match if
2031 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2032
2033 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2034
2035 Remove unused external symbols.
2036 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2037 * xdisp.c (calc_pixel_width_or_height): Now static.
2038 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2039 * indent.c (check_display_width):
2040 * w32term.c: Fix comment to match code.
2041 * xterm.c, xterm.h (x_catching_errors): Remove.
2042
2043 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 * xselect.c: Use signed conversions more consistently (Bug#9498).
2046 (selection_data_to_lisp_data): Assume incoming selection data are
2047 signed integers, not unsigned. This is to be consistent with
2048 outgoing selection data, which was modified to use signed integers
2049 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2050 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2051 expects long, not unsigned long.
2052
2053 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2054
2055 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2056 computation of loop end. Reported by Johan Bockgård
2057 <bojohan@gnu.org>.
2058
2059 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2060
2061 * frame.c (Fother_visible_frames_p): Function deleted.
2062
2063 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2064
2065 * indent.c (compute_motion): Process display vector front to back
2066 rather than the other way around. (Bug#2496)
2067
2068 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2069
2070 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2071
2072 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2073
2074 * minibuf.c (Fread_from_minibuffer): Doc fix.
2075
2076 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2077
2078 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2079 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2080
2081 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2082
2083 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2084 value for non-existent files.
2085
2086 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2087
2088 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2089 set its "size" to -1. This will set the modtime_size field of
2090 the corresponding buffer to -1, which is what
2091 verify-visited-file-modtime expects for files that do not exist.
2092 (Bug#9139)
2093
2094 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2095
2096 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2097 here ...
2098 * lisp.h: ... from here. push_key_description is no longer
2099 defined in keyboard.c, so its declaration should not be in
2100 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2101 logically belongs with push_key_description.
2102
2103 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2104
2105 * buffer.h: Include <sys/types.h> instead of <time.h>.
2106 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2107 Problem reported by Herbert J. Skuhra.
2108
2109 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2110
2111 * xml.c (parse_region): Make the parsing work for
2112 non-comment-starting XML files again (bug#9144).
2113
2114 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2115
2116 * image.c (gif_load): Fix calculation of bottom and right corner.
2117 (Bug#9468)
2118
2119 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2120
2121 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2122 redisplay in small windows.
2123
2124 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2125
2126 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2127
2128 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2129
2130 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2131 Operate on live windows only.
2132
2133 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2134
2135 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2136
2137 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2138
2139 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2140 only under bidi iteration.
2141
2142 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2143
2144 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2145
2146 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2149 Without this fix, the command to link temacs failed due to an
2150 undefined symbol __builtin_isnan. This is because
2151 /usr/include/iso/math_c99.h #defines isnan(x) to
2152 __builtin_isnan(x), but the bundled gcc, which identifies itself
2153 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2154 a __builtin_isnan.
2155 * floatfns.c (isnan): #undef, and then #define to a clone of
2156 what's in data.c.
2157 (Fisnan): Always define, since it's always available now.
2158 (syms_of_floatfns): Always define isnan at the Lisp level.
2159
2160 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2161
2162 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2163
2164 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2165
2166 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2167 The previous code assumed that file offsets (off_t values) fit in
2168 EMACS_INT variables, which is not true on typical 32-bit hosts.
2169 The code messed up by falsely reporting buffer overflow in cases
2170 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2171 when "big" contains more than 2**29 bytes, even though this
2172 inserts just one byte and does not overflow the buffer.
2173 (Finsert_file_contents): Store file offsets as off_t
2174 values, not as EMACS_INT values. Check for overflow when
2175 converting between EMACS_INT and off_t. When checking for
2176 buffer overflow or for overlap, take the offsets into account.
2177 Don't use EMACS_INT for small values where int suffices.
2178 When checking for overlap, fix a typo: ZV was used where
2179 ZV_BYTE was intended.
2180 (Fwrite_region): Don't assume off_t fits into 'long'.
2181 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2182
2183 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2184
2185 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2186
2187 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 sprintf-related integer and memory overflow issues (Bug#9412).
2190
2191 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2192 (esprintf, exprintf, evxprintf): New functions.
2193 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2194 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2195 (modify_event_symbol): Do not assume that the length of
2196 name_alist_or_stem is safe to alloca and fits in int.
2197 (Fexecute_extended_command): Likewise for function name and binding.
2198 (Frecursion_depth): Wrap around reliably on integer overflow.
2199 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2200 since some callers pass EMACS_INT values.
2201 (Fsingle_key_description): Don't crash if symbol name contains more
2202 than MAX_ALLOCA bytes.
2203 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2204 (get_minibuffer): Arg is now EMACS_INT, not int.
2205 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2206 (esprintf, exprintf, evxprintf): New decls.
2207 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2208
2209 * dbusbind.c (signature_cat): New function.
2210 (xd_signature, Fdbus_register_signal):
2211 Do not overrun buffer; instead, report string overflow.
2212
2213 * dispnew.c (add_window_display_history): Don't overrun buffer.
2214 Truncate instead; this is OK since it's just a log.
2215
2216 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2217 even if the time zone offset is outlandishly large.
2218 Don't mishandle offset == INT_MIN.
2219
2220 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2221 when creating daemon; the previous buffer-overflow check was incorrect.
2222
2223 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2224 which has the guts of the old verror function.
2225
2226 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2227 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2228
2229 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2230 (font_unparse_xlfd): Don't blindly alloca long strings.
2231 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2232 fits in int, when using sprintf. Use single snprintf to count
2233 length of string rather than counting it via multiple sprintfs;
2234 that's simpler and more reliable.
2235 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2236 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2237 sprintf, in case result does not fit in int.
2238
2239 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2240 (fontset_from_font): Print it.
2241
2242 * frame.c (tty_frame_count): Now printmax_t, not int.
2243 (make_terminal_frame, set_term_frame_name): Print it.
2244 (x_report_frame_params): In X, window IDs are unsigned long,
2245 not signed long, so print them as unsigned.
2246 (validate_x_resource_name): Check for implausibly long names,
2247 and don't assume name length fits in 'int'.
2248 (x_get_resource_string): Don't blindly alloca invocation name;
2249 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2250 not fit in int.
2251
2252 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2253 (xg_check_special_colors, xg_set_geometry):
2254 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2255
2256 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2257 Use esprintf, not sprintf, in case result does not fit in int.
2258
2259 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2260 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2261 it as a large positive number.
2262 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2263 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2264
2265 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2266 in case result does not fit in int.
2267
2268 * print.c (float_to_string): Detect width overflow more reliably.
2269 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2270 buffer overrun. Don't assume list length fits in 'int'. Treat
2271 print length of 0 as 0, not as infinity; to be consistent with other
2272 uses of print length in this function. Don't overflow print length
2273 index. Don't assume hash table size fits in 'long', or that
2274 vectorlike size fits in 'unsigned long'.
2275
2276 * process.c (make_process): Use printmax_t, not int, to format
2277 process-name gensyms.
2278
2279 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2280
2281 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2282 to avoid potential buffer overrun.
2283
2284 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2285 if X resource line is longer than 512 bytes.
2286
2287 * xfns.c (x_window): Make sprintf buffer a bit bigger
2288 to avoid potential buffer overrun.
2289
2290 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2291
2292 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2293
2294 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2295
2296 Integer overflow fixes for scrolling, etc.
2297 Without these, Emacs silently mishandles large integers sometimes.
2298 For example, "C-u 4294967297 M-x recenter" was treated as if
2299 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2300
2301 * xdisp.c (try_window_id): Check Emacs fixnum range before
2302 converting to 'int'.
2303
2304 * window.c (window_scroll_line_based, Frecenter):
2305 Check that an Emacs fixnum is in range before assigning it to 'int'.
2306 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2307 values converted from Emacs fixnums.
2308 (Frecenter): Don't wrap around a line count if it is out of 'int'
2309 range; instead, treat it as an extreme value.
2310 (Fset_window_configuration, compare_window_configurations):
2311 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2312
2313 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2314 that can exceed INT_MAX. Check that EMACS_INT value is in range
2315 before assigning it to the (possibly-narrower) index.
2316 (match_limit): Don't assume that a fixnum can fit in 'int'.
2317
2318 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2319 exceed INT_MAX.
2320
2321 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2322 (Fvertical_motion): Don't wrap around LINES values that don't fit
2323 in 'int'. Instead, treat them as extreme values. This is good
2324 enough for windows, which can't have more than INT_MAX lines anyway.
2325
2326 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2327
2328 * Require libxml/parser.h to avoid compilation warning.
2329
2330 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2331
2332 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2333 since this reportedly can destroy thread storage.
2334
2335 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2336
2337 * syntax.c (find_defun_start): Update all cache variables if
2338 exiting early (Bug#9401).
2339
2340 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2341
2342 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2343
2344 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2345 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2346 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2347
2348 * term.c (tty_append_glyph): New function.
2349 (produce_stretch_glyph): Static function and its prototype deleted.
2350
2351 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2352 Add prototypes.
2353
2354 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2355
2356 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2357 when checking :margin (Bug#9390).
2358 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2359 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2360 so that the name doesn't mislead. All uses changed.
2361
2362 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2363
2364 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2365 set_tty_hooks.
2366
2367 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2368
2369 * xdisp.c (move_it_to): Don't bail out early when reaching
2370 position beyond to_charpos, if we are scanning backwards.
2371 (move_it_vertically_backward): When DY == 0, make sure we get to
2372 the first character in the line after the newline.
2373
2374 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2377 (ccl_driver): Do not generate an out-of-range pointer.
2378 (Fccl_execute_on_string): Remove unnecessary check for
2379 integer overflow, noted by Stefan Monnier in
2380 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2381 Remove a FIXME that didn't need fixing.
2382 Simplify the newly-introduced buffer reallocation code.
2383
2384 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2385
2386 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2387
2388 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2389
2390 Integer and memory overflow issues (Bug#9196).
2391
2392 * doc.c (get_doc_string): Rework so that
2393 get_doc_string_buffer_size is the actual buffer size, rather than
2394 being 1 less than the actual buffer size; this makes xpalloc more
2395 convenient.
2396
2397 * image.c (x_allocate_bitmap_record, cache_image):
2398 * xselect.c (Fx_register_dnd_atom):
2399 Simplify previous changes by using xpalloc.
2400
2401 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2402 since either will do and ptrdiff_t is convenient with xpalloc.
2403
2404 * charset.c (charset_table_size)
2405 (struct charset_sort_data.priority): Now ptrdiff_t.
2406 (charset_compare): Don't overflow if priorities differ greatly.
2407 (Fsort_charsets): Don't assume list length fits in int.
2408 Check for size-calculation overflow when allocating sort data.
2409 (syms_of_charset): Allocate an initial charset table that is
2410 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2411
2412 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2413
2414 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2415 The actual value is always <= INT_MAX, and leaving it unsigned made
2416 overflow checking harder.
2417
2418 * dispextern.h (struct glyph_matrix.rows_allocated)
2419 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2420 with xpalloc. The values are still always <= INT_MAX.
2421
2422 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2423
2424 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2425 (SAFE_NALLOCA): New macro.
2426
2427 * region-cache.c (struct boundary.pos, find_cache_boundary)
2428 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2429 (set_cache_region, invalidate_region_cache)
2430 (revalidate_region_cache, know_region_cache, region_cache_forward)
2431 (region_cache_backward, pp_cache):
2432 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2433 so that ptrdiff_t * can be passed to xpalloc.
2434 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2435 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2436 (pp_cache): Don't assume cache_len fits in int.
2437 * region-cache.h: Adjust extern decls to match.
2438
2439 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2440 EMACS_INT, since either will do, for xpalloc.
2441
2442 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2443 (xnmalloc, xnrealloc, xpalloc): New functions.
2444
2445 * bidi.c (bidi_shelve_header_size): New constant.
2446 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2447 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2448
2449 * bidi.c (bidi_cache_shrink):
2450 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2451 (overlay_strings):
2452 Don't update size of array until after memory allocation succeeds,
2453 because xmalloc/xrealloc may not return.
2454 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2455 now that we have proper integer overflow checking.
2456 (record_overlay_string, overlay_strings): Catch overflows when
2457 calculating size of overlay_str_buf.
2458
2459 * callproc.c (Fcall_process): Check for size overflow when
2460 calculating size of args2.
2461 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2462 Normally we prefer signed values, but sticking with ptrdiff_t would
2463 require adding more-complicated checks.
2464
2465 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2466 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2467 Redo buffer-overflow calculations to avoid integer overflow.
2468 Add a FIXME comment where memory seems to be over-allocated.
2469
2470 * character.c (Fstring): Check for size-calculation overflow.
2471
2472 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2473 unnecessary integer overflow. Check for size overflow.
2474 (encode_coding_object): Don't update size until xmalloc succeeds.
2475
2476 * composite.c (get_composition_id): Check for overflow in glyph
2477 length calculations.
2478
2479 Integer and memory overflow fixes for display code.
2480 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2481 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2482 (scrolling_window): Check for overflow in size calculations.
2483 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2484 Don't assume glyph table len fits in int.
2485 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2486 (row_table_size): Now ptrdiff_t, not int.
2487 (scrolling_window): Avoid overflow in size calculations.
2488 Don't update size until allocation succeeds.
2489 * fns.c (concat): Check for overflow in size calculations.
2490 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2491 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2492 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2493
2494 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2495 (get_doc_string): Check for size calculation overflow.
2496 Don't update size until allocation succeeds.
2497 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2498 EMACS_INT, where ptrdiff_t will do.
2499 (Fsubstitute_command_keys): Check for string overflow.
2500
2501 * editfns.c (set_time_zone_rule): Don't assume environment length
2502 fits in int.
2503 (message_length): Now ptrdiff_t, not int.
2504 (Fmessage_box): Don't update size until allocation succeeds.
2505 Don't assume message length fits in int.
2506 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2507
2508 * emacs.c (main): Do not reallocate argv, since there is a null at
2509 the end that can be overwritten, and this way there's no need to
2510 worry about size-calculation overflow.
2511 (sort_args): Check for size-calculation overflow.
2512
2513 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2514 alloc succeeds.
2515 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2516
2517 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2518 (x_set_scroll_bar_width, x_figure_window_size):
2519 Check for integer overflow.
2520 (x_set_alpha): Do not assume XINT fits in int.
2521
2522 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2523 This is for the members text_lines, text_cols, total_lines, total_cols,
2524 where the system imposes an 'int' limit.
2525
2526 * fringe.c (Fdefine_fringe_bitmap):
2527 Don't update size until alloc works.
2528
2529 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2530 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2531
2532 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2533 Check for size-calculation overflow.
2534 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2535 do, as we prefer signed integers.
2536 (id_to_widget.max_size, id_to_widget.used)
2537 (xg_store_widget_in_map, xg_remove_widget_from_map)
2538 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2539 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2540 Use and return ptrdiff_t, not int.
2541 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2542 * gtkutil.h: Change prototypes to match the above.
2543
2544 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2545 are duplicate now that they've been promoted to lisp.h.
2546 (x_allocate_bitmap_record, x_alloc_image_color)
2547 (make_image_cache, cache_image, xpm_load):
2548 Don't update size until alloc is done.
2549 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2550 (x_detect_edges):
2551 Check for size calculation overflow.
2552 (ct_colors_allocated_max): New constant.
2553 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2554 overflow.
2555
2556 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2557 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2558 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2559 Use ptrdiff_t, not int, to count maps.
2560 (read_char_minibuf_menu_prompt): Check for overflow in size
2561 calculations. Don't update size until allocation succeeds.
2562 Redo calculations to avoid overflow.
2563 * keyboard.h: Change prototypes to match the above.
2564
2565 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2566 to count maps.
2567 (current_minor_maps): Check for size calculation overflow.
2568 * keymap.h: Change prototypes to match the above.
2569
2570 * lread.c (read1, init_obarray): Don't update size until alloc done.
2571
2572 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2573 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2574
2575 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2576 Now ptrdiff_t, not int.
2577 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2578 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2579
2580 * process.c (Fnetwork_interface_list): Check for overflow
2581 in size calculation.
2582
2583 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2584
2585 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2586 overflow. Don't bother calling xmalloc when xrealloc will do.
2587
2588 * search.c (Freplace_match): Check for size calculation overflow.
2589 (Fset_match_data): Don't assume list lengths fit in 'int'.
2590
2591 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2592 for command line length. Do not attempt to address one before the
2593 beginning of an array, as that's not portable.
2594
2595 * term.c (max_frame_lines): Remove; unused.
2596 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2597 not int.
2598 (encode_terminal_code, calculate_costs): Check for size
2599 calculation overflow.
2600 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2601 table lengths and related sizes. Don't update size until alloc
2602 done. Redo calculations to avoid overflow.
2603 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2604
2605 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2606 subtracting pointers.
2607 (gobble_line): Check for overflow more carefully. Don't update size
2608 until alloc done.
2609
2610 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2611 Don't update size until alloc done.
2612 Redo size calculations to avoid overflow.
2613 Check for size calculation overflow.
2614 (main) [DEBUG]: Fix typo in invoking tparam1.
2615
2616 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2617 Use ptrdiff_t, not int, for sizes.
2618 (store_mode_line_noprop_char): Don't update size until alloc done.
2619
2620 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2621 Use ptrdiff_t, not int, for sizes.
2622 (Finternal_make_lisp_face, cache_face):
2623 Check for size calculation overflow.
2624 (cache_face): Treat size calculation overflows as if they were
2625 memory exhaustion (the usual treatment), rather than aborting.
2626
2627 * xfns.c (x_encode_text, x_set_name_internal)
2628 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2629 sizes, since they can exceed INT_MAX in size. Check for size
2630 calculation overflow.
2631
2632 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2633 (xg_select): Check for size calculation overflow.
2634 Don't update size until alloc done.
2635
2636 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2637 as sprintf is limited to int lengths.
2638
2639 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2640 (X_LONG_MIN): New macros.
2641 Use them to make the following changes clearer.
2642 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2643 This change doesn't affect the value now, but it may help remind
2644 future maintainers not to raise the value too much later.
2645 (SELECTION_QUANTUM): Remove, replacing with ...
2646 (selection_quantum): ... new function, which avoids overflow.
2647 All uses changed.
2648 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2649 assumption that selection length fits in 'int'.
2650 (x_reply_selection_request, x_handle_selection_request)
2651 (x_get_window_property, receive_incremental_selection)
2652 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2653 (lisp_data_to_selection_data, clean_local_selection_data):
2654 Use ptrdiff_t, not int, to record length of selection.
2655 (x_reply_selection_request, x_get_window_property)
2656 (receive_incremental_selection, x_property_data_to_lisp):
2657 Redo calculations to avoid overflow.
2658 (x_reply_selection_request): When sending hint, ceiling it at
2659 X_LONG_MAX rather than relying on wraparound overflow to send
2660 something.
2661 (x_get_window_property, receive_incremental_selection)
2662 (lisp_data_to_selection_data, x_property_data_to_lisp):
2663 Check for size-calculation overflow.
2664 (x_get_window_property, receive_incremental_selection)
2665 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2666 Don't store size until memory allocation succeeds.
2667 (x_get_window_property): Plug memory leak on memory exhaustion.
2668 Don't double-block input; malloc is safe here. Don't assume 2**34
2669 - 4 fits in unsigned long. Add an xassert to check
2670 XGetWindowProperty overflow. Be more careful about overflow
2671 calculations, and distinguish size from memory overflow better.
2672 (receive_incremental_selection): When tracing, don't assume
2673 unsigned int is less than INT_MAX.
2674 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2675 harmful) conversions of unsigned short to int.
2676 (lisp_data_to_selection_data): Don't assume that integers
2677 in the range -65535 through -1 fit in an X unsigned short.
2678 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2679 result parameters unless successful. Rely on cons_to_unsigned
2680 to report problems with elements; the old code wasn't right anyway.
2681 (x_check_property_data): Check for int overflow; we cannot use
2682 a wider type due to X limits.
2683 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2684
2685 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2686
2687 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2688 (x_term_init): Check for size calculation overflow.
2689 (x_color_cells): Don't store size until memory allocation succeeds.
2690 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2691 Don't assume alloca size is less than MAX_ALLOCA.
2692 (x_term_init): Don't assume length fits in int (sprintf is limited
2693 to int size).
2694
2695 Use ptrdiff_t for composition IDs.
2696 * character.c (lisp_string_width):
2697 * composite.c (composition_table_size, n_compositions)
2698 (get_composition_id, composition_gstring_from_id):
2699 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2700 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2701 * window.c (Frecenter):
2702 Use ptrdiff_t, not int, for composition IDs.
2703 * composite.c (get_composition_id): Check for integer overflow.
2704 * composite.h: Adjust prototypes to match the above changes.
2705
2706 Use ptrdiff_t for hash table indexes.
2707 * category.c (hash_get_category_set):
2708 * ccl.c (ccl_driver):
2709 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2710 * coding.c (coding_system_charset_list, detect_coding_system):
2711 * coding.h (struct coding_system.id):
2712 * composite.c (get_composition_id, gstring_lookup_cache):
2713 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2714 * image.c (xpm_get_color_table_h):
2715 * lisp.h (hash_lookup, hash_put):
2716 * minibuf.c (Ftest_completion):
2717 Use ptrdiff_t for hash table indexes, not int (which is too
2718 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2719 32-bit --with-wide-int hosts).
2720
2721 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2722 Add a FIXME comment about memory leaks.
2723 (syms_of_charset): Don't assume xmalloc returns.
2724
2725 Don't assume that stated character widths fit in int.
2726 * character.c (Fchar_width, c_string_width, lisp_string_width):
2727 * character.h (CHAR_WIDTH):
2728 * indent.c (MULTIBYTE_BYTES_WIDTH):
2729 Use sanitize_char_width to avoid undefined and/or bad behavior
2730 with outlandish widths.
2731 * character.h (sanitize_tab_width): Rename from sanitize_width,
2732 now that we have two such functions. All uses changed.
2733 (sanitize_char_width): New inline function.
2734
2735 Don't assume that tab-width fits in int.
2736 * character.h (sanitize_width): New inline function.
2737 (SANE_TAB_WIDTH): New macro.
2738 (ASCII_CHAR_WIDTH): Use it.
2739 * indent.c (sane_tab_width): Remove. All uses replaced by
2740 SANE_TAB_WIDTH (current_buffer).
2741 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2742
2743 * fileio.c: Integer overflow issues with file modes.
2744 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2745
2746 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2747 Remove unreachable code.
2748 (read_hex, load_charset_map_from_file): Check for integer overflow.
2749
2750 * xterm.c: Don't go over XClientMessageEvent limit.
2751 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2752 (x_send_scroll_bar_event): Likewise. Check that the size does not
2753 exceed limits imposed by XClientMessageEvent, as well as the usual
2754 ptrdiff_t and size_t limits.
2755
2756 * keyboard.c: Overflow, signedness and related fixes.
2757 (make_lispy_movement): Use same integer type in forward decl
2758 that is used in the definition.
2759 (read_key_sequence, keyremap_step):
2760 Change bufsize argument back to int, undoing my 2011-03-30 change.
2761 We prefer signed types, and int is wide enough here.
2762 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2763 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2764 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2765 length, not size_t. Use ptrdiff_t for index, not int.
2766 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2767 possibility of integer overflow.
2768
2769 Overflow, signedness and related fixes for images.
2770
2771 * dispextern.h (struct it.stack[0].u.image.image_id)
2772 (struct_it.image_id, struct image.id, struct image_cache.size)
2773 (struct image_cache.used, struct image_cache.ref_count):
2774 * gtkutil.c (update_frame_tool_bar):
2775 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2776 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2777 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2778 * nsmenu.m (update_frame_tool_bar):
2779 * xdisp.c (calc_pixel_width_or_height):
2780 * xfns.c (image_cache_refcount):
2781 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2782 on typical 64-bit hosts.
2783
2784 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2785 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2786 Omit unnecessary casts to int.
2787 (parse_image_spec): Check that integers fall into 'int' range
2788 when the callers expect that.
2789 (image_ascent): Redo ascent calculation to avoid int overflow.
2790 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2791 (lookup_image): Remove unnecessary tests.
2792 (xbm_image_p): Locals are now of int, not EMACS_INT,
2793 since parse_image_check makes sure they fit into int.
2794 (png_load, gif_load, svg_load_image):
2795 Prefer int to unsigned where either will do.
2796 (tiff_handler): New function, combining the cores of the
2797 old tiff_error_handler and tiff_warning_handler.
2798 This function is rewritten to use vsnprintf and thereby avoid
2799 stack buffer overflows. It uses only the features of vsnprintf
2800 that are common to both POSIX and native Microsoft.
2801 (tiff_error_handler, tiff_warning_handler): Use it.
2802 (tiff_load, gif_load, imagemagick_load_image):
2803 Don't assume :index value fits in 'int'.
2804 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2805 (imagemagick_load_image): Check that crop parameters fit into
2806 the integer types that MagickCropImage accepts. Don't assume
2807 Vimagemagick_render_type has a nonnegative value. Don't assume
2808 size_t fits in 'long'.
2809 (gs_load): Use printmax_t to print the widest integers possible.
2810 Check for integer overflow when computing image height and width.
2811
2812 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2813
2814 * xdisp.c (redisplay_window): Don't force window start if point
2815 will be invisible in the resulting window. (Bug#9324)
2816
2817 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2818
2819 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2820 the display spec is of the form `(space ...)'.
2821 (handle_display_spec): Return the value returned by
2822 handle_single_display_spec, not just 1 or zero.
2823 (handle_single_display_spec): If the display spec is of the form
2824 `(space ...)', and specifies display in the text area, return 2
2825 rather than 1.
2826 (try_cursor_movement): Check for the need to scroll more
2827 accurately, and prefer exact match for point under bidi.
2828 Don't advance `row' beyond the last row of the window.
2829
2830 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2831 into disp_prop; all users changed.
2832
2833 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2834 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2835 for the text covered by the display property.
2836
2837 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2838
2839 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2840 Change return value to nil.
2841 (Frecord_buffer): Delete unused function.
2842
2843 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2844
2845 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2846 buffers, return left-to-right.
2847 (set_cursor_from_row): Consider candidate row a win if its glyph
2848 represents a newline and point is on that newline. Fixes cursor
2849 positioning on the newline at EOL of R2L text within L2R
2850 paragraph, and vice versa.
2851 (try_cursor_movement): Check continued rows, in addition to
2852 continuation rows. Fixes unwarranted scroll when point enters a
2853 continued line of R2L text within an L2R paragraph, or vice versa.
2854 (cursor_row_p): Consider the case of point being equal to
2855 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2856 from the end of a short line to the beginning of a continued line
2857 of R2L text within L2R paragraph.
2858 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2859 composed characters.
2860
2861 * bidi.c (bidi_check_type): Use xassert.
2862 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2863 members.
2864
2865 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2866
2867 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2868 a character.
2869
2870 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2871
2872 * nsfont.m (ns_otf_to_script): Fix typo.
2873
2874 2011-08-22 Kenichi Handa <handa@m17n.org>
2875
2876 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2877 extra slot even if the purpose is char-code-property-table.
2878
2879 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2880
2881 * xdisp.c (redisplay_window): When computing centering_position,
2882 account for the height of the header line. (Bug#8874)
2883
2884 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2885 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2886 candidate is selected by the mouse, and that candidate has a
2887 composed character under the mouse.
2888
2889 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2890 coordinates reported by pos-visible-in-window-p for a composed
2891 character in column zero.
2892
2893 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2894
2895 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2896
2897 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2898
2899 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2900 consider it a hit if to_charpos is anywhere in the range of the
2901 composed buffer positions.
2902
2903 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2904
2905 * image.c (gif_load): Don't assume that each subimage has the same
2906 dimensions as the base image. Handle disposal method that is
2907 "undefined" by the gif spec (Bug#9335).
2908
2909 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2910
2911 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2912 (Fcondition_case): Document `debug' symbol in error handler.
2913
2914 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2915
2916 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2917 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2918 from an Org mode buffer to a Speedbar frame.
2919
2920 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2921 a composition, take its buffer position from IT->cmp_it.charpos.
2922 Fixes cursor positioning at the beginning of a line that begins
2923 with a composed character.
2924
2925 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2926
2927 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2928 character bidirectional type, use STRONG_L instead. Fixes crashes
2929 in a buffer produced by `describe-categories'.
2930
2931 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2932 members before the level stack, so they would be saved and
2933 restored when copying iterator state. Fixes incorrect reordering
2934 around TABs covered by display properties.
2935
2936 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2937
2938 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2939
2940 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2941
2942 * eval.c (internal_condition_case, internal_condition_case_1)
2943 (internal_condition_case_2, internal_condition_case_n):
2944 Remove unnecessary aborts (Bug#9081).
2945
2946 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2947
2948 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2949 has no `load' handler, try opening the file locally. (Bug#9311)
2950
2951 2011-08-16 Ken Brown <kbrown@cornell.edu>
2952
2953 * gmalloc.c: Expand comment.
2954
2955 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2956
2957 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2958 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2959
2960 2011-08-16 Ken Brown <kbrown@cornell.edu>
2961
2962 Fix memory allocation problems in Cygwin build (Bug#9273).
2963
2964 * unexcw.c ( __malloc_initialized): Declare external variable.
2965 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2966
2967 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2968 New variables.
2969 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2970 dumped emacs.
2971 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2972 in the static heap.
2973 [CYGWIN] (special_realloc): New function.
2974 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2975 requests to realloc storage in the static heap.
2976
2977 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2978
2979 * bidi.c (bidi_initialize): Remove unused local.
2980
2981 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2982
2983 * bidimirror.h:
2984 * biditype.h: Remove file.
2985 * makefile.w32-in ($(BLD)/bidi.$(O)):
2986 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2987
2988 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2989
2990 * chartab.c: Improve commentary for the uniprop_table API.
2991
2992 * bidi.c (bidi_paragraph_init): Support zero value of
2993 bidi_ignore_explicit_marks_for_paragraph_level.
2994 (bidi_initialize): Use uniprop_table instead of including
2995 biditype.h and bidimirror.h.
2996
2997 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2998 coordinates of the iterator when restoring from ppos_it.
2999 (Bug#9296)
3000
3001 2011-08-14 Kenichi Handa <handa@m17n.org>
3002
3003 * process.c (create_process): Call setup_process_coding_systems
3004 after the pid of the process is set to -1 (Bug#8162).
3005
3006 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3007
3008 * xdisp.c (move_it_in_display_line_to): Don't invoke
3009 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3010 ppos_it. Fixes vertical cursor motion when line beginning is
3011 covered by an image. (Bug#9296)
3012
3013 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3014
3015 * nsterm.h (ns_run_ascript): Declare.
3016 (NSAPP_DATA2_RUNASSCRIPT): Define.
3017
3018 * nsfns.m (as_script, as_result, as_status): New static variables.
3019 (ns_run_ascript): New function.
3020 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3021 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3022 the event loop. Get status from as_status (Bug#7276).
3023
3024 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3025 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3026 the event loop (Bug#7276).
3027
3028 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3029
3030 * gnutls.c (QCgnutls_bootprop_priority)
3031 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3032 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3033 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3034 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3035 (QCgnutls_bootprop_verify_hostname_error)
3036 (QCgnutls_bootprop_callbacks_verify): Rename from
3037 Qgnutls_bootprop_..., all uses changed.
3038
3039 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3040 uses changed.
3041
3042 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3043
3044 * xfaces.c (Qframe_set_background_mode): Now static.
3045 * dispextern.h (Qframe_set_background_mode): Remove decl.
3046
3047 * process.c (Fnetwork_interface_info): Declare local only if needed.
3048
3049 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3050
3051 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3052 (Fnetwork_interface_list): Allocate in increments of bytes instead
3053 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3054 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3055 sockaddr.
3056 (struct ifflag_def): notrailers is smart on OSX.
3057 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3058 Get hardware address with getifaddrs if available.
3059
3060 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3061
3062 * xdisp.c (iterate_out_of_display_property): xassert that
3063 IT->position is set to within IT->object's boundaries. Break from
3064 the loop as soon as EOB is reached; avoids infloops in redisplay
3065 when IT->position is set up wrongly due to some bug.
3066 Set IT->current to match the bidi iterator unconditionally.
3067 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3068 entry. Force push_it to save on the stack the current
3069 buffer/string position, to be restored by pop_it. Fix flags in
3070 the iterator structure wrt the object coming from a display
3071 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3072 properties. (Bug#9284)
3073
3074 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3075
3076 * fontset.c (fontset_get_font_group): Add proper type checks.
3077 (Bug#9172)
3078
3079 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3080
3081 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3082 and LC_VERSION_MIN_MACOSX.
3083 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3084 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3085
3086 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3087
3088 * xdisp.c (forward_to_next_line_start): Allow to use the
3089 no-display-properties-and-no-overlays under bidi display.
3090 Set disp_pos in the bidi iterator to avoid searches for display
3091 properties and overlays.
3092
3093 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3094
3095 * editfns.c (Fset_time_zone_rule): Document relationship with the
3096 setenv function.
3097
3098 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3099 the font entity extracted from the cache (Bug#8109).
3100
3101 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3102
3103 * composite.c (autocmp_chars): Don't reset point. That is done by
3104 restore_point_unwind (Bug#5984).
3105
3106 2011-08-07 Juri Linkov <juri@jurta.org>
3107
3108 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3109 to show the arg `TIME' instead of `TIMEVAL'.
3110
3111 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3112
3113 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3114 display property strides EOL and includes a newline, as in
3115 longlines-mode. (Bug#9254)
3116 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3117 word-wrap under bidirectional display. (Bug#9224)
3118
3119 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3120 is non-zero, even if the data buffer is NULL. Fixes a crash in
3121 vertical-motion with longlines-mode. (Bug#9254)
3122
3123 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3124
3125 * bidi.c <bidi_cache_total_alloc>: Now static.
3126 (bidi_initialize): Initialize bidi_cache_total_alloc.
3127
3128 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3129 cache. (Bug#9221)
3130
3131 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3132 amount allocated this far in `bidi_cache_total_alloc'.
3133 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3134 non-zero, only free the data buffer without restoring the cache
3135 contents. All callers changed.
3136
3137 * dispextern.h (bidi_unshelve_cache): Update prototype.
3138
3139 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3140 (move_it_in_display_line, move_it_to)
3141 (move_it_vertically_backward, move_it_by_lines): Replace the call
3142 to xfree to an equivalent call to bidi_unshelve_cache.
3143 (move_it_in_display_line_to): Fix logic of returning
3144 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3145
3146 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3147
3148 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3149 came from a string character with a `cursor' property. (Bug#9229)
3150
3151 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3152
3153 * Makefile.in (LIB_PTHREAD): New variable.
3154 (LIBES): Add LIB_PTHREAD (Bug#9216).
3155
3156 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3157 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3158
3159 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3160
3161 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3162
3163 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3164
3165 * xterm.c (x_find_topmost_parent): New function.
3166 (x_set_frame_alpha): Find topmost parent window with
3167 x_find_topmost_parent and set the property there also (bug#9181).
3168 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3169
3170 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3171
3172 * callproc.c (Fcall_process): Avoid vfork clobbering
3173 the local vars buffer, coding_systems, current_dir.
3174
3175 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3176
3177 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3178
3179 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3180
3181 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3182 so that it is not optimized away.
3183
3184 * xdisp.c (compute_display_string_pos): Remove unused local.
3185
3186 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3187
3188 Fix slow cursor motion and scrolling in large buffers with
3189 selective display, like Org Mode buffers. (Bug#9218)
3190
3191 * dispextern.h (struct bidi_it): New member disp_prop_p.
3192
3193 * xdisp.c: Remove one-slot cache of display string positions.
3194 (compute_display_string_pos): Accept an additional argument
3195 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3196 for a display string or property. If found, set DISP_PROP_P
3197 non-zero.
3198
3199 * bidi.c (bidi_fetch_char): Accept an additional argument
3200 DISP_PROP_P, and pass it to compute_display_string_pos.
3201 Only handle text covered by a display string if DISP_PROP_P is returned
3202 non-zero. All callers of bidi_fetch_char changed.
3203
3204 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3205
3206 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3207
3208 2010-12-03 Don March <don@ohspite.net>
3209
3210 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3211 last character M-[char] is translated to ESC [char] (bug#7541).
3212
3213 2011-08-02 Kenichi Handa <handa@m17n.org>
3214
3215 * lisp.h (uniprop_table): Extern it.
3216
3217 * chartab.c (uniprop_table): Make it non-static.
3218
3219 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3220
3221 * xdisp.c (forward_to_next_line_start): Accept additional argument
3222 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3223 on the newline.
3224 (reseat_at_next_visible_line_start): Use the bidi iterator state
3225 returned by forward_to_next_line_start to restore the state of
3226 it->bidi_it after backing up to previous newline. (Bug#9212)
3227
3228 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3229
3230 * regex.c (re_comp): Protoize.
3231 (re_exec): Fix return type.
3232 (regexec): Fix type of `ret'. (Bug#9203)
3233
3234 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3235
3236 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3237 This is needed if max-image-size is a floating-point number.
3238
3239 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3240
3241 * print.c (print_object): Print empty symbol as ##.
3242
3243 * lread.c (read1): Read ## as empty symbol.
3244
3245 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3246
3247 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3248 setting frame foreground color (Bug#9175).
3249 (x_set_background_color): Likewise.
3250
3251 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3252 contents (Bug#9176).
3253 (EmacsTooltip -init): Remove bezels and add shadows to
3254 tooltip windows.
3255
3256 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3257 or scroll bar (Bug#8470).
3258
3259 * nsfont.m (nsfont_open): Remove assignment to voffset and
3260 unnecessary vars hshink, expand, hd, full_height, min_height.
3261 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3262
3263 * nsterm.h (nsfont_info): Remove voffset field.
3264
3265 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3266
3267 Implement strike-through and overline on NextStep (Bug#8863).
3268
3269 * nsfont.m (nsfont_open): Use underline position provided by font,
3270 instead of hard-coded value of 2.
3271 (nsfont_draw): Call ns_draw_text_decoration instead.
3272
3273 * nsterm.h: Add declaration for ns_draw_text_decoration.
3274
3275 * nsterm.m (ns_draw_text_decoration): New function for drawing
3276 underline, overline, and strike-through.
3277 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3278 ns_draw_text_decoration. Change treatment of cursor drawing to
3279 accommodate underlining, etc.
3280
3281 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3282
3283 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3284 default.
3285
3286 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3287
3288 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3289 Without this fix, if a signal arrives just after memory fills up,
3290 'malloc' might be invoked reentrantly.
3291
3292 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3293 In other words, assume that every image size is allowed, on non-X
3294 hosts. This assumption is probably wrong, but it lets Emacs compile.
3295
3296 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3297
3298 * regex.c (re_iswctype): Convert return values to boolean.
3299
3300 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3301
3302 * xdisp.c (compute_display_string_pos): Don't use cached display
3303 string position if the buffer had its restriction changed.
3304 (Bug#9184)
3305
3306 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3307
3308 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3309
3310 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3311
3312 Integer signedness and overflow and related fixes. (Bug#9079)
3313
3314 * bidi.c: Integer size and overflow fixes.
3315 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3316 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3317 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3318 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3319 (bidi_find_other_level_edge):
3320 Use ptrdiff_t instead of EMACS_INT where either will do.
3321 This works better on 32-bit hosts configured --with-wide-int.
3322 (bidi_cache_ensure_space): Check for size-calculation overflow.
3323 Use % rather than repeated addition, for better worst-case speed.
3324 Don't set bidi_cache_size until after xrealloc returns, because it
3325 might not return.
3326 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3327 (bidi_cache_ensure_space): Also check that the bidi cache size
3328 does not exceed that of the largest Lisp string or buffer. See Eli
3329 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3330
3331 * alloc.c (__malloc_size_t): Remove.
3332 All uses replaced by size_t. See Andreas Schwab's note
3333 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3334
3335 * image.c: Improve checking for integer overflow.
3336 (check_image_size): Assume that f is nonnull, since
3337 it is always nonnull in practice. This is one less thing to
3338 worry about when checking for integer overflow later.
3339 (x_check_image_size): New function, which checks for integer
3340 overflow issues inside X.
3341 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3342 This removes the need for a memory_full check.
3343 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3344 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3345 (xbm_read_bitmap_data): Change locals back to 'int', since
3346 their values must fit in 'int'.
3347 (xpm_load_image, png_load, tiff_load):
3348 Invoke x_create_x_image_and_pixmap earlier,
3349 to avoid much needless work if the image is too large.
3350 (tiff_load): Treat overly large images as if
3351 x_create_x_image_and_pixmap failed, not as malloc failures.
3352 (gs_load): Use x_check_image_size.
3353
3354 * gtkutil.c: Omit integer casts.
3355 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3356 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3357
3358 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3359
3360 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3361 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3362 would wrongly return t on a 64-bit host.
3363
3364 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3365 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3366 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3367 and therefore cause GCC to emit a bogus diagnostic in some cases.
3368
3369 * image.c: Integer signedness and overflow and related fixes.
3370 This is not an exhaustive set of fixes, but it's time to
3371 record what I've got.
3372 (lookup_pixel_color, check_image_size): Remove redundant decls.
3373 (check_image_size): Don't assume that arbitrary EMACS_INT values
3374 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3375 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3376 (tiff_load, imagemagick_load_image):
3377 Check for overflow in size calculations.
3378 (x_create_x_image_and_pixmap): Remove unnecessary test for
3379 xmalloc returning NULL; that can't happen.
3380 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3381 (xpm_color_bucket): Use better integer hashing function.
3382 (xpm_cache_color): Don't possibly over-allocate memory.
3383 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3384 (gif_memory_source):
3385 Use ptrdiff_t, not int or size_t, to record sizes.
3386 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3387 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3388 either works, as we prefer signed integers.
3389 (tiff_read_from_memory, tiff_write_from_memory):
3390 Return tsize_t, not size_t, since that's what the TIFF API wants.
3391 (tiff_read_from_memory): Don't fail simply because the read would
3392 go past EOF; instead, return a short read.
3393 (tiff_load): Omit no-longer-needed casts.
3394 (Fimagemagick_types): Don't assume size fits into 'int'.
3395
3396 Improve hashing quality when configured --with-wide-int.
3397 * fns.c (hash_string): New function, taken from sxhash_string.
3398 Do not discard information about ASCII character case; this
3399 discarding is no longer needed.
3400 (sxhash-string): Use it. Change sig to match it. Caller changed.
3401 * lisp.h: Declare it.
3402 * lread.c (hash_string): Remove, since we now use fns.c's version.
3403 The fns.c version returns a wider integer if --with-wide-int is
3404 specified, so this should help the quality of the hashing a bit.
3405
3406 * emacs.c: Integer overflow minor fix.
3407 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3408 Define only if GNU_LINUX.
3409 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3410
3411 * dispnew.c: Integer signedness and overflow fixes.
3412 Remove unnecessary forward decls, that were a maintenance hassle.
3413 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3414 All uses changed.
3415 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3416 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3417 (prepare_desired_row, line_draw_cost):
3418 Use int, not unsigned, where either works.
3419 (save_current_matrix, restore_current_matrix):
3420 Use ptrdiff_t, not size_t, where either works.
3421 (init_display): Check for overflow more accurately, and without
3422 relying on undefined behavior.
3423
3424 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3425 Remove, replacing with the new symbols in lisp.h. All uses changed.
3426 * fileio.c (make_temp_name):
3427 * filelock.c (lock_file_1, lock_file):
3428 * xdisp.c (message_dolog):
3429 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3430 Use pMd etc. instead.
3431 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3432 replacing the pWIDE etc. symbols removed from editfns.c.
3433
3434 * keyboard.h (num_input_events): Now uintmax_t.
3435 This is (very slightly) less likely to mess up due to wraparound.
3436 All uses changed.
3437
3438 * buffer.c: Integer signedness fixes.
3439 (alloc_buffer_text, enlarge_buffer_text):
3440 Use ptrdiff_t rather than size_t when either will do, as we prefer
3441 signed integers.
3442
3443 * alloc.c: Integer signedness and overflow fixes.
3444 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3445 (__malloc_size_t): Default to size_t, not to int.
3446 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3447 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3448 Prefer ptrdiff_t to size_t when either would do, as we prefer
3449 signed integers.
3450 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3451 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3452 Now const. Initialize with values that are in range even if char
3453 is signed.
3454 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3455 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3456 These functions do the right thing with sizes > 2**32.
3457 (check_depth): Now ptrdiff_t, not int.
3458 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3459 Adjust to new way of storing sizes. Check for size overflow bugs
3460 in rest of code.
3461 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3462 slightly wrong anyway, as it missed one instance of
3463 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3464 (refill_memory_reserve): Omit needless cast to size_t.
3465 (mark_object_loop_halt): Mark as externally visible.
3466
3467 * xselect.c: Integer signedness and overflow fixes.
3468 (Fx_register_dnd_atom, x_handle_dnd_message):
3469 Use ptrdiff_t, not size_t, since we prefer signed.
3470 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3471 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3472 x_dnd_atoms_size and x_dnd_atoms_length.
3473
3474 * doprnt.c: Prefer signed to unsigned when either works.
3475 * eval.c (verror):
3476 * doprnt.c (doprnt):
3477 * lisp.h (doprnt):
3478 * xdisp.c (vmessage):
3479 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3480 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3481 prefer signed arithmetic to avoid comparison confusion.
3482 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3483 but is a bit tricky.
3484
3485 Assume freestanding C89 headers, string.h, stdlib.h.
3486 * data.c, doprnt.c, floatfns.c, print.c:
3487 Include float.h unconditionally.
3488 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3489 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3490 * regex.c: Likewise for stddef.h, string.h.
3491 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3492 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3493 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3494 (STDC_HEADERS): Remove obsolete defines.
3495 * sysdep.c: Include limits.h unconditionally.
3496
3497 Assume support for memcmp, memcpy, memmove, memset.
3498 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3499 * regex.c (memcmp, memcpy):
3500 Remove; we assume C89 now.
3501
3502 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3503 (__malloc_safe_bcopy): Remove; no longer needed.
3504
3505 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3506 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3507 well either way, and we prefer signed to unsigned.
3508
3509 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3510
3511 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3512 closes the connection while we're reading (bug#9182).
3513
3514 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3515
3516 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3517 are specified (Bug#9168).
3518
3519 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3520
3521 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3522 Found by GCC static checking and --with-wide-int on a 32-bit host.
3523
3524 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3525
3526 * xdisp.c (compute_display_string_pos): Fix logic of caching
3527 previous display string position. Initialize cached_prev_pos to
3528 -1. Fixes slow-down at the beginning of a buffer.
3529
3530 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3531
3532 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3533 for attrs[LFACE_FONTSET_INDEX].
3534
3535 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3536
3537 * xml.c (parse_region): Remove unused local
3538 that was recently introduced.
3539
3540 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3541
3542 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3543 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3544
3545 * xdisp.c (move_it_in_display_line_to): Record the best matching
3546 position for TO_CHARPOS while scanning the line, and restore it on
3547 exit if none of the characters scanned was an exact match.
3548 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3549 when exact match is impossible due to invisible text, and the
3550 lines are truncated.
3551
3552 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3553
3554 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3555 for OSX >= 10.7.
3556
3557 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3558
3559 Fix a significant slow-down of cursor motion with C-n, C-p,
3560 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3561 auto-repeat under bidi redisplay in fontified buffers.
3562 * xdisp.c (compute_stop_pos_backwards): New function.
3563 (next_element_from_buffer): Call compute_stop_pos_backwards to
3564 find a suitable prev_stop when we find ourselves before
3565 base_level_stop.
3566 (reseat): Don't look for prev_stop, as that could mean a very long
3567 run.
3568 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3569 <cached_disp_overlay_modiff>: Cache for last found display string
3570 position.
3571 (compute_display_string_pos): Return the cached position if asked
3572 about the same buffer in the same area of character positions, and
3573 the buffer wasn't changed since the time the display string
3574 position was cached.
3575
3576 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3577
3578 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3579 is an integer, which is important for empty lines. (Bug#9149)
3580
3581 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3582
3583 * frame.c (Fmodify_frame_parameters): In tty case, update the
3584 default face if necessary (Bug#4238).
3585
3586 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3587
3588 * editfns.c (Fstring_to_char): No need to explain what a character
3589 is in the docstring (Bug#6576).
3590
3591 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3592
3593 * xml.c (parse_region): Make sure we always return a tree.
3594
3595 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3596
3597 * xml.c (parse_region): If a document contains only comments,
3598 return that, too.
3599
3600 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3601
3602 * xml.c (make_dom): Return comments, too.
3603
3604 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3605
3606 Port to OpenBSD.
3607 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3608 and the surrounding thread.
3609 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3610 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3611 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3612 timer goes off.
3613 * s/openbsd.h (BROKEN_SIGIO): Define.
3614 * unexelf.c (unexec) [__OpenBSD__]:
3615 Don't update the .mdebug section of the Alpha COFF symbol table.
3616
3617 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3618
3619 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3620 (bug#8460).
3621
3622 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3623
3624 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3625 This fixes some race conditions on the permissions of any newly
3626 created file.
3627
3628 * alloc.c (valid_pointer_p): Use pipe, not open.
3629 This fixes some permissions issues when debugging.
3630
3631 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3632 If fchown fails to set both uid and gid, try to set just gid,
3633 as that is sometimes allowed. Adjust the file's mode to eliminate
3634 setuid or setgid bits that are inappropriate if fchown fails.
3635
3636 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3637
3638 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3639 to compare Lisp_Objects.
3640 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3641 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3642 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3643
3644 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3645
3646 * lread.c (read_integer): Unread even EOF character.
3647 (read1): Likewise. Properly record start position of symbol.
3648
3649 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3650 symbol character follows.
3651
3652 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3653
3654 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3655 This works around a problem with the previous change to Fcopy_file.
3656 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3657 and without this change, GCC might complain about discarding
3658 fchown's return value.
3659
3660 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3661
3662 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3663
3664 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3665
3666 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3667
3668 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3669
3670 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3671 it's used from the C level.
3672
3673 * process.c: Use the same condition for POLL_FOR_INPUT in both
3674 keyboard.c and process.c (bug#1858).
3675
3676 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3677
3678 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3679 (Fgnutls_boot): Use it.
3680
3681 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3682
3683 * doc.c (Fsubstitute_command_keys): Revert last change.
3684
3685 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3686
3687 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3688 quotes the next character, and doesn't affect other longer
3689 sequences (bug#8935).
3690
3691 * lread.c (syms_of_lread): Clarify that is isn't only
3692 `eval-buffer' and `eval-defun' that's affected by
3693 `lexical-binding' (bug#8460).
3694
3695 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3696
3697 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3698 bidi redisplay when a line includes both an image and is truncated.
3699
3700 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 Fix minor problems found by static checking.
3703 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3704 (elsz): Now a signed constant, not a size_t var. We prefer signed
3705 types to unsigned, to avoid integer comparison confusion. Without
3706 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3707 "cannot optimize loop, the loop counter may overflow", a symptom
3708 of the confusion.
3709 * indent.c (Fvertical_motion): Mark locals as initialized.
3710 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3711
3712 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3713
3714 * search.c (Fre_search_backward): Mention `case-fold-search' in
3715 all the re_search_* functions (bug#8138).
3716
3717 * keyboard.c (Fopen_dribble_file): Document when the file is
3718 closed (bug#8056).
3719
3720 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3721
3722 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3723 bidi_cache_idx.
3724
3725 Support bidi reordering of display and overlay strings.
3726 * xdisp.c (compute_display_string_pos)
3727 (compute_display_string_end): Accept additional argument STRING.
3728 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3729 (reseat_to_string): Initialize bidi_it->string.s and
3730 bidi_it->string.schars.
3731 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3732 NULL (avoids a crash in bidi_paragraph_init).
3733 Initialize itb.string.lstring.
3734 (init_iterator): Call bidi_init_it only of a valid
3735 buffer position was specified. Initialize paragraph_embedding to
3736 L2R.
3737 (reseat_to_string): Initialize the bidi iterator.
3738 (display_string): If we need to ignore text properties of
3739 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3740 original value of -1 will not work with bidi.)
3741 (compute_display_string_pos): First arg is now struct
3742 `text_pos *'; all callers changed. Support display properties on
3743 Lisp strings.
3744 (compute_display_string_end): Support display properties on Lisp
3745 strings.
3746 (init_iterator, reseat_1, reseat_to_string): Initialize the
3747 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3748 when iterating on a string not from display properties).
3749 (compute_display_string_pos, compute_display_string_end):
3750 Fix calculation of the object to scan. Fixes an error when using
3751 arrow keys.
3752 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3753 base_level_stop; instead, set base_level_stop to BEGV.
3754 Fixes crashes in vertical-motion.
3755 (next_element_from_buffer): Improve commentary for when
3756 the iterator is before prev_stop.
3757 (init_iterator): Initialize bidi_p from the default value of
3758 bidi-display-reordering, not from buffer-local value. Use the
3759 buffer-local value only if initializing for buffer iteration.
3760 (handle_invisible_prop): Support invisible properties on strings
3761 that are being bidi-reordered.
3762 (set_iterator_to_next): Support bidi reordering of C strings and
3763 Lisp strings.
3764 (next_element_from_string): Support bidi reordering of Lisp
3765 strings.
3766 (handle_stop_backwards): Support Lisp strings as well.
3767 (display_string): Support display of R2L glyph rows.
3768 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3769 (init_iterator): Don't initialize it->bidi_p for strings
3770 here.
3771 (reseat_to_string): Initialize it->bidi_p for strings here.
3772 (next_element_from_string, next_element_from_c_string)
3773 (next_element_from_buffer): Add xassert's for correspondence
3774 between IT's object being iterated and it->bidi_it.string
3775 structure.
3776 (face_before_or_after_it_pos): Support bidi iteration.
3777 (next_element_from_c_string): Handle the case of the first string
3778 character that is not the first one in the visual order.
3779 (get_visually_first_element): New function, refactored from common
3780 parts of next_element_from_buffer, next_element_from_string, and
3781 next_element_from_c_string.
3782 (tool_bar_lines_needed, redisplay_tool_bar)
3783 (display_menu_bar): Force left-to-right direction. Add a FIXME
3784 comment for making that be controlled by a user option.
3785 (push_it, pop_it): Save and restore the state of the
3786 bidi iterator. Save and restore the bidi_p flag.
3787 (pop_it): Iterate out of display property for string iteration as
3788 well.
3789 (iterate_out_of_display_property): Support iteration over strings.
3790 (handle_single_display_spec): Set up it->bidi_it for iteration
3791 over a display string, and call bidi_init_it.
3792 (handle_single_display_spec, next_overlay_string)
3793 (get_overlay_strings_1, push_display_prop): Set up the bidi
3794 iterator for displaying display or overlay strings.
3795 (forward_to_next_line_start): Don't use the shortcut if
3796 bidi-iterating.
3797 (back_to_previous_visible_line_start): If handle_display_prop
3798 pushed the iterator stack, restore the internal state of the bidi
3799 iterator by calling bidi_pop_it same number of times.
3800 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3801 and we are bidi-iterating, don't decrement the iterator position;
3802 instead, set the first_elt flag in the bidi iterator, to produce
3803 the same effect.
3804 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3805 (push_display_prop): xassert that we are iterating a buffer.
3806 (push_it, pop_it): Save and restore paragraph_embedding member.
3807 (handle_single_display_spec, next_overlay_string)
3808 (get_overlay_strings_1, reseat_1, reseat_to_string)
3809 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3810 correctly. Don't assume unibyte strings are not bidi-reordered.
3811 (compute_display_string_pos)
3812 (compute_display_string_end): Fix handling the case of C string.
3813 (push_it, pop_it): Save and restore from_disp_prop_p.
3814 (handle_single_display_spec, push_display_prop): Set the
3815 from_disp_prop_p flag.
3816 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3817 (pop_it): Call iterate_out_of_display_property only if we are
3818 popping after iteration over a string that came from a display
3819 property. Fix a typo in popping stretch info. Add an assertion
3820 for verifying that the iterator position is in sync with the bidi
3821 iterator.
3822 (handle_single_display_spec, get_overlay_strings_1)
3823 (push_display_prop): Fix initialization of paragraph direction for
3824 string when that of the parent object is not yet determined.
3825 (reseat_1): Call bidi_init_it to resync the bidi
3826 iterator with IT's position. (Bug#7616)
3827 (find_row_edges): If ROW->start.pos gives position
3828 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3829 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3830 Reset the from_disp_prop_p flag.
3831 (SAVE_IT, RESTORE_IT): New macros.
3832 (pos_visible_p, face_before_or_after_it_pos)
3833 (back_to_previous_visible_line_start)
3834 (move_it_in_display_line_to, move_it_in_display_line)
3835 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3836 (try_scrolling, redisplay_window, display_line): Use them when
3837 saving a temporary copy of the iterator and restoring it back.
3838 (back_to_previous_visible_line_start, reseat_1)
3839 (init_iterator): Empty the bidi cache "stack".
3840 (move_it_in_display_line_to): If iterator ended up at
3841 EOL, but we never saw any buffer positions smaller than
3842 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3843 motion in bidi-reordered lines.
3844 (move_it_in_display_line_to): Record prev_method and prev_pos
3845 immediately before the call to set_iterator_to_next. Fixes cursor
3846 motion in bidi-reordered lines with stretch glyphs and strings
3847 displayed in margins. (Bug#8133) (Bug#8867)
3848 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3849 TO_CHARPOS.
3850 (pos_visible_p): Support positions in bidi-reordered lines.
3851 Save and restore bidi cache.
3852
3853 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3854 (bidi_paragraph_info): Delete unused struct.
3855 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3856 (bidi_cache_start): New variable.
3857 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3858 to zero.
3859 (bidi_cache_fetch_state, bidi_cache_search)
3860 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3861 (bidi_cache_find, bidi_peek_at_next_level)
3862 (bidi_level_of_next_char, bidi_find_other_level_edge)
3863 (bidi_move_to_visually_next): Compare cache index with
3864 bidi_cache_start rather than with zero.
3865 (bidi_fetch_char): Accept new argument STRING; all callers
3866 changed. Support iteration over a string. Support strings with
3867 display properties. Support unibyte strings. Fix the type of
3868 `len' according to what STRING_CHAR_AND_LENGTH expects.
3869 (bidi_paragraph_init, bidi_resolve_explicit_1)
3870 (bidi_resolve_explicit, bidi_resolve_weak)
3871 (bidi_level_of_next_char, bidi_move_to_visually_next):
3872 Support iteration over a string.
3873 (bidi_set_sor_type, bidi_resolve_explicit_1)
3874 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3875 can now be zero (for strings); special values 0 and -1 were
3876 changed to -1 and -2, respectively.
3877 (bidi_char_at_pos): New function.
3878 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3879 Call it instead of FETCH_MULTIBYTE_CHAR.
3880 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3881 initialized to valid values.
3882 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3883 values.
3884 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3885 the test for valid cached positions. Fix the logic for looking up
3886 the sentinel state in the cache. GCPRO the Lisp string we are
3887 iterating.
3888 (bidi_push_it, bidi_pop_it): New functions.
3889 (bidi_initialize): Initialize the bidi cache start stack pointer.
3890 (bidi_cache_ensure_space): New function, refactored from part of
3891 bidi_cache_iterator_state. Don't assume the required size is just
3892 one BIDI_CACHE_CHUNK away.
3893 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3894 (bidi_count_bytes, bidi_char_at_pos): New functions.
3895 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3896 always valid if bidi_cache_idx is valid.
3897 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3898 is valid if it's going to be used.
3899 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3900 (bidi_cache_fetch_state, bidi_cache_search)
3901 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3902 (bidi_cache_iterator_state, bidi_cache_find)
3903 (bidi_find_other_level_edge, bidi_cache_start_stack):
3904 All variables related to cache indices are now EMACS_INT.
3905
3906 * dispextern.h (struct bidi_string_data): New structure.
3907 (struct bidi_it): New member `string'. Make flag members be 1-bit
3908 fields, and put them last in the struct.
3909 (compute_display_string_pos, compute_display_string_end):
3910 Update prototypes.
3911 (bidi_push_it, bidi_pop_it): Add prototypes.
3912 (struct iterator_stack_entry): New members bidi_p,
3913 paragraph_embedding, and from_disp_prop_p.
3914 (struct it): Member bidi_p is now a bit field 1 bit wide.
3915 (bidi_shelve_cache, bidi_unshelve_cache):
3916 Declare prototypes.
3917
3918 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3919 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3920 and vector-like objects.
3921
3922 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3923 cache around display iteration.
3924
3925 * window.c (Fwindow_end, window_scroll_pixel_based)
3926 (displayed_window_lines, Frecenter): Save and restore the bidi
3927 cache around display iteration.
3928
3929 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3930
3931 * editfns.c (Fdelete_region): Clarify the use of the named
3932 parameters (bug#6788).
3933
3934 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3935
3936 * indent.c (Fvertical_motion): Set and restore w->pointm when
3937 saving and restoring the window's buffer (Bug#9006).
3938
3939 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3940
3941 * editfns.c (Fstring_to_char): Clarify just what is returned
3942 (bug#6576). Text by Eli Zaretskii.
3943
3944 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3945
3946 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3947
3948 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3949
3950 * buffer.c (mmap_find): Fix a typo.
3951
3952 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3953
3954 Fix execution of x selection hooks.
3955 * xselect.c (Qx_lost_selection_functions)
3956 (Qx_sent_selection_functions): New vars.
3957 (syms_of_xselect): DEFSYM them.
3958 (x_handle_selection_request): Pass Qx_sent_selection_functions
3959 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3960 (x_handle_selection_clear,x_clear_frame_selections):
3961 Pass Qx_lost_selection_functions rather than
3962 Vx_lost_selection_functions to Frun_hook_with_args.
3963
3964 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3965
3966 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3967 The old code sometimes used this field without initializing it.
3968
3969 * alloc.c (gc_sweep): Don't read past end of array.
3970 In theory, the old code could also have corrupted Emacs internals,
3971 though it'd be very unlikely.
3972
3973 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3974
3975 * character.c (Fcharacterp): Don't advertise optional ignored
3976 argument. (Bug#4026)
3977
3978 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3979
3980 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3981 key" (bug#4257).
3982
3983 * window.c (Fset_window_start): Doc fix (bug#4199).
3984 (Fset_window_hscroll): Ditto.
3985
3986 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 Fix minor new problems caught by GCC 4.6.1.
3989 * term.c (init_tty): Remove unused local.
3990 * xsettings.c (store_monospaced_changed): Define this function only
3991 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3992 not used otherwise.
3993
3994 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3995
3996 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3997
3998 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3999
4000 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4001 are the mini-buffer and the echo area (bug#3320).
4002
4003 * term.c (init_tty): Remove support for supdup, c10 and perq
4004 terminals, which are no longer supported (bug#1482).
4005
4006 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4007
4008 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4009
4010 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4011
4012 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4013 for non-popups (Bug#3642).
4014
4015 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4016
4017 * alloc.c (reset_malloc_hooks): Protoize.
4018 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4019 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4020 * cm.c (losecursor): Likewise.
4021 * data.c (fmod): Likewise.
4022 * dispnew.c (swap_glyphs_in_rows): Likewise.
4023 * emacs.c (memory_warning_signal): Likewise.
4024 * floatfns.c (float_error): Likewise.
4025 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4026 (otf_open, font_otf_capability, generate_otf_features)
4027 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4028 Likewise.
4029 * image.c (pbm_read_file): Likewise.
4030 * indent.c (string_display_width): Likewise.
4031 * intervals.c (check_for_interval, search_for_interval)
4032 (inc_interval_count, count_intervals, root_interval)
4033 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4034 * lread.c (defalias): Likewise.
4035 * ralloc.c (r_alloc_check): Likewise.
4036 * regex.c (set_image_of_range_1, set_image_of_range)
4037 (regex_grow_registers): Likewise.
4038 * sysdep.c (strerror): Likewise.
4039 * termcap.c (valid_filename_p, tprint, main): Likewise.
4040 * tparam.c (main): Likewise.
4041 * unexhp9k800.c (run_time_remap, save_data_space)
4042 (update_file_ptrs, read_header, write_header, calculate_checksum)
4043 (copy_file, copy_rest, display_header): Likewise.
4044 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4045 Likewise.
4046 * xdisp.c (check_it): Likewise.
4047 * xfaces.c (register_color, unregister_color, unregister_colors):
4048 Likewise.
4049 * xfns.c (print_fontset_result): Likewise.
4050 * xrdb.c (member, fatal, main): Likewise.
4051
4052 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4053
4054 Fix minor problems found by static checking (Bug#9031).
4055 * chartab.c (char_table_set_range, map_sub_char_table):
4056 Remove unused locals.
4057 (uniprop_table): Now static.
4058 * composite.c (_work_char): Remove unused static var.
4059
4060 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4061
4062 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4063
4064 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4065
4066 * gtkutil.c (qttip_cb): Remove code without function.
4067
4068 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4069
4070 * w32.c (pthread_sigmask): New stub.
4071
4072 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4073
4074 Use pthread_sigmask, not sigprocmask (Bug#9010).
4075 sigprocmask is portable only for single-threaded applications, and
4076 Emacs can be multi-threaded when it uses GTK.
4077 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4078 (LIBES): Use it.
4079 * callproc.c (Fcall_process):
4080 * process.c (create_process):
4081 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4082 Use pthread_sigmask, not sigprocmask.
4083
4084 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4085
4086 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4087 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4088 wrong (Bug#8591).
4089
4090 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4091
4092 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4093 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4094 (xg_hide_tooltip): Fix comment.
4095
4096 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4097 in registerServicesMenuSendTypes.
4098 (validRequestorForSendType): Don't check ns_return_types.
4099
4100 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4101 ns_return_type.
4102
4103 2011-07-08 Jason Rumney <jasonr@gnu.org>
4104
4105 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4106 SH_SHOW for hidden windows (Bug#5482).
4107
4108 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4109 frame struct members of non-existent frames (Bug#6284).
4110
4111 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4112
4113 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4114 variable firstTime not needed on OSX >= 10.6.
4115 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4116 >= 10.5. Use setKnobProportion, setDoubleValue.
4117
4118 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4119 (MAC_OS_X_VERSION_10_5): Define if not defined.
4120 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4121 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4122 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4123
4124 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4125 cString and lossyCString on OSX >= 10.4
4126
4127 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4128 sizeToFit on OSX >= 10.2.
4129
4130 * nsimage.m (allocInitFromFile): Don't use deprecated method
4131 bestRepresentationForDevice on OSX >= 10.6.
4132
4133 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4134 to avoid warning.
4135
4136 * emacs.c: Declare unexec_init_emacs_zone.
4137
4138 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4139
4140 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4141
4142 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4143 on svcsMenu (Bug#8842).
4144
4145 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4146 ns_return_types.
4147 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4148
4149 * nsterm.m (QUTF8_STRING): Declare.
4150 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4151 (validRequestorForSendType): Return type is (id).
4152 Change indexOfObjectIdenticalTo to indexOfObject.
4153 Check if we have local selection before returning self (Bug#8842).
4154 (writeSelectionToPasteboard): Put local selection into paste board
4155 if we have a local selection (Bug#8842).
4156 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4157
4158 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4159 (ns_get_local_selection): Declare.
4160
4161 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4162
4163 * keymap.c (describe_map_tree): Don't insert a double newline at
4164 the end of the buffer (bug#1169) and return whether we inserted
4165 something.
4166
4167 * callint.c (Fcall_interactively): Change "reading args" to
4168 "providing args" to try to clarify what it does (bug#1010).
4169
4170 2011-07-07 Kenichi Handa <handa@m17n.org>
4171
4172 * composite.c (composition_compute_stop_pos): Ignore a static
4173 composition starting before CHARPOS (Bug#8915).
4174
4175 * xdisp.c (handle_composition_prop): Likewise.
4176
4177 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4178
4179 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4180 (Bug#9015)
4181
4182 2011-07-07 Kenichi Handa <handa@m17n.org>
4183
4184 * character.h (unicode_category_t): New enum type.
4185
4186 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4187 (Qchar_code_property_table): New variable.
4188 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4189 (UNIPROP_COMPRESSED_FORM_P): New macros.
4190 (char_table_ascii): Uncompress the compressed values.
4191 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4192 Uncompress the compressed values.
4193 (sub_char_table_ref_and_range): Likewise.
4194 (char_table_ref_and_range): Uncompress the compressed values.
4195 (sub_char_table_set): New arg is_uniprop. Callers changed.
4196 Uncompress the compressed values.
4197 (sub_char_table_set_range): Args changed. Callers changed.
4198 (char_table_set_range): Adjuted for the above change.
4199 (map_sub_char_table): Delete args default_val and parent. Add arg
4200 top. Give decoded values to a Lisp function.
4201 (map_char_table): Adjust for the above change. Give decoded
4202 values to a Lisp function. Gcpro more variables.
4203 (uniprop_table_uncompress)
4204 (uniprop_decode_value_run_length): New functions.
4205 (uniprop_decoder, uniprop_decoder_count): New variables.
4206 (uniprop_get_decoder, uniprop_encode_value_character)
4207 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4208 New functions.
4209 (uniprop_encoder, uniprop_encoder_count): New variables.
4210 (uniprop_get_encoder, uniprop_table)
4211 (Funicode_property_table_internal, Fget_unicode_property_internal)
4212 (Fput_unicode_property_internal): New functions.
4213 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4214 Sunicode_property_table_internal, Sget_unicode_property_internal,
4215 and Sput_unicode_property_internal. Defvar_lisp
4216 char-code-property-alist.
4217
4218 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4219 Vunicode_category_table.
4220
4221 * font.c (font_range): Adjust for the change of
4222 Vunicode_category_table.
4223
4224 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4225
4226 * m/iris4d.h: Remove file, move contents ...
4227 * s/irix6-5.h: ... here.
4228
4229 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4230
4231 Remove unportable assumption about struct layout (Bug#8884).
4232 * alloc.c (mark_buffer):
4233 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4234 (clone_per_buffer_values): Don't assume that
4235 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4236 This isn't true in general, and it's particularly not true
4237 if Emacs is configured with --with-wide-int.
4238 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4239 New macros, used in the buffer.c change.
4240
4241 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4242
4243 * xsettings.c: Use both GConf and GSettings if both are available.
4244 (store_config_changed_event): Add comment.
4245 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4246 (store_tool_bar_style_changed): New functions.
4247 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4248 (struct xsettings): Move font inside HAVE_XFT.
4249 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4250 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4251 Move inside HAVE_XFT.
4252 (something_changed_gsettingsCB): Rename from something_changedCB.
4253 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4254 also.
4255 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4256 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4257 (something_changed_gconfCB): Rename from something_changedCB.
4258 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4259 (parse_settings): Move check for font inside HAVE_XFT.
4260 (read_settings, apply_xft_settings): Add comment.
4261 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4262 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4263 call store_font_name_changed.
4264 (xft_settings_event): Add comment.
4265 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4266 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4267 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4268 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4269 (xsettings_initialize): Call init_gsettings last.
4270 (xsettings_get_system_font, xsettings_get_system_normal_font):
4271 Add comment.
4272
4273 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4274
4275 Random fixes. E.g., (random) never returned negative values.
4276 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4277 subseconds part to the entropy, as that's a bit more random.
4278 Prefer signed to unsigned, since the signedness doesn't matter and
4279 in general we prefer signed. When given a limit, use a
4280 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4281 latter isn't right if USE_2_TAGS_FOR_INTS.
4282 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4283 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4284
4285 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4286
4287 * textprop.c (text_property_stickiness):
4288 Obey Vtext_property_default_nonsticky.
4289 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4290 * w32fns.c (syms_of_w32fns):
4291 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4292
4293 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4294
4295 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4296 This is more efficient than Ffile_directory_p and avoids a minor race.
4297
4298 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4299
4300 * buffer.c (Foverlay_put): Say what the return value is
4301 (bug#7835).
4302
4303 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4304 is a directory before asking whether to use the file name
4305 (bug#7564).
4306 (barf_or_query_if_file_exists): Make the "File is a directory"
4307 error be more correct.
4308
4309 * fns.c (Frequire): Remove the mention of the .gz files, since
4310 that's installation-specific, but keep the mention of
4311 `get-load-suffixes'.
4312
4313 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4314
4315 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4316 Report string overflow if the output is too long.
4317
4318 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4319
4320 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4321 (syms_of_gnutls): Remove duplicate DEFSYM for
4322 Qgnutls_bootprop_verify_hostname_error, an error for
4323 Qgnutls_bootprop_verify_error (which is no longer used).
4324
4325 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4326 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4327 Also (re)move comments that are misplaced or no longer relevant.
4328
4329 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4330
4331 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4332
4333 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4334
4335 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4336 and background color parameters if they have been changed.
4337
4338 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4339
4340 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4341
4342 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 * xsettings.c (SYSTEM_FONT): Define only when used.
4345 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4346
4347 * keymap.c (access_keymap_1): Now static.
4348
4349 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4350
4351 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4352 leave any prefix arg for the up event (Bug#1586).
4353
4354 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4355
4356 * lread.c (syms_of_lread): Mention single symbols defined by
4357 `defvar' or `defconst' (bug#7154).
4358
4359 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4360 (Frequire): Mention get-load-suffixes.
4361
4362 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4363
4364 * window.h (window): Remove clone_number slot.
4365 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4366 Remove.
4367 (make_parent_window, make_window, saved_window)
4368 (Fset_window_configuration, save_window_save): Don't deal with
4369 clone numbers.
4370 * buffer.c (Qclone_number): Remove declaration.
4371 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4372
4373 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4374
4375 Add multiple inheritance to keymaps.
4376 * keymap.c (Fmake_composed_keymap): New function.
4377 (Fset_keymap_parent): Simplify.
4378 (fix_submap_inheritance): Remove.
4379 (access_keymap_1): New function extracted from access_keymap to handle
4380 embedded parents and handle lists of maps.
4381 (access_keymap): Use it.
4382 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4383 (Fcopy_keymap): Handle embedded parents.
4384 (Fcommand_remapping, define_as_prefix): Simplify.
4385 (Fkey_binding): Simplify.
4386 (syms_of_keymap): Move minibuffer-local-completion-map,
4387 minibuffer-local-filename-completion-map,
4388 minibuffer-local-must-match-map, and
4389 minibuffer-local-filename-must-match-map to Elisp.
4390 (syms_of_keymap): Defsubr make-composed-keymap.
4391 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4392 (parse_menu_item): Trivial simplification.
4393
4394 2011-07-01 Glenn Morris <rgm@gnu.org>
4395
4396 * Makefile.in (SETTINGS_LIBS): Fix typo.
4397
4398 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4399
4400 * coding.c (Fencode_coding_string): Record the last coding system
4401 used, as the function doc string says (bug#8738).
4402
4403 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4404
4405 * xsettings.c (store_monospaced_changed): Take new font as arg and
4406 check for change against current_mono_font.
4407 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4408 (emacs_settings_constructor, emacs_settings_get_property)
4409 (emacs_settings_set_property, emacs_settings_class_init)
4410 (emacs_settings_init, gsettings_obj): Remove.
4411 (something_changedCB): New function for HAVE_GSETTINGS.
4412 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4413 with value as argument.
4414 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4415 g_settings_new (Bug#8967). Do not create gsettings_obj.
4416 Remove calls to g_settings_bind. Connect something_changedCB to
4417 "changed".
4418
4419 * xgselect.c: Add defined (HAVE_GSETTINGS).
4420 (xgselect_initialize): Ditto.
4421
4422 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4423 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4424 xg_select.
4425
4426 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4427
4428 * eval.c (struct backtrace): Simplify and port the data structure.
4429 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4430 signed bit field, as this assumption is not portable and it makes
4431 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4432 "char debug_on_exit : 1" as this is not portable either; instead,
4433 use the portable "unsigned int debug_on_exit : 1". Remove unused
4434 member evalargs. Remove obsolete comments about cc bombing out.
4435
4436 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4437
4438 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4439 Let HAVE_GSETTINGS override HAVE_GCONF.
4440 (store_monospaced_changed): New function.
4441 (EMACS_SETTINGS): A new type derived from GObject to handle
4442 GSettings notifications.
4443 (emacs_settings_constructor, emacs_settings_get_property)
4444 (emacs_settings_set_property, emacs_settings_class_init):
4445 New functions.
4446 (gsettings_client, gsettings_obj): New variables.
4447 (GSETTINGS_SCHEMA): New define.
4448 (something_changedCB): Call store_monospaced_changed.
4449 (init_gsettings): New function.
4450 (xsettings_initialize): Call init_gsettings.
4451 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4452 to NULL.
4453
4454 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4455 GCONF_CFLAGS/LIBS.
4456
4457 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4458
4459 * window.c (resize_root_window, grow_mini_window)
4460 (shrink_mini_window): Rename Qresize_root_window to
4461 Qwindow_resize_root_window and Qresize_root_window_vertically to
4462 Qwindow_resize_root_window_vertically.
4463
4464 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4465
4466 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4467
4468 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4469
4470 * makefile.w32-in: Redesign dependencies so they reflect more
4471 clearly which files are directly included by each source file,
4472 and not through other includes.
4473
4474 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4475
4476 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4477 (sort_overlays, overlay_strings): When an overlay's clone number
4478 matches the window's clone number process the overlay even if
4479 the overlay's window property doesn't match the current window.
4480
4481 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4482 (Fwindow_hchild): Rename to Fwindow_left_child.
4483 (Fwindow_next): Rename to Fwindow_next_sibling.
4484 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4485 (resize_window_check): Rename to window_resize_check.
4486 (resize_window_apply): Rename to window_resize_apply.
4487 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4488 (Fdelete_other_windows_internal, resize_frame_windows)
4489 (Fsplit_window_internal, Fdelete_window_internal)
4490 (grow_mini_window, shrink_mini_window)
4491 (Fresize_mini_window_internal): Fix callers accordingly.
4492
4493 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4494
4495 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4496 (emacs_fixed_set_min_size): Remove.
4497 (emacs_fixed_new): Take frame as argument.
4498
4499 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4500 (_EmacsFixedPrivate): Remove minwidth/height.
4501 Add struct frame *f.
4502 (emacs_fixed_init): Initialize priv->f.
4503 (get_parent_class, emacs_fixed_set_min_size): Remove.
4504 (emacs_fixed_new): Set priv->f to argument.
4505 (emacs_fixed_get_preferred_width)
4506 (emacs_fixed_get_preferred_height): Use min_width/height from
4507 frames size_hint to set minimum and natural (Bug#8919).
4508 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4509 and use min_width/height from frames size_hint to set
4510 min_width/height (Bug#8919).
4511
4512 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4513 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4514 Fix indentation.
4515
4516 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4517
4518 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4519 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4520 called at ZV.
4521
4522 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4523
4524 * process.c (wait_reading_process_output): Bypass select if
4525 waiting for a cell while ignoring keyboard input, and input is
4526 pending. Suggested by Jan Djärv (Bug#8869).
4527
4528 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4529
4530 Use gnulib's dup2 module instead of rolling our own.
4531 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4532
4533 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4534
4535 * dispnew.c (scrolling_window): Before scrolling, turn off a
4536 mouse-highlight in the window being scrolled.
4537
4538 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4539
4540 Move DEFSYM to lisp.h and use everywhere.
4541
4542 * character.h (DEFSYM): Move declaration...
4543 * lisp.h (DEFSYM): ...here.
4544
4545 * gnutls.c:
4546 * minibuf.c:
4547 * w32menu.c:
4548 * w32proc.c:
4549 * w32select.c: Don't include character.h.
4550
4551 * alloc.c (syms_of_alloc):
4552 * buffer.c (syms_of_buffer):
4553 * bytecode.c (syms_of_bytecode):
4554 * callint.c (syms_of_callint):
4555 * casefiddle.c (syms_of_casefiddle):
4556 * casetab.c (init_casetab_once):
4557 * category.c (init_category_once, syms_of_category):
4558 * ccl.c (syms_of_ccl):
4559 * cmds.c (syms_of_cmds):
4560 * composite.c (syms_of_composite):
4561 * dbusbind.c (syms_of_dbusbind):
4562 * dired.c (syms_of_dired):
4563 * dispnew.c (syms_of_display):
4564 * doc.c (syms_of_doc):
4565 * editfns.c (syms_of_editfns):
4566 * emacs.c (syms_of_emacs):
4567 * eval.c (syms_of_eval):
4568 * fileio.c (syms_of_fileio):
4569 * fns.c (syms_of_fns):
4570 * frame.c (syms_of_frame):
4571 * fringe.c (syms_of_fringe):
4572 * insdel.c (syms_of_insdel):
4573 * keymap.c (syms_of_keymap):
4574 * lread.c (init_obarray, syms_of_lread):
4575 * macros.c (syms_of_macros):
4576 * msdos.c (syms_of_msdos):
4577 * print.c (syms_of_print):
4578 * process.c (syms_of_process):
4579 * search.c (syms_of_search):
4580 * sound.c (syms_of_sound):
4581 * syntax.c (init_syntax_once, syms_of_syntax):
4582 * terminal.c (syms_of_terminal):
4583 * textprop.c (syms_of_textprop):
4584 * undo.c (syms_of_undo):
4585 * w32.c (globals_of_w32):
4586 * window.c (syms_of_window):
4587 * xdisp.c (syms_of_xdisp):
4588 * xfaces.c (syms_of_xfaces):
4589 * xfns.c (syms_of_xfns):
4590 * xmenu.c (syms_of_xmenu):
4591 * xsettings.c (syms_of_xsettings):
4592 * xterm.c (syms_of_xterm): Use DEFSYM.
4593
4594 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4595
4596 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4597
4598 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4599
4600 Integer and buffer overflow fixes (Bug#8873).
4601
4602 * print.c (printchar, strout): Check for string overflow.
4603 (PRINTPREPARE, printchar, strout):
4604 Don't set size unless allocation succeeds.
4605
4606 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4607 for sizes. Check for string overflow more accurately.
4608 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4609
4610 * macros.c: Integer and buffer overflow fixes.
4611 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4612 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4613 Use ptrdiff_t, not int, for sizes.
4614 Don't increment bufsize until after realloc succeeds.
4615 Check for size-calculation overflow.
4616 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4617
4618 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4619
4620 * lread.c: Integer overflow fixes.
4621 (read_integer): Radix is now EMACS_INT, not int,
4622 to improve quality of diagnostics for out-of-range radices.
4623 Calculate buffer size correctly for out-of-range radices.
4624 (read1): Check for integer overflow in radices, and in
4625 read-circle numbers.
4626 (read_escape): Avoid int overflow.
4627 (Fload, openp, read_buffer_size, read1)
4628 (substitute_object_recurse, read_vector, read_list, map_obarray):
4629 Use ptrdiff_t, not int, for sizes.
4630 (read1): Use EMACS_INT, not int, for sizes.
4631 Check for size overflow.
4632
4633 * image.c (cache_image): Check for size arithmetic overflow.
4634
4635 * lread.c: Integer overflow issues.
4636 (saved_doc_string_size, saved_doc_string_length)
4637 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4638 Now ptrdiff_t, not int.
4639 (read1): Don't assume doc string length fits in int. Check for
4640 out-of-range doc string lengths.
4641 (read_list): Don't assume file position fits in int.
4642 (read_escape): Check for hex character overflow.
4643
4644 2011-06-22 Leo Liu <sdl.web@gmail.com>
4645
4646 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4647 Move to minibuffer.el.
4648
4649 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4650
4651 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4652 The following patches are for when GLYPH_DEBUG && !XASSERT.
4653 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4654 * dispnew.c (flush_stdout):
4655 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4656 Mark as externally visible.
4657 * dispnew.c (check_window_matrix_pointers): Now static.
4658 * dispnew.c (window_to_frame_vpos):
4659 * xfns.c (unwind_create_frame):
4660 * xterm.c (x_check_font): Remove unused local.
4661 * scroll.c (CHECK_BOUNDS):
4662 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4663 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4664 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4665 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4666 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4667 Now static.
4668 (debug_method_add): Use va_list and vsprintf rather than relying
4669 on undefined behavior with wrong number of arguments.
4670 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4671 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4672 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4673 since we're not interested in debugging glyphs with old libraries.
4674 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4675 GCC 4.6.0's static checking.
4676
4677 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4678
4679 Integer overflow and signedness fixes (Bug#8873).
4680 A few related buffer overrun fixes, too.
4681
4682 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4683
4684 * dispextern.h (struct face.stipple):
4685 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4686 (x_bitmap_mask, x_allocate_bitmap_record)
4687 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4688 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4689 (x_create_bitmap_from_xpm_data):
4690 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4691 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4692 (.bitmaps_last):
4693 * xfaces.c (load_pixmap):
4694 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4695 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4696 (.bitmaps_last, struct x_output.icon_bitmap):
4697 Use ptrdiff_t, not int, for bitmap indexes.
4698 (x_allocate_bitmap_record): Check for size overflow.
4699 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4700
4701 Use ptrdiff_t, not int, for overlay counts.
4702 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4703 * editfns.c (overlays_around, get_pos_property):
4704 * textprop.c (get_char_property_and_overlay):
4705 * xdisp.c (next_overlay_change, note_mouse_highlight):
4706 * xfaces.c (face_at_buffer_position):
4707 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4708 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4709 (Fnext_overlay_change, Fprevious_overlay_change)
4710 (mouse_face_overlay_overlaps, Foverlays_in):
4711 Use ptrdiff_t, not int, for sizes.
4712 (overlays_at, overlays_in): Check for size-calculation overflow.
4713
4714 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4715
4716 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4717 (x_session_initialize): Do not assume string length fits in int.
4718
4719 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4720 This is unlikely, but can occur if DPI is outlandish.
4721
4722 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4723 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4724
4725 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4726 * xrdb.c (magic_file_p, search_magic_path):
4727 Omit last arg SUFFIX; it was always 0. All callers changed.
4728 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4729
4730 * xfont.c (xfont_match): Avoid need for strlen.
4731
4732 * xfns.c: Don't assume strlen fits in int.
4733 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4734
4735 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4736 not unsigned long, as we prefer signed integers. All callers changed.
4737 Detect integer overflow in repeat count.
4738 (message_dolog): Don't assume print length fits in 39 bytes.
4739 (display_mode_element): Don't assume strlen fits in int.
4740
4741 * termcap.c: Don't assume sizes fit in int and never overflow.
4742 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4743 (gobble_line): Check for size-calculation overflow.
4744
4745 * minibuf.c (Fread_buffer):
4746 * lread.c (intern, intern_c_string):
4747 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4748 Don't assume string length fits in int.
4749
4750 * keyboard.c (parse_tool_bar_item):
4751 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4752
4753 * font.c: Don't assume string length fits in int.
4754 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4755 Use ptrdiff_t, not int.
4756 (font_intern_prop): Don't assume string length fits in int.
4757 Don't assume integer property fits in fixnum.
4758 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4759
4760 * filelock.c: Fix some buffer overrun and integer overflow issues.
4761 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4762 Reformulate so as not to need the command string.
4763 Invoke gzip -cd rather than gunzip, as it's more portable.
4764 (lock_info_type, lock_file_1, lock_file):
4765 Don't assume pid_t and time_t fit in unsigned long.
4766 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4767 (current_lock_owner): Prefer signed type for sizes.
4768 Use memcpy, not strncpy, where memcpy is what is really wanted.
4769 Don't assume (via atoi) that time_t and pid_t fit in int.
4770 Check for time_t and/or pid_t out of range, e.g., via a network share.
4771 Don't alloca where an auto var works fine.
4772
4773 * fileio.c: Fix some integer overflow issues.
4774 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4775 Don't assume string length fits in int.
4776 (directory_file_name): Don't assume string length fits in long.
4777 (make_temp_name): Don't assume pid fits in int, or that its print
4778 length is less than 20.
4779
4780 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4781
4782 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4783
4784 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4785
4786 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4787 We prefer signed integers, even for size calculations.
4788
4789 * emacs.c: Don't assume string length fits in 'int'.
4790 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4791 (main): Don't invoke strlen when not needed.
4792
4793 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4794 (XD_DEBUG_MESSAGE): Don't waste a byte.
4795
4796 * callproc.c (getenv_internal_1, getenv_internal)
4797 (Fgetenv_internal):
4798 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4799
4800 * lread.c (invalid_syntax): Omit length argument.
4801 All uses changed. This doesn't fix a bug, but it simplifies the
4802 code away from its former Hollerith-constant appearance, and it's
4803 one less 'int' to worry about when looking at integer-overflow issues.
4804 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4805
4806 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4807 This didn't break anything, but it didn't help either.
4808 It's confusing to put a bogus integer in a place where the actual
4809 value does not matter.
4810 (LIST_END_P): Remove unused macro and its bogus comment.
4811 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4812
4813 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4814 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4815 implementation.
4816 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4817 We prefer signed types, and the value cannot exceed the EMACS_INT
4818 range anyway (because otherwise the length would not be representable).
4819 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4820 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4821 This avoids a GCC warning when WIDE_EMACS_INT.
4822
4823 * indent.c (sane_tab_width): New function.
4824 (current_column, scan_for_column, Findent_to, position_indentation)
4825 (compute_motion): Use it. This is just for clarity.
4826 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4827
4828 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4829
4830 * lisp.h (lint_assume): New macro.
4831 * composite.c (composition_gstring_put_cache):
4832 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4833
4834 * editfns.c, insdel.c:
4835 Omit unnecessary forward decls, to simplify future changes.
4836
4837 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4838
4839 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4840
4841 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4842 Use much-faster test for byte-length change.
4843 Don't assume string byte-length fits in 'int'.
4844 Check that character arg fits in 'int'.
4845 (mapcar1): Declare byte as byte, for clarity.
4846
4847 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4848
4849 * fns.c (concat): Catch string overflow earlier.
4850 Do not rely on integer wraparound.
4851
4852 * dispextern.h (struct it.overlay_strings_charpos)
4853 (struct it.selective): Now EMACS_INT, not int.
4854 * xdisp.c (forward_to_next_line_start)
4855 (back_to_previous_visible_line_start)
4856 (reseat_at_next_visible_line_start, next_element_from_buffer):
4857 Don't arbitrarily truncate the value of 'selective' to int.
4858
4859 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4860
4861 * composite.c: Don't truncate sizes to 'int'.
4862 (composition_gstring_p, composition_reseat_it)
4863 (composition_adjust_point): Use EMACS_INT, not int.
4864 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4865 not EMACS_UINT, for indexes.
4866
4867 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4868
4869 * buffer.c: Include <verify.h>.
4870 (struct sortvec.priority, struct sortstr.priority):
4871 Now EMACS_INT, not int.
4872 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4873 (struct sortstr.size, record_overlay_string)
4874 (struct sortstrlist.size, struct sortlist.used):
4875 Don't truncate size to int.
4876 (record_overlay_string): Check for size-calculation overflow.
4877 (init_buffer_once): Check at compile-time, not run-time.
4878
4879 2011-06-22 Jim Meyering <meyering@redhat.com>
4880
4881 Don't leak an XBM-image-sized buffer
4882 * image.c (xbm_load): Free the image buffer after using it.
4883
4884 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4885
4886 Port to Sun C.
4887 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4888 that Sun C diagnosed.
4889 * fns.c (secure_hash): Fix pointer signedness issue.
4890 * intervals.c (static_offset_intervals): New function.
4891 (offset_intervals): Use it.
4892
4893 2011-06-21 Leo Liu <sdl.web@gmail.com>
4894
4895 * deps.mk (fns.o):
4896 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4897 sha512.h.
4898
4899 * fns.c (secure_hash): Rename from crypto_hash_function and change
4900 the first arg to accept symbols.
4901 (Fsecure_hash): New primitive.
4902 (syms_of_fns): New symbols.
4903
4904 2011-06-20 Deniz Dogan <deniz@dogan.se>
4905
4906 * process.c (Fset_process_buffer): Clarify return value in
4907 docstring.
4908
4909 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4910
4911 * dispnew.c (add_window_display_history): Use BVAR.
4912
4913 * xdisp.c (debug_method_add): Use BVAR.
4914 (check_window_end, dump_glyph_matrix, dump_glyph)
4915 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4916
4917 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4918 Likewise.
4919
4920 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4921 check till after the cache is created in init_frame_faces.
4922
4923 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4924
4925 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4926
4927 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4928
4929 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4930 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4931 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4932
4933 Improve buffer-overflow checking (Bug#8873).
4934 * fileio.c (Finsert_file_contents):
4935 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4936 Remove the old (too-loose) buffer overflow checks.
4937 They weren't needed, since make_gap checks for buffer overflow.
4938 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4939 The old code merely checked for Emacs fixnum overflow, and relied
4940 on undefined (wraparound) behavior. The new code avoids undefined
4941 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4942
4943 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4944 Tune. Don't use wider integers than needed. Don't use alloca.
4945 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4946
4947 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4948
4949 * insdel.c, lisp.h (buffer_overflow): New function.
4950 (insert_from_buffer_1, replace_range, replace_range_2):
4951 * insdel.c (make_gap_larger):
4952 * editfns.c (Finsert_char):
4953 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4954
4955 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4956
4957 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4958
4959 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4960
4961 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4962 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4963
4964 * fileio.c: Don't assume EMACS_INT fits in off_t.
4965 (emacs_lseek): New static function.
4966 (Finsert_file_contents, Fwrite_region): Use it.
4967 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4968
4969 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4970
4971 * fns.c: Don't overflow int when computing a list length.
4972 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4973 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4974 truncation on 64-bit hosts. Check for QUIT every
4975 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4976 faster and is responsive enough.
4977 (Flength): Report an error instead of overflowing an integer.
4978 (Fsafe_length): Return a float if the value is not representable
4979 as a fixnum. This shouldn't happen except in contrived situations.
4980 (Fnthcdr, Fsort): Don't assume list length fits in int.
4981 (Fcopy_sequence): Don't assume vector length fits in int.
4982
4983 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4984 (header_size, word_size): New constants.
4985 (allocate_vectorlike): Don't check size overflow here.
4986 (allocate_vector): Check it here instead, since this is the only
4987 caller of allocate_vectorlike that could cause overflow.
4988 Check that the new vector's length is representable as a fixnum.
4989
4990 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4991 The previous code was bogus. For example, next_almost_prime (32)
4992 returned 39, which is undesirable as it is a multiple of 3; and
4993 next_almost_prime (24) returned 25, which is a multiple of 5 so
4994 why was the code bothering to check for multiples of 7?
4995
4996 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4997
4998 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4999
5000 Variadic C functions now count arguments with ptrdiff_t.
5001 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5002 Back then I didn't know that the Emacs coding style prefers signed int.
5003 Also, in the meantime I found a few more instances where arguments
5004 were being counted with int, which may truncate counts on 64-bit
5005 machines, or EMACS_INT, which may be unnecessarily wide.
5006 * lisp.h (struct Lisp_Subr.function.aMANY)
5007 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5008 Arg counts are now ptrdiff_t, not size_t.
5009 All variadic functions and their callers changed accordingly.
5010 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5011 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5012 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5013 * callint.c (Fcall_interactively): Check arg count for overflow,
5014 to avoid potential buffer overrun. Use signed char, not 'int',
5015 for 'varies' array, so that we needn't bother to check its size
5016 calculation for overflow.
5017 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5018 * eval.c (apply_lambda):
5019 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5020 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5021 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5022
5023 * callint.c (Fcall_interactively): Don't use index var as event count.
5024
5025 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5026 * mem-limits.h (SIZE): Remove; no longer used.
5027
5028 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5029
5030 Remove unnecessary casts.
5031 * xterm.c (x_term_init):
5032 * xfns.c (x_set_border_pixel):
5033 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5034 These aren't needed now that we assume ANSI C.
5035
5036 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5037 It's more likely to cause problems (due to unsigned overflow)
5038 than to cure them.
5039
5040 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5041
5042 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5043
5044 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5045
5046 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5047
5048 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5049
5050 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5051
5052 GLYPH_CODE_FACE returns EMACS_INT, not int.
5053 * dispextern.h (merge_faces):
5054 * xfaces.c (merge_faces):
5055 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5056 Don't assume EMACS_INT fits in int.
5057
5058 * character.h (CHAR_VALID_P): Remove unused parameter.
5059 * fontset.c, lisp.h, xdisp.c: All uses changed.
5060
5061 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5062
5063 * fns.c (concat): Minor tuning based on overflow analysis.
5064 This doesn't fix any bugs. Use int to hold character, instead
5065 of constantly refetching from Emacs object. Use XFASTINT, not
5066 XINT, for value known to be a character. Don't bother comparing
5067 a single byte to 0400, as it's always less.
5068
5069 * floatfns.c (Fexpt):
5070 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5071
5072 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5073 for characters.
5074
5075 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5076
5077 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5078 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5079 incorrectly succeed when S was a string, because 4294967386 was
5080 truncated before it was used.
5081
5082 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5083 Otherwise, an out-of-range integer could cause undefined behavior
5084 on a 64-bit host.
5085
5086 * composite.c: Use int, not EMACS_INT, for characters.
5087 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5088 EMACS_INT, for values that are known to be in character range.
5089 This doesn't fix any bugs but is the usual style inside Emacs and
5090 may generate better code on 32-bit machines.
5091
5092 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5093 This is for reasons similar to the recent CHAR_STRING fix.
5094 * charset.c (Fencode_char): Check that character arg is actually
5095 a character. Pass an int to ENCODE_CHAR.
5096 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5097 wider than 'int', as a compile-time check to prevent future regressions
5098 in this area.
5099
5100 * character.c (char_string): Remove unnecessary casts.
5101
5102 Make sure a 64-bit char is never passed to CHAR_STRING.
5103 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5104 by silently ignoring the top 32 bits, allowing some values
5105 that were far too large to be valid characters.
5106 * character.h: Include <verify.h>.
5107 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5108 arguments are no wider than unsigned, as a compile-time check
5109 to prevent future regressions in this area.
5110 * data.c (Faset):
5111 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5112 (Fsubst_char_in_region):
5113 * fns.c (concat):
5114 * xdisp.c (decode_mode_spec_coding):
5115 Adjust to CHAR_STRING's new requirement.
5116 * editfns.c (Finsert_char, Fsubst_char_in_region):
5117 * fns.c (concat): Check that character args are actually
5118 characters. Without this test, these functions did the wrong
5119 thing with wildly out-of-range values on 64-bit hosts.
5120
5121 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5122 These casts should not be needed on 32-bit hosts, either.
5123 * keyboard.c (read_char):
5124 * lread.c (Fload): Remove casts to unsigned.
5125
5126 * lisp.h (UNSIGNED_CMP): New macro.
5127 This fixes comparison bugs on 64-bit hosts.
5128 (ASCII_CHAR_P): Use it.
5129 * casefiddle.c (casify_object):
5130 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5131 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5132 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5133 * dispextern.h (FACE_FROM_ID):
5134 * keyboard.c (read_char): Use UNSIGNED_CMP.
5135
5136 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5137 not to EMACS_INT, to avoid GCC warning.
5138
5139 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5140
5141 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5142 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5143 isn't needed on 32-bit machines.
5144
5145 * buffer.c (Fgenerate_new_buffer_name):
5146 Use EMACS_INT for count, not int.
5147 (advance_to_char_boundary): Return EMACS_INT, not int.
5148
5149 * data.c (Qcompiled_function): Now static.
5150
5151 * window.c (window_body_lines): Now static.
5152
5153 * image.c (gif_load): Rename local to avoid shadowing.
5154
5155 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5156 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5157 * alloc.c (make_save_value): Integer argument is now of type
5158 ptrdiff_t, not int.
5159 (mark_object): Use ptrdiff_t, not int.
5160 * lisp.h (pD): New macro.
5161 * print.c (print_object): Use it.
5162
5163 * alloc.c: Use EMACS_INT, not int, to count objects.
5164 (total_conses, total_markers, total_symbols, total_vector_size)
5165 (total_free_conses, total_free_markers, total_free_symbols)
5166 (total_free_floats, total_floats, total_free_intervals)
5167 (total_intervals, total_strings, total_free_strings):
5168 Now EMACS_INT, not int. All uses changed.
5169 (Fgarbage_collect): Compute overall total using a double, so that
5170 integer overflow is less likely to be a problem. Check for overflow
5171 when converting back to an integer.
5172 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5173 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5174 These were 'int' variables that could overflow on 64-bit hosts;
5175 they were never used, so remove them instead of repairing them.
5176 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5177 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5178 Previously, this ceilinged at INT_MAX, but that doesn't work on
5179 64-bit machines.
5180 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5181
5182 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5183 (allocate_vectorlike): Check for ptrdiff_t overflow.
5184 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5185 when a (possibly-narrower) signed value would do just as well.
5186 We prefer using signed arithmetic, to avoid comparison confusion.
5187
5188 * alloc.c: Catch some string size overflows that we were missing.
5189 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5190 for convenience in STRING_BYTES_MAX.
5191 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5192 The definition here is exact; the one in lisp.h was approximate.
5193 (allocate_string_data): Check for string overflow. This catches
5194 some instances we weren't catching before. Also, it catches
5195 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5196 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5197 and ptrdiff_t and EMACS_INT are both 64 bits.
5198
5199 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5200 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5201 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5202
5203 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5204
5205 * alloc.c (Fmake_string): Check for out-of-range init.
5206
5207 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5208
5209 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5210
5211 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5212
5213 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5214 xg_get_default_scrollbar_width.
5215
5216 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5217 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5218 (style_changed_cb): Call update_theme_scrollbar_width and call
5219 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5220 all frames (Bug#8505).
5221 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5222 Call gtk_window_set_resizable if HAVE_GTK3.
5223 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5224 and height if HAVE_GTK3 (Bug#8505).
5225 (scroll_bar_width_for_theme): New variable.
5226 (update_theme_scrollbar_width): New function.
5227 (xg_get_default_scrollbar_width): Move code to
5228 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5229 (xg_initialize): Call update_theme_scrollbar_width.
5230
5231 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5232
5233 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5234
5235 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5236
5237 * frame.c (make_frame): Call other_buffer_safely instead of
5238 other_buffer.
5239
5240 * window.c (temp_output_buffer_show): Call display_buffer with
5241 second argument Vtemp_buffer_show_specifiers and reset latter
5242 immediately after the call.
5243 (Vtemp_buffer_show_specifiers): New variable.
5244 (auto_window_vscroll_p, next_screen_context_lines)
5245 (Vscroll_preserve_screen_position): Remove leading asterisks from
5246 doc-strings.
5247
5248 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5249
5250 Fix minor problems found by GCC 4.6.0 static checking.
5251 * buffer.c (Qclone_number): Remove for now, as it's unused.
5252 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5253 (record_buffer): Remove unused local.
5254 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5255 (set_frame_buffer_list): Remove; unused.
5256 * frame.h (other_visible_frames): Remove decl.
5257 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5258 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5259 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5260 if HAVE_GPM.
5261 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5262 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5263 Define only if HAVE_GPM.
5264 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5265 (update_hints_inhibit): Remove; never set. All uses removed.
5266 * widgetprv.h (emacsFrameClassRec): Remove decl.
5267 * window.c (delete_deletable_window): Now returns void, since it
5268 wasn't returning anything.
5269 (compare_window_configurations): Remove unused locals.
5270 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5271 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5272 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5273 the same widths as pointers. This follows up on the 2011-05-06 patch.
5274 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5275 * xterm.h: Likewise.
5276 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5277
5278 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5279
5280 * makefile.w32-in: Update dependencies.
5281 (LISP_H): Add lib/intprops.h.
5282
5283 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5284
5285 * image.c (gif_load): Add animation frame delay to the metadata.
5286 (syms_of_image): Use DEFSYM. New symbol `delay'.
5287
5288 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5289
5290 * window.c (delete_deletable_window): Re-add.
5291 (Fset_window_configuration): Rewrite to handle dead buffers and
5292 consequently deletable windows.
5293 (window_tree, Fwindow_tree): Remove. Supply functionality in
5294 window.el.
5295 (compare_window_configurations): Simplify code.
5296
5297 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5298
5299 * image.c (imagemagick_load_image): Fix type mismatch.
5300 (Fimagemagick_types): Likewise.
5301
5302 * window.h (replace_buffer_in_windows): Declare.
5303
5304 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5305
5306 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5307 Qclone_number. Remove external declaration of Qdelete_window.
5308 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5309 code.
5310 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5311 Run Qbuffer_list_update_hook if allowed.
5312 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5313 buffer list implementation.
5314 (other_buffer_safely): New function.
5315 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5316 calls to replace_buffer_in_windows and
5317 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5318 if allowed.
5319 (record_buffer): Inhibit quitting and rewrite using quittable
5320 functions. Run Qbuffer_list_update_hook if allowed.
5321 (Frecord_buffer, Funrecord_buffer): New functions.
5322 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5323 Move switch-to-buffer to window.el.
5324 (bury-buffer): Move to window.el.
5325 (Vbuffer_list_update_hook): New variable.
5326
5327 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5328 section.
5329
5330 * window.h (resize_frame_windows): Move up in code.
5331 (Fwindow_frame): Remove EXFUN.
5332 (replace_buffer_in_all_windows): Remove prototype.
5333 (replace_buffer_in_windows_safely): Add prototype.
5334
5335 * window.c: Declare Qdelete_window static again. Move down
5336 declaration of select_count.
5337 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5338 (Fother_window): Move to window.el.
5339 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5340 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5341 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5342 window.el.
5343 (replace_buffer_in_windows): Implement by calling
5344 Qreplace_buffer_in_windows.
5345 (replace_buffer_in_all_windows): Remove with some functionality
5346 moved into replace_buffer_in_windows_safely.
5347 (replace_buffer_in_windows_safely): New function.
5348 (select_window_norecord, select_frame_norecord): Move in front
5349 of run_window_configuration_change_hook. Remove now obsolete
5350 declarations.
5351 (Fset_window_buffer): Rewrite doc-string.
5352 Call Qrecord_window_buffer.
5353 (keys_of_window): Move binding for other-window to window.el.
5354
5355 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5356
5357 * dispextern.h (struct image): Replace data member, whose int_val
5358 and ptr_val fields were not used by anything, with a single
5359 lisp_val object.
5360
5361 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5362 (gif_clear_image, gif_load, imagemagick_load_image)
5363 (gs_clear_image, gs_load): Callers changed.
5364
5365 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5366
5367 * buffer.h: Include <time.h>, for time_t.
5368 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5369
5370 Fix minor problems found by static checking.
5371
5372 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5373
5374 Make identifiers static if they are not used in other modules.
5375 * data.c (Qcompiled_function, Qframe, Qvector):
5376 * image.c (QimageMagick, Qsvg):
5377 * minibuf.c (Qmetadata):
5378 * window.c (resize_window_check, resize_root_window): Now static.
5379 * window.h (resize_window_check, resize_root_window): Remove decls.
5380
5381 * window.c (window_deletion_count, delete_deletable_window):
5382 Remove; unused.
5383 (window_body_lines): Now static.
5384 (Fdelete_other_windows_internal): Mark vars as initialized.
5385 Make sure 'resize_failed' is initialized.
5386 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5387 (resize_window_apply): Remove unused local.
5388 * window.h (delete_deletable_window): Remove decl.
5389
5390 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5391 (imagemagick_load_image): Fix pointer signedness problem by changing
5392 last arg from unsigned char * to char *. All uses changed.
5393 Also, fix a local for similar reasons.
5394 Remove unused locals. Remove locals to avoid shadowing.
5395 (fn_rsvg_handle_free): Remove; unused.
5396 (svg_load, svg_load_image): Fix pointer signedness problem.
5397 (imagemagick_load_image): Don't use garbage pointer image_wand.
5398
5399 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5400
5401 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5402
5403 * image.c (gif_load): Fix omitted cast error introduced by
5404 2011-06-06 change.
5405
5406 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5407
5408 * window.h (resize_proportionally, orig_total_lines)
5409 (orig_top_line): Remove from window structure.
5410 (set_window_height, set_window_width, change_window_heights)
5411 (Fdelete_window): Remove prototypes.
5412 (resize_frame_windows): Remove duplicate declaration.
5413
5414 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5415
5416 * window.h (resize_frame_windows, resize_window_check)
5417 (delete_deletable_window, resize_root_window)
5418 (resize_frame_windows): Declare prototypes.
5419
5420 * window.c (resize_window_apply): Make definition be "static" to
5421 match the prototype.
5422
5423 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5424
5425 * window.c: Remove declarations of Qwindow_size_fixed,
5426 window_min_size_1, window_min_size_2, window_min_size,
5427 size_window, window_fixed_size_p, enlarge_window, delete_window.
5428 Remove static from declaration of Qdelete_window, it's
5429 temporarily needed by Fbury_buffer.
5430 (replace_window): Don't assign orig_top_line and
5431 orig_total_lines.
5432 (Fdelete_window, delete_window): Remove. Window deletion is
5433 handled by window.el.
5434 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5435 Replace Fdelete_window calls with calls to Qdelete_window.
5436 (Fdelete_other_windows): Remove. Deleting other windows is
5437 handled by window.el.
5438 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5439 handled in window.el.
5440 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5441 Window minimum sizes are handled in window.el.
5442 (shrink_windows, size_window, set_window_height)
5443 (set_window_width, change_window_heights, window_height)
5444 (window_width, CURBEG, CURSIZE, enlarge_window)
5445 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5446 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5447 handled in window.el.
5448 (make_dummy_parent): Rename to make_parent_window and give it a
5449 second argument horflag.
5450 (make_window): Don't set resize_proportionally any more.
5451 (Fsplit_window): Remove. Windows are split in window.el.
5452 (save_restore_action, save_restore_orig_size)
5453 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5454 Resize mini windows in window.el.
5455 (grow_mini_window, shrink_mini_window): Implement by calling
5456 Qresize_root_window_vertically, resize_window_check and
5457 resize_window_apply.
5458 (saved_window, Fset_window_configuration, save_window_save):
5459 Do not handle orig_top_line, orig_total_lines, and
5460 resize_proportionally.
5461 (window_min_height, window_min_width): Move to window.el.
5462 (keys_of_window): Move bindings for delete-other-windows,
5463 split-window, delete-window and enlarge-window to window.el.
5464
5465 * buffer.c: Temporarily extern Qdelete_window.
5466 (Fbury_buffer): Temporarily call Qdelete_window instead of
5467 Fdelete_window (Fbury_buffer will move to window.el soon).
5468
5469 * frame.c (set_menu_bar_lines_1): Remove code handling
5470 orig_top_line and orig_total_lines.
5471
5472 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5473 set_window_height but set heights directly.
5474 (change_frame_size_1): Use resize_frame_windows.
5475
5476 * xdisp.c (init_xdisp): Don't use set_window_height but set
5477 heights directly.
5478
5479 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5480 Use resize_frame_windows instead of change_window_heights and run
5481 run_window_configuration_change_hook.
5482
5483 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5484 instead of change_window_heights and run
5485 run_window_configuration_change_hook.
5486
5487 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5488
5489 * window.c (replace_window): Rename second argument REPLACEMENT to
5490 NEW. New third argument SETFLAG. Rewrite.
5491 (delete_window, make_dummy_parent): Call replace_window with
5492 third argument 1.
5493 (window_list_1): Move down in code.
5494 (run_window_configuration_change_hook): Move set_buffer part
5495 before select_frame_norecord part in order to unwind correctly.
5496 Rename count1 to count.
5497 (recombine_windows, delete_deletable_window, resize_root_window)
5498 (Fdelete_other_windows_internal)
5499 (Frun_window_configuration_change_hook, make_parent_window)
5500 (resize_window_check, resize_window_apply, Fresize_window_apply)
5501 (resize_frame_windows, Fsplit_window_internal)
5502 (Fdelete_window_internal, Fresize_mini_window_internal):
5503 New functions.
5504 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5505
5506 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5507
5508 * window.h (window): Add some new members to window structure -
5509 normal_lines, normal_cols, new_total, new_normal, clone_number,
5510 splits, nest, prev_buffers, next_buffers.
5511 (WINDOW_TOTAL_SIZE): Move here from window.c.
5512 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5513
5514 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5515 Remove.
5516 (make_dummy_parent): Set new members of windows structure.
5517 (make_window): Move down in code. Handle new members of window
5518 structure.
5519 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5520 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5521 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5522 (Fset_window_prev_buffers, Fwindow_next_buffers)
5523 (Fset_window_next_buffers, Fset_window_clone_number):
5524 New functions.
5525 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5526 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5527 Doc-string fixes.
5528 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5529 Argument WINDOW can be now internal window too.
5530 (Fwindow_use_time): Move up in code.
5531 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5532 Rewrite doc-string.
5533 (Fset_window_configuration, saved_window)
5534 (Fcurrent_window_configuration, save_window_save): Handle new
5535 members of window structure.
5536 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5537 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5538 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5539 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5540 Qget_mru_window, Qresize_root_window,
5541 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5542 Qauto_buffer_name; staticpro them.
5543
5544 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5545
5546 * window.c (Fwindow_total_size, Fwindow_left_column)
5547 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5548 (Fwindow_list_1): New functions.
5549 (window_box_text_cols): Replace with window_body_cols.
5550 (Fwindow_width, Fscroll_left, Fscroll_right):
5551 Use window_body_cols instead of window_box_text_cols.
5552 (delete_window, Fset_window_configuration):
5553 Call delete_all_subwindows with window as argument.
5554 (delete_all_subwindows): Take a window as argument and not a
5555 structure. Rewrite.
5556 (window_loop): Remove handling of GET_LRU_WINDOW and
5557 GET_LARGEST_WINDOW.
5558 (Fget_lru_window, Fget_largest_window): Move to window.el.
5559
5560 * window.h: Extern window_body_cols instead of
5561 window_box_text_cols. delete_all_subwindows now takes a
5562 Lisp_Object as argument.
5563
5564 * indent.c (compute_motion, Fcompute_motion):
5565 Use window_body_cols instead of window_box_text_cols.
5566
5567 * frame.c (delete_frame): Call delete_all_subwindows with root
5568 window as argument.
5569
5570 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5571
5572 * fns.c (Fputhash): Document return value.
5573
5574 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5575
5576 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5577
5578 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5579
5580 Cons<->int and similar integer overflow fixes (Bug#8794).
5581
5582 Check for overflow when converting integer to cons and back.
5583 * charset.c (Fdefine_charset_internal, Fdecode_char):
5584 Use cons_to_unsigned to catch overflow.
5585 (Fencode_char): Use INTEGER_TO_CONS.
5586 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5587 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5588 * data.c (long_to_cons, cons_to_long): Remove.
5589 (cons_to_unsigned, cons_to_signed): New functions.
5590 These signal an error for invalid or out-of-range values.
5591 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5592 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5593 * font.c (Ffont_variation_glyphs):
5594 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5595 * lisp.h: Include <intprops.h>.
5596 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5597 (cons_to_signed, cons_to_unsigned): New decls.
5598 (long_to_cons, cons_to_long): Remove decls.
5599 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5600 (Fprimitive_undo): Use CONS_TO_INTEGER.
5601 * xfns.c (Fx_window_property): Likewise.
5602 * xselect.c: Include <limits.h>.
5603 (x_own_selection, selection_data_to_lisp_data):
5604 Use INTEGER_TO_CONS.
5605 (x_handle_selection_request, x_handle_selection_clear)
5606 (x_get_foreign_selection, Fx_disown_selection_internal)
5607 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5608 (lisp_data_to_selection_data): Use cons_to_unsigned.
5609 (x_fill_property_data): Use cons_to_signed.
5610 Report values out of range.
5611
5612 Check for buffer and string overflow more precisely.
5613 * buffer.h (BUF_BYTES_MAX): New macro.
5614 * lisp.h (STRING_BYTES_MAX): New macro.
5615 * alloc.c (Fmake_string):
5616 * character.c (string_escape_byte8):
5617 * coding.c (coding_alloc_by_realloc):
5618 * doprnt.c (doprnt):
5619 * editfns.c (Fformat):
5620 * eval.c (verror):
5621 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5622 since they may not be the same number.
5623 * editfns.c (Finsert_char):
5624 * fileio.c (Finsert_file_contents):
5625 Likewise for BUF_BYTES_MAX.
5626
5627 * image.c: Use ptrdiff_t, not int, for sizes.
5628 (slurp_file): Switch from int to ptrdiff_t.
5629 All uses changed.
5630 (slurp_file): Check that file size fits in both size_t (for
5631 malloc) and ptrdiff_t (for sanity and safety).
5632
5633 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5634 if b->modtime has its maximal value.
5635
5636 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5637
5638 Don't assume time_t can fit into int.
5639 * buffer.h (struct buffer.modtime): Now time_t, not int.
5640 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5641 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5642
5643 Minor fixes for signed vs unsigned integers.
5644 * character.h (MAYBE_UNIFY_CHAR):
5645 * charset.c (maybe_unify_char):
5646 * keyboard.c (read_char, reorder_modifiers):
5647 XINT -> XFASTINT, since the integer must be nonnegative.
5648 * ftfont.c (ftfont_spec_pattern):
5649 * keymap.c (access_keymap, silly_event_symbol_error):
5650 XUINT -> XFASTINT, since the integer must be nonnegative.
5651 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5652 since it makes no difference and we prefer signed.
5653 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5654 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5655 nonnegative.
5656
5657 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5658
5659 * window.h (Fwindow_frame): Declare.
5660
5661 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5662
5663 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5664 (SPARE_MEMORY): Always define.
5665 (LARGE_REQUEST): Remove.
5666 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5667
5668 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5669
5670 * lisp.h: Move EXFUNS for Fframe_root_window,
5671 Fframe_first_window and Fset_frame_selected_window to window.h.
5672
5673 * window.h: Move EXFUNS for Fframe_root_window,
5674 Fframe_first_window and Fset_frame_selected_window here from
5675 lisp.h.
5676
5677 * frame.c (Fwindow_frame, Fframe_first_window)
5678 (Fframe_root_window, Fframe_selected_window)
5679 (Fset_frame_selected_window): Move to window.c.
5680 (Factive_minibuffer_window): Move to minibuf.c.
5681 (Fother_visible_frames_p): New function.
5682
5683 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5684
5685 * window.c (decode_window, decode_any_window): Move up in code.
5686 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5687 (inhibit_frame_unsplittable): Remove unused variable.
5688 (Fwindow_buffer): Move up and rewrite doc-string.
5689 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5690 (Fwindow_prev): New functions.
5691 (Fwindow_frame): Move here from frame.c. Accept any window as
5692 argument.
5693 (Fframe_root_window, Fframe_first_window)
5694 (Fframe_selected_window): Move here from frame.c. Accept frame
5695 or arbitrary window as argument. Update doc-strings.
5696 (Fminibuffer_window): Move up in code.
5697 (Fwindow_minibuffer_p): Move up in code and simplify.
5698 (Fset_frame_selected_window): Move here from frame.c.
5699 Marginal rewrite.
5700 (Fselected_window, select_window, Fselect_window): Move up in
5701 code. Minor doc-string fixes.
5702
5703 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5704
5705 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5706 Do not assume that spare memory exists; that assumption is valid
5707 only if SYSTEM_MALLOC.
5708 (LARGE_REQUEST): New macro, so that the issue of large requests
5709 is separated from the issue of spare memory.
5710
5711 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5712
5713 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5714 format. (Bug#8806)
5715
5716 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5717
5718 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5719 before statements.
5720
5721 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5722
5723 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5724
5725 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5726
5727 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5728 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5729
5730 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5731
5732 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5733
5734 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5735
5736 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5737 (x_clipboard_manager_save): Add return value.
5738 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5739 New error handlers.
5740 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5741 Obey Vx_select_enable_clipboard_manager. Catch errors in
5742 x_clipboard_manager_save (Bug#8779).
5743 (Vx_select_enable_clipboard_manager): New variable.
5744 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5745
5746 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5747
5748 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5749
5750 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5751
5752 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5753 in the current matrix if keep_current_p is non-zero.
5754
5755 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5756
5757 * bidi.c (bidi_level_of_next_char): Fix last change.
5758
5759 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5760
5761 Support bidi reordering of text covered by display properties.
5762
5763 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5764 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5765 (bidi_cache_search, bidi_cache_iterator_state)
5766 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5767 (bidi_level_of_next_char, bidi_move_to_visually_next):
5768 Support character positions inside a run of characters covered by a
5769 display string.
5770 (bidi_paragraph_init, bidi_resolve_explicit_1)
5771 (bidi_level_of_next_char): Call bidi_fetch_char and
5772 bidi_fetch_char_advance instead of FETCH_CHAR and
5773 FETCH_CHAR_ADVANCE.
5774 (bidi_init_it): Initialize new members.
5775 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5776 definitions.
5777 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5778 instead of using explicit *_CHAR codes.
5779 (bidi_resolve_explicit, bidi_resolve_weak):
5780 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5781 bidirectional text is supported only in multibyte buffers.
5782 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5783 it to initialize the frame_window_p member of struct bidi_it.
5784 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5785 (bidi_resolve_explicit, bidi_resolve_weak)
5786 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5787 bidi_it->nchars is non-positive.
5788 (bidi_level_of_next_char): Don't try to lookup the cache for the
5789 next/previous character if nothing is cached there yet, or if we
5790 were just reseat()'ed to a new position.
5791
5792 * xdisp.c (set_cursor_from_row): Set start and stop points
5793 according to the row's direction when priming the loop that looks
5794 for the glyph on which to display cursor.
5795 (single_display_spec_intangible_p): Function deleted.
5796 (display_prop_intangible_p): Reimplement to call
5797 handle_display_spec instead of single_display_spec_intangible_p.
5798 Accept 3 additional arguments needed by handle_display_spec.
5799 This fixes incorrect cursor motion across display property with complex
5800 values: lists, `(when COND...)' forms, etc.
5801 (single_display_spec_string_p): Support property values that are
5802 lists with the argument STRING its top-level element.
5803 (display_prop_string_p): Fix the condition for processing a
5804 property that is a list to be consistent with handle_display_spec.
5805 (handle_display_spec): New function, refactored from the
5806 last portion of handle_display_prop.
5807 (compute_display_string_pos): Accept additional argument
5808 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5809 value of a `display' property is a "replacing spec".
5810 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5811 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5812 the display property, but just return a value indicating whether
5813 the display property will replace the characters it covers.
5814 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5815 frame_window_p members of struct bidi_it.
5816 (compute_display_string_pos, compute_display_string_end):
5817 New functions.
5818 (push_it): Accept second argument POSITION, where pop_it should
5819 jump to continue iteration.
5820 (reseat_1): Initialize bidi_it.disp_pos.
5821
5822 * keyboard.c (adjust_point_for_property): Adjust the call to
5823 display_prop_intangible_p to its new signature.
5824
5825 * dispextern.h (struct bidi_it): New member frame_window_p.
5826 (bidi_init_it): Update prototypes.
5827 (display_prop_intangible_p): Update prototype.
5828 (compute_display_string_pos, compute_display_string_end):
5829 Declare prototypes.
5830 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5831 EMACS_INT.
5832
5833 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5834
5835 Malloc failure behavior now depends on size of allocation.
5836 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5837 * lisp.h: Change signatures accordingly.
5838 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5839 All callers changed. (Bug#8762)
5840
5841 * gnutls.c: Use Emacs's memory allocators.
5842 Without this change, the gnutls library would invoke malloc etc.
5843 directly, which causes problems on non-SYNC_INPUT hosts, and which
5844 runs afoul of improving memory_full behavior. (Bug#8761)
5845 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5846 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5847 xfree instead of the default malloc, realloc, free.
5848 (Fgnutls_boot): No need to check for memory allocation failure,
5849 since xmalloc does that for us.
5850
5851 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5852 * category.c (hash_get_category_set):
5853 * ccl.c (ccl_driver):
5854 * charset.c (Fdefine_charset_internal):
5855 * charset.h (struct charset.hash_index):
5856 * composite.c (get_composition_id, gstring_lookup_cache)
5857 (composition_gstring_put_cache):
5858 * composite.h (struct composition.hash_index):
5859 * dispextern.h (struct image.hash):
5860 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5861 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5862 (hashfn_equal, hashfn_user_defined, make_hash_table)
5863 (maybe_resize_hash_table, hash_lookup, hash_put)
5864 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5865 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5866 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5867 * image.c (make_image, search_image_cache, lookup_image)
5868 (xpm_put_color_table_h):
5869 * lisp.h (struct Lisp_Hash_Table):
5870 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5871 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5872 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5873 * alloc.c (allocate_vectorlike):
5874 Check for overflow in vector size calculations.
5875 * ccl.c (ccl_driver):
5876 Check for overflow when converting EMACS_INT to int.
5877 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5878 need to be updated by these changes.
5879 * fns.c (make_hash_table, maybe_resize_hash_table):
5880 Check for integer overflow with large hash tables.
5881 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5882 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5883 (SXHASH_REDUCE): New macro.
5884 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5885 Use it instead of discarding useful hash info with large hash values.
5886 (sxhash_float): New function.
5887 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5888 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5889 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5890 Rewrite to use FIXNUM_BITS, as this simplifies things.
5891 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5892 Adjust signatures to match updated version of code.
5893 (consing_since_gc): Now EMACS_INT, since a single hash table can
5894 use more than INT_MAX bytes.
5895
5896 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5897
5898 Make it possible to build with GCC-4.6+ -O2 -flto.
5899
5900 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5901
5902 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5903
5904 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5905 Call minibuffer-inactive-mode.
5906
5907 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5908
5909 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5910 Update dependencies.
5911
5912 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5913
5914 * data.c (init_data): Remove code for UTS, this system is not
5915 supported anymore.
5916
5917 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5918
5919 Don't force ./temacs to start in terminal mode.
5920
5921 * frame.c (make_initial_frame): Initialize faces in all cases, not
5922 only when CANNOT_DUMP is defined.
5923 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5924
5925 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5926
5927 * dispnew.c (add_window_display_history): Use const for the string
5928 pointer. Remove declaration, not needed.
5929
5930 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5931
5932 Use 'inline', not 'INLINE'.
5933 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5934 * alloc.c, fontset.c (INLINE): Remove.
5935 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5936 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5937 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5938 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5939 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5940
5941 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5942
5943 Make it possible to run ./temacs.
5944
5945 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5946 syms_of_callproc does the same thing. Remove test for
5947 "initialized", do it in the caller.
5948 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5949
5950 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5951
5952 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5953 (read_minibuf): Use get_minibuffer.
5954 (syms_of_minibuf): Use DEFSYM.
5955 (Qmetadata): New var.
5956 * data.c (Qbuffer): Don't make it static.
5957 (syms_of_data): Use DEFSYM.
5958
5959 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5960
5961 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5962 (CCL_CODE_MIN): New macro.
5963
5964 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5965
5966 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5967
5968 * eval.c (Qdebug): Now static.
5969 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5970 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5971 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5972
5973 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5974
5975 * image.c: Various fixes to ImageMagick code comments.
5976 (Fimagemagick_types): Doc fix.
5977
5978 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5979
5980 Minor fixes prompted by GCC 4.6.0 warnings.
5981
5982 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5983
5984 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5985 (x_clipboard_manager_save_all): Move extern decl to ...
5986 * xterm.h: ... here, so that it can be checked for consistency.
5987
5988 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5989
5990 * xselect.c (x_clipboard_manager_save_frame)
5991 (x_clipboard_manager_save_all): New functions.
5992 (Fx_clipboard_manager_save): Lisp function deleted.
5993
5994 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5995 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5996
5997 * xterm.h: Update prototype.
5998
5999 2011-05-28 William Xu <william.xwl@gmail.com>
6000
6001 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6002 exiting (Bug#8239).
6003
6004 2011-05-28 Jim Meyering <meyering@redhat.com>
6005
6006 Avoid a sign-extension bug in crypto_hash_function.
6007 * fns.c (to_uchar): Define.
6008 (crypto_hash_function): Use it to convert some newly-signed
6009 variables to unsigned, to avoid sign-extension bugs. For example,
6010 without this change, (md5 "truc") would evaluate to
6011 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6012 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6013 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6014
6015 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6016
6017 Integer overflow fixes.
6018
6019 * dbusbind.c: Serial number integer overflow fixes.
6020 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6021 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6022 to hold a serial number that is too large for a fixnum.
6023 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6024 Check for serial numbers out of range. Decode any serial number
6025 that was so large that it became a float. (Bug#8722)
6026
6027 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6028 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6029 Use XFASTINT rather than XUINT when numbers are nonnegative.
6030 (xd_append_arg, Fdbus_method_return_internal):
6031 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6032 arguments, check that Lisp number is nonnegative, rather than
6033 silently wrapping negative numbers around. (Bug#8722)
6034 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6035 (Bug#8722)
6036
6037 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6038
6039 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6040
6041 ccl: Add integer overflow checks.
6042 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6043 (IN_INT_RANGE): New macros.
6044 (ccl_driver): Use them to check for integer overflow when
6045 decoding a CCL program. Many of the new checks are whether XINT (x)
6046 fits in int; it doesn't always, on 64-bit hosts. The new version
6047 doesn't catch all possible integer overflows, but it's an
6048 improvement. (Bug#8719)
6049
6050 * alloc.c (make_event_array): Use XINT, not XUINT.
6051 There's no need for unsigned here.
6052
6053 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6054 This follows up to the 2011-05-06 change that substituted uintptr_t
6055 for EMACS_INT. This case wasn't caught back then.
6056
6057 Rework Fformat to avoid integer overflow issues.
6058 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6059 now (part of C89). Include <verify.h>.
6060 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6061 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6062 (Fformat): Avoid the prepass trying to compute sizes; it was only
6063 approximate and thus did not catch overflow reliably. Instead, walk
6064 through the format just once, formatting and computing sizes as we go,
6065 checking for integer overflow at every step, and allocating a larger
6066 buffer as needed. Keep track separately whether the format is
6067 multibyte. Keep only the most-recently calculated precision, rather
6068 than them all. Record whether each argument has been converted to
6069 string. Use EMACS_INT, not int, for byte and char and arg counts.
6070 Support field widths and precisions larger than INT_MAX. Avoid
6071 sprintf's undefined behavior with conversion specifications such as %#d
6072 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6073 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6074 formatting out-of-range floating point numbers with int
6075 formats. (Bug#8668)
6076
6077 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6078
6079 * data.c: Avoid integer truncation in expressions involving floats.
6080 * data.c: Include <intprops.h>.
6081 (arith_driver): When there's an integer overflow in an expression
6082 involving floating point, convert the integers to floating point
6083 so that the resulting value does not suffer from catastrophic
6084 integer truncation. For example, on a 64-bit host (* 4
6085 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6086 Do not rely on undefined behavior after integer overflow.
6087
6088 merge count_size_as_multibyte, parse_str_to_multibyte
6089 * character.c, character.h (count_size_as_multibyte):
6090 Rename from parse_str_to_multibyte; all uses changed.
6091 Check for integer overflow.
6092 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6093 since it's now a duplicate of the other. This is more of
6094 a character than a buffer op, so better that it's in character.c.
6095 * fns.c, print.c: Adjust to above changes.
6096
6097 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6098
6099 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6100
6101 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6102
6103 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6104 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6105 (x_clipboard_manager_save): Now static.
6106 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6107
6108 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6109 (crypto_hash_function): Now static.
6110 Fix pointer signedness problems. Avoid unnecessary initializations.
6111
6112 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6113
6114 * termhooks.h (Vselection_alist): Make it terminal-local.
6115
6116 * terminal.c (create_terminal): Initialize it.
6117
6118 * xselect.c: Support for clipboard managers.
6119 (Vselection_alist): Move to termhooks.h as terminal-local var.
6120 (LOCAL_SELECTION): New macro.
6121 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6122 (symbol_to_x_atom): Remove gratuitous arg.
6123 (x_handle_selection_request, lisp_data_to_selection_data)
6124 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6125 (x_own_selection, x_get_local_selection, x_convert_selection):
6126 New arg, specifying work frame. Use terminal-local Vselection_alist.
6127 (some_frame_on_display): Delete unused function.
6128 (Fx_own_selection_internal, Fx_get_selection_internal)
6129 (Fx_disown_selection_internal, Fx_selection_owner_p)
6130 (Fx_selection_exists_p): New optional frame arg.
6131 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6132 (x_handle_selection_clear): Don't treat other terminals with the
6133 same keyboard specially. Use the terminal-local Vselection_alist.
6134 (x_clear_frame_selections): Use Frun_hook_with_args.
6135
6136 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6137
6138 * xterm.h: Add support for those atoms.
6139
6140 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6141
6142 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6143 (converted_selections, conversion_fail_tag): New global variables.
6144 (x_selection_request_lisp_error): Free the above.
6145 (x_get_local_selection): Remove unnecessary code.
6146 (x_reply_selection_request): Args changed; handle arbitrary array
6147 of converted selections stored in converted_selections.
6148 Separate the XChangeProperty and SelectionNotify steps.
6149 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6150 (x_convert_selection): New function.
6151 (x_handle_selection_event): Simplify.
6152 (x_get_foreign_selection): Don't ignore incoming requests while
6153 waiting for an answer; this will fail when we implement
6154 SAVE_TARGETS, and seems unnecessary anyway.
6155 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6156 (Vx_sent_selection_functions): Doc fix.
6157
6158 2011-05-26 Leo Liu <sdl.web@gmail.com>
6159
6160 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6161
6162 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6163
6164 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6165
6166 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6167 for fringe update if it has periodic bitmap.
6168 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6169 and fringe_bitmap_periodic_p.
6170
6171 * fringe.c (get_fringe_bitmap_data): New function.
6172 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6173 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6174 row. Mark glyph row for fringe update if periodicity changed.
6175
6176 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6177 for fringe update unless it has periodic bitmap.
6178
6179 2011-05-25 Kenichi Handa <handa@m17n.org>
6180
6181 * xdisp.c (get_next_display_element): Set correct it->face_id for
6182 a static composition.
6183
6184 2011-05-24 Leo Liu <sdl.web@gmail.com>
6185
6186 * deps.mk (fns.o):
6187 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6188
6189 * fns.c (crypto_hash_function, Fsha1): New function.
6190 (Fmd5): Use crypto_hash_function.
6191 (syms_of_fns): Add Ssha1.
6192
6193 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6194
6195 * gnutls.c: Remove unused macros.
6196 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6197 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6198 Remove macros that are defined and never used.
6199 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6200
6201 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6202
6203 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6204 (Fx_get_selection_internal): Minor cleanup.
6205 (Fx_own_selection_internal): Rename arguments for consistency with
6206 select.el.
6207
6208 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6209
6210 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6211
6212 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6213
6214 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6215
6216 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6217
6218 * dispnew.c (scrolling_window): Don't exclude the case that the
6219 last enabled row in the desired matrix touches the bottom boundary.
6220
6221 2011-05-21 Glenn Morris <rgm@gnu.org>
6222
6223 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6224 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6225 and add some more files.
6226
6227 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6228
6229 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6230 report_file_error introduced by the change from 2011-05-07.
6231
6232 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6233
6234 * systime.h (Time): Define only if emacs is defined.
6235 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6236 where the include path doesn't have X11/X.h by default. See
6237 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6238
6239 2011-05-20 Kenichi Handa <handa@m17n.org>
6240
6241 * composite.c (find_automatic_composition): Fix previous change.
6242
6243 2011-05-20 Glenn Morris <rgm@gnu.org>
6244
6245 * lisp.mk: New file, split from Makefile.in.
6246 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6247 (shortlisp): Remove.
6248 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6249
6250 2011-05-19 Glenn Morris <rgm@gnu.org>
6251
6252 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6253 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6254 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6255 (lisp): Set the order to that of loadup.el.
6256 (shortlisp): Make it a copy of $lisp.
6257 (SOME_MACHINE_LISP): Remove.
6258 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6259 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6260
6261 2011-05-18 Kenichi Handa <handa@m17n.org>
6262
6263 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6264 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6265 (find_automatic_composition): Mostly rewrite for efficiency.
6266
6267 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6268
6269 * makefile.w32-in: Update dependencies.
6270
6271 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6272
6273 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6274 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6275
6276 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6277
6278 Fix some integer overflow issues, such as string length overflow.
6279
6280 * insdel.c (count_size_as_multibyte): Check for string overflow.
6281
6282 * character.c (lisp_string_width): Check for string overflow.
6283 Use EMACS_INT, not int, for string indexes and lengths; in
6284 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6285 the resulting string length overflows an EMACS_INT; instead,
6286 report a string overflow if no precision given. When checking for
6287 precision exhaustion, use a check that cannot possibly have
6288 integer overflow. (Bug#8675)
6289 * character.h (lisp_string_width): Adjust to new signature.
6290
6291 * alloc.c (string_overflow): New function.
6292 (Fmake_string): Use it. This doesn't change behavior, but saves
6293 a few bytes and will simplify future changes.
6294 * character.c (string_escape_byte8): Likewise.
6295 * lisp.h (string_overflow): New decl.
6296
6297 Fixups, following up to the user-interface timestamp change.
6298 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6299 for UI timestamps, instead of unsigned long.
6300 * msdos.c (mouse_get_pos): Likewise.
6301 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6302 * w32gui.h (Time): Define by including "systime.h" rather than by
6303 declaring it ourselves. (Bug#8664)
6304
6305 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6306 * image.c (clear_image_cache): Likewise.
6307
6308 * term.c (term_mouse_position): Don't assume time_t wraparound.
6309
6310 Be more systematic about user-interface timestamps.
6311 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6312 and sometimes 'EMACS_UINT', to represent these timestamps.
6313 This change causes it to use 'Time' uniformly, as that's what X uses.
6314 This makes the code easier to follow, and makes it easier to catch
6315 integer overflow bugs such as Bug#8664.
6316 * frame.c (Fmouse_position, Fmouse_pixel_position):
6317 Use Time, not unsigned long, for user-interface timestamps.
6318 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6319 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6320 * keyboard.h (last_event_timestamp): Likewise.
6321 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6322 * menu.h (xmenu_show): Likewise.
6323 * term.c (term_mouse_position): Likewise.
6324 * termhooks.h (struct input_event.timestamp): Likewise.
6325 (struct terminal.mouse_position_hook): Likewise.
6326 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6327 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6328 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6329 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6330 what it was before.
6331 * menu.h, termhooks.h: Include "systime.h", for Time.
6332
6333 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6334 Don't assume that the difference between two unsigned long values
6335 can fit into an integer. At this point, we know button_down_time
6336 <= event->timestamp, so the difference must be nonnegative, so
6337 there's no need to cast the result if double-click-time is
6338 nonnegative, as it should be; check that it's nonnegative, just in
6339 case. This bug is triggered when events are more than 2**31 ms
6340 apart (about 25 days). (Bug#8664)
6341
6342 * xselect.c (last_event_timestamp): Remove duplicate decl.
6343 (x_own_selection): Remove needless cast to unsigned long.
6344
6345 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6346 that always fit in int. Use a sentinel instead of a counter, to
6347 avoid a temp and to allay GCC's concerns about possible int overflow.
6348 * frame.h (struct frame): Use int for menu_bar_items_used
6349 instead of EMACS_INT, since it always fits in int.
6350
6351 * menu.c (grow_menu_items): Check for int overflow.
6352
6353 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6354
6355 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6356 Before, the code was not consistent. These values cannot exceed
6357 2**31 - 1 so there's no need to make them unsigned.
6358 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6359 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6360 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6361 as modifiers.
6362 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6363
6364 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6365 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6366 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6367 presumably because the widths might not match.
6368
6369 * window.c (size_window): Avoid needless test at loop start.
6370
6371 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6372
6373 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6374
6375 2011-05-12 Drew Adams <drew.adams@oracle.com>
6376
6377 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6378
6379 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6380
6381 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6382 `width' to `bar_area_x' and `bar_area_width', respectively.
6383 (x_scroll_run): Take account of fringe background extension.
6384
6385 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6386 Rename local vars `left' and `width' to `bar_area_x' and
6387 `bar_area_width', respectively.
6388 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6389 background extension.
6390
6391 2011-05-10 Jim Meyering <meyering@redhat.com>
6392
6393 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6394
6395 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6396
6397 * image.c (Finit_image_library): Return t for built-in image types,
6398 like pbm and xbm. (Bug#8640)
6399
6400 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6401
6402 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6403
6404 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6405
6406 * w32console.c (Fset_screen_color): Doc fix.
6407 (Fget_screen_color): New function.
6408 (syms_of_ntterm): Defsubr it.
6409
6410 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6411 unlink the temporary file if Fcall_process didn't create it in the
6412 first place.
6413 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6414 child process will be redirected to a file specified with `:file'.
6415 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6416 cue to call_process_cleanup not to close that handle.
6417
6418 2011-05-07 Ben Key <bkey76@gmail.com>
6419
6420 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6421 one of two shell specific rules, either bootstrap-temacs-CMD or
6422 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6423 to the previous implementation of the bootstrap-temacs rule.
6424 The bootstrap-temacs-CMD rule is similar to the previous
6425 implementation of the bootstrap-temacs rule except that it
6426 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6427 variable.
6428
6429 These changes, along with some changes to nt/configure.bat,
6430 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6431 earlier fix to add support for --cflags and --ldflags options
6432 that include quotes so that it works whether make uses cmd or
6433 sh as the shell.
6434
6435 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6436
6437 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6438 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6439 is a constant.
6440 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6441 a string. Handle both cases.
6442 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6443 (Fdbus_register_method): Use Qinvalid_function.
6444
6445 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6446
6447 * makefile.w32-in: Update dependencies.
6448 (LISP_H): Add inttypes.h and stdin.h.
6449 (PROCESS_H): Add unistd.h.
6450
6451 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6452
6453 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6454 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6455
6456 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6457
6458 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6459
6460 * term.c (vfatal): Remove stray call to va_end.
6461 It's not needed and the C Standard doesn't allow it here anyway.
6462
6463 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6464 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6465
6466 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6467 bytes.
6468
6469 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6470
6471 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6472
6473 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6474
6475 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6476
6477 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6478
6479 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6480 * charset.c (Fdefine_charset_internal): Don't initialize
6481 charset.code_space[15]. The value was garbage, on hosts with
6482 32-bit int (Bug#8600).
6483
6484 * lread.c (read_integer): Be more consistent with string-to-number.
6485 Use string_to_number to do the actual conversion; this avoids
6486 rounding errors and fixes some other screwups. Without this fix,
6487 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6488 (digit_to_number): Move earlier, for benefit of read_integer.
6489 Return -1 if the digit is out of range for the base, -2 if it is
6490 not a digit in any supported base. (Bug#8602)
6491
6492 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6493
6494 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6495 to match comment at start of function. This also removes a
6496 GCC warning about overflow in a 32+64-bit port.
6497
6498 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6499
6500 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6501 Reported by Stefan Monnier in
6502 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6503 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6504 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6505
6506 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6507 (EMACS_UINTPTR): Likewise, with uintptr_t.
6508
6509 * lisp.h: Prefer 64-bit EMACS_INT if available.
6510 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6511 on 32-bit hosts that have 64-bit int, so that they can access
6512 large files.
6513 However, temporarily disable this change unless the temporary
6514 symbol WIDE_EMACS_INT is defined.
6515
6516 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6517
6518 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6519 This removes an assumption that EMACS_INT and long are the same
6520 width as pointers. The assumption is true for Emacs porting targets
6521 now, but we want to make other targets possible.
6522 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6523 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6524 In the rest of the code, change types of integers that hold casted
6525 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6526 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6527 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6528 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6529 No need to cast type when ORing.
6530 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6531 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6532 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6533 assume EMACS_INT is the same width as char *.
6534 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6535 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6536 Remove no-longer-needed casts.
6537 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6538 (xg_tool_bar_help_callback, xg_make_tool_item):
6539 Use EMACS_INTPTR to hold an integer
6540 that will be cast to void *; this can avoid a GCC warning
6541 if EMACS_INT is not the same width as void *.
6542 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6543 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6544 (current_message_1, set_message_1):
6545 Use a local to convert to proper width without a cast.
6546 * xmenu.c (dialog_selection_callback): Likewise.
6547
6548 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6549 Also, don't assume VALBITS / RAND_BITS is less than 5,
6550 and don't rely on undefined behavior when shifting a 1 left into
6551 the sign bit.
6552 * lisp.h (get_random): Change signature to match.
6553
6554 * lread.c (hash_string): Use size_t, not int, for hash computation.
6555 Normally we prefer signed values; but hashing is special, because
6556 it's better to use unsigned division on hash table sizes so that
6557 the remainder is nonnegative. Also, size_t is the natural width
6558 for hashing into memory. The previous code used 'int', which doesn't
6559 retain enough info to hash well into very large tables.
6560 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6561
6562 * dbusbind.c: Don't possibly lose pointer info when converting.
6563 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6564 Use XPNTR rather than XHASH, so that the high-order bits of
6565 the pointer aren't lost when converting through void *.
6566
6567 * eval.c (Fautoload): Don't double-shift a pointer.
6568
6569 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6570
6571 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6572
6573 * gnutls.c (DEF_GNUTLS_FN):
6574 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6575
6576 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6577
6578 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6579 marker. (Bug#8610)
6580
6581 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6582
6583 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6584 New version that can reserve upto 2GB of heap space.
6585
6586 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6587
6588 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6589
6590 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6591
6592 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6593 `gnutls_certificate_set_x509_key_file'.
6594
6595 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6596
6597 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6598 Update dependencies.
6599
6600 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6601
6602 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6603 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6604 Remove unused parameter `fildes'.
6605 * process.c (read_process_output, send_process): Don't pass it.
6606
6607 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6608
6609 Fix previous change: the library cache is defined in w32.c.
6610 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6611 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6612
6613 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6614
6615 Implement dynamic loading of GnuTLS on Windows.
6616
6617 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6618 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6619 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6620 Declare.
6621
6622 * gnutls.c (Qgnutls_dll): Define.
6623 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6624 (gnutls_*): Declare function pointers.
6625 (init_gnutls_functions): New function to initialize function pointers.
6626 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6627 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6628 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6629 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6630 (emacs_gnutls_write, emacs_gnutls_read)
6631 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6632 (Fgnutls_available_p): New function.
6633 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6634 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6635 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6636
6637 * image.c: Include w32.h.
6638 (Vimage_type_cache): Delete.
6639 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6640 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6641 (w32_delayed_load): Move to w32.c.
6642
6643 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6644
6645 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6646 (w32_delayed_load): Move from image.c. When loading a library, record
6647 its filename in the :loaded-from property of the library id.
6648 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6649 Initialize and staticpro them.
6650 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6651
6652 * process.c: Include lisp.h before w32.h, not after.
6653 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6654 instead of gnutls_record_check_pending.
6655
6656 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6657
6658 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6659
6660 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6661 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6662 as passed in.
6663
6664 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6665
6666 * xterm.c (x_set_frame_alpha): Do not set property on anything
6667 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6668
6669 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6670
6671 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6672
6673 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6674
6675 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6676 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6677 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6678 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6679 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6680 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6681 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6682 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6683 (Qgnutls_bootprop_callbacks_verify): Make static.
6684
6685 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6686
6687 * callproc.c: Indentation fixup.
6688
6689 * sysdep.c (wait_for_termination_1): Make static.
6690 (wait_for_termination, interruptible_wait_for_termination):
6691 Move after wait_for_termination_1.
6692
6693 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6694
6695 * sysdep.c (interruptible_wait_for_termination): New function
6696 which is like wait_for_termination, but allows keyboard
6697 interruptions.
6698
6699 * callproc.c (Fcall_process): Add (:file "file") as an option for
6700 the STDOUT buffer.
6701 (Fcall_process_region): Ditto.
6702
6703 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6704
6705 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6706 rather than `XVECTOR (FOO)->size'.
6707
6708 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6709 inttypes.h, as a gnulib replacement is used if it not available in
6710 system headers.
6711
6712 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6713
6714 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6715 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6716 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6717
6718 * coding.c (coding_alloc_by_realloc): Error out if destination
6719 will grow beyond MOST_POSITIVE_FIXNUM.
6720 (decode_coding_emacs_mule): Abort if there isn't enough place in
6721 charbuf for the composition carryover bytes. Reserve an extra
6722 space for up to 2 characters produced in a loop.
6723 (decode_coding_iso_2022): Abort if there isn't enough place in
6724 charbuf for the composition carryover bytes.
6725
6726 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6727
6728 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6729 aborting when %lld or %lll format is passed.
6730 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6731 %llo or %llx format is passed. (Bug#8545)
6732
6733 * window.c (window_scroll_line_based): Use a marker instead of
6734 simple variables to record original value of point. (Bug#7952)
6735
6736 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6737 produced by %s or %c overflows available buffer space. (Bug#8545)
6738
6739 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6740
6741 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6742 (SIZE_MAX): Move defn after all includes, as they might #define it.
6743
6744 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6745
6746 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6747
6748 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6749
6750 * keyboard.c (Qdelayed_warnings_hook): Define.
6751 (command_loop_1): Run `delayed-warnings-hook'
6752 if Vdelayed_warnings_list is non-nil.
6753 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6754 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6755
6756 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6757
6758 * doprnt.c (doprnt): Don't return value smaller than the buffer
6759 size if the message was truncated. (Bug#8545).
6760
6761 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6762
6763 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6764 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6765
6766 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6767
6768 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6769
6770 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6771
6772 * makefile.w32-in: Update dependencies.
6773
6774 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6775
6776 Improve `doprnt' and its usage. (Bug#8545)
6777 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6778 `format_end'. Remove support for %l as a conversion specifier.
6779 Don't use xrealloc. Improve diagnostics when the %l size modifier
6780 is used. Update the commentary.
6781
6782 * eval.c (verror): Simplify calculation of size_t.
6783
6784 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6785 messages.
6786
6787 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6788
6789 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6790 change.
6791
6792 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6793
6794 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6795 This makes this file independent of the recent pseudovector change.
6796
6797 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6798
6799 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6800
6801 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6802 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6803 Remove unused local.
6804 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6805
6806 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6807 GCC 4.6.0 optimizes based on type-based alias analysis.
6808 For example, if b is of type struct buffer * and v of type struct
6809 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6810 != &v->size, and therefore "v->size = 1; b->size = 2; return
6811 v->size;" must therefore return 1. This assumption is incorrect
6812 for Emacs, since it type-puns struct Lisp_Vector * with many other
6813 types. To fix this problem, this patch adds a new type struct
6814 vectorlike_header that documents the constraints on layout of vectors
6815 and pseudovectors, and helps optimizing compilers not get fooled
6816 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6817 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6818 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6819 the size member.
6820 (XSETPVECTYPE): Rewrite in terms of new macro.
6821 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6822 This is a bit clearer, and further avoids the possibility of
6823 undesirable aliasing.
6824 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6825 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6826 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6827 since Lisp_Subr is a special case (no "next" field).
6828 (ASIZE): Now uses header.size rather than size.
6829 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6830 to avoid the hassle of writing XVECTOR (foo)->header.size.
6831 (struct vectorlike_header): New type.
6832 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6833 object, to help avoid aliasing.
6834 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6835 (SUBRP): Likewise, since Lisp_Subr is a special case.
6836 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6837 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6838 (struct Lisp_Hash_Table): Combine first two members into a single
6839 struct vectorlike_header member. All uses of "size" and "next" members
6840 changed to be "header.size" and "header.next".
6841 * buffer.h (struct buffer): Likewise.
6842 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6843 * frame.h (struct frame): Likewise.
6844 * process.h (struct Lisp_Process): Likewise.
6845 * termhooks.h (struct terminal): Likewise.
6846 * window.c (struct save_window_data, struct saved_window): Likewise.
6847 * window.h (struct window): Likewise.
6848 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6849 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6850 * buffer.c (init_buffer_once): Likewise.
6851 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6852 special case.
6853 * process.c (Fformat_network_address): Use local var for size,
6854 for brevity.
6855
6856 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6857
6858 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6859 * data.c (atof): Remove decl; no longer used or needed.
6860 (digit_to_number): Move to lread.c.
6861 (Fstring_to_number): Use new string_to_number function, to be
6862 consistent with how the Lisp reader treats infinities and NaNs.
6863 Do not assume that floating-point numbers represent EMACS_INT
6864 without losing information; this is not true on most 64-bit hosts.
6865 Avoid double-rounding errors, by insisting on integers when
6866 parsing non-base-10 numbers, as the documentation specifies.
6867 * lisp.h (string_to_number): New decl, replacing ...
6868 (isfloat_string): Remove.
6869 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6870 (read1): Do not accept +. and -. as integers; this
6871 appears to have been a coding error. Similarly, do not accept
6872 strings like +-1e0 as floating point numbers. Do not report
6873 overflow for integer overflows unless the base is not 10 which
6874 means we have no simple and reliable way to continue.
6875 Break out the floating-point parsing into a new
6876 function string_to_number, so that Fstring_to_number parses
6877 floating point numbers consistently with the Lisp reader.
6878 (digit_to_number): Move here from data.c. Make it static inline.
6879 (E_CHAR, EXP_INT): Remove, replacing with ...
6880 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6881 (string_to_number): New function, replacing isfloat_string.
6882 This function checks for valid syntax and produces the resulting
6883 Lisp float number too. Rework it so that string-to-number
6884 no longer mishandles examples like "1.0e+". Use strtoumax,
6885 so that overflow for non-base-10 numbers is reported only when
6886 there's no portable and simple way to convert to floating point.
6887
6888 * textprop.c (set_text_properties_1): Rewrite for clarity,
6889 and to avoid GCC warning about integer overflow.
6890
6891 * intervals.h (struct interval): Use EMACS_INT for members
6892 where EMACS_UINT might cause problems. See
6893 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6894 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6895 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6896 All uses changed.
6897 (offset_intervals): Tell GCC not to worry about length overflow
6898 when negating a negative length.
6899
6900 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6901 (overrun_check_free): Likewise.
6902
6903 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6904 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6905 word size.
6906
6907 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6908 (gnutls_make_error): Rename local to avoid shadowing.
6909 (gnutls_emacs_global_deinit): ifdef out; not used.
6910 (Fgnutls_boot): Use const for pointer to readonly storage.
6911 Comment out unused local. Fix pointer signedness problems.
6912
6913 * lread.c (openp): Don't stuff size_t into an 'int'.
6914 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6915 about possible signed overflow.
6916
6917 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6918 (GDK_KEY_g): Don't define if already defined.
6919 (xg_prepare_tooltip): Avoid pointer signedness problem.
6920 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6921
6922 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6923 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6924
6925 * xfns.c (Fx_window_property): Simplify a bit,
6926 to make a bit faster and to avoid GCC 4.6.0 warning.
6927 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6928
6929 * fns.c (internal_equal): Don't assume size_t fits in int.
6930
6931 * alloc.c (compact_small_strings): Tighten assertion a little.
6932
6933 Replace pEd with more-general pI, and fix some printf arg casts.
6934 * lisp.h (pI): New macro, generalizing old pEd macro to other
6935 conversion specifiers. For example, use "...%"pI"d..." rather
6936 than "...%"pEd"...".
6937 (pEd): Remove. All uses replaced with similar uses of pI.
6938 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6939 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6940 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6941 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6942 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6943 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6944 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6945 64-bit hosts.
6946 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6947 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6948 * print.c (safe_debug_print, print_object): Likewise.
6949 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6950 to int.
6951 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6952 avoiding the 0 flag, which is not portable.
6953 * process.c (Fmake_network_process): Use pI to avoid cast.
6954 * region-cache.c (pp_cache): Likewise.
6955 * xdisp.c (decode_mode_spec): Likewise.
6956 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6957 behavior on 64-bit hosts with printf arg.
6958 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6959 (x_stop_queuing_selection_requests): Likewise.
6960 (x_get_window_property): Don't truncate byte count to an 'int'
6961 when tracing.
6962
6963 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6964 here, since it parses constructs like leading '-' and spaces,
6965 which are not wanted; and it overflows with large numbers.
6966 Instead, simply match F[0-9]+, which is what is wanted anyway.
6967
6968 * alloc.c: Remove unportable assumptions about struct layout.
6969 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6970 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6971 (allocate_vectorlike, make_pure_vector): Use the new macros,
6972 plus offsetof, to remove unportable assumptions about struct layout.
6973 These assumptions hold on all porting targets that I know of, but
6974 they are not guaranteed, they're easy to remove, and removing them
6975 makes further changes easier.
6976
6977 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6978 This doesn't fix a bug but makes the code clearer.
6979 (string_overrun_cookie): Now const. Use initializers that
6980 don't formally overflow signed char, to avoid warnings.
6981 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6982 can cause Emacs to crash when string overrun checking is enabled.
6983 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6984 multiple of sizeof (EMACS_INT); it need not be, if
6985 alignof(EMACS_INT) < sizeof (EMACS_INT).
6986 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6987
6988 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6989
6990 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6991
6992 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6993
6994 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6995 supposed to be handshaking. (Bug#8556)
6996 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6997
6998 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6999
7000 * lisp.h (Qdebug): List symbol.
7001 * eval.c (Qdebug): Restore global linkage.
7002 * keyboard.c (debug-on-event): New variable.
7003 (handle_user_signal): Break into debugger when debug-on-event
7004 matches the current signal symbol.
7005
7006 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7007
7008 * alloc.c (check_sblock, check_string_bytes)
7009 (check_string_free_list): Convert to standard C.
7010
7011 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7012
7013 * w32.c (emacs_gnutls_push): Fix typo.
7014
7015 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7016
7017 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7018 "cast to pointer from integer of different size".
7019
7020 Improve doprnt and its use in verror. (Bug#8545)
7021 * doprnt.c (doprnt): Document the set of format control sequences
7022 supported by the function. Use SAFE_ALLOCA instead of always
7023 using `alloca'.
7024
7025 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7026 is one byte too soon. Don't use xrealloc; instead xfree and
7027 xmalloc anew.
7028
7029 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7030
7031 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7032 callbacks stage.
7033
7034 * gnutls.c: Renamed global_initialized to
7035 gnutls_global_initialized. Added internals for the
7036 :verify-hostname-error, :verify-error, and :verify-flags
7037 parameters of `gnutls-boot' and documented those parameters in the
7038 docstring. Start callback support.
7039 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7040 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7041 on error. Return error code.
7042 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7043 (emacs_gnutls_read): Likewise.
7044 (Fgnutls_boot): Return handshake error code.
7045 (emacs_gnutls_handle_error): New function.
7046 (wsaerror_to_errno): Likewise.
7047
7048 * w32.h (emacs_gnutls_pull): Add prototype.
7049 (emacs_gnutls_push): Likewise.
7050
7051 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7052 (emacs_gnutls_push): Likewise.
7053
7054 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7055
7056 * process.c (wait_reading_process_output): Check if GnuTLS
7057 buffered some data internally if no FDs are set for TLS
7058 connections.
7059
7060 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7061 (LIBS): Link to USER_LIBS.
7062 ($(BLD)/gnutls.$(0)): New target.
7063
7064 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7065
7066 * xdisp.c (handle_single_display_spec): Rename the
7067 display_replaced_before_p argument into display_replaced_p, to
7068 make it consistent with the commentary. Fix typos in the
7069 commentary.
7070
7071 * textprop.c (syms_of_textprop): Remove dead code.
7072 (copy_text_properties): Delete obsolete commentary about an
7073 interface that was deleted long ago. Fix typos in the description
7074 of arguments.
7075
7076 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7077 to changes in oldXMenu/XMenu.h from 2011-04-16.
7078 <menu_help_message, prev_menu_help_message>: Constify.
7079 (IT_menu_make_room): menu->help_text is now `const char **';
7080 adjust.
7081
7082 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7083 to changes in oldXMenu/XMenu.h from 2011-04-16.
7084 (struct XMenu): Declare `help_text' `const char **'.
7085
7086 * xfaces.c <Qunspecified>: Make extern again.
7087
7088 * syntax.c: Include sys/types.h before including regex.h, as
7089 required by Posix.
7090
7091 * doc.c (get_doc_string): Improve the format passed to `error'.
7092
7093 * doprnt.c (doprnt): Improve commentary.
7094
7095 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7096
7097 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7098 them with etags.
7099
7100 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7101 changes in globals.h immediately force recompilation.
7102 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7103 $(CURDIR)/s/ms-w32.h.
7104 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7105
7106 * character.c (Fchar_direction): Function deleted.
7107 (syms_of_character): Don't defsubr it.
7108 <char-direction-table>: Deleted.
7109
7110 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7111
7112 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7113 * doprnt.c: Include limits.h.
7114 (SIZE_MAX): New macro.
7115 (doprnt): Return a size_t value. 2nd arg is now size_t.
7116 Many local variables are now size_t instead of int or unsigned.
7117 Improve overflow protection. Support `l' modifier for integer
7118 conversions. Support %l conversion. Don't assume an EMACS_INT
7119 argument for integer conversions and for %c.
7120
7121 * lisp.h (doprnt): Restore prototype.
7122
7123 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7124 $(SRC)/character.h.
7125
7126 * Makefile.in (base_obj): Add back doprnt.o.
7127
7128 * deps.mk (doprnt.o): Add back prerequisites.
7129 (callint.o): Depend on character.h.
7130
7131 * eval.c (internal_lisp_condition_case): Include the handler
7132 representation in the error message.
7133 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7134 when breaking from the loop.
7135
7136 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7137
7138 * callint.c (Fcall_interactively): When displaying error message
7139 about invalid control letter, pass the character's codepoint, not
7140 a pointer to its multibyte form. Improve display of the character
7141 in octal and display also its hex code.
7142
7143 * character.c (char_string): Use %x to display the (unsigned)
7144 codepoint of an invalid character, to avoid displaying a bogus
7145 negative value.
7146
7147 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7148 `error', not SYMBOL_NAME itself.
7149
7150 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7151 character arguments to `error'.
7152
7153 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7154 to `error' in error message about FINAL_CHAR argument. Make sure
7155 FINAL_CHAR is a character, and use %c when it is passed as
7156 argument to `error'.
7157
7158 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7159
7160 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7161
7162 * w32.c: Include <time.h>.
7163 (sys_localtime): New function.
7164
7165 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7166
7167 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7168
7169 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7170
7171 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7172
7173 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7174 zombies (Bug#8467).
7175
7176 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7177
7178 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7179 gl_state.e_property when gl_state.object is Qt.
7180
7181 * insdel.c (make_gap_larger): Remove limitation of buffer size
7182 to <= INT_MAX.
7183
7184 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7185
7186 * xdisp.c (lookup_glyphless_char_display)
7187 (produce_glyphless_glyph): Handle cons cell entry in
7188 glyphless-char-display.
7189 (Vglyphless_char_display): Document it.
7190
7191 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7192 glyphless-char-display.
7193
7194 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7195
7196 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7197
7198 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7199
7200 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7201 definition for no-X builds.
7202
7203 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7204
7205 Static checks with GCC 4.6.0 and non-default toolkits.
7206
7207 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7208
7209 * process.c (keyboard_bit_set): Define only if SIGIO.
7210 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7211 (send_process): Repair possible setjmp clobbering.
7212
7213 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7214
7215 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7216
7217 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7218
7219 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7220 Define only if needed.
7221
7222 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7223 by pacifying GCC about it. Maybe it's time to retire it?
7224 * xfaces.c (USG, __TIMEVAL__): Likewise.
7225
7226 * dispextern.h (struct redisplay_interface): Rename param
7227 to avoid shadowing.
7228 * termhooks.h (struct terminal): Likewise.
7229 * xterm.c (xembed_send_message): Likewise.
7230
7231 * insdel.c (make_gap_smaller): Define only if
7232 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7233
7234 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7235 it.
7236
7237 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7238 so that we aren't warned about unused symbols.
7239
7240 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7241
7242 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7243
7244 * xfns.c (x_real_positions): Mark locals as initialized.
7245
7246 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7247
7248 * xterm.c: Fix problems found by static analysis with other toolkits.
7249 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7250 (x_dispatch_event): Declare static if USE_GTK, and
7251 define if USE_GTK || USE_X_TOOLKIT.
7252 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7253 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7254 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7255 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7256
7257 * xmenu.c (menu_help_callback): Pointer type fixes.
7258 Use const pointers when pointing at readonly data. Avoid pointer
7259 signedness clashes.
7260 (FALSE): Remove unused macro.
7261 (update_frame_menubar): Remove unused decl.
7262
7263 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7264
7265 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7266 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7267 (single_menu_item): Rename local to avoid shadowing.
7268
7269 * keyboard.c (make_lispy_event): Remove unused local var.
7270
7271 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7272 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7273
7274 * bitmaps: Change bitmaps from unsigned char back to the X11
7275 compatible char. Avoid the old compiler warnings about
7276 out-of-range initializers by using, for example, '\xab' rather
7277 than 0xab.
7278
7279 * xgselect.c (xgselect_initialize): Check vs interface
7280 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7281
7282 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7283
7284 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7285 to read-only memory.
7286
7287 * fns.c (vector): Remove; this old hack is no longer needed.
7288
7289 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7290 Remove unused var.
7291 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7292
7293 * xrdb.c (x_load_resources): Omit unused local.
7294
7295 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7296 (x_window): Rename locals to avoid shadowing.
7297 (USG): Use the kludged USG macro, to pacify gcc.
7298
7299 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7300 (x_term_init): Remove local to avoid shadowing.
7301
7302 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7303
7304 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7305 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7306
7307 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7308
7309 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7310
7311 Fix regex.c, syntax.c and friends for buffers > 2GB.
7312 * syntax.h (struct gl_state_s): Declare character position members
7313 EMACS_INT.
7314
7315 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7316
7317 * textprop.c (verify_interval_modification, interval_of):
7318 Declare arguments EMACS_INT.
7319
7320 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7321 EMACS_INT.
7322
7323 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7324
7325 * indent.c (Fvertical_motion): Local variable it_start is now
7326 EMACS_INT.
7327
7328 * regex.c (re_match, re_match_2, re_match_2_internal)
7329 (bcmp_translate, regcomp, regexec, print_double_string)
7330 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7331 (re_compile_pattern, re_exec): Declare arguments and local
7332 variables `size_t' and `ssize_t' and return values `regoff_t', as
7333 appropriate.
7334 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7335 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7336 <compile_stack_type>: `size' and `avail' are now `size_t'.
7337
7338 * regex.h <regoff_t>: Use ssize_t, not int.
7339 (re_search, re_search_2, re_match, re_match_2): Arguments that
7340 specify buffer/string position and length are now ssize_t and
7341 size_t. Return type is regoff_t.
7342
7343 2011-04-16 Ben Key <bkey76@gmail.com>
7344
7345 * nsfont.m: Fixed bugs in ns_get_family and
7346 ns_descriptor_to_entity that were caused by using free to
7347 deallocate memory blocks that were allocated by xmalloc (via
7348 xstrdup). This caused Emacs to crash when compiled with
7349 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7350 --enable-checking=xmallocoverrun). xfree is now used to
7351 deallocate these memory blocks.
7352
7353 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7354
7355 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7356
7357 emacs_write: Accept and return EMACS_INT for sizes.
7358 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7359 et seq.
7360 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7361 Accept and return EMACS_INT.
7362 (emacs_gnutls_write): Return the number of bytes written on
7363 partial writes.
7364 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7365 (emacs_read, emacs_write): Remove check for negative size, as the
7366 Emacs source code has been audited now.
7367 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7368 (emacs_read, emacs_write): Use it.
7369 * process.c (send_process): Adjust to the new signatures of
7370 emacs_write and emacs_gnutls_write. Do not attempt to store
7371 a byte offset into an 'int'; it might overflow.
7372 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7373
7374 * sound.c: Don't assume sizes fit in 'int'.
7375 (struct sound_device.period_size, alsa_period_size):
7376 Return EMACS_INT, not int.
7377 (struct sound_device.write, vox_write, alsa_write):
7378 Accept EMACS_INT, not int.
7379 (wav_play, au_play): Use EMACS_INT to store sizes and to
7380 record read return values.
7381
7382 2011-04-15 Ben Key <bkey76@gmail.com>
7383
7384 * keyboard.c (Qundefined): Don't declare static since it is used
7385 in nsfns.m.
7386 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7387 static since they are used in nsfont.m.
7388
7389 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7390
7391 * process.c (Qprocessp): Don't declare static.
7392 * lisp.h (Qprocessp): Declare again.
7393
7394 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7395
7396 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7397
7398 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7399
7400 Improve C-level modularity by making more things 'static'.
7401
7402 Don't publish debugger-only interfaces to other modules.
7403 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7404 (verify_bytepos, count_markers): Move decls to the only modules
7405 that need them.
7406 * region-cache.h (pp_cache): Likewise.
7407 * window.h (check_all_windows): Likewise.
7408 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7409
7410 * sysdep.c (croak): Now static, if
7411 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7412 * syssignal.h (croak): Declare only if not static.
7413
7414 * alloc.c (refill_memory_reserve): Now static if
7415 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7416 * lisp.h (refill_memory_reserve): Declare only if not static.
7417
7418 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7419 Define only if USE_LUCID.
7420
7421 * xrdb.c (x_customization_string, x_rm_string): Now static.
7422
7423 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7424 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7425
7426 * xdisp.c (draw_row_with_mouse_face): Now static.
7427 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7428
7429 * window.h (check_all_windows): Mark externally visible.
7430
7431 * window.c (window_deletion_count): Now static.
7432
7433 * undo.c: Make symbols static if they're not exported.
7434 (last_undo_buffer, last_boundary_position, pending_boundary):
7435 Now static.
7436
7437 * textprop.c (interval_insert_behind_hooks): Now static.
7438 (interval_insert_in_front_hooks): Likewise.
7439
7440 * term.c: Make symbols static if they're not exported.
7441 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7442 (max_frame_lines, tty_set_terminal_modes):
7443 (tty_reset_terminal_modes, tty_turn_off_highlight):
7444 (get_tty_terminal): Now static.
7445 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7446 * termhooks.h (term_mouse_moveto): Do not declare if
7447 HAVE_WINDOW_SYSTEM.
7448 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7449 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7450
7451 * sysdep.c: Make symbols static if they're not exported.
7452 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7453 Now static.
7454 (sigprocmask_set, full_mask): Remove; unused.
7455 (wait_debugging): Mark as visible.
7456 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7457 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7458
7459 * syntax.c (syntax_temp): Define only if !__GNUC__.
7460
7461 * sound.c (current_sound_device, current_sound): Now static.
7462
7463 * search.c (searchbufs, searchbuf_head): Now static.
7464
7465 * scroll.c (scroll_cost): Remove; unused.
7466 * dispextern.h (scroll_cost): Remove decl.
7467
7468 * region-cache.h (pp_cache): Mark as externally visible.
7469
7470 * process.c: Make symbols static if they're not exported.
7471 (process_tick, update_tick, create_process, chan_process):
7472 (Vprocess_alist, proc_buffered_char, datagram_access):
7473 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7474 (deactivate_process): Mark defn as static, as well as decl.
7475 * lisp.h (create_process): Remove decl.
7476 * process.h (chan_process, Vprocess_alist): Remove decls.
7477
7478 * print.c: Make symbols static if they're not exported.
7479 (print_depth, new_backquote_output, being_printed, print_buffer):
7480 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7481 (print_interval, print_number_index, initial_stderr_stream):
7482 Now static.
7483 * lisp.h (Fprinc): Remove decl.
7484 (debug_output_compilation_hack): Mark as externally visible.
7485
7486 * sysdep.c (croak): Move decl from here to syssignal.h.
7487 * syssignal.h (croak): Put it here, so the API can be checked when
7488 'croak' is called from dissociate_if_controlling_tty.
7489
7490 * minibuf.c: Make symbols static if they're not exported.
7491 (minibuf_save_list, choose_minibuf_frame): Now static.
7492 * lisp.h (choose_minibuf_frame): Remove decl.
7493
7494 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7495
7496 * lread.c: Make symbols static if they're not exported.
7497 (read_objects, initial_obarray, oblookup_last_bucket_number):
7498 Now static.
7499 (make_symbol): Remove; unused.
7500 * lisp.h (initial_obarray, make_symbol): Remove decls.
7501
7502 * keyboard.c: Make symbols static if they're not exported.
7503 (single_kboard, recent_keys_index, total_keys, recent_keys):
7504 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7505 (this_single_command_key_start, echoing, last_auto_save):
7506 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7507 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7508 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7509 (Vlispy_mouse_stem, double_click_count):
7510 Now static.
7511 (force_auto_save_soon): Define only if SIGDANGER.
7512 (ignore_mouse_drag_p): Now static if
7513 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7514 (print_help): Remove; unused.
7515 (stop_character, last_timer_event): Mark as externally visible.
7516 * keyboard.h (ignore_mouse_drag_p): Declare only if
7517 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7518 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7519 * lisp.h (echoing): Remove decl.
7520 (force_auto_save_soon): Declare only if SIGDANGER.
7521 * xdisp.c (redisplay_window): Simplify code, to make it more
7522 obvious that ignore_mouse_drag_p is not accessed if !defined
7523 USE_GTK && !defined HAVE_NS.
7524
7525 * intervals.c: Make symbols static if they're not exported.
7526 (merge_properties_sticky, merge_interval_right, delete_interval):
7527 Now static.
7528 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7529
7530 * insdel.c: Make symbols static if they're not exported.
7531 However, leave prepare_to_modify_buffer alone. It's never
7532 called from outside this function, but that appears to be a bug.
7533 (combine_after_change_list, combine_after_change_buffer):
7534 (adjust_after_replace, signal_before_change): Now static.
7535 (adjust_after_replace_noundo): Remove; unused.
7536 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7537 (signal_before_change): Remove decls.
7538
7539 * indent.c (val_compute_motion, val_vmotion): Now static.
7540
7541 * image.c: Make symbols static if they're not exported.
7542 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7543 if USE_GTK.
7544 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7545 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7546
7547 * fringe.c (standard_bitmaps): Now static.
7548 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7549
7550 * frame.c: Make symbols static if they're not exported.
7551 (x_report_frame_params, make_terminal_frame): Now static.
7552 (get_frame_param): Now static, unless HAVE_NS.
7553 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7554 (x_get_resource_string): Remove; not used.
7555 * frame.h (make_terminal_frame, x_report_frame_params):
7556 (x_get_resource_string); Remove decls.
7557 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7558 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7559
7560 * font.c, fontset.c: Make symbols static if they're not exported.
7561 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7562 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7563 * font.c (font_close_object): Now static.
7564 * font.h (font_close_object): Remove.
7565 * fontset.c (FONTSET_OBJLIST): Remove.
7566 (free_realized_fontset) #if-0 the body, which does nothing.
7567 (face_suitable_for_char_p): #if-0, as it's never called.
7568 * fontset.h (face_suitable_for_char_p): Remove decl.
7569 * xfaces.c (face_at_string_position):
7570 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7571 since 0 is always ASCII.
7572
7573 * fns.c (weak_hash_tables): Now static.
7574
7575 * fileio.c: Make symbols static if they're not exported.
7576 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7577 (Vwrite_region_annotation_buffers): Now static.
7578
7579 * eval.c: Make symbols static if they're not exported.
7580 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7581 * lisp.h (backtrace_list): Remove decl.
7582
7583 * emacs.c: Make symbols static if they're not exported.
7584 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7585 (fatal_error_code, fatal_error_signal_hook, standard_args):
7586 Now static.
7587 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7588 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7589 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7590 * lisp.h (fatal_error_signal_hook): Remove decl.
7591 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7592
7593 * editfns.c: Move a (normally-unused) function to its only use.
7594 * editfns.c, lisp.h (get_operating_system_release): Remove.
7595 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7596 worth the hassle of breaking this out.
7597
7598 * xterm.c: Make symbols static if they're not exported.
7599 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7600 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7601 (x_destroy_window, x_delete_display):
7602 Now static.
7603 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7604 (x_mouse_leave): Remove; unused.
7605 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7606 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7607 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7608 Remove decls.
7609 (x_mouse_leave): Declare only if WINDOWSNT.
7610 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7611 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7612 USE_X_TOOLKIT.
7613
7614 * ftxfont.c: Make symbols static if they're not exported.
7615 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7616 HAVE_FREETYPE.
7617 * font.h (ftxfont_driver): Likewise.
7618
7619 * xfns.c: Make symbols static if they're not exported.
7620 (x_last_font_name, x_display_info_for_name):
7621 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7622 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7623 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7624 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7625 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7626 (last_show_tip_args): Now static.
7627 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7628 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7629 (x_screen_planes): Remove; unused.
7630 * dispextern.h (x_screen_planes): Remove decl.
7631
7632 * dispnew.c: Make symbols static if they're not exported.
7633 * dispextern.h (redraw_garbaged_frames, scrolling):
7634 (increment_row_positions): Remove.
7635 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7636 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7637 Now static.
7638 (redraw_garbaged_frames): Remove; unused.
7639
7640 * xfaces.c: Make symbols static if they're not exported.
7641 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7642 Remove decls.
7643 * xterm.h (defined_color): Remove decls.
7644 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7645 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7646 (menu_face_changed_default, defined_color, free_realized_face):
7647 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7648 (ascii_face_of_lisp_face): Remove; unused.
7649
7650 * xdisp.c: Make symbols static if they're not exported.
7651 * dispextern.h (scratch_glyph_row, window_box_edges):
7652 (glyph_to_pixel_coords, set_cursor_from_row):
7653 (get_next_display_element, set_iterator_to_next):
7654 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7655 (show_mouse_face): Remove decls
7656 * frame.h (message_buf_print): Likewise.
7657 * lisp.h (pop_message, set_message, check_point_in_composition):
7658 Likewise.
7659 * xterm.h (set_vertical_scroll_bar): Likewise.
7660 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7661 (message_buf_print, scratch_glyph_row, displayed_buffer):
7662 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7663 (get_next_display_element, show_mouse_face, window_box_edges):
7664 (frame_to_window_pixel_xy, check_point_in_composition):
7665 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7666 (glyph_to_pixel_coords): Remove; unused.
7667
7668 * dired.c (file_name_completion): Now static.
7669
7670 * dbusbind.c (xd_in_read_queued_messages): Now static.
7671
7672 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7673 * data.c (circular_list_error): Remove.
7674
7675 * commands.h (last_point_position, last_point_position_buffer):
7676 (last_point_position_window): Remove decls.
7677 * keyboard.c: Make these variables static.
7678
7679 * coding.h (coding, code_convert_region, encode_coding_gap):
7680 Remove decls.
7681 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7682 (iso_code_class, detect_coding, code_convert_region): Now static.
7683 (encode_coding_gap): Remove; unused.
7684
7685 * chartab.c (chartab_chars, chartab_bits): Now static.
7686
7687 * charset.h (charset_iso_8859_1): Remove decl.
7688 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7689 Now static.
7690
7691 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7692 * ccl.c (Vccl_program_table): Now static.
7693 (check_ccl_update): Remove; unused.
7694
7695 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7696 * category.h: ... from here.
7697 * category.c (check_category_table, set_category_set): Now static.
7698
7699 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7700 * lisp.h: Remove these decls.
7701
7702 * buffer.c (buffer_count): Remove unused var.
7703
7704 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7705 so that it's not optimized away.
7706 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7707 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7708 exported only to the debugger.
7709
7710 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7711 * atimer.h (run_all_atimers): Remove; not exported.
7712
7713 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7714 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7715 was inaccessible from Lisp.
7716 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7717 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7718
7719 alloc.c: Import and export fewer symbols, and remove unused items.
7720 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7721 is defined.
7722 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7723 it's not optimized away by whole-program optimization.
7724 (message_enable_multibyte, free_misc): Remove.
7725 (catchlist, handlerlist, mark_backtrace):
7726 Declare only if BYTE_MARK_STACK.
7727 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7728 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7729 (message_enable_multibyte): Remove decl.
7730 (free_misc, interval_free_list, float_block, float_block_index):
7731 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7732 (cons_free_list, last_marked_index):
7733 Now static.
7734 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7735 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7736 (mark_backtrace): Define only if BYTE_MARK_STACK.
7737 * xdisp.c (message_enable_multibyte): Now static.
7738
7739 Declare Lisp_Object Q* variables to be 'static' if not exported.
7740 This makes it easier for human readers (and static analyzers)
7741 to see whether these variables are used from other modules.
7742 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7743 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7744 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7745 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7746 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7747 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7748 * xmenu.c, xselect.c:
7749 Declare Q* vars static if they are not used in other modules.
7750 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7751 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7752 Remove decls of unexported vars.
7753 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7754
7755 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7756
7757 Make Emacs functions such as Fatom 'static' by default.
7758 This makes it easier for human readers (and static analyzers)
7759 to see whether these functions can be called from other modules.
7760 DEFUN now defines a static function. To make the function external
7761 so that it can be used in other C modules, use the new macro DEFUE.
7762 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7763 (Finit_image_library):
7764 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7765 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7766 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7767 Remove decls, since these functions are now static.
7768 (Funintern, Fget_internal_run_time): New decls, since these functions
7769 were already external.
7770
7771 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7772 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7773 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7774 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7775 * keyboard.c, keymap.c, lread.c:
7776 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7777 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7778 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7779 Mark functions with DEFUE instead of DEFUN,
7780 if they are used in other modules.
7781 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7782 decls for now-static functions.
7783 * buffer.h (Fdelete_overlay): Remove decl.
7784 * callproc.c (Fgetenv_internal): Mark as internal.
7785 * composite.c (Fremove_list_of_text_properties): Remove decl.
7786 (Fcomposition_get_gstring): New forward static decl.
7787 * composite.h (Fcomposite_get_gstring): Remove decl.
7788 * dired.c (Ffile_attributes): New forward static decl.
7789 * doc.c (Fdocumntation_property): New forward static decl.
7790 * eval.c (Ffetch_bytecode): New forward static decl.
7791 (Funintern): Remove extern decl; now in .h file where it belongs.
7792 * fileio.c (Fmake_symbolic_link): New forward static decl.
7793 * image.c (Finit_image_library): New forward static decl.
7794 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7795 * intervals.h (Fprevious_property_change):
7796 (Fremove_list_of_text_properties): Remove decls.
7797 * keyboard.c (Fthis_command_keys): Remove decl.
7798 (Fcommand_execute): New forward static decl.
7799 * keymap.c (Flookup_key): New forward static decl.
7800 (Fcopy_keymap): Now static.
7801 * keymap.h (Flookup_key): Remove decl.
7802 * process.c (Fget_process): New forward static decl.
7803 (Fprocess_datagram_address): Mark as internal.
7804 * syntax.c (Fsyntax_table_p): New forward static decl.
7805 (skip_chars): Remove duplicate decl.
7806 * textprop.c (Fprevious_property_change): New forward static decl.
7807 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7808 Now internal.
7809 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7810 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7811
7812 * editfns.c (Fformat): Remove unreachable code.
7813
7814 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7815
7816 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7817 change. (Bug#8496)
7818
7819 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7820
7821 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7822 when at ZV. (Bug#8487)
7823
7824 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7825
7826 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7827 (Bug#8437)
7828 * keyboard.c (parse_tool_bar_item): Likewise.
7829 * sound.c (sound_cleanup, alsa_close): Likewise.
7830 * termcap.c (tgetent): Likewise.
7831 * xfns.c (x_default_font_parameter): Likewise.
7832 * xsettings.c (read_and_apply_settings): Likewise.
7833
7834 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7835 (overrun_check_free): Protoize.
7836
7837 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7838
7839 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7840 since callers should never pass a negative size.
7841 Change the signature to match that of plain 'read' and 'write'; see
7842 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7843 * lisp.h: Update prototypes of emacs_write and emacs_read.
7844
7845 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7846
7847 * xdisp.c (redisplay_window): Don't try to determine the character
7848 position of the scroll margin if the window start point w->startp
7849 is outside the buffer's accessible region. (Bug#8468)
7850
7851 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7852
7853 Fix write-region and its subroutines for buffers > 2GB.
7854 * fileio.c (a_write, e_write): Modify declaration of arguments and
7855 local variables to support buffers larger than 2GB.
7856 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7857
7858 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7859 argument, local variables, and return value.
7860
7861 * lisp.h: Update prototypes of emacs_write and emacs_read.
7862
7863 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7864
7865 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7866
7867 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7868
7869 Fix more problems found by GCC 4.6.0's static checks.
7870
7871 * xdisp.c (vmessage): Use a better test for character truncation.
7872
7873 * charset.c (load_charset_map): <, not <=, for optimization,
7874 and to avoid potential problems with integer overflow.
7875 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7876 * casetab.c (set_identity, shuffle): Likewise.
7877 * editfns.c (Fformat): Likewise.
7878 * syntax.c (skip_chars): Likewise.
7879
7880 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7881 This also lets GCC 4.6.0 generate slightly better loop code.
7882
7883 * callint.c (Fcall_interactively): <, not <=, for optimization.
7884 (Fcall_interactively): Count the number of arguments produced,
7885 not the number of arguments given. This is simpler and lets GCC
7886 4.6.0 generate slightly better code.
7887
7888 * ftfont.c: Distingish more carefully between FcChar8 and char.
7889 The previous code passed unsigned char * to a functions like
7890 strlen and xstrcasecmp that expect char *, which does not
7891 conform to the C standard.
7892 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7893 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7894 char * when the C standard requires it.
7895
7896 * keyboard.c (read_char): Remove unused var.
7897
7898 * eval.c: Port to Windows vsnprintf (Bug#8435).
7899 Include <limits.h>.
7900 (SIZE_MAX): Define if the headers do not.
7901 (verror): Do not give up if vsnprintf returns a negative count.
7902 Instead, grow the buffer. This ports to Windows vsnprintf, which
7903 does not conform to C99. Problem reported by Eli Zaretskii.
7904 Also, simplify the allocation scheme, by avoiding the need for
7905 calling realloc, and removing the ALLOCATED variable.
7906
7907 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7908
7909 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7910 But keep the doprint source code for now, as we might revamp it
7911 and use it again (Bug#8435).
7912 * lisp.h (doprnt): Remove.
7913 * Makefile.in (base_obj): Remove doprnt.o.
7914 * deps.mk (doprnt.o): Remove.
7915
7916 error: Print 32- and 64-bit integers portably (Bug#8435).
7917 Without this change, on typical 64-bit hosts error ("...%d...", N)
7918 was used to print both 32- and 64-bit integers N, which relied on
7919 undefined behavior.
7920 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7921 * lisp.h (error, verror): Mark as printf-like functions.
7922 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7923 Report overflow in size calculations when allocating printf buffer.
7924 Do not truncate output string at its first null byte.
7925 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7926 Truncate the output at a character boundary, since vsnprintf does not
7927 do that.
7928 * charset.c (check_iso_charset_parameter): Convert internal
7929 character to string before calling 'error', since %c now has the
7930 printf meaning.
7931 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7932 overflow when computing char to be passed to 'error'. Do not
7933 pass Lisp_Object to 'error'; pass the integer instead.
7934 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7935 formatted with plain %d.
7936
7937 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7938
7939 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7940
7941 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7942
7943 * xterm.c (x_catch_errors): Remove duplicate declaration.
7944
7945 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7946
7947 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7948
7949 2011-04-10 Jim Meyering <meyering@redhat.com>
7950
7951 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7952 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7953 return ssize_t not "int", and use size_t as the buffer length.
7954 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7955 * gnutls.h: Update declarations.
7956 * process.c (read_process_output): Use ssize_t, to match.
7957 (send_process): Likewise.
7958
7959 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7960
7961 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7962
7963 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7964
7965 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7966 Use unsigned char, to match FcChar8 type definition.
7967
7968 * xterm.c (handle_one_xevent):
7969 * xmenu.c (create_and_show_popup_menu):
7970 * xselect.c (x_decline_selection_request)
7971 (x_reply_selection_request): Avoid type-punned deref of X events.
7972
7973 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7974
7975 Fix some uses of `int' instead of EMACS_INT.
7976 * search.c (string_match_1, fast_string_match)
7977 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7978 (scan_buffer, find_next_newline_no_quit)
7979 (find_before_next_newline, search_command, Freplace_match)
7980 (Fmatch_data): Make some `int' variables be EMACS_INT.
7981
7982 * xdisp.c (display_count_lines): 3rd argument and return value now
7983 EMACS_INT. All callers changed.
7984 (pint2hrstr): Last argument is now EMACS_INT.
7985
7986 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7987 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7988 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7989 (decode_coding_utf_16, decode_coding_emacs_mule)
7990 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7991 (decode_coding_ccl, decode_coding_charset)
7992 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7993 (decode_coding_iso_2022, decode_coding_emacs_mule)
7994 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7995 <char_offset, last_offset>: Declare EMACS_INT.
7996 (encode_coding_utf_8, encode_coding_utf_16)
7997 (encode_coding_emacs_mule, encode_invocation_designation)
7998 (encode_designation_at_bol, encode_coding_iso_2022)
7999 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8000 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8001 Declare EMACS_INT.
8002 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8003 (encode_invocation_designation): Last argument P_NCHARS is now
8004 EMACS_INT.
8005 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8006 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8007
8008 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8009 All users changed.
8010
8011 * ccl.c (Fccl_execute_on_string): Declare some variables
8012 EMACS_INT.
8013
8014 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8015
8016 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8017
8018 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8019
8020 * process.c (Fformat_network_address): Doc fix.
8021
8022 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8023
8024 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8025
8026 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8027
8028 * keyboard.c (read_char): Call Lisp function help-form-show,
8029 instead of using internal_with_output_to_temp_buffer.
8030 (Qhelp_form_show): New var.
8031 (syms_of_keyboard): Use DEFSYM macro.
8032
8033 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8034
8035 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8036
8037 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8038
8039 * process.c (Flist_processes): Remove to Lisp.
8040 (list_processes_1): Delete.
8041
8042 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8043
8044 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8045
8046 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8047
8048 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8049
8050 Fix more problems found by GCC 4.6.0's static checks.
8051
8052 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8053
8054 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8055
8056 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8057
8058 * xdisp.c (vmessage): Mark as a printf-like function.
8059
8060 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8061
8062 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8063
8064 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8065 printf-like functions.
8066 (tiff_load): Add casts to remove these marks before passing them
8067 to system-supplied API.
8068
8069 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8070
8071 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8072 This avoids several warnings with gcc -Wstrict-overflow.
8073 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8074 directly, rather than having caller test rule sign. This avoids
8075 some unnecessary tests.
8076 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8077 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8078 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8079
8080 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8081 (xfont_open): Avoid unnecessary tests.
8082
8083 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8084
8085 * composite.h, composite.c (composition_gstring_put_cache):
8086 Use EMACS_INT, not int, for length.
8087
8088 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8089 breaking out part of COMPOSITION_DECODE_RULE.
8090 (COMPOSITION_DECODE_RULE): Use it.
8091 * composite.c (get_composition_id): Remove unused local vars,
8092 by using the new macro.
8093
8094 * textprop.c (set_text_properties_1): Change while to do-while,
8095 since the condition is always true at first.
8096
8097 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8098 (interval_deletion_adjustment): Return unsigned value.
8099 All uses changed.
8100
8101 * process.c (list_processes_1, create_pty, read_process_output):
8102 (exec_sentinel): Remove vars that were set but not used.
8103 (create_pty): Remove unnecessary "volatile"s.
8104 (Fnetwork_interface_info): Avoid possibility of int overflow.
8105 (read_process_output): Do adaptive read buffering even if carryover.
8106 (read_process_output): Simplify nbytes computation if buffered.
8107
8108 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8109
8110 * syntax.c (scan_words): Remove var that was set but not used.
8111 (update_syntax_table): Use unsigned instead of int.
8112
8113 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8114 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8115 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8116
8117 * print.c (print_error_message): Avoid int overflow.
8118
8119 * font.c (font_list_entities): Redo for clarity,
8120 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8121
8122 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8123 (font_score): Avoid potential overflow in diff calculation.
8124
8125 * fns.c (substring_both): Remove var that is set but not used.
8126 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8127
8128 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8129
8130 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8131 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8132 can always succeed if overflow has undefined behavior.
8133
8134 * search.c (boyer_moore, wordify): Remove vars set but not used.
8135 (wordify): Omit three unnecessary tests.
8136
8137 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8138 All callers changed. This avoids the need for an unused var.
8139
8140 * casefiddle.c (casify_region): Remove var that is set but not used.
8141
8142 * dired.c (file_name_completion): Remove var that is set but not used.
8143
8144 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8145
8146 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8147 (Finsert_file_contents): Remove unnecessary code checking fd.
8148
8149 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8150 Check for integer overflow on size calculations.
8151
8152 * buffer.c (Fprevious_overlay_change): Remove var that is set
8153 but not used.
8154
8155 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8156 Remove vars that are set but not used.
8157 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8158 (timer_check_2): Mark vars as initialized.
8159
8160 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8161
8162 * image.c (lookup_image): Remove var that is set but not used.
8163 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8164
8165 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8166 that are set but not used.
8167
8168 * xfns.c (make_invisible_cursor): Don't return garbage
8169 if XCreateBitmapFromData fails (Bug#8410).
8170
8171 * xselect.c (x_get_local_selection, x_handle_property_notify):
8172 Remove vars that are set but not used.
8173
8174 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8175 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8176
8177 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8178 Remove var that is set but not used.
8179 (scroll_bar_windows_size): Now size_t, not int.
8180 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8181 Check for overflow.
8182
8183 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8184 (map_tty_color) [!defined MSDOS]: Likewise.
8185
8186 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8187
8188 * coding.c: Remove vars that are set but not used.
8189 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8190 All callers changed.
8191 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8192 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8193 (decode_coding_charset): Remove vars that are set but not used.
8194
8195 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8196 that is set but not used.
8197
8198 * print.c (print_object): Remove var that is set but not used.
8199
8200 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8201 The gnulib version avoids calling malloc in the usual case,
8202 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8203 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8204 * filelock.c (current_lock_owner): Likewise.
8205 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8206 * sysdep.c: Include allocator.h, careadlinkat.h.
8207 (emacs_no_realloc_allocator): New static constant.
8208 (emacs_readlink): New function.
8209 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8210 ../lib/careadlinkat.h.
8211
8212 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8213
8214 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8215 first non-nil return value).
8216
8217 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8218
8219 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8220 if not defined (Bug#8403).
8221
8222 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8223
8224 * xdisp.c (display_count_lines): Remove parameter `start',
8225 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8226 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8227 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8228 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8229 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8230 and thereabouts. All callers changed.
8231 (get_per_char_metric): Remove parameter `f', unused since
8232 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8233
8234 2011-04-02 Jim Meyering <meyering@redhat.com>
8235
8236 do not dereference NULL upon failed strdup
8237 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8238 (ns_get_family): Likewise.
8239
8240 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8241
8242 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8243
8244 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8245
8246 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8247 later (Bug#8403).
8248
8249 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8250
8251 Add lexical binding.
8252
8253 * window.c (Ftemp_output_buffer_show): New fun.
8254 (Fsave_window_excursion):
8255 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8256
8257 * lread.c (lisp_file_lexically_bound_p): New function.
8258 (Fload): Bind Qlexical_binding.
8259 (readevalloop): Remove `evalfun' arg.
8260 Bind Qinternal_interpreter_environment.
8261 (Feval_buffer): Bind Qlexical_binding.
8262 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8263 Mark as dynamic.
8264 (syms_of_lread): Declare `lexical-binding'.
8265
8266 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8267
8268 * keyboard.c (eval_dyn): New fun.
8269 (menu_item_eval_property): Use it.
8270
8271 * image.c (parse_image_spec): Use Ffunctionp.
8272
8273 * fns.c (concat, mapcar1): Accept byte-code-functions.
8274
8275 * eval.c (Fsetq): Handle lexical vars.
8276 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8277 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8278 (FletX, Flet): Obey lexical binding.
8279 (Fcommandp): Handle closures.
8280 (Feval): New `lexical' arg.
8281 (eval_sub): New function extracted from Feval. Use it almost
8282 everywhere where Feval was used. Look up vars in lexical env.
8283 Handle closures.
8284 (Ffunctionp): Move from subr.el.
8285 (Ffuncall): Handle closures.
8286 (apply_lambda): Remove `eval_flags'.
8287 (funcall_lambda): Handle closures and new byte-code-functions.
8288 (Fspecial_variable_p): New function.
8289 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8290 but without exporting it to Lisp.
8291
8292 * doc.c (Fdocumentation, store_function_docstring):
8293 * data.c (Finteractive_form): Handle closures.
8294
8295 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8296 interactive spec.
8297
8298 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8299 New byte-codes.
8300 (exec_byte_code): New function extracted from Fbyte_code to handle new
8301 calling convention for byte-code-functions. Add new byte-codes.
8302
8303 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8304
8305 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8306
8307 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8308
8309 * xdisp.c (redisplay_internal): Fix prototype.
8310
8311 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8312
8313 * xdisp.c (SCROLL_LIMIT): New macro.
8314 (try_scrolling): Use it when setting scroll_limit.
8315 Limit scrolling to 100 screen lines.
8316 (redisplay_window): Even when falling back on "recentering",
8317 position point in the window according to scroll-conservatively,
8318 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8319
8320 (try_scrolling): When point is above the window, allow searching
8321 as far as scroll_max, or one screenful, to compute vertical
8322 distance from PT to the scroll margin position. This prevents
8323 try_scrolling from unnecessarily failing when
8324 scroll-conservatively is set to a value slightly larger than the
8325 window height. Clean up the case of PT below the margin at bottom
8326 of window: scroll_max can no longer be INT_MAX. When aggressive
8327 scrolling is in use, don't let point enter the opposite scroll
8328 margin as result of the scroll.
8329 (syms_of_xdisp) <scroll-conservatively>: Document the
8330 threshold of 100 lines for never-recentering scrolling.
8331
8332 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8333
8334 * dispextern.h (move_it_by_lines):
8335 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8336 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8337 (message_log_check_duplicate): Remove parameters `prev_bol' and
8338 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8339 (redisplay_internal): Remove parameter `preserve_echo_area',
8340 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8341
8342 * indent.c (Fvertical_motion):
8343 * window.c (window_scroll_pixel_based, Frecenter):
8344 Don't pass `need_y_p' to `move_it_by_lines'.
8345
8346 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8347
8348 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8349 steal a few bits to be more compact.
8350 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8351 Remove unneeded casts.
8352
8353 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8354
8355 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8356
8357 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8358 binding" message (bug#7967).
8359
8360 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8361
8362 Fix more problems found by GCC 4.6.0's static checks.
8363
8364 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8365 Remove unused local var.
8366
8367 * editfns.c (Fmessage_box): Remove unused local var.
8368
8369 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8370 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8371 Omit unused local vars.
8372 * window.c (shrink_windows): Omit unused local var.
8373 * menu.c (digest_single_submenu): Omit unused local var.
8374 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8375 Omit unused local var.
8376
8377 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8378 Don't assume string length fits in int.
8379 (keyremap_step, read_key_sequence): Use size_t for sizes.
8380 (read_key_sequence): Don't check last_real_key_start redundantly.
8381
8382 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8383 instead of alloca (Bug#8344).
8384
8385 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8386 (Fbacktrace_frame): Don't assume nframes fits in int.
8387
8388 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8389
8390 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8391 concerns.
8392
8393 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8394
8395 * cm.c (calccost): Turn while-do into do-while, for clarity.
8396
8397 * keyboard.c (syms_of_keyboard): Use the same style as later
8398 in this function when indexing through an array. This also
8399 works around GCC bug 48267.
8400
8401 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8402
8403 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8404
8405 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8406 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8407
8408 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8409 This avoids undefined behavior on integer overflow, and is a bit
8410 more convenient anyway since it is compared to a size_t variable.
8411
8412 Variadic C functions now count arguments with size_t, not int.
8413 This avoids an unnecessary limitation on 64-bit machines, which
8414 caused (substring ...) to crash on large vectors (Bug#8344).
8415 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8416 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8417 All variadic functions and their callers changed accordingly.
8418 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8419 * data.c (arith_driver, float_arith_driver): Likewise.
8420 * editfns.c (general_insert_function): Likewise.
8421 * eval.c (struct backtrace.nargs, interactive_p)
8422 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8423 (funcall_lambda, mark_backtrace): Likewise.
8424 * fns.c (concat): Likewise.
8425 * frame.c (x_set_frame_parameters): Likewise.
8426 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8427 0 if not found, not -1. All callers changed.
8428
8429 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8430 (stack_copy_size): Now size_t, not int.
8431 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8432
8433 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8434
8435 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8436 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8437 All callers changed.
8438
8439 * lisp.h (multibyte_char_to_unibyte):
8440 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8441 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8442 * character.h (CHAR_TO_BYTE8):
8443 * cmds.c (internal_self_insert):
8444 * editfns.c (general_insert_function):
8445 * keymap.c (push_key_description):
8446 * search.c (Freplace_match):
8447 * xdisp.c (message_dolog, set_message_1): All callers changed.
8448
8449 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8450
8451 * keyboard.c (safe_run_hook_funcall): New function.
8452 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8453 don't set the hook to nil, but remove the offending function instead.
8454 (Qcommand_hook_internal): Remove, unused.
8455 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8456 Vcommand_hook_internal.
8457
8458 * eval.c (enum run_hooks_condition): Remove.
8459 (funcall_nil, funcall_not): New functions.
8460 (run_hook_with_args): Call each function through a `funcall' argument.
8461 Remove `cond' argument, now redundant.
8462 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8463 (Frun_hook_with_args_until_failure): Adjust accordingly.
8464 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8465
8466 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8467
8468 * dispextern.h (string_buffer_position): Remove declaration.
8469
8470 * print.c (strout): Remove parameter `multibyte', unused since
8471 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8472
8473 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8474 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8475 All callers changed.
8476
8477 * w32.c (_wsa_errlist): Use braces for struct initializers.
8478
8479 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8480 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8481 All callers changed.
8482 (string_buffer_position): Likewise. Also, make static (it's never
8483 used outside xdisp.c).
8484 (cursor_row_p): Remove parameter `w', unused since
8485 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8486 (decode_mode_spec): Remove parameter `precision', introduced during
8487 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8488 All callers changed.
8489
8490 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8491
8492 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8493
8494 2011-03-27 Anders Lindgren <andlind@gmail.com>
8495
8496 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8497 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8498 (ns_update_auto_hide_menu_bar): New functions.
8499 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8500 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8501 ns_constrain_all_frames.
8502 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8503 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8504
8505 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8506
8507 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8508
8509 2011-03-27 Glenn Morris <rgm@gnu.org>
8510
8511 * syssignal.h: Replace RETSIGTYPE with void.
8512 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8513 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8514 Replace SIGTYPE with void everywhere.
8515 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8516 * s/template.h (SIGTYPE): Remove commented out definition.
8517
8518 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8519
8520 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8521 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8522
8523 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8524
8525 * w32.c (read_unc_volume): Use parameter `henum', instead of
8526 global variable `wget_enum_handle'.
8527
8528 * keymap.c (describe_vector): Remove parameters `indices' and
8529 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8530 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8531
8532 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8533
8534 * keyboard.c (timer_check): Remove parameter `do_it_now',
8535 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8536 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8537 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8538
8539 * keyboard.c (read_char):
8540 * w32menu.c (w32_menu_display_help):
8541 * xmenu.c (show_help_event, menu_help_callback):
8542 Adjust calls to `show_help_echo'.
8543
8544 * gtkutil.c (xg_maybe_add_timer):
8545 * keyboard.c (readable_events):
8546 * process.c (wait_reading_process_output):
8547 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8548
8549 * insdel.c (adjust_markers_gap_motion):
8550 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8551 (gap_left, gap_right): Don't call it.
8552
8553 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8554
8555 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8556 incurred during fontification.
8557
8558 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8559
8560 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8561 (DEFVAR_PER_BUFFER): Don't pass it.
8562
8563 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8564 (scrolling_window): Don't pass it.
8565
8566 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8567
8568 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8569
8570 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8571 and `suffix'.
8572 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8573 of variables specific to SELinux and computation of `encoded_absname'.
8574
8575 * image.c (XPutPixel): Remove unused variable `height'.
8576
8577 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8578
8579 * unexw32.c (get_section_info): Remove unused variable `section'.
8580
8581 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8582 (system_process_attributes): Remove unused variable `sess'.
8583 (sys_read): Remove unused variable `err'.
8584
8585 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8586 (w32_wnd_proc): Remove unused variable `isdead'.
8587 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8588 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8589 (x_create_tip_frame): Remove unused variable `tem'.
8590
8591 * w32inevt.c (w32_console_read_socket):
8592 Remove unused variable `no_events'.
8593
8594 * w32term.c (x_draw_composite_glyph_string_foreground):
8595 Remove unused variable `width'.
8596
8597 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8598
8599 * w32term.c (x_set_glyph_string_clipping):
8600 Don't pass uninitialized region to CombineRgn.
8601
8602 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8603
8604 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8605 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8606 (Fx_close_connection): Remove unused variable `i'.
8607
8608 * w32font.c (w32font_draw): Return number of glyphs.
8609 (w32font_open_internal): Remove unused variable `i'.
8610 (w32font_driver): Add missing initializer.
8611
8612 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8613 (fill_in_menu): Remove unused variable `items_added'.
8614
8615 * w32term.c (last_mouse_press_frame): Remove static global variable.
8616 (w32_clip_to_row): Remove unused variable `f'.
8617 (x_delete_terminal): Remove unused variable `i'.
8618
8619 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8620 (NOTHING): Remove unused static global variable.
8621 (uniscribe_check_otf): Remove unused variable `table'.
8622 (uniscribe_font_driver): Add missing initializers.
8623
8624 2011-03-23 Julien Danjou <julien@danjou.info>
8625
8626 * term.c (Fsuspend_tty, Fresume_tty):
8627 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8628 * window.c (temp_output_buffer_show):
8629 * insdel.c (signal_before_change):
8630 * frame.c (Fhandle_switch_frame):
8631 * fileio.c (Fdo_auto_save):
8632 * emacs.c (Fkill_emacs):
8633 * editfns.c (save_excursion_restore):
8634 * cmds.c (internal_self_insert):
8635 * callint.c (Fcall_interactively):
8636 * buffer.c (Fkill_all_local_variables):
8637 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8638 Use Frun_hooks.
8639 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8640 unconditionally since it does the check itself.
8641
8642 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8643
8644 Fix more problems found by GCC 4.5.2's static checks.
8645
8646 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8647 the first time through the loop, since we know p0 < p1 then.
8648 This also avoids a gcc -Wstrict-overflow warning.
8649
8650 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8651 leading to a memory leak, possible in functions like
8652 load_charset_map_from_file that can allocate an unbounded number
8653 of objects (Bug#8318).
8654
8655 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8656 that could (at least in theory) be that large.
8657
8658 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8659 This is less likely to overflow, and avoids undefined behavior if
8660 overflow does occur. All callers changed. Use strtoul to scan
8661 for the unsigned long integer.
8662 (pint2hrstr): Simplify and tune code slightly.
8663 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8664
8665 * scroll.c (do_scrolling): Work around GCC bug 48228.
8666 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8667
8668 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8669 This also avoids a warning with gcc -Wstrict-overflow.
8670 (validate_x_resource_name): Simplify count usage.
8671 This also avoids a warning with gcc -Wstrict-overflow.
8672
8673 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8674 fail (Bug#8306).
8675
8676 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8677
8678 * process.c (Fmake_network_process): Use socklen_t, not int,
8679 where POSIX says socklen_t is required in portable programs.
8680 This fixes a porting bug on hosts like 64-bit HP-UX, where
8681 socklen_t is wider than int (Bug#8277).
8682 (Fmake_network_process, server_accept_connection):
8683 (wait_reading_process_output, read_process_output):
8684 Likewise.
8685
8686 * process.c: Rename or move locals to avoid shadowing.
8687 (list_processes_1, Fmake_network_process):
8688 (read_process_output_error_handler, exec_sentinel_error_handler):
8689 Rename or move locals.
8690 (Fmake_network_process): Define label "retry_connect" only if needed.
8691 (Fnetwork_interface_info): Fix pointer signedness.
8692 (process_send_signal): Add cast to avoid pointer signedness problem.
8693 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8694 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8695
8696 Make tparam.h and terminfo.c consistent.
8697 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8698 Include tparam.h instead, since it declares them.
8699 * cm.h (PC): Remove extern decl; tparam.h now does this.
8700 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8701 * terminfo.c: Include tparam.h, to check interfaces.
8702 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8703 (tparam): Adjust signature to match interface in tparam.h;
8704 this removes some undefined behavior. Check that outstring and len
8705 are zero, which they always are with Emacs.
8706 * tparam.h (PC, BC, UP): New extern decls.
8707
8708 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8709 (xftfont_open): Rename locals to avoid shadowing.
8710
8711 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8712 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8713 (OTF_TAG_SYM): Omit macro if not needed.
8714 (ftfont_list): Remove unused local.
8715 (get_adstyle_property, ftfont_pattern_entity):
8716 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8717 Rename locals to avoid shadowing.
8718
8719 * xfont.c (xfont_list_family): Mark var as initialized.
8720
8721 * xml.c (make_dom): Now static.
8722
8723 * composite.c (composition_compute_stop_pos): Rename local to
8724 avoid shadowing.
8725 (composition_reseat_it): Remove unused locals.
8726 (find_automatic_composition, composition_adjust_point): Likewise.
8727 (composition_update_it): Mark var as initialized.
8728 (find_automatic_composition): Mark vars as initialized,
8729 with a FIXME (Bug#8290).
8730
8731 character.h: Rename locals to avoid shadowing.
8732 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8733 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8734 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8735 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8736 to avoid shadowing.
8737
8738 * textprop.c (property_change_between_p): Remove; unused.
8739
8740 * intervals.c (interval_start_pos): Now static.
8741
8742 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8743
8744 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8745 Rename locals to avoid shadowing.
8746
8747 * sound.c (wav_play, au_play, Fplay_sound_internal):
8748 Fix pointer signedness.
8749 (alsa_choose_format): Remove unused local var.
8750 (wav_play): Initialize a variable to 0, to prevent undefined
8751 behavior (Bug#8278).
8752
8753 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8754
8755 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8756
8757 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8758 clobbering (Bug#8298).
8759 * sysdep.c (sys_subshell): Likewise.
8760 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8761
8762 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8763 This should get cleaned up, so that child_setup has the
8764 same signature on all platforms.
8765
8766 * callproc.c (call_process_cleanup): Now static.
8767 (relocate_fd): Rename locals to avoid shadowing.
8768
8769 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8770
8771 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8772 not to be necessary, and produces flickering.
8773
8774 2011-03-20 Glenn Morris <rgm@gnu.org>
8775
8776 * config.in: Remove file.
8777
8778 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8779
8780 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8781 are now in src/globals.h.
8782 (syms_of_minibuf): Remove spurious & from previous change.
8783
8784 2011-03-20 Leo Liu <sdl.web@gmail.com>
8785
8786 * minibuf.c (completing-read-function): New variable.
8787 (completing-read-default): Rename from completing-read.
8788 (completing-read): Call completing-read-function.
8789
8790 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8791
8792 * xfaces.c (Fx_load_color_file):
8793 Read color file from absolute filename (bug#8250).
8794
8795 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8796
8797 * makefile.w32-in: Update dependencies.
8798
8799 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8800
8801 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8802
8803 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8804
8805 Fix more problems found by GCC 4.5.2's static checks.
8806
8807 * process.c (make_serial_process_unwind, send_process_trap):
8808 (sigchld_handler): Now static.
8809
8810 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8811 That way, the code declares only the vars that it needs.
8812 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8813 * s/cygwin.h (PTY_ITERATION): Likewise.
8814 * s/darwin.h (PTY_ITERATION): Likewise.
8815 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8816
8817 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8818 * process.c (allocate_pty): Don't declare stb unless it's needed.
8819
8820 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8821 (CONSTANTLIM): Remove; unused.
8822 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8823 Define only if needed.
8824
8825 * unexelf.c (unexec): Name an expression,
8826 to avoid gcc -Wbad-function-cast warning.
8827 Use a different way to cause a compilation error if anyone uses
8828 n rather than nn, a way that does not involve shadowing.
8829 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8830
8831 * deps.mk (unexalpha.o): Remove; unused.
8832
8833 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8834 * unexec.h: New file.
8835 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8836 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8837 Depend on unexec.h.
8838 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8839 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8840 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8841 Change as necessary to match prototype in unexec.h.
8842
8843 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8844 shadowing.
8845 (back_comment, skip_chars): Mark vars as initialized.
8846
8847 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8848 Rename locals to avoid shadowing.
8849
8850 * lread.c (read1): Rewrite so as not to use empty "else".
8851 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8852
8853 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8854
8855 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8856 warning when compiling print.c.
8857
8858 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8859 instead of using an uninitialized var.
8860 (font_sort_entities): Mark var as initialized.
8861
8862 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8863
8864 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8865 pointers to constants.
8866 (font_parse_fcname): Remove unused vars.
8867 (font_delete_unmatched): Now static.
8868 (font_get_spec): Remove; unused.
8869 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8870 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8871 Rename or move locals to avoid shadowing.
8872
8873 * fns.c (require_nesting_list, require_unwind): Now static.
8874 (Ffillarray): Rename locals to avoid shadowing.
8875
8876 * floatfns.c (domain_error2): Define only if needed.
8877 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8878
8879 * alloc.c (mark_backtrace): Move decl from here ...
8880 * lisp.h: ... to here, so that it can be checked.
8881
8882 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8883 (Fdefvar): Rewrite so as not to use empty "else".
8884 (lisp_indirect_variable): Name an expression,
8885 to avoid gcc -Wbad-function-cast warning.
8886 (Fdefvar): Rename locals to avoid shadowing.
8887
8888 * callint.c (quotify_arg, quotify_args): Now static.
8889 (Fcall_interactively): Rename locals to avoid shadowing.
8890 Use const pointer when appropriate.
8891
8892 * lisp.h (get_system_name, get_operating_system_release):
8893 Move decls here, to check interfaces.
8894 * process.c (get_operating_system_release): Move decl to lisp.h.
8895 * xrdb.c (get_system_name): Likewise.
8896 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8897 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8898 some of which prompt warnings from gcc -Wbad-function-cast.
8899 (Fformat_time_string, Fencode_time, Finsert_char):
8900 (Ftranslate_region_internal, Fformat):
8901 Rename or remove local vars to avoid shadowing.
8902 (Ftranslate_region_internal): Mark var as initialized.
8903
8904 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8905 avoid shadowing.
8906
8907 * lisp.h (eassert): Check that the argument compiles, even if
8908 ENABLE_CHECKING is not defined.
8909
8910 * data.c (Findirect_variable): Name an expression, to avoid
8911 gcc -Wbad-function-cast warning.
8912 (default_value, arithcompare, arith_driver, arith_error): Now static.
8913 (store_symval_forwarding): Rename local to avoid shadowing.
8914 (Fmake_variable_buffer_local, Fmake_local_variable):
8915 Mark variables as initialized.
8916 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8917
8918 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8919 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8920 Rename locals to avoid shadowing.
8921 (mark_stack): Move local variables into the #ifdef region where
8922 they're used.
8923 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8924 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8925 needed otherwise.
8926 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8927 (GC_STRING_CHARS): Remove; not used.
8928 (Fmemory_limit): Cast sbrk's returned value to char *.
8929
8930 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8931 avoids undefined behavior in theory.
8932
8933 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8934
8935 Use functions, not macros, for up- and down-casing (Bug#8254).
8936 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8937 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8938 to use the following functions instead of these macros.
8939 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8940 EMACS_INT, since callers assume the returned value fits in int.
8941 (upcase1): Likewise, for UPCASE_TABLE.
8942 (uppercasep, lowercasep, upcase): New static inline functions.
8943 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8944 the race-condition problem in the old DOWNCASE.
8945
8946 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8947 Rename locals to avoid shadowing.
8948 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8949 (regex_compile, re_search_2, re_match_2_internal):
8950 Remove unused local vars.
8951 (FREE_VAR): Rewrite so as not to use empty "else",
8952 which gcc can warn about.
8953 (regex_compile, re_match_2_internal): Mark locals as initialized.
8954 (RETALLOC_IF): Define only if needed.
8955 (WORDCHAR_P): Likewise. This one is never needed, but is used
8956 only in a comment talking about a compiler bug, so put inside
8957 the #if 0 of that comment.
8958 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8959 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8960 Remove; unused.
8961
8962 * search.c (boyer_moore): Rename locals to avoid shadowing.
8963 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8964 (PREV_CHAR_BOUNDARY): Likewise.
8965
8966 * search.c (simple_search): Remove unused var.
8967
8968 * dired.c (compile_pattern): Move decl from here ...
8969 * lisp.h: ... to here, so that it can be checked.
8970 (struct re_registers): New forward decl.
8971
8972 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8973
8974 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8975 All uses changed.
8976 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8977 Rename locals to avoid shadowing.
8978 (Fvertical_motion): Mark locals as initialized.
8979
8980 * casefiddle.c (casify_object, casify_region): Now static.
8981 (casify_region): Mark local as initialized.
8982
8983 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8984
8985 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8986 New macros, so that the caller can use some names other than
8987 gcpro1, gcpro2, etc.
8988 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8989 of the new macros.
8990 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8991 argument, for consistency with GCPRO2_VAR, etc: it is now the
8992 prefix of the variable, not the variable itself. All uses
8993 changed.
8994 * dired.c (directory_files_internal, file_name_completion):
8995 Rename locals to avoid shadowing.
8996
8997 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8998 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8999 dired.c's scmp function, had undefined behavior.
9000 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9001 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9002 * buffer.h: ... to here, because these macros use current_buffer,
9003 and the new implementation with inline functions needs to have
9004 current_buffer in scope now, rather than later when the macros
9005 are used.
9006 (downcase, upcase1): New static inline functions.
9007 (DOWNCASE, UPCASE1): Reimplement using these functions.
9008 This avoids undefined behavior in expressions like
9009 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9010 from race conditions in accessing the global variables
9011 case_temp1 and case_temp2.
9012 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9013 * lisp.h (case_temp1, case_temp2): Remove their decls.
9014 * character.h (ASCII_CHAR_P): Move from here ...
9015 * lisp.h: ... to here, so that the inline functions mentioned
9016 above can use them.
9017
9018 * dired.c (directory_files_internal_unwind): Now static.
9019
9020 * fileio.c (file_name_as_directory, directory_file_name):
9021 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9022 Now static.
9023 (file_name_as_directory): Use const pointers when appropriate.
9024 (Fexpand_file_name): Likewise. In particular, newdir might
9025 point at constant storage, so make it a const pointer.
9026 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9027 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9028 signedness issues.
9029 (Fset_file_times, Finsert_file_contents, auto_save_error):
9030 Rename locals to avoid shadowing.
9031
9032 * minibuf.c (choose_minibuf_frame_1): Now static.
9033 (Ftry_completion, Fall_completions): Rename or remove locals
9034 to avoid shadowing.
9035
9036 * marker.c (bytepos_to_charpos): Remove; unused.
9037
9038 * lisp.h (verify_bytepos, count_markers): New decls,
9039 so that gcc does not warn that these functions aren't declared.
9040
9041 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9042 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9043 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9044 (copy_text): Remove unused local var.
9045
9046 * filelock.c (within_one_second): Now static.
9047 (lock_file_1): Rename local to avoid shadowing.
9048
9049 * buffer.c (fix_overlays_before): Mark locals as initialized.
9050 (fix_start_end_in_overlays): Likewise. This function should be
9051 simplified by using pointers-to-pointers, but that's a different
9052 matter.
9053 (switch_to_buffer_1): Now static.
9054 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9055 (report_overlay_modification): Rename locals to avoid shadowing.
9056
9057 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9058 Fix pointer signedness issue.
9059 (sys_subshell): Mark local as volatile if checking for lint,
9060 to suppress a gcc -Wclobbered warning that does not seem to be right.
9061 (MAXPATHLEN): Define only if needed.
9062
9063 * process.c (serial_open, serial_configure): Move decls from here ...
9064 * systty.h: ... to here, so that they can be checked.
9065
9066 * fns.c (get_random, seed_random): Move extern decls from here ...
9067 * lisp.h: ... to here, so that they can be checked.
9068
9069 * sysdep.c (reset_io): Now static.
9070 (wait_for_termination_signal): Remove; unused.
9071
9072 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9073 (copy_keymap_item, append_key, push_text_char_description):
9074 Now static.
9075 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9076 (DENSE_TABLE_SIZE): Remove; unused.
9077 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9078 (describe_map_tree):
9079 Rename locals to avoid shadowing.
9080
9081 * keyboard.c: Declare functions static if they are not used elsewhere.
9082 (echo_char, echo_dash, cmd_error, top_level_2):
9083 (poll_for_input, handle_async_input): Now static.
9084 (read_char, kbd_buffer_get_event, make_lispy_position):
9085 (make_lispy_event, make_lispy_movement, apply_modifiers):
9086 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9087 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9088 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9089 (read_key_sequence, read_char): Mark locals as initialized.
9090 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9091
9092 * keyboard.h (make_ctrl_char): New decl.
9093 (mark_kboards): Move decl here ...
9094 * alloc.c (mark_kboards): ... from here.
9095
9096 * lisp.h (force_auto_save_soon): New decl.
9097
9098 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9099 (DEFINE_DUMMY_FUNCTION): New macro.
9100 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9101 Use it.
9102 (main): Add casts to avoid warnings
9103 if GCC considers string literals to be constants.
9104
9105 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9106
9107 * dbusbind.c: Pointer signedness fixes.
9108 (xd_signature, xd_append_arg, xd_initialize):
9109 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9110 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9111 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9112 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9113
9114 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9115 if GCC considers string literals to be constants.
9116 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9117
9118 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9119
9120 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9121 (print_preprocess, print_object): New macro to fix last change.
9122
9123 * print.c (print_preprocess): Don't forget font objects.
9124
9125 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9126
9127 * emacs.c (USAGE3): Doc fixes.
9128
9129 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9130
9131 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9132 structure.
9133
9134 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9135
9136 * lisp.h (VWindow_system, Qfile_name_history):
9137 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9138 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9139 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9140
9141 * w32select.c: Don't #include "keyboard.h".
9142 (run_protected): Add extern declaration for waiting_for_input.
9143
9144 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9145 * w32console.c (detect_input_pending, read_input_pending)
9146 (encode_terminal_code):
9147 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9148 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9149 (w32_system_caret_y, Qfile_name_history):
9150 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9151 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9152 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9153 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9154 * w32proc.c (Qlocal, report_file_error):
9155 * w32term.c (Vwindow_system, updating_frame):
9156 * w32uniscribe.c (initialized, uniscribe_font_driver):
9157 Remove unneeded extern declarations.
9158
9159 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9160
9161 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9162
9163 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9164
9165 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9166 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9167 These macros can no longer be used for assignment.
9168
9169 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9170 Assign struct members directly, instead of using BUF_BEGV etc.
9171 (record_buffer_markers, fetch_buffer_markers): New functions for
9172 recording and fetching special buffer markers.
9173 (set_buffer_internal_1, set_buffer_temp): Use them.
9174
9175 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9176
9177 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9178
9179 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9180 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9181
9182 * xdisp.c (hscroll_window_tree):
9183 (reconsider_clip_changes): Use PT instead of BUF_PT.
9184
9185 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9186
9187 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9188 $(EMACS_ROOT)/lib/intprops.h.
9189
9190 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9191
9192 Fix more problems found by GCC 4.5.2's static checks.
9193
9194 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9195 to unsigned char * to avoid compiler diagnostic.
9196 (xg_free_frame_widgets): Make it clear that a local variable is
9197 needed only if USE_GTK_TOOLTIP.
9198 (gdk_window_get_screen): Make it clear that this macro is needed
9199 only if USE_GTK_TOOLTIP.
9200 (int_gtk_range_get_value): New function, which avoids a diagnostic
9201 from gcc -Wbad-function-cast.
9202 (xg_set_toolkit_scroll_bar_thumb): Use it.
9203 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9204 diagnostic from gcc -Wbad-function-cast.
9205 (get_utf8_string, xg_get_file_with_chooser):
9206 Rename locals to avoid shadowing.
9207 (create_dialog): Move locals to avoid shadowing.
9208
9209 * xgselect.c (xg_select): Remove unused var.
9210
9211 * image.c (four_corners_best): Mark locals as initialized.
9212 (gif_load): Initialize transparent_p to zero (Bug#8238).
9213 Mark another local as initialized.
9214 (my_png_error, my_error_exit): Mark with NO_RETURN.
9215
9216 * image.c (clear_image_cache): Now static.
9217 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9218 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9219 (x_edge_detection): Remove unnecessary cast that
9220 gcc -Wbad-function-cast diagnoses.
9221 (gif_load): Fix pointer signedness.
9222 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9223 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9224
9225 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9226
9227 Improve quality of tests for time stamp overflow.
9228 For example, without this patch (encode-time 0 0 0 1 1
9229 1152921504606846976) returns the obviously-bogus value (-948597
9230 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9231 reports time overflow. See
9232 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9233 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9234 * editfns.c: Include limits.h and intprops.h.
9235 (TIME_T_MIN, TIME_T_MAX): New macros.
9236 (time_overflow): Move earlier, to before first use.
9237 (hi_time, lo_time): New functions, for an accurate test for
9238 out-of-range times.
9239 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9240 (Fget_internal_run_time): Don't assume time_t fits in int.
9241 (make_time): Use list2 instead of Fcons twice.
9242 (Fdecode_time): More accurate test for out-of-range times.
9243 (check_tm_member): New function.
9244 (Fencode_time): Use it, to test for out-of-range times.
9245 (lisp_time_argument): Don't rely on undefined left-shift and
9246 right-shift behavior when checking for time stamp overflow.
9247
9248 * editfns.c (time_overflow): New function, refactoring common code.
9249 (Fformat_time_string, Fdecode_time, Fencode_time):
9250 (Fcurrent_time_string): Use it.
9251
9252 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9253 * dired.c (make_time): Move to ...
9254 * editfns.c (make_time): ... here.
9255 * systime.h: Note the move.
9256
9257 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9258
9259 * fringe.c (update_window_fringes): Remove unused variables.
9260
9261 * unexmacosx.c (copy_data_segment): Also copy __got section.
9262 (Bug#8223)
9263
9264 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9265
9266 * termcap.c [MSDOS]: Include "msdos.h".
9267 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9268 Constify `char *' arguments and their references according to
9269 prototypes in tparam.h.
9270
9271 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9272
9273 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9274 Adapt all references accordingly.
9275
9276 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9277
9278 2011-03-11 Tom Tromey <tromey@redhat.com>
9279
9280 * buffer.c (syms_of_buffer): Remove obsolete comment.
9281
9282 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9283
9284 * termhooks.h (encode_terminal_code): Declare prototype.
9285
9286 * msdos.c (encode_terminal_code): Don't declare prototype.
9287
9288 * term.c (encode_terminal_code): Now external again, used by
9289 w32console.c and msdos.c.
9290
9291 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9292 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9293
9294 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9295
9296 Fix some minor problems found by GCC 4.5.2's static checks.
9297
9298 * fringe.c (update_window_fringes): Mark locals as initialized
9299 (Bug#8227).
9300 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9301
9302 * alloc.c (mark_fringe_data): Move decl from here ...
9303 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9304 to check its interface.
9305 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9306
9307 * fontset.c (free_realized_fontset): Now static.
9308 (Fset_fontset_font): Rename local to avoid shadowing.
9309 (fontset_font): Mark local as initialized.
9310 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9311
9312 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9313
9314 * xselect.c (x_disown_buffer_selections): Remove; not used.
9315 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9316 (x_own_selection, Fx_disown_selection_internal): Rename locals
9317 to avoid shadowing.
9318 (x_handle_dnd_message): Remove local to avoid shadowing.
9319
9320 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9321 so that the caller can use some name other than gcpro1.
9322 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9323 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9324 (Fx_backspace_delete_keys_p):
9325 Use them to avoid shadowing, and rename vars to avoid shadowing.
9326 (x_decode_color, x_set_name, x_window): Now static.
9327 (Fx_create_frame): Add braces to silence GCC warning.
9328 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9329 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9330 Remove unused locals.
9331 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9332 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9333 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9334 macros.
9335
9336 * xterm.h (x_mouse_leave): New decl.
9337
9338 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9339 Remove unused functions.
9340 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9341 (x_calc_absolute_position): Now static.
9342 (XTread_socket): Don't define label "out" unless it's used.
9343 Don't declare local "event" unless it's used.
9344 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9345 unless they are used.
9346 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9347 (x_fatal_error_signal): Remove; not used.
9348 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9349 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9350 (x_error_catcher, x_connection_closed, x_error_handler):
9351 (x_error_quitter, xembed_send_message, x_iconify_frame):
9352 (my_log_handler): Rename locals to avoid shadowing.
9353 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9354 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9355
9356 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9357 Rename or move locals to avoid shadowing.
9358 (tty_defined_color, merge_face_heights): Now static.
9359 (free_realized_faces_for_fontset): Remove; not used.
9360 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9361 does not deduce is never used uninitialized.
9362 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9363 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9364
9365 * terminal.c (store_terminal_param): Now static.
9366
9367 * xmenu.c (menu_highlight_callback): Now static.
9368 (set_frame_menubar): Remove unused local.
9369 (xmenu_show): Rename parameter to avoid shadowing.
9370 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9371 since they might point to immutable storage.
9372 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9373 since it's unused otherwise.
9374
9375 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9376 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9377 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9378 avoids a gcc -Wuninitialized diagnostic.
9379 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9380 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9381 does not deduce are never used uninitialized.
9382
9383 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9384
9385 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9386 * window.c (window_loop, size_window):
9387 (run_window_configuration_change_hook, enlarge_window): Likewise.
9388
9389 * window.c (display_buffer): Now static.
9390 (size_window): Mark variables that gcc -Wuninitialized
9391 does not deduce are never used uninitialized.
9392 * window.h (check_all_windows): New decl, to forestall
9393 gcc -Wmissing-prototypes diagnostic.
9394 * dispextern.h (bidi_dump_cached_states): Likewise.
9395
9396 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9397 shadowing.
9398 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9399 Include <limits.h>.
9400 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9401 and to avoid gcc -Wuninitialized warning.
9402 (load_charset_map): Mark variables that gcc -Wuninitialized
9403 does not deduce are never used uninitialized.
9404 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9405
9406 * coding.c (coding_set_source, coding_set_destination):
9407 Use "else { /* comment */ }" rather than "else /* comment */;"
9408 for clarity, and to avoid gcc -Wempty-body warning.
9409 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9410 a block, when the outer 'i' will do.
9411 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9412 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9413 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9414 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9415 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9416 Rename locals to avoid shadowing.
9417 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9418 * coding.c (emacs_mule_char, encode_invocation_designation):
9419 Now static, since they're not used elsewhere.
9420 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9421 (decode_coding_object, encode_coding_object, detect_coding_system):
9422 (decode_coding_emacs_mule): Mark variables that gcc
9423 -Wuninitialized does not deduce are never used uninitialized.
9424 (detect_coding_iso_2022): Initialize a local variable that might
9425 be used uninitialized. Leave a FIXME because it's not clear that
9426 this initialization is needed. (Bug#8211)
9427 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9428 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9429 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9430 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9431 Remove unused macros.
9432
9433 * category.c (hash_get_category_set): Remove unused local var.
9434 (copy_category_table): Now static, since it's not used elsewhere.
9435 * character.c (string_count_byte8): Likewise.
9436
9437 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9438 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9439
9440 * chartab.c (copy_sub_char_table): Now static, since it's not used
9441 elsewhere.
9442 (sub_char_table_ref_and_range, char_table_ref_and_range):
9443 Rename locals to avoid shadowing.
9444 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9445
9446 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9447 (BIDI_BOB): Remove unused macro.
9448
9449 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9450 deduce are never used uninitialized.
9451 * term.c (encode_terminal_code): Likewise.
9452
9453 * term.c (encode_terminal_code): Now static. Remove unused local.
9454
9455 * tparam.h: New file.
9456 * term.c, tparam.h: Include it.
9457 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9458 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9459 Move these decls to tparam.h, and make them agree with what
9460 is actually in tparam.c. The previous trick of using incompatible
9461 decls in different modules does not conform to the C standard.
9462 All callers of tparam changed to use tparam's actual API.
9463 * tparam.c (tparam1, tparam, tgoto):
9464 Use const pointers where appropriate.
9465
9466 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9467 * cm.h (struct cm): Likewise.
9468 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9469 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9470 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9471 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9472 (turn_on_face, init_tty): Likewise.
9473 * termchar.h (struct tty_display_info): Likewise.
9474
9475 * term.c (term_mouse_position): Rename local to avoid shadowing.
9476
9477 * alloc.c (mark_ttys): Move decl from here ...
9478 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9479
9480 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9481
9482 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9483
9484 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9485
9486 * search.c (compile_pattern_1): Remove argument regp, unused since
9487 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9488 (compile_pattern): Don't pass it.
9489
9490 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9491
9492 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9493 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9494 for ! HAVE_GTK3.
9495 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9496
9497 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9498
9499 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9500 gdk_window_get_screen, gdk_window_get_geometry,
9501 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9502 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9503 (xg_get_pixbuf_from_pixmap): New function.
9504 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9505 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9506 Call xg_get_pixbuf_from_pixmap instead of
9507 gdk_pixbuf_get_from_drawable.
9508 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9509 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9510 (xg_check_special_colors): Use GtkStyleContext and its functions
9511 for HAVE_GTK3.
9512 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9513 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9514 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9515 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9516 Call gtk_widget_get_preferred_size.
9517 (xg_frame_resized): gdk_window_get_geometry only takes 5
9518 parameters.
9519 (xg_win_to_widget, xg_event_is_for_menubar):
9520 Call gdk_x11_window_lookup_for_display.
9521 (xg_set_widget_bg): New function.
9522 (delete_cb): New function.
9523 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9524 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9525 (xg_set_background_color): Call xg_set_widget_bg.
9526 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9527 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9528 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9529 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9530 if ! HAVE_GTK3.
9531 (update_frame_tool_bar): Call gtk_widget_hide.
9532 (xg_initialize): Use GDK_KEY_g.
9533
9534 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9535 if ! HAVE_GTK3
9536 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9537
9538 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9539 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9540 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9541
9542 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9543
9544 * w32xfns.c (select_palette): Check success of RealizePalette against
9545 GDI_ERROR, not zero.
9546
9547 See ChangeLog.11 for earlier changes.
9548
9549 ;; Local Variables:
9550 ;; coding: utf-8
9551 ;; End:
9552
9553 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9554
9555 This file is part of GNU Emacs.
9556
9557 GNU Emacs is free software: you can redistribute it and/or modify
9558 it under the terms of the GNU General Public License as published by
9559 the Free Software Foundation, either version 3 of the License, or
9560 (at your option) any later version.
9561
9562 GNU Emacs is distributed in the hope that it will be useful,
9563 but WITHOUT ANY WARRANTY; without even the implied warranty of
9564 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9565 GNU General Public License for more details.
9566
9567 You should have received a copy of the GNU General Public License
9568 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.