1 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4 only under bidi iteration.
6 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
10 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
12 isnan: Fix porting problem to Solaris 10 with bundled gcc.
13 Without this fix, the command to link temacs failed due to an
14 undefined symbol __builtin_isnan. This is because
15 /usr/include/iso/math_c99.h #defines isnan(x) to
16 __builtin_isnan(x), but the bundled gcc, which identifies itself
17 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
19 * floatfns.c (isnan): #undef, and then #define to a clone of
21 (Fisnan): Always define, since it's always available now.
22 (syms_of_floatfns): Always define isnan at the Lisp level.
24 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
26 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
28 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
30 * fileio.c: Fix bugs with large file offsets (Bug#9428).
31 The previous code assumed that file offsets (off_t values) fit in
32 EMACS_INT variables, which is not true on typical 32-bit hosts.
33 The code messed up by falsely reporting buffer overflow in cases
34 such as (insert-file-contents "big" nil 1 2) into an empty buffer
35 when "big" contains more than 2**29 bytes, even though this
36 inserts just one byte and does not overflow the buffer.
37 (Finsert_file_contents): Store file offsets as off_t
38 values, not as EMACS_INT values. Check for overflow when
39 converting between EMACS_INT and off_t. When checking for
40 buffer overflow or for overlap, take the offsets into account.
41 Don't use EMACS_INT for small values where int suffices.
42 When checking for overlap, fix a typo: ZV was used where
44 (Fwrite_region): Don't assume off_t fits into 'long'.
45 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
47 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
49 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
51 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
53 sprintf-related integer and memory overflow issues (Bug#9412).
55 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
56 (esprintf, exprintf, evxprintf): New functions.
57 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
58 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
59 (modify_event_symbol): Do not assume that the length of
60 name_alist_or_stem is safe to alloca and fits in int.
61 (Fexecute_extended_command): Likewise for function name and binding.
62 (Frecursion_depth): Wrap around reliably on integer overflow.
63 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
64 since some callers pass EMACS_INT values.
65 (Fsingle_key_description): Don't crash if symbol name contains more
66 than MAX_ALLOCA bytes.
67 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
68 (get_minibuffer): Arg is now EMACS_INT, not int.
69 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
70 (esprintf, exprintf, evxprintf): New decls.
71 * window.h (command_loop_level, minibuf_level): Reflect API changes.
73 * dbusbind.c (signature_cat): New function.
74 (xd_signature, Fdbus_register_signal):
75 Do not overrun buffer; instead, report string overflow.
77 * dispnew.c (add_window_display_history): Don't overrun buffer.
78 Truncate instead; this is OK since it's just a log.
80 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
81 even if the time zone offset is outlandishly large.
82 Don't mishandle offset == INT_MIN.
84 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
85 when creating daemon; the previous buffer-overflow check was incorrect.
87 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
88 which has the guts of the old verror function.
90 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
91 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
93 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
94 (font_unparse_xlfd): Don't blindly alloca long strings.
95 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
96 fits in int, when using sprintf. Use single snprintf to count
97 length of string rather than counting it via multiple sprintfs;
98 that's simpler and more reliable.
99 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
100 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
101 sprintf, in case result does not fit in int.
103 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
104 (fontset_from_font): Print it.
106 * frame.c (tty_frame_count): Now printmax_t, not int.
107 (make_terminal_frame, set_term_frame_name): Print it.
108 (x_report_frame_params): In X, window IDs are unsigned long,
109 not signed long, so print them as unsigned.
110 (validate_x_resource_name): Check for implausibly long names,
111 and don't assume name length fits in 'int'.
112 (x_get_resource_string): Don't blindly alloca invocation name;
113 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
116 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
117 (xg_check_special_colors, xg_set_geometry):
118 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
120 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
121 Use esprintf, not sprintf, in case result does not fit in int.
123 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
124 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
125 it as a large positive number.
126 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
127 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
129 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
130 in case result does not fit in int.
132 * print.c (float_to_string): Detect width overflow more reliably.
133 (print_object): Make sprintf buffer a bit bigger, to avoid potential
134 buffer overrun. Don't assume list length fits in 'int'. Treat
135 print length of 0 as 0, not as infinity; to be consistent with other
136 uses of print length in this function. Don't overflow print length
137 index. Don't assume hash table size fits in 'long', or that
138 vectorlike size fits in 'unsigned long'.
140 * process.c (make_process): Use printmax_t, not int, to format
141 process-name gensyms.
143 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
145 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
146 to avoid potential buffer overrun.
148 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
149 if X resource line is longer than 512 bytes.
151 * xfns.c (x_window): Make sprintf buffer a bit bigger
152 to avoid potential buffer overrun.
154 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
156 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
158 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
160 Integer overflow fixes for scrolling, etc.
161 Without these, Emacs silently mishandles large integers sometimes.
162 For example, "C-u 4294967297 M-x recenter" was treated as if
163 it were "C-u 1 M-x recenter" on a typical 64-bit host.
165 * xdisp.c (try_window_id): Check Emacs fixnum range before
168 * window.c (window_scroll_line_based, Frecenter):
169 Check that an Emacs fixnum is in range before assigning it to 'int'.
170 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
171 values converted from Emacs fixnums.
172 (Frecenter): Don't wrap around a line count if it is out of 'int'
173 range; instead, treat it as an extreme value.
174 (Fset_window_configuration, compare_window_configurations):
175 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
177 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
178 that can exceed INT_MAX. Check that EMACS_INT value is in range
179 before assigning it to the (possibly-narrower) index.
180 (match_limit): Don't assume that a fixnum can fit in 'int'.
182 * print.c (print_object): Use ptrdiff_t, not int, for index that can
185 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
186 (Fvertical_motion): Don't wrap around LINES values that don't fit
187 in 'int'. Instead, treat them as extreme values. This is good
188 enough for windows, which can't have more than INT_MAX lines anyway.
190 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
192 * Require libxml/parser.h to avoid compilation warning.
194 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
196 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
197 since this reportedly can destroy thread storage.
199 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
201 * syntax.c (find_defun_start): Update all cache variables if
202 exiting early (Bug#9401).
204 2011-08-30 Eli Zaretskii <eliz@gnu.org>
206 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
208 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
209 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
210 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
212 * term.c (tty_append_glyph): New function.
213 (produce_stretch_glyph): Static function and its prototype deleted.
215 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
218 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
220 * image.c (parse_image_spec): Check for nonnegative, not for positive,
221 when checking :margin (Bug#9390).
222 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
223 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
224 so that the name doesn't mislead. All uses changed.
226 2011-08-28 Johan Bockgård <bojohan@gnu.org>
228 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
231 2011-08-27 Eli Zaretskii <eliz@gnu.org>
233 * xdisp.c (move_it_to): Don't bail out early when reaching
234 position beyond to_charpos, if we are scanning backwards.
235 (move_it_vertically_backward): When DY == 0, make sure we get to
236 the first character in the line after the newline.
238 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
240 * ccl.c: Improve and simplify overflow checking (Bug#9196).
241 (ccl_driver): Do not generate an out-of-range pointer.
242 (Fccl_execute_on_string): Remove unnecessary check for
243 integer overflow, noted by Stefan Monnier in
244 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
245 Remove a FIXME that didn't need fixing.
246 Simplify the newly-introduced buffer reallocation code.
248 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
250 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
252 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
254 Integer and memory overflow issues (Bug#9196).
256 * doc.c (get_doc_string): Rework so that
257 get_doc_string_buffer_size is the actual buffer size, rather than
258 being 1 less than the actual buffer size; this makes xpalloc more
261 * image.c (x_allocate_bitmap_record, cache_image):
262 * xselect.c (Fx_register_dnd_atom):
263 Simplify previous changes by using xpalloc.
265 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
266 since either will do and ptrdiff_t is convenient with xpalloc.
268 * charset.c (charset_table_size)
269 (struct charset_sort_data.priority): Now ptrdiff_t.
270 (charset_compare): Don't overflow if priorities differ greatly.
271 (Fsort_charsets): Don't assume list length fits in int.
272 Check for size-calculation overflow when allocating sort data.
273 (syms_of_charset): Allocate an initial charset table that is
274 just under 64 KiB, to avoid problems with glibc malloc and mmap.
276 * cmds.c (internal_self_insert): Check for size-calculation overflow.
278 * composite.h (struct composition.glyph_len): Now int, not unsigned.
279 The actual value is always <= INT_MAX, and leaving it unsigned made
280 overflow checking harder.
282 * dispextern.h (struct glyph_matrix.rows_allocated)
283 (struct face_cache.size): Now ptrdiff_t, for convenience in use
284 with xpalloc. The values are still always <= INT_MAX.
286 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
288 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
289 (SAFE_NALLOCA): New macro.
291 * region-cache.c (struct boundary.pos, find_cache_boundary)
292 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
293 (set_cache_region, invalidate_region_cache)
294 (revalidate_region_cache, know_region_cache, region_cache_forward)
295 (region_cache_backward, pp_cache):
296 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
297 so that ptrdiff_t * can be passed to xpalloc.
298 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
299 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
300 (pp_cache): Don't assume cache_len fits in int.
301 * region-cache.h: Adjust extern decls to match.
303 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
304 EMACS_INT, since either will do, for xpalloc.
306 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
307 (xnmalloc, xnrealloc, xpalloc): New functions.
309 * bidi.c (bidi_shelve_header_size): New constant.
310 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
311 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
313 * bidi.c (bidi_cache_shrink):
314 * buffer.c (overlays_at, overlays_in, record_overlay_string)
316 Don't update size of array until after memory allocation succeeds,
317 because xmalloc/xrealloc may not return.
318 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
319 now that we have proper integer overflow checking.
320 (record_overlay_string, overlay_strings): Catch overflows when
321 calculating size of overlay_str_buf.
323 * callproc.c (Fcall_process): Check for size overflow when
324 calculating size of args2.
325 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
326 Normally we prefer signed values, but sticking with ptrdiff_t would
327 require adding more-complicated checks.
329 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
330 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
331 Redo buffer-overflow calculations to avoid integer overflow.
332 Add a FIXME comment where memory seems to be over-allocated.
334 * character.c (Fstring): Check for size-calculation overflow.
336 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
337 unnecessary integer overflow. Check for size overflow.
338 (encode_coding_object): Don't update size until xmalloc succeeds.
340 * composite.c (get_composition_id): Check for overflow in glyph
343 Integer and memory overflow fixes for display code.
344 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
345 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
346 (scrolling_window): Check for overflow in size calculations.
347 (line_draw_cost, realloc_glyph_pool, add_row_entry):
348 Don't assume glyph table len fits in int.
349 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
350 (row_table_size): Now ptrdiff_t, not int.
351 (scrolling_window): Avoid overflow in size calculations.
352 Don't update size until allocation succeeds.
353 * fns.c (concat): Check for overflow in size calculations.
354 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
355 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
356 (NEXT_ALMOST_PRIME_LIMIT): New constant.
358 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
359 (get_doc_string): Check for size calculation overflow.
360 Don't update size until allocation succeeds.
361 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
362 EMACS_INT, where ptrdiff_t will do.
363 (Fsubstitute_command_keys): Check for string overflow.
365 * editfns.c (set_time_zone_rule): Don't assume environment length
367 (message_length): Now ptrdiff_t, not int.
368 (Fmessage_box): Don't update size until allocation succeeds.
369 Don't assume message length fits in int.
370 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
372 * emacs.c (main): Do not reallocate argv, since there is a null at
373 the end that can be overwritten, and this way there's no need to
374 worry about size-calculation overflow.
375 (sort_args): Check for size-calculation overflow.
377 * eval.c (init_eval_once, grow_specpdl): Don't update size until
379 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
381 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
382 (x_set_scroll_bar_width, x_figure_window_size):
383 Check for integer overflow.
384 (x_set_alpha): Do not assume XINT fits in int.
386 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
387 This is for the members text_lines, text_cols, total_lines, total_cols,
388 where the system imposes an 'int' limit.
390 * fringe.c (Fdefine_fringe_bitmap):
391 Don't update size until alloc works.
393 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
394 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
396 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
397 Check for size-calculation overflow.
398 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
399 do, as we prefer signed integers.
400 (id_to_widget.max_size, id_to_widget.used)
401 (xg_store_widget_in_map, xg_remove_widget_from_map)
402 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
403 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
404 Use and return ptrdiff_t, not int.
405 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
406 * gtkutil.h: Change prototypes to match the above.
408 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
409 are duplicate now that they've been promoted to lisp.h.
410 (x_allocate_bitmap_record, x_alloc_image_color)
411 (make_image_cache, cache_image, xpm_load):
412 Don't update size until alloc is done.
413 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
415 Check for size calculation overflow.
416 (ct_colors_allocated_max): New constant.
417 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
420 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
421 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
422 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
423 Use ptrdiff_t, not int, to count maps.
424 (read_char_minibuf_menu_prompt): Check for overflow in size
425 calculations. Don't update size until allocation succeeds. Redo
426 calculations to avoid overflow.
427 * keyboard.h: Change prototypes to match the above.
429 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
431 (current_minor_maps): Check for size calculation overflow.
432 * keymap.h: Change prototypes to match the above.
434 * lread.c (read1, init_obarray): Don't update size until alloc done.
436 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
437 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
439 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
440 Now ptrdiff_t, not int.
441 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
442 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
444 * process.c (Fnetwork_interface_list): Check for overflow
447 * region-cache.c (move_cache_gap): Check for size calculation overflow.
449 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
450 overflow. Don't bother calling xmalloc when xrealloc will do.
452 * search.c (Freplace_match): Check for size calculation overflow.
453 (Fset_match_data): Don't assume list lengths fit in 'int'.
455 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
456 for command line length. Do not attempt to address one before the
457 beginning of an array, as that's not portable.
459 * term.c (max_frame_lines): Remove; unused.
460 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
462 (encode_terminal_code, calculate_costs): Check for size
463 calculation overflow.
464 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
465 table lengths and related sizes. Don't update size until alloc
466 done. Redo calculations to avoid overflow.
467 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
469 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
470 subtracting pointers.
471 (gobble_line): Check for overflow more carefully. Don't update size
474 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
475 Don't update size until alloc done.
476 Redo size calculations to avoid overflow.
477 Check for size calculation overflow.
478 (main) [DEBUG]: Fix typo in invoking tparam1.
480 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
481 Use ptrdiff_t, not int, for sizes.
482 (store_mode_line_noprop_char): Don't update size until alloc done.
484 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
485 Use ptrdiff_t, not int, for sizes.
486 (Finternal_make_lisp_face, cache_face):
487 Check for size calculation overflow.
488 (cache_face): Treat size calculation overflows as if they were
489 memory exhaustion (the usual treatment), rather than aborting.
491 * xfns.c (x_encode_text, x_set_name_internal)
492 (Fx_change_window_property): Use ptrdiff_t, not int, to count
493 sizes, since they can exceed INT_MAX in size. Check for size
494 calculation overflow.
496 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
497 (xg_select): Check for size calculation overflow.
498 Don't update size until alloc done.
500 * xrdb.c (get_environ_db): Don't assume path length fits in int,
501 as sprintf is limited to int lengths.
503 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
504 (X_LONG_MIN): New macros.
505 Use them to make the following changes clearer.
506 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
507 This change doesn't affect the value now, but it may help remind
508 future maintainers not to raise the value too much later.
509 (SELECTION_QUANTUM): Remove, replacing with ...
510 (selection_quantum): ... new function, which avoids overflow.
512 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
513 assumption that selection length fits in 'int'.
514 (x_reply_selection_request, x_handle_selection_request)
515 (x_get_window_property, receive_incremental_selection)
516 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
517 (lisp_data_to_selection_data, clean_local_selection_data):
518 Use ptrdiff_t, not int, to record length of selection.
519 (x_reply_selection_request, x_get_window_property)
520 (receive_incremental_selection, x_property_data_to_lisp):
521 Redo calculations to avoid overflow.
522 (x_reply_selection_request): When sending hint, ceiling it at
523 X_LONG_MAX rather than relying on wraparound overflow to send
525 (x_get_window_property, receive_incremental_selection)
526 (lisp_data_to_selection_data, x_property_data_to_lisp):
527 Check for size-calculation overflow.
528 (x_get_window_property, receive_incremental_selection)
529 (lisp_data_to_selection_data, Fx_register_dnd_atom):
530 Don't store size until memory allocation succeeds.
531 (x_get_window_property): Plug memory leak on memory exhaustion.
532 Don't double-block input; malloc is safe here. Don't assume 2**34
533 - 4 fits in unsigned long. Add an xassert to check
534 XGetWindowProperty overflow. Be more careful about overflow
535 calculations, and distinguish size from memory overflow better.
536 (receive_incremental_selection): When tracing, don't assume
537 unsigned int is less than INT_MAX.
538 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
539 harmful) conversions of unsigned short to int.
540 (lisp_data_to_selection_data): Don't assume that integers
541 in the range -65535 through -1 fit in an X unsigned short.
542 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
543 result parameters unless successful. Rely on cons_to_unsigned
544 to report problems with elements; the old code wasn't right anyway.
545 (x_check_property_data): Check for int overflow; we cannot use
546 a wider type due to X limits.
547 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
549 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
551 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
552 (x_term_init): Check for size calculation overflow.
553 (x_color_cells): Don't store size until memory allocation succeeds.
554 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
555 Don't assume alloca size is less than MAX_ALLOCA.
556 (x_term_init): Don't assume length fits in int (sprintf is limited
559 Use ptrdiff_t for composition IDs.
560 * character.c (lisp_string_width):
561 * composite.c (composition_table_size, n_compositions)
562 (get_composition_id, composition_gstring_from_id):
563 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
564 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
565 * window.c (Frecenter):
566 Use ptrdiff_t, not int, for composition IDs.
567 * composite.c (get_composition_id): Check for integer overflow.
568 * composite.h: Adjust prototypes to match the above changes.
570 Use ptrdiff_t for hash table indexes.
571 * category.c (hash_get_category_set):
572 * ccl.c (ccl_driver):
573 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
574 * coding.c (coding_system_charset_list, detect_coding_system):
575 * coding.h (struct coding_system.id):
576 * composite.c (get_composition_id, gstring_lookup_cache):
577 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
578 * image.c (xpm_get_color_table_h):
579 * lisp.h (hash_lookup, hash_put):
580 * minibuf.c (Ftest_completion):
581 Use ptrdiff_t for hash table indexes, not int (which is too
582 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
583 32-bit --with-wide-int hosts).
585 * charset.c (Fdefine_charset_internal): Check for integer overflow.
586 Add a FIXME comment about memory leaks.
587 (syms_of_charset): Don't assume xmalloc returns.
589 Don't assume that stated character widths fit in int.
590 * character.c (Fchar_width, c_string_width, lisp_string_width):
591 * character.h (CHAR_WIDTH):
592 * indent.c (MULTIBYTE_BYTES_WIDTH):
593 Use sanitize_char_width to avoid undefined and/or bad behavior
594 with outlandish widths.
595 * character.h (sanitize_tab_width): Renamed from sanitize_width,
596 now that we have two such functions. All uses changed.
597 (sanitize_char_width): New inline function.
599 Don't assume that tab-width fits in int.
600 * character.h (sanitize_width): New inline function.
601 (SANE_TAB_WIDTH): New macro.
602 (ASCII_CHAR_WIDTH): Use it.
603 * indent.c (sane_tab_width): Remove. All uses replaced by
604 SANE_TAB_WIDTH (current_buffer).
605 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
607 * fileio.c: Integer overflow issues with file modes.
608 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
610 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
611 Remove unreachable code.
612 (read_hex, load_charset_map_from_file): Check for integer overflow.
614 * xterm.c: don't go over XClientMessageEvent limit
615 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
616 (x_send_scroll_bar_event): Likewise. Check that the size does not
617 exceed limits imposed by XClientMessageEvent, as well as the usual
618 ptrdiff_t and size_t limits.
620 * keyboard.c: Overflow, signedness and related fixes.
621 (make_lispy_movement): Use same integer type in forward decl
622 that is used in the definition.
623 (read_key_sequence, keyremap_step):
624 Change bufsize argument back to int, undoing my 2011-03-30 change.
625 We prefer signed types, and int is wide enough here.
626 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
627 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
628 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
629 length, not size_t. Use ptrdiff_t for index, not int.
630 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
631 possibility of integer overflow.
633 Overflow, signedness and related fixes for images.
635 * dispextern.h (struct it.stack[0].u.image.image_id)
636 (struct_it.image_id, struct image.id, struct image_cache.size)
637 (struct image_cache.used, struct image_cache.ref_count):
638 * gtkutil.c (update_frame_tool_bar):
639 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
640 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
641 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
642 * nsmenu.m (update_frame_tool_bar):
643 * xdisp.c (calc_pixel_width_or_height):
644 * xfns.c (image_cache_refcount):
645 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
646 on typical 64-bit hosts.
648 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
649 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
650 Omit unnecessary casts to int.
651 (parse_image_spec): Check that integers fall into 'int' range
652 when the callers expect that.
653 (image_ascent): Redo ascent calculation to avoid int overflow.
654 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
655 (lookup_image): Remove unnecessary tests.
656 (xbm_image_p): Locals are now of int, not EMACS_INT,
657 since parse_image_check makes sure they fit into int.
658 (png_load, gif_load, svg_load_image):
659 Prefer int to unsigned where either will do.
660 (tiff_handler): New function, combining the cores of the
661 old tiff_error_handler and tiff_warning_handler. This
662 function is rewritten to use vsnprintf and thereby avoid
663 stack buffer overflows. It uses only the features of vsnprintf
664 that are common to both POSIX and native Microsoft.
665 (tiff_error_handler, tiff_warning_handler): Use it.
666 (tiff_load, gif_load, imagemagick_load_image):
667 Don't assume :index value fits in 'int'.
668 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
669 (imagemagick_load_image): Check that crop parameters fit into
670 the integer types that MagickCropImage accepts. Don't assume
671 Vimagemagick_render_type has a nonnegative value. Don't assume
672 size_t fits in 'long'.
673 (gs_load): Use printmax_t to print the widest integers possible.
674 Check for integer overflow when computing image height and width.
676 2011-08-26 Eli Zaretskii <eliz@gnu.org>
678 * xdisp.c (redisplay_window): Don't force window start if point
679 will be invisible in the resulting window. (Bug#9324)
681 2011-08-25 Eli Zaretskii <eliz@gnu.org>
683 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
684 the display spec is of the form `(space ...)'.
685 (handle_display_spec): Return the value returned by
686 handle_single_display_spec, not just 1 or zero.
687 (handle_single_display_spec): If the display spec is of the form
688 `(space ...)', and specifies display in the text area, return 2
690 (try_cursor_movement): Check for the need to scroll more
691 accurately, and prefer exact match for point under bidi. Don't
692 advance `row' beyond the last row of the window.
694 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
695 into disp_prop; all users changed.
697 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
698 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
699 for the text covered by the display property.
701 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
703 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
704 Change return value to nil.
705 (Frecord_buffer): Delete unused function.
707 2011-08-24 Eli Zaretskii <eliz@gnu.org>
709 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
710 buffers, return left-to-right.
711 (set_cursor_from_row): Consider candidate row a win if its glyph
712 represents a newline and point is on that newline. Fixes cursor
713 positioning on the newline at EOL of R2L text within L2R
714 paragraph, and vice versa.
715 (try_cursor_movement): Check continued rows, in addition to
716 continuation rows. Fixes unwarranted scroll when point enters a
717 continued line of R2L text within an L2R paragraph, or vice versa.
718 (cursor_row_p): Consider the case of point being equal to
719 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
720 from the end of a short line to the beginning of a continued line
721 of R2L text within L2R paragraph.
722 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
725 * bidi.c (bidi_check_type): Use xassert.
726 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
729 2011-08-23 Eli Zaretskii <eliz@gnu.org>
731 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
734 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
736 * nsfont.m (ns_otf_to_script): Fix typo.
738 2011-08-22 Kenichi Handa <handa@m17n.org>
740 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
741 extra slot even if the purpose is char-code-property-table.
743 2011-08-23 Eli Zaretskii <eliz@gnu.org>
745 * xdisp.c (redisplay_window): When computing centering_position,
746 account for the height of the header line. (Bug#8874)
748 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
749 instead of CHAR_TO_BYTE. Fixes a crash when a completion
750 candidate is selected by the mouse, and that candidate has a
751 composed character under the mouse.
753 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
754 coordinates reported by pos-visible-in-window-p for a composed
755 character in column zero.
757 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
759 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
761 2011-08-22 Eli Zaretskii <eliz@gnu.org>
763 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
764 consider it a hit if to_charpos is anywhere in the range of the
765 composed buffer positions.
767 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
769 * image.c (gif_load): Don't assume that each subimage has the same
770 dimensions as the base image. Handle disposal method that is
771 "undefined" by the gif spec (Bug#9335).
773 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
775 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
776 (Fcondition_case): Document `debug' symbol in error handler.
778 2011-08-19 Eli Zaretskii <eliz@gnu.org>
780 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
781 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
782 from an Org mode buffer to a Speedbar frame.
784 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
785 a composition, take its buffer position from IT->cmp_it.charpos.
786 Fixes cursor positioning at the beginning of a line that begins
787 with a composed character.
789 2011-08-18 Eli Zaretskii <eliz@gnu.org>
791 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
792 character bidirectional type, use STRONG_L instead. Fixes crashes
793 in a buffer produced by `describe-categories'.
795 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
796 members before the level stack, so they would be saved and
797 restored when copying iterator state. Fixes incorrect reordering
798 around TABs covered by display properties.
800 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
802 * process.c (Fnetwork_interface_list): Correctly determine buffer
805 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
807 * eval.c (internal_condition_case, internal_condition_case_1)
808 (internal_condition_case_2, internal_condition_case_n):
809 Remove unnecessary aborts (Bug#9081).
811 2011-08-17 Eli Zaretskii <eliz@gnu.org>
813 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
814 has no `load' handler, try opening the file locally. (Bug#9311)
816 2011-08-16 Ken Brown <kbrown@cornell.edu>
818 * gmalloc.c: Expand comment.
820 2011-08-16 Eli Zaretskii <eliz@gnu.org>
822 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
823 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
825 2011-08-16 Ken Brown <kbrown@cornell.edu>
827 Fix memory allocation problems in Cygwin build (Bug#9273).
829 * unexcw.c ( __malloc_initialized): Declare external variable.
830 (fixup_executable): Force the dumped emacs to reinitialize malloc.
832 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
834 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
836 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
838 [CYGWIN] (special_realloc): New function.
839 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
840 requests to realloc storage in the static heap.
842 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
844 * bidi.c (bidi_initialize): Remove unused local.
846 2011-08-15 Eli Zaretskii <eliz@gnu.org>
848 * biditype.h: File removed.
850 * bidimirror.h: File removed.
852 * deps.mk (bidi.o): Remove biditype.h and
855 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
858 * dispextern.h: Fix a typo in the comment to bidi_type_t.
860 * chartab.c: Improve commentary for the uniprop_table API.
862 * bidi.c (bidi_paragraph_init): Support zero value of
863 bidi_ignore_explicit_marks_for_paragraph_level.
864 (bidi_initialize): Use uniprop_table instead of including
865 biditype.h and bidimirror.h.
867 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
868 coordinates of the iterator when restoring from ppos_it.
871 2011-08-14 Kenichi Handa <handa@m17n.org>
873 * process.c (create_process): Call setup_process_coding_systems
874 after the pid of the process is set to -1 (Bug#8162).
876 2011-08-14 Eli Zaretskii <eliz@gnu.org>
878 * xdisp.c (move_it_in_display_line_to): Don't invoke
879 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
880 ppos_it. Fixes vertical cursor motion when line beginning is
881 covered by an image. (Bug#9296)
883 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
885 * nsterm.h (ns_run_ascript): Declare.
886 (NSAPP_DATA2_RUNASSCRIPT): Define.
888 * nsfns.m (as_script, as_result, as_status): New static variables.
889 (ns_run_ascript): New function.
890 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
891 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
892 the event loop. Get status from as_status (Bug#7276).
894 * nsterm.m (sendEvent): If event is NSApplicationDefined and
895 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
896 the event loop (Bug#7276).
898 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
900 * gnutls.c (QCgnutls_bootprop_priority)
901 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
902 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
903 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
904 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
905 (QCgnutls_bootprop_verify_hostname_error)
906 (QCgnutls_bootprop_callbacks_verify): Rename from
907 Qgnutls_bootprop_..., all uses changed.
909 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
912 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
914 * xfaces.c (Qframe_set_background_mode): Now static.
915 * dispextern.h (Qframe_set_background_mode): Remove decl.
917 * process.c (Fnetwork_interface_info): Declare local only if needed.
919 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
921 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
922 (Fnetwork_interface_list): Allocate in increments of bytes instead
923 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
924 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
926 (struct ifflag_def): notrailers is smart on OSX.
927 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
928 Get hardware address with getifaddrs if available.
930 2011-08-12 Eli Zaretskii <eliz@gnu.org>
932 * xdisp.c (iterate_out_of_display_property): xassert that
933 IT->position is set to within IT->object's boundaries. Break from
934 the loop as soon as EOB is reached; avoids infloops in redisplay
935 when IT->position is set up wrongly due to some bug.
936 Set IT->current to match the bidi iterator unconditionally.
937 (push_display_prop): Allow GET_FROM_STRING as IT->method on
938 entry. Force push_it to save on the stack the current
939 buffer/string position, to be restored by pop_it. Fix flags in
940 the iterator structure wrt the object coming from a display
941 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
942 properties. (Bug#9284)
944 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
946 * fontset.c (fontset_get_font_group): Add proper type checks.
949 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
951 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
952 and LC_VERSION_MIN_MACOSX.
953 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
954 (dump_it) [LC_FUNCTION_STARTS]: Use it.
956 2011-08-08 Eli Zaretskii <eliz@gnu.org>
958 * xdisp.c (forward_to_next_line_start): Allow to use the
959 no-display-properties-and-no-overlays under bidi display.
960 Set disp_pos in the bidi iterator to avoid searches for display
961 properties and overlays.
963 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
965 * editfns.c (Fset_time_zone_rule): Document relationship with the
968 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
969 the font entity extracted from the cache (Bug#8109).
971 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
973 * composite.c (autocmp_chars): Don't reset point. That is done by
974 restore_point_unwind (Bug#5984).
976 2011-08-07 Juri Linkov <juri@jurta.org>
978 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
979 to show the arg `TIME' instead of `TIMEVAL'.
981 2011-08-06 Eli Zaretskii <eliz@gnu.org>
983 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
984 display property strides EOL and includes a newline, as in
985 longlines-mode. (Bug#9254)
986 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
987 word-wrap under bidirectional display. (Bug#9224)
989 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
990 is non-zero, even if the data buffer is NULL. Fixes a crash in
991 vertical-motion with longlines-mode. (Bug#9254)
993 2011-08-05 Eli Zaretskii <eliz@gnu.org>
995 * bidi.c <bidi_cache_total_alloc>: Now static.
996 (bidi_initialize): Initialize bidi_cache_total_alloc.
998 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1001 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1002 amount allocated this far in `bidi_cache_total_alloc'.
1003 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1004 non-zero, only free the data buffer without restoring the cache
1005 contents. All callers changed.
1007 * dispextern.h (bidi_unshelve_cache): Update prototype.
1009 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1010 (move_it_in_display_line, move_it_to)
1011 (move_it_vertically_backward, move_it_by_lines): Replace the call
1012 to xfree to an equivalent call to bidi_unshelve_cache.
1013 (move_it_in_display_line_to): Fix logic of returning
1014 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1016 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1018 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1019 came from a string character with a `cursor' property. (Bug#9229)
1021 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1023 * Makefile.in (LIB_PTHREAD): New variable.
1024 (LIBES): Add LIB_PTHREAD (Bug#9216).
1026 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1027 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1029 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1031 * regex.c (re_iswctype): Remove some redundant boolean
1034 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1036 * xterm.c (x_find_topmost_parent): New function.
1037 (x_set_frame_alpha): Find topmost parent window with
1038 x_find_topmost_parent and set the property there also (bug#9181).
1039 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1041 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1043 * callproc.c (Fcall_process): Avoid vfork clobbering
1044 the local vars buffer, coding_systems, current_dir.
1046 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1048 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1050 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1052 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1053 so that it is not optimized away.
1055 * xdisp.c (compute_display_string_pos): Remove unused local.
1057 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1059 Fix slow cursor motion and scrolling in large buffers with
1060 selective display, like Org Mode buffers. (Bug#9218)
1062 * dispextern.h (struct bidi_it): New member disp_prop_p.
1064 * xdisp.c: Remove one-slot cache of display string positions.
1065 (compute_display_string_pos): Accept an additional argument
1066 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1067 for a display string or property. If found, set DISP_PROP_P
1070 * bidi.c (bidi_fetch_char): Accept an additional argument
1071 DISP_PROP_P, and pass it to compute_display_string_pos.
1072 Only handle text covered by a display string if DISP_PROP_P is returned
1073 non-zero. All callers of bidi_fetch_char changed.
1075 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1077 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1079 2010-12-03 Don March <don@ohspite.net>
1081 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1082 last character M-[char] is translated to ESC [char] (bug#7541).
1084 2011-08-02 Kenichi Handa <handa@m17n.org>
1086 * lisp.h (uniprop_table): Extern it.
1088 * chartab.c (uniprop_table): Make it non-static.
1090 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1092 * xdisp.c (forward_to_next_line_start): Accept additional argument
1093 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1095 (reseat_at_next_visible_line_start): Use the bidi iterator state
1096 returned by forward_to_next_line_start to restore the state of
1097 it->bidi_it after backing up to previous newline. (Bug#9212)
1099 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1101 * regex.c (re_comp): Protoize.
1102 (re_exec): Fix return type.
1103 (regexec): Fix type of `ret'. (Bug#9203)
1105 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1107 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1108 This is needed if max-image-size is a floating-point number.
1110 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1112 * print.c (print_object): Print empty symbol as ##.
1114 * lread.c (read1): Read ## as empty symbol.
1116 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1118 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1119 setting frame foreground color (Bug#9175).
1120 (x_set_background_color): Likewise.
1122 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1123 contents (Bug#9176).
1124 (EmacsTooltip -init): Remove bezels and add shadows to
1127 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1128 or scroll bar (Bug#8470).
1130 * nsfont.m (nsfont_open): Remove assignment to voffset and
1131 unnecessary vars hshink, expand, hd, full_height, min_height.
1132 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1134 * nsterm.h (nsfont_info): Remove voffset field.
1136 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1138 Implement strike-through and overline on NextStep (Bug#8863).
1140 * nsfont.m (nsfont_open): Use underline position provided by font,
1141 instead of hard-coded value of 2.
1142 (nsfont_draw): Call ns_draw_text_decoration instead.
1144 * nsterm.h: Add declaration for ns_draw_text_decoration.
1146 * nsterm.m (ns_draw_text_decoration): New function for drawing
1147 underline, overline, and strike-through.
1148 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1149 ns_draw_text_decoration. Change treatment of cursor drawing to
1150 accomodate underlining, etc.
1152 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1154 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1157 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1159 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1160 Without this fix, if a signal arrives just after memory fills up,
1161 'malloc' might be invoked reentrantly.
1163 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1164 In other words, assume that every image size is allowed, on non-X
1165 hosts. This assumption is probably wrong, but it lets Emacs compile.
1167 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1169 * regex.c (re_iswctype): Convert return values to boolean.
1171 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1173 * xdisp.c (compute_display_string_pos): Don't use cached display
1174 string position if the buffer had its restriction changed.
1177 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1179 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1181 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1183 Integer signedness and overflow and related fixes. (Bug#9079)
1185 * bidi.c: Integer size and overflow fixes.
1186 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1187 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1188 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1189 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1190 (bidi_find_other_level_edge):
1191 Use ptrdiff_t instead of EMACS_INT where either will do.
1192 This works better on 32-bit hosts configured --with-wide-int.
1193 (bidi_cache_ensure_space): Check for size-calculation overflow.
1194 Use % rather than repeated addition, for better worst-case speed.
1195 Don't set bidi_cache_size until after xrealloc returns, because it
1197 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1198 (bidi_cache_ensure_space): Also check that the bidi cache size
1199 does not exceed that of the largest Lisp string or buffer. See Eli
1200 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1202 * alloc.c (__malloc_size_t): Remove.
1203 All uses replaced by size_t. See Andreas Schwab's note
1204 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1206 * image.c: Improve checking for integer overflow.
1207 (check_image_size): Assume that f is nonnull, since
1208 it is always nonnull in practice. This is one less thing to
1209 worry about when checking for integer overflow later.
1210 (x_check_image_size): New function, which checks for integer
1211 overflow issues inside X.
1212 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1213 This removes the need for a memory_full check.
1214 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1215 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1216 (xbm_read_bitmap_data): Change locals back to 'int', since
1217 their values must fit in 'int'.
1218 (xpm_load_image, png_load, tiff_load):
1219 Invoke x_create_x_image_and_pixmap earlier,
1220 to avoid much needless work if the image is too large.
1221 (tiff_load): Treat overly large images as if
1222 x_create_x_image_and_pixmap failed, not as malloc failures.
1223 (gs_load): Use x_check_image_size.
1225 * gtkutil.c: Omit integer casts.
1226 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1227 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1229 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1231 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1232 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1233 would wrongly return t on a 64-bit host.
1235 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1236 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1237 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1238 and therefore cause GCC to emit a bogus diagnostic in some cases.
1240 * image.c: Integer signedness and overflow and related fixes.
1241 This is not an exhaustive set of fixes, but it's time to
1242 record what I've got.
1243 (lookup_pixel_color, check_image_size): Remove redundant decls.
1244 (check_image_size): Don't assume that arbitrary EMACS_INT values
1245 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1246 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1247 (tiff_load, imagemagick_load_image):
1248 Check for overflow in size calculations.
1249 (x_create_x_image_and_pixmap): Remove unnecessary test for
1250 xmalloc returning NULL; that can't happen.
1251 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1252 (xpm_color_bucket): Use better integer hashing function.
1253 (xpm_cache_color): Don't possibly over-allocate memory.
1254 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1255 (gif_memory_source):
1256 Use ptrdiff_t, not int or size_t, to record sizes.
1257 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1258 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1259 either works, as we prefer signed integers.
1260 (tiff_read_from_memory, tiff_write_from_memory):
1261 Return tsize_t, not size_t, since that's what the TIFF API wants.
1262 (tiff_read_from_memory): Don't fail simply because the read would
1263 go past EOF; instead, return a short read.
1264 (tiff_load): Omit no-longer-needed casts.
1265 (Fimagemagick_types): Don't assume size fits into 'int'.
1267 Improve hashing quality when configured --with-wide-int.
1268 * fns.c (hash_string): New function, taken from sxhash_string.
1269 Do not discard information about ASCII character case; this
1270 discarding is no longer needed.
1271 (sxhash-string): Use it. Change sig to match it. Caller changed.
1272 * lisp.h: Declare it.
1273 * lread.c (hash_string): Remove, since we now use fns.c's version.
1274 The fns.c version returns a wider integer if --with-wide-int is
1275 specified, so this should help the quality of the hashing a bit.
1277 * emacs.c: Integer overflow minor fix.
1278 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1279 Define only if GNU_LINUX.
1280 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1282 * dispnew.c: Integer signedness and overflow fixes.
1283 Remove unnecessary forward decls, that were a maintenance hassle.
1284 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1286 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1287 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1288 (prepare_desired_row, line_draw_cost):
1289 Use int, not unsigned, where either works.
1290 (save_current_matrix, restore_current_matrix):
1291 Use ptrdiff_t, not size_t, where either works.
1292 (init_display): Check for overflow more accurately, and without
1293 relying on undefined behavior.
1295 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1296 Remove, replacing with the new symbols in lisp.h. All uses changed.
1297 * fileio.c (make_temp_name):
1298 * filelock.c (lock_file_1, lock_file):
1299 * xdisp.c (message_dolog):
1300 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1301 Use pMd etc. instead.
1302 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1303 replacing the pWIDE etc. symbols removed from editfns.c.
1305 * keyboard.h (num_input_events): Now uintmax_t.
1306 This is (very slightly) less likely to mess up due to wraparound.
1309 * buffer.c: Integer signedness fixes.
1310 (alloc_buffer_text, enlarge_buffer_text):
1311 Use ptrdiff_t rather than size_t when either will do, as we prefer
1314 * alloc.c: Integer signedness and overflow fixes.
1315 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1316 (__malloc_size_t): Default to size_t, not to int.
1317 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1318 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1319 Prefer ptrdiff_t to size_t when either would do, as we prefer
1321 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1322 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1323 Now const. Initialize with values that are in range even if char
1325 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1326 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1327 These functions do the right thing with sizes > 2**32.
1328 (check_depth): Now ptrdiff_t, not int.
1329 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1330 Adjust to new way of storing sizes. Check for size overflow bugs
1332 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1333 slightly wrong anyway, as it missed one instance of
1334 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1335 (refill_memory_reserve): Omit needless cast to size_t.
1336 (mark_object_loop_halt): Mark as externally visible.
1338 * xselect.c: Integer signedness and overflow fixes.
1339 (Fx_register_dnd_atom, x_handle_dnd_message):
1340 Use ptrdiff_t, not size_t, since we prefer signed.
1341 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1342 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1343 x_dnd_atoms_size and x_dnd_atoms_length.
1345 * doprnt.c: Prefer signed to unsigned when either works.
1347 * doprnt.c (doprnt):
1349 * xdisp.c (vmessage):
1350 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1351 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1352 prefer signed arithmetic to avoid comparison confusion.
1353 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1354 but is a bit tricky.
1356 Assume freestanding C89 headers, string.h, stdlib.h.
1357 * data.c, doprnt.c, floatfns.c, print.c:
1358 Include float.h unconditionally.
1359 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1360 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1361 * regex.c: Likewise for stddef.h, string.h.
1362 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1363 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1364 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1365 (STDC_HEADERS): Remove obsolete defines.
1366 * sysdep.c: Include limits.h unconditionally.
1368 Assume support for memcmp, memcpy, memmove, memset.
1369 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1370 * regex.c (memcmp, memcpy):
1371 Remove; we assume C89 now.
1373 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1374 (__malloc_safe_bcopy): Remove; no longer needed.
1376 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1377 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1378 well either way, and we prefer signed to unsigned.
1380 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1382 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1383 closes the connection while we're reading (bug#9182).
1385 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1387 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1388 are specified (Bug#9168).
1390 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1392 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1393 Found by GCC static checking and --with-wide-int on a 32-bit host.
1395 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1397 * xdisp.c (compute_display_string_pos): Fix logic of caching
1398 previous display string position. Initialize cached_prev_pos to
1399 -1. Fixes slow-down at the beginning of a buffer.
1401 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1403 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1404 for attrs[LFACE_FONTSET_INDEX].
1406 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1408 * xml.c (parse_region): Remove unused local
1409 that was recently introduced.
1411 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1413 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1414 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1416 * xdisp.c (move_it_in_display_line_to): Record the best matching
1417 position for TO_CHARPOS while scanning the line, and restore it on
1418 exit if none of the characters scanned was an exact match.
1419 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1420 when exact match is impossible due to invisible text, and the
1421 lines are truncated.
1423 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1425 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1428 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1430 Fix a significant slow-down of cursor motion with C-n, C-p,
1431 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1432 auto-repeat under bidi redisplay in fontified buffers.
1433 * xdisp.c (compute_stop_pos_backwards): New function.
1434 (next_element_from_buffer): Call compute_stop_pos_backwards to
1435 find a suitable prev_stop when we find ourselves before
1437 (reseat): Don't look for prev_stop, as that could mean a very long
1439 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1440 <cached_disp_overlay_modiff>: Cache for last found display string
1442 (compute_display_string_pos): Return the cached position if asked
1443 about the same buffer in the same area of character positions, and
1444 the buffer wasn't changed since the time the display string
1445 position was cached.
1447 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1449 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1450 is an integer, which is important for empty lines. (Bug#9149)
1452 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1454 * frame.c (Fmodify_frame_parameters): In tty case, update the
1455 default face if necessary (Bug#4238).
1457 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1459 * editfns.c (Fstring_to_char): No need to explain what a character
1460 is in the docstring (Bug#6576).
1462 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1464 * xml.c (parse_region): Make sure we always return a tree.
1466 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1468 * xml.c (parse_region): If a document contains only comments,
1471 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1473 * xml.c (make_dom): Return comments, too.
1475 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1478 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1479 and the surrounding thread.
1480 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1481 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1482 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1484 * s/openbsd.h (BROKEN_SIGIO): Define.
1485 * unexelf.c (unexec) [__OpenBSD__]:
1486 Don't update the .mdebug section of the Alpha COFF symbol table.
1488 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1490 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1493 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1495 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1496 This fixes some race conditions on the permissions of any newly
1499 * alloc.c (valid_pointer_p): Use pipe, not open.
1500 This fixes some permissions issues when debugging.
1502 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1503 If fchown fails to set both uid and gid, try to set just gid,
1504 as that is sometimes allowed. Adjust the file's mode to eliminate
1505 setuid or setgid bits that are inappropriate if fchown fails.
1507 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1509 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1510 to compare Lisp_Objects.
1511 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1512 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1513 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1515 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1517 * lread.c (read_integer): Unread even EOF character.
1518 (read1): Likewise. Properly record start position of symbol.
1520 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1521 symbol character follows.
1523 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1525 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1526 This works around a problem with the previous change to Fcopy_file.
1527 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1528 and without this change, GCC might complain about discarding
1529 fchown's return value.
1531 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1533 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1535 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1537 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1539 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1541 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1542 it's used from the C level.
1544 * process.c: Use the same condition for POLL_FOR_INPUT in both
1545 keyboard.c and process.c (bug#1858).
1547 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1549 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1550 (Fgnutls_boot): Use it.
1552 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1554 * doc.c (Fsubstitute_command_keys): Revert last change.
1556 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1558 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1559 quotes the next character, and doesn't affect other longer
1560 sequences (bug#8935).
1562 * lread.c (syms_of_lread): Clarify that is isn't only
1563 `eval-buffer' and `eval-defun' that's affected by
1564 `lexical-binding' (bug#8460).
1566 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1568 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1569 bidi redisplay when a line includes both an image and is
1572 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1574 Fix minor problems found by static checking.
1575 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1576 (elsz): Now a signed constant, not a size_t var. We prefer signed
1577 types to unsigned, to avoid integer comparison confusion. Without
1578 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1579 "cannot optimize loop, the loop counter may overflow", a symptom
1581 * indent.c (Fvertical_motion): Mark locals as initialized.
1582 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1584 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1586 * search.c (Fre_search_backward): Mention `case-fold-search' in
1587 all the re_search_* functions (bug#8138).
1589 * keyboard.c (Fopen_dribble_file): Document when the file is
1592 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1594 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1597 Support bidi reordering of display and overlay strings.
1598 * xdisp.c (compute_display_string_pos)
1599 (compute_display_string_end): Accept additional argument STRING.
1600 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1601 (reseat_to_string): Initialize bidi_it->string.s and
1602 bidi_it->string.schars.
1603 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1604 NULL (avoids a crash in bidi_paragraph_init).
1605 Initialize itb.string.lstring.
1606 (init_iterator): Call bidi_init_it only of a valid
1607 buffer position was specified. Initialize paragraph_embedding to
1609 (reseat_to_string): Initialize the bidi iterator.
1610 (display_string): If we need to ignore text properties of
1611 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1612 original value of -1 will not work with bidi.)
1613 (compute_display_string_pos): First arg is now struct
1614 `text_pos *'; all callers changed. Support display properties on
1616 (compute_display_string_end): Support display properties on Lisp
1618 (init_iterator, reseat_1, reseat_to_string): Initialize the
1619 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1620 when iterating on a string not from display properties).
1621 (compute_display_string_pos, compute_display_string_end):
1622 Fix calculation of the object to scan. Fixes an error when using
1624 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1625 base_level_stop; instead, set base_level_stop to BEGV.
1626 Fixes crashes in vertical-motion.
1627 (next_element_from_buffer): Improve commentary for when
1628 the iterator is before prev_stop.
1629 (init_iterator): Initialize bidi_p from the default value of
1630 bidi-display-reordering, not from buffer-local value. Use the
1631 buffer-local value only if initializing for buffer iteration.
1632 (handle_invisible_prop): Support invisible properties on strings
1633 that are being bidi-reordered.
1634 (set_iterator_to_next): Support bidi reordering of C strings and
1636 (next_element_from_string): Support bidi reordering of Lisp
1638 (handle_stop_backwards): Support Lisp strings as well.
1639 (display_string): Support display of R2L glyph rows.
1640 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1641 (init_iterator): Don't initialize it->bidi_p for strings
1643 (reseat_to_string): Initialize it->bidi_p for strings here.
1644 (next_element_from_string, next_element_from_c_string)
1645 (next_element_from_buffer): Add xassert's for correspondence
1646 between IT's object being iterated and it->bidi_it.string
1648 (face_before_or_after_it_pos): Support bidi iteration.
1649 (next_element_from_c_string): Handle the case of the first string
1650 character that is not the first one in the visual order.
1651 (get_visually_first_element): New function, refactored from common
1652 parts of next_element_from_buffer, next_element_from_string, and
1653 next_element_from_c_string.
1654 (tool_bar_lines_needed, redisplay_tool_bar)
1655 (display_menu_bar): Force left-to-right direction. Add a FIXME
1656 comment for making that be controlled by a user option.
1657 (push_it, pop_it): Save and restore the state of the
1658 bidi iterator. Save and restore the bidi_p flag.
1659 (pop_it): Iterate out of display property for string iteration as
1661 (iterate_out_of_display_property): Support iteration over strings.
1662 (handle_single_display_spec): Set up it->bidi_it for iteration
1663 over a display string, and call bidi_init_it.
1664 (handle_single_display_spec, next_overlay_string)
1665 (get_overlay_strings_1, push_display_prop): Set up the bidi
1666 iterator for displaying display or overlay strings.
1667 (forward_to_next_line_start): Don't use the shortcut if
1669 (back_to_previous_visible_line_start): If handle_display_prop
1670 pushed the iterator stack, restore the internal state of the bidi
1671 iterator by calling bidi_pop_it same number of times.
1672 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1673 and we are bidi-iterating, don't decrement the iterator position;
1674 instead, set the first_elt flag in the bidi iterator, to produce
1676 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1677 (push_display_prop): xassert that we are iterating a buffer.
1678 (push_it, pop_it): Save and restore paragraph_embedding member.
1679 (handle_single_display_spec, next_overlay_string)
1680 (get_overlay_strings_1, reseat_1, reseat_to_string)
1681 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1682 correctly. Don't assume unibyte strings are not bidi-reordered.
1683 (compute_display_string_pos)
1684 (compute_display_string_end): Fix handling the case of C string.
1685 (push_it, pop_it): Save and restore from_disp_prop_p.
1686 (handle_single_display_spec, push_display_prop): Set the
1687 from_disp_prop_p flag.
1688 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1689 (pop_it): Call iterate_out_of_display_property only if we are
1690 popping after iteration over a string that came from a display
1691 property. Fix a typo in popping stretch info. Add an assertion
1692 for verifying that the iterator position is in sync with the bidi
1694 (handle_single_display_spec, get_overlay_strings_1)
1695 (push_display_prop): Fix initialization of paragraph direction for
1696 string when that of the parent object is not yet determined.
1697 (reseat_1): Call bidi_init_it to resync the bidi
1698 iterator with IT's position. (Bug#7616)
1699 (find_row_edges): If ROW->start.pos gives position
1700 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1701 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1702 Reset the from_disp_prop_p flag.
1703 (SAVE_IT, RESTORE_IT): New macros.
1704 (pos_visible_p, face_before_or_after_it_pos)
1705 (back_to_previous_visible_line_start)
1706 (move_it_in_display_line_to, move_it_in_display_line)
1707 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1708 (try_scrolling, redisplay_window, display_line): Use them when
1709 saving a temporary copy of the iterator and restoring it back.
1710 (back_to_previous_visible_line_start, reseat_1)
1711 (init_iterator): Empty the bidi cache "stack".
1712 (move_it_in_display_line_to): If iterator ended up at
1713 EOL, but we never saw any buffer positions smaller than
1714 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1715 motion in bidi-reordered lines.
1716 (move_it_in_display_line_to): Record prev_method and prev_pos
1717 immediately before the call to set_iterator_to_next. Fixes cursor
1718 motion in bidi-reordered lines with stretch glyphs and strings
1719 displayed in margins. (Bug#8133) (Bug#8867)
1720 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1722 (pos_visible_p): Support positions in bidi-reordered lines.
1723 Save and restore bidi cache.
1725 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1726 (bidi_paragraph_info): Delete unused struct.
1727 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1728 (bidi_cache_start): New variable.
1729 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1731 (bidi_cache_fetch_state, bidi_cache_search)
1732 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1733 (bidi_cache_find, bidi_peek_at_next_level)
1734 (bidi_level_of_next_char, bidi_find_other_level_edge)
1735 (bidi_move_to_visually_next): Compare cache index with
1736 bidi_cache_start rather than with zero.
1737 (bidi_fetch_char): Accept new argument STRING; all callers
1738 changed. Support iteration over a string. Support strings with
1739 display properties. Support unibyte strings. Fix the type of
1740 `len' according to what STRING_CHAR_AND_LENGTH expects.
1741 (bidi_paragraph_init, bidi_resolve_explicit_1)
1742 (bidi_resolve_explicit, bidi_resolve_weak)
1743 (bidi_level_of_next_char, bidi_move_to_visually_next):
1744 Support iteration over a string.
1745 (bidi_set_sor_type, bidi_resolve_explicit_1)
1746 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1747 can now be zero (for strings); special values 0 and -1 were
1748 changed to -1 and -2, respectively.
1749 (bidi_char_at_pos): New function.
1750 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1751 Call it instead of FETCH_MULTIBYTE_CHAR.
1752 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1753 initialized to valid values.
1754 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1756 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1757 the test for valid cached positions. Fix the logic for looking up
1758 the sentinel state in the cache. GCPRO the Lisp string we are
1760 (bidi_push_it, bidi_pop_it): New functions.
1761 (bidi_initialize): Initialize the bidi cache start stack pointer.
1762 (bidi_cache_ensure_space): New function, refactored from part of
1763 bidi_cache_iterator_state. Don't assume the required size is just
1764 one BIDI_CACHE_CHUNK away.
1765 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1766 (bidi_count_bytes, bidi_char_at_pos): New functions.
1767 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1768 always valid if bidi_cache_idx is valid.
1769 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1770 is valid if it's going to be used.
1771 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1772 (bidi_cache_fetch_state, bidi_cache_search)
1773 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1774 (bidi_cache_iterator_state, bidi_cache_find)
1775 (bidi_find_other_level_edge, bidi_cache_start_stack):
1776 All variables related to cache indices are now EMACS_INT.
1778 * dispextern.h (struct bidi_string_data): New structure.
1779 (struct bidi_it): New member `string'. Make flag members be 1-bit
1780 fields, and put them last in the struct.
1781 (compute_display_string_pos, compute_display_string_end):
1783 (bidi_push_it, bidi_pop_it): Add prototypes.
1784 (struct iterator_stack_entry): New members bidi_p,
1785 paragraph_embedding, and from_disp_prop_p.
1786 (struct it): Member bidi_p is now a bit field 1 bit wide.
1787 (bidi_shelve_cache, bidi_unshelve_cache):
1790 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1791 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1792 and vector-like objects.
1794 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1795 cache around display iteration.
1797 * window.c (Fwindow_end, window_scroll_pixel_based)
1798 (displayed_window_lines, Frecenter): Save and restore the bidi
1799 cache around display iteration.
1801 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1803 * editfns.c (Fdelete_region): Clarify the use of the named
1804 parameters (bug#6788).
1806 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1808 * indent.c (Fvertical_motion): Set and restore w->pointm when
1809 saving and restoring the window's buffer (Bug#9006).
1811 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1813 * editfns.c (Fstring_to_char): Clarify just what is returned
1814 (bug#6576). Text by Eli Zaretskii.
1816 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1818 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1820 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1822 * buffer.c (mmap_find): Fix a typo.
1824 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1826 Fix execution of x selection hooks.
1827 * xselect.c (Qx_lost_selection_functions)
1828 (Qx_sent_selection_functions): New vars.
1829 (syms_of_xselect): DEFSYM them.
1830 (x_handle_selection_request): Pass Qx_sent_selection_functions
1831 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1832 (x_handle_selection_clear,x_clear_frame_selections):
1833 Pass Qx_lost_selection_functions rather than
1834 Vx_lost_selection_functions to Frun_hook_with_args.
1836 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1838 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1839 The old code sometimes used this field without initializing it.
1841 * alloc.c (gc_sweep): Don't read past end of array.
1842 In theory, the old code could also have corrupted Emacs internals,
1843 though it'd be very unlikely.
1845 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1847 * character.c (Fcharacterp): Don't advertise optional ignored
1848 argument. (Bug#4026)
1850 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1852 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1855 * window.c (Fset_window_start): Doc fix (bug#4199).
1856 (Fset_window_hscroll): Ditto.
1858 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1860 Fix minor new problems caught by GCC 4.6.1.
1861 * term.c (init_tty): Remove unused local.
1862 * xsettings.c (store_monospaced_changed): Define this function only
1863 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1866 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1868 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1870 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1872 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1873 are the mini-buffer and the echo area (bug#3320).
1875 * term.c (init_tty): Remove support for supdup, c10 and perq
1876 terminals, which are no longer supported (bug#1482).
1878 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1880 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1882 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1884 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1885 for non-popups (Bug#3642).
1887 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1889 * alloc.c (reset_malloc_hooks): Protoize.
1890 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1891 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1892 * cm.c (losecursor): Likewise.
1893 * data.c (fmod): Likewise.
1894 * dispnew.c (swap_glyphs_in_rows): Likewise.
1895 * emacs.c (memory_warning_signal): Likewise.
1896 * floatfns.c (float_error): Likewise.
1897 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1898 (otf_open, font_otf_capability, generate_otf_features)
1899 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1901 * image.c (pbm_read_file): Likewise.
1902 * indent.c (string_display_width): Likewise.
1903 * intervals.c (check_for_interval, search_for_interval)
1904 (inc_interval_count, count_intervals, root_interval)
1905 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1906 * lread.c (defalias): Likewise.
1907 * ralloc.c (r_alloc_check): Likewise.
1908 * regex.c (set_image_of_range_1, set_image_of_range)
1909 (regex_grow_registers): Likewise.
1910 * sysdep.c (strerror): Likewise.
1911 * termcap.c (valid_filename_p, tprint, main): Likewise.
1912 * tparam.c (main): Likewise.
1913 * unexhp9k800.c (run_time_remap, save_data_space)
1914 (update_file_ptrs, read_header, write_header, calculate_checksum)
1915 (copy_file, copy_rest, display_header): Likewise.
1916 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1918 * xdisp.c (check_it): Likewise.
1919 * xfaces.c (register_color, unregister_color, unregister_colors):
1921 * xfns.c (print_fontset_result): Likewise.
1922 * xrdb.c (member, fatal, main): Likewise.
1924 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1926 Fix minor problems found by static checking (Bug#9031).
1927 * chartab.c (char_table_set_range, map_sub_char_table):
1928 Remove unused locals.
1929 (uniprop_table): Now static.
1930 * composite.c (_work_char): Remove unused static var.
1932 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1934 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1936 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1938 * gtkutil.c (qttip_cb): Remove code without function.
1940 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1942 * w32.c (pthread_sigmask): New stub.
1944 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1946 Use pthread_sigmask, not sigprocmask (Bug#9010).
1947 sigprocmask is portable only for single-threaded applications, and
1948 Emacs can be multi-threaded when it uses GTK.
1949 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1951 * callproc.c (Fcall_process):
1952 * process.c (create_process):
1953 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1954 Use pthread_sigmask, not sigprocmask.
1956 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1958 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1959 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1962 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1964 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1965 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1966 (xg_hide_tooltip): Fix comment.
1968 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1969 in registerServicesMenuSendTypes.
1970 (validRequestorForSendType): Don't check ns_return_types.
1972 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1975 2011-07-08 Jason Rumney <jasonr@gnu.org>
1977 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1978 frame struct members of non-existent frames (Bug#6284).
1980 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1982 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1983 variable firstTime not needed on OSX >= 10.6.
1984 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1985 >= 10.5. Use setKnobProportion, setDoubleValue.
1987 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1988 (MAC_OS_X_VERSION_10_5): Define if not defined.
1989 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1990 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1991 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1993 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1994 cString and lossyCString on OSX >= 10.4
1996 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1997 sizeToFit on OSX >= 10.2.
1999 * nsimage.m (allocInitFromFile): Don't use deprecated method
2000 bestRepresentationForDevice on OSX >= 10.6.
2002 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2005 * emacs.c: Declare unexec_init_emacs_zone.
2007 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2009 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2011 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2012 on svcsMenu (Bug#8842).
2014 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2016 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2018 * nsterm.m (QUTF8_STRING): Declare.
2019 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2020 (validRequestorForSendType): Return type is (id).
2021 Change indexOfObjectIdenticalTo to indexOfObject.
2022 Check if we have local selection before returning self (Bug#8842).
2023 (writeSelectionToPasteboard): Put local selection into paste board
2024 if we have a local selection (Bug#8842).
2025 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2027 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2028 (ns_get_local_selection): Declare.
2030 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2032 * keymap.c (describe_map_tree): Don't insert a double newline at
2033 the end of the buffer (bug#1169) and return whether we inserted
2036 * callint.c (Fcall_interactively): Change "reading args" to
2037 "providing args" to try to clarify what it does (bug#1010).
2039 2011-07-07 Kenichi Handa <handa@m17n.org>
2041 * composite.c (composition_compute_stop_pos): Ignore a static
2042 composition starting before CHARPOS (Bug#8915).
2044 * xdisp.c (handle_composition_prop): Likewise.
2046 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2048 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2051 2011-07-07 Kenichi Handa <handa@m17n.org>
2053 * character.h (unicode_category_t): New enum type.
2055 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2056 (Qchar_code_property_table): New variable.
2057 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2058 (UNIPROP_COMPRESSED_FORM_P): New macros.
2059 (char_table_ascii): Uncompress the compressed values.
2060 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2061 Uncompress the compressed values.
2062 (sub_char_table_ref_and_range): Likewise.
2063 (char_table_ref_and_range): Uncompress the compressed values.
2064 (sub_char_table_set): New arg is_uniprop. Callers changed.
2065 Uncompress the compressed values.
2066 (sub_char_table_set_range): Args changed. Callers changed.
2067 (char_table_set_range): Adjuted for the above change.
2068 (map_sub_char_table): Delete args default_val and parent. Add arg
2069 top. Give decoded values to a Lisp function.
2070 (map_char_table): Adjust for the above change. Give decoded
2071 values to a Lisp function. Gcpro more variables.
2072 (uniprop_table_uncompress)
2073 (uniprop_decode_value_run_length): New functions.
2074 (uniprop_decoder, uniprop_decoder_count): New variables.
2075 (uniprop_get_decoder, uniprop_encode_value_character)
2076 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2078 (uniprop_encoder, uniprop_encoder_count): New variables.
2079 (uniprop_get_encoder, uniprop_table)
2080 (Funicode_property_table_internal, Fget_unicode_property_internal)
2081 (Fput_unicode_property_internal): New functions.
2082 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2083 Sunicode_property_table_internal, Sget_unicode_property_internal,
2084 and Sput_unicode_property_internal. Defvar_lisp
2085 char-code-property-alist.
2087 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2088 Vunicode_category_table.
2090 * font.c (font_range): Adjust for the change of
2091 Vunicode_category_table.
2093 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2095 * m/iris4d.h: Remove file, move contents ...
2096 * s/irix6-5.h: ... here.
2098 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2100 Remove unportable assumption about struct layout (Bug#8884).
2101 * alloc.c (mark_buffer):
2102 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2103 (clone_per_buffer_values): Don't assume that
2104 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2105 This isn't true in general, and it's particularly not true
2106 if Emacs is configured with --with-wide-int.
2107 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2108 New macros, used in the buffer.c change.
2110 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2112 * xsettings.c: Use both GConf and GSettings if both are available.
2113 (store_config_changed_event): Add comment.
2114 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2115 (store_tool_bar_style_changed): New functions.
2116 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2117 (struct xsettings): Move font inside HAVE_XFT.
2118 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2119 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2120 Move inside HAVE_XFT.
2121 (something_changed_gsettingsCB): Rename from something_changedCB.
2122 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2124 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2125 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2126 (something_changed_gconfCB): Rename from something_changedCB.
2127 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2128 (parse_settings): Move check for font inside HAVE_XFT.
2129 (read_settings, apply_xft_settings): Add comment.
2130 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2131 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2132 call store_font_name_changed.
2133 (xft_settings_event): Add comment.
2134 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2135 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2136 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2137 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2138 (xsettings_initialize): Call init_gsettings last.
2139 (xsettings_get_system_font, xsettings_get_system_normal_font):
2142 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2144 Random fixes. E.g., (random) never returned negative values.
2145 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2146 subseconds part to the entropy, as that's a bit more random.
2147 Prefer signed to unsigned, since the signedness doesn't matter and
2148 in general we prefer signed. When given a limit, use a
2149 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2150 latter isn't right if USE_2_TAGS_FOR_INTS.
2151 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2152 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2154 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2156 * textprop.c (text_property_stickiness):
2157 Obey Vtext_property_default_nonsticky.
2158 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2159 * w32fns.c (syms_of_w32fns):
2160 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2162 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2164 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2165 This is more efficient than Ffile_directory_p and avoids a minor race.
2167 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2169 * buffer.c (Foverlay_put): Say what the return value is
2172 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2173 is a directory before asking whether to use the file name
2175 (barf_or_query_if_file_exists): Make the "File is a directory"
2176 error be more correct.
2178 * fns.c (Frequire): Remove the mention of the .gz files, since
2179 that's installation-specific, but keep the mention of
2180 `get-load-suffixes'.
2182 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2184 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2185 Report string overflow if the output is too long.
2187 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2189 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2190 (syms_of_gnutls): Remove duplicate DEFSYM for
2191 Qgnutls_bootprop_verify_hostname_error, an error for
2192 Qgnutls_bootprop_verify_error (which is no longer used).
2194 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2195 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2196 Also (re)move comments that are misplaced or no longer relevant.
2198 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2200 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2202 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2204 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2205 and background color parameters if they have been changed.
2207 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2209 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2211 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2213 * xsettings.c (SYSTEM_FONT): Define only when used.
2214 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2216 * keymap.c (access_keymap_1): Now static.
2218 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2220 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2221 leave any prefix arg for the up event (Bug#1586).
2223 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2225 * lread.c (syms_of_lread): Mention single symbols defined by
2226 `defvar' or `defconst' (bug#7154).
2228 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2229 (Frequire): Mention get-load-suffixes.
2231 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2233 * window.h (window): Remove clone_number slot.
2234 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2236 (make_parent_window, make_window, saved_window)
2237 (Fset_window_configuration, save_window_save): Don't deal with
2239 * buffer.c (Qclone_number): Remove declaration.
2240 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2242 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2244 Add multiple inheritance to keymaps.
2245 * keymap.c (Fmake_composed_keymap): New function.
2246 (Fset_keymap_parent): Simplify.
2247 (fix_submap_inheritance): Remove.
2248 (access_keymap_1): New function extracted from access_keymap to handle
2249 embedded parents and handle lists of maps.
2250 (access_keymap): Use it.
2251 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2252 (Fcopy_keymap): Handle embedded parents.
2253 (Fcommand_remapping, define_as_prefix): Simplify.
2254 (Fkey_binding): Simplify.
2255 (syms_of_keymap): Move minibuffer-local-completion-map,
2256 minibuffer-local-filename-completion-map,
2257 minibuffer-local-must-match-map, and
2258 minibuffer-local-filename-must-match-map to Elisp.
2259 (syms_of_keymap): Defsubr make-composed-keymap.
2260 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2261 (parse_menu_item): Trivial simplification.
2263 2011-07-01 Glenn Morris <rgm@gnu.org>
2265 * Makefile.in (SETTINGS_LIBS): Fix typo.
2267 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2269 * coding.c (Fencode_coding_string): Record the last coding system
2270 used, as the function doc string says (bug#8738).
2272 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2274 * xsettings.c (store_monospaced_changed): Take new font as arg and
2275 check for change against current_mono_font.
2276 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2277 (emacs_settings_constructor, emacs_settings_get_property)
2278 (emacs_settings_set_property, emacs_settings_class_init)
2279 (emacs_settings_init, gsettings_obj): Remove.
2280 (something_changedCB): New function for HAVE_GSETTINGS.
2281 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2282 with value as argument.
2283 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2284 g_settings_new (Bug#8967). Do not create gsettings_obj.
2285 Remove calls to g_settings_bind. Connect something_changedCB to
2288 * xgselect.c: Add defined (HAVE_GSETTINGS).
2289 (xgselect_initialize): Ditto.
2291 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2292 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2295 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2297 * eval.c (struct backtrace): Simplify and port the data structure.
2298 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2299 signed bit field, as this assumption is not portable and it makes
2300 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2301 "char debug_on_exit : 1" as this is not portable either; instead,
2302 use the portable "unsigned int debug_on_exit : 1". Remove unused
2303 member evalargs. Remove obsolete comments about cc bombing out.
2305 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2307 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2308 Let HAVE_GSETTINGS override HAVE_GCONF.
2309 (store_monospaced_changed): New function.
2310 (EMACS_SETTINGS): A new type derived from GObject to handle
2311 GSettings notifications.
2312 (emacs_settings_constructor, emacs_settings_get_property)
2313 (emacs_settings_set_property, emacs_settings_class_init):
2315 (gsettings_client, gsettings_obj): New variables.
2316 (GSETTINGS_SCHEMA): New define.
2317 (something_changedCB): Call store_monospaced_changed.
2318 (init_gsettings): New function.
2319 (xsettings_initialize): Call init_gsettings.
2320 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2323 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2326 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2328 * window.c (resize_root_window, grow_mini_window)
2329 (shrink_mini_window): Rename Qresize_root_window to
2330 Qwindow_resize_root_window and Qresize_root_window_vertically to
2331 Qwindow_resize_root_window_vertically.
2333 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2335 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2337 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2339 * makefile.w32-in: Redesign dependencies so they reflect more
2340 clearly which files are directly included by each source file,
2341 and not through other includes.
2343 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2345 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2346 (sort_overlays, overlay_strings): When an overlay's clone number
2347 matches the window's clone number process the overlay even if
2348 the overlay's window property doesn't match the current window.
2350 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2351 (Fwindow_hchild): Rename to Fwindow_left_child.
2352 (Fwindow_next): Rename to Fwindow_next_sibling.
2353 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2354 (resize_window_check): Rename to window_resize_check.
2355 (resize_window_apply): Rename to window_resize_apply.
2356 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2357 (Fdelete_other_windows_internal, resize_frame_windows)
2358 (Fsplit_window_internal, Fdelete_window_internal)
2359 (grow_mini_window, shrink_mini_window)
2360 (Fresize_mini_window_internal): Fix callers accordingly.
2362 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2364 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2365 (emacs_fixed_set_min_size): Remove.
2366 (emacs_fixed_new): Take frame as argument.
2368 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2369 (_EmacsFixedPrivate): Remove minwidth/height.
2370 Add struct frame *f.
2371 (emacs_fixed_init): Initialize priv->f.
2372 (get_parent_class, emacs_fixed_set_min_size): Remove.
2373 (emacs_fixed_new): Set priv->f to argument.
2374 (emacs_fixed_get_preferred_width)
2375 (emacs_fixed_get_preferred_height): Use min_width/height from
2376 frames size_hint to set minimum and natural (Bug#8919).
2377 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2378 and use min_width/height from frames size_hint to set
2379 min_width/height (Bug#8919).
2381 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2382 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2385 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2387 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2388 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2391 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2393 * process.c (wait_reading_process_output): Bypass select if
2394 waiting for a cell while ignoring keyboard input, and input is
2395 pending. Suggested by Jan Djärv (Bug#8869).
2397 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2399 Use gnulib's dup2 module instead of rolling our own.
2400 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2402 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2404 * dispnew.c (scrolling_window): Before scrolling, turn off a
2405 mouse-highlight in the window being scrolled.
2407 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2409 Move DEFSYM to lisp.h and use everywhere.
2411 * character.h (DEFSYM): Move declaration...
2412 * lisp.h (DEFSYM): ...here.
2418 * w32select.c: Don't include character.h.
2420 * alloc.c (syms_of_alloc):
2421 * buffer.c (syms_of_buffer):
2422 * bytecode.c (syms_of_bytecode):
2423 * callint.c (syms_of_callint):
2424 * casefiddle.c (syms_of_casefiddle):
2425 * casetab.c (init_casetab_once):
2426 * category.c (init_category_once, syms_of_category):
2427 * ccl.c (syms_of_ccl):
2428 * cmds.c (syms_of_cmds):
2429 * composite.c (syms_of_composite):
2430 * dbusbind.c (syms_of_dbusbind):
2431 * dired.c (syms_of_dired):
2432 * dispnew.c (syms_of_display):
2433 * doc.c (syms_of_doc):
2434 * editfns.c (syms_of_editfns):
2435 * emacs.c (syms_of_emacs):
2436 * eval.c (syms_of_eval):
2437 * fileio.c (syms_of_fileio):
2438 * fns.c (syms_of_fns):
2439 * frame.c (syms_of_frame):
2440 * fringe.c (syms_of_fringe):
2441 * insdel.c (syms_of_insdel):
2442 * keymap.c (syms_of_keymap):
2443 * lread.c (init_obarray, syms_of_lread):
2444 * macros.c (syms_of_macros):
2445 * msdos.c (syms_of_msdos):
2446 * print.c (syms_of_print):
2447 * process.c (syms_of_process):
2448 * search.c (syms_of_search):
2449 * sound.c (syms_of_sound):
2450 * syntax.c (init_syntax_once, syms_of_syntax):
2451 * terminal.c (syms_of_terminal):
2452 * textprop.c (syms_of_textprop):
2453 * undo.c (syms_of_undo):
2454 * w32.c (globals_of_w32):
2455 * window.c (syms_of_window):
2456 * xdisp.c (syms_of_xdisp):
2457 * xfaces.c (syms_of_xfaces):
2458 * xfns.c (syms_of_xfns):
2459 * xmenu.c (syms_of_xmenu):
2460 * xsettings.c (syms_of_xsettings):
2461 * xterm.c (syms_of_xterm): Use DEFSYM.
2463 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2465 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2467 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2469 Integer and buffer overflow fixes (Bug#8873).
2471 * print.c (printchar, strout): Check for string overflow.
2472 (PRINTPREPARE, printchar, strout):
2473 Don't set size unless allocation succeeds.
2475 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2476 for sizes. Check for string overflow more accurately.
2477 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2479 * macros.c: Integer and buffer overflow fixes.
2480 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2481 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2482 Use ptrdiff_t, not int, for sizes.
2483 Don't increment bufsize until after realloc succeeds.
2484 Check for size-calculation overflow.
2485 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2487 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2489 * lread.c: Integer overflow fixes.
2490 (read_integer): Radix is now EMACS_INT, not int,
2491 to improve quality of diagnostics for out-of-range radices.
2492 Calculate buffer size correctly for out-of-range radices.
2493 (read1): Check for integer overflow in radices, and in
2494 read-circle numbers.
2495 (read_escape): Avoid int overflow.
2496 (Fload, openp, read_buffer_size, read1)
2497 (substitute_object_recurse, read_vector, read_list, map_obarray):
2498 Use ptrdiff_t, not int, for sizes.
2499 (read1): Use EMACS_INT, not int, for sizes.
2500 Check for size overflow.
2502 * image.c (cache_image): Check for size arithmetic overflow.
2504 * lread.c: Integer overflow issues.
2505 (saved_doc_string_size, saved_doc_string_length)
2506 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2507 Now ptrdiff_t, not int.
2508 (read1): Don't assume doc string length fits in int. Check for
2509 out-of-range doc string lengths.
2510 (read_list): Don't assume file position fits in int.
2511 (read_escape): Check for hex character overflow.
2513 2011-06-22 Leo Liu <sdl.web@gmail.com>
2515 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2516 Move to minibuffer.el.
2518 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2520 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2521 The following patches are for when GLYPH_DEBUG && !XASSERT.
2522 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2523 * dispnew.c (flush_stdout):
2524 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2525 Mark as externally visible.
2526 * dispnew.c (check_window_matrix_pointers): Now static.
2527 * dispnew.c (window_to_frame_vpos):
2528 * xfns.c (unwind_create_frame):
2529 * xterm.c (x_check_font): Remove unused local.
2530 * scroll.c (CHECK_BOUNDS):
2531 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2532 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2533 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2534 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2535 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2537 (debug_method_add): Use va_list and vsprintf rather than relying
2538 on undefined behavior with wrong number of arguments.
2539 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2540 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2541 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2542 since we're not interested in debugging glyphs with old libraries.
2543 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2544 GCC 4.6.0's static checking.
2546 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2548 Integer overflow and signedness fixes (Bug#8873).
2549 A few related buffer overrun fixes, too.
2551 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2553 * dispextern.h (struct face.stipple):
2554 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2555 (x_bitmap_mask, x_allocate_bitmap_record)
2556 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2557 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2558 (x_create_bitmap_from_xpm_data):
2559 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2560 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2562 * xfaces.c (load_pixmap):
2563 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2564 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2565 (.bitmaps_last, struct x_output.icon_bitmap):
2566 Use ptrdiff_t, not int, for bitmap indexes.
2567 (x_allocate_bitmap_record): Check for size overflow.
2568 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2570 Use ptrdiff_t, not int, for overlay counts.
2571 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2572 * editfns.c (overlays_around, get_pos_property):
2573 * textprop.c (get_char_property_and_overlay):
2574 * xdisp.c (next_overlay_change, note_mouse_highlight):
2575 * xfaces.c (face_at_buffer_position):
2576 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2577 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2578 (Fnext_overlay_change, Fprevious_overlay_change)
2579 (mouse_face_overlay_overlaps, Foverlays_in):
2580 Use ptrdiff_t, not int, for sizes.
2581 (overlays_at, overlays_in): Check for size-calculation overflow.
2583 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2585 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2586 (x_session_initialize): Do not assume string length fits in int.
2588 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2589 This is unlikely, but can occur if DPI is outlandish.
2591 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2592 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2594 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2595 * xrdb.c (magic_file_p, search_magic_path):
2596 Omit last arg SUFFIX; it was always 0. All callers changed.
2597 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2599 * xfont.c (xfont_match): Avoid need for strlen.
2601 * xfns.c: Don't assume strlen fits in int.
2602 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2604 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2605 not unsigned long, as we prefer signed integers. All callers changed.
2606 Detect integer overflow in repeat count.
2607 (message_dolog): Don't assume print length fits in 39 bytes.
2608 (display_mode_element): Don't assume strlen fits in int.
2610 * termcap.c: Don't assume sizes fit in int and never overflow.
2611 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2612 (gobble_line): Check for size-calculation overflow.
2614 * minibuf.c (Fread_buffer):
2615 * lread.c (intern, intern_c_string):
2616 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2617 Don't assume string length fits in int.
2619 * keyboard.c (parse_tool_bar_item):
2620 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2622 * font.c: Don't assume string length fits in int.
2623 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2624 Use ptrdiff_t, not int.
2625 (font_intern_prop): Don't assume string length fits in int.
2626 Don't assume integer property fits in fixnum.
2627 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2629 * filelock.c: Fix some buffer overrun and integer overflow issues.
2630 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2631 Reformulate so as not to need the command string.
2632 Invoke gzip -cd rather than gunzip, as it's more portable.
2633 (lock_info_type, lock_file_1, lock_file):
2634 Don't assume pid_t and time_t fit in unsigned long.
2635 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2636 (current_lock_owner): Prefer signed type for sizes.
2637 Use memcpy, not strncpy, where memcpy is what is really wanted.
2638 Don't assume (via atoi) that time_t and pid_t fit in int.
2639 Check for time_t and/or pid_t out of range, e.g., via a network share.
2640 Don't alloca where an auto var works fine.
2642 * fileio.c: Fix some integer overflow issues.
2643 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2644 Don't assume string length fits in int.
2645 (directory_file_name): Don't assume string length fits in long.
2646 (make_temp_name): Don't assume pid fits in int, or that its print
2647 length is less than 20.
2649 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2651 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2653 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2655 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2656 We prefer signed integers, even for size calculations.
2658 * emacs.c: Don't assume string length fits in 'int'.
2659 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2660 (main): Don't invoke strlen when not needed.
2662 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2663 (XD_DEBUG_MESSAGE): Don't waste a byte.
2665 * callproc.c (getenv_internal_1, getenv_internal)
2667 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2669 * lread.c (invalid_syntax): Omit length argument.
2670 All uses changed. This doesn't fix a bug, but it simplifies the
2671 code away from its former Hollerith-constant appearance, and it's
2672 one less 'int' to worry about when looking at integer-overflow issues.
2673 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2675 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2676 This didn't break anything, but it didn't help either.
2677 It's confusing to put a bogus integer in a place where the actual
2678 value does not matter.
2679 (LIST_END_P): Remove unused macro and its bogus comment.
2680 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2682 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2683 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2685 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2686 We prefer signed types, and the value cannot exceed the EMACS_INT
2687 range anyway (because otherwise the length would not be representable).
2688 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2689 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2690 This avoids a GCC warning when WIDE_EMACS_INT.
2692 * indent.c (sane_tab_width): New function.
2693 (current_column, scan_for_column, Findent_to, position_indentation)
2694 (compute_motion): Use it. This is just for clarity.
2695 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2697 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2699 * lisp.h (lint_assume): New macro.
2700 * composite.c (composition_gstring_put_cache):
2701 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2703 * editfns.c, insdel.c:
2704 Omit unnecessary forward decls, to simplify future changes.
2706 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2708 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2710 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2711 Use much-faster test for byte-length change.
2712 Don't assume string byte-length fits in 'int'.
2713 Check that character arg fits in 'int'.
2714 (mapcar1): Declare byte as byte, for clarity.
2716 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2718 * fns.c (concat): Catch string overflow earlier.
2719 Do not rely on integer wraparound.
2721 * dispextern.h (struct it.overlay_strings_charpos)
2722 (struct it.selective): Now EMACS_INT, not int.
2723 * xdisp.c (forward_to_next_line_start)
2724 (back_to_previous_visible_line_start)
2725 (reseat_at_next_visible_line_start, next_element_from_buffer):
2726 Don't arbitrarily truncate the value of 'selective' to int.
2728 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2730 * composite.c: Don't truncate sizes to 'int'.
2731 (composition_gstring_p, composition_reseat_it)
2732 (composition_adjust_point): Use EMACS_INT, not int.
2733 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2734 not EMACS_UINT, for indexes.
2736 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2738 * buffer.c: Include <verify.h>.
2739 (struct sortvec.priority, struct sortstr.priority):
2740 Now EMACS_INT, not int.
2741 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2742 (struct sortstr.size, record_overlay_string)
2743 (struct sortstrlist.size, struct sortlist.used):
2744 Don't truncate size to int.
2745 (record_overlay_string): Check for size-calculation overflow.
2746 (init_buffer_once): Check at compile-time, not run-time.
2748 2011-06-22 Jim Meyering <meyering@redhat.com>
2750 Don't leak an XBM-image-sized buffer
2751 * image.c (xbm_load): Free the image buffer after using it.
2753 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2756 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2757 that Sun C diagnosed.
2758 * fns.c (secure_hash): Fix pointer signedness issue.
2759 * intervals.c (static_offset_intervals): New function.
2760 (offset_intervals): Use it.
2762 2011-06-21 Leo Liu <sdl.web@gmail.com>
2765 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2768 * fns.c (secure_hash): Rename from crypto_hash_function and change
2769 the first arg to accept symbols.
2770 (Fsecure_hash): New primitive.
2771 (syms_of_fns): New symbols.
2773 2011-06-20 Deniz Dogan <deniz@dogan.se>
2775 * process.c (Fset_process_buffer): Clarify return value in
2778 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2780 * dispnew.c (add_window_display_history): Use BVAR.
2782 * xdisp.c (debug_method_add): Use BVAR.
2783 (check_window_end, dump_glyph_matrix, dump_glyph)
2784 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2786 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2789 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2790 check till after the cache is created in init_frame_faces.
2792 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2794 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2796 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2798 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2799 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2800 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2802 Improve buffer-overflow checking (Bug#8873).
2803 * fileio.c (Finsert_file_contents):
2804 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2805 Remove the old (too-loose) buffer overflow checks.
2806 They weren't needed, since make_gap checks for buffer overflow.
2807 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2808 The old code merely checked for Emacs fixnum overflow, and relied
2809 on undefined (wraparound) behavior. The new code avoids undefined
2810 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2812 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2813 Tune. Don't use wider integers than needed. Don't use alloca.
2814 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2816 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2818 * insdel.c, lisp.h (buffer_overflow): New function.
2819 (insert_from_buffer_1, replace_range, replace_range_2):
2820 * insdel.c (make_gap_larger):
2821 * editfns.c (Finsert_char):
2822 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2824 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2826 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2828 Integer overflow and signedness fixes (Bug#8873).
2830 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2831 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2833 * fileio.c: Don't assume EMACS_INT fits in off_t.
2834 (emacs_lseek): New static function.
2835 (Finsert_file_contents, Fwrite_region): Use it.
2836 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2838 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2840 * fns.c: Don't overflow int when computing a list length.
2841 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2842 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2843 truncation on 64-bit hosts. Check for QUIT every
2844 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2845 faster and is responsive enough.
2846 (Flength): Report an error instead of overflowing an integer.
2847 (Fsafe_length): Return a float if the value is not representable
2848 as a fixnum. This shouldn't happen except in contrived situations.
2849 (Fnthcdr, Fsort): Don't assume list length fits in int.
2850 (Fcopy_sequence): Don't assume vector length fits in int.
2852 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2853 (header_size, word_size): New constants.
2854 (allocate_vectorlike): Don't check size overflow here.
2855 (allocate_vector): Check it here instead, since this is the only
2856 caller of allocate_vectorlike that could cause overflow.
2857 Check that the new vector's length is representable as a fixnum.
2859 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2860 The previous code was bogus. For example, next_almost_prime (32)
2861 returned 39, which is undesirable as it is a multiple of 3; and
2862 next_almost_prime (24) returned 25, which is a multiple of 5 so
2863 why was the code bothering to check for multiples of 7?
2865 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2867 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2869 Variadic C functions now count arguments with ptrdiff_t.
2870 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2871 Back then I didn't know that the Emacs coding style prefers signed int.
2872 Also, in the meantime I found a few more instances where arguments
2873 were being counted with int, which may truncate counts on 64-bit
2874 machines, or EMACS_INT, which may be unnecessarily wide.
2875 * lisp.h (struct Lisp_Subr.function.aMANY)
2876 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2877 Arg counts are now ptrdiff_t, not size_t.
2878 All variadic functions and their callers changed accordingly.
2879 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2880 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2881 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2882 * callint.c (Fcall_interactively): Check arg count for overflow,
2883 to avoid potential buffer overrun. Use signed char, not 'int',
2884 for 'varies' array, so that we needn't bother to check its size
2885 calculation for overflow.
2886 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2887 * eval.c (apply_lambda):
2888 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2889 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2890 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2892 * callint.c (Fcall_interactively): Don't use index var as event count.
2894 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2895 * mem-limits.h (SIZE): Remove; no longer used.
2897 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2899 Remove unnecessary casts.
2900 * xterm.c (x_term_init):
2901 * xfns.c (x_set_border_pixel):
2902 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2903 These aren't needed now that we assume ANSI C.
2905 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2906 It's more likely to cause problems (due to unsigned overflow)
2909 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2911 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2913 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2915 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2917 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2919 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2921 GLYPH_CODE_FACE returns EMACS_INT, not int.
2922 * dispextern.h (merge_faces):
2923 * xfaces.c (merge_faces):
2924 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2925 Don't assume EMACS_INT fits in int.
2927 * character.h (CHAR_VALID_P): Remove unused parameter.
2928 * fontset.c, lisp.h, xdisp.c: All uses changed.
2930 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2932 * fns.c (concat): Minor tuning based on overflow analysis.
2933 This doesn't fix any bugs. Use int to hold character, instead
2934 of constantly refetching from Emacs object. Use XFASTINT, not
2935 XINT, for value known to be a character. Don't bother comparing
2936 a single byte to 0400, as it's always less.
2938 * floatfns.c (Fexpt):
2939 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2941 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2944 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2946 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2947 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2948 incorrectly succeed when S was a string, because 4294967386 was
2949 truncated before it was used.
2951 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2952 Otherwise, an out-of-range integer could cause undefined behavior
2955 * composite.c: Use int, not EMACS_INT, for characters.
2956 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2957 EMACS_INT, for values that are known to be in character range.
2958 This doesn't fix any bugs but is the usual style inside Emacs and
2959 may generate better code on 32-bit machines.
2961 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2962 This is for reasons similar to the recent CHAR_STRING fix.
2963 * charset.c (Fencode_char): Check that character arg is actually
2964 a character. Pass an int to ENCODE_CHAR.
2965 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2966 wider than 'int', as a compile-time check to prevent future regressions
2969 * character.c (char_string): Remove unnecessary casts.
2971 Make sure a 64-bit char is never passed to CHAR_STRING.
2972 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2973 by silently ignoring the top 32 bits, allowing some values
2974 that were far too large to be valid characters.
2975 * character.h: Include <verify.h>.
2976 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2977 arguments are no wider than unsigned, as a compile-time check
2978 to prevent future regressions in this area.
2980 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2981 (Fsubst_char_in_region):
2983 * xdisp.c (decode_mode_spec_coding):
2984 Adjust to CHAR_STRING's new requirement.
2985 * editfns.c (Finsert_char, Fsubst_char_in_region):
2986 * fns.c (concat): Check that character args are actually
2987 characters. Without this test, these functions did the wrong
2988 thing with wildly out-of-range values on 64-bit hosts.
2990 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2991 These casts should not be needed on 32-bit hosts, either.
2992 * keyboard.c (read_char):
2993 * lread.c (Fload): Remove casts to unsigned.
2995 * lisp.h (UNSIGNED_CMP): New macro.
2996 This fixes comparison bugs on 64-bit hosts.
2997 (ASCII_CHAR_P): Use it.
2998 * casefiddle.c (casify_object):
2999 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3000 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3001 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3002 * dispextern.h (FACE_FROM_ID):
3003 * keyboard.c (read_char): Use UNSIGNED_CMP.
3005 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3006 not to EMACS_INT, to avoid GCC warning.
3008 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3010 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3011 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3012 isn't needed on 32-bit machines.
3014 * buffer.c (Fgenerate_new_buffer_name):
3015 Use EMACS_INT for count, not int.
3016 (advance_to_char_boundary): Return EMACS_INT, not int.
3018 * data.c (Qcompiled_function): Now static.
3020 * window.c (window_body_lines): Now static.
3022 * image.c (gif_load): Rename local to avoid shadowing.
3024 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3025 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3026 * alloc.c (make_save_value): Integer argument is now of type
3028 (mark_object): Use ptrdiff_t, not int.
3029 * lisp.h (pD): New macro.
3030 * print.c (print_object): Use it.
3032 * alloc.c: Use EMACS_INT, not int, to count objects.
3033 (total_conses, total_markers, total_symbols, total_vector_size)
3034 (total_free_conses, total_free_markers, total_free_symbols)
3035 (total_free_floats, total_floats, total_free_intervals)
3036 (total_intervals, total_strings, total_free_strings):
3037 Now EMACS_INT, not int. All uses changed.
3038 (Fgarbage_collect): Compute overall total using a double, so that
3039 integer overflow is less likely to be a problem. Check for overflow
3040 when converting back to an integer.
3041 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3042 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3043 These were 'int' variables that could overflow on 64-bit hosts;
3044 they were never used, so remove them instead of repairing them.
3045 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3046 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3047 Previously, this ceilinged at INT_MAX, but that doesn't work on
3049 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3051 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3052 (allocate_vectorlike): Check for ptrdiff_t overflow.
3053 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3054 when a (possibly-narrower) signed value would do just as well.
3055 We prefer using signed arithmetic, to avoid comparison confusion.
3057 * alloc.c: Catch some string size overflows that we were missing.
3058 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3059 for convenience in STRING_BYTES_MAX.
3060 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3061 The definition here is exact; the one in lisp.h was approximate.
3062 (allocate_string_data): Check for string overflow. This catches
3063 some instances we weren't catching before. Also, it catches
3064 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3065 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3066 and ptrdiff_t and EMACS_INT are both 64 bits.
3068 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3069 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3070 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3072 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3074 * alloc.c (Fmake_string): Check for out-of-range init.
3076 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3078 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3080 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3082 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3083 xg_get_default_scrollbar_width.
3085 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3086 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3087 (style_changed_cb): Call update_theme_scrollbar_width and call
3088 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3089 all frames (Bug#8505).
3090 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3091 Call gtk_window_set_resizable if HAVE_GTK3.
3092 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3093 and height if HAVE_GTK3 (Bug#8505).
3094 (scroll_bar_width_for_theme): New variable.
3095 (update_theme_scrollbar_width): New function.
3096 (xg_get_default_scrollbar_width): Move code to
3097 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3098 (xg_initialize): Call update_theme_scrollbar_width.
3100 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3102 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3104 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3106 * frame.c (make_frame): Call other_buffer_safely instead of
3109 * window.c (temp_output_buffer_show): Call display_buffer with
3110 second argument Vtemp_buffer_show_specifiers and reset latter
3111 immediately after the call.
3112 (Vtemp_buffer_show_specifiers): New variable.
3113 (auto_window_vscroll_p, next_screen_context_lines)
3114 (Vscroll_preserve_screen_position): Remove leading asterisks from
3117 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3119 Fix minor problems found by GCC 4.6.0 static checking.
3120 * buffer.c (Qclone_number): Remove for now, as it's unused.
3121 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3122 (record_buffer): Remove unused local.
3123 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3124 (set_frame_buffer_list): Remove; unused.
3125 * frame.h (other_visible_frames): Remove decl.
3126 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3127 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3128 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3130 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3131 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3132 Define only if HAVE_GPM.
3133 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3134 (update_hints_inhibit): Remove; never set. All uses removed.
3135 * widgetprv.h (emacsFrameClassRec): Remove decl.
3136 * window.c (delete_deletable_window): Now returns void, since it
3137 wasn't returning anything.
3138 (compare_window_configurations): Remove unused locals.
3139 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3140 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3141 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3142 the same widths as pointers. This follows up on the 2011-05-06 patch.
3143 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3144 * xterm.h: Likewise.
3145 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3147 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3149 * makefile.w32-in: Update dependencies.
3150 (LISP_H): Add lib/intprops.h.
3152 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3154 * image.c (gif_load): Add animation frame delay to the metadata.
3155 (syms_of_image): Use DEFSYM. New symbol `delay'.
3157 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3159 * window.c (delete_deletable_window): Re-add.
3160 (Fset_window_configuration): Rewrite to handle dead buffers and
3161 consequently deletable windows.
3162 (window_tree, Fwindow_tree): Remove. Supply functionality in
3164 (compare_window_configurations): Simplify code.
3166 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3168 * image.c (imagemagick_load_image): Fix type mismatch.
3169 (Fimagemagick_types): Likewise.
3171 * window.h (replace_buffer_in_windows): Declare.
3173 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3175 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3176 Qclone_number. Remove external declaration of Qdelete_window.
3177 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3179 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3180 Run Qbuffer_list_update_hook if allowed.
3181 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3182 buffer list implementation.
3183 (other_buffer_safely): New function.
3184 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3185 calls to replace_buffer_in_windows and
3186 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3188 (record_buffer): Inhibit quitting and rewrite using quittable
3189 functions. Run Qbuffer_list_update_hook if allowed.
3190 (Frecord_buffer, Funrecord_buffer): New functions.
3191 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3192 Move switch-to-buffer to window.el.
3193 (bury-buffer): Move to window.el.
3194 (Vbuffer_list_update_hook): New variable.
3196 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3199 * window.h (resize_frame_windows): Move up in code.
3200 (Fwindow_frame): Remove EXFUN.
3201 (replace_buffer_in_all_windows): Remove prototype.
3202 (replace_buffer_in_windows_safely): Add prototype.
3204 * window.c: Declare Qdelete_window static again. Move down
3205 declaration of select_count.
3206 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3207 (Fother_window): Move to window.el.
3208 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3209 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3210 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3212 (replace_buffer_in_windows): Implement by calling
3213 Qreplace_buffer_in_windows.
3214 (replace_buffer_in_all_windows): Remove with some functionality
3215 moved into replace_buffer_in_windows_safely.
3216 (replace_buffer_in_windows_safely): New function.
3217 (select_window_norecord, select_frame_norecord): Move in front
3218 of run_window_configuration_change_hook. Remove now obsolete
3220 (Fset_window_buffer): Rewrite doc-string.
3221 Call Qrecord_window_buffer.
3222 (keys_of_window): Move binding for other-window to window.el.
3224 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3226 * dispextern.h (struct image): Replace data member, whose int_val
3227 and ptr_val fields were not used by anything, with a single
3230 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3231 (gif_clear_image, gif_load, imagemagick_load_image)
3232 (gs_clear_image, gs_load): Callers changed.
3234 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3236 * buffer.h: Include <time.h>, for time_t.
3237 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3239 Fix minor problems found by static checking.
3241 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3243 Make identifiers static if they are not used in other modules.
3244 * data.c (Qcompiled_function, Qframe, Qvector):
3245 * image.c (QimageMagick, Qsvg):
3246 * minibuf.c (Qmetadata):
3247 * window.c (resize_window_check, resize_root_window): Now static.
3248 * window.h (resize_window_check, resize_root_window): Remove decls.
3250 * window.c (window_deletion_count, delete_deletable_window):
3252 (window_body_lines): Now static.
3253 (Fdelete_other_windows_internal): Mark vars as initialized.
3254 Make sure 'resize_failed' is initialized.
3255 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3256 (resize_window_apply): Remove unused local.
3257 * window.h (delete_deletable_window): Remove decl.
3259 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3260 (imagemagick_load_image): Fix pointer signedness problem by changing
3261 last arg from unsigned char * to char *. All uses changed.
3262 Also, fix a local for similar reasons.
3263 Remove unused locals. Remove locals to avoid shadowing.
3264 (fn_rsvg_handle_free): Remove; unused.
3265 (svg_load, svg_load_image): Fix pointer signedness problem.
3266 (imagemagick_load_image): Don't use garbage pointer image_wand.
3268 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3270 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3272 * image.c (gif_load): Fix omitted cast error introduced by
3275 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3277 * window.h (resize_proportionally, orig_total_lines)
3278 (orig_top_line): Remove from window structure.
3279 (set_window_height, set_window_width, change_window_heights)
3280 (Fdelete_window): Remove prototypes.
3281 (resize_frame_windows): Remove duplicate declaration.
3283 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3285 * window.h (resize_frame_windows, resize_window_check)
3286 (delete_deletable_window, resize_root_window)
3287 (resize_frame_windows): Declare prototypes.
3289 * window.c (resize_window_apply): Make definition be "static" to
3290 match the prototype.
3292 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3294 * window.c: Remove declarations of Qwindow_size_fixed,
3295 window_min_size_1, window_min_size_2, window_min_size,
3296 size_window, window_fixed_size_p, enlarge_window, delete_window.
3297 Remove static from declaration of Qdelete_window, it's
3298 temporarily needed by Fbury_buffer.
3299 (replace_window): Don't assign orig_top_line and
3301 (Fdelete_window, delete_window): Remove. Window deletion is
3302 handled by window.el.
3303 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3304 Replace Fdelete_window calls with calls to Qdelete_window.
3305 (Fdelete_other_windows): Remove. Deleting other windows is
3306 handled by window.el.
3307 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3308 handled in window.el.
3309 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3310 Window minimum sizes are handled in window.el.
3311 (shrink_windows, size_window, set_window_height)
3312 (set_window_width, change_window_heights, window_height)
3313 (window_width, CURBEG, CURSIZE, enlarge_window)
3314 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3315 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3316 handled in window.el.
3317 (make_dummy_parent): Rename to make_parent_window and give it a
3318 second argument horflag.
3319 (make_window): Don't set resize_proportionally any more.
3320 (Fsplit_window): Remove. Windows are split in window.el.
3321 (save_restore_action, save_restore_orig_size)
3322 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3323 Resize mini windows in window.el.
3324 (grow_mini_window, shrink_mini_window): Implement by calling
3325 Qresize_root_window_vertically, resize_window_check and
3326 resize_window_apply.
3327 (saved_window, Fset_window_configuration, save_window_save):
3328 Do not handle orig_top_line, orig_total_lines, and
3329 resize_proportionally.
3330 (window_min_height, window_min_width): Move to window.el.
3331 (keys_of_window): Move bindings for delete-other-windows,
3332 split-window, delete-window and enlarge-window to window.el.
3334 * buffer.c: Temporarily extern Qdelete_window.
3335 (Fbury_buffer): Temporarily call Qdelete_window instead of
3336 Fdelete_window (Fbury_buffer will move to window.el soon).
3338 * frame.c (set_menu_bar_lines_1): Remove code handling
3339 orig_top_line and orig_total_lines.
3341 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3342 set_window_height but set heights directly.
3343 (change_frame_size_1): Use resize_frame_windows.
3345 * xdisp.c (init_xdisp): Don't use set_window_height but set
3348 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3349 Use resize_frame_windows instead of change_window_heights and run
3350 run_window_configuration_change_hook.
3352 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3353 instead of change_window_heights and run
3354 run_window_configuration_change_hook.
3356 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3358 * window.c (replace_window): Rename second argument REPLACEMENT to
3359 NEW. New third argument SETFLAG. Rewrite.
3360 (delete_window, make_dummy_parent): Call replace_window with
3362 (window_list_1): Move down in code.
3363 (run_window_configuration_change_hook): Move set_buffer part
3364 before select_frame_norecord part in order to unwind correctly.
3365 Rename count1 to count.
3366 (recombine_windows, delete_deletable_window, resize_root_window)
3367 (Fdelete_other_windows_internal)
3368 (Frun_window_configuration_change_hook, make_parent_window)
3369 (resize_window_check, resize_window_apply, Fresize_window_apply)
3370 (resize_frame_windows, Fsplit_window_internal)
3371 (Fdelete_window_internal, Fresize_mini_window_internal):
3373 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3375 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3377 * window.h (window): Add some new members to window structure -
3378 normal_lines, normal_cols, new_total, new_normal, clone_number,
3379 splits, nest, prev_buffers, next_buffers.
3380 (WINDOW_TOTAL_SIZE): Move here from window.c.
3381 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3383 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3385 (make_dummy_parent): Set new members of windows structure.
3386 (make_window): Move down in code. Handle new members of window
3388 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3389 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3390 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3391 (Fset_window_prev_buffers, Fwindow_next_buffers)
3392 (Fset_window_next_buffers, Fset_window_clone_number):
3394 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3395 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3397 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3398 Argument WINDOW can be now internal window too.
3399 (Fwindow_use_time): Move up in code.
3400 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3402 (Fset_window_configuration, saved_window)
3403 (Fcurrent_window_configuration, save_window_save): Handle new
3404 members of window structure.
3405 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3406 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3407 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3408 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3409 Qget_mru_window, Qresize_root_window,
3410 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3411 Qauto_buffer_name; staticpro them.
3413 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3415 * window.c (Fwindow_total_size, Fwindow_left_column)
3416 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3417 (Fwindow_list_1): New functions.
3418 (window_box_text_cols): Replace with window_body_cols.
3419 (Fwindow_width, Fscroll_left, Fscroll_right):
3420 Use window_body_cols instead of window_box_text_cols.
3421 (delete_window, Fset_window_configuration):
3422 Call delete_all_subwindows with window as argument.
3423 (delete_all_subwindows): Take a window as argument and not a
3425 (window_loop): Remove handling of GET_LRU_WINDOW and
3427 (Fget_lru_window, Fget_largest_window): Move to window.el.
3429 * window.h: Extern window_body_cols instead of
3430 window_box_text_cols. delete_all_subwindows now takes a
3431 Lisp_Object as argument.
3433 * indent.c (compute_motion, Fcompute_motion):
3434 Use window_body_cols instead of window_box_text_cols.
3436 * frame.c (delete_frame): Call delete_all_subwindows with root
3439 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3441 * fns.c (Fputhash): Document return value.
3443 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3445 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3447 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3449 Cons<->int and similar integer overflow fixes (Bug#8794).
3451 Check for overflow when converting integer to cons and back.
3452 * charset.c (Fdefine_charset_internal, Fdecode_char):
3453 Use cons_to_unsigned to catch overflow.
3454 (Fencode_char): Use INTEGER_TO_CONS.
3455 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3456 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3457 * data.c (long_to_cons, cons_to_long): Remove.
3458 (cons_to_unsigned, cons_to_signed): New functions.
3459 These signal an error for invalid or out-of-range values.
3460 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3461 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3462 * font.c (Ffont_variation_glyphs):
3463 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3464 * lisp.h: Include <intprops.h>.
3465 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3466 (cons_to_signed, cons_to_unsigned): New decls.
3467 (long_to_cons, cons_to_long): Remove decls.
3468 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3469 (Fprimitive_undo): Use CONS_TO_INTEGER.
3470 * xfns.c (Fx_window_property): Likewise.
3471 * xselect.c: Include <limits.h>.
3472 (x_own_selection, selection_data_to_lisp_data):
3473 Use INTEGER_TO_CONS.
3474 (x_handle_selection_request, x_handle_selection_clear)
3475 (x_get_foreign_selection, Fx_disown_selection_internal)
3476 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3477 (lisp_data_to_selection_data): Use cons_to_unsigned.
3478 (x_fill_property_data): Use cons_to_signed.
3479 Report values out of range.
3481 Check for buffer and string overflow more precisely.
3482 * buffer.h (BUF_BYTES_MAX): New macro.
3483 * lisp.h (STRING_BYTES_MAX): New macro.
3484 * alloc.c (Fmake_string):
3485 * character.c (string_escape_byte8):
3486 * coding.c (coding_alloc_by_realloc):
3487 * doprnt.c (doprnt):
3488 * editfns.c (Fformat):
3490 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3491 since they may not be the same number.
3492 * editfns.c (Finsert_char):
3493 * fileio.c (Finsert_file_contents):
3494 Likewise for BUF_BYTES_MAX.
3496 * image.c: Use ptrdiff_t, not int, for sizes.
3497 (slurp_file): Switch from int to ptrdiff_t.
3499 (slurp_file): Check that file size fits in both size_t (for
3500 malloc) and ptrdiff_t (for sanity and safety).
3502 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3503 if b->modtime has its maximal value.
3505 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3507 Don't assume time_t can fit into int.
3508 * buffer.h (struct buffer.modtime): Now time_t, not int.
3509 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3510 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3512 Minor fixes for signed vs unsigned integers.
3513 * character.h (MAYBE_UNIFY_CHAR):
3514 * charset.c (maybe_unify_char):
3515 * keyboard.c (read_char, reorder_modifiers):
3516 XINT -> XFASTINT, since the integer must be nonnegative.
3517 * ftfont.c (ftfont_spec_pattern):
3518 * keymap.c (access_keymap, silly_event_symbol_error):
3519 XUINT -> XFASTINT, since the integer must be nonnegative.
3520 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3521 since it makes no difference and we prefer signed.
3522 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3523 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3526 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3528 * window.h (Fwindow_frame): Declare.
3530 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3532 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3533 (SPARE_MEMORY): Always define.
3534 (LARGE_REQUEST): Remove.
3535 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3537 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3539 * lisp.h: Move EXFUNS for Fframe_root_window,
3540 Fframe_first_window and Fset_frame_selected_window to window.h.
3542 * window.h: Move EXFUNS for Fframe_root_window,
3543 Fframe_first_window and Fset_frame_selected_window here from
3546 * frame.c (Fwindow_frame, Fframe_first_window)
3547 (Fframe_root_window, Fframe_selected_window)
3548 (Fset_frame_selected_window): Move to window.c.
3549 (Factive_minibuffer_window): Move to minibuf.c.
3550 (Fother_visible_frames_p): New function.
3552 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3554 * window.c (decode_window, decode_any_window): Move up in code.
3555 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3556 (inhibit_frame_unsplittable): Remove unused variable.
3557 (Fwindow_buffer): Move up and rewrite doc-string.
3558 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3559 (Fwindow_prev): New functions.
3560 (Fwindow_frame): Move here from frame.c. Accept any window as
3562 (Fframe_root_window, Fframe_first_window)
3563 (Fframe_selected_window): Move here from frame.c. Accept frame
3564 or arbitrary window as argument. Update doc-strings.
3565 (Fminibuffer_window): Move up in code.
3566 (Fwindow_minibuffer_p): Move up in code and simplify.
3567 (Fset_frame_selected_window): Move here from frame.c.
3569 (Fselected_window, select_window, Fselect_window): Move up in
3570 code. Minor doc-string fixes.
3572 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3574 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3575 Do not assume that spare memory exists; that assumption is valid
3576 only if SYSTEM_MALLOC.
3577 (LARGE_REQUEST): New macro, so that the issue of large requests
3578 is separated from the issue of spare memory.
3580 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3582 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3585 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3587 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3590 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3592 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3594 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3596 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3597 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3599 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3601 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3603 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3605 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3606 (x_clipboard_manager_save): Add return value.
3607 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3609 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3610 Obey Vx_select_enable_clipboard_manager. Catch errors in
3611 x_clipboard_manager_save (Bug#8779).
3612 (Vx_select_enable_clipboard_manager): New variable.
3613 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3615 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3617 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3619 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3621 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3622 in the current matrix if keep_current_p is non-zero.
3624 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3626 * bidi.c (bidi_level_of_next_char): Fix last change.
3628 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3630 Support bidi reordering of text covered by display properties.
3632 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3633 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3634 (bidi_cache_search, bidi_cache_iterator_state)
3635 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3636 (bidi_level_of_next_char, bidi_move_to_visually_next):
3637 Support character positions inside a run of characters covered by a
3639 (bidi_paragraph_init, bidi_resolve_explicit_1)
3640 (bidi_level_of_next_char): Call bidi_fetch_char and
3641 bidi_fetch_char_advance instead of FETCH_CHAR and
3643 (bidi_init_it): Initialize new members.
3644 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3646 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3647 instead of using explicit *_CHAR codes.
3648 (bidi_resolve_explicit, bidi_resolve_weak):
3649 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3650 bidirectional text is supported only in multibyte buffers.
3651 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3652 it to initialize the frame_window_p member of struct bidi_it.
3653 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3654 (bidi_resolve_explicit, bidi_resolve_weak)
3655 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3656 bidi_it->nchars is non-positive.
3657 (bidi_level_of_next_char): Don't try to lookup the cache for the
3658 next/previous character if nothing is cached there yet, or if we
3659 were just reseat()'ed to a new position.
3661 * xdisp.c (set_cursor_from_row): Set start and stop points
3662 according to the row's direction when priming the loop that looks
3663 for the glyph on which to display cursor.
3664 (single_display_spec_intangible_p): Function deleted.
3665 (display_prop_intangible_p): Reimplement to call
3666 handle_display_spec instead of single_display_spec_intangible_p.
3667 Accept 3 additional arguments needed by handle_display_spec.
3668 This fixes incorrect cursor motion across display property with complex
3669 values: lists, `(when COND...)' forms, etc.
3670 (single_display_spec_string_p): Support property values that are
3671 lists with the argument STRING its top-level element.
3672 (display_prop_string_p): Fix the condition for processing a
3673 property that is a list to be consistent with handle_display_spec.
3674 (handle_display_spec): New function, refactored from the
3675 last portion of handle_display_prop.
3676 (compute_display_string_pos): Accept additional argument
3677 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3678 value of a `display' property is a "replacing spec".
3679 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3680 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3681 the display property, but just return a value indicating whether
3682 the display property will replace the characters it covers.
3683 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3684 frame_window_p members of struct bidi_it.
3685 (compute_display_string_pos, compute_display_string_end):
3687 (push_it): Accept second argument POSITION, where pop_it should
3688 jump to continue iteration.
3689 (reseat_1): Initialize bidi_it.disp_pos.
3691 * keyboard.c (adjust_point_for_property): Adjust the call to
3692 display_prop_intangible_p to its new signature.
3694 * dispextern.h (struct bidi_it): New member frame_window_p.
3695 (bidi_init_it): Update prototypes.
3696 (display_prop_intangible_p): Update prototype.
3697 (compute_display_string_pos, compute_display_string_end):
3699 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3702 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3704 Malloc failure behavior now depends on size of allocation.
3705 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3706 * lisp.h: Change signatures accordingly.
3707 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3708 All callers changed. (Bug#8762)
3710 * gnutls.c: Use Emacs's memory allocators.
3711 Without this change, the gnutls library would invoke malloc etc.
3712 directly, which causes problems on non-SYNC_INPUT hosts, and which
3713 runs afoul of improving memory_full behavior. (Bug#8761)
3714 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3715 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3716 xfree instead of the default malloc, realloc, free.
3717 (Fgnutls_boot): No need to check for memory allocation failure,
3718 since xmalloc does that for us.
3720 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3721 * category.c (hash_get_category_set):
3722 * ccl.c (ccl_driver):
3723 * charset.c (Fdefine_charset_internal):
3724 * charset.h (struct charset.hash_index):
3725 * composite.c (get_composition_id, gstring_lookup_cache)
3726 (composition_gstring_put_cache):
3727 * composite.h (struct composition.hash_index):
3728 * dispextern.h (struct image.hash):
3729 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3730 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3731 (hashfn_equal, hashfn_user_defined, make_hash_table)
3732 (maybe_resize_hash_table, hash_lookup, hash_put)
3733 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3734 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3735 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3736 * image.c (make_image, search_image_cache, lookup_image)
3737 (xpm_put_color_table_h):
3738 * lisp.h (struct Lisp_Hash_Table):
3739 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3740 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3741 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3742 * alloc.c (allocate_vectorlike):
3743 Check for overflow in vector size calculations.
3744 * ccl.c (ccl_driver):
3745 Check for overflow when converting EMACS_INT to int.
3746 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3747 need to be updated by these changes.
3748 * fns.c (make_hash_table, maybe_resize_hash_table):
3749 Check for integer overflow with large hash tables.
3750 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3751 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3752 (SXHASH_REDUCE): New macro.
3753 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3754 Use it instead of discarding useful hash info with large hash values.
3755 (sxhash_float): New function.
3756 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3757 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3758 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3759 Rewrite to use FIXNUM_BITS, as this simplifies things.
3760 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3761 Adjust signatures to match updated version of code.
3762 (consing_since_gc): Now EMACS_INT, since a single hash table can
3763 use more than INT_MAX bytes.
3765 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3767 Make it possible to build with GCC-4.6+ -O2 -flto.
3769 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3771 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3773 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3774 Call minibuffer-inactive-mode.
3776 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3778 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3779 Update dependencies.
3781 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3783 * data.c (init_data): Remove code for UTS, this system is not
3786 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3788 Don't force ./temacs to start in terminal mode.
3790 * frame.c (make_initial_frame): Initialize faces in all cases, not
3791 only when CANNOT_DUMP is defined.
3792 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3794 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3796 * dispnew.c (add_window_display_history): Use const for the string
3797 pointer. Remove declaration, not needed.
3799 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3801 Use 'inline', not 'INLINE'.
3802 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3803 * alloc.c, fontset.c (INLINE): Remove.
3804 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3805 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3806 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3807 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3808 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3810 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3812 Make it possible to run ./temacs.
3814 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3815 syms_of_callproc does the same thing. Remove test for
3816 "initialized", do it in the caller.
3817 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3819 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3821 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3822 (read_minibuf): Use get_minibuffer.
3823 (syms_of_minibuf): Use DEFSYM.
3824 (Qmetadata): New var.
3825 * data.c (Qbuffer): Don't make it static.
3826 (syms_of_data): Use DEFSYM.
3828 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3830 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3831 (CCL_CODE_MIN): New macro.
3833 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3835 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3837 * eval.c (Qdebug): Now static.
3838 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3839 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3840 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3842 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3844 * image.c: Various fixes to ImageMagick code comments.
3845 (Fimagemagick_types): Doc fix.
3847 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3849 Minor fixes prompted by GCC 4.6.0 warnings.
3851 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3853 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3854 (x_clipboard_manager_save_all): Move extern decl to ...
3855 * xterm.h: ... here, so that it can be checked for consistency.
3857 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3859 * xselect.c (x_clipboard_manager_save_frame)
3860 (x_clipboard_manager_save_all): New functions.
3861 (Fx_clipboard_manager_save): Lisp function deleted.
3863 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3864 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3866 * xterm.h: Update prototype.
3868 2011-05-28 William Xu <william.xwl@gmail.com>
3870 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3873 2011-05-28 Jim Meyering <meyering@redhat.com>
3875 Avoid a sign-extension bug in crypto_hash_function.
3876 * fns.c (to_uchar): Define.
3877 (crypto_hash_function): Use it to convert some newly-signed
3878 variables to unsigned, to avoid sign-extension bugs. For example,
3879 without this change, (md5 "truc") would evaluate to
3880 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3881 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3882 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3884 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3886 Integer overflow fixes.
3888 * dbusbind.c: Serial number integer overflow fixes.
3889 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3890 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3891 to hold a serial number that is too large for a fixnum.
3892 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3893 Check for serial numbers out of range. Decode any serial number
3894 that was so large that it became a float. (Bug#8722)
3896 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3897 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3898 Use XFASTINT rather than XUINT when numbers are nonnegative.
3899 (xd_append_arg, Fdbus_method_return_internal):
3900 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3901 arguments, check that Lisp number is nonnegative, rather than
3902 silently wrapping negative numbers around. (Bug#8722)
3903 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3906 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3908 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3910 ccl: add integer overflow checks
3911 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3912 (IN_INT_RANGE): New macros.
3913 (ccl_driver): Use them to check for integer overflow when
3914 decoding a CCL program. Many of the new checks are whether XINT (x)
3915 fits in int; it doesn't always, on 64-bit hosts. The new version
3916 doesn't catch all possible integer overflows, but it's an
3917 improvement. (Bug#8719)
3919 * alloc.c (make_event_array): Use XINT, not XUINT.
3920 There's no need for unsigned here.
3922 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3923 This follows up to the 2011-05-06 change that substituted uintptr_t
3924 for EMACS_INT. This case wasn't caught back then.
3926 Rework Fformat to avoid integer overflow issues.
3927 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3928 now (part of C89). Include <verify.h>.
3929 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3930 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3931 (Fformat): Avoid the prepass trying to compute sizes; it was only
3932 approximate and thus did not catch overflow reliably. Instead, walk
3933 through the format just once, formatting and computing sizes as we go,
3934 checking for integer overflow at every step, and allocating a larger
3935 buffer as needed. Keep track separately whether the format is
3936 multibyte. Keep only the most-recently calculated precision, rather
3937 than them all. Record whether each argument has been converted to
3938 string. Use EMACS_INT, not int, for byte and char and arg counts.
3939 Support field widths and precisions larger than INT_MAX. Avoid
3940 sprintf's undefined behavior with conversion specifications such as %#d
3941 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3942 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3943 formatting out-of-range floating point numbers with int
3946 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3948 * data.c: Avoid integer truncation in expressions involving floats.
3949 * data.c: Include <intprops.h>.
3950 (arith_driver): When there's an integer overflow in an expression
3951 involving floating point, convert the integers to floating point
3952 so that the resulting value does not suffer from catastrophic
3953 integer truncation. For example, on a 64-bit host (* 4
3954 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3955 Do not rely on undefined behavior after integer overflow.
3957 merge count_size_as_multibyte, parse_str_to_multibyte
3958 * character.c, character.h (count_size_as_multibyte):
3959 Rename from parse_str_to_multibyte; all uses changed.
3960 Check for integer overflow.
3961 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3962 since it's now a duplicate of the other. This is more of
3963 a character than a buffer op, so better that it's in character.c.
3964 * fns.c, print.c: Adjust to above changes.
3966 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3968 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3970 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3972 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3973 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3974 (x_clipboard_manager_save): Now static.
3975 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3977 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3978 (crypto_hash_function): Now static.
3979 Fix pointer signedness problems. Avoid unnecessary initializations.
3981 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3983 * termhooks.h (Vselection_alist): Make it terminal-local.
3985 * terminal.c (create_terminal): Initialize it.
3987 * xselect.c: Support for clipboard managers.
3988 (Vselection_alist): Move to termhooks.h as terminal-local var.
3989 (LOCAL_SELECTION): New macro.
3990 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3991 (symbol_to_x_atom): Remove gratuitous arg.
3992 (x_handle_selection_request, lisp_data_to_selection_data)
3993 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3994 (x_own_selection, x_get_local_selection, x_convert_selection):
3995 New arg, specifying work frame. Use terminal-local Vselection_alist.
3996 (some_frame_on_display): Delete unused function.
3997 (Fx_own_selection_internal, Fx_get_selection_internal)
3998 (Fx_disown_selection_internal, Fx_selection_owner_p)
3999 (Fx_selection_exists_p): New optional frame arg.
4000 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4001 (x_handle_selection_clear): Don't treat other terminals with the
4002 same keyboard specially. Use the terminal-local Vselection_alist.
4003 (x_clear_frame_selections): Use Frun_hook_with_args.
4005 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4007 * xterm.h: Add support for those atoms.
4009 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4011 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4012 (converted_selections, conversion_fail_tag): New global variables.
4013 (x_selection_request_lisp_error): Free the above.
4014 (x_get_local_selection): Remove unnecessary code.
4015 (x_reply_selection_request): Args changed; handle arbitrary array
4016 of converted selections stored in converted_selections.
4017 Separate the XChangeProperty and SelectionNotify steps.
4018 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4019 (x_convert_selection): New function.
4020 (x_handle_selection_event): Simplify.
4021 (x_get_foreign_selection): Don't ignore incoming requests while
4022 waiting for an answer; this will fail when we implement
4023 SAVE_TARGETS, and seems unnecessary anyway.
4024 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4025 (Vx_sent_selection_functions): Doc fix.
4027 2011-05-26 Leo Liu <sdl.web@gmail.com>
4029 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4031 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4033 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4035 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4036 for fringe update if it has periodic bitmap.
4037 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4038 and fringe_bitmap_periodic_p.
4040 * fringe.c (get_fringe_bitmap_data): New function.
4041 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4042 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4043 row. Mark glyph row for fringe update if periodicity changed.
4045 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4046 for fringe update unless it has periodic bitmap.
4048 2011-05-25 Kenichi Handa <handa@m17n.org>
4050 * xdisp.c (get_next_display_element): Set correct it->face_id for
4051 a static composition.
4053 2011-05-24 Leo Liu <sdl.web@gmail.com>
4056 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4058 * fns.c (crypto_hash_function, Fsha1): New function.
4059 (Fmd5): Use crypto_hash_function.
4060 (syms_of_fns): Add Ssha1.
4062 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4064 * gnutls.c: Remove unused macros.
4065 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4066 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4067 Remove macros that are defined and never used.
4068 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4070 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4072 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4073 (Fx_get_selection_internal): Minor cleanup.
4074 (Fx_own_selection_internal): Rename arguments for consistency with
4077 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4079 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4081 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4083 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4085 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4087 * dispnew.c (scrolling_window): Don't exclude the case that the
4088 last enabled row in the desired matrix touches the bottom boundary.
4090 2011-05-21 Glenn Morris <rgm@gnu.org>
4092 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4093 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4094 and add some more files.
4096 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4098 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4099 report_file_error introduced by the change from 2011-05-07.
4101 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4103 * systime.h (Time): Define only if emacs is defined.
4104 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4105 where the include path doesn't have X11/X.h by default. See
4106 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4108 2011-05-20 Kenichi Handa <handa@m17n.org>
4110 * composite.c (find_automatic_composition): Fix previous change.
4112 2011-05-20 Glenn Morris <rgm@gnu.org>
4114 * lisp.mk: New file, split from Makefile.in.
4115 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4116 (shortlisp): Remove.
4117 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4119 2011-05-19 Glenn Morris <rgm@gnu.org>
4121 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4122 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4123 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4124 (lisp): Set the order to that of loadup.el.
4125 (shortlisp): Make it a copy of $lisp.
4126 (SOME_MACHINE_LISP): Remove.
4127 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4128 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4130 2011-05-18 Kenichi Handa <handa@m17n.org>
4132 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4133 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4134 (find_automatic_composition): Mostly rewrite for efficiency.
4136 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4138 * makefile.w32-in: Update dependencies.
4140 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4142 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4143 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4145 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4147 Fix some integer overflow issues, such as string length overflow.
4149 * insdel.c (count_size_as_multibyte): Check for string overflow.
4151 * character.c (lisp_string_width): Check for string overflow.
4152 Use EMACS_INT, not int, for string indexes and lengths; in
4153 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4154 the resulting string length overflows an EMACS_INT; instead,
4155 report a string overflow if no precision given. When checking for
4156 precision exhaustion, use a check that cannot possibly have
4157 integer overflow. (Bug#8675)
4158 * character.h (lisp_string_width): Adjust to new signature.
4160 * alloc.c (string_overflow): New function.
4161 (Fmake_string): Use it. This doesn't change behavior, but saves
4162 a few bytes and will simplify future changes.
4163 * character.c (string_escape_byte8): Likewise.
4164 * lisp.h (string_overflow): New decl.
4166 Fixups, following up to the user-interface timestamp change.
4167 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4168 for UI timestamps, instead of unsigned long.
4169 * msdos.c (mouse_get_pos): Likewise.
4170 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4171 * w32gui.h (Time): Define by including "systime.h" rather than by
4172 declaring it ourselves. (Bug#8664)
4174 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4175 * image.c (clear_image_cache): Likewise.
4177 * term.c (term_mouse_position): Don't assume time_t wraparound.
4179 Be more systematic about user-interface timestamps.
4180 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4181 and sometimes 'EMACS_UINT', to represent these timestamps.
4182 This change causes it to use 'Time' uniformly, as that's what X uses.
4183 This makes the code easier to follow, and makes it easier to catch
4184 integer overflow bugs such as Bug#8664.
4185 * frame.c (Fmouse_position, Fmouse_pixel_position):
4186 Use Time, not unsigned long, for user-interface timestamps.
4187 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4188 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4189 * keyboard.h (last_event_timestamp): Likewise.
4190 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4191 * menu.h (xmenu_show): Likewise.
4192 * term.c (term_mouse_position): Likewise.
4193 * termhooks.h (struct input_event.timestamp): Likewise.
4194 (struct terminal.mouse_position_hook): Likewise.
4195 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4196 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4197 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4198 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4200 * menu.h, termhooks.h: Include "systime.h", for Time.
4202 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4203 Don't assume that the difference between two unsigned long values
4204 can fit into an integer. At this point, we know button_down_time
4205 <= event->timestamp, so the difference must be nonnegative, so
4206 there's no need to cast the result if double-click-time is
4207 nonnegative, as it should be; check that it's nonnegative, just in
4208 case. This bug is triggered when events are more than 2**31 ms
4209 apart (about 25 days). (Bug#8664)
4211 * xselect.c (last_event_timestamp): Remove duplicate decl.
4212 (x_own_selection): Remove needless cast to unsigned long.
4214 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4215 that always fit in int. Use a sentinel instead of a counter, to
4216 avoid a temp and to allay GCC's concerns about possible int overflow.
4217 * frame.h (struct frame): Use int for menu_bar_items_used
4218 instead of EMACS_INT, since it always fits in int.
4220 * menu.c (grow_menu_items): Check for int overflow.
4222 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4224 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4225 Before, the code was not consistent. These values cannot exceed
4226 2**31 - 1 so there's no need to make them unsigned.
4227 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4228 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4229 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4231 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4233 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4234 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4235 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4236 presumably because the widths might not match.
4238 * window.c (size_window): Avoid needless test at loop start.
4240 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4242 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4244 2011-05-12 Drew Adams <drew.adams@oracle.com>
4246 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4248 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4250 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4251 `width' to `bar_area_x' and `bar_area_width', respectively.
4252 (x_scroll_run): Take account of fringe background extension.
4254 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4255 Rename local vars `left' and `width' to `bar_area_x' and
4256 `bar_area_width', respectively.
4257 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4258 background extension.
4260 2011-05-10 Jim Meyering <meyering@redhat.com>
4262 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4264 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4266 * image.c (Finit_image_library): Return t for built-in image types,
4267 like pbm and xbm. (Bug#8640)
4269 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4271 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4273 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4275 * w32console.c (Fset_screen_color): Doc fix.
4276 (Fget_screen_color): New function.
4277 (syms_of_ntterm): Defsubr it.
4279 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4280 unlink the temporary file if Fcall_process didn't create it in the
4282 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4283 child process will be redirected to a file specified with `:file'.
4284 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4285 cue to call_process_cleanup not to close that handle.
4287 2011-05-07 Ben Key <bkey76@gmail.com>
4289 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4290 one of two shell specific rules, either bootstrap-temacs-CMD or
4291 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4292 to the previous implementation of the bootstrap-temacs rule.
4293 The bootstrap-temacs-CMD rule is similar to the previous
4294 implementation of the bootstrap-temacs rule except that it
4295 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4298 These changes, along with some changes to nt/configure.bat,
4299 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4300 earlier fix to add support for --cflags and --ldflags options
4301 that include quotes so that it works whether make uses cmd or
4304 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4306 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4307 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4309 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4310 a string. Handle both cases.
4311 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4312 (Fdbus_register_method): Use Qinvalid_function.
4314 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4316 * makefile.w32-in: Update dependencies.
4317 (LISP_H): Add inttypes.h and stdin.h.
4318 (PROCESS_H): Add unistd.h.
4320 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4322 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4323 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4325 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4327 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4329 * term.c (vfatal): Remove stray call to va_end.
4330 It's not needed and the C Standard doesn't allow it here anyway.
4332 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4333 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4335 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4338 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4340 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4342 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4344 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4346 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4348 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4349 * charset.c (Fdefine_charset_internal): Don't initialize
4350 charset.code_space[15]. The value was garbage, on hosts with
4351 32-bit int (Bug#8600).
4353 * lread.c (read_integer): Be more consistent with string-to-number.
4354 Use string_to_number to do the actual conversion; this avoids
4355 rounding errors and fixes some other screwups. Without this fix,
4356 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4357 (digit_to_number): Move earlier, for benefit of read_integer.
4358 Return -1 if the digit is out of range for the base, -2 if it is
4359 not a digit in any supported base. (Bug#8602)
4361 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4363 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4364 to match comment at start of function. This also removes a
4365 GCC warning about overflow in a 32+64-bit port.
4367 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4369 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4370 Reported by Stefan Monnier in
4371 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4372 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4373 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4375 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4376 (EMACS_UINTPTR): Likewise, with uintptr_t.
4378 * lisp.h: Prefer 64-bit EMACS_INT if available.
4379 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4380 on 32-bit hosts that have 64-bit int, so that they can access
4382 However, temporarily disable this change unless the temporary
4383 symbol WIDE_EMACS_INT is defined.
4385 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4387 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4388 This removes an assumption that EMACS_INT and long are the same
4389 width as pointers. The assumption is true for Emacs porting targets
4390 now, but we want to make other targets possible.
4391 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4392 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4393 In the rest of the code, change types of integers that hold casted
4394 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4395 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4396 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4397 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4398 No need to cast type when ORing.
4399 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4400 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4401 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4402 assume EMACS_INT is the same width as char *.
4403 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4404 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4405 Remove no-longer-needed casts.
4406 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4407 (xg_tool_bar_help_callback, xg_make_tool_item):
4408 Use EMACS_INTPTR to hold an integer
4409 that will be cast to void *; this can avoid a GCC warning
4410 if EMACS_INT is not the same width as void *.
4411 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4412 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4413 (current_message_1, set_message_1):
4414 Use a local to convert to proper width without a cast.
4415 * xmenu.c (dialog_selection_callback): Likewise.
4417 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4418 Also, don't assume VALBITS / RAND_BITS is less than 5,
4419 and don't rely on undefined behavior when shifting a 1 left into
4421 * lisp.h (get_random): Change signature to match.
4423 * lread.c (hash_string): Use size_t, not int, for hash computation.
4424 Normally we prefer signed values; but hashing is special, because
4425 it's better to use unsigned division on hash table sizes so that
4426 the remainder is nonnegative. Also, size_t is the natural width
4427 for hashing into memory. The previous code used 'int', which doesn't
4428 retain enough info to hash well into very large tables.
4429 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4431 * dbusbind.c: Don't possibly lose pointer info when converting.
4432 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4433 Use XPNTR rather than XHASH, so that the high-order bits of
4434 the pointer aren't lost when converting through void *.
4436 * eval.c (Fautoload): Don't double-shift a pointer.
4438 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4440 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4442 * gnutls.c (DEF_GNUTLS_FN):
4443 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4445 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4447 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4450 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4452 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4453 New version that can reserve upto 2GB of heap space.
4455 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4457 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4459 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4461 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4462 `gnutls_certificate_set_x509_key_file'.
4464 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4466 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4467 Update dependencies.
4469 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4471 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4472 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4473 Remove unused parameter `fildes'.
4474 * process.c (read_process_output, send_process): Don't pass it.
4476 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4478 Fix previous change: the library cache is defined in w32.c.
4479 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4480 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4482 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4484 Implement dynamic loading of GnuTLS on Windows.
4486 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4487 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4488 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4491 * gnutls.c (Qgnutls_dll): Define.
4492 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4493 (gnutls_*): Declare function pointers.
4494 (init_gnutls_functions): New function to initialize function pointers.
4495 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4496 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4497 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4498 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4499 (emacs_gnutls_write, emacs_gnutls_read)
4500 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4501 (Fgnutls_available_p): New function.
4502 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4503 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4504 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4506 * image.c: Include w32.h.
4507 (Vimage_type_cache): Delete.
4508 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4509 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4510 (w32_delayed_load): Move to w32.c.
4512 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4514 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4515 (w32_delayed_load): Move from image.c. When loading a library, record
4516 its filename in the :loaded-from property of the library id.
4517 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4518 Initialize and staticpro them.
4519 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4521 * process.c: Include lisp.h before w32.h, not after.
4522 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4523 instead of gnutls_record_check_pending.
4525 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4527 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4529 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4530 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4533 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4535 * xterm.c (x_set_frame_alpha): Do not set property on anything
4536 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4538 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4540 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4542 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4544 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4545 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4546 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4547 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4548 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4549 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4550 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4551 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4552 (Qgnutls_bootprop_callbacks_verify): Make static.
4554 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4556 * callproc.c: Indentation fixup.
4558 * sysdep.c (wait_for_termination_1): Make static.
4559 (wait_for_termination, interruptible_wait_for_termination):
4560 Move after wait_for_termination_1.
4562 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4564 * sysdep.c (interruptible_wait_for_termination): New function
4565 which is like wait_for_termination, but allows keyboard
4568 * callproc.c (Fcall_process): Add (:file "file") as an option for
4570 (Fcall_process_region): Ditto.
4572 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4574 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4575 rather than `XVECTOR (FOO)->size'.
4577 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4578 inttypes.h, as a gnulib replacement is used if it not available in
4581 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4583 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4584 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4585 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4587 * coding.c (coding_alloc_by_realloc): Error out if destination
4588 will grow beyond MOST_POSITIVE_FIXNUM.
4589 (decode_coding_emacs_mule): Abort if there isn't enough place in
4590 charbuf for the composition carryover bytes. Reserve an extra
4591 space for up to 2 characters produced in a loop.
4592 (decode_coding_iso_2022): Abort if there isn't enough place in
4593 charbuf for the composition carryover bytes.
4595 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4597 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4598 aborting when %lld or %lll format is passed.
4599 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4600 %llo or %llx format is passed. (Bug#8545)
4602 * window.c (window_scroll_line_based): Use a marker instead of
4603 simple variables to record original value of point. (Bug#7952)
4605 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4606 produced by %s or %c overflows available buffer space. (Bug#8545)
4608 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4610 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4611 (SIZE_MAX): Move defn after all includes, as they might #define it.
4613 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4615 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4617 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4619 * keyboard.c (Qdelayed_warnings_hook): Define.
4620 (command_loop_1): Run `delayed-warnings-hook'
4621 if Vdelayed_warnings_list is non-nil.
4622 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4623 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4625 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4627 * doprnt.c (doprnt): Don't return value smaller than the buffer
4628 size if the message was truncated. (Bug#8545).
4630 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4632 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4633 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4635 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4637 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4639 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4641 * makefile.w32-in: Update dependencies.
4643 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4645 Improve `doprnt' and its usage. (Bug#8545)
4646 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4647 `format_end'. Remove support for %l as a conversion specifier.
4648 Don't use xrealloc. Improve diagnostics when the %l size modifier
4649 is used. Update the commentary.
4651 * eval.c (verror): Simplify calculation of size_t.
4653 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4656 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4658 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4661 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4663 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4664 This makes this file independent of the recent pseudovector change.
4666 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4668 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4670 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4671 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4672 Remove unused local.
4673 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4675 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4676 GCC 4.6.0 optimizes based on type-based alias analysis.
4677 For example, if b is of type struct buffer * and v of type struct
4678 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4679 != &v->size, and therefore "v->size = 1; b->size = 2; return
4680 v->size;" must therefore return 1. This assumption is incorrect
4681 for Emacs, since it type-puns struct Lisp_Vector * with many other
4682 types. To fix this problem, this patch adds a new type struct
4683 vectorlike_header that documents the constraints on layout of vectors
4684 and pseudovectors, and helps optimizing compilers not get fooled
4685 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4686 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4687 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4689 (XSETPVECTYPE): Rewrite in terms of new macro.
4690 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4691 This is a bit clearer, and further avoids the possibility of
4692 undesirable aliasing.
4693 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4694 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4695 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4696 since Lisp_Subr is a special case (no "next" field).
4697 (ASIZE): Now uses header.size rather than size.
4698 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4699 to avoid the hassle of writing XVECTOR (foo)->header.size.
4700 (struct vectorlike_header): New type.
4701 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4702 object, to help avoid aliasing.
4703 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4704 (SUBRP): Likewise, since Lisp_Subr is a special case.
4705 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4706 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4707 (struct Lisp_Hash_Table): Combine first two members into a single
4708 struct vectorlike_header member. All uses of "size" and "next" members
4709 changed to be "header.size" and "header.next".
4710 * buffer.h (struct buffer): Likewise.
4711 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4712 * frame.h (struct frame): Likewise.
4713 * process.h (struct Lisp_Process): Likewise.
4714 * termhooks.h (struct terminal): Likewise.
4715 * window.c (struct save_window_data, struct saved_window): Likewise.
4716 * window.h (struct window): Likewise.
4717 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4718 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4719 * buffer.c (init_buffer_once): Likewise.
4720 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4722 * process.c (Fformat_network_address): Use local var for size,
4725 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4727 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4728 * data.c (atof): Remove decl; no longer used or needed.
4729 (digit_to_number): Move to lread.c.
4730 (Fstring_to_number): Use new string_to_number function, to be
4731 consistent with how the Lisp reader treats infinities and NaNs.
4732 Do not assume that floating-point numbers represent EMACS_INT
4733 without losing information; this is not true on most 64-bit hosts.
4734 Avoid double-rounding errors, by insisting on integers when
4735 parsing non-base-10 numbers, as the documentation specifies.
4736 * lisp.h (string_to_number): New decl, replacing ...
4737 (isfloat_string): Remove.
4738 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4739 (read1): Do not accept +. and -. as integers; this
4740 appears to have been a coding error. Similarly, do not accept
4741 strings like +-1e0 as floating point numbers. Do not report
4742 overflow for integer overflows unless the base is not 10 which
4743 means we have no simple and reliable way to continue.
4744 Break out the floating-point parsing into a new
4745 function string_to_number, so that Fstring_to_number parses
4746 floating point numbers consistently with the Lisp reader.
4747 (digit_to_number): Move here from data.c. Make it static inline.
4748 (E_CHAR, EXP_INT): Remove, replacing with ...
4749 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4750 (string_to_number): New function, replacing isfloat_string.
4751 This function checks for valid syntax and produces the resulting
4752 Lisp float number too. Rework it so that string-to-number
4753 no longer mishandles examples like "1.0e+". Use strtoumax,
4754 so that overflow for non-base-10 numbers is reported only when
4755 there's no portable and simple way to convert to floating point.
4757 * textprop.c (set_text_properties_1): Rewrite for clarity,
4758 and to avoid GCC warning about integer overflow.
4760 * intervals.h (struct interval): Use EMACS_INT for members
4761 where EMACS_UINT might cause problems. See
4762 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4763 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4764 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4766 (offset_intervals): Tell GCC not to worry about length overflow
4767 when negating a negative length.
4769 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4770 (overrun_check_free): Likewise.
4772 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4773 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4776 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4777 (gnutls_make_error): Rename local to avoid shadowing.
4778 (gnutls_emacs_global_deinit): ifdef out; not used.
4779 (Fgnutls_boot): Use const for pointer to readonly storage.
4780 Comment out unused local. Fix pointer signedness problems.
4782 * lread.c (openp): Don't stuff size_t into an 'int'.
4783 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4784 about possible signed overflow.
4786 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4787 (GDK_KEY_g): Don't define if already defined.
4788 (xg_prepare_tooltip): Avoid pointer signedness problem.
4789 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4791 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4792 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4794 * xfns.c (Fx_window_property): Simplify a bit,
4795 to make a bit faster and to avoid GCC 4.6.0 warning.
4796 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4798 * fns.c (internal_equal): Don't assume size_t fits in int.
4800 * alloc.c (compact_small_strings): Tighten assertion a little.
4802 Replace pEd with more-general pI, and fix some printf arg casts.
4803 * lisp.h (pI): New macro, generalizing old pEd macro to other
4804 conversion specifiers. For example, use "...%"pI"d..." rather
4805 than "...%"pEd"...".
4806 (pEd): Remove. All uses replaced with similar uses of pI.
4807 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4808 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4809 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4810 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4811 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4812 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4813 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4815 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4816 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4817 * print.c (safe_debug_print, print_object): Likewise.
4818 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4820 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4821 avoiding the 0 flag, which is not portable.
4822 * process.c (Fmake_network_process): Use pI to avoid cast.
4823 * region-cache.c (pp_cache): Likewise.
4824 * xdisp.c (decode_mode_spec): Likewise.
4825 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4826 behavior on 64-bit hosts with printf arg.
4827 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4828 (x_stop_queuing_selection_requests): Likewise.
4829 (x_get_window_property): Don't truncate byte count to an 'int'
4832 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4833 here, since it parses constructs like leading '-' and spaces,
4834 which are not wanted; and it overflows with large numbers.
4835 Instead, simply match F[0-9]+, which is what is wanted anyway.
4837 * alloc.c: Remove unportable assumptions about struct layout.
4838 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4839 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4840 (allocate_vectorlike, make_pure_vector): Use the new macros,
4841 plus offsetof, to remove unportable assumptions about struct layout.
4842 These assumptions hold on all porting targets that I know of, but
4843 they are not guaranteed, they're easy to remove, and removing them
4844 makes further changes easier.
4846 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4847 This doesn't fix a bug but makes the code clearer.
4848 (string_overrun_cookie): Now const. Use initializers that
4849 don't formally overflow signed char, to avoid warnings.
4850 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4851 can cause Emacs to crash when string overrun checking is enabled.
4852 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4853 multiple of sizeof (EMACS_INT); it need not be, if
4854 alignof(EMACS_INT) < sizeof (EMACS_INT).
4855 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4857 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4859 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4861 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4863 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4864 supposed to be handshaking. (Bug#8556)
4865 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4867 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4869 * lisp.h (Qdebug): List symbol.
4870 * eval.c (Qdebug): Restore global linkage.
4871 * keyboard.c (debug-on-event): New variable.
4872 (handle_user_signal): Break into debugger when debug-on-event
4873 matches the current signal symbol.
4875 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4877 * alloc.c (check_sblock, check_string_bytes)
4878 (check_string_free_list): Convert to standard C.
4880 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4882 * w32.c (emacs_gnutls_push): Fix typo.
4884 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4886 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4887 "cast to pointer from integer of different size".
4889 Improve doprnt and its use in verror. (Bug#8545)
4890 * doprnt.c (doprnt): Document the set of format control sequences
4891 supported by the function. Use SAFE_ALLOCA instead of always
4894 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4895 is one byte too soon. Don't use xrealloc; instead xfree and
4898 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4900 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4903 * gnutls.c: Renamed global_initialized to
4904 gnutls_global_initialized. Added internals for the
4905 :verify-hostname-error, :verify-error, and :verify-flags
4906 parameters of `gnutls-boot' and documented those parameters in the
4907 docstring. Start callback support.
4908 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4909 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4910 on error. Return error code.
4911 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4912 (emacs_gnutls_read): Likewise.
4913 (Fgnutls_boot): Return handshake error code.
4914 (emacs_gnutls_handle_error): New function.
4915 (wsaerror_to_errno): Likewise.
4917 * w32.h (emacs_gnutls_pull): Add prototype.
4918 (emacs_gnutls_push): Likewise.
4920 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4921 (emacs_gnutls_push): Likewise.
4923 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4925 * process.c (wait_reading_process_output): Check if GnuTLS
4926 buffered some data internally if no FDs are set for TLS
4929 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4930 (LIBS): Link to USER_LIBS.
4931 ($(BLD)/gnutls.$(0)): New target.
4933 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4935 * xdisp.c (handle_single_display_spec): Rename the
4936 display_replaced_before_p argument into display_replaced_p, to
4937 make it consistent with the commentary. Fix typos in the
4940 * textprop.c (syms_of_textprop): Remove dead code.
4941 (copy_text_properties): Delete obsolete commentary about an
4942 interface that was deleted long ago. Fix typos in the description
4945 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4946 to changes in oldXMenu/XMenu.h from 2011-04-16.
4947 <menu_help_message, prev_menu_help_message>: Constify.
4948 (IT_menu_make_room): menu->help_text is now `const char **';
4951 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4952 to changes in oldXMenu/XMenu.h from 2011-04-16.
4953 (struct XMenu): Declare `help_text' `const char **'.
4955 * xfaces.c <Qunspecified>: Make extern again.
4957 * syntax.c: Include sys/types.h before including regex.h, as
4960 * doc.c (get_doc_string): Improve the format passed to `error'.
4962 * doprnt.c (doprnt): Improve commentary.
4964 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4966 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4969 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4970 changes in globals.h immediately force recompilation.
4971 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4972 $(CURDIR)/s/ms-w32.h.
4973 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4975 * character.c (Fchar_direction): Function deleted.
4976 (syms_of_character): Don't defsubr it.
4977 <char-direction-table>: Deleted.
4979 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4981 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4982 * doprnt.c: Include limits.h.
4983 (SIZE_MAX): New macro.
4984 (doprnt): Return a size_t value. 2nd arg is now size_t.
4985 Many local variables are now size_t instead of int or unsigned.
4986 Improve overflow protection. Support `l' modifier for integer
4987 conversions. Support %l conversion. Don't assume an EMACS_INT
4988 argument for integer conversions and for %c.
4990 * lisp.h (doprnt): Restore prototype.
4992 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4995 * Makefile.in (base_obj): Add back doprnt.o.
4997 * deps.mk (doprnt.o): Add back prerequisites.
4998 (callint.o): Depend on character.h.
5000 * eval.c (internal_lisp_condition_case): Include the handler
5001 representation in the error message.
5002 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5003 when breaking from the loop.
5005 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5007 * callint.c (Fcall_interactively): When displaying error message
5008 about invalid control letter, pass the character's codepoint, not
5009 a pointer to its multibyte form. Improve display of the character
5010 in octal and display also its hex code.
5012 * character.c (char_string): Use %x to display the (unsigned)
5013 codepoint of an invalid character, to avoid displaying a bogus
5016 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5017 `error', not SYMBOL_NAME itself.
5019 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5020 character arguments to `error'.
5022 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5023 to `error' in error message about FINAL_CHAR argument. Make sure
5024 FINAL_CHAR is a character, and use %c when it is passed as
5025 argument to `error'.
5027 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5029 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5031 * w32.c: Include <time.h>.
5032 (sys_localtime): New function.
5034 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5036 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5038 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5040 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5042 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5045 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5047 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5048 gl_state.e_property when gl_state.object is Qt.
5050 * insdel.c (make_gap_larger): Remove limitation of buffer size
5053 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5055 * xdisp.c (lookup_glyphless_char_display)
5056 (produce_glyphless_glyph): Handle cons cell entry in
5057 glyphless-char-display.
5058 (Vglyphless_char_display): Document it.
5060 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5061 glyphless-char-display.
5063 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5065 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5067 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5069 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5070 definition for no-X builds.
5072 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5074 Static checks with GCC 4.6.0 and non-default toolkits.
5076 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5078 * process.c (keyboard_bit_set): Define only if SIGIO.
5079 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5080 (send_process): Repair possible setjmp clobbering.
5082 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5084 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5086 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5088 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5089 Define only if needed.
5091 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5092 by pacifying GCC about it. Maybe it's time to retire it?
5093 * xfaces.c (USG, __TIMEVAL__): Likewise.
5095 * dispextern.h (struct redisplay_interface): Rename param
5097 * termhooks.h (struct terminal): Likewise.
5098 * xterm.c (xembed_send_message): Likewise.
5100 * insdel.c (make_gap_smaller): Define only if
5101 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5103 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5106 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5107 so that we aren't warned about unused symbols.
5109 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5111 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5113 * xfns.c (x_real_positions): Mark locals as initialized.
5115 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5117 * xterm.c: Fix problems found by static analysis with other toolkits.
5118 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5119 (x_dispatch_event): Declare static if USE_GTK, and
5120 define if USE_GTK || USE_X_TOOLKIT.
5121 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5122 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5123 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5124 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5126 * xmenu.c (menu_help_callback): Pointer type fixes.
5127 Use const pointers when pointing at readonly data. Avoid pointer
5129 (FALSE): Remove unused macro.
5130 (update_frame_menubar): Remove unused decl.
5132 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5134 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5135 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5136 (single_menu_item): Rename local to avoid shadowing.
5138 * keyboard.c (make_lispy_event): Remove unused local var.
5140 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5141 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5143 * bitmaps: Change bitmaps from unsigned char back to the X11
5144 compatible char. Avoid the old compiler warnings about
5145 out-of-range initializers by using, for example, '\xab' rather
5148 * xgselect.c (xgselect_initialize): Check vs interface
5149 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5151 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5153 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5154 to read-only memory.
5156 * fns.c (vector): Remove; this old hack is no longer needed.
5158 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5160 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5162 * xrdb.c (x_load_resources): Omit unused local.
5164 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5165 (x_window): Rename locals to avoid shadowing.
5166 (USG): Use the kludged USG macro, to pacify gcc.
5168 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5169 (x_term_init): Remove local to avoid shadowing.
5171 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5173 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5174 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5176 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5178 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5180 Fix regex.c, syntax.c and friends for buffers > 2GB.
5181 * syntax.h (struct gl_state_s): Declare character position members
5184 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5186 * textprop.c (verify_interval_modification, interval_of):
5187 Declare arguments EMACS_INT.
5189 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5192 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5194 * indent.c (Fvertical_motion): Local variable it_start is now
5197 * regex.c (re_match, re_match_2, re_match_2_internal)
5198 (bcmp_translate, regcomp, regexec, print_double_string)
5199 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5200 (re_compile_pattern, re_exec): Declare arguments and local
5201 variables `size_t' and `ssize_t' and return values `regoff_t', as
5203 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5204 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5205 <compile_stack_type>: `size' and `avail' are now `size_t'.
5207 * regex.h <regoff_t>: Use ssize_t, not int.
5208 (re_search, re_search_2, re_match, re_match_2): Arguments that
5209 specify buffer/string position and length are now ssize_t and
5210 size_t. Return type is regoff_t.
5212 2011-04-16 Ben Key <bkey76@gmail.com>
5214 * nsfont.m: Fixed bugs in ns_get_family and
5215 ns_descriptor_to_entity that were caused by using free to
5216 deallocate memory blocks that were allocated by xmalloc (via
5217 xstrdup). This caused Emacs to crash when compiled with
5218 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5219 --enable-checking=xmallocoverrun). xfree is now used to
5220 deallocate these memory blocks.
5222 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5224 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5226 emacs_write: Accept and return EMACS_INT for sizes.
5227 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5229 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5230 Accept and return EMACS_INT.
5231 (emacs_gnutls_write): Return the number of bytes written on
5233 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5234 (emacs_read, emacs_write): Remove check for negative size, as the
5235 Emacs source code has been audited now.
5236 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5237 (emacs_read, emacs_write): Use it.
5238 * process.c (send_process): Adjust to the new signatures of
5239 emacs_write and emacs_gnutls_write. Do not attempt to store
5240 a byte offset into an 'int'; it might overflow.
5241 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5243 * sound.c: Don't assume sizes fit in 'int'.
5244 (struct sound_device.period_size, alsa_period_size):
5245 Return EMACS_INT, not int.
5246 (struct sound_device.write, vox_write, alsa_write):
5247 Accept EMACS_INT, not int.
5248 (wav_play, au_play): Use EMACS_INT to store sizes and to
5249 record read return values.
5251 2011-04-15 Ben Key <bkey76@gmail.com>
5253 * keyboard.c (Qundefined): Don't declare static since it is used
5255 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5256 static since they are used in nsfont.m.
5258 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5260 * process.c (Qprocessp): Don't declare static.
5261 * lisp.h (Qprocessp): Declare again.
5263 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5265 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5267 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5269 Improve C-level modularity by making more things 'static'.
5271 Don't publish debugger-only interfaces to other modules.
5272 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5273 (verify_bytepos, count_markers): Move decls to the only modules
5275 * region-cache.h (pp_cache): Likewise.
5276 * window.h (check_all_windows): Likewise.
5277 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5279 * sysdep.c (croak): Now static, if
5280 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5281 * syssignal.h (croak): Declare only if not static.
5283 * alloc.c (refill_memory_reserve): Now static if
5284 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5285 * lisp.h (refill_memory_reserve): Declare only if not static.
5287 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5288 Define only if USE_LUCID.
5290 * xrdb.c (x_customization_string, x_rm_string): Now static.
5292 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5293 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5295 * xdisp.c (draw_row_with_mouse_face): Now static.
5296 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5298 * window.h (check_all_windows): Mark externally visible.
5300 * window.c (window_deletion_count): Now static.
5302 * undo.c: Make symbols static if they're not exported.
5303 (last_undo_buffer, last_boundary_position, pending_boundary):
5306 * textprop.c (interval_insert_behind_hooks): Now static.
5307 (interval_insert_in_front_hooks): Likewise.
5309 * term.c: Make symbols static if they're not exported.
5310 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5311 (max_frame_lines, tty_set_terminal_modes):
5312 (tty_reset_terminal_modes, tty_turn_off_highlight):
5313 (get_tty_terminal): Now static.
5314 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5315 * termhooks.h (term_mouse_moveto): Do not declare if
5317 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5318 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5320 * sysdep.c: Make symbols static if they're not exported.
5321 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5323 (sigprocmask_set, full_mask): Remove; unused.
5324 (wait_debugging): Mark as visible.
5325 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5326 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5328 * syntax.c (syntax_temp): Define only if !__GNUC__.
5330 * sound.c (current_sound_device, current_sound): Now static.
5332 * search.c (searchbufs, searchbuf_head): Now static.
5334 * scroll.c (scroll_cost): Remove; unused.
5335 * dispextern.h (scroll_cost): Remove decl.
5337 * region-cache.h (pp_cache): Mark as externally visible.
5339 * process.c: Make symbols static if they're not exported.
5340 (process_tick, update_tick, create_process, chan_process):
5341 (Vprocess_alist, proc_buffered_char, datagram_access):
5342 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5343 (deactivate_process): Mark defn as static, as well as decl.
5344 * lisp.h (create_process): Remove decl.
5345 * process.h (chan_process, Vprocess_alist): Remove decls.
5347 * print.c: Make symbols static if they're not exported.
5348 (print_depth, new_backquote_output, being_printed, print_buffer):
5349 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5350 (print_interval, print_number_index, initial_stderr_stream):
5352 * lisp.h (Fprinc): Remove decl.
5353 (debug_output_compilation_hack): Mark as externally visible.
5355 * sysdep.c (croak): Move decl from here to syssignal.h.
5356 * syssignal.h (croak): Put it here, so the API can be checked when
5357 'croak' is called from dissociate_if_controlling_tty.
5359 * minibuf.c: Make symbols static if they're not exported.
5360 (minibuf_save_list, choose_minibuf_frame): Now static.
5361 * lisp.h (choose_minibuf_frame): Remove decl.
5363 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5365 * lread.c: Make symbols static if they're not exported.
5366 (read_objects, initial_obarray, oblookup_last_bucket_number):
5368 (make_symbol): Remove; unused.
5369 * lisp.h (initial_obarray, make_symbol): Remove decls.
5371 * keyboard.c: Make symbols static if they're not exported.
5372 (single_kboard, recent_keys_index, total_keys, recent_keys):
5373 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5374 (this_single_command_key_start, echoing, last_auto_save):
5375 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5376 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5377 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5378 (Vlispy_mouse_stem, double_click_count):
5380 (force_auto_save_soon): Define only if SIGDANGER.
5381 (ignore_mouse_drag_p): Now static if
5382 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5383 (print_help): Remove; unused.
5384 (stop_character, last_timer_event): Mark as externally visible.
5385 * keyboard.h (ignore_mouse_drag_p): Declare only if
5386 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5387 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5388 * lisp.h (echoing): Remove decl.
5389 (force_auto_save_soon): Declare only if SIGDANGER.
5390 * xdisp.c (redisplay_window): Simplify code, to make it more
5391 obvious that ignore_mouse_drag_p is not accessed if !defined
5392 USE_GTK && !defined HAVE_NS.
5394 * intervals.c: Make symbols static if they're not exported.
5395 (merge_properties_sticky, merge_interval_right, delete_interval):
5397 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5399 * insdel.c: Make symbols static if they're not exported.
5400 However, leave prepare_to_modify_buffer alone. It's never
5401 called from outside this function, but that appears to be a bug.
5402 (combine_after_change_list, combine_after_change_buffer):
5403 (adjust_after_replace, signal_before_change): Now static.
5404 (adjust_after_replace_noundo): Remove; unused.
5405 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5406 (signal_before_change): Remove decls.
5408 * indent.c (val_compute_motion, val_vmotion): Now static.
5410 * image.c: Make symbols static if they're not exported.
5411 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5413 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5414 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5416 * fringe.c (standard_bitmaps): Now static.
5417 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5419 * frame.c: Make symbols static if they're not exported.
5420 (x_report_frame_params, make_terminal_frame): Now static.
5421 (get_frame_param): Now static, unless HAVE_NS.
5422 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5423 (x_get_resource_string): Remove; not used.
5424 * frame.h (make_terminal_frame, x_report_frame_params):
5425 (x_get_resource_string); Remove decls.
5426 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5427 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5429 * font.c, fontset.c: Make symbols static if they're not exported.
5430 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5431 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5432 * font.c (font_close_object): Now static.
5433 * font.h (font_close_object): Remove.
5434 * fontset.c (FONTSET_OBJLIST): Remove.
5435 (free_realized_fontset) #if-0 the body, which does nothing.
5436 (face_suitable_for_char_p): #if-0, as it's never called.
5437 * fontset.h (face_suitable_for_char_p): Remove decl.
5438 * xfaces.c (face_at_string_position):
5439 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5440 since 0 is always ASCII.
5442 * fns.c (weak_hash_tables): Now static.
5444 * fileio.c: Make symbols static if they're not exported.
5445 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5446 (Vwrite_region_annotation_buffers): Now static.
5448 * eval.c: Make symbols static if they're not exported.
5449 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5450 * lisp.h (backtrace_list): Remove decl.
5452 * emacs.c: Make symbols static if they're not exported.
5453 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5454 (fatal_error_code, fatal_error_signal_hook, standard_args):
5456 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5457 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5458 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5459 * lisp.h (fatal_error_signal_hook): Remove decl.
5460 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5462 * editfns.c: Move a (normally-unused) function to its only use.
5463 * editfns.c, lisp.h (get_operating_system_release): Remove.
5464 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5465 worth the hassle of breaking this out.
5467 * xterm.c: Make symbols static if they're not exported.
5468 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5469 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5470 (x_destroy_window, x_delete_display):
5472 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5473 (x_mouse_leave): Remove; unused.
5474 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5475 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5476 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5478 (x_mouse_leave): Declare only if WINDOWSNT.
5479 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5480 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5483 * ftxfont.c: Make symbols static if they're not exported.
5484 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5486 * font.h (ftxfont_driver): Likewise.
5488 * xfns.c: Make symbols static if they're not exported.
5489 (x_last_font_name, x_display_info_for_name):
5490 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5491 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5492 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5493 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5494 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5495 (last_show_tip_args): Now static.
5496 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5497 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5498 (x_screen_planes): Remove; unused.
5499 * dispextern.h (x_screen_planes): Remove decl.
5501 * dispnew.c: Make symbols static if they're not exported.
5502 * dispextern.h (redraw_garbaged_frames, scrolling):
5503 (increment_row_positions): Remove.
5504 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5505 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5507 (redraw_garbaged_frames): Remove; unused.
5509 * xfaces.c: Make symbols static if they're not exported.
5510 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5512 * xterm.h (defined_color): Remove decls.
5513 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5514 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5515 (menu_face_changed_default, defined_color, free_realized_face):
5516 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5517 (ascii_face_of_lisp_face): Remove; unused.
5519 * xdisp.c: Make symbols static if they're not exported.
5520 * dispextern.h (scratch_glyph_row, window_box_edges):
5521 (glyph_to_pixel_coords, set_cursor_from_row):
5522 (get_next_display_element, set_iterator_to_next):
5523 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5524 (show_mouse_face): Remove decls
5525 * frame.h (message_buf_print): Likewise.
5526 * lisp.h (pop_message, set_message, check_point_in_composition):
5528 * xterm.h (set_vertical_scroll_bar): Likewise.
5529 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5530 (message_buf_print, scratch_glyph_row, displayed_buffer):
5531 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5532 (get_next_display_element, show_mouse_face, window_box_edges):
5533 (frame_to_window_pixel_xy, check_point_in_composition):
5534 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5535 (glyph_to_pixel_coords): Remove; unused.
5537 * dired.c (file_name_completion): Now static.
5539 * dbusbind.c (xd_in_read_queued_messages): Now static.
5541 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5542 * data.c (circular_list_error): Remove.
5544 * commands.h (last_point_position, last_point_position_buffer):
5545 (last_point_position_window): Remove decls.
5546 * keyboard.c: Make these variables static.
5548 * coding.h (coding, code_convert_region, encode_coding_gap):
5550 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5551 (iso_code_class, detect_coding, code_convert_region): Now static.
5552 (encode_coding_gap): Remove; unused.
5554 * chartab.c (chartab_chars, chartab_bits): Now static.
5556 * charset.h (charset_iso_8859_1): Remove decl.
5557 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5560 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5561 * ccl.c (Vccl_program_table): Now static.
5562 (check_ccl_update): Remove; unused.
5564 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5565 * category.h: ... from here.
5566 * category.c (check_category_table, set_category_set): Now static.
5568 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5569 * lisp.h: Remove these decls.
5571 * buffer.c (buffer_count): Remove unused var.
5573 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5574 so that it's not optimized away.
5575 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5576 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5577 exported only to the debugger.
5579 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5580 * atimer.h (run_all_atimers): Remove; not exported.
5582 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5583 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5584 was inaccessible from Lisp.
5585 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5586 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5588 alloc.c: Import and export fewer symbols, and remove unused items.
5589 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5591 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5592 it's not optimized away by whole-program optimization.
5593 (message_enable_multibyte, free_misc): Remove.
5594 (catchlist, handlerlist, mark_backtrace):
5595 Declare only if BYTE_MARK_STACK.
5596 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5597 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5598 (message_enable_multibyte): Remove decl.
5599 (free_misc, interval_free_list, float_block, float_block_index):
5600 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5601 (cons_free_list, last_marked_index):
5603 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5604 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5605 (mark_backtrace): Define only if BYTE_MARK_STACK.
5606 * xdisp.c (message_enable_multibyte): Now static.
5608 Declare Lisp_Object Q* variables to be 'static' if not exported.
5609 This makes it easier for human readers (and static analyzers)
5610 to see whether these variables are used from other modules.
5611 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5612 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5613 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5614 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5615 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5616 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5617 * xmenu.c, xselect.c:
5618 Declare Q* vars static if they are not used in other modules.
5619 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5620 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5621 Remove decls of unexported vars.
5622 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5624 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5626 Make Emacs functions such as Fatom 'static' by default.
5627 This makes it easier for human readers (and static analyzers)
5628 to see whether these functions can be called from other modules.
5629 DEFUN now defines a static function. To make the function external
5630 so that it can be used in other C modules, use the new macro DEFUE.
5631 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5632 (Finit_image_library):
5633 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5634 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5635 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5636 Remove decls, since these functions are now static.
5637 (Funintern, Fget_internal_run_time): New decls, since these functions
5638 were already external.
5640 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5641 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5642 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5643 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5644 * keyboard.c, keymap.c, lread.c:
5645 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5646 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5647 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5648 Mark functions with DEFUE instead of DEFUN,
5649 if they are used in other modules.
5650 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5651 decls for now-static functions.
5652 * buffer.h (Fdelete_overlay): Remove decl.
5653 * callproc.c (Fgetenv_internal): Mark as internal.
5654 * composite.c (Fremove_list_of_text_properties): Remove decl.
5655 (Fcomposition_get_gstring): New forward static decl.
5656 * composite.h (Fcomposite_get_gstring): Remove decl.
5657 * dired.c (Ffile_attributes): New forward static decl.
5658 * doc.c (Fdocumntation_property): New forward static decl.
5659 * eval.c (Ffetch_bytecode): New forward static decl.
5660 (Funintern): Remove extern decl; now in .h file where it belongs.
5661 * fileio.c (Fmake_symbolic_link): New forward static decl.
5662 * image.c (Finit_image_library): New forward static decl.
5663 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5664 * intervals.h (Fprevious_property_change):
5665 (Fremove_list_of_text_properties): Remove decls.
5666 * keyboard.c (Fthis_command_keys): Remove decl.
5667 (Fcommand_execute): New forward static decl.
5668 * keymap.c (Flookup_key): New forward static decl.
5669 (Fcopy_keymap): Now static.
5670 * keymap.h (Flookup_key): Remove decl.
5671 * process.c (Fget_process): New forward static decl.
5672 (Fprocess_datagram_address): Mark as internal.
5673 * syntax.c (Fsyntax_table_p): New forward static decl.
5674 (skip_chars): Remove duplicate decl.
5675 * textprop.c (Fprevious_property_change): New forward static decl.
5676 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5678 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5679 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5681 * editfns.c (Fformat): Remove unreachable code.
5683 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5685 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5688 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5690 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5691 when at ZV. (Bug#8487)
5693 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5695 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5697 * keyboard.c (parse_tool_bar_item): Likewise.
5698 * sound.c (sound_cleanup, alsa_close): Likewise.
5699 * termcap.c (tgetent): Likewise.
5700 * xfns.c (x_default_font_parameter): Likewise.
5701 * xsettings.c (read_and_apply_settings): Likewise.
5703 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5704 (overrun_check_free): Protoize.
5706 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5708 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5709 since callers should never pass a negative size.
5710 Change the signature to match that of plain 'read' and 'write'; see
5711 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5712 * lisp.h: Update prototypes of emacs_write and emacs_read.
5714 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5716 * xdisp.c (redisplay_window): Don't try to determine the character
5717 position of the scroll margin if the window start point w->startp
5718 is outside the buffer's accessible region. (Bug#8468)
5720 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5722 Fix write-region and its subroutines for buffers > 2GB.
5723 * fileio.c (a_write, e_write): Modify declaration of arguments and
5724 local variables to support buffers larger than 2GB.
5725 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5727 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5728 argument, local variables, and return value.
5730 * lisp.h: Update prototypes of emacs_write and emacs_read.
5732 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5734 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5736 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5738 Fix more problems found by GCC 4.6.0's static checks.
5740 * xdisp.c (vmessage): Use a better test for character truncation.
5742 * charset.c (load_charset_map): <, not <=, for optimization,
5743 and to avoid potential problems with integer overflow.
5744 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5745 * casetab.c (set_identity, shuffle): Likewise.
5746 * editfns.c (Fformat): Likewise.
5747 * syntax.c (skip_chars): Likewise.
5749 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5750 This also lets GCC 4.6.0 generate slightly better loop code.
5752 * callint.c (Fcall_interactively): <, not <=, for optimization.
5753 (Fcall_interactively): Count the number of arguments produced,
5754 not the number of arguments given. This is simpler and lets GCC
5755 4.6.0 generate slightly better code.
5757 * ftfont.c: Distingish more carefully between FcChar8 and char.
5758 The previous code passed unsigned char * to a functions like
5759 strlen and xstrcasecmp that expect char *, which does not
5760 conform to the C standard.
5761 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5762 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5763 char * when the C standard requires it.
5765 * keyboard.c (read_char): Remove unused var.
5767 * eval.c: Port to Windows vsnprintf (Bug#8435).
5769 (SIZE_MAX): Define if the headers do not.
5770 (verror): Do not give up if vsnprintf returns a negative count.
5771 Instead, grow the buffer. This ports to Windows vsnprintf, which
5772 does not conform to C99. Problem reported by Eli Zaretskii.
5773 Also, simplify the allocation scheme, by avoiding the need for
5774 calling realloc, and removing the ALLOCATED variable.
5776 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5778 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5779 But keep the doprint source code for now, as we might revamp it
5780 and use it again (Bug#8435).
5781 * lisp.h (doprnt): Remove.
5782 * Makefile.in (base_obj): Remove doprnt.o.
5783 * deps.mk (doprnt.o): Remove.
5785 error: Print 32- and 64-bit integers portably (Bug#8435).
5786 Without this change, on typical 64-bit hosts error ("...%d...", N)
5787 was used to print both 32- and 64-bit integers N, which relied on
5789 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5791 * lisp.h (error, verror): Mark as printf-like functions.
5792 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5793 Report overflow in size calculations when allocating printf buffer.
5794 Do not truncate output string at its first null byte.
5795 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5796 Truncate the output at a character boundary, since vsnprintf does not
5798 * charset.c (check_iso_charset_parameter): Convert internal
5799 character to string before calling 'error', since %c now has the
5801 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5802 overflow when computing char to be passed to 'error'. Do not
5803 pass Lisp_Object to 'error'; pass the integer instead.
5804 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5805 formatted with plain %d.
5807 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5809 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5811 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5813 * xterm.c (x_catch_errors): Remove duplicate declaration.
5815 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5817 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5819 2011-04-10 Jim Meyering <meyering@redhat.com>
5821 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5822 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5823 return ssize_t not "int", and use size_t as the buffer length.
5824 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5825 * gnutls.h: Update declarations.
5826 * process.c (read_process_output): Use ssize_t, to match.
5827 (send_process): Likewise.
5829 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5831 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5833 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5835 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5836 Use unsigned char, to match FcChar8 type definition.
5838 * xterm.c (handle_one_xevent):
5839 * xmenu.c (create_and_show_popup_menu):
5840 * xselect.c (x_decline_selection_request)
5841 (x_reply_selection_request): Avoid type-punned deref of X events.
5843 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5845 Fix some uses of `int' instead of EMACS_INT.
5846 * search.c (string_match_1, fast_string_match)
5847 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5848 (scan_buffer, find_next_newline_no_quit)
5849 (find_before_next_newline, search_command, Freplace_match)
5850 (Fmatch_data): Make some `int' variables be EMACS_INT.
5852 * xdisp.c (display_count_lines): 3rd argument and return value now
5853 EMACS_INT. All callers changed.
5854 (pint2hrstr): Last argument is now EMACS_INT.
5856 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5857 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5858 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5859 (decode_coding_utf_16, decode_coding_emacs_mule)
5860 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5861 (decode_coding_ccl, decode_coding_charset)
5862 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5863 (decode_coding_iso_2022, decode_coding_emacs_mule)
5864 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5865 <char_offset, last_offset>: Declare EMACS_INT.
5866 (encode_coding_utf_8, encode_coding_utf_16)
5867 (encode_coding_emacs_mule, encode_invocation_designation)
5868 (encode_designation_at_bol, encode_coding_iso_2022)
5869 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5870 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5872 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5873 (encode_invocation_designation): Last argument P_NCHARS is now
5875 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5876 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5878 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5881 * ccl.c (Fccl_execute_on_string): Declare some variables
5884 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5886 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5888 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5890 * process.c (Fformat_network_address): Doc fix.
5892 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5894 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5896 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5898 * keyboard.c (read_char): Call Lisp function help-form-show,
5899 instead of using internal_with_output_to_temp_buffer.
5900 (Qhelp_form_show): New var.
5901 (syms_of_keyboard): Use DEFSYM macro.
5903 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5905 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5907 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5909 * process.c (Flist_processes): Remove to Lisp.
5910 (list_processes_1): Delete.
5912 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5914 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5916 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5918 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5920 Fix more problems found by GCC 4.6.0's static checks.
5922 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5924 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5926 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5928 * xdisp.c (vmessage): Mark as a printf-like function.
5930 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5932 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5934 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5935 printf-like functions.
5936 (tiff_load): Add casts to remove these marks before passing them
5937 to system-supplied API.
5939 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5941 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5942 This avoids several warnings with gcc -Wstrict-overflow.
5943 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5944 directly, rather than having caller test rule sign. This avoids
5945 some unnecessary tests.
5946 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5947 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5948 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5950 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5951 (xfont_open): Avoid unnecessary tests.
5953 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5955 * composite.h, composite.c (composition_gstring_put_cache):
5956 Use EMACS_INT, not int, for length.
5958 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5959 breaking out part of COMPOSITION_DECODE_RULE.
5960 (COMPOSITION_DECODE_RULE): Use it.
5961 * composite.c (get_composition_id): Remove unused local vars,
5962 by using the new macro.
5964 * textprop.c (set_text_properties_1): Change while to do-while,
5965 since the condition is always true at first.
5967 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5968 (interval_deletion_adjustment): Return unsigned value.
5971 * process.c (list_processes_1, create_pty, read_process_output):
5972 (exec_sentinel): Remove vars that were set but not used.
5973 (create_pty): Remove unnecessary "volatile"s.
5974 (Fnetwork_interface_info): Avoid possibility of int overflow.
5975 (read_process_output): Do adaptive read buffering even if carryover.
5976 (read_process_output): Simplify nbytes computation if buffered.
5978 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5980 * syntax.c (scan_words): Remove var that was set but not used.
5981 (update_syntax_table): Use unsigned instead of int.
5983 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5984 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5985 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5987 * print.c (print_error_message): Avoid int overflow.
5989 * font.c (font_list_entities): Redo for clarity,
5990 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5992 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5993 (font_score): Avoid potential overflow in diff calculation.
5995 * fns.c (substring_both): Remove var that is set but not used.
5996 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5998 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6000 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6001 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6002 can always succeed if overflow has undefined behavior.
6004 * search.c (boyer_moore, wordify): Remove vars set but not used.
6005 (wordify): Omit three unnecessary tests.
6007 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6008 All callers changed. This avoids the need for an unused var.
6010 * casefiddle.c (casify_region): Remove var that is set but not used.
6012 * dired.c (file_name_completion): Remove var that is set but not used.
6014 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6016 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6017 (Finsert_file_contents): Remove unnecessary code checking fd.
6019 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6020 Check for integer overflow on size calculations.
6022 * buffer.c (Fprevious_overlay_change): Remove var that is set
6025 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6026 Remove vars that are set but not used.
6027 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6028 (timer_check_2): Mark vars as initialized.
6030 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6032 * image.c (lookup_image): Remove var that is set but not used.
6033 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6035 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6036 that are set but not used.
6038 * xfns.c (make_invisible_cursor): Don't return garbage
6039 if XCreateBitmapFromData fails (Bug#8410).
6041 * xselect.c (x_get_local_selection, x_handle_property_notify):
6042 Remove vars that are set but not used.
6044 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6045 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6047 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6048 Remove var that is set but not used.
6049 (scroll_bar_windows_size): Now size_t, not int.
6050 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6053 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6054 (map_tty_color) [!defined MSDOS]: Likewise.
6056 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6058 * coding.c: Remove vars that are set but not used.
6059 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6060 All callers changed.
6061 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6062 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6063 (decode_coding_charset): Remove vars that are set but not used.
6065 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6066 that is set but not used.
6068 * print.c (print_object): Remove var that is set but not used.
6070 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6071 The gnulib version avoids calling malloc in the usual case,
6072 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6073 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6074 * filelock.c (current_lock_owner): Likewise.
6075 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6076 * sysdep.c: Include allocator.h, careadlinkat.h.
6077 (emacs_no_realloc_allocator): New static constant.
6078 (emacs_readlink): New function.
6079 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6080 ../lib/careadlinkat.h.
6082 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6084 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6085 first non-nil return value).
6087 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6089 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6090 if not defined (Bug#8403).
6092 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6094 * xdisp.c (display_count_lines): Remove parameter `start',
6095 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6096 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6097 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6098 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6099 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6100 and thereabouts. All callers changed.
6101 (get_per_char_metric): Remove parameter `f', unused since
6102 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6104 2011-04-02 Jim Meyering <meyering@redhat.com>
6106 do not dereference NULL upon failed strdup
6107 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6108 (ns_get_family): Likewise.
6110 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6112 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6114 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6116 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6119 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6121 Add lexical binding.
6123 * window.c (Ftemp_output_buffer_show): New fun.
6124 (Fsave_window_excursion):
6125 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6127 * lread.c (lisp_file_lexically_bound_p): New function.
6128 (Fload): Bind Qlexical_binding.
6129 (readevalloop): Remove `evalfun' arg.
6130 Bind Qinternal_interpreter_environment.
6131 (Feval_buffer): Bind Qlexical_binding.
6132 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6134 (syms_of_lread): Declare `lexical-binding'.
6136 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6138 * keyboard.c (eval_dyn): New fun.
6139 (menu_item_eval_property): Use it.
6141 * image.c (parse_image_spec): Use Ffunctionp.
6143 * fns.c (concat, mapcar1): Accept byte-code-functions.
6145 * eval.c (Fsetq): Handle lexical vars.
6146 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6147 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6148 (FletX, Flet): Obey lexical binding.
6149 (Fcommandp): Handle closures.
6150 (Feval): New `lexical' arg.
6151 (eval_sub): New function extracted from Feval. Use it almost
6152 everywhere where Feval was used. Look up vars in lexical env.
6154 (Ffunctionp): Move from subr.el.
6155 (Ffuncall): Handle closures.
6156 (apply_lambda): Remove `eval_flags'.
6157 (funcall_lambda): Handle closures and new byte-code-functions.
6158 (Fspecial_variable_p): New function.
6159 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6160 but without exporting it to Lisp.
6162 * doc.c (Fdocumentation, store_function_docstring):
6163 * data.c (Finteractive_form): Handle closures.
6165 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6168 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6170 (exec_byte_code): New function extracted from Fbyte_code to handle new
6171 calling convention for byte-code-functions. Add new byte-codes.
6173 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6175 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6177 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6179 * xdisp.c (redisplay_internal): Fix prototype.
6181 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6183 * xdisp.c (SCROLL_LIMIT): New macro.
6184 (try_scrolling): Use it when setting scroll_limit.
6185 Limit scrolling to 100 screen lines.
6186 (redisplay_window): Even when falling back on "recentering",
6187 position point in the window according to scroll-conservatively,
6188 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6190 (try_scrolling): When point is above the window, allow searching
6191 as far as scroll_max, or one screenful, to compute vertical
6192 distance from PT to the scroll margin position. This prevents
6193 try_scrolling from unnecessarily failing when
6194 scroll-conservatively is set to a value slightly larger than the
6195 window height. Clean up the case of PT below the margin at bottom
6196 of window: scroll_max can no longer be INT_MAX. When aggressive
6197 scrolling is in use, don't let point enter the opposite scroll
6198 margin as result of the scroll.
6199 (syms_of_xdisp) <scroll-conservatively>: Document the
6200 threshold of 100 lines for never-recentering scrolling.
6202 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6204 * dispextern.h (move_it_by_lines):
6205 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6206 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6207 (message_log_check_duplicate): Remove parameters `prev_bol' and
6208 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6209 (redisplay_internal): Remove parameter `preserve_echo_area',
6210 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6212 * indent.c (Fvertical_motion):
6213 * window.c (window_scroll_pixel_based, Frecenter):
6214 Don't pass `need_y_p' to `move_it_by_lines'.
6216 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6218 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6219 steal a few bits to be more compact.
6220 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6221 Remove unneeded casts.
6223 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6225 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6227 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6228 binding" message (bug#7967).
6230 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6232 Fix more problems found by GCC 4.6.0's static checks.
6234 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6235 Remove unused local var.
6237 * editfns.c (Fmessage_box): Remove unused local var.
6239 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6240 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6241 Omit unused local vars.
6242 * window.c (shrink_windows): Omit unused local var.
6243 * menu.c (digest_single_submenu): Omit unused local var.
6244 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6245 Omit unused local var.
6247 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6248 Don't assume string length fits in int.
6249 (keyremap_step, read_key_sequence): Use size_t for sizes.
6250 (read_key_sequence): Don't check last_real_key_start redundantly.
6252 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6253 instead of alloca (Bug#8344).
6255 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6256 (Fbacktrace_frame): Don't assume nframes fits in int.
6258 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6260 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6263 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6265 * cm.c (calccost): Turn while-do into do-while, for clarity.
6267 * keyboard.c (syms_of_keyboard): Use the same style as later
6268 in this function when indexing through an array. This also
6269 works around GCC bug 48267.
6271 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6273 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6275 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6276 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6278 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6279 This avoids undefined behavior on integer overflow, and is a bit
6280 more convenient anyway since it is compared to a size_t variable.
6282 Variadic C functions now count arguments with size_t, not int.
6283 This avoids an unnecessary limitation on 64-bit machines, which
6284 caused (substring ...) to crash on large vectors (Bug#8344).
6285 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6286 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6287 All variadic functions and their callers changed accordingly.
6288 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6289 * data.c (arith_driver, float_arith_driver): Likewise.
6290 * editfns.c (general_insert_function): Likewise.
6291 * eval.c (struct backtrace.nargs, interactive_p)
6292 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6293 (funcall_lambda, mark_backtrace): Likewise.
6294 * fns.c (concat): Likewise.
6295 * frame.c (x_set_frame_parameters): Likewise.
6296 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6297 0 if not found, not -1. All callers changed.
6299 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6300 (stack_copy_size): Now size_t, not int.
6301 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6303 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6305 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6306 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6307 All callers changed.
6309 * lisp.h (multibyte_char_to_unibyte):
6310 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6311 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6312 * character.h (CHAR_TO_BYTE8):
6313 * cmds.c (internal_self_insert):
6314 * editfns.c (general_insert_function):
6315 * keymap.c (push_key_description):
6316 * search.c (Freplace_match):
6317 * xdisp.c (message_dolog, set_message_1): All callers changed.
6319 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6321 * keyboard.c (safe_run_hook_funcall): New function.
6322 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6323 don't set the hook to nil, but remove the offending function instead.
6324 (Qcommand_hook_internal): Remove, unused.
6325 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6326 Vcommand_hook_internal.
6328 * eval.c (enum run_hooks_condition): Remove.
6329 (funcall_nil, funcall_not): New functions.
6330 (run_hook_with_args): Call each function through a `funcall' argument.
6331 Remove `cond' argument, now redundant.
6332 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6333 (Frun_hook_with_args_until_failure): Adjust accordingly.
6334 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6336 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6338 * dispextern.h (string_buffer_position): Remove declaration.
6340 * print.c (strout): Remove parameter `multibyte', unused since
6341 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6343 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6344 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6345 All callers changed.
6347 * w32.c (_wsa_errlist): Use braces for struct initializers.
6349 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6350 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6351 All callers changed.
6352 (string_buffer_position): Likewise. Also, make static (it's never
6353 used outside xdisp.c).
6354 (cursor_row_p): Remove parameter `w', unused since
6355 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6356 (decode_mode_spec): Remove parameter `precision', introduced during
6357 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6358 All callers changed.
6360 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6362 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6364 2011-03-27 Anders Lindgren <andlind@gmail.com>
6366 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6367 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6368 (ns_update_auto_hide_menu_bar): New functions.
6369 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6370 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6371 ns_constrain_all_frames.
6372 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6373 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6375 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6377 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6379 2011-03-27 Glenn Morris <rgm@gnu.org>
6381 * syssignal.h: Replace RETSIGTYPE with void.
6382 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6383 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6384 Replace SIGTYPE with void everywhere.
6385 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6386 * s/template.h (SIGTYPE): Remove commented out definition.
6388 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6390 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6391 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6393 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6395 * w32.c (read_unc_volume): Use parameter `henum', instead of
6396 global variable `wget_enum_handle'.
6398 * keymap.c (describe_vector): Remove parameters `indices' and
6399 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6400 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6402 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6404 * keyboard.c (timer_check): Remove parameter `do_it_now',
6405 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6406 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6407 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6409 * keyboard.c (read_char):
6410 * w32menu.c (w32_menu_display_help):
6411 * xmenu.c (show_help_event, menu_help_callback):
6412 Adjust calls to `show_help_echo'.
6414 * gtkutil.c (xg_maybe_add_timer):
6415 * keyboard.c (readable_events):
6416 * process.c (wait_reading_process_output):
6417 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6419 * insdel.c (adjust_markers_gap_motion):
6420 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6421 (gap_left, gap_right): Don't call it.
6423 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6425 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6426 incurred during fontification.
6428 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6430 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6431 (DEFVAR_PER_BUFFER): Don't pass it.
6433 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6434 (scrolling_window): Don't pass it.
6436 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6438 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6440 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6442 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6443 of variables specific to SELinux and computation of `encoded_absname'.
6445 * image.c (XPutPixel): Remove unused variable `height'.
6447 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6449 * unexw32.c (get_section_info): Remove unused variable `section'.
6451 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6452 (system_process_attributes): Remove unused variable `sess'.
6453 (sys_read): Remove unused variable `err'.
6455 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6456 (w32_wnd_proc): Remove unused variable `isdead'.
6457 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6458 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6459 (x_create_tip_frame): Remove unused variable `tem'.
6461 * w32inevt.c (w32_console_read_socket):
6462 Remove unused variable `no_events'.
6464 * w32term.c (x_draw_composite_glyph_string_foreground):
6465 Remove unused variable `width'.
6467 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6469 * w32term.c (x_set_glyph_string_clipping):
6470 Don't pass uninitialized region to CombineRgn.
6472 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6474 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6475 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6476 (Fx_close_connection): Remove unused variable `i'.
6478 * w32font.c (w32font_draw): Return number of glyphs.
6479 (w32font_open_internal): Remove unused variable `i'.
6480 (w32font_driver): Add missing initializer.
6482 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6483 (fill_in_menu): Remove unused variable `items_added'.
6485 * w32term.c (last_mouse_press_frame): Remove static global variable.
6486 (w32_clip_to_row): Remove unused variable `f'.
6487 (x_delete_terminal): Remove unused variable `i'.
6489 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6490 (NOTHING): Remove unused static global variable.
6491 (uniscribe_check_otf): Remove unused variable `table'.
6492 (uniscribe_font_driver): Add missing initializers.
6494 2011-03-23 Julien Danjou <julien@danjou.info>
6496 * term.c (Fsuspend_tty, Fresume_tty):
6497 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6498 * window.c (temp_output_buffer_show):
6499 * insdel.c (signal_before_change):
6500 * frame.c (Fhandle_switch_frame):
6501 * fileio.c (Fdo_auto_save):
6502 * emacs.c (Fkill_emacs):
6503 * editfns.c (save_excursion_restore):
6504 * cmds.c (internal_self_insert):
6505 * callint.c (Fcall_interactively):
6506 * buffer.c (Fkill_all_local_variables):
6507 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6509 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6510 unconditionnaly since it does the check itself.
6512 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6514 Fix more problems found by GCC 4.5.2's static checks.
6516 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6517 the first time through the loop, since we know p0 < p1 then.
6518 This also avoids a gcc -Wstrict-overflow warning.
6520 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6521 leading to a memory leak, possible in functions like
6522 load_charset_map_from_file that can allocate an unbounded number
6523 of objects (Bug#8318).
6525 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6526 that could (at least in theory) be that large.
6528 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6529 This is less likely to overflow, and avoids undefined behavior if
6530 overflow does occur. All callers changed. Use strtoul to scan
6531 for the unsigned long integer.
6532 (pint2hrstr): Simplify and tune code slightly.
6533 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6535 * scroll.c (do_scrolling): Work around GCC bug 48228.
6536 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6538 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6539 This also avoids a warning with gcc -Wstrict-overflow.
6540 (validate_x_resource_name): Simplify count usage.
6541 This also avoids a warning with gcc -Wstrict-overflow.
6543 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6546 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6548 * process.c (Fmake_network_process): Use socklen_t, not int,
6549 where POSIX says socklen_t is required in portable programs.
6550 This fixes a porting bug on hosts like 64-bit HP-UX, where
6551 socklen_t is wider than int (Bug#8277).
6552 (Fmake_network_process, server_accept_connection):
6553 (wait_reading_process_output, read_process_output):
6556 * process.c: Rename or move locals to avoid shadowing.
6557 (list_processes_1, Fmake_network_process):
6558 (read_process_output_error_handler, exec_sentinel_error_handler):
6559 Rename or move locals.
6560 (Fmake_network_process): Define label "retry_connect" only if needed.
6561 (Fnetwork_interface_info): Fix pointer signedness.
6562 (process_send_signal): Add cast to avoid pointer signedness problem.
6563 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6564 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6566 Make tparam.h and terminfo.c consistent.
6567 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6568 Include tparam.h instead, since it declares them.
6569 * cm.h (PC): Remove extern decl; tparam.h now does this.
6570 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6571 * terminfo.c: Include tparam.h, to check interfaces.
6572 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6573 (tparam): Adjust signature to match interface in tparam.h;
6574 this removes some undefined behavior. Check that outstring and len
6575 are zero, which they always are with Emacs.
6576 * tparam.h (PC, BC, UP): New extern decls.
6578 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6579 (xftfont_open): Rename locals to avoid shadowing.
6581 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6582 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6583 (OTF_TAG_SYM): Omit macro if not needed.
6584 (ftfont_list): Remove unused local.
6585 (get_adstyle_property, ftfont_pattern_entity):
6586 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6587 Rename locals to avoid shadowing.
6589 * xfont.c (xfont_list_family): Mark var as initialized.
6591 * xml.c (make_dom): Now static.
6593 * composite.c (composition_compute_stop_pos): Rename local to
6595 (composition_reseat_it): Remove unused locals.
6596 (find_automatic_composition, composition_adjust_point): Likewise.
6597 (composition_update_it): Mark var as initialized.
6598 (find_automatic_composition): Mark vars as initialized,
6599 with a FIXME (Bug#8290).
6601 character.h: Rename locals to avoid shadowing.
6602 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6603 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6604 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6605 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6608 * textprop.c (property_change_between_p): Remove; unused.
6610 * intervals.c (interval_start_pos): Now static.
6612 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6614 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6615 Rename locals to avoid shadowing.
6617 * sound.c (wav_play, au_play, Fplay_sound_internal):
6618 Fix pointer signedness.
6619 (alsa_choose_format): Remove unused local var.
6620 (wav_play): Initialize a variable to 0, to prevent undefined
6621 behavior (Bug#8278).
6623 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6625 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6627 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6628 clobbering (Bug#8298).
6629 * sysdep.c (sys_subshell): Likewise.
6630 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6632 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6633 This should get cleaned up, so that child_setup has the
6634 same signature on all platforms.
6636 * callproc.c (call_process_cleanup): Now static.
6637 (relocate_fd): Rename locals to avoid shadowing.
6639 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6641 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6642 not to be necessary, and produces flickering.
6644 2011-03-20 Glenn Morris <rgm@gnu.org>
6646 * config.in: Remove file.
6648 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6650 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6651 are now in src/globals.h.
6652 (syms_of_minibuf): Remove spurious & from previous change.
6654 2011-03-20 Leo <sdl.web@gmail.com>
6656 * minibuf.c (completing-read-function): New variable.
6657 (completing-read-default): Rename from completing-read.
6658 (completing-read): Call completing-read-function.
6660 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6662 * xfaces.c (Fx_load_color_file):
6663 Read color file from absolute filename (bug#8250).
6665 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6667 * makefile.w32-in: Update dependencies.
6669 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6671 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6673 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6675 Fix more problems found by GCC 4.5.2's static checks.
6677 * process.c (make_serial_process_unwind, send_process_trap):
6678 (sigchld_handler): Now static.
6680 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6681 That way, the code declares only the vars that it needs.
6682 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6683 * s/cygwin.h (PTY_ITERATION): Likewise.
6684 * s/darwin.h (PTY_ITERATION): Likewise.
6685 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6687 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6688 * process.c (allocate_pty): Don't declare stb unless it's needed.
6690 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6691 (CONSTANTLIM): Remove; unused.
6692 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6693 Define only if needed.
6695 * unexelf.c (unexec): Name an expression,
6696 to avoid gcc -Wbad-function-cast warning.
6697 Use a different way to cause a compilation error if anyone uses
6698 n rather than nn, a way that does not involve shadowing.
6699 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6701 * deps.mk (unexalpha.o): Remove; unused.
6703 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6704 * unexec.h: New file.
6705 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6706 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6708 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6709 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6710 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6711 Change as necessary to match prototype in unexec.h.
6713 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6715 (back_comment, skip_chars): Mark vars as initialized.
6717 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6718 Rename locals to avoid shadowing.
6720 * lread.c (read1): Rewrite so as not to use empty "else".
6721 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6723 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6725 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6726 warning when compiling print.c.
6728 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6729 instead of using an uninitialized var.
6730 (font_sort_entities): Mark var as initialized.
6732 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6734 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6735 pointers to constants.
6736 (font_parse_fcname): Remove unused vars.
6737 (font_delete_unmatched): Now static.
6738 (font_get_spec): Remove; unused.
6739 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6740 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6741 Rename or move locals to avoid shadowing.
6743 * fns.c (require_nesting_list, require_unwind): Now static.
6744 (Ffillarray): Rename locals to avoid shadowing.
6746 * floatfns.c (domain_error2): Define only if needed.
6747 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6749 * alloc.c (mark_backtrace): Move decl from here ...
6750 * lisp.h: ... to here, so that it can be checked.
6752 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6753 (Fdefvar): Rewrite so as not to use empty "else".
6754 (lisp_indirect_variable): Name an expression,
6755 to avoid gcc -Wbad-function-cast warning.
6756 (Fdefvar): Rename locals to avoid shadowing.
6758 * callint.c (quotify_arg, quotify_args): Now static.
6759 (Fcall_interactively): Rename locals to avoid shadowing.
6760 Use const pointer when appropriate.
6762 * lisp.h (get_system_name, get_operating_system_release):
6763 Move decls here, to check interfaces.
6764 * process.c (get_operating_system_release): Move decl to lisp.h.
6765 * xrdb.c (get_system_name): Likewise.
6766 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6767 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6768 some of which prompt warnings from gcc -Wbad-function-cast.
6769 (Fformat_time_string, Fencode_time, Finsert_char):
6770 (Ftranslate_region_internal, Fformat):
6771 Rename or remove local vars to avoid shadowing.
6772 (Ftranslate_region_internal): Mark var as initialized.
6774 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6777 * lisp.h (eassert): Check that the argument compiles, even if
6778 ENABLE_CHECKING is not defined.
6780 * data.c (Findirect_variable): Name an expression, to avoid
6781 gcc -Wbad-function-cast warning.
6782 (default_value, arithcompare, arith_driver, arith_error): Now static.
6783 (store_symval_forwarding): Rename local to avoid shadowing.
6784 (Fmake_variable_buffer_local, Fmake_local_variable):
6785 Mark variables as initialized.
6786 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6788 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6789 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6790 Rename locals to avoid shadowing.
6791 (mark_stack): Move local variables into the #ifdef region where
6793 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6794 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6796 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6797 (GC_STRING_CHARS): Remove; not used.
6798 (Fmemory_limit): Cast sbrk's returned value to char *.
6800 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6801 avoids undefined behavior in theory.
6803 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6805 Use functions, not macros, for up- and down-casing (Bug#8254).
6806 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6807 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6808 to use the following functions instead of these macros.
6809 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6810 EMACS_INT, since callers assume the returned value fits in int.
6811 (upcase1): Likewise, for UPCASE_TABLE.
6812 (uppercasep, lowercasep, upcase): New static inline functions.
6813 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6814 the race-condition problem in the old DOWNCASE.
6816 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6817 Rename locals to avoid shadowing.
6818 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6819 (regex_compile, re_search_2, re_match_2_internal):
6820 Remove unused local vars.
6821 (FREE_VAR): Rewrite so as not to use empty "else",
6822 which gcc can warn about.
6823 (regex_compile, re_match_2_internal): Mark locals as initialized.
6824 (RETALLOC_IF): Define only if needed.
6825 (WORDCHAR_P): Likewise. This one is never needed, but is used
6826 only in a comment talking about a compiler bug, so put inside
6827 the #if 0 of that comment.
6828 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6829 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6832 * search.c (boyer_moore): Rename locals to avoid shadowing.
6833 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6834 (PREV_CHAR_BOUNDARY): Likewise.
6836 * search.c (simple_search): Remove unused var.
6838 * dired.c (compile_pattern): Move decl from here ...
6839 * lisp.h: ... to here, so that it can be checked.
6840 (struct re_registers): New forward decl.
6842 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6844 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6846 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6847 Rename locals to avoid shadowing.
6848 (Fvertical_motion): Mark locals as initialized.
6850 * casefiddle.c (casify_object, casify_region): Now static.
6851 (casify_region): Mark local as initialized.
6853 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6855 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6856 New macros, so that the caller can use some names other than
6857 gcpro1, gcpro2, etc.
6858 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6860 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6861 argument, for consistency with GCPRO2_VAR, etc: it is now the
6862 prefix of the variable, not the variable itself. All uses
6864 * dired.c (directory_files_internal, file_name_completion):
6865 Rename locals to avoid shadowing.
6867 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6868 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6869 dired.c's scmp function, had undefined behavior.
6870 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6871 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6872 * buffer.h: ... to here, because these macros use current_buffer,
6873 and the new implementation with inline functions needs to have
6874 current_buffer in scope now, rather than later when the macros
6876 (downcase, upcase1): New static inline functions.
6877 (DOWNCASE, UPCASE1): Reimplement using these functions.
6878 This avoids undefined behavior in expressions like
6879 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6880 from race conditions in accessing the global variables
6881 case_temp1 and case_temp2.
6882 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6883 * lisp.h (case_temp1, case_temp2): Remove their decls.
6884 * character.h (ASCII_CHAR_P): Move from here ...
6885 * lisp.h: ... to here, so that the inline functions mentioned
6888 * dired.c (directory_files_internal_unwind): Now static.
6890 * fileio.c (file_name_as_directory, directory_file_name):
6891 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6893 (file_name_as_directory): Use const pointers when appropriate.
6894 (Fexpand_file_name): Likewise. In particular, newdir might
6895 point at constant storage, so make it a const pointer.
6896 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6897 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6899 (Fset_file_times, Finsert_file_contents, auto_save_error):
6900 Rename locals to avoid shadowing.
6902 * minibuf.c (choose_minibuf_frame_1): Now static.
6903 (Ftry_completion, Fall_completions): Rename or remove locals
6906 * marker.c (bytepos_to_charpos): Remove; unused.
6908 * lisp.h (verify_bytepos, count_markers): New decls,
6909 so that gcc does not warn that these functions aren't declared.
6911 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6912 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6913 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6914 (copy_text): Remove unused local var.
6916 * filelock.c (within_one_second): Now static.
6917 (lock_file_1): Rename local to avoid shadowing.
6919 * buffer.c (fix_overlays_before): Mark locals as initialized.
6920 (fix_start_end_in_overlays): Likewise. This function should be
6921 simplified by using pointers-to-pointers, but that's a different
6923 (switch_to_buffer_1): Now static.
6924 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6925 (report_overlay_modification): Rename locals to avoid shadowing.
6927 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6928 Fix pointer signedness issue.
6929 (sys_subshell): Mark local as volatile if checking for lint,
6930 to suppress a gcc -Wclobbered warning that does not seem to be right.
6931 (MAXPATHLEN): Define only if needed.
6933 * process.c (serial_open, serial_configure): Move decls from here ...
6934 * systty.h: ... to here, so that they can be checked.
6936 * fns.c (get_random, seed_random): Move extern decls from here ...
6937 * lisp.h: ... to here, so that they can be checked.
6939 * sysdep.c (reset_io): Now static.
6940 (wait_for_termination_signal): Remove; unused.
6942 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6943 (copy_keymap_item, append_key, push_text_char_description):
6945 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6946 (DENSE_TABLE_SIZE): Remove; unused.
6947 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6948 (describe_map_tree):
6949 Rename locals to avoid shadowing.
6951 * keyboard.c: Declare functions static if they are not used elsewhere.
6952 (echo_char, echo_dash, cmd_error, top_level_2):
6953 (poll_for_input, handle_async_input): Now static.
6954 (read_char, kbd_buffer_get_event, make_lispy_position):
6955 (make_lispy_event, make_lispy_movement, apply_modifiers):
6956 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6957 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6958 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6959 (read_key_sequence, read_char): Mark locals as initialized.
6960 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6962 * keyboard.h (make_ctrl_char): New decl.
6963 (mark_kboards): Move decl here ...
6964 * alloc.c (mark_kboards): ... from here.
6966 * lisp.h (force_auto_save_soon): New decl.
6968 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6969 (DEFINE_DUMMY_FUNCTION): New macro.
6970 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6972 (main): Add casts to avoid warnings
6973 if GCC considers string literals to be constants.
6975 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6977 * dbusbind.c: Pointer signedness fixes.
6978 (xd_signature, xd_append_arg, xd_initialize):
6979 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6980 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6981 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6982 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6984 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6985 if GCC considers string literals to be constants.
6986 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6988 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6990 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6991 (print_preprocess, print_object): New macro to fix last change.
6993 * print.c (print_preprocess): Don't forget font objects.
6995 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6997 * emacs.c (USAGE3): Doc fixes.
6999 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7001 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7004 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7006 * lisp.h (VWindow_system, Qfile_name_history):
7007 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7008 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7009 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7011 * w32select.c: Don't #include "keyboard.h".
7012 (run_protected): Add extern declaration for waiting_for_input.
7014 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7015 * w32console.c (detect_input_pending, read_input_pending)
7016 (encode_terminal_code):
7017 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7018 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7019 (w32_system_caret_y, Qfile_name_history):
7020 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7021 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7022 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7023 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7024 * w32proc.c (Qlocal, report_file_error):
7025 * w32term.c (Vwindow_system, updating_frame):
7026 * w32uniscribe.c (initialized, uniscribe_font_driver):
7027 Remove unneeded extern declarations.
7029 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7031 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7033 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7035 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7036 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7037 These macros can no longer be used for assignment.
7039 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7040 Assign struct members directly, instead of using BUF_BEGV etc.
7041 (record_buffer_markers, fetch_buffer_markers): New functions for
7042 recording and fetching special buffer markers.
7043 (set_buffer_internal_1, set_buffer_temp): Use them.
7045 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7047 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7049 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7050 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7052 * xdisp.c (hscroll_window_tree):
7053 (reconsider_clip_changes): Use PT instead of BUF_PT.
7055 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7057 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7058 $(EMACS_ROOT)/lib/intprops.h.
7060 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7062 Fix more problems found by GCC 4.5.2's static checks.
7064 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7065 to unsigned char * to avoid compiler diagnostic.
7066 (xg_free_frame_widgets): Make it clear that a local variable is
7067 needed only if USE_GTK_TOOLTIP.
7068 (gdk_window_get_screen): Make it clear that this macro is needed
7069 only if USE_GTK_TOOLTIP.
7070 (int_gtk_range_get_value): New function, which avoids a diagnostic
7071 from gcc -Wbad-function-cast.
7072 (xg_set_toolkit_scroll_bar_thumb): Use it.
7073 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7074 diagnostic from gcc -Wbad-function-cast.
7075 (get_utf8_string, xg_get_file_with_chooser):
7076 Rename locals to avoid shadowing.
7077 (create_dialog): Move locals to avoid shadowing.
7079 * xgselect.c (xg_select): Remove unused var.
7081 * image.c (four_corners_best): Mark locals as initialized.
7082 (gif_load): Initialize transparent_p to zero (Bug#8238).
7083 Mark another local as initialized.
7084 (my_png_error, my_error_exit): Mark with NO_RETURN.
7086 * image.c (clear_image_cache): Now static.
7087 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7088 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7089 (x_edge_detection): Remove unnecessary cast that
7090 gcc -Wbad-function-cast diagnoses.
7091 (gif_load): Fix pointer signedness.
7092 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7093 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7095 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7097 Improve quality of tests for time stamp overflow.
7098 For example, without this patch (encode-time 0 0 0 1 1
7099 1152921504606846976) returns the obviously-bogus value (-948597
7100 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7101 reports time overflow. See
7102 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7103 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7104 * editfns.c: Include limits.h and intprops.h.
7105 (TIME_T_MIN, TIME_T_MAX): New macros.
7106 (time_overflow): Move earlier, to before first use.
7107 (hi_time, lo_time): New functions, for an accurate test for
7109 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7110 (Fget_internal_run_time): Don't assume time_t fits in int.
7111 (make_time): Use list2 instead of Fcons twice.
7112 (Fdecode_time): More accurate test for out-of-range times.
7113 (check_tm_member): New function.
7114 (Fencode_time): Use it, to test for out-of-range times.
7115 (lisp_time_argument): Don't rely on undefined left-shift and
7116 right-shift behavior when checking for time stamp overflow.
7118 * editfns.c (time_overflow): New function, refactoring common code.
7119 (Fformat_time_string, Fdecode_time, Fencode_time):
7120 (Fcurrent_time_string): Use it.
7122 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7123 * dired.c (make_time): Move to ...
7124 * editfns.c (make_time): ... here.
7125 * systime.h: Note the move.
7127 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7129 * fringe.c (update_window_fringes): Remove unused variables.
7131 * unexmacosx.c (copy_data_segment): Also copy __got section.
7134 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7136 * termcap.c [MSDOS]: Include "msdos.h".
7137 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7138 Constify `char *' arguments and their references according to
7139 prototypes in tparam.h.
7141 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7143 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7144 Adapt all references accordingly.
7146 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7148 2011-03-11 Tom Tromey <tromey@redhat.com>
7150 * buffer.c (syms_of_buffer): Remove obsolete comment.
7152 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7154 * termhooks.h (encode_terminal_code): Declare prototype.
7156 * msdos.c (encode_terminal_code): Don't declare prototype.
7158 * term.c (encode_terminal_code): Now external again, used by
7159 w32console.c and msdos.c.
7161 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7162 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7164 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7166 Fix some minor problems found by GCC 4.5.2's static checks.
7168 * fringe.c (update_window_fringes): Mark locals as initialized
7170 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7172 * alloc.c (mark_fringe_data): Move decl from here ...
7173 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7174 to check its interface.
7175 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7177 * fontset.c (free_realized_fontset): Now static.
7178 (Fset_fontset_font): Rename local to avoid shadowing.
7179 (fontset_font): Mark local as initialized.
7180 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7182 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7184 * xselect.c (x_disown_buffer_selections): Remove; not used.
7185 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7186 (x_own_selection, Fx_disown_selection_internal): Rename locals
7188 (x_handle_dnd_message): Remove local to avoid shadowing.
7190 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7191 so that the caller can use some name other than gcpro1.
7192 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7193 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7194 (Fx_backspace_delete_keys_p):
7195 Use them to avoid shadowing, and rename vars to avoid shadowing.
7196 (x_decode_color, x_set_name, x_window): Now static.
7197 (Fx_create_frame): Add braces to silence GCC warning.
7198 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7199 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7200 Remove unused locals.
7201 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7202 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7203 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7206 * xterm.h (x_mouse_leave): New decl.
7208 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7209 Remove unused functions.
7210 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7211 (x_calc_absolute_position): Now static.
7212 (XTread_socket): Don't define label "out" unless it's used.
7213 Don't declare local "event" unless it's used.
7214 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7215 unless they are used.
7216 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7217 (x_fatal_error_signal): Remove; not used.
7218 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7219 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7220 (x_error_catcher, x_connection_closed, x_error_handler):
7221 (x_error_quitter, xembed_send_message, x_iconify_frame):
7222 (my_log_handler): Rename locals to avoid shadowing.
7223 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7224 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7226 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7227 Rename or move locals to avoid shadowing.
7228 (tty_defined_color, merge_face_heights): Now static.
7229 (free_realized_faces_for_fontset): Remove; not used.
7230 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7231 does not deduce is never used uninitialized.
7232 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7233 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7235 * terminal.c (store_terminal_param): Now static.
7237 * xmenu.c (menu_highlight_callback): Now static.
7238 (set_frame_menubar): Remove unused local.
7239 (xmenu_show): Rename parameter to avoid shadowing.
7240 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7241 since they might point to immutable storage.
7242 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7243 since it's unused otherwise.
7245 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7246 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7247 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7248 avoids a gcc -Wuninitialized diagnostic.
7249 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7250 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7251 does not deduce are never used uninitialized.
7253 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7255 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7256 * window.c (window_loop, size_window):
7257 (run_window_configuration_change_hook, enlarge_window): Likewise.
7259 * window.c (display_buffer): Now static.
7260 (size_window): Mark variables that gcc -Wuninitialized
7261 does not deduce are never used uninitialized.
7262 * window.h (check_all_windows): New decl, to forestall
7263 gcc -Wmissing-prototypes diagnostic.
7264 * dispextern.h (bidi_dump_cached_states): Likewise.
7266 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7268 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7270 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7271 and to avoid gcc -Wuninitialized warning.
7272 (load_charset_map): Mark variables that gcc -Wuninitialized
7273 does not deduce are never used uninitialized.
7274 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7276 * coding.c (coding_set_source, coding_set_destination):
7277 Use "else { /* comment */ }" rather than "else /* comment */;"
7278 for clarity, and to avoid gcc -Wempty-body warning.
7279 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7280 a block, when the outer 'i' will do.
7281 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7282 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7283 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7284 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7285 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7286 Rename locals to avoid shadowing.
7287 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7288 * coding.c (emacs_mule_char, encode_invocation_designation):
7289 Now static, since they're not used elsewhere.
7290 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7291 (decode_coding_object, encode_coding_object, detect_coding_system):
7292 (decode_coding_emacs_mule): Mark variables that gcc
7293 -Wuninitialized does not deduce are never used uninitialized.
7294 (detect_coding_iso_2022): Initialize a local variable that might
7295 be used uninitialized. Leave a FIXME because it's not clear that
7296 this initialization is needed. (Bug#8211)
7297 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7298 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7299 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7300 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7301 Remove unused macros.
7303 * category.c (hash_get_category_set): Remove unused local var.
7304 (copy_category_table): Now static, since it's not used elsewhere.
7305 * character.c (string_count_byte8): Likewise.
7307 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7308 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7310 * chartab.c (copy_sub_char_table): Now static, since it's not used
7312 (sub_char_table_ref_and_range, char_table_ref_and_range):
7313 Rename locals to avoid shadowing.
7314 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7316 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7317 (BIDI_BOB): Remove unused macro.
7319 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7320 deduce are never used uninitialized.
7321 * term.c (encode_terminal_code): Likewise.
7323 * term.c (encode_terminal_code): Now static. Remove unused local.
7325 * tparam.h: New file.
7326 * term.c, tparam.h: Include it.
7327 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7328 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7329 Move these decls to tparam.h, and make them agree with what
7330 is actually in tparam.c. The previous trick of using incompatible
7331 decls in different modules does not conform to the C standard.
7332 All callers of tparam changed to use tparam's actual API.
7333 * tparam.c (tparam1, tparam, tgoto):
7334 Use const pointers where appropriate.
7336 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7337 * cm.h (struct cm): Likewise.
7338 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7339 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7340 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7341 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7342 (turn_on_face, init_tty): Likewise.
7343 * termchar.h (struct tty_display_info): Likewise.
7345 * term.c (term_mouse_position): Rename local to avoid shadowing.
7347 * alloc.c (mark_ttys): Move decl from here ...
7348 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7350 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7352 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7354 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7356 * search.c (compile_pattern_1): Remove argument regp, unused since
7357 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7358 (compile_pattern): Don't pass it.
7360 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7362 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7363 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7365 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7367 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7369 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7370 gdk_window_get_screen, gdk_window_get_geometry,
7371 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7372 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7373 (xg_get_pixbuf_from_pixmap): New function.
7374 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7375 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7376 Call xg_get_pixbuf_from_pixmap instead of
7377 gdk_pixbuf_get_from_drawable.
7378 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7379 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7380 (xg_check_special_colors): Use GtkStyleContext and its functions
7382 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7383 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7384 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7385 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7386 Call gtk_widget_get_preferred_size.
7387 (xg_frame_resized): gdk_window_get_geometry only takes 5
7389 (xg_win_to_widget, xg_event_is_for_menubar):
7390 Call gdk_x11_window_lookup_for_display.
7391 (xg_set_widget_bg): New function.
7392 (delete_cb): New function.
7393 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7394 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7395 (xg_set_background_color): Call xg_set_widget_bg.
7396 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7397 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7398 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7399 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7401 (update_frame_tool_bar): Call gtk_widget_hide.
7402 (xg_initialize): Use GDK_KEY_g.
7404 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7406 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7408 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7409 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7410 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7412 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7414 * w32xfns.c (select_palette): Check success of RealizePalette against
7415 GDI_ERROR, not zero.
7417 See ChangeLog.11 for earlier changes.
7423 Copyright (C) 2011 Free Software Foundation, Inc.
7425 This file is part of GNU Emacs.
7427 GNU Emacs is free software: you can redistribute it and/or modify
7428 it under the terms of the GNU General Public License as published by
7429 the Free Software Foundation, either version 3 of the License, or
7430 (at your option) any later version.
7432 GNU Emacs is distributed in the hope that it will be useful,
7433 but WITHOUT ANY WARRANTY; without even the implied warranty of
7434 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7435 GNU General Public License for more details.
7437 You should have received a copy of the GNU General Public License
7438 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.