1 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3 * buffer.h: Include <sys/types.h> instead of <time.h>.
4 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5 Problem reported by Herbert J. Skuhra.
7 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
9 * xml.c (parse_region): Make the parsing work for
10 non-comment-starting XML files again (bug#9144).
12 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
14 * image.c (gif_load): Fix calculation of bottom and right corner.
17 2011-09-10 Eli Zaretskii <eliz@gnu.org>
19 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
20 redisplay in small windows.
22 2011-09-09 Eli Zaretskii <eliz@gnu.org>
24 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
26 2011-09-08 Martin Rudalics <rudalics@gmx.at>
28 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
29 Operate on live windows only.
31 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
33 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
35 2011-09-07 Eli Zaretskii <eliz@gnu.org>
37 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
38 only under bidi iteration.
40 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
42 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
44 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
46 isnan: Fix porting problem to Solaris 10 with bundled gcc.
47 Without this fix, the command to link temacs failed due to an
48 undefined symbol __builtin_isnan. This is because
49 /usr/include/iso/math_c99.h #defines isnan(x) to
50 __builtin_isnan(x), but the bundled gcc, which identifies itself
51 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
53 * floatfns.c (isnan): #undef, and then #define to a clone of
55 (Fisnan): Always define, since it's always available now.
56 (syms_of_floatfns): Always define isnan at the Lisp level.
58 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
60 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
62 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
64 * fileio.c: Fix bugs with large file offsets (Bug#9428).
65 The previous code assumed that file offsets (off_t values) fit in
66 EMACS_INT variables, which is not true on typical 32-bit hosts.
67 The code messed up by falsely reporting buffer overflow in cases
68 such as (insert-file-contents "big" nil 1 2) into an empty buffer
69 when "big" contains more than 2**29 bytes, even though this
70 inserts just one byte and does not overflow the buffer.
71 (Finsert_file_contents): Store file offsets as off_t
72 values, not as EMACS_INT values. Check for overflow when
73 converting between EMACS_INT and off_t. When checking for
74 buffer overflow or for overlap, take the offsets into account.
75 Don't use EMACS_INT for small values where int suffices.
76 When checking for overlap, fix a typo: ZV was used where
78 (Fwrite_region): Don't assume off_t fits into 'long'.
79 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
81 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
83 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
85 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
87 sprintf-related integer and memory overflow issues (Bug#9412).
89 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
90 (esprintf, exprintf, evxprintf): New functions.
91 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
92 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
93 (modify_event_symbol): Do not assume that the length of
94 name_alist_or_stem is safe to alloca and fits in int.
95 (Fexecute_extended_command): Likewise for function name and binding.
96 (Frecursion_depth): Wrap around reliably on integer overflow.
97 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
98 since some callers pass EMACS_INT values.
99 (Fsingle_key_description): Don't crash if symbol name contains more
100 than MAX_ALLOCA bytes.
101 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
102 (get_minibuffer): Arg is now EMACS_INT, not int.
103 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
104 (esprintf, exprintf, evxprintf): New decls.
105 * window.h (command_loop_level, minibuf_level): Reflect API changes.
107 * dbusbind.c (signature_cat): New function.
108 (xd_signature, Fdbus_register_signal):
109 Do not overrun buffer; instead, report string overflow.
111 * dispnew.c (add_window_display_history): Don't overrun buffer.
112 Truncate instead; this is OK since it's just a log.
114 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
115 even if the time zone offset is outlandishly large.
116 Don't mishandle offset == INT_MIN.
118 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
119 when creating daemon; the previous buffer-overflow check was incorrect.
121 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
122 which has the guts of the old verror function.
124 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
125 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
127 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
128 (font_unparse_xlfd): Don't blindly alloca long strings.
129 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
130 fits in int, when using sprintf. Use single snprintf to count
131 length of string rather than counting it via multiple sprintfs;
132 that's simpler and more reliable.
133 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
134 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
135 sprintf, in case result does not fit in int.
137 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
138 (fontset_from_font): Print it.
140 * frame.c (tty_frame_count): Now printmax_t, not int.
141 (make_terminal_frame, set_term_frame_name): Print it.
142 (x_report_frame_params): In X, window IDs are unsigned long,
143 not signed long, so print them as unsigned.
144 (validate_x_resource_name): Check for implausibly long names,
145 and don't assume name length fits in 'int'.
146 (x_get_resource_string): Don't blindly alloca invocation name;
147 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
150 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
151 (xg_check_special_colors, xg_set_geometry):
152 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
154 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
155 Use esprintf, not sprintf, in case result does not fit in int.
157 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
158 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
159 it as a large positive number.
160 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
161 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
163 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
164 in case result does not fit in int.
166 * print.c (float_to_string): Detect width overflow more reliably.
167 (print_object): Make sprintf buffer a bit bigger, to avoid potential
168 buffer overrun. Don't assume list length fits in 'int'. Treat
169 print length of 0 as 0, not as infinity; to be consistent with other
170 uses of print length in this function. Don't overflow print length
171 index. Don't assume hash table size fits in 'long', or that
172 vectorlike size fits in 'unsigned long'.
174 * process.c (make_process): Use printmax_t, not int, to format
175 process-name gensyms.
177 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
179 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
180 to avoid potential buffer overrun.
182 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
183 if X resource line is longer than 512 bytes.
185 * xfns.c (x_window): Make sprintf buffer a bit bigger
186 to avoid potential buffer overrun.
188 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
190 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
192 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
194 Integer overflow fixes for scrolling, etc.
195 Without these, Emacs silently mishandles large integers sometimes.
196 For example, "C-u 4294967297 M-x recenter" was treated as if
197 it were "C-u 1 M-x recenter" on a typical 64-bit host.
199 * xdisp.c (try_window_id): Check Emacs fixnum range before
202 * window.c (window_scroll_line_based, Frecenter):
203 Check that an Emacs fixnum is in range before assigning it to 'int'.
204 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
205 values converted from Emacs fixnums.
206 (Frecenter): Don't wrap around a line count if it is out of 'int'
207 range; instead, treat it as an extreme value.
208 (Fset_window_configuration, compare_window_configurations):
209 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
211 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
212 that can exceed INT_MAX. Check that EMACS_INT value is in range
213 before assigning it to the (possibly-narrower) index.
214 (match_limit): Don't assume that a fixnum can fit in 'int'.
216 * print.c (print_object): Use ptrdiff_t, not int, for index that can
219 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
220 (Fvertical_motion): Don't wrap around LINES values that don't fit
221 in 'int'. Instead, treat them as extreme values. This is good
222 enough for windows, which can't have more than INT_MAX lines anyway.
224 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
226 * Require libxml/parser.h to avoid compilation warning.
228 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
230 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
231 since this reportedly can destroy thread storage.
233 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
235 * syntax.c (find_defun_start): Update all cache variables if
236 exiting early (Bug#9401).
238 2011-08-30 Eli Zaretskii <eliz@gnu.org>
240 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
242 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
243 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
244 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
246 * term.c (tty_append_glyph): New function.
247 (produce_stretch_glyph): Static function and its prototype deleted.
249 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
252 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
254 * image.c (parse_image_spec): Check for nonnegative, not for positive,
255 when checking :margin (Bug#9390).
256 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
257 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
258 so that the name doesn't mislead. All uses changed.
260 2011-08-28 Johan Bockgård <bojohan@gnu.org>
262 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
265 2011-08-27 Eli Zaretskii <eliz@gnu.org>
267 * xdisp.c (move_it_to): Don't bail out early when reaching
268 position beyond to_charpos, if we are scanning backwards.
269 (move_it_vertically_backward): When DY == 0, make sure we get to
270 the first character in the line after the newline.
272 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
274 * ccl.c: Improve and simplify overflow checking (Bug#9196).
275 (ccl_driver): Do not generate an out-of-range pointer.
276 (Fccl_execute_on_string): Remove unnecessary check for
277 integer overflow, noted by Stefan Monnier in
278 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
279 Remove a FIXME that didn't need fixing.
280 Simplify the newly-introduced buffer reallocation code.
282 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
284 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
286 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
288 Integer and memory overflow issues (Bug#9196).
290 * doc.c (get_doc_string): Rework so that
291 get_doc_string_buffer_size is the actual buffer size, rather than
292 being 1 less than the actual buffer size; this makes xpalloc more
295 * image.c (x_allocate_bitmap_record, cache_image):
296 * xselect.c (Fx_register_dnd_atom):
297 Simplify previous changes by using xpalloc.
299 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
300 since either will do and ptrdiff_t is convenient with xpalloc.
302 * charset.c (charset_table_size)
303 (struct charset_sort_data.priority): Now ptrdiff_t.
304 (charset_compare): Don't overflow if priorities differ greatly.
305 (Fsort_charsets): Don't assume list length fits in int.
306 Check for size-calculation overflow when allocating sort data.
307 (syms_of_charset): Allocate an initial charset table that is
308 just under 64 KiB, to avoid problems with glibc malloc and mmap.
310 * cmds.c (internal_self_insert): Check for size-calculation overflow.
312 * composite.h (struct composition.glyph_len): Now int, not unsigned.
313 The actual value is always <= INT_MAX, and leaving it unsigned made
314 overflow checking harder.
316 * dispextern.h (struct glyph_matrix.rows_allocated)
317 (struct face_cache.size): Now ptrdiff_t, for convenience in use
318 with xpalloc. The values are still always <= INT_MAX.
320 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
322 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
323 (SAFE_NALLOCA): New macro.
325 * region-cache.c (struct boundary.pos, find_cache_boundary)
326 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
327 (set_cache_region, invalidate_region_cache)
328 (revalidate_region_cache, know_region_cache, region_cache_forward)
329 (region_cache_backward, pp_cache):
330 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
331 so that ptrdiff_t * can be passed to xpalloc.
332 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
333 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
334 (pp_cache): Don't assume cache_len fits in int.
335 * region-cache.h: Adjust extern decls to match.
337 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
338 EMACS_INT, since either will do, for xpalloc.
340 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
341 (xnmalloc, xnrealloc, xpalloc): New functions.
343 * bidi.c (bidi_shelve_header_size): New constant.
344 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
345 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
347 * bidi.c (bidi_cache_shrink):
348 * buffer.c (overlays_at, overlays_in, record_overlay_string)
350 Don't update size of array until after memory allocation succeeds,
351 because xmalloc/xrealloc may not return.
352 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
353 now that we have proper integer overflow checking.
354 (record_overlay_string, overlay_strings): Catch overflows when
355 calculating size of overlay_str_buf.
357 * callproc.c (Fcall_process): Check for size overflow when
358 calculating size of args2.
359 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
360 Normally we prefer signed values, but sticking with ptrdiff_t would
361 require adding more-complicated checks.
363 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
364 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
365 Redo buffer-overflow calculations to avoid integer overflow.
366 Add a FIXME comment where memory seems to be over-allocated.
368 * character.c (Fstring): Check for size-calculation overflow.
370 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
371 unnecessary integer overflow. Check for size overflow.
372 (encode_coding_object): Don't update size until xmalloc succeeds.
374 * composite.c (get_composition_id): Check for overflow in glyph
377 Integer and memory overflow fixes for display code.
378 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
379 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
380 (scrolling_window): Check for overflow in size calculations.
381 (line_draw_cost, realloc_glyph_pool, add_row_entry):
382 Don't assume glyph table len fits in int.
383 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
384 (row_table_size): Now ptrdiff_t, not int.
385 (scrolling_window): Avoid overflow in size calculations.
386 Don't update size until allocation succeeds.
387 * fns.c (concat): Check for overflow in size calculations.
388 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
389 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
390 (NEXT_ALMOST_PRIME_LIMIT): New constant.
392 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
393 (get_doc_string): Check for size calculation overflow.
394 Don't update size until allocation succeeds.
395 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
396 EMACS_INT, where ptrdiff_t will do.
397 (Fsubstitute_command_keys): Check for string overflow.
399 * editfns.c (set_time_zone_rule): Don't assume environment length
401 (message_length): Now ptrdiff_t, not int.
402 (Fmessage_box): Don't update size until allocation succeeds.
403 Don't assume message length fits in int.
404 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
406 * emacs.c (main): Do not reallocate argv, since there is a null at
407 the end that can be overwritten, and this way there's no need to
408 worry about size-calculation overflow.
409 (sort_args): Check for size-calculation overflow.
411 * eval.c (init_eval_once, grow_specpdl): Don't update size until
413 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
415 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
416 (x_set_scroll_bar_width, x_figure_window_size):
417 Check for integer overflow.
418 (x_set_alpha): Do not assume XINT fits in int.
420 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
421 This is for the members text_lines, text_cols, total_lines, total_cols,
422 where the system imposes an 'int' limit.
424 * fringe.c (Fdefine_fringe_bitmap):
425 Don't update size until alloc works.
427 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
428 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
430 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
431 Check for size-calculation overflow.
432 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
433 do, as we prefer signed integers.
434 (id_to_widget.max_size, id_to_widget.used)
435 (xg_store_widget_in_map, xg_remove_widget_from_map)
436 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
437 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
438 Use and return ptrdiff_t, not int.
439 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
440 * gtkutil.h: Change prototypes to match the above.
442 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
443 are duplicate now that they've been promoted to lisp.h.
444 (x_allocate_bitmap_record, x_alloc_image_color)
445 (make_image_cache, cache_image, xpm_load):
446 Don't update size until alloc is done.
447 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
449 Check for size calculation overflow.
450 (ct_colors_allocated_max): New constant.
451 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
454 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
455 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
456 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
457 Use ptrdiff_t, not int, to count maps.
458 (read_char_minibuf_menu_prompt): Check for overflow in size
459 calculations. Don't update size until allocation succeeds. Redo
460 calculations to avoid overflow.
461 * keyboard.h: Change prototypes to match the above.
463 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
465 (current_minor_maps): Check for size calculation overflow.
466 * keymap.h: Change prototypes to match the above.
468 * lread.c (read1, init_obarray): Don't update size until alloc done.
470 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
471 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
473 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
474 Now ptrdiff_t, not int.
475 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
476 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
478 * process.c (Fnetwork_interface_list): Check for overflow
481 * region-cache.c (move_cache_gap): Check for size calculation overflow.
483 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
484 overflow. Don't bother calling xmalloc when xrealloc will do.
486 * search.c (Freplace_match): Check for size calculation overflow.
487 (Fset_match_data): Don't assume list lengths fit in 'int'.
489 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
490 for command line length. Do not attempt to address one before the
491 beginning of an array, as that's not portable.
493 * term.c (max_frame_lines): Remove; unused.
494 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
496 (encode_terminal_code, calculate_costs): Check for size
497 calculation overflow.
498 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
499 table lengths and related sizes. Don't update size until alloc
500 done. Redo calculations to avoid overflow.
501 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
503 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
504 subtracting pointers.
505 (gobble_line): Check for overflow more carefully. Don't update size
508 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
509 Don't update size until alloc done.
510 Redo size calculations to avoid overflow.
511 Check for size calculation overflow.
512 (main) [DEBUG]: Fix typo in invoking tparam1.
514 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
515 Use ptrdiff_t, not int, for sizes.
516 (store_mode_line_noprop_char): Don't update size until alloc done.
518 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
519 Use ptrdiff_t, not int, for sizes.
520 (Finternal_make_lisp_face, cache_face):
521 Check for size calculation overflow.
522 (cache_face): Treat size calculation overflows as if they were
523 memory exhaustion (the usual treatment), rather than aborting.
525 * xfns.c (x_encode_text, x_set_name_internal)
526 (Fx_change_window_property): Use ptrdiff_t, not int, to count
527 sizes, since they can exceed INT_MAX in size. Check for size
528 calculation overflow.
530 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
531 (xg_select): Check for size calculation overflow.
532 Don't update size until alloc done.
534 * xrdb.c (get_environ_db): Don't assume path length fits in int,
535 as sprintf is limited to int lengths.
537 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
538 (X_LONG_MIN): New macros.
539 Use them to make the following changes clearer.
540 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
541 This change doesn't affect the value now, but it may help remind
542 future maintainers not to raise the value too much later.
543 (SELECTION_QUANTUM): Remove, replacing with ...
544 (selection_quantum): ... new function, which avoids overflow.
546 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
547 assumption that selection length fits in 'int'.
548 (x_reply_selection_request, x_handle_selection_request)
549 (x_get_window_property, receive_incremental_selection)
550 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
551 (lisp_data_to_selection_data, clean_local_selection_data):
552 Use ptrdiff_t, not int, to record length of selection.
553 (x_reply_selection_request, x_get_window_property)
554 (receive_incremental_selection, x_property_data_to_lisp):
555 Redo calculations to avoid overflow.
556 (x_reply_selection_request): When sending hint, ceiling it at
557 X_LONG_MAX rather than relying on wraparound overflow to send
559 (x_get_window_property, receive_incremental_selection)
560 (lisp_data_to_selection_data, x_property_data_to_lisp):
561 Check for size-calculation overflow.
562 (x_get_window_property, receive_incremental_selection)
563 (lisp_data_to_selection_data, Fx_register_dnd_atom):
564 Don't store size until memory allocation succeeds.
565 (x_get_window_property): Plug memory leak on memory exhaustion.
566 Don't double-block input; malloc is safe here. Don't assume 2**34
567 - 4 fits in unsigned long. Add an xassert to check
568 XGetWindowProperty overflow. Be more careful about overflow
569 calculations, and distinguish size from memory overflow better.
570 (receive_incremental_selection): When tracing, don't assume
571 unsigned int is less than INT_MAX.
572 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
573 harmful) conversions of unsigned short to int.
574 (lisp_data_to_selection_data): Don't assume that integers
575 in the range -65535 through -1 fit in an X unsigned short.
576 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
577 result parameters unless successful. Rely on cons_to_unsigned
578 to report problems with elements; the old code wasn't right anyway.
579 (x_check_property_data): Check for int overflow; we cannot use
580 a wider type due to X limits.
581 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
583 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
585 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
586 (x_term_init): Check for size calculation overflow.
587 (x_color_cells): Don't store size until memory allocation succeeds.
588 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
589 Don't assume alloca size is less than MAX_ALLOCA.
590 (x_term_init): Don't assume length fits in int (sprintf is limited
593 Use ptrdiff_t for composition IDs.
594 * character.c (lisp_string_width):
595 * composite.c (composition_table_size, n_compositions)
596 (get_composition_id, composition_gstring_from_id):
597 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
598 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
599 * window.c (Frecenter):
600 Use ptrdiff_t, not int, for composition IDs.
601 * composite.c (get_composition_id): Check for integer overflow.
602 * composite.h: Adjust prototypes to match the above changes.
604 Use ptrdiff_t for hash table indexes.
605 * category.c (hash_get_category_set):
606 * ccl.c (ccl_driver):
607 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
608 * coding.c (coding_system_charset_list, detect_coding_system):
609 * coding.h (struct coding_system.id):
610 * composite.c (get_composition_id, gstring_lookup_cache):
611 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
612 * image.c (xpm_get_color_table_h):
613 * lisp.h (hash_lookup, hash_put):
614 * minibuf.c (Ftest_completion):
615 Use ptrdiff_t for hash table indexes, not int (which is too
616 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
617 32-bit --with-wide-int hosts).
619 * charset.c (Fdefine_charset_internal): Check for integer overflow.
620 Add a FIXME comment about memory leaks.
621 (syms_of_charset): Don't assume xmalloc returns.
623 Don't assume that stated character widths fit in int.
624 * character.c (Fchar_width, c_string_width, lisp_string_width):
625 * character.h (CHAR_WIDTH):
626 * indent.c (MULTIBYTE_BYTES_WIDTH):
627 Use sanitize_char_width to avoid undefined and/or bad behavior
628 with outlandish widths.
629 * character.h (sanitize_tab_width): Renamed from sanitize_width,
630 now that we have two such functions. All uses changed.
631 (sanitize_char_width): New inline function.
633 Don't assume that tab-width fits in int.
634 * character.h (sanitize_width): New inline function.
635 (SANE_TAB_WIDTH): New macro.
636 (ASCII_CHAR_WIDTH): Use it.
637 * indent.c (sane_tab_width): Remove. All uses replaced by
638 SANE_TAB_WIDTH (current_buffer).
639 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
641 * fileio.c: Integer overflow issues with file modes.
642 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
644 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
645 Remove unreachable code.
646 (read_hex, load_charset_map_from_file): Check for integer overflow.
648 * xterm.c: don't go over XClientMessageEvent limit
649 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
650 (x_send_scroll_bar_event): Likewise. Check that the size does not
651 exceed limits imposed by XClientMessageEvent, as well as the usual
652 ptrdiff_t and size_t limits.
654 * keyboard.c: Overflow, signedness and related fixes.
655 (make_lispy_movement): Use same integer type in forward decl
656 that is used in the definition.
657 (read_key_sequence, keyremap_step):
658 Change bufsize argument back to int, undoing my 2011-03-30 change.
659 We prefer signed types, and int is wide enough here.
660 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
661 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
662 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
663 length, not size_t. Use ptrdiff_t for index, not int.
664 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
665 possibility of integer overflow.
667 Overflow, signedness and related fixes for images.
669 * dispextern.h (struct it.stack[0].u.image.image_id)
670 (struct_it.image_id, struct image.id, struct image_cache.size)
671 (struct image_cache.used, struct image_cache.ref_count):
672 * gtkutil.c (update_frame_tool_bar):
673 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
674 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
675 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
676 * nsmenu.m (update_frame_tool_bar):
677 * xdisp.c (calc_pixel_width_or_height):
678 * xfns.c (image_cache_refcount):
679 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
680 on typical 64-bit hosts.
682 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
683 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
684 Omit unnecessary casts to int.
685 (parse_image_spec): Check that integers fall into 'int' range
686 when the callers expect that.
687 (image_ascent): Redo ascent calculation to avoid int overflow.
688 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
689 (lookup_image): Remove unnecessary tests.
690 (xbm_image_p): Locals are now of int, not EMACS_INT,
691 since parse_image_check makes sure they fit into int.
692 (png_load, gif_load, svg_load_image):
693 Prefer int to unsigned where either will do.
694 (tiff_handler): New function, combining the cores of the
695 old tiff_error_handler and tiff_warning_handler. This
696 function is rewritten to use vsnprintf and thereby avoid
697 stack buffer overflows. It uses only the features of vsnprintf
698 that are common to both POSIX and native Microsoft.
699 (tiff_error_handler, tiff_warning_handler): Use it.
700 (tiff_load, gif_load, imagemagick_load_image):
701 Don't assume :index value fits in 'int'.
702 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
703 (imagemagick_load_image): Check that crop parameters fit into
704 the integer types that MagickCropImage accepts. Don't assume
705 Vimagemagick_render_type has a nonnegative value. Don't assume
706 size_t fits in 'long'.
707 (gs_load): Use printmax_t to print the widest integers possible.
708 Check for integer overflow when computing image height and width.
710 2011-08-26 Eli Zaretskii <eliz@gnu.org>
712 * xdisp.c (redisplay_window): Don't force window start if point
713 will be invisible in the resulting window. (Bug#9324)
715 2011-08-25 Eli Zaretskii <eliz@gnu.org>
717 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
718 the display spec is of the form `(space ...)'.
719 (handle_display_spec): Return the value returned by
720 handle_single_display_spec, not just 1 or zero.
721 (handle_single_display_spec): If the display spec is of the form
722 `(space ...)', and specifies display in the text area, return 2
724 (try_cursor_movement): Check for the need to scroll more
725 accurately, and prefer exact match for point under bidi. Don't
726 advance `row' beyond the last row of the window.
728 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
729 into disp_prop; all users changed.
731 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
732 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
733 for the text covered by the display property.
735 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
737 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
738 Change return value to nil.
739 (Frecord_buffer): Delete unused function.
741 2011-08-24 Eli Zaretskii <eliz@gnu.org>
743 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
744 buffers, return left-to-right.
745 (set_cursor_from_row): Consider candidate row a win if its glyph
746 represents a newline and point is on that newline. Fixes cursor
747 positioning on the newline at EOL of R2L text within L2R
748 paragraph, and vice versa.
749 (try_cursor_movement): Check continued rows, in addition to
750 continuation rows. Fixes unwarranted scroll when point enters a
751 continued line of R2L text within an L2R paragraph, or vice versa.
752 (cursor_row_p): Consider the case of point being equal to
753 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
754 from the end of a short line to the beginning of a continued line
755 of R2L text within L2R paragraph.
756 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
759 * bidi.c (bidi_check_type): Use xassert.
760 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
763 2011-08-23 Eli Zaretskii <eliz@gnu.org>
765 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
768 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
770 * nsfont.m (ns_otf_to_script): Fix typo.
772 2011-08-22 Kenichi Handa <handa@m17n.org>
774 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
775 extra slot even if the purpose is char-code-property-table.
777 2011-08-23 Eli Zaretskii <eliz@gnu.org>
779 * xdisp.c (redisplay_window): When computing centering_position,
780 account for the height of the header line. (Bug#8874)
782 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
783 instead of CHAR_TO_BYTE. Fixes a crash when a completion
784 candidate is selected by the mouse, and that candidate has a
785 composed character under the mouse.
787 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
788 coordinates reported by pos-visible-in-window-p for a composed
789 character in column zero.
791 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
793 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
795 2011-08-22 Eli Zaretskii <eliz@gnu.org>
797 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
798 consider it a hit if to_charpos is anywhere in the range of the
799 composed buffer positions.
801 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
803 * image.c (gif_load): Don't assume that each subimage has the same
804 dimensions as the base image. Handle disposal method that is
805 "undefined" by the gif spec (Bug#9335).
807 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
809 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
810 (Fcondition_case): Document `debug' symbol in error handler.
812 2011-08-19 Eli Zaretskii <eliz@gnu.org>
814 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
815 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
816 from an Org mode buffer to a Speedbar frame.
818 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
819 a composition, take its buffer position from IT->cmp_it.charpos.
820 Fixes cursor positioning at the beginning of a line that begins
821 with a composed character.
823 2011-08-18 Eli Zaretskii <eliz@gnu.org>
825 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
826 character bidirectional type, use STRONG_L instead. Fixes crashes
827 in a buffer produced by `describe-categories'.
829 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
830 members before the level stack, so they would be saved and
831 restored when copying iterator state. Fixes incorrect reordering
832 around TABs covered by display properties.
834 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
836 * process.c (Fnetwork_interface_list): Correctly determine buffer
839 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
841 * eval.c (internal_condition_case, internal_condition_case_1)
842 (internal_condition_case_2, internal_condition_case_n):
843 Remove unnecessary aborts (Bug#9081).
845 2011-08-17 Eli Zaretskii <eliz@gnu.org>
847 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
848 has no `load' handler, try opening the file locally. (Bug#9311)
850 2011-08-16 Ken Brown <kbrown@cornell.edu>
852 * gmalloc.c: Expand comment.
854 2011-08-16 Eli Zaretskii <eliz@gnu.org>
856 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
857 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
859 2011-08-16 Ken Brown <kbrown@cornell.edu>
861 Fix memory allocation problems in Cygwin build (Bug#9273).
863 * unexcw.c ( __malloc_initialized): Declare external variable.
864 (fixup_executable): Force the dumped emacs to reinitialize malloc.
866 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
868 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
870 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
872 [CYGWIN] (special_realloc): New function.
873 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
874 requests to realloc storage in the static heap.
876 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
878 * bidi.c (bidi_initialize): Remove unused local.
880 2011-08-15 Eli Zaretskii <eliz@gnu.org>
882 * biditype.h: File removed.
884 * bidimirror.h: File removed.
886 * deps.mk (bidi.o): Remove biditype.h and
889 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
892 * dispextern.h: Fix a typo in the comment to bidi_type_t.
894 * chartab.c: Improve commentary for the uniprop_table API.
896 * bidi.c (bidi_paragraph_init): Support zero value of
897 bidi_ignore_explicit_marks_for_paragraph_level.
898 (bidi_initialize): Use uniprop_table instead of including
899 biditype.h and bidimirror.h.
901 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
902 coordinates of the iterator when restoring from ppos_it.
905 2011-08-14 Kenichi Handa <handa@m17n.org>
907 * process.c (create_process): Call setup_process_coding_systems
908 after the pid of the process is set to -1 (Bug#8162).
910 2011-08-14 Eli Zaretskii <eliz@gnu.org>
912 * xdisp.c (move_it_in_display_line_to): Don't invoke
913 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
914 ppos_it. Fixes vertical cursor motion when line beginning is
915 covered by an image. (Bug#9296)
917 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
919 * nsterm.h (ns_run_ascript): Declare.
920 (NSAPP_DATA2_RUNASSCRIPT): Define.
922 * nsfns.m (as_script, as_result, as_status): New static variables.
923 (ns_run_ascript): New function.
924 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
925 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
926 the event loop. Get status from as_status (Bug#7276).
928 * nsterm.m (sendEvent): If event is NSApplicationDefined and
929 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
930 the event loop (Bug#7276).
932 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
934 * gnutls.c (QCgnutls_bootprop_priority)
935 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
936 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
937 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
938 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
939 (QCgnutls_bootprop_verify_hostname_error)
940 (QCgnutls_bootprop_callbacks_verify): Rename from
941 Qgnutls_bootprop_..., all uses changed.
943 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
946 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
948 * xfaces.c (Qframe_set_background_mode): Now static.
949 * dispextern.h (Qframe_set_background_mode): Remove decl.
951 * process.c (Fnetwork_interface_info): Declare local only if needed.
953 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
955 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
956 (Fnetwork_interface_list): Allocate in increments of bytes instead
957 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
958 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
960 (struct ifflag_def): notrailers is smart on OSX.
961 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
962 Get hardware address with getifaddrs if available.
964 2011-08-12 Eli Zaretskii <eliz@gnu.org>
966 * xdisp.c (iterate_out_of_display_property): xassert that
967 IT->position is set to within IT->object's boundaries. Break from
968 the loop as soon as EOB is reached; avoids infloops in redisplay
969 when IT->position is set up wrongly due to some bug.
970 Set IT->current to match the bidi iterator unconditionally.
971 (push_display_prop): Allow GET_FROM_STRING as IT->method on
972 entry. Force push_it to save on the stack the current
973 buffer/string position, to be restored by pop_it. Fix flags in
974 the iterator structure wrt the object coming from a display
975 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
976 properties. (Bug#9284)
978 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
980 * fontset.c (fontset_get_font_group): Add proper type checks.
983 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
985 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
986 and LC_VERSION_MIN_MACOSX.
987 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
988 (dump_it) [LC_FUNCTION_STARTS]: Use it.
990 2011-08-08 Eli Zaretskii <eliz@gnu.org>
992 * xdisp.c (forward_to_next_line_start): Allow to use the
993 no-display-properties-and-no-overlays under bidi display.
994 Set disp_pos in the bidi iterator to avoid searches for display
995 properties and overlays.
997 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
999 * editfns.c (Fset_time_zone_rule): Document relationship with the
1002 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1003 the font entity extracted from the cache (Bug#8109).
1005 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1007 * composite.c (autocmp_chars): Don't reset point. That is done by
1008 restore_point_unwind (Bug#5984).
1010 2011-08-07 Juri Linkov <juri@jurta.org>
1012 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1013 to show the arg `TIME' instead of `TIMEVAL'.
1015 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1017 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1018 display property strides EOL and includes a newline, as in
1019 longlines-mode. (Bug#9254)
1020 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1021 word-wrap under bidirectional display. (Bug#9224)
1023 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1024 is non-zero, even if the data buffer is NULL. Fixes a crash in
1025 vertical-motion with longlines-mode. (Bug#9254)
1027 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1029 * bidi.c <bidi_cache_total_alloc>: Now static.
1030 (bidi_initialize): Initialize bidi_cache_total_alloc.
1032 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1035 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1036 amount allocated this far in `bidi_cache_total_alloc'.
1037 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1038 non-zero, only free the data buffer without restoring the cache
1039 contents. All callers changed.
1041 * dispextern.h (bidi_unshelve_cache): Update prototype.
1043 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1044 (move_it_in_display_line, move_it_to)
1045 (move_it_vertically_backward, move_it_by_lines): Replace the call
1046 to xfree to an equivalent call to bidi_unshelve_cache.
1047 (move_it_in_display_line_to): Fix logic of returning
1048 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1050 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1052 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1053 came from a string character with a `cursor' property. (Bug#9229)
1055 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1057 * Makefile.in (LIB_PTHREAD): New variable.
1058 (LIBES): Add LIB_PTHREAD (Bug#9216).
1060 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1061 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1063 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1065 * regex.c (re_iswctype): Remove some redundant boolean
1068 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1070 * xterm.c (x_find_topmost_parent): New function.
1071 (x_set_frame_alpha): Find topmost parent window with
1072 x_find_topmost_parent and set the property there also (bug#9181).
1073 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1075 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1077 * callproc.c (Fcall_process): Avoid vfork clobbering
1078 the local vars buffer, coding_systems, current_dir.
1080 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1082 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1084 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1086 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1087 so that it is not optimized away.
1089 * xdisp.c (compute_display_string_pos): Remove unused local.
1091 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1093 Fix slow cursor motion and scrolling in large buffers with
1094 selective display, like Org Mode buffers. (Bug#9218)
1096 * dispextern.h (struct bidi_it): New member disp_prop_p.
1098 * xdisp.c: Remove one-slot cache of display string positions.
1099 (compute_display_string_pos): Accept an additional argument
1100 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1101 for a display string or property. If found, set DISP_PROP_P
1104 * bidi.c (bidi_fetch_char): Accept an additional argument
1105 DISP_PROP_P, and pass it to compute_display_string_pos.
1106 Only handle text covered by a display string if DISP_PROP_P is returned
1107 non-zero. All callers of bidi_fetch_char changed.
1109 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1111 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1113 2010-12-03 Don March <don@ohspite.net>
1115 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1116 last character M-[char] is translated to ESC [char] (bug#7541).
1118 2011-08-02 Kenichi Handa <handa@m17n.org>
1120 * lisp.h (uniprop_table): Extern it.
1122 * chartab.c (uniprop_table): Make it non-static.
1124 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1126 * xdisp.c (forward_to_next_line_start): Accept additional argument
1127 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1129 (reseat_at_next_visible_line_start): Use the bidi iterator state
1130 returned by forward_to_next_line_start to restore the state of
1131 it->bidi_it after backing up to previous newline. (Bug#9212)
1133 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1135 * regex.c (re_comp): Protoize.
1136 (re_exec): Fix return type.
1137 (regexec): Fix type of `ret'. (Bug#9203)
1139 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1141 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1142 This is needed if max-image-size is a floating-point number.
1144 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1146 * print.c (print_object): Print empty symbol as ##.
1148 * lread.c (read1): Read ## as empty symbol.
1150 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1152 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1153 setting frame foreground color (Bug#9175).
1154 (x_set_background_color): Likewise.
1156 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1157 contents (Bug#9176).
1158 (EmacsTooltip -init): Remove bezels and add shadows to
1161 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1162 or scroll bar (Bug#8470).
1164 * nsfont.m (nsfont_open): Remove assignment to voffset and
1165 unnecessary vars hshink, expand, hd, full_height, min_height.
1166 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1168 * nsterm.h (nsfont_info): Remove voffset field.
1170 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1172 Implement strike-through and overline on NextStep (Bug#8863).
1174 * nsfont.m (nsfont_open): Use underline position provided by font,
1175 instead of hard-coded value of 2.
1176 (nsfont_draw): Call ns_draw_text_decoration instead.
1178 * nsterm.h: Add declaration for ns_draw_text_decoration.
1180 * nsterm.m (ns_draw_text_decoration): New function for drawing
1181 underline, overline, and strike-through.
1182 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1183 ns_draw_text_decoration. Change treatment of cursor drawing to
1184 accomodate underlining, etc.
1186 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1188 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1191 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1193 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1194 Without this fix, if a signal arrives just after memory fills up,
1195 'malloc' might be invoked reentrantly.
1197 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1198 In other words, assume that every image size is allowed, on non-X
1199 hosts. This assumption is probably wrong, but it lets Emacs compile.
1201 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1203 * regex.c (re_iswctype): Convert return values to boolean.
1205 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1207 * xdisp.c (compute_display_string_pos): Don't use cached display
1208 string position if the buffer had its restriction changed.
1211 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1213 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1215 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1217 Integer signedness and overflow and related fixes. (Bug#9079)
1219 * bidi.c: Integer size and overflow fixes.
1220 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1221 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1222 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1223 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1224 (bidi_find_other_level_edge):
1225 Use ptrdiff_t instead of EMACS_INT where either will do.
1226 This works better on 32-bit hosts configured --with-wide-int.
1227 (bidi_cache_ensure_space): Check for size-calculation overflow.
1228 Use % rather than repeated addition, for better worst-case speed.
1229 Don't set bidi_cache_size until after xrealloc returns, because it
1231 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1232 (bidi_cache_ensure_space): Also check that the bidi cache size
1233 does not exceed that of the largest Lisp string or buffer. See Eli
1234 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1236 * alloc.c (__malloc_size_t): Remove.
1237 All uses replaced by size_t. See Andreas Schwab's note
1238 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1240 * image.c: Improve checking for integer overflow.
1241 (check_image_size): Assume that f is nonnull, since
1242 it is always nonnull in practice. This is one less thing to
1243 worry about when checking for integer overflow later.
1244 (x_check_image_size): New function, which checks for integer
1245 overflow issues inside X.
1246 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1247 This removes the need for a memory_full check.
1248 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1249 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1250 (xbm_read_bitmap_data): Change locals back to 'int', since
1251 their values must fit in 'int'.
1252 (xpm_load_image, png_load, tiff_load):
1253 Invoke x_create_x_image_and_pixmap earlier,
1254 to avoid much needless work if the image is too large.
1255 (tiff_load): Treat overly large images as if
1256 x_create_x_image_and_pixmap failed, not as malloc failures.
1257 (gs_load): Use x_check_image_size.
1259 * gtkutil.c: Omit integer casts.
1260 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1261 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1263 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1265 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1266 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1267 would wrongly return t on a 64-bit host.
1269 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1270 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1271 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1272 and therefore cause GCC to emit a bogus diagnostic in some cases.
1274 * image.c: Integer signedness and overflow and related fixes.
1275 This is not an exhaustive set of fixes, but it's time to
1276 record what I've got.
1277 (lookup_pixel_color, check_image_size): Remove redundant decls.
1278 (check_image_size): Don't assume that arbitrary EMACS_INT values
1279 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1280 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1281 (tiff_load, imagemagick_load_image):
1282 Check for overflow in size calculations.
1283 (x_create_x_image_and_pixmap): Remove unnecessary test for
1284 xmalloc returning NULL; that can't happen.
1285 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1286 (xpm_color_bucket): Use better integer hashing function.
1287 (xpm_cache_color): Don't possibly over-allocate memory.
1288 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1289 (gif_memory_source):
1290 Use ptrdiff_t, not int or size_t, to record sizes.
1291 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1292 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1293 either works, as we prefer signed integers.
1294 (tiff_read_from_memory, tiff_write_from_memory):
1295 Return tsize_t, not size_t, since that's what the TIFF API wants.
1296 (tiff_read_from_memory): Don't fail simply because the read would
1297 go past EOF; instead, return a short read.
1298 (tiff_load): Omit no-longer-needed casts.
1299 (Fimagemagick_types): Don't assume size fits into 'int'.
1301 Improve hashing quality when configured --with-wide-int.
1302 * fns.c (hash_string): New function, taken from sxhash_string.
1303 Do not discard information about ASCII character case; this
1304 discarding is no longer needed.
1305 (sxhash-string): Use it. Change sig to match it. Caller changed.
1306 * lisp.h: Declare it.
1307 * lread.c (hash_string): Remove, since we now use fns.c's version.
1308 The fns.c version returns a wider integer if --with-wide-int is
1309 specified, so this should help the quality of the hashing a bit.
1311 * emacs.c: Integer overflow minor fix.
1312 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1313 Define only if GNU_LINUX.
1314 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1316 * dispnew.c: Integer signedness and overflow fixes.
1317 Remove unnecessary forward decls, that were a maintenance hassle.
1318 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1320 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1321 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1322 (prepare_desired_row, line_draw_cost):
1323 Use int, not unsigned, where either works.
1324 (save_current_matrix, restore_current_matrix):
1325 Use ptrdiff_t, not size_t, where either works.
1326 (init_display): Check for overflow more accurately, and without
1327 relying on undefined behavior.
1329 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1330 Remove, replacing with the new symbols in lisp.h. All uses changed.
1331 * fileio.c (make_temp_name):
1332 * filelock.c (lock_file_1, lock_file):
1333 * xdisp.c (message_dolog):
1334 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1335 Use pMd etc. instead.
1336 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1337 replacing the pWIDE etc. symbols removed from editfns.c.
1339 * keyboard.h (num_input_events): Now uintmax_t.
1340 This is (very slightly) less likely to mess up due to wraparound.
1343 * buffer.c: Integer signedness fixes.
1344 (alloc_buffer_text, enlarge_buffer_text):
1345 Use ptrdiff_t rather than size_t when either will do, as we prefer
1348 * alloc.c: Integer signedness and overflow fixes.
1349 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1350 (__malloc_size_t): Default to size_t, not to int.
1351 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1352 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1353 Prefer ptrdiff_t to size_t when either would do, as we prefer
1355 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1356 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1357 Now const. Initialize with values that are in range even if char
1359 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1360 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1361 These functions do the right thing with sizes > 2**32.
1362 (check_depth): Now ptrdiff_t, not int.
1363 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1364 Adjust to new way of storing sizes. Check for size overflow bugs
1366 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1367 slightly wrong anyway, as it missed one instance of
1368 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1369 (refill_memory_reserve): Omit needless cast to size_t.
1370 (mark_object_loop_halt): Mark as externally visible.
1372 * xselect.c: Integer signedness and overflow fixes.
1373 (Fx_register_dnd_atom, x_handle_dnd_message):
1374 Use ptrdiff_t, not size_t, since we prefer signed.
1375 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1376 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1377 x_dnd_atoms_size and x_dnd_atoms_length.
1379 * doprnt.c: Prefer signed to unsigned when either works.
1381 * doprnt.c (doprnt):
1383 * xdisp.c (vmessage):
1384 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1385 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1386 prefer signed arithmetic to avoid comparison confusion.
1387 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1388 but is a bit tricky.
1390 Assume freestanding C89 headers, string.h, stdlib.h.
1391 * data.c, doprnt.c, floatfns.c, print.c:
1392 Include float.h unconditionally.
1393 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1394 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1395 * regex.c: Likewise for stddef.h, string.h.
1396 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1397 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1398 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1399 (STDC_HEADERS): Remove obsolete defines.
1400 * sysdep.c: Include limits.h unconditionally.
1402 Assume support for memcmp, memcpy, memmove, memset.
1403 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1404 * regex.c (memcmp, memcpy):
1405 Remove; we assume C89 now.
1407 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1408 (__malloc_safe_bcopy): Remove; no longer needed.
1410 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1411 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1412 well either way, and we prefer signed to unsigned.
1414 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1416 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1417 closes the connection while we're reading (bug#9182).
1419 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1421 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1422 are specified (Bug#9168).
1424 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1426 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1427 Found by GCC static checking and --with-wide-int on a 32-bit host.
1429 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1431 * xdisp.c (compute_display_string_pos): Fix logic of caching
1432 previous display string position. Initialize cached_prev_pos to
1433 -1. Fixes slow-down at the beginning of a buffer.
1435 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1437 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1438 for attrs[LFACE_FONTSET_INDEX].
1440 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1442 * xml.c (parse_region): Remove unused local
1443 that was recently introduced.
1445 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1447 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1448 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1450 * xdisp.c (move_it_in_display_line_to): Record the best matching
1451 position for TO_CHARPOS while scanning the line, and restore it on
1452 exit if none of the characters scanned was an exact match.
1453 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1454 when exact match is impossible due to invisible text, and the
1455 lines are truncated.
1457 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1459 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1462 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1464 Fix a significant slow-down of cursor motion with C-n, C-p,
1465 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1466 auto-repeat under bidi redisplay in fontified buffers.
1467 * xdisp.c (compute_stop_pos_backwards): New function.
1468 (next_element_from_buffer): Call compute_stop_pos_backwards to
1469 find a suitable prev_stop when we find ourselves before
1471 (reseat): Don't look for prev_stop, as that could mean a very long
1473 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1474 <cached_disp_overlay_modiff>: Cache for last found display string
1476 (compute_display_string_pos): Return the cached position if asked
1477 about the same buffer in the same area of character positions, and
1478 the buffer wasn't changed since the time the display string
1479 position was cached.
1481 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1483 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1484 is an integer, which is important for empty lines. (Bug#9149)
1486 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1488 * frame.c (Fmodify_frame_parameters): In tty case, update the
1489 default face if necessary (Bug#4238).
1491 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1493 * editfns.c (Fstring_to_char): No need to explain what a character
1494 is in the docstring (Bug#6576).
1496 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1498 * xml.c (parse_region): Make sure we always return a tree.
1500 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1502 * xml.c (parse_region): If a document contains only comments,
1505 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1507 * xml.c (make_dom): Return comments, too.
1509 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1512 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1513 and the surrounding thread.
1514 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1515 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1516 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1518 * s/openbsd.h (BROKEN_SIGIO): Define.
1519 * unexelf.c (unexec) [__OpenBSD__]:
1520 Don't update the .mdebug section of the Alpha COFF symbol table.
1522 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1524 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1527 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1529 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1530 This fixes some race conditions on the permissions of any newly
1533 * alloc.c (valid_pointer_p): Use pipe, not open.
1534 This fixes some permissions issues when debugging.
1536 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1537 If fchown fails to set both uid and gid, try to set just gid,
1538 as that is sometimes allowed. Adjust the file's mode to eliminate
1539 setuid or setgid bits that are inappropriate if fchown fails.
1541 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1543 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1544 to compare Lisp_Objects.
1545 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1546 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1547 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1549 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1551 * lread.c (read_integer): Unread even EOF character.
1552 (read1): Likewise. Properly record start position of symbol.
1554 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1555 symbol character follows.
1557 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1559 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1560 This works around a problem with the previous change to Fcopy_file.
1561 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1562 and without this change, GCC might complain about discarding
1563 fchown's return value.
1565 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1567 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1569 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1571 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1573 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1575 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1576 it's used from the C level.
1578 * process.c: Use the same condition for POLL_FOR_INPUT in both
1579 keyboard.c and process.c (bug#1858).
1581 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1583 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1584 (Fgnutls_boot): Use it.
1586 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1588 * doc.c (Fsubstitute_command_keys): Revert last change.
1590 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1592 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1593 quotes the next character, and doesn't affect other longer
1594 sequences (bug#8935).
1596 * lread.c (syms_of_lread): Clarify that is isn't only
1597 `eval-buffer' and `eval-defun' that's affected by
1598 `lexical-binding' (bug#8460).
1600 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1602 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1603 bidi redisplay when a line includes both an image and is
1606 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1608 Fix minor problems found by static checking.
1609 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1610 (elsz): Now a signed constant, not a size_t var. We prefer signed
1611 types to unsigned, to avoid integer comparison confusion. Without
1612 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1613 "cannot optimize loop, the loop counter may overflow", a symptom
1615 * indent.c (Fvertical_motion): Mark locals as initialized.
1616 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1618 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1620 * search.c (Fre_search_backward): Mention `case-fold-search' in
1621 all the re_search_* functions (bug#8138).
1623 * keyboard.c (Fopen_dribble_file): Document when the file is
1626 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1628 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1631 Support bidi reordering of display and overlay strings.
1632 * xdisp.c (compute_display_string_pos)
1633 (compute_display_string_end): Accept additional argument STRING.
1634 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1635 (reseat_to_string): Initialize bidi_it->string.s and
1636 bidi_it->string.schars.
1637 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1638 NULL (avoids a crash in bidi_paragraph_init).
1639 Initialize itb.string.lstring.
1640 (init_iterator): Call bidi_init_it only of a valid
1641 buffer position was specified. Initialize paragraph_embedding to
1643 (reseat_to_string): Initialize the bidi iterator.
1644 (display_string): If we need to ignore text properties of
1645 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1646 original value of -1 will not work with bidi.)
1647 (compute_display_string_pos): First arg is now struct
1648 `text_pos *'; all callers changed. Support display properties on
1650 (compute_display_string_end): Support display properties on Lisp
1652 (init_iterator, reseat_1, reseat_to_string): Initialize the
1653 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1654 when iterating on a string not from display properties).
1655 (compute_display_string_pos, compute_display_string_end):
1656 Fix calculation of the object to scan. Fixes an error when using
1658 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1659 base_level_stop; instead, set base_level_stop to BEGV.
1660 Fixes crashes in vertical-motion.
1661 (next_element_from_buffer): Improve commentary for when
1662 the iterator is before prev_stop.
1663 (init_iterator): Initialize bidi_p from the default value of
1664 bidi-display-reordering, not from buffer-local value. Use the
1665 buffer-local value only if initializing for buffer iteration.
1666 (handle_invisible_prop): Support invisible properties on strings
1667 that are being bidi-reordered.
1668 (set_iterator_to_next): Support bidi reordering of C strings and
1670 (next_element_from_string): Support bidi reordering of Lisp
1672 (handle_stop_backwards): Support Lisp strings as well.
1673 (display_string): Support display of R2L glyph rows.
1674 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1675 (init_iterator): Don't initialize it->bidi_p for strings
1677 (reseat_to_string): Initialize it->bidi_p for strings here.
1678 (next_element_from_string, next_element_from_c_string)
1679 (next_element_from_buffer): Add xassert's for correspondence
1680 between IT's object being iterated and it->bidi_it.string
1682 (face_before_or_after_it_pos): Support bidi iteration.
1683 (next_element_from_c_string): Handle the case of the first string
1684 character that is not the first one in the visual order.
1685 (get_visually_first_element): New function, refactored from common
1686 parts of next_element_from_buffer, next_element_from_string, and
1687 next_element_from_c_string.
1688 (tool_bar_lines_needed, redisplay_tool_bar)
1689 (display_menu_bar): Force left-to-right direction. Add a FIXME
1690 comment for making that be controlled by a user option.
1691 (push_it, pop_it): Save and restore the state of the
1692 bidi iterator. Save and restore the bidi_p flag.
1693 (pop_it): Iterate out of display property for string iteration as
1695 (iterate_out_of_display_property): Support iteration over strings.
1696 (handle_single_display_spec): Set up it->bidi_it for iteration
1697 over a display string, and call bidi_init_it.
1698 (handle_single_display_spec, next_overlay_string)
1699 (get_overlay_strings_1, push_display_prop): Set up the bidi
1700 iterator for displaying display or overlay strings.
1701 (forward_to_next_line_start): Don't use the shortcut if
1703 (back_to_previous_visible_line_start): If handle_display_prop
1704 pushed the iterator stack, restore the internal state of the bidi
1705 iterator by calling bidi_pop_it same number of times.
1706 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1707 and we are bidi-iterating, don't decrement the iterator position;
1708 instead, set the first_elt flag in the bidi iterator, to produce
1710 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1711 (push_display_prop): xassert that we are iterating a buffer.
1712 (push_it, pop_it): Save and restore paragraph_embedding member.
1713 (handle_single_display_spec, next_overlay_string)
1714 (get_overlay_strings_1, reseat_1, reseat_to_string)
1715 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1716 correctly. Don't assume unibyte strings are not bidi-reordered.
1717 (compute_display_string_pos)
1718 (compute_display_string_end): Fix handling the case of C string.
1719 (push_it, pop_it): Save and restore from_disp_prop_p.
1720 (handle_single_display_spec, push_display_prop): Set the
1721 from_disp_prop_p flag.
1722 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1723 (pop_it): Call iterate_out_of_display_property only if we are
1724 popping after iteration over a string that came from a display
1725 property. Fix a typo in popping stretch info. Add an assertion
1726 for verifying that the iterator position is in sync with the bidi
1728 (handle_single_display_spec, get_overlay_strings_1)
1729 (push_display_prop): Fix initialization of paragraph direction for
1730 string when that of the parent object is not yet determined.
1731 (reseat_1): Call bidi_init_it to resync the bidi
1732 iterator with IT's position. (Bug#7616)
1733 (find_row_edges): If ROW->start.pos gives position
1734 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1735 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1736 Reset the from_disp_prop_p flag.
1737 (SAVE_IT, RESTORE_IT): New macros.
1738 (pos_visible_p, face_before_or_after_it_pos)
1739 (back_to_previous_visible_line_start)
1740 (move_it_in_display_line_to, move_it_in_display_line)
1741 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1742 (try_scrolling, redisplay_window, display_line): Use them when
1743 saving a temporary copy of the iterator and restoring it back.
1744 (back_to_previous_visible_line_start, reseat_1)
1745 (init_iterator): Empty the bidi cache "stack".
1746 (move_it_in_display_line_to): If iterator ended up at
1747 EOL, but we never saw any buffer positions smaller than
1748 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1749 motion in bidi-reordered lines.
1750 (move_it_in_display_line_to): Record prev_method and prev_pos
1751 immediately before the call to set_iterator_to_next. Fixes cursor
1752 motion in bidi-reordered lines with stretch glyphs and strings
1753 displayed in margins. (Bug#8133) (Bug#8867)
1754 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1756 (pos_visible_p): Support positions in bidi-reordered lines.
1757 Save and restore bidi cache.
1759 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1760 (bidi_paragraph_info): Delete unused struct.
1761 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1762 (bidi_cache_start): New variable.
1763 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1765 (bidi_cache_fetch_state, bidi_cache_search)
1766 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1767 (bidi_cache_find, bidi_peek_at_next_level)
1768 (bidi_level_of_next_char, bidi_find_other_level_edge)
1769 (bidi_move_to_visually_next): Compare cache index with
1770 bidi_cache_start rather than with zero.
1771 (bidi_fetch_char): Accept new argument STRING; all callers
1772 changed. Support iteration over a string. Support strings with
1773 display properties. Support unibyte strings. Fix the type of
1774 `len' according to what STRING_CHAR_AND_LENGTH expects.
1775 (bidi_paragraph_init, bidi_resolve_explicit_1)
1776 (bidi_resolve_explicit, bidi_resolve_weak)
1777 (bidi_level_of_next_char, bidi_move_to_visually_next):
1778 Support iteration over a string.
1779 (bidi_set_sor_type, bidi_resolve_explicit_1)
1780 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1781 can now be zero (for strings); special values 0 and -1 were
1782 changed to -1 and -2, respectively.
1783 (bidi_char_at_pos): New function.
1784 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1785 Call it instead of FETCH_MULTIBYTE_CHAR.
1786 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1787 initialized to valid values.
1788 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1790 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1791 the test for valid cached positions. Fix the logic for looking up
1792 the sentinel state in the cache. GCPRO the Lisp string we are
1794 (bidi_push_it, bidi_pop_it): New functions.
1795 (bidi_initialize): Initialize the bidi cache start stack pointer.
1796 (bidi_cache_ensure_space): New function, refactored from part of
1797 bidi_cache_iterator_state. Don't assume the required size is just
1798 one BIDI_CACHE_CHUNK away.
1799 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1800 (bidi_count_bytes, bidi_char_at_pos): New functions.
1801 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1802 always valid if bidi_cache_idx is valid.
1803 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1804 is valid if it's going to be used.
1805 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1806 (bidi_cache_fetch_state, bidi_cache_search)
1807 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1808 (bidi_cache_iterator_state, bidi_cache_find)
1809 (bidi_find_other_level_edge, bidi_cache_start_stack):
1810 All variables related to cache indices are now EMACS_INT.
1812 * dispextern.h (struct bidi_string_data): New structure.
1813 (struct bidi_it): New member `string'. Make flag members be 1-bit
1814 fields, and put them last in the struct.
1815 (compute_display_string_pos, compute_display_string_end):
1817 (bidi_push_it, bidi_pop_it): Add prototypes.
1818 (struct iterator_stack_entry): New members bidi_p,
1819 paragraph_embedding, and from_disp_prop_p.
1820 (struct it): Member bidi_p is now a bit field 1 bit wide.
1821 (bidi_shelve_cache, bidi_unshelve_cache):
1824 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1825 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1826 and vector-like objects.
1828 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1829 cache around display iteration.
1831 * window.c (Fwindow_end, window_scroll_pixel_based)
1832 (displayed_window_lines, Frecenter): Save and restore the bidi
1833 cache around display iteration.
1835 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1837 * editfns.c (Fdelete_region): Clarify the use of the named
1838 parameters (bug#6788).
1840 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1842 * indent.c (Fvertical_motion): Set and restore w->pointm when
1843 saving and restoring the window's buffer (Bug#9006).
1845 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1847 * editfns.c (Fstring_to_char): Clarify just what is returned
1848 (bug#6576). Text by Eli Zaretskii.
1850 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1852 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1854 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1856 * buffer.c (mmap_find): Fix a typo.
1858 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1860 Fix execution of x selection hooks.
1861 * xselect.c (Qx_lost_selection_functions)
1862 (Qx_sent_selection_functions): New vars.
1863 (syms_of_xselect): DEFSYM them.
1864 (x_handle_selection_request): Pass Qx_sent_selection_functions
1865 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1866 (x_handle_selection_clear,x_clear_frame_selections):
1867 Pass Qx_lost_selection_functions rather than
1868 Vx_lost_selection_functions to Frun_hook_with_args.
1870 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1872 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1873 The old code sometimes used this field without initializing it.
1875 * alloc.c (gc_sweep): Don't read past end of array.
1876 In theory, the old code could also have corrupted Emacs internals,
1877 though it'd be very unlikely.
1879 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1881 * character.c (Fcharacterp): Don't advertise optional ignored
1882 argument. (Bug#4026)
1884 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1886 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1889 * window.c (Fset_window_start): Doc fix (bug#4199).
1890 (Fset_window_hscroll): Ditto.
1892 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1894 Fix minor new problems caught by GCC 4.6.1.
1895 * term.c (init_tty): Remove unused local.
1896 * xsettings.c (store_monospaced_changed): Define this function only
1897 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1900 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1902 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1904 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1906 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1907 are the mini-buffer and the echo area (bug#3320).
1909 * term.c (init_tty): Remove support for supdup, c10 and perq
1910 terminals, which are no longer supported (bug#1482).
1912 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1914 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1916 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1918 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1919 for non-popups (Bug#3642).
1921 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1923 * alloc.c (reset_malloc_hooks): Protoize.
1924 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1925 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1926 * cm.c (losecursor): Likewise.
1927 * data.c (fmod): Likewise.
1928 * dispnew.c (swap_glyphs_in_rows): Likewise.
1929 * emacs.c (memory_warning_signal): Likewise.
1930 * floatfns.c (float_error): Likewise.
1931 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1932 (otf_open, font_otf_capability, generate_otf_features)
1933 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1935 * image.c (pbm_read_file): Likewise.
1936 * indent.c (string_display_width): Likewise.
1937 * intervals.c (check_for_interval, search_for_interval)
1938 (inc_interval_count, count_intervals, root_interval)
1939 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1940 * lread.c (defalias): Likewise.
1941 * ralloc.c (r_alloc_check): Likewise.
1942 * regex.c (set_image_of_range_1, set_image_of_range)
1943 (regex_grow_registers): Likewise.
1944 * sysdep.c (strerror): Likewise.
1945 * termcap.c (valid_filename_p, tprint, main): Likewise.
1946 * tparam.c (main): Likewise.
1947 * unexhp9k800.c (run_time_remap, save_data_space)
1948 (update_file_ptrs, read_header, write_header, calculate_checksum)
1949 (copy_file, copy_rest, display_header): Likewise.
1950 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1952 * xdisp.c (check_it): Likewise.
1953 * xfaces.c (register_color, unregister_color, unregister_colors):
1955 * xfns.c (print_fontset_result): Likewise.
1956 * xrdb.c (member, fatal, main): Likewise.
1958 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1960 Fix minor problems found by static checking (Bug#9031).
1961 * chartab.c (char_table_set_range, map_sub_char_table):
1962 Remove unused locals.
1963 (uniprop_table): Now static.
1964 * composite.c (_work_char): Remove unused static var.
1966 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1968 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1970 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1972 * gtkutil.c (qttip_cb): Remove code without function.
1974 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1976 * w32.c (pthread_sigmask): New stub.
1978 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1980 Use pthread_sigmask, not sigprocmask (Bug#9010).
1981 sigprocmask is portable only for single-threaded applications, and
1982 Emacs can be multi-threaded when it uses GTK.
1983 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1985 * callproc.c (Fcall_process):
1986 * process.c (create_process):
1987 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1988 Use pthread_sigmask, not sigprocmask.
1990 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1992 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1993 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1996 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1998 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1999 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2000 (xg_hide_tooltip): Fix comment.
2002 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2003 in registerServicesMenuSendTypes.
2004 (validRequestorForSendType): Don't check ns_return_types.
2006 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2009 2011-07-08 Jason Rumney <jasonr@gnu.org>
2011 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2012 frame struct members of non-existent frames (Bug#6284).
2014 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2016 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2017 variable firstTime not needed on OSX >= 10.6.
2018 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2019 >= 10.5. Use setKnobProportion, setDoubleValue.
2021 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2022 (MAC_OS_X_VERSION_10_5): Define if not defined.
2023 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2024 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2025 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2027 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2028 cString and lossyCString on OSX >= 10.4
2030 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2031 sizeToFit on OSX >= 10.2.
2033 * nsimage.m (allocInitFromFile): Don't use deprecated method
2034 bestRepresentationForDevice on OSX >= 10.6.
2036 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2039 * emacs.c: Declare unexec_init_emacs_zone.
2041 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2043 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2045 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2046 on svcsMenu (Bug#8842).
2048 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2050 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2052 * nsterm.m (QUTF8_STRING): Declare.
2053 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2054 (validRequestorForSendType): Return type is (id).
2055 Change indexOfObjectIdenticalTo to indexOfObject.
2056 Check if we have local selection before returning self (Bug#8842).
2057 (writeSelectionToPasteboard): Put local selection into paste board
2058 if we have a local selection (Bug#8842).
2059 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2061 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2062 (ns_get_local_selection): Declare.
2064 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2066 * keymap.c (describe_map_tree): Don't insert a double newline at
2067 the end of the buffer (bug#1169) and return whether we inserted
2070 * callint.c (Fcall_interactively): Change "reading args" to
2071 "providing args" to try to clarify what it does (bug#1010).
2073 2011-07-07 Kenichi Handa <handa@m17n.org>
2075 * composite.c (composition_compute_stop_pos): Ignore a static
2076 composition starting before CHARPOS (Bug#8915).
2078 * xdisp.c (handle_composition_prop): Likewise.
2080 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2082 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2085 2011-07-07 Kenichi Handa <handa@m17n.org>
2087 * character.h (unicode_category_t): New enum type.
2089 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2090 (Qchar_code_property_table): New variable.
2091 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2092 (UNIPROP_COMPRESSED_FORM_P): New macros.
2093 (char_table_ascii): Uncompress the compressed values.
2094 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2095 Uncompress the compressed values.
2096 (sub_char_table_ref_and_range): Likewise.
2097 (char_table_ref_and_range): Uncompress the compressed values.
2098 (sub_char_table_set): New arg is_uniprop. Callers changed.
2099 Uncompress the compressed values.
2100 (sub_char_table_set_range): Args changed. Callers changed.
2101 (char_table_set_range): Adjuted for the above change.
2102 (map_sub_char_table): Delete args default_val and parent. Add arg
2103 top. Give decoded values to a Lisp function.
2104 (map_char_table): Adjust for the above change. Give decoded
2105 values to a Lisp function. Gcpro more variables.
2106 (uniprop_table_uncompress)
2107 (uniprop_decode_value_run_length): New functions.
2108 (uniprop_decoder, uniprop_decoder_count): New variables.
2109 (uniprop_get_decoder, uniprop_encode_value_character)
2110 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2112 (uniprop_encoder, uniprop_encoder_count): New variables.
2113 (uniprop_get_encoder, uniprop_table)
2114 (Funicode_property_table_internal, Fget_unicode_property_internal)
2115 (Fput_unicode_property_internal): New functions.
2116 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2117 Sunicode_property_table_internal, Sget_unicode_property_internal,
2118 and Sput_unicode_property_internal. Defvar_lisp
2119 char-code-property-alist.
2121 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2122 Vunicode_category_table.
2124 * font.c (font_range): Adjust for the change of
2125 Vunicode_category_table.
2127 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2129 * m/iris4d.h: Remove file, move contents ...
2130 * s/irix6-5.h: ... here.
2132 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2134 Remove unportable assumption about struct layout (Bug#8884).
2135 * alloc.c (mark_buffer):
2136 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2137 (clone_per_buffer_values): Don't assume that
2138 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2139 This isn't true in general, and it's particularly not true
2140 if Emacs is configured with --with-wide-int.
2141 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2142 New macros, used in the buffer.c change.
2144 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2146 * xsettings.c: Use both GConf and GSettings if both are available.
2147 (store_config_changed_event): Add comment.
2148 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2149 (store_tool_bar_style_changed): New functions.
2150 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2151 (struct xsettings): Move font inside HAVE_XFT.
2152 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2153 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2154 Move inside HAVE_XFT.
2155 (something_changed_gsettingsCB): Rename from something_changedCB.
2156 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2158 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2159 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2160 (something_changed_gconfCB): Rename from something_changedCB.
2161 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2162 (parse_settings): Move check for font inside HAVE_XFT.
2163 (read_settings, apply_xft_settings): Add comment.
2164 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2165 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2166 call store_font_name_changed.
2167 (xft_settings_event): Add comment.
2168 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2169 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2170 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2171 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2172 (xsettings_initialize): Call init_gsettings last.
2173 (xsettings_get_system_font, xsettings_get_system_normal_font):
2176 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2178 Random fixes. E.g., (random) never returned negative values.
2179 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2180 subseconds part to the entropy, as that's a bit more random.
2181 Prefer signed to unsigned, since the signedness doesn't matter and
2182 in general we prefer signed. When given a limit, use a
2183 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2184 latter isn't right if USE_2_TAGS_FOR_INTS.
2185 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2186 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2188 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2190 * textprop.c (text_property_stickiness):
2191 Obey Vtext_property_default_nonsticky.
2192 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2193 * w32fns.c (syms_of_w32fns):
2194 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2196 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2198 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2199 This is more efficient than Ffile_directory_p and avoids a minor race.
2201 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2203 * buffer.c (Foverlay_put): Say what the return value is
2206 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2207 is a directory before asking whether to use the file name
2209 (barf_or_query_if_file_exists): Make the "File is a directory"
2210 error be more correct.
2212 * fns.c (Frequire): Remove the mention of the .gz files, since
2213 that's installation-specific, but keep the mention of
2214 `get-load-suffixes'.
2216 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2218 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2219 Report string overflow if the output is too long.
2221 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2223 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2224 (syms_of_gnutls): Remove duplicate DEFSYM for
2225 Qgnutls_bootprop_verify_hostname_error, an error for
2226 Qgnutls_bootprop_verify_error (which is no longer used).
2228 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2229 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2230 Also (re)move comments that are misplaced or no longer relevant.
2232 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2234 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2236 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2238 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2239 and background color parameters if they have been changed.
2241 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2243 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2245 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2247 * xsettings.c (SYSTEM_FONT): Define only when used.
2248 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2250 * keymap.c (access_keymap_1): Now static.
2252 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2254 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2255 leave any prefix arg for the up event (Bug#1586).
2257 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2259 * lread.c (syms_of_lread): Mention single symbols defined by
2260 `defvar' or `defconst' (bug#7154).
2262 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2263 (Frequire): Mention get-load-suffixes.
2265 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2267 * window.h (window): Remove clone_number slot.
2268 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2270 (make_parent_window, make_window, saved_window)
2271 (Fset_window_configuration, save_window_save): Don't deal with
2273 * buffer.c (Qclone_number): Remove declaration.
2274 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2276 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2278 Add multiple inheritance to keymaps.
2279 * keymap.c (Fmake_composed_keymap): New function.
2280 (Fset_keymap_parent): Simplify.
2281 (fix_submap_inheritance): Remove.
2282 (access_keymap_1): New function extracted from access_keymap to handle
2283 embedded parents and handle lists of maps.
2284 (access_keymap): Use it.
2285 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2286 (Fcopy_keymap): Handle embedded parents.
2287 (Fcommand_remapping, define_as_prefix): Simplify.
2288 (Fkey_binding): Simplify.
2289 (syms_of_keymap): Move minibuffer-local-completion-map,
2290 minibuffer-local-filename-completion-map,
2291 minibuffer-local-must-match-map, and
2292 minibuffer-local-filename-must-match-map to Elisp.
2293 (syms_of_keymap): Defsubr make-composed-keymap.
2294 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2295 (parse_menu_item): Trivial simplification.
2297 2011-07-01 Glenn Morris <rgm@gnu.org>
2299 * Makefile.in (SETTINGS_LIBS): Fix typo.
2301 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2303 * coding.c (Fencode_coding_string): Record the last coding system
2304 used, as the function doc string says (bug#8738).
2306 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2308 * xsettings.c (store_monospaced_changed): Take new font as arg and
2309 check for change against current_mono_font.
2310 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2311 (emacs_settings_constructor, emacs_settings_get_property)
2312 (emacs_settings_set_property, emacs_settings_class_init)
2313 (emacs_settings_init, gsettings_obj): Remove.
2314 (something_changedCB): New function for HAVE_GSETTINGS.
2315 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2316 with value as argument.
2317 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2318 g_settings_new (Bug#8967). Do not create gsettings_obj.
2319 Remove calls to g_settings_bind. Connect something_changedCB to
2322 * xgselect.c: Add defined (HAVE_GSETTINGS).
2323 (xgselect_initialize): Ditto.
2325 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2326 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2329 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2331 * eval.c (struct backtrace): Simplify and port the data structure.
2332 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2333 signed bit field, as this assumption is not portable and it makes
2334 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2335 "char debug_on_exit : 1" as this is not portable either; instead,
2336 use the portable "unsigned int debug_on_exit : 1". Remove unused
2337 member evalargs. Remove obsolete comments about cc bombing out.
2339 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2341 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2342 Let HAVE_GSETTINGS override HAVE_GCONF.
2343 (store_monospaced_changed): New function.
2344 (EMACS_SETTINGS): A new type derived from GObject to handle
2345 GSettings notifications.
2346 (emacs_settings_constructor, emacs_settings_get_property)
2347 (emacs_settings_set_property, emacs_settings_class_init):
2349 (gsettings_client, gsettings_obj): New variables.
2350 (GSETTINGS_SCHEMA): New define.
2351 (something_changedCB): Call store_monospaced_changed.
2352 (init_gsettings): New function.
2353 (xsettings_initialize): Call init_gsettings.
2354 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2357 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2360 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2362 * window.c (resize_root_window, grow_mini_window)
2363 (shrink_mini_window): Rename Qresize_root_window to
2364 Qwindow_resize_root_window and Qresize_root_window_vertically to
2365 Qwindow_resize_root_window_vertically.
2367 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2369 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2371 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2373 * makefile.w32-in: Redesign dependencies so they reflect more
2374 clearly which files are directly included by each source file,
2375 and not through other includes.
2377 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2379 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2380 (sort_overlays, overlay_strings): When an overlay's clone number
2381 matches the window's clone number process the overlay even if
2382 the overlay's window property doesn't match the current window.
2384 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2385 (Fwindow_hchild): Rename to Fwindow_left_child.
2386 (Fwindow_next): Rename to Fwindow_next_sibling.
2387 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2388 (resize_window_check): Rename to window_resize_check.
2389 (resize_window_apply): Rename to window_resize_apply.
2390 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2391 (Fdelete_other_windows_internal, resize_frame_windows)
2392 (Fsplit_window_internal, Fdelete_window_internal)
2393 (grow_mini_window, shrink_mini_window)
2394 (Fresize_mini_window_internal): Fix callers accordingly.
2396 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2398 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2399 (emacs_fixed_set_min_size): Remove.
2400 (emacs_fixed_new): Take frame as argument.
2402 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2403 (_EmacsFixedPrivate): Remove minwidth/height.
2404 Add struct frame *f.
2405 (emacs_fixed_init): Initialize priv->f.
2406 (get_parent_class, emacs_fixed_set_min_size): Remove.
2407 (emacs_fixed_new): Set priv->f to argument.
2408 (emacs_fixed_get_preferred_width)
2409 (emacs_fixed_get_preferred_height): Use min_width/height from
2410 frames size_hint to set minimum and natural (Bug#8919).
2411 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2412 and use min_width/height from frames size_hint to set
2413 min_width/height (Bug#8919).
2415 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2416 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2419 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2421 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2422 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2425 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2427 * process.c (wait_reading_process_output): Bypass select if
2428 waiting for a cell while ignoring keyboard input, and input is
2429 pending. Suggested by Jan Djärv (Bug#8869).
2431 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2433 Use gnulib's dup2 module instead of rolling our own.
2434 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2436 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2438 * dispnew.c (scrolling_window): Before scrolling, turn off a
2439 mouse-highlight in the window being scrolled.
2441 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2443 Move DEFSYM to lisp.h and use everywhere.
2445 * character.h (DEFSYM): Move declaration...
2446 * lisp.h (DEFSYM): ...here.
2452 * w32select.c: Don't include character.h.
2454 * alloc.c (syms_of_alloc):
2455 * buffer.c (syms_of_buffer):
2456 * bytecode.c (syms_of_bytecode):
2457 * callint.c (syms_of_callint):
2458 * casefiddle.c (syms_of_casefiddle):
2459 * casetab.c (init_casetab_once):
2460 * category.c (init_category_once, syms_of_category):
2461 * ccl.c (syms_of_ccl):
2462 * cmds.c (syms_of_cmds):
2463 * composite.c (syms_of_composite):
2464 * dbusbind.c (syms_of_dbusbind):
2465 * dired.c (syms_of_dired):
2466 * dispnew.c (syms_of_display):
2467 * doc.c (syms_of_doc):
2468 * editfns.c (syms_of_editfns):
2469 * emacs.c (syms_of_emacs):
2470 * eval.c (syms_of_eval):
2471 * fileio.c (syms_of_fileio):
2472 * fns.c (syms_of_fns):
2473 * frame.c (syms_of_frame):
2474 * fringe.c (syms_of_fringe):
2475 * insdel.c (syms_of_insdel):
2476 * keymap.c (syms_of_keymap):
2477 * lread.c (init_obarray, syms_of_lread):
2478 * macros.c (syms_of_macros):
2479 * msdos.c (syms_of_msdos):
2480 * print.c (syms_of_print):
2481 * process.c (syms_of_process):
2482 * search.c (syms_of_search):
2483 * sound.c (syms_of_sound):
2484 * syntax.c (init_syntax_once, syms_of_syntax):
2485 * terminal.c (syms_of_terminal):
2486 * textprop.c (syms_of_textprop):
2487 * undo.c (syms_of_undo):
2488 * w32.c (globals_of_w32):
2489 * window.c (syms_of_window):
2490 * xdisp.c (syms_of_xdisp):
2491 * xfaces.c (syms_of_xfaces):
2492 * xfns.c (syms_of_xfns):
2493 * xmenu.c (syms_of_xmenu):
2494 * xsettings.c (syms_of_xsettings):
2495 * xterm.c (syms_of_xterm): Use DEFSYM.
2497 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2499 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2501 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2503 Integer and buffer overflow fixes (Bug#8873).
2505 * print.c (printchar, strout): Check for string overflow.
2506 (PRINTPREPARE, printchar, strout):
2507 Don't set size unless allocation succeeds.
2509 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2510 for sizes. Check for string overflow more accurately.
2511 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2513 * macros.c: Integer and buffer overflow fixes.
2514 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2515 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2516 Use ptrdiff_t, not int, for sizes.
2517 Don't increment bufsize until after realloc succeeds.
2518 Check for size-calculation overflow.
2519 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2521 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2523 * lread.c: Integer overflow fixes.
2524 (read_integer): Radix is now EMACS_INT, not int,
2525 to improve quality of diagnostics for out-of-range radices.
2526 Calculate buffer size correctly for out-of-range radices.
2527 (read1): Check for integer overflow in radices, and in
2528 read-circle numbers.
2529 (read_escape): Avoid int overflow.
2530 (Fload, openp, read_buffer_size, read1)
2531 (substitute_object_recurse, read_vector, read_list, map_obarray):
2532 Use ptrdiff_t, not int, for sizes.
2533 (read1): Use EMACS_INT, not int, for sizes.
2534 Check for size overflow.
2536 * image.c (cache_image): Check for size arithmetic overflow.
2538 * lread.c: Integer overflow issues.
2539 (saved_doc_string_size, saved_doc_string_length)
2540 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2541 Now ptrdiff_t, not int.
2542 (read1): Don't assume doc string length fits in int. Check for
2543 out-of-range doc string lengths.
2544 (read_list): Don't assume file position fits in int.
2545 (read_escape): Check for hex character overflow.
2547 2011-06-22 Leo Liu <sdl.web@gmail.com>
2549 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2550 Move to minibuffer.el.
2552 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2554 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2555 The following patches are for when GLYPH_DEBUG && !XASSERT.
2556 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2557 * dispnew.c (flush_stdout):
2558 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2559 Mark as externally visible.
2560 * dispnew.c (check_window_matrix_pointers): Now static.
2561 * dispnew.c (window_to_frame_vpos):
2562 * xfns.c (unwind_create_frame):
2563 * xterm.c (x_check_font): Remove unused local.
2564 * scroll.c (CHECK_BOUNDS):
2565 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2566 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2567 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2568 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2569 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2571 (debug_method_add): Use va_list and vsprintf rather than relying
2572 on undefined behavior with wrong number of arguments.
2573 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2574 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2575 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2576 since we're not interested in debugging glyphs with old libraries.
2577 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2578 GCC 4.6.0's static checking.
2580 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2582 Integer overflow and signedness fixes (Bug#8873).
2583 A few related buffer overrun fixes, too.
2585 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2587 * dispextern.h (struct face.stipple):
2588 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2589 (x_bitmap_mask, x_allocate_bitmap_record)
2590 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2591 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2592 (x_create_bitmap_from_xpm_data):
2593 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2594 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2596 * xfaces.c (load_pixmap):
2597 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2598 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2599 (.bitmaps_last, struct x_output.icon_bitmap):
2600 Use ptrdiff_t, not int, for bitmap indexes.
2601 (x_allocate_bitmap_record): Check for size overflow.
2602 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2604 Use ptrdiff_t, not int, for overlay counts.
2605 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2606 * editfns.c (overlays_around, get_pos_property):
2607 * textprop.c (get_char_property_and_overlay):
2608 * xdisp.c (next_overlay_change, note_mouse_highlight):
2609 * xfaces.c (face_at_buffer_position):
2610 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2611 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2612 (Fnext_overlay_change, Fprevious_overlay_change)
2613 (mouse_face_overlay_overlaps, Foverlays_in):
2614 Use ptrdiff_t, not int, for sizes.
2615 (overlays_at, overlays_in): Check for size-calculation overflow.
2617 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2619 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2620 (x_session_initialize): Do not assume string length fits in int.
2622 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2623 This is unlikely, but can occur if DPI is outlandish.
2625 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2626 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2628 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2629 * xrdb.c (magic_file_p, search_magic_path):
2630 Omit last arg SUFFIX; it was always 0. All callers changed.
2631 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2633 * xfont.c (xfont_match): Avoid need for strlen.
2635 * xfns.c: Don't assume strlen fits in int.
2636 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2638 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2639 not unsigned long, as we prefer signed integers. All callers changed.
2640 Detect integer overflow in repeat count.
2641 (message_dolog): Don't assume print length fits in 39 bytes.
2642 (display_mode_element): Don't assume strlen fits in int.
2644 * termcap.c: Don't assume sizes fit in int and never overflow.
2645 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2646 (gobble_line): Check for size-calculation overflow.
2648 * minibuf.c (Fread_buffer):
2649 * lread.c (intern, intern_c_string):
2650 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2651 Don't assume string length fits in int.
2653 * keyboard.c (parse_tool_bar_item):
2654 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2656 * font.c: Don't assume string length fits in int.
2657 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2658 Use ptrdiff_t, not int.
2659 (font_intern_prop): Don't assume string length fits in int.
2660 Don't assume integer property fits in fixnum.
2661 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2663 * filelock.c: Fix some buffer overrun and integer overflow issues.
2664 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2665 Reformulate so as not to need the command string.
2666 Invoke gzip -cd rather than gunzip, as it's more portable.
2667 (lock_info_type, lock_file_1, lock_file):
2668 Don't assume pid_t and time_t fit in unsigned long.
2669 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2670 (current_lock_owner): Prefer signed type for sizes.
2671 Use memcpy, not strncpy, where memcpy is what is really wanted.
2672 Don't assume (via atoi) that time_t and pid_t fit in int.
2673 Check for time_t and/or pid_t out of range, e.g., via a network share.
2674 Don't alloca where an auto var works fine.
2676 * fileio.c: Fix some integer overflow issues.
2677 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2678 Don't assume string length fits in int.
2679 (directory_file_name): Don't assume string length fits in long.
2680 (make_temp_name): Don't assume pid fits in int, or that its print
2681 length is less than 20.
2683 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2685 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2687 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2689 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2690 We prefer signed integers, even for size calculations.
2692 * emacs.c: Don't assume string length fits in 'int'.
2693 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2694 (main): Don't invoke strlen when not needed.
2696 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2697 (XD_DEBUG_MESSAGE): Don't waste a byte.
2699 * callproc.c (getenv_internal_1, getenv_internal)
2701 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2703 * lread.c (invalid_syntax): Omit length argument.
2704 All uses changed. This doesn't fix a bug, but it simplifies the
2705 code away from its former Hollerith-constant appearance, and it's
2706 one less 'int' to worry about when looking at integer-overflow issues.
2707 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2709 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2710 This didn't break anything, but it didn't help either.
2711 It's confusing to put a bogus integer in a place where the actual
2712 value does not matter.
2713 (LIST_END_P): Remove unused macro and its bogus comment.
2714 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2716 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2717 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2719 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2720 We prefer signed types, and the value cannot exceed the EMACS_INT
2721 range anyway (because otherwise the length would not be representable).
2722 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2723 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2724 This avoids a GCC warning when WIDE_EMACS_INT.
2726 * indent.c (sane_tab_width): New function.
2727 (current_column, scan_for_column, Findent_to, position_indentation)
2728 (compute_motion): Use it. This is just for clarity.
2729 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2731 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2733 * lisp.h (lint_assume): New macro.
2734 * composite.c (composition_gstring_put_cache):
2735 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2737 * editfns.c, insdel.c:
2738 Omit unnecessary forward decls, to simplify future changes.
2740 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2742 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2744 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2745 Use much-faster test for byte-length change.
2746 Don't assume string byte-length fits in 'int'.
2747 Check that character arg fits in 'int'.
2748 (mapcar1): Declare byte as byte, for clarity.
2750 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2752 * fns.c (concat): Catch string overflow earlier.
2753 Do not rely on integer wraparound.
2755 * dispextern.h (struct it.overlay_strings_charpos)
2756 (struct it.selective): Now EMACS_INT, not int.
2757 * xdisp.c (forward_to_next_line_start)
2758 (back_to_previous_visible_line_start)
2759 (reseat_at_next_visible_line_start, next_element_from_buffer):
2760 Don't arbitrarily truncate the value of 'selective' to int.
2762 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2764 * composite.c: Don't truncate sizes to 'int'.
2765 (composition_gstring_p, composition_reseat_it)
2766 (composition_adjust_point): Use EMACS_INT, not int.
2767 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2768 not EMACS_UINT, for indexes.
2770 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2772 * buffer.c: Include <verify.h>.
2773 (struct sortvec.priority, struct sortstr.priority):
2774 Now EMACS_INT, not int.
2775 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2776 (struct sortstr.size, record_overlay_string)
2777 (struct sortstrlist.size, struct sortlist.used):
2778 Don't truncate size to int.
2779 (record_overlay_string): Check for size-calculation overflow.
2780 (init_buffer_once): Check at compile-time, not run-time.
2782 2011-06-22 Jim Meyering <meyering@redhat.com>
2784 Don't leak an XBM-image-sized buffer
2785 * image.c (xbm_load): Free the image buffer after using it.
2787 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2790 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2791 that Sun C diagnosed.
2792 * fns.c (secure_hash): Fix pointer signedness issue.
2793 * intervals.c (static_offset_intervals): New function.
2794 (offset_intervals): Use it.
2796 2011-06-21 Leo Liu <sdl.web@gmail.com>
2799 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2802 * fns.c (secure_hash): Rename from crypto_hash_function and change
2803 the first arg to accept symbols.
2804 (Fsecure_hash): New primitive.
2805 (syms_of_fns): New symbols.
2807 2011-06-20 Deniz Dogan <deniz@dogan.se>
2809 * process.c (Fset_process_buffer): Clarify return value in
2812 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2814 * dispnew.c (add_window_display_history): Use BVAR.
2816 * xdisp.c (debug_method_add): Use BVAR.
2817 (check_window_end, dump_glyph_matrix, dump_glyph)
2818 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2820 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2823 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2824 check till after the cache is created in init_frame_faces.
2826 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2828 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2830 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2832 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2833 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2834 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2836 Improve buffer-overflow checking (Bug#8873).
2837 * fileio.c (Finsert_file_contents):
2838 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2839 Remove the old (too-loose) buffer overflow checks.
2840 They weren't needed, since make_gap checks for buffer overflow.
2841 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2842 The old code merely checked for Emacs fixnum overflow, and relied
2843 on undefined (wraparound) behavior. The new code avoids undefined
2844 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2846 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2847 Tune. Don't use wider integers than needed. Don't use alloca.
2848 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2850 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2852 * insdel.c, lisp.h (buffer_overflow): New function.
2853 (insert_from_buffer_1, replace_range, replace_range_2):
2854 * insdel.c (make_gap_larger):
2855 * editfns.c (Finsert_char):
2856 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2858 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2860 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2862 Integer overflow and signedness fixes (Bug#8873).
2864 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2865 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2867 * fileio.c: Don't assume EMACS_INT fits in off_t.
2868 (emacs_lseek): New static function.
2869 (Finsert_file_contents, Fwrite_region): Use it.
2870 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2872 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2874 * fns.c: Don't overflow int when computing a list length.
2875 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2876 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2877 truncation on 64-bit hosts. Check for QUIT every
2878 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2879 faster and is responsive enough.
2880 (Flength): Report an error instead of overflowing an integer.
2881 (Fsafe_length): Return a float if the value is not representable
2882 as a fixnum. This shouldn't happen except in contrived situations.
2883 (Fnthcdr, Fsort): Don't assume list length fits in int.
2884 (Fcopy_sequence): Don't assume vector length fits in int.
2886 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2887 (header_size, word_size): New constants.
2888 (allocate_vectorlike): Don't check size overflow here.
2889 (allocate_vector): Check it here instead, since this is the only
2890 caller of allocate_vectorlike that could cause overflow.
2891 Check that the new vector's length is representable as a fixnum.
2893 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2894 The previous code was bogus. For example, next_almost_prime (32)
2895 returned 39, which is undesirable as it is a multiple of 3; and
2896 next_almost_prime (24) returned 25, which is a multiple of 5 so
2897 why was the code bothering to check for multiples of 7?
2899 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2901 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2903 Variadic C functions now count arguments with ptrdiff_t.
2904 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2905 Back then I didn't know that the Emacs coding style prefers signed int.
2906 Also, in the meantime I found a few more instances where arguments
2907 were being counted with int, which may truncate counts on 64-bit
2908 machines, or EMACS_INT, which may be unnecessarily wide.
2909 * lisp.h (struct Lisp_Subr.function.aMANY)
2910 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2911 Arg counts are now ptrdiff_t, not size_t.
2912 All variadic functions and their callers changed accordingly.
2913 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2914 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2915 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2916 * callint.c (Fcall_interactively): Check arg count for overflow,
2917 to avoid potential buffer overrun. Use signed char, not 'int',
2918 for 'varies' array, so that we needn't bother to check its size
2919 calculation for overflow.
2920 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2921 * eval.c (apply_lambda):
2922 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2923 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2924 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2926 * callint.c (Fcall_interactively): Don't use index var as event count.
2928 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2929 * mem-limits.h (SIZE): Remove; no longer used.
2931 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2933 Remove unnecessary casts.
2934 * xterm.c (x_term_init):
2935 * xfns.c (x_set_border_pixel):
2936 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2937 These aren't needed now that we assume ANSI C.
2939 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2940 It's more likely to cause problems (due to unsigned overflow)
2943 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2945 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2947 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2949 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2951 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2953 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2955 GLYPH_CODE_FACE returns EMACS_INT, not int.
2956 * dispextern.h (merge_faces):
2957 * xfaces.c (merge_faces):
2958 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2959 Don't assume EMACS_INT fits in int.
2961 * character.h (CHAR_VALID_P): Remove unused parameter.
2962 * fontset.c, lisp.h, xdisp.c: All uses changed.
2964 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2966 * fns.c (concat): Minor tuning based on overflow analysis.
2967 This doesn't fix any bugs. Use int to hold character, instead
2968 of constantly refetching from Emacs object. Use XFASTINT, not
2969 XINT, for value known to be a character. Don't bother comparing
2970 a single byte to 0400, as it's always less.
2972 * floatfns.c (Fexpt):
2973 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2975 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2978 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2980 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2981 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2982 incorrectly succeed when S was a string, because 4294967386 was
2983 truncated before it was used.
2985 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2986 Otherwise, an out-of-range integer could cause undefined behavior
2989 * composite.c: Use int, not EMACS_INT, for characters.
2990 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2991 EMACS_INT, for values that are known to be in character range.
2992 This doesn't fix any bugs but is the usual style inside Emacs and
2993 may generate better code on 32-bit machines.
2995 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2996 This is for reasons similar to the recent CHAR_STRING fix.
2997 * charset.c (Fencode_char): Check that character arg is actually
2998 a character. Pass an int to ENCODE_CHAR.
2999 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3000 wider than 'int', as a compile-time check to prevent future regressions
3003 * character.c (char_string): Remove unnecessary casts.
3005 Make sure a 64-bit char is never passed to CHAR_STRING.
3006 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3007 by silently ignoring the top 32 bits, allowing some values
3008 that were far too large to be valid characters.
3009 * character.h: Include <verify.h>.
3010 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3011 arguments are no wider than unsigned, as a compile-time check
3012 to prevent future regressions in this area.
3014 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3015 (Fsubst_char_in_region):
3017 * xdisp.c (decode_mode_spec_coding):
3018 Adjust to CHAR_STRING's new requirement.
3019 * editfns.c (Finsert_char, Fsubst_char_in_region):
3020 * fns.c (concat): Check that character args are actually
3021 characters. Without this test, these functions did the wrong
3022 thing with wildly out-of-range values on 64-bit hosts.
3024 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3025 These casts should not be needed on 32-bit hosts, either.
3026 * keyboard.c (read_char):
3027 * lread.c (Fload): Remove casts to unsigned.
3029 * lisp.h (UNSIGNED_CMP): New macro.
3030 This fixes comparison bugs on 64-bit hosts.
3031 (ASCII_CHAR_P): Use it.
3032 * casefiddle.c (casify_object):
3033 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3034 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3035 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3036 * dispextern.h (FACE_FROM_ID):
3037 * keyboard.c (read_char): Use UNSIGNED_CMP.
3039 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3040 not to EMACS_INT, to avoid GCC warning.
3042 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3044 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3045 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3046 isn't needed on 32-bit machines.
3048 * buffer.c (Fgenerate_new_buffer_name):
3049 Use EMACS_INT for count, not int.
3050 (advance_to_char_boundary): Return EMACS_INT, not int.
3052 * data.c (Qcompiled_function): Now static.
3054 * window.c (window_body_lines): Now static.
3056 * image.c (gif_load): Rename local to avoid shadowing.
3058 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3059 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3060 * alloc.c (make_save_value): Integer argument is now of type
3062 (mark_object): Use ptrdiff_t, not int.
3063 * lisp.h (pD): New macro.
3064 * print.c (print_object): Use it.
3066 * alloc.c: Use EMACS_INT, not int, to count objects.
3067 (total_conses, total_markers, total_symbols, total_vector_size)
3068 (total_free_conses, total_free_markers, total_free_symbols)
3069 (total_free_floats, total_floats, total_free_intervals)
3070 (total_intervals, total_strings, total_free_strings):
3071 Now EMACS_INT, not int. All uses changed.
3072 (Fgarbage_collect): Compute overall total using a double, so that
3073 integer overflow is less likely to be a problem. Check for overflow
3074 when converting back to an integer.
3075 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3076 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3077 These were 'int' variables that could overflow on 64-bit hosts;
3078 they were never used, so remove them instead of repairing them.
3079 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3080 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3081 Previously, this ceilinged at INT_MAX, but that doesn't work on
3083 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3085 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3086 (allocate_vectorlike): Check for ptrdiff_t overflow.
3087 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3088 when a (possibly-narrower) signed value would do just as well.
3089 We prefer using signed arithmetic, to avoid comparison confusion.
3091 * alloc.c: Catch some string size overflows that we were missing.
3092 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3093 for convenience in STRING_BYTES_MAX.
3094 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3095 The definition here is exact; the one in lisp.h was approximate.
3096 (allocate_string_data): Check for string overflow. This catches
3097 some instances we weren't catching before. Also, it catches
3098 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3099 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3100 and ptrdiff_t and EMACS_INT are both 64 bits.
3102 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3103 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3104 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3106 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3108 * alloc.c (Fmake_string): Check for out-of-range init.
3110 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3112 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3114 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3116 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3117 xg_get_default_scrollbar_width.
3119 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3120 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3121 (style_changed_cb): Call update_theme_scrollbar_width and call
3122 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3123 all frames (Bug#8505).
3124 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3125 Call gtk_window_set_resizable if HAVE_GTK3.
3126 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3127 and height if HAVE_GTK3 (Bug#8505).
3128 (scroll_bar_width_for_theme): New variable.
3129 (update_theme_scrollbar_width): New function.
3130 (xg_get_default_scrollbar_width): Move code to
3131 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3132 (xg_initialize): Call update_theme_scrollbar_width.
3134 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3136 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3138 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3140 * frame.c (make_frame): Call other_buffer_safely instead of
3143 * window.c (temp_output_buffer_show): Call display_buffer with
3144 second argument Vtemp_buffer_show_specifiers and reset latter
3145 immediately after the call.
3146 (Vtemp_buffer_show_specifiers): New variable.
3147 (auto_window_vscroll_p, next_screen_context_lines)
3148 (Vscroll_preserve_screen_position): Remove leading asterisks from
3151 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3153 Fix minor problems found by GCC 4.6.0 static checking.
3154 * buffer.c (Qclone_number): Remove for now, as it's unused.
3155 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3156 (record_buffer): Remove unused local.
3157 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3158 (set_frame_buffer_list): Remove; unused.
3159 * frame.h (other_visible_frames): Remove decl.
3160 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3161 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3162 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3164 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3165 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3166 Define only if HAVE_GPM.
3167 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3168 (update_hints_inhibit): Remove; never set. All uses removed.
3169 * widgetprv.h (emacsFrameClassRec): Remove decl.
3170 * window.c (delete_deletable_window): Now returns void, since it
3171 wasn't returning anything.
3172 (compare_window_configurations): Remove unused locals.
3173 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3174 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3175 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3176 the same widths as pointers. This follows up on the 2011-05-06 patch.
3177 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3178 * xterm.h: Likewise.
3179 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3181 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3183 * makefile.w32-in: Update dependencies.
3184 (LISP_H): Add lib/intprops.h.
3186 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3188 * image.c (gif_load): Add animation frame delay to the metadata.
3189 (syms_of_image): Use DEFSYM. New symbol `delay'.
3191 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3193 * window.c (delete_deletable_window): Re-add.
3194 (Fset_window_configuration): Rewrite to handle dead buffers and
3195 consequently deletable windows.
3196 (window_tree, Fwindow_tree): Remove. Supply functionality in
3198 (compare_window_configurations): Simplify code.
3200 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3202 * image.c (imagemagick_load_image): Fix type mismatch.
3203 (Fimagemagick_types): Likewise.
3205 * window.h (replace_buffer_in_windows): Declare.
3207 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3209 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3210 Qclone_number. Remove external declaration of Qdelete_window.
3211 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3213 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3214 Run Qbuffer_list_update_hook if allowed.
3215 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3216 buffer list implementation.
3217 (other_buffer_safely): New function.
3218 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3219 calls to replace_buffer_in_windows and
3220 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3222 (record_buffer): Inhibit quitting and rewrite using quittable
3223 functions. Run Qbuffer_list_update_hook if allowed.
3224 (Frecord_buffer, Funrecord_buffer): New functions.
3225 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3226 Move switch-to-buffer to window.el.
3227 (bury-buffer): Move to window.el.
3228 (Vbuffer_list_update_hook): New variable.
3230 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3233 * window.h (resize_frame_windows): Move up in code.
3234 (Fwindow_frame): Remove EXFUN.
3235 (replace_buffer_in_all_windows): Remove prototype.
3236 (replace_buffer_in_windows_safely): Add prototype.
3238 * window.c: Declare Qdelete_window static again. Move down
3239 declaration of select_count.
3240 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3241 (Fother_window): Move to window.el.
3242 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3243 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3244 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3246 (replace_buffer_in_windows): Implement by calling
3247 Qreplace_buffer_in_windows.
3248 (replace_buffer_in_all_windows): Remove with some functionality
3249 moved into replace_buffer_in_windows_safely.
3250 (replace_buffer_in_windows_safely): New function.
3251 (select_window_norecord, select_frame_norecord): Move in front
3252 of run_window_configuration_change_hook. Remove now obsolete
3254 (Fset_window_buffer): Rewrite doc-string.
3255 Call Qrecord_window_buffer.
3256 (keys_of_window): Move binding for other-window to window.el.
3258 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3260 * dispextern.h (struct image): Replace data member, whose int_val
3261 and ptr_val fields were not used by anything, with a single
3264 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3265 (gif_clear_image, gif_load, imagemagick_load_image)
3266 (gs_clear_image, gs_load): Callers changed.
3268 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3270 * buffer.h: Include <time.h>, for time_t.
3271 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3273 Fix minor problems found by static checking.
3275 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3277 Make identifiers static if they are not used in other modules.
3278 * data.c (Qcompiled_function, Qframe, Qvector):
3279 * image.c (QimageMagick, Qsvg):
3280 * minibuf.c (Qmetadata):
3281 * window.c (resize_window_check, resize_root_window): Now static.
3282 * window.h (resize_window_check, resize_root_window): Remove decls.
3284 * window.c (window_deletion_count, delete_deletable_window):
3286 (window_body_lines): Now static.
3287 (Fdelete_other_windows_internal): Mark vars as initialized.
3288 Make sure 'resize_failed' is initialized.
3289 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3290 (resize_window_apply): Remove unused local.
3291 * window.h (delete_deletable_window): Remove decl.
3293 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3294 (imagemagick_load_image): Fix pointer signedness problem by changing
3295 last arg from unsigned char * to char *. All uses changed.
3296 Also, fix a local for similar reasons.
3297 Remove unused locals. Remove locals to avoid shadowing.
3298 (fn_rsvg_handle_free): Remove; unused.
3299 (svg_load, svg_load_image): Fix pointer signedness problem.
3300 (imagemagick_load_image): Don't use garbage pointer image_wand.
3302 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3304 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3306 * image.c (gif_load): Fix omitted cast error introduced by
3309 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3311 * window.h (resize_proportionally, orig_total_lines)
3312 (orig_top_line): Remove from window structure.
3313 (set_window_height, set_window_width, change_window_heights)
3314 (Fdelete_window): Remove prototypes.
3315 (resize_frame_windows): Remove duplicate declaration.
3317 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3319 * window.h (resize_frame_windows, resize_window_check)
3320 (delete_deletable_window, resize_root_window)
3321 (resize_frame_windows): Declare prototypes.
3323 * window.c (resize_window_apply): Make definition be "static" to
3324 match the prototype.
3326 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3328 * window.c: Remove declarations of Qwindow_size_fixed,
3329 window_min_size_1, window_min_size_2, window_min_size,
3330 size_window, window_fixed_size_p, enlarge_window, delete_window.
3331 Remove static from declaration of Qdelete_window, it's
3332 temporarily needed by Fbury_buffer.
3333 (replace_window): Don't assign orig_top_line and
3335 (Fdelete_window, delete_window): Remove. Window deletion is
3336 handled by window.el.
3337 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3338 Replace Fdelete_window calls with calls to Qdelete_window.
3339 (Fdelete_other_windows): Remove. Deleting other windows is
3340 handled by window.el.
3341 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3342 handled in window.el.
3343 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3344 Window minimum sizes are handled in window.el.
3345 (shrink_windows, size_window, set_window_height)
3346 (set_window_width, change_window_heights, window_height)
3347 (window_width, CURBEG, CURSIZE, enlarge_window)
3348 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3349 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3350 handled in window.el.
3351 (make_dummy_parent): Rename to make_parent_window and give it a
3352 second argument horflag.
3353 (make_window): Don't set resize_proportionally any more.
3354 (Fsplit_window): Remove. Windows are split in window.el.
3355 (save_restore_action, save_restore_orig_size)
3356 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3357 Resize mini windows in window.el.
3358 (grow_mini_window, shrink_mini_window): Implement by calling
3359 Qresize_root_window_vertically, resize_window_check and
3360 resize_window_apply.
3361 (saved_window, Fset_window_configuration, save_window_save):
3362 Do not handle orig_top_line, orig_total_lines, and
3363 resize_proportionally.
3364 (window_min_height, window_min_width): Move to window.el.
3365 (keys_of_window): Move bindings for delete-other-windows,
3366 split-window, delete-window and enlarge-window to window.el.
3368 * buffer.c: Temporarily extern Qdelete_window.
3369 (Fbury_buffer): Temporarily call Qdelete_window instead of
3370 Fdelete_window (Fbury_buffer will move to window.el soon).
3372 * frame.c (set_menu_bar_lines_1): Remove code handling
3373 orig_top_line and orig_total_lines.
3375 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3376 set_window_height but set heights directly.
3377 (change_frame_size_1): Use resize_frame_windows.
3379 * xdisp.c (init_xdisp): Don't use set_window_height but set
3382 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3383 Use resize_frame_windows instead of change_window_heights and run
3384 run_window_configuration_change_hook.
3386 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3387 instead of change_window_heights and run
3388 run_window_configuration_change_hook.
3390 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3392 * window.c (replace_window): Rename second argument REPLACEMENT to
3393 NEW. New third argument SETFLAG. Rewrite.
3394 (delete_window, make_dummy_parent): Call replace_window with
3396 (window_list_1): Move down in code.
3397 (run_window_configuration_change_hook): Move set_buffer part
3398 before select_frame_norecord part in order to unwind correctly.
3399 Rename count1 to count.
3400 (recombine_windows, delete_deletable_window, resize_root_window)
3401 (Fdelete_other_windows_internal)
3402 (Frun_window_configuration_change_hook, make_parent_window)
3403 (resize_window_check, resize_window_apply, Fresize_window_apply)
3404 (resize_frame_windows, Fsplit_window_internal)
3405 (Fdelete_window_internal, Fresize_mini_window_internal):
3407 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3409 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3411 * window.h (window): Add some new members to window structure -
3412 normal_lines, normal_cols, new_total, new_normal, clone_number,
3413 splits, nest, prev_buffers, next_buffers.
3414 (WINDOW_TOTAL_SIZE): Move here from window.c.
3415 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3417 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3419 (make_dummy_parent): Set new members of windows structure.
3420 (make_window): Move down in code. Handle new members of window
3422 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3423 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3424 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3425 (Fset_window_prev_buffers, Fwindow_next_buffers)
3426 (Fset_window_next_buffers, Fset_window_clone_number):
3428 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3429 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3431 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3432 Argument WINDOW can be now internal window too.
3433 (Fwindow_use_time): Move up in code.
3434 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3436 (Fset_window_configuration, saved_window)
3437 (Fcurrent_window_configuration, save_window_save): Handle new
3438 members of window structure.
3439 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3440 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3441 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3442 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3443 Qget_mru_window, Qresize_root_window,
3444 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3445 Qauto_buffer_name; staticpro them.
3447 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3449 * window.c (Fwindow_total_size, Fwindow_left_column)
3450 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3451 (Fwindow_list_1): New functions.
3452 (window_box_text_cols): Replace with window_body_cols.
3453 (Fwindow_width, Fscroll_left, Fscroll_right):
3454 Use window_body_cols instead of window_box_text_cols.
3455 (delete_window, Fset_window_configuration):
3456 Call delete_all_subwindows with window as argument.
3457 (delete_all_subwindows): Take a window as argument and not a
3459 (window_loop): Remove handling of GET_LRU_WINDOW and
3461 (Fget_lru_window, Fget_largest_window): Move to window.el.
3463 * window.h: Extern window_body_cols instead of
3464 window_box_text_cols. delete_all_subwindows now takes a
3465 Lisp_Object as argument.
3467 * indent.c (compute_motion, Fcompute_motion):
3468 Use window_body_cols instead of window_box_text_cols.
3470 * frame.c (delete_frame): Call delete_all_subwindows with root
3473 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3475 * fns.c (Fputhash): Document return value.
3477 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3479 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3481 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3483 Cons<->int and similar integer overflow fixes (Bug#8794).
3485 Check for overflow when converting integer to cons and back.
3486 * charset.c (Fdefine_charset_internal, Fdecode_char):
3487 Use cons_to_unsigned to catch overflow.
3488 (Fencode_char): Use INTEGER_TO_CONS.
3489 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3490 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3491 * data.c (long_to_cons, cons_to_long): Remove.
3492 (cons_to_unsigned, cons_to_signed): New functions.
3493 These signal an error for invalid or out-of-range values.
3494 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3495 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3496 * font.c (Ffont_variation_glyphs):
3497 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3498 * lisp.h: Include <intprops.h>.
3499 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3500 (cons_to_signed, cons_to_unsigned): New decls.
3501 (long_to_cons, cons_to_long): Remove decls.
3502 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3503 (Fprimitive_undo): Use CONS_TO_INTEGER.
3504 * xfns.c (Fx_window_property): Likewise.
3505 * xselect.c: Include <limits.h>.
3506 (x_own_selection, selection_data_to_lisp_data):
3507 Use INTEGER_TO_CONS.
3508 (x_handle_selection_request, x_handle_selection_clear)
3509 (x_get_foreign_selection, Fx_disown_selection_internal)
3510 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3511 (lisp_data_to_selection_data): Use cons_to_unsigned.
3512 (x_fill_property_data): Use cons_to_signed.
3513 Report values out of range.
3515 Check for buffer and string overflow more precisely.
3516 * buffer.h (BUF_BYTES_MAX): New macro.
3517 * lisp.h (STRING_BYTES_MAX): New macro.
3518 * alloc.c (Fmake_string):
3519 * character.c (string_escape_byte8):
3520 * coding.c (coding_alloc_by_realloc):
3521 * doprnt.c (doprnt):
3522 * editfns.c (Fformat):
3524 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3525 since they may not be the same number.
3526 * editfns.c (Finsert_char):
3527 * fileio.c (Finsert_file_contents):
3528 Likewise for BUF_BYTES_MAX.
3530 * image.c: Use ptrdiff_t, not int, for sizes.
3531 (slurp_file): Switch from int to ptrdiff_t.
3533 (slurp_file): Check that file size fits in both size_t (for
3534 malloc) and ptrdiff_t (for sanity and safety).
3536 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3537 if b->modtime has its maximal value.
3539 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3541 Don't assume time_t can fit into int.
3542 * buffer.h (struct buffer.modtime): Now time_t, not int.
3543 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3544 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3546 Minor fixes for signed vs unsigned integers.
3547 * character.h (MAYBE_UNIFY_CHAR):
3548 * charset.c (maybe_unify_char):
3549 * keyboard.c (read_char, reorder_modifiers):
3550 XINT -> XFASTINT, since the integer must be nonnegative.
3551 * ftfont.c (ftfont_spec_pattern):
3552 * keymap.c (access_keymap, silly_event_symbol_error):
3553 XUINT -> XFASTINT, since the integer must be nonnegative.
3554 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3555 since it makes no difference and we prefer signed.
3556 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3557 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3560 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3562 * window.h (Fwindow_frame): Declare.
3564 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3566 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3567 (SPARE_MEMORY): Always define.
3568 (LARGE_REQUEST): Remove.
3569 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3571 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3573 * lisp.h: Move EXFUNS for Fframe_root_window,
3574 Fframe_first_window and Fset_frame_selected_window to window.h.
3576 * window.h: Move EXFUNS for Fframe_root_window,
3577 Fframe_first_window and Fset_frame_selected_window here from
3580 * frame.c (Fwindow_frame, Fframe_first_window)
3581 (Fframe_root_window, Fframe_selected_window)
3582 (Fset_frame_selected_window): Move to window.c.
3583 (Factive_minibuffer_window): Move to minibuf.c.
3584 (Fother_visible_frames_p): New function.
3586 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3588 * window.c (decode_window, decode_any_window): Move up in code.
3589 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3590 (inhibit_frame_unsplittable): Remove unused variable.
3591 (Fwindow_buffer): Move up and rewrite doc-string.
3592 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3593 (Fwindow_prev): New functions.
3594 (Fwindow_frame): Move here from frame.c. Accept any window as
3596 (Fframe_root_window, Fframe_first_window)
3597 (Fframe_selected_window): Move here from frame.c. Accept frame
3598 or arbitrary window as argument. Update doc-strings.
3599 (Fminibuffer_window): Move up in code.
3600 (Fwindow_minibuffer_p): Move up in code and simplify.
3601 (Fset_frame_selected_window): Move here from frame.c.
3603 (Fselected_window, select_window, Fselect_window): Move up in
3604 code. Minor doc-string fixes.
3606 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3608 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3609 Do not assume that spare memory exists; that assumption is valid
3610 only if SYSTEM_MALLOC.
3611 (LARGE_REQUEST): New macro, so that the issue of large requests
3612 is separated from the issue of spare memory.
3614 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3616 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3619 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3621 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3624 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3626 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3628 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3630 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3631 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3633 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3635 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3637 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3639 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3640 (x_clipboard_manager_save): Add return value.
3641 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3643 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3644 Obey Vx_select_enable_clipboard_manager. Catch errors in
3645 x_clipboard_manager_save (Bug#8779).
3646 (Vx_select_enable_clipboard_manager): New variable.
3647 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3649 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3651 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3653 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3655 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3656 in the current matrix if keep_current_p is non-zero.
3658 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3660 * bidi.c (bidi_level_of_next_char): Fix last change.
3662 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3664 Support bidi reordering of text covered by display properties.
3666 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3667 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3668 (bidi_cache_search, bidi_cache_iterator_state)
3669 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3670 (bidi_level_of_next_char, bidi_move_to_visually_next):
3671 Support character positions inside a run of characters covered by a
3673 (bidi_paragraph_init, bidi_resolve_explicit_1)
3674 (bidi_level_of_next_char): Call bidi_fetch_char and
3675 bidi_fetch_char_advance instead of FETCH_CHAR and
3677 (bidi_init_it): Initialize new members.
3678 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3680 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3681 instead of using explicit *_CHAR codes.
3682 (bidi_resolve_explicit, bidi_resolve_weak):
3683 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3684 bidirectional text is supported only in multibyte buffers.
3685 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3686 it to initialize the frame_window_p member of struct bidi_it.
3687 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3688 (bidi_resolve_explicit, bidi_resolve_weak)
3689 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3690 bidi_it->nchars is non-positive.
3691 (bidi_level_of_next_char): Don't try to lookup the cache for the
3692 next/previous character if nothing is cached there yet, or if we
3693 were just reseat()'ed to a new position.
3695 * xdisp.c (set_cursor_from_row): Set start and stop points
3696 according to the row's direction when priming the loop that looks
3697 for the glyph on which to display cursor.
3698 (single_display_spec_intangible_p): Function deleted.
3699 (display_prop_intangible_p): Reimplement to call
3700 handle_display_spec instead of single_display_spec_intangible_p.
3701 Accept 3 additional arguments needed by handle_display_spec.
3702 This fixes incorrect cursor motion across display property with complex
3703 values: lists, `(when COND...)' forms, etc.
3704 (single_display_spec_string_p): Support property values that are
3705 lists with the argument STRING its top-level element.
3706 (display_prop_string_p): Fix the condition for processing a
3707 property that is a list to be consistent with handle_display_spec.
3708 (handle_display_spec): New function, refactored from the
3709 last portion of handle_display_prop.
3710 (compute_display_string_pos): Accept additional argument
3711 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3712 value of a `display' property is a "replacing spec".
3713 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3714 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3715 the display property, but just return a value indicating whether
3716 the display property will replace the characters it covers.
3717 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3718 frame_window_p members of struct bidi_it.
3719 (compute_display_string_pos, compute_display_string_end):
3721 (push_it): Accept second argument POSITION, where pop_it should
3722 jump to continue iteration.
3723 (reseat_1): Initialize bidi_it.disp_pos.
3725 * keyboard.c (adjust_point_for_property): Adjust the call to
3726 display_prop_intangible_p to its new signature.
3728 * dispextern.h (struct bidi_it): New member frame_window_p.
3729 (bidi_init_it): Update prototypes.
3730 (display_prop_intangible_p): Update prototype.
3731 (compute_display_string_pos, compute_display_string_end):
3733 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3736 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3738 Malloc failure behavior now depends on size of allocation.
3739 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3740 * lisp.h: Change signatures accordingly.
3741 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3742 All callers changed. (Bug#8762)
3744 * gnutls.c: Use Emacs's memory allocators.
3745 Without this change, the gnutls library would invoke malloc etc.
3746 directly, which causes problems on non-SYNC_INPUT hosts, and which
3747 runs afoul of improving memory_full behavior. (Bug#8761)
3748 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3749 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3750 xfree instead of the default malloc, realloc, free.
3751 (Fgnutls_boot): No need to check for memory allocation failure,
3752 since xmalloc does that for us.
3754 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3755 * category.c (hash_get_category_set):
3756 * ccl.c (ccl_driver):
3757 * charset.c (Fdefine_charset_internal):
3758 * charset.h (struct charset.hash_index):
3759 * composite.c (get_composition_id, gstring_lookup_cache)
3760 (composition_gstring_put_cache):
3761 * composite.h (struct composition.hash_index):
3762 * dispextern.h (struct image.hash):
3763 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3764 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3765 (hashfn_equal, hashfn_user_defined, make_hash_table)
3766 (maybe_resize_hash_table, hash_lookup, hash_put)
3767 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3768 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3769 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3770 * image.c (make_image, search_image_cache, lookup_image)
3771 (xpm_put_color_table_h):
3772 * lisp.h (struct Lisp_Hash_Table):
3773 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3774 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3775 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3776 * alloc.c (allocate_vectorlike):
3777 Check for overflow in vector size calculations.
3778 * ccl.c (ccl_driver):
3779 Check for overflow when converting EMACS_INT to int.
3780 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3781 need to be updated by these changes.
3782 * fns.c (make_hash_table, maybe_resize_hash_table):
3783 Check for integer overflow with large hash tables.
3784 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3785 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3786 (SXHASH_REDUCE): New macro.
3787 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3788 Use it instead of discarding useful hash info with large hash values.
3789 (sxhash_float): New function.
3790 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3791 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3792 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3793 Rewrite to use FIXNUM_BITS, as this simplifies things.
3794 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3795 Adjust signatures to match updated version of code.
3796 (consing_since_gc): Now EMACS_INT, since a single hash table can
3797 use more than INT_MAX bytes.
3799 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3801 Make it possible to build with GCC-4.6+ -O2 -flto.
3803 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3805 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3807 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3808 Call minibuffer-inactive-mode.
3810 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3812 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3813 Update dependencies.
3815 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3817 * data.c (init_data): Remove code for UTS, this system is not
3820 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3822 Don't force ./temacs to start in terminal mode.
3824 * frame.c (make_initial_frame): Initialize faces in all cases, not
3825 only when CANNOT_DUMP is defined.
3826 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3828 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3830 * dispnew.c (add_window_display_history): Use const for the string
3831 pointer. Remove declaration, not needed.
3833 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3835 Use 'inline', not 'INLINE'.
3836 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3837 * alloc.c, fontset.c (INLINE): Remove.
3838 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3839 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3840 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3841 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3842 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3844 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3846 Make it possible to run ./temacs.
3848 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3849 syms_of_callproc does the same thing. Remove test for
3850 "initialized", do it in the caller.
3851 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3853 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3855 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3856 (read_minibuf): Use get_minibuffer.
3857 (syms_of_minibuf): Use DEFSYM.
3858 (Qmetadata): New var.
3859 * data.c (Qbuffer): Don't make it static.
3860 (syms_of_data): Use DEFSYM.
3862 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3864 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3865 (CCL_CODE_MIN): New macro.
3867 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3869 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3871 * eval.c (Qdebug): Now static.
3872 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3873 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3874 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3876 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3878 * image.c: Various fixes to ImageMagick code comments.
3879 (Fimagemagick_types): Doc fix.
3881 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3883 Minor fixes prompted by GCC 4.6.0 warnings.
3885 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3887 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3888 (x_clipboard_manager_save_all): Move extern decl to ...
3889 * xterm.h: ... here, so that it can be checked for consistency.
3891 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3893 * xselect.c (x_clipboard_manager_save_frame)
3894 (x_clipboard_manager_save_all): New functions.
3895 (Fx_clipboard_manager_save): Lisp function deleted.
3897 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3898 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3900 * xterm.h: Update prototype.
3902 2011-05-28 William Xu <william.xwl@gmail.com>
3904 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3907 2011-05-28 Jim Meyering <meyering@redhat.com>
3909 Avoid a sign-extension bug in crypto_hash_function.
3910 * fns.c (to_uchar): Define.
3911 (crypto_hash_function): Use it to convert some newly-signed
3912 variables to unsigned, to avoid sign-extension bugs. For example,
3913 without this change, (md5 "truc") would evaluate to
3914 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3915 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3916 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3918 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3920 Integer overflow fixes.
3922 * dbusbind.c: Serial number integer overflow fixes.
3923 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3924 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3925 to hold a serial number that is too large for a fixnum.
3926 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3927 Check for serial numbers out of range. Decode any serial number
3928 that was so large that it became a float. (Bug#8722)
3930 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3931 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3932 Use XFASTINT rather than XUINT when numbers are nonnegative.
3933 (xd_append_arg, Fdbus_method_return_internal):
3934 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3935 arguments, check that Lisp number is nonnegative, rather than
3936 silently wrapping negative numbers around. (Bug#8722)
3937 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3940 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3942 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3944 ccl: add integer overflow checks
3945 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3946 (IN_INT_RANGE): New macros.
3947 (ccl_driver): Use them to check for integer overflow when
3948 decoding a CCL program. Many of the new checks are whether XINT (x)
3949 fits in int; it doesn't always, on 64-bit hosts. The new version
3950 doesn't catch all possible integer overflows, but it's an
3951 improvement. (Bug#8719)
3953 * alloc.c (make_event_array): Use XINT, not XUINT.
3954 There's no need for unsigned here.
3956 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3957 This follows up to the 2011-05-06 change that substituted uintptr_t
3958 for EMACS_INT. This case wasn't caught back then.
3960 Rework Fformat to avoid integer overflow issues.
3961 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3962 now (part of C89). Include <verify.h>.
3963 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3964 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3965 (Fformat): Avoid the prepass trying to compute sizes; it was only
3966 approximate and thus did not catch overflow reliably. Instead, walk
3967 through the format just once, formatting and computing sizes as we go,
3968 checking for integer overflow at every step, and allocating a larger
3969 buffer as needed. Keep track separately whether the format is
3970 multibyte. Keep only the most-recently calculated precision, rather
3971 than them all. Record whether each argument has been converted to
3972 string. Use EMACS_INT, not int, for byte and char and arg counts.
3973 Support field widths and precisions larger than INT_MAX. Avoid
3974 sprintf's undefined behavior with conversion specifications such as %#d
3975 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3976 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3977 formatting out-of-range floating point numbers with int
3980 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3982 * data.c: Avoid integer truncation in expressions involving floats.
3983 * data.c: Include <intprops.h>.
3984 (arith_driver): When there's an integer overflow in an expression
3985 involving floating point, convert the integers to floating point
3986 so that the resulting value does not suffer from catastrophic
3987 integer truncation. For example, on a 64-bit host (* 4
3988 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3989 Do not rely on undefined behavior after integer overflow.
3991 merge count_size_as_multibyte, parse_str_to_multibyte
3992 * character.c, character.h (count_size_as_multibyte):
3993 Rename from parse_str_to_multibyte; all uses changed.
3994 Check for integer overflow.
3995 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3996 since it's now a duplicate of the other. This is more of
3997 a character than a buffer op, so better that it's in character.c.
3998 * fns.c, print.c: Adjust to above changes.
4000 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4002 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4004 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4006 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4007 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4008 (x_clipboard_manager_save): Now static.
4009 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4011 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4012 (crypto_hash_function): Now static.
4013 Fix pointer signedness problems. Avoid unnecessary initializations.
4015 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4017 * termhooks.h (Vselection_alist): Make it terminal-local.
4019 * terminal.c (create_terminal): Initialize it.
4021 * xselect.c: Support for clipboard managers.
4022 (Vselection_alist): Move to termhooks.h as terminal-local var.
4023 (LOCAL_SELECTION): New macro.
4024 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4025 (symbol_to_x_atom): Remove gratuitous arg.
4026 (x_handle_selection_request, lisp_data_to_selection_data)
4027 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4028 (x_own_selection, x_get_local_selection, x_convert_selection):
4029 New arg, specifying work frame. Use terminal-local Vselection_alist.
4030 (some_frame_on_display): Delete unused function.
4031 (Fx_own_selection_internal, Fx_get_selection_internal)
4032 (Fx_disown_selection_internal, Fx_selection_owner_p)
4033 (Fx_selection_exists_p): New optional frame arg.
4034 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4035 (x_handle_selection_clear): Don't treat other terminals with the
4036 same keyboard specially. Use the terminal-local Vselection_alist.
4037 (x_clear_frame_selections): Use Frun_hook_with_args.
4039 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4041 * xterm.h: Add support for those atoms.
4043 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4045 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4046 (converted_selections, conversion_fail_tag): New global variables.
4047 (x_selection_request_lisp_error): Free the above.
4048 (x_get_local_selection): Remove unnecessary code.
4049 (x_reply_selection_request): Args changed; handle arbitrary array
4050 of converted selections stored in converted_selections.
4051 Separate the XChangeProperty and SelectionNotify steps.
4052 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4053 (x_convert_selection): New function.
4054 (x_handle_selection_event): Simplify.
4055 (x_get_foreign_selection): Don't ignore incoming requests while
4056 waiting for an answer; this will fail when we implement
4057 SAVE_TARGETS, and seems unnecessary anyway.
4058 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4059 (Vx_sent_selection_functions): Doc fix.
4061 2011-05-26 Leo Liu <sdl.web@gmail.com>
4063 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4065 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4067 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4069 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4070 for fringe update if it has periodic bitmap.
4071 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4072 and fringe_bitmap_periodic_p.
4074 * fringe.c (get_fringe_bitmap_data): New function.
4075 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4076 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4077 row. Mark glyph row for fringe update if periodicity changed.
4079 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4080 for fringe update unless it has periodic bitmap.
4082 2011-05-25 Kenichi Handa <handa@m17n.org>
4084 * xdisp.c (get_next_display_element): Set correct it->face_id for
4085 a static composition.
4087 2011-05-24 Leo Liu <sdl.web@gmail.com>
4090 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4092 * fns.c (crypto_hash_function, Fsha1): New function.
4093 (Fmd5): Use crypto_hash_function.
4094 (syms_of_fns): Add Ssha1.
4096 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4098 * gnutls.c: Remove unused macros.
4099 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4100 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4101 Remove macros that are defined and never used.
4102 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4104 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4106 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4107 (Fx_get_selection_internal): Minor cleanup.
4108 (Fx_own_selection_internal): Rename arguments for consistency with
4111 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4113 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4115 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4117 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4119 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4121 * dispnew.c (scrolling_window): Don't exclude the case that the
4122 last enabled row in the desired matrix touches the bottom boundary.
4124 2011-05-21 Glenn Morris <rgm@gnu.org>
4126 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4127 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4128 and add some more files.
4130 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4132 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4133 report_file_error introduced by the change from 2011-05-07.
4135 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4137 * systime.h (Time): Define only if emacs is defined.
4138 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4139 where the include path doesn't have X11/X.h by default. See
4140 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4142 2011-05-20 Kenichi Handa <handa@m17n.org>
4144 * composite.c (find_automatic_composition): Fix previous change.
4146 2011-05-20 Glenn Morris <rgm@gnu.org>
4148 * lisp.mk: New file, split from Makefile.in.
4149 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4150 (shortlisp): Remove.
4151 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4153 2011-05-19 Glenn Morris <rgm@gnu.org>
4155 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4156 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4157 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4158 (lisp): Set the order to that of loadup.el.
4159 (shortlisp): Make it a copy of $lisp.
4160 (SOME_MACHINE_LISP): Remove.
4161 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4162 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4164 2011-05-18 Kenichi Handa <handa@m17n.org>
4166 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4167 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4168 (find_automatic_composition): Mostly rewrite for efficiency.
4170 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4172 * makefile.w32-in: Update dependencies.
4174 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4176 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4177 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4179 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4181 Fix some integer overflow issues, such as string length overflow.
4183 * insdel.c (count_size_as_multibyte): Check for string overflow.
4185 * character.c (lisp_string_width): Check for string overflow.
4186 Use EMACS_INT, not int, for string indexes and lengths; in
4187 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4188 the resulting string length overflows an EMACS_INT; instead,
4189 report a string overflow if no precision given. When checking for
4190 precision exhaustion, use a check that cannot possibly have
4191 integer overflow. (Bug#8675)
4192 * character.h (lisp_string_width): Adjust to new signature.
4194 * alloc.c (string_overflow): New function.
4195 (Fmake_string): Use it. This doesn't change behavior, but saves
4196 a few bytes and will simplify future changes.
4197 * character.c (string_escape_byte8): Likewise.
4198 * lisp.h (string_overflow): New decl.
4200 Fixups, following up to the user-interface timestamp change.
4201 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4202 for UI timestamps, instead of unsigned long.
4203 * msdos.c (mouse_get_pos): Likewise.
4204 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4205 * w32gui.h (Time): Define by including "systime.h" rather than by
4206 declaring it ourselves. (Bug#8664)
4208 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4209 * image.c (clear_image_cache): Likewise.
4211 * term.c (term_mouse_position): Don't assume time_t wraparound.
4213 Be more systematic about user-interface timestamps.
4214 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4215 and sometimes 'EMACS_UINT', to represent these timestamps.
4216 This change causes it to use 'Time' uniformly, as that's what X uses.
4217 This makes the code easier to follow, and makes it easier to catch
4218 integer overflow bugs such as Bug#8664.
4219 * frame.c (Fmouse_position, Fmouse_pixel_position):
4220 Use Time, not unsigned long, for user-interface timestamps.
4221 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4222 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4223 * keyboard.h (last_event_timestamp): Likewise.
4224 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4225 * menu.h (xmenu_show): Likewise.
4226 * term.c (term_mouse_position): Likewise.
4227 * termhooks.h (struct input_event.timestamp): Likewise.
4228 (struct terminal.mouse_position_hook): Likewise.
4229 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4230 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4231 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4232 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4234 * menu.h, termhooks.h: Include "systime.h", for Time.
4236 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4237 Don't assume that the difference between two unsigned long values
4238 can fit into an integer. At this point, we know button_down_time
4239 <= event->timestamp, so the difference must be nonnegative, so
4240 there's no need to cast the result if double-click-time is
4241 nonnegative, as it should be; check that it's nonnegative, just in
4242 case. This bug is triggered when events are more than 2**31 ms
4243 apart (about 25 days). (Bug#8664)
4245 * xselect.c (last_event_timestamp): Remove duplicate decl.
4246 (x_own_selection): Remove needless cast to unsigned long.
4248 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4249 that always fit in int. Use a sentinel instead of a counter, to
4250 avoid a temp and to allay GCC's concerns about possible int overflow.
4251 * frame.h (struct frame): Use int for menu_bar_items_used
4252 instead of EMACS_INT, since it always fits in int.
4254 * menu.c (grow_menu_items): Check for int overflow.
4256 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4258 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4259 Before, the code was not consistent. These values cannot exceed
4260 2**31 - 1 so there's no need to make them unsigned.
4261 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4262 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4263 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4265 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4267 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4268 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4269 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4270 presumably because the widths might not match.
4272 * window.c (size_window): Avoid needless test at loop start.
4274 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4276 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4278 2011-05-12 Drew Adams <drew.adams@oracle.com>
4280 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4282 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4284 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4285 `width' to `bar_area_x' and `bar_area_width', respectively.
4286 (x_scroll_run): Take account of fringe background extension.
4288 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4289 Rename local vars `left' and `width' to `bar_area_x' and
4290 `bar_area_width', respectively.
4291 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4292 background extension.
4294 2011-05-10 Jim Meyering <meyering@redhat.com>
4296 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4298 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4300 * image.c (Finit_image_library): Return t for built-in image types,
4301 like pbm and xbm. (Bug#8640)
4303 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4305 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4307 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4309 * w32console.c (Fset_screen_color): Doc fix.
4310 (Fget_screen_color): New function.
4311 (syms_of_ntterm): Defsubr it.
4313 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4314 unlink the temporary file if Fcall_process didn't create it in the
4316 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4317 child process will be redirected to a file specified with `:file'.
4318 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4319 cue to call_process_cleanup not to close that handle.
4321 2011-05-07 Ben Key <bkey76@gmail.com>
4323 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4324 one of two shell specific rules, either bootstrap-temacs-CMD or
4325 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4326 to the previous implementation of the bootstrap-temacs rule.
4327 The bootstrap-temacs-CMD rule is similar to the previous
4328 implementation of the bootstrap-temacs rule except that it
4329 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4332 These changes, along with some changes to nt/configure.bat,
4333 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4334 earlier fix to add support for --cflags and --ldflags options
4335 that include quotes so that it works whether make uses cmd or
4338 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4340 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4341 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4343 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4344 a string. Handle both cases.
4345 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4346 (Fdbus_register_method): Use Qinvalid_function.
4348 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4350 * makefile.w32-in: Update dependencies.
4351 (LISP_H): Add inttypes.h and stdin.h.
4352 (PROCESS_H): Add unistd.h.
4354 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4356 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4357 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4359 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4361 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4363 * term.c (vfatal): Remove stray call to va_end.
4364 It's not needed and the C Standard doesn't allow it here anyway.
4366 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4367 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4369 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4372 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4374 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4376 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4378 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4380 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4382 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4383 * charset.c (Fdefine_charset_internal): Don't initialize
4384 charset.code_space[15]. The value was garbage, on hosts with
4385 32-bit int (Bug#8600).
4387 * lread.c (read_integer): Be more consistent with string-to-number.
4388 Use string_to_number to do the actual conversion; this avoids
4389 rounding errors and fixes some other screwups. Without this fix,
4390 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4391 (digit_to_number): Move earlier, for benefit of read_integer.
4392 Return -1 if the digit is out of range for the base, -2 if it is
4393 not a digit in any supported base. (Bug#8602)
4395 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4397 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4398 to match comment at start of function. This also removes a
4399 GCC warning about overflow in a 32+64-bit port.
4401 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4403 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4404 Reported by Stefan Monnier in
4405 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4406 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4407 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4409 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4410 (EMACS_UINTPTR): Likewise, with uintptr_t.
4412 * lisp.h: Prefer 64-bit EMACS_INT if available.
4413 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4414 on 32-bit hosts that have 64-bit int, so that they can access
4416 However, temporarily disable this change unless the temporary
4417 symbol WIDE_EMACS_INT is defined.
4419 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4421 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4422 This removes an assumption that EMACS_INT and long are the same
4423 width as pointers. The assumption is true for Emacs porting targets
4424 now, but we want to make other targets possible.
4425 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4426 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4427 In the rest of the code, change types of integers that hold casted
4428 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4429 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4430 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4431 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4432 No need to cast type when ORing.
4433 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4434 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4435 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4436 assume EMACS_INT is the same width as char *.
4437 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4438 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4439 Remove no-longer-needed casts.
4440 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4441 (xg_tool_bar_help_callback, xg_make_tool_item):
4442 Use EMACS_INTPTR to hold an integer
4443 that will be cast to void *; this can avoid a GCC warning
4444 if EMACS_INT is not the same width as void *.
4445 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4446 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4447 (current_message_1, set_message_1):
4448 Use a local to convert to proper width without a cast.
4449 * xmenu.c (dialog_selection_callback): Likewise.
4451 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4452 Also, don't assume VALBITS / RAND_BITS is less than 5,
4453 and don't rely on undefined behavior when shifting a 1 left into
4455 * lisp.h (get_random): Change signature to match.
4457 * lread.c (hash_string): Use size_t, not int, for hash computation.
4458 Normally we prefer signed values; but hashing is special, because
4459 it's better to use unsigned division on hash table sizes so that
4460 the remainder is nonnegative. Also, size_t is the natural width
4461 for hashing into memory. The previous code used 'int', which doesn't
4462 retain enough info to hash well into very large tables.
4463 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4465 * dbusbind.c: Don't possibly lose pointer info when converting.
4466 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4467 Use XPNTR rather than XHASH, so that the high-order bits of
4468 the pointer aren't lost when converting through void *.
4470 * eval.c (Fautoload): Don't double-shift a pointer.
4472 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4474 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4476 * gnutls.c (DEF_GNUTLS_FN):
4477 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4479 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4481 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4484 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4486 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4487 New version that can reserve upto 2GB of heap space.
4489 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4491 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4493 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4495 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4496 `gnutls_certificate_set_x509_key_file'.
4498 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4500 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4501 Update dependencies.
4503 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4505 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4506 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4507 Remove unused parameter `fildes'.
4508 * process.c (read_process_output, send_process): Don't pass it.
4510 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4512 Fix previous change: the library cache is defined in w32.c.
4513 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4514 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4516 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4518 Implement dynamic loading of GnuTLS on Windows.
4520 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4521 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4522 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4525 * gnutls.c (Qgnutls_dll): Define.
4526 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4527 (gnutls_*): Declare function pointers.
4528 (init_gnutls_functions): New function to initialize function pointers.
4529 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4530 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4531 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4532 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4533 (emacs_gnutls_write, emacs_gnutls_read)
4534 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4535 (Fgnutls_available_p): New function.
4536 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4537 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4538 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4540 * image.c: Include w32.h.
4541 (Vimage_type_cache): Delete.
4542 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4543 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4544 (w32_delayed_load): Move to w32.c.
4546 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4548 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4549 (w32_delayed_load): Move from image.c. When loading a library, record
4550 its filename in the :loaded-from property of the library id.
4551 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4552 Initialize and staticpro them.
4553 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4555 * process.c: Include lisp.h before w32.h, not after.
4556 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4557 instead of gnutls_record_check_pending.
4559 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4561 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4563 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4564 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4567 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4569 * xterm.c (x_set_frame_alpha): Do not set property on anything
4570 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4572 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4574 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4576 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4578 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4579 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4580 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4581 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4582 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4583 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4584 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4585 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4586 (Qgnutls_bootprop_callbacks_verify): Make static.
4588 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4590 * callproc.c: Indentation fixup.
4592 * sysdep.c (wait_for_termination_1): Make static.
4593 (wait_for_termination, interruptible_wait_for_termination):
4594 Move after wait_for_termination_1.
4596 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4598 * sysdep.c (interruptible_wait_for_termination): New function
4599 which is like wait_for_termination, but allows keyboard
4602 * callproc.c (Fcall_process): Add (:file "file") as an option for
4604 (Fcall_process_region): Ditto.
4606 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4608 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4609 rather than `XVECTOR (FOO)->size'.
4611 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4612 inttypes.h, as a gnulib replacement is used if it not available in
4615 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4617 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4618 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4619 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4621 * coding.c (coding_alloc_by_realloc): Error out if destination
4622 will grow beyond MOST_POSITIVE_FIXNUM.
4623 (decode_coding_emacs_mule): Abort if there isn't enough place in
4624 charbuf for the composition carryover bytes. Reserve an extra
4625 space for up to 2 characters produced in a loop.
4626 (decode_coding_iso_2022): Abort if there isn't enough place in
4627 charbuf for the composition carryover bytes.
4629 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4631 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4632 aborting when %lld or %lll format is passed.
4633 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4634 %llo or %llx format is passed. (Bug#8545)
4636 * window.c (window_scroll_line_based): Use a marker instead of
4637 simple variables to record original value of point. (Bug#7952)
4639 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4640 produced by %s or %c overflows available buffer space. (Bug#8545)
4642 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4644 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4645 (SIZE_MAX): Move defn after all includes, as they might #define it.
4647 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4649 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4651 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4653 * keyboard.c (Qdelayed_warnings_hook): Define.
4654 (command_loop_1): Run `delayed-warnings-hook'
4655 if Vdelayed_warnings_list is non-nil.
4656 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4657 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4659 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4661 * doprnt.c (doprnt): Don't return value smaller than the buffer
4662 size if the message was truncated. (Bug#8545).
4664 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4666 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4667 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4669 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4671 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4673 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4675 * makefile.w32-in: Update dependencies.
4677 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4679 Improve `doprnt' and its usage. (Bug#8545)
4680 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4681 `format_end'. Remove support for %l as a conversion specifier.
4682 Don't use xrealloc. Improve diagnostics when the %l size modifier
4683 is used. Update the commentary.
4685 * eval.c (verror): Simplify calculation of size_t.
4687 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4690 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4692 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4695 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4697 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4698 This makes this file independent of the recent pseudovector change.
4700 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4702 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4704 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4705 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4706 Remove unused local.
4707 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4709 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4710 GCC 4.6.0 optimizes based on type-based alias analysis.
4711 For example, if b is of type struct buffer * and v of type struct
4712 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4713 != &v->size, and therefore "v->size = 1; b->size = 2; return
4714 v->size;" must therefore return 1. This assumption is incorrect
4715 for Emacs, since it type-puns struct Lisp_Vector * with many other
4716 types. To fix this problem, this patch adds a new type struct
4717 vectorlike_header that documents the constraints on layout of vectors
4718 and pseudovectors, and helps optimizing compilers not get fooled
4719 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4720 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4721 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4723 (XSETPVECTYPE): Rewrite in terms of new macro.
4724 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4725 This is a bit clearer, and further avoids the possibility of
4726 undesirable aliasing.
4727 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4728 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4729 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4730 since Lisp_Subr is a special case (no "next" field).
4731 (ASIZE): Now uses header.size rather than size.
4732 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4733 to avoid the hassle of writing XVECTOR (foo)->header.size.
4734 (struct vectorlike_header): New type.
4735 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4736 object, to help avoid aliasing.
4737 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4738 (SUBRP): Likewise, since Lisp_Subr is a special case.
4739 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4740 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4741 (struct Lisp_Hash_Table): Combine first two members into a single
4742 struct vectorlike_header member. All uses of "size" and "next" members
4743 changed to be "header.size" and "header.next".
4744 * buffer.h (struct buffer): Likewise.
4745 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4746 * frame.h (struct frame): Likewise.
4747 * process.h (struct Lisp_Process): Likewise.
4748 * termhooks.h (struct terminal): Likewise.
4749 * window.c (struct save_window_data, struct saved_window): Likewise.
4750 * window.h (struct window): Likewise.
4751 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4752 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4753 * buffer.c (init_buffer_once): Likewise.
4754 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4756 * process.c (Fformat_network_address): Use local var for size,
4759 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4761 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4762 * data.c (atof): Remove decl; no longer used or needed.
4763 (digit_to_number): Move to lread.c.
4764 (Fstring_to_number): Use new string_to_number function, to be
4765 consistent with how the Lisp reader treats infinities and NaNs.
4766 Do not assume that floating-point numbers represent EMACS_INT
4767 without losing information; this is not true on most 64-bit hosts.
4768 Avoid double-rounding errors, by insisting on integers when
4769 parsing non-base-10 numbers, as the documentation specifies.
4770 * lisp.h (string_to_number): New decl, replacing ...
4771 (isfloat_string): Remove.
4772 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4773 (read1): Do not accept +. and -. as integers; this
4774 appears to have been a coding error. Similarly, do not accept
4775 strings like +-1e0 as floating point numbers. Do not report
4776 overflow for integer overflows unless the base is not 10 which
4777 means we have no simple and reliable way to continue.
4778 Break out the floating-point parsing into a new
4779 function string_to_number, so that Fstring_to_number parses
4780 floating point numbers consistently with the Lisp reader.
4781 (digit_to_number): Move here from data.c. Make it static inline.
4782 (E_CHAR, EXP_INT): Remove, replacing with ...
4783 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4784 (string_to_number): New function, replacing isfloat_string.
4785 This function checks for valid syntax and produces the resulting
4786 Lisp float number too. Rework it so that string-to-number
4787 no longer mishandles examples like "1.0e+". Use strtoumax,
4788 so that overflow for non-base-10 numbers is reported only when
4789 there's no portable and simple way to convert to floating point.
4791 * textprop.c (set_text_properties_1): Rewrite for clarity,
4792 and to avoid GCC warning about integer overflow.
4794 * intervals.h (struct interval): Use EMACS_INT for members
4795 where EMACS_UINT might cause problems. See
4796 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4797 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4798 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4800 (offset_intervals): Tell GCC not to worry about length overflow
4801 when negating a negative length.
4803 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4804 (overrun_check_free): Likewise.
4806 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4807 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4810 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4811 (gnutls_make_error): Rename local to avoid shadowing.
4812 (gnutls_emacs_global_deinit): ifdef out; not used.
4813 (Fgnutls_boot): Use const for pointer to readonly storage.
4814 Comment out unused local. Fix pointer signedness problems.
4816 * lread.c (openp): Don't stuff size_t into an 'int'.
4817 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4818 about possible signed overflow.
4820 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4821 (GDK_KEY_g): Don't define if already defined.
4822 (xg_prepare_tooltip): Avoid pointer signedness problem.
4823 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4825 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4826 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4828 * xfns.c (Fx_window_property): Simplify a bit,
4829 to make a bit faster and to avoid GCC 4.6.0 warning.
4830 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4832 * fns.c (internal_equal): Don't assume size_t fits in int.
4834 * alloc.c (compact_small_strings): Tighten assertion a little.
4836 Replace pEd with more-general pI, and fix some printf arg casts.
4837 * lisp.h (pI): New macro, generalizing old pEd macro to other
4838 conversion specifiers. For example, use "...%"pI"d..." rather
4839 than "...%"pEd"...".
4840 (pEd): Remove. All uses replaced with similar uses of pI.
4841 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4842 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4843 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4844 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4845 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4846 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4847 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4849 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4850 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4851 * print.c (safe_debug_print, print_object): Likewise.
4852 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4854 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4855 avoiding the 0 flag, which is not portable.
4856 * process.c (Fmake_network_process): Use pI to avoid cast.
4857 * region-cache.c (pp_cache): Likewise.
4858 * xdisp.c (decode_mode_spec): Likewise.
4859 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4860 behavior on 64-bit hosts with printf arg.
4861 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4862 (x_stop_queuing_selection_requests): Likewise.
4863 (x_get_window_property): Don't truncate byte count to an 'int'
4866 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4867 here, since it parses constructs like leading '-' and spaces,
4868 which are not wanted; and it overflows with large numbers.
4869 Instead, simply match F[0-9]+, which is what is wanted anyway.
4871 * alloc.c: Remove unportable assumptions about struct layout.
4872 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4873 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4874 (allocate_vectorlike, make_pure_vector): Use the new macros,
4875 plus offsetof, to remove unportable assumptions about struct layout.
4876 These assumptions hold on all porting targets that I know of, but
4877 they are not guaranteed, they're easy to remove, and removing them
4878 makes further changes easier.
4880 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4881 This doesn't fix a bug but makes the code clearer.
4882 (string_overrun_cookie): Now const. Use initializers that
4883 don't formally overflow signed char, to avoid warnings.
4884 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4885 can cause Emacs to crash when string overrun checking is enabled.
4886 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4887 multiple of sizeof (EMACS_INT); it need not be, if
4888 alignof(EMACS_INT) < sizeof (EMACS_INT).
4889 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4891 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4893 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4895 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4897 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4898 supposed to be handshaking. (Bug#8556)
4899 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4901 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4903 * lisp.h (Qdebug): List symbol.
4904 * eval.c (Qdebug): Restore global linkage.
4905 * keyboard.c (debug-on-event): New variable.
4906 (handle_user_signal): Break into debugger when debug-on-event
4907 matches the current signal symbol.
4909 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4911 * alloc.c (check_sblock, check_string_bytes)
4912 (check_string_free_list): Convert to standard C.
4914 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4916 * w32.c (emacs_gnutls_push): Fix typo.
4918 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4920 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4921 "cast to pointer from integer of different size".
4923 Improve doprnt and its use in verror. (Bug#8545)
4924 * doprnt.c (doprnt): Document the set of format control sequences
4925 supported by the function. Use SAFE_ALLOCA instead of always
4928 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4929 is one byte too soon. Don't use xrealloc; instead xfree and
4932 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4934 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4937 * gnutls.c: Renamed global_initialized to
4938 gnutls_global_initialized. Added internals for the
4939 :verify-hostname-error, :verify-error, and :verify-flags
4940 parameters of `gnutls-boot' and documented those parameters in the
4941 docstring. Start callback support.
4942 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4943 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4944 on error. Return error code.
4945 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4946 (emacs_gnutls_read): Likewise.
4947 (Fgnutls_boot): Return handshake error code.
4948 (emacs_gnutls_handle_error): New function.
4949 (wsaerror_to_errno): Likewise.
4951 * w32.h (emacs_gnutls_pull): Add prototype.
4952 (emacs_gnutls_push): Likewise.
4954 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4955 (emacs_gnutls_push): Likewise.
4957 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4959 * process.c (wait_reading_process_output): Check if GnuTLS
4960 buffered some data internally if no FDs are set for TLS
4963 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4964 (LIBS): Link to USER_LIBS.
4965 ($(BLD)/gnutls.$(0)): New target.
4967 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4969 * xdisp.c (handle_single_display_spec): Rename the
4970 display_replaced_before_p argument into display_replaced_p, to
4971 make it consistent with the commentary. Fix typos in the
4974 * textprop.c (syms_of_textprop): Remove dead code.
4975 (copy_text_properties): Delete obsolete commentary about an
4976 interface that was deleted long ago. Fix typos in the description
4979 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4980 to changes in oldXMenu/XMenu.h from 2011-04-16.
4981 <menu_help_message, prev_menu_help_message>: Constify.
4982 (IT_menu_make_room): menu->help_text is now `const char **';
4985 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4986 to changes in oldXMenu/XMenu.h from 2011-04-16.
4987 (struct XMenu): Declare `help_text' `const char **'.
4989 * xfaces.c <Qunspecified>: Make extern again.
4991 * syntax.c: Include sys/types.h before including regex.h, as
4994 * doc.c (get_doc_string): Improve the format passed to `error'.
4996 * doprnt.c (doprnt): Improve commentary.
4998 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5000 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5003 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5004 changes in globals.h immediately force recompilation.
5005 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5006 $(CURDIR)/s/ms-w32.h.
5007 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5009 * character.c (Fchar_direction): Function deleted.
5010 (syms_of_character): Don't defsubr it.
5011 <char-direction-table>: Deleted.
5013 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5015 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5016 * doprnt.c: Include limits.h.
5017 (SIZE_MAX): New macro.
5018 (doprnt): Return a size_t value. 2nd arg is now size_t.
5019 Many local variables are now size_t instead of int or unsigned.
5020 Improve overflow protection. Support `l' modifier for integer
5021 conversions. Support %l conversion. Don't assume an EMACS_INT
5022 argument for integer conversions and for %c.
5024 * lisp.h (doprnt): Restore prototype.
5026 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5029 * Makefile.in (base_obj): Add back doprnt.o.
5031 * deps.mk (doprnt.o): Add back prerequisites.
5032 (callint.o): Depend on character.h.
5034 * eval.c (internal_lisp_condition_case): Include the handler
5035 representation in the error message.
5036 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5037 when breaking from the loop.
5039 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5041 * callint.c (Fcall_interactively): When displaying error message
5042 about invalid control letter, pass the character's codepoint, not
5043 a pointer to its multibyte form. Improve display of the character
5044 in octal and display also its hex code.
5046 * character.c (char_string): Use %x to display the (unsigned)
5047 codepoint of an invalid character, to avoid displaying a bogus
5050 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5051 `error', not SYMBOL_NAME itself.
5053 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5054 character arguments to `error'.
5056 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5057 to `error' in error message about FINAL_CHAR argument. Make sure
5058 FINAL_CHAR is a character, and use %c when it is passed as
5059 argument to `error'.
5061 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5063 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5065 * w32.c: Include <time.h>.
5066 (sys_localtime): New function.
5068 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5070 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5072 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5074 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5076 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5079 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5081 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5082 gl_state.e_property when gl_state.object is Qt.
5084 * insdel.c (make_gap_larger): Remove limitation of buffer size
5087 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5089 * xdisp.c (lookup_glyphless_char_display)
5090 (produce_glyphless_glyph): Handle cons cell entry in
5091 glyphless-char-display.
5092 (Vglyphless_char_display): Document it.
5094 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5095 glyphless-char-display.
5097 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5099 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5101 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5103 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5104 definition for no-X builds.
5106 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5108 Static checks with GCC 4.6.0 and non-default toolkits.
5110 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5112 * process.c (keyboard_bit_set): Define only if SIGIO.
5113 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5114 (send_process): Repair possible setjmp clobbering.
5116 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5118 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5120 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5122 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5123 Define only if needed.
5125 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5126 by pacifying GCC about it. Maybe it's time to retire it?
5127 * xfaces.c (USG, __TIMEVAL__): Likewise.
5129 * dispextern.h (struct redisplay_interface): Rename param
5131 * termhooks.h (struct terminal): Likewise.
5132 * xterm.c (xembed_send_message): Likewise.
5134 * insdel.c (make_gap_smaller): Define only if
5135 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5137 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5140 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5141 so that we aren't warned about unused symbols.
5143 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5145 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5147 * xfns.c (x_real_positions): Mark locals as initialized.
5149 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5151 * xterm.c: Fix problems found by static analysis with other toolkits.
5152 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5153 (x_dispatch_event): Declare static if USE_GTK, and
5154 define if USE_GTK || USE_X_TOOLKIT.
5155 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5156 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5157 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5158 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5160 * xmenu.c (menu_help_callback): Pointer type fixes.
5161 Use const pointers when pointing at readonly data. Avoid pointer
5163 (FALSE): Remove unused macro.
5164 (update_frame_menubar): Remove unused decl.
5166 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5168 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5169 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5170 (single_menu_item): Rename local to avoid shadowing.
5172 * keyboard.c (make_lispy_event): Remove unused local var.
5174 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5175 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5177 * bitmaps: Change bitmaps from unsigned char back to the X11
5178 compatible char. Avoid the old compiler warnings about
5179 out-of-range initializers by using, for example, '\xab' rather
5182 * xgselect.c (xgselect_initialize): Check vs interface
5183 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5185 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5187 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5188 to read-only memory.
5190 * fns.c (vector): Remove; this old hack is no longer needed.
5192 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5194 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5196 * xrdb.c (x_load_resources): Omit unused local.
5198 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5199 (x_window): Rename locals to avoid shadowing.
5200 (USG): Use the kludged USG macro, to pacify gcc.
5202 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5203 (x_term_init): Remove local to avoid shadowing.
5205 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5207 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5208 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5210 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5212 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5214 Fix regex.c, syntax.c and friends for buffers > 2GB.
5215 * syntax.h (struct gl_state_s): Declare character position members
5218 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5220 * textprop.c (verify_interval_modification, interval_of):
5221 Declare arguments EMACS_INT.
5223 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5226 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5228 * indent.c (Fvertical_motion): Local variable it_start is now
5231 * regex.c (re_match, re_match_2, re_match_2_internal)
5232 (bcmp_translate, regcomp, regexec, print_double_string)
5233 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5234 (re_compile_pattern, re_exec): Declare arguments and local
5235 variables `size_t' and `ssize_t' and return values `regoff_t', as
5237 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5238 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5239 <compile_stack_type>: `size' and `avail' are now `size_t'.
5241 * regex.h <regoff_t>: Use ssize_t, not int.
5242 (re_search, re_search_2, re_match, re_match_2): Arguments that
5243 specify buffer/string position and length are now ssize_t and
5244 size_t. Return type is regoff_t.
5246 2011-04-16 Ben Key <bkey76@gmail.com>
5248 * nsfont.m: Fixed bugs in ns_get_family and
5249 ns_descriptor_to_entity that were caused by using free to
5250 deallocate memory blocks that were allocated by xmalloc (via
5251 xstrdup). This caused Emacs to crash when compiled with
5252 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5253 --enable-checking=xmallocoverrun). xfree is now used to
5254 deallocate these memory blocks.
5256 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5258 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5260 emacs_write: Accept and return EMACS_INT for sizes.
5261 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5263 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5264 Accept and return EMACS_INT.
5265 (emacs_gnutls_write): Return the number of bytes written on
5267 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5268 (emacs_read, emacs_write): Remove check for negative size, as the
5269 Emacs source code has been audited now.
5270 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5271 (emacs_read, emacs_write): Use it.
5272 * process.c (send_process): Adjust to the new signatures of
5273 emacs_write and emacs_gnutls_write. Do not attempt to store
5274 a byte offset into an 'int'; it might overflow.
5275 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5277 * sound.c: Don't assume sizes fit in 'int'.
5278 (struct sound_device.period_size, alsa_period_size):
5279 Return EMACS_INT, not int.
5280 (struct sound_device.write, vox_write, alsa_write):
5281 Accept EMACS_INT, not int.
5282 (wav_play, au_play): Use EMACS_INT to store sizes and to
5283 record read return values.
5285 2011-04-15 Ben Key <bkey76@gmail.com>
5287 * keyboard.c (Qundefined): Don't declare static since it is used
5289 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5290 static since they are used in nsfont.m.
5292 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5294 * process.c (Qprocessp): Don't declare static.
5295 * lisp.h (Qprocessp): Declare again.
5297 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5299 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5301 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5303 Improve C-level modularity by making more things 'static'.
5305 Don't publish debugger-only interfaces to other modules.
5306 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5307 (verify_bytepos, count_markers): Move decls to the only modules
5309 * region-cache.h (pp_cache): Likewise.
5310 * window.h (check_all_windows): Likewise.
5311 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5313 * sysdep.c (croak): Now static, if
5314 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5315 * syssignal.h (croak): Declare only if not static.
5317 * alloc.c (refill_memory_reserve): Now static if
5318 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5319 * lisp.h (refill_memory_reserve): Declare only if not static.
5321 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5322 Define only if USE_LUCID.
5324 * xrdb.c (x_customization_string, x_rm_string): Now static.
5326 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5327 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5329 * xdisp.c (draw_row_with_mouse_face): Now static.
5330 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5332 * window.h (check_all_windows): Mark externally visible.
5334 * window.c (window_deletion_count): Now static.
5336 * undo.c: Make symbols static if they're not exported.
5337 (last_undo_buffer, last_boundary_position, pending_boundary):
5340 * textprop.c (interval_insert_behind_hooks): Now static.
5341 (interval_insert_in_front_hooks): Likewise.
5343 * term.c: Make symbols static if they're not exported.
5344 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5345 (max_frame_lines, tty_set_terminal_modes):
5346 (tty_reset_terminal_modes, tty_turn_off_highlight):
5347 (get_tty_terminal): Now static.
5348 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5349 * termhooks.h (term_mouse_moveto): Do not declare if
5351 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5352 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5354 * sysdep.c: Make symbols static if they're not exported.
5355 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5357 (sigprocmask_set, full_mask): Remove; unused.
5358 (wait_debugging): Mark as visible.
5359 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5360 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5362 * syntax.c (syntax_temp): Define only if !__GNUC__.
5364 * sound.c (current_sound_device, current_sound): Now static.
5366 * search.c (searchbufs, searchbuf_head): Now static.
5368 * scroll.c (scroll_cost): Remove; unused.
5369 * dispextern.h (scroll_cost): Remove decl.
5371 * region-cache.h (pp_cache): Mark as externally visible.
5373 * process.c: Make symbols static if they're not exported.
5374 (process_tick, update_tick, create_process, chan_process):
5375 (Vprocess_alist, proc_buffered_char, datagram_access):
5376 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5377 (deactivate_process): Mark defn as static, as well as decl.
5378 * lisp.h (create_process): Remove decl.
5379 * process.h (chan_process, Vprocess_alist): Remove decls.
5381 * print.c: Make symbols static if they're not exported.
5382 (print_depth, new_backquote_output, being_printed, print_buffer):
5383 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5384 (print_interval, print_number_index, initial_stderr_stream):
5386 * lisp.h (Fprinc): Remove decl.
5387 (debug_output_compilation_hack): Mark as externally visible.
5389 * sysdep.c (croak): Move decl from here to syssignal.h.
5390 * syssignal.h (croak): Put it here, so the API can be checked when
5391 'croak' is called from dissociate_if_controlling_tty.
5393 * minibuf.c: Make symbols static if they're not exported.
5394 (minibuf_save_list, choose_minibuf_frame): Now static.
5395 * lisp.h (choose_minibuf_frame): Remove decl.
5397 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5399 * lread.c: Make symbols static if they're not exported.
5400 (read_objects, initial_obarray, oblookup_last_bucket_number):
5402 (make_symbol): Remove; unused.
5403 * lisp.h (initial_obarray, make_symbol): Remove decls.
5405 * keyboard.c: Make symbols static if they're not exported.
5406 (single_kboard, recent_keys_index, total_keys, recent_keys):
5407 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5408 (this_single_command_key_start, echoing, last_auto_save):
5409 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5410 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5411 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5412 (Vlispy_mouse_stem, double_click_count):
5414 (force_auto_save_soon): Define only if SIGDANGER.
5415 (ignore_mouse_drag_p): Now static if
5416 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5417 (print_help): Remove; unused.
5418 (stop_character, last_timer_event): Mark as externally visible.
5419 * keyboard.h (ignore_mouse_drag_p): Declare only if
5420 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5421 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5422 * lisp.h (echoing): Remove decl.
5423 (force_auto_save_soon): Declare only if SIGDANGER.
5424 * xdisp.c (redisplay_window): Simplify code, to make it more
5425 obvious that ignore_mouse_drag_p is not accessed if !defined
5426 USE_GTK && !defined HAVE_NS.
5428 * intervals.c: Make symbols static if they're not exported.
5429 (merge_properties_sticky, merge_interval_right, delete_interval):
5431 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5433 * insdel.c: Make symbols static if they're not exported.
5434 However, leave prepare_to_modify_buffer alone. It's never
5435 called from outside this function, but that appears to be a bug.
5436 (combine_after_change_list, combine_after_change_buffer):
5437 (adjust_after_replace, signal_before_change): Now static.
5438 (adjust_after_replace_noundo): Remove; unused.
5439 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5440 (signal_before_change): Remove decls.
5442 * indent.c (val_compute_motion, val_vmotion): Now static.
5444 * image.c: Make symbols static if they're not exported.
5445 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5447 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5448 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5450 * fringe.c (standard_bitmaps): Now static.
5451 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5453 * frame.c: Make symbols static if they're not exported.
5454 (x_report_frame_params, make_terminal_frame): Now static.
5455 (get_frame_param): Now static, unless HAVE_NS.
5456 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5457 (x_get_resource_string): Remove; not used.
5458 * frame.h (make_terminal_frame, x_report_frame_params):
5459 (x_get_resource_string); Remove decls.
5460 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5461 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5463 * font.c, fontset.c: Make symbols static if they're not exported.
5464 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5465 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5466 * font.c (font_close_object): Now static.
5467 * font.h (font_close_object): Remove.
5468 * fontset.c (FONTSET_OBJLIST): Remove.
5469 (free_realized_fontset) #if-0 the body, which does nothing.
5470 (face_suitable_for_char_p): #if-0, as it's never called.
5471 * fontset.h (face_suitable_for_char_p): Remove decl.
5472 * xfaces.c (face_at_string_position):
5473 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5474 since 0 is always ASCII.
5476 * fns.c (weak_hash_tables): Now static.
5478 * fileio.c: Make symbols static if they're not exported.
5479 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5480 (Vwrite_region_annotation_buffers): Now static.
5482 * eval.c: Make symbols static if they're not exported.
5483 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5484 * lisp.h (backtrace_list): Remove decl.
5486 * emacs.c: Make symbols static if they're not exported.
5487 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5488 (fatal_error_code, fatal_error_signal_hook, standard_args):
5490 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5491 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5492 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5493 * lisp.h (fatal_error_signal_hook): Remove decl.
5494 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5496 * editfns.c: Move a (normally-unused) function to its only use.
5497 * editfns.c, lisp.h (get_operating_system_release): Remove.
5498 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5499 worth the hassle of breaking this out.
5501 * xterm.c: Make symbols static if they're not exported.
5502 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5503 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5504 (x_destroy_window, x_delete_display):
5506 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5507 (x_mouse_leave): Remove; unused.
5508 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5509 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5510 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5512 (x_mouse_leave): Declare only if WINDOWSNT.
5513 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5514 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5517 * ftxfont.c: Make symbols static if they're not exported.
5518 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5520 * font.h (ftxfont_driver): Likewise.
5522 * xfns.c: Make symbols static if they're not exported.
5523 (x_last_font_name, x_display_info_for_name):
5524 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5525 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5526 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5527 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5528 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5529 (last_show_tip_args): Now static.
5530 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5531 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5532 (x_screen_planes): Remove; unused.
5533 * dispextern.h (x_screen_planes): Remove decl.
5535 * dispnew.c: Make symbols static if they're not exported.
5536 * dispextern.h (redraw_garbaged_frames, scrolling):
5537 (increment_row_positions): Remove.
5538 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5539 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5541 (redraw_garbaged_frames): Remove; unused.
5543 * xfaces.c: Make symbols static if they're not exported.
5544 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5546 * xterm.h (defined_color): Remove decls.
5547 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5548 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5549 (menu_face_changed_default, defined_color, free_realized_face):
5550 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5551 (ascii_face_of_lisp_face): Remove; unused.
5553 * xdisp.c: Make symbols static if they're not exported.
5554 * dispextern.h (scratch_glyph_row, window_box_edges):
5555 (glyph_to_pixel_coords, set_cursor_from_row):
5556 (get_next_display_element, set_iterator_to_next):
5557 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5558 (show_mouse_face): Remove decls
5559 * frame.h (message_buf_print): Likewise.
5560 * lisp.h (pop_message, set_message, check_point_in_composition):
5562 * xterm.h (set_vertical_scroll_bar): Likewise.
5563 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5564 (message_buf_print, scratch_glyph_row, displayed_buffer):
5565 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5566 (get_next_display_element, show_mouse_face, window_box_edges):
5567 (frame_to_window_pixel_xy, check_point_in_composition):
5568 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5569 (glyph_to_pixel_coords): Remove; unused.
5571 * dired.c (file_name_completion): Now static.
5573 * dbusbind.c (xd_in_read_queued_messages): Now static.
5575 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5576 * data.c (circular_list_error): Remove.
5578 * commands.h (last_point_position, last_point_position_buffer):
5579 (last_point_position_window): Remove decls.
5580 * keyboard.c: Make these variables static.
5582 * coding.h (coding, code_convert_region, encode_coding_gap):
5584 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5585 (iso_code_class, detect_coding, code_convert_region): Now static.
5586 (encode_coding_gap): Remove; unused.
5588 * chartab.c (chartab_chars, chartab_bits): Now static.
5590 * charset.h (charset_iso_8859_1): Remove decl.
5591 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5594 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5595 * ccl.c (Vccl_program_table): Now static.
5596 (check_ccl_update): Remove; unused.
5598 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5599 * category.h: ... from here.
5600 * category.c (check_category_table, set_category_set): Now static.
5602 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5603 * lisp.h: Remove these decls.
5605 * buffer.c (buffer_count): Remove unused var.
5607 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5608 so that it's not optimized away.
5609 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5610 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5611 exported only to the debugger.
5613 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5614 * atimer.h (run_all_atimers): Remove; not exported.
5616 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5617 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5618 was inaccessible from Lisp.
5619 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5620 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5622 alloc.c: Import and export fewer symbols, and remove unused items.
5623 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5625 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5626 it's not optimized away by whole-program optimization.
5627 (message_enable_multibyte, free_misc): Remove.
5628 (catchlist, handlerlist, mark_backtrace):
5629 Declare only if BYTE_MARK_STACK.
5630 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5631 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5632 (message_enable_multibyte): Remove decl.
5633 (free_misc, interval_free_list, float_block, float_block_index):
5634 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5635 (cons_free_list, last_marked_index):
5637 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5638 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5639 (mark_backtrace): Define only if BYTE_MARK_STACK.
5640 * xdisp.c (message_enable_multibyte): Now static.
5642 Declare Lisp_Object Q* variables to be 'static' if not exported.
5643 This makes it easier for human readers (and static analyzers)
5644 to see whether these variables are used from other modules.
5645 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5646 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5647 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5648 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5649 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5650 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5651 * xmenu.c, xselect.c:
5652 Declare Q* vars static if they are not used in other modules.
5653 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5654 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5655 Remove decls of unexported vars.
5656 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5658 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5660 Make Emacs functions such as Fatom 'static' by default.
5661 This makes it easier for human readers (and static analyzers)
5662 to see whether these functions can be called from other modules.
5663 DEFUN now defines a static function. To make the function external
5664 so that it can be used in other C modules, use the new macro DEFUE.
5665 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5666 (Finit_image_library):
5667 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5668 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5669 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5670 Remove decls, since these functions are now static.
5671 (Funintern, Fget_internal_run_time): New decls, since these functions
5672 were already external.
5674 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5675 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5676 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5677 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5678 * keyboard.c, keymap.c, lread.c:
5679 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5680 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5681 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5682 Mark functions with DEFUE instead of DEFUN,
5683 if they are used in other modules.
5684 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5685 decls for now-static functions.
5686 * buffer.h (Fdelete_overlay): Remove decl.
5687 * callproc.c (Fgetenv_internal): Mark as internal.
5688 * composite.c (Fremove_list_of_text_properties): Remove decl.
5689 (Fcomposition_get_gstring): New forward static decl.
5690 * composite.h (Fcomposite_get_gstring): Remove decl.
5691 * dired.c (Ffile_attributes): New forward static decl.
5692 * doc.c (Fdocumntation_property): New forward static decl.
5693 * eval.c (Ffetch_bytecode): New forward static decl.
5694 (Funintern): Remove extern decl; now in .h file where it belongs.
5695 * fileio.c (Fmake_symbolic_link): New forward static decl.
5696 * image.c (Finit_image_library): New forward static decl.
5697 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5698 * intervals.h (Fprevious_property_change):
5699 (Fremove_list_of_text_properties): Remove decls.
5700 * keyboard.c (Fthis_command_keys): Remove decl.
5701 (Fcommand_execute): New forward static decl.
5702 * keymap.c (Flookup_key): New forward static decl.
5703 (Fcopy_keymap): Now static.
5704 * keymap.h (Flookup_key): Remove decl.
5705 * process.c (Fget_process): New forward static decl.
5706 (Fprocess_datagram_address): Mark as internal.
5707 * syntax.c (Fsyntax_table_p): New forward static decl.
5708 (skip_chars): Remove duplicate decl.
5709 * textprop.c (Fprevious_property_change): New forward static decl.
5710 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5712 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5713 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5715 * editfns.c (Fformat): Remove unreachable code.
5717 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5719 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5722 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5724 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5725 when at ZV. (Bug#8487)
5727 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5729 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5731 * keyboard.c (parse_tool_bar_item): Likewise.
5732 * sound.c (sound_cleanup, alsa_close): Likewise.
5733 * termcap.c (tgetent): Likewise.
5734 * xfns.c (x_default_font_parameter): Likewise.
5735 * xsettings.c (read_and_apply_settings): Likewise.
5737 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5738 (overrun_check_free): Protoize.
5740 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5742 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5743 since callers should never pass a negative size.
5744 Change the signature to match that of plain 'read' and 'write'; see
5745 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5746 * lisp.h: Update prototypes of emacs_write and emacs_read.
5748 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5750 * xdisp.c (redisplay_window): Don't try to determine the character
5751 position of the scroll margin if the window start point w->startp
5752 is outside the buffer's accessible region. (Bug#8468)
5754 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5756 Fix write-region and its subroutines for buffers > 2GB.
5757 * fileio.c (a_write, e_write): Modify declaration of arguments and
5758 local variables to support buffers larger than 2GB.
5759 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5761 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5762 argument, local variables, and return value.
5764 * lisp.h: Update prototypes of emacs_write and emacs_read.
5766 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5768 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5770 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5772 Fix more problems found by GCC 4.6.0's static checks.
5774 * xdisp.c (vmessage): Use a better test for character truncation.
5776 * charset.c (load_charset_map): <, not <=, for optimization,
5777 and to avoid potential problems with integer overflow.
5778 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5779 * casetab.c (set_identity, shuffle): Likewise.
5780 * editfns.c (Fformat): Likewise.
5781 * syntax.c (skip_chars): Likewise.
5783 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5784 This also lets GCC 4.6.0 generate slightly better loop code.
5786 * callint.c (Fcall_interactively): <, not <=, for optimization.
5787 (Fcall_interactively): Count the number of arguments produced,
5788 not the number of arguments given. This is simpler and lets GCC
5789 4.6.0 generate slightly better code.
5791 * ftfont.c: Distingish more carefully between FcChar8 and char.
5792 The previous code passed unsigned char * to a functions like
5793 strlen and xstrcasecmp that expect char *, which does not
5794 conform to the C standard.
5795 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5796 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5797 char * when the C standard requires it.
5799 * keyboard.c (read_char): Remove unused var.
5801 * eval.c: Port to Windows vsnprintf (Bug#8435).
5803 (SIZE_MAX): Define if the headers do not.
5804 (verror): Do not give up if vsnprintf returns a negative count.
5805 Instead, grow the buffer. This ports to Windows vsnprintf, which
5806 does not conform to C99. Problem reported by Eli Zaretskii.
5807 Also, simplify the allocation scheme, by avoiding the need for
5808 calling realloc, and removing the ALLOCATED variable.
5810 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5812 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5813 But keep the doprint source code for now, as we might revamp it
5814 and use it again (Bug#8435).
5815 * lisp.h (doprnt): Remove.
5816 * Makefile.in (base_obj): Remove doprnt.o.
5817 * deps.mk (doprnt.o): Remove.
5819 error: Print 32- and 64-bit integers portably (Bug#8435).
5820 Without this change, on typical 64-bit hosts error ("...%d...", N)
5821 was used to print both 32- and 64-bit integers N, which relied on
5823 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5825 * lisp.h (error, verror): Mark as printf-like functions.
5826 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5827 Report overflow in size calculations when allocating printf buffer.
5828 Do not truncate output string at its first null byte.
5829 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5830 Truncate the output at a character boundary, since vsnprintf does not
5832 * charset.c (check_iso_charset_parameter): Convert internal
5833 character to string before calling 'error', since %c now has the
5835 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5836 overflow when computing char to be passed to 'error'. Do not
5837 pass Lisp_Object to 'error'; pass the integer instead.
5838 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5839 formatted with plain %d.
5841 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5843 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5845 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5847 * xterm.c (x_catch_errors): Remove duplicate declaration.
5849 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5851 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5853 2011-04-10 Jim Meyering <meyering@redhat.com>
5855 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5856 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5857 return ssize_t not "int", and use size_t as the buffer length.
5858 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5859 * gnutls.h: Update declarations.
5860 * process.c (read_process_output): Use ssize_t, to match.
5861 (send_process): Likewise.
5863 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5865 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5867 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5869 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5870 Use unsigned char, to match FcChar8 type definition.
5872 * xterm.c (handle_one_xevent):
5873 * xmenu.c (create_and_show_popup_menu):
5874 * xselect.c (x_decline_selection_request)
5875 (x_reply_selection_request): Avoid type-punned deref of X events.
5877 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5879 Fix some uses of `int' instead of EMACS_INT.
5880 * search.c (string_match_1, fast_string_match)
5881 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5882 (scan_buffer, find_next_newline_no_quit)
5883 (find_before_next_newline, search_command, Freplace_match)
5884 (Fmatch_data): Make some `int' variables be EMACS_INT.
5886 * xdisp.c (display_count_lines): 3rd argument and return value now
5887 EMACS_INT. All callers changed.
5888 (pint2hrstr): Last argument is now EMACS_INT.
5890 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5891 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5892 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5893 (decode_coding_utf_16, decode_coding_emacs_mule)
5894 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5895 (decode_coding_ccl, decode_coding_charset)
5896 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5897 (decode_coding_iso_2022, decode_coding_emacs_mule)
5898 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5899 <char_offset, last_offset>: Declare EMACS_INT.
5900 (encode_coding_utf_8, encode_coding_utf_16)
5901 (encode_coding_emacs_mule, encode_invocation_designation)
5902 (encode_designation_at_bol, encode_coding_iso_2022)
5903 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5904 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5906 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5907 (encode_invocation_designation): Last argument P_NCHARS is now
5909 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5910 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5912 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5915 * ccl.c (Fccl_execute_on_string): Declare some variables
5918 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5920 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5922 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5924 * process.c (Fformat_network_address): Doc fix.
5926 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5928 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5930 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5932 * keyboard.c (read_char): Call Lisp function help-form-show,
5933 instead of using internal_with_output_to_temp_buffer.
5934 (Qhelp_form_show): New var.
5935 (syms_of_keyboard): Use DEFSYM macro.
5937 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5939 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5941 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5943 * process.c (Flist_processes): Remove to Lisp.
5944 (list_processes_1): Delete.
5946 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5948 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5950 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5952 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5954 Fix more problems found by GCC 4.6.0's static checks.
5956 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5958 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5960 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5962 * xdisp.c (vmessage): Mark as a printf-like function.
5964 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5966 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5968 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5969 printf-like functions.
5970 (tiff_load): Add casts to remove these marks before passing them
5971 to system-supplied API.
5973 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5975 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5976 This avoids several warnings with gcc -Wstrict-overflow.
5977 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5978 directly, rather than having caller test rule sign. This avoids
5979 some unnecessary tests.
5980 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5981 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5982 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5984 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5985 (xfont_open): Avoid unnecessary tests.
5987 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5989 * composite.h, composite.c (composition_gstring_put_cache):
5990 Use EMACS_INT, not int, for length.
5992 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5993 breaking out part of COMPOSITION_DECODE_RULE.
5994 (COMPOSITION_DECODE_RULE): Use it.
5995 * composite.c (get_composition_id): Remove unused local vars,
5996 by using the new macro.
5998 * textprop.c (set_text_properties_1): Change while to do-while,
5999 since the condition is always true at first.
6001 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6002 (interval_deletion_adjustment): Return unsigned value.
6005 * process.c (list_processes_1, create_pty, read_process_output):
6006 (exec_sentinel): Remove vars that were set but not used.
6007 (create_pty): Remove unnecessary "volatile"s.
6008 (Fnetwork_interface_info): Avoid possibility of int overflow.
6009 (read_process_output): Do adaptive read buffering even if carryover.
6010 (read_process_output): Simplify nbytes computation if buffered.
6012 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6014 * syntax.c (scan_words): Remove var that was set but not used.
6015 (update_syntax_table): Use unsigned instead of int.
6017 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6018 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6019 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6021 * print.c (print_error_message): Avoid int overflow.
6023 * font.c (font_list_entities): Redo for clarity,
6024 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6026 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6027 (font_score): Avoid potential overflow in diff calculation.
6029 * fns.c (substring_both): Remove var that is set but not used.
6030 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6032 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6034 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6035 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6036 can always succeed if overflow has undefined behavior.
6038 * search.c (boyer_moore, wordify): Remove vars set but not used.
6039 (wordify): Omit three unnecessary tests.
6041 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6042 All callers changed. This avoids the need for an unused var.
6044 * casefiddle.c (casify_region): Remove var that is set but not used.
6046 * dired.c (file_name_completion): Remove var that is set but not used.
6048 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6050 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6051 (Finsert_file_contents): Remove unnecessary code checking fd.
6053 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6054 Check for integer overflow on size calculations.
6056 * buffer.c (Fprevious_overlay_change): Remove var that is set
6059 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6060 Remove vars that are set but not used.
6061 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6062 (timer_check_2): Mark vars as initialized.
6064 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6066 * image.c (lookup_image): Remove var that is set but not used.
6067 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6069 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6070 that are set but not used.
6072 * xfns.c (make_invisible_cursor): Don't return garbage
6073 if XCreateBitmapFromData fails (Bug#8410).
6075 * xselect.c (x_get_local_selection, x_handle_property_notify):
6076 Remove vars that are set but not used.
6078 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6079 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6081 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6082 Remove var that is set but not used.
6083 (scroll_bar_windows_size): Now size_t, not int.
6084 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6087 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6088 (map_tty_color) [!defined MSDOS]: Likewise.
6090 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6092 * coding.c: Remove vars that are set but not used.
6093 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6094 All callers changed.
6095 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6096 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6097 (decode_coding_charset): Remove vars that are set but not used.
6099 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6100 that is set but not used.
6102 * print.c (print_object): Remove var that is set but not used.
6104 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6105 The gnulib version avoids calling malloc in the usual case,
6106 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6107 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6108 * filelock.c (current_lock_owner): Likewise.
6109 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6110 * sysdep.c: Include allocator.h, careadlinkat.h.
6111 (emacs_no_realloc_allocator): New static constant.
6112 (emacs_readlink): New function.
6113 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6114 ../lib/careadlinkat.h.
6116 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6118 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6119 first non-nil return value).
6121 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6123 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6124 if not defined (Bug#8403).
6126 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6128 * xdisp.c (display_count_lines): Remove parameter `start',
6129 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6130 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6131 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6132 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6133 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6134 and thereabouts. All callers changed.
6135 (get_per_char_metric): Remove parameter `f', unused since
6136 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6138 2011-04-02 Jim Meyering <meyering@redhat.com>
6140 do not dereference NULL upon failed strdup
6141 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6142 (ns_get_family): Likewise.
6144 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6146 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6148 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6150 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6153 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6155 Add lexical binding.
6157 * window.c (Ftemp_output_buffer_show): New fun.
6158 (Fsave_window_excursion):
6159 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6161 * lread.c (lisp_file_lexically_bound_p): New function.
6162 (Fload): Bind Qlexical_binding.
6163 (readevalloop): Remove `evalfun' arg.
6164 Bind Qinternal_interpreter_environment.
6165 (Feval_buffer): Bind Qlexical_binding.
6166 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6168 (syms_of_lread): Declare `lexical-binding'.
6170 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6172 * keyboard.c (eval_dyn): New fun.
6173 (menu_item_eval_property): Use it.
6175 * image.c (parse_image_spec): Use Ffunctionp.
6177 * fns.c (concat, mapcar1): Accept byte-code-functions.
6179 * eval.c (Fsetq): Handle lexical vars.
6180 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6181 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6182 (FletX, Flet): Obey lexical binding.
6183 (Fcommandp): Handle closures.
6184 (Feval): New `lexical' arg.
6185 (eval_sub): New function extracted from Feval. Use it almost
6186 everywhere where Feval was used. Look up vars in lexical env.
6188 (Ffunctionp): Move from subr.el.
6189 (Ffuncall): Handle closures.
6190 (apply_lambda): Remove `eval_flags'.
6191 (funcall_lambda): Handle closures and new byte-code-functions.
6192 (Fspecial_variable_p): New function.
6193 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6194 but without exporting it to Lisp.
6196 * doc.c (Fdocumentation, store_function_docstring):
6197 * data.c (Finteractive_form): Handle closures.
6199 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6202 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6204 (exec_byte_code): New function extracted from Fbyte_code to handle new
6205 calling convention for byte-code-functions. Add new byte-codes.
6207 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6209 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6211 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6213 * xdisp.c (redisplay_internal): Fix prototype.
6215 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6217 * xdisp.c (SCROLL_LIMIT): New macro.
6218 (try_scrolling): Use it when setting scroll_limit.
6219 Limit scrolling to 100 screen lines.
6220 (redisplay_window): Even when falling back on "recentering",
6221 position point in the window according to scroll-conservatively,
6222 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6224 (try_scrolling): When point is above the window, allow searching
6225 as far as scroll_max, or one screenful, to compute vertical
6226 distance from PT to the scroll margin position. This prevents
6227 try_scrolling from unnecessarily failing when
6228 scroll-conservatively is set to a value slightly larger than the
6229 window height. Clean up the case of PT below the margin at bottom
6230 of window: scroll_max can no longer be INT_MAX. When aggressive
6231 scrolling is in use, don't let point enter the opposite scroll
6232 margin as result of the scroll.
6233 (syms_of_xdisp) <scroll-conservatively>: Document the
6234 threshold of 100 lines for never-recentering scrolling.
6236 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6238 * dispextern.h (move_it_by_lines):
6239 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6240 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6241 (message_log_check_duplicate): Remove parameters `prev_bol' and
6242 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6243 (redisplay_internal): Remove parameter `preserve_echo_area',
6244 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6246 * indent.c (Fvertical_motion):
6247 * window.c (window_scroll_pixel_based, Frecenter):
6248 Don't pass `need_y_p' to `move_it_by_lines'.
6250 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6252 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6253 steal a few bits to be more compact.
6254 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6255 Remove unneeded casts.
6257 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6259 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6261 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6262 binding" message (bug#7967).
6264 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6266 Fix more problems found by GCC 4.6.0's static checks.
6268 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6269 Remove unused local var.
6271 * editfns.c (Fmessage_box): Remove unused local var.
6273 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6274 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6275 Omit unused local vars.
6276 * window.c (shrink_windows): Omit unused local var.
6277 * menu.c (digest_single_submenu): Omit unused local var.
6278 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6279 Omit unused local var.
6281 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6282 Don't assume string length fits in int.
6283 (keyremap_step, read_key_sequence): Use size_t for sizes.
6284 (read_key_sequence): Don't check last_real_key_start redundantly.
6286 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6287 instead of alloca (Bug#8344).
6289 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6290 (Fbacktrace_frame): Don't assume nframes fits in int.
6292 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6294 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6297 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6299 * cm.c (calccost): Turn while-do into do-while, for clarity.
6301 * keyboard.c (syms_of_keyboard): Use the same style as later
6302 in this function when indexing through an array. This also
6303 works around GCC bug 48267.
6305 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6307 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6309 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6310 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6312 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6313 This avoids undefined behavior on integer overflow, and is a bit
6314 more convenient anyway since it is compared to a size_t variable.
6316 Variadic C functions now count arguments with size_t, not int.
6317 This avoids an unnecessary limitation on 64-bit machines, which
6318 caused (substring ...) to crash on large vectors (Bug#8344).
6319 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6320 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6321 All variadic functions and their callers changed accordingly.
6322 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6323 * data.c (arith_driver, float_arith_driver): Likewise.
6324 * editfns.c (general_insert_function): Likewise.
6325 * eval.c (struct backtrace.nargs, interactive_p)
6326 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6327 (funcall_lambda, mark_backtrace): Likewise.
6328 * fns.c (concat): Likewise.
6329 * frame.c (x_set_frame_parameters): Likewise.
6330 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6331 0 if not found, not -1. All callers changed.
6333 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6334 (stack_copy_size): Now size_t, not int.
6335 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6337 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6339 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6340 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6341 All callers changed.
6343 * lisp.h (multibyte_char_to_unibyte):
6344 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6345 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6346 * character.h (CHAR_TO_BYTE8):
6347 * cmds.c (internal_self_insert):
6348 * editfns.c (general_insert_function):
6349 * keymap.c (push_key_description):
6350 * search.c (Freplace_match):
6351 * xdisp.c (message_dolog, set_message_1): All callers changed.
6353 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6355 * keyboard.c (safe_run_hook_funcall): New function.
6356 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6357 don't set the hook to nil, but remove the offending function instead.
6358 (Qcommand_hook_internal): Remove, unused.
6359 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6360 Vcommand_hook_internal.
6362 * eval.c (enum run_hooks_condition): Remove.
6363 (funcall_nil, funcall_not): New functions.
6364 (run_hook_with_args): Call each function through a `funcall' argument.
6365 Remove `cond' argument, now redundant.
6366 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6367 (Frun_hook_with_args_until_failure): Adjust accordingly.
6368 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6370 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6372 * dispextern.h (string_buffer_position): Remove declaration.
6374 * print.c (strout): Remove parameter `multibyte', unused since
6375 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6377 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6378 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6379 All callers changed.
6381 * w32.c (_wsa_errlist): Use braces for struct initializers.
6383 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6384 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6385 All callers changed.
6386 (string_buffer_position): Likewise. Also, make static (it's never
6387 used outside xdisp.c).
6388 (cursor_row_p): Remove parameter `w', unused since
6389 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6390 (decode_mode_spec): Remove parameter `precision', introduced during
6391 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6392 All callers changed.
6394 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6396 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6398 2011-03-27 Anders Lindgren <andlind@gmail.com>
6400 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6401 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6402 (ns_update_auto_hide_menu_bar): New functions.
6403 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6404 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6405 ns_constrain_all_frames.
6406 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6407 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6409 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6411 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6413 2011-03-27 Glenn Morris <rgm@gnu.org>
6415 * syssignal.h: Replace RETSIGTYPE with void.
6416 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6417 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6418 Replace SIGTYPE with void everywhere.
6419 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6420 * s/template.h (SIGTYPE): Remove commented out definition.
6422 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6424 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6425 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6427 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6429 * w32.c (read_unc_volume): Use parameter `henum', instead of
6430 global variable `wget_enum_handle'.
6432 * keymap.c (describe_vector): Remove parameters `indices' and
6433 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6434 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6436 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6438 * keyboard.c (timer_check): Remove parameter `do_it_now',
6439 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6440 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6441 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6443 * keyboard.c (read_char):
6444 * w32menu.c (w32_menu_display_help):
6445 * xmenu.c (show_help_event, menu_help_callback):
6446 Adjust calls to `show_help_echo'.
6448 * gtkutil.c (xg_maybe_add_timer):
6449 * keyboard.c (readable_events):
6450 * process.c (wait_reading_process_output):
6451 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6453 * insdel.c (adjust_markers_gap_motion):
6454 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6455 (gap_left, gap_right): Don't call it.
6457 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6459 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6460 incurred during fontification.
6462 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6464 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6465 (DEFVAR_PER_BUFFER): Don't pass it.
6467 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6468 (scrolling_window): Don't pass it.
6470 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6472 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6474 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6476 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6477 of variables specific to SELinux and computation of `encoded_absname'.
6479 * image.c (XPutPixel): Remove unused variable `height'.
6481 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6483 * unexw32.c (get_section_info): Remove unused variable `section'.
6485 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6486 (system_process_attributes): Remove unused variable `sess'.
6487 (sys_read): Remove unused variable `err'.
6489 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6490 (w32_wnd_proc): Remove unused variable `isdead'.
6491 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6492 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6493 (x_create_tip_frame): Remove unused variable `tem'.
6495 * w32inevt.c (w32_console_read_socket):
6496 Remove unused variable `no_events'.
6498 * w32term.c (x_draw_composite_glyph_string_foreground):
6499 Remove unused variable `width'.
6501 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6503 * w32term.c (x_set_glyph_string_clipping):
6504 Don't pass uninitialized region to CombineRgn.
6506 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6508 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6509 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6510 (Fx_close_connection): Remove unused variable `i'.
6512 * w32font.c (w32font_draw): Return number of glyphs.
6513 (w32font_open_internal): Remove unused variable `i'.
6514 (w32font_driver): Add missing initializer.
6516 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6517 (fill_in_menu): Remove unused variable `items_added'.
6519 * w32term.c (last_mouse_press_frame): Remove static global variable.
6520 (w32_clip_to_row): Remove unused variable `f'.
6521 (x_delete_terminal): Remove unused variable `i'.
6523 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6524 (NOTHING): Remove unused static global variable.
6525 (uniscribe_check_otf): Remove unused variable `table'.
6526 (uniscribe_font_driver): Add missing initializers.
6528 2011-03-23 Julien Danjou <julien@danjou.info>
6530 * term.c (Fsuspend_tty, Fresume_tty):
6531 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6532 * window.c (temp_output_buffer_show):
6533 * insdel.c (signal_before_change):
6534 * frame.c (Fhandle_switch_frame):
6535 * fileio.c (Fdo_auto_save):
6536 * emacs.c (Fkill_emacs):
6537 * editfns.c (save_excursion_restore):
6538 * cmds.c (internal_self_insert):
6539 * callint.c (Fcall_interactively):
6540 * buffer.c (Fkill_all_local_variables):
6541 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6543 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6544 unconditionnaly since it does the check itself.
6546 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6548 Fix more problems found by GCC 4.5.2's static checks.
6550 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6551 the first time through the loop, since we know p0 < p1 then.
6552 This also avoids a gcc -Wstrict-overflow warning.
6554 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6555 leading to a memory leak, possible in functions like
6556 load_charset_map_from_file that can allocate an unbounded number
6557 of objects (Bug#8318).
6559 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6560 that could (at least in theory) be that large.
6562 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6563 This is less likely to overflow, and avoids undefined behavior if
6564 overflow does occur. All callers changed. Use strtoul to scan
6565 for the unsigned long integer.
6566 (pint2hrstr): Simplify and tune code slightly.
6567 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6569 * scroll.c (do_scrolling): Work around GCC bug 48228.
6570 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6572 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6573 This also avoids a warning with gcc -Wstrict-overflow.
6574 (validate_x_resource_name): Simplify count usage.
6575 This also avoids a warning with gcc -Wstrict-overflow.
6577 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6580 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6582 * process.c (Fmake_network_process): Use socklen_t, not int,
6583 where POSIX says socklen_t is required in portable programs.
6584 This fixes a porting bug on hosts like 64-bit HP-UX, where
6585 socklen_t is wider than int (Bug#8277).
6586 (Fmake_network_process, server_accept_connection):
6587 (wait_reading_process_output, read_process_output):
6590 * process.c: Rename or move locals to avoid shadowing.
6591 (list_processes_1, Fmake_network_process):
6592 (read_process_output_error_handler, exec_sentinel_error_handler):
6593 Rename or move locals.
6594 (Fmake_network_process): Define label "retry_connect" only if needed.
6595 (Fnetwork_interface_info): Fix pointer signedness.
6596 (process_send_signal): Add cast to avoid pointer signedness problem.
6597 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6598 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6600 Make tparam.h and terminfo.c consistent.
6601 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6602 Include tparam.h instead, since it declares them.
6603 * cm.h (PC): Remove extern decl; tparam.h now does this.
6604 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6605 * terminfo.c: Include tparam.h, to check interfaces.
6606 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6607 (tparam): Adjust signature to match interface in tparam.h;
6608 this removes some undefined behavior. Check that outstring and len
6609 are zero, which they always are with Emacs.
6610 * tparam.h (PC, BC, UP): New extern decls.
6612 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6613 (xftfont_open): Rename locals to avoid shadowing.
6615 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6616 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6617 (OTF_TAG_SYM): Omit macro if not needed.
6618 (ftfont_list): Remove unused local.
6619 (get_adstyle_property, ftfont_pattern_entity):
6620 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6621 Rename locals to avoid shadowing.
6623 * xfont.c (xfont_list_family): Mark var as initialized.
6625 * xml.c (make_dom): Now static.
6627 * composite.c (composition_compute_stop_pos): Rename local to
6629 (composition_reseat_it): Remove unused locals.
6630 (find_automatic_composition, composition_adjust_point): Likewise.
6631 (composition_update_it): Mark var as initialized.
6632 (find_automatic_composition): Mark vars as initialized,
6633 with a FIXME (Bug#8290).
6635 character.h: Rename locals to avoid shadowing.
6636 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6637 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6638 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6639 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6642 * textprop.c (property_change_between_p): Remove; unused.
6644 * intervals.c (interval_start_pos): Now static.
6646 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6648 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6649 Rename locals to avoid shadowing.
6651 * sound.c (wav_play, au_play, Fplay_sound_internal):
6652 Fix pointer signedness.
6653 (alsa_choose_format): Remove unused local var.
6654 (wav_play): Initialize a variable to 0, to prevent undefined
6655 behavior (Bug#8278).
6657 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6659 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6661 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6662 clobbering (Bug#8298).
6663 * sysdep.c (sys_subshell): Likewise.
6664 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6666 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6667 This should get cleaned up, so that child_setup has the
6668 same signature on all platforms.
6670 * callproc.c (call_process_cleanup): Now static.
6671 (relocate_fd): Rename locals to avoid shadowing.
6673 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6675 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6676 not to be necessary, and produces flickering.
6678 2011-03-20 Glenn Morris <rgm@gnu.org>
6680 * config.in: Remove file.
6682 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6684 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6685 are now in src/globals.h.
6686 (syms_of_minibuf): Remove spurious & from previous change.
6688 2011-03-20 Leo <sdl.web@gmail.com>
6690 * minibuf.c (completing-read-function): New variable.
6691 (completing-read-default): Rename from completing-read.
6692 (completing-read): Call completing-read-function.
6694 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6696 * xfaces.c (Fx_load_color_file):
6697 Read color file from absolute filename (bug#8250).
6699 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6701 * makefile.w32-in: Update dependencies.
6703 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6705 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6707 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6709 Fix more problems found by GCC 4.5.2's static checks.
6711 * process.c (make_serial_process_unwind, send_process_trap):
6712 (sigchld_handler): Now static.
6714 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6715 That way, the code declares only the vars that it needs.
6716 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6717 * s/cygwin.h (PTY_ITERATION): Likewise.
6718 * s/darwin.h (PTY_ITERATION): Likewise.
6719 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6721 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6722 * process.c (allocate_pty): Don't declare stb unless it's needed.
6724 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6725 (CONSTANTLIM): Remove; unused.
6726 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6727 Define only if needed.
6729 * unexelf.c (unexec): Name an expression,
6730 to avoid gcc -Wbad-function-cast warning.
6731 Use a different way to cause a compilation error if anyone uses
6732 n rather than nn, a way that does not involve shadowing.
6733 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6735 * deps.mk (unexalpha.o): Remove; unused.
6737 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6738 * unexec.h: New file.
6739 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6740 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6742 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6743 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6744 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6745 Change as necessary to match prototype in unexec.h.
6747 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6749 (back_comment, skip_chars): Mark vars as initialized.
6751 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6752 Rename locals to avoid shadowing.
6754 * lread.c (read1): Rewrite so as not to use empty "else".
6755 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6757 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6759 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6760 warning when compiling print.c.
6762 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6763 instead of using an uninitialized var.
6764 (font_sort_entities): Mark var as initialized.
6766 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6768 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6769 pointers to constants.
6770 (font_parse_fcname): Remove unused vars.
6771 (font_delete_unmatched): Now static.
6772 (font_get_spec): Remove; unused.
6773 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6774 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6775 Rename or move locals to avoid shadowing.
6777 * fns.c (require_nesting_list, require_unwind): Now static.
6778 (Ffillarray): Rename locals to avoid shadowing.
6780 * floatfns.c (domain_error2): Define only if needed.
6781 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6783 * alloc.c (mark_backtrace): Move decl from here ...
6784 * lisp.h: ... to here, so that it can be checked.
6786 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6787 (Fdefvar): Rewrite so as not to use empty "else".
6788 (lisp_indirect_variable): Name an expression,
6789 to avoid gcc -Wbad-function-cast warning.
6790 (Fdefvar): Rename locals to avoid shadowing.
6792 * callint.c (quotify_arg, quotify_args): Now static.
6793 (Fcall_interactively): Rename locals to avoid shadowing.
6794 Use const pointer when appropriate.
6796 * lisp.h (get_system_name, get_operating_system_release):
6797 Move decls here, to check interfaces.
6798 * process.c (get_operating_system_release): Move decl to lisp.h.
6799 * xrdb.c (get_system_name): Likewise.
6800 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6801 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6802 some of which prompt warnings from gcc -Wbad-function-cast.
6803 (Fformat_time_string, Fencode_time, Finsert_char):
6804 (Ftranslate_region_internal, Fformat):
6805 Rename or remove local vars to avoid shadowing.
6806 (Ftranslate_region_internal): Mark var as initialized.
6808 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6811 * lisp.h (eassert): Check that the argument compiles, even if
6812 ENABLE_CHECKING is not defined.
6814 * data.c (Findirect_variable): Name an expression, to avoid
6815 gcc -Wbad-function-cast warning.
6816 (default_value, arithcompare, arith_driver, arith_error): Now static.
6817 (store_symval_forwarding): Rename local to avoid shadowing.
6818 (Fmake_variable_buffer_local, Fmake_local_variable):
6819 Mark variables as initialized.
6820 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6822 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6823 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6824 Rename locals to avoid shadowing.
6825 (mark_stack): Move local variables into the #ifdef region where
6827 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6828 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6830 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6831 (GC_STRING_CHARS): Remove; not used.
6832 (Fmemory_limit): Cast sbrk's returned value to char *.
6834 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6835 avoids undefined behavior in theory.
6837 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6839 Use functions, not macros, for up- and down-casing (Bug#8254).
6840 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6841 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6842 to use the following functions instead of these macros.
6843 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6844 EMACS_INT, since callers assume the returned value fits in int.
6845 (upcase1): Likewise, for UPCASE_TABLE.
6846 (uppercasep, lowercasep, upcase): New static inline functions.
6847 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6848 the race-condition problem in the old DOWNCASE.
6850 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6851 Rename locals to avoid shadowing.
6852 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6853 (regex_compile, re_search_2, re_match_2_internal):
6854 Remove unused local vars.
6855 (FREE_VAR): Rewrite so as not to use empty "else",
6856 which gcc can warn about.
6857 (regex_compile, re_match_2_internal): Mark locals as initialized.
6858 (RETALLOC_IF): Define only if needed.
6859 (WORDCHAR_P): Likewise. This one is never needed, but is used
6860 only in a comment talking about a compiler bug, so put inside
6861 the #if 0 of that comment.
6862 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6863 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6866 * search.c (boyer_moore): Rename locals to avoid shadowing.
6867 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6868 (PREV_CHAR_BOUNDARY): Likewise.
6870 * search.c (simple_search): Remove unused var.
6872 * dired.c (compile_pattern): Move decl from here ...
6873 * lisp.h: ... to here, so that it can be checked.
6874 (struct re_registers): New forward decl.
6876 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6878 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6880 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6881 Rename locals to avoid shadowing.
6882 (Fvertical_motion): Mark locals as initialized.
6884 * casefiddle.c (casify_object, casify_region): Now static.
6885 (casify_region): Mark local as initialized.
6887 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6889 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6890 New macros, so that the caller can use some names other than
6891 gcpro1, gcpro2, etc.
6892 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6894 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6895 argument, for consistency with GCPRO2_VAR, etc: it is now the
6896 prefix of the variable, not the variable itself. All uses
6898 * dired.c (directory_files_internal, file_name_completion):
6899 Rename locals to avoid shadowing.
6901 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6902 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6903 dired.c's scmp function, had undefined behavior.
6904 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6905 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6906 * buffer.h: ... to here, because these macros use current_buffer,
6907 and the new implementation with inline functions needs to have
6908 current_buffer in scope now, rather than later when the macros
6910 (downcase, upcase1): New static inline functions.
6911 (DOWNCASE, UPCASE1): Reimplement using these functions.
6912 This avoids undefined behavior in expressions like
6913 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6914 from race conditions in accessing the global variables
6915 case_temp1 and case_temp2.
6916 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6917 * lisp.h (case_temp1, case_temp2): Remove their decls.
6918 * character.h (ASCII_CHAR_P): Move from here ...
6919 * lisp.h: ... to here, so that the inline functions mentioned
6922 * dired.c (directory_files_internal_unwind): Now static.
6924 * fileio.c (file_name_as_directory, directory_file_name):
6925 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6927 (file_name_as_directory): Use const pointers when appropriate.
6928 (Fexpand_file_name): Likewise. In particular, newdir might
6929 point at constant storage, so make it a const pointer.
6930 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6931 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6933 (Fset_file_times, Finsert_file_contents, auto_save_error):
6934 Rename locals to avoid shadowing.
6936 * minibuf.c (choose_minibuf_frame_1): Now static.
6937 (Ftry_completion, Fall_completions): Rename or remove locals
6940 * marker.c (bytepos_to_charpos): Remove; unused.
6942 * lisp.h (verify_bytepos, count_markers): New decls,
6943 so that gcc does not warn that these functions aren't declared.
6945 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6946 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6947 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6948 (copy_text): Remove unused local var.
6950 * filelock.c (within_one_second): Now static.
6951 (lock_file_1): Rename local to avoid shadowing.
6953 * buffer.c (fix_overlays_before): Mark locals as initialized.
6954 (fix_start_end_in_overlays): Likewise. This function should be
6955 simplified by using pointers-to-pointers, but that's a different
6957 (switch_to_buffer_1): Now static.
6958 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6959 (report_overlay_modification): Rename locals to avoid shadowing.
6961 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6962 Fix pointer signedness issue.
6963 (sys_subshell): Mark local as volatile if checking for lint,
6964 to suppress a gcc -Wclobbered warning that does not seem to be right.
6965 (MAXPATHLEN): Define only if needed.
6967 * process.c (serial_open, serial_configure): Move decls from here ...
6968 * systty.h: ... to here, so that they can be checked.
6970 * fns.c (get_random, seed_random): Move extern decls from here ...
6971 * lisp.h: ... to here, so that they can be checked.
6973 * sysdep.c (reset_io): Now static.
6974 (wait_for_termination_signal): Remove; unused.
6976 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6977 (copy_keymap_item, append_key, push_text_char_description):
6979 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6980 (DENSE_TABLE_SIZE): Remove; unused.
6981 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6982 (describe_map_tree):
6983 Rename locals to avoid shadowing.
6985 * keyboard.c: Declare functions static if they are not used elsewhere.
6986 (echo_char, echo_dash, cmd_error, top_level_2):
6987 (poll_for_input, handle_async_input): Now static.
6988 (read_char, kbd_buffer_get_event, make_lispy_position):
6989 (make_lispy_event, make_lispy_movement, apply_modifiers):
6990 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6991 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6992 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6993 (read_key_sequence, read_char): Mark locals as initialized.
6994 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6996 * keyboard.h (make_ctrl_char): New decl.
6997 (mark_kboards): Move decl here ...
6998 * alloc.c (mark_kboards): ... from here.
7000 * lisp.h (force_auto_save_soon): New decl.
7002 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7003 (DEFINE_DUMMY_FUNCTION): New macro.
7004 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7006 (main): Add casts to avoid warnings
7007 if GCC considers string literals to be constants.
7009 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7011 * dbusbind.c: Pointer signedness fixes.
7012 (xd_signature, xd_append_arg, xd_initialize):
7013 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7014 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7015 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7016 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7018 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7019 if GCC considers string literals to be constants.
7020 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7022 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7024 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7025 (print_preprocess, print_object): New macro to fix last change.
7027 * print.c (print_preprocess): Don't forget font objects.
7029 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7031 * emacs.c (USAGE3): Doc fixes.
7033 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7035 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7038 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7040 * lisp.h (VWindow_system, Qfile_name_history):
7041 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7042 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7043 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7045 * w32select.c: Don't #include "keyboard.h".
7046 (run_protected): Add extern declaration for waiting_for_input.
7048 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7049 * w32console.c (detect_input_pending, read_input_pending)
7050 (encode_terminal_code):
7051 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7052 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7053 (w32_system_caret_y, Qfile_name_history):
7054 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7055 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7056 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7057 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7058 * w32proc.c (Qlocal, report_file_error):
7059 * w32term.c (Vwindow_system, updating_frame):
7060 * w32uniscribe.c (initialized, uniscribe_font_driver):
7061 Remove unneeded extern declarations.
7063 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7065 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7067 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7069 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7070 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7071 These macros can no longer be used for assignment.
7073 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7074 Assign struct members directly, instead of using BUF_BEGV etc.
7075 (record_buffer_markers, fetch_buffer_markers): New functions for
7076 recording and fetching special buffer markers.
7077 (set_buffer_internal_1, set_buffer_temp): Use them.
7079 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7081 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7083 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7084 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7086 * xdisp.c (hscroll_window_tree):
7087 (reconsider_clip_changes): Use PT instead of BUF_PT.
7089 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7091 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7092 $(EMACS_ROOT)/lib/intprops.h.
7094 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7096 Fix more problems found by GCC 4.5.2's static checks.
7098 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7099 to unsigned char * to avoid compiler diagnostic.
7100 (xg_free_frame_widgets): Make it clear that a local variable is
7101 needed only if USE_GTK_TOOLTIP.
7102 (gdk_window_get_screen): Make it clear that this macro is needed
7103 only if USE_GTK_TOOLTIP.
7104 (int_gtk_range_get_value): New function, which avoids a diagnostic
7105 from gcc -Wbad-function-cast.
7106 (xg_set_toolkit_scroll_bar_thumb): Use it.
7107 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7108 diagnostic from gcc -Wbad-function-cast.
7109 (get_utf8_string, xg_get_file_with_chooser):
7110 Rename locals to avoid shadowing.
7111 (create_dialog): Move locals to avoid shadowing.
7113 * xgselect.c (xg_select): Remove unused var.
7115 * image.c (four_corners_best): Mark locals as initialized.
7116 (gif_load): Initialize transparent_p to zero (Bug#8238).
7117 Mark another local as initialized.
7118 (my_png_error, my_error_exit): Mark with NO_RETURN.
7120 * image.c (clear_image_cache): Now static.
7121 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7122 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7123 (x_edge_detection): Remove unnecessary cast that
7124 gcc -Wbad-function-cast diagnoses.
7125 (gif_load): Fix pointer signedness.
7126 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7127 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7129 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7131 Improve quality of tests for time stamp overflow.
7132 For example, without this patch (encode-time 0 0 0 1 1
7133 1152921504606846976) returns the obviously-bogus value (-948597
7134 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7135 reports time overflow. See
7136 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7137 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7138 * editfns.c: Include limits.h and intprops.h.
7139 (TIME_T_MIN, TIME_T_MAX): New macros.
7140 (time_overflow): Move earlier, to before first use.
7141 (hi_time, lo_time): New functions, for an accurate test for
7143 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7144 (Fget_internal_run_time): Don't assume time_t fits in int.
7145 (make_time): Use list2 instead of Fcons twice.
7146 (Fdecode_time): More accurate test for out-of-range times.
7147 (check_tm_member): New function.
7148 (Fencode_time): Use it, to test for out-of-range times.
7149 (lisp_time_argument): Don't rely on undefined left-shift and
7150 right-shift behavior when checking for time stamp overflow.
7152 * editfns.c (time_overflow): New function, refactoring common code.
7153 (Fformat_time_string, Fdecode_time, Fencode_time):
7154 (Fcurrent_time_string): Use it.
7156 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7157 * dired.c (make_time): Move to ...
7158 * editfns.c (make_time): ... here.
7159 * systime.h: Note the move.
7161 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7163 * fringe.c (update_window_fringes): Remove unused variables.
7165 * unexmacosx.c (copy_data_segment): Also copy __got section.
7168 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7170 * termcap.c [MSDOS]: Include "msdos.h".
7171 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7172 Constify `char *' arguments and their references according to
7173 prototypes in tparam.h.
7175 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7177 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7178 Adapt all references accordingly.
7180 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7182 2011-03-11 Tom Tromey <tromey@redhat.com>
7184 * buffer.c (syms_of_buffer): Remove obsolete comment.
7186 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7188 * termhooks.h (encode_terminal_code): Declare prototype.
7190 * msdos.c (encode_terminal_code): Don't declare prototype.
7192 * term.c (encode_terminal_code): Now external again, used by
7193 w32console.c and msdos.c.
7195 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7196 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7198 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7200 Fix some minor problems found by GCC 4.5.2's static checks.
7202 * fringe.c (update_window_fringes): Mark locals as initialized
7204 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7206 * alloc.c (mark_fringe_data): Move decl from here ...
7207 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7208 to check its interface.
7209 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7211 * fontset.c (free_realized_fontset): Now static.
7212 (Fset_fontset_font): Rename local to avoid shadowing.
7213 (fontset_font): Mark local as initialized.
7214 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7216 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7218 * xselect.c (x_disown_buffer_selections): Remove; not used.
7219 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7220 (x_own_selection, Fx_disown_selection_internal): Rename locals
7222 (x_handle_dnd_message): Remove local to avoid shadowing.
7224 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7225 so that the caller can use some name other than gcpro1.
7226 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7227 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7228 (Fx_backspace_delete_keys_p):
7229 Use them to avoid shadowing, and rename vars to avoid shadowing.
7230 (x_decode_color, x_set_name, x_window): Now static.
7231 (Fx_create_frame): Add braces to silence GCC warning.
7232 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7233 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7234 Remove unused locals.
7235 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7236 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7237 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7240 * xterm.h (x_mouse_leave): New decl.
7242 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7243 Remove unused functions.
7244 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7245 (x_calc_absolute_position): Now static.
7246 (XTread_socket): Don't define label "out" unless it's used.
7247 Don't declare local "event" unless it's used.
7248 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7249 unless they are used.
7250 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7251 (x_fatal_error_signal): Remove; not used.
7252 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7253 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7254 (x_error_catcher, x_connection_closed, x_error_handler):
7255 (x_error_quitter, xembed_send_message, x_iconify_frame):
7256 (my_log_handler): Rename locals to avoid shadowing.
7257 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7258 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7260 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7261 Rename or move locals to avoid shadowing.
7262 (tty_defined_color, merge_face_heights): Now static.
7263 (free_realized_faces_for_fontset): Remove; not used.
7264 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7265 does not deduce is never used uninitialized.
7266 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7267 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7269 * terminal.c (store_terminal_param): Now static.
7271 * xmenu.c (menu_highlight_callback): Now static.
7272 (set_frame_menubar): Remove unused local.
7273 (xmenu_show): Rename parameter to avoid shadowing.
7274 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7275 since they might point to immutable storage.
7276 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7277 since it's unused otherwise.
7279 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7280 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7281 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7282 avoids a gcc -Wuninitialized diagnostic.
7283 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7284 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7285 does not deduce are never used uninitialized.
7287 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7289 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7290 * window.c (window_loop, size_window):
7291 (run_window_configuration_change_hook, enlarge_window): Likewise.
7293 * window.c (display_buffer): Now static.
7294 (size_window): Mark variables that gcc -Wuninitialized
7295 does not deduce are never used uninitialized.
7296 * window.h (check_all_windows): New decl, to forestall
7297 gcc -Wmissing-prototypes diagnostic.
7298 * dispextern.h (bidi_dump_cached_states): Likewise.
7300 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7302 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7304 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7305 and to avoid gcc -Wuninitialized warning.
7306 (load_charset_map): Mark variables that gcc -Wuninitialized
7307 does not deduce are never used uninitialized.
7308 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7310 * coding.c (coding_set_source, coding_set_destination):
7311 Use "else { /* comment */ }" rather than "else /* comment */;"
7312 for clarity, and to avoid gcc -Wempty-body warning.
7313 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7314 a block, when the outer 'i' will do.
7315 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7316 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7317 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7318 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7319 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7320 Rename locals to avoid shadowing.
7321 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7322 * coding.c (emacs_mule_char, encode_invocation_designation):
7323 Now static, since they're not used elsewhere.
7324 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7325 (decode_coding_object, encode_coding_object, detect_coding_system):
7326 (decode_coding_emacs_mule): Mark variables that gcc
7327 -Wuninitialized does not deduce are never used uninitialized.
7328 (detect_coding_iso_2022): Initialize a local variable that might
7329 be used uninitialized. Leave a FIXME because it's not clear that
7330 this initialization is needed. (Bug#8211)
7331 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7332 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7333 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7334 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7335 Remove unused macros.
7337 * category.c (hash_get_category_set): Remove unused local var.
7338 (copy_category_table): Now static, since it's not used elsewhere.
7339 * character.c (string_count_byte8): Likewise.
7341 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7342 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7344 * chartab.c (copy_sub_char_table): Now static, since it's not used
7346 (sub_char_table_ref_and_range, char_table_ref_and_range):
7347 Rename locals to avoid shadowing.
7348 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7350 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7351 (BIDI_BOB): Remove unused macro.
7353 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7354 deduce are never used uninitialized.
7355 * term.c (encode_terminal_code): Likewise.
7357 * term.c (encode_terminal_code): Now static. Remove unused local.
7359 * tparam.h: New file.
7360 * term.c, tparam.h: Include it.
7361 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7362 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7363 Move these decls to tparam.h, and make them agree with what
7364 is actually in tparam.c. The previous trick of using incompatible
7365 decls in different modules does not conform to the C standard.
7366 All callers of tparam changed to use tparam's actual API.
7367 * tparam.c (tparam1, tparam, tgoto):
7368 Use const pointers where appropriate.
7370 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7371 * cm.h (struct cm): Likewise.
7372 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7373 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7374 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7375 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7376 (turn_on_face, init_tty): Likewise.
7377 * termchar.h (struct tty_display_info): Likewise.
7379 * term.c (term_mouse_position): Rename local to avoid shadowing.
7381 * alloc.c (mark_ttys): Move decl from here ...
7382 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7384 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7386 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7388 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7390 * search.c (compile_pattern_1): Remove argument regp, unused since
7391 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7392 (compile_pattern): Don't pass it.
7394 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7396 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7397 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7399 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7401 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7403 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7404 gdk_window_get_screen, gdk_window_get_geometry,
7405 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7406 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7407 (xg_get_pixbuf_from_pixmap): New function.
7408 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7409 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7410 Call xg_get_pixbuf_from_pixmap instead of
7411 gdk_pixbuf_get_from_drawable.
7412 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7413 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7414 (xg_check_special_colors): Use GtkStyleContext and its functions
7416 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7417 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7418 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7419 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7420 Call gtk_widget_get_preferred_size.
7421 (xg_frame_resized): gdk_window_get_geometry only takes 5
7423 (xg_win_to_widget, xg_event_is_for_menubar):
7424 Call gdk_x11_window_lookup_for_display.
7425 (xg_set_widget_bg): New function.
7426 (delete_cb): New function.
7427 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7428 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7429 (xg_set_background_color): Call xg_set_widget_bg.
7430 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7431 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7432 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7433 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7435 (update_frame_tool_bar): Call gtk_widget_hide.
7436 (xg_initialize): Use GDK_KEY_g.
7438 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7440 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7442 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7443 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7444 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7446 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7448 * w32xfns.c (select_palette): Check success of RealizePalette against
7449 GDI_ERROR, not zero.
7451 See ChangeLog.11 for earlier changes.
7457 Copyright (C) 2011 Free Software Foundation, Inc.
7459 This file is part of GNU Emacs.
7461 GNU Emacs is free software: you can redistribute it and/or modify
7462 it under the terms of the GNU General Public License as published by
7463 the Free Software Foundation, either version 3 of the License, or
7464 (at your option) any later version.
7466 GNU Emacs is distributed in the hope that it will be useful,
7467 but WITHOUT ANY WARRANTY; without even the implied warranty of
7468 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7469 GNU General Public License for more details.
7471 You should have received a copy of the GNU General Public License
7472 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.