Doc fixes for imagemagick support code.
[bpt/emacs.git] / src / ChangeLog
1 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2
3 * image.c: Various fixes to ImageMagick code comments.
4 (Fimagemagick_types): Doc fix.
5
6 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7
8 Minor fixes prompted by GCC 4.6.0 warnings.
9
10 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11
12 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
13 (x_clipboard_manager_save_all): Move extern decl to ...
14 * xterm.h: ... here, so that it can be checked for consistency.
15
16 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
17
18 * xselect.c (x_clipboard_manager_save_frame)
19 (x_clipboard_manager_save_all): New functions.
20 (Fx_clipboard_manager_save): Lisp function deleted.
21
22 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
23 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
24
25 * xterm.h: Update prototype.
26
27 2011-05-28 William Xu <william.xwl@gmail.com>
28
29 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
30 exiting (Bug#8239).
31
32 2011-05-28 Jim Meyering <meyering@redhat.com>
33
34 Avoid a sign-extension bug in crypto_hash_function.
35 * fns.c (to_uchar): Define.
36 (crypto_hash_function): Use it to convert some newly-signed
37 variables to unsigned, to avoid sign-extension bugs. For example,
38 without this change, (md5 "truc") would evaluate to
39 45723a2aff78ff4fff7fff1114760e62 rather than the expected
40 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
41 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
42
43 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
44
45 Integer overflow fixes.
46
47 * dbusbind.c: Serial number integer overflow fixes.
48 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
49 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
50 to hold a serial number that is too large for a fixnum.
51 (Fdbus_method_return_internal, Fdbus_method_error_internal):
52 Check for serial numbers out of range. Decode any serial number
53 that was so large that it became a float. (Bug#8722)
54
55 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
56 (Fdbus_call_method, Fdbus_call_method_asynchronously):
57 Use XFASTINT rather than XUINT when numbers are nonnegative.
58 (xd_append_arg, Fdbus_method_return_internal):
59 (Fdbus_method_error_internal): Likewise. Also, for unsigned
60 arguments, check that Lisp number is nonnegative, rather than
61 silently wrapping negative numbers around. (Bug#8722)
62 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
63 (Bug#8722)
64
65 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
66
67 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
68
69 ccl: add integer overflow checks
70 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
71 (IN_INT_RANGE): New macros.
72 (ccl_driver): Use them to check for integer overflow when
73 decoding a CCL program. Many of the new checks are whether XINT (x)
74 fits in int; it doesn't always, on 64-bit hosts. The new version
75 doesn't catch all possible integer overflows, but it's an
76 improvement. (Bug#8719)
77
78 * alloc.c (make_event_array): Use XINT, not XUINT.
79 There's no need for unsigned here.
80
81 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
82 This follows up to the 2011-05-06 change that substituted uintptr_t
83 for EMACS_INT. This case wasn't caught back then.
84
85 Rework Fformat to avoid integer overflow issues.
86 * editfns.c: Include <float.h> unconditionally, as it's everywhere
87 now (part of C89). Include <verify.h>.
88 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
89 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
90 (Fformat): Avoid the prepass trying to compute sizes; it was only
91 approximate and thus did not catch overflow reliably. Instead, walk
92 through the format just once, formatting and computing sizes as we go,
93 checking for integer overflow at every step, and allocating a larger
94 buffer as needed. Keep track separately whether the format is
95 multibyte. Keep only the most-recently calculated precision, rather
96 than them all. Record whether each argument has been converted to
97 string. Use EMACS_INT, not int, for byte and char and arg counts.
98 Support field widths and precisions larger than INT_MAX. Avoid
99 sprintf's undefined behavior with conversion specifications such as %#d
100 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
101 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
102 formatting out-of-range floating point numbers with int
103 formats. (Bug#8668)
104
105 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
106
107 * data.c: Avoid integer truncation in expressions involving floats.
108 * data.c: Include <intprops.h>.
109 (arith_driver): When there's an integer overflow in an expression
110 involving floating point, convert the integers to floating point
111 so that the resulting value does not suffer from catastrophic
112 integer truncation. For example, on a 64-bit host (* 4
113 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
114 Do not rely on undefined behavior after integer overflow.
115
116 merge count_size_as_multibyte, parse_str_to_multibyte
117 * character.c, character.h (count_size_as_multibyte):
118 Renamed from parse_str_to_multibyte; all uses changed.
119 Check for integer overflow.
120 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
121 since it's now a duplicate of the other. This is more of
122 a character than a buffer op, so better that it's in character.c.
123 * fns.c, print.c: Adjust to above changes.
124
125 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
126
127 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
128
129 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
130
131 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
132 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
133 (x_clipboard_manager_save): Now static.
134 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
135
136 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
137 (crypto_hash_function): Now static.
138 Fix pointer signedness problems. Avoid unnecessary initializations.
139
140 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
141
142 * termhooks.h (Vselection_alist): Make it terminal-local.
143
144 * terminal.c (create_terminal): Initialize it.
145
146 * xselect.c: Support for clipboard managers.
147 (Vselection_alist): Move to termhooks.h as terminal-local var.
148 (LOCAL_SELECTION): New macro.
149 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
150 (symbol_to_x_atom): Remove gratuitous arg.
151 (x_handle_selection_request, lisp_data_to_selection_data)
152 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
153 (x_own_selection, x_get_local_selection, x_convert_selection): New
154 arg, specifying work frame. Use terminal-local Vselection_alist.
155 (some_frame_on_display): Delete unused function.
156 (Fx_own_selection_internal, Fx_get_selection_internal)
157 (Fx_disown_selection_internal, Fx_selection_owner_p)
158 (Fx_selection_exists_p): New optional frame arg.
159 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
160 (x_handle_selection_clear): Don't treat other terminals with the
161 same keyboard specially. Use the terminal-local Vselection_alist.
162 (x_clear_frame_selections): Use Frun_hook_with_args.
163
164 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
165
166 * xterm.h: Add support for those atoms.
167
168 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
169
170 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
171 (converted_selections, conversion_fail_tag): New global variables.
172 (x_selection_request_lisp_error): Free the above.
173 (x_get_local_selection): Remove unnecessary code.
174 (x_reply_selection_request): Args changed; handle arbitrary array
175 of converted selections stored in converted_selections. Separate
176 the XChangeProperty and SelectionNotify steps.
177 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
178 (x_convert_selection): New function.
179 (x_handle_selection_event): Simplify.
180 (x_get_foreign_selection): Don't ignore incoming requests while
181 waiting for an answer; this will fail when we implement
182 SAVE_TARGETS, and seems unnecessary anyway.
183 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
184 (Vx_sent_selection_functions): Doc fix.
185
186 2011-05-26 Leo Liu <sdl.web@gmail.com>
187
188 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
189
190 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
191
192 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
193
194 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
195 for fringe update if it has periodic bitmap.
196 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
197 and fringe_bitmap_periodic_p.
198
199 * fringe.c (get_fringe_bitmap_data): New function.
200 (draw_fringe_bitmap_1, update_window_fringes): Use it.
201 (update_window_fringes): Record periodicity of fringe bitmap in glyph
202 row. Mark glyph row for fringe update if periodicity changed.
203
204 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
205 for fringe update unless it has periodic bitmap.
206
207 2011-05-25 Kenichi Handa <handa@m17n.org>
208
209 * xdisp.c (get_next_display_element): Set correct it->face_id for
210 a static composition.
211
212 2011-05-24 Leo Liu <sdl.web@gmail.com>
213
214 * deps.mk (fns.o):
215 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
216
217 * fns.c (crypto_hash_function, Fsha1): New function.
218 (Fmd5): Use crypto_hash_function.
219 (syms_of_fns): Add Ssha1.
220
221 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
222
223 * gnutls.c: Remove unused macros.
224 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
225 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
226 Remove macros that are defined and never used.
227 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
228
229 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
230
231 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
232 (Fx_get_selection_internal): Minor cleanup.
233 (Fx_own_selection_internal): Rename arguments for consistency with
234 select.el.
235
236 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
237
238 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
239
240 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
241
242 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
243
244 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
245
246 * dispnew.c (scrolling_window): Don't exclude the case that the
247 last enabled row in the desired matrix touches the bottom boundary.
248
249 2011-05-21 Glenn Morris <rgm@gnu.org>
250
251 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
252 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
253 and add some more files.
254
255 2011-05-20 Eli Zaretskii <eliz@gnu.org>
256
257 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
258 report_file_error introduced by the change from 2011-05-07.
259
260 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
261
262 * systime.h (Time): Define only if emacs is defined.
263 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
264 where the include path doesn't have X11/X.h by default. See
265 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
266
267 2011-05-20 Kenichi Handa <handa@m17n.org>
268
269 * composite.c (find_automatic_composition): Fix previous change.
270
271 2011-05-20 Glenn Morris <rgm@gnu.org>
272
273 * lisp.mk: New file, split from Makefile.in.
274 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
275 (shortlisp): Remove.
276 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
277
278 2011-05-19 Glenn Morris <rgm@gnu.org>
279
280 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
281 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
282 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
283 (lisp): Set the order to that of loadup.el.
284 (shortlisp): Make it a copy of $lisp.
285 (SOME_MACHINE_LISP): Remove.
286 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
287 Use just $shortlisp, not $SOME_MACHINE_LISP too.
288
289 2011-05-18 Kenichi Handa <handa@m17n.org>
290
291 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
292 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
293 (find_automatic_composition): Mostly rewrite for efficiency.
294
295 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
296
297 * makefile.w32-in: Update dependencies.
298
299 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
300
301 * menu.c: Include limits.h (fixes the MS-Windows build broken by
302 revision 104625).
303
304 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
305
306 Fix some integer overflow issues, such as string length overflow.
307
308 * insdel.c (count_size_as_multibyte): Check for string overflow.
309
310 * character.c (lisp_string_width): Check for string overflow.
311 Use EMACS_INT, not int, for string indexes and lengths; in
312 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
313 the resulting string length overflows an EMACS_INT; instead,
314 report a string overflow if no precision given. When checking for
315 precision exhaustion, use a check that cannot possibly have
316 integer overflow. (Bug#8675)
317 * character.h (lisp_string_width): Adjust to new signature.
318
319 * alloc.c (string_overflow): New function.
320 (Fmake_string): Use it. This doesn't change behavior, but saves
321 a few bytes and will simplify future changes.
322 * character.c (string_escape_byte8): Likewise.
323 * lisp.h (string_overflow): New decl.
324
325 Fixups, following up to the user-interface timestamp change.
326 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
327 for UI timestamps, instead of unsigned long.
328 * msdos.c (mouse_get_pos): Likewise.
329 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
330 * w32gui.h (Time): Define by including "systime.h" rather than by
331 declaring it ourselves. (Bug#8664)
332
333 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
334 * image.c (clear_image_cache): Likewise.
335
336 * term.c (term_mouse_position): Don't assume time_t wraparound.
337
338 Be more systematic about user-interface timestamps.
339 Before, the code sometimes used 'Time', sometimes 'unsigned long',
340 and sometimes 'EMACS_UINT', to represent these timestamps. This
341 change causes it to use 'Time' uniformly, as that's what X uses.
342 This makes the code easier to follow, and makes it easier to catch
343 integer overflow bugs such as Bug#8664.
344 * frame.c (Fmouse_position, Fmouse_pixel_position):
345 Use Time, not unsigned long, for user-interface timestamps.
346 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
347 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
348 * keyboard.h (last_event_timestamp): Likewise.
349 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
350 * menu.h (xmenu_show): Likewise.
351 * term.c (term_mouse_position): Likewise.
352 * termhooks.h (struct input_event.timestamp): Likewise.
353 (struct terminal.mouse_position_hook): Likewise.
354 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
355 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
356 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
357 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
358 what it was before.
359 * menu.h, termhooks.h: Include "systime.h", for Time.
360
361 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
362 Don't assume that the difference between two unsigned long values
363 can fit into an integer. At this point, we know button_down_time
364 <= event->timestamp, so the difference must be nonnegative, so
365 there's no need to cast the result if double-click-time is
366 nonnegative, as it should be; check that it's nonnegative, just in
367 case. This bug is triggered when events are more than 2**31 ms
368 apart (about 25 days). (Bug#8664)
369
370 * xselect.c (last_event_timestamp): Remove duplicate decl.
371 (x_own_selection): Remove needless cast to unsigned long.
372
373 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
374 that always fit in int. Use a sentinel instead of a counter, to
375 avoid a temp and to allay GCC's concerns about possible int overflow.
376 * frame.h (struct frame): Use int for menu_bar_items_used
377 instead of EMACS_INT, since it always fits in int.
378
379 * menu.c (grow_menu_items): Check for int overflow.
380
381 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
382
383 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
384 Before, the code was not consistent. These values cannot exceed
385 2**31 - 1 so there's no need to make them unsigned.
386 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
387 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
388 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
389 as modifiers.
390 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
391
392 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
393 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
394 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
395 presumably because the widths might not match.
396
397 * window.c (size_window): Avoid needless test at loop start.
398
399 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
400
401 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
402
403 2011-05-12 Drew Adams <drew.adams@oracle.com>
404
405 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
406
407 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
408
409 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
410 `width' to `bar_area_x' and `bar_area_width', respectively.
411 (x_scroll_run): Take account of fringe background extension.
412
413 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
414 Rename local vars `left' and `width' to `bar_area_x' and
415 `bar_area_width', respectively.
416 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
417 background extension.
418
419 2011-05-10 Jim Meyering <meyering@redhat.com>
420
421 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
422
423 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
424
425 * image.c (Finit_image_library): Return t for built-in image types,
426 like pbm and xbm. (Bug#8640)
427
428 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
429
430 * w32menu.c (set_frame_menubar): Fix submenu allocation.
431
432 2011-05-07 Eli Zaretskii <eliz@gnu.org>
433
434 * w32console.c (Fset_screen_color): Doc fix.
435 (Fget_screen_color): New function.
436 (syms_of_ntterm): Defsubr it.
437
438 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
439 unlink the temporary file if Fcall_process didn't create it in the
440 first place.
441 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
442 child process will be redirected to a file specified with `:file'.
443 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
444 cue to call_process_cleanup not to close that handle.
445
446 2011-05-07 Ben Key <bkey76@gmail.com>
447
448 * makefile.w32-in: The bootstrap-temacs rule now makes use of
449 one of two shell specific rules, either bootstrap-temacs-CMD or
450 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
451 to the previous implementation of the bootstrap-temacs rule.
452 The bootstrap-temacs-CMD rule is similar to the previous
453 implementation of the bootstrap-temacs rule except that it
454 makes use of the ESC_CFLAGS variable instead of the CFLAGS
455 variable.
456
457 These changes, along with some changes to nt/configure.bat,
458 nt/gmake.defs, and nt/nmake.defs, are required to extend my
459 earlier fix to add support for --cflags and --ldflags options
460 that include quotes so that it works whether make uses cmd or
461 sh as the shell.
462
463 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
464
465 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
466 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
467 is a constant.
468 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
469 a string. Handle both cases.
470 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
471 (Fdbus_register_method): Use Qinvalid_function.
472
473 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
474
475 * makefile.w32-in: Update dependencies.
476 (LISP_H): Add inttypes.h and stdin.h.
477 (PROCESS_H): Add unistd.h.
478
479 2011-05-06 Eli Zaretskii <eliz@gnu.org>
480
481 * lread.c: Include limits.h (fixes the MS-Windows build broken by
482 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
483
484 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
485
486 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
487
488 * term.c (vfatal): Remove stray call to va_end.
489 It's not needed and the C Standard doesn't allow it here anyway.
490
491 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
492 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
493
494 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
495 bytes.
496
497 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
498
499 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
500
501 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
502
503 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
504
505 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
506
507 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
508 * charset.c (Fdefine_charset_internal): Don't initialize
509 charset.code_space[15]. The value was garbage, on hosts with
510 32-bit int (Bug#8600).
511
512 * lread.c (read_integer): Be more consistent with string-to-number.
513 Use string_to_number to do the actual conversion; this avoids
514 rounding errors and fixes some other screwups. Without this fix,
515 for example, #x1fffffffffffffff was misread as -2305843009213693952.
516 (digit_to_number): Move earlier, for benefit of read_integer.
517 Return -1 if the digit is out of range for the base, -2 if it is
518 not a digit in any supported base. (Bug#8602)
519
520 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
521
522 * dispnew.c (scrolling_window): Return 1 if we scrolled,
523 to match comment at start of function. This also removes a
524 GCC warning about overflow in a 32+64-bit port.
525
526 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
527
528 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
529 Reported by Stefan Monnier in
530 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
531 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
532 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
533
534 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
535 (EMACS_UINTPTR): Likewise, with uintptr_t.
536
537 * lisp.h: Prefer 64-bit EMACS_INT if available.
538 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
539 on 32-bit hosts that have 64-bit int, so that they can access
540 large files.
541 However, temporarily disable this change unless the temporary
542 symbol WIDE_EMACS_INT is defined.
543
544 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
545
546 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
547 This removes an assumption that EMACS_INT and long are the same
548 width as pointers. The assumption is true for Emacs porting targets
549 now, but we want to make other targets possible.
550 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
551 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
552 In the rest of the code, change types of integers that hold casted
553 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
554 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
555 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
556 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
557 No need to cast type when ORing.
558 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
559 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
560 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
561 assume EMACS_INT is the same width as char *.
562 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
563 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
564 Remove no-longer-needed casts.
565 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
566 (xg_tool_bar_help_callback, xg_make_tool_item):
567 Use EMACS_INTPTR to hold an integer
568 that will be cast to void *; this can avoid a GCC warning
569 if EMACS_INT is not the same width as void *.
570 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
571 * xdisp.c (display_echo_area_1, resize_mini_window_1):
572 (current_message_1, set_message_1):
573 Use a local to convert to proper width without a cast.
574 * xmenu.c (dialog_selection_callback): Likewise.
575
576 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
577 Also, don't assume VALBITS / RAND_BITS is less than 5,
578 and don't rely on undefined behavior when shifting a 1 left into
579 the sign bit.
580 * lisp.h (get_random): Change signature to match.
581
582 * lread.c (hash_string): Use size_t, not int, for hash computation.
583 Normally we prefer signed values; but hashing is special, because
584 it's better to use unsigned division on hash table sizes so that
585 the remainder is nonnegative. Also, size_t is the natural width
586 for hashing into memory. The previous code used 'int', which doesn't
587 retain enough info to hash well into very large tables.
588 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
589
590 * dbusbind.c: Don't possibly lose pointer info when converting.
591 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
592 Use XPNTR rather than XHASH, so that the high-order bits of
593 the pointer aren't lost when converting through void *.
594
595 * eval.c (Fautoload): Don't double-shift a pointer.
596
597 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
598
599 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
600
601 * gnutls.c (DEF_GNUTLS_FN):
602 * image.c (DEF_IMGLIB_FN): Make function pointers static.
603
604 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
605
606 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
607 marker. (Bug#8610)
608
609 2011-05-05 Eli Zaretskii <eliz@gnu.org>
610
611 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
612 New version that can reserve upto 2GB of heap space.
613
614 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
615
616 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
617
618 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
619
620 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
621 `gnutls_certificate_set_x509_key_file'.
622
623 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
624
625 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
626 Update dependencies.
627
628 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
629
630 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
631 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
632 Remove unused parameter `fildes'.
633 * process.c (read_process_output, send_process): Don't pass it.
634
635 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
636
637 Fix previous change: the library cache is defined in w32.c.
638 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
639 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
640
641 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
642
643 Implement dynamic loading of GnuTLS on Windows.
644
645 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
646 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
647 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
648 Declare.
649
650 * gnutls.c (Qgnutls_dll): Define.
651 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
652 (gnutls_*): Declare function pointers.
653 (init_gnutls_functions): New function to initialize function pointers.
654 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
655 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
656 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
657 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
658 (emacs_gnutls_write, emacs_gnutls_read)
659 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
660 (Fgnutls_available_p): New function.
661 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
662 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
663 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
664
665 * image.c: Include w32.h.
666 (Vimage_type_cache): Delete.
667 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
668 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
669 (w32_delayed_load): Move to w32.c.
670
671 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
672
673 * w32.c (QCloaded_from, Vlibrary_cache): Define.
674 (w32_delayed_load): Move from image.c. When loading a library, record
675 its filename in the :loaded-from property of the library id.
676 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
677 Initialize and staticpro them.
678 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
679
680 * process.c: Include lisp.h before w32.h, not after.
681 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
682 instead of gnutls_record_check_pending.
683
684 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
685
686 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
687
688 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
689 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
690 as passed in.
691
692 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
693
694 * xterm.c (x_set_frame_alpha): Do not set property on anything
695 else than FRAME_X_OUTER_WINDOW (Bug#8608).
696
697 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
698
699 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
700
701 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
702
703 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
704 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
705 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
706 (gnutls_global_initialized, Qgnutls_bootprop_priority)
707 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
708 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
709 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
710 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
711 (Qgnutls_bootprop_callbacks_verify): Make static.
712
713 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
714
715 * callproc.c: Indentation fixup.
716
717 * sysdep.c (wait_for_termination_1): Make static.
718 (wait_for_termination, interruptible_wait_for_termination):
719 Move after wait_for_termination_1.
720
721 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
722
723 * sysdep.c (interruptible_wait_for_termination): New function
724 which is like wait_for_termination, but allows keyboard
725 interruptions.
726
727 * callproc.c (Fcall_process): Add (:file "file") as an option for
728 the STDOUT buffer.
729 (Fcall_process_region): Ditto.
730
731 2011-04-30 Eli Zaretskii <eliz@gnu.org>
732
733 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
734 rather than `XVECTOR (FOO)->size'.
735
736 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
737 inttypes.h, as a gnulib replacement is used if it not available in
738 system headers.
739
740 2011-04-21 Eli Zaretskii <eliz@gnu.org>
741
742 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
743 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
744 of MOST_POSITIVE_FIXNUM. (Bug#8528)
745
746 * coding.c (coding_alloc_by_realloc): Error out if destination
747 will grow beyond MOST_POSITIVE_FIXNUM.
748 (decode_coding_emacs_mule): Abort if there isn't enough place in
749 charbuf for the composition carryover bytes. Reserve an extra
750 space for up to 2 characters produced in a loop.
751 (decode_coding_iso_2022): Abort if there isn't enough place in
752 charbuf for the composition carryover bytes.
753
754 2011-04-21 Eli Zaretskii <eliz@gnu.org>
755
756 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
757 aborting when %lld or %lll format is passed.
758 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
759 %llo or %llx format is passed. (Bug#8545)
760
761 * window.c (window_scroll_line_based): Use a marker instead of
762 simple variables to record original value of point. (Bug#7952)
763
764 * doprnt.c (doprnt): Fix the case where a multibyte sequence
765 produced by %s or %c overflows available buffer space. (Bug#8545)
766
767 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
768
769 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
770 (SIZE_MAX): Move defn after all includes, as they might #define it.
771
772 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
773
774 * w32.c (init_environment): Warn about defaulting HOME to C:\.
775
776 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
777
778 * keyboard.c (Qdelayed_warnings_hook): Define.
779 (command_loop_1): Run `delayed-warnings-hook'
780 if Vdelayed_warnings_list is non-nil.
781 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
782 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
783
784 2011-04-28 Eli Zaretskii <eliz@gnu.org>
785
786 * doprnt.c (doprnt): Don't return value smaller than the buffer
787 size if the message was truncated. (Bug#8545).
788
789 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
790
791 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
792 (Fx_window_property): #if-0 the whole functions, not just the bodies.
793
794 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
795
796 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
797
798 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
799
800 * makefile.w32-in: Update dependencies.
801
802 2011-04-27 Eli Zaretskii <eliz@gnu.org>
803
804 Improve `doprnt' and its usage. (Bug#8545)
805 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
806 `format_end'. Remove support for %l as a conversion specifier.
807 Don't use xrealloc. Improve diagnostics when the %l size modifier
808 is used. Update the commentary.
809
810 * eval.c (verror): Simplify calculation of size_t.
811
812 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
813 messages.
814
815 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
816
817 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
818 change.
819
820 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
821
822 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
823 This makes this file independent of the recent pseudovector change.
824
825 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
826
827 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
828
829 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
830 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
831 Remove unused local.
832 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
833
834 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
835 GCC 4.6.0 optimizes based on type-based alias analysis.
836 For example, if b is of type struct buffer * and v of type struct
837 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
838 != &v->size, and therefore "v->size = 1; b->size = 2; return
839 v->size;" must therefore return 1. This assumption is incorrect
840 for Emacs, since it type-puns struct Lisp_Vector * with many other
841 types. To fix this problem, this patch adds a new type struct
842 vectorlike_header that documents the constraints on layout of vectors
843 and pseudovectors, and helps optimizing compilers not get fooled
844 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
845 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
846 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
847 the size member.
848 (XSETPVECTYPE): Rewrite in terms of new macro.
849 (XSETPVECTYPESIZE): New macro, specifying both type and size.
850 This is a bit clearer, and further avoids the possibility of
851 undesirable aliasing.
852 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
853 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
854 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
855 since Lisp_Subr is a special case (no "next" field).
856 (ASIZE): Now uses header.size rather than size.
857 All previous uses of XVECTOR (foo)->size replaced to use this macro,
858 to avoid the hassle of writing XVECTOR (foo)->header.size.
859 (struct vectorlike_header): New type.
860 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
861 object, to help avoid aliasing.
862 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
863 (SUBRP): Likewise, since Lisp_Subr is a special case.
864 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
865 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
866 (struct Lisp_Hash_Table): Combine first two members into a single
867 struct vectorlike_header member. All uses of "size" and "next" members
868 changed to be "header.size" and "header.next".
869 * buffer.h (struct buffer): Likewise.
870 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
871 * frame.h (struct frame): Likewise.
872 * process.h (struct Lisp_Process): Likewise.
873 * termhooks.h (struct terminal): Likewise.
874 * window.c (struct save_window_data, struct saved_window): Likewise.
875 * window.h (struct window): Likewise.
876 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
877 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
878 * buffer.c (init_buffer_once): Likewise.
879 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
880 special case.
881 * process.c (Fformat_network_address): Use local var for size,
882 for brevity.
883
884 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
885
886 Make the Lisp reader and string-to-float more consistent (Bug#8525)
887 * data.c (atof): Remove decl; no longer used or needed.
888 (digit_to_number): Move to lread.c.
889 (Fstring_to_number): Use new string_to_number function, to be
890 consistent with how the Lisp reader treats infinities and NaNs.
891 Do not assume that floating-point numbers represent EMACS_INT
892 without losing information; this is not true on most 64-bit hosts.
893 Avoid double-rounding errors, by insisting on integers when
894 parsing non-base-10 numbers, as the documentation specifies.
895 * lisp.h (string_to_number): New decl, replacing ...
896 (isfloat_string): Remove.
897 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
898 (read1): Do not accept +. and -. as integers; this
899 appears to have been a coding error. Similarly, do not accept
900 strings like +-1e0 as floating point numbers. Do not report
901 overflow for integer overflows unless the base is not 10 which
902 means we have no simple and reliable way to continue.
903 Break out the floating-point parsing into a new
904 function string_to_number, so that Fstring_to_number parses
905 floating point numbers consistently with the Lisp reader.
906 (digit_to_number): Move here from data.c. Make it static inline.
907 (E_CHAR, EXP_INT): Remove, replacing with ...
908 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
909 (string_to_number): New function, replacing isfloat_string.
910 This function checks for valid syntax and produces the resulting
911 Lisp float number too. Rework it so that string-to-number
912 no longer mishandles examples like "1.0e+". Use strtoumax,
913 so that overflow for non-base-10 numbers is reported only when
914 there's no portable and simple way to convert to floating point.
915
916 * textprop.c (set_text_properties_1): Rewrite for clarity,
917 and to avoid GCC warning about integer overflow.
918
919 * intervals.h (struct interval): Use EMACS_INT for members
920 where EMACS_UINT might cause problems. See
921 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
922 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
923 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
924 All uses changed.
925 (offset_intervals): Tell GCC not to worry about length overflow
926 when negating a negative length.
927
928 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
929 (overrun_check_free): Likewise.
930
931 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
932 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
933 word size.
934
935 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
936 (gnutls_make_error): Rename local to avoid shadowing.
937 (gnutls_emacs_global_deinit): ifdef out; not used.
938 (Fgnutls_boot): Use const for pointer to readonly storage.
939 Comment out unused local. Fix pointer signedness problems.
940
941 * lread.c (openp): Don't stuff size_t into an 'int'.
942 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
943 about possible signed overflow.
944
945 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
946 (GDK_KEY_g): Don't define if already defined.
947 (xg_prepare_tooltip): Avoid pointer signedness problem.
948 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
949
950 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
951 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
952
953 * xfns.c (Fx_window_property): Simplify a bit,
954 to make a bit faster and to avoid GCC 4.6.0 warning.
955 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
956
957 * fns.c (internal_equal): Don't assume size_t fits in int.
958
959 * alloc.c (compact_small_strings): Tighten assertion a little.
960
961 Replace pEd with more-general pI, and fix some printf arg casts.
962 * lisp.h (pI): New macro, generalizing old pEd macro to other
963 conversion specifiers. For example, use "...%"pI"d..." rather
964 than "...%"pEd"...".
965 (pEd): Remove. All uses replaced with similar uses of pI.
966 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
967 * alloc.c (check_pure_size): Don't overflow by converting size to int.
968 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
969 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
970 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
971 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
972 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
973 64-bit hosts.
974 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
975 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
976 * print.c (safe_debug_print, print_object): Likewise.
977 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
978 to int.
979 Use pI instead of if-then-else-abort. Use %p to avoid casts,
980 avoiding the 0 flag, which is not portable.
981 * process.c (Fmake_network_process): Use pI to avoid cast.
982 * region-cache.c (pp_cache): Likewise.
983 * xdisp.c (decode_mode_spec): Likewise.
984 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
985 behavior on 64-bit hosts with printf arg.
986 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
987 (x_stop_queuing_selection_requests): Likewise.
988 (x_get_window_property): Don't truncate byte count to an 'int'
989 when tracing.
990
991 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
992 here, since it parses constructs like leading '-' and spaces,
993 which are not wanted; and it overflows with large numbers.
994 Instead, simply match F[0-9]+, which is what is wanted anyway.
995
996 * alloc.c: Remove unportable assumptions about struct layout.
997 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
998 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
999 (allocate_vectorlike, make_pure_vector): Use the new macros,
1000 plus offsetof, to remove unportable assumptions about struct layout.
1001 These assumptions hold on all porting targets that I know of, but
1002 they are not guaranteed, they're easy to remove, and removing them
1003 makes further changes easier.
1004
1005 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1006 This doesn't fix a bug but makes the code clearer.
1007 (string_overrun_cookie): Now const. Use initializers that
1008 don't formally overflow signed char, to avoid warnings.
1009 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1010 can cause Emacs to crash when string overrun checking is enabled.
1011 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1012 multiple of sizeof (EMACS_INT); it need not be, if
1013 alignof(EMACS_INT) < sizeof (EMACS_INT).
1014 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1015
1016 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1017
1018 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1019
1020 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1021
1022 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1023 supposed to be handshaking. (Bug#8556)
1024 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1025
1026 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1027
1028 * lisp.h (Qdebug): List symbol.
1029 * eval.c (Qdebug): Restore global linkage.
1030 * keyboard.c (debug-on-event): New variable.
1031 (handle_user_signal): Break into debugger when debug-on-event
1032 matches the current signal symbol.
1033
1034 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1035
1036 * alloc.c (check_sblock, check_string_bytes)
1037 (check_string_free_list): Convert to standard C.
1038
1039 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1040
1041 * w32.c (emacs_gnutls_push): Fix typo.
1042
1043 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1044
1045 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1046 "cast to pointer from integer of different size".
1047
1048 Improve doprnt and its use in verror. (Bug#8545)
1049 * doprnt.c (doprnt): Document the set of format control sequences
1050 supported by the function. Use SAFE_ALLOCA instead of always
1051 using `alloca'.
1052
1053 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1054 is one byte too soon. Don't use xrealloc; instead xfree and
1055 xmalloc anew.
1056
1057 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1058
1059 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1060 callbacks stage.
1061
1062 * gnutls.c: Renamed global_initialized to
1063 gnutls_global_initialized. Added internals for the
1064 :verify-hostname-error, :verify-error, and :verify-flags
1065 parameters of `gnutls-boot' and documented those parameters in the
1066 docstring. Start callback support.
1067 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1068 unless a fatal error occured. Call gnutls_alert_send_appropriate
1069 on error. Return error code.
1070 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1071 (emacs_gnutls_read): Likewise.
1072 (Fgnutls_boot): Return handshake error code.
1073 (emacs_gnutls_handle_error): New function.
1074 (wsaerror_to_errno): Likewise.
1075
1076 * w32.h (emacs_gnutls_pull): Add prototype.
1077 (emacs_gnutls_push): Likewise.
1078
1079 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1080 (emacs_gnutls_push): Likewise.
1081
1082 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1083
1084 * process.c (wait_reading_process_output): Check if GnuTLS
1085 buffered some data internally if no FDs are set for TLS
1086 connections.
1087
1088 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1089 (LIBS): Link to USER_LIBS.
1090 ($(BLD)/gnutls.$(0)): New target.
1091
1092 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1093
1094 * xdisp.c (handle_single_display_spec): Rename the
1095 display_replaced_before_p argument into display_replaced_p, to
1096 make it consistent with the commentary. Fix typos in the
1097 commentary.
1098
1099 * textprop.c (syms_of_textprop): Remove dead code.
1100 (copy_text_properties): Delete obsolete commentary about an
1101 interface that was deleted long ago. Fix typos in the description
1102 of arguments.
1103
1104 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1105 to changes in oldXMenu/XMenu.h from 2011-04-16.
1106 <menu_help_message, prev_menu_help_message>: Constify.
1107 (IT_menu_make_room): menu->help_text is now `const char **';
1108 adjust.
1109
1110 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1111 to changes in oldXMenu/XMenu.h from 2011-04-16.
1112 (struct XMenu): Declare `help_text' `const char **'.
1113
1114 * xfaces.c <Qunspecified>: Make extern again.
1115
1116 * syntax.c: Include sys/types.h before including regex.h, as
1117 required by Posix.
1118
1119 * doc.c (get_doc_string): Improve the format passed to `error'.
1120
1121 * doprnt.c (doprnt): Improve commentary.
1122
1123 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1124
1125 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1126 them with etags.
1127
1128 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1129 changes in globals.h immediately force recompilation.
1130 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1131 $(CURDIR)/s/ms-w32.h.
1132 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1133
1134 * character.c (Fchar_direction): Function deleted.
1135 (syms_of_character): Don't defsubr it.
1136 <char-direction-table>: Deleted.
1137
1138 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1139
1140 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1141 * doprnt.c: Include limits.h.
1142 (SIZE_MAX): New macro.
1143 (doprnt): Return a size_t value. 2nd arg is now size_t.
1144 Many local variables are now size_t instead of int or unsigned.
1145 Improve overflow protection. Support `l' modifier for integer
1146 conversions. Support %l conversion. Don't assume an EMACS_INT
1147 argument for integer conversions and for %c.
1148
1149 * lisp.h (doprnt): Restore prototype.
1150
1151 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1152 $(SRC)/character.h.
1153
1154 * Makefile.in (base_obj): Add back doprnt.o.
1155
1156 * deps.mk (doprnt.o): Add back prerequisites.
1157 (callint.o): Depend on character.h.
1158
1159 * eval.c (internal_lisp_condition_case): Include the handler
1160 representation in the error message.
1161 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1162 when breaking from the loop.
1163
1164 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1165
1166 * callint.c (Fcall_interactively): When displaying error message
1167 about invalid control letter, pass the character's codepoint, not
1168 a pointer to its multibyte form. Improve display of the character
1169 in octal and display also its hex code.
1170
1171 * character.c (char_string): Use %x to display the (unsigned)
1172 codepoint of an invalid character, to avoid displaying a bogus
1173 negative value.
1174
1175 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1176 `error', not SYMBOL_NAME itself.
1177
1178 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1179 character arguments to `error'.
1180
1181 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1182 to `error' in error message about FINAL_CHAR argument. Make sure
1183 FINAL_CHAR is a character, and use %c when it is passed as
1184 argument to `error'.
1185
1186 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1187
1188 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1189
1190 * w32.c: Include <time.h>.
1191 (sys_localtime): New function.
1192
1193 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1194
1195 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1196
1197 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1198
1199 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1200
1201 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1202 zombies (Bug#8467).
1203
1204 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1205
1206 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1207 gl_state.e_property when gl_state.object is Qt.
1208
1209 * insdel.c (make_gap_larger): Remove limitation of buffer size
1210 to <= INT_MAX.
1211
1212 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1213
1214 * xdisp.c (lookup_glyphless_char_display)
1215 (produce_glyphless_glyph): Handle cons cell entry in
1216 glyphless-char-display.
1217 (Vglyphless_char_display): Document it.
1218
1219 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1220 glyphless-char-display.
1221
1222 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1223
1224 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1225
1226 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1227
1228 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1229 definition for no-X builds.
1230
1231 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1232
1233 Static checks with GCC 4.6.0 and non-default toolkits.
1234
1235 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1236
1237 * process.c (keyboard_bit_set): Define only if SIGIO.
1238 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1239 (send_process): Repair possible setjmp clobbering.
1240
1241 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1242
1243 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1244
1245 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1246
1247 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1248 Define only if needed.
1249
1250 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1251 by pacifying GCC about it. Maybe it's time to retire it?
1252 * xfaces.c (USG, __TIMEVAL__): Likewise.
1253
1254 * dispextern.h (struct redisplay_interface): Rename param
1255 to avoid shadowing.
1256 * termhooks.h (struct terminal): Likewise.
1257 * xterm.c (xembed_send_message): Likewise.
1258
1259 * insdel.c (make_gap_smaller): Define only if
1260 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1261
1262 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1263 it.
1264
1265 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1266 so that we aren't warned about unused symbols.
1267
1268 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1269
1270 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1271
1272 * xfns.c (x_real_positions): Mark locals as initialized.
1273
1274 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1275
1276 * xterm.c: Fix problems found by static analysis with other toolkits.
1277 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1278 (x_dispatch_event): Declare static if USE_GTK, and
1279 define if USE_GTK || USE_X_TOOLKIT.
1280 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1281 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1282 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1283 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1284
1285 * xmenu.c (menu_help_callback): Pointer type fixes.
1286 Use const pointers when pointing at readonly data. Avoid pointer
1287 signedness clashes.
1288 (FALSE): Remove unused macro.
1289 (update_frame_menubar): Remove unused decl.
1290
1291 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1292
1293 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1294 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1295 (single_menu_item): Rename local to avoid shadowing.
1296
1297 * keyboard.c (make_lispy_event): Remove unused local var.
1298
1299 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1300 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1301
1302 * bitmaps: Change bitmaps from unsigned char back to the X11
1303 compatible char. Avoid the old compiler warnings about
1304 out-of-range initializers by using, for example, '\xab' rather
1305 than 0xab.
1306
1307 * xgselect.c (xgselect_initialize): Check vs interface
1308 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1309
1310 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1311
1312 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1313 to read-only memory.
1314
1315 * fns.c (vector): Remove; this old hack is no longer needed.
1316
1317 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1318 Remove unused var.
1319 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1320
1321 * xrdb.c (x_load_resources): Omit unused local.
1322
1323 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1324 (x_window): Rename locals to avoid shadowing.
1325 (USG): Use the kludged USG macro, to pacify gcc.
1326
1327 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1328 (x_term_init): Remove local to avoid shadowing.
1329
1330 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1331
1332 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1333 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1334
1335 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1336
1337 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1338
1339 Fix regex.c, syntax.c and friends for buffers > 2GB.
1340 * syntax.h (struct gl_state_s): Declare character position members
1341 EMACS_INT.
1342
1343 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1344
1345 * textprop.c (verify_interval_modification, interval_of):
1346 Declare arguments EMACS_INT.
1347
1348 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1349 EMACS_INT.
1350
1351 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1352
1353 * indent.c (Fvertical_motion): Local variable it_start is now
1354 EMACS_INT.
1355
1356 * regex.c (re_match, re_match_2, re_match_2_internal)
1357 (bcmp_translate, regcomp, regexec, print_double_string)
1358 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1359 (re_compile_pattern, re_exec): Declare arguments and local
1360 variables `size_t' and `ssize_t' and return values `regoff_t', as
1361 appropriate.
1362 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1363 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1364 <compile_stack_type>: `size' and `avail' are now `size_t'.
1365
1366 * regex.h <regoff_t>: Use ssize_t, not int.
1367 (re_search, re_search_2, re_match, re_match_2): Arguments that
1368 specify buffer/string position and length are now ssize_t and
1369 size_t. Return type is regoff_t.
1370
1371 2011-04-16 Ben Key <bkey76@gmail.com>
1372
1373 * nsfont.m: Fixed bugs in ns_get_family and
1374 ns_descriptor_to_entity that were caused by using free to
1375 deallocate memory blocks that were allocated by xmalloc (via
1376 xstrdup). This caused Emacs to crash when compiled with
1377 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1378 --enable-checking=xmallocoverrun). xfree is now used to
1379 deallocate these memory blocks.
1380
1381 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1382
1383 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1384
1385 emacs_write: Accept and return EMACS_INT for sizes.
1386 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1387 et seq.
1388 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1389 Accept and return EMACS_INT.
1390 (emacs_gnutls_write): Return the number of bytes written on
1391 partial writes.
1392 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1393 (emacs_read, emacs_write): Remove check for negative size, as the
1394 Emacs source code has been audited now.
1395 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1396 (emacs_read, emacs_write): Use it.
1397 * process.c (send_process): Adjust to the new signatures of
1398 emacs_write and emacs_gnutls_write. Do not attempt to store
1399 a byte offset into an 'int'; it might overflow.
1400 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1401
1402 * sound.c: Don't assume sizes fit in 'int'.
1403 (struct sound_device.period_size, alsa_period_size):
1404 Return EMACS_INT, not int.
1405 (struct sound_device.write, vox_write, alsa_write):
1406 Accept EMACS_INT, not int.
1407 (wav_play, au_play): Use EMACS_INT to store sizes and to
1408 record read return values.
1409
1410 2011-04-15 Ben Key <bkey76@gmail.com>
1411
1412 * keyboard.c (Qundefined): Don't declare static since it is used
1413 in nsfns.m.
1414 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1415 static since they are used in nsfont.m.
1416
1417 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1418
1419 * process.c (Qprocessp): Don't declare static.
1420 * lisp.h (Qprocessp): Declare again.
1421
1422 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1423
1424 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1425
1426 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1427
1428 Improve C-level modularity by making more things 'static'.
1429
1430 Don't publish debugger-only interfaces to other modules.
1431 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1432 (verify_bytepos, count_markers): Move decls to the only modules
1433 that need them.
1434 * region-cache.h (pp_cache): Likewise.
1435 * window.h (check_all_windows): Likewise.
1436 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1437
1438 * sysdep.c (croak): Now static, if
1439 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1440 * syssignal.h (croak): Declare only if not static.
1441
1442 * alloc.c (refill_memory_reserve): Now static if
1443 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1444 * lisp.h (refill_memory_reserve): Declare only if not static.
1445
1446 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1447 Define only if USE_LUCID.
1448
1449 * xrdb.c (x_customization_string, x_rm_string): Now static.
1450
1451 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1452 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1453
1454 * xdisp.c (draw_row_with_mouse_face): Now static.
1455 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1456
1457 * window.h (check_all_windows): Mark externally visible.
1458
1459 * window.c (window_deletion_count): Now static.
1460
1461 * undo.c: Make symbols static if they're not exported.
1462 (last_undo_buffer, last_boundary_position, pending_boundary):
1463 Now static.
1464
1465 * textprop.c (interval_insert_behind_hooks): Now static.
1466 (interval_insert_in_front_hooks): Likewise.
1467
1468 * term.c: Make symbols static if they're not exported.
1469 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1470 (max_frame_lines, tty_set_terminal_modes):
1471 (tty_reset_terminal_modes, tty_turn_off_highlight):
1472 (get_tty_terminal): Now static.
1473 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1474 * termhooks.h (term_mouse_moveto): Do not declare if
1475 HAVE_WINDOW_SYSTEM.
1476 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1477 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1478
1479 * sysdep.c: Make symbols static if they're not exported.
1480 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1481 Now static.
1482 (sigprocmask_set, full_mask): Remove; unused.
1483 (wait_debugging): Mark as visible.
1484 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1485 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1486
1487 * syntax.c (syntax_temp): Define only if !__GNUC__.
1488
1489 * sound.c (current_sound_device, current_sound): Now static.
1490
1491 * search.c (searchbufs, searchbuf_head): Now static.
1492
1493 * scroll.c (scroll_cost): Remove; unused.
1494 * dispextern.h (scroll_cost): Remove decl.
1495
1496 * region-cache.h (pp_cache): Mark as externally visible.
1497
1498 * process.c: Make symbols static if they're not exported.
1499 (process_tick, update_tick, create_process, chan_process):
1500 (Vprocess_alist, proc_buffered_char, datagram_access):
1501 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1502 (deactivate_process): Mark defn as static, as well as decl.
1503 * lisp.h (create_process): Remove decl.
1504 * process.h (chan_process, Vprocess_alist): Remove decls.
1505
1506 * print.c: Make symbols static if they're not exported.
1507 (print_depth, new_backquote_output, being_printed, print_buffer):
1508 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1509 (print_interval, print_number_index, initial_stderr_stream):
1510 Now static.
1511 * lisp.h (Fprinc): Remove decl.
1512 (debug_output_compilation_hack): Mark as externally visible.
1513
1514 * sysdep.c (croak): Move decl from here to syssignal.h.
1515 * syssignal.h (croak): Put it here, so the API can be checked when
1516 'croak' is called from dissociate_if_controlling_tty.
1517
1518 * minibuf.c: Make symbols static if they're not exported.
1519 (minibuf_save_list, choose_minibuf_frame): Now static.
1520 * lisp.h (choose_minibuf_frame): Remove decl.
1521
1522 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1523
1524 * lread.c: Make symbols static if they're not exported.
1525 (read_objects, initial_obarray, oblookup_last_bucket_number):
1526 Now static.
1527 (make_symbol): Remove; unused.
1528 * lisp.h (initial_obarray, make_symbol): Remove decls.
1529
1530 * keyboard.c: Make symbols static if they're not exported.
1531 (single_kboard, recent_keys_index, total_keys, recent_keys):
1532 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1533 (this_single_command_key_start, echoing, last_auto_save):
1534 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1535 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1536 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1537 (Vlispy_mouse_stem, double_click_count):
1538 Now static.
1539 (force_auto_save_soon): Define only if SIGDANGER.
1540 (ignore_mouse_drag_p): Now static if
1541 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1542 (print_help): Remove; unused.
1543 (stop_character, last_timer_event): Mark as externally visible.
1544 * keyboard.h (ignore_mouse_drag_p): Declare only if
1545 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1546 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1547 * lisp.h (echoing): Remove decl.
1548 (force_auto_save_soon): Declare only if SIGDANGER.
1549 * xdisp.c (redisplay_window): Simplify code, to make it more
1550 obvious that ignore_mouse_drag_p is not accessed if !defined
1551 USE_GTK && !defined HAVE_NS.
1552
1553 * intervals.c: Make symbols static if they're not exported.
1554 (merge_properties_sticky, merge_interval_right, delete_interval):
1555 Now static.
1556 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1557
1558 * insdel.c: Make symbols static if they're not exported.
1559 However, leave prepare_to_modify_buffer alone. It's never
1560 called from outside this function, but that appears to be a bug.
1561 (combine_after_change_list, combine_after_change_buffer):
1562 (adjust_after_replace, signal_before_change): Now static.
1563 (adjust_after_replace_noundo): Remove; unused.
1564 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1565 (signal_before_change): Remove decls.
1566
1567 * indent.c (val_compute_motion, val_vmotion): Now static.
1568
1569 * image.c: Make symbols static if they're not exported.
1570 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1571 if USE_GTK.
1572 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1573 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1574
1575 * fringe.c (standard_bitmaps): Now static.
1576 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1577
1578 * frame.c: Make symbols static if they're not exported.
1579 (x_report_frame_params, make_terminal_frame): Now static.
1580 (get_frame_param): Now static, unless HAVE_NS.
1581 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1582 (x_get_resource_string): Remove; not used.
1583 * frame.h (make_terminal_frame, x_report_frame_params):
1584 (x_get_resource_string); Remove decls.
1585 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1586 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1587
1588 * font.c, fontset.c: Make symbols static if they're not exported.
1589 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1590 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1591 * font.c (font_close_object): Now static.
1592 * font.h (font_close_object): Remove.
1593 * fontset.c (FONTSET_OBJLIST): Remove.
1594 (free_realized_fontset) #if-0 the body, which does nothing.
1595 (face_suitable_for_char_p): #if-0, as it's never called.
1596 * fontset.h (face_suitable_for_char_p): Remove decl.
1597 * xfaces.c (face_at_string_position):
1598 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1599 since 0 is always ASCII.
1600
1601 * fns.c (weak_hash_tables): Now static.
1602
1603 * fileio.c: Make symbols static if they're not exported.
1604 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1605 (Vwrite_region_annotation_buffers): Now static.
1606
1607 * eval.c: Make symbols static if they're not exported.
1608 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1609 * lisp.h (backtrace_list): Remove decl.
1610
1611 * emacs.c: Make symbols static if they're not exported.
1612 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1613 (fatal_error_code, fatal_error_signal_hook, standard_args):
1614 Now static.
1615 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1616 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1617 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1618 * lisp.h (fatal_error_signal_hook): Remove decl.
1619 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1620
1621 * editfns.c: Move a (normally-unused) function to its only use.
1622 * editfns.c, lisp.h (get_operating_system_release): Remove.
1623 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1624 worth the hassle of breaking this out.
1625
1626 * xterm.c: Make symbols static if they're not exported.
1627 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1628 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1629 (x_destroy_window, x_delete_display):
1630 Now static.
1631 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1632 (x_mouse_leave): Remove; unused.
1633 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1634 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1635 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1636 Remove decls.
1637 (x_mouse_leave): Declare only if WINDOWSNT.
1638 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1639 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1640 USE_X_TOOLKIT.
1641
1642 * ftxfont.c: Make symbols static if they're not exported.
1643 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1644 HAVE_FREETYPE.
1645 * font.h (ftxfont_driver): Likewise.
1646
1647 * xfns.c: Make symbols static if they're not exported.
1648 (x_last_font_name, x_display_info_for_name):
1649 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1650 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1651 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1652 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1653 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1654 (last_show_tip_args): Now static.
1655 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1656 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1657 (x_screen_planes): Remove; unused.
1658 * dispextern.h (x_screen_planes): Remove decl.
1659
1660 * dispnew.c: Make symbols static if they're not exported.
1661 * dispextern.h (redraw_garbaged_frames, scrolling):
1662 (increment_row_positions): Remove.
1663 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1664 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1665 Now static.
1666 (redraw_garbaged_frames): Remove; unused.
1667
1668 * xfaces.c: Make symbols static if they're not exported.
1669 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1670 Remove decls.
1671 * xterm.h (defined_color): Remove decls.
1672 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1673 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1674 (menu_face_changed_default, defined_color, free_realized_face):
1675 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1676 (ascii_face_of_lisp_face): Remove; unused.
1677
1678 * xdisp.c: Make symbols static if they're not exported.
1679 * dispextern.h (scratch_glyph_row, window_box_edges):
1680 (glyph_to_pixel_coords, set_cursor_from_row):
1681 (get_next_display_element, set_iterator_to_next):
1682 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1683 (show_mouse_face): Remove decls
1684 * frame.h (message_buf_print): Likewise.
1685 * lisp.h (pop_message, set_message, check_point_in_composition):
1686 Likewise.
1687 * xterm.h (set_vertical_scroll_bar): Likewise.
1688 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1689 (message_buf_print, scratch_glyph_row, displayed_buffer):
1690 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1691 (get_next_display_element, show_mouse_face, window_box_edges):
1692 (frame_to_window_pixel_xy, check_point_in_composition):
1693 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1694 (glyph_to_pixel_coords): Remove; unused.
1695
1696 * dired.c (file_name_completion): Now static.
1697
1698 * dbusbind.c (xd_in_read_queued_messages): Now static.
1699
1700 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1701 * data.c (circular_list_error): Remove.
1702
1703 * commands.h (last_point_position, last_point_position_buffer):
1704 (last_point_position_window): Remove decls.
1705 * keyboard.c: Make these variables static.
1706
1707 * coding.h (coding, code_convert_region, encode_coding_gap):
1708 Remove decls.
1709 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1710 (iso_code_class, detect_coding, code_convert_region): Now static.
1711 (encode_coding_gap): Remove; unused.
1712
1713 * chartab.c (chartab_chars, chartab_bits): Now static.
1714
1715 * charset.h (charset_iso_8859_1): Remove decl.
1716 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1717 Now static.
1718
1719 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1720 * ccl.c (Vccl_program_table): Now static.
1721 (check_ccl_update): Remove; unused.
1722
1723 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1724 * category.h: ... from here.
1725 * category.c (check_category_table, set_category_set): Now static.
1726
1727 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1728 * lisp.h: Remove these decls.
1729
1730 * buffer.c (buffer_count): Remove unused var.
1731
1732 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1733 so that it's not optimized away.
1734 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1735 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1736 exported only to the debugger.
1737
1738 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1739 * atimer.h (run_all_atimers): Remove; not exported.
1740
1741 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1742 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1743 was inaccessible from Lisp.
1744 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1745 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1746
1747 alloc.c: Import and export fewer symbols, and remove unused items.
1748 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1749 is defined.
1750 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1751 it's not optimized away by whole-program optimization.
1752 (message_enable_multibyte, free_misc): Remove.
1753 (catchlist, handlerlist, mark_backtrace):
1754 Declare only if BYTE_MARK_STACK.
1755 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1756 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1757 (message_enable_multibyte): Remove decl.
1758 (free_misc, interval_free_list, float_block, float_block_index):
1759 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1760 (cons_free_list, last_marked_index):
1761 Now static.
1762 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1763 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1764 (mark_backtrace): Define only if BYTE_MARK_STACK.
1765 * xdisp.c (message_enable_multibyte): Now static.
1766
1767 Declare Lisp_Object Q* variables to be 'static' if not exported.
1768 This makes it easier for human readers (and static analyzers)
1769 to see whether these variables are used from other modules.
1770 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1771 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1772 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1773 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1774 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1775 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1776 * xmenu.c, xselect.c:
1777 Declare Q* vars static if they are not used in other modules.
1778 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1779 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1780 Remove decls of unexported vars.
1781 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1782
1783 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1784
1785 Make Emacs functions such as Fatom 'static' by default.
1786 This makes it easier for human readers (and static analyzers)
1787 to see whether these functions can be called from other modules.
1788 DEFUN now defines a static function. To make the function external
1789 so that it can be used in other C modules, use the new macro DEFUE.
1790 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1791 (Finit_image_library):
1792 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1793 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1794 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1795 Remove decls, since these functions are now static.
1796 (Funintern, Fget_internal_run_time): New decls, since these functions
1797 were already external.
1798
1799 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1800 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1801 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1802 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1803 * keyboard.c, keymap.c, lread.c:
1804 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1805 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1806 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1807 Mark functions with DEFUE instead of DEFUN,
1808 if they are used in other modules.
1809 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1810 decls for now-static functions.
1811 * buffer.h (Fdelete_overlay): Remove decl.
1812 * callproc.c (Fgetenv_internal): Mark as internal.
1813 * composite.c (Fremove_list_of_text_properties): Remove decl.
1814 (Fcomposition_get_gstring): New forward static decl.
1815 * composite.h (Fcomposite_get_gstring): Remove decl.
1816 * dired.c (Ffile_attributes): New forward static decl.
1817 * doc.c (Fdocumntation_property): New forward static decl.
1818 * eval.c (Ffetch_bytecode): New forward static decl.
1819 (Funintern): Remove extern decl; now in .h file where it belongs.
1820 * fileio.c (Fmake_symbolic_link): New forward static decl.
1821 * image.c (Finit_image_library): New forward static decl.
1822 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1823 * intervals.h (Fprevious_property_change):
1824 (Fremove_list_of_text_properties): Remove decls.
1825 * keyboard.c (Fthis_command_keys): Remove decl.
1826 (Fcommand_execute): New forward static decl.
1827 * keymap.c (Flookup_key): New forward static decl.
1828 (Fcopy_keymap): Now static.
1829 * keymap.h (Flookup_key): Remove decl.
1830 * process.c (Fget_process): New forward static decl.
1831 (Fprocess_datagram_address): Mark as internal.
1832 * syntax.c (Fsyntax_table_p): New forward static decl.
1833 (skip_chars): Remove duplicate decl.
1834 * textprop.c (Fprevious_property_change): New forward static decl.
1835 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1836 Now internal.
1837 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1838 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1839
1840 * editfns.c (Fformat): Remove unreachable code.
1841
1842 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1843
1844 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1845 change. (Bug#8496)
1846
1847 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1848
1849 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1850 when at ZV. (Bug#8487)
1851
1852 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1853
1854 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1855 (Bug#8437)
1856 * keyboard.c (parse_tool_bar_item): Likewise.
1857 * sound.c (sound_cleanup, alsa_close): Likewise.
1858 * termcap.c (tgetent): Likewise.
1859 * xfns.c (x_default_font_parameter): Likewise.
1860 * xsettings.c (read_and_apply_settings): Likewise.
1861
1862 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1863 (overrun_check_free): Protoize.
1864
1865 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1868 since callers should never pass a negative size.
1869 Change the signature to match that of plain 'read' and 'write'; see
1870 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1871 * lisp.h: Update prototypes of emacs_write and emacs_read.
1872
1873 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1874
1875 * xdisp.c (redisplay_window): Don't try to determine the character
1876 position of the scroll margin if the window start point w->startp
1877 is outside the buffer's accessible region. (Bug#8468)
1878
1879 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1880
1881 Fix write-region and its subroutines for buffers > 2GB.
1882 * fileio.c (a_write, e_write): Modify declaration of arguments and
1883 local variables to support buffers larger than 2GB.
1884 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1885
1886 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1887 argument, local variables, and return value.
1888
1889 * lisp.h: Update prototypes of emacs_write and emacs_read.
1890
1891 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1892
1893 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1894
1895 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1896
1897 Fix more problems found by GCC 4.6.0's static checks.
1898
1899 * xdisp.c (vmessage): Use a better test for character truncation.
1900
1901 * charset.c (load_charset_map): <, not <=, for optimization,
1902 and to avoid potential problems with integer overflow.
1903 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1904 * casetab.c (set_identity, shuffle): Likewise.
1905 * editfns.c (Fformat): Likewise.
1906 * syntax.c (skip_chars): Likewise.
1907
1908 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1909 This also lets GCC 4.6.0 generate slightly better loop code.
1910
1911 * callint.c (Fcall_interactively): <, not <=, for optimization.
1912 (Fcall_interactively): Count the number of arguments produced,
1913 not the number of arguments given. This is simpler and lets GCC
1914 4.6.0 generate slightly better code.
1915
1916 * ftfont.c: Distingish more carefully between FcChar8 and char.
1917 The previous code passed unsigned char * to a functions like
1918 strlen and xstrcasecmp that expect char *, which does not
1919 conform to the C standard.
1920 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1921 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1922 char * when the C standard requires it.
1923
1924 * keyboard.c (read_char): Remove unused var.
1925
1926 * eval.c: Port to Windows vsnprintf (Bug#8435).
1927 Include <limits.h>.
1928 (SIZE_MAX): Define if the headers do not.
1929 (verror): Do not give up if vsnprintf returns a negative count.
1930 Instead, grow the buffer. This ports to Windows vsnprintf, which
1931 does not conform to C99. Problem reported by Eli Zaretskii.
1932 Also, simplify the allocation scheme, by avoiding the need for
1933 calling realloc, and removing the ALLOCATED variable.
1934
1935 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1936
1937 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1938 But keep the doprint source code for now, as we might revamp it
1939 and use it again (Bug#8435).
1940 * lisp.h (doprnt): Remove.
1941 * Makefile.in (base_obj): Remove doprnt.o.
1942 * deps.mk (doprnt.o): Remove.
1943
1944 error: Print 32- and 64-bit integers portably (Bug#8435).
1945 Without this change, on typical 64-bit hosts error ("...%d...", N)
1946 was used to print both 32- and 64-bit integers N, which relied on
1947 undefined behavior.
1948 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1949 New macro.
1950 * lisp.h (error, verror): Mark as printf-like functions.
1951 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1952 Report overflow in size calculations when allocating printf buffer.
1953 Do not truncate output string at its first null byte.
1954 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1955 Truncate the output at a character boundary, since vsnprintf does not
1956 do that.
1957 * charset.c (check_iso_charset_parameter): Convert internal
1958 character to string before calling 'error', since %c now has the
1959 printf meaning.
1960 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1961 overflow when computing char to be passed to 'error'. Do not
1962 pass Lisp_Object to 'error'; pass the integer instead.
1963 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1964 formatted with plain %d.
1965
1966 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1967
1968 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1969
1970 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1971
1972 * xterm.c (x_catch_errors): Remove duplicate declaration.
1973
1974 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1975
1976 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1977
1978 2011-04-10 Jim Meyering <meyering@redhat.com>
1979
1980 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1981 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1982 return ssize_t not "int", and use size_t as the buffer length.
1983 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1984 * gnutls.h: Update declarations.
1985 * process.c (read_process_output): Use ssize_t, to match.
1986 (send_process): Likewise.
1987
1988 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1989
1990 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1991
1992 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1993
1994 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1995 Use unsigned char, to match FcChar8 type definition.
1996
1997 * xterm.c (handle_one_xevent):
1998 * xmenu.c (create_and_show_popup_menu):
1999 * xselect.c (x_decline_selection_request)
2000 (x_reply_selection_request): Avoid type-punned deref of X events.
2001
2002 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2003
2004 Fix some uses of `int' instead of EMACS_INT.
2005 * search.c (string_match_1, fast_string_match)
2006 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2007 (scan_buffer, find_next_newline_no_quit)
2008 (find_before_next_newline, search_command, Freplace_match)
2009 (Fmatch_data): Make some `int' variables be EMACS_INT.
2010
2011 * xdisp.c (display_count_lines): 3rd argument and return value now
2012 EMACS_INT. All callers changed.
2013 (pint2hrstr): Last argument is now EMACS_INT.
2014
2015 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2016 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2017 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2018 (decode_coding_utf_16, decode_coding_emacs_mule)
2019 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2020 (decode_coding_ccl, decode_coding_charset)
2021 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2022 (decode_coding_iso_2022, decode_coding_emacs_mule)
2023 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2024 <char_offset, last_offset>: Declare EMACS_INT.
2025 (encode_coding_utf_8, encode_coding_utf_16)
2026 (encode_coding_emacs_mule, encode_invocation_designation)
2027 (encode_designation_at_bol, encode_coding_iso_2022)
2028 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2029 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2030 Declare EMACS_INT.
2031 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2032 (encode_invocation_designation): Last argument P_NCHARS is now
2033 EMACS_INT.
2034 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2035 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2036
2037 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2038 All users changed.
2039
2040 * ccl.c (Fccl_execute_on_string): Declare some variables
2041 EMACS_INT.
2042
2043 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2044
2045 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2046
2047 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2048
2049 * process.c (Fformat_network_address): Doc fix.
2050
2051 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2052
2053 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2054
2055 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2056
2057 * keyboard.c (read_char): Call Lisp function help-form-show,
2058 instead of using internal_with_output_to_temp_buffer.
2059 (Qhelp_form_show): New var.
2060 (syms_of_keyboard): Use DEFSYM macro.
2061
2062 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2063
2064 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2065
2066 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2067
2068 * process.c (Flist_processes): Remove to Lisp.
2069 (list_processes_1): Delete.
2070
2071 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2072
2073 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2074
2075 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2076
2077 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2078
2079 Fix more problems found by GCC 4.6.0's static checks.
2080
2081 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2082
2083 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2084
2085 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2086
2087 * xdisp.c (vmessage): Mark as a printf-like function.
2088
2089 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2090
2091 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2092
2093 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2094 printf-like functions.
2095 (tiff_load): Add casts to remove these marks before passing them
2096 to system-supplied API.
2097
2098 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2099
2100 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2101 This avoids several warnings with gcc -Wstrict-overflow.
2102 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2103 directly, rather than having caller test rule sign. This avoids
2104 some unnecessary tests.
2105 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2106 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2107 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2108
2109 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2110 (xfont_open): Avoid unnecessary tests.
2111
2112 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2113
2114 * composite.h, composite.c (composition_gstring_put_cache):
2115 Use EMACS_INT, not int, for length.
2116
2117 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2118 breaking out part of COMPOSITION_DECODE_RULE.
2119 (COMPOSITION_DECODE_RULE): Use it.
2120 * composite.c (get_composition_id): Remove unused local vars,
2121 by using the new macro.
2122
2123 * textprop.c (set_text_properties_1): Change while to do-while,
2124 since the condition is always true at first.
2125
2126 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2127 (interval_deletion_adjustment): Return unsigned value.
2128 All uses changed.
2129
2130 * process.c (list_processes_1, create_pty, read_process_output):
2131 (exec_sentinel): Remove vars that were set but not used.
2132 (create_pty): Remove unnecessary "volatile"s.
2133 (Fnetwork_interface_info): Avoid possibility of int overflow.
2134 (read_process_output): Do adaptive read buffering even if carryover.
2135 (read_process_output): Simplify nbytes computation if buffered.
2136
2137 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2138
2139 * syntax.c (scan_words): Remove var that was set but not used.
2140 (update_syntax_table): Use unsigned instead of int.
2141
2142 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2143 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2144 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2145
2146 * print.c (print_error_message): Avoid int overflow.
2147
2148 * font.c (font_list_entities): Redo for clarity,
2149 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2150
2151 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2152 (font_score): Avoid potential overflow in diff calculation.
2153
2154 * fns.c (substring_both): Remove var that is set but not used.
2155 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2156
2157 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2158
2159 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2160 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2161 can always succeed if overflow has undefined behavior.
2162
2163 * search.c (boyer_moore, wordify): Remove vars set but not used.
2164 (wordify): Omit three unnecessary tests.
2165
2166 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2167 All callers changed. This avoids the need for an unused var.
2168
2169 * casefiddle.c (casify_region): Remove var that is set but not used.
2170
2171 * dired.c (file_name_completion): Remove var that is set but not used.
2172
2173 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2174
2175 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2176 (Finsert_file_contents): Remove unnecessary code checking fd.
2177
2178 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2179 Check for integer overflow on size calculations.
2180
2181 * buffer.c (Fprevious_overlay_change): Remove var that is set
2182 but not used.
2183
2184 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2185 Remove vars that are set but not used.
2186 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2187 (timer_check_2): Mark vars as initialized.
2188
2189 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2190
2191 * image.c (lookup_image): Remove var that is set but not used.
2192 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2193
2194 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2195 that are set but not used.
2196
2197 * xfns.c (make_invisible_cursor): Don't return garbage
2198 if XCreateBitmapFromData fails (Bug#8410).
2199
2200 * xselect.c (x_get_local_selection, x_handle_property_notify):
2201 Remove vars that are set but not used.
2202
2203 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2204 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2205
2206 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2207 Remove var that is set but not used.
2208 (scroll_bar_windows_size): Now size_t, not int.
2209 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2210 Check for overflow.
2211
2212 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2213 (map_tty_color) [!defined MSDOS]: Likewise.
2214
2215 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2216
2217 * coding.c: Remove vars that are set but not used.
2218 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2219 All callers changed.
2220 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2221 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2222 (decode_coding_charset): Remove vars that are set but not used.
2223
2224 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2225 that is set but not used.
2226
2227 * print.c (print_object): Remove var that is set but not used.
2228
2229 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2230 The gnulib version avoids calling malloc in the usual case,
2231 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2232 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2233 * filelock.c (current_lock_owner): Likewise.
2234 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2235 * sysdep.c: Include allocator.h, careadlinkat.h.
2236 (emacs_no_realloc_allocator): New static constant.
2237 (emacs_readlink): New function.
2238 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2239 ../lib/careadlinkat.h.
2240
2241 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2242
2243 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2244 first non-nil return value).
2245
2246 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2247
2248 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2249 if not defined (Bug#8403).
2250
2251 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2252
2253 * xdisp.c (display_count_lines): Remove parameter `start',
2254 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2255 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2256 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2257 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2258 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2259 and thereabouts. All callers changed.
2260 (get_per_char_metric): Remove parameter `f', unused since
2261 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2262
2263 2011-04-02 Jim Meyering <meyering@redhat.com>
2264
2265 do not dereference NULL upon failed strdup
2266 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2267 (ns_get_family): Likewise.
2268
2269 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2270
2271 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2272
2273 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2274
2275 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2276 later (Bug#8403).
2277
2278 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2279
2280 Add lexical binding.
2281
2282 * window.c (Ftemp_output_buffer_show): New fun.
2283 (Fsave_window_excursion):
2284 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2285
2286 * lread.c (lisp_file_lexically_bound_p): New function.
2287 (Fload): Bind Qlexical_binding.
2288 (readevalloop): Remove `evalfun' arg.
2289 Bind Qinternal_interpreter_environment.
2290 (Feval_buffer): Bind Qlexical_binding.
2291 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2292 Mark as dynamic.
2293 (syms_of_lread): Declare `lexical-binding'.
2294
2295 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2296
2297 * keyboard.c (eval_dyn): New fun.
2298 (menu_item_eval_property): Use it.
2299
2300 * image.c (parse_image_spec): Use Ffunctionp.
2301
2302 * fns.c (concat, mapcar1): Accept byte-code-functions.
2303
2304 * eval.c (Fsetq): Handle lexical vars.
2305 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2306 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2307 (FletX, Flet): Obey lexical binding.
2308 (Fcommandp): Handle closures.
2309 (Feval): New `lexical' arg.
2310 (eval_sub): New function extracted from Feval. Use it almost
2311 everywhere where Feval was used. Look up vars in lexical env.
2312 Handle closures.
2313 (Ffunctionp): Move from subr.el.
2314 (Ffuncall): Handle closures.
2315 (apply_lambda): Remove `eval_flags'.
2316 (funcall_lambda): Handle closures and new byte-code-functions.
2317 (Fspecial_variable_p): New function.
2318 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2319 but without exporting it to Lisp.
2320
2321 * doc.c (Fdocumentation, store_function_docstring):
2322 * data.c (Finteractive_form): Handle closures.
2323
2324 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2325 interactive spec.
2326
2327 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2328 New byte-codes.
2329 (exec_byte_code): New function extracted from Fbyte_code to handle new
2330 calling convention for byte-code-functions. Add new byte-codes.
2331
2332 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2333
2334 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2335
2336 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2337
2338 * xdisp.c (redisplay_internal): Fix prototype.
2339
2340 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2341
2342 * xdisp.c (SCROLL_LIMIT): New macro.
2343 (try_scrolling): Use it when setting scroll_limit.
2344 Limit scrolling to 100 screen lines.
2345 (redisplay_window): Even when falling back on "recentering",
2346 position point in the window according to scroll-conservatively,
2347 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2348
2349 (try_scrolling): When point is above the window, allow searching
2350 as far as scroll_max, or one screenful, to compute vertical
2351 distance from PT to the scroll margin position. This prevents
2352 try_scrolling from unnecessarily failing when
2353 scroll-conservatively is set to a value slightly larger than the
2354 window height. Clean up the case of PT below the margin at bottom
2355 of window: scroll_max can no longer be INT_MAX. When aggressive
2356 scrolling is in use, don't let point enter the opposite scroll
2357 margin as result of the scroll.
2358 (syms_of_xdisp) <scroll-conservatively>: Document the
2359 threshold of 100 lines for never-recentering scrolling.
2360
2361 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2362
2363 * dispextern.h (move_it_by_lines):
2364 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2365 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2366 (message_log_check_duplicate): Remove parameters `prev_bol' and
2367 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2368 (redisplay_internal): Remove parameter `preserve_echo_area',
2369 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2370
2371 * indent.c (Fvertical_motion):
2372 * window.c (window_scroll_pixel_based, Frecenter):
2373 Don't pass `need_y_p' to `move_it_by_lines'.
2374
2375 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2376
2377 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2378 steal a few bits to be more compact.
2379 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2380 Remove unneeded casts.
2381
2382 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2383
2384 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2385
2386 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2387 binding" message (bug#7967).
2388
2389 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2390
2391 Fix more problems found by GCC 4.6.0's static checks.
2392
2393 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2394 Remove unused local var.
2395
2396 * editfns.c (Fmessage_box): Remove unused local var.
2397
2398 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2399 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2400 Omit unused local vars.
2401 * window.c (shrink_windows): Omit unused local var.
2402 * menu.c (digest_single_submenu): Omit unused local var.
2403 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2404 Omit unused local var.
2405
2406 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2407 Don't assume string length fits in int.
2408 (keyremap_step, read_key_sequence): Use size_t for sizes.
2409 (read_key_sequence): Don't check last_real_key_start redundantly.
2410
2411 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2412 instead of alloca (Bug#8344).
2413
2414 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2415 (Fbacktrace_frame): Don't assume nframes fits in int.
2416
2417 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2418
2419 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2420 concerns.
2421
2422 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2423
2424 * cm.c (calccost): Turn while-do into do-while, for clarity.
2425
2426 * keyboard.c (syms_of_keyboard): Use the same style as later
2427 in this function when indexing through an array. This also
2428 works around GCC bug 48267.
2429
2430 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2431
2432 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2433
2434 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2435 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2436
2437 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2438 This avoids undefined behavior on integer overflow, and is a bit
2439 more convenient anyway since it is compared to a size_t variable.
2440
2441 Variadic C functions now count arguments with size_t, not int.
2442 This avoids an unnecessary limitation on 64-bit machines, which
2443 caused (substring ...) to crash on large vectors (Bug#8344).
2444 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2445 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2446 All variadic functions and their callers changed accordingly.
2447 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2448 * data.c (arith_driver, float_arith_driver): Likewise.
2449 * editfns.c (general_insert_function): Likewise.
2450 * eval.c (struct backtrace.nargs, interactive_p)
2451 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2452 (funcall_lambda, mark_backtrace): Likewise.
2453 * fns.c (concat): Likewise.
2454 * frame.c (x_set_frame_parameters): Likewise.
2455 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2456 0 if not found, not -1. All callers changed.
2457
2458 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2459 (stack_copy_size): Now size_t, not int.
2460 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2461
2462 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2463
2464 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2465 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2466 All callers changed.
2467
2468 * lisp.h (multibyte_char_to_unibyte):
2469 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2470 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2471 * character.h (CHAR_TO_BYTE8):
2472 * cmds.c (internal_self_insert):
2473 * editfns.c (general_insert_function):
2474 * keymap.c (push_key_description):
2475 * search.c (Freplace_match):
2476 * xdisp.c (message_dolog, set_message_1): All callers changed.
2477
2478 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2479
2480 * keyboard.c (safe_run_hook_funcall): New function.
2481 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2482 don't set the hook to nil, but remove the offending function instead.
2483 (Qcommand_hook_internal): Remove, unused.
2484 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2485 Vcommand_hook_internal.
2486
2487 * eval.c (enum run_hooks_condition): Remove.
2488 (funcall_nil, funcall_not): New functions.
2489 (run_hook_with_args): Call each function through a `funcall' argument.
2490 Remove `cond' argument, now redundant.
2491 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2492 (Frun_hook_with_args_until_failure): Adjust accordingly.
2493 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2494
2495 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2496
2497 * dispextern.h (string_buffer_position): Remove declaration.
2498
2499 * print.c (strout): Remove parameter `multibyte', unused since
2500 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2501
2502 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2503 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2504 All callers changed.
2505
2506 * w32.c (_wsa_errlist): Use braces for struct initializers.
2507
2508 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2509 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2510 All callers changed.
2511 (string_buffer_position): Likewise. Also, make static (it's never
2512 used outside xdisp.c).
2513 (cursor_row_p): Remove parameter `w', unused since
2514 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2515 (decode_mode_spec): Remove parameter `precision', introduced during
2516 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2517 All callers changed.
2518
2519 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2520
2521 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2522
2523 2011-03-27 Anders Lindgren <andlind@gmail.com>
2524
2525 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2526 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2527 (ns_update_auto_hide_menu_bar): New functions.
2528 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2529 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2530 ns_constrain_all_frames.
2531 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2532 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2533
2534 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2535
2536 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2537
2538 2011-03-27 Glenn Morris <rgm@gnu.org>
2539
2540 * syssignal.h: Replace RETSIGTYPE with void.
2541 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2542 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2543 Replace SIGTYPE with void everywhere.
2544 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2545 * s/template.h (SIGTYPE): Remove commented out definition.
2546
2547 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2548
2549 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2550 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2551
2552 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2553
2554 * w32.c (read_unc_volume): Use parameter `henum', instead of
2555 global variable `wget_enum_handle'.
2556
2557 * keymap.c (describe_vector): Remove parameters `indices' and
2558 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2559 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2560
2561 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2562
2563 * keyboard.c (timer_check): Remove parameter `do_it_now',
2564 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2565 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2566 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2567
2568 * keyboard.c (read_char):
2569 * w32menu.c (w32_menu_display_help):
2570 * xmenu.c (show_help_event, menu_help_callback):
2571 Adjust calls to `show_help_echo'.
2572
2573 * gtkutil.c (xg_maybe_add_timer):
2574 * keyboard.c (readable_events):
2575 * process.c (wait_reading_process_output):
2576 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2577
2578 * insdel.c (adjust_markers_gap_motion):
2579 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2580 (gap_left, gap_right): Don't call it.
2581
2582 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2583
2584 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2585 incurred during fontification.
2586
2587 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2588
2589 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2590 (DEFVAR_PER_BUFFER): Don't pass it.
2591
2592 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2593 (scrolling_window): Don't pass it.
2594
2595 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2596
2597 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2598
2599 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2600 and `suffix'.
2601 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2602 of variables specific to SELinux and computation of `encoded_absname'.
2603
2604 * image.c (XPutPixel): Remove unused variable `height'.
2605
2606 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2607
2608 * unexw32.c (get_section_info): Remove unused variable `section'.
2609
2610 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2611 (system_process_attributes): Remove unused variable `sess'.
2612 (sys_read): Remove unused variable `err'.
2613
2614 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2615 (w32_wnd_proc): Remove unused variable `isdead'.
2616 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2617 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2618 (x_create_tip_frame): Remove unused variable `tem'.
2619
2620 * w32inevt.c (w32_console_read_socket):
2621 Remove unused variable `no_events'.
2622
2623 * w32term.c (x_draw_composite_glyph_string_foreground):
2624 Remove unused variable `width'.
2625
2626 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2627
2628 * w32term.c (x_set_glyph_string_clipping):
2629 Don't pass uninitialized region to CombineRgn.
2630
2631 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2632
2633 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2634 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2635 (Fx_close_connection): Remove unused variable `i'.
2636
2637 * w32font.c (w32font_draw): Return number of glyphs.
2638 (w32font_open_internal): Remove unused variable `i'.
2639 (w32font_driver): Add missing initializer.
2640
2641 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2642 (fill_in_menu): Remove unused variable `items_added'.
2643
2644 * w32term.c (last_mouse_press_frame): Remove static global variable.
2645 (w32_clip_to_row): Remove unused variable `f'.
2646 (x_delete_terminal): Remove unused variable `i'.
2647
2648 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2649 (NOTHING): Remove unused static global variable.
2650 (uniscribe_check_otf): Remove unused variable `table'.
2651 (uniscribe_font_driver): Add missing initializers.
2652
2653 2011-03-23 Julien Danjou <julien@danjou.info>
2654
2655 * term.c (Fsuspend_tty, Fresume_tty):
2656 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2657 * window.c (temp_output_buffer_show):
2658 * insdel.c (signal_before_change):
2659 * frame.c (Fhandle_switch_frame):
2660 * fileio.c (Fdo_auto_save):
2661 * emacs.c (Fkill_emacs):
2662 * editfns.c (save_excursion_restore):
2663 * cmds.c (internal_self_insert):
2664 * callint.c (Fcall_interactively):
2665 * buffer.c (Fkill_all_local_variables):
2666 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2667 Use Frun_hooks.
2668 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2669 unconditionnaly since it does the check itself.
2670
2671 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2672
2673 Fix more problems found by GCC 4.5.2's static checks.
2674
2675 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2676 the first time through the loop, since we know p0 < p1 then.
2677 This also avoids a gcc -Wstrict-overflow warning.
2678
2679 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2680 leading to a memory leak, possible in functions like
2681 load_charset_map_from_file that can allocate an unbounded number
2682 of objects (Bug#8318).
2683
2684 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2685 that could (at least in theory) be that large.
2686
2687 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2688 This is less likely to overflow, and avoids undefined behavior if
2689 overflow does occur. All callers changed. Use strtoul to scan
2690 for the unsigned long integer.
2691 (pint2hrstr): Simplify and tune code slightly.
2692 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2693
2694 * scroll.c (do_scrolling): Work around GCC bug 48228.
2695 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2696
2697 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2698 This also avoids a warning with gcc -Wstrict-overflow.
2699 (validate_x_resource_name): Simplify count usage.
2700 This also avoids a warning with gcc -Wstrict-overflow.
2701
2702 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2703 fail (Bug#8306).
2704
2705 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2706
2707 * process.c (Fmake_network_process): Use socklen_t, not int,
2708 where POSIX says socklen_t is required in portable programs.
2709 This fixes a porting bug on hosts like 64-bit HP-UX, where
2710 socklen_t is wider than int (Bug#8277).
2711 (Fmake_network_process, server_accept_connection):
2712 (wait_reading_process_output, read_process_output):
2713 Likewise.
2714
2715 * process.c: Rename or move locals to avoid shadowing.
2716 (list_processes_1, Fmake_network_process):
2717 (read_process_output_error_handler, exec_sentinel_error_handler):
2718 Rename or move locals.
2719 (Fmake_network_process): Define label "retry_connect" only if needed.
2720 (Fnetwork_interface_info): Fix pointer signedness.
2721 (process_send_signal): Add cast to avoid pointer signedness problem.
2722 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2723 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2724
2725 Make tparam.h and terminfo.c consistent.
2726 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2727 Include tparam.h instead, since it declares them.
2728 * cm.h (PC): Remove extern decl; tparam.h now does this.
2729 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2730 * terminfo.c: Include tparam.h, to check interfaces.
2731 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2732 (tparam): Adjust signature to match interface in tparam.h;
2733 this removes some undefined behavior. Check that outstring and len
2734 are zero, which they always are with Emacs.
2735 * tparam.h (PC, BC, UP): New extern decls.
2736
2737 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2738 (xftfont_open): Rename locals to avoid shadowing.
2739
2740 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2741 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2742 (OTF_TAG_SYM): Omit macro if not needed.
2743 (ftfont_list): Remove unused local.
2744 (get_adstyle_property, ftfont_pattern_entity):
2745 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2746 Rename locals to avoid shadowing.
2747
2748 * xfont.c (xfont_list_family): Mark var as initialized.
2749
2750 * xml.c (make_dom): Now static.
2751
2752 * composite.c (composition_compute_stop_pos): Rename local to
2753 avoid shadowing.
2754 (composition_reseat_it): Remove unused locals.
2755 (find_automatic_composition, composition_adjust_point): Likewise.
2756 (composition_update_it): Mark var as initialized.
2757 (find_automatic_composition): Mark vars as initialized,
2758 with a FIXME (Bug#8290).
2759
2760 character.h: Rename locals to avoid shadowing.
2761 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2762 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2763 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2764 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2765 to avoid shadowing.
2766
2767 * textprop.c (property_change_between_p): Remove; unused.
2768
2769 * intervals.c (interval_start_pos): Now static.
2770
2771 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2772
2773 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2774 Rename locals to avoid shadowing.
2775
2776 * sound.c (wav_play, au_play, Fplay_sound_internal):
2777 Fix pointer signedness.
2778 (alsa_choose_format): Remove unused local var.
2779 (wav_play): Initialize a variable to 0, to prevent undefined
2780 behavior (Bug#8278).
2781
2782 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2783
2784 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2785
2786 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2787 clobbering (Bug#8298).
2788 * sysdep.c (sys_subshell): Likewise.
2789 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2790
2791 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2792 This should get cleaned up, so that child_setup has the
2793 same signature on all platforms.
2794
2795 * callproc.c (call_process_cleanup): Now static.
2796 (relocate_fd): Rename locals to avoid shadowing.
2797
2798 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2799
2800 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2801 not to be necessary, and produces flickering.
2802
2803 2011-03-20 Glenn Morris <rgm@gnu.org>
2804
2805 * config.in: Remove file.
2806
2807 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2808
2809 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2810 are now in src/globals.h.
2811 (syms_of_minibuf): Remove spurious & from previous change.
2812
2813 2011-03-20 Leo <sdl.web@gmail.com>
2814
2815 * minibuf.c (completing-read-function): New variable.
2816 (completing-read-default): Rename from completing-read.
2817 (completing-read): Call completing-read-function.
2818
2819 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2820
2821 * xfaces.c (Fx_load_color_file):
2822 Read color file from absolute filename (bug#8250).
2823
2824 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2825
2826 * makefile.w32-in: Update dependencies.
2827
2828 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2829
2830 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2831
2832 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2833
2834 Fix more problems found by GCC 4.5.2's static checks.
2835
2836 * process.c (make_serial_process_unwind, send_process_trap):
2837 (sigchld_handler): Now static.
2838
2839 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2840 That way, the code declares only the vars that it needs.
2841 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2842 * s/cygwin.h (PTY_ITERATION): Likewise.
2843 * s/darwin.h (PTY_ITERATION): Likewise.
2844 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2845
2846 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2847 * process.c (allocate_pty): Don't declare stb unless it's needed.
2848
2849 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2850 (CONSTANTLIM): Remove; unused.
2851 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2852 Define only if needed.
2853
2854 * unexelf.c (unexec): Name an expression,
2855 to avoid gcc -Wbad-function-cast warning.
2856 Use a different way to cause a compilation error if anyone uses
2857 n rather than nn, a way that does not involve shadowing.
2858 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2859
2860 * deps.mk (unexalpha.o): Remove; unused.
2861
2862 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2863 * unexec.h: New file.
2864 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2865 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2866 Depend on unexec.h.
2867 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2868 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2869 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2870 Change as necessary to match prototype in unexec.h.
2871
2872 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2873 shadowing.
2874 (back_comment, skip_chars): Mark vars as initialized.
2875
2876 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2877 Rename locals to avoid shadowing.
2878
2879 * lread.c (read1): Rewrite so as not to use empty "else".
2880 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2881
2882 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2883
2884 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2885 warning when compiling print.c.
2886
2887 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2888 instead of using an uninitialized var.
2889 (font_sort_entities): Mark var as initialized.
2890
2891 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2892
2893 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2894 pointers to constants.
2895 (font_parse_fcname): Remove unused vars.
2896 (font_delete_unmatched): Now static.
2897 (font_get_spec): Remove; unused.
2898 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2899 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2900 Rename or move locals to avoid shadowing.
2901
2902 * fns.c (require_nesting_list, require_unwind): Now static.
2903 (Ffillarray): Rename locals to avoid shadowing.
2904
2905 * floatfns.c (domain_error2): Define only if needed.
2906 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2907
2908 * alloc.c (mark_backtrace): Move decl from here ...
2909 * lisp.h: ... to here, so that it can be checked.
2910
2911 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2912 (Fdefvar): Rewrite so as not to use empty "else".
2913 (lisp_indirect_variable): Name an expression,
2914 to avoid gcc -Wbad-function-cast warning.
2915 (Fdefvar): Rename locals to avoid shadowing.
2916
2917 * callint.c (quotify_arg, quotify_args): Now static.
2918 (Fcall_interactively): Rename locals to avoid shadowing.
2919 Use const pointer when appropriate.
2920
2921 * lisp.h (get_system_name, get_operating_system_release):
2922 Move decls here, to check interfaces.
2923 * process.c (get_operating_system_release): Move decl to lisp.h.
2924 * xrdb.c (get_system_name): Likewise.
2925 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2926 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2927 some of which prompt warnings from gcc -Wbad-function-cast.
2928 (Fformat_time_string, Fencode_time, Finsert_char):
2929 (Ftranslate_region_internal, Fformat):
2930 Rename or remove local vars to avoid shadowing.
2931 (Ftranslate_region_internal): Mark var as initialized.
2932
2933 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2934 avoid shadowing.
2935
2936 * lisp.h (eassert): Check that the argument compiles, even if
2937 ENABLE_CHECKING is not defined.
2938
2939 * data.c (Findirect_variable): Name an expression, to avoid
2940 gcc -Wbad-function-cast warning.
2941 (default_value, arithcompare, arith_driver, arith_error): Now static.
2942 (store_symval_forwarding): Rename local to avoid shadowing.
2943 (Fmake_variable_buffer_local, Fmake_local_variable):
2944 Mark variables as initialized.
2945 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2946
2947 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2948 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2949 Rename locals to avoid shadowing.
2950 (mark_stack): Move local variables into the #ifdef region where
2951 they're used.
2952 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2953 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2954 needed otherwise.
2955 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2956 (GC_STRING_CHARS): Remove; not used.
2957 (Fmemory_limit): Cast sbrk's returned value to char *.
2958
2959 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2960 avoids undefined behavior in theory.
2961
2962 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2963
2964 Use functions, not macros, for up- and down-casing (Bug#8254).
2965 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2966 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2967 to use the following functions instead of these macros.
2968 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2969 EMACS_INT, since callers assume the returned value fits in int.
2970 (upcase1): Likewise, for UPCASE_TABLE.
2971 (uppercasep, lowercasep, upcase): New static inline functions.
2972 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2973 the race-condition problem in the old DOWNCASE.
2974
2975 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2976 Rename locals to avoid shadowing.
2977 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2978 (regex_compile, re_search_2, re_match_2_internal):
2979 Remove unused local vars.
2980 (FREE_VAR): Rewrite so as not to use empty "else",
2981 which gcc can warn about.
2982 (regex_compile, re_match_2_internal): Mark locals as initialized.
2983 (RETALLOC_IF): Define only if needed.
2984 (WORDCHAR_P): Likewise. This one is never needed, but is used
2985 only in a comment talking about a compiler bug, so put inside
2986 the #if 0 of that comment.
2987 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2988 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2989 Remove; unused.
2990
2991 * search.c (boyer_moore): Rename locals to avoid shadowing.
2992 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2993 (PREV_CHAR_BOUNDARY): Likewise.
2994
2995 * search.c (simple_search): Remove unused var.
2996
2997 * dired.c (compile_pattern): Move decl from here ...
2998 * lisp.h: ... to here, so that it can be checked.
2999 (struct re_registers): New forward decl.
3000
3001 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3002
3003 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3004 All uses changed.
3005 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3006 Rename locals to avoid shadowing.
3007 (Fvertical_motion): Mark locals as initialized.
3008
3009 * casefiddle.c (casify_object, casify_region): Now static.
3010 (casify_region): Mark local as initialized.
3011
3012 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3013
3014 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3015 New macros, so that the caller can use some names other than
3016 gcpro1, gcpro2, etc.
3017 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3018 of the new macros.
3019 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3020 argument, for consistency with GCPRO2_VAR, etc: it is now the
3021 prefix of the variable, not the variable itself. All uses
3022 changed.
3023 * dired.c (directory_files_internal, file_name_completion):
3024 Rename locals to avoid shadowing.
3025
3026 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3027 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3028 dired.c's scmp function, had undefined behavior.
3029 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3030 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3031 * buffer.h: ... to here, because these macros use current_buffer,
3032 and the new implementation with inline functions needs to have
3033 current_buffer in scope now, rather than later when the macros
3034 are used.
3035 (downcase, upcase1): New static inline functions.
3036 (DOWNCASE, UPCASE1): Reimplement using these functions.
3037 This avoids undefined behavior in expressions like
3038 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3039 from race conditions in accessing the global variables
3040 case_temp1 and case_temp2.
3041 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3042 * lisp.h (case_temp1, case_temp2): Remove their decls.
3043 * character.h (ASCII_CHAR_P): Move from here ...
3044 * lisp.h: ... to here, so that the inline functions mentioned
3045 above can use them.
3046
3047 * dired.c (directory_files_internal_unwind): Now static.
3048
3049 * fileio.c (file_name_as_directory, directory_file_name):
3050 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3051 Now static.
3052 (file_name_as_directory): Use const pointers when appropriate.
3053 (Fexpand_file_name): Likewise. In particular, newdir might
3054 point at constant storage, so make it a const pointer.
3055 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3056 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3057 signedness issues.
3058 (Fset_file_times, Finsert_file_contents, auto_save_error):
3059 Rename locals to avoid shadowing.
3060
3061 * minibuf.c (choose_minibuf_frame_1): Now static.
3062 (Ftry_completion, Fall_completions): Rename or remove locals
3063 to avoid shadowing.
3064
3065 * marker.c (bytepos_to_charpos): Remove; unused.
3066
3067 * lisp.h (verify_bytepos, count_markers): New decls,
3068 so that gcc does not warn that these functions aren't declared.
3069
3070 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3071 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3072 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3073 (copy_text): Remove unused local var.
3074
3075 * filelock.c (within_one_second): Now static.
3076 (lock_file_1): Rename local to avoid shadowing.
3077
3078 * buffer.c (fix_overlays_before): Mark locals as initialized.
3079 (fix_start_end_in_overlays): Likewise. This function should be
3080 simplified by using pointers-to-pointers, but that's a different
3081 matter.
3082 (switch_to_buffer_1): Now static.
3083 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3084 (report_overlay_modification): Rename locals to avoid shadowing.
3085
3086 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3087 Fix pointer signedness issue.
3088 (sys_subshell): Mark local as volatile if checking for lint,
3089 to suppress a gcc -Wclobbered warning that does not seem to be right.
3090 (MAXPATHLEN): Define only if needed.
3091
3092 * process.c (serial_open, serial_configure): Move decls from here ...
3093 * systty.h: ... to here, so that they can be checked.
3094
3095 * fns.c (get_random, seed_random): Move extern decls from here ...
3096 * lisp.h: ... to here, so that they can be checked.
3097
3098 * sysdep.c (reset_io): Now static.
3099 (wait_for_termination_signal): Remove; unused.
3100
3101 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3102 (copy_keymap_item, append_key, push_text_char_description):
3103 Now static.
3104 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3105 (DENSE_TABLE_SIZE): Remove; unused.
3106 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3107 (describe_map_tree):
3108 Rename locals to avoid shadowing.
3109
3110 * keyboard.c: Declare functions static if they are not used elsewhere.
3111 (echo_char, echo_dash, cmd_error, top_level_2):
3112 (poll_for_input, handle_async_input): Now static.
3113 (read_char, kbd_buffer_get_event, make_lispy_position):
3114 (make_lispy_event, make_lispy_movement, apply_modifiers):
3115 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3116 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3117 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3118 (read_key_sequence, read_char): Mark locals as initialized.
3119 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3120
3121 * keyboard.h (make_ctrl_char): New decl.
3122 (mark_kboards): Move decl here ...
3123 * alloc.c (mark_kboards): ... from here.
3124
3125 * lisp.h (force_auto_save_soon): New decl.
3126
3127 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3128 (DEFINE_DUMMY_FUNCTION): New macro.
3129 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3130 Use it.
3131 (main): Add casts to avoid warnings
3132 if GCC considers string literals to be constants.
3133
3134 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3135
3136 * dbusbind.c: Pointer signedness fixes.
3137 (xd_signature, xd_append_arg, xd_initialize):
3138 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3139 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3140 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3141 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3142
3143 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3144 if GCC considers string literals to be constants.
3145 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3146
3147 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3148
3149 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3150 (print_preprocess, print_object): New macro to fix last change.
3151
3152 * print.c (print_preprocess): Don't forget font objects.
3153
3154 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3155
3156 * emacs.c (USAGE3): Doc fixes.
3157
3158 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3159
3160 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3161 structure.
3162
3163 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3164
3165 * lisp.h (VWindow_system, Qfile_name_history):
3166 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3167 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3168 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3169
3170 * w32select.c: Don't #include "keyboard.h".
3171 (run_protected): Add extern declaration for waiting_for_input.
3172
3173 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3174 * w32console.c (detect_input_pending, read_input_pending)
3175 (encode_terminal_code):
3176 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3177 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3178 (w32_system_caret_y, Qfile_name_history):
3179 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3180 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3181 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3182 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3183 * w32proc.c (Qlocal, report_file_error):
3184 * w32term.c (Vwindow_system, updating_frame):
3185 * w32uniscribe.c (initialized, uniscribe_font_driver):
3186 Remove unneeded extern declarations.
3187
3188 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3189
3190 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3191
3192 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3193
3194 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3195 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3196 These macros can no longer be used for assignment.
3197
3198 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3199 Assign struct members directly, instead of using BUF_BEGV etc.
3200 (record_buffer_markers, fetch_buffer_markers): New functions for
3201 recording and fetching special buffer markers.
3202 (set_buffer_internal_1, set_buffer_temp): Use them.
3203
3204 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3205
3206 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3207
3208 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3209 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3210
3211 * xdisp.c (hscroll_window_tree):
3212 (reconsider_clip_changes): Use PT instead of BUF_PT.
3213
3214 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3215
3216 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3217 $(EMACS_ROOT)/lib/intprops.h.
3218
3219 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3220
3221 Fix more problems found by GCC 4.5.2's static checks.
3222
3223 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3224 to unsigned char * to avoid compiler diagnostic.
3225 (xg_free_frame_widgets): Make it clear that a local variable is
3226 needed only if USE_GTK_TOOLTIP.
3227 (gdk_window_get_screen): Make it clear that this macro is needed
3228 only if USE_GTK_TOOLTIP.
3229 (int_gtk_range_get_value): New function, which avoids a diagnostic
3230 from gcc -Wbad-function-cast.
3231 (xg_set_toolkit_scroll_bar_thumb): Use it.
3232 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3233 diagnostic from gcc -Wbad-function-cast.
3234 (get_utf8_string, xg_get_file_with_chooser):
3235 Rename locals to avoid shadowing.
3236 (create_dialog): Move locals to avoid shadowing.
3237
3238 * xgselect.c (xg_select): Remove unused var.
3239
3240 * image.c (four_corners_best): Mark locals as initialized.
3241 (gif_load): Initialize transparent_p to zero (Bug#8238).
3242 Mark another local as initialized.
3243 (my_png_error, my_error_exit): Mark with NO_RETURN.
3244
3245 * image.c (clear_image_cache): Now static.
3246 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3247 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3248 (x_edge_detection): Remove unnecessary cast that
3249 gcc -Wbad-function-cast diagnoses.
3250 (gif_load): Fix pointer signedness.
3251 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3252 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3253
3254 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3255
3256 Improve quality of tests for time stamp overflow.
3257 For example, without this patch (encode-time 0 0 0 1 1
3258 1152921504606846976) returns the obviously-bogus value (-948597
3259 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3260 reports time overflow. See
3261 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3262 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3263 * editfns.c: Include limits.h and intprops.h.
3264 (TIME_T_MIN, TIME_T_MAX): New macros.
3265 (time_overflow): Move earlier, to before first use.
3266 (hi_time, lo_time): New functions, for an accurate test for
3267 out-of-range times.
3268 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3269 (Fget_internal_run_time): Don't assume time_t fits in int.
3270 (make_time): Use list2 instead of Fcons twice.
3271 (Fdecode_time): More accurate test for out-of-range times.
3272 (check_tm_member): New function.
3273 (Fencode_time): Use it, to test for out-of-range times.
3274 (lisp_time_argument): Don't rely on undefined left-shift and
3275 right-shift behavior when checking for time stamp overflow.
3276
3277 * editfns.c (time_overflow): New function, refactoring common code.
3278 (Fformat_time_string, Fdecode_time, Fencode_time):
3279 (Fcurrent_time_string): Use it.
3280
3281 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3282 * dired.c (make_time): Move to ...
3283 * editfns.c (make_time): ... here.
3284 * systime.h: Note the move.
3285
3286 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3287
3288 * fringe.c (update_window_fringes): Remove unused variables.
3289
3290 * unexmacosx.c (copy_data_segment): Also copy __got section.
3291 (Bug#8223)
3292
3293 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3294
3295 * termcap.c [MSDOS]: Include "msdos.h".
3296 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3297 Constify `char *' arguments and their references according to
3298 prototypes in tparam.h.
3299
3300 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3301
3302 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3303 Adapt all references accordingly.
3304
3305 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3306
3307 2011-03-11 Tom Tromey <tromey@redhat.com>
3308
3309 * buffer.c (syms_of_buffer): Remove obsolete comment.
3310
3311 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3312
3313 * termhooks.h (encode_terminal_code): Declare prototype.
3314
3315 * msdos.c (encode_terminal_code): Don't declare prototype.
3316
3317 * term.c (encode_terminal_code): Now external again, used by
3318 w32console.c and msdos.c.
3319
3320 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3321 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3322
3323 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 Fix some minor problems found by GCC 4.5.2's static checks.
3326
3327 * fringe.c (update_window_fringes): Mark locals as initialized
3328 (Bug#8227).
3329 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3330
3331 * alloc.c (mark_fringe_data): Move decl from here ...
3332 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3333 to check its interface.
3334 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3335
3336 * fontset.c (free_realized_fontset): Now static.
3337 (Fset_fontset_font): Rename local to avoid shadowing.
3338 (fontset_font): Mark local as initialized.
3339 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3340
3341 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3342
3343 * xselect.c (x_disown_buffer_selections): Remove; not used.
3344 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3345 (x_own_selection, Fx_disown_selection_internal): Rename locals
3346 to avoid shadowing.
3347 (x_handle_dnd_message): Remove local to avoid shadowing.
3348
3349 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3350 so that the caller can use some name other than gcpro1.
3351 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3352 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3353 (Fx_backspace_delete_keys_p):
3354 Use them to avoid shadowing, and rename vars to avoid shadowing.
3355 (x_decode_color, x_set_name, x_window): Now static.
3356 (Fx_create_frame): Add braces to silence GCC warning.
3357 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3358 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3359 Remove unused locals.
3360 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3361 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3362 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3363 macros.
3364
3365 * xterm.h (x_mouse_leave): New decl.
3366
3367 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3368 Remove unused functions.
3369 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3370 (x_calc_absolute_position): Now static.
3371 (XTread_socket): Don't define label "out" unless it's used.
3372 Don't declare local "event" unless it's used.
3373 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3374 unless they are used.
3375 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3376 (x_fatal_error_signal): Remove; not used.
3377 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3378 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3379 (x_error_catcher, x_connection_closed, x_error_handler):
3380 (x_error_quitter, xembed_send_message, x_iconify_frame):
3381 (my_log_handler): Rename locals to avoid shadowing.
3382 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3383 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3384
3385 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3386 Rename or move locals to avoid shadowing.
3387 (tty_defined_color, merge_face_heights): Now static.
3388 (free_realized_faces_for_fontset): Remove; not used.
3389 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3390 does not deduce is never used uninitialized.
3391 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3392 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3393
3394 * terminal.c (store_terminal_param): Now static.
3395
3396 * xmenu.c (menu_highlight_callback): Now static.
3397 (set_frame_menubar): Remove unused local.
3398 (xmenu_show): Rename parameter to avoid shadowing.
3399 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3400 since they might point to immutable storage.
3401 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3402 since it's unused otherwise.
3403
3404 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3405 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3406 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3407 avoids a gcc -Wuninitialized diagnostic.
3408 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3409 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3410 does not deduce are never used uninitialized.
3411
3412 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3413
3414 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3415 * window.c (window_loop, size_window):
3416 (run_window_configuration_change_hook, enlarge_window): Likewise.
3417
3418 * window.c (display_buffer): Now static.
3419 (size_window): Mark variables that gcc -Wuninitialized
3420 does not deduce are never used uninitialized.
3421 * window.h (check_all_windows): New decl, to forestall
3422 gcc -Wmissing-prototypes diagnostic.
3423 * dispextern.h (bidi_dump_cached_states): Likewise.
3424
3425 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3426 shadowing.
3427 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3428 Include <limits.h>.
3429 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3430 and to avoid gcc -Wuninitialized warning.
3431 (load_charset_map): Mark variables that gcc -Wuninitialized
3432 does not deduce are never used uninitialized.
3433 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3434
3435 * coding.c (coding_set_source, coding_set_destination):
3436 Use "else { /* comment */ }" rather than "else /* comment */;"
3437 for clarity, and to avoid gcc -Wempty-body warning.
3438 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3439 a block, when the outer 'i' will do.
3440 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3441 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3442 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3443 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3444 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3445 Rename locals to avoid shadowing.
3446 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3447 * coding.c (emacs_mule_char, encode_invocation_designation):
3448 Now static, since they're not used elsewhere.
3449 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3450 (decode_coding_object, encode_coding_object, detect_coding_system):
3451 (decode_coding_emacs_mule): Mark variables that gcc
3452 -Wuninitialized does not deduce are never used uninitialized.
3453 (detect_coding_iso_2022): Initialize a local variable that might
3454 be used uninitialized. Leave a FIXME because it's not clear that
3455 this initialization is needed. (Bug#8211)
3456 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3457 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3458 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3459 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3460 Remove unused macros.
3461
3462 * category.c (hash_get_category_set): Remove unused local var.
3463 (copy_category_table): Now static, since it's not used elsewhere.
3464 * character.c (string_count_byte8): Likewise.
3465
3466 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3467 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3468
3469 * chartab.c (copy_sub_char_table): Now static, since it's not used
3470 elsewhere.
3471 (sub_char_table_ref_and_range, char_table_ref_and_range):
3472 Rename locals to avoid shadowing.
3473 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3474
3475 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3476 (BIDI_BOB): Remove unused macro.
3477
3478 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3479 deduce are never used uninitialized.
3480 * term.c (encode_terminal_code): Likewise.
3481
3482 * term.c (encode_terminal_code): Now static. Remove unused local.
3483
3484 * tparam.h: New file.
3485 * term.c, tparam.h: Include it.
3486 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3487 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3488 Move these decls to tparam.h, and make them agree with what
3489 is actually in tparam.c. The previous trick of using incompatible
3490 decls in different modules does not conform to the C standard.
3491 All callers of tparam changed to use tparam's actual API.
3492 * tparam.c (tparam1, tparam, tgoto):
3493 Use const pointers where appropriate.
3494
3495 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3496 * cm.h (struct cm): Likewise.
3497 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3498 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3499 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3500 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3501 (turn_on_face, init_tty): Likewise.
3502 * termchar.h (struct tty_display_info): Likewise.
3503
3504 * term.c (term_mouse_position): Rename local to avoid shadowing.
3505
3506 * alloc.c (mark_ttys): Move decl from here ...
3507 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3508
3509 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3510
3511 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3512
3513 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3514
3515 * search.c (compile_pattern_1): Remove argument regp, unused since
3516 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3517 (compile_pattern): Don't pass it.
3518
3519 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3520
3521 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3522 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3523 for ! HAVE_GTK3.
3524 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3525
3526 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3527
3528 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3529 gdk_window_get_screen, gdk_window_get_geometry,
3530 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3531 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3532 (xg_get_pixbuf_from_pixmap): New function.
3533 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3534 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3535 Call xg_get_pixbuf_from_pixmap instead of
3536 gdk_pixbuf_get_from_drawable.
3537 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3538 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3539 (xg_check_special_colors): Use GtkStyleContext and its functions
3540 for HAVE_GTK3.
3541 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3542 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3543 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3544 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3545 Call gtk_widget_get_preferred_size.
3546 (xg_frame_resized): gdk_window_get_geometry only takes 5
3547 parameters.
3548 (xg_win_to_widget, xg_event_is_for_menubar):
3549 Call gdk_x11_window_lookup_for_display.
3550 (xg_set_widget_bg): New function.
3551 (delete_cb): New function.
3552 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3553 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3554 (xg_set_background_color): Call xg_set_widget_bg.
3555 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3556 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3557 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3558 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3559 if ! HAVE_GTK3.
3560 (update_frame_tool_bar): Call gtk_widget_hide.
3561 (xg_initialize): Use GDK_KEY_g.
3562
3563 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3564 if ! HAVE_GTK3
3565 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3566
3567 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3568 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3569 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3570
3571 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3572
3573 * w32xfns.c (select_palette): Check success of RealizePalette against
3574 GDI_ERROR, not zero.
3575
3576 See ChangeLog.11 for earlier changes.
3577
3578 ;; Local Variables:
3579 ;; coding: utf-8
3580 ;; End:
3581
3582 Copyright (C) 2011 Free Software Foundation, Inc.
3583
3584 This file is part of GNU Emacs.
3585
3586 GNU Emacs is free software: you can redistribute it and/or modify
3587 it under the terms of the GNU General Public License as published by
3588 the Free Software Foundation, either version 3 of the License, or
3589 (at your option) any later version.
3590
3591 GNU Emacs is distributed in the hope that it will be useful,
3592 but WITHOUT ANY WARRANTY; without even the implied warranty of
3593 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3594 GNU General Public License for more details.
3595
3596 You should have received a copy of the GNU General Public License
3597 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.