1 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3 * makefile.w32-in: Redesign dependencies so they reflect more
4 clearly which files are directly included by each source file,
5 and not through other includes.
7 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10 (sort_overlays, overlay_strings): When an overlay's clone number
11 matches the window's clone number process the overlay even if
12 the overlay's window property doesn't match the current window.
14 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
15 (Fwindow_hchild): Rename to Fwindow_left_child.
16 (Fwindow_next): Rename to Fwindow_next_sibling.
17 (Fwindow_prev): Rename to Fwindow_prev_sibling.
18 (resize_window_check): Rename to window_resize_check.
19 (resize_window_apply): Rename to window_resize_apply.
20 (Fresize_window_apply): Rename to Fwindow_resize_apply.
21 (Fdelete_other_windows_internal, resize_frame_windows)
22 (Fsplit_window_internal, Fdelete_window_internal)
23 (grow_mini_window, shrink_mini_window)
24 (Fresize_mini_window_internal): Fix callers accordingly.
26 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
28 * emacsgtkfixed.h: State that this is only used with Gtk+3.
29 (emacs_fixed_set_min_size): Remove.
30 (emacs_fixed_new): Take frame as argument.
32 * emacsgtkfixed.c: State that this is only used with Gtk+3.
33 (_EmacsFixedPrivate): Remove minwidth/height.
35 (emacs_fixed_init): Initialize priv->f.
36 (get_parent_class, emacs_fixed_set_min_size): Remove.
37 (emacs_fixed_new): Set priv->f to argument.
38 (emacs_fixed_get_preferred_width)
39 (emacs_fixed_get_preferred_height): Use min_width/height from
40 frames size_hint to set minimum and natural (Bug#8919).
41 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
42 and use min_width/height from frames size_hint to set
43 min_width/height (Bug#8919).
45 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
46 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
49 2011-06-26 Eli Zaretskii <eliz@gnu.org>
51 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
52 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
55 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
57 * process.c (wait_reading_process_output): Bypass select if
58 waiting for a cell while ignoring keyboard input, and input is
59 pending. Suggested by Jan Djärv (Bug#8869).
61 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
63 Use gnulib's dup2 module instead of rolling our own.
64 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
66 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
68 * dispnew.c (scrolling_window): Before scrolling, turn off a
69 mouse-highlight in the window being scrolled.
71 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
73 Move DEFSYM to lisp.h and use everywhere.
75 * character.h (DEFSYM): Move declaration...
76 * lisp.h (DEFSYM): ...here.
82 * w32select.c: Don't include character.h.
84 * alloc.c (syms_of_alloc):
85 * buffer.c (syms_of_buffer):
86 * bytecode.c (syms_of_bytecode):
87 * callint.c (syms_of_callint):
88 * casefiddle.c (syms_of_casefiddle):
89 * casetab.c (init_casetab_once):
90 * category.c (init_category_once, syms_of_category):
91 * ccl.c (syms_of_ccl):
92 * cmds.c (syms_of_cmds):
93 * composite.c (syms_of_composite):
94 * dbusbind.c (syms_of_dbusbind):
95 * dired.c (syms_of_dired):
96 * dispnew.c (syms_of_display):
97 * doc.c (syms_of_doc):
98 * editfns.c (syms_of_editfns):
99 * emacs.c (syms_of_emacs):
100 * eval.c (syms_of_eval):
101 * fileio.c (syms_of_fileio):
102 * fns.c (syms_of_fns):
103 * frame.c (syms_of_frame):
104 * fringe.c (syms_of_fringe):
105 * insdel.c (syms_of_insdel):
106 * keymap.c (syms_of_keymap):
107 * lread.c (init_obarray, syms_of_lread):
108 * macros.c (syms_of_macros):
109 * msdos.c (syms_of_msdos):
110 * print.c (syms_of_print):
111 * process.c (syms_of_process):
112 * search.c (syms_of_search):
113 * sound.c (syms_of_sound):
114 * syntax.c (init_syntax_once, syms_of_syntax):
115 * terminal.c (syms_of_terminal):
116 * textprop.c (syms_of_textprop):
117 * undo.c (syms_of_undo):
118 * w32.c (globals_of_w32):
119 * window.c (syms_of_window):
120 * xdisp.c (syms_of_xdisp):
121 * xfaces.c (syms_of_xfaces):
122 * xfns.c (syms_of_xfns):
123 * xmenu.c (syms_of_xmenu):
124 * xsettings.c (syms_of_xsettings):
125 * xterm.c (syms_of_xterm): Use DEFSYM.
127 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
129 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
131 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
133 Integer and buffer overflow fixes (Bug#8873).
135 * print.c (printchar, strout): Check for string overflow.
136 (PRINTPREPARE, printchar, strout):
137 Don't set size unless allocation succeeds.
139 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
140 for sizes. Check for string overflow more accurately.
141 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
143 * macros.c: Integer and buffer overflow fixes.
144 * keyboard.h (struct keyboard.kbd_macro_bufsize):
145 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
146 Use ptrdiff_t, not int, for sizes.
147 Don't increment bufsize until after realloc succeeds.
148 Check for size-calculation overflow.
149 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
151 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
153 * lread.c: Integer overflow fixes.
154 (read_integer): Radix is now EMACS_INT, not int,
155 to improve quality of diagnostics for out-of-range radices.
156 Calculate buffer size correctly for out-of-range radices.
157 (read1): Check for integer overflow in radices, and in
159 (read_escape): Avoid int overflow.
160 (Fload, openp, read_buffer_size, read1)
161 (substitute_object_recurse, read_vector, read_list, map_obarray):
162 Use ptrdiff_t, not int, for sizes.
163 (read1): Use EMACS_INT, not int, for sizes.
164 Check for size overflow.
166 * image.c (cache_image): Check for size arithmetic overflow.
168 * lread.c: Integer overflow issues.
169 (saved_doc_string_size, saved_doc_string_length)
170 (prev_saved_doc_string_size, prev_saved_doc_string_length):
171 Now ptrdiff_t, not int.
172 (read1): Don't assume doc string length fits in int. Check for
173 out-of-range doc string lengths.
174 (read_list): Don't assume file position fits in int.
175 (read_escape): Check for hex character overflow.
177 2011-06-22 Leo Liu <sdl.web@gmail.com>
179 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
180 Move to minibuffer.el.
182 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
184 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
185 The following patches are for when GLYPH_DEBUG && !XASSERT.
186 * dispextern.h (trace_redisplay_p, dump_glyph_string):
187 * dispnew.c (flush_stdout):
188 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
189 Mark as externally visible.
190 * dispnew.c (check_window_matrix_pointers): Now static.
191 * dispnew.c (window_to_frame_vpos):
192 * xfns.c (unwind_create_frame):
193 * xterm.c (x_check_font): Remove unused local.
194 * scroll.c (CHECK_BOUNDS):
195 * xfaces.c (cache_fache): Rename local to avoid shadowing.
196 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
197 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
198 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
199 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
201 (debug_method_add): Use va_list and vsprintf rather than relying
202 on undefined behavior with wrong number of arguments.
203 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
204 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
205 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
206 since we're not interested in debugging glyphs with old libraries.
207 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
208 GCC 4.6.0's static checking.
210 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
212 Integer overflow and signedness fixes (Bug#8873).
213 A few related buffer overrun fixes, too.
215 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
217 * dispextern.h (struct face.stipple):
218 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
219 (x_bitmap_mask, x_allocate_bitmap_record)
220 (x_create_bitmap_from_data, x_create_bitmap_from_file)
221 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
222 (x_create_bitmap_from_xpm_data):
223 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
224 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
226 * xfaces.c (load_pixmap):
227 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
228 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
229 (.bitmaps_last, struct x_output.icon_bitmap):
230 Use ptrdiff_t, not int, for bitmap indexes.
231 (x_allocate_bitmap_record): Check for size overflow.
232 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
234 Use ptrdiff_t, not int, for overlay counts.
235 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
236 * editfns.c (overlays_around, get_pos_property):
237 * textprop.c (get_char_property_and_overlay):
238 * xdisp.c (next_overlay_change, note_mouse_highlight):
239 * xfaces.c (face_at_buffer_position):
240 * buffer.c (OVERLAY_COUNT_MAX): New macro.
241 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
242 (Fnext_overlay_change, Fprevious_overlay_change)
243 (mouse_face_overlay_overlaps, Foverlays_in):
244 Use ptrdiff_t, not int, for sizes.
245 (overlays_at, overlays_in): Check for size-calculation overflow.
247 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
249 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
250 (x_session_initialize): Do not assume string length fits in int.
252 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
253 This is unlikely, but can occur if DPI is outlandish.
255 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
256 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
258 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
259 * xrdb.c (magic_file_p, search_magic_path):
260 Omit last arg SUFFIX; it was always 0. All callers changed.
261 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
263 * xfont.c (xfont_match): Avoid need for strlen.
265 * xfns.c: Don't assume strlen fits in int.
266 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
268 * xdisp.c (message_log_check_duplicate): Return intmax_t,
269 not unsigned long, as we prefer signed integers. All callers changed.
270 Detect integer overflow in repeat count.
271 (message_dolog): Don't assume print length fits in 39 bytes.
272 (display_mode_element): Don't assume strlen fits in int.
274 * termcap.c: Don't assume sizes fit in int and never overflow.
275 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
276 (gobble_line): Check for size-calculation overflow.
278 * minibuf.c (Fread_buffer):
279 * lread.c (intern, intern_c_string):
280 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
281 Don't assume string length fits in int.
283 * keyboard.c (parse_tool_bar_item):
284 * gtkutil.c (style_changed_cb): Avoid need for strlen.
286 * font.c: Don't assume string length fits in int.
287 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
288 Use ptrdiff_t, not int.
289 (font_intern_prop): Don't assume string length fits in int.
290 Don't assume integer property fits in fixnum.
291 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
293 * filelock.c: Fix some buffer overrun and integer overflow issues.
294 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
295 Reformulate so as not to need the command string.
296 Invoke gzip -cd rather than gunzip, as it's more portable.
297 (lock_info_type, lock_file_1, lock_file):
298 Don't assume pid_t and time_t fit in unsigned long.
299 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
300 (current_lock_owner): Prefer signed type for sizes.
301 Use memcpy, not strncpy, where memcpy is what is really wanted.
302 Don't assume (via atoi) that time_t and pid_t fit in int.
303 Check for time_t and/or pid_t out of range, e.g., via a network share.
304 Don't alloca where an auto var works fine.
306 * fileio.c: Fix some integer overflow issues.
307 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
308 Don't assume string length fits in int.
309 (directory_file_name): Don't assume string length fits in long.
310 (make_temp_name): Don't assume pid fits in int, or that its print
311 length is less than 20.
313 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
315 * coding.c (make_subsidiaries): Don't assume string length fits in int.
317 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
319 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
320 We prefer signed integers, even for size calculations.
322 * emacs.c: Don't assume string length fits in 'int'.
323 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
324 (main): Don't invoke strlen when not needed.
326 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
327 (XD_DEBUG_MESSAGE): Don't waste a byte.
329 * callproc.c (getenv_internal_1, getenv_internal)
331 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
333 * lread.c (invalid_syntax): Omit length argument.
334 All uses changed. This doesn't fix a bug, but it simplifies the
335 code away from its former Hollerith-constant appearance, and it's
336 one less 'int' to worry about when looking at integer-overflow issues.
337 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
339 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
340 This didn't break anything, but it didn't help either.
341 It's confusing to put a bogus integer in a place where the actual
342 value does not matter.
343 (LIST_END_P): Remove unused macro and its bogus comment.
344 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
346 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
347 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
349 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
350 We prefer signed types, and the value cannot exceed the EMACS_INT
351 range anyway (because otherwise the length would not be representable).
352 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
353 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
354 This avoids a GCC warning when WIDE_EMACS_INT.
356 * indent.c (sane_tab_width): New function.
357 (current_column, scan_for_column, Findent_to, position_indentation)
358 (compute_motion): Use it. This is just for clarity.
359 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
361 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
363 * lisp.h (lint_assume): New macro.
364 * composite.c (composition_gstring_put_cache):
365 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
367 * editfns.c, insdel.c:
368 Omit unnecessary forward decls, to simplify future changes.
370 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
372 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
374 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
375 Use much-faster test for byte-length change.
376 Don't assume string byte-length fits in 'int'.
377 Check that character arg fits in 'int'.
378 (mapcar1): Declare byte as byte, for clarity.
380 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
382 * fns.c (concat): Catch string overflow earlier.
383 Do not rely on integer wraparound.
385 * dispextern.h (struct it.overlay_strings_charpos)
386 (struct it.selective): Now EMACS_INT, not int.
387 * xdisp.c (forward_to_next_line_start)
388 (back_to_previous_visible_line_start)
389 (reseat_at_next_visible_line_start, next_element_from_buffer):
390 Don't arbitrarily truncate the value of 'selective' to int.
392 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
394 * composite.c: Don't truncate sizes to 'int'.
395 (composition_gstring_p, composition_reseat_it)
396 (composition_adjust_point): Use EMACS_INT, not int.
397 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
398 not EMACS_UINT, for indexes.
400 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
402 * buffer.c: Include <verify.h>.
403 (struct sortvec.priority, struct sortstr.priority):
404 Now EMACS_INT, not int.
405 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
406 (struct sortstr.size, record_overlay_string)
407 (struct sortstrlist.size, struct sortlist.used):
408 Don't truncate size to int.
409 (record_overlay_string): Check for size-calculation overflow.
410 (init_buffer_once): Check at compile-time, not run-time.
412 2011-06-22 Jim Meyering <meyering@redhat.com>
414 Don't leak an XBM-image-sized buffer
415 * image.c (xbm_load): Free the image buffer after using it.
417 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
420 * composite.c (find_automatic_composition): Omit needless 'return 0;'
421 that Sun C diagnosed.
422 * fns.c (secure_hash): Fix pointer signedness issue.
423 * intervals.c (static_offset_intervals): New function.
424 (offset_intervals): Use it.
426 2011-06-21 Leo Liu <sdl.web@gmail.com>
429 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
432 * fns.c (secure_hash): Rename from crypto_hash_function and change
433 the first arg to accept symbols.
434 (Fsecure_hash): New primitive.
435 (syms_of_fns): New symbols.
437 2011-06-20 Deniz Dogan <deniz@dogan.se>
439 * process.c (Fset_process_buffer): Clarify return value in
442 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
444 * dispnew.c (add_window_display_history): Use BVAR.
446 * xdisp.c (debug_method_add): Use BVAR.
447 (check_window_end, dump_glyph_matrix, dump_glyph)
448 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
450 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
453 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
454 check till after the cache is created in init_frame_faces.
456 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
458 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
460 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
462 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
463 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
464 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
466 Improve buffer-overflow checking (Bug#8873).
467 * fileio.c (Finsert_file_contents):
468 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
469 Remove the old (too-loose) buffer overflow checks.
470 They weren't needed, since make_gap checks for buffer overflow.
471 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
472 The old code merely checked for Emacs fixnum overflow, and relied
473 on undefined (wraparound) behavior. The new code avoids undefined
474 behavior, and also checks for ptrdiff_t and/or size_t overflow.
476 * editfns.c (Finsert_char): Don't dump core with very negative counts.
477 Tune. Don't use wider integers than needed. Don't use alloca.
478 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
480 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
482 * insdel.c, lisp.h (buffer_overflow): New function.
483 (insert_from_buffer_1, replace_range, replace_range_2):
484 * insdel.c (make_gap_larger):
485 * editfns.c (Finsert_char):
486 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
488 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
490 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
492 Integer overflow and signedness fixes (Bug#8873).
494 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
495 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
497 * fileio.c: Don't assume EMACS_INT fits in off_t.
498 (emacs_lseek): New static function.
499 (Finsert_file_contents, Fwrite_region): Use it.
500 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
502 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
504 * fns.c: Don't overflow int when computing a list length.
505 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
506 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
507 truncation on 64-bit hosts. Check for QUIT every
508 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
509 faster and is responsive enough.
510 (Flength): Report an error instead of overflowing an integer.
511 (Fsafe_length): Return a float if the value is not representable
512 as a fixnum. This shouldn't happen except in contrived situations.
513 (Fnthcdr, Fsort): Don't assume list length fits in int.
514 (Fcopy_sequence): Don't assume vector length fits in int.
516 * alloc.c: Check that resized vectors' lengths fit in fixnums.
517 (header_size, word_size): New constants.
518 (allocate_vectorlike): Don't check size overflow here.
519 (allocate_vector): Check it here instead, since this is the only
520 caller of allocate_vectorlike that could cause overflow.
521 Check that the new vector's length is representable as a fixnum.
523 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
524 The previous code was bogus. For example, next_almost_prime (32)
525 returned 39, which is undesirable as it is a multiple of 3; and
526 next_almost_prime (24) returned 25, which is a multiple of 5 so
527 why was the code bothering to check for multiples of 7?
529 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
531 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
533 Variadic C functions now count arguments with ptrdiff_t.
534 This partly undoes my 2011-03-30 change, which replaced int with size_t.
535 Back then I didn't know that the Emacs coding style prefers signed int.
536 Also, in the meantime I found a few more instances where arguments
537 were being counted with int, which may truncate counts on 64-bit
538 machines, or EMACS_INT, which may be unnecessarily wide.
539 * lisp.h (struct Lisp_Subr.function.aMANY)
540 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
541 Arg counts are now ptrdiff_t, not size_t.
542 All variadic functions and their callers changed accordingly.
543 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
544 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
545 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
546 * callint.c (Fcall_interactively): Check arg count for overflow,
547 to avoid potential buffer overrun. Use signed char, not 'int',
548 for 'varies' array, so that we needn't bother to check its size
549 calculation for overflow.
550 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
551 * eval.c (apply_lambda):
552 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
553 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
554 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
556 * callint.c (Fcall_interactively): Don't use index var as event count.
558 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
559 * mem-limits.h (SIZE): Remove; no longer used.
561 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
563 Remove unnecessary casts.
564 * xterm.c (x_term_init):
565 * xfns.c (x_set_border_pixel):
566 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
567 These aren't needed now that we assume ANSI C.
569 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
570 It's more likely to cause problems (due to unsigned overflow)
573 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
575 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
577 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
579 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
581 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
583 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
585 GLYPH_CODE_FACE returns EMACS_INT, not int.
586 * dispextern.h (merge_faces):
587 * xfaces.c (merge_faces):
588 * xdisp.c (get_next_display_element, next_element_from_display_vector):
589 Don't assume EMACS_INT fits in int.
591 * character.h (CHAR_VALID_P): Remove unused parameter.
592 * fontset.c, lisp.h, xdisp.c: All uses changed.
594 * editfns.c (Ftranslate_region_internal): Omit redundant test.
596 * fns.c (concat): Minor tuning based on overflow analysis.
597 This doesn't fix any bugs. Use int to hold character, instead
598 of constantly refetching from Emacs object. Use XFASTINT, not
599 XINT, for value known to be a character. Don't bother comparing
600 a single byte to 0400, as it's always less.
602 * floatfns.c (Fexpt):
603 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
605 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
608 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
610 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
611 Without this fix, on a 64-bit host (aset S 0 4294967386) would
612 incorrectly succeed when S was a string, because 4294967386 was
613 truncated before it was used.
615 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
616 Otherwise, an out-of-range integer could cause undefined behavior
619 * composite.c: Use int, not EMACS_INT, for characters.
620 (fill_gstring_body, composition_compute_stop_pos): Use int, not
621 EMACS_INT, for values that are known to be in character range.
622 This doesn't fix any bugs but is the usual style inside Emacs and
623 may generate better code on 32-bit machines.
625 Make sure a 64-bit char is never passed to ENCODE_CHAR.
626 This is for reasons similar to the recent CHAR_STRING fix.
627 * charset.c (Fencode_char): Check that character arg is actually
628 a character. Pass an int to ENCODE_CHAR.
629 * charset.h (ENCODE_CHAR): Verify that the character argument is no
630 wider than 'int', as a compile-time check to prevent future regressions
633 * character.c (char_string): Remove unnecessary casts.
635 Make sure a 64-bit char is never passed to CHAR_STRING.
636 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
637 by silently ignoring the top 32 bits, allowing some values
638 that were far too large to be valid characters.
639 * character.h: Include <verify.h>.
640 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
641 arguments are no wider than unsigned, as a compile-time check
642 to prevent future regressions in this area.
644 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
645 (Fsubst_char_in_region):
647 * xdisp.c (decode_mode_spec_coding):
648 Adjust to CHAR_STRING's new requirement.
649 * editfns.c (Finsert_char, Fsubst_char_in_region):
650 * fns.c (concat): Check that character args are actually
651 characters. Without this test, these functions did the wrong
652 thing with wildly out-of-range values on 64-bit hosts.
654 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
655 These casts should not be needed on 32-bit hosts, either.
656 * keyboard.c (read_char):
657 * lread.c (Fload): Remove casts to unsigned.
659 * lisp.h (UNSIGNED_CMP): New macro.
660 This fixes comparison bugs on 64-bit hosts.
661 (ASCII_CHAR_P): Use it.
662 * casefiddle.c (casify_object):
663 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
664 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
665 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
666 * dispextern.h (FACE_FROM_ID):
667 * keyboard.c (read_char): Use UNSIGNED_CMP.
669 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
670 not to EMACS_INT, to avoid GCC warning.
672 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
674 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
675 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
676 isn't needed on 32-bit machines.
678 * buffer.c (Fgenerate_new_buffer_name):
679 Use EMACS_INT for count, not int.
680 (advance_to_char_boundary): Return EMACS_INT, not int.
682 * data.c (Qcompiled_function): Now static.
684 * window.c (window_body_lines): Now static.
686 * image.c (gif_load): Rename local to avoid shadowing.
688 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
689 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
690 * alloc.c (make_save_value): Integer argument is now of type
692 (mark_object): Use ptrdiff_t, not int.
693 * lisp.h (pD): New macro.
694 * print.c (print_object): Use it.
696 * alloc.c: Use EMACS_INT, not int, to count objects.
697 (total_conses, total_markers, total_symbols, total_vector_size)
698 (total_free_conses, total_free_markers, total_free_symbols)
699 (total_free_floats, total_floats, total_free_intervals)
700 (total_intervals, total_strings, total_free_strings):
701 Now EMACS_INT, not int. All uses changed.
702 (Fgarbage_collect): Compute overall total using a double, so that
703 integer overflow is less likely to be a problem. Check for overflow
704 when converting back to an integer.
705 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
706 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
707 These were 'int' variables that could overflow on 64-bit hosts;
708 they were never used, so remove them instead of repairing them.
709 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
710 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
711 Previously, this ceilinged at INT_MAX, but that doesn't work on
713 (allocate_pseudovector): Don't use EMACS_INT when int would do.
715 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
716 (allocate_vectorlike): Check for ptrdiff_t overflow.
717 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
718 when a (possibly-narrower) signed value would do just as well.
719 We prefer using signed arithmetic, to avoid comparison confusion.
721 * alloc.c: Catch some string size overflows that we were missing.
722 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
723 for convenience in STRING_BYTES_MAX.
724 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
725 The definition here is exact; the one in lisp.h was approximate.
726 (allocate_string_data): Check for string overflow. This catches
727 some instances we weren't catching before. Also, it catches
728 size_t overflow on (unusual) hosts where SIZE_MAX <= min
729 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
730 and ptrdiff_t and EMACS_INT are both 64 bits.
732 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
733 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
734 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
736 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
738 * alloc.c (Fmake_string): Check for out-of-range init.
740 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
742 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
744 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
746 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
747 xg_get_default_scrollbar_width.
749 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
750 (int_gtk_range_get_value): Move to the scroll bar part of the file.
751 (style_changed_cb): Call update_theme_scrollbar_width and call
752 x_set_scroll_bar_default_width and xg_frame_set_char_size for
753 all frames (Bug#8505).
754 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
755 Call gtk_window_set_resizable if HAVE_GTK3.
756 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
757 and height if HAVE_GTK3 (Bug#8505).
758 (scroll_bar_width_for_theme): New variable.
759 (update_theme_scrollbar_width): New function.
760 (xg_get_default_scrollbar_width): Move code to
761 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
762 (xg_initialize): Call update_theme_scrollbar_width.
764 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
766 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
768 2011-06-12 Martin Rudalics <rudalics@gmx.at>
770 * frame.c (make_frame): Call other_buffer_safely instead of
773 * window.c (temp_output_buffer_show): Call display_buffer with
774 second argument Vtemp_buffer_show_specifiers and reset latter
775 immediately after the call.
776 (Vtemp_buffer_show_specifiers): New variable.
777 (auto_window_vscroll_p, next_screen_context_lines)
778 (Vscroll_preserve_screen_position): Remove leading asterisks from
781 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
783 Fix minor problems found by GCC 4.6.0 static checking.
784 * buffer.c (Qclone_number): Remove for now, as it's unused.
785 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
786 (record_buffer): Remove unused local.
787 * frame.c (other_visible_frames, frame_buffer_list): Now static.
788 (set_frame_buffer_list): Remove; unused.
789 * frame.h (other_visible_frames): Remove decl.
790 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
791 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
792 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
794 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
795 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
796 Define only if HAVE_GPM.
797 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
798 (update_hints_inhibit): Remove; never set. All uses removed.
799 * widgetprv.h (emacsFrameClassRec): Remove decl.
800 * window.c (delete_deletable_window): Now returns void, since it
801 wasn't returning anything.
802 (compare_window_configurations): Remove unused locals.
803 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
804 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
805 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
806 the same widths as pointers. This follows up on the 2011-05-06 patch.
807 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
809 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
811 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
813 * makefile.w32-in: Update dependencies.
814 (LISP_H): Add lib/intprops.h.
816 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
818 * image.c (gif_load): Add animation frame delay to the metadata.
819 (syms_of_image): Use DEFSYM. New symbol `delay'.
821 2011-06-11 Martin Rudalics <rudalics@gmx.at>
823 * window.c (delete_deletable_window): Re-add.
824 (Fset_window_configuration): Rewrite to handle dead buffers and
825 consequently deletable windows.
826 (window_tree, Fwindow_tree): Remove. Supply functionality in
828 (compare_window_configurations): Simplify code.
830 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
832 * image.c (imagemagick_load_image): Fix type mismatch.
833 (Fimagemagick_types): Likewise.
835 * window.h (replace_buffer_in_windows): Declare.
837 2011-06-11 Martin Rudalics <rudalics@gmx.at>
839 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
840 Qclone_number. Remove external declaration of Qdelete_window.
841 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
843 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
844 Qbuffer_list_update_hook if allowed.
845 (Fother_buffer): Rewrite doc-string. Major rewrite for new
846 buffer list implementation.
847 (other_buffer_safely): New function.
848 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
849 calls to replace_buffer_in_windows and
850 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
852 (record_buffer): Inhibit quitting and rewrite using quittable
853 functions. Run Qbuffer_list_update_hook if allowed.
854 (Frecord_buffer, Funrecord_buffer): New functions.
855 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
856 switch-to-buffer to window.el.
857 (bury-buffer): Move to window.el.
858 (Vbuffer_list_update_hook): New variable.
860 * lisp.h (other_buffer_safely): Add prototype in buffer.c
863 * window.h (resize_frame_windows): Move up in code.
864 (Fwindow_frame): Remove EXFUN.
865 (replace_buffer_in_all_windows): Remove prototype.
866 (replace_buffer_in_windows_safely): Add prototype.
868 * window.c: Declare Qdelete_window static again. Move down
869 declaration of select_count.
870 (Fnext_window, Fprevious_window): Rewrite doc-strings.
871 (Fother_window): Move to window.el.
872 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
873 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
874 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
876 (replace_buffer_in_windows): Implement by calling
877 Qreplace_buffer_in_windows.
878 (replace_buffer_in_all_windows): Remove with some functionality
879 moved into replace_buffer_in_windows_safely.
880 (replace_buffer_in_windows_safely): New function.
881 (select_window_norecord, select_frame_norecord): Move in front
882 of run_window_configuration_change_hook. Remove now obsolete
884 (Fset_window_buffer): Rewrite doc-string. Call
885 Qrecord_window_buffer.
886 (keys_of_window): Move binding for other-window to window.el.
888 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
890 * dispextern.h (struct image): Replace data member, whose int_val
891 and ptr_val fields were not used by anything, with a single
894 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
895 (gif_clear_image, gif_load, imagemagick_load_image)
896 (gs_clear_image, gs_load): Callers changed.
898 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
900 * buffer.h: Include <time.h>, for time_t.
901 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
903 Fix minor problems found by static checking.
905 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
907 Make identifiers static if they are not used in other modules.
908 * data.c (Qcompiled_function, Qframe, Qvector):
909 * image.c (QimageMagick, Qsvg):
910 * minibuf.c (Qmetadata):
911 * window.c (resize_window_check, resize_root_window): Now static.
912 * window.h (resize_window_check, resize_root_window): Remove decls.
914 * window.c (window_deletion_count, delete_deletable_window):
916 (window_body_lines): Now static.
917 (Fdelete_other_windows_internal): Mark vars as initialized.
918 Make sure 'resize_failed' is initialized.
919 (run_window_configuration_change_hook): Rename local to avoid shadowing.
920 (resize_window_apply): Remove unused local.
921 * window.h (delete_deletable_window): Remove decl.
923 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
924 (imagemagick_load_image): Fix pointer signedness problem by changing
925 last arg from unsigned char * to char *. All uses changed.
926 Also, fix a local for similar reasons.
927 Remove unused locals. Remove locals to avoid shadowing.
928 (fn_rsvg_handle_free): Remove; unused.
929 (svg_load, svg_load_image): Fix pointer signedness problem.
930 (imagemagick_load_image): Don't use garbage pointer image_wand.
932 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
934 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
936 * image.c (gif_load): Fix omitted cast error introduced by
939 2011-06-10 Martin Rudalics <rudalics@gmx.at>
941 * window.h (resize_proportionally, orig_total_lines)
942 (orig_top_line): Remove from window structure.
943 (set_window_height, set_window_width, change_window_heights)
944 (Fdelete_window): Remove prototypes.
945 (resize_frame_windows): Remove duplicate declaration.
947 2011-06-10 Eli Zaretskii <eliz@gnu.org>
949 * window.h (resize_frame_windows, resize_window_check)
950 (delete_deletable_window, resize_root_window)
951 (resize_frame_windows): Declare prototypes.
953 * window.c (resize_window_apply): Make definition be "static" to
956 2011-06-10 Martin Rudalics <rudalics@gmx.at>
958 * window.c: Remove declarations of Qwindow_size_fixed,
959 window_min_size_1, window_min_size_2, window_min_size,
960 size_window, window_fixed_size_p, enlarge_window, delete_window.
961 Remove static from declaration of Qdelete_window, it's
962 temporarily needed by Fbury_buffer.
963 (replace_window): Don't assign orig_top_line and
965 (Fdelete_window, delete_window): Remove. Window deletion is
966 handled by window.el.
967 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
968 Fdelete_window calls with calls to Qdelete_window.
969 (Fdelete_other_windows): Remove. Deleting other windows is
970 handled by window.el.
971 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
972 handled in window.el.
973 (window_min_size_2, window_min_size_1, window_min_size): Remove.
974 Window minimum sizes are handled in window.el.
975 (shrink_windows, size_window, set_window_height)
976 (set_window_width, change_window_heights, window_height)
977 (window_width, CURBEG, CURSIZE, enlarge_window)
978 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
979 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
980 handled in window.el.
981 (make_dummy_parent): Rename to make_parent_window and give it a
982 second argument horflag.
983 (make_window): Don't set resize_proportionally any more.
984 (Fsplit_window): Remove. Windows are split in window.el.
985 (save_restore_action, save_restore_orig_size)
986 (shrink_window_lowest_first, save_restore_orig_size): Remove.
987 Resize mini windows in window.el.
988 (grow_mini_window, shrink_mini_window): Implement by calling
989 Qresize_root_window_vertically, resize_window_check and
991 (saved_window, Fset_window_configuration, save_window_save): Do
992 not handle orig_top_line, orig_total_lines, and
993 resize_proportionally.
994 (window_min_height, window_min_width): Move to window.el.
995 (keys_of_window): Move bindings for delete-other-windows,
996 split-window, delete-window and enlarge-window to window.el.
998 * buffer.c: Temporarily extern Qdelete_window.
999 (Fbury_buffer): Temporarily call Qdelete_window instead of
1000 Fdelete_window (Fbury_buffer will move to window.el soon).
1002 * frame.c (set_menu_bar_lines_1): Remove code handling
1003 orig_top_line and orig_total_lines.
1005 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1006 set_window_height but set heights directly.
1007 (change_frame_size_1): Use resize_frame_windows.
1009 * xdisp.c (init_xdisp): Don't use set_window_height but set
1012 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1013 resize_frame_windows instead of change_window_heights and run
1014 run_window_configuration_change_hook.
1016 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1017 instead of change_window_heights and run
1018 run_window_configuration_change_hook.
1020 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1022 * window.c (replace_window): Rename second argument REPLACEMENT to
1023 NEW. New third argument SETFLAG. Rewrite.
1024 (delete_window, make_dummy_parent): Call replace_window with
1026 (window_list_1): Move down in code.
1027 (run_window_configuration_change_hook): Move set_buffer part
1028 before select_frame_norecord part in order to unwind correctly.
1029 Rename count1 to count.
1030 (recombine_windows, delete_deletable_window, resize_root_window)
1031 (Fdelete_other_windows_internal)
1032 (Frun_window_configuration_change_hook, make_parent_window)
1033 (resize_window_check, resize_window_apply, Fresize_window_apply)
1034 (resize_frame_windows, Fsplit_window_internal)
1035 (Fdelete_window_internal, Fresize_mini_window_internal): New
1037 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1039 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1041 * window.h (window): Add some new members to window structure -
1042 normal_lines, normal_cols, new_total, new_normal, clone_number,
1043 splits, nest, prev_buffers, next_buffers.
1044 (WINDOW_TOTAL_SIZE): Move here from window.c.
1045 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1047 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1049 (make_dummy_parent): Set new members of windows structure.
1050 (make_window): Move down in code. Handle new members of window
1052 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1053 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1054 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1055 (Fset_window_prev_buffers, Fwindow_next_buffers)
1056 (Fset_window_next_buffers, Fset_window_clone_number): New
1058 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1059 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1061 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1062 Argument WINDOW can be now internal window too.
1063 (Fwindow_use_time): Move up in code.
1064 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1066 (Fset_window_configuration, saved_window)
1067 (Fcurrent_window_configuration, save_window_save): Handle new
1068 members of window structure.
1069 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1070 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1071 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1072 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1073 Qget_mru_window, Qresize_root_window,
1074 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1075 Qauto_buffer_name; staticpro them.
1077 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1079 * window.c (Fwindow_total_size, Fwindow_left_column)
1080 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1081 (Fwindow_list_1): New functions.
1082 (window_box_text_cols): Replace with window_body_cols.
1083 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1084 window_body_cols instead of window_box_text_cols.
1085 (delete_window, Fset_window_configuration): Call
1086 delete_all_subwindows with window as argument.
1087 (delete_all_subwindows): Take a window as argument and not a
1089 (window_loop): Remove handling of GET_LRU_WINDOW and
1091 (Fget_lru_window, Fget_largest_window): Move to window.el.
1093 * window.h: Extern window_body_cols instead of
1094 window_box_text_cols. delete_all_subwindows now takes a
1095 Lisp_Object as argument.
1097 * indent.c (compute_motion, Fcompute_motion): Use
1098 window_body_cols instead of window_box_text_cols.
1100 * frame.c (delete_frame): Call delete_all_subwindows with root
1103 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1105 * fns.c (Fputhash): Document return value.
1107 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1109 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1111 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1113 Cons<->int and similar integer overflow fixes (Bug#8794).
1115 Check for overflow when converting integer to cons and back.
1116 * charset.c (Fdefine_charset_internal, Fdecode_char):
1117 Use cons_to_unsigned to catch overflow.
1118 (Fencode_char): Use INTEGER_TO_CONS.
1119 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1120 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1121 * data.c (long_to_cons, cons_to_long): Remove.
1122 (cons_to_unsigned, cons_to_signed): New functions.
1123 These signal an error for invalid or out-of-range values.
1124 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1125 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1126 * font.c (Ffont_variation_glyphs):
1127 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1128 * lisp.h: Include <intprops.h>.
1129 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1130 (cons_to_signed, cons_to_unsigned): New decls.
1131 (long_to_cons, cons_to_long): Remove decls.
1132 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1133 (Fprimitive_undo): Use CONS_TO_INTEGER.
1134 * xfns.c (Fx_window_property): Likewise.
1135 * xselect.c: Include <limits.h>.
1136 (x_own_selection, selection_data_to_lisp_data):
1137 Use INTEGER_TO_CONS.
1138 (x_handle_selection_request, x_handle_selection_clear)
1139 (x_get_foreign_selection, Fx_disown_selection_internal)
1140 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1141 (lisp_data_to_selection_data): Use cons_to_unsigned.
1142 (x_fill_property_data): Use cons_to_signed.
1143 Report values out of range.
1145 Check for buffer and string overflow more precisely.
1146 * buffer.h (BUF_BYTES_MAX): New macro.
1147 * lisp.h (STRING_BYTES_MAX): New macro.
1148 * alloc.c (Fmake_string):
1149 * character.c (string_escape_byte8):
1150 * coding.c (coding_alloc_by_realloc):
1151 * doprnt.c (doprnt):
1152 * editfns.c (Fformat):
1154 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1155 since they may not be the same number.
1156 * editfns.c (Finsert_char):
1157 * fileio.c (Finsert_file_contents):
1158 Likewise for BUF_BYTES_MAX.
1160 * image.c: Use ptrdiff_t, not int, for sizes.
1161 (slurp_file): Switch from int to ptrdiff_t.
1163 (slurp_file): Check that file size fits in both size_t (for
1164 malloc) and ptrdiff_t (for sanity and safety).
1166 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1167 if b->modtime has its maximal value.
1169 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1171 Don't assume time_t can fit into int.
1172 * buffer.h (struct buffer.modtime): Now time_t, not int.
1173 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1174 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1176 Minor fixes for signed vs unsigned integers.
1177 * character.h (MAYBE_UNIFY_CHAR):
1178 * charset.c (maybe_unify_char):
1179 * keyboard.c (read_char, reorder_modifiers):
1180 XINT -> XFASTINT, since the integer must be nonnegative.
1181 * ftfont.c (ftfont_spec_pattern):
1182 * keymap.c (access_keymap, silly_event_symbol_error):
1183 XUINT -> XFASTINT, since the integer must be nonnegative.
1184 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1185 since it makes no difference and we prefer signed.
1186 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1187 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1190 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1192 * window.h (Fwindow_frame): Declare.
1194 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1196 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1197 (SPARE_MEMORY): Always define.
1198 (LARGE_REQUEST): Remove.
1199 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1201 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1203 * lisp.h: Move EXFUNS for Fframe_root_window,
1204 Fframe_first_window and Fset_frame_selected_window to window.h.
1206 * window.h: Move EXFUNS for Fframe_root_window,
1207 Fframe_first_window and Fset_frame_selected_window here from
1210 * frame.c (Fwindow_frame, Fframe_first_window)
1211 (Fframe_root_window, Fframe_selected_window)
1212 (Fset_frame_selected_window): Move to window.c.
1213 (Factive_minibuffer_window): Move to minibuf.c.
1214 (Fother_visible_frames_p): New function.
1216 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1218 * window.c (decode_window, decode_any_window): Move up in code.
1219 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1220 (inhibit_frame_unsplittable): Remove unused variable.
1221 (Fwindow_buffer): Move up and rewrite doc-string.
1222 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1223 (Fwindow_prev): New functions.
1224 (Fwindow_frame): Move here from frame.c. Accept any window as
1226 (Fframe_root_window, Fframe_first_window)
1227 (Fframe_selected_window): Move here from frame.c. Accept frame
1228 or arbitrary window as argument. Update doc-strings.
1229 (Fminibuffer_window): Move up in code.
1230 (Fwindow_minibuffer_p): Move up in code and simplify.
1231 (Fset_frame_selected_window): Move here from frame.c.
1233 (Fselected_window, select_window, Fselect_window): Move up in
1234 code. Minor doc-string fixes.
1236 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1238 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1239 Do not assume that spare memory exists; that assumption is valid
1240 only if SYSTEM_MALLOC.
1241 (LARGE_REQUEST): New macro, so that the issue of large requests
1242 is separated from the issue of spare memory.
1244 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1246 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1249 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1251 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1254 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1256 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1258 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1260 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1261 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1263 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1265 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1267 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1269 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1270 (x_clipboard_manager_save): Add return value.
1271 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1273 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1274 Obey Vx_select_enable_clipboard_manager. Catch errors in
1275 x_clipboard_manager_save (Bug#8779).
1276 (Vx_select_enable_clipboard_manager): New variable.
1277 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1279 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1281 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1283 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1285 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1286 in the current matrix if keep_current_p is non-zero.
1288 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1290 * bidi.c (bidi_level_of_next_char): Fix last change.
1292 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1294 Support bidi reordering of text covered by display properties.
1296 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1297 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1298 (bidi_cache_search, bidi_cache_iterator_state)
1299 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1300 (bidi_level_of_next_char, bidi_move_to_visually_next):
1301 Support character positions inside a run of characters covered by a
1303 (bidi_paragraph_init, bidi_resolve_explicit_1)
1304 (bidi_level_of_next_char): Call bidi_fetch_char and
1305 bidi_fetch_char_advance instead of FETCH_CHAR and
1307 (bidi_init_it): Initialize new members.
1308 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1310 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1311 instead of using explicit *_CHAR codes.
1312 (bidi_resolve_explicit, bidi_resolve_weak):
1313 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1314 bidirectional text is supported only in multibyte buffers.
1315 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1316 it to initialize the frame_window_p member of struct bidi_it.
1317 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1318 (bidi_resolve_explicit, bidi_resolve_weak)
1319 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1320 bidi_it->nchars is non-positive.
1321 (bidi_level_of_next_char): Don't try to lookup the cache for the
1322 next/previous character if nothing is cached there yet, or if we
1323 were just reseat()'ed to a new position.
1325 * xdisp.c (set_cursor_from_row): Set start and stop points
1326 according to the row's direction when priming the loop that looks
1327 for the glyph on which to display cursor.
1328 (single_display_spec_intangible_p): Function deleted.
1329 (display_prop_intangible_p): Reimplement to call
1330 handle_display_spec instead of single_display_spec_intangible_p.
1331 Accept 3 additional arguments needed by handle_display_spec.
1332 This fixes incorrect cursor motion across display property with complex
1333 values: lists, `(when COND...)' forms, etc.
1334 (single_display_spec_string_p): Support property values that are
1335 lists with the argument STRING its top-level element.
1336 (display_prop_string_p): Fix the condition for processing a
1337 property that is a list to be consistent with handle_display_spec.
1338 (handle_display_spec): New function, refactored from the
1339 last portion of handle_display_prop.
1340 (compute_display_string_pos): Accept additional argument
1341 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1342 value of a `display' property is a "replacing spec".
1343 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1344 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1345 the display property, but just return a value indicating whether
1346 the display property will replace the characters it covers.
1347 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1348 frame_window_p members of struct bidi_it.
1349 (compute_display_string_pos, compute_display_string_end):
1351 (push_it): Accept second argument POSITION, where pop_it should
1352 jump to continue iteration.
1353 (reseat_1): Initialize bidi_it.disp_pos.
1355 * keyboard.c (adjust_point_for_property): Adjust the call to
1356 display_prop_intangible_p to its new signature.
1358 * dispextern.h (struct bidi_it): New member frame_window_p.
1359 (bidi_init_it): Update prototypes.
1360 (display_prop_intangible_p): Update prototype.
1361 (compute_display_string_pos, compute_display_string_end):
1363 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1366 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1368 Malloc failure behavior now depends on size of allocation.
1369 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1370 * lisp.h: Change signatures accordingly.
1371 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1372 All callers changed. (Bug#8762)
1374 * gnutls.c: Use Emacs's memory allocators.
1375 Without this change, the gnutls library would invoke malloc etc.
1376 directly, which causes problems on non-SYNC_INPUT hosts, and which
1377 runs afoul of improving memory_full behavior. (Bug#8761)
1378 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1379 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1380 xfree instead of the default malloc, realloc, free.
1381 (Fgnutls_boot): No need to check for memory allocation failure,
1382 since xmalloc does that for us.
1384 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1385 * category.c (hash_get_category_set):
1386 * ccl.c (ccl_driver):
1387 * charset.c (Fdefine_charset_internal):
1388 * charset.h (struct charset.hash_index):
1389 * composite.c (get_composition_id, gstring_lookup_cache)
1390 (composition_gstring_put_cache):
1391 * composite.h (struct composition.hash_index):
1392 * dispextern.h (struct image.hash):
1393 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1394 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1395 (hashfn_equal, hashfn_user_defined, make_hash_table)
1396 (maybe_resize_hash_table, hash_lookup, hash_put)
1397 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1398 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1399 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1400 * image.c (make_image, search_image_cache, lookup_image)
1401 (xpm_put_color_table_h):
1402 * lisp.h (struct Lisp_Hash_Table):
1403 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1404 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1405 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1406 * alloc.c (allocate_vectorlike):
1407 Check for overflow in vector size calculations.
1408 * ccl.c (ccl_driver):
1409 Check for overflow when converting EMACS_INT to int.
1410 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1411 need to be updated by these changes.
1412 * fns.c (make_hash_table, maybe_resize_hash_table):
1413 Check for integer overflow with large hash tables.
1414 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1415 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1416 (SXHASH_REDUCE): New macro.
1417 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1418 Use it instead of discarding useful hash info with large hash values.
1419 (sxhash_float): New function.
1420 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1421 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1422 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1423 Rewrite to use FIXNUM_BITS, as this simplifies things.
1424 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1425 Adjust signatures to match updated version of code.
1426 (consing_since_gc): Now EMACS_INT, since a single hash table can
1427 use more than INT_MAX bytes.
1429 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1431 Make it possible to build with GCC-4.6+ -O2 -flto.
1433 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1435 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1437 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1438 Call minibuffer-inactive-mode.
1440 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1442 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1443 Update dependencies.
1445 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1447 * data.c (init_data): Remove code for UTS, this system is not
1450 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1452 Don't force ./temacs to start in terminal mode.
1454 * frame.c (make_initial_frame): Initialize faces in all cases, not
1455 only when CANNOT_DUMP is defined.
1456 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1458 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1460 * dispnew.c (add_window_display_history): Use const for the string
1461 pointer. Remove declaration, not needed.
1463 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1465 Use 'inline', not 'INLINE'.
1466 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1467 * alloc.c, fontset.c (INLINE): Remove.
1468 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1469 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1470 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1471 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1472 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1474 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1476 Make it possible to run ./temacs.
1478 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1479 syms_of_callproc does the same thing. Remove test for
1480 "initialized", do it in the caller.
1481 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1483 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1485 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1486 (read_minibuf): Use get_minibuffer.
1487 (syms_of_minibuf): Use DEFSYM.
1488 (Qmetadata): New var.
1489 * data.c (Qbuffer): Don't make it static.
1490 (syms_of_data): Use DEFSYM.
1492 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1494 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1495 (CCL_CODE_MIN): New macro.
1497 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1499 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1501 * eval.c (Qdebug): Now static.
1502 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1503 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1504 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1506 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1508 * image.c: Various fixes to ImageMagick code comments.
1509 (Fimagemagick_types): Doc fix.
1511 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1513 Minor fixes prompted by GCC 4.6.0 warnings.
1515 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1517 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1518 (x_clipboard_manager_save_all): Move extern decl to ...
1519 * xterm.h: ... here, so that it can be checked for consistency.
1521 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1523 * xselect.c (x_clipboard_manager_save_frame)
1524 (x_clipboard_manager_save_all): New functions.
1525 (Fx_clipboard_manager_save): Lisp function deleted.
1527 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1528 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1530 * xterm.h: Update prototype.
1532 2011-05-28 William Xu <william.xwl@gmail.com>
1534 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1537 2011-05-28 Jim Meyering <meyering@redhat.com>
1539 Avoid a sign-extension bug in crypto_hash_function.
1540 * fns.c (to_uchar): Define.
1541 (crypto_hash_function): Use it to convert some newly-signed
1542 variables to unsigned, to avoid sign-extension bugs. For example,
1543 without this change, (md5 "truc") would evaluate to
1544 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1545 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1546 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1548 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1550 Integer overflow fixes.
1552 * dbusbind.c: Serial number integer overflow fixes.
1553 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1554 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1555 to hold a serial number that is too large for a fixnum.
1556 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1557 Check for serial numbers out of range. Decode any serial number
1558 that was so large that it became a float. (Bug#8722)
1560 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1561 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1562 Use XFASTINT rather than XUINT when numbers are nonnegative.
1563 (xd_append_arg, Fdbus_method_return_internal):
1564 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1565 arguments, check that Lisp number is nonnegative, rather than
1566 silently wrapping negative numbers around. (Bug#8722)
1567 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1570 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1572 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1574 ccl: add integer overflow checks
1575 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1576 (IN_INT_RANGE): New macros.
1577 (ccl_driver): Use them to check for integer overflow when
1578 decoding a CCL program. Many of the new checks are whether XINT (x)
1579 fits in int; it doesn't always, on 64-bit hosts. The new version
1580 doesn't catch all possible integer overflows, but it's an
1581 improvement. (Bug#8719)
1583 * alloc.c (make_event_array): Use XINT, not XUINT.
1584 There's no need for unsigned here.
1586 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1587 This follows up to the 2011-05-06 change that substituted uintptr_t
1588 for EMACS_INT. This case wasn't caught back then.
1590 Rework Fformat to avoid integer overflow issues.
1591 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1592 now (part of C89). Include <verify.h>.
1593 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1594 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1595 (Fformat): Avoid the prepass trying to compute sizes; it was only
1596 approximate and thus did not catch overflow reliably. Instead, walk
1597 through the format just once, formatting and computing sizes as we go,
1598 checking for integer overflow at every step, and allocating a larger
1599 buffer as needed. Keep track separately whether the format is
1600 multibyte. Keep only the most-recently calculated precision, rather
1601 than them all. Record whether each argument has been converted to
1602 string. Use EMACS_INT, not int, for byte and char and arg counts.
1603 Support field widths and precisions larger than INT_MAX. Avoid
1604 sprintf's undefined behavior with conversion specifications such as %#d
1605 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1606 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1607 formatting out-of-range floating point numbers with int
1610 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1612 * data.c: Avoid integer truncation in expressions involving floats.
1613 * data.c: Include <intprops.h>.
1614 (arith_driver): When there's an integer overflow in an expression
1615 involving floating point, convert the integers to floating point
1616 so that the resulting value does not suffer from catastrophic
1617 integer truncation. For example, on a 64-bit host (* 4
1618 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1619 Do not rely on undefined behavior after integer overflow.
1621 merge count_size_as_multibyte, parse_str_to_multibyte
1622 * character.c, character.h (count_size_as_multibyte):
1623 Rename from parse_str_to_multibyte; all uses changed.
1624 Check for integer overflow.
1625 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1626 since it's now a duplicate of the other. This is more of
1627 a character than a buffer op, so better that it's in character.c.
1628 * fns.c, print.c: Adjust to above changes.
1630 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1632 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1634 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1636 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1637 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1638 (x_clipboard_manager_save): Now static.
1639 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1641 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1642 (crypto_hash_function): Now static.
1643 Fix pointer signedness problems. Avoid unnecessary initializations.
1645 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1647 * termhooks.h (Vselection_alist): Make it terminal-local.
1649 * terminal.c (create_terminal): Initialize it.
1651 * xselect.c: Support for clipboard managers.
1652 (Vselection_alist): Move to termhooks.h as terminal-local var.
1653 (LOCAL_SELECTION): New macro.
1654 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1655 (symbol_to_x_atom): Remove gratuitous arg.
1656 (x_handle_selection_request, lisp_data_to_selection_data)
1657 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1658 (x_own_selection, x_get_local_selection, x_convert_selection):
1659 New arg, specifying work frame. Use terminal-local Vselection_alist.
1660 (some_frame_on_display): Delete unused function.
1661 (Fx_own_selection_internal, Fx_get_selection_internal)
1662 (Fx_disown_selection_internal, Fx_selection_owner_p)
1663 (Fx_selection_exists_p): New optional frame arg.
1664 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1665 (x_handle_selection_clear): Don't treat other terminals with the
1666 same keyboard specially. Use the terminal-local Vselection_alist.
1667 (x_clear_frame_selections): Use Frun_hook_with_args.
1669 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1671 * xterm.h: Add support for those atoms.
1673 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1675 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1676 (converted_selections, conversion_fail_tag): New global variables.
1677 (x_selection_request_lisp_error): Free the above.
1678 (x_get_local_selection): Remove unnecessary code.
1679 (x_reply_selection_request): Args changed; handle arbitrary array
1680 of converted selections stored in converted_selections.
1681 Separate the XChangeProperty and SelectionNotify steps.
1682 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1683 (x_convert_selection): New function.
1684 (x_handle_selection_event): Simplify.
1685 (x_get_foreign_selection): Don't ignore incoming requests while
1686 waiting for an answer; this will fail when we implement
1687 SAVE_TARGETS, and seems unnecessary anyway.
1688 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1689 (Vx_sent_selection_functions): Doc fix.
1691 2011-05-26 Leo Liu <sdl.web@gmail.com>
1693 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1695 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1697 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1699 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1700 for fringe update if it has periodic bitmap.
1701 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1702 and fringe_bitmap_periodic_p.
1704 * fringe.c (get_fringe_bitmap_data): New function.
1705 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1706 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1707 row. Mark glyph row for fringe update if periodicity changed.
1709 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1710 for fringe update unless it has periodic bitmap.
1712 2011-05-25 Kenichi Handa <handa@m17n.org>
1714 * xdisp.c (get_next_display_element): Set correct it->face_id for
1715 a static composition.
1717 2011-05-24 Leo Liu <sdl.web@gmail.com>
1720 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1722 * fns.c (crypto_hash_function, Fsha1): New function.
1723 (Fmd5): Use crypto_hash_function.
1724 (syms_of_fns): Add Ssha1.
1726 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1728 * gnutls.c: Remove unused macros.
1729 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1730 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1731 Remove macros that are defined and never used.
1732 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1734 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1736 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1737 (Fx_get_selection_internal): Minor cleanup.
1738 (Fx_own_selection_internal): Rename arguments for consistency with
1741 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1743 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1745 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1747 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1749 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1751 * dispnew.c (scrolling_window): Don't exclude the case that the
1752 last enabled row in the desired matrix touches the bottom boundary.
1754 2011-05-21 Glenn Morris <rgm@gnu.org>
1756 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1757 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1758 and add some more files.
1760 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1762 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1763 report_file_error introduced by the change from 2011-05-07.
1765 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1767 * systime.h (Time): Define only if emacs is defined.
1768 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1769 where the include path doesn't have X11/X.h by default. See
1770 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1772 2011-05-20 Kenichi Handa <handa@m17n.org>
1774 * composite.c (find_automatic_composition): Fix previous change.
1776 2011-05-20 Glenn Morris <rgm@gnu.org>
1778 * lisp.mk: New file, split from Makefile.in.
1779 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1780 (shortlisp): Remove.
1781 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1783 2011-05-19 Glenn Morris <rgm@gnu.org>
1785 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1786 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1787 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1788 (lisp): Set the order to that of loadup.el.
1789 (shortlisp): Make it a copy of $lisp.
1790 (SOME_MACHINE_LISP): Remove.
1791 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1792 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1794 2011-05-18 Kenichi Handa <handa@m17n.org>
1796 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1797 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1798 (find_automatic_composition): Mostly rewrite for efficiency.
1800 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1802 * makefile.w32-in: Update dependencies.
1804 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1806 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1807 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1809 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1811 Fix some integer overflow issues, such as string length overflow.
1813 * insdel.c (count_size_as_multibyte): Check for string overflow.
1815 * character.c (lisp_string_width): Check for string overflow.
1816 Use EMACS_INT, not int, for string indexes and lengths; in
1817 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1818 the resulting string length overflows an EMACS_INT; instead,
1819 report a string overflow if no precision given. When checking for
1820 precision exhaustion, use a check that cannot possibly have
1821 integer overflow. (Bug#8675)
1822 * character.h (lisp_string_width): Adjust to new signature.
1824 * alloc.c (string_overflow): New function.
1825 (Fmake_string): Use it. This doesn't change behavior, but saves
1826 a few bytes and will simplify future changes.
1827 * character.c (string_escape_byte8): Likewise.
1828 * lisp.h (string_overflow): New decl.
1830 Fixups, following up to the user-interface timestamp change.
1831 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1832 for UI timestamps, instead of unsigned long.
1833 * msdos.c (mouse_get_pos): Likewise.
1834 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1835 * w32gui.h (Time): Define by including "systime.h" rather than by
1836 declaring it ourselves. (Bug#8664)
1838 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1839 * image.c (clear_image_cache): Likewise.
1841 * term.c (term_mouse_position): Don't assume time_t wraparound.
1843 Be more systematic about user-interface timestamps.
1844 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1845 and sometimes 'EMACS_UINT', to represent these timestamps.
1846 This change causes it to use 'Time' uniformly, as that's what X uses.
1847 This makes the code easier to follow, and makes it easier to catch
1848 integer overflow bugs such as Bug#8664.
1849 * frame.c (Fmouse_position, Fmouse_pixel_position):
1850 Use Time, not unsigned long, for user-interface timestamps.
1851 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1852 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1853 * keyboard.h (last_event_timestamp): Likewise.
1854 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1855 * menu.h (xmenu_show): Likewise.
1856 * term.c (term_mouse_position): Likewise.
1857 * termhooks.h (struct input_event.timestamp): Likewise.
1858 (struct terminal.mouse_position_hook): Likewise.
1859 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1860 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1861 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1862 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1864 * menu.h, termhooks.h: Include "systime.h", for Time.
1866 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1867 Don't assume that the difference between two unsigned long values
1868 can fit into an integer. At this point, we know button_down_time
1869 <= event->timestamp, so the difference must be nonnegative, so
1870 there's no need to cast the result if double-click-time is
1871 nonnegative, as it should be; check that it's nonnegative, just in
1872 case. This bug is triggered when events are more than 2**31 ms
1873 apart (about 25 days). (Bug#8664)
1875 * xselect.c (last_event_timestamp): Remove duplicate decl.
1876 (x_own_selection): Remove needless cast to unsigned long.
1878 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1879 that always fit in int. Use a sentinel instead of a counter, to
1880 avoid a temp and to allay GCC's concerns about possible int overflow.
1881 * frame.h (struct frame): Use int for menu_bar_items_used
1882 instead of EMACS_INT, since it always fits in int.
1884 * menu.c (grow_menu_items): Check for int overflow.
1886 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1888 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1889 Before, the code was not consistent. These values cannot exceed
1890 2**31 - 1 so there's no need to make them unsigned.
1891 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1892 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1893 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1895 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1897 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1898 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1899 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1900 presumably because the widths might not match.
1902 * window.c (size_window): Avoid needless test at loop start.
1904 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1906 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1908 2011-05-12 Drew Adams <drew.adams@oracle.com>
1910 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1912 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1914 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1915 `width' to `bar_area_x' and `bar_area_width', respectively.
1916 (x_scroll_run): Take account of fringe background extension.
1918 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1919 Rename local vars `left' and `width' to `bar_area_x' and
1920 `bar_area_width', respectively.
1921 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1922 background extension.
1924 2011-05-10 Jim Meyering <meyering@redhat.com>
1926 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1928 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1930 * image.c (Finit_image_library): Return t for built-in image types,
1931 like pbm and xbm. (Bug#8640)
1933 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1935 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1937 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1939 * w32console.c (Fset_screen_color): Doc fix.
1940 (Fget_screen_color): New function.
1941 (syms_of_ntterm): Defsubr it.
1943 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1944 unlink the temporary file if Fcall_process didn't create it in the
1946 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1947 child process will be redirected to a file specified with `:file'.
1948 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1949 cue to call_process_cleanup not to close that handle.
1951 2011-05-07 Ben Key <bkey76@gmail.com>
1953 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1954 one of two shell specific rules, either bootstrap-temacs-CMD or
1955 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1956 to the previous implementation of the bootstrap-temacs rule.
1957 The bootstrap-temacs-CMD rule is similar to the previous
1958 implementation of the bootstrap-temacs rule except that it
1959 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1962 These changes, along with some changes to nt/configure.bat,
1963 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1964 earlier fix to add support for --cflags and --ldflags options
1965 that include quotes so that it works whether make uses cmd or
1968 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1970 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1971 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1973 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1974 a string. Handle both cases.
1975 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1976 (Fdbus_register_method): Use Qinvalid_function.
1978 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1980 * makefile.w32-in: Update dependencies.
1981 (LISP_H): Add inttypes.h and stdin.h.
1982 (PROCESS_H): Add unistd.h.
1984 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1986 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1987 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1989 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1991 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1993 * term.c (vfatal): Remove stray call to va_end.
1994 It's not needed and the C Standard doesn't allow it here anyway.
1996 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1997 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1999 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2002 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2004 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2006 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2008 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2010 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2012 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2013 * charset.c (Fdefine_charset_internal): Don't initialize
2014 charset.code_space[15]. The value was garbage, on hosts with
2015 32-bit int (Bug#8600).
2017 * lread.c (read_integer): Be more consistent with string-to-number.
2018 Use string_to_number to do the actual conversion; this avoids
2019 rounding errors and fixes some other screwups. Without this fix,
2020 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2021 (digit_to_number): Move earlier, for benefit of read_integer.
2022 Return -1 if the digit is out of range for the base, -2 if it is
2023 not a digit in any supported base. (Bug#8602)
2025 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2027 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2028 to match comment at start of function. This also removes a
2029 GCC warning about overflow in a 32+64-bit port.
2031 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2033 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2034 Reported by Stefan Monnier in
2035 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2036 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2037 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2039 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2040 (EMACS_UINTPTR): Likewise, with uintptr_t.
2042 * lisp.h: Prefer 64-bit EMACS_INT if available.
2043 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2044 on 32-bit hosts that have 64-bit int, so that they can access
2046 However, temporarily disable this change unless the temporary
2047 symbol WIDE_EMACS_INT is defined.
2049 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2051 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2052 This removes an assumption that EMACS_INT and long are the same
2053 width as pointers. The assumption is true for Emacs porting targets
2054 now, but we want to make other targets possible.
2055 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2056 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2057 In the rest of the code, change types of integers that hold casted
2058 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2059 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2060 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2061 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2062 No need to cast type when ORing.
2063 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2064 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2065 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2066 assume EMACS_INT is the same width as char *.
2067 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2068 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2069 Remove no-longer-needed casts.
2070 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2071 (xg_tool_bar_help_callback, xg_make_tool_item):
2072 Use EMACS_INTPTR to hold an integer
2073 that will be cast to void *; this can avoid a GCC warning
2074 if EMACS_INT is not the same width as void *.
2075 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2076 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2077 (current_message_1, set_message_1):
2078 Use a local to convert to proper width without a cast.
2079 * xmenu.c (dialog_selection_callback): Likewise.
2081 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2082 Also, don't assume VALBITS / RAND_BITS is less than 5,
2083 and don't rely on undefined behavior when shifting a 1 left into
2085 * lisp.h (get_random): Change signature to match.
2087 * lread.c (hash_string): Use size_t, not int, for hash computation.
2088 Normally we prefer signed values; but hashing is special, because
2089 it's better to use unsigned division on hash table sizes so that
2090 the remainder is nonnegative. Also, size_t is the natural width
2091 for hashing into memory. The previous code used 'int', which doesn't
2092 retain enough info to hash well into very large tables.
2093 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2095 * dbusbind.c: Don't possibly lose pointer info when converting.
2096 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2097 Use XPNTR rather than XHASH, so that the high-order bits of
2098 the pointer aren't lost when converting through void *.
2100 * eval.c (Fautoload): Don't double-shift a pointer.
2102 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2104 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2106 * gnutls.c (DEF_GNUTLS_FN):
2107 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2109 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2111 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2114 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2116 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2117 New version that can reserve upto 2GB of heap space.
2119 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2121 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2123 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2125 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2126 `gnutls_certificate_set_x509_key_file'.
2128 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2130 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2131 Update dependencies.
2133 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2135 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2136 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2137 Remove unused parameter `fildes'.
2138 * process.c (read_process_output, send_process): Don't pass it.
2140 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2142 Fix previous change: the library cache is defined in w32.c.
2143 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2144 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2146 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2148 Implement dynamic loading of GnuTLS on Windows.
2150 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2151 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2152 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2155 * gnutls.c (Qgnutls_dll): Define.
2156 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2157 (gnutls_*): Declare function pointers.
2158 (init_gnutls_functions): New function to initialize function pointers.
2159 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2160 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2161 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2162 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2163 (emacs_gnutls_write, emacs_gnutls_read)
2164 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2165 (Fgnutls_available_p): New function.
2166 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2167 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2168 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2170 * image.c: Include w32.h.
2171 (Vimage_type_cache): Delete.
2172 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2173 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2174 (w32_delayed_load): Move to w32.c.
2176 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2178 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2179 (w32_delayed_load): Move from image.c. When loading a library, record
2180 its filename in the :loaded-from property of the library id.
2181 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2182 Initialize and staticpro them.
2183 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2185 * process.c: Include lisp.h before w32.h, not after.
2186 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2187 instead of gnutls_record_check_pending.
2189 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2191 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2193 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2194 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2197 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2199 * xterm.c (x_set_frame_alpha): Do not set property on anything
2200 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2202 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2204 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2206 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2208 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2209 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2210 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2211 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2212 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2213 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2214 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2215 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2216 (Qgnutls_bootprop_callbacks_verify): Make static.
2218 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2220 * callproc.c: Indentation fixup.
2222 * sysdep.c (wait_for_termination_1): Make static.
2223 (wait_for_termination, interruptible_wait_for_termination):
2224 Move after wait_for_termination_1.
2226 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2228 * sysdep.c (interruptible_wait_for_termination): New function
2229 which is like wait_for_termination, but allows keyboard
2232 * callproc.c (Fcall_process): Add (:file "file") as an option for
2234 (Fcall_process_region): Ditto.
2236 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2238 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2239 rather than `XVECTOR (FOO)->size'.
2241 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2242 inttypes.h, as a gnulib replacement is used if it not available in
2245 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2247 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2248 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2249 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2251 * coding.c (coding_alloc_by_realloc): Error out if destination
2252 will grow beyond MOST_POSITIVE_FIXNUM.
2253 (decode_coding_emacs_mule): Abort if there isn't enough place in
2254 charbuf for the composition carryover bytes. Reserve an extra
2255 space for up to 2 characters produced in a loop.
2256 (decode_coding_iso_2022): Abort if there isn't enough place in
2257 charbuf for the composition carryover bytes.
2259 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2261 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2262 aborting when %lld or %lll format is passed.
2263 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2264 %llo or %llx format is passed. (Bug#8545)
2266 * window.c (window_scroll_line_based): Use a marker instead of
2267 simple variables to record original value of point. (Bug#7952)
2269 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2270 produced by %s or %c overflows available buffer space. (Bug#8545)
2272 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2274 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2275 (SIZE_MAX): Move defn after all includes, as they might #define it.
2277 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2279 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2281 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2283 * keyboard.c (Qdelayed_warnings_hook): Define.
2284 (command_loop_1): Run `delayed-warnings-hook'
2285 if Vdelayed_warnings_list is non-nil.
2286 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2287 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2289 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2291 * doprnt.c (doprnt): Don't return value smaller than the buffer
2292 size if the message was truncated. (Bug#8545).
2294 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2296 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2297 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2299 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2301 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2303 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2305 * makefile.w32-in: Update dependencies.
2307 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2309 Improve `doprnt' and its usage. (Bug#8545)
2310 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2311 `format_end'. Remove support for %l as a conversion specifier.
2312 Don't use xrealloc. Improve diagnostics when the %l size modifier
2313 is used. Update the commentary.
2315 * eval.c (verror): Simplify calculation of size_t.
2317 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2320 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2322 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2325 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2327 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2328 This makes this file independent of the recent pseudovector change.
2330 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2332 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2334 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2335 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2336 Remove unused local.
2337 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2339 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2340 GCC 4.6.0 optimizes based on type-based alias analysis.
2341 For example, if b is of type struct buffer * and v of type struct
2342 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2343 != &v->size, and therefore "v->size = 1; b->size = 2; return
2344 v->size;" must therefore return 1. This assumption is incorrect
2345 for Emacs, since it type-puns struct Lisp_Vector * with many other
2346 types. To fix this problem, this patch adds a new type struct
2347 vectorlike_header that documents the constraints on layout of vectors
2348 and pseudovectors, and helps optimizing compilers not get fooled
2349 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2350 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2351 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2353 (XSETPVECTYPE): Rewrite in terms of new macro.
2354 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2355 This is a bit clearer, and further avoids the possibility of
2356 undesirable aliasing.
2357 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2358 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2359 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2360 since Lisp_Subr is a special case (no "next" field).
2361 (ASIZE): Now uses header.size rather than size.
2362 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2363 to avoid the hassle of writing XVECTOR (foo)->header.size.
2364 (struct vectorlike_header): New type.
2365 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2366 object, to help avoid aliasing.
2367 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2368 (SUBRP): Likewise, since Lisp_Subr is a special case.
2369 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2370 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2371 (struct Lisp_Hash_Table): Combine first two members into a single
2372 struct vectorlike_header member. All uses of "size" and "next" members
2373 changed to be "header.size" and "header.next".
2374 * buffer.h (struct buffer): Likewise.
2375 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2376 * frame.h (struct frame): Likewise.
2377 * process.h (struct Lisp_Process): Likewise.
2378 * termhooks.h (struct terminal): Likewise.
2379 * window.c (struct save_window_data, struct saved_window): Likewise.
2380 * window.h (struct window): Likewise.
2381 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2382 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2383 * buffer.c (init_buffer_once): Likewise.
2384 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2386 * process.c (Fformat_network_address): Use local var for size,
2389 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2391 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2392 * data.c (atof): Remove decl; no longer used or needed.
2393 (digit_to_number): Move to lread.c.
2394 (Fstring_to_number): Use new string_to_number function, to be
2395 consistent with how the Lisp reader treats infinities and NaNs.
2396 Do not assume that floating-point numbers represent EMACS_INT
2397 without losing information; this is not true on most 64-bit hosts.
2398 Avoid double-rounding errors, by insisting on integers when
2399 parsing non-base-10 numbers, as the documentation specifies.
2400 * lisp.h (string_to_number): New decl, replacing ...
2401 (isfloat_string): Remove.
2402 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2403 (read1): Do not accept +. and -. as integers; this
2404 appears to have been a coding error. Similarly, do not accept
2405 strings like +-1e0 as floating point numbers. Do not report
2406 overflow for integer overflows unless the base is not 10 which
2407 means we have no simple and reliable way to continue.
2408 Break out the floating-point parsing into a new
2409 function string_to_number, so that Fstring_to_number parses
2410 floating point numbers consistently with the Lisp reader.
2411 (digit_to_number): Move here from data.c. Make it static inline.
2412 (E_CHAR, EXP_INT): Remove, replacing with ...
2413 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2414 (string_to_number): New function, replacing isfloat_string.
2415 This function checks for valid syntax and produces the resulting
2416 Lisp float number too. Rework it so that string-to-number
2417 no longer mishandles examples like "1.0e+". Use strtoumax,
2418 so that overflow for non-base-10 numbers is reported only when
2419 there's no portable and simple way to convert to floating point.
2421 * textprop.c (set_text_properties_1): Rewrite for clarity,
2422 and to avoid GCC warning about integer overflow.
2424 * intervals.h (struct interval): Use EMACS_INT for members
2425 where EMACS_UINT might cause problems. See
2426 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2427 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2428 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2430 (offset_intervals): Tell GCC not to worry about length overflow
2431 when negating a negative length.
2433 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2434 (overrun_check_free): Likewise.
2436 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2437 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2440 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2441 (gnutls_make_error): Rename local to avoid shadowing.
2442 (gnutls_emacs_global_deinit): ifdef out; not used.
2443 (Fgnutls_boot): Use const for pointer to readonly storage.
2444 Comment out unused local. Fix pointer signedness problems.
2446 * lread.c (openp): Don't stuff size_t into an 'int'.
2447 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2448 about possible signed overflow.
2450 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2451 (GDK_KEY_g): Don't define if already defined.
2452 (xg_prepare_tooltip): Avoid pointer signedness problem.
2453 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2455 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2456 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2458 * xfns.c (Fx_window_property): Simplify a bit,
2459 to make a bit faster and to avoid GCC 4.6.0 warning.
2460 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2462 * fns.c (internal_equal): Don't assume size_t fits in int.
2464 * alloc.c (compact_small_strings): Tighten assertion a little.
2466 Replace pEd with more-general pI, and fix some printf arg casts.
2467 * lisp.h (pI): New macro, generalizing old pEd macro to other
2468 conversion specifiers. For example, use "...%"pI"d..." rather
2469 than "...%"pEd"...".
2470 (pEd): Remove. All uses replaced with similar uses of pI.
2471 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2472 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2473 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2474 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2475 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2476 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2477 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2479 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2480 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2481 * print.c (safe_debug_print, print_object): Likewise.
2482 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2484 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2485 avoiding the 0 flag, which is not portable.
2486 * process.c (Fmake_network_process): Use pI to avoid cast.
2487 * region-cache.c (pp_cache): Likewise.
2488 * xdisp.c (decode_mode_spec): Likewise.
2489 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2490 behavior on 64-bit hosts with printf arg.
2491 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2492 (x_stop_queuing_selection_requests): Likewise.
2493 (x_get_window_property): Don't truncate byte count to an 'int'
2496 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2497 here, since it parses constructs like leading '-' and spaces,
2498 which are not wanted; and it overflows with large numbers.
2499 Instead, simply match F[0-9]+, which is what is wanted anyway.
2501 * alloc.c: Remove unportable assumptions about struct layout.
2502 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2503 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2504 (allocate_vectorlike, make_pure_vector): Use the new macros,
2505 plus offsetof, to remove unportable assumptions about struct layout.
2506 These assumptions hold on all porting targets that I know of, but
2507 they are not guaranteed, they're easy to remove, and removing them
2508 makes further changes easier.
2510 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2511 This doesn't fix a bug but makes the code clearer.
2512 (string_overrun_cookie): Now const. Use initializers that
2513 don't formally overflow signed char, to avoid warnings.
2514 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2515 can cause Emacs to crash when string overrun checking is enabled.
2516 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2517 multiple of sizeof (EMACS_INT); it need not be, if
2518 alignof(EMACS_INT) < sizeof (EMACS_INT).
2519 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2521 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2523 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2525 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2527 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2528 supposed to be handshaking. (Bug#8556)
2529 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2531 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2533 * lisp.h (Qdebug): List symbol.
2534 * eval.c (Qdebug): Restore global linkage.
2535 * keyboard.c (debug-on-event): New variable.
2536 (handle_user_signal): Break into debugger when debug-on-event
2537 matches the current signal symbol.
2539 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2541 * alloc.c (check_sblock, check_string_bytes)
2542 (check_string_free_list): Convert to standard C.
2544 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2546 * w32.c (emacs_gnutls_push): Fix typo.
2548 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2550 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2551 "cast to pointer from integer of different size".
2553 Improve doprnt and its use in verror. (Bug#8545)
2554 * doprnt.c (doprnt): Document the set of format control sequences
2555 supported by the function. Use SAFE_ALLOCA instead of always
2558 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2559 is one byte too soon. Don't use xrealloc; instead xfree and
2562 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2564 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2567 * gnutls.c: Renamed global_initialized to
2568 gnutls_global_initialized. Added internals for the
2569 :verify-hostname-error, :verify-error, and :verify-flags
2570 parameters of `gnutls-boot' and documented those parameters in the
2571 docstring. Start callback support.
2572 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2573 unless a fatal error occured. Call gnutls_alert_send_appropriate
2574 on error. Return error code.
2575 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2576 (emacs_gnutls_read): Likewise.
2577 (Fgnutls_boot): Return handshake error code.
2578 (emacs_gnutls_handle_error): New function.
2579 (wsaerror_to_errno): Likewise.
2581 * w32.h (emacs_gnutls_pull): Add prototype.
2582 (emacs_gnutls_push): Likewise.
2584 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2585 (emacs_gnutls_push): Likewise.
2587 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2589 * process.c (wait_reading_process_output): Check if GnuTLS
2590 buffered some data internally if no FDs are set for TLS
2593 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2594 (LIBS): Link to USER_LIBS.
2595 ($(BLD)/gnutls.$(0)): New target.
2597 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2599 * xdisp.c (handle_single_display_spec): Rename the
2600 display_replaced_before_p argument into display_replaced_p, to
2601 make it consistent with the commentary. Fix typos in the
2604 * textprop.c (syms_of_textprop): Remove dead code.
2605 (copy_text_properties): Delete obsolete commentary about an
2606 interface that was deleted long ago. Fix typos in the description
2609 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2610 to changes in oldXMenu/XMenu.h from 2011-04-16.
2611 <menu_help_message, prev_menu_help_message>: Constify.
2612 (IT_menu_make_room): menu->help_text is now `const char **';
2615 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2616 to changes in oldXMenu/XMenu.h from 2011-04-16.
2617 (struct XMenu): Declare `help_text' `const char **'.
2619 * xfaces.c <Qunspecified>: Make extern again.
2621 * syntax.c: Include sys/types.h before including regex.h, as
2624 * doc.c (get_doc_string): Improve the format passed to `error'.
2626 * doprnt.c (doprnt): Improve commentary.
2628 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2630 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2633 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2634 changes in globals.h immediately force recompilation.
2635 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2636 $(CURDIR)/s/ms-w32.h.
2637 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2639 * character.c (Fchar_direction): Function deleted.
2640 (syms_of_character): Don't defsubr it.
2641 <char-direction-table>: Deleted.
2643 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2645 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2646 * doprnt.c: Include limits.h.
2647 (SIZE_MAX): New macro.
2648 (doprnt): Return a size_t value. 2nd arg is now size_t.
2649 Many local variables are now size_t instead of int or unsigned.
2650 Improve overflow protection. Support `l' modifier for integer
2651 conversions. Support %l conversion. Don't assume an EMACS_INT
2652 argument for integer conversions and for %c.
2654 * lisp.h (doprnt): Restore prototype.
2656 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2659 * Makefile.in (base_obj): Add back doprnt.o.
2661 * deps.mk (doprnt.o): Add back prerequisites.
2662 (callint.o): Depend on character.h.
2664 * eval.c (internal_lisp_condition_case): Include the handler
2665 representation in the error message.
2666 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2667 when breaking from the loop.
2669 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2671 * callint.c (Fcall_interactively): When displaying error message
2672 about invalid control letter, pass the character's codepoint, not
2673 a pointer to its multibyte form. Improve display of the character
2674 in octal and display also its hex code.
2676 * character.c (char_string): Use %x to display the (unsigned)
2677 codepoint of an invalid character, to avoid displaying a bogus
2680 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2681 `error', not SYMBOL_NAME itself.
2683 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2684 character arguments to `error'.
2686 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2687 to `error' in error message about FINAL_CHAR argument. Make sure
2688 FINAL_CHAR is a character, and use %c when it is passed as
2689 argument to `error'.
2691 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2693 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2695 * w32.c: Include <time.h>.
2696 (sys_localtime): New function.
2698 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2700 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2702 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2704 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2706 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2709 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2711 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2712 gl_state.e_property when gl_state.object is Qt.
2714 * insdel.c (make_gap_larger): Remove limitation of buffer size
2717 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2719 * xdisp.c (lookup_glyphless_char_display)
2720 (produce_glyphless_glyph): Handle cons cell entry in
2721 glyphless-char-display.
2722 (Vglyphless_char_display): Document it.
2724 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2725 glyphless-char-display.
2727 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2729 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2731 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2733 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2734 definition for no-X builds.
2736 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2738 Static checks with GCC 4.6.0 and non-default toolkits.
2740 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2742 * process.c (keyboard_bit_set): Define only if SIGIO.
2743 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2744 (send_process): Repair possible setjmp clobbering.
2746 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2748 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2750 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2752 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2753 Define only if needed.
2755 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2756 by pacifying GCC about it. Maybe it's time to retire it?
2757 * xfaces.c (USG, __TIMEVAL__): Likewise.
2759 * dispextern.h (struct redisplay_interface): Rename param
2761 * termhooks.h (struct terminal): Likewise.
2762 * xterm.c (xembed_send_message): Likewise.
2764 * insdel.c (make_gap_smaller): Define only if
2765 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2767 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2770 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2771 so that we aren't warned about unused symbols.
2773 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2775 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2777 * xfns.c (x_real_positions): Mark locals as initialized.
2779 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2781 * xterm.c: Fix problems found by static analysis with other toolkits.
2782 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2783 (x_dispatch_event): Declare static if USE_GTK, and
2784 define if USE_GTK || USE_X_TOOLKIT.
2785 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2786 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2787 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2788 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2790 * xmenu.c (menu_help_callback): Pointer type fixes.
2791 Use const pointers when pointing at readonly data. Avoid pointer
2793 (FALSE): Remove unused macro.
2794 (update_frame_menubar): Remove unused decl.
2796 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2798 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2799 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2800 (single_menu_item): Rename local to avoid shadowing.
2802 * keyboard.c (make_lispy_event): Remove unused local var.
2804 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2805 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2807 * bitmaps: Change bitmaps from unsigned char back to the X11
2808 compatible char. Avoid the old compiler warnings about
2809 out-of-range initializers by using, for example, '\xab' rather
2812 * xgselect.c (xgselect_initialize): Check vs interface
2813 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2815 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2817 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2818 to read-only memory.
2820 * fns.c (vector): Remove; this old hack is no longer needed.
2822 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2824 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2826 * xrdb.c (x_load_resources): Omit unused local.
2828 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2829 (x_window): Rename locals to avoid shadowing.
2830 (USG): Use the kludged USG macro, to pacify gcc.
2832 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2833 (x_term_init): Remove local to avoid shadowing.
2835 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2837 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2838 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2840 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2842 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2844 Fix regex.c, syntax.c and friends for buffers > 2GB.
2845 * syntax.h (struct gl_state_s): Declare character position members
2848 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2850 * textprop.c (verify_interval_modification, interval_of):
2851 Declare arguments EMACS_INT.
2853 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2856 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2858 * indent.c (Fvertical_motion): Local variable it_start is now
2861 * regex.c (re_match, re_match_2, re_match_2_internal)
2862 (bcmp_translate, regcomp, regexec, print_double_string)
2863 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2864 (re_compile_pattern, re_exec): Declare arguments and local
2865 variables `size_t' and `ssize_t' and return values `regoff_t', as
2867 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2868 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2869 <compile_stack_type>: `size' and `avail' are now `size_t'.
2871 * regex.h <regoff_t>: Use ssize_t, not int.
2872 (re_search, re_search_2, re_match, re_match_2): Arguments that
2873 specify buffer/string position and length are now ssize_t and
2874 size_t. Return type is regoff_t.
2876 2011-04-16 Ben Key <bkey76@gmail.com>
2878 * nsfont.m: Fixed bugs in ns_get_family and
2879 ns_descriptor_to_entity that were caused by using free to
2880 deallocate memory blocks that were allocated by xmalloc (via
2881 xstrdup). This caused Emacs to crash when compiled with
2882 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2883 --enable-checking=xmallocoverrun). xfree is now used to
2884 deallocate these memory blocks.
2886 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2888 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2890 emacs_write: Accept and return EMACS_INT for sizes.
2891 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2893 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2894 Accept and return EMACS_INT.
2895 (emacs_gnutls_write): Return the number of bytes written on
2897 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2898 (emacs_read, emacs_write): Remove check for negative size, as the
2899 Emacs source code has been audited now.
2900 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2901 (emacs_read, emacs_write): Use it.
2902 * process.c (send_process): Adjust to the new signatures of
2903 emacs_write and emacs_gnutls_write. Do not attempt to store
2904 a byte offset into an 'int'; it might overflow.
2905 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2907 * sound.c: Don't assume sizes fit in 'int'.
2908 (struct sound_device.period_size, alsa_period_size):
2909 Return EMACS_INT, not int.
2910 (struct sound_device.write, vox_write, alsa_write):
2911 Accept EMACS_INT, not int.
2912 (wav_play, au_play): Use EMACS_INT to store sizes and to
2913 record read return values.
2915 2011-04-15 Ben Key <bkey76@gmail.com>
2917 * keyboard.c (Qundefined): Don't declare static since it is used
2919 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2920 static since they are used in nsfont.m.
2922 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2924 * process.c (Qprocessp): Don't declare static.
2925 * lisp.h (Qprocessp): Declare again.
2927 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2929 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2931 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2933 Improve C-level modularity by making more things 'static'.
2935 Don't publish debugger-only interfaces to other modules.
2936 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2937 (verify_bytepos, count_markers): Move decls to the only modules
2939 * region-cache.h (pp_cache): Likewise.
2940 * window.h (check_all_windows): Likewise.
2941 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2943 * sysdep.c (croak): Now static, if
2944 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2945 * syssignal.h (croak): Declare only if not static.
2947 * alloc.c (refill_memory_reserve): Now static if
2948 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2949 * lisp.h (refill_memory_reserve): Declare only if not static.
2951 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2952 Define only if USE_LUCID.
2954 * xrdb.c (x_customization_string, x_rm_string): Now static.
2956 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2957 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2959 * xdisp.c (draw_row_with_mouse_face): Now static.
2960 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2962 * window.h (check_all_windows): Mark externally visible.
2964 * window.c (window_deletion_count): Now static.
2966 * undo.c: Make symbols static if they're not exported.
2967 (last_undo_buffer, last_boundary_position, pending_boundary):
2970 * textprop.c (interval_insert_behind_hooks): Now static.
2971 (interval_insert_in_front_hooks): Likewise.
2973 * term.c: Make symbols static if they're not exported.
2974 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2975 (max_frame_lines, tty_set_terminal_modes):
2976 (tty_reset_terminal_modes, tty_turn_off_highlight):
2977 (get_tty_terminal): Now static.
2978 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2979 * termhooks.h (term_mouse_moveto): Do not declare if
2981 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2982 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2984 * sysdep.c: Make symbols static if they're not exported.
2985 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2987 (sigprocmask_set, full_mask): Remove; unused.
2988 (wait_debugging): Mark as visible.
2989 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2990 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2992 * syntax.c (syntax_temp): Define only if !__GNUC__.
2994 * sound.c (current_sound_device, current_sound): Now static.
2996 * search.c (searchbufs, searchbuf_head): Now static.
2998 * scroll.c (scroll_cost): Remove; unused.
2999 * dispextern.h (scroll_cost): Remove decl.
3001 * region-cache.h (pp_cache): Mark as externally visible.
3003 * process.c: Make symbols static if they're not exported.
3004 (process_tick, update_tick, create_process, chan_process):
3005 (Vprocess_alist, proc_buffered_char, datagram_access):
3006 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3007 (deactivate_process): Mark defn as static, as well as decl.
3008 * lisp.h (create_process): Remove decl.
3009 * process.h (chan_process, Vprocess_alist): Remove decls.
3011 * print.c: Make symbols static if they're not exported.
3012 (print_depth, new_backquote_output, being_printed, print_buffer):
3013 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3014 (print_interval, print_number_index, initial_stderr_stream):
3016 * lisp.h (Fprinc): Remove decl.
3017 (debug_output_compilation_hack): Mark as externally visible.
3019 * sysdep.c (croak): Move decl from here to syssignal.h.
3020 * syssignal.h (croak): Put it here, so the API can be checked when
3021 'croak' is called from dissociate_if_controlling_tty.
3023 * minibuf.c: Make symbols static if they're not exported.
3024 (minibuf_save_list, choose_minibuf_frame): Now static.
3025 * lisp.h (choose_minibuf_frame): Remove decl.
3027 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3029 * lread.c: Make symbols static if they're not exported.
3030 (read_objects, initial_obarray, oblookup_last_bucket_number):
3032 (make_symbol): Remove; unused.
3033 * lisp.h (initial_obarray, make_symbol): Remove decls.
3035 * keyboard.c: Make symbols static if they're not exported.
3036 (single_kboard, recent_keys_index, total_keys, recent_keys):
3037 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3038 (this_single_command_key_start, echoing, last_auto_save):
3039 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3040 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3041 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3042 (Vlispy_mouse_stem, double_click_count):
3044 (force_auto_save_soon): Define only if SIGDANGER.
3045 (ignore_mouse_drag_p): Now static if
3046 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3047 (print_help): Remove; unused.
3048 (stop_character, last_timer_event): Mark as externally visible.
3049 * keyboard.h (ignore_mouse_drag_p): Declare only if
3050 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3051 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3052 * lisp.h (echoing): Remove decl.
3053 (force_auto_save_soon): Declare only if SIGDANGER.
3054 * xdisp.c (redisplay_window): Simplify code, to make it more
3055 obvious that ignore_mouse_drag_p is not accessed if !defined
3056 USE_GTK && !defined HAVE_NS.
3058 * intervals.c: Make symbols static if they're not exported.
3059 (merge_properties_sticky, merge_interval_right, delete_interval):
3061 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3063 * insdel.c: Make symbols static if they're not exported.
3064 However, leave prepare_to_modify_buffer alone. It's never
3065 called from outside this function, but that appears to be a bug.
3066 (combine_after_change_list, combine_after_change_buffer):
3067 (adjust_after_replace, signal_before_change): Now static.
3068 (adjust_after_replace_noundo): Remove; unused.
3069 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3070 (signal_before_change): Remove decls.
3072 * indent.c (val_compute_motion, val_vmotion): Now static.
3074 * image.c: Make symbols static if they're not exported.
3075 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3077 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3078 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3080 * fringe.c (standard_bitmaps): Now static.
3081 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3083 * frame.c: Make symbols static if they're not exported.
3084 (x_report_frame_params, make_terminal_frame): Now static.
3085 (get_frame_param): Now static, unless HAVE_NS.
3086 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3087 (x_get_resource_string): Remove; not used.
3088 * frame.h (make_terminal_frame, x_report_frame_params):
3089 (x_get_resource_string); Remove decls.
3090 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3091 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3093 * font.c, fontset.c: Make symbols static if they're not exported.
3094 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3095 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3096 * font.c (font_close_object): Now static.
3097 * font.h (font_close_object): Remove.
3098 * fontset.c (FONTSET_OBJLIST): Remove.
3099 (free_realized_fontset) #if-0 the body, which does nothing.
3100 (face_suitable_for_char_p): #if-0, as it's never called.
3101 * fontset.h (face_suitable_for_char_p): Remove decl.
3102 * xfaces.c (face_at_string_position):
3103 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3104 since 0 is always ASCII.
3106 * fns.c (weak_hash_tables): Now static.
3108 * fileio.c: Make symbols static if they're not exported.
3109 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3110 (Vwrite_region_annotation_buffers): Now static.
3112 * eval.c: Make symbols static if they're not exported.
3113 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3114 * lisp.h (backtrace_list): Remove decl.
3116 * emacs.c: Make symbols static if they're not exported.
3117 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3118 (fatal_error_code, fatal_error_signal_hook, standard_args):
3120 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3121 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3122 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3123 * lisp.h (fatal_error_signal_hook): Remove decl.
3124 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3126 * editfns.c: Move a (normally-unused) function to its only use.
3127 * editfns.c, lisp.h (get_operating_system_release): Remove.
3128 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3129 worth the hassle of breaking this out.
3131 * xterm.c: Make symbols static if they're not exported.
3132 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3133 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3134 (x_destroy_window, x_delete_display):
3136 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3137 (x_mouse_leave): Remove; unused.
3138 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3139 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3140 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3142 (x_mouse_leave): Declare only if WINDOWSNT.
3143 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3144 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3147 * ftxfont.c: Make symbols static if they're not exported.
3148 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3150 * font.h (ftxfont_driver): Likewise.
3152 * xfns.c: Make symbols static if they're not exported.
3153 (x_last_font_name, x_display_info_for_name):
3154 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3155 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3156 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3157 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3158 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3159 (last_show_tip_args): Now static.
3160 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3161 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3162 (x_screen_planes): Remove; unused.
3163 * dispextern.h (x_screen_planes): Remove decl.
3165 * dispnew.c: Make symbols static if they're not exported.
3166 * dispextern.h (redraw_garbaged_frames, scrolling):
3167 (increment_row_positions): Remove.
3168 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3169 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3171 (redraw_garbaged_frames): Remove; unused.
3173 * xfaces.c: Make symbols static if they're not exported.
3174 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3176 * xterm.h (defined_color): Remove decls.
3177 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3178 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3179 (menu_face_changed_default, defined_color, free_realized_face):
3180 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3181 (ascii_face_of_lisp_face): Remove; unused.
3183 * xdisp.c: Make symbols static if they're not exported.
3184 * dispextern.h (scratch_glyph_row, window_box_edges):
3185 (glyph_to_pixel_coords, set_cursor_from_row):
3186 (get_next_display_element, set_iterator_to_next):
3187 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3188 (show_mouse_face): Remove decls
3189 * frame.h (message_buf_print): Likewise.
3190 * lisp.h (pop_message, set_message, check_point_in_composition):
3192 * xterm.h (set_vertical_scroll_bar): Likewise.
3193 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3194 (message_buf_print, scratch_glyph_row, displayed_buffer):
3195 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3196 (get_next_display_element, show_mouse_face, window_box_edges):
3197 (frame_to_window_pixel_xy, check_point_in_composition):
3198 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3199 (glyph_to_pixel_coords): Remove; unused.
3201 * dired.c (file_name_completion): Now static.
3203 * dbusbind.c (xd_in_read_queued_messages): Now static.
3205 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3206 * data.c (circular_list_error): Remove.
3208 * commands.h (last_point_position, last_point_position_buffer):
3209 (last_point_position_window): Remove decls.
3210 * keyboard.c: Make these variables static.
3212 * coding.h (coding, code_convert_region, encode_coding_gap):
3214 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3215 (iso_code_class, detect_coding, code_convert_region): Now static.
3216 (encode_coding_gap): Remove; unused.
3218 * chartab.c (chartab_chars, chartab_bits): Now static.
3220 * charset.h (charset_iso_8859_1): Remove decl.
3221 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3224 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3225 * ccl.c (Vccl_program_table): Now static.
3226 (check_ccl_update): Remove; unused.
3228 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3229 * category.h: ... from here.
3230 * category.c (check_category_table, set_category_set): Now static.
3232 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3233 * lisp.h: Remove these decls.
3235 * buffer.c (buffer_count): Remove unused var.
3237 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3238 so that it's not optimized away.
3239 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3240 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3241 exported only to the debugger.
3243 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3244 * atimer.h (run_all_atimers): Remove; not exported.
3246 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3247 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3248 was inaccessible from Lisp.
3249 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3250 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3252 alloc.c: Import and export fewer symbols, and remove unused items.
3253 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3255 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3256 it's not optimized away by whole-program optimization.
3257 (message_enable_multibyte, free_misc): Remove.
3258 (catchlist, handlerlist, mark_backtrace):
3259 Declare only if BYTE_MARK_STACK.
3260 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3261 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3262 (message_enable_multibyte): Remove decl.
3263 (free_misc, interval_free_list, float_block, float_block_index):
3264 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3265 (cons_free_list, last_marked_index):
3267 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3268 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3269 (mark_backtrace): Define only if BYTE_MARK_STACK.
3270 * xdisp.c (message_enable_multibyte): Now static.
3272 Declare Lisp_Object Q* variables to be 'static' if not exported.
3273 This makes it easier for human readers (and static analyzers)
3274 to see whether these variables are used from other modules.
3275 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3276 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3277 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3278 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3279 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3280 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3281 * xmenu.c, xselect.c:
3282 Declare Q* vars static if they are not used in other modules.
3283 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3284 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3285 Remove decls of unexported vars.
3286 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3288 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3290 Make Emacs functions such as Fatom 'static' by default.
3291 This makes it easier for human readers (and static analyzers)
3292 to see whether these functions can be called from other modules.
3293 DEFUN now defines a static function. To make the function external
3294 so that it can be used in other C modules, use the new macro DEFUE.
3295 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3296 (Finit_image_library):
3297 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3298 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3299 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3300 Remove decls, since these functions are now static.
3301 (Funintern, Fget_internal_run_time): New decls, since these functions
3302 were already external.
3304 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3305 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3306 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3307 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3308 * keyboard.c, keymap.c, lread.c:
3309 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3310 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3311 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3312 Mark functions with DEFUE instead of DEFUN,
3313 if they are used in other modules.
3314 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3315 decls for now-static functions.
3316 * buffer.h (Fdelete_overlay): Remove decl.
3317 * callproc.c (Fgetenv_internal): Mark as internal.
3318 * composite.c (Fremove_list_of_text_properties): Remove decl.
3319 (Fcomposition_get_gstring): New forward static decl.
3320 * composite.h (Fcomposite_get_gstring): Remove decl.
3321 * dired.c (Ffile_attributes): New forward static decl.
3322 * doc.c (Fdocumntation_property): New forward static decl.
3323 * eval.c (Ffetch_bytecode): New forward static decl.
3324 (Funintern): Remove extern decl; now in .h file where it belongs.
3325 * fileio.c (Fmake_symbolic_link): New forward static decl.
3326 * image.c (Finit_image_library): New forward static decl.
3327 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3328 * intervals.h (Fprevious_property_change):
3329 (Fremove_list_of_text_properties): Remove decls.
3330 * keyboard.c (Fthis_command_keys): Remove decl.
3331 (Fcommand_execute): New forward static decl.
3332 * keymap.c (Flookup_key): New forward static decl.
3333 (Fcopy_keymap): Now static.
3334 * keymap.h (Flookup_key): Remove decl.
3335 * process.c (Fget_process): New forward static decl.
3336 (Fprocess_datagram_address): Mark as internal.
3337 * syntax.c (Fsyntax_table_p): New forward static decl.
3338 (skip_chars): Remove duplicate decl.
3339 * textprop.c (Fprevious_property_change): New forward static decl.
3340 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3342 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3343 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3345 * editfns.c (Fformat): Remove unreachable code.
3347 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3349 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3352 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3354 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3355 when at ZV. (Bug#8487)
3357 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3359 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3361 * keyboard.c (parse_tool_bar_item): Likewise.
3362 * sound.c (sound_cleanup, alsa_close): Likewise.
3363 * termcap.c (tgetent): Likewise.
3364 * xfns.c (x_default_font_parameter): Likewise.
3365 * xsettings.c (read_and_apply_settings): Likewise.
3367 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3368 (overrun_check_free): Protoize.
3370 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3372 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3373 since callers should never pass a negative size.
3374 Change the signature to match that of plain 'read' and 'write'; see
3375 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3376 * lisp.h: Update prototypes of emacs_write and emacs_read.
3378 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3380 * xdisp.c (redisplay_window): Don't try to determine the character
3381 position of the scroll margin if the window start point w->startp
3382 is outside the buffer's accessible region. (Bug#8468)
3384 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3386 Fix write-region and its subroutines for buffers > 2GB.
3387 * fileio.c (a_write, e_write): Modify declaration of arguments and
3388 local variables to support buffers larger than 2GB.
3389 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3391 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3392 argument, local variables, and return value.
3394 * lisp.h: Update prototypes of emacs_write and emacs_read.
3396 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3398 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3400 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3402 Fix more problems found by GCC 4.6.0's static checks.
3404 * xdisp.c (vmessage): Use a better test for character truncation.
3406 * charset.c (load_charset_map): <, not <=, for optimization,
3407 and to avoid potential problems with integer overflow.
3408 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3409 * casetab.c (set_identity, shuffle): Likewise.
3410 * editfns.c (Fformat): Likewise.
3411 * syntax.c (skip_chars): Likewise.
3413 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3414 This also lets GCC 4.6.0 generate slightly better loop code.
3416 * callint.c (Fcall_interactively): <, not <=, for optimization.
3417 (Fcall_interactively): Count the number of arguments produced,
3418 not the number of arguments given. This is simpler and lets GCC
3419 4.6.0 generate slightly better code.
3421 * ftfont.c: Distingish more carefully between FcChar8 and char.
3422 The previous code passed unsigned char * to a functions like
3423 strlen and xstrcasecmp that expect char *, which does not
3424 conform to the C standard.
3425 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3426 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3427 char * when the C standard requires it.
3429 * keyboard.c (read_char): Remove unused var.
3431 * eval.c: Port to Windows vsnprintf (Bug#8435).
3433 (SIZE_MAX): Define if the headers do not.
3434 (verror): Do not give up if vsnprintf returns a negative count.
3435 Instead, grow the buffer. This ports to Windows vsnprintf, which
3436 does not conform to C99. Problem reported by Eli Zaretskii.
3437 Also, simplify the allocation scheme, by avoiding the need for
3438 calling realloc, and removing the ALLOCATED variable.
3440 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3442 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3443 But keep the doprint source code for now, as we might revamp it
3444 and use it again (Bug#8435).
3445 * lisp.h (doprnt): Remove.
3446 * Makefile.in (base_obj): Remove doprnt.o.
3447 * deps.mk (doprnt.o): Remove.
3449 error: Print 32- and 64-bit integers portably (Bug#8435).
3450 Without this change, on typical 64-bit hosts error ("...%d...", N)
3451 was used to print both 32- and 64-bit integers N, which relied on
3453 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3455 * lisp.h (error, verror): Mark as printf-like functions.
3456 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3457 Report overflow in size calculations when allocating printf buffer.
3458 Do not truncate output string at its first null byte.
3459 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3460 Truncate the output at a character boundary, since vsnprintf does not
3462 * charset.c (check_iso_charset_parameter): Convert internal
3463 character to string before calling 'error', since %c now has the
3465 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3466 overflow when computing char to be passed to 'error'. Do not
3467 pass Lisp_Object to 'error'; pass the integer instead.
3468 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3469 formatted with plain %d.
3471 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3473 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3475 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3477 * xterm.c (x_catch_errors): Remove duplicate declaration.
3479 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3481 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3483 2011-04-10 Jim Meyering <meyering@redhat.com>
3485 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3486 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3487 return ssize_t not "int", and use size_t as the buffer length.
3488 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3489 * gnutls.h: Update declarations.
3490 * process.c (read_process_output): Use ssize_t, to match.
3491 (send_process): Likewise.
3493 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3495 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3497 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3499 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3500 Use unsigned char, to match FcChar8 type definition.
3502 * xterm.c (handle_one_xevent):
3503 * xmenu.c (create_and_show_popup_menu):
3504 * xselect.c (x_decline_selection_request)
3505 (x_reply_selection_request): Avoid type-punned deref of X events.
3507 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3509 Fix some uses of `int' instead of EMACS_INT.
3510 * search.c (string_match_1, fast_string_match)
3511 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3512 (scan_buffer, find_next_newline_no_quit)
3513 (find_before_next_newline, search_command, Freplace_match)
3514 (Fmatch_data): Make some `int' variables be EMACS_INT.
3516 * xdisp.c (display_count_lines): 3rd argument and return value now
3517 EMACS_INT. All callers changed.
3518 (pint2hrstr): Last argument is now EMACS_INT.
3520 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3521 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3522 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3523 (decode_coding_utf_16, decode_coding_emacs_mule)
3524 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3525 (decode_coding_ccl, decode_coding_charset)
3526 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3527 (decode_coding_iso_2022, decode_coding_emacs_mule)
3528 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3529 <char_offset, last_offset>: Declare EMACS_INT.
3530 (encode_coding_utf_8, encode_coding_utf_16)
3531 (encode_coding_emacs_mule, encode_invocation_designation)
3532 (encode_designation_at_bol, encode_coding_iso_2022)
3533 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3534 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3536 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3537 (encode_invocation_designation): Last argument P_NCHARS is now
3539 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3540 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3542 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3545 * ccl.c (Fccl_execute_on_string): Declare some variables
3548 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3550 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3552 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3554 * process.c (Fformat_network_address): Doc fix.
3556 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3558 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3560 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3562 * keyboard.c (read_char): Call Lisp function help-form-show,
3563 instead of using internal_with_output_to_temp_buffer.
3564 (Qhelp_form_show): New var.
3565 (syms_of_keyboard): Use DEFSYM macro.
3567 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3569 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3571 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3573 * process.c (Flist_processes): Remove to Lisp.
3574 (list_processes_1): Delete.
3576 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3578 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3580 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3582 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3584 Fix more problems found by GCC 4.6.0's static checks.
3586 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3588 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3590 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3592 * xdisp.c (vmessage): Mark as a printf-like function.
3594 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3596 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3598 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3599 printf-like functions.
3600 (tiff_load): Add casts to remove these marks before passing them
3601 to system-supplied API.
3603 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3605 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3606 This avoids several warnings with gcc -Wstrict-overflow.
3607 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3608 directly, rather than having caller test rule sign. This avoids
3609 some unnecessary tests.
3610 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3611 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3612 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3614 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3615 (xfont_open): Avoid unnecessary tests.
3617 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3619 * composite.h, composite.c (composition_gstring_put_cache):
3620 Use EMACS_INT, not int, for length.
3622 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3623 breaking out part of COMPOSITION_DECODE_RULE.
3624 (COMPOSITION_DECODE_RULE): Use it.
3625 * composite.c (get_composition_id): Remove unused local vars,
3626 by using the new macro.
3628 * textprop.c (set_text_properties_1): Change while to do-while,
3629 since the condition is always true at first.
3631 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3632 (interval_deletion_adjustment): Return unsigned value.
3635 * process.c (list_processes_1, create_pty, read_process_output):
3636 (exec_sentinel): Remove vars that were set but not used.
3637 (create_pty): Remove unnecessary "volatile"s.
3638 (Fnetwork_interface_info): Avoid possibility of int overflow.
3639 (read_process_output): Do adaptive read buffering even if carryover.
3640 (read_process_output): Simplify nbytes computation if buffered.
3642 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3644 * syntax.c (scan_words): Remove var that was set but not used.
3645 (update_syntax_table): Use unsigned instead of int.
3647 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3648 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3649 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3651 * print.c (print_error_message): Avoid int overflow.
3653 * font.c (font_list_entities): Redo for clarity,
3654 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3656 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3657 (font_score): Avoid potential overflow in diff calculation.
3659 * fns.c (substring_both): Remove var that is set but not used.
3660 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3662 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3664 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3665 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3666 can always succeed if overflow has undefined behavior.
3668 * search.c (boyer_moore, wordify): Remove vars set but not used.
3669 (wordify): Omit three unnecessary tests.
3671 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3672 All callers changed. This avoids the need for an unused var.
3674 * casefiddle.c (casify_region): Remove var that is set but not used.
3676 * dired.c (file_name_completion): Remove var that is set but not used.
3678 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3680 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3681 (Finsert_file_contents): Remove unnecessary code checking fd.
3683 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3684 Check for integer overflow on size calculations.
3686 * buffer.c (Fprevious_overlay_change): Remove var that is set
3689 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3690 Remove vars that are set but not used.
3691 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3692 (timer_check_2): Mark vars as initialized.
3694 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3696 * image.c (lookup_image): Remove var that is set but not used.
3697 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3699 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3700 that are set but not used.
3702 * xfns.c (make_invisible_cursor): Don't return garbage
3703 if XCreateBitmapFromData fails (Bug#8410).
3705 * xselect.c (x_get_local_selection, x_handle_property_notify):
3706 Remove vars that are set but not used.
3708 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3709 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3711 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3712 Remove var that is set but not used.
3713 (scroll_bar_windows_size): Now size_t, not int.
3714 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3717 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3718 (map_tty_color) [!defined MSDOS]: Likewise.
3720 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3722 * coding.c: Remove vars that are set but not used.
3723 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3724 All callers changed.
3725 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3726 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3727 (decode_coding_charset): Remove vars that are set but not used.
3729 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3730 that is set but not used.
3732 * print.c (print_object): Remove var that is set but not used.
3734 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3735 The gnulib version avoids calling malloc in the usual case,
3736 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3737 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3738 * filelock.c (current_lock_owner): Likewise.
3739 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3740 * sysdep.c: Include allocator.h, careadlinkat.h.
3741 (emacs_no_realloc_allocator): New static constant.
3742 (emacs_readlink): New function.
3743 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3744 ../lib/careadlinkat.h.
3746 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3748 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3749 first non-nil return value).
3751 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3753 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3754 if not defined (Bug#8403).
3756 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3758 * xdisp.c (display_count_lines): Remove parameter `start',
3759 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3760 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3761 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3762 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3763 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3764 and thereabouts. All callers changed.
3765 (get_per_char_metric): Remove parameter `f', unused since
3766 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3768 2011-04-02 Jim Meyering <meyering@redhat.com>
3770 do not dereference NULL upon failed strdup
3771 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3772 (ns_get_family): Likewise.
3774 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3776 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3778 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3780 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3783 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3785 Add lexical binding.
3787 * window.c (Ftemp_output_buffer_show): New fun.
3788 (Fsave_window_excursion):
3789 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3791 * lread.c (lisp_file_lexically_bound_p): New function.
3792 (Fload): Bind Qlexical_binding.
3793 (readevalloop): Remove `evalfun' arg.
3794 Bind Qinternal_interpreter_environment.
3795 (Feval_buffer): Bind Qlexical_binding.
3796 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3798 (syms_of_lread): Declare `lexical-binding'.
3800 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3802 * keyboard.c (eval_dyn): New fun.
3803 (menu_item_eval_property): Use it.
3805 * image.c (parse_image_spec): Use Ffunctionp.
3807 * fns.c (concat, mapcar1): Accept byte-code-functions.
3809 * eval.c (Fsetq): Handle lexical vars.
3810 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3811 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3812 (FletX, Flet): Obey lexical binding.
3813 (Fcommandp): Handle closures.
3814 (Feval): New `lexical' arg.
3815 (eval_sub): New function extracted from Feval. Use it almost
3816 everywhere where Feval was used. Look up vars in lexical env.
3818 (Ffunctionp): Move from subr.el.
3819 (Ffuncall): Handle closures.
3820 (apply_lambda): Remove `eval_flags'.
3821 (funcall_lambda): Handle closures and new byte-code-functions.
3822 (Fspecial_variable_p): New function.
3823 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3824 but without exporting it to Lisp.
3826 * doc.c (Fdocumentation, store_function_docstring):
3827 * data.c (Finteractive_form): Handle closures.
3829 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3832 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3834 (exec_byte_code): New function extracted from Fbyte_code to handle new
3835 calling convention for byte-code-functions. Add new byte-codes.
3837 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3839 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3841 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3843 * xdisp.c (redisplay_internal): Fix prototype.
3845 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3847 * xdisp.c (SCROLL_LIMIT): New macro.
3848 (try_scrolling): Use it when setting scroll_limit.
3849 Limit scrolling to 100 screen lines.
3850 (redisplay_window): Even when falling back on "recentering",
3851 position point in the window according to scroll-conservatively,
3852 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3854 (try_scrolling): When point is above the window, allow searching
3855 as far as scroll_max, or one screenful, to compute vertical
3856 distance from PT to the scroll margin position. This prevents
3857 try_scrolling from unnecessarily failing when
3858 scroll-conservatively is set to a value slightly larger than the
3859 window height. Clean up the case of PT below the margin at bottom
3860 of window: scroll_max can no longer be INT_MAX. When aggressive
3861 scrolling is in use, don't let point enter the opposite scroll
3862 margin as result of the scroll.
3863 (syms_of_xdisp) <scroll-conservatively>: Document the
3864 threshold of 100 lines for never-recentering scrolling.
3866 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3868 * dispextern.h (move_it_by_lines):
3869 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3870 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3871 (message_log_check_duplicate): Remove parameters `prev_bol' and
3872 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3873 (redisplay_internal): Remove parameter `preserve_echo_area',
3874 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3876 * indent.c (Fvertical_motion):
3877 * window.c (window_scroll_pixel_based, Frecenter):
3878 Don't pass `need_y_p' to `move_it_by_lines'.
3880 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3882 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3883 steal a few bits to be more compact.
3884 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3885 Remove unneeded casts.
3887 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3889 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3891 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3892 binding" message (bug#7967).
3894 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3896 Fix more problems found by GCC 4.6.0's static checks.
3898 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3899 Remove unused local var.
3901 * editfns.c (Fmessage_box): Remove unused local var.
3903 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3904 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3905 Omit unused local vars.
3906 * window.c (shrink_windows): Omit unused local var.
3907 * menu.c (digest_single_submenu): Omit unused local var.
3908 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3909 Omit unused local var.
3911 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3912 Don't assume string length fits in int.
3913 (keyremap_step, read_key_sequence): Use size_t for sizes.
3914 (read_key_sequence): Don't check last_real_key_start redundantly.
3916 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3917 instead of alloca (Bug#8344).
3919 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3920 (Fbacktrace_frame): Don't assume nframes fits in int.
3922 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3924 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3927 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3929 * cm.c (calccost): Turn while-do into do-while, for clarity.
3931 * keyboard.c (syms_of_keyboard): Use the same style as later
3932 in this function when indexing through an array. This also
3933 works around GCC bug 48267.
3935 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3937 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3939 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3940 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3942 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3943 This avoids undefined behavior on integer overflow, and is a bit
3944 more convenient anyway since it is compared to a size_t variable.
3946 Variadic C functions now count arguments with size_t, not int.
3947 This avoids an unnecessary limitation on 64-bit machines, which
3948 caused (substring ...) to crash on large vectors (Bug#8344).
3949 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3950 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3951 All variadic functions and their callers changed accordingly.
3952 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3953 * data.c (arith_driver, float_arith_driver): Likewise.
3954 * editfns.c (general_insert_function): Likewise.
3955 * eval.c (struct backtrace.nargs, interactive_p)
3956 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3957 (funcall_lambda, mark_backtrace): Likewise.
3958 * fns.c (concat): Likewise.
3959 * frame.c (x_set_frame_parameters): Likewise.
3960 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3961 0 if not found, not -1. All callers changed.
3963 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3964 (stack_copy_size): Now size_t, not int.
3965 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3967 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3969 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3970 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3971 All callers changed.
3973 * lisp.h (multibyte_char_to_unibyte):
3974 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3975 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3976 * character.h (CHAR_TO_BYTE8):
3977 * cmds.c (internal_self_insert):
3978 * editfns.c (general_insert_function):
3979 * keymap.c (push_key_description):
3980 * search.c (Freplace_match):
3981 * xdisp.c (message_dolog, set_message_1): All callers changed.
3983 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3985 * keyboard.c (safe_run_hook_funcall): New function.
3986 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3987 don't set the hook to nil, but remove the offending function instead.
3988 (Qcommand_hook_internal): Remove, unused.
3989 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3990 Vcommand_hook_internal.
3992 * eval.c (enum run_hooks_condition): Remove.
3993 (funcall_nil, funcall_not): New functions.
3994 (run_hook_with_args): Call each function through a `funcall' argument.
3995 Remove `cond' argument, now redundant.
3996 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3997 (Frun_hook_with_args_until_failure): Adjust accordingly.
3998 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4000 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4002 * dispextern.h (string_buffer_position): Remove declaration.
4004 * print.c (strout): Remove parameter `multibyte', unused since
4005 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4007 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4008 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4009 All callers changed.
4011 * w32.c (_wsa_errlist): Use braces for struct initializers.
4013 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4014 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4015 All callers changed.
4016 (string_buffer_position): Likewise. Also, make static (it's never
4017 used outside xdisp.c).
4018 (cursor_row_p): Remove parameter `w', unused since
4019 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4020 (decode_mode_spec): Remove parameter `precision', introduced during
4021 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4022 All callers changed.
4024 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4026 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4028 2011-03-27 Anders Lindgren <andlind@gmail.com>
4030 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4031 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4032 (ns_update_auto_hide_menu_bar): New functions.
4033 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4034 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4035 ns_constrain_all_frames.
4036 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4037 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4039 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4041 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4043 2011-03-27 Glenn Morris <rgm@gnu.org>
4045 * syssignal.h: Replace RETSIGTYPE with void.
4046 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4047 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4048 Replace SIGTYPE with void everywhere.
4049 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4050 * s/template.h (SIGTYPE): Remove commented out definition.
4052 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4054 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4055 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4057 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4059 * w32.c (read_unc_volume): Use parameter `henum', instead of
4060 global variable `wget_enum_handle'.
4062 * keymap.c (describe_vector): Remove parameters `indices' and
4063 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4064 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4066 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4068 * keyboard.c (timer_check): Remove parameter `do_it_now',
4069 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4070 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4071 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4073 * keyboard.c (read_char):
4074 * w32menu.c (w32_menu_display_help):
4075 * xmenu.c (show_help_event, menu_help_callback):
4076 Adjust calls to `show_help_echo'.
4078 * gtkutil.c (xg_maybe_add_timer):
4079 * keyboard.c (readable_events):
4080 * process.c (wait_reading_process_output):
4081 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4083 * insdel.c (adjust_markers_gap_motion):
4084 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4085 (gap_left, gap_right): Don't call it.
4087 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4089 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4090 incurred during fontification.
4092 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4094 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4095 (DEFVAR_PER_BUFFER): Don't pass it.
4097 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4098 (scrolling_window): Don't pass it.
4100 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4102 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4104 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4106 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4107 of variables specific to SELinux and computation of `encoded_absname'.
4109 * image.c (XPutPixel): Remove unused variable `height'.
4111 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4113 * unexw32.c (get_section_info): Remove unused variable `section'.
4115 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4116 (system_process_attributes): Remove unused variable `sess'.
4117 (sys_read): Remove unused variable `err'.
4119 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4120 (w32_wnd_proc): Remove unused variable `isdead'.
4121 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4122 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4123 (x_create_tip_frame): Remove unused variable `tem'.
4125 * w32inevt.c (w32_console_read_socket):
4126 Remove unused variable `no_events'.
4128 * w32term.c (x_draw_composite_glyph_string_foreground):
4129 Remove unused variable `width'.
4131 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4133 * w32term.c (x_set_glyph_string_clipping):
4134 Don't pass uninitialized region to CombineRgn.
4136 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4138 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4139 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4140 (Fx_close_connection): Remove unused variable `i'.
4142 * w32font.c (w32font_draw): Return number of glyphs.
4143 (w32font_open_internal): Remove unused variable `i'.
4144 (w32font_driver): Add missing initializer.
4146 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4147 (fill_in_menu): Remove unused variable `items_added'.
4149 * w32term.c (last_mouse_press_frame): Remove static global variable.
4150 (w32_clip_to_row): Remove unused variable `f'.
4151 (x_delete_terminal): Remove unused variable `i'.
4153 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4154 (NOTHING): Remove unused static global variable.
4155 (uniscribe_check_otf): Remove unused variable `table'.
4156 (uniscribe_font_driver): Add missing initializers.
4158 2011-03-23 Julien Danjou <julien@danjou.info>
4160 * term.c (Fsuspend_tty, Fresume_tty):
4161 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4162 * window.c (temp_output_buffer_show):
4163 * insdel.c (signal_before_change):
4164 * frame.c (Fhandle_switch_frame):
4165 * fileio.c (Fdo_auto_save):
4166 * emacs.c (Fkill_emacs):
4167 * editfns.c (save_excursion_restore):
4168 * cmds.c (internal_self_insert):
4169 * callint.c (Fcall_interactively):
4170 * buffer.c (Fkill_all_local_variables):
4171 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4173 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4174 unconditionnaly since it does the check itself.
4176 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4178 Fix more problems found by GCC 4.5.2's static checks.
4180 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4181 the first time through the loop, since we know p0 < p1 then.
4182 This also avoids a gcc -Wstrict-overflow warning.
4184 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4185 leading to a memory leak, possible in functions like
4186 load_charset_map_from_file that can allocate an unbounded number
4187 of objects (Bug#8318).
4189 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4190 that could (at least in theory) be that large.
4192 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4193 This is less likely to overflow, and avoids undefined behavior if
4194 overflow does occur. All callers changed. Use strtoul to scan
4195 for the unsigned long integer.
4196 (pint2hrstr): Simplify and tune code slightly.
4197 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4199 * scroll.c (do_scrolling): Work around GCC bug 48228.
4200 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4202 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4203 This also avoids a warning with gcc -Wstrict-overflow.
4204 (validate_x_resource_name): Simplify count usage.
4205 This also avoids a warning with gcc -Wstrict-overflow.
4207 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4210 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4212 * process.c (Fmake_network_process): Use socklen_t, not int,
4213 where POSIX says socklen_t is required in portable programs.
4214 This fixes a porting bug on hosts like 64-bit HP-UX, where
4215 socklen_t is wider than int (Bug#8277).
4216 (Fmake_network_process, server_accept_connection):
4217 (wait_reading_process_output, read_process_output):
4220 * process.c: Rename or move locals to avoid shadowing.
4221 (list_processes_1, Fmake_network_process):
4222 (read_process_output_error_handler, exec_sentinel_error_handler):
4223 Rename or move locals.
4224 (Fmake_network_process): Define label "retry_connect" only if needed.
4225 (Fnetwork_interface_info): Fix pointer signedness.
4226 (process_send_signal): Add cast to avoid pointer signedness problem.
4227 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4228 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4230 Make tparam.h and terminfo.c consistent.
4231 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4232 Include tparam.h instead, since it declares them.
4233 * cm.h (PC): Remove extern decl; tparam.h now does this.
4234 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4235 * terminfo.c: Include tparam.h, to check interfaces.
4236 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4237 (tparam): Adjust signature to match interface in tparam.h;
4238 this removes some undefined behavior. Check that outstring and len
4239 are zero, which they always are with Emacs.
4240 * tparam.h (PC, BC, UP): New extern decls.
4242 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4243 (xftfont_open): Rename locals to avoid shadowing.
4245 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4246 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4247 (OTF_TAG_SYM): Omit macro if not needed.
4248 (ftfont_list): Remove unused local.
4249 (get_adstyle_property, ftfont_pattern_entity):
4250 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4251 Rename locals to avoid shadowing.
4253 * xfont.c (xfont_list_family): Mark var as initialized.
4255 * xml.c (make_dom): Now static.
4257 * composite.c (composition_compute_stop_pos): Rename local to
4259 (composition_reseat_it): Remove unused locals.
4260 (find_automatic_composition, composition_adjust_point): Likewise.
4261 (composition_update_it): Mark var as initialized.
4262 (find_automatic_composition): Mark vars as initialized,
4263 with a FIXME (Bug#8290).
4265 character.h: Rename locals to avoid shadowing.
4266 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4267 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4268 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4269 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4272 * textprop.c (property_change_between_p): Remove; unused.
4274 * intervals.c (interval_start_pos): Now static.
4276 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4278 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4279 Rename locals to avoid shadowing.
4281 * sound.c (wav_play, au_play, Fplay_sound_internal):
4282 Fix pointer signedness.
4283 (alsa_choose_format): Remove unused local var.
4284 (wav_play): Initialize a variable to 0, to prevent undefined
4285 behavior (Bug#8278).
4287 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4289 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4291 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4292 clobbering (Bug#8298).
4293 * sysdep.c (sys_subshell): Likewise.
4294 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4296 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4297 This should get cleaned up, so that child_setup has the
4298 same signature on all platforms.
4300 * callproc.c (call_process_cleanup): Now static.
4301 (relocate_fd): Rename locals to avoid shadowing.
4303 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4305 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4306 not to be necessary, and produces flickering.
4308 2011-03-20 Glenn Morris <rgm@gnu.org>
4310 * config.in: Remove file.
4312 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4314 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4315 are now in src/globals.h.
4316 (syms_of_minibuf): Remove spurious & from previous change.
4318 2011-03-20 Leo <sdl.web@gmail.com>
4320 * minibuf.c (completing-read-function): New variable.
4321 (completing-read-default): Rename from completing-read.
4322 (completing-read): Call completing-read-function.
4324 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4326 * xfaces.c (Fx_load_color_file):
4327 Read color file from absolute filename (bug#8250).
4329 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4331 * makefile.w32-in: Update dependencies.
4333 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4335 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4337 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4339 Fix more problems found by GCC 4.5.2's static checks.
4341 * process.c (make_serial_process_unwind, send_process_trap):
4342 (sigchld_handler): Now static.
4344 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4345 That way, the code declares only the vars that it needs.
4346 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4347 * s/cygwin.h (PTY_ITERATION): Likewise.
4348 * s/darwin.h (PTY_ITERATION): Likewise.
4349 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4351 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4352 * process.c (allocate_pty): Don't declare stb unless it's needed.
4354 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4355 (CONSTANTLIM): Remove; unused.
4356 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4357 Define only if needed.
4359 * unexelf.c (unexec): Name an expression,
4360 to avoid gcc -Wbad-function-cast warning.
4361 Use a different way to cause a compilation error if anyone uses
4362 n rather than nn, a way that does not involve shadowing.
4363 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4365 * deps.mk (unexalpha.o): Remove; unused.
4367 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4368 * unexec.h: New file.
4369 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4370 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4372 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4373 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4374 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4375 Change as necessary to match prototype in unexec.h.
4377 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4379 (back_comment, skip_chars): Mark vars as initialized.
4381 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4382 Rename locals to avoid shadowing.
4384 * lread.c (read1): Rewrite so as not to use empty "else".
4385 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4387 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4389 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4390 warning when compiling print.c.
4392 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4393 instead of using an uninitialized var.
4394 (font_sort_entities): Mark var as initialized.
4396 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4398 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4399 pointers to constants.
4400 (font_parse_fcname): Remove unused vars.
4401 (font_delete_unmatched): Now static.
4402 (font_get_spec): Remove; unused.
4403 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4404 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4405 Rename or move locals to avoid shadowing.
4407 * fns.c (require_nesting_list, require_unwind): Now static.
4408 (Ffillarray): Rename locals to avoid shadowing.
4410 * floatfns.c (domain_error2): Define only if needed.
4411 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4413 * alloc.c (mark_backtrace): Move decl from here ...
4414 * lisp.h: ... to here, so that it can be checked.
4416 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4417 (Fdefvar): Rewrite so as not to use empty "else".
4418 (lisp_indirect_variable): Name an expression,
4419 to avoid gcc -Wbad-function-cast warning.
4420 (Fdefvar): Rename locals to avoid shadowing.
4422 * callint.c (quotify_arg, quotify_args): Now static.
4423 (Fcall_interactively): Rename locals to avoid shadowing.
4424 Use const pointer when appropriate.
4426 * lisp.h (get_system_name, get_operating_system_release):
4427 Move decls here, to check interfaces.
4428 * process.c (get_operating_system_release): Move decl to lisp.h.
4429 * xrdb.c (get_system_name): Likewise.
4430 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4431 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4432 some of which prompt warnings from gcc -Wbad-function-cast.
4433 (Fformat_time_string, Fencode_time, Finsert_char):
4434 (Ftranslate_region_internal, Fformat):
4435 Rename or remove local vars to avoid shadowing.
4436 (Ftranslate_region_internal): Mark var as initialized.
4438 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4441 * lisp.h (eassert): Check that the argument compiles, even if
4442 ENABLE_CHECKING is not defined.
4444 * data.c (Findirect_variable): Name an expression, to avoid
4445 gcc -Wbad-function-cast warning.
4446 (default_value, arithcompare, arith_driver, arith_error): Now static.
4447 (store_symval_forwarding): Rename local to avoid shadowing.
4448 (Fmake_variable_buffer_local, Fmake_local_variable):
4449 Mark variables as initialized.
4450 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4452 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4453 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4454 Rename locals to avoid shadowing.
4455 (mark_stack): Move local variables into the #ifdef region where
4457 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4458 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4460 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4461 (GC_STRING_CHARS): Remove; not used.
4462 (Fmemory_limit): Cast sbrk's returned value to char *.
4464 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4465 avoids undefined behavior in theory.
4467 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4469 Use functions, not macros, for up- and down-casing (Bug#8254).
4470 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4471 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4472 to use the following functions instead of these macros.
4473 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4474 EMACS_INT, since callers assume the returned value fits in int.
4475 (upcase1): Likewise, for UPCASE_TABLE.
4476 (uppercasep, lowercasep, upcase): New static inline functions.
4477 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4478 the race-condition problem in the old DOWNCASE.
4480 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4481 Rename locals to avoid shadowing.
4482 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4483 (regex_compile, re_search_2, re_match_2_internal):
4484 Remove unused local vars.
4485 (FREE_VAR): Rewrite so as not to use empty "else",
4486 which gcc can warn about.
4487 (regex_compile, re_match_2_internal): Mark locals as initialized.
4488 (RETALLOC_IF): Define only if needed.
4489 (WORDCHAR_P): Likewise. This one is never needed, but is used
4490 only in a comment talking about a compiler bug, so put inside
4491 the #if 0 of that comment.
4492 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4493 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4496 * search.c (boyer_moore): Rename locals to avoid shadowing.
4497 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4498 (PREV_CHAR_BOUNDARY): Likewise.
4500 * search.c (simple_search): Remove unused var.
4502 * dired.c (compile_pattern): Move decl from here ...
4503 * lisp.h: ... to here, so that it can be checked.
4504 (struct re_registers): New forward decl.
4506 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4508 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4510 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4511 Rename locals to avoid shadowing.
4512 (Fvertical_motion): Mark locals as initialized.
4514 * casefiddle.c (casify_object, casify_region): Now static.
4515 (casify_region): Mark local as initialized.
4517 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4519 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4520 New macros, so that the caller can use some names other than
4521 gcpro1, gcpro2, etc.
4522 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4524 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4525 argument, for consistency with GCPRO2_VAR, etc: it is now the
4526 prefix of the variable, not the variable itself. All uses
4528 * dired.c (directory_files_internal, file_name_completion):
4529 Rename locals to avoid shadowing.
4531 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4532 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4533 dired.c's scmp function, had undefined behavior.
4534 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4535 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4536 * buffer.h: ... to here, because these macros use current_buffer,
4537 and the new implementation with inline functions needs to have
4538 current_buffer in scope now, rather than later when the macros
4540 (downcase, upcase1): New static inline functions.
4541 (DOWNCASE, UPCASE1): Reimplement using these functions.
4542 This avoids undefined behavior in expressions like
4543 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4544 from race conditions in accessing the global variables
4545 case_temp1 and case_temp2.
4546 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4547 * lisp.h (case_temp1, case_temp2): Remove their decls.
4548 * character.h (ASCII_CHAR_P): Move from here ...
4549 * lisp.h: ... to here, so that the inline functions mentioned
4552 * dired.c (directory_files_internal_unwind): Now static.
4554 * fileio.c (file_name_as_directory, directory_file_name):
4555 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4557 (file_name_as_directory): Use const pointers when appropriate.
4558 (Fexpand_file_name): Likewise. In particular, newdir might
4559 point at constant storage, so make it a const pointer.
4560 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4561 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4563 (Fset_file_times, Finsert_file_contents, auto_save_error):
4564 Rename locals to avoid shadowing.
4566 * minibuf.c (choose_minibuf_frame_1): Now static.
4567 (Ftry_completion, Fall_completions): Rename or remove locals
4570 * marker.c (bytepos_to_charpos): Remove; unused.
4572 * lisp.h (verify_bytepos, count_markers): New decls,
4573 so that gcc does not warn that these functions aren't declared.
4575 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4576 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4577 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4578 (copy_text): Remove unused local var.
4580 * filelock.c (within_one_second): Now static.
4581 (lock_file_1): Rename local to avoid shadowing.
4583 * buffer.c (fix_overlays_before): Mark locals as initialized.
4584 (fix_start_end_in_overlays): Likewise. This function should be
4585 simplified by using pointers-to-pointers, but that's a different
4587 (switch_to_buffer_1): Now static.
4588 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4589 (report_overlay_modification): Rename locals to avoid shadowing.
4591 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4592 Fix pointer signedness issue.
4593 (sys_subshell): Mark local as volatile if checking for lint,
4594 to suppress a gcc -Wclobbered warning that does not seem to be right.
4595 (MAXPATHLEN): Define only if needed.
4597 * process.c (serial_open, serial_configure): Move decls from here ...
4598 * systty.h: ... to here, so that they can be checked.
4600 * fns.c (get_random, seed_random): Move extern decls from here ...
4601 * lisp.h: ... to here, so that they can be checked.
4603 * sysdep.c (reset_io): Now static.
4604 (wait_for_termination_signal): Remove; unused.
4606 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4607 (copy_keymap_item, append_key, push_text_char_description):
4609 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4610 (DENSE_TABLE_SIZE): Remove; unused.
4611 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4612 (describe_map_tree):
4613 Rename locals to avoid shadowing.
4615 * keyboard.c: Declare functions static if they are not used elsewhere.
4616 (echo_char, echo_dash, cmd_error, top_level_2):
4617 (poll_for_input, handle_async_input): Now static.
4618 (read_char, kbd_buffer_get_event, make_lispy_position):
4619 (make_lispy_event, make_lispy_movement, apply_modifiers):
4620 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4621 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4622 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4623 (read_key_sequence, read_char): Mark locals as initialized.
4624 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4626 * keyboard.h (make_ctrl_char): New decl.
4627 (mark_kboards): Move decl here ...
4628 * alloc.c (mark_kboards): ... from here.
4630 * lisp.h (force_auto_save_soon): New decl.
4632 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4633 (DEFINE_DUMMY_FUNCTION): New macro.
4634 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4636 (main): Add casts to avoid warnings
4637 if GCC considers string literals to be constants.
4639 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4641 * dbusbind.c: Pointer signedness fixes.
4642 (xd_signature, xd_append_arg, xd_initialize):
4643 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4644 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4645 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4646 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4648 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4649 if GCC considers string literals to be constants.
4650 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4652 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4654 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4655 (print_preprocess, print_object): New macro to fix last change.
4657 * print.c (print_preprocess): Don't forget font objects.
4659 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4661 * emacs.c (USAGE3): Doc fixes.
4663 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4665 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4668 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4670 * lisp.h (VWindow_system, Qfile_name_history):
4671 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4672 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4673 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4675 * w32select.c: Don't #include "keyboard.h".
4676 (run_protected): Add extern declaration for waiting_for_input.
4678 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4679 * w32console.c (detect_input_pending, read_input_pending)
4680 (encode_terminal_code):
4681 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4682 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4683 (w32_system_caret_y, Qfile_name_history):
4684 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4685 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4686 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4687 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4688 * w32proc.c (Qlocal, report_file_error):
4689 * w32term.c (Vwindow_system, updating_frame):
4690 * w32uniscribe.c (initialized, uniscribe_font_driver):
4691 Remove unneeded extern declarations.
4693 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4695 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4697 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4699 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4700 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4701 These macros can no longer be used for assignment.
4703 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4704 Assign struct members directly, instead of using BUF_BEGV etc.
4705 (record_buffer_markers, fetch_buffer_markers): New functions for
4706 recording and fetching special buffer markers.
4707 (set_buffer_internal_1, set_buffer_temp): Use them.
4709 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4711 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4713 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4714 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4716 * xdisp.c (hscroll_window_tree):
4717 (reconsider_clip_changes): Use PT instead of BUF_PT.
4719 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4721 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4722 $(EMACS_ROOT)/lib/intprops.h.
4724 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4726 Fix more problems found by GCC 4.5.2's static checks.
4728 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4729 to unsigned char * to avoid compiler diagnostic.
4730 (xg_free_frame_widgets): Make it clear that a local variable is
4731 needed only if USE_GTK_TOOLTIP.
4732 (gdk_window_get_screen): Make it clear that this macro is needed
4733 only if USE_GTK_TOOLTIP.
4734 (int_gtk_range_get_value): New function, which avoids a diagnostic
4735 from gcc -Wbad-function-cast.
4736 (xg_set_toolkit_scroll_bar_thumb): Use it.
4737 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4738 diagnostic from gcc -Wbad-function-cast.
4739 (get_utf8_string, xg_get_file_with_chooser):
4740 Rename locals to avoid shadowing.
4741 (create_dialog): Move locals to avoid shadowing.
4743 * xgselect.c (xg_select): Remove unused var.
4745 * image.c (four_corners_best): Mark locals as initialized.
4746 (gif_load): Initialize transparent_p to zero (Bug#8238).
4747 Mark another local as initialized.
4748 (my_png_error, my_error_exit): Mark with NO_RETURN.
4750 * image.c (clear_image_cache): Now static.
4751 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4752 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4753 (x_edge_detection): Remove unnecessary cast that
4754 gcc -Wbad-function-cast diagnoses.
4755 (gif_load): Fix pointer signedness.
4756 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4757 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4759 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4761 Improve quality of tests for time stamp overflow.
4762 For example, without this patch (encode-time 0 0 0 1 1
4763 1152921504606846976) returns the obviously-bogus value (-948597
4764 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4765 reports time overflow. See
4766 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4767 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4768 * editfns.c: Include limits.h and intprops.h.
4769 (TIME_T_MIN, TIME_T_MAX): New macros.
4770 (time_overflow): Move earlier, to before first use.
4771 (hi_time, lo_time): New functions, for an accurate test for
4773 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4774 (Fget_internal_run_time): Don't assume time_t fits in int.
4775 (make_time): Use list2 instead of Fcons twice.
4776 (Fdecode_time): More accurate test for out-of-range times.
4777 (check_tm_member): New function.
4778 (Fencode_time): Use it, to test for out-of-range times.
4779 (lisp_time_argument): Don't rely on undefined left-shift and
4780 right-shift behavior when checking for time stamp overflow.
4782 * editfns.c (time_overflow): New function, refactoring common code.
4783 (Fformat_time_string, Fdecode_time, Fencode_time):
4784 (Fcurrent_time_string): Use it.
4786 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4787 * dired.c (make_time): Move to ...
4788 * editfns.c (make_time): ... here.
4789 * systime.h: Note the move.
4791 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4793 * fringe.c (update_window_fringes): Remove unused variables.
4795 * unexmacosx.c (copy_data_segment): Also copy __got section.
4798 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4800 * termcap.c [MSDOS]: Include "msdos.h".
4801 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4802 Constify `char *' arguments and their references according to
4803 prototypes in tparam.h.
4805 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4807 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4808 Adapt all references accordingly.
4810 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4812 2011-03-11 Tom Tromey <tromey@redhat.com>
4814 * buffer.c (syms_of_buffer): Remove obsolete comment.
4816 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4818 * termhooks.h (encode_terminal_code): Declare prototype.
4820 * msdos.c (encode_terminal_code): Don't declare prototype.
4822 * term.c (encode_terminal_code): Now external again, used by
4823 w32console.c and msdos.c.
4825 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4826 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4828 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4830 Fix some minor problems found by GCC 4.5.2's static checks.
4832 * fringe.c (update_window_fringes): Mark locals as initialized
4834 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4836 * alloc.c (mark_fringe_data): Move decl from here ...
4837 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4838 to check its interface.
4839 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4841 * fontset.c (free_realized_fontset): Now static.
4842 (Fset_fontset_font): Rename local to avoid shadowing.
4843 (fontset_font): Mark local as initialized.
4844 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4846 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4848 * xselect.c (x_disown_buffer_selections): Remove; not used.
4849 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4850 (x_own_selection, Fx_disown_selection_internal): Rename locals
4852 (x_handle_dnd_message): Remove local to avoid shadowing.
4854 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4855 so that the caller can use some name other than gcpro1.
4856 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4857 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4858 (Fx_backspace_delete_keys_p):
4859 Use them to avoid shadowing, and rename vars to avoid shadowing.
4860 (x_decode_color, x_set_name, x_window): Now static.
4861 (Fx_create_frame): Add braces to silence GCC warning.
4862 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4863 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4864 Remove unused locals.
4865 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4866 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4867 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4870 * xterm.h (x_mouse_leave): New decl.
4872 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4873 Remove unused functions.
4874 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4875 (x_calc_absolute_position): Now static.
4876 (XTread_socket): Don't define label "out" unless it's used.
4877 Don't declare local "event" unless it's used.
4878 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4879 unless they are used.
4880 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4881 (x_fatal_error_signal): Remove; not used.
4882 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4883 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4884 (x_error_catcher, x_connection_closed, x_error_handler):
4885 (x_error_quitter, xembed_send_message, x_iconify_frame):
4886 (my_log_handler): Rename locals to avoid shadowing.
4887 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4888 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4890 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4891 Rename or move locals to avoid shadowing.
4892 (tty_defined_color, merge_face_heights): Now static.
4893 (free_realized_faces_for_fontset): Remove; not used.
4894 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4895 does not deduce is never used uninitialized.
4896 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4897 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4899 * terminal.c (store_terminal_param): Now static.
4901 * xmenu.c (menu_highlight_callback): Now static.
4902 (set_frame_menubar): Remove unused local.
4903 (xmenu_show): Rename parameter to avoid shadowing.
4904 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4905 since they might point to immutable storage.
4906 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4907 since it's unused otherwise.
4909 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4910 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4911 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4912 avoids a gcc -Wuninitialized diagnostic.
4913 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4914 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4915 does not deduce are never used uninitialized.
4917 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4919 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4920 * window.c (window_loop, size_window):
4921 (run_window_configuration_change_hook, enlarge_window): Likewise.
4923 * window.c (display_buffer): Now static.
4924 (size_window): Mark variables that gcc -Wuninitialized
4925 does not deduce are never used uninitialized.
4926 * window.h (check_all_windows): New decl, to forestall
4927 gcc -Wmissing-prototypes diagnostic.
4928 * dispextern.h (bidi_dump_cached_states): Likewise.
4930 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4932 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4934 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4935 and to avoid gcc -Wuninitialized warning.
4936 (load_charset_map): Mark variables that gcc -Wuninitialized
4937 does not deduce are never used uninitialized.
4938 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4940 * coding.c (coding_set_source, coding_set_destination):
4941 Use "else { /* comment */ }" rather than "else /* comment */;"
4942 for clarity, and to avoid gcc -Wempty-body warning.
4943 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4944 a block, when the outer 'i' will do.
4945 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4946 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4947 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4948 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4949 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4950 Rename locals to avoid shadowing.
4951 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4952 * coding.c (emacs_mule_char, encode_invocation_designation):
4953 Now static, since they're not used elsewhere.
4954 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4955 (decode_coding_object, encode_coding_object, detect_coding_system):
4956 (decode_coding_emacs_mule): Mark variables that gcc
4957 -Wuninitialized does not deduce are never used uninitialized.
4958 (detect_coding_iso_2022): Initialize a local variable that might
4959 be used uninitialized. Leave a FIXME because it's not clear that
4960 this initialization is needed. (Bug#8211)
4961 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4962 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4963 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4964 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4965 Remove unused macros.
4967 * category.c (hash_get_category_set): Remove unused local var.
4968 (copy_category_table): Now static, since it's not used elsewhere.
4969 * character.c (string_count_byte8): Likewise.
4971 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4972 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4974 * chartab.c (copy_sub_char_table): Now static, since it's not used
4976 (sub_char_table_ref_and_range, char_table_ref_and_range):
4977 Rename locals to avoid shadowing.
4978 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4980 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4981 (BIDI_BOB): Remove unused macro.
4983 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4984 deduce are never used uninitialized.
4985 * term.c (encode_terminal_code): Likewise.
4987 * term.c (encode_terminal_code): Now static. Remove unused local.
4989 * tparam.h: New file.
4990 * term.c, tparam.h: Include it.
4991 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4992 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4993 Move these decls to tparam.h, and make them agree with what
4994 is actually in tparam.c. The previous trick of using incompatible
4995 decls in different modules does not conform to the C standard.
4996 All callers of tparam changed to use tparam's actual API.
4997 * tparam.c (tparam1, tparam, tgoto):
4998 Use const pointers where appropriate.
5000 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5001 * cm.h (struct cm): Likewise.
5002 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5003 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5004 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5005 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5006 (turn_on_face, init_tty): Likewise.
5007 * termchar.h (struct tty_display_info): Likewise.
5009 * term.c (term_mouse_position): Rename local to avoid shadowing.
5011 * alloc.c (mark_ttys): Move decl from here ...
5012 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5014 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5016 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5018 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5020 * search.c (compile_pattern_1): Remove argument regp, unused since
5021 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5022 (compile_pattern): Don't pass it.
5024 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5026 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5027 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5029 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5031 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5033 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5034 gdk_window_get_screen, gdk_window_get_geometry,
5035 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5036 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5037 (xg_get_pixbuf_from_pixmap): New function.
5038 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5039 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5040 Call xg_get_pixbuf_from_pixmap instead of
5041 gdk_pixbuf_get_from_drawable.
5042 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5043 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5044 (xg_check_special_colors): Use GtkStyleContext and its functions
5046 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5047 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5048 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5049 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5050 Call gtk_widget_get_preferred_size.
5051 (xg_frame_resized): gdk_window_get_geometry only takes 5
5053 (xg_win_to_widget, xg_event_is_for_menubar):
5054 Call gdk_x11_window_lookup_for_display.
5055 (xg_set_widget_bg): New function.
5056 (delete_cb): New function.
5057 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5058 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5059 (xg_set_background_color): Call xg_set_widget_bg.
5060 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5061 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5062 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5063 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5065 (update_frame_tool_bar): Call gtk_widget_hide.
5066 (xg_initialize): Use GDK_KEY_g.
5068 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5070 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5072 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5073 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5074 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5076 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5078 * w32xfns.c (select_palette): Check success of RealizePalette against
5079 GDI_ERROR, not zero.
5081 See ChangeLog.11 for earlier changes.
5087 Copyright (C) 2011 Free Software Foundation, Inc.
5089 This file is part of GNU Emacs.
5091 GNU Emacs is free software: you can redistribute it and/or modify
5092 it under the terms of the GNU General Public License as published by
5093 the Free Software Foundation, either version 3 of the License, or
5094 (at your option) any later version.
5096 GNU Emacs is distributed in the hope that it will be useful,
5097 but WITHOUT ANY WARRANTY; without even the implied warranty of
5098 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5099 GNU General Public License for more details.
5101 You should have received a copy of the GNU General Public License
5102 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.