Fix the change with paragraph_dir initialization.
[bpt/emacs.git] / src / ChangeLog
1 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5 cursor motion with <left> and <right> arrow keys.
6
7 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
8 some callers set that themselves.
9
10 2011-10-12 Eli Zaretskii <eliz@gnu.org>
11
12 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
13 display string and the previous row comes from the same string and
14 is empty. (Bug#9739) (Bug#9738)
15
16 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
17
18 * doc.c (get_doc_string): Encode file name (bug#9735).
19
20 2011-10-12 Eli Zaretskii <eliz@gnu.org>
21
22 * bidi.c (bidi_level_of_next_char):
23 * xdisp.c (get_visually_first_element): Remove old incorrect
24 comments regarding the Unicode Line Separator character.
25
26 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
27
28 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
29
30 * alloc.c (Fgc_status): Do not access beyond zombies array
31 boundary if nzombies > MAX_ZOMBIES.
32 * alloc.c (dump_zombies): Add missing format specifier.
33
34 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
35
36 * xdisp.c (set_cursor_from_row): Simplify conditionals,
37 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
38
39 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
40 Some packages use them to denote characters with modifiers.
41
42 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
43
44 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
45 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
46 matching a pp-number. Rename parameter var to var1.
47
48 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
49
50 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
51
52 2011-10-08 Glenn Morris <rgm@gnu.org>
53
54 * callint.c (Fcall_interactively): Give a more explicit error for the
55 'c' case with a non-character input. (Bug#8479)
56
57 2011-10-08 Eli Zaretskii <eliz@gnu.org>
58
59 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
60 lines.
61 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
62 lines that are hscrolled on the left.
63
64 * dispnew.c (buffer_posn_from_coords): Account for a possible
65 presence of header-line. (Bug#4426)
66
67 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
68
69 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
70 advertise functionality which we discourage or doesn't work.
71
72 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
73
74 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
75 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
76 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
77 this makes Emacs dump core during garbage collection on rare
78 occasions. sizeof is obviously inferior to offsetof here, so
79 stick with offsetof.
80 (GC_POINTER_ALIGNMENT): New macro.
81 (mark_memory): Omit 3rd (offset) arg; caller changed.
82 Don't assume EMACS_INT alignment is the same as pointer alignment.
83
84 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
85
86 * keyboard.c (read_key_sequence_remapped): New var.
87 (read_key_sequence): Compute remapping in the right buffer.
88 (command_loop_1): Use read_key_sequence's remapping directly.
89
90 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
91
92 * dired.c (file_name_completion): Don't expand file name.
93 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
94 before checking file name handler.
95
96 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
97 they've been requested explicitly (bug#9591).
98
99 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
100
101 * keymap.c (Fsingle_key_description): Use make_specified_string
102 instead of build_string to build string from push_key_description.
103 (Bug#5193)
104
105 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
106
107 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
108 This fixes a Y2038 bug on 64-bit hosts.
109 * buffer.c (reset_buffer):
110 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
111 (Fclear_buffer_auto_save_failure):
112 Use 0, not -1, to represent an unset failure time, since time_t
113 might not be signed.
114
115 Remove dependency on glibc malloc internals.
116 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
117 Move back here from lisp.h, but with their new implementations.
118 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
119 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
120 * charset.c (charset_table_init): New static var.
121 (syms_of_charset): Use it instead of xmalloc. This removes a
122 dependency on glibc malloc internals. See Eli Zaretskii's comment in
123 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
124 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
125 Move back to alloc.c.
126 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
127 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
128
129 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
130
131 * nsterm.m (windowDidResize): Call x_set_window_size only when
132 ns_in_resize is true. Otherwise set pixelwidth/height and
133 call change_frame_size (Bug#9628).
134
135 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
136
137 Port --enable-checking=all to Fedora 14 x86-64.
138 * charset.c (syms_of_charset): Also account for glibc malloc's
139 internal overhead when calculating the initial malloc maximum.
140
141 Port --enable-checking=all to Fedora 14 x86.
142 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
143 Move to lisp.h.
144 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
145 (overrun_check_realloc, overrun_check_free):
146 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
147 That way, xmalloc returns a properly-aligned pointer even if
148 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
149 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
150 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
151 into account when calculating the initial malloc maximum.
152 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
153 Move here from alloc.c, so that charset.c can use it too.
154 Properly align; the old code wasn't right for common 32-bit hosts
155 when configured with --enable-checking=all.
156 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
157 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
158
159 2011-09-29 Eli Zaretskii <eliz@gnu.org>
160
161 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
162 use EDOM.
163
164 2011-09-28 Eli Zaretskii <eliz@gnu.org>
165
166 * xdisp.c (compute_display_string_end): If there's no display
167 string at CHARPOS, return -1.
168
169 * bidi.c (bidi_fetch_char): When compute_display_string_end
170 returns a negative value, treat the character as a normal
171 character not covered by a display string. (Bug#9624)
172
173 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
174
175 * lread.c (Fread_from_string): Fix typo in docstring.
176
177 2011-09-27 Eli Zaretskii <eliz@gnu.org>
178
179 * xdisp.c (handle_invisible_prop): If invisible text ends on a
180 newline, reseat the iterator instead of bidi-iterating there one
181 character at a time. (Bug#9610)
182 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
183 TO_CHARPOS if the bidi iterator is at base embedding level.
184
185 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
186
187 * lread.c (readevalloop): Use correct code for NBSP.
188 (read1): Likewise. (Bug#9608)
189
190 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
191
192 * dbusbind.c (Fdbus_register_signal): When service is not
193 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
194
195 2011-09-25 Glenn Morris <rgm@gnu.org>
196
197 * buffer.c (truncate-lines): Doc fix.
198
199 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
200
201 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
202 (Fset_window_next_buffers): Doc fix.
203
204 2011-09-24 Glenn Morris <rgm@gnu.org>
205
206 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
207
208 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
209
210 Fix minor problems found by static checking.
211 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
212 * indent.c (Fvertical_motion): Fix == vs = typo.
213
214 2011-09-24 Eli Zaretskii <eliz@gnu.org>
215
216 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
217 Default value is now t. Doc fix.
218
219 * indent.c (Fvertical_motion): Compute and apply the overshoot
220 logic when moving up, not only when moving down. Fix the
221 confusing name and values of the it_overshoot_expected variable;
222 logic changes accordingly. (Bug#9254) (Bug#9549)
223
224 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
225 CHARPOS is covered by a display string which includes newlines.
226 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
227 is covered by a display string with embedded newlines.
228
229 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
230
231 * dbusbind.c (Fdbus_register_signal): Add match rule to
232 Vdbus_registered_objects_table. (Bug#9581)
233 (Fdbus_register_method, Vdbus_registered_objects_table):
234 Fix docstring.
235
236 2011-09-24 Jim Meyering <meyering@redhat.com>
237
238 do not ignore write error for any output size
239 The previous change was incomplete.
240 While it makes emacs --batch detect the vast majority of stdout
241 write failures, errors were still ignored whenever the output size is
242 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
243 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
244 && echo FAIL: ignored write error
245 FAIL: ignored write error
246 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
247 && echo FAIL: ignored write error
248 FAIL: ignored write error
249 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
250
251 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
252
253 * emacs.c (Fkill_emacs): In noninteractive mode exit
254 non-successfully if a write error occurred on stdout. (Bug#9574)
255
256 2011-09-21 Eli Zaretskii <eliz@gnu.org>
257
258 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
259 the xassert test.
260
261 * dispextern.h (struct it): Update the comment documenting what
262 can it->OBJECT be.
263
264 2011-09-20 Eli Zaretskii <eliz@gnu.org>
265
266 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
267 a display string, extend search for cursor position to end of row.
268 (find_row_edges): If the row ends in a newline from a display
269 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
270 Handle the case of a display string with multiple newlines.
271 (Fcurrent_bidi_paragraph_direction): Fix search for previous
272 non-empty line. Fixes confusing cursor motion with arrow keys at
273 the beginning of a line that starts with whitespace.
274
275 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
276
277 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
278 (bug#9493).
279
280 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
281
282 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
283 boolean (Bug#9154).
284
285 2011-09-18 Eli Zaretskii <eliz@gnu.org>
286
287 * xdisp.c (display_line): Record maximum and minimum buffer
288 positions even if no glyphs were produced (e.g., by a zero-width
289 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
290 buffer positions that will be removed from the glyph row because
291 they don't fit.
292 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
293 column is beyond frame width: don't subtract 1 "pixel" when
294 computing width of the stretch.
295 (reseat_at_next_visible_line_start): Undo the change made on
296 2011-09-17 that saved paragraph information and restored it after
297 the call to `reseat'. (Bug#9545)
298
299 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
300
301 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
302 and turn window cursor on if cleared (Bug#9415).
303
304 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
305
306 * search.c (boyer_moore): Take unibyte characters from pattern
307 literally. (Bug#9458)
308
309 2011-09-18 Eli Zaretskii <eliz@gnu.org>
310
311 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
312
313 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
314
315 Fix minor problem found by static checking.
316 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
317 initialized, to pacify gcc -Wuninitialized.
318
319 * fileio.c: Report proper errno when syscall falls.
320 (Finsert_file_contents): Save and restore errno,
321 so that report_file_error outputs the correct diagnostic.
322 (Fwrite_region) [CLASH_DETECTION]: Likewise.
323
324 2011-09-18 Eli Zaretskii <eliz@gnu.org>
325
326 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
327
328 2011-09-17 Eli Zaretskii <eliz@gnu.org>
329
330 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
331 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
332
333 2011-09-17 Eli Zaretskii <eliz@gnu.org>
334
335 * xdisp.c (reseat_at_next_visible_line_start): Keep information
336 about the current paragraph and restore it after the call to
337 reseat.
338
339 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
340 (bidi_find_paragraph_start): Search back for paragraph beginning
341 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
342 (bidi_move_to_visually_next): Only trigger paragraph-related
343 computations when the last character is a newline or at EOB, not
344 just any NEUTRAL_B. (Bug#9470)
345
346 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
347 truncated lines if point is covered by a display string. (Bug#9524)
348
349 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
350
351 * xselect.c: Relax test for outgoing X longs (Bug#9498).
352 (cons_to_x_long): New function.
353 (lisp_data_to_selection_data): Use it. Correct the test for
354 short-versus-long data; it was negated. Break out of vector
355 loop, for efficiency, when a long datum is discovered.
356
357 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
358
359 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
360
361 2011-09-16 Eli Zaretskii <eliz@gnu.org>
362
363 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
364 GCC PR/17406) by declaring this function with external scope.
365
366 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
367
368 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
369 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
370
371 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
372
373 * editfns.c (Fformat): Correctly handle text properties on "%%".
374
375 2011-09-15 Eli Zaretskii <eliz@gnu.org>
376
377 * xterm.c (x_draw_composite_glyph_string_foreground):
378 * w32term.c (x_draw_composite_glyph_string_foreground):
379 * term.c (encode_terminal_code):
380 * composite.c (composition_update_it, get_composition_id):
381 * xdisp.c (get_next_display_element)
382 (fill_composite_glyph_string): Add comments about special meaning
383 of TAB characters in a composition.
384
385 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
386
387 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
388 This occurs when processing a multibyte format.
389 Problem reported by Wolfgang Jenker.
390
391 2011-09-15 Johan Bockgård <bojohan@gnu.org>
392
393 * xdisp.c (try_cursor_movement): Only check for exact match if
394 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
395
396 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
397
398 Remove unused external symbols.
399 * dispextern.h (calc_pixel_width_or_height): Remove decl.
400 * xdisp.c (calc_pixel_width_or_height): Now static.
401 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
402 * indent.c (check_display_width):
403 * w32term.c: Fix comment to match code.
404 * xterm.c, xterm.h (x_catching_errors): Remove.
405
406 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
407
408 * xselect.c: Use signed conversions more consistently (Bug#9498).
409 (selection_data_to_lisp_data): Assume incoming selection data are
410 signed integers, not unsigned. This is to be consistent with
411 outgoing selection data, which was modified to use signed integers
412 in as part of the fix to Bug#9196 in response to Jan D.'s comment
413 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
414 expects long, not unsigned long.
415
416 2011-09-14 Eli Zaretskii <eliz@gnu.org>
417
418 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
419 computation of loop end. Reported by Johan Bockgård
420 <bojohan@gnu.org>.
421
422 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
423
424 * frame.c (Fother_visible_frames_p): Function deleted.
425
426 2011-09-12 Eli Zaretskii <eliz@gnu.org>
427
428 * indent.c (compute_motion): Process display vector front to back
429 rather than the other way around. (Bug#2496)
430
431 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
432
433 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
434
435 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
436
437 * minibuf.c (Fread_from_minibuffer): Doc fix.
438
439 2011-09-11 Eli Zaretskii <eliz@gnu.org>
440
441 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
442 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
443
444 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
445
446 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
447 value for non-existent files.
448
449 2011-09-11 Eli Zaretskii <eliz@gnu.org>
450
451 * fileio.c (Finsert_file_contents): If the file cannot be opened,
452 set its "size" to -1. This will set the modtime_size field of
453 the corresponding buffer to -1, which is what
454 verify-visited-file-modtime expects for files that do not exist.
455 (Bug#9139)
456
457 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
458
459 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
460 here ...
461 * lisp.h: ... from here. push_key_description is no longer
462 defined in keyboard.c, so its declaration should not be in
463 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
464 logically belongs with push_key_description.
465
466 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
467
468 * buffer.h: Include <sys/types.h> instead of <time.h>.
469 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
470 Problem reported by Herbert J. Skuhra.
471
472 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
473
474 * xml.c (parse_region): Make the parsing work for
475 non-comment-starting XML files again (bug#9144).
476
477 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
478
479 * image.c (gif_load): Fix calculation of bottom and right corner.
480 (Bug#9468)
481
482 2011-09-10 Eli Zaretskii <eliz@gnu.org>
483
484 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
485 redisplay in small windows.
486
487 2011-09-09 Eli Zaretskii <eliz@gnu.org>
488
489 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
490
491 2011-09-08 Martin Rudalics <rudalics@gmx.at>
492
493 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
494 Operate on live windows only.
495
496 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
497
498 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
499
500 2011-09-07 Eli Zaretskii <eliz@gnu.org>
501
502 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
503 only under bidi iteration.
504
505 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
506
507 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
508
509 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
510
511 isnan: Fix porting problem to Solaris 10 with bundled gcc.
512 Without this fix, the command to link temacs failed due to an
513 undefined symbol __builtin_isnan. This is because
514 /usr/include/iso/math_c99.h #defines isnan(x) to
515 __builtin_isnan(x), but the bundled gcc, which identifies itself
516 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
517 a __builtin_isnan.
518 * floatfns.c (isnan): #undef, and then #define to a clone of
519 what's in data.c.
520 (Fisnan): Always define, since it's always available now.
521 (syms_of_floatfns): Always define isnan at the Lisp level.
522
523 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
524
525 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
526
527 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
528
529 * fileio.c: Fix bugs with large file offsets (Bug#9428).
530 The previous code assumed that file offsets (off_t values) fit in
531 EMACS_INT variables, which is not true on typical 32-bit hosts.
532 The code messed up by falsely reporting buffer overflow in cases
533 such as (insert-file-contents "big" nil 1 2) into an empty buffer
534 when "big" contains more than 2**29 bytes, even though this
535 inserts just one byte and does not overflow the buffer.
536 (Finsert_file_contents): Store file offsets as off_t
537 values, not as EMACS_INT values. Check for overflow when
538 converting between EMACS_INT and off_t. When checking for
539 buffer overflow or for overlap, take the offsets into account.
540 Don't use EMACS_INT for small values where int suffices.
541 When checking for overlap, fix a typo: ZV was used where
542 ZV_BYTE was intended.
543 (Fwrite_region): Don't assume off_t fits into 'long'.
544 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
545
546 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
547
548 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
549
550 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
551
552 sprintf-related integer and memory overflow issues (Bug#9412).
553
554 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
555 (esprintf, exprintf, evxprintf): New functions.
556 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
557 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
558 (modify_event_symbol): Do not assume that the length of
559 name_alist_or_stem is safe to alloca and fits in int.
560 (Fexecute_extended_command): Likewise for function name and binding.
561 (Frecursion_depth): Wrap around reliably on integer overflow.
562 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
563 since some callers pass EMACS_INT values.
564 (Fsingle_key_description): Don't crash if symbol name contains more
565 than MAX_ALLOCA bytes.
566 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
567 (get_minibuffer): Arg is now EMACS_INT, not int.
568 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
569 (esprintf, exprintf, evxprintf): New decls.
570 * window.h (command_loop_level, minibuf_level): Reflect API changes.
571
572 * dbusbind.c (signature_cat): New function.
573 (xd_signature, Fdbus_register_signal):
574 Do not overrun buffer; instead, report string overflow.
575
576 * dispnew.c (add_window_display_history): Don't overrun buffer.
577 Truncate instead; this is OK since it's just a log.
578
579 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
580 even if the time zone offset is outlandishly large.
581 Don't mishandle offset == INT_MIN.
582
583 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
584 when creating daemon; the previous buffer-overflow check was incorrect.
585
586 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
587 which has the guts of the old verror function.
588
589 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
590 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
591
592 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
593 (font_unparse_xlfd): Don't blindly alloca long strings.
594 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
595 fits in int, when using sprintf. Use single snprintf to count
596 length of string rather than counting it via multiple sprintfs;
597 that's simpler and more reliable.
598 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
599 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
600 sprintf, in case result does not fit in int.
601
602 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
603 (fontset_from_font): Print it.
604
605 * frame.c (tty_frame_count): Now printmax_t, not int.
606 (make_terminal_frame, set_term_frame_name): Print it.
607 (x_report_frame_params): In X, window IDs are unsigned long,
608 not signed long, so print them as unsigned.
609 (validate_x_resource_name): Check for implausibly long names,
610 and don't assume name length fits in 'int'.
611 (x_get_resource_string): Don't blindly alloca invocation name;
612 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
613 not fit in int.
614
615 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
616 (xg_check_special_colors, xg_set_geometry):
617 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
618
619 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
620 Use esprintf, not sprintf, in case result does not fit in int.
621
622 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
623 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
624 it as a large positive number.
625 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
626 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
627
628 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
629 in case result does not fit in int.
630
631 * print.c (float_to_string): Detect width overflow more reliably.
632 (print_object): Make sprintf buffer a bit bigger, to avoid potential
633 buffer overrun. Don't assume list length fits in 'int'. Treat
634 print length of 0 as 0, not as infinity; to be consistent with other
635 uses of print length in this function. Don't overflow print length
636 index. Don't assume hash table size fits in 'long', or that
637 vectorlike size fits in 'unsigned long'.
638
639 * process.c (make_process): Use printmax_t, not int, to format
640 process-name gensyms.
641
642 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
643
644 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
645 to avoid potential buffer overrun.
646
647 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
648 if X resource line is longer than 512 bytes.
649
650 * xfns.c (x_window): Make sprintf buffer a bit bigger
651 to avoid potential buffer overrun.
652
653 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
654
655 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
656
657 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
658
659 Integer overflow fixes for scrolling, etc.
660 Without these, Emacs silently mishandles large integers sometimes.
661 For example, "C-u 4294967297 M-x recenter" was treated as if
662 it were "C-u 1 M-x recenter" on a typical 64-bit host.
663
664 * xdisp.c (try_window_id): Check Emacs fixnum range before
665 converting to 'int'.
666
667 * window.c (window_scroll_line_based, Frecenter):
668 Check that an Emacs fixnum is in range before assigning it to 'int'.
669 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
670 values converted from Emacs fixnums.
671 (Frecenter): Don't wrap around a line count if it is out of 'int'
672 range; instead, treat it as an extreme value.
673 (Fset_window_configuration, compare_window_configurations):
674 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
675
676 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
677 that can exceed INT_MAX. Check that EMACS_INT value is in range
678 before assigning it to the (possibly-narrower) index.
679 (match_limit): Don't assume that a fixnum can fit in 'int'.
680
681 * print.c (print_object): Use ptrdiff_t, not int, for index that can
682 exceed INT_MAX.
683
684 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
685 (Fvertical_motion): Don't wrap around LINES values that don't fit
686 in 'int'. Instead, treat them as extreme values. This is good
687 enough for windows, which can't have more than INT_MAX lines anyway.
688
689 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
690
691 * Require libxml/parser.h to avoid compilation warning.
692
693 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
694
695 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
696 since this reportedly can destroy thread storage.
697
698 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
699
700 * syntax.c (find_defun_start): Update all cache variables if
701 exiting early (Bug#9401).
702
703 2011-08-30 Eli Zaretskii <eliz@gnu.org>
704
705 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
706
707 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
708 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
709 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
710
711 * term.c (tty_append_glyph): New function.
712 (produce_stretch_glyph): Static function and its prototype deleted.
713
714 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
715 Add prototypes.
716
717 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
718
719 * image.c (parse_image_spec): Check for nonnegative, not for positive,
720 when checking :margin (Bug#9390).
721 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
722 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
723 so that the name doesn't mislead. All uses changed.
724
725 2011-08-28 Johan Bockgård <bojohan@gnu.org>
726
727 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
728 set_tty_hooks.
729
730 2011-08-27 Eli Zaretskii <eliz@gnu.org>
731
732 * xdisp.c (move_it_to): Don't bail out early when reaching
733 position beyond to_charpos, if we are scanning backwards.
734 (move_it_vertically_backward): When DY == 0, make sure we get to
735 the first character in the line after the newline.
736
737 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
738
739 * ccl.c: Improve and simplify overflow checking (Bug#9196).
740 (ccl_driver): Do not generate an out-of-range pointer.
741 (Fccl_execute_on_string): Remove unnecessary check for
742 integer overflow, noted by Stefan Monnier in
743 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
744 Remove a FIXME that didn't need fixing.
745 Simplify the newly-introduced buffer reallocation code.
746
747 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
748
749 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
750
751 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
752
753 Integer and memory overflow issues (Bug#9196).
754
755 * doc.c (get_doc_string): Rework so that
756 get_doc_string_buffer_size is the actual buffer size, rather than
757 being 1 less than the actual buffer size; this makes xpalloc more
758 convenient.
759
760 * image.c (x_allocate_bitmap_record, cache_image):
761 * xselect.c (Fx_register_dnd_atom):
762 Simplify previous changes by using xpalloc.
763
764 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
765 since either will do and ptrdiff_t is convenient with xpalloc.
766
767 * charset.c (charset_table_size)
768 (struct charset_sort_data.priority): Now ptrdiff_t.
769 (charset_compare): Don't overflow if priorities differ greatly.
770 (Fsort_charsets): Don't assume list length fits in int.
771 Check for size-calculation overflow when allocating sort data.
772 (syms_of_charset): Allocate an initial charset table that is
773 just under 64 KiB, to avoid problems with glibc malloc and mmap.
774
775 * cmds.c (internal_self_insert): Check for size-calculation overflow.
776
777 * composite.h (struct composition.glyph_len): Now int, not unsigned.
778 The actual value is always <= INT_MAX, and leaving it unsigned made
779 overflow checking harder.
780
781 * dispextern.h (struct glyph_matrix.rows_allocated)
782 (struct face_cache.size): Now ptrdiff_t, for convenience in use
783 with xpalloc. The values are still always <= INT_MAX.
784
785 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
786
787 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
788 (SAFE_NALLOCA): New macro.
789
790 * region-cache.c (struct boundary.pos, find_cache_boundary)
791 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
792 (set_cache_region, invalidate_region_cache)
793 (revalidate_region_cache, know_region_cache, region_cache_forward)
794 (region_cache_backward, pp_cache):
795 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
796 so that ptrdiff_t * can be passed to xpalloc.
797 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
798 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
799 (pp_cache): Don't assume cache_len fits in int.
800 * region-cache.h: Adjust extern decls to match.
801
802 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
803 EMACS_INT, since either will do, for xpalloc.
804
805 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
806 (xnmalloc, xnrealloc, xpalloc): New functions.
807
808 * bidi.c (bidi_shelve_header_size): New constant.
809 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
810 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
811
812 * bidi.c (bidi_cache_shrink):
813 * buffer.c (overlays_at, overlays_in, record_overlay_string)
814 (overlay_strings):
815 Don't update size of array until after memory allocation succeeds,
816 because xmalloc/xrealloc may not return.
817 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
818 now that we have proper integer overflow checking.
819 (record_overlay_string, overlay_strings): Catch overflows when
820 calculating size of overlay_str_buf.
821
822 * callproc.c (Fcall_process): Check for size overflow when
823 calculating size of args2.
824 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
825 Normally we prefer signed values, but sticking with ptrdiff_t would
826 require adding more-complicated checks.
827
828 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
829 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
830 Redo buffer-overflow calculations to avoid integer overflow.
831 Add a FIXME comment where memory seems to be over-allocated.
832
833 * character.c (Fstring): Check for size-calculation overflow.
834
835 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
836 unnecessary integer overflow. Check for size overflow.
837 (encode_coding_object): Don't update size until xmalloc succeeds.
838
839 * composite.c (get_composition_id): Check for overflow in glyph
840 length calculations.
841
842 Integer and memory overflow fixes for display code.
843 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
844 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
845 (scrolling_window): Check for overflow in size calculations.
846 (line_draw_cost, realloc_glyph_pool, add_row_entry):
847 Don't assume glyph table len fits in int.
848 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
849 (row_table_size): Now ptrdiff_t, not int.
850 (scrolling_window): Avoid overflow in size calculations.
851 Don't update size until allocation succeeds.
852 * fns.c (concat): Check for overflow in size calculations.
853 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
854 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
855 (NEXT_ALMOST_PRIME_LIMIT): New constant.
856
857 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
858 (get_doc_string): Check for size calculation overflow.
859 Don't update size until allocation succeeds.
860 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
861 EMACS_INT, where ptrdiff_t will do.
862 (Fsubstitute_command_keys): Check for string overflow.
863
864 * editfns.c (set_time_zone_rule): Don't assume environment length
865 fits in int.
866 (message_length): Now ptrdiff_t, not int.
867 (Fmessage_box): Don't update size until allocation succeeds.
868 Don't assume message length fits in int.
869 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
870
871 * emacs.c (main): Do not reallocate argv, since there is a null at
872 the end that can be overwritten, and this way there's no need to
873 worry about size-calculation overflow.
874 (sort_args): Check for size-calculation overflow.
875
876 * eval.c (init_eval_once, grow_specpdl): Don't update size until
877 alloc succeeds.
878 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
879
880 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
881 (x_set_scroll_bar_width, x_figure_window_size):
882 Check for integer overflow.
883 (x_set_alpha): Do not assume XINT fits in int.
884
885 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
886 This is for the members text_lines, text_cols, total_lines, total_cols,
887 where the system imposes an 'int' limit.
888
889 * fringe.c (Fdefine_fringe_bitmap):
890 Don't update size until alloc works.
891
892 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
893 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
894
895 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
896 Check for size-calculation overflow.
897 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
898 do, as we prefer signed integers.
899 (id_to_widget.max_size, id_to_widget.used)
900 (xg_store_widget_in_map, xg_remove_widget_from_map)
901 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
902 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
903 Use and return ptrdiff_t, not int.
904 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
905 * gtkutil.h: Change prototypes to match the above.
906
907 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
908 are duplicate now that they've been promoted to lisp.h.
909 (x_allocate_bitmap_record, x_alloc_image_color)
910 (make_image_cache, cache_image, xpm_load):
911 Don't update size until alloc is done.
912 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
913 (x_detect_edges):
914 Check for size calculation overflow.
915 (ct_colors_allocated_max): New constant.
916 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
917 overflow.
918
919 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
920 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
921 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
922 Use ptrdiff_t, not int, to count maps.
923 (read_char_minibuf_menu_prompt): Check for overflow in size
924 calculations. Don't update size until allocation succeeds.
925 Redo calculations to avoid overflow.
926 * keyboard.h: Change prototypes to match the above.
927
928 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
929 to count maps.
930 (current_minor_maps): Check for size calculation overflow.
931 * keymap.h: Change prototypes to match the above.
932
933 * lread.c (read1, init_obarray): Don't update size until alloc done.
934
935 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
936 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
937
938 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
939 Now ptrdiff_t, not int.
940 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
941 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
942
943 * process.c (Fnetwork_interface_list): Check for overflow
944 in size calculation.
945
946 * region-cache.c (move_cache_gap): Check for size calculation overflow.
947
948 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
949 overflow. Don't bother calling xmalloc when xrealloc will do.
950
951 * search.c (Freplace_match): Check for size calculation overflow.
952 (Fset_match_data): Don't assume list lengths fit in 'int'.
953
954 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
955 for command line length. Do not attempt to address one before the
956 beginning of an array, as that's not portable.
957
958 * term.c (max_frame_lines): Remove; unused.
959 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
960 not int.
961 (encode_terminal_code, calculate_costs): Check for size
962 calculation overflow.
963 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
964 table lengths and related sizes. Don't update size until alloc
965 done. Redo calculations to avoid overflow.
966 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
967
968 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
969 subtracting pointers.
970 (gobble_line): Check for overflow more carefully. Don't update size
971 until alloc done.
972
973 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
974 Don't update size until alloc done.
975 Redo size calculations to avoid overflow.
976 Check for size calculation overflow.
977 (main) [DEBUG]: Fix typo in invoking tparam1.
978
979 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
980 Use ptrdiff_t, not int, for sizes.
981 (store_mode_line_noprop_char): Don't update size until alloc done.
982
983 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
984 Use ptrdiff_t, not int, for sizes.
985 (Finternal_make_lisp_face, cache_face):
986 Check for size calculation overflow.
987 (cache_face): Treat size calculation overflows as if they were
988 memory exhaustion (the usual treatment), rather than aborting.
989
990 * xfns.c (x_encode_text, x_set_name_internal)
991 (Fx_change_window_property): Use ptrdiff_t, not int, to count
992 sizes, since they can exceed INT_MAX in size. Check for size
993 calculation overflow.
994
995 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
996 (xg_select): Check for size calculation overflow.
997 Don't update size until alloc done.
998
999 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1000 as sprintf is limited to int lengths.
1001
1002 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1003 (X_LONG_MIN): New macros.
1004 Use them to make the following changes clearer.
1005 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1006 This change doesn't affect the value now, but it may help remind
1007 future maintainers not to raise the value too much later.
1008 (SELECTION_QUANTUM): Remove, replacing with ...
1009 (selection_quantum): ... new function, which avoids overflow.
1010 All uses changed.
1011 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1012 assumption that selection length fits in 'int'.
1013 (x_reply_selection_request, x_handle_selection_request)
1014 (x_get_window_property, receive_incremental_selection)
1015 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1016 (lisp_data_to_selection_data, clean_local_selection_data):
1017 Use ptrdiff_t, not int, to record length of selection.
1018 (x_reply_selection_request, x_get_window_property)
1019 (receive_incremental_selection, x_property_data_to_lisp):
1020 Redo calculations to avoid overflow.
1021 (x_reply_selection_request): When sending hint, ceiling it at
1022 X_LONG_MAX rather than relying on wraparound overflow to send
1023 something.
1024 (x_get_window_property, receive_incremental_selection)
1025 (lisp_data_to_selection_data, x_property_data_to_lisp):
1026 Check for size-calculation overflow.
1027 (x_get_window_property, receive_incremental_selection)
1028 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1029 Don't store size until memory allocation succeeds.
1030 (x_get_window_property): Plug memory leak on memory exhaustion.
1031 Don't double-block input; malloc is safe here. Don't assume 2**34
1032 - 4 fits in unsigned long. Add an xassert to check
1033 XGetWindowProperty overflow. Be more careful about overflow
1034 calculations, and distinguish size from memory overflow better.
1035 (receive_incremental_selection): When tracing, don't assume
1036 unsigned int is less than INT_MAX.
1037 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1038 harmful) conversions of unsigned short to int.
1039 (lisp_data_to_selection_data): Don't assume that integers
1040 in the range -65535 through -1 fit in an X unsigned short.
1041 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1042 result parameters unless successful. Rely on cons_to_unsigned
1043 to report problems with elements; the old code wasn't right anyway.
1044 (x_check_property_data): Check for int overflow; we cannot use
1045 a wider type due to X limits.
1046 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1047
1048 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1049
1050 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1051 (x_term_init): Check for size calculation overflow.
1052 (x_color_cells): Don't store size until memory allocation succeeds.
1053 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1054 Don't assume alloca size is less than MAX_ALLOCA.
1055 (x_term_init): Don't assume length fits in int (sprintf is limited
1056 to int size).
1057
1058 Use ptrdiff_t for composition IDs.
1059 * character.c (lisp_string_width):
1060 * composite.c (composition_table_size, n_compositions)
1061 (get_composition_id, composition_gstring_from_id):
1062 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1063 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1064 * window.c (Frecenter):
1065 Use ptrdiff_t, not int, for composition IDs.
1066 * composite.c (get_composition_id): Check for integer overflow.
1067 * composite.h: Adjust prototypes to match the above changes.
1068
1069 Use ptrdiff_t for hash table indexes.
1070 * category.c (hash_get_category_set):
1071 * ccl.c (ccl_driver):
1072 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1073 * coding.c (coding_system_charset_list, detect_coding_system):
1074 * coding.h (struct coding_system.id):
1075 * composite.c (get_composition_id, gstring_lookup_cache):
1076 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1077 * image.c (xpm_get_color_table_h):
1078 * lisp.h (hash_lookup, hash_put):
1079 * minibuf.c (Ftest_completion):
1080 Use ptrdiff_t for hash table indexes, not int (which is too
1081 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1082 32-bit --with-wide-int hosts).
1083
1084 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1085 Add a FIXME comment about memory leaks.
1086 (syms_of_charset): Don't assume xmalloc returns.
1087
1088 Don't assume that stated character widths fit in int.
1089 * character.c (Fchar_width, c_string_width, lisp_string_width):
1090 * character.h (CHAR_WIDTH):
1091 * indent.c (MULTIBYTE_BYTES_WIDTH):
1092 Use sanitize_char_width to avoid undefined and/or bad behavior
1093 with outlandish widths.
1094 * character.h (sanitize_tab_width): Rename from sanitize_width,
1095 now that we have two such functions. All uses changed.
1096 (sanitize_char_width): New inline function.
1097
1098 Don't assume that tab-width fits in int.
1099 * character.h (sanitize_width): New inline function.
1100 (SANE_TAB_WIDTH): New macro.
1101 (ASCII_CHAR_WIDTH): Use it.
1102 * indent.c (sane_tab_width): Remove. All uses replaced by
1103 SANE_TAB_WIDTH (current_buffer).
1104 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1105
1106 * fileio.c: Integer overflow issues with file modes.
1107 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1108
1109 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1110 Remove unreachable code.
1111 (read_hex, load_charset_map_from_file): Check for integer overflow.
1112
1113 * xterm.c: don't go over XClientMessageEvent limit
1114 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1115 (x_send_scroll_bar_event): Likewise. Check that the size does not
1116 exceed limits imposed by XClientMessageEvent, as well as the usual
1117 ptrdiff_t and size_t limits.
1118
1119 * keyboard.c: Overflow, signedness and related fixes.
1120 (make_lispy_movement): Use same integer type in forward decl
1121 that is used in the definition.
1122 (read_key_sequence, keyremap_step):
1123 Change bufsize argument back to int, undoing my 2011-03-30 change.
1124 We prefer signed types, and int is wide enough here.
1125 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1126 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1127 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1128 length, not size_t. Use ptrdiff_t for index, not int.
1129 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1130 possibility of integer overflow.
1131
1132 Overflow, signedness and related fixes for images.
1133
1134 * dispextern.h (struct it.stack[0].u.image.image_id)
1135 (struct_it.image_id, struct image.id, struct image_cache.size)
1136 (struct image_cache.used, struct image_cache.ref_count):
1137 * gtkutil.c (update_frame_tool_bar):
1138 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1139 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1140 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1141 * nsmenu.m (update_frame_tool_bar):
1142 * xdisp.c (calc_pixel_width_or_height):
1143 * xfns.c (image_cache_refcount):
1144 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1145 on typical 64-bit hosts.
1146
1147 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1148 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1149 Omit unnecessary casts to int.
1150 (parse_image_spec): Check that integers fall into 'int' range
1151 when the callers expect that.
1152 (image_ascent): Redo ascent calculation to avoid int overflow.
1153 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1154 (lookup_image): Remove unnecessary tests.
1155 (xbm_image_p): Locals are now of int, not EMACS_INT,
1156 since parse_image_check makes sure they fit into int.
1157 (png_load, gif_load, svg_load_image):
1158 Prefer int to unsigned where either will do.
1159 (tiff_handler): New function, combining the cores of the
1160 old tiff_error_handler and tiff_warning_handler.
1161 This function is rewritten to use vsnprintf and thereby avoid
1162 stack buffer overflows. It uses only the features of vsnprintf
1163 that are common to both POSIX and native Microsoft.
1164 (tiff_error_handler, tiff_warning_handler): Use it.
1165 (tiff_load, gif_load, imagemagick_load_image):
1166 Don't assume :index value fits in 'int'.
1167 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1168 (imagemagick_load_image): Check that crop parameters fit into
1169 the integer types that MagickCropImage accepts. Don't assume
1170 Vimagemagick_render_type has a nonnegative value. Don't assume
1171 size_t fits in 'long'.
1172 (gs_load): Use printmax_t to print the widest integers possible.
1173 Check for integer overflow when computing image height and width.
1174
1175 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1176
1177 * xdisp.c (redisplay_window): Don't force window start if point
1178 will be invisible in the resulting window. (Bug#9324)
1179
1180 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1181
1182 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1183 the display spec is of the form `(space ...)'.
1184 (handle_display_spec): Return the value returned by
1185 handle_single_display_spec, not just 1 or zero.
1186 (handle_single_display_spec): If the display spec is of the form
1187 `(space ...)', and specifies display in the text area, return 2
1188 rather than 1.
1189 (try_cursor_movement): Check for the need to scroll more
1190 accurately, and prefer exact match for point under bidi.
1191 Don't advance `row' beyond the last row of the window.
1192
1193 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1194 into disp_prop; all users changed.
1195
1196 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1197 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1198 for the text covered by the display property.
1199
1200 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1201
1202 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1203 Change return value to nil.
1204 (Frecord_buffer): Delete unused function.
1205
1206 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1207
1208 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1209 buffers, return left-to-right.
1210 (set_cursor_from_row): Consider candidate row a win if its glyph
1211 represents a newline and point is on that newline. Fixes cursor
1212 positioning on the newline at EOL of R2L text within L2R
1213 paragraph, and vice versa.
1214 (try_cursor_movement): Check continued rows, in addition to
1215 continuation rows. Fixes unwarranted scroll when point enters a
1216 continued line of R2L text within an L2R paragraph, or vice versa.
1217 (cursor_row_p): Consider the case of point being equal to
1218 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1219 from the end of a short line to the beginning of a continued line
1220 of R2L text within L2R paragraph.
1221 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1222 composed characters.
1223
1224 * bidi.c (bidi_check_type): Use xassert.
1225 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1226 members.
1227
1228 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1229
1230 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1231 a character.
1232
1233 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1234
1235 * nsfont.m (ns_otf_to_script): Fix typo.
1236
1237 2011-08-22 Kenichi Handa <handa@m17n.org>
1238
1239 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1240 extra slot even if the purpose is char-code-property-table.
1241
1242 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1243
1244 * xdisp.c (redisplay_window): When computing centering_position,
1245 account for the height of the header line. (Bug#8874)
1246
1247 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1248 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1249 candidate is selected by the mouse, and that candidate has a
1250 composed character under the mouse.
1251
1252 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1253 coordinates reported by pos-visible-in-window-p for a composed
1254 character in column zero.
1255
1256 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1257
1258 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1259
1260 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1261
1262 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1263 consider it a hit if to_charpos is anywhere in the range of the
1264 composed buffer positions.
1265
1266 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1267
1268 * image.c (gif_load): Don't assume that each subimage has the same
1269 dimensions as the base image. Handle disposal method that is
1270 "undefined" by the gif spec (Bug#9335).
1271
1272 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1273
1274 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1275 (Fcondition_case): Document `debug' symbol in error handler.
1276
1277 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1278
1279 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1280 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1281 from an Org mode buffer to a Speedbar frame.
1282
1283 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1284 a composition, take its buffer position from IT->cmp_it.charpos.
1285 Fixes cursor positioning at the beginning of a line that begins
1286 with a composed character.
1287
1288 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1289
1290 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1291 character bidirectional type, use STRONG_L instead. Fixes crashes
1292 in a buffer produced by `describe-categories'.
1293
1294 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1295 members before the level stack, so they would be saved and
1296 restored when copying iterator state. Fixes incorrect reordering
1297 around TABs covered by display properties.
1298
1299 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1300
1301 * process.c (Fnetwork_interface_list): Correctly determine buffer
1302 size.
1303
1304 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1305
1306 * eval.c (internal_condition_case, internal_condition_case_1)
1307 (internal_condition_case_2, internal_condition_case_n):
1308 Remove unnecessary aborts (Bug#9081).
1309
1310 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1311
1312 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1313 has no `load' handler, try opening the file locally. (Bug#9311)
1314
1315 2011-08-16 Ken Brown <kbrown@cornell.edu>
1316
1317 * gmalloc.c: Expand comment.
1318
1319 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1320
1321 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1322 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1323
1324 2011-08-16 Ken Brown <kbrown@cornell.edu>
1325
1326 Fix memory allocation problems in Cygwin build (Bug#9273).
1327
1328 * unexcw.c ( __malloc_initialized): Declare external variable.
1329 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1330
1331 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1332 New variables.
1333 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1334 dumped emacs.
1335 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1336 in the static heap.
1337 [CYGWIN] (special_realloc): New function.
1338 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1339 requests to realloc storage in the static heap.
1340
1341 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1342
1343 * bidi.c (bidi_initialize): Remove unused local.
1344
1345 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1346
1347 * biditype.h: File removed.
1348
1349 * bidimirror.h: File removed.
1350
1351 * deps.mk (bidi.o): Remove biditype.h and
1352 bidimirror.h.
1353
1354 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1355 bidimirror.h.
1356
1357 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1358
1359 * chartab.c: Improve commentary for the uniprop_table API.
1360
1361 * bidi.c (bidi_paragraph_init): Support zero value of
1362 bidi_ignore_explicit_marks_for_paragraph_level.
1363 (bidi_initialize): Use uniprop_table instead of including
1364 biditype.h and bidimirror.h.
1365
1366 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1367 coordinates of the iterator when restoring from ppos_it.
1368 (Bug#9296)
1369
1370 2011-08-14 Kenichi Handa <handa@m17n.org>
1371
1372 * process.c (create_process): Call setup_process_coding_systems
1373 after the pid of the process is set to -1 (Bug#8162).
1374
1375 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1376
1377 * xdisp.c (move_it_in_display_line_to): Don't invoke
1378 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1379 ppos_it. Fixes vertical cursor motion when line beginning is
1380 covered by an image. (Bug#9296)
1381
1382 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1383
1384 * nsterm.h (ns_run_ascript): Declare.
1385 (NSAPP_DATA2_RUNASSCRIPT): Define.
1386
1387 * nsfns.m (as_script, as_result, as_status): New static variables.
1388 (ns_run_ascript): New function.
1389 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1390 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1391 the event loop. Get status from as_status (Bug#7276).
1392
1393 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1394 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1395 the event loop (Bug#7276).
1396
1397 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1398
1399 * gnutls.c (QCgnutls_bootprop_priority)
1400 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1401 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1402 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1403 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1404 (QCgnutls_bootprop_verify_hostname_error)
1405 (QCgnutls_bootprop_callbacks_verify): Rename from
1406 Qgnutls_bootprop_..., all uses changed.
1407
1408 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1409 uses changed.
1410
1411 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1412
1413 * xfaces.c (Qframe_set_background_mode): Now static.
1414 * dispextern.h (Qframe_set_background_mode): Remove decl.
1415
1416 * process.c (Fnetwork_interface_info): Declare local only if needed.
1417
1418 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1419
1420 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1421 (Fnetwork_interface_list): Allocate in increments of bytes instead
1422 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1423 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1424 sockaddr.
1425 (struct ifflag_def): notrailers is smart on OSX.
1426 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1427 Get hardware address with getifaddrs if available.
1428
1429 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1430
1431 * xdisp.c (iterate_out_of_display_property): xassert that
1432 IT->position is set to within IT->object's boundaries. Break from
1433 the loop as soon as EOB is reached; avoids infloops in redisplay
1434 when IT->position is set up wrongly due to some bug.
1435 Set IT->current to match the bidi iterator unconditionally.
1436 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1437 entry. Force push_it to save on the stack the current
1438 buffer/string position, to be restored by pop_it. Fix flags in
1439 the iterator structure wrt the object coming from a display
1440 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1441 properties. (Bug#9284)
1442
1443 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1444
1445 * fontset.c (fontset_get_font_group): Add proper type checks.
1446 (Bug#9172)
1447
1448 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1449
1450 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1451 and LC_VERSION_MIN_MACOSX.
1452 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1453 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1454
1455 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1456
1457 * xdisp.c (forward_to_next_line_start): Allow to use the
1458 no-display-properties-and-no-overlays under bidi display.
1459 Set disp_pos in the bidi iterator to avoid searches for display
1460 properties and overlays.
1461
1462 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1463
1464 * editfns.c (Fset_time_zone_rule): Document relationship with the
1465 setenv function.
1466
1467 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1468 the font entity extracted from the cache (Bug#8109).
1469
1470 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1471
1472 * composite.c (autocmp_chars): Don't reset point. That is done by
1473 restore_point_unwind (Bug#5984).
1474
1475 2011-08-07 Juri Linkov <juri@jurta.org>
1476
1477 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1478 to show the arg `TIME' instead of `TIMEVAL'.
1479
1480 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1481
1482 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1483 display property strides EOL and includes a newline, as in
1484 longlines-mode. (Bug#9254)
1485 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1486 word-wrap under bidirectional display. (Bug#9224)
1487
1488 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1489 is non-zero, even if the data buffer is NULL. Fixes a crash in
1490 vertical-motion with longlines-mode. (Bug#9254)
1491
1492 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1493
1494 * bidi.c <bidi_cache_total_alloc>: Now static.
1495 (bidi_initialize): Initialize bidi_cache_total_alloc.
1496
1497 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1498 cache. (Bug#9221)
1499
1500 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1501 amount allocated this far in `bidi_cache_total_alloc'.
1502 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1503 non-zero, only free the data buffer without restoring the cache
1504 contents. All callers changed.
1505
1506 * dispextern.h (bidi_unshelve_cache): Update prototype.
1507
1508 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1509 (move_it_in_display_line, move_it_to)
1510 (move_it_vertically_backward, move_it_by_lines): Replace the call
1511 to xfree to an equivalent call to bidi_unshelve_cache.
1512 (move_it_in_display_line_to): Fix logic of returning
1513 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1514
1515 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1516
1517 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1518 came from a string character with a `cursor' property. (Bug#9229)
1519
1520 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1521
1522 * Makefile.in (LIB_PTHREAD): New variable.
1523 (LIBES): Add LIB_PTHREAD (Bug#9216).
1524
1525 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1526 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1527
1528 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1529
1530 * regex.c (re_iswctype): Remove some redundant boolean
1531 conversions.
1532
1533 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1534
1535 * xterm.c (x_find_topmost_parent): New function.
1536 (x_set_frame_alpha): Find topmost parent window with
1537 x_find_topmost_parent and set the property there also (bug#9181).
1538 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1539
1540 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1541
1542 * callproc.c (Fcall_process): Avoid vfork clobbering
1543 the local vars buffer, coding_systems, current_dir.
1544
1545 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1546
1547 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1548
1549 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1550
1551 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1552 so that it is not optimized away.
1553
1554 * xdisp.c (compute_display_string_pos): Remove unused local.
1555
1556 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1557
1558 Fix slow cursor motion and scrolling in large buffers with
1559 selective display, like Org Mode buffers. (Bug#9218)
1560
1561 * dispextern.h (struct bidi_it): New member disp_prop_p.
1562
1563 * xdisp.c: Remove one-slot cache of display string positions.
1564 (compute_display_string_pos): Accept an additional argument
1565 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1566 for a display string or property. If found, set DISP_PROP_P
1567 non-zero.
1568
1569 * bidi.c (bidi_fetch_char): Accept an additional argument
1570 DISP_PROP_P, and pass it to compute_display_string_pos.
1571 Only handle text covered by a display string if DISP_PROP_P is returned
1572 non-zero. All callers of bidi_fetch_char changed.
1573
1574 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1575
1576 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1577
1578 2010-12-03 Don March <don@ohspite.net>
1579
1580 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1581 last character M-[char] is translated to ESC [char] (bug#7541).
1582
1583 2011-08-02 Kenichi Handa <handa@m17n.org>
1584
1585 * lisp.h (uniprop_table): Extern it.
1586
1587 * chartab.c (uniprop_table): Make it non-static.
1588
1589 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1590
1591 * xdisp.c (forward_to_next_line_start): Accept additional argument
1592 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1593 on the newline.
1594 (reseat_at_next_visible_line_start): Use the bidi iterator state
1595 returned by forward_to_next_line_start to restore the state of
1596 it->bidi_it after backing up to previous newline. (Bug#9212)
1597
1598 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1599
1600 * regex.c (re_comp): Protoize.
1601 (re_exec): Fix return type.
1602 (regexec): Fix type of `ret'. (Bug#9203)
1603
1604 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1605
1606 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1607 This is needed if max-image-size is a floating-point number.
1608
1609 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1610
1611 * print.c (print_object): Print empty symbol as ##.
1612
1613 * lread.c (read1): Read ## as empty symbol.
1614
1615 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1616
1617 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1618 setting frame foreground color (Bug#9175).
1619 (x_set_background_color): Likewise.
1620
1621 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1622 contents (Bug#9176).
1623 (EmacsTooltip -init): Remove bezels and add shadows to
1624 tooltip windows.
1625
1626 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1627 or scroll bar (Bug#8470).
1628
1629 * nsfont.m (nsfont_open): Remove assignment to voffset and
1630 unnecessary vars hshink, expand, hd, full_height, min_height.
1631 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1632
1633 * nsterm.h (nsfont_info): Remove voffset field.
1634
1635 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1636
1637 Implement strike-through and overline on NextStep (Bug#8863).
1638
1639 * nsfont.m (nsfont_open): Use underline position provided by font,
1640 instead of hard-coded value of 2.
1641 (nsfont_draw): Call ns_draw_text_decoration instead.
1642
1643 * nsterm.h: Add declaration for ns_draw_text_decoration.
1644
1645 * nsterm.m (ns_draw_text_decoration): New function for drawing
1646 underline, overline, and strike-through.
1647 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1648 ns_draw_text_decoration. Change treatment of cursor drawing to
1649 accommodate underlining, etc.
1650
1651 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1652
1653 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1654 default.
1655
1656 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1657
1658 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1659 Without this fix, if a signal arrives just after memory fills up,
1660 'malloc' might be invoked reentrantly.
1661
1662 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1663 In other words, assume that every image size is allowed, on non-X
1664 hosts. This assumption is probably wrong, but it lets Emacs compile.
1665
1666 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1667
1668 * regex.c (re_iswctype): Convert return values to boolean.
1669
1670 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1671
1672 * xdisp.c (compute_display_string_pos): Don't use cached display
1673 string position if the buffer had its restriction changed.
1674 (Bug#9184)
1675
1676 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1677
1678 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1679
1680 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1681
1682 Integer signedness and overflow and related fixes. (Bug#9079)
1683
1684 * bidi.c: Integer size and overflow fixes.
1685 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1686 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1687 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1688 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1689 (bidi_find_other_level_edge):
1690 Use ptrdiff_t instead of EMACS_INT where either will do.
1691 This works better on 32-bit hosts configured --with-wide-int.
1692 (bidi_cache_ensure_space): Check for size-calculation overflow.
1693 Use % rather than repeated addition, for better worst-case speed.
1694 Don't set bidi_cache_size until after xrealloc returns, because it
1695 might not return.
1696 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1697 (bidi_cache_ensure_space): Also check that the bidi cache size
1698 does not exceed that of the largest Lisp string or buffer. See Eli
1699 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1700
1701 * alloc.c (__malloc_size_t): Remove.
1702 All uses replaced by size_t. See Andreas Schwab's note
1703 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1704
1705 * image.c: Improve checking for integer overflow.
1706 (check_image_size): Assume that f is nonnull, since
1707 it is always nonnull in practice. This is one less thing to
1708 worry about when checking for integer overflow later.
1709 (x_check_image_size): New function, which checks for integer
1710 overflow issues inside X.
1711 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1712 This removes the need for a memory_full check.
1713 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1714 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1715 (xbm_read_bitmap_data): Change locals back to 'int', since
1716 their values must fit in 'int'.
1717 (xpm_load_image, png_load, tiff_load):
1718 Invoke x_create_x_image_and_pixmap earlier,
1719 to avoid much needless work if the image is too large.
1720 (tiff_load): Treat overly large images as if
1721 x_create_x_image_and_pixmap failed, not as malloc failures.
1722 (gs_load): Use x_check_image_size.
1723
1724 * gtkutil.c: Omit integer casts.
1725 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1726 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1727
1728 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1729
1730 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1731 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1732 would wrongly return t on a 64-bit host.
1733
1734 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1735 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1736 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1737 and therefore cause GCC to emit a bogus diagnostic in some cases.
1738
1739 * image.c: Integer signedness and overflow and related fixes.
1740 This is not an exhaustive set of fixes, but it's time to
1741 record what I've got.
1742 (lookup_pixel_color, check_image_size): Remove redundant decls.
1743 (check_image_size): Don't assume that arbitrary EMACS_INT values
1744 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1745 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1746 (tiff_load, imagemagick_load_image):
1747 Check for overflow in size calculations.
1748 (x_create_x_image_and_pixmap): Remove unnecessary test for
1749 xmalloc returning NULL; that can't happen.
1750 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1751 (xpm_color_bucket): Use better integer hashing function.
1752 (xpm_cache_color): Don't possibly over-allocate memory.
1753 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1754 (gif_memory_source):
1755 Use ptrdiff_t, not int or size_t, to record sizes.
1756 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1757 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1758 either works, as we prefer signed integers.
1759 (tiff_read_from_memory, tiff_write_from_memory):
1760 Return tsize_t, not size_t, since that's what the TIFF API wants.
1761 (tiff_read_from_memory): Don't fail simply because the read would
1762 go past EOF; instead, return a short read.
1763 (tiff_load): Omit no-longer-needed casts.
1764 (Fimagemagick_types): Don't assume size fits into 'int'.
1765
1766 Improve hashing quality when configured --with-wide-int.
1767 * fns.c (hash_string): New function, taken from sxhash_string.
1768 Do not discard information about ASCII character case; this
1769 discarding is no longer needed.
1770 (sxhash-string): Use it. Change sig to match it. Caller changed.
1771 * lisp.h: Declare it.
1772 * lread.c (hash_string): Remove, since we now use fns.c's version.
1773 The fns.c version returns a wider integer if --with-wide-int is
1774 specified, so this should help the quality of the hashing a bit.
1775
1776 * emacs.c: Integer overflow minor fix.
1777 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1778 Define only if GNU_LINUX.
1779 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1780
1781 * dispnew.c: Integer signedness and overflow fixes.
1782 Remove unnecessary forward decls, that were a maintenance hassle.
1783 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1784 All uses changed.
1785 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1786 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1787 (prepare_desired_row, line_draw_cost):
1788 Use int, not unsigned, where either works.
1789 (save_current_matrix, restore_current_matrix):
1790 Use ptrdiff_t, not size_t, where either works.
1791 (init_display): Check for overflow more accurately, and without
1792 relying on undefined behavior.
1793
1794 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1795 Remove, replacing with the new symbols in lisp.h. All uses changed.
1796 * fileio.c (make_temp_name):
1797 * filelock.c (lock_file_1, lock_file):
1798 * xdisp.c (message_dolog):
1799 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1800 Use pMd etc. instead.
1801 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1802 replacing the pWIDE etc. symbols removed from editfns.c.
1803
1804 * keyboard.h (num_input_events): Now uintmax_t.
1805 This is (very slightly) less likely to mess up due to wraparound.
1806 All uses changed.
1807
1808 * buffer.c: Integer signedness fixes.
1809 (alloc_buffer_text, enlarge_buffer_text):
1810 Use ptrdiff_t rather than size_t when either will do, as we prefer
1811 signed integers.
1812
1813 * alloc.c: Integer signedness and overflow fixes.
1814 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1815 (__malloc_size_t): Default to size_t, not to int.
1816 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1817 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1818 Prefer ptrdiff_t to size_t when either would do, as we prefer
1819 signed integers.
1820 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1821 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1822 Now const. Initialize with values that are in range even if char
1823 is signed.
1824 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1825 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1826 These functions do the right thing with sizes > 2**32.
1827 (check_depth): Now ptrdiff_t, not int.
1828 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1829 Adjust to new way of storing sizes. Check for size overflow bugs
1830 in rest of code.
1831 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1832 slightly wrong anyway, as it missed one instance of
1833 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1834 (refill_memory_reserve): Omit needless cast to size_t.
1835 (mark_object_loop_halt): Mark as externally visible.
1836
1837 * xselect.c: Integer signedness and overflow fixes.
1838 (Fx_register_dnd_atom, x_handle_dnd_message):
1839 Use ptrdiff_t, not size_t, since we prefer signed.
1840 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1841 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1842 x_dnd_atoms_size and x_dnd_atoms_length.
1843
1844 * doprnt.c: Prefer signed to unsigned when either works.
1845 * eval.c (verror):
1846 * doprnt.c (doprnt):
1847 * lisp.h (doprnt):
1848 * xdisp.c (vmessage):
1849 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1850 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1851 prefer signed arithmetic to avoid comparison confusion.
1852 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1853 but is a bit tricky.
1854
1855 Assume freestanding C89 headers, string.h, stdlib.h.
1856 * data.c, doprnt.c, floatfns.c, print.c:
1857 Include float.h unconditionally.
1858 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1859 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1860 * regex.c: Likewise for stddef.h, string.h.
1861 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1862 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1863 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1864 (STDC_HEADERS): Remove obsolete defines.
1865 * sysdep.c: Include limits.h unconditionally.
1866
1867 Assume support for memcmp, memcpy, memmove, memset.
1868 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1869 * regex.c (memcmp, memcpy):
1870 Remove; we assume C89 now.
1871
1872 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1873 (__malloc_safe_bcopy): Remove; no longer needed.
1874
1875 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1876 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1877 well either way, and we prefer signed to unsigned.
1878
1879 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1880
1881 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1882 closes the connection while we're reading (bug#9182).
1883
1884 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1885
1886 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1887 are specified (Bug#9168).
1888
1889 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1890
1891 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1892 Found by GCC static checking and --with-wide-int on a 32-bit host.
1893
1894 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1895
1896 * xdisp.c (compute_display_string_pos): Fix logic of caching
1897 previous display string position. Initialize cached_prev_pos to
1898 -1. Fixes slow-down at the beginning of a buffer.
1899
1900 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1901
1902 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1903 for attrs[LFACE_FONTSET_INDEX].
1904
1905 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1906
1907 * xml.c (parse_region): Remove unused local
1908 that was recently introduced.
1909
1910 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1911
1912 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1913 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1914
1915 * xdisp.c (move_it_in_display_line_to): Record the best matching
1916 position for TO_CHARPOS while scanning the line, and restore it on
1917 exit if none of the characters scanned was an exact match.
1918 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1919 when exact match is impossible due to invisible text, and the
1920 lines are truncated.
1921
1922 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1923
1924 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1925 for OSX >= 10.7.
1926
1927 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1928
1929 Fix a significant slow-down of cursor motion with C-n, C-p,
1930 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1931 auto-repeat under bidi redisplay in fontified buffers.
1932 * xdisp.c (compute_stop_pos_backwards): New function.
1933 (next_element_from_buffer): Call compute_stop_pos_backwards to
1934 find a suitable prev_stop when we find ourselves before
1935 base_level_stop.
1936 (reseat): Don't look for prev_stop, as that could mean a very long
1937 run.
1938 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1939 <cached_disp_overlay_modiff>: Cache for last found display string
1940 position.
1941 (compute_display_string_pos): Return the cached position if asked
1942 about the same buffer in the same area of character positions, and
1943 the buffer wasn't changed since the time the display string
1944 position was cached.
1945
1946 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1947
1948 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1949 is an integer, which is important for empty lines. (Bug#9149)
1950
1951 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1952
1953 * frame.c (Fmodify_frame_parameters): In tty case, update the
1954 default face if necessary (Bug#4238).
1955
1956 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1957
1958 * editfns.c (Fstring_to_char): No need to explain what a character
1959 is in the docstring (Bug#6576).
1960
1961 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1962
1963 * xml.c (parse_region): Make sure we always return a tree.
1964
1965 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1966
1967 * xml.c (parse_region): If a document contains only comments,
1968 return that, too.
1969
1970 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1971
1972 * xml.c (make_dom): Return comments, too.
1973
1974 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1975
1976 Port to OpenBSD.
1977 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1978 and the surrounding thread.
1979 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1980 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1981 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1982 timer goes off.
1983 * s/openbsd.h (BROKEN_SIGIO): Define.
1984 * unexelf.c (unexec) [__OpenBSD__]:
1985 Don't update the .mdebug section of the Alpha COFF symbol table.
1986
1987 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1988
1989 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1990 (bug#8460).
1991
1992 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1995 This fixes some race conditions on the permissions of any newly
1996 created file.
1997
1998 * alloc.c (valid_pointer_p): Use pipe, not open.
1999 This fixes some permissions issues when debugging.
2000
2001 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2002 If fchown fails to set both uid and gid, try to set just gid,
2003 as that is sometimes allowed. Adjust the file's mode to eliminate
2004 setuid or setgid bits that are inappropriate if fchown fails.
2005
2006 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2007
2008 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2009 to compare Lisp_Objects.
2010 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2011 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2012 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2013
2014 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2015
2016 * lread.c (read_integer): Unread even EOF character.
2017 (read1): Likewise. Properly record start position of symbol.
2018
2019 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2020 symbol character follows.
2021
2022 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2025 This works around a problem with the previous change to Fcopy_file.
2026 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2027 and without this change, GCC might complain about discarding
2028 fchown's return value.
2029
2030 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2031
2032 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2033
2034 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2035
2036 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2037
2038 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2039
2040 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2041 it's used from the C level.
2042
2043 * process.c: Use the same condition for POLL_FOR_INPUT in both
2044 keyboard.c and process.c (bug#1858).
2045
2046 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2047
2048 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2049 (Fgnutls_boot): Use it.
2050
2051 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2052
2053 * doc.c (Fsubstitute_command_keys): Revert last change.
2054
2055 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2056
2057 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2058 quotes the next character, and doesn't affect other longer
2059 sequences (bug#8935).
2060
2061 * lread.c (syms_of_lread): Clarify that is isn't only
2062 `eval-buffer' and `eval-defun' that's affected by
2063 `lexical-binding' (bug#8460).
2064
2065 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2066
2067 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2068 bidi redisplay when a line includes both an image and is
2069 truncated.
2070
2071 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 Fix minor problems found by static checking.
2074 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2075 (elsz): Now a signed constant, not a size_t var. We prefer signed
2076 types to unsigned, to avoid integer comparison confusion. Without
2077 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2078 "cannot optimize loop, the loop counter may overflow", a symptom
2079 of the confusion.
2080 * indent.c (Fvertical_motion): Mark locals as initialized.
2081 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2082
2083 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2084
2085 * search.c (Fre_search_backward): Mention `case-fold-search' in
2086 all the re_search_* functions (bug#8138).
2087
2088 * keyboard.c (Fopen_dribble_file): Document when the file is
2089 closed (bug#8056).
2090
2091 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2092
2093 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2094 bidi_cache_idx.
2095
2096 Support bidi reordering of display and overlay strings.
2097 * xdisp.c (compute_display_string_pos)
2098 (compute_display_string_end): Accept additional argument STRING.
2099 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2100 (reseat_to_string): Initialize bidi_it->string.s and
2101 bidi_it->string.schars.
2102 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2103 NULL (avoids a crash in bidi_paragraph_init).
2104 Initialize itb.string.lstring.
2105 (init_iterator): Call bidi_init_it only of a valid
2106 buffer position was specified. Initialize paragraph_embedding to
2107 L2R.
2108 (reseat_to_string): Initialize the bidi iterator.
2109 (display_string): If we need to ignore text properties of
2110 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2111 original value of -1 will not work with bidi.)
2112 (compute_display_string_pos): First arg is now struct
2113 `text_pos *'; all callers changed. Support display properties on
2114 Lisp strings.
2115 (compute_display_string_end): Support display properties on Lisp
2116 strings.
2117 (init_iterator, reseat_1, reseat_to_string): Initialize the
2118 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2119 when iterating on a string not from display properties).
2120 (compute_display_string_pos, compute_display_string_end):
2121 Fix calculation of the object to scan. Fixes an error when using
2122 arrow keys.
2123 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2124 base_level_stop; instead, set base_level_stop to BEGV.
2125 Fixes crashes in vertical-motion.
2126 (next_element_from_buffer): Improve commentary for when
2127 the iterator is before prev_stop.
2128 (init_iterator): Initialize bidi_p from the default value of
2129 bidi-display-reordering, not from buffer-local value. Use the
2130 buffer-local value only if initializing for buffer iteration.
2131 (handle_invisible_prop): Support invisible properties on strings
2132 that are being bidi-reordered.
2133 (set_iterator_to_next): Support bidi reordering of C strings and
2134 Lisp strings.
2135 (next_element_from_string): Support bidi reordering of Lisp
2136 strings.
2137 (handle_stop_backwards): Support Lisp strings as well.
2138 (display_string): Support display of R2L glyph rows.
2139 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2140 (init_iterator): Don't initialize it->bidi_p for strings
2141 here.
2142 (reseat_to_string): Initialize it->bidi_p for strings here.
2143 (next_element_from_string, next_element_from_c_string)
2144 (next_element_from_buffer): Add xassert's for correspondence
2145 between IT's object being iterated and it->bidi_it.string
2146 structure.
2147 (face_before_or_after_it_pos): Support bidi iteration.
2148 (next_element_from_c_string): Handle the case of the first string
2149 character that is not the first one in the visual order.
2150 (get_visually_first_element): New function, refactored from common
2151 parts of next_element_from_buffer, next_element_from_string, and
2152 next_element_from_c_string.
2153 (tool_bar_lines_needed, redisplay_tool_bar)
2154 (display_menu_bar): Force left-to-right direction. Add a FIXME
2155 comment for making that be controlled by a user option.
2156 (push_it, pop_it): Save and restore the state of the
2157 bidi iterator. Save and restore the bidi_p flag.
2158 (pop_it): Iterate out of display property for string iteration as
2159 well.
2160 (iterate_out_of_display_property): Support iteration over strings.
2161 (handle_single_display_spec): Set up it->bidi_it for iteration
2162 over a display string, and call bidi_init_it.
2163 (handle_single_display_spec, next_overlay_string)
2164 (get_overlay_strings_1, push_display_prop): Set up the bidi
2165 iterator for displaying display or overlay strings.
2166 (forward_to_next_line_start): Don't use the shortcut if
2167 bidi-iterating.
2168 (back_to_previous_visible_line_start): If handle_display_prop
2169 pushed the iterator stack, restore the internal state of the bidi
2170 iterator by calling bidi_pop_it same number of times.
2171 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2172 and we are bidi-iterating, don't decrement the iterator position;
2173 instead, set the first_elt flag in the bidi iterator, to produce
2174 the same effect.
2175 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2176 (push_display_prop): xassert that we are iterating a buffer.
2177 (push_it, pop_it): Save and restore paragraph_embedding member.
2178 (handle_single_display_spec, next_overlay_string)
2179 (get_overlay_strings_1, reseat_1, reseat_to_string)
2180 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2181 correctly. Don't assume unibyte strings are not bidi-reordered.
2182 (compute_display_string_pos)
2183 (compute_display_string_end): Fix handling the case of C string.
2184 (push_it, pop_it): Save and restore from_disp_prop_p.
2185 (handle_single_display_spec, push_display_prop): Set the
2186 from_disp_prop_p flag.
2187 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2188 (pop_it): Call iterate_out_of_display_property only if we are
2189 popping after iteration over a string that came from a display
2190 property. Fix a typo in popping stretch info. Add an assertion
2191 for verifying that the iterator position is in sync with the bidi
2192 iterator.
2193 (handle_single_display_spec, get_overlay_strings_1)
2194 (push_display_prop): Fix initialization of paragraph direction for
2195 string when that of the parent object is not yet determined.
2196 (reseat_1): Call bidi_init_it to resync the bidi
2197 iterator with IT's position. (Bug#7616)
2198 (find_row_edges): If ROW->start.pos gives position
2199 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2200 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2201 Reset the from_disp_prop_p flag.
2202 (SAVE_IT, RESTORE_IT): New macros.
2203 (pos_visible_p, face_before_or_after_it_pos)
2204 (back_to_previous_visible_line_start)
2205 (move_it_in_display_line_to, move_it_in_display_line)
2206 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2207 (try_scrolling, redisplay_window, display_line): Use them when
2208 saving a temporary copy of the iterator and restoring it back.
2209 (back_to_previous_visible_line_start, reseat_1)
2210 (init_iterator): Empty the bidi cache "stack".
2211 (move_it_in_display_line_to): If iterator ended up at
2212 EOL, but we never saw any buffer positions smaller than
2213 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2214 motion in bidi-reordered lines.
2215 (move_it_in_display_line_to): Record prev_method and prev_pos
2216 immediately before the call to set_iterator_to_next. Fixes cursor
2217 motion in bidi-reordered lines with stretch glyphs and strings
2218 displayed in margins. (Bug#8133) (Bug#8867)
2219 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2220 TO_CHARPOS.
2221 (pos_visible_p): Support positions in bidi-reordered lines.
2222 Save and restore bidi cache.
2223
2224 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2225 (bidi_paragraph_info): Delete unused struct.
2226 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2227 (bidi_cache_start): New variable.
2228 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2229 to zero.
2230 (bidi_cache_fetch_state, bidi_cache_search)
2231 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2232 (bidi_cache_find, bidi_peek_at_next_level)
2233 (bidi_level_of_next_char, bidi_find_other_level_edge)
2234 (bidi_move_to_visually_next): Compare cache index with
2235 bidi_cache_start rather than with zero.
2236 (bidi_fetch_char): Accept new argument STRING; all callers
2237 changed. Support iteration over a string. Support strings with
2238 display properties. Support unibyte strings. Fix the type of
2239 `len' according to what STRING_CHAR_AND_LENGTH expects.
2240 (bidi_paragraph_init, bidi_resolve_explicit_1)
2241 (bidi_resolve_explicit, bidi_resolve_weak)
2242 (bidi_level_of_next_char, bidi_move_to_visually_next):
2243 Support iteration over a string.
2244 (bidi_set_sor_type, bidi_resolve_explicit_1)
2245 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2246 can now be zero (for strings); special values 0 and -1 were
2247 changed to -1 and -2, respectively.
2248 (bidi_char_at_pos): New function.
2249 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2250 Call it instead of FETCH_MULTIBYTE_CHAR.
2251 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2252 initialized to valid values.
2253 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2254 values.
2255 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2256 the test for valid cached positions. Fix the logic for looking up
2257 the sentinel state in the cache. GCPRO the Lisp string we are
2258 iterating.
2259 (bidi_push_it, bidi_pop_it): New functions.
2260 (bidi_initialize): Initialize the bidi cache start stack pointer.
2261 (bidi_cache_ensure_space): New function, refactored from part of
2262 bidi_cache_iterator_state. Don't assume the required size is just
2263 one BIDI_CACHE_CHUNK away.
2264 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2265 (bidi_count_bytes, bidi_char_at_pos): New functions.
2266 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2267 always valid if bidi_cache_idx is valid.
2268 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2269 is valid if it's going to be used.
2270 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2271 (bidi_cache_fetch_state, bidi_cache_search)
2272 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2273 (bidi_cache_iterator_state, bidi_cache_find)
2274 (bidi_find_other_level_edge, bidi_cache_start_stack):
2275 All variables related to cache indices are now EMACS_INT.
2276
2277 * dispextern.h (struct bidi_string_data): New structure.
2278 (struct bidi_it): New member `string'. Make flag members be 1-bit
2279 fields, and put them last in the struct.
2280 (compute_display_string_pos, compute_display_string_end):
2281 Update prototypes.
2282 (bidi_push_it, bidi_pop_it): Add prototypes.
2283 (struct iterator_stack_entry): New members bidi_p,
2284 paragraph_embedding, and from_disp_prop_p.
2285 (struct it): Member bidi_p is now a bit field 1 bit wide.
2286 (bidi_shelve_cache, bidi_unshelve_cache):
2287 Declare prototypes.
2288
2289 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2290 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2291 and vector-like objects.
2292
2293 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2294 cache around display iteration.
2295
2296 * window.c (Fwindow_end, window_scroll_pixel_based)
2297 (displayed_window_lines, Frecenter): Save and restore the bidi
2298 cache around display iteration.
2299
2300 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2301
2302 * editfns.c (Fdelete_region): Clarify the use of the named
2303 parameters (bug#6788).
2304
2305 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2306
2307 * indent.c (Fvertical_motion): Set and restore w->pointm when
2308 saving and restoring the window's buffer (Bug#9006).
2309
2310 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2311
2312 * editfns.c (Fstring_to_char): Clarify just what is returned
2313 (bug#6576). Text by Eli Zaretskii.
2314
2315 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2316
2317 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2318
2319 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2320
2321 * buffer.c (mmap_find): Fix a typo.
2322
2323 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2324
2325 Fix execution of x selection hooks.
2326 * xselect.c (Qx_lost_selection_functions)
2327 (Qx_sent_selection_functions): New vars.
2328 (syms_of_xselect): DEFSYM them.
2329 (x_handle_selection_request): Pass Qx_sent_selection_functions
2330 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2331 (x_handle_selection_clear,x_clear_frame_selections):
2332 Pass Qx_lost_selection_functions rather than
2333 Vx_lost_selection_functions to Frun_hook_with_args.
2334
2335 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2336
2337 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2338 The old code sometimes used this field without initializing it.
2339
2340 * alloc.c (gc_sweep): Don't read past end of array.
2341 In theory, the old code could also have corrupted Emacs internals,
2342 though it'd be very unlikely.
2343
2344 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2345
2346 * character.c (Fcharacterp): Don't advertise optional ignored
2347 argument. (Bug#4026)
2348
2349 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2350
2351 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2352 key" (bug#4257).
2353
2354 * window.c (Fset_window_start): Doc fix (bug#4199).
2355 (Fset_window_hscroll): Ditto.
2356
2357 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2358
2359 Fix minor new problems caught by GCC 4.6.1.
2360 * term.c (init_tty): Remove unused local.
2361 * xsettings.c (store_monospaced_changed): Define this function only
2362 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2363 not used otherwise.
2364
2365 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2366
2367 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2368
2369 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2370
2371 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2372 are the mini-buffer and the echo area (bug#3320).
2373
2374 * term.c (init_tty): Remove support for supdup, c10 and perq
2375 terminals, which are no longer supported (bug#1482).
2376
2377 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2378
2379 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2380
2381 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2382
2383 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2384 for non-popups (Bug#3642).
2385
2386 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2387
2388 * alloc.c (reset_malloc_hooks): Protoize.
2389 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2390 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2391 * cm.c (losecursor): Likewise.
2392 * data.c (fmod): Likewise.
2393 * dispnew.c (swap_glyphs_in_rows): Likewise.
2394 * emacs.c (memory_warning_signal): Likewise.
2395 * floatfns.c (float_error): Likewise.
2396 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2397 (otf_open, font_otf_capability, generate_otf_features)
2398 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2399 Likewise.
2400 * image.c (pbm_read_file): Likewise.
2401 * indent.c (string_display_width): Likewise.
2402 * intervals.c (check_for_interval, search_for_interval)
2403 (inc_interval_count, count_intervals, root_interval)
2404 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2405 * lread.c (defalias): Likewise.
2406 * ralloc.c (r_alloc_check): Likewise.
2407 * regex.c (set_image_of_range_1, set_image_of_range)
2408 (regex_grow_registers): Likewise.
2409 * sysdep.c (strerror): Likewise.
2410 * termcap.c (valid_filename_p, tprint, main): Likewise.
2411 * tparam.c (main): Likewise.
2412 * unexhp9k800.c (run_time_remap, save_data_space)
2413 (update_file_ptrs, read_header, write_header, calculate_checksum)
2414 (copy_file, copy_rest, display_header): Likewise.
2415 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2416 Likewise.
2417 * xdisp.c (check_it): Likewise.
2418 * xfaces.c (register_color, unregister_color, unregister_colors):
2419 Likewise.
2420 * xfns.c (print_fontset_result): Likewise.
2421 * xrdb.c (member, fatal, main): Likewise.
2422
2423 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2424
2425 Fix minor problems found by static checking (Bug#9031).
2426 * chartab.c (char_table_set_range, map_sub_char_table):
2427 Remove unused locals.
2428 (uniprop_table): Now static.
2429 * composite.c (_work_char): Remove unused static var.
2430
2431 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2432
2433 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2434
2435 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2436
2437 * gtkutil.c (qttip_cb): Remove code without function.
2438
2439 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2440
2441 * w32.c (pthread_sigmask): New stub.
2442
2443 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2444
2445 Use pthread_sigmask, not sigprocmask (Bug#9010).
2446 sigprocmask is portable only for single-threaded applications, and
2447 Emacs can be multi-threaded when it uses GTK.
2448 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2449 (LIBES): Use it.
2450 * callproc.c (Fcall_process):
2451 * process.c (create_process):
2452 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2453 Use pthread_sigmask, not sigprocmask.
2454
2455 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2456
2457 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2458 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2459 wrong (Bug#8591).
2460
2461 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2462
2463 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2464 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2465 (xg_hide_tooltip): Fix comment.
2466
2467 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2468 in registerServicesMenuSendTypes.
2469 (validRequestorForSendType): Don't check ns_return_types.
2470
2471 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2472 ns_return_type.
2473
2474 2011-07-08 Jason Rumney <jasonr@gnu.org>
2475
2476 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2477 frame struct members of non-existent frames (Bug#6284).
2478
2479 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2480
2481 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2482 variable firstTime not needed on OSX >= 10.6.
2483 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2484 >= 10.5. Use setKnobProportion, setDoubleValue.
2485
2486 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2487 (MAC_OS_X_VERSION_10_5): Define if not defined.
2488 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2489 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2490 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2491
2492 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2493 cString and lossyCString on OSX >= 10.4
2494
2495 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2496 sizeToFit on OSX >= 10.2.
2497
2498 * nsimage.m (allocInitFromFile): Don't use deprecated method
2499 bestRepresentationForDevice on OSX >= 10.6.
2500
2501 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2502 to avoid warning.
2503
2504 * emacs.c: Declare unexec_init_emacs_zone.
2505
2506 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2507
2508 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2509
2510 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2511 on svcsMenu (Bug#8842).
2512
2513 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2514 ns_return_types.
2515 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2516
2517 * nsterm.m (QUTF8_STRING): Declare.
2518 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2519 (validRequestorForSendType): Return type is (id).
2520 Change indexOfObjectIdenticalTo to indexOfObject.
2521 Check if we have local selection before returning self (Bug#8842).
2522 (writeSelectionToPasteboard): Put local selection into paste board
2523 if we have a local selection (Bug#8842).
2524 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2525
2526 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2527 (ns_get_local_selection): Declare.
2528
2529 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2530
2531 * keymap.c (describe_map_tree): Don't insert a double newline at
2532 the end of the buffer (bug#1169) and return whether we inserted
2533 something.
2534
2535 * callint.c (Fcall_interactively): Change "reading args" to
2536 "providing args" to try to clarify what it does (bug#1010).
2537
2538 2011-07-07 Kenichi Handa <handa@m17n.org>
2539
2540 * composite.c (composition_compute_stop_pos): Ignore a static
2541 composition starting before CHARPOS (Bug#8915).
2542
2543 * xdisp.c (handle_composition_prop): Likewise.
2544
2545 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2546
2547 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2548 (Bug#9015)
2549
2550 2011-07-07 Kenichi Handa <handa@m17n.org>
2551
2552 * character.h (unicode_category_t): New enum type.
2553
2554 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2555 (Qchar_code_property_table): New variable.
2556 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2557 (UNIPROP_COMPRESSED_FORM_P): New macros.
2558 (char_table_ascii): Uncompress the compressed values.
2559 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2560 Uncompress the compressed values.
2561 (sub_char_table_ref_and_range): Likewise.
2562 (char_table_ref_and_range): Uncompress the compressed values.
2563 (sub_char_table_set): New arg is_uniprop. Callers changed.
2564 Uncompress the compressed values.
2565 (sub_char_table_set_range): Args changed. Callers changed.
2566 (char_table_set_range): Adjuted for the above change.
2567 (map_sub_char_table): Delete args default_val and parent. Add arg
2568 top. Give decoded values to a Lisp function.
2569 (map_char_table): Adjust for the above change. Give decoded
2570 values to a Lisp function. Gcpro more variables.
2571 (uniprop_table_uncompress)
2572 (uniprop_decode_value_run_length): New functions.
2573 (uniprop_decoder, uniprop_decoder_count): New variables.
2574 (uniprop_get_decoder, uniprop_encode_value_character)
2575 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2576 New functions.
2577 (uniprop_encoder, uniprop_encoder_count): New variables.
2578 (uniprop_get_encoder, uniprop_table)
2579 (Funicode_property_table_internal, Fget_unicode_property_internal)
2580 (Fput_unicode_property_internal): New functions.
2581 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2582 Sunicode_property_table_internal, Sget_unicode_property_internal,
2583 and Sput_unicode_property_internal. Defvar_lisp
2584 char-code-property-alist.
2585
2586 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2587 Vunicode_category_table.
2588
2589 * font.c (font_range): Adjust for the change of
2590 Vunicode_category_table.
2591
2592 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2593
2594 * m/iris4d.h: Remove file, move contents ...
2595 * s/irix6-5.h: ... here.
2596
2597 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2598
2599 Remove unportable assumption about struct layout (Bug#8884).
2600 * alloc.c (mark_buffer):
2601 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2602 (clone_per_buffer_values): Don't assume that
2603 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2604 This isn't true in general, and it's particularly not true
2605 if Emacs is configured with --with-wide-int.
2606 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2607 New macros, used in the buffer.c change.
2608
2609 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2610
2611 * xsettings.c: Use both GConf and GSettings if both are available.
2612 (store_config_changed_event): Add comment.
2613 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2614 (store_tool_bar_style_changed): New functions.
2615 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2616 (struct xsettings): Move font inside HAVE_XFT.
2617 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2618 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2619 Move inside HAVE_XFT.
2620 (something_changed_gsettingsCB): Rename from something_changedCB.
2621 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2622 also.
2623 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2624 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2625 (something_changed_gconfCB): Rename from something_changedCB.
2626 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2627 (parse_settings): Move check for font inside HAVE_XFT.
2628 (read_settings, apply_xft_settings): Add comment.
2629 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2630 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2631 call store_font_name_changed.
2632 (xft_settings_event): Add comment.
2633 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2634 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2635 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2636 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2637 (xsettings_initialize): Call init_gsettings last.
2638 (xsettings_get_system_font, xsettings_get_system_normal_font):
2639 Add comment.
2640
2641 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 Random fixes. E.g., (random) never returned negative values.
2644 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2645 subseconds part to the entropy, as that's a bit more random.
2646 Prefer signed to unsigned, since the signedness doesn't matter and
2647 in general we prefer signed. When given a limit, use a
2648 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2649 latter isn't right if USE_2_TAGS_FOR_INTS.
2650 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2651 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2652
2653 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2654
2655 * textprop.c (text_property_stickiness):
2656 Obey Vtext_property_default_nonsticky.
2657 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2658 * w32fns.c (syms_of_w32fns):
2659 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2660
2661 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2662
2663 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2664 This is more efficient than Ffile_directory_p and avoids a minor race.
2665
2666 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2667
2668 * buffer.c (Foverlay_put): Say what the return value is
2669 (bug#7835).
2670
2671 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2672 is a directory before asking whether to use the file name
2673 (bug#7564).
2674 (barf_or_query_if_file_exists): Make the "File is a directory"
2675 error be more correct.
2676
2677 * fns.c (Frequire): Remove the mention of the .gz files, since
2678 that's installation-specific, but keep the mention of
2679 `get-load-suffixes'.
2680
2681 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2682
2683 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2684 Report string overflow if the output is too long.
2685
2686 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2687
2688 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2689 (syms_of_gnutls): Remove duplicate DEFSYM for
2690 Qgnutls_bootprop_verify_hostname_error, an error for
2691 Qgnutls_bootprop_verify_error (which is no longer used).
2692
2693 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2694 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2695 Also (re)move comments that are misplaced or no longer relevant.
2696
2697 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2698
2699 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2700
2701 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2702
2703 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2704 and background color parameters if they have been changed.
2705
2706 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2707
2708 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2709
2710 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2711
2712 * xsettings.c (SYSTEM_FONT): Define only when used.
2713 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2714
2715 * keymap.c (access_keymap_1): Now static.
2716
2717 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2718
2719 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2720 leave any prefix arg for the up event (Bug#1586).
2721
2722 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2723
2724 * lread.c (syms_of_lread): Mention single symbols defined by
2725 `defvar' or `defconst' (bug#7154).
2726
2727 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2728 (Frequire): Mention get-load-suffixes.
2729
2730 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2731
2732 * window.h (window): Remove clone_number slot.
2733 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2734 Remove.
2735 (make_parent_window, make_window, saved_window)
2736 (Fset_window_configuration, save_window_save): Don't deal with
2737 clone numbers.
2738 * buffer.c (Qclone_number): Remove declaration.
2739 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2740
2741 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2742
2743 Add multiple inheritance to keymaps.
2744 * keymap.c (Fmake_composed_keymap): New function.
2745 (Fset_keymap_parent): Simplify.
2746 (fix_submap_inheritance): Remove.
2747 (access_keymap_1): New function extracted from access_keymap to handle
2748 embedded parents and handle lists of maps.
2749 (access_keymap): Use it.
2750 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2751 (Fcopy_keymap): Handle embedded parents.
2752 (Fcommand_remapping, define_as_prefix): Simplify.
2753 (Fkey_binding): Simplify.
2754 (syms_of_keymap): Move minibuffer-local-completion-map,
2755 minibuffer-local-filename-completion-map,
2756 minibuffer-local-must-match-map, and
2757 minibuffer-local-filename-must-match-map to Elisp.
2758 (syms_of_keymap): Defsubr make-composed-keymap.
2759 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2760 (parse_menu_item): Trivial simplification.
2761
2762 2011-07-01 Glenn Morris <rgm@gnu.org>
2763
2764 * Makefile.in (SETTINGS_LIBS): Fix typo.
2765
2766 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2767
2768 * coding.c (Fencode_coding_string): Record the last coding system
2769 used, as the function doc string says (bug#8738).
2770
2771 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2772
2773 * xsettings.c (store_monospaced_changed): Take new font as arg and
2774 check for change against current_mono_font.
2775 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2776 (emacs_settings_constructor, emacs_settings_get_property)
2777 (emacs_settings_set_property, emacs_settings_class_init)
2778 (emacs_settings_init, gsettings_obj): Remove.
2779 (something_changedCB): New function for HAVE_GSETTINGS.
2780 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2781 with value as argument.
2782 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2783 g_settings_new (Bug#8967). Do not create gsettings_obj.
2784 Remove calls to g_settings_bind. Connect something_changedCB to
2785 "changed".
2786
2787 * xgselect.c: Add defined (HAVE_GSETTINGS).
2788 (xgselect_initialize): Ditto.
2789
2790 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2791 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2792 xg_select.
2793
2794 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2795
2796 * eval.c (struct backtrace): Simplify and port the data structure.
2797 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2798 signed bit field, as this assumption is not portable and it makes
2799 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2800 "char debug_on_exit : 1" as this is not portable either; instead,
2801 use the portable "unsigned int debug_on_exit : 1". Remove unused
2802 member evalargs. Remove obsolete comments about cc bombing out.
2803
2804 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2805
2806 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2807 Let HAVE_GSETTINGS override HAVE_GCONF.
2808 (store_monospaced_changed): New function.
2809 (EMACS_SETTINGS): A new type derived from GObject to handle
2810 GSettings notifications.
2811 (emacs_settings_constructor, emacs_settings_get_property)
2812 (emacs_settings_set_property, emacs_settings_class_init):
2813 New functions.
2814 (gsettings_client, gsettings_obj): New variables.
2815 (GSETTINGS_SCHEMA): New define.
2816 (something_changedCB): Call store_monospaced_changed.
2817 (init_gsettings): New function.
2818 (xsettings_initialize): Call init_gsettings.
2819 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2820 to NULL.
2821
2822 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2823 GCONF_CFLAGS/LIBS.
2824
2825 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2826
2827 * window.c (resize_root_window, grow_mini_window)
2828 (shrink_mini_window): Rename Qresize_root_window to
2829 Qwindow_resize_root_window and Qresize_root_window_vertically to
2830 Qwindow_resize_root_window_vertically.
2831
2832 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2833
2834 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2835
2836 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2837
2838 * makefile.w32-in: Redesign dependencies so they reflect more
2839 clearly which files are directly included by each source file,
2840 and not through other includes.
2841
2842 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2843
2844 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2845 (sort_overlays, overlay_strings): When an overlay's clone number
2846 matches the window's clone number process the overlay even if
2847 the overlay's window property doesn't match the current window.
2848
2849 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2850 (Fwindow_hchild): Rename to Fwindow_left_child.
2851 (Fwindow_next): Rename to Fwindow_next_sibling.
2852 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2853 (resize_window_check): Rename to window_resize_check.
2854 (resize_window_apply): Rename to window_resize_apply.
2855 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2856 (Fdelete_other_windows_internal, resize_frame_windows)
2857 (Fsplit_window_internal, Fdelete_window_internal)
2858 (grow_mini_window, shrink_mini_window)
2859 (Fresize_mini_window_internal): Fix callers accordingly.
2860
2861 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2862
2863 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2864 (emacs_fixed_set_min_size): Remove.
2865 (emacs_fixed_new): Take frame as argument.
2866
2867 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2868 (_EmacsFixedPrivate): Remove minwidth/height.
2869 Add struct frame *f.
2870 (emacs_fixed_init): Initialize priv->f.
2871 (get_parent_class, emacs_fixed_set_min_size): Remove.
2872 (emacs_fixed_new): Set priv->f to argument.
2873 (emacs_fixed_get_preferred_width)
2874 (emacs_fixed_get_preferred_height): Use min_width/height from
2875 frames size_hint to set minimum and natural (Bug#8919).
2876 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2877 and use min_width/height from frames size_hint to set
2878 min_width/height (Bug#8919).
2879
2880 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2881 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2882 Fix indentation.
2883
2884 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2885
2886 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2887 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2888 called at ZV.
2889
2890 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2891
2892 * process.c (wait_reading_process_output): Bypass select if
2893 waiting for a cell while ignoring keyboard input, and input is
2894 pending. Suggested by Jan Djärv (Bug#8869).
2895
2896 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2897
2898 Use gnulib's dup2 module instead of rolling our own.
2899 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2900
2901 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2902
2903 * dispnew.c (scrolling_window): Before scrolling, turn off a
2904 mouse-highlight in the window being scrolled.
2905
2906 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2907
2908 Move DEFSYM to lisp.h and use everywhere.
2909
2910 * character.h (DEFSYM): Move declaration...
2911 * lisp.h (DEFSYM): ...here.
2912
2913 * gnutls.c:
2914 * minibuf.c:
2915 * w32menu.c:
2916 * w32proc.c:
2917 * w32select.c: Don't include character.h.
2918
2919 * alloc.c (syms_of_alloc):
2920 * buffer.c (syms_of_buffer):
2921 * bytecode.c (syms_of_bytecode):
2922 * callint.c (syms_of_callint):
2923 * casefiddle.c (syms_of_casefiddle):
2924 * casetab.c (init_casetab_once):
2925 * category.c (init_category_once, syms_of_category):
2926 * ccl.c (syms_of_ccl):
2927 * cmds.c (syms_of_cmds):
2928 * composite.c (syms_of_composite):
2929 * dbusbind.c (syms_of_dbusbind):
2930 * dired.c (syms_of_dired):
2931 * dispnew.c (syms_of_display):
2932 * doc.c (syms_of_doc):
2933 * editfns.c (syms_of_editfns):
2934 * emacs.c (syms_of_emacs):
2935 * eval.c (syms_of_eval):
2936 * fileio.c (syms_of_fileio):
2937 * fns.c (syms_of_fns):
2938 * frame.c (syms_of_frame):
2939 * fringe.c (syms_of_fringe):
2940 * insdel.c (syms_of_insdel):
2941 * keymap.c (syms_of_keymap):
2942 * lread.c (init_obarray, syms_of_lread):
2943 * macros.c (syms_of_macros):
2944 * msdos.c (syms_of_msdos):
2945 * print.c (syms_of_print):
2946 * process.c (syms_of_process):
2947 * search.c (syms_of_search):
2948 * sound.c (syms_of_sound):
2949 * syntax.c (init_syntax_once, syms_of_syntax):
2950 * terminal.c (syms_of_terminal):
2951 * textprop.c (syms_of_textprop):
2952 * undo.c (syms_of_undo):
2953 * w32.c (globals_of_w32):
2954 * window.c (syms_of_window):
2955 * xdisp.c (syms_of_xdisp):
2956 * xfaces.c (syms_of_xfaces):
2957 * xfns.c (syms_of_xfns):
2958 * xmenu.c (syms_of_xmenu):
2959 * xsettings.c (syms_of_xsettings):
2960 * xterm.c (syms_of_xterm): Use DEFSYM.
2961
2962 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2963
2964 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2965
2966 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2967
2968 Integer and buffer overflow fixes (Bug#8873).
2969
2970 * print.c (printchar, strout): Check for string overflow.
2971 (PRINTPREPARE, printchar, strout):
2972 Don't set size unless allocation succeeds.
2973
2974 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2975 for sizes. Check for string overflow more accurately.
2976 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2977
2978 * macros.c: Integer and buffer overflow fixes.
2979 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2980 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2981 Use ptrdiff_t, not int, for sizes.
2982 Don't increment bufsize until after realloc succeeds.
2983 Check for size-calculation overflow.
2984 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2985
2986 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2987
2988 * lread.c: Integer overflow fixes.
2989 (read_integer): Radix is now EMACS_INT, not int,
2990 to improve quality of diagnostics for out-of-range radices.
2991 Calculate buffer size correctly for out-of-range radices.
2992 (read1): Check for integer overflow in radices, and in
2993 read-circle numbers.
2994 (read_escape): Avoid int overflow.
2995 (Fload, openp, read_buffer_size, read1)
2996 (substitute_object_recurse, read_vector, read_list, map_obarray):
2997 Use ptrdiff_t, not int, for sizes.
2998 (read1): Use EMACS_INT, not int, for sizes.
2999 Check for size overflow.
3000
3001 * image.c (cache_image): Check for size arithmetic overflow.
3002
3003 * lread.c: Integer overflow issues.
3004 (saved_doc_string_size, saved_doc_string_length)
3005 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3006 Now ptrdiff_t, not int.
3007 (read1): Don't assume doc string length fits in int. Check for
3008 out-of-range doc string lengths.
3009 (read_list): Don't assume file position fits in int.
3010 (read_escape): Check for hex character overflow.
3011
3012 2011-06-22 Leo Liu <sdl.web@gmail.com>
3013
3014 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3015 Move to minibuffer.el.
3016
3017 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3020 The following patches are for when GLYPH_DEBUG && !XASSERT.
3021 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3022 * dispnew.c (flush_stdout):
3023 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3024 Mark as externally visible.
3025 * dispnew.c (check_window_matrix_pointers): Now static.
3026 * dispnew.c (window_to_frame_vpos):
3027 * xfns.c (unwind_create_frame):
3028 * xterm.c (x_check_font): Remove unused local.
3029 * scroll.c (CHECK_BOUNDS):
3030 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3031 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3032 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3033 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3034 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3035 Now static.
3036 (debug_method_add): Use va_list and vsprintf rather than relying
3037 on undefined behavior with wrong number of arguments.
3038 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3039 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3040 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3041 since we're not interested in debugging glyphs with old libraries.
3042 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3043 GCC 4.6.0's static checking.
3044
3045 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3046
3047 Integer overflow and signedness fixes (Bug#8873).
3048 A few related buffer overrun fixes, too.
3049
3050 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3051
3052 * dispextern.h (struct face.stipple):
3053 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3054 (x_bitmap_mask, x_allocate_bitmap_record)
3055 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3056 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3057 (x_create_bitmap_from_xpm_data):
3058 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3059 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3060 (.bitmaps_last):
3061 * xfaces.c (load_pixmap):
3062 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3063 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3064 (.bitmaps_last, struct x_output.icon_bitmap):
3065 Use ptrdiff_t, not int, for bitmap indexes.
3066 (x_allocate_bitmap_record): Check for size overflow.
3067 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3068
3069 Use ptrdiff_t, not int, for overlay counts.
3070 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3071 * editfns.c (overlays_around, get_pos_property):
3072 * textprop.c (get_char_property_and_overlay):
3073 * xdisp.c (next_overlay_change, note_mouse_highlight):
3074 * xfaces.c (face_at_buffer_position):
3075 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3076 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3077 (Fnext_overlay_change, Fprevious_overlay_change)
3078 (mouse_face_overlay_overlaps, Foverlays_in):
3079 Use ptrdiff_t, not int, for sizes.
3080 (overlays_at, overlays_in): Check for size-calculation overflow.
3081
3082 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3083
3084 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3085 (x_session_initialize): Do not assume string length fits in int.
3086
3087 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3088 This is unlikely, but can occur if DPI is outlandish.
3089
3090 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3091 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3092
3093 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3094 * xrdb.c (magic_file_p, search_magic_path):
3095 Omit last arg SUFFIX; it was always 0. All callers changed.
3096 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3097
3098 * xfont.c (xfont_match): Avoid need for strlen.
3099
3100 * xfns.c: Don't assume strlen fits in int.
3101 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3102
3103 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3104 not unsigned long, as we prefer signed integers. All callers changed.
3105 Detect integer overflow in repeat count.
3106 (message_dolog): Don't assume print length fits in 39 bytes.
3107 (display_mode_element): Don't assume strlen fits in int.
3108
3109 * termcap.c: Don't assume sizes fit in int and never overflow.
3110 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3111 (gobble_line): Check for size-calculation overflow.
3112
3113 * minibuf.c (Fread_buffer):
3114 * lread.c (intern, intern_c_string):
3115 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3116 Don't assume string length fits in int.
3117
3118 * keyboard.c (parse_tool_bar_item):
3119 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3120
3121 * font.c: Don't assume string length fits in int.
3122 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3123 Use ptrdiff_t, not int.
3124 (font_intern_prop): Don't assume string length fits in int.
3125 Don't assume integer property fits in fixnum.
3126 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3127
3128 * filelock.c: Fix some buffer overrun and integer overflow issues.
3129 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3130 Reformulate so as not to need the command string.
3131 Invoke gzip -cd rather than gunzip, as it's more portable.
3132 (lock_info_type, lock_file_1, lock_file):
3133 Don't assume pid_t and time_t fit in unsigned long.
3134 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3135 (current_lock_owner): Prefer signed type for sizes.
3136 Use memcpy, not strncpy, where memcpy is what is really wanted.
3137 Don't assume (via atoi) that time_t and pid_t fit in int.
3138 Check for time_t and/or pid_t out of range, e.g., via a network share.
3139 Don't alloca where an auto var works fine.
3140
3141 * fileio.c: Fix some integer overflow issues.
3142 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3143 Don't assume string length fits in int.
3144 (directory_file_name): Don't assume string length fits in long.
3145 (make_temp_name): Don't assume pid fits in int, or that its print
3146 length is less than 20.
3147
3148 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3149
3150 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3151
3152 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3153
3154 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3155 We prefer signed integers, even for size calculations.
3156
3157 * emacs.c: Don't assume string length fits in 'int'.
3158 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3159 (main): Don't invoke strlen when not needed.
3160
3161 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3162 (XD_DEBUG_MESSAGE): Don't waste a byte.
3163
3164 * callproc.c (getenv_internal_1, getenv_internal)
3165 (Fgetenv_internal):
3166 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3167
3168 * lread.c (invalid_syntax): Omit length argument.
3169 All uses changed. This doesn't fix a bug, but it simplifies the
3170 code away from its former Hollerith-constant appearance, and it's
3171 one less 'int' to worry about when looking at integer-overflow issues.
3172 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3173
3174 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3175 This didn't break anything, but it didn't help either.
3176 It's confusing to put a bogus integer in a place where the actual
3177 value does not matter.
3178 (LIST_END_P): Remove unused macro and its bogus comment.
3179 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3180
3181 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3182 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3183 implementation.
3184 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3185 We prefer signed types, and the value cannot exceed the EMACS_INT
3186 range anyway (because otherwise the length would not be representable).
3187 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3188 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3189 This avoids a GCC warning when WIDE_EMACS_INT.
3190
3191 * indent.c (sane_tab_width): New function.
3192 (current_column, scan_for_column, Findent_to, position_indentation)
3193 (compute_motion): Use it. This is just for clarity.
3194 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3195
3196 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3197
3198 * lisp.h (lint_assume): New macro.
3199 * composite.c (composition_gstring_put_cache):
3200 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3201
3202 * editfns.c, insdel.c:
3203 Omit unnecessary forward decls, to simplify future changes.
3204
3205 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3206
3207 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3208
3209 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3210 Use much-faster test for byte-length change.
3211 Don't assume string byte-length fits in 'int'.
3212 Check that character arg fits in 'int'.
3213 (mapcar1): Declare byte as byte, for clarity.
3214
3215 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3216
3217 * fns.c (concat): Catch string overflow earlier.
3218 Do not rely on integer wraparound.
3219
3220 * dispextern.h (struct it.overlay_strings_charpos)
3221 (struct it.selective): Now EMACS_INT, not int.
3222 * xdisp.c (forward_to_next_line_start)
3223 (back_to_previous_visible_line_start)
3224 (reseat_at_next_visible_line_start, next_element_from_buffer):
3225 Don't arbitrarily truncate the value of 'selective' to int.
3226
3227 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3228
3229 * composite.c: Don't truncate sizes to 'int'.
3230 (composition_gstring_p, composition_reseat_it)
3231 (composition_adjust_point): Use EMACS_INT, not int.
3232 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3233 not EMACS_UINT, for indexes.
3234
3235 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3236
3237 * buffer.c: Include <verify.h>.
3238 (struct sortvec.priority, struct sortstr.priority):
3239 Now EMACS_INT, not int.
3240 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3241 (struct sortstr.size, record_overlay_string)
3242 (struct sortstrlist.size, struct sortlist.used):
3243 Don't truncate size to int.
3244 (record_overlay_string): Check for size-calculation overflow.
3245 (init_buffer_once): Check at compile-time, not run-time.
3246
3247 2011-06-22 Jim Meyering <meyering@redhat.com>
3248
3249 Don't leak an XBM-image-sized buffer
3250 * image.c (xbm_load): Free the image buffer after using it.
3251
3252 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3253
3254 Port to Sun C.
3255 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3256 that Sun C diagnosed.
3257 * fns.c (secure_hash): Fix pointer signedness issue.
3258 * intervals.c (static_offset_intervals): New function.
3259 (offset_intervals): Use it.
3260
3261 2011-06-21 Leo Liu <sdl.web@gmail.com>
3262
3263 * deps.mk (fns.o):
3264 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3265 sha512.h.
3266
3267 * fns.c (secure_hash): Rename from crypto_hash_function and change
3268 the first arg to accept symbols.
3269 (Fsecure_hash): New primitive.
3270 (syms_of_fns): New symbols.
3271
3272 2011-06-20 Deniz Dogan <deniz@dogan.se>
3273
3274 * process.c (Fset_process_buffer): Clarify return value in
3275 docstring.
3276
3277 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3278
3279 * dispnew.c (add_window_display_history): Use BVAR.
3280
3281 * xdisp.c (debug_method_add): Use BVAR.
3282 (check_window_end, dump_glyph_matrix, dump_glyph)
3283 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3284
3285 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3286 Likewise.
3287
3288 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3289 check till after the cache is created in init_frame_faces.
3290
3291 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3292
3293 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3294
3295 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3296
3297 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3298 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3299 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3300
3301 Improve buffer-overflow checking (Bug#8873).
3302 * fileio.c (Finsert_file_contents):
3303 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3304 Remove the old (too-loose) buffer overflow checks.
3305 They weren't needed, since make_gap checks for buffer overflow.
3306 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3307 The old code merely checked for Emacs fixnum overflow, and relied
3308 on undefined (wraparound) behavior. The new code avoids undefined
3309 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3310
3311 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3312 Tune. Don't use wider integers than needed. Don't use alloca.
3313 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3314
3315 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3316
3317 * insdel.c, lisp.h (buffer_overflow): New function.
3318 (insert_from_buffer_1, replace_range, replace_range_2):
3319 * insdel.c (make_gap_larger):
3320 * editfns.c (Finsert_char):
3321 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3322
3323 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3324
3325 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3326
3327 Integer overflow and signedness fixes (Bug#8873).
3328
3329 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3330 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3331
3332 * fileio.c: Don't assume EMACS_INT fits in off_t.
3333 (emacs_lseek): New static function.
3334 (Finsert_file_contents, Fwrite_region): Use it.
3335 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3336
3337 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3338
3339 * fns.c: Don't overflow int when computing a list length.
3340 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3341 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3342 truncation on 64-bit hosts. Check for QUIT every
3343 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3344 faster and is responsive enough.
3345 (Flength): Report an error instead of overflowing an integer.
3346 (Fsafe_length): Return a float if the value is not representable
3347 as a fixnum. This shouldn't happen except in contrived situations.
3348 (Fnthcdr, Fsort): Don't assume list length fits in int.
3349 (Fcopy_sequence): Don't assume vector length fits in int.
3350
3351 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3352 (header_size, word_size): New constants.
3353 (allocate_vectorlike): Don't check size overflow here.
3354 (allocate_vector): Check it here instead, since this is the only
3355 caller of allocate_vectorlike that could cause overflow.
3356 Check that the new vector's length is representable as a fixnum.
3357
3358 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3359 The previous code was bogus. For example, next_almost_prime (32)
3360 returned 39, which is undesirable as it is a multiple of 3; and
3361 next_almost_prime (24) returned 25, which is a multiple of 5 so
3362 why was the code bothering to check for multiples of 7?
3363
3364 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3365
3366 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3367
3368 Variadic C functions now count arguments with ptrdiff_t.
3369 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3370 Back then I didn't know that the Emacs coding style prefers signed int.
3371 Also, in the meantime I found a few more instances where arguments
3372 were being counted with int, which may truncate counts on 64-bit
3373 machines, or EMACS_INT, which may be unnecessarily wide.
3374 * lisp.h (struct Lisp_Subr.function.aMANY)
3375 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3376 Arg counts are now ptrdiff_t, not size_t.
3377 All variadic functions and their callers changed accordingly.
3378 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3379 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3380 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3381 * callint.c (Fcall_interactively): Check arg count for overflow,
3382 to avoid potential buffer overrun. Use signed char, not 'int',
3383 for 'varies' array, so that we needn't bother to check its size
3384 calculation for overflow.
3385 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3386 * eval.c (apply_lambda):
3387 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3388 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3389 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3390
3391 * callint.c (Fcall_interactively): Don't use index var as event count.
3392
3393 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3394 * mem-limits.h (SIZE): Remove; no longer used.
3395
3396 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3397
3398 Remove unnecessary casts.
3399 * xterm.c (x_term_init):
3400 * xfns.c (x_set_border_pixel):
3401 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3402 These aren't needed now that we assume ANSI C.
3403
3404 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3405 It's more likely to cause problems (due to unsigned overflow)
3406 than to cure them.
3407
3408 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3409
3410 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3411
3412 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3413
3414 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3415
3416 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3417
3418 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3419
3420 GLYPH_CODE_FACE returns EMACS_INT, not int.
3421 * dispextern.h (merge_faces):
3422 * xfaces.c (merge_faces):
3423 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3424 Don't assume EMACS_INT fits in int.
3425
3426 * character.h (CHAR_VALID_P): Remove unused parameter.
3427 * fontset.c, lisp.h, xdisp.c: All uses changed.
3428
3429 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3430
3431 * fns.c (concat): Minor tuning based on overflow analysis.
3432 This doesn't fix any bugs. Use int to hold character, instead
3433 of constantly refetching from Emacs object. Use XFASTINT, not
3434 XINT, for value known to be a character. Don't bother comparing
3435 a single byte to 0400, as it's always less.
3436
3437 * floatfns.c (Fexpt):
3438 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3439
3440 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3441 for characters.
3442
3443 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3444
3445 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3446 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3447 incorrectly succeed when S was a string, because 4294967386 was
3448 truncated before it was used.
3449
3450 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3451 Otherwise, an out-of-range integer could cause undefined behavior
3452 on a 64-bit host.
3453
3454 * composite.c: Use int, not EMACS_INT, for characters.
3455 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3456 EMACS_INT, for values that are known to be in character range.
3457 This doesn't fix any bugs but is the usual style inside Emacs and
3458 may generate better code on 32-bit machines.
3459
3460 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3461 This is for reasons similar to the recent CHAR_STRING fix.
3462 * charset.c (Fencode_char): Check that character arg is actually
3463 a character. Pass an int to ENCODE_CHAR.
3464 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3465 wider than 'int', as a compile-time check to prevent future regressions
3466 in this area.
3467
3468 * character.c (char_string): Remove unnecessary casts.
3469
3470 Make sure a 64-bit char is never passed to CHAR_STRING.
3471 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3472 by silently ignoring the top 32 bits, allowing some values
3473 that were far too large to be valid characters.
3474 * character.h: Include <verify.h>.
3475 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3476 arguments are no wider than unsigned, as a compile-time check
3477 to prevent future regressions in this area.
3478 * data.c (Faset):
3479 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3480 (Fsubst_char_in_region):
3481 * fns.c (concat):
3482 * xdisp.c (decode_mode_spec_coding):
3483 Adjust to CHAR_STRING's new requirement.
3484 * editfns.c (Finsert_char, Fsubst_char_in_region):
3485 * fns.c (concat): Check that character args are actually
3486 characters. Without this test, these functions did the wrong
3487 thing with wildly out-of-range values on 64-bit hosts.
3488
3489 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3490 These casts should not be needed on 32-bit hosts, either.
3491 * keyboard.c (read_char):
3492 * lread.c (Fload): Remove casts to unsigned.
3493
3494 * lisp.h (UNSIGNED_CMP): New macro.
3495 This fixes comparison bugs on 64-bit hosts.
3496 (ASCII_CHAR_P): Use it.
3497 * casefiddle.c (casify_object):
3498 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3499 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3500 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3501 * dispextern.h (FACE_FROM_ID):
3502 * keyboard.c (read_char): Use UNSIGNED_CMP.
3503
3504 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3505 not to EMACS_INT, to avoid GCC warning.
3506
3507 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3508
3509 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3510 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3511 isn't needed on 32-bit machines.
3512
3513 * buffer.c (Fgenerate_new_buffer_name):
3514 Use EMACS_INT for count, not int.
3515 (advance_to_char_boundary): Return EMACS_INT, not int.
3516
3517 * data.c (Qcompiled_function): Now static.
3518
3519 * window.c (window_body_lines): Now static.
3520
3521 * image.c (gif_load): Rename local to avoid shadowing.
3522
3523 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3524 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3525 * alloc.c (make_save_value): Integer argument is now of type
3526 ptrdiff_t, not int.
3527 (mark_object): Use ptrdiff_t, not int.
3528 * lisp.h (pD): New macro.
3529 * print.c (print_object): Use it.
3530
3531 * alloc.c: Use EMACS_INT, not int, to count objects.
3532 (total_conses, total_markers, total_symbols, total_vector_size)
3533 (total_free_conses, total_free_markers, total_free_symbols)
3534 (total_free_floats, total_floats, total_free_intervals)
3535 (total_intervals, total_strings, total_free_strings):
3536 Now EMACS_INT, not int. All uses changed.
3537 (Fgarbage_collect): Compute overall total using a double, so that
3538 integer overflow is less likely to be a problem. Check for overflow
3539 when converting back to an integer.
3540 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3541 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3542 These were 'int' variables that could overflow on 64-bit hosts;
3543 they were never used, so remove them instead of repairing them.
3544 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3545 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3546 Previously, this ceilinged at INT_MAX, but that doesn't work on
3547 64-bit machines.
3548 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3549
3550 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3551 (allocate_vectorlike): Check for ptrdiff_t overflow.
3552 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3553 when a (possibly-narrower) signed value would do just as well.
3554 We prefer using signed arithmetic, to avoid comparison confusion.
3555
3556 * alloc.c: Catch some string size overflows that we were missing.
3557 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3558 for convenience in STRING_BYTES_MAX.
3559 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3560 The definition here is exact; the one in lisp.h was approximate.
3561 (allocate_string_data): Check for string overflow. This catches
3562 some instances we weren't catching before. Also, it catches
3563 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3564 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3565 and ptrdiff_t and EMACS_INT are both 64 bits.
3566
3567 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3568 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3569 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3570
3571 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3572
3573 * alloc.c (Fmake_string): Check for out-of-range init.
3574
3575 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3576
3577 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3578
3579 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3580
3581 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3582 xg_get_default_scrollbar_width.
3583
3584 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3585 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3586 (style_changed_cb): Call update_theme_scrollbar_width and call
3587 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3588 all frames (Bug#8505).
3589 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3590 Call gtk_window_set_resizable if HAVE_GTK3.
3591 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3592 and height if HAVE_GTK3 (Bug#8505).
3593 (scroll_bar_width_for_theme): New variable.
3594 (update_theme_scrollbar_width): New function.
3595 (xg_get_default_scrollbar_width): Move code to
3596 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3597 (xg_initialize): Call update_theme_scrollbar_width.
3598
3599 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3600
3601 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3602
3603 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3604
3605 * frame.c (make_frame): Call other_buffer_safely instead of
3606 other_buffer.
3607
3608 * window.c (temp_output_buffer_show): Call display_buffer with
3609 second argument Vtemp_buffer_show_specifiers and reset latter
3610 immediately after the call.
3611 (Vtemp_buffer_show_specifiers): New variable.
3612 (auto_window_vscroll_p, next_screen_context_lines)
3613 (Vscroll_preserve_screen_position): Remove leading asterisks from
3614 doc-strings.
3615
3616 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3617
3618 Fix minor problems found by GCC 4.6.0 static checking.
3619 * buffer.c (Qclone_number): Remove for now, as it's unused.
3620 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3621 (record_buffer): Remove unused local.
3622 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3623 (set_frame_buffer_list): Remove; unused.
3624 * frame.h (other_visible_frames): Remove decl.
3625 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3626 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3627 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3628 if HAVE_GPM.
3629 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3630 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3631 Define only if HAVE_GPM.
3632 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3633 (update_hints_inhibit): Remove; never set. All uses removed.
3634 * widgetprv.h (emacsFrameClassRec): Remove decl.
3635 * window.c (delete_deletable_window): Now returns void, since it
3636 wasn't returning anything.
3637 (compare_window_configurations): Remove unused locals.
3638 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3639 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3640 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3641 the same widths as pointers. This follows up on the 2011-05-06 patch.
3642 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3643 * xterm.h: Likewise.
3644 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3645
3646 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3647
3648 * makefile.w32-in: Update dependencies.
3649 (LISP_H): Add lib/intprops.h.
3650
3651 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3652
3653 * image.c (gif_load): Add animation frame delay to the metadata.
3654 (syms_of_image): Use DEFSYM. New symbol `delay'.
3655
3656 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3657
3658 * window.c (delete_deletable_window): Re-add.
3659 (Fset_window_configuration): Rewrite to handle dead buffers and
3660 consequently deletable windows.
3661 (window_tree, Fwindow_tree): Remove. Supply functionality in
3662 window.el.
3663 (compare_window_configurations): Simplify code.
3664
3665 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3666
3667 * image.c (imagemagick_load_image): Fix type mismatch.
3668 (Fimagemagick_types): Likewise.
3669
3670 * window.h (replace_buffer_in_windows): Declare.
3671
3672 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3673
3674 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3675 Qclone_number. Remove external declaration of Qdelete_window.
3676 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3677 code.
3678 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3679 Run Qbuffer_list_update_hook if allowed.
3680 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3681 buffer list implementation.
3682 (other_buffer_safely): New function.
3683 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3684 calls to replace_buffer_in_windows and
3685 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3686 if allowed.
3687 (record_buffer): Inhibit quitting and rewrite using quittable
3688 functions. Run Qbuffer_list_update_hook if allowed.
3689 (Frecord_buffer, Funrecord_buffer): New functions.
3690 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3691 Move switch-to-buffer to window.el.
3692 (bury-buffer): Move to window.el.
3693 (Vbuffer_list_update_hook): New variable.
3694
3695 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3696 section.
3697
3698 * window.h (resize_frame_windows): Move up in code.
3699 (Fwindow_frame): Remove EXFUN.
3700 (replace_buffer_in_all_windows): Remove prototype.
3701 (replace_buffer_in_windows_safely): Add prototype.
3702
3703 * window.c: Declare Qdelete_window static again. Move down
3704 declaration of select_count.
3705 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3706 (Fother_window): Move to window.el.
3707 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3708 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3709 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3710 window.el.
3711 (replace_buffer_in_windows): Implement by calling
3712 Qreplace_buffer_in_windows.
3713 (replace_buffer_in_all_windows): Remove with some functionality
3714 moved into replace_buffer_in_windows_safely.
3715 (replace_buffer_in_windows_safely): New function.
3716 (select_window_norecord, select_frame_norecord): Move in front
3717 of run_window_configuration_change_hook. Remove now obsolete
3718 declarations.
3719 (Fset_window_buffer): Rewrite doc-string.
3720 Call Qrecord_window_buffer.
3721 (keys_of_window): Move binding for other-window to window.el.
3722
3723 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3724
3725 * dispextern.h (struct image): Replace data member, whose int_val
3726 and ptr_val fields were not used by anything, with a single
3727 lisp_val object.
3728
3729 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3730 (gif_clear_image, gif_load, imagemagick_load_image)
3731 (gs_clear_image, gs_load): Callers changed.
3732
3733 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3734
3735 * buffer.h: Include <time.h>, for time_t.
3736 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3737
3738 Fix minor problems found by static checking.
3739
3740 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3741
3742 Make identifiers static if they are not used in other modules.
3743 * data.c (Qcompiled_function, Qframe, Qvector):
3744 * image.c (QimageMagick, Qsvg):
3745 * minibuf.c (Qmetadata):
3746 * window.c (resize_window_check, resize_root_window): Now static.
3747 * window.h (resize_window_check, resize_root_window): Remove decls.
3748
3749 * window.c (window_deletion_count, delete_deletable_window):
3750 Remove; unused.
3751 (window_body_lines): Now static.
3752 (Fdelete_other_windows_internal): Mark vars as initialized.
3753 Make sure 'resize_failed' is initialized.
3754 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3755 (resize_window_apply): Remove unused local.
3756 * window.h (delete_deletable_window): Remove decl.
3757
3758 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3759 (imagemagick_load_image): Fix pointer signedness problem by changing
3760 last arg from unsigned char * to char *. All uses changed.
3761 Also, fix a local for similar reasons.
3762 Remove unused locals. Remove locals to avoid shadowing.
3763 (fn_rsvg_handle_free): Remove; unused.
3764 (svg_load, svg_load_image): Fix pointer signedness problem.
3765 (imagemagick_load_image): Don't use garbage pointer image_wand.
3766
3767 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3768
3769 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3770
3771 * image.c (gif_load): Fix omitted cast error introduced by
3772 2011-06-06 change.
3773
3774 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3775
3776 * window.h (resize_proportionally, orig_total_lines)
3777 (orig_top_line): Remove from window structure.
3778 (set_window_height, set_window_width, change_window_heights)
3779 (Fdelete_window): Remove prototypes.
3780 (resize_frame_windows): Remove duplicate declaration.
3781
3782 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3783
3784 * window.h (resize_frame_windows, resize_window_check)
3785 (delete_deletable_window, resize_root_window)
3786 (resize_frame_windows): Declare prototypes.
3787
3788 * window.c (resize_window_apply): Make definition be "static" to
3789 match the prototype.
3790
3791 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3792
3793 * window.c: Remove declarations of Qwindow_size_fixed,
3794 window_min_size_1, window_min_size_2, window_min_size,
3795 size_window, window_fixed_size_p, enlarge_window, delete_window.
3796 Remove static from declaration of Qdelete_window, it's
3797 temporarily needed by Fbury_buffer.
3798 (replace_window): Don't assign orig_top_line and
3799 orig_total_lines.
3800 (Fdelete_window, delete_window): Remove. Window deletion is
3801 handled by window.el.
3802 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3803 Replace Fdelete_window calls with calls to Qdelete_window.
3804 (Fdelete_other_windows): Remove. Deleting other windows is
3805 handled by window.el.
3806 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3807 handled in window.el.
3808 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3809 Window minimum sizes are handled in window.el.
3810 (shrink_windows, size_window, set_window_height)
3811 (set_window_width, change_window_heights, window_height)
3812 (window_width, CURBEG, CURSIZE, enlarge_window)
3813 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3814 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3815 handled in window.el.
3816 (make_dummy_parent): Rename to make_parent_window and give it a
3817 second argument horflag.
3818 (make_window): Don't set resize_proportionally any more.
3819 (Fsplit_window): Remove. Windows are split in window.el.
3820 (save_restore_action, save_restore_orig_size)
3821 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3822 Resize mini windows in window.el.
3823 (grow_mini_window, shrink_mini_window): Implement by calling
3824 Qresize_root_window_vertically, resize_window_check and
3825 resize_window_apply.
3826 (saved_window, Fset_window_configuration, save_window_save):
3827 Do not handle orig_top_line, orig_total_lines, and
3828 resize_proportionally.
3829 (window_min_height, window_min_width): Move to window.el.
3830 (keys_of_window): Move bindings for delete-other-windows,
3831 split-window, delete-window and enlarge-window to window.el.
3832
3833 * buffer.c: Temporarily extern Qdelete_window.
3834 (Fbury_buffer): Temporarily call Qdelete_window instead of
3835 Fdelete_window (Fbury_buffer will move to window.el soon).
3836
3837 * frame.c (set_menu_bar_lines_1): Remove code handling
3838 orig_top_line and orig_total_lines.
3839
3840 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3841 set_window_height but set heights directly.
3842 (change_frame_size_1): Use resize_frame_windows.
3843
3844 * xdisp.c (init_xdisp): Don't use set_window_height but set
3845 heights directly.
3846
3847 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3848 Use resize_frame_windows instead of change_window_heights and run
3849 run_window_configuration_change_hook.
3850
3851 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3852 instead of change_window_heights and run
3853 run_window_configuration_change_hook.
3854
3855 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3856
3857 * window.c (replace_window): Rename second argument REPLACEMENT to
3858 NEW. New third argument SETFLAG. Rewrite.
3859 (delete_window, make_dummy_parent): Call replace_window with
3860 third argument 1.
3861 (window_list_1): Move down in code.
3862 (run_window_configuration_change_hook): Move set_buffer part
3863 before select_frame_norecord part in order to unwind correctly.
3864 Rename count1 to count.
3865 (recombine_windows, delete_deletable_window, resize_root_window)
3866 (Fdelete_other_windows_internal)
3867 (Frun_window_configuration_change_hook, make_parent_window)
3868 (resize_window_check, resize_window_apply, Fresize_window_apply)
3869 (resize_frame_windows, Fsplit_window_internal)
3870 (Fdelete_window_internal, Fresize_mini_window_internal):
3871 New functions.
3872 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3873
3874 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3875
3876 * window.h (window): Add some new members to window structure -
3877 normal_lines, normal_cols, new_total, new_normal, clone_number,
3878 splits, nest, prev_buffers, next_buffers.
3879 (WINDOW_TOTAL_SIZE): Move here from window.c.
3880 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3881
3882 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3883 Remove.
3884 (make_dummy_parent): Set new members of windows structure.
3885 (make_window): Move down in code. Handle new members of window
3886 structure.
3887 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3888 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3889 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3890 (Fset_window_prev_buffers, Fwindow_next_buffers)
3891 (Fset_window_next_buffers, Fset_window_clone_number):
3892 New functions.
3893 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3894 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3895 Doc-string fixes.
3896 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3897 Argument WINDOW can be now internal window too.
3898 (Fwindow_use_time): Move up in code.
3899 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3900 Rewrite doc-string.
3901 (Fset_window_configuration, saved_window)
3902 (Fcurrent_window_configuration, save_window_save): Handle new
3903 members of window structure.
3904 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3905 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3906 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3907 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3908 Qget_mru_window, Qresize_root_window,
3909 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3910 Qauto_buffer_name; staticpro them.
3911
3912 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3913
3914 * window.c (Fwindow_total_size, Fwindow_left_column)
3915 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3916 (Fwindow_list_1): New functions.
3917 (window_box_text_cols): Replace with window_body_cols.
3918 (Fwindow_width, Fscroll_left, Fscroll_right):
3919 Use window_body_cols instead of window_box_text_cols.
3920 (delete_window, Fset_window_configuration):
3921 Call delete_all_subwindows with window as argument.
3922 (delete_all_subwindows): Take a window as argument and not a
3923 structure. Rewrite.
3924 (window_loop): Remove handling of GET_LRU_WINDOW and
3925 GET_LARGEST_WINDOW.
3926 (Fget_lru_window, Fget_largest_window): Move to window.el.
3927
3928 * window.h: Extern window_body_cols instead of
3929 window_box_text_cols. delete_all_subwindows now takes a
3930 Lisp_Object as argument.
3931
3932 * indent.c (compute_motion, Fcompute_motion):
3933 Use window_body_cols instead of window_box_text_cols.
3934
3935 * frame.c (delete_frame): Call delete_all_subwindows with root
3936 window as argument.
3937
3938 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3939
3940 * fns.c (Fputhash): Document return value.
3941
3942 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3943
3944 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3945
3946 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 Cons<->int and similar integer overflow fixes (Bug#8794).
3949
3950 Check for overflow when converting integer to cons and back.
3951 * charset.c (Fdefine_charset_internal, Fdecode_char):
3952 Use cons_to_unsigned to catch overflow.
3953 (Fencode_char): Use INTEGER_TO_CONS.
3954 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3955 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3956 * data.c (long_to_cons, cons_to_long): Remove.
3957 (cons_to_unsigned, cons_to_signed): New functions.
3958 These signal an error for invalid or out-of-range values.
3959 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3960 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3961 * font.c (Ffont_variation_glyphs):
3962 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3963 * lisp.h: Include <intprops.h>.
3964 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3965 (cons_to_signed, cons_to_unsigned): New decls.
3966 (long_to_cons, cons_to_long): Remove decls.
3967 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3968 (Fprimitive_undo): Use CONS_TO_INTEGER.
3969 * xfns.c (Fx_window_property): Likewise.
3970 * xselect.c: Include <limits.h>.
3971 (x_own_selection, selection_data_to_lisp_data):
3972 Use INTEGER_TO_CONS.
3973 (x_handle_selection_request, x_handle_selection_clear)
3974 (x_get_foreign_selection, Fx_disown_selection_internal)
3975 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3976 (lisp_data_to_selection_data): Use cons_to_unsigned.
3977 (x_fill_property_data): Use cons_to_signed.
3978 Report values out of range.
3979
3980 Check for buffer and string overflow more precisely.
3981 * buffer.h (BUF_BYTES_MAX): New macro.
3982 * lisp.h (STRING_BYTES_MAX): New macro.
3983 * alloc.c (Fmake_string):
3984 * character.c (string_escape_byte8):
3985 * coding.c (coding_alloc_by_realloc):
3986 * doprnt.c (doprnt):
3987 * editfns.c (Fformat):
3988 * eval.c (verror):
3989 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3990 since they may not be the same number.
3991 * editfns.c (Finsert_char):
3992 * fileio.c (Finsert_file_contents):
3993 Likewise for BUF_BYTES_MAX.
3994
3995 * image.c: Use ptrdiff_t, not int, for sizes.
3996 (slurp_file): Switch from int to ptrdiff_t.
3997 All uses changed.
3998 (slurp_file): Check that file size fits in both size_t (for
3999 malloc) and ptrdiff_t (for sanity and safety).
4000
4001 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4002 if b->modtime has its maximal value.
4003
4004 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4005
4006 Don't assume time_t can fit into int.
4007 * buffer.h (struct buffer.modtime): Now time_t, not int.
4008 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4009 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4010
4011 Minor fixes for signed vs unsigned integers.
4012 * character.h (MAYBE_UNIFY_CHAR):
4013 * charset.c (maybe_unify_char):
4014 * keyboard.c (read_char, reorder_modifiers):
4015 XINT -> XFASTINT, since the integer must be nonnegative.
4016 * ftfont.c (ftfont_spec_pattern):
4017 * keymap.c (access_keymap, silly_event_symbol_error):
4018 XUINT -> XFASTINT, since the integer must be nonnegative.
4019 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4020 since it makes no difference and we prefer signed.
4021 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4022 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4023 nonnegative.
4024
4025 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4026
4027 * window.h (Fwindow_frame): Declare.
4028
4029 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4030
4031 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4032 (SPARE_MEMORY): Always define.
4033 (LARGE_REQUEST): Remove.
4034 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4035
4036 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4037
4038 * lisp.h: Move EXFUNS for Fframe_root_window,
4039 Fframe_first_window and Fset_frame_selected_window to window.h.
4040
4041 * window.h: Move EXFUNS for Fframe_root_window,
4042 Fframe_first_window and Fset_frame_selected_window here from
4043 lisp.h.
4044
4045 * frame.c (Fwindow_frame, Fframe_first_window)
4046 (Fframe_root_window, Fframe_selected_window)
4047 (Fset_frame_selected_window): Move to window.c.
4048 (Factive_minibuffer_window): Move to minibuf.c.
4049 (Fother_visible_frames_p): New function.
4050
4051 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4052
4053 * window.c (decode_window, decode_any_window): Move up in code.
4054 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4055 (inhibit_frame_unsplittable): Remove unused variable.
4056 (Fwindow_buffer): Move up and rewrite doc-string.
4057 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4058 (Fwindow_prev): New functions.
4059 (Fwindow_frame): Move here from frame.c. Accept any window as
4060 argument.
4061 (Fframe_root_window, Fframe_first_window)
4062 (Fframe_selected_window): Move here from frame.c. Accept frame
4063 or arbitrary window as argument. Update doc-strings.
4064 (Fminibuffer_window): Move up in code.
4065 (Fwindow_minibuffer_p): Move up in code and simplify.
4066 (Fset_frame_selected_window): Move here from frame.c.
4067 Marginal rewrite.
4068 (Fselected_window, select_window, Fselect_window): Move up in
4069 code. Minor doc-string fixes.
4070
4071 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4072
4073 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4074 Do not assume that spare memory exists; that assumption is valid
4075 only if SYSTEM_MALLOC.
4076 (LARGE_REQUEST): New macro, so that the issue of large requests
4077 is separated from the issue of spare memory.
4078
4079 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4080
4081 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4082 format. (Bug#8806)
4083
4084 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4085
4086 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4087 before statements.
4088
4089 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4090
4091 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4092
4093 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4094
4095 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4096 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4097
4098 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4099
4100 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4101
4102 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4103
4104 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4105 (x_clipboard_manager_save): Add return value.
4106 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4107 New error handlers.
4108 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4109 Obey Vx_select_enable_clipboard_manager. Catch errors in
4110 x_clipboard_manager_save (Bug#8779).
4111 (Vx_select_enable_clipboard_manager): New variable.
4112 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4113
4114 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4115
4116 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4117
4118 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4119
4120 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4121 in the current matrix if keep_current_p is non-zero.
4122
4123 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4124
4125 * bidi.c (bidi_level_of_next_char): Fix last change.
4126
4127 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4128
4129 Support bidi reordering of text covered by display properties.
4130
4131 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4132 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4133 (bidi_cache_search, bidi_cache_iterator_state)
4134 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4135 (bidi_level_of_next_char, bidi_move_to_visually_next):
4136 Support character positions inside a run of characters covered by a
4137 display string.
4138 (bidi_paragraph_init, bidi_resolve_explicit_1)
4139 (bidi_level_of_next_char): Call bidi_fetch_char and
4140 bidi_fetch_char_advance instead of FETCH_CHAR and
4141 FETCH_CHAR_ADVANCE.
4142 (bidi_init_it): Initialize new members.
4143 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4144 definitions.
4145 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4146 instead of using explicit *_CHAR codes.
4147 (bidi_resolve_explicit, bidi_resolve_weak):
4148 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4149 bidirectional text is supported only in multibyte buffers.
4150 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4151 it to initialize the frame_window_p member of struct bidi_it.
4152 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4153 (bidi_resolve_explicit, bidi_resolve_weak)
4154 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4155 bidi_it->nchars is non-positive.
4156 (bidi_level_of_next_char): Don't try to lookup the cache for the
4157 next/previous character if nothing is cached there yet, or if we
4158 were just reseat()'ed to a new position.
4159
4160 * xdisp.c (set_cursor_from_row): Set start and stop points
4161 according to the row's direction when priming the loop that looks
4162 for the glyph on which to display cursor.
4163 (single_display_spec_intangible_p): Function deleted.
4164 (display_prop_intangible_p): Reimplement to call
4165 handle_display_spec instead of single_display_spec_intangible_p.
4166 Accept 3 additional arguments needed by handle_display_spec.
4167 This fixes incorrect cursor motion across display property with complex
4168 values: lists, `(when COND...)' forms, etc.
4169 (single_display_spec_string_p): Support property values that are
4170 lists with the argument STRING its top-level element.
4171 (display_prop_string_p): Fix the condition for processing a
4172 property that is a list to be consistent with handle_display_spec.
4173 (handle_display_spec): New function, refactored from the
4174 last portion of handle_display_prop.
4175 (compute_display_string_pos): Accept additional argument
4176 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4177 value of a `display' property is a "replacing spec".
4178 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4179 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4180 the display property, but just return a value indicating whether
4181 the display property will replace the characters it covers.
4182 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4183 frame_window_p members of struct bidi_it.
4184 (compute_display_string_pos, compute_display_string_end):
4185 New functions.
4186 (push_it): Accept second argument POSITION, where pop_it should
4187 jump to continue iteration.
4188 (reseat_1): Initialize bidi_it.disp_pos.
4189
4190 * keyboard.c (adjust_point_for_property): Adjust the call to
4191 display_prop_intangible_p to its new signature.
4192
4193 * dispextern.h (struct bidi_it): New member frame_window_p.
4194 (bidi_init_it): Update prototypes.
4195 (display_prop_intangible_p): Update prototype.
4196 (compute_display_string_pos, compute_display_string_end):
4197 Declare prototypes.
4198 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4199 EMACS_INT.
4200
4201 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4202
4203 Malloc failure behavior now depends on size of allocation.
4204 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4205 * lisp.h: Change signatures accordingly.
4206 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4207 All callers changed. (Bug#8762)
4208
4209 * gnutls.c: Use Emacs's memory allocators.
4210 Without this change, the gnutls library would invoke malloc etc.
4211 directly, which causes problems on non-SYNC_INPUT hosts, and which
4212 runs afoul of improving memory_full behavior. (Bug#8761)
4213 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4214 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4215 xfree instead of the default malloc, realloc, free.
4216 (Fgnutls_boot): No need to check for memory allocation failure,
4217 since xmalloc does that for us.
4218
4219 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4220 * category.c (hash_get_category_set):
4221 * ccl.c (ccl_driver):
4222 * charset.c (Fdefine_charset_internal):
4223 * charset.h (struct charset.hash_index):
4224 * composite.c (get_composition_id, gstring_lookup_cache)
4225 (composition_gstring_put_cache):
4226 * composite.h (struct composition.hash_index):
4227 * dispextern.h (struct image.hash):
4228 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4229 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4230 (hashfn_equal, hashfn_user_defined, make_hash_table)
4231 (maybe_resize_hash_table, hash_lookup, hash_put)
4232 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4233 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4234 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4235 * image.c (make_image, search_image_cache, lookup_image)
4236 (xpm_put_color_table_h):
4237 * lisp.h (struct Lisp_Hash_Table):
4238 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4239 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4240 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4241 * alloc.c (allocate_vectorlike):
4242 Check for overflow in vector size calculations.
4243 * ccl.c (ccl_driver):
4244 Check for overflow when converting EMACS_INT to int.
4245 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4246 need to be updated by these changes.
4247 * fns.c (make_hash_table, maybe_resize_hash_table):
4248 Check for integer overflow with large hash tables.
4249 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4250 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4251 (SXHASH_REDUCE): New macro.
4252 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4253 Use it instead of discarding useful hash info with large hash values.
4254 (sxhash_float): New function.
4255 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4256 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4257 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4258 Rewrite to use FIXNUM_BITS, as this simplifies things.
4259 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4260 Adjust signatures to match updated version of code.
4261 (consing_since_gc): Now EMACS_INT, since a single hash table can
4262 use more than INT_MAX bytes.
4263
4264 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4265
4266 Make it possible to build with GCC-4.6+ -O2 -flto.
4267
4268 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4269
4270 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4271
4272 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4273 Call minibuffer-inactive-mode.
4274
4275 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4276
4277 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4278 Update dependencies.
4279
4280 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4281
4282 * data.c (init_data): Remove code for UTS, this system is not
4283 supported anymore.
4284
4285 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4286
4287 Don't force ./temacs to start in terminal mode.
4288
4289 * frame.c (make_initial_frame): Initialize faces in all cases, not
4290 only when CANNOT_DUMP is defined.
4291 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4292
4293 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4294
4295 * dispnew.c (add_window_display_history): Use const for the string
4296 pointer. Remove declaration, not needed.
4297
4298 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4299
4300 Use 'inline', not 'INLINE'.
4301 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4302 * alloc.c, fontset.c (INLINE): Remove.
4303 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4304 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4305 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4306 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4307 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4308
4309 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4310
4311 Make it possible to run ./temacs.
4312
4313 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4314 syms_of_callproc does the same thing. Remove test for
4315 "initialized", do it in the caller.
4316 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4317
4318 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4319
4320 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4321 (read_minibuf): Use get_minibuffer.
4322 (syms_of_minibuf): Use DEFSYM.
4323 (Qmetadata): New var.
4324 * data.c (Qbuffer): Don't make it static.
4325 (syms_of_data): Use DEFSYM.
4326
4327 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4328
4329 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4330 (CCL_CODE_MIN): New macro.
4331
4332 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4335
4336 * eval.c (Qdebug): Now static.
4337 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4338 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4339 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4340
4341 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4342
4343 * image.c: Various fixes to ImageMagick code comments.
4344 (Fimagemagick_types): Doc fix.
4345
4346 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4347
4348 Minor fixes prompted by GCC 4.6.0 warnings.
4349
4350 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4351
4352 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4353 (x_clipboard_manager_save_all): Move extern decl to ...
4354 * xterm.h: ... here, so that it can be checked for consistency.
4355
4356 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4357
4358 * xselect.c (x_clipboard_manager_save_frame)
4359 (x_clipboard_manager_save_all): New functions.
4360 (Fx_clipboard_manager_save): Lisp function deleted.
4361
4362 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4363 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4364
4365 * xterm.h: Update prototype.
4366
4367 2011-05-28 William Xu <william.xwl@gmail.com>
4368
4369 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4370 exiting (Bug#8239).
4371
4372 2011-05-28 Jim Meyering <meyering@redhat.com>
4373
4374 Avoid a sign-extension bug in crypto_hash_function.
4375 * fns.c (to_uchar): Define.
4376 (crypto_hash_function): Use it to convert some newly-signed
4377 variables to unsigned, to avoid sign-extension bugs. For example,
4378 without this change, (md5 "truc") would evaluate to
4379 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4380 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4381 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4382
4383 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4384
4385 Integer overflow fixes.
4386
4387 * dbusbind.c: Serial number integer overflow fixes.
4388 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4389 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4390 to hold a serial number that is too large for a fixnum.
4391 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4392 Check for serial numbers out of range. Decode any serial number
4393 that was so large that it became a float. (Bug#8722)
4394
4395 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4396 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4397 Use XFASTINT rather than XUINT when numbers are nonnegative.
4398 (xd_append_arg, Fdbus_method_return_internal):
4399 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4400 arguments, check that Lisp number is nonnegative, rather than
4401 silently wrapping negative numbers around. (Bug#8722)
4402 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4403 (Bug#8722)
4404
4405 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4406
4407 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4408
4409 ccl: add integer overflow checks
4410 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4411 (IN_INT_RANGE): New macros.
4412 (ccl_driver): Use them to check for integer overflow when
4413 decoding a CCL program. Many of the new checks are whether XINT (x)
4414 fits in int; it doesn't always, on 64-bit hosts. The new version
4415 doesn't catch all possible integer overflows, but it's an
4416 improvement. (Bug#8719)
4417
4418 * alloc.c (make_event_array): Use XINT, not XUINT.
4419 There's no need for unsigned here.
4420
4421 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4422 This follows up to the 2011-05-06 change that substituted uintptr_t
4423 for EMACS_INT. This case wasn't caught back then.
4424
4425 Rework Fformat to avoid integer overflow issues.
4426 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4427 now (part of C89). Include <verify.h>.
4428 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4429 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4430 (Fformat): Avoid the prepass trying to compute sizes; it was only
4431 approximate and thus did not catch overflow reliably. Instead, walk
4432 through the format just once, formatting and computing sizes as we go,
4433 checking for integer overflow at every step, and allocating a larger
4434 buffer as needed. Keep track separately whether the format is
4435 multibyte. Keep only the most-recently calculated precision, rather
4436 than them all. Record whether each argument has been converted to
4437 string. Use EMACS_INT, not int, for byte and char and arg counts.
4438 Support field widths and precisions larger than INT_MAX. Avoid
4439 sprintf's undefined behavior with conversion specifications such as %#d
4440 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4441 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4442 formatting out-of-range floating point numbers with int
4443 formats. (Bug#8668)
4444
4445 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4446
4447 * data.c: Avoid integer truncation in expressions involving floats.
4448 * data.c: Include <intprops.h>.
4449 (arith_driver): When there's an integer overflow in an expression
4450 involving floating point, convert the integers to floating point
4451 so that the resulting value does not suffer from catastrophic
4452 integer truncation. For example, on a 64-bit host (* 4
4453 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4454 Do not rely on undefined behavior after integer overflow.
4455
4456 merge count_size_as_multibyte, parse_str_to_multibyte
4457 * character.c, character.h (count_size_as_multibyte):
4458 Rename from parse_str_to_multibyte; all uses changed.
4459 Check for integer overflow.
4460 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4461 since it's now a duplicate of the other. This is more of
4462 a character than a buffer op, so better that it's in character.c.
4463 * fns.c, print.c: Adjust to above changes.
4464
4465 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4466
4467 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4468
4469 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4470
4471 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4472 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4473 (x_clipboard_manager_save): Now static.
4474 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4475
4476 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4477 (crypto_hash_function): Now static.
4478 Fix pointer signedness problems. Avoid unnecessary initializations.
4479
4480 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4481
4482 * termhooks.h (Vselection_alist): Make it terminal-local.
4483
4484 * terminal.c (create_terminal): Initialize it.
4485
4486 * xselect.c: Support for clipboard managers.
4487 (Vselection_alist): Move to termhooks.h as terminal-local var.
4488 (LOCAL_SELECTION): New macro.
4489 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4490 (symbol_to_x_atom): Remove gratuitous arg.
4491 (x_handle_selection_request, lisp_data_to_selection_data)
4492 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4493 (x_own_selection, x_get_local_selection, x_convert_selection):
4494 New arg, specifying work frame. Use terminal-local Vselection_alist.
4495 (some_frame_on_display): Delete unused function.
4496 (Fx_own_selection_internal, Fx_get_selection_internal)
4497 (Fx_disown_selection_internal, Fx_selection_owner_p)
4498 (Fx_selection_exists_p): New optional frame arg.
4499 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4500 (x_handle_selection_clear): Don't treat other terminals with the
4501 same keyboard specially. Use the terminal-local Vselection_alist.
4502 (x_clear_frame_selections): Use Frun_hook_with_args.
4503
4504 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4505
4506 * xterm.h: Add support for those atoms.
4507
4508 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4509
4510 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4511 (converted_selections, conversion_fail_tag): New global variables.
4512 (x_selection_request_lisp_error): Free the above.
4513 (x_get_local_selection): Remove unnecessary code.
4514 (x_reply_selection_request): Args changed; handle arbitrary array
4515 of converted selections stored in converted_selections.
4516 Separate the XChangeProperty and SelectionNotify steps.
4517 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4518 (x_convert_selection): New function.
4519 (x_handle_selection_event): Simplify.
4520 (x_get_foreign_selection): Don't ignore incoming requests while
4521 waiting for an answer; this will fail when we implement
4522 SAVE_TARGETS, and seems unnecessary anyway.
4523 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4524 (Vx_sent_selection_functions): Doc fix.
4525
4526 2011-05-26 Leo Liu <sdl.web@gmail.com>
4527
4528 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4529
4530 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4531
4532 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4533
4534 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4535 for fringe update if it has periodic bitmap.
4536 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4537 and fringe_bitmap_periodic_p.
4538
4539 * fringe.c (get_fringe_bitmap_data): New function.
4540 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4541 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4542 row. Mark glyph row for fringe update if periodicity changed.
4543
4544 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4545 for fringe update unless it has periodic bitmap.
4546
4547 2011-05-25 Kenichi Handa <handa@m17n.org>
4548
4549 * xdisp.c (get_next_display_element): Set correct it->face_id for
4550 a static composition.
4551
4552 2011-05-24 Leo Liu <sdl.web@gmail.com>
4553
4554 * deps.mk (fns.o):
4555 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4556
4557 * fns.c (crypto_hash_function, Fsha1): New function.
4558 (Fmd5): Use crypto_hash_function.
4559 (syms_of_fns): Add Ssha1.
4560
4561 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4562
4563 * gnutls.c: Remove unused macros.
4564 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4565 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4566 Remove macros that are defined and never used.
4567 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4568
4569 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4570
4571 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4572 (Fx_get_selection_internal): Minor cleanup.
4573 (Fx_own_selection_internal): Rename arguments for consistency with
4574 select.el.
4575
4576 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4577
4578 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4579
4580 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4581
4582 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4583
4584 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4585
4586 * dispnew.c (scrolling_window): Don't exclude the case that the
4587 last enabled row in the desired matrix touches the bottom boundary.
4588
4589 2011-05-21 Glenn Morris <rgm@gnu.org>
4590
4591 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4592 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4593 and add some more files.
4594
4595 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4596
4597 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4598 report_file_error introduced by the change from 2011-05-07.
4599
4600 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4601
4602 * systime.h (Time): Define only if emacs is defined.
4603 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4604 where the include path doesn't have X11/X.h by default. See
4605 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4606
4607 2011-05-20 Kenichi Handa <handa@m17n.org>
4608
4609 * composite.c (find_automatic_composition): Fix previous change.
4610
4611 2011-05-20 Glenn Morris <rgm@gnu.org>
4612
4613 * lisp.mk: New file, split from Makefile.in.
4614 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4615 (shortlisp): Remove.
4616 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4617
4618 2011-05-19 Glenn Morris <rgm@gnu.org>
4619
4620 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4621 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4622 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4623 (lisp): Set the order to that of loadup.el.
4624 (shortlisp): Make it a copy of $lisp.
4625 (SOME_MACHINE_LISP): Remove.
4626 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4627 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4628
4629 2011-05-18 Kenichi Handa <handa@m17n.org>
4630
4631 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4632 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4633 (find_automatic_composition): Mostly rewrite for efficiency.
4634
4635 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4636
4637 * makefile.w32-in: Update dependencies.
4638
4639 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4640
4641 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4642 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4643
4644 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4645
4646 Fix some integer overflow issues, such as string length overflow.
4647
4648 * insdel.c (count_size_as_multibyte): Check for string overflow.
4649
4650 * character.c (lisp_string_width): Check for string overflow.
4651 Use EMACS_INT, not int, for string indexes and lengths; in
4652 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4653 the resulting string length overflows an EMACS_INT; instead,
4654 report a string overflow if no precision given. When checking for
4655 precision exhaustion, use a check that cannot possibly have
4656 integer overflow. (Bug#8675)
4657 * character.h (lisp_string_width): Adjust to new signature.
4658
4659 * alloc.c (string_overflow): New function.
4660 (Fmake_string): Use it. This doesn't change behavior, but saves
4661 a few bytes and will simplify future changes.
4662 * character.c (string_escape_byte8): Likewise.
4663 * lisp.h (string_overflow): New decl.
4664
4665 Fixups, following up to the user-interface timestamp change.
4666 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4667 for UI timestamps, instead of unsigned long.
4668 * msdos.c (mouse_get_pos): Likewise.
4669 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4670 * w32gui.h (Time): Define by including "systime.h" rather than by
4671 declaring it ourselves. (Bug#8664)
4672
4673 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4674 * image.c (clear_image_cache): Likewise.
4675
4676 * term.c (term_mouse_position): Don't assume time_t wraparound.
4677
4678 Be more systematic about user-interface timestamps.
4679 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4680 and sometimes 'EMACS_UINT', to represent these timestamps.
4681 This change causes it to use 'Time' uniformly, as that's what X uses.
4682 This makes the code easier to follow, and makes it easier to catch
4683 integer overflow bugs such as Bug#8664.
4684 * frame.c (Fmouse_position, Fmouse_pixel_position):
4685 Use Time, not unsigned long, for user-interface timestamps.
4686 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4687 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4688 * keyboard.h (last_event_timestamp): Likewise.
4689 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4690 * menu.h (xmenu_show): Likewise.
4691 * term.c (term_mouse_position): Likewise.
4692 * termhooks.h (struct input_event.timestamp): Likewise.
4693 (struct terminal.mouse_position_hook): Likewise.
4694 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4695 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4696 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4697 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4698 what it was before.
4699 * menu.h, termhooks.h: Include "systime.h", for Time.
4700
4701 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4702 Don't assume that the difference between two unsigned long values
4703 can fit into an integer. At this point, we know button_down_time
4704 <= event->timestamp, so the difference must be nonnegative, so
4705 there's no need to cast the result if double-click-time is
4706 nonnegative, as it should be; check that it's nonnegative, just in
4707 case. This bug is triggered when events are more than 2**31 ms
4708 apart (about 25 days). (Bug#8664)
4709
4710 * xselect.c (last_event_timestamp): Remove duplicate decl.
4711 (x_own_selection): Remove needless cast to unsigned long.
4712
4713 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4714 that always fit in int. Use a sentinel instead of a counter, to
4715 avoid a temp and to allay GCC's concerns about possible int overflow.
4716 * frame.h (struct frame): Use int for menu_bar_items_used
4717 instead of EMACS_INT, since it always fits in int.
4718
4719 * menu.c (grow_menu_items): Check for int overflow.
4720
4721 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4722
4723 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4724 Before, the code was not consistent. These values cannot exceed
4725 2**31 - 1 so there's no need to make them unsigned.
4726 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4727 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4728 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4729 as modifiers.
4730 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4731
4732 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4733 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4734 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4735 presumably because the widths might not match.
4736
4737 * window.c (size_window): Avoid needless test at loop start.
4738
4739 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4740
4741 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4742
4743 2011-05-12 Drew Adams <drew.adams@oracle.com>
4744
4745 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4746
4747 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4748
4749 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4750 `width' to `bar_area_x' and `bar_area_width', respectively.
4751 (x_scroll_run): Take account of fringe background extension.
4752
4753 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4754 Rename local vars `left' and `width' to `bar_area_x' and
4755 `bar_area_width', respectively.
4756 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4757 background extension.
4758
4759 2011-05-10 Jim Meyering <meyering@redhat.com>
4760
4761 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4762
4763 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4764
4765 * image.c (Finit_image_library): Return t for built-in image types,
4766 like pbm and xbm. (Bug#8640)
4767
4768 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4769
4770 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4771
4772 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4773
4774 * w32console.c (Fset_screen_color): Doc fix.
4775 (Fget_screen_color): New function.
4776 (syms_of_ntterm): Defsubr it.
4777
4778 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4779 unlink the temporary file if Fcall_process didn't create it in the
4780 first place.
4781 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4782 child process will be redirected to a file specified with `:file'.
4783 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4784 cue to call_process_cleanup not to close that handle.
4785
4786 2011-05-07 Ben Key <bkey76@gmail.com>
4787
4788 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4789 one of two shell specific rules, either bootstrap-temacs-CMD or
4790 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4791 to the previous implementation of the bootstrap-temacs rule.
4792 The bootstrap-temacs-CMD rule is similar to the previous
4793 implementation of the bootstrap-temacs rule except that it
4794 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4795 variable.
4796
4797 These changes, along with some changes to nt/configure.bat,
4798 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4799 earlier fix to add support for --cflags and --ldflags options
4800 that include quotes so that it works whether make uses cmd or
4801 sh as the shell.
4802
4803 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4804
4805 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4806 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4807 is a constant.
4808 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4809 a string. Handle both cases.
4810 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4811 (Fdbus_register_method): Use Qinvalid_function.
4812
4813 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4814
4815 * makefile.w32-in: Update dependencies.
4816 (LISP_H): Add inttypes.h and stdin.h.
4817 (PROCESS_H): Add unistd.h.
4818
4819 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4820
4821 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4822 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4823
4824 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4825
4826 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4827
4828 * term.c (vfatal): Remove stray call to va_end.
4829 It's not needed and the C Standard doesn't allow it here anyway.
4830
4831 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4832 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4833
4834 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4835 bytes.
4836
4837 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4838
4839 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4840
4841 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4842
4843 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4844
4845 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4846
4847 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4848 * charset.c (Fdefine_charset_internal): Don't initialize
4849 charset.code_space[15]. The value was garbage, on hosts with
4850 32-bit int (Bug#8600).
4851
4852 * lread.c (read_integer): Be more consistent with string-to-number.
4853 Use string_to_number to do the actual conversion; this avoids
4854 rounding errors and fixes some other screwups. Without this fix,
4855 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4856 (digit_to_number): Move earlier, for benefit of read_integer.
4857 Return -1 if the digit is out of range for the base, -2 if it is
4858 not a digit in any supported base. (Bug#8602)
4859
4860 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4861
4862 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4863 to match comment at start of function. This also removes a
4864 GCC warning about overflow in a 32+64-bit port.
4865
4866 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4867
4868 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4869 Reported by Stefan Monnier in
4870 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4871 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4872 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4873
4874 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4875 (EMACS_UINTPTR): Likewise, with uintptr_t.
4876
4877 * lisp.h: Prefer 64-bit EMACS_INT if available.
4878 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4879 on 32-bit hosts that have 64-bit int, so that they can access
4880 large files.
4881 However, temporarily disable this change unless the temporary
4882 symbol WIDE_EMACS_INT is defined.
4883
4884 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4885
4886 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4887 This removes an assumption that EMACS_INT and long are the same
4888 width as pointers. The assumption is true for Emacs porting targets
4889 now, but we want to make other targets possible.
4890 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4891 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4892 In the rest of the code, change types of integers that hold casted
4893 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4894 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4895 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4896 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4897 No need to cast type when ORing.
4898 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4899 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4900 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4901 assume EMACS_INT is the same width as char *.
4902 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4903 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4904 Remove no-longer-needed casts.
4905 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4906 (xg_tool_bar_help_callback, xg_make_tool_item):
4907 Use EMACS_INTPTR to hold an integer
4908 that will be cast to void *; this can avoid a GCC warning
4909 if EMACS_INT is not the same width as void *.
4910 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4911 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4912 (current_message_1, set_message_1):
4913 Use a local to convert to proper width without a cast.
4914 * xmenu.c (dialog_selection_callback): Likewise.
4915
4916 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4917 Also, don't assume VALBITS / RAND_BITS is less than 5,
4918 and don't rely on undefined behavior when shifting a 1 left into
4919 the sign bit.
4920 * lisp.h (get_random): Change signature to match.
4921
4922 * lread.c (hash_string): Use size_t, not int, for hash computation.
4923 Normally we prefer signed values; but hashing is special, because
4924 it's better to use unsigned division on hash table sizes so that
4925 the remainder is nonnegative. Also, size_t is the natural width
4926 for hashing into memory. The previous code used 'int', which doesn't
4927 retain enough info to hash well into very large tables.
4928 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4929
4930 * dbusbind.c: Don't possibly lose pointer info when converting.
4931 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4932 Use XPNTR rather than XHASH, so that the high-order bits of
4933 the pointer aren't lost when converting through void *.
4934
4935 * eval.c (Fautoload): Don't double-shift a pointer.
4936
4937 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4938
4939 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4940
4941 * gnutls.c (DEF_GNUTLS_FN):
4942 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4943
4944 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4945
4946 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4947 marker. (Bug#8610)
4948
4949 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4950
4951 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4952 New version that can reserve upto 2GB of heap space.
4953
4954 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4955
4956 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4957
4958 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4959
4960 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4961 `gnutls_certificate_set_x509_key_file'.
4962
4963 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4964
4965 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4966 Update dependencies.
4967
4968 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4969
4970 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4971 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4972 Remove unused parameter `fildes'.
4973 * process.c (read_process_output, send_process): Don't pass it.
4974
4975 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4976
4977 Fix previous change: the library cache is defined in w32.c.
4978 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4979 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4980
4981 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4982
4983 Implement dynamic loading of GnuTLS on Windows.
4984
4985 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4986 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4987 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4988 Declare.
4989
4990 * gnutls.c (Qgnutls_dll): Define.
4991 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4992 (gnutls_*): Declare function pointers.
4993 (init_gnutls_functions): New function to initialize function pointers.
4994 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4995 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4996 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4997 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4998 (emacs_gnutls_write, emacs_gnutls_read)
4999 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5000 (Fgnutls_available_p): New function.
5001 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5002 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5003 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5004
5005 * image.c: Include w32.h.
5006 (Vimage_type_cache): Delete.
5007 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5008 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5009 (w32_delayed_load): Move to w32.c.
5010
5011 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5012
5013 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5014 (w32_delayed_load): Move from image.c. When loading a library, record
5015 its filename in the :loaded-from property of the library id.
5016 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5017 Initialize and staticpro them.
5018 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5019
5020 * process.c: Include lisp.h before w32.h, not after.
5021 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5022 instead of gnutls_record_check_pending.
5023
5024 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5025
5026 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5027
5028 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5029 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5030 as passed in.
5031
5032 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5033
5034 * xterm.c (x_set_frame_alpha): Do not set property on anything
5035 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5036
5037 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5038
5039 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5040
5041 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5042
5043 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5044 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5045 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5046 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5047 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5048 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5049 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5050 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5051 (Qgnutls_bootprop_callbacks_verify): Make static.
5052
5053 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5054
5055 * callproc.c: Indentation fixup.
5056
5057 * sysdep.c (wait_for_termination_1): Make static.
5058 (wait_for_termination, interruptible_wait_for_termination):
5059 Move after wait_for_termination_1.
5060
5061 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5062
5063 * sysdep.c (interruptible_wait_for_termination): New function
5064 which is like wait_for_termination, but allows keyboard
5065 interruptions.
5066
5067 * callproc.c (Fcall_process): Add (:file "file") as an option for
5068 the STDOUT buffer.
5069 (Fcall_process_region): Ditto.
5070
5071 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5072
5073 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5074 rather than `XVECTOR (FOO)->size'.
5075
5076 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5077 inttypes.h, as a gnulib replacement is used if it not available in
5078 system headers.
5079
5080 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5081
5082 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5083 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5084 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5085
5086 * coding.c (coding_alloc_by_realloc): Error out if destination
5087 will grow beyond MOST_POSITIVE_FIXNUM.
5088 (decode_coding_emacs_mule): Abort if there isn't enough place in
5089 charbuf for the composition carryover bytes. Reserve an extra
5090 space for up to 2 characters produced in a loop.
5091 (decode_coding_iso_2022): Abort if there isn't enough place in
5092 charbuf for the composition carryover bytes.
5093
5094 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5095
5096 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5097 aborting when %lld or %lll format is passed.
5098 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5099 %llo or %llx format is passed. (Bug#8545)
5100
5101 * window.c (window_scroll_line_based): Use a marker instead of
5102 simple variables to record original value of point. (Bug#7952)
5103
5104 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5105 produced by %s or %c overflows available buffer space. (Bug#8545)
5106
5107 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5108
5109 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5110 (SIZE_MAX): Move defn after all includes, as they might #define it.
5111
5112 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5113
5114 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5115
5116 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5117
5118 * keyboard.c (Qdelayed_warnings_hook): Define.
5119 (command_loop_1): Run `delayed-warnings-hook'
5120 if Vdelayed_warnings_list is non-nil.
5121 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5122 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5123
5124 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5125
5126 * doprnt.c (doprnt): Don't return value smaller than the buffer
5127 size if the message was truncated. (Bug#8545).
5128
5129 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5130
5131 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5132 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5133
5134 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5135
5136 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5137
5138 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5139
5140 * makefile.w32-in: Update dependencies.
5141
5142 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5143
5144 Improve `doprnt' and its usage. (Bug#8545)
5145 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5146 `format_end'. Remove support for %l as a conversion specifier.
5147 Don't use xrealloc. Improve diagnostics when the %l size modifier
5148 is used. Update the commentary.
5149
5150 * eval.c (verror): Simplify calculation of size_t.
5151
5152 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5153 messages.
5154
5155 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5156
5157 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5158 change.
5159
5160 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5161
5162 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5163 This makes this file independent of the recent pseudovector change.
5164
5165 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5166
5167 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5168
5169 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5170 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5171 Remove unused local.
5172 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5173
5174 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5175 GCC 4.6.0 optimizes based on type-based alias analysis.
5176 For example, if b is of type struct buffer * and v of type struct
5177 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5178 != &v->size, and therefore "v->size = 1; b->size = 2; return
5179 v->size;" must therefore return 1. This assumption is incorrect
5180 for Emacs, since it type-puns struct Lisp_Vector * with many other
5181 types. To fix this problem, this patch adds a new type struct
5182 vectorlike_header that documents the constraints on layout of vectors
5183 and pseudovectors, and helps optimizing compilers not get fooled
5184 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5185 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5186 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5187 the size member.
5188 (XSETPVECTYPE): Rewrite in terms of new macro.
5189 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5190 This is a bit clearer, and further avoids the possibility of
5191 undesirable aliasing.
5192 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5193 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5194 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5195 since Lisp_Subr is a special case (no "next" field).
5196 (ASIZE): Now uses header.size rather than size.
5197 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5198 to avoid the hassle of writing XVECTOR (foo)->header.size.
5199 (struct vectorlike_header): New type.
5200 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5201 object, to help avoid aliasing.
5202 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5203 (SUBRP): Likewise, since Lisp_Subr is a special case.
5204 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5205 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5206 (struct Lisp_Hash_Table): Combine first two members into a single
5207 struct vectorlike_header member. All uses of "size" and "next" members
5208 changed to be "header.size" and "header.next".
5209 * buffer.h (struct buffer): Likewise.
5210 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5211 * frame.h (struct frame): Likewise.
5212 * process.h (struct Lisp_Process): Likewise.
5213 * termhooks.h (struct terminal): Likewise.
5214 * window.c (struct save_window_data, struct saved_window): Likewise.
5215 * window.h (struct window): Likewise.
5216 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5217 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5218 * buffer.c (init_buffer_once): Likewise.
5219 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5220 special case.
5221 * process.c (Fformat_network_address): Use local var for size,
5222 for brevity.
5223
5224 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5225
5226 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5227 * data.c (atof): Remove decl; no longer used or needed.
5228 (digit_to_number): Move to lread.c.
5229 (Fstring_to_number): Use new string_to_number function, to be
5230 consistent with how the Lisp reader treats infinities and NaNs.
5231 Do not assume that floating-point numbers represent EMACS_INT
5232 without losing information; this is not true on most 64-bit hosts.
5233 Avoid double-rounding errors, by insisting on integers when
5234 parsing non-base-10 numbers, as the documentation specifies.
5235 * lisp.h (string_to_number): New decl, replacing ...
5236 (isfloat_string): Remove.
5237 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5238 (read1): Do not accept +. and -. as integers; this
5239 appears to have been a coding error. Similarly, do not accept
5240 strings like +-1e0 as floating point numbers. Do not report
5241 overflow for integer overflows unless the base is not 10 which
5242 means we have no simple and reliable way to continue.
5243 Break out the floating-point parsing into a new
5244 function string_to_number, so that Fstring_to_number parses
5245 floating point numbers consistently with the Lisp reader.
5246 (digit_to_number): Move here from data.c. Make it static inline.
5247 (E_CHAR, EXP_INT): Remove, replacing with ...
5248 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5249 (string_to_number): New function, replacing isfloat_string.
5250 This function checks for valid syntax and produces the resulting
5251 Lisp float number too. Rework it so that string-to-number
5252 no longer mishandles examples like "1.0e+". Use strtoumax,
5253 so that overflow for non-base-10 numbers is reported only when
5254 there's no portable and simple way to convert to floating point.
5255
5256 * textprop.c (set_text_properties_1): Rewrite for clarity,
5257 and to avoid GCC warning about integer overflow.
5258
5259 * intervals.h (struct interval): Use EMACS_INT for members
5260 where EMACS_UINT might cause problems. See
5261 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5262 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5263 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5264 All uses changed.
5265 (offset_intervals): Tell GCC not to worry about length overflow
5266 when negating a negative length.
5267
5268 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5269 (overrun_check_free): Likewise.
5270
5271 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5272 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5273 word size.
5274
5275 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5276 (gnutls_make_error): Rename local to avoid shadowing.
5277 (gnutls_emacs_global_deinit): ifdef out; not used.
5278 (Fgnutls_boot): Use const for pointer to readonly storage.
5279 Comment out unused local. Fix pointer signedness problems.
5280
5281 * lread.c (openp): Don't stuff size_t into an 'int'.
5282 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5283 about possible signed overflow.
5284
5285 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5286 (GDK_KEY_g): Don't define if already defined.
5287 (xg_prepare_tooltip): Avoid pointer signedness problem.
5288 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5289
5290 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5291 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5292
5293 * xfns.c (Fx_window_property): Simplify a bit,
5294 to make a bit faster and to avoid GCC 4.6.0 warning.
5295 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5296
5297 * fns.c (internal_equal): Don't assume size_t fits in int.
5298
5299 * alloc.c (compact_small_strings): Tighten assertion a little.
5300
5301 Replace pEd with more-general pI, and fix some printf arg casts.
5302 * lisp.h (pI): New macro, generalizing old pEd macro to other
5303 conversion specifiers. For example, use "...%"pI"d..." rather
5304 than "...%"pEd"...".
5305 (pEd): Remove. All uses replaced with similar uses of pI.
5306 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5307 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5308 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5309 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5310 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5311 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5312 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5313 64-bit hosts.
5314 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5315 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5316 * print.c (safe_debug_print, print_object): Likewise.
5317 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5318 to int.
5319 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5320 avoiding the 0 flag, which is not portable.
5321 * process.c (Fmake_network_process): Use pI to avoid cast.
5322 * region-cache.c (pp_cache): Likewise.
5323 * xdisp.c (decode_mode_spec): Likewise.
5324 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5325 behavior on 64-bit hosts with printf arg.
5326 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5327 (x_stop_queuing_selection_requests): Likewise.
5328 (x_get_window_property): Don't truncate byte count to an 'int'
5329 when tracing.
5330
5331 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5332 here, since it parses constructs like leading '-' and spaces,
5333 which are not wanted; and it overflows with large numbers.
5334 Instead, simply match F[0-9]+, which is what is wanted anyway.
5335
5336 * alloc.c: Remove unportable assumptions about struct layout.
5337 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5338 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5339 (allocate_vectorlike, make_pure_vector): Use the new macros,
5340 plus offsetof, to remove unportable assumptions about struct layout.
5341 These assumptions hold on all porting targets that I know of, but
5342 they are not guaranteed, they're easy to remove, and removing them
5343 makes further changes easier.
5344
5345 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5346 This doesn't fix a bug but makes the code clearer.
5347 (string_overrun_cookie): Now const. Use initializers that
5348 don't formally overflow signed char, to avoid warnings.
5349 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5350 can cause Emacs to crash when string overrun checking is enabled.
5351 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5352 multiple of sizeof (EMACS_INT); it need not be, if
5353 alignof(EMACS_INT) < sizeof (EMACS_INT).
5354 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5355
5356 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5357
5358 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5359
5360 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5361
5362 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5363 supposed to be handshaking. (Bug#8556)
5364 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5365
5366 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5367
5368 * lisp.h (Qdebug): List symbol.
5369 * eval.c (Qdebug): Restore global linkage.
5370 * keyboard.c (debug-on-event): New variable.
5371 (handle_user_signal): Break into debugger when debug-on-event
5372 matches the current signal symbol.
5373
5374 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5375
5376 * alloc.c (check_sblock, check_string_bytes)
5377 (check_string_free_list): Convert to standard C.
5378
5379 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5380
5381 * w32.c (emacs_gnutls_push): Fix typo.
5382
5383 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5384
5385 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5386 "cast to pointer from integer of different size".
5387
5388 Improve doprnt and its use in verror. (Bug#8545)
5389 * doprnt.c (doprnt): Document the set of format control sequences
5390 supported by the function. Use SAFE_ALLOCA instead of always
5391 using `alloca'.
5392
5393 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5394 is one byte too soon. Don't use xrealloc; instead xfree and
5395 xmalloc anew.
5396
5397 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5398
5399 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5400 callbacks stage.
5401
5402 * gnutls.c: Renamed global_initialized to
5403 gnutls_global_initialized. Added internals for the
5404 :verify-hostname-error, :verify-error, and :verify-flags
5405 parameters of `gnutls-boot' and documented those parameters in the
5406 docstring. Start callback support.
5407 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5408 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5409 on error. Return error code.
5410 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5411 (emacs_gnutls_read): Likewise.
5412 (Fgnutls_boot): Return handshake error code.
5413 (emacs_gnutls_handle_error): New function.
5414 (wsaerror_to_errno): Likewise.
5415
5416 * w32.h (emacs_gnutls_pull): Add prototype.
5417 (emacs_gnutls_push): Likewise.
5418
5419 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5420 (emacs_gnutls_push): Likewise.
5421
5422 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5423
5424 * process.c (wait_reading_process_output): Check if GnuTLS
5425 buffered some data internally if no FDs are set for TLS
5426 connections.
5427
5428 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5429 (LIBS): Link to USER_LIBS.
5430 ($(BLD)/gnutls.$(0)): New target.
5431
5432 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5433
5434 * xdisp.c (handle_single_display_spec): Rename the
5435 display_replaced_before_p argument into display_replaced_p, to
5436 make it consistent with the commentary. Fix typos in the
5437 commentary.
5438
5439 * textprop.c (syms_of_textprop): Remove dead code.
5440 (copy_text_properties): Delete obsolete commentary about an
5441 interface that was deleted long ago. Fix typos in the description
5442 of arguments.
5443
5444 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5445 to changes in oldXMenu/XMenu.h from 2011-04-16.
5446 <menu_help_message, prev_menu_help_message>: Constify.
5447 (IT_menu_make_room): menu->help_text is now `const char **';
5448 adjust.
5449
5450 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5451 to changes in oldXMenu/XMenu.h from 2011-04-16.
5452 (struct XMenu): Declare `help_text' `const char **'.
5453
5454 * xfaces.c <Qunspecified>: Make extern again.
5455
5456 * syntax.c: Include sys/types.h before including regex.h, as
5457 required by Posix.
5458
5459 * doc.c (get_doc_string): Improve the format passed to `error'.
5460
5461 * doprnt.c (doprnt): Improve commentary.
5462
5463 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5464
5465 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5466 them with etags.
5467
5468 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5469 changes in globals.h immediately force recompilation.
5470 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5471 $(CURDIR)/s/ms-w32.h.
5472 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5473
5474 * character.c (Fchar_direction): Function deleted.
5475 (syms_of_character): Don't defsubr it.
5476 <char-direction-table>: Deleted.
5477
5478 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5479
5480 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5481 * doprnt.c: Include limits.h.
5482 (SIZE_MAX): New macro.
5483 (doprnt): Return a size_t value. 2nd arg is now size_t.
5484 Many local variables are now size_t instead of int or unsigned.
5485 Improve overflow protection. Support `l' modifier for integer
5486 conversions. Support %l conversion. Don't assume an EMACS_INT
5487 argument for integer conversions and for %c.
5488
5489 * lisp.h (doprnt): Restore prototype.
5490
5491 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5492 $(SRC)/character.h.
5493
5494 * Makefile.in (base_obj): Add back doprnt.o.
5495
5496 * deps.mk (doprnt.o): Add back prerequisites.
5497 (callint.o): Depend on character.h.
5498
5499 * eval.c (internal_lisp_condition_case): Include the handler
5500 representation in the error message.
5501 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5502 when breaking from the loop.
5503
5504 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5505
5506 * callint.c (Fcall_interactively): When displaying error message
5507 about invalid control letter, pass the character's codepoint, not
5508 a pointer to its multibyte form. Improve display of the character
5509 in octal and display also its hex code.
5510
5511 * character.c (char_string): Use %x to display the (unsigned)
5512 codepoint of an invalid character, to avoid displaying a bogus
5513 negative value.
5514
5515 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5516 `error', not SYMBOL_NAME itself.
5517
5518 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5519 character arguments to `error'.
5520
5521 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5522 to `error' in error message about FINAL_CHAR argument. Make sure
5523 FINAL_CHAR is a character, and use %c when it is passed as
5524 argument to `error'.
5525
5526 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5527
5528 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5529
5530 * w32.c: Include <time.h>.
5531 (sys_localtime): New function.
5532
5533 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5534
5535 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5536
5537 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5538
5539 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5540
5541 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5542 zombies (Bug#8467).
5543
5544 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5545
5546 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5547 gl_state.e_property when gl_state.object is Qt.
5548
5549 * insdel.c (make_gap_larger): Remove limitation of buffer size
5550 to <= INT_MAX.
5551
5552 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5553
5554 * xdisp.c (lookup_glyphless_char_display)
5555 (produce_glyphless_glyph): Handle cons cell entry in
5556 glyphless-char-display.
5557 (Vglyphless_char_display): Document it.
5558
5559 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5560 glyphless-char-display.
5561
5562 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5563
5564 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5565
5566 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5567
5568 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5569 definition for no-X builds.
5570
5571 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5572
5573 Static checks with GCC 4.6.0 and non-default toolkits.
5574
5575 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5576
5577 * process.c (keyboard_bit_set): Define only if SIGIO.
5578 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5579 (send_process): Repair possible setjmp clobbering.
5580
5581 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5582
5583 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5584
5585 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5586
5587 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5588 Define only if needed.
5589
5590 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5591 by pacifying GCC about it. Maybe it's time to retire it?
5592 * xfaces.c (USG, __TIMEVAL__): Likewise.
5593
5594 * dispextern.h (struct redisplay_interface): Rename param
5595 to avoid shadowing.
5596 * termhooks.h (struct terminal): Likewise.
5597 * xterm.c (xembed_send_message): Likewise.
5598
5599 * insdel.c (make_gap_smaller): Define only if
5600 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5601
5602 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5603 it.
5604
5605 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5606 so that we aren't warned about unused symbols.
5607
5608 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5609
5610 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5611
5612 * xfns.c (x_real_positions): Mark locals as initialized.
5613
5614 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5615
5616 * xterm.c: Fix problems found by static analysis with other toolkits.
5617 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5618 (x_dispatch_event): Declare static if USE_GTK, and
5619 define if USE_GTK || USE_X_TOOLKIT.
5620 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5621 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5622 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5623 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5624
5625 * xmenu.c (menu_help_callback): Pointer type fixes.
5626 Use const pointers when pointing at readonly data. Avoid pointer
5627 signedness clashes.
5628 (FALSE): Remove unused macro.
5629 (update_frame_menubar): Remove unused decl.
5630
5631 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5632
5633 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5634 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5635 (single_menu_item): Rename local to avoid shadowing.
5636
5637 * keyboard.c (make_lispy_event): Remove unused local var.
5638
5639 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5640 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5641
5642 * bitmaps: Change bitmaps from unsigned char back to the X11
5643 compatible char. Avoid the old compiler warnings about
5644 out-of-range initializers by using, for example, '\xab' rather
5645 than 0xab.
5646
5647 * xgselect.c (xgselect_initialize): Check vs interface
5648 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5649
5650 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5651
5652 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5653 to read-only memory.
5654
5655 * fns.c (vector): Remove; this old hack is no longer needed.
5656
5657 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5658 Remove unused var.
5659 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5660
5661 * xrdb.c (x_load_resources): Omit unused local.
5662
5663 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5664 (x_window): Rename locals to avoid shadowing.
5665 (USG): Use the kludged USG macro, to pacify gcc.
5666
5667 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5668 (x_term_init): Remove local to avoid shadowing.
5669
5670 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5671
5672 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5673 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5674
5675 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5676
5677 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5678
5679 Fix regex.c, syntax.c and friends for buffers > 2GB.
5680 * syntax.h (struct gl_state_s): Declare character position members
5681 EMACS_INT.
5682
5683 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5684
5685 * textprop.c (verify_interval_modification, interval_of):
5686 Declare arguments EMACS_INT.
5687
5688 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5689 EMACS_INT.
5690
5691 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5692
5693 * indent.c (Fvertical_motion): Local variable it_start is now
5694 EMACS_INT.
5695
5696 * regex.c (re_match, re_match_2, re_match_2_internal)
5697 (bcmp_translate, regcomp, regexec, print_double_string)
5698 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5699 (re_compile_pattern, re_exec): Declare arguments and local
5700 variables `size_t' and `ssize_t' and return values `regoff_t', as
5701 appropriate.
5702 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5703 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5704 <compile_stack_type>: `size' and `avail' are now `size_t'.
5705
5706 * regex.h <regoff_t>: Use ssize_t, not int.
5707 (re_search, re_search_2, re_match, re_match_2): Arguments that
5708 specify buffer/string position and length are now ssize_t and
5709 size_t. Return type is regoff_t.
5710
5711 2011-04-16 Ben Key <bkey76@gmail.com>
5712
5713 * nsfont.m: Fixed bugs in ns_get_family and
5714 ns_descriptor_to_entity that were caused by using free to
5715 deallocate memory blocks that were allocated by xmalloc (via
5716 xstrdup). This caused Emacs to crash when compiled with
5717 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5718 --enable-checking=xmallocoverrun). xfree is now used to
5719 deallocate these memory blocks.
5720
5721 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5722
5723 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5724
5725 emacs_write: Accept and return EMACS_INT for sizes.
5726 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5727 et seq.
5728 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5729 Accept and return EMACS_INT.
5730 (emacs_gnutls_write): Return the number of bytes written on
5731 partial writes.
5732 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5733 (emacs_read, emacs_write): Remove check for negative size, as the
5734 Emacs source code has been audited now.
5735 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5736 (emacs_read, emacs_write): Use it.
5737 * process.c (send_process): Adjust to the new signatures of
5738 emacs_write and emacs_gnutls_write. Do not attempt to store
5739 a byte offset into an 'int'; it might overflow.
5740 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5741
5742 * sound.c: Don't assume sizes fit in 'int'.
5743 (struct sound_device.period_size, alsa_period_size):
5744 Return EMACS_INT, not int.
5745 (struct sound_device.write, vox_write, alsa_write):
5746 Accept EMACS_INT, not int.
5747 (wav_play, au_play): Use EMACS_INT to store sizes and to
5748 record read return values.
5749
5750 2011-04-15 Ben Key <bkey76@gmail.com>
5751
5752 * keyboard.c (Qundefined): Don't declare static since it is used
5753 in nsfns.m.
5754 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5755 static since they are used in nsfont.m.
5756
5757 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5758
5759 * process.c (Qprocessp): Don't declare static.
5760 * lisp.h (Qprocessp): Declare again.
5761
5762 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5763
5764 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5765
5766 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5767
5768 Improve C-level modularity by making more things 'static'.
5769
5770 Don't publish debugger-only interfaces to other modules.
5771 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5772 (verify_bytepos, count_markers): Move decls to the only modules
5773 that need them.
5774 * region-cache.h (pp_cache): Likewise.
5775 * window.h (check_all_windows): Likewise.
5776 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5777
5778 * sysdep.c (croak): Now static, if
5779 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5780 * syssignal.h (croak): Declare only if not static.
5781
5782 * alloc.c (refill_memory_reserve): Now static if
5783 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5784 * lisp.h (refill_memory_reserve): Declare only if not static.
5785
5786 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5787 Define only if USE_LUCID.
5788
5789 * xrdb.c (x_customization_string, x_rm_string): Now static.
5790
5791 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5792 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5793
5794 * xdisp.c (draw_row_with_mouse_face): Now static.
5795 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5796
5797 * window.h (check_all_windows): Mark externally visible.
5798
5799 * window.c (window_deletion_count): Now static.
5800
5801 * undo.c: Make symbols static if they're not exported.
5802 (last_undo_buffer, last_boundary_position, pending_boundary):
5803 Now static.
5804
5805 * textprop.c (interval_insert_behind_hooks): Now static.
5806 (interval_insert_in_front_hooks): Likewise.
5807
5808 * term.c: Make symbols static if they're not exported.
5809 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5810 (max_frame_lines, tty_set_terminal_modes):
5811 (tty_reset_terminal_modes, tty_turn_off_highlight):
5812 (get_tty_terminal): Now static.
5813 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5814 * termhooks.h (term_mouse_moveto): Do not declare if
5815 HAVE_WINDOW_SYSTEM.
5816 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5817 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5818
5819 * sysdep.c: Make symbols static if they're not exported.
5820 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5821 Now static.
5822 (sigprocmask_set, full_mask): Remove; unused.
5823 (wait_debugging): Mark as visible.
5824 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5825 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5826
5827 * syntax.c (syntax_temp): Define only if !__GNUC__.
5828
5829 * sound.c (current_sound_device, current_sound): Now static.
5830
5831 * search.c (searchbufs, searchbuf_head): Now static.
5832
5833 * scroll.c (scroll_cost): Remove; unused.
5834 * dispextern.h (scroll_cost): Remove decl.
5835
5836 * region-cache.h (pp_cache): Mark as externally visible.
5837
5838 * process.c: Make symbols static if they're not exported.
5839 (process_tick, update_tick, create_process, chan_process):
5840 (Vprocess_alist, proc_buffered_char, datagram_access):
5841 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5842 (deactivate_process): Mark defn as static, as well as decl.
5843 * lisp.h (create_process): Remove decl.
5844 * process.h (chan_process, Vprocess_alist): Remove decls.
5845
5846 * print.c: Make symbols static if they're not exported.
5847 (print_depth, new_backquote_output, being_printed, print_buffer):
5848 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5849 (print_interval, print_number_index, initial_stderr_stream):
5850 Now static.
5851 * lisp.h (Fprinc): Remove decl.
5852 (debug_output_compilation_hack): Mark as externally visible.
5853
5854 * sysdep.c (croak): Move decl from here to syssignal.h.
5855 * syssignal.h (croak): Put it here, so the API can be checked when
5856 'croak' is called from dissociate_if_controlling_tty.
5857
5858 * minibuf.c: Make symbols static if they're not exported.
5859 (minibuf_save_list, choose_minibuf_frame): Now static.
5860 * lisp.h (choose_minibuf_frame): Remove decl.
5861
5862 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5863
5864 * lread.c: Make symbols static if they're not exported.
5865 (read_objects, initial_obarray, oblookup_last_bucket_number):
5866 Now static.
5867 (make_symbol): Remove; unused.
5868 * lisp.h (initial_obarray, make_symbol): Remove decls.
5869
5870 * keyboard.c: Make symbols static if they're not exported.
5871 (single_kboard, recent_keys_index, total_keys, recent_keys):
5872 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5873 (this_single_command_key_start, echoing, last_auto_save):
5874 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5875 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5876 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5877 (Vlispy_mouse_stem, double_click_count):
5878 Now static.
5879 (force_auto_save_soon): Define only if SIGDANGER.
5880 (ignore_mouse_drag_p): Now static if
5881 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5882 (print_help): Remove; unused.
5883 (stop_character, last_timer_event): Mark as externally visible.
5884 * keyboard.h (ignore_mouse_drag_p): Declare only if
5885 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5886 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5887 * lisp.h (echoing): Remove decl.
5888 (force_auto_save_soon): Declare only if SIGDANGER.
5889 * xdisp.c (redisplay_window): Simplify code, to make it more
5890 obvious that ignore_mouse_drag_p is not accessed if !defined
5891 USE_GTK && !defined HAVE_NS.
5892
5893 * intervals.c: Make symbols static if they're not exported.
5894 (merge_properties_sticky, merge_interval_right, delete_interval):
5895 Now static.
5896 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5897
5898 * insdel.c: Make symbols static if they're not exported.
5899 However, leave prepare_to_modify_buffer alone. It's never
5900 called from outside this function, but that appears to be a bug.
5901 (combine_after_change_list, combine_after_change_buffer):
5902 (adjust_after_replace, signal_before_change): Now static.
5903 (adjust_after_replace_noundo): Remove; unused.
5904 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5905 (signal_before_change): Remove decls.
5906
5907 * indent.c (val_compute_motion, val_vmotion): Now static.
5908
5909 * image.c: Make symbols static if they're not exported.
5910 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5911 if USE_GTK.
5912 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5913 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5914
5915 * fringe.c (standard_bitmaps): Now static.
5916 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5917
5918 * frame.c: Make symbols static if they're not exported.
5919 (x_report_frame_params, make_terminal_frame): Now static.
5920 (get_frame_param): Now static, unless HAVE_NS.
5921 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5922 (x_get_resource_string): Remove; not used.
5923 * frame.h (make_terminal_frame, x_report_frame_params):
5924 (x_get_resource_string); Remove decls.
5925 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5926 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5927
5928 * font.c, fontset.c: Make symbols static if they're not exported.
5929 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5930 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5931 * font.c (font_close_object): Now static.
5932 * font.h (font_close_object): Remove.
5933 * fontset.c (FONTSET_OBJLIST): Remove.
5934 (free_realized_fontset) #if-0 the body, which does nothing.
5935 (face_suitable_for_char_p): #if-0, as it's never called.
5936 * fontset.h (face_suitable_for_char_p): Remove decl.
5937 * xfaces.c (face_at_string_position):
5938 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5939 since 0 is always ASCII.
5940
5941 * fns.c (weak_hash_tables): Now static.
5942
5943 * fileio.c: Make symbols static if they're not exported.
5944 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5945 (Vwrite_region_annotation_buffers): Now static.
5946
5947 * eval.c: Make symbols static if they're not exported.
5948 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5949 * lisp.h (backtrace_list): Remove decl.
5950
5951 * emacs.c: Make symbols static if they're not exported.
5952 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5953 (fatal_error_code, fatal_error_signal_hook, standard_args):
5954 Now static.
5955 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5956 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5957 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5958 * lisp.h (fatal_error_signal_hook): Remove decl.
5959 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5960
5961 * editfns.c: Move a (normally-unused) function to its only use.
5962 * editfns.c, lisp.h (get_operating_system_release): Remove.
5963 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5964 worth the hassle of breaking this out.
5965
5966 * xterm.c: Make symbols static if they're not exported.
5967 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5968 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5969 (x_destroy_window, x_delete_display):
5970 Now static.
5971 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5972 (x_mouse_leave): Remove; unused.
5973 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5974 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5975 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5976 Remove decls.
5977 (x_mouse_leave): Declare only if WINDOWSNT.
5978 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5979 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5980 USE_X_TOOLKIT.
5981
5982 * ftxfont.c: Make symbols static if they're not exported.
5983 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5984 HAVE_FREETYPE.
5985 * font.h (ftxfont_driver): Likewise.
5986
5987 * xfns.c: Make symbols static if they're not exported.
5988 (x_last_font_name, x_display_info_for_name):
5989 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5990 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5991 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5992 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5993 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5994 (last_show_tip_args): Now static.
5995 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5996 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5997 (x_screen_planes): Remove; unused.
5998 * dispextern.h (x_screen_planes): Remove decl.
5999
6000 * dispnew.c: Make symbols static if they're not exported.
6001 * dispextern.h (redraw_garbaged_frames, scrolling):
6002 (increment_row_positions): Remove.
6003 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6004 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6005 Now static.
6006 (redraw_garbaged_frames): Remove; unused.
6007
6008 * xfaces.c: Make symbols static if they're not exported.
6009 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6010 Remove decls.
6011 * xterm.h (defined_color): Remove decls.
6012 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6013 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6014 (menu_face_changed_default, defined_color, free_realized_face):
6015 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6016 (ascii_face_of_lisp_face): Remove; unused.
6017
6018 * xdisp.c: Make symbols static if they're not exported.
6019 * dispextern.h (scratch_glyph_row, window_box_edges):
6020 (glyph_to_pixel_coords, set_cursor_from_row):
6021 (get_next_display_element, set_iterator_to_next):
6022 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6023 (show_mouse_face): Remove decls
6024 * frame.h (message_buf_print): Likewise.
6025 * lisp.h (pop_message, set_message, check_point_in_composition):
6026 Likewise.
6027 * xterm.h (set_vertical_scroll_bar): Likewise.
6028 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6029 (message_buf_print, scratch_glyph_row, displayed_buffer):
6030 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6031 (get_next_display_element, show_mouse_face, window_box_edges):
6032 (frame_to_window_pixel_xy, check_point_in_composition):
6033 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6034 (glyph_to_pixel_coords): Remove; unused.
6035
6036 * dired.c (file_name_completion): Now static.
6037
6038 * dbusbind.c (xd_in_read_queued_messages): Now static.
6039
6040 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6041 * data.c (circular_list_error): Remove.
6042
6043 * commands.h (last_point_position, last_point_position_buffer):
6044 (last_point_position_window): Remove decls.
6045 * keyboard.c: Make these variables static.
6046
6047 * coding.h (coding, code_convert_region, encode_coding_gap):
6048 Remove decls.
6049 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6050 (iso_code_class, detect_coding, code_convert_region): Now static.
6051 (encode_coding_gap): Remove; unused.
6052
6053 * chartab.c (chartab_chars, chartab_bits): Now static.
6054
6055 * charset.h (charset_iso_8859_1): Remove decl.
6056 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6057 Now static.
6058
6059 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6060 * ccl.c (Vccl_program_table): Now static.
6061 (check_ccl_update): Remove; unused.
6062
6063 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6064 * category.h: ... from here.
6065 * category.c (check_category_table, set_category_set): Now static.
6066
6067 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6068 * lisp.h: Remove these decls.
6069
6070 * buffer.c (buffer_count): Remove unused var.
6071
6072 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6073 so that it's not optimized away.
6074 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6075 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6076 exported only to the debugger.
6077
6078 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6079 * atimer.h (run_all_atimers): Remove; not exported.
6080
6081 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6082 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6083 was inaccessible from Lisp.
6084 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6085 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6086
6087 alloc.c: Import and export fewer symbols, and remove unused items.
6088 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6089 is defined.
6090 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6091 it's not optimized away by whole-program optimization.
6092 (message_enable_multibyte, free_misc): Remove.
6093 (catchlist, handlerlist, mark_backtrace):
6094 Declare only if BYTE_MARK_STACK.
6095 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6096 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6097 (message_enable_multibyte): Remove decl.
6098 (free_misc, interval_free_list, float_block, float_block_index):
6099 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6100 (cons_free_list, last_marked_index):
6101 Now static.
6102 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6103 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6104 (mark_backtrace): Define only if BYTE_MARK_STACK.
6105 * xdisp.c (message_enable_multibyte): Now static.
6106
6107 Declare Lisp_Object Q* variables to be 'static' if not exported.
6108 This makes it easier for human readers (and static analyzers)
6109 to see whether these variables are used from other modules.
6110 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6111 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6112 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6113 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6114 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6115 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6116 * xmenu.c, xselect.c:
6117 Declare Q* vars static if they are not used in other modules.
6118 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6119 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6120 Remove decls of unexported vars.
6121 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6122
6123 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6124
6125 Make Emacs functions such as Fatom 'static' by default.
6126 This makes it easier for human readers (and static analyzers)
6127 to see whether these functions can be called from other modules.
6128 DEFUN now defines a static function. To make the function external
6129 so that it can be used in other C modules, use the new macro DEFUE.
6130 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6131 (Finit_image_library):
6132 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6133 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6134 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6135 Remove decls, since these functions are now static.
6136 (Funintern, Fget_internal_run_time): New decls, since these functions
6137 were already external.
6138
6139 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6140 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6141 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6142 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6143 * keyboard.c, keymap.c, lread.c:
6144 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6145 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6146 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6147 Mark functions with DEFUE instead of DEFUN,
6148 if they are used in other modules.
6149 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6150 decls for now-static functions.
6151 * buffer.h (Fdelete_overlay): Remove decl.
6152 * callproc.c (Fgetenv_internal): Mark as internal.
6153 * composite.c (Fremove_list_of_text_properties): Remove decl.
6154 (Fcomposition_get_gstring): New forward static decl.
6155 * composite.h (Fcomposite_get_gstring): Remove decl.
6156 * dired.c (Ffile_attributes): New forward static decl.
6157 * doc.c (Fdocumntation_property): New forward static decl.
6158 * eval.c (Ffetch_bytecode): New forward static decl.
6159 (Funintern): Remove extern decl; now in .h file where it belongs.
6160 * fileio.c (Fmake_symbolic_link): New forward static decl.
6161 * image.c (Finit_image_library): New forward static decl.
6162 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6163 * intervals.h (Fprevious_property_change):
6164 (Fremove_list_of_text_properties): Remove decls.
6165 * keyboard.c (Fthis_command_keys): Remove decl.
6166 (Fcommand_execute): New forward static decl.
6167 * keymap.c (Flookup_key): New forward static decl.
6168 (Fcopy_keymap): Now static.
6169 * keymap.h (Flookup_key): Remove decl.
6170 * process.c (Fget_process): New forward static decl.
6171 (Fprocess_datagram_address): Mark as internal.
6172 * syntax.c (Fsyntax_table_p): New forward static decl.
6173 (skip_chars): Remove duplicate decl.
6174 * textprop.c (Fprevious_property_change): New forward static decl.
6175 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6176 Now internal.
6177 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6178 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6179
6180 * editfns.c (Fformat): Remove unreachable code.
6181
6182 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6183
6184 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6185 change. (Bug#8496)
6186
6187 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6188
6189 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6190 when at ZV. (Bug#8487)
6191
6192 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6193
6194 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6195 (Bug#8437)
6196 * keyboard.c (parse_tool_bar_item): Likewise.
6197 * sound.c (sound_cleanup, alsa_close): Likewise.
6198 * termcap.c (tgetent): Likewise.
6199 * xfns.c (x_default_font_parameter): Likewise.
6200 * xsettings.c (read_and_apply_settings): Likewise.
6201
6202 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6203 (overrun_check_free): Protoize.
6204
6205 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6206
6207 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6208 since callers should never pass a negative size.
6209 Change the signature to match that of plain 'read' and 'write'; see
6210 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6211 * lisp.h: Update prototypes of emacs_write and emacs_read.
6212
6213 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6214
6215 * xdisp.c (redisplay_window): Don't try to determine the character
6216 position of the scroll margin if the window start point w->startp
6217 is outside the buffer's accessible region. (Bug#8468)
6218
6219 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6220
6221 Fix write-region and its subroutines for buffers > 2GB.
6222 * fileio.c (a_write, e_write): Modify declaration of arguments and
6223 local variables to support buffers larger than 2GB.
6224 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6225
6226 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6227 argument, local variables, and return value.
6228
6229 * lisp.h: Update prototypes of emacs_write and emacs_read.
6230
6231 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6232
6233 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6234
6235 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6236
6237 Fix more problems found by GCC 4.6.0's static checks.
6238
6239 * xdisp.c (vmessage): Use a better test for character truncation.
6240
6241 * charset.c (load_charset_map): <, not <=, for optimization,
6242 and to avoid potential problems with integer overflow.
6243 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6244 * casetab.c (set_identity, shuffle): Likewise.
6245 * editfns.c (Fformat): Likewise.
6246 * syntax.c (skip_chars): Likewise.
6247
6248 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6249 This also lets GCC 4.6.0 generate slightly better loop code.
6250
6251 * callint.c (Fcall_interactively): <, not <=, for optimization.
6252 (Fcall_interactively): Count the number of arguments produced,
6253 not the number of arguments given. This is simpler and lets GCC
6254 4.6.0 generate slightly better code.
6255
6256 * ftfont.c: Distingish more carefully between FcChar8 and char.
6257 The previous code passed unsigned char * to a functions like
6258 strlen and xstrcasecmp that expect char *, which does not
6259 conform to the C standard.
6260 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6261 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6262 char * when the C standard requires it.
6263
6264 * keyboard.c (read_char): Remove unused var.
6265
6266 * eval.c: Port to Windows vsnprintf (Bug#8435).
6267 Include <limits.h>.
6268 (SIZE_MAX): Define if the headers do not.
6269 (verror): Do not give up if vsnprintf returns a negative count.
6270 Instead, grow the buffer. This ports to Windows vsnprintf, which
6271 does not conform to C99. Problem reported by Eli Zaretskii.
6272 Also, simplify the allocation scheme, by avoiding the need for
6273 calling realloc, and removing the ALLOCATED variable.
6274
6275 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6276
6277 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6278 But keep the doprint source code for now, as we might revamp it
6279 and use it again (Bug#8435).
6280 * lisp.h (doprnt): Remove.
6281 * Makefile.in (base_obj): Remove doprnt.o.
6282 * deps.mk (doprnt.o): Remove.
6283
6284 error: Print 32- and 64-bit integers portably (Bug#8435).
6285 Without this change, on typical 64-bit hosts error ("...%d...", N)
6286 was used to print both 32- and 64-bit integers N, which relied on
6287 undefined behavior.
6288 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6289 New macro.
6290 * lisp.h (error, verror): Mark as printf-like functions.
6291 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6292 Report overflow in size calculations when allocating printf buffer.
6293 Do not truncate output string at its first null byte.
6294 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6295 Truncate the output at a character boundary, since vsnprintf does not
6296 do that.
6297 * charset.c (check_iso_charset_parameter): Convert internal
6298 character to string before calling 'error', since %c now has the
6299 printf meaning.
6300 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6301 overflow when computing char to be passed to 'error'. Do not
6302 pass Lisp_Object to 'error'; pass the integer instead.
6303 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6304 formatted with plain %d.
6305
6306 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6307
6308 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6309
6310 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6311
6312 * xterm.c (x_catch_errors): Remove duplicate declaration.
6313
6314 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6315
6316 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6317
6318 2011-04-10 Jim Meyering <meyering@redhat.com>
6319
6320 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6321 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6322 return ssize_t not "int", and use size_t as the buffer length.
6323 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6324 * gnutls.h: Update declarations.
6325 * process.c (read_process_output): Use ssize_t, to match.
6326 (send_process): Likewise.
6327
6328 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6329
6330 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6331
6332 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6333
6334 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6335 Use unsigned char, to match FcChar8 type definition.
6336
6337 * xterm.c (handle_one_xevent):
6338 * xmenu.c (create_and_show_popup_menu):
6339 * xselect.c (x_decline_selection_request)
6340 (x_reply_selection_request): Avoid type-punned deref of X events.
6341
6342 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6343
6344 Fix some uses of `int' instead of EMACS_INT.
6345 * search.c (string_match_1, fast_string_match)
6346 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6347 (scan_buffer, find_next_newline_no_quit)
6348 (find_before_next_newline, search_command, Freplace_match)
6349 (Fmatch_data): Make some `int' variables be EMACS_INT.
6350
6351 * xdisp.c (display_count_lines): 3rd argument and return value now
6352 EMACS_INT. All callers changed.
6353 (pint2hrstr): Last argument is now EMACS_INT.
6354
6355 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6356 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6357 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6358 (decode_coding_utf_16, decode_coding_emacs_mule)
6359 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6360 (decode_coding_ccl, decode_coding_charset)
6361 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6362 (decode_coding_iso_2022, decode_coding_emacs_mule)
6363 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6364 <char_offset, last_offset>: Declare EMACS_INT.
6365 (encode_coding_utf_8, encode_coding_utf_16)
6366 (encode_coding_emacs_mule, encode_invocation_designation)
6367 (encode_designation_at_bol, encode_coding_iso_2022)
6368 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6369 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6370 Declare EMACS_INT.
6371 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6372 (encode_invocation_designation): Last argument P_NCHARS is now
6373 EMACS_INT.
6374 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6375 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6376
6377 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6378 All users changed.
6379
6380 * ccl.c (Fccl_execute_on_string): Declare some variables
6381 EMACS_INT.
6382
6383 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6384
6385 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6386
6387 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6388
6389 * process.c (Fformat_network_address): Doc fix.
6390
6391 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6392
6393 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6394
6395 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6396
6397 * keyboard.c (read_char): Call Lisp function help-form-show,
6398 instead of using internal_with_output_to_temp_buffer.
6399 (Qhelp_form_show): New var.
6400 (syms_of_keyboard): Use DEFSYM macro.
6401
6402 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6403
6404 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6405
6406 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6407
6408 * process.c (Flist_processes): Remove to Lisp.
6409 (list_processes_1): Delete.
6410
6411 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6412
6413 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6414
6415 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6416
6417 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6418
6419 Fix more problems found by GCC 4.6.0's static checks.
6420
6421 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6422
6423 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6424
6425 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6426
6427 * xdisp.c (vmessage): Mark as a printf-like function.
6428
6429 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6430
6431 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6432
6433 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6434 printf-like functions.
6435 (tiff_load): Add casts to remove these marks before passing them
6436 to system-supplied API.
6437
6438 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6439
6440 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6441 This avoids several warnings with gcc -Wstrict-overflow.
6442 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6443 directly, rather than having caller test rule sign. This avoids
6444 some unnecessary tests.
6445 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6446 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6447 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6448
6449 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6450 (xfont_open): Avoid unnecessary tests.
6451
6452 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6453
6454 * composite.h, composite.c (composition_gstring_put_cache):
6455 Use EMACS_INT, not int, for length.
6456
6457 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6458 breaking out part of COMPOSITION_DECODE_RULE.
6459 (COMPOSITION_DECODE_RULE): Use it.
6460 * composite.c (get_composition_id): Remove unused local vars,
6461 by using the new macro.
6462
6463 * textprop.c (set_text_properties_1): Change while to do-while,
6464 since the condition is always true at first.
6465
6466 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6467 (interval_deletion_adjustment): Return unsigned value.
6468 All uses changed.
6469
6470 * process.c (list_processes_1, create_pty, read_process_output):
6471 (exec_sentinel): Remove vars that were set but not used.
6472 (create_pty): Remove unnecessary "volatile"s.
6473 (Fnetwork_interface_info): Avoid possibility of int overflow.
6474 (read_process_output): Do adaptive read buffering even if carryover.
6475 (read_process_output): Simplify nbytes computation if buffered.
6476
6477 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6478
6479 * syntax.c (scan_words): Remove var that was set but not used.
6480 (update_syntax_table): Use unsigned instead of int.
6481
6482 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6483 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6484 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6485
6486 * print.c (print_error_message): Avoid int overflow.
6487
6488 * font.c (font_list_entities): Redo for clarity,
6489 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6490
6491 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6492 (font_score): Avoid potential overflow in diff calculation.
6493
6494 * fns.c (substring_both): Remove var that is set but not used.
6495 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6496
6497 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6498
6499 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6500 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6501 can always succeed if overflow has undefined behavior.
6502
6503 * search.c (boyer_moore, wordify): Remove vars set but not used.
6504 (wordify): Omit three unnecessary tests.
6505
6506 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6507 All callers changed. This avoids the need for an unused var.
6508
6509 * casefiddle.c (casify_region): Remove var that is set but not used.
6510
6511 * dired.c (file_name_completion): Remove var that is set but not used.
6512
6513 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6514
6515 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6516 (Finsert_file_contents): Remove unnecessary code checking fd.
6517
6518 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6519 Check for integer overflow on size calculations.
6520
6521 * buffer.c (Fprevious_overlay_change): Remove var that is set
6522 but not used.
6523
6524 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6525 Remove vars that are set but not used.
6526 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6527 (timer_check_2): Mark vars as initialized.
6528
6529 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6530
6531 * image.c (lookup_image): Remove var that is set but not used.
6532 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6533
6534 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6535 that are set but not used.
6536
6537 * xfns.c (make_invisible_cursor): Don't return garbage
6538 if XCreateBitmapFromData fails (Bug#8410).
6539
6540 * xselect.c (x_get_local_selection, x_handle_property_notify):
6541 Remove vars that are set but not used.
6542
6543 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6544 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6545
6546 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6547 Remove var that is set but not used.
6548 (scroll_bar_windows_size): Now size_t, not int.
6549 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6550 Check for overflow.
6551
6552 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6553 (map_tty_color) [!defined MSDOS]: Likewise.
6554
6555 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6556
6557 * coding.c: Remove vars that are set but not used.
6558 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6559 All callers changed.
6560 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6561 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6562 (decode_coding_charset): Remove vars that are set but not used.
6563
6564 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6565 that is set but not used.
6566
6567 * print.c (print_object): Remove var that is set but not used.
6568
6569 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6570 The gnulib version avoids calling malloc in the usual case,
6571 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6572 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6573 * filelock.c (current_lock_owner): Likewise.
6574 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6575 * sysdep.c: Include allocator.h, careadlinkat.h.
6576 (emacs_no_realloc_allocator): New static constant.
6577 (emacs_readlink): New function.
6578 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6579 ../lib/careadlinkat.h.
6580
6581 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6582
6583 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6584 first non-nil return value).
6585
6586 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6587
6588 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6589 if not defined (Bug#8403).
6590
6591 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6592
6593 * xdisp.c (display_count_lines): Remove parameter `start',
6594 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6595 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6596 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6597 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6598 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6599 and thereabouts. All callers changed.
6600 (get_per_char_metric): Remove parameter `f', unused since
6601 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6602
6603 2011-04-02 Jim Meyering <meyering@redhat.com>
6604
6605 do not dereference NULL upon failed strdup
6606 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6607 (ns_get_family): Likewise.
6608
6609 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6610
6611 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6612
6613 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6614
6615 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6616 later (Bug#8403).
6617
6618 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6619
6620 Add lexical binding.
6621
6622 * window.c (Ftemp_output_buffer_show): New fun.
6623 (Fsave_window_excursion):
6624 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6625
6626 * lread.c (lisp_file_lexically_bound_p): New function.
6627 (Fload): Bind Qlexical_binding.
6628 (readevalloop): Remove `evalfun' arg.
6629 Bind Qinternal_interpreter_environment.
6630 (Feval_buffer): Bind Qlexical_binding.
6631 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6632 Mark as dynamic.
6633 (syms_of_lread): Declare `lexical-binding'.
6634
6635 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6636
6637 * keyboard.c (eval_dyn): New fun.
6638 (menu_item_eval_property): Use it.
6639
6640 * image.c (parse_image_spec): Use Ffunctionp.
6641
6642 * fns.c (concat, mapcar1): Accept byte-code-functions.
6643
6644 * eval.c (Fsetq): Handle lexical vars.
6645 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6646 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6647 (FletX, Flet): Obey lexical binding.
6648 (Fcommandp): Handle closures.
6649 (Feval): New `lexical' arg.
6650 (eval_sub): New function extracted from Feval. Use it almost
6651 everywhere where Feval was used. Look up vars in lexical env.
6652 Handle closures.
6653 (Ffunctionp): Move from subr.el.
6654 (Ffuncall): Handle closures.
6655 (apply_lambda): Remove `eval_flags'.
6656 (funcall_lambda): Handle closures and new byte-code-functions.
6657 (Fspecial_variable_p): New function.
6658 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6659 but without exporting it to Lisp.
6660
6661 * doc.c (Fdocumentation, store_function_docstring):
6662 * data.c (Finteractive_form): Handle closures.
6663
6664 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6665 interactive spec.
6666
6667 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6668 New byte-codes.
6669 (exec_byte_code): New function extracted from Fbyte_code to handle new
6670 calling convention for byte-code-functions. Add new byte-codes.
6671
6672 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6673
6674 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6675
6676 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6677
6678 * xdisp.c (redisplay_internal): Fix prototype.
6679
6680 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6681
6682 * xdisp.c (SCROLL_LIMIT): New macro.
6683 (try_scrolling): Use it when setting scroll_limit.
6684 Limit scrolling to 100 screen lines.
6685 (redisplay_window): Even when falling back on "recentering",
6686 position point in the window according to scroll-conservatively,
6687 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6688
6689 (try_scrolling): When point is above the window, allow searching
6690 as far as scroll_max, or one screenful, to compute vertical
6691 distance from PT to the scroll margin position. This prevents
6692 try_scrolling from unnecessarily failing when
6693 scroll-conservatively is set to a value slightly larger than the
6694 window height. Clean up the case of PT below the margin at bottom
6695 of window: scroll_max can no longer be INT_MAX. When aggressive
6696 scrolling is in use, don't let point enter the opposite scroll
6697 margin as result of the scroll.
6698 (syms_of_xdisp) <scroll-conservatively>: Document the
6699 threshold of 100 lines for never-recentering scrolling.
6700
6701 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6702
6703 * dispextern.h (move_it_by_lines):
6704 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6705 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6706 (message_log_check_duplicate): Remove parameters `prev_bol' and
6707 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6708 (redisplay_internal): Remove parameter `preserve_echo_area',
6709 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6710
6711 * indent.c (Fvertical_motion):
6712 * window.c (window_scroll_pixel_based, Frecenter):
6713 Don't pass `need_y_p' to `move_it_by_lines'.
6714
6715 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6716
6717 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6718 steal a few bits to be more compact.
6719 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6720 Remove unneeded casts.
6721
6722 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6723
6724 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6725
6726 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6727 binding" message (bug#7967).
6728
6729 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6730
6731 Fix more problems found by GCC 4.6.0's static checks.
6732
6733 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6734 Remove unused local var.
6735
6736 * editfns.c (Fmessage_box): Remove unused local var.
6737
6738 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6739 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6740 Omit unused local vars.
6741 * window.c (shrink_windows): Omit unused local var.
6742 * menu.c (digest_single_submenu): Omit unused local var.
6743 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6744 Omit unused local var.
6745
6746 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6747 Don't assume string length fits in int.
6748 (keyremap_step, read_key_sequence): Use size_t for sizes.
6749 (read_key_sequence): Don't check last_real_key_start redundantly.
6750
6751 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6752 instead of alloca (Bug#8344).
6753
6754 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6755 (Fbacktrace_frame): Don't assume nframes fits in int.
6756
6757 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6758
6759 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6760 concerns.
6761
6762 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6763
6764 * cm.c (calccost): Turn while-do into do-while, for clarity.
6765
6766 * keyboard.c (syms_of_keyboard): Use the same style as later
6767 in this function when indexing through an array. This also
6768 works around GCC bug 48267.
6769
6770 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6771
6772 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6773
6774 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6775 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6776
6777 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6778 This avoids undefined behavior on integer overflow, and is a bit
6779 more convenient anyway since it is compared to a size_t variable.
6780
6781 Variadic C functions now count arguments with size_t, not int.
6782 This avoids an unnecessary limitation on 64-bit machines, which
6783 caused (substring ...) to crash on large vectors (Bug#8344).
6784 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6785 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6786 All variadic functions and their callers changed accordingly.
6787 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6788 * data.c (arith_driver, float_arith_driver): Likewise.
6789 * editfns.c (general_insert_function): Likewise.
6790 * eval.c (struct backtrace.nargs, interactive_p)
6791 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6792 (funcall_lambda, mark_backtrace): Likewise.
6793 * fns.c (concat): Likewise.
6794 * frame.c (x_set_frame_parameters): Likewise.
6795 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6796 0 if not found, not -1. All callers changed.
6797
6798 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6799 (stack_copy_size): Now size_t, not int.
6800 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6801
6802 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6803
6804 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6805 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6806 All callers changed.
6807
6808 * lisp.h (multibyte_char_to_unibyte):
6809 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6810 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6811 * character.h (CHAR_TO_BYTE8):
6812 * cmds.c (internal_self_insert):
6813 * editfns.c (general_insert_function):
6814 * keymap.c (push_key_description):
6815 * search.c (Freplace_match):
6816 * xdisp.c (message_dolog, set_message_1): All callers changed.
6817
6818 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6819
6820 * keyboard.c (safe_run_hook_funcall): New function.
6821 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6822 don't set the hook to nil, but remove the offending function instead.
6823 (Qcommand_hook_internal): Remove, unused.
6824 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6825 Vcommand_hook_internal.
6826
6827 * eval.c (enum run_hooks_condition): Remove.
6828 (funcall_nil, funcall_not): New functions.
6829 (run_hook_with_args): Call each function through a `funcall' argument.
6830 Remove `cond' argument, now redundant.
6831 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6832 (Frun_hook_with_args_until_failure): Adjust accordingly.
6833 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6834
6835 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6836
6837 * dispextern.h (string_buffer_position): Remove declaration.
6838
6839 * print.c (strout): Remove parameter `multibyte', unused since
6840 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6841
6842 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6843 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6844 All callers changed.
6845
6846 * w32.c (_wsa_errlist): Use braces for struct initializers.
6847
6848 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6849 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6850 All callers changed.
6851 (string_buffer_position): Likewise. Also, make static (it's never
6852 used outside xdisp.c).
6853 (cursor_row_p): Remove parameter `w', unused since
6854 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6855 (decode_mode_spec): Remove parameter `precision', introduced during
6856 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6857 All callers changed.
6858
6859 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6860
6861 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6862
6863 2011-03-27 Anders Lindgren <andlind@gmail.com>
6864
6865 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6866 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6867 (ns_update_auto_hide_menu_bar): New functions.
6868 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6869 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6870 ns_constrain_all_frames.
6871 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6872 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6873
6874 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6875
6876 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6877
6878 2011-03-27 Glenn Morris <rgm@gnu.org>
6879
6880 * syssignal.h: Replace RETSIGTYPE with void.
6881 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6882 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6883 Replace SIGTYPE with void everywhere.
6884 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6885 * s/template.h (SIGTYPE): Remove commented out definition.
6886
6887 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6888
6889 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6890 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6891
6892 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6893
6894 * w32.c (read_unc_volume): Use parameter `henum', instead of
6895 global variable `wget_enum_handle'.
6896
6897 * keymap.c (describe_vector): Remove parameters `indices' and
6898 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6899 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6900
6901 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6902
6903 * keyboard.c (timer_check): Remove parameter `do_it_now',
6904 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6905 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6906 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6907
6908 * keyboard.c (read_char):
6909 * w32menu.c (w32_menu_display_help):
6910 * xmenu.c (show_help_event, menu_help_callback):
6911 Adjust calls to `show_help_echo'.
6912
6913 * gtkutil.c (xg_maybe_add_timer):
6914 * keyboard.c (readable_events):
6915 * process.c (wait_reading_process_output):
6916 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6917
6918 * insdel.c (adjust_markers_gap_motion):
6919 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6920 (gap_left, gap_right): Don't call it.
6921
6922 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6923
6924 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6925 incurred during fontification.
6926
6927 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6928
6929 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6930 (DEFVAR_PER_BUFFER): Don't pass it.
6931
6932 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6933 (scrolling_window): Don't pass it.
6934
6935 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6936
6937 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6938
6939 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6940 and `suffix'.
6941 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6942 of variables specific to SELinux and computation of `encoded_absname'.
6943
6944 * image.c (XPutPixel): Remove unused variable `height'.
6945
6946 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6947
6948 * unexw32.c (get_section_info): Remove unused variable `section'.
6949
6950 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6951 (system_process_attributes): Remove unused variable `sess'.
6952 (sys_read): Remove unused variable `err'.
6953
6954 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6955 (w32_wnd_proc): Remove unused variable `isdead'.
6956 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6957 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6958 (x_create_tip_frame): Remove unused variable `tem'.
6959
6960 * w32inevt.c (w32_console_read_socket):
6961 Remove unused variable `no_events'.
6962
6963 * w32term.c (x_draw_composite_glyph_string_foreground):
6964 Remove unused variable `width'.
6965
6966 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6967
6968 * w32term.c (x_set_glyph_string_clipping):
6969 Don't pass uninitialized region to CombineRgn.
6970
6971 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6972
6973 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6974 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6975 (Fx_close_connection): Remove unused variable `i'.
6976
6977 * w32font.c (w32font_draw): Return number of glyphs.
6978 (w32font_open_internal): Remove unused variable `i'.
6979 (w32font_driver): Add missing initializer.
6980
6981 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6982 (fill_in_menu): Remove unused variable `items_added'.
6983
6984 * w32term.c (last_mouse_press_frame): Remove static global variable.
6985 (w32_clip_to_row): Remove unused variable `f'.
6986 (x_delete_terminal): Remove unused variable `i'.
6987
6988 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6989 (NOTHING): Remove unused static global variable.
6990 (uniscribe_check_otf): Remove unused variable `table'.
6991 (uniscribe_font_driver): Add missing initializers.
6992
6993 2011-03-23 Julien Danjou <julien@danjou.info>
6994
6995 * term.c (Fsuspend_tty, Fresume_tty):
6996 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6997 * window.c (temp_output_buffer_show):
6998 * insdel.c (signal_before_change):
6999 * frame.c (Fhandle_switch_frame):
7000 * fileio.c (Fdo_auto_save):
7001 * emacs.c (Fkill_emacs):
7002 * editfns.c (save_excursion_restore):
7003 * cmds.c (internal_self_insert):
7004 * callint.c (Fcall_interactively):
7005 * buffer.c (Fkill_all_local_variables):
7006 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7007 Use Frun_hooks.
7008 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7009 unconditionnaly since it does the check itself.
7010
7011 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7012
7013 Fix more problems found by GCC 4.5.2's static checks.
7014
7015 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7016 the first time through the loop, since we know p0 < p1 then.
7017 This also avoids a gcc -Wstrict-overflow warning.
7018
7019 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7020 leading to a memory leak, possible in functions like
7021 load_charset_map_from_file that can allocate an unbounded number
7022 of objects (Bug#8318).
7023
7024 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7025 that could (at least in theory) be that large.
7026
7027 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7028 This is less likely to overflow, and avoids undefined behavior if
7029 overflow does occur. All callers changed. Use strtoul to scan
7030 for the unsigned long integer.
7031 (pint2hrstr): Simplify and tune code slightly.
7032 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7033
7034 * scroll.c (do_scrolling): Work around GCC bug 48228.
7035 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7036
7037 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7038 This also avoids a warning with gcc -Wstrict-overflow.
7039 (validate_x_resource_name): Simplify count usage.
7040 This also avoids a warning with gcc -Wstrict-overflow.
7041
7042 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7043 fail (Bug#8306).
7044
7045 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7046
7047 * process.c (Fmake_network_process): Use socklen_t, not int,
7048 where POSIX says socklen_t is required in portable programs.
7049 This fixes a porting bug on hosts like 64-bit HP-UX, where
7050 socklen_t is wider than int (Bug#8277).
7051 (Fmake_network_process, server_accept_connection):
7052 (wait_reading_process_output, read_process_output):
7053 Likewise.
7054
7055 * process.c: Rename or move locals to avoid shadowing.
7056 (list_processes_1, Fmake_network_process):
7057 (read_process_output_error_handler, exec_sentinel_error_handler):
7058 Rename or move locals.
7059 (Fmake_network_process): Define label "retry_connect" only if needed.
7060 (Fnetwork_interface_info): Fix pointer signedness.
7061 (process_send_signal): Add cast to avoid pointer signedness problem.
7062 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7063 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7064
7065 Make tparam.h and terminfo.c consistent.
7066 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7067 Include tparam.h instead, since it declares them.
7068 * cm.h (PC): Remove extern decl; tparam.h now does this.
7069 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7070 * terminfo.c: Include tparam.h, to check interfaces.
7071 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7072 (tparam): Adjust signature to match interface in tparam.h;
7073 this removes some undefined behavior. Check that outstring and len
7074 are zero, which they always are with Emacs.
7075 * tparam.h (PC, BC, UP): New extern decls.
7076
7077 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7078 (xftfont_open): Rename locals to avoid shadowing.
7079
7080 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7081 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7082 (OTF_TAG_SYM): Omit macro if not needed.
7083 (ftfont_list): Remove unused local.
7084 (get_adstyle_property, ftfont_pattern_entity):
7085 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7086 Rename locals to avoid shadowing.
7087
7088 * xfont.c (xfont_list_family): Mark var as initialized.
7089
7090 * xml.c (make_dom): Now static.
7091
7092 * composite.c (composition_compute_stop_pos): Rename local to
7093 avoid shadowing.
7094 (composition_reseat_it): Remove unused locals.
7095 (find_automatic_composition, composition_adjust_point): Likewise.
7096 (composition_update_it): Mark var as initialized.
7097 (find_automatic_composition): Mark vars as initialized,
7098 with a FIXME (Bug#8290).
7099
7100 character.h: Rename locals to avoid shadowing.
7101 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7102 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7103 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7104 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7105 to avoid shadowing.
7106
7107 * textprop.c (property_change_between_p): Remove; unused.
7108
7109 * intervals.c (interval_start_pos): Now static.
7110
7111 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7112
7113 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7114 Rename locals to avoid shadowing.
7115
7116 * sound.c (wav_play, au_play, Fplay_sound_internal):
7117 Fix pointer signedness.
7118 (alsa_choose_format): Remove unused local var.
7119 (wav_play): Initialize a variable to 0, to prevent undefined
7120 behavior (Bug#8278).
7121
7122 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7123
7124 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7125
7126 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7127 clobbering (Bug#8298).
7128 * sysdep.c (sys_subshell): Likewise.
7129 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7130
7131 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7132 This should get cleaned up, so that child_setup has the
7133 same signature on all platforms.
7134
7135 * callproc.c (call_process_cleanup): Now static.
7136 (relocate_fd): Rename locals to avoid shadowing.
7137
7138 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7139
7140 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7141 not to be necessary, and produces flickering.
7142
7143 2011-03-20 Glenn Morris <rgm@gnu.org>
7144
7145 * config.in: Remove file.
7146
7147 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7148
7149 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7150 are now in src/globals.h.
7151 (syms_of_minibuf): Remove spurious & from previous change.
7152
7153 2011-03-20 Leo <sdl.web@gmail.com>
7154
7155 * minibuf.c (completing-read-function): New variable.
7156 (completing-read-default): Rename from completing-read.
7157 (completing-read): Call completing-read-function.
7158
7159 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7160
7161 * xfaces.c (Fx_load_color_file):
7162 Read color file from absolute filename (bug#8250).
7163
7164 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7165
7166 * makefile.w32-in: Update dependencies.
7167
7168 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7169
7170 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7171
7172 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7173
7174 Fix more problems found by GCC 4.5.2's static checks.
7175
7176 * process.c (make_serial_process_unwind, send_process_trap):
7177 (sigchld_handler): Now static.
7178
7179 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7180 That way, the code declares only the vars that it needs.
7181 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7182 * s/cygwin.h (PTY_ITERATION): Likewise.
7183 * s/darwin.h (PTY_ITERATION): Likewise.
7184 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7185
7186 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7187 * process.c (allocate_pty): Don't declare stb unless it's needed.
7188
7189 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7190 (CONSTANTLIM): Remove; unused.
7191 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7192 Define only if needed.
7193
7194 * unexelf.c (unexec): Name an expression,
7195 to avoid gcc -Wbad-function-cast warning.
7196 Use a different way to cause a compilation error if anyone uses
7197 n rather than nn, a way that does not involve shadowing.
7198 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7199
7200 * deps.mk (unexalpha.o): Remove; unused.
7201
7202 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7203 * unexec.h: New file.
7204 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7205 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7206 Depend on unexec.h.
7207 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7208 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7209 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7210 Change as necessary to match prototype in unexec.h.
7211
7212 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7213 shadowing.
7214 (back_comment, skip_chars): Mark vars as initialized.
7215
7216 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7217 Rename locals to avoid shadowing.
7218
7219 * lread.c (read1): Rewrite so as not to use empty "else".
7220 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7221
7222 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7223
7224 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7225 warning when compiling print.c.
7226
7227 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7228 instead of using an uninitialized var.
7229 (font_sort_entities): Mark var as initialized.
7230
7231 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7232
7233 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7234 pointers to constants.
7235 (font_parse_fcname): Remove unused vars.
7236 (font_delete_unmatched): Now static.
7237 (font_get_spec): Remove; unused.
7238 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7239 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7240 Rename or move locals to avoid shadowing.
7241
7242 * fns.c (require_nesting_list, require_unwind): Now static.
7243 (Ffillarray): Rename locals to avoid shadowing.
7244
7245 * floatfns.c (domain_error2): Define only if needed.
7246 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7247
7248 * alloc.c (mark_backtrace): Move decl from here ...
7249 * lisp.h: ... to here, so that it can be checked.
7250
7251 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7252 (Fdefvar): Rewrite so as not to use empty "else".
7253 (lisp_indirect_variable): Name an expression,
7254 to avoid gcc -Wbad-function-cast warning.
7255 (Fdefvar): Rename locals to avoid shadowing.
7256
7257 * callint.c (quotify_arg, quotify_args): Now static.
7258 (Fcall_interactively): Rename locals to avoid shadowing.
7259 Use const pointer when appropriate.
7260
7261 * lisp.h (get_system_name, get_operating_system_release):
7262 Move decls here, to check interfaces.
7263 * process.c (get_operating_system_release): Move decl to lisp.h.
7264 * xrdb.c (get_system_name): Likewise.
7265 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7266 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7267 some of which prompt warnings from gcc -Wbad-function-cast.
7268 (Fformat_time_string, Fencode_time, Finsert_char):
7269 (Ftranslate_region_internal, Fformat):
7270 Rename or remove local vars to avoid shadowing.
7271 (Ftranslate_region_internal): Mark var as initialized.
7272
7273 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7274 avoid shadowing.
7275
7276 * lisp.h (eassert): Check that the argument compiles, even if
7277 ENABLE_CHECKING is not defined.
7278
7279 * data.c (Findirect_variable): Name an expression, to avoid
7280 gcc -Wbad-function-cast warning.
7281 (default_value, arithcompare, arith_driver, arith_error): Now static.
7282 (store_symval_forwarding): Rename local to avoid shadowing.
7283 (Fmake_variable_buffer_local, Fmake_local_variable):
7284 Mark variables as initialized.
7285 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7286
7287 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7288 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7289 Rename locals to avoid shadowing.
7290 (mark_stack): Move local variables into the #ifdef region where
7291 they're used.
7292 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7293 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7294 needed otherwise.
7295 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7296 (GC_STRING_CHARS): Remove; not used.
7297 (Fmemory_limit): Cast sbrk's returned value to char *.
7298
7299 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7300 avoids undefined behavior in theory.
7301
7302 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7303
7304 Use functions, not macros, for up- and down-casing (Bug#8254).
7305 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7306 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7307 to use the following functions instead of these macros.
7308 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7309 EMACS_INT, since callers assume the returned value fits in int.
7310 (upcase1): Likewise, for UPCASE_TABLE.
7311 (uppercasep, lowercasep, upcase): New static inline functions.
7312 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7313 the race-condition problem in the old DOWNCASE.
7314
7315 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7316 Rename locals to avoid shadowing.
7317 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7318 (regex_compile, re_search_2, re_match_2_internal):
7319 Remove unused local vars.
7320 (FREE_VAR): Rewrite so as not to use empty "else",
7321 which gcc can warn about.
7322 (regex_compile, re_match_2_internal): Mark locals as initialized.
7323 (RETALLOC_IF): Define only if needed.
7324 (WORDCHAR_P): Likewise. This one is never needed, but is used
7325 only in a comment talking about a compiler bug, so put inside
7326 the #if 0 of that comment.
7327 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7328 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7329 Remove; unused.
7330
7331 * search.c (boyer_moore): Rename locals to avoid shadowing.
7332 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7333 (PREV_CHAR_BOUNDARY): Likewise.
7334
7335 * search.c (simple_search): Remove unused var.
7336
7337 * dired.c (compile_pattern): Move decl from here ...
7338 * lisp.h: ... to here, so that it can be checked.
7339 (struct re_registers): New forward decl.
7340
7341 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7342
7343 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7344 All uses changed.
7345 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7346 Rename locals to avoid shadowing.
7347 (Fvertical_motion): Mark locals as initialized.
7348
7349 * casefiddle.c (casify_object, casify_region): Now static.
7350 (casify_region): Mark local as initialized.
7351
7352 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7353
7354 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7355 New macros, so that the caller can use some names other than
7356 gcpro1, gcpro2, etc.
7357 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7358 of the new macros.
7359 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7360 argument, for consistency with GCPRO2_VAR, etc: it is now the
7361 prefix of the variable, not the variable itself. All uses
7362 changed.
7363 * dired.c (directory_files_internal, file_name_completion):
7364 Rename locals to avoid shadowing.
7365
7366 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7367 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7368 dired.c's scmp function, had undefined behavior.
7369 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7370 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7371 * buffer.h: ... to here, because these macros use current_buffer,
7372 and the new implementation with inline functions needs to have
7373 current_buffer in scope now, rather than later when the macros
7374 are used.
7375 (downcase, upcase1): New static inline functions.
7376 (DOWNCASE, UPCASE1): Reimplement using these functions.
7377 This avoids undefined behavior in expressions like
7378 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7379 from race conditions in accessing the global variables
7380 case_temp1 and case_temp2.
7381 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7382 * lisp.h (case_temp1, case_temp2): Remove their decls.
7383 * character.h (ASCII_CHAR_P): Move from here ...
7384 * lisp.h: ... to here, so that the inline functions mentioned
7385 above can use them.
7386
7387 * dired.c (directory_files_internal_unwind): Now static.
7388
7389 * fileio.c (file_name_as_directory, directory_file_name):
7390 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7391 Now static.
7392 (file_name_as_directory): Use const pointers when appropriate.
7393 (Fexpand_file_name): Likewise. In particular, newdir might
7394 point at constant storage, so make it a const pointer.
7395 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7396 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7397 signedness issues.
7398 (Fset_file_times, Finsert_file_contents, auto_save_error):
7399 Rename locals to avoid shadowing.
7400
7401 * minibuf.c (choose_minibuf_frame_1): Now static.
7402 (Ftry_completion, Fall_completions): Rename or remove locals
7403 to avoid shadowing.
7404
7405 * marker.c (bytepos_to_charpos): Remove; unused.
7406
7407 * lisp.h (verify_bytepos, count_markers): New decls,
7408 so that gcc does not warn that these functions aren't declared.
7409
7410 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7411 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7412 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7413 (copy_text): Remove unused local var.
7414
7415 * filelock.c (within_one_second): Now static.
7416 (lock_file_1): Rename local to avoid shadowing.
7417
7418 * buffer.c (fix_overlays_before): Mark locals as initialized.
7419 (fix_start_end_in_overlays): Likewise. This function should be
7420 simplified by using pointers-to-pointers, but that's a different
7421 matter.
7422 (switch_to_buffer_1): Now static.
7423 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7424 (report_overlay_modification): Rename locals to avoid shadowing.
7425
7426 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7427 Fix pointer signedness issue.
7428 (sys_subshell): Mark local as volatile if checking for lint,
7429 to suppress a gcc -Wclobbered warning that does not seem to be right.
7430 (MAXPATHLEN): Define only if needed.
7431
7432 * process.c (serial_open, serial_configure): Move decls from here ...
7433 * systty.h: ... to here, so that they can be checked.
7434
7435 * fns.c (get_random, seed_random): Move extern decls from here ...
7436 * lisp.h: ... to here, so that they can be checked.
7437
7438 * sysdep.c (reset_io): Now static.
7439 (wait_for_termination_signal): Remove; unused.
7440
7441 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7442 (copy_keymap_item, append_key, push_text_char_description):
7443 Now static.
7444 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7445 (DENSE_TABLE_SIZE): Remove; unused.
7446 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7447 (describe_map_tree):
7448 Rename locals to avoid shadowing.
7449
7450 * keyboard.c: Declare functions static if they are not used elsewhere.
7451 (echo_char, echo_dash, cmd_error, top_level_2):
7452 (poll_for_input, handle_async_input): Now static.
7453 (read_char, kbd_buffer_get_event, make_lispy_position):
7454 (make_lispy_event, make_lispy_movement, apply_modifiers):
7455 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7456 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7457 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7458 (read_key_sequence, read_char): Mark locals as initialized.
7459 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7460
7461 * keyboard.h (make_ctrl_char): New decl.
7462 (mark_kboards): Move decl here ...
7463 * alloc.c (mark_kboards): ... from here.
7464
7465 * lisp.h (force_auto_save_soon): New decl.
7466
7467 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7468 (DEFINE_DUMMY_FUNCTION): New macro.
7469 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7470 Use it.
7471 (main): Add casts to avoid warnings
7472 if GCC considers string literals to be constants.
7473
7474 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7475
7476 * dbusbind.c: Pointer signedness fixes.
7477 (xd_signature, xd_append_arg, xd_initialize):
7478 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7479 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7480 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7481 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7482
7483 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7484 if GCC considers string literals to be constants.
7485 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7486
7487 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7488
7489 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7490 (print_preprocess, print_object): New macro to fix last change.
7491
7492 * print.c (print_preprocess): Don't forget font objects.
7493
7494 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7495
7496 * emacs.c (USAGE3): Doc fixes.
7497
7498 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7499
7500 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7501 structure.
7502
7503 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7504
7505 * lisp.h (VWindow_system, Qfile_name_history):
7506 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7507 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7508 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7509
7510 * w32select.c: Don't #include "keyboard.h".
7511 (run_protected): Add extern declaration for waiting_for_input.
7512
7513 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7514 * w32console.c (detect_input_pending, read_input_pending)
7515 (encode_terminal_code):
7516 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7517 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7518 (w32_system_caret_y, Qfile_name_history):
7519 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7520 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7521 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7522 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7523 * w32proc.c (Qlocal, report_file_error):
7524 * w32term.c (Vwindow_system, updating_frame):
7525 * w32uniscribe.c (initialized, uniscribe_font_driver):
7526 Remove unneeded extern declarations.
7527
7528 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7529
7530 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7531
7532 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7533
7534 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7535 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7536 These macros can no longer be used for assignment.
7537
7538 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7539 Assign struct members directly, instead of using BUF_BEGV etc.
7540 (record_buffer_markers, fetch_buffer_markers): New functions for
7541 recording and fetching special buffer markers.
7542 (set_buffer_internal_1, set_buffer_temp): Use them.
7543
7544 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7545
7546 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7547
7548 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7549 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7550
7551 * xdisp.c (hscroll_window_tree):
7552 (reconsider_clip_changes): Use PT instead of BUF_PT.
7553
7554 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7555
7556 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7557 $(EMACS_ROOT)/lib/intprops.h.
7558
7559 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7560
7561 Fix more problems found by GCC 4.5.2's static checks.
7562
7563 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7564 to unsigned char * to avoid compiler diagnostic.
7565 (xg_free_frame_widgets): Make it clear that a local variable is
7566 needed only if USE_GTK_TOOLTIP.
7567 (gdk_window_get_screen): Make it clear that this macro is needed
7568 only if USE_GTK_TOOLTIP.
7569 (int_gtk_range_get_value): New function, which avoids a diagnostic
7570 from gcc -Wbad-function-cast.
7571 (xg_set_toolkit_scroll_bar_thumb): Use it.
7572 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7573 diagnostic from gcc -Wbad-function-cast.
7574 (get_utf8_string, xg_get_file_with_chooser):
7575 Rename locals to avoid shadowing.
7576 (create_dialog): Move locals to avoid shadowing.
7577
7578 * xgselect.c (xg_select): Remove unused var.
7579
7580 * image.c (four_corners_best): Mark locals as initialized.
7581 (gif_load): Initialize transparent_p to zero (Bug#8238).
7582 Mark another local as initialized.
7583 (my_png_error, my_error_exit): Mark with NO_RETURN.
7584
7585 * image.c (clear_image_cache): Now static.
7586 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7587 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7588 (x_edge_detection): Remove unnecessary cast that
7589 gcc -Wbad-function-cast diagnoses.
7590 (gif_load): Fix pointer signedness.
7591 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7592 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7593
7594 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7595
7596 Improve quality of tests for time stamp overflow.
7597 For example, without this patch (encode-time 0 0 0 1 1
7598 1152921504606846976) returns the obviously-bogus value (-948597
7599 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7600 reports time overflow. See
7601 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7602 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7603 * editfns.c: Include limits.h and intprops.h.
7604 (TIME_T_MIN, TIME_T_MAX): New macros.
7605 (time_overflow): Move earlier, to before first use.
7606 (hi_time, lo_time): New functions, for an accurate test for
7607 out-of-range times.
7608 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7609 (Fget_internal_run_time): Don't assume time_t fits in int.
7610 (make_time): Use list2 instead of Fcons twice.
7611 (Fdecode_time): More accurate test for out-of-range times.
7612 (check_tm_member): New function.
7613 (Fencode_time): Use it, to test for out-of-range times.
7614 (lisp_time_argument): Don't rely on undefined left-shift and
7615 right-shift behavior when checking for time stamp overflow.
7616
7617 * editfns.c (time_overflow): New function, refactoring common code.
7618 (Fformat_time_string, Fdecode_time, Fencode_time):
7619 (Fcurrent_time_string): Use it.
7620
7621 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7622 * dired.c (make_time): Move to ...
7623 * editfns.c (make_time): ... here.
7624 * systime.h: Note the move.
7625
7626 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7627
7628 * fringe.c (update_window_fringes): Remove unused variables.
7629
7630 * unexmacosx.c (copy_data_segment): Also copy __got section.
7631 (Bug#8223)
7632
7633 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7634
7635 * termcap.c [MSDOS]: Include "msdos.h".
7636 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7637 Constify `char *' arguments and their references according to
7638 prototypes in tparam.h.
7639
7640 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7641
7642 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7643 Adapt all references accordingly.
7644
7645 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7646
7647 2011-03-11 Tom Tromey <tromey@redhat.com>
7648
7649 * buffer.c (syms_of_buffer): Remove obsolete comment.
7650
7651 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7652
7653 * termhooks.h (encode_terminal_code): Declare prototype.
7654
7655 * msdos.c (encode_terminal_code): Don't declare prototype.
7656
7657 * term.c (encode_terminal_code): Now external again, used by
7658 w32console.c and msdos.c.
7659
7660 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7661 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7662
7663 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7664
7665 Fix some minor problems found by GCC 4.5.2's static checks.
7666
7667 * fringe.c (update_window_fringes): Mark locals as initialized
7668 (Bug#8227).
7669 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7670
7671 * alloc.c (mark_fringe_data): Move decl from here ...
7672 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7673 to check its interface.
7674 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7675
7676 * fontset.c (free_realized_fontset): Now static.
7677 (Fset_fontset_font): Rename local to avoid shadowing.
7678 (fontset_font): Mark local as initialized.
7679 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7680
7681 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7682
7683 * xselect.c (x_disown_buffer_selections): Remove; not used.
7684 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7685 (x_own_selection, Fx_disown_selection_internal): Rename locals
7686 to avoid shadowing.
7687 (x_handle_dnd_message): Remove local to avoid shadowing.
7688
7689 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7690 so that the caller can use some name other than gcpro1.
7691 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7692 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7693 (Fx_backspace_delete_keys_p):
7694 Use them to avoid shadowing, and rename vars to avoid shadowing.
7695 (x_decode_color, x_set_name, x_window): Now static.
7696 (Fx_create_frame): Add braces to silence GCC warning.
7697 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7698 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7699 Remove unused locals.
7700 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7701 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7702 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7703 macros.
7704
7705 * xterm.h (x_mouse_leave): New decl.
7706
7707 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7708 Remove unused functions.
7709 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7710 (x_calc_absolute_position): Now static.
7711 (XTread_socket): Don't define label "out" unless it's used.
7712 Don't declare local "event" unless it's used.
7713 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7714 unless they are used.
7715 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7716 (x_fatal_error_signal): Remove; not used.
7717 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7718 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7719 (x_error_catcher, x_connection_closed, x_error_handler):
7720 (x_error_quitter, xembed_send_message, x_iconify_frame):
7721 (my_log_handler): Rename locals to avoid shadowing.
7722 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7723 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7724
7725 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7726 Rename or move locals to avoid shadowing.
7727 (tty_defined_color, merge_face_heights): Now static.
7728 (free_realized_faces_for_fontset): Remove; not used.
7729 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7730 does not deduce is never used uninitialized.
7731 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7732 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7733
7734 * terminal.c (store_terminal_param): Now static.
7735
7736 * xmenu.c (menu_highlight_callback): Now static.
7737 (set_frame_menubar): Remove unused local.
7738 (xmenu_show): Rename parameter to avoid shadowing.
7739 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7740 since they might point to immutable storage.
7741 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7742 since it's unused otherwise.
7743
7744 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7745 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7746 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7747 avoids a gcc -Wuninitialized diagnostic.
7748 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7749 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7750 does not deduce are never used uninitialized.
7751
7752 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7753
7754 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7755 * window.c (window_loop, size_window):
7756 (run_window_configuration_change_hook, enlarge_window): Likewise.
7757
7758 * window.c (display_buffer): Now static.
7759 (size_window): Mark variables that gcc -Wuninitialized
7760 does not deduce are never used uninitialized.
7761 * window.h (check_all_windows): New decl, to forestall
7762 gcc -Wmissing-prototypes diagnostic.
7763 * dispextern.h (bidi_dump_cached_states): Likewise.
7764
7765 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7766 shadowing.
7767 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7768 Include <limits.h>.
7769 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7770 and to avoid gcc -Wuninitialized warning.
7771 (load_charset_map): Mark variables that gcc -Wuninitialized
7772 does not deduce are never used uninitialized.
7773 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7774
7775 * coding.c (coding_set_source, coding_set_destination):
7776 Use "else { /* comment */ }" rather than "else /* comment */;"
7777 for clarity, and to avoid gcc -Wempty-body warning.
7778 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7779 a block, when the outer 'i' will do.
7780 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7781 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7782 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7783 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7784 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7785 Rename locals to avoid shadowing.
7786 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7787 * coding.c (emacs_mule_char, encode_invocation_designation):
7788 Now static, since they're not used elsewhere.
7789 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7790 (decode_coding_object, encode_coding_object, detect_coding_system):
7791 (decode_coding_emacs_mule): Mark variables that gcc
7792 -Wuninitialized does not deduce are never used uninitialized.
7793 (detect_coding_iso_2022): Initialize a local variable that might
7794 be used uninitialized. Leave a FIXME because it's not clear that
7795 this initialization is needed. (Bug#8211)
7796 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7797 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7798 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7799 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7800 Remove unused macros.
7801
7802 * category.c (hash_get_category_set): Remove unused local var.
7803 (copy_category_table): Now static, since it's not used elsewhere.
7804 * character.c (string_count_byte8): Likewise.
7805
7806 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7807 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7808
7809 * chartab.c (copy_sub_char_table): Now static, since it's not used
7810 elsewhere.
7811 (sub_char_table_ref_and_range, char_table_ref_and_range):
7812 Rename locals to avoid shadowing.
7813 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7814
7815 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7816 (BIDI_BOB): Remove unused macro.
7817
7818 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7819 deduce are never used uninitialized.
7820 * term.c (encode_terminal_code): Likewise.
7821
7822 * term.c (encode_terminal_code): Now static. Remove unused local.
7823
7824 * tparam.h: New file.
7825 * term.c, tparam.h: Include it.
7826 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7827 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7828 Move these decls to tparam.h, and make them agree with what
7829 is actually in tparam.c. The previous trick of using incompatible
7830 decls in different modules does not conform to the C standard.
7831 All callers of tparam changed to use tparam's actual API.
7832 * tparam.c (tparam1, tparam, tgoto):
7833 Use const pointers where appropriate.
7834
7835 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7836 * cm.h (struct cm): Likewise.
7837 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7838 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7839 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7840 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7841 (turn_on_face, init_tty): Likewise.
7842 * termchar.h (struct tty_display_info): Likewise.
7843
7844 * term.c (term_mouse_position): Rename local to avoid shadowing.
7845
7846 * alloc.c (mark_ttys): Move decl from here ...
7847 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7848
7849 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7850
7851 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7852
7853 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7854
7855 * search.c (compile_pattern_1): Remove argument regp, unused since
7856 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7857 (compile_pattern): Don't pass it.
7858
7859 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7860
7861 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7862 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7863 for ! HAVE_GTK3.
7864 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7865
7866 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7867
7868 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7869 gdk_window_get_screen, gdk_window_get_geometry,
7870 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7871 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7872 (xg_get_pixbuf_from_pixmap): New function.
7873 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7874 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7875 Call xg_get_pixbuf_from_pixmap instead of
7876 gdk_pixbuf_get_from_drawable.
7877 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7878 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7879 (xg_check_special_colors): Use GtkStyleContext and its functions
7880 for HAVE_GTK3.
7881 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7882 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7883 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7884 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7885 Call gtk_widget_get_preferred_size.
7886 (xg_frame_resized): gdk_window_get_geometry only takes 5
7887 parameters.
7888 (xg_win_to_widget, xg_event_is_for_menubar):
7889 Call gdk_x11_window_lookup_for_display.
7890 (xg_set_widget_bg): New function.
7891 (delete_cb): New function.
7892 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7893 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7894 (xg_set_background_color): Call xg_set_widget_bg.
7895 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7896 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7897 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7898 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7899 if ! HAVE_GTK3.
7900 (update_frame_tool_bar): Call gtk_widget_hide.
7901 (xg_initialize): Use GDK_KEY_g.
7902
7903 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7904 if ! HAVE_GTK3
7905 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7906
7907 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7908 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7909 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7910
7911 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7912
7913 * w32xfns.c (select_palette): Check success of RealizePalette against
7914 GDI_ERROR, not zero.
7915
7916 See ChangeLog.11 for earlier changes.
7917
7918 ;; Local Variables:
7919 ;; coding: utf-8
7920 ;; End:
7921
7922 Copyright (C) 2011 Free Software Foundation, Inc.
7923
7924 This file is part of GNU Emacs.
7925
7926 GNU Emacs is free software: you can redistribute it and/or modify
7927 it under the terms of the GNU General Public License as published by
7928 the Free Software Foundation, either version 3 of the License, or
7929 (at your option) any later version.
7930
7931 GNU Emacs is distributed in the hope that it will be useful,
7932 but WITHOUT ANY WARRANTY; without even the implied warranty of
7933 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7934 GNU General Public License for more details.
7935
7936 You should have received a copy of the GNU General Public License
7937 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.