Fix bug #9254 with crash and cursor positioning under longlines-mode.
[bpt/emacs.git] / src / ChangeLog
1 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4 display property strides EOL and includes a newline, as in
5 longlines-mode. (Bug#9254)
6
7 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8 is non-zero, even if the data buffer is NULL. Fixes a crash in
9 vertical-motion with longlines-mode. (Bug#9254)
10
11 2011-08-05 Eli Zaretskii <eliz@gnu.org>
12
13 * bidi.c <bidi_cache_total_alloc>: Now static.
14 (bidi_initialize): Initialize bidi_cache_total_alloc.
15
16 *xdisp.c (display_line): Release buffer allocated for shelved bidi
17 cache. (Bug#9221)
18
19 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
20 amount allocated this far in `bidi_cache_total_alloc'.
21 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
22 non-zero, only free the data buffer without restoring the cache
23 contents. All callers changed.
24
25 * dispextern.h (bidi_unshelve_cache): Update prototype.
26
27 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
28 (move_it_in_display_line, move_it_to)
29 (move_it_vertically_backward, move_it_by_lines): Replace the call
30 to xfree to an equivalent call to bidi_unshelve_cache.
31 (move_it_in_display_line_to): Fix logic of returning
32 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
33
34 2011-08-05 Eli Zaretskii <eliz@gnu.org>
35
36 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
37 came from a string character with a `cursor' property. (Bug#9229)
38
39 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
40
41 * Makefile.in (LIB_PTHREAD): New variable.
42 (LIBES): Add LIB_PTHREAD (Bug#9216).
43
44 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
45 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
46
47 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
48
49 * regex.c (re_iswctype): Remove some redundant boolean
50 conversions.
51
52 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
53
54 * xterm.c (x_find_topmost_parent): New function.
55 (x_set_frame_alpha): Find topmost parent window with
56 x_find_topmost_parent and set the property there also (bug#9181).
57 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
58
59 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
60
61 * callproc.c (Fcall_process): Avoid vfork clobbering
62 the local vars buffer, coding_systems, current_dir.
63
64 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
65
66 * keymap.c (Fmake_composed_keymap): Move to subr.el.
67
68 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
69
70 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
71 so that it is not optimized away.
72
73 * xdisp.c (compute_display_string_pos): Remove unused local.
74
75 2011-08-02 Eli Zaretskii <eliz@gnu.org>
76
77 Fix slow cursor motion and scrolling in large buffers with
78 selective display, like Org Mode buffers. (Bug#9218)
79
80 * dispextern.h (struct bidi_it): New member disp_prop_p.
81
82 * xdisp.c: Remove one-slot cache of display string positions.
83 (compute_display_string_pos): Accept an additional argument
84 DISP_PROP_P; callers changed. Scan at most 5K characters forward
85 for a display string or property. If found, set DISP_PROP_P
86 non-zero.
87
88 * bidi.c (bidi_fetch_char): Accept an additional argument
89 DISP_PROP_P, and pass it to compute_display_string_pos.
90 Only handle text covered by a display string if DISP_PROP_P is returned
91 non-zero. All callers of bidi_fetch_char changed.
92
93 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
94
95 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
96
97 2010-12-03 Don March <don@ohspite.net>
98
99 * keymap.c (Fdefine_key): Fix non-prefix key error message when
100 last character M-[char] is translated to ESC [char] (bug#7541).
101
102 2011-08-02 Kenichi Handa <handa@m17n.org>
103
104 * lisp.h (uniprop_table): Extern it.
105
106 * chartab.c (uniprop_table): Make it non-static.
107
108 2011-08-01 Eli Zaretskii <eliz@gnu.org>
109
110 * xdisp.c (forward_to_next_line_start): Accept additional argument
111 BIDI_IT_PREV, and store into it the state of the bidi iterator had
112 on the newline.
113 (reseat_at_next_visible_line_start): Use the bidi iterator state
114 returned by forward_to_next_line_start to restore the state of
115 it->bidi_it after backing up to previous newline. (Bug#9212)
116
117 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
118
119 * regex.c (re_comp): Protoize.
120 (re_exec): Fix return type.
121 (regexec): Fix type of `ret'. (Bug#9203)
122
123 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
124
125 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
126 This is needed if max-image-size is a floating-point number.
127
128 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
129
130 * print.c (print_object): Print empty symbol as ##.
131
132 * lread.c (read1): Read ## as empty symbol.
133
134 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
135
136 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
137 setting frame foreground color (Bug#9175).
138 (x_set_background_color): Likewise.
139
140 * nsmenu.m (-setText): Size tooltip dimensions precisely to
141 contents (Bug#9176).
142 (EmacsTooltip -init): Remove bezels and add shadows to
143 tooltip windows.
144
145 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
146 or scroll bar (Bug#8470).
147
148 * nsfont.m (nsfont_open): Remove assignment to voffset and
149 unnecessary vars hshink, expand, hd, full_height, min_height.
150 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
151
152 * nsterm.h (nsfont_info): Remove voffset field.
153
154 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
155
156 Implement strike-through and overline on NextStep (Bug#8863).
157
158 * nsfont.m (nsfont_open): Use underline position provided by font,
159 instead of hard-coded value of 2.
160 (nsfont_draw): Call ns_draw_text_decoration instead.
161
162 * nsterm.h: Add declaration for ns_draw_text_decoration.
163
164 * nsterm.m (ns_draw_text_decoration): New function for drawing
165 underline, overline, and strike-through.
166 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
167 ns_draw_text_decoration. Change treatment of cursor drawing to
168 accomodate underlining, etc.
169
170 2011-07-28 Eli Zaretskii <eliz@gnu.org>
171
172 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
173 default.
174
175 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
176
177 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
178 Without this fix, if a signal arrives just after memory fills up,
179 'malloc' might be invoked reentrantly.
180
181 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
182 In other words, assume that every image size is allowed, on non-X
183 hosts. This assumption is probably wrong, but it lets Emacs compile.
184
185 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
186
187 * regex.c (re_iswctype): Convert return values to boolean.
188
189 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
190
191 * xdisp.c (compute_display_string_pos): Don't use cached display
192 string position if the buffer had its restriction changed.
193 (Bug#9184)
194
195 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
196
197 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
198
199 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
200
201 Integer signedness and overflow and related fixes. (Bug#9079)
202
203 * bidi.c: Integer size and overflow fixes.
204 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
205 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
206 (bidi_cache_find_level_change, bidi_cache_ensure_space)
207 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
208 (bidi_find_other_level_edge):
209 Use ptrdiff_t instead of EMACS_INT where either will do.
210 This works better on 32-bit hosts configured --with-wide-int.
211 (bidi_cache_ensure_space): Check for size-calculation overflow.
212 Use % rather than repeated addition, for better worst-case speed.
213 Don't set bidi_cache_size until after xrealloc returns, because it
214 might not return.
215 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
216 (bidi_cache_ensure_space): Also check that the bidi cache size
217 does not exceed that of the largest Lisp string or buffer. See Eli
218 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
219
220 * alloc.c (__malloc_size_t): Remove.
221 All uses replaced by size_t. See Andreas Schwab's note
222 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
223
224 * image.c: Improve checking for integer overflow.
225 (check_image_size): Assume that f is nonnull, since
226 it is always nonnull in practice. This is one less thing to
227 worry about when checking for integer overflow later.
228 (x_check_image_size): New function, which checks for integer
229 overflow issues inside X.
230 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
231 This removes the need for a memory_full check.
232 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
233 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
234 (xbm_read_bitmap_data): Change locals back to 'int', since
235 their values must fit in 'int'.
236 (xpm_load_image, png_load, tiff_load):
237 Invoke x_create_x_image_and_pixmap earlier,
238 to avoid much needless work if the image is too large.
239 (tiff_load): Treat overly large images as if
240 x_create_x_image_and_pixmap failed, not as malloc failures.
241 (gs_load): Use x_check_image_size.
242
243 * gtkutil.c: Omit integer casts.
244 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
245 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
246
247 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
248
249 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
250 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
251 would wrongly return t on a 64-bit host.
252
253 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
254 The plain *_OVERFLOW macros run afoul of GCC bug 49705
255 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
256 and therefore cause GCC to emit a bogus diagnostic in some cases.
257
258 * image.c: Integer signedness and overflow and related fixes.
259 This is not an exhaustive set of fixes, but it's time to
260 record what I've got.
261 (lookup_pixel_color, check_image_size): Remove redundant decls.
262 (check_image_size): Don't assume that arbitrary EMACS_INT values
263 fit in 'int', or that arbitrary 'double' values fit in 'int'.
264 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
265 (tiff_load, imagemagick_load_image):
266 Check for overflow in size calculations.
267 (x_create_x_image_and_pixmap): Remove unnecessary test for
268 xmalloc returning NULL; that can't happen.
269 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
270 (xpm_color_bucket): Use better integer hashing function.
271 (xpm_cache_color): Don't possibly over-allocate memory.
272 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
273 (gif_memory_source):
274 Use ptrdiff_t, not int or size_t, to record sizes.
275 (png_load): Don't assume values greater than 2**31 fit in 'int'.
276 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
277 either works, as we prefer signed integers.
278 (tiff_read_from_memory, tiff_write_from_memory):
279 Return tsize_t, not size_t, since that's what the TIFF API wants.
280 (tiff_read_from_memory): Don't fail simply because the read would
281 go past EOF; instead, return a short read.
282 (tiff_load): Omit no-longer-needed casts.
283 (Fimagemagick_types): Don't assume size fits into 'int'.
284
285 Improve hashing quality when configured --with-wide-int.
286 * fns.c (hash_string): New function, taken from sxhash_string.
287 Do not discard information about ASCII character case; this
288 discarding is no longer needed.
289 (sxhash-string): Use it. Change sig to match it. Caller changed.
290 * lisp.h: Declare it.
291 * lread.c (hash_string): Remove, since we now use fns.c's version.
292 The fns.c version returns a wider integer if --with-wide-int is
293 specified, so this should help the quality of the hashing a bit.
294
295 * emacs.c: Integer overflow minor fix.
296 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
297 Define only if GNU_LINUX.
298 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
299
300 * dispnew.c: Integer signedness and overflow fixes.
301 Remove unnecessary forward decls, that were a maintenance hassle.
302 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
303 All uses changed.
304 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
305 (scrolling_window): Use ptrdiff_t, not int, for byte count.
306 (prepare_desired_row, line_draw_cost):
307 Use int, not unsigned, where either works.
308 (save_current_matrix, restore_current_matrix):
309 Use ptrdiff_t, not size_t, where either works.
310 (init_display): Check for overflow more accurately, and without
311 relying on undefined behavior.
312
313 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
314 Remove, replacing with the new symbols in lisp.h. All uses changed.
315 * fileio.c (make_temp_name):
316 * filelock.c (lock_file_1, lock_file):
317 * xdisp.c (message_dolog):
318 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
319 Use pMd etc. instead.
320 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
321 replacing the pWIDE etc. symbols removed from editfns.c.
322
323 * keyboard.h (num_input_events): Now uintmax_t.
324 This is (very slightly) less likely to mess up due to wraparound.
325 All uses changed.
326
327 * buffer.c: Integer signedness fixes.
328 (alloc_buffer_text, enlarge_buffer_text):
329 Use ptrdiff_t rather than size_t when either will do, as we prefer
330 signed integers.
331
332 * alloc.c: Integer signedness and overflow fixes.
333 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
334 (__malloc_size_t): Default to size_t, not to int.
335 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
336 (Fgarbage_collect, mark_object_loop_halt, mark_object):
337 Prefer ptrdiff_t to size_t when either would do, as we prefer
338 signed integers.
339 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
340 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
341 Now const. Initialize with values that are in range even if char
342 is signed.
343 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
344 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
345 These functions do the right thing with sizes > 2**32.
346 (check_depth): Now ptrdiff_t, not int.
347 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
348 Adjust to new way of storing sizes. Check for size overflow bugs
349 in rest of code.
350 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
351 slightly wrong anyway, as it missed one instance of
352 XMALLOC_OVERRUN_CHECK_OVERHEAD.
353 (refill_memory_reserve): Omit needless cast to size_t.
354 (mark_object_loop_halt): Mark as externally visible.
355
356 * xselect.c: Integer signedness and overflow fixes.
357 (Fx_register_dnd_atom, x_handle_dnd_message):
358 Use ptrdiff_t, not size_t, since we prefer signed.
359 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
360 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
361 x_dnd_atoms_size and x_dnd_atoms_length.
362
363 * doprnt.c: Prefer signed to unsigned when either works.
364 * eval.c (verror):
365 * doprnt.c (doprnt):
366 * lisp.h (doprnt):
367 * xdisp.c (vmessage):
368 Use ptrdiff_t, not size_t, when using or implementing doprnt,
369 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
370 prefer signed arithmetic to avoid comparison confusion.
371 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
372 but is a bit tricky.
373
374 Assume freestanding C89 headers, string.h, stdlib.h.
375 * data.c, doprnt.c, floatfns.c, print.c:
376 Include float.h unconditionally.
377 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
378 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
379 * regex.c: Likewise for stddef.h, string.h.
380 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
381 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
382 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
383 (STDC_HEADERS): Remove obsolete defines.
384 * sysdep.c: Include limits.h unconditionally.
385
386 Assume support for memcmp, memcpy, memmove, memset.
387 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
388 * regex.c (memcmp, memcpy):
389 Remove; we assume C89 now.
390
391 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
392 (__malloc_safe_bcopy): Remove; no longer needed.
393
394 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
395 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
396 well either way, and we prefer signed to unsigned.
397
398 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
399
400 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
401 closes the connection while we're reading (bug#9182).
402
403 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
404
405 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
406 are specified (Bug#9168).
407
408 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
409
410 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
411 Found by GCC static checking and --with-wide-int on a 32-bit host.
412
413 2011-07-25 Eli Zaretskii <eliz@gnu.org>
414
415 * xdisp.c (compute_display_string_pos): Fix logic of caching
416 previous display string position. Initialize cached_prev_pos to
417 -1. Fixes slow-down at the beginning of a buffer.
418
419 2011-07-24 Eli Zaretskii <eliz@gnu.org>
420
421 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
422 for attrs[LFACE_FONTSET_INDEX].
423
424 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
425
426 * xml.c (parse_region): Remove unused local
427 that was recently introduced.
428
429 2011-07-23 Eli Zaretskii <eliz@gnu.org>
430
431 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
432 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
433
434 * xdisp.c (move_it_in_display_line_to): Record the best matching
435 position for TO_CHARPOS while scanning the line, and restore it on
436 exit if none of the characters scanned was an exact match.
437 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
438 when exact match is impossible due to invisible text, and the
439 lines are truncated.
440
441 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
442
443 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
444 for OSX >= 10.7.
445
446 2011-07-22 Eli Zaretskii <eliz@gnu.org>
447
448 Fix a significant slow-down of cursor motion with C-n, C-p,
449 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
450 auto-repeat under bidi redisplay in fontified buffers.
451 * xdisp.c (compute_stop_pos_backwards): New function.
452 (next_element_from_buffer): Call compute_stop_pos_backwards to
453 find a suitable prev_stop when we find ourselves before
454 base_level_stop.
455 (reseat): Don't look for prev_stop, as that could mean a very long
456 run.
457 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
458 <cached_disp_overlay_modiff>: Cache for last found display string
459 position.
460 (compute_display_string_pos): Return the cached position if asked
461 about the same buffer in the same area of character positions, and
462 the buffer wasn't changed since the time the display string
463 position was cached.
464
465 2011-07-22 Eli Zaretskii <eliz@gnu.org>
466
467 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
468 is an integer, which is important for empty lines. (Bug#9149)
469
470 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
471
472 * frame.c (Fmodify_frame_parameters): In tty case, update the
473 default face if necessary (Bug#4238).
474
475 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
476
477 * editfns.c (Fstring_to_char): No need to explain what a character
478 is in the docstring (Bug#6576).
479
480 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
481
482 * xml.c (parse_region): Make sure we always return a tree.
483
484 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
485
486 * xml.c (parse_region): If a document contains only comments,
487 return that, too.
488
489 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
490
491 * xml.c (make_dom): Return comments, too.
492
493 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
494
495 Port to OpenBSD.
496 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
497 and the surrounding thread.
498 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
499 rather than fgets, and retry after EINTR. Otherwise, 'emacs
500 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
501 timer goes off.
502 * s/openbsd.h (BROKEN_SIGIO): Define.
503 * unexelf.c (unexec) [__OpenBSD__]:
504 Don't update the .mdebug section of the Alpha COFF symbol table.
505
506 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
507
508 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
509 (bug#8460).
510
511 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
512
513 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
514 This fixes some race conditions on the permissions of any newly
515 created file.
516
517 * alloc.c (valid_pointer_p): Use pipe, not open.
518 This fixes some permissions issues when debugging.
519
520 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
521 If fchown fails to set both uid and gid, try to set just gid,
522 as that is sometimes allowed. Adjust the file's mode to eliminate
523 setuid or setgid bits that are inappropriate if fchown fails.
524
525 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
526
527 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
528 to compare Lisp_Objects.
529 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
530 global_gnutls_log_level, don't mistake it for a Lisp_Object.
531 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
532
533 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
534
535 * lread.c (read_integer): Unread even EOF character.
536 (read1): Likewise. Properly record start position of symbol.
537
538 * lread.c (read1): Read `#:' as empty uninterned symbol if no
539 symbol character follows.
540
541 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
542
543 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
544 This works around a problem with the previous change to Fcopy_file.
545 Recent glibc declares fchown with __attribute__((warn_unused_result)),
546 and without this change, GCC might complain about discarding
547 fchown's return value.
548
549 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
550
551 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
552
553 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
554
555 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
556
557 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
558
559 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
560 it's used from the C level.
561
562 * process.c: Use the same condition for POLL_FOR_INPUT in both
563 keyboard.c and process.c (bug#1858).
564
565 2011-07-09 Lawrence Mitchell <wence@gmx.li>
566
567 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
568 (Fgnutls_boot): Use it.
569
570 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
571
572 * doc.c (Fsubstitute_command_keys): Revert last change.
573
574 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
575
576 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
577 quotes the next character, and doesn't affect other longer
578 sequences (bug#8935).
579
580 * lread.c (syms_of_lread): Clarify that is isn't only
581 `eval-buffer' and `eval-defun' that's affected by
582 `lexical-binding' (bug#8460).
583
584 2011-07-15 Eli Zaretskii <eliz@gnu.org>
585
586 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
587 bidi redisplay when a line includes both an image and is
588 truncated.
589
590 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
591
592 Fix minor problems found by static checking.
593 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
594 (elsz): Now a signed constant, not a size_t var. We prefer signed
595 types to unsigned, to avoid integer comparison confusion. Without
596 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
597 "cannot optimize loop, the loop counter may overflow", a symptom
598 of the confusion.
599 * indent.c (Fvertical_motion): Mark locals as initialized.
600 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
601
602 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
603
604 * search.c (Fre_search_backward): Mention `case-fold-search' in
605 all the re_search_* functions (bug#8138).
606
607 * keyboard.c (Fopen_dribble_file): Document when the file is
608 closed (bug#8056).
609
610 2011-07-14 Eli Zaretskii <eliz@gnu.org>
611
612 * bidi.c (bidi_dump_cached_states): Fix format of displaying
613 bidi_cache_idx.
614
615 Support bidi reordering of display and overlay strings.
616 * xdisp.c (compute_display_string_pos)
617 (compute_display_string_end): Accept additional argument STRING.
618 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
619 (reseat_to_string): Initialize bidi_it->string.s and
620 bidi_it->string.schars.
621 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
622 NULL (avoids a crash in bidi_paragraph_init).
623 Initialize itb.string.lstring.
624 (init_iterator): Call bidi_init_it only of a valid
625 buffer position was specified. Initialize paragraph_embedding to
626 L2R.
627 (reseat_to_string): Initialize the bidi iterator.
628 (display_string): If we need to ignore text properties of
629 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
630 original value of -1 will not work with bidi.)
631 (compute_display_string_pos): First arg is now struct
632 `text_pos *'; all callers changed. Support display properties on
633 Lisp strings.
634 (compute_display_string_end): Support display properties on Lisp
635 strings.
636 (init_iterator, reseat_1, reseat_to_string): Initialize the
637 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
638 when iterating on a string not from display properties).
639 (compute_display_string_pos, compute_display_string_end):
640 Fix calculation of the object to scan. Fixes an error when using
641 arrow keys.
642 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
643 base_level_stop; instead, set base_level_stop to BEGV.
644 Fixes crashes in vertical-motion.
645 (next_element_from_buffer): Improve commentary for when
646 the iterator is before prev_stop.
647 (init_iterator): Initialize bidi_p from the default value of
648 bidi-display-reordering, not from buffer-local value. Use the
649 buffer-local value only if initializing for buffer iteration.
650 (handle_invisible_prop): Support invisible properties on strings
651 that are being bidi-reordered.
652 (set_iterator_to_next): Support bidi reordering of C strings and
653 Lisp strings.
654 (next_element_from_string): Support bidi reordering of Lisp
655 strings.
656 (handle_stop_backwards): Support Lisp strings as well.
657 (display_string): Support display of R2L glyph rows.
658 Use IT_STRING_CHARPOS when displaying from a Lisp string.
659 (init_iterator): Don't initialize it->bidi_p for strings
660 here.
661 (reseat_to_string): Initialize it->bidi_p for strings here.
662 (next_element_from_string, next_element_from_c_string)
663 (next_element_from_buffer): Add xassert's for correspondence
664 between IT's object being iterated and it->bidi_it.string
665 structure.
666 (face_before_or_after_it_pos): Support bidi iteration.
667 (next_element_from_c_string): Handle the case of the first string
668 character that is not the first one in the visual order.
669 (get_visually_first_element): New function, refactored from common
670 parts of next_element_from_buffer, next_element_from_string, and
671 next_element_from_c_string.
672 (tool_bar_lines_needed, redisplay_tool_bar)
673 (display_menu_bar): Force left-to-right direction. Add a FIXME
674 comment for making that be controlled by a user option.
675 (push_it, pop_it): Save and restore the state of the
676 bidi iterator. Save and restore the bidi_p flag.
677 (pop_it): Iterate out of display property for string iteration as
678 well.
679 (iterate_out_of_display_property): Support iteration over strings.
680 (handle_single_display_spec): Set up it->bidi_it for iteration
681 over a display string, and call bidi_init_it.
682 (handle_single_display_spec, next_overlay_string)
683 (get_overlay_strings_1, push_display_prop): Set up the bidi
684 iterator for displaying display or overlay strings.
685 (forward_to_next_line_start): Don't use the shortcut if
686 bidi-iterating.
687 (back_to_previous_visible_line_start): If handle_display_prop
688 pushed the iterator stack, restore the internal state of the bidi
689 iterator by calling bidi_pop_it same number of times.
690 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
691 and we are bidi-iterating, don't decrement the iterator position;
692 instead, set the first_elt flag in the bidi iterator, to produce
693 the same effect.
694 (reseat_1): Remove redundant setting of string_from_display_prop_p.
695 (push_display_prop): xassert that we are iterating a buffer.
696 (push_it, pop_it): Save and restore paragraph_embedding member.
697 (handle_single_display_spec, next_overlay_string)
698 (get_overlay_strings_1, reseat_1, reseat_to_string)
699 (push_display_prop): Set up the `unibyte' member of bidi_it.string
700 correctly. Don't assume unibyte strings are not bidi-reordered.
701 (compute_display_string_pos)
702 (compute_display_string_end): Fix handling the case of C string.
703 (push_it, pop_it): Save and restore from_disp_prop_p.
704 (handle_single_display_spec, push_display_prop): Set the
705 from_disp_prop_p flag.
706 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
707 (pop_it): Call iterate_out_of_display_property only if we are
708 popping after iteration over a string that came from a display
709 property. Fix a typo in popping stretch info. Add an assertion
710 for verifying that the iterator position is in sync with the bidi
711 iterator.
712 (handle_single_display_spec, get_overlay_strings_1)
713 (push_display_prop): Fix initialization of paragraph direction for
714 string when that of the parent object is not yet determined.
715 (reseat_1): Call bidi_init_it to resync the bidi
716 iterator with IT's position. (Bug#7616)
717 (find_row_edges): If ROW->start.pos gives position
718 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
719 (handle_stop, back_to_previous_visible_line_start, reseat_1):
720 Reset the from_disp_prop_p flag.
721 (SAVE_IT, RESTORE_IT): New macros.
722 (pos_visible_p, face_before_or_after_it_pos)
723 (back_to_previous_visible_line_start)
724 (move_it_in_display_line_to, move_it_in_display_line)
725 (move_it_to, move_it_vertically_backward, move_it_by_lines)
726 (try_scrolling, redisplay_window, display_line): Use them when
727 saving a temporary copy of the iterator and restoring it back.
728 (back_to_previous_visible_line_start, reseat_1)
729 (init_iterator): Empty the bidi cache "stack".
730 (move_it_in_display_line_to): If iterator ended up at
731 EOL, but we never saw any buffer positions smaller than
732 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
733 motion in bidi-reordered lines.
734 (move_it_in_display_line_to): Record prev_method and prev_pos
735 immediately before the call to set_iterator_to_next. Fixes cursor
736 motion in bidi-reordered lines with stretch glyphs and strings
737 displayed in margins. (Bug#8133) (Bug#8867)
738 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
739 TO_CHARPOS.
740 (pos_visible_p): Support positions in bidi-reordered lines.
741 Save and restore bidi cache.
742
743 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
744 (bidi_paragraph_info): Delete unused struct.
745 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
746 (bidi_cache_start): New variable.
747 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
748 to zero.
749 (bidi_cache_fetch_state, bidi_cache_search)
750 (bidi_cache_find_level_change, bidi_cache_iterator_state)
751 (bidi_cache_find, bidi_peek_at_next_level)
752 (bidi_level_of_next_char, bidi_find_other_level_edge)
753 (bidi_move_to_visually_next): Compare cache index with
754 bidi_cache_start rather than with zero.
755 (bidi_fetch_char): Accept new argument STRING; all callers
756 changed. Support iteration over a string. Support strings with
757 display properties. Support unibyte strings. Fix the type of
758 `len' according to what STRING_CHAR_AND_LENGTH expects.
759 (bidi_paragraph_init, bidi_resolve_explicit_1)
760 (bidi_resolve_explicit, bidi_resolve_weak)
761 (bidi_level_of_next_char, bidi_move_to_visually_next):
762 Support iteration over a string.
763 (bidi_set_sor_type, bidi_resolve_explicit_1)
764 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
765 can now be zero (for strings); special values 0 and -1 were
766 changed to -1 and -2, respectively.
767 (bidi_char_at_pos): New function.
768 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
769 Call it instead of FETCH_MULTIBYTE_CHAR.
770 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
771 initialized to valid values.
772 (bidi_init_it): Don't initialize charpos and bytepos with invalid
773 values.
774 (bidi_level_of_next_char): Allow the sentinel "position" to pass
775 the test for valid cached positions. Fix the logic for looking up
776 the sentinel state in the cache. GCPRO the Lisp string we are
777 iterating.
778 (bidi_push_it, bidi_pop_it): New functions.
779 (bidi_initialize): Initialize the bidi cache start stack pointer.
780 (bidi_cache_ensure_space): New function, refactored from part of
781 bidi_cache_iterator_state. Don't assume the required size is just
782 one BIDI_CACHE_CHUNK away.
783 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
784 (bidi_count_bytes, bidi_char_at_pos): New functions.
785 (bidi_cache_search): Don't assume bidi_cache_last_idx is
786 always valid if bidi_cache_idx is valid.
787 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
788 is valid if it's going to be used.
789 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
790 (bidi_cache_fetch_state, bidi_cache_search)
791 (bidi_cache_find_level_change, bidi_cache_ensure_space)
792 (bidi_cache_iterator_state, bidi_cache_find)
793 (bidi_find_other_level_edge, bidi_cache_start_stack):
794 All variables related to cache indices are now EMACS_INT.
795
796 * dispextern.h (struct bidi_string_data): New structure.
797 (struct bidi_it): New member `string'. Make flag members be 1-bit
798 fields, and put them last in the struct.
799 (compute_display_string_pos, compute_display_string_end):
800 Update prototypes.
801 (bidi_push_it, bidi_pop_it): Add prototypes.
802 (struct iterator_stack_entry): New members bidi_p,
803 paragraph_embedding, and from_disp_prop_p.
804 (struct it): Member bidi_p is now a bit field 1 bit wide.
805 (bidi_shelve_cache, bidi_unshelve_cache):
806 Declare prototypes.
807
808 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
809 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
810 and vector-like objects.
811
812 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
813 cache around display iteration.
814
815 * window.c (Fwindow_end, window_scroll_pixel_based)
816 (displayed_window_lines, Frecenter): Save and restore the bidi
817 cache around display iteration.
818
819 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
820
821 * editfns.c (Fdelete_region): Clarify the use of the named
822 parameters (bug#6788).
823
824 2011-07-14 Martin Rudalics <rudalics@gmx.at>
825
826 * indent.c (Fvertical_motion): Set and restore w->pointm when
827 saving and restoring the window's buffer (Bug#9006).
828
829 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
830
831 * editfns.c (Fstring_to_char): Clarify just what is returned
832 (bug#6576). Text by Eli Zaretskii.
833
834 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
835
836 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
837
838 2011-07-13 Eli Zaretskii <eliz@gnu.org>
839
840 * buffer.c (mmap_find): Fix a typo.
841
842 2011-07-13 Johan Bockgård <bojohan@gnu.org>
843
844 Fix execution of x selection hooks.
845 * xselect.c (Qx_lost_selection_functions)
846 (Qx_sent_selection_functions): New vars.
847 (syms_of_xselect): DEFSYM them.
848 (x_handle_selection_request): Pass Qx_sent_selection_functions
849 rather than Vx_sent_selection_functions to Frun_hook_with_args.
850 (x_handle_selection_clear,x_clear_frame_selections):
851 Pass Qx_lost_selection_functions rather than
852 Vx_lost_selection_functions to Frun_hook_with_args.
853
854 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
855
856 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
857 The old code sometimes used this field without initializing it.
858
859 * alloc.c (gc_sweep): Don't read past end of array.
860 In theory, the old code could also have corrupted Emacs internals,
861 though it'd be very unlikely.
862
863 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
864
865 * character.c (Fcharacterp): Don't advertise optional ignored
866 argument. (Bug#4026)
867
868 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
869
870 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
871 key" (bug#4257).
872
873 * window.c (Fset_window_start): Doc fix (bug#4199).
874 (Fset_window_hscroll): Ditto.
875
876 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
877
878 Fix minor new problems caught by GCC 4.6.1.
879 * term.c (init_tty): Remove unused local.
880 * xsettings.c (store_monospaced_changed): Define this function only
881 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
882 not used otherwise.
883
884 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
885
886 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
887
888 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
889
890 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
891 are the mini-buffer and the echo area (bug#3320).
892
893 * term.c (init_tty): Remove support for supdup, c10 and perq
894 terminals, which are no longer supported (bug#1482).
895
896 2011-07-10 Johan Bockgård <bojohan@gnu.org>
897
898 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
899
900 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
901
902 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
903 for non-popups (Bug#3642).
904
905 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
906
907 * alloc.c (reset_malloc_hooks): Protoize.
908 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
909 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
910 * cm.c (losecursor): Likewise.
911 * data.c (fmod): Likewise.
912 * dispnew.c (swap_glyphs_in_rows): Likewise.
913 * emacs.c (memory_warning_signal): Likewise.
914 * floatfns.c (float_error): Likewise.
915 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
916 (otf_open, font_otf_capability, generate_otf_features)
917 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
918 Likewise.
919 * image.c (pbm_read_file): Likewise.
920 * indent.c (string_display_width): Likewise.
921 * intervals.c (check_for_interval, search_for_interval)
922 (inc_interval_count, count_intervals, root_interval)
923 (adjust_intervals_for_insertion, make_new_interval): Likewise.
924 * lread.c (defalias): Likewise.
925 * ralloc.c (r_alloc_check): Likewise.
926 * regex.c (set_image_of_range_1, set_image_of_range)
927 (regex_grow_registers): Likewise.
928 * sysdep.c (strerror): Likewise.
929 * termcap.c (valid_filename_p, tprint, main): Likewise.
930 * tparam.c (main): Likewise.
931 * unexhp9k800.c (run_time_remap, save_data_space)
932 (update_file_ptrs, read_header, write_header, calculate_checksum)
933 (copy_file, copy_rest, display_header): Likewise.
934 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
935 Likewise.
936 * xdisp.c (check_it): Likewise.
937 * xfaces.c (register_color, unregister_color, unregister_colors):
938 Likewise.
939 * xfns.c (print_fontset_result): Likewise.
940 * xrdb.c (member, fatal, main): Likewise.
941
942 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
943
944 Fix minor problems found by static checking (Bug#9031).
945 * chartab.c (char_table_set_range, map_sub_char_table):
946 Remove unused locals.
947 (uniprop_table): Now static.
948 * composite.c (_work_char): Remove unused static var.
949
950 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
951
952 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
953
954 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
955
956 * gtkutil.c (qttip_cb): Remove code without function.
957
958 2011-07-09 Eli Zaretskii <eliz@gnu.org>
959
960 * w32.c (pthread_sigmask): New stub.
961
962 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
963
964 Use pthread_sigmask, not sigprocmask (Bug#9010).
965 sigprocmask is portable only for single-threaded applications, and
966 Emacs can be multi-threaded when it uses GTK.
967 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
968 (LIBES): Use it.
969 * callproc.c (Fcall_process):
970 * process.c (create_process):
971 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
972 Use pthread_sigmask, not sigprocmask.
973
974 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
975
976 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
977 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
978 wrong (Bug#8591).
979
980 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
981
982 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
983 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
984 (xg_hide_tooltip): Fix comment.
985
986 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
987 in registerServicesMenuSendTypes.
988 (validRequestorForSendType): Don't check ns_return_types.
989
990 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
991 ns_return_type.
992
993 2011-07-08 Jason Rumney <jasonr@gnu.org>
994
995 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
996 frame struct members of non-existent frames (Bug#6284).
997
998 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
999
1000 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1001 variable firstTime not needed on OSX >= 10.6.
1002 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1003 >= 10.5. Use setKnobProportion, setDoubleValue.
1004
1005 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1006 (MAC_OS_X_VERSION_10_5): Define if not defined.
1007 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1008 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1009 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1010
1011 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1012 cString and lossyCString on OSX >= 10.4
1013
1014 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1015 sizeToFit on OSX >= 10.2.
1016
1017 * nsimage.m (allocInitFromFile): Don't use deprecated method
1018 bestRepresentationForDevice on OSX >= 10.6.
1019
1020 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1021 to avoid warning.
1022
1023 * emacs.c: Declare unexec_init_emacs_zone.
1024
1025 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1026
1027 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1028
1029 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1030 on svcsMenu (Bug#8842).
1031
1032 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1033 ns_return_types.
1034 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1035
1036 * nsterm.m (QUTF8_STRING): Declare.
1037 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1038 (validRequestorForSendType): Return type is (id).
1039 Change indexOfObjectIdenticalTo to indexOfObject.
1040 Check if we have local selection before returning self (Bug#8842).
1041 (writeSelectionToPasteboard): Put local selection into paste board
1042 if we have a local selection (Bug#8842).
1043 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1044
1045 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1046 (ns_get_local_selection): Declare.
1047
1048 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1049
1050 * keymap.c (describe_map_tree): Don't insert a double newline at
1051 the end of the buffer (bug#1169) and return whether we inserted
1052 something.
1053
1054 * callint.c (Fcall_interactively): Change "reading args" to
1055 "providing args" to try to clarify what it does (bug#1010).
1056
1057 2011-07-07 Kenichi Handa <handa@m17n.org>
1058
1059 * composite.c (composition_compute_stop_pos): Ignore a static
1060 composition starting before CHARPOS (Bug#8915).
1061
1062 * xdisp.c (handle_composition_prop): Likewise.
1063
1064 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1065
1066 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1067 (Bug#9015)
1068
1069 2011-07-07 Kenichi Handa <handa@m17n.org>
1070
1071 * character.h (unicode_category_t): New enum type.
1072
1073 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1074 (Qchar_code_property_table): New variable.
1075 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1076 (UNIPROP_COMPRESSED_FORM_P): New macros.
1077 (char_table_ascii): Uncompress the compressed values.
1078 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1079 Uncompress the compressed values.
1080 (sub_char_table_ref_and_range): Likewise.
1081 (char_table_ref_and_range): Uncompress the compressed values.
1082 (sub_char_table_set): New arg is_uniprop. Callers changed.
1083 Uncompress the compressed values.
1084 (sub_char_table_set_range): Args changed. Callers changed.
1085 (char_table_set_range): Adjuted for the above change.
1086 (map_sub_char_table): Delete args default_val and parent. Add arg
1087 top. Give decoded values to a Lisp function.
1088 (map_char_table): Adjust for the above change. Give decoded
1089 values to a Lisp function. Gcpro more variables.
1090 (uniprop_table_uncompress)
1091 (uniprop_decode_value_run_length): New functions.
1092 (uniprop_decoder, uniprop_decoder_count): New variables.
1093 (uniprop_get_decoder, uniprop_encode_value_character)
1094 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1095 New functions.
1096 (uniprop_encoder, uniprop_encoder_count): New variables.
1097 (uniprop_get_encoder, uniprop_table)
1098 (Funicode_property_table_internal, Fget_unicode_property_internal)
1099 (Fput_unicode_property_internal): New functions.
1100 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1101 Sunicode_property_table_internal, Sget_unicode_property_internal,
1102 and Sput_unicode_property_internal. Defvar_lisp
1103 char-code-property-alist.
1104
1105 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1106 Vunicode_category_table.
1107
1108 * font.c (font_range): Adjust for the change of
1109 Vunicode_category_table.
1110
1111 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1112
1113 * m/iris4d.h: Remove file, move contents ...
1114 * s/irix6-5.h: ... here.
1115
1116 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1117
1118 Remove unportable assumption about struct layout (Bug#8884).
1119 * alloc.c (mark_buffer):
1120 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1121 (clone_per_buffer_values): Don't assume that
1122 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1123 This isn't true in general, and it's particularly not true
1124 if Emacs is configured with --with-wide-int.
1125 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1126 New macros, used in the buffer.c change.
1127
1128 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1129
1130 * xsettings.c: Use both GConf and GSettings if both are available.
1131 (store_config_changed_event): Add comment.
1132 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1133 (store_tool_bar_style_changed): New functions.
1134 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1135 (struct xsettings): Move font inside HAVE_XFT.
1136 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1137 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1138 Move inside HAVE_XFT.
1139 (something_changed_gsettingsCB): Rename from something_changedCB.
1140 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1141 also.
1142 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1143 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1144 (something_changed_gconfCB): Rename from something_changedCB.
1145 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1146 (parse_settings): Move check for font inside HAVE_XFT.
1147 (read_settings, apply_xft_settings): Add comment.
1148 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1149 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1150 call store_font_name_changed.
1151 (xft_settings_event): Add comment.
1152 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1153 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1154 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1155 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1156 (xsettings_initialize): Call init_gsettings last.
1157 (xsettings_get_system_font, xsettings_get_system_normal_font):
1158 Add comment.
1159
1160 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1161
1162 Random fixes. E.g., (random) never returned negative values.
1163 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1164 subseconds part to the entropy, as that's a bit more random.
1165 Prefer signed to unsigned, since the signedness doesn't matter and
1166 in general we prefer signed. When given a limit, use a
1167 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1168 latter isn't right if USE_2_TAGS_FOR_INTS.
1169 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1170 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1171
1172 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1173
1174 * textprop.c (text_property_stickiness):
1175 Obey Vtext_property_default_nonsticky.
1176 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1177 * w32fns.c (syms_of_w32fns):
1178 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1179
1180 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1183 This is more efficient than Ffile_directory_p and avoids a minor race.
1184
1185 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1186
1187 * buffer.c (Foverlay_put): Say what the return value is
1188 (bug#7835).
1189
1190 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1191 is a directory before asking whether to use the file name
1192 (bug#7564).
1193 (barf_or_query_if_file_exists): Make the "File is a directory"
1194 error be more correct.
1195
1196 * fns.c (Frequire): Remove the mention of the .gz files, since
1197 that's installation-specific, but keep the mention of
1198 `get-load-suffixes'.
1199
1200 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1201
1202 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1203 Report string overflow if the output is too long.
1204
1205 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
1206
1207 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1208 (syms_of_gnutls): Remove duplicate DEFSYM for
1209 Qgnutls_bootprop_verify_hostname_error, an error for
1210 Qgnutls_bootprop_verify_error (which is no longer used).
1211
1212 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1213 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1214 Also (re)move comments that are misplaced or no longer relevant.
1215
1216 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1217
1218 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1219
1220 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
1221
1222 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1223 and background color parameters if they have been changed.
1224
1225 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1226
1227 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1228
1229 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1230
1231 * xsettings.c (SYSTEM_FONT): Define only when used.
1232 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1233
1234 * keymap.c (access_keymap_1): Now static.
1235
1236 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
1237
1238 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1239 leave any prefix arg for the up event (Bug#1586).
1240
1241 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1242
1243 * lread.c (syms_of_lread): Mention single symbols defined by
1244 `defvar' or `defconst' (bug#7154).
1245
1246 * fns.c (Frequire): Mention .el.gz files (bug#7314).
1247 (Frequire): Mention get-load-suffixes.
1248
1249 2011-07-02 Martin Rudalics <rudalics@gmx.at>
1250
1251 * window.h (window): Remove clone_number slot.
1252 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1253 Remove.
1254 (make_parent_window, make_window, saved_window)
1255 (Fset_window_configuration, save_window_save): Don't deal with
1256 clone numbers.
1257 * buffer.c (Qclone_number): Remove declaration.
1258 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1259
1260 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1261
1262 Add multiple inheritance to keymaps.
1263 * keymap.c (Fmake_composed_keymap): New function.
1264 (Fset_keymap_parent): Simplify.
1265 (fix_submap_inheritance): Remove.
1266 (access_keymap_1): New function extracted from access_keymap to handle
1267 embedded parents and handle lists of maps.
1268 (access_keymap): Use it.
1269 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1270 (Fcopy_keymap): Handle embedded parents.
1271 (Fcommand_remapping, define_as_prefix): Simplify.
1272 (Fkey_binding): Simplify.
1273 (syms_of_keymap): Move minibuffer-local-completion-map,
1274 minibuffer-local-filename-completion-map,
1275 minibuffer-local-must-match-map, and
1276 minibuffer-local-filename-must-match-map to Elisp.
1277 (syms_of_keymap): Defsubr make-composed-keymap.
1278 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1279 (parse_menu_item): Trivial simplification.
1280
1281 2011-07-01 Glenn Morris <rgm@gnu.org>
1282
1283 * Makefile.in (SETTINGS_LIBS): Fix typo.
1284
1285 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1286
1287 * coding.c (Fencode_coding_string): Record the last coding system
1288 used, as the function doc string says (bug#8738).
1289
1290 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1291
1292 * xsettings.c (store_monospaced_changed): Take new font as arg and
1293 check for change against current_mono_font.
1294 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1295 (emacs_settings_constructor, emacs_settings_get_property)
1296 (emacs_settings_set_property, emacs_settings_class_init)
1297 (emacs_settings_init, gsettings_obj): Remove.
1298 (something_changedCB): New function for HAVE_GSETTINGS.
1299 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1300 with value as argument.
1301 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1302 g_settings_new (Bug#8967). Do not create gsettings_obj.
1303 Remove calls to g_settings_bind. Connect something_changedCB to
1304 "changed".
1305
1306 * xgselect.c: Add defined (HAVE_GSETTINGS).
1307 (xgselect_initialize): Ditto.
1308
1309 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1310 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1311 xg_select.
1312
1313 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1314
1315 * eval.c (struct backtrace): Simplify and port the data structure.
1316 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1317 signed bit field, as this assumption is not portable and it makes
1318 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1319 "char debug_on_exit : 1" as this is not portable either; instead,
1320 use the portable "unsigned int debug_on_exit : 1". Remove unused
1321 member evalargs. Remove obsolete comments about cc bombing out.
1322
1323 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1324
1325 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1326 Let HAVE_GSETTINGS override HAVE_GCONF.
1327 (store_monospaced_changed): New function.
1328 (EMACS_SETTINGS): A new type derived from GObject to handle
1329 GSettings notifications.
1330 (emacs_settings_constructor, emacs_settings_get_property)
1331 (emacs_settings_set_property, emacs_settings_class_init):
1332 New functions.
1333 (gsettings_client, gsettings_obj): New variables.
1334 (GSETTINGS_SCHEMA): New define.
1335 (something_changedCB): Call store_monospaced_changed.
1336 (init_gsettings): New function.
1337 (xsettings_initialize): Call init_gsettings.
1338 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1339 to NULL.
1340
1341 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
1342 GCONF_CFLAGS/LIBS.
1343
1344 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1345
1346 * window.c (resize_root_window, grow_mini_window)
1347 (shrink_mini_window): Rename Qresize_root_window to
1348 Qwindow_resize_root_window and Qresize_root_window_vertically to
1349 Qwindow_resize_root_window_vertically.
1350
1351 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1352
1353 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1354
1355 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1356
1357 * makefile.w32-in: Redesign dependencies so they reflect more
1358 clearly which files are directly included by each source file,
1359 and not through other includes.
1360
1361 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1362
1363 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1364 (sort_overlays, overlay_strings): When an overlay's clone number
1365 matches the window's clone number process the overlay even if
1366 the overlay's window property doesn't match the current window.
1367
1368 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1369 (Fwindow_hchild): Rename to Fwindow_left_child.
1370 (Fwindow_next): Rename to Fwindow_next_sibling.
1371 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1372 (resize_window_check): Rename to window_resize_check.
1373 (resize_window_apply): Rename to window_resize_apply.
1374 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1375 (Fdelete_other_windows_internal, resize_frame_windows)
1376 (Fsplit_window_internal, Fdelete_window_internal)
1377 (grow_mini_window, shrink_mini_window)
1378 (Fresize_mini_window_internal): Fix callers accordingly.
1379
1380 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1381
1382 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1383 (emacs_fixed_set_min_size): Remove.
1384 (emacs_fixed_new): Take frame as argument.
1385
1386 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1387 (_EmacsFixedPrivate): Remove minwidth/height.
1388 Add struct frame *f.
1389 (emacs_fixed_init): Initialize priv->f.
1390 (get_parent_class, emacs_fixed_set_min_size): Remove.
1391 (emacs_fixed_new): Set priv->f to argument.
1392 (emacs_fixed_get_preferred_width)
1393 (emacs_fixed_get_preferred_height): Use min_width/height from
1394 frames size_hint to set minimum and natural (Bug#8919).
1395 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1396 and use min_width/height from frames size_hint to set
1397 min_width/height (Bug#8919).
1398
1399 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1400 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1401 Fix indentation.
1402
1403 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1404
1405 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1406 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1407 called at ZV.
1408
1409 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1410
1411 * process.c (wait_reading_process_output): Bypass select if
1412 waiting for a cell while ignoring keyboard input, and input is
1413 pending. Suggested by Jan Djärv (Bug#8869).
1414
1415 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1416
1417 Use gnulib's dup2 module instead of rolling our own.
1418 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1419
1420 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1421
1422 * dispnew.c (scrolling_window): Before scrolling, turn off a
1423 mouse-highlight in the window being scrolled.
1424
1425 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1426
1427 Move DEFSYM to lisp.h and use everywhere.
1428
1429 * character.h (DEFSYM): Move declaration...
1430 * lisp.h (DEFSYM): ...here.
1431
1432 * gnutls.c:
1433 * minibuf.c:
1434 * w32menu.c:
1435 * w32proc.c:
1436 * w32select.c: Don't include character.h.
1437
1438 * alloc.c (syms_of_alloc):
1439 * buffer.c (syms_of_buffer):
1440 * bytecode.c (syms_of_bytecode):
1441 * callint.c (syms_of_callint):
1442 * casefiddle.c (syms_of_casefiddle):
1443 * casetab.c (init_casetab_once):
1444 * category.c (init_category_once, syms_of_category):
1445 * ccl.c (syms_of_ccl):
1446 * cmds.c (syms_of_cmds):
1447 * composite.c (syms_of_composite):
1448 * dbusbind.c (syms_of_dbusbind):
1449 * dired.c (syms_of_dired):
1450 * dispnew.c (syms_of_display):
1451 * doc.c (syms_of_doc):
1452 * editfns.c (syms_of_editfns):
1453 * emacs.c (syms_of_emacs):
1454 * eval.c (syms_of_eval):
1455 * fileio.c (syms_of_fileio):
1456 * fns.c (syms_of_fns):
1457 * frame.c (syms_of_frame):
1458 * fringe.c (syms_of_fringe):
1459 * insdel.c (syms_of_insdel):
1460 * keymap.c (syms_of_keymap):
1461 * lread.c (init_obarray, syms_of_lread):
1462 * macros.c (syms_of_macros):
1463 * msdos.c (syms_of_msdos):
1464 * print.c (syms_of_print):
1465 * process.c (syms_of_process):
1466 * search.c (syms_of_search):
1467 * sound.c (syms_of_sound):
1468 * syntax.c (init_syntax_once, syms_of_syntax):
1469 * terminal.c (syms_of_terminal):
1470 * textprop.c (syms_of_textprop):
1471 * undo.c (syms_of_undo):
1472 * w32.c (globals_of_w32):
1473 * window.c (syms_of_window):
1474 * xdisp.c (syms_of_xdisp):
1475 * xfaces.c (syms_of_xfaces):
1476 * xfns.c (syms_of_xfns):
1477 * xmenu.c (syms_of_xmenu):
1478 * xsettings.c (syms_of_xsettings):
1479 * xterm.c (syms_of_xterm): Use DEFSYM.
1480
1481 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1482
1483 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1484
1485 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 Integer and buffer overflow fixes (Bug#8873).
1488
1489 * print.c (printchar, strout): Check for string overflow.
1490 (PRINTPREPARE, printchar, strout):
1491 Don't set size unless allocation succeeds.
1492
1493 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1494 for sizes. Check for string overflow more accurately.
1495 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1496
1497 * macros.c: Integer and buffer overflow fixes.
1498 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1499 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1500 Use ptrdiff_t, not int, for sizes.
1501 Don't increment bufsize until after realloc succeeds.
1502 Check for size-calculation overflow.
1503 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1504
1505 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1506
1507 * lread.c: Integer overflow fixes.
1508 (read_integer): Radix is now EMACS_INT, not int,
1509 to improve quality of diagnostics for out-of-range radices.
1510 Calculate buffer size correctly for out-of-range radices.
1511 (read1): Check for integer overflow in radices, and in
1512 read-circle numbers.
1513 (read_escape): Avoid int overflow.
1514 (Fload, openp, read_buffer_size, read1)
1515 (substitute_object_recurse, read_vector, read_list, map_obarray):
1516 Use ptrdiff_t, not int, for sizes.
1517 (read1): Use EMACS_INT, not int, for sizes.
1518 Check for size overflow.
1519
1520 * image.c (cache_image): Check for size arithmetic overflow.
1521
1522 * lread.c: Integer overflow issues.
1523 (saved_doc_string_size, saved_doc_string_length)
1524 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1525 Now ptrdiff_t, not int.
1526 (read1): Don't assume doc string length fits in int. Check for
1527 out-of-range doc string lengths.
1528 (read_list): Don't assume file position fits in int.
1529 (read_escape): Check for hex character overflow.
1530
1531 2011-06-22 Leo Liu <sdl.web@gmail.com>
1532
1533 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1534 Move to minibuffer.el.
1535
1536 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1537
1538 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1539 The following patches are for when GLYPH_DEBUG && !XASSERT.
1540 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1541 * dispnew.c (flush_stdout):
1542 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1543 Mark as externally visible.
1544 * dispnew.c (check_window_matrix_pointers): Now static.
1545 * dispnew.c (window_to_frame_vpos):
1546 * xfns.c (unwind_create_frame):
1547 * xterm.c (x_check_font): Remove unused local.
1548 * scroll.c (CHECK_BOUNDS):
1549 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1550 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1551 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1552 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1553 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1554 Now static.
1555 (debug_method_add): Use va_list and vsprintf rather than relying
1556 on undefined behavior with wrong number of arguments.
1557 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1558 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1559 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1560 since we're not interested in debugging glyphs with old libraries.
1561 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1562 GCC 4.6.0's static checking.
1563
1564 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1565
1566 Integer overflow and signedness fixes (Bug#8873).
1567 A few related buffer overrun fixes, too.
1568
1569 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1570
1571 * dispextern.h (struct face.stipple):
1572 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1573 (x_bitmap_mask, x_allocate_bitmap_record)
1574 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1575 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1576 (x_create_bitmap_from_xpm_data):
1577 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1578 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1579 (.bitmaps_last):
1580 * xfaces.c (load_pixmap):
1581 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1582 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1583 (.bitmaps_last, struct x_output.icon_bitmap):
1584 Use ptrdiff_t, not int, for bitmap indexes.
1585 (x_allocate_bitmap_record): Check for size overflow.
1586 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1587
1588 Use ptrdiff_t, not int, for overlay counts.
1589 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1590 * editfns.c (overlays_around, get_pos_property):
1591 * textprop.c (get_char_property_and_overlay):
1592 * xdisp.c (next_overlay_change, note_mouse_highlight):
1593 * xfaces.c (face_at_buffer_position):
1594 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1595 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1596 (Fnext_overlay_change, Fprevious_overlay_change)
1597 (mouse_face_overlay_overlaps, Foverlays_in):
1598 Use ptrdiff_t, not int, for sizes.
1599 (overlays_at, overlays_in): Check for size-calculation overflow.
1600
1601 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1602
1603 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1604 (x_session_initialize): Do not assume string length fits in int.
1605
1606 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1607 This is unlikely, but can occur if DPI is outlandish.
1608
1609 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1610 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1611
1612 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1613 * xrdb.c (magic_file_p, search_magic_path):
1614 Omit last arg SUFFIX; it was always 0. All callers changed.
1615 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1616
1617 * xfont.c (xfont_match): Avoid need for strlen.
1618
1619 * xfns.c: Don't assume strlen fits in int.
1620 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1621
1622 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1623 not unsigned long, as we prefer signed integers. All callers changed.
1624 Detect integer overflow in repeat count.
1625 (message_dolog): Don't assume print length fits in 39 bytes.
1626 (display_mode_element): Don't assume strlen fits in int.
1627
1628 * termcap.c: Don't assume sizes fit in int and never overflow.
1629 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1630 (gobble_line): Check for size-calculation overflow.
1631
1632 * minibuf.c (Fread_buffer):
1633 * lread.c (intern, intern_c_string):
1634 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1635 Don't assume string length fits in int.
1636
1637 * keyboard.c (parse_tool_bar_item):
1638 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1639
1640 * font.c: Don't assume string length fits in int.
1641 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1642 Use ptrdiff_t, not int.
1643 (font_intern_prop): Don't assume string length fits in int.
1644 Don't assume integer property fits in fixnum.
1645 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1646
1647 * filelock.c: Fix some buffer overrun and integer overflow issues.
1648 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1649 Reformulate so as not to need the command string.
1650 Invoke gzip -cd rather than gunzip, as it's more portable.
1651 (lock_info_type, lock_file_1, lock_file):
1652 Don't assume pid_t and time_t fit in unsigned long.
1653 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1654 (current_lock_owner): Prefer signed type for sizes.
1655 Use memcpy, not strncpy, where memcpy is what is really wanted.
1656 Don't assume (via atoi) that time_t and pid_t fit in int.
1657 Check for time_t and/or pid_t out of range, e.g., via a network share.
1658 Don't alloca where an auto var works fine.
1659
1660 * fileio.c: Fix some integer overflow issues.
1661 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1662 Don't assume string length fits in int.
1663 (directory_file_name): Don't assume string length fits in long.
1664 (make_temp_name): Don't assume pid fits in int, or that its print
1665 length is less than 20.
1666
1667 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1668
1669 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1670
1671 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1672
1673 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1674 We prefer signed integers, even for size calculations.
1675
1676 * emacs.c: Don't assume string length fits in 'int'.
1677 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1678 (main): Don't invoke strlen when not needed.
1679
1680 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1681 (XD_DEBUG_MESSAGE): Don't waste a byte.
1682
1683 * callproc.c (getenv_internal_1, getenv_internal)
1684 (Fgetenv_internal):
1685 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1686
1687 * lread.c (invalid_syntax): Omit length argument.
1688 All uses changed. This doesn't fix a bug, but it simplifies the
1689 code away from its former Hollerith-constant appearance, and it's
1690 one less 'int' to worry about when looking at integer-overflow issues.
1691 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1692
1693 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1694 This didn't break anything, but it didn't help either.
1695 It's confusing to put a bogus integer in a place where the actual
1696 value does not matter.
1697 (LIST_END_P): Remove unused macro and its bogus comment.
1698 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1699
1700 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1701 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1702 implementation.
1703 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1704 We prefer signed types, and the value cannot exceed the EMACS_INT
1705 range anyway (because otherwise the length would not be representable).
1706 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1707 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1708 This avoids a GCC warning when WIDE_EMACS_INT.
1709
1710 * indent.c (sane_tab_width): New function.
1711 (current_column, scan_for_column, Findent_to, position_indentation)
1712 (compute_motion): Use it. This is just for clarity.
1713 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1714
1715 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1716
1717 * lisp.h (lint_assume): New macro.
1718 * composite.c (composition_gstring_put_cache):
1719 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1720
1721 * editfns.c, insdel.c:
1722 Omit unnecessary forward decls, to simplify future changes.
1723
1724 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1725
1726 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1727
1728 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1729 Use much-faster test for byte-length change.
1730 Don't assume string byte-length fits in 'int'.
1731 Check that character arg fits in 'int'.
1732 (mapcar1): Declare byte as byte, for clarity.
1733
1734 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1735
1736 * fns.c (concat): Catch string overflow earlier.
1737 Do not rely on integer wraparound.
1738
1739 * dispextern.h (struct it.overlay_strings_charpos)
1740 (struct it.selective): Now EMACS_INT, not int.
1741 * xdisp.c (forward_to_next_line_start)
1742 (back_to_previous_visible_line_start)
1743 (reseat_at_next_visible_line_start, next_element_from_buffer):
1744 Don't arbitrarily truncate the value of 'selective' to int.
1745
1746 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1747
1748 * composite.c: Don't truncate sizes to 'int'.
1749 (composition_gstring_p, composition_reseat_it)
1750 (composition_adjust_point): Use EMACS_INT, not int.
1751 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1752 not EMACS_UINT, for indexes.
1753
1754 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1755
1756 * buffer.c: Include <verify.h>.
1757 (struct sortvec.priority, struct sortstr.priority):
1758 Now EMACS_INT, not int.
1759 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1760 (struct sortstr.size, record_overlay_string)
1761 (struct sortstrlist.size, struct sortlist.used):
1762 Don't truncate size to int.
1763 (record_overlay_string): Check for size-calculation overflow.
1764 (init_buffer_once): Check at compile-time, not run-time.
1765
1766 2011-06-22 Jim Meyering <meyering@redhat.com>
1767
1768 Don't leak an XBM-image-sized buffer
1769 * image.c (xbm_load): Free the image buffer after using it.
1770
1771 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 Port to Sun C.
1774 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1775 that Sun C diagnosed.
1776 * fns.c (secure_hash): Fix pointer signedness issue.
1777 * intervals.c (static_offset_intervals): New function.
1778 (offset_intervals): Use it.
1779
1780 2011-06-21 Leo Liu <sdl.web@gmail.com>
1781
1782 * deps.mk (fns.o):
1783 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1784 sha512.h.
1785
1786 * fns.c (secure_hash): Rename from crypto_hash_function and change
1787 the first arg to accept symbols.
1788 (Fsecure_hash): New primitive.
1789 (syms_of_fns): New symbols.
1790
1791 2011-06-20 Deniz Dogan <deniz@dogan.se>
1792
1793 * process.c (Fset_process_buffer): Clarify return value in
1794 docstring.
1795
1796 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1797
1798 * dispnew.c (add_window_display_history): Use BVAR.
1799
1800 * xdisp.c (debug_method_add): Use BVAR.
1801 (check_window_end, dump_glyph_matrix, dump_glyph)
1802 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1803
1804 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1805 Likewise.
1806
1807 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1808 check till after the cache is created in init_frame_faces.
1809
1810 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1811
1812 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1813
1814 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1815
1816 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1817 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1818 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1819
1820 Improve buffer-overflow checking (Bug#8873).
1821 * fileio.c (Finsert_file_contents):
1822 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1823 Remove the old (too-loose) buffer overflow checks.
1824 They weren't needed, since make_gap checks for buffer overflow.
1825 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1826 The old code merely checked for Emacs fixnum overflow, and relied
1827 on undefined (wraparound) behavior. The new code avoids undefined
1828 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1829
1830 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1831 Tune. Don't use wider integers than needed. Don't use alloca.
1832 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1833
1834 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1835
1836 * insdel.c, lisp.h (buffer_overflow): New function.
1837 (insert_from_buffer_1, replace_range, replace_range_2):
1838 * insdel.c (make_gap_larger):
1839 * editfns.c (Finsert_char):
1840 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1841
1842 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1843
1844 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 Integer overflow and signedness fixes (Bug#8873).
1847
1848 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1849 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1850
1851 * fileio.c: Don't assume EMACS_INT fits in off_t.
1852 (emacs_lseek): New static function.
1853 (Finsert_file_contents, Fwrite_region): Use it.
1854 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1855
1856 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1857
1858 * fns.c: Don't overflow int when computing a list length.
1859 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1860 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1861 truncation on 64-bit hosts. Check for QUIT every
1862 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1863 faster and is responsive enough.
1864 (Flength): Report an error instead of overflowing an integer.
1865 (Fsafe_length): Return a float if the value is not representable
1866 as a fixnum. This shouldn't happen except in contrived situations.
1867 (Fnthcdr, Fsort): Don't assume list length fits in int.
1868 (Fcopy_sequence): Don't assume vector length fits in int.
1869
1870 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1871 (header_size, word_size): New constants.
1872 (allocate_vectorlike): Don't check size overflow here.
1873 (allocate_vector): Check it here instead, since this is the only
1874 caller of allocate_vectorlike that could cause overflow.
1875 Check that the new vector's length is representable as a fixnum.
1876
1877 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1878 The previous code was bogus. For example, next_almost_prime (32)
1879 returned 39, which is undesirable as it is a multiple of 3; and
1880 next_almost_prime (24) returned 25, which is a multiple of 5 so
1881 why was the code bothering to check for multiples of 7?
1882
1883 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1884
1885 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1886
1887 Variadic C functions now count arguments with ptrdiff_t.
1888 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1889 Back then I didn't know that the Emacs coding style prefers signed int.
1890 Also, in the meantime I found a few more instances where arguments
1891 were being counted with int, which may truncate counts on 64-bit
1892 machines, or EMACS_INT, which may be unnecessarily wide.
1893 * lisp.h (struct Lisp_Subr.function.aMANY)
1894 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1895 Arg counts are now ptrdiff_t, not size_t.
1896 All variadic functions and their callers changed accordingly.
1897 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1898 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1899 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1900 * callint.c (Fcall_interactively): Check arg count for overflow,
1901 to avoid potential buffer overrun. Use signed char, not 'int',
1902 for 'varies' array, so that we needn't bother to check its size
1903 calculation for overflow.
1904 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1905 * eval.c (apply_lambda):
1906 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1907 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1908 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1909
1910 * callint.c (Fcall_interactively): Don't use index var as event count.
1911
1912 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1913 * mem-limits.h (SIZE): Remove; no longer used.
1914
1915 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1916
1917 Remove unnecessary casts.
1918 * xterm.c (x_term_init):
1919 * xfns.c (x_set_border_pixel):
1920 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1921 These aren't needed now that we assume ANSI C.
1922
1923 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1924 It's more likely to cause problems (due to unsigned overflow)
1925 than to cure them.
1926
1927 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1928
1929 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1930
1931 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1932
1933 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1934
1935 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1936
1937 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1938
1939 GLYPH_CODE_FACE returns EMACS_INT, not int.
1940 * dispextern.h (merge_faces):
1941 * xfaces.c (merge_faces):
1942 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1943 Don't assume EMACS_INT fits in int.
1944
1945 * character.h (CHAR_VALID_P): Remove unused parameter.
1946 * fontset.c, lisp.h, xdisp.c: All uses changed.
1947
1948 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1949
1950 * fns.c (concat): Minor tuning based on overflow analysis.
1951 This doesn't fix any bugs. Use int to hold character, instead
1952 of constantly refetching from Emacs object. Use XFASTINT, not
1953 XINT, for value known to be a character. Don't bother comparing
1954 a single byte to 0400, as it's always less.
1955
1956 * floatfns.c (Fexpt):
1957 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1958
1959 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1960 for characters.
1961
1962 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1963
1964 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1965 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1966 incorrectly succeed when S was a string, because 4294967386 was
1967 truncated before it was used.
1968
1969 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1970 Otherwise, an out-of-range integer could cause undefined behavior
1971 on a 64-bit host.
1972
1973 * composite.c: Use int, not EMACS_INT, for characters.
1974 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1975 EMACS_INT, for values that are known to be in character range.
1976 This doesn't fix any bugs but is the usual style inside Emacs and
1977 may generate better code on 32-bit machines.
1978
1979 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1980 This is for reasons similar to the recent CHAR_STRING fix.
1981 * charset.c (Fencode_char): Check that character arg is actually
1982 a character. Pass an int to ENCODE_CHAR.
1983 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1984 wider than 'int', as a compile-time check to prevent future regressions
1985 in this area.
1986
1987 * character.c (char_string): Remove unnecessary casts.
1988
1989 Make sure a 64-bit char is never passed to CHAR_STRING.
1990 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1991 by silently ignoring the top 32 bits, allowing some values
1992 that were far too large to be valid characters.
1993 * character.h: Include <verify.h>.
1994 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1995 arguments are no wider than unsigned, as a compile-time check
1996 to prevent future regressions in this area.
1997 * data.c (Faset):
1998 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1999 (Fsubst_char_in_region):
2000 * fns.c (concat):
2001 * xdisp.c (decode_mode_spec_coding):
2002 Adjust to CHAR_STRING's new requirement.
2003 * editfns.c (Finsert_char, Fsubst_char_in_region):
2004 * fns.c (concat): Check that character args are actually
2005 characters. Without this test, these functions did the wrong
2006 thing with wildly out-of-range values on 64-bit hosts.
2007
2008 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2009 These casts should not be needed on 32-bit hosts, either.
2010 * keyboard.c (read_char):
2011 * lread.c (Fload): Remove casts to unsigned.
2012
2013 * lisp.h (UNSIGNED_CMP): New macro.
2014 This fixes comparison bugs on 64-bit hosts.
2015 (ASCII_CHAR_P): Use it.
2016 * casefiddle.c (casify_object):
2017 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2018 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2019 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2020 * dispextern.h (FACE_FROM_ID):
2021 * keyboard.c (read_char): Use UNSIGNED_CMP.
2022
2023 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2024 not to EMACS_INT, to avoid GCC warning.
2025
2026 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2027
2028 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2029 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2030 isn't needed on 32-bit machines.
2031
2032 * buffer.c (Fgenerate_new_buffer_name):
2033 Use EMACS_INT for count, not int.
2034 (advance_to_char_boundary): Return EMACS_INT, not int.
2035
2036 * data.c (Qcompiled_function): Now static.
2037
2038 * window.c (window_body_lines): Now static.
2039
2040 * image.c (gif_load): Rename local to avoid shadowing.
2041
2042 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2043 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2044 * alloc.c (make_save_value): Integer argument is now of type
2045 ptrdiff_t, not int.
2046 (mark_object): Use ptrdiff_t, not int.
2047 * lisp.h (pD): New macro.
2048 * print.c (print_object): Use it.
2049
2050 * alloc.c: Use EMACS_INT, not int, to count objects.
2051 (total_conses, total_markers, total_symbols, total_vector_size)
2052 (total_free_conses, total_free_markers, total_free_symbols)
2053 (total_free_floats, total_floats, total_free_intervals)
2054 (total_intervals, total_strings, total_free_strings):
2055 Now EMACS_INT, not int. All uses changed.
2056 (Fgarbage_collect): Compute overall total using a double, so that
2057 integer overflow is less likely to be a problem. Check for overflow
2058 when converting back to an integer.
2059 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2060 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2061 These were 'int' variables that could overflow on 64-bit hosts;
2062 they were never used, so remove them instead of repairing them.
2063 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2064 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2065 Previously, this ceilinged at INT_MAX, but that doesn't work on
2066 64-bit machines.
2067 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2068
2069 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2070 (allocate_vectorlike): Check for ptrdiff_t overflow.
2071 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2072 when a (possibly-narrower) signed value would do just as well.
2073 We prefer using signed arithmetic, to avoid comparison confusion.
2074
2075 * alloc.c: Catch some string size overflows that we were missing.
2076 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2077 for convenience in STRING_BYTES_MAX.
2078 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2079 The definition here is exact; the one in lisp.h was approximate.
2080 (allocate_string_data): Check for string overflow. This catches
2081 some instances we weren't catching before. Also, it catches
2082 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2083 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2084 and ptrdiff_t and EMACS_INT are both 64 bits.
2085
2086 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2087 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2088 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2089
2090 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2091
2092 * alloc.c (Fmake_string): Check for out-of-range init.
2093
2094 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2095
2096 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2097
2098 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2099
2100 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2101 xg_get_default_scrollbar_width.
2102
2103 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2104 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2105 (style_changed_cb): Call update_theme_scrollbar_width and call
2106 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2107 all frames (Bug#8505).
2108 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2109 Call gtk_window_set_resizable if HAVE_GTK3.
2110 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2111 and height if HAVE_GTK3 (Bug#8505).
2112 (scroll_bar_width_for_theme): New variable.
2113 (update_theme_scrollbar_width): New function.
2114 (xg_get_default_scrollbar_width): Move code to
2115 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2116 (xg_initialize): Call update_theme_scrollbar_width.
2117
2118 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2119
2120 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2121
2122 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2123
2124 * frame.c (make_frame): Call other_buffer_safely instead of
2125 other_buffer.
2126
2127 * window.c (temp_output_buffer_show): Call display_buffer with
2128 second argument Vtemp_buffer_show_specifiers and reset latter
2129 immediately after the call.
2130 (Vtemp_buffer_show_specifiers): New variable.
2131 (auto_window_vscroll_p, next_screen_context_lines)
2132 (Vscroll_preserve_screen_position): Remove leading asterisks from
2133 doc-strings.
2134
2135 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2136
2137 Fix minor problems found by GCC 4.6.0 static checking.
2138 * buffer.c (Qclone_number): Remove for now, as it's unused.
2139 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2140 (record_buffer): Remove unused local.
2141 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2142 (set_frame_buffer_list): Remove; unused.
2143 * frame.h (other_visible_frames): Remove decl.
2144 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2145 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2146 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2147 if HAVE_GPM.
2148 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2149 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2150 Define only if HAVE_GPM.
2151 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2152 (update_hints_inhibit): Remove; never set. All uses removed.
2153 * widgetprv.h (emacsFrameClassRec): Remove decl.
2154 * window.c (delete_deletable_window): Now returns void, since it
2155 wasn't returning anything.
2156 (compare_window_configurations): Remove unused locals.
2157 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2158 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2159 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2160 the same widths as pointers. This follows up on the 2011-05-06 patch.
2161 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2162 * xterm.h: Likewise.
2163 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2164
2165 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2166
2167 * makefile.w32-in: Update dependencies.
2168 (LISP_H): Add lib/intprops.h.
2169
2170 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2171
2172 * image.c (gif_load): Add animation frame delay to the metadata.
2173 (syms_of_image): Use DEFSYM. New symbol `delay'.
2174
2175 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2176
2177 * window.c (delete_deletable_window): Re-add.
2178 (Fset_window_configuration): Rewrite to handle dead buffers and
2179 consequently deletable windows.
2180 (window_tree, Fwindow_tree): Remove. Supply functionality in
2181 window.el.
2182 (compare_window_configurations): Simplify code.
2183
2184 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2185
2186 * image.c (imagemagick_load_image): Fix type mismatch.
2187 (Fimagemagick_types): Likewise.
2188
2189 * window.h (replace_buffer_in_windows): Declare.
2190
2191 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2192
2193 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2194 Qclone_number. Remove external declaration of Qdelete_window.
2195 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2196 code.
2197 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2198 Run Qbuffer_list_update_hook if allowed.
2199 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2200 buffer list implementation.
2201 (other_buffer_safely): New function.
2202 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2203 calls to replace_buffer_in_windows and
2204 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2205 if allowed.
2206 (record_buffer): Inhibit quitting and rewrite using quittable
2207 functions. Run Qbuffer_list_update_hook if allowed.
2208 (Frecord_buffer, Funrecord_buffer): New functions.
2209 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2210 Move switch-to-buffer to window.el.
2211 (bury-buffer): Move to window.el.
2212 (Vbuffer_list_update_hook): New variable.
2213
2214 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2215 section.
2216
2217 * window.h (resize_frame_windows): Move up in code.
2218 (Fwindow_frame): Remove EXFUN.
2219 (replace_buffer_in_all_windows): Remove prototype.
2220 (replace_buffer_in_windows_safely): Add prototype.
2221
2222 * window.c: Declare Qdelete_window static again. Move down
2223 declaration of select_count.
2224 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2225 (Fother_window): Move to window.el.
2226 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2227 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2228 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2229 window.el.
2230 (replace_buffer_in_windows): Implement by calling
2231 Qreplace_buffer_in_windows.
2232 (replace_buffer_in_all_windows): Remove with some functionality
2233 moved into replace_buffer_in_windows_safely.
2234 (replace_buffer_in_windows_safely): New function.
2235 (select_window_norecord, select_frame_norecord): Move in front
2236 of run_window_configuration_change_hook. Remove now obsolete
2237 declarations.
2238 (Fset_window_buffer): Rewrite doc-string.
2239 Call Qrecord_window_buffer.
2240 (keys_of_window): Move binding for other-window to window.el.
2241
2242 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2243
2244 * dispextern.h (struct image): Replace data member, whose int_val
2245 and ptr_val fields were not used by anything, with a single
2246 lisp_val object.
2247
2248 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2249 (gif_clear_image, gif_load, imagemagick_load_image)
2250 (gs_clear_image, gs_load): Callers changed.
2251
2252 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2253
2254 * buffer.h: Include <time.h>, for time_t.
2255 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2256
2257 Fix minor problems found by static checking.
2258
2259 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2260
2261 Make identifiers static if they are not used in other modules.
2262 * data.c (Qcompiled_function, Qframe, Qvector):
2263 * image.c (QimageMagick, Qsvg):
2264 * minibuf.c (Qmetadata):
2265 * window.c (resize_window_check, resize_root_window): Now static.
2266 * window.h (resize_window_check, resize_root_window): Remove decls.
2267
2268 * window.c (window_deletion_count, delete_deletable_window):
2269 Remove; unused.
2270 (window_body_lines): Now static.
2271 (Fdelete_other_windows_internal): Mark vars as initialized.
2272 Make sure 'resize_failed' is initialized.
2273 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2274 (resize_window_apply): Remove unused local.
2275 * window.h (delete_deletable_window): Remove decl.
2276
2277 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2278 (imagemagick_load_image): Fix pointer signedness problem by changing
2279 last arg from unsigned char * to char *. All uses changed.
2280 Also, fix a local for similar reasons.
2281 Remove unused locals. Remove locals to avoid shadowing.
2282 (fn_rsvg_handle_free): Remove; unused.
2283 (svg_load, svg_load_image): Fix pointer signedness problem.
2284 (imagemagick_load_image): Don't use garbage pointer image_wand.
2285
2286 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2287
2288 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2289
2290 * image.c (gif_load): Fix omitted cast error introduced by
2291 2011-06-06 change.
2292
2293 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2294
2295 * window.h (resize_proportionally, orig_total_lines)
2296 (orig_top_line): Remove from window structure.
2297 (set_window_height, set_window_width, change_window_heights)
2298 (Fdelete_window): Remove prototypes.
2299 (resize_frame_windows): Remove duplicate declaration.
2300
2301 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2302
2303 * window.h (resize_frame_windows, resize_window_check)
2304 (delete_deletable_window, resize_root_window)
2305 (resize_frame_windows): Declare prototypes.
2306
2307 * window.c (resize_window_apply): Make definition be "static" to
2308 match the prototype.
2309
2310 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2311
2312 * window.c: Remove declarations of Qwindow_size_fixed,
2313 window_min_size_1, window_min_size_2, window_min_size,
2314 size_window, window_fixed_size_p, enlarge_window, delete_window.
2315 Remove static from declaration of Qdelete_window, it's
2316 temporarily needed by Fbury_buffer.
2317 (replace_window): Don't assign orig_top_line and
2318 orig_total_lines.
2319 (Fdelete_window, delete_window): Remove. Window deletion is
2320 handled by window.el.
2321 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2322 Replace Fdelete_window calls with calls to Qdelete_window.
2323 (Fdelete_other_windows): Remove. Deleting other windows is
2324 handled by window.el.
2325 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2326 handled in window.el.
2327 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2328 Window minimum sizes are handled in window.el.
2329 (shrink_windows, size_window, set_window_height)
2330 (set_window_width, change_window_heights, window_height)
2331 (window_width, CURBEG, CURSIZE, enlarge_window)
2332 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2333 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2334 handled in window.el.
2335 (make_dummy_parent): Rename to make_parent_window and give it a
2336 second argument horflag.
2337 (make_window): Don't set resize_proportionally any more.
2338 (Fsplit_window): Remove. Windows are split in window.el.
2339 (save_restore_action, save_restore_orig_size)
2340 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2341 Resize mini windows in window.el.
2342 (grow_mini_window, shrink_mini_window): Implement by calling
2343 Qresize_root_window_vertically, resize_window_check and
2344 resize_window_apply.
2345 (saved_window, Fset_window_configuration, save_window_save):
2346 Do not handle orig_top_line, orig_total_lines, and
2347 resize_proportionally.
2348 (window_min_height, window_min_width): Move to window.el.
2349 (keys_of_window): Move bindings for delete-other-windows,
2350 split-window, delete-window and enlarge-window to window.el.
2351
2352 * buffer.c: Temporarily extern Qdelete_window.
2353 (Fbury_buffer): Temporarily call Qdelete_window instead of
2354 Fdelete_window (Fbury_buffer will move to window.el soon).
2355
2356 * frame.c (set_menu_bar_lines_1): Remove code handling
2357 orig_top_line and orig_total_lines.
2358
2359 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2360 set_window_height but set heights directly.
2361 (change_frame_size_1): Use resize_frame_windows.
2362
2363 * xdisp.c (init_xdisp): Don't use set_window_height but set
2364 heights directly.
2365
2366 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2367 Use resize_frame_windows instead of change_window_heights and run
2368 run_window_configuration_change_hook.
2369
2370 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2371 instead of change_window_heights and run
2372 run_window_configuration_change_hook.
2373
2374 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2375
2376 * window.c (replace_window): Rename second argument REPLACEMENT to
2377 NEW. New third argument SETFLAG. Rewrite.
2378 (delete_window, make_dummy_parent): Call replace_window with
2379 third argument 1.
2380 (window_list_1): Move down in code.
2381 (run_window_configuration_change_hook): Move set_buffer part
2382 before select_frame_norecord part in order to unwind correctly.
2383 Rename count1 to count.
2384 (recombine_windows, delete_deletable_window, resize_root_window)
2385 (Fdelete_other_windows_internal)
2386 (Frun_window_configuration_change_hook, make_parent_window)
2387 (resize_window_check, resize_window_apply, Fresize_window_apply)
2388 (resize_frame_windows, Fsplit_window_internal)
2389 (Fdelete_window_internal, Fresize_mini_window_internal):
2390 New functions.
2391 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2392
2393 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2394
2395 * window.h (window): Add some new members to window structure -
2396 normal_lines, normal_cols, new_total, new_normal, clone_number,
2397 splits, nest, prev_buffers, next_buffers.
2398 (WINDOW_TOTAL_SIZE): Move here from window.c.
2399 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2400
2401 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2402 Remove.
2403 (make_dummy_parent): Set new members of windows structure.
2404 (make_window): Move down in code. Handle new members of window
2405 structure.
2406 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2407 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2408 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2409 (Fset_window_prev_buffers, Fwindow_next_buffers)
2410 (Fset_window_next_buffers, Fset_window_clone_number):
2411 New functions.
2412 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2413 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2414 Doc-string fixes.
2415 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2416 Argument WINDOW can be now internal window too.
2417 (Fwindow_use_time): Move up in code.
2418 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2419 Rewrite doc-string.
2420 (Fset_window_configuration, saved_window)
2421 (Fcurrent_window_configuration, save_window_save): Handle new
2422 members of window structure.
2423 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2424 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2425 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2426 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2427 Qget_mru_window, Qresize_root_window,
2428 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2429 Qauto_buffer_name; staticpro them.
2430
2431 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2432
2433 * window.c (Fwindow_total_size, Fwindow_left_column)
2434 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2435 (Fwindow_list_1): New functions.
2436 (window_box_text_cols): Replace with window_body_cols.
2437 (Fwindow_width, Fscroll_left, Fscroll_right):
2438 Use window_body_cols instead of window_box_text_cols.
2439 (delete_window, Fset_window_configuration):
2440 Call delete_all_subwindows with window as argument.
2441 (delete_all_subwindows): Take a window as argument and not a
2442 structure. Rewrite.
2443 (window_loop): Remove handling of GET_LRU_WINDOW and
2444 GET_LARGEST_WINDOW.
2445 (Fget_lru_window, Fget_largest_window): Move to window.el.
2446
2447 * window.h: Extern window_body_cols instead of
2448 window_box_text_cols. delete_all_subwindows now takes a
2449 Lisp_Object as argument.
2450
2451 * indent.c (compute_motion, Fcompute_motion):
2452 Use window_body_cols instead of window_box_text_cols.
2453
2454 * frame.c (delete_frame): Call delete_all_subwindows with root
2455 window as argument.
2456
2457 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2458
2459 * fns.c (Fputhash): Document return value.
2460
2461 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2462
2463 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2464
2465 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2466
2467 Cons<->int and similar integer overflow fixes (Bug#8794).
2468
2469 Check for overflow when converting integer to cons and back.
2470 * charset.c (Fdefine_charset_internal, Fdecode_char):
2471 Use cons_to_unsigned to catch overflow.
2472 (Fencode_char): Use INTEGER_TO_CONS.
2473 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2474 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2475 * data.c (long_to_cons, cons_to_long): Remove.
2476 (cons_to_unsigned, cons_to_signed): New functions.
2477 These signal an error for invalid or out-of-range values.
2478 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2479 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2480 * font.c (Ffont_variation_glyphs):
2481 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2482 * lisp.h: Include <intprops.h>.
2483 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2484 (cons_to_signed, cons_to_unsigned): New decls.
2485 (long_to_cons, cons_to_long): Remove decls.
2486 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2487 (Fprimitive_undo): Use CONS_TO_INTEGER.
2488 * xfns.c (Fx_window_property): Likewise.
2489 * xselect.c: Include <limits.h>.
2490 (x_own_selection, selection_data_to_lisp_data):
2491 Use INTEGER_TO_CONS.
2492 (x_handle_selection_request, x_handle_selection_clear)
2493 (x_get_foreign_selection, Fx_disown_selection_internal)
2494 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2495 (lisp_data_to_selection_data): Use cons_to_unsigned.
2496 (x_fill_property_data): Use cons_to_signed.
2497 Report values out of range.
2498
2499 Check for buffer and string overflow more precisely.
2500 * buffer.h (BUF_BYTES_MAX): New macro.
2501 * lisp.h (STRING_BYTES_MAX): New macro.
2502 * alloc.c (Fmake_string):
2503 * character.c (string_escape_byte8):
2504 * coding.c (coding_alloc_by_realloc):
2505 * doprnt.c (doprnt):
2506 * editfns.c (Fformat):
2507 * eval.c (verror):
2508 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2509 since they may not be the same number.
2510 * editfns.c (Finsert_char):
2511 * fileio.c (Finsert_file_contents):
2512 Likewise for BUF_BYTES_MAX.
2513
2514 * image.c: Use ptrdiff_t, not int, for sizes.
2515 (slurp_file): Switch from int to ptrdiff_t.
2516 All uses changed.
2517 (slurp_file): Check that file size fits in both size_t (for
2518 malloc) and ptrdiff_t (for sanity and safety).
2519
2520 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2521 if b->modtime has its maximal value.
2522
2523 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2524
2525 Don't assume time_t can fit into int.
2526 * buffer.h (struct buffer.modtime): Now time_t, not int.
2527 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2528 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2529
2530 Minor fixes for signed vs unsigned integers.
2531 * character.h (MAYBE_UNIFY_CHAR):
2532 * charset.c (maybe_unify_char):
2533 * keyboard.c (read_char, reorder_modifiers):
2534 XINT -> XFASTINT, since the integer must be nonnegative.
2535 * ftfont.c (ftfont_spec_pattern):
2536 * keymap.c (access_keymap, silly_event_symbol_error):
2537 XUINT -> XFASTINT, since the integer must be nonnegative.
2538 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2539 since it makes no difference and we prefer signed.
2540 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2541 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2542 nonnegative.
2543
2544 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2545
2546 * window.h (Fwindow_frame): Declare.
2547
2548 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2551 (SPARE_MEMORY): Always define.
2552 (LARGE_REQUEST): Remove.
2553 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2554
2555 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2556
2557 * lisp.h: Move EXFUNS for Fframe_root_window,
2558 Fframe_first_window and Fset_frame_selected_window to window.h.
2559
2560 * window.h: Move EXFUNS for Fframe_root_window,
2561 Fframe_first_window and Fset_frame_selected_window here from
2562 lisp.h.
2563
2564 * frame.c (Fwindow_frame, Fframe_first_window)
2565 (Fframe_root_window, Fframe_selected_window)
2566 (Fset_frame_selected_window): Move to window.c.
2567 (Factive_minibuffer_window): Move to minibuf.c.
2568 (Fother_visible_frames_p): New function.
2569
2570 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2571
2572 * window.c (decode_window, decode_any_window): Move up in code.
2573 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2574 (inhibit_frame_unsplittable): Remove unused variable.
2575 (Fwindow_buffer): Move up and rewrite doc-string.
2576 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2577 (Fwindow_prev): New functions.
2578 (Fwindow_frame): Move here from frame.c. Accept any window as
2579 argument.
2580 (Fframe_root_window, Fframe_first_window)
2581 (Fframe_selected_window): Move here from frame.c. Accept frame
2582 or arbitrary window as argument. Update doc-strings.
2583 (Fminibuffer_window): Move up in code.
2584 (Fwindow_minibuffer_p): Move up in code and simplify.
2585 (Fset_frame_selected_window): Move here from frame.c.
2586 Marginal rewrite.
2587 (Fselected_window, select_window, Fselect_window): Move up in
2588 code. Minor doc-string fixes.
2589
2590 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2593 Do not assume that spare memory exists; that assumption is valid
2594 only if SYSTEM_MALLOC.
2595 (LARGE_REQUEST): New macro, so that the issue of large requests
2596 is separated from the issue of spare memory.
2597
2598 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2599
2600 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2601 format. (Bug#8806)
2602
2603 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2604
2605 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2606 before statements.
2607
2608 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2609
2610 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2611
2612 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2613
2614 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2615 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2616
2617 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2618
2619 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2620
2621 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2622
2623 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2624 (x_clipboard_manager_save): Add return value.
2625 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2626 New error handlers.
2627 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2628 Obey Vx_select_enable_clipboard_manager. Catch errors in
2629 x_clipboard_manager_save (Bug#8779).
2630 (Vx_select_enable_clipboard_manager): New variable.
2631 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2632
2633 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2634
2635 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2636
2637 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2638
2639 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2640 in the current matrix if keep_current_p is non-zero.
2641
2642 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2643
2644 * bidi.c (bidi_level_of_next_char): Fix last change.
2645
2646 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2647
2648 Support bidi reordering of text covered by display properties.
2649
2650 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2651 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2652 (bidi_cache_search, bidi_cache_iterator_state)
2653 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2654 (bidi_level_of_next_char, bidi_move_to_visually_next):
2655 Support character positions inside a run of characters covered by a
2656 display string.
2657 (bidi_paragraph_init, bidi_resolve_explicit_1)
2658 (bidi_level_of_next_char): Call bidi_fetch_char and
2659 bidi_fetch_char_advance instead of FETCH_CHAR and
2660 FETCH_CHAR_ADVANCE.
2661 (bidi_init_it): Initialize new members.
2662 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2663 definitions.
2664 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2665 instead of using explicit *_CHAR codes.
2666 (bidi_resolve_explicit, bidi_resolve_weak):
2667 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2668 bidirectional text is supported only in multibyte buffers.
2669 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2670 it to initialize the frame_window_p member of struct bidi_it.
2671 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2672 (bidi_resolve_explicit, bidi_resolve_weak)
2673 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2674 bidi_it->nchars is non-positive.
2675 (bidi_level_of_next_char): Don't try to lookup the cache for the
2676 next/previous character if nothing is cached there yet, or if we
2677 were just reseat()'ed to a new position.
2678
2679 * xdisp.c (set_cursor_from_row): Set start and stop points
2680 according to the row's direction when priming the loop that looks
2681 for the glyph on which to display cursor.
2682 (single_display_spec_intangible_p): Function deleted.
2683 (display_prop_intangible_p): Reimplement to call
2684 handle_display_spec instead of single_display_spec_intangible_p.
2685 Accept 3 additional arguments needed by handle_display_spec.
2686 This fixes incorrect cursor motion across display property with complex
2687 values: lists, `(when COND...)' forms, etc.
2688 (single_display_spec_string_p): Support property values that are
2689 lists with the argument STRING its top-level element.
2690 (display_prop_string_p): Fix the condition for processing a
2691 property that is a list to be consistent with handle_display_spec.
2692 (handle_display_spec): New function, refactored from the
2693 last portion of handle_display_prop.
2694 (compute_display_string_pos): Accept additional argument
2695 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2696 value of a `display' property is a "replacing spec".
2697 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2698 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2699 the display property, but just return a value indicating whether
2700 the display property will replace the characters it covers.
2701 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2702 frame_window_p members of struct bidi_it.
2703 (compute_display_string_pos, compute_display_string_end):
2704 New functions.
2705 (push_it): Accept second argument POSITION, where pop_it should
2706 jump to continue iteration.
2707 (reseat_1): Initialize bidi_it.disp_pos.
2708
2709 * keyboard.c (adjust_point_for_property): Adjust the call to
2710 display_prop_intangible_p to its new signature.
2711
2712 * dispextern.h (struct bidi_it): New member frame_window_p.
2713 (bidi_init_it): Update prototypes.
2714 (display_prop_intangible_p): Update prototype.
2715 (compute_display_string_pos, compute_display_string_end):
2716 Declare prototypes.
2717 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2718 EMACS_INT.
2719
2720 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2721
2722 Malloc failure behavior now depends on size of allocation.
2723 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2724 * lisp.h: Change signatures accordingly.
2725 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2726 All callers changed. (Bug#8762)
2727
2728 * gnutls.c: Use Emacs's memory allocators.
2729 Without this change, the gnutls library would invoke malloc etc.
2730 directly, which causes problems on non-SYNC_INPUT hosts, and which
2731 runs afoul of improving memory_full behavior. (Bug#8761)
2732 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2733 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2734 xfree instead of the default malloc, realloc, free.
2735 (Fgnutls_boot): No need to check for memory allocation failure,
2736 since xmalloc does that for us.
2737
2738 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2739 * category.c (hash_get_category_set):
2740 * ccl.c (ccl_driver):
2741 * charset.c (Fdefine_charset_internal):
2742 * charset.h (struct charset.hash_index):
2743 * composite.c (get_composition_id, gstring_lookup_cache)
2744 (composition_gstring_put_cache):
2745 * composite.h (struct composition.hash_index):
2746 * dispextern.h (struct image.hash):
2747 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2748 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2749 (hashfn_equal, hashfn_user_defined, make_hash_table)
2750 (maybe_resize_hash_table, hash_lookup, hash_put)
2751 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2752 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2753 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2754 * image.c (make_image, search_image_cache, lookup_image)
2755 (xpm_put_color_table_h):
2756 * lisp.h (struct Lisp_Hash_Table):
2757 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2758 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2759 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2760 * alloc.c (allocate_vectorlike):
2761 Check for overflow in vector size calculations.
2762 * ccl.c (ccl_driver):
2763 Check for overflow when converting EMACS_INT to int.
2764 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2765 need to be updated by these changes.
2766 * fns.c (make_hash_table, maybe_resize_hash_table):
2767 Check for integer overflow with large hash tables.
2768 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2769 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2770 (SXHASH_REDUCE): New macro.
2771 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2772 Use it instead of discarding useful hash info with large hash values.
2773 (sxhash_float): New function.
2774 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2775 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2776 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2777 Rewrite to use FIXNUM_BITS, as this simplifies things.
2778 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2779 Adjust signatures to match updated version of code.
2780 (consing_since_gc): Now EMACS_INT, since a single hash table can
2781 use more than INT_MAX bytes.
2782
2783 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2784
2785 Make it possible to build with GCC-4.6+ -O2 -flto.
2786
2787 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2788
2789 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2790
2791 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2792 Call minibuffer-inactive-mode.
2793
2794 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2795
2796 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2797 Update dependencies.
2798
2799 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2800
2801 * data.c (init_data): Remove code for UTS, this system is not
2802 supported anymore.
2803
2804 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2805
2806 Don't force ./temacs to start in terminal mode.
2807
2808 * frame.c (make_initial_frame): Initialize faces in all cases, not
2809 only when CANNOT_DUMP is defined.
2810 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2811
2812 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2813
2814 * dispnew.c (add_window_display_history): Use const for the string
2815 pointer. Remove declaration, not needed.
2816
2817 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2818
2819 Use 'inline', not 'INLINE'.
2820 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2821 * alloc.c, fontset.c (INLINE): Remove.
2822 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2823 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2824 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2825 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2826 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2827
2828 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2829
2830 Make it possible to run ./temacs.
2831
2832 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2833 syms_of_callproc does the same thing. Remove test for
2834 "initialized", do it in the caller.
2835 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2836
2837 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2838
2839 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2840 (read_minibuf): Use get_minibuffer.
2841 (syms_of_minibuf): Use DEFSYM.
2842 (Qmetadata): New var.
2843 * data.c (Qbuffer): Don't make it static.
2844 (syms_of_data): Use DEFSYM.
2845
2846 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2849 (CCL_CODE_MIN): New macro.
2850
2851 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2852
2853 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2854
2855 * eval.c (Qdebug): Now static.
2856 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2857 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2858 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2859
2860 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2861
2862 * image.c: Various fixes to ImageMagick code comments.
2863 (Fimagemagick_types): Doc fix.
2864
2865 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2866
2867 Minor fixes prompted by GCC 4.6.0 warnings.
2868
2869 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2870
2871 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2872 (x_clipboard_manager_save_all): Move extern decl to ...
2873 * xterm.h: ... here, so that it can be checked for consistency.
2874
2875 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2876
2877 * xselect.c (x_clipboard_manager_save_frame)
2878 (x_clipboard_manager_save_all): New functions.
2879 (Fx_clipboard_manager_save): Lisp function deleted.
2880
2881 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2882 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2883
2884 * xterm.h: Update prototype.
2885
2886 2011-05-28 William Xu <william.xwl@gmail.com>
2887
2888 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2889 exiting (Bug#8239).
2890
2891 2011-05-28 Jim Meyering <meyering@redhat.com>
2892
2893 Avoid a sign-extension bug in crypto_hash_function.
2894 * fns.c (to_uchar): Define.
2895 (crypto_hash_function): Use it to convert some newly-signed
2896 variables to unsigned, to avoid sign-extension bugs. For example,
2897 without this change, (md5 "truc") would evaluate to
2898 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2899 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2900 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2901
2902 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2903
2904 Integer overflow fixes.
2905
2906 * dbusbind.c: Serial number integer overflow fixes.
2907 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2908 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2909 to hold a serial number that is too large for a fixnum.
2910 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2911 Check for serial numbers out of range. Decode any serial number
2912 that was so large that it became a float. (Bug#8722)
2913
2914 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2915 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2916 Use XFASTINT rather than XUINT when numbers are nonnegative.
2917 (xd_append_arg, Fdbus_method_return_internal):
2918 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2919 arguments, check that Lisp number is nonnegative, rather than
2920 silently wrapping negative numbers around. (Bug#8722)
2921 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2922 (Bug#8722)
2923
2924 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2925
2926 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2927
2928 ccl: add integer overflow checks
2929 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2930 (IN_INT_RANGE): New macros.
2931 (ccl_driver): Use them to check for integer overflow when
2932 decoding a CCL program. Many of the new checks are whether XINT (x)
2933 fits in int; it doesn't always, on 64-bit hosts. The new version
2934 doesn't catch all possible integer overflows, but it's an
2935 improvement. (Bug#8719)
2936
2937 * alloc.c (make_event_array): Use XINT, not XUINT.
2938 There's no need for unsigned here.
2939
2940 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2941 This follows up to the 2011-05-06 change that substituted uintptr_t
2942 for EMACS_INT. This case wasn't caught back then.
2943
2944 Rework Fformat to avoid integer overflow issues.
2945 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2946 now (part of C89). Include <verify.h>.
2947 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2948 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2949 (Fformat): Avoid the prepass trying to compute sizes; it was only
2950 approximate and thus did not catch overflow reliably. Instead, walk
2951 through the format just once, formatting and computing sizes as we go,
2952 checking for integer overflow at every step, and allocating a larger
2953 buffer as needed. Keep track separately whether the format is
2954 multibyte. Keep only the most-recently calculated precision, rather
2955 than them all. Record whether each argument has been converted to
2956 string. Use EMACS_INT, not int, for byte and char and arg counts.
2957 Support field widths and precisions larger than INT_MAX. Avoid
2958 sprintf's undefined behavior with conversion specifications such as %#d
2959 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2960 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2961 formatting out-of-range floating point numbers with int
2962 formats. (Bug#8668)
2963
2964 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2965
2966 * data.c: Avoid integer truncation in expressions involving floats.
2967 * data.c: Include <intprops.h>.
2968 (arith_driver): When there's an integer overflow in an expression
2969 involving floating point, convert the integers to floating point
2970 so that the resulting value does not suffer from catastrophic
2971 integer truncation. For example, on a 64-bit host (* 4
2972 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2973 Do not rely on undefined behavior after integer overflow.
2974
2975 merge count_size_as_multibyte, parse_str_to_multibyte
2976 * character.c, character.h (count_size_as_multibyte):
2977 Rename from parse_str_to_multibyte; all uses changed.
2978 Check for integer overflow.
2979 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2980 since it's now a duplicate of the other. This is more of
2981 a character than a buffer op, so better that it's in character.c.
2982 * fns.c, print.c: Adjust to above changes.
2983
2984 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2985
2986 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2987
2988 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2989
2990 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2991 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2992 (x_clipboard_manager_save): Now static.
2993 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2994
2995 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2996 (crypto_hash_function): Now static.
2997 Fix pointer signedness problems. Avoid unnecessary initializations.
2998
2999 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3000
3001 * termhooks.h (Vselection_alist): Make it terminal-local.
3002
3003 * terminal.c (create_terminal): Initialize it.
3004
3005 * xselect.c: Support for clipboard managers.
3006 (Vselection_alist): Move to termhooks.h as terminal-local var.
3007 (LOCAL_SELECTION): New macro.
3008 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3009 (symbol_to_x_atom): Remove gratuitous arg.
3010 (x_handle_selection_request, lisp_data_to_selection_data)
3011 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3012 (x_own_selection, x_get_local_selection, x_convert_selection):
3013 New arg, specifying work frame. Use terminal-local Vselection_alist.
3014 (some_frame_on_display): Delete unused function.
3015 (Fx_own_selection_internal, Fx_get_selection_internal)
3016 (Fx_disown_selection_internal, Fx_selection_owner_p)
3017 (Fx_selection_exists_p): New optional frame arg.
3018 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3019 (x_handle_selection_clear): Don't treat other terminals with the
3020 same keyboard specially. Use the terminal-local Vselection_alist.
3021 (x_clear_frame_selections): Use Frun_hook_with_args.
3022
3023 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3024
3025 * xterm.h: Add support for those atoms.
3026
3027 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3028
3029 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3030 (converted_selections, conversion_fail_tag): New global variables.
3031 (x_selection_request_lisp_error): Free the above.
3032 (x_get_local_selection): Remove unnecessary code.
3033 (x_reply_selection_request): Args changed; handle arbitrary array
3034 of converted selections stored in converted_selections.
3035 Separate the XChangeProperty and SelectionNotify steps.
3036 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3037 (x_convert_selection): New function.
3038 (x_handle_selection_event): Simplify.
3039 (x_get_foreign_selection): Don't ignore incoming requests while
3040 waiting for an answer; this will fail when we implement
3041 SAVE_TARGETS, and seems unnecessary anyway.
3042 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3043 (Vx_sent_selection_functions): Doc fix.
3044
3045 2011-05-26 Leo Liu <sdl.web@gmail.com>
3046
3047 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3048
3049 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3050
3051 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3052
3053 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3054 for fringe update if it has periodic bitmap.
3055 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3056 and fringe_bitmap_periodic_p.
3057
3058 * fringe.c (get_fringe_bitmap_data): New function.
3059 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3060 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3061 row. Mark glyph row for fringe update if periodicity changed.
3062
3063 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3064 for fringe update unless it has periodic bitmap.
3065
3066 2011-05-25 Kenichi Handa <handa@m17n.org>
3067
3068 * xdisp.c (get_next_display_element): Set correct it->face_id for
3069 a static composition.
3070
3071 2011-05-24 Leo Liu <sdl.web@gmail.com>
3072
3073 * deps.mk (fns.o):
3074 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3075
3076 * fns.c (crypto_hash_function, Fsha1): New function.
3077 (Fmd5): Use crypto_hash_function.
3078 (syms_of_fns): Add Ssha1.
3079
3080 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 * gnutls.c: Remove unused macros.
3083 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3084 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3085 Remove macros that are defined and never used.
3086 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3087
3088 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3089
3090 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3091 (Fx_get_selection_internal): Minor cleanup.
3092 (Fx_own_selection_internal): Rename arguments for consistency with
3093 select.el.
3094
3095 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3096
3097 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3098
3099 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3100
3101 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3102
3103 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3104
3105 * dispnew.c (scrolling_window): Don't exclude the case that the
3106 last enabled row in the desired matrix touches the bottom boundary.
3107
3108 2011-05-21 Glenn Morris <rgm@gnu.org>
3109
3110 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3111 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3112 and add some more files.
3113
3114 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3115
3116 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3117 report_file_error introduced by the change from 2011-05-07.
3118
3119 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3120
3121 * systime.h (Time): Define only if emacs is defined.
3122 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3123 where the include path doesn't have X11/X.h by default. See
3124 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3125
3126 2011-05-20 Kenichi Handa <handa@m17n.org>
3127
3128 * composite.c (find_automatic_composition): Fix previous change.
3129
3130 2011-05-20 Glenn Morris <rgm@gnu.org>
3131
3132 * lisp.mk: New file, split from Makefile.in.
3133 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3134 (shortlisp): Remove.
3135 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3136
3137 2011-05-19 Glenn Morris <rgm@gnu.org>
3138
3139 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3140 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3141 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3142 (lisp): Set the order to that of loadup.el.
3143 (shortlisp): Make it a copy of $lisp.
3144 (SOME_MACHINE_LISP): Remove.
3145 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3146 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3147
3148 2011-05-18 Kenichi Handa <handa@m17n.org>
3149
3150 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3151 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3152 (find_automatic_composition): Mostly rewrite for efficiency.
3153
3154 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3155
3156 * makefile.w32-in: Update dependencies.
3157
3158 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3159
3160 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3161 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3162
3163 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 Fix some integer overflow issues, such as string length overflow.
3166
3167 * insdel.c (count_size_as_multibyte): Check for string overflow.
3168
3169 * character.c (lisp_string_width): Check for string overflow.
3170 Use EMACS_INT, not int, for string indexes and lengths; in
3171 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3172 the resulting string length overflows an EMACS_INT; instead,
3173 report a string overflow if no precision given. When checking for
3174 precision exhaustion, use a check that cannot possibly have
3175 integer overflow. (Bug#8675)
3176 * character.h (lisp_string_width): Adjust to new signature.
3177
3178 * alloc.c (string_overflow): New function.
3179 (Fmake_string): Use it. This doesn't change behavior, but saves
3180 a few bytes and will simplify future changes.
3181 * character.c (string_escape_byte8): Likewise.
3182 * lisp.h (string_overflow): New decl.
3183
3184 Fixups, following up to the user-interface timestamp change.
3185 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3186 for UI timestamps, instead of unsigned long.
3187 * msdos.c (mouse_get_pos): Likewise.
3188 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3189 * w32gui.h (Time): Define by including "systime.h" rather than by
3190 declaring it ourselves. (Bug#8664)
3191
3192 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3193 * image.c (clear_image_cache): Likewise.
3194
3195 * term.c (term_mouse_position): Don't assume time_t wraparound.
3196
3197 Be more systematic about user-interface timestamps.
3198 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3199 and sometimes 'EMACS_UINT', to represent these timestamps.
3200 This change causes it to use 'Time' uniformly, as that's what X uses.
3201 This makes the code easier to follow, and makes it easier to catch
3202 integer overflow bugs such as Bug#8664.
3203 * frame.c (Fmouse_position, Fmouse_pixel_position):
3204 Use Time, not unsigned long, for user-interface timestamps.
3205 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3206 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3207 * keyboard.h (last_event_timestamp): Likewise.
3208 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3209 * menu.h (xmenu_show): Likewise.
3210 * term.c (term_mouse_position): Likewise.
3211 * termhooks.h (struct input_event.timestamp): Likewise.
3212 (struct terminal.mouse_position_hook): Likewise.
3213 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3214 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3215 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3216 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3217 what it was before.
3218 * menu.h, termhooks.h: Include "systime.h", for Time.
3219
3220 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3221 Don't assume that the difference between two unsigned long values
3222 can fit into an integer. At this point, we know button_down_time
3223 <= event->timestamp, so the difference must be nonnegative, so
3224 there's no need to cast the result if double-click-time is
3225 nonnegative, as it should be; check that it's nonnegative, just in
3226 case. This bug is triggered when events are more than 2**31 ms
3227 apart (about 25 days). (Bug#8664)
3228
3229 * xselect.c (last_event_timestamp): Remove duplicate decl.
3230 (x_own_selection): Remove needless cast to unsigned long.
3231
3232 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3233 that always fit in int. Use a sentinel instead of a counter, to
3234 avoid a temp and to allay GCC's concerns about possible int overflow.
3235 * frame.h (struct frame): Use int for menu_bar_items_used
3236 instead of EMACS_INT, since it always fits in int.
3237
3238 * menu.c (grow_menu_items): Check for int overflow.
3239
3240 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3241
3242 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3243 Before, the code was not consistent. These values cannot exceed
3244 2**31 - 1 so there's no need to make them unsigned.
3245 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3246 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3247 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3248 as modifiers.
3249 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3250
3251 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3252 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3253 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3254 presumably because the widths might not match.
3255
3256 * window.c (size_window): Avoid needless test at loop start.
3257
3258 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3259
3260 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3261
3262 2011-05-12 Drew Adams <drew.adams@oracle.com>
3263
3264 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3265
3266 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3267
3268 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3269 `width' to `bar_area_x' and `bar_area_width', respectively.
3270 (x_scroll_run): Take account of fringe background extension.
3271
3272 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3273 Rename local vars `left' and `width' to `bar_area_x' and
3274 `bar_area_width', respectively.
3275 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3276 background extension.
3277
3278 2011-05-10 Jim Meyering <meyering@redhat.com>
3279
3280 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3281
3282 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3283
3284 * image.c (Finit_image_library): Return t for built-in image types,
3285 like pbm and xbm. (Bug#8640)
3286
3287 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3288
3289 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3290
3291 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3292
3293 * w32console.c (Fset_screen_color): Doc fix.
3294 (Fget_screen_color): New function.
3295 (syms_of_ntterm): Defsubr it.
3296
3297 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3298 unlink the temporary file if Fcall_process didn't create it in the
3299 first place.
3300 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3301 child process will be redirected to a file specified with `:file'.
3302 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3303 cue to call_process_cleanup not to close that handle.
3304
3305 2011-05-07 Ben Key <bkey76@gmail.com>
3306
3307 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3308 one of two shell specific rules, either bootstrap-temacs-CMD or
3309 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3310 to the previous implementation of the bootstrap-temacs rule.
3311 The bootstrap-temacs-CMD rule is similar to the previous
3312 implementation of the bootstrap-temacs rule except that it
3313 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3314 variable.
3315
3316 These changes, along with some changes to nt/configure.bat,
3317 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3318 earlier fix to add support for --cflags and --ldflags options
3319 that include quotes so that it works whether make uses cmd or
3320 sh as the shell.
3321
3322 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3323
3324 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3325 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3326 is a constant.
3327 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3328 a string. Handle both cases.
3329 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3330 (Fdbus_register_method): Use Qinvalid_function.
3331
3332 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3333
3334 * makefile.w32-in: Update dependencies.
3335 (LISP_H): Add inttypes.h and stdin.h.
3336 (PROCESS_H): Add unistd.h.
3337
3338 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3339
3340 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3341 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3342
3343 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3346
3347 * term.c (vfatal): Remove stray call to va_end.
3348 It's not needed and the C Standard doesn't allow it here anyway.
3349
3350 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3351 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3352
3353 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3354 bytes.
3355
3356 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3357
3358 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3359
3360 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3361
3362 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3363
3364 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3365
3366 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3367 * charset.c (Fdefine_charset_internal): Don't initialize
3368 charset.code_space[15]. The value was garbage, on hosts with
3369 32-bit int (Bug#8600).
3370
3371 * lread.c (read_integer): Be more consistent with string-to-number.
3372 Use string_to_number to do the actual conversion; this avoids
3373 rounding errors and fixes some other screwups. Without this fix,
3374 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3375 (digit_to_number): Move earlier, for benefit of read_integer.
3376 Return -1 if the digit is out of range for the base, -2 if it is
3377 not a digit in any supported base. (Bug#8602)
3378
3379 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3380
3381 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3382 to match comment at start of function. This also removes a
3383 GCC warning about overflow in a 32+64-bit port.
3384
3385 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3386
3387 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3388 Reported by Stefan Monnier in
3389 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3390 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3391 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3392
3393 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3394 (EMACS_UINTPTR): Likewise, with uintptr_t.
3395
3396 * lisp.h: Prefer 64-bit EMACS_INT if available.
3397 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3398 on 32-bit hosts that have 64-bit int, so that they can access
3399 large files.
3400 However, temporarily disable this change unless the temporary
3401 symbol WIDE_EMACS_INT is defined.
3402
3403 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3404
3405 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3406 This removes an assumption that EMACS_INT and long are the same
3407 width as pointers. The assumption is true for Emacs porting targets
3408 now, but we want to make other targets possible.
3409 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3410 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3411 In the rest of the code, change types of integers that hold casted
3412 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3413 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3414 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3415 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3416 No need to cast type when ORing.
3417 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3418 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3419 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3420 assume EMACS_INT is the same width as char *.
3421 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3422 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3423 Remove no-longer-needed casts.
3424 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3425 (xg_tool_bar_help_callback, xg_make_tool_item):
3426 Use EMACS_INTPTR to hold an integer
3427 that will be cast to void *; this can avoid a GCC warning
3428 if EMACS_INT is not the same width as void *.
3429 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3430 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3431 (current_message_1, set_message_1):
3432 Use a local to convert to proper width without a cast.
3433 * xmenu.c (dialog_selection_callback): Likewise.
3434
3435 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3436 Also, don't assume VALBITS / RAND_BITS is less than 5,
3437 and don't rely on undefined behavior when shifting a 1 left into
3438 the sign bit.
3439 * lisp.h (get_random): Change signature to match.
3440
3441 * lread.c (hash_string): Use size_t, not int, for hash computation.
3442 Normally we prefer signed values; but hashing is special, because
3443 it's better to use unsigned division on hash table sizes so that
3444 the remainder is nonnegative. Also, size_t is the natural width
3445 for hashing into memory. The previous code used 'int', which doesn't
3446 retain enough info to hash well into very large tables.
3447 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3448
3449 * dbusbind.c: Don't possibly lose pointer info when converting.
3450 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3451 Use XPNTR rather than XHASH, so that the high-order bits of
3452 the pointer aren't lost when converting through void *.
3453
3454 * eval.c (Fautoload): Don't double-shift a pointer.
3455
3456 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3457
3458 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3459
3460 * gnutls.c (DEF_GNUTLS_FN):
3461 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3462
3463 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3464
3465 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3466 marker. (Bug#8610)
3467
3468 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3469
3470 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3471 New version that can reserve upto 2GB of heap space.
3472
3473 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3474
3475 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3476
3477 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3478
3479 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3480 `gnutls_certificate_set_x509_key_file'.
3481
3482 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3483
3484 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3485 Update dependencies.
3486
3487 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3488
3489 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3490 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3491 Remove unused parameter `fildes'.
3492 * process.c (read_process_output, send_process): Don't pass it.
3493
3494 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3495
3496 Fix previous change: the library cache is defined in w32.c.
3497 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3498 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3499
3500 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3501
3502 Implement dynamic loading of GnuTLS on Windows.
3503
3504 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3505 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3506 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3507 Declare.
3508
3509 * gnutls.c (Qgnutls_dll): Define.
3510 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3511 (gnutls_*): Declare function pointers.
3512 (init_gnutls_functions): New function to initialize function pointers.
3513 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3514 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3515 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3516 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3517 (emacs_gnutls_write, emacs_gnutls_read)
3518 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3519 (Fgnutls_available_p): New function.
3520 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3521 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3522 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3523
3524 * image.c: Include w32.h.
3525 (Vimage_type_cache): Delete.
3526 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3527 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3528 (w32_delayed_load): Move to w32.c.
3529
3530 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3531
3532 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3533 (w32_delayed_load): Move from image.c. When loading a library, record
3534 its filename in the :loaded-from property of the library id.
3535 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3536 Initialize and staticpro them.
3537 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3538
3539 * process.c: Include lisp.h before w32.h, not after.
3540 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3541 instead of gnutls_record_check_pending.
3542
3543 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3544
3545 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3546
3547 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3548 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3549 as passed in.
3550
3551 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3552
3553 * xterm.c (x_set_frame_alpha): Do not set property on anything
3554 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3555
3556 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3557
3558 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3559
3560 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3561
3562 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3563 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3564 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3565 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3566 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3567 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3568 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3569 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3570 (Qgnutls_bootprop_callbacks_verify): Make static.
3571
3572 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3573
3574 * callproc.c: Indentation fixup.
3575
3576 * sysdep.c (wait_for_termination_1): Make static.
3577 (wait_for_termination, interruptible_wait_for_termination):
3578 Move after wait_for_termination_1.
3579
3580 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3581
3582 * sysdep.c (interruptible_wait_for_termination): New function
3583 which is like wait_for_termination, but allows keyboard
3584 interruptions.
3585
3586 * callproc.c (Fcall_process): Add (:file "file") as an option for
3587 the STDOUT buffer.
3588 (Fcall_process_region): Ditto.
3589
3590 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3591
3592 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3593 rather than `XVECTOR (FOO)->size'.
3594
3595 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3596 inttypes.h, as a gnulib replacement is used if it not available in
3597 system headers.
3598
3599 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3600
3601 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3602 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3603 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3604
3605 * coding.c (coding_alloc_by_realloc): Error out if destination
3606 will grow beyond MOST_POSITIVE_FIXNUM.
3607 (decode_coding_emacs_mule): Abort if there isn't enough place in
3608 charbuf for the composition carryover bytes. Reserve an extra
3609 space for up to 2 characters produced in a loop.
3610 (decode_coding_iso_2022): Abort if there isn't enough place in
3611 charbuf for the composition carryover bytes.
3612
3613 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3614
3615 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3616 aborting when %lld or %lll format is passed.
3617 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3618 %llo or %llx format is passed. (Bug#8545)
3619
3620 * window.c (window_scroll_line_based): Use a marker instead of
3621 simple variables to record original value of point. (Bug#7952)
3622
3623 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3624 produced by %s or %c overflows available buffer space. (Bug#8545)
3625
3626 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3627
3628 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3629 (SIZE_MAX): Move defn after all includes, as they might #define it.
3630
3631 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3632
3633 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3634
3635 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3636
3637 * keyboard.c (Qdelayed_warnings_hook): Define.
3638 (command_loop_1): Run `delayed-warnings-hook'
3639 if Vdelayed_warnings_list is non-nil.
3640 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3641 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3642
3643 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3644
3645 * doprnt.c (doprnt): Don't return value smaller than the buffer
3646 size if the message was truncated. (Bug#8545).
3647
3648 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3649
3650 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3651 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3652
3653 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3654
3655 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3656
3657 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3658
3659 * makefile.w32-in: Update dependencies.
3660
3661 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3662
3663 Improve `doprnt' and its usage. (Bug#8545)
3664 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3665 `format_end'. Remove support for %l as a conversion specifier.
3666 Don't use xrealloc. Improve diagnostics when the %l size modifier
3667 is used. Update the commentary.
3668
3669 * eval.c (verror): Simplify calculation of size_t.
3670
3671 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3672 messages.
3673
3674 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3675
3676 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3677 change.
3678
3679 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3680
3681 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3682 This makes this file independent of the recent pseudovector change.
3683
3684 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3685
3686 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3687
3688 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3689 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3690 Remove unused local.
3691 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3692
3693 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3694 GCC 4.6.0 optimizes based on type-based alias analysis.
3695 For example, if b is of type struct buffer * and v of type struct
3696 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3697 != &v->size, and therefore "v->size = 1; b->size = 2; return
3698 v->size;" must therefore return 1. This assumption is incorrect
3699 for Emacs, since it type-puns struct Lisp_Vector * with many other
3700 types. To fix this problem, this patch adds a new type struct
3701 vectorlike_header that documents the constraints on layout of vectors
3702 and pseudovectors, and helps optimizing compilers not get fooled
3703 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3704 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3705 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3706 the size member.
3707 (XSETPVECTYPE): Rewrite in terms of new macro.
3708 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3709 This is a bit clearer, and further avoids the possibility of
3710 undesirable aliasing.
3711 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3712 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3713 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3714 since Lisp_Subr is a special case (no "next" field).
3715 (ASIZE): Now uses header.size rather than size.
3716 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3717 to avoid the hassle of writing XVECTOR (foo)->header.size.
3718 (struct vectorlike_header): New type.
3719 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3720 object, to help avoid aliasing.
3721 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3722 (SUBRP): Likewise, since Lisp_Subr is a special case.
3723 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3724 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3725 (struct Lisp_Hash_Table): Combine first two members into a single
3726 struct vectorlike_header member. All uses of "size" and "next" members
3727 changed to be "header.size" and "header.next".
3728 * buffer.h (struct buffer): Likewise.
3729 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3730 * frame.h (struct frame): Likewise.
3731 * process.h (struct Lisp_Process): Likewise.
3732 * termhooks.h (struct terminal): Likewise.
3733 * window.c (struct save_window_data, struct saved_window): Likewise.
3734 * window.h (struct window): Likewise.
3735 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3736 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3737 * buffer.c (init_buffer_once): Likewise.
3738 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3739 special case.
3740 * process.c (Fformat_network_address): Use local var for size,
3741 for brevity.
3742
3743 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3744
3745 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3746 * data.c (atof): Remove decl; no longer used or needed.
3747 (digit_to_number): Move to lread.c.
3748 (Fstring_to_number): Use new string_to_number function, to be
3749 consistent with how the Lisp reader treats infinities and NaNs.
3750 Do not assume that floating-point numbers represent EMACS_INT
3751 without losing information; this is not true on most 64-bit hosts.
3752 Avoid double-rounding errors, by insisting on integers when
3753 parsing non-base-10 numbers, as the documentation specifies.
3754 * lisp.h (string_to_number): New decl, replacing ...
3755 (isfloat_string): Remove.
3756 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3757 (read1): Do not accept +. and -. as integers; this
3758 appears to have been a coding error. Similarly, do not accept
3759 strings like +-1e0 as floating point numbers. Do not report
3760 overflow for integer overflows unless the base is not 10 which
3761 means we have no simple and reliable way to continue.
3762 Break out the floating-point parsing into a new
3763 function string_to_number, so that Fstring_to_number parses
3764 floating point numbers consistently with the Lisp reader.
3765 (digit_to_number): Move here from data.c. Make it static inline.
3766 (E_CHAR, EXP_INT): Remove, replacing with ...
3767 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3768 (string_to_number): New function, replacing isfloat_string.
3769 This function checks for valid syntax and produces the resulting
3770 Lisp float number too. Rework it so that string-to-number
3771 no longer mishandles examples like "1.0e+". Use strtoumax,
3772 so that overflow for non-base-10 numbers is reported only when
3773 there's no portable and simple way to convert to floating point.
3774
3775 * textprop.c (set_text_properties_1): Rewrite for clarity,
3776 and to avoid GCC warning about integer overflow.
3777
3778 * intervals.h (struct interval): Use EMACS_INT for members
3779 where EMACS_UINT might cause problems. See
3780 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3781 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3782 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3783 All uses changed.
3784 (offset_intervals): Tell GCC not to worry about length overflow
3785 when negating a negative length.
3786
3787 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3788 (overrun_check_free): Likewise.
3789
3790 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3791 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3792 word size.
3793
3794 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3795 (gnutls_make_error): Rename local to avoid shadowing.
3796 (gnutls_emacs_global_deinit): ifdef out; not used.
3797 (Fgnutls_boot): Use const for pointer to readonly storage.
3798 Comment out unused local. Fix pointer signedness problems.
3799
3800 * lread.c (openp): Don't stuff size_t into an 'int'.
3801 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3802 about possible signed overflow.
3803
3804 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3805 (GDK_KEY_g): Don't define if already defined.
3806 (xg_prepare_tooltip): Avoid pointer signedness problem.
3807 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3808
3809 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3810 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3811
3812 * xfns.c (Fx_window_property): Simplify a bit,
3813 to make a bit faster and to avoid GCC 4.6.0 warning.
3814 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3815
3816 * fns.c (internal_equal): Don't assume size_t fits in int.
3817
3818 * alloc.c (compact_small_strings): Tighten assertion a little.
3819
3820 Replace pEd with more-general pI, and fix some printf arg casts.
3821 * lisp.h (pI): New macro, generalizing old pEd macro to other
3822 conversion specifiers. For example, use "...%"pI"d..." rather
3823 than "...%"pEd"...".
3824 (pEd): Remove. All uses replaced with similar uses of pI.
3825 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3826 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3827 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3828 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3829 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3830 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3831 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3832 64-bit hosts.
3833 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3834 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3835 * print.c (safe_debug_print, print_object): Likewise.
3836 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3837 to int.
3838 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3839 avoiding the 0 flag, which is not portable.
3840 * process.c (Fmake_network_process): Use pI to avoid cast.
3841 * region-cache.c (pp_cache): Likewise.
3842 * xdisp.c (decode_mode_spec): Likewise.
3843 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3844 behavior on 64-bit hosts with printf arg.
3845 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3846 (x_stop_queuing_selection_requests): Likewise.
3847 (x_get_window_property): Don't truncate byte count to an 'int'
3848 when tracing.
3849
3850 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3851 here, since it parses constructs like leading '-' and spaces,
3852 which are not wanted; and it overflows with large numbers.
3853 Instead, simply match F[0-9]+, which is what is wanted anyway.
3854
3855 * alloc.c: Remove unportable assumptions about struct layout.
3856 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3857 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3858 (allocate_vectorlike, make_pure_vector): Use the new macros,
3859 plus offsetof, to remove unportable assumptions about struct layout.
3860 These assumptions hold on all porting targets that I know of, but
3861 they are not guaranteed, they're easy to remove, and removing them
3862 makes further changes easier.
3863
3864 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3865 This doesn't fix a bug but makes the code clearer.
3866 (string_overrun_cookie): Now const. Use initializers that
3867 don't formally overflow signed char, to avoid warnings.
3868 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3869 can cause Emacs to crash when string overrun checking is enabled.
3870 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3871 multiple of sizeof (EMACS_INT); it need not be, if
3872 alignof(EMACS_INT) < sizeof (EMACS_INT).
3873 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3874
3875 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3876
3877 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3878
3879 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3880
3881 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3882 supposed to be handshaking. (Bug#8556)
3883 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3884
3885 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3886
3887 * lisp.h (Qdebug): List symbol.
3888 * eval.c (Qdebug): Restore global linkage.
3889 * keyboard.c (debug-on-event): New variable.
3890 (handle_user_signal): Break into debugger when debug-on-event
3891 matches the current signal symbol.
3892
3893 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3894
3895 * alloc.c (check_sblock, check_string_bytes)
3896 (check_string_free_list): Convert to standard C.
3897
3898 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3899
3900 * w32.c (emacs_gnutls_push): Fix typo.
3901
3902 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3903
3904 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3905 "cast to pointer from integer of different size".
3906
3907 Improve doprnt and its use in verror. (Bug#8545)
3908 * doprnt.c (doprnt): Document the set of format control sequences
3909 supported by the function. Use SAFE_ALLOCA instead of always
3910 using `alloca'.
3911
3912 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3913 is one byte too soon. Don't use xrealloc; instead xfree and
3914 xmalloc anew.
3915
3916 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3917
3918 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3919 callbacks stage.
3920
3921 * gnutls.c: Renamed global_initialized to
3922 gnutls_global_initialized. Added internals for the
3923 :verify-hostname-error, :verify-error, and :verify-flags
3924 parameters of `gnutls-boot' and documented those parameters in the
3925 docstring. Start callback support.
3926 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3927 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3928 on error. Return error code.
3929 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3930 (emacs_gnutls_read): Likewise.
3931 (Fgnutls_boot): Return handshake error code.
3932 (emacs_gnutls_handle_error): New function.
3933 (wsaerror_to_errno): Likewise.
3934
3935 * w32.h (emacs_gnutls_pull): Add prototype.
3936 (emacs_gnutls_push): Likewise.
3937
3938 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3939 (emacs_gnutls_push): Likewise.
3940
3941 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3942
3943 * process.c (wait_reading_process_output): Check if GnuTLS
3944 buffered some data internally if no FDs are set for TLS
3945 connections.
3946
3947 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3948 (LIBS): Link to USER_LIBS.
3949 ($(BLD)/gnutls.$(0)): New target.
3950
3951 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3952
3953 * xdisp.c (handle_single_display_spec): Rename the
3954 display_replaced_before_p argument into display_replaced_p, to
3955 make it consistent with the commentary. Fix typos in the
3956 commentary.
3957
3958 * textprop.c (syms_of_textprop): Remove dead code.
3959 (copy_text_properties): Delete obsolete commentary about an
3960 interface that was deleted long ago. Fix typos in the description
3961 of arguments.
3962
3963 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3964 to changes in oldXMenu/XMenu.h from 2011-04-16.
3965 <menu_help_message, prev_menu_help_message>: Constify.
3966 (IT_menu_make_room): menu->help_text is now `const char **';
3967 adjust.
3968
3969 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3970 to changes in oldXMenu/XMenu.h from 2011-04-16.
3971 (struct XMenu): Declare `help_text' `const char **'.
3972
3973 * xfaces.c <Qunspecified>: Make extern again.
3974
3975 * syntax.c: Include sys/types.h before including regex.h, as
3976 required by Posix.
3977
3978 * doc.c (get_doc_string): Improve the format passed to `error'.
3979
3980 * doprnt.c (doprnt): Improve commentary.
3981
3982 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3983
3984 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3985 them with etags.
3986
3987 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3988 changes in globals.h immediately force recompilation.
3989 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3990 $(CURDIR)/s/ms-w32.h.
3991 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3992
3993 * character.c (Fchar_direction): Function deleted.
3994 (syms_of_character): Don't defsubr it.
3995 <char-direction-table>: Deleted.
3996
3997 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3998
3999 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4000 * doprnt.c: Include limits.h.
4001 (SIZE_MAX): New macro.
4002 (doprnt): Return a size_t value. 2nd arg is now size_t.
4003 Many local variables are now size_t instead of int or unsigned.
4004 Improve overflow protection. Support `l' modifier for integer
4005 conversions. Support %l conversion. Don't assume an EMACS_INT
4006 argument for integer conversions and for %c.
4007
4008 * lisp.h (doprnt): Restore prototype.
4009
4010 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4011 $(SRC)/character.h.
4012
4013 * Makefile.in (base_obj): Add back doprnt.o.
4014
4015 * deps.mk (doprnt.o): Add back prerequisites.
4016 (callint.o): Depend on character.h.
4017
4018 * eval.c (internal_lisp_condition_case): Include the handler
4019 representation in the error message.
4020 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4021 when breaking from the loop.
4022
4023 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4024
4025 * callint.c (Fcall_interactively): When displaying error message
4026 about invalid control letter, pass the character's codepoint, not
4027 a pointer to its multibyte form. Improve display of the character
4028 in octal and display also its hex code.
4029
4030 * character.c (char_string): Use %x to display the (unsigned)
4031 codepoint of an invalid character, to avoid displaying a bogus
4032 negative value.
4033
4034 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4035 `error', not SYMBOL_NAME itself.
4036
4037 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4038 character arguments to `error'.
4039
4040 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4041 to `error' in error message about FINAL_CHAR argument. Make sure
4042 FINAL_CHAR is a character, and use %c when it is passed as
4043 argument to `error'.
4044
4045 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4046
4047 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4048
4049 * w32.c: Include <time.h>.
4050 (sys_localtime): New function.
4051
4052 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4053
4054 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4055
4056 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4057
4058 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4059
4060 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4061 zombies (Bug#8467).
4062
4063 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4064
4065 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4066 gl_state.e_property when gl_state.object is Qt.
4067
4068 * insdel.c (make_gap_larger): Remove limitation of buffer size
4069 to <= INT_MAX.
4070
4071 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4072
4073 * xdisp.c (lookup_glyphless_char_display)
4074 (produce_glyphless_glyph): Handle cons cell entry in
4075 glyphless-char-display.
4076 (Vglyphless_char_display): Document it.
4077
4078 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4079 glyphless-char-display.
4080
4081 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4082
4083 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4084
4085 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4086
4087 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4088 definition for no-X builds.
4089
4090 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4091
4092 Static checks with GCC 4.6.0 and non-default toolkits.
4093
4094 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4095
4096 * process.c (keyboard_bit_set): Define only if SIGIO.
4097 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4098 (send_process): Repair possible setjmp clobbering.
4099
4100 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4101
4102 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4103
4104 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4105
4106 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4107 Define only if needed.
4108
4109 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4110 by pacifying GCC about it. Maybe it's time to retire it?
4111 * xfaces.c (USG, __TIMEVAL__): Likewise.
4112
4113 * dispextern.h (struct redisplay_interface): Rename param
4114 to avoid shadowing.
4115 * termhooks.h (struct terminal): Likewise.
4116 * xterm.c (xembed_send_message): Likewise.
4117
4118 * insdel.c (make_gap_smaller): Define only if
4119 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4120
4121 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4122 it.
4123
4124 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4125 so that we aren't warned about unused symbols.
4126
4127 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4128
4129 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4130
4131 * xfns.c (x_real_positions): Mark locals as initialized.
4132
4133 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4134
4135 * xterm.c: Fix problems found by static analysis with other toolkits.
4136 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4137 (x_dispatch_event): Declare static if USE_GTK, and
4138 define if USE_GTK || USE_X_TOOLKIT.
4139 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4140 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4141 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4142 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4143
4144 * xmenu.c (menu_help_callback): Pointer type fixes.
4145 Use const pointers when pointing at readonly data. Avoid pointer
4146 signedness clashes.
4147 (FALSE): Remove unused macro.
4148 (update_frame_menubar): Remove unused decl.
4149
4150 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4151
4152 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4153 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4154 (single_menu_item): Rename local to avoid shadowing.
4155
4156 * keyboard.c (make_lispy_event): Remove unused local var.
4157
4158 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4159 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4160
4161 * bitmaps: Change bitmaps from unsigned char back to the X11
4162 compatible char. Avoid the old compiler warnings about
4163 out-of-range initializers by using, for example, '\xab' rather
4164 than 0xab.
4165
4166 * xgselect.c (xgselect_initialize): Check vs interface
4167 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4168
4169 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4170
4171 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4172 to read-only memory.
4173
4174 * fns.c (vector): Remove; this old hack is no longer needed.
4175
4176 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4177 Remove unused var.
4178 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4179
4180 * xrdb.c (x_load_resources): Omit unused local.
4181
4182 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4183 (x_window): Rename locals to avoid shadowing.
4184 (USG): Use the kludged USG macro, to pacify gcc.
4185
4186 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4187 (x_term_init): Remove local to avoid shadowing.
4188
4189 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4190
4191 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4192 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4193
4194 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4195
4196 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4197
4198 Fix regex.c, syntax.c and friends for buffers > 2GB.
4199 * syntax.h (struct gl_state_s): Declare character position members
4200 EMACS_INT.
4201
4202 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4203
4204 * textprop.c (verify_interval_modification, interval_of):
4205 Declare arguments EMACS_INT.
4206
4207 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4208 EMACS_INT.
4209
4210 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4211
4212 * indent.c (Fvertical_motion): Local variable it_start is now
4213 EMACS_INT.
4214
4215 * regex.c (re_match, re_match_2, re_match_2_internal)
4216 (bcmp_translate, regcomp, regexec, print_double_string)
4217 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4218 (re_compile_pattern, re_exec): Declare arguments and local
4219 variables `size_t' and `ssize_t' and return values `regoff_t', as
4220 appropriate.
4221 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4222 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4223 <compile_stack_type>: `size' and `avail' are now `size_t'.
4224
4225 * regex.h <regoff_t>: Use ssize_t, not int.
4226 (re_search, re_search_2, re_match, re_match_2): Arguments that
4227 specify buffer/string position and length are now ssize_t and
4228 size_t. Return type is regoff_t.
4229
4230 2011-04-16 Ben Key <bkey76@gmail.com>
4231
4232 * nsfont.m: Fixed bugs in ns_get_family and
4233 ns_descriptor_to_entity that were caused by using free to
4234 deallocate memory blocks that were allocated by xmalloc (via
4235 xstrdup). This caused Emacs to crash when compiled with
4236 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4237 --enable-checking=xmallocoverrun). xfree is now used to
4238 deallocate these memory blocks.
4239
4240 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
4241
4242 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4243
4244 emacs_write: Accept and return EMACS_INT for sizes.
4245 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4246 et seq.
4247 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4248 Accept and return EMACS_INT.
4249 (emacs_gnutls_write): Return the number of bytes written on
4250 partial writes.
4251 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
4252 (emacs_read, emacs_write): Remove check for negative size, as the
4253 Emacs source code has been audited now.
4254 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4255 (emacs_read, emacs_write): Use it.
4256 * process.c (send_process): Adjust to the new signatures of
4257 emacs_write and emacs_gnutls_write. Do not attempt to store
4258 a byte offset into an 'int'; it might overflow.
4259 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4260
4261 * sound.c: Don't assume sizes fit in 'int'.
4262 (struct sound_device.period_size, alsa_period_size):
4263 Return EMACS_INT, not int.
4264 (struct sound_device.write, vox_write, alsa_write):
4265 Accept EMACS_INT, not int.
4266 (wav_play, au_play): Use EMACS_INT to store sizes and to
4267 record read return values.
4268
4269 2011-04-15 Ben Key <bkey76@gmail.com>
4270
4271 * keyboard.c (Qundefined): Don't declare static since it is used
4272 in nsfns.m.
4273 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4274 static since they are used in nsfont.m.
4275
4276 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4277
4278 * process.c (Qprocessp): Don't declare static.
4279 * lisp.h (Qprocessp): Declare again.
4280
4281 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4282
4283 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4284
4285 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4286
4287 Improve C-level modularity by making more things 'static'.
4288
4289 Don't publish debugger-only interfaces to other modules.
4290 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4291 (verify_bytepos, count_markers): Move decls to the only modules
4292 that need them.
4293 * region-cache.h (pp_cache): Likewise.
4294 * window.h (check_all_windows): Likewise.
4295 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4296
4297 * sysdep.c (croak): Now static, if
4298 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4299 * syssignal.h (croak): Declare only if not static.
4300
4301 * alloc.c (refill_memory_reserve): Now static if
4302 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4303 * lisp.h (refill_memory_reserve): Declare only if not static.
4304
4305 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4306 Define only if USE_LUCID.
4307
4308 * xrdb.c (x_customization_string, x_rm_string): Now static.
4309
4310 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4311 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4312
4313 * xdisp.c (draw_row_with_mouse_face): Now static.
4314 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4315
4316 * window.h (check_all_windows): Mark externally visible.
4317
4318 * window.c (window_deletion_count): Now static.
4319
4320 * undo.c: Make symbols static if they're not exported.
4321 (last_undo_buffer, last_boundary_position, pending_boundary):
4322 Now static.
4323
4324 * textprop.c (interval_insert_behind_hooks): Now static.
4325 (interval_insert_in_front_hooks): Likewise.
4326
4327 * term.c: Make symbols static if they're not exported.
4328 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4329 (max_frame_lines, tty_set_terminal_modes):
4330 (tty_reset_terminal_modes, tty_turn_off_highlight):
4331 (get_tty_terminal): Now static.
4332 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4333 * termhooks.h (term_mouse_moveto): Do not declare if
4334 HAVE_WINDOW_SYSTEM.
4335 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4336 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4337
4338 * sysdep.c: Make symbols static if they're not exported.
4339 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4340 Now static.
4341 (sigprocmask_set, full_mask): Remove; unused.
4342 (wait_debugging): Mark as visible.
4343 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4344 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4345
4346 * syntax.c (syntax_temp): Define only if !__GNUC__.
4347
4348 * sound.c (current_sound_device, current_sound): Now static.
4349
4350 * search.c (searchbufs, searchbuf_head): Now static.
4351
4352 * scroll.c (scroll_cost): Remove; unused.
4353 * dispextern.h (scroll_cost): Remove decl.
4354
4355 * region-cache.h (pp_cache): Mark as externally visible.
4356
4357 * process.c: Make symbols static if they're not exported.
4358 (process_tick, update_tick, create_process, chan_process):
4359 (Vprocess_alist, proc_buffered_char, datagram_access):
4360 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4361 (deactivate_process): Mark defn as static, as well as decl.
4362 * lisp.h (create_process): Remove decl.
4363 * process.h (chan_process, Vprocess_alist): Remove decls.
4364
4365 * print.c: Make symbols static if they're not exported.
4366 (print_depth, new_backquote_output, being_printed, print_buffer):
4367 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4368 (print_interval, print_number_index, initial_stderr_stream):
4369 Now static.
4370 * lisp.h (Fprinc): Remove decl.
4371 (debug_output_compilation_hack): Mark as externally visible.
4372
4373 * sysdep.c (croak): Move decl from here to syssignal.h.
4374 * syssignal.h (croak): Put it here, so the API can be checked when
4375 'croak' is called from dissociate_if_controlling_tty.
4376
4377 * minibuf.c: Make symbols static if they're not exported.
4378 (minibuf_save_list, choose_minibuf_frame): Now static.
4379 * lisp.h (choose_minibuf_frame): Remove decl.
4380
4381 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4382
4383 * lread.c: Make symbols static if they're not exported.
4384 (read_objects, initial_obarray, oblookup_last_bucket_number):
4385 Now static.
4386 (make_symbol): Remove; unused.
4387 * lisp.h (initial_obarray, make_symbol): Remove decls.
4388
4389 * keyboard.c: Make symbols static if they're not exported.
4390 (single_kboard, recent_keys_index, total_keys, recent_keys):
4391 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4392 (this_single_command_key_start, echoing, last_auto_save):
4393 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4394 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4395 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4396 (Vlispy_mouse_stem, double_click_count):
4397 Now static.
4398 (force_auto_save_soon): Define only if SIGDANGER.
4399 (ignore_mouse_drag_p): Now static if
4400 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4401 (print_help): Remove; unused.
4402 (stop_character, last_timer_event): Mark as externally visible.
4403 * keyboard.h (ignore_mouse_drag_p): Declare only if
4404 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4405 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4406 * lisp.h (echoing): Remove decl.
4407 (force_auto_save_soon): Declare only if SIGDANGER.
4408 * xdisp.c (redisplay_window): Simplify code, to make it more
4409 obvious that ignore_mouse_drag_p is not accessed if !defined
4410 USE_GTK && !defined HAVE_NS.
4411
4412 * intervals.c: Make symbols static if they're not exported.
4413 (merge_properties_sticky, merge_interval_right, delete_interval):
4414 Now static.
4415 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4416
4417 * insdel.c: Make symbols static if they're not exported.
4418 However, leave prepare_to_modify_buffer alone. It's never
4419 called from outside this function, but that appears to be a bug.
4420 (combine_after_change_list, combine_after_change_buffer):
4421 (adjust_after_replace, signal_before_change): Now static.
4422 (adjust_after_replace_noundo): Remove; unused.
4423 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4424 (signal_before_change): Remove decls.
4425
4426 * indent.c (val_compute_motion, val_vmotion): Now static.
4427
4428 * image.c: Make symbols static if they're not exported.
4429 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4430 if USE_GTK.
4431 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4432 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4433
4434 * fringe.c (standard_bitmaps): Now static.
4435 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4436
4437 * frame.c: Make symbols static if they're not exported.
4438 (x_report_frame_params, make_terminal_frame): Now static.
4439 (get_frame_param): Now static, unless HAVE_NS.
4440 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4441 (x_get_resource_string): Remove; not used.
4442 * frame.h (make_terminal_frame, x_report_frame_params):
4443 (x_get_resource_string); Remove decls.
4444 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4445 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4446
4447 * font.c, fontset.c: Make symbols static if they're not exported.
4448 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4449 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4450 * font.c (font_close_object): Now static.
4451 * font.h (font_close_object): Remove.
4452 * fontset.c (FONTSET_OBJLIST): Remove.
4453 (free_realized_fontset) #if-0 the body, which does nothing.
4454 (face_suitable_for_char_p): #if-0, as it's never called.
4455 * fontset.h (face_suitable_for_char_p): Remove decl.
4456 * xfaces.c (face_at_string_position):
4457 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4458 since 0 is always ASCII.
4459
4460 * fns.c (weak_hash_tables): Now static.
4461
4462 * fileio.c: Make symbols static if they're not exported.
4463 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4464 (Vwrite_region_annotation_buffers): Now static.
4465
4466 * eval.c: Make symbols static if they're not exported.
4467 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4468 * lisp.h (backtrace_list): Remove decl.
4469
4470 * emacs.c: Make symbols static if they're not exported.
4471 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4472 (fatal_error_code, fatal_error_signal_hook, standard_args):
4473 Now static.
4474 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4475 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4476 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4477 * lisp.h (fatal_error_signal_hook): Remove decl.
4478 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4479
4480 * editfns.c: Move a (normally-unused) function to its only use.
4481 * editfns.c, lisp.h (get_operating_system_release): Remove.
4482 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4483 worth the hassle of breaking this out.
4484
4485 * xterm.c: Make symbols static if they're not exported.
4486 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4487 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4488 (x_destroy_window, x_delete_display):
4489 Now static.
4490 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4491 (x_mouse_leave): Remove; unused.
4492 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4493 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4494 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4495 Remove decls.
4496 (x_mouse_leave): Declare only if WINDOWSNT.
4497 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4498 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4499 USE_X_TOOLKIT.
4500
4501 * ftxfont.c: Make symbols static if they're not exported.
4502 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4503 HAVE_FREETYPE.
4504 * font.h (ftxfont_driver): Likewise.
4505
4506 * xfns.c: Make symbols static if they're not exported.
4507 (x_last_font_name, x_display_info_for_name):
4508 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4509 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4510 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4511 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4512 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4513 (last_show_tip_args): Now static.
4514 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4515 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4516 (x_screen_planes): Remove; unused.
4517 * dispextern.h (x_screen_planes): Remove decl.
4518
4519 * dispnew.c: Make symbols static if they're not exported.
4520 * dispextern.h (redraw_garbaged_frames, scrolling):
4521 (increment_row_positions): Remove.
4522 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4523 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4524 Now static.
4525 (redraw_garbaged_frames): Remove; unused.
4526
4527 * xfaces.c: Make symbols static if they're not exported.
4528 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4529 Remove decls.
4530 * xterm.h (defined_color): Remove decls.
4531 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4532 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4533 (menu_face_changed_default, defined_color, free_realized_face):
4534 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4535 (ascii_face_of_lisp_face): Remove; unused.
4536
4537 * xdisp.c: Make symbols static if they're not exported.
4538 * dispextern.h (scratch_glyph_row, window_box_edges):
4539 (glyph_to_pixel_coords, set_cursor_from_row):
4540 (get_next_display_element, set_iterator_to_next):
4541 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4542 (show_mouse_face): Remove decls
4543 * frame.h (message_buf_print): Likewise.
4544 * lisp.h (pop_message, set_message, check_point_in_composition):
4545 Likewise.
4546 * xterm.h (set_vertical_scroll_bar): Likewise.
4547 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4548 (message_buf_print, scratch_glyph_row, displayed_buffer):
4549 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4550 (get_next_display_element, show_mouse_face, window_box_edges):
4551 (frame_to_window_pixel_xy, check_point_in_composition):
4552 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4553 (glyph_to_pixel_coords): Remove; unused.
4554
4555 * dired.c (file_name_completion): Now static.
4556
4557 * dbusbind.c (xd_in_read_queued_messages): Now static.
4558
4559 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4560 * data.c (circular_list_error): Remove.
4561
4562 * commands.h (last_point_position, last_point_position_buffer):
4563 (last_point_position_window): Remove decls.
4564 * keyboard.c: Make these variables static.
4565
4566 * coding.h (coding, code_convert_region, encode_coding_gap):
4567 Remove decls.
4568 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4569 (iso_code_class, detect_coding, code_convert_region): Now static.
4570 (encode_coding_gap): Remove; unused.
4571
4572 * chartab.c (chartab_chars, chartab_bits): Now static.
4573
4574 * charset.h (charset_iso_8859_1): Remove decl.
4575 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4576 Now static.
4577
4578 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4579 * ccl.c (Vccl_program_table): Now static.
4580 (check_ccl_update): Remove; unused.
4581
4582 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4583 * category.h: ... from here.
4584 * category.c (check_category_table, set_category_set): Now static.
4585
4586 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4587 * lisp.h: Remove these decls.
4588
4589 * buffer.c (buffer_count): Remove unused var.
4590
4591 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4592 so that it's not optimized away.
4593 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4594 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4595 exported only to the debugger.
4596
4597 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4598 * atimer.h (run_all_atimers): Remove; not exported.
4599
4600 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4601 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4602 was inaccessible from Lisp.
4603 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4604 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4605
4606 alloc.c: Import and export fewer symbols, and remove unused items.
4607 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4608 is defined.
4609 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4610 it's not optimized away by whole-program optimization.
4611 (message_enable_multibyte, free_misc): Remove.
4612 (catchlist, handlerlist, mark_backtrace):
4613 Declare only if BYTE_MARK_STACK.
4614 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4615 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4616 (message_enable_multibyte): Remove decl.
4617 (free_misc, interval_free_list, float_block, float_block_index):
4618 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4619 (cons_free_list, last_marked_index):
4620 Now static.
4621 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4622 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4623 (mark_backtrace): Define only if BYTE_MARK_STACK.
4624 * xdisp.c (message_enable_multibyte): Now static.
4625
4626 Declare Lisp_Object Q* variables to be 'static' if not exported.
4627 This makes it easier for human readers (and static analyzers)
4628 to see whether these variables are used from other modules.
4629 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4630 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4631 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4632 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4633 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4634 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4635 * xmenu.c, xselect.c:
4636 Declare Q* vars static if they are not used in other modules.
4637 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4638 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4639 Remove decls of unexported vars.
4640 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4641
4642 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4643
4644 Make Emacs functions such as Fatom 'static' by default.
4645 This makes it easier for human readers (and static analyzers)
4646 to see whether these functions can be called from other modules.
4647 DEFUN now defines a static function. To make the function external
4648 so that it can be used in other C modules, use the new macro DEFUE.
4649 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4650 (Finit_image_library):
4651 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4652 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4653 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4654 Remove decls, since these functions are now static.
4655 (Funintern, Fget_internal_run_time): New decls, since these functions
4656 were already external.
4657
4658 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4659 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4660 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4661 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4662 * keyboard.c, keymap.c, lread.c:
4663 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4664 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4665 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4666 Mark functions with DEFUE instead of DEFUN,
4667 if they are used in other modules.
4668 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4669 decls for now-static functions.
4670 * buffer.h (Fdelete_overlay): Remove decl.
4671 * callproc.c (Fgetenv_internal): Mark as internal.
4672 * composite.c (Fremove_list_of_text_properties): Remove decl.
4673 (Fcomposition_get_gstring): New forward static decl.
4674 * composite.h (Fcomposite_get_gstring): Remove decl.
4675 * dired.c (Ffile_attributes): New forward static decl.
4676 * doc.c (Fdocumntation_property): New forward static decl.
4677 * eval.c (Ffetch_bytecode): New forward static decl.
4678 (Funintern): Remove extern decl; now in .h file where it belongs.
4679 * fileio.c (Fmake_symbolic_link): New forward static decl.
4680 * image.c (Finit_image_library): New forward static decl.
4681 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4682 * intervals.h (Fprevious_property_change):
4683 (Fremove_list_of_text_properties): Remove decls.
4684 * keyboard.c (Fthis_command_keys): Remove decl.
4685 (Fcommand_execute): New forward static decl.
4686 * keymap.c (Flookup_key): New forward static decl.
4687 (Fcopy_keymap): Now static.
4688 * keymap.h (Flookup_key): Remove decl.
4689 * process.c (Fget_process): New forward static decl.
4690 (Fprocess_datagram_address): Mark as internal.
4691 * syntax.c (Fsyntax_table_p): New forward static decl.
4692 (skip_chars): Remove duplicate decl.
4693 * textprop.c (Fprevious_property_change): New forward static decl.
4694 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4695 Now internal.
4696 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4697 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4698
4699 * editfns.c (Fformat): Remove unreachable code.
4700
4701 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4702
4703 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4704 change. (Bug#8496)
4705
4706 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4707
4708 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4709 when at ZV. (Bug#8487)
4710
4711 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4712
4713 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4714 (Bug#8437)
4715 * keyboard.c (parse_tool_bar_item): Likewise.
4716 * sound.c (sound_cleanup, alsa_close): Likewise.
4717 * termcap.c (tgetent): Likewise.
4718 * xfns.c (x_default_font_parameter): Likewise.
4719 * xsettings.c (read_and_apply_settings): Likewise.
4720
4721 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4722 (overrun_check_free): Protoize.
4723
4724 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4725
4726 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4727 since callers should never pass a negative size.
4728 Change the signature to match that of plain 'read' and 'write'; see
4729 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4730 * lisp.h: Update prototypes of emacs_write and emacs_read.
4731
4732 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4733
4734 * xdisp.c (redisplay_window): Don't try to determine the character
4735 position of the scroll margin if the window start point w->startp
4736 is outside the buffer's accessible region. (Bug#8468)
4737
4738 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4739
4740 Fix write-region and its subroutines for buffers > 2GB.
4741 * fileio.c (a_write, e_write): Modify declaration of arguments and
4742 local variables to support buffers larger than 2GB.
4743 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4744
4745 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4746 argument, local variables, and return value.
4747
4748 * lisp.h: Update prototypes of emacs_write and emacs_read.
4749
4750 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4751
4752 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4753
4754 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4755
4756 Fix more problems found by GCC 4.6.0's static checks.
4757
4758 * xdisp.c (vmessage): Use a better test for character truncation.
4759
4760 * charset.c (load_charset_map): <, not <=, for optimization,
4761 and to avoid potential problems with integer overflow.
4762 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4763 * casetab.c (set_identity, shuffle): Likewise.
4764 * editfns.c (Fformat): Likewise.
4765 * syntax.c (skip_chars): Likewise.
4766
4767 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4768 This also lets GCC 4.6.0 generate slightly better loop code.
4769
4770 * callint.c (Fcall_interactively): <, not <=, for optimization.
4771 (Fcall_interactively): Count the number of arguments produced,
4772 not the number of arguments given. This is simpler and lets GCC
4773 4.6.0 generate slightly better code.
4774
4775 * ftfont.c: Distingish more carefully between FcChar8 and char.
4776 The previous code passed unsigned char * to a functions like
4777 strlen and xstrcasecmp that expect char *, which does not
4778 conform to the C standard.
4779 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4780 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4781 char * when the C standard requires it.
4782
4783 * keyboard.c (read_char): Remove unused var.
4784
4785 * eval.c: Port to Windows vsnprintf (Bug#8435).
4786 Include <limits.h>.
4787 (SIZE_MAX): Define if the headers do not.
4788 (verror): Do not give up if vsnprintf returns a negative count.
4789 Instead, grow the buffer. This ports to Windows vsnprintf, which
4790 does not conform to C99. Problem reported by Eli Zaretskii.
4791 Also, simplify the allocation scheme, by avoiding the need for
4792 calling realloc, and removing the ALLOCATED variable.
4793
4794 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4795
4796 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4797 But keep the doprint source code for now, as we might revamp it
4798 and use it again (Bug#8435).
4799 * lisp.h (doprnt): Remove.
4800 * Makefile.in (base_obj): Remove doprnt.o.
4801 * deps.mk (doprnt.o): Remove.
4802
4803 error: Print 32- and 64-bit integers portably (Bug#8435).
4804 Without this change, on typical 64-bit hosts error ("...%d...", N)
4805 was used to print both 32- and 64-bit integers N, which relied on
4806 undefined behavior.
4807 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4808 New macro.
4809 * lisp.h (error, verror): Mark as printf-like functions.
4810 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4811 Report overflow in size calculations when allocating printf buffer.
4812 Do not truncate output string at its first null byte.
4813 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4814 Truncate the output at a character boundary, since vsnprintf does not
4815 do that.
4816 * charset.c (check_iso_charset_parameter): Convert internal
4817 character to string before calling 'error', since %c now has the
4818 printf meaning.
4819 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4820 overflow when computing char to be passed to 'error'. Do not
4821 pass Lisp_Object to 'error'; pass the integer instead.
4822 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4823 formatted with plain %d.
4824
4825 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4826
4827 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4828
4829 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4830
4831 * xterm.c (x_catch_errors): Remove duplicate declaration.
4832
4833 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4834
4835 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4836
4837 2011-04-10 Jim Meyering <meyering@redhat.com>
4838
4839 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4840 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4841 return ssize_t not "int", and use size_t as the buffer length.
4842 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4843 * gnutls.h: Update declarations.
4844 * process.c (read_process_output): Use ssize_t, to match.
4845 (send_process): Likewise.
4846
4847 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4848
4849 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4850
4851 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4852
4853 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4854 Use unsigned char, to match FcChar8 type definition.
4855
4856 * xterm.c (handle_one_xevent):
4857 * xmenu.c (create_and_show_popup_menu):
4858 * xselect.c (x_decline_selection_request)
4859 (x_reply_selection_request): Avoid type-punned deref of X events.
4860
4861 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4862
4863 Fix some uses of `int' instead of EMACS_INT.
4864 * search.c (string_match_1, fast_string_match)
4865 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4866 (scan_buffer, find_next_newline_no_quit)
4867 (find_before_next_newline, search_command, Freplace_match)
4868 (Fmatch_data): Make some `int' variables be EMACS_INT.
4869
4870 * xdisp.c (display_count_lines): 3rd argument and return value now
4871 EMACS_INT. All callers changed.
4872 (pint2hrstr): Last argument is now EMACS_INT.
4873
4874 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4875 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4876 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4877 (decode_coding_utf_16, decode_coding_emacs_mule)
4878 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4879 (decode_coding_ccl, decode_coding_charset)
4880 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4881 (decode_coding_iso_2022, decode_coding_emacs_mule)
4882 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4883 <char_offset, last_offset>: Declare EMACS_INT.
4884 (encode_coding_utf_8, encode_coding_utf_16)
4885 (encode_coding_emacs_mule, encode_invocation_designation)
4886 (encode_designation_at_bol, encode_coding_iso_2022)
4887 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4888 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4889 Declare EMACS_INT.
4890 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4891 (encode_invocation_designation): Last argument P_NCHARS is now
4892 EMACS_INT.
4893 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4894 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4895
4896 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4897 All users changed.
4898
4899 * ccl.c (Fccl_execute_on_string): Declare some variables
4900 EMACS_INT.
4901
4902 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4903
4904 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4905
4906 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4907
4908 * process.c (Fformat_network_address): Doc fix.
4909
4910 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4911
4912 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4913
4914 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4915
4916 * keyboard.c (read_char): Call Lisp function help-form-show,
4917 instead of using internal_with_output_to_temp_buffer.
4918 (Qhelp_form_show): New var.
4919 (syms_of_keyboard): Use DEFSYM macro.
4920
4921 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4922
4923 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4924
4925 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4926
4927 * process.c (Flist_processes): Remove to Lisp.
4928 (list_processes_1): Delete.
4929
4930 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4931
4932 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4933
4934 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4935
4936 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4937
4938 Fix more problems found by GCC 4.6.0's static checks.
4939
4940 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4941
4942 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4943
4944 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4945
4946 * xdisp.c (vmessage): Mark as a printf-like function.
4947
4948 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4949
4950 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4951
4952 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4953 printf-like functions.
4954 (tiff_load): Add casts to remove these marks before passing them
4955 to system-supplied API.
4956
4957 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4958
4959 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4960 This avoids several warnings with gcc -Wstrict-overflow.
4961 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4962 directly, rather than having caller test rule sign. This avoids
4963 some unnecessary tests.
4964 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4965 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4966 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4967
4968 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4969 (xfont_open): Avoid unnecessary tests.
4970
4971 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4972
4973 * composite.h, composite.c (composition_gstring_put_cache):
4974 Use EMACS_INT, not int, for length.
4975
4976 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4977 breaking out part of COMPOSITION_DECODE_RULE.
4978 (COMPOSITION_DECODE_RULE): Use it.
4979 * composite.c (get_composition_id): Remove unused local vars,
4980 by using the new macro.
4981
4982 * textprop.c (set_text_properties_1): Change while to do-while,
4983 since the condition is always true at first.
4984
4985 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4986 (interval_deletion_adjustment): Return unsigned value.
4987 All uses changed.
4988
4989 * process.c (list_processes_1, create_pty, read_process_output):
4990 (exec_sentinel): Remove vars that were set but not used.
4991 (create_pty): Remove unnecessary "volatile"s.
4992 (Fnetwork_interface_info): Avoid possibility of int overflow.
4993 (read_process_output): Do adaptive read buffering even if carryover.
4994 (read_process_output): Simplify nbytes computation if buffered.
4995
4996 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4997
4998 * syntax.c (scan_words): Remove var that was set but not used.
4999 (update_syntax_table): Use unsigned instead of int.
5000
5001 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5002 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5003 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5004
5005 * print.c (print_error_message): Avoid int overflow.
5006
5007 * font.c (font_list_entities): Redo for clarity,
5008 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5009
5010 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5011 (font_score): Avoid potential overflow in diff calculation.
5012
5013 * fns.c (substring_both): Remove var that is set but not used.
5014 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5015
5016 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5017
5018 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5019 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5020 can always succeed if overflow has undefined behavior.
5021
5022 * search.c (boyer_moore, wordify): Remove vars set but not used.
5023 (wordify): Omit three unnecessary tests.
5024
5025 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5026 All callers changed. This avoids the need for an unused var.
5027
5028 * casefiddle.c (casify_region): Remove var that is set but not used.
5029
5030 * dired.c (file_name_completion): Remove var that is set but not used.
5031
5032 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5033
5034 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5035 (Finsert_file_contents): Remove unnecessary code checking fd.
5036
5037 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5038 Check for integer overflow on size calculations.
5039
5040 * buffer.c (Fprevious_overlay_change): Remove var that is set
5041 but not used.
5042
5043 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5044 Remove vars that are set but not used.
5045 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5046 (timer_check_2): Mark vars as initialized.
5047
5048 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5049
5050 * image.c (lookup_image): Remove var that is set but not used.
5051 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5052
5053 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5054 that are set but not used.
5055
5056 * xfns.c (make_invisible_cursor): Don't return garbage
5057 if XCreateBitmapFromData fails (Bug#8410).
5058
5059 * xselect.c (x_get_local_selection, x_handle_property_notify):
5060 Remove vars that are set but not used.
5061
5062 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5063 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5064
5065 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5066 Remove var that is set but not used.
5067 (scroll_bar_windows_size): Now size_t, not int.
5068 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5069 Check for overflow.
5070
5071 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5072 (map_tty_color) [!defined MSDOS]: Likewise.
5073
5074 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5075
5076 * coding.c: Remove vars that are set but not used.
5077 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5078 All callers changed.
5079 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5080 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5081 (decode_coding_charset): Remove vars that are set but not used.
5082
5083 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5084 that is set but not used.
5085
5086 * print.c (print_object): Remove var that is set but not used.
5087
5088 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5089 The gnulib version avoids calling malloc in the usual case,
5090 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5091 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5092 * filelock.c (current_lock_owner): Likewise.
5093 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5094 * sysdep.c: Include allocator.h, careadlinkat.h.
5095 (emacs_no_realloc_allocator): New static constant.
5096 (emacs_readlink): New function.
5097 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5098 ../lib/careadlinkat.h.
5099
5100 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5101
5102 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5103 first non-nil return value).
5104
5105 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5106
5107 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5108 if not defined (Bug#8403).
5109
5110 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5111
5112 * xdisp.c (display_count_lines): Remove parameter `start',
5113 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5114 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5115 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5116 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5117 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5118 and thereabouts. All callers changed.
5119 (get_per_char_metric): Remove parameter `f', unused since
5120 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5121
5122 2011-04-02 Jim Meyering <meyering@redhat.com>
5123
5124 do not dereference NULL upon failed strdup
5125 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5126 (ns_get_family): Likewise.
5127
5128 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5129
5130 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5131
5132 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5133
5134 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5135 later (Bug#8403).
5136
5137 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5138
5139 Add lexical binding.
5140
5141 * window.c (Ftemp_output_buffer_show): New fun.
5142 (Fsave_window_excursion):
5143 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5144
5145 * lread.c (lisp_file_lexically_bound_p): New function.
5146 (Fload): Bind Qlexical_binding.
5147 (readevalloop): Remove `evalfun' arg.
5148 Bind Qinternal_interpreter_environment.
5149 (Feval_buffer): Bind Qlexical_binding.
5150 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5151 Mark as dynamic.
5152 (syms_of_lread): Declare `lexical-binding'.
5153
5154 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5155
5156 * keyboard.c (eval_dyn): New fun.
5157 (menu_item_eval_property): Use it.
5158
5159 * image.c (parse_image_spec): Use Ffunctionp.
5160
5161 * fns.c (concat, mapcar1): Accept byte-code-functions.
5162
5163 * eval.c (Fsetq): Handle lexical vars.
5164 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5165 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5166 (FletX, Flet): Obey lexical binding.
5167 (Fcommandp): Handle closures.
5168 (Feval): New `lexical' arg.
5169 (eval_sub): New function extracted from Feval. Use it almost
5170 everywhere where Feval was used. Look up vars in lexical env.
5171 Handle closures.
5172 (Ffunctionp): Move from subr.el.
5173 (Ffuncall): Handle closures.
5174 (apply_lambda): Remove `eval_flags'.
5175 (funcall_lambda): Handle closures and new byte-code-functions.
5176 (Fspecial_variable_p): New function.
5177 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5178 but without exporting it to Lisp.
5179
5180 * doc.c (Fdocumentation, store_function_docstring):
5181 * data.c (Finteractive_form): Handle closures.
5182
5183 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5184 interactive spec.
5185
5186 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5187 New byte-codes.
5188 (exec_byte_code): New function extracted from Fbyte_code to handle new
5189 calling convention for byte-code-functions. Add new byte-codes.
5190
5191 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5192
5193 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5194
5195 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5196
5197 * xdisp.c (redisplay_internal): Fix prototype.
5198
5199 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5200
5201 * xdisp.c (SCROLL_LIMIT): New macro.
5202 (try_scrolling): Use it when setting scroll_limit.
5203 Limit scrolling to 100 screen lines.
5204 (redisplay_window): Even when falling back on "recentering",
5205 position point in the window according to scroll-conservatively,
5206 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5207
5208 (try_scrolling): When point is above the window, allow searching
5209 as far as scroll_max, or one screenful, to compute vertical
5210 distance from PT to the scroll margin position. This prevents
5211 try_scrolling from unnecessarily failing when
5212 scroll-conservatively is set to a value slightly larger than the
5213 window height. Clean up the case of PT below the margin at bottom
5214 of window: scroll_max can no longer be INT_MAX. When aggressive
5215 scrolling is in use, don't let point enter the opposite scroll
5216 margin as result of the scroll.
5217 (syms_of_xdisp) <scroll-conservatively>: Document the
5218 threshold of 100 lines for never-recentering scrolling.
5219
5220 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5221
5222 * dispextern.h (move_it_by_lines):
5223 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5224 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5225 (message_log_check_duplicate): Remove parameters `prev_bol' and
5226 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5227 (redisplay_internal): Remove parameter `preserve_echo_area',
5228 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5229
5230 * indent.c (Fvertical_motion):
5231 * window.c (window_scroll_pixel_based, Frecenter):
5232 Don't pass `need_y_p' to `move_it_by_lines'.
5233
5234 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5235
5236 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5237 steal a few bits to be more compact.
5238 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5239 Remove unneeded casts.
5240
5241 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5242
5243 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5244
5245 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5246 binding" message (bug#7967).
5247
5248 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5249
5250 Fix more problems found by GCC 4.6.0's static checks.
5251
5252 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5253 Remove unused local var.
5254
5255 * editfns.c (Fmessage_box): Remove unused local var.
5256
5257 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5258 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5259 Omit unused local vars.
5260 * window.c (shrink_windows): Omit unused local var.
5261 * menu.c (digest_single_submenu): Omit unused local var.
5262 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5263 Omit unused local var.
5264
5265 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5266 Don't assume string length fits in int.
5267 (keyremap_step, read_key_sequence): Use size_t for sizes.
5268 (read_key_sequence): Don't check last_real_key_start redundantly.
5269
5270 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5271 instead of alloca (Bug#8344).
5272
5273 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5274 (Fbacktrace_frame): Don't assume nframes fits in int.
5275
5276 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5277
5278 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5279 concerns.
5280
5281 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5282
5283 * cm.c (calccost): Turn while-do into do-while, for clarity.
5284
5285 * keyboard.c (syms_of_keyboard): Use the same style as later
5286 in this function when indexing through an array. This also
5287 works around GCC bug 48267.
5288
5289 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5290
5291 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5292
5293 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5294 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5295
5296 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5297 This avoids undefined behavior on integer overflow, and is a bit
5298 more convenient anyway since it is compared to a size_t variable.
5299
5300 Variadic C functions now count arguments with size_t, not int.
5301 This avoids an unnecessary limitation on 64-bit machines, which
5302 caused (substring ...) to crash on large vectors (Bug#8344).
5303 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5304 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5305 All variadic functions and their callers changed accordingly.
5306 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5307 * data.c (arith_driver, float_arith_driver): Likewise.
5308 * editfns.c (general_insert_function): Likewise.
5309 * eval.c (struct backtrace.nargs, interactive_p)
5310 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5311 (funcall_lambda, mark_backtrace): Likewise.
5312 * fns.c (concat): Likewise.
5313 * frame.c (x_set_frame_parameters): Likewise.
5314 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5315 0 if not found, not -1. All callers changed.
5316
5317 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5318 (stack_copy_size): Now size_t, not int.
5319 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5320
5321 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5322
5323 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5324 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5325 All callers changed.
5326
5327 * lisp.h (multibyte_char_to_unibyte):
5328 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5329 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5330 * character.h (CHAR_TO_BYTE8):
5331 * cmds.c (internal_self_insert):
5332 * editfns.c (general_insert_function):
5333 * keymap.c (push_key_description):
5334 * search.c (Freplace_match):
5335 * xdisp.c (message_dolog, set_message_1): All callers changed.
5336
5337 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5338
5339 * keyboard.c (safe_run_hook_funcall): New function.
5340 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5341 don't set the hook to nil, but remove the offending function instead.
5342 (Qcommand_hook_internal): Remove, unused.
5343 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5344 Vcommand_hook_internal.
5345
5346 * eval.c (enum run_hooks_condition): Remove.
5347 (funcall_nil, funcall_not): New functions.
5348 (run_hook_with_args): Call each function through a `funcall' argument.
5349 Remove `cond' argument, now redundant.
5350 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5351 (Frun_hook_with_args_until_failure): Adjust accordingly.
5352 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5353
5354 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5355
5356 * dispextern.h (string_buffer_position): Remove declaration.
5357
5358 * print.c (strout): Remove parameter `multibyte', unused since
5359 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5360
5361 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5362 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5363 All callers changed.
5364
5365 * w32.c (_wsa_errlist): Use braces for struct initializers.
5366
5367 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5368 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5369 All callers changed.
5370 (string_buffer_position): Likewise. Also, make static (it's never
5371 used outside xdisp.c).
5372 (cursor_row_p): Remove parameter `w', unused since
5373 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5374 (decode_mode_spec): Remove parameter `precision', introduced during
5375 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5376 All callers changed.
5377
5378 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5379
5380 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5381
5382 2011-03-27 Anders Lindgren <andlind@gmail.com>
5383
5384 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5385 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5386 (ns_update_auto_hide_menu_bar): New functions.
5387 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5388 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5389 ns_constrain_all_frames.
5390 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5391 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5392
5393 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5394
5395 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5396
5397 2011-03-27 Glenn Morris <rgm@gnu.org>
5398
5399 * syssignal.h: Replace RETSIGTYPE with void.
5400 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5401 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5402 Replace SIGTYPE with void everywhere.
5403 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5404 * s/template.h (SIGTYPE): Remove commented out definition.
5405
5406 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5407
5408 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5409 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5410
5411 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5412
5413 * w32.c (read_unc_volume): Use parameter `henum', instead of
5414 global variable `wget_enum_handle'.
5415
5416 * keymap.c (describe_vector): Remove parameters `indices' and
5417 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5418 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5419
5420 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5421
5422 * keyboard.c (timer_check): Remove parameter `do_it_now',
5423 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5424 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5425 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5426
5427 * keyboard.c (read_char):
5428 * w32menu.c (w32_menu_display_help):
5429 * xmenu.c (show_help_event, menu_help_callback):
5430 Adjust calls to `show_help_echo'.
5431
5432 * gtkutil.c (xg_maybe_add_timer):
5433 * keyboard.c (readable_events):
5434 * process.c (wait_reading_process_output):
5435 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5436
5437 * insdel.c (adjust_markers_gap_motion):
5438 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5439 (gap_left, gap_right): Don't call it.
5440
5441 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5442
5443 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5444 incurred during fontification.
5445
5446 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5447
5448 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5449 (DEFVAR_PER_BUFFER): Don't pass it.
5450
5451 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5452 (scrolling_window): Don't pass it.
5453
5454 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5455
5456 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5457
5458 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5459 and `suffix'.
5460 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5461 of variables specific to SELinux and computation of `encoded_absname'.
5462
5463 * image.c (XPutPixel): Remove unused variable `height'.
5464
5465 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5466
5467 * unexw32.c (get_section_info): Remove unused variable `section'.
5468
5469 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5470 (system_process_attributes): Remove unused variable `sess'.
5471 (sys_read): Remove unused variable `err'.
5472
5473 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5474 (w32_wnd_proc): Remove unused variable `isdead'.
5475 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5476 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5477 (x_create_tip_frame): Remove unused variable `tem'.
5478
5479 * w32inevt.c (w32_console_read_socket):
5480 Remove unused variable `no_events'.
5481
5482 * w32term.c (x_draw_composite_glyph_string_foreground):
5483 Remove unused variable `width'.
5484
5485 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5486
5487 * w32term.c (x_set_glyph_string_clipping):
5488 Don't pass uninitialized region to CombineRgn.
5489
5490 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5491
5492 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5493 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5494 (Fx_close_connection): Remove unused variable `i'.
5495
5496 * w32font.c (w32font_draw): Return number of glyphs.
5497 (w32font_open_internal): Remove unused variable `i'.
5498 (w32font_driver): Add missing initializer.
5499
5500 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5501 (fill_in_menu): Remove unused variable `items_added'.
5502
5503 * w32term.c (last_mouse_press_frame): Remove static global variable.
5504 (w32_clip_to_row): Remove unused variable `f'.
5505 (x_delete_terminal): Remove unused variable `i'.
5506
5507 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5508 (NOTHING): Remove unused static global variable.
5509 (uniscribe_check_otf): Remove unused variable `table'.
5510 (uniscribe_font_driver): Add missing initializers.
5511
5512 2011-03-23 Julien Danjou <julien@danjou.info>
5513
5514 * term.c (Fsuspend_tty, Fresume_tty):
5515 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5516 * window.c (temp_output_buffer_show):
5517 * insdel.c (signal_before_change):
5518 * frame.c (Fhandle_switch_frame):
5519 * fileio.c (Fdo_auto_save):
5520 * emacs.c (Fkill_emacs):
5521 * editfns.c (save_excursion_restore):
5522 * cmds.c (internal_self_insert):
5523 * callint.c (Fcall_interactively):
5524 * buffer.c (Fkill_all_local_variables):
5525 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5526 Use Frun_hooks.
5527 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5528 unconditionnaly since it does the check itself.
5529
5530 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5531
5532 Fix more problems found by GCC 4.5.2's static checks.
5533
5534 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5535 the first time through the loop, since we know p0 < p1 then.
5536 This also avoids a gcc -Wstrict-overflow warning.
5537
5538 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5539 leading to a memory leak, possible in functions like
5540 load_charset_map_from_file that can allocate an unbounded number
5541 of objects (Bug#8318).
5542
5543 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5544 that could (at least in theory) be that large.
5545
5546 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5547 This is less likely to overflow, and avoids undefined behavior if
5548 overflow does occur. All callers changed. Use strtoul to scan
5549 for the unsigned long integer.
5550 (pint2hrstr): Simplify and tune code slightly.
5551 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5552
5553 * scroll.c (do_scrolling): Work around GCC bug 48228.
5554 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5555
5556 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5557 This also avoids a warning with gcc -Wstrict-overflow.
5558 (validate_x_resource_name): Simplify count usage.
5559 This also avoids a warning with gcc -Wstrict-overflow.
5560
5561 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5562 fail (Bug#8306).
5563
5564 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5565
5566 * process.c (Fmake_network_process): Use socklen_t, not int,
5567 where POSIX says socklen_t is required in portable programs.
5568 This fixes a porting bug on hosts like 64-bit HP-UX, where
5569 socklen_t is wider than int (Bug#8277).
5570 (Fmake_network_process, server_accept_connection):
5571 (wait_reading_process_output, read_process_output):
5572 Likewise.
5573
5574 * process.c: Rename or move locals to avoid shadowing.
5575 (list_processes_1, Fmake_network_process):
5576 (read_process_output_error_handler, exec_sentinel_error_handler):
5577 Rename or move locals.
5578 (Fmake_network_process): Define label "retry_connect" only if needed.
5579 (Fnetwork_interface_info): Fix pointer signedness.
5580 (process_send_signal): Add cast to avoid pointer signedness problem.
5581 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5582 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5583
5584 Make tparam.h and terminfo.c consistent.
5585 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5586 Include tparam.h instead, since it declares them.
5587 * cm.h (PC): Remove extern decl; tparam.h now does this.
5588 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5589 * terminfo.c: Include tparam.h, to check interfaces.
5590 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5591 (tparam): Adjust signature to match interface in tparam.h;
5592 this removes some undefined behavior. Check that outstring and len
5593 are zero, which they always are with Emacs.
5594 * tparam.h (PC, BC, UP): New extern decls.
5595
5596 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5597 (xftfont_open): Rename locals to avoid shadowing.
5598
5599 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5600 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5601 (OTF_TAG_SYM): Omit macro if not needed.
5602 (ftfont_list): Remove unused local.
5603 (get_adstyle_property, ftfont_pattern_entity):
5604 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5605 Rename locals to avoid shadowing.
5606
5607 * xfont.c (xfont_list_family): Mark var as initialized.
5608
5609 * xml.c (make_dom): Now static.
5610
5611 * composite.c (composition_compute_stop_pos): Rename local to
5612 avoid shadowing.
5613 (composition_reseat_it): Remove unused locals.
5614 (find_automatic_composition, composition_adjust_point): Likewise.
5615 (composition_update_it): Mark var as initialized.
5616 (find_automatic_composition): Mark vars as initialized,
5617 with a FIXME (Bug#8290).
5618
5619 character.h: Rename locals to avoid shadowing.
5620 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5621 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5622 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5623 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5624 to avoid shadowing.
5625
5626 * textprop.c (property_change_between_p): Remove; unused.
5627
5628 * intervals.c (interval_start_pos): Now static.
5629
5630 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5631
5632 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5633 Rename locals to avoid shadowing.
5634
5635 * sound.c (wav_play, au_play, Fplay_sound_internal):
5636 Fix pointer signedness.
5637 (alsa_choose_format): Remove unused local var.
5638 (wav_play): Initialize a variable to 0, to prevent undefined
5639 behavior (Bug#8278).
5640
5641 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5642
5643 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5644
5645 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5646 clobbering (Bug#8298).
5647 * sysdep.c (sys_subshell): Likewise.
5648 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5649
5650 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5651 This should get cleaned up, so that child_setup has the
5652 same signature on all platforms.
5653
5654 * callproc.c (call_process_cleanup): Now static.
5655 (relocate_fd): Rename locals to avoid shadowing.
5656
5657 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5658
5659 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5660 not to be necessary, and produces flickering.
5661
5662 2011-03-20 Glenn Morris <rgm@gnu.org>
5663
5664 * config.in: Remove file.
5665
5666 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5667
5668 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5669 are now in src/globals.h.
5670 (syms_of_minibuf): Remove spurious & from previous change.
5671
5672 2011-03-20 Leo <sdl.web@gmail.com>
5673
5674 * minibuf.c (completing-read-function): New variable.
5675 (completing-read-default): Rename from completing-read.
5676 (completing-read): Call completing-read-function.
5677
5678 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5679
5680 * xfaces.c (Fx_load_color_file):
5681 Read color file from absolute filename (bug#8250).
5682
5683 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5684
5685 * makefile.w32-in: Update dependencies.
5686
5687 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5688
5689 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5690
5691 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5692
5693 Fix more problems found by GCC 4.5.2's static checks.
5694
5695 * process.c (make_serial_process_unwind, send_process_trap):
5696 (sigchld_handler): Now static.
5697
5698 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5699 That way, the code declares only the vars that it needs.
5700 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5701 * s/cygwin.h (PTY_ITERATION): Likewise.
5702 * s/darwin.h (PTY_ITERATION): Likewise.
5703 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5704
5705 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5706 * process.c (allocate_pty): Don't declare stb unless it's needed.
5707
5708 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5709 (CONSTANTLIM): Remove; unused.
5710 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5711 Define only if needed.
5712
5713 * unexelf.c (unexec): Name an expression,
5714 to avoid gcc -Wbad-function-cast warning.
5715 Use a different way to cause a compilation error if anyone uses
5716 n rather than nn, a way that does not involve shadowing.
5717 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5718
5719 * deps.mk (unexalpha.o): Remove; unused.
5720
5721 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5722 * unexec.h: New file.
5723 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5724 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5725 Depend on unexec.h.
5726 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5727 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5728 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5729 Change as necessary to match prototype in unexec.h.
5730
5731 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5732 shadowing.
5733 (back_comment, skip_chars): Mark vars as initialized.
5734
5735 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5736 Rename locals to avoid shadowing.
5737
5738 * lread.c (read1): Rewrite so as not to use empty "else".
5739 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5740
5741 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5742
5743 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5744 warning when compiling print.c.
5745
5746 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5747 instead of using an uninitialized var.
5748 (font_sort_entities): Mark var as initialized.
5749
5750 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5751
5752 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5753 pointers to constants.
5754 (font_parse_fcname): Remove unused vars.
5755 (font_delete_unmatched): Now static.
5756 (font_get_spec): Remove; unused.
5757 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5758 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5759 Rename or move locals to avoid shadowing.
5760
5761 * fns.c (require_nesting_list, require_unwind): Now static.
5762 (Ffillarray): Rename locals to avoid shadowing.
5763
5764 * floatfns.c (domain_error2): Define only if needed.
5765 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5766
5767 * alloc.c (mark_backtrace): Move decl from here ...
5768 * lisp.h: ... to here, so that it can be checked.
5769
5770 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5771 (Fdefvar): Rewrite so as not to use empty "else".
5772 (lisp_indirect_variable): Name an expression,
5773 to avoid gcc -Wbad-function-cast warning.
5774 (Fdefvar): Rename locals to avoid shadowing.
5775
5776 * callint.c (quotify_arg, quotify_args): Now static.
5777 (Fcall_interactively): Rename locals to avoid shadowing.
5778 Use const pointer when appropriate.
5779
5780 * lisp.h (get_system_name, get_operating_system_release):
5781 Move decls here, to check interfaces.
5782 * process.c (get_operating_system_release): Move decl to lisp.h.
5783 * xrdb.c (get_system_name): Likewise.
5784 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5785 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5786 some of which prompt warnings from gcc -Wbad-function-cast.
5787 (Fformat_time_string, Fencode_time, Finsert_char):
5788 (Ftranslate_region_internal, Fformat):
5789 Rename or remove local vars to avoid shadowing.
5790 (Ftranslate_region_internal): Mark var as initialized.
5791
5792 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5793 avoid shadowing.
5794
5795 * lisp.h (eassert): Check that the argument compiles, even if
5796 ENABLE_CHECKING is not defined.
5797
5798 * data.c (Findirect_variable): Name an expression, to avoid
5799 gcc -Wbad-function-cast warning.
5800 (default_value, arithcompare, arith_driver, arith_error): Now static.
5801 (store_symval_forwarding): Rename local to avoid shadowing.
5802 (Fmake_variable_buffer_local, Fmake_local_variable):
5803 Mark variables as initialized.
5804 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5805
5806 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5807 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5808 Rename locals to avoid shadowing.
5809 (mark_stack): Move local variables into the #ifdef region where
5810 they're used.
5811 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5812 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5813 needed otherwise.
5814 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5815 (GC_STRING_CHARS): Remove; not used.
5816 (Fmemory_limit): Cast sbrk's returned value to char *.
5817
5818 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5819 avoids undefined behavior in theory.
5820
5821 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5822
5823 Use functions, not macros, for up- and down-casing (Bug#8254).
5824 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5825 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5826 to use the following functions instead of these macros.
5827 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5828 EMACS_INT, since callers assume the returned value fits in int.
5829 (upcase1): Likewise, for UPCASE_TABLE.
5830 (uppercasep, lowercasep, upcase): New static inline functions.
5831 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5832 the race-condition problem in the old DOWNCASE.
5833
5834 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5835 Rename locals to avoid shadowing.
5836 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5837 (regex_compile, re_search_2, re_match_2_internal):
5838 Remove unused local vars.
5839 (FREE_VAR): Rewrite so as not to use empty "else",
5840 which gcc can warn about.
5841 (regex_compile, re_match_2_internal): Mark locals as initialized.
5842 (RETALLOC_IF): Define only if needed.
5843 (WORDCHAR_P): Likewise. This one is never needed, but is used
5844 only in a comment talking about a compiler bug, so put inside
5845 the #if 0 of that comment.
5846 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5847 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5848 Remove; unused.
5849
5850 * search.c (boyer_moore): Rename locals to avoid shadowing.
5851 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5852 (PREV_CHAR_BOUNDARY): Likewise.
5853
5854 * search.c (simple_search): Remove unused var.
5855
5856 * dired.c (compile_pattern): Move decl from here ...
5857 * lisp.h: ... to here, so that it can be checked.
5858 (struct re_registers): New forward decl.
5859
5860 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5861
5862 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5863 All uses changed.
5864 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5865 Rename locals to avoid shadowing.
5866 (Fvertical_motion): Mark locals as initialized.
5867
5868 * casefiddle.c (casify_object, casify_region): Now static.
5869 (casify_region): Mark local as initialized.
5870
5871 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5872
5873 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5874 New macros, so that the caller can use some names other than
5875 gcpro1, gcpro2, etc.
5876 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5877 of the new macros.
5878 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5879 argument, for consistency with GCPRO2_VAR, etc: it is now the
5880 prefix of the variable, not the variable itself. All uses
5881 changed.
5882 * dired.c (directory_files_internal, file_name_completion):
5883 Rename locals to avoid shadowing.
5884
5885 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5886 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5887 dired.c's scmp function, had undefined behavior.
5888 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5889 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5890 * buffer.h: ... to here, because these macros use current_buffer,
5891 and the new implementation with inline functions needs to have
5892 current_buffer in scope now, rather than later when the macros
5893 are used.
5894 (downcase, upcase1): New static inline functions.
5895 (DOWNCASE, UPCASE1): Reimplement using these functions.
5896 This avoids undefined behavior in expressions like
5897 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5898 from race conditions in accessing the global variables
5899 case_temp1 and case_temp2.
5900 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5901 * lisp.h (case_temp1, case_temp2): Remove their decls.
5902 * character.h (ASCII_CHAR_P): Move from here ...
5903 * lisp.h: ... to here, so that the inline functions mentioned
5904 above can use them.
5905
5906 * dired.c (directory_files_internal_unwind): Now static.
5907
5908 * fileio.c (file_name_as_directory, directory_file_name):
5909 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5910 Now static.
5911 (file_name_as_directory): Use const pointers when appropriate.
5912 (Fexpand_file_name): Likewise. In particular, newdir might
5913 point at constant storage, so make it a const pointer.
5914 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5915 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5916 signedness issues.
5917 (Fset_file_times, Finsert_file_contents, auto_save_error):
5918 Rename locals to avoid shadowing.
5919
5920 * minibuf.c (choose_minibuf_frame_1): Now static.
5921 (Ftry_completion, Fall_completions): Rename or remove locals
5922 to avoid shadowing.
5923
5924 * marker.c (bytepos_to_charpos): Remove; unused.
5925
5926 * lisp.h (verify_bytepos, count_markers): New decls,
5927 so that gcc does not warn that these functions aren't declared.
5928
5929 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5930 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5931 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5932 (copy_text): Remove unused local var.
5933
5934 * filelock.c (within_one_second): Now static.
5935 (lock_file_1): Rename local to avoid shadowing.
5936
5937 * buffer.c (fix_overlays_before): Mark locals as initialized.
5938 (fix_start_end_in_overlays): Likewise. This function should be
5939 simplified by using pointers-to-pointers, but that's a different
5940 matter.
5941 (switch_to_buffer_1): Now static.
5942 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5943 (report_overlay_modification): Rename locals to avoid shadowing.
5944
5945 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5946 Fix pointer signedness issue.
5947 (sys_subshell): Mark local as volatile if checking for lint,
5948 to suppress a gcc -Wclobbered warning that does not seem to be right.
5949 (MAXPATHLEN): Define only if needed.
5950
5951 * process.c (serial_open, serial_configure): Move decls from here ...
5952 * systty.h: ... to here, so that they can be checked.
5953
5954 * fns.c (get_random, seed_random): Move extern decls from here ...
5955 * lisp.h: ... to here, so that they can be checked.
5956
5957 * sysdep.c (reset_io): Now static.
5958 (wait_for_termination_signal): Remove; unused.
5959
5960 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5961 (copy_keymap_item, append_key, push_text_char_description):
5962 Now static.
5963 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5964 (DENSE_TABLE_SIZE): Remove; unused.
5965 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5966 (describe_map_tree):
5967 Rename locals to avoid shadowing.
5968
5969 * keyboard.c: Declare functions static if they are not used elsewhere.
5970 (echo_char, echo_dash, cmd_error, top_level_2):
5971 (poll_for_input, handle_async_input): Now static.
5972 (read_char, kbd_buffer_get_event, make_lispy_position):
5973 (make_lispy_event, make_lispy_movement, apply_modifiers):
5974 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5975 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5976 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5977 (read_key_sequence, read_char): Mark locals as initialized.
5978 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5979
5980 * keyboard.h (make_ctrl_char): New decl.
5981 (mark_kboards): Move decl here ...
5982 * alloc.c (mark_kboards): ... from here.
5983
5984 * lisp.h (force_auto_save_soon): New decl.
5985
5986 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5987 (DEFINE_DUMMY_FUNCTION): New macro.
5988 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5989 Use it.
5990 (main): Add casts to avoid warnings
5991 if GCC considers string literals to be constants.
5992
5993 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5994
5995 * dbusbind.c: Pointer signedness fixes.
5996 (xd_signature, xd_append_arg, xd_initialize):
5997 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5998 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5999 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6000 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6001
6002 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6003 if GCC considers string literals to be constants.
6004 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6005
6006 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6007
6008 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6009 (print_preprocess, print_object): New macro to fix last change.
6010
6011 * print.c (print_preprocess): Don't forget font objects.
6012
6013 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6014
6015 * emacs.c (USAGE3): Doc fixes.
6016
6017 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6018
6019 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6020 structure.
6021
6022 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6023
6024 * lisp.h (VWindow_system, Qfile_name_history):
6025 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6026 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6027 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6028
6029 * w32select.c: Don't #include "keyboard.h".
6030 (run_protected): Add extern declaration for waiting_for_input.
6031
6032 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6033 * w32console.c (detect_input_pending, read_input_pending)
6034 (encode_terminal_code):
6035 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6036 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6037 (w32_system_caret_y, Qfile_name_history):
6038 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6039 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6040 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6041 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6042 * w32proc.c (Qlocal, report_file_error):
6043 * w32term.c (Vwindow_system, updating_frame):
6044 * w32uniscribe.c (initialized, uniscribe_font_driver):
6045 Remove unneeded extern declarations.
6046
6047 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6048
6049 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6050
6051 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6052
6053 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6054 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6055 These macros can no longer be used for assignment.
6056
6057 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6058 Assign struct members directly, instead of using BUF_BEGV etc.
6059 (record_buffer_markers, fetch_buffer_markers): New functions for
6060 recording and fetching special buffer markers.
6061 (set_buffer_internal_1, set_buffer_temp): Use them.
6062
6063 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6064
6065 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6066
6067 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6068 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6069
6070 * xdisp.c (hscroll_window_tree):
6071 (reconsider_clip_changes): Use PT instead of BUF_PT.
6072
6073 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6074
6075 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6076 $(EMACS_ROOT)/lib/intprops.h.
6077
6078 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6079
6080 Fix more problems found by GCC 4.5.2's static checks.
6081
6082 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6083 to unsigned char * to avoid compiler diagnostic.
6084 (xg_free_frame_widgets): Make it clear that a local variable is
6085 needed only if USE_GTK_TOOLTIP.
6086 (gdk_window_get_screen): Make it clear that this macro is needed
6087 only if USE_GTK_TOOLTIP.
6088 (int_gtk_range_get_value): New function, which avoids a diagnostic
6089 from gcc -Wbad-function-cast.
6090 (xg_set_toolkit_scroll_bar_thumb): Use it.
6091 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6092 diagnostic from gcc -Wbad-function-cast.
6093 (get_utf8_string, xg_get_file_with_chooser):
6094 Rename locals to avoid shadowing.
6095 (create_dialog): Move locals to avoid shadowing.
6096
6097 * xgselect.c (xg_select): Remove unused var.
6098
6099 * image.c (four_corners_best): Mark locals as initialized.
6100 (gif_load): Initialize transparent_p to zero (Bug#8238).
6101 Mark another local as initialized.
6102 (my_png_error, my_error_exit): Mark with NO_RETURN.
6103
6104 * image.c (clear_image_cache): Now static.
6105 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6106 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6107 (x_edge_detection): Remove unnecessary cast that
6108 gcc -Wbad-function-cast diagnoses.
6109 (gif_load): Fix pointer signedness.
6110 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6111 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6112
6113 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6114
6115 Improve quality of tests for time stamp overflow.
6116 For example, without this patch (encode-time 0 0 0 1 1
6117 1152921504606846976) returns the obviously-bogus value (-948597
6118 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6119 reports time overflow. See
6120 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6121 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6122 * editfns.c: Include limits.h and intprops.h.
6123 (TIME_T_MIN, TIME_T_MAX): New macros.
6124 (time_overflow): Move earlier, to before first use.
6125 (hi_time, lo_time): New functions, for an accurate test for
6126 out-of-range times.
6127 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6128 (Fget_internal_run_time): Don't assume time_t fits in int.
6129 (make_time): Use list2 instead of Fcons twice.
6130 (Fdecode_time): More accurate test for out-of-range times.
6131 (check_tm_member): New function.
6132 (Fencode_time): Use it, to test for out-of-range times.
6133 (lisp_time_argument): Don't rely on undefined left-shift and
6134 right-shift behavior when checking for time stamp overflow.
6135
6136 * editfns.c (time_overflow): New function, refactoring common code.
6137 (Fformat_time_string, Fdecode_time, Fencode_time):
6138 (Fcurrent_time_string): Use it.
6139
6140 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6141 * dired.c (make_time): Move to ...
6142 * editfns.c (make_time): ... here.
6143 * systime.h: Note the move.
6144
6145 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6146
6147 * fringe.c (update_window_fringes): Remove unused variables.
6148
6149 * unexmacosx.c (copy_data_segment): Also copy __got section.
6150 (Bug#8223)
6151
6152 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6153
6154 * termcap.c [MSDOS]: Include "msdos.h".
6155 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6156 Constify `char *' arguments and their references according to
6157 prototypes in tparam.h.
6158
6159 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6160
6161 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6162 Adapt all references accordingly.
6163
6164 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6165
6166 2011-03-11 Tom Tromey <tromey@redhat.com>
6167
6168 * buffer.c (syms_of_buffer): Remove obsolete comment.
6169
6170 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6171
6172 * termhooks.h (encode_terminal_code): Declare prototype.
6173
6174 * msdos.c (encode_terminal_code): Don't declare prototype.
6175
6176 * term.c (encode_terminal_code): Now external again, used by
6177 w32console.c and msdos.c.
6178
6179 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6180 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6181
6182 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6183
6184 Fix some minor problems found by GCC 4.5.2's static checks.
6185
6186 * fringe.c (update_window_fringes): Mark locals as initialized
6187 (Bug#8227).
6188 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6189
6190 * alloc.c (mark_fringe_data): Move decl from here ...
6191 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6192 to check its interface.
6193 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6194
6195 * fontset.c (free_realized_fontset): Now static.
6196 (Fset_fontset_font): Rename local to avoid shadowing.
6197 (fontset_font): Mark local as initialized.
6198 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6199
6200 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6201
6202 * xselect.c (x_disown_buffer_selections): Remove; not used.
6203 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
6204 (x_own_selection, Fx_disown_selection_internal): Rename locals
6205 to avoid shadowing.
6206 (x_handle_dnd_message): Remove local to avoid shadowing.
6207
6208 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6209 so that the caller can use some name other than gcpro1.
6210 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
6211 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6212 (Fx_backspace_delete_keys_p):
6213 Use them to avoid shadowing, and rename vars to avoid shadowing.
6214 (x_decode_color, x_set_name, x_window): Now static.
6215 (Fx_create_frame): Add braces to silence GCC warning.
6216 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
6217 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6218 Remove unused locals.
6219 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6220 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6221 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6222 macros.
6223
6224 * xterm.h (x_mouse_leave): New decl.
6225
6226 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6227 Remove unused functions.
6228 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6229 (x_calc_absolute_position): Now static.
6230 (XTread_socket): Don't define label "out" unless it's used.
6231 Don't declare local "event" unless it's used.
6232 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6233 unless they are used.
6234 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6235 (x_fatal_error_signal): Remove; not used.
6236 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6237 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6238 (x_error_catcher, x_connection_closed, x_error_handler):
6239 (x_error_quitter, xembed_send_message, x_iconify_frame):
6240 (my_log_handler): Rename locals to avoid shadowing.
6241 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
6242 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
6243
6244 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6245 Rename or move locals to avoid shadowing.
6246 (tty_defined_color, merge_face_heights): Now static.
6247 (free_realized_faces_for_fontset): Remove; not used.
6248 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6249 does not deduce is never used uninitialized.
6250 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6251 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
6252
6253 * terminal.c (store_terminal_param): Now static.
6254
6255 * xmenu.c (menu_highlight_callback): Now static.
6256 (set_frame_menubar): Remove unused local.
6257 (xmenu_show): Rename parameter to avoid shadowing.
6258 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6259 since they might point to immutable storage.
6260 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6261 since it's unused otherwise.
6262
6263 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6264 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6265 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6266 avoids a gcc -Wuninitialized diagnostic.
6267 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6268 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6269 does not deduce are never used uninitialized.
6270
6271 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6272
6273 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6274 * window.c (window_loop, size_window):
6275 (run_window_configuration_change_hook, enlarge_window): Likewise.
6276
6277 * window.c (display_buffer): Now static.
6278 (size_window): Mark variables that gcc -Wuninitialized
6279 does not deduce are never used uninitialized.
6280 * window.h (check_all_windows): New decl, to forestall
6281 gcc -Wmissing-prototypes diagnostic.
6282 * dispextern.h (bidi_dump_cached_states): Likewise.
6283
6284 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6285 shadowing.
6286 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6287 Include <limits.h>.
6288 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6289 and to avoid gcc -Wuninitialized warning.
6290 (load_charset_map): Mark variables that gcc -Wuninitialized
6291 does not deduce are never used uninitialized.
6292 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6293
6294 * coding.c (coding_set_source, coding_set_destination):
6295 Use "else { /* comment */ }" rather than "else /* comment */;"
6296 for clarity, and to avoid gcc -Wempty-body warning.
6297 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6298 a block, when the outer 'i' will do.
6299 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6300 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6301 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6302 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6303 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6304 Rename locals to avoid shadowing.
6305 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6306 * coding.c (emacs_mule_char, encode_invocation_designation):
6307 Now static, since they're not used elsewhere.
6308 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6309 (decode_coding_object, encode_coding_object, detect_coding_system):
6310 (decode_coding_emacs_mule): Mark variables that gcc
6311 -Wuninitialized does not deduce are never used uninitialized.
6312 (detect_coding_iso_2022): Initialize a local variable that might
6313 be used uninitialized. Leave a FIXME because it's not clear that
6314 this initialization is needed. (Bug#8211)
6315 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6316 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6317 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6318 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6319 Remove unused macros.
6320
6321 * category.c (hash_get_category_set): Remove unused local var.
6322 (copy_category_table): Now static, since it's not used elsewhere.
6323 * character.c (string_count_byte8): Likewise.
6324
6325 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6326 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6327
6328 * chartab.c (copy_sub_char_table): Now static, since it's not used
6329 elsewhere.
6330 (sub_char_table_ref_and_range, char_table_ref_and_range):
6331 Rename locals to avoid shadowing.
6332 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6333
6334 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6335 (BIDI_BOB): Remove unused macro.
6336
6337 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6338 deduce are never used uninitialized.
6339 * term.c (encode_terminal_code): Likewise.
6340
6341 * term.c (encode_terminal_code): Now static. Remove unused local.
6342
6343 * tparam.h: New file.
6344 * term.c, tparam.h: Include it.
6345 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6346 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6347 Move these decls to tparam.h, and make them agree with what
6348 is actually in tparam.c. The previous trick of using incompatible
6349 decls in different modules does not conform to the C standard.
6350 All callers of tparam changed to use tparam's actual API.
6351 * tparam.c (tparam1, tparam, tgoto):
6352 Use const pointers where appropriate.
6353
6354 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6355 * cm.h (struct cm): Likewise.
6356 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6357 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6358 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6359 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6360 (turn_on_face, init_tty): Likewise.
6361 * termchar.h (struct tty_display_info): Likewise.
6362
6363 * term.c (term_mouse_position): Rename local to avoid shadowing.
6364
6365 * alloc.c (mark_ttys): Move decl from here ...
6366 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6367
6368 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6369
6370 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6371
6372 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6373
6374 * search.c (compile_pattern_1): Remove argument regp, unused since
6375 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6376 (compile_pattern): Don't pass it.
6377
6378 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6379
6380 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6381 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6382 for ! HAVE_GTK3.
6383 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6384
6385 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6386
6387 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6388 gdk_window_get_screen, gdk_window_get_geometry,
6389 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6390 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6391 (xg_get_pixbuf_from_pixmap): New function.
6392 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6393 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6394 Call xg_get_pixbuf_from_pixmap instead of
6395 gdk_pixbuf_get_from_drawable.
6396 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6397 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6398 (xg_check_special_colors): Use GtkStyleContext and its functions
6399 for HAVE_GTK3.
6400 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6401 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6402 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6403 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6404 Call gtk_widget_get_preferred_size.
6405 (xg_frame_resized): gdk_window_get_geometry only takes 5
6406 parameters.
6407 (xg_win_to_widget, xg_event_is_for_menubar):
6408 Call gdk_x11_window_lookup_for_display.
6409 (xg_set_widget_bg): New function.
6410 (delete_cb): New function.
6411 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6412 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6413 (xg_set_background_color): Call xg_set_widget_bg.
6414 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6415 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6416 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6417 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6418 if ! HAVE_GTK3.
6419 (update_frame_tool_bar): Call gtk_widget_hide.
6420 (xg_initialize): Use GDK_KEY_g.
6421
6422 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6423 if ! HAVE_GTK3
6424 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6425
6426 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6427 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6428 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6429
6430 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6431
6432 * w32xfns.c (select_palette): Check success of RealizePalette against
6433 GDI_ERROR, not zero.
6434
6435 See ChangeLog.11 for earlier changes.
6436
6437 ;; Local Variables:
6438 ;; coding: utf-8
6439 ;; End:
6440
6441 Copyright (C) 2011 Free Software Foundation, Inc.
6442
6443 This file is part of GNU Emacs.
6444
6445 GNU Emacs is free software: you can redistribute it and/or modify
6446 it under the terms of the GNU General Public License as published by
6447 the Free Software Foundation, either version 3 of the License, or
6448 (at your option) any later version.
6449
6450 GNU Emacs is distributed in the hope that it will be useful,
6451 but WITHOUT ANY WARRANTY; without even the implied warranty of
6452 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6453 GNU General Public License for more details.
6454
6455 You should have received a copy of the GNU General Public License
6456 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.