1 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
5 (__malloc_size_t, __malloc_ptrdiff_t):
6 Remove. All uses removed, replaced by the definiens if needed,
7 since we can assume C89 or better now.
8 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
9 (protect_malloc_state, align, get_contiguous_space)
10 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
11 (malloc_atfork_handler_child, malloc_enable_thread)
12 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
13 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
14 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
15 (special_realloc, _realloc_internal_nolock, _realloc_internal)
16 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
17 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
18 Define using prototypes, not old style.
19 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
20 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
21 (align): Don't assume that signed integer overflow wraps around.
22 Omit unused local var.
23 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
24 (_free_internal_nolock, memalign, mallochook, reallochook):
25 Omit no-longer-needed casts.
26 (valloc): Use getpagesize, not __getpagesize.
27 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
28 (struct hdr): The 'magic' member is now size_t, not unsigned long.
30 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
32 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
34 Move functions from C to Lisp. Make non-blocking method calls
35 the default. Implement further D-Bus standard interfaces.
37 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
38 (QCdbus_request_name_allow_replacement)
39 (QCdbus_request_name_replace_existing)
40 (QCdbus_request_name_do_not_queue)
41 (QCdbus_request_name_reply_primary_owner)
42 (QCdbus_request_name_reply_in_queue)
43 (QCdbus_request_name_reply_exists)
44 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
45 (QCdbus_registered_serial, QCdbus_registered_method)
46 (QCdbus_registered_signal): New Lisp objects.
47 (XD_DEBUG_MESSAGE): Use sizeof.
48 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
49 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
50 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
51 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
52 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
53 (xd_signature, xd_append_arg): Allow float for integer types.
54 (xd_get_connection_references): New function.
55 (xd_get_connection_address): Rename from xd_initialize. Return
57 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
58 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
60 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
61 Return number of recounts.
62 (Fdbus_get_unique_name): Make stronger parameter check.
63 (Fdbus_message_internal): New defun.
64 (Fdbus_call_method, Fdbus_call_method_asynchronously)
65 (Fdbus_method_return_internal, Fdbus_method_error_internal)
66 (Fdbus_send_signal, Fdbus_register_service)
67 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
68 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
69 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
70 (Vdbus_compiled_version, Vdbus_runtime_version)
71 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
72 (Vdbus_message_type_method_return, Vdbus_message_type_error)
73 (Vdbus_message_type_signal): New defvars.
74 (Vdbus_registered_buses, Vdbus_registered_objects_table): Adapt
77 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
79 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
80 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
81 Do not assume ptrdiff_t is the same width as 'int'.
83 * alloc.c: Handle unusual debugging option combinations.
84 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
85 since the two debugging options are incompatible.
86 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
88 (mem_init, mem_insert, mem_insert_fixup):
89 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
90 (NEED_MEM_INSERT): Remove; no longer needed.
92 2012-04-22 Leo Liu <sdl.web@gmail.com>
94 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
96 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
98 * sysdep.c [__FreeBSD__]: Minor cleanups.
99 (list_system_processes, system_process_attributes) [__FreeBSD__]:
100 Use Emacs indenting style more consistently. Avoid some casts.
101 Use 'double' consistently rather than mixing 'float' and 'double'.
103 2012-04-21 Eduard Wiebe <usenet@pusto.de>
105 * sysdep.c (list_system_processes, system_process_attributes): Add
106 implementation for FreeBSD (Bug#5243).
108 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
110 * lisp.mk (lisp): Update.
112 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
114 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
115 It is never used otherwise.
117 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
119 * print.c (print_preprocess): Only check print_depth if print-circle
121 (print_object): Check for cycles even when print-circle is nil and
122 print-gensym is t, but only check print_depth if print-circle is nil.
124 2012-04-20 Chong Yidong <cyd@gnu.org>
126 * process.c (wait_reading_process_output): If EIO occurs on a pty,
127 set the status to "failed" and ensure that sentinel is run.
129 2012-04-20 Glenn Morris <rgm@gnu.org>
131 * process.c (Fset_process_inherit_coding_system_flag)
132 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
133 (Fmake_network_process, Fmake_serial_process): Doc fix.
135 2012-04-20 Eli Zaretskii <eliz@gnu.org>
137 * xdisp.c (string_buffer_position_lim): Limit starting position to
139 (set_cursor_from_row): If called for a mode-line or header-line
140 row, return zero immediately.
141 (try_cursor_movement): If inside continuation line, don't back up
142 farther than the first row after the header line, if any.
143 Don't consider the header-line row as "partially visible", even if
144 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
146 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
148 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
151 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
152 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
154 configure: new option --enable-gcc-warnings (Bug#11207)
155 * Makefile.in (C_WARNINGS_SWITCH): Remove.
156 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
157 (ALL_CFLAGS): Use new macros rather than old.
158 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
159 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
160 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
161 -Wunused-result, -Wunused-variable. This should go away once
162 the Emacs and Gnulib regex code is merged.
163 (xmalloc, xrealloc): Now static.
165 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
167 * dired.c (Fsystem_groups): Remove unused local.
169 2012-04-17 Glenn Morris <rgm@gnu.org>
171 * dired.c (Fsystem_users): Doc fix.
173 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
175 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
176 (syms_of_dired): Add them.
178 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
180 Fix minor alloc.c problems found by static checking.
181 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
182 New extern decls, to avoid calling undeclared functions.
183 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
184 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
185 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
186 (NEED_MEM_INSERT): New macro.
187 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
188 Remove one incorrect comment and fix another.
190 Fix minor ralloc.c problems found by static checking.
191 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
192 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
193 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
194 (r_alloc_sbrk): Now static.
196 Improve ralloc.c interface checking.
197 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
198 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
199 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
200 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
201 [REL_ALLOC]: ... to here, to check interface.
202 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
203 Remove decls. This fixes an "It stinks!".
205 * alloc.c (which_symbols): Fix alignment issue / type clash.
207 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
209 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
210 (struct Lisp_Misc_Any): Likewise.
211 (struct Lisp_Free): Likewise.
212 * alloc.c (union aligned_Lisp_Symbol): Define.
213 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
214 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
215 (union aligned_Lisp_Misc): Define.
216 (MARKER_BLOCK_SIZE, struct marker_block): Use union
217 aligned_Lisp_Misc instead of union Lisp_Misc.
218 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
220 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
222 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
223 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
224 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
225 * s/netbsd.h, s/sol2-6.h:
226 Remove definition of GC_MARK_STACK, since the default now works.
227 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
228 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
229 no longer the default.
230 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
232 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
234 * lread.c (lisp_file_lexically_bound_p):
235 Fix hang at ";-*-\n" (bug#11238).
237 2012-04-14 Eli Zaretskii <eliz@gnu.org>
239 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
240 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
242 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
244 * nsterm.m (constrainFrameRect): Always constrain when there is only
245 one screen (Bug#10962).
247 2012-04-13 Ken Brown <kbrown@cornell.edu>
249 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
251 2012-04-13 Reuben Thomas <rrt@sc3d.org>
253 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
255 2012-04-11 Daniel Colascione <dancol@dancol.org>
257 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
258 against is gone. It's better to use vfork now so that when Cygwin
259 gains a new, working vfork, we use it automatically (bug#10398).
261 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
263 * window.c (save_window_save): Obey window-point-insertion-type.
265 2012-04-11 Glenn Morris <rgm@gnu.org>
267 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
269 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
271 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
273 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
275 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
276 (force_quit_count): New var.
277 (handle_interrupt): Use it.
279 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
281 * w32.c (w32_delayed_load): Record the full path of the library
282 being loaded (bug#10424).
284 2012-04-09 Glenn Morris <rgm@gnu.org>
286 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
287 not just in the obarray, before snarfing them. (Bug#11036)
289 * Makefile.in ($(leimdir)/leim-list.el):
290 Pass EMACS rather than BUILT_EMACS.
292 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
294 * process.c (make_process):
295 * process.h: Add integer `gnutls_handshakes_tried' member to
298 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
299 Add convenience `GNUTLS_LOG2i' macro.
301 * gnutls.c (gnutls_log_function2i): Convenience log function.
302 (emacs_gnutls_read): Use new log functions,
303 `gnutls_handshakes_tried' process member, and
304 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
305 attempts per process (connection).
307 2012-04-09 Chong Yidong <cyd@gnu.org>
309 * eval.c (Fuser_variable_p, user_variable_p_eh)
310 (lisp_indirect_variable): Functions deleted.
311 (Fdefvar): Caller changed.
313 * callint.c (Finteractive, Fcall_interactively):
314 * minibuf.c (Fread_variable): Callers changed.
316 2012-04-09 Eli Zaretskii <eliz@gnu.org>
318 * xdisp.c (set_cursor_from_row): If the display string appears in
319 the buffer at position that is closer to point than the position
320 after the display string, display the cursor on the first glyph of
321 the display string. Fixes cursor display when a 'display' text
322 property immediately follows invisible text. (Bug#11094)
324 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
326 composite.c: use 'double' consistently
327 * composite.c (get_composition_id): Use 'double' consistently
328 instead of converting 'float' to 'double' and vice versa; this is
329 easier to understand and avoids a GCC warning.
331 2012-04-09 Glenn Morris <rgm@gnu.org>
333 * Makefile.in: Generate leim-list with bootstrap-emacs, in
334 preparation for dumping it with emacs. (Bug#4789)
335 (leimdir): New variable.
336 ($(leimdir)/leim-list.el): New rule.
337 (emacs$(EXEEXT)): Depend on leim-list.el.
339 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
340 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
341 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
343 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
345 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
348 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
350 * xml.c (init_libxml2_functions) [WINDOWSNT]:
351 Remove unused local variable.
353 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
355 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
356 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
357 (mark_memory): Mark Lisp_Objects only if pointers might hide in
358 objects, as mark_maybe_pointer will catch them otherwise.
359 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
360 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
362 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
364 Fix typo that broke non-Windows builds.
365 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
367 2012-04-07 Eli Zaretskii <eliz@gnu.org>
369 Support building on MS-Windows with libxml2.
371 * makefile.w32-in (OBJ2): Add xml.$(O).
372 (GLOBAL_SOURCES): Add xml.c.
373 ($(BLD)/xml.$(O)): New dependency list.
375 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
376 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
377 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
378 [!WINDOWSNT]: New macros.
379 (init_libxml2_functions, libxml2_loaded_p): New functions.
380 (parse_region): Call fn_xmlCheckVersion instead of using the macro
381 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
382 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
383 Calls xmlCleanupParser only if libxml2 was loaded (or statically
385 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
386 Call init_libxml2_functions before calling libxml2 functions.
387 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
389 * emacs.c: Don't include libxml/parser.h.
390 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
391 xmlCleanupParser directly.
393 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
395 2012-04-07 Eli Zaretskii <eliz@gnu.org>
397 * indent.c (Fvertical_motion): If there is a display string at
398 point, use it.vpos to compute how many lines to backtrack after
399 move_it_to point. (Bug#11133)
401 2012-04-06 Eli Zaretskii <eliz@gnu.org>
403 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
404 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
405 about subtle differences between FETCH_CHAR* and STRING_CHAR*
406 macros related to unification of CJK characters. For the details,
407 see the discussion following the message here:
408 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
410 2012-04-04 Chong Yidong <cyd@gnu.org>
412 * keyboard.c (Vdelayed_warnings_list): Doc fix.
414 2012-04-01 Eli Zaretskii <eliz@gnu.org>
416 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
417 instead of alloca. (Bug#11138)
419 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
421 * w32menu.c (is_simple_dialog): Properly check lisp types.
424 2012-03-31 Eli Zaretskii <eliz@gnu.org>
426 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
427 position we get to after a call to move_it_to fails the
428 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
429 only if we wind up in a string from display property. (Bug#11063)
431 * window.c (Fdelete_other_windows_internal): Invalidate the row
432 and column information about mouse highlight, so that redisplay
433 restores it after reallocating the glyph matrices. (Bug#7464)
435 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
436 string comes from a `display' text property, use the buffer
437 position of that property as if we actually saw that position in
439 (move_it_by_lines): Remove the assertion that
440 "it->current_x == 0 && it->hpos == 0" which can be legitimately
441 violated when there's a before-string at the beginning of a line.
444 2012-03-30 Eli Zaretskii <eliz@gnu.org>
446 * xdisp.c (append_space_for_newline): If the default face was
447 remapped, use the remapped face for the appended newline.
448 (extend_face_to_end_of_line): Use the remapped default face for
449 extending the face to the end of the line.
450 (display_line): Call extend_face_to_end_of_line when the default
451 face was remapped. (Bug#11068)
453 2012-03-29 Eli Zaretskii <eliz@gnu.org>
455 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
457 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
459 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
461 2012-03-27 Glenn Morris <rgm@gnu.org>
463 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
466 2012-03-26 Kenichi Handa <handa@m17n.org>
468 * dispextern.h (struct glyph): Fix previous change. Change the
469 bit length of glyphless.ch to 25 (Bug#11082).
471 2012-03-26 Chong Yidong <cyd@gnu.org>
473 * keyboard.c (Vselection_inhibit_update_commands): New variable.
474 (command_loop_1): Use it; inhibit selection update for
475 handle-select-window too (Bug#8996).
477 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
479 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
481 2012-03-25 Kenichi Handa <handa@m17n.org>
483 * dispextern.h (struct glyph): Change the bit length of
484 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
486 2012-03-24 Eli Zaretskii <eliz@gnu.org>
488 * s/ms-w32.h (tzname): Include time.h before redirecting to
489 _tzname. Fixes the MSVC build. (Bug#9960)
491 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
493 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
496 * xterm.c (XTread_socket): Only modify handling_signal if
497 !SYNC_INPUT. (Bug#11080)
499 2012-03-23 Eli Zaretskii <eliz@gnu.org>
501 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
502 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
503 when fetching a multibyte character consumes more bytes than
504 CHAR_BYTES returns, due to unification of CJK characters in
505 string_char. (Bug#11073)
507 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
509 * process.c (wait_reading_process_output): Handle pty disconnect
510 by refraining from sending oneself a SIGCHLD (bug#10933).
512 2012-03-22 Chong Yidong <cyd@gnu.org>
514 * dispextern.h (struct it): New member string_from_prefix_prop_p.
516 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
517 Mark string as coming from a prefix property.
518 (handle_face_prop): Use default face for prefix strings (Bug#4281).
519 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
521 2012-03-21 Chong Yidong <cyd@gnu.org>
523 * xfaces.c (Vface_remapping_alist): Doc fix.
525 2012-03-20 Eli Zaretskii <eliz@gnu.org>
527 * w32proc.c (Fw32_set_console_codepage)
528 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
531 2012-03-20 Chong Yidong <cyd@gnu.org>
533 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
534 to reflect default non-nil value of redisplay-dont-pause.
536 2012-03-19 Kenichi Handa <handa@m17n.org>
538 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
539 it fit in a valid range (Bug#11003).
541 2012-03-18 Eli Zaretskii <eliz@gnu.org>
543 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
544 that is not from display property, accept the row as a "cursor
545 row" if one of the string's character has a non-nil `cursor'
546 property. Fixes cursor positioning when there are newlines in
547 overlay strings, e.g. in icomplete.el. (Bug#11035)
549 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
551 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
553 2012-03-12 Chong Yidong <cyd@gnu.org>
555 * eval.c (inhibit_lisp_code): Rename from
556 inhibit_window_configuration_change_hook; move from window.c.
558 * xfns.c (unwind_create_frame_1, Fx_create_frame):
559 * window.c (run_window_configuration_change_hook)
560 (syms_of_window): Callers changed.
562 2012-03-11 Chong Yidong <cyd@gnu.org>
564 * keymap.c (Fkey_description): Doc fix (Bug#9700).
566 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
568 2012-03-10 Chong Yidong <cyd@gnu.org>
570 * frame.c (other_visible_frames): Don't assume the selected frame
571 is visible (Bug#10955).
573 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
575 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
577 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
579 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
580 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
583 2012-03-03 Glenn Morris <rgm@gnu.org>
585 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
587 2012-03-02 Eli Zaretskii <eliz@gnu.org>
589 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
590 position past the first glyph_row that ends at ZV. (Bug#10902)
591 (redisplay_window, next_element_from_string): Fix typos in
593 (redisplay_window): Pass to move_it_vertically the margin in
594 pixels, not in screen lines.
596 2012-03-02 Glenn Morris <rgm@gnu.org>
598 * buffer.c (buffer-list-update-hook): Doc fix.
600 2012-02-29 Eli Zaretskii <eliz@gnu.org>
602 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
603 push_it before setting up the iterator for the first overlay
604 string, even if we have an empty string loaded.
605 (next_overlay_string): If there's an empty string on the iterator
606 stack, pop the stack. (Bug#10903)
608 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
610 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
611 Suggested by Stefan Monnier in
612 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
613 * alloc.c (widen_to_Lisp_Object): New static function.
614 (mark_memory): Also mark Lisp_Objects by fetching pointer words
615 and widening them to Lisp_Objects. This would work even if
616 USE_LSB_TAG is defined and wide integers are used, which might
617 happen in a future version of Emacs.
619 2012-02-25 Chong Yidong <cyd@gnu.org>
621 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
624 * xselect.c (Fx_selection_exists_p): Doc fix.
625 (x_clipboard_manager_save_all): Print an informative message
626 before saving to clipboard manager.
628 2012-02-24 Chong Yidong <cyd@gnu.org>
630 * keyboard.c (process_special_events): Handle all X selection
631 requests in kbd_buffer, not just the next one (Bug#8869).
633 2012-02-23 Chong Yidong <cyd@gnu.org>
635 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
636 call when setting menu-bar-lines and tool-bar-lines parameters.
637 (unwind_create_frame_1): New helper function.
639 * window.c (inhibit_window_configuration_change_hook): New var.
640 (run_window_configuration_change_hook): Obey it.
641 (syms_of_window): Initialize it.
643 2012-02-22 Chong Yidong <cyd@gnu.org>
645 * xterm.c (x_draw_image_relief): Add missing type check for
646 Vtool_bar_button_margin (Bug#10743).
648 2012-02-21 Chong Yidong <cyd@gnu.org>
650 * fileio.c (Vfile_name_handler_alist): Doc fix.
652 * buffer.c (Fget_file_buffer): Protect against invalid file
653 handler return value.
655 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
657 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
658 when computing $valmask.
660 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
661 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
662 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
663 It's useless in that case, and it can cause problems on hosts
664 that allocate halves of EMACS_INT values separately.
665 Reported by Dan Horák. Diagnosed by Andreas Schwab in
666 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
667 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
668 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
669 it avoids undefined behavior on hosts where shifting right by more
670 than the word width has undefined behavior.
672 2012-02-19 Chong Yidong <cyd@gnu.org>
674 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
675 (Funhandled_file_name_directory, Ffile_name_as_directory)
676 (Fdirectory_file_name, Fexpand_file_name)
677 (Fsubstitute_in_file_name): Protect against invalid file handler
678 return values (Bug#10845).
680 2012-02-18 Eli Zaretskii <eliz@gnu.org>
682 * .gdbinit (pitx): Fix incorrect references to fields of the
685 2012-02-17 Chong Yidong <cyd@gnu.org>
687 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
689 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
691 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
692 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
694 2012-02-15 Chong Yidong <cyd@gnu.org>
696 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
697 marked as special. Also, starting docstrings with * is obsolete.
699 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
701 * gnutls.c (emacs_gnutls_write): Fix last change.
703 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
705 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
708 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
710 * keymap.c (Fsingle_key_description): Handle char ranges.
712 2012-02-12 Chong Yidong <cyd@gnu.org>
714 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
715 as that creates a dangerous corner case.
717 * window.c (Fdelete_window_internal): Invalidate the mouse
718 highlight (Bug#9904).
720 2012-02-12 Glenn Morris <rgm@gnu.org>
722 * xselect.c (Fx_own_selection_internal)
723 (Fx_get_selection_internal, Fx_disown_selection_internal)
724 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
725 * nsselect.m (Fx_own_selection_internal)
726 (Fx_disown_selection_internal, Fx_selection_exists_p)
727 (Fx_selection_owner_p, Fx_get_selection_internal):
728 Sync docs and argument specs with the xselect.c versions.
730 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
732 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
734 2012-02-11 Eli Zaretskii <eliz@gnu.org>
736 * w32select.c (Fx_selection_exists_p): Sync doc string and
737 argument list with xselect.c. (Bug#10783)
739 * w16select.c (Fx_selection_exists_p): Sync doc string and
740 argument list with xselect.c. (Bug#10783)
742 2012-02-10 Glenn Morris <rgm@gnu.org>
744 * fns.c (Fsecure_hash): Doc fix.
746 2012-02-09 Kenichi Handa <handa@m17n.org>
748 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
750 2012-02-07 Chong Yidong <cyd@gnu.org>
752 * buffer.c (Fbuffer_local_variables)
753 (buffer_lisp_local_variables): Handle unbound vars correctly;
754 don't let Qunbound leak into Lisp.
756 2012-02-07 Glenn Morris <rgm@gnu.org>
758 * image.c (Fimagemagick_types): Doc fix.
760 * image.c (imagemagick-render-type): Change it from a lisp object
761 to an integer. Move the doc here from the lisp manual.
762 Treat all values not equal to 0 the same.
764 2012-02-06 Chong Yidong <cyd@gnu.org>
766 * doc.c (store_function_docstring): Avoid applying docstring of
767 alias to base function (Bug#2603).
769 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
771 * .gdbinit (pp1, pv1): Remove redundant defines.
774 2012-02-04 Chong Yidong <cyd@gnu.org>
776 * nsterm.m: Declare a global (Bug#10694).
778 2012-02-04 Eli Zaretskii <eliz@gnu.org>
780 * w32.c (get_emacs_configuration_options):
781 Include --enable-checking, if specified, in the return value.
783 2012-02-04 Martin Rudalics <rudalics@gmx.at>
785 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
786 after rounding frame sizes. (Bug#9723)
788 2012-02-04 Eli Zaretskii <eliz@gnu.org>
790 * keyboard.c (adjust_point_for_property): Don't position point
791 before BEGV. (Bug#10696)
793 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
795 Handle overflow when computing char display width (Bug#9496).
796 * character.c (char_width): Return EMACS_INT, not int.
797 (char_width, c_string_width): Check for overflow when
798 computing the width; this is possible now that individual
799 characters can have unbounded width. Problem introduced
800 by merge from Emacs 23 on 2012-01-19.
802 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
804 * dbusbind.c (Fdbus_register_method): Mention the return value
805 :ignore in the docstring.
807 2012-02-02 Glenn Morris <rgm@gnu.org>
809 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
811 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
812 Unconditionally set to t. (Bug#10673)
813 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
814 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
815 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
817 2012-02-02 Kenichi Handa <handa@m17n.org>
819 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
820 0, do not call append_composite_glyph.
822 2012-02-02 Kenichi Handa <handa@m17n.org>
824 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
826 (x_produce_glyphs): If the component of a composition is a null
827 string, set it->pixel_width to 1 to avoid zero-width glyph.
829 2012-02-01 Eli Zaretskii <eliz@gnu.org>
831 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
832 first 2 arguments are identical. This makes inserting large
833 output from a subprocess an order of magnitude faster on
834 MS-Windows, where all sbrk'ed memory is always contiguous.
836 2012-01-31 Glenn Morris <rgm@gnu.org>
838 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
839 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
840 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
842 2012-01-29 Glenn Morris <rgm@gnu.org>
844 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
846 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
848 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
850 2012-01-28 Chong Yidong <cyd@gnu.org>
852 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
854 2012-01-26 Chong Yidong <cyd@gnu.org>
856 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
858 * search.c (Fsearch_forward, Fsearch_backward): Document negative
859 repeat counts (Bug#10507).
861 2012-01-26 Glenn Morris <rgm@gnu.org>
863 * lread.c (syms_of_lread): Doc fix.
865 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
867 * coding.c (encode_designation_at_bol): Change return value to
870 2012-01-25 Chong Yidong <cyd@gnu.org>
872 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
874 2012-01-21 Chong Yidong <cyd@gnu.org>
876 * floatfns.c (Fcopysign): Make the second argument non-optional,
877 since nil is not allowed anyway.
879 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
881 * process.c (read_process_output): Use p instead of XPROCESS (proc).
882 (send_process): Likewise.
884 2012-01-19 Martin Rudalics <rudalics@gmx.at>
886 * window.c (save_window_save, Fcurrent_window_configuration)
887 (Vwindow_persistent_parameters): Do not use Qstate.
890 2012-01-19 Kenichi Handa <handa@m17n.org>
892 * character.c (char_width): New function.
893 (Fchar_width, c_string_width, lisp_string_width):
894 Use char_width (Bug#9496).
896 2012-01-16 Martin Rudalics <rudalics@gmx.at>
898 * window.c (Vwindow_persistent_parameters): New variable.
899 (Fset_window_configuration, save_window_save): Handle persistent
902 2012-01-14 Eli Zaretskii <eliz@gnu.org>
904 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
905 thrashing the stack of the thread. (Bug#9087)
907 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
909 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
911 2012-01-11 Eli Zaretskii <eliz@gnu.org>
913 * xdisp.c (rows_from_pos_range): Handle the case where the
914 highlight ends on a newline. (Bug#10464)
915 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
916 he end column for display of highlight that ends on a newline
919 2012-01-11 Glenn Morris <rgm@gnu.org>
921 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
922 from load-path also when installation-directory is nil. (Bug#10208)
924 2012-01-10 Glenn Morris <rgm@gnu.org>
926 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
928 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
929 Update template values to be closer to their typical values these days.
931 2012-01-09 Eli Zaretskii <eliz@gnu.org>
933 * xdisp.c (rows_from_pos_range): Accept additional argument
934 DISP_STRING, and accept any glyph in a row whose object is that
935 string as eligible for mouse highlight. Fixes mouse highlight of
936 display strings from overlays. (Bug#10464)
938 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
940 emacs: fix an auto-save permissions race condition (Bug#10400)
941 * fileio.c (auto_saving_dir_umask): New static var.
942 (Fmake_directory_internal): Use it.
943 (do_auto_save_make_dir): Set it, instead of invoking chmod after
944 creating the directory. The old code temporarily assigns
945 too-generous permissions to the directory.
946 (do_auto_save_eh): Clear it.
947 (Fdo_auto_save): Catch all errors, not just file errors, so
948 that the var is always cleared.
950 2012-01-07 Eli Zaretskii <eliz@gnu.org>
952 * search.c (scan_buffer): Pass character positions to
953 know_region_cache, not byte positions. (Bug#6540)
955 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
957 * w32.c (sys_rename): Report EXDEV when rename of a directory
958 fails because the target is on another logical disk. (Bug#10284)
960 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
962 * xterm.c (x_embed_request_focus): New function.
964 * xterm.h: Add prototype.
966 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
968 2012-01-05 Glenn Morris <rgm@gnu.org>
970 * emacs.c (emacs_copyright): Update short copyright year to 2012.
972 2012-01-01 Eli Zaretskii <eliz@gnu.org>
974 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
975 Load gnutls_transport_set_lowat only if GnuTLS version is below
977 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
978 GnuTLS versions below 2.11.1.
980 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
982 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
983 to the doc string advising against its use for altering the way
984 windows are scrolled.
986 2011-12-28 Kenichi Handa <handa@m17n.org>
988 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
989 coding-system ASCII compatible only when it does not produce BOM
990 on encoding (Bug#10383).
992 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
994 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
996 (create_and_show_popup_menu): Always use menu_position_func for
999 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1001 * callint.c (Fcall_interactively): Don't truncate prompt string.
1003 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1005 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1006 property that ends at ZV, so that the bidi iteration could be
1007 resumed from there (after widening). (Bug#10360)
1009 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1011 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1013 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1015 * nsterm.m (x_free_frame_resources):
1016 Release f->output_data.ns->miniimage.
1017 (ns_index_color): Fix indentation. Do not retain
1018 color_table->colors[i].
1020 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1023 * nsfns.m (x_set_background_color): Assign return value from
1024 ns_index_color to face-background instead of NSColor*.
1025 (ns_implicitly_set_icon_type): Fix indentation.
1026 Change assignment in for loop to comparison.
1028 * emacs.c (ns_pool): New variable.
1029 (main): Assign ns_pool.
1030 (Fkill_emacs): Call ns_release_autorelease_pool.
1032 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1033 autorelease fdesc, release fdAttrs and tdict.
1034 (ns_get_covering_families): Release charset.
1035 (ns_findfonts): Release NSFontDescriptor created with new.
1036 (ns_uni_to_glyphs): Fix indentation.
1037 (setString): Release attrStr before assigning new value.
1039 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1041 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1043 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1044 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1046 2011-12-18 David Reitter <reitter@cmu.edu>
1048 * nsterm.m (ns_term_init): Subscribe for notifications
1049 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1050 to method trackingNotification in EmacsMenu.
1052 * nsmenu.m (trackingMenu): New variable.
1053 (trackingNotification): New method (from Aquamacs).
1054 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1055 from Aquamacs (Bug#7030).
1057 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1059 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1060 (symbol_to_nsstring): Fix indentation.
1061 (ns_symbol_to_pb): New function.
1062 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1063 (Fns_rotate_cut_buffers_internal): Remove.
1064 (Fns_store_selection_internal): Rename from
1065 Fns_store_cut_buffer_internal.
1066 (ns_get_foreign_selection, Fx_own_selection_internal)
1067 (Fx_disown_selection_internal, Fx_selection_exists_p)
1068 (Fns_get_selection_internal, Fns_store_selection_internal):
1069 Use ns_symbol_to_pb and check if return value is nil.
1070 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1071 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1072 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1073 renamed to Sns_store_selection_internal.
1074 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1075 and remove this function.
1076 (ns_handle_selection_clear): Remove, never used.
1077 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1080 2011-12-17 Ken Brown <kbrown@cornell.edu>
1082 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1083 GID is unknown (Bug#10257).
1085 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1087 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1088 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1089 which caused a build failure on GNU/Linux IA-64. This problem was
1090 introduced by my 2011-10-07 patch.
1092 2011-12-15 Juri Linkov <juri@jurta.org>
1094 * image.c (imagemagick_error): New function. (Bug#10112)
1095 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1096 Use `imagemagick_error' where ImageMagick functions return
1098 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1101 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1103 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1104 fill background (Bug#8992).
1106 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1108 * window.c (Vwindow_combination_resize)
1109 (Vwindow_combination_limit): Use t instead of non-nil in
1111 (Vrecenter_redisplay): Add first sentence of doc-string on
1113 (Frecenter): Fix doc-string typo.
1115 2011-12-11 Kenichi Handa <handa@m17n.org>
1117 * coding.c (Funencodable_char_position): Pay attention to the
1118 buffer text relocation (Bug#9389).
1120 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1122 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1123 gtk_init (Bug#10100).
1125 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1127 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1128 IT->string is nil. (Bug#10263)
1130 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1132 * nsterm.h (x_free_frame_resources): Declare.
1134 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1135 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1137 * nsterm.h (ns_get_defaults_value): Declare.
1139 * nsterm.m (ns_default): Call ns_get_defaults_value.
1141 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1143 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1146 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1148 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1149 that where the value of an _OBJC_* symbol points to is in the .bss
1150 section (Bug#10240).
1152 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1154 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1155 after the loop to call ccl_driver at least once (Bug#8619).
1157 2011-12-08 Kenichi Handa <handa@m17n.org>
1159 * ftfont.c (get_adstyle_property): Fix previous change
1162 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1164 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1165 dirs from the default value of EMACSLOADPATH (bug#10208).
1167 2011-12-07 Glenn Morris <rgm@gnu.org>
1169 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1170 installation and source directories as well. (Bug#10208)
1172 2011-12-06 Chong Yidong <cyd@gnu.org>
1174 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1176 2011-12-06 Glenn Morris <rgm@gnu.org>
1178 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1179 as an error, not just -1. (Bug#10217)
1181 2011-12-05 Chong Yidong <cyd@gnu.org>
1183 * keyboard.c (process_special_events): New function.
1184 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1186 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1188 * coding.c (encode_designation_at_bol): Don't use uninitialized
1189 local variable (Bug#9318).
1191 2011-12-05 Kenichi Handa <handa@m17n.org>
1193 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1194 return Qnil (Bug#8046, Bug#10193).
1196 2011-12-05 Kenichi Handa <handa@m17n.org>
1198 * coding.c (encode_designation_at_bol): New args charbuf_end and
1199 dst. Return the number of produced bytes. Callers changed.
1200 (coding_set_source): Return how many bytes coding->source was
1202 (coding_set_destination): Return how many bytes
1203 coding->destination was relocated.
1204 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1205 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1207 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1209 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1210 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1213 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1215 The following changes are to fix Bug#9318.
1217 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1218 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1219 (encode_coding_iso_2022, encode_coding_sjis)
1220 (encode_coding_big5, encode_coding_charset): Use the above macros.
1222 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1224 * lisp.h (process_quit_flag): Fix external declaration.
1226 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1228 Don't macro-inline non-performance-critical code.
1229 * eval.c (process_quit_flag): New function.
1230 * lisp.h (QUIT): Use it.
1232 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1234 * nsfns.m (get_geometry_from_preferences): New function.
1235 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1237 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1239 * emacs.c (Qkill_emacs): Define.
1240 (syms_of_emacs): Initialize it.
1241 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1242 Qquit_flag to `kill-emacs' instead.
1243 (quit_throw_to_read_char): Add parameter `from_signal'.
1244 All callers changed. Call Fkill_emacs if requested and safe.
1245 * lisp.h (QUIT): Call Fkill_emacs if requested.
1247 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1249 * widget.c (update_wm_hints): Return if wmshell is null.
1250 (widget_update_wm_size_hints): New function.
1252 * widget.h (widget_update_wm_size_hints): Declare.
1254 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1255 widget_update_wm_size_hints (Bug#10104).
1257 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1259 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1260 before a newline, prepare the bidi iterator for consuming the
1261 newline, and keep the current paragraph direction. (Bug#10183)
1262 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1264 2011-12-02 Juri Linkov <juri@jurta.org>
1266 * search.c (Fword_search_regexp): New Lisp function created from
1267 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1268 (Fword_search_backward, Fword_search_forward)
1269 (Fword_search_backward_lax, Fword_search_forward_lax):
1270 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1271 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1273 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1275 * fileio.c (Finsert_file_contents): Move after-change-function call
1276 to before the "handled:" label, since all "goto handled" appear in
1277 cases where the *-change-functions have already been properly called
1280 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1282 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1283 waiting for input. (Bug#10169)
1285 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1287 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1288 verifies glyph row's hash code--we have just reallocated the
1289 glyphs, so their contents can be complete garbage. (Bug#10164)
1291 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1293 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1295 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1297 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1298 attributes are tested _before_ calling verify_row_hash, to protect
1299 against GCC re-ordering of the tests. (Bug#10164)
1301 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1303 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1305 * xterm.c (handle_one_xevent): Only set async_visible and friends
1306 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1307 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1308 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1310 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1312 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1313 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1314 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1315 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1316 All uses changed to use GCPRO1 etc.
1317 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1318 Revert to old implementation (i.e., before 2011-03-11).
1320 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1322 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1323 of scroll runs so as to avoid assigning disabled bogus rows and
1324 unnecessary graphics copy operations.
1326 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1328 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1329 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1330 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1331 (malloc, free, realloc, calloc): Redirect to e_* only when
1334 * lisp.h (GCTYPEBITS): Move before first use.
1335 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1336 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1337 this macro definition.
1339 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1342 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1344 * gtkutil.c (xg_create_frame_widgets):
1345 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1346 present with Gtk+ 2.0.
1348 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1350 * fileio.c (Finsert_file_contents): Undo previous change; see
1351 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1353 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1355 Rename locals to avoid shadowing.
1356 * fileio.c (Finsert_file_contents):
1357 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1358 * process.c (wait_reading_process_output):
1359 Rename inner 'proc' to 'p' to avoid shadowing.
1360 Indent for consistency with usual Emacs style.
1362 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1364 * xdisp.c (redisplay_window): If cursor row is not fully visible
1365 after recentering, and scroll-conservatively is set to a large
1366 number, scroll window by a few more lines to make the cursor fully
1367 visible and out of scroll-margin. (Bug#10105)
1368 (start_display): Don't move to the next line if the display should
1369 start at a newline that is part of a display vector or an overlay
1372 2011-11-24 Juri Linkov <juri@jurta.org>
1374 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1375 after the `MagickPingImage' call. (Bug#10112)
1377 2011-11-23 Chong Yidong <cyd@gnu.org>
1379 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1381 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1383 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1384 making another buffer current. (Bug#10114)
1386 2011-11-23 Glenn Morris <rgm@gnu.org>
1388 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1390 2011-11-23 Chong Yidong <cyd@gnu.org>
1392 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1393 using it (Bug#5984).
1395 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1397 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1398 and header-lines, as they don't have one computed for them.
1401 * .gdbinit (prow): Make displayed values more self-explaining.
1402 Add row's hash code.
1404 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1406 * process.c (wait_reading_process_output): Fix asynchrounous
1407 GnuTLS socket handling on some versions of the GnuTLS library.
1408 (wait_reading_process_output): Add comment and URL.
1410 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1412 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1414 2011-11-21 Chong Yidong <cyd@gnu.org>
1416 * window.c (Fnext_window, Fprevious_window): Doc fix.
1418 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1420 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1422 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1424 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1426 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1428 * window.c (Fset_window_combination_limit): Rename argument
1430 (Vwindow_combination_limit): Remove "status" from doc-string.
1432 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1434 * m/ibms390.h: Remove.
1435 * m/ibms390x.h: Don't include "ibms390.h".
1437 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1439 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1440 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1442 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1444 * casetab.c (Fset_case_table):
1445 * charset.c (Fcharset_after): Fix typos.
1447 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1449 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1450 Otherwise, valgrind does not work on some platforms.
1451 Problem reported by Andreas Schwab in
1452 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1453 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1454 is set, removing the need for VIRT_ADDRESS_VARIES.
1455 (PURE_P): Use a more-efficient implementation that needs just one
1456 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1457 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1458 to 4 (xorl, subq, cmpq, setbe).
1459 * alloc.c (pure): Always extern now, since that's the
1460 VIRT_ADDR_VARIES behavior.
1461 (PURE_POINTER_P): Use a single comparison, not two, for
1462 consistency with the new puresize.h.
1463 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1464 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1465 Remove VIRT_ADDR_VARIES no longer needed.
1467 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1469 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1470 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1471 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1472 behave as if the cursor position were at the window margin.
1474 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1475 and the cursor position is out of bounds, behave as if the cursor
1476 position were at the window margin. (Bug#10075)
1478 2011-11-18 Chong Yidong <cyd@gnu.org>
1480 * window.c (Fwindow_combination_limit): Make first argument
1481 non-optional, since it is meaningless for live windows like the
1484 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1486 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1488 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1490 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1491 (graft_intervals_into_buffer): Simplify.
1493 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1495 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1496 hash values of the two rows.
1497 (copy_row_except_pointers): Preserve the used[] arrays and the
1498 hash values of the two rows. (Bug#10035)
1499 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1501 * xdisp.c (row_hash): New function, body extracted from
1502 compute_line_metrics.
1503 (compute_line_metrics): Call row_hash, instead of computing the
1506 * dispnew.c (verify_row_hash): Call row_hash for computing the
1507 hash code of a row, instead of duplicating code from xdisp.c.
1509 * dispextern.h (row_hash): Add prototype.
1511 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1513 * frame.c (delete_frame): Don't delete the terminal when the last
1514 X frame is closed if emacs is built with GTK toolkit.
1516 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1518 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1520 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1522 * window.c (Vwindow_splits): Rename to
1523 Vwindow_combination_resize. Suggested by Juri Linkov.
1524 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1527 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1529 * nsfns.m (Fns_font_name):
1530 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1532 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1534 * window.h (window): Rename slot "nest" to "combination_limit".
1535 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1536 (Fset_window_nest): Rename to Fset_window_combination_limit.
1537 (Vwindow_nest): Rename to Vwindow_combination_limit.
1538 (recombine_windows, make_parent_window, make_window)
1539 (Fsplit_window_internal, saved_window)
1540 (Fset_window_configuration, save_window_save): Rename all
1541 occurrences of window_nest to window_combination_limit.
1543 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1545 * image.c (imagemagick_load_image): Fix typo.
1547 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1549 * xdisp.c (display_line): Move the call to
1550 highlight_trailing_whitespace before the call to
1551 compute_line_metrics, since the latter needs to see the final
1552 faces of all the glyphs to compute ROW's hash value.
1553 Fixes assertion violations in row_equal_p. (Bug#10035)
1555 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1557 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1558 just return (bug#10044).
1560 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1562 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1563 with user-defined heap size. Bump the default size of the temacs
1564 heap to 27MB, to avoid memory warning when running temacs.
1565 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1567 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1568 current_matrix and desired_matrix. (Bug#9990)
1569 (verify_row_hash) [XASSERTS]: New function.
1570 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1571 that the hash value of glyph rows is correct.
1573 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1575 * window.h (window): Remove splits slot.
1576 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1577 (Fdelete_other_windows_internal, make_parent_window)
1578 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1579 (Fset_window_configuration, save_window_save): Don't deal with
1580 split status of windows.
1581 (saved_window): Remove splits slot.
1582 (Vwindow_splits): Rewrite doc-string.
1584 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1586 * xfns.c (unwind_create_frame):
1587 * nsfns.m (unwind_create_frame):
1588 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1589 Vframe_list (Bug#9999).
1591 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1593 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1595 2011-11-11 Kenichi Handa <handa@m17n.org>
1597 * callproc.c (Fcall_process): Set the member dst_multibyte of
1600 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1602 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1603 avoid a crash (bug#9496).
1605 2011-11-09 Chong Yidong <cyd@gnu.org>
1607 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1608 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1610 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1612 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1614 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1616 Avoid some portability problems by eschewing 'extern inline' functions.
1617 The trivial performance wins aren't worth the portability hassles; see
1618 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1620 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1621 (window_box_width, window_box_left, window_box_left_offset)
1622 (window_box_right, window_box_right_offset): Undo previous change,
1623 by removing the "extern"s.
1624 * intervals.c (adjust_intervals_for_insertion)
1625 (adjust_intervals_for_deletion): Undo previous change,
1626 making these static again.
1627 (offset_intervals, temp_set_point_both, temp_set_point)
1628 (copy_intervals_to_string): No longer inline.
1629 * xdisp.c (window_text_bottom_y, window_box_width)
1630 (window_box_height, window_box_left_offset)
1631 (window_box_right_offset, window_box_left, window_box_right)
1632 (window_box): No longer inline.
1634 2011-11-08 Chong Yidong <cyd@gnu.org>
1636 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1637 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1638 Signal an error if not a live window.
1639 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1640 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1642 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1644 * lisp.h (syms_of_abbrev): Remove declaration.
1645 Reported by CHENG Gao <chenggao@royau.me>.
1647 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1649 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1650 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1651 of temacs in GUI mode.
1653 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1655 * window.h: Declare delete_all_child_windows instead of
1656 delete_all_subwindows.
1657 * window.c (Fwindow_nest, Fset_window_nest)
1658 (Fset_window_new_total, Fset_window_new_normal)
1659 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1660 (delete_all_subwindows): Rename to delete_all_child_windows.
1661 (Fdelete_other_windows_internal, Fset_window_configuration):
1662 Call delete_all_child_windows instead of delete_all_subwindows.
1663 * frame.c (delete_frame): Call delete_all_child_windows instead
1664 of delete_all_subwindows.
1666 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1668 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1669 This is also needed for porting to any host where GC_MARK_STACK is
1670 not GC_MAKE_GCPROS_NOOPS.
1671 (which_symbols): Use it.
1673 2011-11-07 Kenichi Handa <handa@m17n.org>
1675 * coding.c (coding_set_destination): Check coding->src_pos only
1676 when coding->src_object is a buffer (bug#9910).
1678 * process.c (send_process): Set the member src_multibyte of coding
1679 to 0 (bug#9911) when sending a unibyte text.
1681 * callproc.c (Fcall_process): Set the member src_multibyte of
1682 process_coding to 0 (bug#9912).
1684 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1686 * xmenu.c (cleanup_widget_value_tree): New function.
1687 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1688 calling free_menubar_widget_value_tree directly (Bug#9830).
1690 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1692 Fix some portability problems with 'inline'.
1693 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1694 (window_box_width, window_box_left, window_box_left_offset)
1695 (window_box_right, window_box_right_offset): Declare extern.
1696 Otherwise, these inline functions do not conform to C99 and
1697 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1698 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1699 * intervals.c (adjust_intervals_for_insertion)
1700 (adjust_intervals_for_deletion): Now extern, because otherwise the
1701 extern inline functions 'offset_intervals' couldn't refer to it.
1702 (static_offset_intervals): Remove.
1703 (offset_intervals): Rewrite using the old contents of
1704 static_offset_intervals. The old version didn't conform to C99
1705 because an extern inline function contained a reference to an
1706 identifier with static linkage.
1708 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1710 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1713 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1715 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1716 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1717 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1718 return Qleft_to_right.
1720 2011-11-06 Chong Yidong <cyd@gnu.org>
1722 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1723 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1724 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1725 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1726 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1727 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1728 (Fwindow_vscroll): Doc fix.
1729 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1730 argument, since it makes no sense to pass a live window and for
1731 consistency with window-child.
1733 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1735 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1738 2011-11-05 Jason Rumney <jasonr@gnu.org>
1740 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1741 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1743 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1744 bitwise arithmetic preventing use of unicode-sip and non-truetype
1747 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1749 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1752 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1753 initialization code to keep similarity to xfns.c after changes
1756 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1758 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1759 (unwind_create_frame): New function (Bug#9943).
1760 (Fx_create_frame): Restructure code to be more similar to the one in
1761 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1762 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1763 Move terminal->reference_count++ just before making the frame official
1766 * nsterm.m (x_free_frame_resources): New function.
1767 (x_destroy_window): Move code to x_free_frame_resources.
1769 * xfns.c (unwind_create_frame): Fix comment.
1770 (Fx_create_frame, x_create_tip_frame):
1771 Move terminal->reference_count++ just before making the frame
1772 official. Move initialization of image_cache_refcount and
1773 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1775 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1777 Support MSVC build with newer versions of Visual Studio.
1778 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1779 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1782 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1783 which are not supported by MSVC.
1784 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1785 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1787 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1789 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1791 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1793 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1795 Support MSVC build with newer versions of Visual Studio.
1796 * w32.c: Don't include w32api.h for MSVC.
1797 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1799 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1800 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1801 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1802 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1804 (alloca) [_MSC_VER]: Define to _alloca.
1806 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1808 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1810 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1812 * xdisp.c (note_mouse_highlight): If either of
1813 previous/next-single-property-change returns nil, treat that as
1814 the beginning or the end of the buffer. (Bug#9955)
1816 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1818 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1819 label is not null (Bug#9951).
1820 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1823 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1825 * window.c (Fwindow_body_size): Mention in the doc string that the
1826 return value is in frame's canonical units. (Bug#9949)
1828 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1830 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1832 * w32fns.c (unwind_create_frame): If needed, free the glyph
1833 matrices of the partially constructed frame. (Bug#9943)
1834 * xfns.c (unwind_create_frame): Likewise.
1836 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1838 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1839 Don't stop backward scan on the continuation glyph, even though
1840 its CHARPOS is positive.
1841 (mouse_face_from_buffer_pos, note_mouse_highlight):
1842 Rename cover_string to disp_string.
1844 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1846 * window.c (temp_output_buffer_show): Don't use
1847 Vtemp_buffer_show_specifiers.
1848 (Vtemp_buffer_show_specifiers): Remove unused variable.
1850 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1852 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1853 past the beginning of the current glyph matrix.
1855 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1857 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1858 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1859 HAVE_GTK3 (Bug#9869).
1861 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1862 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1864 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1866 * xterm.c: Declare x_handle_net_wm_state to return int.
1867 (handle_one_xevent): Check if we are iconified but don't have
1868 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1869 (get_current_wm_state): Return non-zero if not hidden,
1870 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1871 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1872 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1873 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1875 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1877 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1878 so that this new function doesn't get optimized away by a
1879 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1881 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1883 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1885 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1887 Fix the `xbytecode' command.
1888 * .gdbinit (xprintbytestr): New command.
1889 (xwhichsymbols): Rename from `which'; all callers changed.
1890 (xbytecode): Print the byte-code string as well.
1892 2011-10-29 Kim Storm <storm@cua.dk>
1894 * alloc.c (which_symbols): New function.
1896 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1898 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1901 2011-10-29 Glenn Morris <rgm@gnu.org>
1903 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1904 Not clear what it was for, and it causes various bugs. (Bug#9839)
1906 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1908 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1909 possible random value that matches one of those tested as
1910 condition to clear the mouse face.
1912 2011-10-28 Chong Yidong <cyd@gnu.org>
1914 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1916 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1918 * window.c (make_window): Initialize phys_cursor_on_p.
1920 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1922 * lisp.h (struct Lisp_Symbol): Update comments.
1924 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1926 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1928 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1930 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1931 <oslsachem@gmail.com> for helping to debug this.
1933 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1934 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1935 (g_b_init_get_glyph_outline_w): New static variables.
1936 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1937 (GetGlyphOutlineW_Proc): New typedefs.
1938 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1939 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1941 (w32font_open_internal, compute_metrics):
1942 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1943 instead of calling the "wide" APIs directly.
1945 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1947 * w32.h (syms_of_w32font): Add prototype.
1949 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1951 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1952 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1953 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1954 (Fmove_to_window_line): Doc fix.
1956 2011-10-27 Chong Yidong <cyd@gnu.org>
1958 * process.c (make_process): Set gnutls_state to NULL.
1960 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1961 non-NULL, regardless of GNUTLS_INITSTAGE.
1962 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1963 an error. Set process slots as soon as we allocate them.
1965 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1967 2011-10-27 Chong Yidong <cyd@gnu.org>
1969 * gnutls.c (emacs_gnutls_deinit): New function.
1970 Deallocate credentials structures as well as calling gnutls_deinit.
1971 (Fgnutls_deinit, Fgnutls_boot): Use it.
1973 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1974 (deactivate_process): Call emacs_gnutls_deinit.
1976 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1978 * image.c (x_create_x_image_and_pixmap):
1979 * w32.c (sys_rename, w32_delayed_load):
1980 * w32font.c (fill_in_logfont):
1981 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1983 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1985 * w32fns.c (w32_default_color_map): New function,
1986 extracted from Fw32_default_color_map.
1987 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1989 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1991 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1993 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1995 * keyboard.c (test_undefined): New function (bug#9751).
1996 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1998 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2000 * sysdep.c (init_sys_modes): Fix the check for the controlling
2001 terminal (Bug#6649).
2003 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2005 * dispextern.h (struct bidi_it): New member next_en_type.
2007 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2008 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2009 current character, check also for next_en_type being WEAK_EN.
2010 (bidi_resolve_weak): Don't enter the expensive loop if the current
2011 position is before next_en_pos. Record the bidi type of the first
2012 non-ET, non-BN character we find, in addition to its position.
2013 (bidi_level_of_next_char): Invalidate next_en_type when
2014 next_en_pos is over-stepped.
2016 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2018 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2019 * editfns.c: Rewrite current-time-zone so that it invokes
2020 the equivalent of (format-time-string "%Z") to get the time zone name.
2021 This fixes a bug when the time zone name contains characters that
2022 need converting from the system time locale to Emacs internal format.
2023 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2024 that patch fixed format-time-string to do the conversion, but
2025 I forgot to fix current-time-zone.
2026 (format_time_string): New function, containing most of
2027 what Fformat_time_string used to contain.
2028 (Fformat_time_string): Rewrite in terms of format_time_string.
2029 This doesn't change this function's behavior.
2030 (current-time-zone): Rewrite to use format_time_string.
2031 This fixes the bug reported by Michael Schierl in
2032 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2033 Jason Rumney's 2007-06-07 change worked around this bug, but
2035 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2037 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2039 * xdisp.c (start_display): If the character at POS is displayed
2040 via a display vector, reset IT->current.dpvec_index to zero.
2041 (try_window_reusing_current_matrix): If a line ends in a display
2042 vector or the next line starts in a display vector, continue
2043 redrawing the window even though the character position of
2044 start_row was reached.
2047 2011-10-18 Chong Yidong <cyd@gnu.org>
2049 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2050 with nobreak-char-display too.
2052 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2054 Fix part 3 of bug#9771.
2055 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2056 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2057 non-neutral characters if the current character is a paragraph
2058 separator (a.k.a. Newline). This avoids running the same
2059 expensive loop twice, once when we consume the preceding newline
2060 and the other time when the line actually needs to be displayed.
2061 Avoid the loop when we see neutrals on the base embedding level
2062 following a character whose directionality is the same as the
2063 paragraph's. This avoids running the expensive loop when a line
2064 ends in a long sequence of neutrals, like control characters.
2065 Add assertion against STRONG_AL type. Slightly rearrange code
2066 that determines the type of a neutral given the first non-neutral
2068 (bidi_level_of_next_char): Set next_en_pos to zero when
2069 invalidating its info.
2071 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2073 * xdisp.c (push_display_prop): Determine whether to record string
2074 or buffer position by IT->string, not by IT->method. Allow
2075 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2076 (move_it_vertically_backward): Don't look for character position
2077 immediately after the newline when in a continuation line.
2080 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2082 * window.c (coordinates_in_window): Rewrite and delabelize
2083 vertical border check. (Bug#5357) (Bug#9618)
2085 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2087 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2088 errors in XSetWindowBorder (bug#9310).
2090 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2092 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2093 avoid crash when xmalloc overrun checking is enabled.
2095 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2097 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2098 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2099 cursor motion with <left> and <right> arrow keys.
2101 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2102 some callers set that themselves.
2104 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2106 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2107 display string and the previous row comes from the same string and
2108 is empty. (Bug#9739) (Bug#9738)
2110 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2112 * doc.c (get_doc_string): Encode file name (bug#9735).
2114 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2116 * bidi.c (bidi_level_of_next_char):
2117 * xdisp.c (get_visually_first_element): Remove old incorrect
2118 comments regarding the Unicode Line Separator character.
2120 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2122 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2124 * alloc.c (Fgc_status): Do not access beyond zombies array
2125 boundary if nzombies > MAX_ZOMBIES.
2126 * alloc.c (dump_zombies): Add missing format specifier.
2128 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2130 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2131 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2133 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2134 Some packages use them to denote characters with modifiers.
2136 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2138 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2139 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2140 matching a pp-number. Rename parameter var to var1.
2142 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2144 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2146 2011-10-08 Glenn Morris <rgm@gnu.org>
2148 * callint.c (Fcall_interactively): Give a more explicit error for the
2149 'c' case with a non-character input. (Bug#8479)
2151 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2153 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2155 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2156 lines that are hscrolled on the left.
2158 * dispnew.c (buffer_posn_from_coords): Account for a possible
2159 presence of header-line. (Bug#4426)
2161 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2163 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2164 Don't advertise functionality which we discourage or doesn't work.
2166 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2168 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2169 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2170 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2171 this makes Emacs dump core during garbage collection on rare
2172 occasions. sizeof is obviously inferior to offsetof here, so
2173 stick with offsetof.
2174 (GC_POINTER_ALIGNMENT): New macro.
2175 (mark_memory): Omit 3rd (offset) arg; caller changed.
2176 Don't assume EMACS_INT alignment is the same as pointer alignment.
2178 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2180 * keyboard.c (read_key_sequence_remapped): New var.
2181 (read_key_sequence): Compute remapping in the right buffer.
2182 (command_loop_1): Use read_key_sequence's remapping directly.
2184 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2186 * dired.c (file_name_completion): Don't expand file name.
2187 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2188 before checking file name handler.
2190 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2191 they've been requested explicitly (bug#9591).
2193 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2195 * keymap.c (Fsingle_key_description): Use make_specified_string
2196 instead of build_string to build string from push_key_description.
2199 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2201 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2202 This fixes a Y2038 bug on 64-bit hosts.
2203 * buffer.c (reset_buffer):
2204 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2205 (Fclear_buffer_auto_save_failure):
2206 Use 0, not -1, to represent an unset failure time, since time_t
2207 might not be signed.
2209 Remove dependency on glibc malloc internals.
2210 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2211 Move back here from lisp.h, but with their new implementations.
2212 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2213 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2214 * charset.c (charset_table_init): New static var.
2215 (syms_of_charset): Use it instead of xmalloc. This removes a
2216 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2217 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2218 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2219 Move back to alloc.c.
2220 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2221 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2223 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2225 * nsterm.m (windowDidResize): Call x_set_window_size only when
2226 ns_in_resize is true. Otherwise set pixelwidth/height and
2227 call change_frame_size (Bug#9628).
2229 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2231 Port --enable-checking=all to Fedora 14 x86-64.
2232 * charset.c (syms_of_charset): Also account for glibc malloc's
2233 internal overhead when calculating the initial malloc maximum.
2235 Port --enable-checking=all to Fedora 14 x86.
2236 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2238 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2239 (overrun_check_realloc, overrun_check_free):
2240 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2241 That way, xmalloc returns a properly-aligned pointer even if
2242 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2243 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2244 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2245 into account when calculating the initial malloc maximum.
2246 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2247 Move here from alloc.c, so that charset.c can use it too.
2248 Properly align; the old code wasn't right for common 32-bit hosts
2249 when configured with --enable-checking=all.
2250 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2251 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2253 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2255 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2258 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2260 * xdisp.c (compute_display_string_end): If there's no display
2261 string at CHARPOS, return -1.
2263 * bidi.c (bidi_fetch_char): When compute_display_string_end
2264 returns a negative value, treat the character as a normal
2265 character not covered by a display string. (Bug#9624)
2267 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2269 * lread.c (Fread_from_string): Fix typo in docstring.
2271 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2273 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2274 newline, reseat the iterator instead of bidi-iterating there one
2275 character at a time. (Bug#9610)
2276 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2277 TO_CHARPOS if the bidi iterator is at base embedding level.
2279 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2281 * lread.c (readevalloop): Use correct code for NBSP.
2282 (read1): Likewise. (Bug#9608)
2284 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2286 * dbusbind.c (Fdbus_register_signal): When service is not
2287 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2289 2011-09-25 Glenn Morris <rgm@gnu.org>
2291 * buffer.c (truncate-lines): Doc fix.
2293 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2295 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2296 (Fset_window_next_buffers): Doc fix.
2298 2011-09-24 Glenn Morris <rgm@gnu.org>
2300 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2302 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2304 Fix minor problems found by static checking.
2305 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2306 * indent.c (Fvertical_motion): Fix == vs = typo.
2308 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2310 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2311 Default value is now t. Doc fix.
2313 * indent.c (Fvertical_motion): Compute and apply the overshoot
2314 logic when moving up, not only when moving down. Fix the
2315 confusing name and values of the it_overshoot_expected variable;
2316 logic changes accordingly. (Bug#9254) (Bug#9549)
2318 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2319 CHARPOS is covered by a display string which includes newlines.
2320 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2321 is covered by a display string with embedded newlines.
2323 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2325 * dbusbind.c (Fdbus_register_signal): Add match rule to
2326 Vdbus_registered_objects_table. (Bug#9581)
2327 (Fdbus_register_method, Vdbus_registered_objects_table):
2330 2011-09-24 Jim Meyering <meyering@redhat.com>
2332 do not ignore write error for any output size
2333 The previous change was incomplete.
2334 While it makes emacs --batch detect the vast majority of stdout
2335 write failures, errors were still ignored whenever the output size is
2336 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2337 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2338 && echo FAIL: ignored write error
2339 FAIL: ignored write error
2340 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2341 && echo FAIL: ignored write error
2342 FAIL: ignored write error
2343 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2345 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2347 * emacs.c (Fkill_emacs): In noninteractive mode exit
2348 non-successfully if a write error occurred on stdout. (Bug#9574)
2350 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2352 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2355 * dispextern.h (struct it): Update the comment documenting what
2358 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2360 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2361 a display string, extend search for cursor position to end of row.
2362 (find_row_edges): If the row ends in a newline from a display
2363 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2364 Handle the case of a display string with multiple newlines.
2365 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2366 non-empty line. Fixes confusing cursor motion with arrow keys at
2367 the beginning of a line that starts with whitespace.
2369 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2371 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2374 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2376 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2379 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2381 * xdisp.c (display_line): Record maximum and minimum buffer
2382 positions even if no glyphs were produced (e.g., by a zero-width
2383 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2384 buffer positions that will be removed from the glyph row because
2386 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2387 column is beyond frame width: don't subtract 1 "pixel" when
2388 computing width of the stretch.
2389 (reseat_at_next_visible_line_start): Undo the change made on
2390 2011-09-17 that saved paragraph information and restored it after
2391 the call to `reseat'. (Bug#9545)
2393 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2395 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2396 and turn window cursor on if cleared (Bug#9415).
2398 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2400 * search.c (boyer_moore): Take unibyte characters from pattern
2401 literally. (Bug#9458)
2403 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2405 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2407 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2409 Fix minor problem found by static checking.
2410 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2411 initialized, to pacify gcc -Wuninitialized.
2413 * fileio.c: Report proper errno when syscall falls.
2414 (Finsert_file_contents): Save and restore errno,
2415 so that report_file_error outputs the correct diagnostic.
2416 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2418 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2420 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2422 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2424 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2425 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2427 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2429 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2430 about the current paragraph and restore it after the call to reseat.
2432 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2433 (bidi_find_paragraph_start): Search back for paragraph beginning
2434 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2435 (bidi_move_to_visually_next): Only trigger paragraph-related
2436 computations when the last character is a newline or at EOB, not
2437 just any NEUTRAL_B. (Bug#9470)
2439 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2440 truncated lines if point is covered by a display string. (Bug#9524)
2442 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2444 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2445 (cons_to_x_long): New function.
2446 (lisp_data_to_selection_data): Use it. Correct the test for
2447 short-versus-long data; it was negated. Break out of vector
2448 loop, for efficiency, when a long datum is discovered.
2450 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2452 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2454 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2456 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2457 GCC PR/17406) by declaring this function with external scope.
2459 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2461 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2462 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2464 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2466 * editfns.c (Fformat): Correctly handle text properties on "%%".
2468 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2470 * xterm.c (x_draw_composite_glyph_string_foreground):
2471 * w32term.c (x_draw_composite_glyph_string_foreground):
2472 * term.c (encode_terminal_code):
2473 * composite.c (composition_update_it, get_composition_id):
2474 * xdisp.c (get_next_display_element)
2475 (fill_composite_glyph_string): Add comments about special meaning
2476 of TAB characters in a composition.
2478 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2480 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2481 This occurs when processing a multibyte format.
2482 Problem reported by Wolfgang Jenker.
2484 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2486 * xdisp.c (try_cursor_movement): Only check for exact match if
2487 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2489 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2491 Remove unused external symbols.
2492 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2493 * xdisp.c (calc_pixel_width_or_height): Now static.
2494 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2495 * indent.c (check_display_width):
2496 * w32term.c: Fix comment to match code.
2497 * xterm.c, xterm.h (x_catching_errors): Remove.
2499 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2501 * xselect.c: Use signed conversions more consistently (Bug#9498).
2502 (selection_data_to_lisp_data): Assume incoming selection data are
2503 signed integers, not unsigned. This is to be consistent with
2504 outgoing selection data, which was modified to use signed integers
2505 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2506 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2507 expects long, not unsigned long.
2509 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2511 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2512 computation of loop end. Reported by Johan Bockgård
2515 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2517 * frame.c (Fother_visible_frames_p): Function deleted.
2519 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2521 * indent.c (compute_motion): Process display vector front to back
2522 rather than the other way around. (Bug#2496)
2524 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2526 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2528 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2530 * minibuf.c (Fread_from_minibuffer): Doc fix.
2532 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2534 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2535 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2537 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2539 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2540 value for non-existent files.
2542 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2544 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2545 set its "size" to -1. This will set the modtime_size field of
2546 the corresponding buffer to -1, which is what
2547 verify-visited-file-modtime expects for files that do not exist.
2550 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2552 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2554 * lisp.h: ... from here. push_key_description is no longer
2555 defined in keyboard.c, so its declaration should not be in
2556 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2557 logically belongs with push_key_description.
2559 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2561 * buffer.h: Include <sys/types.h> instead of <time.h>.
2562 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2563 Problem reported by Herbert J. Skuhra.
2565 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2567 * xml.c (parse_region): Make the parsing work for
2568 non-comment-starting XML files again (bug#9144).
2570 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2572 * image.c (gif_load): Fix calculation of bottom and right corner.
2575 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2577 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2578 redisplay in small windows.
2580 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2582 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2584 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2586 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2587 Operate on live windows only.
2589 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2591 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2593 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2595 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2596 only under bidi iteration.
2598 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2600 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2602 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2604 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2605 Without this fix, the command to link temacs failed due to an
2606 undefined symbol __builtin_isnan. This is because
2607 /usr/include/iso/math_c99.h #defines isnan(x) to
2608 __builtin_isnan(x), but the bundled gcc, which identifies itself
2609 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2611 * floatfns.c (isnan): #undef, and then #define to a clone of
2613 (Fisnan): Always define, since it's always available now.
2614 (syms_of_floatfns): Always define isnan at the Lisp level.
2616 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2618 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2620 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2622 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2623 The previous code assumed that file offsets (off_t values) fit in
2624 EMACS_INT variables, which is not true on typical 32-bit hosts.
2625 The code messed up by falsely reporting buffer overflow in cases
2626 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2627 when "big" contains more than 2**29 bytes, even though this
2628 inserts just one byte and does not overflow the buffer.
2629 (Finsert_file_contents): Store file offsets as off_t
2630 values, not as EMACS_INT values. Check for overflow when
2631 converting between EMACS_INT and off_t. When checking for
2632 buffer overflow or for overlap, take the offsets into account.
2633 Don't use EMACS_INT for small values where int suffices.
2634 When checking for overlap, fix a typo: ZV was used where
2635 ZV_BYTE was intended.
2636 (Fwrite_region): Don't assume off_t fits into 'long'.
2637 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2639 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2641 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2643 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2645 sprintf-related integer and memory overflow issues (Bug#9412).
2647 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2648 (esprintf, exprintf, evxprintf): New functions.
2649 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2650 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2651 (modify_event_symbol): Do not assume that the length of
2652 name_alist_or_stem is safe to alloca and fits in int.
2653 (Fexecute_extended_command): Likewise for function name and binding.
2654 (Frecursion_depth): Wrap around reliably on integer overflow.
2655 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2656 since some callers pass EMACS_INT values.
2657 (Fsingle_key_description): Don't crash if symbol name contains more
2658 than MAX_ALLOCA bytes.
2659 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2660 (get_minibuffer): Arg is now EMACS_INT, not int.
2661 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2662 (esprintf, exprintf, evxprintf): New decls.
2663 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2665 * dbusbind.c (signature_cat): New function.
2666 (xd_signature, Fdbus_register_signal):
2667 Do not overrun buffer; instead, report string overflow.
2669 * dispnew.c (add_window_display_history): Don't overrun buffer.
2670 Truncate instead; this is OK since it's just a log.
2672 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2673 even if the time zone offset is outlandishly large.
2674 Don't mishandle offset == INT_MIN.
2676 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2677 when creating daemon; the previous buffer-overflow check was incorrect.
2679 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2680 which has the guts of the old verror function.
2682 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2683 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2685 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2686 (font_unparse_xlfd): Don't blindly alloca long strings.
2687 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2688 fits in int, when using sprintf. Use single snprintf to count
2689 length of string rather than counting it via multiple sprintfs;
2690 that's simpler and more reliable.
2691 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2692 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2693 sprintf, in case result does not fit in int.
2695 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2696 (fontset_from_font): Print it.
2698 * frame.c (tty_frame_count): Now printmax_t, not int.
2699 (make_terminal_frame, set_term_frame_name): Print it.
2700 (x_report_frame_params): In X, window IDs are unsigned long,
2701 not signed long, so print them as unsigned.
2702 (validate_x_resource_name): Check for implausibly long names,
2703 and don't assume name length fits in 'int'.
2704 (x_get_resource_string): Don't blindly alloca invocation name;
2705 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2708 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2709 (xg_check_special_colors, xg_set_geometry):
2710 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2712 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2713 Use esprintf, not sprintf, in case result does not fit in int.
2715 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2716 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2717 it as a large positive number.
2718 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2719 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2721 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2722 in case result does not fit in int.
2724 * print.c (float_to_string): Detect width overflow more reliably.
2725 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2726 buffer overrun. Don't assume list length fits in 'int'. Treat
2727 print length of 0 as 0, not as infinity; to be consistent with other
2728 uses of print length in this function. Don't overflow print length
2729 index. Don't assume hash table size fits in 'long', or that
2730 vectorlike size fits in 'unsigned long'.
2732 * process.c (make_process): Use printmax_t, not int, to format
2733 process-name gensyms.
2735 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2737 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2738 to avoid potential buffer overrun.
2740 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2741 if X resource line is longer than 512 bytes.
2743 * xfns.c (x_window): Make sprintf buffer a bit bigger
2744 to avoid potential buffer overrun.
2746 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2748 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2750 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2752 Integer overflow fixes for scrolling, etc.
2753 Without these, Emacs silently mishandles large integers sometimes.
2754 For example, "C-u 4294967297 M-x recenter" was treated as if
2755 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2757 * xdisp.c (try_window_id): Check Emacs fixnum range before
2758 converting to 'int'.
2760 * window.c (window_scroll_line_based, Frecenter):
2761 Check that an Emacs fixnum is in range before assigning it to 'int'.
2762 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2763 values converted from Emacs fixnums.
2764 (Frecenter): Don't wrap around a line count if it is out of 'int'
2765 range; instead, treat it as an extreme value.
2766 (Fset_window_configuration, compare_window_configurations):
2767 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2769 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2770 that can exceed INT_MAX. Check that EMACS_INT value is in range
2771 before assigning it to the (possibly-narrower) index.
2772 (match_limit): Don't assume that a fixnum can fit in 'int'.
2774 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2777 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2778 (Fvertical_motion): Don't wrap around LINES values that don't fit
2779 in 'int'. Instead, treat them as extreme values. This is good
2780 enough for windows, which can't have more than INT_MAX lines anyway.
2782 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2784 * Require libxml/parser.h to avoid compilation warning.
2786 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2788 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2789 since this reportedly can destroy thread storage.
2791 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2793 * syntax.c (find_defun_start): Update all cache variables if
2794 exiting early (Bug#9401).
2796 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2798 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2800 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2801 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2802 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2804 * term.c (tty_append_glyph): New function.
2805 (produce_stretch_glyph): Static function and its prototype deleted.
2807 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2810 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2812 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2813 when checking :margin (Bug#9390).
2814 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2815 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2816 so that the name doesn't mislead. All uses changed.
2818 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2820 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2823 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2825 * xdisp.c (move_it_to): Don't bail out early when reaching
2826 position beyond to_charpos, if we are scanning backwards.
2827 (move_it_vertically_backward): When DY == 0, make sure we get to
2828 the first character in the line after the newline.
2830 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2832 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2833 (ccl_driver): Do not generate an out-of-range pointer.
2834 (Fccl_execute_on_string): Remove unnecessary check for
2835 integer overflow, noted by Stefan Monnier in
2836 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2837 Remove a FIXME that didn't need fixing.
2838 Simplify the newly-introduced buffer reallocation code.
2840 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2842 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2844 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2846 Integer and memory overflow issues (Bug#9196).
2848 * doc.c (get_doc_string): Rework so that
2849 get_doc_string_buffer_size is the actual buffer size, rather than
2850 being 1 less than the actual buffer size; this makes xpalloc more
2853 * image.c (x_allocate_bitmap_record, cache_image):
2854 * xselect.c (Fx_register_dnd_atom):
2855 Simplify previous changes by using xpalloc.
2857 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2858 since either will do and ptrdiff_t is convenient with xpalloc.
2860 * charset.c (charset_table_size)
2861 (struct charset_sort_data.priority): Now ptrdiff_t.
2862 (charset_compare): Don't overflow if priorities differ greatly.
2863 (Fsort_charsets): Don't assume list length fits in int.
2864 Check for size-calculation overflow when allocating sort data.
2865 (syms_of_charset): Allocate an initial charset table that is
2866 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2868 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2870 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2871 The actual value is always <= INT_MAX, and leaving it unsigned made
2872 overflow checking harder.
2874 * dispextern.h (struct glyph_matrix.rows_allocated)
2875 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2876 with xpalloc. The values are still always <= INT_MAX.
2878 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2880 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2881 (SAFE_NALLOCA): New macro.
2883 * region-cache.c (struct boundary.pos, find_cache_boundary)
2884 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2885 (set_cache_region, invalidate_region_cache)
2886 (revalidate_region_cache, know_region_cache, region_cache_forward)
2887 (region_cache_backward, pp_cache):
2888 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2889 so that ptrdiff_t * can be passed to xpalloc.
2890 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2891 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2892 (pp_cache): Don't assume cache_len fits in int.
2893 * region-cache.h: Adjust extern decls to match.
2895 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2896 EMACS_INT, since either will do, for xpalloc.
2898 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2899 (xnmalloc, xnrealloc, xpalloc): New functions.
2901 * bidi.c (bidi_shelve_header_size): New constant.
2902 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2903 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2905 * bidi.c (bidi_cache_shrink):
2906 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2908 Don't update size of array until after memory allocation succeeds,
2909 because xmalloc/xrealloc may not return.
2910 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2911 now that we have proper integer overflow checking.
2912 (record_overlay_string, overlay_strings): Catch overflows when
2913 calculating size of overlay_str_buf.
2915 * callproc.c (Fcall_process): Check for size overflow when
2916 calculating size of args2.
2917 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2918 Normally we prefer signed values, but sticking with ptrdiff_t would
2919 require adding more-complicated checks.
2921 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2922 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2923 Redo buffer-overflow calculations to avoid integer overflow.
2924 Add a FIXME comment where memory seems to be over-allocated.
2926 * character.c (Fstring): Check for size-calculation overflow.
2928 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2929 unnecessary integer overflow. Check for size overflow.
2930 (encode_coding_object): Don't update size until xmalloc succeeds.
2932 * composite.c (get_composition_id): Check for overflow in glyph
2933 length calculations.
2935 Integer and memory overflow fixes for display code.
2936 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2937 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2938 (scrolling_window): Check for overflow in size calculations.
2939 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2940 Don't assume glyph table len fits in int.
2941 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2942 (row_table_size): Now ptrdiff_t, not int.
2943 (scrolling_window): Avoid overflow in size calculations.
2944 Don't update size until allocation succeeds.
2945 * fns.c (concat): Check for overflow in size calculations.
2946 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2947 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2948 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2950 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2951 (get_doc_string): Check for size calculation overflow.
2952 Don't update size until allocation succeeds.
2953 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2954 EMACS_INT, where ptrdiff_t will do.
2955 (Fsubstitute_command_keys): Check for string overflow.
2957 * editfns.c (set_time_zone_rule): Don't assume environment length
2959 (message_length): Now ptrdiff_t, not int.
2960 (Fmessage_box): Don't update size until allocation succeeds.
2961 Don't assume message length fits in int.
2962 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2964 * emacs.c (main): Do not reallocate argv, since there is a null at
2965 the end that can be overwritten, and this way there's no need to
2966 worry about size-calculation overflow.
2967 (sort_args): Check for size-calculation overflow.
2969 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2971 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2973 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2974 (x_set_scroll_bar_width, x_figure_window_size):
2975 Check for integer overflow.
2976 (x_set_alpha): Do not assume XINT fits in int.
2978 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2979 This is for the members text_lines, text_cols, total_lines, total_cols,
2980 where the system imposes an 'int' limit.
2982 * fringe.c (Fdefine_fringe_bitmap):
2983 Don't update size until alloc works.
2985 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2986 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2988 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2989 Check for size-calculation overflow.
2990 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2991 do, as we prefer signed integers.
2992 (id_to_widget.max_size, id_to_widget.used)
2993 (xg_store_widget_in_map, xg_remove_widget_from_map)
2994 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2995 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2996 Use and return ptrdiff_t, not int.
2997 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2998 * gtkutil.h: Change prototypes to match the above.
3000 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3001 are duplicate now that they've been promoted to lisp.h.
3002 (x_allocate_bitmap_record, x_alloc_image_color)
3003 (make_image_cache, cache_image, xpm_load):
3004 Don't update size until alloc is done.
3005 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3007 Check for size calculation overflow.
3008 (ct_colors_allocated_max): New constant.
3009 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3012 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3013 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3014 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3015 Use ptrdiff_t, not int, to count maps.
3016 (read_char_minibuf_menu_prompt): Check for overflow in size
3017 calculations. Don't update size until allocation succeeds.
3018 Redo calculations to avoid overflow.
3019 * keyboard.h: Change prototypes to match the above.
3021 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3023 (current_minor_maps): Check for size calculation overflow.
3024 * keymap.h: Change prototypes to match the above.
3026 * lread.c (read1, init_obarray): Don't update size until alloc done.
3028 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3029 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3031 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3032 Now ptrdiff_t, not int.
3033 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3034 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3036 * process.c (Fnetwork_interface_list): Check for overflow
3037 in size calculation.
3039 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3041 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3042 overflow. Don't bother calling xmalloc when xrealloc will do.
3044 * search.c (Freplace_match): Check for size calculation overflow.
3045 (Fset_match_data): Don't assume list lengths fit in 'int'.
3047 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3048 for command line length. Do not attempt to address one before the
3049 beginning of an array, as that's not portable.
3051 * term.c (max_frame_lines): Remove; unused.
3052 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3054 (encode_terminal_code, calculate_costs): Check for size
3055 calculation overflow.
3056 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3057 table lengths and related sizes. Don't update size until alloc
3058 done. Redo calculations to avoid overflow.
3059 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3061 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3062 subtracting pointers.
3063 (gobble_line): Check for overflow more carefully. Don't update size
3066 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3067 Don't update size until alloc done.
3068 Redo size calculations to avoid overflow.
3069 Check for size calculation overflow.
3070 (main) [DEBUG]: Fix typo in invoking tparam1.
3072 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3073 Use ptrdiff_t, not int, for sizes.
3074 (store_mode_line_noprop_char): Don't update size until alloc done.
3076 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3077 Use ptrdiff_t, not int, for sizes.
3078 (Finternal_make_lisp_face, cache_face):
3079 Check for size calculation overflow.
3080 (cache_face): Treat size calculation overflows as if they were
3081 memory exhaustion (the usual treatment), rather than aborting.
3083 * xfns.c (x_encode_text, x_set_name_internal)
3084 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3085 sizes, since they can exceed INT_MAX in size. Check for size
3086 calculation overflow.
3088 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3089 (xg_select): Check for size calculation overflow.
3090 Don't update size until alloc done.
3092 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3093 as sprintf is limited to int lengths.
3095 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3096 (X_LONG_MIN): New macros.
3097 Use them to make the following changes clearer.
3098 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3099 This change doesn't affect the value now, but it may help remind
3100 future maintainers not to raise the value too much later.
3101 (SELECTION_QUANTUM): Remove, replacing with ...
3102 (selection_quantum): ... new function, which avoids overflow.
3104 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3105 assumption that selection length fits in 'int'.
3106 (x_reply_selection_request, x_handle_selection_request)
3107 (x_get_window_property, receive_incremental_selection)
3108 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3109 (lisp_data_to_selection_data, clean_local_selection_data):
3110 Use ptrdiff_t, not int, to record length of selection.
3111 (x_reply_selection_request, x_get_window_property)
3112 (receive_incremental_selection, x_property_data_to_lisp):
3113 Redo calculations to avoid overflow.
3114 (x_reply_selection_request): When sending hint, ceiling it at
3115 X_LONG_MAX rather than relying on wraparound overflow to send
3117 (x_get_window_property, receive_incremental_selection)
3118 (lisp_data_to_selection_data, x_property_data_to_lisp):
3119 Check for size-calculation overflow.
3120 (x_get_window_property, receive_incremental_selection)
3121 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3122 Don't store size until memory allocation succeeds.
3123 (x_get_window_property): Plug memory leak on memory exhaustion.
3124 Don't double-block input; malloc is safe here. Don't assume 2**34
3125 - 4 fits in unsigned long. Add an xassert to check
3126 XGetWindowProperty overflow. Be more careful about overflow
3127 calculations, and distinguish size from memory overflow better.
3128 (receive_incremental_selection): When tracing, don't assume
3129 unsigned int is less than INT_MAX.
3130 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3131 harmful) conversions of unsigned short to int.
3132 (lisp_data_to_selection_data): Don't assume that integers
3133 in the range -65535 through -1 fit in an X unsigned short.
3134 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3135 result parameters unless successful. Rely on cons_to_unsigned
3136 to report problems with elements; the old code wasn't right anyway.
3137 (x_check_property_data): Check for int overflow; we cannot use
3138 a wider type due to X limits.
3139 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3141 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3143 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3144 (x_term_init): Check for size calculation overflow.
3145 (x_color_cells): Don't store size until memory allocation succeeds.
3146 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3147 Don't assume alloca size is less than MAX_ALLOCA.
3148 (x_term_init): Don't assume length fits in int (sprintf is limited
3151 Use ptrdiff_t for composition IDs.
3152 * character.c (lisp_string_width):
3153 * composite.c (composition_table_size, n_compositions)
3154 (get_composition_id, composition_gstring_from_id):
3155 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3156 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3157 * window.c (Frecenter):
3158 Use ptrdiff_t, not int, for composition IDs.
3159 * composite.c (get_composition_id): Check for integer overflow.
3160 * composite.h: Adjust prototypes to match the above changes.
3162 Use ptrdiff_t for hash table indexes.
3163 * category.c (hash_get_category_set):
3164 * ccl.c (ccl_driver):
3165 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3166 * coding.c (coding_system_charset_list, detect_coding_system):
3167 * coding.h (struct coding_system.id):
3168 * composite.c (get_composition_id, gstring_lookup_cache):
3169 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3170 * image.c (xpm_get_color_table_h):
3171 * lisp.h (hash_lookup, hash_put):
3172 * minibuf.c (Ftest_completion):
3173 Use ptrdiff_t for hash table indexes, not int (which is too
3174 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3175 32-bit --with-wide-int hosts).
3177 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3178 Add a FIXME comment about memory leaks.
3179 (syms_of_charset): Don't assume xmalloc returns.
3181 Don't assume that stated character widths fit in int.
3182 * character.c (Fchar_width, c_string_width, lisp_string_width):
3183 * character.h (CHAR_WIDTH):
3184 * indent.c (MULTIBYTE_BYTES_WIDTH):
3185 Use sanitize_char_width to avoid undefined and/or bad behavior
3186 with outlandish widths.
3187 * character.h (sanitize_tab_width): Rename from sanitize_width,
3188 now that we have two such functions. All uses changed.
3189 (sanitize_char_width): New inline function.
3191 Don't assume that tab-width fits in int.
3192 * character.h (sanitize_width): New inline function.
3193 (SANE_TAB_WIDTH): New macro.
3194 (ASCII_CHAR_WIDTH): Use it.
3195 * indent.c (sane_tab_width): Remove. All uses replaced by
3196 SANE_TAB_WIDTH (current_buffer).
3197 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3199 * fileio.c: Integer overflow issues with file modes.
3200 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3202 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3203 Remove unreachable code.
3204 (read_hex, load_charset_map_from_file): Check for integer overflow.
3206 * xterm.c: Don't go over XClientMessageEvent limit.
3207 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3208 (x_send_scroll_bar_event): Likewise. Check that the size does not
3209 exceed limits imposed by XClientMessageEvent, as well as the usual
3210 ptrdiff_t and size_t limits.
3212 * keyboard.c: Overflow, signedness and related fixes.
3213 (make_lispy_movement): Use same integer type in forward decl
3214 that is used in the definition.
3215 (read_key_sequence, keyremap_step):
3216 Change bufsize argument back to int, undoing my 2011-03-30 change.
3217 We prefer signed types, and int is wide enough here.
3218 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3219 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3220 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3221 length, not size_t. Use ptrdiff_t for index, not int.
3222 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3223 possibility of integer overflow.
3225 Overflow, signedness and related fixes for images.
3227 * dispextern.h (struct it.stack[0].u.image.image_id)
3228 (struct_it.image_id, struct image.id, struct image_cache.size)
3229 (struct image_cache.used, struct image_cache.ref_count):
3230 * gtkutil.c (update_frame_tool_bar):
3231 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3232 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3233 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3234 * nsmenu.m (update_frame_tool_bar):
3235 * xdisp.c (calc_pixel_width_or_height):
3236 * xfns.c (image_cache_refcount):
3237 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3238 on typical 64-bit hosts.
3240 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3241 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3242 Omit unnecessary casts to int.
3243 (parse_image_spec): Check that integers fall into 'int' range
3244 when the callers expect that.
3245 (image_ascent): Redo ascent calculation to avoid int overflow.
3246 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3247 (lookup_image): Remove unnecessary tests.
3248 (xbm_image_p): Locals are now of int, not EMACS_INT,
3249 since parse_image_check makes sure they fit into int.
3250 (png_load, gif_load, svg_load_image):
3251 Prefer int to unsigned where either will do.
3252 (tiff_handler): New function, combining the cores of the
3253 old tiff_error_handler and tiff_warning_handler.
3254 This function is rewritten to use vsnprintf and thereby avoid
3255 stack buffer overflows. It uses only the features of vsnprintf
3256 that are common to both POSIX and native Microsoft.
3257 (tiff_error_handler, tiff_warning_handler): Use it.
3258 (tiff_load, gif_load, imagemagick_load_image):
3259 Don't assume :index value fits in 'int'.
3260 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3261 (imagemagick_load_image): Check that crop parameters fit into
3262 the integer types that MagickCropImage accepts. Don't assume
3263 Vimagemagick_render_type has a nonnegative value. Don't assume
3264 size_t fits in 'long'.
3265 (gs_load): Use printmax_t to print the widest integers possible.
3266 Check for integer overflow when computing image height and width.
3268 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3270 * xdisp.c (redisplay_window): Don't force window start if point
3271 will be invisible in the resulting window. (Bug#9324)
3273 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3275 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3276 the display spec is of the form `(space ...)'.
3277 (handle_display_spec): Return the value returned by
3278 handle_single_display_spec, not just 1 or zero.
3279 (handle_single_display_spec): If the display spec is of the form
3280 `(space ...)', and specifies display in the text area, return 2
3282 (try_cursor_movement): Check for the need to scroll more
3283 accurately, and prefer exact match for point under bidi.
3284 Don't advance `row' beyond the last row of the window.
3286 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3287 into disp_prop; all users changed.
3289 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3290 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3291 for the text covered by the display property.
3293 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3295 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3296 Change return value to nil.
3297 (Frecord_buffer): Delete unused function.
3299 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3301 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3302 buffers, return left-to-right.
3303 (set_cursor_from_row): Consider candidate row a win if its glyph
3304 represents a newline and point is on that newline. Fixes cursor
3305 positioning on the newline at EOL of R2L text within L2R
3306 paragraph, and vice versa.
3307 (try_cursor_movement): Check continued rows, in addition to
3308 continuation rows. Fixes unwarranted scroll when point enters a
3309 continued line of R2L text within an L2R paragraph, or vice versa.
3310 (cursor_row_p): Consider the case of point being equal to
3311 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3312 from the end of a short line to the beginning of a continued line
3313 of R2L text within L2R paragraph.
3314 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3315 composed characters.
3317 * bidi.c (bidi_check_type): Use xassert.
3318 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3321 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3323 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3326 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3328 * nsfont.m (ns_otf_to_script): Fix typo.
3330 2011-08-22 Kenichi Handa <handa@m17n.org>
3332 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3333 extra slot even if the purpose is char-code-property-table.
3335 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3337 * xdisp.c (redisplay_window): When computing centering_position,
3338 account for the height of the header line. (Bug#8874)
3340 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3341 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3342 candidate is selected by the mouse, and that candidate has a
3343 composed character under the mouse.
3345 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3346 coordinates reported by pos-visible-in-window-p for a composed
3347 character in column zero.
3349 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3351 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3353 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3355 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3356 consider it a hit if to_charpos is anywhere in the range of the
3357 composed buffer positions.
3359 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3361 * image.c (gif_load): Don't assume that each subimage has the same
3362 dimensions as the base image. Handle disposal method that is
3363 "undefined" by the gif spec (Bug#9335).
3365 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3367 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3368 (Fcondition_case): Document `debug' symbol in error handler.
3370 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3372 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3373 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3374 from an Org mode buffer to a Speedbar frame.
3376 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3377 a composition, take its buffer position from IT->cmp_it.charpos.
3378 Fixes cursor positioning at the beginning of a line that begins
3379 with a composed character.
3381 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3383 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3384 character bidirectional type, use STRONG_L instead. Fixes crashes
3385 in a buffer produced by `describe-categories'.
3387 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3388 members before the level stack, so they would be saved and
3389 restored when copying iterator state. Fixes incorrect reordering
3390 around TABs covered by display properties.
3392 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3394 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3396 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3398 * eval.c (internal_condition_case, internal_condition_case_1)
3399 (internal_condition_case_2, internal_condition_case_n):
3400 Remove unnecessary aborts (Bug#9081).
3402 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3404 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3405 has no `load' handler, try opening the file locally. (Bug#9311)
3407 2011-08-16 Ken Brown <kbrown@cornell.edu>
3409 * gmalloc.c: Expand comment.
3411 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3413 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3414 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3416 2011-08-16 Ken Brown <kbrown@cornell.edu>
3418 Fix memory allocation problems in Cygwin build (Bug#9273).
3420 * unexcw.c ( __malloc_initialized): Declare external variable.
3421 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3423 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3425 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3427 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3429 [CYGWIN] (special_realloc): New function.
3430 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3431 requests to realloc storage in the static heap.
3433 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3435 * bidi.c (bidi_initialize): Remove unused local.
3437 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3440 * biditype.h: Remove file.
3441 * makefile.w32-in ($(BLD)/bidi.$(O)):
3442 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3444 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3446 * chartab.c: Improve commentary for the uniprop_table API.
3448 * bidi.c (bidi_paragraph_init): Support zero value of
3449 bidi_ignore_explicit_marks_for_paragraph_level.
3450 (bidi_initialize): Use uniprop_table instead of including
3451 biditype.h and bidimirror.h.
3453 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3454 coordinates of the iterator when restoring from ppos_it.
3457 2011-08-14 Kenichi Handa <handa@m17n.org>
3459 * process.c (create_process): Call setup_process_coding_systems
3460 after the pid of the process is set to -1 (Bug#8162).
3462 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3464 * xdisp.c (move_it_in_display_line_to): Don't invoke
3465 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3466 ppos_it. Fixes vertical cursor motion when line beginning is
3467 covered by an image. (Bug#9296)
3469 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3471 * nsterm.h (ns_run_ascript): Declare.
3472 (NSAPP_DATA2_RUNASSCRIPT): Define.
3474 * nsfns.m (as_script, as_result, as_status): New static variables.
3475 (ns_run_ascript): New function.
3476 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3477 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3478 the event loop. Get status from as_status (Bug#7276).
3480 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3481 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3482 the event loop (Bug#7276).
3484 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3486 * gnutls.c (QCgnutls_bootprop_priority)
3487 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3488 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3489 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3490 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3491 (QCgnutls_bootprop_verify_hostname_error)
3492 (QCgnutls_bootprop_callbacks_verify): Rename from
3493 Qgnutls_bootprop_..., all uses changed.
3495 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3498 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3500 * xfaces.c (Qframe_set_background_mode): Now static.
3501 * dispextern.h (Qframe_set_background_mode): Remove decl.
3503 * process.c (Fnetwork_interface_info): Declare local only if needed.
3505 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3507 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3508 (Fnetwork_interface_list): Allocate in increments of bytes instead
3509 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3510 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3512 (struct ifflag_def): notrailers is smart on OSX.
3513 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3514 Get hardware address with getifaddrs if available.
3516 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3518 * xdisp.c (iterate_out_of_display_property): xassert that
3519 IT->position is set to within IT->object's boundaries. Break from
3520 the loop as soon as EOB is reached; avoids infloops in redisplay
3521 when IT->position is set up wrongly due to some bug.
3522 Set IT->current to match the bidi iterator unconditionally.
3523 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3524 entry. Force push_it to save on the stack the current
3525 buffer/string position, to be restored by pop_it. Fix flags in
3526 the iterator structure wrt the object coming from a display
3527 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3528 properties. (Bug#9284)
3530 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3532 * fontset.c (fontset_get_font_group): Add proper type checks.
3535 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3537 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3538 and LC_VERSION_MIN_MACOSX.
3539 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3540 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3542 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3544 * xdisp.c (forward_to_next_line_start): Allow to use the
3545 no-display-properties-and-no-overlays under bidi display.
3546 Set disp_pos in the bidi iterator to avoid searches for display
3547 properties and overlays.
3549 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3551 * editfns.c (Fset_time_zone_rule): Document relationship with the
3554 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3555 the font entity extracted from the cache (Bug#8109).
3557 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3559 * composite.c (autocmp_chars): Don't reset point. That is done by
3560 restore_point_unwind (Bug#5984).
3562 2011-08-07 Juri Linkov <juri@jurta.org>
3564 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3565 to show the arg `TIME' instead of `TIMEVAL'.
3567 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3569 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3570 display property strides EOL and includes a newline, as in
3571 longlines-mode. (Bug#9254)
3572 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3573 word-wrap under bidirectional display. (Bug#9224)
3575 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3576 is non-zero, even if the data buffer is NULL. Fixes a crash in
3577 vertical-motion with longlines-mode. (Bug#9254)
3579 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3581 * bidi.c <bidi_cache_total_alloc>: Now static.
3582 (bidi_initialize): Initialize bidi_cache_total_alloc.
3584 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3587 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3588 amount allocated this far in `bidi_cache_total_alloc'.
3589 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3590 non-zero, only free the data buffer without restoring the cache
3591 contents. All callers changed.
3593 * dispextern.h (bidi_unshelve_cache): Update prototype.
3595 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3596 (move_it_in_display_line, move_it_to)
3597 (move_it_vertically_backward, move_it_by_lines): Replace the call
3598 to xfree to an equivalent call to bidi_unshelve_cache.
3599 (move_it_in_display_line_to): Fix logic of returning
3600 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3602 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3604 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3605 came from a string character with a `cursor' property. (Bug#9229)
3607 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3609 * Makefile.in (LIB_PTHREAD): New variable.
3610 (LIBES): Add LIB_PTHREAD (Bug#9216).
3612 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3613 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3615 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3617 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3619 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3621 * xterm.c (x_find_topmost_parent): New function.
3622 (x_set_frame_alpha): Find topmost parent window with
3623 x_find_topmost_parent and set the property there also (bug#9181).
3624 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3626 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3628 * callproc.c (Fcall_process): Avoid vfork clobbering
3629 the local vars buffer, coding_systems, current_dir.
3631 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3633 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3635 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3637 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3638 so that it is not optimized away.
3640 * xdisp.c (compute_display_string_pos): Remove unused local.
3642 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3644 Fix slow cursor motion and scrolling in large buffers with
3645 selective display, like Org Mode buffers. (Bug#9218)
3647 * dispextern.h (struct bidi_it): New member disp_prop_p.
3649 * xdisp.c: Remove one-slot cache of display string positions.
3650 (compute_display_string_pos): Accept an additional argument
3651 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3652 for a display string or property. If found, set DISP_PROP_P
3655 * bidi.c (bidi_fetch_char): Accept an additional argument
3656 DISP_PROP_P, and pass it to compute_display_string_pos.
3657 Only handle text covered by a display string if DISP_PROP_P is returned
3658 non-zero. All callers of bidi_fetch_char changed.
3660 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3662 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3664 2010-12-03 Don March <don@ohspite.net>
3666 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3667 last character M-[char] is translated to ESC [char] (bug#7541).
3669 2011-08-02 Kenichi Handa <handa@m17n.org>
3671 * lisp.h (uniprop_table): Extern it.
3673 * chartab.c (uniprop_table): Make it non-static.
3675 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3677 * xdisp.c (forward_to_next_line_start): Accept additional argument
3678 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3680 (reseat_at_next_visible_line_start): Use the bidi iterator state
3681 returned by forward_to_next_line_start to restore the state of
3682 it->bidi_it after backing up to previous newline. (Bug#9212)
3684 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3686 * regex.c (re_comp): Protoize.
3687 (re_exec): Fix return type.
3688 (regexec): Fix type of `ret'. (Bug#9203)
3690 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3692 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3693 This is needed if max-image-size is a floating-point number.
3695 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3697 * print.c (print_object): Print empty symbol as ##.
3699 * lread.c (read1): Read ## as empty symbol.
3701 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3703 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3704 setting frame foreground color (Bug#9175).
3705 (x_set_background_color): Likewise.
3707 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3708 contents (Bug#9176).
3709 (EmacsTooltip -init): Remove bezels and add shadows to
3712 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3713 or scroll bar (Bug#8470).
3715 * nsfont.m (nsfont_open): Remove assignment to voffset and
3716 unnecessary vars hshink, expand, hd, full_height, min_height.
3717 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3719 * nsterm.h (nsfont_info): Remove voffset field.
3721 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3723 Implement strike-through and overline on NextStep (Bug#8863).
3725 * nsfont.m (nsfont_open): Use underline position provided by font,
3726 instead of hard-coded value of 2.
3727 (nsfont_draw): Call ns_draw_text_decoration instead.
3729 * nsterm.h: Add declaration for ns_draw_text_decoration.
3731 * nsterm.m (ns_draw_text_decoration): New function for drawing
3732 underline, overline, and strike-through.
3733 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3734 ns_draw_text_decoration. Change treatment of cursor drawing to
3735 accommodate underlining, etc.
3737 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3739 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3742 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3744 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3745 Without this fix, if a signal arrives just after memory fills up,
3746 'malloc' might be invoked reentrantly.
3748 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3749 In other words, assume that every image size is allowed, on non-X
3750 hosts. This assumption is probably wrong, but it lets Emacs compile.
3752 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3754 * regex.c (re_iswctype): Convert return values to boolean.
3756 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3758 * xdisp.c (compute_display_string_pos): Don't use cached display
3759 string position if the buffer had its restriction changed.
3762 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3764 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3766 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3768 Integer signedness and overflow and related fixes. (Bug#9079)
3770 * bidi.c: Integer size and overflow fixes.
3771 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3772 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3773 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3774 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3775 (bidi_find_other_level_edge):
3776 Use ptrdiff_t instead of EMACS_INT where either will do.
3777 This works better on 32-bit hosts configured --with-wide-int.
3778 (bidi_cache_ensure_space): Check for size-calculation overflow.
3779 Use % rather than repeated addition, for better worst-case speed.
3780 Don't set bidi_cache_size until after xrealloc returns, because it
3782 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3783 (bidi_cache_ensure_space): Also check that the bidi cache size
3784 does not exceed that of the largest Lisp string or buffer. See Eli
3785 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3787 * alloc.c (__malloc_size_t): Remove.
3788 All uses replaced by size_t. See Andreas Schwab's note
3789 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3791 * image.c: Improve checking for integer overflow.
3792 (check_image_size): Assume that f is nonnull, since
3793 it is always nonnull in practice. This is one less thing to
3794 worry about when checking for integer overflow later.
3795 (x_check_image_size): New function, which checks for integer
3796 overflow issues inside X.
3797 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3798 This removes the need for a memory_full check.
3799 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3800 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3801 (xbm_read_bitmap_data): Change locals back to 'int', since
3802 their values must fit in 'int'.
3803 (xpm_load_image, png_load, tiff_load):
3804 Invoke x_create_x_image_and_pixmap earlier,
3805 to avoid much needless work if the image is too large.
3806 (tiff_load): Treat overly large images as if
3807 x_create_x_image_and_pixmap failed, not as malloc failures.
3808 (gs_load): Use x_check_image_size.
3810 * gtkutil.c: Omit integer casts.
3811 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3812 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3814 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3816 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3817 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3818 would wrongly return t on a 64-bit host.
3820 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3821 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3822 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3823 and therefore cause GCC to emit a bogus diagnostic in some cases.
3825 * image.c: Integer signedness and overflow and related fixes.
3826 This is not an exhaustive set of fixes, but it's time to
3827 record what I've got.
3828 (lookup_pixel_color, check_image_size): Remove redundant decls.
3829 (check_image_size): Don't assume that arbitrary EMACS_INT values
3830 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3831 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3832 (tiff_load, imagemagick_load_image):
3833 Check for overflow in size calculations.
3834 (x_create_x_image_and_pixmap): Remove unnecessary test for
3835 xmalloc returning NULL; that can't happen.
3836 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3837 (xpm_color_bucket): Use better integer hashing function.
3838 (xpm_cache_color): Don't possibly over-allocate memory.
3839 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3840 (gif_memory_source):
3841 Use ptrdiff_t, not int or size_t, to record sizes.
3842 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3843 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3844 either works, as we prefer signed integers.
3845 (tiff_read_from_memory, tiff_write_from_memory):
3846 Return tsize_t, not size_t, since that's what the TIFF API wants.
3847 (tiff_read_from_memory): Don't fail simply because the read would
3848 go past EOF; instead, return a short read.
3849 (tiff_load): Omit no-longer-needed casts.
3850 (Fimagemagick_types): Don't assume size fits into 'int'.
3852 Improve hashing quality when configured --with-wide-int.
3853 * fns.c (hash_string): New function, taken from sxhash_string.
3854 Do not discard information about ASCII character case; this
3855 discarding is no longer needed.
3856 (sxhash-string): Use it. Change sig to match it. Caller changed.
3857 * lisp.h: Declare it.
3858 * lread.c (hash_string): Remove, since we now use fns.c's version.
3859 The fns.c version returns a wider integer if --with-wide-int is
3860 specified, so this should help the quality of the hashing a bit.
3862 * emacs.c: Integer overflow minor fix.
3863 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3864 Define only if GNU_LINUX.
3865 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3867 * dispnew.c: Integer signedness and overflow fixes.
3868 Remove unnecessary forward decls, that were a maintenance hassle.
3869 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3871 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3872 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3873 (prepare_desired_row, line_draw_cost):
3874 Use int, not unsigned, where either works.
3875 (save_current_matrix, restore_current_matrix):
3876 Use ptrdiff_t, not size_t, where either works.
3877 (init_display): Check for overflow more accurately, and without
3878 relying on undefined behavior.
3880 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3881 Remove, replacing with the new symbols in lisp.h. All uses changed.
3882 * fileio.c (make_temp_name):
3883 * filelock.c (lock_file_1, lock_file):
3884 * xdisp.c (message_dolog):
3885 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3886 Use pMd etc. instead.
3887 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3888 replacing the pWIDE etc. symbols removed from editfns.c.
3890 * keyboard.h (num_input_events): Now uintmax_t.
3891 This is (very slightly) less likely to mess up due to wraparound.
3894 * buffer.c: Integer signedness fixes.
3895 (alloc_buffer_text, enlarge_buffer_text):
3896 Use ptrdiff_t rather than size_t when either will do, as we prefer
3899 * alloc.c: Integer signedness and overflow fixes.
3900 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3901 (__malloc_size_t): Default to size_t, not to int.
3902 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3903 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3904 Prefer ptrdiff_t to size_t when either would do, as we prefer
3906 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3907 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3908 Now const. Initialize with values that are in range even if char
3910 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3911 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3912 These functions do the right thing with sizes > 2**32.
3913 (check_depth): Now ptrdiff_t, not int.
3914 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3915 Adjust to new way of storing sizes. Check for size overflow bugs
3917 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3918 slightly wrong anyway, as it missed one instance of
3919 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3920 (refill_memory_reserve): Omit needless cast to size_t.
3921 (mark_object_loop_halt): Mark as externally visible.
3923 * xselect.c: Integer signedness and overflow fixes.
3924 (Fx_register_dnd_atom, x_handle_dnd_message):
3925 Use ptrdiff_t, not size_t, since we prefer signed.
3926 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3927 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3928 x_dnd_atoms_size and x_dnd_atoms_length.
3930 * doprnt.c: Prefer signed to unsigned when either works.
3932 * doprnt.c (doprnt):
3934 * xdisp.c (vmessage):
3935 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3936 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3937 prefer signed arithmetic to avoid comparison confusion.
3938 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3939 but is a bit tricky.
3941 Assume freestanding C89 headers, string.h, stdlib.h.
3942 * data.c, doprnt.c, floatfns.c, print.c:
3943 Include float.h unconditionally.
3944 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3945 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3946 * regex.c: Likewise for stddef.h, string.h.
3947 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3948 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3949 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3950 (STDC_HEADERS): Remove obsolete defines.
3951 * sysdep.c: Include limits.h unconditionally.
3953 Assume support for memcmp, memcpy, memmove, memset.
3954 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3955 * regex.c (memcmp, memcpy):
3956 Remove; we assume C89 now.
3958 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3959 (__malloc_safe_bcopy): Remove; no longer needed.
3961 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3962 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3963 well either way, and we prefer signed to unsigned.
3965 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3967 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3968 closes the connection while we're reading (bug#9182).
3970 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3972 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3973 are specified (Bug#9168).
3975 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3977 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3978 Found by GCC static checking and --with-wide-int on a 32-bit host.
3980 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3982 * xdisp.c (compute_display_string_pos): Fix logic of caching
3983 previous display string position. Initialize cached_prev_pos to
3984 -1. Fixes slow-down at the beginning of a buffer.
3986 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3988 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3989 for attrs[LFACE_FONTSET_INDEX].
3991 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3993 * xml.c (parse_region): Remove unused local
3994 that was recently introduced.
3996 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3998 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3999 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4001 * xdisp.c (move_it_in_display_line_to): Record the best matching
4002 position for TO_CHARPOS while scanning the line, and restore it on
4003 exit if none of the characters scanned was an exact match.
4004 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4005 when exact match is impossible due to invisible text, and the
4006 lines are truncated.
4008 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4010 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4013 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4015 Fix a significant slow-down of cursor motion with C-n, C-p,
4016 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4017 auto-repeat under bidi redisplay in fontified buffers.
4018 * xdisp.c (compute_stop_pos_backwards): New function.
4019 (next_element_from_buffer): Call compute_stop_pos_backwards to
4020 find a suitable prev_stop when we find ourselves before
4022 (reseat): Don't look for prev_stop, as that could mean a very long
4024 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4025 <cached_disp_overlay_modiff>: Cache for last found display string
4027 (compute_display_string_pos): Return the cached position if asked
4028 about the same buffer in the same area of character positions, and
4029 the buffer wasn't changed since the time the display string
4030 position was cached.
4032 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4034 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4035 is an integer, which is important for empty lines. (Bug#9149)
4037 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4039 * frame.c (Fmodify_frame_parameters): In tty case, update the
4040 default face if necessary (Bug#4238).
4042 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4044 * editfns.c (Fstring_to_char): No need to explain what a character
4045 is in the docstring (Bug#6576).
4047 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4049 * xml.c (parse_region): Make sure we always return a tree.
4051 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4053 * xml.c (parse_region): If a document contains only comments,
4056 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4058 * xml.c (make_dom): Return comments, too.
4060 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4063 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4064 and the surrounding thread.
4065 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4066 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4067 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4069 * s/openbsd.h (BROKEN_SIGIO): Define.
4070 * unexelf.c (unexec) [__OpenBSD__]:
4071 Don't update the .mdebug section of the Alpha COFF symbol table.
4073 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4075 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4078 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4080 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4081 This fixes some race conditions on the permissions of any newly
4084 * alloc.c (valid_pointer_p): Use pipe, not open.
4085 This fixes some permissions issues when debugging.
4087 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4088 If fchown fails to set both uid and gid, try to set just gid,
4089 as that is sometimes allowed. Adjust the file's mode to eliminate
4090 setuid or setgid bits that are inappropriate if fchown fails.
4092 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4094 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4095 to compare Lisp_Objects.
4096 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4097 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4098 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4100 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4102 * lread.c (read_integer): Unread even EOF character.
4103 (read1): Likewise. Properly record start position of symbol.
4105 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4106 symbol character follows.
4108 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4110 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4111 This works around a problem with the previous change to Fcopy_file.
4112 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4113 and without this change, GCC might complain about discarding
4114 fchown's return value.
4116 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4118 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4120 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4122 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4124 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4126 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4127 it's used from the C level.
4129 * process.c: Use the same condition for POLL_FOR_INPUT in both
4130 keyboard.c and process.c (bug#1858).
4132 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4134 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4135 (Fgnutls_boot): Use it.
4137 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4139 * doc.c (Fsubstitute_command_keys): Revert last change.
4141 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4143 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4144 quotes the next character, and doesn't affect other longer
4145 sequences (bug#8935).
4147 * lread.c (syms_of_lread): Clarify that is isn't only
4148 `eval-buffer' and `eval-defun' that's affected by
4149 `lexical-binding' (bug#8460).
4151 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4153 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4154 bidi redisplay when a line includes both an image and is truncated.
4156 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4158 Fix minor problems found by static checking.
4159 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4160 (elsz): Now a signed constant, not a size_t var. We prefer signed
4161 types to unsigned, to avoid integer comparison confusion. Without
4162 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4163 "cannot optimize loop, the loop counter may overflow", a symptom
4165 * indent.c (Fvertical_motion): Mark locals as initialized.
4166 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4168 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4170 * search.c (Fre_search_backward): Mention `case-fold-search' in
4171 all the re_search_* functions (bug#8138).
4173 * keyboard.c (Fopen_dribble_file): Document when the file is
4176 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4178 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4181 Support bidi reordering of display and overlay strings.
4182 * xdisp.c (compute_display_string_pos)
4183 (compute_display_string_end): Accept additional argument STRING.
4184 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4185 (reseat_to_string): Initialize bidi_it->string.s and
4186 bidi_it->string.schars.
4187 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4188 NULL (avoids a crash in bidi_paragraph_init).
4189 Initialize itb.string.lstring.
4190 (init_iterator): Call bidi_init_it only of a valid
4191 buffer position was specified. Initialize paragraph_embedding to
4193 (reseat_to_string): Initialize the bidi iterator.
4194 (display_string): If we need to ignore text properties of
4195 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4196 original value of -1 will not work with bidi.)
4197 (compute_display_string_pos): First arg is now struct
4198 `text_pos *'; all callers changed. Support display properties on
4200 (compute_display_string_end): Support display properties on Lisp
4202 (init_iterator, reseat_1, reseat_to_string): Initialize the
4203 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4204 when iterating on a string not from display properties).
4205 (compute_display_string_pos, compute_display_string_end):
4206 Fix calculation of the object to scan. Fixes an error when using
4208 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4209 base_level_stop; instead, set base_level_stop to BEGV.
4210 Fixes crashes in vertical-motion.
4211 (next_element_from_buffer): Improve commentary for when
4212 the iterator is before prev_stop.
4213 (init_iterator): Initialize bidi_p from the default value of
4214 bidi-display-reordering, not from buffer-local value. Use the
4215 buffer-local value only if initializing for buffer iteration.
4216 (handle_invisible_prop): Support invisible properties on strings
4217 that are being bidi-reordered.
4218 (set_iterator_to_next): Support bidi reordering of C strings and
4220 (next_element_from_string): Support bidi reordering of Lisp
4222 (handle_stop_backwards): Support Lisp strings as well.
4223 (display_string): Support display of R2L glyph rows.
4224 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4225 (init_iterator): Don't initialize it->bidi_p for strings
4227 (reseat_to_string): Initialize it->bidi_p for strings here.
4228 (next_element_from_string, next_element_from_c_string)
4229 (next_element_from_buffer): Add xassert's for correspondence
4230 between IT's object being iterated and it->bidi_it.string
4232 (face_before_or_after_it_pos): Support bidi iteration.
4233 (next_element_from_c_string): Handle the case of the first string
4234 character that is not the first one in the visual order.
4235 (get_visually_first_element): New function, refactored from common
4236 parts of next_element_from_buffer, next_element_from_string, and
4237 next_element_from_c_string.
4238 (tool_bar_lines_needed, redisplay_tool_bar)
4239 (display_menu_bar): Force left-to-right direction. Add a FIXME
4240 comment for making that be controlled by a user option.
4241 (push_it, pop_it): Save and restore the state of the
4242 bidi iterator. Save and restore the bidi_p flag.
4243 (pop_it): Iterate out of display property for string iteration as
4245 (iterate_out_of_display_property): Support iteration over strings.
4246 (handle_single_display_spec): Set up it->bidi_it for iteration
4247 over a display string, and call bidi_init_it.
4248 (handle_single_display_spec, next_overlay_string)
4249 (get_overlay_strings_1, push_display_prop): Set up the bidi
4250 iterator for displaying display or overlay strings.
4251 (forward_to_next_line_start): Don't use the shortcut if
4253 (back_to_previous_visible_line_start): If handle_display_prop
4254 pushed the iterator stack, restore the internal state of the bidi
4255 iterator by calling bidi_pop_it same number of times.
4256 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4257 and we are bidi-iterating, don't decrement the iterator position;
4258 instead, set the first_elt flag in the bidi iterator, to produce
4260 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4261 (push_display_prop): xassert that we are iterating a buffer.
4262 (push_it, pop_it): Save and restore paragraph_embedding member.
4263 (handle_single_display_spec, next_overlay_string)
4264 (get_overlay_strings_1, reseat_1, reseat_to_string)
4265 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4266 correctly. Don't assume unibyte strings are not bidi-reordered.
4267 (compute_display_string_pos)
4268 (compute_display_string_end): Fix handling the case of C string.
4269 (push_it, pop_it): Save and restore from_disp_prop_p.
4270 (handle_single_display_spec, push_display_prop): Set the
4271 from_disp_prop_p flag.
4272 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4273 (pop_it): Call iterate_out_of_display_property only if we are
4274 popping after iteration over a string that came from a display
4275 property. Fix a typo in popping stretch info. Add an assertion
4276 for verifying that the iterator position is in sync with the bidi
4278 (handle_single_display_spec, get_overlay_strings_1)
4279 (push_display_prop): Fix initialization of paragraph direction for
4280 string when that of the parent object is not yet determined.
4281 (reseat_1): Call bidi_init_it to resync the bidi
4282 iterator with IT's position. (Bug#7616)
4283 (find_row_edges): If ROW->start.pos gives position
4284 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4285 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4286 Reset the from_disp_prop_p flag.
4287 (SAVE_IT, RESTORE_IT): New macros.
4288 (pos_visible_p, face_before_or_after_it_pos)
4289 (back_to_previous_visible_line_start)
4290 (move_it_in_display_line_to, move_it_in_display_line)
4291 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4292 (try_scrolling, redisplay_window, display_line): Use them when
4293 saving a temporary copy of the iterator and restoring it back.
4294 (back_to_previous_visible_line_start, reseat_1)
4295 (init_iterator): Empty the bidi cache "stack".
4296 (move_it_in_display_line_to): If iterator ended up at
4297 EOL, but we never saw any buffer positions smaller than
4298 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4299 motion in bidi-reordered lines.
4300 (move_it_in_display_line_to): Record prev_method and prev_pos
4301 immediately before the call to set_iterator_to_next. Fixes cursor
4302 motion in bidi-reordered lines with stretch glyphs and strings
4303 displayed in margins. (Bug#8133) (Bug#8867)
4304 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4306 (pos_visible_p): Support positions in bidi-reordered lines.
4307 Save and restore bidi cache.
4309 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4310 (bidi_paragraph_info): Delete unused struct.
4311 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4312 (bidi_cache_start): New variable.
4313 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4315 (bidi_cache_fetch_state, bidi_cache_search)
4316 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4317 (bidi_cache_find, bidi_peek_at_next_level)
4318 (bidi_level_of_next_char, bidi_find_other_level_edge)
4319 (bidi_move_to_visually_next): Compare cache index with
4320 bidi_cache_start rather than with zero.
4321 (bidi_fetch_char): Accept new argument STRING; all callers
4322 changed. Support iteration over a string. Support strings with
4323 display properties. Support unibyte strings. Fix the type of
4324 `len' according to what STRING_CHAR_AND_LENGTH expects.
4325 (bidi_paragraph_init, bidi_resolve_explicit_1)
4326 (bidi_resolve_explicit, bidi_resolve_weak)
4327 (bidi_level_of_next_char, bidi_move_to_visually_next):
4328 Support iteration over a string.
4329 (bidi_set_sor_type, bidi_resolve_explicit_1)
4330 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4331 can now be zero (for strings); special values 0 and -1 were
4332 changed to -1 and -2, respectively.
4333 (bidi_char_at_pos): New function.
4334 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4335 Call it instead of FETCH_MULTIBYTE_CHAR.
4336 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4337 initialized to valid values.
4338 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4340 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4341 the test for valid cached positions. Fix the logic for looking up
4342 the sentinel state in the cache. GCPRO the Lisp string we are
4344 (bidi_push_it, bidi_pop_it): New functions.
4345 (bidi_initialize): Initialize the bidi cache start stack pointer.
4346 (bidi_cache_ensure_space): New function, refactored from part of
4347 bidi_cache_iterator_state. Don't assume the required size is just
4348 one BIDI_CACHE_CHUNK away.
4349 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4350 (bidi_count_bytes, bidi_char_at_pos): New functions.
4351 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4352 always valid if bidi_cache_idx is valid.
4353 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4354 is valid if it's going to be used.
4355 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4356 (bidi_cache_fetch_state, bidi_cache_search)
4357 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4358 (bidi_cache_iterator_state, bidi_cache_find)
4359 (bidi_find_other_level_edge, bidi_cache_start_stack):
4360 All variables related to cache indices are now EMACS_INT.
4362 * dispextern.h (struct bidi_string_data): New structure.
4363 (struct bidi_it): New member `string'. Make flag members be 1-bit
4364 fields, and put them last in the struct.
4365 (compute_display_string_pos, compute_display_string_end):
4367 (bidi_push_it, bidi_pop_it): Add prototypes.
4368 (struct iterator_stack_entry): New members bidi_p,
4369 paragraph_embedding, and from_disp_prop_p.
4370 (struct it): Member bidi_p is now a bit field 1 bit wide.
4371 (bidi_shelve_cache, bidi_unshelve_cache):
4374 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4375 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4376 and vector-like objects.
4378 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4379 cache around display iteration.
4381 * window.c (Fwindow_end, window_scroll_pixel_based)
4382 (displayed_window_lines, Frecenter): Save and restore the bidi
4383 cache around display iteration.
4385 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4387 * editfns.c (Fdelete_region): Clarify the use of the named
4388 parameters (bug#6788).
4390 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4392 * indent.c (Fvertical_motion): Set and restore w->pointm when
4393 saving and restoring the window's buffer (Bug#9006).
4395 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4397 * editfns.c (Fstring_to_char): Clarify just what is returned
4398 (bug#6576). Text by Eli Zaretskii.
4400 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4402 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4404 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4406 * buffer.c (mmap_find): Fix a typo.
4408 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4410 Fix execution of x selection hooks.
4411 * xselect.c (Qx_lost_selection_functions)
4412 (Qx_sent_selection_functions): New vars.
4413 (syms_of_xselect): DEFSYM them.
4414 (x_handle_selection_request): Pass Qx_sent_selection_functions
4415 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4416 (x_handle_selection_clear,x_clear_frame_selections):
4417 Pass Qx_lost_selection_functions rather than
4418 Vx_lost_selection_functions to Frun_hook_with_args.
4420 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4422 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4423 The old code sometimes used this field without initializing it.
4425 * alloc.c (gc_sweep): Don't read past end of array.
4426 In theory, the old code could also have corrupted Emacs internals,
4427 though it'd be very unlikely.
4429 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4431 * character.c (Fcharacterp): Don't advertise optional ignored
4432 argument. (Bug#4026)
4434 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4436 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4439 * window.c (Fset_window_start): Doc fix (bug#4199).
4440 (Fset_window_hscroll): Ditto.
4442 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4444 Fix minor new problems caught by GCC 4.6.1.
4445 * term.c (init_tty): Remove unused local.
4446 * xsettings.c (store_monospaced_changed): Define this function only
4447 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4450 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4452 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4454 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4456 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4457 are the mini-buffer and the echo area (bug#3320).
4459 * term.c (init_tty): Remove support for supdup, c10 and perq
4460 terminals, which are no longer supported (bug#1482).
4462 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4464 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4466 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4468 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4469 for non-popups (Bug#3642).
4471 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4473 * alloc.c (reset_malloc_hooks): Protoize.
4474 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4475 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4476 * cm.c (losecursor): Likewise.
4477 * data.c (fmod): Likewise.
4478 * dispnew.c (swap_glyphs_in_rows): Likewise.
4479 * emacs.c (memory_warning_signal): Likewise.
4480 * floatfns.c (float_error): Likewise.
4481 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4482 (otf_open, font_otf_capability, generate_otf_features)
4483 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4485 * image.c (pbm_read_file): Likewise.
4486 * indent.c (string_display_width): Likewise.
4487 * intervals.c (check_for_interval, search_for_interval)
4488 (inc_interval_count, count_intervals, root_interval)
4489 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4490 * lread.c (defalias): Likewise.
4491 * ralloc.c (r_alloc_check): Likewise.
4492 * regex.c (set_image_of_range_1, set_image_of_range)
4493 (regex_grow_registers): Likewise.
4494 * sysdep.c (strerror): Likewise.
4495 * termcap.c (valid_filename_p, tprint, main): Likewise.
4496 * tparam.c (main): Likewise.
4497 * unexhp9k800.c (run_time_remap, save_data_space)
4498 (update_file_ptrs, read_header, write_header, calculate_checksum)
4499 (copy_file, copy_rest, display_header): Likewise.
4500 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4502 * xdisp.c (check_it): Likewise.
4503 * xfaces.c (register_color, unregister_color, unregister_colors):
4505 * xfns.c (print_fontset_result): Likewise.
4506 * xrdb.c (member, fatal, main): Likewise.
4508 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4510 Fix minor problems found by static checking (Bug#9031).
4511 * chartab.c (char_table_set_range, map_sub_char_table):
4512 Remove unused locals.
4513 (uniprop_table): Now static.
4514 * composite.c (_work_char): Remove unused static var.
4516 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4518 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4520 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4522 * gtkutil.c (qttip_cb): Remove code without function.
4524 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4526 * w32.c (pthread_sigmask): New stub.
4528 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4530 Use pthread_sigmask, not sigprocmask (Bug#9010).
4531 sigprocmask is portable only for single-threaded applications, and
4532 Emacs can be multi-threaded when it uses GTK.
4533 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4535 * callproc.c (Fcall_process):
4536 * process.c (create_process):
4537 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4538 Use pthread_sigmask, not sigprocmask.
4540 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4542 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4543 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4546 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4548 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4549 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4550 (xg_hide_tooltip): Fix comment.
4552 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4553 in registerServicesMenuSendTypes.
4554 (validRequestorForSendType): Don't check ns_return_types.
4556 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4559 2011-07-08 Jason Rumney <jasonr@gnu.org>
4561 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4562 SH_SHOW for hidden windows (Bug#5482).
4564 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4565 frame struct members of non-existent frames (Bug#6284).
4567 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4569 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4570 variable firstTime not needed on OSX >= 10.6.
4571 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4572 >= 10.5. Use setKnobProportion, setDoubleValue.
4574 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4575 (MAC_OS_X_VERSION_10_5): Define if not defined.
4576 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4577 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4578 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4580 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4581 cString and lossyCString on OSX >= 10.4
4583 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4584 sizeToFit on OSX >= 10.2.
4586 * nsimage.m (allocInitFromFile): Don't use deprecated method
4587 bestRepresentationForDevice on OSX >= 10.6.
4589 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4592 * emacs.c: Declare unexec_init_emacs_zone.
4594 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4596 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4598 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4599 on svcsMenu (Bug#8842).
4601 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4603 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4605 * nsterm.m (QUTF8_STRING): Declare.
4606 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4607 (validRequestorForSendType): Return type is (id).
4608 Change indexOfObjectIdenticalTo to indexOfObject.
4609 Check if we have local selection before returning self (Bug#8842).
4610 (writeSelectionToPasteboard): Put local selection into paste board
4611 if we have a local selection (Bug#8842).
4612 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4614 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4615 (ns_get_local_selection): Declare.
4617 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4619 * keymap.c (describe_map_tree): Don't insert a double newline at
4620 the end of the buffer (bug#1169) and return whether we inserted
4623 * callint.c (Fcall_interactively): Change "reading args" to
4624 "providing args" to try to clarify what it does (bug#1010).
4626 2011-07-07 Kenichi Handa <handa@m17n.org>
4628 * composite.c (composition_compute_stop_pos): Ignore a static
4629 composition starting before CHARPOS (Bug#8915).
4631 * xdisp.c (handle_composition_prop): Likewise.
4633 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4635 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4638 2011-07-07 Kenichi Handa <handa@m17n.org>
4640 * character.h (unicode_category_t): New enum type.
4642 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4643 (Qchar_code_property_table): New variable.
4644 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4645 (UNIPROP_COMPRESSED_FORM_P): New macros.
4646 (char_table_ascii): Uncompress the compressed values.
4647 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4648 Uncompress the compressed values.
4649 (sub_char_table_ref_and_range): Likewise.
4650 (char_table_ref_and_range): Uncompress the compressed values.
4651 (sub_char_table_set): New arg is_uniprop. Callers changed.
4652 Uncompress the compressed values.
4653 (sub_char_table_set_range): Args changed. Callers changed.
4654 (char_table_set_range): Adjuted for the above change.
4655 (map_sub_char_table): Delete args default_val and parent. Add arg
4656 top. Give decoded values to a Lisp function.
4657 (map_char_table): Adjust for the above change. Give decoded
4658 values to a Lisp function. Gcpro more variables.
4659 (uniprop_table_uncompress)
4660 (uniprop_decode_value_run_length): New functions.
4661 (uniprop_decoder, uniprop_decoder_count): New variables.
4662 (uniprop_get_decoder, uniprop_encode_value_character)
4663 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4665 (uniprop_encoder, uniprop_encoder_count): New variables.
4666 (uniprop_get_encoder, uniprop_table)
4667 (Funicode_property_table_internal, Fget_unicode_property_internal)
4668 (Fput_unicode_property_internal): New functions.
4669 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4670 Sunicode_property_table_internal, Sget_unicode_property_internal,
4671 and Sput_unicode_property_internal. Defvar_lisp
4672 char-code-property-alist.
4674 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4675 Vunicode_category_table.
4677 * font.c (font_range): Adjust for the change of
4678 Vunicode_category_table.
4680 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4682 * m/iris4d.h: Remove file, move contents ...
4683 * s/irix6-5.h: ... here.
4685 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4687 Remove unportable assumption about struct layout (Bug#8884).
4688 * alloc.c (mark_buffer):
4689 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4690 (clone_per_buffer_values): Don't assume that
4691 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4692 This isn't true in general, and it's particularly not true
4693 if Emacs is configured with --with-wide-int.
4694 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4695 New macros, used in the buffer.c change.
4697 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4699 * xsettings.c: Use both GConf and GSettings if both are available.
4700 (store_config_changed_event): Add comment.
4701 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4702 (store_tool_bar_style_changed): New functions.
4703 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4704 (struct xsettings): Move font inside HAVE_XFT.
4705 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4706 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4707 Move inside HAVE_XFT.
4708 (something_changed_gsettingsCB): Rename from something_changedCB.
4709 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4711 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4712 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4713 (something_changed_gconfCB): Rename from something_changedCB.
4714 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4715 (parse_settings): Move check for font inside HAVE_XFT.
4716 (read_settings, apply_xft_settings): Add comment.
4717 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4718 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4719 call store_font_name_changed.
4720 (xft_settings_event): Add comment.
4721 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4722 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4723 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4724 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4725 (xsettings_initialize): Call init_gsettings last.
4726 (xsettings_get_system_font, xsettings_get_system_normal_font):
4729 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4731 Random fixes. E.g., (random) never returned negative values.
4732 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4733 subseconds part to the entropy, as that's a bit more random.
4734 Prefer signed to unsigned, since the signedness doesn't matter and
4735 in general we prefer signed. When given a limit, use a
4736 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4737 latter isn't right if USE_2_TAGS_FOR_INTS.
4738 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4739 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4741 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4743 * textprop.c (text_property_stickiness):
4744 Obey Vtext_property_default_nonsticky.
4745 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4746 * w32fns.c (syms_of_w32fns):
4747 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4749 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4751 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4752 This is more efficient than Ffile_directory_p and avoids a minor race.
4754 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4756 * buffer.c (Foverlay_put): Say what the return value is
4759 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4760 is a directory before asking whether to use the file name
4762 (barf_or_query_if_file_exists): Make the "File is a directory"
4763 error be more correct.
4765 * fns.c (Frequire): Remove the mention of the .gz files, since
4766 that's installation-specific, but keep the mention of
4767 `get-load-suffixes'.
4769 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4771 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4772 Report string overflow if the output is too long.
4774 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4776 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4777 (syms_of_gnutls): Remove duplicate DEFSYM for
4778 Qgnutls_bootprop_verify_hostname_error, an error for
4779 Qgnutls_bootprop_verify_error (which is no longer used).
4781 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4782 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4783 Also (re)move comments that are misplaced or no longer relevant.
4785 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4787 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4789 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4791 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4792 and background color parameters if they have been changed.
4794 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4796 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4798 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4800 * xsettings.c (SYSTEM_FONT): Define only when used.
4801 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4803 * keymap.c (access_keymap_1): Now static.
4805 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4807 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4808 leave any prefix arg for the up event (Bug#1586).
4810 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4812 * lread.c (syms_of_lread): Mention single symbols defined by
4813 `defvar' or `defconst' (bug#7154).
4815 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4816 (Frequire): Mention get-load-suffixes.
4818 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4820 * window.h (window): Remove clone_number slot.
4821 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4823 (make_parent_window, make_window, saved_window)
4824 (Fset_window_configuration, save_window_save): Don't deal with
4826 * buffer.c (Qclone_number): Remove declaration.
4827 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4829 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4831 Add multiple inheritance to keymaps.
4832 * keymap.c (Fmake_composed_keymap): New function.
4833 (Fset_keymap_parent): Simplify.
4834 (fix_submap_inheritance): Remove.
4835 (access_keymap_1): New function extracted from access_keymap to handle
4836 embedded parents and handle lists of maps.
4837 (access_keymap): Use it.
4838 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4839 (Fcopy_keymap): Handle embedded parents.
4840 (Fcommand_remapping, define_as_prefix): Simplify.
4841 (Fkey_binding): Simplify.
4842 (syms_of_keymap): Move minibuffer-local-completion-map,
4843 minibuffer-local-filename-completion-map,
4844 minibuffer-local-must-match-map, and
4845 minibuffer-local-filename-must-match-map to Elisp.
4846 (syms_of_keymap): Defsubr make-composed-keymap.
4847 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4848 (parse_menu_item): Trivial simplification.
4850 2011-07-01 Glenn Morris <rgm@gnu.org>
4852 * Makefile.in (SETTINGS_LIBS): Fix typo.
4854 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4856 * coding.c (Fencode_coding_string): Record the last coding system
4857 used, as the function doc string says (bug#8738).
4859 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4861 * xsettings.c (store_monospaced_changed): Take new font as arg and
4862 check for change against current_mono_font.
4863 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4864 (emacs_settings_constructor, emacs_settings_get_property)
4865 (emacs_settings_set_property, emacs_settings_class_init)
4866 (emacs_settings_init, gsettings_obj): Remove.
4867 (something_changedCB): New function for HAVE_GSETTINGS.
4868 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4869 with value as argument.
4870 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4871 g_settings_new (Bug#8967). Do not create gsettings_obj.
4872 Remove calls to g_settings_bind. Connect something_changedCB to
4875 * xgselect.c: Add defined (HAVE_GSETTINGS).
4876 (xgselect_initialize): Ditto.
4878 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4879 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4882 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4884 * eval.c (struct backtrace): Simplify and port the data structure.
4885 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4886 signed bit field, as this assumption is not portable and it makes
4887 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4888 "char debug_on_exit : 1" as this is not portable either; instead,
4889 use the portable "unsigned int debug_on_exit : 1". Remove unused
4890 member evalargs. Remove obsolete comments about cc bombing out.
4892 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4894 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4895 Let HAVE_GSETTINGS override HAVE_GCONF.
4896 (store_monospaced_changed): New function.
4897 (EMACS_SETTINGS): A new type derived from GObject to handle
4898 GSettings notifications.
4899 (emacs_settings_constructor, emacs_settings_get_property)
4900 (emacs_settings_set_property, emacs_settings_class_init):
4902 (gsettings_client, gsettings_obj): New variables.
4903 (GSETTINGS_SCHEMA): New define.
4904 (something_changedCB): Call store_monospaced_changed.
4905 (init_gsettings): New function.
4906 (xsettings_initialize): Call init_gsettings.
4907 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4910 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4913 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4915 * window.c (resize_root_window, grow_mini_window)
4916 (shrink_mini_window): Rename Qresize_root_window to
4917 Qwindow_resize_root_window and Qresize_root_window_vertically to
4918 Qwindow_resize_root_window_vertically.
4920 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4922 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4924 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4926 * makefile.w32-in: Redesign dependencies so they reflect more
4927 clearly which files are directly included by each source file,
4928 and not through other includes.
4930 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4932 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4933 (sort_overlays, overlay_strings): When an overlay's clone number
4934 matches the window's clone number process the overlay even if
4935 the overlay's window property doesn't match the current window.
4937 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4938 (Fwindow_hchild): Rename to Fwindow_left_child.
4939 (Fwindow_next): Rename to Fwindow_next_sibling.
4940 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4941 (resize_window_check): Rename to window_resize_check.
4942 (resize_window_apply): Rename to window_resize_apply.
4943 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4944 (Fdelete_other_windows_internal, resize_frame_windows)
4945 (Fsplit_window_internal, Fdelete_window_internal)
4946 (grow_mini_window, shrink_mini_window)
4947 (Fresize_mini_window_internal): Fix callers accordingly.
4949 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4951 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4952 (emacs_fixed_set_min_size): Remove.
4953 (emacs_fixed_new): Take frame as argument.
4955 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4956 (_EmacsFixedPrivate): Remove minwidth/height.
4957 Add struct frame *f.
4958 (emacs_fixed_init): Initialize priv->f.
4959 (get_parent_class, emacs_fixed_set_min_size): Remove.
4960 (emacs_fixed_new): Set priv->f to argument.
4961 (emacs_fixed_get_preferred_width)
4962 (emacs_fixed_get_preferred_height): Use min_width/height from
4963 frames size_hint to set minimum and natural (Bug#8919).
4964 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4965 and use min_width/height from frames size_hint to set
4966 min_width/height (Bug#8919).
4968 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4969 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4972 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4974 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4975 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4978 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4980 * process.c (wait_reading_process_output): Bypass select if
4981 waiting for a cell while ignoring keyboard input, and input is
4982 pending. Suggested by Jan Djärv (Bug#8869).
4984 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4986 Use gnulib's dup2 module instead of rolling our own.
4987 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4989 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4991 * dispnew.c (scrolling_window): Before scrolling, turn off a
4992 mouse-highlight in the window being scrolled.
4994 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4996 Move DEFSYM to lisp.h and use everywhere.
4998 * character.h (DEFSYM): Move declaration...
4999 * lisp.h (DEFSYM): ...here.
5005 * w32select.c: Don't include character.h.
5007 * alloc.c (syms_of_alloc):
5008 * buffer.c (syms_of_buffer):
5009 * bytecode.c (syms_of_bytecode):
5010 * callint.c (syms_of_callint):
5011 * casefiddle.c (syms_of_casefiddle):
5012 * casetab.c (init_casetab_once):
5013 * category.c (init_category_once, syms_of_category):
5014 * ccl.c (syms_of_ccl):
5015 * cmds.c (syms_of_cmds):
5016 * composite.c (syms_of_composite):
5017 * dbusbind.c (syms_of_dbusbind):
5018 * dired.c (syms_of_dired):
5019 * dispnew.c (syms_of_display):
5020 * doc.c (syms_of_doc):
5021 * editfns.c (syms_of_editfns):
5022 * emacs.c (syms_of_emacs):
5023 * eval.c (syms_of_eval):
5024 * fileio.c (syms_of_fileio):
5025 * fns.c (syms_of_fns):
5026 * frame.c (syms_of_frame):
5027 * fringe.c (syms_of_fringe):
5028 * insdel.c (syms_of_insdel):
5029 * keymap.c (syms_of_keymap):
5030 * lread.c (init_obarray, syms_of_lread):
5031 * macros.c (syms_of_macros):
5032 * msdos.c (syms_of_msdos):
5033 * print.c (syms_of_print):
5034 * process.c (syms_of_process):
5035 * search.c (syms_of_search):
5036 * sound.c (syms_of_sound):
5037 * syntax.c (init_syntax_once, syms_of_syntax):
5038 * terminal.c (syms_of_terminal):
5039 * textprop.c (syms_of_textprop):
5040 * undo.c (syms_of_undo):
5041 * w32.c (globals_of_w32):
5042 * window.c (syms_of_window):
5043 * xdisp.c (syms_of_xdisp):
5044 * xfaces.c (syms_of_xfaces):
5045 * xfns.c (syms_of_xfns):
5046 * xmenu.c (syms_of_xmenu):
5047 * xsettings.c (syms_of_xsettings):
5048 * xterm.c (syms_of_xterm): Use DEFSYM.
5050 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5052 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5054 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5056 Integer and buffer overflow fixes (Bug#8873).
5058 * print.c (printchar, strout): Check for string overflow.
5059 (PRINTPREPARE, printchar, strout):
5060 Don't set size unless allocation succeeds.
5062 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5063 for sizes. Check for string overflow more accurately.
5064 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5066 * macros.c: Integer and buffer overflow fixes.
5067 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5068 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5069 Use ptrdiff_t, not int, for sizes.
5070 Don't increment bufsize until after realloc succeeds.
5071 Check for size-calculation overflow.
5072 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5074 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5076 * lread.c: Integer overflow fixes.
5077 (read_integer): Radix is now EMACS_INT, not int,
5078 to improve quality of diagnostics for out-of-range radices.
5079 Calculate buffer size correctly for out-of-range radices.
5080 (read1): Check for integer overflow in radices, and in
5081 read-circle numbers.
5082 (read_escape): Avoid int overflow.
5083 (Fload, openp, read_buffer_size, read1)
5084 (substitute_object_recurse, read_vector, read_list, map_obarray):
5085 Use ptrdiff_t, not int, for sizes.
5086 (read1): Use EMACS_INT, not int, for sizes.
5087 Check for size overflow.
5089 * image.c (cache_image): Check for size arithmetic overflow.
5091 * lread.c: Integer overflow issues.
5092 (saved_doc_string_size, saved_doc_string_length)
5093 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5094 Now ptrdiff_t, not int.
5095 (read1): Don't assume doc string length fits in int. Check for
5096 out-of-range doc string lengths.
5097 (read_list): Don't assume file position fits in int.
5098 (read_escape): Check for hex character overflow.
5100 2011-06-22 Leo Liu <sdl.web@gmail.com>
5102 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5103 Move to minibuffer.el.
5105 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5107 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5108 The following patches are for when GLYPH_DEBUG && !XASSERT.
5109 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5110 * dispnew.c (flush_stdout):
5111 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5112 Mark as externally visible.
5113 * dispnew.c (check_window_matrix_pointers): Now static.
5114 * dispnew.c (window_to_frame_vpos):
5115 * xfns.c (unwind_create_frame):
5116 * xterm.c (x_check_font): Remove unused local.
5117 * scroll.c (CHECK_BOUNDS):
5118 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5119 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5120 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5121 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5122 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5124 (debug_method_add): Use va_list and vsprintf rather than relying
5125 on undefined behavior with wrong number of arguments.
5126 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5127 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5128 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5129 since we're not interested in debugging glyphs with old libraries.
5130 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5131 GCC 4.6.0's static checking.
5133 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5135 Integer overflow and signedness fixes (Bug#8873).
5136 A few related buffer overrun fixes, too.
5138 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5140 * dispextern.h (struct face.stipple):
5141 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5142 (x_bitmap_mask, x_allocate_bitmap_record)
5143 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5144 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5145 (x_create_bitmap_from_xpm_data):
5146 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5147 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5149 * xfaces.c (load_pixmap):
5150 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5151 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5152 (.bitmaps_last, struct x_output.icon_bitmap):
5153 Use ptrdiff_t, not int, for bitmap indexes.
5154 (x_allocate_bitmap_record): Check for size overflow.
5155 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5157 Use ptrdiff_t, not int, for overlay counts.
5158 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5159 * editfns.c (overlays_around, get_pos_property):
5160 * textprop.c (get_char_property_and_overlay):
5161 * xdisp.c (next_overlay_change, note_mouse_highlight):
5162 * xfaces.c (face_at_buffer_position):
5163 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5164 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5165 (Fnext_overlay_change, Fprevious_overlay_change)
5166 (mouse_face_overlay_overlaps, Foverlays_in):
5167 Use ptrdiff_t, not int, for sizes.
5168 (overlays_at, overlays_in): Check for size-calculation overflow.
5170 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5172 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5173 (x_session_initialize): Do not assume string length fits in int.
5175 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5176 This is unlikely, but can occur if DPI is outlandish.
5178 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5179 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5181 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5182 * xrdb.c (magic_file_p, search_magic_path):
5183 Omit last arg SUFFIX; it was always 0. All callers changed.
5184 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5186 * xfont.c (xfont_match): Avoid need for strlen.
5188 * xfns.c: Don't assume strlen fits in int.
5189 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5191 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5192 not unsigned long, as we prefer signed integers. All callers changed.
5193 Detect integer overflow in repeat count.
5194 (message_dolog): Don't assume print length fits in 39 bytes.
5195 (display_mode_element): Don't assume strlen fits in int.
5197 * termcap.c: Don't assume sizes fit in int and never overflow.
5198 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5199 (gobble_line): Check for size-calculation overflow.
5201 * minibuf.c (Fread_buffer):
5202 * lread.c (intern, intern_c_string):
5203 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5204 Don't assume string length fits in int.
5206 * keyboard.c (parse_tool_bar_item):
5207 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5209 * font.c: Don't assume string length fits in int.
5210 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5211 Use ptrdiff_t, not int.
5212 (font_intern_prop): Don't assume string length fits in int.
5213 Don't assume integer property fits in fixnum.
5214 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5216 * filelock.c: Fix some buffer overrun and integer overflow issues.
5217 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5218 Reformulate so as not to need the command string.
5219 Invoke gzip -cd rather than gunzip, as it's more portable.
5220 (lock_info_type, lock_file_1, lock_file):
5221 Don't assume pid_t and time_t fit in unsigned long.
5222 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5223 (current_lock_owner): Prefer signed type for sizes.
5224 Use memcpy, not strncpy, where memcpy is what is really wanted.
5225 Don't assume (via atoi) that time_t and pid_t fit in int.
5226 Check for time_t and/or pid_t out of range, e.g., via a network share.
5227 Don't alloca where an auto var works fine.
5229 * fileio.c: Fix some integer overflow issues.
5230 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5231 Don't assume string length fits in int.
5232 (directory_file_name): Don't assume string length fits in long.
5233 (make_temp_name): Don't assume pid fits in int, or that its print
5234 length is less than 20.
5236 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5238 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5240 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5242 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5243 We prefer signed integers, even for size calculations.
5245 * emacs.c: Don't assume string length fits in 'int'.
5246 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5247 (main): Don't invoke strlen when not needed.
5249 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5250 (XD_DEBUG_MESSAGE): Don't waste a byte.
5252 * callproc.c (getenv_internal_1, getenv_internal)
5254 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5256 * lread.c (invalid_syntax): Omit length argument.
5257 All uses changed. This doesn't fix a bug, but it simplifies the
5258 code away from its former Hollerith-constant appearance, and it's
5259 one less 'int' to worry about when looking at integer-overflow issues.
5260 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5262 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5263 This didn't break anything, but it didn't help either.
5264 It's confusing to put a bogus integer in a place where the actual
5265 value does not matter.
5266 (LIST_END_P): Remove unused macro and its bogus comment.
5267 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5269 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5270 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5272 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5273 We prefer signed types, and the value cannot exceed the EMACS_INT
5274 range anyway (because otherwise the length would not be representable).
5275 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5276 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5277 This avoids a GCC warning when WIDE_EMACS_INT.
5279 * indent.c (sane_tab_width): New function.
5280 (current_column, scan_for_column, Findent_to, position_indentation)
5281 (compute_motion): Use it. This is just for clarity.
5282 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5284 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5286 * lisp.h (lint_assume): New macro.
5287 * composite.c (composition_gstring_put_cache):
5288 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5290 * editfns.c, insdel.c:
5291 Omit unnecessary forward decls, to simplify future changes.
5293 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5295 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5297 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5298 Use much-faster test for byte-length change.
5299 Don't assume string byte-length fits in 'int'.
5300 Check that character arg fits in 'int'.
5301 (mapcar1): Declare byte as byte, for clarity.
5303 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5305 * fns.c (concat): Catch string overflow earlier.
5306 Do not rely on integer wraparound.
5308 * dispextern.h (struct it.overlay_strings_charpos)
5309 (struct it.selective): Now EMACS_INT, not int.
5310 * xdisp.c (forward_to_next_line_start)
5311 (back_to_previous_visible_line_start)
5312 (reseat_at_next_visible_line_start, next_element_from_buffer):
5313 Don't arbitrarily truncate the value of 'selective' to int.
5315 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5317 * composite.c: Don't truncate sizes to 'int'.
5318 (composition_gstring_p, composition_reseat_it)
5319 (composition_adjust_point): Use EMACS_INT, not int.
5320 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5321 not EMACS_UINT, for indexes.
5323 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5325 * buffer.c: Include <verify.h>.
5326 (struct sortvec.priority, struct sortstr.priority):
5327 Now EMACS_INT, not int.
5328 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5329 (struct sortstr.size, record_overlay_string)
5330 (struct sortstrlist.size, struct sortlist.used):
5331 Don't truncate size to int.
5332 (record_overlay_string): Check for size-calculation overflow.
5333 (init_buffer_once): Check at compile-time, not run-time.
5335 2011-06-22 Jim Meyering <meyering@redhat.com>
5337 Don't leak an XBM-image-sized buffer
5338 * image.c (xbm_load): Free the image buffer after using it.
5340 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5343 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5344 that Sun C diagnosed.
5345 * fns.c (secure_hash): Fix pointer signedness issue.
5346 * intervals.c (static_offset_intervals): New function.
5347 (offset_intervals): Use it.
5349 2011-06-21 Leo Liu <sdl.web@gmail.com>
5352 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5355 * fns.c (secure_hash): Rename from crypto_hash_function and change
5356 the first arg to accept symbols.
5357 (Fsecure_hash): New primitive.
5358 (syms_of_fns): New symbols.
5360 2011-06-20 Deniz Dogan <deniz@dogan.se>
5362 * process.c (Fset_process_buffer): Clarify return value in
5365 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5367 * dispnew.c (add_window_display_history): Use BVAR.
5369 * xdisp.c (debug_method_add): Use BVAR.
5370 (check_window_end, dump_glyph_matrix, dump_glyph)
5371 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5373 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5376 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5377 check till after the cache is created in init_frame_faces.
5379 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5381 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5383 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5385 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5386 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5387 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5389 Improve buffer-overflow checking (Bug#8873).
5390 * fileio.c (Finsert_file_contents):
5391 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5392 Remove the old (too-loose) buffer overflow checks.
5393 They weren't needed, since make_gap checks for buffer overflow.
5394 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5395 The old code merely checked for Emacs fixnum overflow, and relied
5396 on undefined (wraparound) behavior. The new code avoids undefined
5397 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5399 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5400 Tune. Don't use wider integers than needed. Don't use alloca.
5401 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5403 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5405 * insdel.c, lisp.h (buffer_overflow): New function.
5406 (insert_from_buffer_1, replace_range, replace_range_2):
5407 * insdel.c (make_gap_larger):
5408 * editfns.c (Finsert_char):
5409 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5411 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5413 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5415 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5417 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5418 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5420 * fileio.c: Don't assume EMACS_INT fits in off_t.
5421 (emacs_lseek): New static function.
5422 (Finsert_file_contents, Fwrite_region): Use it.
5423 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5425 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5427 * fns.c: Don't overflow int when computing a list length.
5428 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5429 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5430 truncation on 64-bit hosts. Check for QUIT every
5431 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5432 faster and is responsive enough.
5433 (Flength): Report an error instead of overflowing an integer.
5434 (Fsafe_length): Return a float if the value is not representable
5435 as a fixnum. This shouldn't happen except in contrived situations.
5436 (Fnthcdr, Fsort): Don't assume list length fits in int.
5437 (Fcopy_sequence): Don't assume vector length fits in int.
5439 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5440 (header_size, word_size): New constants.
5441 (allocate_vectorlike): Don't check size overflow here.
5442 (allocate_vector): Check it here instead, since this is the only
5443 caller of allocate_vectorlike that could cause overflow.
5444 Check that the new vector's length is representable as a fixnum.
5446 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5447 The previous code was bogus. For example, next_almost_prime (32)
5448 returned 39, which is undesirable as it is a multiple of 3; and
5449 next_almost_prime (24) returned 25, which is a multiple of 5 so
5450 why was the code bothering to check for multiples of 7?
5452 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5454 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5456 Variadic C functions now count arguments with ptrdiff_t.
5457 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5458 Back then I didn't know that the Emacs coding style prefers signed int.
5459 Also, in the meantime I found a few more instances where arguments
5460 were being counted with int, which may truncate counts on 64-bit
5461 machines, or EMACS_INT, which may be unnecessarily wide.
5462 * lisp.h (struct Lisp_Subr.function.aMANY)
5463 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5464 Arg counts are now ptrdiff_t, not size_t.
5465 All variadic functions and their callers changed accordingly.
5466 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5467 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5468 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5469 * callint.c (Fcall_interactively): Check arg count for overflow,
5470 to avoid potential buffer overrun. Use signed char, not 'int',
5471 for 'varies' array, so that we needn't bother to check its size
5472 calculation for overflow.
5473 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5474 * eval.c (apply_lambda):
5475 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5476 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5477 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5479 * callint.c (Fcall_interactively): Don't use index var as event count.
5481 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5482 * mem-limits.h (SIZE): Remove; no longer used.
5484 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5486 Remove unnecessary casts.
5487 * xterm.c (x_term_init):
5488 * xfns.c (x_set_border_pixel):
5489 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5490 These aren't needed now that we assume ANSI C.
5492 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5493 It's more likely to cause problems (due to unsigned overflow)
5496 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5498 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5500 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5502 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5504 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5506 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5508 GLYPH_CODE_FACE returns EMACS_INT, not int.
5509 * dispextern.h (merge_faces):
5510 * xfaces.c (merge_faces):
5511 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5512 Don't assume EMACS_INT fits in int.
5514 * character.h (CHAR_VALID_P): Remove unused parameter.
5515 * fontset.c, lisp.h, xdisp.c: All uses changed.
5517 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5519 * fns.c (concat): Minor tuning based on overflow analysis.
5520 This doesn't fix any bugs. Use int to hold character, instead
5521 of constantly refetching from Emacs object. Use XFASTINT, not
5522 XINT, for value known to be a character. Don't bother comparing
5523 a single byte to 0400, as it's always less.
5525 * floatfns.c (Fexpt):
5526 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5528 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5531 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5533 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5534 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5535 incorrectly succeed when S was a string, because 4294967386 was
5536 truncated before it was used.
5538 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5539 Otherwise, an out-of-range integer could cause undefined behavior
5542 * composite.c: Use int, not EMACS_INT, for characters.
5543 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5544 EMACS_INT, for values that are known to be in character range.
5545 This doesn't fix any bugs but is the usual style inside Emacs and
5546 may generate better code on 32-bit machines.
5548 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5549 This is for reasons similar to the recent CHAR_STRING fix.
5550 * charset.c (Fencode_char): Check that character arg is actually
5551 a character. Pass an int to ENCODE_CHAR.
5552 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5553 wider than 'int', as a compile-time check to prevent future regressions
5556 * character.c (char_string): Remove unnecessary casts.
5558 Make sure a 64-bit char is never passed to CHAR_STRING.
5559 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5560 by silently ignoring the top 32 bits, allowing some values
5561 that were far too large to be valid characters.
5562 * character.h: Include <verify.h>.
5563 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5564 arguments are no wider than unsigned, as a compile-time check
5565 to prevent future regressions in this area.
5567 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5568 (Fsubst_char_in_region):
5570 * xdisp.c (decode_mode_spec_coding):
5571 Adjust to CHAR_STRING's new requirement.
5572 * editfns.c (Finsert_char, Fsubst_char_in_region):
5573 * fns.c (concat): Check that character args are actually
5574 characters. Without this test, these functions did the wrong
5575 thing with wildly out-of-range values on 64-bit hosts.
5577 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5578 These casts should not be needed on 32-bit hosts, either.
5579 * keyboard.c (read_char):
5580 * lread.c (Fload): Remove casts to unsigned.
5582 * lisp.h (UNSIGNED_CMP): New macro.
5583 This fixes comparison bugs on 64-bit hosts.
5584 (ASCII_CHAR_P): Use it.
5585 * casefiddle.c (casify_object):
5586 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5587 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5588 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5589 * dispextern.h (FACE_FROM_ID):
5590 * keyboard.c (read_char): Use UNSIGNED_CMP.
5592 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5593 not to EMACS_INT, to avoid GCC warning.
5595 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5597 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5598 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5599 isn't needed on 32-bit machines.
5601 * buffer.c (Fgenerate_new_buffer_name):
5602 Use EMACS_INT for count, not int.
5603 (advance_to_char_boundary): Return EMACS_INT, not int.
5605 * data.c (Qcompiled_function): Now static.
5607 * window.c (window_body_lines): Now static.
5609 * image.c (gif_load): Rename local to avoid shadowing.
5611 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5612 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5613 * alloc.c (make_save_value): Integer argument is now of type
5615 (mark_object): Use ptrdiff_t, not int.
5616 * lisp.h (pD): New macro.
5617 * print.c (print_object): Use it.
5619 * alloc.c: Use EMACS_INT, not int, to count objects.
5620 (total_conses, total_markers, total_symbols, total_vector_size)
5621 (total_free_conses, total_free_markers, total_free_symbols)
5622 (total_free_floats, total_floats, total_free_intervals)
5623 (total_intervals, total_strings, total_free_strings):
5624 Now EMACS_INT, not int. All uses changed.
5625 (Fgarbage_collect): Compute overall total using a double, so that
5626 integer overflow is less likely to be a problem. Check for overflow
5627 when converting back to an integer.
5628 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5629 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5630 These were 'int' variables that could overflow on 64-bit hosts;
5631 they were never used, so remove them instead of repairing them.
5632 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5633 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5634 Previously, this ceilinged at INT_MAX, but that doesn't work on
5636 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5638 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5639 (allocate_vectorlike): Check for ptrdiff_t overflow.
5640 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5641 when a (possibly-narrower) signed value would do just as well.
5642 We prefer using signed arithmetic, to avoid comparison confusion.
5644 * alloc.c: Catch some string size overflows that we were missing.
5645 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5646 for convenience in STRING_BYTES_MAX.
5647 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5648 The definition here is exact; the one in lisp.h was approximate.
5649 (allocate_string_data): Check for string overflow. This catches
5650 some instances we weren't catching before. Also, it catches
5651 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5652 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5653 and ptrdiff_t and EMACS_INT are both 64 bits.
5655 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5656 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5657 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5659 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5661 * alloc.c (Fmake_string): Check for out-of-range init.
5663 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5665 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5667 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5669 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5670 xg_get_default_scrollbar_width.
5672 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5673 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5674 (style_changed_cb): Call update_theme_scrollbar_width and call
5675 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5676 all frames (Bug#8505).
5677 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5678 Call gtk_window_set_resizable if HAVE_GTK3.
5679 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5680 and height if HAVE_GTK3 (Bug#8505).
5681 (scroll_bar_width_for_theme): New variable.
5682 (update_theme_scrollbar_width): New function.
5683 (xg_get_default_scrollbar_width): Move code to
5684 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5685 (xg_initialize): Call update_theme_scrollbar_width.
5687 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5689 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5691 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5693 * frame.c (make_frame): Call other_buffer_safely instead of
5696 * window.c (temp_output_buffer_show): Call display_buffer with
5697 second argument Vtemp_buffer_show_specifiers and reset latter
5698 immediately after the call.
5699 (Vtemp_buffer_show_specifiers): New variable.
5700 (auto_window_vscroll_p, next_screen_context_lines)
5701 (Vscroll_preserve_screen_position): Remove leading asterisks from
5704 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5706 Fix minor problems found by GCC 4.6.0 static checking.
5707 * buffer.c (Qclone_number): Remove for now, as it's unused.
5708 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5709 (record_buffer): Remove unused local.
5710 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5711 (set_frame_buffer_list): Remove; unused.
5712 * frame.h (other_visible_frames): Remove decl.
5713 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5714 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5715 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5717 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5718 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5719 Define only if HAVE_GPM.
5720 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5721 (update_hints_inhibit): Remove; never set. All uses removed.
5722 * widgetprv.h (emacsFrameClassRec): Remove decl.
5723 * window.c (delete_deletable_window): Now returns void, since it
5724 wasn't returning anything.
5725 (compare_window_configurations): Remove unused locals.
5726 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5727 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5728 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5729 the same widths as pointers. This follows up on the 2011-05-06 patch.
5730 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5731 * xterm.h: Likewise.
5732 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5734 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5736 * makefile.w32-in: Update dependencies.
5737 (LISP_H): Add lib/intprops.h.
5739 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5741 * image.c (gif_load): Add animation frame delay to the metadata.
5742 (syms_of_image): Use DEFSYM. New symbol `delay'.
5744 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5746 * window.c (delete_deletable_window): Re-add.
5747 (Fset_window_configuration): Rewrite to handle dead buffers and
5748 consequently deletable windows.
5749 (window_tree, Fwindow_tree): Remove. Supply functionality in
5751 (compare_window_configurations): Simplify code.
5753 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5755 * image.c (imagemagick_load_image): Fix type mismatch.
5756 (Fimagemagick_types): Likewise.
5758 * window.h (replace_buffer_in_windows): Declare.
5760 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5762 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5763 Qclone_number. Remove external declaration of Qdelete_window.
5764 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5766 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5767 Run Qbuffer_list_update_hook if allowed.
5768 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5769 buffer list implementation.
5770 (other_buffer_safely): New function.
5771 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5772 calls to replace_buffer_in_windows and
5773 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5775 (record_buffer): Inhibit quitting and rewrite using quittable
5776 functions. Run Qbuffer_list_update_hook if allowed.
5777 (Frecord_buffer, Funrecord_buffer): New functions.
5778 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5779 Move switch-to-buffer to window.el.
5780 (bury-buffer): Move to window.el.
5781 (Vbuffer_list_update_hook): New variable.
5783 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5786 * window.h (resize_frame_windows): Move up in code.
5787 (Fwindow_frame): Remove EXFUN.
5788 (replace_buffer_in_all_windows): Remove prototype.
5789 (replace_buffer_in_windows_safely): Add prototype.
5791 * window.c: Declare Qdelete_window static again. Move down
5792 declaration of select_count.
5793 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5794 (Fother_window): Move to window.el.
5795 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5796 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5797 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5799 (replace_buffer_in_windows): Implement by calling
5800 Qreplace_buffer_in_windows.
5801 (replace_buffer_in_all_windows): Remove with some functionality
5802 moved into replace_buffer_in_windows_safely.
5803 (replace_buffer_in_windows_safely): New function.
5804 (select_window_norecord, select_frame_norecord): Move in front
5805 of run_window_configuration_change_hook. Remove now obsolete
5807 (Fset_window_buffer): Rewrite doc-string.
5808 Call Qrecord_window_buffer.
5809 (keys_of_window): Move binding for other-window to window.el.
5811 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5813 * dispextern.h (struct image): Replace data member, whose int_val
5814 and ptr_val fields were not used by anything, with a single
5817 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5818 (gif_clear_image, gif_load, imagemagick_load_image)
5819 (gs_clear_image, gs_load): Callers changed.
5821 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5823 * buffer.h: Include <time.h>, for time_t.
5824 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5826 Fix minor problems found by static checking.
5828 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5830 Make identifiers static if they are not used in other modules.
5831 * data.c (Qcompiled_function, Qframe, Qvector):
5832 * image.c (QimageMagick, Qsvg):
5833 * minibuf.c (Qmetadata):
5834 * window.c (resize_window_check, resize_root_window): Now static.
5835 * window.h (resize_window_check, resize_root_window): Remove decls.
5837 * window.c (window_deletion_count, delete_deletable_window):
5839 (window_body_lines): Now static.
5840 (Fdelete_other_windows_internal): Mark vars as initialized.
5841 Make sure 'resize_failed' is initialized.
5842 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5843 (resize_window_apply): Remove unused local.
5844 * window.h (delete_deletable_window): Remove decl.
5846 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5847 (imagemagick_load_image): Fix pointer signedness problem by changing
5848 last arg from unsigned char * to char *. All uses changed.
5849 Also, fix a local for similar reasons.
5850 Remove unused locals. Remove locals to avoid shadowing.
5851 (fn_rsvg_handle_free): Remove; unused.
5852 (svg_load, svg_load_image): Fix pointer signedness problem.
5853 (imagemagick_load_image): Don't use garbage pointer image_wand.
5855 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5857 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5859 * image.c (gif_load): Fix omitted cast error introduced by
5862 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5864 * window.h (resize_proportionally, orig_total_lines)
5865 (orig_top_line): Remove from window structure.
5866 (set_window_height, set_window_width, change_window_heights)
5867 (Fdelete_window): Remove prototypes.
5868 (resize_frame_windows): Remove duplicate declaration.
5870 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5872 * window.h (resize_frame_windows, resize_window_check)
5873 (delete_deletable_window, resize_root_window)
5874 (resize_frame_windows): Declare prototypes.
5876 * window.c (resize_window_apply): Make definition be "static" to
5877 match the prototype.
5879 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5881 * window.c: Remove declarations of Qwindow_size_fixed,
5882 window_min_size_1, window_min_size_2, window_min_size,
5883 size_window, window_fixed_size_p, enlarge_window, delete_window.
5884 Remove static from declaration of Qdelete_window, it's
5885 temporarily needed by Fbury_buffer.
5886 (replace_window): Don't assign orig_top_line and
5888 (Fdelete_window, delete_window): Remove. Window deletion is
5889 handled by window.el.
5890 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5891 Replace Fdelete_window calls with calls to Qdelete_window.
5892 (Fdelete_other_windows): Remove. Deleting other windows is
5893 handled by window.el.
5894 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5895 handled in window.el.
5896 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5897 Window minimum sizes are handled in window.el.
5898 (shrink_windows, size_window, set_window_height)
5899 (set_window_width, change_window_heights, window_height)
5900 (window_width, CURBEG, CURSIZE, enlarge_window)
5901 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5902 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5903 handled in window.el.
5904 (make_dummy_parent): Rename to make_parent_window and give it a
5905 second argument horflag.
5906 (make_window): Don't set resize_proportionally any more.
5907 (Fsplit_window): Remove. Windows are split in window.el.
5908 (save_restore_action, save_restore_orig_size)
5909 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5910 Resize mini windows in window.el.
5911 (grow_mini_window, shrink_mini_window): Implement by calling
5912 Qresize_root_window_vertically, resize_window_check and
5913 resize_window_apply.
5914 (saved_window, Fset_window_configuration, save_window_save):
5915 Do not handle orig_top_line, orig_total_lines, and
5916 resize_proportionally.
5917 (window_min_height, window_min_width): Move to window.el.
5918 (keys_of_window): Move bindings for delete-other-windows,
5919 split-window, delete-window and enlarge-window to window.el.
5921 * buffer.c: Temporarily extern Qdelete_window.
5922 (Fbury_buffer): Temporarily call Qdelete_window instead of
5923 Fdelete_window (Fbury_buffer will move to window.el soon).
5925 * frame.c (set_menu_bar_lines_1): Remove code handling
5926 orig_top_line and orig_total_lines.
5928 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5929 set_window_height but set heights directly.
5930 (change_frame_size_1): Use resize_frame_windows.
5932 * xdisp.c (init_xdisp): Don't use set_window_height but set
5935 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5936 Use resize_frame_windows instead of change_window_heights and run
5937 run_window_configuration_change_hook.
5939 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5940 instead of change_window_heights and run
5941 run_window_configuration_change_hook.
5943 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5945 * window.c (replace_window): Rename second argument REPLACEMENT to
5946 NEW. New third argument SETFLAG. Rewrite.
5947 (delete_window, make_dummy_parent): Call replace_window with
5949 (window_list_1): Move down in code.
5950 (run_window_configuration_change_hook): Move set_buffer part
5951 before select_frame_norecord part in order to unwind correctly.
5952 Rename count1 to count.
5953 (recombine_windows, delete_deletable_window, resize_root_window)
5954 (Fdelete_other_windows_internal)
5955 (Frun_window_configuration_change_hook, make_parent_window)
5956 (resize_window_check, resize_window_apply, Fresize_window_apply)
5957 (resize_frame_windows, Fsplit_window_internal)
5958 (Fdelete_window_internal, Fresize_mini_window_internal):
5960 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5962 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5964 * window.h (window): Add some new members to window structure -
5965 normal_lines, normal_cols, new_total, new_normal, clone_number,
5966 splits, nest, prev_buffers, next_buffers.
5967 (WINDOW_TOTAL_SIZE): Move here from window.c.
5968 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5970 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5972 (make_dummy_parent): Set new members of windows structure.
5973 (make_window): Move down in code. Handle new members of window
5975 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5976 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5977 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5978 (Fset_window_prev_buffers, Fwindow_next_buffers)
5979 (Fset_window_next_buffers, Fset_window_clone_number):
5981 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5982 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5984 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5985 Argument WINDOW can be now internal window too.
5986 (Fwindow_use_time): Move up in code.
5987 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5989 (Fset_window_configuration, saved_window)
5990 (Fcurrent_window_configuration, save_window_save): Handle new
5991 members of window structure.
5992 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5993 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5994 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5995 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5996 Qget_mru_window, Qresize_root_window,
5997 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5998 Qauto_buffer_name; staticpro them.
6000 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6002 * window.c (Fwindow_total_size, Fwindow_left_column)
6003 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6004 (Fwindow_list_1): New functions.
6005 (window_box_text_cols): Replace with window_body_cols.
6006 (Fwindow_width, Fscroll_left, Fscroll_right):
6007 Use window_body_cols instead of window_box_text_cols.
6008 (delete_window, Fset_window_configuration):
6009 Call delete_all_subwindows with window as argument.
6010 (delete_all_subwindows): Take a window as argument and not a
6012 (window_loop): Remove handling of GET_LRU_WINDOW and
6014 (Fget_lru_window, Fget_largest_window): Move to window.el.
6016 * window.h: Extern window_body_cols instead of
6017 window_box_text_cols. delete_all_subwindows now takes a
6018 Lisp_Object as argument.
6020 * indent.c (compute_motion, Fcompute_motion):
6021 Use window_body_cols instead of window_box_text_cols.
6023 * frame.c (delete_frame): Call delete_all_subwindows with root
6026 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6028 * fns.c (Fputhash): Document return value.
6030 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6032 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6034 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6036 Cons<->int and similar integer overflow fixes (Bug#8794).
6038 Check for overflow when converting integer to cons and back.
6039 * charset.c (Fdefine_charset_internal, Fdecode_char):
6040 Use cons_to_unsigned to catch overflow.
6041 (Fencode_char): Use INTEGER_TO_CONS.
6042 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6043 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6044 * data.c (long_to_cons, cons_to_long): Remove.
6045 (cons_to_unsigned, cons_to_signed): New functions.
6046 These signal an error for invalid or out-of-range values.
6047 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6048 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6049 * font.c (Ffont_variation_glyphs):
6050 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6051 * lisp.h: Include <intprops.h>.
6052 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6053 (cons_to_signed, cons_to_unsigned): New decls.
6054 (long_to_cons, cons_to_long): Remove decls.
6055 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6056 (Fprimitive_undo): Use CONS_TO_INTEGER.
6057 * xfns.c (Fx_window_property): Likewise.
6058 * xselect.c: Include <limits.h>.
6059 (x_own_selection, selection_data_to_lisp_data):
6060 Use INTEGER_TO_CONS.
6061 (x_handle_selection_request, x_handle_selection_clear)
6062 (x_get_foreign_selection, Fx_disown_selection_internal)
6063 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6064 (lisp_data_to_selection_data): Use cons_to_unsigned.
6065 (x_fill_property_data): Use cons_to_signed.
6066 Report values out of range.
6068 Check for buffer and string overflow more precisely.
6069 * buffer.h (BUF_BYTES_MAX): New macro.
6070 * lisp.h (STRING_BYTES_MAX): New macro.
6071 * alloc.c (Fmake_string):
6072 * character.c (string_escape_byte8):
6073 * coding.c (coding_alloc_by_realloc):
6074 * doprnt.c (doprnt):
6075 * editfns.c (Fformat):
6077 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6078 since they may not be the same number.
6079 * editfns.c (Finsert_char):
6080 * fileio.c (Finsert_file_contents):
6081 Likewise for BUF_BYTES_MAX.
6083 * image.c: Use ptrdiff_t, not int, for sizes.
6084 (slurp_file): Switch from int to ptrdiff_t.
6086 (slurp_file): Check that file size fits in both size_t (for
6087 malloc) and ptrdiff_t (for sanity and safety).
6089 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6090 if b->modtime has its maximal value.
6092 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6094 Don't assume time_t can fit into int.
6095 * buffer.h (struct buffer.modtime): Now time_t, not int.
6096 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6097 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6099 Minor fixes for signed vs unsigned integers.
6100 * character.h (MAYBE_UNIFY_CHAR):
6101 * charset.c (maybe_unify_char):
6102 * keyboard.c (read_char, reorder_modifiers):
6103 XINT -> XFASTINT, since the integer must be nonnegative.
6104 * ftfont.c (ftfont_spec_pattern):
6105 * keymap.c (access_keymap, silly_event_symbol_error):
6106 XUINT -> XFASTINT, since the integer must be nonnegative.
6107 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6108 since it makes no difference and we prefer signed.
6109 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6110 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6113 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6115 * window.h (Fwindow_frame): Declare.
6117 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6119 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6120 (SPARE_MEMORY): Always define.
6121 (LARGE_REQUEST): Remove.
6122 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6124 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6126 * lisp.h: Move EXFUNS for Fframe_root_window,
6127 Fframe_first_window and Fset_frame_selected_window to window.h.
6129 * window.h: Move EXFUNS for Fframe_root_window,
6130 Fframe_first_window and Fset_frame_selected_window here from
6133 * frame.c (Fwindow_frame, Fframe_first_window)
6134 (Fframe_root_window, Fframe_selected_window)
6135 (Fset_frame_selected_window): Move to window.c.
6136 (Factive_minibuffer_window): Move to minibuf.c.
6137 (Fother_visible_frames_p): New function.
6139 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6141 * window.c (decode_window, decode_any_window): Move up in code.
6142 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6143 (inhibit_frame_unsplittable): Remove unused variable.
6144 (Fwindow_buffer): Move up and rewrite doc-string.
6145 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6146 (Fwindow_prev): New functions.
6147 (Fwindow_frame): Move here from frame.c. Accept any window as
6149 (Fframe_root_window, Fframe_first_window)
6150 (Fframe_selected_window): Move here from frame.c. Accept frame
6151 or arbitrary window as argument. Update doc-strings.
6152 (Fminibuffer_window): Move up in code.
6153 (Fwindow_minibuffer_p): Move up in code and simplify.
6154 (Fset_frame_selected_window): Move here from frame.c.
6156 (Fselected_window, select_window, Fselect_window): Move up in
6157 code. Minor doc-string fixes.
6159 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6161 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6162 Do not assume that spare memory exists; that assumption is valid
6163 only if SYSTEM_MALLOC.
6164 (LARGE_REQUEST): New macro, so that the issue of large requests
6165 is separated from the issue of spare memory.
6167 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6169 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6172 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6174 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6177 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6179 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6181 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6183 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6184 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6186 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6188 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6190 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6192 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6193 (x_clipboard_manager_save): Add return value.
6194 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6196 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6197 Obey Vx_select_enable_clipboard_manager. Catch errors in
6198 x_clipboard_manager_save (Bug#8779).
6199 (Vx_select_enable_clipboard_manager): New variable.
6200 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6202 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6204 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6206 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6208 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6209 in the current matrix if keep_current_p is non-zero.
6211 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6213 * bidi.c (bidi_level_of_next_char): Fix last change.
6215 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6217 Support bidi reordering of text covered by display properties.
6219 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6220 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6221 (bidi_cache_search, bidi_cache_iterator_state)
6222 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6223 (bidi_level_of_next_char, bidi_move_to_visually_next):
6224 Support character positions inside a run of characters covered by a
6226 (bidi_paragraph_init, bidi_resolve_explicit_1)
6227 (bidi_level_of_next_char): Call bidi_fetch_char and
6228 bidi_fetch_char_advance instead of FETCH_CHAR and
6230 (bidi_init_it): Initialize new members.
6231 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6233 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6234 instead of using explicit *_CHAR codes.
6235 (bidi_resolve_explicit, bidi_resolve_weak):
6236 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6237 bidirectional text is supported only in multibyte buffers.
6238 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6239 it to initialize the frame_window_p member of struct bidi_it.
6240 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6241 (bidi_resolve_explicit, bidi_resolve_weak)
6242 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6243 bidi_it->nchars is non-positive.
6244 (bidi_level_of_next_char): Don't try to lookup the cache for the
6245 next/previous character if nothing is cached there yet, or if we
6246 were just reseat()'ed to a new position.
6248 * xdisp.c (set_cursor_from_row): Set start and stop points
6249 according to the row's direction when priming the loop that looks
6250 for the glyph on which to display cursor.
6251 (single_display_spec_intangible_p): Function deleted.
6252 (display_prop_intangible_p): Reimplement to call
6253 handle_display_spec instead of single_display_spec_intangible_p.
6254 Accept 3 additional arguments needed by handle_display_spec.
6255 This fixes incorrect cursor motion across display property with complex
6256 values: lists, `(when COND...)' forms, etc.
6257 (single_display_spec_string_p): Support property values that are
6258 lists with the argument STRING its top-level element.
6259 (display_prop_string_p): Fix the condition for processing a
6260 property that is a list to be consistent with handle_display_spec.
6261 (handle_display_spec): New function, refactored from the
6262 last portion of handle_display_prop.
6263 (compute_display_string_pos): Accept additional argument
6264 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6265 value of a `display' property is a "replacing spec".
6266 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6267 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6268 the display property, but just return a value indicating whether
6269 the display property will replace the characters it covers.
6270 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6271 frame_window_p members of struct bidi_it.
6272 (compute_display_string_pos, compute_display_string_end):
6274 (push_it): Accept second argument POSITION, where pop_it should
6275 jump to continue iteration.
6276 (reseat_1): Initialize bidi_it.disp_pos.
6278 * keyboard.c (adjust_point_for_property): Adjust the call to
6279 display_prop_intangible_p to its new signature.
6281 * dispextern.h (struct bidi_it): New member frame_window_p.
6282 (bidi_init_it): Update prototypes.
6283 (display_prop_intangible_p): Update prototype.
6284 (compute_display_string_pos, compute_display_string_end):
6286 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6289 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6291 Malloc failure behavior now depends on size of allocation.
6292 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6293 * lisp.h: Change signatures accordingly.
6294 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6295 All callers changed. (Bug#8762)
6297 * gnutls.c: Use Emacs's memory allocators.
6298 Without this change, the gnutls library would invoke malloc etc.
6299 directly, which causes problems on non-SYNC_INPUT hosts, and which
6300 runs afoul of improving memory_full behavior. (Bug#8761)
6301 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6302 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6303 xfree instead of the default malloc, realloc, free.
6304 (Fgnutls_boot): No need to check for memory allocation failure,
6305 since xmalloc does that for us.
6307 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6308 * category.c (hash_get_category_set):
6309 * ccl.c (ccl_driver):
6310 * charset.c (Fdefine_charset_internal):
6311 * charset.h (struct charset.hash_index):
6312 * composite.c (get_composition_id, gstring_lookup_cache)
6313 (composition_gstring_put_cache):
6314 * composite.h (struct composition.hash_index):
6315 * dispextern.h (struct image.hash):
6316 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6317 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6318 (hashfn_equal, hashfn_user_defined, make_hash_table)
6319 (maybe_resize_hash_table, hash_lookup, hash_put)
6320 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6321 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6322 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6323 * image.c (make_image, search_image_cache, lookup_image)
6324 (xpm_put_color_table_h):
6325 * lisp.h (struct Lisp_Hash_Table):
6326 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6327 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6328 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6329 * alloc.c (allocate_vectorlike):
6330 Check for overflow in vector size calculations.
6331 * ccl.c (ccl_driver):
6332 Check for overflow when converting EMACS_INT to int.
6333 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6334 need to be updated by these changes.
6335 * fns.c (make_hash_table, maybe_resize_hash_table):
6336 Check for integer overflow with large hash tables.
6337 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6338 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6339 (SXHASH_REDUCE): New macro.
6340 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6341 Use it instead of discarding useful hash info with large hash values.
6342 (sxhash_float): New function.
6343 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6344 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6345 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6346 Rewrite to use FIXNUM_BITS, as this simplifies things.
6347 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6348 Adjust signatures to match updated version of code.
6349 (consing_since_gc): Now EMACS_INT, since a single hash table can
6350 use more than INT_MAX bytes.
6352 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6354 Make it possible to build with GCC-4.6+ -O2 -flto.
6356 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6358 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6360 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6361 Call minibuffer-inactive-mode.
6363 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6365 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6366 Update dependencies.
6368 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6370 * data.c (init_data): Remove code for UTS, this system is not
6373 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6375 Don't force ./temacs to start in terminal mode.
6377 * frame.c (make_initial_frame): Initialize faces in all cases, not
6378 only when CANNOT_DUMP is defined.
6379 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6381 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6383 * dispnew.c (add_window_display_history): Use const for the string
6384 pointer. Remove declaration, not needed.
6386 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6388 Use 'inline', not 'INLINE'.
6389 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6390 * alloc.c, fontset.c (INLINE): Remove.
6391 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6392 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6393 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6394 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6395 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6397 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6399 Make it possible to run ./temacs.
6401 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6402 syms_of_callproc does the same thing. Remove test for
6403 "initialized", do it in the caller.
6404 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6406 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6408 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6409 (read_minibuf): Use get_minibuffer.
6410 (syms_of_minibuf): Use DEFSYM.
6411 (Qmetadata): New var.
6412 * data.c (Qbuffer): Don't make it static.
6413 (syms_of_data): Use DEFSYM.
6415 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6417 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6418 (CCL_CODE_MIN): New macro.
6420 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6422 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6424 * eval.c (Qdebug): Now static.
6425 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6426 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6427 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6429 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6431 * image.c: Various fixes to ImageMagick code comments.
6432 (Fimagemagick_types): Doc fix.
6434 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6436 Minor fixes prompted by GCC 4.6.0 warnings.
6438 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6440 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6441 (x_clipboard_manager_save_all): Move extern decl to ...
6442 * xterm.h: ... here, so that it can be checked for consistency.
6444 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6446 * xselect.c (x_clipboard_manager_save_frame)
6447 (x_clipboard_manager_save_all): New functions.
6448 (Fx_clipboard_manager_save): Lisp function deleted.
6450 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6451 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6453 * xterm.h: Update prototype.
6455 2011-05-28 William Xu <william.xwl@gmail.com>
6457 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6460 2011-05-28 Jim Meyering <meyering@redhat.com>
6462 Avoid a sign-extension bug in crypto_hash_function.
6463 * fns.c (to_uchar): Define.
6464 (crypto_hash_function): Use it to convert some newly-signed
6465 variables to unsigned, to avoid sign-extension bugs. For example,
6466 without this change, (md5 "truc") would evaluate to
6467 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6468 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6469 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6471 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6473 Integer overflow fixes.
6475 * dbusbind.c: Serial number integer overflow fixes.
6476 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6477 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6478 to hold a serial number that is too large for a fixnum.
6479 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6480 Check for serial numbers out of range. Decode any serial number
6481 that was so large that it became a float. (Bug#8722)
6483 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6484 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6485 Use XFASTINT rather than XUINT when numbers are nonnegative.
6486 (xd_append_arg, Fdbus_method_return_internal):
6487 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6488 arguments, check that Lisp number is nonnegative, rather than
6489 silently wrapping negative numbers around. (Bug#8722)
6490 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6493 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6495 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6497 ccl: Add integer overflow checks.
6498 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6499 (IN_INT_RANGE): New macros.
6500 (ccl_driver): Use them to check for integer overflow when
6501 decoding a CCL program. Many of the new checks are whether XINT (x)
6502 fits in int; it doesn't always, on 64-bit hosts. The new version
6503 doesn't catch all possible integer overflows, but it's an
6504 improvement. (Bug#8719)
6506 * alloc.c (make_event_array): Use XINT, not XUINT.
6507 There's no need for unsigned here.
6509 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6510 This follows up to the 2011-05-06 change that substituted uintptr_t
6511 for EMACS_INT. This case wasn't caught back then.
6513 Rework Fformat to avoid integer overflow issues.
6514 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6515 now (part of C89). Include <verify.h>.
6516 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6517 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6518 (Fformat): Avoid the prepass trying to compute sizes; it was only
6519 approximate and thus did not catch overflow reliably. Instead, walk
6520 through the format just once, formatting and computing sizes as we go,
6521 checking for integer overflow at every step, and allocating a larger
6522 buffer as needed. Keep track separately whether the format is
6523 multibyte. Keep only the most-recently calculated precision, rather
6524 than them all. Record whether each argument has been converted to
6525 string. Use EMACS_INT, not int, for byte and char and arg counts.
6526 Support field widths and precisions larger than INT_MAX. Avoid
6527 sprintf's undefined behavior with conversion specifications such as %#d
6528 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6529 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6530 formatting out-of-range floating point numbers with int
6533 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6535 * data.c: Avoid integer truncation in expressions involving floats.
6536 * data.c: Include <intprops.h>.
6537 (arith_driver): When there's an integer overflow in an expression
6538 involving floating point, convert the integers to floating point
6539 so that the resulting value does not suffer from catastrophic
6540 integer truncation. For example, on a 64-bit host (* 4
6541 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6542 Do not rely on undefined behavior after integer overflow.
6544 merge count_size_as_multibyte, parse_str_to_multibyte
6545 * character.c, character.h (count_size_as_multibyte):
6546 Rename from parse_str_to_multibyte; all uses changed.
6547 Check for integer overflow.
6548 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6549 since it's now a duplicate of the other. This is more of
6550 a character than a buffer op, so better that it's in character.c.
6551 * fns.c, print.c: Adjust to above changes.
6553 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6555 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6557 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6559 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6560 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6561 (x_clipboard_manager_save): Now static.
6562 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6564 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6565 (crypto_hash_function): Now static.
6566 Fix pointer signedness problems. Avoid unnecessary initializations.
6568 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6570 * termhooks.h (Vselection_alist): Make it terminal-local.
6572 * terminal.c (create_terminal): Initialize it.
6574 * xselect.c: Support for clipboard managers.
6575 (Vselection_alist): Move to termhooks.h as terminal-local var.
6576 (LOCAL_SELECTION): New macro.
6577 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6578 (symbol_to_x_atom): Remove gratuitous arg.
6579 (x_handle_selection_request, lisp_data_to_selection_data)
6580 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6581 (x_own_selection, x_get_local_selection, x_convert_selection):
6582 New arg, specifying work frame. Use terminal-local Vselection_alist.
6583 (some_frame_on_display): Delete unused function.
6584 (Fx_own_selection_internal, Fx_get_selection_internal)
6585 (Fx_disown_selection_internal, Fx_selection_owner_p)
6586 (Fx_selection_exists_p): New optional frame arg.
6587 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6588 (x_handle_selection_clear): Don't treat other terminals with the
6589 same keyboard specially. Use the terminal-local Vselection_alist.
6590 (x_clear_frame_selections): Use Frun_hook_with_args.
6592 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6594 * xterm.h: Add support for those atoms.
6596 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6598 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6599 (converted_selections, conversion_fail_tag): New global variables.
6600 (x_selection_request_lisp_error): Free the above.
6601 (x_get_local_selection): Remove unnecessary code.
6602 (x_reply_selection_request): Args changed; handle arbitrary array
6603 of converted selections stored in converted_selections.
6604 Separate the XChangeProperty and SelectionNotify steps.
6605 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6606 (x_convert_selection): New function.
6607 (x_handle_selection_event): Simplify.
6608 (x_get_foreign_selection): Don't ignore incoming requests while
6609 waiting for an answer; this will fail when we implement
6610 SAVE_TARGETS, and seems unnecessary anyway.
6611 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6612 (Vx_sent_selection_functions): Doc fix.
6614 2011-05-26 Leo Liu <sdl.web@gmail.com>
6616 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6618 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6620 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6622 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6623 for fringe update if it has periodic bitmap.
6624 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6625 and fringe_bitmap_periodic_p.
6627 * fringe.c (get_fringe_bitmap_data): New function.
6628 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6629 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6630 row. Mark glyph row for fringe update if periodicity changed.
6632 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6633 for fringe update unless it has periodic bitmap.
6635 2011-05-25 Kenichi Handa <handa@m17n.org>
6637 * xdisp.c (get_next_display_element): Set correct it->face_id for
6638 a static composition.
6640 2011-05-24 Leo Liu <sdl.web@gmail.com>
6643 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6645 * fns.c (crypto_hash_function, Fsha1): New function.
6646 (Fmd5): Use crypto_hash_function.
6647 (syms_of_fns): Add Ssha1.
6649 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6651 * gnutls.c: Remove unused macros.
6652 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6653 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6654 Remove macros that are defined and never used.
6655 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6657 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6659 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6660 (Fx_get_selection_internal): Minor cleanup.
6661 (Fx_own_selection_internal): Rename arguments for consistency with
6664 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6666 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6668 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6670 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6672 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6674 * dispnew.c (scrolling_window): Don't exclude the case that the
6675 last enabled row in the desired matrix touches the bottom boundary.
6677 2011-05-21 Glenn Morris <rgm@gnu.org>
6679 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6680 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6681 and add some more files.
6683 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6685 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6686 report_file_error introduced by the change from 2011-05-07.
6688 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6690 * systime.h (Time): Define only if emacs is defined.
6691 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6692 where the include path doesn't have X11/X.h by default. See
6693 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6695 2011-05-20 Kenichi Handa <handa@m17n.org>
6697 * composite.c (find_automatic_composition): Fix previous change.
6699 2011-05-20 Glenn Morris <rgm@gnu.org>
6701 * lisp.mk: New file, split from Makefile.in.
6702 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6703 (shortlisp): Remove.
6704 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6706 2011-05-19 Glenn Morris <rgm@gnu.org>
6708 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6709 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6710 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6711 (lisp): Set the order to that of loadup.el.
6712 (shortlisp): Make it a copy of $lisp.
6713 (SOME_MACHINE_LISP): Remove.
6714 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6715 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6717 2011-05-18 Kenichi Handa <handa@m17n.org>
6719 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6720 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6721 (find_automatic_composition): Mostly rewrite for efficiency.
6723 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6725 * makefile.w32-in: Update dependencies.
6727 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6729 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6730 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6732 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6734 Fix some integer overflow issues, such as string length overflow.
6736 * insdel.c (count_size_as_multibyte): Check for string overflow.
6738 * character.c (lisp_string_width): Check for string overflow.
6739 Use EMACS_INT, not int, for string indexes and lengths; in
6740 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6741 the resulting string length overflows an EMACS_INT; instead,
6742 report a string overflow if no precision given. When checking for
6743 precision exhaustion, use a check that cannot possibly have
6744 integer overflow. (Bug#8675)
6745 * character.h (lisp_string_width): Adjust to new signature.
6747 * alloc.c (string_overflow): New function.
6748 (Fmake_string): Use it. This doesn't change behavior, but saves
6749 a few bytes and will simplify future changes.
6750 * character.c (string_escape_byte8): Likewise.
6751 * lisp.h (string_overflow): New decl.
6753 Fixups, following up to the user-interface timestamp change.
6754 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6755 for UI timestamps, instead of unsigned long.
6756 * msdos.c (mouse_get_pos): Likewise.
6757 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6758 * w32gui.h (Time): Define by including "systime.h" rather than by
6759 declaring it ourselves. (Bug#8664)
6761 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6762 * image.c (clear_image_cache): Likewise.
6764 * term.c (term_mouse_position): Don't assume time_t wraparound.
6766 Be more systematic about user-interface timestamps.
6767 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6768 and sometimes 'EMACS_UINT', to represent these timestamps.
6769 This change causes it to use 'Time' uniformly, as that's what X uses.
6770 This makes the code easier to follow, and makes it easier to catch
6771 integer overflow bugs such as Bug#8664.
6772 * frame.c (Fmouse_position, Fmouse_pixel_position):
6773 Use Time, not unsigned long, for user-interface timestamps.
6774 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6775 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6776 * keyboard.h (last_event_timestamp): Likewise.
6777 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6778 * menu.h (xmenu_show): Likewise.
6779 * term.c (term_mouse_position): Likewise.
6780 * termhooks.h (struct input_event.timestamp): Likewise.
6781 (struct terminal.mouse_position_hook): Likewise.
6782 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6783 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6784 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6785 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6787 * menu.h, termhooks.h: Include "systime.h", for Time.
6789 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6790 Don't assume that the difference between two unsigned long values
6791 can fit into an integer. At this point, we know button_down_time
6792 <= event->timestamp, so the difference must be nonnegative, so
6793 there's no need to cast the result if double-click-time is
6794 nonnegative, as it should be; check that it's nonnegative, just in
6795 case. This bug is triggered when events are more than 2**31 ms
6796 apart (about 25 days). (Bug#8664)
6798 * xselect.c (last_event_timestamp): Remove duplicate decl.
6799 (x_own_selection): Remove needless cast to unsigned long.
6801 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6802 that always fit in int. Use a sentinel instead of a counter, to
6803 avoid a temp and to allay GCC's concerns about possible int overflow.
6804 * frame.h (struct frame): Use int for menu_bar_items_used
6805 instead of EMACS_INT, since it always fits in int.
6807 * menu.c (grow_menu_items): Check for int overflow.
6809 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6811 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6812 Before, the code was not consistent. These values cannot exceed
6813 2**31 - 1 so there's no need to make them unsigned.
6814 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6815 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6816 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6818 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6820 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6821 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6822 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6823 presumably because the widths might not match.
6825 * window.c (size_window): Avoid needless test at loop start.
6827 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6829 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6831 2011-05-12 Drew Adams <drew.adams@oracle.com>
6833 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6835 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6837 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6838 `width' to `bar_area_x' and `bar_area_width', respectively.
6839 (x_scroll_run): Take account of fringe background extension.
6841 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6842 Rename local vars `left' and `width' to `bar_area_x' and
6843 `bar_area_width', respectively.
6844 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6845 background extension.
6847 2011-05-10 Jim Meyering <meyering@redhat.com>
6849 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6851 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6853 * image.c (Finit_image_library): Return t for built-in image types,
6854 like pbm and xbm. (Bug#8640)
6856 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6858 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6860 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6862 * w32console.c (Fset_screen_color): Doc fix.
6863 (Fget_screen_color): New function.
6864 (syms_of_ntterm): Defsubr it.
6866 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6867 unlink the temporary file if Fcall_process didn't create it in the
6869 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6870 child process will be redirected to a file specified with `:file'.
6871 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6872 cue to call_process_cleanup not to close that handle.
6874 2011-05-07 Ben Key <bkey76@gmail.com>
6876 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6877 one of two shell specific rules, either bootstrap-temacs-CMD or
6878 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6879 to the previous implementation of the bootstrap-temacs rule.
6880 The bootstrap-temacs-CMD rule is similar to the previous
6881 implementation of the bootstrap-temacs rule except that it
6882 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6885 These changes, along with some changes to nt/configure.bat,
6886 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6887 earlier fix to add support for --cflags and --ldflags options
6888 that include quotes so that it works whether make uses cmd or
6891 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6893 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6894 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6896 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6897 a string. Handle both cases.
6898 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6899 (Fdbus_register_method): Use Qinvalid_function.
6901 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6903 * makefile.w32-in: Update dependencies.
6904 (LISP_H): Add inttypes.h and stdin.h.
6905 (PROCESS_H): Add unistd.h.
6907 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6909 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6910 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6912 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6914 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6916 * term.c (vfatal): Remove stray call to va_end.
6917 It's not needed and the C Standard doesn't allow it here anyway.
6919 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6920 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6922 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6925 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6927 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6929 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6931 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6933 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6935 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6936 * charset.c (Fdefine_charset_internal): Don't initialize
6937 charset.code_space[15]. The value was garbage, on hosts with
6938 32-bit int (Bug#8600).
6940 * lread.c (read_integer): Be more consistent with string-to-number.
6941 Use string_to_number to do the actual conversion; this avoids
6942 rounding errors and fixes some other screwups. Without this fix,
6943 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6944 (digit_to_number): Move earlier, for benefit of read_integer.
6945 Return -1 if the digit is out of range for the base, -2 if it is
6946 not a digit in any supported base. (Bug#8602)
6948 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6950 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6951 to match comment at start of function. This also removes a
6952 GCC warning about overflow in a 32+64-bit port.
6954 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6956 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6957 Reported by Stefan Monnier in
6958 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6959 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6960 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6962 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6963 (EMACS_UINTPTR): Likewise, with uintptr_t.
6965 * lisp.h: Prefer 64-bit EMACS_INT if available.
6966 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6967 on 32-bit hosts that have 64-bit int, so that they can access
6969 However, temporarily disable this change unless the temporary
6970 symbol WIDE_EMACS_INT is defined.
6972 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6974 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6975 This removes an assumption that EMACS_INT and long are the same
6976 width as pointers. The assumption is true for Emacs porting targets
6977 now, but we want to make other targets possible.
6978 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6979 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6980 In the rest of the code, change types of integers that hold casted
6981 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6982 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6983 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6984 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6985 No need to cast type when ORing.
6986 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6987 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6988 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6989 assume EMACS_INT is the same width as char *.
6990 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6991 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6992 Remove no-longer-needed casts.
6993 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6994 (xg_tool_bar_help_callback, xg_make_tool_item):
6995 Use EMACS_INTPTR to hold an integer
6996 that will be cast to void *; this can avoid a GCC warning
6997 if EMACS_INT is not the same width as void *.
6998 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6999 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7000 (current_message_1, set_message_1):
7001 Use a local to convert to proper width without a cast.
7002 * xmenu.c (dialog_selection_callback): Likewise.
7004 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7005 Also, don't assume VALBITS / RAND_BITS is less than 5,
7006 and don't rely on undefined behavior when shifting a 1 left into
7008 * lisp.h (get_random): Change signature to match.
7010 * lread.c (hash_string): Use size_t, not int, for hash computation.
7011 Normally we prefer signed values; but hashing is special, because
7012 it's better to use unsigned division on hash table sizes so that
7013 the remainder is nonnegative. Also, size_t is the natural width
7014 for hashing into memory. The previous code used 'int', which doesn't
7015 retain enough info to hash well into very large tables.
7016 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7018 * dbusbind.c: Don't possibly lose pointer info when converting.
7019 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7020 Use XPNTR rather than XHASH, so that the high-order bits of
7021 the pointer aren't lost when converting through void *.
7023 * eval.c (Fautoload): Don't double-shift a pointer.
7025 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7027 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7029 * gnutls.c (DEF_GNUTLS_FN):
7030 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7032 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7034 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7037 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7039 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7040 New version that can reserve upto 2GB of heap space.
7042 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7044 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7046 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7048 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7049 `gnutls_certificate_set_x509_key_file'.
7051 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7053 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7054 Update dependencies.
7056 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7058 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7059 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7060 Remove unused parameter `fildes'.
7061 * process.c (read_process_output, send_process): Don't pass it.
7063 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7065 Fix previous change: the library cache is defined in w32.c.
7066 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7067 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7069 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7071 Implement dynamic loading of GnuTLS on Windows.
7073 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7074 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7075 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7078 * gnutls.c (Qgnutls_dll): Define.
7079 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7080 (gnutls_*): Declare function pointers.
7081 (init_gnutls_functions): New function to initialize function pointers.
7082 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7083 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7084 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7085 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7086 (emacs_gnutls_write, emacs_gnutls_read)
7087 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7088 (Fgnutls_available_p): New function.
7089 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7090 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7091 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7093 * image.c: Include w32.h.
7094 (Vimage_type_cache): Delete.
7095 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7096 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7097 (w32_delayed_load): Move to w32.c.
7099 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7101 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7102 (w32_delayed_load): Move from image.c. When loading a library, record
7103 its filename in the :loaded-from property of the library id.
7104 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7105 Initialize and staticpro them.
7106 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7108 * process.c: Include lisp.h before w32.h, not after.
7109 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7110 instead of gnutls_record_check_pending.
7112 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7114 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7116 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7117 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7120 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7122 * xterm.c (x_set_frame_alpha): Do not set property on anything
7123 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7125 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7127 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7129 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7131 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7132 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7133 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7134 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7135 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7136 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7137 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7138 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7139 (Qgnutls_bootprop_callbacks_verify): Make static.
7141 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7143 * callproc.c: Indentation fixup.
7145 * sysdep.c (wait_for_termination_1): Make static.
7146 (wait_for_termination, interruptible_wait_for_termination):
7147 Move after wait_for_termination_1.
7149 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7151 * sysdep.c (interruptible_wait_for_termination): New function
7152 which is like wait_for_termination, but allows keyboard
7155 * callproc.c (Fcall_process): Add (:file "file") as an option for
7157 (Fcall_process_region): Ditto.
7159 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7161 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7162 rather than `XVECTOR (FOO)->size'.
7164 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7165 inttypes.h, as a gnulib replacement is used if it not available in
7168 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7170 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7171 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7172 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7174 * coding.c (coding_alloc_by_realloc): Error out if destination
7175 will grow beyond MOST_POSITIVE_FIXNUM.
7176 (decode_coding_emacs_mule): Abort if there isn't enough place in
7177 charbuf for the composition carryover bytes. Reserve an extra
7178 space for up to 2 characters produced in a loop.
7179 (decode_coding_iso_2022): Abort if there isn't enough place in
7180 charbuf for the composition carryover bytes.
7182 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7184 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7185 aborting when %lld or %lll format is passed.
7186 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7187 %llo or %llx format is passed. (Bug#8545)
7189 * window.c (window_scroll_line_based): Use a marker instead of
7190 simple variables to record original value of point. (Bug#7952)
7192 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7193 produced by %s or %c overflows available buffer space. (Bug#8545)
7195 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7197 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7198 (SIZE_MAX): Move defn after all includes, as they might #define it.
7200 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7202 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7204 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7206 * keyboard.c (Qdelayed_warnings_hook): Define.
7207 (command_loop_1): Run `delayed-warnings-hook'
7208 if Vdelayed_warnings_list is non-nil.
7209 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7210 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7212 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7214 * doprnt.c (doprnt): Don't return value smaller than the buffer
7215 size if the message was truncated. (Bug#8545).
7217 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7219 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7220 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7222 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7224 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7226 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7228 * makefile.w32-in: Update dependencies.
7230 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7232 Improve `doprnt' and its usage. (Bug#8545)
7233 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7234 `format_end'. Remove support for %l as a conversion specifier.
7235 Don't use xrealloc. Improve diagnostics when the %l size modifier
7236 is used. Update the commentary.
7238 * eval.c (verror): Simplify calculation of size_t.
7240 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7243 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7245 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7248 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7250 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7251 This makes this file independent of the recent pseudovector change.
7253 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7255 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7257 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7258 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7259 Remove unused local.
7260 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7262 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7263 GCC 4.6.0 optimizes based on type-based alias analysis.
7264 For example, if b is of type struct buffer * and v of type struct
7265 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7266 != &v->size, and therefore "v->size = 1; b->size = 2; return
7267 v->size;" must therefore return 1. This assumption is incorrect
7268 for Emacs, since it type-puns struct Lisp_Vector * with many other
7269 types. To fix this problem, this patch adds a new type struct
7270 vectorlike_header that documents the constraints on layout of vectors
7271 and pseudovectors, and helps optimizing compilers not get fooled
7272 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7273 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7274 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7276 (XSETPVECTYPE): Rewrite in terms of new macro.
7277 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7278 This is a bit clearer, and further avoids the possibility of
7279 undesirable aliasing.
7280 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7281 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7282 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7283 since Lisp_Subr is a special case (no "next" field).
7284 (ASIZE): Now uses header.size rather than size.
7285 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7286 to avoid the hassle of writing XVECTOR (foo)->header.size.
7287 (struct vectorlike_header): New type.
7288 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7289 object, to help avoid aliasing.
7290 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7291 (SUBRP): Likewise, since Lisp_Subr is a special case.
7292 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7293 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7294 (struct Lisp_Hash_Table): Combine first two members into a single
7295 struct vectorlike_header member. All uses of "size" and "next" members
7296 changed to be "header.size" and "header.next".
7297 * buffer.h (struct buffer): Likewise.
7298 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7299 * frame.h (struct frame): Likewise.
7300 * process.h (struct Lisp_Process): Likewise.
7301 * termhooks.h (struct terminal): Likewise.
7302 * window.c (struct save_window_data, struct saved_window): Likewise.
7303 * window.h (struct window): Likewise.
7304 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7305 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7306 * buffer.c (init_buffer_once): Likewise.
7307 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7309 * process.c (Fformat_network_address): Use local var for size,
7312 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7314 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7315 * data.c (atof): Remove decl; no longer used or needed.
7316 (digit_to_number): Move to lread.c.
7317 (Fstring_to_number): Use new string_to_number function, to be
7318 consistent with how the Lisp reader treats infinities and NaNs.
7319 Do not assume that floating-point numbers represent EMACS_INT
7320 without losing information; this is not true on most 64-bit hosts.
7321 Avoid double-rounding errors, by insisting on integers when
7322 parsing non-base-10 numbers, as the documentation specifies.
7323 * lisp.h (string_to_number): New decl, replacing ...
7324 (isfloat_string): Remove.
7325 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7326 (read1): Do not accept +. and -. as integers; this
7327 appears to have been a coding error. Similarly, do not accept
7328 strings like +-1e0 as floating point numbers. Do not report
7329 overflow for integer overflows unless the base is not 10 which
7330 means we have no simple and reliable way to continue.
7331 Break out the floating-point parsing into a new
7332 function string_to_number, so that Fstring_to_number parses
7333 floating point numbers consistently with the Lisp reader.
7334 (digit_to_number): Move here from data.c. Make it static inline.
7335 (E_CHAR, EXP_INT): Remove, replacing with ...
7336 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7337 (string_to_number): New function, replacing isfloat_string.
7338 This function checks for valid syntax and produces the resulting
7339 Lisp float number too. Rework it so that string-to-number
7340 no longer mishandles examples like "1.0e+". Use strtoumax,
7341 so that overflow for non-base-10 numbers is reported only when
7342 there's no portable and simple way to convert to floating point.
7344 * textprop.c (set_text_properties_1): Rewrite for clarity,
7345 and to avoid GCC warning about integer overflow.
7347 * intervals.h (struct interval): Use EMACS_INT for members
7348 where EMACS_UINT might cause problems. See
7349 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7350 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7351 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7353 (offset_intervals): Tell GCC not to worry about length overflow
7354 when negating a negative length.
7356 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7357 (overrun_check_free): Likewise.
7359 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7360 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7363 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7364 (gnutls_make_error): Rename local to avoid shadowing.
7365 (gnutls_emacs_global_deinit): ifdef out; not used.
7366 (Fgnutls_boot): Use const for pointer to readonly storage.
7367 Comment out unused local. Fix pointer signedness problems.
7369 * lread.c (openp): Don't stuff size_t into an 'int'.
7370 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7371 about possible signed overflow.
7373 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7374 (GDK_KEY_g): Don't define if already defined.
7375 (xg_prepare_tooltip): Avoid pointer signedness problem.
7376 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7378 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7379 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7381 * xfns.c (Fx_window_property): Simplify a bit,
7382 to make a bit faster and to avoid GCC 4.6.0 warning.
7383 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7385 * fns.c (internal_equal): Don't assume size_t fits in int.
7387 * alloc.c (compact_small_strings): Tighten assertion a little.
7389 Replace pEd with more-general pI, and fix some printf arg casts.
7390 * lisp.h (pI): New macro, generalizing old pEd macro to other
7391 conversion specifiers. For example, use "...%"pI"d..." rather
7392 than "...%"pEd"...".
7393 (pEd): Remove. All uses replaced with similar uses of pI.
7394 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7395 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7396 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7397 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7398 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7399 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7400 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7402 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7403 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7404 * print.c (safe_debug_print, print_object): Likewise.
7405 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7407 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7408 avoiding the 0 flag, which is not portable.
7409 * process.c (Fmake_network_process): Use pI to avoid cast.
7410 * region-cache.c (pp_cache): Likewise.
7411 * xdisp.c (decode_mode_spec): Likewise.
7412 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7413 behavior on 64-bit hosts with printf arg.
7414 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7415 (x_stop_queuing_selection_requests): Likewise.
7416 (x_get_window_property): Don't truncate byte count to an 'int'
7419 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7420 here, since it parses constructs like leading '-' and spaces,
7421 which are not wanted; and it overflows with large numbers.
7422 Instead, simply match F[0-9]+, which is what is wanted anyway.
7424 * alloc.c: Remove unportable assumptions about struct layout.
7425 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7426 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7427 (allocate_vectorlike, make_pure_vector): Use the new macros,
7428 plus offsetof, to remove unportable assumptions about struct layout.
7429 These assumptions hold on all porting targets that I know of, but
7430 they are not guaranteed, they're easy to remove, and removing them
7431 makes further changes easier.
7433 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7434 This doesn't fix a bug but makes the code clearer.
7435 (string_overrun_cookie): Now const. Use initializers that
7436 don't formally overflow signed char, to avoid warnings.
7437 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7438 can cause Emacs to crash when string overrun checking is enabled.
7439 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7440 multiple of sizeof (EMACS_INT); it need not be, if
7441 alignof(EMACS_INT) < sizeof (EMACS_INT).
7442 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7444 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7446 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7448 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7450 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7451 supposed to be handshaking. (Bug#8556)
7452 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7454 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7456 * lisp.h (Qdebug): List symbol.
7457 * eval.c (Qdebug): Restore global linkage.
7458 * keyboard.c (debug-on-event): New variable.
7459 (handle_user_signal): Break into debugger when debug-on-event
7460 matches the current signal symbol.
7462 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7464 * alloc.c (check_sblock, check_string_bytes)
7465 (check_string_free_list): Convert to standard C.
7467 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7469 * w32.c (emacs_gnutls_push): Fix typo.
7471 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7473 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7474 "cast to pointer from integer of different size".
7476 Improve doprnt and its use in verror. (Bug#8545)
7477 * doprnt.c (doprnt): Document the set of format control sequences
7478 supported by the function. Use SAFE_ALLOCA instead of always
7481 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7482 is one byte too soon. Don't use xrealloc; instead xfree and
7485 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7487 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7490 * gnutls.c: Renamed global_initialized to
7491 gnutls_global_initialized. Added internals for the
7492 :verify-hostname-error, :verify-error, and :verify-flags
7493 parameters of `gnutls-boot' and documented those parameters in the
7494 docstring. Start callback support.
7495 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7496 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7497 on error. Return error code.
7498 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7499 (emacs_gnutls_read): Likewise.
7500 (Fgnutls_boot): Return handshake error code.
7501 (emacs_gnutls_handle_error): New function.
7502 (wsaerror_to_errno): Likewise.
7504 * w32.h (emacs_gnutls_pull): Add prototype.
7505 (emacs_gnutls_push): Likewise.
7507 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7508 (emacs_gnutls_push): Likewise.
7510 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7512 * process.c (wait_reading_process_output): Check if GnuTLS
7513 buffered some data internally if no FDs are set for TLS
7516 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7517 (LIBS): Link to USER_LIBS.
7518 ($(BLD)/gnutls.$(0)): New target.
7520 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7522 * xdisp.c (handle_single_display_spec): Rename the
7523 display_replaced_before_p argument into display_replaced_p, to
7524 make it consistent with the commentary. Fix typos in the
7527 * textprop.c (syms_of_textprop): Remove dead code.
7528 (copy_text_properties): Delete obsolete commentary about an
7529 interface that was deleted long ago. Fix typos in the description
7532 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7533 to changes in oldXMenu/XMenu.h from 2011-04-16.
7534 <menu_help_message, prev_menu_help_message>: Constify.
7535 (IT_menu_make_room): menu->help_text is now `const char **';
7538 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7539 to changes in oldXMenu/XMenu.h from 2011-04-16.
7540 (struct XMenu): Declare `help_text' `const char **'.
7542 * xfaces.c <Qunspecified>: Make extern again.
7544 * syntax.c: Include sys/types.h before including regex.h, as
7547 * doc.c (get_doc_string): Improve the format passed to `error'.
7549 * doprnt.c (doprnt): Improve commentary.
7551 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7553 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7556 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7557 changes in globals.h immediately force recompilation.
7558 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7559 $(CURDIR)/s/ms-w32.h.
7560 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7562 * character.c (Fchar_direction): Function deleted.
7563 (syms_of_character): Don't defsubr it.
7564 <char-direction-table>: Deleted.
7566 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7568 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7569 * doprnt.c: Include limits.h.
7570 (SIZE_MAX): New macro.
7571 (doprnt): Return a size_t value. 2nd arg is now size_t.
7572 Many local variables are now size_t instead of int or unsigned.
7573 Improve overflow protection. Support `l' modifier for integer
7574 conversions. Support %l conversion. Don't assume an EMACS_INT
7575 argument for integer conversions and for %c.
7577 * lisp.h (doprnt): Restore prototype.
7579 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7582 * Makefile.in (base_obj): Add back doprnt.o.
7584 * deps.mk (doprnt.o): Add back prerequisites.
7585 (callint.o): Depend on character.h.
7587 * eval.c (internal_lisp_condition_case): Include the handler
7588 representation in the error message.
7589 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7590 when breaking from the loop.
7592 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7594 * callint.c (Fcall_interactively): When displaying error message
7595 about invalid control letter, pass the character's codepoint, not
7596 a pointer to its multibyte form. Improve display of the character
7597 in octal and display also its hex code.
7599 * character.c (char_string): Use %x to display the (unsigned)
7600 codepoint of an invalid character, to avoid displaying a bogus
7603 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7604 `error', not SYMBOL_NAME itself.
7606 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7607 character arguments to `error'.
7609 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7610 to `error' in error message about FINAL_CHAR argument. Make sure
7611 FINAL_CHAR is a character, and use %c when it is passed as
7612 argument to `error'.
7614 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7616 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7618 * w32.c: Include <time.h>.
7619 (sys_localtime): New function.
7621 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7623 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7625 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7627 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7629 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7632 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7634 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7635 gl_state.e_property when gl_state.object is Qt.
7637 * insdel.c (make_gap_larger): Remove limitation of buffer size
7640 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7642 * xdisp.c (lookup_glyphless_char_display)
7643 (produce_glyphless_glyph): Handle cons cell entry in
7644 glyphless-char-display.
7645 (Vglyphless_char_display): Document it.
7647 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7648 glyphless-char-display.
7650 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7652 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7654 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7656 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7657 definition for no-X builds.
7659 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7661 Static checks with GCC 4.6.0 and non-default toolkits.
7663 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7665 * process.c (keyboard_bit_set): Define only if SIGIO.
7666 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7667 (send_process): Repair possible setjmp clobbering.
7669 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7671 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7673 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7675 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7676 Define only if needed.
7678 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7679 by pacifying GCC about it. Maybe it's time to retire it?
7680 * xfaces.c (USG, __TIMEVAL__): Likewise.
7682 * dispextern.h (struct redisplay_interface): Rename param
7684 * termhooks.h (struct terminal): Likewise.
7685 * xterm.c (xembed_send_message): Likewise.
7687 * insdel.c (make_gap_smaller): Define only if
7688 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7690 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7693 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7694 so that we aren't warned about unused symbols.
7696 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7698 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7700 * xfns.c (x_real_positions): Mark locals as initialized.
7702 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7704 * xterm.c: Fix problems found by static analysis with other toolkits.
7705 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7706 (x_dispatch_event): Declare static if USE_GTK, and
7707 define if USE_GTK || USE_X_TOOLKIT.
7708 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7709 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7710 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7711 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7713 * xmenu.c (menu_help_callback): Pointer type fixes.
7714 Use const pointers when pointing at readonly data. Avoid pointer
7716 (FALSE): Remove unused macro.
7717 (update_frame_menubar): Remove unused decl.
7719 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7721 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7722 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7723 (single_menu_item): Rename local to avoid shadowing.
7725 * keyboard.c (make_lispy_event): Remove unused local var.
7727 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7728 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7730 * bitmaps: Change bitmaps from unsigned char back to the X11
7731 compatible char. Avoid the old compiler warnings about
7732 out-of-range initializers by using, for example, '\xab' rather
7735 * xgselect.c (xgselect_initialize): Check vs interface
7736 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7738 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7740 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7741 to read-only memory.
7743 * fns.c (vector): Remove; this old hack is no longer needed.
7745 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7747 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7749 * xrdb.c (x_load_resources): Omit unused local.
7751 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7752 (x_window): Rename locals to avoid shadowing.
7753 (USG): Use the kludged USG macro, to pacify gcc.
7755 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7756 (x_term_init): Remove local to avoid shadowing.
7758 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7760 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7761 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7763 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7765 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7767 Fix regex.c, syntax.c and friends for buffers > 2GB.
7768 * syntax.h (struct gl_state_s): Declare character position members
7771 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7773 * textprop.c (verify_interval_modification, interval_of):
7774 Declare arguments EMACS_INT.
7776 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7779 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7781 * indent.c (Fvertical_motion): Local variable it_start is now
7784 * regex.c (re_match, re_match_2, re_match_2_internal)
7785 (bcmp_translate, regcomp, regexec, print_double_string)
7786 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7787 (re_compile_pattern, re_exec): Declare arguments and local
7788 variables `size_t' and `ssize_t' and return values `regoff_t', as
7790 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7791 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7792 <compile_stack_type>: `size' and `avail' are now `size_t'.
7794 * regex.h <regoff_t>: Use ssize_t, not int.
7795 (re_search, re_search_2, re_match, re_match_2): Arguments that
7796 specify buffer/string position and length are now ssize_t and
7797 size_t. Return type is regoff_t.
7799 2011-04-16 Ben Key <bkey76@gmail.com>
7801 * nsfont.m: Fixed bugs in ns_get_family and
7802 ns_descriptor_to_entity that were caused by using free to
7803 deallocate memory blocks that were allocated by xmalloc (via
7804 xstrdup). This caused Emacs to crash when compiled with
7805 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7806 --enable-checking=xmallocoverrun). xfree is now used to
7807 deallocate these memory blocks.
7809 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7811 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7813 emacs_write: Accept and return EMACS_INT for sizes.
7814 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7816 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7817 Accept and return EMACS_INT.
7818 (emacs_gnutls_write): Return the number of bytes written on
7820 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7821 (emacs_read, emacs_write): Remove check for negative size, as the
7822 Emacs source code has been audited now.
7823 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7824 (emacs_read, emacs_write): Use it.
7825 * process.c (send_process): Adjust to the new signatures of
7826 emacs_write and emacs_gnutls_write. Do not attempt to store
7827 a byte offset into an 'int'; it might overflow.
7828 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7830 * sound.c: Don't assume sizes fit in 'int'.
7831 (struct sound_device.period_size, alsa_period_size):
7832 Return EMACS_INT, not int.
7833 (struct sound_device.write, vox_write, alsa_write):
7834 Accept EMACS_INT, not int.
7835 (wav_play, au_play): Use EMACS_INT to store sizes and to
7836 record read return values.
7838 2011-04-15 Ben Key <bkey76@gmail.com>
7840 * keyboard.c (Qundefined): Don't declare static since it is used
7842 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7843 static since they are used in nsfont.m.
7845 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7847 * process.c (Qprocessp): Don't declare static.
7848 * lisp.h (Qprocessp): Declare again.
7850 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7852 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7854 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7856 Improve C-level modularity by making more things 'static'.
7858 Don't publish debugger-only interfaces to other modules.
7859 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7860 (verify_bytepos, count_markers): Move decls to the only modules
7862 * region-cache.h (pp_cache): Likewise.
7863 * window.h (check_all_windows): Likewise.
7864 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7866 * sysdep.c (croak): Now static, if
7867 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7868 * syssignal.h (croak): Declare only if not static.
7870 * alloc.c (refill_memory_reserve): Now static if
7871 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7872 * lisp.h (refill_memory_reserve): Declare only if not static.
7874 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7875 Define only if USE_LUCID.
7877 * xrdb.c (x_customization_string, x_rm_string): Now static.
7879 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7880 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7882 * xdisp.c (draw_row_with_mouse_face): Now static.
7883 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7885 * window.h (check_all_windows): Mark externally visible.
7887 * window.c (window_deletion_count): Now static.
7889 * undo.c: Make symbols static if they're not exported.
7890 (last_undo_buffer, last_boundary_position, pending_boundary):
7893 * textprop.c (interval_insert_behind_hooks): Now static.
7894 (interval_insert_in_front_hooks): Likewise.
7896 * term.c: Make symbols static if they're not exported.
7897 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7898 (max_frame_lines, tty_set_terminal_modes):
7899 (tty_reset_terminal_modes, tty_turn_off_highlight):
7900 (get_tty_terminal): Now static.
7901 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7902 * termhooks.h (term_mouse_moveto): Do not declare if
7904 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7905 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7907 * sysdep.c: Make symbols static if they're not exported.
7908 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7910 (sigprocmask_set, full_mask): Remove; unused.
7911 (wait_debugging): Mark as visible.
7912 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7913 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7915 * syntax.c (syntax_temp): Define only if !__GNUC__.
7917 * sound.c (current_sound_device, current_sound): Now static.
7919 * search.c (searchbufs, searchbuf_head): Now static.
7921 * scroll.c (scroll_cost): Remove; unused.
7922 * dispextern.h (scroll_cost): Remove decl.
7924 * region-cache.h (pp_cache): Mark as externally visible.
7926 * process.c: Make symbols static if they're not exported.
7927 (process_tick, update_tick, create_process, chan_process):
7928 (Vprocess_alist, proc_buffered_char, datagram_access):
7929 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7930 (deactivate_process): Mark defn as static, as well as decl.
7931 * lisp.h (create_process): Remove decl.
7932 * process.h (chan_process, Vprocess_alist): Remove decls.
7934 * print.c: Make symbols static if they're not exported.
7935 (print_depth, new_backquote_output, being_printed, print_buffer):
7936 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7937 (print_interval, print_number_index, initial_stderr_stream):
7939 * lisp.h (Fprinc): Remove decl.
7940 (debug_output_compilation_hack): Mark as externally visible.
7942 * sysdep.c (croak): Move decl from here to syssignal.h.
7943 * syssignal.h (croak): Put it here, so the API can be checked when
7944 'croak' is called from dissociate_if_controlling_tty.
7946 * minibuf.c: Make symbols static if they're not exported.
7947 (minibuf_save_list, choose_minibuf_frame): Now static.
7948 * lisp.h (choose_minibuf_frame): Remove decl.
7950 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7952 * lread.c: Make symbols static if they're not exported.
7953 (read_objects, initial_obarray, oblookup_last_bucket_number):
7955 (make_symbol): Remove; unused.
7956 * lisp.h (initial_obarray, make_symbol): Remove decls.
7958 * keyboard.c: Make symbols static if they're not exported.
7959 (single_kboard, recent_keys_index, total_keys, recent_keys):
7960 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7961 (this_single_command_key_start, echoing, last_auto_save):
7962 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7963 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7964 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7965 (Vlispy_mouse_stem, double_click_count):
7967 (force_auto_save_soon): Define only if SIGDANGER.
7968 (ignore_mouse_drag_p): Now static if
7969 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7970 (print_help): Remove; unused.
7971 (stop_character, last_timer_event): Mark as externally visible.
7972 * keyboard.h (ignore_mouse_drag_p): Declare only if
7973 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7974 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7975 * lisp.h (echoing): Remove decl.
7976 (force_auto_save_soon): Declare only if SIGDANGER.
7977 * xdisp.c (redisplay_window): Simplify code, to make it more
7978 obvious that ignore_mouse_drag_p is not accessed if !defined
7979 USE_GTK && !defined HAVE_NS.
7981 * intervals.c: Make symbols static if they're not exported.
7982 (merge_properties_sticky, merge_interval_right, delete_interval):
7984 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7986 * insdel.c: Make symbols static if they're not exported.
7987 However, leave prepare_to_modify_buffer alone. It's never
7988 called from outside this function, but that appears to be a bug.
7989 (combine_after_change_list, combine_after_change_buffer):
7990 (adjust_after_replace, signal_before_change): Now static.
7991 (adjust_after_replace_noundo): Remove; unused.
7992 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7993 (signal_before_change): Remove decls.
7995 * indent.c (val_compute_motion, val_vmotion): Now static.
7997 * image.c: Make symbols static if they're not exported.
7998 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8000 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8001 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8003 * fringe.c (standard_bitmaps): Now static.
8004 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8006 * frame.c: Make symbols static if they're not exported.
8007 (x_report_frame_params, make_terminal_frame): Now static.
8008 (get_frame_param): Now static, unless HAVE_NS.
8009 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8010 (x_get_resource_string): Remove; not used.
8011 * frame.h (make_terminal_frame, x_report_frame_params):
8012 (x_get_resource_string); Remove decls.
8013 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8014 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8016 * font.c, fontset.c: Make symbols static if they're not exported.
8017 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8018 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8019 * font.c (font_close_object): Now static.
8020 * font.h (font_close_object): Remove.
8021 * fontset.c (FONTSET_OBJLIST): Remove.
8022 (free_realized_fontset) #if-0 the body, which does nothing.
8023 (face_suitable_for_char_p): #if-0, as it's never called.
8024 * fontset.h (face_suitable_for_char_p): Remove decl.
8025 * xfaces.c (face_at_string_position):
8026 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8027 since 0 is always ASCII.
8029 * fns.c (weak_hash_tables): Now static.
8031 * fileio.c: Make symbols static if they're not exported.
8032 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8033 (Vwrite_region_annotation_buffers): Now static.
8035 * eval.c: Make symbols static if they're not exported.
8036 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8037 * lisp.h (backtrace_list): Remove decl.
8039 * emacs.c: Make symbols static if they're not exported.
8040 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8041 (fatal_error_code, fatal_error_signal_hook, standard_args):
8043 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8044 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8045 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8046 * lisp.h (fatal_error_signal_hook): Remove decl.
8047 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8049 * editfns.c: Move a (normally-unused) function to its only use.
8050 * editfns.c, lisp.h (get_operating_system_release): Remove.
8051 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8052 worth the hassle of breaking this out.
8054 * xterm.c: Make symbols static if they're not exported.
8055 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8056 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8057 (x_destroy_window, x_delete_display):
8059 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8060 (x_mouse_leave): Remove; unused.
8061 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8062 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8063 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8065 (x_mouse_leave): Declare only if WINDOWSNT.
8066 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8067 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8070 * ftxfont.c: Make symbols static if they're not exported.
8071 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8073 * font.h (ftxfont_driver): Likewise.
8075 * xfns.c: Make symbols static if they're not exported.
8076 (x_last_font_name, x_display_info_for_name):
8077 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8078 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8079 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8080 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8081 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8082 (last_show_tip_args): Now static.
8083 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8084 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8085 (x_screen_planes): Remove; unused.
8086 * dispextern.h (x_screen_planes): Remove decl.
8088 * dispnew.c: Make symbols static if they're not exported.
8089 * dispextern.h (redraw_garbaged_frames, scrolling):
8090 (increment_row_positions): Remove.
8091 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8092 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8094 (redraw_garbaged_frames): Remove; unused.
8096 * xfaces.c: Make symbols static if they're not exported.
8097 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8099 * xterm.h (defined_color): Remove decls.
8100 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8101 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8102 (menu_face_changed_default, defined_color, free_realized_face):
8103 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8104 (ascii_face_of_lisp_face): Remove; unused.
8106 * xdisp.c: Make symbols static if they're not exported.
8107 * dispextern.h (scratch_glyph_row, window_box_edges):
8108 (glyph_to_pixel_coords, set_cursor_from_row):
8109 (get_next_display_element, set_iterator_to_next):
8110 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8111 (show_mouse_face): Remove decls
8112 * frame.h (message_buf_print): Likewise.
8113 * lisp.h (pop_message, set_message, check_point_in_composition):
8115 * xterm.h (set_vertical_scroll_bar): Likewise.
8116 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8117 (message_buf_print, scratch_glyph_row, displayed_buffer):
8118 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8119 (get_next_display_element, show_mouse_face, window_box_edges):
8120 (frame_to_window_pixel_xy, check_point_in_composition):
8121 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8122 (glyph_to_pixel_coords): Remove; unused.
8124 * dired.c (file_name_completion): Now static.
8126 * dbusbind.c (xd_in_read_queued_messages): Now static.
8128 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8129 * data.c (circular_list_error): Remove.
8131 * commands.h (last_point_position, last_point_position_buffer):
8132 (last_point_position_window): Remove decls.
8133 * keyboard.c: Make these variables static.
8135 * coding.h (coding, code_convert_region, encode_coding_gap):
8137 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8138 (iso_code_class, detect_coding, code_convert_region): Now static.
8139 (encode_coding_gap): Remove; unused.
8141 * chartab.c (chartab_chars, chartab_bits): Now static.
8143 * charset.h (charset_iso_8859_1): Remove decl.
8144 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8147 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8148 * ccl.c (Vccl_program_table): Now static.
8149 (check_ccl_update): Remove; unused.
8151 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8152 * category.h: ... from here.
8153 * category.c (check_category_table, set_category_set): Now static.
8155 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8156 * lisp.h: Remove these decls.
8158 * buffer.c (buffer_count): Remove unused var.
8160 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8161 so that it's not optimized away.
8162 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8163 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8164 exported only to the debugger.
8166 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8167 * atimer.h (run_all_atimers): Remove; not exported.
8169 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8170 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8171 was inaccessible from Lisp.
8172 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8173 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8175 alloc.c: Import and export fewer symbols, and remove unused items.
8176 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8178 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8179 it's not optimized away by whole-program optimization.
8180 (message_enable_multibyte, free_misc): Remove.
8181 (catchlist, handlerlist, mark_backtrace):
8182 Declare only if BYTE_MARK_STACK.
8183 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8184 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8185 (message_enable_multibyte): Remove decl.
8186 (free_misc, interval_free_list, float_block, float_block_index):
8187 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8188 (cons_free_list, last_marked_index):
8190 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8191 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8192 (mark_backtrace): Define only if BYTE_MARK_STACK.
8193 * xdisp.c (message_enable_multibyte): Now static.
8195 Declare Lisp_Object Q* variables to be 'static' if not exported.
8196 This makes it easier for human readers (and static analyzers)
8197 to see whether these variables are used from other modules.
8198 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8199 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8200 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8201 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8202 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8203 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8204 * xmenu.c, xselect.c:
8205 Declare Q* vars static if they are not used in other modules.
8206 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8207 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8208 Remove decls of unexported vars.
8209 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8211 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8213 Make Emacs functions such as Fatom 'static' by default.
8214 This makes it easier for human readers (and static analyzers)
8215 to see whether these functions can be called from other modules.
8216 DEFUN now defines a static function. To make the function external
8217 so that it can be used in other C modules, use the new macro DEFUE.
8218 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8219 (Finit_image_library):
8220 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8221 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8222 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8223 Remove decls, since these functions are now static.
8224 (Funintern, Fget_internal_run_time): New decls, since these functions
8225 were already external.
8227 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8228 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8229 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8230 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8231 * keyboard.c, keymap.c, lread.c:
8232 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8233 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8234 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8235 Mark functions with DEFUE instead of DEFUN,
8236 if they are used in other modules.
8237 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8238 decls for now-static functions.
8239 * buffer.h (Fdelete_overlay): Remove decl.
8240 * callproc.c (Fgetenv_internal): Mark as internal.
8241 * composite.c (Fremove_list_of_text_properties): Remove decl.
8242 (Fcomposition_get_gstring): New forward static decl.
8243 * composite.h (Fcomposite_get_gstring): Remove decl.
8244 * dired.c (Ffile_attributes): New forward static decl.
8245 * doc.c (Fdocumntation_property): New forward static decl.
8246 * eval.c (Ffetch_bytecode): New forward static decl.
8247 (Funintern): Remove extern decl; now in .h file where it belongs.
8248 * fileio.c (Fmake_symbolic_link): New forward static decl.
8249 * image.c (Finit_image_library): New forward static decl.
8250 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8251 * intervals.h (Fprevious_property_change):
8252 (Fremove_list_of_text_properties): Remove decls.
8253 * keyboard.c (Fthis_command_keys): Remove decl.
8254 (Fcommand_execute): New forward static decl.
8255 * keymap.c (Flookup_key): New forward static decl.
8256 (Fcopy_keymap): Now static.
8257 * keymap.h (Flookup_key): Remove decl.
8258 * process.c (Fget_process): New forward static decl.
8259 (Fprocess_datagram_address): Mark as internal.
8260 * syntax.c (Fsyntax_table_p): New forward static decl.
8261 (skip_chars): Remove duplicate decl.
8262 * textprop.c (Fprevious_property_change): New forward static decl.
8263 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8265 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8266 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8268 * editfns.c (Fformat): Remove unreachable code.
8270 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8272 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8275 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8277 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8278 when at ZV. (Bug#8487)
8280 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8282 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8284 * keyboard.c (parse_tool_bar_item): Likewise.
8285 * sound.c (sound_cleanup, alsa_close): Likewise.
8286 * termcap.c (tgetent): Likewise.
8287 * xfns.c (x_default_font_parameter): Likewise.
8288 * xsettings.c (read_and_apply_settings): Likewise.
8290 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8291 (overrun_check_free): Protoize.
8293 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8295 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8296 since callers should never pass a negative size.
8297 Change the signature to match that of plain 'read' and 'write'; see
8298 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8299 * lisp.h: Update prototypes of emacs_write and emacs_read.
8301 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8303 * xdisp.c (redisplay_window): Don't try to determine the character
8304 position of the scroll margin if the window start point w->startp
8305 is outside the buffer's accessible region. (Bug#8468)
8307 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8309 Fix write-region and its subroutines for buffers > 2GB.
8310 * fileio.c (a_write, e_write): Modify declaration of arguments and
8311 local variables to support buffers larger than 2GB.
8312 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8314 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8315 argument, local variables, and return value.
8317 * lisp.h: Update prototypes of emacs_write and emacs_read.
8319 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8321 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8323 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8325 Fix more problems found by GCC 4.6.0's static checks.
8327 * xdisp.c (vmessage): Use a better test for character truncation.
8329 * charset.c (load_charset_map): <, not <=, for optimization,
8330 and to avoid potential problems with integer overflow.
8331 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8332 * casetab.c (set_identity, shuffle): Likewise.
8333 * editfns.c (Fformat): Likewise.
8334 * syntax.c (skip_chars): Likewise.
8336 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8337 This also lets GCC 4.6.0 generate slightly better loop code.
8339 * callint.c (Fcall_interactively): <, not <=, for optimization.
8340 (Fcall_interactively): Count the number of arguments produced,
8341 not the number of arguments given. This is simpler and lets GCC
8342 4.6.0 generate slightly better code.
8344 * ftfont.c: Distingish more carefully between FcChar8 and char.
8345 The previous code passed unsigned char * to a functions like
8346 strlen and xstrcasecmp that expect char *, which does not
8347 conform to the C standard.
8348 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8349 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8350 char * when the C standard requires it.
8352 * keyboard.c (read_char): Remove unused var.
8354 * eval.c: Port to Windows vsnprintf (Bug#8435).
8356 (SIZE_MAX): Define if the headers do not.
8357 (verror): Do not give up if vsnprintf returns a negative count.
8358 Instead, grow the buffer. This ports to Windows vsnprintf, which
8359 does not conform to C99. Problem reported by Eli Zaretskii.
8360 Also, simplify the allocation scheme, by avoiding the need for
8361 calling realloc, and removing the ALLOCATED variable.
8363 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8365 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8366 But keep the doprint source code for now, as we might revamp it
8367 and use it again (Bug#8435).
8368 * lisp.h (doprnt): Remove.
8369 * Makefile.in (base_obj): Remove doprnt.o.
8370 * deps.mk (doprnt.o): Remove.
8372 error: Print 32- and 64-bit integers portably (Bug#8435).
8373 Without this change, on typical 64-bit hosts error ("...%d...", N)
8374 was used to print both 32- and 64-bit integers N, which relied on
8376 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8377 * lisp.h (error, verror): Mark as printf-like functions.
8378 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8379 Report overflow in size calculations when allocating printf buffer.
8380 Do not truncate output string at its first null byte.
8381 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8382 Truncate the output at a character boundary, since vsnprintf does not
8384 * charset.c (check_iso_charset_parameter): Convert internal
8385 character to string before calling 'error', since %c now has the
8387 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8388 overflow when computing char to be passed to 'error'. Do not
8389 pass Lisp_Object to 'error'; pass the integer instead.
8390 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8391 formatted with plain %d.
8393 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8395 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8397 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8399 * xterm.c (x_catch_errors): Remove duplicate declaration.
8401 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8403 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8405 2011-04-10 Jim Meyering <meyering@redhat.com>
8407 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8408 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8409 return ssize_t not "int", and use size_t as the buffer length.
8410 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8411 * gnutls.h: Update declarations.
8412 * process.c (read_process_output): Use ssize_t, to match.
8413 (send_process): Likewise.
8415 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8417 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8419 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8421 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8422 Use unsigned char, to match FcChar8 type definition.
8424 * xterm.c (handle_one_xevent):
8425 * xmenu.c (create_and_show_popup_menu):
8426 * xselect.c (x_decline_selection_request)
8427 (x_reply_selection_request): Avoid type-punned deref of X events.
8429 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8431 Fix some uses of `int' instead of EMACS_INT.
8432 * search.c (string_match_1, fast_string_match)
8433 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8434 (scan_buffer, find_next_newline_no_quit)
8435 (find_before_next_newline, search_command, Freplace_match)
8436 (Fmatch_data): Make some `int' variables be EMACS_INT.
8438 * xdisp.c (display_count_lines): 3rd argument and return value now
8439 EMACS_INT. All callers changed.
8440 (pint2hrstr): Last argument is now EMACS_INT.
8442 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8443 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8444 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8445 (decode_coding_utf_16, decode_coding_emacs_mule)
8446 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8447 (decode_coding_ccl, decode_coding_charset)
8448 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8449 (decode_coding_iso_2022, decode_coding_emacs_mule)
8450 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8451 <char_offset, last_offset>: Declare EMACS_INT.
8452 (encode_coding_utf_8, encode_coding_utf_16)
8453 (encode_coding_emacs_mule, encode_invocation_designation)
8454 (encode_designation_at_bol, encode_coding_iso_2022)
8455 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8456 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8458 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8459 (encode_invocation_designation): Last argument P_NCHARS is now
8461 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8462 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8464 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8467 * ccl.c (Fccl_execute_on_string): Declare some variables
8470 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8472 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8474 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8476 * process.c (Fformat_network_address): Doc fix.
8478 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8480 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8482 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8484 * keyboard.c (read_char): Call Lisp function help-form-show,
8485 instead of using internal_with_output_to_temp_buffer.
8486 (Qhelp_form_show): New var.
8487 (syms_of_keyboard): Use DEFSYM macro.
8489 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8491 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8493 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8495 * process.c (Flist_processes): Remove to Lisp.
8496 (list_processes_1): Delete.
8498 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8500 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8502 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8504 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8506 Fix more problems found by GCC 4.6.0's static checks.
8508 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8510 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8512 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8514 * xdisp.c (vmessage): Mark as a printf-like function.
8516 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8518 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8520 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8521 printf-like functions.
8522 (tiff_load): Add casts to remove these marks before passing them
8523 to system-supplied API.
8525 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8527 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8528 This avoids several warnings with gcc -Wstrict-overflow.
8529 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8530 directly, rather than having caller test rule sign. This avoids
8531 some unnecessary tests.
8532 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8533 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8534 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8536 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8537 (xfont_open): Avoid unnecessary tests.
8539 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8541 * composite.h, composite.c (composition_gstring_put_cache):
8542 Use EMACS_INT, not int, for length.
8544 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8545 breaking out part of COMPOSITION_DECODE_RULE.
8546 (COMPOSITION_DECODE_RULE): Use it.
8547 * composite.c (get_composition_id): Remove unused local vars,
8548 by using the new macro.
8550 * textprop.c (set_text_properties_1): Change while to do-while,
8551 since the condition is always true at first.
8553 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8554 (interval_deletion_adjustment): Return unsigned value.
8557 * process.c (list_processes_1, create_pty, read_process_output):
8558 (exec_sentinel): Remove vars that were set but not used.
8559 (create_pty): Remove unnecessary "volatile"s.
8560 (Fnetwork_interface_info): Avoid possibility of int overflow.
8561 (read_process_output): Do adaptive read buffering even if carryover.
8562 (read_process_output): Simplify nbytes computation if buffered.
8564 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8566 * syntax.c (scan_words): Remove var that was set but not used.
8567 (update_syntax_table): Use unsigned instead of int.
8569 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8570 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8571 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8573 * print.c (print_error_message): Avoid int overflow.
8575 * font.c (font_list_entities): Redo for clarity,
8576 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8578 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8579 (font_score): Avoid potential overflow in diff calculation.
8581 * fns.c (substring_both): Remove var that is set but not used.
8582 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8584 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8586 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8587 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8588 can always succeed if overflow has undefined behavior.
8590 * search.c (boyer_moore, wordify): Remove vars set but not used.
8591 (wordify): Omit three unnecessary tests.
8593 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8594 All callers changed. This avoids the need for an unused var.
8596 * casefiddle.c (casify_region): Remove var that is set but not used.
8598 * dired.c (file_name_completion): Remove var that is set but not used.
8600 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8602 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8603 (Finsert_file_contents): Remove unnecessary code checking fd.
8605 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8606 Check for integer overflow on size calculations.
8608 * buffer.c (Fprevious_overlay_change): Remove var that is set
8611 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8612 Remove vars that are set but not used.
8613 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8614 (timer_check_2): Mark vars as initialized.
8616 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8618 * image.c (lookup_image): Remove var that is set but not used.
8619 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8621 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8622 that are set but not used.
8624 * xfns.c (make_invisible_cursor): Don't return garbage
8625 if XCreateBitmapFromData fails (Bug#8410).
8627 * xselect.c (x_get_local_selection, x_handle_property_notify):
8628 Remove vars that are set but not used.
8630 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8631 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8633 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8634 Remove var that is set but not used.
8635 (scroll_bar_windows_size): Now size_t, not int.
8636 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8639 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8640 (map_tty_color) [!defined MSDOS]: Likewise.
8642 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8644 * coding.c: Remove vars that are set but not used.
8645 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8646 All callers changed.
8647 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8648 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8649 (decode_coding_charset): Remove vars that are set but not used.
8651 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8652 that is set but not used.
8654 * print.c (print_object): Remove var that is set but not used.
8656 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8657 The gnulib version avoids calling malloc in the usual case,
8658 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8659 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8660 * filelock.c (current_lock_owner): Likewise.
8661 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8662 * sysdep.c: Include allocator.h, careadlinkat.h.
8663 (emacs_no_realloc_allocator): New static constant.
8664 (emacs_readlink): New function.
8665 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8666 ../lib/careadlinkat.h.
8668 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8670 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8671 first non-nil return value).
8673 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8675 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8676 if not defined (Bug#8403).
8678 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8680 * xdisp.c (display_count_lines): Remove parameter `start',
8681 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8682 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8683 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8684 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8685 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8686 and thereabouts. All callers changed.
8687 (get_per_char_metric): Remove parameter `f', unused since
8688 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8690 2011-04-02 Jim Meyering <meyering@redhat.com>
8692 do not dereference NULL upon failed strdup
8693 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8694 (ns_get_family): Likewise.
8696 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8698 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8700 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8702 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8705 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8707 Add lexical binding.
8709 * window.c (Ftemp_output_buffer_show): New fun.
8710 (Fsave_window_excursion):
8711 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8713 * lread.c (lisp_file_lexically_bound_p): New function.
8714 (Fload): Bind Qlexical_binding.
8715 (readevalloop): Remove `evalfun' arg.
8716 Bind Qinternal_interpreter_environment.
8717 (Feval_buffer): Bind Qlexical_binding.
8718 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8720 (syms_of_lread): Declare `lexical-binding'.
8722 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8724 * keyboard.c (eval_dyn): New fun.
8725 (menu_item_eval_property): Use it.
8727 * image.c (parse_image_spec): Use Ffunctionp.
8729 * fns.c (concat, mapcar1): Accept byte-code-functions.
8731 * eval.c (Fsetq): Handle lexical vars.
8732 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8733 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8734 (FletX, Flet): Obey lexical binding.
8735 (Fcommandp): Handle closures.
8736 (Feval): New `lexical' arg.
8737 (eval_sub): New function extracted from Feval. Use it almost
8738 everywhere where Feval was used. Look up vars in lexical env.
8740 (Ffunctionp): Move from subr.el.
8741 (Ffuncall): Handle closures.
8742 (apply_lambda): Remove `eval_flags'.
8743 (funcall_lambda): Handle closures and new byte-code-functions.
8744 (Fspecial_variable_p): New function.
8745 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8746 but without exporting it to Lisp.
8748 * doc.c (Fdocumentation, store_function_docstring):
8749 * data.c (Finteractive_form): Handle closures.
8751 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8754 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8756 (exec_byte_code): New function extracted from Fbyte_code to handle new
8757 calling convention for byte-code-functions. Add new byte-codes.
8759 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8761 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8763 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8765 * xdisp.c (redisplay_internal): Fix prototype.
8767 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8769 * xdisp.c (SCROLL_LIMIT): New macro.
8770 (try_scrolling): Use it when setting scroll_limit.
8771 Limit scrolling to 100 screen lines.
8772 (redisplay_window): Even when falling back on "recentering",
8773 position point in the window according to scroll-conservatively,
8774 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8776 (try_scrolling): When point is above the window, allow searching
8777 as far as scroll_max, or one screenful, to compute vertical
8778 distance from PT to the scroll margin position. This prevents
8779 try_scrolling from unnecessarily failing when
8780 scroll-conservatively is set to a value slightly larger than the
8781 window height. Clean up the case of PT below the margin at bottom
8782 of window: scroll_max can no longer be INT_MAX. When aggressive
8783 scrolling is in use, don't let point enter the opposite scroll
8784 margin as result of the scroll.
8785 (syms_of_xdisp) <scroll-conservatively>: Document the
8786 threshold of 100 lines for never-recentering scrolling.
8788 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8790 * dispextern.h (move_it_by_lines):
8791 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8792 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8793 (message_log_check_duplicate): Remove parameters `prev_bol' and
8794 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8795 (redisplay_internal): Remove parameter `preserve_echo_area',
8796 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8798 * indent.c (Fvertical_motion):
8799 * window.c (window_scroll_pixel_based, Frecenter):
8800 Don't pass `need_y_p' to `move_it_by_lines'.
8802 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8804 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8805 steal a few bits to be more compact.
8806 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8807 Remove unneeded casts.
8809 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8811 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8813 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8814 binding" message (bug#7967).
8816 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8818 Fix more problems found by GCC 4.6.0's static checks.
8820 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8821 Remove unused local var.
8823 * editfns.c (Fmessage_box): Remove unused local var.
8825 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8826 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8827 Omit unused local vars.
8828 * window.c (shrink_windows): Omit unused local var.
8829 * menu.c (digest_single_submenu): Omit unused local var.
8830 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8831 Omit unused local var.
8833 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8834 Don't assume string length fits in int.
8835 (keyremap_step, read_key_sequence): Use size_t for sizes.
8836 (read_key_sequence): Don't check last_real_key_start redundantly.
8838 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8839 instead of alloca (Bug#8344).
8841 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8842 (Fbacktrace_frame): Don't assume nframes fits in int.
8844 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8846 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8849 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8851 * cm.c (calccost): Turn while-do into do-while, for clarity.
8853 * keyboard.c (syms_of_keyboard): Use the same style as later
8854 in this function when indexing through an array. This also
8855 works around GCC bug 48267.
8857 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8859 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8861 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8862 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8864 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8865 This avoids undefined behavior on integer overflow, and is a bit
8866 more convenient anyway since it is compared to a size_t variable.
8868 Variadic C functions now count arguments with size_t, not int.
8869 This avoids an unnecessary limitation on 64-bit machines, which
8870 caused (substring ...) to crash on large vectors (Bug#8344).
8871 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8872 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8873 All variadic functions and their callers changed accordingly.
8874 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8875 * data.c (arith_driver, float_arith_driver): Likewise.
8876 * editfns.c (general_insert_function): Likewise.
8877 * eval.c (struct backtrace.nargs, interactive_p)
8878 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8879 (funcall_lambda, mark_backtrace): Likewise.
8880 * fns.c (concat): Likewise.
8881 * frame.c (x_set_frame_parameters): Likewise.
8882 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8883 0 if not found, not -1. All callers changed.
8885 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8886 (stack_copy_size): Now size_t, not int.
8887 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8889 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8891 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8892 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8893 All callers changed.
8895 * lisp.h (multibyte_char_to_unibyte):
8896 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8897 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8898 * character.h (CHAR_TO_BYTE8):
8899 * cmds.c (internal_self_insert):
8900 * editfns.c (general_insert_function):
8901 * keymap.c (push_key_description):
8902 * search.c (Freplace_match):
8903 * xdisp.c (message_dolog, set_message_1): All callers changed.
8905 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8907 * keyboard.c (safe_run_hook_funcall): New function.
8908 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8909 don't set the hook to nil, but remove the offending function instead.
8910 (Qcommand_hook_internal): Remove, unused.
8911 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8912 Vcommand_hook_internal.
8914 * eval.c (enum run_hooks_condition): Remove.
8915 (funcall_nil, funcall_not): New functions.
8916 (run_hook_with_args): Call each function through a `funcall' argument.
8917 Remove `cond' argument, now redundant.
8918 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8919 (Frun_hook_with_args_until_failure): Adjust accordingly.
8920 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8922 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8924 * dispextern.h (string_buffer_position): Remove declaration.
8926 * print.c (strout): Remove parameter `multibyte', unused since
8927 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8929 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8930 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8931 All callers changed.
8933 * w32.c (_wsa_errlist): Use braces for struct initializers.
8935 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8936 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8937 All callers changed.
8938 (string_buffer_position): Likewise. Also, make static (it's never
8939 used outside xdisp.c).
8940 (cursor_row_p): Remove parameter `w', unused since
8941 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8942 (decode_mode_spec): Remove parameter `precision', introduced during
8943 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8944 All callers changed.
8946 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8948 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8950 2011-03-27 Anders Lindgren <andlind@gmail.com>
8952 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8953 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8954 (ns_update_auto_hide_menu_bar): New functions.
8955 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8956 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8957 ns_constrain_all_frames.
8958 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8959 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8961 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8963 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8965 2011-03-27 Glenn Morris <rgm@gnu.org>
8967 * syssignal.h: Replace RETSIGTYPE with void.
8968 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8969 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8970 Replace SIGTYPE with void everywhere.
8971 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8972 * s/template.h (SIGTYPE): Remove commented out definition.
8974 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8976 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8977 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8979 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8981 * w32.c (read_unc_volume): Use parameter `henum', instead of
8982 global variable `wget_enum_handle'.
8984 * keymap.c (describe_vector): Remove parameters `indices' and
8985 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8986 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8988 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8990 * keyboard.c (timer_check): Remove parameter `do_it_now',
8991 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8992 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8993 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8995 * keyboard.c (read_char):
8996 * w32menu.c (w32_menu_display_help):
8997 * xmenu.c (show_help_event, menu_help_callback):
8998 Adjust calls to `show_help_echo'.
9000 * gtkutil.c (xg_maybe_add_timer):
9001 * keyboard.c (readable_events):
9002 * process.c (wait_reading_process_output):
9003 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9005 * insdel.c (adjust_markers_gap_motion):
9006 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9007 (gap_left, gap_right): Don't call it.
9009 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9011 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9012 incurred during fontification.
9014 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9016 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9017 (DEFVAR_PER_BUFFER): Don't pass it.
9019 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9020 (scrolling_window): Don't pass it.
9022 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9024 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9026 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9028 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9029 of variables specific to SELinux and computation of `encoded_absname'.
9031 * image.c (XPutPixel): Remove unused variable `height'.
9033 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9035 * unexw32.c (get_section_info): Remove unused variable `section'.
9037 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9038 (system_process_attributes): Remove unused variable `sess'.
9039 (sys_read): Remove unused variable `err'.
9041 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9042 (w32_wnd_proc): Remove unused variable `isdead'.
9043 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9044 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9045 (x_create_tip_frame): Remove unused variable `tem'.
9047 * w32inevt.c (w32_console_read_socket):
9048 Remove unused variable `no_events'.
9050 * w32term.c (x_draw_composite_glyph_string_foreground):
9051 Remove unused variable `width'.
9053 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9055 * w32term.c (x_set_glyph_string_clipping):
9056 Don't pass uninitialized region to CombineRgn.
9058 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9060 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9061 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9062 (Fx_close_connection): Remove unused variable `i'.
9064 * w32font.c (w32font_draw): Return number of glyphs.
9065 (w32font_open_internal): Remove unused variable `i'.
9066 (w32font_driver): Add missing initializer.
9068 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9069 (fill_in_menu): Remove unused variable `items_added'.
9071 * w32term.c (last_mouse_press_frame): Remove static global variable.
9072 (w32_clip_to_row): Remove unused variable `f'.
9073 (x_delete_terminal): Remove unused variable `i'.
9075 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9076 (NOTHING): Remove unused static global variable.
9077 (uniscribe_check_otf): Remove unused variable `table'.
9078 (uniscribe_font_driver): Add missing initializers.
9080 2011-03-23 Julien Danjou <julien@danjou.info>
9082 * term.c (Fsuspend_tty, Fresume_tty):
9083 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9084 * window.c (temp_output_buffer_show):
9085 * insdel.c (signal_before_change):
9086 * frame.c (Fhandle_switch_frame):
9087 * fileio.c (Fdo_auto_save):
9088 * emacs.c (Fkill_emacs):
9089 * editfns.c (save_excursion_restore):
9090 * cmds.c (internal_self_insert):
9091 * callint.c (Fcall_interactively):
9092 * buffer.c (Fkill_all_local_variables):
9093 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9095 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9096 unconditionally since it does the check itself.
9098 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9100 Fix more problems found by GCC 4.5.2's static checks.
9102 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9103 the first time through the loop, since we know p0 < p1 then.
9104 This also avoids a gcc -Wstrict-overflow warning.
9106 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9107 leading to a memory leak, possible in functions like
9108 load_charset_map_from_file that can allocate an unbounded number
9109 of objects (Bug#8318).
9111 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9112 that could (at least in theory) be that large.
9114 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9115 This is less likely to overflow, and avoids undefined behavior if
9116 overflow does occur. All callers changed. Use strtoul to scan
9117 for the unsigned long integer.
9118 (pint2hrstr): Simplify and tune code slightly.
9119 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9121 * scroll.c (do_scrolling): Work around GCC bug 48228.
9122 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9124 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9125 This also avoids a warning with gcc -Wstrict-overflow.
9126 (validate_x_resource_name): Simplify count usage.
9127 This also avoids a warning with gcc -Wstrict-overflow.
9129 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9132 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9134 * process.c (Fmake_network_process): Use socklen_t, not int,
9135 where POSIX says socklen_t is required in portable programs.
9136 This fixes a porting bug on hosts like 64-bit HP-UX, where
9137 socklen_t is wider than int (Bug#8277).
9138 (Fmake_network_process, server_accept_connection):
9139 (wait_reading_process_output, read_process_output):
9142 * process.c: Rename or move locals to avoid shadowing.
9143 (list_processes_1, Fmake_network_process):
9144 (read_process_output_error_handler, exec_sentinel_error_handler):
9145 Rename or move locals.
9146 (Fmake_network_process): Define label "retry_connect" only if needed.
9147 (Fnetwork_interface_info): Fix pointer signedness.
9148 (process_send_signal): Add cast to avoid pointer signedness problem.
9149 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9150 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9152 Make tparam.h and terminfo.c consistent.
9153 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9154 Include tparam.h instead, since it declares them.
9155 * cm.h (PC): Remove extern decl; tparam.h now does this.
9156 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9157 * terminfo.c: Include tparam.h, to check interfaces.
9158 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9159 (tparam): Adjust signature to match interface in tparam.h;
9160 this removes some undefined behavior. Check that outstring and len
9161 are zero, which they always are with Emacs.
9162 * tparam.h (PC, BC, UP): New extern decls.
9164 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9165 (xftfont_open): Rename locals to avoid shadowing.
9167 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9168 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9169 (OTF_TAG_SYM): Omit macro if not needed.
9170 (ftfont_list): Remove unused local.
9171 (get_adstyle_property, ftfont_pattern_entity):
9172 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9173 Rename locals to avoid shadowing.
9175 * xfont.c (xfont_list_family): Mark var as initialized.
9177 * xml.c (make_dom): Now static.
9179 * composite.c (composition_compute_stop_pos): Rename local to
9181 (composition_reseat_it): Remove unused locals.
9182 (find_automatic_composition, composition_adjust_point): Likewise.
9183 (composition_update_it): Mark var as initialized.
9184 (find_automatic_composition): Mark vars as initialized,
9185 with a FIXME (Bug#8290).
9187 character.h: Rename locals to avoid shadowing.
9188 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9189 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9190 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9191 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9194 * textprop.c (property_change_between_p): Remove; unused.
9196 * intervals.c (interval_start_pos): Now static.
9198 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9200 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9201 Rename locals to avoid shadowing.
9203 * sound.c (wav_play, au_play, Fplay_sound_internal):
9204 Fix pointer signedness.
9205 (alsa_choose_format): Remove unused local var.
9206 (wav_play): Initialize a variable to 0, to prevent undefined
9207 behavior (Bug#8278).
9209 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9211 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9213 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9214 clobbering (Bug#8298).
9215 * sysdep.c (sys_subshell): Likewise.
9216 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9218 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9219 This should get cleaned up, so that child_setup has the
9220 same signature on all platforms.
9222 * callproc.c (call_process_cleanup): Now static.
9223 (relocate_fd): Rename locals to avoid shadowing.
9225 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9227 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9228 not to be necessary, and produces flickering.
9230 2011-03-20 Glenn Morris <rgm@gnu.org>
9232 * config.in: Remove file.
9234 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9236 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9237 are now in src/globals.h.
9238 (syms_of_minibuf): Remove spurious & from previous change.
9240 2011-03-20 Leo Liu <sdl.web@gmail.com>
9242 * minibuf.c (completing-read-function): New variable.
9243 (completing-read-default): Rename from completing-read.
9244 (completing-read): Call completing-read-function.
9246 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9248 * xfaces.c (Fx_load_color_file):
9249 Read color file from absolute filename (bug#8250).
9251 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9253 * makefile.w32-in: Update dependencies.
9255 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9257 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9259 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9261 Fix more problems found by GCC 4.5.2's static checks.
9263 * process.c (make_serial_process_unwind, send_process_trap):
9264 (sigchld_handler): Now static.
9266 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9267 That way, the code declares only the vars that it needs.
9268 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9269 * s/cygwin.h (PTY_ITERATION): Likewise.
9270 * s/darwin.h (PTY_ITERATION): Likewise.
9271 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9273 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9274 * process.c (allocate_pty): Don't declare stb unless it's needed.
9276 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9277 (CONSTANTLIM): Remove; unused.
9278 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9279 Define only if needed.
9281 * unexelf.c (unexec): Name an expression,
9282 to avoid gcc -Wbad-function-cast warning.
9283 Use a different way to cause a compilation error if anyone uses
9284 n rather than nn, a way that does not involve shadowing.
9285 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9287 * deps.mk (unexalpha.o): Remove; unused.
9289 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9290 * unexec.h: New file.
9291 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9292 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9294 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9295 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9296 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9297 Change as necessary to match prototype in unexec.h.
9299 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9301 (back_comment, skip_chars): Mark vars as initialized.
9303 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9304 Rename locals to avoid shadowing.
9306 * lread.c (read1): Rewrite so as not to use empty "else".
9307 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9309 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9311 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9312 warning when compiling print.c.
9314 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9315 instead of using an uninitialized var.
9316 (font_sort_entities): Mark var as initialized.
9318 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9320 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9321 pointers to constants.
9322 (font_parse_fcname): Remove unused vars.
9323 (font_delete_unmatched): Now static.
9324 (font_get_spec): Remove; unused.
9325 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9326 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9327 Rename or move locals to avoid shadowing.
9329 * fns.c (require_nesting_list, require_unwind): Now static.
9330 (Ffillarray): Rename locals to avoid shadowing.
9332 * floatfns.c (domain_error2): Define only if needed.
9333 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9335 * alloc.c (mark_backtrace): Move decl from here ...
9336 * lisp.h: ... to here, so that it can be checked.
9338 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9339 (Fdefvar): Rewrite so as not to use empty "else".
9340 (lisp_indirect_variable): Name an expression,
9341 to avoid gcc -Wbad-function-cast warning.
9342 (Fdefvar): Rename locals to avoid shadowing.
9344 * callint.c (quotify_arg, quotify_args): Now static.
9345 (Fcall_interactively): Rename locals to avoid shadowing.
9346 Use const pointer when appropriate.
9348 * lisp.h (get_system_name, get_operating_system_release):
9349 Move decls here, to check interfaces.
9350 * process.c (get_operating_system_release): Move decl to lisp.h.
9351 * xrdb.c (get_system_name): Likewise.
9352 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9353 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9354 some of which prompt warnings from gcc -Wbad-function-cast.
9355 (Fformat_time_string, Fencode_time, Finsert_char):
9356 (Ftranslate_region_internal, Fformat):
9357 Rename or remove local vars to avoid shadowing.
9358 (Ftranslate_region_internal): Mark var as initialized.
9360 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9363 * lisp.h (eassert): Check that the argument compiles, even if
9364 ENABLE_CHECKING is not defined.
9366 * data.c (Findirect_variable): Name an expression, to avoid
9367 gcc -Wbad-function-cast warning.
9368 (default_value, arithcompare, arith_driver, arith_error): Now static.
9369 (store_symval_forwarding): Rename local to avoid shadowing.
9370 (Fmake_variable_buffer_local, Fmake_local_variable):
9371 Mark variables as initialized.
9372 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9374 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9375 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9376 Rename locals to avoid shadowing.
9377 (mark_stack): Move local variables into the #ifdef region where
9379 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9380 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9382 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9383 (GC_STRING_CHARS): Remove; not used.
9384 (Fmemory_limit): Cast sbrk's returned value to char *.
9386 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9387 avoids undefined behavior in theory.
9389 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9391 Use functions, not macros, for up- and down-casing (Bug#8254).
9392 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9393 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9394 to use the following functions instead of these macros.
9395 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9396 EMACS_INT, since callers assume the returned value fits in int.
9397 (upcase1): Likewise, for UPCASE_TABLE.
9398 (uppercasep, lowercasep, upcase): New static inline functions.
9399 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9400 the race-condition problem in the old DOWNCASE.
9402 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9403 Rename locals to avoid shadowing.
9404 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9405 (regex_compile, re_search_2, re_match_2_internal):
9406 Remove unused local vars.
9407 (FREE_VAR): Rewrite so as not to use empty "else",
9408 which gcc can warn about.
9409 (regex_compile, re_match_2_internal): Mark locals as initialized.
9410 (RETALLOC_IF): Define only if needed.
9411 (WORDCHAR_P): Likewise. This one is never needed, but is used
9412 only in a comment talking about a compiler bug, so put inside
9413 the #if 0 of that comment.
9414 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9415 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9418 * search.c (boyer_moore): Rename locals to avoid shadowing.
9419 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9420 (PREV_CHAR_BOUNDARY): Likewise.
9422 * search.c (simple_search): Remove unused var.
9424 * dired.c (compile_pattern): Move decl from here ...
9425 * lisp.h: ... to here, so that it can be checked.
9426 (struct re_registers): New forward decl.
9428 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9430 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9432 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9433 Rename locals to avoid shadowing.
9434 (Fvertical_motion): Mark locals as initialized.
9436 * casefiddle.c (casify_object, casify_region): Now static.
9437 (casify_region): Mark local as initialized.
9439 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9441 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9442 New macros, so that the caller can use some names other than
9443 gcpro1, gcpro2, etc.
9444 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9446 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9447 argument, for consistency with GCPRO2_VAR, etc: it is now the
9448 prefix of the variable, not the variable itself. All uses
9450 * dired.c (directory_files_internal, file_name_completion):
9451 Rename locals to avoid shadowing.
9453 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9454 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9455 dired.c's scmp function, had undefined behavior.
9456 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9457 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9458 * buffer.h: ... to here, because these macros use current_buffer,
9459 and the new implementation with inline functions needs to have
9460 current_buffer in scope now, rather than later when the macros
9462 (downcase, upcase1): New static inline functions.
9463 (DOWNCASE, UPCASE1): Reimplement using these functions.
9464 This avoids undefined behavior in expressions like
9465 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9466 from race conditions in accessing the global variables
9467 case_temp1 and case_temp2.
9468 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9469 * lisp.h (case_temp1, case_temp2): Remove their decls.
9470 * character.h (ASCII_CHAR_P): Move from here ...
9471 * lisp.h: ... to here, so that the inline functions mentioned
9474 * dired.c (directory_files_internal_unwind): Now static.
9476 * fileio.c (file_name_as_directory, directory_file_name):
9477 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9479 (file_name_as_directory): Use const pointers when appropriate.
9480 (Fexpand_file_name): Likewise. In particular, newdir might
9481 point at constant storage, so make it a const pointer.
9482 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9483 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9485 (Fset_file_times, Finsert_file_contents, auto_save_error):
9486 Rename locals to avoid shadowing.
9488 * minibuf.c (choose_minibuf_frame_1): Now static.
9489 (Ftry_completion, Fall_completions): Rename or remove locals
9492 * marker.c (bytepos_to_charpos): Remove; unused.
9494 * lisp.h (verify_bytepos, count_markers): New decls,
9495 so that gcc does not warn that these functions aren't declared.
9497 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9498 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9499 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9500 (copy_text): Remove unused local var.
9502 * filelock.c (within_one_second): Now static.
9503 (lock_file_1): Rename local to avoid shadowing.
9505 * buffer.c (fix_overlays_before): Mark locals as initialized.
9506 (fix_start_end_in_overlays): Likewise. This function should be
9507 simplified by using pointers-to-pointers, but that's a different
9509 (switch_to_buffer_1): Now static.
9510 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9511 (report_overlay_modification): Rename locals to avoid shadowing.
9513 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9514 Fix pointer signedness issue.
9515 (sys_subshell): Mark local as volatile if checking for lint,
9516 to suppress a gcc -Wclobbered warning that does not seem to be right.
9517 (MAXPATHLEN): Define only if needed.
9519 * process.c (serial_open, serial_configure): Move decls from here ...
9520 * systty.h: ... to here, so that they can be checked.
9522 * fns.c (get_random, seed_random): Move extern decls from here ...
9523 * lisp.h: ... to here, so that they can be checked.
9525 * sysdep.c (reset_io): Now static.
9526 (wait_for_termination_signal): Remove; unused.
9528 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9529 (copy_keymap_item, append_key, push_text_char_description):
9531 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9532 (DENSE_TABLE_SIZE): Remove; unused.
9533 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9534 (describe_map_tree):
9535 Rename locals to avoid shadowing.
9537 * keyboard.c: Declare functions static if they are not used elsewhere.
9538 (echo_char, echo_dash, cmd_error, top_level_2):
9539 (poll_for_input, handle_async_input): Now static.
9540 (read_char, kbd_buffer_get_event, make_lispy_position):
9541 (make_lispy_event, make_lispy_movement, apply_modifiers):
9542 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9543 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9544 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9545 (read_key_sequence, read_char): Mark locals as initialized.
9546 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9548 * keyboard.h (make_ctrl_char): New decl.
9549 (mark_kboards): Move decl here ...
9550 * alloc.c (mark_kboards): ... from here.
9552 * lisp.h (force_auto_save_soon): New decl.
9554 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9555 (DEFINE_DUMMY_FUNCTION): New macro.
9556 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9558 (main): Add casts to avoid warnings
9559 if GCC considers string literals to be constants.
9561 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9563 * dbusbind.c: Pointer signedness fixes.
9564 (xd_signature, xd_append_arg, xd_initialize):
9565 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9566 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9567 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9568 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9570 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9571 if GCC considers string literals to be constants.
9572 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9574 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9576 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9577 (print_preprocess, print_object): New macro to fix last change.
9579 * print.c (print_preprocess): Don't forget font objects.
9581 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9583 * emacs.c (USAGE3): Doc fixes.
9585 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9587 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9590 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9592 * lisp.h (VWindow_system, Qfile_name_history):
9593 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9594 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9595 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9597 * w32select.c: Don't #include "keyboard.h".
9598 (run_protected): Add extern declaration for waiting_for_input.
9600 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9601 * w32console.c (detect_input_pending, read_input_pending)
9602 (encode_terminal_code):
9603 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9604 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9605 (w32_system_caret_y, Qfile_name_history):
9606 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9607 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9608 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9609 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9610 * w32proc.c (Qlocal, report_file_error):
9611 * w32term.c (Vwindow_system, updating_frame):
9612 * w32uniscribe.c (initialized, uniscribe_font_driver):
9613 Remove unneeded extern declarations.
9615 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9617 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9619 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9621 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9622 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9623 These macros can no longer be used for assignment.
9625 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9626 Assign struct members directly, instead of using BUF_BEGV etc.
9627 (record_buffer_markers, fetch_buffer_markers): New functions for
9628 recording and fetching special buffer markers.
9629 (set_buffer_internal_1, set_buffer_temp): Use them.
9631 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9633 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9635 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9636 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9638 * xdisp.c (hscroll_window_tree):
9639 (reconsider_clip_changes): Use PT instead of BUF_PT.
9641 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9643 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9644 $(EMACS_ROOT)/lib/intprops.h.
9646 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9648 Fix more problems found by GCC 4.5.2's static checks.
9650 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9651 to unsigned char * to avoid compiler diagnostic.
9652 (xg_free_frame_widgets): Make it clear that a local variable is
9653 needed only if USE_GTK_TOOLTIP.
9654 (gdk_window_get_screen): Make it clear that this macro is needed
9655 only if USE_GTK_TOOLTIP.
9656 (int_gtk_range_get_value): New function, which avoids a diagnostic
9657 from gcc -Wbad-function-cast.
9658 (xg_set_toolkit_scroll_bar_thumb): Use it.
9659 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9660 diagnostic from gcc -Wbad-function-cast.
9661 (get_utf8_string, xg_get_file_with_chooser):
9662 Rename locals to avoid shadowing.
9663 (create_dialog): Move locals to avoid shadowing.
9665 * xgselect.c (xg_select): Remove unused var.
9667 * image.c (four_corners_best): Mark locals as initialized.
9668 (gif_load): Initialize transparent_p to zero (Bug#8238).
9669 Mark another local as initialized.
9670 (my_png_error, my_error_exit): Mark with NO_RETURN.
9672 * image.c (clear_image_cache): Now static.
9673 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9674 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9675 (x_edge_detection): Remove unnecessary cast that
9676 gcc -Wbad-function-cast diagnoses.
9677 (gif_load): Fix pointer signedness.
9678 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9679 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9681 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9683 Improve quality of tests for time stamp overflow.
9684 For example, without this patch (encode-time 0 0 0 1 1
9685 1152921504606846976) returns the obviously-bogus value (-948597
9686 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9687 reports time overflow. See
9688 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9689 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9690 * editfns.c: Include limits.h and intprops.h.
9691 (TIME_T_MIN, TIME_T_MAX): New macros.
9692 (time_overflow): Move earlier, to before first use.
9693 (hi_time, lo_time): New functions, for an accurate test for
9695 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9696 (Fget_internal_run_time): Don't assume time_t fits in int.
9697 (make_time): Use list2 instead of Fcons twice.
9698 (Fdecode_time): More accurate test for out-of-range times.
9699 (check_tm_member): New function.
9700 (Fencode_time): Use it, to test for out-of-range times.
9701 (lisp_time_argument): Don't rely on undefined left-shift and
9702 right-shift behavior when checking for time stamp overflow.
9704 * editfns.c (time_overflow): New function, refactoring common code.
9705 (Fformat_time_string, Fdecode_time, Fencode_time):
9706 (Fcurrent_time_string): Use it.
9708 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9709 * dired.c (make_time): Move to ...
9710 * editfns.c (make_time): ... here.
9711 * systime.h: Note the move.
9713 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9715 * fringe.c (update_window_fringes): Remove unused variables.
9717 * unexmacosx.c (copy_data_segment): Also copy __got section.
9720 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9722 * termcap.c [MSDOS]: Include "msdos.h".
9723 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9724 Constify `char *' arguments and their references according to
9725 prototypes in tparam.h.
9727 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9729 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9730 Adapt all references accordingly.
9732 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9734 2011-03-11 Tom Tromey <tromey@redhat.com>
9736 * buffer.c (syms_of_buffer): Remove obsolete comment.
9738 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9740 * termhooks.h (encode_terminal_code): Declare prototype.
9742 * msdos.c (encode_terminal_code): Don't declare prototype.
9744 * term.c (encode_terminal_code): Now external again, used by
9745 w32console.c and msdos.c.
9747 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9748 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9750 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9752 Fix some minor problems found by GCC 4.5.2's static checks.
9754 * fringe.c (update_window_fringes): Mark locals as initialized
9756 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9758 * alloc.c (mark_fringe_data): Move decl from here ...
9759 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9760 to check its interface.
9761 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9763 * fontset.c (free_realized_fontset): Now static.
9764 (Fset_fontset_font): Rename local to avoid shadowing.
9765 (fontset_font): Mark local as initialized.
9766 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9768 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9770 * xselect.c (x_disown_buffer_selections): Remove; not used.
9771 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9772 (x_own_selection, Fx_disown_selection_internal): Rename locals
9774 (x_handle_dnd_message): Remove local to avoid shadowing.
9776 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9777 so that the caller can use some name other than gcpro1.
9778 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9779 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9780 (Fx_backspace_delete_keys_p):
9781 Use them to avoid shadowing, and rename vars to avoid shadowing.
9782 (x_decode_color, x_set_name, x_window): Now static.
9783 (Fx_create_frame): Add braces to silence GCC warning.
9784 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9785 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9786 Remove unused locals.
9787 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9788 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9789 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9792 * xterm.h (x_mouse_leave): New decl.
9794 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9795 Remove unused functions.
9796 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9797 (x_calc_absolute_position): Now static.
9798 (XTread_socket): Don't define label "out" unless it's used.
9799 Don't declare local "event" unless it's used.
9800 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9801 unless they are used.
9802 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9803 (x_fatal_error_signal): Remove; not used.
9804 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9805 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9806 (x_error_catcher, x_connection_closed, x_error_handler):
9807 (x_error_quitter, xembed_send_message, x_iconify_frame):
9808 (my_log_handler): Rename locals to avoid shadowing.
9809 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9810 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9812 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9813 Rename or move locals to avoid shadowing.
9814 (tty_defined_color, merge_face_heights): Now static.
9815 (free_realized_faces_for_fontset): Remove; not used.
9816 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9817 does not deduce is never used uninitialized.
9818 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9819 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9821 * terminal.c (store_terminal_param): Now static.
9823 * xmenu.c (menu_highlight_callback): Now static.
9824 (set_frame_menubar): Remove unused local.
9825 (xmenu_show): Rename parameter to avoid shadowing.
9826 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9827 since they might point to immutable storage.
9828 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9829 since it's unused otherwise.
9831 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9832 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9833 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9834 avoids a gcc -Wuninitialized diagnostic.
9835 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9836 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9837 does not deduce are never used uninitialized.
9839 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9841 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9842 * window.c (window_loop, size_window):
9843 (run_window_configuration_change_hook, enlarge_window): Likewise.
9845 * window.c (display_buffer): Now static.
9846 (size_window): Mark variables that gcc -Wuninitialized
9847 does not deduce are never used uninitialized.
9848 * window.h (check_all_windows): New decl, to forestall
9849 gcc -Wmissing-prototypes diagnostic.
9850 * dispextern.h (bidi_dump_cached_states): Likewise.
9852 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9854 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9856 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9857 and to avoid gcc -Wuninitialized warning.
9858 (load_charset_map): Mark variables that gcc -Wuninitialized
9859 does not deduce are never used uninitialized.
9860 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9862 * coding.c (coding_set_source, coding_set_destination):
9863 Use "else { /* comment */ }" rather than "else /* comment */;"
9864 for clarity, and to avoid gcc -Wempty-body warning.
9865 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9866 a block, when the outer 'i' will do.
9867 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9868 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9869 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9870 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9871 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9872 Rename locals to avoid shadowing.
9873 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9874 * coding.c (emacs_mule_char, encode_invocation_designation):
9875 Now static, since they're not used elsewhere.
9876 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9877 (decode_coding_object, encode_coding_object, detect_coding_system):
9878 (decode_coding_emacs_mule): Mark variables that gcc
9879 -Wuninitialized does not deduce are never used uninitialized.
9880 (detect_coding_iso_2022): Initialize a local variable that might
9881 be used uninitialized. Leave a FIXME because it's not clear that
9882 this initialization is needed. (Bug#8211)
9883 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9884 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9885 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9886 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9887 Remove unused macros.
9889 * category.c (hash_get_category_set): Remove unused local var.
9890 (copy_category_table): Now static, since it's not used elsewhere.
9891 * character.c (string_count_byte8): Likewise.
9893 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9894 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9896 * chartab.c (copy_sub_char_table): Now static, since it's not used
9898 (sub_char_table_ref_and_range, char_table_ref_and_range):
9899 Rename locals to avoid shadowing.
9900 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9902 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9903 (BIDI_BOB): Remove unused macro.
9905 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9906 deduce are never used uninitialized.
9907 * term.c (encode_terminal_code): Likewise.
9909 * term.c (encode_terminal_code): Now static. Remove unused local.
9911 * tparam.h: New file.
9912 * term.c, tparam.h: Include it.
9913 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9914 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9915 Move these decls to tparam.h, and make them agree with what
9916 is actually in tparam.c. The previous trick of using incompatible
9917 decls in different modules does not conform to the C standard.
9918 All callers of tparam changed to use tparam's actual API.
9919 * tparam.c (tparam1, tparam, tgoto):
9920 Use const pointers where appropriate.
9922 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9923 * cm.h (struct cm): Likewise.
9924 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9925 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9926 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9927 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9928 (turn_on_face, init_tty): Likewise.
9929 * termchar.h (struct tty_display_info): Likewise.
9931 * term.c (term_mouse_position): Rename local to avoid shadowing.
9933 * alloc.c (mark_ttys): Move decl from here ...
9934 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9936 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9938 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9940 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9942 * search.c (compile_pattern_1): Remove argument regp, unused since
9943 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9944 (compile_pattern): Don't pass it.
9946 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9948 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9949 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9951 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9953 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9955 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9956 gdk_window_get_screen, gdk_window_get_geometry,
9957 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9958 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9959 (xg_get_pixbuf_from_pixmap): New function.
9960 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9961 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9962 Call xg_get_pixbuf_from_pixmap instead of
9963 gdk_pixbuf_get_from_drawable.
9964 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9965 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9966 (xg_check_special_colors): Use GtkStyleContext and its functions
9968 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9969 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9970 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9971 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9972 Call gtk_widget_get_preferred_size.
9973 (xg_frame_resized): gdk_window_get_geometry only takes 5
9975 (xg_win_to_widget, xg_event_is_for_menubar):
9976 Call gdk_x11_window_lookup_for_display.
9977 (xg_set_widget_bg): New function.
9978 (delete_cb): New function.
9979 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9980 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9981 (xg_set_background_color): Call xg_set_widget_bg.
9982 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9983 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9984 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9985 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9987 (update_frame_tool_bar): Call gtk_widget_hide.
9988 (xg_initialize): Use GDK_KEY_g.
9990 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9992 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9994 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9995 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9996 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9998 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10000 * w32xfns.c (select_palette): Check success of RealizePalette against
10001 GDI_ERROR, not zero.
10003 See ChangeLog.11 for earlier changes.
10005 ;; Local Variables:
10009 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10011 This file is part of GNU Emacs.
10013 GNU Emacs is free software: you can redistribute it and/or modify
10014 it under the terms of the GNU General Public License as published by
10015 the Free Software Foundation, either version 3 of the License, or
10016 (at your option) any later version.
10018 GNU Emacs is distributed in the hope that it will be useful,
10019 but WITHOUT ANY WARRANTY; without even the implied warranty of
10020 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10021 GNU General Public License for more details.
10023 You should have received a copy of the GNU General Public License
10024 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.