Avoid bidi-related crashes in Cperl Mode.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2
3 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5 called at ZV.
6
7 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8
9 * process.c (wait_reading_process_output): Bypass select if
10 waiting for a cell while ignoring keyboard input, and input is
11 pending. Suggested by Jan Djärv (Bug#8869).
12
13 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
14
15 Use gnulib's dup2 module instead of rolling our own.
16 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
17
18 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
19
20 * dispnew.c (scrolling_window): Before scrolling, turn off a
21 mouse-highlight in the window being scrolled.
22
23 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
24
25 Move DEFSYM to lisp.h and use everywhere.
26
27 * character.h (DEFSYM): Move declaration...
28 * lisp.h (DEFSYM): ...here.
29
30 * gnutls.c:
31 * minibuf.c:
32 * w32menu.c:
33 * w32proc.c:
34 * w32select.c: Don't include character.h.
35
36 * alloc.c (syms_of_alloc):
37 * buffer.c (syms_of_buffer):
38 * bytecode.c (syms_of_bytecode):
39 * callint.c (syms_of_callint):
40 * casefiddle.c (syms_of_casefiddle):
41 * casetab.c (init_casetab_once):
42 * category.c (init_category_once, syms_of_category):
43 * ccl.c (syms_of_ccl):
44 * cmds.c (syms_of_cmds):
45 * composite.c (syms_of_composite):
46 * dbusbind.c (syms_of_dbusbind):
47 * dired.c (syms_of_dired):
48 * dispnew.c (syms_of_display):
49 * doc.c (syms_of_doc):
50 * editfns.c (syms_of_editfns):
51 * emacs.c (syms_of_emacs):
52 * eval.c (syms_of_eval):
53 * fileio.c (syms_of_fileio):
54 * fns.c (syms_of_fns):
55 * frame.c (syms_of_frame):
56 * fringe.c (syms_of_fringe):
57 * insdel.c (syms_of_insdel):
58 * keymap.c (syms_of_keymap):
59 * lread.c (init_obarray, syms_of_lread):
60 * macros.c (syms_of_macros):
61 * msdos.c (syms_of_msdos):
62 * print.c (syms_of_print):
63 * process.c (syms_of_process):
64 * search.c (syms_of_search):
65 * sound.c (syms_of_sound):
66 * syntax.c (init_syntax_once, syms_of_syntax):
67 * terminal.c (syms_of_terminal):
68 * textprop.c (syms_of_textprop):
69 * undo.c (syms_of_undo):
70 * w32.c (globals_of_w32):
71 * window.c (syms_of_window):
72 * xdisp.c (syms_of_xdisp):
73 * xfaces.c (syms_of_xfaces):
74 * xfns.c (syms_of_xfns):
75 * xmenu.c (syms_of_xmenu):
76 * xsettings.c (syms_of_xsettings):
77 * xterm.c (syms_of_xterm): Use DEFSYM.
78
79 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
80
81 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
82
83 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
84
85 Integer and buffer overflow fixes (Bug#8873).
86
87 * print.c (printchar, strout): Check for string overflow.
88 (PRINTPREPARE, printchar, strout):
89 Don't set size unless allocation succeeds.
90
91 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
92 for sizes. Check for string overflow more accurately.
93 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
94
95 * macros.c: Integer and buffer overflow fixes.
96 * keyboard.h (struct keyboard.kbd_macro_bufsize):
97 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
98 Use ptrdiff_t, not int, for sizes.
99 Don't increment bufsize until after realloc succeeds.
100 Check for size-calculation overflow.
101 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
102
103 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
104
105 * lread.c: Integer overflow fixes.
106 (read_integer): Radix is now EMACS_INT, not int,
107 to improve quality of diagnostics for out-of-range radices.
108 Calculate buffer size correctly for out-of-range radices.
109 (read1): Check for integer overflow in radices, and in
110 read-circle numbers.
111 (read_escape): Avoid int overflow.
112 (Fload, openp, read_buffer_size, read1)
113 (substitute_object_recurse, read_vector, read_list, map_obarray):
114 Use ptrdiff_t, not int, for sizes.
115 (read1): Use EMACS_INT, not int, for sizes.
116 Check for size overflow.
117
118 * image.c (cache_image): Check for size arithmetic overflow.
119
120 * lread.c: Integer overflow issues.
121 (saved_doc_string_size, saved_doc_string_length)
122 (prev_saved_doc_string_size, prev_saved_doc_string_length):
123 Now ptrdiff_t, not int.
124 (read1): Don't assume doc string length fits in int. Check for
125 out-of-range doc string lengths.
126 (read_list): Don't assume file position fits in int.
127 (read_escape): Check for hex character overflow.
128
129 2011-06-22 Leo Liu <sdl.web@gmail.com>
130
131 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
132 Move to minibuffer.el.
133
134 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
135
136 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
137 The following patches are for when GLYPH_DEBUG && !XASSERT.
138 * dispextern.h (trace_redisplay_p, dump_glyph_string):
139 * dispnew.c (flush_stdout):
140 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
141 Mark as externally visible.
142 * dispnew.c (check_window_matrix_pointers): Now static.
143 * dispnew.c (window_to_frame_vpos):
144 * xfns.c (unwind_create_frame):
145 * xterm.c (x_check_font): Remove unused local.
146 * scroll.c (CHECK_BOUNDS):
147 * xfaces.c (cache_fache): Rename local to avoid shadowing.
148 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
149 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
150 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
151 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
152 Now static.
153 (debug_method_add): Use va_list and vsprintf rather than relying
154 on undefined behavior with wrong number of arguments.
155 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
156 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
157 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
158 since we're not interested in debugging glyphs with old libraries.
159 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
160 GCC 4.6.0's static checking.
161
162 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
163
164 Integer overflow and signedness fixes (Bug#8873).
165 A few related buffer overrun fixes, too.
166
167 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
168
169 * dispextern.h (struct face.stipple):
170 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
171 (x_bitmap_mask, x_allocate_bitmap_record)
172 (x_create_bitmap_from_data, x_create_bitmap_from_file)
173 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
174 (x_create_bitmap_from_xpm_data):
175 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
176 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
177 (.bitmaps_last):
178 * xfaces.c (load_pixmap):
179 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
180 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
181 (.bitmaps_last, struct x_output.icon_bitmap):
182 Use ptrdiff_t, not int, for bitmap indexes.
183 (x_allocate_bitmap_record): Check for size overflow.
184 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
185
186 Use ptrdiff_t, not int, for overlay counts.
187 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
188 * editfns.c (overlays_around, get_pos_property):
189 * textprop.c (get_char_property_and_overlay):
190 * xdisp.c (next_overlay_change, note_mouse_highlight):
191 * xfaces.c (face_at_buffer_position):
192 * buffer.c (OVERLAY_COUNT_MAX): New macro.
193 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
194 (Fnext_overlay_change, Fprevious_overlay_change)
195 (mouse_face_overlay_overlaps, Foverlays_in):
196 Use ptrdiff_t, not int, for sizes.
197 (overlays_at, overlays_in): Check for size-calculation overflow.
198
199 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
200
201 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
202 (x_session_initialize): Do not assume string length fits in int.
203
204 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
205 This is unlikely, but can occur if DPI is outlandish.
206
207 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
208 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
209
210 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
211 * xrdb.c (magic_file_p, search_magic_path):
212 Omit last arg SUFFIX; it was always 0. All callers changed.
213 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
214
215 * xfont.c (xfont_match): Avoid need for strlen.
216
217 * xfns.c: Don't assume strlen fits in int.
218 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
219
220 * xdisp.c (message_log_check_duplicate): Return intmax_t,
221 not unsigned long, as we prefer signed integers. All callers changed.
222 Detect integer overflow in repeat count.
223 (message_dolog): Don't assume print length fits in 39 bytes.
224 (display_mode_element): Don't assume strlen fits in int.
225
226 * termcap.c: Don't assume sizes fit in int and never overflow.
227 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
228 (gobble_line): Check for size-calculation overflow.
229
230 * minibuf.c (Fread_buffer):
231 * lread.c (intern, intern_c_string):
232 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
233 Don't assume string length fits in int.
234
235 * keyboard.c (parse_tool_bar_item):
236 * gtkutil.c (style_changed_cb): Avoid need for strlen.
237
238 * font.c: Don't assume string length fits in int.
239 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
240 Use ptrdiff_t, not int.
241 (font_intern_prop): Don't assume string length fits in int.
242 Don't assume integer property fits in fixnum.
243 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
244
245 * filelock.c: Fix some buffer overrun and integer overflow issues.
246 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
247 Reformulate so as not to need the command string.
248 Invoke gzip -cd rather than gunzip, as it's more portable.
249 (lock_info_type, lock_file_1, lock_file):
250 Don't assume pid_t and time_t fit in unsigned long.
251 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
252 (current_lock_owner): Prefer signed type for sizes.
253 Use memcpy, not strncpy, where memcpy is what is really wanted.
254 Don't assume (via atoi) that time_t and pid_t fit in int.
255 Check for time_t and/or pid_t out of range, e.g., via a network share.
256 Don't alloca where an auto var works fine.
257
258 * fileio.c: Fix some integer overflow issues.
259 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
260 Don't assume string length fits in int.
261 (directory_file_name): Don't assume string length fits in long.
262 (make_temp_name): Don't assume pid fits in int, or that its print
263 length is less than 20.
264
265 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
266
267 * coding.c (make_subsidiaries): Don't assume string length fits in int.
268
269 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
270
271 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
272 We prefer signed integers, even for size calculations.
273
274 * emacs.c: Don't assume string length fits in 'int'.
275 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
276 (main): Don't invoke strlen when not needed.
277
278 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
279 (XD_DEBUG_MESSAGE): Don't waste a byte.
280
281 * callproc.c (getenv_internal_1, getenv_internal)
282 (Fgetenv_internal):
283 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
284
285 * lread.c (invalid_syntax): Omit length argument.
286 All uses changed. This doesn't fix a bug, but it simplifies the
287 code away from its former Hollerith-constant appearance, and it's
288 one less 'int' to worry about when looking at integer-overflow issues.
289 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
290
291 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
292 This didn't break anything, but it didn't help either.
293 It's confusing to put a bogus integer in a place where the actual
294 value does not matter.
295 (LIST_END_P): Remove unused macro and its bogus comment.
296 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
297
298 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
299 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
300 implementation.
301 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
302 We prefer signed types, and the value cannot exceed the EMACS_INT
303 range anyway (because otherwise the length would not be representable).
304 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
305 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
306 This avoids a GCC warning when WIDE_EMACS_INT.
307
308 * indent.c (sane_tab_width): New function.
309 (current_column, scan_for_column, Findent_to, position_indentation)
310 (compute_motion): Use it. This is just for clarity.
311 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
312
313 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
314
315 * lisp.h (lint_assume): New macro.
316 * composite.c (composition_gstring_put_cache):
317 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
318
319 * editfns.c, insdel.c:
320 Omit unnecessary forward decls, to simplify future changes.
321
322 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
323
324 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
325
326 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
327 Use much-faster test for byte-length change.
328 Don't assume string byte-length fits in 'int'.
329 Check that character arg fits in 'int'.
330 (mapcar1): Declare byte as byte, for clarity.
331
332 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
333
334 * fns.c (concat): Catch string overflow earlier.
335 Do not rely on integer wraparound.
336
337 * dispextern.h (struct it.overlay_strings_charpos)
338 (struct it.selective): Now EMACS_INT, not int.
339 * xdisp.c (forward_to_next_line_start)
340 (back_to_previous_visible_line_start)
341 (reseat_at_next_visible_line_start, next_element_from_buffer):
342 Don't arbitrarily truncate the value of 'selective' to int.
343
344 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
345
346 * composite.c: Don't truncate sizes to 'int'.
347 (composition_gstring_p, composition_reseat_it)
348 (composition_adjust_point): Use EMACS_INT, not int.
349 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
350 not EMACS_UINT, for indexes.
351
352 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
353
354 * buffer.c: Include <verify.h>.
355 (struct sortvec.priority, struct sortstr.priority):
356 Now EMACS_INT, not int.
357 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
358 (struct sortstr.size, record_overlay_string)
359 (struct sortstrlist.size, struct sortlist.used):
360 Don't truncate size to int.
361 (record_overlay_string): Check for size-calculation overflow.
362 (init_buffer_once): Check at compile-time, not run-time.
363
364 2011-06-22 Jim Meyering <meyering@redhat.com>
365
366 Don't leak an XBM-image-sized buffer
367 * image.c (xbm_load): Free the image buffer after using it.
368
369 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
370
371 Port to Sun C.
372 * composite.c (find_automatic_composition): Omit needless 'return 0;'
373 that Sun C diagnosed.
374 * fns.c (secure_hash): Fix pointer signedness issue.
375 * intervals.c (static_offset_intervals): New function.
376 (offset_intervals): Use it.
377
378 2011-06-21 Leo Liu <sdl.web@gmail.com>
379
380 * deps.mk (fns.o):
381 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
382 sha512.h.
383
384 * fns.c (secure_hash): Rename from crypto_hash_function and change
385 the first arg to accept symbols.
386 (Fsecure_hash): New primitive.
387 (syms_of_fns): New symbols.
388
389 2011-06-20 Deniz Dogan <deniz@dogan.se>
390
391 * process.c (Fset_process_buffer): Clarify return value in
392 docstring.
393
394 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
395
396 * dispnew.c (add_window_display_history): Use BVAR.
397
398 * xdisp.c (debug_method_add): Use BVAR.
399 (check_window_end, dump_glyph_matrix, dump_glyph)
400 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
401
402 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
403 Likewise.
404
405 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
406 check till after the cache is created in init_frame_faces.
407
408 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
409
410 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
411
412 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
413
414 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
415 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
416 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
417
418 Improve buffer-overflow checking (Bug#8873).
419 * fileio.c (Finsert_file_contents):
420 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
421 Remove the old (too-loose) buffer overflow checks.
422 They weren't needed, since make_gap checks for buffer overflow.
423 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
424 The old code merely checked for Emacs fixnum overflow, and relied
425 on undefined (wraparound) behavior. The new code avoids undefined
426 behavior, and also checks for ptrdiff_t and/or size_t overflow.
427
428 * editfns.c (Finsert_char): Don't dump core with very negative counts.
429 Tune. Don't use wider integers than needed. Don't use alloca.
430 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
431
432 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
433
434 * insdel.c, lisp.h (buffer_overflow): New function.
435 (insert_from_buffer_1, replace_range, replace_range_2):
436 * insdel.c (make_gap_larger):
437 * editfns.c (Finsert_char):
438 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
439
440 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
441
442 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
443
444 Integer overflow and signedness fixes (Bug#8873).
445
446 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
447 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
448
449 * fileio.c: Don't assume EMACS_INT fits in off_t.
450 (emacs_lseek): New static function.
451 (Finsert_file_contents, Fwrite_region): Use it.
452 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
453
454 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
455
456 * fns.c: Don't overflow int when computing a list length.
457 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
458 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
459 truncation on 64-bit hosts. Check for QUIT every
460 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
461 faster and is responsive enough.
462 (Flength): Report an error instead of overflowing an integer.
463 (Fsafe_length): Return a float if the value is not representable
464 as a fixnum. This shouldn't happen except in contrived situations.
465 (Fnthcdr, Fsort): Don't assume list length fits in int.
466 (Fcopy_sequence): Don't assume vector length fits in int.
467
468 * alloc.c: Check that resized vectors' lengths fit in fixnums.
469 (header_size, word_size): New constants.
470 (allocate_vectorlike): Don't check size overflow here.
471 (allocate_vector): Check it here instead, since this is the only
472 caller of allocate_vectorlike that could cause overflow.
473 Check that the new vector's length is representable as a fixnum.
474
475 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
476 The previous code was bogus. For example, next_almost_prime (32)
477 returned 39, which is undesirable as it is a multiple of 3; and
478 next_almost_prime (24) returned 25, which is a multiple of 5 so
479 why was the code bothering to check for multiples of 7?
480
481 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
482
483 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
484
485 Variadic C functions now count arguments with ptrdiff_t.
486 This partly undoes my 2011-03-30 change, which replaced int with size_t.
487 Back then I didn't know that the Emacs coding style prefers signed int.
488 Also, in the meantime I found a few more instances where arguments
489 were being counted with int, which may truncate counts on 64-bit
490 machines, or EMACS_INT, which may be unnecessarily wide.
491 * lisp.h (struct Lisp_Subr.function.aMANY)
492 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
493 Arg counts are now ptrdiff_t, not size_t.
494 All variadic functions and their callers changed accordingly.
495 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
496 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
497 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
498 * callint.c (Fcall_interactively): Check arg count for overflow,
499 to avoid potential buffer overrun. Use signed char, not 'int',
500 for 'varies' array, so that we needn't bother to check its size
501 calculation for overflow.
502 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
503 * eval.c (apply_lambda):
504 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
505 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
506 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
507
508 * callint.c (Fcall_interactively): Don't use index var as event count.
509
510 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
511 * mem-limits.h (SIZE): Remove; no longer used.
512
513 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
514
515 Remove unnecessary casts.
516 * xterm.c (x_term_init):
517 * xfns.c (x_set_border_pixel):
518 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
519 These aren't needed now that we assume ANSI C.
520
521 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
522 It's more likely to cause problems (due to unsigned overflow)
523 than to cure them.
524
525 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
526
527 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
528
529 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
530
531 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
532
533 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
534
535 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
536
537 GLYPH_CODE_FACE returns EMACS_INT, not int.
538 * dispextern.h (merge_faces):
539 * xfaces.c (merge_faces):
540 * xdisp.c (get_next_display_element, next_element_from_display_vector):
541 Don't assume EMACS_INT fits in int.
542
543 * character.h (CHAR_VALID_P): Remove unused parameter.
544 * fontset.c, lisp.h, xdisp.c: All uses changed.
545
546 * editfns.c (Ftranslate_region_internal): Omit redundant test.
547
548 * fns.c (concat): Minor tuning based on overflow analysis.
549 This doesn't fix any bugs. Use int to hold character, instead
550 of constantly refetching from Emacs object. Use XFASTINT, not
551 XINT, for value known to be a character. Don't bother comparing
552 a single byte to 0400, as it's always less.
553
554 * floatfns.c (Fexpt):
555 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
556
557 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
558 for characters.
559
560 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
561
562 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
563 Without this fix, on a 64-bit host (aset S 0 4294967386) would
564 incorrectly succeed when S was a string, because 4294967386 was
565 truncated before it was used.
566
567 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
568 Otherwise, an out-of-range integer could cause undefined behavior
569 on a 64-bit host.
570
571 * composite.c: Use int, not EMACS_INT, for characters.
572 (fill_gstring_body, composition_compute_stop_pos): Use int, not
573 EMACS_INT, for values that are known to be in character range.
574 This doesn't fix any bugs but is the usual style inside Emacs and
575 may generate better code on 32-bit machines.
576
577 Make sure a 64-bit char is never passed to ENCODE_CHAR.
578 This is for reasons similar to the recent CHAR_STRING fix.
579 * charset.c (Fencode_char): Check that character arg is actually
580 a character. Pass an int to ENCODE_CHAR.
581 * charset.h (ENCODE_CHAR): Verify that the character argument is no
582 wider than 'int', as a compile-time check to prevent future regressions
583 in this area.
584
585 * character.c (char_string): Remove unnecessary casts.
586
587 Make sure a 64-bit char is never passed to CHAR_STRING.
588 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
589 by silently ignoring the top 32 bits, allowing some values
590 that were far too large to be valid characters.
591 * character.h: Include <verify.h>.
592 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
593 arguments are no wider than unsigned, as a compile-time check
594 to prevent future regressions in this area.
595 * data.c (Faset):
596 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
597 (Fsubst_char_in_region):
598 * fns.c (concat):
599 * xdisp.c (decode_mode_spec_coding):
600 Adjust to CHAR_STRING's new requirement.
601 * editfns.c (Finsert_char, Fsubst_char_in_region):
602 * fns.c (concat): Check that character args are actually
603 characters. Without this test, these functions did the wrong
604 thing with wildly out-of-range values on 64-bit hosts.
605
606 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
607 These casts should not be needed on 32-bit hosts, either.
608 * keyboard.c (read_char):
609 * lread.c (Fload): Remove casts to unsigned.
610
611 * lisp.h (UNSIGNED_CMP): New macro.
612 This fixes comparison bugs on 64-bit hosts.
613 (ASCII_CHAR_P): Use it.
614 * casefiddle.c (casify_object):
615 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
616 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
617 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
618 * dispextern.h (FACE_FROM_ID):
619 * keyboard.c (read_char): Use UNSIGNED_CMP.
620
621 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
622 not to EMACS_INT, to avoid GCC warning.
623
624 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
625
626 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
627 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
628 isn't needed on 32-bit machines.
629
630 * buffer.c (Fgenerate_new_buffer_name):
631 Use EMACS_INT for count, not int.
632 (advance_to_char_boundary): Return EMACS_INT, not int.
633
634 * data.c (Qcompiled_function): Now static.
635
636 * window.c (window_body_lines): Now static.
637
638 * image.c (gif_load): Rename local to avoid shadowing.
639
640 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
641 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
642 * alloc.c (make_save_value): Integer argument is now of type
643 ptrdiff_t, not int.
644 (mark_object): Use ptrdiff_t, not int.
645 * lisp.h (pD): New macro.
646 * print.c (print_object): Use it.
647
648 * alloc.c: Use EMACS_INT, not int, to count objects.
649 (total_conses, total_markers, total_symbols, total_vector_size)
650 (total_free_conses, total_free_markers, total_free_symbols)
651 (total_free_floats, total_floats, total_free_intervals)
652 (total_intervals, total_strings, total_free_strings):
653 Now EMACS_INT, not int. All uses changed.
654 (Fgarbage_collect): Compute overall total using a double, so that
655 integer overflow is less likely to be a problem. Check for overflow
656 when converting back to an integer.
657 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
658 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
659 These were 'int' variables that could overflow on 64-bit hosts;
660 they were never used, so remove them instead of repairing them.
661 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
662 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
663 Previously, this ceilinged at INT_MAX, but that doesn't work on
664 64-bit machines.
665 (allocate_pseudovector): Don't use EMACS_INT when int would do.
666
667 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
668 (allocate_vectorlike): Check for ptrdiff_t overflow.
669 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
670 when a (possibly-narrower) signed value would do just as well.
671 We prefer using signed arithmetic, to avoid comparison confusion.
672
673 * alloc.c: Catch some string size overflows that we were missing.
674 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
675 for convenience in STRING_BYTES_MAX.
676 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
677 The definition here is exact; the one in lisp.h was approximate.
678 (allocate_string_data): Check for string overflow. This catches
679 some instances we weren't catching before. Also, it catches
680 size_t overflow on (unusual) hosts where SIZE_MAX <= min
681 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
682 and ptrdiff_t and EMACS_INT are both 64 bits.
683
684 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
685 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
686 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
687
688 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
689
690 * alloc.c (Fmake_string): Check for out-of-range init.
691
692 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
693
694 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
695
696 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
697
698 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
699 xg_get_default_scrollbar_width.
700
701 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
702 (int_gtk_range_get_value): Move to the scroll bar part of the file.
703 (style_changed_cb): Call update_theme_scrollbar_width and call
704 x_set_scroll_bar_default_width and xg_frame_set_char_size for
705 all frames (Bug#8505).
706 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
707 Call gtk_window_set_resizable if HAVE_GTK3.
708 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
709 and height if HAVE_GTK3 (Bug#8505).
710 (scroll_bar_width_for_theme): New variable.
711 (update_theme_scrollbar_width): New function.
712 (xg_get_default_scrollbar_width): Move code to
713 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
714 (xg_initialize): Call update_theme_scrollbar_width.
715
716 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
717
718 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
719
720 2011-06-12 Martin Rudalics <rudalics@gmx.at>
721
722 * frame.c (make_frame): Call other_buffer_safely instead of
723 other_buffer.
724
725 * window.c (temp_output_buffer_show): Call display_buffer with
726 second argument Vtemp_buffer_show_specifiers and reset latter
727 immediately after the call.
728 (Vtemp_buffer_show_specifiers): New variable.
729 (auto_window_vscroll_p, next_screen_context_lines)
730 (Vscroll_preserve_screen_position): Remove leading asterisks from
731 doc-strings.
732
733 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
734
735 Fix minor problems found by GCC 4.6.0 static checking.
736 * buffer.c (Qclone_number): Remove for now, as it's unused.
737 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
738 (record_buffer): Remove unused local.
739 * frame.c (other_visible_frames, frame_buffer_list): Now static.
740 (set_frame_buffer_list): Remove; unused.
741 * frame.h (other_visible_frames): Remove decl.
742 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
743 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
744 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
745 if HAVE_GPM.
746 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
747 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
748 Define only if HAVE_GPM.
749 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
750 (update_hints_inhibit): Remove; never set. All uses removed.
751 * widgetprv.h (emacsFrameClassRec): Remove decl.
752 * window.c (delete_deletable_window): Now returns void, since it
753 wasn't returning anything.
754 (compare_window_configurations): Remove unused locals.
755 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
756 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
757 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
758 the same widths as pointers. This follows up on the 2011-05-06 patch.
759 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
760 * xterm.h: Likewise.
761 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
762
763 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
764
765 * makefile.w32-in: Update dependencies.
766 (LISP_H): Add lib/intprops.h.
767
768 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
769
770 * image.c (gif_load): Add animation frame delay to the metadata.
771 (syms_of_image): Use DEFSYM. New symbol `delay'.
772
773 2011-06-11 Martin Rudalics <rudalics@gmx.at>
774
775 * window.c (delete_deletable_window): Re-add.
776 (Fset_window_configuration): Rewrite to handle dead buffers and
777 consequently deletable windows.
778 (window_tree, Fwindow_tree): Remove. Supply functionality in
779 window.el.
780 (compare_window_configurations): Simplify code.
781
782 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
783
784 * image.c (imagemagick_load_image): Fix type mismatch.
785 (Fimagemagick_types): Likewise.
786
787 * window.h (replace_buffer_in_windows): Declare.
788
789 2011-06-11 Martin Rudalics <rudalics@gmx.at>
790
791 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
792 Qclone_number. Remove external declaration of Qdelete_window.
793 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
794 code.
795 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
796 Qbuffer_list_update_hook if allowed.
797 (Fother_buffer): Rewrite doc-string. Major rewrite for new
798 buffer list implementation.
799 (other_buffer_safely): New function.
800 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
801 calls to replace_buffer_in_windows and
802 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
803 if allowed.
804 (record_buffer): Inhibit quitting and rewrite using quittable
805 functions. Run Qbuffer_list_update_hook if allowed.
806 (Frecord_buffer, Funrecord_buffer): New functions.
807 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
808 switch-to-buffer to window.el.
809 (bury-buffer): Move to window.el.
810 (Vbuffer_list_update_hook): New variable.
811
812 * lisp.h (other_buffer_safely): Add prototype in buffer.c
813 section.
814
815 * window.h (resize_frame_windows): Move up in code.
816 (Fwindow_frame): Remove EXFUN.
817 (replace_buffer_in_all_windows): Remove prototype.
818 (replace_buffer_in_windows_safely): Add prototype.
819
820 * window.c: Declare Qdelete_window static again. Move down
821 declaration of select_count.
822 (Fnext_window, Fprevious_window): Rewrite doc-strings.
823 (Fother_window): Move to window.el.
824 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
825 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
826 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
827 window.el.
828 (replace_buffer_in_windows): Implement by calling
829 Qreplace_buffer_in_windows.
830 (replace_buffer_in_all_windows): Remove with some functionality
831 moved into replace_buffer_in_windows_safely.
832 (replace_buffer_in_windows_safely): New function.
833 (select_window_norecord, select_frame_norecord): Move in front
834 of run_window_configuration_change_hook. Remove now obsolete
835 declarations.
836 (Fset_window_buffer): Rewrite doc-string. Call
837 Qrecord_window_buffer.
838 (keys_of_window): Move binding for other-window to window.el.
839
840 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
841
842 * dispextern.h (struct image): Replace data member, whose int_val
843 and ptr_val fields were not used by anything, with a single
844 lisp_val object.
845
846 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
847 (gif_clear_image, gif_load, imagemagick_load_image)
848 (gs_clear_image, gs_load): Callers changed.
849
850 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
851
852 * buffer.h: Include <time.h>, for time_t.
853 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
854
855 Fix minor problems found by static checking.
856
857 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
858
859 Make identifiers static if they are not used in other modules.
860 * data.c (Qcompiled_function, Qframe, Qvector):
861 * image.c (QimageMagick, Qsvg):
862 * minibuf.c (Qmetadata):
863 * window.c (resize_window_check, resize_root_window): Now static.
864 * window.h (resize_window_check, resize_root_window): Remove decls.
865
866 * window.c (window_deletion_count, delete_deletable_window):
867 Remove; unused.
868 (window_body_lines): Now static.
869 (Fdelete_other_windows_internal): Mark vars as initialized.
870 Make sure 'resize_failed' is initialized.
871 (run_window_configuration_change_hook): Rename local to avoid shadowing.
872 (resize_window_apply): Remove unused local.
873 * window.h (delete_deletable_window): Remove decl.
874
875 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
876 (imagemagick_load_image): Fix pointer signedness problem by changing
877 last arg from unsigned char * to char *. All uses changed.
878 Also, fix a local for similar reasons.
879 Remove unused locals. Remove locals to avoid shadowing.
880 (fn_rsvg_handle_free): Remove; unused.
881 (svg_load, svg_load_image): Fix pointer signedness problem.
882 (imagemagick_load_image): Don't use garbage pointer image_wand.
883
884 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
885
886 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
887
888 * image.c (gif_load): Fix omitted cast error introduced by
889 2011-06-06 change.
890
891 2011-06-10 Martin Rudalics <rudalics@gmx.at>
892
893 * window.h (resize_proportionally, orig_total_lines)
894 (orig_top_line): Remove from window structure.
895 (set_window_height, set_window_width, change_window_heights)
896 (Fdelete_window): Remove prototypes.
897 (resize_frame_windows): Remove duplicate declaration.
898
899 2011-06-10 Eli Zaretskii <eliz@gnu.org>
900
901 * window.h (resize_frame_windows, resize_window_check)
902 (delete_deletable_window, resize_root_window)
903 (resize_frame_windows): Declare prototypes.
904
905 * window.c (resize_window_apply): Make definition be "static" to
906 match the prototype.
907
908 2011-06-10 Martin Rudalics <rudalics@gmx.at>
909
910 * window.c: Remove declarations of Qwindow_size_fixed,
911 window_min_size_1, window_min_size_2, window_min_size,
912 size_window, window_fixed_size_p, enlarge_window, delete_window.
913 Remove static from declaration of Qdelete_window, it's
914 temporarily needed by Fbury_buffer.
915 (replace_window): Don't assign orig_top_line and
916 orig_total_lines.
917 (Fdelete_window, delete_window): Remove. Window deletion is
918 handled by window.el.
919 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
920 Fdelete_window calls with calls to Qdelete_window.
921 (Fdelete_other_windows): Remove. Deleting other windows is
922 handled by window.el.
923 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
924 handled in window.el.
925 (window_min_size_2, window_min_size_1, window_min_size): Remove.
926 Window minimum sizes are handled in window.el.
927 (shrink_windows, size_window, set_window_height)
928 (set_window_width, change_window_heights, window_height)
929 (window_width, CURBEG, CURSIZE, enlarge_window)
930 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
931 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
932 handled in window.el.
933 (make_dummy_parent): Rename to make_parent_window and give it a
934 second argument horflag.
935 (make_window): Don't set resize_proportionally any more.
936 (Fsplit_window): Remove. Windows are split in window.el.
937 (save_restore_action, save_restore_orig_size)
938 (shrink_window_lowest_first, save_restore_orig_size): Remove.
939 Resize mini windows in window.el.
940 (grow_mini_window, shrink_mini_window): Implement by calling
941 Qresize_root_window_vertically, resize_window_check and
942 resize_window_apply.
943 (saved_window, Fset_window_configuration, save_window_save): Do
944 not handle orig_top_line, orig_total_lines, and
945 resize_proportionally.
946 (window_min_height, window_min_width): Move to window.el.
947 (keys_of_window): Move bindings for delete-other-windows,
948 split-window, delete-window and enlarge-window to window.el.
949
950 * buffer.c: Temporarily extern Qdelete_window.
951 (Fbury_buffer): Temporarily call Qdelete_window instead of
952 Fdelete_window (Fbury_buffer will move to window.el soon).
953
954 * frame.c (set_menu_bar_lines_1): Remove code handling
955 orig_top_line and orig_total_lines.
956
957 * dispnew.c (adjust_frame_glyphs_initially): Don't use
958 set_window_height but set heights directly.
959 (change_frame_size_1): Use resize_frame_windows.
960
961 * xdisp.c (init_xdisp): Don't use set_window_height but set
962 heights directly.
963
964 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
965 resize_frame_windows instead of change_window_heights and run
966 run_window_configuration_change_hook.
967
968 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
969 instead of change_window_heights and run
970 run_window_configuration_change_hook.
971
972 2011-06-09 Martin Rudalics <rudalics@gmx.at>
973
974 * window.c (replace_window): Rename second argument REPLACEMENT to
975 NEW. New third argument SETFLAG. Rewrite.
976 (delete_window, make_dummy_parent): Call replace_window with
977 third argument 1.
978 (window_list_1): Move down in code.
979 (run_window_configuration_change_hook): Move set_buffer part
980 before select_frame_norecord part in order to unwind correctly.
981 Rename count1 to count.
982 (recombine_windows, delete_deletable_window, resize_root_window)
983 (Fdelete_other_windows_internal)
984 (Frun_window_configuration_change_hook, make_parent_window)
985 (resize_window_check, resize_window_apply, Fresize_window_apply)
986 (resize_frame_windows, Fsplit_window_internal)
987 (Fdelete_window_internal, Fresize_mini_window_internal): New
988 functions.
989 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
990
991 2011-06-08 Martin Rudalics <rudalics@gmx.at>
992
993 * window.h (window): Add some new members to window structure -
994 normal_lines, normal_cols, new_total, new_normal, clone_number,
995 splits, nest, prev_buffers, next_buffers.
996 (WINDOW_TOTAL_SIZE): Move here from window.c.
997 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
998
999 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1000 Remove.
1001 (make_dummy_parent): Set new members of windows structure.
1002 (make_window): Move down in code. Handle new members of window
1003 structure.
1004 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1005 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1006 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1007 (Fset_window_prev_buffers, Fwindow_next_buffers)
1008 (Fset_window_next_buffers, Fset_window_clone_number): New
1009 functions.
1010 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1011 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1012 Doc-string fixes.
1013 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1014 Argument WINDOW can be now internal window too.
1015 (Fwindow_use_time): Move up in code.
1016 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1017 Rewrite doc-string.
1018 (Fset_window_configuration, saved_window)
1019 (Fcurrent_window_configuration, save_window_save): Handle new
1020 members of window structure.
1021 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1022 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1023 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1024 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1025 Qget_mru_window, Qresize_root_window,
1026 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1027 Qauto_buffer_name; staticpro them.
1028
1029 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1030
1031 * window.c (Fwindow_total_size, Fwindow_left_column)
1032 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1033 (Fwindow_list_1): New functions.
1034 (window_box_text_cols): Replace with window_body_cols.
1035 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1036 window_body_cols instead of window_box_text_cols.
1037 (delete_window, Fset_window_configuration): Call
1038 delete_all_subwindows with window as argument.
1039 (delete_all_subwindows): Take a window as argument and not a
1040 structure. Rewrite.
1041 (window_loop): Remove handling of GET_LRU_WINDOW and
1042 GET_LARGEST_WINDOW.
1043 (Fget_lru_window, Fget_largest_window): Move to window.el.
1044
1045 * window.h: Extern window_body_cols instead of
1046 window_box_text_cols. delete_all_subwindows now takes a
1047 Lisp_Object as argument.
1048
1049 * indent.c (compute_motion, Fcompute_motion): Use
1050 window_body_cols instead of window_box_text_cols.
1051
1052 * frame.c (delete_frame): Call delete_all_subwindows with root
1053 window as argument.
1054
1055 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1056
1057 * fns.c (Fputhash): Document return value.
1058
1059 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1060
1061 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1062
1063 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1064
1065 Cons<->int and similar integer overflow fixes (Bug#8794).
1066
1067 Check for overflow when converting integer to cons and back.
1068 * charset.c (Fdefine_charset_internal, Fdecode_char):
1069 Use cons_to_unsigned to catch overflow.
1070 (Fencode_char): Use INTEGER_TO_CONS.
1071 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1072 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1073 * data.c (long_to_cons, cons_to_long): Remove.
1074 (cons_to_unsigned, cons_to_signed): New functions.
1075 These signal an error for invalid or out-of-range values.
1076 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1077 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1078 * font.c (Ffont_variation_glyphs):
1079 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1080 * lisp.h: Include <intprops.h>.
1081 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1082 (cons_to_signed, cons_to_unsigned): New decls.
1083 (long_to_cons, cons_to_long): Remove decls.
1084 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1085 (Fprimitive_undo): Use CONS_TO_INTEGER.
1086 * xfns.c (Fx_window_property): Likewise.
1087 * xselect.c: Include <limits.h>.
1088 (x_own_selection, selection_data_to_lisp_data):
1089 Use INTEGER_TO_CONS.
1090 (x_handle_selection_request, x_handle_selection_clear)
1091 (x_get_foreign_selection, Fx_disown_selection_internal)
1092 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1093 (lisp_data_to_selection_data): Use cons_to_unsigned.
1094 (x_fill_property_data): Use cons_to_signed.
1095 Report values out of range.
1096
1097 Check for buffer and string overflow more precisely.
1098 * buffer.h (BUF_BYTES_MAX): New macro.
1099 * lisp.h (STRING_BYTES_MAX): New macro.
1100 * alloc.c (Fmake_string):
1101 * character.c (string_escape_byte8):
1102 * coding.c (coding_alloc_by_realloc):
1103 * doprnt.c (doprnt):
1104 * editfns.c (Fformat):
1105 * eval.c (verror):
1106 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1107 since they may not be the same number.
1108 * editfns.c (Finsert_char):
1109 * fileio.c (Finsert_file_contents):
1110 Likewise for BUF_BYTES_MAX.
1111
1112 * image.c: Use ptrdiff_t, not int, for sizes.
1113 (slurp_file): Switch from int to ptrdiff_t.
1114 All uses changed.
1115 (slurp_file): Check that file size fits in both size_t (for
1116 malloc) and ptrdiff_t (for sanity and safety).
1117
1118 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1119 if b->modtime has its maximal value.
1120
1121 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1122
1123 Don't assume time_t can fit into int.
1124 * buffer.h (struct buffer.modtime): Now time_t, not int.
1125 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1126 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1127
1128 Minor fixes for signed vs unsigned integers.
1129 * character.h (MAYBE_UNIFY_CHAR):
1130 * charset.c (maybe_unify_char):
1131 * keyboard.c (read_char, reorder_modifiers):
1132 XINT -> XFASTINT, since the integer must be nonnegative.
1133 * ftfont.c (ftfont_spec_pattern):
1134 * keymap.c (access_keymap, silly_event_symbol_error):
1135 XUINT -> XFASTINT, since the integer must be nonnegative.
1136 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1137 since it makes no difference and we prefer signed.
1138 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1139 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1140 nonnegative.
1141
1142 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1143
1144 * window.h (Fwindow_frame): Declare.
1145
1146 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1147
1148 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1149 (SPARE_MEMORY): Always define.
1150 (LARGE_REQUEST): Remove.
1151 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1152
1153 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1154
1155 * lisp.h: Move EXFUNS for Fframe_root_window,
1156 Fframe_first_window and Fset_frame_selected_window to window.h.
1157
1158 * window.h: Move EXFUNS for Fframe_root_window,
1159 Fframe_first_window and Fset_frame_selected_window here from
1160 lisp.h.
1161
1162 * frame.c (Fwindow_frame, Fframe_first_window)
1163 (Fframe_root_window, Fframe_selected_window)
1164 (Fset_frame_selected_window): Move to window.c.
1165 (Factive_minibuffer_window): Move to minibuf.c.
1166 (Fother_visible_frames_p): New function.
1167
1168 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1169
1170 * window.c (decode_window, decode_any_window): Move up in code.
1171 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1172 (inhibit_frame_unsplittable): Remove unused variable.
1173 (Fwindow_buffer): Move up and rewrite doc-string.
1174 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1175 (Fwindow_prev): New functions.
1176 (Fwindow_frame): Move here from frame.c. Accept any window as
1177 argument.
1178 (Fframe_root_window, Fframe_first_window)
1179 (Fframe_selected_window): Move here from frame.c. Accept frame
1180 or arbitrary window as argument. Update doc-strings.
1181 (Fminibuffer_window): Move up in code.
1182 (Fwindow_minibuffer_p): Move up in code and simplify.
1183 (Fset_frame_selected_window): Move here from frame.c.
1184 Marginal rewrite.
1185 (Fselected_window, select_window, Fselect_window): Move up in
1186 code. Minor doc-string fixes.
1187
1188 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1189
1190 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1191 Do not assume that spare memory exists; that assumption is valid
1192 only if SYSTEM_MALLOC.
1193 (LARGE_REQUEST): New macro, so that the issue of large requests
1194 is separated from the issue of spare memory.
1195
1196 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1197
1198 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1199 format. (Bug#8806)
1200
1201 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1202
1203 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1204 before statements.
1205
1206 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1207
1208 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1209
1210 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1211
1212 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1213 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1214
1215 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1216
1217 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1218
1219 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1220
1221 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1222 (x_clipboard_manager_save): Add return value.
1223 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1224 New error handlers.
1225 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1226 Obey Vx_select_enable_clipboard_manager. Catch errors in
1227 x_clipboard_manager_save (Bug#8779).
1228 (Vx_select_enable_clipboard_manager): New variable.
1229 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1230
1231 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1232
1233 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1234
1235 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1236
1237 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1238 in the current matrix if keep_current_p is non-zero.
1239
1240 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1241
1242 * bidi.c (bidi_level_of_next_char): Fix last change.
1243
1244 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1245
1246 Support bidi reordering of text covered by display properties.
1247
1248 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1249 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1250 (bidi_cache_search, bidi_cache_iterator_state)
1251 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1252 (bidi_level_of_next_char, bidi_move_to_visually_next):
1253 Support character positions inside a run of characters covered by a
1254 display string.
1255 (bidi_paragraph_init, bidi_resolve_explicit_1)
1256 (bidi_level_of_next_char): Call bidi_fetch_char and
1257 bidi_fetch_char_advance instead of FETCH_CHAR and
1258 FETCH_CHAR_ADVANCE.
1259 (bidi_init_it): Initialize new members.
1260 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1261 definitions.
1262 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1263 instead of using explicit *_CHAR codes.
1264 (bidi_resolve_explicit, bidi_resolve_weak):
1265 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1266 bidirectional text is supported only in multibyte buffers.
1267 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1268 it to initialize the frame_window_p member of struct bidi_it.
1269 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1270 (bidi_resolve_explicit, bidi_resolve_weak)
1271 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1272 bidi_it->nchars is non-positive.
1273 (bidi_level_of_next_char): Don't try to lookup the cache for the
1274 next/previous character if nothing is cached there yet, or if we
1275 were just reseat()'ed to a new position.
1276
1277 * xdisp.c (set_cursor_from_row): Set start and stop points
1278 according to the row's direction when priming the loop that looks
1279 for the glyph on which to display cursor.
1280 (single_display_spec_intangible_p): Function deleted.
1281 (display_prop_intangible_p): Reimplement to call
1282 handle_display_spec instead of single_display_spec_intangible_p.
1283 Accept 3 additional arguments needed by handle_display_spec.
1284 This fixes incorrect cursor motion across display property with complex
1285 values: lists, `(when COND...)' forms, etc.
1286 (single_display_spec_string_p): Support property values that are
1287 lists with the argument STRING its top-level element.
1288 (display_prop_string_p): Fix the condition for processing a
1289 property that is a list to be consistent with handle_display_spec.
1290 (handle_display_spec): New function, refactored from the
1291 last portion of handle_display_prop.
1292 (compute_display_string_pos): Accept additional argument
1293 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1294 value of a `display' property is a "replacing spec".
1295 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1296 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1297 the display property, but just return a value indicating whether
1298 the display property will replace the characters it covers.
1299 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1300 frame_window_p members of struct bidi_it.
1301 (compute_display_string_pos, compute_display_string_end):
1302 New functions.
1303 (push_it): Accept second argument POSITION, where pop_it should
1304 jump to continue iteration.
1305 (reseat_1): Initialize bidi_it.disp_pos.
1306
1307 * keyboard.c (adjust_point_for_property): Adjust the call to
1308 display_prop_intangible_p to its new signature.
1309
1310 * dispextern.h (struct bidi_it): New member frame_window_p.
1311 (bidi_init_it): Update prototypes.
1312 (display_prop_intangible_p): Update prototype.
1313 (compute_display_string_pos, compute_display_string_end):
1314 Declare prototypes.
1315 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1316 EMACS_INT.
1317
1318 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1319
1320 Malloc failure behavior now depends on size of allocation.
1321 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1322 * lisp.h: Change signatures accordingly.
1323 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1324 All callers changed. (Bug#8762)
1325
1326 * gnutls.c: Use Emacs's memory allocators.
1327 Without this change, the gnutls library would invoke malloc etc.
1328 directly, which causes problems on non-SYNC_INPUT hosts, and which
1329 runs afoul of improving memory_full behavior. (Bug#8761)
1330 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1331 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1332 xfree instead of the default malloc, realloc, free.
1333 (Fgnutls_boot): No need to check for memory allocation failure,
1334 since xmalloc does that for us.
1335
1336 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1337 * category.c (hash_get_category_set):
1338 * ccl.c (ccl_driver):
1339 * charset.c (Fdefine_charset_internal):
1340 * charset.h (struct charset.hash_index):
1341 * composite.c (get_composition_id, gstring_lookup_cache)
1342 (composition_gstring_put_cache):
1343 * composite.h (struct composition.hash_index):
1344 * dispextern.h (struct image.hash):
1345 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1346 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1347 (hashfn_equal, hashfn_user_defined, make_hash_table)
1348 (maybe_resize_hash_table, hash_lookup, hash_put)
1349 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1350 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1351 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1352 * image.c (make_image, search_image_cache, lookup_image)
1353 (xpm_put_color_table_h):
1354 * lisp.h (struct Lisp_Hash_Table):
1355 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1356 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1357 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1358 * alloc.c (allocate_vectorlike):
1359 Check for overflow in vector size calculations.
1360 * ccl.c (ccl_driver):
1361 Check for overflow when converting EMACS_INT to int.
1362 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1363 need to be updated by these changes.
1364 * fns.c (make_hash_table, maybe_resize_hash_table):
1365 Check for integer overflow with large hash tables.
1366 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1367 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1368 (SXHASH_REDUCE): New macro.
1369 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1370 Use it instead of discarding useful hash info with large hash values.
1371 (sxhash_float): New function.
1372 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1373 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1374 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1375 Rewrite to use FIXNUM_BITS, as this simplifies things.
1376 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1377 Adjust signatures to match updated version of code.
1378 (consing_since_gc): Now EMACS_INT, since a single hash table can
1379 use more than INT_MAX bytes.
1380
1381 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1382
1383 Make it possible to build with GCC-4.6+ -O2 -flto.
1384
1385 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1386
1387 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1388
1389 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1390 Call minibuffer-inactive-mode.
1391
1392 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1393
1394 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1395 Update dependencies.
1396
1397 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1398
1399 * data.c (init_data): Remove code for UTS, this system is not
1400 supported anymore.
1401
1402 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1403
1404 Don't force ./temacs to start in terminal mode.
1405
1406 * frame.c (make_initial_frame): Initialize faces in all cases, not
1407 only when CANNOT_DUMP is defined.
1408 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1409
1410 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1411
1412 * dispnew.c (add_window_display_history): Use const for the string
1413 pointer. Remove declaration, not needed.
1414
1415 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1416
1417 Use 'inline', not 'INLINE'.
1418 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1419 * alloc.c, fontset.c (INLINE): Remove.
1420 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1421 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1422 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1423 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1424 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1425
1426 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1427
1428 Make it possible to run ./temacs.
1429
1430 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1431 syms_of_callproc does the same thing. Remove test for
1432 "initialized", do it in the caller.
1433 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1434
1435 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1436
1437 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1438 (read_minibuf): Use get_minibuffer.
1439 (syms_of_minibuf): Use DEFSYM.
1440 (Qmetadata): New var.
1441 * data.c (Qbuffer): Don't make it static.
1442 (syms_of_data): Use DEFSYM.
1443
1444 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1445
1446 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1447 (CCL_CODE_MIN): New macro.
1448
1449 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1450
1451 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1452
1453 * eval.c (Qdebug): Now static.
1454 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1455 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1456 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1457
1458 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1459
1460 * image.c: Various fixes to ImageMagick code comments.
1461 (Fimagemagick_types): Doc fix.
1462
1463 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1464
1465 Minor fixes prompted by GCC 4.6.0 warnings.
1466
1467 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1468
1469 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1470 (x_clipboard_manager_save_all): Move extern decl to ...
1471 * xterm.h: ... here, so that it can be checked for consistency.
1472
1473 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1474
1475 * xselect.c (x_clipboard_manager_save_frame)
1476 (x_clipboard_manager_save_all): New functions.
1477 (Fx_clipboard_manager_save): Lisp function deleted.
1478
1479 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1480 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1481
1482 * xterm.h: Update prototype.
1483
1484 2011-05-28 William Xu <william.xwl@gmail.com>
1485
1486 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1487 exiting (Bug#8239).
1488
1489 2011-05-28 Jim Meyering <meyering@redhat.com>
1490
1491 Avoid a sign-extension bug in crypto_hash_function.
1492 * fns.c (to_uchar): Define.
1493 (crypto_hash_function): Use it to convert some newly-signed
1494 variables to unsigned, to avoid sign-extension bugs. For example,
1495 without this change, (md5 "truc") would evaluate to
1496 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1497 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1498 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1499
1500 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1501
1502 Integer overflow fixes.
1503
1504 * dbusbind.c: Serial number integer overflow fixes.
1505 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1506 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1507 to hold a serial number that is too large for a fixnum.
1508 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1509 Check for serial numbers out of range. Decode any serial number
1510 that was so large that it became a float. (Bug#8722)
1511
1512 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1513 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1514 Use XFASTINT rather than XUINT when numbers are nonnegative.
1515 (xd_append_arg, Fdbus_method_return_internal):
1516 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1517 arguments, check that Lisp number is nonnegative, rather than
1518 silently wrapping negative numbers around. (Bug#8722)
1519 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1520 (Bug#8722)
1521
1522 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1523
1524 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1525
1526 ccl: add integer overflow checks
1527 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1528 (IN_INT_RANGE): New macros.
1529 (ccl_driver): Use them to check for integer overflow when
1530 decoding a CCL program. Many of the new checks are whether XINT (x)
1531 fits in int; it doesn't always, on 64-bit hosts. The new version
1532 doesn't catch all possible integer overflows, but it's an
1533 improvement. (Bug#8719)
1534
1535 * alloc.c (make_event_array): Use XINT, not XUINT.
1536 There's no need for unsigned here.
1537
1538 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1539 This follows up to the 2011-05-06 change that substituted uintptr_t
1540 for EMACS_INT. This case wasn't caught back then.
1541
1542 Rework Fformat to avoid integer overflow issues.
1543 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1544 now (part of C89). Include <verify.h>.
1545 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1546 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1547 (Fformat): Avoid the prepass trying to compute sizes; it was only
1548 approximate and thus did not catch overflow reliably. Instead, walk
1549 through the format just once, formatting and computing sizes as we go,
1550 checking for integer overflow at every step, and allocating a larger
1551 buffer as needed. Keep track separately whether the format is
1552 multibyte. Keep only the most-recently calculated precision, rather
1553 than them all. Record whether each argument has been converted to
1554 string. Use EMACS_INT, not int, for byte and char and arg counts.
1555 Support field widths and precisions larger than INT_MAX. Avoid
1556 sprintf's undefined behavior with conversion specifications such as %#d
1557 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1558 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1559 formatting out-of-range floating point numbers with int
1560 formats. (Bug#8668)
1561
1562 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1563
1564 * data.c: Avoid integer truncation in expressions involving floats.
1565 * data.c: Include <intprops.h>.
1566 (arith_driver): When there's an integer overflow in an expression
1567 involving floating point, convert the integers to floating point
1568 so that the resulting value does not suffer from catastrophic
1569 integer truncation. For example, on a 64-bit host (* 4
1570 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1571 Do not rely on undefined behavior after integer overflow.
1572
1573 merge count_size_as_multibyte, parse_str_to_multibyte
1574 * character.c, character.h (count_size_as_multibyte):
1575 Rename from parse_str_to_multibyte; all uses changed.
1576 Check for integer overflow.
1577 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1578 since it's now a duplicate of the other. This is more of
1579 a character than a buffer op, so better that it's in character.c.
1580 * fns.c, print.c: Adjust to above changes.
1581
1582 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1583
1584 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1585
1586 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1587
1588 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1589 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1590 (x_clipboard_manager_save): Now static.
1591 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1592
1593 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1594 (crypto_hash_function): Now static.
1595 Fix pointer signedness problems. Avoid unnecessary initializations.
1596
1597 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1598
1599 * termhooks.h (Vselection_alist): Make it terminal-local.
1600
1601 * terminal.c (create_terminal): Initialize it.
1602
1603 * xselect.c: Support for clipboard managers.
1604 (Vselection_alist): Move to termhooks.h as terminal-local var.
1605 (LOCAL_SELECTION): New macro.
1606 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1607 (symbol_to_x_atom): Remove gratuitous arg.
1608 (x_handle_selection_request, lisp_data_to_selection_data)
1609 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1610 (x_own_selection, x_get_local_selection, x_convert_selection):
1611 New arg, specifying work frame. Use terminal-local Vselection_alist.
1612 (some_frame_on_display): Delete unused function.
1613 (Fx_own_selection_internal, Fx_get_selection_internal)
1614 (Fx_disown_selection_internal, Fx_selection_owner_p)
1615 (Fx_selection_exists_p): New optional frame arg.
1616 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1617 (x_handle_selection_clear): Don't treat other terminals with the
1618 same keyboard specially. Use the terminal-local Vselection_alist.
1619 (x_clear_frame_selections): Use Frun_hook_with_args.
1620
1621 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1622
1623 * xterm.h: Add support for those atoms.
1624
1625 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1626
1627 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1628 (converted_selections, conversion_fail_tag): New global variables.
1629 (x_selection_request_lisp_error): Free the above.
1630 (x_get_local_selection): Remove unnecessary code.
1631 (x_reply_selection_request): Args changed; handle arbitrary array
1632 of converted selections stored in converted_selections.
1633 Separate the XChangeProperty and SelectionNotify steps.
1634 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1635 (x_convert_selection): New function.
1636 (x_handle_selection_event): Simplify.
1637 (x_get_foreign_selection): Don't ignore incoming requests while
1638 waiting for an answer; this will fail when we implement
1639 SAVE_TARGETS, and seems unnecessary anyway.
1640 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1641 (Vx_sent_selection_functions): Doc fix.
1642
1643 2011-05-26 Leo Liu <sdl.web@gmail.com>
1644
1645 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1646
1647 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1648
1649 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1650
1651 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1652 for fringe update if it has periodic bitmap.
1653 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1654 and fringe_bitmap_periodic_p.
1655
1656 * fringe.c (get_fringe_bitmap_data): New function.
1657 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1658 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1659 row. Mark glyph row for fringe update if periodicity changed.
1660
1661 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1662 for fringe update unless it has periodic bitmap.
1663
1664 2011-05-25 Kenichi Handa <handa@m17n.org>
1665
1666 * xdisp.c (get_next_display_element): Set correct it->face_id for
1667 a static composition.
1668
1669 2011-05-24 Leo Liu <sdl.web@gmail.com>
1670
1671 * deps.mk (fns.o):
1672 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1673
1674 * fns.c (crypto_hash_function, Fsha1): New function.
1675 (Fmd5): Use crypto_hash_function.
1676 (syms_of_fns): Add Ssha1.
1677
1678 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1679
1680 * gnutls.c: Remove unused macros.
1681 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1682 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1683 Remove macros that are defined and never used.
1684 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1685
1686 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1687
1688 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1689 (Fx_get_selection_internal): Minor cleanup.
1690 (Fx_own_selection_internal): Rename arguments for consistency with
1691 select.el.
1692
1693 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1696
1697 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1698
1699 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1700
1701 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1702
1703 * dispnew.c (scrolling_window): Don't exclude the case that the
1704 last enabled row in the desired matrix touches the bottom boundary.
1705
1706 2011-05-21 Glenn Morris <rgm@gnu.org>
1707
1708 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1709 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1710 and add some more files.
1711
1712 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1713
1714 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1715 report_file_error introduced by the change from 2011-05-07.
1716
1717 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1718
1719 * systime.h (Time): Define only if emacs is defined.
1720 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1721 where the include path doesn't have X11/X.h by default. See
1722 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1723
1724 2011-05-20 Kenichi Handa <handa@m17n.org>
1725
1726 * composite.c (find_automatic_composition): Fix previous change.
1727
1728 2011-05-20 Glenn Morris <rgm@gnu.org>
1729
1730 * lisp.mk: New file, split from Makefile.in.
1731 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1732 (shortlisp): Remove.
1733 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1734
1735 2011-05-19 Glenn Morris <rgm@gnu.org>
1736
1737 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1738 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1739 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1740 (lisp): Set the order to that of loadup.el.
1741 (shortlisp): Make it a copy of $lisp.
1742 (SOME_MACHINE_LISP): Remove.
1743 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1744 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1745
1746 2011-05-18 Kenichi Handa <handa@m17n.org>
1747
1748 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1749 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1750 (find_automatic_composition): Mostly rewrite for efficiency.
1751
1752 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1753
1754 * makefile.w32-in: Update dependencies.
1755
1756 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1757
1758 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1759 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1760
1761 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1762
1763 Fix some integer overflow issues, such as string length overflow.
1764
1765 * insdel.c (count_size_as_multibyte): Check for string overflow.
1766
1767 * character.c (lisp_string_width): Check for string overflow.
1768 Use EMACS_INT, not int, for string indexes and lengths; in
1769 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1770 the resulting string length overflows an EMACS_INT; instead,
1771 report a string overflow if no precision given. When checking for
1772 precision exhaustion, use a check that cannot possibly have
1773 integer overflow. (Bug#8675)
1774 * character.h (lisp_string_width): Adjust to new signature.
1775
1776 * alloc.c (string_overflow): New function.
1777 (Fmake_string): Use it. This doesn't change behavior, but saves
1778 a few bytes and will simplify future changes.
1779 * character.c (string_escape_byte8): Likewise.
1780 * lisp.h (string_overflow): New decl.
1781
1782 Fixups, following up to the user-interface timestamp change.
1783 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1784 for UI timestamps, instead of unsigned long.
1785 * msdos.c (mouse_get_pos): Likewise.
1786 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1787 * w32gui.h (Time): Define by including "systime.h" rather than by
1788 declaring it ourselves. (Bug#8664)
1789
1790 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1791 * image.c (clear_image_cache): Likewise.
1792
1793 * term.c (term_mouse_position): Don't assume time_t wraparound.
1794
1795 Be more systematic about user-interface timestamps.
1796 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1797 and sometimes 'EMACS_UINT', to represent these timestamps.
1798 This change causes it to use 'Time' uniformly, as that's what X uses.
1799 This makes the code easier to follow, and makes it easier to catch
1800 integer overflow bugs such as Bug#8664.
1801 * frame.c (Fmouse_position, Fmouse_pixel_position):
1802 Use Time, not unsigned long, for user-interface timestamps.
1803 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1804 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1805 * keyboard.h (last_event_timestamp): Likewise.
1806 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1807 * menu.h (xmenu_show): Likewise.
1808 * term.c (term_mouse_position): Likewise.
1809 * termhooks.h (struct input_event.timestamp): Likewise.
1810 (struct terminal.mouse_position_hook): Likewise.
1811 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1812 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1813 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1814 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1815 what it was before.
1816 * menu.h, termhooks.h: Include "systime.h", for Time.
1817
1818 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1819 Don't assume that the difference between two unsigned long values
1820 can fit into an integer. At this point, we know button_down_time
1821 <= event->timestamp, so the difference must be nonnegative, so
1822 there's no need to cast the result if double-click-time is
1823 nonnegative, as it should be; check that it's nonnegative, just in
1824 case. This bug is triggered when events are more than 2**31 ms
1825 apart (about 25 days). (Bug#8664)
1826
1827 * xselect.c (last_event_timestamp): Remove duplicate decl.
1828 (x_own_selection): Remove needless cast to unsigned long.
1829
1830 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1831 that always fit in int. Use a sentinel instead of a counter, to
1832 avoid a temp and to allay GCC's concerns about possible int overflow.
1833 * frame.h (struct frame): Use int for menu_bar_items_used
1834 instead of EMACS_INT, since it always fits in int.
1835
1836 * menu.c (grow_menu_items): Check for int overflow.
1837
1838 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1839
1840 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1841 Before, the code was not consistent. These values cannot exceed
1842 2**31 - 1 so there's no need to make them unsigned.
1843 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1844 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1845 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1846 as modifiers.
1847 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1848
1849 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1850 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1851 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1852 presumably because the widths might not match.
1853
1854 * window.c (size_window): Avoid needless test at loop start.
1855
1856 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1857
1858 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1859
1860 2011-05-12 Drew Adams <drew.adams@oracle.com>
1861
1862 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1863
1864 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1865
1866 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1867 `width' to `bar_area_x' and `bar_area_width', respectively.
1868 (x_scroll_run): Take account of fringe background extension.
1869
1870 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1871 Rename local vars `left' and `width' to `bar_area_x' and
1872 `bar_area_width', respectively.
1873 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1874 background extension.
1875
1876 2011-05-10 Jim Meyering <meyering@redhat.com>
1877
1878 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1879
1880 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1881
1882 * image.c (Finit_image_library): Return t for built-in image types,
1883 like pbm and xbm. (Bug#8640)
1884
1885 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1886
1887 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1888
1889 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1890
1891 * w32console.c (Fset_screen_color): Doc fix.
1892 (Fget_screen_color): New function.
1893 (syms_of_ntterm): Defsubr it.
1894
1895 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1896 unlink the temporary file if Fcall_process didn't create it in the
1897 first place.
1898 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1899 child process will be redirected to a file specified with `:file'.
1900 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1901 cue to call_process_cleanup not to close that handle.
1902
1903 2011-05-07 Ben Key <bkey76@gmail.com>
1904
1905 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1906 one of two shell specific rules, either bootstrap-temacs-CMD or
1907 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1908 to the previous implementation of the bootstrap-temacs rule.
1909 The bootstrap-temacs-CMD rule is similar to the previous
1910 implementation of the bootstrap-temacs rule except that it
1911 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1912 variable.
1913
1914 These changes, along with some changes to nt/configure.bat,
1915 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1916 earlier fix to add support for --cflags and --ldflags options
1917 that include quotes so that it works whether make uses cmd or
1918 sh as the shell.
1919
1920 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1921
1922 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1923 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1924 is a constant.
1925 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1926 a string. Handle both cases.
1927 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1928 (Fdbus_register_method): Use Qinvalid_function.
1929
1930 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1931
1932 * makefile.w32-in: Update dependencies.
1933 (LISP_H): Add inttypes.h and stdin.h.
1934 (PROCESS_H): Add unistd.h.
1935
1936 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1937
1938 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1939 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1940
1941 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1942
1943 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1944
1945 * term.c (vfatal): Remove stray call to va_end.
1946 It's not needed and the C Standard doesn't allow it here anyway.
1947
1948 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1949 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1950
1951 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1952 bytes.
1953
1954 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1955
1956 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1957
1958 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1959
1960 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1961
1962 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1963
1964 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1965 * charset.c (Fdefine_charset_internal): Don't initialize
1966 charset.code_space[15]. The value was garbage, on hosts with
1967 32-bit int (Bug#8600).
1968
1969 * lread.c (read_integer): Be more consistent with string-to-number.
1970 Use string_to_number to do the actual conversion; this avoids
1971 rounding errors and fixes some other screwups. Without this fix,
1972 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1973 (digit_to_number): Move earlier, for benefit of read_integer.
1974 Return -1 if the digit is out of range for the base, -2 if it is
1975 not a digit in any supported base. (Bug#8602)
1976
1977 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1978
1979 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1980 to match comment at start of function. This also removes a
1981 GCC warning about overflow in a 32+64-bit port.
1982
1983 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1984
1985 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1986 Reported by Stefan Monnier in
1987 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1988 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1989 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1990
1991 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1992 (EMACS_UINTPTR): Likewise, with uintptr_t.
1993
1994 * lisp.h: Prefer 64-bit EMACS_INT if available.
1995 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1996 on 32-bit hosts that have 64-bit int, so that they can access
1997 large files.
1998 However, temporarily disable this change unless the temporary
1999 symbol WIDE_EMACS_INT is defined.
2000
2001 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2002
2003 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2004 This removes an assumption that EMACS_INT and long are the same
2005 width as pointers. The assumption is true for Emacs porting targets
2006 now, but we want to make other targets possible.
2007 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2008 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2009 In the rest of the code, change types of integers that hold casted
2010 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2011 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2012 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2013 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2014 No need to cast type when ORing.
2015 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2016 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2017 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2018 assume EMACS_INT is the same width as char *.
2019 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2020 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2021 Remove no-longer-needed casts.
2022 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2023 (xg_tool_bar_help_callback, xg_make_tool_item):
2024 Use EMACS_INTPTR to hold an integer
2025 that will be cast to void *; this can avoid a GCC warning
2026 if EMACS_INT is not the same width as void *.
2027 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2028 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2029 (current_message_1, set_message_1):
2030 Use a local to convert to proper width without a cast.
2031 * xmenu.c (dialog_selection_callback): Likewise.
2032
2033 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2034 Also, don't assume VALBITS / RAND_BITS is less than 5,
2035 and don't rely on undefined behavior when shifting a 1 left into
2036 the sign bit.
2037 * lisp.h (get_random): Change signature to match.
2038
2039 * lread.c (hash_string): Use size_t, not int, for hash computation.
2040 Normally we prefer signed values; but hashing is special, because
2041 it's better to use unsigned division on hash table sizes so that
2042 the remainder is nonnegative. Also, size_t is the natural width
2043 for hashing into memory. The previous code used 'int', which doesn't
2044 retain enough info to hash well into very large tables.
2045 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2046
2047 * dbusbind.c: Don't possibly lose pointer info when converting.
2048 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2049 Use XPNTR rather than XHASH, so that the high-order bits of
2050 the pointer aren't lost when converting through void *.
2051
2052 * eval.c (Fautoload): Don't double-shift a pointer.
2053
2054 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2055
2056 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2057
2058 * gnutls.c (DEF_GNUTLS_FN):
2059 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2060
2061 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2062
2063 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2064 marker. (Bug#8610)
2065
2066 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2067
2068 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2069 New version that can reserve upto 2GB of heap space.
2070
2071 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2072
2073 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2074
2075 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2076
2077 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2078 `gnutls_certificate_set_x509_key_file'.
2079
2080 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2081
2082 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2083 Update dependencies.
2084
2085 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2086
2087 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2088 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2089 Remove unused parameter `fildes'.
2090 * process.c (read_process_output, send_process): Don't pass it.
2091
2092 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2093
2094 Fix previous change: the library cache is defined in w32.c.
2095 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2096 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2097
2098 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2099
2100 Implement dynamic loading of GnuTLS on Windows.
2101
2102 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2103 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2104 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2105 Declare.
2106
2107 * gnutls.c (Qgnutls_dll): Define.
2108 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2109 (gnutls_*): Declare function pointers.
2110 (init_gnutls_functions): New function to initialize function pointers.
2111 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2112 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2113 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2114 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2115 (emacs_gnutls_write, emacs_gnutls_read)
2116 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2117 (Fgnutls_available_p): New function.
2118 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2119 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2120 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2121
2122 * image.c: Include w32.h.
2123 (Vimage_type_cache): Delete.
2124 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2125 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2126 (w32_delayed_load): Move to w32.c.
2127
2128 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2129
2130 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2131 (w32_delayed_load): Move from image.c. When loading a library, record
2132 its filename in the :loaded-from property of the library id.
2133 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2134 Initialize and staticpro them.
2135 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2136
2137 * process.c: Include lisp.h before w32.h, not after.
2138 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2139 instead of gnutls_record_check_pending.
2140
2141 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2142
2143 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2144
2145 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2146 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2147 as passed in.
2148
2149 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2150
2151 * xterm.c (x_set_frame_alpha): Do not set property on anything
2152 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2153
2154 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2155
2156 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2157
2158 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2159
2160 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2161 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2162 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2163 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2164 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2165 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2166 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2167 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2168 (Qgnutls_bootprop_callbacks_verify): Make static.
2169
2170 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2171
2172 * callproc.c: Indentation fixup.
2173
2174 * sysdep.c (wait_for_termination_1): Make static.
2175 (wait_for_termination, interruptible_wait_for_termination):
2176 Move after wait_for_termination_1.
2177
2178 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2179
2180 * sysdep.c (interruptible_wait_for_termination): New function
2181 which is like wait_for_termination, but allows keyboard
2182 interruptions.
2183
2184 * callproc.c (Fcall_process): Add (:file "file") as an option for
2185 the STDOUT buffer.
2186 (Fcall_process_region): Ditto.
2187
2188 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2189
2190 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2191 rather than `XVECTOR (FOO)->size'.
2192
2193 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2194 inttypes.h, as a gnulib replacement is used if it not available in
2195 system headers.
2196
2197 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2198
2199 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2200 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2201 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2202
2203 * coding.c (coding_alloc_by_realloc): Error out if destination
2204 will grow beyond MOST_POSITIVE_FIXNUM.
2205 (decode_coding_emacs_mule): Abort if there isn't enough place in
2206 charbuf for the composition carryover bytes. Reserve an extra
2207 space for up to 2 characters produced in a loop.
2208 (decode_coding_iso_2022): Abort if there isn't enough place in
2209 charbuf for the composition carryover bytes.
2210
2211 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2212
2213 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2214 aborting when %lld or %lll format is passed.
2215 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2216 %llo or %llx format is passed. (Bug#8545)
2217
2218 * window.c (window_scroll_line_based): Use a marker instead of
2219 simple variables to record original value of point. (Bug#7952)
2220
2221 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2222 produced by %s or %c overflows available buffer space. (Bug#8545)
2223
2224 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2225
2226 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2227 (SIZE_MAX): Move defn after all includes, as they might #define it.
2228
2229 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2230
2231 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2232
2233 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2234
2235 * keyboard.c (Qdelayed_warnings_hook): Define.
2236 (command_loop_1): Run `delayed-warnings-hook'
2237 if Vdelayed_warnings_list is non-nil.
2238 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2239 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2240
2241 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2242
2243 * doprnt.c (doprnt): Don't return value smaller than the buffer
2244 size if the message was truncated. (Bug#8545).
2245
2246 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2247
2248 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2249 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2250
2251 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2252
2253 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2254
2255 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2256
2257 * makefile.w32-in: Update dependencies.
2258
2259 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2260
2261 Improve `doprnt' and its usage. (Bug#8545)
2262 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2263 `format_end'. Remove support for %l as a conversion specifier.
2264 Don't use xrealloc. Improve diagnostics when the %l size modifier
2265 is used. Update the commentary.
2266
2267 * eval.c (verror): Simplify calculation of size_t.
2268
2269 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2270 messages.
2271
2272 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2273
2274 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2275 change.
2276
2277 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2280 This makes this file independent of the recent pseudovector change.
2281
2282 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2283
2284 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2285
2286 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2287 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2288 Remove unused local.
2289 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2290
2291 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2292 GCC 4.6.0 optimizes based on type-based alias analysis.
2293 For example, if b is of type struct buffer * and v of type struct
2294 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2295 != &v->size, and therefore "v->size = 1; b->size = 2; return
2296 v->size;" must therefore return 1. This assumption is incorrect
2297 for Emacs, since it type-puns struct Lisp_Vector * with many other
2298 types. To fix this problem, this patch adds a new type struct
2299 vectorlike_header that documents the constraints on layout of vectors
2300 and pseudovectors, and helps optimizing compilers not get fooled
2301 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2302 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2303 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2304 the size member.
2305 (XSETPVECTYPE): Rewrite in terms of new macro.
2306 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2307 This is a bit clearer, and further avoids the possibility of
2308 undesirable aliasing.
2309 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2310 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2311 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2312 since Lisp_Subr is a special case (no "next" field).
2313 (ASIZE): Now uses header.size rather than size.
2314 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2315 to avoid the hassle of writing XVECTOR (foo)->header.size.
2316 (struct vectorlike_header): New type.
2317 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2318 object, to help avoid aliasing.
2319 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2320 (SUBRP): Likewise, since Lisp_Subr is a special case.
2321 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2322 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2323 (struct Lisp_Hash_Table): Combine first two members into a single
2324 struct vectorlike_header member. All uses of "size" and "next" members
2325 changed to be "header.size" and "header.next".
2326 * buffer.h (struct buffer): Likewise.
2327 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2328 * frame.h (struct frame): Likewise.
2329 * process.h (struct Lisp_Process): Likewise.
2330 * termhooks.h (struct terminal): Likewise.
2331 * window.c (struct save_window_data, struct saved_window): Likewise.
2332 * window.h (struct window): Likewise.
2333 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2334 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2335 * buffer.c (init_buffer_once): Likewise.
2336 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2337 special case.
2338 * process.c (Fformat_network_address): Use local var for size,
2339 for brevity.
2340
2341 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2342
2343 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2344 * data.c (atof): Remove decl; no longer used or needed.
2345 (digit_to_number): Move to lread.c.
2346 (Fstring_to_number): Use new string_to_number function, to be
2347 consistent with how the Lisp reader treats infinities and NaNs.
2348 Do not assume that floating-point numbers represent EMACS_INT
2349 without losing information; this is not true on most 64-bit hosts.
2350 Avoid double-rounding errors, by insisting on integers when
2351 parsing non-base-10 numbers, as the documentation specifies.
2352 * lisp.h (string_to_number): New decl, replacing ...
2353 (isfloat_string): Remove.
2354 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2355 (read1): Do not accept +. and -. as integers; this
2356 appears to have been a coding error. Similarly, do not accept
2357 strings like +-1e0 as floating point numbers. Do not report
2358 overflow for integer overflows unless the base is not 10 which
2359 means we have no simple and reliable way to continue.
2360 Break out the floating-point parsing into a new
2361 function string_to_number, so that Fstring_to_number parses
2362 floating point numbers consistently with the Lisp reader.
2363 (digit_to_number): Move here from data.c. Make it static inline.
2364 (E_CHAR, EXP_INT): Remove, replacing with ...
2365 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2366 (string_to_number): New function, replacing isfloat_string.
2367 This function checks for valid syntax and produces the resulting
2368 Lisp float number too. Rework it so that string-to-number
2369 no longer mishandles examples like "1.0e+". Use strtoumax,
2370 so that overflow for non-base-10 numbers is reported only when
2371 there's no portable and simple way to convert to floating point.
2372
2373 * textprop.c (set_text_properties_1): Rewrite for clarity,
2374 and to avoid GCC warning about integer overflow.
2375
2376 * intervals.h (struct interval): Use EMACS_INT for members
2377 where EMACS_UINT might cause problems. See
2378 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2379 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2380 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2381 All uses changed.
2382 (offset_intervals): Tell GCC not to worry about length overflow
2383 when negating a negative length.
2384
2385 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2386 (overrun_check_free): Likewise.
2387
2388 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2389 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2390 word size.
2391
2392 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2393 (gnutls_make_error): Rename local to avoid shadowing.
2394 (gnutls_emacs_global_deinit): ifdef out; not used.
2395 (Fgnutls_boot): Use const for pointer to readonly storage.
2396 Comment out unused local. Fix pointer signedness problems.
2397
2398 * lread.c (openp): Don't stuff size_t into an 'int'.
2399 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2400 about possible signed overflow.
2401
2402 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2403 (GDK_KEY_g): Don't define if already defined.
2404 (xg_prepare_tooltip): Avoid pointer signedness problem.
2405 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2406
2407 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2408 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2409
2410 * xfns.c (Fx_window_property): Simplify a bit,
2411 to make a bit faster and to avoid GCC 4.6.0 warning.
2412 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2413
2414 * fns.c (internal_equal): Don't assume size_t fits in int.
2415
2416 * alloc.c (compact_small_strings): Tighten assertion a little.
2417
2418 Replace pEd with more-general pI, and fix some printf arg casts.
2419 * lisp.h (pI): New macro, generalizing old pEd macro to other
2420 conversion specifiers. For example, use "...%"pI"d..." rather
2421 than "...%"pEd"...".
2422 (pEd): Remove. All uses replaced with similar uses of pI.
2423 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2424 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2425 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2426 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2427 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2428 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2429 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2430 64-bit hosts.
2431 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2432 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2433 * print.c (safe_debug_print, print_object): Likewise.
2434 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2435 to int.
2436 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2437 avoiding the 0 flag, which is not portable.
2438 * process.c (Fmake_network_process): Use pI to avoid cast.
2439 * region-cache.c (pp_cache): Likewise.
2440 * xdisp.c (decode_mode_spec): Likewise.
2441 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2442 behavior on 64-bit hosts with printf arg.
2443 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2444 (x_stop_queuing_selection_requests): Likewise.
2445 (x_get_window_property): Don't truncate byte count to an 'int'
2446 when tracing.
2447
2448 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2449 here, since it parses constructs like leading '-' and spaces,
2450 which are not wanted; and it overflows with large numbers.
2451 Instead, simply match F[0-9]+, which is what is wanted anyway.
2452
2453 * alloc.c: Remove unportable assumptions about struct layout.
2454 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2455 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2456 (allocate_vectorlike, make_pure_vector): Use the new macros,
2457 plus offsetof, to remove unportable assumptions about struct layout.
2458 These assumptions hold on all porting targets that I know of, but
2459 they are not guaranteed, they're easy to remove, and removing them
2460 makes further changes easier.
2461
2462 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2463 This doesn't fix a bug but makes the code clearer.
2464 (string_overrun_cookie): Now const. Use initializers that
2465 don't formally overflow signed char, to avoid warnings.
2466 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2467 can cause Emacs to crash when string overrun checking is enabled.
2468 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2469 multiple of sizeof (EMACS_INT); it need not be, if
2470 alignof(EMACS_INT) < sizeof (EMACS_INT).
2471 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2472
2473 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2474
2475 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2476
2477 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2478
2479 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2480 supposed to be handshaking. (Bug#8556)
2481 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2482
2483 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2484
2485 * lisp.h (Qdebug): List symbol.
2486 * eval.c (Qdebug): Restore global linkage.
2487 * keyboard.c (debug-on-event): New variable.
2488 (handle_user_signal): Break into debugger when debug-on-event
2489 matches the current signal symbol.
2490
2491 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2492
2493 * alloc.c (check_sblock, check_string_bytes)
2494 (check_string_free_list): Convert to standard C.
2495
2496 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2497
2498 * w32.c (emacs_gnutls_push): Fix typo.
2499
2500 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2501
2502 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2503 "cast to pointer from integer of different size".
2504
2505 Improve doprnt and its use in verror. (Bug#8545)
2506 * doprnt.c (doprnt): Document the set of format control sequences
2507 supported by the function. Use SAFE_ALLOCA instead of always
2508 using `alloca'.
2509
2510 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2511 is one byte too soon. Don't use xrealloc; instead xfree and
2512 xmalloc anew.
2513
2514 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2515
2516 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2517 callbacks stage.
2518
2519 * gnutls.c: Renamed global_initialized to
2520 gnutls_global_initialized. Added internals for the
2521 :verify-hostname-error, :verify-error, and :verify-flags
2522 parameters of `gnutls-boot' and documented those parameters in the
2523 docstring. Start callback support.
2524 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2525 unless a fatal error occured. Call gnutls_alert_send_appropriate
2526 on error. Return error code.
2527 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2528 (emacs_gnutls_read): Likewise.
2529 (Fgnutls_boot): Return handshake error code.
2530 (emacs_gnutls_handle_error): New function.
2531 (wsaerror_to_errno): Likewise.
2532
2533 * w32.h (emacs_gnutls_pull): Add prototype.
2534 (emacs_gnutls_push): Likewise.
2535
2536 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2537 (emacs_gnutls_push): Likewise.
2538
2539 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2540
2541 * process.c (wait_reading_process_output): Check if GnuTLS
2542 buffered some data internally if no FDs are set for TLS
2543 connections.
2544
2545 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2546 (LIBS): Link to USER_LIBS.
2547 ($(BLD)/gnutls.$(0)): New target.
2548
2549 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2550
2551 * xdisp.c (handle_single_display_spec): Rename the
2552 display_replaced_before_p argument into display_replaced_p, to
2553 make it consistent with the commentary. Fix typos in the
2554 commentary.
2555
2556 * textprop.c (syms_of_textprop): Remove dead code.
2557 (copy_text_properties): Delete obsolete commentary about an
2558 interface that was deleted long ago. Fix typos in the description
2559 of arguments.
2560
2561 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2562 to changes in oldXMenu/XMenu.h from 2011-04-16.
2563 <menu_help_message, prev_menu_help_message>: Constify.
2564 (IT_menu_make_room): menu->help_text is now `const char **';
2565 adjust.
2566
2567 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2568 to changes in oldXMenu/XMenu.h from 2011-04-16.
2569 (struct XMenu): Declare `help_text' `const char **'.
2570
2571 * xfaces.c <Qunspecified>: Make extern again.
2572
2573 * syntax.c: Include sys/types.h before including regex.h, as
2574 required by Posix.
2575
2576 * doc.c (get_doc_string): Improve the format passed to `error'.
2577
2578 * doprnt.c (doprnt): Improve commentary.
2579
2580 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2581
2582 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2583 them with etags.
2584
2585 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2586 changes in globals.h immediately force recompilation.
2587 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2588 $(CURDIR)/s/ms-w32.h.
2589 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2590
2591 * character.c (Fchar_direction): Function deleted.
2592 (syms_of_character): Don't defsubr it.
2593 <char-direction-table>: Deleted.
2594
2595 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2596
2597 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2598 * doprnt.c: Include limits.h.
2599 (SIZE_MAX): New macro.
2600 (doprnt): Return a size_t value. 2nd arg is now size_t.
2601 Many local variables are now size_t instead of int or unsigned.
2602 Improve overflow protection. Support `l' modifier for integer
2603 conversions. Support %l conversion. Don't assume an EMACS_INT
2604 argument for integer conversions and for %c.
2605
2606 * lisp.h (doprnt): Restore prototype.
2607
2608 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2609 $(SRC)/character.h.
2610
2611 * Makefile.in (base_obj): Add back doprnt.o.
2612
2613 * deps.mk (doprnt.o): Add back prerequisites.
2614 (callint.o): Depend on character.h.
2615
2616 * eval.c (internal_lisp_condition_case): Include the handler
2617 representation in the error message.
2618 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2619 when breaking from the loop.
2620
2621 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2622
2623 * callint.c (Fcall_interactively): When displaying error message
2624 about invalid control letter, pass the character's codepoint, not
2625 a pointer to its multibyte form. Improve display of the character
2626 in octal and display also its hex code.
2627
2628 * character.c (char_string): Use %x to display the (unsigned)
2629 codepoint of an invalid character, to avoid displaying a bogus
2630 negative value.
2631
2632 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2633 `error', not SYMBOL_NAME itself.
2634
2635 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2636 character arguments to `error'.
2637
2638 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2639 to `error' in error message about FINAL_CHAR argument. Make sure
2640 FINAL_CHAR is a character, and use %c when it is passed as
2641 argument to `error'.
2642
2643 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2644
2645 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2646
2647 * w32.c: Include <time.h>.
2648 (sys_localtime): New function.
2649
2650 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2651
2652 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2653
2654 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2655
2656 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2657
2658 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2659 zombies (Bug#8467).
2660
2661 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2662
2663 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2664 gl_state.e_property when gl_state.object is Qt.
2665
2666 * insdel.c (make_gap_larger): Remove limitation of buffer size
2667 to <= INT_MAX.
2668
2669 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2670
2671 * xdisp.c (lookup_glyphless_char_display)
2672 (produce_glyphless_glyph): Handle cons cell entry in
2673 glyphless-char-display.
2674 (Vglyphless_char_display): Document it.
2675
2676 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2677 glyphless-char-display.
2678
2679 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2680
2681 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2682
2683 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2684
2685 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2686 definition for no-X builds.
2687
2688 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2689
2690 Static checks with GCC 4.6.0 and non-default toolkits.
2691
2692 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2693
2694 * process.c (keyboard_bit_set): Define only if SIGIO.
2695 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2696 (send_process): Repair possible setjmp clobbering.
2697
2698 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2699
2700 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2701
2702 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2703
2704 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2705 Define only if needed.
2706
2707 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2708 by pacifying GCC about it. Maybe it's time to retire it?
2709 * xfaces.c (USG, __TIMEVAL__): Likewise.
2710
2711 * dispextern.h (struct redisplay_interface): Rename param
2712 to avoid shadowing.
2713 * termhooks.h (struct terminal): Likewise.
2714 * xterm.c (xembed_send_message): Likewise.
2715
2716 * insdel.c (make_gap_smaller): Define only if
2717 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2718
2719 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2720 it.
2721
2722 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2723 so that we aren't warned about unused symbols.
2724
2725 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2726
2727 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2728
2729 * xfns.c (x_real_positions): Mark locals as initialized.
2730
2731 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2732
2733 * xterm.c: Fix problems found by static analysis with other toolkits.
2734 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2735 (x_dispatch_event): Declare static if USE_GTK, and
2736 define if USE_GTK || USE_X_TOOLKIT.
2737 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2738 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2739 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2740 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2741
2742 * xmenu.c (menu_help_callback): Pointer type fixes.
2743 Use const pointers when pointing at readonly data. Avoid pointer
2744 signedness clashes.
2745 (FALSE): Remove unused macro.
2746 (update_frame_menubar): Remove unused decl.
2747
2748 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2749
2750 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2751 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2752 (single_menu_item): Rename local to avoid shadowing.
2753
2754 * keyboard.c (make_lispy_event): Remove unused local var.
2755
2756 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2757 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2758
2759 * bitmaps: Change bitmaps from unsigned char back to the X11
2760 compatible char. Avoid the old compiler warnings about
2761 out-of-range initializers by using, for example, '\xab' rather
2762 than 0xab.
2763
2764 * xgselect.c (xgselect_initialize): Check vs interface
2765 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2766
2767 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2768
2769 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2770 to read-only memory.
2771
2772 * fns.c (vector): Remove; this old hack is no longer needed.
2773
2774 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2775 Remove unused var.
2776 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2777
2778 * xrdb.c (x_load_resources): Omit unused local.
2779
2780 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2781 (x_window): Rename locals to avoid shadowing.
2782 (USG): Use the kludged USG macro, to pacify gcc.
2783
2784 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2785 (x_term_init): Remove local to avoid shadowing.
2786
2787 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2788
2789 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2790 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2791
2792 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2793
2794 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2795
2796 Fix regex.c, syntax.c and friends for buffers > 2GB.
2797 * syntax.h (struct gl_state_s): Declare character position members
2798 EMACS_INT.
2799
2800 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2801
2802 * textprop.c (verify_interval_modification, interval_of):
2803 Declare arguments EMACS_INT.
2804
2805 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2806 EMACS_INT.
2807
2808 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2809
2810 * indent.c (Fvertical_motion): Local variable it_start is now
2811 EMACS_INT.
2812
2813 * regex.c (re_match, re_match_2, re_match_2_internal)
2814 (bcmp_translate, regcomp, regexec, print_double_string)
2815 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2816 (re_compile_pattern, re_exec): Declare arguments and local
2817 variables `size_t' and `ssize_t' and return values `regoff_t', as
2818 appropriate.
2819 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2820 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2821 <compile_stack_type>: `size' and `avail' are now `size_t'.
2822
2823 * regex.h <regoff_t>: Use ssize_t, not int.
2824 (re_search, re_search_2, re_match, re_match_2): Arguments that
2825 specify buffer/string position and length are now ssize_t and
2826 size_t. Return type is regoff_t.
2827
2828 2011-04-16 Ben Key <bkey76@gmail.com>
2829
2830 * nsfont.m: Fixed bugs in ns_get_family and
2831 ns_descriptor_to_entity that were caused by using free to
2832 deallocate memory blocks that were allocated by xmalloc (via
2833 xstrdup). This caused Emacs to crash when compiled with
2834 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2835 --enable-checking=xmallocoverrun). xfree is now used to
2836 deallocate these memory blocks.
2837
2838 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2839
2840 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2841
2842 emacs_write: Accept and return EMACS_INT for sizes.
2843 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2844 et seq.
2845 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2846 Accept and return EMACS_INT.
2847 (emacs_gnutls_write): Return the number of bytes written on
2848 partial writes.
2849 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2850 (emacs_read, emacs_write): Remove check for negative size, as the
2851 Emacs source code has been audited now.
2852 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2853 (emacs_read, emacs_write): Use it.
2854 * process.c (send_process): Adjust to the new signatures of
2855 emacs_write and emacs_gnutls_write. Do not attempt to store
2856 a byte offset into an 'int'; it might overflow.
2857 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2858
2859 * sound.c: Don't assume sizes fit in 'int'.
2860 (struct sound_device.period_size, alsa_period_size):
2861 Return EMACS_INT, not int.
2862 (struct sound_device.write, vox_write, alsa_write):
2863 Accept EMACS_INT, not int.
2864 (wav_play, au_play): Use EMACS_INT to store sizes and to
2865 record read return values.
2866
2867 2011-04-15 Ben Key <bkey76@gmail.com>
2868
2869 * keyboard.c (Qundefined): Don't declare static since it is used
2870 in nsfns.m.
2871 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2872 static since they are used in nsfont.m.
2873
2874 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2875
2876 * process.c (Qprocessp): Don't declare static.
2877 * lisp.h (Qprocessp): Declare again.
2878
2879 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2880
2881 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2882
2883 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2884
2885 Improve C-level modularity by making more things 'static'.
2886
2887 Don't publish debugger-only interfaces to other modules.
2888 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2889 (verify_bytepos, count_markers): Move decls to the only modules
2890 that need them.
2891 * region-cache.h (pp_cache): Likewise.
2892 * window.h (check_all_windows): Likewise.
2893 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2894
2895 * sysdep.c (croak): Now static, if
2896 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2897 * syssignal.h (croak): Declare only if not static.
2898
2899 * alloc.c (refill_memory_reserve): Now static if
2900 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2901 * lisp.h (refill_memory_reserve): Declare only if not static.
2902
2903 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2904 Define only if USE_LUCID.
2905
2906 * xrdb.c (x_customization_string, x_rm_string): Now static.
2907
2908 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2909 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2910
2911 * xdisp.c (draw_row_with_mouse_face): Now static.
2912 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2913
2914 * window.h (check_all_windows): Mark externally visible.
2915
2916 * window.c (window_deletion_count): Now static.
2917
2918 * undo.c: Make symbols static if they're not exported.
2919 (last_undo_buffer, last_boundary_position, pending_boundary):
2920 Now static.
2921
2922 * textprop.c (interval_insert_behind_hooks): Now static.
2923 (interval_insert_in_front_hooks): Likewise.
2924
2925 * term.c: Make symbols static if they're not exported.
2926 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2927 (max_frame_lines, tty_set_terminal_modes):
2928 (tty_reset_terminal_modes, tty_turn_off_highlight):
2929 (get_tty_terminal): Now static.
2930 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2931 * termhooks.h (term_mouse_moveto): Do not declare if
2932 HAVE_WINDOW_SYSTEM.
2933 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2934 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2935
2936 * sysdep.c: Make symbols static if they're not exported.
2937 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2938 Now static.
2939 (sigprocmask_set, full_mask): Remove; unused.
2940 (wait_debugging): Mark as visible.
2941 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2942 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2943
2944 * syntax.c (syntax_temp): Define only if !__GNUC__.
2945
2946 * sound.c (current_sound_device, current_sound): Now static.
2947
2948 * search.c (searchbufs, searchbuf_head): Now static.
2949
2950 * scroll.c (scroll_cost): Remove; unused.
2951 * dispextern.h (scroll_cost): Remove decl.
2952
2953 * region-cache.h (pp_cache): Mark as externally visible.
2954
2955 * process.c: Make symbols static if they're not exported.
2956 (process_tick, update_tick, create_process, chan_process):
2957 (Vprocess_alist, proc_buffered_char, datagram_access):
2958 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2959 (deactivate_process): Mark defn as static, as well as decl.
2960 * lisp.h (create_process): Remove decl.
2961 * process.h (chan_process, Vprocess_alist): Remove decls.
2962
2963 * print.c: Make symbols static if they're not exported.
2964 (print_depth, new_backquote_output, being_printed, print_buffer):
2965 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2966 (print_interval, print_number_index, initial_stderr_stream):
2967 Now static.
2968 * lisp.h (Fprinc): Remove decl.
2969 (debug_output_compilation_hack): Mark as externally visible.
2970
2971 * sysdep.c (croak): Move decl from here to syssignal.h.
2972 * syssignal.h (croak): Put it here, so the API can be checked when
2973 'croak' is called from dissociate_if_controlling_tty.
2974
2975 * minibuf.c: Make symbols static if they're not exported.
2976 (minibuf_save_list, choose_minibuf_frame): Now static.
2977 * lisp.h (choose_minibuf_frame): Remove decl.
2978
2979 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2980
2981 * lread.c: Make symbols static if they're not exported.
2982 (read_objects, initial_obarray, oblookup_last_bucket_number):
2983 Now static.
2984 (make_symbol): Remove; unused.
2985 * lisp.h (initial_obarray, make_symbol): Remove decls.
2986
2987 * keyboard.c: Make symbols static if they're not exported.
2988 (single_kboard, recent_keys_index, total_keys, recent_keys):
2989 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2990 (this_single_command_key_start, echoing, last_auto_save):
2991 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2992 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2993 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2994 (Vlispy_mouse_stem, double_click_count):
2995 Now static.
2996 (force_auto_save_soon): Define only if SIGDANGER.
2997 (ignore_mouse_drag_p): Now static if
2998 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2999 (print_help): Remove; unused.
3000 (stop_character, last_timer_event): Mark as externally visible.
3001 * keyboard.h (ignore_mouse_drag_p): Declare only if
3002 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3003 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3004 * lisp.h (echoing): Remove decl.
3005 (force_auto_save_soon): Declare only if SIGDANGER.
3006 * xdisp.c (redisplay_window): Simplify code, to make it more
3007 obvious that ignore_mouse_drag_p is not accessed if !defined
3008 USE_GTK && !defined HAVE_NS.
3009
3010 * intervals.c: Make symbols static if they're not exported.
3011 (merge_properties_sticky, merge_interval_right, delete_interval):
3012 Now static.
3013 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3014
3015 * insdel.c: Make symbols static if they're not exported.
3016 However, leave prepare_to_modify_buffer alone. It's never
3017 called from outside this function, but that appears to be a bug.
3018 (combine_after_change_list, combine_after_change_buffer):
3019 (adjust_after_replace, signal_before_change): Now static.
3020 (adjust_after_replace_noundo): Remove; unused.
3021 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3022 (signal_before_change): Remove decls.
3023
3024 * indent.c (val_compute_motion, val_vmotion): Now static.
3025
3026 * image.c: Make symbols static if they're not exported.
3027 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3028 if USE_GTK.
3029 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3030 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3031
3032 * fringe.c (standard_bitmaps): Now static.
3033 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3034
3035 * frame.c: Make symbols static if they're not exported.
3036 (x_report_frame_params, make_terminal_frame): Now static.
3037 (get_frame_param): Now static, unless HAVE_NS.
3038 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3039 (x_get_resource_string): Remove; not used.
3040 * frame.h (make_terminal_frame, x_report_frame_params):
3041 (x_get_resource_string); Remove decls.
3042 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3043 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3044
3045 * font.c, fontset.c: Make symbols static if they're not exported.
3046 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3047 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3048 * font.c (font_close_object): Now static.
3049 * font.h (font_close_object): Remove.
3050 * fontset.c (FONTSET_OBJLIST): Remove.
3051 (free_realized_fontset) #if-0 the body, which does nothing.
3052 (face_suitable_for_char_p): #if-0, as it's never called.
3053 * fontset.h (face_suitable_for_char_p): Remove decl.
3054 * xfaces.c (face_at_string_position):
3055 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3056 since 0 is always ASCII.
3057
3058 * fns.c (weak_hash_tables): Now static.
3059
3060 * fileio.c: Make symbols static if they're not exported.
3061 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3062 (Vwrite_region_annotation_buffers): Now static.
3063
3064 * eval.c: Make symbols static if they're not exported.
3065 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3066 * lisp.h (backtrace_list): Remove decl.
3067
3068 * emacs.c: Make symbols static if they're not exported.
3069 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3070 (fatal_error_code, fatal_error_signal_hook, standard_args):
3071 Now static.
3072 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3073 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3074 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3075 * lisp.h (fatal_error_signal_hook): Remove decl.
3076 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3077
3078 * editfns.c: Move a (normally-unused) function to its only use.
3079 * editfns.c, lisp.h (get_operating_system_release): Remove.
3080 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3081 worth the hassle of breaking this out.
3082
3083 * xterm.c: Make symbols static if they're not exported.
3084 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3085 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3086 (x_destroy_window, x_delete_display):
3087 Now static.
3088 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3089 (x_mouse_leave): Remove; unused.
3090 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3091 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3092 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3093 Remove decls.
3094 (x_mouse_leave): Declare only if WINDOWSNT.
3095 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3096 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3097 USE_X_TOOLKIT.
3098
3099 * ftxfont.c: Make symbols static if they're not exported.
3100 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3101 HAVE_FREETYPE.
3102 * font.h (ftxfont_driver): Likewise.
3103
3104 * xfns.c: Make symbols static if they're not exported.
3105 (x_last_font_name, x_display_info_for_name):
3106 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3107 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3108 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3109 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3110 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3111 (last_show_tip_args): Now static.
3112 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3113 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3114 (x_screen_planes): Remove; unused.
3115 * dispextern.h (x_screen_planes): Remove decl.
3116
3117 * dispnew.c: Make symbols static if they're not exported.
3118 * dispextern.h (redraw_garbaged_frames, scrolling):
3119 (increment_row_positions): Remove.
3120 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3121 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3122 Now static.
3123 (redraw_garbaged_frames): Remove; unused.
3124
3125 * xfaces.c: Make symbols static if they're not exported.
3126 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3127 Remove decls.
3128 * xterm.h (defined_color): Remove decls.
3129 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3130 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3131 (menu_face_changed_default, defined_color, free_realized_face):
3132 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3133 (ascii_face_of_lisp_face): Remove; unused.
3134
3135 * xdisp.c: Make symbols static if they're not exported.
3136 * dispextern.h (scratch_glyph_row, window_box_edges):
3137 (glyph_to_pixel_coords, set_cursor_from_row):
3138 (get_next_display_element, set_iterator_to_next):
3139 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3140 (show_mouse_face): Remove decls
3141 * frame.h (message_buf_print): Likewise.
3142 * lisp.h (pop_message, set_message, check_point_in_composition):
3143 Likewise.
3144 * xterm.h (set_vertical_scroll_bar): Likewise.
3145 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3146 (message_buf_print, scratch_glyph_row, displayed_buffer):
3147 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3148 (get_next_display_element, show_mouse_face, window_box_edges):
3149 (frame_to_window_pixel_xy, check_point_in_composition):
3150 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3151 (glyph_to_pixel_coords): Remove; unused.
3152
3153 * dired.c (file_name_completion): Now static.
3154
3155 * dbusbind.c (xd_in_read_queued_messages): Now static.
3156
3157 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3158 * data.c (circular_list_error): Remove.
3159
3160 * commands.h (last_point_position, last_point_position_buffer):
3161 (last_point_position_window): Remove decls.
3162 * keyboard.c: Make these variables static.
3163
3164 * coding.h (coding, code_convert_region, encode_coding_gap):
3165 Remove decls.
3166 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3167 (iso_code_class, detect_coding, code_convert_region): Now static.
3168 (encode_coding_gap): Remove; unused.
3169
3170 * chartab.c (chartab_chars, chartab_bits): Now static.
3171
3172 * charset.h (charset_iso_8859_1): Remove decl.
3173 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3174 Now static.
3175
3176 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3177 * ccl.c (Vccl_program_table): Now static.
3178 (check_ccl_update): Remove; unused.
3179
3180 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3181 * category.h: ... from here.
3182 * category.c (check_category_table, set_category_set): Now static.
3183
3184 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3185 * lisp.h: Remove these decls.
3186
3187 * buffer.c (buffer_count): Remove unused var.
3188
3189 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3190 so that it's not optimized away.
3191 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3192 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3193 exported only to the debugger.
3194
3195 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3196 * atimer.h (run_all_atimers): Remove; not exported.
3197
3198 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3199 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3200 was inaccessible from Lisp.
3201 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3202 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3203
3204 alloc.c: Import and export fewer symbols, and remove unused items.
3205 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3206 is defined.
3207 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3208 it's not optimized away by whole-program optimization.
3209 (message_enable_multibyte, free_misc): Remove.
3210 (catchlist, handlerlist, mark_backtrace):
3211 Declare only if BYTE_MARK_STACK.
3212 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3213 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3214 (message_enable_multibyte): Remove decl.
3215 (free_misc, interval_free_list, float_block, float_block_index):
3216 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3217 (cons_free_list, last_marked_index):
3218 Now static.
3219 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3220 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3221 (mark_backtrace): Define only if BYTE_MARK_STACK.
3222 * xdisp.c (message_enable_multibyte): Now static.
3223
3224 Declare Lisp_Object Q* variables to be 'static' if not exported.
3225 This makes it easier for human readers (and static analyzers)
3226 to see whether these variables are used from other modules.
3227 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3228 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3229 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3230 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3231 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3232 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3233 * xmenu.c, xselect.c:
3234 Declare Q* vars static if they are not used in other modules.
3235 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3236 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3237 Remove decls of unexported vars.
3238 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3239
3240 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3241
3242 Make Emacs functions such as Fatom 'static' by default.
3243 This makes it easier for human readers (and static analyzers)
3244 to see whether these functions can be called from other modules.
3245 DEFUN now defines a static function. To make the function external
3246 so that it can be used in other C modules, use the new macro DEFUE.
3247 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3248 (Finit_image_library):
3249 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3250 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3251 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3252 Remove decls, since these functions are now static.
3253 (Funintern, Fget_internal_run_time): New decls, since these functions
3254 were already external.
3255
3256 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3257 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3258 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3259 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3260 * keyboard.c, keymap.c, lread.c:
3261 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3262 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3263 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3264 Mark functions with DEFUE instead of DEFUN,
3265 if they are used in other modules.
3266 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3267 decls for now-static functions.
3268 * buffer.h (Fdelete_overlay): Remove decl.
3269 * callproc.c (Fgetenv_internal): Mark as internal.
3270 * composite.c (Fremove_list_of_text_properties): Remove decl.
3271 (Fcomposition_get_gstring): New forward static decl.
3272 * composite.h (Fcomposite_get_gstring): Remove decl.
3273 * dired.c (Ffile_attributes): New forward static decl.
3274 * doc.c (Fdocumntation_property): New forward static decl.
3275 * eval.c (Ffetch_bytecode): New forward static decl.
3276 (Funintern): Remove extern decl; now in .h file where it belongs.
3277 * fileio.c (Fmake_symbolic_link): New forward static decl.
3278 * image.c (Finit_image_library): New forward static decl.
3279 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3280 * intervals.h (Fprevious_property_change):
3281 (Fremove_list_of_text_properties): Remove decls.
3282 * keyboard.c (Fthis_command_keys): Remove decl.
3283 (Fcommand_execute): New forward static decl.
3284 * keymap.c (Flookup_key): New forward static decl.
3285 (Fcopy_keymap): Now static.
3286 * keymap.h (Flookup_key): Remove decl.
3287 * process.c (Fget_process): New forward static decl.
3288 (Fprocess_datagram_address): Mark as internal.
3289 * syntax.c (Fsyntax_table_p): New forward static decl.
3290 (skip_chars): Remove duplicate decl.
3291 * textprop.c (Fprevious_property_change): New forward static decl.
3292 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3293 Now internal.
3294 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3295 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3296
3297 * editfns.c (Fformat): Remove unreachable code.
3298
3299 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3300
3301 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3302 change. (Bug#8496)
3303
3304 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3305
3306 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3307 when at ZV. (Bug#8487)
3308
3309 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3310
3311 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3312 (Bug#8437)
3313 * keyboard.c (parse_tool_bar_item): Likewise.
3314 * sound.c (sound_cleanup, alsa_close): Likewise.
3315 * termcap.c (tgetent): Likewise.
3316 * xfns.c (x_default_font_parameter): Likewise.
3317 * xsettings.c (read_and_apply_settings): Likewise.
3318
3319 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3320 (overrun_check_free): Protoize.
3321
3322 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3323
3324 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3325 since callers should never pass a negative size.
3326 Change the signature to match that of plain 'read' and 'write'; see
3327 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3328 * lisp.h: Update prototypes of emacs_write and emacs_read.
3329
3330 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3331
3332 * xdisp.c (redisplay_window): Don't try to determine the character
3333 position of the scroll margin if the window start point w->startp
3334 is outside the buffer's accessible region. (Bug#8468)
3335
3336 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3337
3338 Fix write-region and its subroutines for buffers > 2GB.
3339 * fileio.c (a_write, e_write): Modify declaration of arguments and
3340 local variables to support buffers larger than 2GB.
3341 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3342
3343 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3344 argument, local variables, and return value.
3345
3346 * lisp.h: Update prototypes of emacs_write and emacs_read.
3347
3348 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3349
3350 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3351
3352 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3353
3354 Fix more problems found by GCC 4.6.0's static checks.
3355
3356 * xdisp.c (vmessage): Use a better test for character truncation.
3357
3358 * charset.c (load_charset_map): <, not <=, for optimization,
3359 and to avoid potential problems with integer overflow.
3360 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3361 * casetab.c (set_identity, shuffle): Likewise.
3362 * editfns.c (Fformat): Likewise.
3363 * syntax.c (skip_chars): Likewise.
3364
3365 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3366 This also lets GCC 4.6.0 generate slightly better loop code.
3367
3368 * callint.c (Fcall_interactively): <, not <=, for optimization.
3369 (Fcall_interactively): Count the number of arguments produced,
3370 not the number of arguments given. This is simpler and lets GCC
3371 4.6.0 generate slightly better code.
3372
3373 * ftfont.c: Distingish more carefully between FcChar8 and char.
3374 The previous code passed unsigned char * to a functions like
3375 strlen and xstrcasecmp that expect char *, which does not
3376 conform to the C standard.
3377 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3378 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3379 char * when the C standard requires it.
3380
3381 * keyboard.c (read_char): Remove unused var.
3382
3383 * eval.c: Port to Windows vsnprintf (Bug#8435).
3384 Include <limits.h>.
3385 (SIZE_MAX): Define if the headers do not.
3386 (verror): Do not give up if vsnprintf returns a negative count.
3387 Instead, grow the buffer. This ports to Windows vsnprintf, which
3388 does not conform to C99. Problem reported by Eli Zaretskii.
3389 Also, simplify the allocation scheme, by avoiding the need for
3390 calling realloc, and removing the ALLOCATED variable.
3391
3392 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3393
3394 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3395 But keep the doprint source code for now, as we might revamp it
3396 and use it again (Bug#8435).
3397 * lisp.h (doprnt): Remove.
3398 * Makefile.in (base_obj): Remove doprnt.o.
3399 * deps.mk (doprnt.o): Remove.
3400
3401 error: Print 32- and 64-bit integers portably (Bug#8435).
3402 Without this change, on typical 64-bit hosts error ("...%d...", N)
3403 was used to print both 32- and 64-bit integers N, which relied on
3404 undefined behavior.
3405 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3406 New macro.
3407 * lisp.h (error, verror): Mark as printf-like functions.
3408 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3409 Report overflow in size calculations when allocating printf buffer.
3410 Do not truncate output string at its first null byte.
3411 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3412 Truncate the output at a character boundary, since vsnprintf does not
3413 do that.
3414 * charset.c (check_iso_charset_parameter): Convert internal
3415 character to string before calling 'error', since %c now has the
3416 printf meaning.
3417 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3418 overflow when computing char to be passed to 'error'. Do not
3419 pass Lisp_Object to 'error'; pass the integer instead.
3420 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3421 formatted with plain %d.
3422
3423 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3424
3425 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3426
3427 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3428
3429 * xterm.c (x_catch_errors): Remove duplicate declaration.
3430
3431 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3432
3433 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3434
3435 2011-04-10 Jim Meyering <meyering@redhat.com>
3436
3437 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3438 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3439 return ssize_t not "int", and use size_t as the buffer length.
3440 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3441 * gnutls.h: Update declarations.
3442 * process.c (read_process_output): Use ssize_t, to match.
3443 (send_process): Likewise.
3444
3445 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3446
3447 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3448
3449 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3450
3451 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3452 Use unsigned char, to match FcChar8 type definition.
3453
3454 * xterm.c (handle_one_xevent):
3455 * xmenu.c (create_and_show_popup_menu):
3456 * xselect.c (x_decline_selection_request)
3457 (x_reply_selection_request): Avoid type-punned deref of X events.
3458
3459 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3460
3461 Fix some uses of `int' instead of EMACS_INT.
3462 * search.c (string_match_1, fast_string_match)
3463 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3464 (scan_buffer, find_next_newline_no_quit)
3465 (find_before_next_newline, search_command, Freplace_match)
3466 (Fmatch_data): Make some `int' variables be EMACS_INT.
3467
3468 * xdisp.c (display_count_lines): 3rd argument and return value now
3469 EMACS_INT. All callers changed.
3470 (pint2hrstr): Last argument is now EMACS_INT.
3471
3472 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3473 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3474 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3475 (decode_coding_utf_16, decode_coding_emacs_mule)
3476 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3477 (decode_coding_ccl, decode_coding_charset)
3478 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3479 (decode_coding_iso_2022, decode_coding_emacs_mule)
3480 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3481 <char_offset, last_offset>: Declare EMACS_INT.
3482 (encode_coding_utf_8, encode_coding_utf_16)
3483 (encode_coding_emacs_mule, encode_invocation_designation)
3484 (encode_designation_at_bol, encode_coding_iso_2022)
3485 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3486 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3487 Declare EMACS_INT.
3488 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3489 (encode_invocation_designation): Last argument P_NCHARS is now
3490 EMACS_INT.
3491 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3492 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3493
3494 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3495 All users changed.
3496
3497 * ccl.c (Fccl_execute_on_string): Declare some variables
3498 EMACS_INT.
3499
3500 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3501
3502 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3503
3504 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3505
3506 * process.c (Fformat_network_address): Doc fix.
3507
3508 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3509
3510 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3511
3512 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3513
3514 * keyboard.c (read_char): Call Lisp function help-form-show,
3515 instead of using internal_with_output_to_temp_buffer.
3516 (Qhelp_form_show): New var.
3517 (syms_of_keyboard): Use DEFSYM macro.
3518
3519 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3520
3521 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3522
3523 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3524
3525 * process.c (Flist_processes): Remove to Lisp.
3526 (list_processes_1): Delete.
3527
3528 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3529
3530 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3531
3532 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3533
3534 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3535
3536 Fix more problems found by GCC 4.6.0's static checks.
3537
3538 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3539
3540 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3541
3542 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3543
3544 * xdisp.c (vmessage): Mark as a printf-like function.
3545
3546 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3547
3548 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3549
3550 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3551 printf-like functions.
3552 (tiff_load): Add casts to remove these marks before passing them
3553 to system-supplied API.
3554
3555 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3556
3557 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3558 This avoids several warnings with gcc -Wstrict-overflow.
3559 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3560 directly, rather than having caller test rule sign. This avoids
3561 some unnecessary tests.
3562 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3563 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3564 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3565
3566 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3567 (xfont_open): Avoid unnecessary tests.
3568
3569 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3570
3571 * composite.h, composite.c (composition_gstring_put_cache):
3572 Use EMACS_INT, not int, for length.
3573
3574 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3575 breaking out part of COMPOSITION_DECODE_RULE.
3576 (COMPOSITION_DECODE_RULE): Use it.
3577 * composite.c (get_composition_id): Remove unused local vars,
3578 by using the new macro.
3579
3580 * textprop.c (set_text_properties_1): Change while to do-while,
3581 since the condition is always true at first.
3582
3583 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3584 (interval_deletion_adjustment): Return unsigned value.
3585 All uses changed.
3586
3587 * process.c (list_processes_1, create_pty, read_process_output):
3588 (exec_sentinel): Remove vars that were set but not used.
3589 (create_pty): Remove unnecessary "volatile"s.
3590 (Fnetwork_interface_info): Avoid possibility of int overflow.
3591 (read_process_output): Do adaptive read buffering even if carryover.
3592 (read_process_output): Simplify nbytes computation if buffered.
3593
3594 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3595
3596 * syntax.c (scan_words): Remove var that was set but not used.
3597 (update_syntax_table): Use unsigned instead of int.
3598
3599 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3600 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3601 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3602
3603 * print.c (print_error_message): Avoid int overflow.
3604
3605 * font.c (font_list_entities): Redo for clarity,
3606 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3607
3608 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3609 (font_score): Avoid potential overflow in diff calculation.
3610
3611 * fns.c (substring_both): Remove var that is set but not used.
3612 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3613
3614 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3615
3616 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3617 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3618 can always succeed if overflow has undefined behavior.
3619
3620 * search.c (boyer_moore, wordify): Remove vars set but not used.
3621 (wordify): Omit three unnecessary tests.
3622
3623 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3624 All callers changed. This avoids the need for an unused var.
3625
3626 * casefiddle.c (casify_region): Remove var that is set but not used.
3627
3628 * dired.c (file_name_completion): Remove var that is set but not used.
3629
3630 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3631
3632 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3633 (Finsert_file_contents): Remove unnecessary code checking fd.
3634
3635 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3636 Check for integer overflow on size calculations.
3637
3638 * buffer.c (Fprevious_overlay_change): Remove var that is set
3639 but not used.
3640
3641 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3642 Remove vars that are set but not used.
3643 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3644 (timer_check_2): Mark vars as initialized.
3645
3646 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3647
3648 * image.c (lookup_image): Remove var that is set but not used.
3649 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3650
3651 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3652 that are set but not used.
3653
3654 * xfns.c (make_invisible_cursor): Don't return garbage
3655 if XCreateBitmapFromData fails (Bug#8410).
3656
3657 * xselect.c (x_get_local_selection, x_handle_property_notify):
3658 Remove vars that are set but not used.
3659
3660 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3661 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3662
3663 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3664 Remove var that is set but not used.
3665 (scroll_bar_windows_size): Now size_t, not int.
3666 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3667 Check for overflow.
3668
3669 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3670 (map_tty_color) [!defined MSDOS]: Likewise.
3671
3672 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3673
3674 * coding.c: Remove vars that are set but not used.
3675 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3676 All callers changed.
3677 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3678 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3679 (decode_coding_charset): Remove vars that are set but not used.
3680
3681 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3682 that is set but not used.
3683
3684 * print.c (print_object): Remove var that is set but not used.
3685
3686 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3687 The gnulib version avoids calling malloc in the usual case,
3688 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3689 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3690 * filelock.c (current_lock_owner): Likewise.
3691 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3692 * sysdep.c: Include allocator.h, careadlinkat.h.
3693 (emacs_no_realloc_allocator): New static constant.
3694 (emacs_readlink): New function.
3695 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3696 ../lib/careadlinkat.h.
3697
3698 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3699
3700 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3701 first non-nil return value).
3702
3703 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3704
3705 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3706 if not defined (Bug#8403).
3707
3708 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3709
3710 * xdisp.c (display_count_lines): Remove parameter `start',
3711 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3712 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3713 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3714 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3715 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3716 and thereabouts. All callers changed.
3717 (get_per_char_metric): Remove parameter `f', unused since
3718 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3719
3720 2011-04-02 Jim Meyering <meyering@redhat.com>
3721
3722 do not dereference NULL upon failed strdup
3723 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3724 (ns_get_family): Likewise.
3725
3726 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3727
3728 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3729
3730 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3731
3732 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3733 later (Bug#8403).
3734
3735 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3736
3737 Add lexical binding.
3738
3739 * window.c (Ftemp_output_buffer_show): New fun.
3740 (Fsave_window_excursion):
3741 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3742
3743 * lread.c (lisp_file_lexically_bound_p): New function.
3744 (Fload): Bind Qlexical_binding.
3745 (readevalloop): Remove `evalfun' arg.
3746 Bind Qinternal_interpreter_environment.
3747 (Feval_buffer): Bind Qlexical_binding.
3748 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3749 Mark as dynamic.
3750 (syms_of_lread): Declare `lexical-binding'.
3751
3752 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3753
3754 * keyboard.c (eval_dyn): New fun.
3755 (menu_item_eval_property): Use it.
3756
3757 * image.c (parse_image_spec): Use Ffunctionp.
3758
3759 * fns.c (concat, mapcar1): Accept byte-code-functions.
3760
3761 * eval.c (Fsetq): Handle lexical vars.
3762 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3763 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3764 (FletX, Flet): Obey lexical binding.
3765 (Fcommandp): Handle closures.
3766 (Feval): New `lexical' arg.
3767 (eval_sub): New function extracted from Feval. Use it almost
3768 everywhere where Feval was used. Look up vars in lexical env.
3769 Handle closures.
3770 (Ffunctionp): Move from subr.el.
3771 (Ffuncall): Handle closures.
3772 (apply_lambda): Remove `eval_flags'.
3773 (funcall_lambda): Handle closures and new byte-code-functions.
3774 (Fspecial_variable_p): New function.
3775 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3776 but without exporting it to Lisp.
3777
3778 * doc.c (Fdocumentation, store_function_docstring):
3779 * data.c (Finteractive_form): Handle closures.
3780
3781 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3782 interactive spec.
3783
3784 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3785 New byte-codes.
3786 (exec_byte_code): New function extracted from Fbyte_code to handle new
3787 calling convention for byte-code-functions. Add new byte-codes.
3788
3789 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3790
3791 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3792
3793 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3794
3795 * xdisp.c (redisplay_internal): Fix prototype.
3796
3797 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3798
3799 * xdisp.c (SCROLL_LIMIT): New macro.
3800 (try_scrolling): Use it when setting scroll_limit.
3801 Limit scrolling to 100 screen lines.
3802 (redisplay_window): Even when falling back on "recentering",
3803 position point in the window according to scroll-conservatively,
3804 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3805
3806 (try_scrolling): When point is above the window, allow searching
3807 as far as scroll_max, or one screenful, to compute vertical
3808 distance from PT to the scroll margin position. This prevents
3809 try_scrolling from unnecessarily failing when
3810 scroll-conservatively is set to a value slightly larger than the
3811 window height. Clean up the case of PT below the margin at bottom
3812 of window: scroll_max can no longer be INT_MAX. When aggressive
3813 scrolling is in use, don't let point enter the opposite scroll
3814 margin as result of the scroll.
3815 (syms_of_xdisp) <scroll-conservatively>: Document the
3816 threshold of 100 lines for never-recentering scrolling.
3817
3818 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3819
3820 * dispextern.h (move_it_by_lines):
3821 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3822 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3823 (message_log_check_duplicate): Remove parameters `prev_bol' and
3824 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3825 (redisplay_internal): Remove parameter `preserve_echo_area',
3826 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3827
3828 * indent.c (Fvertical_motion):
3829 * window.c (window_scroll_pixel_based, Frecenter):
3830 Don't pass `need_y_p' to `move_it_by_lines'.
3831
3832 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3833
3834 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3835 steal a few bits to be more compact.
3836 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3837 Remove unneeded casts.
3838
3839 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3840
3841 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3842
3843 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3844 binding" message (bug#7967).
3845
3846 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3847
3848 Fix more problems found by GCC 4.6.0's static checks.
3849
3850 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3851 Remove unused local var.
3852
3853 * editfns.c (Fmessage_box): Remove unused local var.
3854
3855 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3856 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3857 Omit unused local vars.
3858 * window.c (shrink_windows): Omit unused local var.
3859 * menu.c (digest_single_submenu): Omit unused local var.
3860 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3861 Omit unused local var.
3862
3863 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3864 Don't assume string length fits in int.
3865 (keyremap_step, read_key_sequence): Use size_t for sizes.
3866 (read_key_sequence): Don't check last_real_key_start redundantly.
3867
3868 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3869 instead of alloca (Bug#8344).
3870
3871 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3872 (Fbacktrace_frame): Don't assume nframes fits in int.
3873
3874 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3875
3876 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3877 concerns.
3878
3879 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3880
3881 * cm.c (calccost): Turn while-do into do-while, for clarity.
3882
3883 * keyboard.c (syms_of_keyboard): Use the same style as later
3884 in this function when indexing through an array. This also
3885 works around GCC bug 48267.
3886
3887 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3888
3889 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3890
3891 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3892 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3893
3894 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3895 This avoids undefined behavior on integer overflow, and is a bit
3896 more convenient anyway since it is compared to a size_t variable.
3897
3898 Variadic C functions now count arguments with size_t, not int.
3899 This avoids an unnecessary limitation on 64-bit machines, which
3900 caused (substring ...) to crash on large vectors (Bug#8344).
3901 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3902 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3903 All variadic functions and their callers changed accordingly.
3904 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3905 * data.c (arith_driver, float_arith_driver): Likewise.
3906 * editfns.c (general_insert_function): Likewise.
3907 * eval.c (struct backtrace.nargs, interactive_p)
3908 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3909 (funcall_lambda, mark_backtrace): Likewise.
3910 * fns.c (concat): Likewise.
3911 * frame.c (x_set_frame_parameters): Likewise.
3912 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3913 0 if not found, not -1. All callers changed.
3914
3915 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3916 (stack_copy_size): Now size_t, not int.
3917 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3918
3919 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3920
3921 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3922 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3923 All callers changed.
3924
3925 * lisp.h (multibyte_char_to_unibyte):
3926 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3927 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3928 * character.h (CHAR_TO_BYTE8):
3929 * cmds.c (internal_self_insert):
3930 * editfns.c (general_insert_function):
3931 * keymap.c (push_key_description):
3932 * search.c (Freplace_match):
3933 * xdisp.c (message_dolog, set_message_1): All callers changed.
3934
3935 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3936
3937 * keyboard.c (safe_run_hook_funcall): New function.
3938 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3939 don't set the hook to nil, but remove the offending function instead.
3940 (Qcommand_hook_internal): Remove, unused.
3941 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3942 Vcommand_hook_internal.
3943
3944 * eval.c (enum run_hooks_condition): Remove.
3945 (funcall_nil, funcall_not): New functions.
3946 (run_hook_with_args): Call each function through a `funcall' argument.
3947 Remove `cond' argument, now redundant.
3948 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3949 (Frun_hook_with_args_until_failure): Adjust accordingly.
3950 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3951
3952 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3953
3954 * dispextern.h (string_buffer_position): Remove declaration.
3955
3956 * print.c (strout): Remove parameter `multibyte', unused since
3957 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3958
3959 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3960 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3961 All callers changed.
3962
3963 * w32.c (_wsa_errlist): Use braces for struct initializers.
3964
3965 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3966 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3967 All callers changed.
3968 (string_buffer_position): Likewise. Also, make static (it's never
3969 used outside xdisp.c).
3970 (cursor_row_p): Remove parameter `w', unused since
3971 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3972 (decode_mode_spec): Remove parameter `precision', introduced during
3973 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3974 All callers changed.
3975
3976 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3977
3978 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3979
3980 2011-03-27 Anders Lindgren <andlind@gmail.com>
3981
3982 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3983 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3984 (ns_update_auto_hide_menu_bar): New functions.
3985 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3986 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3987 ns_constrain_all_frames.
3988 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3989 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3990
3991 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3992
3993 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3994
3995 2011-03-27 Glenn Morris <rgm@gnu.org>
3996
3997 * syssignal.h: Replace RETSIGTYPE with void.
3998 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3999 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4000 Replace SIGTYPE with void everywhere.
4001 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4002 * s/template.h (SIGTYPE): Remove commented out definition.
4003
4004 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4005
4006 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4007 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4008
4009 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4010
4011 * w32.c (read_unc_volume): Use parameter `henum', instead of
4012 global variable `wget_enum_handle'.
4013
4014 * keymap.c (describe_vector): Remove parameters `indices' and
4015 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4016 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4017
4018 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4019
4020 * keyboard.c (timer_check): Remove parameter `do_it_now',
4021 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4022 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4023 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4024
4025 * keyboard.c (read_char):
4026 * w32menu.c (w32_menu_display_help):
4027 * xmenu.c (show_help_event, menu_help_callback):
4028 Adjust calls to `show_help_echo'.
4029
4030 * gtkutil.c (xg_maybe_add_timer):
4031 * keyboard.c (readable_events):
4032 * process.c (wait_reading_process_output):
4033 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4034
4035 * insdel.c (adjust_markers_gap_motion):
4036 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4037 (gap_left, gap_right): Don't call it.
4038
4039 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4040
4041 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4042 incurred during fontification.
4043
4044 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4045
4046 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4047 (DEFVAR_PER_BUFFER): Don't pass it.
4048
4049 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4050 (scrolling_window): Don't pass it.
4051
4052 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4053
4054 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4055
4056 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4057 and `suffix'.
4058 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4059 of variables specific to SELinux and computation of `encoded_absname'.
4060
4061 * image.c (XPutPixel): Remove unused variable `height'.
4062
4063 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4064
4065 * unexw32.c (get_section_info): Remove unused variable `section'.
4066
4067 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4068 (system_process_attributes): Remove unused variable `sess'.
4069 (sys_read): Remove unused variable `err'.
4070
4071 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4072 (w32_wnd_proc): Remove unused variable `isdead'.
4073 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4074 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4075 (x_create_tip_frame): Remove unused variable `tem'.
4076
4077 * w32inevt.c (w32_console_read_socket):
4078 Remove unused variable `no_events'.
4079
4080 * w32term.c (x_draw_composite_glyph_string_foreground):
4081 Remove unused variable `width'.
4082
4083 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4084
4085 * w32term.c (x_set_glyph_string_clipping):
4086 Don't pass uninitialized region to CombineRgn.
4087
4088 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4089
4090 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4091 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4092 (Fx_close_connection): Remove unused variable `i'.
4093
4094 * w32font.c (w32font_draw): Return number of glyphs.
4095 (w32font_open_internal): Remove unused variable `i'.
4096 (w32font_driver): Add missing initializer.
4097
4098 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4099 (fill_in_menu): Remove unused variable `items_added'.
4100
4101 * w32term.c (last_mouse_press_frame): Remove static global variable.
4102 (w32_clip_to_row): Remove unused variable `f'.
4103 (x_delete_terminal): Remove unused variable `i'.
4104
4105 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4106 (NOTHING): Remove unused static global variable.
4107 (uniscribe_check_otf): Remove unused variable `table'.
4108 (uniscribe_font_driver): Add missing initializers.
4109
4110 2011-03-23 Julien Danjou <julien@danjou.info>
4111
4112 * term.c (Fsuspend_tty, Fresume_tty):
4113 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4114 * window.c (temp_output_buffer_show):
4115 * insdel.c (signal_before_change):
4116 * frame.c (Fhandle_switch_frame):
4117 * fileio.c (Fdo_auto_save):
4118 * emacs.c (Fkill_emacs):
4119 * editfns.c (save_excursion_restore):
4120 * cmds.c (internal_self_insert):
4121 * callint.c (Fcall_interactively):
4122 * buffer.c (Fkill_all_local_variables):
4123 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4124 Use Frun_hooks.
4125 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4126 unconditionnaly since it does the check itself.
4127
4128 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4129
4130 Fix more problems found by GCC 4.5.2's static checks.
4131
4132 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4133 the first time through the loop, since we know p0 < p1 then.
4134 This also avoids a gcc -Wstrict-overflow warning.
4135
4136 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4137 leading to a memory leak, possible in functions like
4138 load_charset_map_from_file that can allocate an unbounded number
4139 of objects (Bug#8318).
4140
4141 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4142 that could (at least in theory) be that large.
4143
4144 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4145 This is less likely to overflow, and avoids undefined behavior if
4146 overflow does occur. All callers changed. Use strtoul to scan
4147 for the unsigned long integer.
4148 (pint2hrstr): Simplify and tune code slightly.
4149 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4150
4151 * scroll.c (do_scrolling): Work around GCC bug 48228.
4152 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4153
4154 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4155 This also avoids a warning with gcc -Wstrict-overflow.
4156 (validate_x_resource_name): Simplify count usage.
4157 This also avoids a warning with gcc -Wstrict-overflow.
4158
4159 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4160 fail (Bug#8306).
4161
4162 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4163
4164 * process.c (Fmake_network_process): Use socklen_t, not int,
4165 where POSIX says socklen_t is required in portable programs.
4166 This fixes a porting bug on hosts like 64-bit HP-UX, where
4167 socklen_t is wider than int (Bug#8277).
4168 (Fmake_network_process, server_accept_connection):
4169 (wait_reading_process_output, read_process_output):
4170 Likewise.
4171
4172 * process.c: Rename or move locals to avoid shadowing.
4173 (list_processes_1, Fmake_network_process):
4174 (read_process_output_error_handler, exec_sentinel_error_handler):
4175 Rename or move locals.
4176 (Fmake_network_process): Define label "retry_connect" only if needed.
4177 (Fnetwork_interface_info): Fix pointer signedness.
4178 (process_send_signal): Add cast to avoid pointer signedness problem.
4179 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4180 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4181
4182 Make tparam.h and terminfo.c consistent.
4183 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4184 Include tparam.h instead, since it declares them.
4185 * cm.h (PC): Remove extern decl; tparam.h now does this.
4186 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4187 * terminfo.c: Include tparam.h, to check interfaces.
4188 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4189 (tparam): Adjust signature to match interface in tparam.h;
4190 this removes some undefined behavior. Check that outstring and len
4191 are zero, which they always are with Emacs.
4192 * tparam.h (PC, BC, UP): New extern decls.
4193
4194 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4195 (xftfont_open): Rename locals to avoid shadowing.
4196
4197 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4198 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4199 (OTF_TAG_SYM): Omit macro if not needed.
4200 (ftfont_list): Remove unused local.
4201 (get_adstyle_property, ftfont_pattern_entity):
4202 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4203 Rename locals to avoid shadowing.
4204
4205 * xfont.c (xfont_list_family): Mark var as initialized.
4206
4207 * xml.c (make_dom): Now static.
4208
4209 * composite.c (composition_compute_stop_pos): Rename local to
4210 avoid shadowing.
4211 (composition_reseat_it): Remove unused locals.
4212 (find_automatic_composition, composition_adjust_point): Likewise.
4213 (composition_update_it): Mark var as initialized.
4214 (find_automatic_composition): Mark vars as initialized,
4215 with a FIXME (Bug#8290).
4216
4217 character.h: Rename locals to avoid shadowing.
4218 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4219 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4220 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4221 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4222 to avoid shadowing.
4223
4224 * textprop.c (property_change_between_p): Remove; unused.
4225
4226 * intervals.c (interval_start_pos): Now static.
4227
4228 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4229
4230 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4231 Rename locals to avoid shadowing.
4232
4233 * sound.c (wav_play, au_play, Fplay_sound_internal):
4234 Fix pointer signedness.
4235 (alsa_choose_format): Remove unused local var.
4236 (wav_play): Initialize a variable to 0, to prevent undefined
4237 behavior (Bug#8278).
4238
4239 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4240
4241 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4242
4243 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4244 clobbering (Bug#8298).
4245 * sysdep.c (sys_subshell): Likewise.
4246 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4247
4248 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4249 This should get cleaned up, so that child_setup has the
4250 same signature on all platforms.
4251
4252 * callproc.c (call_process_cleanup): Now static.
4253 (relocate_fd): Rename locals to avoid shadowing.
4254
4255 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4256
4257 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4258 not to be necessary, and produces flickering.
4259
4260 2011-03-20 Glenn Morris <rgm@gnu.org>
4261
4262 * config.in: Remove file.
4263
4264 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4265
4266 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4267 are now in src/globals.h.
4268 (syms_of_minibuf): Remove spurious & from previous change.
4269
4270 2011-03-20 Leo <sdl.web@gmail.com>
4271
4272 * minibuf.c (completing-read-function): New variable.
4273 (completing-read-default): Rename from completing-read.
4274 (completing-read): Call completing-read-function.
4275
4276 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4277
4278 * xfaces.c (Fx_load_color_file):
4279 Read color file from absolute filename (bug#8250).
4280
4281 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4282
4283 * makefile.w32-in: Update dependencies.
4284
4285 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4286
4287 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4288
4289 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4290
4291 Fix more problems found by GCC 4.5.2's static checks.
4292
4293 * process.c (make_serial_process_unwind, send_process_trap):
4294 (sigchld_handler): Now static.
4295
4296 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4297 That way, the code declares only the vars that it needs.
4298 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4299 * s/cygwin.h (PTY_ITERATION): Likewise.
4300 * s/darwin.h (PTY_ITERATION): Likewise.
4301 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4302
4303 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4304 * process.c (allocate_pty): Don't declare stb unless it's needed.
4305
4306 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4307 (CONSTANTLIM): Remove; unused.
4308 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4309 Define only if needed.
4310
4311 * unexelf.c (unexec): Name an expression,
4312 to avoid gcc -Wbad-function-cast warning.
4313 Use a different way to cause a compilation error if anyone uses
4314 n rather than nn, a way that does not involve shadowing.
4315 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4316
4317 * deps.mk (unexalpha.o): Remove; unused.
4318
4319 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4320 * unexec.h: New file.
4321 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4322 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4323 Depend on unexec.h.
4324 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4325 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4326 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4327 Change as necessary to match prototype in unexec.h.
4328
4329 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4330 shadowing.
4331 (back_comment, skip_chars): Mark vars as initialized.
4332
4333 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4334 Rename locals to avoid shadowing.
4335
4336 * lread.c (read1): Rewrite so as not to use empty "else".
4337 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4338
4339 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4340
4341 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4342 warning when compiling print.c.
4343
4344 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4345 instead of using an uninitialized var.
4346 (font_sort_entities): Mark var as initialized.
4347
4348 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4349
4350 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4351 pointers to constants.
4352 (font_parse_fcname): Remove unused vars.
4353 (font_delete_unmatched): Now static.
4354 (font_get_spec): Remove; unused.
4355 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4356 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4357 Rename or move locals to avoid shadowing.
4358
4359 * fns.c (require_nesting_list, require_unwind): Now static.
4360 (Ffillarray): Rename locals to avoid shadowing.
4361
4362 * floatfns.c (domain_error2): Define only if needed.
4363 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4364
4365 * alloc.c (mark_backtrace): Move decl from here ...
4366 * lisp.h: ... to here, so that it can be checked.
4367
4368 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4369 (Fdefvar): Rewrite so as not to use empty "else".
4370 (lisp_indirect_variable): Name an expression,
4371 to avoid gcc -Wbad-function-cast warning.
4372 (Fdefvar): Rename locals to avoid shadowing.
4373
4374 * callint.c (quotify_arg, quotify_args): Now static.
4375 (Fcall_interactively): Rename locals to avoid shadowing.
4376 Use const pointer when appropriate.
4377
4378 * lisp.h (get_system_name, get_operating_system_release):
4379 Move decls here, to check interfaces.
4380 * process.c (get_operating_system_release): Move decl to lisp.h.
4381 * xrdb.c (get_system_name): Likewise.
4382 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4383 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4384 some of which prompt warnings from gcc -Wbad-function-cast.
4385 (Fformat_time_string, Fencode_time, Finsert_char):
4386 (Ftranslate_region_internal, Fformat):
4387 Rename or remove local vars to avoid shadowing.
4388 (Ftranslate_region_internal): Mark var as initialized.
4389
4390 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4391 avoid shadowing.
4392
4393 * lisp.h (eassert): Check that the argument compiles, even if
4394 ENABLE_CHECKING is not defined.
4395
4396 * data.c (Findirect_variable): Name an expression, to avoid
4397 gcc -Wbad-function-cast warning.
4398 (default_value, arithcompare, arith_driver, arith_error): Now static.
4399 (store_symval_forwarding): Rename local to avoid shadowing.
4400 (Fmake_variable_buffer_local, Fmake_local_variable):
4401 Mark variables as initialized.
4402 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4403
4404 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4405 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4406 Rename locals to avoid shadowing.
4407 (mark_stack): Move local variables into the #ifdef region where
4408 they're used.
4409 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4410 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4411 needed otherwise.
4412 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4413 (GC_STRING_CHARS): Remove; not used.
4414 (Fmemory_limit): Cast sbrk's returned value to char *.
4415
4416 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4417 avoids undefined behavior in theory.
4418
4419 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4420
4421 Use functions, not macros, for up- and down-casing (Bug#8254).
4422 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4423 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4424 to use the following functions instead of these macros.
4425 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4426 EMACS_INT, since callers assume the returned value fits in int.
4427 (upcase1): Likewise, for UPCASE_TABLE.
4428 (uppercasep, lowercasep, upcase): New static inline functions.
4429 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4430 the race-condition problem in the old DOWNCASE.
4431
4432 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4433 Rename locals to avoid shadowing.
4434 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4435 (regex_compile, re_search_2, re_match_2_internal):
4436 Remove unused local vars.
4437 (FREE_VAR): Rewrite so as not to use empty "else",
4438 which gcc can warn about.
4439 (regex_compile, re_match_2_internal): Mark locals as initialized.
4440 (RETALLOC_IF): Define only if needed.
4441 (WORDCHAR_P): Likewise. This one is never needed, but is used
4442 only in a comment talking about a compiler bug, so put inside
4443 the #if 0 of that comment.
4444 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4445 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4446 Remove; unused.
4447
4448 * search.c (boyer_moore): Rename locals to avoid shadowing.
4449 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4450 (PREV_CHAR_BOUNDARY): Likewise.
4451
4452 * search.c (simple_search): Remove unused var.
4453
4454 * dired.c (compile_pattern): Move decl from here ...
4455 * lisp.h: ... to here, so that it can be checked.
4456 (struct re_registers): New forward decl.
4457
4458 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4459
4460 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4461 All uses changed.
4462 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4463 Rename locals to avoid shadowing.
4464 (Fvertical_motion): Mark locals as initialized.
4465
4466 * casefiddle.c (casify_object, casify_region): Now static.
4467 (casify_region): Mark local as initialized.
4468
4469 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4470
4471 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4472 New macros, so that the caller can use some names other than
4473 gcpro1, gcpro2, etc.
4474 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4475 of the new macros.
4476 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4477 argument, for consistency with GCPRO2_VAR, etc: it is now the
4478 prefix of the variable, not the variable itself. All uses
4479 changed.
4480 * dired.c (directory_files_internal, file_name_completion):
4481 Rename locals to avoid shadowing.
4482
4483 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4484 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4485 dired.c's scmp function, had undefined behavior.
4486 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4487 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4488 * buffer.h: ... to here, because these macros use current_buffer,
4489 and the new implementation with inline functions needs to have
4490 current_buffer in scope now, rather than later when the macros
4491 are used.
4492 (downcase, upcase1): New static inline functions.
4493 (DOWNCASE, UPCASE1): Reimplement using these functions.
4494 This avoids undefined behavior in expressions like
4495 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4496 from race conditions in accessing the global variables
4497 case_temp1 and case_temp2.
4498 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4499 * lisp.h (case_temp1, case_temp2): Remove their decls.
4500 * character.h (ASCII_CHAR_P): Move from here ...
4501 * lisp.h: ... to here, so that the inline functions mentioned
4502 above can use them.
4503
4504 * dired.c (directory_files_internal_unwind): Now static.
4505
4506 * fileio.c (file_name_as_directory, directory_file_name):
4507 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4508 Now static.
4509 (file_name_as_directory): Use const pointers when appropriate.
4510 (Fexpand_file_name): Likewise. In particular, newdir might
4511 point at constant storage, so make it a const pointer.
4512 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4513 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4514 signedness issues.
4515 (Fset_file_times, Finsert_file_contents, auto_save_error):
4516 Rename locals to avoid shadowing.
4517
4518 * minibuf.c (choose_minibuf_frame_1): Now static.
4519 (Ftry_completion, Fall_completions): Rename or remove locals
4520 to avoid shadowing.
4521
4522 * marker.c (bytepos_to_charpos): Remove; unused.
4523
4524 * lisp.h (verify_bytepos, count_markers): New decls,
4525 so that gcc does not warn that these functions aren't declared.
4526
4527 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4528 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4529 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4530 (copy_text): Remove unused local var.
4531
4532 * filelock.c (within_one_second): Now static.
4533 (lock_file_1): Rename local to avoid shadowing.
4534
4535 * buffer.c (fix_overlays_before): Mark locals as initialized.
4536 (fix_start_end_in_overlays): Likewise. This function should be
4537 simplified by using pointers-to-pointers, but that's a different
4538 matter.
4539 (switch_to_buffer_1): Now static.
4540 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4541 (report_overlay_modification): Rename locals to avoid shadowing.
4542
4543 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4544 Fix pointer signedness issue.
4545 (sys_subshell): Mark local as volatile if checking for lint,
4546 to suppress a gcc -Wclobbered warning that does not seem to be right.
4547 (MAXPATHLEN): Define only if needed.
4548
4549 * process.c (serial_open, serial_configure): Move decls from here ...
4550 * systty.h: ... to here, so that they can be checked.
4551
4552 * fns.c (get_random, seed_random): Move extern decls from here ...
4553 * lisp.h: ... to here, so that they can be checked.
4554
4555 * sysdep.c (reset_io): Now static.
4556 (wait_for_termination_signal): Remove; unused.
4557
4558 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4559 (copy_keymap_item, append_key, push_text_char_description):
4560 Now static.
4561 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4562 (DENSE_TABLE_SIZE): Remove; unused.
4563 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4564 (describe_map_tree):
4565 Rename locals to avoid shadowing.
4566
4567 * keyboard.c: Declare functions static if they are not used elsewhere.
4568 (echo_char, echo_dash, cmd_error, top_level_2):
4569 (poll_for_input, handle_async_input): Now static.
4570 (read_char, kbd_buffer_get_event, make_lispy_position):
4571 (make_lispy_event, make_lispy_movement, apply_modifiers):
4572 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4573 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4574 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4575 (read_key_sequence, read_char): Mark locals as initialized.
4576 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4577
4578 * keyboard.h (make_ctrl_char): New decl.
4579 (mark_kboards): Move decl here ...
4580 * alloc.c (mark_kboards): ... from here.
4581
4582 * lisp.h (force_auto_save_soon): New decl.
4583
4584 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4585 (DEFINE_DUMMY_FUNCTION): New macro.
4586 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4587 Use it.
4588 (main): Add casts to avoid warnings
4589 if GCC considers string literals to be constants.
4590
4591 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4592
4593 * dbusbind.c: Pointer signedness fixes.
4594 (xd_signature, xd_append_arg, xd_initialize):
4595 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4596 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4597 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4598 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4599
4600 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4601 if GCC considers string literals to be constants.
4602 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4603
4604 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4605
4606 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4607 (print_preprocess, print_object): New macro to fix last change.
4608
4609 * print.c (print_preprocess): Don't forget font objects.
4610
4611 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4612
4613 * emacs.c (USAGE3): Doc fixes.
4614
4615 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4616
4617 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4618 structure.
4619
4620 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4621
4622 * lisp.h (VWindow_system, Qfile_name_history):
4623 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4624 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4625 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4626
4627 * w32select.c: Don't #include "keyboard.h".
4628 (run_protected): Add extern declaration for waiting_for_input.
4629
4630 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4631 * w32console.c (detect_input_pending, read_input_pending)
4632 (encode_terminal_code):
4633 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4634 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4635 (w32_system_caret_y, Qfile_name_history):
4636 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4637 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4638 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4639 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4640 * w32proc.c (Qlocal, report_file_error):
4641 * w32term.c (Vwindow_system, updating_frame):
4642 * w32uniscribe.c (initialized, uniscribe_font_driver):
4643 Remove unneeded extern declarations.
4644
4645 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4646
4647 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4648
4649 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4650
4651 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4652 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4653 These macros can no longer be used for assignment.
4654
4655 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4656 Assign struct members directly, instead of using BUF_BEGV etc.
4657 (record_buffer_markers, fetch_buffer_markers): New functions for
4658 recording and fetching special buffer markers.
4659 (set_buffer_internal_1, set_buffer_temp): Use them.
4660
4661 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4662
4663 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4664
4665 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4666 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4667
4668 * xdisp.c (hscroll_window_tree):
4669 (reconsider_clip_changes): Use PT instead of BUF_PT.
4670
4671 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4672
4673 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4674 $(EMACS_ROOT)/lib/intprops.h.
4675
4676 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4677
4678 Fix more problems found by GCC 4.5.2's static checks.
4679
4680 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4681 to unsigned char * to avoid compiler diagnostic.
4682 (xg_free_frame_widgets): Make it clear that a local variable is
4683 needed only if USE_GTK_TOOLTIP.
4684 (gdk_window_get_screen): Make it clear that this macro is needed
4685 only if USE_GTK_TOOLTIP.
4686 (int_gtk_range_get_value): New function, which avoids a diagnostic
4687 from gcc -Wbad-function-cast.
4688 (xg_set_toolkit_scroll_bar_thumb): Use it.
4689 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4690 diagnostic from gcc -Wbad-function-cast.
4691 (get_utf8_string, xg_get_file_with_chooser):
4692 Rename locals to avoid shadowing.
4693 (create_dialog): Move locals to avoid shadowing.
4694
4695 * xgselect.c (xg_select): Remove unused var.
4696
4697 * image.c (four_corners_best): Mark locals as initialized.
4698 (gif_load): Initialize transparent_p to zero (Bug#8238).
4699 Mark another local as initialized.
4700 (my_png_error, my_error_exit): Mark with NO_RETURN.
4701
4702 * image.c (clear_image_cache): Now static.
4703 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4704 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4705 (x_edge_detection): Remove unnecessary cast that
4706 gcc -Wbad-function-cast diagnoses.
4707 (gif_load): Fix pointer signedness.
4708 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4709 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4710
4711 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4712
4713 Improve quality of tests for time stamp overflow.
4714 For example, without this patch (encode-time 0 0 0 1 1
4715 1152921504606846976) returns the obviously-bogus value (-948597
4716 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4717 reports time overflow. See
4718 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4719 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4720 * editfns.c: Include limits.h and intprops.h.
4721 (TIME_T_MIN, TIME_T_MAX): New macros.
4722 (time_overflow): Move earlier, to before first use.
4723 (hi_time, lo_time): New functions, for an accurate test for
4724 out-of-range times.
4725 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4726 (Fget_internal_run_time): Don't assume time_t fits in int.
4727 (make_time): Use list2 instead of Fcons twice.
4728 (Fdecode_time): More accurate test for out-of-range times.
4729 (check_tm_member): New function.
4730 (Fencode_time): Use it, to test for out-of-range times.
4731 (lisp_time_argument): Don't rely on undefined left-shift and
4732 right-shift behavior when checking for time stamp overflow.
4733
4734 * editfns.c (time_overflow): New function, refactoring common code.
4735 (Fformat_time_string, Fdecode_time, Fencode_time):
4736 (Fcurrent_time_string): Use it.
4737
4738 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4739 * dired.c (make_time): Move to ...
4740 * editfns.c (make_time): ... here.
4741 * systime.h: Note the move.
4742
4743 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4744
4745 * fringe.c (update_window_fringes): Remove unused variables.
4746
4747 * unexmacosx.c (copy_data_segment): Also copy __got section.
4748 (Bug#8223)
4749
4750 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4751
4752 * termcap.c [MSDOS]: Include "msdos.h".
4753 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4754 Constify `char *' arguments and their references according to
4755 prototypes in tparam.h.
4756
4757 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4758
4759 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4760 Adapt all references accordingly.
4761
4762 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4763
4764 2011-03-11 Tom Tromey <tromey@redhat.com>
4765
4766 * buffer.c (syms_of_buffer): Remove obsolete comment.
4767
4768 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4769
4770 * termhooks.h (encode_terminal_code): Declare prototype.
4771
4772 * msdos.c (encode_terminal_code): Don't declare prototype.
4773
4774 * term.c (encode_terminal_code): Now external again, used by
4775 w32console.c and msdos.c.
4776
4777 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4778 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4779
4780 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4781
4782 Fix some minor problems found by GCC 4.5.2's static checks.
4783
4784 * fringe.c (update_window_fringes): Mark locals as initialized
4785 (Bug#8227).
4786 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4787
4788 * alloc.c (mark_fringe_data): Move decl from here ...
4789 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4790 to check its interface.
4791 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4792
4793 * fontset.c (free_realized_fontset): Now static.
4794 (Fset_fontset_font): Rename local to avoid shadowing.
4795 (fontset_font): Mark local as initialized.
4796 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4797
4798 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4799
4800 * xselect.c (x_disown_buffer_selections): Remove; not used.
4801 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4802 (x_own_selection, Fx_disown_selection_internal): Rename locals
4803 to avoid shadowing.
4804 (x_handle_dnd_message): Remove local to avoid shadowing.
4805
4806 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4807 so that the caller can use some name other than gcpro1.
4808 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4809 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4810 (Fx_backspace_delete_keys_p):
4811 Use them to avoid shadowing, and rename vars to avoid shadowing.
4812 (x_decode_color, x_set_name, x_window): Now static.
4813 (Fx_create_frame): Add braces to silence GCC warning.
4814 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4815 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4816 Remove unused locals.
4817 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4818 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4819 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4820 macros.
4821
4822 * xterm.h (x_mouse_leave): New decl.
4823
4824 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4825 Remove unused functions.
4826 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4827 (x_calc_absolute_position): Now static.
4828 (XTread_socket): Don't define label "out" unless it's used.
4829 Don't declare local "event" unless it's used.
4830 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4831 unless they are used.
4832 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4833 (x_fatal_error_signal): Remove; not used.
4834 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4835 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4836 (x_error_catcher, x_connection_closed, x_error_handler):
4837 (x_error_quitter, xembed_send_message, x_iconify_frame):
4838 (my_log_handler): Rename locals to avoid shadowing.
4839 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4840 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4841
4842 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4843 Rename or move locals to avoid shadowing.
4844 (tty_defined_color, merge_face_heights): Now static.
4845 (free_realized_faces_for_fontset): Remove; not used.
4846 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4847 does not deduce is never used uninitialized.
4848 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4849 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4850
4851 * terminal.c (store_terminal_param): Now static.
4852
4853 * xmenu.c (menu_highlight_callback): Now static.
4854 (set_frame_menubar): Remove unused local.
4855 (xmenu_show): Rename parameter to avoid shadowing.
4856 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4857 since they might point to immutable storage.
4858 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4859 since it's unused otherwise.
4860
4861 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4862 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4863 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4864 avoids a gcc -Wuninitialized diagnostic.
4865 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4866 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4867 does not deduce are never used uninitialized.
4868
4869 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4870
4871 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4872 * window.c (window_loop, size_window):
4873 (run_window_configuration_change_hook, enlarge_window): Likewise.
4874
4875 * window.c (display_buffer): Now static.
4876 (size_window): Mark variables that gcc -Wuninitialized
4877 does not deduce are never used uninitialized.
4878 * window.h (check_all_windows): New decl, to forestall
4879 gcc -Wmissing-prototypes diagnostic.
4880 * dispextern.h (bidi_dump_cached_states): Likewise.
4881
4882 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4883 shadowing.
4884 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4885 Include <limits.h>.
4886 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4887 and to avoid gcc -Wuninitialized warning.
4888 (load_charset_map): Mark variables that gcc -Wuninitialized
4889 does not deduce are never used uninitialized.
4890 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4891
4892 * coding.c (coding_set_source, coding_set_destination):
4893 Use "else { /* comment */ }" rather than "else /* comment */;"
4894 for clarity, and to avoid gcc -Wempty-body warning.
4895 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4896 a block, when the outer 'i' will do.
4897 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4898 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4899 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4900 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4901 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4902 Rename locals to avoid shadowing.
4903 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4904 * coding.c (emacs_mule_char, encode_invocation_designation):
4905 Now static, since they're not used elsewhere.
4906 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4907 (decode_coding_object, encode_coding_object, detect_coding_system):
4908 (decode_coding_emacs_mule): Mark variables that gcc
4909 -Wuninitialized does not deduce are never used uninitialized.
4910 (detect_coding_iso_2022): Initialize a local variable that might
4911 be used uninitialized. Leave a FIXME because it's not clear that
4912 this initialization is needed. (Bug#8211)
4913 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4914 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4915 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4916 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4917 Remove unused macros.
4918
4919 * category.c (hash_get_category_set): Remove unused local var.
4920 (copy_category_table): Now static, since it's not used elsewhere.
4921 * character.c (string_count_byte8): Likewise.
4922
4923 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4924 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4925
4926 * chartab.c (copy_sub_char_table): Now static, since it's not used
4927 elsewhere.
4928 (sub_char_table_ref_and_range, char_table_ref_and_range):
4929 Rename locals to avoid shadowing.
4930 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4931
4932 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4933 (BIDI_BOB): Remove unused macro.
4934
4935 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4936 deduce are never used uninitialized.
4937 * term.c (encode_terminal_code): Likewise.
4938
4939 * term.c (encode_terminal_code): Now static. Remove unused local.
4940
4941 * tparam.h: New file.
4942 * term.c, tparam.h: Include it.
4943 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4944 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4945 Move these decls to tparam.h, and make them agree with what
4946 is actually in tparam.c. The previous trick of using incompatible
4947 decls in different modules does not conform to the C standard.
4948 All callers of tparam changed to use tparam's actual API.
4949 * tparam.c (tparam1, tparam, tgoto):
4950 Use const pointers where appropriate.
4951
4952 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4953 * cm.h (struct cm): Likewise.
4954 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4955 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4956 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4957 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4958 (turn_on_face, init_tty): Likewise.
4959 * termchar.h (struct tty_display_info): Likewise.
4960
4961 * term.c (term_mouse_position): Rename local to avoid shadowing.
4962
4963 * alloc.c (mark_ttys): Move decl from here ...
4964 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4965
4966 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4967
4968 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4969
4970 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4971
4972 * search.c (compile_pattern_1): Remove argument regp, unused since
4973 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4974 (compile_pattern): Don't pass it.
4975
4976 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4977
4978 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4979 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4980 for ! HAVE_GTK3.
4981 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4982
4983 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4984
4985 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4986 gdk_window_get_screen, gdk_window_get_geometry,
4987 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4988 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4989 (xg_get_pixbuf_from_pixmap): New function.
4990 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4991 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4992 Call xg_get_pixbuf_from_pixmap instead of
4993 gdk_pixbuf_get_from_drawable.
4994 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4995 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4996 (xg_check_special_colors): Use GtkStyleContext and its functions
4997 for HAVE_GTK3.
4998 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4999 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5000 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5001 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5002 Call gtk_widget_get_preferred_size.
5003 (xg_frame_resized): gdk_window_get_geometry only takes 5
5004 parameters.
5005 (xg_win_to_widget, xg_event_is_for_menubar):
5006 Call gdk_x11_window_lookup_for_display.
5007 (xg_set_widget_bg): New function.
5008 (delete_cb): New function.
5009 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5010 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5011 (xg_set_background_color): Call xg_set_widget_bg.
5012 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5013 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5014 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5015 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5016 if ! HAVE_GTK3.
5017 (update_frame_tool_bar): Call gtk_widget_hide.
5018 (xg_initialize): Use GDK_KEY_g.
5019
5020 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5021 if ! HAVE_GTK3
5022 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5023
5024 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5025 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5026 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5027
5028 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5029
5030 * w32xfns.c (select_palette): Check success of RealizePalette against
5031 GDI_ERROR, not zero.
5032
5033 See ChangeLog.11 for earlier changes.
5034
5035 ;; Local Variables:
5036 ;; coding: utf-8
5037 ;; End:
5038
5039 Copyright (C) 2011 Free Software Foundation, Inc.
5040
5041 This file is part of GNU Emacs.
5042
5043 GNU Emacs is free software: you can redistribute it and/or modify
5044 it under the terms of the GNU General Public License as published by
5045 the Free Software Foundation, either version 3 of the License, or
5046 (at your option) any later version.
5047
5048 GNU Emacs is distributed in the hope that it will be useful,
5049 but WITHOUT ANY WARRANTY; without even the implied warranty of
5050 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5051 GNU General Public License for more details.
5052
5053 You should have received a copy of the GNU General Public License
5054 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.