* keymap.c (access_keymap_1): Now static.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2
3 * keymap.c (access_keymap_1): Now static.
4
5 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6
7 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8 leave any prefix arg for the up event (Bug#1586).
9
10 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
11
12 * lread.c (syms_of_lread): Mention single symbols defined by
13 `defvar' or `defconst' (bug#7154).
14
15 * fns.c (Frequire): Mention .el.gz files (bug#7314).
16 (Frequire): Mention get-load-suffixes.
17
18 2011-07-02 Martin Rudalics <rudalics@gmx.at>
19
20 * window.h (window): Remove clone_number slot.
21 * window.c (Fwindow_clone_number, Fset_window_clone_number):
22 Remove.
23 (make_parent_window, make_window, saved_window)
24 (Fset_window_configuration, save_window_save): Don't deal with
25 clone numbers.
26 * buffer.c (Qclone_number): Remove declaration.
27 (sort_overlays, overlay_strings): Don't deal with clone numbers.
28
29 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
30
31 Add multiple inheritance to keymaps.
32 * keymap.c (Fmake_composed_keymap): New function.
33 (Fset_keymap_parent): Simplify.
34 (fix_submap_inheritance): Remove.
35 (access_keymap_1): New function extracted from access_keymap to handle
36 embedded parents and handle lists of maps.
37 (access_keymap): Use it.
38 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
39 (Fcopy_keymap): Handle embedded parents.
40 (Fcommand_remapping, define_as_prefix): Simplify.
41 (Fkey_binding): Simplify.
42 (syms_of_keymap): Move minibuffer-local-completion-map,
43 minibuffer-local-filename-completion-map,
44 minibuffer-local-must-match-map, and
45 minibuffer-local-filename-must-match-map to Elisp.
46 (syms_of_keymap): Defsubr make-composed-keymap.
47 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
48 (parse_menu_item): Trivial simplification.
49
50 2011-07-01 Glenn Morris <rgm@gnu.org>
51
52 * Makefile.in (SETTINGS_LIBS): Fix typo.
53
54 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
55
56 * coding.c (Fencode_coding_string): Record the last coding system
57 used, as the function doc string says (bug#8738).
58
59 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
60
61 * xsettings.c (store_monospaced_changed): Take new font as arg and
62 check for change against current_mono_font.
63 (EMACS_TYPE_SETTINGS): Remove this and related defines.
64 (emacs_settings_constructor, emacs_settings_get_property)
65 (emacs_settings_set_property, emacs_settings_class_init)
66 (emacs_settings_init, gsettings_obj): Remove.
67 (something_changedCB): New function for HAVE_GSETTINGS.
68 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
69 with value as argument.
70 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
71 g_settings_new (Bug#8967). Do not create gsettings_obj.
72 Remove calls to g_settings_bind. Connect something_changedCB to
73 "changed".
74
75 * xgselect.c: Add defined (HAVE_GSETTINGS).
76 (xgselect_initialize): Ditto.
77
78 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
79 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
80 xg_select.
81
82 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
83
84 * eval.c (struct backtrace): Simplify and port the data structure.
85 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
86 signed bit field, as this assumption is not portable and it makes
87 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
88 "char debug_on_exit : 1" as this is not portable either; instead,
89 use the portable "unsigned int debug_on_exit : 1". Remove unused
90 member evalargs. Remove obsolete comments about cc bombing out.
91
92 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
93
94 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
95 Let HAVE_GSETTINGS override HAVE_GCONF.
96 (store_monospaced_changed): New function.
97 (EMACS_SETTINGS): A new type derived from GObject to handle
98 GSettings notifications.
99 (emacs_settings_constructor, emacs_settings_get_property)
100 (emacs_settings_set_property, emacs_settings_class_init):
101 New functions.
102 (gsettings_client, gsettings_obj): New variables.
103 (GSETTINGS_SCHEMA): New define.
104 (something_changedCB): Call store_monospaced_changed.
105 (init_gsettings): New function.
106 (xsettings_initialize): Call init_gsettings.
107 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
108 to NULL.
109
110 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
111 GCONF_CFLAGS/LIBS.
112
113 2011-06-29 Martin Rudalics <rudalics@gmx.at>
114
115 * window.c (resize_root_window, grow_mini_window)
116 (shrink_mini_window): Rename Qresize_root_window to
117 Qwindow_resize_root_window and Qresize_root_window_vertically to
118 Qwindow_resize_root_window_vertically.
119
120 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
121
122 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
123
124 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
125
126 * makefile.w32-in: Redesign dependencies so they reflect more
127 clearly which files are directly included by each source file,
128 and not through other includes.
129
130 2011-06-27 Martin Rudalics <rudalics@gmx.at>
131
132 * buffer.c (Qclone_number): Declare static and DEFSYM it.
133 (sort_overlays, overlay_strings): When an overlay's clone number
134 matches the window's clone number process the overlay even if
135 the overlay's window property doesn't match the current window.
136
137 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
138 (Fwindow_hchild): Rename to Fwindow_left_child.
139 (Fwindow_next): Rename to Fwindow_next_sibling.
140 (Fwindow_prev): Rename to Fwindow_prev_sibling.
141 (resize_window_check): Rename to window_resize_check.
142 (resize_window_apply): Rename to window_resize_apply.
143 (Fresize_window_apply): Rename to Fwindow_resize_apply.
144 (Fdelete_other_windows_internal, resize_frame_windows)
145 (Fsplit_window_internal, Fdelete_window_internal)
146 (grow_mini_window, shrink_mini_window)
147 (Fresize_mini_window_internal): Fix callers accordingly.
148
149 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
150
151 * emacsgtkfixed.h: State that this is only used with Gtk+3.
152 (emacs_fixed_set_min_size): Remove.
153 (emacs_fixed_new): Take frame as argument.
154
155 * emacsgtkfixed.c: State that this is only used with Gtk+3.
156 (_EmacsFixedPrivate): Remove minwidth/height.
157 Add struct frame *f.
158 (emacs_fixed_init): Initialize priv->f.
159 (get_parent_class, emacs_fixed_set_min_size): Remove.
160 (emacs_fixed_new): Set priv->f to argument.
161 (emacs_fixed_get_preferred_width)
162 (emacs_fixed_get_preferred_height): Use min_width/height from
163 frames size_hint to set minimum and natural (Bug#8919).
164 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
165 and use min_width/height from frames size_hint to set
166 min_width/height (Bug#8919).
167
168 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
169 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
170 indentation.
171
172 2011-06-26 Eli Zaretskii <eliz@gnu.org>
173
174 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
175 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
176 called at ZV.
177
178 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
179
180 * process.c (wait_reading_process_output): Bypass select if
181 waiting for a cell while ignoring keyboard input, and input is
182 pending. Suggested by Jan Djärv (Bug#8869).
183
184 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
185
186 Use gnulib's dup2 module instead of rolling our own.
187 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
188
189 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
190
191 * dispnew.c (scrolling_window): Before scrolling, turn off a
192 mouse-highlight in the window being scrolled.
193
194 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
195
196 Move DEFSYM to lisp.h and use everywhere.
197
198 * character.h (DEFSYM): Move declaration...
199 * lisp.h (DEFSYM): ...here.
200
201 * gnutls.c:
202 * minibuf.c:
203 * w32menu.c:
204 * w32proc.c:
205 * w32select.c: Don't include character.h.
206
207 * alloc.c (syms_of_alloc):
208 * buffer.c (syms_of_buffer):
209 * bytecode.c (syms_of_bytecode):
210 * callint.c (syms_of_callint):
211 * casefiddle.c (syms_of_casefiddle):
212 * casetab.c (init_casetab_once):
213 * category.c (init_category_once, syms_of_category):
214 * ccl.c (syms_of_ccl):
215 * cmds.c (syms_of_cmds):
216 * composite.c (syms_of_composite):
217 * dbusbind.c (syms_of_dbusbind):
218 * dired.c (syms_of_dired):
219 * dispnew.c (syms_of_display):
220 * doc.c (syms_of_doc):
221 * editfns.c (syms_of_editfns):
222 * emacs.c (syms_of_emacs):
223 * eval.c (syms_of_eval):
224 * fileio.c (syms_of_fileio):
225 * fns.c (syms_of_fns):
226 * frame.c (syms_of_frame):
227 * fringe.c (syms_of_fringe):
228 * insdel.c (syms_of_insdel):
229 * keymap.c (syms_of_keymap):
230 * lread.c (init_obarray, syms_of_lread):
231 * macros.c (syms_of_macros):
232 * msdos.c (syms_of_msdos):
233 * print.c (syms_of_print):
234 * process.c (syms_of_process):
235 * search.c (syms_of_search):
236 * sound.c (syms_of_sound):
237 * syntax.c (init_syntax_once, syms_of_syntax):
238 * terminal.c (syms_of_terminal):
239 * textprop.c (syms_of_textprop):
240 * undo.c (syms_of_undo):
241 * w32.c (globals_of_w32):
242 * window.c (syms_of_window):
243 * xdisp.c (syms_of_xdisp):
244 * xfaces.c (syms_of_xfaces):
245 * xfns.c (syms_of_xfns):
246 * xmenu.c (syms_of_xmenu):
247 * xsettings.c (syms_of_xsettings):
248 * xterm.c (syms_of_xterm): Use DEFSYM.
249
250 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
251
252 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
253
254 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
255
256 Integer and buffer overflow fixes (Bug#8873).
257
258 * print.c (printchar, strout): Check for string overflow.
259 (PRINTPREPARE, printchar, strout):
260 Don't set size unless allocation succeeds.
261
262 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
263 for sizes. Check for string overflow more accurately.
264 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
265
266 * macros.c: Integer and buffer overflow fixes.
267 * keyboard.h (struct keyboard.kbd_macro_bufsize):
268 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
269 Use ptrdiff_t, not int, for sizes.
270 Don't increment bufsize until after realloc succeeds.
271 Check for size-calculation overflow.
272 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
273
274 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
275
276 * lread.c: Integer overflow fixes.
277 (read_integer): Radix is now EMACS_INT, not int,
278 to improve quality of diagnostics for out-of-range radices.
279 Calculate buffer size correctly for out-of-range radices.
280 (read1): Check for integer overflow in radices, and in
281 read-circle numbers.
282 (read_escape): Avoid int overflow.
283 (Fload, openp, read_buffer_size, read1)
284 (substitute_object_recurse, read_vector, read_list, map_obarray):
285 Use ptrdiff_t, not int, for sizes.
286 (read1): Use EMACS_INT, not int, for sizes.
287 Check for size overflow.
288
289 * image.c (cache_image): Check for size arithmetic overflow.
290
291 * lread.c: Integer overflow issues.
292 (saved_doc_string_size, saved_doc_string_length)
293 (prev_saved_doc_string_size, prev_saved_doc_string_length):
294 Now ptrdiff_t, not int.
295 (read1): Don't assume doc string length fits in int. Check for
296 out-of-range doc string lengths.
297 (read_list): Don't assume file position fits in int.
298 (read_escape): Check for hex character overflow.
299
300 2011-06-22 Leo Liu <sdl.web@gmail.com>
301
302 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
303 Move to minibuffer.el.
304
305 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
306
307 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
308 The following patches are for when GLYPH_DEBUG && !XASSERT.
309 * dispextern.h (trace_redisplay_p, dump_glyph_string):
310 * dispnew.c (flush_stdout):
311 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
312 Mark as externally visible.
313 * dispnew.c (check_window_matrix_pointers): Now static.
314 * dispnew.c (window_to_frame_vpos):
315 * xfns.c (unwind_create_frame):
316 * xterm.c (x_check_font): Remove unused local.
317 * scroll.c (CHECK_BOUNDS):
318 * xfaces.c (cache_fache): Rename local to avoid shadowing.
319 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
320 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
321 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
322 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
323 Now static.
324 (debug_method_add): Use va_list and vsprintf rather than relying
325 on undefined behavior with wrong number of arguments.
326 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
327 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
328 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
329 since we're not interested in debugging glyphs with old libraries.
330 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
331 GCC 4.6.0's static checking.
332
333 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
334
335 Integer overflow and signedness fixes (Bug#8873).
336 A few related buffer overrun fixes, too.
337
338 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
339
340 * dispextern.h (struct face.stipple):
341 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
342 (x_bitmap_mask, x_allocate_bitmap_record)
343 (x_create_bitmap_from_data, x_create_bitmap_from_file)
344 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
345 (x_create_bitmap_from_xpm_data):
346 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
347 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
348 (.bitmaps_last):
349 * xfaces.c (load_pixmap):
350 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
351 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
352 (.bitmaps_last, struct x_output.icon_bitmap):
353 Use ptrdiff_t, not int, for bitmap indexes.
354 (x_allocate_bitmap_record): Check for size overflow.
355 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
356
357 Use ptrdiff_t, not int, for overlay counts.
358 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
359 * editfns.c (overlays_around, get_pos_property):
360 * textprop.c (get_char_property_and_overlay):
361 * xdisp.c (next_overlay_change, note_mouse_highlight):
362 * xfaces.c (face_at_buffer_position):
363 * buffer.c (OVERLAY_COUNT_MAX): New macro.
364 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
365 (Fnext_overlay_change, Fprevious_overlay_change)
366 (mouse_face_overlay_overlaps, Foverlays_in):
367 Use ptrdiff_t, not int, for sizes.
368 (overlays_at, overlays_in): Check for size-calculation overflow.
369
370 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
371
372 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
373 (x_session_initialize): Do not assume string length fits in int.
374
375 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
376 This is unlikely, but can occur if DPI is outlandish.
377
378 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
379 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
380
381 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
382 * xrdb.c (magic_file_p, search_magic_path):
383 Omit last arg SUFFIX; it was always 0. All callers changed.
384 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
385
386 * xfont.c (xfont_match): Avoid need for strlen.
387
388 * xfns.c: Don't assume strlen fits in int.
389 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
390
391 * xdisp.c (message_log_check_duplicate): Return intmax_t,
392 not unsigned long, as we prefer signed integers. All callers changed.
393 Detect integer overflow in repeat count.
394 (message_dolog): Don't assume print length fits in 39 bytes.
395 (display_mode_element): Don't assume strlen fits in int.
396
397 * termcap.c: Don't assume sizes fit in int and never overflow.
398 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
399 (gobble_line): Check for size-calculation overflow.
400
401 * minibuf.c (Fread_buffer):
402 * lread.c (intern, intern_c_string):
403 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
404 Don't assume string length fits in int.
405
406 * keyboard.c (parse_tool_bar_item):
407 * gtkutil.c (style_changed_cb): Avoid need for strlen.
408
409 * font.c: Don't assume string length fits in int.
410 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
411 Use ptrdiff_t, not int.
412 (font_intern_prop): Don't assume string length fits in int.
413 Don't assume integer property fits in fixnum.
414 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
415
416 * filelock.c: Fix some buffer overrun and integer overflow issues.
417 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
418 Reformulate so as not to need the command string.
419 Invoke gzip -cd rather than gunzip, as it's more portable.
420 (lock_info_type, lock_file_1, lock_file):
421 Don't assume pid_t and time_t fit in unsigned long.
422 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
423 (current_lock_owner): Prefer signed type for sizes.
424 Use memcpy, not strncpy, where memcpy is what is really wanted.
425 Don't assume (via atoi) that time_t and pid_t fit in int.
426 Check for time_t and/or pid_t out of range, e.g., via a network share.
427 Don't alloca where an auto var works fine.
428
429 * fileio.c: Fix some integer overflow issues.
430 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
431 Don't assume string length fits in int.
432 (directory_file_name): Don't assume string length fits in long.
433 (make_temp_name): Don't assume pid fits in int, or that its print
434 length is less than 20.
435
436 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
437
438 * coding.c (make_subsidiaries): Don't assume string length fits in int.
439
440 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
441
442 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
443 We prefer signed integers, even for size calculations.
444
445 * emacs.c: Don't assume string length fits in 'int'.
446 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
447 (main): Don't invoke strlen when not needed.
448
449 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
450 (XD_DEBUG_MESSAGE): Don't waste a byte.
451
452 * callproc.c (getenv_internal_1, getenv_internal)
453 (Fgetenv_internal):
454 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
455
456 * lread.c (invalid_syntax): Omit length argument.
457 All uses changed. This doesn't fix a bug, but it simplifies the
458 code away from its former Hollerith-constant appearance, and it's
459 one less 'int' to worry about when looking at integer-overflow issues.
460 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
461
462 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
463 This didn't break anything, but it didn't help either.
464 It's confusing to put a bogus integer in a place where the actual
465 value does not matter.
466 (LIST_END_P): Remove unused macro and its bogus comment.
467 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
468
469 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
470 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
471 implementation.
472 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
473 We prefer signed types, and the value cannot exceed the EMACS_INT
474 range anyway (because otherwise the length would not be representable).
475 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
476 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
477 This avoids a GCC warning when WIDE_EMACS_INT.
478
479 * indent.c (sane_tab_width): New function.
480 (current_column, scan_for_column, Findent_to, position_indentation)
481 (compute_motion): Use it. This is just for clarity.
482 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
483
484 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
485
486 * lisp.h (lint_assume): New macro.
487 * composite.c (composition_gstring_put_cache):
488 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
489
490 * editfns.c, insdel.c:
491 Omit unnecessary forward decls, to simplify future changes.
492
493 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
494
495 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
496
497 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
498 Use much-faster test for byte-length change.
499 Don't assume string byte-length fits in 'int'.
500 Check that character arg fits in 'int'.
501 (mapcar1): Declare byte as byte, for clarity.
502
503 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
504
505 * fns.c (concat): Catch string overflow earlier.
506 Do not rely on integer wraparound.
507
508 * dispextern.h (struct it.overlay_strings_charpos)
509 (struct it.selective): Now EMACS_INT, not int.
510 * xdisp.c (forward_to_next_line_start)
511 (back_to_previous_visible_line_start)
512 (reseat_at_next_visible_line_start, next_element_from_buffer):
513 Don't arbitrarily truncate the value of 'selective' to int.
514
515 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
516
517 * composite.c: Don't truncate sizes to 'int'.
518 (composition_gstring_p, composition_reseat_it)
519 (composition_adjust_point): Use EMACS_INT, not int.
520 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
521 not EMACS_UINT, for indexes.
522
523 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
524
525 * buffer.c: Include <verify.h>.
526 (struct sortvec.priority, struct sortstr.priority):
527 Now EMACS_INT, not int.
528 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
529 (struct sortstr.size, record_overlay_string)
530 (struct sortstrlist.size, struct sortlist.used):
531 Don't truncate size to int.
532 (record_overlay_string): Check for size-calculation overflow.
533 (init_buffer_once): Check at compile-time, not run-time.
534
535 2011-06-22 Jim Meyering <meyering@redhat.com>
536
537 Don't leak an XBM-image-sized buffer
538 * image.c (xbm_load): Free the image buffer after using it.
539
540 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
541
542 Port to Sun C.
543 * composite.c (find_automatic_composition): Omit needless 'return 0;'
544 that Sun C diagnosed.
545 * fns.c (secure_hash): Fix pointer signedness issue.
546 * intervals.c (static_offset_intervals): New function.
547 (offset_intervals): Use it.
548
549 2011-06-21 Leo Liu <sdl.web@gmail.com>
550
551 * deps.mk (fns.o):
552 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
553 sha512.h.
554
555 * fns.c (secure_hash): Rename from crypto_hash_function and change
556 the first arg to accept symbols.
557 (Fsecure_hash): New primitive.
558 (syms_of_fns): New symbols.
559
560 2011-06-20 Deniz Dogan <deniz@dogan.se>
561
562 * process.c (Fset_process_buffer): Clarify return value in
563 docstring.
564
565 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
566
567 * dispnew.c (add_window_display_history): Use BVAR.
568
569 * xdisp.c (debug_method_add): Use BVAR.
570 (check_window_end, dump_glyph_matrix, dump_glyph)
571 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
572
573 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
574 Likewise.
575
576 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
577 check till after the cache is created in init_frame_faces.
578
579 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
580
581 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
582
583 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
584
585 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
586 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
587 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
588
589 Improve buffer-overflow checking (Bug#8873).
590 * fileio.c (Finsert_file_contents):
591 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
592 Remove the old (too-loose) buffer overflow checks.
593 They weren't needed, since make_gap checks for buffer overflow.
594 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
595 The old code merely checked for Emacs fixnum overflow, and relied
596 on undefined (wraparound) behavior. The new code avoids undefined
597 behavior, and also checks for ptrdiff_t and/or size_t overflow.
598
599 * editfns.c (Finsert_char): Don't dump core with very negative counts.
600 Tune. Don't use wider integers than needed. Don't use alloca.
601 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
602
603 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
604
605 * insdel.c, lisp.h (buffer_overflow): New function.
606 (insert_from_buffer_1, replace_range, replace_range_2):
607 * insdel.c (make_gap_larger):
608 * editfns.c (Finsert_char):
609 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
610
611 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
612
613 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
614
615 Integer overflow and signedness fixes (Bug#8873).
616
617 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
618 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
619
620 * fileio.c: Don't assume EMACS_INT fits in off_t.
621 (emacs_lseek): New static function.
622 (Finsert_file_contents, Fwrite_region): Use it.
623 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
624
625 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
626
627 * fns.c: Don't overflow int when computing a list length.
628 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
629 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
630 truncation on 64-bit hosts. Check for QUIT every
631 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
632 faster and is responsive enough.
633 (Flength): Report an error instead of overflowing an integer.
634 (Fsafe_length): Return a float if the value is not representable
635 as a fixnum. This shouldn't happen except in contrived situations.
636 (Fnthcdr, Fsort): Don't assume list length fits in int.
637 (Fcopy_sequence): Don't assume vector length fits in int.
638
639 * alloc.c: Check that resized vectors' lengths fit in fixnums.
640 (header_size, word_size): New constants.
641 (allocate_vectorlike): Don't check size overflow here.
642 (allocate_vector): Check it here instead, since this is the only
643 caller of allocate_vectorlike that could cause overflow.
644 Check that the new vector's length is representable as a fixnum.
645
646 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
647 The previous code was bogus. For example, next_almost_prime (32)
648 returned 39, which is undesirable as it is a multiple of 3; and
649 next_almost_prime (24) returned 25, which is a multiple of 5 so
650 why was the code bothering to check for multiples of 7?
651
652 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
653
654 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
655
656 Variadic C functions now count arguments with ptrdiff_t.
657 This partly undoes my 2011-03-30 change, which replaced int with size_t.
658 Back then I didn't know that the Emacs coding style prefers signed int.
659 Also, in the meantime I found a few more instances where arguments
660 were being counted with int, which may truncate counts on 64-bit
661 machines, or EMACS_INT, which may be unnecessarily wide.
662 * lisp.h (struct Lisp_Subr.function.aMANY)
663 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
664 Arg counts are now ptrdiff_t, not size_t.
665 All variadic functions and their callers changed accordingly.
666 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
667 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
668 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
669 * callint.c (Fcall_interactively): Check arg count for overflow,
670 to avoid potential buffer overrun. Use signed char, not 'int',
671 for 'varies' array, so that we needn't bother to check its size
672 calculation for overflow.
673 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
674 * eval.c (apply_lambda):
675 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
676 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
677 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
678
679 * callint.c (Fcall_interactively): Don't use index var as event count.
680
681 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
682 * mem-limits.h (SIZE): Remove; no longer used.
683
684 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
685
686 Remove unnecessary casts.
687 * xterm.c (x_term_init):
688 * xfns.c (x_set_border_pixel):
689 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
690 These aren't needed now that we assume ANSI C.
691
692 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
693 It's more likely to cause problems (due to unsigned overflow)
694 than to cure them.
695
696 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
697
698 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
699
700 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
701
702 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
703
704 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
705
706 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
707
708 GLYPH_CODE_FACE returns EMACS_INT, not int.
709 * dispextern.h (merge_faces):
710 * xfaces.c (merge_faces):
711 * xdisp.c (get_next_display_element, next_element_from_display_vector):
712 Don't assume EMACS_INT fits in int.
713
714 * character.h (CHAR_VALID_P): Remove unused parameter.
715 * fontset.c, lisp.h, xdisp.c: All uses changed.
716
717 * editfns.c (Ftranslate_region_internal): Omit redundant test.
718
719 * fns.c (concat): Minor tuning based on overflow analysis.
720 This doesn't fix any bugs. Use int to hold character, instead
721 of constantly refetching from Emacs object. Use XFASTINT, not
722 XINT, for value known to be a character. Don't bother comparing
723 a single byte to 0400, as it's always less.
724
725 * floatfns.c (Fexpt):
726 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
727
728 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
729 for characters.
730
731 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
732
733 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
734 Without this fix, on a 64-bit host (aset S 0 4294967386) would
735 incorrectly succeed when S was a string, because 4294967386 was
736 truncated before it was used.
737
738 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
739 Otherwise, an out-of-range integer could cause undefined behavior
740 on a 64-bit host.
741
742 * composite.c: Use int, not EMACS_INT, for characters.
743 (fill_gstring_body, composition_compute_stop_pos): Use int, not
744 EMACS_INT, for values that are known to be in character range.
745 This doesn't fix any bugs but is the usual style inside Emacs and
746 may generate better code on 32-bit machines.
747
748 Make sure a 64-bit char is never passed to ENCODE_CHAR.
749 This is for reasons similar to the recent CHAR_STRING fix.
750 * charset.c (Fencode_char): Check that character arg is actually
751 a character. Pass an int to ENCODE_CHAR.
752 * charset.h (ENCODE_CHAR): Verify that the character argument is no
753 wider than 'int', as a compile-time check to prevent future regressions
754 in this area.
755
756 * character.c (char_string): Remove unnecessary casts.
757
758 Make sure a 64-bit char is never passed to CHAR_STRING.
759 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
760 by silently ignoring the top 32 bits, allowing some values
761 that were far too large to be valid characters.
762 * character.h: Include <verify.h>.
763 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
764 arguments are no wider than unsigned, as a compile-time check
765 to prevent future regressions in this area.
766 * data.c (Faset):
767 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
768 (Fsubst_char_in_region):
769 * fns.c (concat):
770 * xdisp.c (decode_mode_spec_coding):
771 Adjust to CHAR_STRING's new requirement.
772 * editfns.c (Finsert_char, Fsubst_char_in_region):
773 * fns.c (concat): Check that character args are actually
774 characters. Without this test, these functions did the wrong
775 thing with wildly out-of-range values on 64-bit hosts.
776
777 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
778 These casts should not be needed on 32-bit hosts, either.
779 * keyboard.c (read_char):
780 * lread.c (Fload): Remove casts to unsigned.
781
782 * lisp.h (UNSIGNED_CMP): New macro.
783 This fixes comparison bugs on 64-bit hosts.
784 (ASCII_CHAR_P): Use it.
785 * casefiddle.c (casify_object):
786 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
787 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
788 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
789 * dispextern.h (FACE_FROM_ID):
790 * keyboard.c (read_char): Use UNSIGNED_CMP.
791
792 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
793 not to EMACS_INT, to avoid GCC warning.
794
795 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
796
797 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
798 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
799 isn't needed on 32-bit machines.
800
801 * buffer.c (Fgenerate_new_buffer_name):
802 Use EMACS_INT for count, not int.
803 (advance_to_char_boundary): Return EMACS_INT, not int.
804
805 * data.c (Qcompiled_function): Now static.
806
807 * window.c (window_body_lines): Now static.
808
809 * image.c (gif_load): Rename local to avoid shadowing.
810
811 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
812 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
813 * alloc.c (make_save_value): Integer argument is now of type
814 ptrdiff_t, not int.
815 (mark_object): Use ptrdiff_t, not int.
816 * lisp.h (pD): New macro.
817 * print.c (print_object): Use it.
818
819 * alloc.c: Use EMACS_INT, not int, to count objects.
820 (total_conses, total_markers, total_symbols, total_vector_size)
821 (total_free_conses, total_free_markers, total_free_symbols)
822 (total_free_floats, total_floats, total_free_intervals)
823 (total_intervals, total_strings, total_free_strings):
824 Now EMACS_INT, not int. All uses changed.
825 (Fgarbage_collect): Compute overall total using a double, so that
826 integer overflow is less likely to be a problem. Check for overflow
827 when converting back to an integer.
828 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
829 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
830 These were 'int' variables that could overflow on 64-bit hosts;
831 they were never used, so remove them instead of repairing them.
832 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
833 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
834 Previously, this ceilinged at INT_MAX, but that doesn't work on
835 64-bit machines.
836 (allocate_pseudovector): Don't use EMACS_INT when int would do.
837
838 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
839 (allocate_vectorlike): Check for ptrdiff_t overflow.
840 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
841 when a (possibly-narrower) signed value would do just as well.
842 We prefer using signed arithmetic, to avoid comparison confusion.
843
844 * alloc.c: Catch some string size overflows that we were missing.
845 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
846 for convenience in STRING_BYTES_MAX.
847 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
848 The definition here is exact; the one in lisp.h was approximate.
849 (allocate_string_data): Check for string overflow. This catches
850 some instances we weren't catching before. Also, it catches
851 size_t overflow on (unusual) hosts where SIZE_MAX <= min
852 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
853 and ptrdiff_t and EMACS_INT are both 64 bits.
854
855 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
856 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
857 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
858
859 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
860
861 * alloc.c (Fmake_string): Check for out-of-range init.
862
863 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
864
865 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
866
867 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
868
869 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
870 xg_get_default_scrollbar_width.
871
872 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
873 (int_gtk_range_get_value): Move to the scroll bar part of the file.
874 (style_changed_cb): Call update_theme_scrollbar_width and call
875 x_set_scroll_bar_default_width and xg_frame_set_char_size for
876 all frames (Bug#8505).
877 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
878 Call gtk_window_set_resizable if HAVE_GTK3.
879 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
880 and height if HAVE_GTK3 (Bug#8505).
881 (scroll_bar_width_for_theme): New variable.
882 (update_theme_scrollbar_width): New function.
883 (xg_get_default_scrollbar_width): Move code to
884 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
885 (xg_initialize): Call update_theme_scrollbar_width.
886
887 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
888
889 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
890
891 2011-06-12 Martin Rudalics <rudalics@gmx.at>
892
893 * frame.c (make_frame): Call other_buffer_safely instead of
894 other_buffer.
895
896 * window.c (temp_output_buffer_show): Call display_buffer with
897 second argument Vtemp_buffer_show_specifiers and reset latter
898 immediately after the call.
899 (Vtemp_buffer_show_specifiers): New variable.
900 (auto_window_vscroll_p, next_screen_context_lines)
901 (Vscroll_preserve_screen_position): Remove leading asterisks from
902 doc-strings.
903
904 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
905
906 Fix minor problems found by GCC 4.6.0 static checking.
907 * buffer.c (Qclone_number): Remove for now, as it's unused.
908 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
909 (record_buffer): Remove unused local.
910 * frame.c (other_visible_frames, frame_buffer_list): Now static.
911 (set_frame_buffer_list): Remove; unused.
912 * frame.h (other_visible_frames): Remove decl.
913 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
914 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
915 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
916 if HAVE_GPM.
917 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
918 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
919 Define only if HAVE_GPM.
920 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
921 (update_hints_inhibit): Remove; never set. All uses removed.
922 * widgetprv.h (emacsFrameClassRec): Remove decl.
923 * window.c (delete_deletable_window): Now returns void, since it
924 wasn't returning anything.
925 (compare_window_configurations): Remove unused locals.
926 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
927 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
928 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
929 the same widths as pointers. This follows up on the 2011-05-06 patch.
930 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
931 * xterm.h: Likewise.
932 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
933
934 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
935
936 * makefile.w32-in: Update dependencies.
937 (LISP_H): Add lib/intprops.h.
938
939 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
940
941 * image.c (gif_load): Add animation frame delay to the metadata.
942 (syms_of_image): Use DEFSYM. New symbol `delay'.
943
944 2011-06-11 Martin Rudalics <rudalics@gmx.at>
945
946 * window.c (delete_deletable_window): Re-add.
947 (Fset_window_configuration): Rewrite to handle dead buffers and
948 consequently deletable windows.
949 (window_tree, Fwindow_tree): Remove. Supply functionality in
950 window.el.
951 (compare_window_configurations): Simplify code.
952
953 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
954
955 * image.c (imagemagick_load_image): Fix type mismatch.
956 (Fimagemagick_types): Likewise.
957
958 * window.h (replace_buffer_in_windows): Declare.
959
960 2011-06-11 Martin Rudalics <rudalics@gmx.at>
961
962 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
963 Qclone_number. Remove external declaration of Qdelete_window.
964 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
965 code.
966 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
967 Qbuffer_list_update_hook if allowed.
968 (Fother_buffer): Rewrite doc-string. Major rewrite for new
969 buffer list implementation.
970 (other_buffer_safely): New function.
971 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
972 calls to replace_buffer_in_windows and
973 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
974 if allowed.
975 (record_buffer): Inhibit quitting and rewrite using quittable
976 functions. Run Qbuffer_list_update_hook if allowed.
977 (Frecord_buffer, Funrecord_buffer): New functions.
978 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
979 switch-to-buffer to window.el.
980 (bury-buffer): Move to window.el.
981 (Vbuffer_list_update_hook): New variable.
982
983 * lisp.h (other_buffer_safely): Add prototype in buffer.c
984 section.
985
986 * window.h (resize_frame_windows): Move up in code.
987 (Fwindow_frame): Remove EXFUN.
988 (replace_buffer_in_all_windows): Remove prototype.
989 (replace_buffer_in_windows_safely): Add prototype.
990
991 * window.c: Declare Qdelete_window static again. Move down
992 declaration of select_count.
993 (Fnext_window, Fprevious_window): Rewrite doc-strings.
994 (Fother_window): Move to window.el.
995 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
996 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
997 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
998 window.el.
999 (replace_buffer_in_windows): Implement by calling
1000 Qreplace_buffer_in_windows.
1001 (replace_buffer_in_all_windows): Remove with some functionality
1002 moved into replace_buffer_in_windows_safely.
1003 (replace_buffer_in_windows_safely): New function.
1004 (select_window_norecord, select_frame_norecord): Move in front
1005 of run_window_configuration_change_hook. Remove now obsolete
1006 declarations.
1007 (Fset_window_buffer): Rewrite doc-string. Call
1008 Qrecord_window_buffer.
1009 (keys_of_window): Move binding for other-window to window.el.
1010
1011 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1012
1013 * dispextern.h (struct image): Replace data member, whose int_val
1014 and ptr_val fields were not used by anything, with a single
1015 lisp_val object.
1016
1017 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1018 (gif_clear_image, gif_load, imagemagick_load_image)
1019 (gs_clear_image, gs_load): Callers changed.
1020
1021 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 * buffer.h: Include <time.h>, for time_t.
1024 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1025
1026 Fix minor problems found by static checking.
1027
1028 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1029
1030 Make identifiers static if they are not used in other modules.
1031 * data.c (Qcompiled_function, Qframe, Qvector):
1032 * image.c (QimageMagick, Qsvg):
1033 * minibuf.c (Qmetadata):
1034 * window.c (resize_window_check, resize_root_window): Now static.
1035 * window.h (resize_window_check, resize_root_window): Remove decls.
1036
1037 * window.c (window_deletion_count, delete_deletable_window):
1038 Remove; unused.
1039 (window_body_lines): Now static.
1040 (Fdelete_other_windows_internal): Mark vars as initialized.
1041 Make sure 'resize_failed' is initialized.
1042 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1043 (resize_window_apply): Remove unused local.
1044 * window.h (delete_deletable_window): Remove decl.
1045
1046 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1047 (imagemagick_load_image): Fix pointer signedness problem by changing
1048 last arg from unsigned char * to char *. All uses changed.
1049 Also, fix a local for similar reasons.
1050 Remove unused locals. Remove locals to avoid shadowing.
1051 (fn_rsvg_handle_free): Remove; unused.
1052 (svg_load, svg_load_image): Fix pointer signedness problem.
1053 (imagemagick_load_image): Don't use garbage pointer image_wand.
1054
1055 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1056
1057 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1058
1059 * image.c (gif_load): Fix omitted cast error introduced by
1060 2011-06-06 change.
1061
1062 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1063
1064 * window.h (resize_proportionally, orig_total_lines)
1065 (orig_top_line): Remove from window structure.
1066 (set_window_height, set_window_width, change_window_heights)
1067 (Fdelete_window): Remove prototypes.
1068 (resize_frame_windows): Remove duplicate declaration.
1069
1070 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1071
1072 * window.h (resize_frame_windows, resize_window_check)
1073 (delete_deletable_window, resize_root_window)
1074 (resize_frame_windows): Declare prototypes.
1075
1076 * window.c (resize_window_apply): Make definition be "static" to
1077 match the prototype.
1078
1079 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1080
1081 * window.c: Remove declarations of Qwindow_size_fixed,
1082 window_min_size_1, window_min_size_2, window_min_size,
1083 size_window, window_fixed_size_p, enlarge_window, delete_window.
1084 Remove static from declaration of Qdelete_window, it's
1085 temporarily needed by Fbury_buffer.
1086 (replace_window): Don't assign orig_top_line and
1087 orig_total_lines.
1088 (Fdelete_window, delete_window): Remove. Window deletion is
1089 handled by window.el.
1090 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1091 Fdelete_window calls with calls to Qdelete_window.
1092 (Fdelete_other_windows): Remove. Deleting other windows is
1093 handled by window.el.
1094 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1095 handled in window.el.
1096 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1097 Window minimum sizes are handled in window.el.
1098 (shrink_windows, size_window, set_window_height)
1099 (set_window_width, change_window_heights, window_height)
1100 (window_width, CURBEG, CURSIZE, enlarge_window)
1101 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1102 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1103 handled in window.el.
1104 (make_dummy_parent): Rename to make_parent_window and give it a
1105 second argument horflag.
1106 (make_window): Don't set resize_proportionally any more.
1107 (Fsplit_window): Remove. Windows are split in window.el.
1108 (save_restore_action, save_restore_orig_size)
1109 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1110 Resize mini windows in window.el.
1111 (grow_mini_window, shrink_mini_window): Implement by calling
1112 Qresize_root_window_vertically, resize_window_check and
1113 resize_window_apply.
1114 (saved_window, Fset_window_configuration, save_window_save): Do
1115 not handle orig_top_line, orig_total_lines, and
1116 resize_proportionally.
1117 (window_min_height, window_min_width): Move to window.el.
1118 (keys_of_window): Move bindings for delete-other-windows,
1119 split-window, delete-window and enlarge-window to window.el.
1120
1121 * buffer.c: Temporarily extern Qdelete_window.
1122 (Fbury_buffer): Temporarily call Qdelete_window instead of
1123 Fdelete_window (Fbury_buffer will move to window.el soon).
1124
1125 * frame.c (set_menu_bar_lines_1): Remove code handling
1126 orig_top_line and orig_total_lines.
1127
1128 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1129 set_window_height but set heights directly.
1130 (change_frame_size_1): Use resize_frame_windows.
1131
1132 * xdisp.c (init_xdisp): Don't use set_window_height but set
1133 heights directly.
1134
1135 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1136 resize_frame_windows instead of change_window_heights and run
1137 run_window_configuration_change_hook.
1138
1139 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1140 instead of change_window_heights and run
1141 run_window_configuration_change_hook.
1142
1143 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1144
1145 * window.c (replace_window): Rename second argument REPLACEMENT to
1146 NEW. New third argument SETFLAG. Rewrite.
1147 (delete_window, make_dummy_parent): Call replace_window with
1148 third argument 1.
1149 (window_list_1): Move down in code.
1150 (run_window_configuration_change_hook): Move set_buffer part
1151 before select_frame_norecord part in order to unwind correctly.
1152 Rename count1 to count.
1153 (recombine_windows, delete_deletable_window, resize_root_window)
1154 (Fdelete_other_windows_internal)
1155 (Frun_window_configuration_change_hook, make_parent_window)
1156 (resize_window_check, resize_window_apply, Fresize_window_apply)
1157 (resize_frame_windows, Fsplit_window_internal)
1158 (Fdelete_window_internal, Fresize_mini_window_internal): New
1159 functions.
1160 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1161
1162 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1163
1164 * window.h (window): Add some new members to window structure -
1165 normal_lines, normal_cols, new_total, new_normal, clone_number,
1166 splits, nest, prev_buffers, next_buffers.
1167 (WINDOW_TOTAL_SIZE): Move here from window.c.
1168 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1169
1170 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1171 Remove.
1172 (make_dummy_parent): Set new members of windows structure.
1173 (make_window): Move down in code. Handle new members of window
1174 structure.
1175 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1176 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1177 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1178 (Fset_window_prev_buffers, Fwindow_next_buffers)
1179 (Fset_window_next_buffers, Fset_window_clone_number): New
1180 functions.
1181 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1182 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1183 Doc-string fixes.
1184 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1185 Argument WINDOW can be now internal window too.
1186 (Fwindow_use_time): Move up in code.
1187 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1188 Rewrite doc-string.
1189 (Fset_window_configuration, saved_window)
1190 (Fcurrent_window_configuration, save_window_save): Handle new
1191 members of window structure.
1192 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1193 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1194 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1195 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1196 Qget_mru_window, Qresize_root_window,
1197 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1198 Qauto_buffer_name; staticpro them.
1199
1200 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1201
1202 * window.c (Fwindow_total_size, Fwindow_left_column)
1203 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1204 (Fwindow_list_1): New functions.
1205 (window_box_text_cols): Replace with window_body_cols.
1206 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1207 window_body_cols instead of window_box_text_cols.
1208 (delete_window, Fset_window_configuration): Call
1209 delete_all_subwindows with window as argument.
1210 (delete_all_subwindows): Take a window as argument and not a
1211 structure. Rewrite.
1212 (window_loop): Remove handling of GET_LRU_WINDOW and
1213 GET_LARGEST_WINDOW.
1214 (Fget_lru_window, Fget_largest_window): Move to window.el.
1215
1216 * window.h: Extern window_body_cols instead of
1217 window_box_text_cols. delete_all_subwindows now takes a
1218 Lisp_Object as argument.
1219
1220 * indent.c (compute_motion, Fcompute_motion): Use
1221 window_body_cols instead of window_box_text_cols.
1222
1223 * frame.c (delete_frame): Call delete_all_subwindows with root
1224 window as argument.
1225
1226 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1227
1228 * fns.c (Fputhash): Document return value.
1229
1230 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1231
1232 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1233
1234 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1235
1236 Cons<->int and similar integer overflow fixes (Bug#8794).
1237
1238 Check for overflow when converting integer to cons and back.
1239 * charset.c (Fdefine_charset_internal, Fdecode_char):
1240 Use cons_to_unsigned to catch overflow.
1241 (Fencode_char): Use INTEGER_TO_CONS.
1242 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1243 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1244 * data.c (long_to_cons, cons_to_long): Remove.
1245 (cons_to_unsigned, cons_to_signed): New functions.
1246 These signal an error for invalid or out-of-range values.
1247 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1248 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1249 * font.c (Ffont_variation_glyphs):
1250 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1251 * lisp.h: Include <intprops.h>.
1252 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1253 (cons_to_signed, cons_to_unsigned): New decls.
1254 (long_to_cons, cons_to_long): Remove decls.
1255 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1256 (Fprimitive_undo): Use CONS_TO_INTEGER.
1257 * xfns.c (Fx_window_property): Likewise.
1258 * xselect.c: Include <limits.h>.
1259 (x_own_selection, selection_data_to_lisp_data):
1260 Use INTEGER_TO_CONS.
1261 (x_handle_selection_request, x_handle_selection_clear)
1262 (x_get_foreign_selection, Fx_disown_selection_internal)
1263 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1264 (lisp_data_to_selection_data): Use cons_to_unsigned.
1265 (x_fill_property_data): Use cons_to_signed.
1266 Report values out of range.
1267
1268 Check for buffer and string overflow more precisely.
1269 * buffer.h (BUF_BYTES_MAX): New macro.
1270 * lisp.h (STRING_BYTES_MAX): New macro.
1271 * alloc.c (Fmake_string):
1272 * character.c (string_escape_byte8):
1273 * coding.c (coding_alloc_by_realloc):
1274 * doprnt.c (doprnt):
1275 * editfns.c (Fformat):
1276 * eval.c (verror):
1277 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1278 since they may not be the same number.
1279 * editfns.c (Finsert_char):
1280 * fileio.c (Finsert_file_contents):
1281 Likewise for BUF_BYTES_MAX.
1282
1283 * image.c: Use ptrdiff_t, not int, for sizes.
1284 (slurp_file): Switch from int to ptrdiff_t.
1285 All uses changed.
1286 (slurp_file): Check that file size fits in both size_t (for
1287 malloc) and ptrdiff_t (for sanity and safety).
1288
1289 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1290 if b->modtime has its maximal value.
1291
1292 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1293
1294 Don't assume time_t can fit into int.
1295 * buffer.h (struct buffer.modtime): Now time_t, not int.
1296 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1297 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1298
1299 Minor fixes for signed vs unsigned integers.
1300 * character.h (MAYBE_UNIFY_CHAR):
1301 * charset.c (maybe_unify_char):
1302 * keyboard.c (read_char, reorder_modifiers):
1303 XINT -> XFASTINT, since the integer must be nonnegative.
1304 * ftfont.c (ftfont_spec_pattern):
1305 * keymap.c (access_keymap, silly_event_symbol_error):
1306 XUINT -> XFASTINT, since the integer must be nonnegative.
1307 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1308 since it makes no difference and we prefer signed.
1309 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1310 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1311 nonnegative.
1312
1313 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1314
1315 * window.h (Fwindow_frame): Declare.
1316
1317 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1320 (SPARE_MEMORY): Always define.
1321 (LARGE_REQUEST): Remove.
1322 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1323
1324 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1325
1326 * lisp.h: Move EXFUNS for Fframe_root_window,
1327 Fframe_first_window and Fset_frame_selected_window to window.h.
1328
1329 * window.h: Move EXFUNS for Fframe_root_window,
1330 Fframe_first_window and Fset_frame_selected_window here from
1331 lisp.h.
1332
1333 * frame.c (Fwindow_frame, Fframe_first_window)
1334 (Fframe_root_window, Fframe_selected_window)
1335 (Fset_frame_selected_window): Move to window.c.
1336 (Factive_minibuffer_window): Move to minibuf.c.
1337 (Fother_visible_frames_p): New function.
1338
1339 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1340
1341 * window.c (decode_window, decode_any_window): Move up in code.
1342 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1343 (inhibit_frame_unsplittable): Remove unused variable.
1344 (Fwindow_buffer): Move up and rewrite doc-string.
1345 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1346 (Fwindow_prev): New functions.
1347 (Fwindow_frame): Move here from frame.c. Accept any window as
1348 argument.
1349 (Fframe_root_window, Fframe_first_window)
1350 (Fframe_selected_window): Move here from frame.c. Accept frame
1351 or arbitrary window as argument. Update doc-strings.
1352 (Fminibuffer_window): Move up in code.
1353 (Fwindow_minibuffer_p): Move up in code and simplify.
1354 (Fset_frame_selected_window): Move here from frame.c.
1355 Marginal rewrite.
1356 (Fselected_window, select_window, Fselect_window): Move up in
1357 code. Minor doc-string fixes.
1358
1359 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1362 Do not assume that spare memory exists; that assumption is valid
1363 only if SYSTEM_MALLOC.
1364 (LARGE_REQUEST): New macro, so that the issue of large requests
1365 is separated from the issue of spare memory.
1366
1367 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1368
1369 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1370 format. (Bug#8806)
1371
1372 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1373
1374 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1375 before statements.
1376
1377 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1378
1379 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1380
1381 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1382
1383 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1384 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1385
1386 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1387
1388 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1389
1390 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1391
1392 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1393 (x_clipboard_manager_save): Add return value.
1394 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1395 New error handlers.
1396 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1397 Obey Vx_select_enable_clipboard_manager. Catch errors in
1398 x_clipboard_manager_save (Bug#8779).
1399 (Vx_select_enable_clipboard_manager): New variable.
1400 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1401
1402 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1403
1404 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1405
1406 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1407
1408 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1409 in the current matrix if keep_current_p is non-zero.
1410
1411 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1412
1413 * bidi.c (bidi_level_of_next_char): Fix last change.
1414
1415 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1416
1417 Support bidi reordering of text covered by display properties.
1418
1419 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1420 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1421 (bidi_cache_search, bidi_cache_iterator_state)
1422 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1423 (bidi_level_of_next_char, bidi_move_to_visually_next):
1424 Support character positions inside a run of characters covered by a
1425 display string.
1426 (bidi_paragraph_init, bidi_resolve_explicit_1)
1427 (bidi_level_of_next_char): Call bidi_fetch_char and
1428 bidi_fetch_char_advance instead of FETCH_CHAR and
1429 FETCH_CHAR_ADVANCE.
1430 (bidi_init_it): Initialize new members.
1431 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1432 definitions.
1433 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1434 instead of using explicit *_CHAR codes.
1435 (bidi_resolve_explicit, bidi_resolve_weak):
1436 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1437 bidirectional text is supported only in multibyte buffers.
1438 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1439 it to initialize the frame_window_p member of struct bidi_it.
1440 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1441 (bidi_resolve_explicit, bidi_resolve_weak)
1442 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1443 bidi_it->nchars is non-positive.
1444 (bidi_level_of_next_char): Don't try to lookup the cache for the
1445 next/previous character if nothing is cached there yet, or if we
1446 were just reseat()'ed to a new position.
1447
1448 * xdisp.c (set_cursor_from_row): Set start and stop points
1449 according to the row's direction when priming the loop that looks
1450 for the glyph on which to display cursor.
1451 (single_display_spec_intangible_p): Function deleted.
1452 (display_prop_intangible_p): Reimplement to call
1453 handle_display_spec instead of single_display_spec_intangible_p.
1454 Accept 3 additional arguments needed by handle_display_spec.
1455 This fixes incorrect cursor motion across display property with complex
1456 values: lists, `(when COND...)' forms, etc.
1457 (single_display_spec_string_p): Support property values that are
1458 lists with the argument STRING its top-level element.
1459 (display_prop_string_p): Fix the condition for processing a
1460 property that is a list to be consistent with handle_display_spec.
1461 (handle_display_spec): New function, refactored from the
1462 last portion of handle_display_prop.
1463 (compute_display_string_pos): Accept additional argument
1464 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1465 value of a `display' property is a "replacing spec".
1466 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1467 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1468 the display property, but just return a value indicating whether
1469 the display property will replace the characters it covers.
1470 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1471 frame_window_p members of struct bidi_it.
1472 (compute_display_string_pos, compute_display_string_end):
1473 New functions.
1474 (push_it): Accept second argument POSITION, where pop_it should
1475 jump to continue iteration.
1476 (reseat_1): Initialize bidi_it.disp_pos.
1477
1478 * keyboard.c (adjust_point_for_property): Adjust the call to
1479 display_prop_intangible_p to its new signature.
1480
1481 * dispextern.h (struct bidi_it): New member frame_window_p.
1482 (bidi_init_it): Update prototypes.
1483 (display_prop_intangible_p): Update prototype.
1484 (compute_display_string_pos, compute_display_string_end):
1485 Declare prototypes.
1486 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1487 EMACS_INT.
1488
1489 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1490
1491 Malloc failure behavior now depends on size of allocation.
1492 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1493 * lisp.h: Change signatures accordingly.
1494 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1495 All callers changed. (Bug#8762)
1496
1497 * gnutls.c: Use Emacs's memory allocators.
1498 Without this change, the gnutls library would invoke malloc etc.
1499 directly, which causes problems on non-SYNC_INPUT hosts, and which
1500 runs afoul of improving memory_full behavior. (Bug#8761)
1501 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1502 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1503 xfree instead of the default malloc, realloc, free.
1504 (Fgnutls_boot): No need to check for memory allocation failure,
1505 since xmalloc does that for us.
1506
1507 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1508 * category.c (hash_get_category_set):
1509 * ccl.c (ccl_driver):
1510 * charset.c (Fdefine_charset_internal):
1511 * charset.h (struct charset.hash_index):
1512 * composite.c (get_composition_id, gstring_lookup_cache)
1513 (composition_gstring_put_cache):
1514 * composite.h (struct composition.hash_index):
1515 * dispextern.h (struct image.hash):
1516 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1517 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1518 (hashfn_equal, hashfn_user_defined, make_hash_table)
1519 (maybe_resize_hash_table, hash_lookup, hash_put)
1520 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1521 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1522 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1523 * image.c (make_image, search_image_cache, lookup_image)
1524 (xpm_put_color_table_h):
1525 * lisp.h (struct Lisp_Hash_Table):
1526 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1527 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1528 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1529 * alloc.c (allocate_vectorlike):
1530 Check for overflow in vector size calculations.
1531 * ccl.c (ccl_driver):
1532 Check for overflow when converting EMACS_INT to int.
1533 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1534 need to be updated by these changes.
1535 * fns.c (make_hash_table, maybe_resize_hash_table):
1536 Check for integer overflow with large hash tables.
1537 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1538 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1539 (SXHASH_REDUCE): New macro.
1540 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1541 Use it instead of discarding useful hash info with large hash values.
1542 (sxhash_float): New function.
1543 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1544 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1545 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1546 Rewrite to use FIXNUM_BITS, as this simplifies things.
1547 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1548 Adjust signatures to match updated version of code.
1549 (consing_since_gc): Now EMACS_INT, since a single hash table can
1550 use more than INT_MAX bytes.
1551
1552 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1553
1554 Make it possible to build with GCC-4.6+ -O2 -flto.
1555
1556 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1557
1558 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1559
1560 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1561 Call minibuffer-inactive-mode.
1562
1563 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1564
1565 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1566 Update dependencies.
1567
1568 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1569
1570 * data.c (init_data): Remove code for UTS, this system is not
1571 supported anymore.
1572
1573 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1574
1575 Don't force ./temacs to start in terminal mode.
1576
1577 * frame.c (make_initial_frame): Initialize faces in all cases, not
1578 only when CANNOT_DUMP is defined.
1579 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1580
1581 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1582
1583 * dispnew.c (add_window_display_history): Use const for the string
1584 pointer. Remove declaration, not needed.
1585
1586 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1587
1588 Use 'inline', not 'INLINE'.
1589 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1590 * alloc.c, fontset.c (INLINE): Remove.
1591 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1592 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1593 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1594 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1595 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1596
1597 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1598
1599 Make it possible to run ./temacs.
1600
1601 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1602 syms_of_callproc does the same thing. Remove test for
1603 "initialized", do it in the caller.
1604 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1605
1606 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1607
1608 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1609 (read_minibuf): Use get_minibuffer.
1610 (syms_of_minibuf): Use DEFSYM.
1611 (Qmetadata): New var.
1612 * data.c (Qbuffer): Don't make it static.
1613 (syms_of_data): Use DEFSYM.
1614
1615 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1616
1617 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1618 (CCL_CODE_MIN): New macro.
1619
1620 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1621
1622 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1623
1624 * eval.c (Qdebug): Now static.
1625 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1626 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1627 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1628
1629 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1630
1631 * image.c: Various fixes to ImageMagick code comments.
1632 (Fimagemagick_types): Doc fix.
1633
1634 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1635
1636 Minor fixes prompted by GCC 4.6.0 warnings.
1637
1638 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1639
1640 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1641 (x_clipboard_manager_save_all): Move extern decl to ...
1642 * xterm.h: ... here, so that it can be checked for consistency.
1643
1644 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1645
1646 * xselect.c (x_clipboard_manager_save_frame)
1647 (x_clipboard_manager_save_all): New functions.
1648 (Fx_clipboard_manager_save): Lisp function deleted.
1649
1650 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1651 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1652
1653 * xterm.h: Update prototype.
1654
1655 2011-05-28 William Xu <william.xwl@gmail.com>
1656
1657 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1658 exiting (Bug#8239).
1659
1660 2011-05-28 Jim Meyering <meyering@redhat.com>
1661
1662 Avoid a sign-extension bug in crypto_hash_function.
1663 * fns.c (to_uchar): Define.
1664 (crypto_hash_function): Use it to convert some newly-signed
1665 variables to unsigned, to avoid sign-extension bugs. For example,
1666 without this change, (md5 "truc") would evaluate to
1667 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1668 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1669 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1670
1671 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1672
1673 Integer overflow fixes.
1674
1675 * dbusbind.c: Serial number integer overflow fixes.
1676 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1677 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1678 to hold a serial number that is too large for a fixnum.
1679 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1680 Check for serial numbers out of range. Decode any serial number
1681 that was so large that it became a float. (Bug#8722)
1682
1683 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1684 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1685 Use XFASTINT rather than XUINT when numbers are nonnegative.
1686 (xd_append_arg, Fdbus_method_return_internal):
1687 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1688 arguments, check that Lisp number is nonnegative, rather than
1689 silently wrapping negative numbers around. (Bug#8722)
1690 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1691 (Bug#8722)
1692
1693 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1694
1695 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1696
1697 ccl: add integer overflow checks
1698 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1699 (IN_INT_RANGE): New macros.
1700 (ccl_driver): Use them to check for integer overflow when
1701 decoding a CCL program. Many of the new checks are whether XINT (x)
1702 fits in int; it doesn't always, on 64-bit hosts. The new version
1703 doesn't catch all possible integer overflows, but it's an
1704 improvement. (Bug#8719)
1705
1706 * alloc.c (make_event_array): Use XINT, not XUINT.
1707 There's no need for unsigned here.
1708
1709 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1710 This follows up to the 2011-05-06 change that substituted uintptr_t
1711 for EMACS_INT. This case wasn't caught back then.
1712
1713 Rework Fformat to avoid integer overflow issues.
1714 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1715 now (part of C89). Include <verify.h>.
1716 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1717 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1718 (Fformat): Avoid the prepass trying to compute sizes; it was only
1719 approximate and thus did not catch overflow reliably. Instead, walk
1720 through the format just once, formatting and computing sizes as we go,
1721 checking for integer overflow at every step, and allocating a larger
1722 buffer as needed. Keep track separately whether the format is
1723 multibyte. Keep only the most-recently calculated precision, rather
1724 than them all. Record whether each argument has been converted to
1725 string. Use EMACS_INT, not int, for byte and char and arg counts.
1726 Support field widths and precisions larger than INT_MAX. Avoid
1727 sprintf's undefined behavior with conversion specifications such as %#d
1728 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1729 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1730 formatting out-of-range floating point numbers with int
1731 formats. (Bug#8668)
1732
1733 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1734
1735 * data.c: Avoid integer truncation in expressions involving floats.
1736 * data.c: Include <intprops.h>.
1737 (arith_driver): When there's an integer overflow in an expression
1738 involving floating point, convert the integers to floating point
1739 so that the resulting value does not suffer from catastrophic
1740 integer truncation. For example, on a 64-bit host (* 4
1741 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1742 Do not rely on undefined behavior after integer overflow.
1743
1744 merge count_size_as_multibyte, parse_str_to_multibyte
1745 * character.c, character.h (count_size_as_multibyte):
1746 Rename from parse_str_to_multibyte; all uses changed.
1747 Check for integer overflow.
1748 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1749 since it's now a duplicate of the other. This is more of
1750 a character than a buffer op, so better that it's in character.c.
1751 * fns.c, print.c: Adjust to above changes.
1752
1753 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1754
1755 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1756
1757 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1758
1759 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1760 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1761 (x_clipboard_manager_save): Now static.
1762 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1763
1764 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1765 (crypto_hash_function): Now static.
1766 Fix pointer signedness problems. Avoid unnecessary initializations.
1767
1768 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1769
1770 * termhooks.h (Vselection_alist): Make it terminal-local.
1771
1772 * terminal.c (create_terminal): Initialize it.
1773
1774 * xselect.c: Support for clipboard managers.
1775 (Vselection_alist): Move to termhooks.h as terminal-local var.
1776 (LOCAL_SELECTION): New macro.
1777 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1778 (symbol_to_x_atom): Remove gratuitous arg.
1779 (x_handle_selection_request, lisp_data_to_selection_data)
1780 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1781 (x_own_selection, x_get_local_selection, x_convert_selection):
1782 New arg, specifying work frame. Use terminal-local Vselection_alist.
1783 (some_frame_on_display): Delete unused function.
1784 (Fx_own_selection_internal, Fx_get_selection_internal)
1785 (Fx_disown_selection_internal, Fx_selection_owner_p)
1786 (Fx_selection_exists_p): New optional frame arg.
1787 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1788 (x_handle_selection_clear): Don't treat other terminals with the
1789 same keyboard specially. Use the terminal-local Vselection_alist.
1790 (x_clear_frame_selections): Use Frun_hook_with_args.
1791
1792 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1793
1794 * xterm.h: Add support for those atoms.
1795
1796 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1797
1798 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1799 (converted_selections, conversion_fail_tag): New global variables.
1800 (x_selection_request_lisp_error): Free the above.
1801 (x_get_local_selection): Remove unnecessary code.
1802 (x_reply_selection_request): Args changed; handle arbitrary array
1803 of converted selections stored in converted_selections.
1804 Separate the XChangeProperty and SelectionNotify steps.
1805 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1806 (x_convert_selection): New function.
1807 (x_handle_selection_event): Simplify.
1808 (x_get_foreign_selection): Don't ignore incoming requests while
1809 waiting for an answer; this will fail when we implement
1810 SAVE_TARGETS, and seems unnecessary anyway.
1811 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1812 (Vx_sent_selection_functions): Doc fix.
1813
1814 2011-05-26 Leo Liu <sdl.web@gmail.com>
1815
1816 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1817
1818 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1819
1820 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1821
1822 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1823 for fringe update if it has periodic bitmap.
1824 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1825 and fringe_bitmap_periodic_p.
1826
1827 * fringe.c (get_fringe_bitmap_data): New function.
1828 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1829 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1830 row. Mark glyph row for fringe update if periodicity changed.
1831
1832 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1833 for fringe update unless it has periodic bitmap.
1834
1835 2011-05-25 Kenichi Handa <handa@m17n.org>
1836
1837 * xdisp.c (get_next_display_element): Set correct it->face_id for
1838 a static composition.
1839
1840 2011-05-24 Leo Liu <sdl.web@gmail.com>
1841
1842 * deps.mk (fns.o):
1843 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1844
1845 * fns.c (crypto_hash_function, Fsha1): New function.
1846 (Fmd5): Use crypto_hash_function.
1847 (syms_of_fns): Add Ssha1.
1848
1849 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1850
1851 * gnutls.c: Remove unused macros.
1852 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1853 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1854 Remove macros that are defined and never used.
1855 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1856
1857 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1858
1859 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1860 (Fx_get_selection_internal): Minor cleanup.
1861 (Fx_own_selection_internal): Rename arguments for consistency with
1862 select.el.
1863
1864 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1865
1866 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1867
1868 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1869
1870 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1871
1872 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1873
1874 * dispnew.c (scrolling_window): Don't exclude the case that the
1875 last enabled row in the desired matrix touches the bottom boundary.
1876
1877 2011-05-21 Glenn Morris <rgm@gnu.org>
1878
1879 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1880 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1881 and add some more files.
1882
1883 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1884
1885 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1886 report_file_error introduced by the change from 2011-05-07.
1887
1888 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * systime.h (Time): Define only if emacs is defined.
1891 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1892 where the include path doesn't have X11/X.h by default. See
1893 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1894
1895 2011-05-20 Kenichi Handa <handa@m17n.org>
1896
1897 * composite.c (find_automatic_composition): Fix previous change.
1898
1899 2011-05-20 Glenn Morris <rgm@gnu.org>
1900
1901 * lisp.mk: New file, split from Makefile.in.
1902 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1903 (shortlisp): Remove.
1904 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1905
1906 2011-05-19 Glenn Morris <rgm@gnu.org>
1907
1908 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1909 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1910 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1911 (lisp): Set the order to that of loadup.el.
1912 (shortlisp): Make it a copy of $lisp.
1913 (SOME_MACHINE_LISP): Remove.
1914 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1915 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1916
1917 2011-05-18 Kenichi Handa <handa@m17n.org>
1918
1919 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1920 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1921 (find_automatic_composition): Mostly rewrite for efficiency.
1922
1923 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1924
1925 * makefile.w32-in: Update dependencies.
1926
1927 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1928
1929 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1930 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1931
1932 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1933
1934 Fix some integer overflow issues, such as string length overflow.
1935
1936 * insdel.c (count_size_as_multibyte): Check for string overflow.
1937
1938 * character.c (lisp_string_width): Check for string overflow.
1939 Use EMACS_INT, not int, for string indexes and lengths; in
1940 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1941 the resulting string length overflows an EMACS_INT; instead,
1942 report a string overflow if no precision given. When checking for
1943 precision exhaustion, use a check that cannot possibly have
1944 integer overflow. (Bug#8675)
1945 * character.h (lisp_string_width): Adjust to new signature.
1946
1947 * alloc.c (string_overflow): New function.
1948 (Fmake_string): Use it. This doesn't change behavior, but saves
1949 a few bytes and will simplify future changes.
1950 * character.c (string_escape_byte8): Likewise.
1951 * lisp.h (string_overflow): New decl.
1952
1953 Fixups, following up to the user-interface timestamp change.
1954 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1955 for UI timestamps, instead of unsigned long.
1956 * msdos.c (mouse_get_pos): Likewise.
1957 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1958 * w32gui.h (Time): Define by including "systime.h" rather than by
1959 declaring it ourselves. (Bug#8664)
1960
1961 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1962 * image.c (clear_image_cache): Likewise.
1963
1964 * term.c (term_mouse_position): Don't assume time_t wraparound.
1965
1966 Be more systematic about user-interface timestamps.
1967 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1968 and sometimes 'EMACS_UINT', to represent these timestamps.
1969 This change causes it to use 'Time' uniformly, as that's what X uses.
1970 This makes the code easier to follow, and makes it easier to catch
1971 integer overflow bugs such as Bug#8664.
1972 * frame.c (Fmouse_position, Fmouse_pixel_position):
1973 Use Time, not unsigned long, for user-interface timestamps.
1974 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1975 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1976 * keyboard.h (last_event_timestamp): Likewise.
1977 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1978 * menu.h (xmenu_show): Likewise.
1979 * term.c (term_mouse_position): Likewise.
1980 * termhooks.h (struct input_event.timestamp): Likewise.
1981 (struct terminal.mouse_position_hook): Likewise.
1982 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1983 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1984 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1985 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1986 what it was before.
1987 * menu.h, termhooks.h: Include "systime.h", for Time.
1988
1989 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1990 Don't assume that the difference between two unsigned long values
1991 can fit into an integer. At this point, we know button_down_time
1992 <= event->timestamp, so the difference must be nonnegative, so
1993 there's no need to cast the result if double-click-time is
1994 nonnegative, as it should be; check that it's nonnegative, just in
1995 case. This bug is triggered when events are more than 2**31 ms
1996 apart (about 25 days). (Bug#8664)
1997
1998 * xselect.c (last_event_timestamp): Remove duplicate decl.
1999 (x_own_selection): Remove needless cast to unsigned long.
2000
2001 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2002 that always fit in int. Use a sentinel instead of a counter, to
2003 avoid a temp and to allay GCC's concerns about possible int overflow.
2004 * frame.h (struct frame): Use int for menu_bar_items_used
2005 instead of EMACS_INT, since it always fits in int.
2006
2007 * menu.c (grow_menu_items): Check for int overflow.
2008
2009 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2010
2011 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2012 Before, the code was not consistent. These values cannot exceed
2013 2**31 - 1 so there's no need to make them unsigned.
2014 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2015 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2016 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2017 as modifiers.
2018 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2019
2020 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2021 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2022 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2023 presumably because the widths might not match.
2024
2025 * window.c (size_window): Avoid needless test at loop start.
2026
2027 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2028
2029 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2030
2031 2011-05-12 Drew Adams <drew.adams@oracle.com>
2032
2033 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2034
2035 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2036
2037 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2038 `width' to `bar_area_x' and `bar_area_width', respectively.
2039 (x_scroll_run): Take account of fringe background extension.
2040
2041 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2042 Rename local vars `left' and `width' to `bar_area_x' and
2043 `bar_area_width', respectively.
2044 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2045 background extension.
2046
2047 2011-05-10 Jim Meyering <meyering@redhat.com>
2048
2049 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2050
2051 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2052
2053 * image.c (Finit_image_library): Return t for built-in image types,
2054 like pbm and xbm. (Bug#8640)
2055
2056 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2057
2058 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2059
2060 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2061
2062 * w32console.c (Fset_screen_color): Doc fix.
2063 (Fget_screen_color): New function.
2064 (syms_of_ntterm): Defsubr it.
2065
2066 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2067 unlink the temporary file if Fcall_process didn't create it in the
2068 first place.
2069 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2070 child process will be redirected to a file specified with `:file'.
2071 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2072 cue to call_process_cleanup not to close that handle.
2073
2074 2011-05-07 Ben Key <bkey76@gmail.com>
2075
2076 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2077 one of two shell specific rules, either bootstrap-temacs-CMD or
2078 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2079 to the previous implementation of the bootstrap-temacs rule.
2080 The bootstrap-temacs-CMD rule is similar to the previous
2081 implementation of the bootstrap-temacs rule except that it
2082 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2083 variable.
2084
2085 These changes, along with some changes to nt/configure.bat,
2086 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2087 earlier fix to add support for --cflags and --ldflags options
2088 that include quotes so that it works whether make uses cmd or
2089 sh as the shell.
2090
2091 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2092
2093 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2094 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2095 is a constant.
2096 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2097 a string. Handle both cases.
2098 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2099 (Fdbus_register_method): Use Qinvalid_function.
2100
2101 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2102
2103 * makefile.w32-in: Update dependencies.
2104 (LISP_H): Add inttypes.h and stdin.h.
2105 (PROCESS_H): Add unistd.h.
2106
2107 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2108
2109 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2110 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2111
2112 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2113
2114 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2115
2116 * term.c (vfatal): Remove stray call to va_end.
2117 It's not needed and the C Standard doesn't allow it here anyway.
2118
2119 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2120 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2121
2122 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2123 bytes.
2124
2125 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2126
2127 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2128
2129 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2130
2131 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2132
2133 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2134
2135 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2136 * charset.c (Fdefine_charset_internal): Don't initialize
2137 charset.code_space[15]. The value was garbage, on hosts with
2138 32-bit int (Bug#8600).
2139
2140 * lread.c (read_integer): Be more consistent with string-to-number.
2141 Use string_to_number to do the actual conversion; this avoids
2142 rounding errors and fixes some other screwups. Without this fix,
2143 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2144 (digit_to_number): Move earlier, for benefit of read_integer.
2145 Return -1 if the digit is out of range for the base, -2 if it is
2146 not a digit in any supported base. (Bug#8602)
2147
2148 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2149
2150 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2151 to match comment at start of function. This also removes a
2152 GCC warning about overflow in a 32+64-bit port.
2153
2154 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2155
2156 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2157 Reported by Stefan Monnier in
2158 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2159 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2160 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2161
2162 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2163 (EMACS_UINTPTR): Likewise, with uintptr_t.
2164
2165 * lisp.h: Prefer 64-bit EMACS_INT if available.
2166 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2167 on 32-bit hosts that have 64-bit int, so that they can access
2168 large files.
2169 However, temporarily disable this change unless the temporary
2170 symbol WIDE_EMACS_INT is defined.
2171
2172 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2173
2174 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2175 This removes an assumption that EMACS_INT and long are the same
2176 width as pointers. The assumption is true for Emacs porting targets
2177 now, but we want to make other targets possible.
2178 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2179 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2180 In the rest of the code, change types of integers that hold casted
2181 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2182 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2183 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2184 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2185 No need to cast type when ORing.
2186 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2187 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2188 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2189 assume EMACS_INT is the same width as char *.
2190 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2191 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2192 Remove no-longer-needed casts.
2193 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2194 (xg_tool_bar_help_callback, xg_make_tool_item):
2195 Use EMACS_INTPTR to hold an integer
2196 that will be cast to void *; this can avoid a GCC warning
2197 if EMACS_INT is not the same width as void *.
2198 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2199 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2200 (current_message_1, set_message_1):
2201 Use a local to convert to proper width without a cast.
2202 * xmenu.c (dialog_selection_callback): Likewise.
2203
2204 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2205 Also, don't assume VALBITS / RAND_BITS is less than 5,
2206 and don't rely on undefined behavior when shifting a 1 left into
2207 the sign bit.
2208 * lisp.h (get_random): Change signature to match.
2209
2210 * lread.c (hash_string): Use size_t, not int, for hash computation.
2211 Normally we prefer signed values; but hashing is special, because
2212 it's better to use unsigned division on hash table sizes so that
2213 the remainder is nonnegative. Also, size_t is the natural width
2214 for hashing into memory. The previous code used 'int', which doesn't
2215 retain enough info to hash well into very large tables.
2216 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2217
2218 * dbusbind.c: Don't possibly lose pointer info when converting.
2219 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2220 Use XPNTR rather than XHASH, so that the high-order bits of
2221 the pointer aren't lost when converting through void *.
2222
2223 * eval.c (Fautoload): Don't double-shift a pointer.
2224
2225 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2226
2227 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2228
2229 * gnutls.c (DEF_GNUTLS_FN):
2230 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2231
2232 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2233
2234 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2235 marker. (Bug#8610)
2236
2237 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2238
2239 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2240 New version that can reserve upto 2GB of heap space.
2241
2242 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2243
2244 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2245
2246 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2247
2248 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2249 `gnutls_certificate_set_x509_key_file'.
2250
2251 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2252
2253 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2254 Update dependencies.
2255
2256 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2257
2258 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2259 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2260 Remove unused parameter `fildes'.
2261 * process.c (read_process_output, send_process): Don't pass it.
2262
2263 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2264
2265 Fix previous change: the library cache is defined in w32.c.
2266 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2267 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2268
2269 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2270
2271 Implement dynamic loading of GnuTLS on Windows.
2272
2273 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2274 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2275 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2276 Declare.
2277
2278 * gnutls.c (Qgnutls_dll): Define.
2279 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2280 (gnutls_*): Declare function pointers.
2281 (init_gnutls_functions): New function to initialize function pointers.
2282 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2283 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2284 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2285 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2286 (emacs_gnutls_write, emacs_gnutls_read)
2287 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2288 (Fgnutls_available_p): New function.
2289 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2290 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2291 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2292
2293 * image.c: Include w32.h.
2294 (Vimage_type_cache): Delete.
2295 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2296 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2297 (w32_delayed_load): Move to w32.c.
2298
2299 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2300
2301 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2302 (w32_delayed_load): Move from image.c. When loading a library, record
2303 its filename in the :loaded-from property of the library id.
2304 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2305 Initialize and staticpro them.
2306 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2307
2308 * process.c: Include lisp.h before w32.h, not after.
2309 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2310 instead of gnutls_record_check_pending.
2311
2312 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2313
2314 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2315
2316 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2317 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2318 as passed in.
2319
2320 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2321
2322 * xterm.c (x_set_frame_alpha): Do not set property on anything
2323 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2324
2325 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2326
2327 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2328
2329 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2330
2331 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2332 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2333 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2334 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2335 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2336 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2337 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2338 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2339 (Qgnutls_bootprop_callbacks_verify): Make static.
2340
2341 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2342
2343 * callproc.c: Indentation fixup.
2344
2345 * sysdep.c (wait_for_termination_1): Make static.
2346 (wait_for_termination, interruptible_wait_for_termination):
2347 Move after wait_for_termination_1.
2348
2349 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2350
2351 * sysdep.c (interruptible_wait_for_termination): New function
2352 which is like wait_for_termination, but allows keyboard
2353 interruptions.
2354
2355 * callproc.c (Fcall_process): Add (:file "file") as an option for
2356 the STDOUT buffer.
2357 (Fcall_process_region): Ditto.
2358
2359 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2360
2361 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2362 rather than `XVECTOR (FOO)->size'.
2363
2364 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2365 inttypes.h, as a gnulib replacement is used if it not available in
2366 system headers.
2367
2368 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2369
2370 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2371 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2372 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2373
2374 * coding.c (coding_alloc_by_realloc): Error out if destination
2375 will grow beyond MOST_POSITIVE_FIXNUM.
2376 (decode_coding_emacs_mule): Abort if there isn't enough place in
2377 charbuf for the composition carryover bytes. Reserve an extra
2378 space for up to 2 characters produced in a loop.
2379 (decode_coding_iso_2022): Abort if there isn't enough place in
2380 charbuf for the composition carryover bytes.
2381
2382 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2383
2384 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2385 aborting when %lld or %lll format is passed.
2386 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2387 %llo or %llx format is passed. (Bug#8545)
2388
2389 * window.c (window_scroll_line_based): Use a marker instead of
2390 simple variables to record original value of point. (Bug#7952)
2391
2392 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2393 produced by %s or %c overflows available buffer space. (Bug#8545)
2394
2395 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2398 (SIZE_MAX): Move defn after all includes, as they might #define it.
2399
2400 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2401
2402 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2403
2404 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2405
2406 * keyboard.c (Qdelayed_warnings_hook): Define.
2407 (command_loop_1): Run `delayed-warnings-hook'
2408 if Vdelayed_warnings_list is non-nil.
2409 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2410 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2411
2412 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2413
2414 * doprnt.c (doprnt): Don't return value smaller than the buffer
2415 size if the message was truncated. (Bug#8545).
2416
2417 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2418
2419 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2420 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2421
2422 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2423
2424 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2425
2426 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2427
2428 * makefile.w32-in: Update dependencies.
2429
2430 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2431
2432 Improve `doprnt' and its usage. (Bug#8545)
2433 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2434 `format_end'. Remove support for %l as a conversion specifier.
2435 Don't use xrealloc. Improve diagnostics when the %l size modifier
2436 is used. Update the commentary.
2437
2438 * eval.c (verror): Simplify calculation of size_t.
2439
2440 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2441 messages.
2442
2443 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2444
2445 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2446 change.
2447
2448 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2449
2450 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2451 This makes this file independent of the recent pseudovector change.
2452
2453 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2454
2455 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2456
2457 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2458 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2459 Remove unused local.
2460 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2461
2462 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2463 GCC 4.6.0 optimizes based on type-based alias analysis.
2464 For example, if b is of type struct buffer * and v of type struct
2465 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2466 != &v->size, and therefore "v->size = 1; b->size = 2; return
2467 v->size;" must therefore return 1. This assumption is incorrect
2468 for Emacs, since it type-puns struct Lisp_Vector * with many other
2469 types. To fix this problem, this patch adds a new type struct
2470 vectorlike_header that documents the constraints on layout of vectors
2471 and pseudovectors, and helps optimizing compilers not get fooled
2472 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2473 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2474 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2475 the size member.
2476 (XSETPVECTYPE): Rewrite in terms of new macro.
2477 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2478 This is a bit clearer, and further avoids the possibility of
2479 undesirable aliasing.
2480 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2481 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2482 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2483 since Lisp_Subr is a special case (no "next" field).
2484 (ASIZE): Now uses header.size rather than size.
2485 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2486 to avoid the hassle of writing XVECTOR (foo)->header.size.
2487 (struct vectorlike_header): New type.
2488 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2489 object, to help avoid aliasing.
2490 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2491 (SUBRP): Likewise, since Lisp_Subr is a special case.
2492 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2493 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2494 (struct Lisp_Hash_Table): Combine first two members into a single
2495 struct vectorlike_header member. All uses of "size" and "next" members
2496 changed to be "header.size" and "header.next".
2497 * buffer.h (struct buffer): Likewise.
2498 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2499 * frame.h (struct frame): Likewise.
2500 * process.h (struct Lisp_Process): Likewise.
2501 * termhooks.h (struct terminal): Likewise.
2502 * window.c (struct save_window_data, struct saved_window): Likewise.
2503 * window.h (struct window): Likewise.
2504 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2505 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2506 * buffer.c (init_buffer_once): Likewise.
2507 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2508 special case.
2509 * process.c (Fformat_network_address): Use local var for size,
2510 for brevity.
2511
2512 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2513
2514 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2515 * data.c (atof): Remove decl; no longer used or needed.
2516 (digit_to_number): Move to lread.c.
2517 (Fstring_to_number): Use new string_to_number function, to be
2518 consistent with how the Lisp reader treats infinities and NaNs.
2519 Do not assume that floating-point numbers represent EMACS_INT
2520 without losing information; this is not true on most 64-bit hosts.
2521 Avoid double-rounding errors, by insisting on integers when
2522 parsing non-base-10 numbers, as the documentation specifies.
2523 * lisp.h (string_to_number): New decl, replacing ...
2524 (isfloat_string): Remove.
2525 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2526 (read1): Do not accept +. and -. as integers; this
2527 appears to have been a coding error. Similarly, do not accept
2528 strings like +-1e0 as floating point numbers. Do not report
2529 overflow for integer overflows unless the base is not 10 which
2530 means we have no simple and reliable way to continue.
2531 Break out the floating-point parsing into a new
2532 function string_to_number, so that Fstring_to_number parses
2533 floating point numbers consistently with the Lisp reader.
2534 (digit_to_number): Move here from data.c. Make it static inline.
2535 (E_CHAR, EXP_INT): Remove, replacing with ...
2536 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2537 (string_to_number): New function, replacing isfloat_string.
2538 This function checks for valid syntax and produces the resulting
2539 Lisp float number too. Rework it so that string-to-number
2540 no longer mishandles examples like "1.0e+". Use strtoumax,
2541 so that overflow for non-base-10 numbers is reported only when
2542 there's no portable and simple way to convert to floating point.
2543
2544 * textprop.c (set_text_properties_1): Rewrite for clarity,
2545 and to avoid GCC warning about integer overflow.
2546
2547 * intervals.h (struct interval): Use EMACS_INT for members
2548 where EMACS_UINT might cause problems. See
2549 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2550 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2551 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2552 All uses changed.
2553 (offset_intervals): Tell GCC not to worry about length overflow
2554 when negating a negative length.
2555
2556 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2557 (overrun_check_free): Likewise.
2558
2559 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2560 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2561 word size.
2562
2563 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2564 (gnutls_make_error): Rename local to avoid shadowing.
2565 (gnutls_emacs_global_deinit): ifdef out; not used.
2566 (Fgnutls_boot): Use const for pointer to readonly storage.
2567 Comment out unused local. Fix pointer signedness problems.
2568
2569 * lread.c (openp): Don't stuff size_t into an 'int'.
2570 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2571 about possible signed overflow.
2572
2573 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2574 (GDK_KEY_g): Don't define if already defined.
2575 (xg_prepare_tooltip): Avoid pointer signedness problem.
2576 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2577
2578 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2579 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2580
2581 * xfns.c (Fx_window_property): Simplify a bit,
2582 to make a bit faster and to avoid GCC 4.6.0 warning.
2583 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2584
2585 * fns.c (internal_equal): Don't assume size_t fits in int.
2586
2587 * alloc.c (compact_small_strings): Tighten assertion a little.
2588
2589 Replace pEd with more-general pI, and fix some printf arg casts.
2590 * lisp.h (pI): New macro, generalizing old pEd macro to other
2591 conversion specifiers. For example, use "...%"pI"d..." rather
2592 than "...%"pEd"...".
2593 (pEd): Remove. All uses replaced with similar uses of pI.
2594 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2595 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2596 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2597 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2598 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2599 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2600 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2601 64-bit hosts.
2602 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2603 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2604 * print.c (safe_debug_print, print_object): Likewise.
2605 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2606 to int.
2607 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2608 avoiding the 0 flag, which is not portable.
2609 * process.c (Fmake_network_process): Use pI to avoid cast.
2610 * region-cache.c (pp_cache): Likewise.
2611 * xdisp.c (decode_mode_spec): Likewise.
2612 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2613 behavior on 64-bit hosts with printf arg.
2614 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2615 (x_stop_queuing_selection_requests): Likewise.
2616 (x_get_window_property): Don't truncate byte count to an 'int'
2617 when tracing.
2618
2619 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2620 here, since it parses constructs like leading '-' and spaces,
2621 which are not wanted; and it overflows with large numbers.
2622 Instead, simply match F[0-9]+, which is what is wanted anyway.
2623
2624 * alloc.c: Remove unportable assumptions about struct layout.
2625 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2626 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2627 (allocate_vectorlike, make_pure_vector): Use the new macros,
2628 plus offsetof, to remove unportable assumptions about struct layout.
2629 These assumptions hold on all porting targets that I know of, but
2630 they are not guaranteed, they're easy to remove, and removing them
2631 makes further changes easier.
2632
2633 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2634 This doesn't fix a bug but makes the code clearer.
2635 (string_overrun_cookie): Now const. Use initializers that
2636 don't formally overflow signed char, to avoid warnings.
2637 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2638 can cause Emacs to crash when string overrun checking is enabled.
2639 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2640 multiple of sizeof (EMACS_INT); it need not be, if
2641 alignof(EMACS_INT) < sizeof (EMACS_INT).
2642 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2643
2644 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2645
2646 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2647
2648 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2649
2650 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2651 supposed to be handshaking. (Bug#8556)
2652 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2653
2654 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2655
2656 * lisp.h (Qdebug): List symbol.
2657 * eval.c (Qdebug): Restore global linkage.
2658 * keyboard.c (debug-on-event): New variable.
2659 (handle_user_signal): Break into debugger when debug-on-event
2660 matches the current signal symbol.
2661
2662 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2663
2664 * alloc.c (check_sblock, check_string_bytes)
2665 (check_string_free_list): Convert to standard C.
2666
2667 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2668
2669 * w32.c (emacs_gnutls_push): Fix typo.
2670
2671 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2672
2673 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2674 "cast to pointer from integer of different size".
2675
2676 Improve doprnt and its use in verror. (Bug#8545)
2677 * doprnt.c (doprnt): Document the set of format control sequences
2678 supported by the function. Use SAFE_ALLOCA instead of always
2679 using `alloca'.
2680
2681 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2682 is one byte too soon. Don't use xrealloc; instead xfree and
2683 xmalloc anew.
2684
2685 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2686
2687 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2688 callbacks stage.
2689
2690 * gnutls.c: Renamed global_initialized to
2691 gnutls_global_initialized. Added internals for the
2692 :verify-hostname-error, :verify-error, and :verify-flags
2693 parameters of `gnutls-boot' and documented those parameters in the
2694 docstring. Start callback support.
2695 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2696 unless a fatal error occured. Call gnutls_alert_send_appropriate
2697 on error. Return error code.
2698 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2699 (emacs_gnutls_read): Likewise.
2700 (Fgnutls_boot): Return handshake error code.
2701 (emacs_gnutls_handle_error): New function.
2702 (wsaerror_to_errno): Likewise.
2703
2704 * w32.h (emacs_gnutls_pull): Add prototype.
2705 (emacs_gnutls_push): Likewise.
2706
2707 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2708 (emacs_gnutls_push): Likewise.
2709
2710 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2711
2712 * process.c (wait_reading_process_output): Check if GnuTLS
2713 buffered some data internally if no FDs are set for TLS
2714 connections.
2715
2716 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2717 (LIBS): Link to USER_LIBS.
2718 ($(BLD)/gnutls.$(0)): New target.
2719
2720 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2721
2722 * xdisp.c (handle_single_display_spec): Rename the
2723 display_replaced_before_p argument into display_replaced_p, to
2724 make it consistent with the commentary. Fix typos in the
2725 commentary.
2726
2727 * textprop.c (syms_of_textprop): Remove dead code.
2728 (copy_text_properties): Delete obsolete commentary about an
2729 interface that was deleted long ago. Fix typos in the description
2730 of arguments.
2731
2732 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2733 to changes in oldXMenu/XMenu.h from 2011-04-16.
2734 <menu_help_message, prev_menu_help_message>: Constify.
2735 (IT_menu_make_room): menu->help_text is now `const char **';
2736 adjust.
2737
2738 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2739 to changes in oldXMenu/XMenu.h from 2011-04-16.
2740 (struct XMenu): Declare `help_text' `const char **'.
2741
2742 * xfaces.c <Qunspecified>: Make extern again.
2743
2744 * syntax.c: Include sys/types.h before including regex.h, as
2745 required by Posix.
2746
2747 * doc.c (get_doc_string): Improve the format passed to `error'.
2748
2749 * doprnt.c (doprnt): Improve commentary.
2750
2751 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2752
2753 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2754 them with etags.
2755
2756 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2757 changes in globals.h immediately force recompilation.
2758 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2759 $(CURDIR)/s/ms-w32.h.
2760 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2761
2762 * character.c (Fchar_direction): Function deleted.
2763 (syms_of_character): Don't defsubr it.
2764 <char-direction-table>: Deleted.
2765
2766 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2767
2768 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2769 * doprnt.c: Include limits.h.
2770 (SIZE_MAX): New macro.
2771 (doprnt): Return a size_t value. 2nd arg is now size_t.
2772 Many local variables are now size_t instead of int or unsigned.
2773 Improve overflow protection. Support `l' modifier for integer
2774 conversions. Support %l conversion. Don't assume an EMACS_INT
2775 argument for integer conversions and for %c.
2776
2777 * lisp.h (doprnt): Restore prototype.
2778
2779 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2780 $(SRC)/character.h.
2781
2782 * Makefile.in (base_obj): Add back doprnt.o.
2783
2784 * deps.mk (doprnt.o): Add back prerequisites.
2785 (callint.o): Depend on character.h.
2786
2787 * eval.c (internal_lisp_condition_case): Include the handler
2788 representation in the error message.
2789 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2790 when breaking from the loop.
2791
2792 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2793
2794 * callint.c (Fcall_interactively): When displaying error message
2795 about invalid control letter, pass the character's codepoint, not
2796 a pointer to its multibyte form. Improve display of the character
2797 in octal and display also its hex code.
2798
2799 * character.c (char_string): Use %x to display the (unsigned)
2800 codepoint of an invalid character, to avoid displaying a bogus
2801 negative value.
2802
2803 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2804 `error', not SYMBOL_NAME itself.
2805
2806 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2807 character arguments to `error'.
2808
2809 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2810 to `error' in error message about FINAL_CHAR argument. Make sure
2811 FINAL_CHAR is a character, and use %c when it is passed as
2812 argument to `error'.
2813
2814 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2815
2816 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2817
2818 * w32.c: Include <time.h>.
2819 (sys_localtime): New function.
2820
2821 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2822
2823 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2824
2825 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2826
2827 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2828
2829 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2830 zombies (Bug#8467).
2831
2832 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2833
2834 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2835 gl_state.e_property when gl_state.object is Qt.
2836
2837 * insdel.c (make_gap_larger): Remove limitation of buffer size
2838 to <= INT_MAX.
2839
2840 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2841
2842 * xdisp.c (lookup_glyphless_char_display)
2843 (produce_glyphless_glyph): Handle cons cell entry in
2844 glyphless-char-display.
2845 (Vglyphless_char_display): Document it.
2846
2847 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2848 glyphless-char-display.
2849
2850 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2851
2852 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2853
2854 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2855
2856 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2857 definition for no-X builds.
2858
2859 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2860
2861 Static checks with GCC 4.6.0 and non-default toolkits.
2862
2863 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2864
2865 * process.c (keyboard_bit_set): Define only if SIGIO.
2866 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2867 (send_process): Repair possible setjmp clobbering.
2868
2869 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2870
2871 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2872
2873 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2874
2875 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2876 Define only if needed.
2877
2878 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2879 by pacifying GCC about it. Maybe it's time to retire it?
2880 * xfaces.c (USG, __TIMEVAL__): Likewise.
2881
2882 * dispextern.h (struct redisplay_interface): Rename param
2883 to avoid shadowing.
2884 * termhooks.h (struct terminal): Likewise.
2885 * xterm.c (xembed_send_message): Likewise.
2886
2887 * insdel.c (make_gap_smaller): Define only if
2888 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2889
2890 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2891 it.
2892
2893 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2894 so that we aren't warned about unused symbols.
2895
2896 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2897
2898 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2899
2900 * xfns.c (x_real_positions): Mark locals as initialized.
2901
2902 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2903
2904 * xterm.c: Fix problems found by static analysis with other toolkits.
2905 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2906 (x_dispatch_event): Declare static if USE_GTK, and
2907 define if USE_GTK || USE_X_TOOLKIT.
2908 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2909 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2910 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2911 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2912
2913 * xmenu.c (menu_help_callback): Pointer type fixes.
2914 Use const pointers when pointing at readonly data. Avoid pointer
2915 signedness clashes.
2916 (FALSE): Remove unused macro.
2917 (update_frame_menubar): Remove unused decl.
2918
2919 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2920
2921 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2922 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2923 (single_menu_item): Rename local to avoid shadowing.
2924
2925 * keyboard.c (make_lispy_event): Remove unused local var.
2926
2927 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2928 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2929
2930 * bitmaps: Change bitmaps from unsigned char back to the X11
2931 compatible char. Avoid the old compiler warnings about
2932 out-of-range initializers by using, for example, '\xab' rather
2933 than 0xab.
2934
2935 * xgselect.c (xgselect_initialize): Check vs interface
2936 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2937
2938 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2939
2940 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2941 to read-only memory.
2942
2943 * fns.c (vector): Remove; this old hack is no longer needed.
2944
2945 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2946 Remove unused var.
2947 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2948
2949 * xrdb.c (x_load_resources): Omit unused local.
2950
2951 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2952 (x_window): Rename locals to avoid shadowing.
2953 (USG): Use the kludged USG macro, to pacify gcc.
2954
2955 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2956 (x_term_init): Remove local to avoid shadowing.
2957
2958 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2959
2960 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2961 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2962
2963 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2964
2965 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2966
2967 Fix regex.c, syntax.c and friends for buffers > 2GB.
2968 * syntax.h (struct gl_state_s): Declare character position members
2969 EMACS_INT.
2970
2971 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2972
2973 * textprop.c (verify_interval_modification, interval_of):
2974 Declare arguments EMACS_INT.
2975
2976 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2977 EMACS_INT.
2978
2979 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2980
2981 * indent.c (Fvertical_motion): Local variable it_start is now
2982 EMACS_INT.
2983
2984 * regex.c (re_match, re_match_2, re_match_2_internal)
2985 (bcmp_translate, regcomp, regexec, print_double_string)
2986 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2987 (re_compile_pattern, re_exec): Declare arguments and local
2988 variables `size_t' and `ssize_t' and return values `regoff_t', as
2989 appropriate.
2990 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2991 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2992 <compile_stack_type>: `size' and `avail' are now `size_t'.
2993
2994 * regex.h <regoff_t>: Use ssize_t, not int.
2995 (re_search, re_search_2, re_match, re_match_2): Arguments that
2996 specify buffer/string position and length are now ssize_t and
2997 size_t. Return type is regoff_t.
2998
2999 2011-04-16 Ben Key <bkey76@gmail.com>
3000
3001 * nsfont.m: Fixed bugs in ns_get_family and
3002 ns_descriptor_to_entity that were caused by using free to
3003 deallocate memory blocks that were allocated by xmalloc (via
3004 xstrdup). This caused Emacs to crash when compiled with
3005 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3006 --enable-checking=xmallocoverrun). xfree is now used to
3007 deallocate these memory blocks.
3008
3009 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3010
3011 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3012
3013 emacs_write: Accept and return EMACS_INT for sizes.
3014 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3015 et seq.
3016 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3017 Accept and return EMACS_INT.
3018 (emacs_gnutls_write): Return the number of bytes written on
3019 partial writes.
3020 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3021 (emacs_read, emacs_write): Remove check for negative size, as the
3022 Emacs source code has been audited now.
3023 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3024 (emacs_read, emacs_write): Use it.
3025 * process.c (send_process): Adjust to the new signatures of
3026 emacs_write and emacs_gnutls_write. Do not attempt to store
3027 a byte offset into an 'int'; it might overflow.
3028 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3029
3030 * sound.c: Don't assume sizes fit in 'int'.
3031 (struct sound_device.period_size, alsa_period_size):
3032 Return EMACS_INT, not int.
3033 (struct sound_device.write, vox_write, alsa_write):
3034 Accept EMACS_INT, not int.
3035 (wav_play, au_play): Use EMACS_INT to store sizes and to
3036 record read return values.
3037
3038 2011-04-15 Ben Key <bkey76@gmail.com>
3039
3040 * keyboard.c (Qundefined): Don't declare static since it is used
3041 in nsfns.m.
3042 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3043 static since they are used in nsfont.m.
3044
3045 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3046
3047 * process.c (Qprocessp): Don't declare static.
3048 * lisp.h (Qprocessp): Declare again.
3049
3050 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3051
3052 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3053
3054 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3055
3056 Improve C-level modularity by making more things 'static'.
3057
3058 Don't publish debugger-only interfaces to other modules.
3059 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3060 (verify_bytepos, count_markers): Move decls to the only modules
3061 that need them.
3062 * region-cache.h (pp_cache): Likewise.
3063 * window.h (check_all_windows): Likewise.
3064 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3065
3066 * sysdep.c (croak): Now static, if
3067 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3068 * syssignal.h (croak): Declare only if not static.
3069
3070 * alloc.c (refill_memory_reserve): Now static if
3071 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3072 * lisp.h (refill_memory_reserve): Declare only if not static.
3073
3074 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3075 Define only if USE_LUCID.
3076
3077 * xrdb.c (x_customization_string, x_rm_string): Now static.
3078
3079 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3080 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3081
3082 * xdisp.c (draw_row_with_mouse_face): Now static.
3083 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3084
3085 * window.h (check_all_windows): Mark externally visible.
3086
3087 * window.c (window_deletion_count): Now static.
3088
3089 * undo.c: Make symbols static if they're not exported.
3090 (last_undo_buffer, last_boundary_position, pending_boundary):
3091 Now static.
3092
3093 * textprop.c (interval_insert_behind_hooks): Now static.
3094 (interval_insert_in_front_hooks): Likewise.
3095
3096 * term.c: Make symbols static if they're not exported.
3097 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3098 (max_frame_lines, tty_set_terminal_modes):
3099 (tty_reset_terminal_modes, tty_turn_off_highlight):
3100 (get_tty_terminal): Now static.
3101 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3102 * termhooks.h (term_mouse_moveto): Do not declare if
3103 HAVE_WINDOW_SYSTEM.
3104 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3105 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3106
3107 * sysdep.c: Make symbols static if they're not exported.
3108 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3109 Now static.
3110 (sigprocmask_set, full_mask): Remove; unused.
3111 (wait_debugging): Mark as visible.
3112 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3113 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3114
3115 * syntax.c (syntax_temp): Define only if !__GNUC__.
3116
3117 * sound.c (current_sound_device, current_sound): Now static.
3118
3119 * search.c (searchbufs, searchbuf_head): Now static.
3120
3121 * scroll.c (scroll_cost): Remove; unused.
3122 * dispextern.h (scroll_cost): Remove decl.
3123
3124 * region-cache.h (pp_cache): Mark as externally visible.
3125
3126 * process.c: Make symbols static if they're not exported.
3127 (process_tick, update_tick, create_process, chan_process):
3128 (Vprocess_alist, proc_buffered_char, datagram_access):
3129 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3130 (deactivate_process): Mark defn as static, as well as decl.
3131 * lisp.h (create_process): Remove decl.
3132 * process.h (chan_process, Vprocess_alist): Remove decls.
3133
3134 * print.c: Make symbols static if they're not exported.
3135 (print_depth, new_backquote_output, being_printed, print_buffer):
3136 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3137 (print_interval, print_number_index, initial_stderr_stream):
3138 Now static.
3139 * lisp.h (Fprinc): Remove decl.
3140 (debug_output_compilation_hack): Mark as externally visible.
3141
3142 * sysdep.c (croak): Move decl from here to syssignal.h.
3143 * syssignal.h (croak): Put it here, so the API can be checked when
3144 'croak' is called from dissociate_if_controlling_tty.
3145
3146 * minibuf.c: Make symbols static if they're not exported.
3147 (minibuf_save_list, choose_minibuf_frame): Now static.
3148 * lisp.h (choose_minibuf_frame): Remove decl.
3149
3150 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3151
3152 * lread.c: Make symbols static if they're not exported.
3153 (read_objects, initial_obarray, oblookup_last_bucket_number):
3154 Now static.
3155 (make_symbol): Remove; unused.
3156 * lisp.h (initial_obarray, make_symbol): Remove decls.
3157
3158 * keyboard.c: Make symbols static if they're not exported.
3159 (single_kboard, recent_keys_index, total_keys, recent_keys):
3160 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3161 (this_single_command_key_start, echoing, last_auto_save):
3162 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3163 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3164 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3165 (Vlispy_mouse_stem, double_click_count):
3166 Now static.
3167 (force_auto_save_soon): Define only if SIGDANGER.
3168 (ignore_mouse_drag_p): Now static if
3169 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3170 (print_help): Remove; unused.
3171 (stop_character, last_timer_event): Mark as externally visible.
3172 * keyboard.h (ignore_mouse_drag_p): Declare only if
3173 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3174 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3175 * lisp.h (echoing): Remove decl.
3176 (force_auto_save_soon): Declare only if SIGDANGER.
3177 * xdisp.c (redisplay_window): Simplify code, to make it more
3178 obvious that ignore_mouse_drag_p is not accessed if !defined
3179 USE_GTK && !defined HAVE_NS.
3180
3181 * intervals.c: Make symbols static if they're not exported.
3182 (merge_properties_sticky, merge_interval_right, delete_interval):
3183 Now static.
3184 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3185
3186 * insdel.c: Make symbols static if they're not exported.
3187 However, leave prepare_to_modify_buffer alone. It's never
3188 called from outside this function, but that appears to be a bug.
3189 (combine_after_change_list, combine_after_change_buffer):
3190 (adjust_after_replace, signal_before_change): Now static.
3191 (adjust_after_replace_noundo): Remove; unused.
3192 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3193 (signal_before_change): Remove decls.
3194
3195 * indent.c (val_compute_motion, val_vmotion): Now static.
3196
3197 * image.c: Make symbols static if they're not exported.
3198 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3199 if USE_GTK.
3200 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3201 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3202
3203 * fringe.c (standard_bitmaps): Now static.
3204 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3205
3206 * frame.c: Make symbols static if they're not exported.
3207 (x_report_frame_params, make_terminal_frame): Now static.
3208 (get_frame_param): Now static, unless HAVE_NS.
3209 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3210 (x_get_resource_string): Remove; not used.
3211 * frame.h (make_terminal_frame, x_report_frame_params):
3212 (x_get_resource_string); Remove decls.
3213 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3214 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3215
3216 * font.c, fontset.c: Make symbols static if they're not exported.
3217 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3218 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3219 * font.c (font_close_object): Now static.
3220 * font.h (font_close_object): Remove.
3221 * fontset.c (FONTSET_OBJLIST): Remove.
3222 (free_realized_fontset) #if-0 the body, which does nothing.
3223 (face_suitable_for_char_p): #if-0, as it's never called.
3224 * fontset.h (face_suitable_for_char_p): Remove decl.
3225 * xfaces.c (face_at_string_position):
3226 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3227 since 0 is always ASCII.
3228
3229 * fns.c (weak_hash_tables): Now static.
3230
3231 * fileio.c: Make symbols static if they're not exported.
3232 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3233 (Vwrite_region_annotation_buffers): Now static.
3234
3235 * eval.c: Make symbols static if they're not exported.
3236 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3237 * lisp.h (backtrace_list): Remove decl.
3238
3239 * emacs.c: Make symbols static if they're not exported.
3240 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3241 (fatal_error_code, fatal_error_signal_hook, standard_args):
3242 Now static.
3243 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3244 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3245 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3246 * lisp.h (fatal_error_signal_hook): Remove decl.
3247 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3248
3249 * editfns.c: Move a (normally-unused) function to its only use.
3250 * editfns.c, lisp.h (get_operating_system_release): Remove.
3251 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3252 worth the hassle of breaking this out.
3253
3254 * xterm.c: Make symbols static if they're not exported.
3255 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3256 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3257 (x_destroy_window, x_delete_display):
3258 Now static.
3259 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3260 (x_mouse_leave): Remove; unused.
3261 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3262 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3263 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3264 Remove decls.
3265 (x_mouse_leave): Declare only if WINDOWSNT.
3266 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3267 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3268 USE_X_TOOLKIT.
3269
3270 * ftxfont.c: Make symbols static if they're not exported.
3271 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3272 HAVE_FREETYPE.
3273 * font.h (ftxfont_driver): Likewise.
3274
3275 * xfns.c: Make symbols static if they're not exported.
3276 (x_last_font_name, x_display_info_for_name):
3277 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3278 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3279 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3280 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3281 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3282 (last_show_tip_args): Now static.
3283 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3284 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3285 (x_screen_planes): Remove; unused.
3286 * dispextern.h (x_screen_planes): Remove decl.
3287
3288 * dispnew.c: Make symbols static if they're not exported.
3289 * dispextern.h (redraw_garbaged_frames, scrolling):
3290 (increment_row_positions): Remove.
3291 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3292 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3293 Now static.
3294 (redraw_garbaged_frames): Remove; unused.
3295
3296 * xfaces.c: Make symbols static if they're not exported.
3297 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3298 Remove decls.
3299 * xterm.h (defined_color): Remove decls.
3300 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3301 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3302 (menu_face_changed_default, defined_color, free_realized_face):
3303 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3304 (ascii_face_of_lisp_face): Remove; unused.
3305
3306 * xdisp.c: Make symbols static if they're not exported.
3307 * dispextern.h (scratch_glyph_row, window_box_edges):
3308 (glyph_to_pixel_coords, set_cursor_from_row):
3309 (get_next_display_element, set_iterator_to_next):
3310 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3311 (show_mouse_face): Remove decls
3312 * frame.h (message_buf_print): Likewise.
3313 * lisp.h (pop_message, set_message, check_point_in_composition):
3314 Likewise.
3315 * xterm.h (set_vertical_scroll_bar): Likewise.
3316 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3317 (message_buf_print, scratch_glyph_row, displayed_buffer):
3318 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3319 (get_next_display_element, show_mouse_face, window_box_edges):
3320 (frame_to_window_pixel_xy, check_point_in_composition):
3321 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3322 (glyph_to_pixel_coords): Remove; unused.
3323
3324 * dired.c (file_name_completion): Now static.
3325
3326 * dbusbind.c (xd_in_read_queued_messages): Now static.
3327
3328 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3329 * data.c (circular_list_error): Remove.
3330
3331 * commands.h (last_point_position, last_point_position_buffer):
3332 (last_point_position_window): Remove decls.
3333 * keyboard.c: Make these variables static.
3334
3335 * coding.h (coding, code_convert_region, encode_coding_gap):
3336 Remove decls.
3337 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3338 (iso_code_class, detect_coding, code_convert_region): Now static.
3339 (encode_coding_gap): Remove; unused.
3340
3341 * chartab.c (chartab_chars, chartab_bits): Now static.
3342
3343 * charset.h (charset_iso_8859_1): Remove decl.
3344 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3345 Now static.
3346
3347 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3348 * ccl.c (Vccl_program_table): Now static.
3349 (check_ccl_update): Remove; unused.
3350
3351 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3352 * category.h: ... from here.
3353 * category.c (check_category_table, set_category_set): Now static.
3354
3355 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3356 * lisp.h: Remove these decls.
3357
3358 * buffer.c (buffer_count): Remove unused var.
3359
3360 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3361 so that it's not optimized away.
3362 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3363 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3364 exported only to the debugger.
3365
3366 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3367 * atimer.h (run_all_atimers): Remove; not exported.
3368
3369 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3370 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3371 was inaccessible from Lisp.
3372 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3373 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3374
3375 alloc.c: Import and export fewer symbols, and remove unused items.
3376 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3377 is defined.
3378 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3379 it's not optimized away by whole-program optimization.
3380 (message_enable_multibyte, free_misc): Remove.
3381 (catchlist, handlerlist, mark_backtrace):
3382 Declare only if BYTE_MARK_STACK.
3383 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3384 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3385 (message_enable_multibyte): Remove decl.
3386 (free_misc, interval_free_list, float_block, float_block_index):
3387 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3388 (cons_free_list, last_marked_index):
3389 Now static.
3390 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3391 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3392 (mark_backtrace): Define only if BYTE_MARK_STACK.
3393 * xdisp.c (message_enable_multibyte): Now static.
3394
3395 Declare Lisp_Object Q* variables to be 'static' if not exported.
3396 This makes it easier for human readers (and static analyzers)
3397 to see whether these variables are used from other modules.
3398 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3399 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3400 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3401 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3402 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3403 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3404 * xmenu.c, xselect.c:
3405 Declare Q* vars static if they are not used in other modules.
3406 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3407 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3408 Remove decls of unexported vars.
3409 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3410
3411 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3412
3413 Make Emacs functions such as Fatom 'static' by default.
3414 This makes it easier for human readers (and static analyzers)
3415 to see whether these functions can be called from other modules.
3416 DEFUN now defines a static function. To make the function external
3417 so that it can be used in other C modules, use the new macro DEFUE.
3418 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3419 (Finit_image_library):
3420 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3421 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3422 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3423 Remove decls, since these functions are now static.
3424 (Funintern, Fget_internal_run_time): New decls, since these functions
3425 were already external.
3426
3427 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3428 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3429 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3430 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3431 * keyboard.c, keymap.c, lread.c:
3432 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3433 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3434 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3435 Mark functions with DEFUE instead of DEFUN,
3436 if they are used in other modules.
3437 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3438 decls for now-static functions.
3439 * buffer.h (Fdelete_overlay): Remove decl.
3440 * callproc.c (Fgetenv_internal): Mark as internal.
3441 * composite.c (Fremove_list_of_text_properties): Remove decl.
3442 (Fcomposition_get_gstring): New forward static decl.
3443 * composite.h (Fcomposite_get_gstring): Remove decl.
3444 * dired.c (Ffile_attributes): New forward static decl.
3445 * doc.c (Fdocumntation_property): New forward static decl.
3446 * eval.c (Ffetch_bytecode): New forward static decl.
3447 (Funintern): Remove extern decl; now in .h file where it belongs.
3448 * fileio.c (Fmake_symbolic_link): New forward static decl.
3449 * image.c (Finit_image_library): New forward static decl.
3450 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3451 * intervals.h (Fprevious_property_change):
3452 (Fremove_list_of_text_properties): Remove decls.
3453 * keyboard.c (Fthis_command_keys): Remove decl.
3454 (Fcommand_execute): New forward static decl.
3455 * keymap.c (Flookup_key): New forward static decl.
3456 (Fcopy_keymap): Now static.
3457 * keymap.h (Flookup_key): Remove decl.
3458 * process.c (Fget_process): New forward static decl.
3459 (Fprocess_datagram_address): Mark as internal.
3460 * syntax.c (Fsyntax_table_p): New forward static decl.
3461 (skip_chars): Remove duplicate decl.
3462 * textprop.c (Fprevious_property_change): New forward static decl.
3463 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3464 Now internal.
3465 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3466 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3467
3468 * editfns.c (Fformat): Remove unreachable code.
3469
3470 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3471
3472 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3473 change. (Bug#8496)
3474
3475 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3476
3477 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3478 when at ZV. (Bug#8487)
3479
3480 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3481
3482 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3483 (Bug#8437)
3484 * keyboard.c (parse_tool_bar_item): Likewise.
3485 * sound.c (sound_cleanup, alsa_close): Likewise.
3486 * termcap.c (tgetent): Likewise.
3487 * xfns.c (x_default_font_parameter): Likewise.
3488 * xsettings.c (read_and_apply_settings): Likewise.
3489
3490 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3491 (overrun_check_free): Protoize.
3492
3493 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3494
3495 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3496 since callers should never pass a negative size.
3497 Change the signature to match that of plain 'read' and 'write'; see
3498 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3499 * lisp.h: Update prototypes of emacs_write and emacs_read.
3500
3501 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3502
3503 * xdisp.c (redisplay_window): Don't try to determine the character
3504 position of the scroll margin if the window start point w->startp
3505 is outside the buffer's accessible region. (Bug#8468)
3506
3507 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3508
3509 Fix write-region and its subroutines for buffers > 2GB.
3510 * fileio.c (a_write, e_write): Modify declaration of arguments and
3511 local variables to support buffers larger than 2GB.
3512 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3513
3514 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3515 argument, local variables, and return value.
3516
3517 * lisp.h: Update prototypes of emacs_write and emacs_read.
3518
3519 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3520
3521 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3522
3523 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3524
3525 Fix more problems found by GCC 4.6.0's static checks.
3526
3527 * xdisp.c (vmessage): Use a better test for character truncation.
3528
3529 * charset.c (load_charset_map): <, not <=, for optimization,
3530 and to avoid potential problems with integer overflow.
3531 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3532 * casetab.c (set_identity, shuffle): Likewise.
3533 * editfns.c (Fformat): Likewise.
3534 * syntax.c (skip_chars): Likewise.
3535
3536 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3537 This also lets GCC 4.6.0 generate slightly better loop code.
3538
3539 * callint.c (Fcall_interactively): <, not <=, for optimization.
3540 (Fcall_interactively): Count the number of arguments produced,
3541 not the number of arguments given. This is simpler and lets GCC
3542 4.6.0 generate slightly better code.
3543
3544 * ftfont.c: Distingish more carefully between FcChar8 and char.
3545 The previous code passed unsigned char * to a functions like
3546 strlen and xstrcasecmp that expect char *, which does not
3547 conform to the C standard.
3548 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3549 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3550 char * when the C standard requires it.
3551
3552 * keyboard.c (read_char): Remove unused var.
3553
3554 * eval.c: Port to Windows vsnprintf (Bug#8435).
3555 Include <limits.h>.
3556 (SIZE_MAX): Define if the headers do not.
3557 (verror): Do not give up if vsnprintf returns a negative count.
3558 Instead, grow the buffer. This ports to Windows vsnprintf, which
3559 does not conform to C99. Problem reported by Eli Zaretskii.
3560 Also, simplify the allocation scheme, by avoiding the need for
3561 calling realloc, and removing the ALLOCATED variable.
3562
3563 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3564
3565 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3566 But keep the doprint source code for now, as we might revamp it
3567 and use it again (Bug#8435).
3568 * lisp.h (doprnt): Remove.
3569 * Makefile.in (base_obj): Remove doprnt.o.
3570 * deps.mk (doprnt.o): Remove.
3571
3572 error: Print 32- and 64-bit integers portably (Bug#8435).
3573 Without this change, on typical 64-bit hosts error ("...%d...", N)
3574 was used to print both 32- and 64-bit integers N, which relied on
3575 undefined behavior.
3576 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3577 New macro.
3578 * lisp.h (error, verror): Mark as printf-like functions.
3579 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3580 Report overflow in size calculations when allocating printf buffer.
3581 Do not truncate output string at its first null byte.
3582 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3583 Truncate the output at a character boundary, since vsnprintf does not
3584 do that.
3585 * charset.c (check_iso_charset_parameter): Convert internal
3586 character to string before calling 'error', since %c now has the
3587 printf meaning.
3588 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3589 overflow when computing char to be passed to 'error'. Do not
3590 pass Lisp_Object to 'error'; pass the integer instead.
3591 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3592 formatted with plain %d.
3593
3594 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3595
3596 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3597
3598 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3599
3600 * xterm.c (x_catch_errors): Remove duplicate declaration.
3601
3602 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3603
3604 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3605
3606 2011-04-10 Jim Meyering <meyering@redhat.com>
3607
3608 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3609 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3610 return ssize_t not "int", and use size_t as the buffer length.
3611 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3612 * gnutls.h: Update declarations.
3613 * process.c (read_process_output): Use ssize_t, to match.
3614 (send_process): Likewise.
3615
3616 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3617
3618 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3619
3620 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3621
3622 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3623 Use unsigned char, to match FcChar8 type definition.
3624
3625 * xterm.c (handle_one_xevent):
3626 * xmenu.c (create_and_show_popup_menu):
3627 * xselect.c (x_decline_selection_request)
3628 (x_reply_selection_request): Avoid type-punned deref of X events.
3629
3630 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3631
3632 Fix some uses of `int' instead of EMACS_INT.
3633 * search.c (string_match_1, fast_string_match)
3634 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3635 (scan_buffer, find_next_newline_no_quit)
3636 (find_before_next_newline, search_command, Freplace_match)
3637 (Fmatch_data): Make some `int' variables be EMACS_INT.
3638
3639 * xdisp.c (display_count_lines): 3rd argument and return value now
3640 EMACS_INT. All callers changed.
3641 (pint2hrstr): Last argument is now EMACS_INT.
3642
3643 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3644 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3645 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3646 (decode_coding_utf_16, decode_coding_emacs_mule)
3647 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3648 (decode_coding_ccl, decode_coding_charset)
3649 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3650 (decode_coding_iso_2022, decode_coding_emacs_mule)
3651 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3652 <char_offset, last_offset>: Declare EMACS_INT.
3653 (encode_coding_utf_8, encode_coding_utf_16)
3654 (encode_coding_emacs_mule, encode_invocation_designation)
3655 (encode_designation_at_bol, encode_coding_iso_2022)
3656 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3657 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3658 Declare EMACS_INT.
3659 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3660 (encode_invocation_designation): Last argument P_NCHARS is now
3661 EMACS_INT.
3662 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3663 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3664
3665 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3666 All users changed.
3667
3668 * ccl.c (Fccl_execute_on_string): Declare some variables
3669 EMACS_INT.
3670
3671 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3672
3673 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3674
3675 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3676
3677 * process.c (Fformat_network_address): Doc fix.
3678
3679 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3680
3681 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3682
3683 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3684
3685 * keyboard.c (read_char): Call Lisp function help-form-show,
3686 instead of using internal_with_output_to_temp_buffer.
3687 (Qhelp_form_show): New var.
3688 (syms_of_keyboard): Use DEFSYM macro.
3689
3690 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3691
3692 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3693
3694 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3695
3696 * process.c (Flist_processes): Remove to Lisp.
3697 (list_processes_1): Delete.
3698
3699 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3700
3701 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3702
3703 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3704
3705 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 Fix more problems found by GCC 4.6.0's static checks.
3708
3709 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3710
3711 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3712
3713 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3714
3715 * xdisp.c (vmessage): Mark as a printf-like function.
3716
3717 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3718
3719 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3720
3721 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3722 printf-like functions.
3723 (tiff_load): Add casts to remove these marks before passing them
3724 to system-supplied API.
3725
3726 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3727
3728 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3729 This avoids several warnings with gcc -Wstrict-overflow.
3730 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3731 directly, rather than having caller test rule sign. This avoids
3732 some unnecessary tests.
3733 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3734 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3735 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3736
3737 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3738 (xfont_open): Avoid unnecessary tests.
3739
3740 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3741
3742 * composite.h, composite.c (composition_gstring_put_cache):
3743 Use EMACS_INT, not int, for length.
3744
3745 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3746 breaking out part of COMPOSITION_DECODE_RULE.
3747 (COMPOSITION_DECODE_RULE): Use it.
3748 * composite.c (get_composition_id): Remove unused local vars,
3749 by using the new macro.
3750
3751 * textprop.c (set_text_properties_1): Change while to do-while,
3752 since the condition is always true at first.
3753
3754 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3755 (interval_deletion_adjustment): Return unsigned value.
3756 All uses changed.
3757
3758 * process.c (list_processes_1, create_pty, read_process_output):
3759 (exec_sentinel): Remove vars that were set but not used.
3760 (create_pty): Remove unnecessary "volatile"s.
3761 (Fnetwork_interface_info): Avoid possibility of int overflow.
3762 (read_process_output): Do adaptive read buffering even if carryover.
3763 (read_process_output): Simplify nbytes computation if buffered.
3764
3765 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3766
3767 * syntax.c (scan_words): Remove var that was set but not used.
3768 (update_syntax_table): Use unsigned instead of int.
3769
3770 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3771 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3772 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3773
3774 * print.c (print_error_message): Avoid int overflow.
3775
3776 * font.c (font_list_entities): Redo for clarity,
3777 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3778
3779 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3780 (font_score): Avoid potential overflow in diff calculation.
3781
3782 * fns.c (substring_both): Remove var that is set but not used.
3783 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3784
3785 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3786
3787 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3788 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3789 can always succeed if overflow has undefined behavior.
3790
3791 * search.c (boyer_moore, wordify): Remove vars set but not used.
3792 (wordify): Omit three unnecessary tests.
3793
3794 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3795 All callers changed. This avoids the need for an unused var.
3796
3797 * casefiddle.c (casify_region): Remove var that is set but not used.
3798
3799 * dired.c (file_name_completion): Remove var that is set but not used.
3800
3801 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3802
3803 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3804 (Finsert_file_contents): Remove unnecessary code checking fd.
3805
3806 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3807 Check for integer overflow on size calculations.
3808
3809 * buffer.c (Fprevious_overlay_change): Remove var that is set
3810 but not used.
3811
3812 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3813 Remove vars that are set but not used.
3814 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3815 (timer_check_2): Mark vars as initialized.
3816
3817 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3818
3819 * image.c (lookup_image): Remove var that is set but not used.
3820 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3821
3822 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3823 that are set but not used.
3824
3825 * xfns.c (make_invisible_cursor): Don't return garbage
3826 if XCreateBitmapFromData fails (Bug#8410).
3827
3828 * xselect.c (x_get_local_selection, x_handle_property_notify):
3829 Remove vars that are set but not used.
3830
3831 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3832 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3833
3834 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3835 Remove var that is set but not used.
3836 (scroll_bar_windows_size): Now size_t, not int.
3837 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3838 Check for overflow.
3839
3840 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3841 (map_tty_color) [!defined MSDOS]: Likewise.
3842
3843 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3844
3845 * coding.c: Remove vars that are set but not used.
3846 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3847 All callers changed.
3848 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3849 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3850 (decode_coding_charset): Remove vars that are set but not used.
3851
3852 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3853 that is set but not used.
3854
3855 * print.c (print_object): Remove var that is set but not used.
3856
3857 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3858 The gnulib version avoids calling malloc in the usual case,
3859 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3860 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3861 * filelock.c (current_lock_owner): Likewise.
3862 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3863 * sysdep.c: Include allocator.h, careadlinkat.h.
3864 (emacs_no_realloc_allocator): New static constant.
3865 (emacs_readlink): New function.
3866 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3867 ../lib/careadlinkat.h.
3868
3869 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3870
3871 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3872 first non-nil return value).
3873
3874 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3875
3876 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3877 if not defined (Bug#8403).
3878
3879 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3880
3881 * xdisp.c (display_count_lines): Remove parameter `start',
3882 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3883 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3884 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3885 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3886 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3887 and thereabouts. All callers changed.
3888 (get_per_char_metric): Remove parameter `f', unused since
3889 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3890
3891 2011-04-02 Jim Meyering <meyering@redhat.com>
3892
3893 do not dereference NULL upon failed strdup
3894 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3895 (ns_get_family): Likewise.
3896
3897 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3898
3899 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3900
3901 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3902
3903 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3904 later (Bug#8403).
3905
3906 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3907
3908 Add lexical binding.
3909
3910 * window.c (Ftemp_output_buffer_show): New fun.
3911 (Fsave_window_excursion):
3912 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3913
3914 * lread.c (lisp_file_lexically_bound_p): New function.
3915 (Fload): Bind Qlexical_binding.
3916 (readevalloop): Remove `evalfun' arg.
3917 Bind Qinternal_interpreter_environment.
3918 (Feval_buffer): Bind Qlexical_binding.
3919 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3920 Mark as dynamic.
3921 (syms_of_lread): Declare `lexical-binding'.
3922
3923 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3924
3925 * keyboard.c (eval_dyn): New fun.
3926 (menu_item_eval_property): Use it.
3927
3928 * image.c (parse_image_spec): Use Ffunctionp.
3929
3930 * fns.c (concat, mapcar1): Accept byte-code-functions.
3931
3932 * eval.c (Fsetq): Handle lexical vars.
3933 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3934 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3935 (FletX, Flet): Obey lexical binding.
3936 (Fcommandp): Handle closures.
3937 (Feval): New `lexical' arg.
3938 (eval_sub): New function extracted from Feval. Use it almost
3939 everywhere where Feval was used. Look up vars in lexical env.
3940 Handle closures.
3941 (Ffunctionp): Move from subr.el.
3942 (Ffuncall): Handle closures.
3943 (apply_lambda): Remove `eval_flags'.
3944 (funcall_lambda): Handle closures and new byte-code-functions.
3945 (Fspecial_variable_p): New function.
3946 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3947 but without exporting it to Lisp.
3948
3949 * doc.c (Fdocumentation, store_function_docstring):
3950 * data.c (Finteractive_form): Handle closures.
3951
3952 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3953 interactive spec.
3954
3955 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3956 New byte-codes.
3957 (exec_byte_code): New function extracted from Fbyte_code to handle new
3958 calling convention for byte-code-functions. Add new byte-codes.
3959
3960 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3961
3962 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3963
3964 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3965
3966 * xdisp.c (redisplay_internal): Fix prototype.
3967
3968 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3969
3970 * xdisp.c (SCROLL_LIMIT): New macro.
3971 (try_scrolling): Use it when setting scroll_limit.
3972 Limit scrolling to 100 screen lines.
3973 (redisplay_window): Even when falling back on "recentering",
3974 position point in the window according to scroll-conservatively,
3975 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3976
3977 (try_scrolling): When point is above the window, allow searching
3978 as far as scroll_max, or one screenful, to compute vertical
3979 distance from PT to the scroll margin position. This prevents
3980 try_scrolling from unnecessarily failing when
3981 scroll-conservatively is set to a value slightly larger than the
3982 window height. Clean up the case of PT below the margin at bottom
3983 of window: scroll_max can no longer be INT_MAX. When aggressive
3984 scrolling is in use, don't let point enter the opposite scroll
3985 margin as result of the scroll.
3986 (syms_of_xdisp) <scroll-conservatively>: Document the
3987 threshold of 100 lines for never-recentering scrolling.
3988
3989 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3990
3991 * dispextern.h (move_it_by_lines):
3992 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3993 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3994 (message_log_check_duplicate): Remove parameters `prev_bol' and
3995 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3996 (redisplay_internal): Remove parameter `preserve_echo_area',
3997 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3998
3999 * indent.c (Fvertical_motion):
4000 * window.c (window_scroll_pixel_based, Frecenter):
4001 Don't pass `need_y_p' to `move_it_by_lines'.
4002
4003 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4004
4005 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4006 steal a few bits to be more compact.
4007 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4008 Remove unneeded casts.
4009
4010 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4011
4012 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4013
4014 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4015 binding" message (bug#7967).
4016
4017 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4018
4019 Fix more problems found by GCC 4.6.0's static checks.
4020
4021 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4022 Remove unused local var.
4023
4024 * editfns.c (Fmessage_box): Remove unused local var.
4025
4026 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4027 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4028 Omit unused local vars.
4029 * window.c (shrink_windows): Omit unused local var.
4030 * menu.c (digest_single_submenu): Omit unused local var.
4031 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4032 Omit unused local var.
4033
4034 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4035 Don't assume string length fits in int.
4036 (keyremap_step, read_key_sequence): Use size_t for sizes.
4037 (read_key_sequence): Don't check last_real_key_start redundantly.
4038
4039 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4040 instead of alloca (Bug#8344).
4041
4042 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4043 (Fbacktrace_frame): Don't assume nframes fits in int.
4044
4045 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4046
4047 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4048 concerns.
4049
4050 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4051
4052 * cm.c (calccost): Turn while-do into do-while, for clarity.
4053
4054 * keyboard.c (syms_of_keyboard): Use the same style as later
4055 in this function when indexing through an array. This also
4056 works around GCC bug 48267.
4057
4058 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4059
4060 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4061
4062 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4063 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4064
4065 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4066 This avoids undefined behavior on integer overflow, and is a bit
4067 more convenient anyway since it is compared to a size_t variable.
4068
4069 Variadic C functions now count arguments with size_t, not int.
4070 This avoids an unnecessary limitation on 64-bit machines, which
4071 caused (substring ...) to crash on large vectors (Bug#8344).
4072 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4073 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4074 All variadic functions and their callers changed accordingly.
4075 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4076 * data.c (arith_driver, float_arith_driver): Likewise.
4077 * editfns.c (general_insert_function): Likewise.
4078 * eval.c (struct backtrace.nargs, interactive_p)
4079 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4080 (funcall_lambda, mark_backtrace): Likewise.
4081 * fns.c (concat): Likewise.
4082 * frame.c (x_set_frame_parameters): Likewise.
4083 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4084 0 if not found, not -1. All callers changed.
4085
4086 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4087 (stack_copy_size): Now size_t, not int.
4088 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4089
4090 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4091
4092 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4093 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4094 All callers changed.
4095
4096 * lisp.h (multibyte_char_to_unibyte):
4097 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4098 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4099 * character.h (CHAR_TO_BYTE8):
4100 * cmds.c (internal_self_insert):
4101 * editfns.c (general_insert_function):
4102 * keymap.c (push_key_description):
4103 * search.c (Freplace_match):
4104 * xdisp.c (message_dolog, set_message_1): All callers changed.
4105
4106 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4107
4108 * keyboard.c (safe_run_hook_funcall): New function.
4109 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4110 don't set the hook to nil, but remove the offending function instead.
4111 (Qcommand_hook_internal): Remove, unused.
4112 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4113 Vcommand_hook_internal.
4114
4115 * eval.c (enum run_hooks_condition): Remove.
4116 (funcall_nil, funcall_not): New functions.
4117 (run_hook_with_args): Call each function through a `funcall' argument.
4118 Remove `cond' argument, now redundant.
4119 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4120 (Frun_hook_with_args_until_failure): Adjust accordingly.
4121 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4122
4123 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4124
4125 * dispextern.h (string_buffer_position): Remove declaration.
4126
4127 * print.c (strout): Remove parameter `multibyte', unused since
4128 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4129
4130 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4131 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4132 All callers changed.
4133
4134 * w32.c (_wsa_errlist): Use braces for struct initializers.
4135
4136 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4137 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4138 All callers changed.
4139 (string_buffer_position): Likewise. Also, make static (it's never
4140 used outside xdisp.c).
4141 (cursor_row_p): Remove parameter `w', unused since
4142 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4143 (decode_mode_spec): Remove parameter `precision', introduced during
4144 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4145 All callers changed.
4146
4147 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4148
4149 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4150
4151 2011-03-27 Anders Lindgren <andlind@gmail.com>
4152
4153 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4154 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4155 (ns_update_auto_hide_menu_bar): New functions.
4156 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4157 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4158 ns_constrain_all_frames.
4159 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4160 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4161
4162 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4163
4164 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4165
4166 2011-03-27 Glenn Morris <rgm@gnu.org>
4167
4168 * syssignal.h: Replace RETSIGTYPE with void.
4169 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4170 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4171 Replace SIGTYPE with void everywhere.
4172 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4173 * s/template.h (SIGTYPE): Remove commented out definition.
4174
4175 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4176
4177 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4178 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4179
4180 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4181
4182 * w32.c (read_unc_volume): Use parameter `henum', instead of
4183 global variable `wget_enum_handle'.
4184
4185 * keymap.c (describe_vector): Remove parameters `indices' and
4186 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4187 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4188
4189 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4190
4191 * keyboard.c (timer_check): Remove parameter `do_it_now',
4192 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4193 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4194 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4195
4196 * keyboard.c (read_char):
4197 * w32menu.c (w32_menu_display_help):
4198 * xmenu.c (show_help_event, menu_help_callback):
4199 Adjust calls to `show_help_echo'.
4200
4201 * gtkutil.c (xg_maybe_add_timer):
4202 * keyboard.c (readable_events):
4203 * process.c (wait_reading_process_output):
4204 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4205
4206 * insdel.c (adjust_markers_gap_motion):
4207 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4208 (gap_left, gap_right): Don't call it.
4209
4210 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4211
4212 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4213 incurred during fontification.
4214
4215 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4216
4217 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4218 (DEFVAR_PER_BUFFER): Don't pass it.
4219
4220 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4221 (scrolling_window): Don't pass it.
4222
4223 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4224
4225 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4226
4227 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4228 and `suffix'.
4229 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4230 of variables specific to SELinux and computation of `encoded_absname'.
4231
4232 * image.c (XPutPixel): Remove unused variable `height'.
4233
4234 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4235
4236 * unexw32.c (get_section_info): Remove unused variable `section'.
4237
4238 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4239 (system_process_attributes): Remove unused variable `sess'.
4240 (sys_read): Remove unused variable `err'.
4241
4242 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4243 (w32_wnd_proc): Remove unused variable `isdead'.
4244 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4245 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4246 (x_create_tip_frame): Remove unused variable `tem'.
4247
4248 * w32inevt.c (w32_console_read_socket):
4249 Remove unused variable `no_events'.
4250
4251 * w32term.c (x_draw_composite_glyph_string_foreground):
4252 Remove unused variable `width'.
4253
4254 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4255
4256 * w32term.c (x_set_glyph_string_clipping):
4257 Don't pass uninitialized region to CombineRgn.
4258
4259 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4260
4261 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4262 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4263 (Fx_close_connection): Remove unused variable `i'.
4264
4265 * w32font.c (w32font_draw): Return number of glyphs.
4266 (w32font_open_internal): Remove unused variable `i'.
4267 (w32font_driver): Add missing initializer.
4268
4269 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4270 (fill_in_menu): Remove unused variable `items_added'.
4271
4272 * w32term.c (last_mouse_press_frame): Remove static global variable.
4273 (w32_clip_to_row): Remove unused variable `f'.
4274 (x_delete_terminal): Remove unused variable `i'.
4275
4276 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4277 (NOTHING): Remove unused static global variable.
4278 (uniscribe_check_otf): Remove unused variable `table'.
4279 (uniscribe_font_driver): Add missing initializers.
4280
4281 2011-03-23 Julien Danjou <julien@danjou.info>
4282
4283 * term.c (Fsuspend_tty, Fresume_tty):
4284 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4285 * window.c (temp_output_buffer_show):
4286 * insdel.c (signal_before_change):
4287 * frame.c (Fhandle_switch_frame):
4288 * fileio.c (Fdo_auto_save):
4289 * emacs.c (Fkill_emacs):
4290 * editfns.c (save_excursion_restore):
4291 * cmds.c (internal_self_insert):
4292 * callint.c (Fcall_interactively):
4293 * buffer.c (Fkill_all_local_variables):
4294 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4295 Use Frun_hooks.
4296 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4297 unconditionnaly since it does the check itself.
4298
4299 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4300
4301 Fix more problems found by GCC 4.5.2's static checks.
4302
4303 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4304 the first time through the loop, since we know p0 < p1 then.
4305 This also avoids a gcc -Wstrict-overflow warning.
4306
4307 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4308 leading to a memory leak, possible in functions like
4309 load_charset_map_from_file that can allocate an unbounded number
4310 of objects (Bug#8318).
4311
4312 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4313 that could (at least in theory) be that large.
4314
4315 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4316 This is less likely to overflow, and avoids undefined behavior if
4317 overflow does occur. All callers changed. Use strtoul to scan
4318 for the unsigned long integer.
4319 (pint2hrstr): Simplify and tune code slightly.
4320 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4321
4322 * scroll.c (do_scrolling): Work around GCC bug 48228.
4323 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4324
4325 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4326 This also avoids a warning with gcc -Wstrict-overflow.
4327 (validate_x_resource_name): Simplify count usage.
4328 This also avoids a warning with gcc -Wstrict-overflow.
4329
4330 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4331 fail (Bug#8306).
4332
4333 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4334
4335 * process.c (Fmake_network_process): Use socklen_t, not int,
4336 where POSIX says socklen_t is required in portable programs.
4337 This fixes a porting bug on hosts like 64-bit HP-UX, where
4338 socklen_t is wider than int (Bug#8277).
4339 (Fmake_network_process, server_accept_connection):
4340 (wait_reading_process_output, read_process_output):
4341 Likewise.
4342
4343 * process.c: Rename or move locals to avoid shadowing.
4344 (list_processes_1, Fmake_network_process):
4345 (read_process_output_error_handler, exec_sentinel_error_handler):
4346 Rename or move locals.
4347 (Fmake_network_process): Define label "retry_connect" only if needed.
4348 (Fnetwork_interface_info): Fix pointer signedness.
4349 (process_send_signal): Add cast to avoid pointer signedness problem.
4350 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4351 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4352
4353 Make tparam.h and terminfo.c consistent.
4354 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4355 Include tparam.h instead, since it declares them.
4356 * cm.h (PC): Remove extern decl; tparam.h now does this.
4357 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4358 * terminfo.c: Include tparam.h, to check interfaces.
4359 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4360 (tparam): Adjust signature to match interface in tparam.h;
4361 this removes some undefined behavior. Check that outstring and len
4362 are zero, which they always are with Emacs.
4363 * tparam.h (PC, BC, UP): New extern decls.
4364
4365 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4366 (xftfont_open): Rename locals to avoid shadowing.
4367
4368 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4369 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4370 (OTF_TAG_SYM): Omit macro if not needed.
4371 (ftfont_list): Remove unused local.
4372 (get_adstyle_property, ftfont_pattern_entity):
4373 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4374 Rename locals to avoid shadowing.
4375
4376 * xfont.c (xfont_list_family): Mark var as initialized.
4377
4378 * xml.c (make_dom): Now static.
4379
4380 * composite.c (composition_compute_stop_pos): Rename local to
4381 avoid shadowing.
4382 (composition_reseat_it): Remove unused locals.
4383 (find_automatic_composition, composition_adjust_point): Likewise.
4384 (composition_update_it): Mark var as initialized.
4385 (find_automatic_composition): Mark vars as initialized,
4386 with a FIXME (Bug#8290).
4387
4388 character.h: Rename locals to avoid shadowing.
4389 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4390 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4391 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4392 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4393 to avoid shadowing.
4394
4395 * textprop.c (property_change_between_p): Remove; unused.
4396
4397 * intervals.c (interval_start_pos): Now static.
4398
4399 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4400
4401 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4402 Rename locals to avoid shadowing.
4403
4404 * sound.c (wav_play, au_play, Fplay_sound_internal):
4405 Fix pointer signedness.
4406 (alsa_choose_format): Remove unused local var.
4407 (wav_play): Initialize a variable to 0, to prevent undefined
4408 behavior (Bug#8278).
4409
4410 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4411
4412 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4413
4414 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4415 clobbering (Bug#8298).
4416 * sysdep.c (sys_subshell): Likewise.
4417 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4418
4419 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4420 This should get cleaned up, so that child_setup has the
4421 same signature on all platforms.
4422
4423 * callproc.c (call_process_cleanup): Now static.
4424 (relocate_fd): Rename locals to avoid shadowing.
4425
4426 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4427
4428 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4429 not to be necessary, and produces flickering.
4430
4431 2011-03-20 Glenn Morris <rgm@gnu.org>
4432
4433 * config.in: Remove file.
4434
4435 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4436
4437 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4438 are now in src/globals.h.
4439 (syms_of_minibuf): Remove spurious & from previous change.
4440
4441 2011-03-20 Leo <sdl.web@gmail.com>
4442
4443 * minibuf.c (completing-read-function): New variable.
4444 (completing-read-default): Rename from completing-read.
4445 (completing-read): Call completing-read-function.
4446
4447 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4448
4449 * xfaces.c (Fx_load_color_file):
4450 Read color file from absolute filename (bug#8250).
4451
4452 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4453
4454 * makefile.w32-in: Update dependencies.
4455
4456 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4457
4458 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4459
4460 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4461
4462 Fix more problems found by GCC 4.5.2's static checks.
4463
4464 * process.c (make_serial_process_unwind, send_process_trap):
4465 (sigchld_handler): Now static.
4466
4467 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4468 That way, the code declares only the vars that it needs.
4469 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4470 * s/cygwin.h (PTY_ITERATION): Likewise.
4471 * s/darwin.h (PTY_ITERATION): Likewise.
4472 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4473
4474 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4475 * process.c (allocate_pty): Don't declare stb unless it's needed.
4476
4477 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4478 (CONSTANTLIM): Remove; unused.
4479 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4480 Define only if needed.
4481
4482 * unexelf.c (unexec): Name an expression,
4483 to avoid gcc -Wbad-function-cast warning.
4484 Use a different way to cause a compilation error if anyone uses
4485 n rather than nn, a way that does not involve shadowing.
4486 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4487
4488 * deps.mk (unexalpha.o): Remove; unused.
4489
4490 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4491 * unexec.h: New file.
4492 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4493 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4494 Depend on unexec.h.
4495 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4496 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4497 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4498 Change as necessary to match prototype in unexec.h.
4499
4500 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4501 shadowing.
4502 (back_comment, skip_chars): Mark vars as initialized.
4503
4504 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4505 Rename locals to avoid shadowing.
4506
4507 * lread.c (read1): Rewrite so as not to use empty "else".
4508 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4509
4510 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4511
4512 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4513 warning when compiling print.c.
4514
4515 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4516 instead of using an uninitialized var.
4517 (font_sort_entities): Mark var as initialized.
4518
4519 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4520
4521 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4522 pointers to constants.
4523 (font_parse_fcname): Remove unused vars.
4524 (font_delete_unmatched): Now static.
4525 (font_get_spec): Remove; unused.
4526 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4527 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4528 Rename or move locals to avoid shadowing.
4529
4530 * fns.c (require_nesting_list, require_unwind): Now static.
4531 (Ffillarray): Rename locals to avoid shadowing.
4532
4533 * floatfns.c (domain_error2): Define only if needed.
4534 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4535
4536 * alloc.c (mark_backtrace): Move decl from here ...
4537 * lisp.h: ... to here, so that it can be checked.
4538
4539 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4540 (Fdefvar): Rewrite so as not to use empty "else".
4541 (lisp_indirect_variable): Name an expression,
4542 to avoid gcc -Wbad-function-cast warning.
4543 (Fdefvar): Rename locals to avoid shadowing.
4544
4545 * callint.c (quotify_arg, quotify_args): Now static.
4546 (Fcall_interactively): Rename locals to avoid shadowing.
4547 Use const pointer when appropriate.
4548
4549 * lisp.h (get_system_name, get_operating_system_release):
4550 Move decls here, to check interfaces.
4551 * process.c (get_operating_system_release): Move decl to lisp.h.
4552 * xrdb.c (get_system_name): Likewise.
4553 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4554 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4555 some of which prompt warnings from gcc -Wbad-function-cast.
4556 (Fformat_time_string, Fencode_time, Finsert_char):
4557 (Ftranslate_region_internal, Fformat):
4558 Rename or remove local vars to avoid shadowing.
4559 (Ftranslate_region_internal): Mark var as initialized.
4560
4561 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4562 avoid shadowing.
4563
4564 * lisp.h (eassert): Check that the argument compiles, even if
4565 ENABLE_CHECKING is not defined.
4566
4567 * data.c (Findirect_variable): Name an expression, to avoid
4568 gcc -Wbad-function-cast warning.
4569 (default_value, arithcompare, arith_driver, arith_error): Now static.
4570 (store_symval_forwarding): Rename local to avoid shadowing.
4571 (Fmake_variable_buffer_local, Fmake_local_variable):
4572 Mark variables as initialized.
4573 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4574
4575 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4576 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4577 Rename locals to avoid shadowing.
4578 (mark_stack): Move local variables into the #ifdef region where
4579 they're used.
4580 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4581 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4582 needed otherwise.
4583 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4584 (GC_STRING_CHARS): Remove; not used.
4585 (Fmemory_limit): Cast sbrk's returned value to char *.
4586
4587 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4588 avoids undefined behavior in theory.
4589
4590 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4591
4592 Use functions, not macros, for up- and down-casing (Bug#8254).
4593 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4594 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4595 to use the following functions instead of these macros.
4596 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4597 EMACS_INT, since callers assume the returned value fits in int.
4598 (upcase1): Likewise, for UPCASE_TABLE.
4599 (uppercasep, lowercasep, upcase): New static inline functions.
4600 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4601 the race-condition problem in the old DOWNCASE.
4602
4603 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4604 Rename locals to avoid shadowing.
4605 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4606 (regex_compile, re_search_2, re_match_2_internal):
4607 Remove unused local vars.
4608 (FREE_VAR): Rewrite so as not to use empty "else",
4609 which gcc can warn about.
4610 (regex_compile, re_match_2_internal): Mark locals as initialized.
4611 (RETALLOC_IF): Define only if needed.
4612 (WORDCHAR_P): Likewise. This one is never needed, but is used
4613 only in a comment talking about a compiler bug, so put inside
4614 the #if 0 of that comment.
4615 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4616 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4617 Remove; unused.
4618
4619 * search.c (boyer_moore): Rename locals to avoid shadowing.
4620 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4621 (PREV_CHAR_BOUNDARY): Likewise.
4622
4623 * search.c (simple_search): Remove unused var.
4624
4625 * dired.c (compile_pattern): Move decl from here ...
4626 * lisp.h: ... to here, so that it can be checked.
4627 (struct re_registers): New forward decl.
4628
4629 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4630
4631 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4632 All uses changed.
4633 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4634 Rename locals to avoid shadowing.
4635 (Fvertical_motion): Mark locals as initialized.
4636
4637 * casefiddle.c (casify_object, casify_region): Now static.
4638 (casify_region): Mark local as initialized.
4639
4640 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4641
4642 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4643 New macros, so that the caller can use some names other than
4644 gcpro1, gcpro2, etc.
4645 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4646 of the new macros.
4647 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4648 argument, for consistency with GCPRO2_VAR, etc: it is now the
4649 prefix of the variable, not the variable itself. All uses
4650 changed.
4651 * dired.c (directory_files_internal, file_name_completion):
4652 Rename locals to avoid shadowing.
4653
4654 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4655 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4656 dired.c's scmp function, had undefined behavior.
4657 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4658 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4659 * buffer.h: ... to here, because these macros use current_buffer,
4660 and the new implementation with inline functions needs to have
4661 current_buffer in scope now, rather than later when the macros
4662 are used.
4663 (downcase, upcase1): New static inline functions.
4664 (DOWNCASE, UPCASE1): Reimplement using these functions.
4665 This avoids undefined behavior in expressions like
4666 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4667 from race conditions in accessing the global variables
4668 case_temp1 and case_temp2.
4669 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4670 * lisp.h (case_temp1, case_temp2): Remove their decls.
4671 * character.h (ASCII_CHAR_P): Move from here ...
4672 * lisp.h: ... to here, so that the inline functions mentioned
4673 above can use them.
4674
4675 * dired.c (directory_files_internal_unwind): Now static.
4676
4677 * fileio.c (file_name_as_directory, directory_file_name):
4678 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4679 Now static.
4680 (file_name_as_directory): Use const pointers when appropriate.
4681 (Fexpand_file_name): Likewise. In particular, newdir might
4682 point at constant storage, so make it a const pointer.
4683 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4684 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4685 signedness issues.
4686 (Fset_file_times, Finsert_file_contents, auto_save_error):
4687 Rename locals to avoid shadowing.
4688
4689 * minibuf.c (choose_minibuf_frame_1): Now static.
4690 (Ftry_completion, Fall_completions): Rename or remove locals
4691 to avoid shadowing.
4692
4693 * marker.c (bytepos_to_charpos): Remove; unused.
4694
4695 * lisp.h (verify_bytepos, count_markers): New decls,
4696 so that gcc does not warn that these functions aren't declared.
4697
4698 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4699 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4700 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4701 (copy_text): Remove unused local var.
4702
4703 * filelock.c (within_one_second): Now static.
4704 (lock_file_1): Rename local to avoid shadowing.
4705
4706 * buffer.c (fix_overlays_before): Mark locals as initialized.
4707 (fix_start_end_in_overlays): Likewise. This function should be
4708 simplified by using pointers-to-pointers, but that's a different
4709 matter.
4710 (switch_to_buffer_1): Now static.
4711 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4712 (report_overlay_modification): Rename locals to avoid shadowing.
4713
4714 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4715 Fix pointer signedness issue.
4716 (sys_subshell): Mark local as volatile if checking for lint,
4717 to suppress a gcc -Wclobbered warning that does not seem to be right.
4718 (MAXPATHLEN): Define only if needed.
4719
4720 * process.c (serial_open, serial_configure): Move decls from here ...
4721 * systty.h: ... to here, so that they can be checked.
4722
4723 * fns.c (get_random, seed_random): Move extern decls from here ...
4724 * lisp.h: ... to here, so that they can be checked.
4725
4726 * sysdep.c (reset_io): Now static.
4727 (wait_for_termination_signal): Remove; unused.
4728
4729 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4730 (copy_keymap_item, append_key, push_text_char_description):
4731 Now static.
4732 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4733 (DENSE_TABLE_SIZE): Remove; unused.
4734 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4735 (describe_map_tree):
4736 Rename locals to avoid shadowing.
4737
4738 * keyboard.c: Declare functions static if they are not used elsewhere.
4739 (echo_char, echo_dash, cmd_error, top_level_2):
4740 (poll_for_input, handle_async_input): Now static.
4741 (read_char, kbd_buffer_get_event, make_lispy_position):
4742 (make_lispy_event, make_lispy_movement, apply_modifiers):
4743 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4744 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4745 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4746 (read_key_sequence, read_char): Mark locals as initialized.
4747 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4748
4749 * keyboard.h (make_ctrl_char): New decl.
4750 (mark_kboards): Move decl here ...
4751 * alloc.c (mark_kboards): ... from here.
4752
4753 * lisp.h (force_auto_save_soon): New decl.
4754
4755 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4756 (DEFINE_DUMMY_FUNCTION): New macro.
4757 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4758 Use it.
4759 (main): Add casts to avoid warnings
4760 if GCC considers string literals to be constants.
4761
4762 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4763
4764 * dbusbind.c: Pointer signedness fixes.
4765 (xd_signature, xd_append_arg, xd_initialize):
4766 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4767 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4768 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4769 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4770
4771 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4772 if GCC considers string literals to be constants.
4773 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4774
4775 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4776
4777 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4778 (print_preprocess, print_object): New macro to fix last change.
4779
4780 * print.c (print_preprocess): Don't forget font objects.
4781
4782 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4783
4784 * emacs.c (USAGE3): Doc fixes.
4785
4786 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4787
4788 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4789 structure.
4790
4791 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4792
4793 * lisp.h (VWindow_system, Qfile_name_history):
4794 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4795 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4796 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4797
4798 * w32select.c: Don't #include "keyboard.h".
4799 (run_protected): Add extern declaration for waiting_for_input.
4800
4801 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4802 * w32console.c (detect_input_pending, read_input_pending)
4803 (encode_terminal_code):
4804 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4805 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4806 (w32_system_caret_y, Qfile_name_history):
4807 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4808 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4809 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4810 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4811 * w32proc.c (Qlocal, report_file_error):
4812 * w32term.c (Vwindow_system, updating_frame):
4813 * w32uniscribe.c (initialized, uniscribe_font_driver):
4814 Remove unneeded extern declarations.
4815
4816 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4817
4818 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4819
4820 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4821
4822 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4823 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4824 These macros can no longer be used for assignment.
4825
4826 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4827 Assign struct members directly, instead of using BUF_BEGV etc.
4828 (record_buffer_markers, fetch_buffer_markers): New functions for
4829 recording and fetching special buffer markers.
4830 (set_buffer_internal_1, set_buffer_temp): Use them.
4831
4832 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4833
4834 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4835
4836 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4837 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4838
4839 * xdisp.c (hscroll_window_tree):
4840 (reconsider_clip_changes): Use PT instead of BUF_PT.
4841
4842 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4843
4844 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4845 $(EMACS_ROOT)/lib/intprops.h.
4846
4847 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4848
4849 Fix more problems found by GCC 4.5.2's static checks.
4850
4851 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4852 to unsigned char * to avoid compiler diagnostic.
4853 (xg_free_frame_widgets): Make it clear that a local variable is
4854 needed only if USE_GTK_TOOLTIP.
4855 (gdk_window_get_screen): Make it clear that this macro is needed
4856 only if USE_GTK_TOOLTIP.
4857 (int_gtk_range_get_value): New function, which avoids a diagnostic
4858 from gcc -Wbad-function-cast.
4859 (xg_set_toolkit_scroll_bar_thumb): Use it.
4860 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4861 diagnostic from gcc -Wbad-function-cast.
4862 (get_utf8_string, xg_get_file_with_chooser):
4863 Rename locals to avoid shadowing.
4864 (create_dialog): Move locals to avoid shadowing.
4865
4866 * xgselect.c (xg_select): Remove unused var.
4867
4868 * image.c (four_corners_best): Mark locals as initialized.
4869 (gif_load): Initialize transparent_p to zero (Bug#8238).
4870 Mark another local as initialized.
4871 (my_png_error, my_error_exit): Mark with NO_RETURN.
4872
4873 * image.c (clear_image_cache): Now static.
4874 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4875 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4876 (x_edge_detection): Remove unnecessary cast that
4877 gcc -Wbad-function-cast diagnoses.
4878 (gif_load): Fix pointer signedness.
4879 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4880 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4881
4882 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4883
4884 Improve quality of tests for time stamp overflow.
4885 For example, without this patch (encode-time 0 0 0 1 1
4886 1152921504606846976) returns the obviously-bogus value (-948597
4887 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4888 reports time overflow. See
4889 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4890 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4891 * editfns.c: Include limits.h and intprops.h.
4892 (TIME_T_MIN, TIME_T_MAX): New macros.
4893 (time_overflow): Move earlier, to before first use.
4894 (hi_time, lo_time): New functions, for an accurate test for
4895 out-of-range times.
4896 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4897 (Fget_internal_run_time): Don't assume time_t fits in int.
4898 (make_time): Use list2 instead of Fcons twice.
4899 (Fdecode_time): More accurate test for out-of-range times.
4900 (check_tm_member): New function.
4901 (Fencode_time): Use it, to test for out-of-range times.
4902 (lisp_time_argument): Don't rely on undefined left-shift and
4903 right-shift behavior when checking for time stamp overflow.
4904
4905 * editfns.c (time_overflow): New function, refactoring common code.
4906 (Fformat_time_string, Fdecode_time, Fencode_time):
4907 (Fcurrent_time_string): Use it.
4908
4909 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4910 * dired.c (make_time): Move to ...
4911 * editfns.c (make_time): ... here.
4912 * systime.h: Note the move.
4913
4914 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4915
4916 * fringe.c (update_window_fringes): Remove unused variables.
4917
4918 * unexmacosx.c (copy_data_segment): Also copy __got section.
4919 (Bug#8223)
4920
4921 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4922
4923 * termcap.c [MSDOS]: Include "msdos.h".
4924 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4925 Constify `char *' arguments and their references according to
4926 prototypes in tparam.h.
4927
4928 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4929
4930 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4931 Adapt all references accordingly.
4932
4933 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4934
4935 2011-03-11 Tom Tromey <tromey@redhat.com>
4936
4937 * buffer.c (syms_of_buffer): Remove obsolete comment.
4938
4939 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4940
4941 * termhooks.h (encode_terminal_code): Declare prototype.
4942
4943 * msdos.c (encode_terminal_code): Don't declare prototype.
4944
4945 * term.c (encode_terminal_code): Now external again, used by
4946 w32console.c and msdos.c.
4947
4948 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4949 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4950
4951 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4952
4953 Fix some minor problems found by GCC 4.5.2's static checks.
4954
4955 * fringe.c (update_window_fringes): Mark locals as initialized
4956 (Bug#8227).
4957 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4958
4959 * alloc.c (mark_fringe_data): Move decl from here ...
4960 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4961 to check its interface.
4962 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4963
4964 * fontset.c (free_realized_fontset): Now static.
4965 (Fset_fontset_font): Rename local to avoid shadowing.
4966 (fontset_font): Mark local as initialized.
4967 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4968
4969 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4970
4971 * xselect.c (x_disown_buffer_selections): Remove; not used.
4972 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4973 (x_own_selection, Fx_disown_selection_internal): Rename locals
4974 to avoid shadowing.
4975 (x_handle_dnd_message): Remove local to avoid shadowing.
4976
4977 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4978 so that the caller can use some name other than gcpro1.
4979 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4980 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4981 (Fx_backspace_delete_keys_p):
4982 Use them to avoid shadowing, and rename vars to avoid shadowing.
4983 (x_decode_color, x_set_name, x_window): Now static.
4984 (Fx_create_frame): Add braces to silence GCC warning.
4985 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4986 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4987 Remove unused locals.
4988 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4989 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4990 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4991 macros.
4992
4993 * xterm.h (x_mouse_leave): New decl.
4994
4995 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4996 Remove unused functions.
4997 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4998 (x_calc_absolute_position): Now static.
4999 (XTread_socket): Don't define label "out" unless it's used.
5000 Don't declare local "event" unless it's used.
5001 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5002 unless they are used.
5003 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5004 (x_fatal_error_signal): Remove; not used.
5005 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5006 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5007 (x_error_catcher, x_connection_closed, x_error_handler):
5008 (x_error_quitter, xembed_send_message, x_iconify_frame):
5009 (my_log_handler): Rename locals to avoid shadowing.
5010 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5011 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5012
5013 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5014 Rename or move locals to avoid shadowing.
5015 (tty_defined_color, merge_face_heights): Now static.
5016 (free_realized_faces_for_fontset): Remove; not used.
5017 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5018 does not deduce is never used uninitialized.
5019 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5020 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5021
5022 * terminal.c (store_terminal_param): Now static.
5023
5024 * xmenu.c (menu_highlight_callback): Now static.
5025 (set_frame_menubar): Remove unused local.
5026 (xmenu_show): Rename parameter to avoid shadowing.
5027 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5028 since they might point to immutable storage.
5029 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5030 since it's unused otherwise.
5031
5032 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5033 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5034 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5035 avoids a gcc -Wuninitialized diagnostic.
5036 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5037 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5038 does not deduce are never used uninitialized.
5039
5040 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5041
5042 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5043 * window.c (window_loop, size_window):
5044 (run_window_configuration_change_hook, enlarge_window): Likewise.
5045
5046 * window.c (display_buffer): Now static.
5047 (size_window): Mark variables that gcc -Wuninitialized
5048 does not deduce are never used uninitialized.
5049 * window.h (check_all_windows): New decl, to forestall
5050 gcc -Wmissing-prototypes diagnostic.
5051 * dispextern.h (bidi_dump_cached_states): Likewise.
5052
5053 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5054 shadowing.
5055 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5056 Include <limits.h>.
5057 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5058 and to avoid gcc -Wuninitialized warning.
5059 (load_charset_map): Mark variables that gcc -Wuninitialized
5060 does not deduce are never used uninitialized.
5061 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5062
5063 * coding.c (coding_set_source, coding_set_destination):
5064 Use "else { /* comment */ }" rather than "else /* comment */;"
5065 for clarity, and to avoid gcc -Wempty-body warning.
5066 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5067 a block, when the outer 'i' will do.
5068 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5069 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5070 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5071 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5072 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5073 Rename locals to avoid shadowing.
5074 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5075 * coding.c (emacs_mule_char, encode_invocation_designation):
5076 Now static, since they're not used elsewhere.
5077 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5078 (decode_coding_object, encode_coding_object, detect_coding_system):
5079 (decode_coding_emacs_mule): Mark variables that gcc
5080 -Wuninitialized does not deduce are never used uninitialized.
5081 (detect_coding_iso_2022): Initialize a local variable that might
5082 be used uninitialized. Leave a FIXME because it's not clear that
5083 this initialization is needed. (Bug#8211)
5084 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5085 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5086 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5087 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5088 Remove unused macros.
5089
5090 * category.c (hash_get_category_set): Remove unused local var.
5091 (copy_category_table): Now static, since it's not used elsewhere.
5092 * character.c (string_count_byte8): Likewise.
5093
5094 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5095 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5096
5097 * chartab.c (copy_sub_char_table): Now static, since it's not used
5098 elsewhere.
5099 (sub_char_table_ref_and_range, char_table_ref_and_range):
5100 Rename locals to avoid shadowing.
5101 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5102
5103 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5104 (BIDI_BOB): Remove unused macro.
5105
5106 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5107 deduce are never used uninitialized.
5108 * term.c (encode_terminal_code): Likewise.
5109
5110 * term.c (encode_terminal_code): Now static. Remove unused local.
5111
5112 * tparam.h: New file.
5113 * term.c, tparam.h: Include it.
5114 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5115 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5116 Move these decls to tparam.h, and make them agree with what
5117 is actually in tparam.c. The previous trick of using incompatible
5118 decls in different modules does not conform to the C standard.
5119 All callers of tparam changed to use tparam's actual API.
5120 * tparam.c (tparam1, tparam, tgoto):
5121 Use const pointers where appropriate.
5122
5123 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5124 * cm.h (struct cm): Likewise.
5125 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5126 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5127 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5128 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5129 (turn_on_face, init_tty): Likewise.
5130 * termchar.h (struct tty_display_info): Likewise.
5131
5132 * term.c (term_mouse_position): Rename local to avoid shadowing.
5133
5134 * alloc.c (mark_ttys): Move decl from here ...
5135 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5136
5137 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5138
5139 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5140
5141 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5142
5143 * search.c (compile_pattern_1): Remove argument regp, unused since
5144 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5145 (compile_pattern): Don't pass it.
5146
5147 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5148
5149 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5150 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5151 for ! HAVE_GTK3.
5152 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5153
5154 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5155
5156 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5157 gdk_window_get_screen, gdk_window_get_geometry,
5158 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5159 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5160 (xg_get_pixbuf_from_pixmap): New function.
5161 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5162 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5163 Call xg_get_pixbuf_from_pixmap instead of
5164 gdk_pixbuf_get_from_drawable.
5165 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5166 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5167 (xg_check_special_colors): Use GtkStyleContext and its functions
5168 for HAVE_GTK3.
5169 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5170 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5171 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5172 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5173 Call gtk_widget_get_preferred_size.
5174 (xg_frame_resized): gdk_window_get_geometry only takes 5
5175 parameters.
5176 (xg_win_to_widget, xg_event_is_for_menubar):
5177 Call gdk_x11_window_lookup_for_display.
5178 (xg_set_widget_bg): New function.
5179 (delete_cb): New function.
5180 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5181 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5182 (xg_set_background_color): Call xg_set_widget_bg.
5183 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5184 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5185 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5186 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5187 if ! HAVE_GTK3.
5188 (update_frame_tool_bar): Call gtk_widget_hide.
5189 (xg_initialize): Use GDK_KEY_g.
5190
5191 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5192 if ! HAVE_GTK3
5193 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5194
5195 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5196 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5197 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5198
5199 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5200
5201 * w32xfns.c (select_palette): Check success of RealizePalette against
5202 GDI_ERROR, not zero.
5203
5204 See ChangeLog.11 for earlier changes.
5205
5206 ;; Local Variables:
5207 ;; coding: utf-8
5208 ;; End:
5209
5210 Copyright (C) 2011 Free Software Foundation, Inc.
5211
5212 This file is part of GNU Emacs.
5213
5214 GNU Emacs is free software: you can redistribute it and/or modify
5215 it under the terms of the GNU General Public License as published by
5216 the Free Software Foundation, either version 3 of the License, or
5217 (at your option) any later version.
5218
5219 GNU Emacs is distributed in the hope that it will be useful,
5220 but WITHOUT ANY WARRANTY; without even the implied warranty of
5221 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5222 GNU General Public License for more details.
5223
5224 You should have received a copy of the GNU General Public License
5225 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.