1 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4 is a directory before asking whether to use the file name
7 * fns.c (Frequire): Remove the mention of the .gz files, since
8 that's installation-specific, but keep the mention of
11 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
13 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
14 Report string overflow if the output is too long.
16 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
18 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
19 (syms_of_gnutls): Remove duplicate DEFSYM for
20 Qgnutls_bootprop_verify_hostname_error, an error for
21 Qgnutls_bootprop_verify_error (which is no longer used).
23 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
24 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
25 Also (re)move comments that are misplaced or no longer relevant.
27 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
29 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
31 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
33 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
34 and background color parameters if they have been changed.
36 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
38 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
40 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
42 * xsettings.c (SYSTEM_FONT): Define only when used.
43 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
45 * keymap.c (access_keymap_1): Now static.
47 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
49 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
50 leave any prefix arg for the up event (Bug#1586).
52 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
54 * lread.c (syms_of_lread): Mention single symbols defined by
55 `defvar' or `defconst' (bug#7154).
57 * fns.c (Frequire): Mention .el.gz files (bug#7314).
58 (Frequire): Mention get-load-suffixes.
60 2011-07-02 Martin Rudalics <rudalics@gmx.at>
62 * window.h (window): Remove clone_number slot.
63 * window.c (Fwindow_clone_number, Fset_window_clone_number):
65 (make_parent_window, make_window, saved_window)
66 (Fset_window_configuration, save_window_save): Don't deal with
68 * buffer.c (Qclone_number): Remove declaration.
69 (sort_overlays, overlay_strings): Don't deal with clone numbers.
71 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
73 Add multiple inheritance to keymaps.
74 * keymap.c (Fmake_composed_keymap): New function.
75 (Fset_keymap_parent): Simplify.
76 (fix_submap_inheritance): Remove.
77 (access_keymap_1): New function extracted from access_keymap to handle
78 embedded parents and handle lists of maps.
79 (access_keymap): Use it.
80 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
81 (Fcopy_keymap): Handle embedded parents.
82 (Fcommand_remapping, define_as_prefix): Simplify.
83 (Fkey_binding): Simplify.
84 (syms_of_keymap): Move minibuffer-local-completion-map,
85 minibuffer-local-filename-completion-map,
86 minibuffer-local-must-match-map, and
87 minibuffer-local-filename-must-match-map to Elisp.
88 (syms_of_keymap): Defsubr make-composed-keymap.
89 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
90 (parse_menu_item): Trivial simplification.
92 2011-07-01 Glenn Morris <rgm@gnu.org>
94 * Makefile.in (SETTINGS_LIBS): Fix typo.
96 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
98 * coding.c (Fencode_coding_string): Record the last coding system
99 used, as the function doc string says (bug#8738).
101 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
103 * xsettings.c (store_monospaced_changed): Take new font as arg and
104 check for change against current_mono_font.
105 (EMACS_TYPE_SETTINGS): Remove this and related defines.
106 (emacs_settings_constructor, emacs_settings_get_property)
107 (emacs_settings_set_property, emacs_settings_class_init)
108 (emacs_settings_init, gsettings_obj): Remove.
109 (something_changedCB): New function for HAVE_GSETTINGS.
110 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
111 with value as argument.
112 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
113 g_settings_new (Bug#8967). Do not create gsettings_obj.
114 Remove calls to g_settings_bind. Connect something_changedCB to
117 * xgselect.c: Add defined (HAVE_GSETTINGS).
118 (xgselect_initialize): Ditto.
120 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
121 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
124 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
126 * eval.c (struct backtrace): Simplify and port the data structure.
127 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
128 signed bit field, as this assumption is not portable and it makes
129 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
130 "char debug_on_exit : 1" as this is not portable either; instead,
131 use the portable "unsigned int debug_on_exit : 1". Remove unused
132 member evalargs. Remove obsolete comments about cc bombing out.
134 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
136 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
137 Let HAVE_GSETTINGS override HAVE_GCONF.
138 (store_monospaced_changed): New function.
139 (EMACS_SETTINGS): A new type derived from GObject to handle
140 GSettings notifications.
141 (emacs_settings_constructor, emacs_settings_get_property)
142 (emacs_settings_set_property, emacs_settings_class_init):
144 (gsettings_client, gsettings_obj): New variables.
145 (GSETTINGS_SCHEMA): New define.
146 (something_changedCB): Call store_monospaced_changed.
147 (init_gsettings): New function.
148 (xsettings_initialize): Call init_gsettings.
149 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
152 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
155 2011-06-29 Martin Rudalics <rudalics@gmx.at>
157 * window.c (resize_root_window, grow_mini_window)
158 (shrink_mini_window): Rename Qresize_root_window to
159 Qwindow_resize_root_window and Qresize_root_window_vertically to
160 Qwindow_resize_root_window_vertically.
162 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
164 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
166 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
168 * makefile.w32-in: Redesign dependencies so they reflect more
169 clearly which files are directly included by each source file,
170 and not through other includes.
172 2011-06-27 Martin Rudalics <rudalics@gmx.at>
174 * buffer.c (Qclone_number): Declare static and DEFSYM it.
175 (sort_overlays, overlay_strings): When an overlay's clone number
176 matches the window's clone number process the overlay even if
177 the overlay's window property doesn't match the current window.
179 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
180 (Fwindow_hchild): Rename to Fwindow_left_child.
181 (Fwindow_next): Rename to Fwindow_next_sibling.
182 (Fwindow_prev): Rename to Fwindow_prev_sibling.
183 (resize_window_check): Rename to window_resize_check.
184 (resize_window_apply): Rename to window_resize_apply.
185 (Fresize_window_apply): Rename to Fwindow_resize_apply.
186 (Fdelete_other_windows_internal, resize_frame_windows)
187 (Fsplit_window_internal, Fdelete_window_internal)
188 (grow_mini_window, shrink_mini_window)
189 (Fresize_mini_window_internal): Fix callers accordingly.
191 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
193 * emacsgtkfixed.h: State that this is only used with Gtk+3.
194 (emacs_fixed_set_min_size): Remove.
195 (emacs_fixed_new): Take frame as argument.
197 * emacsgtkfixed.c: State that this is only used with Gtk+3.
198 (_EmacsFixedPrivate): Remove minwidth/height.
200 (emacs_fixed_init): Initialize priv->f.
201 (get_parent_class, emacs_fixed_set_min_size): Remove.
202 (emacs_fixed_new): Set priv->f to argument.
203 (emacs_fixed_get_preferred_width)
204 (emacs_fixed_get_preferred_height): Use min_width/height from
205 frames size_hint to set minimum and natural (Bug#8919).
206 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
207 and use min_width/height from frames size_hint to set
208 min_width/height (Bug#8919).
210 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
211 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
214 2011-06-26 Eli Zaretskii <eliz@gnu.org>
216 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
217 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
220 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
222 * process.c (wait_reading_process_output): Bypass select if
223 waiting for a cell while ignoring keyboard input, and input is
224 pending. Suggested by Jan Djärv (Bug#8869).
226 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
228 Use gnulib's dup2 module instead of rolling our own.
229 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
231 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
233 * dispnew.c (scrolling_window): Before scrolling, turn off a
234 mouse-highlight in the window being scrolled.
236 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
238 Move DEFSYM to lisp.h and use everywhere.
240 * character.h (DEFSYM): Move declaration...
241 * lisp.h (DEFSYM): ...here.
247 * w32select.c: Don't include character.h.
249 * alloc.c (syms_of_alloc):
250 * buffer.c (syms_of_buffer):
251 * bytecode.c (syms_of_bytecode):
252 * callint.c (syms_of_callint):
253 * casefiddle.c (syms_of_casefiddle):
254 * casetab.c (init_casetab_once):
255 * category.c (init_category_once, syms_of_category):
256 * ccl.c (syms_of_ccl):
257 * cmds.c (syms_of_cmds):
258 * composite.c (syms_of_composite):
259 * dbusbind.c (syms_of_dbusbind):
260 * dired.c (syms_of_dired):
261 * dispnew.c (syms_of_display):
262 * doc.c (syms_of_doc):
263 * editfns.c (syms_of_editfns):
264 * emacs.c (syms_of_emacs):
265 * eval.c (syms_of_eval):
266 * fileio.c (syms_of_fileio):
267 * fns.c (syms_of_fns):
268 * frame.c (syms_of_frame):
269 * fringe.c (syms_of_fringe):
270 * insdel.c (syms_of_insdel):
271 * keymap.c (syms_of_keymap):
272 * lread.c (init_obarray, syms_of_lread):
273 * macros.c (syms_of_macros):
274 * msdos.c (syms_of_msdos):
275 * print.c (syms_of_print):
276 * process.c (syms_of_process):
277 * search.c (syms_of_search):
278 * sound.c (syms_of_sound):
279 * syntax.c (init_syntax_once, syms_of_syntax):
280 * terminal.c (syms_of_terminal):
281 * textprop.c (syms_of_textprop):
282 * undo.c (syms_of_undo):
283 * w32.c (globals_of_w32):
284 * window.c (syms_of_window):
285 * xdisp.c (syms_of_xdisp):
286 * xfaces.c (syms_of_xfaces):
287 * xfns.c (syms_of_xfns):
288 * xmenu.c (syms_of_xmenu):
289 * xsettings.c (syms_of_xsettings):
290 * xterm.c (syms_of_xterm): Use DEFSYM.
292 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
294 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
296 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
298 Integer and buffer overflow fixes (Bug#8873).
300 * print.c (printchar, strout): Check for string overflow.
301 (PRINTPREPARE, printchar, strout):
302 Don't set size unless allocation succeeds.
304 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
305 for sizes. Check for string overflow more accurately.
306 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
308 * macros.c: Integer and buffer overflow fixes.
309 * keyboard.h (struct keyboard.kbd_macro_bufsize):
310 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
311 Use ptrdiff_t, not int, for sizes.
312 Don't increment bufsize until after realloc succeeds.
313 Check for size-calculation overflow.
314 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
316 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
318 * lread.c: Integer overflow fixes.
319 (read_integer): Radix is now EMACS_INT, not int,
320 to improve quality of diagnostics for out-of-range radices.
321 Calculate buffer size correctly for out-of-range radices.
322 (read1): Check for integer overflow in radices, and in
324 (read_escape): Avoid int overflow.
325 (Fload, openp, read_buffer_size, read1)
326 (substitute_object_recurse, read_vector, read_list, map_obarray):
327 Use ptrdiff_t, not int, for sizes.
328 (read1): Use EMACS_INT, not int, for sizes.
329 Check for size overflow.
331 * image.c (cache_image): Check for size arithmetic overflow.
333 * lread.c: Integer overflow issues.
334 (saved_doc_string_size, saved_doc_string_length)
335 (prev_saved_doc_string_size, prev_saved_doc_string_length):
336 Now ptrdiff_t, not int.
337 (read1): Don't assume doc string length fits in int. Check for
338 out-of-range doc string lengths.
339 (read_list): Don't assume file position fits in int.
340 (read_escape): Check for hex character overflow.
342 2011-06-22 Leo Liu <sdl.web@gmail.com>
344 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
345 Move to minibuffer.el.
347 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
349 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
350 The following patches are for when GLYPH_DEBUG && !XASSERT.
351 * dispextern.h (trace_redisplay_p, dump_glyph_string):
352 * dispnew.c (flush_stdout):
353 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
354 Mark as externally visible.
355 * dispnew.c (check_window_matrix_pointers): Now static.
356 * dispnew.c (window_to_frame_vpos):
357 * xfns.c (unwind_create_frame):
358 * xterm.c (x_check_font): Remove unused local.
359 * scroll.c (CHECK_BOUNDS):
360 * xfaces.c (cache_fache): Rename local to avoid shadowing.
361 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
362 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
363 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
364 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
366 (debug_method_add): Use va_list and vsprintf rather than relying
367 on undefined behavior with wrong number of arguments.
368 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
369 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
370 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
371 since we're not interested in debugging glyphs with old libraries.
372 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
373 GCC 4.6.0's static checking.
375 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
377 Integer overflow and signedness fixes (Bug#8873).
378 A few related buffer overrun fixes, too.
380 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
382 * dispextern.h (struct face.stipple):
383 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
384 (x_bitmap_mask, x_allocate_bitmap_record)
385 (x_create_bitmap_from_data, x_create_bitmap_from_file)
386 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
387 (x_create_bitmap_from_xpm_data):
388 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
389 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
391 * xfaces.c (load_pixmap):
392 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
393 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
394 (.bitmaps_last, struct x_output.icon_bitmap):
395 Use ptrdiff_t, not int, for bitmap indexes.
396 (x_allocate_bitmap_record): Check for size overflow.
397 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
399 Use ptrdiff_t, not int, for overlay counts.
400 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
401 * editfns.c (overlays_around, get_pos_property):
402 * textprop.c (get_char_property_and_overlay):
403 * xdisp.c (next_overlay_change, note_mouse_highlight):
404 * xfaces.c (face_at_buffer_position):
405 * buffer.c (OVERLAY_COUNT_MAX): New macro.
406 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
407 (Fnext_overlay_change, Fprevious_overlay_change)
408 (mouse_face_overlay_overlaps, Foverlays_in):
409 Use ptrdiff_t, not int, for sizes.
410 (overlays_at, overlays_in): Check for size-calculation overflow.
412 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
414 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
415 (x_session_initialize): Do not assume string length fits in int.
417 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
418 This is unlikely, but can occur if DPI is outlandish.
420 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
421 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
423 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
424 * xrdb.c (magic_file_p, search_magic_path):
425 Omit last arg SUFFIX; it was always 0. All callers changed.
426 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
428 * xfont.c (xfont_match): Avoid need for strlen.
430 * xfns.c: Don't assume strlen fits in int.
431 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
433 * xdisp.c (message_log_check_duplicate): Return intmax_t,
434 not unsigned long, as we prefer signed integers. All callers changed.
435 Detect integer overflow in repeat count.
436 (message_dolog): Don't assume print length fits in 39 bytes.
437 (display_mode_element): Don't assume strlen fits in int.
439 * termcap.c: Don't assume sizes fit in int and never overflow.
440 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
441 (gobble_line): Check for size-calculation overflow.
443 * minibuf.c (Fread_buffer):
444 * lread.c (intern, intern_c_string):
445 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
446 Don't assume string length fits in int.
448 * keyboard.c (parse_tool_bar_item):
449 * gtkutil.c (style_changed_cb): Avoid need for strlen.
451 * font.c: Don't assume string length fits in int.
452 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
453 Use ptrdiff_t, not int.
454 (font_intern_prop): Don't assume string length fits in int.
455 Don't assume integer property fits in fixnum.
456 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
458 * filelock.c: Fix some buffer overrun and integer overflow issues.
459 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
460 Reformulate so as not to need the command string.
461 Invoke gzip -cd rather than gunzip, as it's more portable.
462 (lock_info_type, lock_file_1, lock_file):
463 Don't assume pid_t and time_t fit in unsigned long.
464 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
465 (current_lock_owner): Prefer signed type for sizes.
466 Use memcpy, not strncpy, where memcpy is what is really wanted.
467 Don't assume (via atoi) that time_t and pid_t fit in int.
468 Check for time_t and/or pid_t out of range, e.g., via a network share.
469 Don't alloca where an auto var works fine.
471 * fileio.c: Fix some integer overflow issues.
472 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
473 Don't assume string length fits in int.
474 (directory_file_name): Don't assume string length fits in long.
475 (make_temp_name): Don't assume pid fits in int, or that its print
476 length is less than 20.
478 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
480 * coding.c (make_subsidiaries): Don't assume string length fits in int.
482 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
484 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
485 We prefer signed integers, even for size calculations.
487 * emacs.c: Don't assume string length fits in 'int'.
488 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
489 (main): Don't invoke strlen when not needed.
491 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
492 (XD_DEBUG_MESSAGE): Don't waste a byte.
494 * callproc.c (getenv_internal_1, getenv_internal)
496 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
498 * lread.c (invalid_syntax): Omit length argument.
499 All uses changed. This doesn't fix a bug, but it simplifies the
500 code away from its former Hollerith-constant appearance, and it's
501 one less 'int' to worry about when looking at integer-overflow issues.
502 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
504 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
505 This didn't break anything, but it didn't help either.
506 It's confusing to put a bogus integer in a place where the actual
507 value does not matter.
508 (LIST_END_P): Remove unused macro and its bogus comment.
509 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
511 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
512 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
514 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
515 We prefer signed types, and the value cannot exceed the EMACS_INT
516 range anyway (because otherwise the length would not be representable).
517 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
518 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
519 This avoids a GCC warning when WIDE_EMACS_INT.
521 * indent.c (sane_tab_width): New function.
522 (current_column, scan_for_column, Findent_to, position_indentation)
523 (compute_motion): Use it. This is just for clarity.
524 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
526 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
528 * lisp.h (lint_assume): New macro.
529 * composite.c (composition_gstring_put_cache):
530 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
532 * editfns.c, insdel.c:
533 Omit unnecessary forward decls, to simplify future changes.
535 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
537 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
539 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
540 Use much-faster test for byte-length change.
541 Don't assume string byte-length fits in 'int'.
542 Check that character arg fits in 'int'.
543 (mapcar1): Declare byte as byte, for clarity.
545 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
547 * fns.c (concat): Catch string overflow earlier.
548 Do not rely on integer wraparound.
550 * dispextern.h (struct it.overlay_strings_charpos)
551 (struct it.selective): Now EMACS_INT, not int.
552 * xdisp.c (forward_to_next_line_start)
553 (back_to_previous_visible_line_start)
554 (reseat_at_next_visible_line_start, next_element_from_buffer):
555 Don't arbitrarily truncate the value of 'selective' to int.
557 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
559 * composite.c: Don't truncate sizes to 'int'.
560 (composition_gstring_p, composition_reseat_it)
561 (composition_adjust_point): Use EMACS_INT, not int.
562 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
563 not EMACS_UINT, for indexes.
565 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
567 * buffer.c: Include <verify.h>.
568 (struct sortvec.priority, struct sortstr.priority):
569 Now EMACS_INT, not int.
570 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
571 (struct sortstr.size, record_overlay_string)
572 (struct sortstrlist.size, struct sortlist.used):
573 Don't truncate size to int.
574 (record_overlay_string): Check for size-calculation overflow.
575 (init_buffer_once): Check at compile-time, not run-time.
577 2011-06-22 Jim Meyering <meyering@redhat.com>
579 Don't leak an XBM-image-sized buffer
580 * image.c (xbm_load): Free the image buffer after using it.
582 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
585 * composite.c (find_automatic_composition): Omit needless 'return 0;'
586 that Sun C diagnosed.
587 * fns.c (secure_hash): Fix pointer signedness issue.
588 * intervals.c (static_offset_intervals): New function.
589 (offset_intervals): Use it.
591 2011-06-21 Leo Liu <sdl.web@gmail.com>
594 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
597 * fns.c (secure_hash): Rename from crypto_hash_function and change
598 the first arg to accept symbols.
599 (Fsecure_hash): New primitive.
600 (syms_of_fns): New symbols.
602 2011-06-20 Deniz Dogan <deniz@dogan.se>
604 * process.c (Fset_process_buffer): Clarify return value in
607 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
609 * dispnew.c (add_window_display_history): Use BVAR.
611 * xdisp.c (debug_method_add): Use BVAR.
612 (check_window_end, dump_glyph_matrix, dump_glyph)
613 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
615 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
618 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
619 check till after the cache is created in init_frame_faces.
621 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
623 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
625 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
627 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
628 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
629 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
631 Improve buffer-overflow checking (Bug#8873).
632 * fileio.c (Finsert_file_contents):
633 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
634 Remove the old (too-loose) buffer overflow checks.
635 They weren't needed, since make_gap checks for buffer overflow.
636 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
637 The old code merely checked for Emacs fixnum overflow, and relied
638 on undefined (wraparound) behavior. The new code avoids undefined
639 behavior, and also checks for ptrdiff_t and/or size_t overflow.
641 * editfns.c (Finsert_char): Don't dump core with very negative counts.
642 Tune. Don't use wider integers than needed. Don't use alloca.
643 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
645 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
647 * insdel.c, lisp.h (buffer_overflow): New function.
648 (insert_from_buffer_1, replace_range, replace_range_2):
649 * insdel.c (make_gap_larger):
650 * editfns.c (Finsert_char):
651 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
653 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
655 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
657 Integer overflow and signedness fixes (Bug#8873).
659 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
660 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
662 * fileio.c: Don't assume EMACS_INT fits in off_t.
663 (emacs_lseek): New static function.
664 (Finsert_file_contents, Fwrite_region): Use it.
665 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
667 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
669 * fns.c: Don't overflow int when computing a list length.
670 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
671 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
672 truncation on 64-bit hosts. Check for QUIT every
673 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
674 faster and is responsive enough.
675 (Flength): Report an error instead of overflowing an integer.
676 (Fsafe_length): Return a float if the value is not representable
677 as a fixnum. This shouldn't happen except in contrived situations.
678 (Fnthcdr, Fsort): Don't assume list length fits in int.
679 (Fcopy_sequence): Don't assume vector length fits in int.
681 * alloc.c: Check that resized vectors' lengths fit in fixnums.
682 (header_size, word_size): New constants.
683 (allocate_vectorlike): Don't check size overflow here.
684 (allocate_vector): Check it here instead, since this is the only
685 caller of allocate_vectorlike that could cause overflow.
686 Check that the new vector's length is representable as a fixnum.
688 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
689 The previous code was bogus. For example, next_almost_prime (32)
690 returned 39, which is undesirable as it is a multiple of 3; and
691 next_almost_prime (24) returned 25, which is a multiple of 5 so
692 why was the code bothering to check for multiples of 7?
694 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
696 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
698 Variadic C functions now count arguments with ptrdiff_t.
699 This partly undoes my 2011-03-30 change, which replaced int with size_t.
700 Back then I didn't know that the Emacs coding style prefers signed int.
701 Also, in the meantime I found a few more instances where arguments
702 were being counted with int, which may truncate counts on 64-bit
703 machines, or EMACS_INT, which may be unnecessarily wide.
704 * lisp.h (struct Lisp_Subr.function.aMANY)
705 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
706 Arg counts are now ptrdiff_t, not size_t.
707 All variadic functions and their callers changed accordingly.
708 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
709 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
710 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
711 * callint.c (Fcall_interactively): Check arg count for overflow,
712 to avoid potential buffer overrun. Use signed char, not 'int',
713 for 'varies' array, so that we needn't bother to check its size
714 calculation for overflow.
715 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
716 * eval.c (apply_lambda):
717 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
718 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
719 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
721 * callint.c (Fcall_interactively): Don't use index var as event count.
723 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
724 * mem-limits.h (SIZE): Remove; no longer used.
726 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
728 Remove unnecessary casts.
729 * xterm.c (x_term_init):
730 * xfns.c (x_set_border_pixel):
731 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
732 These aren't needed now that we assume ANSI C.
734 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
735 It's more likely to cause problems (due to unsigned overflow)
738 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
740 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
742 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
744 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
746 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
748 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
750 GLYPH_CODE_FACE returns EMACS_INT, not int.
751 * dispextern.h (merge_faces):
752 * xfaces.c (merge_faces):
753 * xdisp.c (get_next_display_element, next_element_from_display_vector):
754 Don't assume EMACS_INT fits in int.
756 * character.h (CHAR_VALID_P): Remove unused parameter.
757 * fontset.c, lisp.h, xdisp.c: All uses changed.
759 * editfns.c (Ftranslate_region_internal): Omit redundant test.
761 * fns.c (concat): Minor tuning based on overflow analysis.
762 This doesn't fix any bugs. Use int to hold character, instead
763 of constantly refetching from Emacs object. Use XFASTINT, not
764 XINT, for value known to be a character. Don't bother comparing
765 a single byte to 0400, as it's always less.
767 * floatfns.c (Fexpt):
768 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
770 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
773 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
775 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
776 Without this fix, on a 64-bit host (aset S 0 4294967386) would
777 incorrectly succeed when S was a string, because 4294967386 was
778 truncated before it was used.
780 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
781 Otherwise, an out-of-range integer could cause undefined behavior
784 * composite.c: Use int, not EMACS_INT, for characters.
785 (fill_gstring_body, composition_compute_stop_pos): Use int, not
786 EMACS_INT, for values that are known to be in character range.
787 This doesn't fix any bugs but is the usual style inside Emacs and
788 may generate better code on 32-bit machines.
790 Make sure a 64-bit char is never passed to ENCODE_CHAR.
791 This is for reasons similar to the recent CHAR_STRING fix.
792 * charset.c (Fencode_char): Check that character arg is actually
793 a character. Pass an int to ENCODE_CHAR.
794 * charset.h (ENCODE_CHAR): Verify that the character argument is no
795 wider than 'int', as a compile-time check to prevent future regressions
798 * character.c (char_string): Remove unnecessary casts.
800 Make sure a 64-bit char is never passed to CHAR_STRING.
801 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
802 by silently ignoring the top 32 bits, allowing some values
803 that were far too large to be valid characters.
804 * character.h: Include <verify.h>.
805 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
806 arguments are no wider than unsigned, as a compile-time check
807 to prevent future regressions in this area.
809 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
810 (Fsubst_char_in_region):
812 * xdisp.c (decode_mode_spec_coding):
813 Adjust to CHAR_STRING's new requirement.
814 * editfns.c (Finsert_char, Fsubst_char_in_region):
815 * fns.c (concat): Check that character args are actually
816 characters. Without this test, these functions did the wrong
817 thing with wildly out-of-range values on 64-bit hosts.
819 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
820 These casts should not be needed on 32-bit hosts, either.
821 * keyboard.c (read_char):
822 * lread.c (Fload): Remove casts to unsigned.
824 * lisp.h (UNSIGNED_CMP): New macro.
825 This fixes comparison bugs on 64-bit hosts.
826 (ASCII_CHAR_P): Use it.
827 * casefiddle.c (casify_object):
828 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
829 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
830 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
831 * dispextern.h (FACE_FROM_ID):
832 * keyboard.c (read_char): Use UNSIGNED_CMP.
834 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
835 not to EMACS_INT, to avoid GCC warning.
837 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
839 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
840 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
841 isn't needed on 32-bit machines.
843 * buffer.c (Fgenerate_new_buffer_name):
844 Use EMACS_INT for count, not int.
845 (advance_to_char_boundary): Return EMACS_INT, not int.
847 * data.c (Qcompiled_function): Now static.
849 * window.c (window_body_lines): Now static.
851 * image.c (gif_load): Rename local to avoid shadowing.
853 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
854 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
855 * alloc.c (make_save_value): Integer argument is now of type
857 (mark_object): Use ptrdiff_t, not int.
858 * lisp.h (pD): New macro.
859 * print.c (print_object): Use it.
861 * alloc.c: Use EMACS_INT, not int, to count objects.
862 (total_conses, total_markers, total_symbols, total_vector_size)
863 (total_free_conses, total_free_markers, total_free_symbols)
864 (total_free_floats, total_floats, total_free_intervals)
865 (total_intervals, total_strings, total_free_strings):
866 Now EMACS_INT, not int. All uses changed.
867 (Fgarbage_collect): Compute overall total using a double, so that
868 integer overflow is less likely to be a problem. Check for overflow
869 when converting back to an integer.
870 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
871 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
872 These were 'int' variables that could overflow on 64-bit hosts;
873 they were never used, so remove them instead of repairing them.
874 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
875 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
876 Previously, this ceilinged at INT_MAX, but that doesn't work on
878 (allocate_pseudovector): Don't use EMACS_INT when int would do.
880 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
881 (allocate_vectorlike): Check for ptrdiff_t overflow.
882 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
883 when a (possibly-narrower) signed value would do just as well.
884 We prefer using signed arithmetic, to avoid comparison confusion.
886 * alloc.c: Catch some string size overflows that we were missing.
887 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
888 for convenience in STRING_BYTES_MAX.
889 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
890 The definition here is exact; the one in lisp.h was approximate.
891 (allocate_string_data): Check for string overflow. This catches
892 some instances we weren't catching before. Also, it catches
893 size_t overflow on (unusual) hosts where SIZE_MAX <= min
894 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
895 and ptrdiff_t and EMACS_INT are both 64 bits.
897 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
898 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
899 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
901 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
903 * alloc.c (Fmake_string): Check for out-of-range init.
905 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
907 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
909 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
911 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
912 xg_get_default_scrollbar_width.
914 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
915 (int_gtk_range_get_value): Move to the scroll bar part of the file.
916 (style_changed_cb): Call update_theme_scrollbar_width and call
917 x_set_scroll_bar_default_width and xg_frame_set_char_size for
918 all frames (Bug#8505).
919 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
920 Call gtk_window_set_resizable if HAVE_GTK3.
921 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
922 and height if HAVE_GTK3 (Bug#8505).
923 (scroll_bar_width_for_theme): New variable.
924 (update_theme_scrollbar_width): New function.
925 (xg_get_default_scrollbar_width): Move code to
926 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
927 (xg_initialize): Call update_theme_scrollbar_width.
929 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
931 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
933 2011-06-12 Martin Rudalics <rudalics@gmx.at>
935 * frame.c (make_frame): Call other_buffer_safely instead of
938 * window.c (temp_output_buffer_show): Call display_buffer with
939 second argument Vtemp_buffer_show_specifiers and reset latter
940 immediately after the call.
941 (Vtemp_buffer_show_specifiers): New variable.
942 (auto_window_vscroll_p, next_screen_context_lines)
943 (Vscroll_preserve_screen_position): Remove leading asterisks from
946 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
948 Fix minor problems found by GCC 4.6.0 static checking.
949 * buffer.c (Qclone_number): Remove for now, as it's unused.
950 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
951 (record_buffer): Remove unused local.
952 * frame.c (other_visible_frames, frame_buffer_list): Now static.
953 (set_frame_buffer_list): Remove; unused.
954 * frame.h (other_visible_frames): Remove decl.
955 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
956 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
957 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
959 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
960 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
961 Define only if HAVE_GPM.
962 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
963 (update_hints_inhibit): Remove; never set. All uses removed.
964 * widgetprv.h (emacsFrameClassRec): Remove decl.
965 * window.c (delete_deletable_window): Now returns void, since it
966 wasn't returning anything.
967 (compare_window_configurations): Remove unused locals.
968 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
969 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
970 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
971 the same widths as pointers. This follows up on the 2011-05-06 patch.
972 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
974 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
976 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
978 * makefile.w32-in: Update dependencies.
979 (LISP_H): Add lib/intprops.h.
981 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
983 * image.c (gif_load): Add animation frame delay to the metadata.
984 (syms_of_image): Use DEFSYM. New symbol `delay'.
986 2011-06-11 Martin Rudalics <rudalics@gmx.at>
988 * window.c (delete_deletable_window): Re-add.
989 (Fset_window_configuration): Rewrite to handle dead buffers and
990 consequently deletable windows.
991 (window_tree, Fwindow_tree): Remove. Supply functionality in
993 (compare_window_configurations): Simplify code.
995 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
997 * image.c (imagemagick_load_image): Fix type mismatch.
998 (Fimagemagick_types): Likewise.
1000 * window.h (replace_buffer_in_windows): Declare.
1002 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1004 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1005 Qclone_number. Remove external declaration of Qdelete_window.
1006 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1008 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1009 Qbuffer_list_update_hook if allowed.
1010 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1011 buffer list implementation.
1012 (other_buffer_safely): New function.
1013 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1014 calls to replace_buffer_in_windows and
1015 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1017 (record_buffer): Inhibit quitting and rewrite using quittable
1018 functions. Run Qbuffer_list_update_hook if allowed.
1019 (Frecord_buffer, Funrecord_buffer): New functions.
1020 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1021 switch-to-buffer to window.el.
1022 (bury-buffer): Move to window.el.
1023 (Vbuffer_list_update_hook): New variable.
1025 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1028 * window.h (resize_frame_windows): Move up in code.
1029 (Fwindow_frame): Remove EXFUN.
1030 (replace_buffer_in_all_windows): Remove prototype.
1031 (replace_buffer_in_windows_safely): Add prototype.
1033 * window.c: Declare Qdelete_window static again. Move down
1034 declaration of select_count.
1035 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1036 (Fother_window): Move to window.el.
1037 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1038 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1039 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1041 (replace_buffer_in_windows): Implement by calling
1042 Qreplace_buffer_in_windows.
1043 (replace_buffer_in_all_windows): Remove with some functionality
1044 moved into replace_buffer_in_windows_safely.
1045 (replace_buffer_in_windows_safely): New function.
1046 (select_window_norecord, select_frame_norecord): Move in front
1047 of run_window_configuration_change_hook. Remove now obsolete
1049 (Fset_window_buffer): Rewrite doc-string. Call
1050 Qrecord_window_buffer.
1051 (keys_of_window): Move binding for other-window to window.el.
1053 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1055 * dispextern.h (struct image): Replace data member, whose int_val
1056 and ptr_val fields were not used by anything, with a single
1059 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1060 (gif_clear_image, gif_load, imagemagick_load_image)
1061 (gs_clear_image, gs_load): Callers changed.
1063 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1065 * buffer.h: Include <time.h>, for time_t.
1066 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1068 Fix minor problems found by static checking.
1070 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1072 Make identifiers static if they are not used in other modules.
1073 * data.c (Qcompiled_function, Qframe, Qvector):
1074 * image.c (QimageMagick, Qsvg):
1075 * minibuf.c (Qmetadata):
1076 * window.c (resize_window_check, resize_root_window): Now static.
1077 * window.h (resize_window_check, resize_root_window): Remove decls.
1079 * window.c (window_deletion_count, delete_deletable_window):
1081 (window_body_lines): Now static.
1082 (Fdelete_other_windows_internal): Mark vars as initialized.
1083 Make sure 'resize_failed' is initialized.
1084 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1085 (resize_window_apply): Remove unused local.
1086 * window.h (delete_deletable_window): Remove decl.
1088 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1089 (imagemagick_load_image): Fix pointer signedness problem by changing
1090 last arg from unsigned char * to char *. All uses changed.
1091 Also, fix a local for similar reasons.
1092 Remove unused locals. Remove locals to avoid shadowing.
1093 (fn_rsvg_handle_free): Remove; unused.
1094 (svg_load, svg_load_image): Fix pointer signedness problem.
1095 (imagemagick_load_image): Don't use garbage pointer image_wand.
1097 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1099 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1101 * image.c (gif_load): Fix omitted cast error introduced by
1104 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1106 * window.h (resize_proportionally, orig_total_lines)
1107 (orig_top_line): Remove from window structure.
1108 (set_window_height, set_window_width, change_window_heights)
1109 (Fdelete_window): Remove prototypes.
1110 (resize_frame_windows): Remove duplicate declaration.
1112 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1114 * window.h (resize_frame_windows, resize_window_check)
1115 (delete_deletable_window, resize_root_window)
1116 (resize_frame_windows): Declare prototypes.
1118 * window.c (resize_window_apply): Make definition be "static" to
1119 match the prototype.
1121 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1123 * window.c: Remove declarations of Qwindow_size_fixed,
1124 window_min_size_1, window_min_size_2, window_min_size,
1125 size_window, window_fixed_size_p, enlarge_window, delete_window.
1126 Remove static from declaration of Qdelete_window, it's
1127 temporarily needed by Fbury_buffer.
1128 (replace_window): Don't assign orig_top_line and
1130 (Fdelete_window, delete_window): Remove. Window deletion is
1131 handled by window.el.
1132 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1133 Fdelete_window calls with calls to Qdelete_window.
1134 (Fdelete_other_windows): Remove. Deleting other windows is
1135 handled by window.el.
1136 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1137 handled in window.el.
1138 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1139 Window minimum sizes are handled in window.el.
1140 (shrink_windows, size_window, set_window_height)
1141 (set_window_width, change_window_heights, window_height)
1142 (window_width, CURBEG, CURSIZE, enlarge_window)
1143 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1144 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1145 handled in window.el.
1146 (make_dummy_parent): Rename to make_parent_window and give it a
1147 second argument horflag.
1148 (make_window): Don't set resize_proportionally any more.
1149 (Fsplit_window): Remove. Windows are split in window.el.
1150 (save_restore_action, save_restore_orig_size)
1151 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1152 Resize mini windows in window.el.
1153 (grow_mini_window, shrink_mini_window): Implement by calling
1154 Qresize_root_window_vertically, resize_window_check and
1155 resize_window_apply.
1156 (saved_window, Fset_window_configuration, save_window_save): Do
1157 not handle orig_top_line, orig_total_lines, and
1158 resize_proportionally.
1159 (window_min_height, window_min_width): Move to window.el.
1160 (keys_of_window): Move bindings for delete-other-windows,
1161 split-window, delete-window and enlarge-window to window.el.
1163 * buffer.c: Temporarily extern Qdelete_window.
1164 (Fbury_buffer): Temporarily call Qdelete_window instead of
1165 Fdelete_window (Fbury_buffer will move to window.el soon).
1167 * frame.c (set_menu_bar_lines_1): Remove code handling
1168 orig_top_line and orig_total_lines.
1170 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1171 set_window_height but set heights directly.
1172 (change_frame_size_1): Use resize_frame_windows.
1174 * xdisp.c (init_xdisp): Don't use set_window_height but set
1177 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1178 resize_frame_windows instead of change_window_heights and run
1179 run_window_configuration_change_hook.
1181 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1182 instead of change_window_heights and run
1183 run_window_configuration_change_hook.
1185 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1187 * window.c (replace_window): Rename second argument REPLACEMENT to
1188 NEW. New third argument SETFLAG. Rewrite.
1189 (delete_window, make_dummy_parent): Call replace_window with
1191 (window_list_1): Move down in code.
1192 (run_window_configuration_change_hook): Move set_buffer part
1193 before select_frame_norecord part in order to unwind correctly.
1194 Rename count1 to count.
1195 (recombine_windows, delete_deletable_window, resize_root_window)
1196 (Fdelete_other_windows_internal)
1197 (Frun_window_configuration_change_hook, make_parent_window)
1198 (resize_window_check, resize_window_apply, Fresize_window_apply)
1199 (resize_frame_windows, Fsplit_window_internal)
1200 (Fdelete_window_internal, Fresize_mini_window_internal): New
1202 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1204 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1206 * window.h (window): Add some new members to window structure -
1207 normal_lines, normal_cols, new_total, new_normal, clone_number,
1208 splits, nest, prev_buffers, next_buffers.
1209 (WINDOW_TOTAL_SIZE): Move here from window.c.
1210 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1212 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1214 (make_dummy_parent): Set new members of windows structure.
1215 (make_window): Move down in code. Handle new members of window
1217 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1218 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1219 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1220 (Fset_window_prev_buffers, Fwindow_next_buffers)
1221 (Fset_window_next_buffers, Fset_window_clone_number): New
1223 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1224 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1226 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1227 Argument WINDOW can be now internal window too.
1228 (Fwindow_use_time): Move up in code.
1229 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1231 (Fset_window_configuration, saved_window)
1232 (Fcurrent_window_configuration, save_window_save): Handle new
1233 members of window structure.
1234 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1235 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1236 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1237 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1238 Qget_mru_window, Qresize_root_window,
1239 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1240 Qauto_buffer_name; staticpro them.
1242 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1244 * window.c (Fwindow_total_size, Fwindow_left_column)
1245 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1246 (Fwindow_list_1): New functions.
1247 (window_box_text_cols): Replace with window_body_cols.
1248 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1249 window_body_cols instead of window_box_text_cols.
1250 (delete_window, Fset_window_configuration): Call
1251 delete_all_subwindows with window as argument.
1252 (delete_all_subwindows): Take a window as argument and not a
1254 (window_loop): Remove handling of GET_LRU_WINDOW and
1256 (Fget_lru_window, Fget_largest_window): Move to window.el.
1258 * window.h: Extern window_body_cols instead of
1259 window_box_text_cols. delete_all_subwindows now takes a
1260 Lisp_Object as argument.
1262 * indent.c (compute_motion, Fcompute_motion): Use
1263 window_body_cols instead of window_box_text_cols.
1265 * frame.c (delete_frame): Call delete_all_subwindows with root
1268 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1270 * fns.c (Fputhash): Document return value.
1272 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1274 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1276 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1278 Cons<->int and similar integer overflow fixes (Bug#8794).
1280 Check for overflow when converting integer to cons and back.
1281 * charset.c (Fdefine_charset_internal, Fdecode_char):
1282 Use cons_to_unsigned to catch overflow.
1283 (Fencode_char): Use INTEGER_TO_CONS.
1284 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1285 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1286 * data.c (long_to_cons, cons_to_long): Remove.
1287 (cons_to_unsigned, cons_to_signed): New functions.
1288 These signal an error for invalid or out-of-range values.
1289 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1290 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1291 * font.c (Ffont_variation_glyphs):
1292 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1293 * lisp.h: Include <intprops.h>.
1294 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1295 (cons_to_signed, cons_to_unsigned): New decls.
1296 (long_to_cons, cons_to_long): Remove decls.
1297 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1298 (Fprimitive_undo): Use CONS_TO_INTEGER.
1299 * xfns.c (Fx_window_property): Likewise.
1300 * xselect.c: Include <limits.h>.
1301 (x_own_selection, selection_data_to_lisp_data):
1302 Use INTEGER_TO_CONS.
1303 (x_handle_selection_request, x_handle_selection_clear)
1304 (x_get_foreign_selection, Fx_disown_selection_internal)
1305 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1306 (lisp_data_to_selection_data): Use cons_to_unsigned.
1307 (x_fill_property_data): Use cons_to_signed.
1308 Report values out of range.
1310 Check for buffer and string overflow more precisely.
1311 * buffer.h (BUF_BYTES_MAX): New macro.
1312 * lisp.h (STRING_BYTES_MAX): New macro.
1313 * alloc.c (Fmake_string):
1314 * character.c (string_escape_byte8):
1315 * coding.c (coding_alloc_by_realloc):
1316 * doprnt.c (doprnt):
1317 * editfns.c (Fformat):
1319 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1320 since they may not be the same number.
1321 * editfns.c (Finsert_char):
1322 * fileio.c (Finsert_file_contents):
1323 Likewise for BUF_BYTES_MAX.
1325 * image.c: Use ptrdiff_t, not int, for sizes.
1326 (slurp_file): Switch from int to ptrdiff_t.
1328 (slurp_file): Check that file size fits in both size_t (for
1329 malloc) and ptrdiff_t (for sanity and safety).
1331 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1332 if b->modtime has its maximal value.
1334 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1336 Don't assume time_t can fit into int.
1337 * buffer.h (struct buffer.modtime): Now time_t, not int.
1338 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1339 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1341 Minor fixes for signed vs unsigned integers.
1342 * character.h (MAYBE_UNIFY_CHAR):
1343 * charset.c (maybe_unify_char):
1344 * keyboard.c (read_char, reorder_modifiers):
1345 XINT -> XFASTINT, since the integer must be nonnegative.
1346 * ftfont.c (ftfont_spec_pattern):
1347 * keymap.c (access_keymap, silly_event_symbol_error):
1348 XUINT -> XFASTINT, since the integer must be nonnegative.
1349 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1350 since it makes no difference and we prefer signed.
1351 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1352 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1355 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1357 * window.h (Fwindow_frame): Declare.
1359 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1361 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1362 (SPARE_MEMORY): Always define.
1363 (LARGE_REQUEST): Remove.
1364 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1366 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1368 * lisp.h: Move EXFUNS for Fframe_root_window,
1369 Fframe_first_window and Fset_frame_selected_window to window.h.
1371 * window.h: Move EXFUNS for Fframe_root_window,
1372 Fframe_first_window and Fset_frame_selected_window here from
1375 * frame.c (Fwindow_frame, Fframe_first_window)
1376 (Fframe_root_window, Fframe_selected_window)
1377 (Fset_frame_selected_window): Move to window.c.
1378 (Factive_minibuffer_window): Move to minibuf.c.
1379 (Fother_visible_frames_p): New function.
1381 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1383 * window.c (decode_window, decode_any_window): Move up in code.
1384 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1385 (inhibit_frame_unsplittable): Remove unused variable.
1386 (Fwindow_buffer): Move up and rewrite doc-string.
1387 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1388 (Fwindow_prev): New functions.
1389 (Fwindow_frame): Move here from frame.c. Accept any window as
1391 (Fframe_root_window, Fframe_first_window)
1392 (Fframe_selected_window): Move here from frame.c. Accept frame
1393 or arbitrary window as argument. Update doc-strings.
1394 (Fminibuffer_window): Move up in code.
1395 (Fwindow_minibuffer_p): Move up in code and simplify.
1396 (Fset_frame_selected_window): Move here from frame.c.
1398 (Fselected_window, select_window, Fselect_window): Move up in
1399 code. Minor doc-string fixes.
1401 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1403 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1404 Do not assume that spare memory exists; that assumption is valid
1405 only if SYSTEM_MALLOC.
1406 (LARGE_REQUEST): New macro, so that the issue of large requests
1407 is separated from the issue of spare memory.
1409 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1411 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1414 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1416 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1419 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1421 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1423 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1425 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1426 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1428 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1430 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1432 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1434 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1435 (x_clipboard_manager_save): Add return value.
1436 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1438 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1439 Obey Vx_select_enable_clipboard_manager. Catch errors in
1440 x_clipboard_manager_save (Bug#8779).
1441 (Vx_select_enable_clipboard_manager): New variable.
1442 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1444 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1446 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1448 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1450 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1451 in the current matrix if keep_current_p is non-zero.
1453 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1455 * bidi.c (bidi_level_of_next_char): Fix last change.
1457 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1459 Support bidi reordering of text covered by display properties.
1461 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1462 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1463 (bidi_cache_search, bidi_cache_iterator_state)
1464 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1465 (bidi_level_of_next_char, bidi_move_to_visually_next):
1466 Support character positions inside a run of characters covered by a
1468 (bidi_paragraph_init, bidi_resolve_explicit_1)
1469 (bidi_level_of_next_char): Call bidi_fetch_char and
1470 bidi_fetch_char_advance instead of FETCH_CHAR and
1472 (bidi_init_it): Initialize new members.
1473 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1475 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1476 instead of using explicit *_CHAR codes.
1477 (bidi_resolve_explicit, bidi_resolve_weak):
1478 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1479 bidirectional text is supported only in multibyte buffers.
1480 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1481 it to initialize the frame_window_p member of struct bidi_it.
1482 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1483 (bidi_resolve_explicit, bidi_resolve_weak)
1484 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1485 bidi_it->nchars is non-positive.
1486 (bidi_level_of_next_char): Don't try to lookup the cache for the
1487 next/previous character if nothing is cached there yet, or if we
1488 were just reseat()'ed to a new position.
1490 * xdisp.c (set_cursor_from_row): Set start and stop points
1491 according to the row's direction when priming the loop that looks
1492 for the glyph on which to display cursor.
1493 (single_display_spec_intangible_p): Function deleted.
1494 (display_prop_intangible_p): Reimplement to call
1495 handle_display_spec instead of single_display_spec_intangible_p.
1496 Accept 3 additional arguments needed by handle_display_spec.
1497 This fixes incorrect cursor motion across display property with complex
1498 values: lists, `(when COND...)' forms, etc.
1499 (single_display_spec_string_p): Support property values that are
1500 lists with the argument STRING its top-level element.
1501 (display_prop_string_p): Fix the condition for processing a
1502 property that is a list to be consistent with handle_display_spec.
1503 (handle_display_spec): New function, refactored from the
1504 last portion of handle_display_prop.
1505 (compute_display_string_pos): Accept additional argument
1506 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1507 value of a `display' property is a "replacing spec".
1508 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1509 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1510 the display property, but just return a value indicating whether
1511 the display property will replace the characters it covers.
1512 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1513 frame_window_p members of struct bidi_it.
1514 (compute_display_string_pos, compute_display_string_end):
1516 (push_it): Accept second argument POSITION, where pop_it should
1517 jump to continue iteration.
1518 (reseat_1): Initialize bidi_it.disp_pos.
1520 * keyboard.c (adjust_point_for_property): Adjust the call to
1521 display_prop_intangible_p to its new signature.
1523 * dispextern.h (struct bidi_it): New member frame_window_p.
1524 (bidi_init_it): Update prototypes.
1525 (display_prop_intangible_p): Update prototype.
1526 (compute_display_string_pos, compute_display_string_end):
1528 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1531 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1533 Malloc failure behavior now depends on size of allocation.
1534 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1535 * lisp.h: Change signatures accordingly.
1536 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1537 All callers changed. (Bug#8762)
1539 * gnutls.c: Use Emacs's memory allocators.
1540 Without this change, the gnutls library would invoke malloc etc.
1541 directly, which causes problems on non-SYNC_INPUT hosts, and which
1542 runs afoul of improving memory_full behavior. (Bug#8761)
1543 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1544 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1545 xfree instead of the default malloc, realloc, free.
1546 (Fgnutls_boot): No need to check for memory allocation failure,
1547 since xmalloc does that for us.
1549 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1550 * category.c (hash_get_category_set):
1551 * ccl.c (ccl_driver):
1552 * charset.c (Fdefine_charset_internal):
1553 * charset.h (struct charset.hash_index):
1554 * composite.c (get_composition_id, gstring_lookup_cache)
1555 (composition_gstring_put_cache):
1556 * composite.h (struct composition.hash_index):
1557 * dispextern.h (struct image.hash):
1558 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1559 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1560 (hashfn_equal, hashfn_user_defined, make_hash_table)
1561 (maybe_resize_hash_table, hash_lookup, hash_put)
1562 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1563 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1564 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1565 * image.c (make_image, search_image_cache, lookup_image)
1566 (xpm_put_color_table_h):
1567 * lisp.h (struct Lisp_Hash_Table):
1568 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1569 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1570 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1571 * alloc.c (allocate_vectorlike):
1572 Check for overflow in vector size calculations.
1573 * ccl.c (ccl_driver):
1574 Check for overflow when converting EMACS_INT to int.
1575 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1576 need to be updated by these changes.
1577 * fns.c (make_hash_table, maybe_resize_hash_table):
1578 Check for integer overflow with large hash tables.
1579 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1580 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1581 (SXHASH_REDUCE): New macro.
1582 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1583 Use it instead of discarding useful hash info with large hash values.
1584 (sxhash_float): New function.
1585 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1586 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1587 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1588 Rewrite to use FIXNUM_BITS, as this simplifies things.
1589 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1590 Adjust signatures to match updated version of code.
1591 (consing_since_gc): Now EMACS_INT, since a single hash table can
1592 use more than INT_MAX bytes.
1594 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1596 Make it possible to build with GCC-4.6+ -O2 -flto.
1598 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1600 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1602 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1603 Call minibuffer-inactive-mode.
1605 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1607 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1608 Update dependencies.
1610 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1612 * data.c (init_data): Remove code for UTS, this system is not
1615 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1617 Don't force ./temacs to start in terminal mode.
1619 * frame.c (make_initial_frame): Initialize faces in all cases, not
1620 only when CANNOT_DUMP is defined.
1621 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1623 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1625 * dispnew.c (add_window_display_history): Use const for the string
1626 pointer. Remove declaration, not needed.
1628 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1630 Use 'inline', not 'INLINE'.
1631 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1632 * alloc.c, fontset.c (INLINE): Remove.
1633 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1634 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1635 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1636 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1637 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1639 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1641 Make it possible to run ./temacs.
1643 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1644 syms_of_callproc does the same thing. Remove test for
1645 "initialized", do it in the caller.
1646 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1648 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1650 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1651 (read_minibuf): Use get_minibuffer.
1652 (syms_of_minibuf): Use DEFSYM.
1653 (Qmetadata): New var.
1654 * data.c (Qbuffer): Don't make it static.
1655 (syms_of_data): Use DEFSYM.
1657 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1659 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1660 (CCL_CODE_MIN): New macro.
1662 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1664 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1666 * eval.c (Qdebug): Now static.
1667 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1668 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1669 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1671 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1673 * image.c: Various fixes to ImageMagick code comments.
1674 (Fimagemagick_types): Doc fix.
1676 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1678 Minor fixes prompted by GCC 4.6.0 warnings.
1680 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1682 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1683 (x_clipboard_manager_save_all): Move extern decl to ...
1684 * xterm.h: ... here, so that it can be checked for consistency.
1686 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1688 * xselect.c (x_clipboard_manager_save_frame)
1689 (x_clipboard_manager_save_all): New functions.
1690 (Fx_clipboard_manager_save): Lisp function deleted.
1692 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1693 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1695 * xterm.h: Update prototype.
1697 2011-05-28 William Xu <william.xwl@gmail.com>
1699 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1702 2011-05-28 Jim Meyering <meyering@redhat.com>
1704 Avoid a sign-extension bug in crypto_hash_function.
1705 * fns.c (to_uchar): Define.
1706 (crypto_hash_function): Use it to convert some newly-signed
1707 variables to unsigned, to avoid sign-extension bugs. For example,
1708 without this change, (md5 "truc") would evaluate to
1709 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1710 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1711 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1713 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1715 Integer overflow fixes.
1717 * dbusbind.c: Serial number integer overflow fixes.
1718 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1719 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1720 to hold a serial number that is too large for a fixnum.
1721 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1722 Check for serial numbers out of range. Decode any serial number
1723 that was so large that it became a float. (Bug#8722)
1725 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1726 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1727 Use XFASTINT rather than XUINT when numbers are nonnegative.
1728 (xd_append_arg, Fdbus_method_return_internal):
1729 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1730 arguments, check that Lisp number is nonnegative, rather than
1731 silently wrapping negative numbers around. (Bug#8722)
1732 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1735 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1737 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1739 ccl: add integer overflow checks
1740 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1741 (IN_INT_RANGE): New macros.
1742 (ccl_driver): Use them to check for integer overflow when
1743 decoding a CCL program. Many of the new checks are whether XINT (x)
1744 fits in int; it doesn't always, on 64-bit hosts. The new version
1745 doesn't catch all possible integer overflows, but it's an
1746 improvement. (Bug#8719)
1748 * alloc.c (make_event_array): Use XINT, not XUINT.
1749 There's no need for unsigned here.
1751 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1752 This follows up to the 2011-05-06 change that substituted uintptr_t
1753 for EMACS_INT. This case wasn't caught back then.
1755 Rework Fformat to avoid integer overflow issues.
1756 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1757 now (part of C89). Include <verify.h>.
1758 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1759 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1760 (Fformat): Avoid the prepass trying to compute sizes; it was only
1761 approximate and thus did not catch overflow reliably. Instead, walk
1762 through the format just once, formatting and computing sizes as we go,
1763 checking for integer overflow at every step, and allocating a larger
1764 buffer as needed. Keep track separately whether the format is
1765 multibyte. Keep only the most-recently calculated precision, rather
1766 than them all. Record whether each argument has been converted to
1767 string. Use EMACS_INT, not int, for byte and char and arg counts.
1768 Support field widths and precisions larger than INT_MAX. Avoid
1769 sprintf's undefined behavior with conversion specifications such as %#d
1770 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1771 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1772 formatting out-of-range floating point numbers with int
1775 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1777 * data.c: Avoid integer truncation in expressions involving floats.
1778 * data.c: Include <intprops.h>.
1779 (arith_driver): When there's an integer overflow in an expression
1780 involving floating point, convert the integers to floating point
1781 so that the resulting value does not suffer from catastrophic
1782 integer truncation. For example, on a 64-bit host (* 4
1783 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1784 Do not rely on undefined behavior after integer overflow.
1786 merge count_size_as_multibyte, parse_str_to_multibyte
1787 * character.c, character.h (count_size_as_multibyte):
1788 Rename from parse_str_to_multibyte; all uses changed.
1789 Check for integer overflow.
1790 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1791 since it's now a duplicate of the other. This is more of
1792 a character than a buffer op, so better that it's in character.c.
1793 * fns.c, print.c: Adjust to above changes.
1795 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1797 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1799 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1801 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1802 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1803 (x_clipboard_manager_save): Now static.
1804 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1806 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1807 (crypto_hash_function): Now static.
1808 Fix pointer signedness problems. Avoid unnecessary initializations.
1810 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1812 * termhooks.h (Vselection_alist): Make it terminal-local.
1814 * terminal.c (create_terminal): Initialize it.
1816 * xselect.c: Support for clipboard managers.
1817 (Vselection_alist): Move to termhooks.h as terminal-local var.
1818 (LOCAL_SELECTION): New macro.
1819 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1820 (symbol_to_x_atom): Remove gratuitous arg.
1821 (x_handle_selection_request, lisp_data_to_selection_data)
1822 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1823 (x_own_selection, x_get_local_selection, x_convert_selection):
1824 New arg, specifying work frame. Use terminal-local Vselection_alist.
1825 (some_frame_on_display): Delete unused function.
1826 (Fx_own_selection_internal, Fx_get_selection_internal)
1827 (Fx_disown_selection_internal, Fx_selection_owner_p)
1828 (Fx_selection_exists_p): New optional frame arg.
1829 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1830 (x_handle_selection_clear): Don't treat other terminals with the
1831 same keyboard specially. Use the terminal-local Vselection_alist.
1832 (x_clear_frame_selections): Use Frun_hook_with_args.
1834 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1836 * xterm.h: Add support for those atoms.
1838 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1840 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1841 (converted_selections, conversion_fail_tag): New global variables.
1842 (x_selection_request_lisp_error): Free the above.
1843 (x_get_local_selection): Remove unnecessary code.
1844 (x_reply_selection_request): Args changed; handle arbitrary array
1845 of converted selections stored in converted_selections.
1846 Separate the XChangeProperty and SelectionNotify steps.
1847 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1848 (x_convert_selection): New function.
1849 (x_handle_selection_event): Simplify.
1850 (x_get_foreign_selection): Don't ignore incoming requests while
1851 waiting for an answer; this will fail when we implement
1852 SAVE_TARGETS, and seems unnecessary anyway.
1853 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1854 (Vx_sent_selection_functions): Doc fix.
1856 2011-05-26 Leo Liu <sdl.web@gmail.com>
1858 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1860 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1862 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1864 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1865 for fringe update if it has periodic bitmap.
1866 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1867 and fringe_bitmap_periodic_p.
1869 * fringe.c (get_fringe_bitmap_data): New function.
1870 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1871 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1872 row. Mark glyph row for fringe update if periodicity changed.
1874 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1875 for fringe update unless it has periodic bitmap.
1877 2011-05-25 Kenichi Handa <handa@m17n.org>
1879 * xdisp.c (get_next_display_element): Set correct it->face_id for
1880 a static composition.
1882 2011-05-24 Leo Liu <sdl.web@gmail.com>
1885 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1887 * fns.c (crypto_hash_function, Fsha1): New function.
1888 (Fmd5): Use crypto_hash_function.
1889 (syms_of_fns): Add Ssha1.
1891 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1893 * gnutls.c: Remove unused macros.
1894 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1895 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1896 Remove macros that are defined and never used.
1897 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1899 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1901 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1902 (Fx_get_selection_internal): Minor cleanup.
1903 (Fx_own_selection_internal): Rename arguments for consistency with
1906 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1908 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1910 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1912 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1914 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1916 * dispnew.c (scrolling_window): Don't exclude the case that the
1917 last enabled row in the desired matrix touches the bottom boundary.
1919 2011-05-21 Glenn Morris <rgm@gnu.org>
1921 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1922 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1923 and add some more files.
1925 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1927 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1928 report_file_error introduced by the change from 2011-05-07.
1930 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1932 * systime.h (Time): Define only if emacs is defined.
1933 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1934 where the include path doesn't have X11/X.h by default. See
1935 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1937 2011-05-20 Kenichi Handa <handa@m17n.org>
1939 * composite.c (find_automatic_composition): Fix previous change.
1941 2011-05-20 Glenn Morris <rgm@gnu.org>
1943 * lisp.mk: New file, split from Makefile.in.
1944 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1945 (shortlisp): Remove.
1946 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1948 2011-05-19 Glenn Morris <rgm@gnu.org>
1950 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1951 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1952 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1953 (lisp): Set the order to that of loadup.el.
1954 (shortlisp): Make it a copy of $lisp.
1955 (SOME_MACHINE_LISP): Remove.
1956 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1957 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1959 2011-05-18 Kenichi Handa <handa@m17n.org>
1961 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1962 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1963 (find_automatic_composition): Mostly rewrite for efficiency.
1965 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1967 * makefile.w32-in: Update dependencies.
1969 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1971 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1972 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1974 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1976 Fix some integer overflow issues, such as string length overflow.
1978 * insdel.c (count_size_as_multibyte): Check for string overflow.
1980 * character.c (lisp_string_width): Check for string overflow.
1981 Use EMACS_INT, not int, for string indexes and lengths; in
1982 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1983 the resulting string length overflows an EMACS_INT; instead,
1984 report a string overflow if no precision given. When checking for
1985 precision exhaustion, use a check that cannot possibly have
1986 integer overflow. (Bug#8675)
1987 * character.h (lisp_string_width): Adjust to new signature.
1989 * alloc.c (string_overflow): New function.
1990 (Fmake_string): Use it. This doesn't change behavior, but saves
1991 a few bytes and will simplify future changes.
1992 * character.c (string_escape_byte8): Likewise.
1993 * lisp.h (string_overflow): New decl.
1995 Fixups, following up to the user-interface timestamp change.
1996 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1997 for UI timestamps, instead of unsigned long.
1998 * msdos.c (mouse_get_pos): Likewise.
1999 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2000 * w32gui.h (Time): Define by including "systime.h" rather than by
2001 declaring it ourselves. (Bug#8664)
2003 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2004 * image.c (clear_image_cache): Likewise.
2006 * term.c (term_mouse_position): Don't assume time_t wraparound.
2008 Be more systematic about user-interface timestamps.
2009 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2010 and sometimes 'EMACS_UINT', to represent these timestamps.
2011 This change causes it to use 'Time' uniformly, as that's what X uses.
2012 This makes the code easier to follow, and makes it easier to catch
2013 integer overflow bugs such as Bug#8664.
2014 * frame.c (Fmouse_position, Fmouse_pixel_position):
2015 Use Time, not unsigned long, for user-interface timestamps.
2016 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2017 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2018 * keyboard.h (last_event_timestamp): Likewise.
2019 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2020 * menu.h (xmenu_show): Likewise.
2021 * term.c (term_mouse_position): Likewise.
2022 * termhooks.h (struct input_event.timestamp): Likewise.
2023 (struct terminal.mouse_position_hook): Likewise.
2024 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2025 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2026 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2027 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2029 * menu.h, termhooks.h: Include "systime.h", for Time.
2031 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2032 Don't assume that the difference between two unsigned long values
2033 can fit into an integer. At this point, we know button_down_time
2034 <= event->timestamp, so the difference must be nonnegative, so
2035 there's no need to cast the result if double-click-time is
2036 nonnegative, as it should be; check that it's nonnegative, just in
2037 case. This bug is triggered when events are more than 2**31 ms
2038 apart (about 25 days). (Bug#8664)
2040 * xselect.c (last_event_timestamp): Remove duplicate decl.
2041 (x_own_selection): Remove needless cast to unsigned long.
2043 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2044 that always fit in int. Use a sentinel instead of a counter, to
2045 avoid a temp and to allay GCC's concerns about possible int overflow.
2046 * frame.h (struct frame): Use int for menu_bar_items_used
2047 instead of EMACS_INT, since it always fits in int.
2049 * menu.c (grow_menu_items): Check for int overflow.
2051 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2053 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2054 Before, the code was not consistent. These values cannot exceed
2055 2**31 - 1 so there's no need to make them unsigned.
2056 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2057 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2058 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2060 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2062 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2063 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2064 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2065 presumably because the widths might not match.
2067 * window.c (size_window): Avoid needless test at loop start.
2069 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2071 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2073 2011-05-12 Drew Adams <drew.adams@oracle.com>
2075 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2077 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2079 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2080 `width' to `bar_area_x' and `bar_area_width', respectively.
2081 (x_scroll_run): Take account of fringe background extension.
2083 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2084 Rename local vars `left' and `width' to `bar_area_x' and
2085 `bar_area_width', respectively.
2086 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2087 background extension.
2089 2011-05-10 Jim Meyering <meyering@redhat.com>
2091 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2093 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2095 * image.c (Finit_image_library): Return t for built-in image types,
2096 like pbm and xbm. (Bug#8640)
2098 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2100 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2102 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2104 * w32console.c (Fset_screen_color): Doc fix.
2105 (Fget_screen_color): New function.
2106 (syms_of_ntterm): Defsubr it.
2108 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2109 unlink the temporary file if Fcall_process didn't create it in the
2111 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2112 child process will be redirected to a file specified with `:file'.
2113 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2114 cue to call_process_cleanup not to close that handle.
2116 2011-05-07 Ben Key <bkey76@gmail.com>
2118 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2119 one of two shell specific rules, either bootstrap-temacs-CMD or
2120 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2121 to the previous implementation of the bootstrap-temacs rule.
2122 The bootstrap-temacs-CMD rule is similar to the previous
2123 implementation of the bootstrap-temacs rule except that it
2124 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2127 These changes, along with some changes to nt/configure.bat,
2128 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2129 earlier fix to add support for --cflags and --ldflags options
2130 that include quotes so that it works whether make uses cmd or
2133 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2135 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2136 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2138 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2139 a string. Handle both cases.
2140 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2141 (Fdbus_register_method): Use Qinvalid_function.
2143 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2145 * makefile.w32-in: Update dependencies.
2146 (LISP_H): Add inttypes.h and stdin.h.
2147 (PROCESS_H): Add unistd.h.
2149 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2151 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2152 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2154 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2156 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2158 * term.c (vfatal): Remove stray call to va_end.
2159 It's not needed and the C Standard doesn't allow it here anyway.
2161 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2162 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2164 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2167 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2169 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2171 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2173 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2175 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2177 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2178 * charset.c (Fdefine_charset_internal): Don't initialize
2179 charset.code_space[15]. The value was garbage, on hosts with
2180 32-bit int (Bug#8600).
2182 * lread.c (read_integer): Be more consistent with string-to-number.
2183 Use string_to_number to do the actual conversion; this avoids
2184 rounding errors and fixes some other screwups. Without this fix,
2185 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2186 (digit_to_number): Move earlier, for benefit of read_integer.
2187 Return -1 if the digit is out of range for the base, -2 if it is
2188 not a digit in any supported base. (Bug#8602)
2190 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2192 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2193 to match comment at start of function. This also removes a
2194 GCC warning about overflow in a 32+64-bit port.
2196 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2198 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2199 Reported by Stefan Monnier in
2200 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2201 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2202 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2204 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2205 (EMACS_UINTPTR): Likewise, with uintptr_t.
2207 * lisp.h: Prefer 64-bit EMACS_INT if available.
2208 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2209 on 32-bit hosts that have 64-bit int, so that they can access
2211 However, temporarily disable this change unless the temporary
2212 symbol WIDE_EMACS_INT is defined.
2214 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2216 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2217 This removes an assumption that EMACS_INT and long are the same
2218 width as pointers. The assumption is true for Emacs porting targets
2219 now, but we want to make other targets possible.
2220 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2221 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2222 In the rest of the code, change types of integers that hold casted
2223 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2224 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2225 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2226 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2227 No need to cast type when ORing.
2228 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2229 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2230 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2231 assume EMACS_INT is the same width as char *.
2232 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2233 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2234 Remove no-longer-needed casts.
2235 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2236 (xg_tool_bar_help_callback, xg_make_tool_item):
2237 Use EMACS_INTPTR to hold an integer
2238 that will be cast to void *; this can avoid a GCC warning
2239 if EMACS_INT is not the same width as void *.
2240 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2241 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2242 (current_message_1, set_message_1):
2243 Use a local to convert to proper width without a cast.
2244 * xmenu.c (dialog_selection_callback): Likewise.
2246 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2247 Also, don't assume VALBITS / RAND_BITS is less than 5,
2248 and don't rely on undefined behavior when shifting a 1 left into
2250 * lisp.h (get_random): Change signature to match.
2252 * lread.c (hash_string): Use size_t, not int, for hash computation.
2253 Normally we prefer signed values; but hashing is special, because
2254 it's better to use unsigned division on hash table sizes so that
2255 the remainder is nonnegative. Also, size_t is the natural width
2256 for hashing into memory. The previous code used 'int', which doesn't
2257 retain enough info to hash well into very large tables.
2258 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2260 * dbusbind.c: Don't possibly lose pointer info when converting.
2261 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2262 Use XPNTR rather than XHASH, so that the high-order bits of
2263 the pointer aren't lost when converting through void *.
2265 * eval.c (Fautoload): Don't double-shift a pointer.
2267 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2269 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2271 * gnutls.c (DEF_GNUTLS_FN):
2272 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2274 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2276 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2279 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2281 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2282 New version that can reserve upto 2GB of heap space.
2284 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2286 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2288 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2290 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2291 `gnutls_certificate_set_x509_key_file'.
2293 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2295 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2296 Update dependencies.
2298 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2300 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2301 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2302 Remove unused parameter `fildes'.
2303 * process.c (read_process_output, send_process): Don't pass it.
2305 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2307 Fix previous change: the library cache is defined in w32.c.
2308 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2309 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2311 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2313 Implement dynamic loading of GnuTLS on Windows.
2315 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2316 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2317 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2320 * gnutls.c (Qgnutls_dll): Define.
2321 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2322 (gnutls_*): Declare function pointers.
2323 (init_gnutls_functions): New function to initialize function pointers.
2324 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2325 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2326 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2327 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2328 (emacs_gnutls_write, emacs_gnutls_read)
2329 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2330 (Fgnutls_available_p): New function.
2331 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2332 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2333 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2335 * image.c: Include w32.h.
2336 (Vimage_type_cache): Delete.
2337 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2338 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2339 (w32_delayed_load): Move to w32.c.
2341 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2343 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2344 (w32_delayed_load): Move from image.c. When loading a library, record
2345 its filename in the :loaded-from property of the library id.
2346 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2347 Initialize and staticpro them.
2348 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2350 * process.c: Include lisp.h before w32.h, not after.
2351 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2352 instead of gnutls_record_check_pending.
2354 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2356 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2358 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2359 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2362 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2364 * xterm.c (x_set_frame_alpha): Do not set property on anything
2365 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2367 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2369 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2371 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2373 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2374 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2375 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2376 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2377 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2378 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2379 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2380 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2381 (Qgnutls_bootprop_callbacks_verify): Make static.
2383 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2385 * callproc.c: Indentation fixup.
2387 * sysdep.c (wait_for_termination_1): Make static.
2388 (wait_for_termination, interruptible_wait_for_termination):
2389 Move after wait_for_termination_1.
2391 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2393 * sysdep.c (interruptible_wait_for_termination): New function
2394 which is like wait_for_termination, but allows keyboard
2397 * callproc.c (Fcall_process): Add (:file "file") as an option for
2399 (Fcall_process_region): Ditto.
2401 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2403 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2404 rather than `XVECTOR (FOO)->size'.
2406 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2407 inttypes.h, as a gnulib replacement is used if it not available in
2410 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2412 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2413 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2414 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2416 * coding.c (coding_alloc_by_realloc): Error out if destination
2417 will grow beyond MOST_POSITIVE_FIXNUM.
2418 (decode_coding_emacs_mule): Abort if there isn't enough place in
2419 charbuf for the composition carryover bytes. Reserve an extra
2420 space for up to 2 characters produced in a loop.
2421 (decode_coding_iso_2022): Abort if there isn't enough place in
2422 charbuf for the composition carryover bytes.
2424 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2426 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2427 aborting when %lld or %lll format is passed.
2428 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2429 %llo or %llx format is passed. (Bug#8545)
2431 * window.c (window_scroll_line_based): Use a marker instead of
2432 simple variables to record original value of point. (Bug#7952)
2434 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2435 produced by %s or %c overflows available buffer space. (Bug#8545)
2437 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2439 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2440 (SIZE_MAX): Move defn after all includes, as they might #define it.
2442 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2444 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2446 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2448 * keyboard.c (Qdelayed_warnings_hook): Define.
2449 (command_loop_1): Run `delayed-warnings-hook'
2450 if Vdelayed_warnings_list is non-nil.
2451 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2452 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2454 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2456 * doprnt.c (doprnt): Don't return value smaller than the buffer
2457 size if the message was truncated. (Bug#8545).
2459 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2461 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2462 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2464 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2466 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2468 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2470 * makefile.w32-in: Update dependencies.
2472 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2474 Improve `doprnt' and its usage. (Bug#8545)
2475 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2476 `format_end'. Remove support for %l as a conversion specifier.
2477 Don't use xrealloc. Improve diagnostics when the %l size modifier
2478 is used. Update the commentary.
2480 * eval.c (verror): Simplify calculation of size_t.
2482 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2485 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2487 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2490 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2492 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2493 This makes this file independent of the recent pseudovector change.
2495 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2497 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2499 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2500 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2501 Remove unused local.
2502 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2504 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2505 GCC 4.6.0 optimizes based on type-based alias analysis.
2506 For example, if b is of type struct buffer * and v of type struct
2507 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2508 != &v->size, and therefore "v->size = 1; b->size = 2; return
2509 v->size;" must therefore return 1. This assumption is incorrect
2510 for Emacs, since it type-puns struct Lisp_Vector * with many other
2511 types. To fix this problem, this patch adds a new type struct
2512 vectorlike_header that documents the constraints on layout of vectors
2513 and pseudovectors, and helps optimizing compilers not get fooled
2514 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2515 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2516 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2518 (XSETPVECTYPE): Rewrite in terms of new macro.
2519 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2520 This is a bit clearer, and further avoids the possibility of
2521 undesirable aliasing.
2522 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2523 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2524 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2525 since Lisp_Subr is a special case (no "next" field).
2526 (ASIZE): Now uses header.size rather than size.
2527 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2528 to avoid the hassle of writing XVECTOR (foo)->header.size.
2529 (struct vectorlike_header): New type.
2530 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2531 object, to help avoid aliasing.
2532 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2533 (SUBRP): Likewise, since Lisp_Subr is a special case.
2534 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2535 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2536 (struct Lisp_Hash_Table): Combine first two members into a single
2537 struct vectorlike_header member. All uses of "size" and "next" members
2538 changed to be "header.size" and "header.next".
2539 * buffer.h (struct buffer): Likewise.
2540 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2541 * frame.h (struct frame): Likewise.
2542 * process.h (struct Lisp_Process): Likewise.
2543 * termhooks.h (struct terminal): Likewise.
2544 * window.c (struct save_window_data, struct saved_window): Likewise.
2545 * window.h (struct window): Likewise.
2546 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2547 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2548 * buffer.c (init_buffer_once): Likewise.
2549 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2551 * process.c (Fformat_network_address): Use local var for size,
2554 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2556 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2557 * data.c (atof): Remove decl; no longer used or needed.
2558 (digit_to_number): Move to lread.c.
2559 (Fstring_to_number): Use new string_to_number function, to be
2560 consistent with how the Lisp reader treats infinities and NaNs.
2561 Do not assume that floating-point numbers represent EMACS_INT
2562 without losing information; this is not true on most 64-bit hosts.
2563 Avoid double-rounding errors, by insisting on integers when
2564 parsing non-base-10 numbers, as the documentation specifies.
2565 * lisp.h (string_to_number): New decl, replacing ...
2566 (isfloat_string): Remove.
2567 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2568 (read1): Do not accept +. and -. as integers; this
2569 appears to have been a coding error. Similarly, do not accept
2570 strings like +-1e0 as floating point numbers. Do not report
2571 overflow for integer overflows unless the base is not 10 which
2572 means we have no simple and reliable way to continue.
2573 Break out the floating-point parsing into a new
2574 function string_to_number, so that Fstring_to_number parses
2575 floating point numbers consistently with the Lisp reader.
2576 (digit_to_number): Move here from data.c. Make it static inline.
2577 (E_CHAR, EXP_INT): Remove, replacing with ...
2578 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2579 (string_to_number): New function, replacing isfloat_string.
2580 This function checks for valid syntax and produces the resulting
2581 Lisp float number too. Rework it so that string-to-number
2582 no longer mishandles examples like "1.0e+". Use strtoumax,
2583 so that overflow for non-base-10 numbers is reported only when
2584 there's no portable and simple way to convert to floating point.
2586 * textprop.c (set_text_properties_1): Rewrite for clarity,
2587 and to avoid GCC warning about integer overflow.
2589 * intervals.h (struct interval): Use EMACS_INT for members
2590 where EMACS_UINT might cause problems. See
2591 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2592 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2593 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2595 (offset_intervals): Tell GCC not to worry about length overflow
2596 when negating a negative length.
2598 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2599 (overrun_check_free): Likewise.
2601 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2602 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2605 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2606 (gnutls_make_error): Rename local to avoid shadowing.
2607 (gnutls_emacs_global_deinit): ifdef out; not used.
2608 (Fgnutls_boot): Use const for pointer to readonly storage.
2609 Comment out unused local. Fix pointer signedness problems.
2611 * lread.c (openp): Don't stuff size_t into an 'int'.
2612 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2613 about possible signed overflow.
2615 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2616 (GDK_KEY_g): Don't define if already defined.
2617 (xg_prepare_tooltip): Avoid pointer signedness problem.
2618 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2620 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2621 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2623 * xfns.c (Fx_window_property): Simplify a bit,
2624 to make a bit faster and to avoid GCC 4.6.0 warning.
2625 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2627 * fns.c (internal_equal): Don't assume size_t fits in int.
2629 * alloc.c (compact_small_strings): Tighten assertion a little.
2631 Replace pEd with more-general pI, and fix some printf arg casts.
2632 * lisp.h (pI): New macro, generalizing old pEd macro to other
2633 conversion specifiers. For example, use "...%"pI"d..." rather
2634 than "...%"pEd"...".
2635 (pEd): Remove. All uses replaced with similar uses of pI.
2636 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2637 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2638 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2639 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2640 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2641 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2642 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2644 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2645 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2646 * print.c (safe_debug_print, print_object): Likewise.
2647 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2649 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2650 avoiding the 0 flag, which is not portable.
2651 * process.c (Fmake_network_process): Use pI to avoid cast.
2652 * region-cache.c (pp_cache): Likewise.
2653 * xdisp.c (decode_mode_spec): Likewise.
2654 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2655 behavior on 64-bit hosts with printf arg.
2656 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2657 (x_stop_queuing_selection_requests): Likewise.
2658 (x_get_window_property): Don't truncate byte count to an 'int'
2661 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2662 here, since it parses constructs like leading '-' and spaces,
2663 which are not wanted; and it overflows with large numbers.
2664 Instead, simply match F[0-9]+, which is what is wanted anyway.
2666 * alloc.c: Remove unportable assumptions about struct layout.
2667 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2668 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2669 (allocate_vectorlike, make_pure_vector): Use the new macros,
2670 plus offsetof, to remove unportable assumptions about struct layout.
2671 These assumptions hold on all porting targets that I know of, but
2672 they are not guaranteed, they're easy to remove, and removing them
2673 makes further changes easier.
2675 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2676 This doesn't fix a bug but makes the code clearer.
2677 (string_overrun_cookie): Now const. Use initializers that
2678 don't formally overflow signed char, to avoid warnings.
2679 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2680 can cause Emacs to crash when string overrun checking is enabled.
2681 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2682 multiple of sizeof (EMACS_INT); it need not be, if
2683 alignof(EMACS_INT) < sizeof (EMACS_INT).
2684 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2686 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2688 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2690 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2692 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2693 supposed to be handshaking. (Bug#8556)
2694 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2696 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2698 * lisp.h (Qdebug): List symbol.
2699 * eval.c (Qdebug): Restore global linkage.
2700 * keyboard.c (debug-on-event): New variable.
2701 (handle_user_signal): Break into debugger when debug-on-event
2702 matches the current signal symbol.
2704 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2706 * alloc.c (check_sblock, check_string_bytes)
2707 (check_string_free_list): Convert to standard C.
2709 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2711 * w32.c (emacs_gnutls_push): Fix typo.
2713 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2715 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2716 "cast to pointer from integer of different size".
2718 Improve doprnt and its use in verror. (Bug#8545)
2719 * doprnt.c (doprnt): Document the set of format control sequences
2720 supported by the function. Use SAFE_ALLOCA instead of always
2723 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2724 is one byte too soon. Don't use xrealloc; instead xfree and
2727 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2729 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2732 * gnutls.c: Renamed global_initialized to
2733 gnutls_global_initialized. Added internals for the
2734 :verify-hostname-error, :verify-error, and :verify-flags
2735 parameters of `gnutls-boot' and documented those parameters in the
2736 docstring. Start callback support.
2737 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2738 unless a fatal error occured. Call gnutls_alert_send_appropriate
2739 on error. Return error code.
2740 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2741 (emacs_gnutls_read): Likewise.
2742 (Fgnutls_boot): Return handshake error code.
2743 (emacs_gnutls_handle_error): New function.
2744 (wsaerror_to_errno): Likewise.
2746 * w32.h (emacs_gnutls_pull): Add prototype.
2747 (emacs_gnutls_push): Likewise.
2749 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2750 (emacs_gnutls_push): Likewise.
2752 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2754 * process.c (wait_reading_process_output): Check if GnuTLS
2755 buffered some data internally if no FDs are set for TLS
2758 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2759 (LIBS): Link to USER_LIBS.
2760 ($(BLD)/gnutls.$(0)): New target.
2762 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2764 * xdisp.c (handle_single_display_spec): Rename the
2765 display_replaced_before_p argument into display_replaced_p, to
2766 make it consistent with the commentary. Fix typos in the
2769 * textprop.c (syms_of_textprop): Remove dead code.
2770 (copy_text_properties): Delete obsolete commentary about an
2771 interface that was deleted long ago. Fix typos in the description
2774 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2775 to changes in oldXMenu/XMenu.h from 2011-04-16.
2776 <menu_help_message, prev_menu_help_message>: Constify.
2777 (IT_menu_make_room): menu->help_text is now `const char **';
2780 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2781 to changes in oldXMenu/XMenu.h from 2011-04-16.
2782 (struct XMenu): Declare `help_text' `const char **'.
2784 * xfaces.c <Qunspecified>: Make extern again.
2786 * syntax.c: Include sys/types.h before including regex.h, as
2789 * doc.c (get_doc_string): Improve the format passed to `error'.
2791 * doprnt.c (doprnt): Improve commentary.
2793 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2795 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2798 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2799 changes in globals.h immediately force recompilation.
2800 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2801 $(CURDIR)/s/ms-w32.h.
2802 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2804 * character.c (Fchar_direction): Function deleted.
2805 (syms_of_character): Don't defsubr it.
2806 <char-direction-table>: Deleted.
2808 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2810 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2811 * doprnt.c: Include limits.h.
2812 (SIZE_MAX): New macro.
2813 (doprnt): Return a size_t value. 2nd arg is now size_t.
2814 Many local variables are now size_t instead of int or unsigned.
2815 Improve overflow protection. Support `l' modifier for integer
2816 conversions. Support %l conversion. Don't assume an EMACS_INT
2817 argument for integer conversions and for %c.
2819 * lisp.h (doprnt): Restore prototype.
2821 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2824 * Makefile.in (base_obj): Add back doprnt.o.
2826 * deps.mk (doprnt.o): Add back prerequisites.
2827 (callint.o): Depend on character.h.
2829 * eval.c (internal_lisp_condition_case): Include the handler
2830 representation in the error message.
2831 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2832 when breaking from the loop.
2834 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2836 * callint.c (Fcall_interactively): When displaying error message
2837 about invalid control letter, pass the character's codepoint, not
2838 a pointer to its multibyte form. Improve display of the character
2839 in octal and display also its hex code.
2841 * character.c (char_string): Use %x to display the (unsigned)
2842 codepoint of an invalid character, to avoid displaying a bogus
2845 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2846 `error', not SYMBOL_NAME itself.
2848 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2849 character arguments to `error'.
2851 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2852 to `error' in error message about FINAL_CHAR argument. Make sure
2853 FINAL_CHAR is a character, and use %c when it is passed as
2854 argument to `error'.
2856 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2858 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2860 * w32.c: Include <time.h>.
2861 (sys_localtime): New function.
2863 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2865 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2867 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2869 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2871 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2874 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2876 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2877 gl_state.e_property when gl_state.object is Qt.
2879 * insdel.c (make_gap_larger): Remove limitation of buffer size
2882 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2884 * xdisp.c (lookup_glyphless_char_display)
2885 (produce_glyphless_glyph): Handle cons cell entry in
2886 glyphless-char-display.
2887 (Vglyphless_char_display): Document it.
2889 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2890 glyphless-char-display.
2892 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2894 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2896 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2898 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2899 definition for no-X builds.
2901 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2903 Static checks with GCC 4.6.0 and non-default toolkits.
2905 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2907 * process.c (keyboard_bit_set): Define only if SIGIO.
2908 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2909 (send_process): Repair possible setjmp clobbering.
2911 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2913 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2915 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2917 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2918 Define only if needed.
2920 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2921 by pacifying GCC about it. Maybe it's time to retire it?
2922 * xfaces.c (USG, __TIMEVAL__): Likewise.
2924 * dispextern.h (struct redisplay_interface): Rename param
2926 * termhooks.h (struct terminal): Likewise.
2927 * xterm.c (xembed_send_message): Likewise.
2929 * insdel.c (make_gap_smaller): Define only if
2930 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2932 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2935 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2936 so that we aren't warned about unused symbols.
2938 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2940 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2942 * xfns.c (x_real_positions): Mark locals as initialized.
2944 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2946 * xterm.c: Fix problems found by static analysis with other toolkits.
2947 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2948 (x_dispatch_event): Declare static if USE_GTK, and
2949 define if USE_GTK || USE_X_TOOLKIT.
2950 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2951 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2952 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2953 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2955 * xmenu.c (menu_help_callback): Pointer type fixes.
2956 Use const pointers when pointing at readonly data. Avoid pointer
2958 (FALSE): Remove unused macro.
2959 (update_frame_menubar): Remove unused decl.
2961 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2963 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2964 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2965 (single_menu_item): Rename local to avoid shadowing.
2967 * keyboard.c (make_lispy_event): Remove unused local var.
2969 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2970 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2972 * bitmaps: Change bitmaps from unsigned char back to the X11
2973 compatible char. Avoid the old compiler warnings about
2974 out-of-range initializers by using, for example, '\xab' rather
2977 * xgselect.c (xgselect_initialize): Check vs interface
2978 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2980 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2982 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2983 to read-only memory.
2985 * fns.c (vector): Remove; this old hack is no longer needed.
2987 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2989 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2991 * xrdb.c (x_load_resources): Omit unused local.
2993 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2994 (x_window): Rename locals to avoid shadowing.
2995 (USG): Use the kludged USG macro, to pacify gcc.
2997 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2998 (x_term_init): Remove local to avoid shadowing.
3000 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3002 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3003 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3005 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3007 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3009 Fix regex.c, syntax.c and friends for buffers > 2GB.
3010 * syntax.h (struct gl_state_s): Declare character position members
3013 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3015 * textprop.c (verify_interval_modification, interval_of):
3016 Declare arguments EMACS_INT.
3018 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3021 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3023 * indent.c (Fvertical_motion): Local variable it_start is now
3026 * regex.c (re_match, re_match_2, re_match_2_internal)
3027 (bcmp_translate, regcomp, regexec, print_double_string)
3028 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3029 (re_compile_pattern, re_exec): Declare arguments and local
3030 variables `size_t' and `ssize_t' and return values `regoff_t', as
3032 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3033 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3034 <compile_stack_type>: `size' and `avail' are now `size_t'.
3036 * regex.h <regoff_t>: Use ssize_t, not int.
3037 (re_search, re_search_2, re_match, re_match_2): Arguments that
3038 specify buffer/string position and length are now ssize_t and
3039 size_t. Return type is regoff_t.
3041 2011-04-16 Ben Key <bkey76@gmail.com>
3043 * nsfont.m: Fixed bugs in ns_get_family and
3044 ns_descriptor_to_entity that were caused by using free to
3045 deallocate memory blocks that were allocated by xmalloc (via
3046 xstrdup). This caused Emacs to crash when compiled with
3047 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3048 --enable-checking=xmallocoverrun). xfree is now used to
3049 deallocate these memory blocks.
3051 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3053 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3055 emacs_write: Accept and return EMACS_INT for sizes.
3056 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3058 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3059 Accept and return EMACS_INT.
3060 (emacs_gnutls_write): Return the number of bytes written on
3062 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3063 (emacs_read, emacs_write): Remove check for negative size, as the
3064 Emacs source code has been audited now.
3065 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3066 (emacs_read, emacs_write): Use it.
3067 * process.c (send_process): Adjust to the new signatures of
3068 emacs_write and emacs_gnutls_write. Do not attempt to store
3069 a byte offset into an 'int'; it might overflow.
3070 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3072 * sound.c: Don't assume sizes fit in 'int'.
3073 (struct sound_device.period_size, alsa_period_size):
3074 Return EMACS_INT, not int.
3075 (struct sound_device.write, vox_write, alsa_write):
3076 Accept EMACS_INT, not int.
3077 (wav_play, au_play): Use EMACS_INT to store sizes and to
3078 record read return values.
3080 2011-04-15 Ben Key <bkey76@gmail.com>
3082 * keyboard.c (Qundefined): Don't declare static since it is used
3084 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3085 static since they are used in nsfont.m.
3087 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3089 * process.c (Qprocessp): Don't declare static.
3090 * lisp.h (Qprocessp): Declare again.
3092 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3094 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3096 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3098 Improve C-level modularity by making more things 'static'.
3100 Don't publish debugger-only interfaces to other modules.
3101 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3102 (verify_bytepos, count_markers): Move decls to the only modules
3104 * region-cache.h (pp_cache): Likewise.
3105 * window.h (check_all_windows): Likewise.
3106 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3108 * sysdep.c (croak): Now static, if
3109 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3110 * syssignal.h (croak): Declare only if not static.
3112 * alloc.c (refill_memory_reserve): Now static if
3113 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3114 * lisp.h (refill_memory_reserve): Declare only if not static.
3116 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3117 Define only if USE_LUCID.
3119 * xrdb.c (x_customization_string, x_rm_string): Now static.
3121 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3122 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3124 * xdisp.c (draw_row_with_mouse_face): Now static.
3125 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3127 * window.h (check_all_windows): Mark externally visible.
3129 * window.c (window_deletion_count): Now static.
3131 * undo.c: Make symbols static if they're not exported.
3132 (last_undo_buffer, last_boundary_position, pending_boundary):
3135 * textprop.c (interval_insert_behind_hooks): Now static.
3136 (interval_insert_in_front_hooks): Likewise.
3138 * term.c: Make symbols static if they're not exported.
3139 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3140 (max_frame_lines, tty_set_terminal_modes):
3141 (tty_reset_terminal_modes, tty_turn_off_highlight):
3142 (get_tty_terminal): Now static.
3143 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3144 * termhooks.h (term_mouse_moveto): Do not declare if
3146 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3147 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3149 * sysdep.c: Make symbols static if they're not exported.
3150 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3152 (sigprocmask_set, full_mask): Remove; unused.
3153 (wait_debugging): Mark as visible.
3154 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3155 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3157 * syntax.c (syntax_temp): Define only if !__GNUC__.
3159 * sound.c (current_sound_device, current_sound): Now static.
3161 * search.c (searchbufs, searchbuf_head): Now static.
3163 * scroll.c (scroll_cost): Remove; unused.
3164 * dispextern.h (scroll_cost): Remove decl.
3166 * region-cache.h (pp_cache): Mark as externally visible.
3168 * process.c: Make symbols static if they're not exported.
3169 (process_tick, update_tick, create_process, chan_process):
3170 (Vprocess_alist, proc_buffered_char, datagram_access):
3171 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3172 (deactivate_process): Mark defn as static, as well as decl.
3173 * lisp.h (create_process): Remove decl.
3174 * process.h (chan_process, Vprocess_alist): Remove decls.
3176 * print.c: Make symbols static if they're not exported.
3177 (print_depth, new_backquote_output, being_printed, print_buffer):
3178 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3179 (print_interval, print_number_index, initial_stderr_stream):
3181 * lisp.h (Fprinc): Remove decl.
3182 (debug_output_compilation_hack): Mark as externally visible.
3184 * sysdep.c (croak): Move decl from here to syssignal.h.
3185 * syssignal.h (croak): Put it here, so the API can be checked when
3186 'croak' is called from dissociate_if_controlling_tty.
3188 * minibuf.c: Make symbols static if they're not exported.
3189 (minibuf_save_list, choose_minibuf_frame): Now static.
3190 * lisp.h (choose_minibuf_frame): Remove decl.
3192 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3194 * lread.c: Make symbols static if they're not exported.
3195 (read_objects, initial_obarray, oblookup_last_bucket_number):
3197 (make_symbol): Remove; unused.
3198 * lisp.h (initial_obarray, make_symbol): Remove decls.
3200 * keyboard.c: Make symbols static if they're not exported.
3201 (single_kboard, recent_keys_index, total_keys, recent_keys):
3202 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3203 (this_single_command_key_start, echoing, last_auto_save):
3204 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3205 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3206 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3207 (Vlispy_mouse_stem, double_click_count):
3209 (force_auto_save_soon): Define only if SIGDANGER.
3210 (ignore_mouse_drag_p): Now static if
3211 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3212 (print_help): Remove; unused.
3213 (stop_character, last_timer_event): Mark as externally visible.
3214 * keyboard.h (ignore_mouse_drag_p): Declare only if
3215 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3216 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3217 * lisp.h (echoing): Remove decl.
3218 (force_auto_save_soon): Declare only if SIGDANGER.
3219 * xdisp.c (redisplay_window): Simplify code, to make it more
3220 obvious that ignore_mouse_drag_p is not accessed if !defined
3221 USE_GTK && !defined HAVE_NS.
3223 * intervals.c: Make symbols static if they're not exported.
3224 (merge_properties_sticky, merge_interval_right, delete_interval):
3226 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3228 * insdel.c: Make symbols static if they're not exported.
3229 However, leave prepare_to_modify_buffer alone. It's never
3230 called from outside this function, but that appears to be a bug.
3231 (combine_after_change_list, combine_after_change_buffer):
3232 (adjust_after_replace, signal_before_change): Now static.
3233 (adjust_after_replace_noundo): Remove; unused.
3234 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3235 (signal_before_change): Remove decls.
3237 * indent.c (val_compute_motion, val_vmotion): Now static.
3239 * image.c: Make symbols static if they're not exported.
3240 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3242 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3243 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3245 * fringe.c (standard_bitmaps): Now static.
3246 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3248 * frame.c: Make symbols static if they're not exported.
3249 (x_report_frame_params, make_terminal_frame): Now static.
3250 (get_frame_param): Now static, unless HAVE_NS.
3251 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3252 (x_get_resource_string): Remove; not used.
3253 * frame.h (make_terminal_frame, x_report_frame_params):
3254 (x_get_resource_string); Remove decls.
3255 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3256 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3258 * font.c, fontset.c: Make symbols static if they're not exported.
3259 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3260 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3261 * font.c (font_close_object): Now static.
3262 * font.h (font_close_object): Remove.
3263 * fontset.c (FONTSET_OBJLIST): Remove.
3264 (free_realized_fontset) #if-0 the body, which does nothing.
3265 (face_suitable_for_char_p): #if-0, as it's never called.
3266 * fontset.h (face_suitable_for_char_p): Remove decl.
3267 * xfaces.c (face_at_string_position):
3268 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3269 since 0 is always ASCII.
3271 * fns.c (weak_hash_tables): Now static.
3273 * fileio.c: Make symbols static if they're not exported.
3274 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3275 (Vwrite_region_annotation_buffers): Now static.
3277 * eval.c: Make symbols static if they're not exported.
3278 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3279 * lisp.h (backtrace_list): Remove decl.
3281 * emacs.c: Make symbols static if they're not exported.
3282 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3283 (fatal_error_code, fatal_error_signal_hook, standard_args):
3285 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3286 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3287 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3288 * lisp.h (fatal_error_signal_hook): Remove decl.
3289 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3291 * editfns.c: Move a (normally-unused) function to its only use.
3292 * editfns.c, lisp.h (get_operating_system_release): Remove.
3293 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3294 worth the hassle of breaking this out.
3296 * xterm.c: Make symbols static if they're not exported.
3297 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3298 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3299 (x_destroy_window, x_delete_display):
3301 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3302 (x_mouse_leave): Remove; unused.
3303 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3304 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3305 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3307 (x_mouse_leave): Declare only if WINDOWSNT.
3308 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3309 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3312 * ftxfont.c: Make symbols static if they're not exported.
3313 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3315 * font.h (ftxfont_driver): Likewise.
3317 * xfns.c: Make symbols static if they're not exported.
3318 (x_last_font_name, x_display_info_for_name):
3319 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3320 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3321 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3322 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3323 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3324 (last_show_tip_args): Now static.
3325 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3326 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3327 (x_screen_planes): Remove; unused.
3328 * dispextern.h (x_screen_planes): Remove decl.
3330 * dispnew.c: Make symbols static if they're not exported.
3331 * dispextern.h (redraw_garbaged_frames, scrolling):
3332 (increment_row_positions): Remove.
3333 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3334 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3336 (redraw_garbaged_frames): Remove; unused.
3338 * xfaces.c: Make symbols static if they're not exported.
3339 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3341 * xterm.h (defined_color): Remove decls.
3342 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3343 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3344 (menu_face_changed_default, defined_color, free_realized_face):
3345 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3346 (ascii_face_of_lisp_face): Remove; unused.
3348 * xdisp.c: Make symbols static if they're not exported.
3349 * dispextern.h (scratch_glyph_row, window_box_edges):
3350 (glyph_to_pixel_coords, set_cursor_from_row):
3351 (get_next_display_element, set_iterator_to_next):
3352 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3353 (show_mouse_face): Remove decls
3354 * frame.h (message_buf_print): Likewise.
3355 * lisp.h (pop_message, set_message, check_point_in_composition):
3357 * xterm.h (set_vertical_scroll_bar): Likewise.
3358 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3359 (message_buf_print, scratch_glyph_row, displayed_buffer):
3360 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3361 (get_next_display_element, show_mouse_face, window_box_edges):
3362 (frame_to_window_pixel_xy, check_point_in_composition):
3363 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3364 (glyph_to_pixel_coords): Remove; unused.
3366 * dired.c (file_name_completion): Now static.
3368 * dbusbind.c (xd_in_read_queued_messages): Now static.
3370 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3371 * data.c (circular_list_error): Remove.
3373 * commands.h (last_point_position, last_point_position_buffer):
3374 (last_point_position_window): Remove decls.
3375 * keyboard.c: Make these variables static.
3377 * coding.h (coding, code_convert_region, encode_coding_gap):
3379 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3380 (iso_code_class, detect_coding, code_convert_region): Now static.
3381 (encode_coding_gap): Remove; unused.
3383 * chartab.c (chartab_chars, chartab_bits): Now static.
3385 * charset.h (charset_iso_8859_1): Remove decl.
3386 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3389 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3390 * ccl.c (Vccl_program_table): Now static.
3391 (check_ccl_update): Remove; unused.
3393 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3394 * category.h: ... from here.
3395 * category.c (check_category_table, set_category_set): Now static.
3397 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3398 * lisp.h: Remove these decls.
3400 * buffer.c (buffer_count): Remove unused var.
3402 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3403 so that it's not optimized away.
3404 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3405 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3406 exported only to the debugger.
3408 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3409 * atimer.h (run_all_atimers): Remove; not exported.
3411 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3412 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3413 was inaccessible from Lisp.
3414 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3415 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3417 alloc.c: Import and export fewer symbols, and remove unused items.
3418 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3420 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3421 it's not optimized away by whole-program optimization.
3422 (message_enable_multibyte, free_misc): Remove.
3423 (catchlist, handlerlist, mark_backtrace):
3424 Declare only if BYTE_MARK_STACK.
3425 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3426 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3427 (message_enable_multibyte): Remove decl.
3428 (free_misc, interval_free_list, float_block, float_block_index):
3429 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3430 (cons_free_list, last_marked_index):
3432 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3433 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3434 (mark_backtrace): Define only if BYTE_MARK_STACK.
3435 * xdisp.c (message_enable_multibyte): Now static.
3437 Declare Lisp_Object Q* variables to be 'static' if not exported.
3438 This makes it easier for human readers (and static analyzers)
3439 to see whether these variables are used from other modules.
3440 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3441 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3442 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3443 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3444 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3445 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3446 * xmenu.c, xselect.c:
3447 Declare Q* vars static if they are not used in other modules.
3448 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3449 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3450 Remove decls of unexported vars.
3451 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3453 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3455 Make Emacs functions such as Fatom 'static' by default.
3456 This makes it easier for human readers (and static analyzers)
3457 to see whether these functions can be called from other modules.
3458 DEFUN now defines a static function. To make the function external
3459 so that it can be used in other C modules, use the new macro DEFUE.
3460 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3461 (Finit_image_library):
3462 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3463 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3464 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3465 Remove decls, since these functions are now static.
3466 (Funintern, Fget_internal_run_time): New decls, since these functions
3467 were already external.
3469 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3470 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3471 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3472 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3473 * keyboard.c, keymap.c, lread.c:
3474 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3475 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3476 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3477 Mark functions with DEFUE instead of DEFUN,
3478 if they are used in other modules.
3479 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3480 decls for now-static functions.
3481 * buffer.h (Fdelete_overlay): Remove decl.
3482 * callproc.c (Fgetenv_internal): Mark as internal.
3483 * composite.c (Fremove_list_of_text_properties): Remove decl.
3484 (Fcomposition_get_gstring): New forward static decl.
3485 * composite.h (Fcomposite_get_gstring): Remove decl.
3486 * dired.c (Ffile_attributes): New forward static decl.
3487 * doc.c (Fdocumntation_property): New forward static decl.
3488 * eval.c (Ffetch_bytecode): New forward static decl.
3489 (Funintern): Remove extern decl; now in .h file where it belongs.
3490 * fileio.c (Fmake_symbolic_link): New forward static decl.
3491 * image.c (Finit_image_library): New forward static decl.
3492 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3493 * intervals.h (Fprevious_property_change):
3494 (Fremove_list_of_text_properties): Remove decls.
3495 * keyboard.c (Fthis_command_keys): Remove decl.
3496 (Fcommand_execute): New forward static decl.
3497 * keymap.c (Flookup_key): New forward static decl.
3498 (Fcopy_keymap): Now static.
3499 * keymap.h (Flookup_key): Remove decl.
3500 * process.c (Fget_process): New forward static decl.
3501 (Fprocess_datagram_address): Mark as internal.
3502 * syntax.c (Fsyntax_table_p): New forward static decl.
3503 (skip_chars): Remove duplicate decl.
3504 * textprop.c (Fprevious_property_change): New forward static decl.
3505 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3507 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3508 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3510 * editfns.c (Fformat): Remove unreachable code.
3512 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3514 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3517 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3519 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3520 when at ZV. (Bug#8487)
3522 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3524 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3526 * keyboard.c (parse_tool_bar_item): Likewise.
3527 * sound.c (sound_cleanup, alsa_close): Likewise.
3528 * termcap.c (tgetent): Likewise.
3529 * xfns.c (x_default_font_parameter): Likewise.
3530 * xsettings.c (read_and_apply_settings): Likewise.
3532 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3533 (overrun_check_free): Protoize.
3535 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3537 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3538 since callers should never pass a negative size.
3539 Change the signature to match that of plain 'read' and 'write'; see
3540 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3541 * lisp.h: Update prototypes of emacs_write and emacs_read.
3543 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3545 * xdisp.c (redisplay_window): Don't try to determine the character
3546 position of the scroll margin if the window start point w->startp
3547 is outside the buffer's accessible region. (Bug#8468)
3549 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3551 Fix write-region and its subroutines for buffers > 2GB.
3552 * fileio.c (a_write, e_write): Modify declaration of arguments and
3553 local variables to support buffers larger than 2GB.
3554 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3556 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3557 argument, local variables, and return value.
3559 * lisp.h: Update prototypes of emacs_write and emacs_read.
3561 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3563 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3565 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3567 Fix more problems found by GCC 4.6.0's static checks.
3569 * xdisp.c (vmessage): Use a better test for character truncation.
3571 * charset.c (load_charset_map): <, not <=, for optimization,
3572 and to avoid potential problems with integer overflow.
3573 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3574 * casetab.c (set_identity, shuffle): Likewise.
3575 * editfns.c (Fformat): Likewise.
3576 * syntax.c (skip_chars): Likewise.
3578 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3579 This also lets GCC 4.6.0 generate slightly better loop code.
3581 * callint.c (Fcall_interactively): <, not <=, for optimization.
3582 (Fcall_interactively): Count the number of arguments produced,
3583 not the number of arguments given. This is simpler and lets GCC
3584 4.6.0 generate slightly better code.
3586 * ftfont.c: Distingish more carefully between FcChar8 and char.
3587 The previous code passed unsigned char * to a functions like
3588 strlen and xstrcasecmp that expect char *, which does not
3589 conform to the C standard.
3590 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3591 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3592 char * when the C standard requires it.
3594 * keyboard.c (read_char): Remove unused var.
3596 * eval.c: Port to Windows vsnprintf (Bug#8435).
3598 (SIZE_MAX): Define if the headers do not.
3599 (verror): Do not give up if vsnprintf returns a negative count.
3600 Instead, grow the buffer. This ports to Windows vsnprintf, which
3601 does not conform to C99. Problem reported by Eli Zaretskii.
3602 Also, simplify the allocation scheme, by avoiding the need for
3603 calling realloc, and removing the ALLOCATED variable.
3605 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3607 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3608 But keep the doprint source code for now, as we might revamp it
3609 and use it again (Bug#8435).
3610 * lisp.h (doprnt): Remove.
3611 * Makefile.in (base_obj): Remove doprnt.o.
3612 * deps.mk (doprnt.o): Remove.
3614 error: Print 32- and 64-bit integers portably (Bug#8435).
3615 Without this change, on typical 64-bit hosts error ("...%d...", N)
3616 was used to print both 32- and 64-bit integers N, which relied on
3618 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3620 * lisp.h (error, verror): Mark as printf-like functions.
3621 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3622 Report overflow in size calculations when allocating printf buffer.
3623 Do not truncate output string at its first null byte.
3624 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3625 Truncate the output at a character boundary, since vsnprintf does not
3627 * charset.c (check_iso_charset_parameter): Convert internal
3628 character to string before calling 'error', since %c now has the
3630 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3631 overflow when computing char to be passed to 'error'. Do not
3632 pass Lisp_Object to 'error'; pass the integer instead.
3633 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3634 formatted with plain %d.
3636 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3638 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3640 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3642 * xterm.c (x_catch_errors): Remove duplicate declaration.
3644 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3646 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3648 2011-04-10 Jim Meyering <meyering@redhat.com>
3650 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3651 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3652 return ssize_t not "int", and use size_t as the buffer length.
3653 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3654 * gnutls.h: Update declarations.
3655 * process.c (read_process_output): Use ssize_t, to match.
3656 (send_process): Likewise.
3658 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3660 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3662 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3664 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3665 Use unsigned char, to match FcChar8 type definition.
3667 * xterm.c (handle_one_xevent):
3668 * xmenu.c (create_and_show_popup_menu):
3669 * xselect.c (x_decline_selection_request)
3670 (x_reply_selection_request): Avoid type-punned deref of X events.
3672 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3674 Fix some uses of `int' instead of EMACS_INT.
3675 * search.c (string_match_1, fast_string_match)
3676 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3677 (scan_buffer, find_next_newline_no_quit)
3678 (find_before_next_newline, search_command, Freplace_match)
3679 (Fmatch_data): Make some `int' variables be EMACS_INT.
3681 * xdisp.c (display_count_lines): 3rd argument and return value now
3682 EMACS_INT. All callers changed.
3683 (pint2hrstr): Last argument is now EMACS_INT.
3685 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3686 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3687 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3688 (decode_coding_utf_16, decode_coding_emacs_mule)
3689 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3690 (decode_coding_ccl, decode_coding_charset)
3691 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3692 (decode_coding_iso_2022, decode_coding_emacs_mule)
3693 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3694 <char_offset, last_offset>: Declare EMACS_INT.
3695 (encode_coding_utf_8, encode_coding_utf_16)
3696 (encode_coding_emacs_mule, encode_invocation_designation)
3697 (encode_designation_at_bol, encode_coding_iso_2022)
3698 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3699 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3701 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3702 (encode_invocation_designation): Last argument P_NCHARS is now
3704 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3705 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3707 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3710 * ccl.c (Fccl_execute_on_string): Declare some variables
3713 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3715 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3717 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3719 * process.c (Fformat_network_address): Doc fix.
3721 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3723 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3725 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3727 * keyboard.c (read_char): Call Lisp function help-form-show,
3728 instead of using internal_with_output_to_temp_buffer.
3729 (Qhelp_form_show): New var.
3730 (syms_of_keyboard): Use DEFSYM macro.
3732 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3734 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3736 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3738 * process.c (Flist_processes): Remove to Lisp.
3739 (list_processes_1): Delete.
3741 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3743 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3745 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3747 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3749 Fix more problems found by GCC 4.6.0's static checks.
3751 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3753 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3755 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3757 * xdisp.c (vmessage): Mark as a printf-like function.
3759 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3761 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3763 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3764 printf-like functions.
3765 (tiff_load): Add casts to remove these marks before passing them
3766 to system-supplied API.
3768 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3770 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3771 This avoids several warnings with gcc -Wstrict-overflow.
3772 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3773 directly, rather than having caller test rule sign. This avoids
3774 some unnecessary tests.
3775 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3776 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3777 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3779 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3780 (xfont_open): Avoid unnecessary tests.
3782 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3784 * composite.h, composite.c (composition_gstring_put_cache):
3785 Use EMACS_INT, not int, for length.
3787 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3788 breaking out part of COMPOSITION_DECODE_RULE.
3789 (COMPOSITION_DECODE_RULE): Use it.
3790 * composite.c (get_composition_id): Remove unused local vars,
3791 by using the new macro.
3793 * textprop.c (set_text_properties_1): Change while to do-while,
3794 since the condition is always true at first.
3796 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3797 (interval_deletion_adjustment): Return unsigned value.
3800 * process.c (list_processes_1, create_pty, read_process_output):
3801 (exec_sentinel): Remove vars that were set but not used.
3802 (create_pty): Remove unnecessary "volatile"s.
3803 (Fnetwork_interface_info): Avoid possibility of int overflow.
3804 (read_process_output): Do adaptive read buffering even if carryover.
3805 (read_process_output): Simplify nbytes computation if buffered.
3807 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3809 * syntax.c (scan_words): Remove var that was set but not used.
3810 (update_syntax_table): Use unsigned instead of int.
3812 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3813 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3814 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3816 * print.c (print_error_message): Avoid int overflow.
3818 * font.c (font_list_entities): Redo for clarity,
3819 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3821 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3822 (font_score): Avoid potential overflow in diff calculation.
3824 * fns.c (substring_both): Remove var that is set but not used.
3825 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3827 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3829 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3830 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3831 can always succeed if overflow has undefined behavior.
3833 * search.c (boyer_moore, wordify): Remove vars set but not used.
3834 (wordify): Omit three unnecessary tests.
3836 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3837 All callers changed. This avoids the need for an unused var.
3839 * casefiddle.c (casify_region): Remove var that is set but not used.
3841 * dired.c (file_name_completion): Remove var that is set but not used.
3843 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3845 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3846 (Finsert_file_contents): Remove unnecessary code checking fd.
3848 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3849 Check for integer overflow on size calculations.
3851 * buffer.c (Fprevious_overlay_change): Remove var that is set
3854 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3855 Remove vars that are set but not used.
3856 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3857 (timer_check_2): Mark vars as initialized.
3859 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3861 * image.c (lookup_image): Remove var that is set but not used.
3862 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3864 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3865 that are set but not used.
3867 * xfns.c (make_invisible_cursor): Don't return garbage
3868 if XCreateBitmapFromData fails (Bug#8410).
3870 * xselect.c (x_get_local_selection, x_handle_property_notify):
3871 Remove vars that are set but not used.
3873 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3874 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3876 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3877 Remove var that is set but not used.
3878 (scroll_bar_windows_size): Now size_t, not int.
3879 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3882 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3883 (map_tty_color) [!defined MSDOS]: Likewise.
3885 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3887 * coding.c: Remove vars that are set but not used.
3888 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3889 All callers changed.
3890 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3891 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3892 (decode_coding_charset): Remove vars that are set but not used.
3894 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3895 that is set but not used.
3897 * print.c (print_object): Remove var that is set but not used.
3899 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3900 The gnulib version avoids calling malloc in the usual case,
3901 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3902 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3903 * filelock.c (current_lock_owner): Likewise.
3904 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3905 * sysdep.c: Include allocator.h, careadlinkat.h.
3906 (emacs_no_realloc_allocator): New static constant.
3907 (emacs_readlink): New function.
3908 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3909 ../lib/careadlinkat.h.
3911 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3913 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3914 first non-nil return value).
3916 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3918 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3919 if not defined (Bug#8403).
3921 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3923 * xdisp.c (display_count_lines): Remove parameter `start',
3924 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3925 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3926 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3927 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3928 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3929 and thereabouts. All callers changed.
3930 (get_per_char_metric): Remove parameter `f', unused since
3931 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3933 2011-04-02 Jim Meyering <meyering@redhat.com>
3935 do not dereference NULL upon failed strdup
3936 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3937 (ns_get_family): Likewise.
3939 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3941 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3943 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3945 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3948 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3950 Add lexical binding.
3952 * window.c (Ftemp_output_buffer_show): New fun.
3953 (Fsave_window_excursion):
3954 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3956 * lread.c (lisp_file_lexically_bound_p): New function.
3957 (Fload): Bind Qlexical_binding.
3958 (readevalloop): Remove `evalfun' arg.
3959 Bind Qinternal_interpreter_environment.
3960 (Feval_buffer): Bind Qlexical_binding.
3961 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3963 (syms_of_lread): Declare `lexical-binding'.
3965 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3967 * keyboard.c (eval_dyn): New fun.
3968 (menu_item_eval_property): Use it.
3970 * image.c (parse_image_spec): Use Ffunctionp.
3972 * fns.c (concat, mapcar1): Accept byte-code-functions.
3974 * eval.c (Fsetq): Handle lexical vars.
3975 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3976 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3977 (FletX, Flet): Obey lexical binding.
3978 (Fcommandp): Handle closures.
3979 (Feval): New `lexical' arg.
3980 (eval_sub): New function extracted from Feval. Use it almost
3981 everywhere where Feval was used. Look up vars in lexical env.
3983 (Ffunctionp): Move from subr.el.
3984 (Ffuncall): Handle closures.
3985 (apply_lambda): Remove `eval_flags'.
3986 (funcall_lambda): Handle closures and new byte-code-functions.
3987 (Fspecial_variable_p): New function.
3988 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3989 but without exporting it to Lisp.
3991 * doc.c (Fdocumentation, store_function_docstring):
3992 * data.c (Finteractive_form): Handle closures.
3994 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3997 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3999 (exec_byte_code): New function extracted from Fbyte_code to handle new
4000 calling convention for byte-code-functions. Add new byte-codes.
4002 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4004 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4006 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4008 * xdisp.c (redisplay_internal): Fix prototype.
4010 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4012 * xdisp.c (SCROLL_LIMIT): New macro.
4013 (try_scrolling): Use it when setting scroll_limit.
4014 Limit scrolling to 100 screen lines.
4015 (redisplay_window): Even when falling back on "recentering",
4016 position point in the window according to scroll-conservatively,
4017 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4019 (try_scrolling): When point is above the window, allow searching
4020 as far as scroll_max, or one screenful, to compute vertical
4021 distance from PT to the scroll margin position. This prevents
4022 try_scrolling from unnecessarily failing when
4023 scroll-conservatively is set to a value slightly larger than the
4024 window height. Clean up the case of PT below the margin at bottom
4025 of window: scroll_max can no longer be INT_MAX. When aggressive
4026 scrolling is in use, don't let point enter the opposite scroll
4027 margin as result of the scroll.
4028 (syms_of_xdisp) <scroll-conservatively>: Document the
4029 threshold of 100 lines for never-recentering scrolling.
4031 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4033 * dispextern.h (move_it_by_lines):
4034 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4035 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4036 (message_log_check_duplicate): Remove parameters `prev_bol' and
4037 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4038 (redisplay_internal): Remove parameter `preserve_echo_area',
4039 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4041 * indent.c (Fvertical_motion):
4042 * window.c (window_scroll_pixel_based, Frecenter):
4043 Don't pass `need_y_p' to `move_it_by_lines'.
4045 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4047 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4048 steal a few bits to be more compact.
4049 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4050 Remove unneeded casts.
4052 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4054 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4056 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4057 binding" message (bug#7967).
4059 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4061 Fix more problems found by GCC 4.6.0's static checks.
4063 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4064 Remove unused local var.
4066 * editfns.c (Fmessage_box): Remove unused local var.
4068 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4069 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4070 Omit unused local vars.
4071 * window.c (shrink_windows): Omit unused local var.
4072 * menu.c (digest_single_submenu): Omit unused local var.
4073 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4074 Omit unused local var.
4076 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4077 Don't assume string length fits in int.
4078 (keyremap_step, read_key_sequence): Use size_t for sizes.
4079 (read_key_sequence): Don't check last_real_key_start redundantly.
4081 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4082 instead of alloca (Bug#8344).
4084 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4085 (Fbacktrace_frame): Don't assume nframes fits in int.
4087 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4089 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4092 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4094 * cm.c (calccost): Turn while-do into do-while, for clarity.
4096 * keyboard.c (syms_of_keyboard): Use the same style as later
4097 in this function when indexing through an array. This also
4098 works around GCC bug 48267.
4100 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4102 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4104 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4105 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4107 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4108 This avoids undefined behavior on integer overflow, and is a bit
4109 more convenient anyway since it is compared to a size_t variable.
4111 Variadic C functions now count arguments with size_t, not int.
4112 This avoids an unnecessary limitation on 64-bit machines, which
4113 caused (substring ...) to crash on large vectors (Bug#8344).
4114 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4115 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4116 All variadic functions and their callers changed accordingly.
4117 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4118 * data.c (arith_driver, float_arith_driver): Likewise.
4119 * editfns.c (general_insert_function): Likewise.
4120 * eval.c (struct backtrace.nargs, interactive_p)
4121 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4122 (funcall_lambda, mark_backtrace): Likewise.
4123 * fns.c (concat): Likewise.
4124 * frame.c (x_set_frame_parameters): Likewise.
4125 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4126 0 if not found, not -1. All callers changed.
4128 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4129 (stack_copy_size): Now size_t, not int.
4130 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4132 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4134 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4135 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4136 All callers changed.
4138 * lisp.h (multibyte_char_to_unibyte):
4139 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4140 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4141 * character.h (CHAR_TO_BYTE8):
4142 * cmds.c (internal_self_insert):
4143 * editfns.c (general_insert_function):
4144 * keymap.c (push_key_description):
4145 * search.c (Freplace_match):
4146 * xdisp.c (message_dolog, set_message_1): All callers changed.
4148 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4150 * keyboard.c (safe_run_hook_funcall): New function.
4151 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4152 don't set the hook to nil, but remove the offending function instead.
4153 (Qcommand_hook_internal): Remove, unused.
4154 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4155 Vcommand_hook_internal.
4157 * eval.c (enum run_hooks_condition): Remove.
4158 (funcall_nil, funcall_not): New functions.
4159 (run_hook_with_args): Call each function through a `funcall' argument.
4160 Remove `cond' argument, now redundant.
4161 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4162 (Frun_hook_with_args_until_failure): Adjust accordingly.
4163 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4165 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4167 * dispextern.h (string_buffer_position): Remove declaration.
4169 * print.c (strout): Remove parameter `multibyte', unused since
4170 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4172 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4173 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4174 All callers changed.
4176 * w32.c (_wsa_errlist): Use braces for struct initializers.
4178 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4179 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4180 All callers changed.
4181 (string_buffer_position): Likewise. Also, make static (it's never
4182 used outside xdisp.c).
4183 (cursor_row_p): Remove parameter `w', unused since
4184 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4185 (decode_mode_spec): Remove parameter `precision', introduced during
4186 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4187 All callers changed.
4189 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4191 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4193 2011-03-27 Anders Lindgren <andlind@gmail.com>
4195 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4196 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4197 (ns_update_auto_hide_menu_bar): New functions.
4198 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4199 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4200 ns_constrain_all_frames.
4201 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4202 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4204 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4206 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4208 2011-03-27 Glenn Morris <rgm@gnu.org>
4210 * syssignal.h: Replace RETSIGTYPE with void.
4211 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4212 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4213 Replace SIGTYPE with void everywhere.
4214 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4215 * s/template.h (SIGTYPE): Remove commented out definition.
4217 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4219 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4220 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4222 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4224 * w32.c (read_unc_volume): Use parameter `henum', instead of
4225 global variable `wget_enum_handle'.
4227 * keymap.c (describe_vector): Remove parameters `indices' and
4228 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4229 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4231 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4233 * keyboard.c (timer_check): Remove parameter `do_it_now',
4234 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4235 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4236 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4238 * keyboard.c (read_char):
4239 * w32menu.c (w32_menu_display_help):
4240 * xmenu.c (show_help_event, menu_help_callback):
4241 Adjust calls to `show_help_echo'.
4243 * gtkutil.c (xg_maybe_add_timer):
4244 * keyboard.c (readable_events):
4245 * process.c (wait_reading_process_output):
4246 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4248 * insdel.c (adjust_markers_gap_motion):
4249 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4250 (gap_left, gap_right): Don't call it.
4252 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4254 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4255 incurred during fontification.
4257 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4259 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4260 (DEFVAR_PER_BUFFER): Don't pass it.
4262 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4263 (scrolling_window): Don't pass it.
4265 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4267 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4269 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4271 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4272 of variables specific to SELinux and computation of `encoded_absname'.
4274 * image.c (XPutPixel): Remove unused variable `height'.
4276 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4278 * unexw32.c (get_section_info): Remove unused variable `section'.
4280 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4281 (system_process_attributes): Remove unused variable `sess'.
4282 (sys_read): Remove unused variable `err'.
4284 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4285 (w32_wnd_proc): Remove unused variable `isdead'.
4286 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4287 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4288 (x_create_tip_frame): Remove unused variable `tem'.
4290 * w32inevt.c (w32_console_read_socket):
4291 Remove unused variable `no_events'.
4293 * w32term.c (x_draw_composite_glyph_string_foreground):
4294 Remove unused variable `width'.
4296 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4298 * w32term.c (x_set_glyph_string_clipping):
4299 Don't pass uninitialized region to CombineRgn.
4301 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4303 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4304 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4305 (Fx_close_connection): Remove unused variable `i'.
4307 * w32font.c (w32font_draw): Return number of glyphs.
4308 (w32font_open_internal): Remove unused variable `i'.
4309 (w32font_driver): Add missing initializer.
4311 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4312 (fill_in_menu): Remove unused variable `items_added'.
4314 * w32term.c (last_mouse_press_frame): Remove static global variable.
4315 (w32_clip_to_row): Remove unused variable `f'.
4316 (x_delete_terminal): Remove unused variable `i'.
4318 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4319 (NOTHING): Remove unused static global variable.
4320 (uniscribe_check_otf): Remove unused variable `table'.
4321 (uniscribe_font_driver): Add missing initializers.
4323 2011-03-23 Julien Danjou <julien@danjou.info>
4325 * term.c (Fsuspend_tty, Fresume_tty):
4326 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4327 * window.c (temp_output_buffer_show):
4328 * insdel.c (signal_before_change):
4329 * frame.c (Fhandle_switch_frame):
4330 * fileio.c (Fdo_auto_save):
4331 * emacs.c (Fkill_emacs):
4332 * editfns.c (save_excursion_restore):
4333 * cmds.c (internal_self_insert):
4334 * callint.c (Fcall_interactively):
4335 * buffer.c (Fkill_all_local_variables):
4336 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4338 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4339 unconditionnaly since it does the check itself.
4341 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4343 Fix more problems found by GCC 4.5.2's static checks.
4345 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4346 the first time through the loop, since we know p0 < p1 then.
4347 This also avoids a gcc -Wstrict-overflow warning.
4349 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4350 leading to a memory leak, possible in functions like
4351 load_charset_map_from_file that can allocate an unbounded number
4352 of objects (Bug#8318).
4354 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4355 that could (at least in theory) be that large.
4357 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4358 This is less likely to overflow, and avoids undefined behavior if
4359 overflow does occur. All callers changed. Use strtoul to scan
4360 for the unsigned long integer.
4361 (pint2hrstr): Simplify and tune code slightly.
4362 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4364 * scroll.c (do_scrolling): Work around GCC bug 48228.
4365 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4367 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4368 This also avoids a warning with gcc -Wstrict-overflow.
4369 (validate_x_resource_name): Simplify count usage.
4370 This also avoids a warning with gcc -Wstrict-overflow.
4372 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4375 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4377 * process.c (Fmake_network_process): Use socklen_t, not int,
4378 where POSIX says socklen_t is required in portable programs.
4379 This fixes a porting bug on hosts like 64-bit HP-UX, where
4380 socklen_t is wider than int (Bug#8277).
4381 (Fmake_network_process, server_accept_connection):
4382 (wait_reading_process_output, read_process_output):
4385 * process.c: Rename or move locals to avoid shadowing.
4386 (list_processes_1, Fmake_network_process):
4387 (read_process_output_error_handler, exec_sentinel_error_handler):
4388 Rename or move locals.
4389 (Fmake_network_process): Define label "retry_connect" only if needed.
4390 (Fnetwork_interface_info): Fix pointer signedness.
4391 (process_send_signal): Add cast to avoid pointer signedness problem.
4392 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4393 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4395 Make tparam.h and terminfo.c consistent.
4396 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4397 Include tparam.h instead, since it declares them.
4398 * cm.h (PC): Remove extern decl; tparam.h now does this.
4399 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4400 * terminfo.c: Include tparam.h, to check interfaces.
4401 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4402 (tparam): Adjust signature to match interface in tparam.h;
4403 this removes some undefined behavior. Check that outstring and len
4404 are zero, which they always are with Emacs.
4405 * tparam.h (PC, BC, UP): New extern decls.
4407 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4408 (xftfont_open): Rename locals to avoid shadowing.
4410 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4411 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4412 (OTF_TAG_SYM): Omit macro if not needed.
4413 (ftfont_list): Remove unused local.
4414 (get_adstyle_property, ftfont_pattern_entity):
4415 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4416 Rename locals to avoid shadowing.
4418 * xfont.c (xfont_list_family): Mark var as initialized.
4420 * xml.c (make_dom): Now static.
4422 * composite.c (composition_compute_stop_pos): Rename local to
4424 (composition_reseat_it): Remove unused locals.
4425 (find_automatic_composition, composition_adjust_point): Likewise.
4426 (composition_update_it): Mark var as initialized.
4427 (find_automatic_composition): Mark vars as initialized,
4428 with a FIXME (Bug#8290).
4430 character.h: Rename locals to avoid shadowing.
4431 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4432 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4433 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4434 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4437 * textprop.c (property_change_between_p): Remove; unused.
4439 * intervals.c (interval_start_pos): Now static.
4441 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4443 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4444 Rename locals to avoid shadowing.
4446 * sound.c (wav_play, au_play, Fplay_sound_internal):
4447 Fix pointer signedness.
4448 (alsa_choose_format): Remove unused local var.
4449 (wav_play): Initialize a variable to 0, to prevent undefined
4450 behavior (Bug#8278).
4452 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4454 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4456 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4457 clobbering (Bug#8298).
4458 * sysdep.c (sys_subshell): Likewise.
4459 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4461 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4462 This should get cleaned up, so that child_setup has the
4463 same signature on all platforms.
4465 * callproc.c (call_process_cleanup): Now static.
4466 (relocate_fd): Rename locals to avoid shadowing.
4468 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4470 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4471 not to be necessary, and produces flickering.
4473 2011-03-20 Glenn Morris <rgm@gnu.org>
4475 * config.in: Remove file.
4477 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4479 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4480 are now in src/globals.h.
4481 (syms_of_minibuf): Remove spurious & from previous change.
4483 2011-03-20 Leo <sdl.web@gmail.com>
4485 * minibuf.c (completing-read-function): New variable.
4486 (completing-read-default): Rename from completing-read.
4487 (completing-read): Call completing-read-function.
4489 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4491 * xfaces.c (Fx_load_color_file):
4492 Read color file from absolute filename (bug#8250).
4494 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4496 * makefile.w32-in: Update dependencies.
4498 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4500 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4502 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4504 Fix more problems found by GCC 4.5.2's static checks.
4506 * process.c (make_serial_process_unwind, send_process_trap):
4507 (sigchld_handler): Now static.
4509 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4510 That way, the code declares only the vars that it needs.
4511 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4512 * s/cygwin.h (PTY_ITERATION): Likewise.
4513 * s/darwin.h (PTY_ITERATION): Likewise.
4514 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4516 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4517 * process.c (allocate_pty): Don't declare stb unless it's needed.
4519 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4520 (CONSTANTLIM): Remove; unused.
4521 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4522 Define only if needed.
4524 * unexelf.c (unexec): Name an expression,
4525 to avoid gcc -Wbad-function-cast warning.
4526 Use a different way to cause a compilation error if anyone uses
4527 n rather than nn, a way that does not involve shadowing.
4528 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4530 * deps.mk (unexalpha.o): Remove; unused.
4532 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4533 * unexec.h: New file.
4534 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4535 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4537 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4538 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4539 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4540 Change as necessary to match prototype in unexec.h.
4542 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4544 (back_comment, skip_chars): Mark vars as initialized.
4546 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4547 Rename locals to avoid shadowing.
4549 * lread.c (read1): Rewrite so as not to use empty "else".
4550 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4552 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4554 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4555 warning when compiling print.c.
4557 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4558 instead of using an uninitialized var.
4559 (font_sort_entities): Mark var as initialized.
4561 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4563 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4564 pointers to constants.
4565 (font_parse_fcname): Remove unused vars.
4566 (font_delete_unmatched): Now static.
4567 (font_get_spec): Remove; unused.
4568 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4569 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4570 Rename or move locals to avoid shadowing.
4572 * fns.c (require_nesting_list, require_unwind): Now static.
4573 (Ffillarray): Rename locals to avoid shadowing.
4575 * floatfns.c (domain_error2): Define only if needed.
4576 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4578 * alloc.c (mark_backtrace): Move decl from here ...
4579 * lisp.h: ... to here, so that it can be checked.
4581 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4582 (Fdefvar): Rewrite so as not to use empty "else".
4583 (lisp_indirect_variable): Name an expression,
4584 to avoid gcc -Wbad-function-cast warning.
4585 (Fdefvar): Rename locals to avoid shadowing.
4587 * callint.c (quotify_arg, quotify_args): Now static.
4588 (Fcall_interactively): Rename locals to avoid shadowing.
4589 Use const pointer when appropriate.
4591 * lisp.h (get_system_name, get_operating_system_release):
4592 Move decls here, to check interfaces.
4593 * process.c (get_operating_system_release): Move decl to lisp.h.
4594 * xrdb.c (get_system_name): Likewise.
4595 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4596 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4597 some of which prompt warnings from gcc -Wbad-function-cast.
4598 (Fformat_time_string, Fencode_time, Finsert_char):
4599 (Ftranslate_region_internal, Fformat):
4600 Rename or remove local vars to avoid shadowing.
4601 (Ftranslate_region_internal): Mark var as initialized.
4603 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4606 * lisp.h (eassert): Check that the argument compiles, even if
4607 ENABLE_CHECKING is not defined.
4609 * data.c (Findirect_variable): Name an expression, to avoid
4610 gcc -Wbad-function-cast warning.
4611 (default_value, arithcompare, arith_driver, arith_error): Now static.
4612 (store_symval_forwarding): Rename local to avoid shadowing.
4613 (Fmake_variable_buffer_local, Fmake_local_variable):
4614 Mark variables as initialized.
4615 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4617 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4618 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4619 Rename locals to avoid shadowing.
4620 (mark_stack): Move local variables into the #ifdef region where
4622 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4623 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4625 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4626 (GC_STRING_CHARS): Remove; not used.
4627 (Fmemory_limit): Cast sbrk's returned value to char *.
4629 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4630 avoids undefined behavior in theory.
4632 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4634 Use functions, not macros, for up- and down-casing (Bug#8254).
4635 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4636 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4637 to use the following functions instead of these macros.
4638 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4639 EMACS_INT, since callers assume the returned value fits in int.
4640 (upcase1): Likewise, for UPCASE_TABLE.
4641 (uppercasep, lowercasep, upcase): New static inline functions.
4642 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4643 the race-condition problem in the old DOWNCASE.
4645 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4646 Rename locals to avoid shadowing.
4647 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4648 (regex_compile, re_search_2, re_match_2_internal):
4649 Remove unused local vars.
4650 (FREE_VAR): Rewrite so as not to use empty "else",
4651 which gcc can warn about.
4652 (regex_compile, re_match_2_internal): Mark locals as initialized.
4653 (RETALLOC_IF): Define only if needed.
4654 (WORDCHAR_P): Likewise. This one is never needed, but is used
4655 only in a comment talking about a compiler bug, so put inside
4656 the #if 0 of that comment.
4657 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4658 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4661 * search.c (boyer_moore): Rename locals to avoid shadowing.
4662 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4663 (PREV_CHAR_BOUNDARY): Likewise.
4665 * search.c (simple_search): Remove unused var.
4667 * dired.c (compile_pattern): Move decl from here ...
4668 * lisp.h: ... to here, so that it can be checked.
4669 (struct re_registers): New forward decl.
4671 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4673 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4675 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4676 Rename locals to avoid shadowing.
4677 (Fvertical_motion): Mark locals as initialized.
4679 * casefiddle.c (casify_object, casify_region): Now static.
4680 (casify_region): Mark local as initialized.
4682 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4684 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4685 New macros, so that the caller can use some names other than
4686 gcpro1, gcpro2, etc.
4687 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4689 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4690 argument, for consistency with GCPRO2_VAR, etc: it is now the
4691 prefix of the variable, not the variable itself. All uses
4693 * dired.c (directory_files_internal, file_name_completion):
4694 Rename locals to avoid shadowing.
4696 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4697 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4698 dired.c's scmp function, had undefined behavior.
4699 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4700 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4701 * buffer.h: ... to here, because these macros use current_buffer,
4702 and the new implementation with inline functions needs to have
4703 current_buffer in scope now, rather than later when the macros
4705 (downcase, upcase1): New static inline functions.
4706 (DOWNCASE, UPCASE1): Reimplement using these functions.
4707 This avoids undefined behavior in expressions like
4708 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4709 from race conditions in accessing the global variables
4710 case_temp1 and case_temp2.
4711 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4712 * lisp.h (case_temp1, case_temp2): Remove their decls.
4713 * character.h (ASCII_CHAR_P): Move from here ...
4714 * lisp.h: ... to here, so that the inline functions mentioned
4717 * dired.c (directory_files_internal_unwind): Now static.
4719 * fileio.c (file_name_as_directory, directory_file_name):
4720 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4722 (file_name_as_directory): Use const pointers when appropriate.
4723 (Fexpand_file_name): Likewise. In particular, newdir might
4724 point at constant storage, so make it a const pointer.
4725 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4726 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4728 (Fset_file_times, Finsert_file_contents, auto_save_error):
4729 Rename locals to avoid shadowing.
4731 * minibuf.c (choose_minibuf_frame_1): Now static.
4732 (Ftry_completion, Fall_completions): Rename or remove locals
4735 * marker.c (bytepos_to_charpos): Remove; unused.
4737 * lisp.h (verify_bytepos, count_markers): New decls,
4738 so that gcc does not warn that these functions aren't declared.
4740 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4741 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4742 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4743 (copy_text): Remove unused local var.
4745 * filelock.c (within_one_second): Now static.
4746 (lock_file_1): Rename local to avoid shadowing.
4748 * buffer.c (fix_overlays_before): Mark locals as initialized.
4749 (fix_start_end_in_overlays): Likewise. This function should be
4750 simplified by using pointers-to-pointers, but that's a different
4752 (switch_to_buffer_1): Now static.
4753 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4754 (report_overlay_modification): Rename locals to avoid shadowing.
4756 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4757 Fix pointer signedness issue.
4758 (sys_subshell): Mark local as volatile if checking for lint,
4759 to suppress a gcc -Wclobbered warning that does not seem to be right.
4760 (MAXPATHLEN): Define only if needed.
4762 * process.c (serial_open, serial_configure): Move decls from here ...
4763 * systty.h: ... to here, so that they can be checked.
4765 * fns.c (get_random, seed_random): Move extern decls from here ...
4766 * lisp.h: ... to here, so that they can be checked.
4768 * sysdep.c (reset_io): Now static.
4769 (wait_for_termination_signal): Remove; unused.
4771 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4772 (copy_keymap_item, append_key, push_text_char_description):
4774 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4775 (DENSE_TABLE_SIZE): Remove; unused.
4776 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4777 (describe_map_tree):
4778 Rename locals to avoid shadowing.
4780 * keyboard.c: Declare functions static if they are not used elsewhere.
4781 (echo_char, echo_dash, cmd_error, top_level_2):
4782 (poll_for_input, handle_async_input): Now static.
4783 (read_char, kbd_buffer_get_event, make_lispy_position):
4784 (make_lispy_event, make_lispy_movement, apply_modifiers):
4785 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4786 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4787 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4788 (read_key_sequence, read_char): Mark locals as initialized.
4789 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4791 * keyboard.h (make_ctrl_char): New decl.
4792 (mark_kboards): Move decl here ...
4793 * alloc.c (mark_kboards): ... from here.
4795 * lisp.h (force_auto_save_soon): New decl.
4797 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4798 (DEFINE_DUMMY_FUNCTION): New macro.
4799 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4801 (main): Add casts to avoid warnings
4802 if GCC considers string literals to be constants.
4804 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4806 * dbusbind.c: Pointer signedness fixes.
4807 (xd_signature, xd_append_arg, xd_initialize):
4808 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4809 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4810 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4811 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4813 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4814 if GCC considers string literals to be constants.
4815 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4817 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4819 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4820 (print_preprocess, print_object): New macro to fix last change.
4822 * print.c (print_preprocess): Don't forget font objects.
4824 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4826 * emacs.c (USAGE3): Doc fixes.
4828 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4830 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4833 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4835 * lisp.h (VWindow_system, Qfile_name_history):
4836 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4837 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4838 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4840 * w32select.c: Don't #include "keyboard.h".
4841 (run_protected): Add extern declaration for waiting_for_input.
4843 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4844 * w32console.c (detect_input_pending, read_input_pending)
4845 (encode_terminal_code):
4846 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4847 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4848 (w32_system_caret_y, Qfile_name_history):
4849 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4850 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4851 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4852 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4853 * w32proc.c (Qlocal, report_file_error):
4854 * w32term.c (Vwindow_system, updating_frame):
4855 * w32uniscribe.c (initialized, uniscribe_font_driver):
4856 Remove unneeded extern declarations.
4858 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4860 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4862 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4864 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4865 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4866 These macros can no longer be used for assignment.
4868 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4869 Assign struct members directly, instead of using BUF_BEGV etc.
4870 (record_buffer_markers, fetch_buffer_markers): New functions for
4871 recording and fetching special buffer markers.
4872 (set_buffer_internal_1, set_buffer_temp): Use them.
4874 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4876 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4878 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4879 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4881 * xdisp.c (hscroll_window_tree):
4882 (reconsider_clip_changes): Use PT instead of BUF_PT.
4884 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4886 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4887 $(EMACS_ROOT)/lib/intprops.h.
4889 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4891 Fix more problems found by GCC 4.5.2's static checks.
4893 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4894 to unsigned char * to avoid compiler diagnostic.
4895 (xg_free_frame_widgets): Make it clear that a local variable is
4896 needed only if USE_GTK_TOOLTIP.
4897 (gdk_window_get_screen): Make it clear that this macro is needed
4898 only if USE_GTK_TOOLTIP.
4899 (int_gtk_range_get_value): New function, which avoids a diagnostic
4900 from gcc -Wbad-function-cast.
4901 (xg_set_toolkit_scroll_bar_thumb): Use it.
4902 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4903 diagnostic from gcc -Wbad-function-cast.
4904 (get_utf8_string, xg_get_file_with_chooser):
4905 Rename locals to avoid shadowing.
4906 (create_dialog): Move locals to avoid shadowing.
4908 * xgselect.c (xg_select): Remove unused var.
4910 * image.c (four_corners_best): Mark locals as initialized.
4911 (gif_load): Initialize transparent_p to zero (Bug#8238).
4912 Mark another local as initialized.
4913 (my_png_error, my_error_exit): Mark with NO_RETURN.
4915 * image.c (clear_image_cache): Now static.
4916 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4917 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4918 (x_edge_detection): Remove unnecessary cast that
4919 gcc -Wbad-function-cast diagnoses.
4920 (gif_load): Fix pointer signedness.
4921 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4922 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4924 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4926 Improve quality of tests for time stamp overflow.
4927 For example, without this patch (encode-time 0 0 0 1 1
4928 1152921504606846976) returns the obviously-bogus value (-948597
4929 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4930 reports time overflow. See
4931 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4932 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4933 * editfns.c: Include limits.h and intprops.h.
4934 (TIME_T_MIN, TIME_T_MAX): New macros.
4935 (time_overflow): Move earlier, to before first use.
4936 (hi_time, lo_time): New functions, for an accurate test for
4938 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4939 (Fget_internal_run_time): Don't assume time_t fits in int.
4940 (make_time): Use list2 instead of Fcons twice.
4941 (Fdecode_time): More accurate test for out-of-range times.
4942 (check_tm_member): New function.
4943 (Fencode_time): Use it, to test for out-of-range times.
4944 (lisp_time_argument): Don't rely on undefined left-shift and
4945 right-shift behavior when checking for time stamp overflow.
4947 * editfns.c (time_overflow): New function, refactoring common code.
4948 (Fformat_time_string, Fdecode_time, Fencode_time):
4949 (Fcurrent_time_string): Use it.
4951 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4952 * dired.c (make_time): Move to ...
4953 * editfns.c (make_time): ... here.
4954 * systime.h: Note the move.
4956 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4958 * fringe.c (update_window_fringes): Remove unused variables.
4960 * unexmacosx.c (copy_data_segment): Also copy __got section.
4963 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4965 * termcap.c [MSDOS]: Include "msdos.h".
4966 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4967 Constify `char *' arguments and their references according to
4968 prototypes in tparam.h.
4970 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4972 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4973 Adapt all references accordingly.
4975 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4977 2011-03-11 Tom Tromey <tromey@redhat.com>
4979 * buffer.c (syms_of_buffer): Remove obsolete comment.
4981 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4983 * termhooks.h (encode_terminal_code): Declare prototype.
4985 * msdos.c (encode_terminal_code): Don't declare prototype.
4987 * term.c (encode_terminal_code): Now external again, used by
4988 w32console.c and msdos.c.
4990 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4991 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4993 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4995 Fix some minor problems found by GCC 4.5.2's static checks.
4997 * fringe.c (update_window_fringes): Mark locals as initialized
4999 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5001 * alloc.c (mark_fringe_data): Move decl from here ...
5002 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5003 to check its interface.
5004 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5006 * fontset.c (free_realized_fontset): Now static.
5007 (Fset_fontset_font): Rename local to avoid shadowing.
5008 (fontset_font): Mark local as initialized.
5009 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5011 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5013 * xselect.c (x_disown_buffer_selections): Remove; not used.
5014 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5015 (x_own_selection, Fx_disown_selection_internal): Rename locals
5017 (x_handle_dnd_message): Remove local to avoid shadowing.
5019 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5020 so that the caller can use some name other than gcpro1.
5021 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5022 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5023 (Fx_backspace_delete_keys_p):
5024 Use them to avoid shadowing, and rename vars to avoid shadowing.
5025 (x_decode_color, x_set_name, x_window): Now static.
5026 (Fx_create_frame): Add braces to silence GCC warning.
5027 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5028 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5029 Remove unused locals.
5030 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5031 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5032 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5035 * xterm.h (x_mouse_leave): New decl.
5037 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5038 Remove unused functions.
5039 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5040 (x_calc_absolute_position): Now static.
5041 (XTread_socket): Don't define label "out" unless it's used.
5042 Don't declare local "event" unless it's used.
5043 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5044 unless they are used.
5045 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5046 (x_fatal_error_signal): Remove; not used.
5047 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5048 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5049 (x_error_catcher, x_connection_closed, x_error_handler):
5050 (x_error_quitter, xembed_send_message, x_iconify_frame):
5051 (my_log_handler): Rename locals to avoid shadowing.
5052 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5053 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5055 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5056 Rename or move locals to avoid shadowing.
5057 (tty_defined_color, merge_face_heights): Now static.
5058 (free_realized_faces_for_fontset): Remove; not used.
5059 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5060 does not deduce is never used uninitialized.
5061 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5062 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5064 * terminal.c (store_terminal_param): Now static.
5066 * xmenu.c (menu_highlight_callback): Now static.
5067 (set_frame_menubar): Remove unused local.
5068 (xmenu_show): Rename parameter to avoid shadowing.
5069 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5070 since they might point to immutable storage.
5071 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5072 since it's unused otherwise.
5074 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5075 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5076 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5077 avoids a gcc -Wuninitialized diagnostic.
5078 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5079 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5080 does not deduce are never used uninitialized.
5082 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5084 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5085 * window.c (window_loop, size_window):
5086 (run_window_configuration_change_hook, enlarge_window): Likewise.
5088 * window.c (display_buffer): Now static.
5089 (size_window): Mark variables that gcc -Wuninitialized
5090 does not deduce are never used uninitialized.
5091 * window.h (check_all_windows): New decl, to forestall
5092 gcc -Wmissing-prototypes diagnostic.
5093 * dispextern.h (bidi_dump_cached_states): Likewise.
5095 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5097 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5099 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5100 and to avoid gcc -Wuninitialized warning.
5101 (load_charset_map): Mark variables that gcc -Wuninitialized
5102 does not deduce are never used uninitialized.
5103 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5105 * coding.c (coding_set_source, coding_set_destination):
5106 Use "else { /* comment */ }" rather than "else /* comment */;"
5107 for clarity, and to avoid gcc -Wempty-body warning.
5108 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5109 a block, when the outer 'i' will do.
5110 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5111 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5112 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5113 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5114 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5115 Rename locals to avoid shadowing.
5116 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5117 * coding.c (emacs_mule_char, encode_invocation_designation):
5118 Now static, since they're not used elsewhere.
5119 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5120 (decode_coding_object, encode_coding_object, detect_coding_system):
5121 (decode_coding_emacs_mule): Mark variables that gcc
5122 -Wuninitialized does not deduce are never used uninitialized.
5123 (detect_coding_iso_2022): Initialize a local variable that might
5124 be used uninitialized. Leave a FIXME because it's not clear that
5125 this initialization is needed. (Bug#8211)
5126 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5127 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5128 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5129 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5130 Remove unused macros.
5132 * category.c (hash_get_category_set): Remove unused local var.
5133 (copy_category_table): Now static, since it's not used elsewhere.
5134 * character.c (string_count_byte8): Likewise.
5136 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5137 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5139 * chartab.c (copy_sub_char_table): Now static, since it's not used
5141 (sub_char_table_ref_and_range, char_table_ref_and_range):
5142 Rename locals to avoid shadowing.
5143 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5145 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5146 (BIDI_BOB): Remove unused macro.
5148 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5149 deduce are never used uninitialized.
5150 * term.c (encode_terminal_code): Likewise.
5152 * term.c (encode_terminal_code): Now static. Remove unused local.
5154 * tparam.h: New file.
5155 * term.c, tparam.h: Include it.
5156 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5157 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5158 Move these decls to tparam.h, and make them agree with what
5159 is actually in tparam.c. The previous trick of using incompatible
5160 decls in different modules does not conform to the C standard.
5161 All callers of tparam changed to use tparam's actual API.
5162 * tparam.c (tparam1, tparam, tgoto):
5163 Use const pointers where appropriate.
5165 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5166 * cm.h (struct cm): Likewise.
5167 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5168 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5169 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5170 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5171 (turn_on_face, init_tty): Likewise.
5172 * termchar.h (struct tty_display_info): Likewise.
5174 * term.c (term_mouse_position): Rename local to avoid shadowing.
5176 * alloc.c (mark_ttys): Move decl from here ...
5177 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5179 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5181 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5183 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5185 * search.c (compile_pattern_1): Remove argument regp, unused since
5186 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5187 (compile_pattern): Don't pass it.
5189 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5191 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5192 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5194 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5196 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5198 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5199 gdk_window_get_screen, gdk_window_get_geometry,
5200 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5201 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5202 (xg_get_pixbuf_from_pixmap): New function.
5203 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5204 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5205 Call xg_get_pixbuf_from_pixmap instead of
5206 gdk_pixbuf_get_from_drawable.
5207 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5208 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5209 (xg_check_special_colors): Use GtkStyleContext and its functions
5211 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5212 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5213 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5214 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5215 Call gtk_widget_get_preferred_size.
5216 (xg_frame_resized): gdk_window_get_geometry only takes 5
5218 (xg_win_to_widget, xg_event_is_for_menubar):
5219 Call gdk_x11_window_lookup_for_display.
5220 (xg_set_widget_bg): New function.
5221 (delete_cb): New function.
5222 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5223 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5224 (xg_set_background_color): Call xg_set_widget_bg.
5225 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5226 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5227 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5228 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5230 (update_frame_tool_bar): Call gtk_widget_hide.
5231 (xg_initialize): Use GDK_KEY_g.
5233 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5235 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5237 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5238 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5239 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5241 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5243 * w32xfns.c (select_palette): Check success of RealizePalette against
5244 GDI_ERROR, not zero.
5246 See ChangeLog.11 for earlier changes.
5252 Copyright (C) 2011 Free Software Foundation, Inc.
5254 This file is part of GNU Emacs.
5256 GNU Emacs is free software: you can redistribute it and/or modify
5257 it under the terms of the GNU General Public License as published by
5258 the Free Software Foundation, either version 3 of the License, or
5259 (at your option) any later version.
5261 GNU Emacs is distributed in the hope that it will be useful,
5262 but WITHOUT ANY WARRANTY; without even the implied warranty of
5263 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5264 GNU General Public License for more details.
5266 You should have received a copy of the GNU General Public License
5267 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.