1 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (display_line): Record maximum and minimum buffer
4 positions even if no glyphs were produced (e.g., by a zero-width
5 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6 buffer positions that will be removed from the glyph row because
8 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
9 column is beyond frame width: don't subtract 1 "pixel" when
10 computing width of the stretch.
12 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
15 and turn window cursor on if cleared (Bug#9415).
17 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
19 * search.c (boyer_moore): Take unibyte characters from pattern
22 2011-09-18 Eli Zaretskii <eliz@gnu.org>
24 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
26 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
28 Fix minor problem found by static checking.
29 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
30 initialized, to pacify gcc -Wuninitialized.
32 * fileio.c: Report proper errno when syscall falls.
33 (Finsert_file_contents): Save and restore errno,
34 so that report_file_error outputs the correct diagnostic.
35 (Fwrite_region) [CLASH_DETECTION]: Likewise.
37 2011-09-18 Eli Zaretskii <eliz@gnu.org>
39 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
41 2011-09-17 Eli Zaretskii <eliz@gnu.org>
43 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
44 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
46 2011-09-17 Eli Zaretskii <eliz@gnu.org>
48 * xdisp.c (reseat_at_next_visible_line_start): Keep information
49 about the current paragraph and restore it after the call to
52 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
53 (bidi_find_paragraph_start): Search back for paragraph beginning
54 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
55 (bidi_move_to_visually_next): Only trigger paragraph-related
56 computations when the last character is a newline or at EOB, not
57 just any NEUTRAL_B. (Bug#9470)
59 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
60 truncated lines if point is covered by a display string. (Bug#9524)
62 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
64 * xselect.c: Relax test for outgoing X longs (Bug#9498).
65 (cons_to_x_long): New function.
66 (lisp_data_to_selection_data): Use it. Correct the test for
67 short-versus-long data; it was negated. Break out of vector
68 loop, for efficiency, when a long datum is discovered.
70 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
72 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
74 2011-09-16 Eli Zaretskii <eliz@gnu.org>
76 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
77 GCC PR/17406) by declaring this function with external scope.
79 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
81 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
82 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
84 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
86 * editfns.c (Fformat): Correctly handle text properties on "%%".
88 2011-09-15 Eli Zaretskii <eliz@gnu.org>
90 * xterm.c (x_draw_composite_glyph_string_foreground):
91 * w32term.c (x_draw_composite_glyph_string_foreground):
92 * term.c (encode_terminal_code):
93 * composite.c (composition_update_it, get_composition_id):
94 * xdisp.c (get_next_display_element)
95 (fill_composite_glyph_string): Add comments about special meaning
96 of TAB characters in a composition.
98 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
100 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
101 This occurs when processing a multibyte format.
102 Problem reported by Wolfgang Jenker.
104 2011-09-15 Johan Bockgård <bojohan@gnu.org>
106 * xdisp.c (try_cursor_movement): Only check for exact match if
107 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
109 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
111 Remove unused external symbols.
112 * dispextern.h (calc_pixel_width_or_height): Remove decl.
113 * xdisp.c (calc_pixel_width_or_height): Now static.
114 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
115 * indent.c (check_display_width):
116 * w32term.c: Fix comment to match code.
117 * xterm.c, xterm.h (x_catching_errors): Remove.
119 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
121 * xselect.c: Use signed conversions more consistently (Bug#9498).
122 (selection_data_to_lisp_data): Assume incoming selection data are
123 signed integers, not unsigned. This is to be consistent with
124 outgoing selection data, which was modified to use signed integers
125 in as part of the fix to Bug#9196 in response to Jan D.'s comment
126 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
127 expects long, not unsigned long.
129 2011-09-14 Eli Zaretskii <eliz@gnu.org>
131 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
132 computation of loop end. Reported by Johan Bockgård
135 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
137 * frame.c (Fother_visible_frames_p): Function deleted.
139 2011-09-12 Eli Zaretskii <eliz@gnu.org>
141 * indent.c (compute_motion): Process display vector front to back
142 rather than the other way around. (Bug#2496)
144 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
146 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
148 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
150 * minibuf.c (Fread_from_minibuffer): Doc fix.
152 2011-09-11 Eli Zaretskii <eliz@gnu.org>
154 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
155 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
157 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
159 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
160 value for non-existent files.
162 2011-09-11 Eli Zaretskii <eliz@gnu.org>
164 * fileio.c (Finsert_file_contents): If the file cannot be opened,
165 set its "size" to -1. This will set the modtime_size field of
166 the corresponding buffer to -1, which is what
167 verify-visited-file-modtime expects for files that do not exist.
170 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
172 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
174 * lisp.h: ... from here. push_key_description is no longer
175 defined in keyboard.c, so its declaration should not be in
176 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
177 logically belongs with push_key_description.
179 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
181 * buffer.h: Include <sys/types.h> instead of <time.h>.
182 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
183 Problem reported by Herbert J. Skuhra.
185 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
187 * xml.c (parse_region): Make the parsing work for
188 non-comment-starting XML files again (bug#9144).
190 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
192 * image.c (gif_load): Fix calculation of bottom and right corner.
195 2011-09-10 Eli Zaretskii <eliz@gnu.org>
197 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
198 redisplay in small windows.
200 2011-09-09 Eli Zaretskii <eliz@gnu.org>
202 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
204 2011-09-08 Martin Rudalics <rudalics@gmx.at>
206 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
207 Operate on live windows only.
209 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
211 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
213 2011-09-07 Eli Zaretskii <eliz@gnu.org>
215 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
216 only under bidi iteration.
218 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
220 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
222 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
224 isnan: Fix porting problem to Solaris 10 with bundled gcc.
225 Without this fix, the command to link temacs failed due to an
226 undefined symbol __builtin_isnan. This is because
227 /usr/include/iso/math_c99.h #defines isnan(x) to
228 __builtin_isnan(x), but the bundled gcc, which identifies itself
229 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
231 * floatfns.c (isnan): #undef, and then #define to a clone of
233 (Fisnan): Always define, since it's always available now.
234 (syms_of_floatfns): Always define isnan at the Lisp level.
236 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
238 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
240 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
242 * fileio.c: Fix bugs with large file offsets (Bug#9428).
243 The previous code assumed that file offsets (off_t values) fit in
244 EMACS_INT variables, which is not true on typical 32-bit hosts.
245 The code messed up by falsely reporting buffer overflow in cases
246 such as (insert-file-contents "big" nil 1 2) into an empty buffer
247 when "big" contains more than 2**29 bytes, even though this
248 inserts just one byte and does not overflow the buffer.
249 (Finsert_file_contents): Store file offsets as off_t
250 values, not as EMACS_INT values. Check for overflow when
251 converting between EMACS_INT and off_t. When checking for
252 buffer overflow or for overlap, take the offsets into account.
253 Don't use EMACS_INT for small values where int suffices.
254 When checking for overlap, fix a typo: ZV was used where
255 ZV_BYTE was intended.
256 (Fwrite_region): Don't assume off_t fits into 'long'.
257 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
259 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
261 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
263 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
265 sprintf-related integer and memory overflow issues (Bug#9412).
267 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
268 (esprintf, exprintf, evxprintf): New functions.
269 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
270 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
271 (modify_event_symbol): Do not assume that the length of
272 name_alist_or_stem is safe to alloca and fits in int.
273 (Fexecute_extended_command): Likewise for function name and binding.
274 (Frecursion_depth): Wrap around reliably on integer overflow.
275 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
276 since some callers pass EMACS_INT values.
277 (Fsingle_key_description): Don't crash if symbol name contains more
278 than MAX_ALLOCA bytes.
279 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
280 (get_minibuffer): Arg is now EMACS_INT, not int.
281 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
282 (esprintf, exprintf, evxprintf): New decls.
283 * window.h (command_loop_level, minibuf_level): Reflect API changes.
285 * dbusbind.c (signature_cat): New function.
286 (xd_signature, Fdbus_register_signal):
287 Do not overrun buffer; instead, report string overflow.
289 * dispnew.c (add_window_display_history): Don't overrun buffer.
290 Truncate instead; this is OK since it's just a log.
292 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
293 even if the time zone offset is outlandishly large.
294 Don't mishandle offset == INT_MIN.
296 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
297 when creating daemon; the previous buffer-overflow check was incorrect.
299 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
300 which has the guts of the old verror function.
302 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
303 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
305 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
306 (font_unparse_xlfd): Don't blindly alloca long strings.
307 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
308 fits in int, when using sprintf. Use single snprintf to count
309 length of string rather than counting it via multiple sprintfs;
310 that's simpler and more reliable.
311 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
312 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
313 sprintf, in case result does not fit in int.
315 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
316 (fontset_from_font): Print it.
318 * frame.c (tty_frame_count): Now printmax_t, not int.
319 (make_terminal_frame, set_term_frame_name): Print it.
320 (x_report_frame_params): In X, window IDs are unsigned long,
321 not signed long, so print them as unsigned.
322 (validate_x_resource_name): Check for implausibly long names,
323 and don't assume name length fits in 'int'.
324 (x_get_resource_string): Don't blindly alloca invocation name;
325 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
328 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
329 (xg_check_special_colors, xg_set_geometry):
330 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
332 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
333 Use esprintf, not sprintf, in case result does not fit in int.
335 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
336 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
337 it as a large positive number.
338 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
339 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
341 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
342 in case result does not fit in int.
344 * print.c (float_to_string): Detect width overflow more reliably.
345 (print_object): Make sprintf buffer a bit bigger, to avoid potential
346 buffer overrun. Don't assume list length fits in 'int'. Treat
347 print length of 0 as 0, not as infinity; to be consistent with other
348 uses of print length in this function. Don't overflow print length
349 index. Don't assume hash table size fits in 'long', or that
350 vectorlike size fits in 'unsigned long'.
352 * process.c (make_process): Use printmax_t, not int, to format
353 process-name gensyms.
355 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
357 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
358 to avoid potential buffer overrun.
360 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
361 if X resource line is longer than 512 bytes.
363 * xfns.c (x_window): Make sprintf buffer a bit bigger
364 to avoid potential buffer overrun.
366 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
368 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
370 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
372 Integer overflow fixes for scrolling, etc.
373 Without these, Emacs silently mishandles large integers sometimes.
374 For example, "C-u 4294967297 M-x recenter" was treated as if
375 it were "C-u 1 M-x recenter" on a typical 64-bit host.
377 * xdisp.c (try_window_id): Check Emacs fixnum range before
380 * window.c (window_scroll_line_based, Frecenter):
381 Check that an Emacs fixnum is in range before assigning it to 'int'.
382 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
383 values converted from Emacs fixnums.
384 (Frecenter): Don't wrap around a line count if it is out of 'int'
385 range; instead, treat it as an extreme value.
386 (Fset_window_configuration, compare_window_configurations):
387 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
389 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
390 that can exceed INT_MAX. Check that EMACS_INT value is in range
391 before assigning it to the (possibly-narrower) index.
392 (match_limit): Don't assume that a fixnum can fit in 'int'.
394 * print.c (print_object): Use ptrdiff_t, not int, for index that can
397 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
398 (Fvertical_motion): Don't wrap around LINES values that don't fit
399 in 'int'. Instead, treat them as extreme values. This is good
400 enough for windows, which can't have more than INT_MAX lines anyway.
402 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
404 * Require libxml/parser.h to avoid compilation warning.
406 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
408 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
409 since this reportedly can destroy thread storage.
411 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
413 * syntax.c (find_defun_start): Update all cache variables if
414 exiting early (Bug#9401).
416 2011-08-30 Eli Zaretskii <eliz@gnu.org>
418 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
420 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
421 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
422 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
424 * term.c (tty_append_glyph): New function.
425 (produce_stretch_glyph): Static function and its prototype deleted.
427 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
430 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
432 * image.c (parse_image_spec): Check for nonnegative, not for positive,
433 when checking :margin (Bug#9390).
434 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
435 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
436 so that the name doesn't mislead. All uses changed.
438 2011-08-28 Johan Bockgård <bojohan@gnu.org>
440 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
443 2011-08-27 Eli Zaretskii <eliz@gnu.org>
445 * xdisp.c (move_it_to): Don't bail out early when reaching
446 position beyond to_charpos, if we are scanning backwards.
447 (move_it_vertically_backward): When DY == 0, make sure we get to
448 the first character in the line after the newline.
450 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
452 * ccl.c: Improve and simplify overflow checking (Bug#9196).
453 (ccl_driver): Do not generate an out-of-range pointer.
454 (Fccl_execute_on_string): Remove unnecessary check for
455 integer overflow, noted by Stefan Monnier in
456 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
457 Remove a FIXME that didn't need fixing.
458 Simplify the newly-introduced buffer reallocation code.
460 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
462 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
464 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
466 Integer and memory overflow issues (Bug#9196).
468 * doc.c (get_doc_string): Rework so that
469 get_doc_string_buffer_size is the actual buffer size, rather than
470 being 1 less than the actual buffer size; this makes xpalloc more
473 * image.c (x_allocate_bitmap_record, cache_image):
474 * xselect.c (Fx_register_dnd_atom):
475 Simplify previous changes by using xpalloc.
477 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
478 since either will do and ptrdiff_t is convenient with xpalloc.
480 * charset.c (charset_table_size)
481 (struct charset_sort_data.priority): Now ptrdiff_t.
482 (charset_compare): Don't overflow if priorities differ greatly.
483 (Fsort_charsets): Don't assume list length fits in int.
484 Check for size-calculation overflow when allocating sort data.
485 (syms_of_charset): Allocate an initial charset table that is
486 just under 64 KiB, to avoid problems with glibc malloc and mmap.
488 * cmds.c (internal_self_insert): Check for size-calculation overflow.
490 * composite.h (struct composition.glyph_len): Now int, not unsigned.
491 The actual value is always <= INT_MAX, and leaving it unsigned made
492 overflow checking harder.
494 * dispextern.h (struct glyph_matrix.rows_allocated)
495 (struct face_cache.size): Now ptrdiff_t, for convenience in use
496 with xpalloc. The values are still always <= INT_MAX.
498 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
500 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
501 (SAFE_NALLOCA): New macro.
503 * region-cache.c (struct boundary.pos, find_cache_boundary)
504 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
505 (set_cache_region, invalidate_region_cache)
506 (revalidate_region_cache, know_region_cache, region_cache_forward)
507 (region_cache_backward, pp_cache):
508 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
509 so that ptrdiff_t * can be passed to xpalloc.
510 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
511 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
512 (pp_cache): Don't assume cache_len fits in int.
513 * region-cache.h: Adjust extern decls to match.
515 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
516 EMACS_INT, since either will do, for xpalloc.
518 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
519 (xnmalloc, xnrealloc, xpalloc): New functions.
521 * bidi.c (bidi_shelve_header_size): New constant.
522 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
523 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
525 * bidi.c (bidi_cache_shrink):
526 * buffer.c (overlays_at, overlays_in, record_overlay_string)
528 Don't update size of array until after memory allocation succeeds,
529 because xmalloc/xrealloc may not return.
530 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
531 now that we have proper integer overflow checking.
532 (record_overlay_string, overlay_strings): Catch overflows when
533 calculating size of overlay_str_buf.
535 * callproc.c (Fcall_process): Check for size overflow when
536 calculating size of args2.
537 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
538 Normally we prefer signed values, but sticking with ptrdiff_t would
539 require adding more-complicated checks.
541 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
542 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
543 Redo buffer-overflow calculations to avoid integer overflow.
544 Add a FIXME comment where memory seems to be over-allocated.
546 * character.c (Fstring): Check for size-calculation overflow.
548 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
549 unnecessary integer overflow. Check for size overflow.
550 (encode_coding_object): Don't update size until xmalloc succeeds.
552 * composite.c (get_composition_id): Check for overflow in glyph
555 Integer and memory overflow fixes for display code.
556 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
557 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
558 (scrolling_window): Check for overflow in size calculations.
559 (line_draw_cost, realloc_glyph_pool, add_row_entry):
560 Don't assume glyph table len fits in int.
561 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
562 (row_table_size): Now ptrdiff_t, not int.
563 (scrolling_window): Avoid overflow in size calculations.
564 Don't update size until allocation succeeds.
565 * fns.c (concat): Check for overflow in size calculations.
566 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
567 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
568 (NEXT_ALMOST_PRIME_LIMIT): New constant.
570 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
571 (get_doc_string): Check for size calculation overflow.
572 Don't update size until allocation succeeds.
573 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
574 EMACS_INT, where ptrdiff_t will do.
575 (Fsubstitute_command_keys): Check for string overflow.
577 * editfns.c (set_time_zone_rule): Don't assume environment length
579 (message_length): Now ptrdiff_t, not int.
580 (Fmessage_box): Don't update size until allocation succeeds.
581 Don't assume message length fits in int.
582 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
584 * emacs.c (main): Do not reallocate argv, since there is a null at
585 the end that can be overwritten, and this way there's no need to
586 worry about size-calculation overflow.
587 (sort_args): Check for size-calculation overflow.
589 * eval.c (init_eval_once, grow_specpdl): Don't update size until
591 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
593 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
594 (x_set_scroll_bar_width, x_figure_window_size):
595 Check for integer overflow.
596 (x_set_alpha): Do not assume XINT fits in int.
598 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
599 This is for the members text_lines, text_cols, total_lines, total_cols,
600 where the system imposes an 'int' limit.
602 * fringe.c (Fdefine_fringe_bitmap):
603 Don't update size until alloc works.
605 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
606 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
608 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
609 Check for size-calculation overflow.
610 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
611 do, as we prefer signed integers.
612 (id_to_widget.max_size, id_to_widget.used)
613 (xg_store_widget_in_map, xg_remove_widget_from_map)
614 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
615 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
616 Use and return ptrdiff_t, not int.
617 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
618 * gtkutil.h: Change prototypes to match the above.
620 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
621 are duplicate now that they've been promoted to lisp.h.
622 (x_allocate_bitmap_record, x_alloc_image_color)
623 (make_image_cache, cache_image, xpm_load):
624 Don't update size until alloc is done.
625 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
627 Check for size calculation overflow.
628 (ct_colors_allocated_max): New constant.
629 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
632 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
633 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
634 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
635 Use ptrdiff_t, not int, to count maps.
636 (read_char_minibuf_menu_prompt): Check for overflow in size
637 calculations. Don't update size until allocation succeeds. Redo
638 calculations to avoid overflow.
639 * keyboard.h: Change prototypes to match the above.
641 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
643 (current_minor_maps): Check for size calculation overflow.
644 * keymap.h: Change prototypes to match the above.
646 * lread.c (read1, init_obarray): Don't update size until alloc done.
648 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
649 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
651 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
652 Now ptrdiff_t, not int.
653 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
654 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
656 * process.c (Fnetwork_interface_list): Check for overflow
659 * region-cache.c (move_cache_gap): Check for size calculation overflow.
661 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
662 overflow. Don't bother calling xmalloc when xrealloc will do.
664 * search.c (Freplace_match): Check for size calculation overflow.
665 (Fset_match_data): Don't assume list lengths fit in 'int'.
667 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
668 for command line length. Do not attempt to address one before the
669 beginning of an array, as that's not portable.
671 * term.c (max_frame_lines): Remove; unused.
672 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
674 (encode_terminal_code, calculate_costs): Check for size
675 calculation overflow.
676 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
677 table lengths and related sizes. Don't update size until alloc
678 done. Redo calculations to avoid overflow.
679 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
681 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
682 subtracting pointers.
683 (gobble_line): Check for overflow more carefully. Don't update size
686 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
687 Don't update size until alloc done.
688 Redo size calculations to avoid overflow.
689 Check for size calculation overflow.
690 (main) [DEBUG]: Fix typo in invoking tparam1.
692 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
693 Use ptrdiff_t, not int, for sizes.
694 (store_mode_line_noprop_char): Don't update size until alloc done.
696 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
697 Use ptrdiff_t, not int, for sizes.
698 (Finternal_make_lisp_face, cache_face):
699 Check for size calculation overflow.
700 (cache_face): Treat size calculation overflows as if they were
701 memory exhaustion (the usual treatment), rather than aborting.
703 * xfns.c (x_encode_text, x_set_name_internal)
704 (Fx_change_window_property): Use ptrdiff_t, not int, to count
705 sizes, since they can exceed INT_MAX in size. Check for size
706 calculation overflow.
708 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
709 (xg_select): Check for size calculation overflow.
710 Don't update size until alloc done.
712 * xrdb.c (get_environ_db): Don't assume path length fits in int,
713 as sprintf is limited to int lengths.
715 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
716 (X_LONG_MIN): New macros.
717 Use them to make the following changes clearer.
718 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
719 This change doesn't affect the value now, but it may help remind
720 future maintainers not to raise the value too much later.
721 (SELECTION_QUANTUM): Remove, replacing with ...
722 (selection_quantum): ... new function, which avoids overflow.
724 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
725 assumption that selection length fits in 'int'.
726 (x_reply_selection_request, x_handle_selection_request)
727 (x_get_window_property, receive_incremental_selection)
728 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
729 (lisp_data_to_selection_data, clean_local_selection_data):
730 Use ptrdiff_t, not int, to record length of selection.
731 (x_reply_selection_request, x_get_window_property)
732 (receive_incremental_selection, x_property_data_to_lisp):
733 Redo calculations to avoid overflow.
734 (x_reply_selection_request): When sending hint, ceiling it at
735 X_LONG_MAX rather than relying on wraparound overflow to send
737 (x_get_window_property, receive_incremental_selection)
738 (lisp_data_to_selection_data, x_property_data_to_lisp):
739 Check for size-calculation overflow.
740 (x_get_window_property, receive_incremental_selection)
741 (lisp_data_to_selection_data, Fx_register_dnd_atom):
742 Don't store size until memory allocation succeeds.
743 (x_get_window_property): Plug memory leak on memory exhaustion.
744 Don't double-block input; malloc is safe here. Don't assume 2**34
745 - 4 fits in unsigned long. Add an xassert to check
746 XGetWindowProperty overflow. Be more careful about overflow
747 calculations, and distinguish size from memory overflow better.
748 (receive_incremental_selection): When tracing, don't assume
749 unsigned int is less than INT_MAX.
750 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
751 harmful) conversions of unsigned short to int.
752 (lisp_data_to_selection_data): Don't assume that integers
753 in the range -65535 through -1 fit in an X unsigned short.
754 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
755 result parameters unless successful. Rely on cons_to_unsigned
756 to report problems with elements; the old code wasn't right anyway.
757 (x_check_property_data): Check for int overflow; we cannot use
758 a wider type due to X limits.
759 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
761 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
763 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
764 (x_term_init): Check for size calculation overflow.
765 (x_color_cells): Don't store size until memory allocation succeeds.
766 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
767 Don't assume alloca size is less than MAX_ALLOCA.
768 (x_term_init): Don't assume length fits in int (sprintf is limited
771 Use ptrdiff_t for composition IDs.
772 * character.c (lisp_string_width):
773 * composite.c (composition_table_size, n_compositions)
774 (get_composition_id, composition_gstring_from_id):
775 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
776 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
777 * window.c (Frecenter):
778 Use ptrdiff_t, not int, for composition IDs.
779 * composite.c (get_composition_id): Check for integer overflow.
780 * composite.h: Adjust prototypes to match the above changes.
782 Use ptrdiff_t for hash table indexes.
783 * category.c (hash_get_category_set):
784 * ccl.c (ccl_driver):
785 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
786 * coding.c (coding_system_charset_list, detect_coding_system):
787 * coding.h (struct coding_system.id):
788 * composite.c (get_composition_id, gstring_lookup_cache):
789 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
790 * image.c (xpm_get_color_table_h):
791 * lisp.h (hash_lookup, hash_put):
792 * minibuf.c (Ftest_completion):
793 Use ptrdiff_t for hash table indexes, not int (which is too
794 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
795 32-bit --with-wide-int hosts).
797 * charset.c (Fdefine_charset_internal): Check for integer overflow.
798 Add a FIXME comment about memory leaks.
799 (syms_of_charset): Don't assume xmalloc returns.
801 Don't assume that stated character widths fit in int.
802 * character.c (Fchar_width, c_string_width, lisp_string_width):
803 * character.h (CHAR_WIDTH):
804 * indent.c (MULTIBYTE_BYTES_WIDTH):
805 Use sanitize_char_width to avoid undefined and/or bad behavior
806 with outlandish widths.
807 * character.h (sanitize_tab_width): Renamed from sanitize_width,
808 now that we have two such functions. All uses changed.
809 (sanitize_char_width): New inline function.
811 Don't assume that tab-width fits in int.
812 * character.h (sanitize_width): New inline function.
813 (SANE_TAB_WIDTH): New macro.
814 (ASCII_CHAR_WIDTH): Use it.
815 * indent.c (sane_tab_width): Remove. All uses replaced by
816 SANE_TAB_WIDTH (current_buffer).
817 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
819 * fileio.c: Integer overflow issues with file modes.
820 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
822 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
823 Remove unreachable code.
824 (read_hex, load_charset_map_from_file): Check for integer overflow.
826 * xterm.c: don't go over XClientMessageEvent limit
827 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
828 (x_send_scroll_bar_event): Likewise. Check that the size does not
829 exceed limits imposed by XClientMessageEvent, as well as the usual
830 ptrdiff_t and size_t limits.
832 * keyboard.c: Overflow, signedness and related fixes.
833 (make_lispy_movement): Use same integer type in forward decl
834 that is used in the definition.
835 (read_key_sequence, keyremap_step):
836 Change bufsize argument back to int, undoing my 2011-03-30 change.
837 We prefer signed types, and int is wide enough here.
838 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
839 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
840 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
841 length, not size_t. Use ptrdiff_t for index, not int.
842 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
843 possibility of integer overflow.
845 Overflow, signedness and related fixes for images.
847 * dispextern.h (struct it.stack[0].u.image.image_id)
848 (struct_it.image_id, struct image.id, struct image_cache.size)
849 (struct image_cache.used, struct image_cache.ref_count):
850 * gtkutil.c (update_frame_tool_bar):
851 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
852 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
853 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
854 * nsmenu.m (update_frame_tool_bar):
855 * xdisp.c (calc_pixel_width_or_height):
856 * xfns.c (image_cache_refcount):
857 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
858 on typical 64-bit hosts.
860 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
861 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
862 Omit unnecessary casts to int.
863 (parse_image_spec): Check that integers fall into 'int' range
864 when the callers expect that.
865 (image_ascent): Redo ascent calculation to avoid int overflow.
866 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
867 (lookup_image): Remove unnecessary tests.
868 (xbm_image_p): Locals are now of int, not EMACS_INT,
869 since parse_image_check makes sure they fit into int.
870 (png_load, gif_load, svg_load_image):
871 Prefer int to unsigned where either will do.
872 (tiff_handler): New function, combining the cores of the
873 old tiff_error_handler and tiff_warning_handler. This
874 function is rewritten to use vsnprintf and thereby avoid
875 stack buffer overflows. It uses only the features of vsnprintf
876 that are common to both POSIX and native Microsoft.
877 (tiff_error_handler, tiff_warning_handler): Use it.
878 (tiff_load, gif_load, imagemagick_load_image):
879 Don't assume :index value fits in 'int'.
880 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
881 (imagemagick_load_image): Check that crop parameters fit into
882 the integer types that MagickCropImage accepts. Don't assume
883 Vimagemagick_render_type has a nonnegative value. Don't assume
884 size_t fits in 'long'.
885 (gs_load): Use printmax_t to print the widest integers possible.
886 Check for integer overflow when computing image height and width.
888 2011-08-26 Eli Zaretskii <eliz@gnu.org>
890 * xdisp.c (redisplay_window): Don't force window start if point
891 will be invisible in the resulting window. (Bug#9324)
893 2011-08-25 Eli Zaretskii <eliz@gnu.org>
895 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
896 the display spec is of the form `(space ...)'.
897 (handle_display_spec): Return the value returned by
898 handle_single_display_spec, not just 1 or zero.
899 (handle_single_display_spec): If the display spec is of the form
900 `(space ...)', and specifies display in the text area, return 2
902 (try_cursor_movement): Check for the need to scroll more
903 accurately, and prefer exact match for point under bidi. Don't
904 advance `row' beyond the last row of the window.
906 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
907 into disp_prop; all users changed.
909 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
910 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
911 for the text covered by the display property.
913 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
915 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
916 Change return value to nil.
917 (Frecord_buffer): Delete unused function.
919 2011-08-24 Eli Zaretskii <eliz@gnu.org>
921 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
922 buffers, return left-to-right.
923 (set_cursor_from_row): Consider candidate row a win if its glyph
924 represents a newline and point is on that newline. Fixes cursor
925 positioning on the newline at EOL of R2L text within L2R
926 paragraph, and vice versa.
927 (try_cursor_movement): Check continued rows, in addition to
928 continuation rows. Fixes unwarranted scroll when point enters a
929 continued line of R2L text within an L2R paragraph, or vice versa.
930 (cursor_row_p): Consider the case of point being equal to
931 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
932 from the end of a short line to the beginning of a continued line
933 of R2L text within L2R paragraph.
934 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
937 * bidi.c (bidi_check_type): Use xassert.
938 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
941 2011-08-23 Eli Zaretskii <eliz@gnu.org>
943 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
946 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
948 * nsfont.m (ns_otf_to_script): Fix typo.
950 2011-08-22 Kenichi Handa <handa@m17n.org>
952 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
953 extra slot even if the purpose is char-code-property-table.
955 2011-08-23 Eli Zaretskii <eliz@gnu.org>
957 * xdisp.c (redisplay_window): When computing centering_position,
958 account for the height of the header line. (Bug#8874)
960 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
961 instead of CHAR_TO_BYTE. Fixes a crash when a completion
962 candidate is selected by the mouse, and that candidate has a
963 composed character under the mouse.
965 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
966 coordinates reported by pos-visible-in-window-p for a composed
967 character in column zero.
969 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
971 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
973 2011-08-22 Eli Zaretskii <eliz@gnu.org>
975 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
976 consider it a hit if to_charpos is anywhere in the range of the
977 composed buffer positions.
979 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
981 * image.c (gif_load): Don't assume that each subimage has the same
982 dimensions as the base image. Handle disposal method that is
983 "undefined" by the gif spec (Bug#9335).
985 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
987 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
988 (Fcondition_case): Document `debug' symbol in error handler.
990 2011-08-19 Eli Zaretskii <eliz@gnu.org>
992 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
993 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
994 from an Org mode buffer to a Speedbar frame.
996 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
997 a composition, take its buffer position from IT->cmp_it.charpos.
998 Fixes cursor positioning at the beginning of a line that begins
999 with a composed character.
1001 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1003 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1004 character bidirectional type, use STRONG_L instead. Fixes crashes
1005 in a buffer produced by `describe-categories'.
1007 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1008 members before the level stack, so they would be saved and
1009 restored when copying iterator state. Fixes incorrect reordering
1010 around TABs covered by display properties.
1012 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1014 * process.c (Fnetwork_interface_list): Correctly determine buffer
1017 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1019 * eval.c (internal_condition_case, internal_condition_case_1)
1020 (internal_condition_case_2, internal_condition_case_n):
1021 Remove unnecessary aborts (Bug#9081).
1023 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1025 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1026 has no `load' handler, try opening the file locally. (Bug#9311)
1028 2011-08-16 Ken Brown <kbrown@cornell.edu>
1030 * gmalloc.c: Expand comment.
1032 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1034 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1035 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1037 2011-08-16 Ken Brown <kbrown@cornell.edu>
1039 Fix memory allocation problems in Cygwin build (Bug#9273).
1041 * unexcw.c ( __malloc_initialized): Declare external variable.
1042 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1044 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1046 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1048 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1050 [CYGWIN] (special_realloc): New function.
1051 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1052 requests to realloc storage in the static heap.
1054 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1056 * bidi.c (bidi_initialize): Remove unused local.
1058 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1060 * biditype.h: File removed.
1062 * bidimirror.h: File removed.
1064 * deps.mk (bidi.o): Remove biditype.h and
1067 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1070 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1072 * chartab.c: Improve commentary for the uniprop_table API.
1074 * bidi.c (bidi_paragraph_init): Support zero value of
1075 bidi_ignore_explicit_marks_for_paragraph_level.
1076 (bidi_initialize): Use uniprop_table instead of including
1077 biditype.h and bidimirror.h.
1079 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1080 coordinates of the iterator when restoring from ppos_it.
1083 2011-08-14 Kenichi Handa <handa@m17n.org>
1085 * process.c (create_process): Call setup_process_coding_systems
1086 after the pid of the process is set to -1 (Bug#8162).
1088 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1090 * xdisp.c (move_it_in_display_line_to): Don't invoke
1091 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1092 ppos_it. Fixes vertical cursor motion when line beginning is
1093 covered by an image. (Bug#9296)
1095 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1097 * nsterm.h (ns_run_ascript): Declare.
1098 (NSAPP_DATA2_RUNASSCRIPT): Define.
1100 * nsfns.m (as_script, as_result, as_status): New static variables.
1101 (ns_run_ascript): New function.
1102 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1103 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1104 the event loop. Get status from as_status (Bug#7276).
1106 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1107 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1108 the event loop (Bug#7276).
1110 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1112 * gnutls.c (QCgnutls_bootprop_priority)
1113 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1114 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1115 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1116 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1117 (QCgnutls_bootprop_verify_hostname_error)
1118 (QCgnutls_bootprop_callbacks_verify): Rename from
1119 Qgnutls_bootprop_..., all uses changed.
1121 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1124 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1126 * xfaces.c (Qframe_set_background_mode): Now static.
1127 * dispextern.h (Qframe_set_background_mode): Remove decl.
1129 * process.c (Fnetwork_interface_info): Declare local only if needed.
1131 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1133 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1134 (Fnetwork_interface_list): Allocate in increments of bytes instead
1135 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1136 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1138 (struct ifflag_def): notrailers is smart on OSX.
1139 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1140 Get hardware address with getifaddrs if available.
1142 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1144 * xdisp.c (iterate_out_of_display_property): xassert that
1145 IT->position is set to within IT->object's boundaries. Break from
1146 the loop as soon as EOB is reached; avoids infloops in redisplay
1147 when IT->position is set up wrongly due to some bug.
1148 Set IT->current to match the bidi iterator unconditionally.
1149 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1150 entry. Force push_it to save on the stack the current
1151 buffer/string position, to be restored by pop_it. Fix flags in
1152 the iterator structure wrt the object coming from a display
1153 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1154 properties. (Bug#9284)
1156 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1158 * fontset.c (fontset_get_font_group): Add proper type checks.
1161 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1163 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1164 and LC_VERSION_MIN_MACOSX.
1165 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1166 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1168 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1170 * xdisp.c (forward_to_next_line_start): Allow to use the
1171 no-display-properties-and-no-overlays under bidi display.
1172 Set disp_pos in the bidi iterator to avoid searches for display
1173 properties and overlays.
1175 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1177 * editfns.c (Fset_time_zone_rule): Document relationship with the
1180 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1181 the font entity extracted from the cache (Bug#8109).
1183 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1185 * composite.c (autocmp_chars): Don't reset point. That is done by
1186 restore_point_unwind (Bug#5984).
1188 2011-08-07 Juri Linkov <juri@jurta.org>
1190 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1191 to show the arg `TIME' instead of `TIMEVAL'.
1193 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1195 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1196 display property strides EOL and includes a newline, as in
1197 longlines-mode. (Bug#9254)
1198 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1199 word-wrap under bidirectional display. (Bug#9224)
1201 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1202 is non-zero, even if the data buffer is NULL. Fixes a crash in
1203 vertical-motion with longlines-mode. (Bug#9254)
1205 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1207 * bidi.c <bidi_cache_total_alloc>: Now static.
1208 (bidi_initialize): Initialize bidi_cache_total_alloc.
1210 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1213 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1214 amount allocated this far in `bidi_cache_total_alloc'.
1215 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1216 non-zero, only free the data buffer without restoring the cache
1217 contents. All callers changed.
1219 * dispextern.h (bidi_unshelve_cache): Update prototype.
1221 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1222 (move_it_in_display_line, move_it_to)
1223 (move_it_vertically_backward, move_it_by_lines): Replace the call
1224 to xfree to an equivalent call to bidi_unshelve_cache.
1225 (move_it_in_display_line_to): Fix logic of returning
1226 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1228 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1230 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1231 came from a string character with a `cursor' property. (Bug#9229)
1233 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1235 * Makefile.in (LIB_PTHREAD): New variable.
1236 (LIBES): Add LIB_PTHREAD (Bug#9216).
1238 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1239 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1241 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1243 * regex.c (re_iswctype): Remove some redundant boolean
1246 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1248 * xterm.c (x_find_topmost_parent): New function.
1249 (x_set_frame_alpha): Find topmost parent window with
1250 x_find_topmost_parent and set the property there also (bug#9181).
1251 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1253 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1255 * callproc.c (Fcall_process): Avoid vfork clobbering
1256 the local vars buffer, coding_systems, current_dir.
1258 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1260 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1262 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1264 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1265 so that it is not optimized away.
1267 * xdisp.c (compute_display_string_pos): Remove unused local.
1269 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1271 Fix slow cursor motion and scrolling in large buffers with
1272 selective display, like Org Mode buffers. (Bug#9218)
1274 * dispextern.h (struct bidi_it): New member disp_prop_p.
1276 * xdisp.c: Remove one-slot cache of display string positions.
1277 (compute_display_string_pos): Accept an additional argument
1278 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1279 for a display string or property. If found, set DISP_PROP_P
1282 * bidi.c (bidi_fetch_char): Accept an additional argument
1283 DISP_PROP_P, and pass it to compute_display_string_pos.
1284 Only handle text covered by a display string if DISP_PROP_P is returned
1285 non-zero. All callers of bidi_fetch_char changed.
1287 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1289 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1291 2010-12-03 Don March <don@ohspite.net>
1293 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1294 last character M-[char] is translated to ESC [char] (bug#7541).
1296 2011-08-02 Kenichi Handa <handa@m17n.org>
1298 * lisp.h (uniprop_table): Extern it.
1300 * chartab.c (uniprop_table): Make it non-static.
1302 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1304 * xdisp.c (forward_to_next_line_start): Accept additional argument
1305 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1307 (reseat_at_next_visible_line_start): Use the bidi iterator state
1308 returned by forward_to_next_line_start to restore the state of
1309 it->bidi_it after backing up to previous newline. (Bug#9212)
1311 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1313 * regex.c (re_comp): Protoize.
1314 (re_exec): Fix return type.
1315 (regexec): Fix type of `ret'. (Bug#9203)
1317 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1319 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1320 This is needed if max-image-size is a floating-point number.
1322 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1324 * print.c (print_object): Print empty symbol as ##.
1326 * lread.c (read1): Read ## as empty symbol.
1328 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1330 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1331 setting frame foreground color (Bug#9175).
1332 (x_set_background_color): Likewise.
1334 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1335 contents (Bug#9176).
1336 (EmacsTooltip -init): Remove bezels and add shadows to
1339 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1340 or scroll bar (Bug#8470).
1342 * nsfont.m (nsfont_open): Remove assignment to voffset and
1343 unnecessary vars hshink, expand, hd, full_height, min_height.
1344 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1346 * nsterm.h (nsfont_info): Remove voffset field.
1348 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1350 Implement strike-through and overline on NextStep (Bug#8863).
1352 * nsfont.m (nsfont_open): Use underline position provided by font,
1353 instead of hard-coded value of 2.
1354 (nsfont_draw): Call ns_draw_text_decoration instead.
1356 * nsterm.h: Add declaration for ns_draw_text_decoration.
1358 * nsterm.m (ns_draw_text_decoration): New function for drawing
1359 underline, overline, and strike-through.
1360 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1361 ns_draw_text_decoration. Change treatment of cursor drawing to
1362 accommodate underlining, etc.
1364 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1366 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1369 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1371 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1372 Without this fix, if a signal arrives just after memory fills up,
1373 'malloc' might be invoked reentrantly.
1375 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1376 In other words, assume that every image size is allowed, on non-X
1377 hosts. This assumption is probably wrong, but it lets Emacs compile.
1379 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1381 * regex.c (re_iswctype): Convert return values to boolean.
1383 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1385 * xdisp.c (compute_display_string_pos): Don't use cached display
1386 string position if the buffer had its restriction changed.
1389 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1391 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1393 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1395 Integer signedness and overflow and related fixes. (Bug#9079)
1397 * bidi.c: Integer size and overflow fixes.
1398 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1399 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1400 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1401 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1402 (bidi_find_other_level_edge):
1403 Use ptrdiff_t instead of EMACS_INT where either will do.
1404 This works better on 32-bit hosts configured --with-wide-int.
1405 (bidi_cache_ensure_space): Check for size-calculation overflow.
1406 Use % rather than repeated addition, for better worst-case speed.
1407 Don't set bidi_cache_size until after xrealloc returns, because it
1409 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1410 (bidi_cache_ensure_space): Also check that the bidi cache size
1411 does not exceed that of the largest Lisp string or buffer. See Eli
1412 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1414 * alloc.c (__malloc_size_t): Remove.
1415 All uses replaced by size_t. See Andreas Schwab's note
1416 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1418 * image.c: Improve checking for integer overflow.
1419 (check_image_size): Assume that f is nonnull, since
1420 it is always nonnull in practice. This is one less thing to
1421 worry about when checking for integer overflow later.
1422 (x_check_image_size): New function, which checks for integer
1423 overflow issues inside X.
1424 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1425 This removes the need for a memory_full check.
1426 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1427 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1428 (xbm_read_bitmap_data): Change locals back to 'int', since
1429 their values must fit in 'int'.
1430 (xpm_load_image, png_load, tiff_load):
1431 Invoke x_create_x_image_and_pixmap earlier,
1432 to avoid much needless work if the image is too large.
1433 (tiff_load): Treat overly large images as if
1434 x_create_x_image_and_pixmap failed, not as malloc failures.
1435 (gs_load): Use x_check_image_size.
1437 * gtkutil.c: Omit integer casts.
1438 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1439 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1441 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1443 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1444 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1445 would wrongly return t on a 64-bit host.
1447 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1448 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1449 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1450 and therefore cause GCC to emit a bogus diagnostic in some cases.
1452 * image.c: Integer signedness and overflow and related fixes.
1453 This is not an exhaustive set of fixes, but it's time to
1454 record what I've got.
1455 (lookup_pixel_color, check_image_size): Remove redundant decls.
1456 (check_image_size): Don't assume that arbitrary EMACS_INT values
1457 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1458 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1459 (tiff_load, imagemagick_load_image):
1460 Check for overflow in size calculations.
1461 (x_create_x_image_and_pixmap): Remove unnecessary test for
1462 xmalloc returning NULL; that can't happen.
1463 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1464 (xpm_color_bucket): Use better integer hashing function.
1465 (xpm_cache_color): Don't possibly over-allocate memory.
1466 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1467 (gif_memory_source):
1468 Use ptrdiff_t, not int or size_t, to record sizes.
1469 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1470 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1471 either works, as we prefer signed integers.
1472 (tiff_read_from_memory, tiff_write_from_memory):
1473 Return tsize_t, not size_t, since that's what the TIFF API wants.
1474 (tiff_read_from_memory): Don't fail simply because the read would
1475 go past EOF; instead, return a short read.
1476 (tiff_load): Omit no-longer-needed casts.
1477 (Fimagemagick_types): Don't assume size fits into 'int'.
1479 Improve hashing quality when configured --with-wide-int.
1480 * fns.c (hash_string): New function, taken from sxhash_string.
1481 Do not discard information about ASCII character case; this
1482 discarding is no longer needed.
1483 (sxhash-string): Use it. Change sig to match it. Caller changed.
1484 * lisp.h: Declare it.
1485 * lread.c (hash_string): Remove, since we now use fns.c's version.
1486 The fns.c version returns a wider integer if --with-wide-int is
1487 specified, so this should help the quality of the hashing a bit.
1489 * emacs.c: Integer overflow minor fix.
1490 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1491 Define only if GNU_LINUX.
1492 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1494 * dispnew.c: Integer signedness and overflow fixes.
1495 Remove unnecessary forward decls, that were a maintenance hassle.
1496 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1498 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1499 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1500 (prepare_desired_row, line_draw_cost):
1501 Use int, not unsigned, where either works.
1502 (save_current_matrix, restore_current_matrix):
1503 Use ptrdiff_t, not size_t, where either works.
1504 (init_display): Check for overflow more accurately, and without
1505 relying on undefined behavior.
1507 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1508 Remove, replacing with the new symbols in lisp.h. All uses changed.
1509 * fileio.c (make_temp_name):
1510 * filelock.c (lock_file_1, lock_file):
1511 * xdisp.c (message_dolog):
1512 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1513 Use pMd etc. instead.
1514 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1515 replacing the pWIDE etc. symbols removed from editfns.c.
1517 * keyboard.h (num_input_events): Now uintmax_t.
1518 This is (very slightly) less likely to mess up due to wraparound.
1521 * buffer.c: Integer signedness fixes.
1522 (alloc_buffer_text, enlarge_buffer_text):
1523 Use ptrdiff_t rather than size_t when either will do, as we prefer
1526 * alloc.c: Integer signedness and overflow fixes.
1527 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1528 (__malloc_size_t): Default to size_t, not to int.
1529 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1530 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1531 Prefer ptrdiff_t to size_t when either would do, as we prefer
1533 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1534 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1535 Now const. Initialize with values that are in range even if char
1537 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1538 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1539 These functions do the right thing with sizes > 2**32.
1540 (check_depth): Now ptrdiff_t, not int.
1541 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1542 Adjust to new way of storing sizes. Check for size overflow bugs
1544 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1545 slightly wrong anyway, as it missed one instance of
1546 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1547 (refill_memory_reserve): Omit needless cast to size_t.
1548 (mark_object_loop_halt): Mark as externally visible.
1550 * xselect.c: Integer signedness and overflow fixes.
1551 (Fx_register_dnd_atom, x_handle_dnd_message):
1552 Use ptrdiff_t, not size_t, since we prefer signed.
1553 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1554 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1555 x_dnd_atoms_size and x_dnd_atoms_length.
1557 * doprnt.c: Prefer signed to unsigned when either works.
1559 * doprnt.c (doprnt):
1561 * xdisp.c (vmessage):
1562 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1563 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1564 prefer signed arithmetic to avoid comparison confusion.
1565 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1566 but is a bit tricky.
1568 Assume freestanding C89 headers, string.h, stdlib.h.
1569 * data.c, doprnt.c, floatfns.c, print.c:
1570 Include float.h unconditionally.
1571 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1572 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1573 * regex.c: Likewise for stddef.h, string.h.
1574 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1575 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1576 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1577 (STDC_HEADERS): Remove obsolete defines.
1578 * sysdep.c: Include limits.h unconditionally.
1580 Assume support for memcmp, memcpy, memmove, memset.
1581 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1582 * regex.c (memcmp, memcpy):
1583 Remove; we assume C89 now.
1585 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1586 (__malloc_safe_bcopy): Remove; no longer needed.
1588 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1589 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1590 well either way, and we prefer signed to unsigned.
1592 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1594 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1595 closes the connection while we're reading (bug#9182).
1597 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1599 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1600 are specified (Bug#9168).
1602 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1604 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1605 Found by GCC static checking and --with-wide-int on a 32-bit host.
1607 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1609 * xdisp.c (compute_display_string_pos): Fix logic of caching
1610 previous display string position. Initialize cached_prev_pos to
1611 -1. Fixes slow-down at the beginning of a buffer.
1613 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1615 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1616 for attrs[LFACE_FONTSET_INDEX].
1618 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1620 * xml.c (parse_region): Remove unused local
1621 that was recently introduced.
1623 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1625 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1626 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1628 * xdisp.c (move_it_in_display_line_to): Record the best matching
1629 position for TO_CHARPOS while scanning the line, and restore it on
1630 exit if none of the characters scanned was an exact match.
1631 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1632 when exact match is impossible due to invisible text, and the
1633 lines are truncated.
1635 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1637 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1640 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1642 Fix a significant slow-down of cursor motion with C-n, C-p,
1643 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1644 auto-repeat under bidi redisplay in fontified buffers.
1645 * xdisp.c (compute_stop_pos_backwards): New function.
1646 (next_element_from_buffer): Call compute_stop_pos_backwards to
1647 find a suitable prev_stop when we find ourselves before
1649 (reseat): Don't look for prev_stop, as that could mean a very long
1651 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1652 <cached_disp_overlay_modiff>: Cache for last found display string
1654 (compute_display_string_pos): Return the cached position if asked
1655 about the same buffer in the same area of character positions, and
1656 the buffer wasn't changed since the time the display string
1657 position was cached.
1659 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1661 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1662 is an integer, which is important for empty lines. (Bug#9149)
1664 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1666 * frame.c (Fmodify_frame_parameters): In tty case, update the
1667 default face if necessary (Bug#4238).
1669 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1671 * editfns.c (Fstring_to_char): No need to explain what a character
1672 is in the docstring (Bug#6576).
1674 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1676 * xml.c (parse_region): Make sure we always return a tree.
1678 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1680 * xml.c (parse_region): If a document contains only comments,
1683 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1685 * xml.c (make_dom): Return comments, too.
1687 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1690 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1691 and the surrounding thread.
1692 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1693 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1694 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1696 * s/openbsd.h (BROKEN_SIGIO): Define.
1697 * unexelf.c (unexec) [__OpenBSD__]:
1698 Don't update the .mdebug section of the Alpha COFF symbol table.
1700 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1702 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1705 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1707 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1708 This fixes some race conditions on the permissions of any newly
1711 * alloc.c (valid_pointer_p): Use pipe, not open.
1712 This fixes some permissions issues when debugging.
1714 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1715 If fchown fails to set both uid and gid, try to set just gid,
1716 as that is sometimes allowed. Adjust the file's mode to eliminate
1717 setuid or setgid bits that are inappropriate if fchown fails.
1719 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1721 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1722 to compare Lisp_Objects.
1723 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1724 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1725 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1727 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1729 * lread.c (read_integer): Unread even EOF character.
1730 (read1): Likewise. Properly record start position of symbol.
1732 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1733 symbol character follows.
1735 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1737 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1738 This works around a problem with the previous change to Fcopy_file.
1739 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1740 and without this change, GCC might complain about discarding
1741 fchown's return value.
1743 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1745 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1747 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1749 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1751 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1753 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1754 it's used from the C level.
1756 * process.c: Use the same condition for POLL_FOR_INPUT in both
1757 keyboard.c and process.c (bug#1858).
1759 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1761 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1762 (Fgnutls_boot): Use it.
1764 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1766 * doc.c (Fsubstitute_command_keys): Revert last change.
1768 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1770 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1771 quotes the next character, and doesn't affect other longer
1772 sequences (bug#8935).
1774 * lread.c (syms_of_lread): Clarify that is isn't only
1775 `eval-buffer' and `eval-defun' that's affected by
1776 `lexical-binding' (bug#8460).
1778 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1780 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1781 bidi redisplay when a line includes both an image and is
1784 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1786 Fix minor problems found by static checking.
1787 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1788 (elsz): Now a signed constant, not a size_t var. We prefer signed
1789 types to unsigned, to avoid integer comparison confusion. Without
1790 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1791 "cannot optimize loop, the loop counter may overflow", a symptom
1793 * indent.c (Fvertical_motion): Mark locals as initialized.
1794 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1796 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1798 * search.c (Fre_search_backward): Mention `case-fold-search' in
1799 all the re_search_* functions (bug#8138).
1801 * keyboard.c (Fopen_dribble_file): Document when the file is
1804 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1806 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1809 Support bidi reordering of display and overlay strings.
1810 * xdisp.c (compute_display_string_pos)
1811 (compute_display_string_end): Accept additional argument STRING.
1812 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1813 (reseat_to_string): Initialize bidi_it->string.s and
1814 bidi_it->string.schars.
1815 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1816 NULL (avoids a crash in bidi_paragraph_init).
1817 Initialize itb.string.lstring.
1818 (init_iterator): Call bidi_init_it only of a valid
1819 buffer position was specified. Initialize paragraph_embedding to
1821 (reseat_to_string): Initialize the bidi iterator.
1822 (display_string): If we need to ignore text properties of
1823 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1824 original value of -1 will not work with bidi.)
1825 (compute_display_string_pos): First arg is now struct
1826 `text_pos *'; all callers changed. Support display properties on
1828 (compute_display_string_end): Support display properties on Lisp
1830 (init_iterator, reseat_1, reseat_to_string): Initialize the
1831 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1832 when iterating on a string not from display properties).
1833 (compute_display_string_pos, compute_display_string_end):
1834 Fix calculation of the object to scan. Fixes an error when using
1836 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1837 base_level_stop; instead, set base_level_stop to BEGV.
1838 Fixes crashes in vertical-motion.
1839 (next_element_from_buffer): Improve commentary for when
1840 the iterator is before prev_stop.
1841 (init_iterator): Initialize bidi_p from the default value of
1842 bidi-display-reordering, not from buffer-local value. Use the
1843 buffer-local value only if initializing for buffer iteration.
1844 (handle_invisible_prop): Support invisible properties on strings
1845 that are being bidi-reordered.
1846 (set_iterator_to_next): Support bidi reordering of C strings and
1848 (next_element_from_string): Support bidi reordering of Lisp
1850 (handle_stop_backwards): Support Lisp strings as well.
1851 (display_string): Support display of R2L glyph rows.
1852 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1853 (init_iterator): Don't initialize it->bidi_p for strings
1855 (reseat_to_string): Initialize it->bidi_p for strings here.
1856 (next_element_from_string, next_element_from_c_string)
1857 (next_element_from_buffer): Add xassert's for correspondence
1858 between IT's object being iterated and it->bidi_it.string
1860 (face_before_or_after_it_pos): Support bidi iteration.
1861 (next_element_from_c_string): Handle the case of the first string
1862 character that is not the first one in the visual order.
1863 (get_visually_first_element): New function, refactored from common
1864 parts of next_element_from_buffer, next_element_from_string, and
1865 next_element_from_c_string.
1866 (tool_bar_lines_needed, redisplay_tool_bar)
1867 (display_menu_bar): Force left-to-right direction. Add a FIXME
1868 comment for making that be controlled by a user option.
1869 (push_it, pop_it): Save and restore the state of the
1870 bidi iterator. Save and restore the bidi_p flag.
1871 (pop_it): Iterate out of display property for string iteration as
1873 (iterate_out_of_display_property): Support iteration over strings.
1874 (handle_single_display_spec): Set up it->bidi_it for iteration
1875 over a display string, and call bidi_init_it.
1876 (handle_single_display_spec, next_overlay_string)
1877 (get_overlay_strings_1, push_display_prop): Set up the bidi
1878 iterator for displaying display or overlay strings.
1879 (forward_to_next_line_start): Don't use the shortcut if
1881 (back_to_previous_visible_line_start): If handle_display_prop
1882 pushed the iterator stack, restore the internal state of the bidi
1883 iterator by calling bidi_pop_it same number of times.
1884 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1885 and we are bidi-iterating, don't decrement the iterator position;
1886 instead, set the first_elt flag in the bidi iterator, to produce
1888 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1889 (push_display_prop): xassert that we are iterating a buffer.
1890 (push_it, pop_it): Save and restore paragraph_embedding member.
1891 (handle_single_display_spec, next_overlay_string)
1892 (get_overlay_strings_1, reseat_1, reseat_to_string)
1893 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1894 correctly. Don't assume unibyte strings are not bidi-reordered.
1895 (compute_display_string_pos)
1896 (compute_display_string_end): Fix handling the case of C string.
1897 (push_it, pop_it): Save and restore from_disp_prop_p.
1898 (handle_single_display_spec, push_display_prop): Set the
1899 from_disp_prop_p flag.
1900 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1901 (pop_it): Call iterate_out_of_display_property only if we are
1902 popping after iteration over a string that came from a display
1903 property. Fix a typo in popping stretch info. Add an assertion
1904 for verifying that the iterator position is in sync with the bidi
1906 (handle_single_display_spec, get_overlay_strings_1)
1907 (push_display_prop): Fix initialization of paragraph direction for
1908 string when that of the parent object is not yet determined.
1909 (reseat_1): Call bidi_init_it to resync the bidi
1910 iterator with IT's position. (Bug#7616)
1911 (find_row_edges): If ROW->start.pos gives position
1912 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1913 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1914 Reset the from_disp_prop_p flag.
1915 (SAVE_IT, RESTORE_IT): New macros.
1916 (pos_visible_p, face_before_or_after_it_pos)
1917 (back_to_previous_visible_line_start)
1918 (move_it_in_display_line_to, move_it_in_display_line)
1919 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1920 (try_scrolling, redisplay_window, display_line): Use them when
1921 saving a temporary copy of the iterator and restoring it back.
1922 (back_to_previous_visible_line_start, reseat_1)
1923 (init_iterator): Empty the bidi cache "stack".
1924 (move_it_in_display_line_to): If iterator ended up at
1925 EOL, but we never saw any buffer positions smaller than
1926 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1927 motion in bidi-reordered lines.
1928 (move_it_in_display_line_to): Record prev_method and prev_pos
1929 immediately before the call to set_iterator_to_next. Fixes cursor
1930 motion in bidi-reordered lines with stretch glyphs and strings
1931 displayed in margins. (Bug#8133) (Bug#8867)
1932 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1934 (pos_visible_p): Support positions in bidi-reordered lines.
1935 Save and restore bidi cache.
1937 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1938 (bidi_paragraph_info): Delete unused struct.
1939 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1940 (bidi_cache_start): New variable.
1941 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1943 (bidi_cache_fetch_state, bidi_cache_search)
1944 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1945 (bidi_cache_find, bidi_peek_at_next_level)
1946 (bidi_level_of_next_char, bidi_find_other_level_edge)
1947 (bidi_move_to_visually_next): Compare cache index with
1948 bidi_cache_start rather than with zero.
1949 (bidi_fetch_char): Accept new argument STRING; all callers
1950 changed. Support iteration over a string. Support strings with
1951 display properties. Support unibyte strings. Fix the type of
1952 `len' according to what STRING_CHAR_AND_LENGTH expects.
1953 (bidi_paragraph_init, bidi_resolve_explicit_1)
1954 (bidi_resolve_explicit, bidi_resolve_weak)
1955 (bidi_level_of_next_char, bidi_move_to_visually_next):
1956 Support iteration over a string.
1957 (bidi_set_sor_type, bidi_resolve_explicit_1)
1958 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1959 can now be zero (for strings); special values 0 and -1 were
1960 changed to -1 and -2, respectively.
1961 (bidi_char_at_pos): New function.
1962 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1963 Call it instead of FETCH_MULTIBYTE_CHAR.
1964 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1965 initialized to valid values.
1966 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1968 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1969 the test for valid cached positions. Fix the logic for looking up
1970 the sentinel state in the cache. GCPRO the Lisp string we are
1972 (bidi_push_it, bidi_pop_it): New functions.
1973 (bidi_initialize): Initialize the bidi cache start stack pointer.
1974 (bidi_cache_ensure_space): New function, refactored from part of
1975 bidi_cache_iterator_state. Don't assume the required size is just
1976 one BIDI_CACHE_CHUNK away.
1977 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1978 (bidi_count_bytes, bidi_char_at_pos): New functions.
1979 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1980 always valid if bidi_cache_idx is valid.
1981 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1982 is valid if it's going to be used.
1983 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1984 (bidi_cache_fetch_state, bidi_cache_search)
1985 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1986 (bidi_cache_iterator_state, bidi_cache_find)
1987 (bidi_find_other_level_edge, bidi_cache_start_stack):
1988 All variables related to cache indices are now EMACS_INT.
1990 * dispextern.h (struct bidi_string_data): New structure.
1991 (struct bidi_it): New member `string'. Make flag members be 1-bit
1992 fields, and put them last in the struct.
1993 (compute_display_string_pos, compute_display_string_end):
1995 (bidi_push_it, bidi_pop_it): Add prototypes.
1996 (struct iterator_stack_entry): New members bidi_p,
1997 paragraph_embedding, and from_disp_prop_p.
1998 (struct it): Member bidi_p is now a bit field 1 bit wide.
1999 (bidi_shelve_cache, bidi_unshelve_cache):
2002 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2003 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2004 and vector-like objects.
2006 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2007 cache around display iteration.
2009 * window.c (Fwindow_end, window_scroll_pixel_based)
2010 (displayed_window_lines, Frecenter): Save and restore the bidi
2011 cache around display iteration.
2013 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2015 * editfns.c (Fdelete_region): Clarify the use of the named
2016 parameters (bug#6788).
2018 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2020 * indent.c (Fvertical_motion): Set and restore w->pointm when
2021 saving and restoring the window's buffer (Bug#9006).
2023 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2025 * editfns.c (Fstring_to_char): Clarify just what is returned
2026 (bug#6576). Text by Eli Zaretskii.
2028 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2030 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2032 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2034 * buffer.c (mmap_find): Fix a typo.
2036 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2038 Fix execution of x selection hooks.
2039 * xselect.c (Qx_lost_selection_functions)
2040 (Qx_sent_selection_functions): New vars.
2041 (syms_of_xselect): DEFSYM them.
2042 (x_handle_selection_request): Pass Qx_sent_selection_functions
2043 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2044 (x_handle_selection_clear,x_clear_frame_selections):
2045 Pass Qx_lost_selection_functions rather than
2046 Vx_lost_selection_functions to Frun_hook_with_args.
2048 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2050 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2051 The old code sometimes used this field without initializing it.
2053 * alloc.c (gc_sweep): Don't read past end of array.
2054 In theory, the old code could also have corrupted Emacs internals,
2055 though it'd be very unlikely.
2057 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2059 * character.c (Fcharacterp): Don't advertise optional ignored
2060 argument. (Bug#4026)
2062 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2064 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2067 * window.c (Fset_window_start): Doc fix (bug#4199).
2068 (Fset_window_hscroll): Ditto.
2070 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2072 Fix minor new problems caught by GCC 4.6.1.
2073 * term.c (init_tty): Remove unused local.
2074 * xsettings.c (store_monospaced_changed): Define this function only
2075 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2078 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2080 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2082 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2084 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2085 are the mini-buffer and the echo area (bug#3320).
2087 * term.c (init_tty): Remove support for supdup, c10 and perq
2088 terminals, which are no longer supported (bug#1482).
2090 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2092 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2094 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2096 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2097 for non-popups (Bug#3642).
2099 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2101 * alloc.c (reset_malloc_hooks): Protoize.
2102 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2103 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2104 * cm.c (losecursor): Likewise.
2105 * data.c (fmod): Likewise.
2106 * dispnew.c (swap_glyphs_in_rows): Likewise.
2107 * emacs.c (memory_warning_signal): Likewise.
2108 * floatfns.c (float_error): Likewise.
2109 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2110 (otf_open, font_otf_capability, generate_otf_features)
2111 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2113 * image.c (pbm_read_file): Likewise.
2114 * indent.c (string_display_width): Likewise.
2115 * intervals.c (check_for_interval, search_for_interval)
2116 (inc_interval_count, count_intervals, root_interval)
2117 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2118 * lread.c (defalias): Likewise.
2119 * ralloc.c (r_alloc_check): Likewise.
2120 * regex.c (set_image_of_range_1, set_image_of_range)
2121 (regex_grow_registers): Likewise.
2122 * sysdep.c (strerror): Likewise.
2123 * termcap.c (valid_filename_p, tprint, main): Likewise.
2124 * tparam.c (main): Likewise.
2125 * unexhp9k800.c (run_time_remap, save_data_space)
2126 (update_file_ptrs, read_header, write_header, calculate_checksum)
2127 (copy_file, copy_rest, display_header): Likewise.
2128 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2130 * xdisp.c (check_it): Likewise.
2131 * xfaces.c (register_color, unregister_color, unregister_colors):
2133 * xfns.c (print_fontset_result): Likewise.
2134 * xrdb.c (member, fatal, main): Likewise.
2136 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2138 Fix minor problems found by static checking (Bug#9031).
2139 * chartab.c (char_table_set_range, map_sub_char_table):
2140 Remove unused locals.
2141 (uniprop_table): Now static.
2142 * composite.c (_work_char): Remove unused static var.
2144 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2146 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2148 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2150 * gtkutil.c (qttip_cb): Remove code without function.
2152 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2154 * w32.c (pthread_sigmask): New stub.
2156 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2158 Use pthread_sigmask, not sigprocmask (Bug#9010).
2159 sigprocmask is portable only for single-threaded applications, and
2160 Emacs can be multi-threaded when it uses GTK.
2161 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2163 * callproc.c (Fcall_process):
2164 * process.c (create_process):
2165 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2166 Use pthread_sigmask, not sigprocmask.
2168 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2170 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2171 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2174 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2176 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2177 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2178 (xg_hide_tooltip): Fix comment.
2180 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2181 in registerServicesMenuSendTypes.
2182 (validRequestorForSendType): Don't check ns_return_types.
2184 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2187 2011-07-08 Jason Rumney <jasonr@gnu.org>
2189 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2190 frame struct members of non-existent frames (Bug#6284).
2192 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2194 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2195 variable firstTime not needed on OSX >= 10.6.
2196 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2197 >= 10.5. Use setKnobProportion, setDoubleValue.
2199 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2200 (MAC_OS_X_VERSION_10_5): Define if not defined.
2201 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2202 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2203 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2205 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2206 cString and lossyCString on OSX >= 10.4
2208 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2209 sizeToFit on OSX >= 10.2.
2211 * nsimage.m (allocInitFromFile): Don't use deprecated method
2212 bestRepresentationForDevice on OSX >= 10.6.
2214 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2217 * emacs.c: Declare unexec_init_emacs_zone.
2219 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2221 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2223 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2224 on svcsMenu (Bug#8842).
2226 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2228 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2230 * nsterm.m (QUTF8_STRING): Declare.
2231 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2232 (validRequestorForSendType): Return type is (id).
2233 Change indexOfObjectIdenticalTo to indexOfObject.
2234 Check if we have local selection before returning self (Bug#8842).
2235 (writeSelectionToPasteboard): Put local selection into paste board
2236 if we have a local selection (Bug#8842).
2237 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2239 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2240 (ns_get_local_selection): Declare.
2242 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2244 * keymap.c (describe_map_tree): Don't insert a double newline at
2245 the end of the buffer (bug#1169) and return whether we inserted
2248 * callint.c (Fcall_interactively): Change "reading args" to
2249 "providing args" to try to clarify what it does (bug#1010).
2251 2011-07-07 Kenichi Handa <handa@m17n.org>
2253 * composite.c (composition_compute_stop_pos): Ignore a static
2254 composition starting before CHARPOS (Bug#8915).
2256 * xdisp.c (handle_composition_prop): Likewise.
2258 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2260 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2263 2011-07-07 Kenichi Handa <handa@m17n.org>
2265 * character.h (unicode_category_t): New enum type.
2267 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2268 (Qchar_code_property_table): New variable.
2269 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2270 (UNIPROP_COMPRESSED_FORM_P): New macros.
2271 (char_table_ascii): Uncompress the compressed values.
2272 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2273 Uncompress the compressed values.
2274 (sub_char_table_ref_and_range): Likewise.
2275 (char_table_ref_and_range): Uncompress the compressed values.
2276 (sub_char_table_set): New arg is_uniprop. Callers changed.
2277 Uncompress the compressed values.
2278 (sub_char_table_set_range): Args changed. Callers changed.
2279 (char_table_set_range): Adjuted for the above change.
2280 (map_sub_char_table): Delete args default_val and parent. Add arg
2281 top. Give decoded values to a Lisp function.
2282 (map_char_table): Adjust for the above change. Give decoded
2283 values to a Lisp function. Gcpro more variables.
2284 (uniprop_table_uncompress)
2285 (uniprop_decode_value_run_length): New functions.
2286 (uniprop_decoder, uniprop_decoder_count): New variables.
2287 (uniprop_get_decoder, uniprop_encode_value_character)
2288 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2290 (uniprop_encoder, uniprop_encoder_count): New variables.
2291 (uniprop_get_encoder, uniprop_table)
2292 (Funicode_property_table_internal, Fget_unicode_property_internal)
2293 (Fput_unicode_property_internal): New functions.
2294 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2295 Sunicode_property_table_internal, Sget_unicode_property_internal,
2296 and Sput_unicode_property_internal. Defvar_lisp
2297 char-code-property-alist.
2299 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2300 Vunicode_category_table.
2302 * font.c (font_range): Adjust for the change of
2303 Vunicode_category_table.
2305 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2307 * m/iris4d.h: Remove file, move contents ...
2308 * s/irix6-5.h: ... here.
2310 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2312 Remove unportable assumption about struct layout (Bug#8884).
2313 * alloc.c (mark_buffer):
2314 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2315 (clone_per_buffer_values): Don't assume that
2316 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2317 This isn't true in general, and it's particularly not true
2318 if Emacs is configured with --with-wide-int.
2319 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2320 New macros, used in the buffer.c change.
2322 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2324 * xsettings.c: Use both GConf and GSettings if both are available.
2325 (store_config_changed_event): Add comment.
2326 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2327 (store_tool_bar_style_changed): New functions.
2328 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2329 (struct xsettings): Move font inside HAVE_XFT.
2330 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2331 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2332 Move inside HAVE_XFT.
2333 (something_changed_gsettingsCB): Rename from something_changedCB.
2334 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2336 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2337 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2338 (something_changed_gconfCB): Rename from something_changedCB.
2339 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2340 (parse_settings): Move check for font inside HAVE_XFT.
2341 (read_settings, apply_xft_settings): Add comment.
2342 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2343 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2344 call store_font_name_changed.
2345 (xft_settings_event): Add comment.
2346 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2347 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2348 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2349 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2350 (xsettings_initialize): Call init_gsettings last.
2351 (xsettings_get_system_font, xsettings_get_system_normal_font):
2354 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2356 Random fixes. E.g., (random) never returned negative values.
2357 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2358 subseconds part to the entropy, as that's a bit more random.
2359 Prefer signed to unsigned, since the signedness doesn't matter and
2360 in general we prefer signed. When given a limit, use a
2361 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2362 latter isn't right if USE_2_TAGS_FOR_INTS.
2363 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2364 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2366 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2368 * textprop.c (text_property_stickiness):
2369 Obey Vtext_property_default_nonsticky.
2370 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2371 * w32fns.c (syms_of_w32fns):
2372 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2374 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2376 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2377 This is more efficient than Ffile_directory_p and avoids a minor race.
2379 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2381 * buffer.c (Foverlay_put): Say what the return value is
2384 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2385 is a directory before asking whether to use the file name
2387 (barf_or_query_if_file_exists): Make the "File is a directory"
2388 error be more correct.
2390 * fns.c (Frequire): Remove the mention of the .gz files, since
2391 that's installation-specific, but keep the mention of
2392 `get-load-suffixes'.
2394 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2396 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2397 Report string overflow if the output is too long.
2399 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2401 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2402 (syms_of_gnutls): Remove duplicate DEFSYM for
2403 Qgnutls_bootprop_verify_hostname_error, an error for
2404 Qgnutls_bootprop_verify_error (which is no longer used).
2406 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2407 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2408 Also (re)move comments that are misplaced or no longer relevant.
2410 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2412 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2414 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2416 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2417 and background color parameters if they have been changed.
2419 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2421 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2423 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2425 * xsettings.c (SYSTEM_FONT): Define only when used.
2426 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2428 * keymap.c (access_keymap_1): Now static.
2430 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2432 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2433 leave any prefix arg for the up event (Bug#1586).
2435 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2437 * lread.c (syms_of_lread): Mention single symbols defined by
2438 `defvar' or `defconst' (bug#7154).
2440 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2441 (Frequire): Mention get-load-suffixes.
2443 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2445 * window.h (window): Remove clone_number slot.
2446 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2448 (make_parent_window, make_window, saved_window)
2449 (Fset_window_configuration, save_window_save): Don't deal with
2451 * buffer.c (Qclone_number): Remove declaration.
2452 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2454 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2456 Add multiple inheritance to keymaps.
2457 * keymap.c (Fmake_composed_keymap): New function.
2458 (Fset_keymap_parent): Simplify.
2459 (fix_submap_inheritance): Remove.
2460 (access_keymap_1): New function extracted from access_keymap to handle
2461 embedded parents and handle lists of maps.
2462 (access_keymap): Use it.
2463 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2464 (Fcopy_keymap): Handle embedded parents.
2465 (Fcommand_remapping, define_as_prefix): Simplify.
2466 (Fkey_binding): Simplify.
2467 (syms_of_keymap): Move minibuffer-local-completion-map,
2468 minibuffer-local-filename-completion-map,
2469 minibuffer-local-must-match-map, and
2470 minibuffer-local-filename-must-match-map to Elisp.
2471 (syms_of_keymap): Defsubr make-composed-keymap.
2472 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2473 (parse_menu_item): Trivial simplification.
2475 2011-07-01 Glenn Morris <rgm@gnu.org>
2477 * Makefile.in (SETTINGS_LIBS): Fix typo.
2479 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2481 * coding.c (Fencode_coding_string): Record the last coding system
2482 used, as the function doc string says (bug#8738).
2484 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2486 * xsettings.c (store_monospaced_changed): Take new font as arg and
2487 check for change against current_mono_font.
2488 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2489 (emacs_settings_constructor, emacs_settings_get_property)
2490 (emacs_settings_set_property, emacs_settings_class_init)
2491 (emacs_settings_init, gsettings_obj): Remove.
2492 (something_changedCB): New function for HAVE_GSETTINGS.
2493 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2494 with value as argument.
2495 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2496 g_settings_new (Bug#8967). Do not create gsettings_obj.
2497 Remove calls to g_settings_bind. Connect something_changedCB to
2500 * xgselect.c: Add defined (HAVE_GSETTINGS).
2501 (xgselect_initialize): Ditto.
2503 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2504 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2507 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2509 * eval.c (struct backtrace): Simplify and port the data structure.
2510 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2511 signed bit field, as this assumption is not portable and it makes
2512 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2513 "char debug_on_exit : 1" as this is not portable either; instead,
2514 use the portable "unsigned int debug_on_exit : 1". Remove unused
2515 member evalargs. Remove obsolete comments about cc bombing out.
2517 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2519 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2520 Let HAVE_GSETTINGS override HAVE_GCONF.
2521 (store_monospaced_changed): New function.
2522 (EMACS_SETTINGS): A new type derived from GObject to handle
2523 GSettings notifications.
2524 (emacs_settings_constructor, emacs_settings_get_property)
2525 (emacs_settings_set_property, emacs_settings_class_init):
2527 (gsettings_client, gsettings_obj): New variables.
2528 (GSETTINGS_SCHEMA): New define.
2529 (something_changedCB): Call store_monospaced_changed.
2530 (init_gsettings): New function.
2531 (xsettings_initialize): Call init_gsettings.
2532 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2535 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2538 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2540 * window.c (resize_root_window, grow_mini_window)
2541 (shrink_mini_window): Rename Qresize_root_window to
2542 Qwindow_resize_root_window and Qresize_root_window_vertically to
2543 Qwindow_resize_root_window_vertically.
2545 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2547 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2549 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2551 * makefile.w32-in: Redesign dependencies so they reflect more
2552 clearly which files are directly included by each source file,
2553 and not through other includes.
2555 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2557 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2558 (sort_overlays, overlay_strings): When an overlay's clone number
2559 matches the window's clone number process the overlay even if
2560 the overlay's window property doesn't match the current window.
2562 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2563 (Fwindow_hchild): Rename to Fwindow_left_child.
2564 (Fwindow_next): Rename to Fwindow_next_sibling.
2565 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2566 (resize_window_check): Rename to window_resize_check.
2567 (resize_window_apply): Rename to window_resize_apply.
2568 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2569 (Fdelete_other_windows_internal, resize_frame_windows)
2570 (Fsplit_window_internal, Fdelete_window_internal)
2571 (grow_mini_window, shrink_mini_window)
2572 (Fresize_mini_window_internal): Fix callers accordingly.
2574 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2576 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2577 (emacs_fixed_set_min_size): Remove.
2578 (emacs_fixed_new): Take frame as argument.
2580 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2581 (_EmacsFixedPrivate): Remove minwidth/height.
2582 Add struct frame *f.
2583 (emacs_fixed_init): Initialize priv->f.
2584 (get_parent_class, emacs_fixed_set_min_size): Remove.
2585 (emacs_fixed_new): Set priv->f to argument.
2586 (emacs_fixed_get_preferred_width)
2587 (emacs_fixed_get_preferred_height): Use min_width/height from
2588 frames size_hint to set minimum and natural (Bug#8919).
2589 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2590 and use min_width/height from frames size_hint to set
2591 min_width/height (Bug#8919).
2593 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2594 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2597 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2599 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2600 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2603 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2605 * process.c (wait_reading_process_output): Bypass select if
2606 waiting for a cell while ignoring keyboard input, and input is
2607 pending. Suggested by Jan Djärv (Bug#8869).
2609 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2611 Use gnulib's dup2 module instead of rolling our own.
2612 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2614 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2616 * dispnew.c (scrolling_window): Before scrolling, turn off a
2617 mouse-highlight in the window being scrolled.
2619 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2621 Move DEFSYM to lisp.h and use everywhere.
2623 * character.h (DEFSYM): Move declaration...
2624 * lisp.h (DEFSYM): ...here.
2630 * w32select.c: Don't include character.h.
2632 * alloc.c (syms_of_alloc):
2633 * buffer.c (syms_of_buffer):
2634 * bytecode.c (syms_of_bytecode):
2635 * callint.c (syms_of_callint):
2636 * casefiddle.c (syms_of_casefiddle):
2637 * casetab.c (init_casetab_once):
2638 * category.c (init_category_once, syms_of_category):
2639 * ccl.c (syms_of_ccl):
2640 * cmds.c (syms_of_cmds):
2641 * composite.c (syms_of_composite):
2642 * dbusbind.c (syms_of_dbusbind):
2643 * dired.c (syms_of_dired):
2644 * dispnew.c (syms_of_display):
2645 * doc.c (syms_of_doc):
2646 * editfns.c (syms_of_editfns):
2647 * emacs.c (syms_of_emacs):
2648 * eval.c (syms_of_eval):
2649 * fileio.c (syms_of_fileio):
2650 * fns.c (syms_of_fns):
2651 * frame.c (syms_of_frame):
2652 * fringe.c (syms_of_fringe):
2653 * insdel.c (syms_of_insdel):
2654 * keymap.c (syms_of_keymap):
2655 * lread.c (init_obarray, syms_of_lread):
2656 * macros.c (syms_of_macros):
2657 * msdos.c (syms_of_msdos):
2658 * print.c (syms_of_print):
2659 * process.c (syms_of_process):
2660 * search.c (syms_of_search):
2661 * sound.c (syms_of_sound):
2662 * syntax.c (init_syntax_once, syms_of_syntax):
2663 * terminal.c (syms_of_terminal):
2664 * textprop.c (syms_of_textprop):
2665 * undo.c (syms_of_undo):
2666 * w32.c (globals_of_w32):
2667 * window.c (syms_of_window):
2668 * xdisp.c (syms_of_xdisp):
2669 * xfaces.c (syms_of_xfaces):
2670 * xfns.c (syms_of_xfns):
2671 * xmenu.c (syms_of_xmenu):
2672 * xsettings.c (syms_of_xsettings):
2673 * xterm.c (syms_of_xterm): Use DEFSYM.
2675 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2677 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2679 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2681 Integer and buffer overflow fixes (Bug#8873).
2683 * print.c (printchar, strout): Check for string overflow.
2684 (PRINTPREPARE, printchar, strout):
2685 Don't set size unless allocation succeeds.
2687 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2688 for sizes. Check for string overflow more accurately.
2689 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2691 * macros.c: Integer and buffer overflow fixes.
2692 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2693 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2694 Use ptrdiff_t, not int, for sizes.
2695 Don't increment bufsize until after realloc succeeds.
2696 Check for size-calculation overflow.
2697 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2699 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2701 * lread.c: Integer overflow fixes.
2702 (read_integer): Radix is now EMACS_INT, not int,
2703 to improve quality of diagnostics for out-of-range radices.
2704 Calculate buffer size correctly for out-of-range radices.
2705 (read1): Check for integer overflow in radices, and in
2706 read-circle numbers.
2707 (read_escape): Avoid int overflow.
2708 (Fload, openp, read_buffer_size, read1)
2709 (substitute_object_recurse, read_vector, read_list, map_obarray):
2710 Use ptrdiff_t, not int, for sizes.
2711 (read1): Use EMACS_INT, not int, for sizes.
2712 Check for size overflow.
2714 * image.c (cache_image): Check for size arithmetic overflow.
2716 * lread.c: Integer overflow issues.
2717 (saved_doc_string_size, saved_doc_string_length)
2718 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2719 Now ptrdiff_t, not int.
2720 (read1): Don't assume doc string length fits in int. Check for
2721 out-of-range doc string lengths.
2722 (read_list): Don't assume file position fits in int.
2723 (read_escape): Check for hex character overflow.
2725 2011-06-22 Leo Liu <sdl.web@gmail.com>
2727 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2728 Move to minibuffer.el.
2730 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2732 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2733 The following patches are for when GLYPH_DEBUG && !XASSERT.
2734 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2735 * dispnew.c (flush_stdout):
2736 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2737 Mark as externally visible.
2738 * dispnew.c (check_window_matrix_pointers): Now static.
2739 * dispnew.c (window_to_frame_vpos):
2740 * xfns.c (unwind_create_frame):
2741 * xterm.c (x_check_font): Remove unused local.
2742 * scroll.c (CHECK_BOUNDS):
2743 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2744 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2745 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2746 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2747 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2749 (debug_method_add): Use va_list and vsprintf rather than relying
2750 on undefined behavior with wrong number of arguments.
2751 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2752 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2753 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2754 since we're not interested in debugging glyphs with old libraries.
2755 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2756 GCC 4.6.0's static checking.
2758 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2760 Integer overflow and signedness fixes (Bug#8873).
2761 A few related buffer overrun fixes, too.
2763 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2765 * dispextern.h (struct face.stipple):
2766 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2767 (x_bitmap_mask, x_allocate_bitmap_record)
2768 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2769 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2770 (x_create_bitmap_from_xpm_data):
2771 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2772 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2774 * xfaces.c (load_pixmap):
2775 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2776 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2777 (.bitmaps_last, struct x_output.icon_bitmap):
2778 Use ptrdiff_t, not int, for bitmap indexes.
2779 (x_allocate_bitmap_record): Check for size overflow.
2780 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2782 Use ptrdiff_t, not int, for overlay counts.
2783 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2784 * editfns.c (overlays_around, get_pos_property):
2785 * textprop.c (get_char_property_and_overlay):
2786 * xdisp.c (next_overlay_change, note_mouse_highlight):
2787 * xfaces.c (face_at_buffer_position):
2788 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2789 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2790 (Fnext_overlay_change, Fprevious_overlay_change)
2791 (mouse_face_overlay_overlaps, Foverlays_in):
2792 Use ptrdiff_t, not int, for sizes.
2793 (overlays_at, overlays_in): Check for size-calculation overflow.
2795 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2797 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2798 (x_session_initialize): Do not assume string length fits in int.
2800 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2801 This is unlikely, but can occur if DPI is outlandish.
2803 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2804 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2806 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2807 * xrdb.c (magic_file_p, search_magic_path):
2808 Omit last arg SUFFIX; it was always 0. All callers changed.
2809 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2811 * xfont.c (xfont_match): Avoid need for strlen.
2813 * xfns.c: Don't assume strlen fits in int.
2814 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2816 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2817 not unsigned long, as we prefer signed integers. All callers changed.
2818 Detect integer overflow in repeat count.
2819 (message_dolog): Don't assume print length fits in 39 bytes.
2820 (display_mode_element): Don't assume strlen fits in int.
2822 * termcap.c: Don't assume sizes fit in int and never overflow.
2823 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2824 (gobble_line): Check for size-calculation overflow.
2826 * minibuf.c (Fread_buffer):
2827 * lread.c (intern, intern_c_string):
2828 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2829 Don't assume string length fits in int.
2831 * keyboard.c (parse_tool_bar_item):
2832 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2834 * font.c: Don't assume string length fits in int.
2835 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2836 Use ptrdiff_t, not int.
2837 (font_intern_prop): Don't assume string length fits in int.
2838 Don't assume integer property fits in fixnum.
2839 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2841 * filelock.c: Fix some buffer overrun and integer overflow issues.
2842 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2843 Reformulate so as not to need the command string.
2844 Invoke gzip -cd rather than gunzip, as it's more portable.
2845 (lock_info_type, lock_file_1, lock_file):
2846 Don't assume pid_t and time_t fit in unsigned long.
2847 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2848 (current_lock_owner): Prefer signed type for sizes.
2849 Use memcpy, not strncpy, where memcpy is what is really wanted.
2850 Don't assume (via atoi) that time_t and pid_t fit in int.
2851 Check for time_t and/or pid_t out of range, e.g., via a network share.
2852 Don't alloca where an auto var works fine.
2854 * fileio.c: Fix some integer overflow issues.
2855 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2856 Don't assume string length fits in int.
2857 (directory_file_name): Don't assume string length fits in long.
2858 (make_temp_name): Don't assume pid fits in int, or that its print
2859 length is less than 20.
2861 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2863 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2865 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2867 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2868 We prefer signed integers, even for size calculations.
2870 * emacs.c: Don't assume string length fits in 'int'.
2871 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2872 (main): Don't invoke strlen when not needed.
2874 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2875 (XD_DEBUG_MESSAGE): Don't waste a byte.
2877 * callproc.c (getenv_internal_1, getenv_internal)
2879 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2881 * lread.c (invalid_syntax): Omit length argument.
2882 All uses changed. This doesn't fix a bug, but it simplifies the
2883 code away from its former Hollerith-constant appearance, and it's
2884 one less 'int' to worry about when looking at integer-overflow issues.
2885 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2887 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2888 This didn't break anything, but it didn't help either.
2889 It's confusing to put a bogus integer in a place where the actual
2890 value does not matter.
2891 (LIST_END_P): Remove unused macro and its bogus comment.
2892 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2894 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2895 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2897 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2898 We prefer signed types, and the value cannot exceed the EMACS_INT
2899 range anyway (because otherwise the length would not be representable).
2900 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2901 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2902 This avoids a GCC warning when WIDE_EMACS_INT.
2904 * indent.c (sane_tab_width): New function.
2905 (current_column, scan_for_column, Findent_to, position_indentation)
2906 (compute_motion): Use it. This is just for clarity.
2907 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2909 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2911 * lisp.h (lint_assume): New macro.
2912 * composite.c (composition_gstring_put_cache):
2913 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2915 * editfns.c, insdel.c:
2916 Omit unnecessary forward decls, to simplify future changes.
2918 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2920 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2922 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2923 Use much-faster test for byte-length change.
2924 Don't assume string byte-length fits in 'int'.
2925 Check that character arg fits in 'int'.
2926 (mapcar1): Declare byte as byte, for clarity.
2928 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2930 * fns.c (concat): Catch string overflow earlier.
2931 Do not rely on integer wraparound.
2933 * dispextern.h (struct it.overlay_strings_charpos)
2934 (struct it.selective): Now EMACS_INT, not int.
2935 * xdisp.c (forward_to_next_line_start)
2936 (back_to_previous_visible_line_start)
2937 (reseat_at_next_visible_line_start, next_element_from_buffer):
2938 Don't arbitrarily truncate the value of 'selective' to int.
2940 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2942 * composite.c: Don't truncate sizes to 'int'.
2943 (composition_gstring_p, composition_reseat_it)
2944 (composition_adjust_point): Use EMACS_INT, not int.
2945 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2946 not EMACS_UINT, for indexes.
2948 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2950 * buffer.c: Include <verify.h>.
2951 (struct sortvec.priority, struct sortstr.priority):
2952 Now EMACS_INT, not int.
2953 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2954 (struct sortstr.size, record_overlay_string)
2955 (struct sortstrlist.size, struct sortlist.used):
2956 Don't truncate size to int.
2957 (record_overlay_string): Check for size-calculation overflow.
2958 (init_buffer_once): Check at compile-time, not run-time.
2960 2011-06-22 Jim Meyering <meyering@redhat.com>
2962 Don't leak an XBM-image-sized buffer
2963 * image.c (xbm_load): Free the image buffer after using it.
2965 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2968 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2969 that Sun C diagnosed.
2970 * fns.c (secure_hash): Fix pointer signedness issue.
2971 * intervals.c (static_offset_intervals): New function.
2972 (offset_intervals): Use it.
2974 2011-06-21 Leo Liu <sdl.web@gmail.com>
2977 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2980 * fns.c (secure_hash): Rename from crypto_hash_function and change
2981 the first arg to accept symbols.
2982 (Fsecure_hash): New primitive.
2983 (syms_of_fns): New symbols.
2985 2011-06-20 Deniz Dogan <deniz@dogan.se>
2987 * process.c (Fset_process_buffer): Clarify return value in
2990 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2992 * dispnew.c (add_window_display_history): Use BVAR.
2994 * xdisp.c (debug_method_add): Use BVAR.
2995 (check_window_end, dump_glyph_matrix, dump_glyph)
2996 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2998 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3001 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3002 check till after the cache is created in init_frame_faces.
3004 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3006 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3008 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3010 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3011 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3012 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3014 Improve buffer-overflow checking (Bug#8873).
3015 * fileio.c (Finsert_file_contents):
3016 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3017 Remove the old (too-loose) buffer overflow checks.
3018 They weren't needed, since make_gap checks for buffer overflow.
3019 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3020 The old code merely checked for Emacs fixnum overflow, and relied
3021 on undefined (wraparound) behavior. The new code avoids undefined
3022 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3024 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3025 Tune. Don't use wider integers than needed. Don't use alloca.
3026 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3028 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3030 * insdel.c, lisp.h (buffer_overflow): New function.
3031 (insert_from_buffer_1, replace_range, replace_range_2):
3032 * insdel.c (make_gap_larger):
3033 * editfns.c (Finsert_char):
3034 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3036 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3038 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3040 Integer overflow and signedness fixes (Bug#8873).
3042 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3043 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3045 * fileio.c: Don't assume EMACS_INT fits in off_t.
3046 (emacs_lseek): New static function.
3047 (Finsert_file_contents, Fwrite_region): Use it.
3048 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3050 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3052 * fns.c: Don't overflow int when computing a list length.
3053 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3054 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3055 truncation on 64-bit hosts. Check for QUIT every
3056 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3057 faster and is responsive enough.
3058 (Flength): Report an error instead of overflowing an integer.
3059 (Fsafe_length): Return a float if the value is not representable
3060 as a fixnum. This shouldn't happen except in contrived situations.
3061 (Fnthcdr, Fsort): Don't assume list length fits in int.
3062 (Fcopy_sequence): Don't assume vector length fits in int.
3064 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3065 (header_size, word_size): New constants.
3066 (allocate_vectorlike): Don't check size overflow here.
3067 (allocate_vector): Check it here instead, since this is the only
3068 caller of allocate_vectorlike that could cause overflow.
3069 Check that the new vector's length is representable as a fixnum.
3071 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3072 The previous code was bogus. For example, next_almost_prime (32)
3073 returned 39, which is undesirable as it is a multiple of 3; and
3074 next_almost_prime (24) returned 25, which is a multiple of 5 so
3075 why was the code bothering to check for multiples of 7?
3077 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3079 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3081 Variadic C functions now count arguments with ptrdiff_t.
3082 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3083 Back then I didn't know that the Emacs coding style prefers signed int.
3084 Also, in the meantime I found a few more instances where arguments
3085 were being counted with int, which may truncate counts on 64-bit
3086 machines, or EMACS_INT, which may be unnecessarily wide.
3087 * lisp.h (struct Lisp_Subr.function.aMANY)
3088 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3089 Arg counts are now ptrdiff_t, not size_t.
3090 All variadic functions and their callers changed accordingly.
3091 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3092 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3093 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3094 * callint.c (Fcall_interactively): Check arg count for overflow,
3095 to avoid potential buffer overrun. Use signed char, not 'int',
3096 for 'varies' array, so that we needn't bother to check its size
3097 calculation for overflow.
3098 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3099 * eval.c (apply_lambda):
3100 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3101 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3102 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3104 * callint.c (Fcall_interactively): Don't use index var as event count.
3106 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3107 * mem-limits.h (SIZE): Remove; no longer used.
3109 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3111 Remove unnecessary casts.
3112 * xterm.c (x_term_init):
3113 * xfns.c (x_set_border_pixel):
3114 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3115 These aren't needed now that we assume ANSI C.
3117 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3118 It's more likely to cause problems (due to unsigned overflow)
3121 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3123 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3125 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3127 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3129 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3131 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3133 GLYPH_CODE_FACE returns EMACS_INT, not int.
3134 * dispextern.h (merge_faces):
3135 * xfaces.c (merge_faces):
3136 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3137 Don't assume EMACS_INT fits in int.
3139 * character.h (CHAR_VALID_P): Remove unused parameter.
3140 * fontset.c, lisp.h, xdisp.c: All uses changed.
3142 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3144 * fns.c (concat): Minor tuning based on overflow analysis.
3145 This doesn't fix any bugs. Use int to hold character, instead
3146 of constantly refetching from Emacs object. Use XFASTINT, not
3147 XINT, for value known to be a character. Don't bother comparing
3148 a single byte to 0400, as it's always less.
3150 * floatfns.c (Fexpt):
3151 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3153 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3156 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3158 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3159 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3160 incorrectly succeed when S was a string, because 4294967386 was
3161 truncated before it was used.
3163 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3164 Otherwise, an out-of-range integer could cause undefined behavior
3167 * composite.c: Use int, not EMACS_INT, for characters.
3168 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3169 EMACS_INT, for values that are known to be in character range.
3170 This doesn't fix any bugs but is the usual style inside Emacs and
3171 may generate better code on 32-bit machines.
3173 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3174 This is for reasons similar to the recent CHAR_STRING fix.
3175 * charset.c (Fencode_char): Check that character arg is actually
3176 a character. Pass an int to ENCODE_CHAR.
3177 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3178 wider than 'int', as a compile-time check to prevent future regressions
3181 * character.c (char_string): Remove unnecessary casts.
3183 Make sure a 64-bit char is never passed to CHAR_STRING.
3184 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3185 by silently ignoring the top 32 bits, allowing some values
3186 that were far too large to be valid characters.
3187 * character.h: Include <verify.h>.
3188 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3189 arguments are no wider than unsigned, as a compile-time check
3190 to prevent future regressions in this area.
3192 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3193 (Fsubst_char_in_region):
3195 * xdisp.c (decode_mode_spec_coding):
3196 Adjust to CHAR_STRING's new requirement.
3197 * editfns.c (Finsert_char, Fsubst_char_in_region):
3198 * fns.c (concat): Check that character args are actually
3199 characters. Without this test, these functions did the wrong
3200 thing with wildly out-of-range values on 64-bit hosts.
3202 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3203 These casts should not be needed on 32-bit hosts, either.
3204 * keyboard.c (read_char):
3205 * lread.c (Fload): Remove casts to unsigned.
3207 * lisp.h (UNSIGNED_CMP): New macro.
3208 This fixes comparison bugs on 64-bit hosts.
3209 (ASCII_CHAR_P): Use it.
3210 * casefiddle.c (casify_object):
3211 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3212 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3213 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3214 * dispextern.h (FACE_FROM_ID):
3215 * keyboard.c (read_char): Use UNSIGNED_CMP.
3217 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3218 not to EMACS_INT, to avoid GCC warning.
3220 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3222 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3223 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3224 isn't needed on 32-bit machines.
3226 * buffer.c (Fgenerate_new_buffer_name):
3227 Use EMACS_INT for count, not int.
3228 (advance_to_char_boundary): Return EMACS_INT, not int.
3230 * data.c (Qcompiled_function): Now static.
3232 * window.c (window_body_lines): Now static.
3234 * image.c (gif_load): Rename local to avoid shadowing.
3236 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3237 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3238 * alloc.c (make_save_value): Integer argument is now of type
3240 (mark_object): Use ptrdiff_t, not int.
3241 * lisp.h (pD): New macro.
3242 * print.c (print_object): Use it.
3244 * alloc.c: Use EMACS_INT, not int, to count objects.
3245 (total_conses, total_markers, total_symbols, total_vector_size)
3246 (total_free_conses, total_free_markers, total_free_symbols)
3247 (total_free_floats, total_floats, total_free_intervals)
3248 (total_intervals, total_strings, total_free_strings):
3249 Now EMACS_INT, not int. All uses changed.
3250 (Fgarbage_collect): Compute overall total using a double, so that
3251 integer overflow is less likely to be a problem. Check for overflow
3252 when converting back to an integer.
3253 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3254 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3255 These were 'int' variables that could overflow on 64-bit hosts;
3256 they were never used, so remove them instead of repairing them.
3257 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3258 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3259 Previously, this ceilinged at INT_MAX, but that doesn't work on
3261 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3263 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3264 (allocate_vectorlike): Check for ptrdiff_t overflow.
3265 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3266 when a (possibly-narrower) signed value would do just as well.
3267 We prefer using signed arithmetic, to avoid comparison confusion.
3269 * alloc.c: Catch some string size overflows that we were missing.
3270 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3271 for convenience in STRING_BYTES_MAX.
3272 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3273 The definition here is exact; the one in lisp.h was approximate.
3274 (allocate_string_data): Check for string overflow. This catches
3275 some instances we weren't catching before. Also, it catches
3276 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3277 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3278 and ptrdiff_t and EMACS_INT are both 64 bits.
3280 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3281 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3282 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3284 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3286 * alloc.c (Fmake_string): Check for out-of-range init.
3288 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3290 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3292 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3294 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3295 xg_get_default_scrollbar_width.
3297 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3298 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3299 (style_changed_cb): Call update_theme_scrollbar_width and call
3300 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3301 all frames (Bug#8505).
3302 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3303 Call gtk_window_set_resizable if HAVE_GTK3.
3304 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3305 and height if HAVE_GTK3 (Bug#8505).
3306 (scroll_bar_width_for_theme): New variable.
3307 (update_theme_scrollbar_width): New function.
3308 (xg_get_default_scrollbar_width): Move code to
3309 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3310 (xg_initialize): Call update_theme_scrollbar_width.
3312 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3314 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3316 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3318 * frame.c (make_frame): Call other_buffer_safely instead of
3321 * window.c (temp_output_buffer_show): Call display_buffer with
3322 second argument Vtemp_buffer_show_specifiers and reset latter
3323 immediately after the call.
3324 (Vtemp_buffer_show_specifiers): New variable.
3325 (auto_window_vscroll_p, next_screen_context_lines)
3326 (Vscroll_preserve_screen_position): Remove leading asterisks from
3329 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3331 Fix minor problems found by GCC 4.6.0 static checking.
3332 * buffer.c (Qclone_number): Remove for now, as it's unused.
3333 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3334 (record_buffer): Remove unused local.
3335 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3336 (set_frame_buffer_list): Remove; unused.
3337 * frame.h (other_visible_frames): Remove decl.
3338 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3339 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3340 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3342 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3343 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3344 Define only if HAVE_GPM.
3345 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3346 (update_hints_inhibit): Remove; never set. All uses removed.
3347 * widgetprv.h (emacsFrameClassRec): Remove decl.
3348 * window.c (delete_deletable_window): Now returns void, since it
3349 wasn't returning anything.
3350 (compare_window_configurations): Remove unused locals.
3351 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3352 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3353 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3354 the same widths as pointers. This follows up on the 2011-05-06 patch.
3355 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3356 * xterm.h: Likewise.
3357 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3359 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3361 * makefile.w32-in: Update dependencies.
3362 (LISP_H): Add lib/intprops.h.
3364 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3366 * image.c (gif_load): Add animation frame delay to the metadata.
3367 (syms_of_image): Use DEFSYM. New symbol `delay'.
3369 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3371 * window.c (delete_deletable_window): Re-add.
3372 (Fset_window_configuration): Rewrite to handle dead buffers and
3373 consequently deletable windows.
3374 (window_tree, Fwindow_tree): Remove. Supply functionality in
3376 (compare_window_configurations): Simplify code.
3378 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3380 * image.c (imagemagick_load_image): Fix type mismatch.
3381 (Fimagemagick_types): Likewise.
3383 * window.h (replace_buffer_in_windows): Declare.
3385 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3387 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3388 Qclone_number. Remove external declaration of Qdelete_window.
3389 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3391 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3392 Run Qbuffer_list_update_hook if allowed.
3393 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3394 buffer list implementation.
3395 (other_buffer_safely): New function.
3396 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3397 calls to replace_buffer_in_windows and
3398 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3400 (record_buffer): Inhibit quitting and rewrite using quittable
3401 functions. Run Qbuffer_list_update_hook if allowed.
3402 (Frecord_buffer, Funrecord_buffer): New functions.
3403 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3404 Move switch-to-buffer to window.el.
3405 (bury-buffer): Move to window.el.
3406 (Vbuffer_list_update_hook): New variable.
3408 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3411 * window.h (resize_frame_windows): Move up in code.
3412 (Fwindow_frame): Remove EXFUN.
3413 (replace_buffer_in_all_windows): Remove prototype.
3414 (replace_buffer_in_windows_safely): Add prototype.
3416 * window.c: Declare Qdelete_window static again. Move down
3417 declaration of select_count.
3418 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3419 (Fother_window): Move to window.el.
3420 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3421 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3422 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3424 (replace_buffer_in_windows): Implement by calling
3425 Qreplace_buffer_in_windows.
3426 (replace_buffer_in_all_windows): Remove with some functionality
3427 moved into replace_buffer_in_windows_safely.
3428 (replace_buffer_in_windows_safely): New function.
3429 (select_window_norecord, select_frame_norecord): Move in front
3430 of run_window_configuration_change_hook. Remove now obsolete
3432 (Fset_window_buffer): Rewrite doc-string.
3433 Call Qrecord_window_buffer.
3434 (keys_of_window): Move binding for other-window to window.el.
3436 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3438 * dispextern.h (struct image): Replace data member, whose int_val
3439 and ptr_val fields were not used by anything, with a single
3442 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3443 (gif_clear_image, gif_load, imagemagick_load_image)
3444 (gs_clear_image, gs_load): Callers changed.
3446 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3448 * buffer.h: Include <time.h>, for time_t.
3449 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3451 Fix minor problems found by static checking.
3453 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3455 Make identifiers static if they are not used in other modules.
3456 * data.c (Qcompiled_function, Qframe, Qvector):
3457 * image.c (QimageMagick, Qsvg):
3458 * minibuf.c (Qmetadata):
3459 * window.c (resize_window_check, resize_root_window): Now static.
3460 * window.h (resize_window_check, resize_root_window): Remove decls.
3462 * window.c (window_deletion_count, delete_deletable_window):
3464 (window_body_lines): Now static.
3465 (Fdelete_other_windows_internal): Mark vars as initialized.
3466 Make sure 'resize_failed' is initialized.
3467 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3468 (resize_window_apply): Remove unused local.
3469 * window.h (delete_deletable_window): Remove decl.
3471 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3472 (imagemagick_load_image): Fix pointer signedness problem by changing
3473 last arg from unsigned char * to char *. All uses changed.
3474 Also, fix a local for similar reasons.
3475 Remove unused locals. Remove locals to avoid shadowing.
3476 (fn_rsvg_handle_free): Remove; unused.
3477 (svg_load, svg_load_image): Fix pointer signedness problem.
3478 (imagemagick_load_image): Don't use garbage pointer image_wand.
3480 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3482 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3484 * image.c (gif_load): Fix omitted cast error introduced by
3487 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3489 * window.h (resize_proportionally, orig_total_lines)
3490 (orig_top_line): Remove from window structure.
3491 (set_window_height, set_window_width, change_window_heights)
3492 (Fdelete_window): Remove prototypes.
3493 (resize_frame_windows): Remove duplicate declaration.
3495 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3497 * window.h (resize_frame_windows, resize_window_check)
3498 (delete_deletable_window, resize_root_window)
3499 (resize_frame_windows): Declare prototypes.
3501 * window.c (resize_window_apply): Make definition be "static" to
3502 match the prototype.
3504 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3506 * window.c: Remove declarations of Qwindow_size_fixed,
3507 window_min_size_1, window_min_size_2, window_min_size,
3508 size_window, window_fixed_size_p, enlarge_window, delete_window.
3509 Remove static from declaration of Qdelete_window, it's
3510 temporarily needed by Fbury_buffer.
3511 (replace_window): Don't assign orig_top_line and
3513 (Fdelete_window, delete_window): Remove. Window deletion is
3514 handled by window.el.
3515 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3516 Replace Fdelete_window calls with calls to Qdelete_window.
3517 (Fdelete_other_windows): Remove. Deleting other windows is
3518 handled by window.el.
3519 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3520 handled in window.el.
3521 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3522 Window minimum sizes are handled in window.el.
3523 (shrink_windows, size_window, set_window_height)
3524 (set_window_width, change_window_heights, window_height)
3525 (window_width, CURBEG, CURSIZE, enlarge_window)
3526 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3527 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3528 handled in window.el.
3529 (make_dummy_parent): Rename to make_parent_window and give it a
3530 second argument horflag.
3531 (make_window): Don't set resize_proportionally any more.
3532 (Fsplit_window): Remove. Windows are split in window.el.
3533 (save_restore_action, save_restore_orig_size)
3534 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3535 Resize mini windows in window.el.
3536 (grow_mini_window, shrink_mini_window): Implement by calling
3537 Qresize_root_window_vertically, resize_window_check and
3538 resize_window_apply.
3539 (saved_window, Fset_window_configuration, save_window_save):
3540 Do not handle orig_top_line, orig_total_lines, and
3541 resize_proportionally.
3542 (window_min_height, window_min_width): Move to window.el.
3543 (keys_of_window): Move bindings for delete-other-windows,
3544 split-window, delete-window and enlarge-window to window.el.
3546 * buffer.c: Temporarily extern Qdelete_window.
3547 (Fbury_buffer): Temporarily call Qdelete_window instead of
3548 Fdelete_window (Fbury_buffer will move to window.el soon).
3550 * frame.c (set_menu_bar_lines_1): Remove code handling
3551 orig_top_line and orig_total_lines.
3553 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3554 set_window_height but set heights directly.
3555 (change_frame_size_1): Use resize_frame_windows.
3557 * xdisp.c (init_xdisp): Don't use set_window_height but set
3560 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3561 Use resize_frame_windows instead of change_window_heights and run
3562 run_window_configuration_change_hook.
3564 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3565 instead of change_window_heights and run
3566 run_window_configuration_change_hook.
3568 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3570 * window.c (replace_window): Rename second argument REPLACEMENT to
3571 NEW. New third argument SETFLAG. Rewrite.
3572 (delete_window, make_dummy_parent): Call replace_window with
3574 (window_list_1): Move down in code.
3575 (run_window_configuration_change_hook): Move set_buffer part
3576 before select_frame_norecord part in order to unwind correctly.
3577 Rename count1 to count.
3578 (recombine_windows, delete_deletable_window, resize_root_window)
3579 (Fdelete_other_windows_internal)
3580 (Frun_window_configuration_change_hook, make_parent_window)
3581 (resize_window_check, resize_window_apply, Fresize_window_apply)
3582 (resize_frame_windows, Fsplit_window_internal)
3583 (Fdelete_window_internal, Fresize_mini_window_internal):
3585 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3587 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3589 * window.h (window): Add some new members to window structure -
3590 normal_lines, normal_cols, new_total, new_normal, clone_number,
3591 splits, nest, prev_buffers, next_buffers.
3592 (WINDOW_TOTAL_SIZE): Move here from window.c.
3593 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3595 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3597 (make_dummy_parent): Set new members of windows structure.
3598 (make_window): Move down in code. Handle new members of window
3600 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3601 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3602 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3603 (Fset_window_prev_buffers, Fwindow_next_buffers)
3604 (Fset_window_next_buffers, Fset_window_clone_number):
3606 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3607 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3609 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3610 Argument WINDOW can be now internal window too.
3611 (Fwindow_use_time): Move up in code.
3612 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3614 (Fset_window_configuration, saved_window)
3615 (Fcurrent_window_configuration, save_window_save): Handle new
3616 members of window structure.
3617 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3618 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3619 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3620 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3621 Qget_mru_window, Qresize_root_window,
3622 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3623 Qauto_buffer_name; staticpro them.
3625 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3627 * window.c (Fwindow_total_size, Fwindow_left_column)
3628 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3629 (Fwindow_list_1): New functions.
3630 (window_box_text_cols): Replace with window_body_cols.
3631 (Fwindow_width, Fscroll_left, Fscroll_right):
3632 Use window_body_cols instead of window_box_text_cols.
3633 (delete_window, Fset_window_configuration):
3634 Call delete_all_subwindows with window as argument.
3635 (delete_all_subwindows): Take a window as argument and not a
3637 (window_loop): Remove handling of GET_LRU_WINDOW and
3639 (Fget_lru_window, Fget_largest_window): Move to window.el.
3641 * window.h: Extern window_body_cols instead of
3642 window_box_text_cols. delete_all_subwindows now takes a
3643 Lisp_Object as argument.
3645 * indent.c (compute_motion, Fcompute_motion):
3646 Use window_body_cols instead of window_box_text_cols.
3648 * frame.c (delete_frame): Call delete_all_subwindows with root
3651 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3653 * fns.c (Fputhash): Document return value.
3655 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3657 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3659 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3661 Cons<->int and similar integer overflow fixes (Bug#8794).
3663 Check for overflow when converting integer to cons and back.
3664 * charset.c (Fdefine_charset_internal, Fdecode_char):
3665 Use cons_to_unsigned to catch overflow.
3666 (Fencode_char): Use INTEGER_TO_CONS.
3667 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3668 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3669 * data.c (long_to_cons, cons_to_long): Remove.
3670 (cons_to_unsigned, cons_to_signed): New functions.
3671 These signal an error for invalid or out-of-range values.
3672 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3673 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3674 * font.c (Ffont_variation_glyphs):
3675 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3676 * lisp.h: Include <intprops.h>.
3677 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3678 (cons_to_signed, cons_to_unsigned): New decls.
3679 (long_to_cons, cons_to_long): Remove decls.
3680 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3681 (Fprimitive_undo): Use CONS_TO_INTEGER.
3682 * xfns.c (Fx_window_property): Likewise.
3683 * xselect.c: Include <limits.h>.
3684 (x_own_selection, selection_data_to_lisp_data):
3685 Use INTEGER_TO_CONS.
3686 (x_handle_selection_request, x_handle_selection_clear)
3687 (x_get_foreign_selection, Fx_disown_selection_internal)
3688 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3689 (lisp_data_to_selection_data): Use cons_to_unsigned.
3690 (x_fill_property_data): Use cons_to_signed.
3691 Report values out of range.
3693 Check for buffer and string overflow more precisely.
3694 * buffer.h (BUF_BYTES_MAX): New macro.
3695 * lisp.h (STRING_BYTES_MAX): New macro.
3696 * alloc.c (Fmake_string):
3697 * character.c (string_escape_byte8):
3698 * coding.c (coding_alloc_by_realloc):
3699 * doprnt.c (doprnt):
3700 * editfns.c (Fformat):
3702 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3703 since they may not be the same number.
3704 * editfns.c (Finsert_char):
3705 * fileio.c (Finsert_file_contents):
3706 Likewise for BUF_BYTES_MAX.
3708 * image.c: Use ptrdiff_t, not int, for sizes.
3709 (slurp_file): Switch from int to ptrdiff_t.
3711 (slurp_file): Check that file size fits in both size_t (for
3712 malloc) and ptrdiff_t (for sanity and safety).
3714 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3715 if b->modtime has its maximal value.
3717 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3719 Don't assume time_t can fit into int.
3720 * buffer.h (struct buffer.modtime): Now time_t, not int.
3721 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3722 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3724 Minor fixes for signed vs unsigned integers.
3725 * character.h (MAYBE_UNIFY_CHAR):
3726 * charset.c (maybe_unify_char):
3727 * keyboard.c (read_char, reorder_modifiers):
3728 XINT -> XFASTINT, since the integer must be nonnegative.
3729 * ftfont.c (ftfont_spec_pattern):
3730 * keymap.c (access_keymap, silly_event_symbol_error):
3731 XUINT -> XFASTINT, since the integer must be nonnegative.
3732 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3733 since it makes no difference and we prefer signed.
3734 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3735 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3738 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3740 * window.h (Fwindow_frame): Declare.
3742 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3744 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3745 (SPARE_MEMORY): Always define.
3746 (LARGE_REQUEST): Remove.
3747 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3749 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3751 * lisp.h: Move EXFUNS for Fframe_root_window,
3752 Fframe_first_window and Fset_frame_selected_window to window.h.
3754 * window.h: Move EXFUNS for Fframe_root_window,
3755 Fframe_first_window and Fset_frame_selected_window here from
3758 * frame.c (Fwindow_frame, Fframe_first_window)
3759 (Fframe_root_window, Fframe_selected_window)
3760 (Fset_frame_selected_window): Move to window.c.
3761 (Factive_minibuffer_window): Move to minibuf.c.
3762 (Fother_visible_frames_p): New function.
3764 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3766 * window.c (decode_window, decode_any_window): Move up in code.
3767 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3768 (inhibit_frame_unsplittable): Remove unused variable.
3769 (Fwindow_buffer): Move up and rewrite doc-string.
3770 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3771 (Fwindow_prev): New functions.
3772 (Fwindow_frame): Move here from frame.c. Accept any window as
3774 (Fframe_root_window, Fframe_first_window)
3775 (Fframe_selected_window): Move here from frame.c. Accept frame
3776 or arbitrary window as argument. Update doc-strings.
3777 (Fminibuffer_window): Move up in code.
3778 (Fwindow_minibuffer_p): Move up in code and simplify.
3779 (Fset_frame_selected_window): Move here from frame.c.
3781 (Fselected_window, select_window, Fselect_window): Move up in
3782 code. Minor doc-string fixes.
3784 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3786 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3787 Do not assume that spare memory exists; that assumption is valid
3788 only if SYSTEM_MALLOC.
3789 (LARGE_REQUEST): New macro, so that the issue of large requests
3790 is separated from the issue of spare memory.
3792 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3794 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3797 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3799 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3802 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3804 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3806 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3808 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3809 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3811 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3813 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3815 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3817 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3818 (x_clipboard_manager_save): Add return value.
3819 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3821 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3822 Obey Vx_select_enable_clipboard_manager. Catch errors in
3823 x_clipboard_manager_save (Bug#8779).
3824 (Vx_select_enable_clipboard_manager): New variable.
3825 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3827 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3829 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3831 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3833 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3834 in the current matrix if keep_current_p is non-zero.
3836 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3838 * bidi.c (bidi_level_of_next_char): Fix last change.
3840 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3842 Support bidi reordering of text covered by display properties.
3844 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3845 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3846 (bidi_cache_search, bidi_cache_iterator_state)
3847 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3848 (bidi_level_of_next_char, bidi_move_to_visually_next):
3849 Support character positions inside a run of characters covered by a
3851 (bidi_paragraph_init, bidi_resolve_explicit_1)
3852 (bidi_level_of_next_char): Call bidi_fetch_char and
3853 bidi_fetch_char_advance instead of FETCH_CHAR and
3855 (bidi_init_it): Initialize new members.
3856 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3858 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3859 instead of using explicit *_CHAR codes.
3860 (bidi_resolve_explicit, bidi_resolve_weak):
3861 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3862 bidirectional text is supported only in multibyte buffers.
3863 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3864 it to initialize the frame_window_p member of struct bidi_it.
3865 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3866 (bidi_resolve_explicit, bidi_resolve_weak)
3867 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3868 bidi_it->nchars is non-positive.
3869 (bidi_level_of_next_char): Don't try to lookup the cache for the
3870 next/previous character if nothing is cached there yet, or if we
3871 were just reseat()'ed to a new position.
3873 * xdisp.c (set_cursor_from_row): Set start and stop points
3874 according to the row's direction when priming the loop that looks
3875 for the glyph on which to display cursor.
3876 (single_display_spec_intangible_p): Function deleted.
3877 (display_prop_intangible_p): Reimplement to call
3878 handle_display_spec instead of single_display_spec_intangible_p.
3879 Accept 3 additional arguments needed by handle_display_spec.
3880 This fixes incorrect cursor motion across display property with complex
3881 values: lists, `(when COND...)' forms, etc.
3882 (single_display_spec_string_p): Support property values that are
3883 lists with the argument STRING its top-level element.
3884 (display_prop_string_p): Fix the condition for processing a
3885 property that is a list to be consistent with handle_display_spec.
3886 (handle_display_spec): New function, refactored from the
3887 last portion of handle_display_prop.
3888 (compute_display_string_pos): Accept additional argument
3889 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3890 value of a `display' property is a "replacing spec".
3891 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3892 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3893 the display property, but just return a value indicating whether
3894 the display property will replace the characters it covers.
3895 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3896 frame_window_p members of struct bidi_it.
3897 (compute_display_string_pos, compute_display_string_end):
3899 (push_it): Accept second argument POSITION, where pop_it should
3900 jump to continue iteration.
3901 (reseat_1): Initialize bidi_it.disp_pos.
3903 * keyboard.c (adjust_point_for_property): Adjust the call to
3904 display_prop_intangible_p to its new signature.
3906 * dispextern.h (struct bidi_it): New member frame_window_p.
3907 (bidi_init_it): Update prototypes.
3908 (display_prop_intangible_p): Update prototype.
3909 (compute_display_string_pos, compute_display_string_end):
3911 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3914 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3916 Malloc failure behavior now depends on size of allocation.
3917 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3918 * lisp.h: Change signatures accordingly.
3919 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3920 All callers changed. (Bug#8762)
3922 * gnutls.c: Use Emacs's memory allocators.
3923 Without this change, the gnutls library would invoke malloc etc.
3924 directly, which causes problems on non-SYNC_INPUT hosts, and which
3925 runs afoul of improving memory_full behavior. (Bug#8761)
3926 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3927 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3928 xfree instead of the default malloc, realloc, free.
3929 (Fgnutls_boot): No need to check for memory allocation failure,
3930 since xmalloc does that for us.
3932 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3933 * category.c (hash_get_category_set):
3934 * ccl.c (ccl_driver):
3935 * charset.c (Fdefine_charset_internal):
3936 * charset.h (struct charset.hash_index):
3937 * composite.c (get_composition_id, gstring_lookup_cache)
3938 (composition_gstring_put_cache):
3939 * composite.h (struct composition.hash_index):
3940 * dispextern.h (struct image.hash):
3941 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3942 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3943 (hashfn_equal, hashfn_user_defined, make_hash_table)
3944 (maybe_resize_hash_table, hash_lookup, hash_put)
3945 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3946 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3947 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3948 * image.c (make_image, search_image_cache, lookup_image)
3949 (xpm_put_color_table_h):
3950 * lisp.h (struct Lisp_Hash_Table):
3951 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3952 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3953 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3954 * alloc.c (allocate_vectorlike):
3955 Check for overflow in vector size calculations.
3956 * ccl.c (ccl_driver):
3957 Check for overflow when converting EMACS_INT to int.
3958 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3959 need to be updated by these changes.
3960 * fns.c (make_hash_table, maybe_resize_hash_table):
3961 Check for integer overflow with large hash tables.
3962 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3963 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3964 (SXHASH_REDUCE): New macro.
3965 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3966 Use it instead of discarding useful hash info with large hash values.
3967 (sxhash_float): New function.
3968 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3969 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3970 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3971 Rewrite to use FIXNUM_BITS, as this simplifies things.
3972 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3973 Adjust signatures to match updated version of code.
3974 (consing_since_gc): Now EMACS_INT, since a single hash table can
3975 use more than INT_MAX bytes.
3977 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3979 Make it possible to build with GCC-4.6+ -O2 -flto.
3981 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3983 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3985 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3986 Call minibuffer-inactive-mode.
3988 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3990 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3991 Update dependencies.
3993 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3995 * data.c (init_data): Remove code for UTS, this system is not
3998 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4000 Don't force ./temacs to start in terminal mode.
4002 * frame.c (make_initial_frame): Initialize faces in all cases, not
4003 only when CANNOT_DUMP is defined.
4004 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4006 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4008 * dispnew.c (add_window_display_history): Use const for the string
4009 pointer. Remove declaration, not needed.
4011 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4013 Use 'inline', not 'INLINE'.
4014 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4015 * alloc.c, fontset.c (INLINE): Remove.
4016 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4017 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4018 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4019 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4020 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4022 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4024 Make it possible to run ./temacs.
4026 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4027 syms_of_callproc does the same thing. Remove test for
4028 "initialized", do it in the caller.
4029 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4031 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4033 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4034 (read_minibuf): Use get_minibuffer.
4035 (syms_of_minibuf): Use DEFSYM.
4036 (Qmetadata): New var.
4037 * data.c (Qbuffer): Don't make it static.
4038 (syms_of_data): Use DEFSYM.
4040 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4042 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4043 (CCL_CODE_MIN): New macro.
4045 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4047 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4049 * eval.c (Qdebug): Now static.
4050 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4051 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4052 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4054 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4056 * image.c: Various fixes to ImageMagick code comments.
4057 (Fimagemagick_types): Doc fix.
4059 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4061 Minor fixes prompted by GCC 4.6.0 warnings.
4063 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4065 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4066 (x_clipboard_manager_save_all): Move extern decl to ...
4067 * xterm.h: ... here, so that it can be checked for consistency.
4069 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4071 * xselect.c (x_clipboard_manager_save_frame)
4072 (x_clipboard_manager_save_all): New functions.
4073 (Fx_clipboard_manager_save): Lisp function deleted.
4075 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4076 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4078 * xterm.h: Update prototype.
4080 2011-05-28 William Xu <william.xwl@gmail.com>
4082 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4085 2011-05-28 Jim Meyering <meyering@redhat.com>
4087 Avoid a sign-extension bug in crypto_hash_function.
4088 * fns.c (to_uchar): Define.
4089 (crypto_hash_function): Use it to convert some newly-signed
4090 variables to unsigned, to avoid sign-extension bugs. For example,
4091 without this change, (md5 "truc") would evaluate to
4092 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4093 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4094 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4096 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4098 Integer overflow fixes.
4100 * dbusbind.c: Serial number integer overflow fixes.
4101 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4102 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4103 to hold a serial number that is too large for a fixnum.
4104 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4105 Check for serial numbers out of range. Decode any serial number
4106 that was so large that it became a float. (Bug#8722)
4108 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4109 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4110 Use XFASTINT rather than XUINT when numbers are nonnegative.
4111 (xd_append_arg, Fdbus_method_return_internal):
4112 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4113 arguments, check that Lisp number is nonnegative, rather than
4114 silently wrapping negative numbers around. (Bug#8722)
4115 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4118 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4120 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4122 ccl: add integer overflow checks
4123 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4124 (IN_INT_RANGE): New macros.
4125 (ccl_driver): Use them to check for integer overflow when
4126 decoding a CCL program. Many of the new checks are whether XINT (x)
4127 fits in int; it doesn't always, on 64-bit hosts. The new version
4128 doesn't catch all possible integer overflows, but it's an
4129 improvement. (Bug#8719)
4131 * alloc.c (make_event_array): Use XINT, not XUINT.
4132 There's no need for unsigned here.
4134 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4135 This follows up to the 2011-05-06 change that substituted uintptr_t
4136 for EMACS_INT. This case wasn't caught back then.
4138 Rework Fformat to avoid integer overflow issues.
4139 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4140 now (part of C89). Include <verify.h>.
4141 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4142 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4143 (Fformat): Avoid the prepass trying to compute sizes; it was only
4144 approximate and thus did not catch overflow reliably. Instead, walk
4145 through the format just once, formatting and computing sizes as we go,
4146 checking for integer overflow at every step, and allocating a larger
4147 buffer as needed. Keep track separately whether the format is
4148 multibyte. Keep only the most-recently calculated precision, rather
4149 than them all. Record whether each argument has been converted to
4150 string. Use EMACS_INT, not int, for byte and char and arg counts.
4151 Support field widths and precisions larger than INT_MAX. Avoid
4152 sprintf's undefined behavior with conversion specifications such as %#d
4153 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4154 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4155 formatting out-of-range floating point numbers with int
4158 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4160 * data.c: Avoid integer truncation in expressions involving floats.
4161 * data.c: Include <intprops.h>.
4162 (arith_driver): When there's an integer overflow in an expression
4163 involving floating point, convert the integers to floating point
4164 so that the resulting value does not suffer from catastrophic
4165 integer truncation. For example, on a 64-bit host (* 4
4166 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4167 Do not rely on undefined behavior after integer overflow.
4169 merge count_size_as_multibyte, parse_str_to_multibyte
4170 * character.c, character.h (count_size_as_multibyte):
4171 Rename from parse_str_to_multibyte; all uses changed.
4172 Check for integer overflow.
4173 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4174 since it's now a duplicate of the other. This is more of
4175 a character than a buffer op, so better that it's in character.c.
4176 * fns.c, print.c: Adjust to above changes.
4178 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4180 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4182 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4184 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4185 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4186 (x_clipboard_manager_save): Now static.
4187 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4189 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4190 (crypto_hash_function): Now static.
4191 Fix pointer signedness problems. Avoid unnecessary initializations.
4193 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4195 * termhooks.h (Vselection_alist): Make it terminal-local.
4197 * terminal.c (create_terminal): Initialize it.
4199 * xselect.c: Support for clipboard managers.
4200 (Vselection_alist): Move to termhooks.h as terminal-local var.
4201 (LOCAL_SELECTION): New macro.
4202 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4203 (symbol_to_x_atom): Remove gratuitous arg.
4204 (x_handle_selection_request, lisp_data_to_selection_data)
4205 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4206 (x_own_selection, x_get_local_selection, x_convert_selection):
4207 New arg, specifying work frame. Use terminal-local Vselection_alist.
4208 (some_frame_on_display): Delete unused function.
4209 (Fx_own_selection_internal, Fx_get_selection_internal)
4210 (Fx_disown_selection_internal, Fx_selection_owner_p)
4211 (Fx_selection_exists_p): New optional frame arg.
4212 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4213 (x_handle_selection_clear): Don't treat other terminals with the
4214 same keyboard specially. Use the terminal-local Vselection_alist.
4215 (x_clear_frame_selections): Use Frun_hook_with_args.
4217 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4219 * xterm.h: Add support for those atoms.
4221 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4223 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4224 (converted_selections, conversion_fail_tag): New global variables.
4225 (x_selection_request_lisp_error): Free the above.
4226 (x_get_local_selection): Remove unnecessary code.
4227 (x_reply_selection_request): Args changed; handle arbitrary array
4228 of converted selections stored in converted_selections.
4229 Separate the XChangeProperty and SelectionNotify steps.
4230 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4231 (x_convert_selection): New function.
4232 (x_handle_selection_event): Simplify.
4233 (x_get_foreign_selection): Don't ignore incoming requests while
4234 waiting for an answer; this will fail when we implement
4235 SAVE_TARGETS, and seems unnecessary anyway.
4236 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4237 (Vx_sent_selection_functions): Doc fix.
4239 2011-05-26 Leo Liu <sdl.web@gmail.com>
4241 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4243 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4245 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4247 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4248 for fringe update if it has periodic bitmap.
4249 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4250 and fringe_bitmap_periodic_p.
4252 * fringe.c (get_fringe_bitmap_data): New function.
4253 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4254 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4255 row. Mark glyph row for fringe update if periodicity changed.
4257 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4258 for fringe update unless it has periodic bitmap.
4260 2011-05-25 Kenichi Handa <handa@m17n.org>
4262 * xdisp.c (get_next_display_element): Set correct it->face_id for
4263 a static composition.
4265 2011-05-24 Leo Liu <sdl.web@gmail.com>
4268 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4270 * fns.c (crypto_hash_function, Fsha1): New function.
4271 (Fmd5): Use crypto_hash_function.
4272 (syms_of_fns): Add Ssha1.
4274 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4276 * gnutls.c: Remove unused macros.
4277 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4278 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4279 Remove macros that are defined and never used.
4280 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4282 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4284 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4285 (Fx_get_selection_internal): Minor cleanup.
4286 (Fx_own_selection_internal): Rename arguments for consistency with
4289 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4291 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4293 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4295 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4297 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4299 * dispnew.c (scrolling_window): Don't exclude the case that the
4300 last enabled row in the desired matrix touches the bottom boundary.
4302 2011-05-21 Glenn Morris <rgm@gnu.org>
4304 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4305 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4306 and add some more files.
4308 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4310 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4311 report_file_error introduced by the change from 2011-05-07.
4313 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4315 * systime.h (Time): Define only if emacs is defined.
4316 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4317 where the include path doesn't have X11/X.h by default. See
4318 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4320 2011-05-20 Kenichi Handa <handa@m17n.org>
4322 * composite.c (find_automatic_composition): Fix previous change.
4324 2011-05-20 Glenn Morris <rgm@gnu.org>
4326 * lisp.mk: New file, split from Makefile.in.
4327 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4328 (shortlisp): Remove.
4329 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4331 2011-05-19 Glenn Morris <rgm@gnu.org>
4333 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4334 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4335 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4336 (lisp): Set the order to that of loadup.el.
4337 (shortlisp): Make it a copy of $lisp.
4338 (SOME_MACHINE_LISP): Remove.
4339 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4340 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4342 2011-05-18 Kenichi Handa <handa@m17n.org>
4344 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4345 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4346 (find_automatic_composition): Mostly rewrite for efficiency.
4348 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4350 * makefile.w32-in: Update dependencies.
4352 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4354 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4355 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4357 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4359 Fix some integer overflow issues, such as string length overflow.
4361 * insdel.c (count_size_as_multibyte): Check for string overflow.
4363 * character.c (lisp_string_width): Check for string overflow.
4364 Use EMACS_INT, not int, for string indexes and lengths; in
4365 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4366 the resulting string length overflows an EMACS_INT; instead,
4367 report a string overflow if no precision given. When checking for
4368 precision exhaustion, use a check that cannot possibly have
4369 integer overflow. (Bug#8675)
4370 * character.h (lisp_string_width): Adjust to new signature.
4372 * alloc.c (string_overflow): New function.
4373 (Fmake_string): Use it. This doesn't change behavior, but saves
4374 a few bytes and will simplify future changes.
4375 * character.c (string_escape_byte8): Likewise.
4376 * lisp.h (string_overflow): New decl.
4378 Fixups, following up to the user-interface timestamp change.
4379 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4380 for UI timestamps, instead of unsigned long.
4381 * msdos.c (mouse_get_pos): Likewise.
4382 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4383 * w32gui.h (Time): Define by including "systime.h" rather than by
4384 declaring it ourselves. (Bug#8664)
4386 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4387 * image.c (clear_image_cache): Likewise.
4389 * term.c (term_mouse_position): Don't assume time_t wraparound.
4391 Be more systematic about user-interface timestamps.
4392 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4393 and sometimes 'EMACS_UINT', to represent these timestamps.
4394 This change causes it to use 'Time' uniformly, as that's what X uses.
4395 This makes the code easier to follow, and makes it easier to catch
4396 integer overflow bugs such as Bug#8664.
4397 * frame.c (Fmouse_position, Fmouse_pixel_position):
4398 Use Time, not unsigned long, for user-interface timestamps.
4399 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4400 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4401 * keyboard.h (last_event_timestamp): Likewise.
4402 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4403 * menu.h (xmenu_show): Likewise.
4404 * term.c (term_mouse_position): Likewise.
4405 * termhooks.h (struct input_event.timestamp): Likewise.
4406 (struct terminal.mouse_position_hook): Likewise.
4407 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4408 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4409 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4410 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4412 * menu.h, termhooks.h: Include "systime.h", for Time.
4414 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4415 Don't assume that the difference between two unsigned long values
4416 can fit into an integer. At this point, we know button_down_time
4417 <= event->timestamp, so the difference must be nonnegative, so
4418 there's no need to cast the result if double-click-time is
4419 nonnegative, as it should be; check that it's nonnegative, just in
4420 case. This bug is triggered when events are more than 2**31 ms
4421 apart (about 25 days). (Bug#8664)
4423 * xselect.c (last_event_timestamp): Remove duplicate decl.
4424 (x_own_selection): Remove needless cast to unsigned long.
4426 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4427 that always fit in int. Use a sentinel instead of a counter, to
4428 avoid a temp and to allay GCC's concerns about possible int overflow.
4429 * frame.h (struct frame): Use int for menu_bar_items_used
4430 instead of EMACS_INT, since it always fits in int.
4432 * menu.c (grow_menu_items): Check for int overflow.
4434 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4436 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4437 Before, the code was not consistent. These values cannot exceed
4438 2**31 - 1 so there's no need to make them unsigned.
4439 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4440 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4441 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4443 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4445 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4446 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4447 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4448 presumably because the widths might not match.
4450 * window.c (size_window): Avoid needless test at loop start.
4452 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4454 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4456 2011-05-12 Drew Adams <drew.adams@oracle.com>
4458 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4460 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4462 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4463 `width' to `bar_area_x' and `bar_area_width', respectively.
4464 (x_scroll_run): Take account of fringe background extension.
4466 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4467 Rename local vars `left' and `width' to `bar_area_x' and
4468 `bar_area_width', respectively.
4469 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4470 background extension.
4472 2011-05-10 Jim Meyering <meyering@redhat.com>
4474 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4476 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4478 * image.c (Finit_image_library): Return t for built-in image types,
4479 like pbm and xbm. (Bug#8640)
4481 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4483 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4485 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4487 * w32console.c (Fset_screen_color): Doc fix.
4488 (Fget_screen_color): New function.
4489 (syms_of_ntterm): Defsubr it.
4491 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4492 unlink the temporary file if Fcall_process didn't create it in the
4494 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4495 child process will be redirected to a file specified with `:file'.
4496 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4497 cue to call_process_cleanup not to close that handle.
4499 2011-05-07 Ben Key <bkey76@gmail.com>
4501 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4502 one of two shell specific rules, either bootstrap-temacs-CMD or
4503 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4504 to the previous implementation of the bootstrap-temacs rule.
4505 The bootstrap-temacs-CMD rule is similar to the previous
4506 implementation of the bootstrap-temacs rule except that it
4507 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4510 These changes, along with some changes to nt/configure.bat,
4511 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4512 earlier fix to add support for --cflags and --ldflags options
4513 that include quotes so that it works whether make uses cmd or
4516 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4518 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4519 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4521 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4522 a string. Handle both cases.
4523 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4524 (Fdbus_register_method): Use Qinvalid_function.
4526 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4528 * makefile.w32-in: Update dependencies.
4529 (LISP_H): Add inttypes.h and stdin.h.
4530 (PROCESS_H): Add unistd.h.
4532 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4534 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4535 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4537 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4539 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4541 * term.c (vfatal): Remove stray call to va_end.
4542 It's not needed and the C Standard doesn't allow it here anyway.
4544 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4545 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4547 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4550 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4552 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4554 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4556 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4558 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4560 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4561 * charset.c (Fdefine_charset_internal): Don't initialize
4562 charset.code_space[15]. The value was garbage, on hosts with
4563 32-bit int (Bug#8600).
4565 * lread.c (read_integer): Be more consistent with string-to-number.
4566 Use string_to_number to do the actual conversion; this avoids
4567 rounding errors and fixes some other screwups. Without this fix,
4568 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4569 (digit_to_number): Move earlier, for benefit of read_integer.
4570 Return -1 if the digit is out of range for the base, -2 if it is
4571 not a digit in any supported base. (Bug#8602)
4573 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4575 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4576 to match comment at start of function. This also removes a
4577 GCC warning about overflow in a 32+64-bit port.
4579 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4581 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4582 Reported by Stefan Monnier in
4583 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4584 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4585 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4587 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4588 (EMACS_UINTPTR): Likewise, with uintptr_t.
4590 * lisp.h: Prefer 64-bit EMACS_INT if available.
4591 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4592 on 32-bit hosts that have 64-bit int, so that they can access
4594 However, temporarily disable this change unless the temporary
4595 symbol WIDE_EMACS_INT is defined.
4597 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4599 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4600 This removes an assumption that EMACS_INT and long are the same
4601 width as pointers. The assumption is true for Emacs porting targets
4602 now, but we want to make other targets possible.
4603 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4604 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4605 In the rest of the code, change types of integers that hold casted
4606 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4607 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4608 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4609 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4610 No need to cast type when ORing.
4611 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4612 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4613 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4614 assume EMACS_INT is the same width as char *.
4615 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4616 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4617 Remove no-longer-needed casts.
4618 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4619 (xg_tool_bar_help_callback, xg_make_tool_item):
4620 Use EMACS_INTPTR to hold an integer
4621 that will be cast to void *; this can avoid a GCC warning
4622 if EMACS_INT is not the same width as void *.
4623 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4624 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4625 (current_message_1, set_message_1):
4626 Use a local to convert to proper width without a cast.
4627 * xmenu.c (dialog_selection_callback): Likewise.
4629 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4630 Also, don't assume VALBITS / RAND_BITS is less than 5,
4631 and don't rely on undefined behavior when shifting a 1 left into
4633 * lisp.h (get_random): Change signature to match.
4635 * lread.c (hash_string): Use size_t, not int, for hash computation.
4636 Normally we prefer signed values; but hashing is special, because
4637 it's better to use unsigned division on hash table sizes so that
4638 the remainder is nonnegative. Also, size_t is the natural width
4639 for hashing into memory. The previous code used 'int', which doesn't
4640 retain enough info to hash well into very large tables.
4641 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4643 * dbusbind.c: Don't possibly lose pointer info when converting.
4644 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4645 Use XPNTR rather than XHASH, so that the high-order bits of
4646 the pointer aren't lost when converting through void *.
4648 * eval.c (Fautoload): Don't double-shift a pointer.
4650 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4652 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4654 * gnutls.c (DEF_GNUTLS_FN):
4655 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4657 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4659 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4662 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4664 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4665 New version that can reserve upto 2GB of heap space.
4667 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4669 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4671 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4673 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4674 `gnutls_certificate_set_x509_key_file'.
4676 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4678 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4679 Update dependencies.
4681 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4683 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4684 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4685 Remove unused parameter `fildes'.
4686 * process.c (read_process_output, send_process): Don't pass it.
4688 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4690 Fix previous change: the library cache is defined in w32.c.
4691 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4692 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4694 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4696 Implement dynamic loading of GnuTLS on Windows.
4698 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4699 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4700 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4703 * gnutls.c (Qgnutls_dll): Define.
4704 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4705 (gnutls_*): Declare function pointers.
4706 (init_gnutls_functions): New function to initialize function pointers.
4707 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4708 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4709 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4710 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4711 (emacs_gnutls_write, emacs_gnutls_read)
4712 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4713 (Fgnutls_available_p): New function.
4714 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4715 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4716 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4718 * image.c: Include w32.h.
4719 (Vimage_type_cache): Delete.
4720 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4721 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4722 (w32_delayed_load): Move to w32.c.
4724 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4726 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4727 (w32_delayed_load): Move from image.c. When loading a library, record
4728 its filename in the :loaded-from property of the library id.
4729 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4730 Initialize and staticpro them.
4731 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4733 * process.c: Include lisp.h before w32.h, not after.
4734 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4735 instead of gnutls_record_check_pending.
4737 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4739 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4741 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4742 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4745 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4747 * xterm.c (x_set_frame_alpha): Do not set property on anything
4748 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4750 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4752 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4754 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4756 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4757 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4758 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4759 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4760 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4761 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4762 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4763 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4764 (Qgnutls_bootprop_callbacks_verify): Make static.
4766 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4768 * callproc.c: Indentation fixup.
4770 * sysdep.c (wait_for_termination_1): Make static.
4771 (wait_for_termination, interruptible_wait_for_termination):
4772 Move after wait_for_termination_1.
4774 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4776 * sysdep.c (interruptible_wait_for_termination): New function
4777 which is like wait_for_termination, but allows keyboard
4780 * callproc.c (Fcall_process): Add (:file "file") as an option for
4782 (Fcall_process_region): Ditto.
4784 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4786 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4787 rather than `XVECTOR (FOO)->size'.
4789 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4790 inttypes.h, as a gnulib replacement is used if it not available in
4793 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4795 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4796 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4797 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4799 * coding.c (coding_alloc_by_realloc): Error out if destination
4800 will grow beyond MOST_POSITIVE_FIXNUM.
4801 (decode_coding_emacs_mule): Abort if there isn't enough place in
4802 charbuf for the composition carryover bytes. Reserve an extra
4803 space for up to 2 characters produced in a loop.
4804 (decode_coding_iso_2022): Abort if there isn't enough place in
4805 charbuf for the composition carryover bytes.
4807 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4809 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4810 aborting when %lld or %lll format is passed.
4811 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4812 %llo or %llx format is passed. (Bug#8545)
4814 * window.c (window_scroll_line_based): Use a marker instead of
4815 simple variables to record original value of point. (Bug#7952)
4817 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4818 produced by %s or %c overflows available buffer space. (Bug#8545)
4820 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4822 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4823 (SIZE_MAX): Move defn after all includes, as they might #define it.
4825 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4827 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4829 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4831 * keyboard.c (Qdelayed_warnings_hook): Define.
4832 (command_loop_1): Run `delayed-warnings-hook'
4833 if Vdelayed_warnings_list is non-nil.
4834 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4835 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4837 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4839 * doprnt.c (doprnt): Don't return value smaller than the buffer
4840 size if the message was truncated. (Bug#8545).
4842 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4844 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4845 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4847 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4849 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4851 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4853 * makefile.w32-in: Update dependencies.
4855 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4857 Improve `doprnt' and its usage. (Bug#8545)
4858 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4859 `format_end'. Remove support for %l as a conversion specifier.
4860 Don't use xrealloc. Improve diagnostics when the %l size modifier
4861 is used. Update the commentary.
4863 * eval.c (verror): Simplify calculation of size_t.
4865 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4868 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4870 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4873 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4875 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4876 This makes this file independent of the recent pseudovector change.
4878 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4880 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4882 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4883 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4884 Remove unused local.
4885 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4887 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4888 GCC 4.6.0 optimizes based on type-based alias analysis.
4889 For example, if b is of type struct buffer * and v of type struct
4890 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4891 != &v->size, and therefore "v->size = 1; b->size = 2; return
4892 v->size;" must therefore return 1. This assumption is incorrect
4893 for Emacs, since it type-puns struct Lisp_Vector * with many other
4894 types. To fix this problem, this patch adds a new type struct
4895 vectorlike_header that documents the constraints on layout of vectors
4896 and pseudovectors, and helps optimizing compilers not get fooled
4897 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4898 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4899 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4901 (XSETPVECTYPE): Rewrite in terms of new macro.
4902 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4903 This is a bit clearer, and further avoids the possibility of
4904 undesirable aliasing.
4905 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4906 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4907 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4908 since Lisp_Subr is a special case (no "next" field).
4909 (ASIZE): Now uses header.size rather than size.
4910 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4911 to avoid the hassle of writing XVECTOR (foo)->header.size.
4912 (struct vectorlike_header): New type.
4913 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4914 object, to help avoid aliasing.
4915 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4916 (SUBRP): Likewise, since Lisp_Subr is a special case.
4917 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4918 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4919 (struct Lisp_Hash_Table): Combine first two members into a single
4920 struct vectorlike_header member. All uses of "size" and "next" members
4921 changed to be "header.size" and "header.next".
4922 * buffer.h (struct buffer): Likewise.
4923 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4924 * frame.h (struct frame): Likewise.
4925 * process.h (struct Lisp_Process): Likewise.
4926 * termhooks.h (struct terminal): Likewise.
4927 * window.c (struct save_window_data, struct saved_window): Likewise.
4928 * window.h (struct window): Likewise.
4929 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4930 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4931 * buffer.c (init_buffer_once): Likewise.
4932 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4934 * process.c (Fformat_network_address): Use local var for size,
4937 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4939 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4940 * data.c (atof): Remove decl; no longer used or needed.
4941 (digit_to_number): Move to lread.c.
4942 (Fstring_to_number): Use new string_to_number function, to be
4943 consistent with how the Lisp reader treats infinities and NaNs.
4944 Do not assume that floating-point numbers represent EMACS_INT
4945 without losing information; this is not true on most 64-bit hosts.
4946 Avoid double-rounding errors, by insisting on integers when
4947 parsing non-base-10 numbers, as the documentation specifies.
4948 * lisp.h (string_to_number): New decl, replacing ...
4949 (isfloat_string): Remove.
4950 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4951 (read1): Do not accept +. and -. as integers; this
4952 appears to have been a coding error. Similarly, do not accept
4953 strings like +-1e0 as floating point numbers. Do not report
4954 overflow for integer overflows unless the base is not 10 which
4955 means we have no simple and reliable way to continue.
4956 Break out the floating-point parsing into a new
4957 function string_to_number, so that Fstring_to_number parses
4958 floating point numbers consistently with the Lisp reader.
4959 (digit_to_number): Move here from data.c. Make it static inline.
4960 (E_CHAR, EXP_INT): Remove, replacing with ...
4961 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4962 (string_to_number): New function, replacing isfloat_string.
4963 This function checks for valid syntax and produces the resulting
4964 Lisp float number too. Rework it so that string-to-number
4965 no longer mishandles examples like "1.0e+". Use strtoumax,
4966 so that overflow for non-base-10 numbers is reported only when
4967 there's no portable and simple way to convert to floating point.
4969 * textprop.c (set_text_properties_1): Rewrite for clarity,
4970 and to avoid GCC warning about integer overflow.
4972 * intervals.h (struct interval): Use EMACS_INT for members
4973 where EMACS_UINT might cause problems. See
4974 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4975 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4976 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4978 (offset_intervals): Tell GCC not to worry about length overflow
4979 when negating a negative length.
4981 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4982 (overrun_check_free): Likewise.
4984 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4985 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4988 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4989 (gnutls_make_error): Rename local to avoid shadowing.
4990 (gnutls_emacs_global_deinit): ifdef out; not used.
4991 (Fgnutls_boot): Use const for pointer to readonly storage.
4992 Comment out unused local. Fix pointer signedness problems.
4994 * lread.c (openp): Don't stuff size_t into an 'int'.
4995 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4996 about possible signed overflow.
4998 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4999 (GDK_KEY_g): Don't define if already defined.
5000 (xg_prepare_tooltip): Avoid pointer signedness problem.
5001 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5003 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5004 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5006 * xfns.c (Fx_window_property): Simplify a bit,
5007 to make a bit faster and to avoid GCC 4.6.0 warning.
5008 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5010 * fns.c (internal_equal): Don't assume size_t fits in int.
5012 * alloc.c (compact_small_strings): Tighten assertion a little.
5014 Replace pEd with more-general pI, and fix some printf arg casts.
5015 * lisp.h (pI): New macro, generalizing old pEd macro to other
5016 conversion specifiers. For example, use "...%"pI"d..." rather
5017 than "...%"pEd"...".
5018 (pEd): Remove. All uses replaced with similar uses of pI.
5019 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5020 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5021 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5022 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5023 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5024 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5025 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5027 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5028 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5029 * print.c (safe_debug_print, print_object): Likewise.
5030 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5032 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5033 avoiding the 0 flag, which is not portable.
5034 * process.c (Fmake_network_process): Use pI to avoid cast.
5035 * region-cache.c (pp_cache): Likewise.
5036 * xdisp.c (decode_mode_spec): Likewise.
5037 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5038 behavior on 64-bit hosts with printf arg.
5039 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5040 (x_stop_queuing_selection_requests): Likewise.
5041 (x_get_window_property): Don't truncate byte count to an 'int'
5044 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5045 here, since it parses constructs like leading '-' and spaces,
5046 which are not wanted; and it overflows with large numbers.
5047 Instead, simply match F[0-9]+, which is what is wanted anyway.
5049 * alloc.c: Remove unportable assumptions about struct layout.
5050 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5051 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5052 (allocate_vectorlike, make_pure_vector): Use the new macros,
5053 plus offsetof, to remove unportable assumptions about struct layout.
5054 These assumptions hold on all porting targets that I know of, but
5055 they are not guaranteed, they're easy to remove, and removing them
5056 makes further changes easier.
5058 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5059 This doesn't fix a bug but makes the code clearer.
5060 (string_overrun_cookie): Now const. Use initializers that
5061 don't formally overflow signed char, to avoid warnings.
5062 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5063 can cause Emacs to crash when string overrun checking is enabled.
5064 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5065 multiple of sizeof (EMACS_INT); it need not be, if
5066 alignof(EMACS_INT) < sizeof (EMACS_INT).
5067 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5069 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5071 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5073 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5075 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5076 supposed to be handshaking. (Bug#8556)
5077 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5079 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5081 * lisp.h (Qdebug): List symbol.
5082 * eval.c (Qdebug): Restore global linkage.
5083 * keyboard.c (debug-on-event): New variable.
5084 (handle_user_signal): Break into debugger when debug-on-event
5085 matches the current signal symbol.
5087 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5089 * alloc.c (check_sblock, check_string_bytes)
5090 (check_string_free_list): Convert to standard C.
5092 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5094 * w32.c (emacs_gnutls_push): Fix typo.
5096 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5098 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5099 "cast to pointer from integer of different size".
5101 Improve doprnt and its use in verror. (Bug#8545)
5102 * doprnt.c (doprnt): Document the set of format control sequences
5103 supported by the function. Use SAFE_ALLOCA instead of always
5106 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5107 is one byte too soon. Don't use xrealloc; instead xfree and
5110 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5112 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5115 * gnutls.c: Renamed global_initialized to
5116 gnutls_global_initialized. Added internals for the
5117 :verify-hostname-error, :verify-error, and :verify-flags
5118 parameters of `gnutls-boot' and documented those parameters in the
5119 docstring. Start callback support.
5120 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5121 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5122 on error. Return error code.
5123 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5124 (emacs_gnutls_read): Likewise.
5125 (Fgnutls_boot): Return handshake error code.
5126 (emacs_gnutls_handle_error): New function.
5127 (wsaerror_to_errno): Likewise.
5129 * w32.h (emacs_gnutls_pull): Add prototype.
5130 (emacs_gnutls_push): Likewise.
5132 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5133 (emacs_gnutls_push): Likewise.
5135 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5137 * process.c (wait_reading_process_output): Check if GnuTLS
5138 buffered some data internally if no FDs are set for TLS
5141 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5142 (LIBS): Link to USER_LIBS.
5143 ($(BLD)/gnutls.$(0)): New target.
5145 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5147 * xdisp.c (handle_single_display_spec): Rename the
5148 display_replaced_before_p argument into display_replaced_p, to
5149 make it consistent with the commentary. Fix typos in the
5152 * textprop.c (syms_of_textprop): Remove dead code.
5153 (copy_text_properties): Delete obsolete commentary about an
5154 interface that was deleted long ago. Fix typos in the description
5157 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5158 to changes in oldXMenu/XMenu.h from 2011-04-16.
5159 <menu_help_message, prev_menu_help_message>: Constify.
5160 (IT_menu_make_room): menu->help_text is now `const char **';
5163 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5164 to changes in oldXMenu/XMenu.h from 2011-04-16.
5165 (struct XMenu): Declare `help_text' `const char **'.
5167 * xfaces.c <Qunspecified>: Make extern again.
5169 * syntax.c: Include sys/types.h before including regex.h, as
5172 * doc.c (get_doc_string): Improve the format passed to `error'.
5174 * doprnt.c (doprnt): Improve commentary.
5176 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5178 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5181 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5182 changes in globals.h immediately force recompilation.
5183 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5184 $(CURDIR)/s/ms-w32.h.
5185 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5187 * character.c (Fchar_direction): Function deleted.
5188 (syms_of_character): Don't defsubr it.
5189 <char-direction-table>: Deleted.
5191 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5193 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5194 * doprnt.c: Include limits.h.
5195 (SIZE_MAX): New macro.
5196 (doprnt): Return a size_t value. 2nd arg is now size_t.
5197 Many local variables are now size_t instead of int or unsigned.
5198 Improve overflow protection. Support `l' modifier for integer
5199 conversions. Support %l conversion. Don't assume an EMACS_INT
5200 argument for integer conversions and for %c.
5202 * lisp.h (doprnt): Restore prototype.
5204 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5207 * Makefile.in (base_obj): Add back doprnt.o.
5209 * deps.mk (doprnt.o): Add back prerequisites.
5210 (callint.o): Depend on character.h.
5212 * eval.c (internal_lisp_condition_case): Include the handler
5213 representation in the error message.
5214 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5215 when breaking from the loop.
5217 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5219 * callint.c (Fcall_interactively): When displaying error message
5220 about invalid control letter, pass the character's codepoint, not
5221 a pointer to its multibyte form. Improve display of the character
5222 in octal and display also its hex code.
5224 * character.c (char_string): Use %x to display the (unsigned)
5225 codepoint of an invalid character, to avoid displaying a bogus
5228 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5229 `error', not SYMBOL_NAME itself.
5231 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5232 character arguments to `error'.
5234 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5235 to `error' in error message about FINAL_CHAR argument. Make sure
5236 FINAL_CHAR is a character, and use %c when it is passed as
5237 argument to `error'.
5239 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5241 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5243 * w32.c: Include <time.h>.
5244 (sys_localtime): New function.
5246 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5248 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5250 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5252 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5254 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5257 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5259 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5260 gl_state.e_property when gl_state.object is Qt.
5262 * insdel.c (make_gap_larger): Remove limitation of buffer size
5265 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5267 * xdisp.c (lookup_glyphless_char_display)
5268 (produce_glyphless_glyph): Handle cons cell entry in
5269 glyphless-char-display.
5270 (Vglyphless_char_display): Document it.
5272 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5273 glyphless-char-display.
5275 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5277 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5279 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5281 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5282 definition for no-X builds.
5284 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5286 Static checks with GCC 4.6.0 and non-default toolkits.
5288 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5290 * process.c (keyboard_bit_set): Define only if SIGIO.
5291 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5292 (send_process): Repair possible setjmp clobbering.
5294 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5296 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5298 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5300 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5301 Define only if needed.
5303 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5304 by pacifying GCC about it. Maybe it's time to retire it?
5305 * xfaces.c (USG, __TIMEVAL__): Likewise.
5307 * dispextern.h (struct redisplay_interface): Rename param
5309 * termhooks.h (struct terminal): Likewise.
5310 * xterm.c (xembed_send_message): Likewise.
5312 * insdel.c (make_gap_smaller): Define only if
5313 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5315 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5318 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5319 so that we aren't warned about unused symbols.
5321 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5323 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5325 * xfns.c (x_real_positions): Mark locals as initialized.
5327 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5329 * xterm.c: Fix problems found by static analysis with other toolkits.
5330 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5331 (x_dispatch_event): Declare static if USE_GTK, and
5332 define if USE_GTK || USE_X_TOOLKIT.
5333 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5334 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5335 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5336 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5338 * xmenu.c (menu_help_callback): Pointer type fixes.
5339 Use const pointers when pointing at readonly data. Avoid pointer
5341 (FALSE): Remove unused macro.
5342 (update_frame_menubar): Remove unused decl.
5344 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5346 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5347 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5348 (single_menu_item): Rename local to avoid shadowing.
5350 * keyboard.c (make_lispy_event): Remove unused local var.
5352 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5353 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5355 * bitmaps: Change bitmaps from unsigned char back to the X11
5356 compatible char. Avoid the old compiler warnings about
5357 out-of-range initializers by using, for example, '\xab' rather
5360 * xgselect.c (xgselect_initialize): Check vs interface
5361 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5363 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5365 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5366 to read-only memory.
5368 * fns.c (vector): Remove; this old hack is no longer needed.
5370 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5372 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5374 * xrdb.c (x_load_resources): Omit unused local.
5376 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5377 (x_window): Rename locals to avoid shadowing.
5378 (USG): Use the kludged USG macro, to pacify gcc.
5380 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5381 (x_term_init): Remove local to avoid shadowing.
5383 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5385 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5386 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5388 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5390 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5392 Fix regex.c, syntax.c and friends for buffers > 2GB.
5393 * syntax.h (struct gl_state_s): Declare character position members
5396 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5398 * textprop.c (verify_interval_modification, interval_of):
5399 Declare arguments EMACS_INT.
5401 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5404 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5406 * indent.c (Fvertical_motion): Local variable it_start is now
5409 * regex.c (re_match, re_match_2, re_match_2_internal)
5410 (bcmp_translate, regcomp, regexec, print_double_string)
5411 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5412 (re_compile_pattern, re_exec): Declare arguments and local
5413 variables `size_t' and `ssize_t' and return values `regoff_t', as
5415 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5416 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5417 <compile_stack_type>: `size' and `avail' are now `size_t'.
5419 * regex.h <regoff_t>: Use ssize_t, not int.
5420 (re_search, re_search_2, re_match, re_match_2): Arguments that
5421 specify buffer/string position and length are now ssize_t and
5422 size_t. Return type is regoff_t.
5424 2011-04-16 Ben Key <bkey76@gmail.com>
5426 * nsfont.m: Fixed bugs in ns_get_family and
5427 ns_descriptor_to_entity that were caused by using free to
5428 deallocate memory blocks that were allocated by xmalloc (via
5429 xstrdup). This caused Emacs to crash when compiled with
5430 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5431 --enable-checking=xmallocoverrun). xfree is now used to
5432 deallocate these memory blocks.
5434 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5436 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5438 emacs_write: Accept and return EMACS_INT for sizes.
5439 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5441 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5442 Accept and return EMACS_INT.
5443 (emacs_gnutls_write): Return the number of bytes written on
5445 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5446 (emacs_read, emacs_write): Remove check for negative size, as the
5447 Emacs source code has been audited now.
5448 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5449 (emacs_read, emacs_write): Use it.
5450 * process.c (send_process): Adjust to the new signatures of
5451 emacs_write and emacs_gnutls_write. Do not attempt to store
5452 a byte offset into an 'int'; it might overflow.
5453 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5455 * sound.c: Don't assume sizes fit in 'int'.
5456 (struct sound_device.period_size, alsa_period_size):
5457 Return EMACS_INT, not int.
5458 (struct sound_device.write, vox_write, alsa_write):
5459 Accept EMACS_INT, not int.
5460 (wav_play, au_play): Use EMACS_INT to store sizes and to
5461 record read return values.
5463 2011-04-15 Ben Key <bkey76@gmail.com>
5465 * keyboard.c (Qundefined): Don't declare static since it is used
5467 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5468 static since they are used in nsfont.m.
5470 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5472 * process.c (Qprocessp): Don't declare static.
5473 * lisp.h (Qprocessp): Declare again.
5475 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5477 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5479 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5481 Improve C-level modularity by making more things 'static'.
5483 Don't publish debugger-only interfaces to other modules.
5484 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5485 (verify_bytepos, count_markers): Move decls to the only modules
5487 * region-cache.h (pp_cache): Likewise.
5488 * window.h (check_all_windows): Likewise.
5489 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5491 * sysdep.c (croak): Now static, if
5492 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5493 * syssignal.h (croak): Declare only if not static.
5495 * alloc.c (refill_memory_reserve): Now static if
5496 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5497 * lisp.h (refill_memory_reserve): Declare only if not static.
5499 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5500 Define only if USE_LUCID.
5502 * xrdb.c (x_customization_string, x_rm_string): Now static.
5504 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5505 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5507 * xdisp.c (draw_row_with_mouse_face): Now static.
5508 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5510 * window.h (check_all_windows): Mark externally visible.
5512 * window.c (window_deletion_count): Now static.
5514 * undo.c: Make symbols static if they're not exported.
5515 (last_undo_buffer, last_boundary_position, pending_boundary):
5518 * textprop.c (interval_insert_behind_hooks): Now static.
5519 (interval_insert_in_front_hooks): Likewise.
5521 * term.c: Make symbols static if they're not exported.
5522 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5523 (max_frame_lines, tty_set_terminal_modes):
5524 (tty_reset_terminal_modes, tty_turn_off_highlight):
5525 (get_tty_terminal): Now static.
5526 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5527 * termhooks.h (term_mouse_moveto): Do not declare if
5529 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5530 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5532 * sysdep.c: Make symbols static if they're not exported.
5533 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5535 (sigprocmask_set, full_mask): Remove; unused.
5536 (wait_debugging): Mark as visible.
5537 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5538 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5540 * syntax.c (syntax_temp): Define only if !__GNUC__.
5542 * sound.c (current_sound_device, current_sound): Now static.
5544 * search.c (searchbufs, searchbuf_head): Now static.
5546 * scroll.c (scroll_cost): Remove; unused.
5547 * dispextern.h (scroll_cost): Remove decl.
5549 * region-cache.h (pp_cache): Mark as externally visible.
5551 * process.c: Make symbols static if they're not exported.
5552 (process_tick, update_tick, create_process, chan_process):
5553 (Vprocess_alist, proc_buffered_char, datagram_access):
5554 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5555 (deactivate_process): Mark defn as static, as well as decl.
5556 * lisp.h (create_process): Remove decl.
5557 * process.h (chan_process, Vprocess_alist): Remove decls.
5559 * print.c: Make symbols static if they're not exported.
5560 (print_depth, new_backquote_output, being_printed, print_buffer):
5561 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5562 (print_interval, print_number_index, initial_stderr_stream):
5564 * lisp.h (Fprinc): Remove decl.
5565 (debug_output_compilation_hack): Mark as externally visible.
5567 * sysdep.c (croak): Move decl from here to syssignal.h.
5568 * syssignal.h (croak): Put it here, so the API can be checked when
5569 'croak' is called from dissociate_if_controlling_tty.
5571 * minibuf.c: Make symbols static if they're not exported.
5572 (minibuf_save_list, choose_minibuf_frame): Now static.
5573 * lisp.h (choose_minibuf_frame): Remove decl.
5575 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5577 * lread.c: Make symbols static if they're not exported.
5578 (read_objects, initial_obarray, oblookup_last_bucket_number):
5580 (make_symbol): Remove; unused.
5581 * lisp.h (initial_obarray, make_symbol): Remove decls.
5583 * keyboard.c: Make symbols static if they're not exported.
5584 (single_kboard, recent_keys_index, total_keys, recent_keys):
5585 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5586 (this_single_command_key_start, echoing, last_auto_save):
5587 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5588 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5589 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5590 (Vlispy_mouse_stem, double_click_count):
5592 (force_auto_save_soon): Define only if SIGDANGER.
5593 (ignore_mouse_drag_p): Now static if
5594 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5595 (print_help): Remove; unused.
5596 (stop_character, last_timer_event): Mark as externally visible.
5597 * keyboard.h (ignore_mouse_drag_p): Declare only if
5598 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5599 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5600 * lisp.h (echoing): Remove decl.
5601 (force_auto_save_soon): Declare only if SIGDANGER.
5602 * xdisp.c (redisplay_window): Simplify code, to make it more
5603 obvious that ignore_mouse_drag_p is not accessed if !defined
5604 USE_GTK && !defined HAVE_NS.
5606 * intervals.c: Make symbols static if they're not exported.
5607 (merge_properties_sticky, merge_interval_right, delete_interval):
5609 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5611 * insdel.c: Make symbols static if they're not exported.
5612 However, leave prepare_to_modify_buffer alone. It's never
5613 called from outside this function, but that appears to be a bug.
5614 (combine_after_change_list, combine_after_change_buffer):
5615 (adjust_after_replace, signal_before_change): Now static.
5616 (adjust_after_replace_noundo): Remove; unused.
5617 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5618 (signal_before_change): Remove decls.
5620 * indent.c (val_compute_motion, val_vmotion): Now static.
5622 * image.c: Make symbols static if they're not exported.
5623 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5625 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5626 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5628 * fringe.c (standard_bitmaps): Now static.
5629 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5631 * frame.c: Make symbols static if they're not exported.
5632 (x_report_frame_params, make_terminal_frame): Now static.
5633 (get_frame_param): Now static, unless HAVE_NS.
5634 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5635 (x_get_resource_string): Remove; not used.
5636 * frame.h (make_terminal_frame, x_report_frame_params):
5637 (x_get_resource_string); Remove decls.
5638 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5639 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5641 * font.c, fontset.c: Make symbols static if they're not exported.
5642 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5643 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5644 * font.c (font_close_object): Now static.
5645 * font.h (font_close_object): Remove.
5646 * fontset.c (FONTSET_OBJLIST): Remove.
5647 (free_realized_fontset) #if-0 the body, which does nothing.
5648 (face_suitable_for_char_p): #if-0, as it's never called.
5649 * fontset.h (face_suitable_for_char_p): Remove decl.
5650 * xfaces.c (face_at_string_position):
5651 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5652 since 0 is always ASCII.
5654 * fns.c (weak_hash_tables): Now static.
5656 * fileio.c: Make symbols static if they're not exported.
5657 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5658 (Vwrite_region_annotation_buffers): Now static.
5660 * eval.c: Make symbols static if they're not exported.
5661 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5662 * lisp.h (backtrace_list): Remove decl.
5664 * emacs.c: Make symbols static if they're not exported.
5665 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5666 (fatal_error_code, fatal_error_signal_hook, standard_args):
5668 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5669 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5670 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5671 * lisp.h (fatal_error_signal_hook): Remove decl.
5672 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5674 * editfns.c: Move a (normally-unused) function to its only use.
5675 * editfns.c, lisp.h (get_operating_system_release): Remove.
5676 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5677 worth the hassle of breaking this out.
5679 * xterm.c: Make symbols static if they're not exported.
5680 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5681 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5682 (x_destroy_window, x_delete_display):
5684 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5685 (x_mouse_leave): Remove; unused.
5686 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5687 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5688 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5690 (x_mouse_leave): Declare only if WINDOWSNT.
5691 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5692 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5695 * ftxfont.c: Make symbols static if they're not exported.
5696 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5698 * font.h (ftxfont_driver): Likewise.
5700 * xfns.c: Make symbols static if they're not exported.
5701 (x_last_font_name, x_display_info_for_name):
5702 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5703 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5704 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5705 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5706 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5707 (last_show_tip_args): Now static.
5708 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5709 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5710 (x_screen_planes): Remove; unused.
5711 * dispextern.h (x_screen_planes): Remove decl.
5713 * dispnew.c: Make symbols static if they're not exported.
5714 * dispextern.h (redraw_garbaged_frames, scrolling):
5715 (increment_row_positions): Remove.
5716 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5717 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5719 (redraw_garbaged_frames): Remove; unused.
5721 * xfaces.c: Make symbols static if they're not exported.
5722 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5724 * xterm.h (defined_color): Remove decls.
5725 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5726 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5727 (menu_face_changed_default, defined_color, free_realized_face):
5728 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5729 (ascii_face_of_lisp_face): Remove; unused.
5731 * xdisp.c: Make symbols static if they're not exported.
5732 * dispextern.h (scratch_glyph_row, window_box_edges):
5733 (glyph_to_pixel_coords, set_cursor_from_row):
5734 (get_next_display_element, set_iterator_to_next):
5735 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5736 (show_mouse_face): Remove decls
5737 * frame.h (message_buf_print): Likewise.
5738 * lisp.h (pop_message, set_message, check_point_in_composition):
5740 * xterm.h (set_vertical_scroll_bar): Likewise.
5741 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5742 (message_buf_print, scratch_glyph_row, displayed_buffer):
5743 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5744 (get_next_display_element, show_mouse_face, window_box_edges):
5745 (frame_to_window_pixel_xy, check_point_in_composition):
5746 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5747 (glyph_to_pixel_coords): Remove; unused.
5749 * dired.c (file_name_completion): Now static.
5751 * dbusbind.c (xd_in_read_queued_messages): Now static.
5753 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5754 * data.c (circular_list_error): Remove.
5756 * commands.h (last_point_position, last_point_position_buffer):
5757 (last_point_position_window): Remove decls.
5758 * keyboard.c: Make these variables static.
5760 * coding.h (coding, code_convert_region, encode_coding_gap):
5762 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5763 (iso_code_class, detect_coding, code_convert_region): Now static.
5764 (encode_coding_gap): Remove; unused.
5766 * chartab.c (chartab_chars, chartab_bits): Now static.
5768 * charset.h (charset_iso_8859_1): Remove decl.
5769 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5772 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5773 * ccl.c (Vccl_program_table): Now static.
5774 (check_ccl_update): Remove; unused.
5776 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5777 * category.h: ... from here.
5778 * category.c (check_category_table, set_category_set): Now static.
5780 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5781 * lisp.h: Remove these decls.
5783 * buffer.c (buffer_count): Remove unused var.
5785 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5786 so that it's not optimized away.
5787 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5788 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5789 exported only to the debugger.
5791 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5792 * atimer.h (run_all_atimers): Remove; not exported.
5794 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5795 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5796 was inaccessible from Lisp.
5797 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5798 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5800 alloc.c: Import and export fewer symbols, and remove unused items.
5801 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5803 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5804 it's not optimized away by whole-program optimization.
5805 (message_enable_multibyte, free_misc): Remove.
5806 (catchlist, handlerlist, mark_backtrace):
5807 Declare only if BYTE_MARK_STACK.
5808 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5809 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5810 (message_enable_multibyte): Remove decl.
5811 (free_misc, interval_free_list, float_block, float_block_index):
5812 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5813 (cons_free_list, last_marked_index):
5815 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5816 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5817 (mark_backtrace): Define only if BYTE_MARK_STACK.
5818 * xdisp.c (message_enable_multibyte): Now static.
5820 Declare Lisp_Object Q* variables to be 'static' if not exported.
5821 This makes it easier for human readers (and static analyzers)
5822 to see whether these variables are used from other modules.
5823 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5824 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5825 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5826 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5827 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5828 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5829 * xmenu.c, xselect.c:
5830 Declare Q* vars static if they are not used in other modules.
5831 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5832 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5833 Remove decls of unexported vars.
5834 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5836 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5838 Make Emacs functions such as Fatom 'static' by default.
5839 This makes it easier for human readers (and static analyzers)
5840 to see whether these functions can be called from other modules.
5841 DEFUN now defines a static function. To make the function external
5842 so that it can be used in other C modules, use the new macro DEFUE.
5843 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5844 (Finit_image_library):
5845 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5846 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5847 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5848 Remove decls, since these functions are now static.
5849 (Funintern, Fget_internal_run_time): New decls, since these functions
5850 were already external.
5852 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5853 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5854 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5855 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5856 * keyboard.c, keymap.c, lread.c:
5857 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5858 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5859 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5860 Mark functions with DEFUE instead of DEFUN,
5861 if they are used in other modules.
5862 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5863 decls for now-static functions.
5864 * buffer.h (Fdelete_overlay): Remove decl.
5865 * callproc.c (Fgetenv_internal): Mark as internal.
5866 * composite.c (Fremove_list_of_text_properties): Remove decl.
5867 (Fcomposition_get_gstring): New forward static decl.
5868 * composite.h (Fcomposite_get_gstring): Remove decl.
5869 * dired.c (Ffile_attributes): New forward static decl.
5870 * doc.c (Fdocumntation_property): New forward static decl.
5871 * eval.c (Ffetch_bytecode): New forward static decl.
5872 (Funintern): Remove extern decl; now in .h file where it belongs.
5873 * fileio.c (Fmake_symbolic_link): New forward static decl.
5874 * image.c (Finit_image_library): New forward static decl.
5875 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5876 * intervals.h (Fprevious_property_change):
5877 (Fremove_list_of_text_properties): Remove decls.
5878 * keyboard.c (Fthis_command_keys): Remove decl.
5879 (Fcommand_execute): New forward static decl.
5880 * keymap.c (Flookup_key): New forward static decl.
5881 (Fcopy_keymap): Now static.
5882 * keymap.h (Flookup_key): Remove decl.
5883 * process.c (Fget_process): New forward static decl.
5884 (Fprocess_datagram_address): Mark as internal.
5885 * syntax.c (Fsyntax_table_p): New forward static decl.
5886 (skip_chars): Remove duplicate decl.
5887 * textprop.c (Fprevious_property_change): New forward static decl.
5888 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5890 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5891 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5893 * editfns.c (Fformat): Remove unreachable code.
5895 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5897 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5900 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5902 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5903 when at ZV. (Bug#8487)
5905 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5907 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5909 * keyboard.c (parse_tool_bar_item): Likewise.
5910 * sound.c (sound_cleanup, alsa_close): Likewise.
5911 * termcap.c (tgetent): Likewise.
5912 * xfns.c (x_default_font_parameter): Likewise.
5913 * xsettings.c (read_and_apply_settings): Likewise.
5915 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5916 (overrun_check_free): Protoize.
5918 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5920 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5921 since callers should never pass a negative size.
5922 Change the signature to match that of plain 'read' and 'write'; see
5923 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5924 * lisp.h: Update prototypes of emacs_write and emacs_read.
5926 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5928 * xdisp.c (redisplay_window): Don't try to determine the character
5929 position of the scroll margin if the window start point w->startp
5930 is outside the buffer's accessible region. (Bug#8468)
5932 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5934 Fix write-region and its subroutines for buffers > 2GB.
5935 * fileio.c (a_write, e_write): Modify declaration of arguments and
5936 local variables to support buffers larger than 2GB.
5937 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5939 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5940 argument, local variables, and return value.
5942 * lisp.h: Update prototypes of emacs_write and emacs_read.
5944 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5946 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5948 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5950 Fix more problems found by GCC 4.6.0's static checks.
5952 * xdisp.c (vmessage): Use a better test for character truncation.
5954 * charset.c (load_charset_map): <, not <=, for optimization,
5955 and to avoid potential problems with integer overflow.
5956 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5957 * casetab.c (set_identity, shuffle): Likewise.
5958 * editfns.c (Fformat): Likewise.
5959 * syntax.c (skip_chars): Likewise.
5961 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5962 This also lets GCC 4.6.0 generate slightly better loop code.
5964 * callint.c (Fcall_interactively): <, not <=, for optimization.
5965 (Fcall_interactively): Count the number of arguments produced,
5966 not the number of arguments given. This is simpler and lets GCC
5967 4.6.0 generate slightly better code.
5969 * ftfont.c: Distingish more carefully between FcChar8 and char.
5970 The previous code passed unsigned char * to a functions like
5971 strlen and xstrcasecmp that expect char *, which does not
5972 conform to the C standard.
5973 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5974 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5975 char * when the C standard requires it.
5977 * keyboard.c (read_char): Remove unused var.
5979 * eval.c: Port to Windows vsnprintf (Bug#8435).
5981 (SIZE_MAX): Define if the headers do not.
5982 (verror): Do not give up if vsnprintf returns a negative count.
5983 Instead, grow the buffer. This ports to Windows vsnprintf, which
5984 does not conform to C99. Problem reported by Eli Zaretskii.
5985 Also, simplify the allocation scheme, by avoiding the need for
5986 calling realloc, and removing the ALLOCATED variable.
5988 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5990 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5991 But keep the doprint source code for now, as we might revamp it
5992 and use it again (Bug#8435).
5993 * lisp.h (doprnt): Remove.
5994 * Makefile.in (base_obj): Remove doprnt.o.
5995 * deps.mk (doprnt.o): Remove.
5997 error: Print 32- and 64-bit integers portably (Bug#8435).
5998 Without this change, on typical 64-bit hosts error ("...%d...", N)
5999 was used to print both 32- and 64-bit integers N, which relied on
6001 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6003 * lisp.h (error, verror): Mark as printf-like functions.
6004 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6005 Report overflow in size calculations when allocating printf buffer.
6006 Do not truncate output string at its first null byte.
6007 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6008 Truncate the output at a character boundary, since vsnprintf does not
6010 * charset.c (check_iso_charset_parameter): Convert internal
6011 character to string before calling 'error', since %c now has the
6013 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6014 overflow when computing char to be passed to 'error'. Do not
6015 pass Lisp_Object to 'error'; pass the integer instead.
6016 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6017 formatted with plain %d.
6019 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6021 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6023 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6025 * xterm.c (x_catch_errors): Remove duplicate declaration.
6027 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6029 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6031 2011-04-10 Jim Meyering <meyering@redhat.com>
6033 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6034 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6035 return ssize_t not "int", and use size_t as the buffer length.
6036 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6037 * gnutls.h: Update declarations.
6038 * process.c (read_process_output): Use ssize_t, to match.
6039 (send_process): Likewise.
6041 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6043 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6045 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6047 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6048 Use unsigned char, to match FcChar8 type definition.
6050 * xterm.c (handle_one_xevent):
6051 * xmenu.c (create_and_show_popup_menu):
6052 * xselect.c (x_decline_selection_request)
6053 (x_reply_selection_request): Avoid type-punned deref of X events.
6055 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6057 Fix some uses of `int' instead of EMACS_INT.
6058 * search.c (string_match_1, fast_string_match)
6059 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6060 (scan_buffer, find_next_newline_no_quit)
6061 (find_before_next_newline, search_command, Freplace_match)
6062 (Fmatch_data): Make some `int' variables be EMACS_INT.
6064 * xdisp.c (display_count_lines): 3rd argument and return value now
6065 EMACS_INT. All callers changed.
6066 (pint2hrstr): Last argument is now EMACS_INT.
6068 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6069 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6070 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6071 (decode_coding_utf_16, decode_coding_emacs_mule)
6072 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6073 (decode_coding_ccl, decode_coding_charset)
6074 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6075 (decode_coding_iso_2022, decode_coding_emacs_mule)
6076 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6077 <char_offset, last_offset>: Declare EMACS_INT.
6078 (encode_coding_utf_8, encode_coding_utf_16)
6079 (encode_coding_emacs_mule, encode_invocation_designation)
6080 (encode_designation_at_bol, encode_coding_iso_2022)
6081 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6082 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6084 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6085 (encode_invocation_designation): Last argument P_NCHARS is now
6087 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6088 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6090 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6093 * ccl.c (Fccl_execute_on_string): Declare some variables
6096 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6098 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6100 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6102 * process.c (Fformat_network_address): Doc fix.
6104 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6106 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6108 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6110 * keyboard.c (read_char): Call Lisp function help-form-show,
6111 instead of using internal_with_output_to_temp_buffer.
6112 (Qhelp_form_show): New var.
6113 (syms_of_keyboard): Use DEFSYM macro.
6115 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6117 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6119 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6121 * process.c (Flist_processes): Remove to Lisp.
6122 (list_processes_1): Delete.
6124 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6126 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6128 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6130 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6132 Fix more problems found by GCC 4.6.0's static checks.
6134 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6136 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6138 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6140 * xdisp.c (vmessage): Mark as a printf-like function.
6142 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6144 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6146 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6147 printf-like functions.
6148 (tiff_load): Add casts to remove these marks before passing them
6149 to system-supplied API.
6151 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6153 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6154 This avoids several warnings with gcc -Wstrict-overflow.
6155 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6156 directly, rather than having caller test rule sign. This avoids
6157 some unnecessary tests.
6158 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6159 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6160 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6162 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6163 (xfont_open): Avoid unnecessary tests.
6165 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6167 * composite.h, composite.c (composition_gstring_put_cache):
6168 Use EMACS_INT, not int, for length.
6170 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6171 breaking out part of COMPOSITION_DECODE_RULE.
6172 (COMPOSITION_DECODE_RULE): Use it.
6173 * composite.c (get_composition_id): Remove unused local vars,
6174 by using the new macro.
6176 * textprop.c (set_text_properties_1): Change while to do-while,
6177 since the condition is always true at first.
6179 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6180 (interval_deletion_adjustment): Return unsigned value.
6183 * process.c (list_processes_1, create_pty, read_process_output):
6184 (exec_sentinel): Remove vars that were set but not used.
6185 (create_pty): Remove unnecessary "volatile"s.
6186 (Fnetwork_interface_info): Avoid possibility of int overflow.
6187 (read_process_output): Do adaptive read buffering even if carryover.
6188 (read_process_output): Simplify nbytes computation if buffered.
6190 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6192 * syntax.c (scan_words): Remove var that was set but not used.
6193 (update_syntax_table): Use unsigned instead of int.
6195 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6196 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6197 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6199 * print.c (print_error_message): Avoid int overflow.
6201 * font.c (font_list_entities): Redo for clarity,
6202 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6204 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6205 (font_score): Avoid potential overflow in diff calculation.
6207 * fns.c (substring_both): Remove var that is set but not used.
6208 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6210 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6212 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6213 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6214 can always succeed if overflow has undefined behavior.
6216 * search.c (boyer_moore, wordify): Remove vars set but not used.
6217 (wordify): Omit three unnecessary tests.
6219 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6220 All callers changed. This avoids the need for an unused var.
6222 * casefiddle.c (casify_region): Remove var that is set but not used.
6224 * dired.c (file_name_completion): Remove var that is set but not used.
6226 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6228 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6229 (Finsert_file_contents): Remove unnecessary code checking fd.
6231 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6232 Check for integer overflow on size calculations.
6234 * buffer.c (Fprevious_overlay_change): Remove var that is set
6237 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6238 Remove vars that are set but not used.
6239 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6240 (timer_check_2): Mark vars as initialized.
6242 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6244 * image.c (lookup_image): Remove var that is set but not used.
6245 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6247 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6248 that are set but not used.
6250 * xfns.c (make_invisible_cursor): Don't return garbage
6251 if XCreateBitmapFromData fails (Bug#8410).
6253 * xselect.c (x_get_local_selection, x_handle_property_notify):
6254 Remove vars that are set but not used.
6256 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6257 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6259 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6260 Remove var that is set but not used.
6261 (scroll_bar_windows_size): Now size_t, not int.
6262 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6265 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6266 (map_tty_color) [!defined MSDOS]: Likewise.
6268 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6270 * coding.c: Remove vars that are set but not used.
6271 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6272 All callers changed.
6273 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6274 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6275 (decode_coding_charset): Remove vars that are set but not used.
6277 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6278 that is set but not used.
6280 * print.c (print_object): Remove var that is set but not used.
6282 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6283 The gnulib version avoids calling malloc in the usual case,
6284 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6285 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6286 * filelock.c (current_lock_owner): Likewise.
6287 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6288 * sysdep.c: Include allocator.h, careadlinkat.h.
6289 (emacs_no_realloc_allocator): New static constant.
6290 (emacs_readlink): New function.
6291 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6292 ../lib/careadlinkat.h.
6294 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6296 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6297 first non-nil return value).
6299 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6301 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6302 if not defined (Bug#8403).
6304 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6306 * xdisp.c (display_count_lines): Remove parameter `start',
6307 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6308 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6309 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6310 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6311 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6312 and thereabouts. All callers changed.
6313 (get_per_char_metric): Remove parameter `f', unused since
6314 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6316 2011-04-02 Jim Meyering <meyering@redhat.com>
6318 do not dereference NULL upon failed strdup
6319 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6320 (ns_get_family): Likewise.
6322 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6324 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6326 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6328 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6331 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6333 Add lexical binding.
6335 * window.c (Ftemp_output_buffer_show): New fun.
6336 (Fsave_window_excursion):
6337 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6339 * lread.c (lisp_file_lexically_bound_p): New function.
6340 (Fload): Bind Qlexical_binding.
6341 (readevalloop): Remove `evalfun' arg.
6342 Bind Qinternal_interpreter_environment.
6343 (Feval_buffer): Bind Qlexical_binding.
6344 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6346 (syms_of_lread): Declare `lexical-binding'.
6348 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6350 * keyboard.c (eval_dyn): New fun.
6351 (menu_item_eval_property): Use it.
6353 * image.c (parse_image_spec): Use Ffunctionp.
6355 * fns.c (concat, mapcar1): Accept byte-code-functions.
6357 * eval.c (Fsetq): Handle lexical vars.
6358 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6359 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6360 (FletX, Flet): Obey lexical binding.
6361 (Fcommandp): Handle closures.
6362 (Feval): New `lexical' arg.
6363 (eval_sub): New function extracted from Feval. Use it almost
6364 everywhere where Feval was used. Look up vars in lexical env.
6366 (Ffunctionp): Move from subr.el.
6367 (Ffuncall): Handle closures.
6368 (apply_lambda): Remove `eval_flags'.
6369 (funcall_lambda): Handle closures and new byte-code-functions.
6370 (Fspecial_variable_p): New function.
6371 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6372 but without exporting it to Lisp.
6374 * doc.c (Fdocumentation, store_function_docstring):
6375 * data.c (Finteractive_form): Handle closures.
6377 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6380 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6382 (exec_byte_code): New function extracted from Fbyte_code to handle new
6383 calling convention for byte-code-functions. Add new byte-codes.
6385 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6387 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6389 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6391 * xdisp.c (redisplay_internal): Fix prototype.
6393 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6395 * xdisp.c (SCROLL_LIMIT): New macro.
6396 (try_scrolling): Use it when setting scroll_limit.
6397 Limit scrolling to 100 screen lines.
6398 (redisplay_window): Even when falling back on "recentering",
6399 position point in the window according to scroll-conservatively,
6400 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6402 (try_scrolling): When point is above the window, allow searching
6403 as far as scroll_max, or one screenful, to compute vertical
6404 distance from PT to the scroll margin position. This prevents
6405 try_scrolling from unnecessarily failing when
6406 scroll-conservatively is set to a value slightly larger than the
6407 window height. Clean up the case of PT below the margin at bottom
6408 of window: scroll_max can no longer be INT_MAX. When aggressive
6409 scrolling is in use, don't let point enter the opposite scroll
6410 margin as result of the scroll.
6411 (syms_of_xdisp) <scroll-conservatively>: Document the
6412 threshold of 100 lines for never-recentering scrolling.
6414 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6416 * dispextern.h (move_it_by_lines):
6417 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6418 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6419 (message_log_check_duplicate): Remove parameters `prev_bol' and
6420 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6421 (redisplay_internal): Remove parameter `preserve_echo_area',
6422 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6424 * indent.c (Fvertical_motion):
6425 * window.c (window_scroll_pixel_based, Frecenter):
6426 Don't pass `need_y_p' to `move_it_by_lines'.
6428 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6430 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6431 steal a few bits to be more compact.
6432 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6433 Remove unneeded casts.
6435 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6437 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6439 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6440 binding" message (bug#7967).
6442 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6444 Fix more problems found by GCC 4.6.0's static checks.
6446 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6447 Remove unused local var.
6449 * editfns.c (Fmessage_box): Remove unused local var.
6451 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6452 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6453 Omit unused local vars.
6454 * window.c (shrink_windows): Omit unused local var.
6455 * menu.c (digest_single_submenu): Omit unused local var.
6456 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6457 Omit unused local var.
6459 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6460 Don't assume string length fits in int.
6461 (keyremap_step, read_key_sequence): Use size_t for sizes.
6462 (read_key_sequence): Don't check last_real_key_start redundantly.
6464 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6465 instead of alloca (Bug#8344).
6467 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6468 (Fbacktrace_frame): Don't assume nframes fits in int.
6470 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6472 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6475 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6477 * cm.c (calccost): Turn while-do into do-while, for clarity.
6479 * keyboard.c (syms_of_keyboard): Use the same style as later
6480 in this function when indexing through an array. This also
6481 works around GCC bug 48267.
6483 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6485 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6487 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6488 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6490 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6491 This avoids undefined behavior on integer overflow, and is a bit
6492 more convenient anyway since it is compared to a size_t variable.
6494 Variadic C functions now count arguments with size_t, not int.
6495 This avoids an unnecessary limitation on 64-bit machines, which
6496 caused (substring ...) to crash on large vectors (Bug#8344).
6497 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6498 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6499 All variadic functions and their callers changed accordingly.
6500 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6501 * data.c (arith_driver, float_arith_driver): Likewise.
6502 * editfns.c (general_insert_function): Likewise.
6503 * eval.c (struct backtrace.nargs, interactive_p)
6504 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6505 (funcall_lambda, mark_backtrace): Likewise.
6506 * fns.c (concat): Likewise.
6507 * frame.c (x_set_frame_parameters): Likewise.
6508 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6509 0 if not found, not -1. All callers changed.
6511 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6512 (stack_copy_size): Now size_t, not int.
6513 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6515 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6517 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6518 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6519 All callers changed.
6521 * lisp.h (multibyte_char_to_unibyte):
6522 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6523 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6524 * character.h (CHAR_TO_BYTE8):
6525 * cmds.c (internal_self_insert):
6526 * editfns.c (general_insert_function):
6527 * keymap.c (push_key_description):
6528 * search.c (Freplace_match):
6529 * xdisp.c (message_dolog, set_message_1): All callers changed.
6531 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6533 * keyboard.c (safe_run_hook_funcall): New function.
6534 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6535 don't set the hook to nil, but remove the offending function instead.
6536 (Qcommand_hook_internal): Remove, unused.
6537 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6538 Vcommand_hook_internal.
6540 * eval.c (enum run_hooks_condition): Remove.
6541 (funcall_nil, funcall_not): New functions.
6542 (run_hook_with_args): Call each function through a `funcall' argument.
6543 Remove `cond' argument, now redundant.
6544 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6545 (Frun_hook_with_args_until_failure): Adjust accordingly.
6546 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6548 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6550 * dispextern.h (string_buffer_position): Remove declaration.
6552 * print.c (strout): Remove parameter `multibyte', unused since
6553 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6555 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6556 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6557 All callers changed.
6559 * w32.c (_wsa_errlist): Use braces for struct initializers.
6561 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6562 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6563 All callers changed.
6564 (string_buffer_position): Likewise. Also, make static (it's never
6565 used outside xdisp.c).
6566 (cursor_row_p): Remove parameter `w', unused since
6567 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6568 (decode_mode_spec): Remove parameter `precision', introduced during
6569 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6570 All callers changed.
6572 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6574 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6576 2011-03-27 Anders Lindgren <andlind@gmail.com>
6578 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6579 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6580 (ns_update_auto_hide_menu_bar): New functions.
6581 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6582 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6583 ns_constrain_all_frames.
6584 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6585 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6587 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6589 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6591 2011-03-27 Glenn Morris <rgm@gnu.org>
6593 * syssignal.h: Replace RETSIGTYPE with void.
6594 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6595 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6596 Replace SIGTYPE with void everywhere.
6597 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6598 * s/template.h (SIGTYPE): Remove commented out definition.
6600 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6602 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6603 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6605 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6607 * w32.c (read_unc_volume): Use parameter `henum', instead of
6608 global variable `wget_enum_handle'.
6610 * keymap.c (describe_vector): Remove parameters `indices' and
6611 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6612 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6614 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6616 * keyboard.c (timer_check): Remove parameter `do_it_now',
6617 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6618 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6619 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6621 * keyboard.c (read_char):
6622 * w32menu.c (w32_menu_display_help):
6623 * xmenu.c (show_help_event, menu_help_callback):
6624 Adjust calls to `show_help_echo'.
6626 * gtkutil.c (xg_maybe_add_timer):
6627 * keyboard.c (readable_events):
6628 * process.c (wait_reading_process_output):
6629 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6631 * insdel.c (adjust_markers_gap_motion):
6632 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6633 (gap_left, gap_right): Don't call it.
6635 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6637 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6638 incurred during fontification.
6640 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6642 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6643 (DEFVAR_PER_BUFFER): Don't pass it.
6645 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6646 (scrolling_window): Don't pass it.
6648 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6650 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6652 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6654 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6655 of variables specific to SELinux and computation of `encoded_absname'.
6657 * image.c (XPutPixel): Remove unused variable `height'.
6659 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6661 * unexw32.c (get_section_info): Remove unused variable `section'.
6663 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6664 (system_process_attributes): Remove unused variable `sess'.
6665 (sys_read): Remove unused variable `err'.
6667 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6668 (w32_wnd_proc): Remove unused variable `isdead'.
6669 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6670 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6671 (x_create_tip_frame): Remove unused variable `tem'.
6673 * w32inevt.c (w32_console_read_socket):
6674 Remove unused variable `no_events'.
6676 * w32term.c (x_draw_composite_glyph_string_foreground):
6677 Remove unused variable `width'.
6679 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6681 * w32term.c (x_set_glyph_string_clipping):
6682 Don't pass uninitialized region to CombineRgn.
6684 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6686 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6687 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6688 (Fx_close_connection): Remove unused variable `i'.
6690 * w32font.c (w32font_draw): Return number of glyphs.
6691 (w32font_open_internal): Remove unused variable `i'.
6692 (w32font_driver): Add missing initializer.
6694 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6695 (fill_in_menu): Remove unused variable `items_added'.
6697 * w32term.c (last_mouse_press_frame): Remove static global variable.
6698 (w32_clip_to_row): Remove unused variable `f'.
6699 (x_delete_terminal): Remove unused variable `i'.
6701 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6702 (NOTHING): Remove unused static global variable.
6703 (uniscribe_check_otf): Remove unused variable `table'.
6704 (uniscribe_font_driver): Add missing initializers.
6706 2011-03-23 Julien Danjou <julien@danjou.info>
6708 * term.c (Fsuspend_tty, Fresume_tty):
6709 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6710 * window.c (temp_output_buffer_show):
6711 * insdel.c (signal_before_change):
6712 * frame.c (Fhandle_switch_frame):
6713 * fileio.c (Fdo_auto_save):
6714 * emacs.c (Fkill_emacs):
6715 * editfns.c (save_excursion_restore):
6716 * cmds.c (internal_self_insert):
6717 * callint.c (Fcall_interactively):
6718 * buffer.c (Fkill_all_local_variables):
6719 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6721 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6722 unconditionnaly since it does the check itself.
6724 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6726 Fix more problems found by GCC 4.5.2's static checks.
6728 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6729 the first time through the loop, since we know p0 < p1 then.
6730 This also avoids a gcc -Wstrict-overflow warning.
6732 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6733 leading to a memory leak, possible in functions like
6734 load_charset_map_from_file that can allocate an unbounded number
6735 of objects (Bug#8318).
6737 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6738 that could (at least in theory) be that large.
6740 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6741 This is less likely to overflow, and avoids undefined behavior if
6742 overflow does occur. All callers changed. Use strtoul to scan
6743 for the unsigned long integer.
6744 (pint2hrstr): Simplify and tune code slightly.
6745 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6747 * scroll.c (do_scrolling): Work around GCC bug 48228.
6748 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6750 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6751 This also avoids a warning with gcc -Wstrict-overflow.
6752 (validate_x_resource_name): Simplify count usage.
6753 This also avoids a warning with gcc -Wstrict-overflow.
6755 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6758 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6760 * process.c (Fmake_network_process): Use socklen_t, not int,
6761 where POSIX says socklen_t is required in portable programs.
6762 This fixes a porting bug on hosts like 64-bit HP-UX, where
6763 socklen_t is wider than int (Bug#8277).
6764 (Fmake_network_process, server_accept_connection):
6765 (wait_reading_process_output, read_process_output):
6768 * process.c: Rename or move locals to avoid shadowing.
6769 (list_processes_1, Fmake_network_process):
6770 (read_process_output_error_handler, exec_sentinel_error_handler):
6771 Rename or move locals.
6772 (Fmake_network_process): Define label "retry_connect" only if needed.
6773 (Fnetwork_interface_info): Fix pointer signedness.
6774 (process_send_signal): Add cast to avoid pointer signedness problem.
6775 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6776 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6778 Make tparam.h and terminfo.c consistent.
6779 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6780 Include tparam.h instead, since it declares them.
6781 * cm.h (PC): Remove extern decl; tparam.h now does this.
6782 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6783 * terminfo.c: Include tparam.h, to check interfaces.
6784 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6785 (tparam): Adjust signature to match interface in tparam.h;
6786 this removes some undefined behavior. Check that outstring and len
6787 are zero, which they always are with Emacs.
6788 * tparam.h (PC, BC, UP): New extern decls.
6790 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6791 (xftfont_open): Rename locals to avoid shadowing.
6793 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6794 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6795 (OTF_TAG_SYM): Omit macro if not needed.
6796 (ftfont_list): Remove unused local.
6797 (get_adstyle_property, ftfont_pattern_entity):
6798 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6799 Rename locals to avoid shadowing.
6801 * xfont.c (xfont_list_family): Mark var as initialized.
6803 * xml.c (make_dom): Now static.
6805 * composite.c (composition_compute_stop_pos): Rename local to
6807 (composition_reseat_it): Remove unused locals.
6808 (find_automatic_composition, composition_adjust_point): Likewise.
6809 (composition_update_it): Mark var as initialized.
6810 (find_automatic_composition): Mark vars as initialized,
6811 with a FIXME (Bug#8290).
6813 character.h: Rename locals to avoid shadowing.
6814 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6815 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6816 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6817 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6820 * textprop.c (property_change_between_p): Remove; unused.
6822 * intervals.c (interval_start_pos): Now static.
6824 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6826 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6827 Rename locals to avoid shadowing.
6829 * sound.c (wav_play, au_play, Fplay_sound_internal):
6830 Fix pointer signedness.
6831 (alsa_choose_format): Remove unused local var.
6832 (wav_play): Initialize a variable to 0, to prevent undefined
6833 behavior (Bug#8278).
6835 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6837 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6839 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6840 clobbering (Bug#8298).
6841 * sysdep.c (sys_subshell): Likewise.
6842 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6844 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6845 This should get cleaned up, so that child_setup has the
6846 same signature on all platforms.
6848 * callproc.c (call_process_cleanup): Now static.
6849 (relocate_fd): Rename locals to avoid shadowing.
6851 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6853 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6854 not to be necessary, and produces flickering.
6856 2011-03-20 Glenn Morris <rgm@gnu.org>
6858 * config.in: Remove file.
6860 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6862 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6863 are now in src/globals.h.
6864 (syms_of_minibuf): Remove spurious & from previous change.
6866 2011-03-20 Leo <sdl.web@gmail.com>
6868 * minibuf.c (completing-read-function): New variable.
6869 (completing-read-default): Rename from completing-read.
6870 (completing-read): Call completing-read-function.
6872 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6874 * xfaces.c (Fx_load_color_file):
6875 Read color file from absolute filename (bug#8250).
6877 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6879 * makefile.w32-in: Update dependencies.
6881 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6883 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6885 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6887 Fix more problems found by GCC 4.5.2's static checks.
6889 * process.c (make_serial_process_unwind, send_process_trap):
6890 (sigchld_handler): Now static.
6892 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6893 That way, the code declares only the vars that it needs.
6894 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6895 * s/cygwin.h (PTY_ITERATION): Likewise.
6896 * s/darwin.h (PTY_ITERATION): Likewise.
6897 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6899 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6900 * process.c (allocate_pty): Don't declare stb unless it's needed.
6902 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6903 (CONSTANTLIM): Remove; unused.
6904 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6905 Define only if needed.
6907 * unexelf.c (unexec): Name an expression,
6908 to avoid gcc -Wbad-function-cast warning.
6909 Use a different way to cause a compilation error if anyone uses
6910 n rather than nn, a way that does not involve shadowing.
6911 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6913 * deps.mk (unexalpha.o): Remove; unused.
6915 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6916 * unexec.h: New file.
6917 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6918 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6920 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6921 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6922 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6923 Change as necessary to match prototype in unexec.h.
6925 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6927 (back_comment, skip_chars): Mark vars as initialized.
6929 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6930 Rename locals to avoid shadowing.
6932 * lread.c (read1): Rewrite so as not to use empty "else".
6933 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6935 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6937 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6938 warning when compiling print.c.
6940 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6941 instead of using an uninitialized var.
6942 (font_sort_entities): Mark var as initialized.
6944 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6946 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6947 pointers to constants.
6948 (font_parse_fcname): Remove unused vars.
6949 (font_delete_unmatched): Now static.
6950 (font_get_spec): Remove; unused.
6951 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6952 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6953 Rename or move locals to avoid shadowing.
6955 * fns.c (require_nesting_list, require_unwind): Now static.
6956 (Ffillarray): Rename locals to avoid shadowing.
6958 * floatfns.c (domain_error2): Define only if needed.
6959 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6961 * alloc.c (mark_backtrace): Move decl from here ...
6962 * lisp.h: ... to here, so that it can be checked.
6964 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6965 (Fdefvar): Rewrite so as not to use empty "else".
6966 (lisp_indirect_variable): Name an expression,
6967 to avoid gcc -Wbad-function-cast warning.
6968 (Fdefvar): Rename locals to avoid shadowing.
6970 * callint.c (quotify_arg, quotify_args): Now static.
6971 (Fcall_interactively): Rename locals to avoid shadowing.
6972 Use const pointer when appropriate.
6974 * lisp.h (get_system_name, get_operating_system_release):
6975 Move decls here, to check interfaces.
6976 * process.c (get_operating_system_release): Move decl to lisp.h.
6977 * xrdb.c (get_system_name): Likewise.
6978 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6979 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6980 some of which prompt warnings from gcc -Wbad-function-cast.
6981 (Fformat_time_string, Fencode_time, Finsert_char):
6982 (Ftranslate_region_internal, Fformat):
6983 Rename or remove local vars to avoid shadowing.
6984 (Ftranslate_region_internal): Mark var as initialized.
6986 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6989 * lisp.h (eassert): Check that the argument compiles, even if
6990 ENABLE_CHECKING is not defined.
6992 * data.c (Findirect_variable): Name an expression, to avoid
6993 gcc -Wbad-function-cast warning.
6994 (default_value, arithcompare, arith_driver, arith_error): Now static.
6995 (store_symval_forwarding): Rename local to avoid shadowing.
6996 (Fmake_variable_buffer_local, Fmake_local_variable):
6997 Mark variables as initialized.
6998 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7000 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7001 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7002 Rename locals to avoid shadowing.
7003 (mark_stack): Move local variables into the #ifdef region where
7005 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7006 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7008 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7009 (GC_STRING_CHARS): Remove; not used.
7010 (Fmemory_limit): Cast sbrk's returned value to char *.
7012 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7013 avoids undefined behavior in theory.
7015 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7017 Use functions, not macros, for up- and down-casing (Bug#8254).
7018 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7019 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7020 to use the following functions instead of these macros.
7021 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7022 EMACS_INT, since callers assume the returned value fits in int.
7023 (upcase1): Likewise, for UPCASE_TABLE.
7024 (uppercasep, lowercasep, upcase): New static inline functions.
7025 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7026 the race-condition problem in the old DOWNCASE.
7028 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7029 Rename locals to avoid shadowing.
7030 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7031 (regex_compile, re_search_2, re_match_2_internal):
7032 Remove unused local vars.
7033 (FREE_VAR): Rewrite so as not to use empty "else",
7034 which gcc can warn about.
7035 (regex_compile, re_match_2_internal): Mark locals as initialized.
7036 (RETALLOC_IF): Define only if needed.
7037 (WORDCHAR_P): Likewise. This one is never needed, but is used
7038 only in a comment talking about a compiler bug, so put inside
7039 the #if 0 of that comment.
7040 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7041 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7044 * search.c (boyer_moore): Rename locals to avoid shadowing.
7045 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7046 (PREV_CHAR_BOUNDARY): Likewise.
7048 * search.c (simple_search): Remove unused var.
7050 * dired.c (compile_pattern): Move decl from here ...
7051 * lisp.h: ... to here, so that it can be checked.
7052 (struct re_registers): New forward decl.
7054 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7056 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7058 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7059 Rename locals to avoid shadowing.
7060 (Fvertical_motion): Mark locals as initialized.
7062 * casefiddle.c (casify_object, casify_region): Now static.
7063 (casify_region): Mark local as initialized.
7065 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7067 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7068 New macros, so that the caller can use some names other than
7069 gcpro1, gcpro2, etc.
7070 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7072 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7073 argument, for consistency with GCPRO2_VAR, etc: it is now the
7074 prefix of the variable, not the variable itself. All uses
7076 * dired.c (directory_files_internal, file_name_completion):
7077 Rename locals to avoid shadowing.
7079 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7080 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7081 dired.c's scmp function, had undefined behavior.
7082 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7083 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7084 * buffer.h: ... to here, because these macros use current_buffer,
7085 and the new implementation with inline functions needs to have
7086 current_buffer in scope now, rather than later when the macros
7088 (downcase, upcase1): New static inline functions.
7089 (DOWNCASE, UPCASE1): Reimplement using these functions.
7090 This avoids undefined behavior in expressions like
7091 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7092 from race conditions in accessing the global variables
7093 case_temp1 and case_temp2.
7094 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7095 * lisp.h (case_temp1, case_temp2): Remove their decls.
7096 * character.h (ASCII_CHAR_P): Move from here ...
7097 * lisp.h: ... to here, so that the inline functions mentioned
7100 * dired.c (directory_files_internal_unwind): Now static.
7102 * fileio.c (file_name_as_directory, directory_file_name):
7103 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7105 (file_name_as_directory): Use const pointers when appropriate.
7106 (Fexpand_file_name): Likewise. In particular, newdir might
7107 point at constant storage, so make it a const pointer.
7108 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7109 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7111 (Fset_file_times, Finsert_file_contents, auto_save_error):
7112 Rename locals to avoid shadowing.
7114 * minibuf.c (choose_minibuf_frame_1): Now static.
7115 (Ftry_completion, Fall_completions): Rename or remove locals
7118 * marker.c (bytepos_to_charpos): Remove; unused.
7120 * lisp.h (verify_bytepos, count_markers): New decls,
7121 so that gcc does not warn that these functions aren't declared.
7123 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7124 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7125 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7126 (copy_text): Remove unused local var.
7128 * filelock.c (within_one_second): Now static.
7129 (lock_file_1): Rename local to avoid shadowing.
7131 * buffer.c (fix_overlays_before): Mark locals as initialized.
7132 (fix_start_end_in_overlays): Likewise. This function should be
7133 simplified by using pointers-to-pointers, but that's a different
7135 (switch_to_buffer_1): Now static.
7136 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7137 (report_overlay_modification): Rename locals to avoid shadowing.
7139 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7140 Fix pointer signedness issue.
7141 (sys_subshell): Mark local as volatile if checking for lint,
7142 to suppress a gcc -Wclobbered warning that does not seem to be right.
7143 (MAXPATHLEN): Define only if needed.
7145 * process.c (serial_open, serial_configure): Move decls from here ...
7146 * systty.h: ... to here, so that they can be checked.
7148 * fns.c (get_random, seed_random): Move extern decls from here ...
7149 * lisp.h: ... to here, so that they can be checked.
7151 * sysdep.c (reset_io): Now static.
7152 (wait_for_termination_signal): Remove; unused.
7154 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7155 (copy_keymap_item, append_key, push_text_char_description):
7157 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7158 (DENSE_TABLE_SIZE): Remove; unused.
7159 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7160 (describe_map_tree):
7161 Rename locals to avoid shadowing.
7163 * keyboard.c: Declare functions static if they are not used elsewhere.
7164 (echo_char, echo_dash, cmd_error, top_level_2):
7165 (poll_for_input, handle_async_input): Now static.
7166 (read_char, kbd_buffer_get_event, make_lispy_position):
7167 (make_lispy_event, make_lispy_movement, apply_modifiers):
7168 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7169 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7170 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7171 (read_key_sequence, read_char): Mark locals as initialized.
7172 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7174 * keyboard.h (make_ctrl_char): New decl.
7175 (mark_kboards): Move decl here ...
7176 * alloc.c (mark_kboards): ... from here.
7178 * lisp.h (force_auto_save_soon): New decl.
7180 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7181 (DEFINE_DUMMY_FUNCTION): New macro.
7182 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7184 (main): Add casts to avoid warnings
7185 if GCC considers string literals to be constants.
7187 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7189 * dbusbind.c: Pointer signedness fixes.
7190 (xd_signature, xd_append_arg, xd_initialize):
7191 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7192 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7193 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7194 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7196 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7197 if GCC considers string literals to be constants.
7198 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7200 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7202 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7203 (print_preprocess, print_object): New macro to fix last change.
7205 * print.c (print_preprocess): Don't forget font objects.
7207 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7209 * emacs.c (USAGE3): Doc fixes.
7211 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7213 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7216 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7218 * lisp.h (VWindow_system, Qfile_name_history):
7219 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7220 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7221 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7223 * w32select.c: Don't #include "keyboard.h".
7224 (run_protected): Add extern declaration for waiting_for_input.
7226 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7227 * w32console.c (detect_input_pending, read_input_pending)
7228 (encode_terminal_code):
7229 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7230 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7231 (w32_system_caret_y, Qfile_name_history):
7232 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7233 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7234 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7235 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7236 * w32proc.c (Qlocal, report_file_error):
7237 * w32term.c (Vwindow_system, updating_frame):
7238 * w32uniscribe.c (initialized, uniscribe_font_driver):
7239 Remove unneeded extern declarations.
7241 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7243 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7245 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7247 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7248 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7249 These macros can no longer be used for assignment.
7251 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7252 Assign struct members directly, instead of using BUF_BEGV etc.
7253 (record_buffer_markers, fetch_buffer_markers): New functions for
7254 recording and fetching special buffer markers.
7255 (set_buffer_internal_1, set_buffer_temp): Use them.
7257 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7259 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7261 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7262 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7264 * xdisp.c (hscroll_window_tree):
7265 (reconsider_clip_changes): Use PT instead of BUF_PT.
7267 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7269 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7270 $(EMACS_ROOT)/lib/intprops.h.
7272 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7274 Fix more problems found by GCC 4.5.2's static checks.
7276 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7277 to unsigned char * to avoid compiler diagnostic.
7278 (xg_free_frame_widgets): Make it clear that a local variable is
7279 needed only if USE_GTK_TOOLTIP.
7280 (gdk_window_get_screen): Make it clear that this macro is needed
7281 only if USE_GTK_TOOLTIP.
7282 (int_gtk_range_get_value): New function, which avoids a diagnostic
7283 from gcc -Wbad-function-cast.
7284 (xg_set_toolkit_scroll_bar_thumb): Use it.
7285 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7286 diagnostic from gcc -Wbad-function-cast.
7287 (get_utf8_string, xg_get_file_with_chooser):
7288 Rename locals to avoid shadowing.
7289 (create_dialog): Move locals to avoid shadowing.
7291 * xgselect.c (xg_select): Remove unused var.
7293 * image.c (four_corners_best): Mark locals as initialized.
7294 (gif_load): Initialize transparent_p to zero (Bug#8238).
7295 Mark another local as initialized.
7296 (my_png_error, my_error_exit): Mark with NO_RETURN.
7298 * image.c (clear_image_cache): Now static.
7299 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7300 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7301 (x_edge_detection): Remove unnecessary cast that
7302 gcc -Wbad-function-cast diagnoses.
7303 (gif_load): Fix pointer signedness.
7304 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7305 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7307 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7309 Improve quality of tests for time stamp overflow.
7310 For example, without this patch (encode-time 0 0 0 1 1
7311 1152921504606846976) returns the obviously-bogus value (-948597
7312 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7313 reports time overflow. See
7314 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7315 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7316 * editfns.c: Include limits.h and intprops.h.
7317 (TIME_T_MIN, TIME_T_MAX): New macros.
7318 (time_overflow): Move earlier, to before first use.
7319 (hi_time, lo_time): New functions, for an accurate test for
7321 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7322 (Fget_internal_run_time): Don't assume time_t fits in int.
7323 (make_time): Use list2 instead of Fcons twice.
7324 (Fdecode_time): More accurate test for out-of-range times.
7325 (check_tm_member): New function.
7326 (Fencode_time): Use it, to test for out-of-range times.
7327 (lisp_time_argument): Don't rely on undefined left-shift and
7328 right-shift behavior when checking for time stamp overflow.
7330 * editfns.c (time_overflow): New function, refactoring common code.
7331 (Fformat_time_string, Fdecode_time, Fencode_time):
7332 (Fcurrent_time_string): Use it.
7334 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7335 * dired.c (make_time): Move to ...
7336 * editfns.c (make_time): ... here.
7337 * systime.h: Note the move.
7339 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7341 * fringe.c (update_window_fringes): Remove unused variables.
7343 * unexmacosx.c (copy_data_segment): Also copy __got section.
7346 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7348 * termcap.c [MSDOS]: Include "msdos.h".
7349 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7350 Constify `char *' arguments and their references according to
7351 prototypes in tparam.h.
7353 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7355 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7356 Adapt all references accordingly.
7358 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7360 2011-03-11 Tom Tromey <tromey@redhat.com>
7362 * buffer.c (syms_of_buffer): Remove obsolete comment.
7364 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7366 * termhooks.h (encode_terminal_code): Declare prototype.
7368 * msdos.c (encode_terminal_code): Don't declare prototype.
7370 * term.c (encode_terminal_code): Now external again, used by
7371 w32console.c and msdos.c.
7373 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7374 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7376 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7378 Fix some minor problems found by GCC 4.5.2's static checks.
7380 * fringe.c (update_window_fringes): Mark locals as initialized
7382 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7384 * alloc.c (mark_fringe_data): Move decl from here ...
7385 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7386 to check its interface.
7387 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7389 * fontset.c (free_realized_fontset): Now static.
7390 (Fset_fontset_font): Rename local to avoid shadowing.
7391 (fontset_font): Mark local as initialized.
7392 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7394 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7396 * xselect.c (x_disown_buffer_selections): Remove; not used.
7397 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7398 (x_own_selection, Fx_disown_selection_internal): Rename locals
7400 (x_handle_dnd_message): Remove local to avoid shadowing.
7402 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7403 so that the caller can use some name other than gcpro1.
7404 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7405 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7406 (Fx_backspace_delete_keys_p):
7407 Use them to avoid shadowing, and rename vars to avoid shadowing.
7408 (x_decode_color, x_set_name, x_window): Now static.
7409 (Fx_create_frame): Add braces to silence GCC warning.
7410 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7411 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7412 Remove unused locals.
7413 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7414 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7415 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7418 * xterm.h (x_mouse_leave): New decl.
7420 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7421 Remove unused functions.
7422 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7423 (x_calc_absolute_position): Now static.
7424 (XTread_socket): Don't define label "out" unless it's used.
7425 Don't declare local "event" unless it's used.
7426 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7427 unless they are used.
7428 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7429 (x_fatal_error_signal): Remove; not used.
7430 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7431 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7432 (x_error_catcher, x_connection_closed, x_error_handler):
7433 (x_error_quitter, xembed_send_message, x_iconify_frame):
7434 (my_log_handler): Rename locals to avoid shadowing.
7435 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7436 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7438 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7439 Rename or move locals to avoid shadowing.
7440 (tty_defined_color, merge_face_heights): Now static.
7441 (free_realized_faces_for_fontset): Remove; not used.
7442 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7443 does not deduce is never used uninitialized.
7444 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7445 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7447 * terminal.c (store_terminal_param): Now static.
7449 * xmenu.c (menu_highlight_callback): Now static.
7450 (set_frame_menubar): Remove unused local.
7451 (xmenu_show): Rename parameter to avoid shadowing.
7452 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7453 since they might point to immutable storage.
7454 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7455 since it's unused otherwise.
7457 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7458 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7459 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7460 avoids a gcc -Wuninitialized diagnostic.
7461 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7462 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7463 does not deduce are never used uninitialized.
7465 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7467 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7468 * window.c (window_loop, size_window):
7469 (run_window_configuration_change_hook, enlarge_window): Likewise.
7471 * window.c (display_buffer): Now static.
7472 (size_window): Mark variables that gcc -Wuninitialized
7473 does not deduce are never used uninitialized.
7474 * window.h (check_all_windows): New decl, to forestall
7475 gcc -Wmissing-prototypes diagnostic.
7476 * dispextern.h (bidi_dump_cached_states): Likewise.
7478 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7480 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7482 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7483 and to avoid gcc -Wuninitialized warning.
7484 (load_charset_map): Mark variables that gcc -Wuninitialized
7485 does not deduce are never used uninitialized.
7486 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7488 * coding.c (coding_set_source, coding_set_destination):
7489 Use "else { /* comment */ }" rather than "else /* comment */;"
7490 for clarity, and to avoid gcc -Wempty-body warning.
7491 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7492 a block, when the outer 'i' will do.
7493 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7494 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7495 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7496 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7497 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7498 Rename locals to avoid shadowing.
7499 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7500 * coding.c (emacs_mule_char, encode_invocation_designation):
7501 Now static, since they're not used elsewhere.
7502 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7503 (decode_coding_object, encode_coding_object, detect_coding_system):
7504 (decode_coding_emacs_mule): Mark variables that gcc
7505 -Wuninitialized does not deduce are never used uninitialized.
7506 (detect_coding_iso_2022): Initialize a local variable that might
7507 be used uninitialized. Leave a FIXME because it's not clear that
7508 this initialization is needed. (Bug#8211)
7509 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7510 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7511 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7512 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7513 Remove unused macros.
7515 * category.c (hash_get_category_set): Remove unused local var.
7516 (copy_category_table): Now static, since it's not used elsewhere.
7517 * character.c (string_count_byte8): Likewise.
7519 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7520 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7522 * chartab.c (copy_sub_char_table): Now static, since it's not used
7524 (sub_char_table_ref_and_range, char_table_ref_and_range):
7525 Rename locals to avoid shadowing.
7526 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7528 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7529 (BIDI_BOB): Remove unused macro.
7531 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7532 deduce are never used uninitialized.
7533 * term.c (encode_terminal_code): Likewise.
7535 * term.c (encode_terminal_code): Now static. Remove unused local.
7537 * tparam.h: New file.
7538 * term.c, tparam.h: Include it.
7539 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7540 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7541 Move these decls to tparam.h, and make them agree with what
7542 is actually in tparam.c. The previous trick of using incompatible
7543 decls in different modules does not conform to the C standard.
7544 All callers of tparam changed to use tparam's actual API.
7545 * tparam.c (tparam1, tparam, tgoto):
7546 Use const pointers where appropriate.
7548 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7549 * cm.h (struct cm): Likewise.
7550 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7551 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7552 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7553 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7554 (turn_on_face, init_tty): Likewise.
7555 * termchar.h (struct tty_display_info): Likewise.
7557 * term.c (term_mouse_position): Rename local to avoid shadowing.
7559 * alloc.c (mark_ttys): Move decl from here ...
7560 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7562 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7564 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7566 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7568 * search.c (compile_pattern_1): Remove argument regp, unused since
7569 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7570 (compile_pattern): Don't pass it.
7572 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7574 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7575 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7577 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7579 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7581 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7582 gdk_window_get_screen, gdk_window_get_geometry,
7583 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7584 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7585 (xg_get_pixbuf_from_pixmap): New function.
7586 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7587 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7588 Call xg_get_pixbuf_from_pixmap instead of
7589 gdk_pixbuf_get_from_drawable.
7590 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7591 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7592 (xg_check_special_colors): Use GtkStyleContext and its functions
7594 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7595 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7596 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7597 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7598 Call gtk_widget_get_preferred_size.
7599 (xg_frame_resized): gdk_window_get_geometry only takes 5
7601 (xg_win_to_widget, xg_event_is_for_menubar):
7602 Call gdk_x11_window_lookup_for_display.
7603 (xg_set_widget_bg): New function.
7604 (delete_cb): New function.
7605 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7606 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7607 (xg_set_background_color): Call xg_set_widget_bg.
7608 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7609 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7610 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7611 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7613 (update_frame_tool_bar): Call gtk_widget_hide.
7614 (xg_initialize): Use GDK_KEY_g.
7616 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7618 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7620 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7621 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7622 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7624 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7626 * w32xfns.c (select_palette): Check success of RealizePalette against
7627 GDI_ERROR, not zero.
7629 See ChangeLog.11 for earlier changes.
7635 Copyright (C) 2011 Free Software Foundation, Inc.
7637 This file is part of GNU Emacs.
7639 GNU Emacs is free software: you can redistribute it and/or modify
7640 it under the terms of the GNU General Public License as published by
7641 the Free Software Foundation, either version 3 of the License, or
7642 (at your option) any later version.
7644 GNU Emacs is distributed in the hope that it will be useful,
7645 but WITHOUT ANY WARRANTY; without even the implied warranty of
7646 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7647 GNU General Public License for more details.
7649 You should have received a copy of the GNU General Public License
7650 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.