Fix compilation with GLYPH_DEBUG.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2
3 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5
6 * xdisp.c (move_it_in_display_line_to): Record the best matching
7 position for TO_CHARPOS while scanning the line, and restore it on
8 exit if none of the characters scanned was an exact match. Fixes
9 vertical-motion and pos-visible-in-window-p under bidi redisplay
10 when exact match is impossible due to invisible text, and the
11 lines are truncated.
12
13 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
14
15 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
16 for OSX >= 10.7.
17
18 2011-07-22 Eli Zaretskii <eliz@gnu.org>
19
20 Fix a significant slow-down of cursor motion with C-n, C-p,
21 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
22 auto-repeat under bidi redisplay in fontified buffers.
23 * xdisp.c (compute_stop_pos_backwards): New function.
24 (next_element_from_buffer): Call compute_stop_pos_backwards to
25 find a suitable prev_stop when we find ourselves before
26 base_level_stop.
27 (reseat): Don't look for prev_stop, as that could mean a very long
28 run.
29 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
30 <cached_disp_overlay_modiff>: Cache for last found display string
31 position.
32 (compute_display_string_pos): Return the cached position if asked
33 about the same buffer in the same area of character positions, and
34 the buffer wasn't changed since the time the display string
35 position was cached.
36
37 2011-07-22 Eli Zaretskii <eliz@gnu.org>
38
39 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
40 is an integer, which is important for empty lines. (Bug#9149)
41
42 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
43
44 * frame.c (Fmodify_frame_parameters): In tty case, update the
45 default face if necessary (Bug#4238).
46
47 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
48
49 * editfns.c (Fstring_to_char): No need to explain what a character
50 is in the docstring (Bug#6576).
51
52 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
53
54 * xml.c (parse_region): Make sure we always return a tree.
55
56 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
57
58 * xml.c (parse_region): If a document contains only comments,
59 return that, too.
60
61 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
62
63 * xml.c (make_dom): Return comments, too.
64
65 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
66
67 Port to OpenBSD.
68 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
69 and the surrounding thread.
70 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
71 rather than fgets, and retry after EINTR. Otherwise, 'emacs
72 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
73 timer goes off.
74 * s/openbsd.h (BROKEN_SIGIO): Define.
75 * unexelf.c (unexec) [__OpenBSD__]:
76 Don't update the .mdebug section of the Alpha COFF symbol table.
77
78 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
79
80 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
81 (bug#8460).
82
83 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
84
85 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
86 This fixes some race conditions on the permissions of any newly
87 created file.
88
89 * alloc.c (valid_pointer_p): Use pipe, not open.
90 This fixes some permissions issues when debugging.
91
92 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
93 If fchown fails to set both uid and gid, try to set just gid,
94 as that is sometimes allowed. Adjust the file's mode to eliminate
95 setuid or setgid bits that are inappropriate if fchown fails.
96
97 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
98
99 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
100 to compare Lisp_Objects.
101 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
102 global_gnutls_log_level, don't mistake it for a Lisp_Object.
103 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
104
105 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
106
107 * lread.c (read_integer): Unread even EOF character.
108 (read1): Likewise. Properly record start position of symbol.
109
110 * lread.c (read1): Read `#:' as empty uninterned symbol if no
111 symbol character follows.
112
113 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
114
115 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
116 This works around a problem with the previous change to Fcopy_file.
117 Recent glibc declares fchown with __attribute__((warn_unused_result)),
118 and without this change, GCC might complain about discarding
119 fchown's return value.
120
121 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
122
123 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
124
125 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
126
127 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
128
129 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
130
131 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
132 it's used from the C level.
133
134 * process.c: Use the same condition for POLL_FOR_INPUT in both
135 keyboard.c and process.c (bug#1858).
136
137 2011-07-09 Lawrence Mitchell <wence@gmx.li>
138
139 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
140 (Fgnutls_boot): Use it.
141
142 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
143
144 * doc.c (Fsubstitute_command_keys): Revert last change.
145
146 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
147
148 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
149 quotes the next character, and doesn't affect other longer
150 sequences (bug#8935).
151
152 * lread.c (syms_of_lread): Clarify that is isn't only
153 `eval-buffer' and `eval-defun' that's affected by
154 `lexical-binding' (bug#8460).
155
156 2011-07-15 Eli Zaretskii <eliz@gnu.org>
157
158 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
159 bidi redisplay when a line includes both an image and is
160 truncated.
161
162 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
163
164 Fix minor problems found by static checking.
165 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
166 (elsz): Now a signed constant, not a size_t var. We prefer signed
167 types to unsigned, to avoid integer comparison confusion. Without
168 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
169 "cannot optimize loop, the loop counter may overflow", a symptom
170 of the confusion.
171 * indent.c (Fvertical_motion): Mark locals as initialized.
172 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
173
174 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
175
176 * search.c (Fre_search_backward): Mention `case-fold-search' in
177 all the re_search_* functions (bug#8138).
178
179 * keyboard.c (Fopen_dribble_file): Document when the file is
180 closed (bug#8056).
181
182 2011-07-14 Eli Zaretskii <eliz@gnu.org>
183
184 * bidi.c (bidi_dump_cached_states): Fix format of displaying
185 bidi_cache_idx.
186
187 Support bidi reordering of display and overlay strings.
188 * xdisp.c (compute_display_string_pos)
189 (compute_display_string_end): Accept additional argument STRING.
190 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
191 (reseat_to_string): Initialize bidi_it->string.s and
192 bidi_it->string.schars.
193 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
194 NULL (avoids a crash in bidi_paragraph_init). Initialize
195 itb.string.lstring.
196 (init_iterator): Call bidi_init_it only of a valid
197 buffer position was specified. Initialize paragraph_embedding to
198 L2R.
199 (reseat_to_string): Initialize the bidi iterator.
200 (display_string): If we need to ignore text properties of
201 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
202 original value of -1 will not work with bidi.)
203 (compute_display_string_pos): First arg is now struct
204 `text_pos *'; all callers changed. Support display properties on
205 Lisp strings.
206 (compute_display_string_end): Support display properties on Lisp
207 strings.
208 (init_iterator, reseat_1, reseat_to_string): Initialize the
209 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
210 when iterating on a string not from display properties).
211 (compute_display_string_pos, compute_display_string_end): Fix
212 calculation of the object to scan. Fixes an error when using
213 arrow keys.
214 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
215 base_level_stop; instead, set base_level_stop to BEGV. Fixes
216 crashes in vertical-motion.
217 (next_element_from_buffer): Improve commentary for when
218 the iterator is before prev_stop.
219 (init_iterator): Initialize bidi_p from the default value of
220 bidi-display-reordering, not from buffer-local value. Use the
221 buffer-local value only if initializing for buffer iteration.
222 (handle_invisible_prop): Support invisible properties on strings
223 that are being bidi-reordered.
224 (set_iterator_to_next): Support bidi reordering of C strings and
225 Lisp strings.
226 (next_element_from_string): Support bidi reordering of Lisp
227 strings.
228 (handle_stop_backwards): Support Lisp strings as well.
229 (display_string): Support display of R2L glyph rows. Use
230 IT_STRING_CHARPOS when displaying from a Lisp string.
231 (init_iterator): Don't initialize it->bidi_p for strings
232 here.
233 (reseat_to_string): Initialize it->bidi_p for strings here.
234 (next_element_from_string, next_element_from_c_string)
235 (next_element_from_buffer): Add xassert's for correspondence
236 between IT's object being iterated and it->bidi_it.string
237 structure.
238 (face_before_or_after_it_pos): Support bidi iteration.
239 (next_element_from_c_string): Handle the case of the first string
240 character that is not the first one in the visual order.
241 (get_visually_first_element): New function, refactored from common
242 parts of next_element_from_buffer, next_element_from_string, and
243 next_element_from_c_string.
244 (tool_bar_lines_needed, redisplay_tool_bar)
245 (display_menu_bar): Force left-to-right direction. Add a FIXME
246 comment for making that be controlled by a user option.
247 (push_it, pop_it): Save and restore the state of the
248 bidi iterator. Save and restore the bidi_p flag.
249 (pop_it): Iterate out of display property for string iteration as
250 well.
251 (iterate_out_of_display_property): Support iteration over strings.
252 (handle_single_display_spec): Set up it->bidi_it for iteration
253 over a display string, and call bidi_init_it.
254 (handle_single_display_spec, next_overlay_string)
255 (get_overlay_strings_1, push_display_prop): Set up the bidi
256 iterator for displaying display or overlay strings.
257 (forward_to_next_line_start): Don't use the shortcut if
258 bidi-iterating.
259 (back_to_previous_visible_line_start): If handle_display_prop
260 pushed the iterator stack, restore the internal state of the bidi
261 iterator by calling bidi_pop_it same number of times.
262 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
263 and we are bidi-iterating, don't decrement the iterator position;
264 instead, set the first_elt flag in the bidi iterator, to produce
265 the same effect.
266 (reseat_1): Remove redundant setting of string_from_display_prop_p.
267 (push_display_prop): xassert that we are iterating a buffer.
268 (push_it, pop_it): Save and restore paragraph_embedding member.
269 (handle_single_display_spec, next_overlay_string)
270 (get_overlay_strings_1, reseat_1, reseat_to_string)
271 (push_display_prop): Set up the `unibyte' member of bidi_it.string
272 correctly. Don't assume unibyte strings are not bidi-reordered.
273 (compute_display_string_pos)
274 (compute_display_string_end): Fix handling the case of C string.
275 (push_it, pop_it): Save and restore from_disp_prop_p.
276 (handle_single_display_spec, push_display_prop): Set the
277 from_disp_prop_p flag.
278 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
279 (pop_it): Call iterate_out_of_display_property only if we are
280 popping after iteration over a string that came from a display
281 property. Fix a typo in popping stretch info. Add an assertion
282 for verifying that the iterator position is in sync with the bidi
283 iterator.
284 (handle_single_display_spec, get_overlay_strings_1)
285 (push_display_prop): Fix initialization of paragraph direction for
286 string when that of the parent object is not yet determined.
287 (reseat_1): Call bidi_init_it to resync the bidi
288 iterator with IT's position. (Bug#7616)
289 (find_row_edges): If ROW->start.pos gives position
290 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
291 (handle_stop, back_to_previous_visible_line_start, reseat_1):
292 Reset the from_disp_prop_p flag.
293 (SAVE_IT, RESTORE_IT): New macros.
294 (pos_visible_p, face_before_or_after_it_pos)
295 (back_to_previous_visible_line_start)
296 (move_it_in_display_line_to, move_it_in_display_line)
297 (move_it_to, move_it_vertically_backward, move_it_by_lines)
298 (try_scrolling, redisplay_window, display_line): Use them when
299 saving a temporary copy of the iterator and restoring it back.
300 (back_to_previous_visible_line_start, reseat_1)
301 (init_iterator): Empty the bidi cache "stack".
302 (move_it_in_display_line_to): If iterator ended up at
303 EOL, but we never saw any buffer positions smaller than
304 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
305 motion in bidi-reordered lines.
306 (move_it_in_display_line_to): Record prev_method and prev_pos
307 immediately before the call to set_iterator_to_next. Fixes cursor
308 motion in bidi-reordered lines with stretch glyphs and strings
309 displayed in margins. (Bug#8133) (Bug#8867)
310 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
311 TO_CHARPOS.
312 (pos_visible_p): Support positions in bidi-reordered lines. Save
313 and restore bidi cache.
314
315 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
316 (bidi_paragraph_info): Delete unused struct.
317 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
318 (bidi_cache_start): New variable.
319 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
320 to zero.
321 (bidi_cache_fetch_state, bidi_cache_search)
322 (bidi_cache_find_level_change, bidi_cache_iterator_state)
323 (bidi_cache_find, bidi_peek_at_next_level)
324 (bidi_level_of_next_char, bidi_find_other_level_edge)
325 (bidi_move_to_visually_next): Compare cache index with
326 bidi_cache_start rather than with zero.
327 (bidi_fetch_char): Accept new argument STRING; all callers
328 changed. Support iteration over a string. Support strings with
329 display properties. Support unibyte strings. Fix the type of
330 `len' according to what STRING_CHAR_AND_LENGTH expects.
331 (bidi_paragraph_init, bidi_resolve_explicit_1)
332 (bidi_resolve_explicit, bidi_resolve_weak)
333 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
334 iteration over a string.
335 (bidi_set_sor_type, bidi_resolve_explicit_1)
336 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
337 can now be zero (for strings); special values 0 and -1 were
338 changed to -1 and -2, respectively.
339 (bidi_char_at_pos): New function.
340 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
341 Call it instead of FETCH_MULTIBYTE_CHAR.
342 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
343 initialized to valid values.
344 (bidi_init_it): Don't initialize charpos and bytepos with invalid
345 values.
346 (bidi_level_of_next_char): Allow the sentinel "position" to pass
347 the test for valid cached positions. Fix the logic for looking up
348 the sentinel state in the cache. GCPRO the Lisp string we are
349 iterating.
350 (bidi_push_it, bidi_pop_it): New functions.
351 (bidi_initialize): Initialize the bidi cache start stack pointer.
352 (bidi_cache_ensure_space): New function, refactored from part of
353 bidi_cache_iterator_state. Don't assume the required size is just
354 one BIDI_CACHE_CHUNK away.
355 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
356 (bidi_count_bytes, bidi_char_at_pos): New functions.
357 (bidi_cache_search): Don't assume bidi_cache_last_idx is
358 always valid if bidi_cache_idx is valid.
359 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
360 is valid if it's going to be used.
361 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
362 (bidi_cache_fetch_state, bidi_cache_search)
363 (bidi_cache_find_level_change, bidi_cache_ensure_space)
364 (bidi_cache_iterator_state, bidi_cache_find)
365 (bidi_find_other_level_edge, bidi_cache_start_stack): All
366 variables related to cache indices are now EMACS_INT.
367
368 * dispextern.h (struct bidi_string_data): New structure.
369 (struct bidi_it): New member `string'. Make flag members be 1-bit
370 fields, and put them last in the struct.
371 (compute_display_string_pos, compute_display_string_end): Update
372 prototypes.
373 (bidi_push_it, bidi_pop_it): Add prototypes.
374 (struct iterator_stack_entry): New members bidi_p,
375 paragraph_embedding, and from_disp_prop_p.
376 (struct it): Member bidi_p is now a bit field 1 bit wide.
377 (bidi_shelve_cache, bidi_unshelve_cache): Declare
378 prototypes.
379
380 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
381 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
382 and vector-like objects.
383
384 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
385 cache around display iteration.
386
387 * window.c (Fwindow_end, window_scroll_pixel_based)
388 (displayed_window_lines, Frecenter): Save and restore the bidi
389 cache around display iteration.
390
391 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
392
393 * editfns.c (Fdelete_region): Clarify the use of the named
394 parameters (bug#6788).
395
396 2011-07-14 Martin Rudalics <rudalics@gmx.at>
397
398 * indent.c (Fvertical_motion): Set and restore w->pointm when
399 saving and restoring the window's buffer (Bug#9006).
400
401 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
402
403 * editfns.c (Fstring_to_char): Clarify just what is returned
404 (bug#6576). Text by Eli Zaretskii.
405
406 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
407
408 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
409
410 2011-07-13 Eli Zaretskii <eliz@gnu.org>
411
412 * buffer.c (mmap_find): Fix a typo.
413
414 2011-07-13 Johan Bockgård <bojohan@gnu.org>
415
416 Fix execution of x selection hooks.
417 * xselect.c (Qx_lost_selection_functions)
418 (Qx_sent_selection_functions): New vars.
419 (syms_of_xselect): DEFSYM them.
420 (x_handle_selection_request): Pass Qx_sent_selection_functions
421 rather than Vx_sent_selection_functions to Frun_hook_with_args.
422 (x_handle_selection_clear,x_clear_frame_selections):
423 Pass Qx_lost_selection_functions rather than
424 Vx_lost_selection_functions to Frun_hook_with_args.
425
426 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
427
428 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
429 The old code sometimes used this field without initializing it.
430
431 * alloc.c (gc_sweep): Don't read past end of array.
432 In theory, the old code could also have corrupted Emacs internals,
433 though it'd be very unlikely.
434
435 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
436
437 * character.c (Fcharacterp): Don't advertise optional ignored
438 argument. (Bug#4026)
439
440 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
441
442 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
443 key" (bug#4257).
444
445 * window.c (Fset_window_start): Doc fix (bug#4199).
446 (Fset_window_hscroll): Ditto.
447
448 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
449
450 Fix minor new problems caught by GCC 4.6.1.
451 * term.c (init_tty): Remove unused local.
452 * xsettings.c (store_monospaced_changed): Define this function only
453 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
454 not used otherwise.
455
456 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
457
458 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
459
460 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
461
462 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
463 are the mini-buffer and the echo area (bug#3320).
464
465 * term.c (init_tty): Remove support for supdup, c10 and perq
466 terminals, which are no longer supported (bug#1482).
467
468 2011-07-10 Johan Bockgård <bojohan@gnu.org>
469
470 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
471
472 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
473
474 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
475 for non-popups (Bug#3642).
476
477 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
478
479 * alloc.c (reset_malloc_hooks): Protoize.
480 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
481 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
482 * cm.c (losecursor): Likewise.
483 * data.c (fmod): Likewise.
484 * dispnew.c (swap_glyphs_in_rows): Likewise.
485 * emacs.c (memory_warning_signal): Likewise.
486 * floatfns.c (float_error): Likewise.
487 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
488 (otf_open, font_otf_capability, generate_otf_features)
489 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
490 Likewise.
491 * image.c (pbm_read_file): Likewise.
492 * indent.c (string_display_width): Likewise.
493 * intervals.c (check_for_interval, search_for_interval)
494 (inc_interval_count, count_intervals, root_interval)
495 (adjust_intervals_for_insertion, make_new_interval): Likewise.
496 * lread.c (defalias): Likewise.
497 * ralloc.c (r_alloc_check): Likewise.
498 * regex.c (set_image_of_range_1, set_image_of_range)
499 (regex_grow_registers): Likewise.
500 * sysdep.c (strerror): Likewise.
501 * termcap.c (valid_filename_p, tprint, main): Likewise.
502 * tparam.c (main): Likewise.
503 * unexhp9k800.c (run_time_remap, save_data_space)
504 (update_file_ptrs, read_header, write_header, calculate_checksum)
505 (copy_file, copy_rest, display_header): Likewise.
506 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
507 Likewise.
508 * xdisp.c (check_it): Likewise.
509 * xfaces.c (register_color, unregister_color, unregister_colors):
510 Likewise.
511 * xfns.c (print_fontset_result): Likewise.
512 * xrdb.c (member, fatal, main): Likewise.
513
514 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
515
516 Fix minor problems found by static checking (Bug#9031).
517 * chartab.c (char_table_set_range, map_sub_char_table):
518 Remove unused locals.
519 (uniprop_table): Now static.
520 * composite.c (_work_char): Remove unused static var.
521
522 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
523
524 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
525
526 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
527
528 * gtkutil.c (qttip_cb): Remove code without function.
529
530 2011-07-09 Eli Zaretskii <eliz@gnu.org>
531
532 * w32.c (pthread_sigmask): New stub.
533
534 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
535
536 Use pthread_sigmask, not sigprocmask (Bug#9010).
537 sigprocmask is portable only for single-threaded applications, and
538 Emacs can be multi-threaded when it uses GTK.
539 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
540 (LIBES): Use it.
541 * callproc.c (Fcall_process):
542 * process.c (create_process):
543 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
544 Use pthread_sigmask, not sigprocmask.
545
546 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
547
548 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
549 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
550 wrong (Bug#8591).
551
552 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
553
554 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
555 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
556 (xg_hide_tooltip): Fix comment.
557
558 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
559 in registerServicesMenuSendTypes.
560 (validRequestorForSendType): Don't check ns_return_types.
561
562 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
563 ns_return_type.
564
565 2011-07-08 Jason Rumney <jasonr@gnu.org>
566
567 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
568 frame struct members of non-existent frames (Bug#6284).
569
570 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
571
572 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
573 variable firstTime not needed on OSX >= 10.6.
574 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
575 >= 10.5. Use setKnobProportion, setDoubleValue.
576
577 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
578 (MAC_OS_X_VERSION_10_5): Define if not defined.
579 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
580 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
581 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
582
583 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
584 cString and lossyCString on OSX >= 10.4
585
586 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
587 sizeToFit on OSX >= 10.2.
588
589 * nsimage.m (allocInitFromFile): Don't use deprecated method
590 bestRepresentationForDevice on OSX >= 10.6.
591
592 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
593 to avoid warning.
594
595 * emacs.c: Declare unexec_init_emacs_zone.
596
597 * nsgui.h: Fix compiler warning about gnulib redefining verify.
598
599 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
600
601 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
602 on svcsMenu (Bug#8842).
603
604 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
605 ns_return_types.
606 (Fns_list_services): Just return Qnil on 10.6, code not working there.
607
608 * nsterm.m (QUTF8_STRING): Declare.
609 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
610 (validRequestorForSendType): Return type is (id).
611 Change indexOfObjectIdenticalTo to indexOfObject.
612 Check if we have local selection before returning self (Bug#8842).
613 (writeSelectionToPasteboard): Put local selection into paste board
614 if we have a local selection (Bug#8842).
615 (syms_of_nsterm): DEFSYM QUTF8_STRING.
616
617 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
618 (ns_get_local_selection): Declare.
619
620 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
621
622 * keymap.c (describe_map_tree): Don't insert a double newline at
623 the end of the buffer (bug#1169) and return whether we inserted
624 something.
625
626 * callint.c (Fcall_interactively): Change "reading args" to
627 "providing args" to try to clarify what it does (bug#1010).
628
629 2011-07-07 Kenichi Handa <handa@m17n.org>
630
631 * composite.c (composition_compute_stop_pos): Ignore a static
632 composition starting before CHARPOS (Bug#8915).
633
634 * xdisp.c (handle_composition_prop): Likewise.
635
636 2011-07-07 Eli Zaretskii <eliz@gnu.org>
637
638 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
639 (Bug#9015)
640
641 2011-07-07 Kenichi Handa <handa@m17n.org>
642
643 * character.h (unicode_category_t): New enum type.
644
645 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
646 (Qchar_code_property_table): New variable.
647 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
648 (UNIPROP_COMPRESSED_FORM_P): New macros.
649 (char_table_ascii): Uncompress the compressed values.
650 (sub_char_table_ref): New arg is_uniprop. Callers changed.
651 Uncompress the compressed values.
652 (sub_char_table_ref_and_range): Likewise.
653 (char_table_ref_and_range): Uncompress the compressed values.
654 (sub_char_table_set): New arg is_uniprop. Callers changed.
655 Uncompress the compressed values.
656 (sub_char_table_set_range): Args changed. Callers changed.
657 (char_table_set_range): Adjuted for the above change.
658 (map_sub_char_table): Delete args default_val and parent. Add arg
659 top. Give decoded values to a Lisp function.
660 (map_char_table): Adjusted for the above change. Give decoded
661 values to a Lisp function. Gcpro more variables.
662 (uniprop_table_uncompress)
663 (uniprop_decode_value_run_length): New functions.
664 (uniprop_decoder, uniprop_decoder_count): New variables.
665 (uniprop_get_decoder, uniprop_encode_value_character)
666 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
667 New functions.
668 (uniprop_encoder, uniprop_encoder_count): New variables.
669 (uniprop_get_encoder, uniprop_table)
670 (Funicode_property_table_internal, Fget_unicode_property_internal)
671 (Fput_unicode_property_internal): New functions.
672 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
673 Sunicode_property_table_internal, Sget_unicode_property_internal,
674 and Sput_unicode_property_internal. Defvar_lisp
675 char-code-property-alist.
676
677 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
678 Vunicode_category_table.
679
680 * font.c (font_range): Adjusted for the change of
681 Vunicode_category_table.
682
683 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
684
685 * m/iris4d.h: Remove file, move contents ...
686 * s/irix6-5.h: ... here.
687
688 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
689
690 Remove unportable assumption about struct layout (Bug#8884).
691 * alloc.c (mark_buffer):
692 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
693 (clone_per_buffer_values): Don't assume that
694 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
695 This isn't true in general, and it's particularly not true
696 if Emacs is configured with --with-wide-int.
697 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
698 New macros, used in the buffer.c change.
699
700 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
701
702 * xsettings.c: Use both GConf and GSettings if both are available.
703 (store_config_changed_event): Add comment.
704 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
705 (store_tool_bar_style_changed): New functions.
706 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
707 (struct xsettings): Move font inside HAVE_XFT.
708 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
709 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
710 Move inside HAVE_XFT.
711 (something_changed_gsettingsCB): Renamed from something_changedCB.
712 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
713 also.
714 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
715 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
716 (something_changed_gconfCB): Renamed from something_changedCB.
717 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
718 (parse_settings): Move check for font inside HAVE_XFT.
719 (read_settings, apply_xft_settings): Add comment.
720 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
721 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
722 call store_font_name_changed.
723 (xft_settings_event): Add comment.
724 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
725 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
726 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
727 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
728 (xsettings_initialize): Call init_gsettings last.
729 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
730 comment.
731
732 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
733
734 Random fixes. E.g., (random) never returned negative values.
735 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
736 subseconds part to the entropy, as that's a bit more random.
737 Prefer signed to unsigned, since the signedness doesn't matter and
738 in general we prefer signed. When given a limit, use a
739 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
740 latter isn't right if USE_2_TAGS_FOR_INTS.
741 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
742 not 0..VALMASK. Don't discard "excess" bits that random () returns.
743
744 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
745
746 * textprop.c (text_property_stickiness):
747 Obey Vtext_property_default_nonsticky.
748 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
749 * w32fns.c (syms_of_w32fns):
750 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
751
752 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
753
754 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
755 This is more efficient than Ffile_directory_p and avoids a minor race.
756
757 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
758
759 * buffer.c (Foverlay_put): Say what the return value is
760 (bug#7835).
761
762 * fileio.c (barf_or_query_if_file_exists): Check first if the file
763 is a directory before asking whether to use the file name
764 (bug#7564).
765 (barf_or_query_if_file_exists): Make the "File is a directory"
766 error be more correct.
767
768 * fns.c (Frequire): Remove the mention of the .gz files, since
769 that's installation-specific, but keep the mention of
770 `get-load-suffixes'.
771
772 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
773
774 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
775 Report string overflow if the output is too long.
776
777 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
778
779 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
780 (syms_of_gnutls): Remove duplicate DEFSYM for
781 Qgnutls_bootprop_verify_hostname_error, an error for
782 Qgnutls_bootprop_verify_error (which is no longer used).
783
784 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
785 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
786 Also (re)move comments that are misplaced or no longer relevant.
787
788 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
789
790 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
791
792 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
793
794 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
795 and background color parameters if they have been changed.
796
797 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
798
799 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
800
801 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
802
803 * xsettings.c (SYSTEM_FONT): Define only when used.
804 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
805
806 * keymap.c (access_keymap_1): Now static.
807
808 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
809
810 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
811 leave any prefix arg for the up event (Bug#1586).
812
813 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
814
815 * lread.c (syms_of_lread): Mention single symbols defined by
816 `defvar' or `defconst' (bug#7154).
817
818 * fns.c (Frequire): Mention .el.gz files (bug#7314).
819 (Frequire): Mention get-load-suffixes.
820
821 2011-07-02 Martin Rudalics <rudalics@gmx.at>
822
823 * window.h (window): Remove clone_number slot.
824 * window.c (Fwindow_clone_number, Fset_window_clone_number):
825 Remove.
826 (make_parent_window, make_window, saved_window)
827 (Fset_window_configuration, save_window_save): Don't deal with
828 clone numbers.
829 * buffer.c (Qclone_number): Remove declaration.
830 (sort_overlays, overlay_strings): Don't deal with clone numbers.
831
832 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
833
834 Add multiple inheritance to keymaps.
835 * keymap.c (Fmake_composed_keymap): New function.
836 (Fset_keymap_parent): Simplify.
837 (fix_submap_inheritance): Remove.
838 (access_keymap_1): New function extracted from access_keymap to handle
839 embedded parents and handle lists of maps.
840 (access_keymap): Use it.
841 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
842 (Fcopy_keymap): Handle embedded parents.
843 (Fcommand_remapping, define_as_prefix): Simplify.
844 (Fkey_binding): Simplify.
845 (syms_of_keymap): Move minibuffer-local-completion-map,
846 minibuffer-local-filename-completion-map,
847 minibuffer-local-must-match-map, and
848 minibuffer-local-filename-must-match-map to Elisp.
849 (syms_of_keymap): Defsubr make-composed-keymap.
850 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
851 (parse_menu_item): Trivial simplification.
852
853 2011-07-01 Glenn Morris <rgm@gnu.org>
854
855 * Makefile.in (SETTINGS_LIBS): Fix typo.
856
857 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
858
859 * coding.c (Fencode_coding_string): Record the last coding system
860 used, as the function doc string says (bug#8738).
861
862 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
863
864 * xsettings.c (store_monospaced_changed): Take new font as arg and
865 check for change against current_mono_font.
866 (EMACS_TYPE_SETTINGS): Remove this and related defines.
867 (emacs_settings_constructor, emacs_settings_get_property)
868 (emacs_settings_set_property, emacs_settings_class_init)
869 (emacs_settings_init, gsettings_obj): Remove.
870 (something_changedCB): New function for HAVE_GSETTINGS.
871 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
872 with value as argument.
873 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
874 g_settings_new (Bug#8967). Do not create gsettings_obj.
875 Remove calls to g_settings_bind. Connect something_changedCB to
876 "changed".
877
878 * xgselect.c: Add defined (HAVE_GSETTINGS).
879 (xgselect_initialize): Ditto.
880
881 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
882 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
883 xg_select.
884
885 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
886
887 * eval.c (struct backtrace): Simplify and port the data structure.
888 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
889 signed bit field, as this assumption is not portable and it makes
890 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
891 "char debug_on_exit : 1" as this is not portable either; instead,
892 use the portable "unsigned int debug_on_exit : 1". Remove unused
893 member evalargs. Remove obsolete comments about cc bombing out.
894
895 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
896
897 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
898 Let HAVE_GSETTINGS override HAVE_GCONF.
899 (store_monospaced_changed): New function.
900 (EMACS_SETTINGS): A new type derived from GObject to handle
901 GSettings notifications.
902 (emacs_settings_constructor, emacs_settings_get_property)
903 (emacs_settings_set_property, emacs_settings_class_init):
904 New functions.
905 (gsettings_client, gsettings_obj): New variables.
906 (GSETTINGS_SCHEMA): New define.
907 (something_changedCB): Call store_monospaced_changed.
908 (init_gsettings): New function.
909 (xsettings_initialize): Call init_gsettings.
910 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
911 to NULL.
912
913 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
914 GCONF_CFLAGS/LIBS.
915
916 2011-06-29 Martin Rudalics <rudalics@gmx.at>
917
918 * window.c (resize_root_window, grow_mini_window)
919 (shrink_mini_window): Rename Qresize_root_window to
920 Qwindow_resize_root_window and Qresize_root_window_vertically to
921 Qwindow_resize_root_window_vertically.
922
923 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
924
925 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
926
927 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
928
929 * makefile.w32-in: Redesign dependencies so they reflect more
930 clearly which files are directly included by each source file,
931 and not through other includes.
932
933 2011-06-27 Martin Rudalics <rudalics@gmx.at>
934
935 * buffer.c (Qclone_number): Declare static and DEFSYM it.
936 (sort_overlays, overlay_strings): When an overlay's clone number
937 matches the window's clone number process the overlay even if
938 the overlay's window property doesn't match the current window.
939
940 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
941 (Fwindow_hchild): Rename to Fwindow_left_child.
942 (Fwindow_next): Rename to Fwindow_next_sibling.
943 (Fwindow_prev): Rename to Fwindow_prev_sibling.
944 (resize_window_check): Rename to window_resize_check.
945 (resize_window_apply): Rename to window_resize_apply.
946 (Fresize_window_apply): Rename to Fwindow_resize_apply.
947 (Fdelete_other_windows_internal, resize_frame_windows)
948 (Fsplit_window_internal, Fdelete_window_internal)
949 (grow_mini_window, shrink_mini_window)
950 (Fresize_mini_window_internal): Fix callers accordingly.
951
952 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
953
954 * emacsgtkfixed.h: State that this is only used with Gtk+3.
955 (emacs_fixed_set_min_size): Remove.
956 (emacs_fixed_new): Take frame as argument.
957
958 * emacsgtkfixed.c: State that this is only used with Gtk+3.
959 (_EmacsFixedPrivate): Remove minwidth/height.
960 Add struct frame *f.
961 (emacs_fixed_init): Initialize priv->f.
962 (get_parent_class, emacs_fixed_set_min_size): Remove.
963 (emacs_fixed_new): Set priv->f to argument.
964 (emacs_fixed_get_preferred_width)
965 (emacs_fixed_get_preferred_height): Use min_width/height from
966 frames size_hint to set minimum and natural (Bug#8919).
967 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
968 and use min_width/height from frames size_hint to set
969 min_width/height (Bug#8919).
970
971 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
972 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
973 Fix indentation.
974
975 2011-06-26 Eli Zaretskii <eliz@gnu.org>
976
977 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
978 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
979 called at ZV.
980
981 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
982
983 * process.c (wait_reading_process_output): Bypass select if
984 waiting for a cell while ignoring keyboard input, and input is
985 pending. Suggested by Jan Djärv (Bug#8869).
986
987 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
988
989 Use gnulib's dup2 module instead of rolling our own.
990 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
991
992 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
993
994 * dispnew.c (scrolling_window): Before scrolling, turn off a
995 mouse-highlight in the window being scrolled.
996
997 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
998
999 Move DEFSYM to lisp.h and use everywhere.
1000
1001 * character.h (DEFSYM): Move declaration...
1002 * lisp.h (DEFSYM): ...here.
1003
1004 * gnutls.c:
1005 * minibuf.c:
1006 * w32menu.c:
1007 * w32proc.c:
1008 * w32select.c: Don't include character.h.
1009
1010 * alloc.c (syms_of_alloc):
1011 * buffer.c (syms_of_buffer):
1012 * bytecode.c (syms_of_bytecode):
1013 * callint.c (syms_of_callint):
1014 * casefiddle.c (syms_of_casefiddle):
1015 * casetab.c (init_casetab_once):
1016 * category.c (init_category_once, syms_of_category):
1017 * ccl.c (syms_of_ccl):
1018 * cmds.c (syms_of_cmds):
1019 * composite.c (syms_of_composite):
1020 * dbusbind.c (syms_of_dbusbind):
1021 * dired.c (syms_of_dired):
1022 * dispnew.c (syms_of_display):
1023 * doc.c (syms_of_doc):
1024 * editfns.c (syms_of_editfns):
1025 * emacs.c (syms_of_emacs):
1026 * eval.c (syms_of_eval):
1027 * fileio.c (syms_of_fileio):
1028 * fns.c (syms_of_fns):
1029 * frame.c (syms_of_frame):
1030 * fringe.c (syms_of_fringe):
1031 * insdel.c (syms_of_insdel):
1032 * keymap.c (syms_of_keymap):
1033 * lread.c (init_obarray, syms_of_lread):
1034 * macros.c (syms_of_macros):
1035 * msdos.c (syms_of_msdos):
1036 * print.c (syms_of_print):
1037 * process.c (syms_of_process):
1038 * search.c (syms_of_search):
1039 * sound.c (syms_of_sound):
1040 * syntax.c (init_syntax_once, syms_of_syntax):
1041 * terminal.c (syms_of_terminal):
1042 * textprop.c (syms_of_textprop):
1043 * undo.c (syms_of_undo):
1044 * w32.c (globals_of_w32):
1045 * window.c (syms_of_window):
1046 * xdisp.c (syms_of_xdisp):
1047 * xfaces.c (syms_of_xfaces):
1048 * xfns.c (syms_of_xfns):
1049 * xmenu.c (syms_of_xmenu):
1050 * xsettings.c (syms_of_xsettings):
1051 * xterm.c (syms_of_xterm): Use DEFSYM.
1052
1053 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1054
1055 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1056
1057 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1058
1059 Integer and buffer overflow fixes (Bug#8873).
1060
1061 * print.c (printchar, strout): Check for string overflow.
1062 (PRINTPREPARE, printchar, strout):
1063 Don't set size unless allocation succeeds.
1064
1065 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1066 for sizes. Check for string overflow more accurately.
1067 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1068
1069 * macros.c: Integer and buffer overflow fixes.
1070 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1071 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1072 Use ptrdiff_t, not int, for sizes.
1073 Don't increment bufsize until after realloc succeeds.
1074 Check for size-calculation overflow.
1075 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1076
1077 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1078
1079 * lread.c: Integer overflow fixes.
1080 (read_integer): Radix is now EMACS_INT, not int,
1081 to improve quality of diagnostics for out-of-range radices.
1082 Calculate buffer size correctly for out-of-range radices.
1083 (read1): Check for integer overflow in radices, and in
1084 read-circle numbers.
1085 (read_escape): Avoid int overflow.
1086 (Fload, openp, read_buffer_size, read1)
1087 (substitute_object_recurse, read_vector, read_list, map_obarray):
1088 Use ptrdiff_t, not int, for sizes.
1089 (read1): Use EMACS_INT, not int, for sizes.
1090 Check for size overflow.
1091
1092 * image.c (cache_image): Check for size arithmetic overflow.
1093
1094 * lread.c: Integer overflow issues.
1095 (saved_doc_string_size, saved_doc_string_length)
1096 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1097 Now ptrdiff_t, not int.
1098 (read1): Don't assume doc string length fits in int. Check for
1099 out-of-range doc string lengths.
1100 (read_list): Don't assume file position fits in int.
1101 (read_escape): Check for hex character overflow.
1102
1103 2011-06-22 Leo Liu <sdl.web@gmail.com>
1104
1105 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1106 Move to minibuffer.el.
1107
1108 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1111 The following patches are for when GLYPH_DEBUG && !XASSERT.
1112 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1113 * dispnew.c (flush_stdout):
1114 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1115 Mark as externally visible.
1116 * dispnew.c (check_window_matrix_pointers): Now static.
1117 * dispnew.c (window_to_frame_vpos):
1118 * xfns.c (unwind_create_frame):
1119 * xterm.c (x_check_font): Remove unused local.
1120 * scroll.c (CHECK_BOUNDS):
1121 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1122 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1123 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1124 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1125 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1126 Now static.
1127 (debug_method_add): Use va_list and vsprintf rather than relying
1128 on undefined behavior with wrong number of arguments.
1129 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1130 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1131 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1132 since we're not interested in debugging glyphs with old libraries.
1133 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1134 GCC 4.6.0's static checking.
1135
1136 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1137
1138 Integer overflow and signedness fixes (Bug#8873).
1139 A few related buffer overrun fixes, too.
1140
1141 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1142
1143 * dispextern.h (struct face.stipple):
1144 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1145 (x_bitmap_mask, x_allocate_bitmap_record)
1146 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1147 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1148 (x_create_bitmap_from_xpm_data):
1149 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1150 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1151 (.bitmaps_last):
1152 * xfaces.c (load_pixmap):
1153 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1154 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1155 (.bitmaps_last, struct x_output.icon_bitmap):
1156 Use ptrdiff_t, not int, for bitmap indexes.
1157 (x_allocate_bitmap_record): Check for size overflow.
1158 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1159
1160 Use ptrdiff_t, not int, for overlay counts.
1161 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1162 * editfns.c (overlays_around, get_pos_property):
1163 * textprop.c (get_char_property_and_overlay):
1164 * xdisp.c (next_overlay_change, note_mouse_highlight):
1165 * xfaces.c (face_at_buffer_position):
1166 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1167 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1168 (Fnext_overlay_change, Fprevious_overlay_change)
1169 (mouse_face_overlay_overlaps, Foverlays_in):
1170 Use ptrdiff_t, not int, for sizes.
1171 (overlays_at, overlays_in): Check for size-calculation overflow.
1172
1173 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1174
1175 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1176 (x_session_initialize): Do not assume string length fits in int.
1177
1178 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1179 This is unlikely, but can occur if DPI is outlandish.
1180
1181 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1182 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1183
1184 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1185 * xrdb.c (magic_file_p, search_magic_path):
1186 Omit last arg SUFFIX; it was always 0. All callers changed.
1187 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1188
1189 * xfont.c (xfont_match): Avoid need for strlen.
1190
1191 * xfns.c: Don't assume strlen fits in int.
1192 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1193
1194 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1195 not unsigned long, as we prefer signed integers. All callers changed.
1196 Detect integer overflow in repeat count.
1197 (message_dolog): Don't assume print length fits in 39 bytes.
1198 (display_mode_element): Don't assume strlen fits in int.
1199
1200 * termcap.c: Don't assume sizes fit in int and never overflow.
1201 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1202 (gobble_line): Check for size-calculation overflow.
1203
1204 * minibuf.c (Fread_buffer):
1205 * lread.c (intern, intern_c_string):
1206 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1207 Don't assume string length fits in int.
1208
1209 * keyboard.c (parse_tool_bar_item):
1210 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1211
1212 * font.c: Don't assume string length fits in int.
1213 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1214 Use ptrdiff_t, not int.
1215 (font_intern_prop): Don't assume string length fits in int.
1216 Don't assume integer property fits in fixnum.
1217 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1218
1219 * filelock.c: Fix some buffer overrun and integer overflow issues.
1220 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1221 Reformulate so as not to need the command string.
1222 Invoke gzip -cd rather than gunzip, as it's more portable.
1223 (lock_info_type, lock_file_1, lock_file):
1224 Don't assume pid_t and time_t fit in unsigned long.
1225 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1226 (current_lock_owner): Prefer signed type for sizes.
1227 Use memcpy, not strncpy, where memcpy is what is really wanted.
1228 Don't assume (via atoi) that time_t and pid_t fit in int.
1229 Check for time_t and/or pid_t out of range, e.g., via a network share.
1230 Don't alloca where an auto var works fine.
1231
1232 * fileio.c: Fix some integer overflow issues.
1233 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1234 Don't assume string length fits in int.
1235 (directory_file_name): Don't assume string length fits in long.
1236 (make_temp_name): Don't assume pid fits in int, or that its print
1237 length is less than 20.
1238
1239 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1240
1241 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1242
1243 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1244
1245 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1246 We prefer signed integers, even for size calculations.
1247
1248 * emacs.c: Don't assume string length fits in 'int'.
1249 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1250 (main): Don't invoke strlen when not needed.
1251
1252 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1253 (XD_DEBUG_MESSAGE): Don't waste a byte.
1254
1255 * callproc.c (getenv_internal_1, getenv_internal)
1256 (Fgetenv_internal):
1257 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1258
1259 * lread.c (invalid_syntax): Omit length argument.
1260 All uses changed. This doesn't fix a bug, but it simplifies the
1261 code away from its former Hollerith-constant appearance, and it's
1262 one less 'int' to worry about when looking at integer-overflow issues.
1263 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1264
1265 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1266 This didn't break anything, but it didn't help either.
1267 It's confusing to put a bogus integer in a place where the actual
1268 value does not matter.
1269 (LIST_END_P): Remove unused macro and its bogus comment.
1270 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1271
1272 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1273 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1274 implementation.
1275 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1276 We prefer signed types, and the value cannot exceed the EMACS_INT
1277 range anyway (because otherwise the length would not be representable).
1278 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1279 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1280 This avoids a GCC warning when WIDE_EMACS_INT.
1281
1282 * indent.c (sane_tab_width): New function.
1283 (current_column, scan_for_column, Findent_to, position_indentation)
1284 (compute_motion): Use it. This is just for clarity.
1285 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1286
1287 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1288
1289 * lisp.h (lint_assume): New macro.
1290 * composite.c (composition_gstring_put_cache):
1291 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1292
1293 * editfns.c, insdel.c:
1294 Omit unnecessary forward decls, to simplify future changes.
1295
1296 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1297
1298 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1299
1300 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1301 Use much-faster test for byte-length change.
1302 Don't assume string byte-length fits in 'int'.
1303 Check that character arg fits in 'int'.
1304 (mapcar1): Declare byte as byte, for clarity.
1305
1306 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1307
1308 * fns.c (concat): Catch string overflow earlier.
1309 Do not rely on integer wraparound.
1310
1311 * dispextern.h (struct it.overlay_strings_charpos)
1312 (struct it.selective): Now EMACS_INT, not int.
1313 * xdisp.c (forward_to_next_line_start)
1314 (back_to_previous_visible_line_start)
1315 (reseat_at_next_visible_line_start, next_element_from_buffer):
1316 Don't arbitrarily truncate the value of 'selective' to int.
1317
1318 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1319
1320 * composite.c: Don't truncate sizes to 'int'.
1321 (composition_gstring_p, composition_reseat_it)
1322 (composition_adjust_point): Use EMACS_INT, not int.
1323 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1324 not EMACS_UINT, for indexes.
1325
1326 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1327
1328 * buffer.c: Include <verify.h>.
1329 (struct sortvec.priority, struct sortstr.priority):
1330 Now EMACS_INT, not int.
1331 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1332 (struct sortstr.size, record_overlay_string)
1333 (struct sortstrlist.size, struct sortlist.used):
1334 Don't truncate size to int.
1335 (record_overlay_string): Check for size-calculation overflow.
1336 (init_buffer_once): Check at compile-time, not run-time.
1337
1338 2011-06-22 Jim Meyering <meyering@redhat.com>
1339
1340 Don't leak an XBM-image-sized buffer
1341 * image.c (xbm_load): Free the image buffer after using it.
1342
1343 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1344
1345 Port to Sun C.
1346 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1347 that Sun C diagnosed.
1348 * fns.c (secure_hash): Fix pointer signedness issue.
1349 * intervals.c (static_offset_intervals): New function.
1350 (offset_intervals): Use it.
1351
1352 2011-06-21 Leo Liu <sdl.web@gmail.com>
1353
1354 * deps.mk (fns.o):
1355 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1356 sha512.h.
1357
1358 * fns.c (secure_hash): Rename from crypto_hash_function and change
1359 the first arg to accept symbols.
1360 (Fsecure_hash): New primitive.
1361 (syms_of_fns): New symbols.
1362
1363 2011-06-20 Deniz Dogan <deniz@dogan.se>
1364
1365 * process.c (Fset_process_buffer): Clarify return value in
1366 docstring.
1367
1368 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1369
1370 * dispnew.c (add_window_display_history): Use BVAR.
1371
1372 * xdisp.c (debug_method_add): Use BVAR.
1373 (check_window_end, dump_glyph_matrix, dump_glyph)
1374 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1375
1376 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1377 Likewise.
1378
1379 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1380 check till after the cache is created in init_frame_faces.
1381
1382 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1383
1384 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1385
1386 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1389 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1390 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1391
1392 Improve buffer-overflow checking (Bug#8873).
1393 * fileio.c (Finsert_file_contents):
1394 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1395 Remove the old (too-loose) buffer overflow checks.
1396 They weren't needed, since make_gap checks for buffer overflow.
1397 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1398 The old code merely checked for Emacs fixnum overflow, and relied
1399 on undefined (wraparound) behavior. The new code avoids undefined
1400 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1401
1402 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1403 Tune. Don't use wider integers than needed. Don't use alloca.
1404 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1405
1406 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1407
1408 * insdel.c, lisp.h (buffer_overflow): New function.
1409 (insert_from_buffer_1, replace_range, replace_range_2):
1410 * insdel.c (make_gap_larger):
1411 * editfns.c (Finsert_char):
1412 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1413
1414 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1415
1416 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1417
1418 Integer overflow and signedness fixes (Bug#8873).
1419
1420 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1421 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1422
1423 * fileio.c: Don't assume EMACS_INT fits in off_t.
1424 (emacs_lseek): New static function.
1425 (Finsert_file_contents, Fwrite_region): Use it.
1426 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1427
1428 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1429
1430 * fns.c: Don't overflow int when computing a list length.
1431 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1432 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1433 truncation on 64-bit hosts. Check for QUIT every
1434 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1435 faster and is responsive enough.
1436 (Flength): Report an error instead of overflowing an integer.
1437 (Fsafe_length): Return a float if the value is not representable
1438 as a fixnum. This shouldn't happen except in contrived situations.
1439 (Fnthcdr, Fsort): Don't assume list length fits in int.
1440 (Fcopy_sequence): Don't assume vector length fits in int.
1441
1442 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1443 (header_size, word_size): New constants.
1444 (allocate_vectorlike): Don't check size overflow here.
1445 (allocate_vector): Check it here instead, since this is the only
1446 caller of allocate_vectorlike that could cause overflow.
1447 Check that the new vector's length is representable as a fixnum.
1448
1449 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1450 The previous code was bogus. For example, next_almost_prime (32)
1451 returned 39, which is undesirable as it is a multiple of 3; and
1452 next_almost_prime (24) returned 25, which is a multiple of 5 so
1453 why was the code bothering to check for multiples of 7?
1454
1455 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1456
1457 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1458
1459 Variadic C functions now count arguments with ptrdiff_t.
1460 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1461 Back then I didn't know that the Emacs coding style prefers signed int.
1462 Also, in the meantime I found a few more instances where arguments
1463 were being counted with int, which may truncate counts on 64-bit
1464 machines, or EMACS_INT, which may be unnecessarily wide.
1465 * lisp.h (struct Lisp_Subr.function.aMANY)
1466 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1467 Arg counts are now ptrdiff_t, not size_t.
1468 All variadic functions and their callers changed accordingly.
1469 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1470 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1471 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1472 * callint.c (Fcall_interactively): Check arg count for overflow,
1473 to avoid potential buffer overrun. Use signed char, not 'int',
1474 for 'varies' array, so that we needn't bother to check its size
1475 calculation for overflow.
1476 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1477 * eval.c (apply_lambda):
1478 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1479 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1480 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1481
1482 * callint.c (Fcall_interactively): Don't use index var as event count.
1483
1484 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1485 * mem-limits.h (SIZE): Remove; no longer used.
1486
1487 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1488
1489 Remove unnecessary casts.
1490 * xterm.c (x_term_init):
1491 * xfns.c (x_set_border_pixel):
1492 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1493 These aren't needed now that we assume ANSI C.
1494
1495 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1496 It's more likely to cause problems (due to unsigned overflow)
1497 than to cure them.
1498
1499 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1500
1501 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1502
1503 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1504
1505 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1506
1507 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1508
1509 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1510
1511 GLYPH_CODE_FACE returns EMACS_INT, not int.
1512 * dispextern.h (merge_faces):
1513 * xfaces.c (merge_faces):
1514 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1515 Don't assume EMACS_INT fits in int.
1516
1517 * character.h (CHAR_VALID_P): Remove unused parameter.
1518 * fontset.c, lisp.h, xdisp.c: All uses changed.
1519
1520 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1521
1522 * fns.c (concat): Minor tuning based on overflow analysis.
1523 This doesn't fix any bugs. Use int to hold character, instead
1524 of constantly refetching from Emacs object. Use XFASTINT, not
1525 XINT, for value known to be a character. Don't bother comparing
1526 a single byte to 0400, as it's always less.
1527
1528 * floatfns.c (Fexpt):
1529 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1530
1531 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1532 for characters.
1533
1534 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1535
1536 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1537 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1538 incorrectly succeed when S was a string, because 4294967386 was
1539 truncated before it was used.
1540
1541 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1542 Otherwise, an out-of-range integer could cause undefined behavior
1543 on a 64-bit host.
1544
1545 * composite.c: Use int, not EMACS_INT, for characters.
1546 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1547 EMACS_INT, for values that are known to be in character range.
1548 This doesn't fix any bugs but is the usual style inside Emacs and
1549 may generate better code on 32-bit machines.
1550
1551 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1552 This is for reasons similar to the recent CHAR_STRING fix.
1553 * charset.c (Fencode_char): Check that character arg is actually
1554 a character. Pass an int to ENCODE_CHAR.
1555 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1556 wider than 'int', as a compile-time check to prevent future regressions
1557 in this area.
1558
1559 * character.c (char_string): Remove unnecessary casts.
1560
1561 Make sure a 64-bit char is never passed to CHAR_STRING.
1562 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1563 by silently ignoring the top 32 bits, allowing some values
1564 that were far too large to be valid characters.
1565 * character.h: Include <verify.h>.
1566 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1567 arguments are no wider than unsigned, as a compile-time check
1568 to prevent future regressions in this area.
1569 * data.c (Faset):
1570 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1571 (Fsubst_char_in_region):
1572 * fns.c (concat):
1573 * xdisp.c (decode_mode_spec_coding):
1574 Adjust to CHAR_STRING's new requirement.
1575 * editfns.c (Finsert_char, Fsubst_char_in_region):
1576 * fns.c (concat): Check that character args are actually
1577 characters. Without this test, these functions did the wrong
1578 thing with wildly out-of-range values on 64-bit hosts.
1579
1580 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1581 These casts should not be needed on 32-bit hosts, either.
1582 * keyboard.c (read_char):
1583 * lread.c (Fload): Remove casts to unsigned.
1584
1585 * lisp.h (UNSIGNED_CMP): New macro.
1586 This fixes comparison bugs on 64-bit hosts.
1587 (ASCII_CHAR_P): Use it.
1588 * casefiddle.c (casify_object):
1589 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1590 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1591 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1592 * dispextern.h (FACE_FROM_ID):
1593 * keyboard.c (read_char): Use UNSIGNED_CMP.
1594
1595 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1596 not to EMACS_INT, to avoid GCC warning.
1597
1598 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1599
1600 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1601 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1602 isn't needed on 32-bit machines.
1603
1604 * buffer.c (Fgenerate_new_buffer_name):
1605 Use EMACS_INT for count, not int.
1606 (advance_to_char_boundary): Return EMACS_INT, not int.
1607
1608 * data.c (Qcompiled_function): Now static.
1609
1610 * window.c (window_body_lines): Now static.
1611
1612 * image.c (gif_load): Rename local to avoid shadowing.
1613
1614 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1615 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1616 * alloc.c (make_save_value): Integer argument is now of type
1617 ptrdiff_t, not int.
1618 (mark_object): Use ptrdiff_t, not int.
1619 * lisp.h (pD): New macro.
1620 * print.c (print_object): Use it.
1621
1622 * alloc.c: Use EMACS_INT, not int, to count objects.
1623 (total_conses, total_markers, total_symbols, total_vector_size)
1624 (total_free_conses, total_free_markers, total_free_symbols)
1625 (total_free_floats, total_floats, total_free_intervals)
1626 (total_intervals, total_strings, total_free_strings):
1627 Now EMACS_INT, not int. All uses changed.
1628 (Fgarbage_collect): Compute overall total using a double, so that
1629 integer overflow is less likely to be a problem. Check for overflow
1630 when converting back to an integer.
1631 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1632 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1633 These were 'int' variables that could overflow on 64-bit hosts;
1634 they were never used, so remove them instead of repairing them.
1635 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1636 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1637 Previously, this ceilinged at INT_MAX, but that doesn't work on
1638 64-bit machines.
1639 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1640
1641 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1642 (allocate_vectorlike): Check for ptrdiff_t overflow.
1643 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1644 when a (possibly-narrower) signed value would do just as well.
1645 We prefer using signed arithmetic, to avoid comparison confusion.
1646
1647 * alloc.c: Catch some string size overflows that we were missing.
1648 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1649 for convenience in STRING_BYTES_MAX.
1650 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1651 The definition here is exact; the one in lisp.h was approximate.
1652 (allocate_string_data): Check for string overflow. This catches
1653 some instances we weren't catching before. Also, it catches
1654 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1655 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1656 and ptrdiff_t and EMACS_INT are both 64 bits.
1657
1658 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1659 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1660 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1661
1662 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1663
1664 * alloc.c (Fmake_string): Check for out-of-range init.
1665
1666 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1667
1668 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1669
1670 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1671
1672 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1673 xg_get_default_scrollbar_width.
1674
1675 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1676 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1677 (style_changed_cb): Call update_theme_scrollbar_width and call
1678 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1679 all frames (Bug#8505).
1680 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1681 Call gtk_window_set_resizable if HAVE_GTK3.
1682 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1683 and height if HAVE_GTK3 (Bug#8505).
1684 (scroll_bar_width_for_theme): New variable.
1685 (update_theme_scrollbar_width): New function.
1686 (xg_get_default_scrollbar_width): Move code to
1687 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1688 (xg_initialize): Call update_theme_scrollbar_width.
1689
1690 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1691
1692 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1693
1694 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1695
1696 * frame.c (make_frame): Call other_buffer_safely instead of
1697 other_buffer.
1698
1699 * window.c (temp_output_buffer_show): Call display_buffer with
1700 second argument Vtemp_buffer_show_specifiers and reset latter
1701 immediately after the call.
1702 (Vtemp_buffer_show_specifiers): New variable.
1703 (auto_window_vscroll_p, next_screen_context_lines)
1704 (Vscroll_preserve_screen_position): Remove leading asterisks from
1705 doc-strings.
1706
1707 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1708
1709 Fix minor problems found by GCC 4.6.0 static checking.
1710 * buffer.c (Qclone_number): Remove for now, as it's unused.
1711 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1712 (record_buffer): Remove unused local.
1713 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1714 (set_frame_buffer_list): Remove; unused.
1715 * frame.h (other_visible_frames): Remove decl.
1716 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1717 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1718 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1719 if HAVE_GPM.
1720 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1721 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1722 Define only if HAVE_GPM.
1723 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1724 (update_hints_inhibit): Remove; never set. All uses removed.
1725 * widgetprv.h (emacsFrameClassRec): Remove decl.
1726 * window.c (delete_deletable_window): Now returns void, since it
1727 wasn't returning anything.
1728 (compare_window_configurations): Remove unused locals.
1729 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1730 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1731 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1732 the same widths as pointers. This follows up on the 2011-05-06 patch.
1733 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1734 * xterm.h: Likewise.
1735 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1736
1737 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1738
1739 * makefile.w32-in: Update dependencies.
1740 (LISP_H): Add lib/intprops.h.
1741
1742 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1743
1744 * image.c (gif_load): Add animation frame delay to the metadata.
1745 (syms_of_image): Use DEFSYM. New symbol `delay'.
1746
1747 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1748
1749 * window.c (delete_deletable_window): Re-add.
1750 (Fset_window_configuration): Rewrite to handle dead buffers and
1751 consequently deletable windows.
1752 (window_tree, Fwindow_tree): Remove. Supply functionality in
1753 window.el.
1754 (compare_window_configurations): Simplify code.
1755
1756 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1757
1758 * image.c (imagemagick_load_image): Fix type mismatch.
1759 (Fimagemagick_types): Likewise.
1760
1761 * window.h (replace_buffer_in_windows): Declare.
1762
1763 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1764
1765 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1766 Qclone_number. Remove external declaration of Qdelete_window.
1767 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1768 code.
1769 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1770 Qbuffer_list_update_hook if allowed.
1771 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1772 buffer list implementation.
1773 (other_buffer_safely): New function.
1774 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1775 calls to replace_buffer_in_windows and
1776 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1777 if allowed.
1778 (record_buffer): Inhibit quitting and rewrite using quittable
1779 functions. Run Qbuffer_list_update_hook if allowed.
1780 (Frecord_buffer, Funrecord_buffer): New functions.
1781 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1782 switch-to-buffer to window.el.
1783 (bury-buffer): Move to window.el.
1784 (Vbuffer_list_update_hook): New variable.
1785
1786 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1787 section.
1788
1789 * window.h (resize_frame_windows): Move up in code.
1790 (Fwindow_frame): Remove EXFUN.
1791 (replace_buffer_in_all_windows): Remove prototype.
1792 (replace_buffer_in_windows_safely): Add prototype.
1793
1794 * window.c: Declare Qdelete_window static again. Move down
1795 declaration of select_count.
1796 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1797 (Fother_window): Move to window.el.
1798 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1799 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1800 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1801 window.el.
1802 (replace_buffer_in_windows): Implement by calling
1803 Qreplace_buffer_in_windows.
1804 (replace_buffer_in_all_windows): Remove with some functionality
1805 moved into replace_buffer_in_windows_safely.
1806 (replace_buffer_in_windows_safely): New function.
1807 (select_window_norecord, select_frame_norecord): Move in front
1808 of run_window_configuration_change_hook. Remove now obsolete
1809 declarations.
1810 (Fset_window_buffer): Rewrite doc-string. Call
1811 Qrecord_window_buffer.
1812 (keys_of_window): Move binding for other-window to window.el.
1813
1814 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1815
1816 * dispextern.h (struct image): Replace data member, whose int_val
1817 and ptr_val fields were not used by anything, with a single
1818 lisp_val object.
1819
1820 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1821 (gif_clear_image, gif_load, imagemagick_load_image)
1822 (gs_clear_image, gs_load): Callers changed.
1823
1824 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 * buffer.h: Include <time.h>, for time_t.
1827 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1828
1829 Fix minor problems found by static checking.
1830
1831 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1832
1833 Make identifiers static if they are not used in other modules.
1834 * data.c (Qcompiled_function, Qframe, Qvector):
1835 * image.c (QimageMagick, Qsvg):
1836 * minibuf.c (Qmetadata):
1837 * window.c (resize_window_check, resize_root_window): Now static.
1838 * window.h (resize_window_check, resize_root_window): Remove decls.
1839
1840 * window.c (window_deletion_count, delete_deletable_window):
1841 Remove; unused.
1842 (window_body_lines): Now static.
1843 (Fdelete_other_windows_internal): Mark vars as initialized.
1844 Make sure 'resize_failed' is initialized.
1845 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1846 (resize_window_apply): Remove unused local.
1847 * window.h (delete_deletable_window): Remove decl.
1848
1849 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1850 (imagemagick_load_image): Fix pointer signedness problem by changing
1851 last arg from unsigned char * to char *. All uses changed.
1852 Also, fix a local for similar reasons.
1853 Remove unused locals. Remove locals to avoid shadowing.
1854 (fn_rsvg_handle_free): Remove; unused.
1855 (svg_load, svg_load_image): Fix pointer signedness problem.
1856 (imagemagick_load_image): Don't use garbage pointer image_wand.
1857
1858 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1859
1860 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1861
1862 * image.c (gif_load): Fix omitted cast error introduced by
1863 2011-06-06 change.
1864
1865 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1866
1867 * window.h (resize_proportionally, orig_total_lines)
1868 (orig_top_line): Remove from window structure.
1869 (set_window_height, set_window_width, change_window_heights)
1870 (Fdelete_window): Remove prototypes.
1871 (resize_frame_windows): Remove duplicate declaration.
1872
1873 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1874
1875 * window.h (resize_frame_windows, resize_window_check)
1876 (delete_deletable_window, resize_root_window)
1877 (resize_frame_windows): Declare prototypes.
1878
1879 * window.c (resize_window_apply): Make definition be "static" to
1880 match the prototype.
1881
1882 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1883
1884 * window.c: Remove declarations of Qwindow_size_fixed,
1885 window_min_size_1, window_min_size_2, window_min_size,
1886 size_window, window_fixed_size_p, enlarge_window, delete_window.
1887 Remove static from declaration of Qdelete_window, it's
1888 temporarily needed by Fbury_buffer.
1889 (replace_window): Don't assign orig_top_line and
1890 orig_total_lines.
1891 (Fdelete_window, delete_window): Remove. Window deletion is
1892 handled by window.el.
1893 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1894 Fdelete_window calls with calls to Qdelete_window.
1895 (Fdelete_other_windows): Remove. Deleting other windows is
1896 handled by window.el.
1897 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1898 handled in window.el.
1899 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1900 Window minimum sizes are handled in window.el.
1901 (shrink_windows, size_window, set_window_height)
1902 (set_window_width, change_window_heights, window_height)
1903 (window_width, CURBEG, CURSIZE, enlarge_window)
1904 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1905 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1906 handled in window.el.
1907 (make_dummy_parent): Rename to make_parent_window and give it a
1908 second argument horflag.
1909 (make_window): Don't set resize_proportionally any more.
1910 (Fsplit_window): Remove. Windows are split in window.el.
1911 (save_restore_action, save_restore_orig_size)
1912 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1913 Resize mini windows in window.el.
1914 (grow_mini_window, shrink_mini_window): Implement by calling
1915 Qresize_root_window_vertically, resize_window_check and
1916 resize_window_apply.
1917 (saved_window, Fset_window_configuration, save_window_save): Do
1918 not handle orig_top_line, orig_total_lines, and
1919 resize_proportionally.
1920 (window_min_height, window_min_width): Move to window.el.
1921 (keys_of_window): Move bindings for delete-other-windows,
1922 split-window, delete-window and enlarge-window to window.el.
1923
1924 * buffer.c: Temporarily extern Qdelete_window.
1925 (Fbury_buffer): Temporarily call Qdelete_window instead of
1926 Fdelete_window (Fbury_buffer will move to window.el soon).
1927
1928 * frame.c (set_menu_bar_lines_1): Remove code handling
1929 orig_top_line and orig_total_lines.
1930
1931 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1932 set_window_height but set heights directly.
1933 (change_frame_size_1): Use resize_frame_windows.
1934
1935 * xdisp.c (init_xdisp): Don't use set_window_height but set
1936 heights directly.
1937
1938 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1939 resize_frame_windows instead of change_window_heights and run
1940 run_window_configuration_change_hook.
1941
1942 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1943 instead of change_window_heights and run
1944 run_window_configuration_change_hook.
1945
1946 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1947
1948 * window.c (replace_window): Rename second argument REPLACEMENT to
1949 NEW. New third argument SETFLAG. Rewrite.
1950 (delete_window, make_dummy_parent): Call replace_window with
1951 third argument 1.
1952 (window_list_1): Move down in code.
1953 (run_window_configuration_change_hook): Move set_buffer part
1954 before select_frame_norecord part in order to unwind correctly.
1955 Rename count1 to count.
1956 (recombine_windows, delete_deletable_window, resize_root_window)
1957 (Fdelete_other_windows_internal)
1958 (Frun_window_configuration_change_hook, make_parent_window)
1959 (resize_window_check, resize_window_apply, Fresize_window_apply)
1960 (resize_frame_windows, Fsplit_window_internal)
1961 (Fdelete_window_internal, Fresize_mini_window_internal): New
1962 functions.
1963 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1964
1965 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1966
1967 * window.h (window): Add some new members to window structure -
1968 normal_lines, normal_cols, new_total, new_normal, clone_number,
1969 splits, nest, prev_buffers, next_buffers.
1970 (WINDOW_TOTAL_SIZE): Move here from window.c.
1971 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1972
1973 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1974 Remove.
1975 (make_dummy_parent): Set new members of windows structure.
1976 (make_window): Move down in code. Handle new members of window
1977 structure.
1978 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1979 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1980 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1981 (Fset_window_prev_buffers, Fwindow_next_buffers)
1982 (Fset_window_next_buffers, Fset_window_clone_number): New
1983 functions.
1984 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1985 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1986 Doc-string fixes.
1987 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1988 Argument WINDOW can be now internal window too.
1989 (Fwindow_use_time): Move up in code.
1990 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1991 Rewrite doc-string.
1992 (Fset_window_configuration, saved_window)
1993 (Fcurrent_window_configuration, save_window_save): Handle new
1994 members of window structure.
1995 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1996 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1997 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1998 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1999 Qget_mru_window, Qresize_root_window,
2000 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2001 Qauto_buffer_name; staticpro them.
2002
2003 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2004
2005 * window.c (Fwindow_total_size, Fwindow_left_column)
2006 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2007 (Fwindow_list_1): New functions.
2008 (window_box_text_cols): Replace with window_body_cols.
2009 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2010 window_body_cols instead of window_box_text_cols.
2011 (delete_window, Fset_window_configuration): Call
2012 delete_all_subwindows with window as argument.
2013 (delete_all_subwindows): Take a window as argument and not a
2014 structure. Rewrite.
2015 (window_loop): Remove handling of GET_LRU_WINDOW and
2016 GET_LARGEST_WINDOW.
2017 (Fget_lru_window, Fget_largest_window): Move to window.el.
2018
2019 * window.h: Extern window_body_cols instead of
2020 window_box_text_cols. delete_all_subwindows now takes a
2021 Lisp_Object as argument.
2022
2023 * indent.c (compute_motion, Fcompute_motion): Use
2024 window_body_cols instead of window_box_text_cols.
2025
2026 * frame.c (delete_frame): Call delete_all_subwindows with root
2027 window as argument.
2028
2029 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2030
2031 * fns.c (Fputhash): Document return value.
2032
2033 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2034
2035 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2036
2037 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2038
2039 Cons<->int and similar integer overflow fixes (Bug#8794).
2040
2041 Check for overflow when converting integer to cons and back.
2042 * charset.c (Fdefine_charset_internal, Fdecode_char):
2043 Use cons_to_unsigned to catch overflow.
2044 (Fencode_char): Use INTEGER_TO_CONS.
2045 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2046 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2047 * data.c (long_to_cons, cons_to_long): Remove.
2048 (cons_to_unsigned, cons_to_signed): New functions.
2049 These signal an error for invalid or out-of-range values.
2050 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2051 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2052 * font.c (Ffont_variation_glyphs):
2053 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2054 * lisp.h: Include <intprops.h>.
2055 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2056 (cons_to_signed, cons_to_unsigned): New decls.
2057 (long_to_cons, cons_to_long): Remove decls.
2058 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2059 (Fprimitive_undo): Use CONS_TO_INTEGER.
2060 * xfns.c (Fx_window_property): Likewise.
2061 * xselect.c: Include <limits.h>.
2062 (x_own_selection, selection_data_to_lisp_data):
2063 Use INTEGER_TO_CONS.
2064 (x_handle_selection_request, x_handle_selection_clear)
2065 (x_get_foreign_selection, Fx_disown_selection_internal)
2066 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2067 (lisp_data_to_selection_data): Use cons_to_unsigned.
2068 (x_fill_property_data): Use cons_to_signed.
2069 Report values out of range.
2070
2071 Check for buffer and string overflow more precisely.
2072 * buffer.h (BUF_BYTES_MAX): New macro.
2073 * lisp.h (STRING_BYTES_MAX): New macro.
2074 * alloc.c (Fmake_string):
2075 * character.c (string_escape_byte8):
2076 * coding.c (coding_alloc_by_realloc):
2077 * doprnt.c (doprnt):
2078 * editfns.c (Fformat):
2079 * eval.c (verror):
2080 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2081 since they may not be the same number.
2082 * editfns.c (Finsert_char):
2083 * fileio.c (Finsert_file_contents):
2084 Likewise for BUF_BYTES_MAX.
2085
2086 * image.c: Use ptrdiff_t, not int, for sizes.
2087 (slurp_file): Switch from int to ptrdiff_t.
2088 All uses changed.
2089 (slurp_file): Check that file size fits in both size_t (for
2090 malloc) and ptrdiff_t (for sanity and safety).
2091
2092 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2093 if b->modtime has its maximal value.
2094
2095 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2096
2097 Don't assume time_t can fit into int.
2098 * buffer.h (struct buffer.modtime): Now time_t, not int.
2099 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2100 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2101
2102 Minor fixes for signed vs unsigned integers.
2103 * character.h (MAYBE_UNIFY_CHAR):
2104 * charset.c (maybe_unify_char):
2105 * keyboard.c (read_char, reorder_modifiers):
2106 XINT -> XFASTINT, since the integer must be nonnegative.
2107 * ftfont.c (ftfont_spec_pattern):
2108 * keymap.c (access_keymap, silly_event_symbol_error):
2109 XUINT -> XFASTINT, since the integer must be nonnegative.
2110 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2111 since it makes no difference and we prefer signed.
2112 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2113 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2114 nonnegative.
2115
2116 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2117
2118 * window.h (Fwindow_frame): Declare.
2119
2120 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2121
2122 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2123 (SPARE_MEMORY): Always define.
2124 (LARGE_REQUEST): Remove.
2125 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2126
2127 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2128
2129 * lisp.h: Move EXFUNS for Fframe_root_window,
2130 Fframe_first_window and Fset_frame_selected_window to window.h.
2131
2132 * window.h: Move EXFUNS for Fframe_root_window,
2133 Fframe_first_window and Fset_frame_selected_window here from
2134 lisp.h.
2135
2136 * frame.c (Fwindow_frame, Fframe_first_window)
2137 (Fframe_root_window, Fframe_selected_window)
2138 (Fset_frame_selected_window): Move to window.c.
2139 (Factive_minibuffer_window): Move to minibuf.c.
2140 (Fother_visible_frames_p): New function.
2141
2142 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2143
2144 * window.c (decode_window, decode_any_window): Move up in code.
2145 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2146 (inhibit_frame_unsplittable): Remove unused variable.
2147 (Fwindow_buffer): Move up and rewrite doc-string.
2148 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2149 (Fwindow_prev): New functions.
2150 (Fwindow_frame): Move here from frame.c. Accept any window as
2151 argument.
2152 (Fframe_root_window, Fframe_first_window)
2153 (Fframe_selected_window): Move here from frame.c. Accept frame
2154 or arbitrary window as argument. Update doc-strings.
2155 (Fminibuffer_window): Move up in code.
2156 (Fwindow_minibuffer_p): Move up in code and simplify.
2157 (Fset_frame_selected_window): Move here from frame.c.
2158 Marginal rewrite.
2159 (Fselected_window, select_window, Fselect_window): Move up in
2160 code. Minor doc-string fixes.
2161
2162 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2163
2164 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2165 Do not assume that spare memory exists; that assumption is valid
2166 only if SYSTEM_MALLOC.
2167 (LARGE_REQUEST): New macro, so that the issue of large requests
2168 is separated from the issue of spare memory.
2169
2170 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2171
2172 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2173 format. (Bug#8806)
2174
2175 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2176
2177 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2178 before statements.
2179
2180 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2181
2182 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2183
2184 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2185
2186 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2187 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2188
2189 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2190
2191 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2192
2193 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2194
2195 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2196 (x_clipboard_manager_save): Add return value.
2197 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2198 New error handlers.
2199 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2200 Obey Vx_select_enable_clipboard_manager. Catch errors in
2201 x_clipboard_manager_save (Bug#8779).
2202 (Vx_select_enable_clipboard_manager): New variable.
2203 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2204
2205 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2206
2207 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2208
2209 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2210
2211 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2212 in the current matrix if keep_current_p is non-zero.
2213
2214 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2215
2216 * bidi.c (bidi_level_of_next_char): Fix last change.
2217
2218 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2219
2220 Support bidi reordering of text covered by display properties.
2221
2222 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2223 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2224 (bidi_cache_search, bidi_cache_iterator_state)
2225 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2226 (bidi_level_of_next_char, bidi_move_to_visually_next):
2227 Support character positions inside a run of characters covered by a
2228 display string.
2229 (bidi_paragraph_init, bidi_resolve_explicit_1)
2230 (bidi_level_of_next_char): Call bidi_fetch_char and
2231 bidi_fetch_char_advance instead of FETCH_CHAR and
2232 FETCH_CHAR_ADVANCE.
2233 (bidi_init_it): Initialize new members.
2234 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2235 definitions.
2236 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2237 instead of using explicit *_CHAR codes.
2238 (bidi_resolve_explicit, bidi_resolve_weak):
2239 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2240 bidirectional text is supported only in multibyte buffers.
2241 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2242 it to initialize the frame_window_p member of struct bidi_it.
2243 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2244 (bidi_resolve_explicit, bidi_resolve_weak)
2245 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2246 bidi_it->nchars is non-positive.
2247 (bidi_level_of_next_char): Don't try to lookup the cache for the
2248 next/previous character if nothing is cached there yet, or if we
2249 were just reseat()'ed to a new position.
2250
2251 * xdisp.c (set_cursor_from_row): Set start and stop points
2252 according to the row's direction when priming the loop that looks
2253 for the glyph on which to display cursor.
2254 (single_display_spec_intangible_p): Function deleted.
2255 (display_prop_intangible_p): Reimplement to call
2256 handle_display_spec instead of single_display_spec_intangible_p.
2257 Accept 3 additional arguments needed by handle_display_spec.
2258 This fixes incorrect cursor motion across display property with complex
2259 values: lists, `(when COND...)' forms, etc.
2260 (single_display_spec_string_p): Support property values that are
2261 lists with the argument STRING its top-level element.
2262 (display_prop_string_p): Fix the condition for processing a
2263 property that is a list to be consistent with handle_display_spec.
2264 (handle_display_spec): New function, refactored from the
2265 last portion of handle_display_prop.
2266 (compute_display_string_pos): Accept additional argument
2267 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2268 value of a `display' property is a "replacing spec".
2269 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2270 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2271 the display property, but just return a value indicating whether
2272 the display property will replace the characters it covers.
2273 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2274 frame_window_p members of struct bidi_it.
2275 (compute_display_string_pos, compute_display_string_end):
2276 New functions.
2277 (push_it): Accept second argument POSITION, where pop_it should
2278 jump to continue iteration.
2279 (reseat_1): Initialize bidi_it.disp_pos.
2280
2281 * keyboard.c (adjust_point_for_property): Adjust the call to
2282 display_prop_intangible_p to its new signature.
2283
2284 * dispextern.h (struct bidi_it): New member frame_window_p.
2285 (bidi_init_it): Update prototypes.
2286 (display_prop_intangible_p): Update prototype.
2287 (compute_display_string_pos, compute_display_string_end):
2288 Declare prototypes.
2289 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2290 EMACS_INT.
2291
2292 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2293
2294 Malloc failure behavior now depends on size of allocation.
2295 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2296 * lisp.h: Change signatures accordingly.
2297 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2298 All callers changed. (Bug#8762)
2299
2300 * gnutls.c: Use Emacs's memory allocators.
2301 Without this change, the gnutls library would invoke malloc etc.
2302 directly, which causes problems on non-SYNC_INPUT hosts, and which
2303 runs afoul of improving memory_full behavior. (Bug#8761)
2304 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2305 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2306 xfree instead of the default malloc, realloc, free.
2307 (Fgnutls_boot): No need to check for memory allocation failure,
2308 since xmalloc does that for us.
2309
2310 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2311 * category.c (hash_get_category_set):
2312 * ccl.c (ccl_driver):
2313 * charset.c (Fdefine_charset_internal):
2314 * charset.h (struct charset.hash_index):
2315 * composite.c (get_composition_id, gstring_lookup_cache)
2316 (composition_gstring_put_cache):
2317 * composite.h (struct composition.hash_index):
2318 * dispextern.h (struct image.hash):
2319 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2320 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2321 (hashfn_equal, hashfn_user_defined, make_hash_table)
2322 (maybe_resize_hash_table, hash_lookup, hash_put)
2323 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2324 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2325 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2326 * image.c (make_image, search_image_cache, lookup_image)
2327 (xpm_put_color_table_h):
2328 * lisp.h (struct Lisp_Hash_Table):
2329 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2330 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2331 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2332 * alloc.c (allocate_vectorlike):
2333 Check for overflow in vector size calculations.
2334 * ccl.c (ccl_driver):
2335 Check for overflow when converting EMACS_INT to int.
2336 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2337 need to be updated by these changes.
2338 * fns.c (make_hash_table, maybe_resize_hash_table):
2339 Check for integer overflow with large hash tables.
2340 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2341 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2342 (SXHASH_REDUCE): New macro.
2343 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2344 Use it instead of discarding useful hash info with large hash values.
2345 (sxhash_float): New function.
2346 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2347 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2348 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2349 Rewrite to use FIXNUM_BITS, as this simplifies things.
2350 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2351 Adjust signatures to match updated version of code.
2352 (consing_since_gc): Now EMACS_INT, since a single hash table can
2353 use more than INT_MAX bytes.
2354
2355 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2356
2357 Make it possible to build with GCC-4.6+ -O2 -flto.
2358
2359 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2360
2361 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2362
2363 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2364 Call minibuffer-inactive-mode.
2365
2366 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2367
2368 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2369 Update dependencies.
2370
2371 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2372
2373 * data.c (init_data): Remove code for UTS, this system is not
2374 supported anymore.
2375
2376 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2377
2378 Don't force ./temacs to start in terminal mode.
2379
2380 * frame.c (make_initial_frame): Initialize faces in all cases, not
2381 only when CANNOT_DUMP is defined.
2382 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2383
2384 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2385
2386 * dispnew.c (add_window_display_history): Use const for the string
2387 pointer. Remove declaration, not needed.
2388
2389 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2390
2391 Use 'inline', not 'INLINE'.
2392 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2393 * alloc.c, fontset.c (INLINE): Remove.
2394 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2395 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2396 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2397 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2398 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2399
2400 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2401
2402 Make it possible to run ./temacs.
2403
2404 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2405 syms_of_callproc does the same thing. Remove test for
2406 "initialized", do it in the caller.
2407 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2408
2409 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2410
2411 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2412 (read_minibuf): Use get_minibuffer.
2413 (syms_of_minibuf): Use DEFSYM.
2414 (Qmetadata): New var.
2415 * data.c (Qbuffer): Don't make it static.
2416 (syms_of_data): Use DEFSYM.
2417
2418 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2419
2420 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2421 (CCL_CODE_MIN): New macro.
2422
2423 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2424
2425 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2426
2427 * eval.c (Qdebug): Now static.
2428 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2429 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2430 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2431
2432 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2433
2434 * image.c: Various fixes to ImageMagick code comments.
2435 (Fimagemagick_types): Doc fix.
2436
2437 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 Minor fixes prompted by GCC 4.6.0 warnings.
2440
2441 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2442
2443 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2444 (x_clipboard_manager_save_all): Move extern decl to ...
2445 * xterm.h: ... here, so that it can be checked for consistency.
2446
2447 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2448
2449 * xselect.c (x_clipboard_manager_save_frame)
2450 (x_clipboard_manager_save_all): New functions.
2451 (Fx_clipboard_manager_save): Lisp function deleted.
2452
2453 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2454 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2455
2456 * xterm.h: Update prototype.
2457
2458 2011-05-28 William Xu <william.xwl@gmail.com>
2459
2460 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2461 exiting (Bug#8239).
2462
2463 2011-05-28 Jim Meyering <meyering@redhat.com>
2464
2465 Avoid a sign-extension bug in crypto_hash_function.
2466 * fns.c (to_uchar): Define.
2467 (crypto_hash_function): Use it to convert some newly-signed
2468 variables to unsigned, to avoid sign-extension bugs. For example,
2469 without this change, (md5 "truc") would evaluate to
2470 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2471 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2472 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2473
2474 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2475
2476 Integer overflow fixes.
2477
2478 * dbusbind.c: Serial number integer overflow fixes.
2479 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2480 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2481 to hold a serial number that is too large for a fixnum.
2482 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2483 Check for serial numbers out of range. Decode any serial number
2484 that was so large that it became a float. (Bug#8722)
2485
2486 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2487 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2488 Use XFASTINT rather than XUINT when numbers are nonnegative.
2489 (xd_append_arg, Fdbus_method_return_internal):
2490 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2491 arguments, check that Lisp number is nonnegative, rather than
2492 silently wrapping negative numbers around. (Bug#8722)
2493 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2494 (Bug#8722)
2495
2496 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2497
2498 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2499
2500 ccl: add integer overflow checks
2501 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2502 (IN_INT_RANGE): New macros.
2503 (ccl_driver): Use them to check for integer overflow when
2504 decoding a CCL program. Many of the new checks are whether XINT (x)
2505 fits in int; it doesn't always, on 64-bit hosts. The new version
2506 doesn't catch all possible integer overflows, but it's an
2507 improvement. (Bug#8719)
2508
2509 * alloc.c (make_event_array): Use XINT, not XUINT.
2510 There's no need for unsigned here.
2511
2512 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2513 This follows up to the 2011-05-06 change that substituted uintptr_t
2514 for EMACS_INT. This case wasn't caught back then.
2515
2516 Rework Fformat to avoid integer overflow issues.
2517 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2518 now (part of C89). Include <verify.h>.
2519 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2520 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2521 (Fformat): Avoid the prepass trying to compute sizes; it was only
2522 approximate and thus did not catch overflow reliably. Instead, walk
2523 through the format just once, formatting and computing sizes as we go,
2524 checking for integer overflow at every step, and allocating a larger
2525 buffer as needed. Keep track separately whether the format is
2526 multibyte. Keep only the most-recently calculated precision, rather
2527 than them all. Record whether each argument has been converted to
2528 string. Use EMACS_INT, not int, for byte and char and arg counts.
2529 Support field widths and precisions larger than INT_MAX. Avoid
2530 sprintf's undefined behavior with conversion specifications such as %#d
2531 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2532 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2533 formatting out-of-range floating point numbers with int
2534 formats. (Bug#8668)
2535
2536 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2537
2538 * data.c: Avoid integer truncation in expressions involving floats.
2539 * data.c: Include <intprops.h>.
2540 (arith_driver): When there's an integer overflow in an expression
2541 involving floating point, convert the integers to floating point
2542 so that the resulting value does not suffer from catastrophic
2543 integer truncation. For example, on a 64-bit host (* 4
2544 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2545 Do not rely on undefined behavior after integer overflow.
2546
2547 merge count_size_as_multibyte, parse_str_to_multibyte
2548 * character.c, character.h (count_size_as_multibyte):
2549 Rename from parse_str_to_multibyte; all uses changed.
2550 Check for integer overflow.
2551 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2552 since it's now a duplicate of the other. This is more of
2553 a character than a buffer op, so better that it's in character.c.
2554 * fns.c, print.c: Adjust to above changes.
2555
2556 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2557
2558 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2559
2560 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2561
2562 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2563 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2564 (x_clipboard_manager_save): Now static.
2565 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2566
2567 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2568 (crypto_hash_function): Now static.
2569 Fix pointer signedness problems. Avoid unnecessary initializations.
2570
2571 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2572
2573 * termhooks.h (Vselection_alist): Make it terminal-local.
2574
2575 * terminal.c (create_terminal): Initialize it.
2576
2577 * xselect.c: Support for clipboard managers.
2578 (Vselection_alist): Move to termhooks.h as terminal-local var.
2579 (LOCAL_SELECTION): New macro.
2580 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2581 (symbol_to_x_atom): Remove gratuitous arg.
2582 (x_handle_selection_request, lisp_data_to_selection_data)
2583 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2584 (x_own_selection, x_get_local_selection, x_convert_selection):
2585 New arg, specifying work frame. Use terminal-local Vselection_alist.
2586 (some_frame_on_display): Delete unused function.
2587 (Fx_own_selection_internal, Fx_get_selection_internal)
2588 (Fx_disown_selection_internal, Fx_selection_owner_p)
2589 (Fx_selection_exists_p): New optional frame arg.
2590 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2591 (x_handle_selection_clear): Don't treat other terminals with the
2592 same keyboard specially. Use the terminal-local Vselection_alist.
2593 (x_clear_frame_selections): Use Frun_hook_with_args.
2594
2595 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2596
2597 * xterm.h: Add support for those atoms.
2598
2599 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2600
2601 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2602 (converted_selections, conversion_fail_tag): New global variables.
2603 (x_selection_request_lisp_error): Free the above.
2604 (x_get_local_selection): Remove unnecessary code.
2605 (x_reply_selection_request): Args changed; handle arbitrary array
2606 of converted selections stored in converted_selections.
2607 Separate the XChangeProperty and SelectionNotify steps.
2608 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2609 (x_convert_selection): New function.
2610 (x_handle_selection_event): Simplify.
2611 (x_get_foreign_selection): Don't ignore incoming requests while
2612 waiting for an answer; this will fail when we implement
2613 SAVE_TARGETS, and seems unnecessary anyway.
2614 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2615 (Vx_sent_selection_functions): Doc fix.
2616
2617 2011-05-26 Leo Liu <sdl.web@gmail.com>
2618
2619 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2620
2621 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2622
2623 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2624
2625 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2626 for fringe update if it has periodic bitmap.
2627 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2628 and fringe_bitmap_periodic_p.
2629
2630 * fringe.c (get_fringe_bitmap_data): New function.
2631 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2632 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2633 row. Mark glyph row for fringe update if periodicity changed.
2634
2635 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2636 for fringe update unless it has periodic bitmap.
2637
2638 2011-05-25 Kenichi Handa <handa@m17n.org>
2639
2640 * xdisp.c (get_next_display_element): Set correct it->face_id for
2641 a static composition.
2642
2643 2011-05-24 Leo Liu <sdl.web@gmail.com>
2644
2645 * deps.mk (fns.o):
2646 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2647
2648 * fns.c (crypto_hash_function, Fsha1): New function.
2649 (Fmd5): Use crypto_hash_function.
2650 (syms_of_fns): Add Ssha1.
2651
2652 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2653
2654 * gnutls.c: Remove unused macros.
2655 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2656 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2657 Remove macros that are defined and never used.
2658 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2659
2660 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2661
2662 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2663 (Fx_get_selection_internal): Minor cleanup.
2664 (Fx_own_selection_internal): Rename arguments for consistency with
2665 select.el.
2666
2667 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2668
2669 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2670
2671 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2672
2673 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2674
2675 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2676
2677 * dispnew.c (scrolling_window): Don't exclude the case that the
2678 last enabled row in the desired matrix touches the bottom boundary.
2679
2680 2011-05-21 Glenn Morris <rgm@gnu.org>
2681
2682 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2683 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2684 and add some more files.
2685
2686 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2687
2688 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2689 report_file_error introduced by the change from 2011-05-07.
2690
2691 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 * systime.h (Time): Define only if emacs is defined.
2694 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2695 where the include path doesn't have X11/X.h by default. See
2696 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2697
2698 2011-05-20 Kenichi Handa <handa@m17n.org>
2699
2700 * composite.c (find_automatic_composition): Fix previous change.
2701
2702 2011-05-20 Glenn Morris <rgm@gnu.org>
2703
2704 * lisp.mk: New file, split from Makefile.in.
2705 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2706 (shortlisp): Remove.
2707 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2708
2709 2011-05-19 Glenn Morris <rgm@gnu.org>
2710
2711 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2712 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2713 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2714 (lisp): Set the order to that of loadup.el.
2715 (shortlisp): Make it a copy of $lisp.
2716 (SOME_MACHINE_LISP): Remove.
2717 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2718 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2719
2720 2011-05-18 Kenichi Handa <handa@m17n.org>
2721
2722 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2723 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2724 (find_automatic_composition): Mostly rewrite for efficiency.
2725
2726 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2727
2728 * makefile.w32-in: Update dependencies.
2729
2730 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2731
2732 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2733 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2734
2735 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2736
2737 Fix some integer overflow issues, such as string length overflow.
2738
2739 * insdel.c (count_size_as_multibyte): Check for string overflow.
2740
2741 * character.c (lisp_string_width): Check for string overflow.
2742 Use EMACS_INT, not int, for string indexes and lengths; in
2743 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2744 the resulting string length overflows an EMACS_INT; instead,
2745 report a string overflow if no precision given. When checking for
2746 precision exhaustion, use a check that cannot possibly have
2747 integer overflow. (Bug#8675)
2748 * character.h (lisp_string_width): Adjust to new signature.
2749
2750 * alloc.c (string_overflow): New function.
2751 (Fmake_string): Use it. This doesn't change behavior, but saves
2752 a few bytes and will simplify future changes.
2753 * character.c (string_escape_byte8): Likewise.
2754 * lisp.h (string_overflow): New decl.
2755
2756 Fixups, following up to the user-interface timestamp change.
2757 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2758 for UI timestamps, instead of unsigned long.
2759 * msdos.c (mouse_get_pos): Likewise.
2760 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2761 * w32gui.h (Time): Define by including "systime.h" rather than by
2762 declaring it ourselves. (Bug#8664)
2763
2764 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2765 * image.c (clear_image_cache): Likewise.
2766
2767 * term.c (term_mouse_position): Don't assume time_t wraparound.
2768
2769 Be more systematic about user-interface timestamps.
2770 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2771 and sometimes 'EMACS_UINT', to represent these timestamps.
2772 This change causes it to use 'Time' uniformly, as that's what X uses.
2773 This makes the code easier to follow, and makes it easier to catch
2774 integer overflow bugs such as Bug#8664.
2775 * frame.c (Fmouse_position, Fmouse_pixel_position):
2776 Use Time, not unsigned long, for user-interface timestamps.
2777 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2778 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2779 * keyboard.h (last_event_timestamp): Likewise.
2780 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2781 * menu.h (xmenu_show): Likewise.
2782 * term.c (term_mouse_position): Likewise.
2783 * termhooks.h (struct input_event.timestamp): Likewise.
2784 (struct terminal.mouse_position_hook): Likewise.
2785 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2786 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2787 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2788 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2789 what it was before.
2790 * menu.h, termhooks.h: Include "systime.h", for Time.
2791
2792 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2793 Don't assume that the difference between two unsigned long values
2794 can fit into an integer. At this point, we know button_down_time
2795 <= event->timestamp, so the difference must be nonnegative, so
2796 there's no need to cast the result if double-click-time is
2797 nonnegative, as it should be; check that it's nonnegative, just in
2798 case. This bug is triggered when events are more than 2**31 ms
2799 apart (about 25 days). (Bug#8664)
2800
2801 * xselect.c (last_event_timestamp): Remove duplicate decl.
2802 (x_own_selection): Remove needless cast to unsigned long.
2803
2804 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2805 that always fit in int. Use a sentinel instead of a counter, to
2806 avoid a temp and to allay GCC's concerns about possible int overflow.
2807 * frame.h (struct frame): Use int for menu_bar_items_used
2808 instead of EMACS_INT, since it always fits in int.
2809
2810 * menu.c (grow_menu_items): Check for int overflow.
2811
2812 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2813
2814 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2815 Before, the code was not consistent. These values cannot exceed
2816 2**31 - 1 so there's no need to make them unsigned.
2817 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2818 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2819 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2820 as modifiers.
2821 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2822
2823 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2824 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2825 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2826 presumably because the widths might not match.
2827
2828 * window.c (size_window): Avoid needless test at loop start.
2829
2830 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2831
2832 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2833
2834 2011-05-12 Drew Adams <drew.adams@oracle.com>
2835
2836 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2837
2838 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2839
2840 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2841 `width' to `bar_area_x' and `bar_area_width', respectively.
2842 (x_scroll_run): Take account of fringe background extension.
2843
2844 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2845 Rename local vars `left' and `width' to `bar_area_x' and
2846 `bar_area_width', respectively.
2847 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2848 background extension.
2849
2850 2011-05-10 Jim Meyering <meyering@redhat.com>
2851
2852 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2853
2854 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2855
2856 * image.c (Finit_image_library): Return t for built-in image types,
2857 like pbm and xbm. (Bug#8640)
2858
2859 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2860
2861 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2862
2863 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2864
2865 * w32console.c (Fset_screen_color): Doc fix.
2866 (Fget_screen_color): New function.
2867 (syms_of_ntterm): Defsubr it.
2868
2869 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2870 unlink the temporary file if Fcall_process didn't create it in the
2871 first place.
2872 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2873 child process will be redirected to a file specified with `:file'.
2874 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2875 cue to call_process_cleanup not to close that handle.
2876
2877 2011-05-07 Ben Key <bkey76@gmail.com>
2878
2879 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2880 one of two shell specific rules, either bootstrap-temacs-CMD or
2881 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2882 to the previous implementation of the bootstrap-temacs rule.
2883 The bootstrap-temacs-CMD rule is similar to the previous
2884 implementation of the bootstrap-temacs rule except that it
2885 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2886 variable.
2887
2888 These changes, along with some changes to nt/configure.bat,
2889 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2890 earlier fix to add support for --cflags and --ldflags options
2891 that include quotes so that it works whether make uses cmd or
2892 sh as the shell.
2893
2894 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2895
2896 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2897 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2898 is a constant.
2899 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2900 a string. Handle both cases.
2901 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2902 (Fdbus_register_method): Use Qinvalid_function.
2903
2904 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2905
2906 * makefile.w32-in: Update dependencies.
2907 (LISP_H): Add inttypes.h and stdin.h.
2908 (PROCESS_H): Add unistd.h.
2909
2910 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2911
2912 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2913 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2914
2915 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2916
2917 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2918
2919 * term.c (vfatal): Remove stray call to va_end.
2920 It's not needed and the C Standard doesn't allow it here anyway.
2921
2922 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2923 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2924
2925 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2926 bytes.
2927
2928 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2929
2930 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2931
2932 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2933
2934 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2935
2936 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2937
2938 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2939 * charset.c (Fdefine_charset_internal): Don't initialize
2940 charset.code_space[15]. The value was garbage, on hosts with
2941 32-bit int (Bug#8600).
2942
2943 * lread.c (read_integer): Be more consistent with string-to-number.
2944 Use string_to_number to do the actual conversion; this avoids
2945 rounding errors and fixes some other screwups. Without this fix,
2946 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2947 (digit_to_number): Move earlier, for benefit of read_integer.
2948 Return -1 if the digit is out of range for the base, -2 if it is
2949 not a digit in any supported base. (Bug#8602)
2950
2951 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2952
2953 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2954 to match comment at start of function. This also removes a
2955 GCC warning about overflow in a 32+64-bit port.
2956
2957 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2958
2959 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2960 Reported by Stefan Monnier in
2961 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2962 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2963 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2964
2965 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2966 (EMACS_UINTPTR): Likewise, with uintptr_t.
2967
2968 * lisp.h: Prefer 64-bit EMACS_INT if available.
2969 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2970 on 32-bit hosts that have 64-bit int, so that they can access
2971 large files.
2972 However, temporarily disable this change unless the temporary
2973 symbol WIDE_EMACS_INT is defined.
2974
2975 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2976
2977 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2978 This removes an assumption that EMACS_INT and long are the same
2979 width as pointers. The assumption is true for Emacs porting targets
2980 now, but we want to make other targets possible.
2981 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2982 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2983 In the rest of the code, change types of integers that hold casted
2984 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2985 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2986 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2987 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2988 No need to cast type when ORing.
2989 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2990 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2991 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2992 assume EMACS_INT is the same width as char *.
2993 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2994 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2995 Remove no-longer-needed casts.
2996 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2997 (xg_tool_bar_help_callback, xg_make_tool_item):
2998 Use EMACS_INTPTR to hold an integer
2999 that will be cast to void *; this can avoid a GCC warning
3000 if EMACS_INT is not the same width as void *.
3001 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3002 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3003 (current_message_1, set_message_1):
3004 Use a local to convert to proper width without a cast.
3005 * xmenu.c (dialog_selection_callback): Likewise.
3006
3007 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3008 Also, don't assume VALBITS / RAND_BITS is less than 5,
3009 and don't rely on undefined behavior when shifting a 1 left into
3010 the sign bit.
3011 * lisp.h (get_random): Change signature to match.
3012
3013 * lread.c (hash_string): Use size_t, not int, for hash computation.
3014 Normally we prefer signed values; but hashing is special, because
3015 it's better to use unsigned division on hash table sizes so that
3016 the remainder is nonnegative. Also, size_t is the natural width
3017 for hashing into memory. The previous code used 'int', which doesn't
3018 retain enough info to hash well into very large tables.
3019 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3020
3021 * dbusbind.c: Don't possibly lose pointer info when converting.
3022 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3023 Use XPNTR rather than XHASH, so that the high-order bits of
3024 the pointer aren't lost when converting through void *.
3025
3026 * eval.c (Fautoload): Don't double-shift a pointer.
3027
3028 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3029
3030 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3031
3032 * gnutls.c (DEF_GNUTLS_FN):
3033 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3034
3035 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3036
3037 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3038 marker. (Bug#8610)
3039
3040 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3041
3042 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3043 New version that can reserve upto 2GB of heap space.
3044
3045 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3046
3047 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3048
3049 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3050
3051 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3052 `gnutls_certificate_set_x509_key_file'.
3053
3054 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3055
3056 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3057 Update dependencies.
3058
3059 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3060
3061 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3062 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3063 Remove unused parameter `fildes'.
3064 * process.c (read_process_output, send_process): Don't pass it.
3065
3066 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3067
3068 Fix previous change: the library cache is defined in w32.c.
3069 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3070 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3071
3072 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3073
3074 Implement dynamic loading of GnuTLS on Windows.
3075
3076 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3077 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3078 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3079 Declare.
3080
3081 * gnutls.c (Qgnutls_dll): Define.
3082 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3083 (gnutls_*): Declare function pointers.
3084 (init_gnutls_functions): New function to initialize function pointers.
3085 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3086 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3087 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3088 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3089 (emacs_gnutls_write, emacs_gnutls_read)
3090 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3091 (Fgnutls_available_p): New function.
3092 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3093 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3094 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3095
3096 * image.c: Include w32.h.
3097 (Vimage_type_cache): Delete.
3098 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3099 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3100 (w32_delayed_load): Move to w32.c.
3101
3102 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3103
3104 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3105 (w32_delayed_load): Move from image.c. When loading a library, record
3106 its filename in the :loaded-from property of the library id.
3107 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3108 Initialize and staticpro them.
3109 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3110
3111 * process.c: Include lisp.h before w32.h, not after.
3112 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3113 instead of gnutls_record_check_pending.
3114
3115 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3116
3117 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3118
3119 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3120 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3121 as passed in.
3122
3123 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3124
3125 * xterm.c (x_set_frame_alpha): Do not set property on anything
3126 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3127
3128 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3129
3130 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3131
3132 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3133
3134 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3135 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3136 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3137 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3138 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3139 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3140 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3141 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3142 (Qgnutls_bootprop_callbacks_verify): Make static.
3143
3144 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3145
3146 * callproc.c: Indentation fixup.
3147
3148 * sysdep.c (wait_for_termination_1): Make static.
3149 (wait_for_termination, interruptible_wait_for_termination):
3150 Move after wait_for_termination_1.
3151
3152 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3153
3154 * sysdep.c (interruptible_wait_for_termination): New function
3155 which is like wait_for_termination, but allows keyboard
3156 interruptions.
3157
3158 * callproc.c (Fcall_process): Add (:file "file") as an option for
3159 the STDOUT buffer.
3160 (Fcall_process_region): Ditto.
3161
3162 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3163
3164 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3165 rather than `XVECTOR (FOO)->size'.
3166
3167 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3168 inttypes.h, as a gnulib replacement is used if it not available in
3169 system headers.
3170
3171 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3172
3173 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3174 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3175 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3176
3177 * coding.c (coding_alloc_by_realloc): Error out if destination
3178 will grow beyond MOST_POSITIVE_FIXNUM.
3179 (decode_coding_emacs_mule): Abort if there isn't enough place in
3180 charbuf for the composition carryover bytes. Reserve an extra
3181 space for up to 2 characters produced in a loop.
3182 (decode_coding_iso_2022): Abort if there isn't enough place in
3183 charbuf for the composition carryover bytes.
3184
3185 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3186
3187 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3188 aborting when %lld or %lll format is passed.
3189 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3190 %llo or %llx format is passed. (Bug#8545)
3191
3192 * window.c (window_scroll_line_based): Use a marker instead of
3193 simple variables to record original value of point. (Bug#7952)
3194
3195 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3196 produced by %s or %c overflows available buffer space. (Bug#8545)
3197
3198 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3199
3200 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3201 (SIZE_MAX): Move defn after all includes, as they might #define it.
3202
3203 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3204
3205 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3206
3207 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3208
3209 * keyboard.c (Qdelayed_warnings_hook): Define.
3210 (command_loop_1): Run `delayed-warnings-hook'
3211 if Vdelayed_warnings_list is non-nil.
3212 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3213 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3214
3215 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3216
3217 * doprnt.c (doprnt): Don't return value smaller than the buffer
3218 size if the message was truncated. (Bug#8545).
3219
3220 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3221
3222 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3223 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3224
3225 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3226
3227 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3228
3229 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3230
3231 * makefile.w32-in: Update dependencies.
3232
3233 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3234
3235 Improve `doprnt' and its usage. (Bug#8545)
3236 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3237 `format_end'. Remove support for %l as a conversion specifier.
3238 Don't use xrealloc. Improve diagnostics when the %l size modifier
3239 is used. Update the commentary.
3240
3241 * eval.c (verror): Simplify calculation of size_t.
3242
3243 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3244 messages.
3245
3246 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3247
3248 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3249 change.
3250
3251 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3252
3253 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3254 This makes this file independent of the recent pseudovector change.
3255
3256 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3257
3258 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3259
3260 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3261 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3262 Remove unused local.
3263 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3264
3265 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3266 GCC 4.6.0 optimizes based on type-based alias analysis.
3267 For example, if b is of type struct buffer * and v of type struct
3268 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3269 != &v->size, and therefore "v->size = 1; b->size = 2; return
3270 v->size;" must therefore return 1. This assumption is incorrect
3271 for Emacs, since it type-puns struct Lisp_Vector * with many other
3272 types. To fix this problem, this patch adds a new type struct
3273 vectorlike_header that documents the constraints on layout of vectors
3274 and pseudovectors, and helps optimizing compilers not get fooled
3275 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3276 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3277 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3278 the size member.
3279 (XSETPVECTYPE): Rewrite in terms of new macro.
3280 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3281 This is a bit clearer, and further avoids the possibility of
3282 undesirable aliasing.
3283 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3284 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3285 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3286 since Lisp_Subr is a special case (no "next" field).
3287 (ASIZE): Now uses header.size rather than size.
3288 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3289 to avoid the hassle of writing XVECTOR (foo)->header.size.
3290 (struct vectorlike_header): New type.
3291 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3292 object, to help avoid aliasing.
3293 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3294 (SUBRP): Likewise, since Lisp_Subr is a special case.
3295 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3296 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3297 (struct Lisp_Hash_Table): Combine first two members into a single
3298 struct vectorlike_header member. All uses of "size" and "next" members
3299 changed to be "header.size" and "header.next".
3300 * buffer.h (struct buffer): Likewise.
3301 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3302 * frame.h (struct frame): Likewise.
3303 * process.h (struct Lisp_Process): Likewise.
3304 * termhooks.h (struct terminal): Likewise.
3305 * window.c (struct save_window_data, struct saved_window): Likewise.
3306 * window.h (struct window): Likewise.
3307 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3308 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3309 * buffer.c (init_buffer_once): Likewise.
3310 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3311 special case.
3312 * process.c (Fformat_network_address): Use local var for size,
3313 for brevity.
3314
3315 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3316
3317 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3318 * data.c (atof): Remove decl; no longer used or needed.
3319 (digit_to_number): Move to lread.c.
3320 (Fstring_to_number): Use new string_to_number function, to be
3321 consistent with how the Lisp reader treats infinities and NaNs.
3322 Do not assume that floating-point numbers represent EMACS_INT
3323 without losing information; this is not true on most 64-bit hosts.
3324 Avoid double-rounding errors, by insisting on integers when
3325 parsing non-base-10 numbers, as the documentation specifies.
3326 * lisp.h (string_to_number): New decl, replacing ...
3327 (isfloat_string): Remove.
3328 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3329 (read1): Do not accept +. and -. as integers; this
3330 appears to have been a coding error. Similarly, do not accept
3331 strings like +-1e0 as floating point numbers. Do not report
3332 overflow for integer overflows unless the base is not 10 which
3333 means we have no simple and reliable way to continue.
3334 Break out the floating-point parsing into a new
3335 function string_to_number, so that Fstring_to_number parses
3336 floating point numbers consistently with the Lisp reader.
3337 (digit_to_number): Move here from data.c. Make it static inline.
3338 (E_CHAR, EXP_INT): Remove, replacing with ...
3339 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3340 (string_to_number): New function, replacing isfloat_string.
3341 This function checks for valid syntax and produces the resulting
3342 Lisp float number too. Rework it so that string-to-number
3343 no longer mishandles examples like "1.0e+". Use strtoumax,
3344 so that overflow for non-base-10 numbers is reported only when
3345 there's no portable and simple way to convert to floating point.
3346
3347 * textprop.c (set_text_properties_1): Rewrite for clarity,
3348 and to avoid GCC warning about integer overflow.
3349
3350 * intervals.h (struct interval): Use EMACS_INT for members
3351 where EMACS_UINT might cause problems. See
3352 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3353 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3354 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3355 All uses changed.
3356 (offset_intervals): Tell GCC not to worry about length overflow
3357 when negating a negative length.
3358
3359 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3360 (overrun_check_free): Likewise.
3361
3362 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3363 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3364 word size.
3365
3366 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3367 (gnutls_make_error): Rename local to avoid shadowing.
3368 (gnutls_emacs_global_deinit): ifdef out; not used.
3369 (Fgnutls_boot): Use const for pointer to readonly storage.
3370 Comment out unused local. Fix pointer signedness problems.
3371
3372 * lread.c (openp): Don't stuff size_t into an 'int'.
3373 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3374 about possible signed overflow.
3375
3376 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3377 (GDK_KEY_g): Don't define if already defined.
3378 (xg_prepare_tooltip): Avoid pointer signedness problem.
3379 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3380
3381 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3382 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3383
3384 * xfns.c (Fx_window_property): Simplify a bit,
3385 to make a bit faster and to avoid GCC 4.6.0 warning.
3386 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3387
3388 * fns.c (internal_equal): Don't assume size_t fits in int.
3389
3390 * alloc.c (compact_small_strings): Tighten assertion a little.
3391
3392 Replace pEd with more-general pI, and fix some printf arg casts.
3393 * lisp.h (pI): New macro, generalizing old pEd macro to other
3394 conversion specifiers. For example, use "...%"pI"d..." rather
3395 than "...%"pEd"...".
3396 (pEd): Remove. All uses replaced with similar uses of pI.
3397 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3398 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3399 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3400 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3401 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3402 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3403 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3404 64-bit hosts.
3405 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3406 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3407 * print.c (safe_debug_print, print_object): Likewise.
3408 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3409 to int.
3410 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3411 avoiding the 0 flag, which is not portable.
3412 * process.c (Fmake_network_process): Use pI to avoid cast.
3413 * region-cache.c (pp_cache): Likewise.
3414 * xdisp.c (decode_mode_spec): Likewise.
3415 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3416 behavior on 64-bit hosts with printf arg.
3417 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3418 (x_stop_queuing_selection_requests): Likewise.
3419 (x_get_window_property): Don't truncate byte count to an 'int'
3420 when tracing.
3421
3422 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3423 here, since it parses constructs like leading '-' and spaces,
3424 which are not wanted; and it overflows with large numbers.
3425 Instead, simply match F[0-9]+, which is what is wanted anyway.
3426
3427 * alloc.c: Remove unportable assumptions about struct layout.
3428 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3429 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3430 (allocate_vectorlike, make_pure_vector): Use the new macros,
3431 plus offsetof, to remove unportable assumptions about struct layout.
3432 These assumptions hold on all porting targets that I know of, but
3433 they are not guaranteed, they're easy to remove, and removing them
3434 makes further changes easier.
3435
3436 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3437 This doesn't fix a bug but makes the code clearer.
3438 (string_overrun_cookie): Now const. Use initializers that
3439 don't formally overflow signed char, to avoid warnings.
3440 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3441 can cause Emacs to crash when string overrun checking is enabled.
3442 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3443 multiple of sizeof (EMACS_INT); it need not be, if
3444 alignof(EMACS_INT) < sizeof (EMACS_INT).
3445 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3446
3447 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3448
3449 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3450
3451 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3452
3453 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3454 supposed to be handshaking. (Bug#8556)
3455 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3456
3457 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3458
3459 * lisp.h (Qdebug): List symbol.
3460 * eval.c (Qdebug): Restore global linkage.
3461 * keyboard.c (debug-on-event): New variable.
3462 (handle_user_signal): Break into debugger when debug-on-event
3463 matches the current signal symbol.
3464
3465 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3466
3467 * alloc.c (check_sblock, check_string_bytes)
3468 (check_string_free_list): Convert to standard C.
3469
3470 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3471
3472 * w32.c (emacs_gnutls_push): Fix typo.
3473
3474 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3475
3476 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3477 "cast to pointer from integer of different size".
3478
3479 Improve doprnt and its use in verror. (Bug#8545)
3480 * doprnt.c (doprnt): Document the set of format control sequences
3481 supported by the function. Use SAFE_ALLOCA instead of always
3482 using `alloca'.
3483
3484 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3485 is one byte too soon. Don't use xrealloc; instead xfree and
3486 xmalloc anew.
3487
3488 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3489
3490 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3491 callbacks stage.
3492
3493 * gnutls.c: Renamed global_initialized to
3494 gnutls_global_initialized. Added internals for the
3495 :verify-hostname-error, :verify-error, and :verify-flags
3496 parameters of `gnutls-boot' and documented those parameters in the
3497 docstring. Start callback support.
3498 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3499 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3500 on error. Return error code.
3501 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3502 (emacs_gnutls_read): Likewise.
3503 (Fgnutls_boot): Return handshake error code.
3504 (emacs_gnutls_handle_error): New function.
3505 (wsaerror_to_errno): Likewise.
3506
3507 * w32.h (emacs_gnutls_pull): Add prototype.
3508 (emacs_gnutls_push): Likewise.
3509
3510 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3511 (emacs_gnutls_push): Likewise.
3512
3513 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3514
3515 * process.c (wait_reading_process_output): Check if GnuTLS
3516 buffered some data internally if no FDs are set for TLS
3517 connections.
3518
3519 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3520 (LIBS): Link to USER_LIBS.
3521 ($(BLD)/gnutls.$(0)): New target.
3522
3523 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3524
3525 * xdisp.c (handle_single_display_spec): Rename the
3526 display_replaced_before_p argument into display_replaced_p, to
3527 make it consistent with the commentary. Fix typos in the
3528 commentary.
3529
3530 * textprop.c (syms_of_textprop): Remove dead code.
3531 (copy_text_properties): Delete obsolete commentary about an
3532 interface that was deleted long ago. Fix typos in the description
3533 of arguments.
3534
3535 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3536 to changes in oldXMenu/XMenu.h from 2011-04-16.
3537 <menu_help_message, prev_menu_help_message>: Constify.
3538 (IT_menu_make_room): menu->help_text is now `const char **';
3539 adjust.
3540
3541 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3542 to changes in oldXMenu/XMenu.h from 2011-04-16.
3543 (struct XMenu): Declare `help_text' `const char **'.
3544
3545 * xfaces.c <Qunspecified>: Make extern again.
3546
3547 * syntax.c: Include sys/types.h before including regex.h, as
3548 required by Posix.
3549
3550 * doc.c (get_doc_string): Improve the format passed to `error'.
3551
3552 * doprnt.c (doprnt): Improve commentary.
3553
3554 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3555
3556 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3557 them with etags.
3558
3559 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3560 changes in globals.h immediately force recompilation.
3561 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3562 $(CURDIR)/s/ms-w32.h.
3563 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3564
3565 * character.c (Fchar_direction): Function deleted.
3566 (syms_of_character): Don't defsubr it.
3567 <char-direction-table>: Deleted.
3568
3569 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3570
3571 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3572 * doprnt.c: Include limits.h.
3573 (SIZE_MAX): New macro.
3574 (doprnt): Return a size_t value. 2nd arg is now size_t.
3575 Many local variables are now size_t instead of int or unsigned.
3576 Improve overflow protection. Support `l' modifier for integer
3577 conversions. Support %l conversion. Don't assume an EMACS_INT
3578 argument for integer conversions and for %c.
3579
3580 * lisp.h (doprnt): Restore prototype.
3581
3582 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3583 $(SRC)/character.h.
3584
3585 * Makefile.in (base_obj): Add back doprnt.o.
3586
3587 * deps.mk (doprnt.o): Add back prerequisites.
3588 (callint.o): Depend on character.h.
3589
3590 * eval.c (internal_lisp_condition_case): Include the handler
3591 representation in the error message.
3592 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3593 when breaking from the loop.
3594
3595 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3596
3597 * callint.c (Fcall_interactively): When displaying error message
3598 about invalid control letter, pass the character's codepoint, not
3599 a pointer to its multibyte form. Improve display of the character
3600 in octal and display also its hex code.
3601
3602 * character.c (char_string): Use %x to display the (unsigned)
3603 codepoint of an invalid character, to avoid displaying a bogus
3604 negative value.
3605
3606 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3607 `error', not SYMBOL_NAME itself.
3608
3609 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3610 character arguments to `error'.
3611
3612 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3613 to `error' in error message about FINAL_CHAR argument. Make sure
3614 FINAL_CHAR is a character, and use %c when it is passed as
3615 argument to `error'.
3616
3617 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3618
3619 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3620
3621 * w32.c: Include <time.h>.
3622 (sys_localtime): New function.
3623
3624 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3625
3626 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3627
3628 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3629
3630 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3631
3632 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3633 zombies (Bug#8467).
3634
3635 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3636
3637 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3638 gl_state.e_property when gl_state.object is Qt.
3639
3640 * insdel.c (make_gap_larger): Remove limitation of buffer size
3641 to <= INT_MAX.
3642
3643 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3644
3645 * xdisp.c (lookup_glyphless_char_display)
3646 (produce_glyphless_glyph): Handle cons cell entry in
3647 glyphless-char-display.
3648 (Vglyphless_char_display): Document it.
3649
3650 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3651 glyphless-char-display.
3652
3653 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3654
3655 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3656
3657 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3658
3659 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3660 definition for no-X builds.
3661
3662 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3663
3664 Static checks with GCC 4.6.0 and non-default toolkits.
3665
3666 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3667
3668 * process.c (keyboard_bit_set): Define only if SIGIO.
3669 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3670 (send_process): Repair possible setjmp clobbering.
3671
3672 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3673
3674 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3675
3676 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3677
3678 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3679 Define only if needed.
3680
3681 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3682 by pacifying GCC about it. Maybe it's time to retire it?
3683 * xfaces.c (USG, __TIMEVAL__): Likewise.
3684
3685 * dispextern.h (struct redisplay_interface): Rename param
3686 to avoid shadowing.
3687 * termhooks.h (struct terminal): Likewise.
3688 * xterm.c (xembed_send_message): Likewise.
3689
3690 * insdel.c (make_gap_smaller): Define only if
3691 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3692
3693 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3694 it.
3695
3696 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3697 so that we aren't warned about unused symbols.
3698
3699 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3700
3701 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3702
3703 * xfns.c (x_real_positions): Mark locals as initialized.
3704
3705 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3706
3707 * xterm.c: Fix problems found by static analysis with other toolkits.
3708 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3709 (x_dispatch_event): Declare static if USE_GTK, and
3710 define if USE_GTK || USE_X_TOOLKIT.
3711 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3712 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3713 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3714 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3715
3716 * xmenu.c (menu_help_callback): Pointer type fixes.
3717 Use const pointers when pointing at readonly data. Avoid pointer
3718 signedness clashes.
3719 (FALSE): Remove unused macro.
3720 (update_frame_menubar): Remove unused decl.
3721
3722 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3723
3724 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3725 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3726 (single_menu_item): Rename local to avoid shadowing.
3727
3728 * keyboard.c (make_lispy_event): Remove unused local var.
3729
3730 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3731 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3732
3733 * bitmaps: Change bitmaps from unsigned char back to the X11
3734 compatible char. Avoid the old compiler warnings about
3735 out-of-range initializers by using, for example, '\xab' rather
3736 than 0xab.
3737
3738 * xgselect.c (xgselect_initialize): Check vs interface
3739 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3740
3741 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3742
3743 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3744 to read-only memory.
3745
3746 * fns.c (vector): Remove; this old hack is no longer needed.
3747
3748 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3749 Remove unused var.
3750 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3751
3752 * xrdb.c (x_load_resources): Omit unused local.
3753
3754 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3755 (x_window): Rename locals to avoid shadowing.
3756 (USG): Use the kludged USG macro, to pacify gcc.
3757
3758 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3759 (x_term_init): Remove local to avoid shadowing.
3760
3761 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3762
3763 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3764 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3765
3766 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3767
3768 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3769
3770 Fix regex.c, syntax.c and friends for buffers > 2GB.
3771 * syntax.h (struct gl_state_s): Declare character position members
3772 EMACS_INT.
3773
3774 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3775
3776 * textprop.c (verify_interval_modification, interval_of):
3777 Declare arguments EMACS_INT.
3778
3779 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3780 EMACS_INT.
3781
3782 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3783
3784 * indent.c (Fvertical_motion): Local variable it_start is now
3785 EMACS_INT.
3786
3787 * regex.c (re_match, re_match_2, re_match_2_internal)
3788 (bcmp_translate, regcomp, regexec, print_double_string)
3789 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3790 (re_compile_pattern, re_exec): Declare arguments and local
3791 variables `size_t' and `ssize_t' and return values `regoff_t', as
3792 appropriate.
3793 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3794 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3795 <compile_stack_type>: `size' and `avail' are now `size_t'.
3796
3797 * regex.h <regoff_t>: Use ssize_t, not int.
3798 (re_search, re_search_2, re_match, re_match_2): Arguments that
3799 specify buffer/string position and length are now ssize_t and
3800 size_t. Return type is regoff_t.
3801
3802 2011-04-16 Ben Key <bkey76@gmail.com>
3803
3804 * nsfont.m: Fixed bugs in ns_get_family and
3805 ns_descriptor_to_entity that were caused by using free to
3806 deallocate memory blocks that were allocated by xmalloc (via
3807 xstrdup). This caused Emacs to crash when compiled with
3808 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3809 --enable-checking=xmallocoverrun). xfree is now used to
3810 deallocate these memory blocks.
3811
3812 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3813
3814 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3815
3816 emacs_write: Accept and return EMACS_INT for sizes.
3817 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3818 et seq.
3819 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3820 Accept and return EMACS_INT.
3821 (emacs_gnutls_write): Return the number of bytes written on
3822 partial writes.
3823 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3824 (emacs_read, emacs_write): Remove check for negative size, as the
3825 Emacs source code has been audited now.
3826 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3827 (emacs_read, emacs_write): Use it.
3828 * process.c (send_process): Adjust to the new signatures of
3829 emacs_write and emacs_gnutls_write. Do not attempt to store
3830 a byte offset into an 'int'; it might overflow.
3831 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3832
3833 * sound.c: Don't assume sizes fit in 'int'.
3834 (struct sound_device.period_size, alsa_period_size):
3835 Return EMACS_INT, not int.
3836 (struct sound_device.write, vox_write, alsa_write):
3837 Accept EMACS_INT, not int.
3838 (wav_play, au_play): Use EMACS_INT to store sizes and to
3839 record read return values.
3840
3841 2011-04-15 Ben Key <bkey76@gmail.com>
3842
3843 * keyboard.c (Qundefined): Don't declare static since it is used
3844 in nsfns.m.
3845 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3846 static since they are used in nsfont.m.
3847
3848 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3849
3850 * process.c (Qprocessp): Don't declare static.
3851 * lisp.h (Qprocessp): Declare again.
3852
3853 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3854
3855 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3856
3857 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3858
3859 Improve C-level modularity by making more things 'static'.
3860
3861 Don't publish debugger-only interfaces to other modules.
3862 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3863 (verify_bytepos, count_markers): Move decls to the only modules
3864 that need them.
3865 * region-cache.h (pp_cache): Likewise.
3866 * window.h (check_all_windows): Likewise.
3867 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3868
3869 * sysdep.c (croak): Now static, if
3870 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3871 * syssignal.h (croak): Declare only if not static.
3872
3873 * alloc.c (refill_memory_reserve): Now static if
3874 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3875 * lisp.h (refill_memory_reserve): Declare only if not static.
3876
3877 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3878 Define only if USE_LUCID.
3879
3880 * xrdb.c (x_customization_string, x_rm_string): Now static.
3881
3882 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3883 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3884
3885 * xdisp.c (draw_row_with_mouse_face): Now static.
3886 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3887
3888 * window.h (check_all_windows): Mark externally visible.
3889
3890 * window.c (window_deletion_count): Now static.
3891
3892 * undo.c: Make symbols static if they're not exported.
3893 (last_undo_buffer, last_boundary_position, pending_boundary):
3894 Now static.
3895
3896 * textprop.c (interval_insert_behind_hooks): Now static.
3897 (interval_insert_in_front_hooks): Likewise.
3898
3899 * term.c: Make symbols static if they're not exported.
3900 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3901 (max_frame_lines, tty_set_terminal_modes):
3902 (tty_reset_terminal_modes, tty_turn_off_highlight):
3903 (get_tty_terminal): Now static.
3904 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3905 * termhooks.h (term_mouse_moveto): Do not declare if
3906 HAVE_WINDOW_SYSTEM.
3907 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3908 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3909
3910 * sysdep.c: Make symbols static if they're not exported.
3911 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3912 Now static.
3913 (sigprocmask_set, full_mask): Remove; unused.
3914 (wait_debugging): Mark as visible.
3915 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3916 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3917
3918 * syntax.c (syntax_temp): Define only if !__GNUC__.
3919
3920 * sound.c (current_sound_device, current_sound): Now static.
3921
3922 * search.c (searchbufs, searchbuf_head): Now static.
3923
3924 * scroll.c (scroll_cost): Remove; unused.
3925 * dispextern.h (scroll_cost): Remove decl.
3926
3927 * region-cache.h (pp_cache): Mark as externally visible.
3928
3929 * process.c: Make symbols static if they're not exported.
3930 (process_tick, update_tick, create_process, chan_process):
3931 (Vprocess_alist, proc_buffered_char, datagram_access):
3932 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3933 (deactivate_process): Mark defn as static, as well as decl.
3934 * lisp.h (create_process): Remove decl.
3935 * process.h (chan_process, Vprocess_alist): Remove decls.
3936
3937 * print.c: Make symbols static if they're not exported.
3938 (print_depth, new_backquote_output, being_printed, print_buffer):
3939 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3940 (print_interval, print_number_index, initial_stderr_stream):
3941 Now static.
3942 * lisp.h (Fprinc): Remove decl.
3943 (debug_output_compilation_hack): Mark as externally visible.
3944
3945 * sysdep.c (croak): Move decl from here to syssignal.h.
3946 * syssignal.h (croak): Put it here, so the API can be checked when
3947 'croak' is called from dissociate_if_controlling_tty.
3948
3949 * minibuf.c: Make symbols static if they're not exported.
3950 (minibuf_save_list, choose_minibuf_frame): Now static.
3951 * lisp.h (choose_minibuf_frame): Remove decl.
3952
3953 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3954
3955 * lread.c: Make symbols static if they're not exported.
3956 (read_objects, initial_obarray, oblookup_last_bucket_number):
3957 Now static.
3958 (make_symbol): Remove; unused.
3959 * lisp.h (initial_obarray, make_symbol): Remove decls.
3960
3961 * keyboard.c: Make symbols static if they're not exported.
3962 (single_kboard, recent_keys_index, total_keys, recent_keys):
3963 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3964 (this_single_command_key_start, echoing, last_auto_save):
3965 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3966 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3967 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3968 (Vlispy_mouse_stem, double_click_count):
3969 Now static.
3970 (force_auto_save_soon): Define only if SIGDANGER.
3971 (ignore_mouse_drag_p): Now static if
3972 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3973 (print_help): Remove; unused.
3974 (stop_character, last_timer_event): Mark as externally visible.
3975 * keyboard.h (ignore_mouse_drag_p): Declare only if
3976 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3977 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3978 * lisp.h (echoing): Remove decl.
3979 (force_auto_save_soon): Declare only if SIGDANGER.
3980 * xdisp.c (redisplay_window): Simplify code, to make it more
3981 obvious that ignore_mouse_drag_p is not accessed if !defined
3982 USE_GTK && !defined HAVE_NS.
3983
3984 * intervals.c: Make symbols static if they're not exported.
3985 (merge_properties_sticky, merge_interval_right, delete_interval):
3986 Now static.
3987 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3988
3989 * insdel.c: Make symbols static if they're not exported.
3990 However, leave prepare_to_modify_buffer alone. It's never
3991 called from outside this function, but that appears to be a bug.
3992 (combine_after_change_list, combine_after_change_buffer):
3993 (adjust_after_replace, signal_before_change): Now static.
3994 (adjust_after_replace_noundo): Remove; unused.
3995 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3996 (signal_before_change): Remove decls.
3997
3998 * indent.c (val_compute_motion, val_vmotion): Now static.
3999
4000 * image.c: Make symbols static if they're not exported.
4001 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4002 if USE_GTK.
4003 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4004 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4005
4006 * fringe.c (standard_bitmaps): Now static.
4007 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4008
4009 * frame.c: Make symbols static if they're not exported.
4010 (x_report_frame_params, make_terminal_frame): Now static.
4011 (get_frame_param): Now static, unless HAVE_NS.
4012 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4013 (x_get_resource_string): Remove; not used.
4014 * frame.h (make_terminal_frame, x_report_frame_params):
4015 (x_get_resource_string); Remove decls.
4016 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4017 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4018
4019 * font.c, fontset.c: Make symbols static if they're not exported.
4020 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4021 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4022 * font.c (font_close_object): Now static.
4023 * font.h (font_close_object): Remove.
4024 * fontset.c (FONTSET_OBJLIST): Remove.
4025 (free_realized_fontset) #if-0 the body, which does nothing.
4026 (face_suitable_for_char_p): #if-0, as it's never called.
4027 * fontset.h (face_suitable_for_char_p): Remove decl.
4028 * xfaces.c (face_at_string_position):
4029 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4030 since 0 is always ASCII.
4031
4032 * fns.c (weak_hash_tables): Now static.
4033
4034 * fileio.c: Make symbols static if they're not exported.
4035 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4036 (Vwrite_region_annotation_buffers): Now static.
4037
4038 * eval.c: Make symbols static if they're not exported.
4039 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4040 * lisp.h (backtrace_list): Remove decl.
4041
4042 * emacs.c: Make symbols static if they're not exported.
4043 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4044 (fatal_error_code, fatal_error_signal_hook, standard_args):
4045 Now static.
4046 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4047 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4048 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4049 * lisp.h (fatal_error_signal_hook): Remove decl.
4050 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4051
4052 * editfns.c: Move a (normally-unused) function to its only use.
4053 * editfns.c, lisp.h (get_operating_system_release): Remove.
4054 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4055 worth the hassle of breaking this out.
4056
4057 * xterm.c: Make symbols static if they're not exported.
4058 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4059 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4060 (x_destroy_window, x_delete_display):
4061 Now static.
4062 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4063 (x_mouse_leave): Remove; unused.
4064 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4065 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4066 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4067 Remove decls.
4068 (x_mouse_leave): Declare only if WINDOWSNT.
4069 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4070 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4071 USE_X_TOOLKIT.
4072
4073 * ftxfont.c: Make symbols static if they're not exported.
4074 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4075 HAVE_FREETYPE.
4076 * font.h (ftxfont_driver): Likewise.
4077
4078 * xfns.c: Make symbols static if they're not exported.
4079 (x_last_font_name, x_display_info_for_name):
4080 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4081 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4082 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4083 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4084 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4085 (last_show_tip_args): Now static.
4086 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4087 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4088 (x_screen_planes): Remove; unused.
4089 * dispextern.h (x_screen_planes): Remove decl.
4090
4091 * dispnew.c: Make symbols static if they're not exported.
4092 * dispextern.h (redraw_garbaged_frames, scrolling):
4093 (increment_row_positions): Remove.
4094 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4095 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4096 Now static.
4097 (redraw_garbaged_frames): Remove; unused.
4098
4099 * xfaces.c: Make symbols static if they're not exported.
4100 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4101 Remove decls.
4102 * xterm.h (defined_color): Remove decls.
4103 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4104 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4105 (menu_face_changed_default, defined_color, free_realized_face):
4106 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4107 (ascii_face_of_lisp_face): Remove; unused.
4108
4109 * xdisp.c: Make symbols static if they're not exported.
4110 * dispextern.h (scratch_glyph_row, window_box_edges):
4111 (glyph_to_pixel_coords, set_cursor_from_row):
4112 (get_next_display_element, set_iterator_to_next):
4113 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4114 (show_mouse_face): Remove decls
4115 * frame.h (message_buf_print): Likewise.
4116 * lisp.h (pop_message, set_message, check_point_in_composition):
4117 Likewise.
4118 * xterm.h (set_vertical_scroll_bar): Likewise.
4119 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4120 (message_buf_print, scratch_glyph_row, displayed_buffer):
4121 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4122 (get_next_display_element, show_mouse_face, window_box_edges):
4123 (frame_to_window_pixel_xy, check_point_in_composition):
4124 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4125 (glyph_to_pixel_coords): Remove; unused.
4126
4127 * dired.c (file_name_completion): Now static.
4128
4129 * dbusbind.c (xd_in_read_queued_messages): Now static.
4130
4131 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4132 * data.c (circular_list_error): Remove.
4133
4134 * commands.h (last_point_position, last_point_position_buffer):
4135 (last_point_position_window): Remove decls.
4136 * keyboard.c: Make these variables static.
4137
4138 * coding.h (coding, code_convert_region, encode_coding_gap):
4139 Remove decls.
4140 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4141 (iso_code_class, detect_coding, code_convert_region): Now static.
4142 (encode_coding_gap): Remove; unused.
4143
4144 * chartab.c (chartab_chars, chartab_bits): Now static.
4145
4146 * charset.h (charset_iso_8859_1): Remove decl.
4147 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4148 Now static.
4149
4150 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4151 * ccl.c (Vccl_program_table): Now static.
4152 (check_ccl_update): Remove; unused.
4153
4154 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4155 * category.h: ... from here.
4156 * category.c (check_category_table, set_category_set): Now static.
4157
4158 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4159 * lisp.h: Remove these decls.
4160
4161 * buffer.c (buffer_count): Remove unused var.
4162
4163 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4164 so that it's not optimized away.
4165 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4166 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4167 exported only to the debugger.
4168
4169 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4170 * atimer.h (run_all_atimers): Remove; not exported.
4171
4172 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4173 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4174 was inaccessible from Lisp.
4175 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4176 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4177
4178 alloc.c: Import and export fewer symbols, and remove unused items.
4179 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4180 is defined.
4181 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4182 it's not optimized away by whole-program optimization.
4183 (message_enable_multibyte, free_misc): Remove.
4184 (catchlist, handlerlist, mark_backtrace):
4185 Declare only if BYTE_MARK_STACK.
4186 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4187 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4188 (message_enable_multibyte): Remove decl.
4189 (free_misc, interval_free_list, float_block, float_block_index):
4190 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4191 (cons_free_list, last_marked_index):
4192 Now static.
4193 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4194 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4195 (mark_backtrace): Define only if BYTE_MARK_STACK.
4196 * xdisp.c (message_enable_multibyte): Now static.
4197
4198 Declare Lisp_Object Q* variables to be 'static' if not exported.
4199 This makes it easier for human readers (and static analyzers)
4200 to see whether these variables are used from other modules.
4201 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4202 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4203 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4204 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4205 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4206 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4207 * xmenu.c, xselect.c:
4208 Declare Q* vars static if they are not used in other modules.
4209 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4210 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4211 Remove decls of unexported vars.
4212 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4213
4214 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4215
4216 Make Emacs functions such as Fatom 'static' by default.
4217 This makes it easier for human readers (and static analyzers)
4218 to see whether these functions can be called from other modules.
4219 DEFUN now defines a static function. To make the function external
4220 so that it can be used in other C modules, use the new macro DEFUE.
4221 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4222 (Finit_image_library):
4223 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4224 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4225 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4226 Remove decls, since these functions are now static.
4227 (Funintern, Fget_internal_run_time): New decls, since these functions
4228 were already external.
4229
4230 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4231 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4232 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4233 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4234 * keyboard.c, keymap.c, lread.c:
4235 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4236 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4237 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4238 Mark functions with DEFUE instead of DEFUN,
4239 if they are used in other modules.
4240 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4241 decls for now-static functions.
4242 * buffer.h (Fdelete_overlay): Remove decl.
4243 * callproc.c (Fgetenv_internal): Mark as internal.
4244 * composite.c (Fremove_list_of_text_properties): Remove decl.
4245 (Fcomposition_get_gstring): New forward static decl.
4246 * composite.h (Fcomposite_get_gstring): Remove decl.
4247 * dired.c (Ffile_attributes): New forward static decl.
4248 * doc.c (Fdocumntation_property): New forward static decl.
4249 * eval.c (Ffetch_bytecode): New forward static decl.
4250 (Funintern): Remove extern decl; now in .h file where it belongs.
4251 * fileio.c (Fmake_symbolic_link): New forward static decl.
4252 * image.c (Finit_image_library): New forward static decl.
4253 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4254 * intervals.h (Fprevious_property_change):
4255 (Fremove_list_of_text_properties): Remove decls.
4256 * keyboard.c (Fthis_command_keys): Remove decl.
4257 (Fcommand_execute): New forward static decl.
4258 * keymap.c (Flookup_key): New forward static decl.
4259 (Fcopy_keymap): Now static.
4260 * keymap.h (Flookup_key): Remove decl.
4261 * process.c (Fget_process): New forward static decl.
4262 (Fprocess_datagram_address): Mark as internal.
4263 * syntax.c (Fsyntax_table_p): New forward static decl.
4264 (skip_chars): Remove duplicate decl.
4265 * textprop.c (Fprevious_property_change): New forward static decl.
4266 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4267 Now internal.
4268 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4269 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4270
4271 * editfns.c (Fformat): Remove unreachable code.
4272
4273 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4274
4275 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4276 change. (Bug#8496)
4277
4278 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4279
4280 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4281 when at ZV. (Bug#8487)
4282
4283 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4284
4285 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4286 (Bug#8437)
4287 * keyboard.c (parse_tool_bar_item): Likewise.
4288 * sound.c (sound_cleanup, alsa_close): Likewise.
4289 * termcap.c (tgetent): Likewise.
4290 * xfns.c (x_default_font_parameter): Likewise.
4291 * xsettings.c (read_and_apply_settings): Likewise.
4292
4293 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4294 (overrun_check_free): Protoize.
4295
4296 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4297
4298 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4299 since callers should never pass a negative size.
4300 Change the signature to match that of plain 'read' and 'write'; see
4301 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4302 * lisp.h: Update prototypes of emacs_write and emacs_read.
4303
4304 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4305
4306 * xdisp.c (redisplay_window): Don't try to determine the character
4307 position of the scroll margin if the window start point w->startp
4308 is outside the buffer's accessible region. (Bug#8468)
4309
4310 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4311
4312 Fix write-region and its subroutines for buffers > 2GB.
4313 * fileio.c (a_write, e_write): Modify declaration of arguments and
4314 local variables to support buffers larger than 2GB.
4315 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4316
4317 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4318 argument, local variables, and return value.
4319
4320 * lisp.h: Update prototypes of emacs_write and emacs_read.
4321
4322 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4323
4324 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4325
4326 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4327
4328 Fix more problems found by GCC 4.6.0's static checks.
4329
4330 * xdisp.c (vmessage): Use a better test for character truncation.
4331
4332 * charset.c (load_charset_map): <, not <=, for optimization,
4333 and to avoid potential problems with integer overflow.
4334 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4335 * casetab.c (set_identity, shuffle): Likewise.
4336 * editfns.c (Fformat): Likewise.
4337 * syntax.c (skip_chars): Likewise.
4338
4339 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4340 This also lets GCC 4.6.0 generate slightly better loop code.
4341
4342 * callint.c (Fcall_interactively): <, not <=, for optimization.
4343 (Fcall_interactively): Count the number of arguments produced,
4344 not the number of arguments given. This is simpler and lets GCC
4345 4.6.0 generate slightly better code.
4346
4347 * ftfont.c: Distingish more carefully between FcChar8 and char.
4348 The previous code passed unsigned char * to a functions like
4349 strlen and xstrcasecmp that expect char *, which does not
4350 conform to the C standard.
4351 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4352 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4353 char * when the C standard requires it.
4354
4355 * keyboard.c (read_char): Remove unused var.
4356
4357 * eval.c: Port to Windows vsnprintf (Bug#8435).
4358 Include <limits.h>.
4359 (SIZE_MAX): Define if the headers do not.
4360 (verror): Do not give up if vsnprintf returns a negative count.
4361 Instead, grow the buffer. This ports to Windows vsnprintf, which
4362 does not conform to C99. Problem reported by Eli Zaretskii.
4363 Also, simplify the allocation scheme, by avoiding the need for
4364 calling realloc, and removing the ALLOCATED variable.
4365
4366 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4367
4368 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4369 But keep the doprint source code for now, as we might revamp it
4370 and use it again (Bug#8435).
4371 * lisp.h (doprnt): Remove.
4372 * Makefile.in (base_obj): Remove doprnt.o.
4373 * deps.mk (doprnt.o): Remove.
4374
4375 error: Print 32- and 64-bit integers portably (Bug#8435).
4376 Without this change, on typical 64-bit hosts error ("...%d...", N)
4377 was used to print both 32- and 64-bit integers N, which relied on
4378 undefined behavior.
4379 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4380 New macro.
4381 * lisp.h (error, verror): Mark as printf-like functions.
4382 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4383 Report overflow in size calculations when allocating printf buffer.
4384 Do not truncate output string at its first null byte.
4385 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4386 Truncate the output at a character boundary, since vsnprintf does not
4387 do that.
4388 * charset.c (check_iso_charset_parameter): Convert internal
4389 character to string before calling 'error', since %c now has the
4390 printf meaning.
4391 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4392 overflow when computing char to be passed to 'error'. Do not
4393 pass Lisp_Object to 'error'; pass the integer instead.
4394 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4395 formatted with plain %d.
4396
4397 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4398
4399 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4400
4401 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4402
4403 * xterm.c (x_catch_errors): Remove duplicate declaration.
4404
4405 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4406
4407 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4408
4409 2011-04-10 Jim Meyering <meyering@redhat.com>
4410
4411 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4412 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4413 return ssize_t not "int", and use size_t as the buffer length.
4414 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4415 * gnutls.h: Update declarations.
4416 * process.c (read_process_output): Use ssize_t, to match.
4417 (send_process): Likewise.
4418
4419 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4420
4421 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4422
4423 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4424
4425 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4426 Use unsigned char, to match FcChar8 type definition.
4427
4428 * xterm.c (handle_one_xevent):
4429 * xmenu.c (create_and_show_popup_menu):
4430 * xselect.c (x_decline_selection_request)
4431 (x_reply_selection_request): Avoid type-punned deref of X events.
4432
4433 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4434
4435 Fix some uses of `int' instead of EMACS_INT.
4436 * search.c (string_match_1, fast_string_match)
4437 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4438 (scan_buffer, find_next_newline_no_quit)
4439 (find_before_next_newline, search_command, Freplace_match)
4440 (Fmatch_data): Make some `int' variables be EMACS_INT.
4441
4442 * xdisp.c (display_count_lines): 3rd argument and return value now
4443 EMACS_INT. All callers changed.
4444 (pint2hrstr): Last argument is now EMACS_INT.
4445
4446 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4447 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4448 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4449 (decode_coding_utf_16, decode_coding_emacs_mule)
4450 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4451 (decode_coding_ccl, decode_coding_charset)
4452 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4453 (decode_coding_iso_2022, decode_coding_emacs_mule)
4454 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4455 <char_offset, last_offset>: Declare EMACS_INT.
4456 (encode_coding_utf_8, encode_coding_utf_16)
4457 (encode_coding_emacs_mule, encode_invocation_designation)
4458 (encode_designation_at_bol, encode_coding_iso_2022)
4459 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4460 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4461 Declare EMACS_INT.
4462 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4463 (encode_invocation_designation): Last argument P_NCHARS is now
4464 EMACS_INT.
4465 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4466 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4467
4468 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4469 All users changed.
4470
4471 * ccl.c (Fccl_execute_on_string): Declare some variables
4472 EMACS_INT.
4473
4474 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4475
4476 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4477
4478 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4479
4480 * process.c (Fformat_network_address): Doc fix.
4481
4482 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4483
4484 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4485
4486 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4487
4488 * keyboard.c (read_char): Call Lisp function help-form-show,
4489 instead of using internal_with_output_to_temp_buffer.
4490 (Qhelp_form_show): New var.
4491 (syms_of_keyboard): Use DEFSYM macro.
4492
4493 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4494
4495 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4496
4497 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4498
4499 * process.c (Flist_processes): Remove to Lisp.
4500 (list_processes_1): Delete.
4501
4502 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4503
4504 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4505
4506 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4507
4508 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4509
4510 Fix more problems found by GCC 4.6.0's static checks.
4511
4512 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4513
4514 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4515
4516 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4517
4518 * xdisp.c (vmessage): Mark as a printf-like function.
4519
4520 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4521
4522 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4523
4524 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4525 printf-like functions.
4526 (tiff_load): Add casts to remove these marks before passing them
4527 to system-supplied API.
4528
4529 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4530
4531 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4532 This avoids several warnings with gcc -Wstrict-overflow.
4533 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4534 directly, rather than having caller test rule sign. This avoids
4535 some unnecessary tests.
4536 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4537 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4538 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4539
4540 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4541 (xfont_open): Avoid unnecessary tests.
4542
4543 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4544
4545 * composite.h, composite.c (composition_gstring_put_cache):
4546 Use EMACS_INT, not int, for length.
4547
4548 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4549 breaking out part of COMPOSITION_DECODE_RULE.
4550 (COMPOSITION_DECODE_RULE): Use it.
4551 * composite.c (get_composition_id): Remove unused local vars,
4552 by using the new macro.
4553
4554 * textprop.c (set_text_properties_1): Change while to do-while,
4555 since the condition is always true at first.
4556
4557 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4558 (interval_deletion_adjustment): Return unsigned value.
4559 All uses changed.
4560
4561 * process.c (list_processes_1, create_pty, read_process_output):
4562 (exec_sentinel): Remove vars that were set but not used.
4563 (create_pty): Remove unnecessary "volatile"s.
4564 (Fnetwork_interface_info): Avoid possibility of int overflow.
4565 (read_process_output): Do adaptive read buffering even if carryover.
4566 (read_process_output): Simplify nbytes computation if buffered.
4567
4568 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4569
4570 * syntax.c (scan_words): Remove var that was set but not used.
4571 (update_syntax_table): Use unsigned instead of int.
4572
4573 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4574 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4575 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4576
4577 * print.c (print_error_message): Avoid int overflow.
4578
4579 * font.c (font_list_entities): Redo for clarity,
4580 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4581
4582 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4583 (font_score): Avoid potential overflow in diff calculation.
4584
4585 * fns.c (substring_both): Remove var that is set but not used.
4586 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4587
4588 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4589
4590 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4591 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4592 can always succeed if overflow has undefined behavior.
4593
4594 * search.c (boyer_moore, wordify): Remove vars set but not used.
4595 (wordify): Omit three unnecessary tests.
4596
4597 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4598 All callers changed. This avoids the need for an unused var.
4599
4600 * casefiddle.c (casify_region): Remove var that is set but not used.
4601
4602 * dired.c (file_name_completion): Remove var that is set but not used.
4603
4604 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4605
4606 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4607 (Finsert_file_contents): Remove unnecessary code checking fd.
4608
4609 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4610 Check for integer overflow on size calculations.
4611
4612 * buffer.c (Fprevious_overlay_change): Remove var that is set
4613 but not used.
4614
4615 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4616 Remove vars that are set but not used.
4617 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4618 (timer_check_2): Mark vars as initialized.
4619
4620 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4621
4622 * image.c (lookup_image): Remove var that is set but not used.
4623 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4624
4625 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4626 that are set but not used.
4627
4628 * xfns.c (make_invisible_cursor): Don't return garbage
4629 if XCreateBitmapFromData fails (Bug#8410).
4630
4631 * xselect.c (x_get_local_selection, x_handle_property_notify):
4632 Remove vars that are set but not used.
4633
4634 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4635 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4636
4637 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4638 Remove var that is set but not used.
4639 (scroll_bar_windows_size): Now size_t, not int.
4640 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4641 Check for overflow.
4642
4643 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4644 (map_tty_color) [!defined MSDOS]: Likewise.
4645
4646 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4647
4648 * coding.c: Remove vars that are set but not used.
4649 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4650 All callers changed.
4651 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4652 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4653 (decode_coding_charset): Remove vars that are set but not used.
4654
4655 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4656 that is set but not used.
4657
4658 * print.c (print_object): Remove var that is set but not used.
4659
4660 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4661 The gnulib version avoids calling malloc in the usual case,
4662 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4663 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4664 * filelock.c (current_lock_owner): Likewise.
4665 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4666 * sysdep.c: Include allocator.h, careadlinkat.h.
4667 (emacs_no_realloc_allocator): New static constant.
4668 (emacs_readlink): New function.
4669 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4670 ../lib/careadlinkat.h.
4671
4672 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4673
4674 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4675 first non-nil return value).
4676
4677 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4678
4679 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4680 if not defined (Bug#8403).
4681
4682 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4683
4684 * xdisp.c (display_count_lines): Remove parameter `start',
4685 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4686 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4687 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4688 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4689 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4690 and thereabouts. All callers changed.
4691 (get_per_char_metric): Remove parameter `f', unused since
4692 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4693
4694 2011-04-02 Jim Meyering <meyering@redhat.com>
4695
4696 do not dereference NULL upon failed strdup
4697 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4698 (ns_get_family): Likewise.
4699
4700 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4701
4702 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4703
4704 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4705
4706 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4707 later (Bug#8403).
4708
4709 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4710
4711 Add lexical binding.
4712
4713 * window.c (Ftemp_output_buffer_show): New fun.
4714 (Fsave_window_excursion):
4715 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4716
4717 * lread.c (lisp_file_lexically_bound_p): New function.
4718 (Fload): Bind Qlexical_binding.
4719 (readevalloop): Remove `evalfun' arg.
4720 Bind Qinternal_interpreter_environment.
4721 (Feval_buffer): Bind Qlexical_binding.
4722 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4723 Mark as dynamic.
4724 (syms_of_lread): Declare `lexical-binding'.
4725
4726 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4727
4728 * keyboard.c (eval_dyn): New fun.
4729 (menu_item_eval_property): Use it.
4730
4731 * image.c (parse_image_spec): Use Ffunctionp.
4732
4733 * fns.c (concat, mapcar1): Accept byte-code-functions.
4734
4735 * eval.c (Fsetq): Handle lexical vars.
4736 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4737 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4738 (FletX, Flet): Obey lexical binding.
4739 (Fcommandp): Handle closures.
4740 (Feval): New `lexical' arg.
4741 (eval_sub): New function extracted from Feval. Use it almost
4742 everywhere where Feval was used. Look up vars in lexical env.
4743 Handle closures.
4744 (Ffunctionp): Move from subr.el.
4745 (Ffuncall): Handle closures.
4746 (apply_lambda): Remove `eval_flags'.
4747 (funcall_lambda): Handle closures and new byte-code-functions.
4748 (Fspecial_variable_p): New function.
4749 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4750 but without exporting it to Lisp.
4751
4752 * doc.c (Fdocumentation, store_function_docstring):
4753 * data.c (Finteractive_form): Handle closures.
4754
4755 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4756 interactive spec.
4757
4758 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4759 New byte-codes.
4760 (exec_byte_code): New function extracted from Fbyte_code to handle new
4761 calling convention for byte-code-functions. Add new byte-codes.
4762
4763 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4764
4765 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4766
4767 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4768
4769 * xdisp.c (redisplay_internal): Fix prototype.
4770
4771 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4772
4773 * xdisp.c (SCROLL_LIMIT): New macro.
4774 (try_scrolling): Use it when setting scroll_limit.
4775 Limit scrolling to 100 screen lines.
4776 (redisplay_window): Even when falling back on "recentering",
4777 position point in the window according to scroll-conservatively,
4778 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4779
4780 (try_scrolling): When point is above the window, allow searching
4781 as far as scroll_max, or one screenful, to compute vertical
4782 distance from PT to the scroll margin position. This prevents
4783 try_scrolling from unnecessarily failing when
4784 scroll-conservatively is set to a value slightly larger than the
4785 window height. Clean up the case of PT below the margin at bottom
4786 of window: scroll_max can no longer be INT_MAX. When aggressive
4787 scrolling is in use, don't let point enter the opposite scroll
4788 margin as result of the scroll.
4789 (syms_of_xdisp) <scroll-conservatively>: Document the
4790 threshold of 100 lines for never-recentering scrolling.
4791
4792 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4793
4794 * dispextern.h (move_it_by_lines):
4795 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4796 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4797 (message_log_check_duplicate): Remove parameters `prev_bol' and
4798 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4799 (redisplay_internal): Remove parameter `preserve_echo_area',
4800 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4801
4802 * indent.c (Fvertical_motion):
4803 * window.c (window_scroll_pixel_based, Frecenter):
4804 Don't pass `need_y_p' to `move_it_by_lines'.
4805
4806 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4807
4808 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4809 steal a few bits to be more compact.
4810 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4811 Remove unneeded casts.
4812
4813 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4814
4815 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4816
4817 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4818 binding" message (bug#7967).
4819
4820 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4821
4822 Fix more problems found by GCC 4.6.0's static checks.
4823
4824 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4825 Remove unused local var.
4826
4827 * editfns.c (Fmessage_box): Remove unused local var.
4828
4829 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4830 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4831 Omit unused local vars.
4832 * window.c (shrink_windows): Omit unused local var.
4833 * menu.c (digest_single_submenu): Omit unused local var.
4834 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4835 Omit unused local var.
4836
4837 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4838 Don't assume string length fits in int.
4839 (keyremap_step, read_key_sequence): Use size_t for sizes.
4840 (read_key_sequence): Don't check last_real_key_start redundantly.
4841
4842 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4843 instead of alloca (Bug#8344).
4844
4845 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4846 (Fbacktrace_frame): Don't assume nframes fits in int.
4847
4848 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4849
4850 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4851 concerns.
4852
4853 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4854
4855 * cm.c (calccost): Turn while-do into do-while, for clarity.
4856
4857 * keyboard.c (syms_of_keyboard): Use the same style as later
4858 in this function when indexing through an array. This also
4859 works around GCC bug 48267.
4860
4861 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4862
4863 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4864
4865 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4866 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4867
4868 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4869 This avoids undefined behavior on integer overflow, and is a bit
4870 more convenient anyway since it is compared to a size_t variable.
4871
4872 Variadic C functions now count arguments with size_t, not int.
4873 This avoids an unnecessary limitation on 64-bit machines, which
4874 caused (substring ...) to crash on large vectors (Bug#8344).
4875 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4876 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4877 All variadic functions and their callers changed accordingly.
4878 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4879 * data.c (arith_driver, float_arith_driver): Likewise.
4880 * editfns.c (general_insert_function): Likewise.
4881 * eval.c (struct backtrace.nargs, interactive_p)
4882 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4883 (funcall_lambda, mark_backtrace): Likewise.
4884 * fns.c (concat): Likewise.
4885 * frame.c (x_set_frame_parameters): Likewise.
4886 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4887 0 if not found, not -1. All callers changed.
4888
4889 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4890 (stack_copy_size): Now size_t, not int.
4891 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4892
4893 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4894
4895 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4896 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4897 All callers changed.
4898
4899 * lisp.h (multibyte_char_to_unibyte):
4900 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4901 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4902 * character.h (CHAR_TO_BYTE8):
4903 * cmds.c (internal_self_insert):
4904 * editfns.c (general_insert_function):
4905 * keymap.c (push_key_description):
4906 * search.c (Freplace_match):
4907 * xdisp.c (message_dolog, set_message_1): All callers changed.
4908
4909 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4910
4911 * keyboard.c (safe_run_hook_funcall): New function.
4912 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4913 don't set the hook to nil, but remove the offending function instead.
4914 (Qcommand_hook_internal): Remove, unused.
4915 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4916 Vcommand_hook_internal.
4917
4918 * eval.c (enum run_hooks_condition): Remove.
4919 (funcall_nil, funcall_not): New functions.
4920 (run_hook_with_args): Call each function through a `funcall' argument.
4921 Remove `cond' argument, now redundant.
4922 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4923 (Frun_hook_with_args_until_failure): Adjust accordingly.
4924 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4925
4926 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4927
4928 * dispextern.h (string_buffer_position): Remove declaration.
4929
4930 * print.c (strout): Remove parameter `multibyte', unused since
4931 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4932
4933 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4934 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4935 All callers changed.
4936
4937 * w32.c (_wsa_errlist): Use braces for struct initializers.
4938
4939 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4940 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4941 All callers changed.
4942 (string_buffer_position): Likewise. Also, make static (it's never
4943 used outside xdisp.c).
4944 (cursor_row_p): Remove parameter `w', unused since
4945 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4946 (decode_mode_spec): Remove parameter `precision', introduced during
4947 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4948 All callers changed.
4949
4950 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4951
4952 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4953
4954 2011-03-27 Anders Lindgren <andlind@gmail.com>
4955
4956 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4957 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4958 (ns_update_auto_hide_menu_bar): New functions.
4959 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4960 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4961 ns_constrain_all_frames.
4962 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4963 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4964
4965 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4966
4967 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4968
4969 2011-03-27 Glenn Morris <rgm@gnu.org>
4970
4971 * syssignal.h: Replace RETSIGTYPE with void.
4972 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4973 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4974 Replace SIGTYPE with void everywhere.
4975 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4976 * s/template.h (SIGTYPE): Remove commented out definition.
4977
4978 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4979
4980 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4981 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4982
4983 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4984
4985 * w32.c (read_unc_volume): Use parameter `henum', instead of
4986 global variable `wget_enum_handle'.
4987
4988 * keymap.c (describe_vector): Remove parameters `indices' and
4989 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4990 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4991
4992 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4993
4994 * keyboard.c (timer_check): Remove parameter `do_it_now',
4995 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4996 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4997 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4998
4999 * keyboard.c (read_char):
5000 * w32menu.c (w32_menu_display_help):
5001 * xmenu.c (show_help_event, menu_help_callback):
5002 Adjust calls to `show_help_echo'.
5003
5004 * gtkutil.c (xg_maybe_add_timer):
5005 * keyboard.c (readable_events):
5006 * process.c (wait_reading_process_output):
5007 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5008
5009 * insdel.c (adjust_markers_gap_motion):
5010 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5011 (gap_left, gap_right): Don't call it.
5012
5013 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5014
5015 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5016 incurred during fontification.
5017
5018 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5019
5020 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5021 (DEFVAR_PER_BUFFER): Don't pass it.
5022
5023 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5024 (scrolling_window): Don't pass it.
5025
5026 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5027
5028 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5029
5030 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5031 and `suffix'.
5032 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5033 of variables specific to SELinux and computation of `encoded_absname'.
5034
5035 * image.c (XPutPixel): Remove unused variable `height'.
5036
5037 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5038
5039 * unexw32.c (get_section_info): Remove unused variable `section'.
5040
5041 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5042 (system_process_attributes): Remove unused variable `sess'.
5043 (sys_read): Remove unused variable `err'.
5044
5045 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5046 (w32_wnd_proc): Remove unused variable `isdead'.
5047 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5048 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5049 (x_create_tip_frame): Remove unused variable `tem'.
5050
5051 * w32inevt.c (w32_console_read_socket):
5052 Remove unused variable `no_events'.
5053
5054 * w32term.c (x_draw_composite_glyph_string_foreground):
5055 Remove unused variable `width'.
5056
5057 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5058
5059 * w32term.c (x_set_glyph_string_clipping):
5060 Don't pass uninitialized region to CombineRgn.
5061
5062 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5063
5064 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5065 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5066 (Fx_close_connection): Remove unused variable `i'.
5067
5068 * w32font.c (w32font_draw): Return number of glyphs.
5069 (w32font_open_internal): Remove unused variable `i'.
5070 (w32font_driver): Add missing initializer.
5071
5072 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5073 (fill_in_menu): Remove unused variable `items_added'.
5074
5075 * w32term.c (last_mouse_press_frame): Remove static global variable.
5076 (w32_clip_to_row): Remove unused variable `f'.
5077 (x_delete_terminal): Remove unused variable `i'.
5078
5079 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5080 (NOTHING): Remove unused static global variable.
5081 (uniscribe_check_otf): Remove unused variable `table'.
5082 (uniscribe_font_driver): Add missing initializers.
5083
5084 2011-03-23 Julien Danjou <julien@danjou.info>
5085
5086 * term.c (Fsuspend_tty, Fresume_tty):
5087 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5088 * window.c (temp_output_buffer_show):
5089 * insdel.c (signal_before_change):
5090 * frame.c (Fhandle_switch_frame):
5091 * fileio.c (Fdo_auto_save):
5092 * emacs.c (Fkill_emacs):
5093 * editfns.c (save_excursion_restore):
5094 * cmds.c (internal_self_insert):
5095 * callint.c (Fcall_interactively):
5096 * buffer.c (Fkill_all_local_variables):
5097 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5098 Use Frun_hooks.
5099 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5100 unconditionnaly since it does the check itself.
5101
5102 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5103
5104 Fix more problems found by GCC 4.5.2's static checks.
5105
5106 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5107 the first time through the loop, since we know p0 < p1 then.
5108 This also avoids a gcc -Wstrict-overflow warning.
5109
5110 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5111 leading to a memory leak, possible in functions like
5112 load_charset_map_from_file that can allocate an unbounded number
5113 of objects (Bug#8318).
5114
5115 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5116 that could (at least in theory) be that large.
5117
5118 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5119 This is less likely to overflow, and avoids undefined behavior if
5120 overflow does occur. All callers changed. Use strtoul to scan
5121 for the unsigned long integer.
5122 (pint2hrstr): Simplify and tune code slightly.
5123 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5124
5125 * scroll.c (do_scrolling): Work around GCC bug 48228.
5126 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5127
5128 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5129 This also avoids a warning with gcc -Wstrict-overflow.
5130 (validate_x_resource_name): Simplify count usage.
5131 This also avoids a warning with gcc -Wstrict-overflow.
5132
5133 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5134 fail (Bug#8306).
5135
5136 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5137
5138 * process.c (Fmake_network_process): Use socklen_t, not int,
5139 where POSIX says socklen_t is required in portable programs.
5140 This fixes a porting bug on hosts like 64-bit HP-UX, where
5141 socklen_t is wider than int (Bug#8277).
5142 (Fmake_network_process, server_accept_connection):
5143 (wait_reading_process_output, read_process_output):
5144 Likewise.
5145
5146 * process.c: Rename or move locals to avoid shadowing.
5147 (list_processes_1, Fmake_network_process):
5148 (read_process_output_error_handler, exec_sentinel_error_handler):
5149 Rename or move locals.
5150 (Fmake_network_process): Define label "retry_connect" only if needed.
5151 (Fnetwork_interface_info): Fix pointer signedness.
5152 (process_send_signal): Add cast to avoid pointer signedness problem.
5153 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5154 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5155
5156 Make tparam.h and terminfo.c consistent.
5157 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5158 Include tparam.h instead, since it declares them.
5159 * cm.h (PC): Remove extern decl; tparam.h now does this.
5160 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5161 * terminfo.c: Include tparam.h, to check interfaces.
5162 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5163 (tparam): Adjust signature to match interface in tparam.h;
5164 this removes some undefined behavior. Check that outstring and len
5165 are zero, which they always are with Emacs.
5166 * tparam.h (PC, BC, UP): New extern decls.
5167
5168 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5169 (xftfont_open): Rename locals to avoid shadowing.
5170
5171 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5172 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5173 (OTF_TAG_SYM): Omit macro if not needed.
5174 (ftfont_list): Remove unused local.
5175 (get_adstyle_property, ftfont_pattern_entity):
5176 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5177 Rename locals to avoid shadowing.
5178
5179 * xfont.c (xfont_list_family): Mark var as initialized.
5180
5181 * xml.c (make_dom): Now static.
5182
5183 * composite.c (composition_compute_stop_pos): Rename local to
5184 avoid shadowing.
5185 (composition_reseat_it): Remove unused locals.
5186 (find_automatic_composition, composition_adjust_point): Likewise.
5187 (composition_update_it): Mark var as initialized.
5188 (find_automatic_composition): Mark vars as initialized,
5189 with a FIXME (Bug#8290).
5190
5191 character.h: Rename locals to avoid shadowing.
5192 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5193 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5194 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5195 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5196 to avoid shadowing.
5197
5198 * textprop.c (property_change_between_p): Remove; unused.
5199
5200 * intervals.c (interval_start_pos): Now static.
5201
5202 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5203
5204 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5205 Rename locals to avoid shadowing.
5206
5207 * sound.c (wav_play, au_play, Fplay_sound_internal):
5208 Fix pointer signedness.
5209 (alsa_choose_format): Remove unused local var.
5210 (wav_play): Initialize a variable to 0, to prevent undefined
5211 behavior (Bug#8278).
5212
5213 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5214
5215 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5216
5217 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5218 clobbering (Bug#8298).
5219 * sysdep.c (sys_subshell): Likewise.
5220 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5221
5222 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5223 This should get cleaned up, so that child_setup has the
5224 same signature on all platforms.
5225
5226 * callproc.c (call_process_cleanup): Now static.
5227 (relocate_fd): Rename locals to avoid shadowing.
5228
5229 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5230
5231 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5232 not to be necessary, and produces flickering.
5233
5234 2011-03-20 Glenn Morris <rgm@gnu.org>
5235
5236 * config.in: Remove file.
5237
5238 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5239
5240 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5241 are now in src/globals.h.
5242 (syms_of_minibuf): Remove spurious & from previous change.
5243
5244 2011-03-20 Leo <sdl.web@gmail.com>
5245
5246 * minibuf.c (completing-read-function): New variable.
5247 (completing-read-default): Rename from completing-read.
5248 (completing-read): Call completing-read-function.
5249
5250 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5251
5252 * xfaces.c (Fx_load_color_file):
5253 Read color file from absolute filename (bug#8250).
5254
5255 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5256
5257 * makefile.w32-in: Update dependencies.
5258
5259 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5260
5261 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5262
5263 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5264
5265 Fix more problems found by GCC 4.5.2's static checks.
5266
5267 * process.c (make_serial_process_unwind, send_process_trap):
5268 (sigchld_handler): Now static.
5269
5270 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5271 That way, the code declares only the vars that it needs.
5272 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5273 * s/cygwin.h (PTY_ITERATION): Likewise.
5274 * s/darwin.h (PTY_ITERATION): Likewise.
5275 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5276
5277 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5278 * process.c (allocate_pty): Don't declare stb unless it's needed.
5279
5280 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5281 (CONSTANTLIM): Remove; unused.
5282 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5283 Define only if needed.
5284
5285 * unexelf.c (unexec): Name an expression,
5286 to avoid gcc -Wbad-function-cast warning.
5287 Use a different way to cause a compilation error if anyone uses
5288 n rather than nn, a way that does not involve shadowing.
5289 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5290
5291 * deps.mk (unexalpha.o): Remove; unused.
5292
5293 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5294 * unexec.h: New file.
5295 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5296 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5297 Depend on unexec.h.
5298 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5299 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5300 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5301 Change as necessary to match prototype in unexec.h.
5302
5303 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5304 shadowing.
5305 (back_comment, skip_chars): Mark vars as initialized.
5306
5307 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5308 Rename locals to avoid shadowing.
5309
5310 * lread.c (read1): Rewrite so as not to use empty "else".
5311 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5312
5313 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5314
5315 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5316 warning when compiling print.c.
5317
5318 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5319 instead of using an uninitialized var.
5320 (font_sort_entities): Mark var as initialized.
5321
5322 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5323
5324 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5325 pointers to constants.
5326 (font_parse_fcname): Remove unused vars.
5327 (font_delete_unmatched): Now static.
5328 (font_get_spec): Remove; unused.
5329 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5330 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5331 Rename or move locals to avoid shadowing.
5332
5333 * fns.c (require_nesting_list, require_unwind): Now static.
5334 (Ffillarray): Rename locals to avoid shadowing.
5335
5336 * floatfns.c (domain_error2): Define only if needed.
5337 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5338
5339 * alloc.c (mark_backtrace): Move decl from here ...
5340 * lisp.h: ... to here, so that it can be checked.
5341
5342 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5343 (Fdefvar): Rewrite so as not to use empty "else".
5344 (lisp_indirect_variable): Name an expression,
5345 to avoid gcc -Wbad-function-cast warning.
5346 (Fdefvar): Rename locals to avoid shadowing.
5347
5348 * callint.c (quotify_arg, quotify_args): Now static.
5349 (Fcall_interactively): Rename locals to avoid shadowing.
5350 Use const pointer when appropriate.
5351
5352 * lisp.h (get_system_name, get_operating_system_release):
5353 Move decls here, to check interfaces.
5354 * process.c (get_operating_system_release): Move decl to lisp.h.
5355 * xrdb.c (get_system_name): Likewise.
5356 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5357 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5358 some of which prompt warnings from gcc -Wbad-function-cast.
5359 (Fformat_time_string, Fencode_time, Finsert_char):
5360 (Ftranslate_region_internal, Fformat):
5361 Rename or remove local vars to avoid shadowing.
5362 (Ftranslate_region_internal): Mark var as initialized.
5363
5364 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5365 avoid shadowing.
5366
5367 * lisp.h (eassert): Check that the argument compiles, even if
5368 ENABLE_CHECKING is not defined.
5369
5370 * data.c (Findirect_variable): Name an expression, to avoid
5371 gcc -Wbad-function-cast warning.
5372 (default_value, arithcompare, arith_driver, arith_error): Now static.
5373 (store_symval_forwarding): Rename local to avoid shadowing.
5374 (Fmake_variable_buffer_local, Fmake_local_variable):
5375 Mark variables as initialized.
5376 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5377
5378 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5379 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5380 Rename locals to avoid shadowing.
5381 (mark_stack): Move local variables into the #ifdef region where
5382 they're used.
5383 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5384 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5385 needed otherwise.
5386 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5387 (GC_STRING_CHARS): Remove; not used.
5388 (Fmemory_limit): Cast sbrk's returned value to char *.
5389
5390 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5391 avoids undefined behavior in theory.
5392
5393 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5394
5395 Use functions, not macros, for up- and down-casing (Bug#8254).
5396 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5397 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5398 to use the following functions instead of these macros.
5399 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5400 EMACS_INT, since callers assume the returned value fits in int.
5401 (upcase1): Likewise, for UPCASE_TABLE.
5402 (uppercasep, lowercasep, upcase): New static inline functions.
5403 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5404 the race-condition problem in the old DOWNCASE.
5405
5406 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5407 Rename locals to avoid shadowing.
5408 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5409 (regex_compile, re_search_2, re_match_2_internal):
5410 Remove unused local vars.
5411 (FREE_VAR): Rewrite so as not to use empty "else",
5412 which gcc can warn about.
5413 (regex_compile, re_match_2_internal): Mark locals as initialized.
5414 (RETALLOC_IF): Define only if needed.
5415 (WORDCHAR_P): Likewise. This one is never needed, but is used
5416 only in a comment talking about a compiler bug, so put inside
5417 the #if 0 of that comment.
5418 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5419 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5420 Remove; unused.
5421
5422 * search.c (boyer_moore): Rename locals to avoid shadowing.
5423 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5424 (PREV_CHAR_BOUNDARY): Likewise.
5425
5426 * search.c (simple_search): Remove unused var.
5427
5428 * dired.c (compile_pattern): Move decl from here ...
5429 * lisp.h: ... to here, so that it can be checked.
5430 (struct re_registers): New forward decl.
5431
5432 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5433
5434 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5435 All uses changed.
5436 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5437 Rename locals to avoid shadowing.
5438 (Fvertical_motion): Mark locals as initialized.
5439
5440 * casefiddle.c (casify_object, casify_region): Now static.
5441 (casify_region): Mark local as initialized.
5442
5443 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5444
5445 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5446 New macros, so that the caller can use some names other than
5447 gcpro1, gcpro2, etc.
5448 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5449 of the new macros.
5450 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5451 argument, for consistency with GCPRO2_VAR, etc: it is now the
5452 prefix of the variable, not the variable itself. All uses
5453 changed.
5454 * dired.c (directory_files_internal, file_name_completion):
5455 Rename locals to avoid shadowing.
5456
5457 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5458 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5459 dired.c's scmp function, had undefined behavior.
5460 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5461 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5462 * buffer.h: ... to here, because these macros use current_buffer,
5463 and the new implementation with inline functions needs to have
5464 current_buffer in scope now, rather than later when the macros
5465 are used.
5466 (downcase, upcase1): New static inline functions.
5467 (DOWNCASE, UPCASE1): Reimplement using these functions.
5468 This avoids undefined behavior in expressions like
5469 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5470 from race conditions in accessing the global variables
5471 case_temp1 and case_temp2.
5472 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5473 * lisp.h (case_temp1, case_temp2): Remove their decls.
5474 * character.h (ASCII_CHAR_P): Move from here ...
5475 * lisp.h: ... to here, so that the inline functions mentioned
5476 above can use them.
5477
5478 * dired.c (directory_files_internal_unwind): Now static.
5479
5480 * fileio.c (file_name_as_directory, directory_file_name):
5481 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5482 Now static.
5483 (file_name_as_directory): Use const pointers when appropriate.
5484 (Fexpand_file_name): Likewise. In particular, newdir might
5485 point at constant storage, so make it a const pointer.
5486 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5487 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5488 signedness issues.
5489 (Fset_file_times, Finsert_file_contents, auto_save_error):
5490 Rename locals to avoid shadowing.
5491
5492 * minibuf.c (choose_minibuf_frame_1): Now static.
5493 (Ftry_completion, Fall_completions): Rename or remove locals
5494 to avoid shadowing.
5495
5496 * marker.c (bytepos_to_charpos): Remove; unused.
5497
5498 * lisp.h (verify_bytepos, count_markers): New decls,
5499 so that gcc does not warn that these functions aren't declared.
5500
5501 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5502 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5503 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5504 (copy_text): Remove unused local var.
5505
5506 * filelock.c (within_one_second): Now static.
5507 (lock_file_1): Rename local to avoid shadowing.
5508
5509 * buffer.c (fix_overlays_before): Mark locals as initialized.
5510 (fix_start_end_in_overlays): Likewise. This function should be
5511 simplified by using pointers-to-pointers, but that's a different
5512 matter.
5513 (switch_to_buffer_1): Now static.
5514 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5515 (report_overlay_modification): Rename locals to avoid shadowing.
5516
5517 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5518 Fix pointer signedness issue.
5519 (sys_subshell): Mark local as volatile if checking for lint,
5520 to suppress a gcc -Wclobbered warning that does not seem to be right.
5521 (MAXPATHLEN): Define only if needed.
5522
5523 * process.c (serial_open, serial_configure): Move decls from here ...
5524 * systty.h: ... to here, so that they can be checked.
5525
5526 * fns.c (get_random, seed_random): Move extern decls from here ...
5527 * lisp.h: ... to here, so that they can be checked.
5528
5529 * sysdep.c (reset_io): Now static.
5530 (wait_for_termination_signal): Remove; unused.
5531
5532 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5533 (copy_keymap_item, append_key, push_text_char_description):
5534 Now static.
5535 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5536 (DENSE_TABLE_SIZE): Remove; unused.
5537 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5538 (describe_map_tree):
5539 Rename locals to avoid shadowing.
5540
5541 * keyboard.c: Declare functions static if they are not used elsewhere.
5542 (echo_char, echo_dash, cmd_error, top_level_2):
5543 (poll_for_input, handle_async_input): Now static.
5544 (read_char, kbd_buffer_get_event, make_lispy_position):
5545 (make_lispy_event, make_lispy_movement, apply_modifiers):
5546 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5547 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5548 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5549 (read_key_sequence, read_char): Mark locals as initialized.
5550 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5551
5552 * keyboard.h (make_ctrl_char): New decl.
5553 (mark_kboards): Move decl here ...
5554 * alloc.c (mark_kboards): ... from here.
5555
5556 * lisp.h (force_auto_save_soon): New decl.
5557
5558 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5559 (DEFINE_DUMMY_FUNCTION): New macro.
5560 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5561 Use it.
5562 (main): Add casts to avoid warnings
5563 if GCC considers string literals to be constants.
5564
5565 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5566
5567 * dbusbind.c: Pointer signedness fixes.
5568 (xd_signature, xd_append_arg, xd_initialize):
5569 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5570 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5571 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5572 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5573
5574 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5575 if GCC considers string literals to be constants.
5576 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5577
5578 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5579
5580 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5581 (print_preprocess, print_object): New macro to fix last change.
5582
5583 * print.c (print_preprocess): Don't forget font objects.
5584
5585 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5586
5587 * emacs.c (USAGE3): Doc fixes.
5588
5589 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5590
5591 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5592 structure.
5593
5594 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5595
5596 * lisp.h (VWindow_system, Qfile_name_history):
5597 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5598 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5599 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5600
5601 * w32select.c: Don't #include "keyboard.h".
5602 (run_protected): Add extern declaration for waiting_for_input.
5603
5604 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5605 * w32console.c (detect_input_pending, read_input_pending)
5606 (encode_terminal_code):
5607 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5608 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5609 (w32_system_caret_y, Qfile_name_history):
5610 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5611 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5612 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5613 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5614 * w32proc.c (Qlocal, report_file_error):
5615 * w32term.c (Vwindow_system, updating_frame):
5616 * w32uniscribe.c (initialized, uniscribe_font_driver):
5617 Remove unneeded extern declarations.
5618
5619 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5620
5621 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5622
5623 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5624
5625 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5626 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5627 These macros can no longer be used for assignment.
5628
5629 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5630 Assign struct members directly, instead of using BUF_BEGV etc.
5631 (record_buffer_markers, fetch_buffer_markers): New functions for
5632 recording and fetching special buffer markers.
5633 (set_buffer_internal_1, set_buffer_temp): Use them.
5634
5635 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5636
5637 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5638
5639 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5640 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5641
5642 * xdisp.c (hscroll_window_tree):
5643 (reconsider_clip_changes): Use PT instead of BUF_PT.
5644
5645 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5646
5647 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5648 $(EMACS_ROOT)/lib/intprops.h.
5649
5650 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5651
5652 Fix more problems found by GCC 4.5.2's static checks.
5653
5654 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5655 to unsigned char * to avoid compiler diagnostic.
5656 (xg_free_frame_widgets): Make it clear that a local variable is
5657 needed only if USE_GTK_TOOLTIP.
5658 (gdk_window_get_screen): Make it clear that this macro is needed
5659 only if USE_GTK_TOOLTIP.
5660 (int_gtk_range_get_value): New function, which avoids a diagnostic
5661 from gcc -Wbad-function-cast.
5662 (xg_set_toolkit_scroll_bar_thumb): Use it.
5663 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5664 diagnostic from gcc -Wbad-function-cast.
5665 (get_utf8_string, xg_get_file_with_chooser):
5666 Rename locals to avoid shadowing.
5667 (create_dialog): Move locals to avoid shadowing.
5668
5669 * xgselect.c (xg_select): Remove unused var.
5670
5671 * image.c (four_corners_best): Mark locals as initialized.
5672 (gif_load): Initialize transparent_p to zero (Bug#8238).
5673 Mark another local as initialized.
5674 (my_png_error, my_error_exit): Mark with NO_RETURN.
5675
5676 * image.c (clear_image_cache): Now static.
5677 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5678 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5679 (x_edge_detection): Remove unnecessary cast that
5680 gcc -Wbad-function-cast diagnoses.
5681 (gif_load): Fix pointer signedness.
5682 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5683 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5684
5685 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5686
5687 Improve quality of tests for time stamp overflow.
5688 For example, without this patch (encode-time 0 0 0 1 1
5689 1152921504606846976) returns the obviously-bogus value (-948597
5690 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5691 reports time overflow. See
5692 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5693 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5694 * editfns.c: Include limits.h and intprops.h.
5695 (TIME_T_MIN, TIME_T_MAX): New macros.
5696 (time_overflow): Move earlier, to before first use.
5697 (hi_time, lo_time): New functions, for an accurate test for
5698 out-of-range times.
5699 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5700 (Fget_internal_run_time): Don't assume time_t fits in int.
5701 (make_time): Use list2 instead of Fcons twice.
5702 (Fdecode_time): More accurate test for out-of-range times.
5703 (check_tm_member): New function.
5704 (Fencode_time): Use it, to test for out-of-range times.
5705 (lisp_time_argument): Don't rely on undefined left-shift and
5706 right-shift behavior when checking for time stamp overflow.
5707
5708 * editfns.c (time_overflow): New function, refactoring common code.
5709 (Fformat_time_string, Fdecode_time, Fencode_time):
5710 (Fcurrent_time_string): Use it.
5711
5712 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5713 * dired.c (make_time): Move to ...
5714 * editfns.c (make_time): ... here.
5715 * systime.h: Note the move.
5716
5717 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5718
5719 * fringe.c (update_window_fringes): Remove unused variables.
5720
5721 * unexmacosx.c (copy_data_segment): Also copy __got section.
5722 (Bug#8223)
5723
5724 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5725
5726 * termcap.c [MSDOS]: Include "msdos.h".
5727 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5728 Constify `char *' arguments and their references according to
5729 prototypes in tparam.h.
5730
5731 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5732
5733 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5734 Adapt all references accordingly.
5735
5736 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5737
5738 2011-03-11 Tom Tromey <tromey@redhat.com>
5739
5740 * buffer.c (syms_of_buffer): Remove obsolete comment.
5741
5742 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5743
5744 * termhooks.h (encode_terminal_code): Declare prototype.
5745
5746 * msdos.c (encode_terminal_code): Don't declare prototype.
5747
5748 * term.c (encode_terminal_code): Now external again, used by
5749 w32console.c and msdos.c.
5750
5751 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5752 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5753
5754 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5755
5756 Fix some minor problems found by GCC 4.5.2's static checks.
5757
5758 * fringe.c (update_window_fringes): Mark locals as initialized
5759 (Bug#8227).
5760 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5761
5762 * alloc.c (mark_fringe_data): Move decl from here ...
5763 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5764 to check its interface.
5765 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5766
5767 * fontset.c (free_realized_fontset): Now static.
5768 (Fset_fontset_font): Rename local to avoid shadowing.
5769 (fontset_font): Mark local as initialized.
5770 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5771
5772 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5773
5774 * xselect.c (x_disown_buffer_selections): Remove; not used.
5775 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5776 (x_own_selection, Fx_disown_selection_internal): Rename locals
5777 to avoid shadowing.
5778 (x_handle_dnd_message): Remove local to avoid shadowing.
5779
5780 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5781 so that the caller can use some name other than gcpro1.
5782 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5783 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5784 (Fx_backspace_delete_keys_p):
5785 Use them to avoid shadowing, and rename vars to avoid shadowing.
5786 (x_decode_color, x_set_name, x_window): Now static.
5787 (Fx_create_frame): Add braces to silence GCC warning.
5788 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5789 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5790 Remove unused locals.
5791 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5792 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5793 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5794 macros.
5795
5796 * xterm.h (x_mouse_leave): New decl.
5797
5798 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5799 Remove unused functions.
5800 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5801 (x_calc_absolute_position): Now static.
5802 (XTread_socket): Don't define label "out" unless it's used.
5803 Don't declare local "event" unless it's used.
5804 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5805 unless they are used.
5806 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5807 (x_fatal_error_signal): Remove; not used.
5808 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5809 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5810 (x_error_catcher, x_connection_closed, x_error_handler):
5811 (x_error_quitter, xembed_send_message, x_iconify_frame):
5812 (my_log_handler): Rename locals to avoid shadowing.
5813 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5814 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5815
5816 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5817 Rename or move locals to avoid shadowing.
5818 (tty_defined_color, merge_face_heights): Now static.
5819 (free_realized_faces_for_fontset): Remove; not used.
5820 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5821 does not deduce is never used uninitialized.
5822 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5823 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5824
5825 * terminal.c (store_terminal_param): Now static.
5826
5827 * xmenu.c (menu_highlight_callback): Now static.
5828 (set_frame_menubar): Remove unused local.
5829 (xmenu_show): Rename parameter to avoid shadowing.
5830 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5831 since they might point to immutable storage.
5832 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5833 since it's unused otherwise.
5834
5835 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5836 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5837 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5838 avoids a gcc -Wuninitialized diagnostic.
5839 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5840 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5841 does not deduce are never used uninitialized.
5842
5843 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5844
5845 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5846 * window.c (window_loop, size_window):
5847 (run_window_configuration_change_hook, enlarge_window): Likewise.
5848
5849 * window.c (display_buffer): Now static.
5850 (size_window): Mark variables that gcc -Wuninitialized
5851 does not deduce are never used uninitialized.
5852 * window.h (check_all_windows): New decl, to forestall
5853 gcc -Wmissing-prototypes diagnostic.
5854 * dispextern.h (bidi_dump_cached_states): Likewise.
5855
5856 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5857 shadowing.
5858 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5859 Include <limits.h>.
5860 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5861 and to avoid gcc -Wuninitialized warning.
5862 (load_charset_map): Mark variables that gcc -Wuninitialized
5863 does not deduce are never used uninitialized.
5864 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5865
5866 * coding.c (coding_set_source, coding_set_destination):
5867 Use "else { /* comment */ }" rather than "else /* comment */;"
5868 for clarity, and to avoid gcc -Wempty-body warning.
5869 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5870 a block, when the outer 'i' will do.
5871 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5872 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5873 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5874 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5875 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5876 Rename locals to avoid shadowing.
5877 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5878 * coding.c (emacs_mule_char, encode_invocation_designation):
5879 Now static, since they're not used elsewhere.
5880 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5881 (decode_coding_object, encode_coding_object, detect_coding_system):
5882 (decode_coding_emacs_mule): Mark variables that gcc
5883 -Wuninitialized does not deduce are never used uninitialized.
5884 (detect_coding_iso_2022): Initialize a local variable that might
5885 be used uninitialized. Leave a FIXME because it's not clear that
5886 this initialization is needed. (Bug#8211)
5887 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5888 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5889 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5890 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5891 Remove unused macros.
5892
5893 * category.c (hash_get_category_set): Remove unused local var.
5894 (copy_category_table): Now static, since it's not used elsewhere.
5895 * character.c (string_count_byte8): Likewise.
5896
5897 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5898 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5899
5900 * chartab.c (copy_sub_char_table): Now static, since it's not used
5901 elsewhere.
5902 (sub_char_table_ref_and_range, char_table_ref_and_range):
5903 Rename locals to avoid shadowing.
5904 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5905
5906 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5907 (BIDI_BOB): Remove unused macro.
5908
5909 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5910 deduce are never used uninitialized.
5911 * term.c (encode_terminal_code): Likewise.
5912
5913 * term.c (encode_terminal_code): Now static. Remove unused local.
5914
5915 * tparam.h: New file.
5916 * term.c, tparam.h: Include it.
5917 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5918 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5919 Move these decls to tparam.h, and make them agree with what
5920 is actually in tparam.c. The previous trick of using incompatible
5921 decls in different modules does not conform to the C standard.
5922 All callers of tparam changed to use tparam's actual API.
5923 * tparam.c (tparam1, tparam, tgoto):
5924 Use const pointers where appropriate.
5925
5926 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5927 * cm.h (struct cm): Likewise.
5928 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5929 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5930 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5931 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5932 (turn_on_face, init_tty): Likewise.
5933 * termchar.h (struct tty_display_info): Likewise.
5934
5935 * term.c (term_mouse_position): Rename local to avoid shadowing.
5936
5937 * alloc.c (mark_ttys): Move decl from here ...
5938 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5939
5940 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5941
5942 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5943
5944 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5945
5946 * search.c (compile_pattern_1): Remove argument regp, unused since
5947 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5948 (compile_pattern): Don't pass it.
5949
5950 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5951
5952 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5953 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5954 for ! HAVE_GTK3.
5955 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5956
5957 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5958
5959 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5960 gdk_window_get_screen, gdk_window_get_geometry,
5961 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5962 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5963 (xg_get_pixbuf_from_pixmap): New function.
5964 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5965 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5966 Call xg_get_pixbuf_from_pixmap instead of
5967 gdk_pixbuf_get_from_drawable.
5968 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5969 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5970 (xg_check_special_colors): Use GtkStyleContext and its functions
5971 for HAVE_GTK3.
5972 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5973 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5974 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5975 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5976 Call gtk_widget_get_preferred_size.
5977 (xg_frame_resized): gdk_window_get_geometry only takes 5
5978 parameters.
5979 (xg_win_to_widget, xg_event_is_for_menubar):
5980 Call gdk_x11_window_lookup_for_display.
5981 (xg_set_widget_bg): New function.
5982 (delete_cb): New function.
5983 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5984 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5985 (xg_set_background_color): Call xg_set_widget_bg.
5986 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5987 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5988 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5989 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5990 if ! HAVE_GTK3.
5991 (update_frame_tool_bar): Call gtk_widget_hide.
5992 (xg_initialize): Use GDK_KEY_g.
5993
5994 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5995 if ! HAVE_GTK3
5996 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5997
5998 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5999 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6000 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6001
6002 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6003
6004 * w32xfns.c (select_palette): Check success of RealizePalette against
6005 GDI_ERROR, not zero.
6006
6007 See ChangeLog.11 for earlier changes.
6008
6009 ;; Local Variables:
6010 ;; coding: utf-8
6011 ;; End:
6012
6013 Copyright (C) 2011 Free Software Foundation, Inc.
6014
6015 This file is part of GNU Emacs.
6016
6017 GNU Emacs is free software: you can redistribute it and/or modify
6018 it under the terms of the GNU General Public License as published by
6019 the Free Software Foundation, either version 3 of the License, or
6020 (at your option) any later version.
6021
6022 GNU Emacs is distributed in the hope that it will be useful,
6023 but WITHOUT ANY WARRANTY; without even the implied warranty of
6024 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6025 GNU General Public License for more details.
6026
6027 You should have received a copy of the GNU General Public License
6028 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.