Add comments about special meaning of TAB characters in compositions.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2
3 * xterm.c (x_draw_composite_glyph_string_foreground):
4 * w32term.c (x_draw_composite_glyph_string_foreground):
5 * term.c (encode_terminal_code):
6 * composite.c (composition_update_it, get_composition_id):
7 * xdisp.c (get_next_display_element)
8 (fill_composite_glyph_string): Add comments about special meaning
9 of TAB characters in a composition.
10
11 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
12
13 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
14 This occurs when processing a multibyte format, which can happen
15 when using 'eval'. Problem reported by Wolfgang Jenker.
16
17 2011-09-15 Johan Bockgård <bojohan@gnu.org>
18
19 * xdisp.c (try_cursor_movement): Only check for exact match if
20 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
21
22 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
23
24 Remove unused external symbols.
25 * dispextern.h (calc_pixel_width_or_height): Remove decl.
26 * xdisp.c (calc_pixel_width_or_height): Now static.
27 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
28 * indent.c (check_display_width):
29 * w32term.c: Fix comment to match code.
30 * xterm.c, xterm.h (x_catching_errors): Remove.
31
32 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
33
34 * xselect.c: Use signed conversions more consistently (Bug#9498).
35 (selection_data_to_lisp_data): Assume incoming selection data are
36 signed integers, not unsigned. This is to be consistent with
37 outgoing selection data, which was modified to use signed integers
38 in as part of the fix to Bug#9196 in response to Jan D.'s comment
39 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
40 expects long, not unsigned long.
41
42 2011-09-14 Eli Zaretskii <eliz@gnu.org>
43
44 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
45 computation of loop end. Reported by Johan Bockgård
46 <bojohan@gnu.org>.
47
48 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
49
50 * frame.c (Fother_visible_frames_p): Function deleted.
51
52 2011-09-12 Eli Zaretskii <eliz@gnu.org>
53
54 * indent.c (compute_motion): Process display vector front to back
55 rather than the other way around. (Bug#2496)
56
57 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
58
59 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
60
61 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
62
63 * minibuf.c (Fread_from_minibuffer): Doc fix.
64
65 2011-09-11 Eli Zaretskii <eliz@gnu.org>
66
67 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
68 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
69
70 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
71
72 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
73 value for non-existent files.
74
75 2011-09-11 Eli Zaretskii <eliz@gnu.org>
76
77 * fileio.c (Finsert_file_contents): If the file cannot be opened,
78 set its "size" to -1. This will set the modtime_size field of
79 the corresponding buffer to -1, which is what
80 verify-visited-file-modtime expects for files that do not exist.
81 (Bug#9139)
82
83 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
84
85 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
86 here ...
87 * lisp.h: ... from here. push_key_description is no longer
88 defined in keyboard.c, so its declaration should not be in
89 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
90 logically belongs with push_key_description.
91
92 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
93
94 * buffer.h: Include <sys/types.h> instead of <time.h>.
95 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
96 Problem reported by Herbert J. Skuhra.
97
98 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
99
100 * xml.c (parse_region): Make the parsing work for
101 non-comment-starting XML files again (bug#9144).
102
103 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
104
105 * image.c (gif_load): Fix calculation of bottom and right corner.
106 (Bug#9468)
107
108 2011-09-10 Eli Zaretskii <eliz@gnu.org>
109
110 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
111 redisplay in small windows.
112
113 2011-09-09 Eli Zaretskii <eliz@gnu.org>
114
115 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
116
117 2011-09-08 Martin Rudalics <rudalics@gmx.at>
118
119 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
120 Operate on live windows only.
121
122 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
123
124 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
125
126 2011-09-07 Eli Zaretskii <eliz@gnu.org>
127
128 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
129 only under bidi iteration.
130
131 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
132
133 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
134
135 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
136
137 isnan: Fix porting problem to Solaris 10 with bundled gcc.
138 Without this fix, the command to link temacs failed due to an
139 undefined symbol __builtin_isnan. This is because
140 /usr/include/iso/math_c99.h #defines isnan(x) to
141 __builtin_isnan(x), but the bundled gcc, which identifies itself
142 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
143 a __builtin_isnan.
144 * floatfns.c (isnan): #undef, and then #define to a clone of
145 what's in data.c.
146 (Fisnan): Always define, since it's always available now.
147 (syms_of_floatfns): Always define isnan at the Lisp level.
148
149 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
150
151 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
152
153 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
154
155 * fileio.c: Fix bugs with large file offsets (Bug#9428).
156 The previous code assumed that file offsets (off_t values) fit in
157 EMACS_INT variables, which is not true on typical 32-bit hosts.
158 The code messed up by falsely reporting buffer overflow in cases
159 such as (insert-file-contents "big" nil 1 2) into an empty buffer
160 when "big" contains more than 2**29 bytes, even though this
161 inserts just one byte and does not overflow the buffer.
162 (Finsert_file_contents): Store file offsets as off_t
163 values, not as EMACS_INT values. Check for overflow when
164 converting between EMACS_INT and off_t. When checking for
165 buffer overflow or for overlap, take the offsets into account.
166 Don't use EMACS_INT for small values where int suffices.
167 When checking for overlap, fix a typo: ZV was used where
168 ZV_BYTE was intended.
169 (Fwrite_region): Don't assume off_t fits into 'long'.
170 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
171
172 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
173
174 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
175
176 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
177
178 sprintf-related integer and memory overflow issues (Bug#9412).
179
180 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
181 (esprintf, exprintf, evxprintf): New functions.
182 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
183 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
184 (modify_event_symbol): Do not assume that the length of
185 name_alist_or_stem is safe to alloca and fits in int.
186 (Fexecute_extended_command): Likewise for function name and binding.
187 (Frecursion_depth): Wrap around reliably on integer overflow.
188 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
189 since some callers pass EMACS_INT values.
190 (Fsingle_key_description): Don't crash if symbol name contains more
191 than MAX_ALLOCA bytes.
192 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
193 (get_minibuffer): Arg is now EMACS_INT, not int.
194 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
195 (esprintf, exprintf, evxprintf): New decls.
196 * window.h (command_loop_level, minibuf_level): Reflect API changes.
197
198 * dbusbind.c (signature_cat): New function.
199 (xd_signature, Fdbus_register_signal):
200 Do not overrun buffer; instead, report string overflow.
201
202 * dispnew.c (add_window_display_history): Don't overrun buffer.
203 Truncate instead; this is OK since it's just a log.
204
205 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
206 even if the time zone offset is outlandishly large.
207 Don't mishandle offset == INT_MIN.
208
209 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
210 when creating daemon; the previous buffer-overflow check was incorrect.
211
212 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
213 which has the guts of the old verror function.
214
215 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
216 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
217
218 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
219 (font_unparse_xlfd): Don't blindly alloca long strings.
220 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
221 fits in int, when using sprintf. Use single snprintf to count
222 length of string rather than counting it via multiple sprintfs;
223 that's simpler and more reliable.
224 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
225 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
226 sprintf, in case result does not fit in int.
227
228 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
229 (fontset_from_font): Print it.
230
231 * frame.c (tty_frame_count): Now printmax_t, not int.
232 (make_terminal_frame, set_term_frame_name): Print it.
233 (x_report_frame_params): In X, window IDs are unsigned long,
234 not signed long, so print them as unsigned.
235 (validate_x_resource_name): Check for implausibly long names,
236 and don't assume name length fits in 'int'.
237 (x_get_resource_string): Don't blindly alloca invocation name;
238 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
239 not fit in int.
240
241 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
242 (xg_check_special_colors, xg_set_geometry):
243 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
244
245 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
246 Use esprintf, not sprintf, in case result does not fit in int.
247
248 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
249 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
250 it as a large positive number.
251 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
252 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
253
254 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
255 in case result does not fit in int.
256
257 * print.c (float_to_string): Detect width overflow more reliably.
258 (print_object): Make sprintf buffer a bit bigger, to avoid potential
259 buffer overrun. Don't assume list length fits in 'int'. Treat
260 print length of 0 as 0, not as infinity; to be consistent with other
261 uses of print length in this function. Don't overflow print length
262 index. Don't assume hash table size fits in 'long', or that
263 vectorlike size fits in 'unsigned long'.
264
265 * process.c (make_process): Use printmax_t, not int, to format
266 process-name gensyms.
267
268 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
269
270 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
271 to avoid potential buffer overrun.
272
273 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
274 if X resource line is longer than 512 bytes.
275
276 * xfns.c (x_window): Make sprintf buffer a bit bigger
277 to avoid potential buffer overrun.
278
279 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
280
281 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
282
283 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
284
285 Integer overflow fixes for scrolling, etc.
286 Without these, Emacs silently mishandles large integers sometimes.
287 For example, "C-u 4294967297 M-x recenter" was treated as if
288 it were "C-u 1 M-x recenter" on a typical 64-bit host.
289
290 * xdisp.c (try_window_id): Check Emacs fixnum range before
291 converting to 'int'.
292
293 * window.c (window_scroll_line_based, Frecenter):
294 Check that an Emacs fixnum is in range before assigning it to 'int'.
295 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
296 values converted from Emacs fixnums.
297 (Frecenter): Don't wrap around a line count if it is out of 'int'
298 range; instead, treat it as an extreme value.
299 (Fset_window_configuration, compare_window_configurations):
300 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
301
302 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
303 that can exceed INT_MAX. Check that EMACS_INT value is in range
304 before assigning it to the (possibly-narrower) index.
305 (match_limit): Don't assume that a fixnum can fit in 'int'.
306
307 * print.c (print_object): Use ptrdiff_t, not int, for index that can
308 exceed INT_MAX.
309
310 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
311 (Fvertical_motion): Don't wrap around LINES values that don't fit
312 in 'int'. Instead, treat them as extreme values. This is good
313 enough for windows, which can't have more than INT_MAX lines anyway.
314
315 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
316
317 * Require libxml/parser.h to avoid compilation warning.
318
319 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
320
321 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
322 since this reportedly can destroy thread storage.
323
324 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
325
326 * syntax.c (find_defun_start): Update all cache variables if
327 exiting early (Bug#9401).
328
329 2011-08-30 Eli Zaretskii <eliz@gnu.org>
330
331 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
332
333 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
334 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
335 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
336
337 * term.c (tty_append_glyph): New function.
338 (produce_stretch_glyph): Static function and its prototype deleted.
339
340 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
341 prototypes.
342
343 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
344
345 * image.c (parse_image_spec): Check for nonnegative, not for positive,
346 when checking :margin (Bug#9390).
347 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
348 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
349 so that the name doesn't mislead. All uses changed.
350
351 2011-08-28 Johan Bockgård <bojohan@gnu.org>
352
353 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
354 set_tty_hooks.
355
356 2011-08-27 Eli Zaretskii <eliz@gnu.org>
357
358 * xdisp.c (move_it_to): Don't bail out early when reaching
359 position beyond to_charpos, if we are scanning backwards.
360 (move_it_vertically_backward): When DY == 0, make sure we get to
361 the first character in the line after the newline.
362
363 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
364
365 * ccl.c: Improve and simplify overflow checking (Bug#9196).
366 (ccl_driver): Do not generate an out-of-range pointer.
367 (Fccl_execute_on_string): Remove unnecessary check for
368 integer overflow, noted by Stefan Monnier in
369 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
370 Remove a FIXME that didn't need fixing.
371 Simplify the newly-introduced buffer reallocation code.
372
373 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
374
375 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
376
377 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
378
379 Integer and memory overflow issues (Bug#9196).
380
381 * doc.c (get_doc_string): Rework so that
382 get_doc_string_buffer_size is the actual buffer size, rather than
383 being 1 less than the actual buffer size; this makes xpalloc more
384 convenient.
385
386 * image.c (x_allocate_bitmap_record, cache_image):
387 * xselect.c (Fx_register_dnd_atom):
388 Simplify previous changes by using xpalloc.
389
390 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
391 since either will do and ptrdiff_t is convenient with xpalloc.
392
393 * charset.c (charset_table_size)
394 (struct charset_sort_data.priority): Now ptrdiff_t.
395 (charset_compare): Don't overflow if priorities differ greatly.
396 (Fsort_charsets): Don't assume list length fits in int.
397 Check for size-calculation overflow when allocating sort data.
398 (syms_of_charset): Allocate an initial charset table that is
399 just under 64 KiB, to avoid problems with glibc malloc and mmap.
400
401 * cmds.c (internal_self_insert): Check for size-calculation overflow.
402
403 * composite.h (struct composition.glyph_len): Now int, not unsigned.
404 The actual value is always <= INT_MAX, and leaving it unsigned made
405 overflow checking harder.
406
407 * dispextern.h (struct glyph_matrix.rows_allocated)
408 (struct face_cache.size): Now ptrdiff_t, for convenience in use
409 with xpalloc. The values are still always <= INT_MAX.
410
411 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
412
413 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
414 (SAFE_NALLOCA): New macro.
415
416 * region-cache.c (struct boundary.pos, find_cache_boundary)
417 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
418 (set_cache_region, invalidate_region_cache)
419 (revalidate_region_cache, know_region_cache, region_cache_forward)
420 (region_cache_backward, pp_cache):
421 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
422 so that ptrdiff_t * can be passed to xpalloc.
423 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
424 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
425 (pp_cache): Don't assume cache_len fits in int.
426 * region-cache.h: Adjust extern decls to match.
427
428 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
429 EMACS_INT, since either will do, for xpalloc.
430
431 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
432 (xnmalloc, xnrealloc, xpalloc): New functions.
433
434 * bidi.c (bidi_shelve_header_size): New constant.
435 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
436 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
437
438 * bidi.c (bidi_cache_shrink):
439 * buffer.c (overlays_at, overlays_in, record_overlay_string)
440 (overlay_strings):
441 Don't update size of array until after memory allocation succeeds,
442 because xmalloc/xrealloc may not return.
443 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
444 now that we have proper integer overflow checking.
445 (record_overlay_string, overlay_strings): Catch overflows when
446 calculating size of overlay_str_buf.
447
448 * callproc.c (Fcall_process): Check for size overflow when
449 calculating size of args2.
450 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
451 Normally we prefer signed values, but sticking with ptrdiff_t would
452 require adding more-complicated checks.
453
454 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
455 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
456 Redo buffer-overflow calculations to avoid integer overflow.
457 Add a FIXME comment where memory seems to be over-allocated.
458
459 * character.c (Fstring): Check for size-calculation overflow.
460
461 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
462 unnecessary integer overflow. Check for size overflow.
463 (encode_coding_object): Don't update size until xmalloc succeeds.
464
465 * composite.c (get_composition_id): Check for overflow in glyph
466 length calculations.
467
468 Integer and memory overflow fixes for display code.
469 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
470 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
471 (scrolling_window): Check for overflow in size calculations.
472 (line_draw_cost, realloc_glyph_pool, add_row_entry):
473 Don't assume glyph table len fits in int.
474 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
475 (row_table_size): Now ptrdiff_t, not int.
476 (scrolling_window): Avoid overflow in size calculations.
477 Don't update size until allocation succeeds.
478 * fns.c (concat): Check for overflow in size calculations.
479 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
480 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
481 (NEXT_ALMOST_PRIME_LIMIT): New constant.
482
483 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
484 (get_doc_string): Check for size calculation overflow.
485 Don't update size until allocation succeeds.
486 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
487 EMACS_INT, where ptrdiff_t will do.
488 (Fsubstitute_command_keys): Check for string overflow.
489
490 * editfns.c (set_time_zone_rule): Don't assume environment length
491 fits in int.
492 (message_length): Now ptrdiff_t, not int.
493 (Fmessage_box): Don't update size until allocation succeeds.
494 Don't assume message length fits in int.
495 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
496
497 * emacs.c (main): Do not reallocate argv, since there is a null at
498 the end that can be overwritten, and this way there's no need to
499 worry about size-calculation overflow.
500 (sort_args): Check for size-calculation overflow.
501
502 * eval.c (init_eval_once, grow_specpdl): Don't update size until
503 alloc succeeds.
504 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
505
506 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
507 (x_set_scroll_bar_width, x_figure_window_size):
508 Check for integer overflow.
509 (x_set_alpha): Do not assume XINT fits in int.
510
511 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
512 This is for the members text_lines, text_cols, total_lines, total_cols,
513 where the system imposes an 'int' limit.
514
515 * fringe.c (Fdefine_fringe_bitmap):
516 Don't update size until alloc works.
517
518 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
519 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
520
521 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
522 Check for size-calculation overflow.
523 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
524 do, as we prefer signed integers.
525 (id_to_widget.max_size, id_to_widget.used)
526 (xg_store_widget_in_map, xg_remove_widget_from_map)
527 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
528 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
529 Use and return ptrdiff_t, not int.
530 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
531 * gtkutil.h: Change prototypes to match the above.
532
533 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
534 are duplicate now that they've been promoted to lisp.h.
535 (x_allocate_bitmap_record, x_alloc_image_color)
536 (make_image_cache, cache_image, xpm_load):
537 Don't update size until alloc is done.
538 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
539 (x_detect_edges):
540 Check for size calculation overflow.
541 (ct_colors_allocated_max): New constant.
542 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
543 overflow.
544
545 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
546 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
547 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
548 Use ptrdiff_t, not int, to count maps.
549 (read_char_minibuf_menu_prompt): Check for overflow in size
550 calculations. Don't update size until allocation succeeds. Redo
551 calculations to avoid overflow.
552 * keyboard.h: Change prototypes to match the above.
553
554 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
555 to count maps.
556 (current_minor_maps): Check for size calculation overflow.
557 * keymap.h: Change prototypes to match the above.
558
559 * lread.c (read1, init_obarray): Don't update size until alloc done.
560
561 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
562 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
563
564 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
565 Now ptrdiff_t, not int.
566 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
567 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
568
569 * process.c (Fnetwork_interface_list): Check for overflow
570 in size calculation.
571
572 * region-cache.c (move_cache_gap): Check for size calculation overflow.
573
574 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
575 overflow. Don't bother calling xmalloc when xrealloc will do.
576
577 * search.c (Freplace_match): Check for size calculation overflow.
578 (Fset_match_data): Don't assume list lengths fit in 'int'.
579
580 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
581 for command line length. Do not attempt to address one before the
582 beginning of an array, as that's not portable.
583
584 * term.c (max_frame_lines): Remove; unused.
585 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
586 not int.
587 (encode_terminal_code, calculate_costs): Check for size
588 calculation overflow.
589 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
590 table lengths and related sizes. Don't update size until alloc
591 done. Redo calculations to avoid overflow.
592 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
593
594 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
595 subtracting pointers.
596 (gobble_line): Check for overflow more carefully. Don't update size
597 until alloc done.
598
599 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
600 Don't update size until alloc done.
601 Redo size calculations to avoid overflow.
602 Check for size calculation overflow.
603 (main) [DEBUG]: Fix typo in invoking tparam1.
604
605 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
606 Use ptrdiff_t, not int, for sizes.
607 (store_mode_line_noprop_char): Don't update size until alloc done.
608
609 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
610 Use ptrdiff_t, not int, for sizes.
611 (Finternal_make_lisp_face, cache_face):
612 Check for size calculation overflow.
613 (cache_face): Treat size calculation overflows as if they were
614 memory exhaustion (the usual treatment), rather than aborting.
615
616 * xfns.c (x_encode_text, x_set_name_internal)
617 (Fx_change_window_property): Use ptrdiff_t, not int, to count
618 sizes, since they can exceed INT_MAX in size. Check for size
619 calculation overflow.
620
621 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
622 (xg_select): Check for size calculation overflow.
623 Don't update size until alloc done.
624
625 * xrdb.c (get_environ_db): Don't assume path length fits in int,
626 as sprintf is limited to int lengths.
627
628 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
629 (X_LONG_MIN): New macros.
630 Use them to make the following changes clearer.
631 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
632 This change doesn't affect the value now, but it may help remind
633 future maintainers not to raise the value too much later.
634 (SELECTION_QUANTUM): Remove, replacing with ...
635 (selection_quantum): ... new function, which avoids overflow.
636 All uses changed.
637 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
638 assumption that selection length fits in 'int'.
639 (x_reply_selection_request, x_handle_selection_request)
640 (x_get_window_property, receive_incremental_selection)
641 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
642 (lisp_data_to_selection_data, clean_local_selection_data):
643 Use ptrdiff_t, not int, to record length of selection.
644 (x_reply_selection_request, x_get_window_property)
645 (receive_incremental_selection, x_property_data_to_lisp):
646 Redo calculations to avoid overflow.
647 (x_reply_selection_request): When sending hint, ceiling it at
648 X_LONG_MAX rather than relying on wraparound overflow to send
649 something.
650 (x_get_window_property, receive_incremental_selection)
651 (lisp_data_to_selection_data, x_property_data_to_lisp):
652 Check for size-calculation overflow.
653 (x_get_window_property, receive_incremental_selection)
654 (lisp_data_to_selection_data, Fx_register_dnd_atom):
655 Don't store size until memory allocation succeeds.
656 (x_get_window_property): Plug memory leak on memory exhaustion.
657 Don't double-block input; malloc is safe here. Don't assume 2**34
658 - 4 fits in unsigned long. Add an xassert to check
659 XGetWindowProperty overflow. Be more careful about overflow
660 calculations, and distinguish size from memory overflow better.
661 (receive_incremental_selection): When tracing, don't assume
662 unsigned int is less than INT_MAX.
663 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
664 harmful) conversions of unsigned short to int.
665 (lisp_data_to_selection_data): Don't assume that integers
666 in the range -65535 through -1 fit in an X unsigned short.
667 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
668 result parameters unless successful. Rely on cons_to_unsigned
669 to report problems with elements; the old code wasn't right anyway.
670 (x_check_property_data): Check for int overflow; we cannot use
671 a wider type due to X limits.
672 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
673
674 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
675
676 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
677 (x_term_init): Check for size calculation overflow.
678 (x_color_cells): Don't store size until memory allocation succeeds.
679 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
680 Don't assume alloca size is less than MAX_ALLOCA.
681 (x_term_init): Don't assume length fits in int (sprintf is limited
682 to int size).
683
684 Use ptrdiff_t for composition IDs.
685 * character.c (lisp_string_width):
686 * composite.c (composition_table_size, n_compositions)
687 (get_composition_id, composition_gstring_from_id):
688 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
689 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
690 * window.c (Frecenter):
691 Use ptrdiff_t, not int, for composition IDs.
692 * composite.c (get_composition_id): Check for integer overflow.
693 * composite.h: Adjust prototypes to match the above changes.
694
695 Use ptrdiff_t for hash table indexes.
696 * category.c (hash_get_category_set):
697 * ccl.c (ccl_driver):
698 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
699 * coding.c (coding_system_charset_list, detect_coding_system):
700 * coding.h (struct coding_system.id):
701 * composite.c (get_composition_id, gstring_lookup_cache):
702 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
703 * image.c (xpm_get_color_table_h):
704 * lisp.h (hash_lookup, hash_put):
705 * minibuf.c (Ftest_completion):
706 Use ptrdiff_t for hash table indexes, not int (which is too
707 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
708 32-bit --with-wide-int hosts).
709
710 * charset.c (Fdefine_charset_internal): Check for integer overflow.
711 Add a FIXME comment about memory leaks.
712 (syms_of_charset): Don't assume xmalloc returns.
713
714 Don't assume that stated character widths fit in int.
715 * character.c (Fchar_width, c_string_width, lisp_string_width):
716 * character.h (CHAR_WIDTH):
717 * indent.c (MULTIBYTE_BYTES_WIDTH):
718 Use sanitize_char_width to avoid undefined and/or bad behavior
719 with outlandish widths.
720 * character.h (sanitize_tab_width): Renamed from sanitize_width,
721 now that we have two such functions. All uses changed.
722 (sanitize_char_width): New inline function.
723
724 Don't assume that tab-width fits in int.
725 * character.h (sanitize_width): New inline function.
726 (SANE_TAB_WIDTH): New macro.
727 (ASCII_CHAR_WIDTH): Use it.
728 * indent.c (sane_tab_width): Remove. All uses replaced by
729 SANE_TAB_WIDTH (current_buffer).
730 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
731
732 * fileio.c: Integer overflow issues with file modes.
733 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
734
735 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
736 Remove unreachable code.
737 (read_hex, load_charset_map_from_file): Check for integer overflow.
738
739 * xterm.c: don't go over XClientMessageEvent limit
740 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
741 (x_send_scroll_bar_event): Likewise. Check that the size does not
742 exceed limits imposed by XClientMessageEvent, as well as the usual
743 ptrdiff_t and size_t limits.
744
745 * keyboard.c: Overflow, signedness and related fixes.
746 (make_lispy_movement): Use same integer type in forward decl
747 that is used in the definition.
748 (read_key_sequence, keyremap_step):
749 Change bufsize argument back to int, undoing my 2011-03-30 change.
750 We prefer signed types, and int is wide enough here.
751 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
752 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
753 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
754 length, not size_t. Use ptrdiff_t for index, not int.
755 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
756 possibility of integer overflow.
757
758 Overflow, signedness and related fixes for images.
759
760 * dispextern.h (struct it.stack[0].u.image.image_id)
761 (struct_it.image_id, struct image.id, struct image_cache.size)
762 (struct image_cache.used, struct image_cache.ref_count):
763 * gtkutil.c (update_frame_tool_bar):
764 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
765 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
766 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
767 * nsmenu.m (update_frame_tool_bar):
768 * xdisp.c (calc_pixel_width_or_height):
769 * xfns.c (image_cache_refcount):
770 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
771 on typical 64-bit hosts.
772
773 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
774 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
775 Omit unnecessary casts to int.
776 (parse_image_spec): Check that integers fall into 'int' range
777 when the callers expect that.
778 (image_ascent): Redo ascent calculation to avoid int overflow.
779 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
780 (lookup_image): Remove unnecessary tests.
781 (xbm_image_p): Locals are now of int, not EMACS_INT,
782 since parse_image_check makes sure they fit into int.
783 (png_load, gif_load, svg_load_image):
784 Prefer int to unsigned where either will do.
785 (tiff_handler): New function, combining the cores of the
786 old tiff_error_handler and tiff_warning_handler. This
787 function is rewritten to use vsnprintf and thereby avoid
788 stack buffer overflows. It uses only the features of vsnprintf
789 that are common to both POSIX and native Microsoft.
790 (tiff_error_handler, tiff_warning_handler): Use it.
791 (tiff_load, gif_load, imagemagick_load_image):
792 Don't assume :index value fits in 'int'.
793 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
794 (imagemagick_load_image): Check that crop parameters fit into
795 the integer types that MagickCropImage accepts. Don't assume
796 Vimagemagick_render_type has a nonnegative value. Don't assume
797 size_t fits in 'long'.
798 (gs_load): Use printmax_t to print the widest integers possible.
799 Check for integer overflow when computing image height and width.
800
801 2011-08-26 Eli Zaretskii <eliz@gnu.org>
802
803 * xdisp.c (redisplay_window): Don't force window start if point
804 will be invisible in the resulting window. (Bug#9324)
805
806 2011-08-25 Eli Zaretskii <eliz@gnu.org>
807
808 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
809 the display spec is of the form `(space ...)'.
810 (handle_display_spec): Return the value returned by
811 handle_single_display_spec, not just 1 or zero.
812 (handle_single_display_spec): If the display spec is of the form
813 `(space ...)', and specifies display in the text area, return 2
814 rather than 1.
815 (try_cursor_movement): Check for the need to scroll more
816 accurately, and prefer exact match for point under bidi. Don't
817 advance `row' beyond the last row of the window.
818
819 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
820 into disp_prop; all users changed.
821
822 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
823 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
824 for the text covered by the display property.
825
826 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
827
828 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
829 Change return value to nil.
830 (Frecord_buffer): Delete unused function.
831
832 2011-08-24 Eli Zaretskii <eliz@gnu.org>
833
834 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
835 buffers, return left-to-right.
836 (set_cursor_from_row): Consider candidate row a win if its glyph
837 represents a newline and point is on that newline. Fixes cursor
838 positioning on the newline at EOL of R2L text within L2R
839 paragraph, and vice versa.
840 (try_cursor_movement): Check continued rows, in addition to
841 continuation rows. Fixes unwarranted scroll when point enters a
842 continued line of R2L text within an L2R paragraph, or vice versa.
843 (cursor_row_p): Consider the case of point being equal to
844 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
845 from the end of a short line to the beginning of a continued line
846 of R2L text within L2R paragraph.
847 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
848 composed characters.
849
850 * bidi.c (bidi_check_type): Use xassert.
851 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
852 members.
853
854 2011-08-23 Eli Zaretskii <eliz@gnu.org>
855
856 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
857 a character.
858
859 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
860
861 * nsfont.m (ns_otf_to_script): Fix typo.
862
863 2011-08-22 Kenichi Handa <handa@m17n.org>
864
865 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
866 extra slot even if the purpose is char-code-property-table.
867
868 2011-08-23 Eli Zaretskii <eliz@gnu.org>
869
870 * xdisp.c (redisplay_window): When computing centering_position,
871 account for the height of the header line. (Bug#8874)
872
873 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
874 instead of CHAR_TO_BYTE. Fixes a crash when a completion
875 candidate is selected by the mouse, and that candidate has a
876 composed character under the mouse.
877
878 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
879 coordinates reported by pos-visible-in-window-p for a composed
880 character in column zero.
881
882 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
883
884 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
885
886 2011-08-22 Eli Zaretskii <eliz@gnu.org>
887
888 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
889 consider it a hit if to_charpos is anywhere in the range of the
890 composed buffer positions.
891
892 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
893
894 * image.c (gif_load): Don't assume that each subimage has the same
895 dimensions as the base image. Handle disposal method that is
896 "undefined" by the gif spec (Bug#9335).
897
898 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
899
900 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
901 (Fcondition_case): Document `debug' symbol in error handler.
902
903 2011-08-19 Eli Zaretskii <eliz@gnu.org>
904
905 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
906 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
907 from an Org mode buffer to a Speedbar frame.
908
909 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
910 a composition, take its buffer position from IT->cmp_it.charpos.
911 Fixes cursor positioning at the beginning of a line that begins
912 with a composed character.
913
914 2011-08-18 Eli Zaretskii <eliz@gnu.org>
915
916 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
917 character bidirectional type, use STRONG_L instead. Fixes crashes
918 in a buffer produced by `describe-categories'.
919
920 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
921 members before the level stack, so they would be saved and
922 restored when copying iterator state. Fixes incorrect reordering
923 around TABs covered by display properties.
924
925 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
926
927 * process.c (Fnetwork_interface_list): Correctly determine buffer
928 size.
929
930 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
931
932 * eval.c (internal_condition_case, internal_condition_case_1)
933 (internal_condition_case_2, internal_condition_case_n):
934 Remove unnecessary aborts (Bug#9081).
935
936 2011-08-17 Eli Zaretskii <eliz@gnu.org>
937
938 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
939 has no `load' handler, try opening the file locally. (Bug#9311)
940
941 2011-08-16 Ken Brown <kbrown@cornell.edu>
942
943 * gmalloc.c: Expand comment.
944
945 2011-08-16 Eli Zaretskii <eliz@gnu.org>
946
947 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
948 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
949
950 2011-08-16 Ken Brown <kbrown@cornell.edu>
951
952 Fix memory allocation problems in Cygwin build (Bug#9273).
953
954 * unexcw.c ( __malloc_initialized): Declare external variable.
955 (fixup_executable): Force the dumped emacs to reinitialize malloc.
956
957 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
958 New variables.
959 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
960 dumped emacs.
961 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
962 in the static heap.
963 [CYGWIN] (special_realloc): New function.
964 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
965 requests to realloc storage in the static heap.
966
967 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
968
969 * bidi.c (bidi_initialize): Remove unused local.
970
971 2011-08-15 Eli Zaretskii <eliz@gnu.org>
972
973 * biditype.h: File removed.
974
975 * bidimirror.h: File removed.
976
977 * deps.mk (bidi.o): Remove biditype.h and
978 bidimirror.h.
979
980 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
981 bidimirror.h.
982
983 * dispextern.h: Fix a typo in the comment to bidi_type_t.
984
985 * chartab.c: Improve commentary for the uniprop_table API.
986
987 * bidi.c (bidi_paragraph_init): Support zero value of
988 bidi_ignore_explicit_marks_for_paragraph_level.
989 (bidi_initialize): Use uniprop_table instead of including
990 biditype.h and bidimirror.h.
991
992 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
993 coordinates of the iterator when restoring from ppos_it.
994 (Bug#9296)
995
996 2011-08-14 Kenichi Handa <handa@m17n.org>
997
998 * process.c (create_process): Call setup_process_coding_systems
999 after the pid of the process is set to -1 (Bug#8162).
1000
1001 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1002
1003 * xdisp.c (move_it_in_display_line_to): Don't invoke
1004 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1005 ppos_it. Fixes vertical cursor motion when line beginning is
1006 covered by an image. (Bug#9296)
1007
1008 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1009
1010 * nsterm.h (ns_run_ascript): Declare.
1011 (NSAPP_DATA2_RUNASSCRIPT): Define.
1012
1013 * nsfns.m (as_script, as_result, as_status): New static variables.
1014 (ns_run_ascript): New function.
1015 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1016 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1017 the event loop. Get status from as_status (Bug#7276).
1018
1019 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1020 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1021 the event loop (Bug#7276).
1022
1023 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1024
1025 * gnutls.c (QCgnutls_bootprop_priority)
1026 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1027 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1028 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1029 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1030 (QCgnutls_bootprop_verify_hostname_error)
1031 (QCgnutls_bootprop_callbacks_verify): Rename from
1032 Qgnutls_bootprop_..., all uses changed.
1033
1034 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1035 uses changed.
1036
1037 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1038
1039 * xfaces.c (Qframe_set_background_mode): Now static.
1040 * dispextern.h (Qframe_set_background_mode): Remove decl.
1041
1042 * process.c (Fnetwork_interface_info): Declare local only if needed.
1043
1044 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1045
1046 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1047 (Fnetwork_interface_list): Allocate in increments of bytes instead
1048 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1049 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1050 sockaddr.
1051 (struct ifflag_def): notrailers is smart on OSX.
1052 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1053 Get hardware address with getifaddrs if available.
1054
1055 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1056
1057 * xdisp.c (iterate_out_of_display_property): xassert that
1058 IT->position is set to within IT->object's boundaries. Break from
1059 the loop as soon as EOB is reached; avoids infloops in redisplay
1060 when IT->position is set up wrongly due to some bug.
1061 Set IT->current to match the bidi iterator unconditionally.
1062 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1063 entry. Force push_it to save on the stack the current
1064 buffer/string position, to be restored by pop_it. Fix flags in
1065 the iterator structure wrt the object coming from a display
1066 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1067 properties. (Bug#9284)
1068
1069 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1070
1071 * fontset.c (fontset_get_font_group): Add proper type checks.
1072 (Bug#9172)
1073
1074 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1075
1076 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1077 and LC_VERSION_MIN_MACOSX.
1078 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1079 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1080
1081 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1082
1083 * xdisp.c (forward_to_next_line_start): Allow to use the
1084 no-display-properties-and-no-overlays under bidi display.
1085 Set disp_pos in the bidi iterator to avoid searches for display
1086 properties and overlays.
1087
1088 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1089
1090 * editfns.c (Fset_time_zone_rule): Document relationship with the
1091 setenv function.
1092
1093 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1094 the font entity extracted from the cache (Bug#8109).
1095
1096 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1097
1098 * composite.c (autocmp_chars): Don't reset point. That is done by
1099 restore_point_unwind (Bug#5984).
1100
1101 2011-08-07 Juri Linkov <juri@jurta.org>
1102
1103 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1104 to show the arg `TIME' instead of `TIMEVAL'.
1105
1106 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1107
1108 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1109 display property strides EOL and includes a newline, as in
1110 longlines-mode. (Bug#9254)
1111 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1112 word-wrap under bidirectional display. (Bug#9224)
1113
1114 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1115 is non-zero, even if the data buffer is NULL. Fixes a crash in
1116 vertical-motion with longlines-mode. (Bug#9254)
1117
1118 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1119
1120 * bidi.c <bidi_cache_total_alloc>: Now static.
1121 (bidi_initialize): Initialize bidi_cache_total_alloc.
1122
1123 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1124 cache. (Bug#9221)
1125
1126 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1127 amount allocated this far in `bidi_cache_total_alloc'.
1128 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1129 non-zero, only free the data buffer without restoring the cache
1130 contents. All callers changed.
1131
1132 * dispextern.h (bidi_unshelve_cache): Update prototype.
1133
1134 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1135 (move_it_in_display_line, move_it_to)
1136 (move_it_vertically_backward, move_it_by_lines): Replace the call
1137 to xfree to an equivalent call to bidi_unshelve_cache.
1138 (move_it_in_display_line_to): Fix logic of returning
1139 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1140
1141 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1142
1143 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1144 came from a string character with a `cursor' property. (Bug#9229)
1145
1146 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1147
1148 * Makefile.in (LIB_PTHREAD): New variable.
1149 (LIBES): Add LIB_PTHREAD (Bug#9216).
1150
1151 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1152 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1153
1154 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1155
1156 * regex.c (re_iswctype): Remove some redundant boolean
1157 conversions.
1158
1159 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1160
1161 * xterm.c (x_find_topmost_parent): New function.
1162 (x_set_frame_alpha): Find topmost parent window with
1163 x_find_topmost_parent and set the property there also (bug#9181).
1164 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1165
1166 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1167
1168 * callproc.c (Fcall_process): Avoid vfork clobbering
1169 the local vars buffer, coding_systems, current_dir.
1170
1171 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1172
1173 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1174
1175 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1176
1177 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1178 so that it is not optimized away.
1179
1180 * xdisp.c (compute_display_string_pos): Remove unused local.
1181
1182 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1183
1184 Fix slow cursor motion and scrolling in large buffers with
1185 selective display, like Org Mode buffers. (Bug#9218)
1186
1187 * dispextern.h (struct bidi_it): New member disp_prop_p.
1188
1189 * xdisp.c: Remove one-slot cache of display string positions.
1190 (compute_display_string_pos): Accept an additional argument
1191 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1192 for a display string or property. If found, set DISP_PROP_P
1193 non-zero.
1194
1195 * bidi.c (bidi_fetch_char): Accept an additional argument
1196 DISP_PROP_P, and pass it to compute_display_string_pos.
1197 Only handle text covered by a display string if DISP_PROP_P is returned
1198 non-zero. All callers of bidi_fetch_char changed.
1199
1200 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1201
1202 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1203
1204 2010-12-03 Don March <don@ohspite.net>
1205
1206 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1207 last character M-[char] is translated to ESC [char] (bug#7541).
1208
1209 2011-08-02 Kenichi Handa <handa@m17n.org>
1210
1211 * lisp.h (uniprop_table): Extern it.
1212
1213 * chartab.c (uniprop_table): Make it non-static.
1214
1215 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1216
1217 * xdisp.c (forward_to_next_line_start): Accept additional argument
1218 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1219 on the newline.
1220 (reseat_at_next_visible_line_start): Use the bidi iterator state
1221 returned by forward_to_next_line_start to restore the state of
1222 it->bidi_it after backing up to previous newline. (Bug#9212)
1223
1224 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1225
1226 * regex.c (re_comp): Protoize.
1227 (re_exec): Fix return type.
1228 (regexec): Fix type of `ret'. (Bug#9203)
1229
1230 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1231
1232 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1233 This is needed if max-image-size is a floating-point number.
1234
1235 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1236
1237 * print.c (print_object): Print empty symbol as ##.
1238
1239 * lread.c (read1): Read ## as empty symbol.
1240
1241 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1242
1243 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1244 setting frame foreground color (Bug#9175).
1245 (x_set_background_color): Likewise.
1246
1247 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1248 contents (Bug#9176).
1249 (EmacsTooltip -init): Remove bezels and add shadows to
1250 tooltip windows.
1251
1252 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1253 or scroll bar (Bug#8470).
1254
1255 * nsfont.m (nsfont_open): Remove assignment to voffset and
1256 unnecessary vars hshink, expand, hd, full_height, min_height.
1257 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1258
1259 * nsterm.h (nsfont_info): Remove voffset field.
1260
1261 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1262
1263 Implement strike-through and overline on NextStep (Bug#8863).
1264
1265 * nsfont.m (nsfont_open): Use underline position provided by font,
1266 instead of hard-coded value of 2.
1267 (nsfont_draw): Call ns_draw_text_decoration instead.
1268
1269 * nsterm.h: Add declaration for ns_draw_text_decoration.
1270
1271 * nsterm.m (ns_draw_text_decoration): New function for drawing
1272 underline, overline, and strike-through.
1273 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1274 ns_draw_text_decoration. Change treatment of cursor drawing to
1275 accomodate underlining, etc.
1276
1277 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1278
1279 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1280 default.
1281
1282 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1283
1284 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1285 Without this fix, if a signal arrives just after memory fills up,
1286 'malloc' might be invoked reentrantly.
1287
1288 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1289 In other words, assume that every image size is allowed, on non-X
1290 hosts. This assumption is probably wrong, but it lets Emacs compile.
1291
1292 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1293
1294 * regex.c (re_iswctype): Convert return values to boolean.
1295
1296 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1297
1298 * xdisp.c (compute_display_string_pos): Don't use cached display
1299 string position if the buffer had its restriction changed.
1300 (Bug#9184)
1301
1302 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1305
1306 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1307
1308 Integer signedness and overflow and related fixes. (Bug#9079)
1309
1310 * bidi.c: Integer size and overflow fixes.
1311 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1312 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1313 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1314 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1315 (bidi_find_other_level_edge):
1316 Use ptrdiff_t instead of EMACS_INT where either will do.
1317 This works better on 32-bit hosts configured --with-wide-int.
1318 (bidi_cache_ensure_space): Check for size-calculation overflow.
1319 Use % rather than repeated addition, for better worst-case speed.
1320 Don't set bidi_cache_size until after xrealloc returns, because it
1321 might not return.
1322 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1323 (bidi_cache_ensure_space): Also check that the bidi cache size
1324 does not exceed that of the largest Lisp string or buffer. See Eli
1325 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1326
1327 * alloc.c (__malloc_size_t): Remove.
1328 All uses replaced by size_t. See Andreas Schwab's note
1329 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1330
1331 * image.c: Improve checking for integer overflow.
1332 (check_image_size): Assume that f is nonnull, since
1333 it is always nonnull in practice. This is one less thing to
1334 worry about when checking for integer overflow later.
1335 (x_check_image_size): New function, which checks for integer
1336 overflow issues inside X.
1337 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1338 This removes the need for a memory_full check.
1339 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1340 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1341 (xbm_read_bitmap_data): Change locals back to 'int', since
1342 their values must fit in 'int'.
1343 (xpm_load_image, png_load, tiff_load):
1344 Invoke x_create_x_image_and_pixmap earlier,
1345 to avoid much needless work if the image is too large.
1346 (tiff_load): Treat overly large images as if
1347 x_create_x_image_and_pixmap failed, not as malloc failures.
1348 (gs_load): Use x_check_image_size.
1349
1350 * gtkutil.c: Omit integer casts.
1351 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1352 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1353
1354 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1355
1356 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1357 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1358 would wrongly return t on a 64-bit host.
1359
1360 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1361 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1362 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1363 and therefore cause GCC to emit a bogus diagnostic in some cases.
1364
1365 * image.c: Integer signedness and overflow and related fixes.
1366 This is not an exhaustive set of fixes, but it's time to
1367 record what I've got.
1368 (lookup_pixel_color, check_image_size): Remove redundant decls.
1369 (check_image_size): Don't assume that arbitrary EMACS_INT values
1370 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1371 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1372 (tiff_load, imagemagick_load_image):
1373 Check for overflow in size calculations.
1374 (x_create_x_image_and_pixmap): Remove unnecessary test for
1375 xmalloc returning NULL; that can't happen.
1376 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1377 (xpm_color_bucket): Use better integer hashing function.
1378 (xpm_cache_color): Don't possibly over-allocate memory.
1379 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1380 (gif_memory_source):
1381 Use ptrdiff_t, not int or size_t, to record sizes.
1382 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1383 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1384 either works, as we prefer signed integers.
1385 (tiff_read_from_memory, tiff_write_from_memory):
1386 Return tsize_t, not size_t, since that's what the TIFF API wants.
1387 (tiff_read_from_memory): Don't fail simply because the read would
1388 go past EOF; instead, return a short read.
1389 (tiff_load): Omit no-longer-needed casts.
1390 (Fimagemagick_types): Don't assume size fits into 'int'.
1391
1392 Improve hashing quality when configured --with-wide-int.
1393 * fns.c (hash_string): New function, taken from sxhash_string.
1394 Do not discard information about ASCII character case; this
1395 discarding is no longer needed.
1396 (sxhash-string): Use it. Change sig to match it. Caller changed.
1397 * lisp.h: Declare it.
1398 * lread.c (hash_string): Remove, since we now use fns.c's version.
1399 The fns.c version returns a wider integer if --with-wide-int is
1400 specified, so this should help the quality of the hashing a bit.
1401
1402 * emacs.c: Integer overflow minor fix.
1403 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1404 Define only if GNU_LINUX.
1405 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1406
1407 * dispnew.c: Integer signedness and overflow fixes.
1408 Remove unnecessary forward decls, that were a maintenance hassle.
1409 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1410 All uses changed.
1411 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1412 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1413 (prepare_desired_row, line_draw_cost):
1414 Use int, not unsigned, where either works.
1415 (save_current_matrix, restore_current_matrix):
1416 Use ptrdiff_t, not size_t, where either works.
1417 (init_display): Check for overflow more accurately, and without
1418 relying on undefined behavior.
1419
1420 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1421 Remove, replacing with the new symbols in lisp.h. All uses changed.
1422 * fileio.c (make_temp_name):
1423 * filelock.c (lock_file_1, lock_file):
1424 * xdisp.c (message_dolog):
1425 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1426 Use pMd etc. instead.
1427 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1428 replacing the pWIDE etc. symbols removed from editfns.c.
1429
1430 * keyboard.h (num_input_events): Now uintmax_t.
1431 This is (very slightly) less likely to mess up due to wraparound.
1432 All uses changed.
1433
1434 * buffer.c: Integer signedness fixes.
1435 (alloc_buffer_text, enlarge_buffer_text):
1436 Use ptrdiff_t rather than size_t when either will do, as we prefer
1437 signed integers.
1438
1439 * alloc.c: Integer signedness and overflow fixes.
1440 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1441 (__malloc_size_t): Default to size_t, not to int.
1442 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1443 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1444 Prefer ptrdiff_t to size_t when either would do, as we prefer
1445 signed integers.
1446 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1447 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1448 Now const. Initialize with values that are in range even if char
1449 is signed.
1450 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1451 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1452 These functions do the right thing with sizes > 2**32.
1453 (check_depth): Now ptrdiff_t, not int.
1454 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1455 Adjust to new way of storing sizes. Check for size overflow bugs
1456 in rest of code.
1457 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1458 slightly wrong anyway, as it missed one instance of
1459 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1460 (refill_memory_reserve): Omit needless cast to size_t.
1461 (mark_object_loop_halt): Mark as externally visible.
1462
1463 * xselect.c: Integer signedness and overflow fixes.
1464 (Fx_register_dnd_atom, x_handle_dnd_message):
1465 Use ptrdiff_t, not size_t, since we prefer signed.
1466 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1467 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1468 x_dnd_atoms_size and x_dnd_atoms_length.
1469
1470 * doprnt.c: Prefer signed to unsigned when either works.
1471 * eval.c (verror):
1472 * doprnt.c (doprnt):
1473 * lisp.h (doprnt):
1474 * xdisp.c (vmessage):
1475 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1476 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1477 prefer signed arithmetic to avoid comparison confusion.
1478 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1479 but is a bit tricky.
1480
1481 Assume freestanding C89 headers, string.h, stdlib.h.
1482 * data.c, doprnt.c, floatfns.c, print.c:
1483 Include float.h unconditionally.
1484 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1485 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1486 * regex.c: Likewise for stddef.h, string.h.
1487 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1488 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1489 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1490 (STDC_HEADERS): Remove obsolete defines.
1491 * sysdep.c: Include limits.h unconditionally.
1492
1493 Assume support for memcmp, memcpy, memmove, memset.
1494 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1495 * regex.c (memcmp, memcpy):
1496 Remove; we assume C89 now.
1497
1498 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1499 (__malloc_safe_bcopy): Remove; no longer needed.
1500
1501 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1502 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1503 well either way, and we prefer signed to unsigned.
1504
1505 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1506
1507 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1508 closes the connection while we're reading (bug#9182).
1509
1510 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1511
1512 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1513 are specified (Bug#9168).
1514
1515 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1518 Found by GCC static checking and --with-wide-int on a 32-bit host.
1519
1520 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1521
1522 * xdisp.c (compute_display_string_pos): Fix logic of caching
1523 previous display string position. Initialize cached_prev_pos to
1524 -1. Fixes slow-down at the beginning of a buffer.
1525
1526 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1527
1528 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1529 for attrs[LFACE_FONTSET_INDEX].
1530
1531 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 * xml.c (parse_region): Remove unused local
1534 that was recently introduced.
1535
1536 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1537
1538 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1539 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1540
1541 * xdisp.c (move_it_in_display_line_to): Record the best matching
1542 position for TO_CHARPOS while scanning the line, and restore it on
1543 exit if none of the characters scanned was an exact match.
1544 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1545 when exact match is impossible due to invisible text, and the
1546 lines are truncated.
1547
1548 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1549
1550 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1551 for OSX >= 10.7.
1552
1553 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1554
1555 Fix a significant slow-down of cursor motion with C-n, C-p,
1556 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1557 auto-repeat under bidi redisplay in fontified buffers.
1558 * xdisp.c (compute_stop_pos_backwards): New function.
1559 (next_element_from_buffer): Call compute_stop_pos_backwards to
1560 find a suitable prev_stop when we find ourselves before
1561 base_level_stop.
1562 (reseat): Don't look for prev_stop, as that could mean a very long
1563 run.
1564 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1565 <cached_disp_overlay_modiff>: Cache for last found display string
1566 position.
1567 (compute_display_string_pos): Return the cached position if asked
1568 about the same buffer in the same area of character positions, and
1569 the buffer wasn't changed since the time the display string
1570 position was cached.
1571
1572 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1573
1574 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1575 is an integer, which is important for empty lines. (Bug#9149)
1576
1577 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1578
1579 * frame.c (Fmodify_frame_parameters): In tty case, update the
1580 default face if necessary (Bug#4238).
1581
1582 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1583
1584 * editfns.c (Fstring_to_char): No need to explain what a character
1585 is in the docstring (Bug#6576).
1586
1587 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1588
1589 * xml.c (parse_region): Make sure we always return a tree.
1590
1591 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1592
1593 * xml.c (parse_region): If a document contains only comments,
1594 return that, too.
1595
1596 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1597
1598 * xml.c (make_dom): Return comments, too.
1599
1600 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1601
1602 Port to OpenBSD.
1603 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1604 and the surrounding thread.
1605 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1606 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1607 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1608 timer goes off.
1609 * s/openbsd.h (BROKEN_SIGIO): Define.
1610 * unexelf.c (unexec) [__OpenBSD__]:
1611 Don't update the .mdebug section of the Alpha COFF symbol table.
1612
1613 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1614
1615 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1616 (bug#8460).
1617
1618 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1621 This fixes some race conditions on the permissions of any newly
1622 created file.
1623
1624 * alloc.c (valid_pointer_p): Use pipe, not open.
1625 This fixes some permissions issues when debugging.
1626
1627 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1628 If fchown fails to set both uid and gid, try to set just gid,
1629 as that is sometimes allowed. Adjust the file's mode to eliminate
1630 setuid or setgid bits that are inappropriate if fchown fails.
1631
1632 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1633
1634 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1635 to compare Lisp_Objects.
1636 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1637 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1638 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1639
1640 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1641
1642 * lread.c (read_integer): Unread even EOF character.
1643 (read1): Likewise. Properly record start position of symbol.
1644
1645 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1646 symbol character follows.
1647
1648 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1649
1650 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1651 This works around a problem with the previous change to Fcopy_file.
1652 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1653 and without this change, GCC might complain about discarding
1654 fchown's return value.
1655
1656 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1657
1658 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1659
1660 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1661
1662 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1663
1664 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1665
1666 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1667 it's used from the C level.
1668
1669 * process.c: Use the same condition for POLL_FOR_INPUT in both
1670 keyboard.c and process.c (bug#1858).
1671
1672 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1673
1674 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1675 (Fgnutls_boot): Use it.
1676
1677 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1678
1679 * doc.c (Fsubstitute_command_keys): Revert last change.
1680
1681 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1682
1683 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1684 quotes the next character, and doesn't affect other longer
1685 sequences (bug#8935).
1686
1687 * lread.c (syms_of_lread): Clarify that is isn't only
1688 `eval-buffer' and `eval-defun' that's affected by
1689 `lexical-binding' (bug#8460).
1690
1691 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1692
1693 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1694 bidi redisplay when a line includes both an image and is
1695 truncated.
1696
1697 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1698
1699 Fix minor problems found by static checking.
1700 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1701 (elsz): Now a signed constant, not a size_t var. We prefer signed
1702 types to unsigned, to avoid integer comparison confusion. Without
1703 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1704 "cannot optimize loop, the loop counter may overflow", a symptom
1705 of the confusion.
1706 * indent.c (Fvertical_motion): Mark locals as initialized.
1707 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1708
1709 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1710
1711 * search.c (Fre_search_backward): Mention `case-fold-search' in
1712 all the re_search_* functions (bug#8138).
1713
1714 * keyboard.c (Fopen_dribble_file): Document when the file is
1715 closed (bug#8056).
1716
1717 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1718
1719 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1720 bidi_cache_idx.
1721
1722 Support bidi reordering of display and overlay strings.
1723 * xdisp.c (compute_display_string_pos)
1724 (compute_display_string_end): Accept additional argument STRING.
1725 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1726 (reseat_to_string): Initialize bidi_it->string.s and
1727 bidi_it->string.schars.
1728 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1729 NULL (avoids a crash in bidi_paragraph_init).
1730 Initialize itb.string.lstring.
1731 (init_iterator): Call bidi_init_it only of a valid
1732 buffer position was specified. Initialize paragraph_embedding to
1733 L2R.
1734 (reseat_to_string): Initialize the bidi iterator.
1735 (display_string): If we need to ignore text properties of
1736 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1737 original value of -1 will not work with bidi.)
1738 (compute_display_string_pos): First arg is now struct
1739 `text_pos *'; all callers changed. Support display properties on
1740 Lisp strings.
1741 (compute_display_string_end): Support display properties on Lisp
1742 strings.
1743 (init_iterator, reseat_1, reseat_to_string): Initialize the
1744 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1745 when iterating on a string not from display properties).
1746 (compute_display_string_pos, compute_display_string_end):
1747 Fix calculation of the object to scan. Fixes an error when using
1748 arrow keys.
1749 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1750 base_level_stop; instead, set base_level_stop to BEGV.
1751 Fixes crashes in vertical-motion.
1752 (next_element_from_buffer): Improve commentary for when
1753 the iterator is before prev_stop.
1754 (init_iterator): Initialize bidi_p from the default value of
1755 bidi-display-reordering, not from buffer-local value. Use the
1756 buffer-local value only if initializing for buffer iteration.
1757 (handle_invisible_prop): Support invisible properties on strings
1758 that are being bidi-reordered.
1759 (set_iterator_to_next): Support bidi reordering of C strings and
1760 Lisp strings.
1761 (next_element_from_string): Support bidi reordering of Lisp
1762 strings.
1763 (handle_stop_backwards): Support Lisp strings as well.
1764 (display_string): Support display of R2L glyph rows.
1765 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1766 (init_iterator): Don't initialize it->bidi_p for strings
1767 here.
1768 (reseat_to_string): Initialize it->bidi_p for strings here.
1769 (next_element_from_string, next_element_from_c_string)
1770 (next_element_from_buffer): Add xassert's for correspondence
1771 between IT's object being iterated and it->bidi_it.string
1772 structure.
1773 (face_before_or_after_it_pos): Support bidi iteration.
1774 (next_element_from_c_string): Handle the case of the first string
1775 character that is not the first one in the visual order.
1776 (get_visually_first_element): New function, refactored from common
1777 parts of next_element_from_buffer, next_element_from_string, and
1778 next_element_from_c_string.
1779 (tool_bar_lines_needed, redisplay_tool_bar)
1780 (display_menu_bar): Force left-to-right direction. Add a FIXME
1781 comment for making that be controlled by a user option.
1782 (push_it, pop_it): Save and restore the state of the
1783 bidi iterator. Save and restore the bidi_p flag.
1784 (pop_it): Iterate out of display property for string iteration as
1785 well.
1786 (iterate_out_of_display_property): Support iteration over strings.
1787 (handle_single_display_spec): Set up it->bidi_it for iteration
1788 over a display string, and call bidi_init_it.
1789 (handle_single_display_spec, next_overlay_string)
1790 (get_overlay_strings_1, push_display_prop): Set up the bidi
1791 iterator for displaying display or overlay strings.
1792 (forward_to_next_line_start): Don't use the shortcut if
1793 bidi-iterating.
1794 (back_to_previous_visible_line_start): If handle_display_prop
1795 pushed the iterator stack, restore the internal state of the bidi
1796 iterator by calling bidi_pop_it same number of times.
1797 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1798 and we are bidi-iterating, don't decrement the iterator position;
1799 instead, set the first_elt flag in the bidi iterator, to produce
1800 the same effect.
1801 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1802 (push_display_prop): xassert that we are iterating a buffer.
1803 (push_it, pop_it): Save and restore paragraph_embedding member.
1804 (handle_single_display_spec, next_overlay_string)
1805 (get_overlay_strings_1, reseat_1, reseat_to_string)
1806 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1807 correctly. Don't assume unibyte strings are not bidi-reordered.
1808 (compute_display_string_pos)
1809 (compute_display_string_end): Fix handling the case of C string.
1810 (push_it, pop_it): Save and restore from_disp_prop_p.
1811 (handle_single_display_spec, push_display_prop): Set the
1812 from_disp_prop_p flag.
1813 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1814 (pop_it): Call iterate_out_of_display_property only if we are
1815 popping after iteration over a string that came from a display
1816 property. Fix a typo in popping stretch info. Add an assertion
1817 for verifying that the iterator position is in sync with the bidi
1818 iterator.
1819 (handle_single_display_spec, get_overlay_strings_1)
1820 (push_display_prop): Fix initialization of paragraph direction for
1821 string when that of the parent object is not yet determined.
1822 (reseat_1): Call bidi_init_it to resync the bidi
1823 iterator with IT's position. (Bug#7616)
1824 (find_row_edges): If ROW->start.pos gives position
1825 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1826 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1827 Reset the from_disp_prop_p flag.
1828 (SAVE_IT, RESTORE_IT): New macros.
1829 (pos_visible_p, face_before_or_after_it_pos)
1830 (back_to_previous_visible_line_start)
1831 (move_it_in_display_line_to, move_it_in_display_line)
1832 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1833 (try_scrolling, redisplay_window, display_line): Use them when
1834 saving a temporary copy of the iterator and restoring it back.
1835 (back_to_previous_visible_line_start, reseat_1)
1836 (init_iterator): Empty the bidi cache "stack".
1837 (move_it_in_display_line_to): If iterator ended up at
1838 EOL, but we never saw any buffer positions smaller than
1839 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1840 motion in bidi-reordered lines.
1841 (move_it_in_display_line_to): Record prev_method and prev_pos
1842 immediately before the call to set_iterator_to_next. Fixes cursor
1843 motion in bidi-reordered lines with stretch glyphs and strings
1844 displayed in margins. (Bug#8133) (Bug#8867)
1845 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1846 TO_CHARPOS.
1847 (pos_visible_p): Support positions in bidi-reordered lines.
1848 Save and restore bidi cache.
1849
1850 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1851 (bidi_paragraph_info): Delete unused struct.
1852 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1853 (bidi_cache_start): New variable.
1854 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1855 to zero.
1856 (bidi_cache_fetch_state, bidi_cache_search)
1857 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1858 (bidi_cache_find, bidi_peek_at_next_level)
1859 (bidi_level_of_next_char, bidi_find_other_level_edge)
1860 (bidi_move_to_visually_next): Compare cache index with
1861 bidi_cache_start rather than with zero.
1862 (bidi_fetch_char): Accept new argument STRING; all callers
1863 changed. Support iteration over a string. Support strings with
1864 display properties. Support unibyte strings. Fix the type of
1865 `len' according to what STRING_CHAR_AND_LENGTH expects.
1866 (bidi_paragraph_init, bidi_resolve_explicit_1)
1867 (bidi_resolve_explicit, bidi_resolve_weak)
1868 (bidi_level_of_next_char, bidi_move_to_visually_next):
1869 Support iteration over a string.
1870 (bidi_set_sor_type, bidi_resolve_explicit_1)
1871 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1872 can now be zero (for strings); special values 0 and -1 were
1873 changed to -1 and -2, respectively.
1874 (bidi_char_at_pos): New function.
1875 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1876 Call it instead of FETCH_MULTIBYTE_CHAR.
1877 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1878 initialized to valid values.
1879 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1880 values.
1881 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1882 the test for valid cached positions. Fix the logic for looking up
1883 the sentinel state in the cache. GCPRO the Lisp string we are
1884 iterating.
1885 (bidi_push_it, bidi_pop_it): New functions.
1886 (bidi_initialize): Initialize the bidi cache start stack pointer.
1887 (bidi_cache_ensure_space): New function, refactored from part of
1888 bidi_cache_iterator_state. Don't assume the required size is just
1889 one BIDI_CACHE_CHUNK away.
1890 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1891 (bidi_count_bytes, bidi_char_at_pos): New functions.
1892 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1893 always valid if bidi_cache_idx is valid.
1894 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1895 is valid if it's going to be used.
1896 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1897 (bidi_cache_fetch_state, bidi_cache_search)
1898 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1899 (bidi_cache_iterator_state, bidi_cache_find)
1900 (bidi_find_other_level_edge, bidi_cache_start_stack):
1901 All variables related to cache indices are now EMACS_INT.
1902
1903 * dispextern.h (struct bidi_string_data): New structure.
1904 (struct bidi_it): New member `string'. Make flag members be 1-bit
1905 fields, and put them last in the struct.
1906 (compute_display_string_pos, compute_display_string_end):
1907 Update prototypes.
1908 (bidi_push_it, bidi_pop_it): Add prototypes.
1909 (struct iterator_stack_entry): New members bidi_p,
1910 paragraph_embedding, and from_disp_prop_p.
1911 (struct it): Member bidi_p is now a bit field 1 bit wide.
1912 (bidi_shelve_cache, bidi_unshelve_cache):
1913 Declare prototypes.
1914
1915 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1916 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1917 and vector-like objects.
1918
1919 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1920 cache around display iteration.
1921
1922 * window.c (Fwindow_end, window_scroll_pixel_based)
1923 (displayed_window_lines, Frecenter): Save and restore the bidi
1924 cache around display iteration.
1925
1926 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1927
1928 * editfns.c (Fdelete_region): Clarify the use of the named
1929 parameters (bug#6788).
1930
1931 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1932
1933 * indent.c (Fvertical_motion): Set and restore w->pointm when
1934 saving and restoring the window's buffer (Bug#9006).
1935
1936 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1937
1938 * editfns.c (Fstring_to_char): Clarify just what is returned
1939 (bug#6576). Text by Eli Zaretskii.
1940
1941 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1942
1943 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1944
1945 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1946
1947 * buffer.c (mmap_find): Fix a typo.
1948
1949 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1950
1951 Fix execution of x selection hooks.
1952 * xselect.c (Qx_lost_selection_functions)
1953 (Qx_sent_selection_functions): New vars.
1954 (syms_of_xselect): DEFSYM them.
1955 (x_handle_selection_request): Pass Qx_sent_selection_functions
1956 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1957 (x_handle_selection_clear,x_clear_frame_selections):
1958 Pass Qx_lost_selection_functions rather than
1959 Vx_lost_selection_functions to Frun_hook_with_args.
1960
1961 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1962
1963 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1964 The old code sometimes used this field without initializing it.
1965
1966 * alloc.c (gc_sweep): Don't read past end of array.
1967 In theory, the old code could also have corrupted Emacs internals,
1968 though it'd be very unlikely.
1969
1970 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1971
1972 * character.c (Fcharacterp): Don't advertise optional ignored
1973 argument. (Bug#4026)
1974
1975 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1976
1977 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1978 key" (bug#4257).
1979
1980 * window.c (Fset_window_start): Doc fix (bug#4199).
1981 (Fset_window_hscroll): Ditto.
1982
1983 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1984
1985 Fix minor new problems caught by GCC 4.6.1.
1986 * term.c (init_tty): Remove unused local.
1987 * xsettings.c (store_monospaced_changed): Define this function only
1988 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1989 not used otherwise.
1990
1991 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1992
1993 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1994
1995 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1996
1997 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1998 are the mini-buffer and the echo area (bug#3320).
1999
2000 * term.c (init_tty): Remove support for supdup, c10 and perq
2001 terminals, which are no longer supported (bug#1482).
2002
2003 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2004
2005 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2006
2007 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2008
2009 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2010 for non-popups (Bug#3642).
2011
2012 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2013
2014 * alloc.c (reset_malloc_hooks): Protoize.
2015 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2016 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2017 * cm.c (losecursor): Likewise.
2018 * data.c (fmod): Likewise.
2019 * dispnew.c (swap_glyphs_in_rows): Likewise.
2020 * emacs.c (memory_warning_signal): Likewise.
2021 * floatfns.c (float_error): Likewise.
2022 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2023 (otf_open, font_otf_capability, generate_otf_features)
2024 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2025 Likewise.
2026 * image.c (pbm_read_file): Likewise.
2027 * indent.c (string_display_width): Likewise.
2028 * intervals.c (check_for_interval, search_for_interval)
2029 (inc_interval_count, count_intervals, root_interval)
2030 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2031 * lread.c (defalias): Likewise.
2032 * ralloc.c (r_alloc_check): Likewise.
2033 * regex.c (set_image_of_range_1, set_image_of_range)
2034 (regex_grow_registers): Likewise.
2035 * sysdep.c (strerror): Likewise.
2036 * termcap.c (valid_filename_p, tprint, main): Likewise.
2037 * tparam.c (main): Likewise.
2038 * unexhp9k800.c (run_time_remap, save_data_space)
2039 (update_file_ptrs, read_header, write_header, calculate_checksum)
2040 (copy_file, copy_rest, display_header): Likewise.
2041 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2042 Likewise.
2043 * xdisp.c (check_it): Likewise.
2044 * xfaces.c (register_color, unregister_color, unregister_colors):
2045 Likewise.
2046 * xfns.c (print_fontset_result): Likewise.
2047 * xrdb.c (member, fatal, main): Likewise.
2048
2049 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2050
2051 Fix minor problems found by static checking (Bug#9031).
2052 * chartab.c (char_table_set_range, map_sub_char_table):
2053 Remove unused locals.
2054 (uniprop_table): Now static.
2055 * composite.c (_work_char): Remove unused static var.
2056
2057 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2058
2059 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2060
2061 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2062
2063 * gtkutil.c (qttip_cb): Remove code without function.
2064
2065 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2066
2067 * w32.c (pthread_sigmask): New stub.
2068
2069 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2070
2071 Use pthread_sigmask, not sigprocmask (Bug#9010).
2072 sigprocmask is portable only for single-threaded applications, and
2073 Emacs can be multi-threaded when it uses GTK.
2074 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2075 (LIBES): Use it.
2076 * callproc.c (Fcall_process):
2077 * process.c (create_process):
2078 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2079 Use pthread_sigmask, not sigprocmask.
2080
2081 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2082
2083 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2084 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2085 wrong (Bug#8591).
2086
2087 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2088
2089 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2090 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2091 (xg_hide_tooltip): Fix comment.
2092
2093 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2094 in registerServicesMenuSendTypes.
2095 (validRequestorForSendType): Don't check ns_return_types.
2096
2097 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2098 ns_return_type.
2099
2100 2011-07-08 Jason Rumney <jasonr@gnu.org>
2101
2102 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2103 frame struct members of non-existent frames (Bug#6284).
2104
2105 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2106
2107 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2108 variable firstTime not needed on OSX >= 10.6.
2109 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2110 >= 10.5. Use setKnobProportion, setDoubleValue.
2111
2112 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2113 (MAC_OS_X_VERSION_10_5): Define if not defined.
2114 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2115 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2116 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2117
2118 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2119 cString and lossyCString on OSX >= 10.4
2120
2121 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2122 sizeToFit on OSX >= 10.2.
2123
2124 * nsimage.m (allocInitFromFile): Don't use deprecated method
2125 bestRepresentationForDevice on OSX >= 10.6.
2126
2127 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2128 to avoid warning.
2129
2130 * emacs.c: Declare unexec_init_emacs_zone.
2131
2132 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2133
2134 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2135
2136 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2137 on svcsMenu (Bug#8842).
2138
2139 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2140 ns_return_types.
2141 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2142
2143 * nsterm.m (QUTF8_STRING): Declare.
2144 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2145 (validRequestorForSendType): Return type is (id).
2146 Change indexOfObjectIdenticalTo to indexOfObject.
2147 Check if we have local selection before returning self (Bug#8842).
2148 (writeSelectionToPasteboard): Put local selection into paste board
2149 if we have a local selection (Bug#8842).
2150 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2151
2152 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2153 (ns_get_local_selection): Declare.
2154
2155 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2156
2157 * keymap.c (describe_map_tree): Don't insert a double newline at
2158 the end of the buffer (bug#1169) and return whether we inserted
2159 something.
2160
2161 * callint.c (Fcall_interactively): Change "reading args" to
2162 "providing args" to try to clarify what it does (bug#1010).
2163
2164 2011-07-07 Kenichi Handa <handa@m17n.org>
2165
2166 * composite.c (composition_compute_stop_pos): Ignore a static
2167 composition starting before CHARPOS (Bug#8915).
2168
2169 * xdisp.c (handle_composition_prop): Likewise.
2170
2171 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2172
2173 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2174 (Bug#9015)
2175
2176 2011-07-07 Kenichi Handa <handa@m17n.org>
2177
2178 * character.h (unicode_category_t): New enum type.
2179
2180 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2181 (Qchar_code_property_table): New variable.
2182 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2183 (UNIPROP_COMPRESSED_FORM_P): New macros.
2184 (char_table_ascii): Uncompress the compressed values.
2185 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2186 Uncompress the compressed values.
2187 (sub_char_table_ref_and_range): Likewise.
2188 (char_table_ref_and_range): Uncompress the compressed values.
2189 (sub_char_table_set): New arg is_uniprop. Callers changed.
2190 Uncompress the compressed values.
2191 (sub_char_table_set_range): Args changed. Callers changed.
2192 (char_table_set_range): Adjuted for the above change.
2193 (map_sub_char_table): Delete args default_val and parent. Add arg
2194 top. Give decoded values to a Lisp function.
2195 (map_char_table): Adjust for the above change. Give decoded
2196 values to a Lisp function. Gcpro more variables.
2197 (uniprop_table_uncompress)
2198 (uniprop_decode_value_run_length): New functions.
2199 (uniprop_decoder, uniprop_decoder_count): New variables.
2200 (uniprop_get_decoder, uniprop_encode_value_character)
2201 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2202 New functions.
2203 (uniprop_encoder, uniprop_encoder_count): New variables.
2204 (uniprop_get_encoder, uniprop_table)
2205 (Funicode_property_table_internal, Fget_unicode_property_internal)
2206 (Fput_unicode_property_internal): New functions.
2207 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2208 Sunicode_property_table_internal, Sget_unicode_property_internal,
2209 and Sput_unicode_property_internal. Defvar_lisp
2210 char-code-property-alist.
2211
2212 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2213 Vunicode_category_table.
2214
2215 * font.c (font_range): Adjust for the change of
2216 Vunicode_category_table.
2217
2218 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2219
2220 * m/iris4d.h: Remove file, move contents ...
2221 * s/irix6-5.h: ... here.
2222
2223 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2224
2225 Remove unportable assumption about struct layout (Bug#8884).
2226 * alloc.c (mark_buffer):
2227 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2228 (clone_per_buffer_values): Don't assume that
2229 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2230 This isn't true in general, and it's particularly not true
2231 if Emacs is configured with --with-wide-int.
2232 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2233 New macros, used in the buffer.c change.
2234
2235 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2236
2237 * xsettings.c: Use both GConf and GSettings if both are available.
2238 (store_config_changed_event): Add comment.
2239 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2240 (store_tool_bar_style_changed): New functions.
2241 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2242 (struct xsettings): Move font inside HAVE_XFT.
2243 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2244 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2245 Move inside HAVE_XFT.
2246 (something_changed_gsettingsCB): Rename from something_changedCB.
2247 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2248 also.
2249 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2250 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2251 (something_changed_gconfCB): Rename from something_changedCB.
2252 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2253 (parse_settings): Move check for font inside HAVE_XFT.
2254 (read_settings, apply_xft_settings): Add comment.
2255 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2256 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2257 call store_font_name_changed.
2258 (xft_settings_event): Add comment.
2259 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2260 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2261 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2262 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2263 (xsettings_initialize): Call init_gsettings last.
2264 (xsettings_get_system_font, xsettings_get_system_normal_font):
2265 Add comment.
2266
2267 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2268
2269 Random fixes. E.g., (random) never returned negative values.
2270 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2271 subseconds part to the entropy, as that's a bit more random.
2272 Prefer signed to unsigned, since the signedness doesn't matter and
2273 in general we prefer signed. When given a limit, use a
2274 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2275 latter isn't right if USE_2_TAGS_FOR_INTS.
2276 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2277 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2278
2279 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2280
2281 * textprop.c (text_property_stickiness):
2282 Obey Vtext_property_default_nonsticky.
2283 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2284 * w32fns.c (syms_of_w32fns):
2285 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2286
2287 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2288
2289 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2290 This is more efficient than Ffile_directory_p and avoids a minor race.
2291
2292 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2293
2294 * buffer.c (Foverlay_put): Say what the return value is
2295 (bug#7835).
2296
2297 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2298 is a directory before asking whether to use the file name
2299 (bug#7564).
2300 (barf_or_query_if_file_exists): Make the "File is a directory"
2301 error be more correct.
2302
2303 * fns.c (Frequire): Remove the mention of the .gz files, since
2304 that's installation-specific, but keep the mention of
2305 `get-load-suffixes'.
2306
2307 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2308
2309 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2310 Report string overflow if the output is too long.
2311
2312 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2313
2314 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2315 (syms_of_gnutls): Remove duplicate DEFSYM for
2316 Qgnutls_bootprop_verify_hostname_error, an error for
2317 Qgnutls_bootprop_verify_error (which is no longer used).
2318
2319 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2320 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2321 Also (re)move comments that are misplaced or no longer relevant.
2322
2323 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2324
2325 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2326
2327 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2328
2329 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2330 and background color parameters if they have been changed.
2331
2332 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2333
2334 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2335
2336 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2337
2338 * xsettings.c (SYSTEM_FONT): Define only when used.
2339 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2340
2341 * keymap.c (access_keymap_1): Now static.
2342
2343 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2344
2345 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2346 leave any prefix arg for the up event (Bug#1586).
2347
2348 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2349
2350 * lread.c (syms_of_lread): Mention single symbols defined by
2351 `defvar' or `defconst' (bug#7154).
2352
2353 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2354 (Frequire): Mention get-load-suffixes.
2355
2356 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2357
2358 * window.h (window): Remove clone_number slot.
2359 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2360 Remove.
2361 (make_parent_window, make_window, saved_window)
2362 (Fset_window_configuration, save_window_save): Don't deal with
2363 clone numbers.
2364 * buffer.c (Qclone_number): Remove declaration.
2365 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2366
2367 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2368
2369 Add multiple inheritance to keymaps.
2370 * keymap.c (Fmake_composed_keymap): New function.
2371 (Fset_keymap_parent): Simplify.
2372 (fix_submap_inheritance): Remove.
2373 (access_keymap_1): New function extracted from access_keymap to handle
2374 embedded parents and handle lists of maps.
2375 (access_keymap): Use it.
2376 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2377 (Fcopy_keymap): Handle embedded parents.
2378 (Fcommand_remapping, define_as_prefix): Simplify.
2379 (Fkey_binding): Simplify.
2380 (syms_of_keymap): Move minibuffer-local-completion-map,
2381 minibuffer-local-filename-completion-map,
2382 minibuffer-local-must-match-map, and
2383 minibuffer-local-filename-must-match-map to Elisp.
2384 (syms_of_keymap): Defsubr make-composed-keymap.
2385 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2386 (parse_menu_item): Trivial simplification.
2387
2388 2011-07-01 Glenn Morris <rgm@gnu.org>
2389
2390 * Makefile.in (SETTINGS_LIBS): Fix typo.
2391
2392 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2393
2394 * coding.c (Fencode_coding_string): Record the last coding system
2395 used, as the function doc string says (bug#8738).
2396
2397 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2398
2399 * xsettings.c (store_monospaced_changed): Take new font as arg and
2400 check for change against current_mono_font.
2401 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2402 (emacs_settings_constructor, emacs_settings_get_property)
2403 (emacs_settings_set_property, emacs_settings_class_init)
2404 (emacs_settings_init, gsettings_obj): Remove.
2405 (something_changedCB): New function for HAVE_GSETTINGS.
2406 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2407 with value as argument.
2408 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2409 g_settings_new (Bug#8967). Do not create gsettings_obj.
2410 Remove calls to g_settings_bind. Connect something_changedCB to
2411 "changed".
2412
2413 * xgselect.c: Add defined (HAVE_GSETTINGS).
2414 (xgselect_initialize): Ditto.
2415
2416 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2417 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2418 xg_select.
2419
2420 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2421
2422 * eval.c (struct backtrace): Simplify and port the data structure.
2423 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2424 signed bit field, as this assumption is not portable and it makes
2425 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2426 "char debug_on_exit : 1" as this is not portable either; instead,
2427 use the portable "unsigned int debug_on_exit : 1". Remove unused
2428 member evalargs. Remove obsolete comments about cc bombing out.
2429
2430 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2431
2432 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2433 Let HAVE_GSETTINGS override HAVE_GCONF.
2434 (store_monospaced_changed): New function.
2435 (EMACS_SETTINGS): A new type derived from GObject to handle
2436 GSettings notifications.
2437 (emacs_settings_constructor, emacs_settings_get_property)
2438 (emacs_settings_set_property, emacs_settings_class_init):
2439 New functions.
2440 (gsettings_client, gsettings_obj): New variables.
2441 (GSETTINGS_SCHEMA): New define.
2442 (something_changedCB): Call store_monospaced_changed.
2443 (init_gsettings): New function.
2444 (xsettings_initialize): Call init_gsettings.
2445 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2446 to NULL.
2447
2448 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2449 GCONF_CFLAGS/LIBS.
2450
2451 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2452
2453 * window.c (resize_root_window, grow_mini_window)
2454 (shrink_mini_window): Rename Qresize_root_window to
2455 Qwindow_resize_root_window and Qresize_root_window_vertically to
2456 Qwindow_resize_root_window_vertically.
2457
2458 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2459
2460 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2461
2462 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2463
2464 * makefile.w32-in: Redesign dependencies so they reflect more
2465 clearly which files are directly included by each source file,
2466 and not through other includes.
2467
2468 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2469
2470 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2471 (sort_overlays, overlay_strings): When an overlay's clone number
2472 matches the window's clone number process the overlay even if
2473 the overlay's window property doesn't match the current window.
2474
2475 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2476 (Fwindow_hchild): Rename to Fwindow_left_child.
2477 (Fwindow_next): Rename to Fwindow_next_sibling.
2478 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2479 (resize_window_check): Rename to window_resize_check.
2480 (resize_window_apply): Rename to window_resize_apply.
2481 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2482 (Fdelete_other_windows_internal, resize_frame_windows)
2483 (Fsplit_window_internal, Fdelete_window_internal)
2484 (grow_mini_window, shrink_mini_window)
2485 (Fresize_mini_window_internal): Fix callers accordingly.
2486
2487 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2488
2489 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2490 (emacs_fixed_set_min_size): Remove.
2491 (emacs_fixed_new): Take frame as argument.
2492
2493 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2494 (_EmacsFixedPrivate): Remove minwidth/height.
2495 Add struct frame *f.
2496 (emacs_fixed_init): Initialize priv->f.
2497 (get_parent_class, emacs_fixed_set_min_size): Remove.
2498 (emacs_fixed_new): Set priv->f to argument.
2499 (emacs_fixed_get_preferred_width)
2500 (emacs_fixed_get_preferred_height): Use min_width/height from
2501 frames size_hint to set minimum and natural (Bug#8919).
2502 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2503 and use min_width/height from frames size_hint to set
2504 min_width/height (Bug#8919).
2505
2506 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2507 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2508 Fix indentation.
2509
2510 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2511
2512 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2513 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2514 called at ZV.
2515
2516 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2517
2518 * process.c (wait_reading_process_output): Bypass select if
2519 waiting for a cell while ignoring keyboard input, and input is
2520 pending. Suggested by Jan Djärv (Bug#8869).
2521
2522 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2523
2524 Use gnulib's dup2 module instead of rolling our own.
2525 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2526
2527 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2528
2529 * dispnew.c (scrolling_window): Before scrolling, turn off a
2530 mouse-highlight in the window being scrolled.
2531
2532 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2533
2534 Move DEFSYM to lisp.h and use everywhere.
2535
2536 * character.h (DEFSYM): Move declaration...
2537 * lisp.h (DEFSYM): ...here.
2538
2539 * gnutls.c:
2540 * minibuf.c:
2541 * w32menu.c:
2542 * w32proc.c:
2543 * w32select.c: Don't include character.h.
2544
2545 * alloc.c (syms_of_alloc):
2546 * buffer.c (syms_of_buffer):
2547 * bytecode.c (syms_of_bytecode):
2548 * callint.c (syms_of_callint):
2549 * casefiddle.c (syms_of_casefiddle):
2550 * casetab.c (init_casetab_once):
2551 * category.c (init_category_once, syms_of_category):
2552 * ccl.c (syms_of_ccl):
2553 * cmds.c (syms_of_cmds):
2554 * composite.c (syms_of_composite):
2555 * dbusbind.c (syms_of_dbusbind):
2556 * dired.c (syms_of_dired):
2557 * dispnew.c (syms_of_display):
2558 * doc.c (syms_of_doc):
2559 * editfns.c (syms_of_editfns):
2560 * emacs.c (syms_of_emacs):
2561 * eval.c (syms_of_eval):
2562 * fileio.c (syms_of_fileio):
2563 * fns.c (syms_of_fns):
2564 * frame.c (syms_of_frame):
2565 * fringe.c (syms_of_fringe):
2566 * insdel.c (syms_of_insdel):
2567 * keymap.c (syms_of_keymap):
2568 * lread.c (init_obarray, syms_of_lread):
2569 * macros.c (syms_of_macros):
2570 * msdos.c (syms_of_msdos):
2571 * print.c (syms_of_print):
2572 * process.c (syms_of_process):
2573 * search.c (syms_of_search):
2574 * sound.c (syms_of_sound):
2575 * syntax.c (init_syntax_once, syms_of_syntax):
2576 * terminal.c (syms_of_terminal):
2577 * textprop.c (syms_of_textprop):
2578 * undo.c (syms_of_undo):
2579 * w32.c (globals_of_w32):
2580 * window.c (syms_of_window):
2581 * xdisp.c (syms_of_xdisp):
2582 * xfaces.c (syms_of_xfaces):
2583 * xfns.c (syms_of_xfns):
2584 * xmenu.c (syms_of_xmenu):
2585 * xsettings.c (syms_of_xsettings):
2586 * xterm.c (syms_of_xterm): Use DEFSYM.
2587
2588 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2589
2590 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2591
2592 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2593
2594 Integer and buffer overflow fixes (Bug#8873).
2595
2596 * print.c (printchar, strout): Check for string overflow.
2597 (PRINTPREPARE, printchar, strout):
2598 Don't set size unless allocation succeeds.
2599
2600 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2601 for sizes. Check for string overflow more accurately.
2602 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2603
2604 * macros.c: Integer and buffer overflow fixes.
2605 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2606 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2607 Use ptrdiff_t, not int, for sizes.
2608 Don't increment bufsize until after realloc succeeds.
2609 Check for size-calculation overflow.
2610 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2611
2612 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2613
2614 * lread.c: Integer overflow fixes.
2615 (read_integer): Radix is now EMACS_INT, not int,
2616 to improve quality of diagnostics for out-of-range radices.
2617 Calculate buffer size correctly for out-of-range radices.
2618 (read1): Check for integer overflow in radices, and in
2619 read-circle numbers.
2620 (read_escape): Avoid int overflow.
2621 (Fload, openp, read_buffer_size, read1)
2622 (substitute_object_recurse, read_vector, read_list, map_obarray):
2623 Use ptrdiff_t, not int, for sizes.
2624 (read1): Use EMACS_INT, not int, for sizes.
2625 Check for size overflow.
2626
2627 * image.c (cache_image): Check for size arithmetic overflow.
2628
2629 * lread.c: Integer overflow issues.
2630 (saved_doc_string_size, saved_doc_string_length)
2631 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2632 Now ptrdiff_t, not int.
2633 (read1): Don't assume doc string length fits in int. Check for
2634 out-of-range doc string lengths.
2635 (read_list): Don't assume file position fits in int.
2636 (read_escape): Check for hex character overflow.
2637
2638 2011-06-22 Leo Liu <sdl.web@gmail.com>
2639
2640 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2641 Move to minibuffer.el.
2642
2643 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2646 The following patches are for when GLYPH_DEBUG && !XASSERT.
2647 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2648 * dispnew.c (flush_stdout):
2649 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2650 Mark as externally visible.
2651 * dispnew.c (check_window_matrix_pointers): Now static.
2652 * dispnew.c (window_to_frame_vpos):
2653 * xfns.c (unwind_create_frame):
2654 * xterm.c (x_check_font): Remove unused local.
2655 * scroll.c (CHECK_BOUNDS):
2656 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2657 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2658 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2659 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2660 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2661 Now static.
2662 (debug_method_add): Use va_list and vsprintf rather than relying
2663 on undefined behavior with wrong number of arguments.
2664 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2665 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2666 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2667 since we're not interested in debugging glyphs with old libraries.
2668 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2669 GCC 4.6.0's static checking.
2670
2671 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2672
2673 Integer overflow and signedness fixes (Bug#8873).
2674 A few related buffer overrun fixes, too.
2675
2676 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2677
2678 * dispextern.h (struct face.stipple):
2679 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2680 (x_bitmap_mask, x_allocate_bitmap_record)
2681 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2682 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2683 (x_create_bitmap_from_xpm_data):
2684 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2685 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2686 (.bitmaps_last):
2687 * xfaces.c (load_pixmap):
2688 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2689 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2690 (.bitmaps_last, struct x_output.icon_bitmap):
2691 Use ptrdiff_t, not int, for bitmap indexes.
2692 (x_allocate_bitmap_record): Check for size overflow.
2693 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2694
2695 Use ptrdiff_t, not int, for overlay counts.
2696 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2697 * editfns.c (overlays_around, get_pos_property):
2698 * textprop.c (get_char_property_and_overlay):
2699 * xdisp.c (next_overlay_change, note_mouse_highlight):
2700 * xfaces.c (face_at_buffer_position):
2701 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2702 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2703 (Fnext_overlay_change, Fprevious_overlay_change)
2704 (mouse_face_overlay_overlaps, Foverlays_in):
2705 Use ptrdiff_t, not int, for sizes.
2706 (overlays_at, overlays_in): Check for size-calculation overflow.
2707
2708 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2709
2710 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2711 (x_session_initialize): Do not assume string length fits in int.
2712
2713 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2714 This is unlikely, but can occur if DPI is outlandish.
2715
2716 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2717 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2718
2719 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2720 * xrdb.c (magic_file_p, search_magic_path):
2721 Omit last arg SUFFIX; it was always 0. All callers changed.
2722 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2723
2724 * xfont.c (xfont_match): Avoid need for strlen.
2725
2726 * xfns.c: Don't assume strlen fits in int.
2727 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2728
2729 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2730 not unsigned long, as we prefer signed integers. All callers changed.
2731 Detect integer overflow in repeat count.
2732 (message_dolog): Don't assume print length fits in 39 bytes.
2733 (display_mode_element): Don't assume strlen fits in int.
2734
2735 * termcap.c: Don't assume sizes fit in int and never overflow.
2736 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2737 (gobble_line): Check for size-calculation overflow.
2738
2739 * minibuf.c (Fread_buffer):
2740 * lread.c (intern, intern_c_string):
2741 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2742 Don't assume string length fits in int.
2743
2744 * keyboard.c (parse_tool_bar_item):
2745 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2746
2747 * font.c: Don't assume string length fits in int.
2748 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2749 Use ptrdiff_t, not int.
2750 (font_intern_prop): Don't assume string length fits in int.
2751 Don't assume integer property fits in fixnum.
2752 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2753
2754 * filelock.c: Fix some buffer overrun and integer overflow issues.
2755 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2756 Reformulate so as not to need the command string.
2757 Invoke gzip -cd rather than gunzip, as it's more portable.
2758 (lock_info_type, lock_file_1, lock_file):
2759 Don't assume pid_t and time_t fit in unsigned long.
2760 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2761 (current_lock_owner): Prefer signed type for sizes.
2762 Use memcpy, not strncpy, where memcpy is what is really wanted.
2763 Don't assume (via atoi) that time_t and pid_t fit in int.
2764 Check for time_t and/or pid_t out of range, e.g., via a network share.
2765 Don't alloca where an auto var works fine.
2766
2767 * fileio.c: Fix some integer overflow issues.
2768 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2769 Don't assume string length fits in int.
2770 (directory_file_name): Don't assume string length fits in long.
2771 (make_temp_name): Don't assume pid fits in int, or that its print
2772 length is less than 20.
2773
2774 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2775
2776 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2777
2778 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2779
2780 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2781 We prefer signed integers, even for size calculations.
2782
2783 * emacs.c: Don't assume string length fits in 'int'.
2784 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2785 (main): Don't invoke strlen when not needed.
2786
2787 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2788 (XD_DEBUG_MESSAGE): Don't waste a byte.
2789
2790 * callproc.c (getenv_internal_1, getenv_internal)
2791 (Fgetenv_internal):
2792 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2793
2794 * lread.c (invalid_syntax): Omit length argument.
2795 All uses changed. This doesn't fix a bug, but it simplifies the
2796 code away from its former Hollerith-constant appearance, and it's
2797 one less 'int' to worry about when looking at integer-overflow issues.
2798 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2799
2800 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2801 This didn't break anything, but it didn't help either.
2802 It's confusing to put a bogus integer in a place where the actual
2803 value does not matter.
2804 (LIST_END_P): Remove unused macro and its bogus comment.
2805 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2806
2807 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2808 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2809 implementation.
2810 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2811 We prefer signed types, and the value cannot exceed the EMACS_INT
2812 range anyway (because otherwise the length would not be representable).
2813 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2814 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2815 This avoids a GCC warning when WIDE_EMACS_INT.
2816
2817 * indent.c (sane_tab_width): New function.
2818 (current_column, scan_for_column, Findent_to, position_indentation)
2819 (compute_motion): Use it. This is just for clarity.
2820 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2821
2822 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2823
2824 * lisp.h (lint_assume): New macro.
2825 * composite.c (composition_gstring_put_cache):
2826 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2827
2828 * editfns.c, insdel.c:
2829 Omit unnecessary forward decls, to simplify future changes.
2830
2831 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2832
2833 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2834
2835 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2836 Use much-faster test for byte-length change.
2837 Don't assume string byte-length fits in 'int'.
2838 Check that character arg fits in 'int'.
2839 (mapcar1): Declare byte as byte, for clarity.
2840
2841 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2842
2843 * fns.c (concat): Catch string overflow earlier.
2844 Do not rely on integer wraparound.
2845
2846 * dispextern.h (struct it.overlay_strings_charpos)
2847 (struct it.selective): Now EMACS_INT, not int.
2848 * xdisp.c (forward_to_next_line_start)
2849 (back_to_previous_visible_line_start)
2850 (reseat_at_next_visible_line_start, next_element_from_buffer):
2851 Don't arbitrarily truncate the value of 'selective' to int.
2852
2853 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2854
2855 * composite.c: Don't truncate sizes to 'int'.
2856 (composition_gstring_p, composition_reseat_it)
2857 (composition_adjust_point): Use EMACS_INT, not int.
2858 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2859 not EMACS_UINT, for indexes.
2860
2861 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2862
2863 * buffer.c: Include <verify.h>.
2864 (struct sortvec.priority, struct sortstr.priority):
2865 Now EMACS_INT, not int.
2866 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2867 (struct sortstr.size, record_overlay_string)
2868 (struct sortstrlist.size, struct sortlist.used):
2869 Don't truncate size to int.
2870 (record_overlay_string): Check for size-calculation overflow.
2871 (init_buffer_once): Check at compile-time, not run-time.
2872
2873 2011-06-22 Jim Meyering <meyering@redhat.com>
2874
2875 Don't leak an XBM-image-sized buffer
2876 * image.c (xbm_load): Free the image buffer after using it.
2877
2878 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2879
2880 Port to Sun C.
2881 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2882 that Sun C diagnosed.
2883 * fns.c (secure_hash): Fix pointer signedness issue.
2884 * intervals.c (static_offset_intervals): New function.
2885 (offset_intervals): Use it.
2886
2887 2011-06-21 Leo Liu <sdl.web@gmail.com>
2888
2889 * deps.mk (fns.o):
2890 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2891 sha512.h.
2892
2893 * fns.c (secure_hash): Rename from crypto_hash_function and change
2894 the first arg to accept symbols.
2895 (Fsecure_hash): New primitive.
2896 (syms_of_fns): New symbols.
2897
2898 2011-06-20 Deniz Dogan <deniz@dogan.se>
2899
2900 * process.c (Fset_process_buffer): Clarify return value in
2901 docstring.
2902
2903 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2904
2905 * dispnew.c (add_window_display_history): Use BVAR.
2906
2907 * xdisp.c (debug_method_add): Use BVAR.
2908 (check_window_end, dump_glyph_matrix, dump_glyph)
2909 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2910
2911 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2912 Likewise.
2913
2914 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2915 check till after the cache is created in init_frame_faces.
2916
2917 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2918
2919 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2920
2921 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2922
2923 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2924 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2925 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2926
2927 Improve buffer-overflow checking (Bug#8873).
2928 * fileio.c (Finsert_file_contents):
2929 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2930 Remove the old (too-loose) buffer overflow checks.
2931 They weren't needed, since make_gap checks for buffer overflow.
2932 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2933 The old code merely checked for Emacs fixnum overflow, and relied
2934 on undefined (wraparound) behavior. The new code avoids undefined
2935 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2936
2937 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2938 Tune. Don't use wider integers than needed. Don't use alloca.
2939 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2940
2941 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2942
2943 * insdel.c, lisp.h (buffer_overflow): New function.
2944 (insert_from_buffer_1, replace_range, replace_range_2):
2945 * insdel.c (make_gap_larger):
2946 * editfns.c (Finsert_char):
2947 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2948
2949 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2950
2951 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2952
2953 Integer overflow and signedness fixes (Bug#8873).
2954
2955 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2956 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2957
2958 * fileio.c: Don't assume EMACS_INT fits in off_t.
2959 (emacs_lseek): New static function.
2960 (Finsert_file_contents, Fwrite_region): Use it.
2961 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2962
2963 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2964
2965 * fns.c: Don't overflow int when computing a list length.
2966 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2967 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2968 truncation on 64-bit hosts. Check for QUIT every
2969 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2970 faster and is responsive enough.
2971 (Flength): Report an error instead of overflowing an integer.
2972 (Fsafe_length): Return a float if the value is not representable
2973 as a fixnum. This shouldn't happen except in contrived situations.
2974 (Fnthcdr, Fsort): Don't assume list length fits in int.
2975 (Fcopy_sequence): Don't assume vector length fits in int.
2976
2977 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2978 (header_size, word_size): New constants.
2979 (allocate_vectorlike): Don't check size overflow here.
2980 (allocate_vector): Check it here instead, since this is the only
2981 caller of allocate_vectorlike that could cause overflow.
2982 Check that the new vector's length is representable as a fixnum.
2983
2984 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2985 The previous code was bogus. For example, next_almost_prime (32)
2986 returned 39, which is undesirable as it is a multiple of 3; and
2987 next_almost_prime (24) returned 25, which is a multiple of 5 so
2988 why was the code bothering to check for multiples of 7?
2989
2990 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2991
2992 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2993
2994 Variadic C functions now count arguments with ptrdiff_t.
2995 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2996 Back then I didn't know that the Emacs coding style prefers signed int.
2997 Also, in the meantime I found a few more instances where arguments
2998 were being counted with int, which may truncate counts on 64-bit
2999 machines, or EMACS_INT, which may be unnecessarily wide.
3000 * lisp.h (struct Lisp_Subr.function.aMANY)
3001 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3002 Arg counts are now ptrdiff_t, not size_t.
3003 All variadic functions and their callers changed accordingly.
3004 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3005 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3006 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3007 * callint.c (Fcall_interactively): Check arg count for overflow,
3008 to avoid potential buffer overrun. Use signed char, not 'int',
3009 for 'varies' array, so that we needn't bother to check its size
3010 calculation for overflow.
3011 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3012 * eval.c (apply_lambda):
3013 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3014 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3015 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3016
3017 * callint.c (Fcall_interactively): Don't use index var as event count.
3018
3019 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3020 * mem-limits.h (SIZE): Remove; no longer used.
3021
3022 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3023
3024 Remove unnecessary casts.
3025 * xterm.c (x_term_init):
3026 * xfns.c (x_set_border_pixel):
3027 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3028 These aren't needed now that we assume ANSI C.
3029
3030 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3031 It's more likely to cause problems (due to unsigned overflow)
3032 than to cure them.
3033
3034 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3035
3036 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3037
3038 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3039
3040 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3041
3042 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3043
3044 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3045
3046 GLYPH_CODE_FACE returns EMACS_INT, not int.
3047 * dispextern.h (merge_faces):
3048 * xfaces.c (merge_faces):
3049 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3050 Don't assume EMACS_INT fits in int.
3051
3052 * character.h (CHAR_VALID_P): Remove unused parameter.
3053 * fontset.c, lisp.h, xdisp.c: All uses changed.
3054
3055 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3056
3057 * fns.c (concat): Minor tuning based on overflow analysis.
3058 This doesn't fix any bugs. Use int to hold character, instead
3059 of constantly refetching from Emacs object. Use XFASTINT, not
3060 XINT, for value known to be a character. Don't bother comparing
3061 a single byte to 0400, as it's always less.
3062
3063 * floatfns.c (Fexpt):
3064 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3065
3066 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3067 for characters.
3068
3069 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3070
3071 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3072 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3073 incorrectly succeed when S was a string, because 4294967386 was
3074 truncated before it was used.
3075
3076 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3077 Otherwise, an out-of-range integer could cause undefined behavior
3078 on a 64-bit host.
3079
3080 * composite.c: Use int, not EMACS_INT, for characters.
3081 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3082 EMACS_INT, for values that are known to be in character range.
3083 This doesn't fix any bugs but is the usual style inside Emacs and
3084 may generate better code on 32-bit machines.
3085
3086 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3087 This is for reasons similar to the recent CHAR_STRING fix.
3088 * charset.c (Fencode_char): Check that character arg is actually
3089 a character. Pass an int to ENCODE_CHAR.
3090 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3091 wider than 'int', as a compile-time check to prevent future regressions
3092 in this area.
3093
3094 * character.c (char_string): Remove unnecessary casts.
3095
3096 Make sure a 64-bit char is never passed to CHAR_STRING.
3097 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3098 by silently ignoring the top 32 bits, allowing some values
3099 that were far too large to be valid characters.
3100 * character.h: Include <verify.h>.
3101 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3102 arguments are no wider than unsigned, as a compile-time check
3103 to prevent future regressions in this area.
3104 * data.c (Faset):
3105 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3106 (Fsubst_char_in_region):
3107 * fns.c (concat):
3108 * xdisp.c (decode_mode_spec_coding):
3109 Adjust to CHAR_STRING's new requirement.
3110 * editfns.c (Finsert_char, Fsubst_char_in_region):
3111 * fns.c (concat): Check that character args are actually
3112 characters. Without this test, these functions did the wrong
3113 thing with wildly out-of-range values on 64-bit hosts.
3114
3115 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3116 These casts should not be needed on 32-bit hosts, either.
3117 * keyboard.c (read_char):
3118 * lread.c (Fload): Remove casts to unsigned.
3119
3120 * lisp.h (UNSIGNED_CMP): New macro.
3121 This fixes comparison bugs on 64-bit hosts.
3122 (ASCII_CHAR_P): Use it.
3123 * casefiddle.c (casify_object):
3124 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3125 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3126 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3127 * dispextern.h (FACE_FROM_ID):
3128 * keyboard.c (read_char): Use UNSIGNED_CMP.
3129
3130 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3131 not to EMACS_INT, to avoid GCC warning.
3132
3133 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3134
3135 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3136 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3137 isn't needed on 32-bit machines.
3138
3139 * buffer.c (Fgenerate_new_buffer_name):
3140 Use EMACS_INT for count, not int.
3141 (advance_to_char_boundary): Return EMACS_INT, not int.
3142
3143 * data.c (Qcompiled_function): Now static.
3144
3145 * window.c (window_body_lines): Now static.
3146
3147 * image.c (gif_load): Rename local to avoid shadowing.
3148
3149 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3150 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3151 * alloc.c (make_save_value): Integer argument is now of type
3152 ptrdiff_t, not int.
3153 (mark_object): Use ptrdiff_t, not int.
3154 * lisp.h (pD): New macro.
3155 * print.c (print_object): Use it.
3156
3157 * alloc.c: Use EMACS_INT, not int, to count objects.
3158 (total_conses, total_markers, total_symbols, total_vector_size)
3159 (total_free_conses, total_free_markers, total_free_symbols)
3160 (total_free_floats, total_floats, total_free_intervals)
3161 (total_intervals, total_strings, total_free_strings):
3162 Now EMACS_INT, not int. All uses changed.
3163 (Fgarbage_collect): Compute overall total using a double, so that
3164 integer overflow is less likely to be a problem. Check for overflow
3165 when converting back to an integer.
3166 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3167 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3168 These were 'int' variables that could overflow on 64-bit hosts;
3169 they were never used, so remove them instead of repairing them.
3170 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3171 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3172 Previously, this ceilinged at INT_MAX, but that doesn't work on
3173 64-bit machines.
3174 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3175
3176 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3177 (allocate_vectorlike): Check for ptrdiff_t overflow.
3178 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3179 when a (possibly-narrower) signed value would do just as well.
3180 We prefer using signed arithmetic, to avoid comparison confusion.
3181
3182 * alloc.c: Catch some string size overflows that we were missing.
3183 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3184 for convenience in STRING_BYTES_MAX.
3185 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3186 The definition here is exact; the one in lisp.h was approximate.
3187 (allocate_string_data): Check for string overflow. This catches
3188 some instances we weren't catching before. Also, it catches
3189 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3190 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3191 and ptrdiff_t and EMACS_INT are both 64 bits.
3192
3193 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3194 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3195 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3196
3197 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3198
3199 * alloc.c (Fmake_string): Check for out-of-range init.
3200
3201 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3202
3203 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3204
3205 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3206
3207 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3208 xg_get_default_scrollbar_width.
3209
3210 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3211 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3212 (style_changed_cb): Call update_theme_scrollbar_width and call
3213 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3214 all frames (Bug#8505).
3215 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3216 Call gtk_window_set_resizable if HAVE_GTK3.
3217 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3218 and height if HAVE_GTK3 (Bug#8505).
3219 (scroll_bar_width_for_theme): New variable.
3220 (update_theme_scrollbar_width): New function.
3221 (xg_get_default_scrollbar_width): Move code to
3222 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3223 (xg_initialize): Call update_theme_scrollbar_width.
3224
3225 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3226
3227 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3228
3229 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3230
3231 * frame.c (make_frame): Call other_buffer_safely instead of
3232 other_buffer.
3233
3234 * window.c (temp_output_buffer_show): Call display_buffer with
3235 second argument Vtemp_buffer_show_specifiers and reset latter
3236 immediately after the call.
3237 (Vtemp_buffer_show_specifiers): New variable.
3238 (auto_window_vscroll_p, next_screen_context_lines)
3239 (Vscroll_preserve_screen_position): Remove leading asterisks from
3240 doc-strings.
3241
3242 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3243
3244 Fix minor problems found by GCC 4.6.0 static checking.
3245 * buffer.c (Qclone_number): Remove for now, as it's unused.
3246 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3247 (record_buffer): Remove unused local.
3248 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3249 (set_frame_buffer_list): Remove; unused.
3250 * frame.h (other_visible_frames): Remove decl.
3251 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3252 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3253 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3254 if HAVE_GPM.
3255 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3256 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3257 Define only if HAVE_GPM.
3258 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3259 (update_hints_inhibit): Remove; never set. All uses removed.
3260 * widgetprv.h (emacsFrameClassRec): Remove decl.
3261 * window.c (delete_deletable_window): Now returns void, since it
3262 wasn't returning anything.
3263 (compare_window_configurations): Remove unused locals.
3264 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3265 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3266 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3267 the same widths as pointers. This follows up on the 2011-05-06 patch.
3268 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3269 * xterm.h: Likewise.
3270 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3271
3272 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3273
3274 * makefile.w32-in: Update dependencies.
3275 (LISP_H): Add lib/intprops.h.
3276
3277 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3278
3279 * image.c (gif_load): Add animation frame delay to the metadata.
3280 (syms_of_image): Use DEFSYM. New symbol `delay'.
3281
3282 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3283
3284 * window.c (delete_deletable_window): Re-add.
3285 (Fset_window_configuration): Rewrite to handle dead buffers and
3286 consequently deletable windows.
3287 (window_tree, Fwindow_tree): Remove. Supply functionality in
3288 window.el.
3289 (compare_window_configurations): Simplify code.
3290
3291 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3292
3293 * image.c (imagemagick_load_image): Fix type mismatch.
3294 (Fimagemagick_types): Likewise.
3295
3296 * window.h (replace_buffer_in_windows): Declare.
3297
3298 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3299
3300 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3301 Qclone_number. Remove external declaration of Qdelete_window.
3302 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3303 code.
3304 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3305 Run Qbuffer_list_update_hook if allowed.
3306 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3307 buffer list implementation.
3308 (other_buffer_safely): New function.
3309 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3310 calls to replace_buffer_in_windows and
3311 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3312 if allowed.
3313 (record_buffer): Inhibit quitting and rewrite using quittable
3314 functions. Run Qbuffer_list_update_hook if allowed.
3315 (Frecord_buffer, Funrecord_buffer): New functions.
3316 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3317 Move switch-to-buffer to window.el.
3318 (bury-buffer): Move to window.el.
3319 (Vbuffer_list_update_hook): New variable.
3320
3321 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3322 section.
3323
3324 * window.h (resize_frame_windows): Move up in code.
3325 (Fwindow_frame): Remove EXFUN.
3326 (replace_buffer_in_all_windows): Remove prototype.
3327 (replace_buffer_in_windows_safely): Add prototype.
3328
3329 * window.c: Declare Qdelete_window static again. Move down
3330 declaration of select_count.
3331 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3332 (Fother_window): Move to window.el.
3333 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3334 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3335 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3336 window.el.
3337 (replace_buffer_in_windows): Implement by calling
3338 Qreplace_buffer_in_windows.
3339 (replace_buffer_in_all_windows): Remove with some functionality
3340 moved into replace_buffer_in_windows_safely.
3341 (replace_buffer_in_windows_safely): New function.
3342 (select_window_norecord, select_frame_norecord): Move in front
3343 of run_window_configuration_change_hook. Remove now obsolete
3344 declarations.
3345 (Fset_window_buffer): Rewrite doc-string.
3346 Call Qrecord_window_buffer.
3347 (keys_of_window): Move binding for other-window to window.el.
3348
3349 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3350
3351 * dispextern.h (struct image): Replace data member, whose int_val
3352 and ptr_val fields were not used by anything, with a single
3353 lisp_val object.
3354
3355 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3356 (gif_clear_image, gif_load, imagemagick_load_image)
3357 (gs_clear_image, gs_load): Callers changed.
3358
3359 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3360
3361 * buffer.h: Include <time.h>, for time_t.
3362 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3363
3364 Fix minor problems found by static checking.
3365
3366 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3367
3368 Make identifiers static if they are not used in other modules.
3369 * data.c (Qcompiled_function, Qframe, Qvector):
3370 * image.c (QimageMagick, Qsvg):
3371 * minibuf.c (Qmetadata):
3372 * window.c (resize_window_check, resize_root_window): Now static.
3373 * window.h (resize_window_check, resize_root_window): Remove decls.
3374
3375 * window.c (window_deletion_count, delete_deletable_window):
3376 Remove; unused.
3377 (window_body_lines): Now static.
3378 (Fdelete_other_windows_internal): Mark vars as initialized.
3379 Make sure 'resize_failed' is initialized.
3380 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3381 (resize_window_apply): Remove unused local.
3382 * window.h (delete_deletable_window): Remove decl.
3383
3384 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3385 (imagemagick_load_image): Fix pointer signedness problem by changing
3386 last arg from unsigned char * to char *. All uses changed.
3387 Also, fix a local for similar reasons.
3388 Remove unused locals. Remove locals to avoid shadowing.
3389 (fn_rsvg_handle_free): Remove; unused.
3390 (svg_load, svg_load_image): Fix pointer signedness problem.
3391 (imagemagick_load_image): Don't use garbage pointer image_wand.
3392
3393 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3394
3395 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3396
3397 * image.c (gif_load): Fix omitted cast error introduced by
3398 2011-06-06 change.
3399
3400 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3401
3402 * window.h (resize_proportionally, orig_total_lines)
3403 (orig_top_line): Remove from window structure.
3404 (set_window_height, set_window_width, change_window_heights)
3405 (Fdelete_window): Remove prototypes.
3406 (resize_frame_windows): Remove duplicate declaration.
3407
3408 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3409
3410 * window.h (resize_frame_windows, resize_window_check)
3411 (delete_deletable_window, resize_root_window)
3412 (resize_frame_windows): Declare prototypes.
3413
3414 * window.c (resize_window_apply): Make definition be "static" to
3415 match the prototype.
3416
3417 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3418
3419 * window.c: Remove declarations of Qwindow_size_fixed,
3420 window_min_size_1, window_min_size_2, window_min_size,
3421 size_window, window_fixed_size_p, enlarge_window, delete_window.
3422 Remove static from declaration of Qdelete_window, it's
3423 temporarily needed by Fbury_buffer.
3424 (replace_window): Don't assign orig_top_line and
3425 orig_total_lines.
3426 (Fdelete_window, delete_window): Remove. Window deletion is
3427 handled by window.el.
3428 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3429 Replace Fdelete_window calls with calls to Qdelete_window.
3430 (Fdelete_other_windows): Remove. Deleting other windows is
3431 handled by window.el.
3432 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3433 handled in window.el.
3434 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3435 Window minimum sizes are handled in window.el.
3436 (shrink_windows, size_window, set_window_height)
3437 (set_window_width, change_window_heights, window_height)
3438 (window_width, CURBEG, CURSIZE, enlarge_window)
3439 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3440 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3441 handled in window.el.
3442 (make_dummy_parent): Rename to make_parent_window and give it a
3443 second argument horflag.
3444 (make_window): Don't set resize_proportionally any more.
3445 (Fsplit_window): Remove. Windows are split in window.el.
3446 (save_restore_action, save_restore_orig_size)
3447 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3448 Resize mini windows in window.el.
3449 (grow_mini_window, shrink_mini_window): Implement by calling
3450 Qresize_root_window_vertically, resize_window_check and
3451 resize_window_apply.
3452 (saved_window, Fset_window_configuration, save_window_save):
3453 Do not handle orig_top_line, orig_total_lines, and
3454 resize_proportionally.
3455 (window_min_height, window_min_width): Move to window.el.
3456 (keys_of_window): Move bindings for delete-other-windows,
3457 split-window, delete-window and enlarge-window to window.el.
3458
3459 * buffer.c: Temporarily extern Qdelete_window.
3460 (Fbury_buffer): Temporarily call Qdelete_window instead of
3461 Fdelete_window (Fbury_buffer will move to window.el soon).
3462
3463 * frame.c (set_menu_bar_lines_1): Remove code handling
3464 orig_top_line and orig_total_lines.
3465
3466 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3467 set_window_height but set heights directly.
3468 (change_frame_size_1): Use resize_frame_windows.
3469
3470 * xdisp.c (init_xdisp): Don't use set_window_height but set
3471 heights directly.
3472
3473 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3474 Use resize_frame_windows instead of change_window_heights and run
3475 run_window_configuration_change_hook.
3476
3477 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3478 instead of change_window_heights and run
3479 run_window_configuration_change_hook.
3480
3481 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3482
3483 * window.c (replace_window): Rename second argument REPLACEMENT to
3484 NEW. New third argument SETFLAG. Rewrite.
3485 (delete_window, make_dummy_parent): Call replace_window with
3486 third argument 1.
3487 (window_list_1): Move down in code.
3488 (run_window_configuration_change_hook): Move set_buffer part
3489 before select_frame_norecord part in order to unwind correctly.
3490 Rename count1 to count.
3491 (recombine_windows, delete_deletable_window, resize_root_window)
3492 (Fdelete_other_windows_internal)
3493 (Frun_window_configuration_change_hook, make_parent_window)
3494 (resize_window_check, resize_window_apply, Fresize_window_apply)
3495 (resize_frame_windows, Fsplit_window_internal)
3496 (Fdelete_window_internal, Fresize_mini_window_internal):
3497 New functions.
3498 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3499
3500 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3501
3502 * window.h (window): Add some new members to window structure -
3503 normal_lines, normal_cols, new_total, new_normal, clone_number,
3504 splits, nest, prev_buffers, next_buffers.
3505 (WINDOW_TOTAL_SIZE): Move here from window.c.
3506 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3507
3508 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3509 Remove.
3510 (make_dummy_parent): Set new members of windows structure.
3511 (make_window): Move down in code. Handle new members of window
3512 structure.
3513 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3514 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3515 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3516 (Fset_window_prev_buffers, Fwindow_next_buffers)
3517 (Fset_window_next_buffers, Fset_window_clone_number):
3518 New functions.
3519 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3520 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3521 Doc-string fixes.
3522 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3523 Argument WINDOW can be now internal window too.
3524 (Fwindow_use_time): Move up in code.
3525 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3526 Rewrite doc-string.
3527 (Fset_window_configuration, saved_window)
3528 (Fcurrent_window_configuration, save_window_save): Handle new
3529 members of window structure.
3530 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3531 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3532 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3533 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3534 Qget_mru_window, Qresize_root_window,
3535 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3536 Qauto_buffer_name; staticpro them.
3537
3538 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3539
3540 * window.c (Fwindow_total_size, Fwindow_left_column)
3541 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3542 (Fwindow_list_1): New functions.
3543 (window_box_text_cols): Replace with window_body_cols.
3544 (Fwindow_width, Fscroll_left, Fscroll_right):
3545 Use window_body_cols instead of window_box_text_cols.
3546 (delete_window, Fset_window_configuration):
3547 Call delete_all_subwindows with window as argument.
3548 (delete_all_subwindows): Take a window as argument and not a
3549 structure. Rewrite.
3550 (window_loop): Remove handling of GET_LRU_WINDOW and
3551 GET_LARGEST_WINDOW.
3552 (Fget_lru_window, Fget_largest_window): Move to window.el.
3553
3554 * window.h: Extern window_body_cols instead of
3555 window_box_text_cols. delete_all_subwindows now takes a
3556 Lisp_Object as argument.
3557
3558 * indent.c (compute_motion, Fcompute_motion):
3559 Use window_body_cols instead of window_box_text_cols.
3560
3561 * frame.c (delete_frame): Call delete_all_subwindows with root
3562 window as argument.
3563
3564 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3565
3566 * fns.c (Fputhash): Document return value.
3567
3568 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3569
3570 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3571
3572 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3573
3574 Cons<->int and similar integer overflow fixes (Bug#8794).
3575
3576 Check for overflow when converting integer to cons and back.
3577 * charset.c (Fdefine_charset_internal, Fdecode_char):
3578 Use cons_to_unsigned to catch overflow.
3579 (Fencode_char): Use INTEGER_TO_CONS.
3580 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3581 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3582 * data.c (long_to_cons, cons_to_long): Remove.
3583 (cons_to_unsigned, cons_to_signed): New functions.
3584 These signal an error for invalid or out-of-range values.
3585 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3586 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3587 * font.c (Ffont_variation_glyphs):
3588 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3589 * lisp.h: Include <intprops.h>.
3590 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3591 (cons_to_signed, cons_to_unsigned): New decls.
3592 (long_to_cons, cons_to_long): Remove decls.
3593 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3594 (Fprimitive_undo): Use CONS_TO_INTEGER.
3595 * xfns.c (Fx_window_property): Likewise.
3596 * xselect.c: Include <limits.h>.
3597 (x_own_selection, selection_data_to_lisp_data):
3598 Use INTEGER_TO_CONS.
3599 (x_handle_selection_request, x_handle_selection_clear)
3600 (x_get_foreign_selection, Fx_disown_selection_internal)
3601 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3602 (lisp_data_to_selection_data): Use cons_to_unsigned.
3603 (x_fill_property_data): Use cons_to_signed.
3604 Report values out of range.
3605
3606 Check for buffer and string overflow more precisely.
3607 * buffer.h (BUF_BYTES_MAX): New macro.
3608 * lisp.h (STRING_BYTES_MAX): New macro.
3609 * alloc.c (Fmake_string):
3610 * character.c (string_escape_byte8):
3611 * coding.c (coding_alloc_by_realloc):
3612 * doprnt.c (doprnt):
3613 * editfns.c (Fformat):
3614 * eval.c (verror):
3615 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3616 since they may not be the same number.
3617 * editfns.c (Finsert_char):
3618 * fileio.c (Finsert_file_contents):
3619 Likewise for BUF_BYTES_MAX.
3620
3621 * image.c: Use ptrdiff_t, not int, for sizes.
3622 (slurp_file): Switch from int to ptrdiff_t.
3623 All uses changed.
3624 (slurp_file): Check that file size fits in both size_t (for
3625 malloc) and ptrdiff_t (for sanity and safety).
3626
3627 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3628 if b->modtime has its maximal value.
3629
3630 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3631
3632 Don't assume time_t can fit into int.
3633 * buffer.h (struct buffer.modtime): Now time_t, not int.
3634 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3635 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3636
3637 Minor fixes for signed vs unsigned integers.
3638 * character.h (MAYBE_UNIFY_CHAR):
3639 * charset.c (maybe_unify_char):
3640 * keyboard.c (read_char, reorder_modifiers):
3641 XINT -> XFASTINT, since the integer must be nonnegative.
3642 * ftfont.c (ftfont_spec_pattern):
3643 * keymap.c (access_keymap, silly_event_symbol_error):
3644 XUINT -> XFASTINT, since the integer must be nonnegative.
3645 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3646 since it makes no difference and we prefer signed.
3647 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3648 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3649 nonnegative.
3650
3651 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3652
3653 * window.h (Fwindow_frame): Declare.
3654
3655 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3658 (SPARE_MEMORY): Always define.
3659 (LARGE_REQUEST): Remove.
3660 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3661
3662 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3663
3664 * lisp.h: Move EXFUNS for Fframe_root_window,
3665 Fframe_first_window and Fset_frame_selected_window to window.h.
3666
3667 * window.h: Move EXFUNS for Fframe_root_window,
3668 Fframe_first_window and Fset_frame_selected_window here from
3669 lisp.h.
3670
3671 * frame.c (Fwindow_frame, Fframe_first_window)
3672 (Fframe_root_window, Fframe_selected_window)
3673 (Fset_frame_selected_window): Move to window.c.
3674 (Factive_minibuffer_window): Move to minibuf.c.
3675 (Fother_visible_frames_p): New function.
3676
3677 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3678
3679 * window.c (decode_window, decode_any_window): Move up in code.
3680 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3681 (inhibit_frame_unsplittable): Remove unused variable.
3682 (Fwindow_buffer): Move up and rewrite doc-string.
3683 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3684 (Fwindow_prev): New functions.
3685 (Fwindow_frame): Move here from frame.c. Accept any window as
3686 argument.
3687 (Fframe_root_window, Fframe_first_window)
3688 (Fframe_selected_window): Move here from frame.c. Accept frame
3689 or arbitrary window as argument. Update doc-strings.
3690 (Fminibuffer_window): Move up in code.
3691 (Fwindow_minibuffer_p): Move up in code and simplify.
3692 (Fset_frame_selected_window): Move here from frame.c.
3693 Marginal rewrite.
3694 (Fselected_window, select_window, Fselect_window): Move up in
3695 code. Minor doc-string fixes.
3696
3697 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3698
3699 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3700 Do not assume that spare memory exists; that assumption is valid
3701 only if SYSTEM_MALLOC.
3702 (LARGE_REQUEST): New macro, so that the issue of large requests
3703 is separated from the issue of spare memory.
3704
3705 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3706
3707 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3708 format. (Bug#8806)
3709
3710 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3711
3712 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3713 before statements.
3714
3715 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3716
3717 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3718
3719 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3720
3721 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3722 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3723
3724 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3725
3726 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3727
3728 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3729
3730 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3731 (x_clipboard_manager_save): Add return value.
3732 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3733 New error handlers.
3734 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3735 Obey Vx_select_enable_clipboard_manager. Catch errors in
3736 x_clipboard_manager_save (Bug#8779).
3737 (Vx_select_enable_clipboard_manager): New variable.
3738 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3739
3740 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3741
3742 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3743
3744 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3745
3746 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3747 in the current matrix if keep_current_p is non-zero.
3748
3749 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3750
3751 * bidi.c (bidi_level_of_next_char): Fix last change.
3752
3753 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3754
3755 Support bidi reordering of text covered by display properties.
3756
3757 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3758 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3759 (bidi_cache_search, bidi_cache_iterator_state)
3760 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3761 (bidi_level_of_next_char, bidi_move_to_visually_next):
3762 Support character positions inside a run of characters covered by a
3763 display string.
3764 (bidi_paragraph_init, bidi_resolve_explicit_1)
3765 (bidi_level_of_next_char): Call bidi_fetch_char and
3766 bidi_fetch_char_advance instead of FETCH_CHAR and
3767 FETCH_CHAR_ADVANCE.
3768 (bidi_init_it): Initialize new members.
3769 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3770 definitions.
3771 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3772 instead of using explicit *_CHAR codes.
3773 (bidi_resolve_explicit, bidi_resolve_weak):
3774 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3775 bidirectional text is supported only in multibyte buffers.
3776 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3777 it to initialize the frame_window_p member of struct bidi_it.
3778 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3779 (bidi_resolve_explicit, bidi_resolve_weak)
3780 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3781 bidi_it->nchars is non-positive.
3782 (bidi_level_of_next_char): Don't try to lookup the cache for the
3783 next/previous character if nothing is cached there yet, or if we
3784 were just reseat()'ed to a new position.
3785
3786 * xdisp.c (set_cursor_from_row): Set start and stop points
3787 according to the row's direction when priming the loop that looks
3788 for the glyph on which to display cursor.
3789 (single_display_spec_intangible_p): Function deleted.
3790 (display_prop_intangible_p): Reimplement to call
3791 handle_display_spec instead of single_display_spec_intangible_p.
3792 Accept 3 additional arguments needed by handle_display_spec.
3793 This fixes incorrect cursor motion across display property with complex
3794 values: lists, `(when COND...)' forms, etc.
3795 (single_display_spec_string_p): Support property values that are
3796 lists with the argument STRING its top-level element.
3797 (display_prop_string_p): Fix the condition for processing a
3798 property that is a list to be consistent with handle_display_spec.
3799 (handle_display_spec): New function, refactored from the
3800 last portion of handle_display_prop.
3801 (compute_display_string_pos): Accept additional argument
3802 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3803 value of a `display' property is a "replacing spec".
3804 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3805 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3806 the display property, but just return a value indicating whether
3807 the display property will replace the characters it covers.
3808 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3809 frame_window_p members of struct bidi_it.
3810 (compute_display_string_pos, compute_display_string_end):
3811 New functions.
3812 (push_it): Accept second argument POSITION, where pop_it should
3813 jump to continue iteration.
3814 (reseat_1): Initialize bidi_it.disp_pos.
3815
3816 * keyboard.c (adjust_point_for_property): Adjust the call to
3817 display_prop_intangible_p to its new signature.
3818
3819 * dispextern.h (struct bidi_it): New member frame_window_p.
3820 (bidi_init_it): Update prototypes.
3821 (display_prop_intangible_p): Update prototype.
3822 (compute_display_string_pos, compute_display_string_end):
3823 Declare prototypes.
3824 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3825 EMACS_INT.
3826
3827 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3828
3829 Malloc failure behavior now depends on size of allocation.
3830 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3831 * lisp.h: Change signatures accordingly.
3832 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3833 All callers changed. (Bug#8762)
3834
3835 * gnutls.c: Use Emacs's memory allocators.
3836 Without this change, the gnutls library would invoke malloc etc.
3837 directly, which causes problems on non-SYNC_INPUT hosts, and which
3838 runs afoul of improving memory_full behavior. (Bug#8761)
3839 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3840 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3841 xfree instead of the default malloc, realloc, free.
3842 (Fgnutls_boot): No need to check for memory allocation failure,
3843 since xmalloc does that for us.
3844
3845 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3846 * category.c (hash_get_category_set):
3847 * ccl.c (ccl_driver):
3848 * charset.c (Fdefine_charset_internal):
3849 * charset.h (struct charset.hash_index):
3850 * composite.c (get_composition_id, gstring_lookup_cache)
3851 (composition_gstring_put_cache):
3852 * composite.h (struct composition.hash_index):
3853 * dispextern.h (struct image.hash):
3854 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3855 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3856 (hashfn_equal, hashfn_user_defined, make_hash_table)
3857 (maybe_resize_hash_table, hash_lookup, hash_put)
3858 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3859 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3860 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3861 * image.c (make_image, search_image_cache, lookup_image)
3862 (xpm_put_color_table_h):
3863 * lisp.h (struct Lisp_Hash_Table):
3864 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3865 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3866 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3867 * alloc.c (allocate_vectorlike):
3868 Check for overflow in vector size calculations.
3869 * ccl.c (ccl_driver):
3870 Check for overflow when converting EMACS_INT to int.
3871 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3872 need to be updated by these changes.
3873 * fns.c (make_hash_table, maybe_resize_hash_table):
3874 Check for integer overflow with large hash tables.
3875 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3876 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3877 (SXHASH_REDUCE): New macro.
3878 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3879 Use it instead of discarding useful hash info with large hash values.
3880 (sxhash_float): New function.
3881 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3882 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3883 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3884 Rewrite to use FIXNUM_BITS, as this simplifies things.
3885 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3886 Adjust signatures to match updated version of code.
3887 (consing_since_gc): Now EMACS_INT, since a single hash table can
3888 use more than INT_MAX bytes.
3889
3890 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3891
3892 Make it possible to build with GCC-4.6+ -O2 -flto.
3893
3894 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3895
3896 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3897
3898 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3899 Call minibuffer-inactive-mode.
3900
3901 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3902
3903 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3904 Update dependencies.
3905
3906 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3907
3908 * data.c (init_data): Remove code for UTS, this system is not
3909 supported anymore.
3910
3911 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3912
3913 Don't force ./temacs to start in terminal mode.
3914
3915 * frame.c (make_initial_frame): Initialize faces in all cases, not
3916 only when CANNOT_DUMP is defined.
3917 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3918
3919 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3920
3921 * dispnew.c (add_window_display_history): Use const for the string
3922 pointer. Remove declaration, not needed.
3923
3924 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3925
3926 Use 'inline', not 'INLINE'.
3927 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3928 * alloc.c, fontset.c (INLINE): Remove.
3929 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3930 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3931 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3932 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3933 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3934
3935 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3936
3937 Make it possible to run ./temacs.
3938
3939 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3940 syms_of_callproc does the same thing. Remove test for
3941 "initialized", do it in the caller.
3942 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3943
3944 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3945
3946 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3947 (read_minibuf): Use get_minibuffer.
3948 (syms_of_minibuf): Use DEFSYM.
3949 (Qmetadata): New var.
3950 * data.c (Qbuffer): Don't make it static.
3951 (syms_of_data): Use DEFSYM.
3952
3953 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3954
3955 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3956 (CCL_CODE_MIN): New macro.
3957
3958 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3959
3960 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3961
3962 * eval.c (Qdebug): Now static.
3963 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3964 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3965 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3966
3967 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3968
3969 * image.c: Various fixes to ImageMagick code comments.
3970 (Fimagemagick_types): Doc fix.
3971
3972 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3973
3974 Minor fixes prompted by GCC 4.6.0 warnings.
3975
3976 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3977
3978 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3979 (x_clipboard_manager_save_all): Move extern decl to ...
3980 * xterm.h: ... here, so that it can be checked for consistency.
3981
3982 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3983
3984 * xselect.c (x_clipboard_manager_save_frame)
3985 (x_clipboard_manager_save_all): New functions.
3986 (Fx_clipboard_manager_save): Lisp function deleted.
3987
3988 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3989 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3990
3991 * xterm.h: Update prototype.
3992
3993 2011-05-28 William Xu <william.xwl@gmail.com>
3994
3995 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3996 exiting (Bug#8239).
3997
3998 2011-05-28 Jim Meyering <meyering@redhat.com>
3999
4000 Avoid a sign-extension bug in crypto_hash_function.
4001 * fns.c (to_uchar): Define.
4002 (crypto_hash_function): Use it to convert some newly-signed
4003 variables to unsigned, to avoid sign-extension bugs. For example,
4004 without this change, (md5 "truc") would evaluate to
4005 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4006 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4007 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4008
4009 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4010
4011 Integer overflow fixes.
4012
4013 * dbusbind.c: Serial number integer overflow fixes.
4014 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4015 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4016 to hold a serial number that is too large for a fixnum.
4017 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4018 Check for serial numbers out of range. Decode any serial number
4019 that was so large that it became a float. (Bug#8722)
4020
4021 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4022 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4023 Use XFASTINT rather than XUINT when numbers are nonnegative.
4024 (xd_append_arg, Fdbus_method_return_internal):
4025 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4026 arguments, check that Lisp number is nonnegative, rather than
4027 silently wrapping negative numbers around. (Bug#8722)
4028 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4029 (Bug#8722)
4030
4031 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4032
4033 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4034
4035 ccl: add integer overflow checks
4036 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4037 (IN_INT_RANGE): New macros.
4038 (ccl_driver): Use them to check for integer overflow when
4039 decoding a CCL program. Many of the new checks are whether XINT (x)
4040 fits in int; it doesn't always, on 64-bit hosts. The new version
4041 doesn't catch all possible integer overflows, but it's an
4042 improvement. (Bug#8719)
4043
4044 * alloc.c (make_event_array): Use XINT, not XUINT.
4045 There's no need for unsigned here.
4046
4047 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4048 This follows up to the 2011-05-06 change that substituted uintptr_t
4049 for EMACS_INT. This case wasn't caught back then.
4050
4051 Rework Fformat to avoid integer overflow issues.
4052 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4053 now (part of C89). Include <verify.h>.
4054 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4055 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4056 (Fformat): Avoid the prepass trying to compute sizes; it was only
4057 approximate and thus did not catch overflow reliably. Instead, walk
4058 through the format just once, formatting and computing sizes as we go,
4059 checking for integer overflow at every step, and allocating a larger
4060 buffer as needed. Keep track separately whether the format is
4061 multibyte. Keep only the most-recently calculated precision, rather
4062 than them all. Record whether each argument has been converted to
4063 string. Use EMACS_INT, not int, for byte and char and arg counts.
4064 Support field widths and precisions larger than INT_MAX. Avoid
4065 sprintf's undefined behavior with conversion specifications such as %#d
4066 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4067 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4068 formatting out-of-range floating point numbers with int
4069 formats. (Bug#8668)
4070
4071 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4072
4073 * data.c: Avoid integer truncation in expressions involving floats.
4074 * data.c: Include <intprops.h>.
4075 (arith_driver): When there's an integer overflow in an expression
4076 involving floating point, convert the integers to floating point
4077 so that the resulting value does not suffer from catastrophic
4078 integer truncation. For example, on a 64-bit host (* 4
4079 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4080 Do not rely on undefined behavior after integer overflow.
4081
4082 merge count_size_as_multibyte, parse_str_to_multibyte
4083 * character.c, character.h (count_size_as_multibyte):
4084 Rename from parse_str_to_multibyte; all uses changed.
4085 Check for integer overflow.
4086 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4087 since it's now a duplicate of the other. This is more of
4088 a character than a buffer op, so better that it's in character.c.
4089 * fns.c, print.c: Adjust to above changes.
4090
4091 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4092
4093 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4094
4095 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4096
4097 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4098 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4099 (x_clipboard_manager_save): Now static.
4100 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4101
4102 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4103 (crypto_hash_function): Now static.
4104 Fix pointer signedness problems. Avoid unnecessary initializations.
4105
4106 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4107
4108 * termhooks.h (Vselection_alist): Make it terminal-local.
4109
4110 * terminal.c (create_terminal): Initialize it.
4111
4112 * xselect.c: Support for clipboard managers.
4113 (Vselection_alist): Move to termhooks.h as terminal-local var.
4114 (LOCAL_SELECTION): New macro.
4115 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4116 (symbol_to_x_atom): Remove gratuitous arg.
4117 (x_handle_selection_request, lisp_data_to_selection_data)
4118 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4119 (x_own_selection, x_get_local_selection, x_convert_selection):
4120 New arg, specifying work frame. Use terminal-local Vselection_alist.
4121 (some_frame_on_display): Delete unused function.
4122 (Fx_own_selection_internal, Fx_get_selection_internal)
4123 (Fx_disown_selection_internal, Fx_selection_owner_p)
4124 (Fx_selection_exists_p): New optional frame arg.
4125 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4126 (x_handle_selection_clear): Don't treat other terminals with the
4127 same keyboard specially. Use the terminal-local Vselection_alist.
4128 (x_clear_frame_selections): Use Frun_hook_with_args.
4129
4130 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4131
4132 * xterm.h: Add support for those atoms.
4133
4134 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4135
4136 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4137 (converted_selections, conversion_fail_tag): New global variables.
4138 (x_selection_request_lisp_error): Free the above.
4139 (x_get_local_selection): Remove unnecessary code.
4140 (x_reply_selection_request): Args changed; handle arbitrary array
4141 of converted selections stored in converted_selections.
4142 Separate the XChangeProperty and SelectionNotify steps.
4143 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4144 (x_convert_selection): New function.
4145 (x_handle_selection_event): Simplify.
4146 (x_get_foreign_selection): Don't ignore incoming requests while
4147 waiting for an answer; this will fail when we implement
4148 SAVE_TARGETS, and seems unnecessary anyway.
4149 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4150 (Vx_sent_selection_functions): Doc fix.
4151
4152 2011-05-26 Leo Liu <sdl.web@gmail.com>
4153
4154 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4155
4156 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4157
4158 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4159
4160 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4161 for fringe update if it has periodic bitmap.
4162 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4163 and fringe_bitmap_periodic_p.
4164
4165 * fringe.c (get_fringe_bitmap_data): New function.
4166 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4167 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4168 row. Mark glyph row for fringe update if periodicity changed.
4169
4170 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4171 for fringe update unless it has periodic bitmap.
4172
4173 2011-05-25 Kenichi Handa <handa@m17n.org>
4174
4175 * xdisp.c (get_next_display_element): Set correct it->face_id for
4176 a static composition.
4177
4178 2011-05-24 Leo Liu <sdl.web@gmail.com>
4179
4180 * deps.mk (fns.o):
4181 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4182
4183 * fns.c (crypto_hash_function, Fsha1): New function.
4184 (Fmd5): Use crypto_hash_function.
4185 (syms_of_fns): Add Ssha1.
4186
4187 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4188
4189 * gnutls.c: Remove unused macros.
4190 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4191 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4192 Remove macros that are defined and never used.
4193 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4194
4195 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4196
4197 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4198 (Fx_get_selection_internal): Minor cleanup.
4199 (Fx_own_selection_internal): Rename arguments for consistency with
4200 select.el.
4201
4202 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4203
4204 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4205
4206 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4207
4208 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4209
4210 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4211
4212 * dispnew.c (scrolling_window): Don't exclude the case that the
4213 last enabled row in the desired matrix touches the bottom boundary.
4214
4215 2011-05-21 Glenn Morris <rgm@gnu.org>
4216
4217 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4218 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4219 and add some more files.
4220
4221 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4222
4223 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4224 report_file_error introduced by the change from 2011-05-07.
4225
4226 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4227
4228 * systime.h (Time): Define only if emacs is defined.
4229 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4230 where the include path doesn't have X11/X.h by default. See
4231 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4232
4233 2011-05-20 Kenichi Handa <handa@m17n.org>
4234
4235 * composite.c (find_automatic_composition): Fix previous change.
4236
4237 2011-05-20 Glenn Morris <rgm@gnu.org>
4238
4239 * lisp.mk: New file, split from Makefile.in.
4240 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4241 (shortlisp): Remove.
4242 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4243
4244 2011-05-19 Glenn Morris <rgm@gnu.org>
4245
4246 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4247 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4248 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4249 (lisp): Set the order to that of loadup.el.
4250 (shortlisp): Make it a copy of $lisp.
4251 (SOME_MACHINE_LISP): Remove.
4252 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4253 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4254
4255 2011-05-18 Kenichi Handa <handa@m17n.org>
4256
4257 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4258 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4259 (find_automatic_composition): Mostly rewrite for efficiency.
4260
4261 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4262
4263 * makefile.w32-in: Update dependencies.
4264
4265 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4266
4267 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4268 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4269
4270 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4271
4272 Fix some integer overflow issues, such as string length overflow.
4273
4274 * insdel.c (count_size_as_multibyte): Check for string overflow.
4275
4276 * character.c (lisp_string_width): Check for string overflow.
4277 Use EMACS_INT, not int, for string indexes and lengths; in
4278 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4279 the resulting string length overflows an EMACS_INT; instead,
4280 report a string overflow if no precision given. When checking for
4281 precision exhaustion, use a check that cannot possibly have
4282 integer overflow. (Bug#8675)
4283 * character.h (lisp_string_width): Adjust to new signature.
4284
4285 * alloc.c (string_overflow): New function.
4286 (Fmake_string): Use it. This doesn't change behavior, but saves
4287 a few bytes and will simplify future changes.
4288 * character.c (string_escape_byte8): Likewise.
4289 * lisp.h (string_overflow): New decl.
4290
4291 Fixups, following up to the user-interface timestamp change.
4292 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4293 for UI timestamps, instead of unsigned long.
4294 * msdos.c (mouse_get_pos): Likewise.
4295 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4296 * w32gui.h (Time): Define by including "systime.h" rather than by
4297 declaring it ourselves. (Bug#8664)
4298
4299 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4300 * image.c (clear_image_cache): Likewise.
4301
4302 * term.c (term_mouse_position): Don't assume time_t wraparound.
4303
4304 Be more systematic about user-interface timestamps.
4305 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4306 and sometimes 'EMACS_UINT', to represent these timestamps.
4307 This change causes it to use 'Time' uniformly, as that's what X uses.
4308 This makes the code easier to follow, and makes it easier to catch
4309 integer overflow bugs such as Bug#8664.
4310 * frame.c (Fmouse_position, Fmouse_pixel_position):
4311 Use Time, not unsigned long, for user-interface timestamps.
4312 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4313 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4314 * keyboard.h (last_event_timestamp): Likewise.
4315 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4316 * menu.h (xmenu_show): Likewise.
4317 * term.c (term_mouse_position): Likewise.
4318 * termhooks.h (struct input_event.timestamp): Likewise.
4319 (struct terminal.mouse_position_hook): Likewise.
4320 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4321 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4322 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4323 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4324 what it was before.
4325 * menu.h, termhooks.h: Include "systime.h", for Time.
4326
4327 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4328 Don't assume that the difference between two unsigned long values
4329 can fit into an integer. At this point, we know button_down_time
4330 <= event->timestamp, so the difference must be nonnegative, so
4331 there's no need to cast the result if double-click-time is
4332 nonnegative, as it should be; check that it's nonnegative, just in
4333 case. This bug is triggered when events are more than 2**31 ms
4334 apart (about 25 days). (Bug#8664)
4335
4336 * xselect.c (last_event_timestamp): Remove duplicate decl.
4337 (x_own_selection): Remove needless cast to unsigned long.
4338
4339 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4340 that always fit in int. Use a sentinel instead of a counter, to
4341 avoid a temp and to allay GCC's concerns about possible int overflow.
4342 * frame.h (struct frame): Use int for menu_bar_items_used
4343 instead of EMACS_INT, since it always fits in int.
4344
4345 * menu.c (grow_menu_items): Check for int overflow.
4346
4347 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4348
4349 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4350 Before, the code was not consistent. These values cannot exceed
4351 2**31 - 1 so there's no need to make them unsigned.
4352 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4353 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4354 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4355 as modifiers.
4356 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4357
4358 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4359 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4360 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4361 presumably because the widths might not match.
4362
4363 * window.c (size_window): Avoid needless test at loop start.
4364
4365 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4366
4367 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4368
4369 2011-05-12 Drew Adams <drew.adams@oracle.com>
4370
4371 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4372
4373 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4374
4375 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4376 `width' to `bar_area_x' and `bar_area_width', respectively.
4377 (x_scroll_run): Take account of fringe background extension.
4378
4379 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4380 Rename local vars `left' and `width' to `bar_area_x' and
4381 `bar_area_width', respectively.
4382 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4383 background extension.
4384
4385 2011-05-10 Jim Meyering <meyering@redhat.com>
4386
4387 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4388
4389 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4390
4391 * image.c (Finit_image_library): Return t for built-in image types,
4392 like pbm and xbm. (Bug#8640)
4393
4394 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4395
4396 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4397
4398 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4399
4400 * w32console.c (Fset_screen_color): Doc fix.
4401 (Fget_screen_color): New function.
4402 (syms_of_ntterm): Defsubr it.
4403
4404 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4405 unlink the temporary file if Fcall_process didn't create it in the
4406 first place.
4407 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4408 child process will be redirected to a file specified with `:file'.
4409 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4410 cue to call_process_cleanup not to close that handle.
4411
4412 2011-05-07 Ben Key <bkey76@gmail.com>
4413
4414 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4415 one of two shell specific rules, either bootstrap-temacs-CMD or
4416 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4417 to the previous implementation of the bootstrap-temacs rule.
4418 The bootstrap-temacs-CMD rule is similar to the previous
4419 implementation of the bootstrap-temacs rule except that it
4420 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4421 variable.
4422
4423 These changes, along with some changes to nt/configure.bat,
4424 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4425 earlier fix to add support for --cflags and --ldflags options
4426 that include quotes so that it works whether make uses cmd or
4427 sh as the shell.
4428
4429 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4430
4431 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4432 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4433 is a constant.
4434 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4435 a string. Handle both cases.
4436 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4437 (Fdbus_register_method): Use Qinvalid_function.
4438
4439 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4440
4441 * makefile.w32-in: Update dependencies.
4442 (LISP_H): Add inttypes.h and stdin.h.
4443 (PROCESS_H): Add unistd.h.
4444
4445 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4446
4447 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4448 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4449
4450 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4451
4452 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4453
4454 * term.c (vfatal): Remove stray call to va_end.
4455 It's not needed and the C Standard doesn't allow it here anyway.
4456
4457 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4458 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4459
4460 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4461 bytes.
4462
4463 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4464
4465 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4466
4467 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4468
4469 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4470
4471 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4472
4473 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4474 * charset.c (Fdefine_charset_internal): Don't initialize
4475 charset.code_space[15]. The value was garbage, on hosts with
4476 32-bit int (Bug#8600).
4477
4478 * lread.c (read_integer): Be more consistent with string-to-number.
4479 Use string_to_number to do the actual conversion; this avoids
4480 rounding errors and fixes some other screwups. Without this fix,
4481 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4482 (digit_to_number): Move earlier, for benefit of read_integer.
4483 Return -1 if the digit is out of range for the base, -2 if it is
4484 not a digit in any supported base. (Bug#8602)
4485
4486 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4487
4488 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4489 to match comment at start of function. This also removes a
4490 GCC warning about overflow in a 32+64-bit port.
4491
4492 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4493
4494 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4495 Reported by Stefan Monnier in
4496 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4497 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4498 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4499
4500 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4501 (EMACS_UINTPTR): Likewise, with uintptr_t.
4502
4503 * lisp.h: Prefer 64-bit EMACS_INT if available.
4504 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4505 on 32-bit hosts that have 64-bit int, so that they can access
4506 large files.
4507 However, temporarily disable this change unless the temporary
4508 symbol WIDE_EMACS_INT is defined.
4509
4510 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4511
4512 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4513 This removes an assumption that EMACS_INT and long are the same
4514 width as pointers. The assumption is true for Emacs porting targets
4515 now, but we want to make other targets possible.
4516 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4517 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4518 In the rest of the code, change types of integers that hold casted
4519 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4520 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4521 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4522 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4523 No need to cast type when ORing.
4524 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4525 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4526 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4527 assume EMACS_INT is the same width as char *.
4528 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4529 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4530 Remove no-longer-needed casts.
4531 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4532 (xg_tool_bar_help_callback, xg_make_tool_item):
4533 Use EMACS_INTPTR to hold an integer
4534 that will be cast to void *; this can avoid a GCC warning
4535 if EMACS_INT is not the same width as void *.
4536 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4537 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4538 (current_message_1, set_message_1):
4539 Use a local to convert to proper width without a cast.
4540 * xmenu.c (dialog_selection_callback): Likewise.
4541
4542 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4543 Also, don't assume VALBITS / RAND_BITS is less than 5,
4544 and don't rely on undefined behavior when shifting a 1 left into
4545 the sign bit.
4546 * lisp.h (get_random): Change signature to match.
4547
4548 * lread.c (hash_string): Use size_t, not int, for hash computation.
4549 Normally we prefer signed values; but hashing is special, because
4550 it's better to use unsigned division on hash table sizes so that
4551 the remainder is nonnegative. Also, size_t is the natural width
4552 for hashing into memory. The previous code used 'int', which doesn't
4553 retain enough info to hash well into very large tables.
4554 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4555
4556 * dbusbind.c: Don't possibly lose pointer info when converting.
4557 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4558 Use XPNTR rather than XHASH, so that the high-order bits of
4559 the pointer aren't lost when converting through void *.
4560
4561 * eval.c (Fautoload): Don't double-shift a pointer.
4562
4563 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4564
4565 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4566
4567 * gnutls.c (DEF_GNUTLS_FN):
4568 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4569
4570 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4571
4572 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4573 marker. (Bug#8610)
4574
4575 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4576
4577 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4578 New version that can reserve upto 2GB of heap space.
4579
4580 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4581
4582 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4583
4584 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4585
4586 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4587 `gnutls_certificate_set_x509_key_file'.
4588
4589 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4590
4591 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4592 Update dependencies.
4593
4594 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4595
4596 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4597 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4598 Remove unused parameter `fildes'.
4599 * process.c (read_process_output, send_process): Don't pass it.
4600
4601 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4602
4603 Fix previous change: the library cache is defined in w32.c.
4604 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4605 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4606
4607 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4608
4609 Implement dynamic loading of GnuTLS on Windows.
4610
4611 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4612 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4613 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4614 Declare.
4615
4616 * gnutls.c (Qgnutls_dll): Define.
4617 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4618 (gnutls_*): Declare function pointers.
4619 (init_gnutls_functions): New function to initialize function pointers.
4620 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4621 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4622 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4623 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4624 (emacs_gnutls_write, emacs_gnutls_read)
4625 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4626 (Fgnutls_available_p): New function.
4627 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4628 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4629 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4630
4631 * image.c: Include w32.h.
4632 (Vimage_type_cache): Delete.
4633 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4634 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4635 (w32_delayed_load): Move to w32.c.
4636
4637 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4638
4639 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4640 (w32_delayed_load): Move from image.c. When loading a library, record
4641 its filename in the :loaded-from property of the library id.
4642 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4643 Initialize and staticpro them.
4644 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4645
4646 * process.c: Include lisp.h before w32.h, not after.
4647 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4648 instead of gnutls_record_check_pending.
4649
4650 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4651
4652 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4653
4654 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4655 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4656 as passed in.
4657
4658 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4659
4660 * xterm.c (x_set_frame_alpha): Do not set property on anything
4661 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4662
4663 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4664
4665 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4666
4667 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4668
4669 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4670 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4671 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4672 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4673 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4674 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4675 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4676 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4677 (Qgnutls_bootprop_callbacks_verify): Make static.
4678
4679 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4680
4681 * callproc.c: Indentation fixup.
4682
4683 * sysdep.c (wait_for_termination_1): Make static.
4684 (wait_for_termination, interruptible_wait_for_termination):
4685 Move after wait_for_termination_1.
4686
4687 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4688
4689 * sysdep.c (interruptible_wait_for_termination): New function
4690 which is like wait_for_termination, but allows keyboard
4691 interruptions.
4692
4693 * callproc.c (Fcall_process): Add (:file "file") as an option for
4694 the STDOUT buffer.
4695 (Fcall_process_region): Ditto.
4696
4697 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4698
4699 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4700 rather than `XVECTOR (FOO)->size'.
4701
4702 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4703 inttypes.h, as a gnulib replacement is used if it not available in
4704 system headers.
4705
4706 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4707
4708 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4709 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4710 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4711
4712 * coding.c (coding_alloc_by_realloc): Error out if destination
4713 will grow beyond MOST_POSITIVE_FIXNUM.
4714 (decode_coding_emacs_mule): Abort if there isn't enough place in
4715 charbuf for the composition carryover bytes. Reserve an extra
4716 space for up to 2 characters produced in a loop.
4717 (decode_coding_iso_2022): Abort if there isn't enough place in
4718 charbuf for the composition carryover bytes.
4719
4720 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4721
4722 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4723 aborting when %lld or %lll format is passed.
4724 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4725 %llo or %llx format is passed. (Bug#8545)
4726
4727 * window.c (window_scroll_line_based): Use a marker instead of
4728 simple variables to record original value of point. (Bug#7952)
4729
4730 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4731 produced by %s or %c overflows available buffer space. (Bug#8545)
4732
4733 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4734
4735 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4736 (SIZE_MAX): Move defn after all includes, as they might #define it.
4737
4738 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4739
4740 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4741
4742 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4743
4744 * keyboard.c (Qdelayed_warnings_hook): Define.
4745 (command_loop_1): Run `delayed-warnings-hook'
4746 if Vdelayed_warnings_list is non-nil.
4747 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4748 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4749
4750 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4751
4752 * doprnt.c (doprnt): Don't return value smaller than the buffer
4753 size if the message was truncated. (Bug#8545).
4754
4755 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4756
4757 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4758 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4759
4760 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4761
4762 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4763
4764 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4765
4766 * makefile.w32-in: Update dependencies.
4767
4768 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4769
4770 Improve `doprnt' and its usage. (Bug#8545)
4771 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4772 `format_end'. Remove support for %l as a conversion specifier.
4773 Don't use xrealloc. Improve diagnostics when the %l size modifier
4774 is used. Update the commentary.
4775
4776 * eval.c (verror): Simplify calculation of size_t.
4777
4778 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4779 messages.
4780
4781 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4782
4783 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4784 change.
4785
4786 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4787
4788 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4789 This makes this file independent of the recent pseudovector change.
4790
4791 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4792
4793 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4794
4795 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4796 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4797 Remove unused local.
4798 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4799
4800 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4801 GCC 4.6.0 optimizes based on type-based alias analysis.
4802 For example, if b is of type struct buffer * and v of type struct
4803 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4804 != &v->size, and therefore "v->size = 1; b->size = 2; return
4805 v->size;" must therefore return 1. This assumption is incorrect
4806 for Emacs, since it type-puns struct Lisp_Vector * with many other
4807 types. To fix this problem, this patch adds a new type struct
4808 vectorlike_header that documents the constraints on layout of vectors
4809 and pseudovectors, and helps optimizing compilers not get fooled
4810 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4811 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4812 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4813 the size member.
4814 (XSETPVECTYPE): Rewrite in terms of new macro.
4815 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4816 This is a bit clearer, and further avoids the possibility of
4817 undesirable aliasing.
4818 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4819 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4820 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4821 since Lisp_Subr is a special case (no "next" field).
4822 (ASIZE): Now uses header.size rather than size.
4823 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4824 to avoid the hassle of writing XVECTOR (foo)->header.size.
4825 (struct vectorlike_header): New type.
4826 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4827 object, to help avoid aliasing.
4828 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4829 (SUBRP): Likewise, since Lisp_Subr is a special case.
4830 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4831 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4832 (struct Lisp_Hash_Table): Combine first two members into a single
4833 struct vectorlike_header member. All uses of "size" and "next" members
4834 changed to be "header.size" and "header.next".
4835 * buffer.h (struct buffer): Likewise.
4836 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4837 * frame.h (struct frame): Likewise.
4838 * process.h (struct Lisp_Process): Likewise.
4839 * termhooks.h (struct terminal): Likewise.
4840 * window.c (struct save_window_data, struct saved_window): Likewise.
4841 * window.h (struct window): Likewise.
4842 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4843 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4844 * buffer.c (init_buffer_once): Likewise.
4845 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4846 special case.
4847 * process.c (Fformat_network_address): Use local var for size,
4848 for brevity.
4849
4850 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4851
4852 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4853 * data.c (atof): Remove decl; no longer used or needed.
4854 (digit_to_number): Move to lread.c.
4855 (Fstring_to_number): Use new string_to_number function, to be
4856 consistent with how the Lisp reader treats infinities and NaNs.
4857 Do not assume that floating-point numbers represent EMACS_INT
4858 without losing information; this is not true on most 64-bit hosts.
4859 Avoid double-rounding errors, by insisting on integers when
4860 parsing non-base-10 numbers, as the documentation specifies.
4861 * lisp.h (string_to_number): New decl, replacing ...
4862 (isfloat_string): Remove.
4863 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4864 (read1): Do not accept +. and -. as integers; this
4865 appears to have been a coding error. Similarly, do not accept
4866 strings like +-1e0 as floating point numbers. Do not report
4867 overflow for integer overflows unless the base is not 10 which
4868 means we have no simple and reliable way to continue.
4869 Break out the floating-point parsing into a new
4870 function string_to_number, so that Fstring_to_number parses
4871 floating point numbers consistently with the Lisp reader.
4872 (digit_to_number): Move here from data.c. Make it static inline.
4873 (E_CHAR, EXP_INT): Remove, replacing with ...
4874 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4875 (string_to_number): New function, replacing isfloat_string.
4876 This function checks for valid syntax and produces the resulting
4877 Lisp float number too. Rework it so that string-to-number
4878 no longer mishandles examples like "1.0e+". Use strtoumax,
4879 so that overflow for non-base-10 numbers is reported only when
4880 there's no portable and simple way to convert to floating point.
4881
4882 * textprop.c (set_text_properties_1): Rewrite for clarity,
4883 and to avoid GCC warning about integer overflow.
4884
4885 * intervals.h (struct interval): Use EMACS_INT for members
4886 where EMACS_UINT might cause problems. See
4887 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4888 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4889 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4890 All uses changed.
4891 (offset_intervals): Tell GCC not to worry about length overflow
4892 when negating a negative length.
4893
4894 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4895 (overrun_check_free): Likewise.
4896
4897 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4898 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4899 word size.
4900
4901 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4902 (gnutls_make_error): Rename local to avoid shadowing.
4903 (gnutls_emacs_global_deinit): ifdef out; not used.
4904 (Fgnutls_boot): Use const for pointer to readonly storage.
4905 Comment out unused local. Fix pointer signedness problems.
4906
4907 * lread.c (openp): Don't stuff size_t into an 'int'.
4908 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4909 about possible signed overflow.
4910
4911 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4912 (GDK_KEY_g): Don't define if already defined.
4913 (xg_prepare_tooltip): Avoid pointer signedness problem.
4914 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4915
4916 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4917 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4918
4919 * xfns.c (Fx_window_property): Simplify a bit,
4920 to make a bit faster and to avoid GCC 4.6.0 warning.
4921 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4922
4923 * fns.c (internal_equal): Don't assume size_t fits in int.
4924
4925 * alloc.c (compact_small_strings): Tighten assertion a little.
4926
4927 Replace pEd with more-general pI, and fix some printf arg casts.
4928 * lisp.h (pI): New macro, generalizing old pEd macro to other
4929 conversion specifiers. For example, use "...%"pI"d..." rather
4930 than "...%"pEd"...".
4931 (pEd): Remove. All uses replaced with similar uses of pI.
4932 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4933 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4934 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4935 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4936 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4937 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4938 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4939 64-bit hosts.
4940 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4941 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4942 * print.c (safe_debug_print, print_object): Likewise.
4943 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4944 to int.
4945 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4946 avoiding the 0 flag, which is not portable.
4947 * process.c (Fmake_network_process): Use pI to avoid cast.
4948 * region-cache.c (pp_cache): Likewise.
4949 * xdisp.c (decode_mode_spec): Likewise.
4950 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4951 behavior on 64-bit hosts with printf arg.
4952 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4953 (x_stop_queuing_selection_requests): Likewise.
4954 (x_get_window_property): Don't truncate byte count to an 'int'
4955 when tracing.
4956
4957 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4958 here, since it parses constructs like leading '-' and spaces,
4959 which are not wanted; and it overflows with large numbers.
4960 Instead, simply match F[0-9]+, which is what is wanted anyway.
4961
4962 * alloc.c: Remove unportable assumptions about struct layout.
4963 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4964 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4965 (allocate_vectorlike, make_pure_vector): Use the new macros,
4966 plus offsetof, to remove unportable assumptions about struct layout.
4967 These assumptions hold on all porting targets that I know of, but
4968 they are not guaranteed, they're easy to remove, and removing them
4969 makes further changes easier.
4970
4971 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4972 This doesn't fix a bug but makes the code clearer.
4973 (string_overrun_cookie): Now const. Use initializers that
4974 don't formally overflow signed char, to avoid warnings.
4975 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4976 can cause Emacs to crash when string overrun checking is enabled.
4977 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4978 multiple of sizeof (EMACS_INT); it need not be, if
4979 alignof(EMACS_INT) < sizeof (EMACS_INT).
4980 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4981
4982 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4983
4984 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4985
4986 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4987
4988 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4989 supposed to be handshaking. (Bug#8556)
4990 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4991
4992 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4993
4994 * lisp.h (Qdebug): List symbol.
4995 * eval.c (Qdebug): Restore global linkage.
4996 * keyboard.c (debug-on-event): New variable.
4997 (handle_user_signal): Break into debugger when debug-on-event
4998 matches the current signal symbol.
4999
5000 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5001
5002 * alloc.c (check_sblock, check_string_bytes)
5003 (check_string_free_list): Convert to standard C.
5004
5005 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5006
5007 * w32.c (emacs_gnutls_push): Fix typo.
5008
5009 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5010
5011 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5012 "cast to pointer from integer of different size".
5013
5014 Improve doprnt and its use in verror. (Bug#8545)
5015 * doprnt.c (doprnt): Document the set of format control sequences
5016 supported by the function. Use SAFE_ALLOCA instead of always
5017 using `alloca'.
5018
5019 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5020 is one byte too soon. Don't use xrealloc; instead xfree and
5021 xmalloc anew.
5022
5023 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5024
5025 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5026 callbacks stage.
5027
5028 * gnutls.c: Renamed global_initialized to
5029 gnutls_global_initialized. Added internals for the
5030 :verify-hostname-error, :verify-error, and :verify-flags
5031 parameters of `gnutls-boot' and documented those parameters in the
5032 docstring. Start callback support.
5033 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5034 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5035 on error. Return error code.
5036 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5037 (emacs_gnutls_read): Likewise.
5038 (Fgnutls_boot): Return handshake error code.
5039 (emacs_gnutls_handle_error): New function.
5040 (wsaerror_to_errno): Likewise.
5041
5042 * w32.h (emacs_gnutls_pull): Add prototype.
5043 (emacs_gnutls_push): Likewise.
5044
5045 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5046 (emacs_gnutls_push): Likewise.
5047
5048 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5049
5050 * process.c (wait_reading_process_output): Check if GnuTLS
5051 buffered some data internally if no FDs are set for TLS
5052 connections.
5053
5054 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5055 (LIBS): Link to USER_LIBS.
5056 ($(BLD)/gnutls.$(0)): New target.
5057
5058 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5059
5060 * xdisp.c (handle_single_display_spec): Rename the
5061 display_replaced_before_p argument into display_replaced_p, to
5062 make it consistent with the commentary. Fix typos in the
5063 commentary.
5064
5065 * textprop.c (syms_of_textprop): Remove dead code.
5066 (copy_text_properties): Delete obsolete commentary about an
5067 interface that was deleted long ago. Fix typos in the description
5068 of arguments.
5069
5070 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5071 to changes in oldXMenu/XMenu.h from 2011-04-16.
5072 <menu_help_message, prev_menu_help_message>: Constify.
5073 (IT_menu_make_room): menu->help_text is now `const char **';
5074 adjust.
5075
5076 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5077 to changes in oldXMenu/XMenu.h from 2011-04-16.
5078 (struct XMenu): Declare `help_text' `const char **'.
5079
5080 * xfaces.c <Qunspecified>: Make extern again.
5081
5082 * syntax.c: Include sys/types.h before including regex.h, as
5083 required by Posix.
5084
5085 * doc.c (get_doc_string): Improve the format passed to `error'.
5086
5087 * doprnt.c (doprnt): Improve commentary.
5088
5089 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5090
5091 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5092 them with etags.
5093
5094 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5095 changes in globals.h immediately force recompilation.
5096 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5097 $(CURDIR)/s/ms-w32.h.
5098 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5099
5100 * character.c (Fchar_direction): Function deleted.
5101 (syms_of_character): Don't defsubr it.
5102 <char-direction-table>: Deleted.
5103
5104 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5105
5106 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5107 * doprnt.c: Include limits.h.
5108 (SIZE_MAX): New macro.
5109 (doprnt): Return a size_t value. 2nd arg is now size_t.
5110 Many local variables are now size_t instead of int or unsigned.
5111 Improve overflow protection. Support `l' modifier for integer
5112 conversions. Support %l conversion. Don't assume an EMACS_INT
5113 argument for integer conversions and for %c.
5114
5115 * lisp.h (doprnt): Restore prototype.
5116
5117 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5118 $(SRC)/character.h.
5119
5120 * Makefile.in (base_obj): Add back doprnt.o.
5121
5122 * deps.mk (doprnt.o): Add back prerequisites.
5123 (callint.o): Depend on character.h.
5124
5125 * eval.c (internal_lisp_condition_case): Include the handler
5126 representation in the error message.
5127 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5128 when breaking from the loop.
5129
5130 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5131
5132 * callint.c (Fcall_interactively): When displaying error message
5133 about invalid control letter, pass the character's codepoint, not
5134 a pointer to its multibyte form. Improve display of the character
5135 in octal and display also its hex code.
5136
5137 * character.c (char_string): Use %x to display the (unsigned)
5138 codepoint of an invalid character, to avoid displaying a bogus
5139 negative value.
5140
5141 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5142 `error', not SYMBOL_NAME itself.
5143
5144 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5145 character arguments to `error'.
5146
5147 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5148 to `error' in error message about FINAL_CHAR argument. Make sure
5149 FINAL_CHAR is a character, and use %c when it is passed as
5150 argument to `error'.
5151
5152 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5153
5154 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5155
5156 * w32.c: Include <time.h>.
5157 (sys_localtime): New function.
5158
5159 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5160
5161 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5162
5163 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5164
5165 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5166
5167 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5168 zombies (Bug#8467).
5169
5170 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5171
5172 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5173 gl_state.e_property when gl_state.object is Qt.
5174
5175 * insdel.c (make_gap_larger): Remove limitation of buffer size
5176 to <= INT_MAX.
5177
5178 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5179
5180 * xdisp.c (lookup_glyphless_char_display)
5181 (produce_glyphless_glyph): Handle cons cell entry in
5182 glyphless-char-display.
5183 (Vglyphless_char_display): Document it.
5184
5185 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5186 glyphless-char-display.
5187
5188 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5189
5190 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5191
5192 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5193
5194 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5195 definition for no-X builds.
5196
5197 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5198
5199 Static checks with GCC 4.6.0 and non-default toolkits.
5200
5201 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5202
5203 * process.c (keyboard_bit_set): Define only if SIGIO.
5204 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5205 (send_process): Repair possible setjmp clobbering.
5206
5207 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5208
5209 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5210
5211 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5212
5213 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5214 Define only if needed.
5215
5216 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5217 by pacifying GCC about it. Maybe it's time to retire it?
5218 * xfaces.c (USG, __TIMEVAL__): Likewise.
5219
5220 * dispextern.h (struct redisplay_interface): Rename param
5221 to avoid shadowing.
5222 * termhooks.h (struct terminal): Likewise.
5223 * xterm.c (xembed_send_message): Likewise.
5224
5225 * insdel.c (make_gap_smaller): Define only if
5226 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5227
5228 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5229 it.
5230
5231 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5232 so that we aren't warned about unused symbols.
5233
5234 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5235
5236 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5237
5238 * xfns.c (x_real_positions): Mark locals as initialized.
5239
5240 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5241
5242 * xterm.c: Fix problems found by static analysis with other toolkits.
5243 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5244 (x_dispatch_event): Declare static if USE_GTK, and
5245 define if USE_GTK || USE_X_TOOLKIT.
5246 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5247 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5248 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5249 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5250
5251 * xmenu.c (menu_help_callback): Pointer type fixes.
5252 Use const pointers when pointing at readonly data. Avoid pointer
5253 signedness clashes.
5254 (FALSE): Remove unused macro.
5255 (update_frame_menubar): Remove unused decl.
5256
5257 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5258
5259 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5260 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5261 (single_menu_item): Rename local to avoid shadowing.
5262
5263 * keyboard.c (make_lispy_event): Remove unused local var.
5264
5265 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5266 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5267
5268 * bitmaps: Change bitmaps from unsigned char back to the X11
5269 compatible char. Avoid the old compiler warnings about
5270 out-of-range initializers by using, for example, '\xab' rather
5271 than 0xab.
5272
5273 * xgselect.c (xgselect_initialize): Check vs interface
5274 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5275
5276 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5277
5278 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5279 to read-only memory.
5280
5281 * fns.c (vector): Remove; this old hack is no longer needed.
5282
5283 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5284 Remove unused var.
5285 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5286
5287 * xrdb.c (x_load_resources): Omit unused local.
5288
5289 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5290 (x_window): Rename locals to avoid shadowing.
5291 (USG): Use the kludged USG macro, to pacify gcc.
5292
5293 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5294 (x_term_init): Remove local to avoid shadowing.
5295
5296 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5297
5298 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5299 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5300
5301 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5302
5303 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5304
5305 Fix regex.c, syntax.c and friends for buffers > 2GB.
5306 * syntax.h (struct gl_state_s): Declare character position members
5307 EMACS_INT.
5308
5309 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5310
5311 * textprop.c (verify_interval_modification, interval_of):
5312 Declare arguments EMACS_INT.
5313
5314 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5315 EMACS_INT.
5316
5317 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5318
5319 * indent.c (Fvertical_motion): Local variable it_start is now
5320 EMACS_INT.
5321
5322 * regex.c (re_match, re_match_2, re_match_2_internal)
5323 (bcmp_translate, regcomp, regexec, print_double_string)
5324 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5325 (re_compile_pattern, re_exec): Declare arguments and local
5326 variables `size_t' and `ssize_t' and return values `regoff_t', as
5327 appropriate.
5328 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5329 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5330 <compile_stack_type>: `size' and `avail' are now `size_t'.
5331
5332 * regex.h <regoff_t>: Use ssize_t, not int.
5333 (re_search, re_search_2, re_match, re_match_2): Arguments that
5334 specify buffer/string position and length are now ssize_t and
5335 size_t. Return type is regoff_t.
5336
5337 2011-04-16 Ben Key <bkey76@gmail.com>
5338
5339 * nsfont.m: Fixed bugs in ns_get_family and
5340 ns_descriptor_to_entity that were caused by using free to
5341 deallocate memory blocks that were allocated by xmalloc (via
5342 xstrdup). This caused Emacs to crash when compiled with
5343 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5344 --enable-checking=xmallocoverrun). xfree is now used to
5345 deallocate these memory blocks.
5346
5347 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5348
5349 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5350
5351 emacs_write: Accept and return EMACS_INT for sizes.
5352 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5353 et seq.
5354 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5355 Accept and return EMACS_INT.
5356 (emacs_gnutls_write): Return the number of bytes written on
5357 partial writes.
5358 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5359 (emacs_read, emacs_write): Remove check for negative size, as the
5360 Emacs source code has been audited now.
5361 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5362 (emacs_read, emacs_write): Use it.
5363 * process.c (send_process): Adjust to the new signatures of
5364 emacs_write and emacs_gnutls_write. Do not attempt to store
5365 a byte offset into an 'int'; it might overflow.
5366 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5367
5368 * sound.c: Don't assume sizes fit in 'int'.
5369 (struct sound_device.period_size, alsa_period_size):
5370 Return EMACS_INT, not int.
5371 (struct sound_device.write, vox_write, alsa_write):
5372 Accept EMACS_INT, not int.
5373 (wav_play, au_play): Use EMACS_INT to store sizes and to
5374 record read return values.
5375
5376 2011-04-15 Ben Key <bkey76@gmail.com>
5377
5378 * keyboard.c (Qundefined): Don't declare static since it is used
5379 in nsfns.m.
5380 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5381 static since they are used in nsfont.m.
5382
5383 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5384
5385 * process.c (Qprocessp): Don't declare static.
5386 * lisp.h (Qprocessp): Declare again.
5387
5388 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5389
5390 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5391
5392 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5393
5394 Improve C-level modularity by making more things 'static'.
5395
5396 Don't publish debugger-only interfaces to other modules.
5397 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5398 (verify_bytepos, count_markers): Move decls to the only modules
5399 that need them.
5400 * region-cache.h (pp_cache): Likewise.
5401 * window.h (check_all_windows): Likewise.
5402 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5403
5404 * sysdep.c (croak): Now static, if
5405 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5406 * syssignal.h (croak): Declare only if not static.
5407
5408 * alloc.c (refill_memory_reserve): Now static if
5409 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5410 * lisp.h (refill_memory_reserve): Declare only if not static.
5411
5412 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5413 Define only if USE_LUCID.
5414
5415 * xrdb.c (x_customization_string, x_rm_string): Now static.
5416
5417 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5418 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5419
5420 * xdisp.c (draw_row_with_mouse_face): Now static.
5421 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5422
5423 * window.h (check_all_windows): Mark externally visible.
5424
5425 * window.c (window_deletion_count): Now static.
5426
5427 * undo.c: Make symbols static if they're not exported.
5428 (last_undo_buffer, last_boundary_position, pending_boundary):
5429 Now static.
5430
5431 * textprop.c (interval_insert_behind_hooks): Now static.
5432 (interval_insert_in_front_hooks): Likewise.
5433
5434 * term.c: Make symbols static if they're not exported.
5435 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5436 (max_frame_lines, tty_set_terminal_modes):
5437 (tty_reset_terminal_modes, tty_turn_off_highlight):
5438 (get_tty_terminal): Now static.
5439 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5440 * termhooks.h (term_mouse_moveto): Do not declare if
5441 HAVE_WINDOW_SYSTEM.
5442 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5443 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5444
5445 * sysdep.c: Make symbols static if they're not exported.
5446 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5447 Now static.
5448 (sigprocmask_set, full_mask): Remove; unused.
5449 (wait_debugging): Mark as visible.
5450 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5451 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5452
5453 * syntax.c (syntax_temp): Define only if !__GNUC__.
5454
5455 * sound.c (current_sound_device, current_sound): Now static.
5456
5457 * search.c (searchbufs, searchbuf_head): Now static.
5458
5459 * scroll.c (scroll_cost): Remove; unused.
5460 * dispextern.h (scroll_cost): Remove decl.
5461
5462 * region-cache.h (pp_cache): Mark as externally visible.
5463
5464 * process.c: Make symbols static if they're not exported.
5465 (process_tick, update_tick, create_process, chan_process):
5466 (Vprocess_alist, proc_buffered_char, datagram_access):
5467 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5468 (deactivate_process): Mark defn as static, as well as decl.
5469 * lisp.h (create_process): Remove decl.
5470 * process.h (chan_process, Vprocess_alist): Remove decls.
5471
5472 * print.c: Make symbols static if they're not exported.
5473 (print_depth, new_backquote_output, being_printed, print_buffer):
5474 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5475 (print_interval, print_number_index, initial_stderr_stream):
5476 Now static.
5477 * lisp.h (Fprinc): Remove decl.
5478 (debug_output_compilation_hack): Mark as externally visible.
5479
5480 * sysdep.c (croak): Move decl from here to syssignal.h.
5481 * syssignal.h (croak): Put it here, so the API can be checked when
5482 'croak' is called from dissociate_if_controlling_tty.
5483
5484 * minibuf.c: Make symbols static if they're not exported.
5485 (minibuf_save_list, choose_minibuf_frame): Now static.
5486 * lisp.h (choose_minibuf_frame): Remove decl.
5487
5488 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5489
5490 * lread.c: Make symbols static if they're not exported.
5491 (read_objects, initial_obarray, oblookup_last_bucket_number):
5492 Now static.
5493 (make_symbol): Remove; unused.
5494 * lisp.h (initial_obarray, make_symbol): Remove decls.
5495
5496 * keyboard.c: Make symbols static if they're not exported.
5497 (single_kboard, recent_keys_index, total_keys, recent_keys):
5498 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5499 (this_single_command_key_start, echoing, last_auto_save):
5500 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5501 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5502 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5503 (Vlispy_mouse_stem, double_click_count):
5504 Now static.
5505 (force_auto_save_soon): Define only if SIGDANGER.
5506 (ignore_mouse_drag_p): Now static if
5507 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5508 (print_help): Remove; unused.
5509 (stop_character, last_timer_event): Mark as externally visible.
5510 * keyboard.h (ignore_mouse_drag_p): Declare only if
5511 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5512 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5513 * lisp.h (echoing): Remove decl.
5514 (force_auto_save_soon): Declare only if SIGDANGER.
5515 * xdisp.c (redisplay_window): Simplify code, to make it more
5516 obvious that ignore_mouse_drag_p is not accessed if !defined
5517 USE_GTK && !defined HAVE_NS.
5518
5519 * intervals.c: Make symbols static if they're not exported.
5520 (merge_properties_sticky, merge_interval_right, delete_interval):
5521 Now static.
5522 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5523
5524 * insdel.c: Make symbols static if they're not exported.
5525 However, leave prepare_to_modify_buffer alone. It's never
5526 called from outside this function, but that appears to be a bug.
5527 (combine_after_change_list, combine_after_change_buffer):
5528 (adjust_after_replace, signal_before_change): Now static.
5529 (adjust_after_replace_noundo): Remove; unused.
5530 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5531 (signal_before_change): Remove decls.
5532
5533 * indent.c (val_compute_motion, val_vmotion): Now static.
5534
5535 * image.c: Make symbols static if they're not exported.
5536 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5537 if USE_GTK.
5538 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5539 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5540
5541 * fringe.c (standard_bitmaps): Now static.
5542 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5543
5544 * frame.c: Make symbols static if they're not exported.
5545 (x_report_frame_params, make_terminal_frame): Now static.
5546 (get_frame_param): Now static, unless HAVE_NS.
5547 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5548 (x_get_resource_string): Remove; not used.
5549 * frame.h (make_terminal_frame, x_report_frame_params):
5550 (x_get_resource_string); Remove decls.
5551 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5552 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5553
5554 * font.c, fontset.c: Make symbols static if they're not exported.
5555 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5556 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5557 * font.c (font_close_object): Now static.
5558 * font.h (font_close_object): Remove.
5559 * fontset.c (FONTSET_OBJLIST): Remove.
5560 (free_realized_fontset) #if-0 the body, which does nothing.
5561 (face_suitable_for_char_p): #if-0, as it's never called.
5562 * fontset.h (face_suitable_for_char_p): Remove decl.
5563 * xfaces.c (face_at_string_position):
5564 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5565 since 0 is always ASCII.
5566
5567 * fns.c (weak_hash_tables): Now static.
5568
5569 * fileio.c: Make symbols static if they're not exported.
5570 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5571 (Vwrite_region_annotation_buffers): Now static.
5572
5573 * eval.c: Make symbols static if they're not exported.
5574 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5575 * lisp.h (backtrace_list): Remove decl.
5576
5577 * emacs.c: Make symbols static if they're not exported.
5578 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5579 (fatal_error_code, fatal_error_signal_hook, standard_args):
5580 Now static.
5581 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5582 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5583 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5584 * lisp.h (fatal_error_signal_hook): Remove decl.
5585 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5586
5587 * editfns.c: Move a (normally-unused) function to its only use.
5588 * editfns.c, lisp.h (get_operating_system_release): Remove.
5589 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5590 worth the hassle of breaking this out.
5591
5592 * xterm.c: Make symbols static if they're not exported.
5593 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5594 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5595 (x_destroy_window, x_delete_display):
5596 Now static.
5597 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5598 (x_mouse_leave): Remove; unused.
5599 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5600 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5601 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5602 Remove decls.
5603 (x_mouse_leave): Declare only if WINDOWSNT.
5604 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5605 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5606 USE_X_TOOLKIT.
5607
5608 * ftxfont.c: Make symbols static if they're not exported.
5609 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5610 HAVE_FREETYPE.
5611 * font.h (ftxfont_driver): Likewise.
5612
5613 * xfns.c: Make symbols static if they're not exported.
5614 (x_last_font_name, x_display_info_for_name):
5615 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5616 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5617 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5618 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5619 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5620 (last_show_tip_args): Now static.
5621 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5622 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5623 (x_screen_planes): Remove; unused.
5624 * dispextern.h (x_screen_planes): Remove decl.
5625
5626 * dispnew.c: Make symbols static if they're not exported.
5627 * dispextern.h (redraw_garbaged_frames, scrolling):
5628 (increment_row_positions): Remove.
5629 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5630 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5631 Now static.
5632 (redraw_garbaged_frames): Remove; unused.
5633
5634 * xfaces.c: Make symbols static if they're not exported.
5635 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5636 Remove decls.
5637 * xterm.h (defined_color): Remove decls.
5638 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5639 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5640 (menu_face_changed_default, defined_color, free_realized_face):
5641 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5642 (ascii_face_of_lisp_face): Remove; unused.
5643
5644 * xdisp.c: Make symbols static if they're not exported.
5645 * dispextern.h (scratch_glyph_row, window_box_edges):
5646 (glyph_to_pixel_coords, set_cursor_from_row):
5647 (get_next_display_element, set_iterator_to_next):
5648 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5649 (show_mouse_face): Remove decls
5650 * frame.h (message_buf_print): Likewise.
5651 * lisp.h (pop_message, set_message, check_point_in_composition):
5652 Likewise.
5653 * xterm.h (set_vertical_scroll_bar): Likewise.
5654 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5655 (message_buf_print, scratch_glyph_row, displayed_buffer):
5656 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5657 (get_next_display_element, show_mouse_face, window_box_edges):
5658 (frame_to_window_pixel_xy, check_point_in_composition):
5659 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5660 (glyph_to_pixel_coords): Remove; unused.
5661
5662 * dired.c (file_name_completion): Now static.
5663
5664 * dbusbind.c (xd_in_read_queued_messages): Now static.
5665
5666 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5667 * data.c (circular_list_error): Remove.
5668
5669 * commands.h (last_point_position, last_point_position_buffer):
5670 (last_point_position_window): Remove decls.
5671 * keyboard.c: Make these variables static.
5672
5673 * coding.h (coding, code_convert_region, encode_coding_gap):
5674 Remove decls.
5675 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5676 (iso_code_class, detect_coding, code_convert_region): Now static.
5677 (encode_coding_gap): Remove; unused.
5678
5679 * chartab.c (chartab_chars, chartab_bits): Now static.
5680
5681 * charset.h (charset_iso_8859_1): Remove decl.
5682 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5683 Now static.
5684
5685 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5686 * ccl.c (Vccl_program_table): Now static.
5687 (check_ccl_update): Remove; unused.
5688
5689 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5690 * category.h: ... from here.
5691 * category.c (check_category_table, set_category_set): Now static.
5692
5693 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5694 * lisp.h: Remove these decls.
5695
5696 * buffer.c (buffer_count): Remove unused var.
5697
5698 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5699 so that it's not optimized away.
5700 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5701 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5702 exported only to the debugger.
5703
5704 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5705 * atimer.h (run_all_atimers): Remove; not exported.
5706
5707 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5708 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5709 was inaccessible from Lisp.
5710 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5711 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5712
5713 alloc.c: Import and export fewer symbols, and remove unused items.
5714 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5715 is defined.
5716 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5717 it's not optimized away by whole-program optimization.
5718 (message_enable_multibyte, free_misc): Remove.
5719 (catchlist, handlerlist, mark_backtrace):
5720 Declare only if BYTE_MARK_STACK.
5721 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5722 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5723 (message_enable_multibyte): Remove decl.
5724 (free_misc, interval_free_list, float_block, float_block_index):
5725 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5726 (cons_free_list, last_marked_index):
5727 Now static.
5728 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5729 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5730 (mark_backtrace): Define only if BYTE_MARK_STACK.
5731 * xdisp.c (message_enable_multibyte): Now static.
5732
5733 Declare Lisp_Object Q* variables to be 'static' if not exported.
5734 This makes it easier for human readers (and static analyzers)
5735 to see whether these variables are used from other modules.
5736 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5737 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5738 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5739 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5740 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5741 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5742 * xmenu.c, xselect.c:
5743 Declare Q* vars static if they are not used in other modules.
5744 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5745 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5746 Remove decls of unexported vars.
5747 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5748
5749 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5750
5751 Make Emacs functions such as Fatom 'static' by default.
5752 This makes it easier for human readers (and static analyzers)
5753 to see whether these functions can be called from other modules.
5754 DEFUN now defines a static function. To make the function external
5755 so that it can be used in other C modules, use the new macro DEFUE.
5756 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5757 (Finit_image_library):
5758 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5759 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5760 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5761 Remove decls, since these functions are now static.
5762 (Funintern, Fget_internal_run_time): New decls, since these functions
5763 were already external.
5764
5765 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5766 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5767 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5768 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5769 * keyboard.c, keymap.c, lread.c:
5770 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5771 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5772 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5773 Mark functions with DEFUE instead of DEFUN,
5774 if they are used in other modules.
5775 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5776 decls for now-static functions.
5777 * buffer.h (Fdelete_overlay): Remove decl.
5778 * callproc.c (Fgetenv_internal): Mark as internal.
5779 * composite.c (Fremove_list_of_text_properties): Remove decl.
5780 (Fcomposition_get_gstring): New forward static decl.
5781 * composite.h (Fcomposite_get_gstring): Remove decl.
5782 * dired.c (Ffile_attributes): New forward static decl.
5783 * doc.c (Fdocumntation_property): New forward static decl.
5784 * eval.c (Ffetch_bytecode): New forward static decl.
5785 (Funintern): Remove extern decl; now in .h file where it belongs.
5786 * fileio.c (Fmake_symbolic_link): New forward static decl.
5787 * image.c (Finit_image_library): New forward static decl.
5788 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5789 * intervals.h (Fprevious_property_change):
5790 (Fremove_list_of_text_properties): Remove decls.
5791 * keyboard.c (Fthis_command_keys): Remove decl.
5792 (Fcommand_execute): New forward static decl.
5793 * keymap.c (Flookup_key): New forward static decl.
5794 (Fcopy_keymap): Now static.
5795 * keymap.h (Flookup_key): Remove decl.
5796 * process.c (Fget_process): New forward static decl.
5797 (Fprocess_datagram_address): Mark as internal.
5798 * syntax.c (Fsyntax_table_p): New forward static decl.
5799 (skip_chars): Remove duplicate decl.
5800 * textprop.c (Fprevious_property_change): New forward static decl.
5801 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5802 Now internal.
5803 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5804 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5805
5806 * editfns.c (Fformat): Remove unreachable code.
5807
5808 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5809
5810 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5811 change. (Bug#8496)
5812
5813 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5814
5815 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5816 when at ZV. (Bug#8487)
5817
5818 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5819
5820 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5821 (Bug#8437)
5822 * keyboard.c (parse_tool_bar_item): Likewise.
5823 * sound.c (sound_cleanup, alsa_close): Likewise.
5824 * termcap.c (tgetent): Likewise.
5825 * xfns.c (x_default_font_parameter): Likewise.
5826 * xsettings.c (read_and_apply_settings): Likewise.
5827
5828 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5829 (overrun_check_free): Protoize.
5830
5831 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5832
5833 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5834 since callers should never pass a negative size.
5835 Change the signature to match that of plain 'read' and 'write'; see
5836 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5837 * lisp.h: Update prototypes of emacs_write and emacs_read.
5838
5839 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5840
5841 * xdisp.c (redisplay_window): Don't try to determine the character
5842 position of the scroll margin if the window start point w->startp
5843 is outside the buffer's accessible region. (Bug#8468)
5844
5845 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5846
5847 Fix write-region and its subroutines for buffers > 2GB.
5848 * fileio.c (a_write, e_write): Modify declaration of arguments and
5849 local variables to support buffers larger than 2GB.
5850 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5851
5852 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5853 argument, local variables, and return value.
5854
5855 * lisp.h: Update prototypes of emacs_write and emacs_read.
5856
5857 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5858
5859 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5860
5861 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5862
5863 Fix more problems found by GCC 4.6.0's static checks.
5864
5865 * xdisp.c (vmessage): Use a better test for character truncation.
5866
5867 * charset.c (load_charset_map): <, not <=, for optimization,
5868 and to avoid potential problems with integer overflow.
5869 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5870 * casetab.c (set_identity, shuffle): Likewise.
5871 * editfns.c (Fformat): Likewise.
5872 * syntax.c (skip_chars): Likewise.
5873
5874 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5875 This also lets GCC 4.6.0 generate slightly better loop code.
5876
5877 * callint.c (Fcall_interactively): <, not <=, for optimization.
5878 (Fcall_interactively): Count the number of arguments produced,
5879 not the number of arguments given. This is simpler and lets GCC
5880 4.6.0 generate slightly better code.
5881
5882 * ftfont.c: Distingish more carefully between FcChar8 and char.
5883 The previous code passed unsigned char * to a functions like
5884 strlen and xstrcasecmp that expect char *, which does not
5885 conform to the C standard.
5886 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5887 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5888 char * when the C standard requires it.
5889
5890 * keyboard.c (read_char): Remove unused var.
5891
5892 * eval.c: Port to Windows vsnprintf (Bug#8435).
5893 Include <limits.h>.
5894 (SIZE_MAX): Define if the headers do not.
5895 (verror): Do not give up if vsnprintf returns a negative count.
5896 Instead, grow the buffer. This ports to Windows vsnprintf, which
5897 does not conform to C99. Problem reported by Eli Zaretskii.
5898 Also, simplify the allocation scheme, by avoiding the need for
5899 calling realloc, and removing the ALLOCATED variable.
5900
5901 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5902
5903 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5904 But keep the doprint source code for now, as we might revamp it
5905 and use it again (Bug#8435).
5906 * lisp.h (doprnt): Remove.
5907 * Makefile.in (base_obj): Remove doprnt.o.
5908 * deps.mk (doprnt.o): Remove.
5909
5910 error: Print 32- and 64-bit integers portably (Bug#8435).
5911 Without this change, on typical 64-bit hosts error ("...%d...", N)
5912 was used to print both 32- and 64-bit integers N, which relied on
5913 undefined behavior.
5914 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5915 New macro.
5916 * lisp.h (error, verror): Mark as printf-like functions.
5917 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5918 Report overflow in size calculations when allocating printf buffer.
5919 Do not truncate output string at its first null byte.
5920 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5921 Truncate the output at a character boundary, since vsnprintf does not
5922 do that.
5923 * charset.c (check_iso_charset_parameter): Convert internal
5924 character to string before calling 'error', since %c now has the
5925 printf meaning.
5926 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5927 overflow when computing char to be passed to 'error'. Do not
5928 pass Lisp_Object to 'error'; pass the integer instead.
5929 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5930 formatted with plain %d.
5931
5932 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5933
5934 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5935
5936 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5937
5938 * xterm.c (x_catch_errors): Remove duplicate declaration.
5939
5940 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5941
5942 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5943
5944 2011-04-10 Jim Meyering <meyering@redhat.com>
5945
5946 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5947 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5948 return ssize_t not "int", and use size_t as the buffer length.
5949 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5950 * gnutls.h: Update declarations.
5951 * process.c (read_process_output): Use ssize_t, to match.
5952 (send_process): Likewise.
5953
5954 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5955
5956 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5957
5958 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5959
5960 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5961 Use unsigned char, to match FcChar8 type definition.
5962
5963 * xterm.c (handle_one_xevent):
5964 * xmenu.c (create_and_show_popup_menu):
5965 * xselect.c (x_decline_selection_request)
5966 (x_reply_selection_request): Avoid type-punned deref of X events.
5967
5968 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5969
5970 Fix some uses of `int' instead of EMACS_INT.
5971 * search.c (string_match_1, fast_string_match)
5972 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5973 (scan_buffer, find_next_newline_no_quit)
5974 (find_before_next_newline, search_command, Freplace_match)
5975 (Fmatch_data): Make some `int' variables be EMACS_INT.
5976
5977 * xdisp.c (display_count_lines): 3rd argument and return value now
5978 EMACS_INT. All callers changed.
5979 (pint2hrstr): Last argument is now EMACS_INT.
5980
5981 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5982 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5983 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5984 (decode_coding_utf_16, decode_coding_emacs_mule)
5985 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5986 (decode_coding_ccl, decode_coding_charset)
5987 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5988 (decode_coding_iso_2022, decode_coding_emacs_mule)
5989 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5990 <char_offset, last_offset>: Declare EMACS_INT.
5991 (encode_coding_utf_8, encode_coding_utf_16)
5992 (encode_coding_emacs_mule, encode_invocation_designation)
5993 (encode_designation_at_bol, encode_coding_iso_2022)
5994 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5995 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5996 Declare EMACS_INT.
5997 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5998 (encode_invocation_designation): Last argument P_NCHARS is now
5999 EMACS_INT.
6000 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6001 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6002
6003 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6004 All users changed.
6005
6006 * ccl.c (Fccl_execute_on_string): Declare some variables
6007 EMACS_INT.
6008
6009 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6010
6011 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6012
6013 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6014
6015 * process.c (Fformat_network_address): Doc fix.
6016
6017 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6018
6019 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6020
6021 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6022
6023 * keyboard.c (read_char): Call Lisp function help-form-show,
6024 instead of using internal_with_output_to_temp_buffer.
6025 (Qhelp_form_show): New var.
6026 (syms_of_keyboard): Use DEFSYM macro.
6027
6028 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6029
6030 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6031
6032 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6033
6034 * process.c (Flist_processes): Remove to Lisp.
6035 (list_processes_1): Delete.
6036
6037 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6038
6039 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6040
6041 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6042
6043 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6044
6045 Fix more problems found by GCC 4.6.0's static checks.
6046
6047 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6048
6049 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6050
6051 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6052
6053 * xdisp.c (vmessage): Mark as a printf-like function.
6054
6055 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6056
6057 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6058
6059 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6060 printf-like functions.
6061 (tiff_load): Add casts to remove these marks before passing them
6062 to system-supplied API.
6063
6064 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6065
6066 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6067 This avoids several warnings with gcc -Wstrict-overflow.
6068 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6069 directly, rather than having caller test rule sign. This avoids
6070 some unnecessary tests.
6071 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6072 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6073 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6074
6075 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6076 (xfont_open): Avoid unnecessary tests.
6077
6078 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6079
6080 * composite.h, composite.c (composition_gstring_put_cache):
6081 Use EMACS_INT, not int, for length.
6082
6083 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6084 breaking out part of COMPOSITION_DECODE_RULE.
6085 (COMPOSITION_DECODE_RULE): Use it.
6086 * composite.c (get_composition_id): Remove unused local vars,
6087 by using the new macro.
6088
6089 * textprop.c (set_text_properties_1): Change while to do-while,
6090 since the condition is always true at first.
6091
6092 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6093 (interval_deletion_adjustment): Return unsigned value.
6094 All uses changed.
6095
6096 * process.c (list_processes_1, create_pty, read_process_output):
6097 (exec_sentinel): Remove vars that were set but not used.
6098 (create_pty): Remove unnecessary "volatile"s.
6099 (Fnetwork_interface_info): Avoid possibility of int overflow.
6100 (read_process_output): Do adaptive read buffering even if carryover.
6101 (read_process_output): Simplify nbytes computation if buffered.
6102
6103 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6104
6105 * syntax.c (scan_words): Remove var that was set but not used.
6106 (update_syntax_table): Use unsigned instead of int.
6107
6108 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6109 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6110 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6111
6112 * print.c (print_error_message): Avoid int overflow.
6113
6114 * font.c (font_list_entities): Redo for clarity,
6115 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6116
6117 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6118 (font_score): Avoid potential overflow in diff calculation.
6119
6120 * fns.c (substring_both): Remove var that is set but not used.
6121 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6122
6123 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6124
6125 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6126 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6127 can always succeed if overflow has undefined behavior.
6128
6129 * search.c (boyer_moore, wordify): Remove vars set but not used.
6130 (wordify): Omit three unnecessary tests.
6131
6132 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6133 All callers changed. This avoids the need for an unused var.
6134
6135 * casefiddle.c (casify_region): Remove var that is set but not used.
6136
6137 * dired.c (file_name_completion): Remove var that is set but not used.
6138
6139 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6140
6141 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6142 (Finsert_file_contents): Remove unnecessary code checking fd.
6143
6144 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6145 Check for integer overflow on size calculations.
6146
6147 * buffer.c (Fprevious_overlay_change): Remove var that is set
6148 but not used.
6149
6150 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6151 Remove vars that are set but not used.
6152 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6153 (timer_check_2): Mark vars as initialized.
6154
6155 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6156
6157 * image.c (lookup_image): Remove var that is set but not used.
6158 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6159
6160 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6161 that are set but not used.
6162
6163 * xfns.c (make_invisible_cursor): Don't return garbage
6164 if XCreateBitmapFromData fails (Bug#8410).
6165
6166 * xselect.c (x_get_local_selection, x_handle_property_notify):
6167 Remove vars that are set but not used.
6168
6169 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6170 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6171
6172 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6173 Remove var that is set but not used.
6174 (scroll_bar_windows_size): Now size_t, not int.
6175 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6176 Check for overflow.
6177
6178 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6179 (map_tty_color) [!defined MSDOS]: Likewise.
6180
6181 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6182
6183 * coding.c: Remove vars that are set but not used.
6184 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6185 All callers changed.
6186 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6187 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6188 (decode_coding_charset): Remove vars that are set but not used.
6189
6190 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6191 that is set but not used.
6192
6193 * print.c (print_object): Remove var that is set but not used.
6194
6195 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6196 The gnulib version avoids calling malloc in the usual case,
6197 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6198 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6199 * filelock.c (current_lock_owner): Likewise.
6200 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6201 * sysdep.c: Include allocator.h, careadlinkat.h.
6202 (emacs_no_realloc_allocator): New static constant.
6203 (emacs_readlink): New function.
6204 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6205 ../lib/careadlinkat.h.
6206
6207 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6208
6209 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6210 first non-nil return value).
6211
6212 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6213
6214 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6215 if not defined (Bug#8403).
6216
6217 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6218
6219 * xdisp.c (display_count_lines): Remove parameter `start',
6220 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6221 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6222 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6223 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6224 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6225 and thereabouts. All callers changed.
6226 (get_per_char_metric): Remove parameter `f', unused since
6227 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6228
6229 2011-04-02 Jim Meyering <meyering@redhat.com>
6230
6231 do not dereference NULL upon failed strdup
6232 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6233 (ns_get_family): Likewise.
6234
6235 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6236
6237 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6238
6239 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6240
6241 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6242 later (Bug#8403).
6243
6244 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6245
6246 Add lexical binding.
6247
6248 * window.c (Ftemp_output_buffer_show): New fun.
6249 (Fsave_window_excursion):
6250 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6251
6252 * lread.c (lisp_file_lexically_bound_p): New function.
6253 (Fload): Bind Qlexical_binding.
6254 (readevalloop): Remove `evalfun' arg.
6255 Bind Qinternal_interpreter_environment.
6256 (Feval_buffer): Bind Qlexical_binding.
6257 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6258 Mark as dynamic.
6259 (syms_of_lread): Declare `lexical-binding'.
6260
6261 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6262
6263 * keyboard.c (eval_dyn): New fun.
6264 (menu_item_eval_property): Use it.
6265
6266 * image.c (parse_image_spec): Use Ffunctionp.
6267
6268 * fns.c (concat, mapcar1): Accept byte-code-functions.
6269
6270 * eval.c (Fsetq): Handle lexical vars.
6271 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6272 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6273 (FletX, Flet): Obey lexical binding.
6274 (Fcommandp): Handle closures.
6275 (Feval): New `lexical' arg.
6276 (eval_sub): New function extracted from Feval. Use it almost
6277 everywhere where Feval was used. Look up vars in lexical env.
6278 Handle closures.
6279 (Ffunctionp): Move from subr.el.
6280 (Ffuncall): Handle closures.
6281 (apply_lambda): Remove `eval_flags'.
6282 (funcall_lambda): Handle closures and new byte-code-functions.
6283 (Fspecial_variable_p): New function.
6284 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6285 but without exporting it to Lisp.
6286
6287 * doc.c (Fdocumentation, store_function_docstring):
6288 * data.c (Finteractive_form): Handle closures.
6289
6290 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6291 interactive spec.
6292
6293 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6294 New byte-codes.
6295 (exec_byte_code): New function extracted from Fbyte_code to handle new
6296 calling convention for byte-code-functions. Add new byte-codes.
6297
6298 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6299
6300 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6301
6302 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6303
6304 * xdisp.c (redisplay_internal): Fix prototype.
6305
6306 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6307
6308 * xdisp.c (SCROLL_LIMIT): New macro.
6309 (try_scrolling): Use it when setting scroll_limit.
6310 Limit scrolling to 100 screen lines.
6311 (redisplay_window): Even when falling back on "recentering",
6312 position point in the window according to scroll-conservatively,
6313 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6314
6315 (try_scrolling): When point is above the window, allow searching
6316 as far as scroll_max, or one screenful, to compute vertical
6317 distance from PT to the scroll margin position. This prevents
6318 try_scrolling from unnecessarily failing when
6319 scroll-conservatively is set to a value slightly larger than the
6320 window height. Clean up the case of PT below the margin at bottom
6321 of window: scroll_max can no longer be INT_MAX. When aggressive
6322 scrolling is in use, don't let point enter the opposite scroll
6323 margin as result of the scroll.
6324 (syms_of_xdisp) <scroll-conservatively>: Document the
6325 threshold of 100 lines for never-recentering scrolling.
6326
6327 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6328
6329 * dispextern.h (move_it_by_lines):
6330 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6331 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6332 (message_log_check_duplicate): Remove parameters `prev_bol' and
6333 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6334 (redisplay_internal): Remove parameter `preserve_echo_area',
6335 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6336
6337 * indent.c (Fvertical_motion):
6338 * window.c (window_scroll_pixel_based, Frecenter):
6339 Don't pass `need_y_p' to `move_it_by_lines'.
6340
6341 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6342
6343 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6344 steal a few bits to be more compact.
6345 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6346 Remove unneeded casts.
6347
6348 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6349
6350 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6351
6352 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6353 binding" message (bug#7967).
6354
6355 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6356
6357 Fix more problems found by GCC 4.6.0's static checks.
6358
6359 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6360 Remove unused local var.
6361
6362 * editfns.c (Fmessage_box): Remove unused local var.
6363
6364 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6365 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6366 Omit unused local vars.
6367 * window.c (shrink_windows): Omit unused local var.
6368 * menu.c (digest_single_submenu): Omit unused local var.
6369 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6370 Omit unused local var.
6371
6372 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6373 Don't assume string length fits in int.
6374 (keyremap_step, read_key_sequence): Use size_t for sizes.
6375 (read_key_sequence): Don't check last_real_key_start redundantly.
6376
6377 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6378 instead of alloca (Bug#8344).
6379
6380 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6381 (Fbacktrace_frame): Don't assume nframes fits in int.
6382
6383 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6384
6385 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6386 concerns.
6387
6388 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6389
6390 * cm.c (calccost): Turn while-do into do-while, for clarity.
6391
6392 * keyboard.c (syms_of_keyboard): Use the same style as later
6393 in this function when indexing through an array. This also
6394 works around GCC bug 48267.
6395
6396 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6397
6398 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6399
6400 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6401 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6402
6403 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6404 This avoids undefined behavior on integer overflow, and is a bit
6405 more convenient anyway since it is compared to a size_t variable.
6406
6407 Variadic C functions now count arguments with size_t, not int.
6408 This avoids an unnecessary limitation on 64-bit machines, which
6409 caused (substring ...) to crash on large vectors (Bug#8344).
6410 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6411 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6412 All variadic functions and their callers changed accordingly.
6413 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6414 * data.c (arith_driver, float_arith_driver): Likewise.
6415 * editfns.c (general_insert_function): Likewise.
6416 * eval.c (struct backtrace.nargs, interactive_p)
6417 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6418 (funcall_lambda, mark_backtrace): Likewise.
6419 * fns.c (concat): Likewise.
6420 * frame.c (x_set_frame_parameters): Likewise.
6421 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6422 0 if not found, not -1. All callers changed.
6423
6424 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6425 (stack_copy_size): Now size_t, not int.
6426 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6427
6428 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6429
6430 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6431 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6432 All callers changed.
6433
6434 * lisp.h (multibyte_char_to_unibyte):
6435 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6436 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6437 * character.h (CHAR_TO_BYTE8):
6438 * cmds.c (internal_self_insert):
6439 * editfns.c (general_insert_function):
6440 * keymap.c (push_key_description):
6441 * search.c (Freplace_match):
6442 * xdisp.c (message_dolog, set_message_1): All callers changed.
6443
6444 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6445
6446 * keyboard.c (safe_run_hook_funcall): New function.
6447 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6448 don't set the hook to nil, but remove the offending function instead.
6449 (Qcommand_hook_internal): Remove, unused.
6450 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6451 Vcommand_hook_internal.
6452
6453 * eval.c (enum run_hooks_condition): Remove.
6454 (funcall_nil, funcall_not): New functions.
6455 (run_hook_with_args): Call each function through a `funcall' argument.
6456 Remove `cond' argument, now redundant.
6457 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6458 (Frun_hook_with_args_until_failure): Adjust accordingly.
6459 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6460
6461 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6462
6463 * dispextern.h (string_buffer_position): Remove declaration.
6464
6465 * print.c (strout): Remove parameter `multibyte', unused since
6466 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6467
6468 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6469 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6470 All callers changed.
6471
6472 * w32.c (_wsa_errlist): Use braces for struct initializers.
6473
6474 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6475 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6476 All callers changed.
6477 (string_buffer_position): Likewise. Also, make static (it's never
6478 used outside xdisp.c).
6479 (cursor_row_p): Remove parameter `w', unused since
6480 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6481 (decode_mode_spec): Remove parameter `precision', introduced during
6482 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6483 All callers changed.
6484
6485 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6486
6487 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6488
6489 2011-03-27 Anders Lindgren <andlind@gmail.com>
6490
6491 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6492 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6493 (ns_update_auto_hide_menu_bar): New functions.
6494 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6495 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6496 ns_constrain_all_frames.
6497 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6498 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6499
6500 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6501
6502 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6503
6504 2011-03-27 Glenn Morris <rgm@gnu.org>
6505
6506 * syssignal.h: Replace RETSIGTYPE with void.
6507 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6508 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6509 Replace SIGTYPE with void everywhere.
6510 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6511 * s/template.h (SIGTYPE): Remove commented out definition.
6512
6513 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6514
6515 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6516 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6517
6518 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6519
6520 * w32.c (read_unc_volume): Use parameter `henum', instead of
6521 global variable `wget_enum_handle'.
6522
6523 * keymap.c (describe_vector): Remove parameters `indices' and
6524 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6525 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6526
6527 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6528
6529 * keyboard.c (timer_check): Remove parameter `do_it_now',
6530 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6531 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6532 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6533
6534 * keyboard.c (read_char):
6535 * w32menu.c (w32_menu_display_help):
6536 * xmenu.c (show_help_event, menu_help_callback):
6537 Adjust calls to `show_help_echo'.
6538
6539 * gtkutil.c (xg_maybe_add_timer):
6540 * keyboard.c (readable_events):
6541 * process.c (wait_reading_process_output):
6542 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6543
6544 * insdel.c (adjust_markers_gap_motion):
6545 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6546 (gap_left, gap_right): Don't call it.
6547
6548 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6549
6550 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6551 incurred during fontification.
6552
6553 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6554
6555 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6556 (DEFVAR_PER_BUFFER): Don't pass it.
6557
6558 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6559 (scrolling_window): Don't pass it.
6560
6561 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6562
6563 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6564
6565 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6566 and `suffix'.
6567 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6568 of variables specific to SELinux and computation of `encoded_absname'.
6569
6570 * image.c (XPutPixel): Remove unused variable `height'.
6571
6572 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6573
6574 * unexw32.c (get_section_info): Remove unused variable `section'.
6575
6576 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6577 (system_process_attributes): Remove unused variable `sess'.
6578 (sys_read): Remove unused variable `err'.
6579
6580 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6581 (w32_wnd_proc): Remove unused variable `isdead'.
6582 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6583 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6584 (x_create_tip_frame): Remove unused variable `tem'.
6585
6586 * w32inevt.c (w32_console_read_socket):
6587 Remove unused variable `no_events'.
6588
6589 * w32term.c (x_draw_composite_glyph_string_foreground):
6590 Remove unused variable `width'.
6591
6592 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6593
6594 * w32term.c (x_set_glyph_string_clipping):
6595 Don't pass uninitialized region to CombineRgn.
6596
6597 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6598
6599 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6600 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6601 (Fx_close_connection): Remove unused variable `i'.
6602
6603 * w32font.c (w32font_draw): Return number of glyphs.
6604 (w32font_open_internal): Remove unused variable `i'.
6605 (w32font_driver): Add missing initializer.
6606
6607 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6608 (fill_in_menu): Remove unused variable `items_added'.
6609
6610 * w32term.c (last_mouse_press_frame): Remove static global variable.
6611 (w32_clip_to_row): Remove unused variable `f'.
6612 (x_delete_terminal): Remove unused variable `i'.
6613
6614 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6615 (NOTHING): Remove unused static global variable.
6616 (uniscribe_check_otf): Remove unused variable `table'.
6617 (uniscribe_font_driver): Add missing initializers.
6618
6619 2011-03-23 Julien Danjou <julien@danjou.info>
6620
6621 * term.c (Fsuspend_tty, Fresume_tty):
6622 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6623 * window.c (temp_output_buffer_show):
6624 * insdel.c (signal_before_change):
6625 * frame.c (Fhandle_switch_frame):
6626 * fileio.c (Fdo_auto_save):
6627 * emacs.c (Fkill_emacs):
6628 * editfns.c (save_excursion_restore):
6629 * cmds.c (internal_self_insert):
6630 * callint.c (Fcall_interactively):
6631 * buffer.c (Fkill_all_local_variables):
6632 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6633 Use Frun_hooks.
6634 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6635 unconditionnaly since it does the check itself.
6636
6637 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6638
6639 Fix more problems found by GCC 4.5.2's static checks.
6640
6641 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6642 the first time through the loop, since we know p0 < p1 then.
6643 This also avoids a gcc -Wstrict-overflow warning.
6644
6645 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6646 leading to a memory leak, possible in functions like
6647 load_charset_map_from_file that can allocate an unbounded number
6648 of objects (Bug#8318).
6649
6650 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6651 that could (at least in theory) be that large.
6652
6653 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6654 This is less likely to overflow, and avoids undefined behavior if
6655 overflow does occur. All callers changed. Use strtoul to scan
6656 for the unsigned long integer.
6657 (pint2hrstr): Simplify and tune code slightly.
6658 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6659
6660 * scroll.c (do_scrolling): Work around GCC bug 48228.
6661 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6662
6663 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6664 This also avoids a warning with gcc -Wstrict-overflow.
6665 (validate_x_resource_name): Simplify count usage.
6666 This also avoids a warning with gcc -Wstrict-overflow.
6667
6668 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6669 fail (Bug#8306).
6670
6671 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6672
6673 * process.c (Fmake_network_process): Use socklen_t, not int,
6674 where POSIX says socklen_t is required in portable programs.
6675 This fixes a porting bug on hosts like 64-bit HP-UX, where
6676 socklen_t is wider than int (Bug#8277).
6677 (Fmake_network_process, server_accept_connection):
6678 (wait_reading_process_output, read_process_output):
6679 Likewise.
6680
6681 * process.c: Rename or move locals to avoid shadowing.
6682 (list_processes_1, Fmake_network_process):
6683 (read_process_output_error_handler, exec_sentinel_error_handler):
6684 Rename or move locals.
6685 (Fmake_network_process): Define label "retry_connect" only if needed.
6686 (Fnetwork_interface_info): Fix pointer signedness.
6687 (process_send_signal): Add cast to avoid pointer signedness problem.
6688 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6689 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6690
6691 Make tparam.h and terminfo.c consistent.
6692 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6693 Include tparam.h instead, since it declares them.
6694 * cm.h (PC): Remove extern decl; tparam.h now does this.
6695 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6696 * terminfo.c: Include tparam.h, to check interfaces.
6697 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6698 (tparam): Adjust signature to match interface in tparam.h;
6699 this removes some undefined behavior. Check that outstring and len
6700 are zero, which they always are with Emacs.
6701 * tparam.h (PC, BC, UP): New extern decls.
6702
6703 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6704 (xftfont_open): Rename locals to avoid shadowing.
6705
6706 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6707 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6708 (OTF_TAG_SYM): Omit macro if not needed.
6709 (ftfont_list): Remove unused local.
6710 (get_adstyle_property, ftfont_pattern_entity):
6711 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6712 Rename locals to avoid shadowing.
6713
6714 * xfont.c (xfont_list_family): Mark var as initialized.
6715
6716 * xml.c (make_dom): Now static.
6717
6718 * composite.c (composition_compute_stop_pos): Rename local to
6719 avoid shadowing.
6720 (composition_reseat_it): Remove unused locals.
6721 (find_automatic_composition, composition_adjust_point): Likewise.
6722 (composition_update_it): Mark var as initialized.
6723 (find_automatic_composition): Mark vars as initialized,
6724 with a FIXME (Bug#8290).
6725
6726 character.h: Rename locals to avoid shadowing.
6727 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6728 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6729 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6730 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6731 to avoid shadowing.
6732
6733 * textprop.c (property_change_between_p): Remove; unused.
6734
6735 * intervals.c (interval_start_pos): Now static.
6736
6737 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6738
6739 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6740 Rename locals to avoid shadowing.
6741
6742 * sound.c (wav_play, au_play, Fplay_sound_internal):
6743 Fix pointer signedness.
6744 (alsa_choose_format): Remove unused local var.
6745 (wav_play): Initialize a variable to 0, to prevent undefined
6746 behavior (Bug#8278).
6747
6748 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6749
6750 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6751
6752 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6753 clobbering (Bug#8298).
6754 * sysdep.c (sys_subshell): Likewise.
6755 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6756
6757 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6758 This should get cleaned up, so that child_setup has the
6759 same signature on all platforms.
6760
6761 * callproc.c (call_process_cleanup): Now static.
6762 (relocate_fd): Rename locals to avoid shadowing.
6763
6764 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6765
6766 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6767 not to be necessary, and produces flickering.
6768
6769 2011-03-20 Glenn Morris <rgm@gnu.org>
6770
6771 * config.in: Remove file.
6772
6773 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6774
6775 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6776 are now in src/globals.h.
6777 (syms_of_minibuf): Remove spurious & from previous change.
6778
6779 2011-03-20 Leo <sdl.web@gmail.com>
6780
6781 * minibuf.c (completing-read-function): New variable.
6782 (completing-read-default): Rename from completing-read.
6783 (completing-read): Call completing-read-function.
6784
6785 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6786
6787 * xfaces.c (Fx_load_color_file):
6788 Read color file from absolute filename (bug#8250).
6789
6790 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6791
6792 * makefile.w32-in: Update dependencies.
6793
6794 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6795
6796 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6797
6798 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6799
6800 Fix more problems found by GCC 4.5.2's static checks.
6801
6802 * process.c (make_serial_process_unwind, send_process_trap):
6803 (sigchld_handler): Now static.
6804
6805 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6806 That way, the code declares only the vars that it needs.
6807 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6808 * s/cygwin.h (PTY_ITERATION): Likewise.
6809 * s/darwin.h (PTY_ITERATION): Likewise.
6810 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6811
6812 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6813 * process.c (allocate_pty): Don't declare stb unless it's needed.
6814
6815 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6816 (CONSTANTLIM): Remove; unused.
6817 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6818 Define only if needed.
6819
6820 * unexelf.c (unexec): Name an expression,
6821 to avoid gcc -Wbad-function-cast warning.
6822 Use a different way to cause a compilation error if anyone uses
6823 n rather than nn, a way that does not involve shadowing.
6824 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6825
6826 * deps.mk (unexalpha.o): Remove; unused.
6827
6828 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6829 * unexec.h: New file.
6830 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6831 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6832 Depend on unexec.h.
6833 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6834 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6835 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6836 Change as necessary to match prototype in unexec.h.
6837
6838 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6839 shadowing.
6840 (back_comment, skip_chars): Mark vars as initialized.
6841
6842 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6843 Rename locals to avoid shadowing.
6844
6845 * lread.c (read1): Rewrite so as not to use empty "else".
6846 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6847
6848 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6849
6850 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6851 warning when compiling print.c.
6852
6853 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6854 instead of using an uninitialized var.
6855 (font_sort_entities): Mark var as initialized.
6856
6857 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6858
6859 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6860 pointers to constants.
6861 (font_parse_fcname): Remove unused vars.
6862 (font_delete_unmatched): Now static.
6863 (font_get_spec): Remove; unused.
6864 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6865 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6866 Rename or move locals to avoid shadowing.
6867
6868 * fns.c (require_nesting_list, require_unwind): Now static.
6869 (Ffillarray): Rename locals to avoid shadowing.
6870
6871 * floatfns.c (domain_error2): Define only if needed.
6872 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6873
6874 * alloc.c (mark_backtrace): Move decl from here ...
6875 * lisp.h: ... to here, so that it can be checked.
6876
6877 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6878 (Fdefvar): Rewrite so as not to use empty "else".
6879 (lisp_indirect_variable): Name an expression,
6880 to avoid gcc -Wbad-function-cast warning.
6881 (Fdefvar): Rename locals to avoid shadowing.
6882
6883 * callint.c (quotify_arg, quotify_args): Now static.
6884 (Fcall_interactively): Rename locals to avoid shadowing.
6885 Use const pointer when appropriate.
6886
6887 * lisp.h (get_system_name, get_operating_system_release):
6888 Move decls here, to check interfaces.
6889 * process.c (get_operating_system_release): Move decl to lisp.h.
6890 * xrdb.c (get_system_name): Likewise.
6891 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6892 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6893 some of which prompt warnings from gcc -Wbad-function-cast.
6894 (Fformat_time_string, Fencode_time, Finsert_char):
6895 (Ftranslate_region_internal, Fformat):
6896 Rename or remove local vars to avoid shadowing.
6897 (Ftranslate_region_internal): Mark var as initialized.
6898
6899 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6900 avoid shadowing.
6901
6902 * lisp.h (eassert): Check that the argument compiles, even if
6903 ENABLE_CHECKING is not defined.
6904
6905 * data.c (Findirect_variable): Name an expression, to avoid
6906 gcc -Wbad-function-cast warning.
6907 (default_value, arithcompare, arith_driver, arith_error): Now static.
6908 (store_symval_forwarding): Rename local to avoid shadowing.
6909 (Fmake_variable_buffer_local, Fmake_local_variable):
6910 Mark variables as initialized.
6911 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6912
6913 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6914 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6915 Rename locals to avoid shadowing.
6916 (mark_stack): Move local variables into the #ifdef region where
6917 they're used.
6918 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6919 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6920 needed otherwise.
6921 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6922 (GC_STRING_CHARS): Remove; not used.
6923 (Fmemory_limit): Cast sbrk's returned value to char *.
6924
6925 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6926 avoids undefined behavior in theory.
6927
6928 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6929
6930 Use functions, not macros, for up- and down-casing (Bug#8254).
6931 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6932 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6933 to use the following functions instead of these macros.
6934 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6935 EMACS_INT, since callers assume the returned value fits in int.
6936 (upcase1): Likewise, for UPCASE_TABLE.
6937 (uppercasep, lowercasep, upcase): New static inline functions.
6938 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6939 the race-condition problem in the old DOWNCASE.
6940
6941 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6942 Rename locals to avoid shadowing.
6943 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6944 (regex_compile, re_search_2, re_match_2_internal):
6945 Remove unused local vars.
6946 (FREE_VAR): Rewrite so as not to use empty "else",
6947 which gcc can warn about.
6948 (regex_compile, re_match_2_internal): Mark locals as initialized.
6949 (RETALLOC_IF): Define only if needed.
6950 (WORDCHAR_P): Likewise. This one is never needed, but is used
6951 only in a comment talking about a compiler bug, so put inside
6952 the #if 0 of that comment.
6953 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6954 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6955 Remove; unused.
6956
6957 * search.c (boyer_moore): Rename locals to avoid shadowing.
6958 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6959 (PREV_CHAR_BOUNDARY): Likewise.
6960
6961 * search.c (simple_search): Remove unused var.
6962
6963 * dired.c (compile_pattern): Move decl from here ...
6964 * lisp.h: ... to here, so that it can be checked.
6965 (struct re_registers): New forward decl.
6966
6967 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6968
6969 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6970 All uses changed.
6971 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6972 Rename locals to avoid shadowing.
6973 (Fvertical_motion): Mark locals as initialized.
6974
6975 * casefiddle.c (casify_object, casify_region): Now static.
6976 (casify_region): Mark local as initialized.
6977
6978 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6979
6980 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6981 New macros, so that the caller can use some names other than
6982 gcpro1, gcpro2, etc.
6983 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6984 of the new macros.
6985 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6986 argument, for consistency with GCPRO2_VAR, etc: it is now the
6987 prefix of the variable, not the variable itself. All uses
6988 changed.
6989 * dired.c (directory_files_internal, file_name_completion):
6990 Rename locals to avoid shadowing.
6991
6992 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6993 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6994 dired.c's scmp function, had undefined behavior.
6995 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6996 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6997 * buffer.h: ... to here, because these macros use current_buffer,
6998 and the new implementation with inline functions needs to have
6999 current_buffer in scope now, rather than later when the macros
7000 are used.
7001 (downcase, upcase1): New static inline functions.
7002 (DOWNCASE, UPCASE1): Reimplement using these functions.
7003 This avoids undefined behavior in expressions like
7004 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7005 from race conditions in accessing the global variables
7006 case_temp1 and case_temp2.
7007 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7008 * lisp.h (case_temp1, case_temp2): Remove their decls.
7009 * character.h (ASCII_CHAR_P): Move from here ...
7010 * lisp.h: ... to here, so that the inline functions mentioned
7011 above can use them.
7012
7013 * dired.c (directory_files_internal_unwind): Now static.
7014
7015 * fileio.c (file_name_as_directory, directory_file_name):
7016 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7017 Now static.
7018 (file_name_as_directory): Use const pointers when appropriate.
7019 (Fexpand_file_name): Likewise. In particular, newdir might
7020 point at constant storage, so make it a const pointer.
7021 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7022 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7023 signedness issues.
7024 (Fset_file_times, Finsert_file_contents, auto_save_error):
7025 Rename locals to avoid shadowing.
7026
7027 * minibuf.c (choose_minibuf_frame_1): Now static.
7028 (Ftry_completion, Fall_completions): Rename or remove locals
7029 to avoid shadowing.
7030
7031 * marker.c (bytepos_to_charpos): Remove; unused.
7032
7033 * lisp.h (verify_bytepos, count_markers): New decls,
7034 so that gcc does not warn that these functions aren't declared.
7035
7036 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7037 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7038 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7039 (copy_text): Remove unused local var.
7040
7041 * filelock.c (within_one_second): Now static.
7042 (lock_file_1): Rename local to avoid shadowing.
7043
7044 * buffer.c (fix_overlays_before): Mark locals as initialized.
7045 (fix_start_end_in_overlays): Likewise. This function should be
7046 simplified by using pointers-to-pointers, but that's a different
7047 matter.
7048 (switch_to_buffer_1): Now static.
7049 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7050 (report_overlay_modification): Rename locals to avoid shadowing.
7051
7052 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7053 Fix pointer signedness issue.
7054 (sys_subshell): Mark local as volatile if checking for lint,
7055 to suppress a gcc -Wclobbered warning that does not seem to be right.
7056 (MAXPATHLEN): Define only if needed.
7057
7058 * process.c (serial_open, serial_configure): Move decls from here ...
7059 * systty.h: ... to here, so that they can be checked.
7060
7061 * fns.c (get_random, seed_random): Move extern decls from here ...
7062 * lisp.h: ... to here, so that they can be checked.
7063
7064 * sysdep.c (reset_io): Now static.
7065 (wait_for_termination_signal): Remove; unused.
7066
7067 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7068 (copy_keymap_item, append_key, push_text_char_description):
7069 Now static.
7070 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7071 (DENSE_TABLE_SIZE): Remove; unused.
7072 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7073 (describe_map_tree):
7074 Rename locals to avoid shadowing.
7075
7076 * keyboard.c: Declare functions static if they are not used elsewhere.
7077 (echo_char, echo_dash, cmd_error, top_level_2):
7078 (poll_for_input, handle_async_input): Now static.
7079 (read_char, kbd_buffer_get_event, make_lispy_position):
7080 (make_lispy_event, make_lispy_movement, apply_modifiers):
7081 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7082 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7083 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7084 (read_key_sequence, read_char): Mark locals as initialized.
7085 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7086
7087 * keyboard.h (make_ctrl_char): New decl.
7088 (mark_kboards): Move decl here ...
7089 * alloc.c (mark_kboards): ... from here.
7090
7091 * lisp.h (force_auto_save_soon): New decl.
7092
7093 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7094 (DEFINE_DUMMY_FUNCTION): New macro.
7095 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7096 Use it.
7097 (main): Add casts to avoid warnings
7098 if GCC considers string literals to be constants.
7099
7100 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7101
7102 * dbusbind.c: Pointer signedness fixes.
7103 (xd_signature, xd_append_arg, xd_initialize):
7104 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7105 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7106 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7107 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7108
7109 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7110 if GCC considers string literals to be constants.
7111 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7112
7113 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7114
7115 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7116 (print_preprocess, print_object): New macro to fix last change.
7117
7118 * print.c (print_preprocess): Don't forget font objects.
7119
7120 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7121
7122 * emacs.c (USAGE3): Doc fixes.
7123
7124 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7125
7126 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7127 structure.
7128
7129 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7130
7131 * lisp.h (VWindow_system, Qfile_name_history):
7132 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7133 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7134 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7135
7136 * w32select.c: Don't #include "keyboard.h".
7137 (run_protected): Add extern declaration for waiting_for_input.
7138
7139 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7140 * w32console.c (detect_input_pending, read_input_pending)
7141 (encode_terminal_code):
7142 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7143 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7144 (w32_system_caret_y, Qfile_name_history):
7145 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7146 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7147 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7148 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7149 * w32proc.c (Qlocal, report_file_error):
7150 * w32term.c (Vwindow_system, updating_frame):
7151 * w32uniscribe.c (initialized, uniscribe_font_driver):
7152 Remove unneeded extern declarations.
7153
7154 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7155
7156 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7157
7158 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7159
7160 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7161 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7162 These macros can no longer be used for assignment.
7163
7164 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7165 Assign struct members directly, instead of using BUF_BEGV etc.
7166 (record_buffer_markers, fetch_buffer_markers): New functions for
7167 recording and fetching special buffer markers.
7168 (set_buffer_internal_1, set_buffer_temp): Use them.
7169
7170 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7171
7172 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7173
7174 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7175 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7176
7177 * xdisp.c (hscroll_window_tree):
7178 (reconsider_clip_changes): Use PT instead of BUF_PT.
7179
7180 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7181
7182 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7183 $(EMACS_ROOT)/lib/intprops.h.
7184
7185 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7186
7187 Fix more problems found by GCC 4.5.2's static checks.
7188
7189 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7190 to unsigned char * to avoid compiler diagnostic.
7191 (xg_free_frame_widgets): Make it clear that a local variable is
7192 needed only if USE_GTK_TOOLTIP.
7193 (gdk_window_get_screen): Make it clear that this macro is needed
7194 only if USE_GTK_TOOLTIP.
7195 (int_gtk_range_get_value): New function, which avoids a diagnostic
7196 from gcc -Wbad-function-cast.
7197 (xg_set_toolkit_scroll_bar_thumb): Use it.
7198 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7199 diagnostic from gcc -Wbad-function-cast.
7200 (get_utf8_string, xg_get_file_with_chooser):
7201 Rename locals to avoid shadowing.
7202 (create_dialog): Move locals to avoid shadowing.
7203
7204 * xgselect.c (xg_select): Remove unused var.
7205
7206 * image.c (four_corners_best): Mark locals as initialized.
7207 (gif_load): Initialize transparent_p to zero (Bug#8238).
7208 Mark another local as initialized.
7209 (my_png_error, my_error_exit): Mark with NO_RETURN.
7210
7211 * image.c (clear_image_cache): Now static.
7212 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7213 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7214 (x_edge_detection): Remove unnecessary cast that
7215 gcc -Wbad-function-cast diagnoses.
7216 (gif_load): Fix pointer signedness.
7217 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7218 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7219
7220 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7221
7222 Improve quality of tests for time stamp overflow.
7223 For example, without this patch (encode-time 0 0 0 1 1
7224 1152921504606846976) returns the obviously-bogus value (-948597
7225 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7226 reports time overflow. See
7227 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7228 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7229 * editfns.c: Include limits.h and intprops.h.
7230 (TIME_T_MIN, TIME_T_MAX): New macros.
7231 (time_overflow): Move earlier, to before first use.
7232 (hi_time, lo_time): New functions, for an accurate test for
7233 out-of-range times.
7234 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7235 (Fget_internal_run_time): Don't assume time_t fits in int.
7236 (make_time): Use list2 instead of Fcons twice.
7237 (Fdecode_time): More accurate test for out-of-range times.
7238 (check_tm_member): New function.
7239 (Fencode_time): Use it, to test for out-of-range times.
7240 (lisp_time_argument): Don't rely on undefined left-shift and
7241 right-shift behavior when checking for time stamp overflow.
7242
7243 * editfns.c (time_overflow): New function, refactoring common code.
7244 (Fformat_time_string, Fdecode_time, Fencode_time):
7245 (Fcurrent_time_string): Use it.
7246
7247 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7248 * dired.c (make_time): Move to ...
7249 * editfns.c (make_time): ... here.
7250 * systime.h: Note the move.
7251
7252 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7253
7254 * fringe.c (update_window_fringes): Remove unused variables.
7255
7256 * unexmacosx.c (copy_data_segment): Also copy __got section.
7257 (Bug#8223)
7258
7259 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7260
7261 * termcap.c [MSDOS]: Include "msdos.h".
7262 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7263 Constify `char *' arguments and their references according to
7264 prototypes in tparam.h.
7265
7266 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7267
7268 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7269 Adapt all references accordingly.
7270
7271 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7272
7273 2011-03-11 Tom Tromey <tromey@redhat.com>
7274
7275 * buffer.c (syms_of_buffer): Remove obsolete comment.
7276
7277 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7278
7279 * termhooks.h (encode_terminal_code): Declare prototype.
7280
7281 * msdos.c (encode_terminal_code): Don't declare prototype.
7282
7283 * term.c (encode_terminal_code): Now external again, used by
7284 w32console.c and msdos.c.
7285
7286 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7287 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7288
7289 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7290
7291 Fix some minor problems found by GCC 4.5.2's static checks.
7292
7293 * fringe.c (update_window_fringes): Mark locals as initialized
7294 (Bug#8227).
7295 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7296
7297 * alloc.c (mark_fringe_data): Move decl from here ...
7298 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7299 to check its interface.
7300 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7301
7302 * fontset.c (free_realized_fontset): Now static.
7303 (Fset_fontset_font): Rename local to avoid shadowing.
7304 (fontset_font): Mark local as initialized.
7305 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7306
7307 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7308
7309 * xselect.c (x_disown_buffer_selections): Remove; not used.
7310 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7311 (x_own_selection, Fx_disown_selection_internal): Rename locals
7312 to avoid shadowing.
7313 (x_handle_dnd_message): Remove local to avoid shadowing.
7314
7315 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7316 so that the caller can use some name other than gcpro1.
7317 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7318 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7319 (Fx_backspace_delete_keys_p):
7320 Use them to avoid shadowing, and rename vars to avoid shadowing.
7321 (x_decode_color, x_set_name, x_window): Now static.
7322 (Fx_create_frame): Add braces to silence GCC warning.
7323 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7324 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7325 Remove unused locals.
7326 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7327 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7328 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7329 macros.
7330
7331 * xterm.h (x_mouse_leave): New decl.
7332
7333 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7334 Remove unused functions.
7335 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7336 (x_calc_absolute_position): Now static.
7337 (XTread_socket): Don't define label "out" unless it's used.
7338 Don't declare local "event" unless it's used.
7339 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7340 unless they are used.
7341 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7342 (x_fatal_error_signal): Remove; not used.
7343 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7344 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7345 (x_error_catcher, x_connection_closed, x_error_handler):
7346 (x_error_quitter, xembed_send_message, x_iconify_frame):
7347 (my_log_handler): Rename locals to avoid shadowing.
7348 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7349 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7350
7351 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7352 Rename or move locals to avoid shadowing.
7353 (tty_defined_color, merge_face_heights): Now static.
7354 (free_realized_faces_for_fontset): Remove; not used.
7355 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7356 does not deduce is never used uninitialized.
7357 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7358 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7359
7360 * terminal.c (store_terminal_param): Now static.
7361
7362 * xmenu.c (menu_highlight_callback): Now static.
7363 (set_frame_menubar): Remove unused local.
7364 (xmenu_show): Rename parameter to avoid shadowing.
7365 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7366 since they might point to immutable storage.
7367 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7368 since it's unused otherwise.
7369
7370 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7371 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7372 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7373 avoids a gcc -Wuninitialized diagnostic.
7374 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7375 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7376 does not deduce are never used uninitialized.
7377
7378 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7379
7380 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7381 * window.c (window_loop, size_window):
7382 (run_window_configuration_change_hook, enlarge_window): Likewise.
7383
7384 * window.c (display_buffer): Now static.
7385 (size_window): Mark variables that gcc -Wuninitialized
7386 does not deduce are never used uninitialized.
7387 * window.h (check_all_windows): New decl, to forestall
7388 gcc -Wmissing-prototypes diagnostic.
7389 * dispextern.h (bidi_dump_cached_states): Likewise.
7390
7391 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7392 shadowing.
7393 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7394 Include <limits.h>.
7395 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7396 and to avoid gcc -Wuninitialized warning.
7397 (load_charset_map): Mark variables that gcc -Wuninitialized
7398 does not deduce are never used uninitialized.
7399 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7400
7401 * coding.c (coding_set_source, coding_set_destination):
7402 Use "else { /* comment */ }" rather than "else /* comment */;"
7403 for clarity, and to avoid gcc -Wempty-body warning.
7404 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7405 a block, when the outer 'i' will do.
7406 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7407 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7408 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7409 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7410 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7411 Rename locals to avoid shadowing.
7412 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7413 * coding.c (emacs_mule_char, encode_invocation_designation):
7414 Now static, since they're not used elsewhere.
7415 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7416 (decode_coding_object, encode_coding_object, detect_coding_system):
7417 (decode_coding_emacs_mule): Mark variables that gcc
7418 -Wuninitialized does not deduce are never used uninitialized.
7419 (detect_coding_iso_2022): Initialize a local variable that might
7420 be used uninitialized. Leave a FIXME because it's not clear that
7421 this initialization is needed. (Bug#8211)
7422 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7423 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7424 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7425 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7426 Remove unused macros.
7427
7428 * category.c (hash_get_category_set): Remove unused local var.
7429 (copy_category_table): Now static, since it's not used elsewhere.
7430 * character.c (string_count_byte8): Likewise.
7431
7432 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7433 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7434
7435 * chartab.c (copy_sub_char_table): Now static, since it's not used
7436 elsewhere.
7437 (sub_char_table_ref_and_range, char_table_ref_and_range):
7438 Rename locals to avoid shadowing.
7439 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7440
7441 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7442 (BIDI_BOB): Remove unused macro.
7443
7444 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7445 deduce are never used uninitialized.
7446 * term.c (encode_terminal_code): Likewise.
7447
7448 * term.c (encode_terminal_code): Now static. Remove unused local.
7449
7450 * tparam.h: New file.
7451 * term.c, tparam.h: Include it.
7452 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7453 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7454 Move these decls to tparam.h, and make them agree with what
7455 is actually in tparam.c. The previous trick of using incompatible
7456 decls in different modules does not conform to the C standard.
7457 All callers of tparam changed to use tparam's actual API.
7458 * tparam.c (tparam1, tparam, tgoto):
7459 Use const pointers where appropriate.
7460
7461 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7462 * cm.h (struct cm): Likewise.
7463 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7464 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7465 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7466 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7467 (turn_on_face, init_tty): Likewise.
7468 * termchar.h (struct tty_display_info): Likewise.
7469
7470 * term.c (term_mouse_position): Rename local to avoid shadowing.
7471
7472 * alloc.c (mark_ttys): Move decl from here ...
7473 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7474
7475 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7476
7477 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7478
7479 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7480
7481 * search.c (compile_pattern_1): Remove argument regp, unused since
7482 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7483 (compile_pattern): Don't pass it.
7484
7485 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7486
7487 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7488 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7489 for ! HAVE_GTK3.
7490 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7491
7492 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7493
7494 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7495 gdk_window_get_screen, gdk_window_get_geometry,
7496 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7497 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7498 (xg_get_pixbuf_from_pixmap): New function.
7499 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7500 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7501 Call xg_get_pixbuf_from_pixmap instead of
7502 gdk_pixbuf_get_from_drawable.
7503 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7504 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7505 (xg_check_special_colors): Use GtkStyleContext and its functions
7506 for HAVE_GTK3.
7507 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7508 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7509 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7510 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7511 Call gtk_widget_get_preferred_size.
7512 (xg_frame_resized): gdk_window_get_geometry only takes 5
7513 parameters.
7514 (xg_win_to_widget, xg_event_is_for_menubar):
7515 Call gdk_x11_window_lookup_for_display.
7516 (xg_set_widget_bg): New function.
7517 (delete_cb): New function.
7518 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7519 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7520 (xg_set_background_color): Call xg_set_widget_bg.
7521 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7522 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7523 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7524 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7525 if ! HAVE_GTK3.
7526 (update_frame_tool_bar): Call gtk_widget_hide.
7527 (xg_initialize): Use GDK_KEY_g.
7528
7529 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7530 if ! HAVE_GTK3
7531 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7532
7533 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7534 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7535 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7536
7537 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7538
7539 * w32xfns.c (select_palette): Check success of RealizePalette against
7540 GDI_ERROR, not zero.
7541
7542 See ChangeLog.11 for earlier changes.
7543
7544 ;; Local Variables:
7545 ;; coding: utf-8
7546 ;; End:
7547
7548 Copyright (C) 2011 Free Software Foundation, Inc.
7549
7550 This file is part of GNU Emacs.
7551
7552 GNU Emacs is free software: you can redistribute it and/or modify
7553 it under the terms of the GNU General Public License as published by
7554 the Free Software Foundation, either version 3 of the License, or
7555 (at your option) any later version.
7556
7557 GNU Emacs is distributed in the hope that it will be useful,
7558 but WITHOUT ANY WARRANTY; without even the implied warranty of
7559 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7560 GNU General Public License for more details.
7561
7562 You should have received a copy of the GNU General Public License
7563 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.