Fix a compilation error with MinGW GCC 3.x in tiff_handler.
[bpt/emacs.git] / src / ChangeLog
1 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2
3 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4 GCC PR/17406) by declaring this function with external scope.
5
6 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7
8 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
9 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
10
11 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
12
13 * editfns.c (Fformat): Correctly handle text properties on "%%".
14
15 2011-09-15 Eli Zaretskii <eliz@gnu.org>
16
17 * xterm.c (x_draw_composite_glyph_string_foreground):
18 * w32term.c (x_draw_composite_glyph_string_foreground):
19 * term.c (encode_terminal_code):
20 * composite.c (composition_update_it, get_composition_id):
21 * xdisp.c (get_next_display_element)
22 (fill_composite_glyph_string): Add comments about special meaning
23 of TAB characters in a composition.
24
25 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
26
27 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
28 This occurs when processing a multibyte format.
29 Problem reported by Wolfgang Jenker.
30
31 2011-09-15 Johan Bockgård <bojohan@gnu.org>
32
33 * xdisp.c (try_cursor_movement): Only check for exact match if
34 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
35
36 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
37
38 Remove unused external symbols.
39 * dispextern.h (calc_pixel_width_or_height): Remove decl.
40 * xdisp.c (calc_pixel_width_or_height): Now static.
41 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
42 * indent.c (check_display_width):
43 * w32term.c: Fix comment to match code.
44 * xterm.c, xterm.h (x_catching_errors): Remove.
45
46 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
47
48 * xselect.c: Use signed conversions more consistently (Bug#9498).
49 (selection_data_to_lisp_data): Assume incoming selection data are
50 signed integers, not unsigned. This is to be consistent with
51 outgoing selection data, which was modified to use signed integers
52 in as part of the fix to Bug#9196 in response to Jan D.'s comment
53 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
54 expects long, not unsigned long.
55
56 2011-09-14 Eli Zaretskii <eliz@gnu.org>
57
58 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
59 computation of loop end. Reported by Johan Bockgård
60 <bojohan@gnu.org>.
61
62 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
63
64 * frame.c (Fother_visible_frames_p): Function deleted.
65
66 2011-09-12 Eli Zaretskii <eliz@gnu.org>
67
68 * indent.c (compute_motion): Process display vector front to back
69 rather than the other way around. (Bug#2496)
70
71 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
72
73 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
74
75 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
76
77 * minibuf.c (Fread_from_minibuffer): Doc fix.
78
79 2011-09-11 Eli Zaretskii <eliz@gnu.org>
80
81 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
82 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
83
84 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
85
86 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
87 value for non-existent files.
88
89 2011-09-11 Eli Zaretskii <eliz@gnu.org>
90
91 * fileio.c (Finsert_file_contents): If the file cannot be opened,
92 set its "size" to -1. This will set the modtime_size field of
93 the corresponding buffer to -1, which is what
94 verify-visited-file-modtime expects for files that do not exist.
95 (Bug#9139)
96
97 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
98
99 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
100 here ...
101 * lisp.h: ... from here. push_key_description is no longer
102 defined in keyboard.c, so its declaration should not be in
103 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
104 logically belongs with push_key_description.
105
106 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
107
108 * buffer.h: Include <sys/types.h> instead of <time.h>.
109 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
110 Problem reported by Herbert J. Skuhra.
111
112 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
113
114 * xml.c (parse_region): Make the parsing work for
115 non-comment-starting XML files again (bug#9144).
116
117 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
118
119 * image.c (gif_load): Fix calculation of bottom and right corner.
120 (Bug#9468)
121
122 2011-09-10 Eli Zaretskii <eliz@gnu.org>
123
124 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
125 redisplay in small windows.
126
127 2011-09-09 Eli Zaretskii <eliz@gnu.org>
128
129 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
130
131 2011-09-08 Martin Rudalics <rudalics@gmx.at>
132
133 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
134 Operate on live windows only.
135
136 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
137
138 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
139
140 2011-09-07 Eli Zaretskii <eliz@gnu.org>
141
142 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
143 only under bidi iteration.
144
145 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
146
147 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
148
149 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
150
151 isnan: Fix porting problem to Solaris 10 with bundled gcc.
152 Without this fix, the command to link temacs failed due to an
153 undefined symbol __builtin_isnan. This is because
154 /usr/include/iso/math_c99.h #defines isnan(x) to
155 __builtin_isnan(x), but the bundled gcc, which identifies itself
156 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
157 a __builtin_isnan.
158 * floatfns.c (isnan): #undef, and then #define to a clone of
159 what's in data.c.
160 (Fisnan): Always define, since it's always available now.
161 (syms_of_floatfns): Always define isnan at the Lisp level.
162
163 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
164
165 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
166
167 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
168
169 * fileio.c: Fix bugs with large file offsets (Bug#9428).
170 The previous code assumed that file offsets (off_t values) fit in
171 EMACS_INT variables, which is not true on typical 32-bit hosts.
172 The code messed up by falsely reporting buffer overflow in cases
173 such as (insert-file-contents "big" nil 1 2) into an empty buffer
174 when "big" contains more than 2**29 bytes, even though this
175 inserts just one byte and does not overflow the buffer.
176 (Finsert_file_contents): Store file offsets as off_t
177 values, not as EMACS_INT values. Check for overflow when
178 converting between EMACS_INT and off_t. When checking for
179 buffer overflow or for overlap, take the offsets into account.
180 Don't use EMACS_INT for small values where int suffices.
181 When checking for overlap, fix a typo: ZV was used where
182 ZV_BYTE was intended.
183 (Fwrite_region): Don't assume off_t fits into 'long'.
184 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
185
186 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
187
188 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
189
190 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
191
192 sprintf-related integer and memory overflow issues (Bug#9412).
193
194 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
195 (esprintf, exprintf, evxprintf): New functions.
196 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
197 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
198 (modify_event_symbol): Do not assume that the length of
199 name_alist_or_stem is safe to alloca and fits in int.
200 (Fexecute_extended_command): Likewise for function name and binding.
201 (Frecursion_depth): Wrap around reliably on integer overflow.
202 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
203 since some callers pass EMACS_INT values.
204 (Fsingle_key_description): Don't crash if symbol name contains more
205 than MAX_ALLOCA bytes.
206 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
207 (get_minibuffer): Arg is now EMACS_INT, not int.
208 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
209 (esprintf, exprintf, evxprintf): New decls.
210 * window.h (command_loop_level, minibuf_level): Reflect API changes.
211
212 * dbusbind.c (signature_cat): New function.
213 (xd_signature, Fdbus_register_signal):
214 Do not overrun buffer; instead, report string overflow.
215
216 * dispnew.c (add_window_display_history): Don't overrun buffer.
217 Truncate instead; this is OK since it's just a log.
218
219 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
220 even if the time zone offset is outlandishly large.
221 Don't mishandle offset == INT_MIN.
222
223 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
224 when creating daemon; the previous buffer-overflow check was incorrect.
225
226 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
227 which has the guts of the old verror function.
228
229 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
230 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
231
232 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
233 (font_unparse_xlfd): Don't blindly alloca long strings.
234 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
235 fits in int, when using sprintf. Use single snprintf to count
236 length of string rather than counting it via multiple sprintfs;
237 that's simpler and more reliable.
238 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
239 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
240 sprintf, in case result does not fit in int.
241
242 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
243 (fontset_from_font): Print it.
244
245 * frame.c (tty_frame_count): Now printmax_t, not int.
246 (make_terminal_frame, set_term_frame_name): Print it.
247 (x_report_frame_params): In X, window IDs are unsigned long,
248 not signed long, so print them as unsigned.
249 (validate_x_resource_name): Check for implausibly long names,
250 and don't assume name length fits in 'int'.
251 (x_get_resource_string): Don't blindly alloca invocation name;
252 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
253 not fit in int.
254
255 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
256 (xg_check_special_colors, xg_set_geometry):
257 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
258
259 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
260 Use esprintf, not sprintf, in case result does not fit in int.
261
262 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
263 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
264 it as a large positive number.
265 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
266 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
267
268 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
269 in case result does not fit in int.
270
271 * print.c (float_to_string): Detect width overflow more reliably.
272 (print_object): Make sprintf buffer a bit bigger, to avoid potential
273 buffer overrun. Don't assume list length fits in 'int'. Treat
274 print length of 0 as 0, not as infinity; to be consistent with other
275 uses of print length in this function. Don't overflow print length
276 index. Don't assume hash table size fits in 'long', or that
277 vectorlike size fits in 'unsigned long'.
278
279 * process.c (make_process): Use printmax_t, not int, to format
280 process-name gensyms.
281
282 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
283
284 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
285 to avoid potential buffer overrun.
286
287 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
288 if X resource line is longer than 512 bytes.
289
290 * xfns.c (x_window): Make sprintf buffer a bit bigger
291 to avoid potential buffer overrun.
292
293 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
294
295 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
296
297 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
298
299 Integer overflow fixes for scrolling, etc.
300 Without these, Emacs silently mishandles large integers sometimes.
301 For example, "C-u 4294967297 M-x recenter" was treated as if
302 it were "C-u 1 M-x recenter" on a typical 64-bit host.
303
304 * xdisp.c (try_window_id): Check Emacs fixnum range before
305 converting to 'int'.
306
307 * window.c (window_scroll_line_based, Frecenter):
308 Check that an Emacs fixnum is in range before assigning it to 'int'.
309 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
310 values converted from Emacs fixnums.
311 (Frecenter): Don't wrap around a line count if it is out of 'int'
312 range; instead, treat it as an extreme value.
313 (Fset_window_configuration, compare_window_configurations):
314 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
315
316 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
317 that can exceed INT_MAX. Check that EMACS_INT value is in range
318 before assigning it to the (possibly-narrower) index.
319 (match_limit): Don't assume that a fixnum can fit in 'int'.
320
321 * print.c (print_object): Use ptrdiff_t, not int, for index that can
322 exceed INT_MAX.
323
324 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
325 (Fvertical_motion): Don't wrap around LINES values that don't fit
326 in 'int'. Instead, treat them as extreme values. This is good
327 enough for windows, which can't have more than INT_MAX lines anyway.
328
329 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
330
331 * Require libxml/parser.h to avoid compilation warning.
332
333 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
334
335 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
336 since this reportedly can destroy thread storage.
337
338 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
339
340 * syntax.c (find_defun_start): Update all cache variables if
341 exiting early (Bug#9401).
342
343 2011-08-30 Eli Zaretskii <eliz@gnu.org>
344
345 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
346
347 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
348 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
349 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
350
351 * term.c (tty_append_glyph): New function.
352 (produce_stretch_glyph): Static function and its prototype deleted.
353
354 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
355 prototypes.
356
357 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
358
359 * image.c (parse_image_spec): Check for nonnegative, not for positive,
360 when checking :margin (Bug#9390).
361 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
362 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
363 so that the name doesn't mislead. All uses changed.
364
365 2011-08-28 Johan Bockgård <bojohan@gnu.org>
366
367 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
368 set_tty_hooks.
369
370 2011-08-27 Eli Zaretskii <eliz@gnu.org>
371
372 * xdisp.c (move_it_to): Don't bail out early when reaching
373 position beyond to_charpos, if we are scanning backwards.
374 (move_it_vertically_backward): When DY == 0, make sure we get to
375 the first character in the line after the newline.
376
377 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
378
379 * ccl.c: Improve and simplify overflow checking (Bug#9196).
380 (ccl_driver): Do not generate an out-of-range pointer.
381 (Fccl_execute_on_string): Remove unnecessary check for
382 integer overflow, noted by Stefan Monnier in
383 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
384 Remove a FIXME that didn't need fixing.
385 Simplify the newly-introduced buffer reallocation code.
386
387 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
388
389 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
390
391 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
392
393 Integer and memory overflow issues (Bug#9196).
394
395 * doc.c (get_doc_string): Rework so that
396 get_doc_string_buffer_size is the actual buffer size, rather than
397 being 1 less than the actual buffer size; this makes xpalloc more
398 convenient.
399
400 * image.c (x_allocate_bitmap_record, cache_image):
401 * xselect.c (Fx_register_dnd_atom):
402 Simplify previous changes by using xpalloc.
403
404 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
405 since either will do and ptrdiff_t is convenient with xpalloc.
406
407 * charset.c (charset_table_size)
408 (struct charset_sort_data.priority): Now ptrdiff_t.
409 (charset_compare): Don't overflow if priorities differ greatly.
410 (Fsort_charsets): Don't assume list length fits in int.
411 Check for size-calculation overflow when allocating sort data.
412 (syms_of_charset): Allocate an initial charset table that is
413 just under 64 KiB, to avoid problems with glibc malloc and mmap.
414
415 * cmds.c (internal_self_insert): Check for size-calculation overflow.
416
417 * composite.h (struct composition.glyph_len): Now int, not unsigned.
418 The actual value is always <= INT_MAX, and leaving it unsigned made
419 overflow checking harder.
420
421 * dispextern.h (struct glyph_matrix.rows_allocated)
422 (struct face_cache.size): Now ptrdiff_t, for convenience in use
423 with xpalloc. The values are still always <= INT_MAX.
424
425 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
426
427 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
428 (SAFE_NALLOCA): New macro.
429
430 * region-cache.c (struct boundary.pos, find_cache_boundary)
431 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
432 (set_cache_region, invalidate_region_cache)
433 (revalidate_region_cache, know_region_cache, region_cache_forward)
434 (region_cache_backward, pp_cache):
435 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
436 so that ptrdiff_t * can be passed to xpalloc.
437 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
438 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
439 (pp_cache): Don't assume cache_len fits in int.
440 * region-cache.h: Adjust extern decls to match.
441
442 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
443 EMACS_INT, since either will do, for xpalloc.
444
445 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
446 (xnmalloc, xnrealloc, xpalloc): New functions.
447
448 * bidi.c (bidi_shelve_header_size): New constant.
449 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
450 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
451
452 * bidi.c (bidi_cache_shrink):
453 * buffer.c (overlays_at, overlays_in, record_overlay_string)
454 (overlay_strings):
455 Don't update size of array until after memory allocation succeeds,
456 because xmalloc/xrealloc may not return.
457 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
458 now that we have proper integer overflow checking.
459 (record_overlay_string, overlay_strings): Catch overflows when
460 calculating size of overlay_str_buf.
461
462 * callproc.c (Fcall_process): Check for size overflow when
463 calculating size of args2.
464 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
465 Normally we prefer signed values, but sticking with ptrdiff_t would
466 require adding more-complicated checks.
467
468 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
469 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
470 Redo buffer-overflow calculations to avoid integer overflow.
471 Add a FIXME comment where memory seems to be over-allocated.
472
473 * character.c (Fstring): Check for size-calculation overflow.
474
475 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
476 unnecessary integer overflow. Check for size overflow.
477 (encode_coding_object): Don't update size until xmalloc succeeds.
478
479 * composite.c (get_composition_id): Check for overflow in glyph
480 length calculations.
481
482 Integer and memory overflow fixes for display code.
483 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
484 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
485 (scrolling_window): Check for overflow in size calculations.
486 (line_draw_cost, realloc_glyph_pool, add_row_entry):
487 Don't assume glyph table len fits in int.
488 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
489 (row_table_size): Now ptrdiff_t, not int.
490 (scrolling_window): Avoid overflow in size calculations.
491 Don't update size until allocation succeeds.
492 * fns.c (concat): Check for overflow in size calculations.
493 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
494 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
495 (NEXT_ALMOST_PRIME_LIMIT): New constant.
496
497 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
498 (get_doc_string): Check for size calculation overflow.
499 Don't update size until allocation succeeds.
500 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
501 EMACS_INT, where ptrdiff_t will do.
502 (Fsubstitute_command_keys): Check for string overflow.
503
504 * editfns.c (set_time_zone_rule): Don't assume environment length
505 fits in int.
506 (message_length): Now ptrdiff_t, not int.
507 (Fmessage_box): Don't update size until allocation succeeds.
508 Don't assume message length fits in int.
509 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
510
511 * emacs.c (main): Do not reallocate argv, since there is a null at
512 the end that can be overwritten, and this way there's no need to
513 worry about size-calculation overflow.
514 (sort_args): Check for size-calculation overflow.
515
516 * eval.c (init_eval_once, grow_specpdl): Don't update size until
517 alloc succeeds.
518 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
519
520 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
521 (x_set_scroll_bar_width, x_figure_window_size):
522 Check for integer overflow.
523 (x_set_alpha): Do not assume XINT fits in int.
524
525 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
526 This is for the members text_lines, text_cols, total_lines, total_cols,
527 where the system imposes an 'int' limit.
528
529 * fringe.c (Fdefine_fringe_bitmap):
530 Don't update size until alloc works.
531
532 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
533 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
534
535 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
536 Check for size-calculation overflow.
537 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
538 do, as we prefer signed integers.
539 (id_to_widget.max_size, id_to_widget.used)
540 (xg_store_widget_in_map, xg_remove_widget_from_map)
541 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
542 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
543 Use and return ptrdiff_t, not int.
544 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
545 * gtkutil.h: Change prototypes to match the above.
546
547 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
548 are duplicate now that they've been promoted to lisp.h.
549 (x_allocate_bitmap_record, x_alloc_image_color)
550 (make_image_cache, cache_image, xpm_load):
551 Don't update size until alloc is done.
552 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
553 (x_detect_edges):
554 Check for size calculation overflow.
555 (ct_colors_allocated_max): New constant.
556 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
557 overflow.
558
559 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
560 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
561 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
562 Use ptrdiff_t, not int, to count maps.
563 (read_char_minibuf_menu_prompt): Check for overflow in size
564 calculations. Don't update size until allocation succeeds. Redo
565 calculations to avoid overflow.
566 * keyboard.h: Change prototypes to match the above.
567
568 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
569 to count maps.
570 (current_minor_maps): Check for size calculation overflow.
571 * keymap.h: Change prototypes to match the above.
572
573 * lread.c (read1, init_obarray): Don't update size until alloc done.
574
575 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
576 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
577
578 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
579 Now ptrdiff_t, not int.
580 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
581 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
582
583 * process.c (Fnetwork_interface_list): Check for overflow
584 in size calculation.
585
586 * region-cache.c (move_cache_gap): Check for size calculation overflow.
587
588 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
589 overflow. Don't bother calling xmalloc when xrealloc will do.
590
591 * search.c (Freplace_match): Check for size calculation overflow.
592 (Fset_match_data): Don't assume list lengths fit in 'int'.
593
594 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
595 for command line length. Do not attempt to address one before the
596 beginning of an array, as that's not portable.
597
598 * term.c (max_frame_lines): Remove; unused.
599 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
600 not int.
601 (encode_terminal_code, calculate_costs): Check for size
602 calculation overflow.
603 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
604 table lengths and related sizes. Don't update size until alloc
605 done. Redo calculations to avoid overflow.
606 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
607
608 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
609 subtracting pointers.
610 (gobble_line): Check for overflow more carefully. Don't update size
611 until alloc done.
612
613 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
614 Don't update size until alloc done.
615 Redo size calculations to avoid overflow.
616 Check for size calculation overflow.
617 (main) [DEBUG]: Fix typo in invoking tparam1.
618
619 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
620 Use ptrdiff_t, not int, for sizes.
621 (store_mode_line_noprop_char): Don't update size until alloc done.
622
623 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
624 Use ptrdiff_t, not int, for sizes.
625 (Finternal_make_lisp_face, cache_face):
626 Check for size calculation overflow.
627 (cache_face): Treat size calculation overflows as if they were
628 memory exhaustion (the usual treatment), rather than aborting.
629
630 * xfns.c (x_encode_text, x_set_name_internal)
631 (Fx_change_window_property): Use ptrdiff_t, not int, to count
632 sizes, since they can exceed INT_MAX in size. Check for size
633 calculation overflow.
634
635 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
636 (xg_select): Check for size calculation overflow.
637 Don't update size until alloc done.
638
639 * xrdb.c (get_environ_db): Don't assume path length fits in int,
640 as sprintf is limited to int lengths.
641
642 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
643 (X_LONG_MIN): New macros.
644 Use them to make the following changes clearer.
645 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
646 This change doesn't affect the value now, but it may help remind
647 future maintainers not to raise the value too much later.
648 (SELECTION_QUANTUM): Remove, replacing with ...
649 (selection_quantum): ... new function, which avoids overflow.
650 All uses changed.
651 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
652 assumption that selection length fits in 'int'.
653 (x_reply_selection_request, x_handle_selection_request)
654 (x_get_window_property, receive_incremental_selection)
655 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
656 (lisp_data_to_selection_data, clean_local_selection_data):
657 Use ptrdiff_t, not int, to record length of selection.
658 (x_reply_selection_request, x_get_window_property)
659 (receive_incremental_selection, x_property_data_to_lisp):
660 Redo calculations to avoid overflow.
661 (x_reply_selection_request): When sending hint, ceiling it at
662 X_LONG_MAX rather than relying on wraparound overflow to send
663 something.
664 (x_get_window_property, receive_incremental_selection)
665 (lisp_data_to_selection_data, x_property_data_to_lisp):
666 Check for size-calculation overflow.
667 (x_get_window_property, receive_incremental_selection)
668 (lisp_data_to_selection_data, Fx_register_dnd_atom):
669 Don't store size until memory allocation succeeds.
670 (x_get_window_property): Plug memory leak on memory exhaustion.
671 Don't double-block input; malloc is safe here. Don't assume 2**34
672 - 4 fits in unsigned long. Add an xassert to check
673 XGetWindowProperty overflow. Be more careful about overflow
674 calculations, and distinguish size from memory overflow better.
675 (receive_incremental_selection): When tracing, don't assume
676 unsigned int is less than INT_MAX.
677 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
678 harmful) conversions of unsigned short to int.
679 (lisp_data_to_selection_data): Don't assume that integers
680 in the range -65535 through -1 fit in an X unsigned short.
681 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
682 result parameters unless successful. Rely on cons_to_unsigned
683 to report problems with elements; the old code wasn't right anyway.
684 (x_check_property_data): Check for int overflow; we cannot use
685 a wider type due to X limits.
686 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
687
688 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
689
690 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
691 (x_term_init): Check for size calculation overflow.
692 (x_color_cells): Don't store size until memory allocation succeeds.
693 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
694 Don't assume alloca size is less than MAX_ALLOCA.
695 (x_term_init): Don't assume length fits in int (sprintf is limited
696 to int size).
697
698 Use ptrdiff_t for composition IDs.
699 * character.c (lisp_string_width):
700 * composite.c (composition_table_size, n_compositions)
701 (get_composition_id, composition_gstring_from_id):
702 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
703 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
704 * window.c (Frecenter):
705 Use ptrdiff_t, not int, for composition IDs.
706 * composite.c (get_composition_id): Check for integer overflow.
707 * composite.h: Adjust prototypes to match the above changes.
708
709 Use ptrdiff_t for hash table indexes.
710 * category.c (hash_get_category_set):
711 * ccl.c (ccl_driver):
712 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
713 * coding.c (coding_system_charset_list, detect_coding_system):
714 * coding.h (struct coding_system.id):
715 * composite.c (get_composition_id, gstring_lookup_cache):
716 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
717 * image.c (xpm_get_color_table_h):
718 * lisp.h (hash_lookup, hash_put):
719 * minibuf.c (Ftest_completion):
720 Use ptrdiff_t for hash table indexes, not int (which is too
721 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
722 32-bit --with-wide-int hosts).
723
724 * charset.c (Fdefine_charset_internal): Check for integer overflow.
725 Add a FIXME comment about memory leaks.
726 (syms_of_charset): Don't assume xmalloc returns.
727
728 Don't assume that stated character widths fit in int.
729 * character.c (Fchar_width, c_string_width, lisp_string_width):
730 * character.h (CHAR_WIDTH):
731 * indent.c (MULTIBYTE_BYTES_WIDTH):
732 Use sanitize_char_width to avoid undefined and/or bad behavior
733 with outlandish widths.
734 * character.h (sanitize_tab_width): Renamed from sanitize_width,
735 now that we have two such functions. All uses changed.
736 (sanitize_char_width): New inline function.
737
738 Don't assume that tab-width fits in int.
739 * character.h (sanitize_width): New inline function.
740 (SANE_TAB_WIDTH): New macro.
741 (ASCII_CHAR_WIDTH): Use it.
742 * indent.c (sane_tab_width): Remove. All uses replaced by
743 SANE_TAB_WIDTH (current_buffer).
744 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
745
746 * fileio.c: Integer overflow issues with file modes.
747 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
748
749 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
750 Remove unreachable code.
751 (read_hex, load_charset_map_from_file): Check for integer overflow.
752
753 * xterm.c: don't go over XClientMessageEvent limit
754 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
755 (x_send_scroll_bar_event): Likewise. Check that the size does not
756 exceed limits imposed by XClientMessageEvent, as well as the usual
757 ptrdiff_t and size_t limits.
758
759 * keyboard.c: Overflow, signedness and related fixes.
760 (make_lispy_movement): Use same integer type in forward decl
761 that is used in the definition.
762 (read_key_sequence, keyremap_step):
763 Change bufsize argument back to int, undoing my 2011-03-30 change.
764 We prefer signed types, and int is wide enough here.
765 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
766 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
767 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
768 length, not size_t. Use ptrdiff_t for index, not int.
769 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
770 possibility of integer overflow.
771
772 Overflow, signedness and related fixes for images.
773
774 * dispextern.h (struct it.stack[0].u.image.image_id)
775 (struct_it.image_id, struct image.id, struct image_cache.size)
776 (struct image_cache.used, struct image_cache.ref_count):
777 * gtkutil.c (update_frame_tool_bar):
778 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
779 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
780 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
781 * nsmenu.m (update_frame_tool_bar):
782 * xdisp.c (calc_pixel_width_or_height):
783 * xfns.c (image_cache_refcount):
784 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
785 on typical 64-bit hosts.
786
787 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
788 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
789 Omit unnecessary casts to int.
790 (parse_image_spec): Check that integers fall into 'int' range
791 when the callers expect that.
792 (image_ascent): Redo ascent calculation to avoid int overflow.
793 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
794 (lookup_image): Remove unnecessary tests.
795 (xbm_image_p): Locals are now of int, not EMACS_INT,
796 since parse_image_check makes sure they fit into int.
797 (png_load, gif_load, svg_load_image):
798 Prefer int to unsigned where either will do.
799 (tiff_handler): New function, combining the cores of the
800 old tiff_error_handler and tiff_warning_handler. This
801 function is rewritten to use vsnprintf and thereby avoid
802 stack buffer overflows. It uses only the features of vsnprintf
803 that are common to both POSIX and native Microsoft.
804 (tiff_error_handler, tiff_warning_handler): Use it.
805 (tiff_load, gif_load, imagemagick_load_image):
806 Don't assume :index value fits in 'int'.
807 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
808 (imagemagick_load_image): Check that crop parameters fit into
809 the integer types that MagickCropImage accepts. Don't assume
810 Vimagemagick_render_type has a nonnegative value. Don't assume
811 size_t fits in 'long'.
812 (gs_load): Use printmax_t to print the widest integers possible.
813 Check for integer overflow when computing image height and width.
814
815 2011-08-26 Eli Zaretskii <eliz@gnu.org>
816
817 * xdisp.c (redisplay_window): Don't force window start if point
818 will be invisible in the resulting window. (Bug#9324)
819
820 2011-08-25 Eli Zaretskii <eliz@gnu.org>
821
822 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
823 the display spec is of the form `(space ...)'.
824 (handle_display_spec): Return the value returned by
825 handle_single_display_spec, not just 1 or zero.
826 (handle_single_display_spec): If the display spec is of the form
827 `(space ...)', and specifies display in the text area, return 2
828 rather than 1.
829 (try_cursor_movement): Check for the need to scroll more
830 accurately, and prefer exact match for point under bidi. Don't
831 advance `row' beyond the last row of the window.
832
833 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
834 into disp_prop; all users changed.
835
836 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
837 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
838 for the text covered by the display property.
839
840 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
841
842 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
843 Change return value to nil.
844 (Frecord_buffer): Delete unused function.
845
846 2011-08-24 Eli Zaretskii <eliz@gnu.org>
847
848 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
849 buffers, return left-to-right.
850 (set_cursor_from_row): Consider candidate row a win if its glyph
851 represents a newline and point is on that newline. Fixes cursor
852 positioning on the newline at EOL of R2L text within L2R
853 paragraph, and vice versa.
854 (try_cursor_movement): Check continued rows, in addition to
855 continuation rows. Fixes unwarranted scroll when point enters a
856 continued line of R2L text within an L2R paragraph, or vice versa.
857 (cursor_row_p): Consider the case of point being equal to
858 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
859 from the end of a short line to the beginning of a continued line
860 of R2L text within L2R paragraph.
861 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
862 composed characters.
863
864 * bidi.c (bidi_check_type): Use xassert.
865 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
866 members.
867
868 2011-08-23 Eli Zaretskii <eliz@gnu.org>
869
870 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
871 a character.
872
873 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
874
875 * nsfont.m (ns_otf_to_script): Fix typo.
876
877 2011-08-22 Kenichi Handa <handa@m17n.org>
878
879 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
880 extra slot even if the purpose is char-code-property-table.
881
882 2011-08-23 Eli Zaretskii <eliz@gnu.org>
883
884 * xdisp.c (redisplay_window): When computing centering_position,
885 account for the height of the header line. (Bug#8874)
886
887 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
888 instead of CHAR_TO_BYTE. Fixes a crash when a completion
889 candidate is selected by the mouse, and that candidate has a
890 composed character under the mouse.
891
892 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
893 coordinates reported by pos-visible-in-window-p for a composed
894 character in column zero.
895
896 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
897
898 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
899
900 2011-08-22 Eli Zaretskii <eliz@gnu.org>
901
902 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
903 consider it a hit if to_charpos is anywhere in the range of the
904 composed buffer positions.
905
906 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
907
908 * image.c (gif_load): Don't assume that each subimage has the same
909 dimensions as the base image. Handle disposal method that is
910 "undefined" by the gif spec (Bug#9335).
911
912 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
913
914 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
915 (Fcondition_case): Document `debug' symbol in error handler.
916
917 2011-08-19 Eli Zaretskii <eliz@gnu.org>
918
919 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
920 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
921 from an Org mode buffer to a Speedbar frame.
922
923 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
924 a composition, take its buffer position from IT->cmp_it.charpos.
925 Fixes cursor positioning at the beginning of a line that begins
926 with a composed character.
927
928 2011-08-18 Eli Zaretskii <eliz@gnu.org>
929
930 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
931 character bidirectional type, use STRONG_L instead. Fixes crashes
932 in a buffer produced by `describe-categories'.
933
934 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
935 members before the level stack, so they would be saved and
936 restored when copying iterator state. Fixes incorrect reordering
937 around TABs covered by display properties.
938
939 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
940
941 * process.c (Fnetwork_interface_list): Correctly determine buffer
942 size.
943
944 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
945
946 * eval.c (internal_condition_case, internal_condition_case_1)
947 (internal_condition_case_2, internal_condition_case_n):
948 Remove unnecessary aborts (Bug#9081).
949
950 2011-08-17 Eli Zaretskii <eliz@gnu.org>
951
952 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
953 has no `load' handler, try opening the file locally. (Bug#9311)
954
955 2011-08-16 Ken Brown <kbrown@cornell.edu>
956
957 * gmalloc.c: Expand comment.
958
959 2011-08-16 Eli Zaretskii <eliz@gnu.org>
960
961 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
962 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
963
964 2011-08-16 Ken Brown <kbrown@cornell.edu>
965
966 Fix memory allocation problems in Cygwin build (Bug#9273).
967
968 * unexcw.c ( __malloc_initialized): Declare external variable.
969 (fixup_executable): Force the dumped emacs to reinitialize malloc.
970
971 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
972 New variables.
973 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
974 dumped emacs.
975 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
976 in the static heap.
977 [CYGWIN] (special_realloc): New function.
978 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
979 requests to realloc storage in the static heap.
980
981 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
982
983 * bidi.c (bidi_initialize): Remove unused local.
984
985 2011-08-15 Eli Zaretskii <eliz@gnu.org>
986
987 * biditype.h: File removed.
988
989 * bidimirror.h: File removed.
990
991 * deps.mk (bidi.o): Remove biditype.h and
992 bidimirror.h.
993
994 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
995 bidimirror.h.
996
997 * dispextern.h: Fix a typo in the comment to bidi_type_t.
998
999 * chartab.c: Improve commentary for the uniprop_table API.
1000
1001 * bidi.c (bidi_paragraph_init): Support zero value of
1002 bidi_ignore_explicit_marks_for_paragraph_level.
1003 (bidi_initialize): Use uniprop_table instead of including
1004 biditype.h and bidimirror.h.
1005
1006 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1007 coordinates of the iterator when restoring from ppos_it.
1008 (Bug#9296)
1009
1010 2011-08-14 Kenichi Handa <handa@m17n.org>
1011
1012 * process.c (create_process): Call setup_process_coding_systems
1013 after the pid of the process is set to -1 (Bug#8162).
1014
1015 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1016
1017 * xdisp.c (move_it_in_display_line_to): Don't invoke
1018 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1019 ppos_it. Fixes vertical cursor motion when line beginning is
1020 covered by an image. (Bug#9296)
1021
1022 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1023
1024 * nsterm.h (ns_run_ascript): Declare.
1025 (NSAPP_DATA2_RUNASSCRIPT): Define.
1026
1027 * nsfns.m (as_script, as_result, as_status): New static variables.
1028 (ns_run_ascript): New function.
1029 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1030 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1031 the event loop. Get status from as_status (Bug#7276).
1032
1033 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1034 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1035 the event loop (Bug#7276).
1036
1037 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1038
1039 * gnutls.c (QCgnutls_bootprop_priority)
1040 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1041 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1042 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1043 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1044 (QCgnutls_bootprop_verify_hostname_error)
1045 (QCgnutls_bootprop_callbacks_verify): Rename from
1046 Qgnutls_bootprop_..., all uses changed.
1047
1048 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1049 uses changed.
1050
1051 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1052
1053 * xfaces.c (Qframe_set_background_mode): Now static.
1054 * dispextern.h (Qframe_set_background_mode): Remove decl.
1055
1056 * process.c (Fnetwork_interface_info): Declare local only if needed.
1057
1058 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1059
1060 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1061 (Fnetwork_interface_list): Allocate in increments of bytes instead
1062 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1063 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1064 sockaddr.
1065 (struct ifflag_def): notrailers is smart on OSX.
1066 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1067 Get hardware address with getifaddrs if available.
1068
1069 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1070
1071 * xdisp.c (iterate_out_of_display_property): xassert that
1072 IT->position is set to within IT->object's boundaries. Break from
1073 the loop as soon as EOB is reached; avoids infloops in redisplay
1074 when IT->position is set up wrongly due to some bug.
1075 Set IT->current to match the bidi iterator unconditionally.
1076 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1077 entry. Force push_it to save on the stack the current
1078 buffer/string position, to be restored by pop_it. Fix flags in
1079 the iterator structure wrt the object coming from a display
1080 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1081 properties. (Bug#9284)
1082
1083 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1084
1085 * fontset.c (fontset_get_font_group): Add proper type checks.
1086 (Bug#9172)
1087
1088 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1089
1090 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1091 and LC_VERSION_MIN_MACOSX.
1092 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1093 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1094
1095 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1096
1097 * xdisp.c (forward_to_next_line_start): Allow to use the
1098 no-display-properties-and-no-overlays under bidi display.
1099 Set disp_pos in the bidi iterator to avoid searches for display
1100 properties and overlays.
1101
1102 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1103
1104 * editfns.c (Fset_time_zone_rule): Document relationship with the
1105 setenv function.
1106
1107 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1108 the font entity extracted from the cache (Bug#8109).
1109
1110 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1111
1112 * composite.c (autocmp_chars): Don't reset point. That is done by
1113 restore_point_unwind (Bug#5984).
1114
1115 2011-08-07 Juri Linkov <juri@jurta.org>
1116
1117 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1118 to show the arg `TIME' instead of `TIMEVAL'.
1119
1120 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1121
1122 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1123 display property strides EOL and includes a newline, as in
1124 longlines-mode. (Bug#9254)
1125 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1126 word-wrap under bidirectional display. (Bug#9224)
1127
1128 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1129 is non-zero, even if the data buffer is NULL. Fixes a crash in
1130 vertical-motion with longlines-mode. (Bug#9254)
1131
1132 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1133
1134 * bidi.c <bidi_cache_total_alloc>: Now static.
1135 (bidi_initialize): Initialize bidi_cache_total_alloc.
1136
1137 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1138 cache. (Bug#9221)
1139
1140 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1141 amount allocated this far in `bidi_cache_total_alloc'.
1142 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1143 non-zero, only free the data buffer without restoring the cache
1144 contents. All callers changed.
1145
1146 * dispextern.h (bidi_unshelve_cache): Update prototype.
1147
1148 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1149 (move_it_in_display_line, move_it_to)
1150 (move_it_vertically_backward, move_it_by_lines): Replace the call
1151 to xfree to an equivalent call to bidi_unshelve_cache.
1152 (move_it_in_display_line_to): Fix logic of returning
1153 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1154
1155 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1156
1157 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1158 came from a string character with a `cursor' property. (Bug#9229)
1159
1160 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1161
1162 * Makefile.in (LIB_PTHREAD): New variable.
1163 (LIBES): Add LIB_PTHREAD (Bug#9216).
1164
1165 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1166 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1167
1168 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1169
1170 * regex.c (re_iswctype): Remove some redundant boolean
1171 conversions.
1172
1173 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1174
1175 * xterm.c (x_find_topmost_parent): New function.
1176 (x_set_frame_alpha): Find topmost parent window with
1177 x_find_topmost_parent and set the property there also (bug#9181).
1178 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1179
1180 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 * callproc.c (Fcall_process): Avoid vfork clobbering
1183 the local vars buffer, coding_systems, current_dir.
1184
1185 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1186
1187 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1188
1189 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1192 so that it is not optimized away.
1193
1194 * xdisp.c (compute_display_string_pos): Remove unused local.
1195
1196 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1197
1198 Fix slow cursor motion and scrolling in large buffers with
1199 selective display, like Org Mode buffers. (Bug#9218)
1200
1201 * dispextern.h (struct bidi_it): New member disp_prop_p.
1202
1203 * xdisp.c: Remove one-slot cache of display string positions.
1204 (compute_display_string_pos): Accept an additional argument
1205 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1206 for a display string or property. If found, set DISP_PROP_P
1207 non-zero.
1208
1209 * bidi.c (bidi_fetch_char): Accept an additional argument
1210 DISP_PROP_P, and pass it to compute_display_string_pos.
1211 Only handle text covered by a display string if DISP_PROP_P is returned
1212 non-zero. All callers of bidi_fetch_char changed.
1213
1214 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1215
1216 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1217
1218 2010-12-03 Don March <don@ohspite.net>
1219
1220 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1221 last character M-[char] is translated to ESC [char] (bug#7541).
1222
1223 2011-08-02 Kenichi Handa <handa@m17n.org>
1224
1225 * lisp.h (uniprop_table): Extern it.
1226
1227 * chartab.c (uniprop_table): Make it non-static.
1228
1229 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1230
1231 * xdisp.c (forward_to_next_line_start): Accept additional argument
1232 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1233 on the newline.
1234 (reseat_at_next_visible_line_start): Use the bidi iterator state
1235 returned by forward_to_next_line_start to restore the state of
1236 it->bidi_it after backing up to previous newline. (Bug#9212)
1237
1238 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1239
1240 * regex.c (re_comp): Protoize.
1241 (re_exec): Fix return type.
1242 (regexec): Fix type of `ret'. (Bug#9203)
1243
1244 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1247 This is needed if max-image-size is a floating-point number.
1248
1249 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1250
1251 * print.c (print_object): Print empty symbol as ##.
1252
1253 * lread.c (read1): Read ## as empty symbol.
1254
1255 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1256
1257 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1258 setting frame foreground color (Bug#9175).
1259 (x_set_background_color): Likewise.
1260
1261 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1262 contents (Bug#9176).
1263 (EmacsTooltip -init): Remove bezels and add shadows to
1264 tooltip windows.
1265
1266 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1267 or scroll bar (Bug#8470).
1268
1269 * nsfont.m (nsfont_open): Remove assignment to voffset and
1270 unnecessary vars hshink, expand, hd, full_height, min_height.
1271 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1272
1273 * nsterm.h (nsfont_info): Remove voffset field.
1274
1275 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1276
1277 Implement strike-through and overline on NextStep (Bug#8863).
1278
1279 * nsfont.m (nsfont_open): Use underline position provided by font,
1280 instead of hard-coded value of 2.
1281 (nsfont_draw): Call ns_draw_text_decoration instead.
1282
1283 * nsterm.h: Add declaration for ns_draw_text_decoration.
1284
1285 * nsterm.m (ns_draw_text_decoration): New function for drawing
1286 underline, overline, and strike-through.
1287 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1288 ns_draw_text_decoration. Change treatment of cursor drawing to
1289 accomodate underlining, etc.
1290
1291 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1292
1293 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1294 default.
1295
1296 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1299 Without this fix, if a signal arrives just after memory fills up,
1300 'malloc' might be invoked reentrantly.
1301
1302 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1303 In other words, assume that every image size is allowed, on non-X
1304 hosts. This assumption is probably wrong, but it lets Emacs compile.
1305
1306 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1307
1308 * regex.c (re_iswctype): Convert return values to boolean.
1309
1310 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1311
1312 * xdisp.c (compute_display_string_pos): Don't use cached display
1313 string position if the buffer had its restriction changed.
1314 (Bug#9184)
1315
1316 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1319
1320 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1321
1322 Integer signedness and overflow and related fixes. (Bug#9079)
1323
1324 * bidi.c: Integer size and overflow fixes.
1325 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1326 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1327 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1328 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1329 (bidi_find_other_level_edge):
1330 Use ptrdiff_t instead of EMACS_INT where either will do.
1331 This works better on 32-bit hosts configured --with-wide-int.
1332 (bidi_cache_ensure_space): Check for size-calculation overflow.
1333 Use % rather than repeated addition, for better worst-case speed.
1334 Don't set bidi_cache_size until after xrealloc returns, because it
1335 might not return.
1336 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1337 (bidi_cache_ensure_space): Also check that the bidi cache size
1338 does not exceed that of the largest Lisp string or buffer. See Eli
1339 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1340
1341 * alloc.c (__malloc_size_t): Remove.
1342 All uses replaced by size_t. See Andreas Schwab's note
1343 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1344
1345 * image.c: Improve checking for integer overflow.
1346 (check_image_size): Assume that f is nonnull, since
1347 it is always nonnull in practice. This is one less thing to
1348 worry about when checking for integer overflow later.
1349 (x_check_image_size): New function, which checks for integer
1350 overflow issues inside X.
1351 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1352 This removes the need for a memory_full check.
1353 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1354 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1355 (xbm_read_bitmap_data): Change locals back to 'int', since
1356 their values must fit in 'int'.
1357 (xpm_load_image, png_load, tiff_load):
1358 Invoke x_create_x_image_and_pixmap earlier,
1359 to avoid much needless work if the image is too large.
1360 (tiff_load): Treat overly large images as if
1361 x_create_x_image_and_pixmap failed, not as malloc failures.
1362 (gs_load): Use x_check_image_size.
1363
1364 * gtkutil.c: Omit integer casts.
1365 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1366 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1367
1368 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1369
1370 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1371 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1372 would wrongly return t on a 64-bit host.
1373
1374 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1375 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1376 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1377 and therefore cause GCC to emit a bogus diagnostic in some cases.
1378
1379 * image.c: Integer signedness and overflow and related fixes.
1380 This is not an exhaustive set of fixes, but it's time to
1381 record what I've got.
1382 (lookup_pixel_color, check_image_size): Remove redundant decls.
1383 (check_image_size): Don't assume that arbitrary EMACS_INT values
1384 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1385 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1386 (tiff_load, imagemagick_load_image):
1387 Check for overflow in size calculations.
1388 (x_create_x_image_and_pixmap): Remove unnecessary test for
1389 xmalloc returning NULL; that can't happen.
1390 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1391 (xpm_color_bucket): Use better integer hashing function.
1392 (xpm_cache_color): Don't possibly over-allocate memory.
1393 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1394 (gif_memory_source):
1395 Use ptrdiff_t, not int or size_t, to record sizes.
1396 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1397 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1398 either works, as we prefer signed integers.
1399 (tiff_read_from_memory, tiff_write_from_memory):
1400 Return tsize_t, not size_t, since that's what the TIFF API wants.
1401 (tiff_read_from_memory): Don't fail simply because the read would
1402 go past EOF; instead, return a short read.
1403 (tiff_load): Omit no-longer-needed casts.
1404 (Fimagemagick_types): Don't assume size fits into 'int'.
1405
1406 Improve hashing quality when configured --with-wide-int.
1407 * fns.c (hash_string): New function, taken from sxhash_string.
1408 Do not discard information about ASCII character case; this
1409 discarding is no longer needed.
1410 (sxhash-string): Use it. Change sig to match it. Caller changed.
1411 * lisp.h: Declare it.
1412 * lread.c (hash_string): Remove, since we now use fns.c's version.
1413 The fns.c version returns a wider integer if --with-wide-int is
1414 specified, so this should help the quality of the hashing a bit.
1415
1416 * emacs.c: Integer overflow minor fix.
1417 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1418 Define only if GNU_LINUX.
1419 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1420
1421 * dispnew.c: Integer signedness and overflow fixes.
1422 Remove unnecessary forward decls, that were a maintenance hassle.
1423 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1424 All uses changed.
1425 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1426 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1427 (prepare_desired_row, line_draw_cost):
1428 Use int, not unsigned, where either works.
1429 (save_current_matrix, restore_current_matrix):
1430 Use ptrdiff_t, not size_t, where either works.
1431 (init_display): Check for overflow more accurately, and without
1432 relying on undefined behavior.
1433
1434 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1435 Remove, replacing with the new symbols in lisp.h. All uses changed.
1436 * fileio.c (make_temp_name):
1437 * filelock.c (lock_file_1, lock_file):
1438 * xdisp.c (message_dolog):
1439 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1440 Use pMd etc. instead.
1441 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1442 replacing the pWIDE etc. symbols removed from editfns.c.
1443
1444 * keyboard.h (num_input_events): Now uintmax_t.
1445 This is (very slightly) less likely to mess up due to wraparound.
1446 All uses changed.
1447
1448 * buffer.c: Integer signedness fixes.
1449 (alloc_buffer_text, enlarge_buffer_text):
1450 Use ptrdiff_t rather than size_t when either will do, as we prefer
1451 signed integers.
1452
1453 * alloc.c: Integer signedness and overflow fixes.
1454 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1455 (__malloc_size_t): Default to size_t, not to int.
1456 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1457 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1458 Prefer ptrdiff_t to size_t when either would do, as we prefer
1459 signed integers.
1460 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1461 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1462 Now const. Initialize with values that are in range even if char
1463 is signed.
1464 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1465 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1466 These functions do the right thing with sizes > 2**32.
1467 (check_depth): Now ptrdiff_t, not int.
1468 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1469 Adjust to new way of storing sizes. Check for size overflow bugs
1470 in rest of code.
1471 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1472 slightly wrong anyway, as it missed one instance of
1473 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1474 (refill_memory_reserve): Omit needless cast to size_t.
1475 (mark_object_loop_halt): Mark as externally visible.
1476
1477 * xselect.c: Integer signedness and overflow fixes.
1478 (Fx_register_dnd_atom, x_handle_dnd_message):
1479 Use ptrdiff_t, not size_t, since we prefer signed.
1480 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1481 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1482 x_dnd_atoms_size and x_dnd_atoms_length.
1483
1484 * doprnt.c: Prefer signed to unsigned when either works.
1485 * eval.c (verror):
1486 * doprnt.c (doprnt):
1487 * lisp.h (doprnt):
1488 * xdisp.c (vmessage):
1489 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1490 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1491 prefer signed arithmetic to avoid comparison confusion.
1492 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1493 but is a bit tricky.
1494
1495 Assume freestanding C89 headers, string.h, stdlib.h.
1496 * data.c, doprnt.c, floatfns.c, print.c:
1497 Include float.h unconditionally.
1498 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1499 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1500 * regex.c: Likewise for stddef.h, string.h.
1501 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1502 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1503 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1504 (STDC_HEADERS): Remove obsolete defines.
1505 * sysdep.c: Include limits.h unconditionally.
1506
1507 Assume support for memcmp, memcpy, memmove, memset.
1508 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1509 * regex.c (memcmp, memcpy):
1510 Remove; we assume C89 now.
1511
1512 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1513 (__malloc_safe_bcopy): Remove; no longer needed.
1514
1515 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1516 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1517 well either way, and we prefer signed to unsigned.
1518
1519 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1520
1521 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1522 closes the connection while we're reading (bug#9182).
1523
1524 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1525
1526 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1527 are specified (Bug#9168).
1528
1529 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1530
1531 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1532 Found by GCC static checking and --with-wide-int on a 32-bit host.
1533
1534 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1535
1536 * xdisp.c (compute_display_string_pos): Fix logic of caching
1537 previous display string position. Initialize cached_prev_pos to
1538 -1. Fixes slow-down at the beginning of a buffer.
1539
1540 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1541
1542 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1543 for attrs[LFACE_FONTSET_INDEX].
1544
1545 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1546
1547 * xml.c (parse_region): Remove unused local
1548 that was recently introduced.
1549
1550 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1551
1552 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1553 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1554
1555 * xdisp.c (move_it_in_display_line_to): Record the best matching
1556 position for TO_CHARPOS while scanning the line, and restore it on
1557 exit if none of the characters scanned was an exact match.
1558 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1559 when exact match is impossible due to invisible text, and the
1560 lines are truncated.
1561
1562 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1563
1564 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1565 for OSX >= 10.7.
1566
1567 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1568
1569 Fix a significant slow-down of cursor motion with C-n, C-p,
1570 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1571 auto-repeat under bidi redisplay in fontified buffers.
1572 * xdisp.c (compute_stop_pos_backwards): New function.
1573 (next_element_from_buffer): Call compute_stop_pos_backwards to
1574 find a suitable prev_stop when we find ourselves before
1575 base_level_stop.
1576 (reseat): Don't look for prev_stop, as that could mean a very long
1577 run.
1578 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1579 <cached_disp_overlay_modiff>: Cache for last found display string
1580 position.
1581 (compute_display_string_pos): Return the cached position if asked
1582 about the same buffer in the same area of character positions, and
1583 the buffer wasn't changed since the time the display string
1584 position was cached.
1585
1586 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1587
1588 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1589 is an integer, which is important for empty lines. (Bug#9149)
1590
1591 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1592
1593 * frame.c (Fmodify_frame_parameters): In tty case, update the
1594 default face if necessary (Bug#4238).
1595
1596 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1597
1598 * editfns.c (Fstring_to_char): No need to explain what a character
1599 is in the docstring (Bug#6576).
1600
1601 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1602
1603 * xml.c (parse_region): Make sure we always return a tree.
1604
1605 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1606
1607 * xml.c (parse_region): If a document contains only comments,
1608 return that, too.
1609
1610 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1611
1612 * xml.c (make_dom): Return comments, too.
1613
1614 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1615
1616 Port to OpenBSD.
1617 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1618 and the surrounding thread.
1619 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1620 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1621 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1622 timer goes off.
1623 * s/openbsd.h (BROKEN_SIGIO): Define.
1624 * unexelf.c (unexec) [__OpenBSD__]:
1625 Don't update the .mdebug section of the Alpha COFF symbol table.
1626
1627 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1628
1629 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1630 (bug#8460).
1631
1632 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1633
1634 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1635 This fixes some race conditions on the permissions of any newly
1636 created file.
1637
1638 * alloc.c (valid_pointer_p): Use pipe, not open.
1639 This fixes some permissions issues when debugging.
1640
1641 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1642 If fchown fails to set both uid and gid, try to set just gid,
1643 as that is sometimes allowed. Adjust the file's mode to eliminate
1644 setuid or setgid bits that are inappropriate if fchown fails.
1645
1646 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1647
1648 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1649 to compare Lisp_Objects.
1650 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1651 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1652 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1653
1654 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1655
1656 * lread.c (read_integer): Unread even EOF character.
1657 (read1): Likewise. Properly record start position of symbol.
1658
1659 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1660 symbol character follows.
1661
1662 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1663
1664 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1665 This works around a problem with the previous change to Fcopy_file.
1666 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1667 and without this change, GCC might complain about discarding
1668 fchown's return value.
1669
1670 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1671
1672 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1673
1674 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1675
1676 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1677
1678 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1679
1680 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1681 it's used from the C level.
1682
1683 * process.c: Use the same condition for POLL_FOR_INPUT in both
1684 keyboard.c and process.c (bug#1858).
1685
1686 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1687
1688 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1689 (Fgnutls_boot): Use it.
1690
1691 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1692
1693 * doc.c (Fsubstitute_command_keys): Revert last change.
1694
1695 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1696
1697 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1698 quotes the next character, and doesn't affect other longer
1699 sequences (bug#8935).
1700
1701 * lread.c (syms_of_lread): Clarify that is isn't only
1702 `eval-buffer' and `eval-defun' that's affected by
1703 `lexical-binding' (bug#8460).
1704
1705 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1706
1707 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1708 bidi redisplay when a line includes both an image and is
1709 truncated.
1710
1711 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1712
1713 Fix minor problems found by static checking.
1714 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1715 (elsz): Now a signed constant, not a size_t var. We prefer signed
1716 types to unsigned, to avoid integer comparison confusion. Without
1717 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1718 "cannot optimize loop, the loop counter may overflow", a symptom
1719 of the confusion.
1720 * indent.c (Fvertical_motion): Mark locals as initialized.
1721 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1722
1723 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1724
1725 * search.c (Fre_search_backward): Mention `case-fold-search' in
1726 all the re_search_* functions (bug#8138).
1727
1728 * keyboard.c (Fopen_dribble_file): Document when the file is
1729 closed (bug#8056).
1730
1731 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1732
1733 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1734 bidi_cache_idx.
1735
1736 Support bidi reordering of display and overlay strings.
1737 * xdisp.c (compute_display_string_pos)
1738 (compute_display_string_end): Accept additional argument STRING.
1739 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1740 (reseat_to_string): Initialize bidi_it->string.s and
1741 bidi_it->string.schars.
1742 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1743 NULL (avoids a crash in bidi_paragraph_init).
1744 Initialize itb.string.lstring.
1745 (init_iterator): Call bidi_init_it only of a valid
1746 buffer position was specified. Initialize paragraph_embedding to
1747 L2R.
1748 (reseat_to_string): Initialize the bidi iterator.
1749 (display_string): If we need to ignore text properties of
1750 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1751 original value of -1 will not work with bidi.)
1752 (compute_display_string_pos): First arg is now struct
1753 `text_pos *'; all callers changed. Support display properties on
1754 Lisp strings.
1755 (compute_display_string_end): Support display properties on Lisp
1756 strings.
1757 (init_iterator, reseat_1, reseat_to_string): Initialize the
1758 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1759 when iterating on a string not from display properties).
1760 (compute_display_string_pos, compute_display_string_end):
1761 Fix calculation of the object to scan. Fixes an error when using
1762 arrow keys.
1763 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1764 base_level_stop; instead, set base_level_stop to BEGV.
1765 Fixes crashes in vertical-motion.
1766 (next_element_from_buffer): Improve commentary for when
1767 the iterator is before prev_stop.
1768 (init_iterator): Initialize bidi_p from the default value of
1769 bidi-display-reordering, not from buffer-local value. Use the
1770 buffer-local value only if initializing for buffer iteration.
1771 (handle_invisible_prop): Support invisible properties on strings
1772 that are being bidi-reordered.
1773 (set_iterator_to_next): Support bidi reordering of C strings and
1774 Lisp strings.
1775 (next_element_from_string): Support bidi reordering of Lisp
1776 strings.
1777 (handle_stop_backwards): Support Lisp strings as well.
1778 (display_string): Support display of R2L glyph rows.
1779 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1780 (init_iterator): Don't initialize it->bidi_p for strings
1781 here.
1782 (reseat_to_string): Initialize it->bidi_p for strings here.
1783 (next_element_from_string, next_element_from_c_string)
1784 (next_element_from_buffer): Add xassert's for correspondence
1785 between IT's object being iterated and it->bidi_it.string
1786 structure.
1787 (face_before_or_after_it_pos): Support bidi iteration.
1788 (next_element_from_c_string): Handle the case of the first string
1789 character that is not the first one in the visual order.
1790 (get_visually_first_element): New function, refactored from common
1791 parts of next_element_from_buffer, next_element_from_string, and
1792 next_element_from_c_string.
1793 (tool_bar_lines_needed, redisplay_tool_bar)
1794 (display_menu_bar): Force left-to-right direction. Add a FIXME
1795 comment for making that be controlled by a user option.
1796 (push_it, pop_it): Save and restore the state of the
1797 bidi iterator. Save and restore the bidi_p flag.
1798 (pop_it): Iterate out of display property for string iteration as
1799 well.
1800 (iterate_out_of_display_property): Support iteration over strings.
1801 (handle_single_display_spec): Set up it->bidi_it for iteration
1802 over a display string, and call bidi_init_it.
1803 (handle_single_display_spec, next_overlay_string)
1804 (get_overlay_strings_1, push_display_prop): Set up the bidi
1805 iterator for displaying display or overlay strings.
1806 (forward_to_next_line_start): Don't use the shortcut if
1807 bidi-iterating.
1808 (back_to_previous_visible_line_start): If handle_display_prop
1809 pushed the iterator stack, restore the internal state of the bidi
1810 iterator by calling bidi_pop_it same number of times.
1811 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1812 and we are bidi-iterating, don't decrement the iterator position;
1813 instead, set the first_elt flag in the bidi iterator, to produce
1814 the same effect.
1815 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1816 (push_display_prop): xassert that we are iterating a buffer.
1817 (push_it, pop_it): Save and restore paragraph_embedding member.
1818 (handle_single_display_spec, next_overlay_string)
1819 (get_overlay_strings_1, reseat_1, reseat_to_string)
1820 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1821 correctly. Don't assume unibyte strings are not bidi-reordered.
1822 (compute_display_string_pos)
1823 (compute_display_string_end): Fix handling the case of C string.
1824 (push_it, pop_it): Save and restore from_disp_prop_p.
1825 (handle_single_display_spec, push_display_prop): Set the
1826 from_disp_prop_p flag.
1827 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1828 (pop_it): Call iterate_out_of_display_property only if we are
1829 popping after iteration over a string that came from a display
1830 property. Fix a typo in popping stretch info. Add an assertion
1831 for verifying that the iterator position is in sync with the bidi
1832 iterator.
1833 (handle_single_display_spec, get_overlay_strings_1)
1834 (push_display_prop): Fix initialization of paragraph direction for
1835 string when that of the parent object is not yet determined.
1836 (reseat_1): Call bidi_init_it to resync the bidi
1837 iterator with IT's position. (Bug#7616)
1838 (find_row_edges): If ROW->start.pos gives position
1839 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1840 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1841 Reset the from_disp_prop_p flag.
1842 (SAVE_IT, RESTORE_IT): New macros.
1843 (pos_visible_p, face_before_or_after_it_pos)
1844 (back_to_previous_visible_line_start)
1845 (move_it_in_display_line_to, move_it_in_display_line)
1846 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1847 (try_scrolling, redisplay_window, display_line): Use them when
1848 saving a temporary copy of the iterator and restoring it back.
1849 (back_to_previous_visible_line_start, reseat_1)
1850 (init_iterator): Empty the bidi cache "stack".
1851 (move_it_in_display_line_to): If iterator ended up at
1852 EOL, but we never saw any buffer positions smaller than
1853 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1854 motion in bidi-reordered lines.
1855 (move_it_in_display_line_to): Record prev_method and prev_pos
1856 immediately before the call to set_iterator_to_next. Fixes cursor
1857 motion in bidi-reordered lines with stretch glyphs and strings
1858 displayed in margins. (Bug#8133) (Bug#8867)
1859 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1860 TO_CHARPOS.
1861 (pos_visible_p): Support positions in bidi-reordered lines.
1862 Save and restore bidi cache.
1863
1864 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1865 (bidi_paragraph_info): Delete unused struct.
1866 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1867 (bidi_cache_start): New variable.
1868 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1869 to zero.
1870 (bidi_cache_fetch_state, bidi_cache_search)
1871 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1872 (bidi_cache_find, bidi_peek_at_next_level)
1873 (bidi_level_of_next_char, bidi_find_other_level_edge)
1874 (bidi_move_to_visually_next): Compare cache index with
1875 bidi_cache_start rather than with zero.
1876 (bidi_fetch_char): Accept new argument STRING; all callers
1877 changed. Support iteration over a string. Support strings with
1878 display properties. Support unibyte strings. Fix the type of
1879 `len' according to what STRING_CHAR_AND_LENGTH expects.
1880 (bidi_paragraph_init, bidi_resolve_explicit_1)
1881 (bidi_resolve_explicit, bidi_resolve_weak)
1882 (bidi_level_of_next_char, bidi_move_to_visually_next):
1883 Support iteration over a string.
1884 (bidi_set_sor_type, bidi_resolve_explicit_1)
1885 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1886 can now be zero (for strings); special values 0 and -1 were
1887 changed to -1 and -2, respectively.
1888 (bidi_char_at_pos): New function.
1889 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1890 Call it instead of FETCH_MULTIBYTE_CHAR.
1891 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1892 initialized to valid values.
1893 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1894 values.
1895 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1896 the test for valid cached positions. Fix the logic for looking up
1897 the sentinel state in the cache. GCPRO the Lisp string we are
1898 iterating.
1899 (bidi_push_it, bidi_pop_it): New functions.
1900 (bidi_initialize): Initialize the bidi cache start stack pointer.
1901 (bidi_cache_ensure_space): New function, refactored from part of
1902 bidi_cache_iterator_state. Don't assume the required size is just
1903 one BIDI_CACHE_CHUNK away.
1904 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1905 (bidi_count_bytes, bidi_char_at_pos): New functions.
1906 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1907 always valid if bidi_cache_idx is valid.
1908 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1909 is valid if it's going to be used.
1910 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1911 (bidi_cache_fetch_state, bidi_cache_search)
1912 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1913 (bidi_cache_iterator_state, bidi_cache_find)
1914 (bidi_find_other_level_edge, bidi_cache_start_stack):
1915 All variables related to cache indices are now EMACS_INT.
1916
1917 * dispextern.h (struct bidi_string_data): New structure.
1918 (struct bidi_it): New member `string'. Make flag members be 1-bit
1919 fields, and put them last in the struct.
1920 (compute_display_string_pos, compute_display_string_end):
1921 Update prototypes.
1922 (bidi_push_it, bidi_pop_it): Add prototypes.
1923 (struct iterator_stack_entry): New members bidi_p,
1924 paragraph_embedding, and from_disp_prop_p.
1925 (struct it): Member bidi_p is now a bit field 1 bit wide.
1926 (bidi_shelve_cache, bidi_unshelve_cache):
1927 Declare prototypes.
1928
1929 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1930 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1931 and vector-like objects.
1932
1933 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1934 cache around display iteration.
1935
1936 * window.c (Fwindow_end, window_scroll_pixel_based)
1937 (displayed_window_lines, Frecenter): Save and restore the bidi
1938 cache around display iteration.
1939
1940 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1941
1942 * editfns.c (Fdelete_region): Clarify the use of the named
1943 parameters (bug#6788).
1944
1945 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1946
1947 * indent.c (Fvertical_motion): Set and restore w->pointm when
1948 saving and restoring the window's buffer (Bug#9006).
1949
1950 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1951
1952 * editfns.c (Fstring_to_char): Clarify just what is returned
1953 (bug#6576). Text by Eli Zaretskii.
1954
1955 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1956
1957 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1958
1959 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1960
1961 * buffer.c (mmap_find): Fix a typo.
1962
1963 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1964
1965 Fix execution of x selection hooks.
1966 * xselect.c (Qx_lost_selection_functions)
1967 (Qx_sent_selection_functions): New vars.
1968 (syms_of_xselect): DEFSYM them.
1969 (x_handle_selection_request): Pass Qx_sent_selection_functions
1970 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1971 (x_handle_selection_clear,x_clear_frame_selections):
1972 Pass Qx_lost_selection_functions rather than
1973 Vx_lost_selection_functions to Frun_hook_with_args.
1974
1975 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1978 The old code sometimes used this field without initializing it.
1979
1980 * alloc.c (gc_sweep): Don't read past end of array.
1981 In theory, the old code could also have corrupted Emacs internals,
1982 though it'd be very unlikely.
1983
1984 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1985
1986 * character.c (Fcharacterp): Don't advertise optional ignored
1987 argument. (Bug#4026)
1988
1989 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1990
1991 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1992 key" (bug#4257).
1993
1994 * window.c (Fset_window_start): Doc fix (bug#4199).
1995 (Fset_window_hscroll): Ditto.
1996
1997 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1998
1999 Fix minor new problems caught by GCC 4.6.1.
2000 * term.c (init_tty): Remove unused local.
2001 * xsettings.c (store_monospaced_changed): Define this function only
2002 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2003 not used otherwise.
2004
2005 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2006
2007 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2008
2009 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2010
2011 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2012 are the mini-buffer and the echo area (bug#3320).
2013
2014 * term.c (init_tty): Remove support for supdup, c10 and perq
2015 terminals, which are no longer supported (bug#1482).
2016
2017 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2018
2019 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2020
2021 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2022
2023 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2024 for non-popups (Bug#3642).
2025
2026 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2027
2028 * alloc.c (reset_malloc_hooks): Protoize.
2029 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2030 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2031 * cm.c (losecursor): Likewise.
2032 * data.c (fmod): Likewise.
2033 * dispnew.c (swap_glyphs_in_rows): Likewise.
2034 * emacs.c (memory_warning_signal): Likewise.
2035 * floatfns.c (float_error): Likewise.
2036 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2037 (otf_open, font_otf_capability, generate_otf_features)
2038 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2039 Likewise.
2040 * image.c (pbm_read_file): Likewise.
2041 * indent.c (string_display_width): Likewise.
2042 * intervals.c (check_for_interval, search_for_interval)
2043 (inc_interval_count, count_intervals, root_interval)
2044 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2045 * lread.c (defalias): Likewise.
2046 * ralloc.c (r_alloc_check): Likewise.
2047 * regex.c (set_image_of_range_1, set_image_of_range)
2048 (regex_grow_registers): Likewise.
2049 * sysdep.c (strerror): Likewise.
2050 * termcap.c (valid_filename_p, tprint, main): Likewise.
2051 * tparam.c (main): Likewise.
2052 * unexhp9k800.c (run_time_remap, save_data_space)
2053 (update_file_ptrs, read_header, write_header, calculate_checksum)
2054 (copy_file, copy_rest, display_header): Likewise.
2055 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2056 Likewise.
2057 * xdisp.c (check_it): Likewise.
2058 * xfaces.c (register_color, unregister_color, unregister_colors):
2059 Likewise.
2060 * xfns.c (print_fontset_result): Likewise.
2061 * xrdb.c (member, fatal, main): Likewise.
2062
2063 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 Fix minor problems found by static checking (Bug#9031).
2066 * chartab.c (char_table_set_range, map_sub_char_table):
2067 Remove unused locals.
2068 (uniprop_table): Now static.
2069 * composite.c (_work_char): Remove unused static var.
2070
2071 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2072
2073 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2074
2075 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2076
2077 * gtkutil.c (qttip_cb): Remove code without function.
2078
2079 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2080
2081 * w32.c (pthread_sigmask): New stub.
2082
2083 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2084
2085 Use pthread_sigmask, not sigprocmask (Bug#9010).
2086 sigprocmask is portable only for single-threaded applications, and
2087 Emacs can be multi-threaded when it uses GTK.
2088 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2089 (LIBES): Use it.
2090 * callproc.c (Fcall_process):
2091 * process.c (create_process):
2092 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2093 Use pthread_sigmask, not sigprocmask.
2094
2095 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2096
2097 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2098 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2099 wrong (Bug#8591).
2100
2101 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2102
2103 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2104 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2105 (xg_hide_tooltip): Fix comment.
2106
2107 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2108 in registerServicesMenuSendTypes.
2109 (validRequestorForSendType): Don't check ns_return_types.
2110
2111 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2112 ns_return_type.
2113
2114 2011-07-08 Jason Rumney <jasonr@gnu.org>
2115
2116 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2117 frame struct members of non-existent frames (Bug#6284).
2118
2119 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2120
2121 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2122 variable firstTime not needed on OSX >= 10.6.
2123 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2124 >= 10.5. Use setKnobProportion, setDoubleValue.
2125
2126 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2127 (MAC_OS_X_VERSION_10_5): Define if not defined.
2128 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2129 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2130 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2131
2132 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2133 cString and lossyCString on OSX >= 10.4
2134
2135 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2136 sizeToFit on OSX >= 10.2.
2137
2138 * nsimage.m (allocInitFromFile): Don't use deprecated method
2139 bestRepresentationForDevice on OSX >= 10.6.
2140
2141 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2142 to avoid warning.
2143
2144 * emacs.c: Declare unexec_init_emacs_zone.
2145
2146 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2147
2148 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2149
2150 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2151 on svcsMenu (Bug#8842).
2152
2153 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2154 ns_return_types.
2155 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2156
2157 * nsterm.m (QUTF8_STRING): Declare.
2158 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2159 (validRequestorForSendType): Return type is (id).
2160 Change indexOfObjectIdenticalTo to indexOfObject.
2161 Check if we have local selection before returning self (Bug#8842).
2162 (writeSelectionToPasteboard): Put local selection into paste board
2163 if we have a local selection (Bug#8842).
2164 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2165
2166 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2167 (ns_get_local_selection): Declare.
2168
2169 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2170
2171 * keymap.c (describe_map_tree): Don't insert a double newline at
2172 the end of the buffer (bug#1169) and return whether we inserted
2173 something.
2174
2175 * callint.c (Fcall_interactively): Change "reading args" to
2176 "providing args" to try to clarify what it does (bug#1010).
2177
2178 2011-07-07 Kenichi Handa <handa@m17n.org>
2179
2180 * composite.c (composition_compute_stop_pos): Ignore a static
2181 composition starting before CHARPOS (Bug#8915).
2182
2183 * xdisp.c (handle_composition_prop): Likewise.
2184
2185 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2186
2187 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2188 (Bug#9015)
2189
2190 2011-07-07 Kenichi Handa <handa@m17n.org>
2191
2192 * character.h (unicode_category_t): New enum type.
2193
2194 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2195 (Qchar_code_property_table): New variable.
2196 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2197 (UNIPROP_COMPRESSED_FORM_P): New macros.
2198 (char_table_ascii): Uncompress the compressed values.
2199 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2200 Uncompress the compressed values.
2201 (sub_char_table_ref_and_range): Likewise.
2202 (char_table_ref_and_range): Uncompress the compressed values.
2203 (sub_char_table_set): New arg is_uniprop. Callers changed.
2204 Uncompress the compressed values.
2205 (sub_char_table_set_range): Args changed. Callers changed.
2206 (char_table_set_range): Adjuted for the above change.
2207 (map_sub_char_table): Delete args default_val and parent. Add arg
2208 top. Give decoded values to a Lisp function.
2209 (map_char_table): Adjust for the above change. Give decoded
2210 values to a Lisp function. Gcpro more variables.
2211 (uniprop_table_uncompress)
2212 (uniprop_decode_value_run_length): New functions.
2213 (uniprop_decoder, uniprop_decoder_count): New variables.
2214 (uniprop_get_decoder, uniprop_encode_value_character)
2215 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2216 New functions.
2217 (uniprop_encoder, uniprop_encoder_count): New variables.
2218 (uniprop_get_encoder, uniprop_table)
2219 (Funicode_property_table_internal, Fget_unicode_property_internal)
2220 (Fput_unicode_property_internal): New functions.
2221 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2222 Sunicode_property_table_internal, Sget_unicode_property_internal,
2223 and Sput_unicode_property_internal. Defvar_lisp
2224 char-code-property-alist.
2225
2226 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2227 Vunicode_category_table.
2228
2229 * font.c (font_range): Adjust for the change of
2230 Vunicode_category_table.
2231
2232 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2233
2234 * m/iris4d.h: Remove file, move contents ...
2235 * s/irix6-5.h: ... here.
2236
2237 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2238
2239 Remove unportable assumption about struct layout (Bug#8884).
2240 * alloc.c (mark_buffer):
2241 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2242 (clone_per_buffer_values): Don't assume that
2243 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2244 This isn't true in general, and it's particularly not true
2245 if Emacs is configured with --with-wide-int.
2246 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2247 New macros, used in the buffer.c change.
2248
2249 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2250
2251 * xsettings.c: Use both GConf and GSettings if both are available.
2252 (store_config_changed_event): Add comment.
2253 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2254 (store_tool_bar_style_changed): New functions.
2255 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2256 (struct xsettings): Move font inside HAVE_XFT.
2257 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2258 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2259 Move inside HAVE_XFT.
2260 (something_changed_gsettingsCB): Rename from something_changedCB.
2261 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2262 also.
2263 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2264 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2265 (something_changed_gconfCB): Rename from something_changedCB.
2266 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2267 (parse_settings): Move check for font inside HAVE_XFT.
2268 (read_settings, apply_xft_settings): Add comment.
2269 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2270 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2271 call store_font_name_changed.
2272 (xft_settings_event): Add comment.
2273 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2274 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2275 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2276 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2277 (xsettings_initialize): Call init_gsettings last.
2278 (xsettings_get_system_font, xsettings_get_system_normal_font):
2279 Add comment.
2280
2281 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2282
2283 Random fixes. E.g., (random) never returned negative values.
2284 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2285 subseconds part to the entropy, as that's a bit more random.
2286 Prefer signed to unsigned, since the signedness doesn't matter and
2287 in general we prefer signed. When given a limit, use a
2288 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2289 latter isn't right if USE_2_TAGS_FOR_INTS.
2290 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2291 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2292
2293 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2294
2295 * textprop.c (text_property_stickiness):
2296 Obey Vtext_property_default_nonsticky.
2297 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2298 * w32fns.c (syms_of_w32fns):
2299 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2300
2301 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2302
2303 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2304 This is more efficient than Ffile_directory_p and avoids a minor race.
2305
2306 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2307
2308 * buffer.c (Foverlay_put): Say what the return value is
2309 (bug#7835).
2310
2311 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2312 is a directory before asking whether to use the file name
2313 (bug#7564).
2314 (barf_or_query_if_file_exists): Make the "File is a directory"
2315 error be more correct.
2316
2317 * fns.c (Frequire): Remove the mention of the .gz files, since
2318 that's installation-specific, but keep the mention of
2319 `get-load-suffixes'.
2320
2321 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2322
2323 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2324 Report string overflow if the output is too long.
2325
2326 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2327
2328 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2329 (syms_of_gnutls): Remove duplicate DEFSYM for
2330 Qgnutls_bootprop_verify_hostname_error, an error for
2331 Qgnutls_bootprop_verify_error (which is no longer used).
2332
2333 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2334 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2335 Also (re)move comments that are misplaced or no longer relevant.
2336
2337 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2338
2339 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2340
2341 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2342
2343 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2344 and background color parameters if they have been changed.
2345
2346 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2347
2348 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2349
2350 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2351
2352 * xsettings.c (SYSTEM_FONT): Define only when used.
2353 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2354
2355 * keymap.c (access_keymap_1): Now static.
2356
2357 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2358
2359 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2360 leave any prefix arg for the up event (Bug#1586).
2361
2362 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2363
2364 * lread.c (syms_of_lread): Mention single symbols defined by
2365 `defvar' or `defconst' (bug#7154).
2366
2367 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2368 (Frequire): Mention get-load-suffixes.
2369
2370 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2371
2372 * window.h (window): Remove clone_number slot.
2373 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2374 Remove.
2375 (make_parent_window, make_window, saved_window)
2376 (Fset_window_configuration, save_window_save): Don't deal with
2377 clone numbers.
2378 * buffer.c (Qclone_number): Remove declaration.
2379 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2380
2381 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2382
2383 Add multiple inheritance to keymaps.
2384 * keymap.c (Fmake_composed_keymap): New function.
2385 (Fset_keymap_parent): Simplify.
2386 (fix_submap_inheritance): Remove.
2387 (access_keymap_1): New function extracted from access_keymap to handle
2388 embedded parents and handle lists of maps.
2389 (access_keymap): Use it.
2390 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2391 (Fcopy_keymap): Handle embedded parents.
2392 (Fcommand_remapping, define_as_prefix): Simplify.
2393 (Fkey_binding): Simplify.
2394 (syms_of_keymap): Move minibuffer-local-completion-map,
2395 minibuffer-local-filename-completion-map,
2396 minibuffer-local-must-match-map, and
2397 minibuffer-local-filename-must-match-map to Elisp.
2398 (syms_of_keymap): Defsubr make-composed-keymap.
2399 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2400 (parse_menu_item): Trivial simplification.
2401
2402 2011-07-01 Glenn Morris <rgm@gnu.org>
2403
2404 * Makefile.in (SETTINGS_LIBS): Fix typo.
2405
2406 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2407
2408 * coding.c (Fencode_coding_string): Record the last coding system
2409 used, as the function doc string says (bug#8738).
2410
2411 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2412
2413 * xsettings.c (store_monospaced_changed): Take new font as arg and
2414 check for change against current_mono_font.
2415 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2416 (emacs_settings_constructor, emacs_settings_get_property)
2417 (emacs_settings_set_property, emacs_settings_class_init)
2418 (emacs_settings_init, gsettings_obj): Remove.
2419 (something_changedCB): New function for HAVE_GSETTINGS.
2420 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2421 with value as argument.
2422 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2423 g_settings_new (Bug#8967). Do not create gsettings_obj.
2424 Remove calls to g_settings_bind. Connect something_changedCB to
2425 "changed".
2426
2427 * xgselect.c: Add defined (HAVE_GSETTINGS).
2428 (xgselect_initialize): Ditto.
2429
2430 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2431 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2432 xg_select.
2433
2434 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 * eval.c (struct backtrace): Simplify and port the data structure.
2437 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2438 signed bit field, as this assumption is not portable and it makes
2439 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2440 "char debug_on_exit : 1" as this is not portable either; instead,
2441 use the portable "unsigned int debug_on_exit : 1". Remove unused
2442 member evalargs. Remove obsolete comments about cc bombing out.
2443
2444 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2445
2446 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2447 Let HAVE_GSETTINGS override HAVE_GCONF.
2448 (store_monospaced_changed): New function.
2449 (EMACS_SETTINGS): A new type derived from GObject to handle
2450 GSettings notifications.
2451 (emacs_settings_constructor, emacs_settings_get_property)
2452 (emacs_settings_set_property, emacs_settings_class_init):
2453 New functions.
2454 (gsettings_client, gsettings_obj): New variables.
2455 (GSETTINGS_SCHEMA): New define.
2456 (something_changedCB): Call store_monospaced_changed.
2457 (init_gsettings): New function.
2458 (xsettings_initialize): Call init_gsettings.
2459 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2460 to NULL.
2461
2462 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2463 GCONF_CFLAGS/LIBS.
2464
2465 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2466
2467 * window.c (resize_root_window, grow_mini_window)
2468 (shrink_mini_window): Rename Qresize_root_window to
2469 Qwindow_resize_root_window and Qresize_root_window_vertically to
2470 Qwindow_resize_root_window_vertically.
2471
2472 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2473
2474 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2475
2476 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2477
2478 * makefile.w32-in: Redesign dependencies so they reflect more
2479 clearly which files are directly included by each source file,
2480 and not through other includes.
2481
2482 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2483
2484 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2485 (sort_overlays, overlay_strings): When an overlay's clone number
2486 matches the window's clone number process the overlay even if
2487 the overlay's window property doesn't match the current window.
2488
2489 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2490 (Fwindow_hchild): Rename to Fwindow_left_child.
2491 (Fwindow_next): Rename to Fwindow_next_sibling.
2492 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2493 (resize_window_check): Rename to window_resize_check.
2494 (resize_window_apply): Rename to window_resize_apply.
2495 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2496 (Fdelete_other_windows_internal, resize_frame_windows)
2497 (Fsplit_window_internal, Fdelete_window_internal)
2498 (grow_mini_window, shrink_mini_window)
2499 (Fresize_mini_window_internal): Fix callers accordingly.
2500
2501 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2502
2503 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2504 (emacs_fixed_set_min_size): Remove.
2505 (emacs_fixed_new): Take frame as argument.
2506
2507 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2508 (_EmacsFixedPrivate): Remove minwidth/height.
2509 Add struct frame *f.
2510 (emacs_fixed_init): Initialize priv->f.
2511 (get_parent_class, emacs_fixed_set_min_size): Remove.
2512 (emacs_fixed_new): Set priv->f to argument.
2513 (emacs_fixed_get_preferred_width)
2514 (emacs_fixed_get_preferred_height): Use min_width/height from
2515 frames size_hint to set minimum and natural (Bug#8919).
2516 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2517 and use min_width/height from frames size_hint to set
2518 min_width/height (Bug#8919).
2519
2520 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2521 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2522 Fix indentation.
2523
2524 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2525
2526 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2527 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2528 called at ZV.
2529
2530 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2531
2532 * process.c (wait_reading_process_output): Bypass select if
2533 waiting for a cell while ignoring keyboard input, and input is
2534 pending. Suggested by Jan Djärv (Bug#8869).
2535
2536 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2537
2538 Use gnulib's dup2 module instead of rolling our own.
2539 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2540
2541 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2542
2543 * dispnew.c (scrolling_window): Before scrolling, turn off a
2544 mouse-highlight in the window being scrolled.
2545
2546 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2547
2548 Move DEFSYM to lisp.h and use everywhere.
2549
2550 * character.h (DEFSYM): Move declaration...
2551 * lisp.h (DEFSYM): ...here.
2552
2553 * gnutls.c:
2554 * minibuf.c:
2555 * w32menu.c:
2556 * w32proc.c:
2557 * w32select.c: Don't include character.h.
2558
2559 * alloc.c (syms_of_alloc):
2560 * buffer.c (syms_of_buffer):
2561 * bytecode.c (syms_of_bytecode):
2562 * callint.c (syms_of_callint):
2563 * casefiddle.c (syms_of_casefiddle):
2564 * casetab.c (init_casetab_once):
2565 * category.c (init_category_once, syms_of_category):
2566 * ccl.c (syms_of_ccl):
2567 * cmds.c (syms_of_cmds):
2568 * composite.c (syms_of_composite):
2569 * dbusbind.c (syms_of_dbusbind):
2570 * dired.c (syms_of_dired):
2571 * dispnew.c (syms_of_display):
2572 * doc.c (syms_of_doc):
2573 * editfns.c (syms_of_editfns):
2574 * emacs.c (syms_of_emacs):
2575 * eval.c (syms_of_eval):
2576 * fileio.c (syms_of_fileio):
2577 * fns.c (syms_of_fns):
2578 * frame.c (syms_of_frame):
2579 * fringe.c (syms_of_fringe):
2580 * insdel.c (syms_of_insdel):
2581 * keymap.c (syms_of_keymap):
2582 * lread.c (init_obarray, syms_of_lread):
2583 * macros.c (syms_of_macros):
2584 * msdos.c (syms_of_msdos):
2585 * print.c (syms_of_print):
2586 * process.c (syms_of_process):
2587 * search.c (syms_of_search):
2588 * sound.c (syms_of_sound):
2589 * syntax.c (init_syntax_once, syms_of_syntax):
2590 * terminal.c (syms_of_terminal):
2591 * textprop.c (syms_of_textprop):
2592 * undo.c (syms_of_undo):
2593 * w32.c (globals_of_w32):
2594 * window.c (syms_of_window):
2595 * xdisp.c (syms_of_xdisp):
2596 * xfaces.c (syms_of_xfaces):
2597 * xfns.c (syms_of_xfns):
2598 * xmenu.c (syms_of_xmenu):
2599 * xsettings.c (syms_of_xsettings):
2600 * xterm.c (syms_of_xterm): Use DEFSYM.
2601
2602 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2603
2604 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2605
2606 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 Integer and buffer overflow fixes (Bug#8873).
2609
2610 * print.c (printchar, strout): Check for string overflow.
2611 (PRINTPREPARE, printchar, strout):
2612 Don't set size unless allocation succeeds.
2613
2614 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2615 for sizes. Check for string overflow more accurately.
2616 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2617
2618 * macros.c: Integer and buffer overflow fixes.
2619 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2620 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2621 Use ptrdiff_t, not int, for sizes.
2622 Don't increment bufsize until after realloc succeeds.
2623 Check for size-calculation overflow.
2624 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2625
2626 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2627
2628 * lread.c: Integer overflow fixes.
2629 (read_integer): Radix is now EMACS_INT, not int,
2630 to improve quality of diagnostics for out-of-range radices.
2631 Calculate buffer size correctly for out-of-range radices.
2632 (read1): Check for integer overflow in radices, and in
2633 read-circle numbers.
2634 (read_escape): Avoid int overflow.
2635 (Fload, openp, read_buffer_size, read1)
2636 (substitute_object_recurse, read_vector, read_list, map_obarray):
2637 Use ptrdiff_t, not int, for sizes.
2638 (read1): Use EMACS_INT, not int, for sizes.
2639 Check for size overflow.
2640
2641 * image.c (cache_image): Check for size arithmetic overflow.
2642
2643 * lread.c: Integer overflow issues.
2644 (saved_doc_string_size, saved_doc_string_length)
2645 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2646 Now ptrdiff_t, not int.
2647 (read1): Don't assume doc string length fits in int. Check for
2648 out-of-range doc string lengths.
2649 (read_list): Don't assume file position fits in int.
2650 (read_escape): Check for hex character overflow.
2651
2652 2011-06-22 Leo Liu <sdl.web@gmail.com>
2653
2654 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2655 Move to minibuffer.el.
2656
2657 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2658
2659 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2660 The following patches are for when GLYPH_DEBUG && !XASSERT.
2661 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2662 * dispnew.c (flush_stdout):
2663 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2664 Mark as externally visible.
2665 * dispnew.c (check_window_matrix_pointers): Now static.
2666 * dispnew.c (window_to_frame_vpos):
2667 * xfns.c (unwind_create_frame):
2668 * xterm.c (x_check_font): Remove unused local.
2669 * scroll.c (CHECK_BOUNDS):
2670 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2671 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2672 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2673 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2674 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2675 Now static.
2676 (debug_method_add): Use va_list and vsprintf rather than relying
2677 on undefined behavior with wrong number of arguments.
2678 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2679 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2680 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2681 since we're not interested in debugging glyphs with old libraries.
2682 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2683 GCC 4.6.0's static checking.
2684
2685 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2686
2687 Integer overflow and signedness fixes (Bug#8873).
2688 A few related buffer overrun fixes, too.
2689
2690 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2691
2692 * dispextern.h (struct face.stipple):
2693 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2694 (x_bitmap_mask, x_allocate_bitmap_record)
2695 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2696 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2697 (x_create_bitmap_from_xpm_data):
2698 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2699 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2700 (.bitmaps_last):
2701 * xfaces.c (load_pixmap):
2702 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2703 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2704 (.bitmaps_last, struct x_output.icon_bitmap):
2705 Use ptrdiff_t, not int, for bitmap indexes.
2706 (x_allocate_bitmap_record): Check for size overflow.
2707 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2708
2709 Use ptrdiff_t, not int, for overlay counts.
2710 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2711 * editfns.c (overlays_around, get_pos_property):
2712 * textprop.c (get_char_property_and_overlay):
2713 * xdisp.c (next_overlay_change, note_mouse_highlight):
2714 * xfaces.c (face_at_buffer_position):
2715 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2716 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2717 (Fnext_overlay_change, Fprevious_overlay_change)
2718 (mouse_face_overlay_overlaps, Foverlays_in):
2719 Use ptrdiff_t, not int, for sizes.
2720 (overlays_at, overlays_in): Check for size-calculation overflow.
2721
2722 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2723
2724 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2725 (x_session_initialize): Do not assume string length fits in int.
2726
2727 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2728 This is unlikely, but can occur if DPI is outlandish.
2729
2730 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2731 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2732
2733 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2734 * xrdb.c (magic_file_p, search_magic_path):
2735 Omit last arg SUFFIX; it was always 0. All callers changed.
2736 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2737
2738 * xfont.c (xfont_match): Avoid need for strlen.
2739
2740 * xfns.c: Don't assume strlen fits in int.
2741 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2742
2743 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2744 not unsigned long, as we prefer signed integers. All callers changed.
2745 Detect integer overflow in repeat count.
2746 (message_dolog): Don't assume print length fits in 39 bytes.
2747 (display_mode_element): Don't assume strlen fits in int.
2748
2749 * termcap.c: Don't assume sizes fit in int and never overflow.
2750 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2751 (gobble_line): Check for size-calculation overflow.
2752
2753 * minibuf.c (Fread_buffer):
2754 * lread.c (intern, intern_c_string):
2755 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2756 Don't assume string length fits in int.
2757
2758 * keyboard.c (parse_tool_bar_item):
2759 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2760
2761 * font.c: Don't assume string length fits in int.
2762 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2763 Use ptrdiff_t, not int.
2764 (font_intern_prop): Don't assume string length fits in int.
2765 Don't assume integer property fits in fixnum.
2766 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2767
2768 * filelock.c: Fix some buffer overrun and integer overflow issues.
2769 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2770 Reformulate so as not to need the command string.
2771 Invoke gzip -cd rather than gunzip, as it's more portable.
2772 (lock_info_type, lock_file_1, lock_file):
2773 Don't assume pid_t and time_t fit in unsigned long.
2774 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2775 (current_lock_owner): Prefer signed type for sizes.
2776 Use memcpy, not strncpy, where memcpy is what is really wanted.
2777 Don't assume (via atoi) that time_t and pid_t fit in int.
2778 Check for time_t and/or pid_t out of range, e.g., via a network share.
2779 Don't alloca where an auto var works fine.
2780
2781 * fileio.c: Fix some integer overflow issues.
2782 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2783 Don't assume string length fits in int.
2784 (directory_file_name): Don't assume string length fits in long.
2785 (make_temp_name): Don't assume pid fits in int, or that its print
2786 length is less than 20.
2787
2788 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2789
2790 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2791
2792 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2793
2794 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2795 We prefer signed integers, even for size calculations.
2796
2797 * emacs.c: Don't assume string length fits in 'int'.
2798 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2799 (main): Don't invoke strlen when not needed.
2800
2801 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2802 (XD_DEBUG_MESSAGE): Don't waste a byte.
2803
2804 * callproc.c (getenv_internal_1, getenv_internal)
2805 (Fgetenv_internal):
2806 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2807
2808 * lread.c (invalid_syntax): Omit length argument.
2809 All uses changed. This doesn't fix a bug, but it simplifies the
2810 code away from its former Hollerith-constant appearance, and it's
2811 one less 'int' to worry about when looking at integer-overflow issues.
2812 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2813
2814 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2815 This didn't break anything, but it didn't help either.
2816 It's confusing to put a bogus integer in a place where the actual
2817 value does not matter.
2818 (LIST_END_P): Remove unused macro and its bogus comment.
2819 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2820
2821 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2822 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2823 implementation.
2824 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2825 We prefer signed types, and the value cannot exceed the EMACS_INT
2826 range anyway (because otherwise the length would not be representable).
2827 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2828 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2829 This avoids a GCC warning when WIDE_EMACS_INT.
2830
2831 * indent.c (sane_tab_width): New function.
2832 (current_column, scan_for_column, Findent_to, position_indentation)
2833 (compute_motion): Use it. This is just for clarity.
2834 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2835
2836 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2837
2838 * lisp.h (lint_assume): New macro.
2839 * composite.c (composition_gstring_put_cache):
2840 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2841
2842 * editfns.c, insdel.c:
2843 Omit unnecessary forward decls, to simplify future changes.
2844
2845 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2846
2847 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2848
2849 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2850 Use much-faster test for byte-length change.
2851 Don't assume string byte-length fits in 'int'.
2852 Check that character arg fits in 'int'.
2853 (mapcar1): Declare byte as byte, for clarity.
2854
2855 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2856
2857 * fns.c (concat): Catch string overflow earlier.
2858 Do not rely on integer wraparound.
2859
2860 * dispextern.h (struct it.overlay_strings_charpos)
2861 (struct it.selective): Now EMACS_INT, not int.
2862 * xdisp.c (forward_to_next_line_start)
2863 (back_to_previous_visible_line_start)
2864 (reseat_at_next_visible_line_start, next_element_from_buffer):
2865 Don't arbitrarily truncate the value of 'selective' to int.
2866
2867 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2868
2869 * composite.c: Don't truncate sizes to 'int'.
2870 (composition_gstring_p, composition_reseat_it)
2871 (composition_adjust_point): Use EMACS_INT, not int.
2872 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2873 not EMACS_UINT, for indexes.
2874
2875 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2876
2877 * buffer.c: Include <verify.h>.
2878 (struct sortvec.priority, struct sortstr.priority):
2879 Now EMACS_INT, not int.
2880 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2881 (struct sortstr.size, record_overlay_string)
2882 (struct sortstrlist.size, struct sortlist.used):
2883 Don't truncate size to int.
2884 (record_overlay_string): Check for size-calculation overflow.
2885 (init_buffer_once): Check at compile-time, not run-time.
2886
2887 2011-06-22 Jim Meyering <meyering@redhat.com>
2888
2889 Don't leak an XBM-image-sized buffer
2890 * image.c (xbm_load): Free the image buffer after using it.
2891
2892 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 Port to Sun C.
2895 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2896 that Sun C diagnosed.
2897 * fns.c (secure_hash): Fix pointer signedness issue.
2898 * intervals.c (static_offset_intervals): New function.
2899 (offset_intervals): Use it.
2900
2901 2011-06-21 Leo Liu <sdl.web@gmail.com>
2902
2903 * deps.mk (fns.o):
2904 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2905 sha512.h.
2906
2907 * fns.c (secure_hash): Rename from crypto_hash_function and change
2908 the first arg to accept symbols.
2909 (Fsecure_hash): New primitive.
2910 (syms_of_fns): New symbols.
2911
2912 2011-06-20 Deniz Dogan <deniz@dogan.se>
2913
2914 * process.c (Fset_process_buffer): Clarify return value in
2915 docstring.
2916
2917 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2918
2919 * dispnew.c (add_window_display_history): Use BVAR.
2920
2921 * xdisp.c (debug_method_add): Use BVAR.
2922 (check_window_end, dump_glyph_matrix, dump_glyph)
2923 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2924
2925 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2926 Likewise.
2927
2928 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2929 check till after the cache is created in init_frame_faces.
2930
2931 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2932
2933 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2934
2935 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2936
2937 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2938 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2939 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2940
2941 Improve buffer-overflow checking (Bug#8873).
2942 * fileio.c (Finsert_file_contents):
2943 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2944 Remove the old (too-loose) buffer overflow checks.
2945 They weren't needed, since make_gap checks for buffer overflow.
2946 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2947 The old code merely checked for Emacs fixnum overflow, and relied
2948 on undefined (wraparound) behavior. The new code avoids undefined
2949 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2950
2951 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2952 Tune. Don't use wider integers than needed. Don't use alloca.
2953 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2954
2955 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2956
2957 * insdel.c, lisp.h (buffer_overflow): New function.
2958 (insert_from_buffer_1, replace_range, replace_range_2):
2959 * insdel.c (make_gap_larger):
2960 * editfns.c (Finsert_char):
2961 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2962
2963 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2964
2965 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2966
2967 Integer overflow and signedness fixes (Bug#8873).
2968
2969 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2970 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2971
2972 * fileio.c: Don't assume EMACS_INT fits in off_t.
2973 (emacs_lseek): New static function.
2974 (Finsert_file_contents, Fwrite_region): Use it.
2975 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2976
2977 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2978
2979 * fns.c: Don't overflow int when computing a list length.
2980 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2981 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2982 truncation on 64-bit hosts. Check for QUIT every
2983 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2984 faster and is responsive enough.
2985 (Flength): Report an error instead of overflowing an integer.
2986 (Fsafe_length): Return a float if the value is not representable
2987 as a fixnum. This shouldn't happen except in contrived situations.
2988 (Fnthcdr, Fsort): Don't assume list length fits in int.
2989 (Fcopy_sequence): Don't assume vector length fits in int.
2990
2991 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2992 (header_size, word_size): New constants.
2993 (allocate_vectorlike): Don't check size overflow here.
2994 (allocate_vector): Check it here instead, since this is the only
2995 caller of allocate_vectorlike that could cause overflow.
2996 Check that the new vector's length is representable as a fixnum.
2997
2998 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2999 The previous code was bogus. For example, next_almost_prime (32)
3000 returned 39, which is undesirable as it is a multiple of 3; and
3001 next_almost_prime (24) returned 25, which is a multiple of 5 so
3002 why was the code bothering to check for multiples of 7?
3003
3004 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3005
3006 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3007
3008 Variadic C functions now count arguments with ptrdiff_t.
3009 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3010 Back then I didn't know that the Emacs coding style prefers signed int.
3011 Also, in the meantime I found a few more instances where arguments
3012 were being counted with int, which may truncate counts on 64-bit
3013 machines, or EMACS_INT, which may be unnecessarily wide.
3014 * lisp.h (struct Lisp_Subr.function.aMANY)
3015 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3016 Arg counts are now ptrdiff_t, not size_t.
3017 All variadic functions and their callers changed accordingly.
3018 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3019 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3020 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3021 * callint.c (Fcall_interactively): Check arg count for overflow,
3022 to avoid potential buffer overrun. Use signed char, not 'int',
3023 for 'varies' array, so that we needn't bother to check its size
3024 calculation for overflow.
3025 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3026 * eval.c (apply_lambda):
3027 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3028 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3029 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3030
3031 * callint.c (Fcall_interactively): Don't use index var as event count.
3032
3033 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3034 * mem-limits.h (SIZE): Remove; no longer used.
3035
3036 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3037
3038 Remove unnecessary casts.
3039 * xterm.c (x_term_init):
3040 * xfns.c (x_set_border_pixel):
3041 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3042 These aren't needed now that we assume ANSI C.
3043
3044 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3045 It's more likely to cause problems (due to unsigned overflow)
3046 than to cure them.
3047
3048 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3049
3050 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3051
3052 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3053
3054 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3055
3056 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3057
3058 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3059
3060 GLYPH_CODE_FACE returns EMACS_INT, not int.
3061 * dispextern.h (merge_faces):
3062 * xfaces.c (merge_faces):
3063 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3064 Don't assume EMACS_INT fits in int.
3065
3066 * character.h (CHAR_VALID_P): Remove unused parameter.
3067 * fontset.c, lisp.h, xdisp.c: All uses changed.
3068
3069 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3070
3071 * fns.c (concat): Minor tuning based on overflow analysis.
3072 This doesn't fix any bugs. Use int to hold character, instead
3073 of constantly refetching from Emacs object. Use XFASTINT, not
3074 XINT, for value known to be a character. Don't bother comparing
3075 a single byte to 0400, as it's always less.
3076
3077 * floatfns.c (Fexpt):
3078 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3079
3080 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3081 for characters.
3082
3083 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3084
3085 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3086 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3087 incorrectly succeed when S was a string, because 4294967386 was
3088 truncated before it was used.
3089
3090 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3091 Otherwise, an out-of-range integer could cause undefined behavior
3092 on a 64-bit host.
3093
3094 * composite.c: Use int, not EMACS_INT, for characters.
3095 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3096 EMACS_INT, for values that are known to be in character range.
3097 This doesn't fix any bugs but is the usual style inside Emacs and
3098 may generate better code on 32-bit machines.
3099
3100 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3101 This is for reasons similar to the recent CHAR_STRING fix.
3102 * charset.c (Fencode_char): Check that character arg is actually
3103 a character. Pass an int to ENCODE_CHAR.
3104 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3105 wider than 'int', as a compile-time check to prevent future regressions
3106 in this area.
3107
3108 * character.c (char_string): Remove unnecessary casts.
3109
3110 Make sure a 64-bit char is never passed to CHAR_STRING.
3111 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3112 by silently ignoring the top 32 bits, allowing some values
3113 that were far too large to be valid characters.
3114 * character.h: Include <verify.h>.
3115 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3116 arguments are no wider than unsigned, as a compile-time check
3117 to prevent future regressions in this area.
3118 * data.c (Faset):
3119 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3120 (Fsubst_char_in_region):
3121 * fns.c (concat):
3122 * xdisp.c (decode_mode_spec_coding):
3123 Adjust to CHAR_STRING's new requirement.
3124 * editfns.c (Finsert_char, Fsubst_char_in_region):
3125 * fns.c (concat): Check that character args are actually
3126 characters. Without this test, these functions did the wrong
3127 thing with wildly out-of-range values on 64-bit hosts.
3128
3129 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3130 These casts should not be needed on 32-bit hosts, either.
3131 * keyboard.c (read_char):
3132 * lread.c (Fload): Remove casts to unsigned.
3133
3134 * lisp.h (UNSIGNED_CMP): New macro.
3135 This fixes comparison bugs on 64-bit hosts.
3136 (ASCII_CHAR_P): Use it.
3137 * casefiddle.c (casify_object):
3138 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3139 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3140 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3141 * dispextern.h (FACE_FROM_ID):
3142 * keyboard.c (read_char): Use UNSIGNED_CMP.
3143
3144 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3145 not to EMACS_INT, to avoid GCC warning.
3146
3147 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3148
3149 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3150 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3151 isn't needed on 32-bit machines.
3152
3153 * buffer.c (Fgenerate_new_buffer_name):
3154 Use EMACS_INT for count, not int.
3155 (advance_to_char_boundary): Return EMACS_INT, not int.
3156
3157 * data.c (Qcompiled_function): Now static.
3158
3159 * window.c (window_body_lines): Now static.
3160
3161 * image.c (gif_load): Rename local to avoid shadowing.
3162
3163 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3164 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3165 * alloc.c (make_save_value): Integer argument is now of type
3166 ptrdiff_t, not int.
3167 (mark_object): Use ptrdiff_t, not int.
3168 * lisp.h (pD): New macro.
3169 * print.c (print_object): Use it.
3170
3171 * alloc.c: Use EMACS_INT, not int, to count objects.
3172 (total_conses, total_markers, total_symbols, total_vector_size)
3173 (total_free_conses, total_free_markers, total_free_symbols)
3174 (total_free_floats, total_floats, total_free_intervals)
3175 (total_intervals, total_strings, total_free_strings):
3176 Now EMACS_INT, not int. All uses changed.
3177 (Fgarbage_collect): Compute overall total using a double, so that
3178 integer overflow is less likely to be a problem. Check for overflow
3179 when converting back to an integer.
3180 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3181 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3182 These were 'int' variables that could overflow on 64-bit hosts;
3183 they were never used, so remove them instead of repairing them.
3184 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3185 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3186 Previously, this ceilinged at INT_MAX, but that doesn't work on
3187 64-bit machines.
3188 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3189
3190 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3191 (allocate_vectorlike): Check for ptrdiff_t overflow.
3192 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3193 when a (possibly-narrower) signed value would do just as well.
3194 We prefer using signed arithmetic, to avoid comparison confusion.
3195
3196 * alloc.c: Catch some string size overflows that we were missing.
3197 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3198 for convenience in STRING_BYTES_MAX.
3199 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3200 The definition here is exact; the one in lisp.h was approximate.
3201 (allocate_string_data): Check for string overflow. This catches
3202 some instances we weren't catching before. Also, it catches
3203 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3204 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3205 and ptrdiff_t and EMACS_INT are both 64 bits.
3206
3207 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3208 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3209 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3210
3211 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3212
3213 * alloc.c (Fmake_string): Check for out-of-range init.
3214
3215 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3216
3217 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3218
3219 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3220
3221 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3222 xg_get_default_scrollbar_width.
3223
3224 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3225 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3226 (style_changed_cb): Call update_theme_scrollbar_width and call
3227 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3228 all frames (Bug#8505).
3229 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3230 Call gtk_window_set_resizable if HAVE_GTK3.
3231 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3232 and height if HAVE_GTK3 (Bug#8505).
3233 (scroll_bar_width_for_theme): New variable.
3234 (update_theme_scrollbar_width): New function.
3235 (xg_get_default_scrollbar_width): Move code to
3236 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3237 (xg_initialize): Call update_theme_scrollbar_width.
3238
3239 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3240
3241 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3242
3243 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3244
3245 * frame.c (make_frame): Call other_buffer_safely instead of
3246 other_buffer.
3247
3248 * window.c (temp_output_buffer_show): Call display_buffer with
3249 second argument Vtemp_buffer_show_specifiers and reset latter
3250 immediately after the call.
3251 (Vtemp_buffer_show_specifiers): New variable.
3252 (auto_window_vscroll_p, next_screen_context_lines)
3253 (Vscroll_preserve_screen_position): Remove leading asterisks from
3254 doc-strings.
3255
3256 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3257
3258 Fix minor problems found by GCC 4.6.0 static checking.
3259 * buffer.c (Qclone_number): Remove for now, as it's unused.
3260 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3261 (record_buffer): Remove unused local.
3262 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3263 (set_frame_buffer_list): Remove; unused.
3264 * frame.h (other_visible_frames): Remove decl.
3265 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3266 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3267 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3268 if HAVE_GPM.
3269 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3270 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3271 Define only if HAVE_GPM.
3272 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3273 (update_hints_inhibit): Remove; never set. All uses removed.
3274 * widgetprv.h (emacsFrameClassRec): Remove decl.
3275 * window.c (delete_deletable_window): Now returns void, since it
3276 wasn't returning anything.
3277 (compare_window_configurations): Remove unused locals.
3278 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3279 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3280 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3281 the same widths as pointers. This follows up on the 2011-05-06 patch.
3282 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3283 * xterm.h: Likewise.
3284 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3285
3286 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3287
3288 * makefile.w32-in: Update dependencies.
3289 (LISP_H): Add lib/intprops.h.
3290
3291 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3292
3293 * image.c (gif_load): Add animation frame delay to the metadata.
3294 (syms_of_image): Use DEFSYM. New symbol `delay'.
3295
3296 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3297
3298 * window.c (delete_deletable_window): Re-add.
3299 (Fset_window_configuration): Rewrite to handle dead buffers and
3300 consequently deletable windows.
3301 (window_tree, Fwindow_tree): Remove. Supply functionality in
3302 window.el.
3303 (compare_window_configurations): Simplify code.
3304
3305 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3306
3307 * image.c (imagemagick_load_image): Fix type mismatch.
3308 (Fimagemagick_types): Likewise.
3309
3310 * window.h (replace_buffer_in_windows): Declare.
3311
3312 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3313
3314 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3315 Qclone_number. Remove external declaration of Qdelete_window.
3316 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3317 code.
3318 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3319 Run Qbuffer_list_update_hook if allowed.
3320 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3321 buffer list implementation.
3322 (other_buffer_safely): New function.
3323 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3324 calls to replace_buffer_in_windows and
3325 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3326 if allowed.
3327 (record_buffer): Inhibit quitting and rewrite using quittable
3328 functions. Run Qbuffer_list_update_hook if allowed.
3329 (Frecord_buffer, Funrecord_buffer): New functions.
3330 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3331 Move switch-to-buffer to window.el.
3332 (bury-buffer): Move to window.el.
3333 (Vbuffer_list_update_hook): New variable.
3334
3335 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3336 section.
3337
3338 * window.h (resize_frame_windows): Move up in code.
3339 (Fwindow_frame): Remove EXFUN.
3340 (replace_buffer_in_all_windows): Remove prototype.
3341 (replace_buffer_in_windows_safely): Add prototype.
3342
3343 * window.c: Declare Qdelete_window static again. Move down
3344 declaration of select_count.
3345 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3346 (Fother_window): Move to window.el.
3347 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3348 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3349 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3350 window.el.
3351 (replace_buffer_in_windows): Implement by calling
3352 Qreplace_buffer_in_windows.
3353 (replace_buffer_in_all_windows): Remove with some functionality
3354 moved into replace_buffer_in_windows_safely.
3355 (replace_buffer_in_windows_safely): New function.
3356 (select_window_norecord, select_frame_norecord): Move in front
3357 of run_window_configuration_change_hook. Remove now obsolete
3358 declarations.
3359 (Fset_window_buffer): Rewrite doc-string.
3360 Call Qrecord_window_buffer.
3361 (keys_of_window): Move binding for other-window to window.el.
3362
3363 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3364
3365 * dispextern.h (struct image): Replace data member, whose int_val
3366 and ptr_val fields were not used by anything, with a single
3367 lisp_val object.
3368
3369 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3370 (gif_clear_image, gif_load, imagemagick_load_image)
3371 (gs_clear_image, gs_load): Callers changed.
3372
3373 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3374
3375 * buffer.h: Include <time.h>, for time_t.
3376 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3377
3378 Fix minor problems found by static checking.
3379
3380 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3381
3382 Make identifiers static if they are not used in other modules.
3383 * data.c (Qcompiled_function, Qframe, Qvector):
3384 * image.c (QimageMagick, Qsvg):
3385 * minibuf.c (Qmetadata):
3386 * window.c (resize_window_check, resize_root_window): Now static.
3387 * window.h (resize_window_check, resize_root_window): Remove decls.
3388
3389 * window.c (window_deletion_count, delete_deletable_window):
3390 Remove; unused.
3391 (window_body_lines): Now static.
3392 (Fdelete_other_windows_internal): Mark vars as initialized.
3393 Make sure 'resize_failed' is initialized.
3394 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3395 (resize_window_apply): Remove unused local.
3396 * window.h (delete_deletable_window): Remove decl.
3397
3398 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3399 (imagemagick_load_image): Fix pointer signedness problem by changing
3400 last arg from unsigned char * to char *. All uses changed.
3401 Also, fix a local for similar reasons.
3402 Remove unused locals. Remove locals to avoid shadowing.
3403 (fn_rsvg_handle_free): Remove; unused.
3404 (svg_load, svg_load_image): Fix pointer signedness problem.
3405 (imagemagick_load_image): Don't use garbage pointer image_wand.
3406
3407 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3408
3409 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3410
3411 * image.c (gif_load): Fix omitted cast error introduced by
3412 2011-06-06 change.
3413
3414 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3415
3416 * window.h (resize_proportionally, orig_total_lines)
3417 (orig_top_line): Remove from window structure.
3418 (set_window_height, set_window_width, change_window_heights)
3419 (Fdelete_window): Remove prototypes.
3420 (resize_frame_windows): Remove duplicate declaration.
3421
3422 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3423
3424 * window.h (resize_frame_windows, resize_window_check)
3425 (delete_deletable_window, resize_root_window)
3426 (resize_frame_windows): Declare prototypes.
3427
3428 * window.c (resize_window_apply): Make definition be "static" to
3429 match the prototype.
3430
3431 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3432
3433 * window.c: Remove declarations of Qwindow_size_fixed,
3434 window_min_size_1, window_min_size_2, window_min_size,
3435 size_window, window_fixed_size_p, enlarge_window, delete_window.
3436 Remove static from declaration of Qdelete_window, it's
3437 temporarily needed by Fbury_buffer.
3438 (replace_window): Don't assign orig_top_line and
3439 orig_total_lines.
3440 (Fdelete_window, delete_window): Remove. Window deletion is
3441 handled by window.el.
3442 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3443 Replace Fdelete_window calls with calls to Qdelete_window.
3444 (Fdelete_other_windows): Remove. Deleting other windows is
3445 handled by window.el.
3446 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3447 handled in window.el.
3448 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3449 Window minimum sizes are handled in window.el.
3450 (shrink_windows, size_window, set_window_height)
3451 (set_window_width, change_window_heights, window_height)
3452 (window_width, CURBEG, CURSIZE, enlarge_window)
3453 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3454 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3455 handled in window.el.
3456 (make_dummy_parent): Rename to make_parent_window and give it a
3457 second argument horflag.
3458 (make_window): Don't set resize_proportionally any more.
3459 (Fsplit_window): Remove. Windows are split in window.el.
3460 (save_restore_action, save_restore_orig_size)
3461 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3462 Resize mini windows in window.el.
3463 (grow_mini_window, shrink_mini_window): Implement by calling
3464 Qresize_root_window_vertically, resize_window_check and
3465 resize_window_apply.
3466 (saved_window, Fset_window_configuration, save_window_save):
3467 Do not handle orig_top_line, orig_total_lines, and
3468 resize_proportionally.
3469 (window_min_height, window_min_width): Move to window.el.
3470 (keys_of_window): Move bindings for delete-other-windows,
3471 split-window, delete-window and enlarge-window to window.el.
3472
3473 * buffer.c: Temporarily extern Qdelete_window.
3474 (Fbury_buffer): Temporarily call Qdelete_window instead of
3475 Fdelete_window (Fbury_buffer will move to window.el soon).
3476
3477 * frame.c (set_menu_bar_lines_1): Remove code handling
3478 orig_top_line and orig_total_lines.
3479
3480 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3481 set_window_height but set heights directly.
3482 (change_frame_size_1): Use resize_frame_windows.
3483
3484 * xdisp.c (init_xdisp): Don't use set_window_height but set
3485 heights directly.
3486
3487 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3488 Use resize_frame_windows instead of change_window_heights and run
3489 run_window_configuration_change_hook.
3490
3491 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3492 instead of change_window_heights and run
3493 run_window_configuration_change_hook.
3494
3495 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3496
3497 * window.c (replace_window): Rename second argument REPLACEMENT to
3498 NEW. New third argument SETFLAG. Rewrite.
3499 (delete_window, make_dummy_parent): Call replace_window with
3500 third argument 1.
3501 (window_list_1): Move down in code.
3502 (run_window_configuration_change_hook): Move set_buffer part
3503 before select_frame_norecord part in order to unwind correctly.
3504 Rename count1 to count.
3505 (recombine_windows, delete_deletable_window, resize_root_window)
3506 (Fdelete_other_windows_internal)
3507 (Frun_window_configuration_change_hook, make_parent_window)
3508 (resize_window_check, resize_window_apply, Fresize_window_apply)
3509 (resize_frame_windows, Fsplit_window_internal)
3510 (Fdelete_window_internal, Fresize_mini_window_internal):
3511 New functions.
3512 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3513
3514 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3515
3516 * window.h (window): Add some new members to window structure -
3517 normal_lines, normal_cols, new_total, new_normal, clone_number,
3518 splits, nest, prev_buffers, next_buffers.
3519 (WINDOW_TOTAL_SIZE): Move here from window.c.
3520 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3521
3522 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3523 Remove.
3524 (make_dummy_parent): Set new members of windows structure.
3525 (make_window): Move down in code. Handle new members of window
3526 structure.
3527 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3528 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3529 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3530 (Fset_window_prev_buffers, Fwindow_next_buffers)
3531 (Fset_window_next_buffers, Fset_window_clone_number):
3532 New functions.
3533 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3534 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3535 Doc-string fixes.
3536 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3537 Argument WINDOW can be now internal window too.
3538 (Fwindow_use_time): Move up in code.
3539 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3540 Rewrite doc-string.
3541 (Fset_window_configuration, saved_window)
3542 (Fcurrent_window_configuration, save_window_save): Handle new
3543 members of window structure.
3544 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3545 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3546 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3547 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3548 Qget_mru_window, Qresize_root_window,
3549 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3550 Qauto_buffer_name; staticpro them.
3551
3552 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3553
3554 * window.c (Fwindow_total_size, Fwindow_left_column)
3555 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3556 (Fwindow_list_1): New functions.
3557 (window_box_text_cols): Replace with window_body_cols.
3558 (Fwindow_width, Fscroll_left, Fscroll_right):
3559 Use window_body_cols instead of window_box_text_cols.
3560 (delete_window, Fset_window_configuration):
3561 Call delete_all_subwindows with window as argument.
3562 (delete_all_subwindows): Take a window as argument and not a
3563 structure. Rewrite.
3564 (window_loop): Remove handling of GET_LRU_WINDOW and
3565 GET_LARGEST_WINDOW.
3566 (Fget_lru_window, Fget_largest_window): Move to window.el.
3567
3568 * window.h: Extern window_body_cols instead of
3569 window_box_text_cols. delete_all_subwindows now takes a
3570 Lisp_Object as argument.
3571
3572 * indent.c (compute_motion, Fcompute_motion):
3573 Use window_body_cols instead of window_box_text_cols.
3574
3575 * frame.c (delete_frame): Call delete_all_subwindows with root
3576 window as argument.
3577
3578 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3579
3580 * fns.c (Fputhash): Document return value.
3581
3582 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3583
3584 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3585
3586 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3587
3588 Cons<->int and similar integer overflow fixes (Bug#8794).
3589
3590 Check for overflow when converting integer to cons and back.
3591 * charset.c (Fdefine_charset_internal, Fdecode_char):
3592 Use cons_to_unsigned to catch overflow.
3593 (Fencode_char): Use INTEGER_TO_CONS.
3594 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3595 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3596 * data.c (long_to_cons, cons_to_long): Remove.
3597 (cons_to_unsigned, cons_to_signed): New functions.
3598 These signal an error for invalid or out-of-range values.
3599 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3600 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3601 * font.c (Ffont_variation_glyphs):
3602 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3603 * lisp.h: Include <intprops.h>.
3604 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3605 (cons_to_signed, cons_to_unsigned): New decls.
3606 (long_to_cons, cons_to_long): Remove decls.
3607 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3608 (Fprimitive_undo): Use CONS_TO_INTEGER.
3609 * xfns.c (Fx_window_property): Likewise.
3610 * xselect.c: Include <limits.h>.
3611 (x_own_selection, selection_data_to_lisp_data):
3612 Use INTEGER_TO_CONS.
3613 (x_handle_selection_request, x_handle_selection_clear)
3614 (x_get_foreign_selection, Fx_disown_selection_internal)
3615 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3616 (lisp_data_to_selection_data): Use cons_to_unsigned.
3617 (x_fill_property_data): Use cons_to_signed.
3618 Report values out of range.
3619
3620 Check for buffer and string overflow more precisely.
3621 * buffer.h (BUF_BYTES_MAX): New macro.
3622 * lisp.h (STRING_BYTES_MAX): New macro.
3623 * alloc.c (Fmake_string):
3624 * character.c (string_escape_byte8):
3625 * coding.c (coding_alloc_by_realloc):
3626 * doprnt.c (doprnt):
3627 * editfns.c (Fformat):
3628 * eval.c (verror):
3629 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3630 since they may not be the same number.
3631 * editfns.c (Finsert_char):
3632 * fileio.c (Finsert_file_contents):
3633 Likewise for BUF_BYTES_MAX.
3634
3635 * image.c: Use ptrdiff_t, not int, for sizes.
3636 (slurp_file): Switch from int to ptrdiff_t.
3637 All uses changed.
3638 (slurp_file): Check that file size fits in both size_t (for
3639 malloc) and ptrdiff_t (for sanity and safety).
3640
3641 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3642 if b->modtime has its maximal value.
3643
3644 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3645
3646 Don't assume time_t can fit into int.
3647 * buffer.h (struct buffer.modtime): Now time_t, not int.
3648 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3649 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3650
3651 Minor fixes for signed vs unsigned integers.
3652 * character.h (MAYBE_UNIFY_CHAR):
3653 * charset.c (maybe_unify_char):
3654 * keyboard.c (read_char, reorder_modifiers):
3655 XINT -> XFASTINT, since the integer must be nonnegative.
3656 * ftfont.c (ftfont_spec_pattern):
3657 * keymap.c (access_keymap, silly_event_symbol_error):
3658 XUINT -> XFASTINT, since the integer must be nonnegative.
3659 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3660 since it makes no difference and we prefer signed.
3661 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3662 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3663 nonnegative.
3664
3665 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3666
3667 * window.h (Fwindow_frame): Declare.
3668
3669 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3670
3671 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3672 (SPARE_MEMORY): Always define.
3673 (LARGE_REQUEST): Remove.
3674 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3675
3676 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3677
3678 * lisp.h: Move EXFUNS for Fframe_root_window,
3679 Fframe_first_window and Fset_frame_selected_window to window.h.
3680
3681 * window.h: Move EXFUNS for Fframe_root_window,
3682 Fframe_first_window and Fset_frame_selected_window here from
3683 lisp.h.
3684
3685 * frame.c (Fwindow_frame, Fframe_first_window)
3686 (Fframe_root_window, Fframe_selected_window)
3687 (Fset_frame_selected_window): Move to window.c.
3688 (Factive_minibuffer_window): Move to minibuf.c.
3689 (Fother_visible_frames_p): New function.
3690
3691 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3692
3693 * window.c (decode_window, decode_any_window): Move up in code.
3694 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3695 (inhibit_frame_unsplittable): Remove unused variable.
3696 (Fwindow_buffer): Move up and rewrite doc-string.
3697 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3698 (Fwindow_prev): New functions.
3699 (Fwindow_frame): Move here from frame.c. Accept any window as
3700 argument.
3701 (Fframe_root_window, Fframe_first_window)
3702 (Fframe_selected_window): Move here from frame.c. Accept frame
3703 or arbitrary window as argument. Update doc-strings.
3704 (Fminibuffer_window): Move up in code.
3705 (Fwindow_minibuffer_p): Move up in code and simplify.
3706 (Fset_frame_selected_window): Move here from frame.c.
3707 Marginal rewrite.
3708 (Fselected_window, select_window, Fselect_window): Move up in
3709 code. Minor doc-string fixes.
3710
3711 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3712
3713 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3714 Do not assume that spare memory exists; that assumption is valid
3715 only if SYSTEM_MALLOC.
3716 (LARGE_REQUEST): New macro, so that the issue of large requests
3717 is separated from the issue of spare memory.
3718
3719 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3720
3721 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3722 format. (Bug#8806)
3723
3724 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3725
3726 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3727 before statements.
3728
3729 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3730
3731 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3732
3733 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3734
3735 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3736 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3737
3738 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3739
3740 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3741
3742 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3743
3744 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3745 (x_clipboard_manager_save): Add return value.
3746 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3747 New error handlers.
3748 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3749 Obey Vx_select_enable_clipboard_manager. Catch errors in
3750 x_clipboard_manager_save (Bug#8779).
3751 (Vx_select_enable_clipboard_manager): New variable.
3752 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3753
3754 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3755
3756 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3757
3758 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3759
3760 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3761 in the current matrix if keep_current_p is non-zero.
3762
3763 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3764
3765 * bidi.c (bidi_level_of_next_char): Fix last change.
3766
3767 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3768
3769 Support bidi reordering of text covered by display properties.
3770
3771 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3772 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3773 (bidi_cache_search, bidi_cache_iterator_state)
3774 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3775 (bidi_level_of_next_char, bidi_move_to_visually_next):
3776 Support character positions inside a run of characters covered by a
3777 display string.
3778 (bidi_paragraph_init, bidi_resolve_explicit_1)
3779 (bidi_level_of_next_char): Call bidi_fetch_char and
3780 bidi_fetch_char_advance instead of FETCH_CHAR and
3781 FETCH_CHAR_ADVANCE.
3782 (bidi_init_it): Initialize new members.
3783 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3784 definitions.
3785 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3786 instead of using explicit *_CHAR codes.
3787 (bidi_resolve_explicit, bidi_resolve_weak):
3788 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3789 bidirectional text is supported only in multibyte buffers.
3790 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3791 it to initialize the frame_window_p member of struct bidi_it.
3792 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3793 (bidi_resolve_explicit, bidi_resolve_weak)
3794 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3795 bidi_it->nchars is non-positive.
3796 (bidi_level_of_next_char): Don't try to lookup the cache for the
3797 next/previous character if nothing is cached there yet, or if we
3798 were just reseat()'ed to a new position.
3799
3800 * xdisp.c (set_cursor_from_row): Set start and stop points
3801 according to the row's direction when priming the loop that looks
3802 for the glyph on which to display cursor.
3803 (single_display_spec_intangible_p): Function deleted.
3804 (display_prop_intangible_p): Reimplement to call
3805 handle_display_spec instead of single_display_spec_intangible_p.
3806 Accept 3 additional arguments needed by handle_display_spec.
3807 This fixes incorrect cursor motion across display property with complex
3808 values: lists, `(when COND...)' forms, etc.
3809 (single_display_spec_string_p): Support property values that are
3810 lists with the argument STRING its top-level element.
3811 (display_prop_string_p): Fix the condition for processing a
3812 property that is a list to be consistent with handle_display_spec.
3813 (handle_display_spec): New function, refactored from the
3814 last portion of handle_display_prop.
3815 (compute_display_string_pos): Accept additional argument
3816 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3817 value of a `display' property is a "replacing spec".
3818 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3819 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3820 the display property, but just return a value indicating whether
3821 the display property will replace the characters it covers.
3822 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3823 frame_window_p members of struct bidi_it.
3824 (compute_display_string_pos, compute_display_string_end):
3825 New functions.
3826 (push_it): Accept second argument POSITION, where pop_it should
3827 jump to continue iteration.
3828 (reseat_1): Initialize bidi_it.disp_pos.
3829
3830 * keyboard.c (adjust_point_for_property): Adjust the call to
3831 display_prop_intangible_p to its new signature.
3832
3833 * dispextern.h (struct bidi_it): New member frame_window_p.
3834 (bidi_init_it): Update prototypes.
3835 (display_prop_intangible_p): Update prototype.
3836 (compute_display_string_pos, compute_display_string_end):
3837 Declare prototypes.
3838 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3839 EMACS_INT.
3840
3841 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3842
3843 Malloc failure behavior now depends on size of allocation.
3844 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3845 * lisp.h: Change signatures accordingly.
3846 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3847 All callers changed. (Bug#8762)
3848
3849 * gnutls.c: Use Emacs's memory allocators.
3850 Without this change, the gnutls library would invoke malloc etc.
3851 directly, which causes problems on non-SYNC_INPUT hosts, and which
3852 runs afoul of improving memory_full behavior. (Bug#8761)
3853 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3854 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3855 xfree instead of the default malloc, realloc, free.
3856 (Fgnutls_boot): No need to check for memory allocation failure,
3857 since xmalloc does that for us.
3858
3859 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3860 * category.c (hash_get_category_set):
3861 * ccl.c (ccl_driver):
3862 * charset.c (Fdefine_charset_internal):
3863 * charset.h (struct charset.hash_index):
3864 * composite.c (get_composition_id, gstring_lookup_cache)
3865 (composition_gstring_put_cache):
3866 * composite.h (struct composition.hash_index):
3867 * dispextern.h (struct image.hash):
3868 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3869 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3870 (hashfn_equal, hashfn_user_defined, make_hash_table)
3871 (maybe_resize_hash_table, hash_lookup, hash_put)
3872 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3873 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3874 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3875 * image.c (make_image, search_image_cache, lookup_image)
3876 (xpm_put_color_table_h):
3877 * lisp.h (struct Lisp_Hash_Table):
3878 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3879 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3880 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3881 * alloc.c (allocate_vectorlike):
3882 Check for overflow in vector size calculations.
3883 * ccl.c (ccl_driver):
3884 Check for overflow when converting EMACS_INT to int.
3885 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3886 need to be updated by these changes.
3887 * fns.c (make_hash_table, maybe_resize_hash_table):
3888 Check for integer overflow with large hash tables.
3889 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3890 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3891 (SXHASH_REDUCE): New macro.
3892 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3893 Use it instead of discarding useful hash info with large hash values.
3894 (sxhash_float): New function.
3895 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3896 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3897 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3898 Rewrite to use FIXNUM_BITS, as this simplifies things.
3899 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3900 Adjust signatures to match updated version of code.
3901 (consing_since_gc): Now EMACS_INT, since a single hash table can
3902 use more than INT_MAX bytes.
3903
3904 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3905
3906 Make it possible to build with GCC-4.6+ -O2 -flto.
3907
3908 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3909
3910 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3911
3912 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3913 Call minibuffer-inactive-mode.
3914
3915 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3916
3917 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3918 Update dependencies.
3919
3920 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3921
3922 * data.c (init_data): Remove code for UTS, this system is not
3923 supported anymore.
3924
3925 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3926
3927 Don't force ./temacs to start in terminal mode.
3928
3929 * frame.c (make_initial_frame): Initialize faces in all cases, not
3930 only when CANNOT_DUMP is defined.
3931 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3932
3933 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3934
3935 * dispnew.c (add_window_display_history): Use const for the string
3936 pointer. Remove declaration, not needed.
3937
3938 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3939
3940 Use 'inline', not 'INLINE'.
3941 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3942 * alloc.c, fontset.c (INLINE): Remove.
3943 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3944 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3945 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3946 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3947 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3948
3949 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3950
3951 Make it possible to run ./temacs.
3952
3953 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3954 syms_of_callproc does the same thing. Remove test for
3955 "initialized", do it in the caller.
3956 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3957
3958 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3959
3960 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3961 (read_minibuf): Use get_minibuffer.
3962 (syms_of_minibuf): Use DEFSYM.
3963 (Qmetadata): New var.
3964 * data.c (Qbuffer): Don't make it static.
3965 (syms_of_data): Use DEFSYM.
3966
3967 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3968
3969 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3970 (CCL_CODE_MIN): New macro.
3971
3972 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3973
3974 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3975
3976 * eval.c (Qdebug): Now static.
3977 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3978 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3979 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3980
3981 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3982
3983 * image.c: Various fixes to ImageMagick code comments.
3984 (Fimagemagick_types): Doc fix.
3985
3986 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 Minor fixes prompted by GCC 4.6.0 warnings.
3989
3990 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3991
3992 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3993 (x_clipboard_manager_save_all): Move extern decl to ...
3994 * xterm.h: ... here, so that it can be checked for consistency.
3995
3996 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3997
3998 * xselect.c (x_clipboard_manager_save_frame)
3999 (x_clipboard_manager_save_all): New functions.
4000 (Fx_clipboard_manager_save): Lisp function deleted.
4001
4002 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4003 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4004
4005 * xterm.h: Update prototype.
4006
4007 2011-05-28 William Xu <william.xwl@gmail.com>
4008
4009 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4010 exiting (Bug#8239).
4011
4012 2011-05-28 Jim Meyering <meyering@redhat.com>
4013
4014 Avoid a sign-extension bug in crypto_hash_function.
4015 * fns.c (to_uchar): Define.
4016 (crypto_hash_function): Use it to convert some newly-signed
4017 variables to unsigned, to avoid sign-extension bugs. For example,
4018 without this change, (md5 "truc") would evaluate to
4019 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4020 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4021 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4022
4023 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4024
4025 Integer overflow fixes.
4026
4027 * dbusbind.c: Serial number integer overflow fixes.
4028 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4029 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4030 to hold a serial number that is too large for a fixnum.
4031 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4032 Check for serial numbers out of range. Decode any serial number
4033 that was so large that it became a float. (Bug#8722)
4034
4035 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4036 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4037 Use XFASTINT rather than XUINT when numbers are nonnegative.
4038 (xd_append_arg, Fdbus_method_return_internal):
4039 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4040 arguments, check that Lisp number is nonnegative, rather than
4041 silently wrapping negative numbers around. (Bug#8722)
4042 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4043 (Bug#8722)
4044
4045 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4046
4047 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4048
4049 ccl: add integer overflow checks
4050 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4051 (IN_INT_RANGE): New macros.
4052 (ccl_driver): Use them to check for integer overflow when
4053 decoding a CCL program. Many of the new checks are whether XINT (x)
4054 fits in int; it doesn't always, on 64-bit hosts. The new version
4055 doesn't catch all possible integer overflows, but it's an
4056 improvement. (Bug#8719)
4057
4058 * alloc.c (make_event_array): Use XINT, not XUINT.
4059 There's no need for unsigned here.
4060
4061 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4062 This follows up to the 2011-05-06 change that substituted uintptr_t
4063 for EMACS_INT. This case wasn't caught back then.
4064
4065 Rework Fformat to avoid integer overflow issues.
4066 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4067 now (part of C89). Include <verify.h>.
4068 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4069 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4070 (Fformat): Avoid the prepass trying to compute sizes; it was only
4071 approximate and thus did not catch overflow reliably. Instead, walk
4072 through the format just once, formatting and computing sizes as we go,
4073 checking for integer overflow at every step, and allocating a larger
4074 buffer as needed. Keep track separately whether the format is
4075 multibyte. Keep only the most-recently calculated precision, rather
4076 than them all. Record whether each argument has been converted to
4077 string. Use EMACS_INT, not int, for byte and char and arg counts.
4078 Support field widths and precisions larger than INT_MAX. Avoid
4079 sprintf's undefined behavior with conversion specifications such as %#d
4080 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4081 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4082 formatting out-of-range floating point numbers with int
4083 formats. (Bug#8668)
4084
4085 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4086
4087 * data.c: Avoid integer truncation in expressions involving floats.
4088 * data.c: Include <intprops.h>.
4089 (arith_driver): When there's an integer overflow in an expression
4090 involving floating point, convert the integers to floating point
4091 so that the resulting value does not suffer from catastrophic
4092 integer truncation. For example, on a 64-bit host (* 4
4093 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4094 Do not rely on undefined behavior after integer overflow.
4095
4096 merge count_size_as_multibyte, parse_str_to_multibyte
4097 * character.c, character.h (count_size_as_multibyte):
4098 Rename from parse_str_to_multibyte; all uses changed.
4099 Check for integer overflow.
4100 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4101 since it's now a duplicate of the other. This is more of
4102 a character than a buffer op, so better that it's in character.c.
4103 * fns.c, print.c: Adjust to above changes.
4104
4105 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4106
4107 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4108
4109 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4110
4111 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4112 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4113 (x_clipboard_manager_save): Now static.
4114 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4115
4116 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4117 (crypto_hash_function): Now static.
4118 Fix pointer signedness problems. Avoid unnecessary initializations.
4119
4120 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4121
4122 * termhooks.h (Vselection_alist): Make it terminal-local.
4123
4124 * terminal.c (create_terminal): Initialize it.
4125
4126 * xselect.c: Support for clipboard managers.
4127 (Vselection_alist): Move to termhooks.h as terminal-local var.
4128 (LOCAL_SELECTION): New macro.
4129 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4130 (symbol_to_x_atom): Remove gratuitous arg.
4131 (x_handle_selection_request, lisp_data_to_selection_data)
4132 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4133 (x_own_selection, x_get_local_selection, x_convert_selection):
4134 New arg, specifying work frame. Use terminal-local Vselection_alist.
4135 (some_frame_on_display): Delete unused function.
4136 (Fx_own_selection_internal, Fx_get_selection_internal)
4137 (Fx_disown_selection_internal, Fx_selection_owner_p)
4138 (Fx_selection_exists_p): New optional frame arg.
4139 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4140 (x_handle_selection_clear): Don't treat other terminals with the
4141 same keyboard specially. Use the terminal-local Vselection_alist.
4142 (x_clear_frame_selections): Use Frun_hook_with_args.
4143
4144 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4145
4146 * xterm.h: Add support for those atoms.
4147
4148 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4149
4150 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4151 (converted_selections, conversion_fail_tag): New global variables.
4152 (x_selection_request_lisp_error): Free the above.
4153 (x_get_local_selection): Remove unnecessary code.
4154 (x_reply_selection_request): Args changed; handle arbitrary array
4155 of converted selections stored in converted_selections.
4156 Separate the XChangeProperty and SelectionNotify steps.
4157 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4158 (x_convert_selection): New function.
4159 (x_handle_selection_event): Simplify.
4160 (x_get_foreign_selection): Don't ignore incoming requests while
4161 waiting for an answer; this will fail when we implement
4162 SAVE_TARGETS, and seems unnecessary anyway.
4163 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4164 (Vx_sent_selection_functions): Doc fix.
4165
4166 2011-05-26 Leo Liu <sdl.web@gmail.com>
4167
4168 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4169
4170 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4171
4172 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4173
4174 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4175 for fringe update if it has periodic bitmap.
4176 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4177 and fringe_bitmap_periodic_p.
4178
4179 * fringe.c (get_fringe_bitmap_data): New function.
4180 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4181 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4182 row. Mark glyph row for fringe update if periodicity changed.
4183
4184 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4185 for fringe update unless it has periodic bitmap.
4186
4187 2011-05-25 Kenichi Handa <handa@m17n.org>
4188
4189 * xdisp.c (get_next_display_element): Set correct it->face_id for
4190 a static composition.
4191
4192 2011-05-24 Leo Liu <sdl.web@gmail.com>
4193
4194 * deps.mk (fns.o):
4195 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4196
4197 * fns.c (crypto_hash_function, Fsha1): New function.
4198 (Fmd5): Use crypto_hash_function.
4199 (syms_of_fns): Add Ssha1.
4200
4201 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4202
4203 * gnutls.c: Remove unused macros.
4204 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4205 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4206 Remove macros that are defined and never used.
4207 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4208
4209 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4210
4211 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4212 (Fx_get_selection_internal): Minor cleanup.
4213 (Fx_own_selection_internal): Rename arguments for consistency with
4214 select.el.
4215
4216 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4217
4218 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4219
4220 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4221
4222 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4223
4224 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4225
4226 * dispnew.c (scrolling_window): Don't exclude the case that the
4227 last enabled row in the desired matrix touches the bottom boundary.
4228
4229 2011-05-21 Glenn Morris <rgm@gnu.org>
4230
4231 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4232 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4233 and add some more files.
4234
4235 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4236
4237 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4238 report_file_error introduced by the change from 2011-05-07.
4239
4240 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4241
4242 * systime.h (Time): Define only if emacs is defined.
4243 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4244 where the include path doesn't have X11/X.h by default. See
4245 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4246
4247 2011-05-20 Kenichi Handa <handa@m17n.org>
4248
4249 * composite.c (find_automatic_composition): Fix previous change.
4250
4251 2011-05-20 Glenn Morris <rgm@gnu.org>
4252
4253 * lisp.mk: New file, split from Makefile.in.
4254 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4255 (shortlisp): Remove.
4256 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4257
4258 2011-05-19 Glenn Morris <rgm@gnu.org>
4259
4260 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4261 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4262 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4263 (lisp): Set the order to that of loadup.el.
4264 (shortlisp): Make it a copy of $lisp.
4265 (SOME_MACHINE_LISP): Remove.
4266 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4267 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4268
4269 2011-05-18 Kenichi Handa <handa@m17n.org>
4270
4271 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4272 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4273 (find_automatic_composition): Mostly rewrite for efficiency.
4274
4275 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4276
4277 * makefile.w32-in: Update dependencies.
4278
4279 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4280
4281 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4282 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4283
4284 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4285
4286 Fix some integer overflow issues, such as string length overflow.
4287
4288 * insdel.c (count_size_as_multibyte): Check for string overflow.
4289
4290 * character.c (lisp_string_width): Check for string overflow.
4291 Use EMACS_INT, not int, for string indexes and lengths; in
4292 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4293 the resulting string length overflows an EMACS_INT; instead,
4294 report a string overflow if no precision given. When checking for
4295 precision exhaustion, use a check that cannot possibly have
4296 integer overflow. (Bug#8675)
4297 * character.h (lisp_string_width): Adjust to new signature.
4298
4299 * alloc.c (string_overflow): New function.
4300 (Fmake_string): Use it. This doesn't change behavior, but saves
4301 a few bytes and will simplify future changes.
4302 * character.c (string_escape_byte8): Likewise.
4303 * lisp.h (string_overflow): New decl.
4304
4305 Fixups, following up to the user-interface timestamp change.
4306 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4307 for UI timestamps, instead of unsigned long.
4308 * msdos.c (mouse_get_pos): Likewise.
4309 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4310 * w32gui.h (Time): Define by including "systime.h" rather than by
4311 declaring it ourselves. (Bug#8664)
4312
4313 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4314 * image.c (clear_image_cache): Likewise.
4315
4316 * term.c (term_mouse_position): Don't assume time_t wraparound.
4317
4318 Be more systematic about user-interface timestamps.
4319 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4320 and sometimes 'EMACS_UINT', to represent these timestamps.
4321 This change causes it to use 'Time' uniformly, as that's what X uses.
4322 This makes the code easier to follow, and makes it easier to catch
4323 integer overflow bugs such as Bug#8664.
4324 * frame.c (Fmouse_position, Fmouse_pixel_position):
4325 Use Time, not unsigned long, for user-interface timestamps.
4326 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4327 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4328 * keyboard.h (last_event_timestamp): Likewise.
4329 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4330 * menu.h (xmenu_show): Likewise.
4331 * term.c (term_mouse_position): Likewise.
4332 * termhooks.h (struct input_event.timestamp): Likewise.
4333 (struct terminal.mouse_position_hook): Likewise.
4334 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4335 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4336 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4337 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4338 what it was before.
4339 * menu.h, termhooks.h: Include "systime.h", for Time.
4340
4341 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4342 Don't assume that the difference between two unsigned long values
4343 can fit into an integer. At this point, we know button_down_time
4344 <= event->timestamp, so the difference must be nonnegative, so
4345 there's no need to cast the result if double-click-time is
4346 nonnegative, as it should be; check that it's nonnegative, just in
4347 case. This bug is triggered when events are more than 2**31 ms
4348 apart (about 25 days). (Bug#8664)
4349
4350 * xselect.c (last_event_timestamp): Remove duplicate decl.
4351 (x_own_selection): Remove needless cast to unsigned long.
4352
4353 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4354 that always fit in int. Use a sentinel instead of a counter, to
4355 avoid a temp and to allay GCC's concerns about possible int overflow.
4356 * frame.h (struct frame): Use int for menu_bar_items_used
4357 instead of EMACS_INT, since it always fits in int.
4358
4359 * menu.c (grow_menu_items): Check for int overflow.
4360
4361 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4362
4363 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4364 Before, the code was not consistent. These values cannot exceed
4365 2**31 - 1 so there's no need to make them unsigned.
4366 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4367 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4368 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4369 as modifiers.
4370 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4371
4372 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4373 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4374 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4375 presumably because the widths might not match.
4376
4377 * window.c (size_window): Avoid needless test at loop start.
4378
4379 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4380
4381 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4382
4383 2011-05-12 Drew Adams <drew.adams@oracle.com>
4384
4385 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4386
4387 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4388
4389 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4390 `width' to `bar_area_x' and `bar_area_width', respectively.
4391 (x_scroll_run): Take account of fringe background extension.
4392
4393 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4394 Rename local vars `left' and `width' to `bar_area_x' and
4395 `bar_area_width', respectively.
4396 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4397 background extension.
4398
4399 2011-05-10 Jim Meyering <meyering@redhat.com>
4400
4401 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4402
4403 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4404
4405 * image.c (Finit_image_library): Return t for built-in image types,
4406 like pbm and xbm. (Bug#8640)
4407
4408 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4409
4410 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4411
4412 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4413
4414 * w32console.c (Fset_screen_color): Doc fix.
4415 (Fget_screen_color): New function.
4416 (syms_of_ntterm): Defsubr it.
4417
4418 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4419 unlink the temporary file if Fcall_process didn't create it in the
4420 first place.
4421 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4422 child process will be redirected to a file specified with `:file'.
4423 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4424 cue to call_process_cleanup not to close that handle.
4425
4426 2011-05-07 Ben Key <bkey76@gmail.com>
4427
4428 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4429 one of two shell specific rules, either bootstrap-temacs-CMD or
4430 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4431 to the previous implementation of the bootstrap-temacs rule.
4432 The bootstrap-temacs-CMD rule is similar to the previous
4433 implementation of the bootstrap-temacs rule except that it
4434 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4435 variable.
4436
4437 These changes, along with some changes to nt/configure.bat,
4438 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4439 earlier fix to add support for --cflags and --ldflags options
4440 that include quotes so that it works whether make uses cmd or
4441 sh as the shell.
4442
4443 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4444
4445 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4446 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4447 is a constant.
4448 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4449 a string. Handle both cases.
4450 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4451 (Fdbus_register_method): Use Qinvalid_function.
4452
4453 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4454
4455 * makefile.w32-in: Update dependencies.
4456 (LISP_H): Add inttypes.h and stdin.h.
4457 (PROCESS_H): Add unistd.h.
4458
4459 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4460
4461 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4462 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4463
4464 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4465
4466 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4467
4468 * term.c (vfatal): Remove stray call to va_end.
4469 It's not needed and the C Standard doesn't allow it here anyway.
4470
4471 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4472 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4473
4474 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4475 bytes.
4476
4477 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4478
4479 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4480
4481 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4482
4483 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4484
4485 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4486
4487 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4488 * charset.c (Fdefine_charset_internal): Don't initialize
4489 charset.code_space[15]. The value was garbage, on hosts with
4490 32-bit int (Bug#8600).
4491
4492 * lread.c (read_integer): Be more consistent with string-to-number.
4493 Use string_to_number to do the actual conversion; this avoids
4494 rounding errors and fixes some other screwups. Without this fix,
4495 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4496 (digit_to_number): Move earlier, for benefit of read_integer.
4497 Return -1 if the digit is out of range for the base, -2 if it is
4498 not a digit in any supported base. (Bug#8602)
4499
4500 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4501
4502 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4503 to match comment at start of function. This also removes a
4504 GCC warning about overflow in a 32+64-bit port.
4505
4506 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4507
4508 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4509 Reported by Stefan Monnier in
4510 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4511 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4512 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4513
4514 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4515 (EMACS_UINTPTR): Likewise, with uintptr_t.
4516
4517 * lisp.h: Prefer 64-bit EMACS_INT if available.
4518 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4519 on 32-bit hosts that have 64-bit int, so that they can access
4520 large files.
4521 However, temporarily disable this change unless the temporary
4522 symbol WIDE_EMACS_INT is defined.
4523
4524 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4525
4526 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4527 This removes an assumption that EMACS_INT and long are the same
4528 width as pointers. The assumption is true for Emacs porting targets
4529 now, but we want to make other targets possible.
4530 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4531 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4532 In the rest of the code, change types of integers that hold casted
4533 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4534 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4535 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4536 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4537 No need to cast type when ORing.
4538 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4539 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4540 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4541 assume EMACS_INT is the same width as char *.
4542 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4543 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4544 Remove no-longer-needed casts.
4545 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4546 (xg_tool_bar_help_callback, xg_make_tool_item):
4547 Use EMACS_INTPTR to hold an integer
4548 that will be cast to void *; this can avoid a GCC warning
4549 if EMACS_INT is not the same width as void *.
4550 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4551 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4552 (current_message_1, set_message_1):
4553 Use a local to convert to proper width without a cast.
4554 * xmenu.c (dialog_selection_callback): Likewise.
4555
4556 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4557 Also, don't assume VALBITS / RAND_BITS is less than 5,
4558 and don't rely on undefined behavior when shifting a 1 left into
4559 the sign bit.
4560 * lisp.h (get_random): Change signature to match.
4561
4562 * lread.c (hash_string): Use size_t, not int, for hash computation.
4563 Normally we prefer signed values; but hashing is special, because
4564 it's better to use unsigned division on hash table sizes so that
4565 the remainder is nonnegative. Also, size_t is the natural width
4566 for hashing into memory. The previous code used 'int', which doesn't
4567 retain enough info to hash well into very large tables.
4568 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4569
4570 * dbusbind.c: Don't possibly lose pointer info when converting.
4571 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4572 Use XPNTR rather than XHASH, so that the high-order bits of
4573 the pointer aren't lost when converting through void *.
4574
4575 * eval.c (Fautoload): Don't double-shift a pointer.
4576
4577 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4578
4579 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4580
4581 * gnutls.c (DEF_GNUTLS_FN):
4582 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4583
4584 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4585
4586 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4587 marker. (Bug#8610)
4588
4589 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4590
4591 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4592 New version that can reserve upto 2GB of heap space.
4593
4594 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4595
4596 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4597
4598 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4599
4600 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4601 `gnutls_certificate_set_x509_key_file'.
4602
4603 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4604
4605 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4606 Update dependencies.
4607
4608 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4609
4610 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4611 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4612 Remove unused parameter `fildes'.
4613 * process.c (read_process_output, send_process): Don't pass it.
4614
4615 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4616
4617 Fix previous change: the library cache is defined in w32.c.
4618 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4619 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4620
4621 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4622
4623 Implement dynamic loading of GnuTLS on Windows.
4624
4625 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4626 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4627 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4628 Declare.
4629
4630 * gnutls.c (Qgnutls_dll): Define.
4631 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4632 (gnutls_*): Declare function pointers.
4633 (init_gnutls_functions): New function to initialize function pointers.
4634 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4635 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4636 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4637 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4638 (emacs_gnutls_write, emacs_gnutls_read)
4639 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4640 (Fgnutls_available_p): New function.
4641 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4642 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4643 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4644
4645 * image.c: Include w32.h.
4646 (Vimage_type_cache): Delete.
4647 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4648 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4649 (w32_delayed_load): Move to w32.c.
4650
4651 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4652
4653 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4654 (w32_delayed_load): Move from image.c. When loading a library, record
4655 its filename in the :loaded-from property of the library id.
4656 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4657 Initialize and staticpro them.
4658 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4659
4660 * process.c: Include lisp.h before w32.h, not after.
4661 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4662 instead of gnutls_record_check_pending.
4663
4664 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4665
4666 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4667
4668 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4669 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4670 as passed in.
4671
4672 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4673
4674 * xterm.c (x_set_frame_alpha): Do not set property on anything
4675 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4676
4677 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4678
4679 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4680
4681 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4682
4683 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4684 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4685 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4686 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4687 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4688 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4689 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4690 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4691 (Qgnutls_bootprop_callbacks_verify): Make static.
4692
4693 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4694
4695 * callproc.c: Indentation fixup.
4696
4697 * sysdep.c (wait_for_termination_1): Make static.
4698 (wait_for_termination, interruptible_wait_for_termination):
4699 Move after wait_for_termination_1.
4700
4701 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4702
4703 * sysdep.c (interruptible_wait_for_termination): New function
4704 which is like wait_for_termination, but allows keyboard
4705 interruptions.
4706
4707 * callproc.c (Fcall_process): Add (:file "file") as an option for
4708 the STDOUT buffer.
4709 (Fcall_process_region): Ditto.
4710
4711 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4712
4713 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4714 rather than `XVECTOR (FOO)->size'.
4715
4716 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4717 inttypes.h, as a gnulib replacement is used if it not available in
4718 system headers.
4719
4720 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4721
4722 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4723 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4724 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4725
4726 * coding.c (coding_alloc_by_realloc): Error out if destination
4727 will grow beyond MOST_POSITIVE_FIXNUM.
4728 (decode_coding_emacs_mule): Abort if there isn't enough place in
4729 charbuf for the composition carryover bytes. Reserve an extra
4730 space for up to 2 characters produced in a loop.
4731 (decode_coding_iso_2022): Abort if there isn't enough place in
4732 charbuf for the composition carryover bytes.
4733
4734 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4735
4736 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4737 aborting when %lld or %lll format is passed.
4738 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4739 %llo or %llx format is passed. (Bug#8545)
4740
4741 * window.c (window_scroll_line_based): Use a marker instead of
4742 simple variables to record original value of point. (Bug#7952)
4743
4744 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4745 produced by %s or %c overflows available buffer space. (Bug#8545)
4746
4747 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4748
4749 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4750 (SIZE_MAX): Move defn after all includes, as they might #define it.
4751
4752 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4753
4754 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4755
4756 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4757
4758 * keyboard.c (Qdelayed_warnings_hook): Define.
4759 (command_loop_1): Run `delayed-warnings-hook'
4760 if Vdelayed_warnings_list is non-nil.
4761 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4762 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4763
4764 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4765
4766 * doprnt.c (doprnt): Don't return value smaller than the buffer
4767 size if the message was truncated. (Bug#8545).
4768
4769 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4770
4771 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4772 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4773
4774 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4775
4776 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4777
4778 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4779
4780 * makefile.w32-in: Update dependencies.
4781
4782 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4783
4784 Improve `doprnt' and its usage. (Bug#8545)
4785 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4786 `format_end'. Remove support for %l as a conversion specifier.
4787 Don't use xrealloc. Improve diagnostics when the %l size modifier
4788 is used. Update the commentary.
4789
4790 * eval.c (verror): Simplify calculation of size_t.
4791
4792 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4793 messages.
4794
4795 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4796
4797 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4798 change.
4799
4800 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4801
4802 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4803 This makes this file independent of the recent pseudovector change.
4804
4805 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4806
4807 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4808
4809 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4810 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4811 Remove unused local.
4812 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4813
4814 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4815 GCC 4.6.0 optimizes based on type-based alias analysis.
4816 For example, if b is of type struct buffer * and v of type struct
4817 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4818 != &v->size, and therefore "v->size = 1; b->size = 2; return
4819 v->size;" must therefore return 1. This assumption is incorrect
4820 for Emacs, since it type-puns struct Lisp_Vector * with many other
4821 types. To fix this problem, this patch adds a new type struct
4822 vectorlike_header that documents the constraints on layout of vectors
4823 and pseudovectors, and helps optimizing compilers not get fooled
4824 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4825 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4826 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4827 the size member.
4828 (XSETPVECTYPE): Rewrite in terms of new macro.
4829 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4830 This is a bit clearer, and further avoids the possibility of
4831 undesirable aliasing.
4832 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4833 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4834 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4835 since Lisp_Subr is a special case (no "next" field).
4836 (ASIZE): Now uses header.size rather than size.
4837 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4838 to avoid the hassle of writing XVECTOR (foo)->header.size.
4839 (struct vectorlike_header): New type.
4840 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4841 object, to help avoid aliasing.
4842 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4843 (SUBRP): Likewise, since Lisp_Subr is a special case.
4844 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4845 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4846 (struct Lisp_Hash_Table): Combine first two members into a single
4847 struct vectorlike_header member. All uses of "size" and "next" members
4848 changed to be "header.size" and "header.next".
4849 * buffer.h (struct buffer): Likewise.
4850 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4851 * frame.h (struct frame): Likewise.
4852 * process.h (struct Lisp_Process): Likewise.
4853 * termhooks.h (struct terminal): Likewise.
4854 * window.c (struct save_window_data, struct saved_window): Likewise.
4855 * window.h (struct window): Likewise.
4856 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4857 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4858 * buffer.c (init_buffer_once): Likewise.
4859 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4860 special case.
4861 * process.c (Fformat_network_address): Use local var for size,
4862 for brevity.
4863
4864 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4865
4866 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4867 * data.c (atof): Remove decl; no longer used or needed.
4868 (digit_to_number): Move to lread.c.
4869 (Fstring_to_number): Use new string_to_number function, to be
4870 consistent with how the Lisp reader treats infinities and NaNs.
4871 Do not assume that floating-point numbers represent EMACS_INT
4872 without losing information; this is not true on most 64-bit hosts.
4873 Avoid double-rounding errors, by insisting on integers when
4874 parsing non-base-10 numbers, as the documentation specifies.
4875 * lisp.h (string_to_number): New decl, replacing ...
4876 (isfloat_string): Remove.
4877 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4878 (read1): Do not accept +. and -. as integers; this
4879 appears to have been a coding error. Similarly, do not accept
4880 strings like +-1e0 as floating point numbers. Do not report
4881 overflow for integer overflows unless the base is not 10 which
4882 means we have no simple and reliable way to continue.
4883 Break out the floating-point parsing into a new
4884 function string_to_number, so that Fstring_to_number parses
4885 floating point numbers consistently with the Lisp reader.
4886 (digit_to_number): Move here from data.c. Make it static inline.
4887 (E_CHAR, EXP_INT): Remove, replacing with ...
4888 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4889 (string_to_number): New function, replacing isfloat_string.
4890 This function checks for valid syntax and produces the resulting
4891 Lisp float number too. Rework it so that string-to-number
4892 no longer mishandles examples like "1.0e+". Use strtoumax,
4893 so that overflow for non-base-10 numbers is reported only when
4894 there's no portable and simple way to convert to floating point.
4895
4896 * textprop.c (set_text_properties_1): Rewrite for clarity,
4897 and to avoid GCC warning about integer overflow.
4898
4899 * intervals.h (struct interval): Use EMACS_INT for members
4900 where EMACS_UINT might cause problems. See
4901 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4902 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4903 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4904 All uses changed.
4905 (offset_intervals): Tell GCC not to worry about length overflow
4906 when negating a negative length.
4907
4908 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4909 (overrun_check_free): Likewise.
4910
4911 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4912 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4913 word size.
4914
4915 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4916 (gnutls_make_error): Rename local to avoid shadowing.
4917 (gnutls_emacs_global_deinit): ifdef out; not used.
4918 (Fgnutls_boot): Use const for pointer to readonly storage.
4919 Comment out unused local. Fix pointer signedness problems.
4920
4921 * lread.c (openp): Don't stuff size_t into an 'int'.
4922 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4923 about possible signed overflow.
4924
4925 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4926 (GDK_KEY_g): Don't define if already defined.
4927 (xg_prepare_tooltip): Avoid pointer signedness problem.
4928 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4929
4930 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4931 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4932
4933 * xfns.c (Fx_window_property): Simplify a bit,
4934 to make a bit faster and to avoid GCC 4.6.0 warning.
4935 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4936
4937 * fns.c (internal_equal): Don't assume size_t fits in int.
4938
4939 * alloc.c (compact_small_strings): Tighten assertion a little.
4940
4941 Replace pEd with more-general pI, and fix some printf arg casts.
4942 * lisp.h (pI): New macro, generalizing old pEd macro to other
4943 conversion specifiers. For example, use "...%"pI"d..." rather
4944 than "...%"pEd"...".
4945 (pEd): Remove. All uses replaced with similar uses of pI.
4946 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4947 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4948 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4949 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4950 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4951 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4952 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4953 64-bit hosts.
4954 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4955 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4956 * print.c (safe_debug_print, print_object): Likewise.
4957 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4958 to int.
4959 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4960 avoiding the 0 flag, which is not portable.
4961 * process.c (Fmake_network_process): Use pI to avoid cast.
4962 * region-cache.c (pp_cache): Likewise.
4963 * xdisp.c (decode_mode_spec): Likewise.
4964 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4965 behavior on 64-bit hosts with printf arg.
4966 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4967 (x_stop_queuing_selection_requests): Likewise.
4968 (x_get_window_property): Don't truncate byte count to an 'int'
4969 when tracing.
4970
4971 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4972 here, since it parses constructs like leading '-' and spaces,
4973 which are not wanted; and it overflows with large numbers.
4974 Instead, simply match F[0-9]+, which is what is wanted anyway.
4975
4976 * alloc.c: Remove unportable assumptions about struct layout.
4977 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4978 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4979 (allocate_vectorlike, make_pure_vector): Use the new macros,
4980 plus offsetof, to remove unportable assumptions about struct layout.
4981 These assumptions hold on all porting targets that I know of, but
4982 they are not guaranteed, they're easy to remove, and removing them
4983 makes further changes easier.
4984
4985 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4986 This doesn't fix a bug but makes the code clearer.
4987 (string_overrun_cookie): Now const. Use initializers that
4988 don't formally overflow signed char, to avoid warnings.
4989 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4990 can cause Emacs to crash when string overrun checking is enabled.
4991 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4992 multiple of sizeof (EMACS_INT); it need not be, if
4993 alignof(EMACS_INT) < sizeof (EMACS_INT).
4994 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4995
4996 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4997
4998 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4999
5000 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5001
5002 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5003 supposed to be handshaking. (Bug#8556)
5004 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5005
5006 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5007
5008 * lisp.h (Qdebug): List symbol.
5009 * eval.c (Qdebug): Restore global linkage.
5010 * keyboard.c (debug-on-event): New variable.
5011 (handle_user_signal): Break into debugger when debug-on-event
5012 matches the current signal symbol.
5013
5014 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5015
5016 * alloc.c (check_sblock, check_string_bytes)
5017 (check_string_free_list): Convert to standard C.
5018
5019 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5020
5021 * w32.c (emacs_gnutls_push): Fix typo.
5022
5023 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5024
5025 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5026 "cast to pointer from integer of different size".
5027
5028 Improve doprnt and its use in verror. (Bug#8545)
5029 * doprnt.c (doprnt): Document the set of format control sequences
5030 supported by the function. Use SAFE_ALLOCA instead of always
5031 using `alloca'.
5032
5033 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5034 is one byte too soon. Don't use xrealloc; instead xfree and
5035 xmalloc anew.
5036
5037 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5038
5039 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5040 callbacks stage.
5041
5042 * gnutls.c: Renamed global_initialized to
5043 gnutls_global_initialized. Added internals for the
5044 :verify-hostname-error, :verify-error, and :verify-flags
5045 parameters of `gnutls-boot' and documented those parameters in the
5046 docstring. Start callback support.
5047 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5048 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5049 on error. Return error code.
5050 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5051 (emacs_gnutls_read): Likewise.
5052 (Fgnutls_boot): Return handshake error code.
5053 (emacs_gnutls_handle_error): New function.
5054 (wsaerror_to_errno): Likewise.
5055
5056 * w32.h (emacs_gnutls_pull): Add prototype.
5057 (emacs_gnutls_push): Likewise.
5058
5059 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5060 (emacs_gnutls_push): Likewise.
5061
5062 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5063
5064 * process.c (wait_reading_process_output): Check if GnuTLS
5065 buffered some data internally if no FDs are set for TLS
5066 connections.
5067
5068 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5069 (LIBS): Link to USER_LIBS.
5070 ($(BLD)/gnutls.$(0)): New target.
5071
5072 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5073
5074 * xdisp.c (handle_single_display_spec): Rename the
5075 display_replaced_before_p argument into display_replaced_p, to
5076 make it consistent with the commentary. Fix typos in the
5077 commentary.
5078
5079 * textprop.c (syms_of_textprop): Remove dead code.
5080 (copy_text_properties): Delete obsolete commentary about an
5081 interface that was deleted long ago. Fix typos in the description
5082 of arguments.
5083
5084 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5085 to changes in oldXMenu/XMenu.h from 2011-04-16.
5086 <menu_help_message, prev_menu_help_message>: Constify.
5087 (IT_menu_make_room): menu->help_text is now `const char **';
5088 adjust.
5089
5090 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5091 to changes in oldXMenu/XMenu.h from 2011-04-16.
5092 (struct XMenu): Declare `help_text' `const char **'.
5093
5094 * xfaces.c <Qunspecified>: Make extern again.
5095
5096 * syntax.c: Include sys/types.h before including regex.h, as
5097 required by Posix.
5098
5099 * doc.c (get_doc_string): Improve the format passed to `error'.
5100
5101 * doprnt.c (doprnt): Improve commentary.
5102
5103 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5104
5105 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5106 them with etags.
5107
5108 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5109 changes in globals.h immediately force recompilation.
5110 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5111 $(CURDIR)/s/ms-w32.h.
5112 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5113
5114 * character.c (Fchar_direction): Function deleted.
5115 (syms_of_character): Don't defsubr it.
5116 <char-direction-table>: Deleted.
5117
5118 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5119
5120 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5121 * doprnt.c: Include limits.h.
5122 (SIZE_MAX): New macro.
5123 (doprnt): Return a size_t value. 2nd arg is now size_t.
5124 Many local variables are now size_t instead of int or unsigned.
5125 Improve overflow protection. Support `l' modifier for integer
5126 conversions. Support %l conversion. Don't assume an EMACS_INT
5127 argument for integer conversions and for %c.
5128
5129 * lisp.h (doprnt): Restore prototype.
5130
5131 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5132 $(SRC)/character.h.
5133
5134 * Makefile.in (base_obj): Add back doprnt.o.
5135
5136 * deps.mk (doprnt.o): Add back prerequisites.
5137 (callint.o): Depend on character.h.
5138
5139 * eval.c (internal_lisp_condition_case): Include the handler
5140 representation in the error message.
5141 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5142 when breaking from the loop.
5143
5144 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5145
5146 * callint.c (Fcall_interactively): When displaying error message
5147 about invalid control letter, pass the character's codepoint, not
5148 a pointer to its multibyte form. Improve display of the character
5149 in octal and display also its hex code.
5150
5151 * character.c (char_string): Use %x to display the (unsigned)
5152 codepoint of an invalid character, to avoid displaying a bogus
5153 negative value.
5154
5155 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5156 `error', not SYMBOL_NAME itself.
5157
5158 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5159 character arguments to `error'.
5160
5161 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5162 to `error' in error message about FINAL_CHAR argument. Make sure
5163 FINAL_CHAR is a character, and use %c when it is passed as
5164 argument to `error'.
5165
5166 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5167
5168 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5169
5170 * w32.c: Include <time.h>.
5171 (sys_localtime): New function.
5172
5173 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5174
5175 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5176
5177 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5178
5179 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5180
5181 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5182 zombies (Bug#8467).
5183
5184 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5185
5186 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5187 gl_state.e_property when gl_state.object is Qt.
5188
5189 * insdel.c (make_gap_larger): Remove limitation of buffer size
5190 to <= INT_MAX.
5191
5192 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5193
5194 * xdisp.c (lookup_glyphless_char_display)
5195 (produce_glyphless_glyph): Handle cons cell entry in
5196 glyphless-char-display.
5197 (Vglyphless_char_display): Document it.
5198
5199 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5200 glyphless-char-display.
5201
5202 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5203
5204 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5205
5206 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5207
5208 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5209 definition for no-X builds.
5210
5211 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5212
5213 Static checks with GCC 4.6.0 and non-default toolkits.
5214
5215 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5216
5217 * process.c (keyboard_bit_set): Define only if SIGIO.
5218 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5219 (send_process): Repair possible setjmp clobbering.
5220
5221 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5222
5223 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5224
5225 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5226
5227 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5228 Define only if needed.
5229
5230 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5231 by pacifying GCC about it. Maybe it's time to retire it?
5232 * xfaces.c (USG, __TIMEVAL__): Likewise.
5233
5234 * dispextern.h (struct redisplay_interface): Rename param
5235 to avoid shadowing.
5236 * termhooks.h (struct terminal): Likewise.
5237 * xterm.c (xembed_send_message): Likewise.
5238
5239 * insdel.c (make_gap_smaller): Define only if
5240 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5241
5242 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5243 it.
5244
5245 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5246 so that we aren't warned about unused symbols.
5247
5248 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5249
5250 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5251
5252 * xfns.c (x_real_positions): Mark locals as initialized.
5253
5254 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5255
5256 * xterm.c: Fix problems found by static analysis with other toolkits.
5257 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5258 (x_dispatch_event): Declare static if USE_GTK, and
5259 define if USE_GTK || USE_X_TOOLKIT.
5260 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5261 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5262 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5263 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5264
5265 * xmenu.c (menu_help_callback): Pointer type fixes.
5266 Use const pointers when pointing at readonly data. Avoid pointer
5267 signedness clashes.
5268 (FALSE): Remove unused macro.
5269 (update_frame_menubar): Remove unused decl.
5270
5271 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5272
5273 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5274 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5275 (single_menu_item): Rename local to avoid shadowing.
5276
5277 * keyboard.c (make_lispy_event): Remove unused local var.
5278
5279 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5280 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5281
5282 * bitmaps: Change bitmaps from unsigned char back to the X11
5283 compatible char. Avoid the old compiler warnings about
5284 out-of-range initializers by using, for example, '\xab' rather
5285 than 0xab.
5286
5287 * xgselect.c (xgselect_initialize): Check vs interface
5288 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5289
5290 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5291
5292 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5293 to read-only memory.
5294
5295 * fns.c (vector): Remove; this old hack is no longer needed.
5296
5297 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5298 Remove unused var.
5299 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5300
5301 * xrdb.c (x_load_resources): Omit unused local.
5302
5303 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5304 (x_window): Rename locals to avoid shadowing.
5305 (USG): Use the kludged USG macro, to pacify gcc.
5306
5307 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5308 (x_term_init): Remove local to avoid shadowing.
5309
5310 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5311
5312 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5313 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5314
5315 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5316
5317 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5318
5319 Fix regex.c, syntax.c and friends for buffers > 2GB.
5320 * syntax.h (struct gl_state_s): Declare character position members
5321 EMACS_INT.
5322
5323 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5324
5325 * textprop.c (verify_interval_modification, interval_of):
5326 Declare arguments EMACS_INT.
5327
5328 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5329 EMACS_INT.
5330
5331 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5332
5333 * indent.c (Fvertical_motion): Local variable it_start is now
5334 EMACS_INT.
5335
5336 * regex.c (re_match, re_match_2, re_match_2_internal)
5337 (bcmp_translate, regcomp, regexec, print_double_string)
5338 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5339 (re_compile_pattern, re_exec): Declare arguments and local
5340 variables `size_t' and `ssize_t' and return values `regoff_t', as
5341 appropriate.
5342 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5343 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5344 <compile_stack_type>: `size' and `avail' are now `size_t'.
5345
5346 * regex.h <regoff_t>: Use ssize_t, not int.
5347 (re_search, re_search_2, re_match, re_match_2): Arguments that
5348 specify buffer/string position and length are now ssize_t and
5349 size_t. Return type is regoff_t.
5350
5351 2011-04-16 Ben Key <bkey76@gmail.com>
5352
5353 * nsfont.m: Fixed bugs in ns_get_family and
5354 ns_descriptor_to_entity that were caused by using free to
5355 deallocate memory blocks that were allocated by xmalloc (via
5356 xstrdup). This caused Emacs to crash when compiled with
5357 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5358 --enable-checking=xmallocoverrun). xfree is now used to
5359 deallocate these memory blocks.
5360
5361 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5362
5363 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5364
5365 emacs_write: Accept and return EMACS_INT for sizes.
5366 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5367 et seq.
5368 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5369 Accept and return EMACS_INT.
5370 (emacs_gnutls_write): Return the number of bytes written on
5371 partial writes.
5372 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5373 (emacs_read, emacs_write): Remove check for negative size, as the
5374 Emacs source code has been audited now.
5375 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5376 (emacs_read, emacs_write): Use it.
5377 * process.c (send_process): Adjust to the new signatures of
5378 emacs_write and emacs_gnutls_write. Do not attempt to store
5379 a byte offset into an 'int'; it might overflow.
5380 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5381
5382 * sound.c: Don't assume sizes fit in 'int'.
5383 (struct sound_device.period_size, alsa_period_size):
5384 Return EMACS_INT, not int.
5385 (struct sound_device.write, vox_write, alsa_write):
5386 Accept EMACS_INT, not int.
5387 (wav_play, au_play): Use EMACS_INT to store sizes and to
5388 record read return values.
5389
5390 2011-04-15 Ben Key <bkey76@gmail.com>
5391
5392 * keyboard.c (Qundefined): Don't declare static since it is used
5393 in nsfns.m.
5394 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5395 static since they are used in nsfont.m.
5396
5397 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5398
5399 * process.c (Qprocessp): Don't declare static.
5400 * lisp.h (Qprocessp): Declare again.
5401
5402 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5403
5404 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5405
5406 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5407
5408 Improve C-level modularity by making more things 'static'.
5409
5410 Don't publish debugger-only interfaces to other modules.
5411 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5412 (verify_bytepos, count_markers): Move decls to the only modules
5413 that need them.
5414 * region-cache.h (pp_cache): Likewise.
5415 * window.h (check_all_windows): Likewise.
5416 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5417
5418 * sysdep.c (croak): Now static, if
5419 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5420 * syssignal.h (croak): Declare only if not static.
5421
5422 * alloc.c (refill_memory_reserve): Now static if
5423 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5424 * lisp.h (refill_memory_reserve): Declare only if not static.
5425
5426 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5427 Define only if USE_LUCID.
5428
5429 * xrdb.c (x_customization_string, x_rm_string): Now static.
5430
5431 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5432 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5433
5434 * xdisp.c (draw_row_with_mouse_face): Now static.
5435 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5436
5437 * window.h (check_all_windows): Mark externally visible.
5438
5439 * window.c (window_deletion_count): Now static.
5440
5441 * undo.c: Make symbols static if they're not exported.
5442 (last_undo_buffer, last_boundary_position, pending_boundary):
5443 Now static.
5444
5445 * textprop.c (interval_insert_behind_hooks): Now static.
5446 (interval_insert_in_front_hooks): Likewise.
5447
5448 * term.c: Make symbols static if they're not exported.
5449 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5450 (max_frame_lines, tty_set_terminal_modes):
5451 (tty_reset_terminal_modes, tty_turn_off_highlight):
5452 (get_tty_terminal): Now static.
5453 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5454 * termhooks.h (term_mouse_moveto): Do not declare if
5455 HAVE_WINDOW_SYSTEM.
5456 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5457 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5458
5459 * sysdep.c: Make symbols static if they're not exported.
5460 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5461 Now static.
5462 (sigprocmask_set, full_mask): Remove; unused.
5463 (wait_debugging): Mark as visible.
5464 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5465 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5466
5467 * syntax.c (syntax_temp): Define only if !__GNUC__.
5468
5469 * sound.c (current_sound_device, current_sound): Now static.
5470
5471 * search.c (searchbufs, searchbuf_head): Now static.
5472
5473 * scroll.c (scroll_cost): Remove; unused.
5474 * dispextern.h (scroll_cost): Remove decl.
5475
5476 * region-cache.h (pp_cache): Mark as externally visible.
5477
5478 * process.c: Make symbols static if they're not exported.
5479 (process_tick, update_tick, create_process, chan_process):
5480 (Vprocess_alist, proc_buffered_char, datagram_access):
5481 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5482 (deactivate_process): Mark defn as static, as well as decl.
5483 * lisp.h (create_process): Remove decl.
5484 * process.h (chan_process, Vprocess_alist): Remove decls.
5485
5486 * print.c: Make symbols static if they're not exported.
5487 (print_depth, new_backquote_output, being_printed, print_buffer):
5488 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5489 (print_interval, print_number_index, initial_stderr_stream):
5490 Now static.
5491 * lisp.h (Fprinc): Remove decl.
5492 (debug_output_compilation_hack): Mark as externally visible.
5493
5494 * sysdep.c (croak): Move decl from here to syssignal.h.
5495 * syssignal.h (croak): Put it here, so the API can be checked when
5496 'croak' is called from dissociate_if_controlling_tty.
5497
5498 * minibuf.c: Make symbols static if they're not exported.
5499 (minibuf_save_list, choose_minibuf_frame): Now static.
5500 * lisp.h (choose_minibuf_frame): Remove decl.
5501
5502 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5503
5504 * lread.c: Make symbols static if they're not exported.
5505 (read_objects, initial_obarray, oblookup_last_bucket_number):
5506 Now static.
5507 (make_symbol): Remove; unused.
5508 * lisp.h (initial_obarray, make_symbol): Remove decls.
5509
5510 * keyboard.c: Make symbols static if they're not exported.
5511 (single_kboard, recent_keys_index, total_keys, recent_keys):
5512 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5513 (this_single_command_key_start, echoing, last_auto_save):
5514 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5515 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5516 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5517 (Vlispy_mouse_stem, double_click_count):
5518 Now static.
5519 (force_auto_save_soon): Define only if SIGDANGER.
5520 (ignore_mouse_drag_p): Now static if
5521 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5522 (print_help): Remove; unused.
5523 (stop_character, last_timer_event): Mark as externally visible.
5524 * keyboard.h (ignore_mouse_drag_p): Declare only if
5525 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5526 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5527 * lisp.h (echoing): Remove decl.
5528 (force_auto_save_soon): Declare only if SIGDANGER.
5529 * xdisp.c (redisplay_window): Simplify code, to make it more
5530 obvious that ignore_mouse_drag_p is not accessed if !defined
5531 USE_GTK && !defined HAVE_NS.
5532
5533 * intervals.c: Make symbols static if they're not exported.
5534 (merge_properties_sticky, merge_interval_right, delete_interval):
5535 Now static.
5536 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5537
5538 * insdel.c: Make symbols static if they're not exported.
5539 However, leave prepare_to_modify_buffer alone. It's never
5540 called from outside this function, but that appears to be a bug.
5541 (combine_after_change_list, combine_after_change_buffer):
5542 (adjust_after_replace, signal_before_change): Now static.
5543 (adjust_after_replace_noundo): Remove; unused.
5544 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5545 (signal_before_change): Remove decls.
5546
5547 * indent.c (val_compute_motion, val_vmotion): Now static.
5548
5549 * image.c: Make symbols static if they're not exported.
5550 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5551 if USE_GTK.
5552 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5553 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5554
5555 * fringe.c (standard_bitmaps): Now static.
5556 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5557
5558 * frame.c: Make symbols static if they're not exported.
5559 (x_report_frame_params, make_terminal_frame): Now static.
5560 (get_frame_param): Now static, unless HAVE_NS.
5561 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5562 (x_get_resource_string): Remove; not used.
5563 * frame.h (make_terminal_frame, x_report_frame_params):
5564 (x_get_resource_string); Remove decls.
5565 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5566 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5567
5568 * font.c, fontset.c: Make symbols static if they're not exported.
5569 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5570 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5571 * font.c (font_close_object): Now static.
5572 * font.h (font_close_object): Remove.
5573 * fontset.c (FONTSET_OBJLIST): Remove.
5574 (free_realized_fontset) #if-0 the body, which does nothing.
5575 (face_suitable_for_char_p): #if-0, as it's never called.
5576 * fontset.h (face_suitable_for_char_p): Remove decl.
5577 * xfaces.c (face_at_string_position):
5578 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5579 since 0 is always ASCII.
5580
5581 * fns.c (weak_hash_tables): Now static.
5582
5583 * fileio.c: Make symbols static if they're not exported.
5584 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5585 (Vwrite_region_annotation_buffers): Now static.
5586
5587 * eval.c: Make symbols static if they're not exported.
5588 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5589 * lisp.h (backtrace_list): Remove decl.
5590
5591 * emacs.c: Make symbols static if they're not exported.
5592 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5593 (fatal_error_code, fatal_error_signal_hook, standard_args):
5594 Now static.
5595 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5596 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5597 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5598 * lisp.h (fatal_error_signal_hook): Remove decl.
5599 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5600
5601 * editfns.c: Move a (normally-unused) function to its only use.
5602 * editfns.c, lisp.h (get_operating_system_release): Remove.
5603 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5604 worth the hassle of breaking this out.
5605
5606 * xterm.c: Make symbols static if they're not exported.
5607 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5608 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5609 (x_destroy_window, x_delete_display):
5610 Now static.
5611 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5612 (x_mouse_leave): Remove; unused.
5613 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5614 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5615 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5616 Remove decls.
5617 (x_mouse_leave): Declare only if WINDOWSNT.
5618 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5619 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5620 USE_X_TOOLKIT.
5621
5622 * ftxfont.c: Make symbols static if they're not exported.
5623 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5624 HAVE_FREETYPE.
5625 * font.h (ftxfont_driver): Likewise.
5626
5627 * xfns.c: Make symbols static if they're not exported.
5628 (x_last_font_name, x_display_info_for_name):
5629 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5630 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5631 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5632 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5633 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5634 (last_show_tip_args): Now static.
5635 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5636 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5637 (x_screen_planes): Remove; unused.
5638 * dispextern.h (x_screen_planes): Remove decl.
5639
5640 * dispnew.c: Make symbols static if they're not exported.
5641 * dispextern.h (redraw_garbaged_frames, scrolling):
5642 (increment_row_positions): Remove.
5643 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5644 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5645 Now static.
5646 (redraw_garbaged_frames): Remove; unused.
5647
5648 * xfaces.c: Make symbols static if they're not exported.
5649 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5650 Remove decls.
5651 * xterm.h (defined_color): Remove decls.
5652 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5653 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5654 (menu_face_changed_default, defined_color, free_realized_face):
5655 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5656 (ascii_face_of_lisp_face): Remove; unused.
5657
5658 * xdisp.c: Make symbols static if they're not exported.
5659 * dispextern.h (scratch_glyph_row, window_box_edges):
5660 (glyph_to_pixel_coords, set_cursor_from_row):
5661 (get_next_display_element, set_iterator_to_next):
5662 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5663 (show_mouse_face): Remove decls
5664 * frame.h (message_buf_print): Likewise.
5665 * lisp.h (pop_message, set_message, check_point_in_composition):
5666 Likewise.
5667 * xterm.h (set_vertical_scroll_bar): Likewise.
5668 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5669 (message_buf_print, scratch_glyph_row, displayed_buffer):
5670 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5671 (get_next_display_element, show_mouse_face, window_box_edges):
5672 (frame_to_window_pixel_xy, check_point_in_composition):
5673 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5674 (glyph_to_pixel_coords): Remove; unused.
5675
5676 * dired.c (file_name_completion): Now static.
5677
5678 * dbusbind.c (xd_in_read_queued_messages): Now static.
5679
5680 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5681 * data.c (circular_list_error): Remove.
5682
5683 * commands.h (last_point_position, last_point_position_buffer):
5684 (last_point_position_window): Remove decls.
5685 * keyboard.c: Make these variables static.
5686
5687 * coding.h (coding, code_convert_region, encode_coding_gap):
5688 Remove decls.
5689 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5690 (iso_code_class, detect_coding, code_convert_region): Now static.
5691 (encode_coding_gap): Remove; unused.
5692
5693 * chartab.c (chartab_chars, chartab_bits): Now static.
5694
5695 * charset.h (charset_iso_8859_1): Remove decl.
5696 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5697 Now static.
5698
5699 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5700 * ccl.c (Vccl_program_table): Now static.
5701 (check_ccl_update): Remove; unused.
5702
5703 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5704 * category.h: ... from here.
5705 * category.c (check_category_table, set_category_set): Now static.
5706
5707 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5708 * lisp.h: Remove these decls.
5709
5710 * buffer.c (buffer_count): Remove unused var.
5711
5712 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5713 so that it's not optimized away.
5714 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5715 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5716 exported only to the debugger.
5717
5718 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5719 * atimer.h (run_all_atimers): Remove; not exported.
5720
5721 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5722 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5723 was inaccessible from Lisp.
5724 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5725 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5726
5727 alloc.c: Import and export fewer symbols, and remove unused items.
5728 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5729 is defined.
5730 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5731 it's not optimized away by whole-program optimization.
5732 (message_enable_multibyte, free_misc): Remove.
5733 (catchlist, handlerlist, mark_backtrace):
5734 Declare only if BYTE_MARK_STACK.
5735 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5736 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5737 (message_enable_multibyte): Remove decl.
5738 (free_misc, interval_free_list, float_block, float_block_index):
5739 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5740 (cons_free_list, last_marked_index):
5741 Now static.
5742 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5743 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5744 (mark_backtrace): Define only if BYTE_MARK_STACK.
5745 * xdisp.c (message_enable_multibyte): Now static.
5746
5747 Declare Lisp_Object Q* variables to be 'static' if not exported.
5748 This makes it easier for human readers (and static analyzers)
5749 to see whether these variables are used from other modules.
5750 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5751 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5752 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5753 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5754 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5755 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5756 * xmenu.c, xselect.c:
5757 Declare Q* vars static if they are not used in other modules.
5758 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5759 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5760 Remove decls of unexported vars.
5761 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5762
5763 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5764
5765 Make Emacs functions such as Fatom 'static' by default.
5766 This makes it easier for human readers (and static analyzers)
5767 to see whether these functions can be called from other modules.
5768 DEFUN now defines a static function. To make the function external
5769 so that it can be used in other C modules, use the new macro DEFUE.
5770 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5771 (Finit_image_library):
5772 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5773 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5774 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5775 Remove decls, since these functions are now static.
5776 (Funintern, Fget_internal_run_time): New decls, since these functions
5777 were already external.
5778
5779 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5780 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5781 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5782 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5783 * keyboard.c, keymap.c, lread.c:
5784 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5785 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5786 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5787 Mark functions with DEFUE instead of DEFUN,
5788 if they are used in other modules.
5789 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5790 decls for now-static functions.
5791 * buffer.h (Fdelete_overlay): Remove decl.
5792 * callproc.c (Fgetenv_internal): Mark as internal.
5793 * composite.c (Fremove_list_of_text_properties): Remove decl.
5794 (Fcomposition_get_gstring): New forward static decl.
5795 * composite.h (Fcomposite_get_gstring): Remove decl.
5796 * dired.c (Ffile_attributes): New forward static decl.
5797 * doc.c (Fdocumntation_property): New forward static decl.
5798 * eval.c (Ffetch_bytecode): New forward static decl.
5799 (Funintern): Remove extern decl; now in .h file where it belongs.
5800 * fileio.c (Fmake_symbolic_link): New forward static decl.
5801 * image.c (Finit_image_library): New forward static decl.
5802 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5803 * intervals.h (Fprevious_property_change):
5804 (Fremove_list_of_text_properties): Remove decls.
5805 * keyboard.c (Fthis_command_keys): Remove decl.
5806 (Fcommand_execute): New forward static decl.
5807 * keymap.c (Flookup_key): New forward static decl.
5808 (Fcopy_keymap): Now static.
5809 * keymap.h (Flookup_key): Remove decl.
5810 * process.c (Fget_process): New forward static decl.
5811 (Fprocess_datagram_address): Mark as internal.
5812 * syntax.c (Fsyntax_table_p): New forward static decl.
5813 (skip_chars): Remove duplicate decl.
5814 * textprop.c (Fprevious_property_change): New forward static decl.
5815 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5816 Now internal.
5817 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5818 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5819
5820 * editfns.c (Fformat): Remove unreachable code.
5821
5822 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5823
5824 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5825 change. (Bug#8496)
5826
5827 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5828
5829 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5830 when at ZV. (Bug#8487)
5831
5832 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5833
5834 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5835 (Bug#8437)
5836 * keyboard.c (parse_tool_bar_item): Likewise.
5837 * sound.c (sound_cleanup, alsa_close): Likewise.
5838 * termcap.c (tgetent): Likewise.
5839 * xfns.c (x_default_font_parameter): Likewise.
5840 * xsettings.c (read_and_apply_settings): Likewise.
5841
5842 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5843 (overrun_check_free): Protoize.
5844
5845 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5846
5847 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5848 since callers should never pass a negative size.
5849 Change the signature to match that of plain 'read' and 'write'; see
5850 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5851 * lisp.h: Update prototypes of emacs_write and emacs_read.
5852
5853 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5854
5855 * xdisp.c (redisplay_window): Don't try to determine the character
5856 position of the scroll margin if the window start point w->startp
5857 is outside the buffer's accessible region. (Bug#8468)
5858
5859 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5860
5861 Fix write-region and its subroutines for buffers > 2GB.
5862 * fileio.c (a_write, e_write): Modify declaration of arguments and
5863 local variables to support buffers larger than 2GB.
5864 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5865
5866 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5867 argument, local variables, and return value.
5868
5869 * lisp.h: Update prototypes of emacs_write and emacs_read.
5870
5871 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5872
5873 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5874
5875 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5876
5877 Fix more problems found by GCC 4.6.0's static checks.
5878
5879 * xdisp.c (vmessage): Use a better test for character truncation.
5880
5881 * charset.c (load_charset_map): <, not <=, for optimization,
5882 and to avoid potential problems with integer overflow.
5883 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5884 * casetab.c (set_identity, shuffle): Likewise.
5885 * editfns.c (Fformat): Likewise.
5886 * syntax.c (skip_chars): Likewise.
5887
5888 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5889 This also lets GCC 4.6.0 generate slightly better loop code.
5890
5891 * callint.c (Fcall_interactively): <, not <=, for optimization.
5892 (Fcall_interactively): Count the number of arguments produced,
5893 not the number of arguments given. This is simpler and lets GCC
5894 4.6.0 generate slightly better code.
5895
5896 * ftfont.c: Distingish more carefully between FcChar8 and char.
5897 The previous code passed unsigned char * to a functions like
5898 strlen and xstrcasecmp that expect char *, which does not
5899 conform to the C standard.
5900 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5901 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5902 char * when the C standard requires it.
5903
5904 * keyboard.c (read_char): Remove unused var.
5905
5906 * eval.c: Port to Windows vsnprintf (Bug#8435).
5907 Include <limits.h>.
5908 (SIZE_MAX): Define if the headers do not.
5909 (verror): Do not give up if vsnprintf returns a negative count.
5910 Instead, grow the buffer. This ports to Windows vsnprintf, which
5911 does not conform to C99. Problem reported by Eli Zaretskii.
5912 Also, simplify the allocation scheme, by avoiding the need for
5913 calling realloc, and removing the ALLOCATED variable.
5914
5915 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5916
5917 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5918 But keep the doprint source code for now, as we might revamp it
5919 and use it again (Bug#8435).
5920 * lisp.h (doprnt): Remove.
5921 * Makefile.in (base_obj): Remove doprnt.o.
5922 * deps.mk (doprnt.o): Remove.
5923
5924 error: Print 32- and 64-bit integers portably (Bug#8435).
5925 Without this change, on typical 64-bit hosts error ("...%d...", N)
5926 was used to print both 32- and 64-bit integers N, which relied on
5927 undefined behavior.
5928 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5929 New macro.
5930 * lisp.h (error, verror): Mark as printf-like functions.
5931 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5932 Report overflow in size calculations when allocating printf buffer.
5933 Do not truncate output string at its first null byte.
5934 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5935 Truncate the output at a character boundary, since vsnprintf does not
5936 do that.
5937 * charset.c (check_iso_charset_parameter): Convert internal
5938 character to string before calling 'error', since %c now has the
5939 printf meaning.
5940 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5941 overflow when computing char to be passed to 'error'. Do not
5942 pass Lisp_Object to 'error'; pass the integer instead.
5943 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5944 formatted with plain %d.
5945
5946 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5947
5948 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5949
5950 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5951
5952 * xterm.c (x_catch_errors): Remove duplicate declaration.
5953
5954 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5955
5956 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5957
5958 2011-04-10 Jim Meyering <meyering@redhat.com>
5959
5960 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5961 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5962 return ssize_t not "int", and use size_t as the buffer length.
5963 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5964 * gnutls.h: Update declarations.
5965 * process.c (read_process_output): Use ssize_t, to match.
5966 (send_process): Likewise.
5967
5968 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5969
5970 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5971
5972 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5973
5974 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5975 Use unsigned char, to match FcChar8 type definition.
5976
5977 * xterm.c (handle_one_xevent):
5978 * xmenu.c (create_and_show_popup_menu):
5979 * xselect.c (x_decline_selection_request)
5980 (x_reply_selection_request): Avoid type-punned deref of X events.
5981
5982 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5983
5984 Fix some uses of `int' instead of EMACS_INT.
5985 * search.c (string_match_1, fast_string_match)
5986 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5987 (scan_buffer, find_next_newline_no_quit)
5988 (find_before_next_newline, search_command, Freplace_match)
5989 (Fmatch_data): Make some `int' variables be EMACS_INT.
5990
5991 * xdisp.c (display_count_lines): 3rd argument and return value now
5992 EMACS_INT. All callers changed.
5993 (pint2hrstr): Last argument is now EMACS_INT.
5994
5995 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5996 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5997 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5998 (decode_coding_utf_16, decode_coding_emacs_mule)
5999 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6000 (decode_coding_ccl, decode_coding_charset)
6001 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6002 (decode_coding_iso_2022, decode_coding_emacs_mule)
6003 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6004 <char_offset, last_offset>: Declare EMACS_INT.
6005 (encode_coding_utf_8, encode_coding_utf_16)
6006 (encode_coding_emacs_mule, encode_invocation_designation)
6007 (encode_designation_at_bol, encode_coding_iso_2022)
6008 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6009 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6010 Declare EMACS_INT.
6011 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6012 (encode_invocation_designation): Last argument P_NCHARS is now
6013 EMACS_INT.
6014 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6015 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6016
6017 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6018 All users changed.
6019
6020 * ccl.c (Fccl_execute_on_string): Declare some variables
6021 EMACS_INT.
6022
6023 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6024
6025 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6026
6027 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6028
6029 * process.c (Fformat_network_address): Doc fix.
6030
6031 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6032
6033 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6034
6035 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6036
6037 * keyboard.c (read_char): Call Lisp function help-form-show,
6038 instead of using internal_with_output_to_temp_buffer.
6039 (Qhelp_form_show): New var.
6040 (syms_of_keyboard): Use DEFSYM macro.
6041
6042 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6043
6044 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6045
6046 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6047
6048 * process.c (Flist_processes): Remove to Lisp.
6049 (list_processes_1): Delete.
6050
6051 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6052
6053 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6054
6055 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6056
6057 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6058
6059 Fix more problems found by GCC 4.6.0's static checks.
6060
6061 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6062
6063 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6064
6065 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6066
6067 * xdisp.c (vmessage): Mark as a printf-like function.
6068
6069 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6070
6071 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6072
6073 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6074 printf-like functions.
6075 (tiff_load): Add casts to remove these marks before passing them
6076 to system-supplied API.
6077
6078 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6079
6080 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6081 This avoids several warnings with gcc -Wstrict-overflow.
6082 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6083 directly, rather than having caller test rule sign. This avoids
6084 some unnecessary tests.
6085 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6086 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6087 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6088
6089 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6090 (xfont_open): Avoid unnecessary tests.
6091
6092 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6093
6094 * composite.h, composite.c (composition_gstring_put_cache):
6095 Use EMACS_INT, not int, for length.
6096
6097 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6098 breaking out part of COMPOSITION_DECODE_RULE.
6099 (COMPOSITION_DECODE_RULE): Use it.
6100 * composite.c (get_composition_id): Remove unused local vars,
6101 by using the new macro.
6102
6103 * textprop.c (set_text_properties_1): Change while to do-while,
6104 since the condition is always true at first.
6105
6106 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6107 (interval_deletion_adjustment): Return unsigned value.
6108 All uses changed.
6109
6110 * process.c (list_processes_1, create_pty, read_process_output):
6111 (exec_sentinel): Remove vars that were set but not used.
6112 (create_pty): Remove unnecessary "volatile"s.
6113 (Fnetwork_interface_info): Avoid possibility of int overflow.
6114 (read_process_output): Do adaptive read buffering even if carryover.
6115 (read_process_output): Simplify nbytes computation if buffered.
6116
6117 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6118
6119 * syntax.c (scan_words): Remove var that was set but not used.
6120 (update_syntax_table): Use unsigned instead of int.
6121
6122 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6123 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6124 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6125
6126 * print.c (print_error_message): Avoid int overflow.
6127
6128 * font.c (font_list_entities): Redo for clarity,
6129 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6130
6131 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6132 (font_score): Avoid potential overflow in diff calculation.
6133
6134 * fns.c (substring_both): Remove var that is set but not used.
6135 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6136
6137 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6138
6139 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6140 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6141 can always succeed if overflow has undefined behavior.
6142
6143 * search.c (boyer_moore, wordify): Remove vars set but not used.
6144 (wordify): Omit three unnecessary tests.
6145
6146 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6147 All callers changed. This avoids the need for an unused var.
6148
6149 * casefiddle.c (casify_region): Remove var that is set but not used.
6150
6151 * dired.c (file_name_completion): Remove var that is set but not used.
6152
6153 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6154
6155 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6156 (Finsert_file_contents): Remove unnecessary code checking fd.
6157
6158 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6159 Check for integer overflow on size calculations.
6160
6161 * buffer.c (Fprevious_overlay_change): Remove var that is set
6162 but not used.
6163
6164 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6165 Remove vars that are set but not used.
6166 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6167 (timer_check_2): Mark vars as initialized.
6168
6169 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6170
6171 * image.c (lookup_image): Remove var that is set but not used.
6172 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6173
6174 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6175 that are set but not used.
6176
6177 * xfns.c (make_invisible_cursor): Don't return garbage
6178 if XCreateBitmapFromData fails (Bug#8410).
6179
6180 * xselect.c (x_get_local_selection, x_handle_property_notify):
6181 Remove vars that are set but not used.
6182
6183 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6184 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6185
6186 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6187 Remove var that is set but not used.
6188 (scroll_bar_windows_size): Now size_t, not int.
6189 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6190 Check for overflow.
6191
6192 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6193 (map_tty_color) [!defined MSDOS]: Likewise.
6194
6195 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6196
6197 * coding.c: Remove vars that are set but not used.
6198 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6199 All callers changed.
6200 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6201 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6202 (decode_coding_charset): Remove vars that are set but not used.
6203
6204 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6205 that is set but not used.
6206
6207 * print.c (print_object): Remove var that is set but not used.
6208
6209 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6210 The gnulib version avoids calling malloc in the usual case,
6211 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6212 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6213 * filelock.c (current_lock_owner): Likewise.
6214 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6215 * sysdep.c: Include allocator.h, careadlinkat.h.
6216 (emacs_no_realloc_allocator): New static constant.
6217 (emacs_readlink): New function.
6218 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6219 ../lib/careadlinkat.h.
6220
6221 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6222
6223 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6224 first non-nil return value).
6225
6226 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6227
6228 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6229 if not defined (Bug#8403).
6230
6231 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6232
6233 * xdisp.c (display_count_lines): Remove parameter `start',
6234 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6235 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6236 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6237 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6238 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6239 and thereabouts. All callers changed.
6240 (get_per_char_metric): Remove parameter `f', unused since
6241 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6242
6243 2011-04-02 Jim Meyering <meyering@redhat.com>
6244
6245 do not dereference NULL upon failed strdup
6246 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6247 (ns_get_family): Likewise.
6248
6249 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6250
6251 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6252
6253 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6254
6255 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6256 later (Bug#8403).
6257
6258 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6259
6260 Add lexical binding.
6261
6262 * window.c (Ftemp_output_buffer_show): New fun.
6263 (Fsave_window_excursion):
6264 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6265
6266 * lread.c (lisp_file_lexically_bound_p): New function.
6267 (Fload): Bind Qlexical_binding.
6268 (readevalloop): Remove `evalfun' arg.
6269 Bind Qinternal_interpreter_environment.
6270 (Feval_buffer): Bind Qlexical_binding.
6271 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6272 Mark as dynamic.
6273 (syms_of_lread): Declare `lexical-binding'.
6274
6275 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6276
6277 * keyboard.c (eval_dyn): New fun.
6278 (menu_item_eval_property): Use it.
6279
6280 * image.c (parse_image_spec): Use Ffunctionp.
6281
6282 * fns.c (concat, mapcar1): Accept byte-code-functions.
6283
6284 * eval.c (Fsetq): Handle lexical vars.
6285 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6286 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6287 (FletX, Flet): Obey lexical binding.
6288 (Fcommandp): Handle closures.
6289 (Feval): New `lexical' arg.
6290 (eval_sub): New function extracted from Feval. Use it almost
6291 everywhere where Feval was used. Look up vars in lexical env.
6292 Handle closures.
6293 (Ffunctionp): Move from subr.el.
6294 (Ffuncall): Handle closures.
6295 (apply_lambda): Remove `eval_flags'.
6296 (funcall_lambda): Handle closures and new byte-code-functions.
6297 (Fspecial_variable_p): New function.
6298 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6299 but without exporting it to Lisp.
6300
6301 * doc.c (Fdocumentation, store_function_docstring):
6302 * data.c (Finteractive_form): Handle closures.
6303
6304 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6305 interactive spec.
6306
6307 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6308 New byte-codes.
6309 (exec_byte_code): New function extracted from Fbyte_code to handle new
6310 calling convention for byte-code-functions. Add new byte-codes.
6311
6312 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6313
6314 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6315
6316 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6317
6318 * xdisp.c (redisplay_internal): Fix prototype.
6319
6320 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6321
6322 * xdisp.c (SCROLL_LIMIT): New macro.
6323 (try_scrolling): Use it when setting scroll_limit.
6324 Limit scrolling to 100 screen lines.
6325 (redisplay_window): Even when falling back on "recentering",
6326 position point in the window according to scroll-conservatively,
6327 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6328
6329 (try_scrolling): When point is above the window, allow searching
6330 as far as scroll_max, or one screenful, to compute vertical
6331 distance from PT to the scroll margin position. This prevents
6332 try_scrolling from unnecessarily failing when
6333 scroll-conservatively is set to a value slightly larger than the
6334 window height. Clean up the case of PT below the margin at bottom
6335 of window: scroll_max can no longer be INT_MAX. When aggressive
6336 scrolling is in use, don't let point enter the opposite scroll
6337 margin as result of the scroll.
6338 (syms_of_xdisp) <scroll-conservatively>: Document the
6339 threshold of 100 lines for never-recentering scrolling.
6340
6341 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6342
6343 * dispextern.h (move_it_by_lines):
6344 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6345 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6346 (message_log_check_duplicate): Remove parameters `prev_bol' and
6347 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6348 (redisplay_internal): Remove parameter `preserve_echo_area',
6349 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6350
6351 * indent.c (Fvertical_motion):
6352 * window.c (window_scroll_pixel_based, Frecenter):
6353 Don't pass `need_y_p' to `move_it_by_lines'.
6354
6355 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6356
6357 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6358 steal a few bits to be more compact.
6359 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6360 Remove unneeded casts.
6361
6362 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6363
6364 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6365
6366 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6367 binding" message (bug#7967).
6368
6369 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6370
6371 Fix more problems found by GCC 4.6.0's static checks.
6372
6373 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6374 Remove unused local var.
6375
6376 * editfns.c (Fmessage_box): Remove unused local var.
6377
6378 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6379 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6380 Omit unused local vars.
6381 * window.c (shrink_windows): Omit unused local var.
6382 * menu.c (digest_single_submenu): Omit unused local var.
6383 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6384 Omit unused local var.
6385
6386 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6387 Don't assume string length fits in int.
6388 (keyremap_step, read_key_sequence): Use size_t for sizes.
6389 (read_key_sequence): Don't check last_real_key_start redundantly.
6390
6391 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6392 instead of alloca (Bug#8344).
6393
6394 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6395 (Fbacktrace_frame): Don't assume nframes fits in int.
6396
6397 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6398
6399 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6400 concerns.
6401
6402 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6403
6404 * cm.c (calccost): Turn while-do into do-while, for clarity.
6405
6406 * keyboard.c (syms_of_keyboard): Use the same style as later
6407 in this function when indexing through an array. This also
6408 works around GCC bug 48267.
6409
6410 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6411
6412 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6413
6414 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6415 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6416
6417 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6418 This avoids undefined behavior on integer overflow, and is a bit
6419 more convenient anyway since it is compared to a size_t variable.
6420
6421 Variadic C functions now count arguments with size_t, not int.
6422 This avoids an unnecessary limitation on 64-bit machines, which
6423 caused (substring ...) to crash on large vectors (Bug#8344).
6424 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6425 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6426 All variadic functions and their callers changed accordingly.
6427 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6428 * data.c (arith_driver, float_arith_driver): Likewise.
6429 * editfns.c (general_insert_function): Likewise.
6430 * eval.c (struct backtrace.nargs, interactive_p)
6431 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6432 (funcall_lambda, mark_backtrace): Likewise.
6433 * fns.c (concat): Likewise.
6434 * frame.c (x_set_frame_parameters): Likewise.
6435 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6436 0 if not found, not -1. All callers changed.
6437
6438 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6439 (stack_copy_size): Now size_t, not int.
6440 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6441
6442 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6443
6444 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6445 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6446 All callers changed.
6447
6448 * lisp.h (multibyte_char_to_unibyte):
6449 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6450 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6451 * character.h (CHAR_TO_BYTE8):
6452 * cmds.c (internal_self_insert):
6453 * editfns.c (general_insert_function):
6454 * keymap.c (push_key_description):
6455 * search.c (Freplace_match):
6456 * xdisp.c (message_dolog, set_message_1): All callers changed.
6457
6458 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6459
6460 * keyboard.c (safe_run_hook_funcall): New function.
6461 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6462 don't set the hook to nil, but remove the offending function instead.
6463 (Qcommand_hook_internal): Remove, unused.
6464 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6465 Vcommand_hook_internal.
6466
6467 * eval.c (enum run_hooks_condition): Remove.
6468 (funcall_nil, funcall_not): New functions.
6469 (run_hook_with_args): Call each function through a `funcall' argument.
6470 Remove `cond' argument, now redundant.
6471 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6472 (Frun_hook_with_args_until_failure): Adjust accordingly.
6473 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6474
6475 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6476
6477 * dispextern.h (string_buffer_position): Remove declaration.
6478
6479 * print.c (strout): Remove parameter `multibyte', unused since
6480 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6481
6482 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6483 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6484 All callers changed.
6485
6486 * w32.c (_wsa_errlist): Use braces for struct initializers.
6487
6488 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6489 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6490 All callers changed.
6491 (string_buffer_position): Likewise. Also, make static (it's never
6492 used outside xdisp.c).
6493 (cursor_row_p): Remove parameter `w', unused since
6494 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6495 (decode_mode_spec): Remove parameter `precision', introduced during
6496 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6497 All callers changed.
6498
6499 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6500
6501 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6502
6503 2011-03-27 Anders Lindgren <andlind@gmail.com>
6504
6505 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6506 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6507 (ns_update_auto_hide_menu_bar): New functions.
6508 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6509 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6510 ns_constrain_all_frames.
6511 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6512 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6513
6514 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6515
6516 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6517
6518 2011-03-27 Glenn Morris <rgm@gnu.org>
6519
6520 * syssignal.h: Replace RETSIGTYPE with void.
6521 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6522 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6523 Replace SIGTYPE with void everywhere.
6524 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6525 * s/template.h (SIGTYPE): Remove commented out definition.
6526
6527 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6528
6529 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6530 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6531
6532 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6533
6534 * w32.c (read_unc_volume): Use parameter `henum', instead of
6535 global variable `wget_enum_handle'.
6536
6537 * keymap.c (describe_vector): Remove parameters `indices' and
6538 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6539 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6540
6541 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6542
6543 * keyboard.c (timer_check): Remove parameter `do_it_now',
6544 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6545 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6546 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6547
6548 * keyboard.c (read_char):
6549 * w32menu.c (w32_menu_display_help):
6550 * xmenu.c (show_help_event, menu_help_callback):
6551 Adjust calls to `show_help_echo'.
6552
6553 * gtkutil.c (xg_maybe_add_timer):
6554 * keyboard.c (readable_events):
6555 * process.c (wait_reading_process_output):
6556 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6557
6558 * insdel.c (adjust_markers_gap_motion):
6559 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6560 (gap_left, gap_right): Don't call it.
6561
6562 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6563
6564 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6565 incurred during fontification.
6566
6567 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6568
6569 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6570 (DEFVAR_PER_BUFFER): Don't pass it.
6571
6572 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6573 (scrolling_window): Don't pass it.
6574
6575 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6576
6577 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6578
6579 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6580 and `suffix'.
6581 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6582 of variables specific to SELinux and computation of `encoded_absname'.
6583
6584 * image.c (XPutPixel): Remove unused variable `height'.
6585
6586 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6587
6588 * unexw32.c (get_section_info): Remove unused variable `section'.
6589
6590 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6591 (system_process_attributes): Remove unused variable `sess'.
6592 (sys_read): Remove unused variable `err'.
6593
6594 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6595 (w32_wnd_proc): Remove unused variable `isdead'.
6596 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6597 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6598 (x_create_tip_frame): Remove unused variable `tem'.
6599
6600 * w32inevt.c (w32_console_read_socket):
6601 Remove unused variable `no_events'.
6602
6603 * w32term.c (x_draw_composite_glyph_string_foreground):
6604 Remove unused variable `width'.
6605
6606 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6607
6608 * w32term.c (x_set_glyph_string_clipping):
6609 Don't pass uninitialized region to CombineRgn.
6610
6611 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6612
6613 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6614 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6615 (Fx_close_connection): Remove unused variable `i'.
6616
6617 * w32font.c (w32font_draw): Return number of glyphs.
6618 (w32font_open_internal): Remove unused variable `i'.
6619 (w32font_driver): Add missing initializer.
6620
6621 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6622 (fill_in_menu): Remove unused variable `items_added'.
6623
6624 * w32term.c (last_mouse_press_frame): Remove static global variable.
6625 (w32_clip_to_row): Remove unused variable `f'.
6626 (x_delete_terminal): Remove unused variable `i'.
6627
6628 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6629 (NOTHING): Remove unused static global variable.
6630 (uniscribe_check_otf): Remove unused variable `table'.
6631 (uniscribe_font_driver): Add missing initializers.
6632
6633 2011-03-23 Julien Danjou <julien@danjou.info>
6634
6635 * term.c (Fsuspend_tty, Fresume_tty):
6636 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6637 * window.c (temp_output_buffer_show):
6638 * insdel.c (signal_before_change):
6639 * frame.c (Fhandle_switch_frame):
6640 * fileio.c (Fdo_auto_save):
6641 * emacs.c (Fkill_emacs):
6642 * editfns.c (save_excursion_restore):
6643 * cmds.c (internal_self_insert):
6644 * callint.c (Fcall_interactively):
6645 * buffer.c (Fkill_all_local_variables):
6646 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6647 Use Frun_hooks.
6648 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6649 unconditionnaly since it does the check itself.
6650
6651 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6652
6653 Fix more problems found by GCC 4.5.2's static checks.
6654
6655 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6656 the first time through the loop, since we know p0 < p1 then.
6657 This also avoids a gcc -Wstrict-overflow warning.
6658
6659 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6660 leading to a memory leak, possible in functions like
6661 load_charset_map_from_file that can allocate an unbounded number
6662 of objects (Bug#8318).
6663
6664 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6665 that could (at least in theory) be that large.
6666
6667 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6668 This is less likely to overflow, and avoids undefined behavior if
6669 overflow does occur. All callers changed. Use strtoul to scan
6670 for the unsigned long integer.
6671 (pint2hrstr): Simplify and tune code slightly.
6672 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6673
6674 * scroll.c (do_scrolling): Work around GCC bug 48228.
6675 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6676
6677 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6678 This also avoids a warning with gcc -Wstrict-overflow.
6679 (validate_x_resource_name): Simplify count usage.
6680 This also avoids a warning with gcc -Wstrict-overflow.
6681
6682 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6683 fail (Bug#8306).
6684
6685 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6686
6687 * process.c (Fmake_network_process): Use socklen_t, not int,
6688 where POSIX says socklen_t is required in portable programs.
6689 This fixes a porting bug on hosts like 64-bit HP-UX, where
6690 socklen_t is wider than int (Bug#8277).
6691 (Fmake_network_process, server_accept_connection):
6692 (wait_reading_process_output, read_process_output):
6693 Likewise.
6694
6695 * process.c: Rename or move locals to avoid shadowing.
6696 (list_processes_1, Fmake_network_process):
6697 (read_process_output_error_handler, exec_sentinel_error_handler):
6698 Rename or move locals.
6699 (Fmake_network_process): Define label "retry_connect" only if needed.
6700 (Fnetwork_interface_info): Fix pointer signedness.
6701 (process_send_signal): Add cast to avoid pointer signedness problem.
6702 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6703 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6704
6705 Make tparam.h and terminfo.c consistent.
6706 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6707 Include tparam.h instead, since it declares them.
6708 * cm.h (PC): Remove extern decl; tparam.h now does this.
6709 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6710 * terminfo.c: Include tparam.h, to check interfaces.
6711 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6712 (tparam): Adjust signature to match interface in tparam.h;
6713 this removes some undefined behavior. Check that outstring and len
6714 are zero, which they always are with Emacs.
6715 * tparam.h (PC, BC, UP): New extern decls.
6716
6717 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6718 (xftfont_open): Rename locals to avoid shadowing.
6719
6720 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6721 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6722 (OTF_TAG_SYM): Omit macro if not needed.
6723 (ftfont_list): Remove unused local.
6724 (get_adstyle_property, ftfont_pattern_entity):
6725 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6726 Rename locals to avoid shadowing.
6727
6728 * xfont.c (xfont_list_family): Mark var as initialized.
6729
6730 * xml.c (make_dom): Now static.
6731
6732 * composite.c (composition_compute_stop_pos): Rename local to
6733 avoid shadowing.
6734 (composition_reseat_it): Remove unused locals.
6735 (find_automatic_composition, composition_adjust_point): Likewise.
6736 (composition_update_it): Mark var as initialized.
6737 (find_automatic_composition): Mark vars as initialized,
6738 with a FIXME (Bug#8290).
6739
6740 character.h: Rename locals to avoid shadowing.
6741 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6742 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6743 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6744 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6745 to avoid shadowing.
6746
6747 * textprop.c (property_change_between_p): Remove; unused.
6748
6749 * intervals.c (interval_start_pos): Now static.
6750
6751 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6752
6753 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6754 Rename locals to avoid shadowing.
6755
6756 * sound.c (wav_play, au_play, Fplay_sound_internal):
6757 Fix pointer signedness.
6758 (alsa_choose_format): Remove unused local var.
6759 (wav_play): Initialize a variable to 0, to prevent undefined
6760 behavior (Bug#8278).
6761
6762 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6763
6764 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6765
6766 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6767 clobbering (Bug#8298).
6768 * sysdep.c (sys_subshell): Likewise.
6769 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6770
6771 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6772 This should get cleaned up, so that child_setup has the
6773 same signature on all platforms.
6774
6775 * callproc.c (call_process_cleanup): Now static.
6776 (relocate_fd): Rename locals to avoid shadowing.
6777
6778 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6779
6780 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6781 not to be necessary, and produces flickering.
6782
6783 2011-03-20 Glenn Morris <rgm@gnu.org>
6784
6785 * config.in: Remove file.
6786
6787 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6788
6789 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6790 are now in src/globals.h.
6791 (syms_of_minibuf): Remove spurious & from previous change.
6792
6793 2011-03-20 Leo <sdl.web@gmail.com>
6794
6795 * minibuf.c (completing-read-function): New variable.
6796 (completing-read-default): Rename from completing-read.
6797 (completing-read): Call completing-read-function.
6798
6799 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6800
6801 * xfaces.c (Fx_load_color_file):
6802 Read color file from absolute filename (bug#8250).
6803
6804 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6805
6806 * makefile.w32-in: Update dependencies.
6807
6808 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6809
6810 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6811
6812 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6813
6814 Fix more problems found by GCC 4.5.2's static checks.
6815
6816 * process.c (make_serial_process_unwind, send_process_trap):
6817 (sigchld_handler): Now static.
6818
6819 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6820 That way, the code declares only the vars that it needs.
6821 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6822 * s/cygwin.h (PTY_ITERATION): Likewise.
6823 * s/darwin.h (PTY_ITERATION): Likewise.
6824 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6825
6826 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6827 * process.c (allocate_pty): Don't declare stb unless it's needed.
6828
6829 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6830 (CONSTANTLIM): Remove; unused.
6831 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6832 Define only if needed.
6833
6834 * unexelf.c (unexec): Name an expression,
6835 to avoid gcc -Wbad-function-cast warning.
6836 Use a different way to cause a compilation error if anyone uses
6837 n rather than nn, a way that does not involve shadowing.
6838 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6839
6840 * deps.mk (unexalpha.o): Remove; unused.
6841
6842 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6843 * unexec.h: New file.
6844 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6845 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6846 Depend on unexec.h.
6847 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6848 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6849 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6850 Change as necessary to match prototype in unexec.h.
6851
6852 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6853 shadowing.
6854 (back_comment, skip_chars): Mark vars as initialized.
6855
6856 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6857 Rename locals to avoid shadowing.
6858
6859 * lread.c (read1): Rewrite so as not to use empty "else".
6860 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6861
6862 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6863
6864 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6865 warning when compiling print.c.
6866
6867 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6868 instead of using an uninitialized var.
6869 (font_sort_entities): Mark var as initialized.
6870
6871 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6872
6873 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6874 pointers to constants.
6875 (font_parse_fcname): Remove unused vars.
6876 (font_delete_unmatched): Now static.
6877 (font_get_spec): Remove; unused.
6878 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6879 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6880 Rename or move locals to avoid shadowing.
6881
6882 * fns.c (require_nesting_list, require_unwind): Now static.
6883 (Ffillarray): Rename locals to avoid shadowing.
6884
6885 * floatfns.c (domain_error2): Define only if needed.
6886 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6887
6888 * alloc.c (mark_backtrace): Move decl from here ...
6889 * lisp.h: ... to here, so that it can be checked.
6890
6891 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6892 (Fdefvar): Rewrite so as not to use empty "else".
6893 (lisp_indirect_variable): Name an expression,
6894 to avoid gcc -Wbad-function-cast warning.
6895 (Fdefvar): Rename locals to avoid shadowing.
6896
6897 * callint.c (quotify_arg, quotify_args): Now static.
6898 (Fcall_interactively): Rename locals to avoid shadowing.
6899 Use const pointer when appropriate.
6900
6901 * lisp.h (get_system_name, get_operating_system_release):
6902 Move decls here, to check interfaces.
6903 * process.c (get_operating_system_release): Move decl to lisp.h.
6904 * xrdb.c (get_system_name): Likewise.
6905 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6906 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6907 some of which prompt warnings from gcc -Wbad-function-cast.
6908 (Fformat_time_string, Fencode_time, Finsert_char):
6909 (Ftranslate_region_internal, Fformat):
6910 Rename or remove local vars to avoid shadowing.
6911 (Ftranslate_region_internal): Mark var as initialized.
6912
6913 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6914 avoid shadowing.
6915
6916 * lisp.h (eassert): Check that the argument compiles, even if
6917 ENABLE_CHECKING is not defined.
6918
6919 * data.c (Findirect_variable): Name an expression, to avoid
6920 gcc -Wbad-function-cast warning.
6921 (default_value, arithcompare, arith_driver, arith_error): Now static.
6922 (store_symval_forwarding): Rename local to avoid shadowing.
6923 (Fmake_variable_buffer_local, Fmake_local_variable):
6924 Mark variables as initialized.
6925 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6926
6927 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6928 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6929 Rename locals to avoid shadowing.
6930 (mark_stack): Move local variables into the #ifdef region where
6931 they're used.
6932 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6933 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6934 needed otherwise.
6935 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6936 (GC_STRING_CHARS): Remove; not used.
6937 (Fmemory_limit): Cast sbrk's returned value to char *.
6938
6939 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6940 avoids undefined behavior in theory.
6941
6942 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6943
6944 Use functions, not macros, for up- and down-casing (Bug#8254).
6945 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6946 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6947 to use the following functions instead of these macros.
6948 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6949 EMACS_INT, since callers assume the returned value fits in int.
6950 (upcase1): Likewise, for UPCASE_TABLE.
6951 (uppercasep, lowercasep, upcase): New static inline functions.
6952 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6953 the race-condition problem in the old DOWNCASE.
6954
6955 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6956 Rename locals to avoid shadowing.
6957 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6958 (regex_compile, re_search_2, re_match_2_internal):
6959 Remove unused local vars.
6960 (FREE_VAR): Rewrite so as not to use empty "else",
6961 which gcc can warn about.
6962 (regex_compile, re_match_2_internal): Mark locals as initialized.
6963 (RETALLOC_IF): Define only if needed.
6964 (WORDCHAR_P): Likewise. This one is never needed, but is used
6965 only in a comment talking about a compiler bug, so put inside
6966 the #if 0 of that comment.
6967 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6968 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6969 Remove; unused.
6970
6971 * search.c (boyer_moore): Rename locals to avoid shadowing.
6972 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6973 (PREV_CHAR_BOUNDARY): Likewise.
6974
6975 * search.c (simple_search): Remove unused var.
6976
6977 * dired.c (compile_pattern): Move decl from here ...
6978 * lisp.h: ... to here, so that it can be checked.
6979 (struct re_registers): New forward decl.
6980
6981 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6982
6983 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6984 All uses changed.
6985 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6986 Rename locals to avoid shadowing.
6987 (Fvertical_motion): Mark locals as initialized.
6988
6989 * casefiddle.c (casify_object, casify_region): Now static.
6990 (casify_region): Mark local as initialized.
6991
6992 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6993
6994 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6995 New macros, so that the caller can use some names other than
6996 gcpro1, gcpro2, etc.
6997 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6998 of the new macros.
6999 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7000 argument, for consistency with GCPRO2_VAR, etc: it is now the
7001 prefix of the variable, not the variable itself. All uses
7002 changed.
7003 * dired.c (directory_files_internal, file_name_completion):
7004 Rename locals to avoid shadowing.
7005
7006 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7007 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7008 dired.c's scmp function, had undefined behavior.
7009 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7010 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7011 * buffer.h: ... to here, because these macros use current_buffer,
7012 and the new implementation with inline functions needs to have
7013 current_buffer in scope now, rather than later when the macros
7014 are used.
7015 (downcase, upcase1): New static inline functions.
7016 (DOWNCASE, UPCASE1): Reimplement using these functions.
7017 This avoids undefined behavior in expressions like
7018 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7019 from race conditions in accessing the global variables
7020 case_temp1 and case_temp2.
7021 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7022 * lisp.h (case_temp1, case_temp2): Remove their decls.
7023 * character.h (ASCII_CHAR_P): Move from here ...
7024 * lisp.h: ... to here, so that the inline functions mentioned
7025 above can use them.
7026
7027 * dired.c (directory_files_internal_unwind): Now static.
7028
7029 * fileio.c (file_name_as_directory, directory_file_name):
7030 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7031 Now static.
7032 (file_name_as_directory): Use const pointers when appropriate.
7033 (Fexpand_file_name): Likewise. In particular, newdir might
7034 point at constant storage, so make it a const pointer.
7035 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7036 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7037 signedness issues.
7038 (Fset_file_times, Finsert_file_contents, auto_save_error):
7039 Rename locals to avoid shadowing.
7040
7041 * minibuf.c (choose_minibuf_frame_1): Now static.
7042 (Ftry_completion, Fall_completions): Rename or remove locals
7043 to avoid shadowing.
7044
7045 * marker.c (bytepos_to_charpos): Remove; unused.
7046
7047 * lisp.h (verify_bytepos, count_markers): New decls,
7048 so that gcc does not warn that these functions aren't declared.
7049
7050 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7051 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7052 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7053 (copy_text): Remove unused local var.
7054
7055 * filelock.c (within_one_second): Now static.
7056 (lock_file_1): Rename local to avoid shadowing.
7057
7058 * buffer.c (fix_overlays_before): Mark locals as initialized.
7059 (fix_start_end_in_overlays): Likewise. This function should be
7060 simplified by using pointers-to-pointers, but that's a different
7061 matter.
7062 (switch_to_buffer_1): Now static.
7063 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7064 (report_overlay_modification): Rename locals to avoid shadowing.
7065
7066 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7067 Fix pointer signedness issue.
7068 (sys_subshell): Mark local as volatile if checking for lint,
7069 to suppress a gcc -Wclobbered warning that does not seem to be right.
7070 (MAXPATHLEN): Define only if needed.
7071
7072 * process.c (serial_open, serial_configure): Move decls from here ...
7073 * systty.h: ... to here, so that they can be checked.
7074
7075 * fns.c (get_random, seed_random): Move extern decls from here ...
7076 * lisp.h: ... to here, so that they can be checked.
7077
7078 * sysdep.c (reset_io): Now static.
7079 (wait_for_termination_signal): Remove; unused.
7080
7081 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7082 (copy_keymap_item, append_key, push_text_char_description):
7083 Now static.
7084 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7085 (DENSE_TABLE_SIZE): Remove; unused.
7086 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7087 (describe_map_tree):
7088 Rename locals to avoid shadowing.
7089
7090 * keyboard.c: Declare functions static if they are not used elsewhere.
7091 (echo_char, echo_dash, cmd_error, top_level_2):
7092 (poll_for_input, handle_async_input): Now static.
7093 (read_char, kbd_buffer_get_event, make_lispy_position):
7094 (make_lispy_event, make_lispy_movement, apply_modifiers):
7095 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7096 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7097 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7098 (read_key_sequence, read_char): Mark locals as initialized.
7099 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7100
7101 * keyboard.h (make_ctrl_char): New decl.
7102 (mark_kboards): Move decl here ...
7103 * alloc.c (mark_kboards): ... from here.
7104
7105 * lisp.h (force_auto_save_soon): New decl.
7106
7107 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7108 (DEFINE_DUMMY_FUNCTION): New macro.
7109 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7110 Use it.
7111 (main): Add casts to avoid warnings
7112 if GCC considers string literals to be constants.
7113
7114 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7115
7116 * dbusbind.c: Pointer signedness fixes.
7117 (xd_signature, xd_append_arg, xd_initialize):
7118 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7119 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7120 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7121 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7122
7123 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7124 if GCC considers string literals to be constants.
7125 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7126
7127 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7128
7129 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7130 (print_preprocess, print_object): New macro to fix last change.
7131
7132 * print.c (print_preprocess): Don't forget font objects.
7133
7134 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7135
7136 * emacs.c (USAGE3): Doc fixes.
7137
7138 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7139
7140 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7141 structure.
7142
7143 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7144
7145 * lisp.h (VWindow_system, Qfile_name_history):
7146 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7147 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7148 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7149
7150 * w32select.c: Don't #include "keyboard.h".
7151 (run_protected): Add extern declaration for waiting_for_input.
7152
7153 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7154 * w32console.c (detect_input_pending, read_input_pending)
7155 (encode_terminal_code):
7156 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7157 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7158 (w32_system_caret_y, Qfile_name_history):
7159 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7160 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7161 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7162 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7163 * w32proc.c (Qlocal, report_file_error):
7164 * w32term.c (Vwindow_system, updating_frame):
7165 * w32uniscribe.c (initialized, uniscribe_font_driver):
7166 Remove unneeded extern declarations.
7167
7168 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7169
7170 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7171
7172 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7173
7174 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7175 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7176 These macros can no longer be used for assignment.
7177
7178 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7179 Assign struct members directly, instead of using BUF_BEGV etc.
7180 (record_buffer_markers, fetch_buffer_markers): New functions for
7181 recording and fetching special buffer markers.
7182 (set_buffer_internal_1, set_buffer_temp): Use them.
7183
7184 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7185
7186 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7187
7188 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7189 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7190
7191 * xdisp.c (hscroll_window_tree):
7192 (reconsider_clip_changes): Use PT instead of BUF_PT.
7193
7194 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7195
7196 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7197 $(EMACS_ROOT)/lib/intprops.h.
7198
7199 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7200
7201 Fix more problems found by GCC 4.5.2's static checks.
7202
7203 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7204 to unsigned char * to avoid compiler diagnostic.
7205 (xg_free_frame_widgets): Make it clear that a local variable is
7206 needed only if USE_GTK_TOOLTIP.
7207 (gdk_window_get_screen): Make it clear that this macro is needed
7208 only if USE_GTK_TOOLTIP.
7209 (int_gtk_range_get_value): New function, which avoids a diagnostic
7210 from gcc -Wbad-function-cast.
7211 (xg_set_toolkit_scroll_bar_thumb): Use it.
7212 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7213 diagnostic from gcc -Wbad-function-cast.
7214 (get_utf8_string, xg_get_file_with_chooser):
7215 Rename locals to avoid shadowing.
7216 (create_dialog): Move locals to avoid shadowing.
7217
7218 * xgselect.c (xg_select): Remove unused var.
7219
7220 * image.c (four_corners_best): Mark locals as initialized.
7221 (gif_load): Initialize transparent_p to zero (Bug#8238).
7222 Mark another local as initialized.
7223 (my_png_error, my_error_exit): Mark with NO_RETURN.
7224
7225 * image.c (clear_image_cache): Now static.
7226 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7227 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7228 (x_edge_detection): Remove unnecessary cast that
7229 gcc -Wbad-function-cast diagnoses.
7230 (gif_load): Fix pointer signedness.
7231 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7232 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7233
7234 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7235
7236 Improve quality of tests for time stamp overflow.
7237 For example, without this patch (encode-time 0 0 0 1 1
7238 1152921504606846976) returns the obviously-bogus value (-948597
7239 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7240 reports time overflow. See
7241 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7242 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7243 * editfns.c: Include limits.h and intprops.h.
7244 (TIME_T_MIN, TIME_T_MAX): New macros.
7245 (time_overflow): Move earlier, to before first use.
7246 (hi_time, lo_time): New functions, for an accurate test for
7247 out-of-range times.
7248 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7249 (Fget_internal_run_time): Don't assume time_t fits in int.
7250 (make_time): Use list2 instead of Fcons twice.
7251 (Fdecode_time): More accurate test for out-of-range times.
7252 (check_tm_member): New function.
7253 (Fencode_time): Use it, to test for out-of-range times.
7254 (lisp_time_argument): Don't rely on undefined left-shift and
7255 right-shift behavior when checking for time stamp overflow.
7256
7257 * editfns.c (time_overflow): New function, refactoring common code.
7258 (Fformat_time_string, Fdecode_time, Fencode_time):
7259 (Fcurrent_time_string): Use it.
7260
7261 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7262 * dired.c (make_time): Move to ...
7263 * editfns.c (make_time): ... here.
7264 * systime.h: Note the move.
7265
7266 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7267
7268 * fringe.c (update_window_fringes): Remove unused variables.
7269
7270 * unexmacosx.c (copy_data_segment): Also copy __got section.
7271 (Bug#8223)
7272
7273 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7274
7275 * termcap.c [MSDOS]: Include "msdos.h".
7276 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7277 Constify `char *' arguments and their references according to
7278 prototypes in tparam.h.
7279
7280 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7281
7282 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7283 Adapt all references accordingly.
7284
7285 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7286
7287 2011-03-11 Tom Tromey <tromey@redhat.com>
7288
7289 * buffer.c (syms_of_buffer): Remove obsolete comment.
7290
7291 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7292
7293 * termhooks.h (encode_terminal_code): Declare prototype.
7294
7295 * msdos.c (encode_terminal_code): Don't declare prototype.
7296
7297 * term.c (encode_terminal_code): Now external again, used by
7298 w32console.c and msdos.c.
7299
7300 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7301 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7302
7303 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7304
7305 Fix some minor problems found by GCC 4.5.2's static checks.
7306
7307 * fringe.c (update_window_fringes): Mark locals as initialized
7308 (Bug#8227).
7309 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7310
7311 * alloc.c (mark_fringe_data): Move decl from here ...
7312 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7313 to check its interface.
7314 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7315
7316 * fontset.c (free_realized_fontset): Now static.
7317 (Fset_fontset_font): Rename local to avoid shadowing.
7318 (fontset_font): Mark local as initialized.
7319 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7320
7321 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7322
7323 * xselect.c (x_disown_buffer_selections): Remove; not used.
7324 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7325 (x_own_selection, Fx_disown_selection_internal): Rename locals
7326 to avoid shadowing.
7327 (x_handle_dnd_message): Remove local to avoid shadowing.
7328
7329 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7330 so that the caller can use some name other than gcpro1.
7331 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7332 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7333 (Fx_backspace_delete_keys_p):
7334 Use them to avoid shadowing, and rename vars to avoid shadowing.
7335 (x_decode_color, x_set_name, x_window): Now static.
7336 (Fx_create_frame): Add braces to silence GCC warning.
7337 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7338 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7339 Remove unused locals.
7340 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7341 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7342 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7343 macros.
7344
7345 * xterm.h (x_mouse_leave): New decl.
7346
7347 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7348 Remove unused functions.
7349 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7350 (x_calc_absolute_position): Now static.
7351 (XTread_socket): Don't define label "out" unless it's used.
7352 Don't declare local "event" unless it's used.
7353 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7354 unless they are used.
7355 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7356 (x_fatal_error_signal): Remove; not used.
7357 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7358 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7359 (x_error_catcher, x_connection_closed, x_error_handler):
7360 (x_error_quitter, xembed_send_message, x_iconify_frame):
7361 (my_log_handler): Rename locals to avoid shadowing.
7362 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7363 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7364
7365 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7366 Rename or move locals to avoid shadowing.
7367 (tty_defined_color, merge_face_heights): Now static.
7368 (free_realized_faces_for_fontset): Remove; not used.
7369 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7370 does not deduce is never used uninitialized.
7371 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7372 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7373
7374 * terminal.c (store_terminal_param): Now static.
7375
7376 * xmenu.c (menu_highlight_callback): Now static.
7377 (set_frame_menubar): Remove unused local.
7378 (xmenu_show): Rename parameter to avoid shadowing.
7379 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7380 since they might point to immutable storage.
7381 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7382 since it's unused otherwise.
7383
7384 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7385 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7386 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7387 avoids a gcc -Wuninitialized diagnostic.
7388 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7389 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7390 does not deduce are never used uninitialized.
7391
7392 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7393
7394 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7395 * window.c (window_loop, size_window):
7396 (run_window_configuration_change_hook, enlarge_window): Likewise.
7397
7398 * window.c (display_buffer): Now static.
7399 (size_window): Mark variables that gcc -Wuninitialized
7400 does not deduce are never used uninitialized.
7401 * window.h (check_all_windows): New decl, to forestall
7402 gcc -Wmissing-prototypes diagnostic.
7403 * dispextern.h (bidi_dump_cached_states): Likewise.
7404
7405 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7406 shadowing.
7407 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7408 Include <limits.h>.
7409 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7410 and to avoid gcc -Wuninitialized warning.
7411 (load_charset_map): Mark variables that gcc -Wuninitialized
7412 does not deduce are never used uninitialized.
7413 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7414
7415 * coding.c (coding_set_source, coding_set_destination):
7416 Use "else { /* comment */ }" rather than "else /* comment */;"
7417 for clarity, and to avoid gcc -Wempty-body warning.
7418 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7419 a block, when the outer 'i' will do.
7420 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7421 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7422 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7423 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7424 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7425 Rename locals to avoid shadowing.
7426 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7427 * coding.c (emacs_mule_char, encode_invocation_designation):
7428 Now static, since they're not used elsewhere.
7429 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7430 (decode_coding_object, encode_coding_object, detect_coding_system):
7431 (decode_coding_emacs_mule): Mark variables that gcc
7432 -Wuninitialized does not deduce are never used uninitialized.
7433 (detect_coding_iso_2022): Initialize a local variable that might
7434 be used uninitialized. Leave a FIXME because it's not clear that
7435 this initialization is needed. (Bug#8211)
7436 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7437 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7438 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7439 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7440 Remove unused macros.
7441
7442 * category.c (hash_get_category_set): Remove unused local var.
7443 (copy_category_table): Now static, since it's not used elsewhere.
7444 * character.c (string_count_byte8): Likewise.
7445
7446 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7447 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7448
7449 * chartab.c (copy_sub_char_table): Now static, since it's not used
7450 elsewhere.
7451 (sub_char_table_ref_and_range, char_table_ref_and_range):
7452 Rename locals to avoid shadowing.
7453 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7454
7455 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7456 (BIDI_BOB): Remove unused macro.
7457
7458 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7459 deduce are never used uninitialized.
7460 * term.c (encode_terminal_code): Likewise.
7461
7462 * term.c (encode_terminal_code): Now static. Remove unused local.
7463
7464 * tparam.h: New file.
7465 * term.c, tparam.h: Include it.
7466 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7467 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7468 Move these decls to tparam.h, and make them agree with what
7469 is actually in tparam.c. The previous trick of using incompatible
7470 decls in different modules does not conform to the C standard.
7471 All callers of tparam changed to use tparam's actual API.
7472 * tparam.c (tparam1, tparam, tgoto):
7473 Use const pointers where appropriate.
7474
7475 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7476 * cm.h (struct cm): Likewise.
7477 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7478 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7479 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7480 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7481 (turn_on_face, init_tty): Likewise.
7482 * termchar.h (struct tty_display_info): Likewise.
7483
7484 * term.c (term_mouse_position): Rename local to avoid shadowing.
7485
7486 * alloc.c (mark_ttys): Move decl from here ...
7487 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7488
7489 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7490
7491 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7492
7493 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7494
7495 * search.c (compile_pattern_1): Remove argument regp, unused since
7496 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7497 (compile_pattern): Don't pass it.
7498
7499 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7500
7501 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7502 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7503 for ! HAVE_GTK3.
7504 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7505
7506 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7507
7508 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7509 gdk_window_get_screen, gdk_window_get_geometry,
7510 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7511 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7512 (xg_get_pixbuf_from_pixmap): New function.
7513 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7514 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7515 Call xg_get_pixbuf_from_pixmap instead of
7516 gdk_pixbuf_get_from_drawable.
7517 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7518 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7519 (xg_check_special_colors): Use GtkStyleContext and its functions
7520 for HAVE_GTK3.
7521 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7522 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7523 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7524 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7525 Call gtk_widget_get_preferred_size.
7526 (xg_frame_resized): gdk_window_get_geometry only takes 5
7527 parameters.
7528 (xg_win_to_widget, xg_event_is_for_menubar):
7529 Call gdk_x11_window_lookup_for_display.
7530 (xg_set_widget_bg): New function.
7531 (delete_cb): New function.
7532 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7533 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7534 (xg_set_background_color): Call xg_set_widget_bg.
7535 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7536 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7537 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7538 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7539 if ! HAVE_GTK3.
7540 (update_frame_tool_bar): Call gtk_widget_hide.
7541 (xg_initialize): Use GDK_KEY_g.
7542
7543 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7544 if ! HAVE_GTK3
7545 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7546
7547 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7548 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7549 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7550
7551 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7552
7553 * w32xfns.c (select_palette): Check success of RealizePalette against
7554 GDI_ERROR, not zero.
7555
7556 See ChangeLog.11 for earlier changes.
7557
7558 ;; Local Variables:
7559 ;; coding: utf-8
7560 ;; End:
7561
7562 Copyright (C) 2011 Free Software Foundation, Inc.
7563
7564 This file is part of GNU Emacs.
7565
7566 GNU Emacs is free software: you can redistribute it and/or modify
7567 it under the terms of the GNU General Public License as published by
7568 the Free Software Foundation, either version 3 of the License, or
7569 (at your option) any later version.
7570
7571 GNU Emacs is distributed in the hope that it will be useful,
7572 but WITHOUT ANY WARRANTY; without even the implied warranty of
7573 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7574 GNU General Public License for more details.
7575
7576 You should have received a copy of the GNU General Public License
7577 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.