1 2011-09-24 Jim Meyering <meyering@redhat.com>
3 do not ignore write error for any output size
4 The previous change was incomplete.
5 While it makes emacs --batch detect the vast majority of stdout
6 write failures, errors were still ignored whenever the output size is
7 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
8 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
9 && echo FAIL: ignored write error
10 FAIL: ignored write error
11 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
12 && echo FAIL: ignored write error
13 FAIL: ignored write error
14 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
16 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
18 * emacs.c (Fkill_emacs): In noninteractive mode exit
19 non-successfully if a write error occurred on stdout. (Bug#9574)
21 2011-09-21 Eli Zaretskii <eliz@gnu.org>
23 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
26 * dispextern.h (struct it): Update the comment documenting what
29 2011-09-20 Eli Zaretskii <eliz@gnu.org>
31 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
32 a display string, extend search for cursor position to end of row.
33 (find_row_edges): If the row ends in a newline from a display
34 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
35 Handle the case of a display string with multiple newlines.
36 (Fcurrent_bidi_paragraph_direction): Fix search for previous
37 non-empty line. Fixes confusing cursor motion with arrow keys at
38 the beginning of a line that starts with whitespace.
40 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
42 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
45 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
47 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
50 2011-09-18 Eli Zaretskii <eliz@gnu.org>
52 * xdisp.c (display_line): Record maximum and minimum buffer
53 positions even if no glyphs were produced (e.g., by a zero-width
54 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
55 buffer positions that will be removed from the glyph row because
57 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
58 column is beyond frame width: don't subtract 1 "pixel" when
59 computing width of the stretch.
60 (reseat_at_next_visible_line_start): Undo the change made on
61 2011-09-17 that saved paragraph information and restored it after
62 the call to `reseat'. (Bug#9545)
64 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
66 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
67 and turn window cursor on if cleared (Bug#9415).
69 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
71 * search.c (boyer_moore): Take unibyte characters from pattern
74 2011-09-18 Eli Zaretskii <eliz@gnu.org>
76 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
78 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
80 Fix minor problem found by static checking.
81 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
82 initialized, to pacify gcc -Wuninitialized.
84 * fileio.c: Report proper errno when syscall falls.
85 (Finsert_file_contents): Save and restore errno,
86 so that report_file_error outputs the correct diagnostic.
87 (Fwrite_region) [CLASH_DETECTION]: Likewise.
89 2011-09-18 Eli Zaretskii <eliz@gnu.org>
91 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
93 2011-09-17 Eli Zaretskii <eliz@gnu.org>
95 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
96 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
98 2011-09-17 Eli Zaretskii <eliz@gnu.org>
100 * xdisp.c (reseat_at_next_visible_line_start): Keep information
101 about the current paragraph and restore it after the call to
104 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
105 (bidi_find_paragraph_start): Search back for paragraph beginning
106 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
107 (bidi_move_to_visually_next): Only trigger paragraph-related
108 computations when the last character is a newline or at EOB, not
109 just any NEUTRAL_B. (Bug#9470)
111 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
112 truncated lines if point is covered by a display string. (Bug#9524)
114 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
116 * xselect.c: Relax test for outgoing X longs (Bug#9498).
117 (cons_to_x_long): New function.
118 (lisp_data_to_selection_data): Use it. Correct the test for
119 short-versus-long data; it was negated. Break out of vector
120 loop, for efficiency, when a long datum is discovered.
122 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
124 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
126 2011-09-16 Eli Zaretskii <eliz@gnu.org>
128 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
129 GCC PR/17406) by declaring this function with external scope.
131 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
133 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
134 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
136 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
138 * editfns.c (Fformat): Correctly handle text properties on "%%".
140 2011-09-15 Eli Zaretskii <eliz@gnu.org>
142 * xterm.c (x_draw_composite_glyph_string_foreground):
143 * w32term.c (x_draw_composite_glyph_string_foreground):
144 * term.c (encode_terminal_code):
145 * composite.c (composition_update_it, get_composition_id):
146 * xdisp.c (get_next_display_element)
147 (fill_composite_glyph_string): Add comments about special meaning
148 of TAB characters in a composition.
150 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
152 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
153 This occurs when processing a multibyte format.
154 Problem reported by Wolfgang Jenker.
156 2011-09-15 Johan Bockgård <bojohan@gnu.org>
158 * xdisp.c (try_cursor_movement): Only check for exact match if
159 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
161 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
163 Remove unused external symbols.
164 * dispextern.h (calc_pixel_width_or_height): Remove decl.
165 * xdisp.c (calc_pixel_width_or_height): Now static.
166 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
167 * indent.c (check_display_width):
168 * w32term.c: Fix comment to match code.
169 * xterm.c, xterm.h (x_catching_errors): Remove.
171 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
173 * xselect.c: Use signed conversions more consistently (Bug#9498).
174 (selection_data_to_lisp_data): Assume incoming selection data are
175 signed integers, not unsigned. This is to be consistent with
176 outgoing selection data, which was modified to use signed integers
177 in as part of the fix to Bug#9196 in response to Jan D.'s comment
178 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
179 expects long, not unsigned long.
181 2011-09-14 Eli Zaretskii <eliz@gnu.org>
183 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
184 computation of loop end. Reported by Johan Bockgård
187 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
189 * frame.c (Fother_visible_frames_p): Function deleted.
191 2011-09-12 Eli Zaretskii <eliz@gnu.org>
193 * indent.c (compute_motion): Process display vector front to back
194 rather than the other way around. (Bug#2496)
196 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
198 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
200 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
202 * minibuf.c (Fread_from_minibuffer): Doc fix.
204 2011-09-11 Eli Zaretskii <eliz@gnu.org>
206 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
207 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
209 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
211 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
212 value for non-existent files.
214 2011-09-11 Eli Zaretskii <eliz@gnu.org>
216 * fileio.c (Finsert_file_contents): If the file cannot be opened,
217 set its "size" to -1. This will set the modtime_size field of
218 the corresponding buffer to -1, which is what
219 verify-visited-file-modtime expects for files that do not exist.
222 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
224 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
226 * lisp.h: ... from here. push_key_description is no longer
227 defined in keyboard.c, so its declaration should not be in
228 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
229 logically belongs with push_key_description.
231 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
233 * buffer.h: Include <sys/types.h> instead of <time.h>.
234 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
235 Problem reported by Herbert J. Skuhra.
237 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
239 * xml.c (parse_region): Make the parsing work for
240 non-comment-starting XML files again (bug#9144).
242 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
244 * image.c (gif_load): Fix calculation of bottom and right corner.
247 2011-09-10 Eli Zaretskii <eliz@gnu.org>
249 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
250 redisplay in small windows.
252 2011-09-09 Eli Zaretskii <eliz@gnu.org>
254 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
256 2011-09-08 Martin Rudalics <rudalics@gmx.at>
258 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
259 Operate on live windows only.
261 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
263 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
265 2011-09-07 Eli Zaretskii <eliz@gnu.org>
267 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
268 only under bidi iteration.
270 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
272 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
274 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
276 isnan: Fix porting problem to Solaris 10 with bundled gcc.
277 Without this fix, the command to link temacs failed due to an
278 undefined symbol __builtin_isnan. This is because
279 /usr/include/iso/math_c99.h #defines isnan(x) to
280 __builtin_isnan(x), but the bundled gcc, which identifies itself
281 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
283 * floatfns.c (isnan): #undef, and then #define to a clone of
285 (Fisnan): Always define, since it's always available now.
286 (syms_of_floatfns): Always define isnan at the Lisp level.
288 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
290 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
292 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
294 * fileio.c: Fix bugs with large file offsets (Bug#9428).
295 The previous code assumed that file offsets (off_t values) fit in
296 EMACS_INT variables, which is not true on typical 32-bit hosts.
297 The code messed up by falsely reporting buffer overflow in cases
298 such as (insert-file-contents "big" nil 1 2) into an empty buffer
299 when "big" contains more than 2**29 bytes, even though this
300 inserts just one byte and does not overflow the buffer.
301 (Finsert_file_contents): Store file offsets as off_t
302 values, not as EMACS_INT values. Check for overflow when
303 converting between EMACS_INT and off_t. When checking for
304 buffer overflow or for overlap, take the offsets into account.
305 Don't use EMACS_INT for small values where int suffices.
306 When checking for overlap, fix a typo: ZV was used where
307 ZV_BYTE was intended.
308 (Fwrite_region): Don't assume off_t fits into 'long'.
309 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
311 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
313 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
315 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
317 sprintf-related integer and memory overflow issues (Bug#9412).
319 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
320 (esprintf, exprintf, evxprintf): New functions.
321 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
322 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
323 (modify_event_symbol): Do not assume that the length of
324 name_alist_or_stem is safe to alloca and fits in int.
325 (Fexecute_extended_command): Likewise for function name and binding.
326 (Frecursion_depth): Wrap around reliably on integer overflow.
327 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
328 since some callers pass EMACS_INT values.
329 (Fsingle_key_description): Don't crash if symbol name contains more
330 than MAX_ALLOCA bytes.
331 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
332 (get_minibuffer): Arg is now EMACS_INT, not int.
333 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
334 (esprintf, exprintf, evxprintf): New decls.
335 * window.h (command_loop_level, minibuf_level): Reflect API changes.
337 * dbusbind.c (signature_cat): New function.
338 (xd_signature, Fdbus_register_signal):
339 Do not overrun buffer; instead, report string overflow.
341 * dispnew.c (add_window_display_history): Don't overrun buffer.
342 Truncate instead; this is OK since it's just a log.
344 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
345 even if the time zone offset is outlandishly large.
346 Don't mishandle offset == INT_MIN.
348 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
349 when creating daemon; the previous buffer-overflow check was incorrect.
351 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
352 which has the guts of the old verror function.
354 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
355 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
357 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
358 (font_unparse_xlfd): Don't blindly alloca long strings.
359 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
360 fits in int, when using sprintf. Use single snprintf to count
361 length of string rather than counting it via multiple sprintfs;
362 that's simpler and more reliable.
363 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
364 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
365 sprintf, in case result does not fit in int.
367 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
368 (fontset_from_font): Print it.
370 * frame.c (tty_frame_count): Now printmax_t, not int.
371 (make_terminal_frame, set_term_frame_name): Print it.
372 (x_report_frame_params): In X, window IDs are unsigned long,
373 not signed long, so print them as unsigned.
374 (validate_x_resource_name): Check for implausibly long names,
375 and don't assume name length fits in 'int'.
376 (x_get_resource_string): Don't blindly alloca invocation name;
377 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
380 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
381 (xg_check_special_colors, xg_set_geometry):
382 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
384 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
385 Use esprintf, not sprintf, in case result does not fit in int.
387 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
388 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
389 it as a large positive number.
390 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
391 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
393 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
394 in case result does not fit in int.
396 * print.c (float_to_string): Detect width overflow more reliably.
397 (print_object): Make sprintf buffer a bit bigger, to avoid potential
398 buffer overrun. Don't assume list length fits in 'int'. Treat
399 print length of 0 as 0, not as infinity; to be consistent with other
400 uses of print length in this function. Don't overflow print length
401 index. Don't assume hash table size fits in 'long', or that
402 vectorlike size fits in 'unsigned long'.
404 * process.c (make_process): Use printmax_t, not int, to format
405 process-name gensyms.
407 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
409 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
410 to avoid potential buffer overrun.
412 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
413 if X resource line is longer than 512 bytes.
415 * xfns.c (x_window): Make sprintf buffer a bit bigger
416 to avoid potential buffer overrun.
418 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
420 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
422 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
424 Integer overflow fixes for scrolling, etc.
425 Without these, Emacs silently mishandles large integers sometimes.
426 For example, "C-u 4294967297 M-x recenter" was treated as if
427 it were "C-u 1 M-x recenter" on a typical 64-bit host.
429 * xdisp.c (try_window_id): Check Emacs fixnum range before
432 * window.c (window_scroll_line_based, Frecenter):
433 Check that an Emacs fixnum is in range before assigning it to 'int'.
434 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
435 values converted from Emacs fixnums.
436 (Frecenter): Don't wrap around a line count if it is out of 'int'
437 range; instead, treat it as an extreme value.
438 (Fset_window_configuration, compare_window_configurations):
439 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
441 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
442 that can exceed INT_MAX. Check that EMACS_INT value is in range
443 before assigning it to the (possibly-narrower) index.
444 (match_limit): Don't assume that a fixnum can fit in 'int'.
446 * print.c (print_object): Use ptrdiff_t, not int, for index that can
449 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
450 (Fvertical_motion): Don't wrap around LINES values that don't fit
451 in 'int'. Instead, treat them as extreme values. This is good
452 enough for windows, which can't have more than INT_MAX lines anyway.
454 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
456 * Require libxml/parser.h to avoid compilation warning.
458 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
460 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
461 since this reportedly can destroy thread storage.
463 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
465 * syntax.c (find_defun_start): Update all cache variables if
466 exiting early (Bug#9401).
468 2011-08-30 Eli Zaretskii <eliz@gnu.org>
470 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
472 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
473 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
474 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
476 * term.c (tty_append_glyph): New function.
477 (produce_stretch_glyph): Static function and its prototype deleted.
479 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
482 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
484 * image.c (parse_image_spec): Check for nonnegative, not for positive,
485 when checking :margin (Bug#9390).
486 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
487 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
488 so that the name doesn't mislead. All uses changed.
490 2011-08-28 Johan Bockgård <bojohan@gnu.org>
492 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
495 2011-08-27 Eli Zaretskii <eliz@gnu.org>
497 * xdisp.c (move_it_to): Don't bail out early when reaching
498 position beyond to_charpos, if we are scanning backwards.
499 (move_it_vertically_backward): When DY == 0, make sure we get to
500 the first character in the line after the newline.
502 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
504 * ccl.c: Improve and simplify overflow checking (Bug#9196).
505 (ccl_driver): Do not generate an out-of-range pointer.
506 (Fccl_execute_on_string): Remove unnecessary check for
507 integer overflow, noted by Stefan Monnier in
508 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
509 Remove a FIXME that didn't need fixing.
510 Simplify the newly-introduced buffer reallocation code.
512 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
514 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
516 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
518 Integer and memory overflow issues (Bug#9196).
520 * doc.c (get_doc_string): Rework so that
521 get_doc_string_buffer_size is the actual buffer size, rather than
522 being 1 less than the actual buffer size; this makes xpalloc more
525 * image.c (x_allocate_bitmap_record, cache_image):
526 * xselect.c (Fx_register_dnd_atom):
527 Simplify previous changes by using xpalloc.
529 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
530 since either will do and ptrdiff_t is convenient with xpalloc.
532 * charset.c (charset_table_size)
533 (struct charset_sort_data.priority): Now ptrdiff_t.
534 (charset_compare): Don't overflow if priorities differ greatly.
535 (Fsort_charsets): Don't assume list length fits in int.
536 Check for size-calculation overflow when allocating sort data.
537 (syms_of_charset): Allocate an initial charset table that is
538 just under 64 KiB, to avoid problems with glibc malloc and mmap.
540 * cmds.c (internal_self_insert): Check for size-calculation overflow.
542 * composite.h (struct composition.glyph_len): Now int, not unsigned.
543 The actual value is always <= INT_MAX, and leaving it unsigned made
544 overflow checking harder.
546 * dispextern.h (struct glyph_matrix.rows_allocated)
547 (struct face_cache.size): Now ptrdiff_t, for convenience in use
548 with xpalloc. The values are still always <= INT_MAX.
550 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
552 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
553 (SAFE_NALLOCA): New macro.
555 * region-cache.c (struct boundary.pos, find_cache_boundary)
556 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
557 (set_cache_region, invalidate_region_cache)
558 (revalidate_region_cache, know_region_cache, region_cache_forward)
559 (region_cache_backward, pp_cache):
560 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
561 so that ptrdiff_t * can be passed to xpalloc.
562 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
563 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
564 (pp_cache): Don't assume cache_len fits in int.
565 * region-cache.h: Adjust extern decls to match.
567 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
568 EMACS_INT, since either will do, for xpalloc.
570 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
571 (xnmalloc, xnrealloc, xpalloc): New functions.
573 * bidi.c (bidi_shelve_header_size): New constant.
574 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
575 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
577 * bidi.c (bidi_cache_shrink):
578 * buffer.c (overlays_at, overlays_in, record_overlay_string)
580 Don't update size of array until after memory allocation succeeds,
581 because xmalloc/xrealloc may not return.
582 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
583 now that we have proper integer overflow checking.
584 (record_overlay_string, overlay_strings): Catch overflows when
585 calculating size of overlay_str_buf.
587 * callproc.c (Fcall_process): Check for size overflow when
588 calculating size of args2.
589 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
590 Normally we prefer signed values, but sticking with ptrdiff_t would
591 require adding more-complicated checks.
593 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
594 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
595 Redo buffer-overflow calculations to avoid integer overflow.
596 Add a FIXME comment where memory seems to be over-allocated.
598 * character.c (Fstring): Check for size-calculation overflow.
600 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
601 unnecessary integer overflow. Check for size overflow.
602 (encode_coding_object): Don't update size until xmalloc succeeds.
604 * composite.c (get_composition_id): Check for overflow in glyph
607 Integer and memory overflow fixes for display code.
608 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
609 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
610 (scrolling_window): Check for overflow in size calculations.
611 (line_draw_cost, realloc_glyph_pool, add_row_entry):
612 Don't assume glyph table len fits in int.
613 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
614 (row_table_size): Now ptrdiff_t, not int.
615 (scrolling_window): Avoid overflow in size calculations.
616 Don't update size until allocation succeeds.
617 * fns.c (concat): Check for overflow in size calculations.
618 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
619 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
620 (NEXT_ALMOST_PRIME_LIMIT): New constant.
622 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
623 (get_doc_string): Check for size calculation overflow.
624 Don't update size until allocation succeeds.
625 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
626 EMACS_INT, where ptrdiff_t will do.
627 (Fsubstitute_command_keys): Check for string overflow.
629 * editfns.c (set_time_zone_rule): Don't assume environment length
631 (message_length): Now ptrdiff_t, not int.
632 (Fmessage_box): Don't update size until allocation succeeds.
633 Don't assume message length fits in int.
634 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
636 * emacs.c (main): Do not reallocate argv, since there is a null at
637 the end that can be overwritten, and this way there's no need to
638 worry about size-calculation overflow.
639 (sort_args): Check for size-calculation overflow.
641 * eval.c (init_eval_once, grow_specpdl): Don't update size until
643 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
645 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
646 (x_set_scroll_bar_width, x_figure_window_size):
647 Check for integer overflow.
648 (x_set_alpha): Do not assume XINT fits in int.
650 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
651 This is for the members text_lines, text_cols, total_lines, total_cols,
652 where the system imposes an 'int' limit.
654 * fringe.c (Fdefine_fringe_bitmap):
655 Don't update size until alloc works.
657 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
658 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
660 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
661 Check for size-calculation overflow.
662 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
663 do, as we prefer signed integers.
664 (id_to_widget.max_size, id_to_widget.used)
665 (xg_store_widget_in_map, xg_remove_widget_from_map)
666 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
667 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
668 Use and return ptrdiff_t, not int.
669 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
670 * gtkutil.h: Change prototypes to match the above.
672 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
673 are duplicate now that they've been promoted to lisp.h.
674 (x_allocate_bitmap_record, x_alloc_image_color)
675 (make_image_cache, cache_image, xpm_load):
676 Don't update size until alloc is done.
677 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
679 Check for size calculation overflow.
680 (ct_colors_allocated_max): New constant.
681 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
684 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
685 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
686 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
687 Use ptrdiff_t, not int, to count maps.
688 (read_char_minibuf_menu_prompt): Check for overflow in size
689 calculations. Don't update size until allocation succeeds. Redo
690 calculations to avoid overflow.
691 * keyboard.h: Change prototypes to match the above.
693 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
695 (current_minor_maps): Check for size calculation overflow.
696 * keymap.h: Change prototypes to match the above.
698 * lread.c (read1, init_obarray): Don't update size until alloc done.
700 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
701 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
703 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
704 Now ptrdiff_t, not int.
705 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
706 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
708 * process.c (Fnetwork_interface_list): Check for overflow
711 * region-cache.c (move_cache_gap): Check for size calculation overflow.
713 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
714 overflow. Don't bother calling xmalloc when xrealloc will do.
716 * search.c (Freplace_match): Check for size calculation overflow.
717 (Fset_match_data): Don't assume list lengths fit in 'int'.
719 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
720 for command line length. Do not attempt to address one before the
721 beginning of an array, as that's not portable.
723 * term.c (max_frame_lines): Remove; unused.
724 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
726 (encode_terminal_code, calculate_costs): Check for size
727 calculation overflow.
728 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
729 table lengths and related sizes. Don't update size until alloc
730 done. Redo calculations to avoid overflow.
731 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
733 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
734 subtracting pointers.
735 (gobble_line): Check for overflow more carefully. Don't update size
738 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
739 Don't update size until alloc done.
740 Redo size calculations to avoid overflow.
741 Check for size calculation overflow.
742 (main) [DEBUG]: Fix typo in invoking tparam1.
744 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
745 Use ptrdiff_t, not int, for sizes.
746 (store_mode_line_noprop_char): Don't update size until alloc done.
748 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
749 Use ptrdiff_t, not int, for sizes.
750 (Finternal_make_lisp_face, cache_face):
751 Check for size calculation overflow.
752 (cache_face): Treat size calculation overflows as if they were
753 memory exhaustion (the usual treatment), rather than aborting.
755 * xfns.c (x_encode_text, x_set_name_internal)
756 (Fx_change_window_property): Use ptrdiff_t, not int, to count
757 sizes, since they can exceed INT_MAX in size. Check for size
758 calculation overflow.
760 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
761 (xg_select): Check for size calculation overflow.
762 Don't update size until alloc done.
764 * xrdb.c (get_environ_db): Don't assume path length fits in int,
765 as sprintf is limited to int lengths.
767 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
768 (X_LONG_MIN): New macros.
769 Use them to make the following changes clearer.
770 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
771 This change doesn't affect the value now, but it may help remind
772 future maintainers not to raise the value too much later.
773 (SELECTION_QUANTUM): Remove, replacing with ...
774 (selection_quantum): ... new function, which avoids overflow.
776 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
777 assumption that selection length fits in 'int'.
778 (x_reply_selection_request, x_handle_selection_request)
779 (x_get_window_property, receive_incremental_selection)
780 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
781 (lisp_data_to_selection_data, clean_local_selection_data):
782 Use ptrdiff_t, not int, to record length of selection.
783 (x_reply_selection_request, x_get_window_property)
784 (receive_incremental_selection, x_property_data_to_lisp):
785 Redo calculations to avoid overflow.
786 (x_reply_selection_request): When sending hint, ceiling it at
787 X_LONG_MAX rather than relying on wraparound overflow to send
789 (x_get_window_property, receive_incremental_selection)
790 (lisp_data_to_selection_data, x_property_data_to_lisp):
791 Check for size-calculation overflow.
792 (x_get_window_property, receive_incremental_selection)
793 (lisp_data_to_selection_data, Fx_register_dnd_atom):
794 Don't store size until memory allocation succeeds.
795 (x_get_window_property): Plug memory leak on memory exhaustion.
796 Don't double-block input; malloc is safe here. Don't assume 2**34
797 - 4 fits in unsigned long. Add an xassert to check
798 XGetWindowProperty overflow. Be more careful about overflow
799 calculations, and distinguish size from memory overflow better.
800 (receive_incremental_selection): When tracing, don't assume
801 unsigned int is less than INT_MAX.
802 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
803 harmful) conversions of unsigned short to int.
804 (lisp_data_to_selection_data): Don't assume that integers
805 in the range -65535 through -1 fit in an X unsigned short.
806 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
807 result parameters unless successful. Rely on cons_to_unsigned
808 to report problems with elements; the old code wasn't right anyway.
809 (x_check_property_data): Check for int overflow; we cannot use
810 a wider type due to X limits.
811 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
813 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
815 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
816 (x_term_init): Check for size calculation overflow.
817 (x_color_cells): Don't store size until memory allocation succeeds.
818 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
819 Don't assume alloca size is less than MAX_ALLOCA.
820 (x_term_init): Don't assume length fits in int (sprintf is limited
823 Use ptrdiff_t for composition IDs.
824 * character.c (lisp_string_width):
825 * composite.c (composition_table_size, n_compositions)
826 (get_composition_id, composition_gstring_from_id):
827 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
828 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
829 * window.c (Frecenter):
830 Use ptrdiff_t, not int, for composition IDs.
831 * composite.c (get_composition_id): Check for integer overflow.
832 * composite.h: Adjust prototypes to match the above changes.
834 Use ptrdiff_t for hash table indexes.
835 * category.c (hash_get_category_set):
836 * ccl.c (ccl_driver):
837 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
838 * coding.c (coding_system_charset_list, detect_coding_system):
839 * coding.h (struct coding_system.id):
840 * composite.c (get_composition_id, gstring_lookup_cache):
841 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
842 * image.c (xpm_get_color_table_h):
843 * lisp.h (hash_lookup, hash_put):
844 * minibuf.c (Ftest_completion):
845 Use ptrdiff_t for hash table indexes, not int (which is too
846 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
847 32-bit --with-wide-int hosts).
849 * charset.c (Fdefine_charset_internal): Check for integer overflow.
850 Add a FIXME comment about memory leaks.
851 (syms_of_charset): Don't assume xmalloc returns.
853 Don't assume that stated character widths fit in int.
854 * character.c (Fchar_width, c_string_width, lisp_string_width):
855 * character.h (CHAR_WIDTH):
856 * indent.c (MULTIBYTE_BYTES_WIDTH):
857 Use sanitize_char_width to avoid undefined and/or bad behavior
858 with outlandish widths.
859 * character.h (sanitize_tab_width): Renamed from sanitize_width,
860 now that we have two such functions. All uses changed.
861 (sanitize_char_width): New inline function.
863 Don't assume that tab-width fits in int.
864 * character.h (sanitize_width): New inline function.
865 (SANE_TAB_WIDTH): New macro.
866 (ASCII_CHAR_WIDTH): Use it.
867 * indent.c (sane_tab_width): Remove. All uses replaced by
868 SANE_TAB_WIDTH (current_buffer).
869 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
871 * fileio.c: Integer overflow issues with file modes.
872 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
874 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
875 Remove unreachable code.
876 (read_hex, load_charset_map_from_file): Check for integer overflow.
878 * xterm.c: don't go over XClientMessageEvent limit
879 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
880 (x_send_scroll_bar_event): Likewise. Check that the size does not
881 exceed limits imposed by XClientMessageEvent, as well as the usual
882 ptrdiff_t and size_t limits.
884 * keyboard.c: Overflow, signedness and related fixes.
885 (make_lispy_movement): Use same integer type in forward decl
886 that is used in the definition.
887 (read_key_sequence, keyremap_step):
888 Change bufsize argument back to int, undoing my 2011-03-30 change.
889 We prefer signed types, and int is wide enough here.
890 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
891 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
892 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
893 length, not size_t. Use ptrdiff_t for index, not int.
894 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
895 possibility of integer overflow.
897 Overflow, signedness and related fixes for images.
899 * dispextern.h (struct it.stack[0].u.image.image_id)
900 (struct_it.image_id, struct image.id, struct image_cache.size)
901 (struct image_cache.used, struct image_cache.ref_count):
902 * gtkutil.c (update_frame_tool_bar):
903 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
904 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
905 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
906 * nsmenu.m (update_frame_tool_bar):
907 * xdisp.c (calc_pixel_width_or_height):
908 * xfns.c (image_cache_refcount):
909 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
910 on typical 64-bit hosts.
912 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
913 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
914 Omit unnecessary casts to int.
915 (parse_image_spec): Check that integers fall into 'int' range
916 when the callers expect that.
917 (image_ascent): Redo ascent calculation to avoid int overflow.
918 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
919 (lookup_image): Remove unnecessary tests.
920 (xbm_image_p): Locals are now of int, not EMACS_INT,
921 since parse_image_check makes sure they fit into int.
922 (png_load, gif_load, svg_load_image):
923 Prefer int to unsigned where either will do.
924 (tiff_handler): New function, combining the cores of the
925 old tiff_error_handler and tiff_warning_handler. This
926 function is rewritten to use vsnprintf and thereby avoid
927 stack buffer overflows. It uses only the features of vsnprintf
928 that are common to both POSIX and native Microsoft.
929 (tiff_error_handler, tiff_warning_handler): Use it.
930 (tiff_load, gif_load, imagemagick_load_image):
931 Don't assume :index value fits in 'int'.
932 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
933 (imagemagick_load_image): Check that crop parameters fit into
934 the integer types that MagickCropImage accepts. Don't assume
935 Vimagemagick_render_type has a nonnegative value. Don't assume
936 size_t fits in 'long'.
937 (gs_load): Use printmax_t to print the widest integers possible.
938 Check for integer overflow when computing image height and width.
940 2011-08-26 Eli Zaretskii <eliz@gnu.org>
942 * xdisp.c (redisplay_window): Don't force window start if point
943 will be invisible in the resulting window. (Bug#9324)
945 2011-08-25 Eli Zaretskii <eliz@gnu.org>
947 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
948 the display spec is of the form `(space ...)'.
949 (handle_display_spec): Return the value returned by
950 handle_single_display_spec, not just 1 or zero.
951 (handle_single_display_spec): If the display spec is of the form
952 `(space ...)', and specifies display in the text area, return 2
954 (try_cursor_movement): Check for the need to scroll more
955 accurately, and prefer exact match for point under bidi. Don't
956 advance `row' beyond the last row of the window.
958 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
959 into disp_prop; all users changed.
961 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
962 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
963 for the text covered by the display property.
965 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
967 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
968 Change return value to nil.
969 (Frecord_buffer): Delete unused function.
971 2011-08-24 Eli Zaretskii <eliz@gnu.org>
973 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
974 buffers, return left-to-right.
975 (set_cursor_from_row): Consider candidate row a win if its glyph
976 represents a newline and point is on that newline. Fixes cursor
977 positioning on the newline at EOL of R2L text within L2R
978 paragraph, and vice versa.
979 (try_cursor_movement): Check continued rows, in addition to
980 continuation rows. Fixes unwarranted scroll when point enters a
981 continued line of R2L text within an L2R paragraph, or vice versa.
982 (cursor_row_p): Consider the case of point being equal to
983 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
984 from the end of a short line to the beginning of a continued line
985 of R2L text within L2R paragraph.
986 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
989 * bidi.c (bidi_check_type): Use xassert.
990 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
993 2011-08-23 Eli Zaretskii <eliz@gnu.org>
995 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
998 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1000 * nsfont.m (ns_otf_to_script): Fix typo.
1002 2011-08-22 Kenichi Handa <handa@m17n.org>
1004 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1005 extra slot even if the purpose is char-code-property-table.
1007 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1009 * xdisp.c (redisplay_window): When computing centering_position,
1010 account for the height of the header line. (Bug#8874)
1012 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1013 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1014 candidate is selected by the mouse, and that candidate has a
1015 composed character under the mouse.
1017 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1018 coordinates reported by pos-visible-in-window-p for a composed
1019 character in column zero.
1021 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1023 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1025 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1027 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1028 consider it a hit if to_charpos is anywhere in the range of the
1029 composed buffer positions.
1031 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1033 * image.c (gif_load): Don't assume that each subimage has the same
1034 dimensions as the base image. Handle disposal method that is
1035 "undefined" by the gif spec (Bug#9335).
1037 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1039 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1040 (Fcondition_case): Document `debug' symbol in error handler.
1042 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1044 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1045 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1046 from an Org mode buffer to a Speedbar frame.
1048 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1049 a composition, take its buffer position from IT->cmp_it.charpos.
1050 Fixes cursor positioning at the beginning of a line that begins
1051 with a composed character.
1053 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1055 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1056 character bidirectional type, use STRONG_L instead. Fixes crashes
1057 in a buffer produced by `describe-categories'.
1059 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1060 members before the level stack, so they would be saved and
1061 restored when copying iterator state. Fixes incorrect reordering
1062 around TABs covered by display properties.
1064 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1066 * process.c (Fnetwork_interface_list): Correctly determine buffer
1069 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1071 * eval.c (internal_condition_case, internal_condition_case_1)
1072 (internal_condition_case_2, internal_condition_case_n):
1073 Remove unnecessary aborts (Bug#9081).
1075 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1077 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1078 has no `load' handler, try opening the file locally. (Bug#9311)
1080 2011-08-16 Ken Brown <kbrown@cornell.edu>
1082 * gmalloc.c: Expand comment.
1084 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1086 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1087 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1089 2011-08-16 Ken Brown <kbrown@cornell.edu>
1091 Fix memory allocation problems in Cygwin build (Bug#9273).
1093 * unexcw.c ( __malloc_initialized): Declare external variable.
1094 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1096 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1098 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1100 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1102 [CYGWIN] (special_realloc): New function.
1103 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1104 requests to realloc storage in the static heap.
1106 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1108 * bidi.c (bidi_initialize): Remove unused local.
1110 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1112 * biditype.h: File removed.
1114 * bidimirror.h: File removed.
1116 * deps.mk (bidi.o): Remove biditype.h and
1119 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1122 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1124 * chartab.c: Improve commentary for the uniprop_table API.
1126 * bidi.c (bidi_paragraph_init): Support zero value of
1127 bidi_ignore_explicit_marks_for_paragraph_level.
1128 (bidi_initialize): Use uniprop_table instead of including
1129 biditype.h and bidimirror.h.
1131 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1132 coordinates of the iterator when restoring from ppos_it.
1135 2011-08-14 Kenichi Handa <handa@m17n.org>
1137 * process.c (create_process): Call setup_process_coding_systems
1138 after the pid of the process is set to -1 (Bug#8162).
1140 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1142 * xdisp.c (move_it_in_display_line_to): Don't invoke
1143 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1144 ppos_it. Fixes vertical cursor motion when line beginning is
1145 covered by an image. (Bug#9296)
1147 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1149 * nsterm.h (ns_run_ascript): Declare.
1150 (NSAPP_DATA2_RUNASSCRIPT): Define.
1152 * nsfns.m (as_script, as_result, as_status): New static variables.
1153 (ns_run_ascript): New function.
1154 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1155 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1156 the event loop. Get status from as_status (Bug#7276).
1158 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1159 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1160 the event loop (Bug#7276).
1162 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1164 * gnutls.c (QCgnutls_bootprop_priority)
1165 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1166 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1167 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1168 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1169 (QCgnutls_bootprop_verify_hostname_error)
1170 (QCgnutls_bootprop_callbacks_verify): Rename from
1171 Qgnutls_bootprop_..., all uses changed.
1173 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1176 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1178 * xfaces.c (Qframe_set_background_mode): Now static.
1179 * dispextern.h (Qframe_set_background_mode): Remove decl.
1181 * process.c (Fnetwork_interface_info): Declare local only if needed.
1183 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1185 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1186 (Fnetwork_interface_list): Allocate in increments of bytes instead
1187 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1188 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1190 (struct ifflag_def): notrailers is smart on OSX.
1191 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1192 Get hardware address with getifaddrs if available.
1194 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1196 * xdisp.c (iterate_out_of_display_property): xassert that
1197 IT->position is set to within IT->object's boundaries. Break from
1198 the loop as soon as EOB is reached; avoids infloops in redisplay
1199 when IT->position is set up wrongly due to some bug.
1200 Set IT->current to match the bidi iterator unconditionally.
1201 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1202 entry. Force push_it to save on the stack the current
1203 buffer/string position, to be restored by pop_it. Fix flags in
1204 the iterator structure wrt the object coming from a display
1205 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1206 properties. (Bug#9284)
1208 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1210 * fontset.c (fontset_get_font_group): Add proper type checks.
1213 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1215 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1216 and LC_VERSION_MIN_MACOSX.
1217 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1218 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1220 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1222 * xdisp.c (forward_to_next_line_start): Allow to use the
1223 no-display-properties-and-no-overlays under bidi display.
1224 Set disp_pos in the bidi iterator to avoid searches for display
1225 properties and overlays.
1227 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1229 * editfns.c (Fset_time_zone_rule): Document relationship with the
1232 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1233 the font entity extracted from the cache (Bug#8109).
1235 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1237 * composite.c (autocmp_chars): Don't reset point. That is done by
1238 restore_point_unwind (Bug#5984).
1240 2011-08-07 Juri Linkov <juri@jurta.org>
1242 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1243 to show the arg `TIME' instead of `TIMEVAL'.
1245 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1247 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1248 display property strides EOL and includes a newline, as in
1249 longlines-mode. (Bug#9254)
1250 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1251 word-wrap under bidirectional display. (Bug#9224)
1253 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1254 is non-zero, even if the data buffer is NULL. Fixes a crash in
1255 vertical-motion with longlines-mode. (Bug#9254)
1257 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1259 * bidi.c <bidi_cache_total_alloc>: Now static.
1260 (bidi_initialize): Initialize bidi_cache_total_alloc.
1262 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1265 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1266 amount allocated this far in `bidi_cache_total_alloc'.
1267 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1268 non-zero, only free the data buffer without restoring the cache
1269 contents. All callers changed.
1271 * dispextern.h (bidi_unshelve_cache): Update prototype.
1273 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1274 (move_it_in_display_line, move_it_to)
1275 (move_it_vertically_backward, move_it_by_lines): Replace the call
1276 to xfree to an equivalent call to bidi_unshelve_cache.
1277 (move_it_in_display_line_to): Fix logic of returning
1278 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1280 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1282 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1283 came from a string character with a `cursor' property. (Bug#9229)
1285 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1287 * Makefile.in (LIB_PTHREAD): New variable.
1288 (LIBES): Add LIB_PTHREAD (Bug#9216).
1290 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1291 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1293 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1295 * regex.c (re_iswctype): Remove some redundant boolean
1298 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1300 * xterm.c (x_find_topmost_parent): New function.
1301 (x_set_frame_alpha): Find topmost parent window with
1302 x_find_topmost_parent and set the property there also (bug#9181).
1303 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1305 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1307 * callproc.c (Fcall_process): Avoid vfork clobbering
1308 the local vars buffer, coding_systems, current_dir.
1310 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1312 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1314 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1316 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1317 so that it is not optimized away.
1319 * xdisp.c (compute_display_string_pos): Remove unused local.
1321 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1323 Fix slow cursor motion and scrolling in large buffers with
1324 selective display, like Org Mode buffers. (Bug#9218)
1326 * dispextern.h (struct bidi_it): New member disp_prop_p.
1328 * xdisp.c: Remove one-slot cache of display string positions.
1329 (compute_display_string_pos): Accept an additional argument
1330 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1331 for a display string or property. If found, set DISP_PROP_P
1334 * bidi.c (bidi_fetch_char): Accept an additional argument
1335 DISP_PROP_P, and pass it to compute_display_string_pos.
1336 Only handle text covered by a display string if DISP_PROP_P is returned
1337 non-zero. All callers of bidi_fetch_char changed.
1339 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1341 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1343 2010-12-03 Don March <don@ohspite.net>
1345 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1346 last character M-[char] is translated to ESC [char] (bug#7541).
1348 2011-08-02 Kenichi Handa <handa@m17n.org>
1350 * lisp.h (uniprop_table): Extern it.
1352 * chartab.c (uniprop_table): Make it non-static.
1354 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1356 * xdisp.c (forward_to_next_line_start): Accept additional argument
1357 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1359 (reseat_at_next_visible_line_start): Use the bidi iterator state
1360 returned by forward_to_next_line_start to restore the state of
1361 it->bidi_it after backing up to previous newline. (Bug#9212)
1363 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1365 * regex.c (re_comp): Protoize.
1366 (re_exec): Fix return type.
1367 (regexec): Fix type of `ret'. (Bug#9203)
1369 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1371 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1372 This is needed if max-image-size is a floating-point number.
1374 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1376 * print.c (print_object): Print empty symbol as ##.
1378 * lread.c (read1): Read ## as empty symbol.
1380 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1382 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1383 setting frame foreground color (Bug#9175).
1384 (x_set_background_color): Likewise.
1386 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1387 contents (Bug#9176).
1388 (EmacsTooltip -init): Remove bezels and add shadows to
1391 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1392 or scroll bar (Bug#8470).
1394 * nsfont.m (nsfont_open): Remove assignment to voffset and
1395 unnecessary vars hshink, expand, hd, full_height, min_height.
1396 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1398 * nsterm.h (nsfont_info): Remove voffset field.
1400 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1402 Implement strike-through and overline on NextStep (Bug#8863).
1404 * nsfont.m (nsfont_open): Use underline position provided by font,
1405 instead of hard-coded value of 2.
1406 (nsfont_draw): Call ns_draw_text_decoration instead.
1408 * nsterm.h: Add declaration for ns_draw_text_decoration.
1410 * nsterm.m (ns_draw_text_decoration): New function for drawing
1411 underline, overline, and strike-through.
1412 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1413 ns_draw_text_decoration. Change treatment of cursor drawing to
1414 accommodate underlining, etc.
1416 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1418 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1421 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1423 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1424 Without this fix, if a signal arrives just after memory fills up,
1425 'malloc' might be invoked reentrantly.
1427 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1428 In other words, assume that every image size is allowed, on non-X
1429 hosts. This assumption is probably wrong, but it lets Emacs compile.
1431 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1433 * regex.c (re_iswctype): Convert return values to boolean.
1435 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1437 * xdisp.c (compute_display_string_pos): Don't use cached display
1438 string position if the buffer had its restriction changed.
1441 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1443 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1445 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1447 Integer signedness and overflow and related fixes. (Bug#9079)
1449 * bidi.c: Integer size and overflow fixes.
1450 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1451 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1452 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1453 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1454 (bidi_find_other_level_edge):
1455 Use ptrdiff_t instead of EMACS_INT where either will do.
1456 This works better on 32-bit hosts configured --with-wide-int.
1457 (bidi_cache_ensure_space): Check for size-calculation overflow.
1458 Use % rather than repeated addition, for better worst-case speed.
1459 Don't set bidi_cache_size until after xrealloc returns, because it
1461 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1462 (bidi_cache_ensure_space): Also check that the bidi cache size
1463 does not exceed that of the largest Lisp string or buffer. See Eli
1464 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1466 * alloc.c (__malloc_size_t): Remove.
1467 All uses replaced by size_t. See Andreas Schwab's note
1468 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1470 * image.c: Improve checking for integer overflow.
1471 (check_image_size): Assume that f is nonnull, since
1472 it is always nonnull in practice. This is one less thing to
1473 worry about when checking for integer overflow later.
1474 (x_check_image_size): New function, which checks for integer
1475 overflow issues inside X.
1476 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1477 This removes the need for a memory_full check.
1478 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1479 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1480 (xbm_read_bitmap_data): Change locals back to 'int', since
1481 their values must fit in 'int'.
1482 (xpm_load_image, png_load, tiff_load):
1483 Invoke x_create_x_image_and_pixmap earlier,
1484 to avoid much needless work if the image is too large.
1485 (tiff_load): Treat overly large images as if
1486 x_create_x_image_and_pixmap failed, not as malloc failures.
1487 (gs_load): Use x_check_image_size.
1489 * gtkutil.c: Omit integer casts.
1490 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1491 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1493 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1495 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1496 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1497 would wrongly return t on a 64-bit host.
1499 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1500 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1501 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1502 and therefore cause GCC to emit a bogus diagnostic in some cases.
1504 * image.c: Integer signedness and overflow and related fixes.
1505 This is not an exhaustive set of fixes, but it's time to
1506 record what I've got.
1507 (lookup_pixel_color, check_image_size): Remove redundant decls.
1508 (check_image_size): Don't assume that arbitrary EMACS_INT values
1509 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1510 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1511 (tiff_load, imagemagick_load_image):
1512 Check for overflow in size calculations.
1513 (x_create_x_image_and_pixmap): Remove unnecessary test for
1514 xmalloc returning NULL; that can't happen.
1515 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1516 (xpm_color_bucket): Use better integer hashing function.
1517 (xpm_cache_color): Don't possibly over-allocate memory.
1518 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1519 (gif_memory_source):
1520 Use ptrdiff_t, not int or size_t, to record sizes.
1521 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1522 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1523 either works, as we prefer signed integers.
1524 (tiff_read_from_memory, tiff_write_from_memory):
1525 Return tsize_t, not size_t, since that's what the TIFF API wants.
1526 (tiff_read_from_memory): Don't fail simply because the read would
1527 go past EOF; instead, return a short read.
1528 (tiff_load): Omit no-longer-needed casts.
1529 (Fimagemagick_types): Don't assume size fits into 'int'.
1531 Improve hashing quality when configured --with-wide-int.
1532 * fns.c (hash_string): New function, taken from sxhash_string.
1533 Do not discard information about ASCII character case; this
1534 discarding is no longer needed.
1535 (sxhash-string): Use it. Change sig to match it. Caller changed.
1536 * lisp.h: Declare it.
1537 * lread.c (hash_string): Remove, since we now use fns.c's version.
1538 The fns.c version returns a wider integer if --with-wide-int is
1539 specified, so this should help the quality of the hashing a bit.
1541 * emacs.c: Integer overflow minor fix.
1542 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1543 Define only if GNU_LINUX.
1544 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1546 * dispnew.c: Integer signedness and overflow fixes.
1547 Remove unnecessary forward decls, that were a maintenance hassle.
1548 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1550 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1551 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1552 (prepare_desired_row, line_draw_cost):
1553 Use int, not unsigned, where either works.
1554 (save_current_matrix, restore_current_matrix):
1555 Use ptrdiff_t, not size_t, where either works.
1556 (init_display): Check for overflow more accurately, and without
1557 relying on undefined behavior.
1559 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1560 Remove, replacing with the new symbols in lisp.h. All uses changed.
1561 * fileio.c (make_temp_name):
1562 * filelock.c (lock_file_1, lock_file):
1563 * xdisp.c (message_dolog):
1564 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1565 Use pMd etc. instead.
1566 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1567 replacing the pWIDE etc. symbols removed from editfns.c.
1569 * keyboard.h (num_input_events): Now uintmax_t.
1570 This is (very slightly) less likely to mess up due to wraparound.
1573 * buffer.c: Integer signedness fixes.
1574 (alloc_buffer_text, enlarge_buffer_text):
1575 Use ptrdiff_t rather than size_t when either will do, as we prefer
1578 * alloc.c: Integer signedness and overflow fixes.
1579 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1580 (__malloc_size_t): Default to size_t, not to int.
1581 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1582 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1583 Prefer ptrdiff_t to size_t when either would do, as we prefer
1585 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1586 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1587 Now const. Initialize with values that are in range even if char
1589 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1590 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1591 These functions do the right thing with sizes > 2**32.
1592 (check_depth): Now ptrdiff_t, not int.
1593 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1594 Adjust to new way of storing sizes. Check for size overflow bugs
1596 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1597 slightly wrong anyway, as it missed one instance of
1598 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1599 (refill_memory_reserve): Omit needless cast to size_t.
1600 (mark_object_loop_halt): Mark as externally visible.
1602 * xselect.c: Integer signedness and overflow fixes.
1603 (Fx_register_dnd_atom, x_handle_dnd_message):
1604 Use ptrdiff_t, not size_t, since we prefer signed.
1605 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1606 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1607 x_dnd_atoms_size and x_dnd_atoms_length.
1609 * doprnt.c: Prefer signed to unsigned when either works.
1611 * doprnt.c (doprnt):
1613 * xdisp.c (vmessage):
1614 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1615 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1616 prefer signed arithmetic to avoid comparison confusion.
1617 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1618 but is a bit tricky.
1620 Assume freestanding C89 headers, string.h, stdlib.h.
1621 * data.c, doprnt.c, floatfns.c, print.c:
1622 Include float.h unconditionally.
1623 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1624 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1625 * regex.c: Likewise for stddef.h, string.h.
1626 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1627 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1628 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1629 (STDC_HEADERS): Remove obsolete defines.
1630 * sysdep.c: Include limits.h unconditionally.
1632 Assume support for memcmp, memcpy, memmove, memset.
1633 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1634 * regex.c (memcmp, memcpy):
1635 Remove; we assume C89 now.
1637 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1638 (__malloc_safe_bcopy): Remove; no longer needed.
1640 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1641 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1642 well either way, and we prefer signed to unsigned.
1644 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1646 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1647 closes the connection while we're reading (bug#9182).
1649 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1651 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1652 are specified (Bug#9168).
1654 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1656 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1657 Found by GCC static checking and --with-wide-int on a 32-bit host.
1659 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1661 * xdisp.c (compute_display_string_pos): Fix logic of caching
1662 previous display string position. Initialize cached_prev_pos to
1663 -1. Fixes slow-down at the beginning of a buffer.
1665 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1667 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1668 for attrs[LFACE_FONTSET_INDEX].
1670 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1672 * xml.c (parse_region): Remove unused local
1673 that was recently introduced.
1675 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1677 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1678 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1680 * xdisp.c (move_it_in_display_line_to): Record the best matching
1681 position for TO_CHARPOS while scanning the line, and restore it on
1682 exit if none of the characters scanned was an exact match.
1683 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1684 when exact match is impossible due to invisible text, and the
1685 lines are truncated.
1687 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1689 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1692 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1694 Fix a significant slow-down of cursor motion with C-n, C-p,
1695 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1696 auto-repeat under bidi redisplay in fontified buffers.
1697 * xdisp.c (compute_stop_pos_backwards): New function.
1698 (next_element_from_buffer): Call compute_stop_pos_backwards to
1699 find a suitable prev_stop when we find ourselves before
1701 (reseat): Don't look for prev_stop, as that could mean a very long
1703 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1704 <cached_disp_overlay_modiff>: Cache for last found display string
1706 (compute_display_string_pos): Return the cached position if asked
1707 about the same buffer in the same area of character positions, and
1708 the buffer wasn't changed since the time the display string
1709 position was cached.
1711 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1713 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1714 is an integer, which is important for empty lines. (Bug#9149)
1716 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1718 * frame.c (Fmodify_frame_parameters): In tty case, update the
1719 default face if necessary (Bug#4238).
1721 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1723 * editfns.c (Fstring_to_char): No need to explain what a character
1724 is in the docstring (Bug#6576).
1726 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1728 * xml.c (parse_region): Make sure we always return a tree.
1730 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1732 * xml.c (parse_region): If a document contains only comments,
1735 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1737 * xml.c (make_dom): Return comments, too.
1739 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1742 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1743 and the surrounding thread.
1744 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1745 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1746 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1748 * s/openbsd.h (BROKEN_SIGIO): Define.
1749 * unexelf.c (unexec) [__OpenBSD__]:
1750 Don't update the .mdebug section of the Alpha COFF symbol table.
1752 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1754 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1757 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1759 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1760 This fixes some race conditions on the permissions of any newly
1763 * alloc.c (valid_pointer_p): Use pipe, not open.
1764 This fixes some permissions issues when debugging.
1766 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1767 If fchown fails to set both uid and gid, try to set just gid,
1768 as that is sometimes allowed. Adjust the file's mode to eliminate
1769 setuid or setgid bits that are inappropriate if fchown fails.
1771 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1773 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1774 to compare Lisp_Objects.
1775 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1776 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1777 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1779 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1781 * lread.c (read_integer): Unread even EOF character.
1782 (read1): Likewise. Properly record start position of symbol.
1784 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1785 symbol character follows.
1787 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1789 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1790 This works around a problem with the previous change to Fcopy_file.
1791 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1792 and without this change, GCC might complain about discarding
1793 fchown's return value.
1795 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1797 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1799 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1801 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1803 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1805 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1806 it's used from the C level.
1808 * process.c: Use the same condition for POLL_FOR_INPUT in both
1809 keyboard.c and process.c (bug#1858).
1811 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1813 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1814 (Fgnutls_boot): Use it.
1816 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1818 * doc.c (Fsubstitute_command_keys): Revert last change.
1820 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1822 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1823 quotes the next character, and doesn't affect other longer
1824 sequences (bug#8935).
1826 * lread.c (syms_of_lread): Clarify that is isn't only
1827 `eval-buffer' and `eval-defun' that's affected by
1828 `lexical-binding' (bug#8460).
1830 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1832 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1833 bidi redisplay when a line includes both an image and is
1836 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1838 Fix minor problems found by static checking.
1839 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1840 (elsz): Now a signed constant, not a size_t var. We prefer signed
1841 types to unsigned, to avoid integer comparison confusion. Without
1842 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1843 "cannot optimize loop, the loop counter may overflow", a symptom
1845 * indent.c (Fvertical_motion): Mark locals as initialized.
1846 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1848 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1850 * search.c (Fre_search_backward): Mention `case-fold-search' in
1851 all the re_search_* functions (bug#8138).
1853 * keyboard.c (Fopen_dribble_file): Document when the file is
1856 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1858 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1861 Support bidi reordering of display and overlay strings.
1862 * xdisp.c (compute_display_string_pos)
1863 (compute_display_string_end): Accept additional argument STRING.
1864 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1865 (reseat_to_string): Initialize bidi_it->string.s and
1866 bidi_it->string.schars.
1867 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1868 NULL (avoids a crash in bidi_paragraph_init).
1869 Initialize itb.string.lstring.
1870 (init_iterator): Call bidi_init_it only of a valid
1871 buffer position was specified. Initialize paragraph_embedding to
1873 (reseat_to_string): Initialize the bidi iterator.
1874 (display_string): If we need to ignore text properties of
1875 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1876 original value of -1 will not work with bidi.)
1877 (compute_display_string_pos): First arg is now struct
1878 `text_pos *'; all callers changed. Support display properties on
1880 (compute_display_string_end): Support display properties on Lisp
1882 (init_iterator, reseat_1, reseat_to_string): Initialize the
1883 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1884 when iterating on a string not from display properties).
1885 (compute_display_string_pos, compute_display_string_end):
1886 Fix calculation of the object to scan. Fixes an error when using
1888 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1889 base_level_stop; instead, set base_level_stop to BEGV.
1890 Fixes crashes in vertical-motion.
1891 (next_element_from_buffer): Improve commentary for when
1892 the iterator is before prev_stop.
1893 (init_iterator): Initialize bidi_p from the default value of
1894 bidi-display-reordering, not from buffer-local value. Use the
1895 buffer-local value only if initializing for buffer iteration.
1896 (handle_invisible_prop): Support invisible properties on strings
1897 that are being bidi-reordered.
1898 (set_iterator_to_next): Support bidi reordering of C strings and
1900 (next_element_from_string): Support bidi reordering of Lisp
1902 (handle_stop_backwards): Support Lisp strings as well.
1903 (display_string): Support display of R2L glyph rows.
1904 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1905 (init_iterator): Don't initialize it->bidi_p for strings
1907 (reseat_to_string): Initialize it->bidi_p for strings here.
1908 (next_element_from_string, next_element_from_c_string)
1909 (next_element_from_buffer): Add xassert's for correspondence
1910 between IT's object being iterated and it->bidi_it.string
1912 (face_before_or_after_it_pos): Support bidi iteration.
1913 (next_element_from_c_string): Handle the case of the first string
1914 character that is not the first one in the visual order.
1915 (get_visually_first_element): New function, refactored from common
1916 parts of next_element_from_buffer, next_element_from_string, and
1917 next_element_from_c_string.
1918 (tool_bar_lines_needed, redisplay_tool_bar)
1919 (display_menu_bar): Force left-to-right direction. Add a FIXME
1920 comment for making that be controlled by a user option.
1921 (push_it, pop_it): Save and restore the state of the
1922 bidi iterator. Save and restore the bidi_p flag.
1923 (pop_it): Iterate out of display property for string iteration as
1925 (iterate_out_of_display_property): Support iteration over strings.
1926 (handle_single_display_spec): Set up it->bidi_it for iteration
1927 over a display string, and call bidi_init_it.
1928 (handle_single_display_spec, next_overlay_string)
1929 (get_overlay_strings_1, push_display_prop): Set up the bidi
1930 iterator for displaying display or overlay strings.
1931 (forward_to_next_line_start): Don't use the shortcut if
1933 (back_to_previous_visible_line_start): If handle_display_prop
1934 pushed the iterator stack, restore the internal state of the bidi
1935 iterator by calling bidi_pop_it same number of times.
1936 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1937 and we are bidi-iterating, don't decrement the iterator position;
1938 instead, set the first_elt flag in the bidi iterator, to produce
1940 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1941 (push_display_prop): xassert that we are iterating a buffer.
1942 (push_it, pop_it): Save and restore paragraph_embedding member.
1943 (handle_single_display_spec, next_overlay_string)
1944 (get_overlay_strings_1, reseat_1, reseat_to_string)
1945 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1946 correctly. Don't assume unibyte strings are not bidi-reordered.
1947 (compute_display_string_pos)
1948 (compute_display_string_end): Fix handling the case of C string.
1949 (push_it, pop_it): Save and restore from_disp_prop_p.
1950 (handle_single_display_spec, push_display_prop): Set the
1951 from_disp_prop_p flag.
1952 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1953 (pop_it): Call iterate_out_of_display_property only if we are
1954 popping after iteration over a string that came from a display
1955 property. Fix a typo in popping stretch info. Add an assertion
1956 for verifying that the iterator position is in sync with the bidi
1958 (handle_single_display_spec, get_overlay_strings_1)
1959 (push_display_prop): Fix initialization of paragraph direction for
1960 string when that of the parent object is not yet determined.
1961 (reseat_1): Call bidi_init_it to resync the bidi
1962 iterator with IT's position. (Bug#7616)
1963 (find_row_edges): If ROW->start.pos gives position
1964 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1965 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1966 Reset the from_disp_prop_p flag.
1967 (SAVE_IT, RESTORE_IT): New macros.
1968 (pos_visible_p, face_before_or_after_it_pos)
1969 (back_to_previous_visible_line_start)
1970 (move_it_in_display_line_to, move_it_in_display_line)
1971 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1972 (try_scrolling, redisplay_window, display_line): Use them when
1973 saving a temporary copy of the iterator and restoring it back.
1974 (back_to_previous_visible_line_start, reseat_1)
1975 (init_iterator): Empty the bidi cache "stack".
1976 (move_it_in_display_line_to): If iterator ended up at
1977 EOL, but we never saw any buffer positions smaller than
1978 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1979 motion in bidi-reordered lines.
1980 (move_it_in_display_line_to): Record prev_method and prev_pos
1981 immediately before the call to set_iterator_to_next. Fixes cursor
1982 motion in bidi-reordered lines with stretch glyphs and strings
1983 displayed in margins. (Bug#8133) (Bug#8867)
1984 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1986 (pos_visible_p): Support positions in bidi-reordered lines.
1987 Save and restore bidi cache.
1989 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1990 (bidi_paragraph_info): Delete unused struct.
1991 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1992 (bidi_cache_start): New variable.
1993 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1995 (bidi_cache_fetch_state, bidi_cache_search)
1996 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1997 (bidi_cache_find, bidi_peek_at_next_level)
1998 (bidi_level_of_next_char, bidi_find_other_level_edge)
1999 (bidi_move_to_visually_next): Compare cache index with
2000 bidi_cache_start rather than with zero.
2001 (bidi_fetch_char): Accept new argument STRING; all callers
2002 changed. Support iteration over a string. Support strings with
2003 display properties. Support unibyte strings. Fix the type of
2004 `len' according to what STRING_CHAR_AND_LENGTH expects.
2005 (bidi_paragraph_init, bidi_resolve_explicit_1)
2006 (bidi_resolve_explicit, bidi_resolve_weak)
2007 (bidi_level_of_next_char, bidi_move_to_visually_next):
2008 Support iteration over a string.
2009 (bidi_set_sor_type, bidi_resolve_explicit_1)
2010 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2011 can now be zero (for strings); special values 0 and -1 were
2012 changed to -1 and -2, respectively.
2013 (bidi_char_at_pos): New function.
2014 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2015 Call it instead of FETCH_MULTIBYTE_CHAR.
2016 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2017 initialized to valid values.
2018 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2020 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2021 the test for valid cached positions. Fix the logic for looking up
2022 the sentinel state in the cache. GCPRO the Lisp string we are
2024 (bidi_push_it, bidi_pop_it): New functions.
2025 (bidi_initialize): Initialize the bidi cache start stack pointer.
2026 (bidi_cache_ensure_space): New function, refactored from part of
2027 bidi_cache_iterator_state. Don't assume the required size is just
2028 one BIDI_CACHE_CHUNK away.
2029 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2030 (bidi_count_bytes, bidi_char_at_pos): New functions.
2031 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2032 always valid if bidi_cache_idx is valid.
2033 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2034 is valid if it's going to be used.
2035 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2036 (bidi_cache_fetch_state, bidi_cache_search)
2037 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2038 (bidi_cache_iterator_state, bidi_cache_find)
2039 (bidi_find_other_level_edge, bidi_cache_start_stack):
2040 All variables related to cache indices are now EMACS_INT.
2042 * dispextern.h (struct bidi_string_data): New structure.
2043 (struct bidi_it): New member `string'. Make flag members be 1-bit
2044 fields, and put them last in the struct.
2045 (compute_display_string_pos, compute_display_string_end):
2047 (bidi_push_it, bidi_pop_it): Add prototypes.
2048 (struct iterator_stack_entry): New members bidi_p,
2049 paragraph_embedding, and from_disp_prop_p.
2050 (struct it): Member bidi_p is now a bit field 1 bit wide.
2051 (bidi_shelve_cache, bidi_unshelve_cache):
2054 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2055 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2056 and vector-like objects.
2058 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2059 cache around display iteration.
2061 * window.c (Fwindow_end, window_scroll_pixel_based)
2062 (displayed_window_lines, Frecenter): Save and restore the bidi
2063 cache around display iteration.
2065 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2067 * editfns.c (Fdelete_region): Clarify the use of the named
2068 parameters (bug#6788).
2070 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2072 * indent.c (Fvertical_motion): Set and restore w->pointm when
2073 saving and restoring the window's buffer (Bug#9006).
2075 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2077 * editfns.c (Fstring_to_char): Clarify just what is returned
2078 (bug#6576). Text by Eli Zaretskii.
2080 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2082 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2084 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2086 * buffer.c (mmap_find): Fix a typo.
2088 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2090 Fix execution of x selection hooks.
2091 * xselect.c (Qx_lost_selection_functions)
2092 (Qx_sent_selection_functions): New vars.
2093 (syms_of_xselect): DEFSYM them.
2094 (x_handle_selection_request): Pass Qx_sent_selection_functions
2095 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2096 (x_handle_selection_clear,x_clear_frame_selections):
2097 Pass Qx_lost_selection_functions rather than
2098 Vx_lost_selection_functions to Frun_hook_with_args.
2100 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2102 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2103 The old code sometimes used this field without initializing it.
2105 * alloc.c (gc_sweep): Don't read past end of array.
2106 In theory, the old code could also have corrupted Emacs internals,
2107 though it'd be very unlikely.
2109 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2111 * character.c (Fcharacterp): Don't advertise optional ignored
2112 argument. (Bug#4026)
2114 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2116 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2119 * window.c (Fset_window_start): Doc fix (bug#4199).
2120 (Fset_window_hscroll): Ditto.
2122 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2124 Fix minor new problems caught by GCC 4.6.1.
2125 * term.c (init_tty): Remove unused local.
2126 * xsettings.c (store_monospaced_changed): Define this function only
2127 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2130 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2132 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2134 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2136 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2137 are the mini-buffer and the echo area (bug#3320).
2139 * term.c (init_tty): Remove support for supdup, c10 and perq
2140 terminals, which are no longer supported (bug#1482).
2142 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2144 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2146 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2148 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2149 for non-popups (Bug#3642).
2151 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2153 * alloc.c (reset_malloc_hooks): Protoize.
2154 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2155 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2156 * cm.c (losecursor): Likewise.
2157 * data.c (fmod): Likewise.
2158 * dispnew.c (swap_glyphs_in_rows): Likewise.
2159 * emacs.c (memory_warning_signal): Likewise.
2160 * floatfns.c (float_error): Likewise.
2161 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2162 (otf_open, font_otf_capability, generate_otf_features)
2163 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2165 * image.c (pbm_read_file): Likewise.
2166 * indent.c (string_display_width): Likewise.
2167 * intervals.c (check_for_interval, search_for_interval)
2168 (inc_interval_count, count_intervals, root_interval)
2169 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2170 * lread.c (defalias): Likewise.
2171 * ralloc.c (r_alloc_check): Likewise.
2172 * regex.c (set_image_of_range_1, set_image_of_range)
2173 (regex_grow_registers): Likewise.
2174 * sysdep.c (strerror): Likewise.
2175 * termcap.c (valid_filename_p, tprint, main): Likewise.
2176 * tparam.c (main): Likewise.
2177 * unexhp9k800.c (run_time_remap, save_data_space)
2178 (update_file_ptrs, read_header, write_header, calculate_checksum)
2179 (copy_file, copy_rest, display_header): Likewise.
2180 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2182 * xdisp.c (check_it): Likewise.
2183 * xfaces.c (register_color, unregister_color, unregister_colors):
2185 * xfns.c (print_fontset_result): Likewise.
2186 * xrdb.c (member, fatal, main): Likewise.
2188 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2190 Fix minor problems found by static checking (Bug#9031).
2191 * chartab.c (char_table_set_range, map_sub_char_table):
2192 Remove unused locals.
2193 (uniprop_table): Now static.
2194 * composite.c (_work_char): Remove unused static var.
2196 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2198 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2200 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2202 * gtkutil.c (qttip_cb): Remove code without function.
2204 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2206 * w32.c (pthread_sigmask): New stub.
2208 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2210 Use pthread_sigmask, not sigprocmask (Bug#9010).
2211 sigprocmask is portable only for single-threaded applications, and
2212 Emacs can be multi-threaded when it uses GTK.
2213 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2215 * callproc.c (Fcall_process):
2216 * process.c (create_process):
2217 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2218 Use pthread_sigmask, not sigprocmask.
2220 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2222 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2223 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2226 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2228 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2229 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2230 (xg_hide_tooltip): Fix comment.
2232 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2233 in registerServicesMenuSendTypes.
2234 (validRequestorForSendType): Don't check ns_return_types.
2236 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2239 2011-07-08 Jason Rumney <jasonr@gnu.org>
2241 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2242 frame struct members of non-existent frames (Bug#6284).
2244 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2246 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2247 variable firstTime not needed on OSX >= 10.6.
2248 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2249 >= 10.5. Use setKnobProportion, setDoubleValue.
2251 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2252 (MAC_OS_X_VERSION_10_5): Define if not defined.
2253 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2254 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2255 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2257 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2258 cString and lossyCString on OSX >= 10.4
2260 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2261 sizeToFit on OSX >= 10.2.
2263 * nsimage.m (allocInitFromFile): Don't use deprecated method
2264 bestRepresentationForDevice on OSX >= 10.6.
2266 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2269 * emacs.c: Declare unexec_init_emacs_zone.
2271 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2273 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2275 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2276 on svcsMenu (Bug#8842).
2278 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2280 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2282 * nsterm.m (QUTF8_STRING): Declare.
2283 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2284 (validRequestorForSendType): Return type is (id).
2285 Change indexOfObjectIdenticalTo to indexOfObject.
2286 Check if we have local selection before returning self (Bug#8842).
2287 (writeSelectionToPasteboard): Put local selection into paste board
2288 if we have a local selection (Bug#8842).
2289 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2291 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2292 (ns_get_local_selection): Declare.
2294 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2296 * keymap.c (describe_map_tree): Don't insert a double newline at
2297 the end of the buffer (bug#1169) and return whether we inserted
2300 * callint.c (Fcall_interactively): Change "reading args" to
2301 "providing args" to try to clarify what it does (bug#1010).
2303 2011-07-07 Kenichi Handa <handa@m17n.org>
2305 * composite.c (composition_compute_stop_pos): Ignore a static
2306 composition starting before CHARPOS (Bug#8915).
2308 * xdisp.c (handle_composition_prop): Likewise.
2310 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2312 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2315 2011-07-07 Kenichi Handa <handa@m17n.org>
2317 * character.h (unicode_category_t): New enum type.
2319 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2320 (Qchar_code_property_table): New variable.
2321 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2322 (UNIPROP_COMPRESSED_FORM_P): New macros.
2323 (char_table_ascii): Uncompress the compressed values.
2324 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2325 Uncompress the compressed values.
2326 (sub_char_table_ref_and_range): Likewise.
2327 (char_table_ref_and_range): Uncompress the compressed values.
2328 (sub_char_table_set): New arg is_uniprop. Callers changed.
2329 Uncompress the compressed values.
2330 (sub_char_table_set_range): Args changed. Callers changed.
2331 (char_table_set_range): Adjuted for the above change.
2332 (map_sub_char_table): Delete args default_val and parent. Add arg
2333 top. Give decoded values to a Lisp function.
2334 (map_char_table): Adjust for the above change. Give decoded
2335 values to a Lisp function. Gcpro more variables.
2336 (uniprop_table_uncompress)
2337 (uniprop_decode_value_run_length): New functions.
2338 (uniprop_decoder, uniprop_decoder_count): New variables.
2339 (uniprop_get_decoder, uniprop_encode_value_character)
2340 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2342 (uniprop_encoder, uniprop_encoder_count): New variables.
2343 (uniprop_get_encoder, uniprop_table)
2344 (Funicode_property_table_internal, Fget_unicode_property_internal)
2345 (Fput_unicode_property_internal): New functions.
2346 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2347 Sunicode_property_table_internal, Sget_unicode_property_internal,
2348 and Sput_unicode_property_internal. Defvar_lisp
2349 char-code-property-alist.
2351 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2352 Vunicode_category_table.
2354 * font.c (font_range): Adjust for the change of
2355 Vunicode_category_table.
2357 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2359 * m/iris4d.h: Remove file, move contents ...
2360 * s/irix6-5.h: ... here.
2362 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2364 Remove unportable assumption about struct layout (Bug#8884).
2365 * alloc.c (mark_buffer):
2366 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2367 (clone_per_buffer_values): Don't assume that
2368 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2369 This isn't true in general, and it's particularly not true
2370 if Emacs is configured with --with-wide-int.
2371 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2372 New macros, used in the buffer.c change.
2374 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2376 * xsettings.c: Use both GConf and GSettings if both are available.
2377 (store_config_changed_event): Add comment.
2378 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2379 (store_tool_bar_style_changed): New functions.
2380 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2381 (struct xsettings): Move font inside HAVE_XFT.
2382 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2383 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2384 Move inside HAVE_XFT.
2385 (something_changed_gsettingsCB): Rename from something_changedCB.
2386 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2388 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2389 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2390 (something_changed_gconfCB): Rename from something_changedCB.
2391 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2392 (parse_settings): Move check for font inside HAVE_XFT.
2393 (read_settings, apply_xft_settings): Add comment.
2394 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2395 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2396 call store_font_name_changed.
2397 (xft_settings_event): Add comment.
2398 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2399 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2400 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2401 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2402 (xsettings_initialize): Call init_gsettings last.
2403 (xsettings_get_system_font, xsettings_get_system_normal_font):
2406 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2408 Random fixes. E.g., (random) never returned negative values.
2409 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2410 subseconds part to the entropy, as that's a bit more random.
2411 Prefer signed to unsigned, since the signedness doesn't matter and
2412 in general we prefer signed. When given a limit, use a
2413 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2414 latter isn't right if USE_2_TAGS_FOR_INTS.
2415 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2416 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2418 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2420 * textprop.c (text_property_stickiness):
2421 Obey Vtext_property_default_nonsticky.
2422 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2423 * w32fns.c (syms_of_w32fns):
2424 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2426 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2428 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2429 This is more efficient than Ffile_directory_p and avoids a minor race.
2431 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2433 * buffer.c (Foverlay_put): Say what the return value is
2436 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2437 is a directory before asking whether to use the file name
2439 (barf_or_query_if_file_exists): Make the "File is a directory"
2440 error be more correct.
2442 * fns.c (Frequire): Remove the mention of the .gz files, since
2443 that's installation-specific, but keep the mention of
2444 `get-load-suffixes'.
2446 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2448 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2449 Report string overflow if the output is too long.
2451 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2453 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2454 (syms_of_gnutls): Remove duplicate DEFSYM for
2455 Qgnutls_bootprop_verify_hostname_error, an error for
2456 Qgnutls_bootprop_verify_error (which is no longer used).
2458 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2459 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2460 Also (re)move comments that are misplaced or no longer relevant.
2462 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2464 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2466 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2468 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2469 and background color parameters if they have been changed.
2471 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2473 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2475 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2477 * xsettings.c (SYSTEM_FONT): Define only when used.
2478 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2480 * keymap.c (access_keymap_1): Now static.
2482 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2484 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2485 leave any prefix arg for the up event (Bug#1586).
2487 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2489 * lread.c (syms_of_lread): Mention single symbols defined by
2490 `defvar' or `defconst' (bug#7154).
2492 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2493 (Frequire): Mention get-load-suffixes.
2495 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2497 * window.h (window): Remove clone_number slot.
2498 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2500 (make_parent_window, make_window, saved_window)
2501 (Fset_window_configuration, save_window_save): Don't deal with
2503 * buffer.c (Qclone_number): Remove declaration.
2504 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2506 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2508 Add multiple inheritance to keymaps.
2509 * keymap.c (Fmake_composed_keymap): New function.
2510 (Fset_keymap_parent): Simplify.
2511 (fix_submap_inheritance): Remove.
2512 (access_keymap_1): New function extracted from access_keymap to handle
2513 embedded parents and handle lists of maps.
2514 (access_keymap): Use it.
2515 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2516 (Fcopy_keymap): Handle embedded parents.
2517 (Fcommand_remapping, define_as_prefix): Simplify.
2518 (Fkey_binding): Simplify.
2519 (syms_of_keymap): Move minibuffer-local-completion-map,
2520 minibuffer-local-filename-completion-map,
2521 minibuffer-local-must-match-map, and
2522 minibuffer-local-filename-must-match-map to Elisp.
2523 (syms_of_keymap): Defsubr make-composed-keymap.
2524 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2525 (parse_menu_item): Trivial simplification.
2527 2011-07-01 Glenn Morris <rgm@gnu.org>
2529 * Makefile.in (SETTINGS_LIBS): Fix typo.
2531 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2533 * coding.c (Fencode_coding_string): Record the last coding system
2534 used, as the function doc string says (bug#8738).
2536 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2538 * xsettings.c (store_monospaced_changed): Take new font as arg and
2539 check for change against current_mono_font.
2540 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2541 (emacs_settings_constructor, emacs_settings_get_property)
2542 (emacs_settings_set_property, emacs_settings_class_init)
2543 (emacs_settings_init, gsettings_obj): Remove.
2544 (something_changedCB): New function for HAVE_GSETTINGS.
2545 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2546 with value as argument.
2547 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2548 g_settings_new (Bug#8967). Do not create gsettings_obj.
2549 Remove calls to g_settings_bind. Connect something_changedCB to
2552 * xgselect.c: Add defined (HAVE_GSETTINGS).
2553 (xgselect_initialize): Ditto.
2555 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2556 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2559 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2561 * eval.c (struct backtrace): Simplify and port the data structure.
2562 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2563 signed bit field, as this assumption is not portable and it makes
2564 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2565 "char debug_on_exit : 1" as this is not portable either; instead,
2566 use the portable "unsigned int debug_on_exit : 1". Remove unused
2567 member evalargs. Remove obsolete comments about cc bombing out.
2569 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2571 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2572 Let HAVE_GSETTINGS override HAVE_GCONF.
2573 (store_monospaced_changed): New function.
2574 (EMACS_SETTINGS): A new type derived from GObject to handle
2575 GSettings notifications.
2576 (emacs_settings_constructor, emacs_settings_get_property)
2577 (emacs_settings_set_property, emacs_settings_class_init):
2579 (gsettings_client, gsettings_obj): New variables.
2580 (GSETTINGS_SCHEMA): New define.
2581 (something_changedCB): Call store_monospaced_changed.
2582 (init_gsettings): New function.
2583 (xsettings_initialize): Call init_gsettings.
2584 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2587 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2590 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2592 * window.c (resize_root_window, grow_mini_window)
2593 (shrink_mini_window): Rename Qresize_root_window to
2594 Qwindow_resize_root_window and Qresize_root_window_vertically to
2595 Qwindow_resize_root_window_vertically.
2597 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2599 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2601 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2603 * makefile.w32-in: Redesign dependencies so they reflect more
2604 clearly which files are directly included by each source file,
2605 and not through other includes.
2607 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2609 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2610 (sort_overlays, overlay_strings): When an overlay's clone number
2611 matches the window's clone number process the overlay even if
2612 the overlay's window property doesn't match the current window.
2614 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2615 (Fwindow_hchild): Rename to Fwindow_left_child.
2616 (Fwindow_next): Rename to Fwindow_next_sibling.
2617 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2618 (resize_window_check): Rename to window_resize_check.
2619 (resize_window_apply): Rename to window_resize_apply.
2620 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2621 (Fdelete_other_windows_internal, resize_frame_windows)
2622 (Fsplit_window_internal, Fdelete_window_internal)
2623 (grow_mini_window, shrink_mini_window)
2624 (Fresize_mini_window_internal): Fix callers accordingly.
2626 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2628 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2629 (emacs_fixed_set_min_size): Remove.
2630 (emacs_fixed_new): Take frame as argument.
2632 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2633 (_EmacsFixedPrivate): Remove minwidth/height.
2634 Add struct frame *f.
2635 (emacs_fixed_init): Initialize priv->f.
2636 (get_parent_class, emacs_fixed_set_min_size): Remove.
2637 (emacs_fixed_new): Set priv->f to argument.
2638 (emacs_fixed_get_preferred_width)
2639 (emacs_fixed_get_preferred_height): Use min_width/height from
2640 frames size_hint to set minimum and natural (Bug#8919).
2641 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2642 and use min_width/height from frames size_hint to set
2643 min_width/height (Bug#8919).
2645 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2646 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2649 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2651 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2652 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2655 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2657 * process.c (wait_reading_process_output): Bypass select if
2658 waiting for a cell while ignoring keyboard input, and input is
2659 pending. Suggested by Jan Djärv (Bug#8869).
2661 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2663 Use gnulib's dup2 module instead of rolling our own.
2664 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2666 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2668 * dispnew.c (scrolling_window): Before scrolling, turn off a
2669 mouse-highlight in the window being scrolled.
2671 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2673 Move DEFSYM to lisp.h and use everywhere.
2675 * character.h (DEFSYM): Move declaration...
2676 * lisp.h (DEFSYM): ...here.
2682 * w32select.c: Don't include character.h.
2684 * alloc.c (syms_of_alloc):
2685 * buffer.c (syms_of_buffer):
2686 * bytecode.c (syms_of_bytecode):
2687 * callint.c (syms_of_callint):
2688 * casefiddle.c (syms_of_casefiddle):
2689 * casetab.c (init_casetab_once):
2690 * category.c (init_category_once, syms_of_category):
2691 * ccl.c (syms_of_ccl):
2692 * cmds.c (syms_of_cmds):
2693 * composite.c (syms_of_composite):
2694 * dbusbind.c (syms_of_dbusbind):
2695 * dired.c (syms_of_dired):
2696 * dispnew.c (syms_of_display):
2697 * doc.c (syms_of_doc):
2698 * editfns.c (syms_of_editfns):
2699 * emacs.c (syms_of_emacs):
2700 * eval.c (syms_of_eval):
2701 * fileio.c (syms_of_fileio):
2702 * fns.c (syms_of_fns):
2703 * frame.c (syms_of_frame):
2704 * fringe.c (syms_of_fringe):
2705 * insdel.c (syms_of_insdel):
2706 * keymap.c (syms_of_keymap):
2707 * lread.c (init_obarray, syms_of_lread):
2708 * macros.c (syms_of_macros):
2709 * msdos.c (syms_of_msdos):
2710 * print.c (syms_of_print):
2711 * process.c (syms_of_process):
2712 * search.c (syms_of_search):
2713 * sound.c (syms_of_sound):
2714 * syntax.c (init_syntax_once, syms_of_syntax):
2715 * terminal.c (syms_of_terminal):
2716 * textprop.c (syms_of_textprop):
2717 * undo.c (syms_of_undo):
2718 * w32.c (globals_of_w32):
2719 * window.c (syms_of_window):
2720 * xdisp.c (syms_of_xdisp):
2721 * xfaces.c (syms_of_xfaces):
2722 * xfns.c (syms_of_xfns):
2723 * xmenu.c (syms_of_xmenu):
2724 * xsettings.c (syms_of_xsettings):
2725 * xterm.c (syms_of_xterm): Use DEFSYM.
2727 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2729 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2731 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2733 Integer and buffer overflow fixes (Bug#8873).
2735 * print.c (printchar, strout): Check for string overflow.
2736 (PRINTPREPARE, printchar, strout):
2737 Don't set size unless allocation succeeds.
2739 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2740 for sizes. Check for string overflow more accurately.
2741 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2743 * macros.c: Integer and buffer overflow fixes.
2744 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2745 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2746 Use ptrdiff_t, not int, for sizes.
2747 Don't increment bufsize until after realloc succeeds.
2748 Check for size-calculation overflow.
2749 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2751 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2753 * lread.c: Integer overflow fixes.
2754 (read_integer): Radix is now EMACS_INT, not int,
2755 to improve quality of diagnostics for out-of-range radices.
2756 Calculate buffer size correctly for out-of-range radices.
2757 (read1): Check for integer overflow in radices, and in
2758 read-circle numbers.
2759 (read_escape): Avoid int overflow.
2760 (Fload, openp, read_buffer_size, read1)
2761 (substitute_object_recurse, read_vector, read_list, map_obarray):
2762 Use ptrdiff_t, not int, for sizes.
2763 (read1): Use EMACS_INT, not int, for sizes.
2764 Check for size overflow.
2766 * image.c (cache_image): Check for size arithmetic overflow.
2768 * lread.c: Integer overflow issues.
2769 (saved_doc_string_size, saved_doc_string_length)
2770 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2771 Now ptrdiff_t, not int.
2772 (read1): Don't assume doc string length fits in int. Check for
2773 out-of-range doc string lengths.
2774 (read_list): Don't assume file position fits in int.
2775 (read_escape): Check for hex character overflow.
2777 2011-06-22 Leo Liu <sdl.web@gmail.com>
2779 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2780 Move to minibuffer.el.
2782 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2784 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2785 The following patches are for when GLYPH_DEBUG && !XASSERT.
2786 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2787 * dispnew.c (flush_stdout):
2788 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2789 Mark as externally visible.
2790 * dispnew.c (check_window_matrix_pointers): Now static.
2791 * dispnew.c (window_to_frame_vpos):
2792 * xfns.c (unwind_create_frame):
2793 * xterm.c (x_check_font): Remove unused local.
2794 * scroll.c (CHECK_BOUNDS):
2795 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2796 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2797 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2798 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2799 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2801 (debug_method_add): Use va_list and vsprintf rather than relying
2802 on undefined behavior with wrong number of arguments.
2803 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2804 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2805 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2806 since we're not interested in debugging glyphs with old libraries.
2807 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2808 GCC 4.6.0's static checking.
2810 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2812 Integer overflow and signedness fixes (Bug#8873).
2813 A few related buffer overrun fixes, too.
2815 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2817 * dispextern.h (struct face.stipple):
2818 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2819 (x_bitmap_mask, x_allocate_bitmap_record)
2820 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2821 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2822 (x_create_bitmap_from_xpm_data):
2823 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2824 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2826 * xfaces.c (load_pixmap):
2827 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2828 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2829 (.bitmaps_last, struct x_output.icon_bitmap):
2830 Use ptrdiff_t, not int, for bitmap indexes.
2831 (x_allocate_bitmap_record): Check for size overflow.
2832 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2834 Use ptrdiff_t, not int, for overlay counts.
2835 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2836 * editfns.c (overlays_around, get_pos_property):
2837 * textprop.c (get_char_property_and_overlay):
2838 * xdisp.c (next_overlay_change, note_mouse_highlight):
2839 * xfaces.c (face_at_buffer_position):
2840 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2841 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2842 (Fnext_overlay_change, Fprevious_overlay_change)
2843 (mouse_face_overlay_overlaps, Foverlays_in):
2844 Use ptrdiff_t, not int, for sizes.
2845 (overlays_at, overlays_in): Check for size-calculation overflow.
2847 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2849 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2850 (x_session_initialize): Do not assume string length fits in int.
2852 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2853 This is unlikely, but can occur if DPI is outlandish.
2855 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2856 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2858 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2859 * xrdb.c (magic_file_p, search_magic_path):
2860 Omit last arg SUFFIX; it was always 0. All callers changed.
2861 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2863 * xfont.c (xfont_match): Avoid need for strlen.
2865 * xfns.c: Don't assume strlen fits in int.
2866 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2868 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2869 not unsigned long, as we prefer signed integers. All callers changed.
2870 Detect integer overflow in repeat count.
2871 (message_dolog): Don't assume print length fits in 39 bytes.
2872 (display_mode_element): Don't assume strlen fits in int.
2874 * termcap.c: Don't assume sizes fit in int and never overflow.
2875 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2876 (gobble_line): Check for size-calculation overflow.
2878 * minibuf.c (Fread_buffer):
2879 * lread.c (intern, intern_c_string):
2880 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2881 Don't assume string length fits in int.
2883 * keyboard.c (parse_tool_bar_item):
2884 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2886 * font.c: Don't assume string length fits in int.
2887 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2888 Use ptrdiff_t, not int.
2889 (font_intern_prop): Don't assume string length fits in int.
2890 Don't assume integer property fits in fixnum.
2891 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2893 * filelock.c: Fix some buffer overrun and integer overflow issues.
2894 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2895 Reformulate so as not to need the command string.
2896 Invoke gzip -cd rather than gunzip, as it's more portable.
2897 (lock_info_type, lock_file_1, lock_file):
2898 Don't assume pid_t and time_t fit in unsigned long.
2899 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2900 (current_lock_owner): Prefer signed type for sizes.
2901 Use memcpy, not strncpy, where memcpy is what is really wanted.
2902 Don't assume (via atoi) that time_t and pid_t fit in int.
2903 Check for time_t and/or pid_t out of range, e.g., via a network share.
2904 Don't alloca where an auto var works fine.
2906 * fileio.c: Fix some integer overflow issues.
2907 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2908 Don't assume string length fits in int.
2909 (directory_file_name): Don't assume string length fits in long.
2910 (make_temp_name): Don't assume pid fits in int, or that its print
2911 length is less than 20.
2913 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2915 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2917 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2919 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2920 We prefer signed integers, even for size calculations.
2922 * emacs.c: Don't assume string length fits in 'int'.
2923 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2924 (main): Don't invoke strlen when not needed.
2926 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2927 (XD_DEBUG_MESSAGE): Don't waste a byte.
2929 * callproc.c (getenv_internal_1, getenv_internal)
2931 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2933 * lread.c (invalid_syntax): Omit length argument.
2934 All uses changed. This doesn't fix a bug, but it simplifies the
2935 code away from its former Hollerith-constant appearance, and it's
2936 one less 'int' to worry about when looking at integer-overflow issues.
2937 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2939 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2940 This didn't break anything, but it didn't help either.
2941 It's confusing to put a bogus integer in a place where the actual
2942 value does not matter.
2943 (LIST_END_P): Remove unused macro and its bogus comment.
2944 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2946 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2947 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2949 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2950 We prefer signed types, and the value cannot exceed the EMACS_INT
2951 range anyway (because otherwise the length would not be representable).
2952 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2953 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2954 This avoids a GCC warning when WIDE_EMACS_INT.
2956 * indent.c (sane_tab_width): New function.
2957 (current_column, scan_for_column, Findent_to, position_indentation)
2958 (compute_motion): Use it. This is just for clarity.
2959 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2961 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2963 * lisp.h (lint_assume): New macro.
2964 * composite.c (composition_gstring_put_cache):
2965 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2967 * editfns.c, insdel.c:
2968 Omit unnecessary forward decls, to simplify future changes.
2970 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2972 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2974 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2975 Use much-faster test for byte-length change.
2976 Don't assume string byte-length fits in 'int'.
2977 Check that character arg fits in 'int'.
2978 (mapcar1): Declare byte as byte, for clarity.
2980 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2982 * fns.c (concat): Catch string overflow earlier.
2983 Do not rely on integer wraparound.
2985 * dispextern.h (struct it.overlay_strings_charpos)
2986 (struct it.selective): Now EMACS_INT, not int.
2987 * xdisp.c (forward_to_next_line_start)
2988 (back_to_previous_visible_line_start)
2989 (reseat_at_next_visible_line_start, next_element_from_buffer):
2990 Don't arbitrarily truncate the value of 'selective' to int.
2992 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2994 * composite.c: Don't truncate sizes to 'int'.
2995 (composition_gstring_p, composition_reseat_it)
2996 (composition_adjust_point): Use EMACS_INT, not int.
2997 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2998 not EMACS_UINT, for indexes.
3000 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3002 * buffer.c: Include <verify.h>.
3003 (struct sortvec.priority, struct sortstr.priority):
3004 Now EMACS_INT, not int.
3005 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3006 (struct sortstr.size, record_overlay_string)
3007 (struct sortstrlist.size, struct sortlist.used):
3008 Don't truncate size to int.
3009 (record_overlay_string): Check for size-calculation overflow.
3010 (init_buffer_once): Check at compile-time, not run-time.
3012 2011-06-22 Jim Meyering <meyering@redhat.com>
3014 Don't leak an XBM-image-sized buffer
3015 * image.c (xbm_load): Free the image buffer after using it.
3017 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3020 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3021 that Sun C diagnosed.
3022 * fns.c (secure_hash): Fix pointer signedness issue.
3023 * intervals.c (static_offset_intervals): New function.
3024 (offset_intervals): Use it.
3026 2011-06-21 Leo Liu <sdl.web@gmail.com>
3029 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3032 * fns.c (secure_hash): Rename from crypto_hash_function and change
3033 the first arg to accept symbols.
3034 (Fsecure_hash): New primitive.
3035 (syms_of_fns): New symbols.
3037 2011-06-20 Deniz Dogan <deniz@dogan.se>
3039 * process.c (Fset_process_buffer): Clarify return value in
3042 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3044 * dispnew.c (add_window_display_history): Use BVAR.
3046 * xdisp.c (debug_method_add): Use BVAR.
3047 (check_window_end, dump_glyph_matrix, dump_glyph)
3048 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3050 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3053 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3054 check till after the cache is created in init_frame_faces.
3056 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3058 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3060 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3062 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3063 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3064 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3066 Improve buffer-overflow checking (Bug#8873).
3067 * fileio.c (Finsert_file_contents):
3068 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3069 Remove the old (too-loose) buffer overflow checks.
3070 They weren't needed, since make_gap checks for buffer overflow.
3071 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3072 The old code merely checked for Emacs fixnum overflow, and relied
3073 on undefined (wraparound) behavior. The new code avoids undefined
3074 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3076 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3077 Tune. Don't use wider integers than needed. Don't use alloca.
3078 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3080 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3082 * insdel.c, lisp.h (buffer_overflow): New function.
3083 (insert_from_buffer_1, replace_range, replace_range_2):
3084 * insdel.c (make_gap_larger):
3085 * editfns.c (Finsert_char):
3086 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3088 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3090 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3092 Integer overflow and signedness fixes (Bug#8873).
3094 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3095 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3097 * fileio.c: Don't assume EMACS_INT fits in off_t.
3098 (emacs_lseek): New static function.
3099 (Finsert_file_contents, Fwrite_region): Use it.
3100 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3102 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3104 * fns.c: Don't overflow int when computing a list length.
3105 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3106 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3107 truncation on 64-bit hosts. Check for QUIT every
3108 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3109 faster and is responsive enough.
3110 (Flength): Report an error instead of overflowing an integer.
3111 (Fsafe_length): Return a float if the value is not representable
3112 as a fixnum. This shouldn't happen except in contrived situations.
3113 (Fnthcdr, Fsort): Don't assume list length fits in int.
3114 (Fcopy_sequence): Don't assume vector length fits in int.
3116 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3117 (header_size, word_size): New constants.
3118 (allocate_vectorlike): Don't check size overflow here.
3119 (allocate_vector): Check it here instead, since this is the only
3120 caller of allocate_vectorlike that could cause overflow.
3121 Check that the new vector's length is representable as a fixnum.
3123 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3124 The previous code was bogus. For example, next_almost_prime (32)
3125 returned 39, which is undesirable as it is a multiple of 3; and
3126 next_almost_prime (24) returned 25, which is a multiple of 5 so
3127 why was the code bothering to check for multiples of 7?
3129 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3131 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3133 Variadic C functions now count arguments with ptrdiff_t.
3134 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3135 Back then I didn't know that the Emacs coding style prefers signed int.
3136 Also, in the meantime I found a few more instances where arguments
3137 were being counted with int, which may truncate counts on 64-bit
3138 machines, or EMACS_INT, which may be unnecessarily wide.
3139 * lisp.h (struct Lisp_Subr.function.aMANY)
3140 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3141 Arg counts are now ptrdiff_t, not size_t.
3142 All variadic functions and their callers changed accordingly.
3143 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3144 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3145 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3146 * callint.c (Fcall_interactively): Check arg count for overflow,
3147 to avoid potential buffer overrun. Use signed char, not 'int',
3148 for 'varies' array, so that we needn't bother to check its size
3149 calculation for overflow.
3150 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3151 * eval.c (apply_lambda):
3152 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3153 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3154 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3156 * callint.c (Fcall_interactively): Don't use index var as event count.
3158 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3159 * mem-limits.h (SIZE): Remove; no longer used.
3161 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3163 Remove unnecessary casts.
3164 * xterm.c (x_term_init):
3165 * xfns.c (x_set_border_pixel):
3166 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3167 These aren't needed now that we assume ANSI C.
3169 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3170 It's more likely to cause problems (due to unsigned overflow)
3173 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3175 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3177 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3179 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3181 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3183 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3185 GLYPH_CODE_FACE returns EMACS_INT, not int.
3186 * dispextern.h (merge_faces):
3187 * xfaces.c (merge_faces):
3188 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3189 Don't assume EMACS_INT fits in int.
3191 * character.h (CHAR_VALID_P): Remove unused parameter.
3192 * fontset.c, lisp.h, xdisp.c: All uses changed.
3194 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3196 * fns.c (concat): Minor tuning based on overflow analysis.
3197 This doesn't fix any bugs. Use int to hold character, instead
3198 of constantly refetching from Emacs object. Use XFASTINT, not
3199 XINT, for value known to be a character. Don't bother comparing
3200 a single byte to 0400, as it's always less.
3202 * floatfns.c (Fexpt):
3203 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3205 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3208 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3210 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3211 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3212 incorrectly succeed when S was a string, because 4294967386 was
3213 truncated before it was used.
3215 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3216 Otherwise, an out-of-range integer could cause undefined behavior
3219 * composite.c: Use int, not EMACS_INT, for characters.
3220 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3221 EMACS_INT, for values that are known to be in character range.
3222 This doesn't fix any bugs but is the usual style inside Emacs and
3223 may generate better code on 32-bit machines.
3225 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3226 This is for reasons similar to the recent CHAR_STRING fix.
3227 * charset.c (Fencode_char): Check that character arg is actually
3228 a character. Pass an int to ENCODE_CHAR.
3229 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3230 wider than 'int', as a compile-time check to prevent future regressions
3233 * character.c (char_string): Remove unnecessary casts.
3235 Make sure a 64-bit char is never passed to CHAR_STRING.
3236 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3237 by silently ignoring the top 32 bits, allowing some values
3238 that were far too large to be valid characters.
3239 * character.h: Include <verify.h>.
3240 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3241 arguments are no wider than unsigned, as a compile-time check
3242 to prevent future regressions in this area.
3244 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3245 (Fsubst_char_in_region):
3247 * xdisp.c (decode_mode_spec_coding):
3248 Adjust to CHAR_STRING's new requirement.
3249 * editfns.c (Finsert_char, Fsubst_char_in_region):
3250 * fns.c (concat): Check that character args are actually
3251 characters. Without this test, these functions did the wrong
3252 thing with wildly out-of-range values on 64-bit hosts.
3254 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3255 These casts should not be needed on 32-bit hosts, either.
3256 * keyboard.c (read_char):
3257 * lread.c (Fload): Remove casts to unsigned.
3259 * lisp.h (UNSIGNED_CMP): New macro.
3260 This fixes comparison bugs on 64-bit hosts.
3261 (ASCII_CHAR_P): Use it.
3262 * casefiddle.c (casify_object):
3263 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3264 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3265 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3266 * dispextern.h (FACE_FROM_ID):
3267 * keyboard.c (read_char): Use UNSIGNED_CMP.
3269 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3270 not to EMACS_INT, to avoid GCC warning.
3272 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3274 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3275 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3276 isn't needed on 32-bit machines.
3278 * buffer.c (Fgenerate_new_buffer_name):
3279 Use EMACS_INT for count, not int.
3280 (advance_to_char_boundary): Return EMACS_INT, not int.
3282 * data.c (Qcompiled_function): Now static.
3284 * window.c (window_body_lines): Now static.
3286 * image.c (gif_load): Rename local to avoid shadowing.
3288 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3289 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3290 * alloc.c (make_save_value): Integer argument is now of type
3292 (mark_object): Use ptrdiff_t, not int.
3293 * lisp.h (pD): New macro.
3294 * print.c (print_object): Use it.
3296 * alloc.c: Use EMACS_INT, not int, to count objects.
3297 (total_conses, total_markers, total_symbols, total_vector_size)
3298 (total_free_conses, total_free_markers, total_free_symbols)
3299 (total_free_floats, total_floats, total_free_intervals)
3300 (total_intervals, total_strings, total_free_strings):
3301 Now EMACS_INT, not int. All uses changed.
3302 (Fgarbage_collect): Compute overall total using a double, so that
3303 integer overflow is less likely to be a problem. Check for overflow
3304 when converting back to an integer.
3305 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3306 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3307 These were 'int' variables that could overflow on 64-bit hosts;
3308 they were never used, so remove them instead of repairing them.
3309 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3310 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3311 Previously, this ceilinged at INT_MAX, but that doesn't work on
3313 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3315 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3316 (allocate_vectorlike): Check for ptrdiff_t overflow.
3317 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3318 when a (possibly-narrower) signed value would do just as well.
3319 We prefer using signed arithmetic, to avoid comparison confusion.
3321 * alloc.c: Catch some string size overflows that we were missing.
3322 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3323 for convenience in STRING_BYTES_MAX.
3324 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3325 The definition here is exact; the one in lisp.h was approximate.
3326 (allocate_string_data): Check for string overflow. This catches
3327 some instances we weren't catching before. Also, it catches
3328 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3329 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3330 and ptrdiff_t and EMACS_INT are both 64 bits.
3332 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3333 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3334 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3336 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3338 * alloc.c (Fmake_string): Check for out-of-range init.
3340 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3342 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3344 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3346 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3347 xg_get_default_scrollbar_width.
3349 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3350 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3351 (style_changed_cb): Call update_theme_scrollbar_width and call
3352 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3353 all frames (Bug#8505).
3354 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3355 Call gtk_window_set_resizable if HAVE_GTK3.
3356 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3357 and height if HAVE_GTK3 (Bug#8505).
3358 (scroll_bar_width_for_theme): New variable.
3359 (update_theme_scrollbar_width): New function.
3360 (xg_get_default_scrollbar_width): Move code to
3361 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3362 (xg_initialize): Call update_theme_scrollbar_width.
3364 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3366 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3368 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3370 * frame.c (make_frame): Call other_buffer_safely instead of
3373 * window.c (temp_output_buffer_show): Call display_buffer with
3374 second argument Vtemp_buffer_show_specifiers and reset latter
3375 immediately after the call.
3376 (Vtemp_buffer_show_specifiers): New variable.
3377 (auto_window_vscroll_p, next_screen_context_lines)
3378 (Vscroll_preserve_screen_position): Remove leading asterisks from
3381 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3383 Fix minor problems found by GCC 4.6.0 static checking.
3384 * buffer.c (Qclone_number): Remove for now, as it's unused.
3385 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3386 (record_buffer): Remove unused local.
3387 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3388 (set_frame_buffer_list): Remove; unused.
3389 * frame.h (other_visible_frames): Remove decl.
3390 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3391 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3392 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3394 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3395 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3396 Define only if HAVE_GPM.
3397 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3398 (update_hints_inhibit): Remove; never set. All uses removed.
3399 * widgetprv.h (emacsFrameClassRec): Remove decl.
3400 * window.c (delete_deletable_window): Now returns void, since it
3401 wasn't returning anything.
3402 (compare_window_configurations): Remove unused locals.
3403 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3404 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3405 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3406 the same widths as pointers. This follows up on the 2011-05-06 patch.
3407 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3408 * xterm.h: Likewise.
3409 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3411 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3413 * makefile.w32-in: Update dependencies.
3414 (LISP_H): Add lib/intprops.h.
3416 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3418 * image.c (gif_load): Add animation frame delay to the metadata.
3419 (syms_of_image): Use DEFSYM. New symbol `delay'.
3421 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3423 * window.c (delete_deletable_window): Re-add.
3424 (Fset_window_configuration): Rewrite to handle dead buffers and
3425 consequently deletable windows.
3426 (window_tree, Fwindow_tree): Remove. Supply functionality in
3428 (compare_window_configurations): Simplify code.
3430 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3432 * image.c (imagemagick_load_image): Fix type mismatch.
3433 (Fimagemagick_types): Likewise.
3435 * window.h (replace_buffer_in_windows): Declare.
3437 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3439 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3440 Qclone_number. Remove external declaration of Qdelete_window.
3441 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3443 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3444 Run Qbuffer_list_update_hook if allowed.
3445 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3446 buffer list implementation.
3447 (other_buffer_safely): New function.
3448 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3449 calls to replace_buffer_in_windows and
3450 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3452 (record_buffer): Inhibit quitting and rewrite using quittable
3453 functions. Run Qbuffer_list_update_hook if allowed.
3454 (Frecord_buffer, Funrecord_buffer): New functions.
3455 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3456 Move switch-to-buffer to window.el.
3457 (bury-buffer): Move to window.el.
3458 (Vbuffer_list_update_hook): New variable.
3460 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3463 * window.h (resize_frame_windows): Move up in code.
3464 (Fwindow_frame): Remove EXFUN.
3465 (replace_buffer_in_all_windows): Remove prototype.
3466 (replace_buffer_in_windows_safely): Add prototype.
3468 * window.c: Declare Qdelete_window static again. Move down
3469 declaration of select_count.
3470 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3471 (Fother_window): Move to window.el.
3472 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3473 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3474 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3476 (replace_buffer_in_windows): Implement by calling
3477 Qreplace_buffer_in_windows.
3478 (replace_buffer_in_all_windows): Remove with some functionality
3479 moved into replace_buffer_in_windows_safely.
3480 (replace_buffer_in_windows_safely): New function.
3481 (select_window_norecord, select_frame_norecord): Move in front
3482 of run_window_configuration_change_hook. Remove now obsolete
3484 (Fset_window_buffer): Rewrite doc-string.
3485 Call Qrecord_window_buffer.
3486 (keys_of_window): Move binding for other-window to window.el.
3488 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3490 * dispextern.h (struct image): Replace data member, whose int_val
3491 and ptr_val fields were not used by anything, with a single
3494 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3495 (gif_clear_image, gif_load, imagemagick_load_image)
3496 (gs_clear_image, gs_load): Callers changed.
3498 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3500 * buffer.h: Include <time.h>, for time_t.
3501 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3503 Fix minor problems found by static checking.
3505 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3507 Make identifiers static if they are not used in other modules.
3508 * data.c (Qcompiled_function, Qframe, Qvector):
3509 * image.c (QimageMagick, Qsvg):
3510 * minibuf.c (Qmetadata):
3511 * window.c (resize_window_check, resize_root_window): Now static.
3512 * window.h (resize_window_check, resize_root_window): Remove decls.
3514 * window.c (window_deletion_count, delete_deletable_window):
3516 (window_body_lines): Now static.
3517 (Fdelete_other_windows_internal): Mark vars as initialized.
3518 Make sure 'resize_failed' is initialized.
3519 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3520 (resize_window_apply): Remove unused local.
3521 * window.h (delete_deletable_window): Remove decl.
3523 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3524 (imagemagick_load_image): Fix pointer signedness problem by changing
3525 last arg from unsigned char * to char *. All uses changed.
3526 Also, fix a local for similar reasons.
3527 Remove unused locals. Remove locals to avoid shadowing.
3528 (fn_rsvg_handle_free): Remove; unused.
3529 (svg_load, svg_load_image): Fix pointer signedness problem.
3530 (imagemagick_load_image): Don't use garbage pointer image_wand.
3532 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3534 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3536 * image.c (gif_load): Fix omitted cast error introduced by
3539 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3541 * window.h (resize_proportionally, orig_total_lines)
3542 (orig_top_line): Remove from window structure.
3543 (set_window_height, set_window_width, change_window_heights)
3544 (Fdelete_window): Remove prototypes.
3545 (resize_frame_windows): Remove duplicate declaration.
3547 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3549 * window.h (resize_frame_windows, resize_window_check)
3550 (delete_deletable_window, resize_root_window)
3551 (resize_frame_windows): Declare prototypes.
3553 * window.c (resize_window_apply): Make definition be "static" to
3554 match the prototype.
3556 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3558 * window.c: Remove declarations of Qwindow_size_fixed,
3559 window_min_size_1, window_min_size_2, window_min_size,
3560 size_window, window_fixed_size_p, enlarge_window, delete_window.
3561 Remove static from declaration of Qdelete_window, it's
3562 temporarily needed by Fbury_buffer.
3563 (replace_window): Don't assign orig_top_line and
3565 (Fdelete_window, delete_window): Remove. Window deletion is
3566 handled by window.el.
3567 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3568 Replace Fdelete_window calls with calls to Qdelete_window.
3569 (Fdelete_other_windows): Remove. Deleting other windows is
3570 handled by window.el.
3571 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3572 handled in window.el.
3573 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3574 Window minimum sizes are handled in window.el.
3575 (shrink_windows, size_window, set_window_height)
3576 (set_window_width, change_window_heights, window_height)
3577 (window_width, CURBEG, CURSIZE, enlarge_window)
3578 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3579 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3580 handled in window.el.
3581 (make_dummy_parent): Rename to make_parent_window and give it a
3582 second argument horflag.
3583 (make_window): Don't set resize_proportionally any more.
3584 (Fsplit_window): Remove. Windows are split in window.el.
3585 (save_restore_action, save_restore_orig_size)
3586 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3587 Resize mini windows in window.el.
3588 (grow_mini_window, shrink_mini_window): Implement by calling
3589 Qresize_root_window_vertically, resize_window_check and
3590 resize_window_apply.
3591 (saved_window, Fset_window_configuration, save_window_save):
3592 Do not handle orig_top_line, orig_total_lines, and
3593 resize_proportionally.
3594 (window_min_height, window_min_width): Move to window.el.
3595 (keys_of_window): Move bindings for delete-other-windows,
3596 split-window, delete-window and enlarge-window to window.el.
3598 * buffer.c: Temporarily extern Qdelete_window.
3599 (Fbury_buffer): Temporarily call Qdelete_window instead of
3600 Fdelete_window (Fbury_buffer will move to window.el soon).
3602 * frame.c (set_menu_bar_lines_1): Remove code handling
3603 orig_top_line and orig_total_lines.
3605 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3606 set_window_height but set heights directly.
3607 (change_frame_size_1): Use resize_frame_windows.
3609 * xdisp.c (init_xdisp): Don't use set_window_height but set
3612 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3613 Use resize_frame_windows instead of change_window_heights and run
3614 run_window_configuration_change_hook.
3616 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3617 instead of change_window_heights and run
3618 run_window_configuration_change_hook.
3620 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3622 * window.c (replace_window): Rename second argument REPLACEMENT to
3623 NEW. New third argument SETFLAG. Rewrite.
3624 (delete_window, make_dummy_parent): Call replace_window with
3626 (window_list_1): Move down in code.
3627 (run_window_configuration_change_hook): Move set_buffer part
3628 before select_frame_norecord part in order to unwind correctly.
3629 Rename count1 to count.
3630 (recombine_windows, delete_deletable_window, resize_root_window)
3631 (Fdelete_other_windows_internal)
3632 (Frun_window_configuration_change_hook, make_parent_window)
3633 (resize_window_check, resize_window_apply, Fresize_window_apply)
3634 (resize_frame_windows, Fsplit_window_internal)
3635 (Fdelete_window_internal, Fresize_mini_window_internal):
3637 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3639 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3641 * window.h (window): Add some new members to window structure -
3642 normal_lines, normal_cols, new_total, new_normal, clone_number,
3643 splits, nest, prev_buffers, next_buffers.
3644 (WINDOW_TOTAL_SIZE): Move here from window.c.
3645 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3647 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3649 (make_dummy_parent): Set new members of windows structure.
3650 (make_window): Move down in code. Handle new members of window
3652 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3653 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3654 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3655 (Fset_window_prev_buffers, Fwindow_next_buffers)
3656 (Fset_window_next_buffers, Fset_window_clone_number):
3658 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3659 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3661 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3662 Argument WINDOW can be now internal window too.
3663 (Fwindow_use_time): Move up in code.
3664 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3666 (Fset_window_configuration, saved_window)
3667 (Fcurrent_window_configuration, save_window_save): Handle new
3668 members of window structure.
3669 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3670 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3671 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3672 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3673 Qget_mru_window, Qresize_root_window,
3674 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3675 Qauto_buffer_name; staticpro them.
3677 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3679 * window.c (Fwindow_total_size, Fwindow_left_column)
3680 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3681 (Fwindow_list_1): New functions.
3682 (window_box_text_cols): Replace with window_body_cols.
3683 (Fwindow_width, Fscroll_left, Fscroll_right):
3684 Use window_body_cols instead of window_box_text_cols.
3685 (delete_window, Fset_window_configuration):
3686 Call delete_all_subwindows with window as argument.
3687 (delete_all_subwindows): Take a window as argument and not a
3689 (window_loop): Remove handling of GET_LRU_WINDOW and
3691 (Fget_lru_window, Fget_largest_window): Move to window.el.
3693 * window.h: Extern window_body_cols instead of
3694 window_box_text_cols. delete_all_subwindows now takes a
3695 Lisp_Object as argument.
3697 * indent.c (compute_motion, Fcompute_motion):
3698 Use window_body_cols instead of window_box_text_cols.
3700 * frame.c (delete_frame): Call delete_all_subwindows with root
3703 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3705 * fns.c (Fputhash): Document return value.
3707 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3709 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3711 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3713 Cons<->int and similar integer overflow fixes (Bug#8794).
3715 Check for overflow when converting integer to cons and back.
3716 * charset.c (Fdefine_charset_internal, Fdecode_char):
3717 Use cons_to_unsigned to catch overflow.
3718 (Fencode_char): Use INTEGER_TO_CONS.
3719 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3720 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3721 * data.c (long_to_cons, cons_to_long): Remove.
3722 (cons_to_unsigned, cons_to_signed): New functions.
3723 These signal an error for invalid or out-of-range values.
3724 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3725 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3726 * font.c (Ffont_variation_glyphs):
3727 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3728 * lisp.h: Include <intprops.h>.
3729 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3730 (cons_to_signed, cons_to_unsigned): New decls.
3731 (long_to_cons, cons_to_long): Remove decls.
3732 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3733 (Fprimitive_undo): Use CONS_TO_INTEGER.
3734 * xfns.c (Fx_window_property): Likewise.
3735 * xselect.c: Include <limits.h>.
3736 (x_own_selection, selection_data_to_lisp_data):
3737 Use INTEGER_TO_CONS.
3738 (x_handle_selection_request, x_handle_selection_clear)
3739 (x_get_foreign_selection, Fx_disown_selection_internal)
3740 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3741 (lisp_data_to_selection_data): Use cons_to_unsigned.
3742 (x_fill_property_data): Use cons_to_signed.
3743 Report values out of range.
3745 Check for buffer and string overflow more precisely.
3746 * buffer.h (BUF_BYTES_MAX): New macro.
3747 * lisp.h (STRING_BYTES_MAX): New macro.
3748 * alloc.c (Fmake_string):
3749 * character.c (string_escape_byte8):
3750 * coding.c (coding_alloc_by_realloc):
3751 * doprnt.c (doprnt):
3752 * editfns.c (Fformat):
3754 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3755 since they may not be the same number.
3756 * editfns.c (Finsert_char):
3757 * fileio.c (Finsert_file_contents):
3758 Likewise for BUF_BYTES_MAX.
3760 * image.c: Use ptrdiff_t, not int, for sizes.
3761 (slurp_file): Switch from int to ptrdiff_t.
3763 (slurp_file): Check that file size fits in both size_t (for
3764 malloc) and ptrdiff_t (for sanity and safety).
3766 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3767 if b->modtime has its maximal value.
3769 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3771 Don't assume time_t can fit into int.
3772 * buffer.h (struct buffer.modtime): Now time_t, not int.
3773 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3774 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3776 Minor fixes for signed vs unsigned integers.
3777 * character.h (MAYBE_UNIFY_CHAR):
3778 * charset.c (maybe_unify_char):
3779 * keyboard.c (read_char, reorder_modifiers):
3780 XINT -> XFASTINT, since the integer must be nonnegative.
3781 * ftfont.c (ftfont_spec_pattern):
3782 * keymap.c (access_keymap, silly_event_symbol_error):
3783 XUINT -> XFASTINT, since the integer must be nonnegative.
3784 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3785 since it makes no difference and we prefer signed.
3786 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3787 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3790 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3792 * window.h (Fwindow_frame): Declare.
3794 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3796 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3797 (SPARE_MEMORY): Always define.
3798 (LARGE_REQUEST): Remove.
3799 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3801 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3803 * lisp.h: Move EXFUNS for Fframe_root_window,
3804 Fframe_first_window and Fset_frame_selected_window to window.h.
3806 * window.h: Move EXFUNS for Fframe_root_window,
3807 Fframe_first_window and Fset_frame_selected_window here from
3810 * frame.c (Fwindow_frame, Fframe_first_window)
3811 (Fframe_root_window, Fframe_selected_window)
3812 (Fset_frame_selected_window): Move to window.c.
3813 (Factive_minibuffer_window): Move to minibuf.c.
3814 (Fother_visible_frames_p): New function.
3816 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3818 * window.c (decode_window, decode_any_window): Move up in code.
3819 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3820 (inhibit_frame_unsplittable): Remove unused variable.
3821 (Fwindow_buffer): Move up and rewrite doc-string.
3822 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3823 (Fwindow_prev): New functions.
3824 (Fwindow_frame): Move here from frame.c. Accept any window as
3826 (Fframe_root_window, Fframe_first_window)
3827 (Fframe_selected_window): Move here from frame.c. Accept frame
3828 or arbitrary window as argument. Update doc-strings.
3829 (Fminibuffer_window): Move up in code.
3830 (Fwindow_minibuffer_p): Move up in code and simplify.
3831 (Fset_frame_selected_window): Move here from frame.c.
3833 (Fselected_window, select_window, Fselect_window): Move up in
3834 code. Minor doc-string fixes.
3836 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3838 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3839 Do not assume that spare memory exists; that assumption is valid
3840 only if SYSTEM_MALLOC.
3841 (LARGE_REQUEST): New macro, so that the issue of large requests
3842 is separated from the issue of spare memory.
3844 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3846 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3849 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3851 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3854 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3856 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3858 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3860 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3861 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3863 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3865 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3867 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3869 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3870 (x_clipboard_manager_save): Add return value.
3871 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3873 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3874 Obey Vx_select_enable_clipboard_manager. Catch errors in
3875 x_clipboard_manager_save (Bug#8779).
3876 (Vx_select_enable_clipboard_manager): New variable.
3877 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3879 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3881 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3883 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3885 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3886 in the current matrix if keep_current_p is non-zero.
3888 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3890 * bidi.c (bidi_level_of_next_char): Fix last change.
3892 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3894 Support bidi reordering of text covered by display properties.
3896 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3897 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3898 (bidi_cache_search, bidi_cache_iterator_state)
3899 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3900 (bidi_level_of_next_char, bidi_move_to_visually_next):
3901 Support character positions inside a run of characters covered by a
3903 (bidi_paragraph_init, bidi_resolve_explicit_1)
3904 (bidi_level_of_next_char): Call bidi_fetch_char and
3905 bidi_fetch_char_advance instead of FETCH_CHAR and
3907 (bidi_init_it): Initialize new members.
3908 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3910 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3911 instead of using explicit *_CHAR codes.
3912 (bidi_resolve_explicit, bidi_resolve_weak):
3913 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3914 bidirectional text is supported only in multibyte buffers.
3915 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3916 it to initialize the frame_window_p member of struct bidi_it.
3917 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3918 (bidi_resolve_explicit, bidi_resolve_weak)
3919 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3920 bidi_it->nchars is non-positive.
3921 (bidi_level_of_next_char): Don't try to lookup the cache for the
3922 next/previous character if nothing is cached there yet, or if we
3923 were just reseat()'ed to a new position.
3925 * xdisp.c (set_cursor_from_row): Set start and stop points
3926 according to the row's direction when priming the loop that looks
3927 for the glyph on which to display cursor.
3928 (single_display_spec_intangible_p): Function deleted.
3929 (display_prop_intangible_p): Reimplement to call
3930 handle_display_spec instead of single_display_spec_intangible_p.
3931 Accept 3 additional arguments needed by handle_display_spec.
3932 This fixes incorrect cursor motion across display property with complex
3933 values: lists, `(when COND...)' forms, etc.
3934 (single_display_spec_string_p): Support property values that are
3935 lists with the argument STRING its top-level element.
3936 (display_prop_string_p): Fix the condition for processing a
3937 property that is a list to be consistent with handle_display_spec.
3938 (handle_display_spec): New function, refactored from the
3939 last portion of handle_display_prop.
3940 (compute_display_string_pos): Accept additional argument
3941 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3942 value of a `display' property is a "replacing spec".
3943 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3944 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3945 the display property, but just return a value indicating whether
3946 the display property will replace the characters it covers.
3947 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3948 frame_window_p members of struct bidi_it.
3949 (compute_display_string_pos, compute_display_string_end):
3951 (push_it): Accept second argument POSITION, where pop_it should
3952 jump to continue iteration.
3953 (reseat_1): Initialize bidi_it.disp_pos.
3955 * keyboard.c (adjust_point_for_property): Adjust the call to
3956 display_prop_intangible_p to its new signature.
3958 * dispextern.h (struct bidi_it): New member frame_window_p.
3959 (bidi_init_it): Update prototypes.
3960 (display_prop_intangible_p): Update prototype.
3961 (compute_display_string_pos, compute_display_string_end):
3963 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3966 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3968 Malloc failure behavior now depends on size of allocation.
3969 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3970 * lisp.h: Change signatures accordingly.
3971 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3972 All callers changed. (Bug#8762)
3974 * gnutls.c: Use Emacs's memory allocators.
3975 Without this change, the gnutls library would invoke malloc etc.
3976 directly, which causes problems on non-SYNC_INPUT hosts, and which
3977 runs afoul of improving memory_full behavior. (Bug#8761)
3978 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3979 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3980 xfree instead of the default malloc, realloc, free.
3981 (Fgnutls_boot): No need to check for memory allocation failure,
3982 since xmalloc does that for us.
3984 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3985 * category.c (hash_get_category_set):
3986 * ccl.c (ccl_driver):
3987 * charset.c (Fdefine_charset_internal):
3988 * charset.h (struct charset.hash_index):
3989 * composite.c (get_composition_id, gstring_lookup_cache)
3990 (composition_gstring_put_cache):
3991 * composite.h (struct composition.hash_index):
3992 * dispextern.h (struct image.hash):
3993 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3994 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3995 (hashfn_equal, hashfn_user_defined, make_hash_table)
3996 (maybe_resize_hash_table, hash_lookup, hash_put)
3997 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3998 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3999 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4000 * image.c (make_image, search_image_cache, lookup_image)
4001 (xpm_put_color_table_h):
4002 * lisp.h (struct Lisp_Hash_Table):
4003 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4004 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4005 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4006 * alloc.c (allocate_vectorlike):
4007 Check for overflow in vector size calculations.
4008 * ccl.c (ccl_driver):
4009 Check for overflow when converting EMACS_INT to int.
4010 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4011 need to be updated by these changes.
4012 * fns.c (make_hash_table, maybe_resize_hash_table):
4013 Check for integer overflow with large hash tables.
4014 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4015 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4016 (SXHASH_REDUCE): New macro.
4017 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4018 Use it instead of discarding useful hash info with large hash values.
4019 (sxhash_float): New function.
4020 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4021 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4022 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4023 Rewrite to use FIXNUM_BITS, as this simplifies things.
4024 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4025 Adjust signatures to match updated version of code.
4026 (consing_since_gc): Now EMACS_INT, since a single hash table can
4027 use more than INT_MAX bytes.
4029 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4031 Make it possible to build with GCC-4.6+ -O2 -flto.
4033 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4035 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4037 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4038 Call minibuffer-inactive-mode.
4040 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4042 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4043 Update dependencies.
4045 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4047 * data.c (init_data): Remove code for UTS, this system is not
4050 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4052 Don't force ./temacs to start in terminal mode.
4054 * frame.c (make_initial_frame): Initialize faces in all cases, not
4055 only when CANNOT_DUMP is defined.
4056 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4058 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4060 * dispnew.c (add_window_display_history): Use const for the string
4061 pointer. Remove declaration, not needed.
4063 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4065 Use 'inline', not 'INLINE'.
4066 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4067 * alloc.c, fontset.c (INLINE): Remove.
4068 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4069 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4070 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4071 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4072 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4074 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4076 Make it possible to run ./temacs.
4078 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4079 syms_of_callproc does the same thing. Remove test for
4080 "initialized", do it in the caller.
4081 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4083 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4085 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4086 (read_minibuf): Use get_minibuffer.
4087 (syms_of_minibuf): Use DEFSYM.
4088 (Qmetadata): New var.
4089 * data.c (Qbuffer): Don't make it static.
4090 (syms_of_data): Use DEFSYM.
4092 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4094 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4095 (CCL_CODE_MIN): New macro.
4097 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4099 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4101 * eval.c (Qdebug): Now static.
4102 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4103 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4104 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4106 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4108 * image.c: Various fixes to ImageMagick code comments.
4109 (Fimagemagick_types): Doc fix.
4111 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4113 Minor fixes prompted by GCC 4.6.0 warnings.
4115 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4117 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4118 (x_clipboard_manager_save_all): Move extern decl to ...
4119 * xterm.h: ... here, so that it can be checked for consistency.
4121 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4123 * xselect.c (x_clipboard_manager_save_frame)
4124 (x_clipboard_manager_save_all): New functions.
4125 (Fx_clipboard_manager_save): Lisp function deleted.
4127 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4128 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4130 * xterm.h: Update prototype.
4132 2011-05-28 William Xu <william.xwl@gmail.com>
4134 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4137 2011-05-28 Jim Meyering <meyering@redhat.com>
4139 Avoid a sign-extension bug in crypto_hash_function.
4140 * fns.c (to_uchar): Define.
4141 (crypto_hash_function): Use it to convert some newly-signed
4142 variables to unsigned, to avoid sign-extension bugs. For example,
4143 without this change, (md5 "truc") would evaluate to
4144 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4145 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4146 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4148 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4150 Integer overflow fixes.
4152 * dbusbind.c: Serial number integer overflow fixes.
4153 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4154 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4155 to hold a serial number that is too large for a fixnum.
4156 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4157 Check for serial numbers out of range. Decode any serial number
4158 that was so large that it became a float. (Bug#8722)
4160 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4161 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4162 Use XFASTINT rather than XUINT when numbers are nonnegative.
4163 (xd_append_arg, Fdbus_method_return_internal):
4164 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4165 arguments, check that Lisp number is nonnegative, rather than
4166 silently wrapping negative numbers around. (Bug#8722)
4167 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4170 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4172 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4174 ccl: add integer overflow checks
4175 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4176 (IN_INT_RANGE): New macros.
4177 (ccl_driver): Use them to check for integer overflow when
4178 decoding a CCL program. Many of the new checks are whether XINT (x)
4179 fits in int; it doesn't always, on 64-bit hosts. The new version
4180 doesn't catch all possible integer overflows, but it's an
4181 improvement. (Bug#8719)
4183 * alloc.c (make_event_array): Use XINT, not XUINT.
4184 There's no need for unsigned here.
4186 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4187 This follows up to the 2011-05-06 change that substituted uintptr_t
4188 for EMACS_INT. This case wasn't caught back then.
4190 Rework Fformat to avoid integer overflow issues.
4191 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4192 now (part of C89). Include <verify.h>.
4193 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4194 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4195 (Fformat): Avoid the prepass trying to compute sizes; it was only
4196 approximate and thus did not catch overflow reliably. Instead, walk
4197 through the format just once, formatting and computing sizes as we go,
4198 checking for integer overflow at every step, and allocating a larger
4199 buffer as needed. Keep track separately whether the format is
4200 multibyte. Keep only the most-recently calculated precision, rather
4201 than them all. Record whether each argument has been converted to
4202 string. Use EMACS_INT, not int, for byte and char and arg counts.
4203 Support field widths and precisions larger than INT_MAX. Avoid
4204 sprintf's undefined behavior with conversion specifications such as %#d
4205 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4206 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4207 formatting out-of-range floating point numbers with int
4210 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4212 * data.c: Avoid integer truncation in expressions involving floats.
4213 * data.c: Include <intprops.h>.
4214 (arith_driver): When there's an integer overflow in an expression
4215 involving floating point, convert the integers to floating point
4216 so that the resulting value does not suffer from catastrophic
4217 integer truncation. For example, on a 64-bit host (* 4
4218 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4219 Do not rely on undefined behavior after integer overflow.
4221 merge count_size_as_multibyte, parse_str_to_multibyte
4222 * character.c, character.h (count_size_as_multibyte):
4223 Rename from parse_str_to_multibyte; all uses changed.
4224 Check for integer overflow.
4225 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4226 since it's now a duplicate of the other. This is more of
4227 a character than a buffer op, so better that it's in character.c.
4228 * fns.c, print.c: Adjust to above changes.
4230 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4232 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4234 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4236 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4237 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4238 (x_clipboard_manager_save): Now static.
4239 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4241 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4242 (crypto_hash_function): Now static.
4243 Fix pointer signedness problems. Avoid unnecessary initializations.
4245 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4247 * termhooks.h (Vselection_alist): Make it terminal-local.
4249 * terminal.c (create_terminal): Initialize it.
4251 * xselect.c: Support for clipboard managers.
4252 (Vselection_alist): Move to termhooks.h as terminal-local var.
4253 (LOCAL_SELECTION): New macro.
4254 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4255 (symbol_to_x_atom): Remove gratuitous arg.
4256 (x_handle_selection_request, lisp_data_to_selection_data)
4257 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4258 (x_own_selection, x_get_local_selection, x_convert_selection):
4259 New arg, specifying work frame. Use terminal-local Vselection_alist.
4260 (some_frame_on_display): Delete unused function.
4261 (Fx_own_selection_internal, Fx_get_selection_internal)
4262 (Fx_disown_selection_internal, Fx_selection_owner_p)
4263 (Fx_selection_exists_p): New optional frame arg.
4264 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4265 (x_handle_selection_clear): Don't treat other terminals with the
4266 same keyboard specially. Use the terminal-local Vselection_alist.
4267 (x_clear_frame_selections): Use Frun_hook_with_args.
4269 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4271 * xterm.h: Add support for those atoms.
4273 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4275 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4276 (converted_selections, conversion_fail_tag): New global variables.
4277 (x_selection_request_lisp_error): Free the above.
4278 (x_get_local_selection): Remove unnecessary code.
4279 (x_reply_selection_request): Args changed; handle arbitrary array
4280 of converted selections stored in converted_selections.
4281 Separate the XChangeProperty and SelectionNotify steps.
4282 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4283 (x_convert_selection): New function.
4284 (x_handle_selection_event): Simplify.
4285 (x_get_foreign_selection): Don't ignore incoming requests while
4286 waiting for an answer; this will fail when we implement
4287 SAVE_TARGETS, and seems unnecessary anyway.
4288 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4289 (Vx_sent_selection_functions): Doc fix.
4291 2011-05-26 Leo Liu <sdl.web@gmail.com>
4293 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4295 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4297 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4299 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4300 for fringe update if it has periodic bitmap.
4301 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4302 and fringe_bitmap_periodic_p.
4304 * fringe.c (get_fringe_bitmap_data): New function.
4305 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4306 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4307 row. Mark glyph row for fringe update if periodicity changed.
4309 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4310 for fringe update unless it has periodic bitmap.
4312 2011-05-25 Kenichi Handa <handa@m17n.org>
4314 * xdisp.c (get_next_display_element): Set correct it->face_id for
4315 a static composition.
4317 2011-05-24 Leo Liu <sdl.web@gmail.com>
4320 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4322 * fns.c (crypto_hash_function, Fsha1): New function.
4323 (Fmd5): Use crypto_hash_function.
4324 (syms_of_fns): Add Ssha1.
4326 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4328 * gnutls.c: Remove unused macros.
4329 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4330 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4331 Remove macros that are defined and never used.
4332 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4334 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4336 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4337 (Fx_get_selection_internal): Minor cleanup.
4338 (Fx_own_selection_internal): Rename arguments for consistency with
4341 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4343 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4345 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4347 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4349 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4351 * dispnew.c (scrolling_window): Don't exclude the case that the
4352 last enabled row in the desired matrix touches the bottom boundary.
4354 2011-05-21 Glenn Morris <rgm@gnu.org>
4356 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4357 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4358 and add some more files.
4360 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4362 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4363 report_file_error introduced by the change from 2011-05-07.
4365 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4367 * systime.h (Time): Define only if emacs is defined.
4368 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4369 where the include path doesn't have X11/X.h by default. See
4370 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4372 2011-05-20 Kenichi Handa <handa@m17n.org>
4374 * composite.c (find_automatic_composition): Fix previous change.
4376 2011-05-20 Glenn Morris <rgm@gnu.org>
4378 * lisp.mk: New file, split from Makefile.in.
4379 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4380 (shortlisp): Remove.
4381 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4383 2011-05-19 Glenn Morris <rgm@gnu.org>
4385 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4386 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4387 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4388 (lisp): Set the order to that of loadup.el.
4389 (shortlisp): Make it a copy of $lisp.
4390 (SOME_MACHINE_LISP): Remove.
4391 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4392 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4394 2011-05-18 Kenichi Handa <handa@m17n.org>
4396 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4397 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4398 (find_automatic_composition): Mostly rewrite for efficiency.
4400 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4402 * makefile.w32-in: Update dependencies.
4404 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4406 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4407 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4409 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4411 Fix some integer overflow issues, such as string length overflow.
4413 * insdel.c (count_size_as_multibyte): Check for string overflow.
4415 * character.c (lisp_string_width): Check for string overflow.
4416 Use EMACS_INT, not int, for string indexes and lengths; in
4417 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4418 the resulting string length overflows an EMACS_INT; instead,
4419 report a string overflow if no precision given. When checking for
4420 precision exhaustion, use a check that cannot possibly have
4421 integer overflow. (Bug#8675)
4422 * character.h (lisp_string_width): Adjust to new signature.
4424 * alloc.c (string_overflow): New function.
4425 (Fmake_string): Use it. This doesn't change behavior, but saves
4426 a few bytes and will simplify future changes.
4427 * character.c (string_escape_byte8): Likewise.
4428 * lisp.h (string_overflow): New decl.
4430 Fixups, following up to the user-interface timestamp change.
4431 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4432 for UI timestamps, instead of unsigned long.
4433 * msdos.c (mouse_get_pos): Likewise.
4434 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4435 * w32gui.h (Time): Define by including "systime.h" rather than by
4436 declaring it ourselves. (Bug#8664)
4438 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4439 * image.c (clear_image_cache): Likewise.
4441 * term.c (term_mouse_position): Don't assume time_t wraparound.
4443 Be more systematic about user-interface timestamps.
4444 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4445 and sometimes 'EMACS_UINT', to represent these timestamps.
4446 This change causes it to use 'Time' uniformly, as that's what X uses.
4447 This makes the code easier to follow, and makes it easier to catch
4448 integer overflow bugs such as Bug#8664.
4449 * frame.c (Fmouse_position, Fmouse_pixel_position):
4450 Use Time, not unsigned long, for user-interface timestamps.
4451 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4452 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4453 * keyboard.h (last_event_timestamp): Likewise.
4454 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4455 * menu.h (xmenu_show): Likewise.
4456 * term.c (term_mouse_position): Likewise.
4457 * termhooks.h (struct input_event.timestamp): Likewise.
4458 (struct terminal.mouse_position_hook): Likewise.
4459 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4460 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4461 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4462 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4464 * menu.h, termhooks.h: Include "systime.h", for Time.
4466 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4467 Don't assume that the difference between two unsigned long values
4468 can fit into an integer. At this point, we know button_down_time
4469 <= event->timestamp, so the difference must be nonnegative, so
4470 there's no need to cast the result if double-click-time is
4471 nonnegative, as it should be; check that it's nonnegative, just in
4472 case. This bug is triggered when events are more than 2**31 ms
4473 apart (about 25 days). (Bug#8664)
4475 * xselect.c (last_event_timestamp): Remove duplicate decl.
4476 (x_own_selection): Remove needless cast to unsigned long.
4478 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4479 that always fit in int. Use a sentinel instead of a counter, to
4480 avoid a temp and to allay GCC's concerns about possible int overflow.
4481 * frame.h (struct frame): Use int for menu_bar_items_used
4482 instead of EMACS_INT, since it always fits in int.
4484 * menu.c (grow_menu_items): Check for int overflow.
4486 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4488 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4489 Before, the code was not consistent. These values cannot exceed
4490 2**31 - 1 so there's no need to make them unsigned.
4491 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4492 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4493 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4495 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4497 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4498 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4499 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4500 presumably because the widths might not match.
4502 * window.c (size_window): Avoid needless test at loop start.
4504 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4506 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4508 2011-05-12 Drew Adams <drew.adams@oracle.com>
4510 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4512 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4514 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4515 `width' to `bar_area_x' and `bar_area_width', respectively.
4516 (x_scroll_run): Take account of fringe background extension.
4518 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4519 Rename local vars `left' and `width' to `bar_area_x' and
4520 `bar_area_width', respectively.
4521 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4522 background extension.
4524 2011-05-10 Jim Meyering <meyering@redhat.com>
4526 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4528 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4530 * image.c (Finit_image_library): Return t for built-in image types,
4531 like pbm and xbm. (Bug#8640)
4533 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4535 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4537 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4539 * w32console.c (Fset_screen_color): Doc fix.
4540 (Fget_screen_color): New function.
4541 (syms_of_ntterm): Defsubr it.
4543 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4544 unlink the temporary file if Fcall_process didn't create it in the
4546 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4547 child process will be redirected to a file specified with `:file'.
4548 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4549 cue to call_process_cleanup not to close that handle.
4551 2011-05-07 Ben Key <bkey76@gmail.com>
4553 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4554 one of two shell specific rules, either bootstrap-temacs-CMD or
4555 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4556 to the previous implementation of the bootstrap-temacs rule.
4557 The bootstrap-temacs-CMD rule is similar to the previous
4558 implementation of the bootstrap-temacs rule except that it
4559 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4562 These changes, along with some changes to nt/configure.bat,
4563 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4564 earlier fix to add support for --cflags and --ldflags options
4565 that include quotes so that it works whether make uses cmd or
4568 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4570 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4571 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4573 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4574 a string. Handle both cases.
4575 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4576 (Fdbus_register_method): Use Qinvalid_function.
4578 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4580 * makefile.w32-in: Update dependencies.
4581 (LISP_H): Add inttypes.h and stdin.h.
4582 (PROCESS_H): Add unistd.h.
4584 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4586 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4587 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4589 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4591 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4593 * term.c (vfatal): Remove stray call to va_end.
4594 It's not needed and the C Standard doesn't allow it here anyway.
4596 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4597 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4599 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4602 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4604 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4606 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4608 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4610 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4612 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4613 * charset.c (Fdefine_charset_internal): Don't initialize
4614 charset.code_space[15]. The value was garbage, on hosts with
4615 32-bit int (Bug#8600).
4617 * lread.c (read_integer): Be more consistent with string-to-number.
4618 Use string_to_number to do the actual conversion; this avoids
4619 rounding errors and fixes some other screwups. Without this fix,
4620 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4621 (digit_to_number): Move earlier, for benefit of read_integer.
4622 Return -1 if the digit is out of range for the base, -2 if it is
4623 not a digit in any supported base. (Bug#8602)
4625 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4627 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4628 to match comment at start of function. This also removes a
4629 GCC warning about overflow in a 32+64-bit port.
4631 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4633 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4634 Reported by Stefan Monnier in
4635 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4636 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4637 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4639 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4640 (EMACS_UINTPTR): Likewise, with uintptr_t.
4642 * lisp.h: Prefer 64-bit EMACS_INT if available.
4643 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4644 on 32-bit hosts that have 64-bit int, so that they can access
4646 However, temporarily disable this change unless the temporary
4647 symbol WIDE_EMACS_INT is defined.
4649 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4651 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4652 This removes an assumption that EMACS_INT and long are the same
4653 width as pointers. The assumption is true for Emacs porting targets
4654 now, but we want to make other targets possible.
4655 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4656 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4657 In the rest of the code, change types of integers that hold casted
4658 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4659 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4660 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4661 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4662 No need to cast type when ORing.
4663 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4664 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4665 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4666 assume EMACS_INT is the same width as char *.
4667 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4668 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4669 Remove no-longer-needed casts.
4670 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4671 (xg_tool_bar_help_callback, xg_make_tool_item):
4672 Use EMACS_INTPTR to hold an integer
4673 that will be cast to void *; this can avoid a GCC warning
4674 if EMACS_INT is not the same width as void *.
4675 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4676 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4677 (current_message_1, set_message_1):
4678 Use a local to convert to proper width without a cast.
4679 * xmenu.c (dialog_selection_callback): Likewise.
4681 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4682 Also, don't assume VALBITS / RAND_BITS is less than 5,
4683 and don't rely on undefined behavior when shifting a 1 left into
4685 * lisp.h (get_random): Change signature to match.
4687 * lread.c (hash_string): Use size_t, not int, for hash computation.
4688 Normally we prefer signed values; but hashing is special, because
4689 it's better to use unsigned division on hash table sizes so that
4690 the remainder is nonnegative. Also, size_t is the natural width
4691 for hashing into memory. The previous code used 'int', which doesn't
4692 retain enough info to hash well into very large tables.
4693 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4695 * dbusbind.c: Don't possibly lose pointer info when converting.
4696 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4697 Use XPNTR rather than XHASH, so that the high-order bits of
4698 the pointer aren't lost when converting through void *.
4700 * eval.c (Fautoload): Don't double-shift a pointer.
4702 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4704 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4706 * gnutls.c (DEF_GNUTLS_FN):
4707 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4709 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4711 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4714 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4716 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4717 New version that can reserve upto 2GB of heap space.
4719 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4721 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4723 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4725 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4726 `gnutls_certificate_set_x509_key_file'.
4728 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4730 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4731 Update dependencies.
4733 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4735 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4736 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4737 Remove unused parameter `fildes'.
4738 * process.c (read_process_output, send_process): Don't pass it.
4740 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4742 Fix previous change: the library cache is defined in w32.c.
4743 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4744 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4746 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4748 Implement dynamic loading of GnuTLS on Windows.
4750 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4751 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4752 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4755 * gnutls.c (Qgnutls_dll): Define.
4756 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4757 (gnutls_*): Declare function pointers.
4758 (init_gnutls_functions): New function to initialize function pointers.
4759 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4760 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4761 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4762 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4763 (emacs_gnutls_write, emacs_gnutls_read)
4764 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4765 (Fgnutls_available_p): New function.
4766 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4767 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4768 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4770 * image.c: Include w32.h.
4771 (Vimage_type_cache): Delete.
4772 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4773 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4774 (w32_delayed_load): Move to w32.c.
4776 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4778 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4779 (w32_delayed_load): Move from image.c. When loading a library, record
4780 its filename in the :loaded-from property of the library id.
4781 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4782 Initialize and staticpro them.
4783 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4785 * process.c: Include lisp.h before w32.h, not after.
4786 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4787 instead of gnutls_record_check_pending.
4789 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4791 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4793 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4794 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4797 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4799 * xterm.c (x_set_frame_alpha): Do not set property on anything
4800 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4802 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4804 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4806 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4808 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4809 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4810 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4811 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4812 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4813 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4814 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4815 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4816 (Qgnutls_bootprop_callbacks_verify): Make static.
4818 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4820 * callproc.c: Indentation fixup.
4822 * sysdep.c (wait_for_termination_1): Make static.
4823 (wait_for_termination, interruptible_wait_for_termination):
4824 Move after wait_for_termination_1.
4826 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4828 * sysdep.c (interruptible_wait_for_termination): New function
4829 which is like wait_for_termination, but allows keyboard
4832 * callproc.c (Fcall_process): Add (:file "file") as an option for
4834 (Fcall_process_region): Ditto.
4836 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4838 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4839 rather than `XVECTOR (FOO)->size'.
4841 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4842 inttypes.h, as a gnulib replacement is used if it not available in
4845 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4847 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4848 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4849 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4851 * coding.c (coding_alloc_by_realloc): Error out if destination
4852 will grow beyond MOST_POSITIVE_FIXNUM.
4853 (decode_coding_emacs_mule): Abort if there isn't enough place in
4854 charbuf for the composition carryover bytes. Reserve an extra
4855 space for up to 2 characters produced in a loop.
4856 (decode_coding_iso_2022): Abort if there isn't enough place in
4857 charbuf for the composition carryover bytes.
4859 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4861 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4862 aborting when %lld or %lll format is passed.
4863 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4864 %llo or %llx format is passed. (Bug#8545)
4866 * window.c (window_scroll_line_based): Use a marker instead of
4867 simple variables to record original value of point. (Bug#7952)
4869 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4870 produced by %s or %c overflows available buffer space. (Bug#8545)
4872 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4874 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4875 (SIZE_MAX): Move defn after all includes, as they might #define it.
4877 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4879 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4881 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4883 * keyboard.c (Qdelayed_warnings_hook): Define.
4884 (command_loop_1): Run `delayed-warnings-hook'
4885 if Vdelayed_warnings_list is non-nil.
4886 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4887 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4889 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4891 * doprnt.c (doprnt): Don't return value smaller than the buffer
4892 size if the message was truncated. (Bug#8545).
4894 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4896 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4897 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4899 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4901 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4903 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4905 * makefile.w32-in: Update dependencies.
4907 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4909 Improve `doprnt' and its usage. (Bug#8545)
4910 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4911 `format_end'. Remove support for %l as a conversion specifier.
4912 Don't use xrealloc. Improve diagnostics when the %l size modifier
4913 is used. Update the commentary.
4915 * eval.c (verror): Simplify calculation of size_t.
4917 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4920 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4922 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4925 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4927 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4928 This makes this file independent of the recent pseudovector change.
4930 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4932 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4934 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4935 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4936 Remove unused local.
4937 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4939 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4940 GCC 4.6.0 optimizes based on type-based alias analysis.
4941 For example, if b is of type struct buffer * and v of type struct
4942 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4943 != &v->size, and therefore "v->size = 1; b->size = 2; return
4944 v->size;" must therefore return 1. This assumption is incorrect
4945 for Emacs, since it type-puns struct Lisp_Vector * with many other
4946 types. To fix this problem, this patch adds a new type struct
4947 vectorlike_header that documents the constraints on layout of vectors
4948 and pseudovectors, and helps optimizing compilers not get fooled
4949 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4950 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4951 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4953 (XSETPVECTYPE): Rewrite in terms of new macro.
4954 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4955 This is a bit clearer, and further avoids the possibility of
4956 undesirable aliasing.
4957 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4958 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4959 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4960 since Lisp_Subr is a special case (no "next" field).
4961 (ASIZE): Now uses header.size rather than size.
4962 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4963 to avoid the hassle of writing XVECTOR (foo)->header.size.
4964 (struct vectorlike_header): New type.
4965 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4966 object, to help avoid aliasing.
4967 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4968 (SUBRP): Likewise, since Lisp_Subr is a special case.
4969 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4970 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4971 (struct Lisp_Hash_Table): Combine first two members into a single
4972 struct vectorlike_header member. All uses of "size" and "next" members
4973 changed to be "header.size" and "header.next".
4974 * buffer.h (struct buffer): Likewise.
4975 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4976 * frame.h (struct frame): Likewise.
4977 * process.h (struct Lisp_Process): Likewise.
4978 * termhooks.h (struct terminal): Likewise.
4979 * window.c (struct save_window_data, struct saved_window): Likewise.
4980 * window.h (struct window): Likewise.
4981 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4982 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4983 * buffer.c (init_buffer_once): Likewise.
4984 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4986 * process.c (Fformat_network_address): Use local var for size,
4989 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4991 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4992 * data.c (atof): Remove decl; no longer used or needed.
4993 (digit_to_number): Move to lread.c.
4994 (Fstring_to_number): Use new string_to_number function, to be
4995 consistent with how the Lisp reader treats infinities and NaNs.
4996 Do not assume that floating-point numbers represent EMACS_INT
4997 without losing information; this is not true on most 64-bit hosts.
4998 Avoid double-rounding errors, by insisting on integers when
4999 parsing non-base-10 numbers, as the documentation specifies.
5000 * lisp.h (string_to_number): New decl, replacing ...
5001 (isfloat_string): Remove.
5002 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5003 (read1): Do not accept +. and -. as integers; this
5004 appears to have been a coding error. Similarly, do not accept
5005 strings like +-1e0 as floating point numbers. Do not report
5006 overflow for integer overflows unless the base is not 10 which
5007 means we have no simple and reliable way to continue.
5008 Break out the floating-point parsing into a new
5009 function string_to_number, so that Fstring_to_number parses
5010 floating point numbers consistently with the Lisp reader.
5011 (digit_to_number): Move here from data.c. Make it static inline.
5012 (E_CHAR, EXP_INT): Remove, replacing with ...
5013 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5014 (string_to_number): New function, replacing isfloat_string.
5015 This function checks for valid syntax and produces the resulting
5016 Lisp float number too. Rework it so that string-to-number
5017 no longer mishandles examples like "1.0e+". Use strtoumax,
5018 so that overflow for non-base-10 numbers is reported only when
5019 there's no portable and simple way to convert to floating point.
5021 * textprop.c (set_text_properties_1): Rewrite for clarity,
5022 and to avoid GCC warning about integer overflow.
5024 * intervals.h (struct interval): Use EMACS_INT for members
5025 where EMACS_UINT might cause problems. See
5026 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5027 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5028 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5030 (offset_intervals): Tell GCC not to worry about length overflow
5031 when negating a negative length.
5033 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5034 (overrun_check_free): Likewise.
5036 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5037 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5040 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5041 (gnutls_make_error): Rename local to avoid shadowing.
5042 (gnutls_emacs_global_deinit): ifdef out; not used.
5043 (Fgnutls_boot): Use const for pointer to readonly storage.
5044 Comment out unused local. Fix pointer signedness problems.
5046 * lread.c (openp): Don't stuff size_t into an 'int'.
5047 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5048 about possible signed overflow.
5050 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5051 (GDK_KEY_g): Don't define if already defined.
5052 (xg_prepare_tooltip): Avoid pointer signedness problem.
5053 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5055 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5056 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5058 * xfns.c (Fx_window_property): Simplify a bit,
5059 to make a bit faster and to avoid GCC 4.6.0 warning.
5060 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5062 * fns.c (internal_equal): Don't assume size_t fits in int.
5064 * alloc.c (compact_small_strings): Tighten assertion a little.
5066 Replace pEd with more-general pI, and fix some printf arg casts.
5067 * lisp.h (pI): New macro, generalizing old pEd macro to other
5068 conversion specifiers. For example, use "...%"pI"d..." rather
5069 than "...%"pEd"...".
5070 (pEd): Remove. All uses replaced with similar uses of pI.
5071 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5072 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5073 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5074 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5075 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5076 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5077 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5079 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5080 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5081 * print.c (safe_debug_print, print_object): Likewise.
5082 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5084 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5085 avoiding the 0 flag, which is not portable.
5086 * process.c (Fmake_network_process): Use pI to avoid cast.
5087 * region-cache.c (pp_cache): Likewise.
5088 * xdisp.c (decode_mode_spec): Likewise.
5089 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5090 behavior on 64-bit hosts with printf arg.
5091 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5092 (x_stop_queuing_selection_requests): Likewise.
5093 (x_get_window_property): Don't truncate byte count to an 'int'
5096 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5097 here, since it parses constructs like leading '-' and spaces,
5098 which are not wanted; and it overflows with large numbers.
5099 Instead, simply match F[0-9]+, which is what is wanted anyway.
5101 * alloc.c: Remove unportable assumptions about struct layout.
5102 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5103 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5104 (allocate_vectorlike, make_pure_vector): Use the new macros,
5105 plus offsetof, to remove unportable assumptions about struct layout.
5106 These assumptions hold on all porting targets that I know of, but
5107 they are not guaranteed, they're easy to remove, and removing them
5108 makes further changes easier.
5110 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5111 This doesn't fix a bug but makes the code clearer.
5112 (string_overrun_cookie): Now const. Use initializers that
5113 don't formally overflow signed char, to avoid warnings.
5114 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5115 can cause Emacs to crash when string overrun checking is enabled.
5116 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5117 multiple of sizeof (EMACS_INT); it need not be, if
5118 alignof(EMACS_INT) < sizeof (EMACS_INT).
5119 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5121 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5123 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5125 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5127 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5128 supposed to be handshaking. (Bug#8556)
5129 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5131 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5133 * lisp.h (Qdebug): List symbol.
5134 * eval.c (Qdebug): Restore global linkage.
5135 * keyboard.c (debug-on-event): New variable.
5136 (handle_user_signal): Break into debugger when debug-on-event
5137 matches the current signal symbol.
5139 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5141 * alloc.c (check_sblock, check_string_bytes)
5142 (check_string_free_list): Convert to standard C.
5144 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5146 * w32.c (emacs_gnutls_push): Fix typo.
5148 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5150 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5151 "cast to pointer from integer of different size".
5153 Improve doprnt and its use in verror. (Bug#8545)
5154 * doprnt.c (doprnt): Document the set of format control sequences
5155 supported by the function. Use SAFE_ALLOCA instead of always
5158 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5159 is one byte too soon. Don't use xrealloc; instead xfree and
5162 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5164 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5167 * gnutls.c: Renamed global_initialized to
5168 gnutls_global_initialized. Added internals for the
5169 :verify-hostname-error, :verify-error, and :verify-flags
5170 parameters of `gnutls-boot' and documented those parameters in the
5171 docstring. Start callback support.
5172 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5173 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5174 on error. Return error code.
5175 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5176 (emacs_gnutls_read): Likewise.
5177 (Fgnutls_boot): Return handshake error code.
5178 (emacs_gnutls_handle_error): New function.
5179 (wsaerror_to_errno): Likewise.
5181 * w32.h (emacs_gnutls_pull): Add prototype.
5182 (emacs_gnutls_push): Likewise.
5184 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5185 (emacs_gnutls_push): Likewise.
5187 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5189 * process.c (wait_reading_process_output): Check if GnuTLS
5190 buffered some data internally if no FDs are set for TLS
5193 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5194 (LIBS): Link to USER_LIBS.
5195 ($(BLD)/gnutls.$(0)): New target.
5197 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5199 * xdisp.c (handle_single_display_spec): Rename the
5200 display_replaced_before_p argument into display_replaced_p, to
5201 make it consistent with the commentary. Fix typos in the
5204 * textprop.c (syms_of_textprop): Remove dead code.
5205 (copy_text_properties): Delete obsolete commentary about an
5206 interface that was deleted long ago. Fix typos in the description
5209 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5210 to changes in oldXMenu/XMenu.h from 2011-04-16.
5211 <menu_help_message, prev_menu_help_message>: Constify.
5212 (IT_menu_make_room): menu->help_text is now `const char **';
5215 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5216 to changes in oldXMenu/XMenu.h from 2011-04-16.
5217 (struct XMenu): Declare `help_text' `const char **'.
5219 * xfaces.c <Qunspecified>: Make extern again.
5221 * syntax.c: Include sys/types.h before including regex.h, as
5224 * doc.c (get_doc_string): Improve the format passed to `error'.
5226 * doprnt.c (doprnt): Improve commentary.
5228 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5230 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5233 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5234 changes in globals.h immediately force recompilation.
5235 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5236 $(CURDIR)/s/ms-w32.h.
5237 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5239 * character.c (Fchar_direction): Function deleted.
5240 (syms_of_character): Don't defsubr it.
5241 <char-direction-table>: Deleted.
5243 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5245 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5246 * doprnt.c: Include limits.h.
5247 (SIZE_MAX): New macro.
5248 (doprnt): Return a size_t value. 2nd arg is now size_t.
5249 Many local variables are now size_t instead of int or unsigned.
5250 Improve overflow protection. Support `l' modifier for integer
5251 conversions. Support %l conversion. Don't assume an EMACS_INT
5252 argument for integer conversions and for %c.
5254 * lisp.h (doprnt): Restore prototype.
5256 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5259 * Makefile.in (base_obj): Add back doprnt.o.
5261 * deps.mk (doprnt.o): Add back prerequisites.
5262 (callint.o): Depend on character.h.
5264 * eval.c (internal_lisp_condition_case): Include the handler
5265 representation in the error message.
5266 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5267 when breaking from the loop.
5269 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5271 * callint.c (Fcall_interactively): When displaying error message
5272 about invalid control letter, pass the character's codepoint, not
5273 a pointer to its multibyte form. Improve display of the character
5274 in octal and display also its hex code.
5276 * character.c (char_string): Use %x to display the (unsigned)
5277 codepoint of an invalid character, to avoid displaying a bogus
5280 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5281 `error', not SYMBOL_NAME itself.
5283 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5284 character arguments to `error'.
5286 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5287 to `error' in error message about FINAL_CHAR argument. Make sure
5288 FINAL_CHAR is a character, and use %c when it is passed as
5289 argument to `error'.
5291 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5293 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5295 * w32.c: Include <time.h>.
5296 (sys_localtime): New function.
5298 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5300 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5302 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5304 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5306 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5309 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5311 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5312 gl_state.e_property when gl_state.object is Qt.
5314 * insdel.c (make_gap_larger): Remove limitation of buffer size
5317 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5319 * xdisp.c (lookup_glyphless_char_display)
5320 (produce_glyphless_glyph): Handle cons cell entry in
5321 glyphless-char-display.
5322 (Vglyphless_char_display): Document it.
5324 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5325 glyphless-char-display.
5327 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5329 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5331 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5333 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5334 definition for no-X builds.
5336 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5338 Static checks with GCC 4.6.0 and non-default toolkits.
5340 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5342 * process.c (keyboard_bit_set): Define only if SIGIO.
5343 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5344 (send_process): Repair possible setjmp clobbering.
5346 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5348 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5350 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5352 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5353 Define only if needed.
5355 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5356 by pacifying GCC about it. Maybe it's time to retire it?
5357 * xfaces.c (USG, __TIMEVAL__): Likewise.
5359 * dispextern.h (struct redisplay_interface): Rename param
5361 * termhooks.h (struct terminal): Likewise.
5362 * xterm.c (xembed_send_message): Likewise.
5364 * insdel.c (make_gap_smaller): Define only if
5365 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5367 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5370 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5371 so that we aren't warned about unused symbols.
5373 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5375 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5377 * xfns.c (x_real_positions): Mark locals as initialized.
5379 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5381 * xterm.c: Fix problems found by static analysis with other toolkits.
5382 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5383 (x_dispatch_event): Declare static if USE_GTK, and
5384 define if USE_GTK || USE_X_TOOLKIT.
5385 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5386 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5387 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5388 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5390 * xmenu.c (menu_help_callback): Pointer type fixes.
5391 Use const pointers when pointing at readonly data. Avoid pointer
5393 (FALSE): Remove unused macro.
5394 (update_frame_menubar): Remove unused decl.
5396 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5398 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5399 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5400 (single_menu_item): Rename local to avoid shadowing.
5402 * keyboard.c (make_lispy_event): Remove unused local var.
5404 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5405 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5407 * bitmaps: Change bitmaps from unsigned char back to the X11
5408 compatible char. Avoid the old compiler warnings about
5409 out-of-range initializers by using, for example, '\xab' rather
5412 * xgselect.c (xgselect_initialize): Check vs interface
5413 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5415 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5417 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5418 to read-only memory.
5420 * fns.c (vector): Remove; this old hack is no longer needed.
5422 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5424 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5426 * xrdb.c (x_load_resources): Omit unused local.
5428 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5429 (x_window): Rename locals to avoid shadowing.
5430 (USG): Use the kludged USG macro, to pacify gcc.
5432 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5433 (x_term_init): Remove local to avoid shadowing.
5435 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5437 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5438 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5440 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5442 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5444 Fix regex.c, syntax.c and friends for buffers > 2GB.
5445 * syntax.h (struct gl_state_s): Declare character position members
5448 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5450 * textprop.c (verify_interval_modification, interval_of):
5451 Declare arguments EMACS_INT.
5453 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5456 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5458 * indent.c (Fvertical_motion): Local variable it_start is now
5461 * regex.c (re_match, re_match_2, re_match_2_internal)
5462 (bcmp_translate, regcomp, regexec, print_double_string)
5463 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5464 (re_compile_pattern, re_exec): Declare arguments and local
5465 variables `size_t' and `ssize_t' and return values `regoff_t', as
5467 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5468 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5469 <compile_stack_type>: `size' and `avail' are now `size_t'.
5471 * regex.h <regoff_t>: Use ssize_t, not int.
5472 (re_search, re_search_2, re_match, re_match_2): Arguments that
5473 specify buffer/string position and length are now ssize_t and
5474 size_t. Return type is regoff_t.
5476 2011-04-16 Ben Key <bkey76@gmail.com>
5478 * nsfont.m: Fixed bugs in ns_get_family and
5479 ns_descriptor_to_entity that were caused by using free to
5480 deallocate memory blocks that were allocated by xmalloc (via
5481 xstrdup). This caused Emacs to crash when compiled with
5482 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5483 --enable-checking=xmallocoverrun). xfree is now used to
5484 deallocate these memory blocks.
5486 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5488 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5490 emacs_write: Accept and return EMACS_INT for sizes.
5491 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5493 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5494 Accept and return EMACS_INT.
5495 (emacs_gnutls_write): Return the number of bytes written on
5497 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5498 (emacs_read, emacs_write): Remove check for negative size, as the
5499 Emacs source code has been audited now.
5500 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5501 (emacs_read, emacs_write): Use it.
5502 * process.c (send_process): Adjust to the new signatures of
5503 emacs_write and emacs_gnutls_write. Do not attempt to store
5504 a byte offset into an 'int'; it might overflow.
5505 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5507 * sound.c: Don't assume sizes fit in 'int'.
5508 (struct sound_device.period_size, alsa_period_size):
5509 Return EMACS_INT, not int.
5510 (struct sound_device.write, vox_write, alsa_write):
5511 Accept EMACS_INT, not int.
5512 (wav_play, au_play): Use EMACS_INT to store sizes and to
5513 record read return values.
5515 2011-04-15 Ben Key <bkey76@gmail.com>
5517 * keyboard.c (Qundefined): Don't declare static since it is used
5519 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5520 static since they are used in nsfont.m.
5522 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5524 * process.c (Qprocessp): Don't declare static.
5525 * lisp.h (Qprocessp): Declare again.
5527 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5529 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5531 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5533 Improve C-level modularity by making more things 'static'.
5535 Don't publish debugger-only interfaces to other modules.
5536 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5537 (verify_bytepos, count_markers): Move decls to the only modules
5539 * region-cache.h (pp_cache): Likewise.
5540 * window.h (check_all_windows): Likewise.
5541 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5543 * sysdep.c (croak): Now static, if
5544 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5545 * syssignal.h (croak): Declare only if not static.
5547 * alloc.c (refill_memory_reserve): Now static if
5548 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5549 * lisp.h (refill_memory_reserve): Declare only if not static.
5551 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5552 Define only if USE_LUCID.
5554 * xrdb.c (x_customization_string, x_rm_string): Now static.
5556 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5557 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5559 * xdisp.c (draw_row_with_mouse_face): Now static.
5560 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5562 * window.h (check_all_windows): Mark externally visible.
5564 * window.c (window_deletion_count): Now static.
5566 * undo.c: Make symbols static if they're not exported.
5567 (last_undo_buffer, last_boundary_position, pending_boundary):
5570 * textprop.c (interval_insert_behind_hooks): Now static.
5571 (interval_insert_in_front_hooks): Likewise.
5573 * term.c: Make symbols static if they're not exported.
5574 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5575 (max_frame_lines, tty_set_terminal_modes):
5576 (tty_reset_terminal_modes, tty_turn_off_highlight):
5577 (get_tty_terminal): Now static.
5578 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5579 * termhooks.h (term_mouse_moveto): Do not declare if
5581 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5582 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5584 * sysdep.c: Make symbols static if they're not exported.
5585 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5587 (sigprocmask_set, full_mask): Remove; unused.
5588 (wait_debugging): Mark as visible.
5589 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5590 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5592 * syntax.c (syntax_temp): Define only if !__GNUC__.
5594 * sound.c (current_sound_device, current_sound): Now static.
5596 * search.c (searchbufs, searchbuf_head): Now static.
5598 * scroll.c (scroll_cost): Remove; unused.
5599 * dispextern.h (scroll_cost): Remove decl.
5601 * region-cache.h (pp_cache): Mark as externally visible.
5603 * process.c: Make symbols static if they're not exported.
5604 (process_tick, update_tick, create_process, chan_process):
5605 (Vprocess_alist, proc_buffered_char, datagram_access):
5606 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5607 (deactivate_process): Mark defn as static, as well as decl.
5608 * lisp.h (create_process): Remove decl.
5609 * process.h (chan_process, Vprocess_alist): Remove decls.
5611 * print.c: Make symbols static if they're not exported.
5612 (print_depth, new_backquote_output, being_printed, print_buffer):
5613 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5614 (print_interval, print_number_index, initial_stderr_stream):
5616 * lisp.h (Fprinc): Remove decl.
5617 (debug_output_compilation_hack): Mark as externally visible.
5619 * sysdep.c (croak): Move decl from here to syssignal.h.
5620 * syssignal.h (croak): Put it here, so the API can be checked when
5621 'croak' is called from dissociate_if_controlling_tty.
5623 * minibuf.c: Make symbols static if they're not exported.
5624 (minibuf_save_list, choose_minibuf_frame): Now static.
5625 * lisp.h (choose_minibuf_frame): Remove decl.
5627 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5629 * lread.c: Make symbols static if they're not exported.
5630 (read_objects, initial_obarray, oblookup_last_bucket_number):
5632 (make_symbol): Remove; unused.
5633 * lisp.h (initial_obarray, make_symbol): Remove decls.
5635 * keyboard.c: Make symbols static if they're not exported.
5636 (single_kboard, recent_keys_index, total_keys, recent_keys):
5637 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5638 (this_single_command_key_start, echoing, last_auto_save):
5639 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5640 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5641 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5642 (Vlispy_mouse_stem, double_click_count):
5644 (force_auto_save_soon): Define only if SIGDANGER.
5645 (ignore_mouse_drag_p): Now static if
5646 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5647 (print_help): Remove; unused.
5648 (stop_character, last_timer_event): Mark as externally visible.
5649 * keyboard.h (ignore_mouse_drag_p): Declare only if
5650 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5651 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5652 * lisp.h (echoing): Remove decl.
5653 (force_auto_save_soon): Declare only if SIGDANGER.
5654 * xdisp.c (redisplay_window): Simplify code, to make it more
5655 obvious that ignore_mouse_drag_p is not accessed if !defined
5656 USE_GTK && !defined HAVE_NS.
5658 * intervals.c: Make symbols static if they're not exported.
5659 (merge_properties_sticky, merge_interval_right, delete_interval):
5661 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5663 * insdel.c: Make symbols static if they're not exported.
5664 However, leave prepare_to_modify_buffer alone. It's never
5665 called from outside this function, but that appears to be a bug.
5666 (combine_after_change_list, combine_after_change_buffer):
5667 (adjust_after_replace, signal_before_change): Now static.
5668 (adjust_after_replace_noundo): Remove; unused.
5669 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5670 (signal_before_change): Remove decls.
5672 * indent.c (val_compute_motion, val_vmotion): Now static.
5674 * image.c: Make symbols static if they're not exported.
5675 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5677 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5678 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5680 * fringe.c (standard_bitmaps): Now static.
5681 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5683 * frame.c: Make symbols static if they're not exported.
5684 (x_report_frame_params, make_terminal_frame): Now static.
5685 (get_frame_param): Now static, unless HAVE_NS.
5686 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5687 (x_get_resource_string): Remove; not used.
5688 * frame.h (make_terminal_frame, x_report_frame_params):
5689 (x_get_resource_string); Remove decls.
5690 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5691 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5693 * font.c, fontset.c: Make symbols static if they're not exported.
5694 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5695 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5696 * font.c (font_close_object): Now static.
5697 * font.h (font_close_object): Remove.
5698 * fontset.c (FONTSET_OBJLIST): Remove.
5699 (free_realized_fontset) #if-0 the body, which does nothing.
5700 (face_suitable_for_char_p): #if-0, as it's never called.
5701 * fontset.h (face_suitable_for_char_p): Remove decl.
5702 * xfaces.c (face_at_string_position):
5703 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5704 since 0 is always ASCII.
5706 * fns.c (weak_hash_tables): Now static.
5708 * fileio.c: Make symbols static if they're not exported.
5709 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5710 (Vwrite_region_annotation_buffers): Now static.
5712 * eval.c: Make symbols static if they're not exported.
5713 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5714 * lisp.h (backtrace_list): Remove decl.
5716 * emacs.c: Make symbols static if they're not exported.
5717 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5718 (fatal_error_code, fatal_error_signal_hook, standard_args):
5720 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5721 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5722 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5723 * lisp.h (fatal_error_signal_hook): Remove decl.
5724 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5726 * editfns.c: Move a (normally-unused) function to its only use.
5727 * editfns.c, lisp.h (get_operating_system_release): Remove.
5728 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5729 worth the hassle of breaking this out.
5731 * xterm.c: Make symbols static if they're not exported.
5732 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5733 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5734 (x_destroy_window, x_delete_display):
5736 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5737 (x_mouse_leave): Remove; unused.
5738 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5739 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5740 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5742 (x_mouse_leave): Declare only if WINDOWSNT.
5743 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5744 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5747 * ftxfont.c: Make symbols static if they're not exported.
5748 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5750 * font.h (ftxfont_driver): Likewise.
5752 * xfns.c: Make symbols static if they're not exported.
5753 (x_last_font_name, x_display_info_for_name):
5754 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5755 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5756 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5757 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5758 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5759 (last_show_tip_args): Now static.
5760 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5761 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5762 (x_screen_planes): Remove; unused.
5763 * dispextern.h (x_screen_planes): Remove decl.
5765 * dispnew.c: Make symbols static if they're not exported.
5766 * dispextern.h (redraw_garbaged_frames, scrolling):
5767 (increment_row_positions): Remove.
5768 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5769 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5771 (redraw_garbaged_frames): Remove; unused.
5773 * xfaces.c: Make symbols static if they're not exported.
5774 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5776 * xterm.h (defined_color): Remove decls.
5777 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5778 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5779 (menu_face_changed_default, defined_color, free_realized_face):
5780 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5781 (ascii_face_of_lisp_face): Remove; unused.
5783 * xdisp.c: Make symbols static if they're not exported.
5784 * dispextern.h (scratch_glyph_row, window_box_edges):
5785 (glyph_to_pixel_coords, set_cursor_from_row):
5786 (get_next_display_element, set_iterator_to_next):
5787 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5788 (show_mouse_face): Remove decls
5789 * frame.h (message_buf_print): Likewise.
5790 * lisp.h (pop_message, set_message, check_point_in_composition):
5792 * xterm.h (set_vertical_scroll_bar): Likewise.
5793 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5794 (message_buf_print, scratch_glyph_row, displayed_buffer):
5795 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5796 (get_next_display_element, show_mouse_face, window_box_edges):
5797 (frame_to_window_pixel_xy, check_point_in_composition):
5798 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5799 (glyph_to_pixel_coords): Remove; unused.
5801 * dired.c (file_name_completion): Now static.
5803 * dbusbind.c (xd_in_read_queued_messages): Now static.
5805 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5806 * data.c (circular_list_error): Remove.
5808 * commands.h (last_point_position, last_point_position_buffer):
5809 (last_point_position_window): Remove decls.
5810 * keyboard.c: Make these variables static.
5812 * coding.h (coding, code_convert_region, encode_coding_gap):
5814 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5815 (iso_code_class, detect_coding, code_convert_region): Now static.
5816 (encode_coding_gap): Remove; unused.
5818 * chartab.c (chartab_chars, chartab_bits): Now static.
5820 * charset.h (charset_iso_8859_1): Remove decl.
5821 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5824 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5825 * ccl.c (Vccl_program_table): Now static.
5826 (check_ccl_update): Remove; unused.
5828 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5829 * category.h: ... from here.
5830 * category.c (check_category_table, set_category_set): Now static.
5832 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5833 * lisp.h: Remove these decls.
5835 * buffer.c (buffer_count): Remove unused var.
5837 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5838 so that it's not optimized away.
5839 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5840 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5841 exported only to the debugger.
5843 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5844 * atimer.h (run_all_atimers): Remove; not exported.
5846 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5847 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5848 was inaccessible from Lisp.
5849 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5850 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5852 alloc.c: Import and export fewer symbols, and remove unused items.
5853 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5855 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5856 it's not optimized away by whole-program optimization.
5857 (message_enable_multibyte, free_misc): Remove.
5858 (catchlist, handlerlist, mark_backtrace):
5859 Declare only if BYTE_MARK_STACK.
5860 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5861 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5862 (message_enable_multibyte): Remove decl.
5863 (free_misc, interval_free_list, float_block, float_block_index):
5864 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5865 (cons_free_list, last_marked_index):
5867 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5868 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5869 (mark_backtrace): Define only if BYTE_MARK_STACK.
5870 * xdisp.c (message_enable_multibyte): Now static.
5872 Declare Lisp_Object Q* variables to be 'static' if not exported.
5873 This makes it easier for human readers (and static analyzers)
5874 to see whether these variables are used from other modules.
5875 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5876 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5877 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5878 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5879 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5880 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5881 * xmenu.c, xselect.c:
5882 Declare Q* vars static if they are not used in other modules.
5883 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5884 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5885 Remove decls of unexported vars.
5886 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5888 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5890 Make Emacs functions such as Fatom 'static' by default.
5891 This makes it easier for human readers (and static analyzers)
5892 to see whether these functions can be called from other modules.
5893 DEFUN now defines a static function. To make the function external
5894 so that it can be used in other C modules, use the new macro DEFUE.
5895 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5896 (Finit_image_library):
5897 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5898 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5899 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5900 Remove decls, since these functions are now static.
5901 (Funintern, Fget_internal_run_time): New decls, since these functions
5902 were already external.
5904 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5905 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5906 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5907 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5908 * keyboard.c, keymap.c, lread.c:
5909 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5910 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5911 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5912 Mark functions with DEFUE instead of DEFUN,
5913 if they are used in other modules.
5914 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5915 decls for now-static functions.
5916 * buffer.h (Fdelete_overlay): Remove decl.
5917 * callproc.c (Fgetenv_internal): Mark as internal.
5918 * composite.c (Fremove_list_of_text_properties): Remove decl.
5919 (Fcomposition_get_gstring): New forward static decl.
5920 * composite.h (Fcomposite_get_gstring): Remove decl.
5921 * dired.c (Ffile_attributes): New forward static decl.
5922 * doc.c (Fdocumntation_property): New forward static decl.
5923 * eval.c (Ffetch_bytecode): New forward static decl.
5924 (Funintern): Remove extern decl; now in .h file where it belongs.
5925 * fileio.c (Fmake_symbolic_link): New forward static decl.
5926 * image.c (Finit_image_library): New forward static decl.
5927 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5928 * intervals.h (Fprevious_property_change):
5929 (Fremove_list_of_text_properties): Remove decls.
5930 * keyboard.c (Fthis_command_keys): Remove decl.
5931 (Fcommand_execute): New forward static decl.
5932 * keymap.c (Flookup_key): New forward static decl.
5933 (Fcopy_keymap): Now static.
5934 * keymap.h (Flookup_key): Remove decl.
5935 * process.c (Fget_process): New forward static decl.
5936 (Fprocess_datagram_address): Mark as internal.
5937 * syntax.c (Fsyntax_table_p): New forward static decl.
5938 (skip_chars): Remove duplicate decl.
5939 * textprop.c (Fprevious_property_change): New forward static decl.
5940 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5942 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5943 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5945 * editfns.c (Fformat): Remove unreachable code.
5947 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5949 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5952 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5954 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5955 when at ZV. (Bug#8487)
5957 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5959 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5961 * keyboard.c (parse_tool_bar_item): Likewise.
5962 * sound.c (sound_cleanup, alsa_close): Likewise.
5963 * termcap.c (tgetent): Likewise.
5964 * xfns.c (x_default_font_parameter): Likewise.
5965 * xsettings.c (read_and_apply_settings): Likewise.
5967 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5968 (overrun_check_free): Protoize.
5970 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5972 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5973 since callers should never pass a negative size.
5974 Change the signature to match that of plain 'read' and 'write'; see
5975 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5976 * lisp.h: Update prototypes of emacs_write and emacs_read.
5978 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5980 * xdisp.c (redisplay_window): Don't try to determine the character
5981 position of the scroll margin if the window start point w->startp
5982 is outside the buffer's accessible region. (Bug#8468)
5984 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5986 Fix write-region and its subroutines for buffers > 2GB.
5987 * fileio.c (a_write, e_write): Modify declaration of arguments and
5988 local variables to support buffers larger than 2GB.
5989 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5991 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5992 argument, local variables, and return value.
5994 * lisp.h: Update prototypes of emacs_write and emacs_read.
5996 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5998 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6000 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6002 Fix more problems found by GCC 4.6.0's static checks.
6004 * xdisp.c (vmessage): Use a better test for character truncation.
6006 * charset.c (load_charset_map): <, not <=, for optimization,
6007 and to avoid potential problems with integer overflow.
6008 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6009 * casetab.c (set_identity, shuffle): Likewise.
6010 * editfns.c (Fformat): Likewise.
6011 * syntax.c (skip_chars): Likewise.
6013 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6014 This also lets GCC 4.6.0 generate slightly better loop code.
6016 * callint.c (Fcall_interactively): <, not <=, for optimization.
6017 (Fcall_interactively): Count the number of arguments produced,
6018 not the number of arguments given. This is simpler and lets GCC
6019 4.6.0 generate slightly better code.
6021 * ftfont.c: Distingish more carefully between FcChar8 and char.
6022 The previous code passed unsigned char * to a functions like
6023 strlen and xstrcasecmp that expect char *, which does not
6024 conform to the C standard.
6025 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6026 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6027 char * when the C standard requires it.
6029 * keyboard.c (read_char): Remove unused var.
6031 * eval.c: Port to Windows vsnprintf (Bug#8435).
6033 (SIZE_MAX): Define if the headers do not.
6034 (verror): Do not give up if vsnprintf returns a negative count.
6035 Instead, grow the buffer. This ports to Windows vsnprintf, which
6036 does not conform to C99. Problem reported by Eli Zaretskii.
6037 Also, simplify the allocation scheme, by avoiding the need for
6038 calling realloc, and removing the ALLOCATED variable.
6040 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6042 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6043 But keep the doprint source code for now, as we might revamp it
6044 and use it again (Bug#8435).
6045 * lisp.h (doprnt): Remove.
6046 * Makefile.in (base_obj): Remove doprnt.o.
6047 * deps.mk (doprnt.o): Remove.
6049 error: Print 32- and 64-bit integers portably (Bug#8435).
6050 Without this change, on typical 64-bit hosts error ("...%d...", N)
6051 was used to print both 32- and 64-bit integers N, which relied on
6053 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6055 * lisp.h (error, verror): Mark as printf-like functions.
6056 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6057 Report overflow in size calculations when allocating printf buffer.
6058 Do not truncate output string at its first null byte.
6059 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6060 Truncate the output at a character boundary, since vsnprintf does not
6062 * charset.c (check_iso_charset_parameter): Convert internal
6063 character to string before calling 'error', since %c now has the
6065 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6066 overflow when computing char to be passed to 'error'. Do not
6067 pass Lisp_Object to 'error'; pass the integer instead.
6068 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6069 formatted with plain %d.
6071 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6073 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6075 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6077 * xterm.c (x_catch_errors): Remove duplicate declaration.
6079 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6081 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6083 2011-04-10 Jim Meyering <meyering@redhat.com>
6085 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6086 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6087 return ssize_t not "int", and use size_t as the buffer length.
6088 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6089 * gnutls.h: Update declarations.
6090 * process.c (read_process_output): Use ssize_t, to match.
6091 (send_process): Likewise.
6093 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6095 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6097 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6099 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6100 Use unsigned char, to match FcChar8 type definition.
6102 * xterm.c (handle_one_xevent):
6103 * xmenu.c (create_and_show_popup_menu):
6104 * xselect.c (x_decline_selection_request)
6105 (x_reply_selection_request): Avoid type-punned deref of X events.
6107 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6109 Fix some uses of `int' instead of EMACS_INT.
6110 * search.c (string_match_1, fast_string_match)
6111 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6112 (scan_buffer, find_next_newline_no_quit)
6113 (find_before_next_newline, search_command, Freplace_match)
6114 (Fmatch_data): Make some `int' variables be EMACS_INT.
6116 * xdisp.c (display_count_lines): 3rd argument and return value now
6117 EMACS_INT. All callers changed.
6118 (pint2hrstr): Last argument is now EMACS_INT.
6120 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6121 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6122 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6123 (decode_coding_utf_16, decode_coding_emacs_mule)
6124 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6125 (decode_coding_ccl, decode_coding_charset)
6126 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6127 (decode_coding_iso_2022, decode_coding_emacs_mule)
6128 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6129 <char_offset, last_offset>: Declare EMACS_INT.
6130 (encode_coding_utf_8, encode_coding_utf_16)
6131 (encode_coding_emacs_mule, encode_invocation_designation)
6132 (encode_designation_at_bol, encode_coding_iso_2022)
6133 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6134 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6136 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6137 (encode_invocation_designation): Last argument P_NCHARS is now
6139 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6140 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6142 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6145 * ccl.c (Fccl_execute_on_string): Declare some variables
6148 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6150 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6152 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6154 * process.c (Fformat_network_address): Doc fix.
6156 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6158 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6160 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6162 * keyboard.c (read_char): Call Lisp function help-form-show,
6163 instead of using internal_with_output_to_temp_buffer.
6164 (Qhelp_form_show): New var.
6165 (syms_of_keyboard): Use DEFSYM macro.
6167 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6169 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6171 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6173 * process.c (Flist_processes): Remove to Lisp.
6174 (list_processes_1): Delete.
6176 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6178 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6180 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6182 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6184 Fix more problems found by GCC 4.6.0's static checks.
6186 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6188 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6190 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6192 * xdisp.c (vmessage): Mark as a printf-like function.
6194 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6196 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6198 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6199 printf-like functions.
6200 (tiff_load): Add casts to remove these marks before passing them
6201 to system-supplied API.
6203 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6205 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6206 This avoids several warnings with gcc -Wstrict-overflow.
6207 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6208 directly, rather than having caller test rule sign. This avoids
6209 some unnecessary tests.
6210 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6211 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6212 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6214 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6215 (xfont_open): Avoid unnecessary tests.
6217 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6219 * composite.h, composite.c (composition_gstring_put_cache):
6220 Use EMACS_INT, not int, for length.
6222 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6223 breaking out part of COMPOSITION_DECODE_RULE.
6224 (COMPOSITION_DECODE_RULE): Use it.
6225 * composite.c (get_composition_id): Remove unused local vars,
6226 by using the new macro.
6228 * textprop.c (set_text_properties_1): Change while to do-while,
6229 since the condition is always true at first.
6231 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6232 (interval_deletion_adjustment): Return unsigned value.
6235 * process.c (list_processes_1, create_pty, read_process_output):
6236 (exec_sentinel): Remove vars that were set but not used.
6237 (create_pty): Remove unnecessary "volatile"s.
6238 (Fnetwork_interface_info): Avoid possibility of int overflow.
6239 (read_process_output): Do adaptive read buffering even if carryover.
6240 (read_process_output): Simplify nbytes computation if buffered.
6242 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6244 * syntax.c (scan_words): Remove var that was set but not used.
6245 (update_syntax_table): Use unsigned instead of int.
6247 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6248 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6249 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6251 * print.c (print_error_message): Avoid int overflow.
6253 * font.c (font_list_entities): Redo for clarity,
6254 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6256 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6257 (font_score): Avoid potential overflow in diff calculation.
6259 * fns.c (substring_both): Remove var that is set but not used.
6260 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6262 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6264 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6265 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6266 can always succeed if overflow has undefined behavior.
6268 * search.c (boyer_moore, wordify): Remove vars set but not used.
6269 (wordify): Omit three unnecessary tests.
6271 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6272 All callers changed. This avoids the need for an unused var.
6274 * casefiddle.c (casify_region): Remove var that is set but not used.
6276 * dired.c (file_name_completion): Remove var that is set but not used.
6278 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6280 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6281 (Finsert_file_contents): Remove unnecessary code checking fd.
6283 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6284 Check for integer overflow on size calculations.
6286 * buffer.c (Fprevious_overlay_change): Remove var that is set
6289 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6290 Remove vars that are set but not used.
6291 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6292 (timer_check_2): Mark vars as initialized.
6294 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6296 * image.c (lookup_image): Remove var that is set but not used.
6297 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6299 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6300 that are set but not used.
6302 * xfns.c (make_invisible_cursor): Don't return garbage
6303 if XCreateBitmapFromData fails (Bug#8410).
6305 * xselect.c (x_get_local_selection, x_handle_property_notify):
6306 Remove vars that are set but not used.
6308 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6309 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6311 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6312 Remove var that is set but not used.
6313 (scroll_bar_windows_size): Now size_t, not int.
6314 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6317 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6318 (map_tty_color) [!defined MSDOS]: Likewise.
6320 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6322 * coding.c: Remove vars that are set but not used.
6323 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6324 All callers changed.
6325 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6326 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6327 (decode_coding_charset): Remove vars that are set but not used.
6329 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6330 that is set but not used.
6332 * print.c (print_object): Remove var that is set but not used.
6334 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6335 The gnulib version avoids calling malloc in the usual case,
6336 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6337 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6338 * filelock.c (current_lock_owner): Likewise.
6339 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6340 * sysdep.c: Include allocator.h, careadlinkat.h.
6341 (emacs_no_realloc_allocator): New static constant.
6342 (emacs_readlink): New function.
6343 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6344 ../lib/careadlinkat.h.
6346 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6348 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6349 first non-nil return value).
6351 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6353 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6354 if not defined (Bug#8403).
6356 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6358 * xdisp.c (display_count_lines): Remove parameter `start',
6359 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6360 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6361 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6362 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6363 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6364 and thereabouts. All callers changed.
6365 (get_per_char_metric): Remove parameter `f', unused since
6366 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6368 2011-04-02 Jim Meyering <meyering@redhat.com>
6370 do not dereference NULL upon failed strdup
6371 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6372 (ns_get_family): Likewise.
6374 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6376 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6378 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6380 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6383 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6385 Add lexical binding.
6387 * window.c (Ftemp_output_buffer_show): New fun.
6388 (Fsave_window_excursion):
6389 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6391 * lread.c (lisp_file_lexically_bound_p): New function.
6392 (Fload): Bind Qlexical_binding.
6393 (readevalloop): Remove `evalfun' arg.
6394 Bind Qinternal_interpreter_environment.
6395 (Feval_buffer): Bind Qlexical_binding.
6396 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6398 (syms_of_lread): Declare `lexical-binding'.
6400 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6402 * keyboard.c (eval_dyn): New fun.
6403 (menu_item_eval_property): Use it.
6405 * image.c (parse_image_spec): Use Ffunctionp.
6407 * fns.c (concat, mapcar1): Accept byte-code-functions.
6409 * eval.c (Fsetq): Handle lexical vars.
6410 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6411 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6412 (FletX, Flet): Obey lexical binding.
6413 (Fcommandp): Handle closures.
6414 (Feval): New `lexical' arg.
6415 (eval_sub): New function extracted from Feval. Use it almost
6416 everywhere where Feval was used. Look up vars in lexical env.
6418 (Ffunctionp): Move from subr.el.
6419 (Ffuncall): Handle closures.
6420 (apply_lambda): Remove `eval_flags'.
6421 (funcall_lambda): Handle closures and new byte-code-functions.
6422 (Fspecial_variable_p): New function.
6423 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6424 but without exporting it to Lisp.
6426 * doc.c (Fdocumentation, store_function_docstring):
6427 * data.c (Finteractive_form): Handle closures.
6429 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6432 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6434 (exec_byte_code): New function extracted from Fbyte_code to handle new
6435 calling convention for byte-code-functions. Add new byte-codes.
6437 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6439 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6441 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6443 * xdisp.c (redisplay_internal): Fix prototype.
6445 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6447 * xdisp.c (SCROLL_LIMIT): New macro.
6448 (try_scrolling): Use it when setting scroll_limit.
6449 Limit scrolling to 100 screen lines.
6450 (redisplay_window): Even when falling back on "recentering",
6451 position point in the window according to scroll-conservatively,
6452 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6454 (try_scrolling): When point is above the window, allow searching
6455 as far as scroll_max, or one screenful, to compute vertical
6456 distance from PT to the scroll margin position. This prevents
6457 try_scrolling from unnecessarily failing when
6458 scroll-conservatively is set to a value slightly larger than the
6459 window height. Clean up the case of PT below the margin at bottom
6460 of window: scroll_max can no longer be INT_MAX. When aggressive
6461 scrolling is in use, don't let point enter the opposite scroll
6462 margin as result of the scroll.
6463 (syms_of_xdisp) <scroll-conservatively>: Document the
6464 threshold of 100 lines for never-recentering scrolling.
6466 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6468 * dispextern.h (move_it_by_lines):
6469 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6470 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6471 (message_log_check_duplicate): Remove parameters `prev_bol' and
6472 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6473 (redisplay_internal): Remove parameter `preserve_echo_area',
6474 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6476 * indent.c (Fvertical_motion):
6477 * window.c (window_scroll_pixel_based, Frecenter):
6478 Don't pass `need_y_p' to `move_it_by_lines'.
6480 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6482 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6483 steal a few bits to be more compact.
6484 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6485 Remove unneeded casts.
6487 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6489 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6491 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6492 binding" message (bug#7967).
6494 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6496 Fix more problems found by GCC 4.6.0's static checks.
6498 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6499 Remove unused local var.
6501 * editfns.c (Fmessage_box): Remove unused local var.
6503 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6504 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6505 Omit unused local vars.
6506 * window.c (shrink_windows): Omit unused local var.
6507 * menu.c (digest_single_submenu): Omit unused local var.
6508 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6509 Omit unused local var.
6511 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6512 Don't assume string length fits in int.
6513 (keyremap_step, read_key_sequence): Use size_t for sizes.
6514 (read_key_sequence): Don't check last_real_key_start redundantly.
6516 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6517 instead of alloca (Bug#8344).
6519 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6520 (Fbacktrace_frame): Don't assume nframes fits in int.
6522 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6524 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6527 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6529 * cm.c (calccost): Turn while-do into do-while, for clarity.
6531 * keyboard.c (syms_of_keyboard): Use the same style as later
6532 in this function when indexing through an array. This also
6533 works around GCC bug 48267.
6535 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6537 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6539 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6540 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6542 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6543 This avoids undefined behavior on integer overflow, and is a bit
6544 more convenient anyway since it is compared to a size_t variable.
6546 Variadic C functions now count arguments with size_t, not int.
6547 This avoids an unnecessary limitation on 64-bit machines, which
6548 caused (substring ...) to crash on large vectors (Bug#8344).
6549 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6550 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6551 All variadic functions and their callers changed accordingly.
6552 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6553 * data.c (arith_driver, float_arith_driver): Likewise.
6554 * editfns.c (general_insert_function): Likewise.
6555 * eval.c (struct backtrace.nargs, interactive_p)
6556 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6557 (funcall_lambda, mark_backtrace): Likewise.
6558 * fns.c (concat): Likewise.
6559 * frame.c (x_set_frame_parameters): Likewise.
6560 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6561 0 if not found, not -1. All callers changed.
6563 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6564 (stack_copy_size): Now size_t, not int.
6565 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6567 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6569 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6570 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6571 All callers changed.
6573 * lisp.h (multibyte_char_to_unibyte):
6574 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6575 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6576 * character.h (CHAR_TO_BYTE8):
6577 * cmds.c (internal_self_insert):
6578 * editfns.c (general_insert_function):
6579 * keymap.c (push_key_description):
6580 * search.c (Freplace_match):
6581 * xdisp.c (message_dolog, set_message_1): All callers changed.
6583 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6585 * keyboard.c (safe_run_hook_funcall): New function.
6586 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6587 don't set the hook to nil, but remove the offending function instead.
6588 (Qcommand_hook_internal): Remove, unused.
6589 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6590 Vcommand_hook_internal.
6592 * eval.c (enum run_hooks_condition): Remove.
6593 (funcall_nil, funcall_not): New functions.
6594 (run_hook_with_args): Call each function through a `funcall' argument.
6595 Remove `cond' argument, now redundant.
6596 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6597 (Frun_hook_with_args_until_failure): Adjust accordingly.
6598 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6600 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6602 * dispextern.h (string_buffer_position): Remove declaration.
6604 * print.c (strout): Remove parameter `multibyte', unused since
6605 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6607 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6608 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6609 All callers changed.
6611 * w32.c (_wsa_errlist): Use braces for struct initializers.
6613 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6614 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6615 All callers changed.
6616 (string_buffer_position): Likewise. Also, make static (it's never
6617 used outside xdisp.c).
6618 (cursor_row_p): Remove parameter `w', unused since
6619 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6620 (decode_mode_spec): Remove parameter `precision', introduced during
6621 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6622 All callers changed.
6624 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6626 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6628 2011-03-27 Anders Lindgren <andlind@gmail.com>
6630 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6631 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6632 (ns_update_auto_hide_menu_bar): New functions.
6633 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6634 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6635 ns_constrain_all_frames.
6636 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6637 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6639 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6641 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6643 2011-03-27 Glenn Morris <rgm@gnu.org>
6645 * syssignal.h: Replace RETSIGTYPE with void.
6646 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6647 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6648 Replace SIGTYPE with void everywhere.
6649 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6650 * s/template.h (SIGTYPE): Remove commented out definition.
6652 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6654 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6655 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6657 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6659 * w32.c (read_unc_volume): Use parameter `henum', instead of
6660 global variable `wget_enum_handle'.
6662 * keymap.c (describe_vector): Remove parameters `indices' and
6663 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6664 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6666 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6668 * keyboard.c (timer_check): Remove parameter `do_it_now',
6669 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6670 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6671 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6673 * keyboard.c (read_char):
6674 * w32menu.c (w32_menu_display_help):
6675 * xmenu.c (show_help_event, menu_help_callback):
6676 Adjust calls to `show_help_echo'.
6678 * gtkutil.c (xg_maybe_add_timer):
6679 * keyboard.c (readable_events):
6680 * process.c (wait_reading_process_output):
6681 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6683 * insdel.c (adjust_markers_gap_motion):
6684 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6685 (gap_left, gap_right): Don't call it.
6687 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6689 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6690 incurred during fontification.
6692 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6694 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6695 (DEFVAR_PER_BUFFER): Don't pass it.
6697 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6698 (scrolling_window): Don't pass it.
6700 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6702 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6704 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6706 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6707 of variables specific to SELinux and computation of `encoded_absname'.
6709 * image.c (XPutPixel): Remove unused variable `height'.
6711 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6713 * unexw32.c (get_section_info): Remove unused variable `section'.
6715 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6716 (system_process_attributes): Remove unused variable `sess'.
6717 (sys_read): Remove unused variable `err'.
6719 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6720 (w32_wnd_proc): Remove unused variable `isdead'.
6721 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6722 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6723 (x_create_tip_frame): Remove unused variable `tem'.
6725 * w32inevt.c (w32_console_read_socket):
6726 Remove unused variable `no_events'.
6728 * w32term.c (x_draw_composite_glyph_string_foreground):
6729 Remove unused variable `width'.
6731 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6733 * w32term.c (x_set_glyph_string_clipping):
6734 Don't pass uninitialized region to CombineRgn.
6736 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6738 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6739 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6740 (Fx_close_connection): Remove unused variable `i'.
6742 * w32font.c (w32font_draw): Return number of glyphs.
6743 (w32font_open_internal): Remove unused variable `i'.
6744 (w32font_driver): Add missing initializer.
6746 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6747 (fill_in_menu): Remove unused variable `items_added'.
6749 * w32term.c (last_mouse_press_frame): Remove static global variable.
6750 (w32_clip_to_row): Remove unused variable `f'.
6751 (x_delete_terminal): Remove unused variable `i'.
6753 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6754 (NOTHING): Remove unused static global variable.
6755 (uniscribe_check_otf): Remove unused variable `table'.
6756 (uniscribe_font_driver): Add missing initializers.
6758 2011-03-23 Julien Danjou <julien@danjou.info>
6760 * term.c (Fsuspend_tty, Fresume_tty):
6761 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6762 * window.c (temp_output_buffer_show):
6763 * insdel.c (signal_before_change):
6764 * frame.c (Fhandle_switch_frame):
6765 * fileio.c (Fdo_auto_save):
6766 * emacs.c (Fkill_emacs):
6767 * editfns.c (save_excursion_restore):
6768 * cmds.c (internal_self_insert):
6769 * callint.c (Fcall_interactively):
6770 * buffer.c (Fkill_all_local_variables):
6771 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6773 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6774 unconditionnaly since it does the check itself.
6776 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6778 Fix more problems found by GCC 4.5.2's static checks.
6780 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6781 the first time through the loop, since we know p0 < p1 then.
6782 This also avoids a gcc -Wstrict-overflow warning.
6784 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6785 leading to a memory leak, possible in functions like
6786 load_charset_map_from_file that can allocate an unbounded number
6787 of objects (Bug#8318).
6789 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6790 that could (at least in theory) be that large.
6792 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6793 This is less likely to overflow, and avoids undefined behavior if
6794 overflow does occur. All callers changed. Use strtoul to scan
6795 for the unsigned long integer.
6796 (pint2hrstr): Simplify and tune code slightly.
6797 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6799 * scroll.c (do_scrolling): Work around GCC bug 48228.
6800 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6802 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6803 This also avoids a warning with gcc -Wstrict-overflow.
6804 (validate_x_resource_name): Simplify count usage.
6805 This also avoids a warning with gcc -Wstrict-overflow.
6807 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6810 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6812 * process.c (Fmake_network_process): Use socklen_t, not int,
6813 where POSIX says socklen_t is required in portable programs.
6814 This fixes a porting bug on hosts like 64-bit HP-UX, where
6815 socklen_t is wider than int (Bug#8277).
6816 (Fmake_network_process, server_accept_connection):
6817 (wait_reading_process_output, read_process_output):
6820 * process.c: Rename or move locals to avoid shadowing.
6821 (list_processes_1, Fmake_network_process):
6822 (read_process_output_error_handler, exec_sentinel_error_handler):
6823 Rename or move locals.
6824 (Fmake_network_process): Define label "retry_connect" only if needed.
6825 (Fnetwork_interface_info): Fix pointer signedness.
6826 (process_send_signal): Add cast to avoid pointer signedness problem.
6827 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6828 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6830 Make tparam.h and terminfo.c consistent.
6831 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6832 Include tparam.h instead, since it declares them.
6833 * cm.h (PC): Remove extern decl; tparam.h now does this.
6834 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6835 * terminfo.c: Include tparam.h, to check interfaces.
6836 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6837 (tparam): Adjust signature to match interface in tparam.h;
6838 this removes some undefined behavior. Check that outstring and len
6839 are zero, which they always are with Emacs.
6840 * tparam.h (PC, BC, UP): New extern decls.
6842 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6843 (xftfont_open): Rename locals to avoid shadowing.
6845 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6846 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6847 (OTF_TAG_SYM): Omit macro if not needed.
6848 (ftfont_list): Remove unused local.
6849 (get_adstyle_property, ftfont_pattern_entity):
6850 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6851 Rename locals to avoid shadowing.
6853 * xfont.c (xfont_list_family): Mark var as initialized.
6855 * xml.c (make_dom): Now static.
6857 * composite.c (composition_compute_stop_pos): Rename local to
6859 (composition_reseat_it): Remove unused locals.
6860 (find_automatic_composition, composition_adjust_point): Likewise.
6861 (composition_update_it): Mark var as initialized.
6862 (find_automatic_composition): Mark vars as initialized,
6863 with a FIXME (Bug#8290).
6865 character.h: Rename locals to avoid shadowing.
6866 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6867 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6868 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6869 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6872 * textprop.c (property_change_between_p): Remove; unused.
6874 * intervals.c (interval_start_pos): Now static.
6876 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6878 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6879 Rename locals to avoid shadowing.
6881 * sound.c (wav_play, au_play, Fplay_sound_internal):
6882 Fix pointer signedness.
6883 (alsa_choose_format): Remove unused local var.
6884 (wav_play): Initialize a variable to 0, to prevent undefined
6885 behavior (Bug#8278).
6887 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6889 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6891 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6892 clobbering (Bug#8298).
6893 * sysdep.c (sys_subshell): Likewise.
6894 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6896 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6897 This should get cleaned up, so that child_setup has the
6898 same signature on all platforms.
6900 * callproc.c (call_process_cleanup): Now static.
6901 (relocate_fd): Rename locals to avoid shadowing.
6903 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6905 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6906 not to be necessary, and produces flickering.
6908 2011-03-20 Glenn Morris <rgm@gnu.org>
6910 * config.in: Remove file.
6912 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6914 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6915 are now in src/globals.h.
6916 (syms_of_minibuf): Remove spurious & from previous change.
6918 2011-03-20 Leo <sdl.web@gmail.com>
6920 * minibuf.c (completing-read-function): New variable.
6921 (completing-read-default): Rename from completing-read.
6922 (completing-read): Call completing-read-function.
6924 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6926 * xfaces.c (Fx_load_color_file):
6927 Read color file from absolute filename (bug#8250).
6929 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6931 * makefile.w32-in: Update dependencies.
6933 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6935 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6937 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6939 Fix more problems found by GCC 4.5.2's static checks.
6941 * process.c (make_serial_process_unwind, send_process_trap):
6942 (sigchld_handler): Now static.
6944 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6945 That way, the code declares only the vars that it needs.
6946 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6947 * s/cygwin.h (PTY_ITERATION): Likewise.
6948 * s/darwin.h (PTY_ITERATION): Likewise.
6949 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6951 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6952 * process.c (allocate_pty): Don't declare stb unless it's needed.
6954 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6955 (CONSTANTLIM): Remove; unused.
6956 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6957 Define only if needed.
6959 * unexelf.c (unexec): Name an expression,
6960 to avoid gcc -Wbad-function-cast warning.
6961 Use a different way to cause a compilation error if anyone uses
6962 n rather than nn, a way that does not involve shadowing.
6963 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6965 * deps.mk (unexalpha.o): Remove; unused.
6967 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6968 * unexec.h: New file.
6969 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6970 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6972 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6973 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6974 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6975 Change as necessary to match prototype in unexec.h.
6977 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6979 (back_comment, skip_chars): Mark vars as initialized.
6981 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6982 Rename locals to avoid shadowing.
6984 * lread.c (read1): Rewrite so as not to use empty "else".
6985 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6987 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6989 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6990 warning when compiling print.c.
6992 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6993 instead of using an uninitialized var.
6994 (font_sort_entities): Mark var as initialized.
6996 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6998 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6999 pointers to constants.
7000 (font_parse_fcname): Remove unused vars.
7001 (font_delete_unmatched): Now static.
7002 (font_get_spec): Remove; unused.
7003 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7004 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7005 Rename or move locals to avoid shadowing.
7007 * fns.c (require_nesting_list, require_unwind): Now static.
7008 (Ffillarray): Rename locals to avoid shadowing.
7010 * floatfns.c (domain_error2): Define only if needed.
7011 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7013 * alloc.c (mark_backtrace): Move decl from here ...
7014 * lisp.h: ... to here, so that it can be checked.
7016 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7017 (Fdefvar): Rewrite so as not to use empty "else".
7018 (lisp_indirect_variable): Name an expression,
7019 to avoid gcc -Wbad-function-cast warning.
7020 (Fdefvar): Rename locals to avoid shadowing.
7022 * callint.c (quotify_arg, quotify_args): Now static.
7023 (Fcall_interactively): Rename locals to avoid shadowing.
7024 Use const pointer when appropriate.
7026 * lisp.h (get_system_name, get_operating_system_release):
7027 Move decls here, to check interfaces.
7028 * process.c (get_operating_system_release): Move decl to lisp.h.
7029 * xrdb.c (get_system_name): Likewise.
7030 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7031 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7032 some of which prompt warnings from gcc -Wbad-function-cast.
7033 (Fformat_time_string, Fencode_time, Finsert_char):
7034 (Ftranslate_region_internal, Fformat):
7035 Rename or remove local vars to avoid shadowing.
7036 (Ftranslate_region_internal): Mark var as initialized.
7038 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7041 * lisp.h (eassert): Check that the argument compiles, even if
7042 ENABLE_CHECKING is not defined.
7044 * data.c (Findirect_variable): Name an expression, to avoid
7045 gcc -Wbad-function-cast warning.
7046 (default_value, arithcompare, arith_driver, arith_error): Now static.
7047 (store_symval_forwarding): Rename local to avoid shadowing.
7048 (Fmake_variable_buffer_local, Fmake_local_variable):
7049 Mark variables as initialized.
7050 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7052 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7053 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7054 Rename locals to avoid shadowing.
7055 (mark_stack): Move local variables into the #ifdef region where
7057 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7058 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7060 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7061 (GC_STRING_CHARS): Remove; not used.
7062 (Fmemory_limit): Cast sbrk's returned value to char *.
7064 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7065 avoids undefined behavior in theory.
7067 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7069 Use functions, not macros, for up- and down-casing (Bug#8254).
7070 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7071 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7072 to use the following functions instead of these macros.
7073 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7074 EMACS_INT, since callers assume the returned value fits in int.
7075 (upcase1): Likewise, for UPCASE_TABLE.
7076 (uppercasep, lowercasep, upcase): New static inline functions.
7077 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7078 the race-condition problem in the old DOWNCASE.
7080 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7081 Rename locals to avoid shadowing.
7082 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7083 (regex_compile, re_search_2, re_match_2_internal):
7084 Remove unused local vars.
7085 (FREE_VAR): Rewrite so as not to use empty "else",
7086 which gcc can warn about.
7087 (regex_compile, re_match_2_internal): Mark locals as initialized.
7088 (RETALLOC_IF): Define only if needed.
7089 (WORDCHAR_P): Likewise. This one is never needed, but is used
7090 only in a comment talking about a compiler bug, so put inside
7091 the #if 0 of that comment.
7092 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7093 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7096 * search.c (boyer_moore): Rename locals to avoid shadowing.
7097 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7098 (PREV_CHAR_BOUNDARY): Likewise.
7100 * search.c (simple_search): Remove unused var.
7102 * dired.c (compile_pattern): Move decl from here ...
7103 * lisp.h: ... to here, so that it can be checked.
7104 (struct re_registers): New forward decl.
7106 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7108 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7110 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7111 Rename locals to avoid shadowing.
7112 (Fvertical_motion): Mark locals as initialized.
7114 * casefiddle.c (casify_object, casify_region): Now static.
7115 (casify_region): Mark local as initialized.
7117 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7119 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7120 New macros, so that the caller can use some names other than
7121 gcpro1, gcpro2, etc.
7122 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7124 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7125 argument, for consistency with GCPRO2_VAR, etc: it is now the
7126 prefix of the variable, not the variable itself. All uses
7128 * dired.c (directory_files_internal, file_name_completion):
7129 Rename locals to avoid shadowing.
7131 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7132 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7133 dired.c's scmp function, had undefined behavior.
7134 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7135 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7136 * buffer.h: ... to here, because these macros use current_buffer,
7137 and the new implementation with inline functions needs to have
7138 current_buffer in scope now, rather than later when the macros
7140 (downcase, upcase1): New static inline functions.
7141 (DOWNCASE, UPCASE1): Reimplement using these functions.
7142 This avoids undefined behavior in expressions like
7143 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7144 from race conditions in accessing the global variables
7145 case_temp1 and case_temp2.
7146 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7147 * lisp.h (case_temp1, case_temp2): Remove their decls.
7148 * character.h (ASCII_CHAR_P): Move from here ...
7149 * lisp.h: ... to here, so that the inline functions mentioned
7152 * dired.c (directory_files_internal_unwind): Now static.
7154 * fileio.c (file_name_as_directory, directory_file_name):
7155 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7157 (file_name_as_directory): Use const pointers when appropriate.
7158 (Fexpand_file_name): Likewise. In particular, newdir might
7159 point at constant storage, so make it a const pointer.
7160 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7161 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7163 (Fset_file_times, Finsert_file_contents, auto_save_error):
7164 Rename locals to avoid shadowing.
7166 * minibuf.c (choose_minibuf_frame_1): Now static.
7167 (Ftry_completion, Fall_completions): Rename or remove locals
7170 * marker.c (bytepos_to_charpos): Remove; unused.
7172 * lisp.h (verify_bytepos, count_markers): New decls,
7173 so that gcc does not warn that these functions aren't declared.
7175 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7176 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7177 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7178 (copy_text): Remove unused local var.
7180 * filelock.c (within_one_second): Now static.
7181 (lock_file_1): Rename local to avoid shadowing.
7183 * buffer.c (fix_overlays_before): Mark locals as initialized.
7184 (fix_start_end_in_overlays): Likewise. This function should be
7185 simplified by using pointers-to-pointers, but that's a different
7187 (switch_to_buffer_1): Now static.
7188 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7189 (report_overlay_modification): Rename locals to avoid shadowing.
7191 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7192 Fix pointer signedness issue.
7193 (sys_subshell): Mark local as volatile if checking for lint,
7194 to suppress a gcc -Wclobbered warning that does not seem to be right.
7195 (MAXPATHLEN): Define only if needed.
7197 * process.c (serial_open, serial_configure): Move decls from here ...
7198 * systty.h: ... to here, so that they can be checked.
7200 * fns.c (get_random, seed_random): Move extern decls from here ...
7201 * lisp.h: ... to here, so that they can be checked.
7203 * sysdep.c (reset_io): Now static.
7204 (wait_for_termination_signal): Remove; unused.
7206 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7207 (copy_keymap_item, append_key, push_text_char_description):
7209 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7210 (DENSE_TABLE_SIZE): Remove; unused.
7211 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7212 (describe_map_tree):
7213 Rename locals to avoid shadowing.
7215 * keyboard.c: Declare functions static if they are not used elsewhere.
7216 (echo_char, echo_dash, cmd_error, top_level_2):
7217 (poll_for_input, handle_async_input): Now static.
7218 (read_char, kbd_buffer_get_event, make_lispy_position):
7219 (make_lispy_event, make_lispy_movement, apply_modifiers):
7220 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7221 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7222 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7223 (read_key_sequence, read_char): Mark locals as initialized.
7224 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7226 * keyboard.h (make_ctrl_char): New decl.
7227 (mark_kboards): Move decl here ...
7228 * alloc.c (mark_kboards): ... from here.
7230 * lisp.h (force_auto_save_soon): New decl.
7232 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7233 (DEFINE_DUMMY_FUNCTION): New macro.
7234 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7236 (main): Add casts to avoid warnings
7237 if GCC considers string literals to be constants.
7239 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7241 * dbusbind.c: Pointer signedness fixes.
7242 (xd_signature, xd_append_arg, xd_initialize):
7243 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7244 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7245 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7246 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7248 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7249 if GCC considers string literals to be constants.
7250 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7252 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7254 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7255 (print_preprocess, print_object): New macro to fix last change.
7257 * print.c (print_preprocess): Don't forget font objects.
7259 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7261 * emacs.c (USAGE3): Doc fixes.
7263 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7265 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7268 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7270 * lisp.h (VWindow_system, Qfile_name_history):
7271 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7272 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7273 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7275 * w32select.c: Don't #include "keyboard.h".
7276 (run_protected): Add extern declaration for waiting_for_input.
7278 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7279 * w32console.c (detect_input_pending, read_input_pending)
7280 (encode_terminal_code):
7281 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7282 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7283 (w32_system_caret_y, Qfile_name_history):
7284 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7285 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7286 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7287 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7288 * w32proc.c (Qlocal, report_file_error):
7289 * w32term.c (Vwindow_system, updating_frame):
7290 * w32uniscribe.c (initialized, uniscribe_font_driver):
7291 Remove unneeded extern declarations.
7293 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7295 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7297 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7299 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7300 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7301 These macros can no longer be used for assignment.
7303 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7304 Assign struct members directly, instead of using BUF_BEGV etc.
7305 (record_buffer_markers, fetch_buffer_markers): New functions for
7306 recording and fetching special buffer markers.
7307 (set_buffer_internal_1, set_buffer_temp): Use them.
7309 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7311 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7313 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7314 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7316 * xdisp.c (hscroll_window_tree):
7317 (reconsider_clip_changes): Use PT instead of BUF_PT.
7319 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7321 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7322 $(EMACS_ROOT)/lib/intprops.h.
7324 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7326 Fix more problems found by GCC 4.5.2's static checks.
7328 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7329 to unsigned char * to avoid compiler diagnostic.
7330 (xg_free_frame_widgets): Make it clear that a local variable is
7331 needed only if USE_GTK_TOOLTIP.
7332 (gdk_window_get_screen): Make it clear that this macro is needed
7333 only if USE_GTK_TOOLTIP.
7334 (int_gtk_range_get_value): New function, which avoids a diagnostic
7335 from gcc -Wbad-function-cast.
7336 (xg_set_toolkit_scroll_bar_thumb): Use it.
7337 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7338 diagnostic from gcc -Wbad-function-cast.
7339 (get_utf8_string, xg_get_file_with_chooser):
7340 Rename locals to avoid shadowing.
7341 (create_dialog): Move locals to avoid shadowing.
7343 * xgselect.c (xg_select): Remove unused var.
7345 * image.c (four_corners_best): Mark locals as initialized.
7346 (gif_load): Initialize transparent_p to zero (Bug#8238).
7347 Mark another local as initialized.
7348 (my_png_error, my_error_exit): Mark with NO_RETURN.
7350 * image.c (clear_image_cache): Now static.
7351 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7352 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7353 (x_edge_detection): Remove unnecessary cast that
7354 gcc -Wbad-function-cast diagnoses.
7355 (gif_load): Fix pointer signedness.
7356 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7357 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7359 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7361 Improve quality of tests for time stamp overflow.
7362 For example, without this patch (encode-time 0 0 0 1 1
7363 1152921504606846976) returns the obviously-bogus value (-948597
7364 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7365 reports time overflow. See
7366 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7367 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7368 * editfns.c: Include limits.h and intprops.h.
7369 (TIME_T_MIN, TIME_T_MAX): New macros.
7370 (time_overflow): Move earlier, to before first use.
7371 (hi_time, lo_time): New functions, for an accurate test for
7373 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7374 (Fget_internal_run_time): Don't assume time_t fits in int.
7375 (make_time): Use list2 instead of Fcons twice.
7376 (Fdecode_time): More accurate test for out-of-range times.
7377 (check_tm_member): New function.
7378 (Fencode_time): Use it, to test for out-of-range times.
7379 (lisp_time_argument): Don't rely on undefined left-shift and
7380 right-shift behavior when checking for time stamp overflow.
7382 * editfns.c (time_overflow): New function, refactoring common code.
7383 (Fformat_time_string, Fdecode_time, Fencode_time):
7384 (Fcurrent_time_string): Use it.
7386 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7387 * dired.c (make_time): Move to ...
7388 * editfns.c (make_time): ... here.
7389 * systime.h: Note the move.
7391 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7393 * fringe.c (update_window_fringes): Remove unused variables.
7395 * unexmacosx.c (copy_data_segment): Also copy __got section.
7398 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7400 * termcap.c [MSDOS]: Include "msdos.h".
7401 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7402 Constify `char *' arguments and their references according to
7403 prototypes in tparam.h.
7405 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7407 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7408 Adapt all references accordingly.
7410 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7412 2011-03-11 Tom Tromey <tromey@redhat.com>
7414 * buffer.c (syms_of_buffer): Remove obsolete comment.
7416 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7418 * termhooks.h (encode_terminal_code): Declare prototype.
7420 * msdos.c (encode_terminal_code): Don't declare prototype.
7422 * term.c (encode_terminal_code): Now external again, used by
7423 w32console.c and msdos.c.
7425 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7426 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7428 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7430 Fix some minor problems found by GCC 4.5.2's static checks.
7432 * fringe.c (update_window_fringes): Mark locals as initialized
7434 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7436 * alloc.c (mark_fringe_data): Move decl from here ...
7437 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7438 to check its interface.
7439 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7441 * fontset.c (free_realized_fontset): Now static.
7442 (Fset_fontset_font): Rename local to avoid shadowing.
7443 (fontset_font): Mark local as initialized.
7444 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7446 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7448 * xselect.c (x_disown_buffer_selections): Remove; not used.
7449 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7450 (x_own_selection, Fx_disown_selection_internal): Rename locals
7452 (x_handle_dnd_message): Remove local to avoid shadowing.
7454 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7455 so that the caller can use some name other than gcpro1.
7456 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7457 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7458 (Fx_backspace_delete_keys_p):
7459 Use them to avoid shadowing, and rename vars to avoid shadowing.
7460 (x_decode_color, x_set_name, x_window): Now static.
7461 (Fx_create_frame): Add braces to silence GCC warning.
7462 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7463 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7464 Remove unused locals.
7465 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7466 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7467 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7470 * xterm.h (x_mouse_leave): New decl.
7472 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7473 Remove unused functions.
7474 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7475 (x_calc_absolute_position): Now static.
7476 (XTread_socket): Don't define label "out" unless it's used.
7477 Don't declare local "event" unless it's used.
7478 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7479 unless they are used.
7480 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7481 (x_fatal_error_signal): Remove; not used.
7482 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7483 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7484 (x_error_catcher, x_connection_closed, x_error_handler):
7485 (x_error_quitter, xembed_send_message, x_iconify_frame):
7486 (my_log_handler): Rename locals to avoid shadowing.
7487 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7488 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7490 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7491 Rename or move locals to avoid shadowing.
7492 (tty_defined_color, merge_face_heights): Now static.
7493 (free_realized_faces_for_fontset): Remove; not used.
7494 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7495 does not deduce is never used uninitialized.
7496 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7497 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7499 * terminal.c (store_terminal_param): Now static.
7501 * xmenu.c (menu_highlight_callback): Now static.
7502 (set_frame_menubar): Remove unused local.
7503 (xmenu_show): Rename parameter to avoid shadowing.
7504 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7505 since they might point to immutable storage.
7506 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7507 since it's unused otherwise.
7509 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7510 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7511 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7512 avoids a gcc -Wuninitialized diagnostic.
7513 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7514 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7515 does not deduce are never used uninitialized.
7517 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7519 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7520 * window.c (window_loop, size_window):
7521 (run_window_configuration_change_hook, enlarge_window): Likewise.
7523 * window.c (display_buffer): Now static.
7524 (size_window): Mark variables that gcc -Wuninitialized
7525 does not deduce are never used uninitialized.
7526 * window.h (check_all_windows): New decl, to forestall
7527 gcc -Wmissing-prototypes diagnostic.
7528 * dispextern.h (bidi_dump_cached_states): Likewise.
7530 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7532 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7534 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7535 and to avoid gcc -Wuninitialized warning.
7536 (load_charset_map): Mark variables that gcc -Wuninitialized
7537 does not deduce are never used uninitialized.
7538 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7540 * coding.c (coding_set_source, coding_set_destination):
7541 Use "else { /* comment */ }" rather than "else /* comment */;"
7542 for clarity, and to avoid gcc -Wempty-body warning.
7543 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7544 a block, when the outer 'i' will do.
7545 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7546 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7547 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7548 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7549 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7550 Rename locals to avoid shadowing.
7551 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7552 * coding.c (emacs_mule_char, encode_invocation_designation):
7553 Now static, since they're not used elsewhere.
7554 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7555 (decode_coding_object, encode_coding_object, detect_coding_system):
7556 (decode_coding_emacs_mule): Mark variables that gcc
7557 -Wuninitialized does not deduce are never used uninitialized.
7558 (detect_coding_iso_2022): Initialize a local variable that might
7559 be used uninitialized. Leave a FIXME because it's not clear that
7560 this initialization is needed. (Bug#8211)
7561 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7562 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7563 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7564 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7565 Remove unused macros.
7567 * category.c (hash_get_category_set): Remove unused local var.
7568 (copy_category_table): Now static, since it's not used elsewhere.
7569 * character.c (string_count_byte8): Likewise.
7571 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7572 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7574 * chartab.c (copy_sub_char_table): Now static, since it's not used
7576 (sub_char_table_ref_and_range, char_table_ref_and_range):
7577 Rename locals to avoid shadowing.
7578 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7580 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7581 (BIDI_BOB): Remove unused macro.
7583 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7584 deduce are never used uninitialized.
7585 * term.c (encode_terminal_code): Likewise.
7587 * term.c (encode_terminal_code): Now static. Remove unused local.
7589 * tparam.h: New file.
7590 * term.c, tparam.h: Include it.
7591 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7592 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7593 Move these decls to tparam.h, and make them agree with what
7594 is actually in tparam.c. The previous trick of using incompatible
7595 decls in different modules does not conform to the C standard.
7596 All callers of tparam changed to use tparam's actual API.
7597 * tparam.c (tparam1, tparam, tgoto):
7598 Use const pointers where appropriate.
7600 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7601 * cm.h (struct cm): Likewise.
7602 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7603 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7604 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7605 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7606 (turn_on_face, init_tty): Likewise.
7607 * termchar.h (struct tty_display_info): Likewise.
7609 * term.c (term_mouse_position): Rename local to avoid shadowing.
7611 * alloc.c (mark_ttys): Move decl from here ...
7612 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7614 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7616 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7618 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7620 * search.c (compile_pattern_1): Remove argument regp, unused since
7621 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7622 (compile_pattern): Don't pass it.
7624 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7626 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7627 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7629 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7631 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7633 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7634 gdk_window_get_screen, gdk_window_get_geometry,
7635 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7636 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7637 (xg_get_pixbuf_from_pixmap): New function.
7638 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7639 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7640 Call xg_get_pixbuf_from_pixmap instead of
7641 gdk_pixbuf_get_from_drawable.
7642 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7643 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7644 (xg_check_special_colors): Use GtkStyleContext and its functions
7646 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7647 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7648 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7649 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7650 Call gtk_widget_get_preferred_size.
7651 (xg_frame_resized): gdk_window_get_geometry only takes 5
7653 (xg_win_to_widget, xg_event_is_for_menubar):
7654 Call gdk_x11_window_lookup_for_display.
7655 (xg_set_widget_bg): New function.
7656 (delete_cb): New function.
7657 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7658 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7659 (xg_set_background_color): Call xg_set_widget_bg.
7660 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7661 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7662 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7663 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7665 (update_frame_tool_bar): Call gtk_widget_hide.
7666 (xg_initialize): Use GDK_KEY_g.
7668 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7670 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7672 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7673 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7674 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7676 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7678 * w32xfns.c (select_palette): Check success of RealizePalette against
7679 GDI_ERROR, not zero.
7681 See ChangeLog.11 for earlier changes.
7687 Copyright (C) 2011 Free Software Foundation, Inc.
7689 This file is part of GNU Emacs.
7691 GNU Emacs is free software: you can redistribute it and/or modify
7692 it under the terms of the GNU General Public License as published by
7693 the Free Software Foundation, either version 3 of the License, or
7694 (at your option) any later version.
7696 GNU Emacs is distributed in the hope that it will be useful,
7697 but WITHOUT ANY WARRANTY; without even the implied warranty of
7698 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7699 GNU General Public License for more details.
7701 You should have received a copy of the GNU General Public License
7702 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.