* xselect.c: Integer signedness and overflow fixes.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-07 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xselect.c: Integer signedness and overflow fixes.
4 (Fx_register_dnd_atom, x_handle_dnd_message):
5 Use ptrdiff_t, not size_t, since we prefer signed.
6 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8 x_dnd_atoms_size and x_dnd_atoms_length.
9
10 * doprnt.c: Prefer signed to unsigned when either works.
11 * eval.c (verror):
12 * doprnt.c (doprnt):
13 * lisp.h (doprnt):
14 * xdisp.c (vmessage):
15 Use ptrdiff_t, not size_t, when using or implementing doprnt,
16 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
17 prefer signed arithmetic to avoid comparison confusion.
18 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
19 but is a bit tricky.
20
21 Assume freestanding C89 headers, string.h, stdlib.h.
22 * data.c, doprnt.c, floatfns.c, print.c:
23 Include float.h unconditionally.
24 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
25 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
26 * regex.c: Likewise for stddef.h, string.h.
27 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
28 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
29 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
30 (STDC_HEADERS): Remove obsolete defines.
31 * sysdep.c: Include limits.h unconditionally.
32
33 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
34
35 Assume support for memcmp, memcpy, memmove, memset.
36 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
37 * regex.c (memcmp, memcpy):
38 Remove; we assume C89 now.
39
40 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
41 (__malloc_safe_bcopy): Remove; no longer needed.
42
43 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
44 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
45 well either way, and we prefer signed to unsigned.
46
47 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
48
49 Remove unportable assumption about struct layout (Bug#8884).
50 * alloc.c (mark_buffer):
51 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
52 (clone_per_buffer_values): Don't assume that
53 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
54 This isn't true in general, and it's particularly not true
55 if Emacs is configured with --with-wide-int.
56 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
57 New macros, used in the buffer.c change.
58
59 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
60
61 * xsettings.c: Use both GConf and GSettings if both are available.
62 (store_config_changed_event): Add comment.
63 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
64 (store_tool_bar_style_changed): New functions.
65 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
66 (struct xsettings): Move font inside HAVE_XFT.
67 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
68 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
69 Move inside HAVE_XFT.
70 (something_changed_gsettingsCB): Renamed from something_changedCB.
71 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
72 also.
73 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
74 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
75 (something_changed_gconfCB): Renamed from something_changedCB.
76 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
77 (parse_settings): Move check for font inside HAVE_XFT.
78 (read_settings, apply_xft_settings): Add comment.
79 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
80 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
81 call store_font_name_changed.
82 (xft_settings_event): Add comment.
83 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
84 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
85 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
86 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
87 (xsettings_initialize): Call init_gsettings last.
88 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
89 comment.
90
91 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
92
93 Random fixes. E.g., (random) never returned negative values.
94 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
95 subseconds part to the entropy, as that's a bit more random.
96 Prefer signed to unsigned, since the signedness doesn't matter and
97 in general we prefer signed. When given a limit, use a
98 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
99 latter isn't right if USE_2_TAGS_FOR_INTS.
100 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
101 not 0..VALMASK. Don't discard "excess" bits that random () returns.
102
103 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
104
105 * textprop.c (text_property_stickiness):
106 Obey Vtext_property_default_nonsticky.
107 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
108 * w32fns.c (syms_of_w32fns):
109 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
110
111 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
112
113 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
114 This is more efficient than Ffile_directory_p and avoids a minor race.
115
116 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
117
118 * buffer.c (Foverlay_put): Say what the return value is
119 (bug#7835).
120
121 * fileio.c (barf_or_query_if_file_exists): Check first if the file
122 is a directory before asking whether to use the file name
123 (bug#7564).
124 (barf_or_query_if_file_exists): Make the "File is a directory"
125 error be more correct.
126
127 * fns.c (Frequire): Remove the mention of the .gz files, since
128 that's installation-specific, but keep the mention of
129 `get-load-suffixes'.
130
131 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
132
133 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
134 Report string overflow if the output is too long.
135
136 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
137
138 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
139 (syms_of_gnutls): Remove duplicate DEFSYM for
140 Qgnutls_bootprop_verify_hostname_error, an error for
141 Qgnutls_bootprop_verify_error (which is no longer used).
142
143 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
144 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
145 Also (re)move comments that are misplaced or no longer relevant.
146
147 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
148
149 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
150
151 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
152
153 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
154 and background color parameters if they have been changed.
155
156 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
157
158 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
159
160 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
161
162 * xsettings.c (SYSTEM_FONT): Define only when used.
163 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
164
165 * keymap.c (access_keymap_1): Now static.
166
167 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
168
169 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
170 leave any prefix arg for the up event (Bug#1586).
171
172 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
173
174 * lread.c (syms_of_lread): Mention single symbols defined by
175 `defvar' or `defconst' (bug#7154).
176
177 * fns.c (Frequire): Mention .el.gz files (bug#7314).
178 (Frequire): Mention get-load-suffixes.
179
180 2011-07-02 Martin Rudalics <rudalics@gmx.at>
181
182 * window.h (window): Remove clone_number slot.
183 * window.c (Fwindow_clone_number, Fset_window_clone_number):
184 Remove.
185 (make_parent_window, make_window, saved_window)
186 (Fset_window_configuration, save_window_save): Don't deal with
187 clone numbers.
188 * buffer.c (Qclone_number): Remove declaration.
189 (sort_overlays, overlay_strings): Don't deal with clone numbers.
190
191 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
192
193 Add multiple inheritance to keymaps.
194 * keymap.c (Fmake_composed_keymap): New function.
195 (Fset_keymap_parent): Simplify.
196 (fix_submap_inheritance): Remove.
197 (access_keymap_1): New function extracted from access_keymap to handle
198 embedded parents and handle lists of maps.
199 (access_keymap): Use it.
200 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
201 (Fcopy_keymap): Handle embedded parents.
202 (Fcommand_remapping, define_as_prefix): Simplify.
203 (Fkey_binding): Simplify.
204 (syms_of_keymap): Move minibuffer-local-completion-map,
205 minibuffer-local-filename-completion-map,
206 minibuffer-local-must-match-map, and
207 minibuffer-local-filename-must-match-map to Elisp.
208 (syms_of_keymap): Defsubr make-composed-keymap.
209 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
210 (parse_menu_item): Trivial simplification.
211
212 2011-07-01 Glenn Morris <rgm@gnu.org>
213
214 * Makefile.in (SETTINGS_LIBS): Fix typo.
215
216 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
217
218 * coding.c (Fencode_coding_string): Record the last coding system
219 used, as the function doc string says (bug#8738).
220
221 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
222
223 * xsettings.c (store_monospaced_changed): Take new font as arg and
224 check for change against current_mono_font.
225 (EMACS_TYPE_SETTINGS): Remove this and related defines.
226 (emacs_settings_constructor, emacs_settings_get_property)
227 (emacs_settings_set_property, emacs_settings_class_init)
228 (emacs_settings_init, gsettings_obj): Remove.
229 (something_changedCB): New function for HAVE_GSETTINGS.
230 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
231 with value as argument.
232 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
233 g_settings_new (Bug#8967). Do not create gsettings_obj.
234 Remove calls to g_settings_bind. Connect something_changedCB to
235 "changed".
236
237 * xgselect.c: Add defined (HAVE_GSETTINGS).
238 (xgselect_initialize): Ditto.
239
240 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
241 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
242 xg_select.
243
244 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
245
246 * eval.c (struct backtrace): Simplify and port the data structure.
247 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
248 signed bit field, as this assumption is not portable and it makes
249 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
250 "char debug_on_exit : 1" as this is not portable either; instead,
251 use the portable "unsigned int debug_on_exit : 1". Remove unused
252 member evalargs. Remove obsolete comments about cc bombing out.
253
254 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
255
256 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
257 Let HAVE_GSETTINGS override HAVE_GCONF.
258 (store_monospaced_changed): New function.
259 (EMACS_SETTINGS): A new type derived from GObject to handle
260 GSettings notifications.
261 (emacs_settings_constructor, emacs_settings_get_property)
262 (emacs_settings_set_property, emacs_settings_class_init):
263 New functions.
264 (gsettings_client, gsettings_obj): New variables.
265 (GSETTINGS_SCHEMA): New define.
266 (something_changedCB): Call store_monospaced_changed.
267 (init_gsettings): New function.
268 (xsettings_initialize): Call init_gsettings.
269 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
270 to NULL.
271
272 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
273 GCONF_CFLAGS/LIBS.
274
275 2011-06-29 Martin Rudalics <rudalics@gmx.at>
276
277 * window.c (resize_root_window, grow_mini_window)
278 (shrink_mini_window): Rename Qresize_root_window to
279 Qwindow_resize_root_window and Qresize_root_window_vertically to
280 Qwindow_resize_root_window_vertically.
281
282 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
283
284 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
285
286 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
287
288 * makefile.w32-in: Redesign dependencies so they reflect more
289 clearly which files are directly included by each source file,
290 and not through other includes.
291
292 2011-06-27 Martin Rudalics <rudalics@gmx.at>
293
294 * buffer.c (Qclone_number): Declare static and DEFSYM it.
295 (sort_overlays, overlay_strings): When an overlay's clone number
296 matches the window's clone number process the overlay even if
297 the overlay's window property doesn't match the current window.
298
299 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
300 (Fwindow_hchild): Rename to Fwindow_left_child.
301 (Fwindow_next): Rename to Fwindow_next_sibling.
302 (Fwindow_prev): Rename to Fwindow_prev_sibling.
303 (resize_window_check): Rename to window_resize_check.
304 (resize_window_apply): Rename to window_resize_apply.
305 (Fresize_window_apply): Rename to Fwindow_resize_apply.
306 (Fdelete_other_windows_internal, resize_frame_windows)
307 (Fsplit_window_internal, Fdelete_window_internal)
308 (grow_mini_window, shrink_mini_window)
309 (Fresize_mini_window_internal): Fix callers accordingly.
310
311 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
312
313 * emacsgtkfixed.h: State that this is only used with Gtk+3.
314 (emacs_fixed_set_min_size): Remove.
315 (emacs_fixed_new): Take frame as argument.
316
317 * emacsgtkfixed.c: State that this is only used with Gtk+3.
318 (_EmacsFixedPrivate): Remove minwidth/height.
319 Add struct frame *f.
320 (emacs_fixed_init): Initialize priv->f.
321 (get_parent_class, emacs_fixed_set_min_size): Remove.
322 (emacs_fixed_new): Set priv->f to argument.
323 (emacs_fixed_get_preferred_width)
324 (emacs_fixed_get_preferred_height): Use min_width/height from
325 frames size_hint to set minimum and natural (Bug#8919).
326 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
327 and use min_width/height from frames size_hint to set
328 min_width/height (Bug#8919).
329
330 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
331 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
332 Fix indentation.
333
334 2011-06-26 Eli Zaretskii <eliz@gnu.org>
335
336 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
337 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
338 called at ZV.
339
340 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
341
342 * process.c (wait_reading_process_output): Bypass select if
343 waiting for a cell while ignoring keyboard input, and input is
344 pending. Suggested by Jan Djärv (Bug#8869).
345
346 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
347
348 Use gnulib's dup2 module instead of rolling our own.
349 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
350
351 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
352
353 * dispnew.c (scrolling_window): Before scrolling, turn off a
354 mouse-highlight in the window being scrolled.
355
356 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
357
358 Move DEFSYM to lisp.h and use everywhere.
359
360 * character.h (DEFSYM): Move declaration...
361 * lisp.h (DEFSYM): ...here.
362
363 * gnutls.c:
364 * minibuf.c:
365 * w32menu.c:
366 * w32proc.c:
367 * w32select.c: Don't include character.h.
368
369 * alloc.c (syms_of_alloc):
370 * buffer.c (syms_of_buffer):
371 * bytecode.c (syms_of_bytecode):
372 * callint.c (syms_of_callint):
373 * casefiddle.c (syms_of_casefiddle):
374 * casetab.c (init_casetab_once):
375 * category.c (init_category_once, syms_of_category):
376 * ccl.c (syms_of_ccl):
377 * cmds.c (syms_of_cmds):
378 * composite.c (syms_of_composite):
379 * dbusbind.c (syms_of_dbusbind):
380 * dired.c (syms_of_dired):
381 * dispnew.c (syms_of_display):
382 * doc.c (syms_of_doc):
383 * editfns.c (syms_of_editfns):
384 * emacs.c (syms_of_emacs):
385 * eval.c (syms_of_eval):
386 * fileio.c (syms_of_fileio):
387 * fns.c (syms_of_fns):
388 * frame.c (syms_of_frame):
389 * fringe.c (syms_of_fringe):
390 * insdel.c (syms_of_insdel):
391 * keymap.c (syms_of_keymap):
392 * lread.c (init_obarray, syms_of_lread):
393 * macros.c (syms_of_macros):
394 * msdos.c (syms_of_msdos):
395 * print.c (syms_of_print):
396 * process.c (syms_of_process):
397 * search.c (syms_of_search):
398 * sound.c (syms_of_sound):
399 * syntax.c (init_syntax_once, syms_of_syntax):
400 * terminal.c (syms_of_terminal):
401 * textprop.c (syms_of_textprop):
402 * undo.c (syms_of_undo):
403 * w32.c (globals_of_w32):
404 * window.c (syms_of_window):
405 * xdisp.c (syms_of_xdisp):
406 * xfaces.c (syms_of_xfaces):
407 * xfns.c (syms_of_xfns):
408 * xmenu.c (syms_of_xmenu):
409 * xsettings.c (syms_of_xsettings):
410 * xterm.c (syms_of_xterm): Use DEFSYM.
411
412 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
413
414 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
415
416 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
417
418 Integer and buffer overflow fixes (Bug#8873).
419
420 * print.c (printchar, strout): Check for string overflow.
421 (PRINTPREPARE, printchar, strout):
422 Don't set size unless allocation succeeds.
423
424 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
425 for sizes. Check for string overflow more accurately.
426 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
427
428 * macros.c: Integer and buffer overflow fixes.
429 * keyboard.h (struct keyboard.kbd_macro_bufsize):
430 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
431 Use ptrdiff_t, not int, for sizes.
432 Don't increment bufsize until after realloc succeeds.
433 Check for size-calculation overflow.
434 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
435
436 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
437
438 * lread.c: Integer overflow fixes.
439 (read_integer): Radix is now EMACS_INT, not int,
440 to improve quality of diagnostics for out-of-range radices.
441 Calculate buffer size correctly for out-of-range radices.
442 (read1): Check for integer overflow in radices, and in
443 read-circle numbers.
444 (read_escape): Avoid int overflow.
445 (Fload, openp, read_buffer_size, read1)
446 (substitute_object_recurse, read_vector, read_list, map_obarray):
447 Use ptrdiff_t, not int, for sizes.
448 (read1): Use EMACS_INT, not int, for sizes.
449 Check for size overflow.
450
451 * image.c (cache_image): Check for size arithmetic overflow.
452
453 * lread.c: Integer overflow issues.
454 (saved_doc_string_size, saved_doc_string_length)
455 (prev_saved_doc_string_size, prev_saved_doc_string_length):
456 Now ptrdiff_t, not int.
457 (read1): Don't assume doc string length fits in int. Check for
458 out-of-range doc string lengths.
459 (read_list): Don't assume file position fits in int.
460 (read_escape): Check for hex character overflow.
461
462 2011-06-22 Leo Liu <sdl.web@gmail.com>
463
464 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
465 Move to minibuffer.el.
466
467 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
468
469 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
470 The following patches are for when GLYPH_DEBUG && !XASSERT.
471 * dispextern.h (trace_redisplay_p, dump_glyph_string):
472 * dispnew.c (flush_stdout):
473 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
474 Mark as externally visible.
475 * dispnew.c (check_window_matrix_pointers): Now static.
476 * dispnew.c (window_to_frame_vpos):
477 * xfns.c (unwind_create_frame):
478 * xterm.c (x_check_font): Remove unused local.
479 * scroll.c (CHECK_BOUNDS):
480 * xfaces.c (cache_fache): Rename local to avoid shadowing.
481 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
482 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
483 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
484 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
485 Now static.
486 (debug_method_add): Use va_list and vsprintf rather than relying
487 on undefined behavior with wrong number of arguments.
488 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
489 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
490 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
491 since we're not interested in debugging glyphs with old libraries.
492 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
493 GCC 4.6.0's static checking.
494
495 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
496
497 Integer overflow and signedness fixes (Bug#8873).
498 A few related buffer overrun fixes, too.
499
500 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
501
502 * dispextern.h (struct face.stipple):
503 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
504 (x_bitmap_mask, x_allocate_bitmap_record)
505 (x_create_bitmap_from_data, x_create_bitmap_from_file)
506 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
507 (x_create_bitmap_from_xpm_data):
508 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
509 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
510 (.bitmaps_last):
511 * xfaces.c (load_pixmap):
512 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
513 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
514 (.bitmaps_last, struct x_output.icon_bitmap):
515 Use ptrdiff_t, not int, for bitmap indexes.
516 (x_allocate_bitmap_record): Check for size overflow.
517 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
518
519 Use ptrdiff_t, not int, for overlay counts.
520 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
521 * editfns.c (overlays_around, get_pos_property):
522 * textprop.c (get_char_property_and_overlay):
523 * xdisp.c (next_overlay_change, note_mouse_highlight):
524 * xfaces.c (face_at_buffer_position):
525 * buffer.c (OVERLAY_COUNT_MAX): New macro.
526 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
527 (Fnext_overlay_change, Fprevious_overlay_change)
528 (mouse_face_overlay_overlaps, Foverlays_in):
529 Use ptrdiff_t, not int, for sizes.
530 (overlays_at, overlays_in): Check for size-calculation overflow.
531
532 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
533
534 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
535 (x_session_initialize): Do not assume string length fits in int.
536
537 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
538 This is unlikely, but can occur if DPI is outlandish.
539
540 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
541 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
542
543 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
544 * xrdb.c (magic_file_p, search_magic_path):
545 Omit last arg SUFFIX; it was always 0. All callers changed.
546 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
547
548 * xfont.c (xfont_match): Avoid need for strlen.
549
550 * xfns.c: Don't assume strlen fits in int.
551 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
552
553 * xdisp.c (message_log_check_duplicate): Return intmax_t,
554 not unsigned long, as we prefer signed integers. All callers changed.
555 Detect integer overflow in repeat count.
556 (message_dolog): Don't assume print length fits in 39 bytes.
557 (display_mode_element): Don't assume strlen fits in int.
558
559 * termcap.c: Don't assume sizes fit in int and never overflow.
560 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
561 (gobble_line): Check for size-calculation overflow.
562
563 * minibuf.c (Fread_buffer):
564 * lread.c (intern, intern_c_string):
565 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
566 Don't assume string length fits in int.
567
568 * keyboard.c (parse_tool_bar_item):
569 * gtkutil.c (style_changed_cb): Avoid need for strlen.
570
571 * font.c: Don't assume string length fits in int.
572 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
573 Use ptrdiff_t, not int.
574 (font_intern_prop): Don't assume string length fits in int.
575 Don't assume integer property fits in fixnum.
576 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
577
578 * filelock.c: Fix some buffer overrun and integer overflow issues.
579 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
580 Reformulate so as not to need the command string.
581 Invoke gzip -cd rather than gunzip, as it's more portable.
582 (lock_info_type, lock_file_1, lock_file):
583 Don't assume pid_t and time_t fit in unsigned long.
584 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
585 (current_lock_owner): Prefer signed type for sizes.
586 Use memcpy, not strncpy, where memcpy is what is really wanted.
587 Don't assume (via atoi) that time_t and pid_t fit in int.
588 Check for time_t and/or pid_t out of range, e.g., via a network share.
589 Don't alloca where an auto var works fine.
590
591 * fileio.c: Fix some integer overflow issues.
592 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
593 Don't assume string length fits in int.
594 (directory_file_name): Don't assume string length fits in long.
595 (make_temp_name): Don't assume pid fits in int, or that its print
596 length is less than 20.
597
598 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
599
600 * coding.c (make_subsidiaries): Don't assume string length fits in int.
601
602 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
603
604 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
605 We prefer signed integers, even for size calculations.
606
607 * emacs.c: Don't assume string length fits in 'int'.
608 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
609 (main): Don't invoke strlen when not needed.
610
611 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
612 (XD_DEBUG_MESSAGE): Don't waste a byte.
613
614 * callproc.c (getenv_internal_1, getenv_internal)
615 (Fgetenv_internal):
616 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
617
618 * lread.c (invalid_syntax): Omit length argument.
619 All uses changed. This doesn't fix a bug, but it simplifies the
620 code away from its former Hollerith-constant appearance, and it's
621 one less 'int' to worry about when looking at integer-overflow issues.
622 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
623
624 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
625 This didn't break anything, but it didn't help either.
626 It's confusing to put a bogus integer in a place where the actual
627 value does not matter.
628 (LIST_END_P): Remove unused macro and its bogus comment.
629 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
630
631 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
632 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
633 implementation.
634 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
635 We prefer signed types, and the value cannot exceed the EMACS_INT
636 range anyway (because otherwise the length would not be representable).
637 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
638 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
639 This avoids a GCC warning when WIDE_EMACS_INT.
640
641 * indent.c (sane_tab_width): New function.
642 (current_column, scan_for_column, Findent_to, position_indentation)
643 (compute_motion): Use it. This is just for clarity.
644 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
645
646 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
647
648 * lisp.h (lint_assume): New macro.
649 * composite.c (composition_gstring_put_cache):
650 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
651
652 * editfns.c, insdel.c:
653 Omit unnecessary forward decls, to simplify future changes.
654
655 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
656
657 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
658
659 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
660 Use much-faster test for byte-length change.
661 Don't assume string byte-length fits in 'int'.
662 Check that character arg fits in 'int'.
663 (mapcar1): Declare byte as byte, for clarity.
664
665 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
666
667 * fns.c (concat): Catch string overflow earlier.
668 Do not rely on integer wraparound.
669
670 * dispextern.h (struct it.overlay_strings_charpos)
671 (struct it.selective): Now EMACS_INT, not int.
672 * xdisp.c (forward_to_next_line_start)
673 (back_to_previous_visible_line_start)
674 (reseat_at_next_visible_line_start, next_element_from_buffer):
675 Don't arbitrarily truncate the value of 'selective' to int.
676
677 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
678
679 * composite.c: Don't truncate sizes to 'int'.
680 (composition_gstring_p, composition_reseat_it)
681 (composition_adjust_point): Use EMACS_INT, not int.
682 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
683 not EMACS_UINT, for indexes.
684
685 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
686
687 * buffer.c: Include <verify.h>.
688 (struct sortvec.priority, struct sortstr.priority):
689 Now EMACS_INT, not int.
690 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
691 (struct sortstr.size, record_overlay_string)
692 (struct sortstrlist.size, struct sortlist.used):
693 Don't truncate size to int.
694 (record_overlay_string): Check for size-calculation overflow.
695 (init_buffer_once): Check at compile-time, not run-time.
696
697 2011-06-22 Jim Meyering <meyering@redhat.com>
698
699 Don't leak an XBM-image-sized buffer
700 * image.c (xbm_load): Free the image buffer after using it.
701
702 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
703
704 Port to Sun C.
705 * composite.c (find_automatic_composition): Omit needless 'return 0;'
706 that Sun C diagnosed.
707 * fns.c (secure_hash): Fix pointer signedness issue.
708 * intervals.c (static_offset_intervals): New function.
709 (offset_intervals): Use it.
710
711 2011-06-21 Leo Liu <sdl.web@gmail.com>
712
713 * deps.mk (fns.o):
714 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
715 sha512.h.
716
717 * fns.c (secure_hash): Rename from crypto_hash_function and change
718 the first arg to accept symbols.
719 (Fsecure_hash): New primitive.
720 (syms_of_fns): New symbols.
721
722 2011-06-20 Deniz Dogan <deniz@dogan.se>
723
724 * process.c (Fset_process_buffer): Clarify return value in
725 docstring.
726
727 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
728
729 * dispnew.c (add_window_display_history): Use BVAR.
730
731 * xdisp.c (debug_method_add): Use BVAR.
732 (check_window_end, dump_glyph_matrix, dump_glyph)
733 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
734
735 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
736 Likewise.
737
738 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
739 check till after the cache is created in init_frame_faces.
740
741 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
742
743 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
744
745 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
746
747 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
748 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
749 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
750
751 Improve buffer-overflow checking (Bug#8873).
752 * fileio.c (Finsert_file_contents):
753 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
754 Remove the old (too-loose) buffer overflow checks.
755 They weren't needed, since make_gap checks for buffer overflow.
756 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
757 The old code merely checked for Emacs fixnum overflow, and relied
758 on undefined (wraparound) behavior. The new code avoids undefined
759 behavior, and also checks for ptrdiff_t and/or size_t overflow.
760
761 * editfns.c (Finsert_char): Don't dump core with very negative counts.
762 Tune. Don't use wider integers than needed. Don't use alloca.
763 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
764
765 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
766
767 * insdel.c, lisp.h (buffer_overflow): New function.
768 (insert_from_buffer_1, replace_range, replace_range_2):
769 * insdel.c (make_gap_larger):
770 * editfns.c (Finsert_char):
771 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
772
773 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
774
775 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
776
777 Integer overflow and signedness fixes (Bug#8873).
778
779 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
780 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
781
782 * fileio.c: Don't assume EMACS_INT fits in off_t.
783 (emacs_lseek): New static function.
784 (Finsert_file_contents, Fwrite_region): Use it.
785 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
786
787 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
788
789 * fns.c: Don't overflow int when computing a list length.
790 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
791 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
792 truncation on 64-bit hosts. Check for QUIT every
793 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
794 faster and is responsive enough.
795 (Flength): Report an error instead of overflowing an integer.
796 (Fsafe_length): Return a float if the value is not representable
797 as a fixnum. This shouldn't happen except in contrived situations.
798 (Fnthcdr, Fsort): Don't assume list length fits in int.
799 (Fcopy_sequence): Don't assume vector length fits in int.
800
801 * alloc.c: Check that resized vectors' lengths fit in fixnums.
802 (header_size, word_size): New constants.
803 (allocate_vectorlike): Don't check size overflow here.
804 (allocate_vector): Check it here instead, since this is the only
805 caller of allocate_vectorlike that could cause overflow.
806 Check that the new vector's length is representable as a fixnum.
807
808 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
809 The previous code was bogus. For example, next_almost_prime (32)
810 returned 39, which is undesirable as it is a multiple of 3; and
811 next_almost_prime (24) returned 25, which is a multiple of 5 so
812 why was the code bothering to check for multiples of 7?
813
814 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
815
816 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
817
818 Variadic C functions now count arguments with ptrdiff_t.
819 This partly undoes my 2011-03-30 change, which replaced int with size_t.
820 Back then I didn't know that the Emacs coding style prefers signed int.
821 Also, in the meantime I found a few more instances where arguments
822 were being counted with int, which may truncate counts on 64-bit
823 machines, or EMACS_INT, which may be unnecessarily wide.
824 * lisp.h (struct Lisp_Subr.function.aMANY)
825 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
826 Arg counts are now ptrdiff_t, not size_t.
827 All variadic functions and their callers changed accordingly.
828 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
829 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
830 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
831 * callint.c (Fcall_interactively): Check arg count for overflow,
832 to avoid potential buffer overrun. Use signed char, not 'int',
833 for 'varies' array, so that we needn't bother to check its size
834 calculation for overflow.
835 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
836 * eval.c (apply_lambda):
837 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
838 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
839 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
840
841 * callint.c (Fcall_interactively): Don't use index var as event count.
842
843 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
844 * mem-limits.h (SIZE): Remove; no longer used.
845
846 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
847
848 Remove unnecessary casts.
849 * xterm.c (x_term_init):
850 * xfns.c (x_set_border_pixel):
851 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
852 These aren't needed now that we assume ANSI C.
853
854 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
855 It's more likely to cause problems (due to unsigned overflow)
856 than to cure them.
857
858 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
859
860 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
861
862 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
863
864 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
865
866 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
867
868 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
869
870 GLYPH_CODE_FACE returns EMACS_INT, not int.
871 * dispextern.h (merge_faces):
872 * xfaces.c (merge_faces):
873 * xdisp.c (get_next_display_element, next_element_from_display_vector):
874 Don't assume EMACS_INT fits in int.
875
876 * character.h (CHAR_VALID_P): Remove unused parameter.
877 * fontset.c, lisp.h, xdisp.c: All uses changed.
878
879 * editfns.c (Ftranslate_region_internal): Omit redundant test.
880
881 * fns.c (concat): Minor tuning based on overflow analysis.
882 This doesn't fix any bugs. Use int to hold character, instead
883 of constantly refetching from Emacs object. Use XFASTINT, not
884 XINT, for value known to be a character. Don't bother comparing
885 a single byte to 0400, as it's always less.
886
887 * floatfns.c (Fexpt):
888 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
889
890 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
891 for characters.
892
893 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
894
895 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
896 Without this fix, on a 64-bit host (aset S 0 4294967386) would
897 incorrectly succeed when S was a string, because 4294967386 was
898 truncated before it was used.
899
900 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
901 Otherwise, an out-of-range integer could cause undefined behavior
902 on a 64-bit host.
903
904 * composite.c: Use int, not EMACS_INT, for characters.
905 (fill_gstring_body, composition_compute_stop_pos): Use int, not
906 EMACS_INT, for values that are known to be in character range.
907 This doesn't fix any bugs but is the usual style inside Emacs and
908 may generate better code on 32-bit machines.
909
910 Make sure a 64-bit char is never passed to ENCODE_CHAR.
911 This is for reasons similar to the recent CHAR_STRING fix.
912 * charset.c (Fencode_char): Check that character arg is actually
913 a character. Pass an int to ENCODE_CHAR.
914 * charset.h (ENCODE_CHAR): Verify that the character argument is no
915 wider than 'int', as a compile-time check to prevent future regressions
916 in this area.
917
918 * character.c (char_string): Remove unnecessary casts.
919
920 Make sure a 64-bit char is never passed to CHAR_STRING.
921 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
922 by silently ignoring the top 32 bits, allowing some values
923 that were far too large to be valid characters.
924 * character.h: Include <verify.h>.
925 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
926 arguments are no wider than unsigned, as a compile-time check
927 to prevent future regressions in this area.
928 * data.c (Faset):
929 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
930 (Fsubst_char_in_region):
931 * fns.c (concat):
932 * xdisp.c (decode_mode_spec_coding):
933 Adjust to CHAR_STRING's new requirement.
934 * editfns.c (Finsert_char, Fsubst_char_in_region):
935 * fns.c (concat): Check that character args are actually
936 characters. Without this test, these functions did the wrong
937 thing with wildly out-of-range values on 64-bit hosts.
938
939 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
940 These casts should not be needed on 32-bit hosts, either.
941 * keyboard.c (read_char):
942 * lread.c (Fload): Remove casts to unsigned.
943
944 * lisp.h (UNSIGNED_CMP): New macro.
945 This fixes comparison bugs on 64-bit hosts.
946 (ASCII_CHAR_P): Use it.
947 * casefiddle.c (casify_object):
948 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
949 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
950 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
951 * dispextern.h (FACE_FROM_ID):
952 * keyboard.c (read_char): Use UNSIGNED_CMP.
953
954 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
955 not to EMACS_INT, to avoid GCC warning.
956
957 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
958
959 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
960 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
961 isn't needed on 32-bit machines.
962
963 * buffer.c (Fgenerate_new_buffer_name):
964 Use EMACS_INT for count, not int.
965 (advance_to_char_boundary): Return EMACS_INT, not int.
966
967 * data.c (Qcompiled_function): Now static.
968
969 * window.c (window_body_lines): Now static.
970
971 * image.c (gif_load): Rename local to avoid shadowing.
972
973 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
974 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
975 * alloc.c (make_save_value): Integer argument is now of type
976 ptrdiff_t, not int.
977 (mark_object): Use ptrdiff_t, not int.
978 * lisp.h (pD): New macro.
979 * print.c (print_object): Use it.
980
981 * alloc.c: Use EMACS_INT, not int, to count objects.
982 (total_conses, total_markers, total_symbols, total_vector_size)
983 (total_free_conses, total_free_markers, total_free_symbols)
984 (total_free_floats, total_floats, total_free_intervals)
985 (total_intervals, total_strings, total_free_strings):
986 Now EMACS_INT, not int. All uses changed.
987 (Fgarbage_collect): Compute overall total using a double, so that
988 integer overflow is less likely to be a problem. Check for overflow
989 when converting back to an integer.
990 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
991 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
992 These were 'int' variables that could overflow on 64-bit hosts;
993 they were never used, so remove them instead of repairing them.
994 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
995 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
996 Previously, this ceilinged at INT_MAX, but that doesn't work on
997 64-bit machines.
998 (allocate_pseudovector): Don't use EMACS_INT when int would do.
999
1000 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1001 (allocate_vectorlike): Check for ptrdiff_t overflow.
1002 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1003 when a (possibly-narrower) signed value would do just as well.
1004 We prefer using signed arithmetic, to avoid comparison confusion.
1005
1006 * alloc.c: Catch some string size overflows that we were missing.
1007 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1008 for convenience in STRING_BYTES_MAX.
1009 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1010 The definition here is exact; the one in lisp.h was approximate.
1011 (allocate_string_data): Check for string overflow. This catches
1012 some instances we weren't catching before. Also, it catches
1013 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1014 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1015 and ptrdiff_t and EMACS_INT are both 64 bits.
1016
1017 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1018 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1019 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1020
1021 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1022
1023 * alloc.c (Fmake_string): Check for out-of-range init.
1024
1025 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1026
1027 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1028
1029 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1030
1031 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1032 xg_get_default_scrollbar_width.
1033
1034 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1035 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1036 (style_changed_cb): Call update_theme_scrollbar_width and call
1037 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1038 all frames (Bug#8505).
1039 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1040 Call gtk_window_set_resizable if HAVE_GTK3.
1041 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1042 and height if HAVE_GTK3 (Bug#8505).
1043 (scroll_bar_width_for_theme): New variable.
1044 (update_theme_scrollbar_width): New function.
1045 (xg_get_default_scrollbar_width): Move code to
1046 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1047 (xg_initialize): Call update_theme_scrollbar_width.
1048
1049 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1050
1051 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1052
1053 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1054
1055 * frame.c (make_frame): Call other_buffer_safely instead of
1056 other_buffer.
1057
1058 * window.c (temp_output_buffer_show): Call display_buffer with
1059 second argument Vtemp_buffer_show_specifiers and reset latter
1060 immediately after the call.
1061 (Vtemp_buffer_show_specifiers): New variable.
1062 (auto_window_vscroll_p, next_screen_context_lines)
1063 (Vscroll_preserve_screen_position): Remove leading asterisks from
1064 doc-strings.
1065
1066 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1067
1068 Fix minor problems found by GCC 4.6.0 static checking.
1069 * buffer.c (Qclone_number): Remove for now, as it's unused.
1070 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1071 (record_buffer): Remove unused local.
1072 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1073 (set_frame_buffer_list): Remove; unused.
1074 * frame.h (other_visible_frames): Remove decl.
1075 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1076 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1077 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1078 if HAVE_GPM.
1079 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1080 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1081 Define only if HAVE_GPM.
1082 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1083 (update_hints_inhibit): Remove; never set. All uses removed.
1084 * widgetprv.h (emacsFrameClassRec): Remove decl.
1085 * window.c (delete_deletable_window): Now returns void, since it
1086 wasn't returning anything.
1087 (compare_window_configurations): Remove unused locals.
1088 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1089 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1090 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1091 the same widths as pointers. This follows up on the 2011-05-06 patch.
1092 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1093 * xterm.h: Likewise.
1094 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1095
1096 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1097
1098 * makefile.w32-in: Update dependencies.
1099 (LISP_H): Add lib/intprops.h.
1100
1101 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1102
1103 * image.c (gif_load): Add animation frame delay to the metadata.
1104 (syms_of_image): Use DEFSYM. New symbol `delay'.
1105
1106 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1107
1108 * window.c (delete_deletable_window): Re-add.
1109 (Fset_window_configuration): Rewrite to handle dead buffers and
1110 consequently deletable windows.
1111 (window_tree, Fwindow_tree): Remove. Supply functionality in
1112 window.el.
1113 (compare_window_configurations): Simplify code.
1114
1115 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1116
1117 * image.c (imagemagick_load_image): Fix type mismatch.
1118 (Fimagemagick_types): Likewise.
1119
1120 * window.h (replace_buffer_in_windows): Declare.
1121
1122 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1123
1124 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1125 Qclone_number. Remove external declaration of Qdelete_window.
1126 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1127 code.
1128 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1129 Qbuffer_list_update_hook if allowed.
1130 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1131 buffer list implementation.
1132 (other_buffer_safely): New function.
1133 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1134 calls to replace_buffer_in_windows and
1135 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1136 if allowed.
1137 (record_buffer): Inhibit quitting and rewrite using quittable
1138 functions. Run Qbuffer_list_update_hook if allowed.
1139 (Frecord_buffer, Funrecord_buffer): New functions.
1140 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1141 switch-to-buffer to window.el.
1142 (bury-buffer): Move to window.el.
1143 (Vbuffer_list_update_hook): New variable.
1144
1145 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1146 section.
1147
1148 * window.h (resize_frame_windows): Move up in code.
1149 (Fwindow_frame): Remove EXFUN.
1150 (replace_buffer_in_all_windows): Remove prototype.
1151 (replace_buffer_in_windows_safely): Add prototype.
1152
1153 * window.c: Declare Qdelete_window static again. Move down
1154 declaration of select_count.
1155 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1156 (Fother_window): Move to window.el.
1157 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1158 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1159 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1160 window.el.
1161 (replace_buffer_in_windows): Implement by calling
1162 Qreplace_buffer_in_windows.
1163 (replace_buffer_in_all_windows): Remove with some functionality
1164 moved into replace_buffer_in_windows_safely.
1165 (replace_buffer_in_windows_safely): New function.
1166 (select_window_norecord, select_frame_norecord): Move in front
1167 of run_window_configuration_change_hook. Remove now obsolete
1168 declarations.
1169 (Fset_window_buffer): Rewrite doc-string. Call
1170 Qrecord_window_buffer.
1171 (keys_of_window): Move binding for other-window to window.el.
1172
1173 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1174
1175 * dispextern.h (struct image): Replace data member, whose int_val
1176 and ptr_val fields were not used by anything, with a single
1177 lisp_val object.
1178
1179 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1180 (gif_clear_image, gif_load, imagemagick_load_image)
1181 (gs_clear_image, gs_load): Callers changed.
1182
1183 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * buffer.h: Include <time.h>, for time_t.
1186 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1187
1188 Fix minor problems found by static checking.
1189
1190 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1191
1192 Make identifiers static if they are not used in other modules.
1193 * data.c (Qcompiled_function, Qframe, Qvector):
1194 * image.c (QimageMagick, Qsvg):
1195 * minibuf.c (Qmetadata):
1196 * window.c (resize_window_check, resize_root_window): Now static.
1197 * window.h (resize_window_check, resize_root_window): Remove decls.
1198
1199 * window.c (window_deletion_count, delete_deletable_window):
1200 Remove; unused.
1201 (window_body_lines): Now static.
1202 (Fdelete_other_windows_internal): Mark vars as initialized.
1203 Make sure 'resize_failed' is initialized.
1204 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1205 (resize_window_apply): Remove unused local.
1206 * window.h (delete_deletable_window): Remove decl.
1207
1208 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1209 (imagemagick_load_image): Fix pointer signedness problem by changing
1210 last arg from unsigned char * to char *. All uses changed.
1211 Also, fix a local for similar reasons.
1212 Remove unused locals. Remove locals to avoid shadowing.
1213 (fn_rsvg_handle_free): Remove; unused.
1214 (svg_load, svg_load_image): Fix pointer signedness problem.
1215 (imagemagick_load_image): Don't use garbage pointer image_wand.
1216
1217 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1218
1219 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1220
1221 * image.c (gif_load): Fix omitted cast error introduced by
1222 2011-06-06 change.
1223
1224 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1225
1226 * window.h (resize_proportionally, orig_total_lines)
1227 (orig_top_line): Remove from window structure.
1228 (set_window_height, set_window_width, change_window_heights)
1229 (Fdelete_window): Remove prototypes.
1230 (resize_frame_windows): Remove duplicate declaration.
1231
1232 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1233
1234 * window.h (resize_frame_windows, resize_window_check)
1235 (delete_deletable_window, resize_root_window)
1236 (resize_frame_windows): Declare prototypes.
1237
1238 * window.c (resize_window_apply): Make definition be "static" to
1239 match the prototype.
1240
1241 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1242
1243 * window.c: Remove declarations of Qwindow_size_fixed,
1244 window_min_size_1, window_min_size_2, window_min_size,
1245 size_window, window_fixed_size_p, enlarge_window, delete_window.
1246 Remove static from declaration of Qdelete_window, it's
1247 temporarily needed by Fbury_buffer.
1248 (replace_window): Don't assign orig_top_line and
1249 orig_total_lines.
1250 (Fdelete_window, delete_window): Remove. Window deletion is
1251 handled by window.el.
1252 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1253 Fdelete_window calls with calls to Qdelete_window.
1254 (Fdelete_other_windows): Remove. Deleting other windows is
1255 handled by window.el.
1256 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1257 handled in window.el.
1258 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1259 Window minimum sizes are handled in window.el.
1260 (shrink_windows, size_window, set_window_height)
1261 (set_window_width, change_window_heights, window_height)
1262 (window_width, CURBEG, CURSIZE, enlarge_window)
1263 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1264 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1265 handled in window.el.
1266 (make_dummy_parent): Rename to make_parent_window and give it a
1267 second argument horflag.
1268 (make_window): Don't set resize_proportionally any more.
1269 (Fsplit_window): Remove. Windows are split in window.el.
1270 (save_restore_action, save_restore_orig_size)
1271 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1272 Resize mini windows in window.el.
1273 (grow_mini_window, shrink_mini_window): Implement by calling
1274 Qresize_root_window_vertically, resize_window_check and
1275 resize_window_apply.
1276 (saved_window, Fset_window_configuration, save_window_save): Do
1277 not handle orig_top_line, orig_total_lines, and
1278 resize_proportionally.
1279 (window_min_height, window_min_width): Move to window.el.
1280 (keys_of_window): Move bindings for delete-other-windows,
1281 split-window, delete-window and enlarge-window to window.el.
1282
1283 * buffer.c: Temporarily extern Qdelete_window.
1284 (Fbury_buffer): Temporarily call Qdelete_window instead of
1285 Fdelete_window (Fbury_buffer will move to window.el soon).
1286
1287 * frame.c (set_menu_bar_lines_1): Remove code handling
1288 orig_top_line and orig_total_lines.
1289
1290 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1291 set_window_height but set heights directly.
1292 (change_frame_size_1): Use resize_frame_windows.
1293
1294 * xdisp.c (init_xdisp): Don't use set_window_height but set
1295 heights directly.
1296
1297 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1298 resize_frame_windows instead of change_window_heights and run
1299 run_window_configuration_change_hook.
1300
1301 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1302 instead of change_window_heights and run
1303 run_window_configuration_change_hook.
1304
1305 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1306
1307 * window.c (replace_window): Rename second argument REPLACEMENT to
1308 NEW. New third argument SETFLAG. Rewrite.
1309 (delete_window, make_dummy_parent): Call replace_window with
1310 third argument 1.
1311 (window_list_1): Move down in code.
1312 (run_window_configuration_change_hook): Move set_buffer part
1313 before select_frame_norecord part in order to unwind correctly.
1314 Rename count1 to count.
1315 (recombine_windows, delete_deletable_window, resize_root_window)
1316 (Fdelete_other_windows_internal)
1317 (Frun_window_configuration_change_hook, make_parent_window)
1318 (resize_window_check, resize_window_apply, Fresize_window_apply)
1319 (resize_frame_windows, Fsplit_window_internal)
1320 (Fdelete_window_internal, Fresize_mini_window_internal): New
1321 functions.
1322 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1323
1324 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1325
1326 * window.h (window): Add some new members to window structure -
1327 normal_lines, normal_cols, new_total, new_normal, clone_number,
1328 splits, nest, prev_buffers, next_buffers.
1329 (WINDOW_TOTAL_SIZE): Move here from window.c.
1330 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1331
1332 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1333 Remove.
1334 (make_dummy_parent): Set new members of windows structure.
1335 (make_window): Move down in code. Handle new members of window
1336 structure.
1337 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1338 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1339 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1340 (Fset_window_prev_buffers, Fwindow_next_buffers)
1341 (Fset_window_next_buffers, Fset_window_clone_number): New
1342 functions.
1343 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1344 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1345 Doc-string fixes.
1346 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1347 Argument WINDOW can be now internal window too.
1348 (Fwindow_use_time): Move up in code.
1349 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1350 Rewrite doc-string.
1351 (Fset_window_configuration, saved_window)
1352 (Fcurrent_window_configuration, save_window_save): Handle new
1353 members of window structure.
1354 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1355 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1356 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1357 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1358 Qget_mru_window, Qresize_root_window,
1359 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1360 Qauto_buffer_name; staticpro them.
1361
1362 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1363
1364 * window.c (Fwindow_total_size, Fwindow_left_column)
1365 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1366 (Fwindow_list_1): New functions.
1367 (window_box_text_cols): Replace with window_body_cols.
1368 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1369 window_body_cols instead of window_box_text_cols.
1370 (delete_window, Fset_window_configuration): Call
1371 delete_all_subwindows with window as argument.
1372 (delete_all_subwindows): Take a window as argument and not a
1373 structure. Rewrite.
1374 (window_loop): Remove handling of GET_LRU_WINDOW and
1375 GET_LARGEST_WINDOW.
1376 (Fget_lru_window, Fget_largest_window): Move to window.el.
1377
1378 * window.h: Extern window_body_cols instead of
1379 window_box_text_cols. delete_all_subwindows now takes a
1380 Lisp_Object as argument.
1381
1382 * indent.c (compute_motion, Fcompute_motion): Use
1383 window_body_cols instead of window_box_text_cols.
1384
1385 * frame.c (delete_frame): Call delete_all_subwindows with root
1386 window as argument.
1387
1388 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1389
1390 * fns.c (Fputhash): Document return value.
1391
1392 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1393
1394 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1395
1396 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1397
1398 Cons<->int and similar integer overflow fixes (Bug#8794).
1399
1400 Check for overflow when converting integer to cons and back.
1401 * charset.c (Fdefine_charset_internal, Fdecode_char):
1402 Use cons_to_unsigned to catch overflow.
1403 (Fencode_char): Use INTEGER_TO_CONS.
1404 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1405 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1406 * data.c (long_to_cons, cons_to_long): Remove.
1407 (cons_to_unsigned, cons_to_signed): New functions.
1408 These signal an error for invalid or out-of-range values.
1409 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1410 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1411 * font.c (Ffont_variation_glyphs):
1412 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1413 * lisp.h: Include <intprops.h>.
1414 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1415 (cons_to_signed, cons_to_unsigned): New decls.
1416 (long_to_cons, cons_to_long): Remove decls.
1417 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1418 (Fprimitive_undo): Use CONS_TO_INTEGER.
1419 * xfns.c (Fx_window_property): Likewise.
1420 * xselect.c: Include <limits.h>.
1421 (x_own_selection, selection_data_to_lisp_data):
1422 Use INTEGER_TO_CONS.
1423 (x_handle_selection_request, x_handle_selection_clear)
1424 (x_get_foreign_selection, Fx_disown_selection_internal)
1425 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1426 (lisp_data_to_selection_data): Use cons_to_unsigned.
1427 (x_fill_property_data): Use cons_to_signed.
1428 Report values out of range.
1429
1430 Check for buffer and string overflow more precisely.
1431 * buffer.h (BUF_BYTES_MAX): New macro.
1432 * lisp.h (STRING_BYTES_MAX): New macro.
1433 * alloc.c (Fmake_string):
1434 * character.c (string_escape_byte8):
1435 * coding.c (coding_alloc_by_realloc):
1436 * doprnt.c (doprnt):
1437 * editfns.c (Fformat):
1438 * eval.c (verror):
1439 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1440 since they may not be the same number.
1441 * editfns.c (Finsert_char):
1442 * fileio.c (Finsert_file_contents):
1443 Likewise for BUF_BYTES_MAX.
1444
1445 * image.c: Use ptrdiff_t, not int, for sizes.
1446 (slurp_file): Switch from int to ptrdiff_t.
1447 All uses changed.
1448 (slurp_file): Check that file size fits in both size_t (for
1449 malloc) and ptrdiff_t (for sanity and safety).
1450
1451 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1452 if b->modtime has its maximal value.
1453
1454 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1455
1456 Don't assume time_t can fit into int.
1457 * buffer.h (struct buffer.modtime): Now time_t, not int.
1458 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1459 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1460
1461 Minor fixes for signed vs unsigned integers.
1462 * character.h (MAYBE_UNIFY_CHAR):
1463 * charset.c (maybe_unify_char):
1464 * keyboard.c (read_char, reorder_modifiers):
1465 XINT -> XFASTINT, since the integer must be nonnegative.
1466 * ftfont.c (ftfont_spec_pattern):
1467 * keymap.c (access_keymap, silly_event_symbol_error):
1468 XUINT -> XFASTINT, since the integer must be nonnegative.
1469 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1470 since it makes no difference and we prefer signed.
1471 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1472 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1473 nonnegative.
1474
1475 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1476
1477 * window.h (Fwindow_frame): Declare.
1478
1479 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1480
1481 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1482 (SPARE_MEMORY): Always define.
1483 (LARGE_REQUEST): Remove.
1484 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1485
1486 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1487
1488 * lisp.h: Move EXFUNS for Fframe_root_window,
1489 Fframe_first_window and Fset_frame_selected_window to window.h.
1490
1491 * window.h: Move EXFUNS for Fframe_root_window,
1492 Fframe_first_window and Fset_frame_selected_window here from
1493 lisp.h.
1494
1495 * frame.c (Fwindow_frame, Fframe_first_window)
1496 (Fframe_root_window, Fframe_selected_window)
1497 (Fset_frame_selected_window): Move to window.c.
1498 (Factive_minibuffer_window): Move to minibuf.c.
1499 (Fother_visible_frames_p): New function.
1500
1501 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1502
1503 * window.c (decode_window, decode_any_window): Move up in code.
1504 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1505 (inhibit_frame_unsplittable): Remove unused variable.
1506 (Fwindow_buffer): Move up and rewrite doc-string.
1507 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1508 (Fwindow_prev): New functions.
1509 (Fwindow_frame): Move here from frame.c. Accept any window as
1510 argument.
1511 (Fframe_root_window, Fframe_first_window)
1512 (Fframe_selected_window): Move here from frame.c. Accept frame
1513 or arbitrary window as argument. Update doc-strings.
1514 (Fminibuffer_window): Move up in code.
1515 (Fwindow_minibuffer_p): Move up in code and simplify.
1516 (Fset_frame_selected_window): Move here from frame.c.
1517 Marginal rewrite.
1518 (Fselected_window, select_window, Fselect_window): Move up in
1519 code. Minor doc-string fixes.
1520
1521 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1522
1523 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1524 Do not assume that spare memory exists; that assumption is valid
1525 only if SYSTEM_MALLOC.
1526 (LARGE_REQUEST): New macro, so that the issue of large requests
1527 is separated from the issue of spare memory.
1528
1529 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1530
1531 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1532 format. (Bug#8806)
1533
1534 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1535
1536 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1537 before statements.
1538
1539 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1540
1541 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1542
1543 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1544
1545 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1546 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1547
1548 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1549
1550 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1551
1552 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1553
1554 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1555 (x_clipboard_manager_save): Add return value.
1556 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1557 New error handlers.
1558 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1559 Obey Vx_select_enable_clipboard_manager. Catch errors in
1560 x_clipboard_manager_save (Bug#8779).
1561 (Vx_select_enable_clipboard_manager): New variable.
1562 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1563
1564 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1565
1566 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1567
1568 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1569
1570 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1571 in the current matrix if keep_current_p is non-zero.
1572
1573 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1574
1575 * bidi.c (bidi_level_of_next_char): Fix last change.
1576
1577 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1578
1579 Support bidi reordering of text covered by display properties.
1580
1581 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1582 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1583 (bidi_cache_search, bidi_cache_iterator_state)
1584 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1585 (bidi_level_of_next_char, bidi_move_to_visually_next):
1586 Support character positions inside a run of characters covered by a
1587 display string.
1588 (bidi_paragraph_init, bidi_resolve_explicit_1)
1589 (bidi_level_of_next_char): Call bidi_fetch_char and
1590 bidi_fetch_char_advance instead of FETCH_CHAR and
1591 FETCH_CHAR_ADVANCE.
1592 (bidi_init_it): Initialize new members.
1593 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1594 definitions.
1595 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1596 instead of using explicit *_CHAR codes.
1597 (bidi_resolve_explicit, bidi_resolve_weak):
1598 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1599 bidirectional text is supported only in multibyte buffers.
1600 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1601 it to initialize the frame_window_p member of struct bidi_it.
1602 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1603 (bidi_resolve_explicit, bidi_resolve_weak)
1604 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1605 bidi_it->nchars is non-positive.
1606 (bidi_level_of_next_char): Don't try to lookup the cache for the
1607 next/previous character if nothing is cached there yet, or if we
1608 were just reseat()'ed to a new position.
1609
1610 * xdisp.c (set_cursor_from_row): Set start and stop points
1611 according to the row's direction when priming the loop that looks
1612 for the glyph on which to display cursor.
1613 (single_display_spec_intangible_p): Function deleted.
1614 (display_prop_intangible_p): Reimplement to call
1615 handle_display_spec instead of single_display_spec_intangible_p.
1616 Accept 3 additional arguments needed by handle_display_spec.
1617 This fixes incorrect cursor motion across display property with complex
1618 values: lists, `(when COND...)' forms, etc.
1619 (single_display_spec_string_p): Support property values that are
1620 lists with the argument STRING its top-level element.
1621 (display_prop_string_p): Fix the condition for processing a
1622 property that is a list to be consistent with handle_display_spec.
1623 (handle_display_spec): New function, refactored from the
1624 last portion of handle_display_prop.
1625 (compute_display_string_pos): Accept additional argument
1626 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1627 value of a `display' property is a "replacing spec".
1628 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1629 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1630 the display property, but just return a value indicating whether
1631 the display property will replace the characters it covers.
1632 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1633 frame_window_p members of struct bidi_it.
1634 (compute_display_string_pos, compute_display_string_end):
1635 New functions.
1636 (push_it): Accept second argument POSITION, where pop_it should
1637 jump to continue iteration.
1638 (reseat_1): Initialize bidi_it.disp_pos.
1639
1640 * keyboard.c (adjust_point_for_property): Adjust the call to
1641 display_prop_intangible_p to its new signature.
1642
1643 * dispextern.h (struct bidi_it): New member frame_window_p.
1644 (bidi_init_it): Update prototypes.
1645 (display_prop_intangible_p): Update prototype.
1646 (compute_display_string_pos, compute_display_string_end):
1647 Declare prototypes.
1648 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1649 EMACS_INT.
1650
1651 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1652
1653 Malloc failure behavior now depends on size of allocation.
1654 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1655 * lisp.h: Change signatures accordingly.
1656 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1657 All callers changed. (Bug#8762)
1658
1659 * gnutls.c: Use Emacs's memory allocators.
1660 Without this change, the gnutls library would invoke malloc etc.
1661 directly, which causes problems on non-SYNC_INPUT hosts, and which
1662 runs afoul of improving memory_full behavior. (Bug#8761)
1663 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1664 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1665 xfree instead of the default malloc, realloc, free.
1666 (Fgnutls_boot): No need to check for memory allocation failure,
1667 since xmalloc does that for us.
1668
1669 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1670 * category.c (hash_get_category_set):
1671 * ccl.c (ccl_driver):
1672 * charset.c (Fdefine_charset_internal):
1673 * charset.h (struct charset.hash_index):
1674 * composite.c (get_composition_id, gstring_lookup_cache)
1675 (composition_gstring_put_cache):
1676 * composite.h (struct composition.hash_index):
1677 * dispextern.h (struct image.hash):
1678 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1679 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1680 (hashfn_equal, hashfn_user_defined, make_hash_table)
1681 (maybe_resize_hash_table, hash_lookup, hash_put)
1682 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1683 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1684 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1685 * image.c (make_image, search_image_cache, lookup_image)
1686 (xpm_put_color_table_h):
1687 * lisp.h (struct Lisp_Hash_Table):
1688 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1689 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1690 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1691 * alloc.c (allocate_vectorlike):
1692 Check for overflow in vector size calculations.
1693 * ccl.c (ccl_driver):
1694 Check for overflow when converting EMACS_INT to int.
1695 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1696 need to be updated by these changes.
1697 * fns.c (make_hash_table, maybe_resize_hash_table):
1698 Check for integer overflow with large hash tables.
1699 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1700 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1701 (SXHASH_REDUCE): New macro.
1702 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1703 Use it instead of discarding useful hash info with large hash values.
1704 (sxhash_float): New function.
1705 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1706 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1707 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1708 Rewrite to use FIXNUM_BITS, as this simplifies things.
1709 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1710 Adjust signatures to match updated version of code.
1711 (consing_since_gc): Now EMACS_INT, since a single hash table can
1712 use more than INT_MAX bytes.
1713
1714 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1715
1716 Make it possible to build with GCC-4.6+ -O2 -flto.
1717
1718 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1719
1720 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1721
1722 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1723 Call minibuffer-inactive-mode.
1724
1725 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1726
1727 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1728 Update dependencies.
1729
1730 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1731
1732 * data.c (init_data): Remove code for UTS, this system is not
1733 supported anymore.
1734
1735 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1736
1737 Don't force ./temacs to start in terminal mode.
1738
1739 * frame.c (make_initial_frame): Initialize faces in all cases, not
1740 only when CANNOT_DUMP is defined.
1741 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1742
1743 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1744
1745 * dispnew.c (add_window_display_history): Use const for the string
1746 pointer. Remove declaration, not needed.
1747
1748 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1749
1750 Use 'inline', not 'INLINE'.
1751 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1752 * alloc.c, fontset.c (INLINE): Remove.
1753 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1754 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1755 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1756 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1757 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1758
1759 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1760
1761 Make it possible to run ./temacs.
1762
1763 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1764 syms_of_callproc does the same thing. Remove test for
1765 "initialized", do it in the caller.
1766 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1767
1768 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1769
1770 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1771 (read_minibuf): Use get_minibuffer.
1772 (syms_of_minibuf): Use DEFSYM.
1773 (Qmetadata): New var.
1774 * data.c (Qbuffer): Don't make it static.
1775 (syms_of_data): Use DEFSYM.
1776
1777 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1778
1779 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1780 (CCL_CODE_MIN): New macro.
1781
1782 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1783
1784 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1785
1786 * eval.c (Qdebug): Now static.
1787 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1788 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1789 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1790
1791 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1792
1793 * image.c: Various fixes to ImageMagick code comments.
1794 (Fimagemagick_types): Doc fix.
1795
1796 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 Minor fixes prompted by GCC 4.6.0 warnings.
1799
1800 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1801
1802 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1803 (x_clipboard_manager_save_all): Move extern decl to ...
1804 * xterm.h: ... here, so that it can be checked for consistency.
1805
1806 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1807
1808 * xselect.c (x_clipboard_manager_save_frame)
1809 (x_clipboard_manager_save_all): New functions.
1810 (Fx_clipboard_manager_save): Lisp function deleted.
1811
1812 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1813 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1814
1815 * xterm.h: Update prototype.
1816
1817 2011-05-28 William Xu <william.xwl@gmail.com>
1818
1819 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1820 exiting (Bug#8239).
1821
1822 2011-05-28 Jim Meyering <meyering@redhat.com>
1823
1824 Avoid a sign-extension bug in crypto_hash_function.
1825 * fns.c (to_uchar): Define.
1826 (crypto_hash_function): Use it to convert some newly-signed
1827 variables to unsigned, to avoid sign-extension bugs. For example,
1828 without this change, (md5 "truc") would evaluate to
1829 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1830 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1831 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1832
1833 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1834
1835 Integer overflow fixes.
1836
1837 * dbusbind.c: Serial number integer overflow fixes.
1838 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1839 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1840 to hold a serial number that is too large for a fixnum.
1841 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1842 Check for serial numbers out of range. Decode any serial number
1843 that was so large that it became a float. (Bug#8722)
1844
1845 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1846 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1847 Use XFASTINT rather than XUINT when numbers are nonnegative.
1848 (xd_append_arg, Fdbus_method_return_internal):
1849 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1850 arguments, check that Lisp number is nonnegative, rather than
1851 silently wrapping negative numbers around. (Bug#8722)
1852 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1853 (Bug#8722)
1854
1855 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1856
1857 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1858
1859 ccl: add integer overflow checks
1860 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1861 (IN_INT_RANGE): New macros.
1862 (ccl_driver): Use them to check for integer overflow when
1863 decoding a CCL program. Many of the new checks are whether XINT (x)
1864 fits in int; it doesn't always, on 64-bit hosts. The new version
1865 doesn't catch all possible integer overflows, but it's an
1866 improvement. (Bug#8719)
1867
1868 * alloc.c (make_event_array): Use XINT, not XUINT.
1869 There's no need for unsigned here.
1870
1871 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1872 This follows up to the 2011-05-06 change that substituted uintptr_t
1873 for EMACS_INT. This case wasn't caught back then.
1874
1875 Rework Fformat to avoid integer overflow issues.
1876 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1877 now (part of C89). Include <verify.h>.
1878 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1879 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1880 (Fformat): Avoid the prepass trying to compute sizes; it was only
1881 approximate and thus did not catch overflow reliably. Instead, walk
1882 through the format just once, formatting and computing sizes as we go,
1883 checking for integer overflow at every step, and allocating a larger
1884 buffer as needed. Keep track separately whether the format is
1885 multibyte. Keep only the most-recently calculated precision, rather
1886 than them all. Record whether each argument has been converted to
1887 string. Use EMACS_INT, not int, for byte and char and arg counts.
1888 Support field widths and precisions larger than INT_MAX. Avoid
1889 sprintf's undefined behavior with conversion specifications such as %#d
1890 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1891 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1892 formatting out-of-range floating point numbers with int
1893 formats. (Bug#8668)
1894
1895 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1896
1897 * data.c: Avoid integer truncation in expressions involving floats.
1898 * data.c: Include <intprops.h>.
1899 (arith_driver): When there's an integer overflow in an expression
1900 involving floating point, convert the integers to floating point
1901 so that the resulting value does not suffer from catastrophic
1902 integer truncation. For example, on a 64-bit host (* 4
1903 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1904 Do not rely on undefined behavior after integer overflow.
1905
1906 merge count_size_as_multibyte, parse_str_to_multibyte
1907 * character.c, character.h (count_size_as_multibyte):
1908 Rename from parse_str_to_multibyte; all uses changed.
1909 Check for integer overflow.
1910 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1911 since it's now a duplicate of the other. This is more of
1912 a character than a buffer op, so better that it's in character.c.
1913 * fns.c, print.c: Adjust to above changes.
1914
1915 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1916
1917 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1918
1919 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1922 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1923 (x_clipboard_manager_save): Now static.
1924 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1925
1926 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1927 (crypto_hash_function): Now static.
1928 Fix pointer signedness problems. Avoid unnecessary initializations.
1929
1930 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1931
1932 * termhooks.h (Vselection_alist): Make it terminal-local.
1933
1934 * terminal.c (create_terminal): Initialize it.
1935
1936 * xselect.c: Support for clipboard managers.
1937 (Vselection_alist): Move to termhooks.h as terminal-local var.
1938 (LOCAL_SELECTION): New macro.
1939 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1940 (symbol_to_x_atom): Remove gratuitous arg.
1941 (x_handle_selection_request, lisp_data_to_selection_data)
1942 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1943 (x_own_selection, x_get_local_selection, x_convert_selection):
1944 New arg, specifying work frame. Use terminal-local Vselection_alist.
1945 (some_frame_on_display): Delete unused function.
1946 (Fx_own_selection_internal, Fx_get_selection_internal)
1947 (Fx_disown_selection_internal, Fx_selection_owner_p)
1948 (Fx_selection_exists_p): New optional frame arg.
1949 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1950 (x_handle_selection_clear): Don't treat other terminals with the
1951 same keyboard specially. Use the terminal-local Vselection_alist.
1952 (x_clear_frame_selections): Use Frun_hook_with_args.
1953
1954 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1955
1956 * xterm.h: Add support for those atoms.
1957
1958 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1959
1960 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1961 (converted_selections, conversion_fail_tag): New global variables.
1962 (x_selection_request_lisp_error): Free the above.
1963 (x_get_local_selection): Remove unnecessary code.
1964 (x_reply_selection_request): Args changed; handle arbitrary array
1965 of converted selections stored in converted_selections.
1966 Separate the XChangeProperty and SelectionNotify steps.
1967 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1968 (x_convert_selection): New function.
1969 (x_handle_selection_event): Simplify.
1970 (x_get_foreign_selection): Don't ignore incoming requests while
1971 waiting for an answer; this will fail when we implement
1972 SAVE_TARGETS, and seems unnecessary anyway.
1973 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1974 (Vx_sent_selection_functions): Doc fix.
1975
1976 2011-05-26 Leo Liu <sdl.web@gmail.com>
1977
1978 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1979
1980 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1981
1982 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1983
1984 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1985 for fringe update if it has periodic bitmap.
1986 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1987 and fringe_bitmap_periodic_p.
1988
1989 * fringe.c (get_fringe_bitmap_data): New function.
1990 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1991 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1992 row. Mark glyph row for fringe update if periodicity changed.
1993
1994 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1995 for fringe update unless it has periodic bitmap.
1996
1997 2011-05-25 Kenichi Handa <handa@m17n.org>
1998
1999 * xdisp.c (get_next_display_element): Set correct it->face_id for
2000 a static composition.
2001
2002 2011-05-24 Leo Liu <sdl.web@gmail.com>
2003
2004 * deps.mk (fns.o):
2005 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2006
2007 * fns.c (crypto_hash_function, Fsha1): New function.
2008 (Fmd5): Use crypto_hash_function.
2009 (syms_of_fns): Add Ssha1.
2010
2011 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2012
2013 * gnutls.c: Remove unused macros.
2014 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2015 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2016 Remove macros that are defined and never used.
2017 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2018
2019 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2020
2021 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2022 (Fx_get_selection_internal): Minor cleanup.
2023 (Fx_own_selection_internal): Rename arguments for consistency with
2024 select.el.
2025
2026 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2027
2028 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2029
2030 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2031
2032 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2033
2034 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2035
2036 * dispnew.c (scrolling_window): Don't exclude the case that the
2037 last enabled row in the desired matrix touches the bottom boundary.
2038
2039 2011-05-21 Glenn Morris <rgm@gnu.org>
2040
2041 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2042 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2043 and add some more files.
2044
2045 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2046
2047 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2048 report_file_error introduced by the change from 2011-05-07.
2049
2050 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2051
2052 * systime.h (Time): Define only if emacs is defined.
2053 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2054 where the include path doesn't have X11/X.h by default. See
2055 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2056
2057 2011-05-20 Kenichi Handa <handa@m17n.org>
2058
2059 * composite.c (find_automatic_composition): Fix previous change.
2060
2061 2011-05-20 Glenn Morris <rgm@gnu.org>
2062
2063 * lisp.mk: New file, split from Makefile.in.
2064 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2065 (shortlisp): Remove.
2066 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2067
2068 2011-05-19 Glenn Morris <rgm@gnu.org>
2069
2070 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2071 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2072 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2073 (lisp): Set the order to that of loadup.el.
2074 (shortlisp): Make it a copy of $lisp.
2075 (SOME_MACHINE_LISP): Remove.
2076 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2077 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2078
2079 2011-05-18 Kenichi Handa <handa@m17n.org>
2080
2081 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2082 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2083 (find_automatic_composition): Mostly rewrite for efficiency.
2084
2085 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2086
2087 * makefile.w32-in: Update dependencies.
2088
2089 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2090
2091 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2092 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2093
2094 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2095
2096 Fix some integer overflow issues, such as string length overflow.
2097
2098 * insdel.c (count_size_as_multibyte): Check for string overflow.
2099
2100 * character.c (lisp_string_width): Check for string overflow.
2101 Use EMACS_INT, not int, for string indexes and lengths; in
2102 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2103 the resulting string length overflows an EMACS_INT; instead,
2104 report a string overflow if no precision given. When checking for
2105 precision exhaustion, use a check that cannot possibly have
2106 integer overflow. (Bug#8675)
2107 * character.h (lisp_string_width): Adjust to new signature.
2108
2109 * alloc.c (string_overflow): New function.
2110 (Fmake_string): Use it. This doesn't change behavior, but saves
2111 a few bytes and will simplify future changes.
2112 * character.c (string_escape_byte8): Likewise.
2113 * lisp.h (string_overflow): New decl.
2114
2115 Fixups, following up to the user-interface timestamp change.
2116 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2117 for UI timestamps, instead of unsigned long.
2118 * msdos.c (mouse_get_pos): Likewise.
2119 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2120 * w32gui.h (Time): Define by including "systime.h" rather than by
2121 declaring it ourselves. (Bug#8664)
2122
2123 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2124 * image.c (clear_image_cache): Likewise.
2125
2126 * term.c (term_mouse_position): Don't assume time_t wraparound.
2127
2128 Be more systematic about user-interface timestamps.
2129 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2130 and sometimes 'EMACS_UINT', to represent these timestamps.
2131 This change causes it to use 'Time' uniformly, as that's what X uses.
2132 This makes the code easier to follow, and makes it easier to catch
2133 integer overflow bugs such as Bug#8664.
2134 * frame.c (Fmouse_position, Fmouse_pixel_position):
2135 Use Time, not unsigned long, for user-interface timestamps.
2136 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2137 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2138 * keyboard.h (last_event_timestamp): Likewise.
2139 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2140 * menu.h (xmenu_show): Likewise.
2141 * term.c (term_mouse_position): Likewise.
2142 * termhooks.h (struct input_event.timestamp): Likewise.
2143 (struct terminal.mouse_position_hook): Likewise.
2144 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2145 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2146 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2147 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2148 what it was before.
2149 * menu.h, termhooks.h: Include "systime.h", for Time.
2150
2151 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2152 Don't assume that the difference between two unsigned long values
2153 can fit into an integer. At this point, we know button_down_time
2154 <= event->timestamp, so the difference must be nonnegative, so
2155 there's no need to cast the result if double-click-time is
2156 nonnegative, as it should be; check that it's nonnegative, just in
2157 case. This bug is triggered when events are more than 2**31 ms
2158 apart (about 25 days). (Bug#8664)
2159
2160 * xselect.c (last_event_timestamp): Remove duplicate decl.
2161 (x_own_selection): Remove needless cast to unsigned long.
2162
2163 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2164 that always fit in int. Use a sentinel instead of a counter, to
2165 avoid a temp and to allay GCC's concerns about possible int overflow.
2166 * frame.h (struct frame): Use int for menu_bar_items_used
2167 instead of EMACS_INT, since it always fits in int.
2168
2169 * menu.c (grow_menu_items): Check for int overflow.
2170
2171 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2172
2173 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2174 Before, the code was not consistent. These values cannot exceed
2175 2**31 - 1 so there's no need to make them unsigned.
2176 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2177 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2178 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2179 as modifiers.
2180 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2181
2182 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2183 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2184 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2185 presumably because the widths might not match.
2186
2187 * window.c (size_window): Avoid needless test at loop start.
2188
2189 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2190
2191 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2192
2193 2011-05-12 Drew Adams <drew.adams@oracle.com>
2194
2195 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2196
2197 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2198
2199 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2200 `width' to `bar_area_x' and `bar_area_width', respectively.
2201 (x_scroll_run): Take account of fringe background extension.
2202
2203 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2204 Rename local vars `left' and `width' to `bar_area_x' and
2205 `bar_area_width', respectively.
2206 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2207 background extension.
2208
2209 2011-05-10 Jim Meyering <meyering@redhat.com>
2210
2211 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2212
2213 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2214
2215 * image.c (Finit_image_library): Return t for built-in image types,
2216 like pbm and xbm. (Bug#8640)
2217
2218 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2219
2220 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2221
2222 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2223
2224 * w32console.c (Fset_screen_color): Doc fix.
2225 (Fget_screen_color): New function.
2226 (syms_of_ntterm): Defsubr it.
2227
2228 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2229 unlink the temporary file if Fcall_process didn't create it in the
2230 first place.
2231 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2232 child process will be redirected to a file specified with `:file'.
2233 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2234 cue to call_process_cleanup not to close that handle.
2235
2236 2011-05-07 Ben Key <bkey76@gmail.com>
2237
2238 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2239 one of two shell specific rules, either bootstrap-temacs-CMD or
2240 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2241 to the previous implementation of the bootstrap-temacs rule.
2242 The bootstrap-temacs-CMD rule is similar to the previous
2243 implementation of the bootstrap-temacs rule except that it
2244 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2245 variable.
2246
2247 These changes, along with some changes to nt/configure.bat,
2248 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2249 earlier fix to add support for --cflags and --ldflags options
2250 that include quotes so that it works whether make uses cmd or
2251 sh as the shell.
2252
2253 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2254
2255 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2256 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2257 is a constant.
2258 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2259 a string. Handle both cases.
2260 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2261 (Fdbus_register_method): Use Qinvalid_function.
2262
2263 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2264
2265 * makefile.w32-in: Update dependencies.
2266 (LISP_H): Add inttypes.h and stdin.h.
2267 (PROCESS_H): Add unistd.h.
2268
2269 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2270
2271 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2272 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2273
2274 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2275
2276 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2277
2278 * term.c (vfatal): Remove stray call to va_end.
2279 It's not needed and the C Standard doesn't allow it here anyway.
2280
2281 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2282 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2283
2284 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2285 bytes.
2286
2287 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2288
2289 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2290
2291 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2292
2293 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2294
2295 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2296
2297 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2298 * charset.c (Fdefine_charset_internal): Don't initialize
2299 charset.code_space[15]. The value was garbage, on hosts with
2300 32-bit int (Bug#8600).
2301
2302 * lread.c (read_integer): Be more consistent with string-to-number.
2303 Use string_to_number to do the actual conversion; this avoids
2304 rounding errors and fixes some other screwups. Without this fix,
2305 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2306 (digit_to_number): Move earlier, for benefit of read_integer.
2307 Return -1 if the digit is out of range for the base, -2 if it is
2308 not a digit in any supported base. (Bug#8602)
2309
2310 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2311
2312 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2313 to match comment at start of function. This also removes a
2314 GCC warning about overflow in a 32+64-bit port.
2315
2316 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2317
2318 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2319 Reported by Stefan Monnier in
2320 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2321 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2322 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2323
2324 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2325 (EMACS_UINTPTR): Likewise, with uintptr_t.
2326
2327 * lisp.h: Prefer 64-bit EMACS_INT if available.
2328 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2329 on 32-bit hosts that have 64-bit int, so that they can access
2330 large files.
2331 However, temporarily disable this change unless the temporary
2332 symbol WIDE_EMACS_INT is defined.
2333
2334 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2335
2336 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2337 This removes an assumption that EMACS_INT and long are the same
2338 width as pointers. The assumption is true for Emacs porting targets
2339 now, but we want to make other targets possible.
2340 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2341 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2342 In the rest of the code, change types of integers that hold casted
2343 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2344 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2345 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2346 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2347 No need to cast type when ORing.
2348 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2349 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2350 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2351 assume EMACS_INT is the same width as char *.
2352 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2353 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2354 Remove no-longer-needed casts.
2355 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2356 (xg_tool_bar_help_callback, xg_make_tool_item):
2357 Use EMACS_INTPTR to hold an integer
2358 that will be cast to void *; this can avoid a GCC warning
2359 if EMACS_INT is not the same width as void *.
2360 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2361 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2362 (current_message_1, set_message_1):
2363 Use a local to convert to proper width without a cast.
2364 * xmenu.c (dialog_selection_callback): Likewise.
2365
2366 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2367 Also, don't assume VALBITS / RAND_BITS is less than 5,
2368 and don't rely on undefined behavior when shifting a 1 left into
2369 the sign bit.
2370 * lisp.h (get_random): Change signature to match.
2371
2372 * lread.c (hash_string): Use size_t, not int, for hash computation.
2373 Normally we prefer signed values; but hashing is special, because
2374 it's better to use unsigned division on hash table sizes so that
2375 the remainder is nonnegative. Also, size_t is the natural width
2376 for hashing into memory. The previous code used 'int', which doesn't
2377 retain enough info to hash well into very large tables.
2378 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2379
2380 * dbusbind.c: Don't possibly lose pointer info when converting.
2381 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2382 Use XPNTR rather than XHASH, so that the high-order bits of
2383 the pointer aren't lost when converting through void *.
2384
2385 * eval.c (Fautoload): Don't double-shift a pointer.
2386
2387 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2388
2389 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2390
2391 * gnutls.c (DEF_GNUTLS_FN):
2392 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2393
2394 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2395
2396 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2397 marker. (Bug#8610)
2398
2399 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2400
2401 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2402 New version that can reserve upto 2GB of heap space.
2403
2404 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2405
2406 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2407
2408 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2409
2410 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2411 `gnutls_certificate_set_x509_key_file'.
2412
2413 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2414
2415 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2416 Update dependencies.
2417
2418 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2419
2420 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2421 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2422 Remove unused parameter `fildes'.
2423 * process.c (read_process_output, send_process): Don't pass it.
2424
2425 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2426
2427 Fix previous change: the library cache is defined in w32.c.
2428 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2429 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2430
2431 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2432
2433 Implement dynamic loading of GnuTLS on Windows.
2434
2435 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2436 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2437 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2438 Declare.
2439
2440 * gnutls.c (Qgnutls_dll): Define.
2441 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2442 (gnutls_*): Declare function pointers.
2443 (init_gnutls_functions): New function to initialize function pointers.
2444 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2445 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2446 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2447 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2448 (emacs_gnutls_write, emacs_gnutls_read)
2449 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2450 (Fgnutls_available_p): New function.
2451 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2452 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2453 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2454
2455 * image.c: Include w32.h.
2456 (Vimage_type_cache): Delete.
2457 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2458 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2459 (w32_delayed_load): Move to w32.c.
2460
2461 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2462
2463 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2464 (w32_delayed_load): Move from image.c. When loading a library, record
2465 its filename in the :loaded-from property of the library id.
2466 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2467 Initialize and staticpro them.
2468 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2469
2470 * process.c: Include lisp.h before w32.h, not after.
2471 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2472 instead of gnutls_record_check_pending.
2473
2474 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2475
2476 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2477
2478 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2479 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2480 as passed in.
2481
2482 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2483
2484 * xterm.c (x_set_frame_alpha): Do not set property on anything
2485 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2486
2487 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2488
2489 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2490
2491 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2492
2493 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2494 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2495 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2496 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2497 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2498 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2499 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2500 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2501 (Qgnutls_bootprop_callbacks_verify): Make static.
2502
2503 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2504
2505 * callproc.c: Indentation fixup.
2506
2507 * sysdep.c (wait_for_termination_1): Make static.
2508 (wait_for_termination, interruptible_wait_for_termination):
2509 Move after wait_for_termination_1.
2510
2511 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2512
2513 * sysdep.c (interruptible_wait_for_termination): New function
2514 which is like wait_for_termination, but allows keyboard
2515 interruptions.
2516
2517 * callproc.c (Fcall_process): Add (:file "file") as an option for
2518 the STDOUT buffer.
2519 (Fcall_process_region): Ditto.
2520
2521 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2522
2523 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2524 rather than `XVECTOR (FOO)->size'.
2525
2526 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2527 inttypes.h, as a gnulib replacement is used if it not available in
2528 system headers.
2529
2530 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2531
2532 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2533 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2534 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2535
2536 * coding.c (coding_alloc_by_realloc): Error out if destination
2537 will grow beyond MOST_POSITIVE_FIXNUM.
2538 (decode_coding_emacs_mule): Abort if there isn't enough place in
2539 charbuf for the composition carryover bytes. Reserve an extra
2540 space for up to 2 characters produced in a loop.
2541 (decode_coding_iso_2022): Abort if there isn't enough place in
2542 charbuf for the composition carryover bytes.
2543
2544 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2545
2546 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2547 aborting when %lld or %lll format is passed.
2548 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2549 %llo or %llx format is passed. (Bug#8545)
2550
2551 * window.c (window_scroll_line_based): Use a marker instead of
2552 simple variables to record original value of point. (Bug#7952)
2553
2554 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2555 produced by %s or %c overflows available buffer space. (Bug#8545)
2556
2557 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2558
2559 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2560 (SIZE_MAX): Move defn after all includes, as they might #define it.
2561
2562 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2563
2564 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2565
2566 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2567
2568 * keyboard.c (Qdelayed_warnings_hook): Define.
2569 (command_loop_1): Run `delayed-warnings-hook'
2570 if Vdelayed_warnings_list is non-nil.
2571 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2572 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2573
2574 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2575
2576 * doprnt.c (doprnt): Don't return value smaller than the buffer
2577 size if the message was truncated. (Bug#8545).
2578
2579 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2580
2581 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2582 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2583
2584 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2585
2586 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2587
2588 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2589
2590 * makefile.w32-in: Update dependencies.
2591
2592 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2593
2594 Improve `doprnt' and its usage. (Bug#8545)
2595 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2596 `format_end'. Remove support for %l as a conversion specifier.
2597 Don't use xrealloc. Improve diagnostics when the %l size modifier
2598 is used. Update the commentary.
2599
2600 * eval.c (verror): Simplify calculation of size_t.
2601
2602 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2603 messages.
2604
2605 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2606
2607 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2608 change.
2609
2610 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2611
2612 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2613 This makes this file independent of the recent pseudovector change.
2614
2615 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2616
2617 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2618
2619 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2620 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2621 Remove unused local.
2622 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2623
2624 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2625 GCC 4.6.0 optimizes based on type-based alias analysis.
2626 For example, if b is of type struct buffer * and v of type struct
2627 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2628 != &v->size, and therefore "v->size = 1; b->size = 2; return
2629 v->size;" must therefore return 1. This assumption is incorrect
2630 for Emacs, since it type-puns struct Lisp_Vector * with many other
2631 types. To fix this problem, this patch adds a new type struct
2632 vectorlike_header that documents the constraints on layout of vectors
2633 and pseudovectors, and helps optimizing compilers not get fooled
2634 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2635 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2636 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2637 the size member.
2638 (XSETPVECTYPE): Rewrite in terms of new macro.
2639 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2640 This is a bit clearer, and further avoids the possibility of
2641 undesirable aliasing.
2642 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2643 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2644 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2645 since Lisp_Subr is a special case (no "next" field).
2646 (ASIZE): Now uses header.size rather than size.
2647 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2648 to avoid the hassle of writing XVECTOR (foo)->header.size.
2649 (struct vectorlike_header): New type.
2650 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2651 object, to help avoid aliasing.
2652 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2653 (SUBRP): Likewise, since Lisp_Subr is a special case.
2654 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2655 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2656 (struct Lisp_Hash_Table): Combine first two members into a single
2657 struct vectorlike_header member. All uses of "size" and "next" members
2658 changed to be "header.size" and "header.next".
2659 * buffer.h (struct buffer): Likewise.
2660 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2661 * frame.h (struct frame): Likewise.
2662 * process.h (struct Lisp_Process): Likewise.
2663 * termhooks.h (struct terminal): Likewise.
2664 * window.c (struct save_window_data, struct saved_window): Likewise.
2665 * window.h (struct window): Likewise.
2666 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2667 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2668 * buffer.c (init_buffer_once): Likewise.
2669 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2670 special case.
2671 * process.c (Fformat_network_address): Use local var for size,
2672 for brevity.
2673
2674 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2675
2676 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2677 * data.c (atof): Remove decl; no longer used or needed.
2678 (digit_to_number): Move to lread.c.
2679 (Fstring_to_number): Use new string_to_number function, to be
2680 consistent with how the Lisp reader treats infinities and NaNs.
2681 Do not assume that floating-point numbers represent EMACS_INT
2682 without losing information; this is not true on most 64-bit hosts.
2683 Avoid double-rounding errors, by insisting on integers when
2684 parsing non-base-10 numbers, as the documentation specifies.
2685 * lisp.h (string_to_number): New decl, replacing ...
2686 (isfloat_string): Remove.
2687 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2688 (read1): Do not accept +. and -. as integers; this
2689 appears to have been a coding error. Similarly, do not accept
2690 strings like +-1e0 as floating point numbers. Do not report
2691 overflow for integer overflows unless the base is not 10 which
2692 means we have no simple and reliable way to continue.
2693 Break out the floating-point parsing into a new
2694 function string_to_number, so that Fstring_to_number parses
2695 floating point numbers consistently with the Lisp reader.
2696 (digit_to_number): Move here from data.c. Make it static inline.
2697 (E_CHAR, EXP_INT): Remove, replacing with ...
2698 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2699 (string_to_number): New function, replacing isfloat_string.
2700 This function checks for valid syntax and produces the resulting
2701 Lisp float number too. Rework it so that string-to-number
2702 no longer mishandles examples like "1.0e+". Use strtoumax,
2703 so that overflow for non-base-10 numbers is reported only when
2704 there's no portable and simple way to convert to floating point.
2705
2706 * textprop.c (set_text_properties_1): Rewrite for clarity,
2707 and to avoid GCC warning about integer overflow.
2708
2709 * intervals.h (struct interval): Use EMACS_INT for members
2710 where EMACS_UINT might cause problems. See
2711 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2712 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2713 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2714 All uses changed.
2715 (offset_intervals): Tell GCC not to worry about length overflow
2716 when negating a negative length.
2717
2718 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2719 (overrun_check_free): Likewise.
2720
2721 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2722 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2723 word size.
2724
2725 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2726 (gnutls_make_error): Rename local to avoid shadowing.
2727 (gnutls_emacs_global_deinit): ifdef out; not used.
2728 (Fgnutls_boot): Use const for pointer to readonly storage.
2729 Comment out unused local. Fix pointer signedness problems.
2730
2731 * lread.c (openp): Don't stuff size_t into an 'int'.
2732 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2733 about possible signed overflow.
2734
2735 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2736 (GDK_KEY_g): Don't define if already defined.
2737 (xg_prepare_tooltip): Avoid pointer signedness problem.
2738 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2739
2740 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2741 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2742
2743 * xfns.c (Fx_window_property): Simplify a bit,
2744 to make a bit faster and to avoid GCC 4.6.0 warning.
2745 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2746
2747 * fns.c (internal_equal): Don't assume size_t fits in int.
2748
2749 * alloc.c (compact_small_strings): Tighten assertion a little.
2750
2751 Replace pEd with more-general pI, and fix some printf arg casts.
2752 * lisp.h (pI): New macro, generalizing old pEd macro to other
2753 conversion specifiers. For example, use "...%"pI"d..." rather
2754 than "...%"pEd"...".
2755 (pEd): Remove. All uses replaced with similar uses of pI.
2756 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2757 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2758 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2759 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2760 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2761 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2762 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2763 64-bit hosts.
2764 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2765 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2766 * print.c (safe_debug_print, print_object): Likewise.
2767 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2768 to int.
2769 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2770 avoiding the 0 flag, which is not portable.
2771 * process.c (Fmake_network_process): Use pI to avoid cast.
2772 * region-cache.c (pp_cache): Likewise.
2773 * xdisp.c (decode_mode_spec): Likewise.
2774 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2775 behavior on 64-bit hosts with printf arg.
2776 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2777 (x_stop_queuing_selection_requests): Likewise.
2778 (x_get_window_property): Don't truncate byte count to an 'int'
2779 when tracing.
2780
2781 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2782 here, since it parses constructs like leading '-' and spaces,
2783 which are not wanted; and it overflows with large numbers.
2784 Instead, simply match F[0-9]+, which is what is wanted anyway.
2785
2786 * alloc.c: Remove unportable assumptions about struct layout.
2787 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2788 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2789 (allocate_vectorlike, make_pure_vector): Use the new macros,
2790 plus offsetof, to remove unportable assumptions about struct layout.
2791 These assumptions hold on all porting targets that I know of, but
2792 they are not guaranteed, they're easy to remove, and removing them
2793 makes further changes easier.
2794
2795 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2796 This doesn't fix a bug but makes the code clearer.
2797 (string_overrun_cookie): Now const. Use initializers that
2798 don't formally overflow signed char, to avoid warnings.
2799 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2800 can cause Emacs to crash when string overrun checking is enabled.
2801 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2802 multiple of sizeof (EMACS_INT); it need not be, if
2803 alignof(EMACS_INT) < sizeof (EMACS_INT).
2804 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2805
2806 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2807
2808 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2809
2810 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2811
2812 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2813 supposed to be handshaking. (Bug#8556)
2814 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2815
2816 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2817
2818 * lisp.h (Qdebug): List symbol.
2819 * eval.c (Qdebug): Restore global linkage.
2820 * keyboard.c (debug-on-event): New variable.
2821 (handle_user_signal): Break into debugger when debug-on-event
2822 matches the current signal symbol.
2823
2824 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2825
2826 * alloc.c (check_sblock, check_string_bytes)
2827 (check_string_free_list): Convert to standard C.
2828
2829 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2830
2831 * w32.c (emacs_gnutls_push): Fix typo.
2832
2833 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2834
2835 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2836 "cast to pointer from integer of different size".
2837
2838 Improve doprnt and its use in verror. (Bug#8545)
2839 * doprnt.c (doprnt): Document the set of format control sequences
2840 supported by the function. Use SAFE_ALLOCA instead of always
2841 using `alloca'.
2842
2843 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2844 is one byte too soon. Don't use xrealloc; instead xfree and
2845 xmalloc anew.
2846
2847 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2848
2849 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2850 callbacks stage.
2851
2852 * gnutls.c: Renamed global_initialized to
2853 gnutls_global_initialized. Added internals for the
2854 :verify-hostname-error, :verify-error, and :verify-flags
2855 parameters of `gnutls-boot' and documented those parameters in the
2856 docstring. Start callback support.
2857 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2858 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2859 on error. Return error code.
2860 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2861 (emacs_gnutls_read): Likewise.
2862 (Fgnutls_boot): Return handshake error code.
2863 (emacs_gnutls_handle_error): New function.
2864 (wsaerror_to_errno): Likewise.
2865
2866 * w32.h (emacs_gnutls_pull): Add prototype.
2867 (emacs_gnutls_push): Likewise.
2868
2869 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2870 (emacs_gnutls_push): Likewise.
2871
2872 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2873
2874 * process.c (wait_reading_process_output): Check if GnuTLS
2875 buffered some data internally if no FDs are set for TLS
2876 connections.
2877
2878 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2879 (LIBS): Link to USER_LIBS.
2880 ($(BLD)/gnutls.$(0)): New target.
2881
2882 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2883
2884 * xdisp.c (handle_single_display_spec): Rename the
2885 display_replaced_before_p argument into display_replaced_p, to
2886 make it consistent with the commentary. Fix typos in the
2887 commentary.
2888
2889 * textprop.c (syms_of_textprop): Remove dead code.
2890 (copy_text_properties): Delete obsolete commentary about an
2891 interface that was deleted long ago. Fix typos in the description
2892 of arguments.
2893
2894 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2895 to changes in oldXMenu/XMenu.h from 2011-04-16.
2896 <menu_help_message, prev_menu_help_message>: Constify.
2897 (IT_menu_make_room): menu->help_text is now `const char **';
2898 adjust.
2899
2900 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2901 to changes in oldXMenu/XMenu.h from 2011-04-16.
2902 (struct XMenu): Declare `help_text' `const char **'.
2903
2904 * xfaces.c <Qunspecified>: Make extern again.
2905
2906 * syntax.c: Include sys/types.h before including regex.h, as
2907 required by Posix.
2908
2909 * doc.c (get_doc_string): Improve the format passed to `error'.
2910
2911 * doprnt.c (doprnt): Improve commentary.
2912
2913 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2914
2915 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2916 them with etags.
2917
2918 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2919 changes in globals.h immediately force recompilation.
2920 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2921 $(CURDIR)/s/ms-w32.h.
2922 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2923
2924 * character.c (Fchar_direction): Function deleted.
2925 (syms_of_character): Don't defsubr it.
2926 <char-direction-table>: Deleted.
2927
2928 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2929
2930 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2931 * doprnt.c: Include limits.h.
2932 (SIZE_MAX): New macro.
2933 (doprnt): Return a size_t value. 2nd arg is now size_t.
2934 Many local variables are now size_t instead of int or unsigned.
2935 Improve overflow protection. Support `l' modifier for integer
2936 conversions. Support %l conversion. Don't assume an EMACS_INT
2937 argument for integer conversions and for %c.
2938
2939 * lisp.h (doprnt): Restore prototype.
2940
2941 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2942 $(SRC)/character.h.
2943
2944 * Makefile.in (base_obj): Add back doprnt.o.
2945
2946 * deps.mk (doprnt.o): Add back prerequisites.
2947 (callint.o): Depend on character.h.
2948
2949 * eval.c (internal_lisp_condition_case): Include the handler
2950 representation in the error message.
2951 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2952 when breaking from the loop.
2953
2954 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2955
2956 * callint.c (Fcall_interactively): When displaying error message
2957 about invalid control letter, pass the character's codepoint, not
2958 a pointer to its multibyte form. Improve display of the character
2959 in octal and display also its hex code.
2960
2961 * character.c (char_string): Use %x to display the (unsigned)
2962 codepoint of an invalid character, to avoid displaying a bogus
2963 negative value.
2964
2965 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2966 `error', not SYMBOL_NAME itself.
2967
2968 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2969 character arguments to `error'.
2970
2971 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2972 to `error' in error message about FINAL_CHAR argument. Make sure
2973 FINAL_CHAR is a character, and use %c when it is passed as
2974 argument to `error'.
2975
2976 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2977
2978 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2979
2980 * w32.c: Include <time.h>.
2981 (sys_localtime): New function.
2982
2983 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2984
2985 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2986
2987 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2988
2989 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2990
2991 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2992 zombies (Bug#8467).
2993
2994 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2995
2996 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2997 gl_state.e_property when gl_state.object is Qt.
2998
2999 * insdel.c (make_gap_larger): Remove limitation of buffer size
3000 to <= INT_MAX.
3001
3002 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3003
3004 * xdisp.c (lookup_glyphless_char_display)
3005 (produce_glyphless_glyph): Handle cons cell entry in
3006 glyphless-char-display.
3007 (Vglyphless_char_display): Document it.
3008
3009 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3010 glyphless-char-display.
3011
3012 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3013
3014 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3015
3016 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3017
3018 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3019 definition for no-X builds.
3020
3021 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3022
3023 Static checks with GCC 4.6.0 and non-default toolkits.
3024
3025 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3026
3027 * process.c (keyboard_bit_set): Define only if SIGIO.
3028 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3029 (send_process): Repair possible setjmp clobbering.
3030
3031 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3032
3033 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3034
3035 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3036
3037 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3038 Define only if needed.
3039
3040 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3041 by pacifying GCC about it. Maybe it's time to retire it?
3042 * xfaces.c (USG, __TIMEVAL__): Likewise.
3043
3044 * dispextern.h (struct redisplay_interface): Rename param
3045 to avoid shadowing.
3046 * termhooks.h (struct terminal): Likewise.
3047 * xterm.c (xembed_send_message): Likewise.
3048
3049 * insdel.c (make_gap_smaller): Define only if
3050 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3051
3052 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3053 it.
3054
3055 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3056 so that we aren't warned about unused symbols.
3057
3058 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3059
3060 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3061
3062 * xfns.c (x_real_positions): Mark locals as initialized.
3063
3064 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3065
3066 * xterm.c: Fix problems found by static analysis with other toolkits.
3067 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3068 (x_dispatch_event): Declare static if USE_GTK, and
3069 define if USE_GTK || USE_X_TOOLKIT.
3070 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3071 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3072 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3073 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3074
3075 * xmenu.c (menu_help_callback): Pointer type fixes.
3076 Use const pointers when pointing at readonly data. Avoid pointer
3077 signedness clashes.
3078 (FALSE): Remove unused macro.
3079 (update_frame_menubar): Remove unused decl.
3080
3081 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3082
3083 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3084 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3085 (single_menu_item): Rename local to avoid shadowing.
3086
3087 * keyboard.c (make_lispy_event): Remove unused local var.
3088
3089 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3090 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3091
3092 * bitmaps: Change bitmaps from unsigned char back to the X11
3093 compatible char. Avoid the old compiler warnings about
3094 out-of-range initializers by using, for example, '\xab' rather
3095 than 0xab.
3096
3097 * xgselect.c (xgselect_initialize): Check vs interface
3098 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3099
3100 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3101
3102 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3103 to read-only memory.
3104
3105 * fns.c (vector): Remove; this old hack is no longer needed.
3106
3107 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3108 Remove unused var.
3109 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3110
3111 * xrdb.c (x_load_resources): Omit unused local.
3112
3113 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3114 (x_window): Rename locals to avoid shadowing.
3115 (USG): Use the kludged USG macro, to pacify gcc.
3116
3117 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3118 (x_term_init): Remove local to avoid shadowing.
3119
3120 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3121
3122 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3123 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3124
3125 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3126
3127 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3128
3129 Fix regex.c, syntax.c and friends for buffers > 2GB.
3130 * syntax.h (struct gl_state_s): Declare character position members
3131 EMACS_INT.
3132
3133 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3134
3135 * textprop.c (verify_interval_modification, interval_of):
3136 Declare arguments EMACS_INT.
3137
3138 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3139 EMACS_INT.
3140
3141 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3142
3143 * indent.c (Fvertical_motion): Local variable it_start is now
3144 EMACS_INT.
3145
3146 * regex.c (re_match, re_match_2, re_match_2_internal)
3147 (bcmp_translate, regcomp, regexec, print_double_string)
3148 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3149 (re_compile_pattern, re_exec): Declare arguments and local
3150 variables `size_t' and `ssize_t' and return values `regoff_t', as
3151 appropriate.
3152 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3153 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3154 <compile_stack_type>: `size' and `avail' are now `size_t'.
3155
3156 * regex.h <regoff_t>: Use ssize_t, not int.
3157 (re_search, re_search_2, re_match, re_match_2): Arguments that
3158 specify buffer/string position and length are now ssize_t and
3159 size_t. Return type is regoff_t.
3160
3161 2011-04-16 Ben Key <bkey76@gmail.com>
3162
3163 * nsfont.m: Fixed bugs in ns_get_family and
3164 ns_descriptor_to_entity that were caused by using free to
3165 deallocate memory blocks that were allocated by xmalloc (via
3166 xstrdup). This caused Emacs to crash when compiled with
3167 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3168 --enable-checking=xmallocoverrun). xfree is now used to
3169 deallocate these memory blocks.
3170
3171 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3172
3173 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3174
3175 emacs_write: Accept and return EMACS_INT for sizes.
3176 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3177 et seq.
3178 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3179 Accept and return EMACS_INT.
3180 (emacs_gnutls_write): Return the number of bytes written on
3181 partial writes.
3182 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3183 (emacs_read, emacs_write): Remove check for negative size, as the
3184 Emacs source code has been audited now.
3185 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3186 (emacs_read, emacs_write): Use it.
3187 * process.c (send_process): Adjust to the new signatures of
3188 emacs_write and emacs_gnutls_write. Do not attempt to store
3189 a byte offset into an 'int'; it might overflow.
3190 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3191
3192 * sound.c: Don't assume sizes fit in 'int'.
3193 (struct sound_device.period_size, alsa_period_size):
3194 Return EMACS_INT, not int.
3195 (struct sound_device.write, vox_write, alsa_write):
3196 Accept EMACS_INT, not int.
3197 (wav_play, au_play): Use EMACS_INT to store sizes and to
3198 record read return values.
3199
3200 2011-04-15 Ben Key <bkey76@gmail.com>
3201
3202 * keyboard.c (Qundefined): Don't declare static since it is used
3203 in nsfns.m.
3204 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3205 static since they are used in nsfont.m.
3206
3207 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3208
3209 * process.c (Qprocessp): Don't declare static.
3210 * lisp.h (Qprocessp): Declare again.
3211
3212 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3213
3214 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3215
3216 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3217
3218 Improve C-level modularity by making more things 'static'.
3219
3220 Don't publish debugger-only interfaces to other modules.
3221 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3222 (verify_bytepos, count_markers): Move decls to the only modules
3223 that need them.
3224 * region-cache.h (pp_cache): Likewise.
3225 * window.h (check_all_windows): Likewise.
3226 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3227
3228 * sysdep.c (croak): Now static, if
3229 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3230 * syssignal.h (croak): Declare only if not static.
3231
3232 * alloc.c (refill_memory_reserve): Now static if
3233 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3234 * lisp.h (refill_memory_reserve): Declare only if not static.
3235
3236 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3237 Define only if USE_LUCID.
3238
3239 * xrdb.c (x_customization_string, x_rm_string): Now static.
3240
3241 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3242 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3243
3244 * xdisp.c (draw_row_with_mouse_face): Now static.
3245 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3246
3247 * window.h (check_all_windows): Mark externally visible.
3248
3249 * window.c (window_deletion_count): Now static.
3250
3251 * undo.c: Make symbols static if they're not exported.
3252 (last_undo_buffer, last_boundary_position, pending_boundary):
3253 Now static.
3254
3255 * textprop.c (interval_insert_behind_hooks): Now static.
3256 (interval_insert_in_front_hooks): Likewise.
3257
3258 * term.c: Make symbols static if they're not exported.
3259 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3260 (max_frame_lines, tty_set_terminal_modes):
3261 (tty_reset_terminal_modes, tty_turn_off_highlight):
3262 (get_tty_terminal): Now static.
3263 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3264 * termhooks.h (term_mouse_moveto): Do not declare if
3265 HAVE_WINDOW_SYSTEM.
3266 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3267 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3268
3269 * sysdep.c: Make symbols static if they're not exported.
3270 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3271 Now static.
3272 (sigprocmask_set, full_mask): Remove; unused.
3273 (wait_debugging): Mark as visible.
3274 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3275 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3276
3277 * syntax.c (syntax_temp): Define only if !__GNUC__.
3278
3279 * sound.c (current_sound_device, current_sound): Now static.
3280
3281 * search.c (searchbufs, searchbuf_head): Now static.
3282
3283 * scroll.c (scroll_cost): Remove; unused.
3284 * dispextern.h (scroll_cost): Remove decl.
3285
3286 * region-cache.h (pp_cache): Mark as externally visible.
3287
3288 * process.c: Make symbols static if they're not exported.
3289 (process_tick, update_tick, create_process, chan_process):
3290 (Vprocess_alist, proc_buffered_char, datagram_access):
3291 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3292 (deactivate_process): Mark defn as static, as well as decl.
3293 * lisp.h (create_process): Remove decl.
3294 * process.h (chan_process, Vprocess_alist): Remove decls.
3295
3296 * print.c: Make symbols static if they're not exported.
3297 (print_depth, new_backquote_output, being_printed, print_buffer):
3298 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3299 (print_interval, print_number_index, initial_stderr_stream):
3300 Now static.
3301 * lisp.h (Fprinc): Remove decl.
3302 (debug_output_compilation_hack): Mark as externally visible.
3303
3304 * sysdep.c (croak): Move decl from here to syssignal.h.
3305 * syssignal.h (croak): Put it here, so the API can be checked when
3306 'croak' is called from dissociate_if_controlling_tty.
3307
3308 * minibuf.c: Make symbols static if they're not exported.
3309 (minibuf_save_list, choose_minibuf_frame): Now static.
3310 * lisp.h (choose_minibuf_frame): Remove decl.
3311
3312 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3313
3314 * lread.c: Make symbols static if they're not exported.
3315 (read_objects, initial_obarray, oblookup_last_bucket_number):
3316 Now static.
3317 (make_symbol): Remove; unused.
3318 * lisp.h (initial_obarray, make_symbol): Remove decls.
3319
3320 * keyboard.c: Make symbols static if they're not exported.
3321 (single_kboard, recent_keys_index, total_keys, recent_keys):
3322 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3323 (this_single_command_key_start, echoing, last_auto_save):
3324 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3325 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3326 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3327 (Vlispy_mouse_stem, double_click_count):
3328 Now static.
3329 (force_auto_save_soon): Define only if SIGDANGER.
3330 (ignore_mouse_drag_p): Now static if
3331 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3332 (print_help): Remove; unused.
3333 (stop_character, last_timer_event): Mark as externally visible.
3334 * keyboard.h (ignore_mouse_drag_p): Declare only if
3335 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3336 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3337 * lisp.h (echoing): Remove decl.
3338 (force_auto_save_soon): Declare only if SIGDANGER.
3339 * xdisp.c (redisplay_window): Simplify code, to make it more
3340 obvious that ignore_mouse_drag_p is not accessed if !defined
3341 USE_GTK && !defined HAVE_NS.
3342
3343 * intervals.c: Make symbols static if they're not exported.
3344 (merge_properties_sticky, merge_interval_right, delete_interval):
3345 Now static.
3346 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3347
3348 * insdel.c: Make symbols static if they're not exported.
3349 However, leave prepare_to_modify_buffer alone. It's never
3350 called from outside this function, but that appears to be a bug.
3351 (combine_after_change_list, combine_after_change_buffer):
3352 (adjust_after_replace, signal_before_change): Now static.
3353 (adjust_after_replace_noundo): Remove; unused.
3354 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3355 (signal_before_change): Remove decls.
3356
3357 * indent.c (val_compute_motion, val_vmotion): Now static.
3358
3359 * image.c: Make symbols static if they're not exported.
3360 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3361 if USE_GTK.
3362 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3363 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3364
3365 * fringe.c (standard_bitmaps): Now static.
3366 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3367
3368 * frame.c: Make symbols static if they're not exported.
3369 (x_report_frame_params, make_terminal_frame): Now static.
3370 (get_frame_param): Now static, unless HAVE_NS.
3371 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3372 (x_get_resource_string): Remove; not used.
3373 * frame.h (make_terminal_frame, x_report_frame_params):
3374 (x_get_resource_string); Remove decls.
3375 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3376 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3377
3378 * font.c, fontset.c: Make symbols static if they're not exported.
3379 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3380 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3381 * font.c (font_close_object): Now static.
3382 * font.h (font_close_object): Remove.
3383 * fontset.c (FONTSET_OBJLIST): Remove.
3384 (free_realized_fontset) #if-0 the body, which does nothing.
3385 (face_suitable_for_char_p): #if-0, as it's never called.
3386 * fontset.h (face_suitable_for_char_p): Remove decl.
3387 * xfaces.c (face_at_string_position):
3388 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3389 since 0 is always ASCII.
3390
3391 * fns.c (weak_hash_tables): Now static.
3392
3393 * fileio.c: Make symbols static if they're not exported.
3394 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3395 (Vwrite_region_annotation_buffers): Now static.
3396
3397 * eval.c: Make symbols static if they're not exported.
3398 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3399 * lisp.h (backtrace_list): Remove decl.
3400
3401 * emacs.c: Make symbols static if they're not exported.
3402 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3403 (fatal_error_code, fatal_error_signal_hook, standard_args):
3404 Now static.
3405 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3406 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3407 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3408 * lisp.h (fatal_error_signal_hook): Remove decl.
3409 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3410
3411 * editfns.c: Move a (normally-unused) function to its only use.
3412 * editfns.c, lisp.h (get_operating_system_release): Remove.
3413 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3414 worth the hassle of breaking this out.
3415
3416 * xterm.c: Make symbols static if they're not exported.
3417 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3418 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3419 (x_destroy_window, x_delete_display):
3420 Now static.
3421 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3422 (x_mouse_leave): Remove; unused.
3423 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3424 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3425 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3426 Remove decls.
3427 (x_mouse_leave): Declare only if WINDOWSNT.
3428 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3429 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3430 USE_X_TOOLKIT.
3431
3432 * ftxfont.c: Make symbols static if they're not exported.
3433 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3434 HAVE_FREETYPE.
3435 * font.h (ftxfont_driver): Likewise.
3436
3437 * xfns.c: Make symbols static if they're not exported.
3438 (x_last_font_name, x_display_info_for_name):
3439 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3440 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3441 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3442 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3443 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3444 (last_show_tip_args): Now static.
3445 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3446 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3447 (x_screen_planes): Remove; unused.
3448 * dispextern.h (x_screen_planes): Remove decl.
3449
3450 * dispnew.c: Make symbols static if they're not exported.
3451 * dispextern.h (redraw_garbaged_frames, scrolling):
3452 (increment_row_positions): Remove.
3453 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3454 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3455 Now static.
3456 (redraw_garbaged_frames): Remove; unused.
3457
3458 * xfaces.c: Make symbols static if they're not exported.
3459 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3460 Remove decls.
3461 * xterm.h (defined_color): Remove decls.
3462 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3463 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3464 (menu_face_changed_default, defined_color, free_realized_face):
3465 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3466 (ascii_face_of_lisp_face): Remove; unused.
3467
3468 * xdisp.c: Make symbols static if they're not exported.
3469 * dispextern.h (scratch_glyph_row, window_box_edges):
3470 (glyph_to_pixel_coords, set_cursor_from_row):
3471 (get_next_display_element, set_iterator_to_next):
3472 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3473 (show_mouse_face): Remove decls
3474 * frame.h (message_buf_print): Likewise.
3475 * lisp.h (pop_message, set_message, check_point_in_composition):
3476 Likewise.
3477 * xterm.h (set_vertical_scroll_bar): Likewise.
3478 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3479 (message_buf_print, scratch_glyph_row, displayed_buffer):
3480 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3481 (get_next_display_element, show_mouse_face, window_box_edges):
3482 (frame_to_window_pixel_xy, check_point_in_composition):
3483 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3484 (glyph_to_pixel_coords): Remove; unused.
3485
3486 * dired.c (file_name_completion): Now static.
3487
3488 * dbusbind.c (xd_in_read_queued_messages): Now static.
3489
3490 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3491 * data.c (circular_list_error): Remove.
3492
3493 * commands.h (last_point_position, last_point_position_buffer):
3494 (last_point_position_window): Remove decls.
3495 * keyboard.c: Make these variables static.
3496
3497 * coding.h (coding, code_convert_region, encode_coding_gap):
3498 Remove decls.
3499 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3500 (iso_code_class, detect_coding, code_convert_region): Now static.
3501 (encode_coding_gap): Remove; unused.
3502
3503 * chartab.c (chartab_chars, chartab_bits): Now static.
3504
3505 * charset.h (charset_iso_8859_1): Remove decl.
3506 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3507 Now static.
3508
3509 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3510 * ccl.c (Vccl_program_table): Now static.
3511 (check_ccl_update): Remove; unused.
3512
3513 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3514 * category.h: ... from here.
3515 * category.c (check_category_table, set_category_set): Now static.
3516
3517 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3518 * lisp.h: Remove these decls.
3519
3520 * buffer.c (buffer_count): Remove unused var.
3521
3522 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3523 so that it's not optimized away.
3524 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3525 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3526 exported only to the debugger.
3527
3528 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3529 * atimer.h (run_all_atimers): Remove; not exported.
3530
3531 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3532 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3533 was inaccessible from Lisp.
3534 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3535 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3536
3537 alloc.c: Import and export fewer symbols, and remove unused items.
3538 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3539 is defined.
3540 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3541 it's not optimized away by whole-program optimization.
3542 (message_enable_multibyte, free_misc): Remove.
3543 (catchlist, handlerlist, mark_backtrace):
3544 Declare only if BYTE_MARK_STACK.
3545 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3546 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3547 (message_enable_multibyte): Remove decl.
3548 (free_misc, interval_free_list, float_block, float_block_index):
3549 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3550 (cons_free_list, last_marked_index):
3551 Now static.
3552 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3553 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3554 (mark_backtrace): Define only if BYTE_MARK_STACK.
3555 * xdisp.c (message_enable_multibyte): Now static.
3556
3557 Declare Lisp_Object Q* variables to be 'static' if not exported.
3558 This makes it easier for human readers (and static analyzers)
3559 to see whether these variables are used from other modules.
3560 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3561 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3562 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3563 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3564 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3565 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3566 * xmenu.c, xselect.c:
3567 Declare Q* vars static if they are not used in other modules.
3568 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3569 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3570 Remove decls of unexported vars.
3571 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3572
3573 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3574
3575 Make Emacs functions such as Fatom 'static' by default.
3576 This makes it easier for human readers (and static analyzers)
3577 to see whether these functions can be called from other modules.
3578 DEFUN now defines a static function. To make the function external
3579 so that it can be used in other C modules, use the new macro DEFUE.
3580 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3581 (Finit_image_library):
3582 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3583 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3584 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3585 Remove decls, since these functions are now static.
3586 (Funintern, Fget_internal_run_time): New decls, since these functions
3587 were already external.
3588
3589 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3590 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3591 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3592 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3593 * keyboard.c, keymap.c, lread.c:
3594 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3595 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3596 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3597 Mark functions with DEFUE instead of DEFUN,
3598 if they are used in other modules.
3599 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3600 decls for now-static functions.
3601 * buffer.h (Fdelete_overlay): Remove decl.
3602 * callproc.c (Fgetenv_internal): Mark as internal.
3603 * composite.c (Fremove_list_of_text_properties): Remove decl.
3604 (Fcomposition_get_gstring): New forward static decl.
3605 * composite.h (Fcomposite_get_gstring): Remove decl.
3606 * dired.c (Ffile_attributes): New forward static decl.
3607 * doc.c (Fdocumntation_property): New forward static decl.
3608 * eval.c (Ffetch_bytecode): New forward static decl.
3609 (Funintern): Remove extern decl; now in .h file where it belongs.
3610 * fileio.c (Fmake_symbolic_link): New forward static decl.
3611 * image.c (Finit_image_library): New forward static decl.
3612 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3613 * intervals.h (Fprevious_property_change):
3614 (Fremove_list_of_text_properties): Remove decls.
3615 * keyboard.c (Fthis_command_keys): Remove decl.
3616 (Fcommand_execute): New forward static decl.
3617 * keymap.c (Flookup_key): New forward static decl.
3618 (Fcopy_keymap): Now static.
3619 * keymap.h (Flookup_key): Remove decl.
3620 * process.c (Fget_process): New forward static decl.
3621 (Fprocess_datagram_address): Mark as internal.
3622 * syntax.c (Fsyntax_table_p): New forward static decl.
3623 (skip_chars): Remove duplicate decl.
3624 * textprop.c (Fprevious_property_change): New forward static decl.
3625 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3626 Now internal.
3627 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3628 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3629
3630 * editfns.c (Fformat): Remove unreachable code.
3631
3632 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3633
3634 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3635 change. (Bug#8496)
3636
3637 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3638
3639 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3640 when at ZV. (Bug#8487)
3641
3642 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3643
3644 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3645 (Bug#8437)
3646 * keyboard.c (parse_tool_bar_item): Likewise.
3647 * sound.c (sound_cleanup, alsa_close): Likewise.
3648 * termcap.c (tgetent): Likewise.
3649 * xfns.c (x_default_font_parameter): Likewise.
3650 * xsettings.c (read_and_apply_settings): Likewise.
3651
3652 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3653 (overrun_check_free): Protoize.
3654
3655 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3658 since callers should never pass a negative size.
3659 Change the signature to match that of plain 'read' and 'write'; see
3660 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3661 * lisp.h: Update prototypes of emacs_write and emacs_read.
3662
3663 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3664
3665 * xdisp.c (redisplay_window): Don't try to determine the character
3666 position of the scroll margin if the window start point w->startp
3667 is outside the buffer's accessible region. (Bug#8468)
3668
3669 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3670
3671 Fix write-region and its subroutines for buffers > 2GB.
3672 * fileio.c (a_write, e_write): Modify declaration of arguments and
3673 local variables to support buffers larger than 2GB.
3674 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3675
3676 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3677 argument, local variables, and return value.
3678
3679 * lisp.h: Update prototypes of emacs_write and emacs_read.
3680
3681 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3682
3683 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3684
3685 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3686
3687 Fix more problems found by GCC 4.6.0's static checks.
3688
3689 * xdisp.c (vmessage): Use a better test for character truncation.
3690
3691 * charset.c (load_charset_map): <, not <=, for optimization,
3692 and to avoid potential problems with integer overflow.
3693 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3694 * casetab.c (set_identity, shuffle): Likewise.
3695 * editfns.c (Fformat): Likewise.
3696 * syntax.c (skip_chars): Likewise.
3697
3698 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3699 This also lets GCC 4.6.0 generate slightly better loop code.
3700
3701 * callint.c (Fcall_interactively): <, not <=, for optimization.
3702 (Fcall_interactively): Count the number of arguments produced,
3703 not the number of arguments given. This is simpler and lets GCC
3704 4.6.0 generate slightly better code.
3705
3706 * ftfont.c: Distingish more carefully between FcChar8 and char.
3707 The previous code passed unsigned char * to a functions like
3708 strlen and xstrcasecmp that expect char *, which does not
3709 conform to the C standard.
3710 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3711 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3712 char * when the C standard requires it.
3713
3714 * keyboard.c (read_char): Remove unused var.
3715
3716 * eval.c: Port to Windows vsnprintf (Bug#8435).
3717 Include <limits.h>.
3718 (SIZE_MAX): Define if the headers do not.
3719 (verror): Do not give up if vsnprintf returns a negative count.
3720 Instead, grow the buffer. This ports to Windows vsnprintf, which
3721 does not conform to C99. Problem reported by Eli Zaretskii.
3722 Also, simplify the allocation scheme, by avoiding the need for
3723 calling realloc, and removing the ALLOCATED variable.
3724
3725 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3726
3727 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3728 But keep the doprint source code for now, as we might revamp it
3729 and use it again (Bug#8435).
3730 * lisp.h (doprnt): Remove.
3731 * Makefile.in (base_obj): Remove doprnt.o.
3732 * deps.mk (doprnt.o): Remove.
3733
3734 error: Print 32- and 64-bit integers portably (Bug#8435).
3735 Without this change, on typical 64-bit hosts error ("...%d...", N)
3736 was used to print both 32- and 64-bit integers N, which relied on
3737 undefined behavior.
3738 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3739 New macro.
3740 * lisp.h (error, verror): Mark as printf-like functions.
3741 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3742 Report overflow in size calculations when allocating printf buffer.
3743 Do not truncate output string at its first null byte.
3744 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3745 Truncate the output at a character boundary, since vsnprintf does not
3746 do that.
3747 * charset.c (check_iso_charset_parameter): Convert internal
3748 character to string before calling 'error', since %c now has the
3749 printf meaning.
3750 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3751 overflow when computing char to be passed to 'error'. Do not
3752 pass Lisp_Object to 'error'; pass the integer instead.
3753 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3754 formatted with plain %d.
3755
3756 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3757
3758 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3759
3760 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3761
3762 * xterm.c (x_catch_errors): Remove duplicate declaration.
3763
3764 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3765
3766 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3767
3768 2011-04-10 Jim Meyering <meyering@redhat.com>
3769
3770 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3771 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3772 return ssize_t not "int", and use size_t as the buffer length.
3773 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3774 * gnutls.h: Update declarations.
3775 * process.c (read_process_output): Use ssize_t, to match.
3776 (send_process): Likewise.
3777
3778 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3779
3780 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3781
3782 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3783
3784 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3785 Use unsigned char, to match FcChar8 type definition.
3786
3787 * xterm.c (handle_one_xevent):
3788 * xmenu.c (create_and_show_popup_menu):
3789 * xselect.c (x_decline_selection_request)
3790 (x_reply_selection_request): Avoid type-punned deref of X events.
3791
3792 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3793
3794 Fix some uses of `int' instead of EMACS_INT.
3795 * search.c (string_match_1, fast_string_match)
3796 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3797 (scan_buffer, find_next_newline_no_quit)
3798 (find_before_next_newline, search_command, Freplace_match)
3799 (Fmatch_data): Make some `int' variables be EMACS_INT.
3800
3801 * xdisp.c (display_count_lines): 3rd argument and return value now
3802 EMACS_INT. All callers changed.
3803 (pint2hrstr): Last argument is now EMACS_INT.
3804
3805 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3806 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3807 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3808 (decode_coding_utf_16, decode_coding_emacs_mule)
3809 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3810 (decode_coding_ccl, decode_coding_charset)
3811 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3812 (decode_coding_iso_2022, decode_coding_emacs_mule)
3813 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3814 <char_offset, last_offset>: Declare EMACS_INT.
3815 (encode_coding_utf_8, encode_coding_utf_16)
3816 (encode_coding_emacs_mule, encode_invocation_designation)
3817 (encode_designation_at_bol, encode_coding_iso_2022)
3818 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3819 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3820 Declare EMACS_INT.
3821 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3822 (encode_invocation_designation): Last argument P_NCHARS is now
3823 EMACS_INT.
3824 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3825 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3826
3827 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3828 All users changed.
3829
3830 * ccl.c (Fccl_execute_on_string): Declare some variables
3831 EMACS_INT.
3832
3833 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3834
3835 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3836
3837 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3838
3839 * process.c (Fformat_network_address): Doc fix.
3840
3841 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3842
3843 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3844
3845 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3846
3847 * keyboard.c (read_char): Call Lisp function help-form-show,
3848 instead of using internal_with_output_to_temp_buffer.
3849 (Qhelp_form_show): New var.
3850 (syms_of_keyboard): Use DEFSYM macro.
3851
3852 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3853
3854 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3855
3856 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3857
3858 * process.c (Flist_processes): Remove to Lisp.
3859 (list_processes_1): Delete.
3860
3861 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3862
3863 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3864
3865 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3866
3867 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3868
3869 Fix more problems found by GCC 4.6.0's static checks.
3870
3871 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3872
3873 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3874
3875 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3876
3877 * xdisp.c (vmessage): Mark as a printf-like function.
3878
3879 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3880
3881 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3882
3883 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3884 printf-like functions.
3885 (tiff_load): Add casts to remove these marks before passing them
3886 to system-supplied API.
3887
3888 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3889
3890 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3891 This avoids several warnings with gcc -Wstrict-overflow.
3892 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3893 directly, rather than having caller test rule sign. This avoids
3894 some unnecessary tests.
3895 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3896 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3897 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3898
3899 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3900 (xfont_open): Avoid unnecessary tests.
3901
3902 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3903
3904 * composite.h, composite.c (composition_gstring_put_cache):
3905 Use EMACS_INT, not int, for length.
3906
3907 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3908 breaking out part of COMPOSITION_DECODE_RULE.
3909 (COMPOSITION_DECODE_RULE): Use it.
3910 * composite.c (get_composition_id): Remove unused local vars,
3911 by using the new macro.
3912
3913 * textprop.c (set_text_properties_1): Change while to do-while,
3914 since the condition is always true at first.
3915
3916 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3917 (interval_deletion_adjustment): Return unsigned value.
3918 All uses changed.
3919
3920 * process.c (list_processes_1, create_pty, read_process_output):
3921 (exec_sentinel): Remove vars that were set but not used.
3922 (create_pty): Remove unnecessary "volatile"s.
3923 (Fnetwork_interface_info): Avoid possibility of int overflow.
3924 (read_process_output): Do adaptive read buffering even if carryover.
3925 (read_process_output): Simplify nbytes computation if buffered.
3926
3927 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3928
3929 * syntax.c (scan_words): Remove var that was set but not used.
3930 (update_syntax_table): Use unsigned instead of int.
3931
3932 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3933 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3934 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3935
3936 * print.c (print_error_message): Avoid int overflow.
3937
3938 * font.c (font_list_entities): Redo for clarity,
3939 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3940
3941 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3942 (font_score): Avoid potential overflow in diff calculation.
3943
3944 * fns.c (substring_both): Remove var that is set but not used.
3945 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3946
3947 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3948
3949 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3950 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3951 can always succeed if overflow has undefined behavior.
3952
3953 * search.c (boyer_moore, wordify): Remove vars set but not used.
3954 (wordify): Omit three unnecessary tests.
3955
3956 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3957 All callers changed. This avoids the need for an unused var.
3958
3959 * casefiddle.c (casify_region): Remove var that is set but not used.
3960
3961 * dired.c (file_name_completion): Remove var that is set but not used.
3962
3963 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3964
3965 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3966 (Finsert_file_contents): Remove unnecessary code checking fd.
3967
3968 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3969 Check for integer overflow on size calculations.
3970
3971 * buffer.c (Fprevious_overlay_change): Remove var that is set
3972 but not used.
3973
3974 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3975 Remove vars that are set but not used.
3976 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3977 (timer_check_2): Mark vars as initialized.
3978
3979 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3980
3981 * image.c (lookup_image): Remove var that is set but not used.
3982 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3983
3984 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3985 that are set but not used.
3986
3987 * xfns.c (make_invisible_cursor): Don't return garbage
3988 if XCreateBitmapFromData fails (Bug#8410).
3989
3990 * xselect.c (x_get_local_selection, x_handle_property_notify):
3991 Remove vars that are set but not used.
3992
3993 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3994 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3995
3996 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3997 Remove var that is set but not used.
3998 (scroll_bar_windows_size): Now size_t, not int.
3999 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4000 Check for overflow.
4001
4002 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4003 (map_tty_color) [!defined MSDOS]: Likewise.
4004
4005 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4006
4007 * coding.c: Remove vars that are set but not used.
4008 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4009 All callers changed.
4010 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4011 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4012 (decode_coding_charset): Remove vars that are set but not used.
4013
4014 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4015 that is set but not used.
4016
4017 * print.c (print_object): Remove var that is set but not used.
4018
4019 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4020 The gnulib version avoids calling malloc in the usual case,
4021 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4022 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4023 * filelock.c (current_lock_owner): Likewise.
4024 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4025 * sysdep.c: Include allocator.h, careadlinkat.h.
4026 (emacs_no_realloc_allocator): New static constant.
4027 (emacs_readlink): New function.
4028 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4029 ../lib/careadlinkat.h.
4030
4031 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4032
4033 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4034 first non-nil return value).
4035
4036 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4037
4038 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4039 if not defined (Bug#8403).
4040
4041 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4042
4043 * xdisp.c (display_count_lines): Remove parameter `start',
4044 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4045 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4046 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4047 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4048 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4049 and thereabouts. All callers changed.
4050 (get_per_char_metric): Remove parameter `f', unused since
4051 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4052
4053 2011-04-02 Jim Meyering <meyering@redhat.com>
4054
4055 do not dereference NULL upon failed strdup
4056 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4057 (ns_get_family): Likewise.
4058
4059 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4060
4061 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4062
4063 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4064
4065 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4066 later (Bug#8403).
4067
4068 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4069
4070 Add lexical binding.
4071
4072 * window.c (Ftemp_output_buffer_show): New fun.
4073 (Fsave_window_excursion):
4074 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4075
4076 * lread.c (lisp_file_lexically_bound_p): New function.
4077 (Fload): Bind Qlexical_binding.
4078 (readevalloop): Remove `evalfun' arg.
4079 Bind Qinternal_interpreter_environment.
4080 (Feval_buffer): Bind Qlexical_binding.
4081 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4082 Mark as dynamic.
4083 (syms_of_lread): Declare `lexical-binding'.
4084
4085 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4086
4087 * keyboard.c (eval_dyn): New fun.
4088 (menu_item_eval_property): Use it.
4089
4090 * image.c (parse_image_spec): Use Ffunctionp.
4091
4092 * fns.c (concat, mapcar1): Accept byte-code-functions.
4093
4094 * eval.c (Fsetq): Handle lexical vars.
4095 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4096 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4097 (FletX, Flet): Obey lexical binding.
4098 (Fcommandp): Handle closures.
4099 (Feval): New `lexical' arg.
4100 (eval_sub): New function extracted from Feval. Use it almost
4101 everywhere where Feval was used. Look up vars in lexical env.
4102 Handle closures.
4103 (Ffunctionp): Move from subr.el.
4104 (Ffuncall): Handle closures.
4105 (apply_lambda): Remove `eval_flags'.
4106 (funcall_lambda): Handle closures and new byte-code-functions.
4107 (Fspecial_variable_p): New function.
4108 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4109 but without exporting it to Lisp.
4110
4111 * doc.c (Fdocumentation, store_function_docstring):
4112 * data.c (Finteractive_form): Handle closures.
4113
4114 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4115 interactive spec.
4116
4117 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4118 New byte-codes.
4119 (exec_byte_code): New function extracted from Fbyte_code to handle new
4120 calling convention for byte-code-functions. Add new byte-codes.
4121
4122 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4123
4124 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4125
4126 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4127
4128 * xdisp.c (redisplay_internal): Fix prototype.
4129
4130 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4131
4132 * xdisp.c (SCROLL_LIMIT): New macro.
4133 (try_scrolling): Use it when setting scroll_limit.
4134 Limit scrolling to 100 screen lines.
4135 (redisplay_window): Even when falling back on "recentering",
4136 position point in the window according to scroll-conservatively,
4137 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4138
4139 (try_scrolling): When point is above the window, allow searching
4140 as far as scroll_max, or one screenful, to compute vertical
4141 distance from PT to the scroll margin position. This prevents
4142 try_scrolling from unnecessarily failing when
4143 scroll-conservatively is set to a value slightly larger than the
4144 window height. Clean up the case of PT below the margin at bottom
4145 of window: scroll_max can no longer be INT_MAX. When aggressive
4146 scrolling is in use, don't let point enter the opposite scroll
4147 margin as result of the scroll.
4148 (syms_of_xdisp) <scroll-conservatively>: Document the
4149 threshold of 100 lines for never-recentering scrolling.
4150
4151 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4152
4153 * dispextern.h (move_it_by_lines):
4154 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4155 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4156 (message_log_check_duplicate): Remove parameters `prev_bol' and
4157 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4158 (redisplay_internal): Remove parameter `preserve_echo_area',
4159 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4160
4161 * indent.c (Fvertical_motion):
4162 * window.c (window_scroll_pixel_based, Frecenter):
4163 Don't pass `need_y_p' to `move_it_by_lines'.
4164
4165 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4166
4167 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4168 steal a few bits to be more compact.
4169 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4170 Remove unneeded casts.
4171
4172 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4173
4174 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4175
4176 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4177 binding" message (bug#7967).
4178
4179 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4180
4181 Fix more problems found by GCC 4.6.0's static checks.
4182
4183 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4184 Remove unused local var.
4185
4186 * editfns.c (Fmessage_box): Remove unused local var.
4187
4188 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4189 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4190 Omit unused local vars.
4191 * window.c (shrink_windows): Omit unused local var.
4192 * menu.c (digest_single_submenu): Omit unused local var.
4193 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4194 Omit unused local var.
4195
4196 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4197 Don't assume string length fits in int.
4198 (keyremap_step, read_key_sequence): Use size_t for sizes.
4199 (read_key_sequence): Don't check last_real_key_start redundantly.
4200
4201 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4202 instead of alloca (Bug#8344).
4203
4204 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4205 (Fbacktrace_frame): Don't assume nframes fits in int.
4206
4207 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4208
4209 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4210 concerns.
4211
4212 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4213
4214 * cm.c (calccost): Turn while-do into do-while, for clarity.
4215
4216 * keyboard.c (syms_of_keyboard): Use the same style as later
4217 in this function when indexing through an array. This also
4218 works around GCC bug 48267.
4219
4220 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4221
4222 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4223
4224 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4225 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4226
4227 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4228 This avoids undefined behavior on integer overflow, and is a bit
4229 more convenient anyway since it is compared to a size_t variable.
4230
4231 Variadic C functions now count arguments with size_t, not int.
4232 This avoids an unnecessary limitation on 64-bit machines, which
4233 caused (substring ...) to crash on large vectors (Bug#8344).
4234 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4235 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4236 All variadic functions and their callers changed accordingly.
4237 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4238 * data.c (arith_driver, float_arith_driver): Likewise.
4239 * editfns.c (general_insert_function): Likewise.
4240 * eval.c (struct backtrace.nargs, interactive_p)
4241 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4242 (funcall_lambda, mark_backtrace): Likewise.
4243 * fns.c (concat): Likewise.
4244 * frame.c (x_set_frame_parameters): Likewise.
4245 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4246 0 if not found, not -1. All callers changed.
4247
4248 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4249 (stack_copy_size): Now size_t, not int.
4250 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4251
4252 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4253
4254 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4255 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4256 All callers changed.
4257
4258 * lisp.h (multibyte_char_to_unibyte):
4259 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4260 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4261 * character.h (CHAR_TO_BYTE8):
4262 * cmds.c (internal_self_insert):
4263 * editfns.c (general_insert_function):
4264 * keymap.c (push_key_description):
4265 * search.c (Freplace_match):
4266 * xdisp.c (message_dolog, set_message_1): All callers changed.
4267
4268 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4269
4270 * keyboard.c (safe_run_hook_funcall): New function.
4271 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4272 don't set the hook to nil, but remove the offending function instead.
4273 (Qcommand_hook_internal): Remove, unused.
4274 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4275 Vcommand_hook_internal.
4276
4277 * eval.c (enum run_hooks_condition): Remove.
4278 (funcall_nil, funcall_not): New functions.
4279 (run_hook_with_args): Call each function through a `funcall' argument.
4280 Remove `cond' argument, now redundant.
4281 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4282 (Frun_hook_with_args_until_failure): Adjust accordingly.
4283 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4284
4285 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4286
4287 * dispextern.h (string_buffer_position): Remove declaration.
4288
4289 * print.c (strout): Remove parameter `multibyte', unused since
4290 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4291
4292 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4293 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4294 All callers changed.
4295
4296 * w32.c (_wsa_errlist): Use braces for struct initializers.
4297
4298 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4299 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4300 All callers changed.
4301 (string_buffer_position): Likewise. Also, make static (it's never
4302 used outside xdisp.c).
4303 (cursor_row_p): Remove parameter `w', unused since
4304 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4305 (decode_mode_spec): Remove parameter `precision', introduced during
4306 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4307 All callers changed.
4308
4309 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4310
4311 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4312
4313 2011-03-27 Anders Lindgren <andlind@gmail.com>
4314
4315 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4316 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4317 (ns_update_auto_hide_menu_bar): New functions.
4318 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4319 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4320 ns_constrain_all_frames.
4321 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4322 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4323
4324 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4325
4326 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4327
4328 2011-03-27 Glenn Morris <rgm@gnu.org>
4329
4330 * syssignal.h: Replace RETSIGTYPE with void.
4331 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4332 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4333 Replace SIGTYPE with void everywhere.
4334 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4335 * s/template.h (SIGTYPE): Remove commented out definition.
4336
4337 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4338
4339 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4340 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4341
4342 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4343
4344 * w32.c (read_unc_volume): Use parameter `henum', instead of
4345 global variable `wget_enum_handle'.
4346
4347 * keymap.c (describe_vector): Remove parameters `indices' and
4348 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4349 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4350
4351 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4352
4353 * keyboard.c (timer_check): Remove parameter `do_it_now',
4354 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4355 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4356 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4357
4358 * keyboard.c (read_char):
4359 * w32menu.c (w32_menu_display_help):
4360 * xmenu.c (show_help_event, menu_help_callback):
4361 Adjust calls to `show_help_echo'.
4362
4363 * gtkutil.c (xg_maybe_add_timer):
4364 * keyboard.c (readable_events):
4365 * process.c (wait_reading_process_output):
4366 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4367
4368 * insdel.c (adjust_markers_gap_motion):
4369 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4370 (gap_left, gap_right): Don't call it.
4371
4372 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4373
4374 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4375 incurred during fontification.
4376
4377 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4378
4379 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4380 (DEFVAR_PER_BUFFER): Don't pass it.
4381
4382 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4383 (scrolling_window): Don't pass it.
4384
4385 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4386
4387 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4388
4389 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4390 and `suffix'.
4391 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4392 of variables specific to SELinux and computation of `encoded_absname'.
4393
4394 * image.c (XPutPixel): Remove unused variable `height'.
4395
4396 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4397
4398 * unexw32.c (get_section_info): Remove unused variable `section'.
4399
4400 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4401 (system_process_attributes): Remove unused variable `sess'.
4402 (sys_read): Remove unused variable `err'.
4403
4404 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4405 (w32_wnd_proc): Remove unused variable `isdead'.
4406 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4407 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4408 (x_create_tip_frame): Remove unused variable `tem'.
4409
4410 * w32inevt.c (w32_console_read_socket):
4411 Remove unused variable `no_events'.
4412
4413 * w32term.c (x_draw_composite_glyph_string_foreground):
4414 Remove unused variable `width'.
4415
4416 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4417
4418 * w32term.c (x_set_glyph_string_clipping):
4419 Don't pass uninitialized region to CombineRgn.
4420
4421 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4422
4423 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4424 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4425 (Fx_close_connection): Remove unused variable `i'.
4426
4427 * w32font.c (w32font_draw): Return number of glyphs.
4428 (w32font_open_internal): Remove unused variable `i'.
4429 (w32font_driver): Add missing initializer.
4430
4431 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4432 (fill_in_menu): Remove unused variable `items_added'.
4433
4434 * w32term.c (last_mouse_press_frame): Remove static global variable.
4435 (w32_clip_to_row): Remove unused variable `f'.
4436 (x_delete_terminal): Remove unused variable `i'.
4437
4438 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4439 (NOTHING): Remove unused static global variable.
4440 (uniscribe_check_otf): Remove unused variable `table'.
4441 (uniscribe_font_driver): Add missing initializers.
4442
4443 2011-03-23 Julien Danjou <julien@danjou.info>
4444
4445 * term.c (Fsuspend_tty, Fresume_tty):
4446 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4447 * window.c (temp_output_buffer_show):
4448 * insdel.c (signal_before_change):
4449 * frame.c (Fhandle_switch_frame):
4450 * fileio.c (Fdo_auto_save):
4451 * emacs.c (Fkill_emacs):
4452 * editfns.c (save_excursion_restore):
4453 * cmds.c (internal_self_insert):
4454 * callint.c (Fcall_interactively):
4455 * buffer.c (Fkill_all_local_variables):
4456 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4457 Use Frun_hooks.
4458 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4459 unconditionnaly since it does the check itself.
4460
4461 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4462
4463 Fix more problems found by GCC 4.5.2's static checks.
4464
4465 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4466 the first time through the loop, since we know p0 < p1 then.
4467 This also avoids a gcc -Wstrict-overflow warning.
4468
4469 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4470 leading to a memory leak, possible in functions like
4471 load_charset_map_from_file that can allocate an unbounded number
4472 of objects (Bug#8318).
4473
4474 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4475 that could (at least in theory) be that large.
4476
4477 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4478 This is less likely to overflow, and avoids undefined behavior if
4479 overflow does occur. All callers changed. Use strtoul to scan
4480 for the unsigned long integer.
4481 (pint2hrstr): Simplify and tune code slightly.
4482 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4483
4484 * scroll.c (do_scrolling): Work around GCC bug 48228.
4485 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4486
4487 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4488 This also avoids a warning with gcc -Wstrict-overflow.
4489 (validate_x_resource_name): Simplify count usage.
4490 This also avoids a warning with gcc -Wstrict-overflow.
4491
4492 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4493 fail (Bug#8306).
4494
4495 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4496
4497 * process.c (Fmake_network_process): Use socklen_t, not int,
4498 where POSIX says socklen_t is required in portable programs.
4499 This fixes a porting bug on hosts like 64-bit HP-UX, where
4500 socklen_t is wider than int (Bug#8277).
4501 (Fmake_network_process, server_accept_connection):
4502 (wait_reading_process_output, read_process_output):
4503 Likewise.
4504
4505 * process.c: Rename or move locals to avoid shadowing.
4506 (list_processes_1, Fmake_network_process):
4507 (read_process_output_error_handler, exec_sentinel_error_handler):
4508 Rename or move locals.
4509 (Fmake_network_process): Define label "retry_connect" only if needed.
4510 (Fnetwork_interface_info): Fix pointer signedness.
4511 (process_send_signal): Add cast to avoid pointer signedness problem.
4512 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4513 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4514
4515 Make tparam.h and terminfo.c consistent.
4516 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4517 Include tparam.h instead, since it declares them.
4518 * cm.h (PC): Remove extern decl; tparam.h now does this.
4519 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4520 * terminfo.c: Include tparam.h, to check interfaces.
4521 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4522 (tparam): Adjust signature to match interface in tparam.h;
4523 this removes some undefined behavior. Check that outstring and len
4524 are zero, which they always are with Emacs.
4525 * tparam.h (PC, BC, UP): New extern decls.
4526
4527 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4528 (xftfont_open): Rename locals to avoid shadowing.
4529
4530 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4531 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4532 (OTF_TAG_SYM): Omit macro if not needed.
4533 (ftfont_list): Remove unused local.
4534 (get_adstyle_property, ftfont_pattern_entity):
4535 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4536 Rename locals to avoid shadowing.
4537
4538 * xfont.c (xfont_list_family): Mark var as initialized.
4539
4540 * xml.c (make_dom): Now static.
4541
4542 * composite.c (composition_compute_stop_pos): Rename local to
4543 avoid shadowing.
4544 (composition_reseat_it): Remove unused locals.
4545 (find_automatic_composition, composition_adjust_point): Likewise.
4546 (composition_update_it): Mark var as initialized.
4547 (find_automatic_composition): Mark vars as initialized,
4548 with a FIXME (Bug#8290).
4549
4550 character.h: Rename locals to avoid shadowing.
4551 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4552 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4553 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4554 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4555 to avoid shadowing.
4556
4557 * textprop.c (property_change_between_p): Remove; unused.
4558
4559 * intervals.c (interval_start_pos): Now static.
4560
4561 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4562
4563 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4564 Rename locals to avoid shadowing.
4565
4566 * sound.c (wav_play, au_play, Fplay_sound_internal):
4567 Fix pointer signedness.
4568 (alsa_choose_format): Remove unused local var.
4569 (wav_play): Initialize a variable to 0, to prevent undefined
4570 behavior (Bug#8278).
4571
4572 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4573
4574 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4575
4576 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4577 clobbering (Bug#8298).
4578 * sysdep.c (sys_subshell): Likewise.
4579 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4580
4581 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4582 This should get cleaned up, so that child_setup has the
4583 same signature on all platforms.
4584
4585 * callproc.c (call_process_cleanup): Now static.
4586 (relocate_fd): Rename locals to avoid shadowing.
4587
4588 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4589
4590 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4591 not to be necessary, and produces flickering.
4592
4593 2011-03-20 Glenn Morris <rgm@gnu.org>
4594
4595 * config.in: Remove file.
4596
4597 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4598
4599 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4600 are now in src/globals.h.
4601 (syms_of_minibuf): Remove spurious & from previous change.
4602
4603 2011-03-20 Leo <sdl.web@gmail.com>
4604
4605 * minibuf.c (completing-read-function): New variable.
4606 (completing-read-default): Rename from completing-read.
4607 (completing-read): Call completing-read-function.
4608
4609 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4610
4611 * xfaces.c (Fx_load_color_file):
4612 Read color file from absolute filename (bug#8250).
4613
4614 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4615
4616 * makefile.w32-in: Update dependencies.
4617
4618 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4619
4620 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4621
4622 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4623
4624 Fix more problems found by GCC 4.5.2's static checks.
4625
4626 * process.c (make_serial_process_unwind, send_process_trap):
4627 (sigchld_handler): Now static.
4628
4629 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4630 That way, the code declares only the vars that it needs.
4631 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4632 * s/cygwin.h (PTY_ITERATION): Likewise.
4633 * s/darwin.h (PTY_ITERATION): Likewise.
4634 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4635
4636 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4637 * process.c (allocate_pty): Don't declare stb unless it's needed.
4638
4639 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4640 (CONSTANTLIM): Remove; unused.
4641 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4642 Define only if needed.
4643
4644 * unexelf.c (unexec): Name an expression,
4645 to avoid gcc -Wbad-function-cast warning.
4646 Use a different way to cause a compilation error if anyone uses
4647 n rather than nn, a way that does not involve shadowing.
4648 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4649
4650 * deps.mk (unexalpha.o): Remove; unused.
4651
4652 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4653 * unexec.h: New file.
4654 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4655 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4656 Depend on unexec.h.
4657 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4658 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4659 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4660 Change as necessary to match prototype in unexec.h.
4661
4662 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4663 shadowing.
4664 (back_comment, skip_chars): Mark vars as initialized.
4665
4666 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4667 Rename locals to avoid shadowing.
4668
4669 * lread.c (read1): Rewrite so as not to use empty "else".
4670 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4671
4672 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4673
4674 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4675 warning when compiling print.c.
4676
4677 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4678 instead of using an uninitialized var.
4679 (font_sort_entities): Mark var as initialized.
4680
4681 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4682
4683 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4684 pointers to constants.
4685 (font_parse_fcname): Remove unused vars.
4686 (font_delete_unmatched): Now static.
4687 (font_get_spec): Remove; unused.
4688 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4689 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4690 Rename or move locals to avoid shadowing.
4691
4692 * fns.c (require_nesting_list, require_unwind): Now static.
4693 (Ffillarray): Rename locals to avoid shadowing.
4694
4695 * floatfns.c (domain_error2): Define only if needed.
4696 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4697
4698 * alloc.c (mark_backtrace): Move decl from here ...
4699 * lisp.h: ... to here, so that it can be checked.
4700
4701 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4702 (Fdefvar): Rewrite so as not to use empty "else".
4703 (lisp_indirect_variable): Name an expression,
4704 to avoid gcc -Wbad-function-cast warning.
4705 (Fdefvar): Rename locals to avoid shadowing.
4706
4707 * callint.c (quotify_arg, quotify_args): Now static.
4708 (Fcall_interactively): Rename locals to avoid shadowing.
4709 Use const pointer when appropriate.
4710
4711 * lisp.h (get_system_name, get_operating_system_release):
4712 Move decls here, to check interfaces.
4713 * process.c (get_operating_system_release): Move decl to lisp.h.
4714 * xrdb.c (get_system_name): Likewise.
4715 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4716 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4717 some of which prompt warnings from gcc -Wbad-function-cast.
4718 (Fformat_time_string, Fencode_time, Finsert_char):
4719 (Ftranslate_region_internal, Fformat):
4720 Rename or remove local vars to avoid shadowing.
4721 (Ftranslate_region_internal): Mark var as initialized.
4722
4723 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4724 avoid shadowing.
4725
4726 * lisp.h (eassert): Check that the argument compiles, even if
4727 ENABLE_CHECKING is not defined.
4728
4729 * data.c (Findirect_variable): Name an expression, to avoid
4730 gcc -Wbad-function-cast warning.
4731 (default_value, arithcompare, arith_driver, arith_error): Now static.
4732 (store_symval_forwarding): Rename local to avoid shadowing.
4733 (Fmake_variable_buffer_local, Fmake_local_variable):
4734 Mark variables as initialized.
4735 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4736
4737 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4738 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4739 Rename locals to avoid shadowing.
4740 (mark_stack): Move local variables into the #ifdef region where
4741 they're used.
4742 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4743 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4744 needed otherwise.
4745 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4746 (GC_STRING_CHARS): Remove; not used.
4747 (Fmemory_limit): Cast sbrk's returned value to char *.
4748
4749 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4750 avoids undefined behavior in theory.
4751
4752 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4753
4754 Use functions, not macros, for up- and down-casing (Bug#8254).
4755 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4756 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4757 to use the following functions instead of these macros.
4758 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4759 EMACS_INT, since callers assume the returned value fits in int.
4760 (upcase1): Likewise, for UPCASE_TABLE.
4761 (uppercasep, lowercasep, upcase): New static inline functions.
4762 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4763 the race-condition problem in the old DOWNCASE.
4764
4765 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4766 Rename locals to avoid shadowing.
4767 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4768 (regex_compile, re_search_2, re_match_2_internal):
4769 Remove unused local vars.
4770 (FREE_VAR): Rewrite so as not to use empty "else",
4771 which gcc can warn about.
4772 (regex_compile, re_match_2_internal): Mark locals as initialized.
4773 (RETALLOC_IF): Define only if needed.
4774 (WORDCHAR_P): Likewise. This one is never needed, but is used
4775 only in a comment talking about a compiler bug, so put inside
4776 the #if 0 of that comment.
4777 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4778 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4779 Remove; unused.
4780
4781 * search.c (boyer_moore): Rename locals to avoid shadowing.
4782 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4783 (PREV_CHAR_BOUNDARY): Likewise.
4784
4785 * search.c (simple_search): Remove unused var.
4786
4787 * dired.c (compile_pattern): Move decl from here ...
4788 * lisp.h: ... to here, so that it can be checked.
4789 (struct re_registers): New forward decl.
4790
4791 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4792
4793 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4794 All uses changed.
4795 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4796 Rename locals to avoid shadowing.
4797 (Fvertical_motion): Mark locals as initialized.
4798
4799 * casefiddle.c (casify_object, casify_region): Now static.
4800 (casify_region): Mark local as initialized.
4801
4802 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4803
4804 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4805 New macros, so that the caller can use some names other than
4806 gcpro1, gcpro2, etc.
4807 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4808 of the new macros.
4809 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4810 argument, for consistency with GCPRO2_VAR, etc: it is now the
4811 prefix of the variable, not the variable itself. All uses
4812 changed.
4813 * dired.c (directory_files_internal, file_name_completion):
4814 Rename locals to avoid shadowing.
4815
4816 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4817 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4818 dired.c's scmp function, had undefined behavior.
4819 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4820 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4821 * buffer.h: ... to here, because these macros use current_buffer,
4822 and the new implementation with inline functions needs to have
4823 current_buffer in scope now, rather than later when the macros
4824 are used.
4825 (downcase, upcase1): New static inline functions.
4826 (DOWNCASE, UPCASE1): Reimplement using these functions.
4827 This avoids undefined behavior in expressions like
4828 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4829 from race conditions in accessing the global variables
4830 case_temp1 and case_temp2.
4831 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4832 * lisp.h (case_temp1, case_temp2): Remove their decls.
4833 * character.h (ASCII_CHAR_P): Move from here ...
4834 * lisp.h: ... to here, so that the inline functions mentioned
4835 above can use them.
4836
4837 * dired.c (directory_files_internal_unwind): Now static.
4838
4839 * fileio.c (file_name_as_directory, directory_file_name):
4840 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4841 Now static.
4842 (file_name_as_directory): Use const pointers when appropriate.
4843 (Fexpand_file_name): Likewise. In particular, newdir might
4844 point at constant storage, so make it a const pointer.
4845 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4846 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4847 signedness issues.
4848 (Fset_file_times, Finsert_file_contents, auto_save_error):
4849 Rename locals to avoid shadowing.
4850
4851 * minibuf.c (choose_minibuf_frame_1): Now static.
4852 (Ftry_completion, Fall_completions): Rename or remove locals
4853 to avoid shadowing.
4854
4855 * marker.c (bytepos_to_charpos): Remove; unused.
4856
4857 * lisp.h (verify_bytepos, count_markers): New decls,
4858 so that gcc does not warn that these functions aren't declared.
4859
4860 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4861 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4862 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4863 (copy_text): Remove unused local var.
4864
4865 * filelock.c (within_one_second): Now static.
4866 (lock_file_1): Rename local to avoid shadowing.
4867
4868 * buffer.c (fix_overlays_before): Mark locals as initialized.
4869 (fix_start_end_in_overlays): Likewise. This function should be
4870 simplified by using pointers-to-pointers, but that's a different
4871 matter.
4872 (switch_to_buffer_1): Now static.
4873 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4874 (report_overlay_modification): Rename locals to avoid shadowing.
4875
4876 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4877 Fix pointer signedness issue.
4878 (sys_subshell): Mark local as volatile if checking for lint,
4879 to suppress a gcc -Wclobbered warning that does not seem to be right.
4880 (MAXPATHLEN): Define only if needed.
4881
4882 * process.c (serial_open, serial_configure): Move decls from here ...
4883 * systty.h: ... to here, so that they can be checked.
4884
4885 * fns.c (get_random, seed_random): Move extern decls from here ...
4886 * lisp.h: ... to here, so that they can be checked.
4887
4888 * sysdep.c (reset_io): Now static.
4889 (wait_for_termination_signal): Remove; unused.
4890
4891 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4892 (copy_keymap_item, append_key, push_text_char_description):
4893 Now static.
4894 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4895 (DENSE_TABLE_SIZE): Remove; unused.
4896 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4897 (describe_map_tree):
4898 Rename locals to avoid shadowing.
4899
4900 * keyboard.c: Declare functions static if they are not used elsewhere.
4901 (echo_char, echo_dash, cmd_error, top_level_2):
4902 (poll_for_input, handle_async_input): Now static.
4903 (read_char, kbd_buffer_get_event, make_lispy_position):
4904 (make_lispy_event, make_lispy_movement, apply_modifiers):
4905 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4906 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4907 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4908 (read_key_sequence, read_char): Mark locals as initialized.
4909 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4910
4911 * keyboard.h (make_ctrl_char): New decl.
4912 (mark_kboards): Move decl here ...
4913 * alloc.c (mark_kboards): ... from here.
4914
4915 * lisp.h (force_auto_save_soon): New decl.
4916
4917 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4918 (DEFINE_DUMMY_FUNCTION): New macro.
4919 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4920 Use it.
4921 (main): Add casts to avoid warnings
4922 if GCC considers string literals to be constants.
4923
4924 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4925
4926 * dbusbind.c: Pointer signedness fixes.
4927 (xd_signature, xd_append_arg, xd_initialize):
4928 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4929 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4930 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4931 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4932
4933 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4934 if GCC considers string literals to be constants.
4935 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4936
4937 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4938
4939 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4940 (print_preprocess, print_object): New macro to fix last change.
4941
4942 * print.c (print_preprocess): Don't forget font objects.
4943
4944 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4945
4946 * emacs.c (USAGE3): Doc fixes.
4947
4948 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4949
4950 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4951 structure.
4952
4953 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4954
4955 * lisp.h (VWindow_system, Qfile_name_history):
4956 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4957 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4958 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4959
4960 * w32select.c: Don't #include "keyboard.h".
4961 (run_protected): Add extern declaration for waiting_for_input.
4962
4963 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4964 * w32console.c (detect_input_pending, read_input_pending)
4965 (encode_terminal_code):
4966 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4967 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4968 (w32_system_caret_y, Qfile_name_history):
4969 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4970 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4971 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4972 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4973 * w32proc.c (Qlocal, report_file_error):
4974 * w32term.c (Vwindow_system, updating_frame):
4975 * w32uniscribe.c (initialized, uniscribe_font_driver):
4976 Remove unneeded extern declarations.
4977
4978 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4979
4980 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4981
4982 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4983
4984 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4985 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4986 These macros can no longer be used for assignment.
4987
4988 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4989 Assign struct members directly, instead of using BUF_BEGV etc.
4990 (record_buffer_markers, fetch_buffer_markers): New functions for
4991 recording and fetching special buffer markers.
4992 (set_buffer_internal_1, set_buffer_temp): Use them.
4993
4994 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4995
4996 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4997
4998 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4999 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5000
5001 * xdisp.c (hscroll_window_tree):
5002 (reconsider_clip_changes): Use PT instead of BUF_PT.
5003
5004 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5005
5006 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5007 $(EMACS_ROOT)/lib/intprops.h.
5008
5009 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5010
5011 Fix more problems found by GCC 4.5.2's static checks.
5012
5013 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5014 to unsigned char * to avoid compiler diagnostic.
5015 (xg_free_frame_widgets): Make it clear that a local variable is
5016 needed only if USE_GTK_TOOLTIP.
5017 (gdk_window_get_screen): Make it clear that this macro is needed
5018 only if USE_GTK_TOOLTIP.
5019 (int_gtk_range_get_value): New function, which avoids a diagnostic
5020 from gcc -Wbad-function-cast.
5021 (xg_set_toolkit_scroll_bar_thumb): Use it.
5022 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5023 diagnostic from gcc -Wbad-function-cast.
5024 (get_utf8_string, xg_get_file_with_chooser):
5025 Rename locals to avoid shadowing.
5026 (create_dialog): Move locals to avoid shadowing.
5027
5028 * xgselect.c (xg_select): Remove unused var.
5029
5030 * image.c (four_corners_best): Mark locals as initialized.
5031 (gif_load): Initialize transparent_p to zero (Bug#8238).
5032 Mark another local as initialized.
5033 (my_png_error, my_error_exit): Mark with NO_RETURN.
5034
5035 * image.c (clear_image_cache): Now static.
5036 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5037 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5038 (x_edge_detection): Remove unnecessary cast that
5039 gcc -Wbad-function-cast diagnoses.
5040 (gif_load): Fix pointer signedness.
5041 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5042 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5043
5044 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5045
5046 Improve quality of tests for time stamp overflow.
5047 For example, without this patch (encode-time 0 0 0 1 1
5048 1152921504606846976) returns the obviously-bogus value (-948597
5049 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5050 reports time overflow. See
5051 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5052 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5053 * editfns.c: Include limits.h and intprops.h.
5054 (TIME_T_MIN, TIME_T_MAX): New macros.
5055 (time_overflow): Move earlier, to before first use.
5056 (hi_time, lo_time): New functions, for an accurate test for
5057 out-of-range times.
5058 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5059 (Fget_internal_run_time): Don't assume time_t fits in int.
5060 (make_time): Use list2 instead of Fcons twice.
5061 (Fdecode_time): More accurate test for out-of-range times.
5062 (check_tm_member): New function.
5063 (Fencode_time): Use it, to test for out-of-range times.
5064 (lisp_time_argument): Don't rely on undefined left-shift and
5065 right-shift behavior when checking for time stamp overflow.
5066
5067 * editfns.c (time_overflow): New function, refactoring common code.
5068 (Fformat_time_string, Fdecode_time, Fencode_time):
5069 (Fcurrent_time_string): Use it.
5070
5071 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5072 * dired.c (make_time): Move to ...
5073 * editfns.c (make_time): ... here.
5074 * systime.h: Note the move.
5075
5076 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5077
5078 * fringe.c (update_window_fringes): Remove unused variables.
5079
5080 * unexmacosx.c (copy_data_segment): Also copy __got section.
5081 (Bug#8223)
5082
5083 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5084
5085 * termcap.c [MSDOS]: Include "msdos.h".
5086 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5087 Constify `char *' arguments and their references according to
5088 prototypes in tparam.h.
5089
5090 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5091
5092 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5093 Adapt all references accordingly.
5094
5095 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5096
5097 2011-03-11 Tom Tromey <tromey@redhat.com>
5098
5099 * buffer.c (syms_of_buffer): Remove obsolete comment.
5100
5101 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5102
5103 * termhooks.h (encode_terminal_code): Declare prototype.
5104
5105 * msdos.c (encode_terminal_code): Don't declare prototype.
5106
5107 * term.c (encode_terminal_code): Now external again, used by
5108 w32console.c and msdos.c.
5109
5110 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5111 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5112
5113 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5114
5115 Fix some minor problems found by GCC 4.5.2's static checks.
5116
5117 * fringe.c (update_window_fringes): Mark locals as initialized
5118 (Bug#8227).
5119 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5120
5121 * alloc.c (mark_fringe_data): Move decl from here ...
5122 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5123 to check its interface.
5124 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5125
5126 * fontset.c (free_realized_fontset): Now static.
5127 (Fset_fontset_font): Rename local to avoid shadowing.
5128 (fontset_font): Mark local as initialized.
5129 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5130
5131 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5132
5133 * xselect.c (x_disown_buffer_selections): Remove; not used.
5134 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5135 (x_own_selection, Fx_disown_selection_internal): Rename locals
5136 to avoid shadowing.
5137 (x_handle_dnd_message): Remove local to avoid shadowing.
5138
5139 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5140 so that the caller can use some name other than gcpro1.
5141 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5142 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5143 (Fx_backspace_delete_keys_p):
5144 Use them to avoid shadowing, and rename vars to avoid shadowing.
5145 (x_decode_color, x_set_name, x_window): Now static.
5146 (Fx_create_frame): Add braces to silence GCC warning.
5147 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5148 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5149 Remove unused locals.
5150 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5151 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5152 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5153 macros.
5154
5155 * xterm.h (x_mouse_leave): New decl.
5156
5157 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5158 Remove unused functions.
5159 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5160 (x_calc_absolute_position): Now static.
5161 (XTread_socket): Don't define label "out" unless it's used.
5162 Don't declare local "event" unless it's used.
5163 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5164 unless they are used.
5165 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5166 (x_fatal_error_signal): Remove; not used.
5167 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5168 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5169 (x_error_catcher, x_connection_closed, x_error_handler):
5170 (x_error_quitter, xembed_send_message, x_iconify_frame):
5171 (my_log_handler): Rename locals to avoid shadowing.
5172 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5173 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5174
5175 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5176 Rename or move locals to avoid shadowing.
5177 (tty_defined_color, merge_face_heights): Now static.
5178 (free_realized_faces_for_fontset): Remove; not used.
5179 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5180 does not deduce is never used uninitialized.
5181 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5182 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5183
5184 * terminal.c (store_terminal_param): Now static.
5185
5186 * xmenu.c (menu_highlight_callback): Now static.
5187 (set_frame_menubar): Remove unused local.
5188 (xmenu_show): Rename parameter to avoid shadowing.
5189 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5190 since they might point to immutable storage.
5191 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5192 since it's unused otherwise.
5193
5194 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5195 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5196 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5197 avoids a gcc -Wuninitialized diagnostic.
5198 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5199 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5200 does not deduce are never used uninitialized.
5201
5202 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5203
5204 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5205 * window.c (window_loop, size_window):
5206 (run_window_configuration_change_hook, enlarge_window): Likewise.
5207
5208 * window.c (display_buffer): Now static.
5209 (size_window): Mark variables that gcc -Wuninitialized
5210 does not deduce are never used uninitialized.
5211 * window.h (check_all_windows): New decl, to forestall
5212 gcc -Wmissing-prototypes diagnostic.
5213 * dispextern.h (bidi_dump_cached_states): Likewise.
5214
5215 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5216 shadowing.
5217 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5218 Include <limits.h>.
5219 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5220 and to avoid gcc -Wuninitialized warning.
5221 (load_charset_map): Mark variables that gcc -Wuninitialized
5222 does not deduce are never used uninitialized.
5223 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5224
5225 * coding.c (coding_set_source, coding_set_destination):
5226 Use "else { /* comment */ }" rather than "else /* comment */;"
5227 for clarity, and to avoid gcc -Wempty-body warning.
5228 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5229 a block, when the outer 'i' will do.
5230 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5231 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5232 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5233 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5234 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5235 Rename locals to avoid shadowing.
5236 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5237 * coding.c (emacs_mule_char, encode_invocation_designation):
5238 Now static, since they're not used elsewhere.
5239 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5240 (decode_coding_object, encode_coding_object, detect_coding_system):
5241 (decode_coding_emacs_mule): Mark variables that gcc
5242 -Wuninitialized does not deduce are never used uninitialized.
5243 (detect_coding_iso_2022): Initialize a local variable that might
5244 be used uninitialized. Leave a FIXME because it's not clear that
5245 this initialization is needed. (Bug#8211)
5246 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5247 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5248 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5249 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5250 Remove unused macros.
5251
5252 * category.c (hash_get_category_set): Remove unused local var.
5253 (copy_category_table): Now static, since it's not used elsewhere.
5254 * character.c (string_count_byte8): Likewise.
5255
5256 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5257 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5258
5259 * chartab.c (copy_sub_char_table): Now static, since it's not used
5260 elsewhere.
5261 (sub_char_table_ref_and_range, char_table_ref_and_range):
5262 Rename locals to avoid shadowing.
5263 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5264
5265 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5266 (BIDI_BOB): Remove unused macro.
5267
5268 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5269 deduce are never used uninitialized.
5270 * term.c (encode_terminal_code): Likewise.
5271
5272 * term.c (encode_terminal_code): Now static. Remove unused local.
5273
5274 * tparam.h: New file.
5275 * term.c, tparam.h: Include it.
5276 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5277 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5278 Move these decls to tparam.h, and make them agree with what
5279 is actually in tparam.c. The previous trick of using incompatible
5280 decls in different modules does not conform to the C standard.
5281 All callers of tparam changed to use tparam's actual API.
5282 * tparam.c (tparam1, tparam, tgoto):
5283 Use const pointers where appropriate.
5284
5285 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5286 * cm.h (struct cm): Likewise.
5287 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5288 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5289 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5290 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5291 (turn_on_face, init_tty): Likewise.
5292 * termchar.h (struct tty_display_info): Likewise.
5293
5294 * term.c (term_mouse_position): Rename local to avoid shadowing.
5295
5296 * alloc.c (mark_ttys): Move decl from here ...
5297 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5298
5299 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5300
5301 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5302
5303 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5304
5305 * search.c (compile_pattern_1): Remove argument regp, unused since
5306 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5307 (compile_pattern): Don't pass it.
5308
5309 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5310
5311 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5312 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5313 for ! HAVE_GTK3.
5314 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5315
5316 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5317
5318 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5319 gdk_window_get_screen, gdk_window_get_geometry,
5320 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5321 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5322 (xg_get_pixbuf_from_pixmap): New function.
5323 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5324 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5325 Call xg_get_pixbuf_from_pixmap instead of
5326 gdk_pixbuf_get_from_drawable.
5327 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5328 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5329 (xg_check_special_colors): Use GtkStyleContext and its functions
5330 for HAVE_GTK3.
5331 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5332 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5333 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5334 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5335 Call gtk_widget_get_preferred_size.
5336 (xg_frame_resized): gdk_window_get_geometry only takes 5
5337 parameters.
5338 (xg_win_to_widget, xg_event_is_for_menubar):
5339 Call gdk_x11_window_lookup_for_display.
5340 (xg_set_widget_bg): New function.
5341 (delete_cb): New function.
5342 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5343 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5344 (xg_set_background_color): Call xg_set_widget_bg.
5345 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5346 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5347 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5348 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5349 if ! HAVE_GTK3.
5350 (update_frame_tool_bar): Call gtk_widget_hide.
5351 (xg_initialize): Use GDK_KEY_g.
5352
5353 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5354 if ! HAVE_GTK3
5355 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5356
5357 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5358 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5359 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5360
5361 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5362
5363 * w32xfns.c (select_palette): Check success of RealizePalette against
5364 GDI_ERROR, not zero.
5365
5366 See ChangeLog.11 for earlier changes.
5367
5368 ;; Local Variables:
5369 ;; coding: utf-8
5370 ;; End:
5371
5372 Copyright (C) 2011 Free Software Foundation, Inc.
5373
5374 This file is part of GNU Emacs.
5375
5376 GNU Emacs is free software: you can redistribute it and/or modify
5377 it under the terms of the GNU General Public License as published by
5378 the Free Software Foundation, either version 3 of the License, or
5379 (at your option) any later version.
5380
5381 GNU Emacs is distributed in the hope that it will be useful,
5382 but WITHOUT ANY WARRANTY; without even the implied warranty of
5383 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5384 GNU General Public License for more details.
5385
5386 You should have received a copy of the GNU General Public License
5387 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.