1 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3 Do not limit current-time-string to years 1000..9999.
4 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5 (Fcurrent_time_string): Support any year that is supported by the
6 underlying localtime representation. Don't use asctime, as it
7 has undefined behavior for years outside the range -999..9999.
9 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
11 Fix race conditions involving setenv, gmtime, localtime, asctime.
12 Without this fix, interrupts could mess up code that uses these
13 nonreentrant functions, since setting TZ invalidates existing
14 tm_zone or tzname values, and since most of these functions return
15 pointers to static storage.
16 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
17 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
18 Grow the critical sections to include not just invoking
19 localtime/gmtime, but also accessing these functions' results
20 including their tm_zone values if any, and any related TZ setting.
21 (format_time_string): Last arg is now struct tm *, not struct tm **,
22 so that the struct tm is saved in the critical section. All
23 callers changed. Simplify allocation of initial buffer, partly
24 motivated by the fact that memory allocation needs to be outside
27 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
29 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
32 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
33 Remove duplicated buffer name initialization.
35 2012-05-02 Jim Meyering <jim@meyering.net>
37 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
39 * xfns.c (x_window): Use xstrdup (Bug#11375).
41 2012-05-02 Eli Zaretskii <eliz@gnu.org>
43 * xdisp.c (pos_visible_p): If already at a newline from the
44 display string before the 'while' loop, don't walk back the glyphs
45 from it3.glyph_row. Solves assertion violation when the display
46 string begins with a newline (egg.el). (Bug#11367)
48 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
50 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
53 2012-05-01 Glenn Morris <rgm@gnu.org>
55 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
56 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
57 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
58 All were removed before 23.1.
60 * dispnew.c: Remove HAVE_LIBNCURSES test;
61 it is always true on relevant platforms.
63 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
64 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
66 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
68 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
70 * .gdbinit (xpr): Remove checks for no longer existing misc types.
71 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
74 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
76 Do not avoid creating empty evaporating overlays (Bug#9642).
77 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
78 That is, do not delete an evaporating overlay if it becomes
79 empty after its bounds are adjusted to fit within its buffer.
80 This fix caused other problems, and I'm reverting it until we get
81 to the bottom of them.
83 2012-04-27 Chong Yidong <cyd@gnu.org>
85 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
87 2012-04-27 Eli Zaretskii <eliz@gnu.org>
89 * xdisp.c (pos_visible_p): If the window start position is beyond
90 ZV, start the display from buffer beginning. Prevents assertion
91 violation in init_iterator when the minibuffer window is scrolled
94 * window.c (window_scroll_pixel_based): Likewise.
96 2012-04-27 Chong Yidong <cyd@gnu.org>
98 * keymap.c (where_is_internal): Doc fix (Bug#10872).
100 2012-04-27 Glenn Morris <rgm@gnu.org>
102 * fileio.c (Fcopy_file, Fset_file_selinux_context):
103 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
105 2012-04-27 Eli Zaretskii <eliz@gnu.org>
107 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
108 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
110 2012-04-26 Eli Zaretskii <eliz@gnu.org>
112 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
113 display element, check also the underlying string or buffer
114 character. (Bug#11341)
116 * w32menu.c: Include w32heap.h.
117 (add_menu_item): If the call to AppendMenuW (via
118 unicode_append_menu) fails, disable Unicode menus only if we are
119 running on Windows 9X/Me.
121 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
123 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
124 (xgetint): Add missing shift for LSB tags.
126 2012-04-24 Martin Rudalics <rudalics@gmx.at>
128 * keyboard.c (read_char): Don't wipe echo area for select window
129 events: These might get delayed via `mouse-autoselect-window'
132 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
134 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
135 manipulation of :loaded-from data.
137 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
139 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
140 now a cons (bug#11311).
142 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
144 Do not create empty overlays with the evaporate property (Bug#9642).
145 * buffer.c (Fmove_overlay): Delete an evaporating overlay
146 if it becomes empty after its bounds are adjusted to fit within
147 its buffer. Without this fix, in a nonempty buffer (let ((o
148 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
149 yields an empty overlay that has the evaporate property, which is
150 not supposed to happen.
152 Fix minor GTK3 problems found by static checking.
153 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
154 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
155 (struct _EmacsFixedClass, emacs_fixed_get_type):
156 Move decls here from emacsgtkfixed.h, since they needn't be public.
157 (emacs_fixed_get_type): Now static.
158 (emacs_fixed_class_init): Omit unused local.
159 (emacs_fixed_child_type): Remove; unused.
160 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
161 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
162 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
163 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
164 (EMACS_FIXED_GET_CLASS): Remove; unused.
165 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
167 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
168 Problem reported by Juanma Barranquero for Windows -Wunused-function.
170 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
172 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
173 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
174 (__malloc_size_t, __malloc_ptrdiff_t):
175 Remove. All uses removed, replaced by the definiens if needed,
176 since we can assume C89 or better now.
177 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
178 (protect_malloc_state, align, get_contiguous_space)
179 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
180 (malloc_atfork_handler_child, malloc_enable_thread)
181 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
182 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
183 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
184 (special_realloc, _realloc_internal_nolock, _realloc_internal)
185 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
186 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
187 Define using prototypes, not old style.
188 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
189 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
190 (align): Don't assume that signed integer overflow wraps around.
191 Omit unused local var.
192 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
193 (_free_internal_nolock, memalign, mallochook, reallochook):
194 Omit no-longer-needed casts.
195 (valloc): Use getpagesize, not __getpagesize.
196 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
197 (struct hdr): The 'magic' member is now size_t, not unsigned long.
199 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
201 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
203 Move functions from C to Lisp. Make non-blocking method calls
204 the default. Implement further D-Bus standard interfaces.
206 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
207 (QCdbus_request_name_allow_replacement)
208 (QCdbus_request_name_replace_existing)
209 (QCdbus_request_name_do_not_queue)
210 (QCdbus_request_name_reply_primary_owner)
211 (QCdbus_request_name_reply_in_queue)
212 (QCdbus_request_name_reply_exists)
213 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
214 (QCdbus_registered_serial, QCdbus_registered_method)
215 (QCdbus_registered_signal): New Lisp objects.
216 (XD_DEBUG_MESSAGE): Use sizeof.
217 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
218 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
219 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
220 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
221 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
222 (xd_signature, xd_append_arg): Allow float for integer types.
223 (xd_get_connection_references): New function.
224 (xd_get_connection_address): Rename from xd_initialize.
225 Return cached address.
226 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
227 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
229 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
230 Return number of recounts.
231 (Fdbus_get_unique_name): Make stronger parameter check.
232 (Fdbus_message_internal): New defun.
233 (Fdbus_call_method, Fdbus_call_method_asynchronously)
234 (Fdbus_method_return_internal, Fdbus_method_error_internal)
235 (Fdbus_send_signal, Fdbus_register_service)
236 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
237 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
238 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
239 (Vdbus_compiled_version, Vdbus_runtime_version)
240 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
241 (Vdbus_message_type_method_return, Vdbus_message_type_error)
242 (Vdbus_message_type_signal): New defvars.
243 (Vdbus_registered_buses, Vdbus_registered_objects_table):
246 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
248 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
249 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
250 Do not assume ptrdiff_t is the same width as 'int'.
252 * alloc.c: Handle unusual debugging option combinations.
253 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
254 since the two debugging options are incompatible.
255 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
257 (mem_init, mem_insert, mem_insert_fixup):
258 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
259 (NEED_MEM_INSERT): Remove; no longer needed.
261 2012-04-22 Leo Liu <sdl.web@gmail.com>
263 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
265 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
267 * sysdep.c [__FreeBSD__]: Minor cleanups.
268 (list_system_processes, system_process_attributes) [__FreeBSD__]:
269 Use Emacs indenting style more consistently. Avoid some casts.
270 Use 'double' consistently rather than mixing 'float' and 'double'.
272 2012-04-21 Eduard Wiebe <usenet@pusto.de>
274 * sysdep.c (list_system_processes, system_process_attributes):
275 Add implementation for FreeBSD (Bug#5243).
277 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
279 * lisp.mk (lisp): Update.
281 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
283 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
284 It is never used otherwise.
286 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
288 * print.c (print_preprocess): Only check print_depth if print-circle
290 (print_object): Check for cycles even when print-circle is nil and
291 print-gensym is t, but only check print_depth if print-circle is nil.
293 2012-04-20 Chong Yidong <cyd@gnu.org>
295 * process.c (wait_reading_process_output): If EIO occurs on a pty,
296 set the status to "failed" and ensure that sentinel is run.
298 2012-04-20 Glenn Morris <rgm@gnu.org>
300 * process.c (Fset_process_inherit_coding_system_flag)
301 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
302 (Fmake_network_process, Fmake_serial_process): Doc fix.
304 2012-04-20 Eli Zaretskii <eliz@gnu.org>
306 * xdisp.c (string_buffer_position_lim): Limit starting position to
308 (set_cursor_from_row): If called for a mode-line or header-line
309 row, return zero immediately.
310 (try_cursor_movement): If inside continuation line, don't back up
311 farther than the first row after the header line, if any.
312 Don't consider the header-line row as "partially visible", even if
313 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
315 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
317 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
320 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
321 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
323 configure: new option --enable-gcc-warnings (Bug#11207)
324 * Makefile.in (C_WARNINGS_SWITCH): Remove.
325 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
326 (ALL_CFLAGS): Use new macros rather than old.
327 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
328 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
329 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
330 -Wunused-result, -Wunused-variable. This should go away once
331 the Emacs and Gnulib regex code is merged.
332 (xmalloc, xrealloc): Now static.
334 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
336 * dired.c (Fsystem_groups): Remove unused local.
338 2012-04-17 Glenn Morris <rgm@gnu.org>
340 * dired.c (Fsystem_users): Doc fix.
342 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
344 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
345 (syms_of_dired): Add them.
347 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
349 Fix minor alloc.c problems found by static checking.
350 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
351 New extern decls, to avoid calling undeclared functions.
352 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
353 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
354 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
355 (NEED_MEM_INSERT): New macro.
356 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
357 Remove one incorrect comment and fix another.
359 Fix minor ralloc.c problems found by static checking.
360 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
361 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
362 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
363 (r_alloc_sbrk): Now static.
365 Improve ralloc.c interface checking.
366 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
367 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
368 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
369 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
370 [REL_ALLOC]: ... to here, to check interface.
371 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
372 Remove decls. This fixes an "It stinks!".
374 * alloc.c (which_symbols): Fix alignment issue / type clash.
376 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
378 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
379 (struct Lisp_Misc_Any): Likewise.
380 (struct Lisp_Free): Likewise.
381 * alloc.c (union aligned_Lisp_Symbol): Define.
382 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
383 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
384 (union aligned_Lisp_Misc): Define.
385 (MARKER_BLOCK_SIZE, struct marker_block): Use union
386 aligned_Lisp_Misc instead of union Lisp_Misc.
387 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
389 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
391 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
392 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
393 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
394 * s/netbsd.h, s/sol2-6.h:
395 Remove definition of GC_MARK_STACK, since the default now works.
396 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
397 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
398 no longer the default.
399 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
401 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
403 * lread.c (lisp_file_lexically_bound_p):
404 Fix hang at ";-*-\n" (bug#11238).
406 2012-04-14 Eli Zaretskii <eliz@gnu.org>
408 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
409 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
411 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
413 * nsterm.m (constrainFrameRect): Always constrain when there is only
414 one screen (Bug#10962).
416 2012-04-13 Ken Brown <kbrown@cornell.edu>
418 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
420 2012-04-13 Reuben Thomas <rrt@sc3d.org>
422 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
424 2012-04-11 Daniel Colascione <dancol@dancol.org>
426 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
427 against is gone. It's better to use vfork now so that when Cygwin
428 gains a new, working vfork, we use it automatically (bug#10398).
430 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
432 * window.c (save_window_save): Obey window-point-insertion-type.
434 2012-04-11 Glenn Morris <rgm@gnu.org>
436 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
438 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
440 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
442 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
444 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
445 (force_quit_count): New var.
446 (handle_interrupt): Use it.
448 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
450 * w32.c (w32_delayed_load): Record the full path of the library
451 being loaded (bug#10424).
453 2012-04-09 Glenn Morris <rgm@gnu.org>
455 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
456 not just in the obarray, before snarfing them. (Bug#11036)
458 * Makefile.in ($(leimdir)/leim-list.el):
459 Pass EMACS rather than BUILT_EMACS.
461 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
463 * process.c (make_process):
464 * process.h: Add integer `gnutls_handshakes_tried' member to
467 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
468 Add convenience `GNUTLS_LOG2i' macro.
470 * gnutls.c (gnutls_log_function2i): Convenience log function.
471 (emacs_gnutls_read): Use new log functions,
472 `gnutls_handshakes_tried' process member, and
473 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
474 attempts per process (connection).
476 2012-04-09 Chong Yidong <cyd@gnu.org>
478 * eval.c (Fuser_variable_p, user_variable_p_eh)
479 (lisp_indirect_variable): Functions deleted.
480 (Fdefvar): Caller changed.
482 * callint.c (Finteractive, Fcall_interactively):
483 * minibuf.c (Fread_variable): Callers changed.
485 2012-04-09 Eli Zaretskii <eliz@gnu.org>
487 * xdisp.c (set_cursor_from_row): If the display string appears in
488 the buffer at position that is closer to point than the position
489 after the display string, display the cursor on the first glyph of
490 the display string. Fixes cursor display when a 'display' text
491 property immediately follows invisible text. (Bug#11094)
493 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
495 composite.c: use 'double' consistently
496 * composite.c (get_composition_id): Use 'double' consistently
497 instead of converting 'float' to 'double' and vice versa; this is
498 easier to understand and avoids a GCC warning.
500 2012-04-09 Glenn Morris <rgm@gnu.org>
502 * Makefile.in: Generate leim-list with bootstrap-emacs, in
503 preparation for dumping it with emacs. (Bug#4789)
504 (leimdir): New variable.
505 ($(leimdir)/leim-list.el): New rule.
506 (emacs$(EXEEXT)): Depend on leim-list.el.
508 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
509 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
510 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
512 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
514 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
517 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
519 * xml.c (init_libxml2_functions) [WINDOWSNT]:
520 Remove unused local variable.
522 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
524 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
525 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
526 (mark_memory): Mark Lisp_Objects only if pointers might hide in
527 objects, as mark_maybe_pointer will catch them otherwise.
528 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
529 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
531 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
533 Fix typo that broke non-Windows builds.
534 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
536 2012-04-07 Eli Zaretskii <eliz@gnu.org>
538 Support building on MS-Windows with libxml2.
540 * makefile.w32-in (OBJ2): Add xml.$(O).
541 (GLOBAL_SOURCES): Add xml.c.
542 ($(BLD)/xml.$(O)): New dependency list.
544 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
545 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
546 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
547 [!WINDOWSNT]: New macros.
548 (init_libxml2_functions, libxml2_loaded_p): New functions.
549 (parse_region): Call fn_xmlCheckVersion instead of using the macro
550 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
551 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
552 Calls xmlCleanupParser only if libxml2 was loaded (or statically
554 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
555 Call init_libxml2_functions before calling libxml2 functions.
556 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
558 * emacs.c: Don't include libxml/parser.h.
559 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
560 xmlCleanupParser directly.
562 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
564 2012-04-07 Eli Zaretskii <eliz@gnu.org>
566 * indent.c (Fvertical_motion): If there is a display string at
567 point, use it.vpos to compute how many lines to backtrack after
568 move_it_to point. (Bug#11133)
570 2012-04-06 Eli Zaretskii <eliz@gnu.org>
572 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
573 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
574 about subtle differences between FETCH_CHAR* and STRING_CHAR*
575 macros related to unification of CJK characters. For the details,
576 see the discussion following the message here:
577 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
579 2012-04-04 Chong Yidong <cyd@gnu.org>
581 * keyboard.c (Vdelayed_warnings_list): Doc fix.
583 2012-04-01 Eli Zaretskii <eliz@gnu.org>
585 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
586 instead of alloca. (Bug#11138)
588 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
590 * w32menu.c (is_simple_dialog): Properly check lisp types.
593 2012-03-31 Eli Zaretskii <eliz@gnu.org>
595 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
596 position we get to after a call to move_it_to fails the
597 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
598 only if we wind up in a string from display property. (Bug#11063)
600 * window.c (Fdelete_other_windows_internal): Invalidate the row
601 and column information about mouse highlight, so that redisplay
602 restores it after reallocating the glyph matrices. (Bug#7464)
604 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
605 string comes from a `display' text property, use the buffer
606 position of that property as if we actually saw that position in
608 (move_it_by_lines): Remove the assertion that
609 "it->current_x == 0 && it->hpos == 0" which can be legitimately
610 violated when there's a before-string at the beginning of a line.
613 2012-03-30 Eli Zaretskii <eliz@gnu.org>
615 * xdisp.c (append_space_for_newline): If the default face was
616 remapped, use the remapped face for the appended newline.
617 (extend_face_to_end_of_line): Use the remapped default face for
618 extending the face to the end of the line.
619 (display_line): Call extend_face_to_end_of_line when the default
620 face was remapped. (Bug#11068)
622 2012-03-29 Eli Zaretskii <eliz@gnu.org>
624 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
626 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
628 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
630 2012-03-27 Glenn Morris <rgm@gnu.org>
632 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
635 2012-03-26 Kenichi Handa <handa@m17n.org>
637 * dispextern.h (struct glyph): Fix previous change. Change the
638 bit length of glyphless.ch to 25 (Bug#11082).
640 2012-03-26 Chong Yidong <cyd@gnu.org>
642 * keyboard.c (Vselection_inhibit_update_commands): New variable.
643 (command_loop_1): Use it; inhibit selection update for
644 handle-select-window too (Bug#8996).
646 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
648 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
650 2012-03-25 Kenichi Handa <handa@m17n.org>
652 * dispextern.h (struct glyph): Change the bit length of
653 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
655 2012-03-24 Eli Zaretskii <eliz@gnu.org>
657 * s/ms-w32.h (tzname): Include time.h before redirecting to
658 _tzname. Fixes the MSVC build. (Bug#9960)
660 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
662 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
665 * xterm.c (XTread_socket): Only modify handling_signal if
666 !SYNC_INPUT. (Bug#11080)
668 2012-03-23 Eli Zaretskii <eliz@gnu.org>
670 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
671 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
672 when fetching a multibyte character consumes more bytes than
673 CHAR_BYTES returns, due to unification of CJK characters in
674 string_char. (Bug#11073)
676 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
678 * process.c (wait_reading_process_output): Handle pty disconnect
679 by refraining from sending oneself a SIGCHLD (bug#10933).
681 2012-03-22 Chong Yidong <cyd@gnu.org>
683 * dispextern.h (struct it): New member string_from_prefix_prop_p.
685 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
686 Mark string as coming from a prefix property.
687 (handle_face_prop): Use default face for prefix strings (Bug#4281).
688 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
690 2012-03-21 Chong Yidong <cyd@gnu.org>
692 * xfaces.c (Vface_remapping_alist): Doc fix.
694 2012-03-20 Eli Zaretskii <eliz@gnu.org>
696 * w32proc.c (Fw32_set_console_codepage)
697 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
700 2012-03-20 Chong Yidong <cyd@gnu.org>
702 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
703 to reflect default non-nil value of redisplay-dont-pause.
705 2012-03-19 Kenichi Handa <handa@m17n.org>
707 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
708 it fit in a valid range (Bug#11003).
710 2012-03-18 Eli Zaretskii <eliz@gnu.org>
712 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
713 that is not from display property, accept the row as a "cursor
714 row" if one of the string's character has a non-nil `cursor'
715 property. Fixes cursor positioning when there are newlines in
716 overlay strings, e.g. in icomplete.el. (Bug#11035)
718 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
720 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
722 2012-03-12 Chong Yidong <cyd@gnu.org>
724 * eval.c (inhibit_lisp_code): Rename from
725 inhibit_window_configuration_change_hook; move from window.c.
727 * xfns.c (unwind_create_frame_1, Fx_create_frame):
728 * window.c (run_window_configuration_change_hook)
729 (syms_of_window): Callers changed.
731 2012-03-11 Chong Yidong <cyd@gnu.org>
733 * keymap.c (Fkey_description): Doc fix (Bug#9700).
735 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
737 2012-03-10 Chong Yidong <cyd@gnu.org>
739 * frame.c (other_visible_frames): Don't assume the selected frame
740 is visible (Bug#10955).
742 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
744 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
746 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
748 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
749 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
752 2012-03-03 Glenn Morris <rgm@gnu.org>
754 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
756 2012-03-02 Eli Zaretskii <eliz@gnu.org>
758 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
759 position past the first glyph_row that ends at ZV. (Bug#10902)
760 (redisplay_window, next_element_from_string): Fix typos in
762 (redisplay_window): Pass to move_it_vertically the margin in
763 pixels, not in screen lines.
765 2012-03-02 Glenn Morris <rgm@gnu.org>
767 * buffer.c (buffer-list-update-hook): Doc fix.
769 2012-02-29 Eli Zaretskii <eliz@gnu.org>
771 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
772 push_it before setting up the iterator for the first overlay
773 string, even if we have an empty string loaded.
774 (next_overlay_string): If there's an empty string on the iterator
775 stack, pop the stack. (Bug#10903)
777 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
779 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
780 Suggested by Stefan Monnier in
781 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
782 * alloc.c (widen_to_Lisp_Object): New static function.
783 (mark_memory): Also mark Lisp_Objects by fetching pointer words
784 and widening them to Lisp_Objects. This would work even if
785 USE_LSB_TAG is defined and wide integers are used, which might
786 happen in a future version of Emacs.
788 2012-02-25 Chong Yidong <cyd@gnu.org>
790 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
793 * xselect.c (Fx_selection_exists_p): Doc fix.
794 (x_clipboard_manager_save_all): Print an informative message
795 before saving to clipboard manager.
797 2012-02-24 Chong Yidong <cyd@gnu.org>
799 * keyboard.c (process_special_events): Handle all X selection
800 requests in kbd_buffer, not just the next one (Bug#8869).
802 2012-02-23 Chong Yidong <cyd@gnu.org>
804 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
805 call when setting menu-bar-lines and tool-bar-lines parameters.
806 (unwind_create_frame_1): New helper function.
808 * window.c (inhibit_window_configuration_change_hook): New var.
809 (run_window_configuration_change_hook): Obey it.
810 (syms_of_window): Initialize it.
812 2012-02-22 Chong Yidong <cyd@gnu.org>
814 * xterm.c (x_draw_image_relief): Add missing type check for
815 Vtool_bar_button_margin (Bug#10743).
817 2012-02-21 Chong Yidong <cyd@gnu.org>
819 * fileio.c (Vfile_name_handler_alist): Doc fix.
821 * buffer.c (Fget_file_buffer): Protect against invalid file
822 handler return value.
824 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
826 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
827 when computing $valmask.
829 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
830 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
831 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
832 It's useless in that case, and it can cause problems on hosts
833 that allocate halves of EMACS_INT values separately.
834 Reported by Dan Horák. Diagnosed by Andreas Schwab in
835 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
836 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
837 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
838 it avoids undefined behavior on hosts where shifting right by more
839 than the word width has undefined behavior.
841 2012-02-19 Chong Yidong <cyd@gnu.org>
843 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
844 (Funhandled_file_name_directory, Ffile_name_as_directory)
845 (Fdirectory_file_name, Fexpand_file_name)
846 (Fsubstitute_in_file_name): Protect against invalid file handler
847 return values (Bug#10845).
849 2012-02-18 Eli Zaretskii <eliz@gnu.org>
851 * .gdbinit (pitx): Fix incorrect references to fields of the
854 2012-02-17 Chong Yidong <cyd@gnu.org>
856 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
858 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
860 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
861 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
863 2012-02-15 Chong Yidong <cyd@gnu.org>
865 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
866 marked as special. Also, starting docstrings with * is obsolete.
868 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
870 * gnutls.c (emacs_gnutls_write): Fix last change.
872 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
874 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
877 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
879 * keymap.c (Fsingle_key_description): Handle char ranges.
881 2012-02-12 Chong Yidong <cyd@gnu.org>
883 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
884 as that creates a dangerous corner case.
886 * window.c (Fdelete_window_internal): Invalidate the mouse
887 highlight (Bug#9904).
889 2012-02-12 Glenn Morris <rgm@gnu.org>
891 * xselect.c (Fx_own_selection_internal)
892 (Fx_get_selection_internal, Fx_disown_selection_internal)
893 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
894 * nsselect.m (Fx_own_selection_internal)
895 (Fx_disown_selection_internal, Fx_selection_exists_p)
896 (Fx_selection_owner_p, Fx_get_selection_internal):
897 Sync docs and argument specs with the xselect.c versions.
899 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
901 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
903 2012-02-11 Eli Zaretskii <eliz@gnu.org>
905 * w32select.c (Fx_selection_exists_p): Sync doc string and
906 argument list with xselect.c. (Bug#10783)
908 * w16select.c (Fx_selection_exists_p): Sync doc string and
909 argument list with xselect.c. (Bug#10783)
911 2012-02-10 Glenn Morris <rgm@gnu.org>
913 * fns.c (Fsecure_hash): Doc fix.
915 2012-02-09 Kenichi Handa <handa@m17n.org>
917 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
919 2012-02-07 Chong Yidong <cyd@gnu.org>
921 * buffer.c (Fbuffer_local_variables)
922 (buffer_lisp_local_variables): Handle unbound vars correctly;
923 don't let Qunbound leak into Lisp.
925 2012-02-07 Glenn Morris <rgm@gnu.org>
927 * image.c (Fimagemagick_types): Doc fix.
929 * image.c (imagemagick-render-type): Change it from a lisp object
930 to an integer. Move the doc here from the lisp manual.
931 Treat all values not equal to 0 the same.
933 2012-02-06 Chong Yidong <cyd@gnu.org>
935 * doc.c (store_function_docstring): Avoid applying docstring of
936 alias to base function (Bug#2603).
938 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
940 * .gdbinit (pp1, pv1): Remove redundant defines.
943 2012-02-04 Chong Yidong <cyd@gnu.org>
945 * nsterm.m: Declare a global (Bug#10694).
947 2012-02-04 Eli Zaretskii <eliz@gnu.org>
949 * w32.c (get_emacs_configuration_options):
950 Include --enable-checking, if specified, in the return value.
952 2012-02-04 Martin Rudalics <rudalics@gmx.at>
954 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
955 after rounding frame sizes. (Bug#9723)
957 2012-02-04 Eli Zaretskii <eliz@gnu.org>
959 * keyboard.c (adjust_point_for_property): Don't position point
960 before BEGV. (Bug#10696)
962 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
964 Handle overflow when computing char display width (Bug#9496).
965 * character.c (char_width): Return EMACS_INT, not int.
966 (char_width, c_string_width): Check for overflow when
967 computing the width; this is possible now that individual
968 characters can have unbounded width. Problem introduced
969 by merge from Emacs 23 on 2012-01-19.
971 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
973 * dbusbind.c (Fdbus_register_method): Mention the return value
974 :ignore in the docstring.
976 2012-02-02 Glenn Morris <rgm@gnu.org>
978 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
980 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
981 Unconditionally set to t. (Bug#10673)
982 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
983 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
984 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
986 2012-02-02 Kenichi Handa <handa@m17n.org>
988 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
989 0, do not call append_composite_glyph.
991 2012-02-02 Kenichi Handa <handa@m17n.org>
993 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
995 (x_produce_glyphs): If the component of a composition is a null
996 string, set it->pixel_width to 1 to avoid zero-width glyph.
998 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1000 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1001 first 2 arguments are identical. This makes inserting large
1002 output from a subprocess an order of magnitude faster on
1003 MS-Windows, where all sbrk'ed memory is always contiguous.
1005 2012-01-31 Glenn Morris <rgm@gnu.org>
1007 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1008 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1009 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1011 2012-01-29 Glenn Morris <rgm@gnu.org>
1013 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1015 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1017 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1019 2012-01-28 Chong Yidong <cyd@gnu.org>
1021 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1023 2012-01-26 Chong Yidong <cyd@gnu.org>
1025 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1027 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1028 repeat counts (Bug#10507).
1030 2012-01-26 Glenn Morris <rgm@gnu.org>
1032 * lread.c (syms_of_lread): Doc fix.
1034 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1036 * coding.c (encode_designation_at_bol): Change return value to
1039 2012-01-25 Chong Yidong <cyd@gnu.org>
1041 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1043 2012-01-21 Chong Yidong <cyd@gnu.org>
1045 * floatfns.c (Fcopysign): Make the second argument non-optional,
1046 since nil is not allowed anyway.
1048 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1050 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1051 (send_process): Likewise.
1053 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1055 * window.c (save_window_save, Fcurrent_window_configuration)
1056 (Vwindow_persistent_parameters): Do not use Qstate.
1057 Rewrite doc-strings.
1059 2012-01-19 Kenichi Handa <handa@m17n.org>
1061 * character.c (char_width): New function.
1062 (Fchar_width, c_string_width, lisp_string_width):
1063 Use char_width (Bug#9496).
1065 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1067 * window.c (Vwindow_persistent_parameters): New variable.
1068 (Fset_window_configuration, save_window_save): Handle persistent
1071 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1073 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1074 thrashing the stack of the thread. (Bug#9087)
1076 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1078 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1080 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1082 * xdisp.c (rows_from_pos_range): Handle the case where the
1083 highlight ends on a newline. (Bug#10464)
1084 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1085 he end column for display of highlight that ends on a newline
1088 2012-01-11 Glenn Morris <rgm@gnu.org>
1090 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1091 from load-path also when installation-directory is nil. (Bug#10208)
1093 2012-01-10 Glenn Morris <rgm@gnu.org>
1095 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1097 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1098 Update template values to be closer to their typical values these days.
1100 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1102 * xdisp.c (rows_from_pos_range): Accept additional argument
1103 DISP_STRING, and accept any glyph in a row whose object is that
1104 string as eligible for mouse highlight. Fixes mouse highlight of
1105 display strings from overlays. (Bug#10464)
1107 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1109 emacs: fix an auto-save permissions race condition (Bug#10400)
1110 * fileio.c (auto_saving_dir_umask): New static var.
1111 (Fmake_directory_internal): Use it.
1112 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1113 creating the directory. The old code temporarily assigns
1114 too-generous permissions to the directory.
1115 (do_auto_save_eh): Clear it.
1116 (Fdo_auto_save): Catch all errors, not just file errors, so
1117 that the var is always cleared.
1119 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1121 * search.c (scan_buffer): Pass character positions to
1122 know_region_cache, not byte positions. (Bug#6540)
1124 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1126 * w32.c (sys_rename): Report EXDEV when rename of a directory
1127 fails because the target is on another logical disk. (Bug#10284)
1129 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1131 * xterm.c (x_embed_request_focus): New function.
1133 * xterm.h: Add prototype.
1135 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1137 2012-01-05 Glenn Morris <rgm@gnu.org>
1139 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1141 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1143 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1144 Load gnutls_transport_set_lowat only if GnuTLS version is below
1146 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1147 GnuTLS versions below 2.11.1.
1149 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1151 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1152 to the doc string advising against its use for altering the way
1153 windows are scrolled.
1155 2011-12-28 Kenichi Handa <handa@m17n.org>
1157 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1158 coding-system ASCII compatible only when it does not produce BOM
1159 on encoding (Bug#10383).
1161 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1163 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1165 (create_and_show_popup_menu): Always use menu_position_func for
1168 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1170 * callint.c (Fcall_interactively): Don't truncate prompt string.
1172 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1174 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1175 property that ends at ZV, so that the bidi iteration could be
1176 resumed from there (after widening). (Bug#10360)
1178 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1180 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1182 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1184 * nsterm.m (x_free_frame_resources):
1185 Release f->output_data.ns->miniimage.
1186 (ns_index_color): Fix indentation. Do not retain
1187 color_table->colors[i].
1189 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1192 * nsfns.m (x_set_background_color): Assign return value from
1193 ns_index_color to face-background instead of NSColor*.
1194 (ns_implicitly_set_icon_type): Fix indentation.
1195 Change assignment in for loop to comparison.
1197 * emacs.c (ns_pool): New variable.
1198 (main): Assign ns_pool.
1199 (Fkill_emacs): Call ns_release_autorelease_pool.
1201 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1202 autorelease fdesc, release fdAttrs and tdict.
1203 (ns_get_covering_families): Release charset.
1204 (ns_findfonts): Release NSFontDescriptor created with new.
1205 (ns_uni_to_glyphs): Fix indentation.
1206 (setString): Release attrStr before assigning new value.
1208 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1210 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1212 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1213 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1215 2011-12-18 David Reitter <reitter@cmu.edu>
1217 * nsterm.m (ns_term_init): Subscribe for notifications
1218 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1219 to method trackingNotification in EmacsMenu.
1221 * nsmenu.m (trackingMenu): New variable.
1222 (trackingNotification): New method (from Aquamacs).
1223 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1224 from Aquamacs (Bug#7030).
1226 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1228 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1229 (symbol_to_nsstring): Fix indentation.
1230 (ns_symbol_to_pb): New function.
1231 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1232 (Fns_rotate_cut_buffers_internal): Remove.
1233 (Fns_store_selection_internal): Rename from
1234 Fns_store_cut_buffer_internal.
1235 (ns_get_foreign_selection, Fx_own_selection_internal)
1236 (Fx_disown_selection_internal, Fx_selection_exists_p)
1237 (Fns_get_selection_internal, Fns_store_selection_internal):
1238 Use ns_symbol_to_pb and check if return value is nil.
1239 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1240 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1241 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1242 renamed to Sns_store_selection_internal.
1243 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1244 and remove this function.
1245 (ns_handle_selection_clear): Remove, never used.
1246 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1249 2011-12-17 Ken Brown <kbrown@cornell.edu>
1251 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1252 GID is unknown (Bug#10257).
1254 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1256 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1257 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1258 which caused a build failure on GNU/Linux IA-64. This problem was
1259 introduced by my 2011-10-07 patch.
1261 2011-12-15 Juri Linkov <juri@jurta.org>
1263 * image.c (imagemagick_error): New function. (Bug#10112)
1264 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1265 Use `imagemagick_error' where ImageMagick functions return
1267 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1270 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1272 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1273 fill background (Bug#8992).
1275 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1277 * window.c (Vwindow_combination_resize)
1278 (Vwindow_combination_limit): Use t instead of non-nil in
1280 (Vrecenter_redisplay): Add first sentence of doc-string on
1282 (Frecenter): Fix doc-string typo.
1284 2011-12-11 Kenichi Handa <handa@m17n.org>
1286 * coding.c (Funencodable_char_position): Pay attention to the
1287 buffer text relocation (Bug#9389).
1289 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1291 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1292 gtk_init (Bug#10100).
1294 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1296 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1297 IT->string is nil. (Bug#10263)
1299 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1301 * nsterm.h (x_free_frame_resources): Declare.
1303 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1304 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1306 * nsterm.h (ns_get_defaults_value): Declare.
1308 * nsterm.m (ns_default): Call ns_get_defaults_value.
1310 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1312 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1315 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1317 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1318 that where the value of an _OBJC_* symbol points to is in the .bss
1319 section (Bug#10240).
1321 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1323 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1324 after the loop to call ccl_driver at least once (Bug#8619).
1326 2011-12-08 Kenichi Handa <handa@m17n.org>
1328 * ftfont.c (get_adstyle_property): Fix previous change
1331 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1333 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1334 dirs from the default value of EMACSLOADPATH (bug#10208).
1336 2011-12-07 Glenn Morris <rgm@gnu.org>
1338 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1339 installation and source directories as well. (Bug#10208)
1341 2011-12-06 Chong Yidong <cyd@gnu.org>
1343 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1345 2011-12-06 Glenn Morris <rgm@gnu.org>
1347 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1348 as an error, not just -1. (Bug#10217)
1350 2011-12-05 Chong Yidong <cyd@gnu.org>
1352 * keyboard.c (process_special_events): New function.
1353 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1355 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1357 * coding.c (encode_designation_at_bol): Don't use uninitialized
1358 local variable (Bug#9318).
1360 2011-12-05 Kenichi Handa <handa@m17n.org>
1362 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1363 return Qnil (Bug#8046, Bug#10193).
1365 2011-12-05 Kenichi Handa <handa@m17n.org>
1367 * coding.c (encode_designation_at_bol): New args charbuf_end and
1368 dst. Return the number of produced bytes. Callers changed.
1369 (coding_set_source): Return how many bytes coding->source was
1371 (coding_set_destination): Return how many bytes
1372 coding->destination was relocated.
1373 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1374 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1376 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1378 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1379 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1382 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1384 The following changes are to fix Bug#9318.
1386 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1387 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1388 (encode_coding_iso_2022, encode_coding_sjis)
1389 (encode_coding_big5, encode_coding_charset): Use the above macros.
1391 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1393 * lisp.h (process_quit_flag): Fix external declaration.
1395 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1397 Don't macro-inline non-performance-critical code.
1398 * eval.c (process_quit_flag): New function.
1399 * lisp.h (QUIT): Use it.
1401 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1403 * nsfns.m (get_geometry_from_preferences): New function.
1404 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1406 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1408 * emacs.c (Qkill_emacs): Define.
1409 (syms_of_emacs): Initialize it.
1410 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1411 Qquit_flag to `kill-emacs' instead.
1412 (quit_throw_to_read_char): Add parameter `from_signal'.
1413 All callers changed. Call Fkill_emacs if requested and safe.
1414 * lisp.h (QUIT): Call Fkill_emacs if requested.
1416 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1418 * widget.c (update_wm_hints): Return if wmshell is null.
1419 (widget_update_wm_size_hints): New function.
1421 * widget.h (widget_update_wm_size_hints): Declare.
1423 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1424 widget_update_wm_size_hints (Bug#10104).
1426 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1428 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1429 before a newline, prepare the bidi iterator for consuming the
1430 newline, and keep the current paragraph direction. (Bug#10183)
1431 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1433 2011-12-02 Juri Linkov <juri@jurta.org>
1435 * search.c (Fword_search_regexp): New Lisp function created from
1436 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1437 (Fword_search_backward, Fword_search_forward)
1438 (Fword_search_backward_lax, Fword_search_forward_lax):
1439 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1440 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1442 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1444 * fileio.c (Finsert_file_contents): Move after-change-function call
1445 to before the "handled:" label, since all "goto handled" appear in
1446 cases where the *-change-functions have already been properly called
1449 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1451 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1452 waiting for input. (Bug#10169)
1454 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1456 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1457 verifies glyph row's hash code--we have just reallocated the
1458 glyphs, so their contents can be complete garbage. (Bug#10164)
1460 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1462 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1464 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1466 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1467 attributes are tested _before_ calling verify_row_hash, to protect
1468 against GCC re-ordering of the tests. (Bug#10164)
1470 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1472 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1474 * xterm.c (handle_one_xevent): Only set async_visible and friends
1475 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1476 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1477 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1479 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1481 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1482 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1483 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1484 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1485 All uses changed to use GCPRO1 etc.
1486 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1487 Revert to old implementation (i.e., before 2011-03-11).
1489 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1491 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1492 of scroll runs so as to avoid assigning disabled bogus rows and
1493 unnecessary graphics copy operations.
1495 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1497 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1498 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1499 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1500 (malloc, free, realloc, calloc): Redirect to e_* only when
1503 * lisp.h (GCTYPEBITS): Move before first use.
1504 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1505 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1506 this macro definition.
1508 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1511 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1513 * gtkutil.c (xg_create_frame_widgets):
1514 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1515 present with Gtk+ 2.0.
1517 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1519 * fileio.c (Finsert_file_contents): Undo previous change; see
1520 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1522 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1524 Rename locals to avoid shadowing.
1525 * fileio.c (Finsert_file_contents):
1526 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1527 * process.c (wait_reading_process_output):
1528 Rename inner 'proc' to 'p' to avoid shadowing.
1529 Indent for consistency with usual Emacs style.
1531 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1533 * xdisp.c (redisplay_window): If cursor row is not fully visible
1534 after recentering, and scroll-conservatively is set to a large
1535 number, scroll window by a few more lines to make the cursor fully
1536 visible and out of scroll-margin. (Bug#10105)
1537 (start_display): Don't move to the next line if the display should
1538 start at a newline that is part of a display vector or an overlay
1541 2011-11-24 Juri Linkov <juri@jurta.org>
1543 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1544 after the `MagickPingImage' call. (Bug#10112)
1546 2011-11-23 Chong Yidong <cyd@gnu.org>
1548 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1550 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1552 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1553 making another buffer current. (Bug#10114)
1555 2011-11-23 Glenn Morris <rgm@gnu.org>
1557 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1559 2011-11-23 Chong Yidong <cyd@gnu.org>
1561 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1562 using it (Bug#5984).
1564 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1566 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1567 and header-lines, as they don't have one computed for them.
1570 * .gdbinit (prow): Make displayed values more self-explaining.
1571 Add row's hash code.
1573 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1575 * process.c (wait_reading_process_output): Fix asynchrounous
1576 GnuTLS socket handling on some versions of the GnuTLS library.
1577 (wait_reading_process_output): Add comment and URL.
1579 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1581 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1583 2011-11-21 Chong Yidong <cyd@gnu.org>
1585 * window.c (Fnext_window, Fprevious_window): Doc fix.
1587 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1589 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1591 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1593 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1595 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1597 * window.c (Fset_window_combination_limit): Rename argument
1599 (Vwindow_combination_limit): Remove "status" from doc-string.
1601 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1603 * m/ibms390.h: Remove.
1604 * m/ibms390x.h: Don't include "ibms390.h".
1606 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1608 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1609 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1611 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1613 * casetab.c (Fset_case_table):
1614 * charset.c (Fcharset_after): Fix typos.
1616 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1618 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1619 Otherwise, valgrind does not work on some platforms.
1620 Problem reported by Andreas Schwab in
1621 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1622 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1623 is set, removing the need for VIRT_ADDRESS_VARIES.
1624 (PURE_P): Use a more-efficient implementation that needs just one
1625 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1626 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1627 to 4 (xorl, subq, cmpq, setbe).
1628 * alloc.c (pure): Always extern now, since that's the
1629 VIRT_ADDR_VARIES behavior.
1630 (PURE_POINTER_P): Use a single comparison, not two, for
1631 consistency with the new puresize.h.
1632 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1633 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1634 Remove VIRT_ADDR_VARIES no longer needed.
1636 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1638 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1639 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1640 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1641 behave as if the cursor position were at the window margin.
1643 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1644 and the cursor position is out of bounds, behave as if the cursor
1645 position were at the window margin. (Bug#10075)
1647 2011-11-18 Chong Yidong <cyd@gnu.org>
1649 * window.c (Fwindow_combination_limit): Make first argument
1650 non-optional, since it is meaningless for live windows like the
1653 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1655 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1657 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1659 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1660 (graft_intervals_into_buffer): Simplify.
1662 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1664 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1665 hash values of the two rows.
1666 (copy_row_except_pointers): Preserve the used[] arrays and the
1667 hash values of the two rows. (Bug#10035)
1668 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1670 * xdisp.c (row_hash): New function, body extracted from
1671 compute_line_metrics.
1672 (compute_line_metrics): Call row_hash, instead of computing the
1675 * dispnew.c (verify_row_hash): Call row_hash for computing the
1676 hash code of a row, instead of duplicating code from xdisp.c.
1678 * dispextern.h (row_hash): Add prototype.
1680 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1682 * frame.c (delete_frame): Don't delete the terminal when the last
1683 X frame is closed if emacs is built with GTK toolkit.
1685 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1687 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1689 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1691 * window.c (Vwindow_splits): Rename to
1692 Vwindow_combination_resize. Suggested by Juri Linkov.
1693 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1696 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1698 * nsfns.m (Fns_font_name):
1699 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1701 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1703 * window.h (window): Rename slot "nest" to "combination_limit".
1704 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1705 (Fset_window_nest): Rename to Fset_window_combination_limit.
1706 (Vwindow_nest): Rename to Vwindow_combination_limit.
1707 (recombine_windows, make_parent_window, make_window)
1708 (Fsplit_window_internal, saved_window)
1709 (Fset_window_configuration, save_window_save): Rename all
1710 occurrences of window_nest to window_combination_limit.
1712 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1714 * image.c (imagemagick_load_image): Fix typo.
1716 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1718 * xdisp.c (display_line): Move the call to
1719 highlight_trailing_whitespace before the call to
1720 compute_line_metrics, since the latter needs to see the final
1721 faces of all the glyphs to compute ROW's hash value.
1722 Fixes assertion violations in row_equal_p. (Bug#10035)
1724 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1726 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1727 just return (bug#10044).
1729 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1731 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1732 with user-defined heap size. Bump the default size of the temacs
1733 heap to 27MB, to avoid memory warning when running temacs.
1734 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1736 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1737 current_matrix and desired_matrix. (Bug#9990)
1738 (verify_row_hash) [XASSERTS]: New function.
1739 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1740 that the hash value of glyph rows is correct.
1742 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1744 * window.h (window): Remove splits slot.
1745 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1746 (Fdelete_other_windows_internal, make_parent_window)
1747 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1748 (Fset_window_configuration, save_window_save): Don't deal with
1749 split status of windows.
1750 (saved_window): Remove splits slot.
1751 (Vwindow_splits): Rewrite doc-string.
1753 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1755 * xfns.c (unwind_create_frame):
1756 * nsfns.m (unwind_create_frame):
1757 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1758 Vframe_list (Bug#9999).
1760 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1762 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1764 2011-11-11 Kenichi Handa <handa@m17n.org>
1766 * callproc.c (Fcall_process): Set the member dst_multibyte of
1769 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1771 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1772 avoid a crash (bug#9496).
1774 2011-11-09 Chong Yidong <cyd@gnu.org>
1776 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1777 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1779 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1781 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1783 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1785 Avoid some portability problems by eschewing 'extern inline' functions.
1786 The trivial performance wins aren't worth the portability hassles; see
1787 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1789 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1790 (window_box_width, window_box_left, window_box_left_offset)
1791 (window_box_right, window_box_right_offset): Undo previous change,
1792 by removing the "extern"s.
1793 * intervals.c (adjust_intervals_for_insertion)
1794 (adjust_intervals_for_deletion): Undo previous change,
1795 making these static again.
1796 (offset_intervals, temp_set_point_both, temp_set_point)
1797 (copy_intervals_to_string): No longer inline.
1798 * xdisp.c (window_text_bottom_y, window_box_width)
1799 (window_box_height, window_box_left_offset)
1800 (window_box_right_offset, window_box_left, window_box_right)
1801 (window_box): No longer inline.
1803 2011-11-08 Chong Yidong <cyd@gnu.org>
1805 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1806 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1807 Signal an error if not a live window.
1808 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1809 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1811 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1813 * lisp.h (syms_of_abbrev): Remove declaration.
1814 Reported by CHENG Gao <chenggao@royau.me>.
1816 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1818 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1819 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1820 of temacs in GUI mode.
1822 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1824 * window.h: Declare delete_all_child_windows instead of
1825 delete_all_subwindows.
1826 * window.c (Fwindow_nest, Fset_window_nest)
1827 (Fset_window_new_total, Fset_window_new_normal)
1828 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1829 (delete_all_subwindows): Rename to delete_all_child_windows.
1830 (Fdelete_other_windows_internal, Fset_window_configuration):
1831 Call delete_all_child_windows instead of delete_all_subwindows.
1832 * frame.c (delete_frame): Call delete_all_child_windows instead
1833 of delete_all_subwindows.
1835 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1837 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1838 This is also needed for porting to any host where GC_MARK_STACK is
1839 not GC_MAKE_GCPROS_NOOPS.
1840 (which_symbols): Use it.
1842 2011-11-07 Kenichi Handa <handa@m17n.org>
1844 * coding.c (coding_set_destination): Check coding->src_pos only
1845 when coding->src_object is a buffer (bug#9910).
1847 * process.c (send_process): Set the member src_multibyte of coding
1848 to 0 (bug#9911) when sending a unibyte text.
1850 * callproc.c (Fcall_process): Set the member src_multibyte of
1851 process_coding to 0 (bug#9912).
1853 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1855 * xmenu.c (cleanup_widget_value_tree): New function.
1856 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1857 calling free_menubar_widget_value_tree directly (Bug#9830).
1859 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1861 Fix some portability problems with 'inline'.
1862 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1863 (window_box_width, window_box_left, window_box_left_offset)
1864 (window_box_right, window_box_right_offset): Declare extern.
1865 Otherwise, these inline functions do not conform to C99 and
1866 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1867 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1868 * intervals.c (adjust_intervals_for_insertion)
1869 (adjust_intervals_for_deletion): Now extern, because otherwise the
1870 extern inline functions 'offset_intervals' couldn't refer to it.
1871 (static_offset_intervals): Remove.
1872 (offset_intervals): Rewrite using the old contents of
1873 static_offset_intervals. The old version didn't conform to C99
1874 because an extern inline function contained a reference to an
1875 identifier with static linkage.
1877 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1879 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1882 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1884 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1885 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1886 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1887 return Qleft_to_right.
1889 2011-11-06 Chong Yidong <cyd@gnu.org>
1891 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1892 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1893 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1894 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1895 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1896 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1897 (Fwindow_vscroll): Doc fix.
1898 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1899 argument, since it makes no sense to pass a live window and for
1900 consistency with window-child.
1902 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1904 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1907 2011-11-05 Jason Rumney <jasonr@gnu.org>
1909 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1910 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1912 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1913 bitwise arithmetic preventing use of unicode-sip and non-truetype
1916 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1918 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1921 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1922 initialization code to keep similarity to xfns.c after changes
1925 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1927 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1928 (unwind_create_frame): New function (Bug#9943).
1929 (Fx_create_frame): Restructure code to be more similar to the one in
1930 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1931 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1932 Move terminal->reference_count++ just before making the frame official
1935 * nsterm.m (x_free_frame_resources): New function.
1936 (x_destroy_window): Move code to x_free_frame_resources.
1938 * xfns.c (unwind_create_frame): Fix comment.
1939 (Fx_create_frame, x_create_tip_frame):
1940 Move terminal->reference_count++ just before making the frame
1941 official. Move initialization of image_cache_refcount and
1942 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1944 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1946 Support MSVC build with newer versions of Visual Studio.
1947 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1948 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1951 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1952 which are not supported by MSVC.
1953 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1954 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1956 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1958 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1960 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1962 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1964 Support MSVC build with newer versions of Visual Studio.
1965 * w32.c: Don't include w32api.h for MSVC.
1966 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1968 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1969 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1970 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1971 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1973 (alloca) [_MSC_VER]: Define to _alloca.
1975 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1977 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1979 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1981 * xdisp.c (note_mouse_highlight): If either of
1982 previous/next-single-property-change returns nil, treat that as
1983 the beginning or the end of the buffer. (Bug#9955)
1985 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1987 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1988 label is not null (Bug#9951).
1989 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1992 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1994 * window.c (Fwindow_body_size): Mention in the doc string that the
1995 return value is in frame's canonical units. (Bug#9949)
1997 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1999 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2001 * w32fns.c (unwind_create_frame): If needed, free the glyph
2002 matrices of the partially constructed frame. (Bug#9943)
2003 * xfns.c (unwind_create_frame): Likewise.
2005 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2007 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2008 Don't stop backward scan on the continuation glyph, even though
2009 its CHARPOS is positive.
2010 (mouse_face_from_buffer_pos, note_mouse_highlight):
2011 Rename cover_string to disp_string.
2013 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2015 * window.c (temp_output_buffer_show): Don't use
2016 Vtemp_buffer_show_specifiers.
2017 (Vtemp_buffer_show_specifiers): Remove unused variable.
2019 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2021 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2022 past the beginning of the current glyph matrix.
2024 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2026 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2027 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2028 HAVE_GTK3 (Bug#9869).
2030 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2031 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2033 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2035 * xterm.c: Declare x_handle_net_wm_state to return int.
2036 (handle_one_xevent): Check if we are iconified but don't have
2037 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2038 (get_current_wm_state): Return non-zero if not hidden,
2039 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2040 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2041 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2042 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2044 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2046 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2047 so that this new function doesn't get optimized away by a
2048 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2050 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2052 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2054 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2056 Fix the `xbytecode' command.
2057 * .gdbinit (xprintbytestr): New command.
2058 (xwhichsymbols): Rename from `which'; all callers changed.
2059 (xbytecode): Print the byte-code string as well.
2061 2011-10-29 Kim Storm <storm@cua.dk>
2063 * alloc.c (which_symbols): New function.
2065 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2067 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2070 2011-10-29 Glenn Morris <rgm@gnu.org>
2072 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2073 Not clear what it was for, and it causes various bugs. (Bug#9839)
2075 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2077 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2078 possible random value that matches one of those tested as
2079 condition to clear the mouse face.
2081 2011-10-28 Chong Yidong <cyd@gnu.org>
2083 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2085 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2087 * window.c (make_window): Initialize phys_cursor_on_p.
2089 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2091 * lisp.h (struct Lisp_Symbol): Update comments.
2093 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2095 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2097 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2099 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2100 <oslsachem@gmail.com> for helping to debug this.
2102 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2103 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2104 (g_b_init_get_glyph_outline_w): New static variables.
2105 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2106 (GetGlyphOutlineW_Proc): New typedefs.
2107 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2108 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2110 (w32font_open_internal, compute_metrics):
2111 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2112 instead of calling the "wide" APIs directly.
2114 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2116 * w32.h (syms_of_w32font): Add prototype.
2118 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2120 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2121 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2122 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2123 (Fmove_to_window_line): Doc fix.
2125 2011-10-27 Chong Yidong <cyd@gnu.org>
2127 * process.c (make_process): Set gnutls_state to NULL.
2129 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2130 non-NULL, regardless of GNUTLS_INITSTAGE.
2131 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2132 an error. Set process slots as soon as we allocate them.
2134 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2136 2011-10-27 Chong Yidong <cyd@gnu.org>
2138 * gnutls.c (emacs_gnutls_deinit): New function.
2139 Deallocate credentials structures as well as calling gnutls_deinit.
2140 (Fgnutls_deinit, Fgnutls_boot): Use it.
2142 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2143 (deactivate_process): Call emacs_gnutls_deinit.
2145 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2147 * image.c (x_create_x_image_and_pixmap):
2148 * w32.c (sys_rename, w32_delayed_load):
2149 * w32font.c (fill_in_logfont):
2150 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2152 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2154 * w32fns.c (w32_default_color_map): New function,
2155 extracted from Fw32_default_color_map.
2156 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2158 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2160 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2162 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2164 * keyboard.c (test_undefined): New function (bug#9751).
2165 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2167 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2169 * sysdep.c (init_sys_modes): Fix the check for the controlling
2170 terminal (Bug#6649).
2172 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2174 * dispextern.h (struct bidi_it): New member next_en_type.
2176 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2177 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2178 current character, check also for next_en_type being WEAK_EN.
2179 (bidi_resolve_weak): Don't enter the expensive loop if the current
2180 position is before next_en_pos. Record the bidi type of the first
2181 non-ET, non-BN character we find, in addition to its position.
2182 (bidi_level_of_next_char): Invalidate next_en_type when
2183 next_en_pos is over-stepped.
2185 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2187 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2188 * editfns.c: Rewrite current-time-zone so that it invokes
2189 the equivalent of (format-time-string "%Z") to get the time zone name.
2190 This fixes a bug when the time zone name contains characters that
2191 need converting from the system time locale to Emacs internal format.
2192 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2193 that patch fixed format-time-string to do the conversion, but
2194 I forgot to fix current-time-zone.
2195 (format_time_string): New function, containing most of
2196 what Fformat_time_string used to contain.
2197 (Fformat_time_string): Rewrite in terms of format_time_string.
2198 This doesn't change this function's behavior.
2199 (current-time-zone): Rewrite to use format_time_string.
2200 This fixes the bug reported by Michael Schierl in
2201 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2202 Jason Rumney's 2007-06-07 change worked around this bug, but
2204 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2206 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2208 * xdisp.c (start_display): If the character at POS is displayed
2209 via a display vector, reset IT->current.dpvec_index to zero.
2210 (try_window_reusing_current_matrix): If a line ends in a display
2211 vector or the next line starts in a display vector, continue
2212 redrawing the window even though the character position of
2213 start_row was reached.
2216 2011-10-18 Chong Yidong <cyd@gnu.org>
2218 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2219 with nobreak-char-display too.
2221 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2223 Fix part 3 of bug#9771.
2224 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2225 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2226 non-neutral characters if the current character is a paragraph
2227 separator (a.k.a. Newline). This avoids running the same
2228 expensive loop twice, once when we consume the preceding newline
2229 and the other time when the line actually needs to be displayed.
2230 Avoid the loop when we see neutrals on the base embedding level
2231 following a character whose directionality is the same as the
2232 paragraph's. This avoids running the expensive loop when a line
2233 ends in a long sequence of neutrals, like control characters.
2234 Add assertion against STRONG_AL type. Slightly rearrange code
2235 that determines the type of a neutral given the first non-neutral
2237 (bidi_level_of_next_char): Set next_en_pos to zero when
2238 invalidating its info.
2240 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2242 * xdisp.c (push_display_prop): Determine whether to record string
2243 or buffer position by IT->string, not by IT->method. Allow
2244 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2245 (move_it_vertically_backward): Don't look for character position
2246 immediately after the newline when in a continuation line.
2249 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2251 * window.c (coordinates_in_window): Rewrite and delabelize
2252 vertical border check. (Bug#5357) (Bug#9618)
2254 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2256 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2257 errors in XSetWindowBorder (bug#9310).
2259 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2261 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2262 avoid crash when xmalloc overrun checking is enabled.
2264 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2266 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2267 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2268 cursor motion with <left> and <right> arrow keys.
2270 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2271 some callers set that themselves.
2273 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2275 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2276 display string and the previous row comes from the same string and
2277 is empty. (Bug#9739) (Bug#9738)
2279 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2281 * doc.c (get_doc_string): Encode file name (bug#9735).
2283 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2285 * bidi.c (bidi_level_of_next_char):
2286 * xdisp.c (get_visually_first_element): Remove old incorrect
2287 comments regarding the Unicode Line Separator character.
2289 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2291 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2293 * alloc.c (Fgc_status): Do not access beyond zombies array
2294 boundary if nzombies > MAX_ZOMBIES.
2295 * alloc.c (dump_zombies): Add missing format specifier.
2297 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2299 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2300 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2302 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2303 Some packages use them to denote characters with modifiers.
2305 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2307 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2308 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2309 matching a pp-number. Rename parameter var to var1.
2311 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2313 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2315 2011-10-08 Glenn Morris <rgm@gnu.org>
2317 * callint.c (Fcall_interactively): Give a more explicit error for the
2318 'c' case with a non-character input. (Bug#8479)
2320 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2322 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2324 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2325 lines that are hscrolled on the left.
2327 * dispnew.c (buffer_posn_from_coords): Account for a possible
2328 presence of header-line. (Bug#4426)
2330 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2332 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2333 Don't advertise functionality which we discourage or doesn't work.
2335 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2337 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2338 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2339 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2340 this makes Emacs dump core during garbage collection on rare
2341 occasions. sizeof is obviously inferior to offsetof here, so
2342 stick with offsetof.
2343 (GC_POINTER_ALIGNMENT): New macro.
2344 (mark_memory): Omit 3rd (offset) arg; caller changed.
2345 Don't assume EMACS_INT alignment is the same as pointer alignment.
2347 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2349 * keyboard.c (read_key_sequence_remapped): New var.
2350 (read_key_sequence): Compute remapping in the right buffer.
2351 (command_loop_1): Use read_key_sequence's remapping directly.
2353 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2355 * dired.c (file_name_completion): Don't expand file name.
2356 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2357 before checking file name handler.
2359 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2360 they've been requested explicitly (bug#9591).
2362 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2364 * keymap.c (Fsingle_key_description): Use make_specified_string
2365 instead of build_string to build string from push_key_description.
2368 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2370 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2371 This fixes a Y2038 bug on 64-bit hosts.
2372 * buffer.c (reset_buffer):
2373 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2374 (Fclear_buffer_auto_save_failure):
2375 Use 0, not -1, to represent an unset failure time, since time_t
2376 might not be signed.
2378 Remove dependency on glibc malloc internals.
2379 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2380 Move back here from lisp.h, but with their new implementations.
2381 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2382 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2383 * charset.c (charset_table_init): New static var.
2384 (syms_of_charset): Use it instead of xmalloc. This removes a
2385 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2386 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2387 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2388 Move back to alloc.c.
2389 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2390 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2392 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2394 * nsterm.m (windowDidResize): Call x_set_window_size only when
2395 ns_in_resize is true. Otherwise set pixelwidth/height and
2396 call change_frame_size (Bug#9628).
2398 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2400 Port --enable-checking=all to Fedora 14 x86-64.
2401 * charset.c (syms_of_charset): Also account for glibc malloc's
2402 internal overhead when calculating the initial malloc maximum.
2404 Port --enable-checking=all to Fedora 14 x86.
2405 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2407 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2408 (overrun_check_realloc, overrun_check_free):
2409 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2410 That way, xmalloc returns a properly-aligned pointer even if
2411 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2412 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2413 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2414 into account when calculating the initial malloc maximum.
2415 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2416 Move here from alloc.c, so that charset.c can use it too.
2417 Properly align; the old code wasn't right for common 32-bit hosts
2418 when configured with --enable-checking=all.
2419 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2420 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2422 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2424 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2427 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2429 * xdisp.c (compute_display_string_end): If there's no display
2430 string at CHARPOS, return -1.
2432 * bidi.c (bidi_fetch_char): When compute_display_string_end
2433 returns a negative value, treat the character as a normal
2434 character not covered by a display string. (Bug#9624)
2436 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2438 * lread.c (Fread_from_string): Fix typo in docstring.
2440 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2442 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2443 newline, reseat the iterator instead of bidi-iterating there one
2444 character at a time. (Bug#9610)
2445 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2446 TO_CHARPOS if the bidi iterator is at base embedding level.
2448 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2450 * lread.c (readevalloop): Use correct code for NBSP.
2451 (read1): Likewise. (Bug#9608)
2453 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2455 * dbusbind.c (Fdbus_register_signal): When service is not
2456 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2458 2011-09-25 Glenn Morris <rgm@gnu.org>
2460 * buffer.c (truncate-lines): Doc fix.
2462 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2464 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2465 (Fset_window_next_buffers): Doc fix.
2467 2011-09-24 Glenn Morris <rgm@gnu.org>
2469 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2471 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2473 Fix minor problems found by static checking.
2474 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2475 * indent.c (Fvertical_motion): Fix == vs = typo.
2477 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2479 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2480 Default value is now t. Doc fix.
2482 * indent.c (Fvertical_motion): Compute and apply the overshoot
2483 logic when moving up, not only when moving down. Fix the
2484 confusing name and values of the it_overshoot_expected variable;
2485 logic changes accordingly. (Bug#9254) (Bug#9549)
2487 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2488 CHARPOS is covered by a display string which includes newlines.
2489 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2490 is covered by a display string with embedded newlines.
2492 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2494 * dbusbind.c (Fdbus_register_signal): Add match rule to
2495 Vdbus_registered_objects_table. (Bug#9581)
2496 (Fdbus_register_method, Vdbus_registered_objects_table):
2499 2011-09-24 Jim Meyering <meyering@redhat.com>
2501 do not ignore write error for any output size
2502 The previous change was incomplete.
2503 While it makes emacs --batch detect the vast majority of stdout
2504 write failures, errors were still ignored whenever the output size is
2505 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2506 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2507 && echo FAIL: ignored write error
2508 FAIL: ignored write error
2509 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2510 && echo FAIL: ignored write error
2511 FAIL: ignored write error
2512 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2514 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2516 * emacs.c (Fkill_emacs): In noninteractive mode exit
2517 non-successfully if a write error occurred on stdout. (Bug#9574)
2519 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2521 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2524 * dispextern.h (struct it): Update the comment documenting what
2527 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2529 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2530 a display string, extend search for cursor position to end of row.
2531 (find_row_edges): If the row ends in a newline from a display
2532 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2533 Handle the case of a display string with multiple newlines.
2534 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2535 non-empty line. Fixes confusing cursor motion with arrow keys at
2536 the beginning of a line that starts with whitespace.
2538 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2540 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2543 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2545 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2548 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2550 * xdisp.c (display_line): Record maximum and minimum buffer
2551 positions even if no glyphs were produced (e.g., by a zero-width
2552 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2553 buffer positions that will be removed from the glyph row because
2555 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2556 column is beyond frame width: don't subtract 1 "pixel" when
2557 computing width of the stretch.
2558 (reseat_at_next_visible_line_start): Undo the change made on
2559 2011-09-17 that saved paragraph information and restored it after
2560 the call to `reseat'. (Bug#9545)
2562 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2564 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2565 and turn window cursor on if cleared (Bug#9415).
2567 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2569 * search.c (boyer_moore): Take unibyte characters from pattern
2570 literally. (Bug#9458)
2572 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2574 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2576 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2578 Fix minor problem found by static checking.
2579 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2580 initialized, to pacify gcc -Wuninitialized.
2582 * fileio.c: Report proper errno when syscall falls.
2583 (Finsert_file_contents): Save and restore errno,
2584 so that report_file_error outputs the correct diagnostic.
2585 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2587 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2589 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2591 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2593 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2594 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2596 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2598 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2599 about the current paragraph and restore it after the call to reseat.
2601 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2602 (bidi_find_paragraph_start): Search back for paragraph beginning
2603 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2604 (bidi_move_to_visually_next): Only trigger paragraph-related
2605 computations when the last character is a newline or at EOB, not
2606 just any NEUTRAL_B. (Bug#9470)
2608 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2609 truncated lines if point is covered by a display string. (Bug#9524)
2611 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2613 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2614 (cons_to_x_long): New function.
2615 (lisp_data_to_selection_data): Use it. Correct the test for
2616 short-versus-long data; it was negated. Break out of vector
2617 loop, for efficiency, when a long datum is discovered.
2619 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2621 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2623 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2625 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2626 GCC PR/17406) by declaring this function with external scope.
2628 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2630 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2631 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2633 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2635 * editfns.c (Fformat): Correctly handle text properties on "%%".
2637 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2639 * xterm.c (x_draw_composite_glyph_string_foreground):
2640 * w32term.c (x_draw_composite_glyph_string_foreground):
2641 * term.c (encode_terminal_code):
2642 * composite.c (composition_update_it, get_composition_id):
2643 * xdisp.c (get_next_display_element)
2644 (fill_composite_glyph_string): Add comments about special meaning
2645 of TAB characters in a composition.
2647 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2649 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2650 This occurs when processing a multibyte format.
2651 Problem reported by Wolfgang Jenker.
2653 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2655 * xdisp.c (try_cursor_movement): Only check for exact match if
2656 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2658 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2660 Remove unused external symbols.
2661 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2662 * xdisp.c (calc_pixel_width_or_height): Now static.
2663 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2664 * indent.c (check_display_width):
2665 * w32term.c: Fix comment to match code.
2666 * xterm.c, xterm.h (x_catching_errors): Remove.
2668 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2670 * xselect.c: Use signed conversions more consistently (Bug#9498).
2671 (selection_data_to_lisp_data): Assume incoming selection data are
2672 signed integers, not unsigned. This is to be consistent with
2673 outgoing selection data, which was modified to use signed integers
2674 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2675 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2676 expects long, not unsigned long.
2678 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2680 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2681 computation of loop end. Reported by Johan Bockgård
2684 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2686 * frame.c (Fother_visible_frames_p): Function deleted.
2688 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2690 * indent.c (compute_motion): Process display vector front to back
2691 rather than the other way around. (Bug#2496)
2693 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2695 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2697 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2699 * minibuf.c (Fread_from_minibuffer): Doc fix.
2701 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2703 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2704 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2706 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2708 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2709 value for non-existent files.
2711 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2713 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2714 set its "size" to -1. This will set the modtime_size field of
2715 the corresponding buffer to -1, which is what
2716 verify-visited-file-modtime expects for files that do not exist.
2719 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2721 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2723 * lisp.h: ... from here. push_key_description is no longer
2724 defined in keyboard.c, so its declaration should not be in
2725 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2726 logically belongs with push_key_description.
2728 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2730 * buffer.h: Include <sys/types.h> instead of <time.h>.
2731 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2732 Problem reported by Herbert J. Skuhra.
2734 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2736 * xml.c (parse_region): Make the parsing work for
2737 non-comment-starting XML files again (bug#9144).
2739 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2741 * image.c (gif_load): Fix calculation of bottom and right corner.
2744 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2746 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2747 redisplay in small windows.
2749 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2751 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2753 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2755 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2756 Operate on live windows only.
2758 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2760 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2762 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2764 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2765 only under bidi iteration.
2767 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2769 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2771 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2773 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2774 Without this fix, the command to link temacs failed due to an
2775 undefined symbol __builtin_isnan. This is because
2776 /usr/include/iso/math_c99.h #defines isnan(x) to
2777 __builtin_isnan(x), but the bundled gcc, which identifies itself
2778 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2780 * floatfns.c (isnan): #undef, and then #define to a clone of
2782 (Fisnan): Always define, since it's always available now.
2783 (syms_of_floatfns): Always define isnan at the Lisp level.
2785 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2787 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2789 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2791 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2792 The previous code assumed that file offsets (off_t values) fit in
2793 EMACS_INT variables, which is not true on typical 32-bit hosts.
2794 The code messed up by falsely reporting buffer overflow in cases
2795 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2796 when "big" contains more than 2**29 bytes, even though this
2797 inserts just one byte and does not overflow the buffer.
2798 (Finsert_file_contents): Store file offsets as off_t
2799 values, not as EMACS_INT values. Check for overflow when
2800 converting between EMACS_INT and off_t. When checking for
2801 buffer overflow or for overlap, take the offsets into account.
2802 Don't use EMACS_INT for small values where int suffices.
2803 When checking for overlap, fix a typo: ZV was used where
2804 ZV_BYTE was intended.
2805 (Fwrite_region): Don't assume off_t fits into 'long'.
2806 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2808 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2810 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2812 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2814 sprintf-related integer and memory overflow issues (Bug#9412).
2816 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2817 (esprintf, exprintf, evxprintf): New functions.
2818 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2819 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2820 (modify_event_symbol): Do not assume that the length of
2821 name_alist_or_stem is safe to alloca and fits in int.
2822 (Fexecute_extended_command): Likewise for function name and binding.
2823 (Frecursion_depth): Wrap around reliably on integer overflow.
2824 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2825 since some callers pass EMACS_INT values.
2826 (Fsingle_key_description): Don't crash if symbol name contains more
2827 than MAX_ALLOCA bytes.
2828 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2829 (get_minibuffer): Arg is now EMACS_INT, not int.
2830 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2831 (esprintf, exprintf, evxprintf): New decls.
2832 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2834 * dbusbind.c (signature_cat): New function.
2835 (xd_signature, Fdbus_register_signal):
2836 Do not overrun buffer; instead, report string overflow.
2838 * dispnew.c (add_window_display_history): Don't overrun buffer.
2839 Truncate instead; this is OK since it's just a log.
2841 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2842 even if the time zone offset is outlandishly large.
2843 Don't mishandle offset == INT_MIN.
2845 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2846 when creating daemon; the previous buffer-overflow check was incorrect.
2848 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2849 which has the guts of the old verror function.
2851 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2852 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2854 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2855 (font_unparse_xlfd): Don't blindly alloca long strings.
2856 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2857 fits in int, when using sprintf. Use single snprintf to count
2858 length of string rather than counting it via multiple sprintfs;
2859 that's simpler and more reliable.
2860 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2861 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2862 sprintf, in case result does not fit in int.
2864 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2865 (fontset_from_font): Print it.
2867 * frame.c (tty_frame_count): Now printmax_t, not int.
2868 (make_terminal_frame, set_term_frame_name): Print it.
2869 (x_report_frame_params): In X, window IDs are unsigned long,
2870 not signed long, so print them as unsigned.
2871 (validate_x_resource_name): Check for implausibly long names,
2872 and don't assume name length fits in 'int'.
2873 (x_get_resource_string): Don't blindly alloca invocation name;
2874 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2877 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2878 (xg_check_special_colors, xg_set_geometry):
2879 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2881 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2882 Use esprintf, not sprintf, in case result does not fit in int.
2884 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2885 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2886 it as a large positive number.
2887 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2888 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2890 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2891 in case result does not fit in int.
2893 * print.c (float_to_string): Detect width overflow more reliably.
2894 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2895 buffer overrun. Don't assume list length fits in 'int'. Treat
2896 print length of 0 as 0, not as infinity; to be consistent with other
2897 uses of print length in this function. Don't overflow print length
2898 index. Don't assume hash table size fits in 'long', or that
2899 vectorlike size fits in 'unsigned long'.
2901 * process.c (make_process): Use printmax_t, not int, to format
2902 process-name gensyms.
2904 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2906 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2907 to avoid potential buffer overrun.
2909 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2910 if X resource line is longer than 512 bytes.
2912 * xfns.c (x_window): Make sprintf buffer a bit bigger
2913 to avoid potential buffer overrun.
2915 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2917 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2919 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2921 Integer overflow fixes for scrolling, etc.
2922 Without these, Emacs silently mishandles large integers sometimes.
2923 For example, "C-u 4294967297 M-x recenter" was treated as if
2924 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2926 * xdisp.c (try_window_id): Check Emacs fixnum range before
2927 converting to 'int'.
2929 * window.c (window_scroll_line_based, Frecenter):
2930 Check that an Emacs fixnum is in range before assigning it to 'int'.
2931 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2932 values converted from Emacs fixnums.
2933 (Frecenter): Don't wrap around a line count if it is out of 'int'
2934 range; instead, treat it as an extreme value.
2935 (Fset_window_configuration, compare_window_configurations):
2936 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2938 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2939 that can exceed INT_MAX. Check that EMACS_INT value is in range
2940 before assigning it to the (possibly-narrower) index.
2941 (match_limit): Don't assume that a fixnum can fit in 'int'.
2943 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2946 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2947 (Fvertical_motion): Don't wrap around LINES values that don't fit
2948 in 'int'. Instead, treat them as extreme values. This is good
2949 enough for windows, which can't have more than INT_MAX lines anyway.
2951 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2953 * Require libxml/parser.h to avoid compilation warning.
2955 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2957 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2958 since this reportedly can destroy thread storage.
2960 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2962 * syntax.c (find_defun_start): Update all cache variables if
2963 exiting early (Bug#9401).
2965 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2967 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2969 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2970 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2971 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2973 * term.c (tty_append_glyph): New function.
2974 (produce_stretch_glyph): Static function and its prototype deleted.
2976 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2979 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2981 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2982 when checking :margin (Bug#9390).
2983 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2984 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2985 so that the name doesn't mislead. All uses changed.
2987 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2989 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2992 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2994 * xdisp.c (move_it_to): Don't bail out early when reaching
2995 position beyond to_charpos, if we are scanning backwards.
2996 (move_it_vertically_backward): When DY == 0, make sure we get to
2997 the first character in the line after the newline.
2999 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3001 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3002 (ccl_driver): Do not generate an out-of-range pointer.
3003 (Fccl_execute_on_string): Remove unnecessary check for
3004 integer overflow, noted by Stefan Monnier in
3005 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3006 Remove a FIXME that didn't need fixing.
3007 Simplify the newly-introduced buffer reallocation code.
3009 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3011 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3013 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3015 Integer and memory overflow issues (Bug#9196).
3017 * doc.c (get_doc_string): Rework so that
3018 get_doc_string_buffer_size is the actual buffer size, rather than
3019 being 1 less than the actual buffer size; this makes xpalloc more
3022 * image.c (x_allocate_bitmap_record, cache_image):
3023 * xselect.c (Fx_register_dnd_atom):
3024 Simplify previous changes by using xpalloc.
3026 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3027 since either will do and ptrdiff_t is convenient with xpalloc.
3029 * charset.c (charset_table_size)
3030 (struct charset_sort_data.priority): Now ptrdiff_t.
3031 (charset_compare): Don't overflow if priorities differ greatly.
3032 (Fsort_charsets): Don't assume list length fits in int.
3033 Check for size-calculation overflow when allocating sort data.
3034 (syms_of_charset): Allocate an initial charset table that is
3035 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3037 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3039 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3040 The actual value is always <= INT_MAX, and leaving it unsigned made
3041 overflow checking harder.
3043 * dispextern.h (struct glyph_matrix.rows_allocated)
3044 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3045 with xpalloc. The values are still always <= INT_MAX.
3047 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3049 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3050 (SAFE_NALLOCA): New macro.
3052 * region-cache.c (struct boundary.pos, find_cache_boundary)
3053 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3054 (set_cache_region, invalidate_region_cache)
3055 (revalidate_region_cache, know_region_cache, region_cache_forward)
3056 (region_cache_backward, pp_cache):
3057 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3058 so that ptrdiff_t * can be passed to xpalloc.
3059 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3060 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3061 (pp_cache): Don't assume cache_len fits in int.
3062 * region-cache.h: Adjust extern decls to match.
3064 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3065 EMACS_INT, since either will do, for xpalloc.
3067 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3068 (xnmalloc, xnrealloc, xpalloc): New functions.
3070 * bidi.c (bidi_shelve_header_size): New constant.
3071 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3072 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3074 * bidi.c (bidi_cache_shrink):
3075 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3077 Don't update size of array until after memory allocation succeeds,
3078 because xmalloc/xrealloc may not return.
3079 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3080 now that we have proper integer overflow checking.
3081 (record_overlay_string, overlay_strings): Catch overflows when
3082 calculating size of overlay_str_buf.
3084 * callproc.c (Fcall_process): Check for size overflow when
3085 calculating size of args2.
3086 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3087 Normally we prefer signed values, but sticking with ptrdiff_t would
3088 require adding more-complicated checks.
3090 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3091 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3092 Redo buffer-overflow calculations to avoid integer overflow.
3093 Add a FIXME comment where memory seems to be over-allocated.
3095 * character.c (Fstring): Check for size-calculation overflow.
3097 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3098 unnecessary integer overflow. Check for size overflow.
3099 (encode_coding_object): Don't update size until xmalloc succeeds.
3101 * composite.c (get_composition_id): Check for overflow in glyph
3102 length calculations.
3104 Integer and memory overflow fixes for display code.
3105 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3106 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3107 (scrolling_window): Check for overflow in size calculations.
3108 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3109 Don't assume glyph table len fits in int.
3110 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3111 (row_table_size): Now ptrdiff_t, not int.
3112 (scrolling_window): Avoid overflow in size calculations.
3113 Don't update size until allocation succeeds.
3114 * fns.c (concat): Check for overflow in size calculations.
3115 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3116 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3117 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3119 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3120 (get_doc_string): Check for size calculation overflow.
3121 Don't update size until allocation succeeds.
3122 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3123 EMACS_INT, where ptrdiff_t will do.
3124 (Fsubstitute_command_keys): Check for string overflow.
3126 * editfns.c (set_time_zone_rule): Don't assume environment length
3128 (message_length): Now ptrdiff_t, not int.
3129 (Fmessage_box): Don't update size until allocation succeeds.
3130 Don't assume message length fits in int.
3131 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3133 * emacs.c (main): Do not reallocate argv, since there is a null at
3134 the end that can be overwritten, and this way there's no need to
3135 worry about size-calculation overflow.
3136 (sort_args): Check for size-calculation overflow.
3138 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3140 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3142 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3143 (x_set_scroll_bar_width, x_figure_window_size):
3144 Check for integer overflow.
3145 (x_set_alpha): Do not assume XINT fits in int.
3147 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3148 This is for the members text_lines, text_cols, total_lines, total_cols,
3149 where the system imposes an 'int' limit.
3151 * fringe.c (Fdefine_fringe_bitmap):
3152 Don't update size until alloc works.
3154 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3155 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3157 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3158 Check for size-calculation overflow.
3159 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3160 do, as we prefer signed integers.
3161 (id_to_widget.max_size, id_to_widget.used)
3162 (xg_store_widget_in_map, xg_remove_widget_from_map)
3163 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3164 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3165 Use and return ptrdiff_t, not int.
3166 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3167 * gtkutil.h: Change prototypes to match the above.
3169 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3170 are duplicate now that they've been promoted to lisp.h.
3171 (x_allocate_bitmap_record, x_alloc_image_color)
3172 (make_image_cache, cache_image, xpm_load):
3173 Don't update size until alloc is done.
3174 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3176 Check for size calculation overflow.
3177 (ct_colors_allocated_max): New constant.
3178 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3181 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3182 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3183 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3184 Use ptrdiff_t, not int, to count maps.
3185 (read_char_minibuf_menu_prompt): Check for overflow in size
3186 calculations. Don't update size until allocation succeeds.
3187 Redo calculations to avoid overflow.
3188 * keyboard.h: Change prototypes to match the above.
3190 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3192 (current_minor_maps): Check for size calculation overflow.
3193 * keymap.h: Change prototypes to match the above.
3195 * lread.c (read1, init_obarray): Don't update size until alloc done.
3197 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3198 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3200 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3201 Now ptrdiff_t, not int.
3202 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3203 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3205 * process.c (Fnetwork_interface_list): Check for overflow
3206 in size calculation.
3208 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3210 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3211 overflow. Don't bother calling xmalloc when xrealloc will do.
3213 * search.c (Freplace_match): Check for size calculation overflow.
3214 (Fset_match_data): Don't assume list lengths fit in 'int'.
3216 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3217 for command line length. Do not attempt to address one before the
3218 beginning of an array, as that's not portable.
3220 * term.c (max_frame_lines): Remove; unused.
3221 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3223 (encode_terminal_code, calculate_costs): Check for size
3224 calculation overflow.
3225 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3226 table lengths and related sizes. Don't update size until alloc
3227 done. Redo calculations to avoid overflow.
3228 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3230 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3231 subtracting pointers.
3232 (gobble_line): Check for overflow more carefully. Don't update size
3235 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3236 Don't update size until alloc done.
3237 Redo size calculations to avoid overflow.
3238 Check for size calculation overflow.
3239 (main) [DEBUG]: Fix typo in invoking tparam1.
3241 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3242 Use ptrdiff_t, not int, for sizes.
3243 (store_mode_line_noprop_char): Don't update size until alloc done.
3245 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3246 Use ptrdiff_t, not int, for sizes.
3247 (Finternal_make_lisp_face, cache_face):
3248 Check for size calculation overflow.
3249 (cache_face): Treat size calculation overflows as if they were
3250 memory exhaustion (the usual treatment), rather than aborting.
3252 * xfns.c (x_encode_text, x_set_name_internal)
3253 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3254 sizes, since they can exceed INT_MAX in size. Check for size
3255 calculation overflow.
3257 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3258 (xg_select): Check for size calculation overflow.
3259 Don't update size until alloc done.
3261 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3262 as sprintf is limited to int lengths.
3264 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3265 (X_LONG_MIN): New macros.
3266 Use them to make the following changes clearer.
3267 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3268 This change doesn't affect the value now, but it may help remind
3269 future maintainers not to raise the value too much later.
3270 (SELECTION_QUANTUM): Remove, replacing with ...
3271 (selection_quantum): ... new function, which avoids overflow.
3273 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3274 assumption that selection length fits in 'int'.
3275 (x_reply_selection_request, x_handle_selection_request)
3276 (x_get_window_property, receive_incremental_selection)
3277 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3278 (lisp_data_to_selection_data, clean_local_selection_data):
3279 Use ptrdiff_t, not int, to record length of selection.
3280 (x_reply_selection_request, x_get_window_property)
3281 (receive_incremental_selection, x_property_data_to_lisp):
3282 Redo calculations to avoid overflow.
3283 (x_reply_selection_request): When sending hint, ceiling it at
3284 X_LONG_MAX rather than relying on wraparound overflow to send
3286 (x_get_window_property, receive_incremental_selection)
3287 (lisp_data_to_selection_data, x_property_data_to_lisp):
3288 Check for size-calculation overflow.
3289 (x_get_window_property, receive_incremental_selection)
3290 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3291 Don't store size until memory allocation succeeds.
3292 (x_get_window_property): Plug memory leak on memory exhaustion.
3293 Don't double-block input; malloc is safe here. Don't assume 2**34
3294 - 4 fits in unsigned long. Add an xassert to check
3295 XGetWindowProperty overflow. Be more careful about overflow
3296 calculations, and distinguish size from memory overflow better.
3297 (receive_incremental_selection): When tracing, don't assume
3298 unsigned int is less than INT_MAX.
3299 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3300 harmful) conversions of unsigned short to int.
3301 (lisp_data_to_selection_data): Don't assume that integers
3302 in the range -65535 through -1 fit in an X unsigned short.
3303 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3304 result parameters unless successful. Rely on cons_to_unsigned
3305 to report problems with elements; the old code wasn't right anyway.
3306 (x_check_property_data): Check for int overflow; we cannot use
3307 a wider type due to X limits.
3308 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3310 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3312 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3313 (x_term_init): Check for size calculation overflow.
3314 (x_color_cells): Don't store size until memory allocation succeeds.
3315 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3316 Don't assume alloca size is less than MAX_ALLOCA.
3317 (x_term_init): Don't assume length fits in int (sprintf is limited
3320 Use ptrdiff_t for composition IDs.
3321 * character.c (lisp_string_width):
3322 * composite.c (composition_table_size, n_compositions)
3323 (get_composition_id, composition_gstring_from_id):
3324 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3325 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3326 * window.c (Frecenter):
3327 Use ptrdiff_t, not int, for composition IDs.
3328 * composite.c (get_composition_id): Check for integer overflow.
3329 * composite.h: Adjust prototypes to match the above changes.
3331 Use ptrdiff_t for hash table indexes.
3332 * category.c (hash_get_category_set):
3333 * ccl.c (ccl_driver):
3334 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3335 * coding.c (coding_system_charset_list, detect_coding_system):
3336 * coding.h (struct coding_system.id):
3337 * composite.c (get_composition_id, gstring_lookup_cache):
3338 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3339 * image.c (xpm_get_color_table_h):
3340 * lisp.h (hash_lookup, hash_put):
3341 * minibuf.c (Ftest_completion):
3342 Use ptrdiff_t for hash table indexes, not int (which is too
3343 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3344 32-bit --with-wide-int hosts).
3346 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3347 Add a FIXME comment about memory leaks.
3348 (syms_of_charset): Don't assume xmalloc returns.
3350 Don't assume that stated character widths fit in int.
3351 * character.c (Fchar_width, c_string_width, lisp_string_width):
3352 * character.h (CHAR_WIDTH):
3353 * indent.c (MULTIBYTE_BYTES_WIDTH):
3354 Use sanitize_char_width to avoid undefined and/or bad behavior
3355 with outlandish widths.
3356 * character.h (sanitize_tab_width): Rename from sanitize_width,
3357 now that we have two such functions. All uses changed.
3358 (sanitize_char_width): New inline function.
3360 Don't assume that tab-width fits in int.
3361 * character.h (sanitize_width): New inline function.
3362 (SANE_TAB_WIDTH): New macro.
3363 (ASCII_CHAR_WIDTH): Use it.
3364 * indent.c (sane_tab_width): Remove. All uses replaced by
3365 SANE_TAB_WIDTH (current_buffer).
3366 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3368 * fileio.c: Integer overflow issues with file modes.
3369 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3371 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3372 Remove unreachable code.
3373 (read_hex, load_charset_map_from_file): Check for integer overflow.
3375 * xterm.c: Don't go over XClientMessageEvent limit.
3376 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3377 (x_send_scroll_bar_event): Likewise. Check that the size does not
3378 exceed limits imposed by XClientMessageEvent, as well as the usual
3379 ptrdiff_t and size_t limits.
3381 * keyboard.c: Overflow, signedness and related fixes.
3382 (make_lispy_movement): Use same integer type in forward decl
3383 that is used in the definition.
3384 (read_key_sequence, keyremap_step):
3385 Change bufsize argument back to int, undoing my 2011-03-30 change.
3386 We prefer signed types, and int is wide enough here.
3387 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3388 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3389 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3390 length, not size_t. Use ptrdiff_t for index, not int.
3391 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3392 possibility of integer overflow.
3394 Overflow, signedness and related fixes for images.
3396 * dispextern.h (struct it.stack[0].u.image.image_id)
3397 (struct_it.image_id, struct image.id, struct image_cache.size)
3398 (struct image_cache.used, struct image_cache.ref_count):
3399 * gtkutil.c (update_frame_tool_bar):
3400 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3401 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3402 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3403 * nsmenu.m (update_frame_tool_bar):
3404 * xdisp.c (calc_pixel_width_or_height):
3405 * xfns.c (image_cache_refcount):
3406 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3407 on typical 64-bit hosts.
3409 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3410 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3411 Omit unnecessary casts to int.
3412 (parse_image_spec): Check that integers fall into 'int' range
3413 when the callers expect that.
3414 (image_ascent): Redo ascent calculation to avoid int overflow.
3415 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3416 (lookup_image): Remove unnecessary tests.
3417 (xbm_image_p): Locals are now of int, not EMACS_INT,
3418 since parse_image_check makes sure they fit into int.
3419 (png_load, gif_load, svg_load_image):
3420 Prefer int to unsigned where either will do.
3421 (tiff_handler): New function, combining the cores of the
3422 old tiff_error_handler and tiff_warning_handler.
3423 This function is rewritten to use vsnprintf and thereby avoid
3424 stack buffer overflows. It uses only the features of vsnprintf
3425 that are common to both POSIX and native Microsoft.
3426 (tiff_error_handler, tiff_warning_handler): Use it.
3427 (tiff_load, gif_load, imagemagick_load_image):
3428 Don't assume :index value fits in 'int'.
3429 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3430 (imagemagick_load_image): Check that crop parameters fit into
3431 the integer types that MagickCropImage accepts. Don't assume
3432 Vimagemagick_render_type has a nonnegative value. Don't assume
3433 size_t fits in 'long'.
3434 (gs_load): Use printmax_t to print the widest integers possible.
3435 Check for integer overflow when computing image height and width.
3437 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3439 * xdisp.c (redisplay_window): Don't force window start if point
3440 will be invisible in the resulting window. (Bug#9324)
3442 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3444 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3445 the display spec is of the form `(space ...)'.
3446 (handle_display_spec): Return the value returned by
3447 handle_single_display_spec, not just 1 or zero.
3448 (handle_single_display_spec): If the display spec is of the form
3449 `(space ...)', and specifies display in the text area, return 2
3451 (try_cursor_movement): Check for the need to scroll more
3452 accurately, and prefer exact match for point under bidi.
3453 Don't advance `row' beyond the last row of the window.
3455 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3456 into disp_prop; all users changed.
3458 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3459 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3460 for the text covered by the display property.
3462 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3464 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3465 Change return value to nil.
3466 (Frecord_buffer): Delete unused function.
3468 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3470 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3471 buffers, return left-to-right.
3472 (set_cursor_from_row): Consider candidate row a win if its glyph
3473 represents a newline and point is on that newline. Fixes cursor
3474 positioning on the newline at EOL of R2L text within L2R
3475 paragraph, and vice versa.
3476 (try_cursor_movement): Check continued rows, in addition to
3477 continuation rows. Fixes unwarranted scroll when point enters a
3478 continued line of R2L text within an L2R paragraph, or vice versa.
3479 (cursor_row_p): Consider the case of point being equal to
3480 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3481 from the end of a short line to the beginning of a continued line
3482 of R2L text within L2R paragraph.
3483 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3484 composed characters.
3486 * bidi.c (bidi_check_type): Use xassert.
3487 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3490 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3492 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3495 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3497 * nsfont.m (ns_otf_to_script): Fix typo.
3499 2011-08-22 Kenichi Handa <handa@m17n.org>
3501 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3502 extra slot even if the purpose is char-code-property-table.
3504 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3506 * xdisp.c (redisplay_window): When computing centering_position,
3507 account for the height of the header line. (Bug#8874)
3509 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3510 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3511 candidate is selected by the mouse, and that candidate has a
3512 composed character under the mouse.
3514 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3515 coordinates reported by pos-visible-in-window-p for a composed
3516 character in column zero.
3518 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3520 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3522 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3524 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3525 consider it a hit if to_charpos is anywhere in the range of the
3526 composed buffer positions.
3528 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3530 * image.c (gif_load): Don't assume that each subimage has the same
3531 dimensions as the base image. Handle disposal method that is
3532 "undefined" by the gif spec (Bug#9335).
3534 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3536 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3537 (Fcondition_case): Document `debug' symbol in error handler.
3539 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3541 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3542 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3543 from an Org mode buffer to a Speedbar frame.
3545 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3546 a composition, take its buffer position from IT->cmp_it.charpos.
3547 Fixes cursor positioning at the beginning of a line that begins
3548 with a composed character.
3550 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3552 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3553 character bidirectional type, use STRONG_L instead. Fixes crashes
3554 in a buffer produced by `describe-categories'.
3556 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3557 members before the level stack, so they would be saved and
3558 restored when copying iterator state. Fixes incorrect reordering
3559 around TABs covered by display properties.
3561 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3563 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3565 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3567 * eval.c (internal_condition_case, internal_condition_case_1)
3568 (internal_condition_case_2, internal_condition_case_n):
3569 Remove unnecessary aborts (Bug#9081).
3571 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3573 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3574 has no `load' handler, try opening the file locally. (Bug#9311)
3576 2011-08-16 Ken Brown <kbrown@cornell.edu>
3578 * gmalloc.c: Expand comment.
3580 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3582 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3583 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3585 2011-08-16 Ken Brown <kbrown@cornell.edu>
3587 Fix memory allocation problems in Cygwin build (Bug#9273).
3589 * unexcw.c ( __malloc_initialized): Declare external variable.
3590 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3592 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3594 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3596 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3598 [CYGWIN] (special_realloc): New function.
3599 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3600 requests to realloc storage in the static heap.
3602 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3604 * bidi.c (bidi_initialize): Remove unused local.
3606 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3609 * biditype.h: Remove file.
3610 * makefile.w32-in ($(BLD)/bidi.$(O)):
3611 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3613 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3615 * chartab.c: Improve commentary for the uniprop_table API.
3617 * bidi.c (bidi_paragraph_init): Support zero value of
3618 bidi_ignore_explicit_marks_for_paragraph_level.
3619 (bidi_initialize): Use uniprop_table instead of including
3620 biditype.h and bidimirror.h.
3622 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3623 coordinates of the iterator when restoring from ppos_it.
3626 2011-08-14 Kenichi Handa <handa@m17n.org>
3628 * process.c (create_process): Call setup_process_coding_systems
3629 after the pid of the process is set to -1 (Bug#8162).
3631 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3633 * xdisp.c (move_it_in_display_line_to): Don't invoke
3634 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3635 ppos_it. Fixes vertical cursor motion when line beginning is
3636 covered by an image. (Bug#9296)
3638 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3640 * nsterm.h (ns_run_ascript): Declare.
3641 (NSAPP_DATA2_RUNASSCRIPT): Define.
3643 * nsfns.m (as_script, as_result, as_status): New static variables.
3644 (ns_run_ascript): New function.
3645 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3646 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3647 the event loop. Get status from as_status (Bug#7276).
3649 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3650 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3651 the event loop (Bug#7276).
3653 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3655 * gnutls.c (QCgnutls_bootprop_priority)
3656 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3657 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3658 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3659 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3660 (QCgnutls_bootprop_verify_hostname_error)
3661 (QCgnutls_bootprop_callbacks_verify): Rename from
3662 Qgnutls_bootprop_..., all uses changed.
3664 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3667 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3669 * xfaces.c (Qframe_set_background_mode): Now static.
3670 * dispextern.h (Qframe_set_background_mode): Remove decl.
3672 * process.c (Fnetwork_interface_info): Declare local only if needed.
3674 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3676 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3677 (Fnetwork_interface_list): Allocate in increments of bytes instead
3678 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3679 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3681 (struct ifflag_def): notrailers is smart on OSX.
3682 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3683 Get hardware address with getifaddrs if available.
3685 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3687 * xdisp.c (iterate_out_of_display_property): xassert that
3688 IT->position is set to within IT->object's boundaries. Break from
3689 the loop as soon as EOB is reached; avoids infloops in redisplay
3690 when IT->position is set up wrongly due to some bug.
3691 Set IT->current to match the bidi iterator unconditionally.
3692 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3693 entry. Force push_it to save on the stack the current
3694 buffer/string position, to be restored by pop_it. Fix flags in
3695 the iterator structure wrt the object coming from a display
3696 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3697 properties. (Bug#9284)
3699 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3701 * fontset.c (fontset_get_font_group): Add proper type checks.
3704 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3706 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3707 and LC_VERSION_MIN_MACOSX.
3708 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3709 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3711 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3713 * xdisp.c (forward_to_next_line_start): Allow to use the
3714 no-display-properties-and-no-overlays under bidi display.
3715 Set disp_pos in the bidi iterator to avoid searches for display
3716 properties and overlays.
3718 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3720 * editfns.c (Fset_time_zone_rule): Document relationship with the
3723 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3724 the font entity extracted from the cache (Bug#8109).
3726 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3728 * composite.c (autocmp_chars): Don't reset point. That is done by
3729 restore_point_unwind (Bug#5984).
3731 2011-08-07 Juri Linkov <juri@jurta.org>
3733 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3734 to show the arg `TIME' instead of `TIMEVAL'.
3736 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3738 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3739 display property strides EOL and includes a newline, as in
3740 longlines-mode. (Bug#9254)
3741 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3742 word-wrap under bidirectional display. (Bug#9224)
3744 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3745 is non-zero, even if the data buffer is NULL. Fixes a crash in
3746 vertical-motion with longlines-mode. (Bug#9254)
3748 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3750 * bidi.c <bidi_cache_total_alloc>: Now static.
3751 (bidi_initialize): Initialize bidi_cache_total_alloc.
3753 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3756 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3757 amount allocated this far in `bidi_cache_total_alloc'.
3758 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3759 non-zero, only free the data buffer without restoring the cache
3760 contents. All callers changed.
3762 * dispextern.h (bidi_unshelve_cache): Update prototype.
3764 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3765 (move_it_in_display_line, move_it_to)
3766 (move_it_vertically_backward, move_it_by_lines): Replace the call
3767 to xfree to an equivalent call to bidi_unshelve_cache.
3768 (move_it_in_display_line_to): Fix logic of returning
3769 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3771 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3773 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3774 came from a string character with a `cursor' property. (Bug#9229)
3776 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3778 * Makefile.in (LIB_PTHREAD): New variable.
3779 (LIBES): Add LIB_PTHREAD (Bug#9216).
3781 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3782 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3784 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3786 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3788 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3790 * xterm.c (x_find_topmost_parent): New function.
3791 (x_set_frame_alpha): Find topmost parent window with
3792 x_find_topmost_parent and set the property there also (bug#9181).
3793 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3795 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3797 * callproc.c (Fcall_process): Avoid vfork clobbering
3798 the local vars buffer, coding_systems, current_dir.
3800 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3802 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3804 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3806 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3807 so that it is not optimized away.
3809 * xdisp.c (compute_display_string_pos): Remove unused local.
3811 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3813 Fix slow cursor motion and scrolling in large buffers with
3814 selective display, like Org Mode buffers. (Bug#9218)
3816 * dispextern.h (struct bidi_it): New member disp_prop_p.
3818 * xdisp.c: Remove one-slot cache of display string positions.
3819 (compute_display_string_pos): Accept an additional argument
3820 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3821 for a display string or property. If found, set DISP_PROP_P
3824 * bidi.c (bidi_fetch_char): Accept an additional argument
3825 DISP_PROP_P, and pass it to compute_display_string_pos.
3826 Only handle text covered by a display string if DISP_PROP_P is returned
3827 non-zero. All callers of bidi_fetch_char changed.
3829 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3831 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3833 2010-12-03 Don March <don@ohspite.net>
3835 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3836 last character M-[char] is translated to ESC [char] (bug#7541).
3838 2011-08-02 Kenichi Handa <handa@m17n.org>
3840 * lisp.h (uniprop_table): Extern it.
3842 * chartab.c (uniprop_table): Make it non-static.
3844 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3846 * xdisp.c (forward_to_next_line_start): Accept additional argument
3847 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3849 (reseat_at_next_visible_line_start): Use the bidi iterator state
3850 returned by forward_to_next_line_start to restore the state of
3851 it->bidi_it after backing up to previous newline. (Bug#9212)
3853 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3855 * regex.c (re_comp): Protoize.
3856 (re_exec): Fix return type.
3857 (regexec): Fix type of `ret'. (Bug#9203)
3859 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3861 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3862 This is needed if max-image-size is a floating-point number.
3864 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3866 * print.c (print_object): Print empty symbol as ##.
3868 * lread.c (read1): Read ## as empty symbol.
3870 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3872 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3873 setting frame foreground color (Bug#9175).
3874 (x_set_background_color): Likewise.
3876 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3877 contents (Bug#9176).
3878 (EmacsTooltip -init): Remove bezels and add shadows to
3881 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3882 or scroll bar (Bug#8470).
3884 * nsfont.m (nsfont_open): Remove assignment to voffset and
3885 unnecessary vars hshink, expand, hd, full_height, min_height.
3886 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3888 * nsterm.h (nsfont_info): Remove voffset field.
3890 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3892 Implement strike-through and overline on NextStep (Bug#8863).
3894 * nsfont.m (nsfont_open): Use underline position provided by font,
3895 instead of hard-coded value of 2.
3896 (nsfont_draw): Call ns_draw_text_decoration instead.
3898 * nsterm.h: Add declaration for ns_draw_text_decoration.
3900 * nsterm.m (ns_draw_text_decoration): New function for drawing
3901 underline, overline, and strike-through.
3902 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3903 ns_draw_text_decoration. Change treatment of cursor drawing to
3904 accommodate underlining, etc.
3906 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3908 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3911 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3913 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3914 Without this fix, if a signal arrives just after memory fills up,
3915 'malloc' might be invoked reentrantly.
3917 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3918 In other words, assume that every image size is allowed, on non-X
3919 hosts. This assumption is probably wrong, but it lets Emacs compile.
3921 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3923 * regex.c (re_iswctype): Convert return values to boolean.
3925 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3927 * xdisp.c (compute_display_string_pos): Don't use cached display
3928 string position if the buffer had its restriction changed.
3931 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3933 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3935 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3937 Integer signedness and overflow and related fixes. (Bug#9079)
3939 * bidi.c: Integer size and overflow fixes.
3940 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3941 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3942 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3943 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3944 (bidi_find_other_level_edge):
3945 Use ptrdiff_t instead of EMACS_INT where either will do.
3946 This works better on 32-bit hosts configured --with-wide-int.
3947 (bidi_cache_ensure_space): Check for size-calculation overflow.
3948 Use % rather than repeated addition, for better worst-case speed.
3949 Don't set bidi_cache_size until after xrealloc returns, because it
3951 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3952 (bidi_cache_ensure_space): Also check that the bidi cache size
3953 does not exceed that of the largest Lisp string or buffer. See Eli
3954 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3956 * alloc.c (__malloc_size_t): Remove.
3957 All uses replaced by size_t. See Andreas Schwab's note
3958 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3960 * image.c: Improve checking for integer overflow.
3961 (check_image_size): Assume that f is nonnull, since
3962 it is always nonnull in practice. This is one less thing to
3963 worry about when checking for integer overflow later.
3964 (x_check_image_size): New function, which checks for integer
3965 overflow issues inside X.
3966 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3967 This removes the need for a memory_full check.
3968 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3969 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3970 (xbm_read_bitmap_data): Change locals back to 'int', since
3971 their values must fit in 'int'.
3972 (xpm_load_image, png_load, tiff_load):
3973 Invoke x_create_x_image_and_pixmap earlier,
3974 to avoid much needless work if the image is too large.
3975 (tiff_load): Treat overly large images as if
3976 x_create_x_image_and_pixmap failed, not as malloc failures.
3977 (gs_load): Use x_check_image_size.
3979 * gtkutil.c: Omit integer casts.
3980 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3981 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3983 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3985 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3986 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3987 would wrongly return t on a 64-bit host.
3989 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3990 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3991 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3992 and therefore cause GCC to emit a bogus diagnostic in some cases.
3994 * image.c: Integer signedness and overflow and related fixes.
3995 This is not an exhaustive set of fixes, but it's time to
3996 record what I've got.
3997 (lookup_pixel_color, check_image_size): Remove redundant decls.
3998 (check_image_size): Don't assume that arbitrary EMACS_INT values
3999 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4000 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4001 (tiff_load, imagemagick_load_image):
4002 Check for overflow in size calculations.
4003 (x_create_x_image_and_pixmap): Remove unnecessary test for
4004 xmalloc returning NULL; that can't happen.
4005 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4006 (xpm_color_bucket): Use better integer hashing function.
4007 (xpm_cache_color): Don't possibly over-allocate memory.
4008 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4009 (gif_memory_source):
4010 Use ptrdiff_t, not int or size_t, to record sizes.
4011 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4012 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4013 either works, as we prefer signed integers.
4014 (tiff_read_from_memory, tiff_write_from_memory):
4015 Return tsize_t, not size_t, since that's what the TIFF API wants.
4016 (tiff_read_from_memory): Don't fail simply because the read would
4017 go past EOF; instead, return a short read.
4018 (tiff_load): Omit no-longer-needed casts.
4019 (Fimagemagick_types): Don't assume size fits into 'int'.
4021 Improve hashing quality when configured --with-wide-int.
4022 * fns.c (hash_string): New function, taken from sxhash_string.
4023 Do not discard information about ASCII character case; this
4024 discarding is no longer needed.
4025 (sxhash-string): Use it. Change sig to match it. Caller changed.
4026 * lisp.h: Declare it.
4027 * lread.c (hash_string): Remove, since we now use fns.c's version.
4028 The fns.c version returns a wider integer if --with-wide-int is
4029 specified, so this should help the quality of the hashing a bit.
4031 * emacs.c: Integer overflow minor fix.
4032 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4033 Define only if GNU_LINUX.
4034 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4036 * dispnew.c: Integer signedness and overflow fixes.
4037 Remove unnecessary forward decls, that were a maintenance hassle.
4038 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4040 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4041 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4042 (prepare_desired_row, line_draw_cost):
4043 Use int, not unsigned, where either works.
4044 (save_current_matrix, restore_current_matrix):
4045 Use ptrdiff_t, not size_t, where either works.
4046 (init_display): Check for overflow more accurately, and without
4047 relying on undefined behavior.
4049 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4050 Remove, replacing with the new symbols in lisp.h. All uses changed.
4051 * fileio.c (make_temp_name):
4052 * filelock.c (lock_file_1, lock_file):
4053 * xdisp.c (message_dolog):
4054 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4055 Use pMd etc. instead.
4056 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4057 replacing the pWIDE etc. symbols removed from editfns.c.
4059 * keyboard.h (num_input_events): Now uintmax_t.
4060 This is (very slightly) less likely to mess up due to wraparound.
4063 * buffer.c: Integer signedness fixes.
4064 (alloc_buffer_text, enlarge_buffer_text):
4065 Use ptrdiff_t rather than size_t when either will do, as we prefer
4068 * alloc.c: Integer signedness and overflow fixes.
4069 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4070 (__malloc_size_t): Default to size_t, not to int.
4071 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4072 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4073 Prefer ptrdiff_t to size_t when either would do, as we prefer
4075 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4076 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4077 Now const. Initialize with values that are in range even if char
4079 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4080 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4081 These functions do the right thing with sizes > 2**32.
4082 (check_depth): Now ptrdiff_t, not int.
4083 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4084 Adjust to new way of storing sizes. Check for size overflow bugs
4086 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4087 slightly wrong anyway, as it missed one instance of
4088 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4089 (refill_memory_reserve): Omit needless cast to size_t.
4090 (mark_object_loop_halt): Mark as externally visible.
4092 * xselect.c: Integer signedness and overflow fixes.
4093 (Fx_register_dnd_atom, x_handle_dnd_message):
4094 Use ptrdiff_t, not size_t, since we prefer signed.
4095 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4096 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4097 x_dnd_atoms_size and x_dnd_atoms_length.
4099 * doprnt.c: Prefer signed to unsigned when either works.
4101 * doprnt.c (doprnt):
4103 * xdisp.c (vmessage):
4104 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4105 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4106 prefer signed arithmetic to avoid comparison confusion.
4107 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4108 but is a bit tricky.
4110 Assume freestanding C89 headers, string.h, stdlib.h.
4111 * data.c, doprnt.c, floatfns.c, print.c:
4112 Include float.h unconditionally.
4113 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4114 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4115 * regex.c: Likewise for stddef.h, string.h.
4116 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4117 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4118 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4119 (STDC_HEADERS): Remove obsolete defines.
4120 * sysdep.c: Include limits.h unconditionally.
4122 Assume support for memcmp, memcpy, memmove, memset.
4123 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4124 * regex.c (memcmp, memcpy):
4125 Remove; we assume C89 now.
4127 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4128 (__malloc_safe_bcopy): Remove; no longer needed.
4130 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4131 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4132 well either way, and we prefer signed to unsigned.
4134 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4136 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4137 closes the connection while we're reading (bug#9182).
4139 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4141 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4142 are specified (Bug#9168).
4144 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4146 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4147 Found by GCC static checking and --with-wide-int on a 32-bit host.
4149 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4151 * xdisp.c (compute_display_string_pos): Fix logic of caching
4152 previous display string position. Initialize cached_prev_pos to
4153 -1. Fixes slow-down at the beginning of a buffer.
4155 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4157 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4158 for attrs[LFACE_FONTSET_INDEX].
4160 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4162 * xml.c (parse_region): Remove unused local
4163 that was recently introduced.
4165 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4167 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4168 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4170 * xdisp.c (move_it_in_display_line_to): Record the best matching
4171 position for TO_CHARPOS while scanning the line, and restore it on
4172 exit if none of the characters scanned was an exact match.
4173 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4174 when exact match is impossible due to invisible text, and the
4175 lines are truncated.
4177 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4179 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4182 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4184 Fix a significant slow-down of cursor motion with C-n, C-p,
4185 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4186 auto-repeat under bidi redisplay in fontified buffers.
4187 * xdisp.c (compute_stop_pos_backwards): New function.
4188 (next_element_from_buffer): Call compute_stop_pos_backwards to
4189 find a suitable prev_stop when we find ourselves before
4191 (reseat): Don't look for prev_stop, as that could mean a very long
4193 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4194 <cached_disp_overlay_modiff>: Cache for last found display string
4196 (compute_display_string_pos): Return the cached position if asked
4197 about the same buffer in the same area of character positions, and
4198 the buffer wasn't changed since the time the display string
4199 position was cached.
4201 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4203 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4204 is an integer, which is important for empty lines. (Bug#9149)
4206 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4208 * frame.c (Fmodify_frame_parameters): In tty case, update the
4209 default face if necessary (Bug#4238).
4211 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4213 * editfns.c (Fstring_to_char): No need to explain what a character
4214 is in the docstring (Bug#6576).
4216 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4218 * xml.c (parse_region): Make sure we always return a tree.
4220 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4222 * xml.c (parse_region): If a document contains only comments,
4225 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4227 * xml.c (make_dom): Return comments, too.
4229 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4232 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4233 and the surrounding thread.
4234 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4235 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4236 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4238 * s/openbsd.h (BROKEN_SIGIO): Define.
4239 * unexelf.c (unexec) [__OpenBSD__]:
4240 Don't update the .mdebug section of the Alpha COFF symbol table.
4242 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4244 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4247 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4249 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4250 This fixes some race conditions on the permissions of any newly
4253 * alloc.c (valid_pointer_p): Use pipe, not open.
4254 This fixes some permissions issues when debugging.
4256 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4257 If fchown fails to set both uid and gid, try to set just gid,
4258 as that is sometimes allowed. Adjust the file's mode to eliminate
4259 setuid or setgid bits that are inappropriate if fchown fails.
4261 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4263 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4264 to compare Lisp_Objects.
4265 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4266 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4267 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4269 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4271 * lread.c (read_integer): Unread even EOF character.
4272 (read1): Likewise. Properly record start position of symbol.
4274 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4275 symbol character follows.
4277 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4279 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4280 This works around a problem with the previous change to Fcopy_file.
4281 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4282 and without this change, GCC might complain about discarding
4283 fchown's return value.
4285 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4287 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4289 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4291 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4293 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4295 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4296 it's used from the C level.
4298 * process.c: Use the same condition for POLL_FOR_INPUT in both
4299 keyboard.c and process.c (bug#1858).
4301 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4303 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4304 (Fgnutls_boot): Use it.
4306 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4308 * doc.c (Fsubstitute_command_keys): Revert last change.
4310 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4312 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4313 quotes the next character, and doesn't affect other longer
4314 sequences (bug#8935).
4316 * lread.c (syms_of_lread): Clarify that is isn't only
4317 `eval-buffer' and `eval-defun' that's affected by
4318 `lexical-binding' (bug#8460).
4320 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4322 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4323 bidi redisplay when a line includes both an image and is truncated.
4325 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4327 Fix minor problems found by static checking.
4328 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4329 (elsz): Now a signed constant, not a size_t var. We prefer signed
4330 types to unsigned, to avoid integer comparison confusion. Without
4331 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4332 "cannot optimize loop, the loop counter may overflow", a symptom
4334 * indent.c (Fvertical_motion): Mark locals as initialized.
4335 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4337 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4339 * search.c (Fre_search_backward): Mention `case-fold-search' in
4340 all the re_search_* functions (bug#8138).
4342 * keyboard.c (Fopen_dribble_file): Document when the file is
4345 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4347 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4350 Support bidi reordering of display and overlay strings.
4351 * xdisp.c (compute_display_string_pos)
4352 (compute_display_string_end): Accept additional argument STRING.
4353 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4354 (reseat_to_string): Initialize bidi_it->string.s and
4355 bidi_it->string.schars.
4356 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4357 NULL (avoids a crash in bidi_paragraph_init).
4358 Initialize itb.string.lstring.
4359 (init_iterator): Call bidi_init_it only of a valid
4360 buffer position was specified. Initialize paragraph_embedding to
4362 (reseat_to_string): Initialize the bidi iterator.
4363 (display_string): If we need to ignore text properties of
4364 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4365 original value of -1 will not work with bidi.)
4366 (compute_display_string_pos): First arg is now struct
4367 `text_pos *'; all callers changed. Support display properties on
4369 (compute_display_string_end): Support display properties on Lisp
4371 (init_iterator, reseat_1, reseat_to_string): Initialize the
4372 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4373 when iterating on a string not from display properties).
4374 (compute_display_string_pos, compute_display_string_end):
4375 Fix calculation of the object to scan. Fixes an error when using
4377 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4378 base_level_stop; instead, set base_level_stop to BEGV.
4379 Fixes crashes in vertical-motion.
4380 (next_element_from_buffer): Improve commentary for when
4381 the iterator is before prev_stop.
4382 (init_iterator): Initialize bidi_p from the default value of
4383 bidi-display-reordering, not from buffer-local value. Use the
4384 buffer-local value only if initializing for buffer iteration.
4385 (handle_invisible_prop): Support invisible properties on strings
4386 that are being bidi-reordered.
4387 (set_iterator_to_next): Support bidi reordering of C strings and
4389 (next_element_from_string): Support bidi reordering of Lisp
4391 (handle_stop_backwards): Support Lisp strings as well.
4392 (display_string): Support display of R2L glyph rows.
4393 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4394 (init_iterator): Don't initialize it->bidi_p for strings
4396 (reseat_to_string): Initialize it->bidi_p for strings here.
4397 (next_element_from_string, next_element_from_c_string)
4398 (next_element_from_buffer): Add xassert's for correspondence
4399 between IT's object being iterated and it->bidi_it.string
4401 (face_before_or_after_it_pos): Support bidi iteration.
4402 (next_element_from_c_string): Handle the case of the first string
4403 character that is not the first one in the visual order.
4404 (get_visually_first_element): New function, refactored from common
4405 parts of next_element_from_buffer, next_element_from_string, and
4406 next_element_from_c_string.
4407 (tool_bar_lines_needed, redisplay_tool_bar)
4408 (display_menu_bar): Force left-to-right direction. Add a FIXME
4409 comment for making that be controlled by a user option.
4410 (push_it, pop_it): Save and restore the state of the
4411 bidi iterator. Save and restore the bidi_p flag.
4412 (pop_it): Iterate out of display property for string iteration as
4414 (iterate_out_of_display_property): Support iteration over strings.
4415 (handle_single_display_spec): Set up it->bidi_it for iteration
4416 over a display string, and call bidi_init_it.
4417 (handle_single_display_spec, next_overlay_string)
4418 (get_overlay_strings_1, push_display_prop): Set up the bidi
4419 iterator for displaying display or overlay strings.
4420 (forward_to_next_line_start): Don't use the shortcut if
4422 (back_to_previous_visible_line_start): If handle_display_prop
4423 pushed the iterator stack, restore the internal state of the bidi
4424 iterator by calling bidi_pop_it same number of times.
4425 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4426 and we are bidi-iterating, don't decrement the iterator position;
4427 instead, set the first_elt flag in the bidi iterator, to produce
4429 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4430 (push_display_prop): xassert that we are iterating a buffer.
4431 (push_it, pop_it): Save and restore paragraph_embedding member.
4432 (handle_single_display_spec, next_overlay_string)
4433 (get_overlay_strings_1, reseat_1, reseat_to_string)
4434 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4435 correctly. Don't assume unibyte strings are not bidi-reordered.
4436 (compute_display_string_pos)
4437 (compute_display_string_end): Fix handling the case of C string.
4438 (push_it, pop_it): Save and restore from_disp_prop_p.
4439 (handle_single_display_spec, push_display_prop): Set the
4440 from_disp_prop_p flag.
4441 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4442 (pop_it): Call iterate_out_of_display_property only if we are
4443 popping after iteration over a string that came from a display
4444 property. Fix a typo in popping stretch info. Add an assertion
4445 for verifying that the iterator position is in sync with the bidi
4447 (handle_single_display_spec, get_overlay_strings_1)
4448 (push_display_prop): Fix initialization of paragraph direction for
4449 string when that of the parent object is not yet determined.
4450 (reseat_1): Call bidi_init_it to resync the bidi
4451 iterator with IT's position. (Bug#7616)
4452 (find_row_edges): If ROW->start.pos gives position
4453 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4454 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4455 Reset the from_disp_prop_p flag.
4456 (SAVE_IT, RESTORE_IT): New macros.
4457 (pos_visible_p, face_before_or_after_it_pos)
4458 (back_to_previous_visible_line_start)
4459 (move_it_in_display_line_to, move_it_in_display_line)
4460 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4461 (try_scrolling, redisplay_window, display_line): Use them when
4462 saving a temporary copy of the iterator and restoring it back.
4463 (back_to_previous_visible_line_start, reseat_1)
4464 (init_iterator): Empty the bidi cache "stack".
4465 (move_it_in_display_line_to): If iterator ended up at
4466 EOL, but we never saw any buffer positions smaller than
4467 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4468 motion in bidi-reordered lines.
4469 (move_it_in_display_line_to): Record prev_method and prev_pos
4470 immediately before the call to set_iterator_to_next. Fixes cursor
4471 motion in bidi-reordered lines with stretch glyphs and strings
4472 displayed in margins. (Bug#8133) (Bug#8867)
4473 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4475 (pos_visible_p): Support positions in bidi-reordered lines.
4476 Save and restore bidi cache.
4478 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4479 (bidi_paragraph_info): Delete unused struct.
4480 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4481 (bidi_cache_start): New variable.
4482 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4484 (bidi_cache_fetch_state, bidi_cache_search)
4485 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4486 (bidi_cache_find, bidi_peek_at_next_level)
4487 (bidi_level_of_next_char, bidi_find_other_level_edge)
4488 (bidi_move_to_visually_next): Compare cache index with
4489 bidi_cache_start rather than with zero.
4490 (bidi_fetch_char): Accept new argument STRING; all callers
4491 changed. Support iteration over a string. Support strings with
4492 display properties. Support unibyte strings. Fix the type of
4493 `len' according to what STRING_CHAR_AND_LENGTH expects.
4494 (bidi_paragraph_init, bidi_resolve_explicit_1)
4495 (bidi_resolve_explicit, bidi_resolve_weak)
4496 (bidi_level_of_next_char, bidi_move_to_visually_next):
4497 Support iteration over a string.
4498 (bidi_set_sor_type, bidi_resolve_explicit_1)
4499 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4500 can now be zero (for strings); special values 0 and -1 were
4501 changed to -1 and -2, respectively.
4502 (bidi_char_at_pos): New function.
4503 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4504 Call it instead of FETCH_MULTIBYTE_CHAR.
4505 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4506 initialized to valid values.
4507 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4509 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4510 the test for valid cached positions. Fix the logic for looking up
4511 the sentinel state in the cache. GCPRO the Lisp string we are
4513 (bidi_push_it, bidi_pop_it): New functions.
4514 (bidi_initialize): Initialize the bidi cache start stack pointer.
4515 (bidi_cache_ensure_space): New function, refactored from part of
4516 bidi_cache_iterator_state. Don't assume the required size is just
4517 one BIDI_CACHE_CHUNK away.
4518 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4519 (bidi_count_bytes, bidi_char_at_pos): New functions.
4520 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4521 always valid if bidi_cache_idx is valid.
4522 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4523 is valid if it's going to be used.
4524 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4525 (bidi_cache_fetch_state, bidi_cache_search)
4526 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4527 (bidi_cache_iterator_state, bidi_cache_find)
4528 (bidi_find_other_level_edge, bidi_cache_start_stack):
4529 All variables related to cache indices are now EMACS_INT.
4531 * dispextern.h (struct bidi_string_data): New structure.
4532 (struct bidi_it): New member `string'. Make flag members be 1-bit
4533 fields, and put them last in the struct.
4534 (compute_display_string_pos, compute_display_string_end):
4536 (bidi_push_it, bidi_pop_it): Add prototypes.
4537 (struct iterator_stack_entry): New members bidi_p,
4538 paragraph_embedding, and from_disp_prop_p.
4539 (struct it): Member bidi_p is now a bit field 1 bit wide.
4540 (bidi_shelve_cache, bidi_unshelve_cache):
4543 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4544 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4545 and vector-like objects.
4547 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4548 cache around display iteration.
4550 * window.c (Fwindow_end, window_scroll_pixel_based)
4551 (displayed_window_lines, Frecenter): Save and restore the bidi
4552 cache around display iteration.
4554 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4556 * editfns.c (Fdelete_region): Clarify the use of the named
4557 parameters (bug#6788).
4559 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4561 * indent.c (Fvertical_motion): Set and restore w->pointm when
4562 saving and restoring the window's buffer (Bug#9006).
4564 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4566 * editfns.c (Fstring_to_char): Clarify just what is returned
4567 (bug#6576). Text by Eli Zaretskii.
4569 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4571 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4573 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4575 * buffer.c (mmap_find): Fix a typo.
4577 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4579 Fix execution of x selection hooks.
4580 * xselect.c (Qx_lost_selection_functions)
4581 (Qx_sent_selection_functions): New vars.
4582 (syms_of_xselect): DEFSYM them.
4583 (x_handle_selection_request): Pass Qx_sent_selection_functions
4584 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4585 (x_handle_selection_clear,x_clear_frame_selections):
4586 Pass Qx_lost_selection_functions rather than
4587 Vx_lost_selection_functions to Frun_hook_with_args.
4589 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4591 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4592 The old code sometimes used this field without initializing it.
4594 * alloc.c (gc_sweep): Don't read past end of array.
4595 In theory, the old code could also have corrupted Emacs internals,
4596 though it'd be very unlikely.
4598 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4600 * character.c (Fcharacterp): Don't advertise optional ignored
4601 argument. (Bug#4026)
4603 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4605 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4608 * window.c (Fset_window_start): Doc fix (bug#4199).
4609 (Fset_window_hscroll): Ditto.
4611 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4613 Fix minor new problems caught by GCC 4.6.1.
4614 * term.c (init_tty): Remove unused local.
4615 * xsettings.c (store_monospaced_changed): Define this function only
4616 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4619 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4621 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4623 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4625 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4626 are the mini-buffer and the echo area (bug#3320).
4628 * term.c (init_tty): Remove support for supdup, c10 and perq
4629 terminals, which are no longer supported (bug#1482).
4631 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4633 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4635 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4637 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4638 for non-popups (Bug#3642).
4640 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4642 * alloc.c (reset_malloc_hooks): Protoize.
4643 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4644 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4645 * cm.c (losecursor): Likewise.
4646 * data.c (fmod): Likewise.
4647 * dispnew.c (swap_glyphs_in_rows): Likewise.
4648 * emacs.c (memory_warning_signal): Likewise.
4649 * floatfns.c (float_error): Likewise.
4650 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4651 (otf_open, font_otf_capability, generate_otf_features)
4652 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4654 * image.c (pbm_read_file): Likewise.
4655 * indent.c (string_display_width): Likewise.
4656 * intervals.c (check_for_interval, search_for_interval)
4657 (inc_interval_count, count_intervals, root_interval)
4658 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4659 * lread.c (defalias): Likewise.
4660 * ralloc.c (r_alloc_check): Likewise.
4661 * regex.c (set_image_of_range_1, set_image_of_range)
4662 (regex_grow_registers): Likewise.
4663 * sysdep.c (strerror): Likewise.
4664 * termcap.c (valid_filename_p, tprint, main): Likewise.
4665 * tparam.c (main): Likewise.
4666 * unexhp9k800.c (run_time_remap, save_data_space)
4667 (update_file_ptrs, read_header, write_header, calculate_checksum)
4668 (copy_file, copy_rest, display_header): Likewise.
4669 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4671 * xdisp.c (check_it): Likewise.
4672 * xfaces.c (register_color, unregister_color, unregister_colors):
4674 * xfns.c (print_fontset_result): Likewise.
4675 * xrdb.c (member, fatal, main): Likewise.
4677 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4679 Fix minor problems found by static checking (Bug#9031).
4680 * chartab.c (char_table_set_range, map_sub_char_table):
4681 Remove unused locals.
4682 (uniprop_table): Now static.
4683 * composite.c (_work_char): Remove unused static var.
4685 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4687 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4689 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4691 * gtkutil.c (qttip_cb): Remove code without function.
4693 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4695 * w32.c (pthread_sigmask): New stub.
4697 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4699 Use pthread_sigmask, not sigprocmask (Bug#9010).
4700 sigprocmask is portable only for single-threaded applications, and
4701 Emacs can be multi-threaded when it uses GTK.
4702 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4704 * callproc.c (Fcall_process):
4705 * process.c (create_process):
4706 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4707 Use pthread_sigmask, not sigprocmask.
4709 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4711 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4712 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4715 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4717 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4718 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4719 (xg_hide_tooltip): Fix comment.
4721 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4722 in registerServicesMenuSendTypes.
4723 (validRequestorForSendType): Don't check ns_return_types.
4725 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4728 2011-07-08 Jason Rumney <jasonr@gnu.org>
4730 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4731 SH_SHOW for hidden windows (Bug#5482).
4733 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4734 frame struct members of non-existent frames (Bug#6284).
4736 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4738 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4739 variable firstTime not needed on OSX >= 10.6.
4740 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4741 >= 10.5. Use setKnobProportion, setDoubleValue.
4743 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4744 (MAC_OS_X_VERSION_10_5): Define if not defined.
4745 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4746 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4747 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4749 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4750 cString and lossyCString on OSX >= 10.4
4752 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4753 sizeToFit on OSX >= 10.2.
4755 * nsimage.m (allocInitFromFile): Don't use deprecated method
4756 bestRepresentationForDevice on OSX >= 10.6.
4758 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4761 * emacs.c: Declare unexec_init_emacs_zone.
4763 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4765 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4767 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4768 on svcsMenu (Bug#8842).
4770 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4772 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4774 * nsterm.m (QUTF8_STRING): Declare.
4775 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4776 (validRequestorForSendType): Return type is (id).
4777 Change indexOfObjectIdenticalTo to indexOfObject.
4778 Check if we have local selection before returning self (Bug#8842).
4779 (writeSelectionToPasteboard): Put local selection into paste board
4780 if we have a local selection (Bug#8842).
4781 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4783 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4784 (ns_get_local_selection): Declare.
4786 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4788 * keymap.c (describe_map_tree): Don't insert a double newline at
4789 the end of the buffer (bug#1169) and return whether we inserted
4792 * callint.c (Fcall_interactively): Change "reading args" to
4793 "providing args" to try to clarify what it does (bug#1010).
4795 2011-07-07 Kenichi Handa <handa@m17n.org>
4797 * composite.c (composition_compute_stop_pos): Ignore a static
4798 composition starting before CHARPOS (Bug#8915).
4800 * xdisp.c (handle_composition_prop): Likewise.
4802 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4804 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4807 2011-07-07 Kenichi Handa <handa@m17n.org>
4809 * character.h (unicode_category_t): New enum type.
4811 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4812 (Qchar_code_property_table): New variable.
4813 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4814 (UNIPROP_COMPRESSED_FORM_P): New macros.
4815 (char_table_ascii): Uncompress the compressed values.
4816 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4817 Uncompress the compressed values.
4818 (sub_char_table_ref_and_range): Likewise.
4819 (char_table_ref_and_range): Uncompress the compressed values.
4820 (sub_char_table_set): New arg is_uniprop. Callers changed.
4821 Uncompress the compressed values.
4822 (sub_char_table_set_range): Args changed. Callers changed.
4823 (char_table_set_range): Adjuted for the above change.
4824 (map_sub_char_table): Delete args default_val and parent. Add arg
4825 top. Give decoded values to a Lisp function.
4826 (map_char_table): Adjust for the above change. Give decoded
4827 values to a Lisp function. Gcpro more variables.
4828 (uniprop_table_uncompress)
4829 (uniprop_decode_value_run_length): New functions.
4830 (uniprop_decoder, uniprop_decoder_count): New variables.
4831 (uniprop_get_decoder, uniprop_encode_value_character)
4832 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4834 (uniprop_encoder, uniprop_encoder_count): New variables.
4835 (uniprop_get_encoder, uniprop_table)
4836 (Funicode_property_table_internal, Fget_unicode_property_internal)
4837 (Fput_unicode_property_internal): New functions.
4838 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4839 Sunicode_property_table_internal, Sget_unicode_property_internal,
4840 and Sput_unicode_property_internal. Defvar_lisp
4841 char-code-property-alist.
4843 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4844 Vunicode_category_table.
4846 * font.c (font_range): Adjust for the change of
4847 Vunicode_category_table.
4849 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4851 * m/iris4d.h: Remove file, move contents ...
4852 * s/irix6-5.h: ... here.
4854 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4856 Remove unportable assumption about struct layout (Bug#8884).
4857 * alloc.c (mark_buffer):
4858 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4859 (clone_per_buffer_values): Don't assume that
4860 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4861 This isn't true in general, and it's particularly not true
4862 if Emacs is configured with --with-wide-int.
4863 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4864 New macros, used in the buffer.c change.
4866 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4868 * xsettings.c: Use both GConf and GSettings if both are available.
4869 (store_config_changed_event): Add comment.
4870 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4871 (store_tool_bar_style_changed): New functions.
4872 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4873 (struct xsettings): Move font inside HAVE_XFT.
4874 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4875 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4876 Move inside HAVE_XFT.
4877 (something_changed_gsettingsCB): Rename from something_changedCB.
4878 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4880 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4881 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4882 (something_changed_gconfCB): Rename from something_changedCB.
4883 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4884 (parse_settings): Move check for font inside HAVE_XFT.
4885 (read_settings, apply_xft_settings): Add comment.
4886 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4887 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4888 call store_font_name_changed.
4889 (xft_settings_event): Add comment.
4890 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4891 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4892 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4893 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4894 (xsettings_initialize): Call init_gsettings last.
4895 (xsettings_get_system_font, xsettings_get_system_normal_font):
4898 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4900 Random fixes. E.g., (random) never returned negative values.
4901 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4902 subseconds part to the entropy, as that's a bit more random.
4903 Prefer signed to unsigned, since the signedness doesn't matter and
4904 in general we prefer signed. When given a limit, use a
4905 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4906 latter isn't right if USE_2_TAGS_FOR_INTS.
4907 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4908 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4910 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4912 * textprop.c (text_property_stickiness):
4913 Obey Vtext_property_default_nonsticky.
4914 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4915 * w32fns.c (syms_of_w32fns):
4916 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4918 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4920 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4921 This is more efficient than Ffile_directory_p and avoids a minor race.
4923 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4925 * buffer.c (Foverlay_put): Say what the return value is
4928 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4929 is a directory before asking whether to use the file name
4931 (barf_or_query_if_file_exists): Make the "File is a directory"
4932 error be more correct.
4934 * fns.c (Frequire): Remove the mention of the .gz files, since
4935 that's installation-specific, but keep the mention of
4936 `get-load-suffixes'.
4938 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4940 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4941 Report string overflow if the output is too long.
4943 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4945 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4946 (syms_of_gnutls): Remove duplicate DEFSYM for
4947 Qgnutls_bootprop_verify_hostname_error, an error for
4948 Qgnutls_bootprop_verify_error (which is no longer used).
4950 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4951 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4952 Also (re)move comments that are misplaced or no longer relevant.
4954 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4956 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4958 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4960 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4961 and background color parameters if they have been changed.
4963 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4965 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4967 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4969 * xsettings.c (SYSTEM_FONT): Define only when used.
4970 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4972 * keymap.c (access_keymap_1): Now static.
4974 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4976 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4977 leave any prefix arg for the up event (Bug#1586).
4979 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4981 * lread.c (syms_of_lread): Mention single symbols defined by
4982 `defvar' or `defconst' (bug#7154).
4984 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4985 (Frequire): Mention get-load-suffixes.
4987 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4989 * window.h (window): Remove clone_number slot.
4990 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4992 (make_parent_window, make_window, saved_window)
4993 (Fset_window_configuration, save_window_save): Don't deal with
4995 * buffer.c (Qclone_number): Remove declaration.
4996 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4998 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5000 Add multiple inheritance to keymaps.
5001 * keymap.c (Fmake_composed_keymap): New function.
5002 (Fset_keymap_parent): Simplify.
5003 (fix_submap_inheritance): Remove.
5004 (access_keymap_1): New function extracted from access_keymap to handle
5005 embedded parents and handle lists of maps.
5006 (access_keymap): Use it.
5007 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5008 (Fcopy_keymap): Handle embedded parents.
5009 (Fcommand_remapping, define_as_prefix): Simplify.
5010 (Fkey_binding): Simplify.
5011 (syms_of_keymap): Move minibuffer-local-completion-map,
5012 minibuffer-local-filename-completion-map,
5013 minibuffer-local-must-match-map, and
5014 minibuffer-local-filename-must-match-map to Elisp.
5015 (syms_of_keymap): Defsubr make-composed-keymap.
5016 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5017 (parse_menu_item): Trivial simplification.
5019 2011-07-01 Glenn Morris <rgm@gnu.org>
5021 * Makefile.in (SETTINGS_LIBS): Fix typo.
5023 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5025 * coding.c (Fencode_coding_string): Record the last coding system
5026 used, as the function doc string says (bug#8738).
5028 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5030 * xsettings.c (store_monospaced_changed): Take new font as arg and
5031 check for change against current_mono_font.
5032 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5033 (emacs_settings_constructor, emacs_settings_get_property)
5034 (emacs_settings_set_property, emacs_settings_class_init)
5035 (emacs_settings_init, gsettings_obj): Remove.
5036 (something_changedCB): New function for HAVE_GSETTINGS.
5037 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5038 with value as argument.
5039 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5040 g_settings_new (Bug#8967). Do not create gsettings_obj.
5041 Remove calls to g_settings_bind. Connect something_changedCB to
5044 * xgselect.c: Add defined (HAVE_GSETTINGS).
5045 (xgselect_initialize): Ditto.
5047 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5048 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5051 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5053 * eval.c (struct backtrace): Simplify and port the data structure.
5054 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5055 signed bit field, as this assumption is not portable and it makes
5056 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5057 "char debug_on_exit : 1" as this is not portable either; instead,
5058 use the portable "unsigned int debug_on_exit : 1". Remove unused
5059 member evalargs. Remove obsolete comments about cc bombing out.
5061 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5063 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5064 Let HAVE_GSETTINGS override HAVE_GCONF.
5065 (store_monospaced_changed): New function.
5066 (EMACS_SETTINGS): A new type derived from GObject to handle
5067 GSettings notifications.
5068 (emacs_settings_constructor, emacs_settings_get_property)
5069 (emacs_settings_set_property, emacs_settings_class_init):
5071 (gsettings_client, gsettings_obj): New variables.
5072 (GSETTINGS_SCHEMA): New define.
5073 (something_changedCB): Call store_monospaced_changed.
5074 (init_gsettings): New function.
5075 (xsettings_initialize): Call init_gsettings.
5076 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5079 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5082 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5084 * window.c (resize_root_window, grow_mini_window)
5085 (shrink_mini_window): Rename Qresize_root_window to
5086 Qwindow_resize_root_window and Qresize_root_window_vertically to
5087 Qwindow_resize_root_window_vertically.
5089 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5091 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5093 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5095 * makefile.w32-in: Redesign dependencies so they reflect more
5096 clearly which files are directly included by each source file,
5097 and not through other includes.
5099 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5101 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5102 (sort_overlays, overlay_strings): When an overlay's clone number
5103 matches the window's clone number process the overlay even if
5104 the overlay's window property doesn't match the current window.
5106 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5107 (Fwindow_hchild): Rename to Fwindow_left_child.
5108 (Fwindow_next): Rename to Fwindow_next_sibling.
5109 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5110 (resize_window_check): Rename to window_resize_check.
5111 (resize_window_apply): Rename to window_resize_apply.
5112 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5113 (Fdelete_other_windows_internal, resize_frame_windows)
5114 (Fsplit_window_internal, Fdelete_window_internal)
5115 (grow_mini_window, shrink_mini_window)
5116 (Fresize_mini_window_internal): Fix callers accordingly.
5118 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5120 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5121 (emacs_fixed_set_min_size): Remove.
5122 (emacs_fixed_new): Take frame as argument.
5124 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5125 (_EmacsFixedPrivate): Remove minwidth/height.
5126 Add struct frame *f.
5127 (emacs_fixed_init): Initialize priv->f.
5128 (get_parent_class, emacs_fixed_set_min_size): Remove.
5129 (emacs_fixed_new): Set priv->f to argument.
5130 (emacs_fixed_get_preferred_width)
5131 (emacs_fixed_get_preferred_height): Use min_width/height from
5132 frames size_hint to set minimum and natural (Bug#8919).
5133 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5134 and use min_width/height from frames size_hint to set
5135 min_width/height (Bug#8919).
5137 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5138 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5141 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5143 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5144 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5147 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5149 * process.c (wait_reading_process_output): Bypass select if
5150 waiting for a cell while ignoring keyboard input, and input is
5151 pending. Suggested by Jan Djärv (Bug#8869).
5153 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5155 Use gnulib's dup2 module instead of rolling our own.
5156 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5158 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5160 * dispnew.c (scrolling_window): Before scrolling, turn off a
5161 mouse-highlight in the window being scrolled.
5163 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5165 Move DEFSYM to lisp.h and use everywhere.
5167 * character.h (DEFSYM): Move declaration...
5168 * lisp.h (DEFSYM): ...here.
5174 * w32select.c: Don't include character.h.
5176 * alloc.c (syms_of_alloc):
5177 * buffer.c (syms_of_buffer):
5178 * bytecode.c (syms_of_bytecode):
5179 * callint.c (syms_of_callint):
5180 * casefiddle.c (syms_of_casefiddle):
5181 * casetab.c (init_casetab_once):
5182 * category.c (init_category_once, syms_of_category):
5183 * ccl.c (syms_of_ccl):
5184 * cmds.c (syms_of_cmds):
5185 * composite.c (syms_of_composite):
5186 * dbusbind.c (syms_of_dbusbind):
5187 * dired.c (syms_of_dired):
5188 * dispnew.c (syms_of_display):
5189 * doc.c (syms_of_doc):
5190 * editfns.c (syms_of_editfns):
5191 * emacs.c (syms_of_emacs):
5192 * eval.c (syms_of_eval):
5193 * fileio.c (syms_of_fileio):
5194 * fns.c (syms_of_fns):
5195 * frame.c (syms_of_frame):
5196 * fringe.c (syms_of_fringe):
5197 * insdel.c (syms_of_insdel):
5198 * keymap.c (syms_of_keymap):
5199 * lread.c (init_obarray, syms_of_lread):
5200 * macros.c (syms_of_macros):
5201 * msdos.c (syms_of_msdos):
5202 * print.c (syms_of_print):
5203 * process.c (syms_of_process):
5204 * search.c (syms_of_search):
5205 * sound.c (syms_of_sound):
5206 * syntax.c (init_syntax_once, syms_of_syntax):
5207 * terminal.c (syms_of_terminal):
5208 * textprop.c (syms_of_textprop):
5209 * undo.c (syms_of_undo):
5210 * w32.c (globals_of_w32):
5211 * window.c (syms_of_window):
5212 * xdisp.c (syms_of_xdisp):
5213 * xfaces.c (syms_of_xfaces):
5214 * xfns.c (syms_of_xfns):
5215 * xmenu.c (syms_of_xmenu):
5216 * xsettings.c (syms_of_xsettings):
5217 * xterm.c (syms_of_xterm): Use DEFSYM.
5219 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5221 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5223 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5225 Integer and buffer overflow fixes (Bug#8873).
5227 * print.c (printchar, strout): Check for string overflow.
5228 (PRINTPREPARE, printchar, strout):
5229 Don't set size unless allocation succeeds.
5231 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5232 for sizes. Check for string overflow more accurately.
5233 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5235 * macros.c: Integer and buffer overflow fixes.
5236 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5237 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5238 Use ptrdiff_t, not int, for sizes.
5239 Don't increment bufsize until after realloc succeeds.
5240 Check for size-calculation overflow.
5241 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5243 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5245 * lread.c: Integer overflow fixes.
5246 (read_integer): Radix is now EMACS_INT, not int,
5247 to improve quality of diagnostics for out-of-range radices.
5248 Calculate buffer size correctly for out-of-range radices.
5249 (read1): Check for integer overflow in radices, and in
5250 read-circle numbers.
5251 (read_escape): Avoid int overflow.
5252 (Fload, openp, read_buffer_size, read1)
5253 (substitute_object_recurse, read_vector, read_list, map_obarray):
5254 Use ptrdiff_t, not int, for sizes.
5255 (read1): Use EMACS_INT, not int, for sizes.
5256 Check for size overflow.
5258 * image.c (cache_image): Check for size arithmetic overflow.
5260 * lread.c: Integer overflow issues.
5261 (saved_doc_string_size, saved_doc_string_length)
5262 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5263 Now ptrdiff_t, not int.
5264 (read1): Don't assume doc string length fits in int. Check for
5265 out-of-range doc string lengths.
5266 (read_list): Don't assume file position fits in int.
5267 (read_escape): Check for hex character overflow.
5269 2011-06-22 Leo Liu <sdl.web@gmail.com>
5271 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5272 Move to minibuffer.el.
5274 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5276 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5277 The following patches are for when GLYPH_DEBUG && !XASSERT.
5278 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5279 * dispnew.c (flush_stdout):
5280 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5281 Mark as externally visible.
5282 * dispnew.c (check_window_matrix_pointers): Now static.
5283 * dispnew.c (window_to_frame_vpos):
5284 * xfns.c (unwind_create_frame):
5285 * xterm.c (x_check_font): Remove unused local.
5286 * scroll.c (CHECK_BOUNDS):
5287 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5288 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5289 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5290 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5291 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5293 (debug_method_add): Use va_list and vsprintf rather than relying
5294 on undefined behavior with wrong number of arguments.
5295 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5296 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5297 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5298 since we're not interested in debugging glyphs with old libraries.
5299 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5300 GCC 4.6.0's static checking.
5302 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5304 Integer overflow and signedness fixes (Bug#8873).
5305 A few related buffer overrun fixes, too.
5307 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5309 * dispextern.h (struct face.stipple):
5310 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5311 (x_bitmap_mask, x_allocate_bitmap_record)
5312 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5313 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5314 (x_create_bitmap_from_xpm_data):
5315 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5316 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5318 * xfaces.c (load_pixmap):
5319 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5320 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5321 (.bitmaps_last, struct x_output.icon_bitmap):
5322 Use ptrdiff_t, not int, for bitmap indexes.
5323 (x_allocate_bitmap_record): Check for size overflow.
5324 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5326 Use ptrdiff_t, not int, for overlay counts.
5327 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5328 * editfns.c (overlays_around, get_pos_property):
5329 * textprop.c (get_char_property_and_overlay):
5330 * xdisp.c (next_overlay_change, note_mouse_highlight):
5331 * xfaces.c (face_at_buffer_position):
5332 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5333 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5334 (Fnext_overlay_change, Fprevious_overlay_change)
5335 (mouse_face_overlay_overlaps, Foverlays_in):
5336 Use ptrdiff_t, not int, for sizes.
5337 (overlays_at, overlays_in): Check for size-calculation overflow.
5339 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5341 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5342 (x_session_initialize): Do not assume string length fits in int.
5344 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5345 This is unlikely, but can occur if DPI is outlandish.
5347 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5348 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5350 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5351 * xrdb.c (magic_file_p, search_magic_path):
5352 Omit last arg SUFFIX; it was always 0. All callers changed.
5353 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5355 * xfont.c (xfont_match): Avoid need for strlen.
5357 * xfns.c: Don't assume strlen fits in int.
5358 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5360 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5361 not unsigned long, as we prefer signed integers. All callers changed.
5362 Detect integer overflow in repeat count.
5363 (message_dolog): Don't assume print length fits in 39 bytes.
5364 (display_mode_element): Don't assume strlen fits in int.
5366 * termcap.c: Don't assume sizes fit in int and never overflow.
5367 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5368 (gobble_line): Check for size-calculation overflow.
5370 * minibuf.c (Fread_buffer):
5371 * lread.c (intern, intern_c_string):
5372 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5373 Don't assume string length fits in int.
5375 * keyboard.c (parse_tool_bar_item):
5376 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5378 * font.c: Don't assume string length fits in int.
5379 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5380 Use ptrdiff_t, not int.
5381 (font_intern_prop): Don't assume string length fits in int.
5382 Don't assume integer property fits in fixnum.
5383 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5385 * filelock.c: Fix some buffer overrun and integer overflow issues.
5386 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5387 Reformulate so as not to need the command string.
5388 Invoke gzip -cd rather than gunzip, as it's more portable.
5389 (lock_info_type, lock_file_1, lock_file):
5390 Don't assume pid_t and time_t fit in unsigned long.
5391 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5392 (current_lock_owner): Prefer signed type for sizes.
5393 Use memcpy, not strncpy, where memcpy is what is really wanted.
5394 Don't assume (via atoi) that time_t and pid_t fit in int.
5395 Check for time_t and/or pid_t out of range, e.g., via a network share.
5396 Don't alloca where an auto var works fine.
5398 * fileio.c: Fix some integer overflow issues.
5399 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5400 Don't assume string length fits in int.
5401 (directory_file_name): Don't assume string length fits in long.
5402 (make_temp_name): Don't assume pid fits in int, or that its print
5403 length is less than 20.
5405 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5407 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5409 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5411 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5412 We prefer signed integers, even for size calculations.
5414 * emacs.c: Don't assume string length fits in 'int'.
5415 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5416 (main): Don't invoke strlen when not needed.
5418 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5419 (XD_DEBUG_MESSAGE): Don't waste a byte.
5421 * callproc.c (getenv_internal_1, getenv_internal)
5423 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5425 * lread.c (invalid_syntax): Omit length argument.
5426 All uses changed. This doesn't fix a bug, but it simplifies the
5427 code away from its former Hollerith-constant appearance, and it's
5428 one less 'int' to worry about when looking at integer-overflow issues.
5429 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5431 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5432 This didn't break anything, but it didn't help either.
5433 It's confusing to put a bogus integer in a place where the actual
5434 value does not matter.
5435 (LIST_END_P): Remove unused macro and its bogus comment.
5436 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5438 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5439 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5441 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5442 We prefer signed types, and the value cannot exceed the EMACS_INT
5443 range anyway (because otherwise the length would not be representable).
5444 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5445 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5446 This avoids a GCC warning when WIDE_EMACS_INT.
5448 * indent.c (sane_tab_width): New function.
5449 (current_column, scan_for_column, Findent_to, position_indentation)
5450 (compute_motion): Use it. This is just for clarity.
5451 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5453 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5455 * lisp.h (lint_assume): New macro.
5456 * composite.c (composition_gstring_put_cache):
5457 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5459 * editfns.c, insdel.c:
5460 Omit unnecessary forward decls, to simplify future changes.
5462 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5464 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5466 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5467 Use much-faster test for byte-length change.
5468 Don't assume string byte-length fits in 'int'.
5469 Check that character arg fits in 'int'.
5470 (mapcar1): Declare byte as byte, for clarity.
5472 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5474 * fns.c (concat): Catch string overflow earlier.
5475 Do not rely on integer wraparound.
5477 * dispextern.h (struct it.overlay_strings_charpos)
5478 (struct it.selective): Now EMACS_INT, not int.
5479 * xdisp.c (forward_to_next_line_start)
5480 (back_to_previous_visible_line_start)
5481 (reseat_at_next_visible_line_start, next_element_from_buffer):
5482 Don't arbitrarily truncate the value of 'selective' to int.
5484 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5486 * composite.c: Don't truncate sizes to 'int'.
5487 (composition_gstring_p, composition_reseat_it)
5488 (composition_adjust_point): Use EMACS_INT, not int.
5489 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5490 not EMACS_UINT, for indexes.
5492 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5494 * buffer.c: Include <verify.h>.
5495 (struct sortvec.priority, struct sortstr.priority):
5496 Now EMACS_INT, not int.
5497 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5498 (struct sortstr.size, record_overlay_string)
5499 (struct sortstrlist.size, struct sortlist.used):
5500 Don't truncate size to int.
5501 (record_overlay_string): Check for size-calculation overflow.
5502 (init_buffer_once): Check at compile-time, not run-time.
5504 2011-06-22 Jim Meyering <meyering@redhat.com>
5506 Don't leak an XBM-image-sized buffer
5507 * image.c (xbm_load): Free the image buffer after using it.
5509 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5512 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5513 that Sun C diagnosed.
5514 * fns.c (secure_hash): Fix pointer signedness issue.
5515 * intervals.c (static_offset_intervals): New function.
5516 (offset_intervals): Use it.
5518 2011-06-21 Leo Liu <sdl.web@gmail.com>
5521 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5524 * fns.c (secure_hash): Rename from crypto_hash_function and change
5525 the first arg to accept symbols.
5526 (Fsecure_hash): New primitive.
5527 (syms_of_fns): New symbols.
5529 2011-06-20 Deniz Dogan <deniz@dogan.se>
5531 * process.c (Fset_process_buffer): Clarify return value in
5534 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5536 * dispnew.c (add_window_display_history): Use BVAR.
5538 * xdisp.c (debug_method_add): Use BVAR.
5539 (check_window_end, dump_glyph_matrix, dump_glyph)
5540 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5542 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5545 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5546 check till after the cache is created in init_frame_faces.
5548 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5550 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5552 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5554 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5555 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5556 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5558 Improve buffer-overflow checking (Bug#8873).
5559 * fileio.c (Finsert_file_contents):
5560 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5561 Remove the old (too-loose) buffer overflow checks.
5562 They weren't needed, since make_gap checks for buffer overflow.
5563 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5564 The old code merely checked for Emacs fixnum overflow, and relied
5565 on undefined (wraparound) behavior. The new code avoids undefined
5566 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5568 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5569 Tune. Don't use wider integers than needed. Don't use alloca.
5570 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5572 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5574 * insdel.c, lisp.h (buffer_overflow): New function.
5575 (insert_from_buffer_1, replace_range, replace_range_2):
5576 * insdel.c (make_gap_larger):
5577 * editfns.c (Finsert_char):
5578 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5580 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5582 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5584 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5586 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5587 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5589 * fileio.c: Don't assume EMACS_INT fits in off_t.
5590 (emacs_lseek): New static function.
5591 (Finsert_file_contents, Fwrite_region): Use it.
5592 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5594 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5596 * fns.c: Don't overflow int when computing a list length.
5597 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5598 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5599 truncation on 64-bit hosts. Check for QUIT every
5600 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5601 faster and is responsive enough.
5602 (Flength): Report an error instead of overflowing an integer.
5603 (Fsafe_length): Return a float if the value is not representable
5604 as a fixnum. This shouldn't happen except in contrived situations.
5605 (Fnthcdr, Fsort): Don't assume list length fits in int.
5606 (Fcopy_sequence): Don't assume vector length fits in int.
5608 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5609 (header_size, word_size): New constants.
5610 (allocate_vectorlike): Don't check size overflow here.
5611 (allocate_vector): Check it here instead, since this is the only
5612 caller of allocate_vectorlike that could cause overflow.
5613 Check that the new vector's length is representable as a fixnum.
5615 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5616 The previous code was bogus. For example, next_almost_prime (32)
5617 returned 39, which is undesirable as it is a multiple of 3; and
5618 next_almost_prime (24) returned 25, which is a multiple of 5 so
5619 why was the code bothering to check for multiples of 7?
5621 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5623 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5625 Variadic C functions now count arguments with ptrdiff_t.
5626 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5627 Back then I didn't know that the Emacs coding style prefers signed int.
5628 Also, in the meantime I found a few more instances where arguments
5629 were being counted with int, which may truncate counts on 64-bit
5630 machines, or EMACS_INT, which may be unnecessarily wide.
5631 * lisp.h (struct Lisp_Subr.function.aMANY)
5632 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5633 Arg counts are now ptrdiff_t, not size_t.
5634 All variadic functions and their callers changed accordingly.
5635 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5636 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5637 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5638 * callint.c (Fcall_interactively): Check arg count for overflow,
5639 to avoid potential buffer overrun. Use signed char, not 'int',
5640 for 'varies' array, so that we needn't bother to check its size
5641 calculation for overflow.
5642 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5643 * eval.c (apply_lambda):
5644 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5645 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5646 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5648 * callint.c (Fcall_interactively): Don't use index var as event count.
5650 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5651 * mem-limits.h (SIZE): Remove; no longer used.
5653 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5655 Remove unnecessary casts.
5656 * xterm.c (x_term_init):
5657 * xfns.c (x_set_border_pixel):
5658 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5659 These aren't needed now that we assume ANSI C.
5661 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5662 It's more likely to cause problems (due to unsigned overflow)
5665 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5667 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5669 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5671 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5673 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5675 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5677 GLYPH_CODE_FACE returns EMACS_INT, not int.
5678 * dispextern.h (merge_faces):
5679 * xfaces.c (merge_faces):
5680 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5681 Don't assume EMACS_INT fits in int.
5683 * character.h (CHAR_VALID_P): Remove unused parameter.
5684 * fontset.c, lisp.h, xdisp.c: All uses changed.
5686 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5688 * fns.c (concat): Minor tuning based on overflow analysis.
5689 This doesn't fix any bugs. Use int to hold character, instead
5690 of constantly refetching from Emacs object. Use XFASTINT, not
5691 XINT, for value known to be a character. Don't bother comparing
5692 a single byte to 0400, as it's always less.
5694 * floatfns.c (Fexpt):
5695 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5697 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5700 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5702 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5703 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5704 incorrectly succeed when S was a string, because 4294967386 was
5705 truncated before it was used.
5707 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5708 Otherwise, an out-of-range integer could cause undefined behavior
5711 * composite.c: Use int, not EMACS_INT, for characters.
5712 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5713 EMACS_INT, for values that are known to be in character range.
5714 This doesn't fix any bugs but is the usual style inside Emacs and
5715 may generate better code on 32-bit machines.
5717 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5718 This is for reasons similar to the recent CHAR_STRING fix.
5719 * charset.c (Fencode_char): Check that character arg is actually
5720 a character. Pass an int to ENCODE_CHAR.
5721 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5722 wider than 'int', as a compile-time check to prevent future regressions
5725 * character.c (char_string): Remove unnecessary casts.
5727 Make sure a 64-bit char is never passed to CHAR_STRING.
5728 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5729 by silently ignoring the top 32 bits, allowing some values
5730 that were far too large to be valid characters.
5731 * character.h: Include <verify.h>.
5732 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5733 arguments are no wider than unsigned, as a compile-time check
5734 to prevent future regressions in this area.
5736 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5737 (Fsubst_char_in_region):
5739 * xdisp.c (decode_mode_spec_coding):
5740 Adjust to CHAR_STRING's new requirement.
5741 * editfns.c (Finsert_char, Fsubst_char_in_region):
5742 * fns.c (concat): Check that character args are actually
5743 characters. Without this test, these functions did the wrong
5744 thing with wildly out-of-range values on 64-bit hosts.
5746 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5747 These casts should not be needed on 32-bit hosts, either.
5748 * keyboard.c (read_char):
5749 * lread.c (Fload): Remove casts to unsigned.
5751 * lisp.h (UNSIGNED_CMP): New macro.
5752 This fixes comparison bugs on 64-bit hosts.
5753 (ASCII_CHAR_P): Use it.
5754 * casefiddle.c (casify_object):
5755 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5756 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5757 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5758 * dispextern.h (FACE_FROM_ID):
5759 * keyboard.c (read_char): Use UNSIGNED_CMP.
5761 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5762 not to EMACS_INT, to avoid GCC warning.
5764 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5766 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5767 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5768 isn't needed on 32-bit machines.
5770 * buffer.c (Fgenerate_new_buffer_name):
5771 Use EMACS_INT for count, not int.
5772 (advance_to_char_boundary): Return EMACS_INT, not int.
5774 * data.c (Qcompiled_function): Now static.
5776 * window.c (window_body_lines): Now static.
5778 * image.c (gif_load): Rename local to avoid shadowing.
5780 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5781 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5782 * alloc.c (make_save_value): Integer argument is now of type
5784 (mark_object): Use ptrdiff_t, not int.
5785 * lisp.h (pD): New macro.
5786 * print.c (print_object): Use it.
5788 * alloc.c: Use EMACS_INT, not int, to count objects.
5789 (total_conses, total_markers, total_symbols, total_vector_size)
5790 (total_free_conses, total_free_markers, total_free_symbols)
5791 (total_free_floats, total_floats, total_free_intervals)
5792 (total_intervals, total_strings, total_free_strings):
5793 Now EMACS_INT, not int. All uses changed.
5794 (Fgarbage_collect): Compute overall total using a double, so that
5795 integer overflow is less likely to be a problem. Check for overflow
5796 when converting back to an integer.
5797 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5798 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5799 These were 'int' variables that could overflow on 64-bit hosts;
5800 they were never used, so remove them instead of repairing them.
5801 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5802 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5803 Previously, this ceilinged at INT_MAX, but that doesn't work on
5805 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5807 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5808 (allocate_vectorlike): Check for ptrdiff_t overflow.
5809 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5810 when a (possibly-narrower) signed value would do just as well.
5811 We prefer using signed arithmetic, to avoid comparison confusion.
5813 * alloc.c: Catch some string size overflows that we were missing.
5814 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5815 for convenience in STRING_BYTES_MAX.
5816 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5817 The definition here is exact; the one in lisp.h was approximate.
5818 (allocate_string_data): Check for string overflow. This catches
5819 some instances we weren't catching before. Also, it catches
5820 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5821 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5822 and ptrdiff_t and EMACS_INT are both 64 bits.
5824 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5825 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5826 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5828 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5830 * alloc.c (Fmake_string): Check for out-of-range init.
5832 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5834 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5836 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5838 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5839 xg_get_default_scrollbar_width.
5841 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5842 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5843 (style_changed_cb): Call update_theme_scrollbar_width and call
5844 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5845 all frames (Bug#8505).
5846 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5847 Call gtk_window_set_resizable if HAVE_GTK3.
5848 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5849 and height if HAVE_GTK3 (Bug#8505).
5850 (scroll_bar_width_for_theme): New variable.
5851 (update_theme_scrollbar_width): New function.
5852 (xg_get_default_scrollbar_width): Move code to
5853 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5854 (xg_initialize): Call update_theme_scrollbar_width.
5856 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5858 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5860 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5862 * frame.c (make_frame): Call other_buffer_safely instead of
5865 * window.c (temp_output_buffer_show): Call display_buffer with
5866 second argument Vtemp_buffer_show_specifiers and reset latter
5867 immediately after the call.
5868 (Vtemp_buffer_show_specifiers): New variable.
5869 (auto_window_vscroll_p, next_screen_context_lines)
5870 (Vscroll_preserve_screen_position): Remove leading asterisks from
5873 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5875 Fix minor problems found by GCC 4.6.0 static checking.
5876 * buffer.c (Qclone_number): Remove for now, as it's unused.
5877 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5878 (record_buffer): Remove unused local.
5879 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5880 (set_frame_buffer_list): Remove; unused.
5881 * frame.h (other_visible_frames): Remove decl.
5882 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5883 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5884 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5886 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5887 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5888 Define only if HAVE_GPM.
5889 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5890 (update_hints_inhibit): Remove; never set. All uses removed.
5891 * widgetprv.h (emacsFrameClassRec): Remove decl.
5892 * window.c (delete_deletable_window): Now returns void, since it
5893 wasn't returning anything.
5894 (compare_window_configurations): Remove unused locals.
5895 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5896 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5897 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5898 the same widths as pointers. This follows up on the 2011-05-06 patch.
5899 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5900 * xterm.h: Likewise.
5901 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5903 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5905 * makefile.w32-in: Update dependencies.
5906 (LISP_H): Add lib/intprops.h.
5908 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5910 * image.c (gif_load): Add animation frame delay to the metadata.
5911 (syms_of_image): Use DEFSYM. New symbol `delay'.
5913 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5915 * window.c (delete_deletable_window): Re-add.
5916 (Fset_window_configuration): Rewrite to handle dead buffers and
5917 consequently deletable windows.
5918 (window_tree, Fwindow_tree): Remove. Supply functionality in
5920 (compare_window_configurations): Simplify code.
5922 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5924 * image.c (imagemagick_load_image): Fix type mismatch.
5925 (Fimagemagick_types): Likewise.
5927 * window.h (replace_buffer_in_windows): Declare.
5929 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5931 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5932 Qclone_number. Remove external declaration of Qdelete_window.
5933 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5935 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5936 Run Qbuffer_list_update_hook if allowed.
5937 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5938 buffer list implementation.
5939 (other_buffer_safely): New function.
5940 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5941 calls to replace_buffer_in_windows and
5942 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5944 (record_buffer): Inhibit quitting and rewrite using quittable
5945 functions. Run Qbuffer_list_update_hook if allowed.
5946 (Frecord_buffer, Funrecord_buffer): New functions.
5947 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5948 Move switch-to-buffer to window.el.
5949 (bury-buffer): Move to window.el.
5950 (Vbuffer_list_update_hook): New variable.
5952 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5955 * window.h (resize_frame_windows): Move up in code.
5956 (Fwindow_frame): Remove EXFUN.
5957 (replace_buffer_in_all_windows): Remove prototype.
5958 (replace_buffer_in_windows_safely): Add prototype.
5960 * window.c: Declare Qdelete_window static again. Move down
5961 declaration of select_count.
5962 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5963 (Fother_window): Move to window.el.
5964 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5965 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5966 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5968 (replace_buffer_in_windows): Implement by calling
5969 Qreplace_buffer_in_windows.
5970 (replace_buffer_in_all_windows): Remove with some functionality
5971 moved into replace_buffer_in_windows_safely.
5972 (replace_buffer_in_windows_safely): New function.
5973 (select_window_norecord, select_frame_norecord): Move in front
5974 of run_window_configuration_change_hook. Remove now obsolete
5976 (Fset_window_buffer): Rewrite doc-string.
5977 Call Qrecord_window_buffer.
5978 (keys_of_window): Move binding for other-window to window.el.
5980 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5982 * dispextern.h (struct image): Replace data member, whose int_val
5983 and ptr_val fields were not used by anything, with a single
5986 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5987 (gif_clear_image, gif_load, imagemagick_load_image)
5988 (gs_clear_image, gs_load): Callers changed.
5990 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5992 * buffer.h: Include <time.h>, for time_t.
5993 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5995 Fix minor problems found by static checking.
5997 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5999 Make identifiers static if they are not used in other modules.
6000 * data.c (Qcompiled_function, Qframe, Qvector):
6001 * image.c (QimageMagick, Qsvg):
6002 * minibuf.c (Qmetadata):
6003 * window.c (resize_window_check, resize_root_window): Now static.
6004 * window.h (resize_window_check, resize_root_window): Remove decls.
6006 * window.c (window_deletion_count, delete_deletable_window):
6008 (window_body_lines): Now static.
6009 (Fdelete_other_windows_internal): Mark vars as initialized.
6010 Make sure 'resize_failed' is initialized.
6011 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6012 (resize_window_apply): Remove unused local.
6013 * window.h (delete_deletable_window): Remove decl.
6015 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6016 (imagemagick_load_image): Fix pointer signedness problem by changing
6017 last arg from unsigned char * to char *. All uses changed.
6018 Also, fix a local for similar reasons.
6019 Remove unused locals. Remove locals to avoid shadowing.
6020 (fn_rsvg_handle_free): Remove; unused.
6021 (svg_load, svg_load_image): Fix pointer signedness problem.
6022 (imagemagick_load_image): Don't use garbage pointer image_wand.
6024 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6026 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6028 * image.c (gif_load): Fix omitted cast error introduced by
6031 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6033 * window.h (resize_proportionally, orig_total_lines)
6034 (orig_top_line): Remove from window structure.
6035 (set_window_height, set_window_width, change_window_heights)
6036 (Fdelete_window): Remove prototypes.
6037 (resize_frame_windows): Remove duplicate declaration.
6039 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6041 * window.h (resize_frame_windows, resize_window_check)
6042 (delete_deletable_window, resize_root_window)
6043 (resize_frame_windows): Declare prototypes.
6045 * window.c (resize_window_apply): Make definition be "static" to
6046 match the prototype.
6048 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6050 * window.c: Remove declarations of Qwindow_size_fixed,
6051 window_min_size_1, window_min_size_2, window_min_size,
6052 size_window, window_fixed_size_p, enlarge_window, delete_window.
6053 Remove static from declaration of Qdelete_window, it's
6054 temporarily needed by Fbury_buffer.
6055 (replace_window): Don't assign orig_top_line and
6057 (Fdelete_window, delete_window): Remove. Window deletion is
6058 handled by window.el.
6059 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6060 Replace Fdelete_window calls with calls to Qdelete_window.
6061 (Fdelete_other_windows): Remove. Deleting other windows is
6062 handled by window.el.
6063 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6064 handled in window.el.
6065 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6066 Window minimum sizes are handled in window.el.
6067 (shrink_windows, size_window, set_window_height)
6068 (set_window_width, change_window_heights, window_height)
6069 (window_width, CURBEG, CURSIZE, enlarge_window)
6070 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6071 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6072 handled in window.el.
6073 (make_dummy_parent): Rename to make_parent_window and give it a
6074 second argument horflag.
6075 (make_window): Don't set resize_proportionally any more.
6076 (Fsplit_window): Remove. Windows are split in window.el.
6077 (save_restore_action, save_restore_orig_size)
6078 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6079 Resize mini windows in window.el.
6080 (grow_mini_window, shrink_mini_window): Implement by calling
6081 Qresize_root_window_vertically, resize_window_check and
6082 resize_window_apply.
6083 (saved_window, Fset_window_configuration, save_window_save):
6084 Do not handle orig_top_line, orig_total_lines, and
6085 resize_proportionally.
6086 (window_min_height, window_min_width): Move to window.el.
6087 (keys_of_window): Move bindings for delete-other-windows,
6088 split-window, delete-window and enlarge-window to window.el.
6090 * buffer.c: Temporarily extern Qdelete_window.
6091 (Fbury_buffer): Temporarily call Qdelete_window instead of
6092 Fdelete_window (Fbury_buffer will move to window.el soon).
6094 * frame.c (set_menu_bar_lines_1): Remove code handling
6095 orig_top_line and orig_total_lines.
6097 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6098 set_window_height but set heights directly.
6099 (change_frame_size_1): Use resize_frame_windows.
6101 * xdisp.c (init_xdisp): Don't use set_window_height but set
6104 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6105 Use resize_frame_windows instead of change_window_heights and run
6106 run_window_configuration_change_hook.
6108 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6109 instead of change_window_heights and run
6110 run_window_configuration_change_hook.
6112 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6114 * window.c (replace_window): Rename second argument REPLACEMENT to
6115 NEW. New third argument SETFLAG. Rewrite.
6116 (delete_window, make_dummy_parent): Call replace_window with
6118 (window_list_1): Move down in code.
6119 (run_window_configuration_change_hook): Move set_buffer part
6120 before select_frame_norecord part in order to unwind correctly.
6121 Rename count1 to count.
6122 (recombine_windows, delete_deletable_window, resize_root_window)
6123 (Fdelete_other_windows_internal)
6124 (Frun_window_configuration_change_hook, make_parent_window)
6125 (resize_window_check, resize_window_apply, Fresize_window_apply)
6126 (resize_frame_windows, Fsplit_window_internal)
6127 (Fdelete_window_internal, Fresize_mini_window_internal):
6129 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6131 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6133 * window.h (window): Add some new members to window structure -
6134 normal_lines, normal_cols, new_total, new_normal, clone_number,
6135 splits, nest, prev_buffers, next_buffers.
6136 (WINDOW_TOTAL_SIZE): Move here from window.c.
6137 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6139 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6141 (make_dummy_parent): Set new members of windows structure.
6142 (make_window): Move down in code. Handle new members of window
6144 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6145 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6146 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6147 (Fset_window_prev_buffers, Fwindow_next_buffers)
6148 (Fset_window_next_buffers, Fset_window_clone_number):
6150 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6151 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6153 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6154 Argument WINDOW can be now internal window too.
6155 (Fwindow_use_time): Move up in code.
6156 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6158 (Fset_window_configuration, saved_window)
6159 (Fcurrent_window_configuration, save_window_save): Handle new
6160 members of window structure.
6161 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6162 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6163 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6164 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6165 Qget_mru_window, Qresize_root_window,
6166 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6167 Qauto_buffer_name; staticpro them.
6169 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6171 * window.c (Fwindow_total_size, Fwindow_left_column)
6172 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6173 (Fwindow_list_1): New functions.
6174 (window_box_text_cols): Replace with window_body_cols.
6175 (Fwindow_width, Fscroll_left, Fscroll_right):
6176 Use window_body_cols instead of window_box_text_cols.
6177 (delete_window, Fset_window_configuration):
6178 Call delete_all_subwindows with window as argument.
6179 (delete_all_subwindows): Take a window as argument and not a
6181 (window_loop): Remove handling of GET_LRU_WINDOW and
6183 (Fget_lru_window, Fget_largest_window): Move to window.el.
6185 * window.h: Extern window_body_cols instead of
6186 window_box_text_cols. delete_all_subwindows now takes a
6187 Lisp_Object as argument.
6189 * indent.c (compute_motion, Fcompute_motion):
6190 Use window_body_cols instead of window_box_text_cols.
6192 * frame.c (delete_frame): Call delete_all_subwindows with root
6195 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6197 * fns.c (Fputhash): Document return value.
6199 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6201 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6203 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6205 Cons<->int and similar integer overflow fixes (Bug#8794).
6207 Check for overflow when converting integer to cons and back.
6208 * charset.c (Fdefine_charset_internal, Fdecode_char):
6209 Use cons_to_unsigned to catch overflow.
6210 (Fencode_char): Use INTEGER_TO_CONS.
6211 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6212 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6213 * data.c (long_to_cons, cons_to_long): Remove.
6214 (cons_to_unsigned, cons_to_signed): New functions.
6215 These signal an error for invalid or out-of-range values.
6216 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6217 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6218 * font.c (Ffont_variation_glyphs):
6219 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6220 * lisp.h: Include <intprops.h>.
6221 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6222 (cons_to_signed, cons_to_unsigned): New decls.
6223 (long_to_cons, cons_to_long): Remove decls.
6224 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6225 (Fprimitive_undo): Use CONS_TO_INTEGER.
6226 * xfns.c (Fx_window_property): Likewise.
6227 * xselect.c: Include <limits.h>.
6228 (x_own_selection, selection_data_to_lisp_data):
6229 Use INTEGER_TO_CONS.
6230 (x_handle_selection_request, x_handle_selection_clear)
6231 (x_get_foreign_selection, Fx_disown_selection_internal)
6232 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6233 (lisp_data_to_selection_data): Use cons_to_unsigned.
6234 (x_fill_property_data): Use cons_to_signed.
6235 Report values out of range.
6237 Check for buffer and string overflow more precisely.
6238 * buffer.h (BUF_BYTES_MAX): New macro.
6239 * lisp.h (STRING_BYTES_MAX): New macro.
6240 * alloc.c (Fmake_string):
6241 * character.c (string_escape_byte8):
6242 * coding.c (coding_alloc_by_realloc):
6243 * doprnt.c (doprnt):
6244 * editfns.c (Fformat):
6246 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6247 since they may not be the same number.
6248 * editfns.c (Finsert_char):
6249 * fileio.c (Finsert_file_contents):
6250 Likewise for BUF_BYTES_MAX.
6252 * image.c: Use ptrdiff_t, not int, for sizes.
6253 (slurp_file): Switch from int to ptrdiff_t.
6255 (slurp_file): Check that file size fits in both size_t (for
6256 malloc) and ptrdiff_t (for sanity and safety).
6258 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6259 if b->modtime has its maximal value.
6261 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6263 Don't assume time_t can fit into int.
6264 * buffer.h (struct buffer.modtime): Now time_t, not int.
6265 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6266 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6268 Minor fixes for signed vs unsigned integers.
6269 * character.h (MAYBE_UNIFY_CHAR):
6270 * charset.c (maybe_unify_char):
6271 * keyboard.c (read_char, reorder_modifiers):
6272 XINT -> XFASTINT, since the integer must be nonnegative.
6273 * ftfont.c (ftfont_spec_pattern):
6274 * keymap.c (access_keymap, silly_event_symbol_error):
6275 XUINT -> XFASTINT, since the integer must be nonnegative.
6276 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6277 since it makes no difference and we prefer signed.
6278 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6279 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6282 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6284 * window.h (Fwindow_frame): Declare.
6286 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6288 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6289 (SPARE_MEMORY): Always define.
6290 (LARGE_REQUEST): Remove.
6291 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6293 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6295 * lisp.h: Move EXFUNS for Fframe_root_window,
6296 Fframe_first_window and Fset_frame_selected_window to window.h.
6298 * window.h: Move EXFUNS for Fframe_root_window,
6299 Fframe_first_window and Fset_frame_selected_window here from
6302 * frame.c (Fwindow_frame, Fframe_first_window)
6303 (Fframe_root_window, Fframe_selected_window)
6304 (Fset_frame_selected_window): Move to window.c.
6305 (Factive_minibuffer_window): Move to minibuf.c.
6306 (Fother_visible_frames_p): New function.
6308 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6310 * window.c (decode_window, decode_any_window): Move up in code.
6311 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6312 (inhibit_frame_unsplittable): Remove unused variable.
6313 (Fwindow_buffer): Move up and rewrite doc-string.
6314 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6315 (Fwindow_prev): New functions.
6316 (Fwindow_frame): Move here from frame.c. Accept any window as
6318 (Fframe_root_window, Fframe_first_window)
6319 (Fframe_selected_window): Move here from frame.c. Accept frame
6320 or arbitrary window as argument. Update doc-strings.
6321 (Fminibuffer_window): Move up in code.
6322 (Fwindow_minibuffer_p): Move up in code and simplify.
6323 (Fset_frame_selected_window): Move here from frame.c.
6325 (Fselected_window, select_window, Fselect_window): Move up in
6326 code. Minor doc-string fixes.
6328 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6330 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6331 Do not assume that spare memory exists; that assumption is valid
6332 only if SYSTEM_MALLOC.
6333 (LARGE_REQUEST): New macro, so that the issue of large requests
6334 is separated from the issue of spare memory.
6336 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6338 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6341 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6343 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6346 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6348 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6350 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6352 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6353 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6355 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6357 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6359 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6361 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6362 (x_clipboard_manager_save): Add return value.
6363 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6365 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6366 Obey Vx_select_enable_clipboard_manager. Catch errors in
6367 x_clipboard_manager_save (Bug#8779).
6368 (Vx_select_enable_clipboard_manager): New variable.
6369 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6371 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6373 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6375 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6377 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6378 in the current matrix if keep_current_p is non-zero.
6380 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6382 * bidi.c (bidi_level_of_next_char): Fix last change.
6384 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6386 Support bidi reordering of text covered by display properties.
6388 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6389 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6390 (bidi_cache_search, bidi_cache_iterator_state)
6391 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6392 (bidi_level_of_next_char, bidi_move_to_visually_next):
6393 Support character positions inside a run of characters covered by a
6395 (bidi_paragraph_init, bidi_resolve_explicit_1)
6396 (bidi_level_of_next_char): Call bidi_fetch_char and
6397 bidi_fetch_char_advance instead of FETCH_CHAR and
6399 (bidi_init_it): Initialize new members.
6400 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6402 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6403 instead of using explicit *_CHAR codes.
6404 (bidi_resolve_explicit, bidi_resolve_weak):
6405 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6406 bidirectional text is supported only in multibyte buffers.
6407 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6408 it to initialize the frame_window_p member of struct bidi_it.
6409 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6410 (bidi_resolve_explicit, bidi_resolve_weak)
6411 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6412 bidi_it->nchars is non-positive.
6413 (bidi_level_of_next_char): Don't try to lookup the cache for the
6414 next/previous character if nothing is cached there yet, or if we
6415 were just reseat()'ed to a new position.
6417 * xdisp.c (set_cursor_from_row): Set start and stop points
6418 according to the row's direction when priming the loop that looks
6419 for the glyph on which to display cursor.
6420 (single_display_spec_intangible_p): Function deleted.
6421 (display_prop_intangible_p): Reimplement to call
6422 handle_display_spec instead of single_display_spec_intangible_p.
6423 Accept 3 additional arguments needed by handle_display_spec.
6424 This fixes incorrect cursor motion across display property with complex
6425 values: lists, `(when COND...)' forms, etc.
6426 (single_display_spec_string_p): Support property values that are
6427 lists with the argument STRING its top-level element.
6428 (display_prop_string_p): Fix the condition for processing a
6429 property that is a list to be consistent with handle_display_spec.
6430 (handle_display_spec): New function, refactored from the
6431 last portion of handle_display_prop.
6432 (compute_display_string_pos): Accept additional argument
6433 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6434 value of a `display' property is a "replacing spec".
6435 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6436 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6437 the display property, but just return a value indicating whether
6438 the display property will replace the characters it covers.
6439 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6440 frame_window_p members of struct bidi_it.
6441 (compute_display_string_pos, compute_display_string_end):
6443 (push_it): Accept second argument POSITION, where pop_it should
6444 jump to continue iteration.
6445 (reseat_1): Initialize bidi_it.disp_pos.
6447 * keyboard.c (adjust_point_for_property): Adjust the call to
6448 display_prop_intangible_p to its new signature.
6450 * dispextern.h (struct bidi_it): New member frame_window_p.
6451 (bidi_init_it): Update prototypes.
6452 (display_prop_intangible_p): Update prototype.
6453 (compute_display_string_pos, compute_display_string_end):
6455 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6458 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6460 Malloc failure behavior now depends on size of allocation.
6461 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6462 * lisp.h: Change signatures accordingly.
6463 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6464 All callers changed. (Bug#8762)
6466 * gnutls.c: Use Emacs's memory allocators.
6467 Without this change, the gnutls library would invoke malloc etc.
6468 directly, which causes problems on non-SYNC_INPUT hosts, and which
6469 runs afoul of improving memory_full behavior. (Bug#8761)
6470 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6471 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6472 xfree instead of the default malloc, realloc, free.
6473 (Fgnutls_boot): No need to check for memory allocation failure,
6474 since xmalloc does that for us.
6476 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6477 * category.c (hash_get_category_set):
6478 * ccl.c (ccl_driver):
6479 * charset.c (Fdefine_charset_internal):
6480 * charset.h (struct charset.hash_index):
6481 * composite.c (get_composition_id, gstring_lookup_cache)
6482 (composition_gstring_put_cache):
6483 * composite.h (struct composition.hash_index):
6484 * dispextern.h (struct image.hash):
6485 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6486 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6487 (hashfn_equal, hashfn_user_defined, make_hash_table)
6488 (maybe_resize_hash_table, hash_lookup, hash_put)
6489 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6490 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6491 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6492 * image.c (make_image, search_image_cache, lookup_image)
6493 (xpm_put_color_table_h):
6494 * lisp.h (struct Lisp_Hash_Table):
6495 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6496 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6497 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6498 * alloc.c (allocate_vectorlike):
6499 Check for overflow in vector size calculations.
6500 * ccl.c (ccl_driver):
6501 Check for overflow when converting EMACS_INT to int.
6502 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6503 need to be updated by these changes.
6504 * fns.c (make_hash_table, maybe_resize_hash_table):
6505 Check for integer overflow with large hash tables.
6506 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6507 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6508 (SXHASH_REDUCE): New macro.
6509 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6510 Use it instead of discarding useful hash info with large hash values.
6511 (sxhash_float): New function.
6512 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6513 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6514 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6515 Rewrite to use FIXNUM_BITS, as this simplifies things.
6516 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6517 Adjust signatures to match updated version of code.
6518 (consing_since_gc): Now EMACS_INT, since a single hash table can
6519 use more than INT_MAX bytes.
6521 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6523 Make it possible to build with GCC-4.6+ -O2 -flto.
6525 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6527 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6529 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6530 Call minibuffer-inactive-mode.
6532 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6534 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6535 Update dependencies.
6537 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6539 * data.c (init_data): Remove code for UTS, this system is not
6542 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6544 Don't force ./temacs to start in terminal mode.
6546 * frame.c (make_initial_frame): Initialize faces in all cases, not
6547 only when CANNOT_DUMP is defined.
6548 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6550 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6552 * dispnew.c (add_window_display_history): Use const for the string
6553 pointer. Remove declaration, not needed.
6555 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6557 Use 'inline', not 'INLINE'.
6558 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6559 * alloc.c, fontset.c (INLINE): Remove.
6560 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6561 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6562 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6563 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6564 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6566 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6568 Make it possible to run ./temacs.
6570 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6571 syms_of_callproc does the same thing. Remove test for
6572 "initialized", do it in the caller.
6573 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6575 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6577 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6578 (read_minibuf): Use get_minibuffer.
6579 (syms_of_minibuf): Use DEFSYM.
6580 (Qmetadata): New var.
6581 * data.c (Qbuffer): Don't make it static.
6582 (syms_of_data): Use DEFSYM.
6584 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6586 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6587 (CCL_CODE_MIN): New macro.
6589 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6591 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6593 * eval.c (Qdebug): Now static.
6594 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6595 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6596 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6598 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6600 * image.c: Various fixes to ImageMagick code comments.
6601 (Fimagemagick_types): Doc fix.
6603 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6605 Minor fixes prompted by GCC 4.6.0 warnings.
6607 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6609 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6610 (x_clipboard_manager_save_all): Move extern decl to ...
6611 * xterm.h: ... here, so that it can be checked for consistency.
6613 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6615 * xselect.c (x_clipboard_manager_save_frame)
6616 (x_clipboard_manager_save_all): New functions.
6617 (Fx_clipboard_manager_save): Lisp function deleted.
6619 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6620 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6622 * xterm.h: Update prototype.
6624 2011-05-28 William Xu <william.xwl@gmail.com>
6626 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6629 2011-05-28 Jim Meyering <meyering@redhat.com>
6631 Avoid a sign-extension bug in crypto_hash_function.
6632 * fns.c (to_uchar): Define.
6633 (crypto_hash_function): Use it to convert some newly-signed
6634 variables to unsigned, to avoid sign-extension bugs. For example,
6635 without this change, (md5 "truc") would evaluate to
6636 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6637 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6638 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6640 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6642 Integer overflow fixes.
6644 * dbusbind.c: Serial number integer overflow fixes.
6645 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6646 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6647 to hold a serial number that is too large for a fixnum.
6648 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6649 Check for serial numbers out of range. Decode any serial number
6650 that was so large that it became a float. (Bug#8722)
6652 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6653 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6654 Use XFASTINT rather than XUINT when numbers are nonnegative.
6655 (xd_append_arg, Fdbus_method_return_internal):
6656 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6657 arguments, check that Lisp number is nonnegative, rather than
6658 silently wrapping negative numbers around. (Bug#8722)
6659 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6662 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6664 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6666 ccl: Add integer overflow checks.
6667 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6668 (IN_INT_RANGE): New macros.
6669 (ccl_driver): Use them to check for integer overflow when
6670 decoding a CCL program. Many of the new checks are whether XINT (x)
6671 fits in int; it doesn't always, on 64-bit hosts. The new version
6672 doesn't catch all possible integer overflows, but it's an
6673 improvement. (Bug#8719)
6675 * alloc.c (make_event_array): Use XINT, not XUINT.
6676 There's no need for unsigned here.
6678 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6679 This follows up to the 2011-05-06 change that substituted uintptr_t
6680 for EMACS_INT. This case wasn't caught back then.
6682 Rework Fformat to avoid integer overflow issues.
6683 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6684 now (part of C89). Include <verify.h>.
6685 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6686 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6687 (Fformat): Avoid the prepass trying to compute sizes; it was only
6688 approximate and thus did not catch overflow reliably. Instead, walk
6689 through the format just once, formatting and computing sizes as we go,
6690 checking for integer overflow at every step, and allocating a larger
6691 buffer as needed. Keep track separately whether the format is
6692 multibyte. Keep only the most-recently calculated precision, rather
6693 than them all. Record whether each argument has been converted to
6694 string. Use EMACS_INT, not int, for byte and char and arg counts.
6695 Support field widths and precisions larger than INT_MAX. Avoid
6696 sprintf's undefined behavior with conversion specifications such as %#d
6697 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6698 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6699 formatting out-of-range floating point numbers with int
6702 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6704 * data.c: Avoid integer truncation in expressions involving floats.
6705 * data.c: Include <intprops.h>.
6706 (arith_driver): When there's an integer overflow in an expression
6707 involving floating point, convert the integers to floating point
6708 so that the resulting value does not suffer from catastrophic
6709 integer truncation. For example, on a 64-bit host (* 4
6710 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6711 Do not rely on undefined behavior after integer overflow.
6713 merge count_size_as_multibyte, parse_str_to_multibyte
6714 * character.c, character.h (count_size_as_multibyte):
6715 Rename from parse_str_to_multibyte; all uses changed.
6716 Check for integer overflow.
6717 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6718 since it's now a duplicate of the other. This is more of
6719 a character than a buffer op, so better that it's in character.c.
6720 * fns.c, print.c: Adjust to above changes.
6722 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6724 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6726 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6728 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6729 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6730 (x_clipboard_manager_save): Now static.
6731 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6733 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6734 (crypto_hash_function): Now static.
6735 Fix pointer signedness problems. Avoid unnecessary initializations.
6737 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6739 * termhooks.h (Vselection_alist): Make it terminal-local.
6741 * terminal.c (create_terminal): Initialize it.
6743 * xselect.c: Support for clipboard managers.
6744 (Vselection_alist): Move to termhooks.h as terminal-local var.
6745 (LOCAL_SELECTION): New macro.
6746 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6747 (symbol_to_x_atom): Remove gratuitous arg.
6748 (x_handle_selection_request, lisp_data_to_selection_data)
6749 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6750 (x_own_selection, x_get_local_selection, x_convert_selection):
6751 New arg, specifying work frame. Use terminal-local Vselection_alist.
6752 (some_frame_on_display): Delete unused function.
6753 (Fx_own_selection_internal, Fx_get_selection_internal)
6754 (Fx_disown_selection_internal, Fx_selection_owner_p)
6755 (Fx_selection_exists_p): New optional frame arg.
6756 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6757 (x_handle_selection_clear): Don't treat other terminals with the
6758 same keyboard specially. Use the terminal-local Vselection_alist.
6759 (x_clear_frame_selections): Use Frun_hook_with_args.
6761 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6763 * xterm.h: Add support for those atoms.
6765 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6767 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6768 (converted_selections, conversion_fail_tag): New global variables.
6769 (x_selection_request_lisp_error): Free the above.
6770 (x_get_local_selection): Remove unnecessary code.
6771 (x_reply_selection_request): Args changed; handle arbitrary array
6772 of converted selections stored in converted_selections.
6773 Separate the XChangeProperty and SelectionNotify steps.
6774 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6775 (x_convert_selection): New function.
6776 (x_handle_selection_event): Simplify.
6777 (x_get_foreign_selection): Don't ignore incoming requests while
6778 waiting for an answer; this will fail when we implement
6779 SAVE_TARGETS, and seems unnecessary anyway.
6780 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6781 (Vx_sent_selection_functions): Doc fix.
6783 2011-05-26 Leo Liu <sdl.web@gmail.com>
6785 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6787 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6789 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6791 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6792 for fringe update if it has periodic bitmap.
6793 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6794 and fringe_bitmap_periodic_p.
6796 * fringe.c (get_fringe_bitmap_data): New function.
6797 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6798 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6799 row. Mark glyph row for fringe update if periodicity changed.
6801 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6802 for fringe update unless it has periodic bitmap.
6804 2011-05-25 Kenichi Handa <handa@m17n.org>
6806 * xdisp.c (get_next_display_element): Set correct it->face_id for
6807 a static composition.
6809 2011-05-24 Leo Liu <sdl.web@gmail.com>
6812 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6814 * fns.c (crypto_hash_function, Fsha1): New function.
6815 (Fmd5): Use crypto_hash_function.
6816 (syms_of_fns): Add Ssha1.
6818 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6820 * gnutls.c: Remove unused macros.
6821 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6822 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6823 Remove macros that are defined and never used.
6824 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6826 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6828 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6829 (Fx_get_selection_internal): Minor cleanup.
6830 (Fx_own_selection_internal): Rename arguments for consistency with
6833 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6835 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6837 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6839 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6841 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6843 * dispnew.c (scrolling_window): Don't exclude the case that the
6844 last enabled row in the desired matrix touches the bottom boundary.
6846 2011-05-21 Glenn Morris <rgm@gnu.org>
6848 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6849 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6850 and add some more files.
6852 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6854 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6855 report_file_error introduced by the change from 2011-05-07.
6857 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6859 * systime.h (Time): Define only if emacs is defined.
6860 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6861 where the include path doesn't have X11/X.h by default. See
6862 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6864 2011-05-20 Kenichi Handa <handa@m17n.org>
6866 * composite.c (find_automatic_composition): Fix previous change.
6868 2011-05-20 Glenn Morris <rgm@gnu.org>
6870 * lisp.mk: New file, split from Makefile.in.
6871 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6872 (shortlisp): Remove.
6873 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6875 2011-05-19 Glenn Morris <rgm@gnu.org>
6877 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6878 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6879 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6880 (lisp): Set the order to that of loadup.el.
6881 (shortlisp): Make it a copy of $lisp.
6882 (SOME_MACHINE_LISP): Remove.
6883 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6884 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6886 2011-05-18 Kenichi Handa <handa@m17n.org>
6888 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6889 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6890 (find_automatic_composition): Mostly rewrite for efficiency.
6892 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6894 * makefile.w32-in: Update dependencies.
6896 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6898 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6899 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6901 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6903 Fix some integer overflow issues, such as string length overflow.
6905 * insdel.c (count_size_as_multibyte): Check for string overflow.
6907 * character.c (lisp_string_width): Check for string overflow.
6908 Use EMACS_INT, not int, for string indexes and lengths; in
6909 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6910 the resulting string length overflows an EMACS_INT; instead,
6911 report a string overflow if no precision given. When checking for
6912 precision exhaustion, use a check that cannot possibly have
6913 integer overflow. (Bug#8675)
6914 * character.h (lisp_string_width): Adjust to new signature.
6916 * alloc.c (string_overflow): New function.
6917 (Fmake_string): Use it. This doesn't change behavior, but saves
6918 a few bytes and will simplify future changes.
6919 * character.c (string_escape_byte8): Likewise.
6920 * lisp.h (string_overflow): New decl.
6922 Fixups, following up to the user-interface timestamp change.
6923 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6924 for UI timestamps, instead of unsigned long.
6925 * msdos.c (mouse_get_pos): Likewise.
6926 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6927 * w32gui.h (Time): Define by including "systime.h" rather than by
6928 declaring it ourselves. (Bug#8664)
6930 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6931 * image.c (clear_image_cache): Likewise.
6933 * term.c (term_mouse_position): Don't assume time_t wraparound.
6935 Be more systematic about user-interface timestamps.
6936 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6937 and sometimes 'EMACS_UINT', to represent these timestamps.
6938 This change causes it to use 'Time' uniformly, as that's what X uses.
6939 This makes the code easier to follow, and makes it easier to catch
6940 integer overflow bugs such as Bug#8664.
6941 * frame.c (Fmouse_position, Fmouse_pixel_position):
6942 Use Time, not unsigned long, for user-interface timestamps.
6943 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6944 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6945 * keyboard.h (last_event_timestamp): Likewise.
6946 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6947 * menu.h (xmenu_show): Likewise.
6948 * term.c (term_mouse_position): Likewise.
6949 * termhooks.h (struct input_event.timestamp): Likewise.
6950 (struct terminal.mouse_position_hook): Likewise.
6951 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6952 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6953 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6954 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6956 * menu.h, termhooks.h: Include "systime.h", for Time.
6958 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6959 Don't assume that the difference between two unsigned long values
6960 can fit into an integer. At this point, we know button_down_time
6961 <= event->timestamp, so the difference must be nonnegative, so
6962 there's no need to cast the result if double-click-time is
6963 nonnegative, as it should be; check that it's nonnegative, just in
6964 case. This bug is triggered when events are more than 2**31 ms
6965 apart (about 25 days). (Bug#8664)
6967 * xselect.c (last_event_timestamp): Remove duplicate decl.
6968 (x_own_selection): Remove needless cast to unsigned long.
6970 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6971 that always fit in int. Use a sentinel instead of a counter, to
6972 avoid a temp and to allay GCC's concerns about possible int overflow.
6973 * frame.h (struct frame): Use int for menu_bar_items_used
6974 instead of EMACS_INT, since it always fits in int.
6976 * menu.c (grow_menu_items): Check for int overflow.
6978 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6980 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6981 Before, the code was not consistent. These values cannot exceed
6982 2**31 - 1 so there's no need to make them unsigned.
6983 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6984 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6985 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6987 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6989 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6990 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6991 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6992 presumably because the widths might not match.
6994 * window.c (size_window): Avoid needless test at loop start.
6996 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6998 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7000 2011-05-12 Drew Adams <drew.adams@oracle.com>
7002 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7004 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7006 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7007 `width' to `bar_area_x' and `bar_area_width', respectively.
7008 (x_scroll_run): Take account of fringe background extension.
7010 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7011 Rename local vars `left' and `width' to `bar_area_x' and
7012 `bar_area_width', respectively.
7013 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7014 background extension.
7016 2011-05-10 Jim Meyering <meyering@redhat.com>
7018 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7020 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7022 * image.c (Finit_image_library): Return t for built-in image types,
7023 like pbm and xbm. (Bug#8640)
7025 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7027 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7029 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7031 * w32console.c (Fset_screen_color): Doc fix.
7032 (Fget_screen_color): New function.
7033 (syms_of_ntterm): Defsubr it.
7035 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7036 unlink the temporary file if Fcall_process didn't create it in the
7038 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7039 child process will be redirected to a file specified with `:file'.
7040 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7041 cue to call_process_cleanup not to close that handle.
7043 2011-05-07 Ben Key <bkey76@gmail.com>
7045 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7046 one of two shell specific rules, either bootstrap-temacs-CMD or
7047 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7048 to the previous implementation of the bootstrap-temacs rule.
7049 The bootstrap-temacs-CMD rule is similar to the previous
7050 implementation of the bootstrap-temacs rule except that it
7051 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7054 These changes, along with some changes to nt/configure.bat,
7055 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7056 earlier fix to add support for --cflags and --ldflags options
7057 that include quotes so that it works whether make uses cmd or
7060 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7062 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7063 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7065 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7066 a string. Handle both cases.
7067 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7068 (Fdbus_register_method): Use Qinvalid_function.
7070 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7072 * makefile.w32-in: Update dependencies.
7073 (LISP_H): Add inttypes.h and stdin.h.
7074 (PROCESS_H): Add unistd.h.
7076 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7078 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7079 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7081 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7083 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7085 * term.c (vfatal): Remove stray call to va_end.
7086 It's not needed and the C Standard doesn't allow it here anyway.
7088 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7089 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7091 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7094 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7096 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7098 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7100 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7102 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7104 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7105 * charset.c (Fdefine_charset_internal): Don't initialize
7106 charset.code_space[15]. The value was garbage, on hosts with
7107 32-bit int (Bug#8600).
7109 * lread.c (read_integer): Be more consistent with string-to-number.
7110 Use string_to_number to do the actual conversion; this avoids
7111 rounding errors and fixes some other screwups. Without this fix,
7112 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7113 (digit_to_number): Move earlier, for benefit of read_integer.
7114 Return -1 if the digit is out of range for the base, -2 if it is
7115 not a digit in any supported base. (Bug#8602)
7117 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7119 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7120 to match comment at start of function. This also removes a
7121 GCC warning about overflow in a 32+64-bit port.
7123 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7125 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7126 Reported by Stefan Monnier in
7127 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7128 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7129 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7131 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7132 (EMACS_UINTPTR): Likewise, with uintptr_t.
7134 * lisp.h: Prefer 64-bit EMACS_INT if available.
7135 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7136 on 32-bit hosts that have 64-bit int, so that they can access
7138 However, temporarily disable this change unless the temporary
7139 symbol WIDE_EMACS_INT is defined.
7141 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7143 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7144 This removes an assumption that EMACS_INT and long are the same
7145 width as pointers. The assumption is true for Emacs porting targets
7146 now, but we want to make other targets possible.
7147 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7148 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7149 In the rest of the code, change types of integers that hold casted
7150 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7151 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7152 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7153 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7154 No need to cast type when ORing.
7155 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7156 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7157 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7158 assume EMACS_INT is the same width as char *.
7159 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7160 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7161 Remove no-longer-needed casts.
7162 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7163 (xg_tool_bar_help_callback, xg_make_tool_item):
7164 Use EMACS_INTPTR to hold an integer
7165 that will be cast to void *; this can avoid a GCC warning
7166 if EMACS_INT is not the same width as void *.
7167 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7168 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7169 (current_message_1, set_message_1):
7170 Use a local to convert to proper width without a cast.
7171 * xmenu.c (dialog_selection_callback): Likewise.
7173 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7174 Also, don't assume VALBITS / RAND_BITS is less than 5,
7175 and don't rely on undefined behavior when shifting a 1 left into
7177 * lisp.h (get_random): Change signature to match.
7179 * lread.c (hash_string): Use size_t, not int, for hash computation.
7180 Normally we prefer signed values; but hashing is special, because
7181 it's better to use unsigned division on hash table sizes so that
7182 the remainder is nonnegative. Also, size_t is the natural width
7183 for hashing into memory. The previous code used 'int', which doesn't
7184 retain enough info to hash well into very large tables.
7185 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7187 * dbusbind.c: Don't possibly lose pointer info when converting.
7188 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7189 Use XPNTR rather than XHASH, so that the high-order bits of
7190 the pointer aren't lost when converting through void *.
7192 * eval.c (Fautoload): Don't double-shift a pointer.
7194 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7196 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7198 * gnutls.c (DEF_GNUTLS_FN):
7199 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7201 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7203 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7206 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7208 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7209 New version that can reserve upto 2GB of heap space.
7211 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7213 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7215 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7217 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7218 `gnutls_certificate_set_x509_key_file'.
7220 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7222 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7223 Update dependencies.
7225 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7227 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7228 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7229 Remove unused parameter `fildes'.
7230 * process.c (read_process_output, send_process): Don't pass it.
7232 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7234 Fix previous change: the library cache is defined in w32.c.
7235 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7236 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7238 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7240 Implement dynamic loading of GnuTLS on Windows.
7242 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7243 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7244 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7247 * gnutls.c (Qgnutls_dll): Define.
7248 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7249 (gnutls_*): Declare function pointers.
7250 (init_gnutls_functions): New function to initialize function pointers.
7251 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7252 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7253 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7254 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7255 (emacs_gnutls_write, emacs_gnutls_read)
7256 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7257 (Fgnutls_available_p): New function.
7258 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7259 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7260 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7262 * image.c: Include w32.h.
7263 (Vimage_type_cache): Delete.
7264 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7265 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7266 (w32_delayed_load): Move to w32.c.
7268 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7270 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7271 (w32_delayed_load): Move from image.c. When loading a library, record
7272 its filename in the :loaded-from property of the library id.
7273 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7274 Initialize and staticpro them.
7275 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7277 * process.c: Include lisp.h before w32.h, not after.
7278 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7279 instead of gnutls_record_check_pending.
7281 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7283 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7285 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7286 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7289 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7291 * xterm.c (x_set_frame_alpha): Do not set property on anything
7292 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7294 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7296 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7298 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7300 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7301 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7302 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7303 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7304 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7305 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7306 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7307 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7308 (Qgnutls_bootprop_callbacks_verify): Make static.
7310 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7312 * callproc.c: Indentation fixup.
7314 * sysdep.c (wait_for_termination_1): Make static.
7315 (wait_for_termination, interruptible_wait_for_termination):
7316 Move after wait_for_termination_1.
7318 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7320 * sysdep.c (interruptible_wait_for_termination): New function
7321 which is like wait_for_termination, but allows keyboard
7324 * callproc.c (Fcall_process): Add (:file "file") as an option for
7326 (Fcall_process_region): Ditto.
7328 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7330 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7331 rather than `XVECTOR (FOO)->size'.
7333 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7334 inttypes.h, as a gnulib replacement is used if it not available in
7337 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7339 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7340 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7341 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7343 * coding.c (coding_alloc_by_realloc): Error out if destination
7344 will grow beyond MOST_POSITIVE_FIXNUM.
7345 (decode_coding_emacs_mule): Abort if there isn't enough place in
7346 charbuf for the composition carryover bytes. Reserve an extra
7347 space for up to 2 characters produced in a loop.
7348 (decode_coding_iso_2022): Abort if there isn't enough place in
7349 charbuf for the composition carryover bytes.
7351 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7353 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7354 aborting when %lld or %lll format is passed.
7355 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7356 %llo or %llx format is passed. (Bug#8545)
7358 * window.c (window_scroll_line_based): Use a marker instead of
7359 simple variables to record original value of point. (Bug#7952)
7361 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7362 produced by %s or %c overflows available buffer space. (Bug#8545)
7364 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7366 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7367 (SIZE_MAX): Move defn after all includes, as they might #define it.
7369 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7371 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7373 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7375 * keyboard.c (Qdelayed_warnings_hook): Define.
7376 (command_loop_1): Run `delayed-warnings-hook'
7377 if Vdelayed_warnings_list is non-nil.
7378 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7379 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7381 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7383 * doprnt.c (doprnt): Don't return value smaller than the buffer
7384 size if the message was truncated. (Bug#8545).
7386 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7388 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7389 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7391 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7393 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7395 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7397 * makefile.w32-in: Update dependencies.
7399 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7401 Improve `doprnt' and its usage. (Bug#8545)
7402 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7403 `format_end'. Remove support for %l as a conversion specifier.
7404 Don't use xrealloc. Improve diagnostics when the %l size modifier
7405 is used. Update the commentary.
7407 * eval.c (verror): Simplify calculation of size_t.
7409 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7412 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7414 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7417 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7419 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7420 This makes this file independent of the recent pseudovector change.
7422 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7424 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7426 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7427 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7428 Remove unused local.
7429 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7431 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7432 GCC 4.6.0 optimizes based on type-based alias analysis.
7433 For example, if b is of type struct buffer * and v of type struct
7434 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7435 != &v->size, and therefore "v->size = 1; b->size = 2; return
7436 v->size;" must therefore return 1. This assumption is incorrect
7437 for Emacs, since it type-puns struct Lisp_Vector * with many other
7438 types. To fix this problem, this patch adds a new type struct
7439 vectorlike_header that documents the constraints on layout of vectors
7440 and pseudovectors, and helps optimizing compilers not get fooled
7441 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7442 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7443 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7445 (XSETPVECTYPE): Rewrite in terms of new macro.
7446 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7447 This is a bit clearer, and further avoids the possibility of
7448 undesirable aliasing.
7449 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7450 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7451 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7452 since Lisp_Subr is a special case (no "next" field).
7453 (ASIZE): Now uses header.size rather than size.
7454 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7455 to avoid the hassle of writing XVECTOR (foo)->header.size.
7456 (struct vectorlike_header): New type.
7457 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7458 object, to help avoid aliasing.
7459 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7460 (SUBRP): Likewise, since Lisp_Subr is a special case.
7461 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7462 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7463 (struct Lisp_Hash_Table): Combine first two members into a single
7464 struct vectorlike_header member. All uses of "size" and "next" members
7465 changed to be "header.size" and "header.next".
7466 * buffer.h (struct buffer): Likewise.
7467 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7468 * frame.h (struct frame): Likewise.
7469 * process.h (struct Lisp_Process): Likewise.
7470 * termhooks.h (struct terminal): Likewise.
7471 * window.c (struct save_window_data, struct saved_window): Likewise.
7472 * window.h (struct window): Likewise.
7473 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7474 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7475 * buffer.c (init_buffer_once): Likewise.
7476 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7478 * process.c (Fformat_network_address): Use local var for size,
7481 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7483 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7484 * data.c (atof): Remove decl; no longer used or needed.
7485 (digit_to_number): Move to lread.c.
7486 (Fstring_to_number): Use new string_to_number function, to be
7487 consistent with how the Lisp reader treats infinities and NaNs.
7488 Do not assume that floating-point numbers represent EMACS_INT
7489 without losing information; this is not true on most 64-bit hosts.
7490 Avoid double-rounding errors, by insisting on integers when
7491 parsing non-base-10 numbers, as the documentation specifies.
7492 * lisp.h (string_to_number): New decl, replacing ...
7493 (isfloat_string): Remove.
7494 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7495 (read1): Do not accept +. and -. as integers; this
7496 appears to have been a coding error. Similarly, do not accept
7497 strings like +-1e0 as floating point numbers. Do not report
7498 overflow for integer overflows unless the base is not 10 which
7499 means we have no simple and reliable way to continue.
7500 Break out the floating-point parsing into a new
7501 function string_to_number, so that Fstring_to_number parses
7502 floating point numbers consistently with the Lisp reader.
7503 (digit_to_number): Move here from data.c. Make it static inline.
7504 (E_CHAR, EXP_INT): Remove, replacing with ...
7505 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7506 (string_to_number): New function, replacing isfloat_string.
7507 This function checks for valid syntax and produces the resulting
7508 Lisp float number too. Rework it so that string-to-number
7509 no longer mishandles examples like "1.0e+". Use strtoumax,
7510 so that overflow for non-base-10 numbers is reported only when
7511 there's no portable and simple way to convert to floating point.
7513 * textprop.c (set_text_properties_1): Rewrite for clarity,
7514 and to avoid GCC warning about integer overflow.
7516 * intervals.h (struct interval): Use EMACS_INT for members
7517 where EMACS_UINT might cause problems. See
7518 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7519 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7520 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7522 (offset_intervals): Tell GCC not to worry about length overflow
7523 when negating a negative length.
7525 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7526 (overrun_check_free): Likewise.
7528 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7529 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7532 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7533 (gnutls_make_error): Rename local to avoid shadowing.
7534 (gnutls_emacs_global_deinit): ifdef out; not used.
7535 (Fgnutls_boot): Use const for pointer to readonly storage.
7536 Comment out unused local. Fix pointer signedness problems.
7538 * lread.c (openp): Don't stuff size_t into an 'int'.
7539 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7540 about possible signed overflow.
7542 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7543 (GDK_KEY_g): Don't define if already defined.
7544 (xg_prepare_tooltip): Avoid pointer signedness problem.
7545 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7547 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7548 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7550 * xfns.c (Fx_window_property): Simplify a bit,
7551 to make a bit faster and to avoid GCC 4.6.0 warning.
7552 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7554 * fns.c (internal_equal): Don't assume size_t fits in int.
7556 * alloc.c (compact_small_strings): Tighten assertion a little.
7558 Replace pEd with more-general pI, and fix some printf arg casts.
7559 * lisp.h (pI): New macro, generalizing old pEd macro to other
7560 conversion specifiers. For example, use "...%"pI"d..." rather
7561 than "...%"pEd"...".
7562 (pEd): Remove. All uses replaced with similar uses of pI.
7563 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7564 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7565 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7566 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7567 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7568 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7569 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7571 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7572 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7573 * print.c (safe_debug_print, print_object): Likewise.
7574 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7576 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7577 avoiding the 0 flag, which is not portable.
7578 * process.c (Fmake_network_process): Use pI to avoid cast.
7579 * region-cache.c (pp_cache): Likewise.
7580 * xdisp.c (decode_mode_spec): Likewise.
7581 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7582 behavior on 64-bit hosts with printf arg.
7583 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7584 (x_stop_queuing_selection_requests): Likewise.
7585 (x_get_window_property): Don't truncate byte count to an 'int'
7588 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7589 here, since it parses constructs like leading '-' and spaces,
7590 which are not wanted; and it overflows with large numbers.
7591 Instead, simply match F[0-9]+, which is what is wanted anyway.
7593 * alloc.c: Remove unportable assumptions about struct layout.
7594 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7595 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7596 (allocate_vectorlike, make_pure_vector): Use the new macros,
7597 plus offsetof, to remove unportable assumptions about struct layout.
7598 These assumptions hold on all porting targets that I know of, but
7599 they are not guaranteed, they're easy to remove, and removing them
7600 makes further changes easier.
7602 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7603 This doesn't fix a bug but makes the code clearer.
7604 (string_overrun_cookie): Now const. Use initializers that
7605 don't formally overflow signed char, to avoid warnings.
7606 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7607 can cause Emacs to crash when string overrun checking is enabled.
7608 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7609 multiple of sizeof (EMACS_INT); it need not be, if
7610 alignof(EMACS_INT) < sizeof (EMACS_INT).
7611 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7613 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7615 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7617 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7619 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7620 supposed to be handshaking. (Bug#8556)
7621 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7623 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7625 * lisp.h (Qdebug): List symbol.
7626 * eval.c (Qdebug): Restore global linkage.
7627 * keyboard.c (debug-on-event): New variable.
7628 (handle_user_signal): Break into debugger when debug-on-event
7629 matches the current signal symbol.
7631 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7633 * alloc.c (check_sblock, check_string_bytes)
7634 (check_string_free_list): Convert to standard C.
7636 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7638 * w32.c (emacs_gnutls_push): Fix typo.
7640 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7642 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7643 "cast to pointer from integer of different size".
7645 Improve doprnt and its use in verror. (Bug#8545)
7646 * doprnt.c (doprnt): Document the set of format control sequences
7647 supported by the function. Use SAFE_ALLOCA instead of always
7650 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7651 is one byte too soon. Don't use xrealloc; instead xfree and
7654 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7656 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7659 * gnutls.c: Renamed global_initialized to
7660 gnutls_global_initialized. Added internals for the
7661 :verify-hostname-error, :verify-error, and :verify-flags
7662 parameters of `gnutls-boot' and documented those parameters in the
7663 docstring. Start callback support.
7664 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7665 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7666 on error. Return error code.
7667 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7668 (emacs_gnutls_read): Likewise.
7669 (Fgnutls_boot): Return handshake error code.
7670 (emacs_gnutls_handle_error): New function.
7671 (wsaerror_to_errno): Likewise.
7673 * w32.h (emacs_gnutls_pull): Add prototype.
7674 (emacs_gnutls_push): Likewise.
7676 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7677 (emacs_gnutls_push): Likewise.
7679 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7681 * process.c (wait_reading_process_output): Check if GnuTLS
7682 buffered some data internally if no FDs are set for TLS
7685 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7686 (LIBS): Link to USER_LIBS.
7687 ($(BLD)/gnutls.$(0)): New target.
7689 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7691 * xdisp.c (handle_single_display_spec): Rename the
7692 display_replaced_before_p argument into display_replaced_p, to
7693 make it consistent with the commentary. Fix typos in the
7696 * textprop.c (syms_of_textprop): Remove dead code.
7697 (copy_text_properties): Delete obsolete commentary about an
7698 interface that was deleted long ago. Fix typos in the description
7701 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7702 to changes in oldXMenu/XMenu.h from 2011-04-16.
7703 <menu_help_message, prev_menu_help_message>: Constify.
7704 (IT_menu_make_room): menu->help_text is now `const char **';
7707 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7708 to changes in oldXMenu/XMenu.h from 2011-04-16.
7709 (struct XMenu): Declare `help_text' `const char **'.
7711 * xfaces.c <Qunspecified>: Make extern again.
7713 * syntax.c: Include sys/types.h before including regex.h, as
7716 * doc.c (get_doc_string): Improve the format passed to `error'.
7718 * doprnt.c (doprnt): Improve commentary.
7720 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7722 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7725 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7726 changes in globals.h immediately force recompilation.
7727 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7728 $(CURDIR)/s/ms-w32.h.
7729 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7731 * character.c (Fchar_direction): Function deleted.
7732 (syms_of_character): Don't defsubr it.
7733 <char-direction-table>: Deleted.
7735 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7737 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7738 * doprnt.c: Include limits.h.
7739 (SIZE_MAX): New macro.
7740 (doprnt): Return a size_t value. 2nd arg is now size_t.
7741 Many local variables are now size_t instead of int or unsigned.
7742 Improve overflow protection. Support `l' modifier for integer
7743 conversions. Support %l conversion. Don't assume an EMACS_INT
7744 argument for integer conversions and for %c.
7746 * lisp.h (doprnt): Restore prototype.
7748 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7751 * Makefile.in (base_obj): Add back doprnt.o.
7753 * deps.mk (doprnt.o): Add back prerequisites.
7754 (callint.o): Depend on character.h.
7756 * eval.c (internal_lisp_condition_case): Include the handler
7757 representation in the error message.
7758 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7759 when breaking from the loop.
7761 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7763 * callint.c (Fcall_interactively): When displaying error message
7764 about invalid control letter, pass the character's codepoint, not
7765 a pointer to its multibyte form. Improve display of the character
7766 in octal and display also its hex code.
7768 * character.c (char_string): Use %x to display the (unsigned)
7769 codepoint of an invalid character, to avoid displaying a bogus
7772 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7773 `error', not SYMBOL_NAME itself.
7775 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7776 character arguments to `error'.
7778 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7779 to `error' in error message about FINAL_CHAR argument. Make sure
7780 FINAL_CHAR is a character, and use %c when it is passed as
7781 argument to `error'.
7783 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7785 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7787 * w32.c: Include <time.h>.
7788 (sys_localtime): New function.
7790 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7792 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7794 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7796 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7798 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7801 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7803 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7804 gl_state.e_property when gl_state.object is Qt.
7806 * insdel.c (make_gap_larger): Remove limitation of buffer size
7809 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7811 * xdisp.c (lookup_glyphless_char_display)
7812 (produce_glyphless_glyph): Handle cons cell entry in
7813 glyphless-char-display.
7814 (Vglyphless_char_display): Document it.
7816 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7817 glyphless-char-display.
7819 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7821 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7823 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7825 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7826 definition for no-X builds.
7828 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7830 Static checks with GCC 4.6.0 and non-default toolkits.
7832 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7834 * process.c (keyboard_bit_set): Define only if SIGIO.
7835 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7836 (send_process): Repair possible setjmp clobbering.
7838 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7840 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7842 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7844 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7845 Define only if needed.
7847 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7848 by pacifying GCC about it. Maybe it's time to retire it?
7849 * xfaces.c (USG, __TIMEVAL__): Likewise.
7851 * dispextern.h (struct redisplay_interface): Rename param
7853 * termhooks.h (struct terminal): Likewise.
7854 * xterm.c (xembed_send_message): Likewise.
7856 * insdel.c (make_gap_smaller): Define only if
7857 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7859 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7862 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7863 so that we aren't warned about unused symbols.
7865 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7867 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7869 * xfns.c (x_real_positions): Mark locals as initialized.
7871 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7873 * xterm.c: Fix problems found by static analysis with other toolkits.
7874 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7875 (x_dispatch_event): Declare static if USE_GTK, and
7876 define if USE_GTK || USE_X_TOOLKIT.
7877 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7878 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7879 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7880 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7882 * xmenu.c (menu_help_callback): Pointer type fixes.
7883 Use const pointers when pointing at readonly data. Avoid pointer
7885 (FALSE): Remove unused macro.
7886 (update_frame_menubar): Remove unused decl.
7888 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7890 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7891 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7892 (single_menu_item): Rename local to avoid shadowing.
7894 * keyboard.c (make_lispy_event): Remove unused local var.
7896 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7897 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7899 * bitmaps: Change bitmaps from unsigned char back to the X11
7900 compatible char. Avoid the old compiler warnings about
7901 out-of-range initializers by using, for example, '\xab' rather
7904 * xgselect.c (xgselect_initialize): Check vs interface
7905 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7907 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7909 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7910 to read-only memory.
7912 * fns.c (vector): Remove; this old hack is no longer needed.
7914 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7916 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7918 * xrdb.c (x_load_resources): Omit unused local.
7920 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7921 (x_window): Rename locals to avoid shadowing.
7922 (USG): Use the kludged USG macro, to pacify gcc.
7924 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7925 (x_term_init): Remove local to avoid shadowing.
7927 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7929 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7930 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7932 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7934 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7936 Fix regex.c, syntax.c and friends for buffers > 2GB.
7937 * syntax.h (struct gl_state_s): Declare character position members
7940 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7942 * textprop.c (verify_interval_modification, interval_of):
7943 Declare arguments EMACS_INT.
7945 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7948 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7950 * indent.c (Fvertical_motion): Local variable it_start is now
7953 * regex.c (re_match, re_match_2, re_match_2_internal)
7954 (bcmp_translate, regcomp, regexec, print_double_string)
7955 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7956 (re_compile_pattern, re_exec): Declare arguments and local
7957 variables `size_t' and `ssize_t' and return values `regoff_t', as
7959 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7960 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7961 <compile_stack_type>: `size' and `avail' are now `size_t'.
7963 * regex.h <regoff_t>: Use ssize_t, not int.
7964 (re_search, re_search_2, re_match, re_match_2): Arguments that
7965 specify buffer/string position and length are now ssize_t and
7966 size_t. Return type is regoff_t.
7968 2011-04-16 Ben Key <bkey76@gmail.com>
7970 * nsfont.m: Fixed bugs in ns_get_family and
7971 ns_descriptor_to_entity that were caused by using free to
7972 deallocate memory blocks that were allocated by xmalloc (via
7973 xstrdup). This caused Emacs to crash when compiled with
7974 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7975 --enable-checking=xmallocoverrun). xfree is now used to
7976 deallocate these memory blocks.
7978 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7980 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7982 emacs_write: Accept and return EMACS_INT for sizes.
7983 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7985 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7986 Accept and return EMACS_INT.
7987 (emacs_gnutls_write): Return the number of bytes written on
7989 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7990 (emacs_read, emacs_write): Remove check for negative size, as the
7991 Emacs source code has been audited now.
7992 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7993 (emacs_read, emacs_write): Use it.
7994 * process.c (send_process): Adjust to the new signatures of
7995 emacs_write and emacs_gnutls_write. Do not attempt to store
7996 a byte offset into an 'int'; it might overflow.
7997 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7999 * sound.c: Don't assume sizes fit in 'int'.
8000 (struct sound_device.period_size, alsa_period_size):
8001 Return EMACS_INT, not int.
8002 (struct sound_device.write, vox_write, alsa_write):
8003 Accept EMACS_INT, not int.
8004 (wav_play, au_play): Use EMACS_INT to store sizes and to
8005 record read return values.
8007 2011-04-15 Ben Key <bkey76@gmail.com>
8009 * keyboard.c (Qundefined): Don't declare static since it is used
8011 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8012 static since they are used in nsfont.m.
8014 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8016 * process.c (Qprocessp): Don't declare static.
8017 * lisp.h (Qprocessp): Declare again.
8019 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8021 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8023 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8025 Improve C-level modularity by making more things 'static'.
8027 Don't publish debugger-only interfaces to other modules.
8028 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8029 (verify_bytepos, count_markers): Move decls to the only modules
8031 * region-cache.h (pp_cache): Likewise.
8032 * window.h (check_all_windows): Likewise.
8033 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8035 * sysdep.c (croak): Now static, if
8036 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8037 * syssignal.h (croak): Declare only if not static.
8039 * alloc.c (refill_memory_reserve): Now static if
8040 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8041 * lisp.h (refill_memory_reserve): Declare only if not static.
8043 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8044 Define only if USE_LUCID.
8046 * xrdb.c (x_customization_string, x_rm_string): Now static.
8048 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8049 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8051 * xdisp.c (draw_row_with_mouse_face): Now static.
8052 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8054 * window.h (check_all_windows): Mark externally visible.
8056 * window.c (window_deletion_count): Now static.
8058 * undo.c: Make symbols static if they're not exported.
8059 (last_undo_buffer, last_boundary_position, pending_boundary):
8062 * textprop.c (interval_insert_behind_hooks): Now static.
8063 (interval_insert_in_front_hooks): Likewise.
8065 * term.c: Make symbols static if they're not exported.
8066 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8067 (max_frame_lines, tty_set_terminal_modes):
8068 (tty_reset_terminal_modes, tty_turn_off_highlight):
8069 (get_tty_terminal): Now static.
8070 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8071 * termhooks.h (term_mouse_moveto): Do not declare if
8073 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8074 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8076 * sysdep.c: Make symbols static if they're not exported.
8077 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8079 (sigprocmask_set, full_mask): Remove; unused.
8080 (wait_debugging): Mark as visible.
8081 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8082 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8084 * syntax.c (syntax_temp): Define only if !__GNUC__.
8086 * sound.c (current_sound_device, current_sound): Now static.
8088 * search.c (searchbufs, searchbuf_head): Now static.
8090 * scroll.c (scroll_cost): Remove; unused.
8091 * dispextern.h (scroll_cost): Remove decl.
8093 * region-cache.h (pp_cache): Mark as externally visible.
8095 * process.c: Make symbols static if they're not exported.
8096 (process_tick, update_tick, create_process, chan_process):
8097 (Vprocess_alist, proc_buffered_char, datagram_access):
8098 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8099 (deactivate_process): Mark defn as static, as well as decl.
8100 * lisp.h (create_process): Remove decl.
8101 * process.h (chan_process, Vprocess_alist): Remove decls.
8103 * print.c: Make symbols static if they're not exported.
8104 (print_depth, new_backquote_output, being_printed, print_buffer):
8105 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8106 (print_interval, print_number_index, initial_stderr_stream):
8108 * lisp.h (Fprinc): Remove decl.
8109 (debug_output_compilation_hack): Mark as externally visible.
8111 * sysdep.c (croak): Move decl from here to syssignal.h.
8112 * syssignal.h (croak): Put it here, so the API can be checked when
8113 'croak' is called from dissociate_if_controlling_tty.
8115 * minibuf.c: Make symbols static if they're not exported.
8116 (minibuf_save_list, choose_minibuf_frame): Now static.
8117 * lisp.h (choose_minibuf_frame): Remove decl.
8119 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8121 * lread.c: Make symbols static if they're not exported.
8122 (read_objects, initial_obarray, oblookup_last_bucket_number):
8124 (make_symbol): Remove; unused.
8125 * lisp.h (initial_obarray, make_symbol): Remove decls.
8127 * keyboard.c: Make symbols static if they're not exported.
8128 (single_kboard, recent_keys_index, total_keys, recent_keys):
8129 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8130 (this_single_command_key_start, echoing, last_auto_save):
8131 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8132 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8133 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8134 (Vlispy_mouse_stem, double_click_count):
8136 (force_auto_save_soon): Define only if SIGDANGER.
8137 (ignore_mouse_drag_p): Now static if
8138 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8139 (print_help): Remove; unused.
8140 (stop_character, last_timer_event): Mark as externally visible.
8141 * keyboard.h (ignore_mouse_drag_p): Declare only if
8142 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8143 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8144 * lisp.h (echoing): Remove decl.
8145 (force_auto_save_soon): Declare only if SIGDANGER.
8146 * xdisp.c (redisplay_window): Simplify code, to make it more
8147 obvious that ignore_mouse_drag_p is not accessed if !defined
8148 USE_GTK && !defined HAVE_NS.
8150 * intervals.c: Make symbols static if they're not exported.
8151 (merge_properties_sticky, merge_interval_right, delete_interval):
8153 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8155 * insdel.c: Make symbols static if they're not exported.
8156 However, leave prepare_to_modify_buffer alone. It's never
8157 called from outside this function, but that appears to be a bug.
8158 (combine_after_change_list, combine_after_change_buffer):
8159 (adjust_after_replace, signal_before_change): Now static.
8160 (adjust_after_replace_noundo): Remove; unused.
8161 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8162 (signal_before_change): Remove decls.
8164 * indent.c (val_compute_motion, val_vmotion): Now static.
8166 * image.c: Make symbols static if they're not exported.
8167 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8169 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8170 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8172 * fringe.c (standard_bitmaps): Now static.
8173 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8175 * frame.c: Make symbols static if they're not exported.
8176 (x_report_frame_params, make_terminal_frame): Now static.
8177 (get_frame_param): Now static, unless HAVE_NS.
8178 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8179 (x_get_resource_string): Remove; not used.
8180 * frame.h (make_terminal_frame, x_report_frame_params):
8181 (x_get_resource_string); Remove decls.
8182 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8183 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8185 * font.c, fontset.c: Make symbols static if they're not exported.
8186 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8187 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8188 * font.c (font_close_object): Now static.
8189 * font.h (font_close_object): Remove.
8190 * fontset.c (FONTSET_OBJLIST): Remove.
8191 (free_realized_fontset) #if-0 the body, which does nothing.
8192 (face_suitable_for_char_p): #if-0, as it's never called.
8193 * fontset.h (face_suitable_for_char_p): Remove decl.
8194 * xfaces.c (face_at_string_position):
8195 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8196 since 0 is always ASCII.
8198 * fns.c (weak_hash_tables): Now static.
8200 * fileio.c: Make symbols static if they're not exported.
8201 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8202 (Vwrite_region_annotation_buffers): Now static.
8204 * eval.c: Make symbols static if they're not exported.
8205 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8206 * lisp.h (backtrace_list): Remove decl.
8208 * emacs.c: Make symbols static if they're not exported.
8209 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8210 (fatal_error_code, fatal_error_signal_hook, standard_args):
8212 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8213 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8214 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8215 * lisp.h (fatal_error_signal_hook): Remove decl.
8216 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8218 * editfns.c: Move a (normally-unused) function to its only use.
8219 * editfns.c, lisp.h (get_operating_system_release): Remove.
8220 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8221 worth the hassle of breaking this out.
8223 * xterm.c: Make symbols static if they're not exported.
8224 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8225 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8226 (x_destroy_window, x_delete_display):
8228 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8229 (x_mouse_leave): Remove; unused.
8230 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8231 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8232 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8234 (x_mouse_leave): Declare only if WINDOWSNT.
8235 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8236 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8239 * ftxfont.c: Make symbols static if they're not exported.
8240 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8242 * font.h (ftxfont_driver): Likewise.
8244 * xfns.c: Make symbols static if they're not exported.
8245 (x_last_font_name, x_display_info_for_name):
8246 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8247 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8248 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8249 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8250 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8251 (last_show_tip_args): Now static.
8252 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8253 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8254 (x_screen_planes): Remove; unused.
8255 * dispextern.h (x_screen_planes): Remove decl.
8257 * dispnew.c: Make symbols static if they're not exported.
8258 * dispextern.h (redraw_garbaged_frames, scrolling):
8259 (increment_row_positions): Remove.
8260 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8261 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8263 (redraw_garbaged_frames): Remove; unused.
8265 * xfaces.c: Make symbols static if they're not exported.
8266 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8268 * xterm.h (defined_color): Remove decls.
8269 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8270 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8271 (menu_face_changed_default, defined_color, free_realized_face):
8272 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8273 (ascii_face_of_lisp_face): Remove; unused.
8275 * xdisp.c: Make symbols static if they're not exported.
8276 * dispextern.h (scratch_glyph_row, window_box_edges):
8277 (glyph_to_pixel_coords, set_cursor_from_row):
8278 (get_next_display_element, set_iterator_to_next):
8279 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8280 (show_mouse_face): Remove decls
8281 * frame.h (message_buf_print): Likewise.
8282 * lisp.h (pop_message, set_message, check_point_in_composition):
8284 * xterm.h (set_vertical_scroll_bar): Likewise.
8285 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8286 (message_buf_print, scratch_glyph_row, displayed_buffer):
8287 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8288 (get_next_display_element, show_mouse_face, window_box_edges):
8289 (frame_to_window_pixel_xy, check_point_in_composition):
8290 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8291 (glyph_to_pixel_coords): Remove; unused.
8293 * dired.c (file_name_completion): Now static.
8295 * dbusbind.c (xd_in_read_queued_messages): Now static.
8297 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8298 * data.c (circular_list_error): Remove.
8300 * commands.h (last_point_position, last_point_position_buffer):
8301 (last_point_position_window): Remove decls.
8302 * keyboard.c: Make these variables static.
8304 * coding.h (coding, code_convert_region, encode_coding_gap):
8306 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8307 (iso_code_class, detect_coding, code_convert_region): Now static.
8308 (encode_coding_gap): Remove; unused.
8310 * chartab.c (chartab_chars, chartab_bits): Now static.
8312 * charset.h (charset_iso_8859_1): Remove decl.
8313 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8316 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8317 * ccl.c (Vccl_program_table): Now static.
8318 (check_ccl_update): Remove; unused.
8320 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8321 * category.h: ... from here.
8322 * category.c (check_category_table, set_category_set): Now static.
8324 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8325 * lisp.h: Remove these decls.
8327 * buffer.c (buffer_count): Remove unused var.
8329 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8330 so that it's not optimized away.
8331 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8332 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8333 exported only to the debugger.
8335 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8336 * atimer.h (run_all_atimers): Remove; not exported.
8338 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8339 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8340 was inaccessible from Lisp.
8341 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8342 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8344 alloc.c: Import and export fewer symbols, and remove unused items.
8345 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8347 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8348 it's not optimized away by whole-program optimization.
8349 (message_enable_multibyte, free_misc): Remove.
8350 (catchlist, handlerlist, mark_backtrace):
8351 Declare only if BYTE_MARK_STACK.
8352 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8353 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8354 (message_enable_multibyte): Remove decl.
8355 (free_misc, interval_free_list, float_block, float_block_index):
8356 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8357 (cons_free_list, last_marked_index):
8359 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8360 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8361 (mark_backtrace): Define only if BYTE_MARK_STACK.
8362 * xdisp.c (message_enable_multibyte): Now static.
8364 Declare Lisp_Object Q* variables to be 'static' if not exported.
8365 This makes it easier for human readers (and static analyzers)
8366 to see whether these variables are used from other modules.
8367 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8368 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8369 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8370 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8371 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8372 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8373 * xmenu.c, xselect.c:
8374 Declare Q* vars static if they are not used in other modules.
8375 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8376 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8377 Remove decls of unexported vars.
8378 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8380 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8382 Make Emacs functions such as Fatom 'static' by default.
8383 This makes it easier for human readers (and static analyzers)
8384 to see whether these functions can be called from other modules.
8385 DEFUN now defines a static function. To make the function external
8386 so that it can be used in other C modules, use the new macro DEFUE.
8387 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8388 (Finit_image_library):
8389 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8390 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8391 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8392 Remove decls, since these functions are now static.
8393 (Funintern, Fget_internal_run_time): New decls, since these functions
8394 were already external.
8396 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8397 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8398 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8399 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8400 * keyboard.c, keymap.c, lread.c:
8401 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8402 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8403 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8404 Mark functions with DEFUE instead of DEFUN,
8405 if they are used in other modules.
8406 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8407 decls for now-static functions.
8408 * buffer.h (Fdelete_overlay): Remove decl.
8409 * callproc.c (Fgetenv_internal): Mark as internal.
8410 * composite.c (Fremove_list_of_text_properties): Remove decl.
8411 (Fcomposition_get_gstring): New forward static decl.
8412 * composite.h (Fcomposite_get_gstring): Remove decl.
8413 * dired.c (Ffile_attributes): New forward static decl.
8414 * doc.c (Fdocumntation_property): New forward static decl.
8415 * eval.c (Ffetch_bytecode): New forward static decl.
8416 (Funintern): Remove extern decl; now in .h file where it belongs.
8417 * fileio.c (Fmake_symbolic_link): New forward static decl.
8418 * image.c (Finit_image_library): New forward static decl.
8419 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8420 * intervals.h (Fprevious_property_change):
8421 (Fremove_list_of_text_properties): Remove decls.
8422 * keyboard.c (Fthis_command_keys): Remove decl.
8423 (Fcommand_execute): New forward static decl.
8424 * keymap.c (Flookup_key): New forward static decl.
8425 (Fcopy_keymap): Now static.
8426 * keymap.h (Flookup_key): Remove decl.
8427 * process.c (Fget_process): New forward static decl.
8428 (Fprocess_datagram_address): Mark as internal.
8429 * syntax.c (Fsyntax_table_p): New forward static decl.
8430 (skip_chars): Remove duplicate decl.
8431 * textprop.c (Fprevious_property_change): New forward static decl.
8432 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8434 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8435 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8437 * editfns.c (Fformat): Remove unreachable code.
8439 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8441 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8444 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8446 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8447 when at ZV. (Bug#8487)
8449 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8451 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8453 * keyboard.c (parse_tool_bar_item): Likewise.
8454 * sound.c (sound_cleanup, alsa_close): Likewise.
8455 * termcap.c (tgetent): Likewise.
8456 * xfns.c (x_default_font_parameter): Likewise.
8457 * xsettings.c (read_and_apply_settings): Likewise.
8459 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8460 (overrun_check_free): Protoize.
8462 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8464 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8465 since callers should never pass a negative size.
8466 Change the signature to match that of plain 'read' and 'write'; see
8467 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8468 * lisp.h: Update prototypes of emacs_write and emacs_read.
8470 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8472 * xdisp.c (redisplay_window): Don't try to determine the character
8473 position of the scroll margin if the window start point w->startp
8474 is outside the buffer's accessible region. (Bug#8468)
8476 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8478 Fix write-region and its subroutines for buffers > 2GB.
8479 * fileio.c (a_write, e_write): Modify declaration of arguments and
8480 local variables to support buffers larger than 2GB.
8481 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8483 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8484 argument, local variables, and return value.
8486 * lisp.h: Update prototypes of emacs_write and emacs_read.
8488 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8490 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8492 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8494 Fix more problems found by GCC 4.6.0's static checks.
8496 * xdisp.c (vmessage): Use a better test for character truncation.
8498 * charset.c (load_charset_map): <, not <=, for optimization,
8499 and to avoid potential problems with integer overflow.
8500 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8501 * casetab.c (set_identity, shuffle): Likewise.
8502 * editfns.c (Fformat): Likewise.
8503 * syntax.c (skip_chars): Likewise.
8505 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8506 This also lets GCC 4.6.0 generate slightly better loop code.
8508 * callint.c (Fcall_interactively): <, not <=, for optimization.
8509 (Fcall_interactively): Count the number of arguments produced,
8510 not the number of arguments given. This is simpler and lets GCC
8511 4.6.0 generate slightly better code.
8513 * ftfont.c: Distingish more carefully between FcChar8 and char.
8514 The previous code passed unsigned char * to a functions like
8515 strlen and xstrcasecmp that expect char *, which does not
8516 conform to the C standard.
8517 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8518 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8519 char * when the C standard requires it.
8521 * keyboard.c (read_char): Remove unused var.
8523 * eval.c: Port to Windows vsnprintf (Bug#8435).
8525 (SIZE_MAX): Define if the headers do not.
8526 (verror): Do not give up if vsnprintf returns a negative count.
8527 Instead, grow the buffer. This ports to Windows vsnprintf, which
8528 does not conform to C99. Problem reported by Eli Zaretskii.
8529 Also, simplify the allocation scheme, by avoiding the need for
8530 calling realloc, and removing the ALLOCATED variable.
8532 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8534 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8535 But keep the doprint source code for now, as we might revamp it
8536 and use it again (Bug#8435).
8537 * lisp.h (doprnt): Remove.
8538 * Makefile.in (base_obj): Remove doprnt.o.
8539 * deps.mk (doprnt.o): Remove.
8541 error: Print 32- and 64-bit integers portably (Bug#8435).
8542 Without this change, on typical 64-bit hosts error ("...%d...", N)
8543 was used to print both 32- and 64-bit integers N, which relied on
8545 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8546 * lisp.h (error, verror): Mark as printf-like functions.
8547 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8548 Report overflow in size calculations when allocating printf buffer.
8549 Do not truncate output string at its first null byte.
8550 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8551 Truncate the output at a character boundary, since vsnprintf does not
8553 * charset.c (check_iso_charset_parameter): Convert internal
8554 character to string before calling 'error', since %c now has the
8556 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8557 overflow when computing char to be passed to 'error'. Do not
8558 pass Lisp_Object to 'error'; pass the integer instead.
8559 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8560 formatted with plain %d.
8562 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8564 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8566 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8568 * xterm.c (x_catch_errors): Remove duplicate declaration.
8570 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8572 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8574 2011-04-10 Jim Meyering <meyering@redhat.com>
8576 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8577 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8578 return ssize_t not "int", and use size_t as the buffer length.
8579 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8580 * gnutls.h: Update declarations.
8581 * process.c (read_process_output): Use ssize_t, to match.
8582 (send_process): Likewise.
8584 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8586 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8588 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8590 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8591 Use unsigned char, to match FcChar8 type definition.
8593 * xterm.c (handle_one_xevent):
8594 * xmenu.c (create_and_show_popup_menu):
8595 * xselect.c (x_decline_selection_request)
8596 (x_reply_selection_request): Avoid type-punned deref of X events.
8598 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8600 Fix some uses of `int' instead of EMACS_INT.
8601 * search.c (string_match_1, fast_string_match)
8602 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8603 (scan_buffer, find_next_newline_no_quit)
8604 (find_before_next_newline, search_command, Freplace_match)
8605 (Fmatch_data): Make some `int' variables be EMACS_INT.
8607 * xdisp.c (display_count_lines): 3rd argument and return value now
8608 EMACS_INT. All callers changed.
8609 (pint2hrstr): Last argument is now EMACS_INT.
8611 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8612 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8613 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8614 (decode_coding_utf_16, decode_coding_emacs_mule)
8615 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8616 (decode_coding_ccl, decode_coding_charset)
8617 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8618 (decode_coding_iso_2022, decode_coding_emacs_mule)
8619 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8620 <char_offset, last_offset>: Declare EMACS_INT.
8621 (encode_coding_utf_8, encode_coding_utf_16)
8622 (encode_coding_emacs_mule, encode_invocation_designation)
8623 (encode_designation_at_bol, encode_coding_iso_2022)
8624 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8625 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8627 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8628 (encode_invocation_designation): Last argument P_NCHARS is now
8630 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8631 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8633 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8636 * ccl.c (Fccl_execute_on_string): Declare some variables
8639 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8641 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8643 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8645 * process.c (Fformat_network_address): Doc fix.
8647 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8649 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8651 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8653 * keyboard.c (read_char): Call Lisp function help-form-show,
8654 instead of using internal_with_output_to_temp_buffer.
8655 (Qhelp_form_show): New var.
8656 (syms_of_keyboard): Use DEFSYM macro.
8658 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8660 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8662 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8664 * process.c (Flist_processes): Remove to Lisp.
8665 (list_processes_1): Delete.
8667 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8669 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8671 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8673 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8675 Fix more problems found by GCC 4.6.0's static checks.
8677 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8679 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8681 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8683 * xdisp.c (vmessage): Mark as a printf-like function.
8685 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8687 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8689 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8690 printf-like functions.
8691 (tiff_load): Add casts to remove these marks before passing them
8692 to system-supplied API.
8694 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8696 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8697 This avoids several warnings with gcc -Wstrict-overflow.
8698 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8699 directly, rather than having caller test rule sign. This avoids
8700 some unnecessary tests.
8701 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8702 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8703 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8705 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8706 (xfont_open): Avoid unnecessary tests.
8708 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8710 * composite.h, composite.c (composition_gstring_put_cache):
8711 Use EMACS_INT, not int, for length.
8713 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8714 breaking out part of COMPOSITION_DECODE_RULE.
8715 (COMPOSITION_DECODE_RULE): Use it.
8716 * composite.c (get_composition_id): Remove unused local vars,
8717 by using the new macro.
8719 * textprop.c (set_text_properties_1): Change while to do-while,
8720 since the condition is always true at first.
8722 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8723 (interval_deletion_adjustment): Return unsigned value.
8726 * process.c (list_processes_1, create_pty, read_process_output):
8727 (exec_sentinel): Remove vars that were set but not used.
8728 (create_pty): Remove unnecessary "volatile"s.
8729 (Fnetwork_interface_info): Avoid possibility of int overflow.
8730 (read_process_output): Do adaptive read buffering even if carryover.
8731 (read_process_output): Simplify nbytes computation if buffered.
8733 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8735 * syntax.c (scan_words): Remove var that was set but not used.
8736 (update_syntax_table): Use unsigned instead of int.
8738 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8739 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8740 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8742 * print.c (print_error_message): Avoid int overflow.
8744 * font.c (font_list_entities): Redo for clarity,
8745 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8747 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8748 (font_score): Avoid potential overflow in diff calculation.
8750 * fns.c (substring_both): Remove var that is set but not used.
8751 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8753 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8755 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8756 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8757 can always succeed if overflow has undefined behavior.
8759 * search.c (boyer_moore, wordify): Remove vars set but not used.
8760 (wordify): Omit three unnecessary tests.
8762 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8763 All callers changed. This avoids the need for an unused var.
8765 * casefiddle.c (casify_region): Remove var that is set but not used.
8767 * dired.c (file_name_completion): Remove var that is set but not used.
8769 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8771 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8772 (Finsert_file_contents): Remove unnecessary code checking fd.
8774 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8775 Check for integer overflow on size calculations.
8777 * buffer.c (Fprevious_overlay_change): Remove var that is set
8780 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8781 Remove vars that are set but not used.
8782 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8783 (timer_check_2): Mark vars as initialized.
8785 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8787 * image.c (lookup_image): Remove var that is set but not used.
8788 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8790 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8791 that are set but not used.
8793 * xfns.c (make_invisible_cursor): Don't return garbage
8794 if XCreateBitmapFromData fails (Bug#8410).
8796 * xselect.c (x_get_local_selection, x_handle_property_notify):
8797 Remove vars that are set but not used.
8799 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8800 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8802 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8803 Remove var that is set but not used.
8804 (scroll_bar_windows_size): Now size_t, not int.
8805 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8808 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8809 (map_tty_color) [!defined MSDOS]: Likewise.
8811 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8813 * coding.c: Remove vars that are set but not used.
8814 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8815 All callers changed.
8816 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8817 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8818 (decode_coding_charset): Remove vars that are set but not used.
8820 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8821 that is set but not used.
8823 * print.c (print_object): Remove var that is set but not used.
8825 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8826 The gnulib version avoids calling malloc in the usual case,
8827 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8828 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8829 * filelock.c (current_lock_owner): Likewise.
8830 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8831 * sysdep.c: Include allocator.h, careadlinkat.h.
8832 (emacs_no_realloc_allocator): New static constant.
8833 (emacs_readlink): New function.
8834 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8835 ../lib/careadlinkat.h.
8837 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8839 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8840 first non-nil return value).
8842 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8844 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8845 if not defined (Bug#8403).
8847 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8849 * xdisp.c (display_count_lines): Remove parameter `start',
8850 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8851 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8852 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8853 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8854 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8855 and thereabouts. All callers changed.
8856 (get_per_char_metric): Remove parameter `f', unused since
8857 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8859 2011-04-02 Jim Meyering <meyering@redhat.com>
8861 do not dereference NULL upon failed strdup
8862 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8863 (ns_get_family): Likewise.
8865 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8867 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8869 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8871 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8874 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8876 Add lexical binding.
8878 * window.c (Ftemp_output_buffer_show): New fun.
8879 (Fsave_window_excursion):
8880 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8882 * lread.c (lisp_file_lexically_bound_p): New function.
8883 (Fload): Bind Qlexical_binding.
8884 (readevalloop): Remove `evalfun' arg.
8885 Bind Qinternal_interpreter_environment.
8886 (Feval_buffer): Bind Qlexical_binding.
8887 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8889 (syms_of_lread): Declare `lexical-binding'.
8891 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8893 * keyboard.c (eval_dyn): New fun.
8894 (menu_item_eval_property): Use it.
8896 * image.c (parse_image_spec): Use Ffunctionp.
8898 * fns.c (concat, mapcar1): Accept byte-code-functions.
8900 * eval.c (Fsetq): Handle lexical vars.
8901 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8902 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8903 (FletX, Flet): Obey lexical binding.
8904 (Fcommandp): Handle closures.
8905 (Feval): New `lexical' arg.
8906 (eval_sub): New function extracted from Feval. Use it almost
8907 everywhere where Feval was used. Look up vars in lexical env.
8909 (Ffunctionp): Move from subr.el.
8910 (Ffuncall): Handle closures.
8911 (apply_lambda): Remove `eval_flags'.
8912 (funcall_lambda): Handle closures and new byte-code-functions.
8913 (Fspecial_variable_p): New function.
8914 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8915 but without exporting it to Lisp.
8917 * doc.c (Fdocumentation, store_function_docstring):
8918 * data.c (Finteractive_form): Handle closures.
8920 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8923 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8925 (exec_byte_code): New function extracted from Fbyte_code to handle new
8926 calling convention for byte-code-functions. Add new byte-codes.
8928 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8930 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8932 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8934 * xdisp.c (redisplay_internal): Fix prototype.
8936 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8938 * xdisp.c (SCROLL_LIMIT): New macro.
8939 (try_scrolling): Use it when setting scroll_limit.
8940 Limit scrolling to 100 screen lines.
8941 (redisplay_window): Even when falling back on "recentering",
8942 position point in the window according to scroll-conservatively,
8943 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8945 (try_scrolling): When point is above the window, allow searching
8946 as far as scroll_max, or one screenful, to compute vertical
8947 distance from PT to the scroll margin position. This prevents
8948 try_scrolling from unnecessarily failing when
8949 scroll-conservatively is set to a value slightly larger than the
8950 window height. Clean up the case of PT below the margin at bottom
8951 of window: scroll_max can no longer be INT_MAX. When aggressive
8952 scrolling is in use, don't let point enter the opposite scroll
8953 margin as result of the scroll.
8954 (syms_of_xdisp) <scroll-conservatively>: Document the
8955 threshold of 100 lines for never-recentering scrolling.
8957 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8959 * dispextern.h (move_it_by_lines):
8960 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8961 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8962 (message_log_check_duplicate): Remove parameters `prev_bol' and
8963 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8964 (redisplay_internal): Remove parameter `preserve_echo_area',
8965 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8967 * indent.c (Fvertical_motion):
8968 * window.c (window_scroll_pixel_based, Frecenter):
8969 Don't pass `need_y_p' to `move_it_by_lines'.
8971 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8973 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8974 steal a few bits to be more compact.
8975 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8976 Remove unneeded casts.
8978 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8980 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8982 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8983 binding" message (bug#7967).
8985 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8987 Fix more problems found by GCC 4.6.0's static checks.
8989 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8990 Remove unused local var.
8992 * editfns.c (Fmessage_box): Remove unused local var.
8994 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8995 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8996 Omit unused local vars.
8997 * window.c (shrink_windows): Omit unused local var.
8998 * menu.c (digest_single_submenu): Omit unused local var.
8999 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9000 Omit unused local var.
9002 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9003 Don't assume string length fits in int.
9004 (keyremap_step, read_key_sequence): Use size_t for sizes.
9005 (read_key_sequence): Don't check last_real_key_start redundantly.
9007 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9008 instead of alloca (Bug#8344).
9010 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9011 (Fbacktrace_frame): Don't assume nframes fits in int.
9013 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9015 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9018 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9020 * cm.c (calccost): Turn while-do into do-while, for clarity.
9022 * keyboard.c (syms_of_keyboard): Use the same style as later
9023 in this function when indexing through an array. This also
9024 works around GCC bug 48267.
9026 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9028 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9030 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9031 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9033 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9034 This avoids undefined behavior on integer overflow, and is a bit
9035 more convenient anyway since it is compared to a size_t variable.
9037 Variadic C functions now count arguments with size_t, not int.
9038 This avoids an unnecessary limitation on 64-bit machines, which
9039 caused (substring ...) to crash on large vectors (Bug#8344).
9040 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9041 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9042 All variadic functions and their callers changed accordingly.
9043 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9044 * data.c (arith_driver, float_arith_driver): Likewise.
9045 * editfns.c (general_insert_function): Likewise.
9046 * eval.c (struct backtrace.nargs, interactive_p)
9047 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9048 (funcall_lambda, mark_backtrace): Likewise.
9049 * fns.c (concat): Likewise.
9050 * frame.c (x_set_frame_parameters): Likewise.
9051 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9052 0 if not found, not -1. All callers changed.
9054 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9055 (stack_copy_size): Now size_t, not int.
9056 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9058 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9060 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9061 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9062 All callers changed.
9064 * lisp.h (multibyte_char_to_unibyte):
9065 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9066 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9067 * character.h (CHAR_TO_BYTE8):
9068 * cmds.c (internal_self_insert):
9069 * editfns.c (general_insert_function):
9070 * keymap.c (push_key_description):
9071 * search.c (Freplace_match):
9072 * xdisp.c (message_dolog, set_message_1): All callers changed.
9074 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9076 * keyboard.c (safe_run_hook_funcall): New function.
9077 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9078 don't set the hook to nil, but remove the offending function instead.
9079 (Qcommand_hook_internal): Remove, unused.
9080 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9081 Vcommand_hook_internal.
9083 * eval.c (enum run_hooks_condition): Remove.
9084 (funcall_nil, funcall_not): New functions.
9085 (run_hook_with_args): Call each function through a `funcall' argument.
9086 Remove `cond' argument, now redundant.
9087 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9088 (Frun_hook_with_args_until_failure): Adjust accordingly.
9089 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9091 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9093 * dispextern.h (string_buffer_position): Remove declaration.
9095 * print.c (strout): Remove parameter `multibyte', unused since
9096 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9098 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9099 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9100 All callers changed.
9102 * w32.c (_wsa_errlist): Use braces for struct initializers.
9104 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9105 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9106 All callers changed.
9107 (string_buffer_position): Likewise. Also, make static (it's never
9108 used outside xdisp.c).
9109 (cursor_row_p): Remove parameter `w', unused since
9110 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9111 (decode_mode_spec): Remove parameter `precision', introduced during
9112 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9113 All callers changed.
9115 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9117 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9119 2011-03-27 Anders Lindgren <andlind@gmail.com>
9121 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9122 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9123 (ns_update_auto_hide_menu_bar): New functions.
9124 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9125 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9126 ns_constrain_all_frames.
9127 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9128 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9130 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9132 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9134 2011-03-27 Glenn Morris <rgm@gnu.org>
9136 * syssignal.h: Replace RETSIGTYPE with void.
9137 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9138 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9139 Replace SIGTYPE with void everywhere.
9140 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9141 * s/template.h (SIGTYPE): Remove commented out definition.
9143 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9145 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9146 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9148 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9150 * w32.c (read_unc_volume): Use parameter `henum', instead of
9151 global variable `wget_enum_handle'.
9153 * keymap.c (describe_vector): Remove parameters `indices' and
9154 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9155 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9157 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9159 * keyboard.c (timer_check): Remove parameter `do_it_now',
9160 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9161 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9162 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9164 * keyboard.c (read_char):
9165 * w32menu.c (w32_menu_display_help):
9166 * xmenu.c (show_help_event, menu_help_callback):
9167 Adjust calls to `show_help_echo'.
9169 * gtkutil.c (xg_maybe_add_timer):
9170 * keyboard.c (readable_events):
9171 * process.c (wait_reading_process_output):
9172 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9174 * insdel.c (adjust_markers_gap_motion):
9175 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9176 (gap_left, gap_right): Don't call it.
9178 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9180 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9181 incurred during fontification.
9183 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9185 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9186 (DEFVAR_PER_BUFFER): Don't pass it.
9188 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9189 (scrolling_window): Don't pass it.
9191 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9193 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9195 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9197 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9198 of variables specific to SELinux and computation of `encoded_absname'.
9200 * image.c (XPutPixel): Remove unused variable `height'.
9202 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9204 * unexw32.c (get_section_info): Remove unused variable `section'.
9206 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9207 (system_process_attributes): Remove unused variable `sess'.
9208 (sys_read): Remove unused variable `err'.
9210 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9211 (w32_wnd_proc): Remove unused variable `isdead'.
9212 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9213 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9214 (x_create_tip_frame): Remove unused variable `tem'.
9216 * w32inevt.c (w32_console_read_socket):
9217 Remove unused variable `no_events'.
9219 * w32term.c (x_draw_composite_glyph_string_foreground):
9220 Remove unused variable `width'.
9222 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9224 * w32term.c (x_set_glyph_string_clipping):
9225 Don't pass uninitialized region to CombineRgn.
9227 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9229 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9230 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9231 (Fx_close_connection): Remove unused variable `i'.
9233 * w32font.c (w32font_draw): Return number of glyphs.
9234 (w32font_open_internal): Remove unused variable `i'.
9235 (w32font_driver): Add missing initializer.
9237 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9238 (fill_in_menu): Remove unused variable `items_added'.
9240 * w32term.c (last_mouse_press_frame): Remove static global variable.
9241 (w32_clip_to_row): Remove unused variable `f'.
9242 (x_delete_terminal): Remove unused variable `i'.
9244 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9245 (NOTHING): Remove unused static global variable.
9246 (uniscribe_check_otf): Remove unused variable `table'.
9247 (uniscribe_font_driver): Add missing initializers.
9249 2011-03-23 Julien Danjou <julien@danjou.info>
9251 * term.c (Fsuspend_tty, Fresume_tty):
9252 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9253 * window.c (temp_output_buffer_show):
9254 * insdel.c (signal_before_change):
9255 * frame.c (Fhandle_switch_frame):
9256 * fileio.c (Fdo_auto_save):
9257 * emacs.c (Fkill_emacs):
9258 * editfns.c (save_excursion_restore):
9259 * cmds.c (internal_self_insert):
9260 * callint.c (Fcall_interactively):
9261 * buffer.c (Fkill_all_local_variables):
9262 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9264 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9265 unconditionally since it does the check itself.
9267 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9269 Fix more problems found by GCC 4.5.2's static checks.
9271 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9272 the first time through the loop, since we know p0 < p1 then.
9273 This also avoids a gcc -Wstrict-overflow warning.
9275 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9276 leading to a memory leak, possible in functions like
9277 load_charset_map_from_file that can allocate an unbounded number
9278 of objects (Bug#8318).
9280 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9281 that could (at least in theory) be that large.
9283 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9284 This is less likely to overflow, and avoids undefined behavior if
9285 overflow does occur. All callers changed. Use strtoul to scan
9286 for the unsigned long integer.
9287 (pint2hrstr): Simplify and tune code slightly.
9288 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9290 * scroll.c (do_scrolling): Work around GCC bug 48228.
9291 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9293 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9294 This also avoids a warning with gcc -Wstrict-overflow.
9295 (validate_x_resource_name): Simplify count usage.
9296 This also avoids a warning with gcc -Wstrict-overflow.
9298 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9301 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9303 * process.c (Fmake_network_process): Use socklen_t, not int,
9304 where POSIX says socklen_t is required in portable programs.
9305 This fixes a porting bug on hosts like 64-bit HP-UX, where
9306 socklen_t is wider than int (Bug#8277).
9307 (Fmake_network_process, server_accept_connection):
9308 (wait_reading_process_output, read_process_output):
9311 * process.c: Rename or move locals to avoid shadowing.
9312 (list_processes_1, Fmake_network_process):
9313 (read_process_output_error_handler, exec_sentinel_error_handler):
9314 Rename or move locals.
9315 (Fmake_network_process): Define label "retry_connect" only if needed.
9316 (Fnetwork_interface_info): Fix pointer signedness.
9317 (process_send_signal): Add cast to avoid pointer signedness problem.
9318 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9319 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9321 Make tparam.h and terminfo.c consistent.
9322 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9323 Include tparam.h instead, since it declares them.
9324 * cm.h (PC): Remove extern decl; tparam.h now does this.
9325 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9326 * terminfo.c: Include tparam.h, to check interfaces.
9327 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9328 (tparam): Adjust signature to match interface in tparam.h;
9329 this removes some undefined behavior. Check that outstring and len
9330 are zero, which they always are with Emacs.
9331 * tparam.h (PC, BC, UP): New extern decls.
9333 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9334 (xftfont_open): Rename locals to avoid shadowing.
9336 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9337 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9338 (OTF_TAG_SYM): Omit macro if not needed.
9339 (ftfont_list): Remove unused local.
9340 (get_adstyle_property, ftfont_pattern_entity):
9341 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9342 Rename locals to avoid shadowing.
9344 * xfont.c (xfont_list_family): Mark var as initialized.
9346 * xml.c (make_dom): Now static.
9348 * composite.c (composition_compute_stop_pos): Rename local to
9350 (composition_reseat_it): Remove unused locals.
9351 (find_automatic_composition, composition_adjust_point): Likewise.
9352 (composition_update_it): Mark var as initialized.
9353 (find_automatic_composition): Mark vars as initialized,
9354 with a FIXME (Bug#8290).
9356 character.h: Rename locals to avoid shadowing.
9357 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9358 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9359 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9360 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9363 * textprop.c (property_change_between_p): Remove; unused.
9365 * intervals.c (interval_start_pos): Now static.
9367 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9369 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9370 Rename locals to avoid shadowing.
9372 * sound.c (wav_play, au_play, Fplay_sound_internal):
9373 Fix pointer signedness.
9374 (alsa_choose_format): Remove unused local var.
9375 (wav_play): Initialize a variable to 0, to prevent undefined
9376 behavior (Bug#8278).
9378 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9380 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9382 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9383 clobbering (Bug#8298).
9384 * sysdep.c (sys_subshell): Likewise.
9385 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9387 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9388 This should get cleaned up, so that child_setup has the
9389 same signature on all platforms.
9391 * callproc.c (call_process_cleanup): Now static.
9392 (relocate_fd): Rename locals to avoid shadowing.
9394 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9396 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9397 not to be necessary, and produces flickering.
9399 2011-03-20 Glenn Morris <rgm@gnu.org>
9401 * config.in: Remove file.
9403 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9405 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9406 are now in src/globals.h.
9407 (syms_of_minibuf): Remove spurious & from previous change.
9409 2011-03-20 Leo Liu <sdl.web@gmail.com>
9411 * minibuf.c (completing-read-function): New variable.
9412 (completing-read-default): Rename from completing-read.
9413 (completing-read): Call completing-read-function.
9415 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9417 * xfaces.c (Fx_load_color_file):
9418 Read color file from absolute filename (bug#8250).
9420 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9422 * makefile.w32-in: Update dependencies.
9424 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9426 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9428 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9430 Fix more problems found by GCC 4.5.2's static checks.
9432 * process.c (make_serial_process_unwind, send_process_trap):
9433 (sigchld_handler): Now static.
9435 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9436 That way, the code declares only the vars that it needs.
9437 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9438 * s/cygwin.h (PTY_ITERATION): Likewise.
9439 * s/darwin.h (PTY_ITERATION): Likewise.
9440 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9442 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9443 * process.c (allocate_pty): Don't declare stb unless it's needed.
9445 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9446 (CONSTANTLIM): Remove; unused.
9447 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9448 Define only if needed.
9450 * unexelf.c (unexec): Name an expression,
9451 to avoid gcc -Wbad-function-cast warning.
9452 Use a different way to cause a compilation error if anyone uses
9453 n rather than nn, a way that does not involve shadowing.
9454 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9456 * deps.mk (unexalpha.o): Remove; unused.
9458 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9459 * unexec.h: New file.
9460 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9461 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9463 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9464 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9465 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9466 Change as necessary to match prototype in unexec.h.
9468 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9470 (back_comment, skip_chars): Mark vars as initialized.
9472 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9473 Rename locals to avoid shadowing.
9475 * lread.c (read1): Rewrite so as not to use empty "else".
9476 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9478 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9480 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9481 warning when compiling print.c.
9483 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9484 instead of using an uninitialized var.
9485 (font_sort_entities): Mark var as initialized.
9487 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9489 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9490 pointers to constants.
9491 (font_parse_fcname): Remove unused vars.
9492 (font_delete_unmatched): Now static.
9493 (font_get_spec): Remove; unused.
9494 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9495 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9496 Rename or move locals to avoid shadowing.
9498 * fns.c (require_nesting_list, require_unwind): Now static.
9499 (Ffillarray): Rename locals to avoid shadowing.
9501 * floatfns.c (domain_error2): Define only if needed.
9502 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9504 * alloc.c (mark_backtrace): Move decl from here ...
9505 * lisp.h: ... to here, so that it can be checked.
9507 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9508 (Fdefvar): Rewrite so as not to use empty "else".
9509 (lisp_indirect_variable): Name an expression,
9510 to avoid gcc -Wbad-function-cast warning.
9511 (Fdefvar): Rename locals to avoid shadowing.
9513 * callint.c (quotify_arg, quotify_args): Now static.
9514 (Fcall_interactively): Rename locals to avoid shadowing.
9515 Use const pointer when appropriate.
9517 * lisp.h (get_system_name, get_operating_system_release):
9518 Move decls here, to check interfaces.
9519 * process.c (get_operating_system_release): Move decl to lisp.h.
9520 * xrdb.c (get_system_name): Likewise.
9521 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9522 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9523 some of which prompt warnings from gcc -Wbad-function-cast.
9524 (Fformat_time_string, Fencode_time, Finsert_char):
9525 (Ftranslate_region_internal, Fformat):
9526 Rename or remove local vars to avoid shadowing.
9527 (Ftranslate_region_internal): Mark var as initialized.
9529 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9532 * lisp.h (eassert): Check that the argument compiles, even if
9533 ENABLE_CHECKING is not defined.
9535 * data.c (Findirect_variable): Name an expression, to avoid
9536 gcc -Wbad-function-cast warning.
9537 (default_value, arithcompare, arith_driver, arith_error): Now static.
9538 (store_symval_forwarding): Rename local to avoid shadowing.
9539 (Fmake_variable_buffer_local, Fmake_local_variable):
9540 Mark variables as initialized.
9541 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9543 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9544 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9545 Rename locals to avoid shadowing.
9546 (mark_stack): Move local variables into the #ifdef region where
9548 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9549 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9551 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9552 (GC_STRING_CHARS): Remove; not used.
9553 (Fmemory_limit): Cast sbrk's returned value to char *.
9555 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9556 avoids undefined behavior in theory.
9558 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9560 Use functions, not macros, for up- and down-casing (Bug#8254).
9561 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9562 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9563 to use the following functions instead of these macros.
9564 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9565 EMACS_INT, since callers assume the returned value fits in int.
9566 (upcase1): Likewise, for UPCASE_TABLE.
9567 (uppercasep, lowercasep, upcase): New static inline functions.
9568 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9569 the race-condition problem in the old DOWNCASE.
9571 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9572 Rename locals to avoid shadowing.
9573 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9574 (regex_compile, re_search_2, re_match_2_internal):
9575 Remove unused local vars.
9576 (FREE_VAR): Rewrite so as not to use empty "else",
9577 which gcc can warn about.
9578 (regex_compile, re_match_2_internal): Mark locals as initialized.
9579 (RETALLOC_IF): Define only if needed.
9580 (WORDCHAR_P): Likewise. This one is never needed, but is used
9581 only in a comment talking about a compiler bug, so put inside
9582 the #if 0 of that comment.
9583 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9584 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9587 * search.c (boyer_moore): Rename locals to avoid shadowing.
9588 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9589 (PREV_CHAR_BOUNDARY): Likewise.
9591 * search.c (simple_search): Remove unused var.
9593 * dired.c (compile_pattern): Move decl from here ...
9594 * lisp.h: ... to here, so that it can be checked.
9595 (struct re_registers): New forward decl.
9597 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9599 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9601 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9602 Rename locals to avoid shadowing.
9603 (Fvertical_motion): Mark locals as initialized.
9605 * casefiddle.c (casify_object, casify_region): Now static.
9606 (casify_region): Mark local as initialized.
9608 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9610 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9611 New macros, so that the caller can use some names other than
9612 gcpro1, gcpro2, etc.
9613 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9615 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9616 argument, for consistency with GCPRO2_VAR, etc: it is now the
9617 prefix of the variable, not the variable itself. All uses
9619 * dired.c (directory_files_internal, file_name_completion):
9620 Rename locals to avoid shadowing.
9622 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9623 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9624 dired.c's scmp function, had undefined behavior.
9625 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9626 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9627 * buffer.h: ... to here, because these macros use current_buffer,
9628 and the new implementation with inline functions needs to have
9629 current_buffer in scope now, rather than later when the macros
9631 (downcase, upcase1): New static inline functions.
9632 (DOWNCASE, UPCASE1): Reimplement using these functions.
9633 This avoids undefined behavior in expressions like
9634 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9635 from race conditions in accessing the global variables
9636 case_temp1 and case_temp2.
9637 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9638 * lisp.h (case_temp1, case_temp2): Remove their decls.
9639 * character.h (ASCII_CHAR_P): Move from here ...
9640 * lisp.h: ... to here, so that the inline functions mentioned
9643 * dired.c (directory_files_internal_unwind): Now static.
9645 * fileio.c (file_name_as_directory, directory_file_name):
9646 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9648 (file_name_as_directory): Use const pointers when appropriate.
9649 (Fexpand_file_name): Likewise. In particular, newdir might
9650 point at constant storage, so make it a const pointer.
9651 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9652 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9654 (Fset_file_times, Finsert_file_contents, auto_save_error):
9655 Rename locals to avoid shadowing.
9657 * minibuf.c (choose_minibuf_frame_1): Now static.
9658 (Ftry_completion, Fall_completions): Rename or remove locals
9661 * marker.c (bytepos_to_charpos): Remove; unused.
9663 * lisp.h (verify_bytepos, count_markers): New decls,
9664 so that gcc does not warn that these functions aren't declared.
9666 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9667 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9668 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9669 (copy_text): Remove unused local var.
9671 * filelock.c (within_one_second): Now static.
9672 (lock_file_1): Rename local to avoid shadowing.
9674 * buffer.c (fix_overlays_before): Mark locals as initialized.
9675 (fix_start_end_in_overlays): Likewise. This function should be
9676 simplified by using pointers-to-pointers, but that's a different
9678 (switch_to_buffer_1): Now static.
9679 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9680 (report_overlay_modification): Rename locals to avoid shadowing.
9682 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9683 Fix pointer signedness issue.
9684 (sys_subshell): Mark local as volatile if checking for lint,
9685 to suppress a gcc -Wclobbered warning that does not seem to be right.
9686 (MAXPATHLEN): Define only if needed.
9688 * process.c (serial_open, serial_configure): Move decls from here ...
9689 * systty.h: ... to here, so that they can be checked.
9691 * fns.c (get_random, seed_random): Move extern decls from here ...
9692 * lisp.h: ... to here, so that they can be checked.
9694 * sysdep.c (reset_io): Now static.
9695 (wait_for_termination_signal): Remove; unused.
9697 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9698 (copy_keymap_item, append_key, push_text_char_description):
9700 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9701 (DENSE_TABLE_SIZE): Remove; unused.
9702 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9703 (describe_map_tree):
9704 Rename locals to avoid shadowing.
9706 * keyboard.c: Declare functions static if they are not used elsewhere.
9707 (echo_char, echo_dash, cmd_error, top_level_2):
9708 (poll_for_input, handle_async_input): Now static.
9709 (read_char, kbd_buffer_get_event, make_lispy_position):
9710 (make_lispy_event, make_lispy_movement, apply_modifiers):
9711 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9712 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9713 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9714 (read_key_sequence, read_char): Mark locals as initialized.
9715 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9717 * keyboard.h (make_ctrl_char): New decl.
9718 (mark_kboards): Move decl here ...
9719 * alloc.c (mark_kboards): ... from here.
9721 * lisp.h (force_auto_save_soon): New decl.
9723 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9724 (DEFINE_DUMMY_FUNCTION): New macro.
9725 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9727 (main): Add casts to avoid warnings
9728 if GCC considers string literals to be constants.
9730 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9732 * dbusbind.c: Pointer signedness fixes.
9733 (xd_signature, xd_append_arg, xd_initialize):
9734 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9735 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9736 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9737 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9739 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9740 if GCC considers string literals to be constants.
9741 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9743 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9745 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9746 (print_preprocess, print_object): New macro to fix last change.
9748 * print.c (print_preprocess): Don't forget font objects.
9750 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9752 * emacs.c (USAGE3): Doc fixes.
9754 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9756 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9759 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9761 * lisp.h (VWindow_system, Qfile_name_history):
9762 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9763 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9764 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9766 * w32select.c: Don't #include "keyboard.h".
9767 (run_protected): Add extern declaration for waiting_for_input.
9769 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9770 * w32console.c (detect_input_pending, read_input_pending)
9771 (encode_terminal_code):
9772 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9773 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9774 (w32_system_caret_y, Qfile_name_history):
9775 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9776 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9777 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9778 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9779 * w32proc.c (Qlocal, report_file_error):
9780 * w32term.c (Vwindow_system, updating_frame):
9781 * w32uniscribe.c (initialized, uniscribe_font_driver):
9782 Remove unneeded extern declarations.
9784 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9786 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9788 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9790 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9791 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9792 These macros can no longer be used for assignment.
9794 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9795 Assign struct members directly, instead of using BUF_BEGV etc.
9796 (record_buffer_markers, fetch_buffer_markers): New functions for
9797 recording and fetching special buffer markers.
9798 (set_buffer_internal_1, set_buffer_temp): Use them.
9800 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9802 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9804 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9805 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9807 * xdisp.c (hscroll_window_tree):
9808 (reconsider_clip_changes): Use PT instead of BUF_PT.
9810 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9812 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9813 $(EMACS_ROOT)/lib/intprops.h.
9815 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9817 Fix more problems found by GCC 4.5.2's static checks.
9819 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9820 to unsigned char * to avoid compiler diagnostic.
9821 (xg_free_frame_widgets): Make it clear that a local variable is
9822 needed only if USE_GTK_TOOLTIP.
9823 (gdk_window_get_screen): Make it clear that this macro is needed
9824 only if USE_GTK_TOOLTIP.
9825 (int_gtk_range_get_value): New function, which avoids a diagnostic
9826 from gcc -Wbad-function-cast.
9827 (xg_set_toolkit_scroll_bar_thumb): Use it.
9828 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9829 diagnostic from gcc -Wbad-function-cast.
9830 (get_utf8_string, xg_get_file_with_chooser):
9831 Rename locals to avoid shadowing.
9832 (create_dialog): Move locals to avoid shadowing.
9834 * xgselect.c (xg_select): Remove unused var.
9836 * image.c (four_corners_best): Mark locals as initialized.
9837 (gif_load): Initialize transparent_p to zero (Bug#8238).
9838 Mark another local as initialized.
9839 (my_png_error, my_error_exit): Mark with NO_RETURN.
9841 * image.c (clear_image_cache): Now static.
9842 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9843 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9844 (x_edge_detection): Remove unnecessary cast that
9845 gcc -Wbad-function-cast diagnoses.
9846 (gif_load): Fix pointer signedness.
9847 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9848 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9850 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9852 Improve quality of tests for time stamp overflow.
9853 For example, without this patch (encode-time 0 0 0 1 1
9854 1152921504606846976) returns the obviously-bogus value (-948597
9855 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9856 reports time overflow. See
9857 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9858 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9859 * editfns.c: Include limits.h and intprops.h.
9860 (TIME_T_MIN, TIME_T_MAX): New macros.
9861 (time_overflow): Move earlier, to before first use.
9862 (hi_time, lo_time): New functions, for an accurate test for
9864 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9865 (Fget_internal_run_time): Don't assume time_t fits in int.
9866 (make_time): Use list2 instead of Fcons twice.
9867 (Fdecode_time): More accurate test for out-of-range times.
9868 (check_tm_member): New function.
9869 (Fencode_time): Use it, to test for out-of-range times.
9870 (lisp_time_argument): Don't rely on undefined left-shift and
9871 right-shift behavior when checking for time stamp overflow.
9873 * editfns.c (time_overflow): New function, refactoring common code.
9874 (Fformat_time_string, Fdecode_time, Fencode_time):
9875 (Fcurrent_time_string): Use it.
9877 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9878 * dired.c (make_time): Move to ...
9879 * editfns.c (make_time): ... here.
9880 * systime.h: Note the move.
9882 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9884 * fringe.c (update_window_fringes): Remove unused variables.
9886 * unexmacosx.c (copy_data_segment): Also copy __got section.
9889 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9891 * termcap.c [MSDOS]: Include "msdos.h".
9892 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9893 Constify `char *' arguments and their references according to
9894 prototypes in tparam.h.
9896 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9898 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9899 Adapt all references accordingly.
9901 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9903 2011-03-11 Tom Tromey <tromey@redhat.com>
9905 * buffer.c (syms_of_buffer): Remove obsolete comment.
9907 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9909 * termhooks.h (encode_terminal_code): Declare prototype.
9911 * msdos.c (encode_terminal_code): Don't declare prototype.
9913 * term.c (encode_terminal_code): Now external again, used by
9914 w32console.c and msdos.c.
9916 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9917 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9919 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9921 Fix some minor problems found by GCC 4.5.2's static checks.
9923 * fringe.c (update_window_fringes): Mark locals as initialized
9925 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9927 * alloc.c (mark_fringe_data): Move decl from here ...
9928 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9929 to check its interface.
9930 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9932 * fontset.c (free_realized_fontset): Now static.
9933 (Fset_fontset_font): Rename local to avoid shadowing.
9934 (fontset_font): Mark local as initialized.
9935 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9937 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9939 * xselect.c (x_disown_buffer_selections): Remove; not used.
9940 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9941 (x_own_selection, Fx_disown_selection_internal): Rename locals
9943 (x_handle_dnd_message): Remove local to avoid shadowing.
9945 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9946 so that the caller can use some name other than gcpro1.
9947 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9948 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9949 (Fx_backspace_delete_keys_p):
9950 Use them to avoid shadowing, and rename vars to avoid shadowing.
9951 (x_decode_color, x_set_name, x_window): Now static.
9952 (Fx_create_frame): Add braces to silence GCC warning.
9953 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9954 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9955 Remove unused locals.
9956 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9957 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9958 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9961 * xterm.h (x_mouse_leave): New decl.
9963 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9964 Remove unused functions.
9965 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9966 (x_calc_absolute_position): Now static.
9967 (XTread_socket): Don't define label "out" unless it's used.
9968 Don't declare local "event" unless it's used.
9969 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9970 unless they are used.
9971 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9972 (x_fatal_error_signal): Remove; not used.
9973 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9974 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9975 (x_error_catcher, x_connection_closed, x_error_handler):
9976 (x_error_quitter, xembed_send_message, x_iconify_frame):
9977 (my_log_handler): Rename locals to avoid shadowing.
9978 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9979 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9981 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9982 Rename or move locals to avoid shadowing.
9983 (tty_defined_color, merge_face_heights): Now static.
9984 (free_realized_faces_for_fontset): Remove; not used.
9985 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9986 does not deduce is never used uninitialized.
9987 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9988 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9990 * terminal.c (store_terminal_param): Now static.
9992 * xmenu.c (menu_highlight_callback): Now static.
9993 (set_frame_menubar): Remove unused local.
9994 (xmenu_show): Rename parameter to avoid shadowing.
9995 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9996 since they might point to immutable storage.
9997 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9998 since it's unused otherwise.
10000 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10001 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10002 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10003 avoids a gcc -Wuninitialized diagnostic.
10004 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10005 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10006 does not deduce are never used uninitialized.
10008 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10010 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10011 * window.c (window_loop, size_window):
10012 (run_window_configuration_change_hook, enlarge_window): Likewise.
10014 * window.c (display_buffer): Now static.
10015 (size_window): Mark variables that gcc -Wuninitialized
10016 does not deduce are never used uninitialized.
10017 * window.h (check_all_windows): New decl, to forestall
10018 gcc -Wmissing-prototypes diagnostic.
10019 * dispextern.h (bidi_dump_cached_states): Likewise.
10021 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10023 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10024 Include <limits.h>.
10025 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10026 and to avoid gcc -Wuninitialized warning.
10027 (load_charset_map): Mark variables that gcc -Wuninitialized
10028 does not deduce are never used uninitialized.
10029 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10031 * coding.c (coding_set_source, coding_set_destination):
10032 Use "else { /* comment */ }" rather than "else /* comment */;"
10033 for clarity, and to avoid gcc -Wempty-body warning.
10034 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10035 a block, when the outer 'i' will do.
10036 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10037 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10038 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10039 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10040 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10041 Rename locals to avoid shadowing.
10042 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10043 * coding.c (emacs_mule_char, encode_invocation_designation):
10044 Now static, since they're not used elsewhere.
10045 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10046 (decode_coding_object, encode_coding_object, detect_coding_system):
10047 (decode_coding_emacs_mule): Mark variables that gcc
10048 -Wuninitialized does not deduce are never used uninitialized.
10049 (detect_coding_iso_2022): Initialize a local variable that might
10050 be used uninitialized. Leave a FIXME because it's not clear that
10051 this initialization is needed. (Bug#8211)
10052 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10053 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10054 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10055 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10056 Remove unused macros.
10058 * category.c (hash_get_category_set): Remove unused local var.
10059 (copy_category_table): Now static, since it's not used elsewhere.
10060 * character.c (string_count_byte8): Likewise.
10062 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10063 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10065 * chartab.c (copy_sub_char_table): Now static, since it's not used
10067 (sub_char_table_ref_and_range, char_table_ref_and_range):
10068 Rename locals to avoid shadowing.
10069 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10071 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10072 (BIDI_BOB): Remove unused macro.
10074 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10075 deduce are never used uninitialized.
10076 * term.c (encode_terminal_code): Likewise.
10078 * term.c (encode_terminal_code): Now static. Remove unused local.
10080 * tparam.h: New file.
10081 * term.c, tparam.h: Include it.
10082 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10083 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10084 Move these decls to tparam.h, and make them agree with what
10085 is actually in tparam.c. The previous trick of using incompatible
10086 decls in different modules does not conform to the C standard.
10087 All callers of tparam changed to use tparam's actual API.
10088 * tparam.c (tparam1, tparam, tgoto):
10089 Use const pointers where appropriate.
10091 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10092 * cm.h (struct cm): Likewise.
10093 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10094 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10095 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10096 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10097 (turn_on_face, init_tty): Likewise.
10098 * termchar.h (struct tty_display_info): Likewise.
10100 * term.c (term_mouse_position): Rename local to avoid shadowing.
10102 * alloc.c (mark_ttys): Move decl from here ...
10103 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10105 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10107 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10109 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10111 * search.c (compile_pattern_1): Remove argument regp, unused since
10112 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10113 (compile_pattern): Don't pass it.
10115 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10117 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10118 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10120 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10122 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10124 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10125 gdk_window_get_screen, gdk_window_get_geometry,
10126 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10127 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10128 (xg_get_pixbuf_from_pixmap): New function.
10129 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10130 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10131 Call xg_get_pixbuf_from_pixmap instead of
10132 gdk_pixbuf_get_from_drawable.
10133 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10134 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10135 (xg_check_special_colors): Use GtkStyleContext and its functions
10137 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10138 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10139 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10140 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10141 Call gtk_widget_get_preferred_size.
10142 (xg_frame_resized): gdk_window_get_geometry only takes 5
10144 (xg_win_to_widget, xg_event_is_for_menubar):
10145 Call gdk_x11_window_lookup_for_display.
10146 (xg_set_widget_bg): New function.
10147 (delete_cb): New function.
10148 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10149 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10150 (xg_set_background_color): Call xg_set_widget_bg.
10151 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10152 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10153 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10154 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10156 (update_frame_tool_bar): Call gtk_widget_hide.
10157 (xg_initialize): Use GDK_KEY_g.
10159 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10161 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10163 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10164 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10165 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10167 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10169 * w32xfns.c (select_palette): Check success of RealizePalette against
10170 GDI_ERROR, not zero.
10172 See ChangeLog.11 for earlier changes.
10174 ;; Local Variables:
10178 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10180 This file is part of GNU Emacs.
10182 GNU Emacs is free software: you can redistribute it and/or modify
10183 it under the terms of the GNU General Public License as published by
10184 the Free Software Foundation, either version 3 of the License, or
10185 (at your option) any later version.
10187 GNU Emacs is distributed in the hope that it will be useful,
10188 but WITHOUT ANY WARRANTY; without even the implied warranty of
10189 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10190 GNU General Public License for more details.
10192 You should have received a copy of the GNU General Public License
10193 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.