* xsettings.c (apply_xft_settings): Fix potential buffer overrun.
[bpt/emacs.git] / src / ChangeLog
1 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4 This is unlikely, but can occur if DPI is outlandish.
5
6 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7
8 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9 * xrdb.c (magic_file_p, search_magic_path):
10 Omit last arg SUFFIX; it was always 0. All callers changed.
11 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
12
13 * xfont.c (xfont_match): Avoid need for strlen.
14
15 * xfns.c: Don't assume strlen fits in int.
16 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
17
18 * xdisp.c (message_log_check_duplicate): Return intmax_t,
19 not unsigned long, as we prefer signed integers. All callers changed.
20 Detect integer overflow in repeat count.
21 (message_dolog): Don't assume print length fits in 39 bytes.
22 (display_mode_element): Don't assume strlen fits in int.
23
24 * termcap.c: Don't assume sizes fit in int and never overflow.
25 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
26 (gobble_line): Check for size-calculation overflow.
27
28 * minibuf.c (Fread_buffer):
29 * lread.c (intern, intern_c_string):
30 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
31 Don't assume string length fits in int.
32
33 * keyboard.c (parse_tool_bar_item):
34 * gtkutil.c (style_changed_cb): Avoid need for strlen.
35
36 * font.c: Don't assume string length fits in int.
37 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
38 Use ptrdiff_t, not int.
39 (font_intern_prop): Don't assume string length fits in int.
40 Don't assume integer property fits in fixnum.
41 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
42
43 * filelock.c: Fix some buffer overrun and integer overflow issues.
44 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
45 Reformulate so as not to need the command string.
46 Invoke gzip -cd rather than gunzip, as it's more portable.
47 (lock_info_type, lock_file_1, lock_file):
48 Don't assume pid_t and time_t fit in unsigned long.
49 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
50 (current_lock_owner): Prefer signed type for sizes.
51 Use memcpy, not strncpy, where memcpy is what is really wanted.
52 Don't assume (via atoi) that time_t and pid_t fit in int.
53 Check for time_t and/or pid_t out of range, e.g., via a network share.
54 Don't alloca where an auto var works fine.
55
56 * fileio.c: Fix some integer overflow issues.
57 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
58 Don't assume string length fits in int.
59 (directory_file_name): Don't assume string length fits in long.
60 (make_temp_name): Don't assume pid fits in int, or that its print
61 length is less than 20.
62
63 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
64
65 * coding.c (make_subsidiaries): Don't assume string length fits in int.
66
67 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
68
69 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
70 We prefer signed integers, even for size calculations.
71
72 * emacs.c: Don't assume string length fits in 'int'.
73 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
74 (main): Don't invoke strlen when not needed.
75
76 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
77 (XD_DEBUG_MESSAGE): Don't waste a byte.
78
79 * callproc.c (getenv_internal_1, getenv_internal)
80 (Fgetenv_internal):
81 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
82
83 * lread.c (invalid_syntax): Omit length argument.
84 All uses changed. This doesn't fix a bug, but it simplifies the
85 code away from its former Hollerith-constant appearance, and it's
86 one less 'int' to worry about when looking at integer-overflow issues.
87 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
88
89 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
90 This didn't break anything, but it didn't help either.
91 It's confusing to put a bogus integer in a place where the actual
92 value does not matter.
93 (LIST_END_P): Remove unused macro and its bogus comment.
94 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
95
96 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
97 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
98 implementation.
99 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
100 We prefer signed types, and the value cannot exceed the EMACS_INT
101 range anyway (because otherwise the length would not be representable).
102 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
103 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
104 This avoids a GCC warning when WIDE_EMACS_INT.
105
106 * indent.c (sane_tab_width): New function.
107 (current_column, scan_for_column, Findent_to, position_indentation)
108 (compute_motion): Use it. This is just for clarity.
109 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
110
111 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
112
113 * lisp.h (lint_assume): New macro.
114 * composite.c (composition_gstring_put_cache):
115 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
116
117 * editfns.c, insdel.c:
118 Omit unnecessary forward decls, to simplify future changes.
119
120 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
121
122 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
123
124 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
125 Use much-faster test for byte-length change.
126 Don't assume string byte-length fits in 'int'.
127 Check that character arg fits in 'int'.
128 (mapcar1): Declare byte as byte, for clarity.
129
130 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
131
132 * fns.c (concat): Catch string overflow earlier.
133 Do not rely on integer wraparound.
134
135 * dispextern.h (struct it.overlay_strings_charpos)
136 (struct it.selective): Now EMACS_INT, not int.
137 * xdisp.c (forward_to_next_line_start)
138 (back_to_previous_visible_line_start)
139 (reseat_at_next_visible_line_start, next_element_from_buffer):
140 Don't arbitrarily truncate the value of 'selective' to int.
141
142 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
143
144 * composite.c: Don't truncate sizes to 'int'.
145 (composition_gstring_p, composition_reseat_it)
146 (composition_adjust_point): Use EMACS_INT, not int.
147 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
148 not EMACS_UINT, for indexes.
149
150 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
151
152 * buffer.c: Include <verify.h>.
153 (struct sortvec.priority, struct sortstr.priority):
154 Now EMACS_INT, not int.
155 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
156 (struct sortstr.size, record_overlay_string)
157 (struct sortstrlist.size, struct sortlist.used):
158 Don't truncate size to int.
159 (record_overlay_string): Check for size-calculation overflow.
160 (init_buffer_once): Check at compile-time, not run-time.
161
162 2011-06-20 Deniz Dogan <deniz@dogan.se>
163
164 * process.c (Fset_process_buffer): Clarify return value in
165 docstring.
166
167 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
168
169 * dispnew.c (add_window_display_history): Use BVAR.
170
171 * xdisp.c (debug_method_add): Use BVAR.
172 (check_window_end, dump_glyph_matrix, dump_glyph)
173 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
174
175 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
176 Likewise.
177
178 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
179 check till after the cache is created in init_frame_faces.
180
181 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
182
183 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
184
185 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
186
187 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
188 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
189 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
190
191 Improve buffer-overflow checking (Bug#8873).
192 * fileio.c (Finsert_file_contents):
193 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
194 Remove the old (too-loose) buffer overflow checks.
195 They weren't needed, since make_gap checks for buffer overflow.
196 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
197 The old code merely checked for Emacs fixnum overflow, and relied
198 on undefined (wraparound) behavior. The new code avoids undefined
199 behavior, and also checks for ptrdiff_t and/or size_t overflow.
200
201 * editfns.c (Finsert_char): Don't dump core with very negative counts.
202 Tune. Don't use wider integers than needed. Don't use alloca.
203 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
204
205 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
206
207 * insdel.c, lisp.h (buffer_overflow): New function.
208 (insert_from_buffer_1, replace_range, replace_range_2):
209 * insdel.c (make_gap_larger):
210 * editfns.c (Finsert_char):
211 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
212
213 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
214
215 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
216
217 Integer overflow and signedness fixes (Bug#8873).
218
219 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
220 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
221
222 * fileio.c: Don't assume EMACS_INT fits in off_t.
223 (emacs_lseek): New static function.
224 (Finsert_file_contents, Fwrite_region): Use it.
225 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
226
227 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
228
229 * fns.c: Don't overflow int when computing a list length.
230 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
231 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
232 truncation on 64-bit hosts. Check for QUIT every
233 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
234 faster and is responsive enough.
235 (Flength): Report an error instead of overflowing an integer.
236 (Fsafe_length): Return a float if the value is not representable
237 as a fixnum. This shouldn't happen except in contrived situations.
238 (Fnthcdr, Fsort): Don't assume list length fits in int.
239 (Fcopy_sequence): Don't assume vector length fits in int.
240
241 * alloc.c: Check that resized vectors' lengths fit in fixnums.
242 (header_size, word_size): New constants.
243 (allocate_vectorlike): Don't check size overflow here.
244 (allocate_vector): Check it here instead, since this is the only
245 caller of allocate_vectorlike that could cause overflow.
246 Check that the new vector's length is representable as a fixnum.
247
248 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
249 The previous code was bogus. For example, next_almost_prime (32)
250 returned 39, which is undesirable as it is a multiple of 3; and
251 next_almost_prime (24) returned 25, which is a multiple of 5 so
252 why was the code bothering to check for multiples of 7?
253
254 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
255
256 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
257
258 Variadic C functions now count arguments with ptrdiff_t.
259 This partly undoes my 2011-03-30 change, which replaced int with size_t.
260 Back then I didn't know that the Emacs coding style prefers signed int.
261 Also, in the meantime I found a few more instances where arguments
262 were being counted with int, which may truncate counts on 64-bit
263 machines, or EMACS_INT, which may be unnecessarily wide.
264 * lisp.h (struct Lisp_Subr.function.aMANY)
265 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
266 Arg counts are now ptrdiff_t, not size_t.
267 All variadic functions and their callers changed accordingly.
268 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
269 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
270 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
271 * callint.c (Fcall_interactively): Check arg count for overflow,
272 to avoid potential buffer overrun. Use signed char, not 'int',
273 for 'varies' array, so that we needn't bother to check its size
274 calculation for overflow.
275 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
276 * eval.c (apply_lambda):
277 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
278 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
279 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
280
281 * callint.c (Fcall_interactively): Don't use index var as event count.
282
283 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
284 * mem-limits.h (SIZE): Remove; no longer used.
285
286 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
287
288 Remove unnecessary casts.
289 * xterm.c (x_term_init):
290 * xfns.c (x_set_border_pixel):
291 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
292 These aren't needed now that we assume ANSI C.
293
294 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
295 It's more likely to cause problems (due to unsigned overflow)
296 than to cure them.
297
298 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
299
300 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
301
302 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
303
304 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
305
306 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
307
308 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
309
310 GLYPH_CODE_FACE returns EMACS_INT, not int.
311 * dispextern.h (merge_faces):
312 * xfaces.c (merge_faces):
313 * xdisp.c (get_next_display_element, next_element_from_display_vector):
314 Don't assume EMACS_INT fits in int.
315
316 * character.h (CHAR_VALID_P): Remove unused parameter.
317 * fontset.c, lisp.h, xdisp.c: All uses changed.
318
319 * editfns.c (Ftranslate_region_internal): Omit redundant test.
320
321 * fns.c (concat): Minor tuning based on overflow analysis.
322 This doesn't fix any bugs. Use int to hold character, instead
323 of constantly refetching from Emacs object. Use XFASTINT, not
324 XINT, for value known to be a character. Don't bother comparing
325 a single byte to 0400, as it's always less.
326
327 * floatfns.c (Fexpt):
328 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
329
330 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
331 for characters.
332
333 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
334
335 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
336 Without this fix, on a 64-bit host (aset S 0 4294967386) would
337 incorrectly succeed when S was a string, because 4294967386 was
338 truncated before it was used.
339
340 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
341 Otherwise, an out-of-range integer could cause undefined behavior
342 on a 64-bit host.
343
344 * composite.c: Use int, not EMACS_INT, for characters.
345 (fill_gstring_body, composition_compute_stop_pos): Use int, not
346 EMACS_INT, for values that are known to be in character range.
347 This doesn't fix any bugs but is the usual style inside Emacs and
348 may generate better code on 32-bit machines.
349
350 Make sure a 64-bit char is never passed to ENCODE_CHAR.
351 This is for reasons similar to the recent CHAR_STRING fix.
352 * charset.c (Fencode_char): Check that character arg is actually
353 a character. Pass an int to ENCODE_CHAR.
354 * charset.h (ENCODE_CHAR): Verify that the character argument is no
355 wider than 'int', as a compile-time check to prevent future regressions
356 in this area.
357
358 * character.c (char_string): Remove unnecessary casts.
359
360 Make sure a 64-bit char is never passed to CHAR_STRING.
361 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
362 by silently ignoring the top 32 bits, allowing some values
363 that were far too large to be valid characters.
364 * character.h: Include <verify.h>.
365 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
366 arguments are no wider than unsigned, as a compile-time check
367 to prevent future regressions in this area.
368 * data.c (Faset):
369 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
370 (Fsubst_char_in_region):
371 * fns.c (concat):
372 * xdisp.c (decode_mode_spec_coding):
373 Adjust to CHAR_STRING's new requirement.
374 * editfns.c (Finsert_char, Fsubst_char_in_region):
375 * fns.c (concat): Check that character args are actually
376 characters. Without this test, these functions did the wrong
377 thing with wildly out-of-range values on 64-bit hosts.
378
379 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
380 These casts should not be needed on 32-bit hosts, either.
381 * keyboard.c (read_char):
382 * lread.c (Fload): Remove casts to unsigned.
383
384 * lisp.h (UNSIGNED_CMP): New macro.
385 This fixes comparison bugs on 64-bit hosts.
386 (ASCII_CHAR_P): Use it.
387 * casefiddle.c (casify_object):
388 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
389 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
390 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
391 * dispextern.h (FACE_FROM_ID):
392 * keyboard.c (read_char): Use UNSIGNED_CMP.
393
394 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
395 not to EMACS_INT, to avoid GCC warning.
396
397 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
398
399 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
400 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
401 isn't needed on 32-bit machines.
402
403 * buffer.c (Fgenerate_new_buffer_name):
404 Use EMACS_INT for count, not int.
405 (advance_to_char_boundary): Return EMACS_INT, not int.
406
407 * data.c (Qcompiled_function): Now static.
408
409 * window.c (window_body_lines): Now static.
410
411 * image.c (gif_load): Rename local to avoid shadowing.
412
413 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
414 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
415 * alloc.c (make_save_value): Integer argument is now of type
416 ptrdiff_t, not int.
417 (mark_object): Use ptrdiff_t, not int.
418 * lisp.h (pD): New macro.
419 * print.c (print_object): Use it.
420
421 * alloc.c: Use EMACS_INT, not int, to count objects.
422 (total_conses, total_markers, total_symbols, total_vector_size)
423 (total_free_conses, total_free_markers, total_free_symbols)
424 (total_free_floats, total_floats, total_free_intervals)
425 (total_intervals, total_strings, total_free_strings):
426 Now EMACS_INT, not int. All uses changed.
427 (Fgarbage_collect): Compute overall total using a double, so that
428 integer overflow is less likely to be a problem. Check for overflow
429 when converting back to an integer.
430 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
431 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
432 These were 'int' variables that could overflow on 64-bit hosts;
433 they were never used, so remove them instead of repairing them.
434 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
435 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
436 Previously, this ceilinged at INT_MAX, but that doesn't work on
437 64-bit machines.
438 (allocate_pseudovector): Don't use EMACS_INT when int would do.
439
440 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
441 (allocate_vectorlike): Check for ptrdiff_t overflow.
442 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
443 when a (possibly-narrower) signed value would do just as well.
444 We prefer using signed arithmetic, to avoid comparison confusion.
445
446 * alloc.c: Catch some string size overflows that we were missing.
447 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
448 for convenience in STRING_BYTES_MAX.
449 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
450 The definition here is exact; the one in lisp.h was approximate.
451 (allocate_string_data): Check for string overflow. This catches
452 some instances we weren't catching before. Also, it catches
453 size_t overflow on (unusual) hosts where SIZE_MAX <= min
454 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
455 and ptrdiff_t and EMACS_INT are both 64 bits.
456
457 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
458 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
459 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
460
461 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
462
463 * alloc.c (Fmake_string): Check for out-of-range init.
464
465 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
466
467 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
468
469 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
470
471 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
472 xg_get_default_scrollbar_width.
473
474 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
475 (int_gtk_range_get_value): Move to the scroll bar part of the file.
476 (style_changed_cb): Call update_theme_scrollbar_width and call
477 x_set_scroll_bar_default_width and xg_frame_set_char_size for
478 all frames (Bug#8505).
479 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
480 Call gtk_window_set_resizable if HAVE_GTK3.
481 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
482 and height if HAVE_GTK3 (Bug#8505).
483 (scroll_bar_width_for_theme): New variable.
484 (update_theme_scrollbar_width): New function.
485 (xg_get_default_scrollbar_width): Move code to
486 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
487 (xg_initialize): Call update_theme_scrollbar_width.
488
489 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
490
491 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
492
493 2011-06-12 Martin Rudalics <rudalics@gmx.at>
494
495 * frame.c (make_frame): Call other_buffer_safely instead of
496 other_buffer.
497
498 * window.c (temp_output_buffer_show): Call display_buffer with
499 second argument Vtemp_buffer_show_specifiers and reset latter
500 immediately after the call.
501 (Vtemp_buffer_show_specifiers): New variable.
502 (auto_window_vscroll_p, next_screen_context_lines)
503 (Vscroll_preserve_screen_position): Remove leading asterisks from
504 doc-strings.
505
506 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
507
508 Fix minor problems found by GCC 4.6.0 static checking.
509 * buffer.c (Qclone_number): Remove for now, as it's unused.
510 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
511 (record_buffer): Remove unused local.
512 * frame.c (other_visible_frames, frame_buffer_list): Now static.
513 (set_frame_buffer_list): Remove; unused.
514 * frame.h (other_visible_frames): Remove decl.
515 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
516 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
517 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
518 if HAVE_GPM.
519 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
520 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
521 Define only if HAVE_GPM.
522 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
523 (update_hints_inhibit): Remove; never set. All uses removed.
524 * widgetprv.h (emacsFrameClassRec): Remove decl.
525 * window.c (delete_deletable_window): Now returns void, since it
526 wasn't returning anything.
527 (compare_window_configurations): Remove unused locals.
528 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
529 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
530 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
531 the same widths as pointers. This follows up on the 2011-05-06 patch.
532 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
533 * xterm.h: Likewise.
534 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
535
536 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
537
538 * makefile.w32-in: Update dependencies.
539 (LISP_H): Add lib/intprops.h.
540
541 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
542
543 * image.c (gif_load): Add animation frame delay to the metadata.
544 (syms_of_image): Use DEFSYM. New symbol `delay'.
545
546 2011-06-11 Martin Rudalics <rudalics@gmx.at>
547
548 * window.c (delete_deletable_window): Re-add.
549 (Fset_window_configuration): Rewrite to handle dead buffers and
550 consequently deletable windows.
551 (window_tree, Fwindow_tree): Remove. Supply functionality in
552 window.el.
553 (compare_window_configurations): Simplify code.
554
555 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
556
557 * image.c (imagemagick_load_image): Fix type mismatch.
558 (Fimagemagick_types): Likewise.
559
560 * window.h (replace_buffer_in_windows): Declare.
561
562 2011-06-11 Martin Rudalics <rudalics@gmx.at>
563
564 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
565 Qclone_number. Remove external declaration of Qdelete_window.
566 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
567 code.
568 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
569 Qbuffer_list_update_hook if allowed.
570 (Fother_buffer): Rewrite doc-string. Major rewrite for new
571 buffer list implementation.
572 (other_buffer_safely): New function.
573 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
574 calls to replace_buffer_in_windows and
575 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
576 if allowed.
577 (record_buffer): Inhibit quitting and rewrite using quittable
578 functions. Run Qbuffer_list_update_hook if allowed.
579 (Frecord_buffer, Funrecord_buffer): New functions.
580 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
581 switch-to-buffer to window.el.
582 (bury-buffer): Move to window.el.
583 (Vbuffer_list_update_hook): New variable.
584
585 * lisp.h (other_buffer_safely): Add prototype in buffer.c
586 section.
587
588 * window.h (resize_frame_windows): Move up in code.
589 (Fwindow_frame): Remove EXFUN.
590 (replace_buffer_in_all_windows): Remove prototype.
591 (replace_buffer_in_windows_safely): Add prototype.
592
593 * window.c: Declare Qdelete_window static again. Move down
594 declaration of select_count.
595 (Fnext_window, Fprevious_window): Rewrite doc-strings.
596 (Fother_window): Move to window.el.
597 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
598 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
599 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
600 window.el.
601 (replace_buffer_in_windows): Implement by calling
602 Qreplace_buffer_in_windows.
603 (replace_buffer_in_all_windows): Remove with some functionality
604 moved into replace_buffer_in_windows_safely.
605 (replace_buffer_in_windows_safely): New function.
606 (select_window_norecord, select_frame_norecord): Move in front
607 of run_window_configuration_change_hook. Remove now obsolete
608 declarations.
609 (Fset_window_buffer): Rewrite doc-string. Call
610 Qrecord_window_buffer.
611 (keys_of_window): Move binding for other-window to window.el.
612
613 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
614
615 * dispextern.h (struct image): Replace data member, whose int_val
616 and ptr_val fields were not used by anything, with a single
617 lisp_val object.
618
619 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
620 (gif_clear_image, gif_load, imagemagick_load_image)
621 (gs_clear_image, gs_load): Callers changed.
622
623 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
624
625 * buffer.h: Include <time.h>, for time_t.
626 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
627
628 Fix minor problems found by static checking.
629
630 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
631
632 Make identifiers static if they are not used in other modules.
633 * data.c (Qcompiled_function, Qframe, Qvector):
634 * image.c (QimageMagick, Qsvg):
635 * minibuf.c (Qmetadata):
636 * window.c (resize_window_check, resize_root_window): Now static.
637 * window.h (resize_window_check, resize_root_window): Remove decls.
638
639 * window.c (window_deletion_count, delete_deletable_window):
640 Remove; unused.
641 (window_body_lines): Now static.
642 (Fdelete_other_windows_internal): Mark vars as initialized.
643 Make sure 'resize_failed' is initialized.
644 (run_window_configuration_change_hook): Rename local to avoid shadowing.
645 (resize_window_apply): Remove unused local.
646 * window.h (delete_deletable_window): Remove decl.
647
648 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
649 (imagemagick_load_image): Fix pointer signedness problem by changing
650 last arg from unsigned char * to char *. All uses changed.
651 Also, fix a local for similar reasons.
652 Remove unused locals. Remove locals to avoid shadowing.
653 (fn_rsvg_handle_free): Remove; unused.
654 (svg_load, svg_load_image): Fix pointer signedness problem.
655 (imagemagick_load_image): Don't use garbage pointer image_wand.
656
657 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
658
659 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
660
661 * image.c (gif_load): Fix omitted cast error introduced by
662 2011-06-06 change.
663
664 2011-06-10 Martin Rudalics <rudalics@gmx.at>
665
666 * window.h (resize_proportionally, orig_total_lines)
667 (orig_top_line): Remove from window structure.
668 (set_window_height, set_window_width, change_window_heights)
669 (Fdelete_window): Remove prototypes.
670 (resize_frame_windows): Remove duplicate declaration.
671
672 2011-06-10 Eli Zaretskii <eliz@gnu.org>
673
674 * window.h (resize_frame_windows, resize_window_check)
675 (delete_deletable_window, resize_root_window)
676 (resize_frame_windows): Declare prototypes.
677
678 * window.c (resize_window_apply): Make definition be "static" to
679 match the prototype.
680
681 2011-06-10 Martin Rudalics <rudalics@gmx.at>
682
683 * window.c: Remove declarations of Qwindow_size_fixed,
684 window_min_size_1, window_min_size_2, window_min_size,
685 size_window, window_fixed_size_p, enlarge_window, delete_window.
686 Remove static from declaration of Qdelete_window, it's
687 temporarily needed by Fbury_buffer.
688 (replace_window): Don't assign orig_top_line and
689 orig_total_lines.
690 (Fdelete_window, delete_window): Remove. Window deletion is
691 handled by window.el.
692 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
693 Fdelete_window calls with calls to Qdelete_window.
694 (Fdelete_other_windows): Remove. Deleting other windows is
695 handled by window.el.
696 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
697 handled in window.el.
698 (window_min_size_2, window_min_size_1, window_min_size): Remove.
699 Window minimum sizes are handled in window.el.
700 (shrink_windows, size_window, set_window_height)
701 (set_window_width, change_window_heights, window_height)
702 (window_width, CURBEG, CURSIZE, enlarge_window)
703 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
704 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
705 handled in window.el.
706 (make_dummy_parent): Rename to make_parent_window and give it a
707 second argument horflag.
708 (make_window): Don't set resize_proportionally any more.
709 (Fsplit_window): Remove. Windows are split in window.el.
710 (save_restore_action, save_restore_orig_size)
711 (shrink_window_lowest_first, save_restore_orig_size): Remove.
712 Resize mini windows in window.el.
713 (grow_mini_window, shrink_mini_window): Implement by calling
714 Qresize_root_window_vertically, resize_window_check and
715 resize_window_apply.
716 (saved_window, Fset_window_configuration, save_window_save): Do
717 not handle orig_top_line, orig_total_lines, and
718 resize_proportionally.
719 (window_min_height, window_min_width): Move to window.el.
720 (keys_of_window): Move bindings for delete-other-windows,
721 split-window, delete-window and enlarge-window to window.el.
722
723 * buffer.c: Temporarily extern Qdelete_window.
724 (Fbury_buffer): Temporarily call Qdelete_window instead of
725 Fdelete_window (Fbury_buffer will move to window.el soon).
726
727 * frame.c (set_menu_bar_lines_1): Remove code handling
728 orig_top_line and orig_total_lines.
729
730 * dispnew.c (adjust_frame_glyphs_initially): Don't use
731 set_window_height but set heights directly.
732 (change_frame_size_1): Use resize_frame_windows.
733
734 * xdisp.c (init_xdisp): Don't use set_window_height but set
735 heights directly.
736
737 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
738 resize_frame_windows instead of change_window_heights and run
739 run_window_configuration_change_hook.
740
741 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
742 instead of change_window_heights and run
743 run_window_configuration_change_hook.
744
745 2011-06-09 Martin Rudalics <rudalics@gmx.at>
746
747 * window.c (replace_window): Rename second argument REPLACEMENT to
748 NEW. New third argument SETFLAG. Rewrite.
749 (delete_window, make_dummy_parent): Call replace_window with
750 third argument 1.
751 (window_list_1): Move down in code.
752 (run_window_configuration_change_hook): Move set_buffer part
753 before select_frame_norecord part in order to unwind correctly.
754 Rename count1 to count.
755 (recombine_windows, delete_deletable_window, resize_root_window)
756 (Fdelete_other_windows_internal)
757 (Frun_window_configuration_change_hook, make_parent_window)
758 (resize_window_check, resize_window_apply, Fresize_window_apply)
759 (resize_frame_windows, Fsplit_window_internal)
760 (Fdelete_window_internal, Fresize_mini_window_internal): New
761 functions.
762 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
763
764 2011-06-08 Martin Rudalics <rudalics@gmx.at>
765
766 * window.h (window): Add some new members to window structure -
767 normal_lines, normal_cols, new_total, new_normal, clone_number,
768 splits, nest, prev_buffers, next_buffers.
769 (WINDOW_TOTAL_SIZE): Move here from window.c.
770 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
771
772 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
773 Remove.
774 (make_dummy_parent): Set new members of windows structure.
775 (make_window): Move down in code. Handle new members of window
776 structure.
777 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
778 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
779 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
780 (Fset_window_prev_buffers, Fwindow_next_buffers)
781 (Fset_window_next_buffers, Fset_window_clone_number): New
782 functions.
783 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
784 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
785 Doc-string fixes.
786 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
787 Argument WINDOW can be now internal window too.
788 (Fwindow_use_time): Move up in code.
789 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
790 Rewrite doc-string.
791 (Fset_window_configuration, saved_window)
792 (Fcurrent_window_configuration, save_window_save): Handle new
793 members of window structure.
794 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
795 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
796 (syms_of_window): New Lisp objects Qrecord_window_buffer,
797 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
798 Qget_mru_window, Qresize_root_window,
799 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
800 Qauto_buffer_name; staticpro them.
801
802 2011-06-07 Martin Rudalics <rudalics@gmx.at>
803
804 * window.c (Fwindow_total_size, Fwindow_left_column)
805 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
806 (Fwindow_list_1): New functions.
807 (window_box_text_cols): Replace with window_body_cols.
808 (Fwindow_width, Fscroll_left, Fscroll_right): Use
809 window_body_cols instead of window_box_text_cols.
810 (delete_window, Fset_window_configuration): Call
811 delete_all_subwindows with window as argument.
812 (delete_all_subwindows): Take a window as argument and not a
813 structure. Rewrite.
814 (window_loop): Remove handling of GET_LRU_WINDOW and
815 GET_LARGEST_WINDOW.
816 (Fget_lru_window, Fget_largest_window): Move to window.el.
817
818 * window.h: Extern window_body_cols instead of
819 window_box_text_cols. delete_all_subwindows now takes a
820 Lisp_Object as argument.
821
822 * indent.c (compute_motion, Fcompute_motion): Use
823 window_body_cols instead of window_box_text_cols.
824
825 * frame.c (delete_frame): Call delete_all_subwindows with root
826 window as argument.
827
828 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
829
830 * fns.c (Fputhash): Document return value.
831
832 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
833
834 * image.c (gif_load): Implement gif89a spec "no disposal" method.
835
836 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
837
838 Cons<->int and similar integer overflow fixes (Bug#8794).
839
840 Check for overflow when converting integer to cons and back.
841 * charset.c (Fdefine_charset_internal, Fdecode_char):
842 Use cons_to_unsigned to catch overflow.
843 (Fencode_char): Use INTEGER_TO_CONS.
844 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
845 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
846 * data.c (long_to_cons, cons_to_long): Remove.
847 (cons_to_unsigned, cons_to_signed): New functions.
848 These signal an error for invalid or out-of-range values.
849 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
850 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
851 * font.c (Ffont_variation_glyphs):
852 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
853 * lisp.h: Include <intprops.h>.
854 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
855 (cons_to_signed, cons_to_unsigned): New decls.
856 (long_to_cons, cons_to_long): Remove decls.
857 * undo.c (record_first_change): Use INTEGER_TO_CONS.
858 (Fprimitive_undo): Use CONS_TO_INTEGER.
859 * xfns.c (Fx_window_property): Likewise.
860 * xselect.c: Include <limits.h>.
861 (x_own_selection, selection_data_to_lisp_data):
862 Use INTEGER_TO_CONS.
863 (x_handle_selection_request, x_handle_selection_clear)
864 (x_get_foreign_selection, Fx_disown_selection_internal)
865 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
866 (lisp_data_to_selection_data): Use cons_to_unsigned.
867 (x_fill_property_data): Use cons_to_signed.
868 Report values out of range.
869
870 Check for buffer and string overflow more precisely.
871 * buffer.h (BUF_BYTES_MAX): New macro.
872 * lisp.h (STRING_BYTES_MAX): New macro.
873 * alloc.c (Fmake_string):
874 * character.c (string_escape_byte8):
875 * coding.c (coding_alloc_by_realloc):
876 * doprnt.c (doprnt):
877 * editfns.c (Fformat):
878 * eval.c (verror):
879 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
880 since they may not be the same number.
881 * editfns.c (Finsert_char):
882 * fileio.c (Finsert_file_contents):
883 Likewise for BUF_BYTES_MAX.
884
885 * image.c: Use ptrdiff_t, not int, for sizes.
886 (slurp_file): Switch from int to ptrdiff_t.
887 All uses changed.
888 (slurp_file): Check that file size fits in both size_t (for
889 malloc) and ptrdiff_t (for sanity and safety).
890
891 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
892 if b->modtime has its maximal value.
893
894 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
895
896 Don't assume time_t can fit into int.
897 * buffer.h (struct buffer.modtime): Now time_t, not int.
898 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
899 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
900
901 Minor fixes for signed vs unsigned integers.
902 * character.h (MAYBE_UNIFY_CHAR):
903 * charset.c (maybe_unify_char):
904 * keyboard.c (read_char, reorder_modifiers):
905 XINT -> XFASTINT, since the integer must be nonnegative.
906 * ftfont.c (ftfont_spec_pattern):
907 * keymap.c (access_keymap, silly_event_symbol_error):
908 XUINT -> XFASTINT, since the integer must be nonnegative.
909 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
910 since it makes no difference and we prefer signed.
911 * keyboard.c (record_char): Use XUINT when all the neighbors do.
912 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
913 nonnegative.
914
915 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
916
917 * window.h (Fwindow_frame): Declare.
918
919 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
920
921 * alloc.c: Simplify handling of large-request failures (Bug#8800).
922 (SPARE_MEMORY): Always define.
923 (LARGE_REQUEST): Remove.
924 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
925
926 2011-06-06 Martin Rudalics <rudalics@gmx.at>
927
928 * lisp.h: Move EXFUNS for Fframe_root_window,
929 Fframe_first_window and Fset_frame_selected_window to window.h.
930
931 * window.h: Move EXFUNS for Fframe_root_window,
932 Fframe_first_window and Fset_frame_selected_window here from
933 lisp.h.
934
935 * frame.c (Fwindow_frame, Fframe_first_window)
936 (Fframe_root_window, Fframe_selected_window)
937 (Fset_frame_selected_window): Move to window.c.
938 (Factive_minibuffer_window): Move to minibuf.c.
939 (Fother_visible_frames_p): New function.
940
941 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
942
943 * window.c (decode_window, decode_any_window): Move up in code.
944 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
945 (inhibit_frame_unsplittable): Remove unused variable.
946 (Fwindow_buffer): Move up and rewrite doc-string.
947 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
948 (Fwindow_prev): New functions.
949 (Fwindow_frame): Move here from frame.c. Accept any window as
950 argument.
951 (Fframe_root_window, Fframe_first_window)
952 (Fframe_selected_window): Move here from frame.c. Accept frame
953 or arbitrary window as argument. Update doc-strings.
954 (Fminibuffer_window): Move up in code.
955 (Fwindow_minibuffer_p): Move up in code and simplify.
956 (Fset_frame_selected_window): Move here from frame.c.
957 Marginal rewrite.
958 (Fselected_window, select_window, Fselect_window): Move up in
959 code. Minor doc-string fixes.
960
961 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
962
963 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
964 Do not assume that spare memory exists; that assumption is valid
965 only if SYSTEM_MALLOC.
966 (LARGE_REQUEST): New macro, so that the issue of large requests
967 is separated from the issue of spare memory.
968
969 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
970
971 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
972 format. (Bug#8806)
973
974 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
975
976 * xfns.c (x_set_scroll_bar_default_width): Move declarations
977 before statements.
978
979 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
980
981 * gtkutil.c (xg_get_default_scrollbar_width): New function.
982
983 * gtkutil.h: Declare xg_get_default_scrollbar_width.
984
985 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
986 min width by calling x_set_scroll_bar_default_width (Bug#8505).
987
988 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
989
990 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
991
992 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
993
994 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
995 (x_clipboard_manager_save): Add return value.
996 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
997 New error handlers.
998 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
999 Obey Vx_select_enable_clipboard_manager. Catch errors in
1000 x_clipboard_manager_save (Bug#8779).
1001 (Vx_select_enable_clipboard_manager): New variable.
1002 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1003
1004 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1005
1006 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1007
1008 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1009
1010 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1011 in the current matrix if keep_current_p is non-zero.
1012
1013 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1014
1015 * bidi.c (bidi_level_of_next_char): Fix last change.
1016
1017 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1018
1019 Support bidi reordering of text covered by display properties.
1020
1021 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1022 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1023 (bidi_cache_search, bidi_cache_iterator_state)
1024 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1025 (bidi_level_of_next_char, bidi_move_to_visually_next):
1026 Support character positions inside a run of characters covered by a
1027 display string.
1028 (bidi_paragraph_init, bidi_resolve_explicit_1)
1029 (bidi_level_of_next_char): Call bidi_fetch_char and
1030 bidi_fetch_char_advance instead of FETCH_CHAR and
1031 FETCH_CHAR_ADVANCE.
1032 (bidi_init_it): Initialize new members.
1033 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1034 definitions.
1035 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1036 instead of using explicit *_CHAR codes.
1037 (bidi_resolve_explicit, bidi_resolve_weak):
1038 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1039 bidirectional text is supported only in multibyte buffers.
1040 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1041 it to initialize the frame_window_p member of struct bidi_it.
1042 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1043 (bidi_resolve_explicit, bidi_resolve_weak)
1044 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1045 bidi_it->nchars is non-positive.
1046 (bidi_level_of_next_char): Don't try to lookup the cache for the
1047 next/previous character if nothing is cached there yet, or if we
1048 were just reseat()'ed to a new position.
1049
1050 * xdisp.c (set_cursor_from_row): Set start and stop points
1051 according to the row's direction when priming the loop that looks
1052 for the glyph on which to display cursor.
1053 (single_display_spec_intangible_p): Function deleted.
1054 (display_prop_intangible_p): Reimplement to call
1055 handle_display_spec instead of single_display_spec_intangible_p.
1056 Accept 3 additional arguments needed by handle_display_spec.
1057 This fixes incorrect cursor motion across display property with complex
1058 values: lists, `(when COND...)' forms, etc.
1059 (single_display_spec_string_p): Support property values that are
1060 lists with the argument STRING its top-level element.
1061 (display_prop_string_p): Fix the condition for processing a
1062 property that is a list to be consistent with handle_display_spec.
1063 (handle_display_spec): New function, refactored from the
1064 last portion of handle_display_prop.
1065 (compute_display_string_pos): Accept additional argument
1066 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1067 value of a `display' property is a "replacing spec".
1068 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1069 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1070 the display property, but just return a value indicating whether
1071 the display property will replace the characters it covers.
1072 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1073 frame_window_p members of struct bidi_it.
1074 (compute_display_string_pos, compute_display_string_end):
1075 New functions.
1076 (push_it): Accept second argument POSITION, where pop_it should
1077 jump to continue iteration.
1078 (reseat_1): Initialize bidi_it.disp_pos.
1079
1080 * keyboard.c (adjust_point_for_property): Adjust the call to
1081 display_prop_intangible_p to its new signature.
1082
1083 * dispextern.h (struct bidi_it): New member frame_window_p.
1084 (bidi_init_it): Update prototypes.
1085 (display_prop_intangible_p): Update prototype.
1086 (compute_display_string_pos, compute_display_string_end):
1087 Declare prototypes.
1088 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1089 EMACS_INT.
1090
1091 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 Malloc failure behavior now depends on size of allocation.
1094 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1095 * lisp.h: Change signatures accordingly.
1096 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1097 All callers changed. (Bug#8762)
1098
1099 * gnutls.c: Use Emacs's memory allocators.
1100 Without this change, the gnutls library would invoke malloc etc.
1101 directly, which causes problems on non-SYNC_INPUT hosts, and which
1102 runs afoul of improving memory_full behavior. (Bug#8761)
1103 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1104 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1105 xfree instead of the default malloc, realloc, free.
1106 (Fgnutls_boot): No need to check for memory allocation failure,
1107 since xmalloc does that for us.
1108
1109 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1110 * category.c (hash_get_category_set):
1111 * ccl.c (ccl_driver):
1112 * charset.c (Fdefine_charset_internal):
1113 * charset.h (struct charset.hash_index):
1114 * composite.c (get_composition_id, gstring_lookup_cache)
1115 (composition_gstring_put_cache):
1116 * composite.h (struct composition.hash_index):
1117 * dispextern.h (struct image.hash):
1118 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1119 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1120 (hashfn_equal, hashfn_user_defined, make_hash_table)
1121 (maybe_resize_hash_table, hash_lookup, hash_put)
1122 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1123 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1124 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1125 * image.c (make_image, search_image_cache, lookup_image)
1126 (xpm_put_color_table_h):
1127 * lisp.h (struct Lisp_Hash_Table):
1128 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1129 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1130 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1131 * alloc.c (allocate_vectorlike):
1132 Check for overflow in vector size calculations.
1133 * ccl.c (ccl_driver):
1134 Check for overflow when converting EMACS_INT to int.
1135 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1136 need to be updated by these changes.
1137 * fns.c (make_hash_table, maybe_resize_hash_table):
1138 Check for integer overflow with large hash tables.
1139 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1140 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1141 (SXHASH_REDUCE): New macro.
1142 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1143 Use it instead of discarding useful hash info with large hash values.
1144 (sxhash_float): New function.
1145 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1146 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1147 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1148 Rewrite to use FIXNUM_BITS, as this simplifies things.
1149 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1150 Adjust signatures to match updated version of code.
1151 (consing_since_gc): Now EMACS_INT, since a single hash table can
1152 use more than INT_MAX bytes.
1153
1154 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1155
1156 Make it possible to build with GCC-4.6+ -O2 -flto.
1157
1158 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1159
1160 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1161
1162 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1163 Call minibuffer-inactive-mode.
1164
1165 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1166
1167 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1168 Update dependencies.
1169
1170 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1171
1172 * data.c (init_data): Remove code for UTS, this system is not
1173 supported anymore.
1174
1175 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1176
1177 Don't force ./temacs to start in terminal mode.
1178
1179 * frame.c (make_initial_frame): Initialize faces in all cases, not
1180 only when CANNOT_DUMP is defined.
1181 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1182
1183 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1184
1185 * dispnew.c (add_window_display_history): Use const for the string
1186 pointer. Remove declaration, not needed.
1187
1188 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1189
1190 Use 'inline', not 'INLINE'.
1191 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1192 * alloc.c, fontset.c (INLINE): Remove.
1193 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1194 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1195 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1196 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1197 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1198
1199 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1200
1201 Make it possible to run ./temacs.
1202
1203 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1204 syms_of_callproc does the same thing. Remove test for
1205 "initialized", do it in the caller.
1206 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1207
1208 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1209
1210 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1211 (read_minibuf): Use get_minibuffer.
1212 (syms_of_minibuf): Use DEFSYM.
1213 (Qmetadata): New var.
1214 * data.c (Qbuffer): Don't make it static.
1215 (syms_of_data): Use DEFSYM.
1216
1217 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1218
1219 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1220 (CCL_CODE_MIN): New macro.
1221
1222 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1223
1224 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1225
1226 * eval.c (Qdebug): Now static.
1227 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1228 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1229 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1230
1231 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1232
1233 * image.c: Various fixes to ImageMagick code comments.
1234 (Fimagemagick_types): Doc fix.
1235
1236 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 Minor fixes prompted by GCC 4.6.0 warnings.
1239
1240 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1241
1242 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1243 (x_clipboard_manager_save_all): Move extern decl to ...
1244 * xterm.h: ... here, so that it can be checked for consistency.
1245
1246 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1247
1248 * xselect.c (x_clipboard_manager_save_frame)
1249 (x_clipboard_manager_save_all): New functions.
1250 (Fx_clipboard_manager_save): Lisp function deleted.
1251
1252 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1253 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1254
1255 * xterm.h: Update prototype.
1256
1257 2011-05-28 William Xu <william.xwl@gmail.com>
1258
1259 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1260 exiting (Bug#8239).
1261
1262 2011-05-28 Jim Meyering <meyering@redhat.com>
1263
1264 Avoid a sign-extension bug in crypto_hash_function.
1265 * fns.c (to_uchar): Define.
1266 (crypto_hash_function): Use it to convert some newly-signed
1267 variables to unsigned, to avoid sign-extension bugs. For example,
1268 without this change, (md5 "truc") would evaluate to
1269 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1270 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1271 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1272
1273 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1274
1275 Integer overflow fixes.
1276
1277 * dbusbind.c: Serial number integer overflow fixes.
1278 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1279 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1280 to hold a serial number that is too large for a fixnum.
1281 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1282 Check for serial numbers out of range. Decode any serial number
1283 that was so large that it became a float. (Bug#8722)
1284
1285 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1286 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1287 Use XFASTINT rather than XUINT when numbers are nonnegative.
1288 (xd_append_arg, Fdbus_method_return_internal):
1289 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1290 arguments, check that Lisp number is nonnegative, rather than
1291 silently wrapping negative numbers around. (Bug#8722)
1292 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1293 (Bug#8722)
1294
1295 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1296
1297 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1298
1299 ccl: add integer overflow checks
1300 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1301 (IN_INT_RANGE): New macros.
1302 (ccl_driver): Use them to check for integer overflow when
1303 decoding a CCL program. Many of the new checks are whether XINT (x)
1304 fits in int; it doesn't always, on 64-bit hosts. The new version
1305 doesn't catch all possible integer overflows, but it's an
1306 improvement. (Bug#8719)
1307
1308 * alloc.c (make_event_array): Use XINT, not XUINT.
1309 There's no need for unsigned here.
1310
1311 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1312 This follows up to the 2011-05-06 change that substituted uintptr_t
1313 for EMACS_INT. This case wasn't caught back then.
1314
1315 Rework Fformat to avoid integer overflow issues.
1316 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1317 now (part of C89). Include <verify.h>.
1318 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1319 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1320 (Fformat): Avoid the prepass trying to compute sizes; it was only
1321 approximate and thus did not catch overflow reliably. Instead, walk
1322 through the format just once, formatting and computing sizes as we go,
1323 checking for integer overflow at every step, and allocating a larger
1324 buffer as needed. Keep track separately whether the format is
1325 multibyte. Keep only the most-recently calculated precision, rather
1326 than them all. Record whether each argument has been converted to
1327 string. Use EMACS_INT, not int, for byte and char and arg counts.
1328 Support field widths and precisions larger than INT_MAX. Avoid
1329 sprintf's undefined behavior with conversion specifications such as %#d
1330 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1331 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1332 formatting out-of-range floating point numbers with int
1333 formats. (Bug#8668)
1334
1335 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1336
1337 * data.c: Avoid integer truncation in expressions involving floats.
1338 * data.c: Include <intprops.h>.
1339 (arith_driver): When there's an integer overflow in an expression
1340 involving floating point, convert the integers to floating point
1341 so that the resulting value does not suffer from catastrophic
1342 integer truncation. For example, on a 64-bit host (* 4
1343 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1344 Do not rely on undefined behavior after integer overflow.
1345
1346 merge count_size_as_multibyte, parse_str_to_multibyte
1347 * character.c, character.h (count_size_as_multibyte):
1348 Rename from parse_str_to_multibyte; all uses changed.
1349 Check for integer overflow.
1350 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1351 since it's now a duplicate of the other. This is more of
1352 a character than a buffer op, so better that it's in character.c.
1353 * fns.c, print.c: Adjust to above changes.
1354
1355 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1356
1357 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1358
1359 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1362 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1363 (x_clipboard_manager_save): Now static.
1364 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1365
1366 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1367 (crypto_hash_function): Now static.
1368 Fix pointer signedness problems. Avoid unnecessary initializations.
1369
1370 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1371
1372 * termhooks.h (Vselection_alist): Make it terminal-local.
1373
1374 * terminal.c (create_terminal): Initialize it.
1375
1376 * xselect.c: Support for clipboard managers.
1377 (Vselection_alist): Move to termhooks.h as terminal-local var.
1378 (LOCAL_SELECTION): New macro.
1379 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1380 (symbol_to_x_atom): Remove gratuitous arg.
1381 (x_handle_selection_request, lisp_data_to_selection_data)
1382 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1383 (x_own_selection, x_get_local_selection, x_convert_selection):
1384 New arg, specifying work frame. Use terminal-local Vselection_alist.
1385 (some_frame_on_display): Delete unused function.
1386 (Fx_own_selection_internal, Fx_get_selection_internal)
1387 (Fx_disown_selection_internal, Fx_selection_owner_p)
1388 (Fx_selection_exists_p): New optional frame arg.
1389 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1390 (x_handle_selection_clear): Don't treat other terminals with the
1391 same keyboard specially. Use the terminal-local Vselection_alist.
1392 (x_clear_frame_selections): Use Frun_hook_with_args.
1393
1394 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1395
1396 * xterm.h: Add support for those atoms.
1397
1398 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1399
1400 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1401 (converted_selections, conversion_fail_tag): New global variables.
1402 (x_selection_request_lisp_error): Free the above.
1403 (x_get_local_selection): Remove unnecessary code.
1404 (x_reply_selection_request): Args changed; handle arbitrary array
1405 of converted selections stored in converted_selections.
1406 Separate the XChangeProperty and SelectionNotify steps.
1407 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1408 (x_convert_selection): New function.
1409 (x_handle_selection_event): Simplify.
1410 (x_get_foreign_selection): Don't ignore incoming requests while
1411 waiting for an answer; this will fail when we implement
1412 SAVE_TARGETS, and seems unnecessary anyway.
1413 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1414 (Vx_sent_selection_functions): Doc fix.
1415
1416 2011-05-26 Leo Liu <sdl.web@gmail.com>
1417
1418 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1419
1420 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1421
1422 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1423
1424 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1425 for fringe update if it has periodic bitmap.
1426 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1427 and fringe_bitmap_periodic_p.
1428
1429 * fringe.c (get_fringe_bitmap_data): New function.
1430 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1431 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1432 row. Mark glyph row for fringe update if periodicity changed.
1433
1434 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1435 for fringe update unless it has periodic bitmap.
1436
1437 2011-05-25 Kenichi Handa <handa@m17n.org>
1438
1439 * xdisp.c (get_next_display_element): Set correct it->face_id for
1440 a static composition.
1441
1442 2011-05-24 Leo Liu <sdl.web@gmail.com>
1443
1444 * deps.mk (fns.o):
1445 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1446
1447 * fns.c (crypto_hash_function, Fsha1): New function.
1448 (Fmd5): Use crypto_hash_function.
1449 (syms_of_fns): Add Ssha1.
1450
1451 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1452
1453 * gnutls.c: Remove unused macros.
1454 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1455 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1456 Remove macros that are defined and never used.
1457 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1458
1459 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1460
1461 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1462 (Fx_get_selection_internal): Minor cleanup.
1463 (Fx_own_selection_internal): Rename arguments for consistency with
1464 select.el.
1465
1466 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1467
1468 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1469
1470 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1471
1472 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1473
1474 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1475
1476 * dispnew.c (scrolling_window): Don't exclude the case that the
1477 last enabled row in the desired matrix touches the bottom boundary.
1478
1479 2011-05-21 Glenn Morris <rgm@gnu.org>
1480
1481 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1482 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1483 and add some more files.
1484
1485 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1486
1487 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1488 report_file_error introduced by the change from 2011-05-07.
1489
1490 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1491
1492 * systime.h (Time): Define only if emacs is defined.
1493 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1494 where the include path doesn't have X11/X.h by default. See
1495 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1496
1497 2011-05-20 Kenichi Handa <handa@m17n.org>
1498
1499 * composite.c (find_automatic_composition): Fix previous change.
1500
1501 2011-05-20 Glenn Morris <rgm@gnu.org>
1502
1503 * lisp.mk: New file, split from Makefile.in.
1504 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1505 (shortlisp): Remove.
1506 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1507
1508 2011-05-19 Glenn Morris <rgm@gnu.org>
1509
1510 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1511 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1512 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1513 (lisp): Set the order to that of loadup.el.
1514 (shortlisp): Make it a copy of $lisp.
1515 (SOME_MACHINE_LISP): Remove.
1516 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1517 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1518
1519 2011-05-18 Kenichi Handa <handa@m17n.org>
1520
1521 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1522 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1523 (find_automatic_composition): Mostly rewrite for efficiency.
1524
1525 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1526
1527 * makefile.w32-in: Update dependencies.
1528
1529 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1530
1531 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1532 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1533
1534 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 Fix some integer overflow issues, such as string length overflow.
1537
1538 * insdel.c (count_size_as_multibyte): Check for string overflow.
1539
1540 * character.c (lisp_string_width): Check for string overflow.
1541 Use EMACS_INT, not int, for string indexes and lengths; in
1542 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1543 the resulting string length overflows an EMACS_INT; instead,
1544 report a string overflow if no precision given. When checking for
1545 precision exhaustion, use a check that cannot possibly have
1546 integer overflow. (Bug#8675)
1547 * character.h (lisp_string_width): Adjust to new signature.
1548
1549 * alloc.c (string_overflow): New function.
1550 (Fmake_string): Use it. This doesn't change behavior, but saves
1551 a few bytes and will simplify future changes.
1552 * character.c (string_escape_byte8): Likewise.
1553 * lisp.h (string_overflow): New decl.
1554
1555 Fixups, following up to the user-interface timestamp change.
1556 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1557 for UI timestamps, instead of unsigned long.
1558 * msdos.c (mouse_get_pos): Likewise.
1559 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1560 * w32gui.h (Time): Define by including "systime.h" rather than by
1561 declaring it ourselves. (Bug#8664)
1562
1563 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1564 * image.c (clear_image_cache): Likewise.
1565
1566 * term.c (term_mouse_position): Don't assume time_t wraparound.
1567
1568 Be more systematic about user-interface timestamps.
1569 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1570 and sometimes 'EMACS_UINT', to represent these timestamps.
1571 This change causes it to use 'Time' uniformly, as that's what X uses.
1572 This makes the code easier to follow, and makes it easier to catch
1573 integer overflow bugs such as Bug#8664.
1574 * frame.c (Fmouse_position, Fmouse_pixel_position):
1575 Use Time, not unsigned long, for user-interface timestamps.
1576 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1577 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1578 * keyboard.h (last_event_timestamp): Likewise.
1579 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1580 * menu.h (xmenu_show): Likewise.
1581 * term.c (term_mouse_position): Likewise.
1582 * termhooks.h (struct input_event.timestamp): Likewise.
1583 (struct terminal.mouse_position_hook): Likewise.
1584 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1585 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1586 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1587 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1588 what it was before.
1589 * menu.h, termhooks.h: Include "systime.h", for Time.
1590
1591 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1592 Don't assume that the difference between two unsigned long values
1593 can fit into an integer. At this point, we know button_down_time
1594 <= event->timestamp, so the difference must be nonnegative, so
1595 there's no need to cast the result if double-click-time is
1596 nonnegative, as it should be; check that it's nonnegative, just in
1597 case. This bug is triggered when events are more than 2**31 ms
1598 apart (about 25 days). (Bug#8664)
1599
1600 * xselect.c (last_event_timestamp): Remove duplicate decl.
1601 (x_own_selection): Remove needless cast to unsigned long.
1602
1603 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1604 that always fit in int. Use a sentinel instead of a counter, to
1605 avoid a temp and to allay GCC's concerns about possible int overflow.
1606 * frame.h (struct frame): Use int for menu_bar_items_used
1607 instead of EMACS_INT, since it always fits in int.
1608
1609 * menu.c (grow_menu_items): Check for int overflow.
1610
1611 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1612
1613 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1614 Before, the code was not consistent. These values cannot exceed
1615 2**31 - 1 so there's no need to make them unsigned.
1616 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1617 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1618 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1619 as modifiers.
1620 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1621
1622 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1623 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1624 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1625 presumably because the widths might not match.
1626
1627 * window.c (size_window): Avoid needless test at loop start.
1628
1629 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1630
1631 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1632
1633 2011-05-12 Drew Adams <drew.adams@oracle.com>
1634
1635 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1636
1637 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1638
1639 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1640 `width' to `bar_area_x' and `bar_area_width', respectively.
1641 (x_scroll_run): Take account of fringe background extension.
1642
1643 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1644 Rename local vars `left' and `width' to `bar_area_x' and
1645 `bar_area_width', respectively.
1646 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1647 background extension.
1648
1649 2011-05-10 Jim Meyering <meyering@redhat.com>
1650
1651 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1652
1653 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1654
1655 * image.c (Finit_image_library): Return t for built-in image types,
1656 like pbm and xbm. (Bug#8640)
1657
1658 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1659
1660 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1661
1662 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1663
1664 * w32console.c (Fset_screen_color): Doc fix.
1665 (Fget_screen_color): New function.
1666 (syms_of_ntterm): Defsubr it.
1667
1668 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1669 unlink the temporary file if Fcall_process didn't create it in the
1670 first place.
1671 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1672 child process will be redirected to a file specified with `:file'.
1673 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1674 cue to call_process_cleanup not to close that handle.
1675
1676 2011-05-07 Ben Key <bkey76@gmail.com>
1677
1678 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1679 one of two shell specific rules, either bootstrap-temacs-CMD or
1680 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1681 to the previous implementation of the bootstrap-temacs rule.
1682 The bootstrap-temacs-CMD rule is similar to the previous
1683 implementation of the bootstrap-temacs rule except that it
1684 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1685 variable.
1686
1687 These changes, along with some changes to nt/configure.bat,
1688 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1689 earlier fix to add support for --cflags and --ldflags options
1690 that include quotes so that it works whether make uses cmd or
1691 sh as the shell.
1692
1693 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1694
1695 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1696 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1697 is a constant.
1698 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1699 a string. Handle both cases.
1700 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1701 (Fdbus_register_method): Use Qinvalid_function.
1702
1703 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1704
1705 * makefile.w32-in: Update dependencies.
1706 (LISP_H): Add inttypes.h and stdin.h.
1707 (PROCESS_H): Add unistd.h.
1708
1709 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1710
1711 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1712 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1713
1714 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1715
1716 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1717
1718 * term.c (vfatal): Remove stray call to va_end.
1719 It's not needed and the C Standard doesn't allow it here anyway.
1720
1721 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1722 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1723
1724 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1725 bytes.
1726
1727 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1728
1729 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1730
1731 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1732
1733 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1734
1735 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1736
1737 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1738 * charset.c (Fdefine_charset_internal): Don't initialize
1739 charset.code_space[15]. The value was garbage, on hosts with
1740 32-bit int (Bug#8600).
1741
1742 * lread.c (read_integer): Be more consistent with string-to-number.
1743 Use string_to_number to do the actual conversion; this avoids
1744 rounding errors and fixes some other screwups. Without this fix,
1745 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1746 (digit_to_number): Move earlier, for benefit of read_integer.
1747 Return -1 if the digit is out of range for the base, -2 if it is
1748 not a digit in any supported base. (Bug#8602)
1749
1750 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1751
1752 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1753 to match comment at start of function. This also removes a
1754 GCC warning about overflow in a 32+64-bit port.
1755
1756 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1757
1758 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1759 Reported by Stefan Monnier in
1760 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1761 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1762 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1763
1764 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1765 (EMACS_UINTPTR): Likewise, with uintptr_t.
1766
1767 * lisp.h: Prefer 64-bit EMACS_INT if available.
1768 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1769 on 32-bit hosts that have 64-bit int, so that they can access
1770 large files.
1771 However, temporarily disable this change unless the temporary
1772 symbol WIDE_EMACS_INT is defined.
1773
1774 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1775
1776 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1777 This removes an assumption that EMACS_INT and long are the same
1778 width as pointers. The assumption is true for Emacs porting targets
1779 now, but we want to make other targets possible.
1780 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1781 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1782 In the rest of the code, change types of integers that hold casted
1783 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1784 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1785 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1786 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1787 No need to cast type when ORing.
1788 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1789 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1790 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1791 assume EMACS_INT is the same width as char *.
1792 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1793 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1794 Remove no-longer-needed casts.
1795 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1796 (xg_tool_bar_help_callback, xg_make_tool_item):
1797 Use EMACS_INTPTR to hold an integer
1798 that will be cast to void *; this can avoid a GCC warning
1799 if EMACS_INT is not the same width as void *.
1800 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1801 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1802 (current_message_1, set_message_1):
1803 Use a local to convert to proper width without a cast.
1804 * xmenu.c (dialog_selection_callback): Likewise.
1805
1806 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1807 Also, don't assume VALBITS / RAND_BITS is less than 5,
1808 and don't rely on undefined behavior when shifting a 1 left into
1809 the sign bit.
1810 * lisp.h (get_random): Change signature to match.
1811
1812 * lread.c (hash_string): Use size_t, not int, for hash computation.
1813 Normally we prefer signed values; but hashing is special, because
1814 it's better to use unsigned division on hash table sizes so that
1815 the remainder is nonnegative. Also, size_t is the natural width
1816 for hashing into memory. The previous code used 'int', which doesn't
1817 retain enough info to hash well into very large tables.
1818 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1819
1820 * dbusbind.c: Don't possibly lose pointer info when converting.
1821 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1822 Use XPNTR rather than XHASH, so that the high-order bits of
1823 the pointer aren't lost when converting through void *.
1824
1825 * eval.c (Fautoload): Don't double-shift a pointer.
1826
1827 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1828
1829 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1830
1831 * gnutls.c (DEF_GNUTLS_FN):
1832 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1833
1834 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1835
1836 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1837 marker. (Bug#8610)
1838
1839 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1840
1841 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1842 New version that can reserve upto 2GB of heap space.
1843
1844 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1845
1846 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1847
1848 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1849
1850 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1851 `gnutls_certificate_set_x509_key_file'.
1852
1853 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1854
1855 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1856 Update dependencies.
1857
1858 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1859
1860 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1861 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1862 Remove unused parameter `fildes'.
1863 * process.c (read_process_output, send_process): Don't pass it.
1864
1865 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1866
1867 Fix previous change: the library cache is defined in w32.c.
1868 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1869 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1870
1871 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1872
1873 Implement dynamic loading of GnuTLS on Windows.
1874
1875 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1876 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1877 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1878 Declare.
1879
1880 * gnutls.c (Qgnutls_dll): Define.
1881 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1882 (gnutls_*): Declare function pointers.
1883 (init_gnutls_functions): New function to initialize function pointers.
1884 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1885 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1886 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1887 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1888 (emacs_gnutls_write, emacs_gnutls_read)
1889 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1890 (Fgnutls_available_p): New function.
1891 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1892 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1893 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1894
1895 * image.c: Include w32.h.
1896 (Vimage_type_cache): Delete.
1897 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1898 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1899 (w32_delayed_load): Move to w32.c.
1900
1901 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1902
1903 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1904 (w32_delayed_load): Move from image.c. When loading a library, record
1905 its filename in the :loaded-from property of the library id.
1906 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1907 Initialize and staticpro them.
1908 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1909
1910 * process.c: Include lisp.h before w32.h, not after.
1911 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1912 instead of gnutls_record_check_pending.
1913
1914 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1915
1916 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1917
1918 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1919 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1920 as passed in.
1921
1922 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1923
1924 * xterm.c (x_set_frame_alpha): Do not set property on anything
1925 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1926
1927 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1928
1929 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1930
1931 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1932
1933 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1934 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1935 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1936 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1937 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1938 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1939 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1940 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1941 (Qgnutls_bootprop_callbacks_verify): Make static.
1942
1943 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1944
1945 * callproc.c: Indentation fixup.
1946
1947 * sysdep.c (wait_for_termination_1): Make static.
1948 (wait_for_termination, interruptible_wait_for_termination):
1949 Move after wait_for_termination_1.
1950
1951 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1952
1953 * sysdep.c (interruptible_wait_for_termination): New function
1954 which is like wait_for_termination, but allows keyboard
1955 interruptions.
1956
1957 * callproc.c (Fcall_process): Add (:file "file") as an option for
1958 the STDOUT buffer.
1959 (Fcall_process_region): Ditto.
1960
1961 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1962
1963 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1964 rather than `XVECTOR (FOO)->size'.
1965
1966 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1967 inttypes.h, as a gnulib replacement is used if it not available in
1968 system headers.
1969
1970 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1971
1972 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1973 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1974 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1975
1976 * coding.c (coding_alloc_by_realloc): Error out if destination
1977 will grow beyond MOST_POSITIVE_FIXNUM.
1978 (decode_coding_emacs_mule): Abort if there isn't enough place in
1979 charbuf for the composition carryover bytes. Reserve an extra
1980 space for up to 2 characters produced in a loop.
1981 (decode_coding_iso_2022): Abort if there isn't enough place in
1982 charbuf for the composition carryover bytes.
1983
1984 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1985
1986 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1987 aborting when %lld or %lll format is passed.
1988 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1989 %llo or %llx format is passed. (Bug#8545)
1990
1991 * window.c (window_scroll_line_based): Use a marker instead of
1992 simple variables to record original value of point. (Bug#7952)
1993
1994 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1995 produced by %s or %c overflows available buffer space. (Bug#8545)
1996
1997 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1998
1999 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2000 (SIZE_MAX): Move defn after all includes, as they might #define it.
2001
2002 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2003
2004 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2005
2006 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2007
2008 * keyboard.c (Qdelayed_warnings_hook): Define.
2009 (command_loop_1): Run `delayed-warnings-hook'
2010 if Vdelayed_warnings_list is non-nil.
2011 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2012 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2013
2014 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2015
2016 * doprnt.c (doprnt): Don't return value smaller than the buffer
2017 size if the message was truncated. (Bug#8545).
2018
2019 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2020
2021 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2022 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2023
2024 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2025
2026 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2027
2028 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2029
2030 * makefile.w32-in: Update dependencies.
2031
2032 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2033
2034 Improve `doprnt' and its usage. (Bug#8545)
2035 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2036 `format_end'. Remove support for %l as a conversion specifier.
2037 Don't use xrealloc. Improve diagnostics when the %l size modifier
2038 is used. Update the commentary.
2039
2040 * eval.c (verror): Simplify calculation of size_t.
2041
2042 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2043 messages.
2044
2045 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2046
2047 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2048 change.
2049
2050 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2051
2052 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2053 This makes this file independent of the recent pseudovector change.
2054
2055 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2056
2057 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2058
2059 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2060 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2061 Remove unused local.
2062 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2063
2064 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2065 GCC 4.6.0 optimizes based on type-based alias analysis.
2066 For example, if b is of type struct buffer * and v of type struct
2067 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2068 != &v->size, and therefore "v->size = 1; b->size = 2; return
2069 v->size;" must therefore return 1. This assumption is incorrect
2070 for Emacs, since it type-puns struct Lisp_Vector * with many other
2071 types. To fix this problem, this patch adds a new type struct
2072 vectorlike_header that documents the constraints on layout of vectors
2073 and pseudovectors, and helps optimizing compilers not get fooled
2074 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2075 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2076 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2077 the size member.
2078 (XSETPVECTYPE): Rewrite in terms of new macro.
2079 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2080 This is a bit clearer, and further avoids the possibility of
2081 undesirable aliasing.
2082 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2083 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2084 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2085 since Lisp_Subr is a special case (no "next" field).
2086 (ASIZE): Now uses header.size rather than size.
2087 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2088 to avoid the hassle of writing XVECTOR (foo)->header.size.
2089 (struct vectorlike_header): New type.
2090 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2091 object, to help avoid aliasing.
2092 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2093 (SUBRP): Likewise, since Lisp_Subr is a special case.
2094 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2095 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2096 (struct Lisp_Hash_Table): Combine first two members into a single
2097 struct vectorlike_header member. All uses of "size" and "next" members
2098 changed to be "header.size" and "header.next".
2099 * buffer.h (struct buffer): Likewise.
2100 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2101 * frame.h (struct frame): Likewise.
2102 * process.h (struct Lisp_Process): Likewise.
2103 * termhooks.h (struct terminal): Likewise.
2104 * window.c (struct save_window_data, struct saved_window): Likewise.
2105 * window.h (struct window): Likewise.
2106 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2107 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2108 * buffer.c (init_buffer_once): Likewise.
2109 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2110 special case.
2111 * process.c (Fformat_network_address): Use local var for size,
2112 for brevity.
2113
2114 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2115
2116 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2117 * data.c (atof): Remove decl; no longer used or needed.
2118 (digit_to_number): Move to lread.c.
2119 (Fstring_to_number): Use new string_to_number function, to be
2120 consistent with how the Lisp reader treats infinities and NaNs.
2121 Do not assume that floating-point numbers represent EMACS_INT
2122 without losing information; this is not true on most 64-bit hosts.
2123 Avoid double-rounding errors, by insisting on integers when
2124 parsing non-base-10 numbers, as the documentation specifies.
2125 * lisp.h (string_to_number): New decl, replacing ...
2126 (isfloat_string): Remove.
2127 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2128 (read1): Do not accept +. and -. as integers; this
2129 appears to have been a coding error. Similarly, do not accept
2130 strings like +-1e0 as floating point numbers. Do not report
2131 overflow for integer overflows unless the base is not 10 which
2132 means we have no simple and reliable way to continue.
2133 Break out the floating-point parsing into a new
2134 function string_to_number, so that Fstring_to_number parses
2135 floating point numbers consistently with the Lisp reader.
2136 (digit_to_number): Move here from data.c. Make it static inline.
2137 (E_CHAR, EXP_INT): Remove, replacing with ...
2138 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2139 (string_to_number): New function, replacing isfloat_string.
2140 This function checks for valid syntax and produces the resulting
2141 Lisp float number too. Rework it so that string-to-number
2142 no longer mishandles examples like "1.0e+". Use strtoumax,
2143 so that overflow for non-base-10 numbers is reported only when
2144 there's no portable and simple way to convert to floating point.
2145
2146 * textprop.c (set_text_properties_1): Rewrite for clarity,
2147 and to avoid GCC warning about integer overflow.
2148
2149 * intervals.h (struct interval): Use EMACS_INT for members
2150 where EMACS_UINT might cause problems. See
2151 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2152 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2153 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2154 All uses changed.
2155 (offset_intervals): Tell GCC not to worry about length overflow
2156 when negating a negative length.
2157
2158 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2159 (overrun_check_free): Likewise.
2160
2161 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2162 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2163 word size.
2164
2165 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2166 (gnutls_make_error): Rename local to avoid shadowing.
2167 (gnutls_emacs_global_deinit): ifdef out; not used.
2168 (Fgnutls_boot): Use const for pointer to readonly storage.
2169 Comment out unused local. Fix pointer signedness problems.
2170
2171 * lread.c (openp): Don't stuff size_t into an 'int'.
2172 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2173 about possible signed overflow.
2174
2175 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2176 (GDK_KEY_g): Don't define if already defined.
2177 (xg_prepare_tooltip): Avoid pointer signedness problem.
2178 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2179
2180 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2181 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2182
2183 * xfns.c (Fx_window_property): Simplify a bit,
2184 to make a bit faster and to avoid GCC 4.6.0 warning.
2185 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2186
2187 * fns.c (internal_equal): Don't assume size_t fits in int.
2188
2189 * alloc.c (compact_small_strings): Tighten assertion a little.
2190
2191 Replace pEd with more-general pI, and fix some printf arg casts.
2192 * lisp.h (pI): New macro, generalizing old pEd macro to other
2193 conversion specifiers. For example, use "...%"pI"d..." rather
2194 than "...%"pEd"...".
2195 (pEd): Remove. All uses replaced with similar uses of pI.
2196 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2197 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2198 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2199 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2200 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2201 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2202 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2203 64-bit hosts.
2204 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2205 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2206 * print.c (safe_debug_print, print_object): Likewise.
2207 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2208 to int.
2209 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2210 avoiding the 0 flag, which is not portable.
2211 * process.c (Fmake_network_process): Use pI to avoid cast.
2212 * region-cache.c (pp_cache): Likewise.
2213 * xdisp.c (decode_mode_spec): Likewise.
2214 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2215 behavior on 64-bit hosts with printf arg.
2216 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2217 (x_stop_queuing_selection_requests): Likewise.
2218 (x_get_window_property): Don't truncate byte count to an 'int'
2219 when tracing.
2220
2221 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2222 here, since it parses constructs like leading '-' and spaces,
2223 which are not wanted; and it overflows with large numbers.
2224 Instead, simply match F[0-9]+, which is what is wanted anyway.
2225
2226 * alloc.c: Remove unportable assumptions about struct layout.
2227 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2228 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2229 (allocate_vectorlike, make_pure_vector): Use the new macros,
2230 plus offsetof, to remove unportable assumptions about struct layout.
2231 These assumptions hold on all porting targets that I know of, but
2232 they are not guaranteed, they're easy to remove, and removing them
2233 makes further changes easier.
2234
2235 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2236 This doesn't fix a bug but makes the code clearer.
2237 (string_overrun_cookie): Now const. Use initializers that
2238 don't formally overflow signed char, to avoid warnings.
2239 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2240 can cause Emacs to crash when string overrun checking is enabled.
2241 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2242 multiple of sizeof (EMACS_INT); it need not be, if
2243 alignof(EMACS_INT) < sizeof (EMACS_INT).
2244 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2245
2246 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2247
2248 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2249
2250 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2251
2252 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2253 supposed to be handshaking. (Bug#8556)
2254 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2255
2256 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2257
2258 * lisp.h (Qdebug): List symbol.
2259 * eval.c (Qdebug): Restore global linkage.
2260 * keyboard.c (debug-on-event): New variable.
2261 (handle_user_signal): Break into debugger when debug-on-event
2262 matches the current signal symbol.
2263
2264 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2265
2266 * alloc.c (check_sblock, check_string_bytes)
2267 (check_string_free_list): Convert to standard C.
2268
2269 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2270
2271 * w32.c (emacs_gnutls_push): Fix typo.
2272
2273 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2274
2275 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2276 "cast to pointer from integer of different size".
2277
2278 Improve doprnt and its use in verror. (Bug#8545)
2279 * doprnt.c (doprnt): Document the set of format control sequences
2280 supported by the function. Use SAFE_ALLOCA instead of always
2281 using `alloca'.
2282
2283 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2284 is one byte too soon. Don't use xrealloc; instead xfree and
2285 xmalloc anew.
2286
2287 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2288
2289 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2290 callbacks stage.
2291
2292 * gnutls.c: Renamed global_initialized to
2293 gnutls_global_initialized. Added internals for the
2294 :verify-hostname-error, :verify-error, and :verify-flags
2295 parameters of `gnutls-boot' and documented those parameters in the
2296 docstring. Start callback support.
2297 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2298 unless a fatal error occured. Call gnutls_alert_send_appropriate
2299 on error. Return error code.
2300 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2301 (emacs_gnutls_read): Likewise.
2302 (Fgnutls_boot): Return handshake error code.
2303 (emacs_gnutls_handle_error): New function.
2304 (wsaerror_to_errno): Likewise.
2305
2306 * w32.h (emacs_gnutls_pull): Add prototype.
2307 (emacs_gnutls_push): Likewise.
2308
2309 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2310 (emacs_gnutls_push): Likewise.
2311
2312 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2313
2314 * process.c (wait_reading_process_output): Check if GnuTLS
2315 buffered some data internally if no FDs are set for TLS
2316 connections.
2317
2318 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2319 (LIBS): Link to USER_LIBS.
2320 ($(BLD)/gnutls.$(0)): New target.
2321
2322 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2323
2324 * xdisp.c (handle_single_display_spec): Rename the
2325 display_replaced_before_p argument into display_replaced_p, to
2326 make it consistent with the commentary. Fix typos in the
2327 commentary.
2328
2329 * textprop.c (syms_of_textprop): Remove dead code.
2330 (copy_text_properties): Delete obsolete commentary about an
2331 interface that was deleted long ago. Fix typos in the description
2332 of arguments.
2333
2334 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2335 to changes in oldXMenu/XMenu.h from 2011-04-16.
2336 <menu_help_message, prev_menu_help_message>: Constify.
2337 (IT_menu_make_room): menu->help_text is now `const char **';
2338 adjust.
2339
2340 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2341 to changes in oldXMenu/XMenu.h from 2011-04-16.
2342 (struct XMenu): Declare `help_text' `const char **'.
2343
2344 * xfaces.c <Qunspecified>: Make extern again.
2345
2346 * syntax.c: Include sys/types.h before including regex.h, as
2347 required by Posix.
2348
2349 * doc.c (get_doc_string): Improve the format passed to `error'.
2350
2351 * doprnt.c (doprnt): Improve commentary.
2352
2353 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2354
2355 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2356 them with etags.
2357
2358 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2359 changes in globals.h immediately force recompilation.
2360 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2361 $(CURDIR)/s/ms-w32.h.
2362 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2363
2364 * character.c (Fchar_direction): Function deleted.
2365 (syms_of_character): Don't defsubr it.
2366 <char-direction-table>: Deleted.
2367
2368 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2369
2370 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2371 * doprnt.c: Include limits.h.
2372 (SIZE_MAX): New macro.
2373 (doprnt): Return a size_t value. 2nd arg is now size_t.
2374 Many local variables are now size_t instead of int or unsigned.
2375 Improve overflow protection. Support `l' modifier for integer
2376 conversions. Support %l conversion. Don't assume an EMACS_INT
2377 argument for integer conversions and for %c.
2378
2379 * lisp.h (doprnt): Restore prototype.
2380
2381 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2382 $(SRC)/character.h.
2383
2384 * Makefile.in (base_obj): Add back doprnt.o.
2385
2386 * deps.mk (doprnt.o): Add back prerequisites.
2387 (callint.o): Depend on character.h.
2388
2389 * eval.c (internal_lisp_condition_case): Include the handler
2390 representation in the error message.
2391 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2392 when breaking from the loop.
2393
2394 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2395
2396 * callint.c (Fcall_interactively): When displaying error message
2397 about invalid control letter, pass the character's codepoint, not
2398 a pointer to its multibyte form. Improve display of the character
2399 in octal and display also its hex code.
2400
2401 * character.c (char_string): Use %x to display the (unsigned)
2402 codepoint of an invalid character, to avoid displaying a bogus
2403 negative value.
2404
2405 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2406 `error', not SYMBOL_NAME itself.
2407
2408 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2409 character arguments to `error'.
2410
2411 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2412 to `error' in error message about FINAL_CHAR argument. Make sure
2413 FINAL_CHAR is a character, and use %c when it is passed as
2414 argument to `error'.
2415
2416 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2417
2418 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2419
2420 * w32.c: Include <time.h>.
2421 (sys_localtime): New function.
2422
2423 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2424
2425 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2426
2427 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2428
2429 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2430
2431 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2432 zombies (Bug#8467).
2433
2434 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2435
2436 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2437 gl_state.e_property when gl_state.object is Qt.
2438
2439 * insdel.c (make_gap_larger): Remove limitation of buffer size
2440 to <= INT_MAX.
2441
2442 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2443
2444 * xdisp.c (lookup_glyphless_char_display)
2445 (produce_glyphless_glyph): Handle cons cell entry in
2446 glyphless-char-display.
2447 (Vglyphless_char_display): Document it.
2448
2449 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2450 glyphless-char-display.
2451
2452 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2453
2454 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2455
2456 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2457
2458 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2459 definition for no-X builds.
2460
2461 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2462
2463 Static checks with GCC 4.6.0 and non-default toolkits.
2464
2465 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2466
2467 * process.c (keyboard_bit_set): Define only if SIGIO.
2468 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2469 (send_process): Repair possible setjmp clobbering.
2470
2471 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2472
2473 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2474
2475 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2476
2477 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2478 Define only if needed.
2479
2480 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2481 by pacifying GCC about it. Maybe it's time to retire it?
2482 * xfaces.c (USG, __TIMEVAL__): Likewise.
2483
2484 * dispextern.h (struct redisplay_interface): Rename param
2485 to avoid shadowing.
2486 * termhooks.h (struct terminal): Likewise.
2487 * xterm.c (xembed_send_message): Likewise.
2488
2489 * insdel.c (make_gap_smaller): Define only if
2490 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2491
2492 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2493 it.
2494
2495 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2496 so that we aren't warned about unused symbols.
2497
2498 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2499
2500 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2501
2502 * xfns.c (x_real_positions): Mark locals as initialized.
2503
2504 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2505
2506 * xterm.c: Fix problems found by static analysis with other toolkits.
2507 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2508 (x_dispatch_event): Declare static if USE_GTK, and
2509 define if USE_GTK || USE_X_TOOLKIT.
2510 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2511 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2512 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2513 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2514
2515 * xmenu.c (menu_help_callback): Pointer type fixes.
2516 Use const pointers when pointing at readonly data. Avoid pointer
2517 signedness clashes.
2518 (FALSE): Remove unused macro.
2519 (update_frame_menubar): Remove unused decl.
2520
2521 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2522
2523 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2524 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2525 (single_menu_item): Rename local to avoid shadowing.
2526
2527 * keyboard.c (make_lispy_event): Remove unused local var.
2528
2529 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2530 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2531
2532 * bitmaps: Change bitmaps from unsigned char back to the X11
2533 compatible char. Avoid the old compiler warnings about
2534 out-of-range initializers by using, for example, '\xab' rather
2535 than 0xab.
2536
2537 * xgselect.c (xgselect_initialize): Check vs interface
2538 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2539
2540 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2541
2542 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2543 to read-only memory.
2544
2545 * fns.c (vector): Remove; this old hack is no longer needed.
2546
2547 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2548 Remove unused var.
2549 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2550
2551 * xrdb.c (x_load_resources): Omit unused local.
2552
2553 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2554 (x_window): Rename locals to avoid shadowing.
2555 (USG): Use the kludged USG macro, to pacify gcc.
2556
2557 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2558 (x_term_init): Remove local to avoid shadowing.
2559
2560 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2561
2562 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2563 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2564
2565 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2566
2567 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2568
2569 Fix regex.c, syntax.c and friends for buffers > 2GB.
2570 * syntax.h (struct gl_state_s): Declare character position members
2571 EMACS_INT.
2572
2573 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2574
2575 * textprop.c (verify_interval_modification, interval_of):
2576 Declare arguments EMACS_INT.
2577
2578 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2579 EMACS_INT.
2580
2581 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2582
2583 * indent.c (Fvertical_motion): Local variable it_start is now
2584 EMACS_INT.
2585
2586 * regex.c (re_match, re_match_2, re_match_2_internal)
2587 (bcmp_translate, regcomp, regexec, print_double_string)
2588 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2589 (re_compile_pattern, re_exec): Declare arguments and local
2590 variables `size_t' and `ssize_t' and return values `regoff_t', as
2591 appropriate.
2592 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2593 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2594 <compile_stack_type>: `size' and `avail' are now `size_t'.
2595
2596 * regex.h <regoff_t>: Use ssize_t, not int.
2597 (re_search, re_search_2, re_match, re_match_2): Arguments that
2598 specify buffer/string position and length are now ssize_t and
2599 size_t. Return type is regoff_t.
2600
2601 2011-04-16 Ben Key <bkey76@gmail.com>
2602
2603 * nsfont.m: Fixed bugs in ns_get_family and
2604 ns_descriptor_to_entity that were caused by using free to
2605 deallocate memory blocks that were allocated by xmalloc (via
2606 xstrdup). This caused Emacs to crash when compiled with
2607 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2608 --enable-checking=xmallocoverrun). xfree is now used to
2609 deallocate these memory blocks.
2610
2611 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2614
2615 emacs_write: Accept and return EMACS_INT for sizes.
2616 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2617 et seq.
2618 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2619 Accept and return EMACS_INT.
2620 (emacs_gnutls_write): Return the number of bytes written on
2621 partial writes.
2622 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2623 (emacs_read, emacs_write): Remove check for negative size, as the
2624 Emacs source code has been audited now.
2625 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2626 (emacs_read, emacs_write): Use it.
2627 * process.c (send_process): Adjust to the new signatures of
2628 emacs_write and emacs_gnutls_write. Do not attempt to store
2629 a byte offset into an 'int'; it might overflow.
2630 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2631
2632 * sound.c: Don't assume sizes fit in 'int'.
2633 (struct sound_device.period_size, alsa_period_size):
2634 Return EMACS_INT, not int.
2635 (struct sound_device.write, vox_write, alsa_write):
2636 Accept EMACS_INT, not int.
2637 (wav_play, au_play): Use EMACS_INT to store sizes and to
2638 record read return values.
2639
2640 2011-04-15 Ben Key <bkey76@gmail.com>
2641
2642 * keyboard.c (Qundefined): Don't declare static since it is used
2643 in nsfns.m.
2644 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2645 static since they are used in nsfont.m.
2646
2647 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2648
2649 * process.c (Qprocessp): Don't declare static.
2650 * lisp.h (Qprocessp): Declare again.
2651
2652 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2653
2654 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2655
2656 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 Improve C-level modularity by making more things 'static'.
2659
2660 Don't publish debugger-only interfaces to other modules.
2661 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2662 (verify_bytepos, count_markers): Move decls to the only modules
2663 that need them.
2664 * region-cache.h (pp_cache): Likewise.
2665 * window.h (check_all_windows): Likewise.
2666 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2667
2668 * sysdep.c (croak): Now static, if
2669 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2670 * syssignal.h (croak): Declare only if not static.
2671
2672 * alloc.c (refill_memory_reserve): Now static if
2673 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2674 * lisp.h (refill_memory_reserve): Declare only if not static.
2675
2676 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2677 Define only if USE_LUCID.
2678
2679 * xrdb.c (x_customization_string, x_rm_string): Now static.
2680
2681 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2682 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2683
2684 * xdisp.c (draw_row_with_mouse_face): Now static.
2685 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2686
2687 * window.h (check_all_windows): Mark externally visible.
2688
2689 * window.c (window_deletion_count): Now static.
2690
2691 * undo.c: Make symbols static if they're not exported.
2692 (last_undo_buffer, last_boundary_position, pending_boundary):
2693 Now static.
2694
2695 * textprop.c (interval_insert_behind_hooks): Now static.
2696 (interval_insert_in_front_hooks): Likewise.
2697
2698 * term.c: Make symbols static if they're not exported.
2699 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2700 (max_frame_lines, tty_set_terminal_modes):
2701 (tty_reset_terminal_modes, tty_turn_off_highlight):
2702 (get_tty_terminal): Now static.
2703 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2704 * termhooks.h (term_mouse_moveto): Do not declare if
2705 HAVE_WINDOW_SYSTEM.
2706 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2707 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2708
2709 * sysdep.c: Make symbols static if they're not exported.
2710 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2711 Now static.
2712 (sigprocmask_set, full_mask): Remove; unused.
2713 (wait_debugging): Mark as visible.
2714 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2715 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2716
2717 * syntax.c (syntax_temp): Define only if !__GNUC__.
2718
2719 * sound.c (current_sound_device, current_sound): Now static.
2720
2721 * search.c (searchbufs, searchbuf_head): Now static.
2722
2723 * scroll.c (scroll_cost): Remove; unused.
2724 * dispextern.h (scroll_cost): Remove decl.
2725
2726 * region-cache.h (pp_cache): Mark as externally visible.
2727
2728 * process.c: Make symbols static if they're not exported.
2729 (process_tick, update_tick, create_process, chan_process):
2730 (Vprocess_alist, proc_buffered_char, datagram_access):
2731 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2732 (deactivate_process): Mark defn as static, as well as decl.
2733 * lisp.h (create_process): Remove decl.
2734 * process.h (chan_process, Vprocess_alist): Remove decls.
2735
2736 * print.c: Make symbols static if they're not exported.
2737 (print_depth, new_backquote_output, being_printed, print_buffer):
2738 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2739 (print_interval, print_number_index, initial_stderr_stream):
2740 Now static.
2741 * lisp.h (Fprinc): Remove decl.
2742 (debug_output_compilation_hack): Mark as externally visible.
2743
2744 * sysdep.c (croak): Move decl from here to syssignal.h.
2745 * syssignal.h (croak): Put it here, so the API can be checked when
2746 'croak' is called from dissociate_if_controlling_tty.
2747
2748 * minibuf.c: Make symbols static if they're not exported.
2749 (minibuf_save_list, choose_minibuf_frame): Now static.
2750 * lisp.h (choose_minibuf_frame): Remove decl.
2751
2752 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2753
2754 * lread.c: Make symbols static if they're not exported.
2755 (read_objects, initial_obarray, oblookup_last_bucket_number):
2756 Now static.
2757 (make_symbol): Remove; unused.
2758 * lisp.h (initial_obarray, make_symbol): Remove decls.
2759
2760 * keyboard.c: Make symbols static if they're not exported.
2761 (single_kboard, recent_keys_index, total_keys, recent_keys):
2762 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2763 (this_single_command_key_start, echoing, last_auto_save):
2764 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2765 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2766 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2767 (Vlispy_mouse_stem, double_click_count):
2768 Now static.
2769 (force_auto_save_soon): Define only if SIGDANGER.
2770 (ignore_mouse_drag_p): Now static if
2771 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2772 (print_help): Remove; unused.
2773 (stop_character, last_timer_event): Mark as externally visible.
2774 * keyboard.h (ignore_mouse_drag_p): Declare only if
2775 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2776 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2777 * lisp.h (echoing): Remove decl.
2778 (force_auto_save_soon): Declare only if SIGDANGER.
2779 * xdisp.c (redisplay_window): Simplify code, to make it more
2780 obvious that ignore_mouse_drag_p is not accessed if !defined
2781 USE_GTK && !defined HAVE_NS.
2782
2783 * intervals.c: Make symbols static if they're not exported.
2784 (merge_properties_sticky, merge_interval_right, delete_interval):
2785 Now static.
2786 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2787
2788 * insdel.c: Make symbols static if they're not exported.
2789 However, leave prepare_to_modify_buffer alone. It's never
2790 called from outside this function, but that appears to be a bug.
2791 (combine_after_change_list, combine_after_change_buffer):
2792 (adjust_after_replace, signal_before_change): Now static.
2793 (adjust_after_replace_noundo): Remove; unused.
2794 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2795 (signal_before_change): Remove decls.
2796
2797 * indent.c (val_compute_motion, val_vmotion): Now static.
2798
2799 * image.c: Make symbols static if they're not exported.
2800 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2801 if USE_GTK.
2802 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2803 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2804
2805 * fringe.c (standard_bitmaps): Now static.
2806 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2807
2808 * frame.c: Make symbols static if they're not exported.
2809 (x_report_frame_params, make_terminal_frame): Now static.
2810 (get_frame_param): Now static, unless HAVE_NS.
2811 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2812 (x_get_resource_string): Remove; not used.
2813 * frame.h (make_terminal_frame, x_report_frame_params):
2814 (x_get_resource_string); Remove decls.
2815 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2816 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2817
2818 * font.c, fontset.c: Make symbols static if they're not exported.
2819 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2820 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2821 * font.c (font_close_object): Now static.
2822 * font.h (font_close_object): Remove.
2823 * fontset.c (FONTSET_OBJLIST): Remove.
2824 (free_realized_fontset) #if-0 the body, which does nothing.
2825 (face_suitable_for_char_p): #if-0, as it's never called.
2826 * fontset.h (face_suitable_for_char_p): Remove decl.
2827 * xfaces.c (face_at_string_position):
2828 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2829 since 0 is always ASCII.
2830
2831 * fns.c (weak_hash_tables): Now static.
2832
2833 * fileio.c: Make symbols static if they're not exported.
2834 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2835 (Vwrite_region_annotation_buffers): Now static.
2836
2837 * eval.c: Make symbols static if they're not exported.
2838 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2839 * lisp.h (backtrace_list): Remove decl.
2840
2841 * emacs.c: Make symbols static if they're not exported.
2842 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2843 (fatal_error_code, fatal_error_signal_hook, standard_args):
2844 Now static.
2845 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2846 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2847 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2848 * lisp.h (fatal_error_signal_hook): Remove decl.
2849 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2850
2851 * editfns.c: Move a (normally-unused) function to its only use.
2852 * editfns.c, lisp.h (get_operating_system_release): Remove.
2853 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2854 worth the hassle of breaking this out.
2855
2856 * xterm.c: Make symbols static if they're not exported.
2857 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2858 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2859 (x_destroy_window, x_delete_display):
2860 Now static.
2861 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2862 (x_mouse_leave): Remove; unused.
2863 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2864 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2865 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2866 Remove decls.
2867 (x_mouse_leave): Declare only if WINDOWSNT.
2868 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2869 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2870 USE_X_TOOLKIT.
2871
2872 * ftxfont.c: Make symbols static if they're not exported.
2873 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2874 HAVE_FREETYPE.
2875 * font.h (ftxfont_driver): Likewise.
2876
2877 * xfns.c: Make symbols static if they're not exported.
2878 (x_last_font_name, x_display_info_for_name):
2879 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2880 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2881 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2882 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2883 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2884 (last_show_tip_args): Now static.
2885 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2886 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2887 (x_screen_planes): Remove; unused.
2888 * dispextern.h (x_screen_planes): Remove decl.
2889
2890 * dispnew.c: Make symbols static if they're not exported.
2891 * dispextern.h (redraw_garbaged_frames, scrolling):
2892 (increment_row_positions): Remove.
2893 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2894 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2895 Now static.
2896 (redraw_garbaged_frames): Remove; unused.
2897
2898 * xfaces.c: Make symbols static if they're not exported.
2899 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2900 Remove decls.
2901 * xterm.h (defined_color): Remove decls.
2902 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2903 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2904 (menu_face_changed_default, defined_color, free_realized_face):
2905 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2906 (ascii_face_of_lisp_face): Remove; unused.
2907
2908 * xdisp.c: Make symbols static if they're not exported.
2909 * dispextern.h (scratch_glyph_row, window_box_edges):
2910 (glyph_to_pixel_coords, set_cursor_from_row):
2911 (get_next_display_element, set_iterator_to_next):
2912 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2913 (show_mouse_face): Remove decls
2914 * frame.h (message_buf_print): Likewise.
2915 * lisp.h (pop_message, set_message, check_point_in_composition):
2916 Likewise.
2917 * xterm.h (set_vertical_scroll_bar): Likewise.
2918 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2919 (message_buf_print, scratch_glyph_row, displayed_buffer):
2920 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2921 (get_next_display_element, show_mouse_face, window_box_edges):
2922 (frame_to_window_pixel_xy, check_point_in_composition):
2923 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2924 (glyph_to_pixel_coords): Remove; unused.
2925
2926 * dired.c (file_name_completion): Now static.
2927
2928 * dbusbind.c (xd_in_read_queued_messages): Now static.
2929
2930 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2931 * data.c (circular_list_error): Remove.
2932
2933 * commands.h (last_point_position, last_point_position_buffer):
2934 (last_point_position_window): Remove decls.
2935 * keyboard.c: Make these variables static.
2936
2937 * coding.h (coding, code_convert_region, encode_coding_gap):
2938 Remove decls.
2939 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2940 (iso_code_class, detect_coding, code_convert_region): Now static.
2941 (encode_coding_gap): Remove; unused.
2942
2943 * chartab.c (chartab_chars, chartab_bits): Now static.
2944
2945 * charset.h (charset_iso_8859_1): Remove decl.
2946 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2947 Now static.
2948
2949 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2950 * ccl.c (Vccl_program_table): Now static.
2951 (check_ccl_update): Remove; unused.
2952
2953 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2954 * category.h: ... from here.
2955 * category.c (check_category_table, set_category_set): Now static.
2956
2957 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2958 * lisp.h: Remove these decls.
2959
2960 * buffer.c (buffer_count): Remove unused var.
2961
2962 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2963 so that it's not optimized away.
2964 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2965 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2966 exported only to the debugger.
2967
2968 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2969 * atimer.h (run_all_atimers): Remove; not exported.
2970
2971 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2972 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2973 was inaccessible from Lisp.
2974 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2975 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2976
2977 alloc.c: Import and export fewer symbols, and remove unused items.
2978 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2979 is defined.
2980 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2981 it's not optimized away by whole-program optimization.
2982 (message_enable_multibyte, free_misc): Remove.
2983 (catchlist, handlerlist, mark_backtrace):
2984 Declare only if BYTE_MARK_STACK.
2985 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2986 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2987 (message_enable_multibyte): Remove decl.
2988 (free_misc, interval_free_list, float_block, float_block_index):
2989 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2990 (cons_free_list, last_marked_index):
2991 Now static.
2992 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2993 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2994 (mark_backtrace): Define only if BYTE_MARK_STACK.
2995 * xdisp.c (message_enable_multibyte): Now static.
2996
2997 Declare Lisp_Object Q* variables to be 'static' if not exported.
2998 This makes it easier for human readers (and static analyzers)
2999 to see whether these variables are used from other modules.
3000 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3001 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3002 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3003 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3004 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3005 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3006 * xmenu.c, xselect.c:
3007 Declare Q* vars static if they are not used in other modules.
3008 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3009 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3010 Remove decls of unexported vars.
3011 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3012
3013 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3014
3015 Make Emacs functions such as Fatom 'static' by default.
3016 This makes it easier for human readers (and static analyzers)
3017 to see whether these functions can be called from other modules.
3018 DEFUN now defines a static function. To make the function external
3019 so that it can be used in other C modules, use the new macro DEFUE.
3020 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3021 (Finit_image_library):
3022 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3023 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3024 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3025 Remove decls, since these functions are now static.
3026 (Funintern, Fget_internal_run_time): New decls, since these functions
3027 were already external.
3028
3029 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3030 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3031 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3032 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3033 * keyboard.c, keymap.c, lread.c:
3034 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3035 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3036 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3037 Mark functions with DEFUE instead of DEFUN,
3038 if they are used in other modules.
3039 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3040 decls for now-static functions.
3041 * buffer.h (Fdelete_overlay): Remove decl.
3042 * callproc.c (Fgetenv_internal): Mark as internal.
3043 * composite.c (Fremove_list_of_text_properties): Remove decl.
3044 (Fcomposition_get_gstring): New forward static decl.
3045 * composite.h (Fcomposite_get_gstring): Remove decl.
3046 * dired.c (Ffile_attributes): New forward static decl.
3047 * doc.c (Fdocumntation_property): New forward static decl.
3048 * eval.c (Ffetch_bytecode): New forward static decl.
3049 (Funintern): Remove extern decl; now in .h file where it belongs.
3050 * fileio.c (Fmake_symbolic_link): New forward static decl.
3051 * image.c (Finit_image_library): New forward static decl.
3052 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3053 * intervals.h (Fprevious_property_change):
3054 (Fremove_list_of_text_properties): Remove decls.
3055 * keyboard.c (Fthis_command_keys): Remove decl.
3056 (Fcommand_execute): New forward static decl.
3057 * keymap.c (Flookup_key): New forward static decl.
3058 (Fcopy_keymap): Now static.
3059 * keymap.h (Flookup_key): Remove decl.
3060 * process.c (Fget_process): New forward static decl.
3061 (Fprocess_datagram_address): Mark as internal.
3062 * syntax.c (Fsyntax_table_p): New forward static decl.
3063 (skip_chars): Remove duplicate decl.
3064 * textprop.c (Fprevious_property_change): New forward static decl.
3065 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3066 Now internal.
3067 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3068 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3069
3070 * editfns.c (Fformat): Remove unreachable code.
3071
3072 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3073
3074 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3075 change. (Bug#8496)
3076
3077 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3078
3079 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3080 when at ZV. (Bug#8487)
3081
3082 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3083
3084 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3085 (Bug#8437)
3086 * keyboard.c (parse_tool_bar_item): Likewise.
3087 * sound.c (sound_cleanup, alsa_close): Likewise.
3088 * termcap.c (tgetent): Likewise.
3089 * xfns.c (x_default_font_parameter): Likewise.
3090 * xsettings.c (read_and_apply_settings): Likewise.
3091
3092 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3093 (overrun_check_free): Protoize.
3094
3095 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3096
3097 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3098 since callers should never pass a negative size.
3099 Change the signature to match that of plain 'read' and 'write'; see
3100 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3101 * lisp.h: Update prototypes of emacs_write and emacs_read.
3102
3103 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3104
3105 * xdisp.c (redisplay_window): Don't try to determine the character
3106 position of the scroll margin if the window start point w->startp
3107 is outside the buffer's accessible region. (Bug#8468)
3108
3109 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3110
3111 Fix write-region and its subroutines for buffers > 2GB.
3112 * fileio.c (a_write, e_write): Modify declaration of arguments and
3113 local variables to support buffers larger than 2GB.
3114 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3115
3116 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3117 argument, local variables, and return value.
3118
3119 * lisp.h: Update prototypes of emacs_write and emacs_read.
3120
3121 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3122
3123 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3124
3125 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3126
3127 Fix more problems found by GCC 4.6.0's static checks.
3128
3129 * xdisp.c (vmessage): Use a better test for character truncation.
3130
3131 * charset.c (load_charset_map): <, not <=, for optimization,
3132 and to avoid potential problems with integer overflow.
3133 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3134 * casetab.c (set_identity, shuffle): Likewise.
3135 * editfns.c (Fformat): Likewise.
3136 * syntax.c (skip_chars): Likewise.
3137
3138 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3139 This also lets GCC 4.6.0 generate slightly better loop code.
3140
3141 * callint.c (Fcall_interactively): <, not <=, for optimization.
3142 (Fcall_interactively): Count the number of arguments produced,
3143 not the number of arguments given. This is simpler and lets GCC
3144 4.6.0 generate slightly better code.
3145
3146 * ftfont.c: Distingish more carefully between FcChar8 and char.
3147 The previous code passed unsigned char * to a functions like
3148 strlen and xstrcasecmp that expect char *, which does not
3149 conform to the C standard.
3150 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3151 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3152 char * when the C standard requires it.
3153
3154 * keyboard.c (read_char): Remove unused var.
3155
3156 * eval.c: Port to Windows vsnprintf (Bug#8435).
3157 Include <limits.h>.
3158 (SIZE_MAX): Define if the headers do not.
3159 (verror): Do not give up if vsnprintf returns a negative count.
3160 Instead, grow the buffer. This ports to Windows vsnprintf, which
3161 does not conform to C99. Problem reported by Eli Zaretskii.
3162 Also, simplify the allocation scheme, by avoiding the need for
3163 calling realloc, and removing the ALLOCATED variable.
3164
3165 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3166
3167 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3168 But keep the doprint source code for now, as we might revamp it
3169 and use it again (Bug#8435).
3170 * lisp.h (doprnt): Remove.
3171 * Makefile.in (base_obj): Remove doprnt.o.
3172 * deps.mk (doprnt.o): Remove.
3173
3174 error: Print 32- and 64-bit integers portably (Bug#8435).
3175 Without this change, on typical 64-bit hosts error ("...%d...", N)
3176 was used to print both 32- and 64-bit integers N, which relied on
3177 undefined behavior.
3178 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3179 New macro.
3180 * lisp.h (error, verror): Mark as printf-like functions.
3181 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3182 Report overflow in size calculations when allocating printf buffer.
3183 Do not truncate output string at its first null byte.
3184 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3185 Truncate the output at a character boundary, since vsnprintf does not
3186 do that.
3187 * charset.c (check_iso_charset_parameter): Convert internal
3188 character to string before calling 'error', since %c now has the
3189 printf meaning.
3190 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3191 overflow when computing char to be passed to 'error'. Do not
3192 pass Lisp_Object to 'error'; pass the integer instead.
3193 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3194 formatted with plain %d.
3195
3196 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3197
3198 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3199
3200 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3201
3202 * xterm.c (x_catch_errors): Remove duplicate declaration.
3203
3204 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3205
3206 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3207
3208 2011-04-10 Jim Meyering <meyering@redhat.com>
3209
3210 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3211 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3212 return ssize_t not "int", and use size_t as the buffer length.
3213 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3214 * gnutls.h: Update declarations.
3215 * process.c (read_process_output): Use ssize_t, to match.
3216 (send_process): Likewise.
3217
3218 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3219
3220 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3221
3222 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3223
3224 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3225 Use unsigned char, to match FcChar8 type definition.
3226
3227 * xterm.c (handle_one_xevent):
3228 * xmenu.c (create_and_show_popup_menu):
3229 * xselect.c (x_decline_selection_request)
3230 (x_reply_selection_request): Avoid type-punned deref of X events.
3231
3232 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3233
3234 Fix some uses of `int' instead of EMACS_INT.
3235 * search.c (string_match_1, fast_string_match)
3236 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3237 (scan_buffer, find_next_newline_no_quit)
3238 (find_before_next_newline, search_command, Freplace_match)
3239 (Fmatch_data): Make some `int' variables be EMACS_INT.
3240
3241 * xdisp.c (display_count_lines): 3rd argument and return value now
3242 EMACS_INT. All callers changed.
3243 (pint2hrstr): Last argument is now EMACS_INT.
3244
3245 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3246 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3247 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3248 (decode_coding_utf_16, decode_coding_emacs_mule)
3249 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3250 (decode_coding_ccl, decode_coding_charset)
3251 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3252 (decode_coding_iso_2022, decode_coding_emacs_mule)
3253 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3254 <char_offset, last_offset>: Declare EMACS_INT.
3255 (encode_coding_utf_8, encode_coding_utf_16)
3256 (encode_coding_emacs_mule, encode_invocation_designation)
3257 (encode_designation_at_bol, encode_coding_iso_2022)
3258 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3259 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3260 Declare EMACS_INT.
3261 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3262 (encode_invocation_designation): Last argument P_NCHARS is now
3263 EMACS_INT.
3264 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3265 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3266
3267 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3268 All users changed.
3269
3270 * ccl.c (Fccl_execute_on_string): Declare some variables
3271 EMACS_INT.
3272
3273 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3274
3275 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3276
3277 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3278
3279 * process.c (Fformat_network_address): Doc fix.
3280
3281 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3282
3283 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3284
3285 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3286
3287 * keyboard.c (read_char): Call Lisp function help-form-show,
3288 instead of using internal_with_output_to_temp_buffer.
3289 (Qhelp_form_show): New var.
3290 (syms_of_keyboard): Use DEFSYM macro.
3291
3292 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3293
3294 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3295
3296 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3297
3298 * process.c (Flist_processes): Remove to Lisp.
3299 (list_processes_1): Delete.
3300
3301 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3302
3303 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3304
3305 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3306
3307 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3308
3309 Fix more problems found by GCC 4.6.0's static checks.
3310
3311 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3312
3313 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3314
3315 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3316
3317 * xdisp.c (vmessage): Mark as a printf-like function.
3318
3319 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3320
3321 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3322
3323 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3324 printf-like functions.
3325 (tiff_load): Add casts to remove these marks before passing them
3326 to system-supplied API.
3327
3328 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3329
3330 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3331 This avoids several warnings with gcc -Wstrict-overflow.
3332 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3333 directly, rather than having caller test rule sign. This avoids
3334 some unnecessary tests.
3335 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3336 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3337 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3338
3339 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3340 (xfont_open): Avoid unnecessary tests.
3341
3342 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3343
3344 * composite.h, composite.c (composition_gstring_put_cache):
3345 Use EMACS_INT, not int, for length.
3346
3347 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3348 breaking out part of COMPOSITION_DECODE_RULE.
3349 (COMPOSITION_DECODE_RULE): Use it.
3350 * composite.c (get_composition_id): Remove unused local vars,
3351 by using the new macro.
3352
3353 * textprop.c (set_text_properties_1): Change while to do-while,
3354 since the condition is always true at first.
3355
3356 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3357 (interval_deletion_adjustment): Return unsigned value.
3358 All uses changed.
3359
3360 * process.c (list_processes_1, create_pty, read_process_output):
3361 (exec_sentinel): Remove vars that were set but not used.
3362 (create_pty): Remove unnecessary "volatile"s.
3363 (Fnetwork_interface_info): Avoid possibility of int overflow.
3364 (read_process_output): Do adaptive read buffering even if carryover.
3365 (read_process_output): Simplify nbytes computation if buffered.
3366
3367 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3368
3369 * syntax.c (scan_words): Remove var that was set but not used.
3370 (update_syntax_table): Use unsigned instead of int.
3371
3372 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3373 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3374 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3375
3376 * print.c (print_error_message): Avoid int overflow.
3377
3378 * font.c (font_list_entities): Redo for clarity,
3379 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3380
3381 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3382 (font_score): Avoid potential overflow in diff calculation.
3383
3384 * fns.c (substring_both): Remove var that is set but not used.
3385 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3386
3387 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3388
3389 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3390 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3391 can always succeed if overflow has undefined behavior.
3392
3393 * search.c (boyer_moore, wordify): Remove vars set but not used.
3394 (wordify): Omit three unnecessary tests.
3395
3396 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3397 All callers changed. This avoids the need for an unused var.
3398
3399 * casefiddle.c (casify_region): Remove var that is set but not used.
3400
3401 * dired.c (file_name_completion): Remove var that is set but not used.
3402
3403 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3404
3405 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3406 (Finsert_file_contents): Remove unnecessary code checking fd.
3407
3408 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3409 Check for integer overflow on size calculations.
3410
3411 * buffer.c (Fprevious_overlay_change): Remove var that is set
3412 but not used.
3413
3414 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3415 Remove vars that are set but not used.
3416 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3417 (timer_check_2): Mark vars as initialized.
3418
3419 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3420
3421 * image.c (lookup_image): Remove var that is set but not used.
3422 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3423
3424 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3425 that are set but not used.
3426
3427 * xfns.c (make_invisible_cursor): Don't return garbage
3428 if XCreateBitmapFromData fails (Bug#8410).
3429
3430 * xselect.c (x_get_local_selection, x_handle_property_notify):
3431 Remove vars that are set but not used.
3432
3433 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3434 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3435
3436 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3437 Remove var that is set but not used.
3438 (scroll_bar_windows_size): Now size_t, not int.
3439 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3440 Check for overflow.
3441
3442 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3443 (map_tty_color) [!defined MSDOS]: Likewise.
3444
3445 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3446
3447 * coding.c: Remove vars that are set but not used.
3448 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3449 All callers changed.
3450 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3451 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3452 (decode_coding_charset): Remove vars that are set but not used.
3453
3454 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3455 that is set but not used.
3456
3457 * print.c (print_object): Remove var that is set but not used.
3458
3459 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3460 The gnulib version avoids calling malloc in the usual case,
3461 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3462 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3463 * filelock.c (current_lock_owner): Likewise.
3464 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3465 * sysdep.c: Include allocator.h, careadlinkat.h.
3466 (emacs_no_realloc_allocator): New static constant.
3467 (emacs_readlink): New function.
3468 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3469 ../lib/careadlinkat.h.
3470
3471 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3472
3473 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3474 first non-nil return value).
3475
3476 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3477
3478 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3479 if not defined (Bug#8403).
3480
3481 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3482
3483 * xdisp.c (display_count_lines): Remove parameter `start',
3484 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3485 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3486 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3487 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3488 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3489 and thereabouts. All callers changed.
3490 (get_per_char_metric): Remove parameter `f', unused since
3491 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3492
3493 2011-04-02 Jim Meyering <meyering@redhat.com>
3494
3495 do not dereference NULL upon failed strdup
3496 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3497 (ns_get_family): Likewise.
3498
3499 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3500
3501 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3502
3503 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3504
3505 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3506 later (Bug#8403).
3507
3508 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3509
3510 Add lexical binding.
3511
3512 * window.c (Ftemp_output_buffer_show): New fun.
3513 (Fsave_window_excursion):
3514 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3515
3516 * lread.c (lisp_file_lexically_bound_p): New function.
3517 (Fload): Bind Qlexical_binding.
3518 (readevalloop): Remove `evalfun' arg.
3519 Bind Qinternal_interpreter_environment.
3520 (Feval_buffer): Bind Qlexical_binding.
3521 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3522 Mark as dynamic.
3523 (syms_of_lread): Declare `lexical-binding'.
3524
3525 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3526
3527 * keyboard.c (eval_dyn): New fun.
3528 (menu_item_eval_property): Use it.
3529
3530 * image.c (parse_image_spec): Use Ffunctionp.
3531
3532 * fns.c (concat, mapcar1): Accept byte-code-functions.
3533
3534 * eval.c (Fsetq): Handle lexical vars.
3535 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3536 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3537 (FletX, Flet): Obey lexical binding.
3538 (Fcommandp): Handle closures.
3539 (Feval): New `lexical' arg.
3540 (eval_sub): New function extracted from Feval. Use it almost
3541 everywhere where Feval was used. Look up vars in lexical env.
3542 Handle closures.
3543 (Ffunctionp): Move from subr.el.
3544 (Ffuncall): Handle closures.
3545 (apply_lambda): Remove `eval_flags'.
3546 (funcall_lambda): Handle closures and new byte-code-functions.
3547 (Fspecial_variable_p): New function.
3548 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3549 but without exporting it to Lisp.
3550
3551 * doc.c (Fdocumentation, store_function_docstring):
3552 * data.c (Finteractive_form): Handle closures.
3553
3554 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3555 interactive spec.
3556
3557 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3558 New byte-codes.
3559 (exec_byte_code): New function extracted from Fbyte_code to handle new
3560 calling convention for byte-code-functions. Add new byte-codes.
3561
3562 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3563
3564 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3565
3566 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3567
3568 * xdisp.c (redisplay_internal): Fix prototype.
3569
3570 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3571
3572 * xdisp.c (SCROLL_LIMIT): New macro.
3573 (try_scrolling): Use it when setting scroll_limit.
3574 Limit scrolling to 100 screen lines.
3575 (redisplay_window): Even when falling back on "recentering",
3576 position point in the window according to scroll-conservatively,
3577 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3578
3579 (try_scrolling): When point is above the window, allow searching
3580 as far as scroll_max, or one screenful, to compute vertical
3581 distance from PT to the scroll margin position. This prevents
3582 try_scrolling from unnecessarily failing when
3583 scroll-conservatively is set to a value slightly larger than the
3584 window height. Clean up the case of PT below the margin at bottom
3585 of window: scroll_max can no longer be INT_MAX. When aggressive
3586 scrolling is in use, don't let point enter the opposite scroll
3587 margin as result of the scroll.
3588 (syms_of_xdisp) <scroll-conservatively>: Document the
3589 threshold of 100 lines for never-recentering scrolling.
3590
3591 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3592
3593 * dispextern.h (move_it_by_lines):
3594 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3595 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3596 (message_log_check_duplicate): Remove parameters `prev_bol' and
3597 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3598 (redisplay_internal): Remove parameter `preserve_echo_area',
3599 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3600
3601 * indent.c (Fvertical_motion):
3602 * window.c (window_scroll_pixel_based, Frecenter):
3603 Don't pass `need_y_p' to `move_it_by_lines'.
3604
3605 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3606
3607 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3608 steal a few bits to be more compact.
3609 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3610 Remove unneeded casts.
3611
3612 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3613
3614 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3615
3616 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3617 binding" message (bug#7967).
3618
3619 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3620
3621 Fix more problems found by GCC 4.6.0's static checks.
3622
3623 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3624 Remove unused local var.
3625
3626 * editfns.c (Fmessage_box): Remove unused local var.
3627
3628 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3629 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3630 Omit unused local vars.
3631 * window.c (shrink_windows): Omit unused local var.
3632 * menu.c (digest_single_submenu): Omit unused local var.
3633 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3634 Omit unused local var.
3635
3636 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3637 Don't assume string length fits in int.
3638 (keyremap_step, read_key_sequence): Use size_t for sizes.
3639 (read_key_sequence): Don't check last_real_key_start redundantly.
3640
3641 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3642 instead of alloca (Bug#8344).
3643
3644 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3645 (Fbacktrace_frame): Don't assume nframes fits in int.
3646
3647 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3648
3649 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3650 concerns.
3651
3652 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3653
3654 * cm.c (calccost): Turn while-do into do-while, for clarity.
3655
3656 * keyboard.c (syms_of_keyboard): Use the same style as later
3657 in this function when indexing through an array. This also
3658 works around GCC bug 48267.
3659
3660 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3661
3662 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3663
3664 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3665 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3666
3667 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3668 This avoids undefined behavior on integer overflow, and is a bit
3669 more convenient anyway since it is compared to a size_t variable.
3670
3671 Variadic C functions now count arguments with size_t, not int.
3672 This avoids an unnecessary limitation on 64-bit machines, which
3673 caused (substring ...) to crash on large vectors (Bug#8344).
3674 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3675 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3676 All variadic functions and their callers changed accordingly.
3677 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3678 * data.c (arith_driver, float_arith_driver): Likewise.
3679 * editfns.c (general_insert_function): Likewise.
3680 * eval.c (struct backtrace.nargs, interactive_p)
3681 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3682 (funcall_lambda, mark_backtrace): Likewise.
3683 * fns.c (concat): Likewise.
3684 * frame.c (x_set_frame_parameters): Likewise.
3685 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3686 0 if not found, not -1. All callers changed.
3687
3688 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3689 (stack_copy_size): Now size_t, not int.
3690 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3691
3692 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3693
3694 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3695 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3696 All callers changed.
3697
3698 * lisp.h (multibyte_char_to_unibyte):
3699 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3700 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3701 * character.h (CHAR_TO_BYTE8):
3702 * cmds.c (internal_self_insert):
3703 * editfns.c (general_insert_function):
3704 * keymap.c (push_key_description):
3705 * search.c (Freplace_match):
3706 * xdisp.c (message_dolog, set_message_1): All callers changed.
3707
3708 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3709
3710 * keyboard.c (safe_run_hook_funcall): New function.
3711 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3712 don't set the hook to nil, but remove the offending function instead.
3713 (Qcommand_hook_internal): Remove, unused.
3714 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3715 Vcommand_hook_internal.
3716
3717 * eval.c (enum run_hooks_condition): Remove.
3718 (funcall_nil, funcall_not): New functions.
3719 (run_hook_with_args): Call each function through a `funcall' argument.
3720 Remove `cond' argument, now redundant.
3721 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3722 (Frun_hook_with_args_until_failure): Adjust accordingly.
3723 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3724
3725 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3726
3727 * dispextern.h (string_buffer_position): Remove declaration.
3728
3729 * print.c (strout): Remove parameter `multibyte', unused since
3730 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3731
3732 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3733 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3734 All callers changed.
3735
3736 * w32.c (_wsa_errlist): Use braces for struct initializers.
3737
3738 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3739 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3740 All callers changed.
3741 (string_buffer_position): Likewise. Also, make static (it's never
3742 used outside xdisp.c).
3743 (cursor_row_p): Remove parameter `w', unused since
3744 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3745 (decode_mode_spec): Remove parameter `precision', introduced during
3746 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3747 All callers changed.
3748
3749 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3750
3751 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3752
3753 2011-03-27 Anders Lindgren <andlind@gmail.com>
3754
3755 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3756 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3757 (ns_update_auto_hide_menu_bar): New functions.
3758 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3759 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3760 ns_constrain_all_frames.
3761 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3762 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3763
3764 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3765
3766 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3767
3768 2011-03-27 Glenn Morris <rgm@gnu.org>
3769
3770 * syssignal.h: Replace RETSIGTYPE with void.
3771 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3772 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3773 Replace SIGTYPE with void everywhere.
3774 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3775 * s/template.h (SIGTYPE): Remove commented out definition.
3776
3777 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3778
3779 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3780 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3781
3782 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3783
3784 * w32.c (read_unc_volume): Use parameter `henum', instead of
3785 global variable `wget_enum_handle'.
3786
3787 * keymap.c (describe_vector): Remove parameters `indices' and
3788 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3789 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3790
3791 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3792
3793 * keyboard.c (timer_check): Remove parameter `do_it_now',
3794 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3795 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3796 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3797
3798 * keyboard.c (read_char):
3799 * w32menu.c (w32_menu_display_help):
3800 * xmenu.c (show_help_event, menu_help_callback):
3801 Adjust calls to `show_help_echo'.
3802
3803 * gtkutil.c (xg_maybe_add_timer):
3804 * keyboard.c (readable_events):
3805 * process.c (wait_reading_process_output):
3806 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3807
3808 * insdel.c (adjust_markers_gap_motion):
3809 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3810 (gap_left, gap_right): Don't call it.
3811
3812 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3813
3814 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3815 incurred during fontification.
3816
3817 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3818
3819 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3820 (DEFVAR_PER_BUFFER): Don't pass it.
3821
3822 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3823 (scrolling_window): Don't pass it.
3824
3825 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3826
3827 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3828
3829 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3830 and `suffix'.
3831 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3832 of variables specific to SELinux and computation of `encoded_absname'.
3833
3834 * image.c (XPutPixel): Remove unused variable `height'.
3835
3836 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3837
3838 * unexw32.c (get_section_info): Remove unused variable `section'.
3839
3840 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3841 (system_process_attributes): Remove unused variable `sess'.
3842 (sys_read): Remove unused variable `err'.
3843
3844 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3845 (w32_wnd_proc): Remove unused variable `isdead'.
3846 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3847 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3848 (x_create_tip_frame): Remove unused variable `tem'.
3849
3850 * w32inevt.c (w32_console_read_socket):
3851 Remove unused variable `no_events'.
3852
3853 * w32term.c (x_draw_composite_glyph_string_foreground):
3854 Remove unused variable `width'.
3855
3856 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3857
3858 * w32term.c (x_set_glyph_string_clipping):
3859 Don't pass uninitialized region to CombineRgn.
3860
3861 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3862
3863 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3864 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3865 (Fx_close_connection): Remove unused variable `i'.
3866
3867 * w32font.c (w32font_draw): Return number of glyphs.
3868 (w32font_open_internal): Remove unused variable `i'.
3869 (w32font_driver): Add missing initializer.
3870
3871 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3872 (fill_in_menu): Remove unused variable `items_added'.
3873
3874 * w32term.c (last_mouse_press_frame): Remove static global variable.
3875 (w32_clip_to_row): Remove unused variable `f'.
3876 (x_delete_terminal): Remove unused variable `i'.
3877
3878 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3879 (NOTHING): Remove unused static global variable.
3880 (uniscribe_check_otf): Remove unused variable `table'.
3881 (uniscribe_font_driver): Add missing initializers.
3882
3883 2011-03-23 Julien Danjou <julien@danjou.info>
3884
3885 * term.c (Fsuspend_tty, Fresume_tty):
3886 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3887 * window.c (temp_output_buffer_show):
3888 * insdel.c (signal_before_change):
3889 * frame.c (Fhandle_switch_frame):
3890 * fileio.c (Fdo_auto_save):
3891 * emacs.c (Fkill_emacs):
3892 * editfns.c (save_excursion_restore):
3893 * cmds.c (internal_self_insert):
3894 * callint.c (Fcall_interactively):
3895 * buffer.c (Fkill_all_local_variables):
3896 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3897 Use Frun_hooks.
3898 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3899 unconditionnaly since it does the check itself.
3900
3901 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3902
3903 Fix more problems found by GCC 4.5.2's static checks.
3904
3905 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3906 the first time through the loop, since we know p0 < p1 then.
3907 This also avoids a gcc -Wstrict-overflow warning.
3908
3909 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3910 leading to a memory leak, possible in functions like
3911 load_charset_map_from_file that can allocate an unbounded number
3912 of objects (Bug#8318).
3913
3914 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3915 that could (at least in theory) be that large.
3916
3917 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3918 This is less likely to overflow, and avoids undefined behavior if
3919 overflow does occur. All callers changed. Use strtoul to scan
3920 for the unsigned long integer.
3921 (pint2hrstr): Simplify and tune code slightly.
3922 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3923
3924 * scroll.c (do_scrolling): Work around GCC bug 48228.
3925 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3926
3927 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3928 This also avoids a warning with gcc -Wstrict-overflow.
3929 (validate_x_resource_name): Simplify count usage.
3930 This also avoids a warning with gcc -Wstrict-overflow.
3931
3932 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3933 fail (Bug#8306).
3934
3935 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3936
3937 * process.c (Fmake_network_process): Use socklen_t, not int,
3938 where POSIX says socklen_t is required in portable programs.
3939 This fixes a porting bug on hosts like 64-bit HP-UX, where
3940 socklen_t is wider than int (Bug#8277).
3941 (Fmake_network_process, server_accept_connection):
3942 (wait_reading_process_output, read_process_output):
3943 Likewise.
3944
3945 * process.c: Rename or move locals to avoid shadowing.
3946 (list_processes_1, Fmake_network_process):
3947 (read_process_output_error_handler, exec_sentinel_error_handler):
3948 Rename or move locals.
3949 (Fmake_network_process): Define label "retry_connect" only if needed.
3950 (Fnetwork_interface_info): Fix pointer signedness.
3951 (process_send_signal): Add cast to avoid pointer signedness problem.
3952 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3953 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3954
3955 Make tparam.h and terminfo.c consistent.
3956 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3957 Include tparam.h instead, since it declares them.
3958 * cm.h (PC): Remove extern decl; tparam.h now does this.
3959 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3960 * terminfo.c: Include tparam.h, to check interfaces.
3961 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3962 (tparam): Adjust signature to match interface in tparam.h;
3963 this removes some undefined behavior. Check that outstring and len
3964 are zero, which they always are with Emacs.
3965 * tparam.h (PC, BC, UP): New extern decls.
3966
3967 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3968 (xftfont_open): Rename locals to avoid shadowing.
3969
3970 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3971 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3972 (OTF_TAG_SYM): Omit macro if not needed.
3973 (ftfont_list): Remove unused local.
3974 (get_adstyle_property, ftfont_pattern_entity):
3975 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3976 Rename locals to avoid shadowing.
3977
3978 * xfont.c (xfont_list_family): Mark var as initialized.
3979
3980 * xml.c (make_dom): Now static.
3981
3982 * composite.c (composition_compute_stop_pos): Rename local to
3983 avoid shadowing.
3984 (composition_reseat_it): Remove unused locals.
3985 (find_automatic_composition, composition_adjust_point): Likewise.
3986 (composition_update_it): Mark var as initialized.
3987 (find_automatic_composition): Mark vars as initialized,
3988 with a FIXME (Bug#8290).
3989
3990 character.h: Rename locals to avoid shadowing.
3991 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3992 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3993 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3994 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3995 to avoid shadowing.
3996
3997 * textprop.c (property_change_between_p): Remove; unused.
3998
3999 * intervals.c (interval_start_pos): Now static.
4000
4001 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4002
4003 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4004 Rename locals to avoid shadowing.
4005
4006 * sound.c (wav_play, au_play, Fplay_sound_internal):
4007 Fix pointer signedness.
4008 (alsa_choose_format): Remove unused local var.
4009 (wav_play): Initialize a variable to 0, to prevent undefined
4010 behavior (Bug#8278).
4011
4012 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4013
4014 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4015
4016 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4017 clobbering (Bug#8298).
4018 * sysdep.c (sys_subshell): Likewise.
4019 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4020
4021 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4022 This should get cleaned up, so that child_setup has the
4023 same signature on all platforms.
4024
4025 * callproc.c (call_process_cleanup): Now static.
4026 (relocate_fd): Rename locals to avoid shadowing.
4027
4028 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4029
4030 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4031 not to be necessary, and produces flickering.
4032
4033 2011-03-20 Glenn Morris <rgm@gnu.org>
4034
4035 * config.in: Remove file.
4036
4037 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4038
4039 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4040 are now in src/globals.h.
4041 (syms_of_minibuf): Remove spurious & from previous change.
4042
4043 2011-03-20 Leo <sdl.web@gmail.com>
4044
4045 * minibuf.c (completing-read-function): New variable.
4046 (completing-read-default): Rename from completing-read.
4047 (completing-read): Call completing-read-function.
4048
4049 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4050
4051 * xfaces.c (Fx_load_color_file):
4052 Read color file from absolute filename (bug#8250).
4053
4054 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4055
4056 * makefile.w32-in: Update dependencies.
4057
4058 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4059
4060 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4061
4062 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4063
4064 Fix more problems found by GCC 4.5.2's static checks.
4065
4066 * process.c (make_serial_process_unwind, send_process_trap):
4067 (sigchld_handler): Now static.
4068
4069 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4070 That way, the code declares only the vars that it needs.
4071 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4072 * s/cygwin.h (PTY_ITERATION): Likewise.
4073 * s/darwin.h (PTY_ITERATION): Likewise.
4074 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4075
4076 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4077 * process.c (allocate_pty): Don't declare stb unless it's needed.
4078
4079 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4080 (CONSTANTLIM): Remove; unused.
4081 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4082 Define only if needed.
4083
4084 * unexelf.c (unexec): Name an expression,
4085 to avoid gcc -Wbad-function-cast warning.
4086 Use a different way to cause a compilation error if anyone uses
4087 n rather than nn, a way that does not involve shadowing.
4088 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4089
4090 * deps.mk (unexalpha.o): Remove; unused.
4091
4092 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4093 * unexec.h: New file.
4094 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4095 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4096 Depend on unexec.h.
4097 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4098 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4099 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4100 Change as necessary to match prototype in unexec.h.
4101
4102 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4103 shadowing.
4104 (back_comment, skip_chars): Mark vars as initialized.
4105
4106 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4107 Rename locals to avoid shadowing.
4108
4109 * lread.c (read1): Rewrite so as not to use empty "else".
4110 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4111
4112 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4113
4114 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4115 warning when compiling print.c.
4116
4117 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4118 instead of using an uninitialized var.
4119 (font_sort_entities): Mark var as initialized.
4120
4121 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4122
4123 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4124 pointers to constants.
4125 (font_parse_fcname): Remove unused vars.
4126 (font_delete_unmatched): Now static.
4127 (font_get_spec): Remove; unused.
4128 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4129 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4130 Rename or move locals to avoid shadowing.
4131
4132 * fns.c (require_nesting_list, require_unwind): Now static.
4133 (Ffillarray): Rename locals to avoid shadowing.
4134
4135 * floatfns.c (domain_error2): Define only if needed.
4136 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4137
4138 * alloc.c (mark_backtrace): Move decl from here ...
4139 * lisp.h: ... to here, so that it can be checked.
4140
4141 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4142 (Fdefvar): Rewrite so as not to use empty "else".
4143 (lisp_indirect_variable): Name an expression,
4144 to avoid gcc -Wbad-function-cast warning.
4145 (Fdefvar): Rename locals to avoid shadowing.
4146
4147 * callint.c (quotify_arg, quotify_args): Now static.
4148 (Fcall_interactively): Rename locals to avoid shadowing.
4149 Use const pointer when appropriate.
4150
4151 * lisp.h (get_system_name, get_operating_system_release):
4152 Move decls here, to check interfaces.
4153 * process.c (get_operating_system_release): Move decl to lisp.h.
4154 * xrdb.c (get_system_name): Likewise.
4155 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4156 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4157 some of which prompt warnings from gcc -Wbad-function-cast.
4158 (Fformat_time_string, Fencode_time, Finsert_char):
4159 (Ftranslate_region_internal, Fformat):
4160 Rename or remove local vars to avoid shadowing.
4161 (Ftranslate_region_internal): Mark var as initialized.
4162
4163 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4164 avoid shadowing.
4165
4166 * lisp.h (eassert): Check that the argument compiles, even if
4167 ENABLE_CHECKING is not defined.
4168
4169 * data.c (Findirect_variable): Name an expression, to avoid
4170 gcc -Wbad-function-cast warning.
4171 (default_value, arithcompare, arith_driver, arith_error): Now static.
4172 (store_symval_forwarding): Rename local to avoid shadowing.
4173 (Fmake_variable_buffer_local, Fmake_local_variable):
4174 Mark variables as initialized.
4175 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4176
4177 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4178 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4179 Rename locals to avoid shadowing.
4180 (mark_stack): Move local variables into the #ifdef region where
4181 they're used.
4182 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4183 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4184 needed otherwise.
4185 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4186 (GC_STRING_CHARS): Remove; not used.
4187 (Fmemory_limit): Cast sbrk's returned value to char *.
4188
4189 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4190 avoids undefined behavior in theory.
4191
4192 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4193
4194 Use functions, not macros, for up- and down-casing (Bug#8254).
4195 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4196 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4197 to use the following functions instead of these macros.
4198 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4199 EMACS_INT, since callers assume the returned value fits in int.
4200 (upcase1): Likewise, for UPCASE_TABLE.
4201 (uppercasep, lowercasep, upcase): New static inline functions.
4202 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4203 the race-condition problem in the old DOWNCASE.
4204
4205 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4206 Rename locals to avoid shadowing.
4207 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4208 (regex_compile, re_search_2, re_match_2_internal):
4209 Remove unused local vars.
4210 (FREE_VAR): Rewrite so as not to use empty "else",
4211 which gcc can warn about.
4212 (regex_compile, re_match_2_internal): Mark locals as initialized.
4213 (RETALLOC_IF): Define only if needed.
4214 (WORDCHAR_P): Likewise. This one is never needed, but is used
4215 only in a comment talking about a compiler bug, so put inside
4216 the #if 0 of that comment.
4217 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4218 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4219 Remove; unused.
4220
4221 * search.c (boyer_moore): Rename locals to avoid shadowing.
4222 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4223 (PREV_CHAR_BOUNDARY): Likewise.
4224
4225 * search.c (simple_search): Remove unused var.
4226
4227 * dired.c (compile_pattern): Move decl from here ...
4228 * lisp.h: ... to here, so that it can be checked.
4229 (struct re_registers): New forward decl.
4230
4231 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4232
4233 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4234 All uses changed.
4235 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4236 Rename locals to avoid shadowing.
4237 (Fvertical_motion): Mark locals as initialized.
4238
4239 * casefiddle.c (casify_object, casify_region): Now static.
4240 (casify_region): Mark local as initialized.
4241
4242 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4243
4244 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4245 New macros, so that the caller can use some names other than
4246 gcpro1, gcpro2, etc.
4247 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4248 of the new macros.
4249 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4250 argument, for consistency with GCPRO2_VAR, etc: it is now the
4251 prefix of the variable, not the variable itself. All uses
4252 changed.
4253 * dired.c (directory_files_internal, file_name_completion):
4254 Rename locals to avoid shadowing.
4255
4256 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4257 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4258 dired.c's scmp function, had undefined behavior.
4259 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4260 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4261 * buffer.h: ... to here, because these macros use current_buffer,
4262 and the new implementation with inline functions needs to have
4263 current_buffer in scope now, rather than later when the macros
4264 are used.
4265 (downcase, upcase1): New static inline functions.
4266 (DOWNCASE, UPCASE1): Reimplement using these functions.
4267 This avoids undefined behavior in expressions like
4268 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4269 from race conditions in accessing the global variables
4270 case_temp1 and case_temp2.
4271 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4272 * lisp.h (case_temp1, case_temp2): Remove their decls.
4273 * character.h (ASCII_CHAR_P): Move from here ...
4274 * lisp.h: ... to here, so that the inline functions mentioned
4275 above can use them.
4276
4277 * dired.c (directory_files_internal_unwind): Now static.
4278
4279 * fileio.c (file_name_as_directory, directory_file_name):
4280 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4281 Now static.
4282 (file_name_as_directory): Use const pointers when appropriate.
4283 (Fexpand_file_name): Likewise. In particular, newdir might
4284 point at constant storage, so make it a const pointer.
4285 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4286 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4287 signedness issues.
4288 (Fset_file_times, Finsert_file_contents, auto_save_error):
4289 Rename locals to avoid shadowing.
4290
4291 * minibuf.c (choose_minibuf_frame_1): Now static.
4292 (Ftry_completion, Fall_completions): Rename or remove locals
4293 to avoid shadowing.
4294
4295 * marker.c (bytepos_to_charpos): Remove; unused.
4296
4297 * lisp.h (verify_bytepos, count_markers): New decls,
4298 so that gcc does not warn that these functions aren't declared.
4299
4300 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4301 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4302 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4303 (copy_text): Remove unused local var.
4304
4305 * filelock.c (within_one_second): Now static.
4306 (lock_file_1): Rename local to avoid shadowing.
4307
4308 * buffer.c (fix_overlays_before): Mark locals as initialized.
4309 (fix_start_end_in_overlays): Likewise. This function should be
4310 simplified by using pointers-to-pointers, but that's a different
4311 matter.
4312 (switch_to_buffer_1): Now static.
4313 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4314 (report_overlay_modification): Rename locals to avoid shadowing.
4315
4316 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4317 Fix pointer signedness issue.
4318 (sys_subshell): Mark local as volatile if checking for lint,
4319 to suppress a gcc -Wclobbered warning that does not seem to be right.
4320 (MAXPATHLEN): Define only if needed.
4321
4322 * process.c (serial_open, serial_configure): Move decls from here ...
4323 * systty.h: ... to here, so that they can be checked.
4324
4325 * fns.c (get_random, seed_random): Move extern decls from here ...
4326 * lisp.h: ... to here, so that they can be checked.
4327
4328 * sysdep.c (reset_io): Now static.
4329 (wait_for_termination_signal): Remove; unused.
4330
4331 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4332 (copy_keymap_item, append_key, push_text_char_description):
4333 Now static.
4334 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4335 (DENSE_TABLE_SIZE): Remove; unused.
4336 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4337 (describe_map_tree):
4338 Rename locals to avoid shadowing.
4339
4340 * keyboard.c: Declare functions static if they are not used elsewhere.
4341 (echo_char, echo_dash, cmd_error, top_level_2):
4342 (poll_for_input, handle_async_input): Now static.
4343 (read_char, kbd_buffer_get_event, make_lispy_position):
4344 (make_lispy_event, make_lispy_movement, apply_modifiers):
4345 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4346 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4347 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4348 (read_key_sequence, read_char): Mark locals as initialized.
4349 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4350
4351 * keyboard.h (make_ctrl_char): New decl.
4352 (mark_kboards): Move decl here ...
4353 * alloc.c (mark_kboards): ... from here.
4354
4355 * lisp.h (force_auto_save_soon): New decl.
4356
4357 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4358 (DEFINE_DUMMY_FUNCTION): New macro.
4359 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4360 Use it.
4361 (main): Add casts to avoid warnings
4362 if GCC considers string literals to be constants.
4363
4364 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4365
4366 * dbusbind.c: Pointer signedness fixes.
4367 (xd_signature, xd_append_arg, xd_initialize):
4368 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4369 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4370 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4371 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4372
4373 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4374 if GCC considers string literals to be constants.
4375 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4376
4377 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4378
4379 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4380 (print_preprocess, print_object): New macro to fix last change.
4381
4382 * print.c (print_preprocess): Don't forget font objects.
4383
4384 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4385
4386 * emacs.c (USAGE3): Doc fixes.
4387
4388 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4389
4390 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4391 structure.
4392
4393 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4394
4395 * lisp.h (VWindow_system, Qfile_name_history):
4396 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4397 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4398 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4399
4400 * w32select.c: Don't #include "keyboard.h".
4401 (run_protected): Add extern declaration for waiting_for_input.
4402
4403 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4404 * w32console.c (detect_input_pending, read_input_pending)
4405 (encode_terminal_code):
4406 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4407 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4408 (w32_system_caret_y, Qfile_name_history):
4409 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4410 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4411 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4412 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4413 * w32proc.c (Qlocal, report_file_error):
4414 * w32term.c (Vwindow_system, updating_frame):
4415 * w32uniscribe.c (initialized, uniscribe_font_driver):
4416 Remove unneeded extern declarations.
4417
4418 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4419
4420 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4421
4422 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4423
4424 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4425 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4426 These macros can no longer be used for assignment.
4427
4428 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4429 Assign struct members directly, instead of using BUF_BEGV etc.
4430 (record_buffer_markers, fetch_buffer_markers): New functions for
4431 recording and fetching special buffer markers.
4432 (set_buffer_internal_1, set_buffer_temp): Use them.
4433
4434 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4435
4436 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4437
4438 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4439 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4440
4441 * xdisp.c (hscroll_window_tree):
4442 (reconsider_clip_changes): Use PT instead of BUF_PT.
4443
4444 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4445
4446 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4447 $(EMACS_ROOT)/lib/intprops.h.
4448
4449 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4450
4451 Fix more problems found by GCC 4.5.2's static checks.
4452
4453 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4454 to unsigned char * to avoid compiler diagnostic.
4455 (xg_free_frame_widgets): Make it clear that a local variable is
4456 needed only if USE_GTK_TOOLTIP.
4457 (gdk_window_get_screen): Make it clear that this macro is needed
4458 only if USE_GTK_TOOLTIP.
4459 (int_gtk_range_get_value): New function, which avoids a diagnostic
4460 from gcc -Wbad-function-cast.
4461 (xg_set_toolkit_scroll_bar_thumb): Use it.
4462 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4463 diagnostic from gcc -Wbad-function-cast.
4464 (get_utf8_string, xg_get_file_with_chooser):
4465 Rename locals to avoid shadowing.
4466 (create_dialog): Move locals to avoid shadowing.
4467
4468 * xgselect.c (xg_select): Remove unused var.
4469
4470 * image.c (four_corners_best): Mark locals as initialized.
4471 (gif_load): Initialize transparent_p to zero (Bug#8238).
4472 Mark another local as initialized.
4473 (my_png_error, my_error_exit): Mark with NO_RETURN.
4474
4475 * image.c (clear_image_cache): Now static.
4476 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4477 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4478 (x_edge_detection): Remove unnecessary cast that
4479 gcc -Wbad-function-cast diagnoses.
4480 (gif_load): Fix pointer signedness.
4481 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4482 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4483
4484 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4485
4486 Improve quality of tests for time stamp overflow.
4487 For example, without this patch (encode-time 0 0 0 1 1
4488 1152921504606846976) returns the obviously-bogus value (-948597
4489 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4490 reports time overflow. See
4491 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4492 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4493 * editfns.c: Include limits.h and intprops.h.
4494 (TIME_T_MIN, TIME_T_MAX): New macros.
4495 (time_overflow): Move earlier, to before first use.
4496 (hi_time, lo_time): New functions, for an accurate test for
4497 out-of-range times.
4498 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4499 (Fget_internal_run_time): Don't assume time_t fits in int.
4500 (make_time): Use list2 instead of Fcons twice.
4501 (Fdecode_time): More accurate test for out-of-range times.
4502 (check_tm_member): New function.
4503 (Fencode_time): Use it, to test for out-of-range times.
4504 (lisp_time_argument): Don't rely on undefined left-shift and
4505 right-shift behavior when checking for time stamp overflow.
4506
4507 * editfns.c (time_overflow): New function, refactoring common code.
4508 (Fformat_time_string, Fdecode_time, Fencode_time):
4509 (Fcurrent_time_string): Use it.
4510
4511 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4512 * dired.c (make_time): Move to ...
4513 * editfns.c (make_time): ... here.
4514 * systime.h: Note the move.
4515
4516 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4517
4518 * fringe.c (update_window_fringes): Remove unused variables.
4519
4520 * unexmacosx.c (copy_data_segment): Also copy __got section.
4521 (Bug#8223)
4522
4523 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4524
4525 * termcap.c [MSDOS]: Include "msdos.h".
4526 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4527 Constify `char *' arguments and their references according to
4528 prototypes in tparam.h.
4529
4530 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4531
4532 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4533 Adapt all references accordingly.
4534
4535 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4536
4537 2011-03-11 Tom Tromey <tromey@redhat.com>
4538
4539 * buffer.c (syms_of_buffer): Remove obsolete comment.
4540
4541 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4542
4543 * termhooks.h (encode_terminal_code): Declare prototype.
4544
4545 * msdos.c (encode_terminal_code): Don't declare prototype.
4546
4547 * term.c (encode_terminal_code): Now external again, used by
4548 w32console.c and msdos.c.
4549
4550 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4551 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4552
4553 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4554
4555 Fix some minor problems found by GCC 4.5.2's static checks.
4556
4557 * fringe.c (update_window_fringes): Mark locals as initialized
4558 (Bug#8227).
4559 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4560
4561 * alloc.c (mark_fringe_data): Move decl from here ...
4562 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4563 to check its interface.
4564 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4565
4566 * fontset.c (free_realized_fontset): Now static.
4567 (Fset_fontset_font): Rename local to avoid shadowing.
4568 (fontset_font): Mark local as initialized.
4569 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4570
4571 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4572
4573 * xselect.c (x_disown_buffer_selections): Remove; not used.
4574 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4575 (x_own_selection, Fx_disown_selection_internal): Rename locals
4576 to avoid shadowing.
4577 (x_handle_dnd_message): Remove local to avoid shadowing.
4578
4579 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4580 so that the caller can use some name other than gcpro1.
4581 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4582 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4583 (Fx_backspace_delete_keys_p):
4584 Use them to avoid shadowing, and rename vars to avoid shadowing.
4585 (x_decode_color, x_set_name, x_window): Now static.
4586 (Fx_create_frame): Add braces to silence GCC warning.
4587 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4588 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4589 Remove unused locals.
4590 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4591 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4592 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4593 macros.
4594
4595 * xterm.h (x_mouse_leave): New decl.
4596
4597 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4598 Remove unused functions.
4599 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4600 (x_calc_absolute_position): Now static.
4601 (XTread_socket): Don't define label "out" unless it's used.
4602 Don't declare local "event" unless it's used.
4603 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4604 unless they are used.
4605 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4606 (x_fatal_error_signal): Remove; not used.
4607 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4608 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4609 (x_error_catcher, x_connection_closed, x_error_handler):
4610 (x_error_quitter, xembed_send_message, x_iconify_frame):
4611 (my_log_handler): Rename locals to avoid shadowing.
4612 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4613 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4614
4615 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4616 Rename or move locals to avoid shadowing.
4617 (tty_defined_color, merge_face_heights): Now static.
4618 (free_realized_faces_for_fontset): Remove; not used.
4619 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4620 does not deduce is never used uninitialized.
4621 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4622 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4623
4624 * terminal.c (store_terminal_param): Now static.
4625
4626 * xmenu.c (menu_highlight_callback): Now static.
4627 (set_frame_menubar): Remove unused local.
4628 (xmenu_show): Rename parameter to avoid shadowing.
4629 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4630 since they might point to immutable storage.
4631 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4632 since it's unused otherwise.
4633
4634 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4635 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4636 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4637 avoids a gcc -Wuninitialized diagnostic.
4638 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4639 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4640 does not deduce are never used uninitialized.
4641
4642 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4643
4644 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4645 * window.c (window_loop, size_window):
4646 (run_window_configuration_change_hook, enlarge_window): Likewise.
4647
4648 * window.c (display_buffer): Now static.
4649 (size_window): Mark variables that gcc -Wuninitialized
4650 does not deduce are never used uninitialized.
4651 * window.h (check_all_windows): New decl, to forestall
4652 gcc -Wmissing-prototypes diagnostic.
4653 * dispextern.h (bidi_dump_cached_states): Likewise.
4654
4655 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4656 shadowing.
4657 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4658 Include <limits.h>.
4659 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4660 and to avoid gcc -Wuninitialized warning.
4661 (load_charset_map): Mark variables that gcc -Wuninitialized
4662 does not deduce are never used uninitialized.
4663 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4664
4665 * coding.c (coding_set_source, coding_set_destination):
4666 Use "else { /* comment */ }" rather than "else /* comment */;"
4667 for clarity, and to avoid gcc -Wempty-body warning.
4668 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4669 a block, when the outer 'i' will do.
4670 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4671 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4672 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4673 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4674 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4675 Rename locals to avoid shadowing.
4676 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4677 * coding.c (emacs_mule_char, encode_invocation_designation):
4678 Now static, since they're not used elsewhere.
4679 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4680 (decode_coding_object, encode_coding_object, detect_coding_system):
4681 (decode_coding_emacs_mule): Mark variables that gcc
4682 -Wuninitialized does not deduce are never used uninitialized.
4683 (detect_coding_iso_2022): Initialize a local variable that might
4684 be used uninitialized. Leave a FIXME because it's not clear that
4685 this initialization is needed. (Bug#8211)
4686 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4687 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4688 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4689 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4690 Remove unused macros.
4691
4692 * category.c (hash_get_category_set): Remove unused local var.
4693 (copy_category_table): Now static, since it's not used elsewhere.
4694 * character.c (string_count_byte8): Likewise.
4695
4696 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4697 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4698
4699 * chartab.c (copy_sub_char_table): Now static, since it's not used
4700 elsewhere.
4701 (sub_char_table_ref_and_range, char_table_ref_and_range):
4702 Rename locals to avoid shadowing.
4703 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4704
4705 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4706 (BIDI_BOB): Remove unused macro.
4707
4708 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4709 deduce are never used uninitialized.
4710 * term.c (encode_terminal_code): Likewise.
4711
4712 * term.c (encode_terminal_code): Now static. Remove unused local.
4713
4714 * tparam.h: New file.
4715 * term.c, tparam.h: Include it.
4716 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4717 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4718 Move these decls to tparam.h, and make them agree with what
4719 is actually in tparam.c. The previous trick of using incompatible
4720 decls in different modules does not conform to the C standard.
4721 All callers of tparam changed to use tparam's actual API.
4722 * tparam.c (tparam1, tparam, tgoto):
4723 Use const pointers where appropriate.
4724
4725 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4726 * cm.h (struct cm): Likewise.
4727 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4728 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4729 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4730 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4731 (turn_on_face, init_tty): Likewise.
4732 * termchar.h (struct tty_display_info): Likewise.
4733
4734 * term.c (term_mouse_position): Rename local to avoid shadowing.
4735
4736 * alloc.c (mark_ttys): Move decl from here ...
4737 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4738
4739 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4740
4741 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4742
4743 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4744
4745 * search.c (compile_pattern_1): Remove argument regp, unused since
4746 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4747 (compile_pattern): Don't pass it.
4748
4749 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4750
4751 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4752 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4753 for ! HAVE_GTK3.
4754 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4755
4756 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4757
4758 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4759 gdk_window_get_screen, gdk_window_get_geometry,
4760 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4761 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4762 (xg_get_pixbuf_from_pixmap): New function.
4763 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4764 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4765 Call xg_get_pixbuf_from_pixmap instead of
4766 gdk_pixbuf_get_from_drawable.
4767 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4768 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4769 (xg_check_special_colors): Use GtkStyleContext and its functions
4770 for HAVE_GTK3.
4771 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4772 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4773 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4774 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4775 Call gtk_widget_get_preferred_size.
4776 (xg_frame_resized): gdk_window_get_geometry only takes 5
4777 parameters.
4778 (xg_win_to_widget, xg_event_is_for_menubar):
4779 Call gdk_x11_window_lookup_for_display.
4780 (xg_set_widget_bg): New function.
4781 (delete_cb): New function.
4782 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4783 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4784 (xg_set_background_color): Call xg_set_widget_bg.
4785 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4786 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4787 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4788 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4789 if ! HAVE_GTK3.
4790 (update_frame_tool_bar): Call gtk_widget_hide.
4791 (xg_initialize): Use GDK_KEY_g.
4792
4793 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4794 if ! HAVE_GTK3
4795 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4796
4797 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4798 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4799 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4800
4801 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4802
4803 * w32xfns.c (select_palette): Check success of RealizePalette against
4804 GDI_ERROR, not zero.
4805
4806 See ChangeLog.11 for earlier changes.
4807
4808 ;; Local Variables:
4809 ;; coding: utf-8
4810 ;; End:
4811
4812 Copyright (C) 2011 Free Software Foundation, Inc.
4813
4814 This file is part of GNU Emacs.
4815
4816 GNU Emacs is free software: you can redistribute it and/or modify
4817 it under the terms of the GNU General Public License as published by
4818 the Free Software Foundation, either version 3 of the License, or
4819 (at your option) any later version.
4820
4821 GNU Emacs is distributed in the hope that it will be useful,
4822 but WITHOUT ANY WARRANTY; without even the implied warranty of
4823 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4824 GNU General Public License for more details.
4825
4826 You should have received a copy of the GNU General Public License
4827 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.