Don't assume that tab-width fits in int.
[bpt/emacs.git] / src / ChangeLog
1 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2
3 Don't assume that tab-width fits in int.
4 * character.h (sanitize_width): New inline function.
5 (SANE_TAB_WIDTH): New macro.
6 (ASCII_CHAR_WIDTH): Use it.
7 * indent.c (sane_tab_width): Remove. All uses replaced by
8 SANE_TAB_WIDTH (current_buffer).
9 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
10
11 * fileio.c: Integer overflow issues with file modes.
12 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
13
14 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
15 Remove unreachable code.
16 (read_hex, load_charset_map_from_file): Check for integer overflow.
17
18 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
19
20 * xterm.c: don't go over XClientMessageEvent limit
21 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
22 (x_send_scroll_bar_event): Likewise. Check that the size does not
23 exceed limits imposed by XClientMessageEvent, as well as the usual
24 ptrdiff_t and size_t limits.
25
26 * keyboard.c: Overflow, signedness and related fixes.
27 (make_lispy_movement): Use same integer type in forward decl
28 that is used in the definition.
29 (read_key_sequence, keyremap_step):
30 Change bufsize argument back to int, undoing my 2011-03-30 change.
31 We prefer signed types, and int is wide enough here.
32 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
33 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
34 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
35 length, not size_t. Use ptrdiff_t for index, not int.
36 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
37 possibility of integer overflow.
38
39 Overflow, signedness and related fixes for images.
40
41 * dispextern.h (struct it.stack[0].u.image.image_id)
42 (struct_it.image_id, struct image.id, struct image_cache.size)
43 (struct image_cache.used, struct image_cache.ref_count):
44 * gtkutil.c (update_frame_tool_bar):
45 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
46 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
47 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
48 * nsmenu.m (update_frame_tool_bar):
49 * xdisp.c (calc_pixel_width_or_height):
50 * xfns.c (image_cache_refcount):
51 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
52 on typical 64-bit hosts.
53
54 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
55 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
56 Omit unnecessary casts to int.
57 (parse_image_spec): Check that integers fall into 'int' range
58 when the callers expect that.
59 (image_ascent): Redo ascent calculation to avoid int overflow.
60 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
61 (lookup_image): Remove unnecessary tests.
62 (xbm_image_p): Locals are now of int, not EMACS_INT,
63 since parse_image_check makes sure they fit into int.
64 (png_load, gif_load, svg_load_image):
65 Prefer int to unsigned where either will do.
66 (tiff_handler): New function, combining the cores of the
67 old tiff_error_handler and tiff_warning_handler. This
68 function is rewritten to use vsnprintf and thereby avoid
69 stack buffer overflows. It uses only the features of vsnprintf
70 that are common to both POSIX and native Microsoft.
71 (tiff_error_handler, tiff_warning_handler): Use it.
72 (tiff_load, gif_load, imagemagick_load_image):
73 Don't assume :index value fits in 'int'.
74 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
75 (imagemagick_load_image): Check that crop parameters fit into
76 the integer types that MagickCropImage accepts. Don't assume
77 Vimagemagick_render_type has a nonnegative value. Don't assume
78 size_t fits in 'long'.
79 (gs_load): Use printmax_t to print the widest integers possible.
80 Check for integer overflow when computing image height and width.
81
82 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
83
84 Integer signedness and overflow and related fixes. (Bug#9079)
85
86 * bidi.c: Integer size and overflow fixes.
87 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
88 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
89 (bidi_cache_find_level_change, bidi_cache_ensure_space)
90 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
91 (bidi_find_other_level_edge):
92 Use ptrdiff_t instead of EMACS_INT where either will do.
93 This works better on 32-bit hosts configured --with-wide-int.
94 (bidi_cache_ensure_space): Check for size-calculation overflow.
95 Use % rather than repeated addition, for better worst-case speed.
96 Don't set bidi_cache_size until after xrealloc returns, because it
97 might not return.
98 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
99 (bidi_cache_ensure_space): Also check that the bidi cache size
100 does not exceed that of the largest Lisp string or buffer. See Eli
101 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
102
103 * alloc.c (__malloc_size_t): Remove.
104 All uses replaced by size_t. See Andreas Schwab's note
105 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
106
107 * image.c: Improve checking for integer overflow.
108 (check_image_size): Assume that f is nonnull, since
109 it is always nonnull in practice. This is one less thing to
110 worry about when checking for integer overflow later.
111 (x_check_image_size): New function, which checks for integer
112 overflow issues inside X.
113 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
114 This removes the need for a memory_full check.
115 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
116 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
117 (xbm_read_bitmap_data): Change locals back to 'int', since
118 their values must fit in 'int'.
119 (xpm_load_image, png_load, tiff_load):
120 Invoke x_create_x_image_and_pixmap earlier,
121 to avoid much needless work if the image is too large.
122 (tiff_load): Treat overly large images as if
123 x_create_x_image_and_pixmap failed, not as malloc failures.
124 (gs_load): Use x_check_image_size.
125
126 * gtkutil.c: Omit integer casts.
127 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
128 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
129
130 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
131
132 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
133 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
134 would wrongly return t on a 64-bit host.
135
136 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
137 The plain *_OVERFLOW macros run afoul of GCC bug 49705
138 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
139 and therefore cause GCC to emit a bogus diagnostic in some cases.
140
141 * image.c: Integer signedness and overflow and related fixes.
142 This is not an exhaustive set of fixes, but it's time to
143 record what I've got.
144 (lookup_pixel_color, check_image_size): Remove redundant decls.
145 (check_image_size): Don't assume that arbitrary EMACS_INT values
146 fit in 'int', or that arbitrary 'double' values fit in 'int'.
147 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
148 (tiff_load, imagemagick_load_image):
149 Check for overflow in size calculations.
150 (x_create_x_image_and_pixmap): Remove unnecessary test for
151 xmalloc returning NULL; that can't happen.
152 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
153 (xpm_color_bucket): Use better integer hashing function.
154 (xpm_cache_color): Don't possibly over-allocate memory.
155 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
156 (gif_memory_source):
157 Use ptrdiff_t, not int or size_t, to record sizes.
158 (png_load): Don't assume values greater than 2**31 fit in 'int'.
159 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
160 either works, as we prefer signed integers.
161 (tiff_read_from_memory, tiff_write_from_memory):
162 Return tsize_t, not size_t, since that's what the TIFF API wants.
163 (tiff_read_from_memory): Don't fail simply because the read would
164 go past EOF; instead, return a short read.
165 (tiff_load): Omit no-longer-needed casts.
166 (Fimagemagick_types): Don't assume size fits into 'int'.
167
168 Improve hashing quality when configured --with-wide-int.
169 * fns.c (hash_string): New function, taken from sxhash_string.
170 Do not discard information about ASCII character case; this
171 discarding is no longer needed.
172 (sxhash-string): Use it. Change sig to match it. Caller changed.
173 * lisp.h: Declare it.
174 * lread.c (hash_string): Remove, since we now use fns.c's version.
175 The fns.c version returns a wider integer if --with-wide-int is
176 specified, so this should help the quality of the hashing a bit.
177
178 * emacs.c: Integer overflow minor fix.
179 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
180 Define only if GNU_LINUX.
181 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
182
183 * dispnew.c: Integer signedness and overflow fixes.
184 Remove unnecessary forward decls, that were a maintenance hassle.
185 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
186 All uses changed.
187 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
188 (scrolling_window): Use ptrdiff_t, not int, for byte count.
189 (prepare_desired_row, line_draw_cost):
190 Use int, not unsigned, where either works.
191 (save_current_matrix, restore_current_matrix):
192 Use ptrdiff_t, not size_t, where either works.
193 (init_display): Check for overflow more accurately, and without
194 relying on undefined behavior.
195
196 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
197 Remove, replacing with the new symbols in lisp.h. All uses changed.
198 * fileio.c (make_temp_name):
199 * filelock.c (lock_file_1, lock_file):
200 * xdisp.c (message_dolog):
201 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
202 Use pMd etc. instead.
203 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
204 replacing the pWIDE etc. symbols removed from editfns.c.
205
206 * keyboard.h (num_input_events): Now uintmax_t.
207 This is (very slightly) less likely to mess up due to wraparound.
208 All uses changed.
209
210 * buffer.c: Integer signedness fixes.
211 (alloc_buffer_text, enlarge_buffer_text):
212 Use ptrdiff_t rather than size_t when either will do, as we prefer
213 signed integers.
214
215 * alloc.c: Integer signedness and overflow fixes.
216 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
217 (__malloc_size_t): Default to size_t, not to int.
218 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
219 (Fgarbage_collect, mark_object_loop_halt, mark_object):
220 Prefer ptrdiff_t to size_t when either would do, as we prefer
221 signed integers.
222 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
223 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
224 Now const. Initialize with values that are in range even if char
225 is signed.
226 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
227 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
228 These functions do the right thing with sizes > 2**32.
229 (check_depth): Now ptrdiff_t, not int.
230 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
231 Adjust to new way of storing sizes. Check for size overflow bugs
232 in rest of code.
233 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
234 slightly wrong anyway, as it missed one instance of
235 XMALLOC_OVERRUN_CHECK_OVERHEAD.
236 (refill_memory_reserve): Omit needless cast to size_t.
237 (mark_object_loop_halt): Mark as externally visible.
238
239 * xselect.c: Integer signedness and overflow fixes.
240 (Fx_register_dnd_atom, x_handle_dnd_message):
241 Use ptrdiff_t, not size_t, since we prefer signed.
242 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
243 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
244 x_dnd_atoms_size and x_dnd_atoms_length.
245
246 * doprnt.c: Prefer signed to unsigned when either works.
247 * eval.c (verror):
248 * doprnt.c (doprnt):
249 * lisp.h (doprnt):
250 * xdisp.c (vmessage):
251 Use ptrdiff_t, not size_t, when using or implementing doprnt,
252 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
253 prefer signed arithmetic to avoid comparison confusion.
254 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
255 but is a bit tricky.
256
257 Assume freestanding C89 headers, string.h, stdlib.h.
258 * data.c, doprnt.c, floatfns.c, print.c:
259 Include float.h unconditionally.
260 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
261 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
262 * regex.c: Likewise for stddef.h, string.h.
263 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
264 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
265 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
266 (STDC_HEADERS): Remove obsolete defines.
267 * sysdep.c: Include limits.h unconditionally.
268
269 Assume support for memcmp, memcpy, memmove, memset.
270 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
271 * regex.c (memcmp, memcpy):
272 Remove; we assume C89 now.
273
274 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
275 (__malloc_safe_bcopy): Remove; no longer needed.
276
277 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
278 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
279 well either way, and we prefer signed to unsigned.
280
281 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
282
283 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
284 This works around a problem with the previous change to Fcopy_file.
285 Recent glibc declares fchown with __attribute__((warn_unused_result)),
286 and without this change, GCC might complain about discarding
287 fchown's return value.
288
289 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
290
291 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
292
293 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
294
295 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
296
297 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
298
299 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
300 it's used from the C level.
301
302 * process.c: Use the same condition for POLL_FOR_INPUT in both
303 keyboard.c and process.c (bug#1858).
304
305 2011-07-09 Lawrence Mitchell <wence@gmx.li>
306
307 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
308 (Fgnutls_boot): Use it.
309
310 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
311
312 * doc.c (Fsubstitute_command_keys): Revert last change.
313
314 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
315
316 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
317 quotes the next character, and doesn't affect other longer
318 sequences (bug#8935).
319
320 * lread.c (syms_of_lread): Clarify that is isn't only
321 `eval-buffer' and `eval-defun' that's affected by
322 `lexical-binding' (bug#8460).
323
324 2011-07-15 Eli Zaretskii <eliz@gnu.org>
325
326 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
327 bidi redisplay when a line includes both an image and is
328 truncated.
329
330 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
331
332 Fix minor problems found by static checking.
333 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
334 (elsz): Now a signed constant, not a size_t var. We prefer signed
335 types to unsigned, to avoid integer comparison confusion. Without
336 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
337 "cannot optimize loop, the loop counter may overflow", a symptom
338 of the confusion.
339 * indent.c (Fvertical_motion): Mark locals as initialized.
340 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
341
342 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
343
344 * search.c (Fre_search_backward): Mention `case-fold-search' in
345 all the re_search_* functions (bug#8138).
346
347 * keyboard.c (Fopen_dribble_file): Document when the file is
348 closed (bug#8056).
349
350 2011-07-14 Eli Zaretskii <eliz@gnu.org>
351
352 * bidi.c (bidi_dump_cached_states): Fix format of displaying
353 bidi_cache_idx.
354
355 Support bidi reordering of display and overlay strings.
356 * xdisp.c (compute_display_string_pos)
357 (compute_display_string_end): Accept additional argument STRING.
358 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
359 (reseat_to_string): Initialize bidi_it->string.s and
360 bidi_it->string.schars.
361 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
362 NULL (avoids a crash in bidi_paragraph_init). Initialize
363 itb.string.lstring.
364 (init_iterator): Call bidi_init_it only of a valid
365 buffer position was specified. Initialize paragraph_embedding to
366 L2R.
367 (reseat_to_string): Initialize the bidi iterator.
368 (display_string): If we need to ignore text properties of
369 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
370 original value of -1 will not work with bidi.)
371 (compute_display_string_pos): First arg is now struct
372 `text_pos *'; all callers changed. Support display properties on
373 Lisp strings.
374 (compute_display_string_end): Support display properties on Lisp
375 strings.
376 (init_iterator, reseat_1, reseat_to_string): Initialize the
377 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
378 when iterating on a string not from display properties).
379 (compute_display_string_pos, compute_display_string_end): Fix
380 calculation of the object to scan. Fixes an error when using
381 arrow keys.
382 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
383 base_level_stop; instead, set base_level_stop to BEGV. Fixes
384 crashes in vertical-motion.
385 (next_element_from_buffer): Improve commentary for when
386 the iterator is before prev_stop.
387 (init_iterator): Initialize bidi_p from the default value of
388 bidi-display-reordering, not from buffer-local value. Use the
389 buffer-local value only if initializing for buffer iteration.
390 (handle_invisible_prop): Support invisible properties on strings
391 that are being bidi-reordered.
392 (set_iterator_to_next): Support bidi reordering of C strings and
393 Lisp strings.
394 (next_element_from_string): Support bidi reordering of Lisp
395 strings.
396 (handle_stop_backwards): Support Lisp strings as well.
397 (display_string): Support display of R2L glyph rows. Use
398 IT_STRING_CHARPOS when displaying from a Lisp string.
399 (init_iterator): Don't initialize it->bidi_p for strings
400 here.
401 (reseat_to_string): Initialize it->bidi_p for strings here.
402 (next_element_from_string, next_element_from_c_string)
403 (next_element_from_buffer): Add xassert's for correspondence
404 between IT's object being iterated and it->bidi_it.string
405 structure.
406 (face_before_or_after_it_pos): Support bidi iteration.
407 (next_element_from_c_string): Handle the case of the first string
408 character that is not the first one in the visual order.
409 (get_visually_first_element): New function, refactored from common
410 parts of next_element_from_buffer, next_element_from_string, and
411 next_element_from_c_string.
412 (tool_bar_lines_needed, redisplay_tool_bar)
413 (display_menu_bar): Force left-to-right direction. Add a FIXME
414 comment for making that be controlled by a user option.
415 (push_it, pop_it): Save and restore the state of the
416 bidi iterator. Save and restore the bidi_p flag.
417 (pop_it): Iterate out of display property for string iteration as
418 well.
419 (iterate_out_of_display_property): Support iteration over strings.
420 (handle_single_display_spec): Set up it->bidi_it for iteration
421 over a display string, and call bidi_init_it.
422 (handle_single_display_spec, next_overlay_string)
423 (get_overlay_strings_1, push_display_prop): Set up the bidi
424 iterator for displaying display or overlay strings.
425 (forward_to_next_line_start): Don't use the shortcut if
426 bidi-iterating.
427 (back_to_previous_visible_line_start): If handle_display_prop
428 pushed the iterator stack, restore the internal state of the bidi
429 iterator by calling bidi_pop_it same number of times.
430 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
431 and we are bidi-iterating, don't decrement the iterator position;
432 instead, set the first_elt flag in the bidi iterator, to produce
433 the same effect.
434 (reseat_1): Remove redundant setting of string_from_display_prop_p.
435 (push_display_prop): xassert that we are iterating a buffer.
436 (push_it, pop_it): Save and restore paragraph_embedding member.
437 (handle_single_display_spec, next_overlay_string)
438 (get_overlay_strings_1, reseat_1, reseat_to_string)
439 (push_display_prop): Set up the `unibyte' member of bidi_it.string
440 correctly. Don't assume unibyte strings are not bidi-reordered.
441 (compute_display_string_pos)
442 (compute_display_string_end): Fix handling the case of C string.
443 (push_it, pop_it): Save and restore from_disp_prop_p.
444 (handle_single_display_spec, push_display_prop): Set the
445 from_disp_prop_p flag.
446 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
447 (pop_it): Call iterate_out_of_display_property only if we are
448 popping after iteration over a string that came from a display
449 property. Fix a typo in popping stretch info. Add an assertion
450 for verifying that the iterator position is in sync with the bidi
451 iterator.
452 (handle_single_display_spec, get_overlay_strings_1)
453 (push_display_prop): Fix initialization of paragraph direction for
454 string when that of the parent object is not yet determined.
455 (reseat_1): Call bidi_init_it to resync the bidi
456 iterator with IT's position. (Bug#7616)
457 (find_row_edges): If ROW->start.pos gives position
458 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
459 (handle_stop, back_to_previous_visible_line_start, reseat_1):
460 Reset the from_disp_prop_p flag.
461 (SAVE_IT, RESTORE_IT): New macros.
462 (pos_visible_p, face_before_or_after_it_pos)
463 (back_to_previous_visible_line_start)
464 (move_it_in_display_line_to, move_it_in_display_line)
465 (move_it_to, move_it_vertically_backward, move_it_by_lines)
466 (try_scrolling, redisplay_window, display_line): Use them when
467 saving a temporary copy of the iterator and restoring it back.
468 (back_to_previous_visible_line_start, reseat_1)
469 (init_iterator): Empty the bidi cache "stack".
470 (move_it_in_display_line_to): If iterator ended up at
471 EOL, but we never saw any buffer positions smaller than
472 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
473 motion in bidi-reordered lines.
474 (move_it_in_display_line_to): Record prev_method and prev_pos
475 immediately before the call to set_iterator_to_next. Fixes cursor
476 motion in bidi-reordered lines with stretch glyphs and strings
477 displayed in margins. (Bug#8133) (Bug#8867)
478 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
479 TO_CHARPOS.
480 (pos_visible_p): Support positions in bidi-reordered lines. Save
481 and restore bidi cache.
482
483 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
484 (bidi_paragraph_info): Delete unused struct.
485 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
486 (bidi_cache_start): New variable.
487 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
488 to zero.
489 (bidi_cache_fetch_state, bidi_cache_search)
490 (bidi_cache_find_level_change, bidi_cache_iterator_state)
491 (bidi_cache_find, bidi_peek_at_next_level)
492 (bidi_level_of_next_char, bidi_find_other_level_edge)
493 (bidi_move_to_visually_next): Compare cache index with
494 bidi_cache_start rather than with zero.
495 (bidi_fetch_char): Accept new argument STRING; all callers
496 changed. Support iteration over a string. Support strings with
497 display properties. Support unibyte strings. Fix the type of
498 `len' according to what STRING_CHAR_AND_LENGTH expects.
499 (bidi_paragraph_init, bidi_resolve_explicit_1)
500 (bidi_resolve_explicit, bidi_resolve_weak)
501 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
502 iteration over a string.
503 (bidi_set_sor_type, bidi_resolve_explicit_1)
504 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
505 can now be zero (for strings); special values 0 and -1 were
506 changed to -1 and -2, respectively.
507 (bidi_char_at_pos): New function.
508 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
509 Call it instead of FETCH_MULTIBYTE_CHAR.
510 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
511 initialized to valid values.
512 (bidi_init_it): Don't initialize charpos and bytepos with invalid
513 values.
514 (bidi_level_of_next_char): Allow the sentinel "position" to pass
515 the test for valid cached positions. Fix the logic for looking up
516 the sentinel state in the cache. GCPRO the Lisp string we are
517 iterating.
518 (bidi_push_it, bidi_pop_it): New functions.
519 (bidi_initialize): Initialize the bidi cache start stack pointer.
520 (bidi_cache_ensure_space): New function, refactored from part of
521 bidi_cache_iterator_state. Don't assume the required size is just
522 one BIDI_CACHE_CHUNK away.
523 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
524 (bidi_count_bytes, bidi_char_at_pos): New functions.
525 (bidi_cache_search): Don't assume bidi_cache_last_idx is
526 always valid if bidi_cache_idx is valid.
527 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
528 is valid if it's going to be used.
529 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
530 (bidi_cache_fetch_state, bidi_cache_search)
531 (bidi_cache_find_level_change, bidi_cache_ensure_space)
532 (bidi_cache_iterator_state, bidi_cache_find)
533 (bidi_find_other_level_edge, bidi_cache_start_stack): All
534 variables related to cache indices are now EMACS_INT.
535
536 * dispextern.h (struct bidi_string_data): New structure.
537 (struct bidi_it): New member `string'. Make flag members be 1-bit
538 fields, and put them last in the struct.
539 (compute_display_string_pos, compute_display_string_end): Update
540 prototypes.
541 (bidi_push_it, bidi_pop_it): Add prototypes.
542 (struct iterator_stack_entry): New members bidi_p,
543 paragraph_embedding, and from_disp_prop_p.
544 (struct it): Member bidi_p is now a bit field 1 bit wide.
545 (bidi_shelve_cache, bidi_unshelve_cache): Declare
546 prototypes.
547
548 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
549 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
550 and vector-like objects.
551
552 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
553 cache around display iteration.
554
555 * window.c (Fwindow_end, window_scroll_pixel_based)
556 (displayed_window_lines, Frecenter): Save and restore the bidi
557 cache around display iteration.
558
559 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
560
561 * editfns.c (Fdelete_region): Clarify the use of the named
562 parameters (bug#6788).
563
564 2011-07-14 Martin Rudalics <rudalics@gmx.at>
565
566 * indent.c (Fvertical_motion): Set and restore w->pointm when
567 saving and restoring the window's buffer (Bug#9006).
568
569 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
570
571 * editfns.c (Fstring_to_char): Clarify just what is returned
572 (bug#6576). Text by Eli Zaretskii.
573
574 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
575
576 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
577
578 2011-07-13 Eli Zaretskii <eliz@gnu.org>
579
580 * buffer.c (mmap_find): Fix a typo.
581
582 2011-07-13 Johan Bockgård <bojohan@gnu.org>
583
584 Fix execution of x selection hooks.
585 * xselect.c (Qx_lost_selection_functions)
586 (Qx_sent_selection_functions): New vars.
587 (syms_of_xselect): DEFSYM them.
588 (x_handle_selection_request): Pass Qx_sent_selection_functions
589 rather than Vx_sent_selection_functions to Frun_hook_with_args.
590 (x_handle_selection_clear,x_clear_frame_selections):
591 Pass Qx_lost_selection_functions rather than
592 Vx_lost_selection_functions to Frun_hook_with_args.
593
594 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
595
596 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
597 The old code sometimes used this field without initializing it.
598
599 * alloc.c (gc_sweep): Don't read past end of array.
600 In theory, the old code could also have corrupted Emacs internals,
601 though it'd be very unlikely.
602
603 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
604
605 * character.c (Fcharacterp): Don't advertise optional ignored
606 argument. (Bug#4026)
607
608 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
609
610 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
611 key" (bug#4257).
612
613 * window.c (Fset_window_start): Doc fix (bug#4199).
614 (Fset_window_hscroll): Ditto.
615
616 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
617
618 Fix minor new problems caught by GCC 4.6.1.
619 * term.c (init_tty): Remove unused local.
620 * xsettings.c (store_monospaced_changed): Define this function only
621 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
622 not used otherwise.
623
624 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
625
626 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
627
628 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
629
630 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
631 are the mini-buffer and the echo area (bug#3320).
632
633 * term.c (init_tty): Remove support for supdup, c10 and perq
634 terminals, which are no longer supported (bug#1482).
635
636 2011-07-10 Johan Bockgård <bojohan@gnu.org>
637
638 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
639
640 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
641
642 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
643 for non-popups (Bug#3642).
644
645 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
646
647 * alloc.c (reset_malloc_hooks): Protoize.
648 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
649 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
650 * cm.c (losecursor): Likewise.
651 * data.c (fmod): Likewise.
652 * dispnew.c (swap_glyphs_in_rows): Likewise.
653 * emacs.c (memory_warning_signal): Likewise.
654 * floatfns.c (float_error): Likewise.
655 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
656 (otf_open, font_otf_capability, generate_otf_features)
657 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
658 Likewise.
659 * image.c (pbm_read_file): Likewise.
660 * indent.c (string_display_width): Likewise.
661 * intervals.c (check_for_interval, search_for_interval)
662 (inc_interval_count, count_intervals, root_interval)
663 (adjust_intervals_for_insertion, make_new_interval): Likewise.
664 * lread.c (defalias): Likewise.
665 * ralloc.c (r_alloc_check): Likewise.
666 * regex.c (set_image_of_range_1, set_image_of_range)
667 (regex_grow_registers): Likewise.
668 * sysdep.c (strerror): Likewise.
669 * termcap.c (valid_filename_p, tprint, main): Likewise.
670 * tparam.c (main): Likewise.
671 * unexhp9k800.c (run_time_remap, save_data_space)
672 (update_file_ptrs, read_header, write_header, calculate_checksum)
673 (copy_file, copy_rest, display_header): Likewise.
674 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
675 Likewise.
676 * xdisp.c (check_it): Likewise.
677 * xfaces.c (register_color, unregister_color, unregister_colors):
678 Likewise.
679 * xfns.c (print_fontset_result): Likewise.
680 * xrdb.c (member, fatal, main): Likewise.
681
682 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
683
684 Fix minor problems found by static checking (Bug#9031).
685 * chartab.c (char_table_set_range, map_sub_char_table):
686 Remove unused locals.
687 (uniprop_table): Now static.
688 * composite.c (_work_char): Remove unused static var.
689
690 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
691
692 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
693
694 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
695
696 * gtkutil.c (qttip_cb): Remove code without function.
697
698 2011-07-09 Eli Zaretskii <eliz@gnu.org>
699
700 * w32.c (pthread_sigmask): New stub.
701
702 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
703
704 Use pthread_sigmask, not sigprocmask (Bug#9010).
705 sigprocmask is portable only for single-threaded applications, and
706 Emacs can be multi-threaded when it uses GTK.
707 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
708 (LIBES): Use it.
709 * callproc.c (Fcall_process):
710 * process.c (create_process):
711 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
712 Use pthread_sigmask, not sigprocmask.
713
714 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
715
716 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
717 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
718 wrong (Bug#8591).
719
720 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
721
722 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
723 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
724 (xg_hide_tooltip): Fix comment.
725
726 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
727 in registerServicesMenuSendTypes.
728 (validRequestorForSendType): Don't check ns_return_types.
729
730 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
731 ns_return_type.
732
733 2011-07-08 Jason Rumney <jasonr@gnu.org>
734
735 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
736 frame struct members of non-existent frames (Bug#6284).
737
738 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
739
740 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
741 variable firstTime not needed on OSX >= 10.6.
742 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
743 >= 10.5. Use setKnobProportion, setDoubleValue.
744
745 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
746 (MAC_OS_X_VERSION_10_5): Define if not defined.
747 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
748 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
749 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
750
751 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
752 cString and lossyCString on OSX >= 10.4
753
754 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
755 sizeToFit on OSX >= 10.2.
756
757 * nsimage.m (allocInitFromFile): Don't use deprecated method
758 bestRepresentationForDevice on OSX >= 10.6.
759
760 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
761 to avoid warning.
762
763 * emacs.c: Declare unexec_init_emacs_zone.
764
765 * nsgui.h: Fix compiler warning about gnulib redefining verify.
766
767 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
768
769 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
770 on svcsMenu (Bug#8842).
771
772 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
773 ns_return_types.
774 (Fns_list_services): Just return Qnil on 10.6, code not working there.
775
776 * nsterm.m (QUTF8_STRING): Declare.
777 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
778 (validRequestorForSendType): Return type is (id).
779 Change indexOfObjectIdenticalTo to indexOfObject.
780 Check if we have local selection before returning self (Bug#8842).
781 (writeSelectionToPasteboard): Put local selection into paste board
782 if we have a local selection (Bug#8842).
783 (syms_of_nsterm): DEFSYM QUTF8_STRING.
784
785 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
786 (ns_get_local_selection): Declare.
787
788 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
789
790 * keymap.c (describe_map_tree): Don't insert a double newline at
791 the end of the buffer (bug#1169) and return whether we inserted
792 something.
793
794 * callint.c (Fcall_interactively): Change "reading args" to
795 "providing args" to try to clarify what it does (bug#1010).
796
797 2011-07-07 Kenichi Handa <handa@m17n.org>
798
799 * composite.c (composition_compute_stop_pos): Ignore a static
800 composition starting before CHARPOS (Bug#8915).
801
802 * xdisp.c (handle_composition_prop): Likewise.
803
804 2011-07-07 Eli Zaretskii <eliz@gnu.org>
805
806 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
807 (Bug#9015)
808
809 2011-07-07 Kenichi Handa <handa@m17n.org>
810
811 * character.h (unicode_category_t): New enum type.
812
813 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
814 (Qchar_code_property_table): New variable.
815 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
816 (UNIPROP_COMPRESSED_FORM_P): New macros.
817 (char_table_ascii): Uncompress the compressed values.
818 (sub_char_table_ref): New arg is_uniprop. Callers changed.
819 Uncompress the compressed values.
820 (sub_char_table_ref_and_range): Likewise.
821 (char_table_ref_and_range): Uncompress the compressed values.
822 (sub_char_table_set): New arg is_uniprop. Callers changed.
823 Uncompress the compressed values.
824 (sub_char_table_set_range): Args changed. Callers changed.
825 (char_table_set_range): Adjuted for the above change.
826 (map_sub_char_table): Delete args default_val and parent. Add arg
827 top. Give decoded values to a Lisp function.
828 (map_char_table): Adjusted for the above change. Give decoded
829 values to a Lisp function. Gcpro more variables.
830 (uniprop_table_uncompress)
831 (uniprop_decode_value_run_length): New functions.
832 (uniprop_decoder, uniprop_decoder_count): New variables.
833 (uniprop_get_decoder, uniprop_encode_value_character)
834 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
835 New functions.
836 (uniprop_encoder, uniprop_encoder_count): New variables.
837 (uniprop_get_encoder, uniprop_table)
838 (Funicode_property_table_internal, Fget_unicode_property_internal)
839 (Fput_unicode_property_internal): New functions.
840 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
841 Sunicode_property_table_internal, Sget_unicode_property_internal,
842 and Sput_unicode_property_internal. Defvar_lisp
843 char-code-property-alist.
844
845 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
846 Vunicode_category_table.
847
848 * font.c (font_range): Adjusted for the change of
849 Vunicode_category_table.
850
851 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
852
853 * m/iris4d.h: Remove file, move contents ...
854 * s/irix6-5.h: ... here.
855
856 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
857
858 Remove unportable assumption about struct layout (Bug#8884).
859 * alloc.c (mark_buffer):
860 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
861 (clone_per_buffer_values): Don't assume that
862 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
863 This isn't true in general, and it's particularly not true
864 if Emacs is configured with --with-wide-int.
865 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
866 New macros, used in the buffer.c change.
867
868 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
869
870 * xsettings.c: Use both GConf and GSettings if both are available.
871 (store_config_changed_event): Add comment.
872 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
873 (store_tool_bar_style_changed): New functions.
874 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
875 (struct xsettings): Move font inside HAVE_XFT.
876 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
877 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
878 Move inside HAVE_XFT.
879 (something_changed_gsettingsCB): Renamed from something_changedCB.
880 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
881 also.
882 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
883 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
884 (something_changed_gconfCB): Renamed from something_changedCB.
885 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
886 (parse_settings): Move check for font inside HAVE_XFT.
887 (read_settings, apply_xft_settings): Add comment.
888 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
889 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
890 call store_font_name_changed.
891 (xft_settings_event): Add comment.
892 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
893 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
894 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
895 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
896 (xsettings_initialize): Call init_gsettings last.
897 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
898 comment.
899
900 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
901
902 Random fixes. E.g., (random) never returned negative values.
903 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
904 subseconds part to the entropy, as that's a bit more random.
905 Prefer signed to unsigned, since the signedness doesn't matter and
906 in general we prefer signed. When given a limit, use a
907 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
908 latter isn't right if USE_2_TAGS_FOR_INTS.
909 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
910 not 0..VALMASK. Don't discard "excess" bits that random () returns.
911
912 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
913
914 * textprop.c (text_property_stickiness):
915 Obey Vtext_property_default_nonsticky.
916 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
917 * w32fns.c (syms_of_w32fns):
918 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
919
920 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
921
922 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
923 This is more efficient than Ffile_directory_p and avoids a minor race.
924
925 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
926
927 * buffer.c (Foverlay_put): Say what the return value is
928 (bug#7835).
929
930 * fileio.c (barf_or_query_if_file_exists): Check first if the file
931 is a directory before asking whether to use the file name
932 (bug#7564).
933 (barf_or_query_if_file_exists): Make the "File is a directory"
934 error be more correct.
935
936 * fns.c (Frequire): Remove the mention of the .gz files, since
937 that's installation-specific, but keep the mention of
938 `get-load-suffixes'.
939
940 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
941
942 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
943 Report string overflow if the output is too long.
944
945 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
946
947 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
948 (syms_of_gnutls): Remove duplicate DEFSYM for
949 Qgnutls_bootprop_verify_hostname_error, an error for
950 Qgnutls_bootprop_verify_error (which is no longer used).
951
952 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
953 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
954 Also (re)move comments that are misplaced or no longer relevant.
955
956 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
957
958 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
959
960 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
961
962 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
963 and background color parameters if they have been changed.
964
965 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
966
967 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
968
969 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
970
971 * xsettings.c (SYSTEM_FONT): Define only when used.
972 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
973
974 * keymap.c (access_keymap_1): Now static.
975
976 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
977
978 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
979 leave any prefix arg for the up event (Bug#1586).
980
981 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
982
983 * lread.c (syms_of_lread): Mention single symbols defined by
984 `defvar' or `defconst' (bug#7154).
985
986 * fns.c (Frequire): Mention .el.gz files (bug#7314).
987 (Frequire): Mention get-load-suffixes.
988
989 2011-07-02 Martin Rudalics <rudalics@gmx.at>
990
991 * window.h (window): Remove clone_number slot.
992 * window.c (Fwindow_clone_number, Fset_window_clone_number):
993 Remove.
994 (make_parent_window, make_window, saved_window)
995 (Fset_window_configuration, save_window_save): Don't deal with
996 clone numbers.
997 * buffer.c (Qclone_number): Remove declaration.
998 (sort_overlays, overlay_strings): Don't deal with clone numbers.
999
1000 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1001
1002 Add multiple inheritance to keymaps.
1003 * keymap.c (Fmake_composed_keymap): New function.
1004 (Fset_keymap_parent): Simplify.
1005 (fix_submap_inheritance): Remove.
1006 (access_keymap_1): New function extracted from access_keymap to handle
1007 embedded parents and handle lists of maps.
1008 (access_keymap): Use it.
1009 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1010 (Fcopy_keymap): Handle embedded parents.
1011 (Fcommand_remapping, define_as_prefix): Simplify.
1012 (Fkey_binding): Simplify.
1013 (syms_of_keymap): Move minibuffer-local-completion-map,
1014 minibuffer-local-filename-completion-map,
1015 minibuffer-local-must-match-map, and
1016 minibuffer-local-filename-must-match-map to Elisp.
1017 (syms_of_keymap): Defsubr make-composed-keymap.
1018 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1019 (parse_menu_item): Trivial simplification.
1020
1021 2011-07-01 Glenn Morris <rgm@gnu.org>
1022
1023 * Makefile.in (SETTINGS_LIBS): Fix typo.
1024
1025 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1026
1027 * coding.c (Fencode_coding_string): Record the last coding system
1028 used, as the function doc string says (bug#8738).
1029
1030 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1031
1032 * xsettings.c (store_monospaced_changed): Take new font as arg and
1033 check for change against current_mono_font.
1034 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1035 (emacs_settings_constructor, emacs_settings_get_property)
1036 (emacs_settings_set_property, emacs_settings_class_init)
1037 (emacs_settings_init, gsettings_obj): Remove.
1038 (something_changedCB): New function for HAVE_GSETTINGS.
1039 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1040 with value as argument.
1041 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1042 g_settings_new (Bug#8967). Do not create gsettings_obj.
1043 Remove calls to g_settings_bind. Connect something_changedCB to
1044 "changed".
1045
1046 * xgselect.c: Add defined (HAVE_GSETTINGS).
1047 (xgselect_initialize): Ditto.
1048
1049 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1050 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1051 xg_select.
1052
1053 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1054
1055 * eval.c (struct backtrace): Simplify and port the data structure.
1056 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1057 signed bit field, as this assumption is not portable and it makes
1058 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1059 "char debug_on_exit : 1" as this is not portable either; instead,
1060 use the portable "unsigned int debug_on_exit : 1". Remove unused
1061 member evalargs. Remove obsolete comments about cc bombing out.
1062
1063 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1064
1065 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1066 Let HAVE_GSETTINGS override HAVE_GCONF.
1067 (store_monospaced_changed): New function.
1068 (EMACS_SETTINGS): A new type derived from GObject to handle
1069 GSettings notifications.
1070 (emacs_settings_constructor, emacs_settings_get_property)
1071 (emacs_settings_set_property, emacs_settings_class_init):
1072 New functions.
1073 (gsettings_client, gsettings_obj): New variables.
1074 (GSETTINGS_SCHEMA): New define.
1075 (something_changedCB): Call store_monospaced_changed.
1076 (init_gsettings): New function.
1077 (xsettings_initialize): Call init_gsettings.
1078 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1079 to NULL.
1080
1081 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1082 GCONF_CFLAGS/LIBS.
1083
1084 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1085
1086 * window.c (resize_root_window, grow_mini_window)
1087 (shrink_mini_window): Rename Qresize_root_window to
1088 Qwindow_resize_root_window and Qresize_root_window_vertically to
1089 Qwindow_resize_root_window_vertically.
1090
1091 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1092
1093 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1094
1095 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1096
1097 * makefile.w32-in: Redesign dependencies so they reflect more
1098 clearly which files are directly included by each source file,
1099 and not through other includes.
1100
1101 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1102
1103 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1104 (sort_overlays, overlay_strings): When an overlay's clone number
1105 matches the window's clone number process the overlay even if
1106 the overlay's window property doesn't match the current window.
1107
1108 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1109 (Fwindow_hchild): Rename to Fwindow_left_child.
1110 (Fwindow_next): Rename to Fwindow_next_sibling.
1111 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1112 (resize_window_check): Rename to window_resize_check.
1113 (resize_window_apply): Rename to window_resize_apply.
1114 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1115 (Fdelete_other_windows_internal, resize_frame_windows)
1116 (Fsplit_window_internal, Fdelete_window_internal)
1117 (grow_mini_window, shrink_mini_window)
1118 (Fresize_mini_window_internal): Fix callers accordingly.
1119
1120 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1121
1122 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1123 (emacs_fixed_set_min_size): Remove.
1124 (emacs_fixed_new): Take frame as argument.
1125
1126 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1127 (_EmacsFixedPrivate): Remove minwidth/height.
1128 Add struct frame *f.
1129 (emacs_fixed_init): Initialize priv->f.
1130 (get_parent_class, emacs_fixed_set_min_size): Remove.
1131 (emacs_fixed_new): Set priv->f to argument.
1132 (emacs_fixed_get_preferred_width)
1133 (emacs_fixed_get_preferred_height): Use min_width/height from
1134 frames size_hint to set minimum and natural (Bug#8919).
1135 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1136 and use min_width/height from frames size_hint to set
1137 min_width/height (Bug#8919).
1138
1139 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1140 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1141 Fix indentation.
1142
1143 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1144
1145 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1146 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1147 called at ZV.
1148
1149 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1150
1151 * process.c (wait_reading_process_output): Bypass select if
1152 waiting for a cell while ignoring keyboard input, and input is
1153 pending. Suggested by Jan Djärv (Bug#8869).
1154
1155 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 Use gnulib's dup2 module instead of rolling our own.
1158 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1159
1160 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1161
1162 * dispnew.c (scrolling_window): Before scrolling, turn off a
1163 mouse-highlight in the window being scrolled.
1164
1165 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1166
1167 Move DEFSYM to lisp.h and use everywhere.
1168
1169 * character.h (DEFSYM): Move declaration...
1170 * lisp.h (DEFSYM): ...here.
1171
1172 * gnutls.c:
1173 * minibuf.c:
1174 * w32menu.c:
1175 * w32proc.c:
1176 * w32select.c: Don't include character.h.
1177
1178 * alloc.c (syms_of_alloc):
1179 * buffer.c (syms_of_buffer):
1180 * bytecode.c (syms_of_bytecode):
1181 * callint.c (syms_of_callint):
1182 * casefiddle.c (syms_of_casefiddle):
1183 * casetab.c (init_casetab_once):
1184 * category.c (init_category_once, syms_of_category):
1185 * ccl.c (syms_of_ccl):
1186 * cmds.c (syms_of_cmds):
1187 * composite.c (syms_of_composite):
1188 * dbusbind.c (syms_of_dbusbind):
1189 * dired.c (syms_of_dired):
1190 * dispnew.c (syms_of_display):
1191 * doc.c (syms_of_doc):
1192 * editfns.c (syms_of_editfns):
1193 * emacs.c (syms_of_emacs):
1194 * eval.c (syms_of_eval):
1195 * fileio.c (syms_of_fileio):
1196 * fns.c (syms_of_fns):
1197 * frame.c (syms_of_frame):
1198 * fringe.c (syms_of_fringe):
1199 * insdel.c (syms_of_insdel):
1200 * keymap.c (syms_of_keymap):
1201 * lread.c (init_obarray, syms_of_lread):
1202 * macros.c (syms_of_macros):
1203 * msdos.c (syms_of_msdos):
1204 * print.c (syms_of_print):
1205 * process.c (syms_of_process):
1206 * search.c (syms_of_search):
1207 * sound.c (syms_of_sound):
1208 * syntax.c (init_syntax_once, syms_of_syntax):
1209 * terminal.c (syms_of_terminal):
1210 * textprop.c (syms_of_textprop):
1211 * undo.c (syms_of_undo):
1212 * w32.c (globals_of_w32):
1213 * window.c (syms_of_window):
1214 * xdisp.c (syms_of_xdisp):
1215 * xfaces.c (syms_of_xfaces):
1216 * xfns.c (syms_of_xfns):
1217 * xmenu.c (syms_of_xmenu):
1218 * xsettings.c (syms_of_xsettings):
1219 * xterm.c (syms_of_xterm): Use DEFSYM.
1220
1221 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1222
1223 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1224
1225 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 Integer and buffer overflow fixes (Bug#8873).
1228
1229 * print.c (printchar, strout): Check for string overflow.
1230 (PRINTPREPARE, printchar, strout):
1231 Don't set size unless allocation succeeds.
1232
1233 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1234 for sizes. Check for string overflow more accurately.
1235 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1236
1237 * macros.c: Integer and buffer overflow fixes.
1238 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1239 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1240 Use ptrdiff_t, not int, for sizes.
1241 Don't increment bufsize until after realloc succeeds.
1242 Check for size-calculation overflow.
1243 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1244
1245 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1246
1247 * lread.c: Integer overflow fixes.
1248 (read_integer): Radix is now EMACS_INT, not int,
1249 to improve quality of diagnostics for out-of-range radices.
1250 Calculate buffer size correctly for out-of-range radices.
1251 (read1): Check for integer overflow in radices, and in
1252 read-circle numbers.
1253 (read_escape): Avoid int overflow.
1254 (Fload, openp, read_buffer_size, read1)
1255 (substitute_object_recurse, read_vector, read_list, map_obarray):
1256 Use ptrdiff_t, not int, for sizes.
1257 (read1): Use EMACS_INT, not int, for sizes.
1258 Check for size overflow.
1259
1260 * image.c (cache_image): Check for size arithmetic overflow.
1261
1262 * lread.c: Integer overflow issues.
1263 (saved_doc_string_size, saved_doc_string_length)
1264 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1265 Now ptrdiff_t, not int.
1266 (read1): Don't assume doc string length fits in int. Check for
1267 out-of-range doc string lengths.
1268 (read_list): Don't assume file position fits in int.
1269 (read_escape): Check for hex character overflow.
1270
1271 2011-06-22 Leo Liu <sdl.web@gmail.com>
1272
1273 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1274 Move to minibuffer.el.
1275
1276 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1277
1278 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1279 The following patches are for when GLYPH_DEBUG && !XASSERT.
1280 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1281 * dispnew.c (flush_stdout):
1282 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1283 Mark as externally visible.
1284 * dispnew.c (check_window_matrix_pointers): Now static.
1285 * dispnew.c (window_to_frame_vpos):
1286 * xfns.c (unwind_create_frame):
1287 * xterm.c (x_check_font): Remove unused local.
1288 * scroll.c (CHECK_BOUNDS):
1289 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1290 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1291 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1292 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1293 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1294 Now static.
1295 (debug_method_add): Use va_list and vsprintf rather than relying
1296 on undefined behavior with wrong number of arguments.
1297 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1298 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1299 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1300 since we're not interested in debugging glyphs with old libraries.
1301 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1302 GCC 4.6.0's static checking.
1303
1304 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1305
1306 Integer overflow and signedness fixes (Bug#8873).
1307 A few related buffer overrun fixes, too.
1308
1309 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1310
1311 * dispextern.h (struct face.stipple):
1312 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1313 (x_bitmap_mask, x_allocate_bitmap_record)
1314 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1315 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1316 (x_create_bitmap_from_xpm_data):
1317 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1318 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1319 (.bitmaps_last):
1320 * xfaces.c (load_pixmap):
1321 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1322 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1323 (.bitmaps_last, struct x_output.icon_bitmap):
1324 Use ptrdiff_t, not int, for bitmap indexes.
1325 (x_allocate_bitmap_record): Check for size overflow.
1326 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1327
1328 Use ptrdiff_t, not int, for overlay counts.
1329 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1330 * editfns.c (overlays_around, get_pos_property):
1331 * textprop.c (get_char_property_and_overlay):
1332 * xdisp.c (next_overlay_change, note_mouse_highlight):
1333 * xfaces.c (face_at_buffer_position):
1334 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1335 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1336 (Fnext_overlay_change, Fprevious_overlay_change)
1337 (mouse_face_overlay_overlaps, Foverlays_in):
1338 Use ptrdiff_t, not int, for sizes.
1339 (overlays_at, overlays_in): Check for size-calculation overflow.
1340
1341 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1342
1343 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1344 (x_session_initialize): Do not assume string length fits in int.
1345
1346 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1347 This is unlikely, but can occur if DPI is outlandish.
1348
1349 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1350 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1351
1352 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1353 * xrdb.c (magic_file_p, search_magic_path):
1354 Omit last arg SUFFIX; it was always 0. All callers changed.
1355 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1356
1357 * xfont.c (xfont_match): Avoid need for strlen.
1358
1359 * xfns.c: Don't assume strlen fits in int.
1360 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1361
1362 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1363 not unsigned long, as we prefer signed integers. All callers changed.
1364 Detect integer overflow in repeat count.
1365 (message_dolog): Don't assume print length fits in 39 bytes.
1366 (display_mode_element): Don't assume strlen fits in int.
1367
1368 * termcap.c: Don't assume sizes fit in int and never overflow.
1369 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1370 (gobble_line): Check for size-calculation overflow.
1371
1372 * minibuf.c (Fread_buffer):
1373 * lread.c (intern, intern_c_string):
1374 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1375 Don't assume string length fits in int.
1376
1377 * keyboard.c (parse_tool_bar_item):
1378 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1379
1380 * font.c: Don't assume string length fits in int.
1381 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1382 Use ptrdiff_t, not int.
1383 (font_intern_prop): Don't assume string length fits in int.
1384 Don't assume integer property fits in fixnum.
1385 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1386
1387 * filelock.c: Fix some buffer overrun and integer overflow issues.
1388 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1389 Reformulate so as not to need the command string.
1390 Invoke gzip -cd rather than gunzip, as it's more portable.
1391 (lock_info_type, lock_file_1, lock_file):
1392 Don't assume pid_t and time_t fit in unsigned long.
1393 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1394 (current_lock_owner): Prefer signed type for sizes.
1395 Use memcpy, not strncpy, where memcpy is what is really wanted.
1396 Don't assume (via atoi) that time_t and pid_t fit in int.
1397 Check for time_t and/or pid_t out of range, e.g., via a network share.
1398 Don't alloca where an auto var works fine.
1399
1400 * fileio.c: Fix some integer overflow issues.
1401 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1402 Don't assume string length fits in int.
1403 (directory_file_name): Don't assume string length fits in long.
1404 (make_temp_name): Don't assume pid fits in int, or that its print
1405 length is less than 20.
1406
1407 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1408
1409 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1410
1411 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1412
1413 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1414 We prefer signed integers, even for size calculations.
1415
1416 * emacs.c: Don't assume string length fits in 'int'.
1417 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1418 (main): Don't invoke strlen when not needed.
1419
1420 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1421 (XD_DEBUG_MESSAGE): Don't waste a byte.
1422
1423 * callproc.c (getenv_internal_1, getenv_internal)
1424 (Fgetenv_internal):
1425 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1426
1427 * lread.c (invalid_syntax): Omit length argument.
1428 All uses changed. This doesn't fix a bug, but it simplifies the
1429 code away from its former Hollerith-constant appearance, and it's
1430 one less 'int' to worry about when looking at integer-overflow issues.
1431 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1432
1433 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1434 This didn't break anything, but it didn't help either.
1435 It's confusing to put a bogus integer in a place where the actual
1436 value does not matter.
1437 (LIST_END_P): Remove unused macro and its bogus comment.
1438 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1439
1440 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1441 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1442 implementation.
1443 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1444 We prefer signed types, and the value cannot exceed the EMACS_INT
1445 range anyway (because otherwise the length would not be representable).
1446 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1447 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1448 This avoids a GCC warning when WIDE_EMACS_INT.
1449
1450 * indent.c (sane_tab_width): New function.
1451 (current_column, scan_for_column, Findent_to, position_indentation)
1452 (compute_motion): Use it. This is just for clarity.
1453 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1454
1455 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1456
1457 * lisp.h (lint_assume): New macro.
1458 * composite.c (composition_gstring_put_cache):
1459 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1460
1461 * editfns.c, insdel.c:
1462 Omit unnecessary forward decls, to simplify future changes.
1463
1464 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1465
1466 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1467
1468 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1469 Use much-faster test for byte-length change.
1470 Don't assume string byte-length fits in 'int'.
1471 Check that character arg fits in 'int'.
1472 (mapcar1): Declare byte as byte, for clarity.
1473
1474 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1475
1476 * fns.c (concat): Catch string overflow earlier.
1477 Do not rely on integer wraparound.
1478
1479 * dispextern.h (struct it.overlay_strings_charpos)
1480 (struct it.selective): Now EMACS_INT, not int.
1481 * xdisp.c (forward_to_next_line_start)
1482 (back_to_previous_visible_line_start)
1483 (reseat_at_next_visible_line_start, next_element_from_buffer):
1484 Don't arbitrarily truncate the value of 'selective' to int.
1485
1486 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1487
1488 * composite.c: Don't truncate sizes to 'int'.
1489 (composition_gstring_p, composition_reseat_it)
1490 (composition_adjust_point): Use EMACS_INT, not int.
1491 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1492 not EMACS_UINT, for indexes.
1493
1494 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1495
1496 * buffer.c: Include <verify.h>.
1497 (struct sortvec.priority, struct sortstr.priority):
1498 Now EMACS_INT, not int.
1499 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1500 (struct sortstr.size, record_overlay_string)
1501 (struct sortstrlist.size, struct sortlist.used):
1502 Don't truncate size to int.
1503 (record_overlay_string): Check for size-calculation overflow.
1504 (init_buffer_once): Check at compile-time, not run-time.
1505
1506 2011-06-22 Jim Meyering <meyering@redhat.com>
1507
1508 Don't leak an XBM-image-sized buffer
1509 * image.c (xbm_load): Free the image buffer after using it.
1510
1511 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 Port to Sun C.
1514 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1515 that Sun C diagnosed.
1516 * fns.c (secure_hash): Fix pointer signedness issue.
1517 * intervals.c (static_offset_intervals): New function.
1518 (offset_intervals): Use it.
1519
1520 2011-06-21 Leo Liu <sdl.web@gmail.com>
1521
1522 * deps.mk (fns.o):
1523 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1524 sha512.h.
1525
1526 * fns.c (secure_hash): Rename from crypto_hash_function and change
1527 the first arg to accept symbols.
1528 (Fsecure_hash): New primitive.
1529 (syms_of_fns): New symbols.
1530
1531 2011-06-20 Deniz Dogan <deniz@dogan.se>
1532
1533 * process.c (Fset_process_buffer): Clarify return value in
1534 docstring.
1535
1536 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1537
1538 * dispnew.c (add_window_display_history): Use BVAR.
1539
1540 * xdisp.c (debug_method_add): Use BVAR.
1541 (check_window_end, dump_glyph_matrix, dump_glyph)
1542 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1543
1544 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1545 Likewise.
1546
1547 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1548 check till after the cache is created in init_frame_faces.
1549
1550 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1551
1552 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1553
1554 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1555
1556 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1557 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1558 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1559
1560 Improve buffer-overflow checking (Bug#8873).
1561 * fileio.c (Finsert_file_contents):
1562 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1563 Remove the old (too-loose) buffer overflow checks.
1564 They weren't needed, since make_gap checks for buffer overflow.
1565 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1566 The old code merely checked for Emacs fixnum overflow, and relied
1567 on undefined (wraparound) behavior. The new code avoids undefined
1568 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1569
1570 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1571 Tune. Don't use wider integers than needed. Don't use alloca.
1572 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1573
1574 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1575
1576 * insdel.c, lisp.h (buffer_overflow): New function.
1577 (insert_from_buffer_1, replace_range, replace_range_2):
1578 * insdel.c (make_gap_larger):
1579 * editfns.c (Finsert_char):
1580 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1581
1582 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1583
1584 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1585
1586 Integer overflow and signedness fixes (Bug#8873).
1587
1588 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1589 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1590
1591 * fileio.c: Don't assume EMACS_INT fits in off_t.
1592 (emacs_lseek): New static function.
1593 (Finsert_file_contents, Fwrite_region): Use it.
1594 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1595
1596 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1597
1598 * fns.c: Don't overflow int when computing a list length.
1599 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1600 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1601 truncation on 64-bit hosts. Check for QUIT every
1602 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1603 faster and is responsive enough.
1604 (Flength): Report an error instead of overflowing an integer.
1605 (Fsafe_length): Return a float if the value is not representable
1606 as a fixnum. This shouldn't happen except in contrived situations.
1607 (Fnthcdr, Fsort): Don't assume list length fits in int.
1608 (Fcopy_sequence): Don't assume vector length fits in int.
1609
1610 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1611 (header_size, word_size): New constants.
1612 (allocate_vectorlike): Don't check size overflow here.
1613 (allocate_vector): Check it here instead, since this is the only
1614 caller of allocate_vectorlike that could cause overflow.
1615 Check that the new vector's length is representable as a fixnum.
1616
1617 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1618 The previous code was bogus. For example, next_almost_prime (32)
1619 returned 39, which is undesirable as it is a multiple of 3; and
1620 next_almost_prime (24) returned 25, which is a multiple of 5 so
1621 why was the code bothering to check for multiples of 7?
1622
1623 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1624
1625 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1626
1627 Variadic C functions now count arguments with ptrdiff_t.
1628 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1629 Back then I didn't know that the Emacs coding style prefers signed int.
1630 Also, in the meantime I found a few more instances where arguments
1631 were being counted with int, which may truncate counts on 64-bit
1632 machines, or EMACS_INT, which may be unnecessarily wide.
1633 * lisp.h (struct Lisp_Subr.function.aMANY)
1634 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1635 Arg counts are now ptrdiff_t, not size_t.
1636 All variadic functions and their callers changed accordingly.
1637 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1638 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1639 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1640 * callint.c (Fcall_interactively): Check arg count for overflow,
1641 to avoid potential buffer overrun. Use signed char, not 'int',
1642 for 'varies' array, so that we needn't bother to check its size
1643 calculation for overflow.
1644 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1645 * eval.c (apply_lambda):
1646 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1647 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1648 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1649
1650 * callint.c (Fcall_interactively): Don't use index var as event count.
1651
1652 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1653 * mem-limits.h (SIZE): Remove; no longer used.
1654
1655 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1656
1657 Remove unnecessary casts.
1658 * xterm.c (x_term_init):
1659 * xfns.c (x_set_border_pixel):
1660 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1661 These aren't needed now that we assume ANSI C.
1662
1663 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1664 It's more likely to cause problems (due to unsigned overflow)
1665 than to cure them.
1666
1667 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1668
1669 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1670
1671 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1672
1673 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1674
1675 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1676
1677 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1678
1679 GLYPH_CODE_FACE returns EMACS_INT, not int.
1680 * dispextern.h (merge_faces):
1681 * xfaces.c (merge_faces):
1682 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1683 Don't assume EMACS_INT fits in int.
1684
1685 * character.h (CHAR_VALID_P): Remove unused parameter.
1686 * fontset.c, lisp.h, xdisp.c: All uses changed.
1687
1688 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1689
1690 * fns.c (concat): Minor tuning based on overflow analysis.
1691 This doesn't fix any bugs. Use int to hold character, instead
1692 of constantly refetching from Emacs object. Use XFASTINT, not
1693 XINT, for value known to be a character. Don't bother comparing
1694 a single byte to 0400, as it's always less.
1695
1696 * floatfns.c (Fexpt):
1697 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1698
1699 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1700 for characters.
1701
1702 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1703
1704 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1705 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1706 incorrectly succeed when S was a string, because 4294967386 was
1707 truncated before it was used.
1708
1709 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1710 Otherwise, an out-of-range integer could cause undefined behavior
1711 on a 64-bit host.
1712
1713 * composite.c: Use int, not EMACS_INT, for characters.
1714 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1715 EMACS_INT, for values that are known to be in character range.
1716 This doesn't fix any bugs but is the usual style inside Emacs and
1717 may generate better code on 32-bit machines.
1718
1719 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1720 This is for reasons similar to the recent CHAR_STRING fix.
1721 * charset.c (Fencode_char): Check that character arg is actually
1722 a character. Pass an int to ENCODE_CHAR.
1723 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1724 wider than 'int', as a compile-time check to prevent future regressions
1725 in this area.
1726
1727 * character.c (char_string): Remove unnecessary casts.
1728
1729 Make sure a 64-bit char is never passed to CHAR_STRING.
1730 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1731 by silently ignoring the top 32 bits, allowing some values
1732 that were far too large to be valid characters.
1733 * character.h: Include <verify.h>.
1734 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1735 arguments are no wider than unsigned, as a compile-time check
1736 to prevent future regressions in this area.
1737 * data.c (Faset):
1738 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1739 (Fsubst_char_in_region):
1740 * fns.c (concat):
1741 * xdisp.c (decode_mode_spec_coding):
1742 Adjust to CHAR_STRING's new requirement.
1743 * editfns.c (Finsert_char, Fsubst_char_in_region):
1744 * fns.c (concat): Check that character args are actually
1745 characters. Without this test, these functions did the wrong
1746 thing with wildly out-of-range values on 64-bit hosts.
1747
1748 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1749 These casts should not be needed on 32-bit hosts, either.
1750 * keyboard.c (read_char):
1751 * lread.c (Fload): Remove casts to unsigned.
1752
1753 * lisp.h (UNSIGNED_CMP): New macro.
1754 This fixes comparison bugs on 64-bit hosts.
1755 (ASCII_CHAR_P): Use it.
1756 * casefiddle.c (casify_object):
1757 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1758 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1759 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1760 * dispextern.h (FACE_FROM_ID):
1761 * keyboard.c (read_char): Use UNSIGNED_CMP.
1762
1763 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1764 not to EMACS_INT, to avoid GCC warning.
1765
1766 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1767
1768 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1769 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1770 isn't needed on 32-bit machines.
1771
1772 * buffer.c (Fgenerate_new_buffer_name):
1773 Use EMACS_INT for count, not int.
1774 (advance_to_char_boundary): Return EMACS_INT, not int.
1775
1776 * data.c (Qcompiled_function): Now static.
1777
1778 * window.c (window_body_lines): Now static.
1779
1780 * image.c (gif_load): Rename local to avoid shadowing.
1781
1782 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1783 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1784 * alloc.c (make_save_value): Integer argument is now of type
1785 ptrdiff_t, not int.
1786 (mark_object): Use ptrdiff_t, not int.
1787 * lisp.h (pD): New macro.
1788 * print.c (print_object): Use it.
1789
1790 * alloc.c: Use EMACS_INT, not int, to count objects.
1791 (total_conses, total_markers, total_symbols, total_vector_size)
1792 (total_free_conses, total_free_markers, total_free_symbols)
1793 (total_free_floats, total_floats, total_free_intervals)
1794 (total_intervals, total_strings, total_free_strings):
1795 Now EMACS_INT, not int. All uses changed.
1796 (Fgarbage_collect): Compute overall total using a double, so that
1797 integer overflow is less likely to be a problem. Check for overflow
1798 when converting back to an integer.
1799 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1800 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1801 These were 'int' variables that could overflow on 64-bit hosts;
1802 they were never used, so remove them instead of repairing them.
1803 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1804 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1805 Previously, this ceilinged at INT_MAX, but that doesn't work on
1806 64-bit machines.
1807 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1808
1809 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1810 (allocate_vectorlike): Check for ptrdiff_t overflow.
1811 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1812 when a (possibly-narrower) signed value would do just as well.
1813 We prefer using signed arithmetic, to avoid comparison confusion.
1814
1815 * alloc.c: Catch some string size overflows that we were missing.
1816 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1817 for convenience in STRING_BYTES_MAX.
1818 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1819 The definition here is exact; the one in lisp.h was approximate.
1820 (allocate_string_data): Check for string overflow. This catches
1821 some instances we weren't catching before. Also, it catches
1822 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1823 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1824 and ptrdiff_t and EMACS_INT are both 64 bits.
1825
1826 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1827 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1828 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1829
1830 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1831
1832 * alloc.c (Fmake_string): Check for out-of-range init.
1833
1834 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1835
1836 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1837
1838 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1839
1840 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1841 xg_get_default_scrollbar_width.
1842
1843 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1844 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1845 (style_changed_cb): Call update_theme_scrollbar_width and call
1846 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1847 all frames (Bug#8505).
1848 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1849 Call gtk_window_set_resizable if HAVE_GTK3.
1850 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1851 and height if HAVE_GTK3 (Bug#8505).
1852 (scroll_bar_width_for_theme): New variable.
1853 (update_theme_scrollbar_width): New function.
1854 (xg_get_default_scrollbar_width): Move code to
1855 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1856 (xg_initialize): Call update_theme_scrollbar_width.
1857
1858 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1859
1860 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1861
1862 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1863
1864 * frame.c (make_frame): Call other_buffer_safely instead of
1865 other_buffer.
1866
1867 * window.c (temp_output_buffer_show): Call display_buffer with
1868 second argument Vtemp_buffer_show_specifiers and reset latter
1869 immediately after the call.
1870 (Vtemp_buffer_show_specifiers): New variable.
1871 (auto_window_vscroll_p, next_screen_context_lines)
1872 (Vscroll_preserve_screen_position): Remove leading asterisks from
1873 doc-strings.
1874
1875 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1876
1877 Fix minor problems found by GCC 4.6.0 static checking.
1878 * buffer.c (Qclone_number): Remove for now, as it's unused.
1879 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1880 (record_buffer): Remove unused local.
1881 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1882 (set_frame_buffer_list): Remove; unused.
1883 * frame.h (other_visible_frames): Remove decl.
1884 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1885 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1886 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1887 if HAVE_GPM.
1888 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1889 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1890 Define only if HAVE_GPM.
1891 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1892 (update_hints_inhibit): Remove; never set. All uses removed.
1893 * widgetprv.h (emacsFrameClassRec): Remove decl.
1894 * window.c (delete_deletable_window): Now returns void, since it
1895 wasn't returning anything.
1896 (compare_window_configurations): Remove unused locals.
1897 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1898 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1899 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1900 the same widths as pointers. This follows up on the 2011-05-06 patch.
1901 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1902 * xterm.h: Likewise.
1903 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1904
1905 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1906
1907 * makefile.w32-in: Update dependencies.
1908 (LISP_H): Add lib/intprops.h.
1909
1910 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1911
1912 * image.c (gif_load): Add animation frame delay to the metadata.
1913 (syms_of_image): Use DEFSYM. New symbol `delay'.
1914
1915 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1916
1917 * window.c (delete_deletable_window): Re-add.
1918 (Fset_window_configuration): Rewrite to handle dead buffers and
1919 consequently deletable windows.
1920 (window_tree, Fwindow_tree): Remove. Supply functionality in
1921 window.el.
1922 (compare_window_configurations): Simplify code.
1923
1924 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1925
1926 * image.c (imagemagick_load_image): Fix type mismatch.
1927 (Fimagemagick_types): Likewise.
1928
1929 * window.h (replace_buffer_in_windows): Declare.
1930
1931 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1932
1933 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1934 Qclone_number. Remove external declaration of Qdelete_window.
1935 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1936 code.
1937 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1938 Qbuffer_list_update_hook if allowed.
1939 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1940 buffer list implementation.
1941 (other_buffer_safely): New function.
1942 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1943 calls to replace_buffer_in_windows and
1944 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1945 if allowed.
1946 (record_buffer): Inhibit quitting and rewrite using quittable
1947 functions. Run Qbuffer_list_update_hook if allowed.
1948 (Frecord_buffer, Funrecord_buffer): New functions.
1949 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1950 switch-to-buffer to window.el.
1951 (bury-buffer): Move to window.el.
1952 (Vbuffer_list_update_hook): New variable.
1953
1954 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1955 section.
1956
1957 * window.h (resize_frame_windows): Move up in code.
1958 (Fwindow_frame): Remove EXFUN.
1959 (replace_buffer_in_all_windows): Remove prototype.
1960 (replace_buffer_in_windows_safely): Add prototype.
1961
1962 * window.c: Declare Qdelete_window static again. Move down
1963 declaration of select_count.
1964 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1965 (Fother_window): Move to window.el.
1966 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1967 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1968 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1969 window.el.
1970 (replace_buffer_in_windows): Implement by calling
1971 Qreplace_buffer_in_windows.
1972 (replace_buffer_in_all_windows): Remove with some functionality
1973 moved into replace_buffer_in_windows_safely.
1974 (replace_buffer_in_windows_safely): New function.
1975 (select_window_norecord, select_frame_norecord): Move in front
1976 of run_window_configuration_change_hook. Remove now obsolete
1977 declarations.
1978 (Fset_window_buffer): Rewrite doc-string. Call
1979 Qrecord_window_buffer.
1980 (keys_of_window): Move binding for other-window to window.el.
1981
1982 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1983
1984 * dispextern.h (struct image): Replace data member, whose int_val
1985 and ptr_val fields were not used by anything, with a single
1986 lisp_val object.
1987
1988 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1989 (gif_clear_image, gif_load, imagemagick_load_image)
1990 (gs_clear_image, gs_load): Callers changed.
1991
1992 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1993
1994 * buffer.h: Include <time.h>, for time_t.
1995 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1996
1997 Fix minor problems found by static checking.
1998
1999 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2000
2001 Make identifiers static if they are not used in other modules.
2002 * data.c (Qcompiled_function, Qframe, Qvector):
2003 * image.c (QimageMagick, Qsvg):
2004 * minibuf.c (Qmetadata):
2005 * window.c (resize_window_check, resize_root_window): Now static.
2006 * window.h (resize_window_check, resize_root_window): Remove decls.
2007
2008 * window.c (window_deletion_count, delete_deletable_window):
2009 Remove; unused.
2010 (window_body_lines): Now static.
2011 (Fdelete_other_windows_internal): Mark vars as initialized.
2012 Make sure 'resize_failed' is initialized.
2013 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2014 (resize_window_apply): Remove unused local.
2015 * window.h (delete_deletable_window): Remove decl.
2016
2017 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
2018 (imagemagick_load_image): Fix pointer signedness problem by changing
2019 last arg from unsigned char * to char *. All uses changed.
2020 Also, fix a local for similar reasons.
2021 Remove unused locals. Remove locals to avoid shadowing.
2022 (fn_rsvg_handle_free): Remove; unused.
2023 (svg_load, svg_load_image): Fix pointer signedness problem.
2024 (imagemagick_load_image): Don't use garbage pointer image_wand.
2025
2026 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2027
2028 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
2029
2030 * image.c (gif_load): Fix omitted cast error introduced by
2031 2011-06-06 change.
2032
2033 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2034
2035 * window.h (resize_proportionally, orig_total_lines)
2036 (orig_top_line): Remove from window structure.
2037 (set_window_height, set_window_width, change_window_heights)
2038 (Fdelete_window): Remove prototypes.
2039 (resize_frame_windows): Remove duplicate declaration.
2040
2041 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2042
2043 * window.h (resize_frame_windows, resize_window_check)
2044 (delete_deletable_window, resize_root_window)
2045 (resize_frame_windows): Declare prototypes.
2046
2047 * window.c (resize_window_apply): Make definition be "static" to
2048 match the prototype.
2049
2050 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2051
2052 * window.c: Remove declarations of Qwindow_size_fixed,
2053 window_min_size_1, window_min_size_2, window_min_size,
2054 size_window, window_fixed_size_p, enlarge_window, delete_window.
2055 Remove static from declaration of Qdelete_window, it's
2056 temporarily needed by Fbury_buffer.
2057 (replace_window): Don't assign orig_top_line and
2058 orig_total_lines.
2059 (Fdelete_window, delete_window): Remove. Window deletion is
2060 handled by window.el.
2061 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2062 Fdelete_window calls with calls to Qdelete_window.
2063 (Fdelete_other_windows): Remove. Deleting other windows is
2064 handled by window.el.
2065 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2066 handled in window.el.
2067 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2068 Window minimum sizes are handled in window.el.
2069 (shrink_windows, size_window, set_window_height)
2070 (set_window_width, change_window_heights, window_height)
2071 (window_width, CURBEG, CURSIZE, enlarge_window)
2072 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2073 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2074 handled in window.el.
2075 (make_dummy_parent): Rename to make_parent_window and give it a
2076 second argument horflag.
2077 (make_window): Don't set resize_proportionally any more.
2078 (Fsplit_window): Remove. Windows are split in window.el.
2079 (save_restore_action, save_restore_orig_size)
2080 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2081 Resize mini windows in window.el.
2082 (grow_mini_window, shrink_mini_window): Implement by calling
2083 Qresize_root_window_vertically, resize_window_check and
2084 resize_window_apply.
2085 (saved_window, Fset_window_configuration, save_window_save): Do
2086 not handle orig_top_line, orig_total_lines, and
2087 resize_proportionally.
2088 (window_min_height, window_min_width): Move to window.el.
2089 (keys_of_window): Move bindings for delete-other-windows,
2090 split-window, delete-window and enlarge-window to window.el.
2091
2092 * buffer.c: Temporarily extern Qdelete_window.
2093 (Fbury_buffer): Temporarily call Qdelete_window instead of
2094 Fdelete_window (Fbury_buffer will move to window.el soon).
2095
2096 * frame.c (set_menu_bar_lines_1): Remove code handling
2097 orig_top_line and orig_total_lines.
2098
2099 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2100 set_window_height but set heights directly.
2101 (change_frame_size_1): Use resize_frame_windows.
2102
2103 * xdisp.c (init_xdisp): Don't use set_window_height but set
2104 heights directly.
2105
2106 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2107 resize_frame_windows instead of change_window_heights and run
2108 run_window_configuration_change_hook.
2109
2110 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2111 instead of change_window_heights and run
2112 run_window_configuration_change_hook.
2113
2114 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2115
2116 * window.c (replace_window): Rename second argument REPLACEMENT to
2117 NEW. New third argument SETFLAG. Rewrite.
2118 (delete_window, make_dummy_parent): Call replace_window with
2119 third argument 1.
2120 (window_list_1): Move down in code.
2121 (run_window_configuration_change_hook): Move set_buffer part
2122 before select_frame_norecord part in order to unwind correctly.
2123 Rename count1 to count.
2124 (recombine_windows, delete_deletable_window, resize_root_window)
2125 (Fdelete_other_windows_internal)
2126 (Frun_window_configuration_change_hook, make_parent_window)
2127 (resize_window_check, resize_window_apply, Fresize_window_apply)
2128 (resize_frame_windows, Fsplit_window_internal)
2129 (Fdelete_window_internal, Fresize_mini_window_internal): New
2130 functions.
2131 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2132
2133 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2134
2135 * window.h (window): Add some new members to window structure -
2136 normal_lines, normal_cols, new_total, new_normal, clone_number,
2137 splits, nest, prev_buffers, next_buffers.
2138 (WINDOW_TOTAL_SIZE): Move here from window.c.
2139 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2140
2141 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2142 Remove.
2143 (make_dummy_parent): Set new members of windows structure.
2144 (make_window): Move down in code. Handle new members of window
2145 structure.
2146 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2147 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2148 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2149 (Fset_window_prev_buffers, Fwindow_next_buffers)
2150 (Fset_window_next_buffers, Fset_window_clone_number): New
2151 functions.
2152 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2153 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2154 Doc-string fixes.
2155 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2156 Argument WINDOW can be now internal window too.
2157 (Fwindow_use_time): Move up in code.
2158 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2159 Rewrite doc-string.
2160 (Fset_window_configuration, saved_window)
2161 (Fcurrent_window_configuration, save_window_save): Handle new
2162 members of window structure.
2163 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2164 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2165 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2166 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2167 Qget_mru_window, Qresize_root_window,
2168 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2169 Qauto_buffer_name; staticpro them.
2170
2171 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2172
2173 * window.c (Fwindow_total_size, Fwindow_left_column)
2174 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2175 (Fwindow_list_1): New functions.
2176 (window_box_text_cols): Replace with window_body_cols.
2177 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2178 window_body_cols instead of window_box_text_cols.
2179 (delete_window, Fset_window_configuration): Call
2180 delete_all_subwindows with window as argument.
2181 (delete_all_subwindows): Take a window as argument and not a
2182 structure. Rewrite.
2183 (window_loop): Remove handling of GET_LRU_WINDOW and
2184 GET_LARGEST_WINDOW.
2185 (Fget_lru_window, Fget_largest_window): Move to window.el.
2186
2187 * window.h: Extern window_body_cols instead of
2188 window_box_text_cols. delete_all_subwindows now takes a
2189 Lisp_Object as argument.
2190
2191 * indent.c (compute_motion, Fcompute_motion): Use
2192 window_body_cols instead of window_box_text_cols.
2193
2194 * frame.c (delete_frame): Call delete_all_subwindows with root
2195 window as argument.
2196
2197 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2198
2199 * fns.c (Fputhash): Document return value.
2200
2201 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2202
2203 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2204
2205 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2206
2207 Cons<->int and similar integer overflow fixes (Bug#8794).
2208
2209 Check for overflow when converting integer to cons and back.
2210 * charset.c (Fdefine_charset_internal, Fdecode_char):
2211 Use cons_to_unsigned to catch overflow.
2212 (Fencode_char): Use INTEGER_TO_CONS.
2213 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2214 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2215 * data.c (long_to_cons, cons_to_long): Remove.
2216 (cons_to_unsigned, cons_to_signed): New functions.
2217 These signal an error for invalid or out-of-range values.
2218 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2219 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2220 * font.c (Ffont_variation_glyphs):
2221 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2222 * lisp.h: Include <intprops.h>.
2223 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2224 (cons_to_signed, cons_to_unsigned): New decls.
2225 (long_to_cons, cons_to_long): Remove decls.
2226 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2227 (Fprimitive_undo): Use CONS_TO_INTEGER.
2228 * xfns.c (Fx_window_property): Likewise.
2229 * xselect.c: Include <limits.h>.
2230 (x_own_selection, selection_data_to_lisp_data):
2231 Use INTEGER_TO_CONS.
2232 (x_handle_selection_request, x_handle_selection_clear)
2233 (x_get_foreign_selection, Fx_disown_selection_internal)
2234 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2235 (lisp_data_to_selection_data): Use cons_to_unsigned.
2236 (x_fill_property_data): Use cons_to_signed.
2237 Report values out of range.
2238
2239 Check for buffer and string overflow more precisely.
2240 * buffer.h (BUF_BYTES_MAX): New macro.
2241 * lisp.h (STRING_BYTES_MAX): New macro.
2242 * alloc.c (Fmake_string):
2243 * character.c (string_escape_byte8):
2244 * coding.c (coding_alloc_by_realloc):
2245 * doprnt.c (doprnt):
2246 * editfns.c (Fformat):
2247 * eval.c (verror):
2248 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2249 since they may not be the same number.
2250 * editfns.c (Finsert_char):
2251 * fileio.c (Finsert_file_contents):
2252 Likewise for BUF_BYTES_MAX.
2253
2254 * image.c: Use ptrdiff_t, not int, for sizes.
2255 (slurp_file): Switch from int to ptrdiff_t.
2256 All uses changed.
2257 (slurp_file): Check that file size fits in both size_t (for
2258 malloc) and ptrdiff_t (for sanity and safety).
2259
2260 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2261 if b->modtime has its maximal value.
2262
2263 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2264
2265 Don't assume time_t can fit into int.
2266 * buffer.h (struct buffer.modtime): Now time_t, not int.
2267 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2268 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2269
2270 Minor fixes for signed vs unsigned integers.
2271 * character.h (MAYBE_UNIFY_CHAR):
2272 * charset.c (maybe_unify_char):
2273 * keyboard.c (read_char, reorder_modifiers):
2274 XINT -> XFASTINT, since the integer must be nonnegative.
2275 * ftfont.c (ftfont_spec_pattern):
2276 * keymap.c (access_keymap, silly_event_symbol_error):
2277 XUINT -> XFASTINT, since the integer must be nonnegative.
2278 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2279 since it makes no difference and we prefer signed.
2280 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2281 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2282 nonnegative.
2283
2284 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2285
2286 * window.h (Fwindow_frame): Declare.
2287
2288 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2289
2290 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2291 (SPARE_MEMORY): Always define.
2292 (LARGE_REQUEST): Remove.
2293 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2294
2295 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2296
2297 * lisp.h: Move EXFUNS for Fframe_root_window,
2298 Fframe_first_window and Fset_frame_selected_window to window.h.
2299
2300 * window.h: Move EXFUNS for Fframe_root_window,
2301 Fframe_first_window and Fset_frame_selected_window here from
2302 lisp.h.
2303
2304 * frame.c (Fwindow_frame, Fframe_first_window)
2305 (Fframe_root_window, Fframe_selected_window)
2306 (Fset_frame_selected_window): Move to window.c.
2307 (Factive_minibuffer_window): Move to minibuf.c.
2308 (Fother_visible_frames_p): New function.
2309
2310 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2311
2312 * window.c (decode_window, decode_any_window): Move up in code.
2313 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2314 (inhibit_frame_unsplittable): Remove unused variable.
2315 (Fwindow_buffer): Move up and rewrite doc-string.
2316 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2317 (Fwindow_prev): New functions.
2318 (Fwindow_frame): Move here from frame.c. Accept any window as
2319 argument.
2320 (Fframe_root_window, Fframe_first_window)
2321 (Fframe_selected_window): Move here from frame.c. Accept frame
2322 or arbitrary window as argument. Update doc-strings.
2323 (Fminibuffer_window): Move up in code.
2324 (Fwindow_minibuffer_p): Move up in code and simplify.
2325 (Fset_frame_selected_window): Move here from frame.c.
2326 Marginal rewrite.
2327 (Fselected_window, select_window, Fselect_window): Move up in
2328 code. Minor doc-string fixes.
2329
2330 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2331
2332 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2333 Do not assume that spare memory exists; that assumption is valid
2334 only if SYSTEM_MALLOC.
2335 (LARGE_REQUEST): New macro, so that the issue of large requests
2336 is separated from the issue of spare memory.
2337
2338 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2339
2340 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2341 format. (Bug#8806)
2342
2343 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2344
2345 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2346 before statements.
2347
2348 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2349
2350 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2351
2352 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2353
2354 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2355 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2356
2357 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2358
2359 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2360
2361 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2362
2363 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2364 (x_clipboard_manager_save): Add return value.
2365 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2366 New error handlers.
2367 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2368 Obey Vx_select_enable_clipboard_manager. Catch errors in
2369 x_clipboard_manager_save (Bug#8779).
2370 (Vx_select_enable_clipboard_manager): New variable.
2371 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2372
2373 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2374
2375 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2376
2377 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2378
2379 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2380 in the current matrix if keep_current_p is non-zero.
2381
2382 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2383
2384 * bidi.c (bidi_level_of_next_char): Fix last change.
2385
2386 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2387
2388 Support bidi reordering of text covered by display properties.
2389
2390 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2391 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2392 (bidi_cache_search, bidi_cache_iterator_state)
2393 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2394 (bidi_level_of_next_char, bidi_move_to_visually_next):
2395 Support character positions inside a run of characters covered by a
2396 display string.
2397 (bidi_paragraph_init, bidi_resolve_explicit_1)
2398 (bidi_level_of_next_char): Call bidi_fetch_char and
2399 bidi_fetch_char_advance instead of FETCH_CHAR and
2400 FETCH_CHAR_ADVANCE.
2401 (bidi_init_it): Initialize new members.
2402 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2403 definitions.
2404 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2405 instead of using explicit *_CHAR codes.
2406 (bidi_resolve_explicit, bidi_resolve_weak):
2407 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2408 bidirectional text is supported only in multibyte buffers.
2409 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2410 it to initialize the frame_window_p member of struct bidi_it.
2411 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2412 (bidi_resolve_explicit, bidi_resolve_weak)
2413 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2414 bidi_it->nchars is non-positive.
2415 (bidi_level_of_next_char): Don't try to lookup the cache for the
2416 next/previous character if nothing is cached there yet, or if we
2417 were just reseat()'ed to a new position.
2418
2419 * xdisp.c (set_cursor_from_row): Set start and stop points
2420 according to the row's direction when priming the loop that looks
2421 for the glyph on which to display cursor.
2422 (single_display_spec_intangible_p): Function deleted.
2423 (display_prop_intangible_p): Reimplement to call
2424 handle_display_spec instead of single_display_spec_intangible_p.
2425 Accept 3 additional arguments needed by handle_display_spec.
2426 This fixes incorrect cursor motion across display property with complex
2427 values: lists, `(when COND...)' forms, etc.
2428 (single_display_spec_string_p): Support property values that are
2429 lists with the argument STRING its top-level element.
2430 (display_prop_string_p): Fix the condition for processing a
2431 property that is a list to be consistent with handle_display_spec.
2432 (handle_display_spec): New function, refactored from the
2433 last portion of handle_display_prop.
2434 (compute_display_string_pos): Accept additional argument
2435 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2436 value of a `display' property is a "replacing spec".
2437 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2438 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2439 the display property, but just return a value indicating whether
2440 the display property will replace the characters it covers.
2441 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2442 frame_window_p members of struct bidi_it.
2443 (compute_display_string_pos, compute_display_string_end):
2444 New functions.
2445 (push_it): Accept second argument POSITION, where pop_it should
2446 jump to continue iteration.
2447 (reseat_1): Initialize bidi_it.disp_pos.
2448
2449 * keyboard.c (adjust_point_for_property): Adjust the call to
2450 display_prop_intangible_p to its new signature.
2451
2452 * dispextern.h (struct bidi_it): New member frame_window_p.
2453 (bidi_init_it): Update prototypes.
2454 (display_prop_intangible_p): Update prototype.
2455 (compute_display_string_pos, compute_display_string_end):
2456 Declare prototypes.
2457 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2458 EMACS_INT.
2459
2460 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2461
2462 Malloc failure behavior now depends on size of allocation.
2463 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2464 * lisp.h: Change signatures accordingly.
2465 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2466 All callers changed. (Bug#8762)
2467
2468 * gnutls.c: Use Emacs's memory allocators.
2469 Without this change, the gnutls library would invoke malloc etc.
2470 directly, which causes problems on non-SYNC_INPUT hosts, and which
2471 runs afoul of improving memory_full behavior. (Bug#8761)
2472 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2473 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2474 xfree instead of the default malloc, realloc, free.
2475 (Fgnutls_boot): No need to check for memory allocation failure,
2476 since xmalloc does that for us.
2477
2478 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2479 * category.c (hash_get_category_set):
2480 * ccl.c (ccl_driver):
2481 * charset.c (Fdefine_charset_internal):
2482 * charset.h (struct charset.hash_index):
2483 * composite.c (get_composition_id, gstring_lookup_cache)
2484 (composition_gstring_put_cache):
2485 * composite.h (struct composition.hash_index):
2486 * dispextern.h (struct image.hash):
2487 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2488 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2489 (hashfn_equal, hashfn_user_defined, make_hash_table)
2490 (maybe_resize_hash_table, hash_lookup, hash_put)
2491 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2492 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2493 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2494 * image.c (make_image, search_image_cache, lookup_image)
2495 (xpm_put_color_table_h):
2496 * lisp.h (struct Lisp_Hash_Table):
2497 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2498 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2499 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2500 * alloc.c (allocate_vectorlike):
2501 Check for overflow in vector size calculations.
2502 * ccl.c (ccl_driver):
2503 Check for overflow when converting EMACS_INT to int.
2504 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2505 need to be updated by these changes.
2506 * fns.c (make_hash_table, maybe_resize_hash_table):
2507 Check for integer overflow with large hash tables.
2508 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2509 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2510 (SXHASH_REDUCE): New macro.
2511 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2512 Use it instead of discarding useful hash info with large hash values.
2513 (sxhash_float): New function.
2514 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2515 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2516 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2517 Rewrite to use FIXNUM_BITS, as this simplifies things.
2518 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2519 Adjust signatures to match updated version of code.
2520 (consing_since_gc): Now EMACS_INT, since a single hash table can
2521 use more than INT_MAX bytes.
2522
2523 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2524
2525 Make it possible to build with GCC-4.6+ -O2 -flto.
2526
2527 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2528
2529 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2530
2531 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2532 Call minibuffer-inactive-mode.
2533
2534 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2535
2536 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2537 Update dependencies.
2538
2539 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2540
2541 * data.c (init_data): Remove code for UTS, this system is not
2542 supported anymore.
2543
2544 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2545
2546 Don't force ./temacs to start in terminal mode.
2547
2548 * frame.c (make_initial_frame): Initialize faces in all cases, not
2549 only when CANNOT_DUMP is defined.
2550 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2551
2552 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2553
2554 * dispnew.c (add_window_display_history): Use const for the string
2555 pointer. Remove declaration, not needed.
2556
2557 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2558
2559 Use 'inline', not 'INLINE'.
2560 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2561 * alloc.c, fontset.c (INLINE): Remove.
2562 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2563 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2564 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2565 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2566 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2567
2568 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2569
2570 Make it possible to run ./temacs.
2571
2572 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2573 syms_of_callproc does the same thing. Remove test for
2574 "initialized", do it in the caller.
2575 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2576
2577 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2578
2579 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2580 (read_minibuf): Use get_minibuffer.
2581 (syms_of_minibuf): Use DEFSYM.
2582 (Qmetadata): New var.
2583 * data.c (Qbuffer): Don't make it static.
2584 (syms_of_data): Use DEFSYM.
2585
2586 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2587
2588 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2589 (CCL_CODE_MIN): New macro.
2590
2591 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2594
2595 * eval.c (Qdebug): Now static.
2596 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2597 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2598 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2599
2600 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2601
2602 * image.c: Various fixes to ImageMagick code comments.
2603 (Fimagemagick_types): Doc fix.
2604
2605 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2606
2607 Minor fixes prompted by GCC 4.6.0 warnings.
2608
2609 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2610
2611 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2612 (x_clipboard_manager_save_all): Move extern decl to ...
2613 * xterm.h: ... here, so that it can be checked for consistency.
2614
2615 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2616
2617 * xselect.c (x_clipboard_manager_save_frame)
2618 (x_clipboard_manager_save_all): New functions.
2619 (Fx_clipboard_manager_save): Lisp function deleted.
2620
2621 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2622 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2623
2624 * xterm.h: Update prototype.
2625
2626 2011-05-28 William Xu <william.xwl@gmail.com>
2627
2628 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2629 exiting (Bug#8239).
2630
2631 2011-05-28 Jim Meyering <meyering@redhat.com>
2632
2633 Avoid a sign-extension bug in crypto_hash_function.
2634 * fns.c (to_uchar): Define.
2635 (crypto_hash_function): Use it to convert some newly-signed
2636 variables to unsigned, to avoid sign-extension bugs. For example,
2637 without this change, (md5 "truc") would evaluate to
2638 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2639 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2640 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2641
2642 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 Integer overflow fixes.
2645
2646 * dbusbind.c: Serial number integer overflow fixes.
2647 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2648 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2649 to hold a serial number that is too large for a fixnum.
2650 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2651 Check for serial numbers out of range. Decode any serial number
2652 that was so large that it became a float. (Bug#8722)
2653
2654 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2655 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2656 Use XFASTINT rather than XUINT when numbers are nonnegative.
2657 (xd_append_arg, Fdbus_method_return_internal):
2658 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2659 arguments, check that Lisp number is nonnegative, rather than
2660 silently wrapping negative numbers around. (Bug#8722)
2661 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2662 (Bug#8722)
2663
2664 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2665
2666 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2667
2668 ccl: add integer overflow checks
2669 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2670 (IN_INT_RANGE): New macros.
2671 (ccl_driver): Use them to check for integer overflow when
2672 decoding a CCL program. Many of the new checks are whether XINT (x)
2673 fits in int; it doesn't always, on 64-bit hosts. The new version
2674 doesn't catch all possible integer overflows, but it's an
2675 improvement. (Bug#8719)
2676
2677 * alloc.c (make_event_array): Use XINT, not XUINT.
2678 There's no need for unsigned here.
2679
2680 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2681 This follows up to the 2011-05-06 change that substituted uintptr_t
2682 for EMACS_INT. This case wasn't caught back then.
2683
2684 Rework Fformat to avoid integer overflow issues.
2685 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2686 now (part of C89). Include <verify.h>.
2687 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2688 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2689 (Fformat): Avoid the prepass trying to compute sizes; it was only
2690 approximate and thus did not catch overflow reliably. Instead, walk
2691 through the format just once, formatting and computing sizes as we go,
2692 checking for integer overflow at every step, and allocating a larger
2693 buffer as needed. Keep track separately whether the format is
2694 multibyte. Keep only the most-recently calculated precision, rather
2695 than them all. Record whether each argument has been converted to
2696 string. Use EMACS_INT, not int, for byte and char and arg counts.
2697 Support field widths and precisions larger than INT_MAX. Avoid
2698 sprintf's undefined behavior with conversion specifications such as %#d
2699 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2700 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2701 formatting out-of-range floating point numbers with int
2702 formats. (Bug#8668)
2703
2704 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2705
2706 * data.c: Avoid integer truncation in expressions involving floats.
2707 * data.c: Include <intprops.h>.
2708 (arith_driver): When there's an integer overflow in an expression
2709 involving floating point, convert the integers to floating point
2710 so that the resulting value does not suffer from catastrophic
2711 integer truncation. For example, on a 64-bit host (* 4
2712 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2713 Do not rely on undefined behavior after integer overflow.
2714
2715 merge count_size_as_multibyte, parse_str_to_multibyte
2716 * character.c, character.h (count_size_as_multibyte):
2717 Rename from parse_str_to_multibyte; all uses changed.
2718 Check for integer overflow.
2719 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2720 since it's now a duplicate of the other. This is more of
2721 a character than a buffer op, so better that it's in character.c.
2722 * fns.c, print.c: Adjust to above changes.
2723
2724 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2725
2726 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2727
2728 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2729
2730 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2731 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2732 (x_clipboard_manager_save): Now static.
2733 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2734
2735 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2736 (crypto_hash_function): Now static.
2737 Fix pointer signedness problems. Avoid unnecessary initializations.
2738
2739 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2740
2741 * termhooks.h (Vselection_alist): Make it terminal-local.
2742
2743 * terminal.c (create_terminal): Initialize it.
2744
2745 * xselect.c: Support for clipboard managers.
2746 (Vselection_alist): Move to termhooks.h as terminal-local var.
2747 (LOCAL_SELECTION): New macro.
2748 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2749 (symbol_to_x_atom): Remove gratuitous arg.
2750 (x_handle_selection_request, lisp_data_to_selection_data)
2751 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2752 (x_own_selection, x_get_local_selection, x_convert_selection):
2753 New arg, specifying work frame. Use terminal-local Vselection_alist.
2754 (some_frame_on_display): Delete unused function.
2755 (Fx_own_selection_internal, Fx_get_selection_internal)
2756 (Fx_disown_selection_internal, Fx_selection_owner_p)
2757 (Fx_selection_exists_p): New optional frame arg.
2758 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2759 (x_handle_selection_clear): Don't treat other terminals with the
2760 same keyboard specially. Use the terminal-local Vselection_alist.
2761 (x_clear_frame_selections): Use Frun_hook_with_args.
2762
2763 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2764
2765 * xterm.h: Add support for those atoms.
2766
2767 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2768
2769 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2770 (converted_selections, conversion_fail_tag): New global variables.
2771 (x_selection_request_lisp_error): Free the above.
2772 (x_get_local_selection): Remove unnecessary code.
2773 (x_reply_selection_request): Args changed; handle arbitrary array
2774 of converted selections stored in converted_selections.
2775 Separate the XChangeProperty and SelectionNotify steps.
2776 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2777 (x_convert_selection): New function.
2778 (x_handle_selection_event): Simplify.
2779 (x_get_foreign_selection): Don't ignore incoming requests while
2780 waiting for an answer; this will fail when we implement
2781 SAVE_TARGETS, and seems unnecessary anyway.
2782 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2783 (Vx_sent_selection_functions): Doc fix.
2784
2785 2011-05-26 Leo Liu <sdl.web@gmail.com>
2786
2787 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2788
2789 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2790
2791 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2792
2793 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2794 for fringe update if it has periodic bitmap.
2795 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2796 and fringe_bitmap_periodic_p.
2797
2798 * fringe.c (get_fringe_bitmap_data): New function.
2799 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2800 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2801 row. Mark glyph row for fringe update if periodicity changed.
2802
2803 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2804 for fringe update unless it has periodic bitmap.
2805
2806 2011-05-25 Kenichi Handa <handa@m17n.org>
2807
2808 * xdisp.c (get_next_display_element): Set correct it->face_id for
2809 a static composition.
2810
2811 2011-05-24 Leo Liu <sdl.web@gmail.com>
2812
2813 * deps.mk (fns.o):
2814 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2815
2816 * fns.c (crypto_hash_function, Fsha1): New function.
2817 (Fmd5): Use crypto_hash_function.
2818 (syms_of_fns): Add Ssha1.
2819
2820 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2821
2822 * gnutls.c: Remove unused macros.
2823 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2824 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2825 Remove macros that are defined and never used.
2826 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2827
2828 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2829
2830 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2831 (Fx_get_selection_internal): Minor cleanup.
2832 (Fx_own_selection_internal): Rename arguments for consistency with
2833 select.el.
2834
2835 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2838
2839 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2840
2841 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2842
2843 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2844
2845 * dispnew.c (scrolling_window): Don't exclude the case that the
2846 last enabled row in the desired matrix touches the bottom boundary.
2847
2848 2011-05-21 Glenn Morris <rgm@gnu.org>
2849
2850 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2851 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2852 and add some more files.
2853
2854 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2855
2856 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2857 report_file_error introduced by the change from 2011-05-07.
2858
2859 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2860
2861 * systime.h (Time): Define only if emacs is defined.
2862 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2863 where the include path doesn't have X11/X.h by default. See
2864 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2865
2866 2011-05-20 Kenichi Handa <handa@m17n.org>
2867
2868 * composite.c (find_automatic_composition): Fix previous change.
2869
2870 2011-05-20 Glenn Morris <rgm@gnu.org>
2871
2872 * lisp.mk: New file, split from Makefile.in.
2873 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2874 (shortlisp): Remove.
2875 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2876
2877 2011-05-19 Glenn Morris <rgm@gnu.org>
2878
2879 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2880 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2881 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2882 (lisp): Set the order to that of loadup.el.
2883 (shortlisp): Make it a copy of $lisp.
2884 (SOME_MACHINE_LISP): Remove.
2885 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2886 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2887
2888 2011-05-18 Kenichi Handa <handa@m17n.org>
2889
2890 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2891 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2892 (find_automatic_composition): Mostly rewrite for efficiency.
2893
2894 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2895
2896 * makefile.w32-in: Update dependencies.
2897
2898 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2899
2900 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2901 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2902
2903 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2904
2905 Fix some integer overflow issues, such as string length overflow.
2906
2907 * insdel.c (count_size_as_multibyte): Check for string overflow.
2908
2909 * character.c (lisp_string_width): Check for string overflow.
2910 Use EMACS_INT, not int, for string indexes and lengths; in
2911 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2912 the resulting string length overflows an EMACS_INT; instead,
2913 report a string overflow if no precision given. When checking for
2914 precision exhaustion, use a check that cannot possibly have
2915 integer overflow. (Bug#8675)
2916 * character.h (lisp_string_width): Adjust to new signature.
2917
2918 * alloc.c (string_overflow): New function.
2919 (Fmake_string): Use it. This doesn't change behavior, but saves
2920 a few bytes and will simplify future changes.
2921 * character.c (string_escape_byte8): Likewise.
2922 * lisp.h (string_overflow): New decl.
2923
2924 Fixups, following up to the user-interface timestamp change.
2925 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2926 for UI timestamps, instead of unsigned long.
2927 * msdos.c (mouse_get_pos): Likewise.
2928 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2929 * w32gui.h (Time): Define by including "systime.h" rather than by
2930 declaring it ourselves. (Bug#8664)
2931
2932 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2933 * image.c (clear_image_cache): Likewise.
2934
2935 * term.c (term_mouse_position): Don't assume time_t wraparound.
2936
2937 Be more systematic about user-interface timestamps.
2938 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2939 and sometimes 'EMACS_UINT', to represent these timestamps.
2940 This change causes it to use 'Time' uniformly, as that's what X uses.
2941 This makes the code easier to follow, and makes it easier to catch
2942 integer overflow bugs such as Bug#8664.
2943 * frame.c (Fmouse_position, Fmouse_pixel_position):
2944 Use Time, not unsigned long, for user-interface timestamps.
2945 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2946 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2947 * keyboard.h (last_event_timestamp): Likewise.
2948 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2949 * menu.h (xmenu_show): Likewise.
2950 * term.c (term_mouse_position): Likewise.
2951 * termhooks.h (struct input_event.timestamp): Likewise.
2952 (struct terminal.mouse_position_hook): Likewise.
2953 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2954 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2955 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2956 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2957 what it was before.
2958 * menu.h, termhooks.h: Include "systime.h", for Time.
2959
2960 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2961 Don't assume that the difference between two unsigned long values
2962 can fit into an integer. At this point, we know button_down_time
2963 <= event->timestamp, so the difference must be nonnegative, so
2964 there's no need to cast the result if double-click-time is
2965 nonnegative, as it should be; check that it's nonnegative, just in
2966 case. This bug is triggered when events are more than 2**31 ms
2967 apart (about 25 days). (Bug#8664)
2968
2969 * xselect.c (last_event_timestamp): Remove duplicate decl.
2970 (x_own_selection): Remove needless cast to unsigned long.
2971
2972 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2973 that always fit in int. Use a sentinel instead of a counter, to
2974 avoid a temp and to allay GCC's concerns about possible int overflow.
2975 * frame.h (struct frame): Use int for menu_bar_items_used
2976 instead of EMACS_INT, since it always fits in int.
2977
2978 * menu.c (grow_menu_items): Check for int overflow.
2979
2980 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2981
2982 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2983 Before, the code was not consistent. These values cannot exceed
2984 2**31 - 1 so there's no need to make them unsigned.
2985 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2986 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2987 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2988 as modifiers.
2989 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2990
2991 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2992 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2993 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2994 presumably because the widths might not match.
2995
2996 * window.c (size_window): Avoid needless test at loop start.
2997
2998 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2999
3000 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3001
3002 2011-05-12 Drew Adams <drew.adams@oracle.com>
3003
3004 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3005
3006 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3007
3008 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3009 `width' to `bar_area_x' and `bar_area_width', respectively.
3010 (x_scroll_run): Take account of fringe background extension.
3011
3012 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3013 Rename local vars `left' and `width' to `bar_area_x' and
3014 `bar_area_width', respectively.
3015 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3016 background extension.
3017
3018 2011-05-10 Jim Meyering <meyering@redhat.com>
3019
3020 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3021
3022 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
3023
3024 * image.c (Finit_image_library): Return t for built-in image types,
3025 like pbm and xbm. (Bug#8640)
3026
3027 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3028
3029 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3030
3031 2011-05-07 Eli Zaretskii <eliz@gnu.org>
3032
3033 * w32console.c (Fset_screen_color): Doc fix.
3034 (Fget_screen_color): New function.
3035 (syms_of_ntterm): Defsubr it.
3036
3037 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3038 unlink the temporary file if Fcall_process didn't create it in the
3039 first place.
3040 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3041 child process will be redirected to a file specified with `:file'.
3042 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3043 cue to call_process_cleanup not to close that handle.
3044
3045 2011-05-07 Ben Key <bkey76@gmail.com>
3046
3047 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3048 one of two shell specific rules, either bootstrap-temacs-CMD or
3049 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3050 to the previous implementation of the bootstrap-temacs rule.
3051 The bootstrap-temacs-CMD rule is similar to the previous
3052 implementation of the bootstrap-temacs rule except that it
3053 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3054 variable.
3055
3056 These changes, along with some changes to nt/configure.bat,
3057 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3058 earlier fix to add support for --cflags and --ldflags options
3059 that include quotes so that it works whether make uses cmd or
3060 sh as the shell.
3061
3062 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3063
3064 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3065 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3066 is a constant.
3067 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3068 a string. Handle both cases.
3069 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3070 (Fdbus_register_method): Use Qinvalid_function.
3071
3072 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3073
3074 * makefile.w32-in: Update dependencies.
3075 (LISP_H): Add inttypes.h and stdin.h.
3076 (PROCESS_H): Add unistd.h.
3077
3078 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3079
3080 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3081 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3082
3083 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3084
3085 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3086
3087 * term.c (vfatal): Remove stray call to va_end.
3088 It's not needed and the C Standard doesn't allow it here anyway.
3089
3090 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3091 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3092
3093 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3094 bytes.
3095
3096 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3097
3098 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3099
3100 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3101
3102 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3103
3104 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3105
3106 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3107 * charset.c (Fdefine_charset_internal): Don't initialize
3108 charset.code_space[15]. The value was garbage, on hosts with
3109 32-bit int (Bug#8600).
3110
3111 * lread.c (read_integer): Be more consistent with string-to-number.
3112 Use string_to_number to do the actual conversion; this avoids
3113 rounding errors and fixes some other screwups. Without this fix,
3114 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3115 (digit_to_number): Move earlier, for benefit of read_integer.
3116 Return -1 if the digit is out of range for the base, -2 if it is
3117 not a digit in any supported base. (Bug#8602)
3118
3119 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3120
3121 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3122 to match comment at start of function. This also removes a
3123 GCC warning about overflow in a 32+64-bit port.
3124
3125 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3126
3127 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3128 Reported by Stefan Monnier in
3129 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3130 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3131 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3132
3133 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3134 (EMACS_UINTPTR): Likewise, with uintptr_t.
3135
3136 * lisp.h: Prefer 64-bit EMACS_INT if available.
3137 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3138 on 32-bit hosts that have 64-bit int, so that they can access
3139 large files.
3140 However, temporarily disable this change unless the temporary
3141 symbol WIDE_EMACS_INT is defined.
3142
3143 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3144
3145 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3146 This removes an assumption that EMACS_INT and long are the same
3147 width as pointers. The assumption is true for Emacs porting targets
3148 now, but we want to make other targets possible.
3149 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3150 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3151 In the rest of the code, change types of integers that hold casted
3152 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3153 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3154 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3155 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3156 No need to cast type when ORing.
3157 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3158 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3159 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3160 assume EMACS_INT is the same width as char *.
3161 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3162 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3163 Remove no-longer-needed casts.
3164 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3165 (xg_tool_bar_help_callback, xg_make_tool_item):
3166 Use EMACS_INTPTR to hold an integer
3167 that will be cast to void *; this can avoid a GCC warning
3168 if EMACS_INT is not the same width as void *.
3169 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3170 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3171 (current_message_1, set_message_1):
3172 Use a local to convert to proper width without a cast.
3173 * xmenu.c (dialog_selection_callback): Likewise.
3174
3175 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3176 Also, don't assume VALBITS / RAND_BITS is less than 5,
3177 and don't rely on undefined behavior when shifting a 1 left into
3178 the sign bit.
3179 * lisp.h (get_random): Change signature to match.
3180
3181 * lread.c (hash_string): Use size_t, not int, for hash computation.
3182 Normally we prefer signed values; but hashing is special, because
3183 it's better to use unsigned division on hash table sizes so that
3184 the remainder is nonnegative. Also, size_t is the natural width
3185 for hashing into memory. The previous code used 'int', which doesn't
3186 retain enough info to hash well into very large tables.
3187 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3188
3189 * dbusbind.c: Don't possibly lose pointer info when converting.
3190 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3191 Use XPNTR rather than XHASH, so that the high-order bits of
3192 the pointer aren't lost when converting through void *.
3193
3194 * eval.c (Fautoload): Don't double-shift a pointer.
3195
3196 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3197
3198 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3199
3200 * gnutls.c (DEF_GNUTLS_FN):
3201 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3202
3203 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3204
3205 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3206 marker. (Bug#8610)
3207
3208 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3209
3210 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3211 New version that can reserve upto 2GB of heap space.
3212
3213 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3214
3215 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3216
3217 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3218
3219 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3220 `gnutls_certificate_set_x509_key_file'.
3221
3222 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3223
3224 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3225 Update dependencies.
3226
3227 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3228
3229 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3230 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3231 Remove unused parameter `fildes'.
3232 * process.c (read_process_output, send_process): Don't pass it.
3233
3234 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3235
3236 Fix previous change: the library cache is defined in w32.c.
3237 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3238 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3239
3240 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3241
3242 Implement dynamic loading of GnuTLS on Windows.
3243
3244 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3245 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3246 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3247 Declare.
3248
3249 * gnutls.c (Qgnutls_dll): Define.
3250 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3251 (gnutls_*): Declare function pointers.
3252 (init_gnutls_functions): New function to initialize function pointers.
3253 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3254 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3255 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3256 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3257 (emacs_gnutls_write, emacs_gnutls_read)
3258 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3259 (Fgnutls_available_p): New function.
3260 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3261 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3262 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3263
3264 * image.c: Include w32.h.
3265 (Vimage_type_cache): Delete.
3266 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3267 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3268 (w32_delayed_load): Move to w32.c.
3269
3270 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3271
3272 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3273 (w32_delayed_load): Move from image.c. When loading a library, record
3274 its filename in the :loaded-from property of the library id.
3275 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3276 Initialize and staticpro them.
3277 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3278
3279 * process.c: Include lisp.h before w32.h, not after.
3280 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3281 instead of gnutls_record_check_pending.
3282
3283 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3284
3285 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3286
3287 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3288 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3289 as passed in.
3290
3291 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3292
3293 * xterm.c (x_set_frame_alpha): Do not set property on anything
3294 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3295
3296 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3297
3298 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3299
3300 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3301
3302 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3303 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3304 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3305 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3306 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3307 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3308 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3309 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3310 (Qgnutls_bootprop_callbacks_verify): Make static.
3311
3312 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3313
3314 * callproc.c: Indentation fixup.
3315
3316 * sysdep.c (wait_for_termination_1): Make static.
3317 (wait_for_termination, interruptible_wait_for_termination):
3318 Move after wait_for_termination_1.
3319
3320 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3321
3322 * sysdep.c (interruptible_wait_for_termination): New function
3323 which is like wait_for_termination, but allows keyboard
3324 interruptions.
3325
3326 * callproc.c (Fcall_process): Add (:file "file") as an option for
3327 the STDOUT buffer.
3328 (Fcall_process_region): Ditto.
3329
3330 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3331
3332 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3333 rather than `XVECTOR (FOO)->size'.
3334
3335 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3336 inttypes.h, as a gnulib replacement is used if it not available in
3337 system headers.
3338
3339 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3340
3341 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3342 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3343 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3344
3345 * coding.c (coding_alloc_by_realloc): Error out if destination
3346 will grow beyond MOST_POSITIVE_FIXNUM.
3347 (decode_coding_emacs_mule): Abort if there isn't enough place in
3348 charbuf for the composition carryover bytes. Reserve an extra
3349 space for up to 2 characters produced in a loop.
3350 (decode_coding_iso_2022): Abort if there isn't enough place in
3351 charbuf for the composition carryover bytes.
3352
3353 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3354
3355 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3356 aborting when %lld or %lll format is passed.
3357 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3358 %llo or %llx format is passed. (Bug#8545)
3359
3360 * window.c (window_scroll_line_based): Use a marker instead of
3361 simple variables to record original value of point. (Bug#7952)
3362
3363 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3364 produced by %s or %c overflows available buffer space. (Bug#8545)
3365
3366 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3367
3368 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3369 (SIZE_MAX): Move defn after all includes, as they might #define it.
3370
3371 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3372
3373 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3374
3375 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3376
3377 * keyboard.c (Qdelayed_warnings_hook): Define.
3378 (command_loop_1): Run `delayed-warnings-hook'
3379 if Vdelayed_warnings_list is non-nil.
3380 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3381 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3382
3383 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3384
3385 * doprnt.c (doprnt): Don't return value smaller than the buffer
3386 size if the message was truncated. (Bug#8545).
3387
3388 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3389
3390 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3391 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3392
3393 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3394
3395 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3396
3397 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3398
3399 * makefile.w32-in: Update dependencies.
3400
3401 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3402
3403 Improve `doprnt' and its usage. (Bug#8545)
3404 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3405 `format_end'. Remove support for %l as a conversion specifier.
3406 Don't use xrealloc. Improve diagnostics when the %l size modifier
3407 is used. Update the commentary.
3408
3409 * eval.c (verror): Simplify calculation of size_t.
3410
3411 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3412 messages.
3413
3414 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3415
3416 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3417 change.
3418
3419 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3420
3421 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3422 This makes this file independent of the recent pseudovector change.
3423
3424 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3425
3426 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3427
3428 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3429 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3430 Remove unused local.
3431 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3432
3433 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3434 GCC 4.6.0 optimizes based on type-based alias analysis.
3435 For example, if b is of type struct buffer * and v of type struct
3436 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3437 != &v->size, and therefore "v->size = 1; b->size = 2; return
3438 v->size;" must therefore return 1. This assumption is incorrect
3439 for Emacs, since it type-puns struct Lisp_Vector * with many other
3440 types. To fix this problem, this patch adds a new type struct
3441 vectorlike_header that documents the constraints on layout of vectors
3442 and pseudovectors, and helps optimizing compilers not get fooled
3443 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3444 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3445 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3446 the size member.
3447 (XSETPVECTYPE): Rewrite in terms of new macro.
3448 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3449 This is a bit clearer, and further avoids the possibility of
3450 undesirable aliasing.
3451 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3452 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3453 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3454 since Lisp_Subr is a special case (no "next" field).
3455 (ASIZE): Now uses header.size rather than size.
3456 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3457 to avoid the hassle of writing XVECTOR (foo)->header.size.
3458 (struct vectorlike_header): New type.
3459 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3460 object, to help avoid aliasing.
3461 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3462 (SUBRP): Likewise, since Lisp_Subr is a special case.
3463 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3464 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3465 (struct Lisp_Hash_Table): Combine first two members into a single
3466 struct vectorlike_header member. All uses of "size" and "next" members
3467 changed to be "header.size" and "header.next".
3468 * buffer.h (struct buffer): Likewise.
3469 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3470 * frame.h (struct frame): Likewise.
3471 * process.h (struct Lisp_Process): Likewise.
3472 * termhooks.h (struct terminal): Likewise.
3473 * window.c (struct save_window_data, struct saved_window): Likewise.
3474 * window.h (struct window): Likewise.
3475 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3476 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3477 * buffer.c (init_buffer_once): Likewise.
3478 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3479 special case.
3480 * process.c (Fformat_network_address): Use local var for size,
3481 for brevity.
3482
3483 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3484
3485 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3486 * data.c (atof): Remove decl; no longer used or needed.
3487 (digit_to_number): Move to lread.c.
3488 (Fstring_to_number): Use new string_to_number function, to be
3489 consistent with how the Lisp reader treats infinities and NaNs.
3490 Do not assume that floating-point numbers represent EMACS_INT
3491 without losing information; this is not true on most 64-bit hosts.
3492 Avoid double-rounding errors, by insisting on integers when
3493 parsing non-base-10 numbers, as the documentation specifies.
3494 * lisp.h (string_to_number): New decl, replacing ...
3495 (isfloat_string): Remove.
3496 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3497 (read1): Do not accept +. and -. as integers; this
3498 appears to have been a coding error. Similarly, do not accept
3499 strings like +-1e0 as floating point numbers. Do not report
3500 overflow for integer overflows unless the base is not 10 which
3501 means we have no simple and reliable way to continue.
3502 Break out the floating-point parsing into a new
3503 function string_to_number, so that Fstring_to_number parses
3504 floating point numbers consistently with the Lisp reader.
3505 (digit_to_number): Move here from data.c. Make it static inline.
3506 (E_CHAR, EXP_INT): Remove, replacing with ...
3507 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3508 (string_to_number): New function, replacing isfloat_string.
3509 This function checks for valid syntax and produces the resulting
3510 Lisp float number too. Rework it so that string-to-number
3511 no longer mishandles examples like "1.0e+". Use strtoumax,
3512 so that overflow for non-base-10 numbers is reported only when
3513 there's no portable and simple way to convert to floating point.
3514
3515 * textprop.c (set_text_properties_1): Rewrite for clarity,
3516 and to avoid GCC warning about integer overflow.
3517
3518 * intervals.h (struct interval): Use EMACS_INT for members
3519 where EMACS_UINT might cause problems. See
3520 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3521 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3522 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3523 All uses changed.
3524 (offset_intervals): Tell GCC not to worry about length overflow
3525 when negating a negative length.
3526
3527 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3528 (overrun_check_free): Likewise.
3529
3530 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3531 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3532 word size.
3533
3534 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3535 (gnutls_make_error): Rename local to avoid shadowing.
3536 (gnutls_emacs_global_deinit): ifdef out; not used.
3537 (Fgnutls_boot): Use const for pointer to readonly storage.
3538 Comment out unused local. Fix pointer signedness problems.
3539
3540 * lread.c (openp): Don't stuff size_t into an 'int'.
3541 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3542 about possible signed overflow.
3543
3544 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3545 (GDK_KEY_g): Don't define if already defined.
3546 (xg_prepare_tooltip): Avoid pointer signedness problem.
3547 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3548
3549 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3550 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3551
3552 * xfns.c (Fx_window_property): Simplify a bit,
3553 to make a bit faster and to avoid GCC 4.6.0 warning.
3554 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3555
3556 * fns.c (internal_equal): Don't assume size_t fits in int.
3557
3558 * alloc.c (compact_small_strings): Tighten assertion a little.
3559
3560 Replace pEd with more-general pI, and fix some printf arg casts.
3561 * lisp.h (pI): New macro, generalizing old pEd macro to other
3562 conversion specifiers. For example, use "...%"pI"d..." rather
3563 than "...%"pEd"...".
3564 (pEd): Remove. All uses replaced with similar uses of pI.
3565 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3566 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3567 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3568 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3569 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3570 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3571 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3572 64-bit hosts.
3573 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3574 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3575 * print.c (safe_debug_print, print_object): Likewise.
3576 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3577 to int.
3578 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3579 avoiding the 0 flag, which is not portable.
3580 * process.c (Fmake_network_process): Use pI to avoid cast.
3581 * region-cache.c (pp_cache): Likewise.
3582 * xdisp.c (decode_mode_spec): Likewise.
3583 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3584 behavior on 64-bit hosts with printf arg.
3585 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3586 (x_stop_queuing_selection_requests): Likewise.
3587 (x_get_window_property): Don't truncate byte count to an 'int'
3588 when tracing.
3589
3590 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3591 here, since it parses constructs like leading '-' and spaces,
3592 which are not wanted; and it overflows with large numbers.
3593 Instead, simply match F[0-9]+, which is what is wanted anyway.
3594
3595 * alloc.c: Remove unportable assumptions about struct layout.
3596 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3597 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3598 (allocate_vectorlike, make_pure_vector): Use the new macros,
3599 plus offsetof, to remove unportable assumptions about struct layout.
3600 These assumptions hold on all porting targets that I know of, but
3601 they are not guaranteed, they're easy to remove, and removing them
3602 makes further changes easier.
3603
3604 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3605 This doesn't fix a bug but makes the code clearer.
3606 (string_overrun_cookie): Now const. Use initializers that
3607 don't formally overflow signed char, to avoid warnings.
3608 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3609 can cause Emacs to crash when string overrun checking is enabled.
3610 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3611 multiple of sizeof (EMACS_INT); it need not be, if
3612 alignof(EMACS_INT) < sizeof (EMACS_INT).
3613 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3614
3615 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3616
3617 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3618
3619 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3620
3621 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3622 supposed to be handshaking. (Bug#8556)
3623 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3624
3625 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3626
3627 * lisp.h (Qdebug): List symbol.
3628 * eval.c (Qdebug): Restore global linkage.
3629 * keyboard.c (debug-on-event): New variable.
3630 (handle_user_signal): Break into debugger when debug-on-event
3631 matches the current signal symbol.
3632
3633 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3634
3635 * alloc.c (check_sblock, check_string_bytes)
3636 (check_string_free_list): Convert to standard C.
3637
3638 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3639
3640 * w32.c (emacs_gnutls_push): Fix typo.
3641
3642 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3643
3644 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3645 "cast to pointer from integer of different size".
3646
3647 Improve doprnt and its use in verror. (Bug#8545)
3648 * doprnt.c (doprnt): Document the set of format control sequences
3649 supported by the function. Use SAFE_ALLOCA instead of always
3650 using `alloca'.
3651
3652 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3653 is one byte too soon. Don't use xrealloc; instead xfree and
3654 xmalloc anew.
3655
3656 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3657
3658 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3659 callbacks stage.
3660
3661 * gnutls.c: Renamed global_initialized to
3662 gnutls_global_initialized. Added internals for the
3663 :verify-hostname-error, :verify-error, and :verify-flags
3664 parameters of `gnutls-boot' and documented those parameters in the
3665 docstring. Start callback support.
3666 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3667 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3668 on error. Return error code.
3669 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3670 (emacs_gnutls_read): Likewise.
3671 (Fgnutls_boot): Return handshake error code.
3672 (emacs_gnutls_handle_error): New function.
3673 (wsaerror_to_errno): Likewise.
3674
3675 * w32.h (emacs_gnutls_pull): Add prototype.
3676 (emacs_gnutls_push): Likewise.
3677
3678 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3679 (emacs_gnutls_push): Likewise.
3680
3681 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3682
3683 * process.c (wait_reading_process_output): Check if GnuTLS
3684 buffered some data internally if no FDs are set for TLS
3685 connections.
3686
3687 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3688 (LIBS): Link to USER_LIBS.
3689 ($(BLD)/gnutls.$(0)): New target.
3690
3691 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3692
3693 * xdisp.c (handle_single_display_spec): Rename the
3694 display_replaced_before_p argument into display_replaced_p, to
3695 make it consistent with the commentary. Fix typos in the
3696 commentary.
3697
3698 * textprop.c (syms_of_textprop): Remove dead code.
3699 (copy_text_properties): Delete obsolete commentary about an
3700 interface that was deleted long ago. Fix typos in the description
3701 of arguments.
3702
3703 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3704 to changes in oldXMenu/XMenu.h from 2011-04-16.
3705 <menu_help_message, prev_menu_help_message>: Constify.
3706 (IT_menu_make_room): menu->help_text is now `const char **';
3707 adjust.
3708
3709 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3710 to changes in oldXMenu/XMenu.h from 2011-04-16.
3711 (struct XMenu): Declare `help_text' `const char **'.
3712
3713 * xfaces.c <Qunspecified>: Make extern again.
3714
3715 * syntax.c: Include sys/types.h before including regex.h, as
3716 required by Posix.
3717
3718 * doc.c (get_doc_string): Improve the format passed to `error'.
3719
3720 * doprnt.c (doprnt): Improve commentary.
3721
3722 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3723
3724 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3725 them with etags.
3726
3727 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3728 changes in globals.h immediately force recompilation.
3729 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3730 $(CURDIR)/s/ms-w32.h.
3731 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3732
3733 * character.c (Fchar_direction): Function deleted.
3734 (syms_of_character): Don't defsubr it.
3735 <char-direction-table>: Deleted.
3736
3737 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3738
3739 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3740 * doprnt.c: Include limits.h.
3741 (SIZE_MAX): New macro.
3742 (doprnt): Return a size_t value. 2nd arg is now size_t.
3743 Many local variables are now size_t instead of int or unsigned.
3744 Improve overflow protection. Support `l' modifier for integer
3745 conversions. Support %l conversion. Don't assume an EMACS_INT
3746 argument for integer conversions and for %c.
3747
3748 * lisp.h (doprnt): Restore prototype.
3749
3750 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3751 $(SRC)/character.h.
3752
3753 * Makefile.in (base_obj): Add back doprnt.o.
3754
3755 * deps.mk (doprnt.o): Add back prerequisites.
3756 (callint.o): Depend on character.h.
3757
3758 * eval.c (internal_lisp_condition_case): Include the handler
3759 representation in the error message.
3760 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3761 when breaking from the loop.
3762
3763 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3764
3765 * callint.c (Fcall_interactively): When displaying error message
3766 about invalid control letter, pass the character's codepoint, not
3767 a pointer to its multibyte form. Improve display of the character
3768 in octal and display also its hex code.
3769
3770 * character.c (char_string): Use %x to display the (unsigned)
3771 codepoint of an invalid character, to avoid displaying a bogus
3772 negative value.
3773
3774 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3775 `error', not SYMBOL_NAME itself.
3776
3777 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3778 character arguments to `error'.
3779
3780 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3781 to `error' in error message about FINAL_CHAR argument. Make sure
3782 FINAL_CHAR is a character, and use %c when it is passed as
3783 argument to `error'.
3784
3785 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3786
3787 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3788
3789 * w32.c: Include <time.h>.
3790 (sys_localtime): New function.
3791
3792 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3793
3794 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3795
3796 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3797
3798 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3799
3800 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3801 zombies (Bug#8467).
3802
3803 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3804
3805 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3806 gl_state.e_property when gl_state.object is Qt.
3807
3808 * insdel.c (make_gap_larger): Remove limitation of buffer size
3809 to <= INT_MAX.
3810
3811 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3812
3813 * xdisp.c (lookup_glyphless_char_display)
3814 (produce_glyphless_glyph): Handle cons cell entry in
3815 glyphless-char-display.
3816 (Vglyphless_char_display): Document it.
3817
3818 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3819 glyphless-char-display.
3820
3821 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3822
3823 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3824
3825 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3826
3827 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3828 definition for no-X builds.
3829
3830 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 Static checks with GCC 4.6.0 and non-default toolkits.
3833
3834 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3835
3836 * process.c (keyboard_bit_set): Define only if SIGIO.
3837 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3838 (send_process): Repair possible setjmp clobbering.
3839
3840 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3841
3842 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3843
3844 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3845
3846 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3847 Define only if needed.
3848
3849 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3850 by pacifying GCC about it. Maybe it's time to retire it?
3851 * xfaces.c (USG, __TIMEVAL__): Likewise.
3852
3853 * dispextern.h (struct redisplay_interface): Rename param
3854 to avoid shadowing.
3855 * termhooks.h (struct terminal): Likewise.
3856 * xterm.c (xembed_send_message): Likewise.
3857
3858 * insdel.c (make_gap_smaller): Define only if
3859 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3860
3861 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3862 it.
3863
3864 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3865 so that we aren't warned about unused symbols.
3866
3867 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3868
3869 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3870
3871 * xfns.c (x_real_positions): Mark locals as initialized.
3872
3873 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3874
3875 * xterm.c: Fix problems found by static analysis with other toolkits.
3876 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3877 (x_dispatch_event): Declare static if USE_GTK, and
3878 define if USE_GTK || USE_X_TOOLKIT.
3879 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3880 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3881 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3882 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3883
3884 * xmenu.c (menu_help_callback): Pointer type fixes.
3885 Use const pointers when pointing at readonly data. Avoid pointer
3886 signedness clashes.
3887 (FALSE): Remove unused macro.
3888 (update_frame_menubar): Remove unused decl.
3889
3890 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3891
3892 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3893 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3894 (single_menu_item): Rename local to avoid shadowing.
3895
3896 * keyboard.c (make_lispy_event): Remove unused local var.
3897
3898 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3899 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3900
3901 * bitmaps: Change bitmaps from unsigned char back to the X11
3902 compatible char. Avoid the old compiler warnings about
3903 out-of-range initializers by using, for example, '\xab' rather
3904 than 0xab.
3905
3906 * xgselect.c (xgselect_initialize): Check vs interface
3907 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3908
3909 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3910
3911 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3912 to read-only memory.
3913
3914 * fns.c (vector): Remove; this old hack is no longer needed.
3915
3916 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3917 Remove unused var.
3918 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3919
3920 * xrdb.c (x_load_resources): Omit unused local.
3921
3922 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3923 (x_window): Rename locals to avoid shadowing.
3924 (USG): Use the kludged USG macro, to pacify gcc.
3925
3926 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3927 (x_term_init): Remove local to avoid shadowing.
3928
3929 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3930
3931 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3932 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3933
3934 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3935
3936 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3937
3938 Fix regex.c, syntax.c and friends for buffers > 2GB.
3939 * syntax.h (struct gl_state_s): Declare character position members
3940 EMACS_INT.
3941
3942 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3943
3944 * textprop.c (verify_interval_modification, interval_of):
3945 Declare arguments EMACS_INT.
3946
3947 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3948 EMACS_INT.
3949
3950 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3951
3952 * indent.c (Fvertical_motion): Local variable it_start is now
3953 EMACS_INT.
3954
3955 * regex.c (re_match, re_match_2, re_match_2_internal)
3956 (bcmp_translate, regcomp, regexec, print_double_string)
3957 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3958 (re_compile_pattern, re_exec): Declare arguments and local
3959 variables `size_t' and `ssize_t' and return values `regoff_t', as
3960 appropriate.
3961 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3962 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3963 <compile_stack_type>: `size' and `avail' are now `size_t'.
3964
3965 * regex.h <regoff_t>: Use ssize_t, not int.
3966 (re_search, re_search_2, re_match, re_match_2): Arguments that
3967 specify buffer/string position and length are now ssize_t and
3968 size_t. Return type is regoff_t.
3969
3970 2011-04-16 Ben Key <bkey76@gmail.com>
3971
3972 * nsfont.m: Fixed bugs in ns_get_family and
3973 ns_descriptor_to_entity that were caused by using free to
3974 deallocate memory blocks that were allocated by xmalloc (via
3975 xstrdup). This caused Emacs to crash when compiled with
3976 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3977 --enable-checking=xmallocoverrun). xfree is now used to
3978 deallocate these memory blocks.
3979
3980 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3981
3982 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3983
3984 emacs_write: Accept and return EMACS_INT for sizes.
3985 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3986 et seq.
3987 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3988 Accept and return EMACS_INT.
3989 (emacs_gnutls_write): Return the number of bytes written on
3990 partial writes.
3991 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3992 (emacs_read, emacs_write): Remove check for negative size, as the
3993 Emacs source code has been audited now.
3994 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3995 (emacs_read, emacs_write): Use it.
3996 * process.c (send_process): Adjust to the new signatures of
3997 emacs_write and emacs_gnutls_write. Do not attempt to store
3998 a byte offset into an 'int'; it might overflow.
3999 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
4000
4001 * sound.c: Don't assume sizes fit in 'int'.
4002 (struct sound_device.period_size, alsa_period_size):
4003 Return EMACS_INT, not int.
4004 (struct sound_device.write, vox_write, alsa_write):
4005 Accept EMACS_INT, not int.
4006 (wav_play, au_play): Use EMACS_INT to store sizes and to
4007 record read return values.
4008
4009 2011-04-15 Ben Key <bkey76@gmail.com>
4010
4011 * keyboard.c (Qundefined): Don't declare static since it is used
4012 in nsfns.m.
4013 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4014 static since they are used in nsfont.m.
4015
4016 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4017
4018 * process.c (Qprocessp): Don't declare static.
4019 * lisp.h (Qprocessp): Declare again.
4020
4021 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
4022
4023 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4024
4025 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4026
4027 Improve C-level modularity by making more things 'static'.
4028
4029 Don't publish debugger-only interfaces to other modules.
4030 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4031 (verify_bytepos, count_markers): Move decls to the only modules
4032 that need them.
4033 * region-cache.h (pp_cache): Likewise.
4034 * window.h (check_all_windows): Likewise.
4035 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4036
4037 * sysdep.c (croak): Now static, if
4038 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4039 * syssignal.h (croak): Declare only if not static.
4040
4041 * alloc.c (refill_memory_reserve): Now static if
4042 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4043 * lisp.h (refill_memory_reserve): Declare only if not static.
4044
4045 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4046 Define only if USE_LUCID.
4047
4048 * xrdb.c (x_customization_string, x_rm_string): Now static.
4049
4050 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4051 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4052
4053 * xdisp.c (draw_row_with_mouse_face): Now static.
4054 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4055
4056 * window.h (check_all_windows): Mark externally visible.
4057
4058 * window.c (window_deletion_count): Now static.
4059
4060 * undo.c: Make symbols static if they're not exported.
4061 (last_undo_buffer, last_boundary_position, pending_boundary):
4062 Now static.
4063
4064 * textprop.c (interval_insert_behind_hooks): Now static.
4065 (interval_insert_in_front_hooks): Likewise.
4066
4067 * term.c: Make symbols static if they're not exported.
4068 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4069 (max_frame_lines, tty_set_terminal_modes):
4070 (tty_reset_terminal_modes, tty_turn_off_highlight):
4071 (get_tty_terminal): Now static.
4072 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4073 * termhooks.h (term_mouse_moveto): Do not declare if
4074 HAVE_WINDOW_SYSTEM.
4075 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4076 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4077
4078 * sysdep.c: Make symbols static if they're not exported.
4079 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4080 Now static.
4081 (sigprocmask_set, full_mask): Remove; unused.
4082 (wait_debugging): Mark as visible.
4083 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4084 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4085
4086 * syntax.c (syntax_temp): Define only if !__GNUC__.
4087
4088 * sound.c (current_sound_device, current_sound): Now static.
4089
4090 * search.c (searchbufs, searchbuf_head): Now static.
4091
4092 * scroll.c (scroll_cost): Remove; unused.
4093 * dispextern.h (scroll_cost): Remove decl.
4094
4095 * region-cache.h (pp_cache): Mark as externally visible.
4096
4097 * process.c: Make symbols static if they're not exported.
4098 (process_tick, update_tick, create_process, chan_process):
4099 (Vprocess_alist, proc_buffered_char, datagram_access):
4100 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4101 (deactivate_process): Mark defn as static, as well as decl.
4102 * lisp.h (create_process): Remove decl.
4103 * process.h (chan_process, Vprocess_alist): Remove decls.
4104
4105 * print.c: Make symbols static if they're not exported.
4106 (print_depth, new_backquote_output, being_printed, print_buffer):
4107 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4108 (print_interval, print_number_index, initial_stderr_stream):
4109 Now static.
4110 * lisp.h (Fprinc): Remove decl.
4111 (debug_output_compilation_hack): Mark as externally visible.
4112
4113 * sysdep.c (croak): Move decl from here to syssignal.h.
4114 * syssignal.h (croak): Put it here, so the API can be checked when
4115 'croak' is called from dissociate_if_controlling_tty.
4116
4117 * minibuf.c: Make symbols static if they're not exported.
4118 (minibuf_save_list, choose_minibuf_frame): Now static.
4119 * lisp.h (choose_minibuf_frame): Remove decl.
4120
4121 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4122
4123 * lread.c: Make symbols static if they're not exported.
4124 (read_objects, initial_obarray, oblookup_last_bucket_number):
4125 Now static.
4126 (make_symbol): Remove; unused.
4127 * lisp.h (initial_obarray, make_symbol): Remove decls.
4128
4129 * keyboard.c: Make symbols static if they're not exported.
4130 (single_kboard, recent_keys_index, total_keys, recent_keys):
4131 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4132 (this_single_command_key_start, echoing, last_auto_save):
4133 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4134 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4135 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4136 (Vlispy_mouse_stem, double_click_count):
4137 Now static.
4138 (force_auto_save_soon): Define only if SIGDANGER.
4139 (ignore_mouse_drag_p): Now static if
4140 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4141 (print_help): Remove; unused.
4142 (stop_character, last_timer_event): Mark as externally visible.
4143 * keyboard.h (ignore_mouse_drag_p): Declare only if
4144 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4145 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4146 * lisp.h (echoing): Remove decl.
4147 (force_auto_save_soon): Declare only if SIGDANGER.
4148 * xdisp.c (redisplay_window): Simplify code, to make it more
4149 obvious that ignore_mouse_drag_p is not accessed if !defined
4150 USE_GTK && !defined HAVE_NS.
4151
4152 * intervals.c: Make symbols static if they're not exported.
4153 (merge_properties_sticky, merge_interval_right, delete_interval):
4154 Now static.
4155 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4156
4157 * insdel.c: Make symbols static if they're not exported.
4158 However, leave prepare_to_modify_buffer alone. It's never
4159 called from outside this function, but that appears to be a bug.
4160 (combine_after_change_list, combine_after_change_buffer):
4161 (adjust_after_replace, signal_before_change): Now static.
4162 (adjust_after_replace_noundo): Remove; unused.
4163 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4164 (signal_before_change): Remove decls.
4165
4166 * indent.c (val_compute_motion, val_vmotion): Now static.
4167
4168 * image.c: Make symbols static if they're not exported.
4169 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4170 if USE_GTK.
4171 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4172 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4173
4174 * fringe.c (standard_bitmaps): Now static.
4175 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4176
4177 * frame.c: Make symbols static if they're not exported.
4178 (x_report_frame_params, make_terminal_frame): Now static.
4179 (get_frame_param): Now static, unless HAVE_NS.
4180 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4181 (x_get_resource_string): Remove; not used.
4182 * frame.h (make_terminal_frame, x_report_frame_params):
4183 (x_get_resource_string); Remove decls.
4184 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4185 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4186
4187 * font.c, fontset.c: Make symbols static if they're not exported.
4188 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4189 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4190 * font.c (font_close_object): Now static.
4191 * font.h (font_close_object): Remove.
4192 * fontset.c (FONTSET_OBJLIST): Remove.
4193 (free_realized_fontset) #if-0 the body, which does nothing.
4194 (face_suitable_for_char_p): #if-0, as it's never called.
4195 * fontset.h (face_suitable_for_char_p): Remove decl.
4196 * xfaces.c (face_at_string_position):
4197 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4198 since 0 is always ASCII.
4199
4200 * fns.c (weak_hash_tables): Now static.
4201
4202 * fileio.c: Make symbols static if they're not exported.
4203 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4204 (Vwrite_region_annotation_buffers): Now static.
4205
4206 * eval.c: Make symbols static if they're not exported.
4207 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4208 * lisp.h (backtrace_list): Remove decl.
4209
4210 * emacs.c: Make symbols static if they're not exported.
4211 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4212 (fatal_error_code, fatal_error_signal_hook, standard_args):
4213 Now static.
4214 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4215 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4216 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4217 * lisp.h (fatal_error_signal_hook): Remove decl.
4218 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4219
4220 * editfns.c: Move a (normally-unused) function to its only use.
4221 * editfns.c, lisp.h (get_operating_system_release): Remove.
4222 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4223 worth the hassle of breaking this out.
4224
4225 * xterm.c: Make symbols static if they're not exported.
4226 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4227 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4228 (x_destroy_window, x_delete_display):
4229 Now static.
4230 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4231 (x_mouse_leave): Remove; unused.
4232 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4233 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4234 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4235 Remove decls.
4236 (x_mouse_leave): Declare only if WINDOWSNT.
4237 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4238 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4239 USE_X_TOOLKIT.
4240
4241 * ftxfont.c: Make symbols static if they're not exported.
4242 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4243 HAVE_FREETYPE.
4244 * font.h (ftxfont_driver): Likewise.
4245
4246 * xfns.c: Make symbols static if they're not exported.
4247 (x_last_font_name, x_display_info_for_name):
4248 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4249 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4250 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4251 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4252 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4253 (last_show_tip_args): Now static.
4254 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4255 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4256 (x_screen_planes): Remove; unused.
4257 * dispextern.h (x_screen_planes): Remove decl.
4258
4259 * dispnew.c: Make symbols static if they're not exported.
4260 * dispextern.h (redraw_garbaged_frames, scrolling):
4261 (increment_row_positions): Remove.
4262 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4263 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4264 Now static.
4265 (redraw_garbaged_frames): Remove; unused.
4266
4267 * xfaces.c: Make symbols static if they're not exported.
4268 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4269 Remove decls.
4270 * xterm.h (defined_color): Remove decls.
4271 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4272 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4273 (menu_face_changed_default, defined_color, free_realized_face):
4274 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4275 (ascii_face_of_lisp_face): Remove; unused.
4276
4277 * xdisp.c: Make symbols static if they're not exported.
4278 * dispextern.h (scratch_glyph_row, window_box_edges):
4279 (glyph_to_pixel_coords, set_cursor_from_row):
4280 (get_next_display_element, set_iterator_to_next):
4281 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4282 (show_mouse_face): Remove decls
4283 * frame.h (message_buf_print): Likewise.
4284 * lisp.h (pop_message, set_message, check_point_in_composition):
4285 Likewise.
4286 * xterm.h (set_vertical_scroll_bar): Likewise.
4287 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4288 (message_buf_print, scratch_glyph_row, displayed_buffer):
4289 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4290 (get_next_display_element, show_mouse_face, window_box_edges):
4291 (frame_to_window_pixel_xy, check_point_in_composition):
4292 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4293 (glyph_to_pixel_coords): Remove; unused.
4294
4295 * dired.c (file_name_completion): Now static.
4296
4297 * dbusbind.c (xd_in_read_queued_messages): Now static.
4298
4299 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4300 * data.c (circular_list_error): Remove.
4301
4302 * commands.h (last_point_position, last_point_position_buffer):
4303 (last_point_position_window): Remove decls.
4304 * keyboard.c: Make these variables static.
4305
4306 * coding.h (coding, code_convert_region, encode_coding_gap):
4307 Remove decls.
4308 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4309 (iso_code_class, detect_coding, code_convert_region): Now static.
4310 (encode_coding_gap): Remove; unused.
4311
4312 * chartab.c (chartab_chars, chartab_bits): Now static.
4313
4314 * charset.h (charset_iso_8859_1): Remove decl.
4315 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4316 Now static.
4317
4318 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4319 * ccl.c (Vccl_program_table): Now static.
4320 (check_ccl_update): Remove; unused.
4321
4322 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4323 * category.h: ... from here.
4324 * category.c (check_category_table, set_category_set): Now static.
4325
4326 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4327 * lisp.h: Remove these decls.
4328
4329 * buffer.c (buffer_count): Remove unused var.
4330
4331 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4332 so that it's not optimized away.
4333 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4334 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4335 exported only to the debugger.
4336
4337 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4338 * atimer.h (run_all_atimers): Remove; not exported.
4339
4340 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4341 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4342 was inaccessible from Lisp.
4343 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4344 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4345
4346 alloc.c: Import and export fewer symbols, and remove unused items.
4347 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4348 is defined.
4349 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4350 it's not optimized away by whole-program optimization.
4351 (message_enable_multibyte, free_misc): Remove.
4352 (catchlist, handlerlist, mark_backtrace):
4353 Declare only if BYTE_MARK_STACK.
4354 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4355 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4356 (message_enable_multibyte): Remove decl.
4357 (free_misc, interval_free_list, float_block, float_block_index):
4358 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4359 (cons_free_list, last_marked_index):
4360 Now static.
4361 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4362 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4363 (mark_backtrace): Define only if BYTE_MARK_STACK.
4364 * xdisp.c (message_enable_multibyte): Now static.
4365
4366 Declare Lisp_Object Q* variables to be 'static' if not exported.
4367 This makes it easier for human readers (and static analyzers)
4368 to see whether these variables are used from other modules.
4369 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4370 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4371 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4372 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4373 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4374 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4375 * xmenu.c, xselect.c:
4376 Declare Q* vars static if they are not used in other modules.
4377 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4378 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4379 Remove decls of unexported vars.
4380 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4381
4382 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4383
4384 Make Emacs functions such as Fatom 'static' by default.
4385 This makes it easier for human readers (and static analyzers)
4386 to see whether these functions can be called from other modules.
4387 DEFUN now defines a static function. To make the function external
4388 so that it can be used in other C modules, use the new macro DEFUE.
4389 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4390 (Finit_image_library):
4391 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4392 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4393 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4394 Remove decls, since these functions are now static.
4395 (Funintern, Fget_internal_run_time): New decls, since these functions
4396 were already external.
4397
4398 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4399 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4400 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4401 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4402 * keyboard.c, keymap.c, lread.c:
4403 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4404 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4405 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4406 Mark functions with DEFUE instead of DEFUN,
4407 if they are used in other modules.
4408 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4409 decls for now-static functions.
4410 * buffer.h (Fdelete_overlay): Remove decl.
4411 * callproc.c (Fgetenv_internal): Mark as internal.
4412 * composite.c (Fremove_list_of_text_properties): Remove decl.
4413 (Fcomposition_get_gstring): New forward static decl.
4414 * composite.h (Fcomposite_get_gstring): Remove decl.
4415 * dired.c (Ffile_attributes): New forward static decl.
4416 * doc.c (Fdocumntation_property): New forward static decl.
4417 * eval.c (Ffetch_bytecode): New forward static decl.
4418 (Funintern): Remove extern decl; now in .h file where it belongs.
4419 * fileio.c (Fmake_symbolic_link): New forward static decl.
4420 * image.c (Finit_image_library): New forward static decl.
4421 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4422 * intervals.h (Fprevious_property_change):
4423 (Fremove_list_of_text_properties): Remove decls.
4424 * keyboard.c (Fthis_command_keys): Remove decl.
4425 (Fcommand_execute): New forward static decl.
4426 * keymap.c (Flookup_key): New forward static decl.
4427 (Fcopy_keymap): Now static.
4428 * keymap.h (Flookup_key): Remove decl.
4429 * process.c (Fget_process): New forward static decl.
4430 (Fprocess_datagram_address): Mark as internal.
4431 * syntax.c (Fsyntax_table_p): New forward static decl.
4432 (skip_chars): Remove duplicate decl.
4433 * textprop.c (Fprevious_property_change): New forward static decl.
4434 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4435 Now internal.
4436 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4437 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4438
4439 * editfns.c (Fformat): Remove unreachable code.
4440
4441 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4442
4443 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4444 change. (Bug#8496)
4445
4446 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4447
4448 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4449 when at ZV. (Bug#8487)
4450
4451 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4452
4453 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4454 (Bug#8437)
4455 * keyboard.c (parse_tool_bar_item): Likewise.
4456 * sound.c (sound_cleanup, alsa_close): Likewise.
4457 * termcap.c (tgetent): Likewise.
4458 * xfns.c (x_default_font_parameter): Likewise.
4459 * xsettings.c (read_and_apply_settings): Likewise.
4460
4461 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4462 (overrun_check_free): Protoize.
4463
4464 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4465
4466 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4467 since callers should never pass a negative size.
4468 Change the signature to match that of plain 'read' and 'write'; see
4469 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4470 * lisp.h: Update prototypes of emacs_write and emacs_read.
4471
4472 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4473
4474 * xdisp.c (redisplay_window): Don't try to determine the character
4475 position of the scroll margin if the window start point w->startp
4476 is outside the buffer's accessible region. (Bug#8468)
4477
4478 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4479
4480 Fix write-region and its subroutines for buffers > 2GB.
4481 * fileio.c (a_write, e_write): Modify declaration of arguments and
4482 local variables to support buffers larger than 2GB.
4483 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4484
4485 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4486 argument, local variables, and return value.
4487
4488 * lisp.h: Update prototypes of emacs_write and emacs_read.
4489
4490 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4491
4492 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4493
4494 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4495
4496 Fix more problems found by GCC 4.6.0's static checks.
4497
4498 * xdisp.c (vmessage): Use a better test for character truncation.
4499
4500 * charset.c (load_charset_map): <, not <=, for optimization,
4501 and to avoid potential problems with integer overflow.
4502 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4503 * casetab.c (set_identity, shuffle): Likewise.
4504 * editfns.c (Fformat): Likewise.
4505 * syntax.c (skip_chars): Likewise.
4506
4507 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4508 This also lets GCC 4.6.0 generate slightly better loop code.
4509
4510 * callint.c (Fcall_interactively): <, not <=, for optimization.
4511 (Fcall_interactively): Count the number of arguments produced,
4512 not the number of arguments given. This is simpler and lets GCC
4513 4.6.0 generate slightly better code.
4514
4515 * ftfont.c: Distingish more carefully between FcChar8 and char.
4516 The previous code passed unsigned char * to a functions like
4517 strlen and xstrcasecmp that expect char *, which does not
4518 conform to the C standard.
4519 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4520 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4521 char * when the C standard requires it.
4522
4523 * keyboard.c (read_char): Remove unused var.
4524
4525 * eval.c: Port to Windows vsnprintf (Bug#8435).
4526 Include <limits.h>.
4527 (SIZE_MAX): Define if the headers do not.
4528 (verror): Do not give up if vsnprintf returns a negative count.
4529 Instead, grow the buffer. This ports to Windows vsnprintf, which
4530 does not conform to C99. Problem reported by Eli Zaretskii.
4531 Also, simplify the allocation scheme, by avoiding the need for
4532 calling realloc, and removing the ALLOCATED variable.
4533
4534 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4535
4536 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4537 But keep the doprint source code for now, as we might revamp it
4538 and use it again (Bug#8435).
4539 * lisp.h (doprnt): Remove.
4540 * Makefile.in (base_obj): Remove doprnt.o.
4541 * deps.mk (doprnt.o): Remove.
4542
4543 error: Print 32- and 64-bit integers portably (Bug#8435).
4544 Without this change, on typical 64-bit hosts error ("...%d...", N)
4545 was used to print both 32- and 64-bit integers N, which relied on
4546 undefined behavior.
4547 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4548 New macro.
4549 * lisp.h (error, verror): Mark as printf-like functions.
4550 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4551 Report overflow in size calculations when allocating printf buffer.
4552 Do not truncate output string at its first null byte.
4553 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4554 Truncate the output at a character boundary, since vsnprintf does not
4555 do that.
4556 * charset.c (check_iso_charset_parameter): Convert internal
4557 character to string before calling 'error', since %c now has the
4558 printf meaning.
4559 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4560 overflow when computing char to be passed to 'error'. Do not
4561 pass Lisp_Object to 'error'; pass the integer instead.
4562 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4563 formatted with plain %d.
4564
4565 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4566
4567 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4568
4569 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4570
4571 * xterm.c (x_catch_errors): Remove duplicate declaration.
4572
4573 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4574
4575 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4576
4577 2011-04-10 Jim Meyering <meyering@redhat.com>
4578
4579 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4580 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4581 return ssize_t not "int", and use size_t as the buffer length.
4582 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4583 * gnutls.h: Update declarations.
4584 * process.c (read_process_output): Use ssize_t, to match.
4585 (send_process): Likewise.
4586
4587 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4588
4589 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4590
4591 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4592
4593 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4594 Use unsigned char, to match FcChar8 type definition.
4595
4596 * xterm.c (handle_one_xevent):
4597 * xmenu.c (create_and_show_popup_menu):
4598 * xselect.c (x_decline_selection_request)
4599 (x_reply_selection_request): Avoid type-punned deref of X events.
4600
4601 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4602
4603 Fix some uses of `int' instead of EMACS_INT.
4604 * search.c (string_match_1, fast_string_match)
4605 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4606 (scan_buffer, find_next_newline_no_quit)
4607 (find_before_next_newline, search_command, Freplace_match)
4608 (Fmatch_data): Make some `int' variables be EMACS_INT.
4609
4610 * xdisp.c (display_count_lines): 3rd argument and return value now
4611 EMACS_INT. All callers changed.
4612 (pint2hrstr): Last argument is now EMACS_INT.
4613
4614 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4615 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4616 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4617 (decode_coding_utf_16, decode_coding_emacs_mule)
4618 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4619 (decode_coding_ccl, decode_coding_charset)
4620 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4621 (decode_coding_iso_2022, decode_coding_emacs_mule)
4622 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4623 <char_offset, last_offset>: Declare EMACS_INT.
4624 (encode_coding_utf_8, encode_coding_utf_16)
4625 (encode_coding_emacs_mule, encode_invocation_designation)
4626 (encode_designation_at_bol, encode_coding_iso_2022)
4627 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4628 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4629 Declare EMACS_INT.
4630 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4631 (encode_invocation_designation): Last argument P_NCHARS is now
4632 EMACS_INT.
4633 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4634 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4635
4636 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4637 All users changed.
4638
4639 * ccl.c (Fccl_execute_on_string): Declare some variables
4640 EMACS_INT.
4641
4642 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4643
4644 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4645
4646 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4647
4648 * process.c (Fformat_network_address): Doc fix.
4649
4650 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4651
4652 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4653
4654 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4655
4656 * keyboard.c (read_char): Call Lisp function help-form-show,
4657 instead of using internal_with_output_to_temp_buffer.
4658 (Qhelp_form_show): New var.
4659 (syms_of_keyboard): Use DEFSYM macro.
4660
4661 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4662
4663 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4664
4665 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4666
4667 * process.c (Flist_processes): Remove to Lisp.
4668 (list_processes_1): Delete.
4669
4670 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4671
4672 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4673
4674 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4675
4676 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4677
4678 Fix more problems found by GCC 4.6.0's static checks.
4679
4680 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4681
4682 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4683
4684 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4685
4686 * xdisp.c (vmessage): Mark as a printf-like function.
4687
4688 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4689
4690 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4691
4692 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4693 printf-like functions.
4694 (tiff_load): Add casts to remove these marks before passing them
4695 to system-supplied API.
4696
4697 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4698
4699 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4700 This avoids several warnings with gcc -Wstrict-overflow.
4701 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4702 directly, rather than having caller test rule sign. This avoids
4703 some unnecessary tests.
4704 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4705 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4706 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4707
4708 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4709 (xfont_open): Avoid unnecessary tests.
4710
4711 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4712
4713 * composite.h, composite.c (composition_gstring_put_cache):
4714 Use EMACS_INT, not int, for length.
4715
4716 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4717 breaking out part of COMPOSITION_DECODE_RULE.
4718 (COMPOSITION_DECODE_RULE): Use it.
4719 * composite.c (get_composition_id): Remove unused local vars,
4720 by using the new macro.
4721
4722 * textprop.c (set_text_properties_1): Change while to do-while,
4723 since the condition is always true at first.
4724
4725 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4726 (interval_deletion_adjustment): Return unsigned value.
4727 All uses changed.
4728
4729 * process.c (list_processes_1, create_pty, read_process_output):
4730 (exec_sentinel): Remove vars that were set but not used.
4731 (create_pty): Remove unnecessary "volatile"s.
4732 (Fnetwork_interface_info): Avoid possibility of int overflow.
4733 (read_process_output): Do adaptive read buffering even if carryover.
4734 (read_process_output): Simplify nbytes computation if buffered.
4735
4736 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4737
4738 * syntax.c (scan_words): Remove var that was set but not used.
4739 (update_syntax_table): Use unsigned instead of int.
4740
4741 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4742 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4743 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4744
4745 * print.c (print_error_message): Avoid int overflow.
4746
4747 * font.c (font_list_entities): Redo for clarity,
4748 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4749
4750 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4751 (font_score): Avoid potential overflow in diff calculation.
4752
4753 * fns.c (substring_both): Remove var that is set but not used.
4754 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4755
4756 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4757
4758 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4759 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4760 can always succeed if overflow has undefined behavior.
4761
4762 * search.c (boyer_moore, wordify): Remove vars set but not used.
4763 (wordify): Omit three unnecessary tests.
4764
4765 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4766 All callers changed. This avoids the need for an unused var.
4767
4768 * casefiddle.c (casify_region): Remove var that is set but not used.
4769
4770 * dired.c (file_name_completion): Remove var that is set but not used.
4771
4772 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4773
4774 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4775 (Finsert_file_contents): Remove unnecessary code checking fd.
4776
4777 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4778 Check for integer overflow on size calculations.
4779
4780 * buffer.c (Fprevious_overlay_change): Remove var that is set
4781 but not used.
4782
4783 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4784 Remove vars that are set but not used.
4785 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4786 (timer_check_2): Mark vars as initialized.
4787
4788 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4789
4790 * image.c (lookup_image): Remove var that is set but not used.
4791 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4792
4793 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4794 that are set but not used.
4795
4796 * xfns.c (make_invisible_cursor): Don't return garbage
4797 if XCreateBitmapFromData fails (Bug#8410).
4798
4799 * xselect.c (x_get_local_selection, x_handle_property_notify):
4800 Remove vars that are set but not used.
4801
4802 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4803 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4804
4805 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4806 Remove var that is set but not used.
4807 (scroll_bar_windows_size): Now size_t, not int.
4808 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4809 Check for overflow.
4810
4811 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4812 (map_tty_color) [!defined MSDOS]: Likewise.
4813
4814 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4815
4816 * coding.c: Remove vars that are set but not used.
4817 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4818 All callers changed.
4819 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4820 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4821 (decode_coding_charset): Remove vars that are set but not used.
4822
4823 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4824 that is set but not used.
4825
4826 * print.c (print_object): Remove var that is set but not used.
4827
4828 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4829 The gnulib version avoids calling malloc in the usual case,
4830 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4831 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4832 * filelock.c (current_lock_owner): Likewise.
4833 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4834 * sysdep.c: Include allocator.h, careadlinkat.h.
4835 (emacs_no_realloc_allocator): New static constant.
4836 (emacs_readlink): New function.
4837 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4838 ../lib/careadlinkat.h.
4839
4840 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4841
4842 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4843 first non-nil return value).
4844
4845 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4846
4847 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4848 if not defined (Bug#8403).
4849
4850 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4851
4852 * xdisp.c (display_count_lines): Remove parameter `start',
4853 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4854 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4855 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4856 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4857 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4858 and thereabouts. All callers changed.
4859 (get_per_char_metric): Remove parameter `f', unused since
4860 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4861
4862 2011-04-02 Jim Meyering <meyering@redhat.com>
4863
4864 do not dereference NULL upon failed strdup
4865 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4866 (ns_get_family): Likewise.
4867
4868 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4869
4870 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4871
4872 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4873
4874 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4875 later (Bug#8403).
4876
4877 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4878
4879 Add lexical binding.
4880
4881 * window.c (Ftemp_output_buffer_show): New fun.
4882 (Fsave_window_excursion):
4883 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4884
4885 * lread.c (lisp_file_lexically_bound_p): New function.
4886 (Fload): Bind Qlexical_binding.
4887 (readevalloop): Remove `evalfun' arg.
4888 Bind Qinternal_interpreter_environment.
4889 (Feval_buffer): Bind Qlexical_binding.
4890 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4891 Mark as dynamic.
4892 (syms_of_lread): Declare `lexical-binding'.
4893
4894 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4895
4896 * keyboard.c (eval_dyn): New fun.
4897 (menu_item_eval_property): Use it.
4898
4899 * image.c (parse_image_spec): Use Ffunctionp.
4900
4901 * fns.c (concat, mapcar1): Accept byte-code-functions.
4902
4903 * eval.c (Fsetq): Handle lexical vars.
4904 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4905 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4906 (FletX, Flet): Obey lexical binding.
4907 (Fcommandp): Handle closures.
4908 (Feval): New `lexical' arg.
4909 (eval_sub): New function extracted from Feval. Use it almost
4910 everywhere where Feval was used. Look up vars in lexical env.
4911 Handle closures.
4912 (Ffunctionp): Move from subr.el.
4913 (Ffuncall): Handle closures.
4914 (apply_lambda): Remove `eval_flags'.
4915 (funcall_lambda): Handle closures and new byte-code-functions.
4916 (Fspecial_variable_p): New function.
4917 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4918 but without exporting it to Lisp.
4919
4920 * doc.c (Fdocumentation, store_function_docstring):
4921 * data.c (Finteractive_form): Handle closures.
4922
4923 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4924 interactive spec.
4925
4926 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4927 New byte-codes.
4928 (exec_byte_code): New function extracted from Fbyte_code to handle new
4929 calling convention for byte-code-functions. Add new byte-codes.
4930
4931 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4932
4933 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4934
4935 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4936
4937 * xdisp.c (redisplay_internal): Fix prototype.
4938
4939 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4940
4941 * xdisp.c (SCROLL_LIMIT): New macro.
4942 (try_scrolling): Use it when setting scroll_limit.
4943 Limit scrolling to 100 screen lines.
4944 (redisplay_window): Even when falling back on "recentering",
4945 position point in the window according to scroll-conservatively,
4946 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4947
4948 (try_scrolling): When point is above the window, allow searching
4949 as far as scroll_max, or one screenful, to compute vertical
4950 distance from PT to the scroll margin position. This prevents
4951 try_scrolling from unnecessarily failing when
4952 scroll-conservatively is set to a value slightly larger than the
4953 window height. Clean up the case of PT below the margin at bottom
4954 of window: scroll_max can no longer be INT_MAX. When aggressive
4955 scrolling is in use, don't let point enter the opposite scroll
4956 margin as result of the scroll.
4957 (syms_of_xdisp) <scroll-conservatively>: Document the
4958 threshold of 100 lines for never-recentering scrolling.
4959
4960 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4961
4962 * dispextern.h (move_it_by_lines):
4963 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4964 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4965 (message_log_check_duplicate): Remove parameters `prev_bol' and
4966 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4967 (redisplay_internal): Remove parameter `preserve_echo_area',
4968 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4969
4970 * indent.c (Fvertical_motion):
4971 * window.c (window_scroll_pixel_based, Frecenter):
4972 Don't pass `need_y_p' to `move_it_by_lines'.
4973
4974 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4975
4976 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4977 steal a few bits to be more compact.
4978 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4979 Remove unneeded casts.
4980
4981 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4982
4983 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4984
4985 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4986 binding" message (bug#7967).
4987
4988 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4989
4990 Fix more problems found by GCC 4.6.0's static checks.
4991
4992 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4993 Remove unused local var.
4994
4995 * editfns.c (Fmessage_box): Remove unused local var.
4996
4997 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4998 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4999 Omit unused local vars.
5000 * window.c (shrink_windows): Omit unused local var.
5001 * menu.c (digest_single_submenu): Omit unused local var.
5002 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5003 Omit unused local var.
5004
5005 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5006 Don't assume string length fits in int.
5007 (keyremap_step, read_key_sequence): Use size_t for sizes.
5008 (read_key_sequence): Don't check last_real_key_start redundantly.
5009
5010 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5011 instead of alloca (Bug#8344).
5012
5013 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5014 (Fbacktrace_frame): Don't assume nframes fits in int.
5015
5016 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5017
5018 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5019 concerns.
5020
5021 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5022
5023 * cm.c (calccost): Turn while-do into do-while, for clarity.
5024
5025 * keyboard.c (syms_of_keyboard): Use the same style as later
5026 in this function when indexing through an array. This also
5027 works around GCC bug 48267.
5028
5029 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5030
5031 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5032
5033 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5034 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5035
5036 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5037 This avoids undefined behavior on integer overflow, and is a bit
5038 more convenient anyway since it is compared to a size_t variable.
5039
5040 Variadic C functions now count arguments with size_t, not int.
5041 This avoids an unnecessary limitation on 64-bit machines, which
5042 caused (substring ...) to crash on large vectors (Bug#8344).
5043 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5044 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5045 All variadic functions and their callers changed accordingly.
5046 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5047 * data.c (arith_driver, float_arith_driver): Likewise.
5048 * editfns.c (general_insert_function): Likewise.
5049 * eval.c (struct backtrace.nargs, interactive_p)
5050 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5051 (funcall_lambda, mark_backtrace): Likewise.
5052 * fns.c (concat): Likewise.
5053 * frame.c (x_set_frame_parameters): Likewise.
5054 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5055 0 if not found, not -1. All callers changed.
5056
5057 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5058 (stack_copy_size): Now size_t, not int.
5059 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5060
5061 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5062
5063 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5064 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5065 All callers changed.
5066
5067 * lisp.h (multibyte_char_to_unibyte):
5068 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5069 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5070 * character.h (CHAR_TO_BYTE8):
5071 * cmds.c (internal_self_insert):
5072 * editfns.c (general_insert_function):
5073 * keymap.c (push_key_description):
5074 * search.c (Freplace_match):
5075 * xdisp.c (message_dolog, set_message_1): All callers changed.
5076
5077 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5078
5079 * keyboard.c (safe_run_hook_funcall): New function.
5080 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5081 don't set the hook to nil, but remove the offending function instead.
5082 (Qcommand_hook_internal): Remove, unused.
5083 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5084 Vcommand_hook_internal.
5085
5086 * eval.c (enum run_hooks_condition): Remove.
5087 (funcall_nil, funcall_not): New functions.
5088 (run_hook_with_args): Call each function through a `funcall' argument.
5089 Remove `cond' argument, now redundant.
5090 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5091 (Frun_hook_with_args_until_failure): Adjust accordingly.
5092 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5093
5094 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5095
5096 * dispextern.h (string_buffer_position): Remove declaration.
5097
5098 * print.c (strout): Remove parameter `multibyte', unused since
5099 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5100
5101 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5102 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5103 All callers changed.
5104
5105 * w32.c (_wsa_errlist): Use braces for struct initializers.
5106
5107 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5108 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5109 All callers changed.
5110 (string_buffer_position): Likewise. Also, make static (it's never
5111 used outside xdisp.c).
5112 (cursor_row_p): Remove parameter `w', unused since
5113 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5114 (decode_mode_spec): Remove parameter `precision', introduced during
5115 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5116 All callers changed.
5117
5118 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5119
5120 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5121
5122 2011-03-27 Anders Lindgren <andlind@gmail.com>
5123
5124 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5125 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5126 (ns_update_auto_hide_menu_bar): New functions.
5127 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5128 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5129 ns_constrain_all_frames.
5130 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5131 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5132
5133 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5134
5135 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5136
5137 2011-03-27 Glenn Morris <rgm@gnu.org>
5138
5139 * syssignal.h: Replace RETSIGTYPE with void.
5140 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5141 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5142 Replace SIGTYPE with void everywhere.
5143 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5144 * s/template.h (SIGTYPE): Remove commented out definition.
5145
5146 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5147
5148 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5149 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5150
5151 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5152
5153 * w32.c (read_unc_volume): Use parameter `henum', instead of
5154 global variable `wget_enum_handle'.
5155
5156 * keymap.c (describe_vector): Remove parameters `indices' and
5157 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5158 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5159
5160 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5161
5162 * keyboard.c (timer_check): Remove parameter `do_it_now',
5163 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5164 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5165 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5166
5167 * keyboard.c (read_char):
5168 * w32menu.c (w32_menu_display_help):
5169 * xmenu.c (show_help_event, menu_help_callback):
5170 Adjust calls to `show_help_echo'.
5171
5172 * gtkutil.c (xg_maybe_add_timer):
5173 * keyboard.c (readable_events):
5174 * process.c (wait_reading_process_output):
5175 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5176
5177 * insdel.c (adjust_markers_gap_motion):
5178 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5179 (gap_left, gap_right): Don't call it.
5180
5181 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5182
5183 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5184 incurred during fontification.
5185
5186 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5187
5188 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5189 (DEFVAR_PER_BUFFER): Don't pass it.
5190
5191 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5192 (scrolling_window): Don't pass it.
5193
5194 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5195
5196 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5197
5198 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5199 and `suffix'.
5200 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5201 of variables specific to SELinux and computation of `encoded_absname'.
5202
5203 * image.c (XPutPixel): Remove unused variable `height'.
5204
5205 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5206
5207 * unexw32.c (get_section_info): Remove unused variable `section'.
5208
5209 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5210 (system_process_attributes): Remove unused variable `sess'.
5211 (sys_read): Remove unused variable `err'.
5212
5213 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5214 (w32_wnd_proc): Remove unused variable `isdead'.
5215 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5216 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5217 (x_create_tip_frame): Remove unused variable `tem'.
5218
5219 * w32inevt.c (w32_console_read_socket):
5220 Remove unused variable `no_events'.
5221
5222 * w32term.c (x_draw_composite_glyph_string_foreground):
5223 Remove unused variable `width'.
5224
5225 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5226
5227 * w32term.c (x_set_glyph_string_clipping):
5228 Don't pass uninitialized region to CombineRgn.
5229
5230 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5231
5232 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5233 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5234 (Fx_close_connection): Remove unused variable `i'.
5235
5236 * w32font.c (w32font_draw): Return number of glyphs.
5237 (w32font_open_internal): Remove unused variable `i'.
5238 (w32font_driver): Add missing initializer.
5239
5240 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5241 (fill_in_menu): Remove unused variable `items_added'.
5242
5243 * w32term.c (last_mouse_press_frame): Remove static global variable.
5244 (w32_clip_to_row): Remove unused variable `f'.
5245 (x_delete_terminal): Remove unused variable `i'.
5246
5247 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5248 (NOTHING): Remove unused static global variable.
5249 (uniscribe_check_otf): Remove unused variable `table'.
5250 (uniscribe_font_driver): Add missing initializers.
5251
5252 2011-03-23 Julien Danjou <julien@danjou.info>
5253
5254 * term.c (Fsuspend_tty, Fresume_tty):
5255 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5256 * window.c (temp_output_buffer_show):
5257 * insdel.c (signal_before_change):
5258 * frame.c (Fhandle_switch_frame):
5259 * fileio.c (Fdo_auto_save):
5260 * emacs.c (Fkill_emacs):
5261 * editfns.c (save_excursion_restore):
5262 * cmds.c (internal_self_insert):
5263 * callint.c (Fcall_interactively):
5264 * buffer.c (Fkill_all_local_variables):
5265 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5266 Use Frun_hooks.
5267 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5268 unconditionnaly since it does the check itself.
5269
5270 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5271
5272 Fix more problems found by GCC 4.5.2's static checks.
5273
5274 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5275 the first time through the loop, since we know p0 < p1 then.
5276 This also avoids a gcc -Wstrict-overflow warning.
5277
5278 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5279 leading to a memory leak, possible in functions like
5280 load_charset_map_from_file that can allocate an unbounded number
5281 of objects (Bug#8318).
5282
5283 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5284 that could (at least in theory) be that large.
5285
5286 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5287 This is less likely to overflow, and avoids undefined behavior if
5288 overflow does occur. All callers changed. Use strtoul to scan
5289 for the unsigned long integer.
5290 (pint2hrstr): Simplify and tune code slightly.
5291 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5292
5293 * scroll.c (do_scrolling): Work around GCC bug 48228.
5294 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5295
5296 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5297 This also avoids a warning with gcc -Wstrict-overflow.
5298 (validate_x_resource_name): Simplify count usage.
5299 This also avoids a warning with gcc -Wstrict-overflow.
5300
5301 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5302 fail (Bug#8306).
5303
5304 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5305
5306 * process.c (Fmake_network_process): Use socklen_t, not int,
5307 where POSIX says socklen_t is required in portable programs.
5308 This fixes a porting bug on hosts like 64-bit HP-UX, where
5309 socklen_t is wider than int (Bug#8277).
5310 (Fmake_network_process, server_accept_connection):
5311 (wait_reading_process_output, read_process_output):
5312 Likewise.
5313
5314 * process.c: Rename or move locals to avoid shadowing.
5315 (list_processes_1, Fmake_network_process):
5316 (read_process_output_error_handler, exec_sentinel_error_handler):
5317 Rename or move locals.
5318 (Fmake_network_process): Define label "retry_connect" only if needed.
5319 (Fnetwork_interface_info): Fix pointer signedness.
5320 (process_send_signal): Add cast to avoid pointer signedness problem.
5321 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5322 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5323
5324 Make tparam.h and terminfo.c consistent.
5325 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5326 Include tparam.h instead, since it declares them.
5327 * cm.h (PC): Remove extern decl; tparam.h now does this.
5328 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5329 * terminfo.c: Include tparam.h, to check interfaces.
5330 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5331 (tparam): Adjust signature to match interface in tparam.h;
5332 this removes some undefined behavior. Check that outstring and len
5333 are zero, which they always are with Emacs.
5334 * tparam.h (PC, BC, UP): New extern decls.
5335
5336 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5337 (xftfont_open): Rename locals to avoid shadowing.
5338
5339 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5340 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5341 (OTF_TAG_SYM): Omit macro if not needed.
5342 (ftfont_list): Remove unused local.
5343 (get_adstyle_property, ftfont_pattern_entity):
5344 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5345 Rename locals to avoid shadowing.
5346
5347 * xfont.c (xfont_list_family): Mark var as initialized.
5348
5349 * xml.c (make_dom): Now static.
5350
5351 * composite.c (composition_compute_stop_pos): Rename local to
5352 avoid shadowing.
5353 (composition_reseat_it): Remove unused locals.
5354 (find_automatic_composition, composition_adjust_point): Likewise.
5355 (composition_update_it): Mark var as initialized.
5356 (find_automatic_composition): Mark vars as initialized,
5357 with a FIXME (Bug#8290).
5358
5359 character.h: Rename locals to avoid shadowing.
5360 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5361 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5362 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5363 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5364 to avoid shadowing.
5365
5366 * textprop.c (property_change_between_p): Remove; unused.
5367
5368 * intervals.c (interval_start_pos): Now static.
5369
5370 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5371
5372 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5373 Rename locals to avoid shadowing.
5374
5375 * sound.c (wav_play, au_play, Fplay_sound_internal):
5376 Fix pointer signedness.
5377 (alsa_choose_format): Remove unused local var.
5378 (wav_play): Initialize a variable to 0, to prevent undefined
5379 behavior (Bug#8278).
5380
5381 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5382
5383 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5384
5385 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5386 clobbering (Bug#8298).
5387 * sysdep.c (sys_subshell): Likewise.
5388 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5389
5390 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5391 This should get cleaned up, so that child_setup has the
5392 same signature on all platforms.
5393
5394 * callproc.c (call_process_cleanup): Now static.
5395 (relocate_fd): Rename locals to avoid shadowing.
5396
5397 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5398
5399 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5400 not to be necessary, and produces flickering.
5401
5402 2011-03-20 Glenn Morris <rgm@gnu.org>
5403
5404 * config.in: Remove file.
5405
5406 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5407
5408 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5409 are now in src/globals.h.
5410 (syms_of_minibuf): Remove spurious & from previous change.
5411
5412 2011-03-20 Leo <sdl.web@gmail.com>
5413
5414 * minibuf.c (completing-read-function): New variable.
5415 (completing-read-default): Rename from completing-read.
5416 (completing-read): Call completing-read-function.
5417
5418 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5419
5420 * xfaces.c (Fx_load_color_file):
5421 Read color file from absolute filename (bug#8250).
5422
5423 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5424
5425 * makefile.w32-in: Update dependencies.
5426
5427 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5428
5429 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5430
5431 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5432
5433 Fix more problems found by GCC 4.5.2's static checks.
5434
5435 * process.c (make_serial_process_unwind, send_process_trap):
5436 (sigchld_handler): Now static.
5437
5438 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5439 That way, the code declares only the vars that it needs.
5440 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5441 * s/cygwin.h (PTY_ITERATION): Likewise.
5442 * s/darwin.h (PTY_ITERATION): Likewise.
5443 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5444
5445 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5446 * process.c (allocate_pty): Don't declare stb unless it's needed.
5447
5448 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5449 (CONSTANTLIM): Remove; unused.
5450 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5451 Define only if needed.
5452
5453 * unexelf.c (unexec): Name an expression,
5454 to avoid gcc -Wbad-function-cast warning.
5455 Use a different way to cause a compilation error if anyone uses
5456 n rather than nn, a way that does not involve shadowing.
5457 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5458
5459 * deps.mk (unexalpha.o): Remove; unused.
5460
5461 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5462 * unexec.h: New file.
5463 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5464 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5465 Depend on unexec.h.
5466 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5467 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5468 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5469 Change as necessary to match prototype in unexec.h.
5470
5471 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5472 shadowing.
5473 (back_comment, skip_chars): Mark vars as initialized.
5474
5475 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5476 Rename locals to avoid shadowing.
5477
5478 * lread.c (read1): Rewrite so as not to use empty "else".
5479 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5480
5481 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5482
5483 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5484 warning when compiling print.c.
5485
5486 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5487 instead of using an uninitialized var.
5488 (font_sort_entities): Mark var as initialized.
5489
5490 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5491
5492 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5493 pointers to constants.
5494 (font_parse_fcname): Remove unused vars.
5495 (font_delete_unmatched): Now static.
5496 (font_get_spec): Remove; unused.
5497 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5498 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5499 Rename or move locals to avoid shadowing.
5500
5501 * fns.c (require_nesting_list, require_unwind): Now static.
5502 (Ffillarray): Rename locals to avoid shadowing.
5503
5504 * floatfns.c (domain_error2): Define only if needed.
5505 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5506
5507 * alloc.c (mark_backtrace): Move decl from here ...
5508 * lisp.h: ... to here, so that it can be checked.
5509
5510 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5511 (Fdefvar): Rewrite so as not to use empty "else".
5512 (lisp_indirect_variable): Name an expression,
5513 to avoid gcc -Wbad-function-cast warning.
5514 (Fdefvar): Rename locals to avoid shadowing.
5515
5516 * callint.c (quotify_arg, quotify_args): Now static.
5517 (Fcall_interactively): Rename locals to avoid shadowing.
5518 Use const pointer when appropriate.
5519
5520 * lisp.h (get_system_name, get_operating_system_release):
5521 Move decls here, to check interfaces.
5522 * process.c (get_operating_system_release): Move decl to lisp.h.
5523 * xrdb.c (get_system_name): Likewise.
5524 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5525 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5526 some of which prompt warnings from gcc -Wbad-function-cast.
5527 (Fformat_time_string, Fencode_time, Finsert_char):
5528 (Ftranslate_region_internal, Fformat):
5529 Rename or remove local vars to avoid shadowing.
5530 (Ftranslate_region_internal): Mark var as initialized.
5531
5532 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5533 avoid shadowing.
5534
5535 * lisp.h (eassert): Check that the argument compiles, even if
5536 ENABLE_CHECKING is not defined.
5537
5538 * data.c (Findirect_variable): Name an expression, to avoid
5539 gcc -Wbad-function-cast warning.
5540 (default_value, arithcompare, arith_driver, arith_error): Now static.
5541 (store_symval_forwarding): Rename local to avoid shadowing.
5542 (Fmake_variable_buffer_local, Fmake_local_variable):
5543 Mark variables as initialized.
5544 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5545
5546 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5547 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5548 Rename locals to avoid shadowing.
5549 (mark_stack): Move local variables into the #ifdef region where
5550 they're used.
5551 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5552 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5553 needed otherwise.
5554 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5555 (GC_STRING_CHARS): Remove; not used.
5556 (Fmemory_limit): Cast sbrk's returned value to char *.
5557
5558 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5559 avoids undefined behavior in theory.
5560
5561 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5562
5563 Use functions, not macros, for up- and down-casing (Bug#8254).
5564 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5565 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5566 to use the following functions instead of these macros.
5567 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5568 EMACS_INT, since callers assume the returned value fits in int.
5569 (upcase1): Likewise, for UPCASE_TABLE.
5570 (uppercasep, lowercasep, upcase): New static inline functions.
5571 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5572 the race-condition problem in the old DOWNCASE.
5573
5574 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5575 Rename locals to avoid shadowing.
5576 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5577 (regex_compile, re_search_2, re_match_2_internal):
5578 Remove unused local vars.
5579 (FREE_VAR): Rewrite so as not to use empty "else",
5580 which gcc can warn about.
5581 (regex_compile, re_match_2_internal): Mark locals as initialized.
5582 (RETALLOC_IF): Define only if needed.
5583 (WORDCHAR_P): Likewise. This one is never needed, but is used
5584 only in a comment talking about a compiler bug, so put inside
5585 the #if 0 of that comment.
5586 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5587 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5588 Remove; unused.
5589
5590 * search.c (boyer_moore): Rename locals to avoid shadowing.
5591 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5592 (PREV_CHAR_BOUNDARY): Likewise.
5593
5594 * search.c (simple_search): Remove unused var.
5595
5596 * dired.c (compile_pattern): Move decl from here ...
5597 * lisp.h: ... to here, so that it can be checked.
5598 (struct re_registers): New forward decl.
5599
5600 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5601
5602 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5603 All uses changed.
5604 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5605 Rename locals to avoid shadowing.
5606 (Fvertical_motion): Mark locals as initialized.
5607
5608 * casefiddle.c (casify_object, casify_region): Now static.
5609 (casify_region): Mark local as initialized.
5610
5611 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5612
5613 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5614 New macros, so that the caller can use some names other than
5615 gcpro1, gcpro2, etc.
5616 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5617 of the new macros.
5618 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5619 argument, for consistency with GCPRO2_VAR, etc: it is now the
5620 prefix of the variable, not the variable itself. All uses
5621 changed.
5622 * dired.c (directory_files_internal, file_name_completion):
5623 Rename locals to avoid shadowing.
5624
5625 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5626 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5627 dired.c's scmp function, had undefined behavior.
5628 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5629 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5630 * buffer.h: ... to here, because these macros use current_buffer,
5631 and the new implementation with inline functions needs to have
5632 current_buffer in scope now, rather than later when the macros
5633 are used.
5634 (downcase, upcase1): New static inline functions.
5635 (DOWNCASE, UPCASE1): Reimplement using these functions.
5636 This avoids undefined behavior in expressions like
5637 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5638 from race conditions in accessing the global variables
5639 case_temp1 and case_temp2.
5640 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5641 * lisp.h (case_temp1, case_temp2): Remove their decls.
5642 * character.h (ASCII_CHAR_P): Move from here ...
5643 * lisp.h: ... to here, so that the inline functions mentioned
5644 above can use them.
5645
5646 * dired.c (directory_files_internal_unwind): Now static.
5647
5648 * fileio.c (file_name_as_directory, directory_file_name):
5649 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5650 Now static.
5651 (file_name_as_directory): Use const pointers when appropriate.
5652 (Fexpand_file_name): Likewise. In particular, newdir might
5653 point at constant storage, so make it a const pointer.
5654 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5655 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5656 signedness issues.
5657 (Fset_file_times, Finsert_file_contents, auto_save_error):
5658 Rename locals to avoid shadowing.
5659
5660 * minibuf.c (choose_minibuf_frame_1): Now static.
5661 (Ftry_completion, Fall_completions): Rename or remove locals
5662 to avoid shadowing.
5663
5664 * marker.c (bytepos_to_charpos): Remove; unused.
5665
5666 * lisp.h (verify_bytepos, count_markers): New decls,
5667 so that gcc does not warn that these functions aren't declared.
5668
5669 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5670 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5671 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5672 (copy_text): Remove unused local var.
5673
5674 * filelock.c (within_one_second): Now static.
5675 (lock_file_1): Rename local to avoid shadowing.
5676
5677 * buffer.c (fix_overlays_before): Mark locals as initialized.
5678 (fix_start_end_in_overlays): Likewise. This function should be
5679 simplified by using pointers-to-pointers, but that's a different
5680 matter.
5681 (switch_to_buffer_1): Now static.
5682 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5683 (report_overlay_modification): Rename locals to avoid shadowing.
5684
5685 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5686 Fix pointer signedness issue.
5687 (sys_subshell): Mark local as volatile if checking for lint,
5688 to suppress a gcc -Wclobbered warning that does not seem to be right.
5689 (MAXPATHLEN): Define only if needed.
5690
5691 * process.c (serial_open, serial_configure): Move decls from here ...
5692 * systty.h: ... to here, so that they can be checked.
5693
5694 * fns.c (get_random, seed_random): Move extern decls from here ...
5695 * lisp.h: ... to here, so that they can be checked.
5696
5697 * sysdep.c (reset_io): Now static.
5698 (wait_for_termination_signal): Remove; unused.
5699
5700 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5701 (copy_keymap_item, append_key, push_text_char_description):
5702 Now static.
5703 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5704 (DENSE_TABLE_SIZE): Remove; unused.
5705 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5706 (describe_map_tree):
5707 Rename locals to avoid shadowing.
5708
5709 * keyboard.c: Declare functions static if they are not used elsewhere.
5710 (echo_char, echo_dash, cmd_error, top_level_2):
5711 (poll_for_input, handle_async_input): Now static.
5712 (read_char, kbd_buffer_get_event, make_lispy_position):
5713 (make_lispy_event, make_lispy_movement, apply_modifiers):
5714 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5715 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5716 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5717 (read_key_sequence, read_char): Mark locals as initialized.
5718 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5719
5720 * keyboard.h (make_ctrl_char): New decl.
5721 (mark_kboards): Move decl here ...
5722 * alloc.c (mark_kboards): ... from here.
5723
5724 * lisp.h (force_auto_save_soon): New decl.
5725
5726 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5727 (DEFINE_DUMMY_FUNCTION): New macro.
5728 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5729 Use it.
5730 (main): Add casts to avoid warnings
5731 if GCC considers string literals to be constants.
5732
5733 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5734
5735 * dbusbind.c: Pointer signedness fixes.
5736 (xd_signature, xd_append_arg, xd_initialize):
5737 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5738 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5739 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5740 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5741
5742 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5743 if GCC considers string literals to be constants.
5744 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5745
5746 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5747
5748 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5749 (print_preprocess, print_object): New macro to fix last change.
5750
5751 * print.c (print_preprocess): Don't forget font objects.
5752
5753 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5754
5755 * emacs.c (USAGE3): Doc fixes.
5756
5757 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5758
5759 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5760 structure.
5761
5762 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5763
5764 * lisp.h (VWindow_system, Qfile_name_history):
5765 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5766 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5767 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5768
5769 * w32select.c: Don't #include "keyboard.h".
5770 (run_protected): Add extern declaration for waiting_for_input.
5771
5772 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5773 * w32console.c (detect_input_pending, read_input_pending)
5774 (encode_terminal_code):
5775 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5776 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5777 (w32_system_caret_y, Qfile_name_history):
5778 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5779 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5780 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5781 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5782 * w32proc.c (Qlocal, report_file_error):
5783 * w32term.c (Vwindow_system, updating_frame):
5784 * w32uniscribe.c (initialized, uniscribe_font_driver):
5785 Remove unneeded extern declarations.
5786
5787 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5788
5789 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5790
5791 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5792
5793 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5794 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5795 These macros can no longer be used for assignment.
5796
5797 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5798 Assign struct members directly, instead of using BUF_BEGV etc.
5799 (record_buffer_markers, fetch_buffer_markers): New functions for
5800 recording and fetching special buffer markers.
5801 (set_buffer_internal_1, set_buffer_temp): Use them.
5802
5803 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5804
5805 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5806
5807 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5808 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5809
5810 * xdisp.c (hscroll_window_tree):
5811 (reconsider_clip_changes): Use PT instead of BUF_PT.
5812
5813 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5814
5815 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5816 $(EMACS_ROOT)/lib/intprops.h.
5817
5818 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5819
5820 Fix more problems found by GCC 4.5.2's static checks.
5821
5822 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5823 to unsigned char * to avoid compiler diagnostic.
5824 (xg_free_frame_widgets): Make it clear that a local variable is
5825 needed only if USE_GTK_TOOLTIP.
5826 (gdk_window_get_screen): Make it clear that this macro is needed
5827 only if USE_GTK_TOOLTIP.
5828 (int_gtk_range_get_value): New function, which avoids a diagnostic
5829 from gcc -Wbad-function-cast.
5830 (xg_set_toolkit_scroll_bar_thumb): Use it.
5831 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5832 diagnostic from gcc -Wbad-function-cast.
5833 (get_utf8_string, xg_get_file_with_chooser):
5834 Rename locals to avoid shadowing.
5835 (create_dialog): Move locals to avoid shadowing.
5836
5837 * xgselect.c (xg_select): Remove unused var.
5838
5839 * image.c (four_corners_best): Mark locals as initialized.
5840 (gif_load): Initialize transparent_p to zero (Bug#8238).
5841 Mark another local as initialized.
5842 (my_png_error, my_error_exit): Mark with NO_RETURN.
5843
5844 * image.c (clear_image_cache): Now static.
5845 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5846 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5847 (x_edge_detection): Remove unnecessary cast that
5848 gcc -Wbad-function-cast diagnoses.
5849 (gif_load): Fix pointer signedness.
5850 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5851 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5852
5853 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5854
5855 Improve quality of tests for time stamp overflow.
5856 For example, without this patch (encode-time 0 0 0 1 1
5857 1152921504606846976) returns the obviously-bogus value (-948597
5858 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5859 reports time overflow. See
5860 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5861 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5862 * editfns.c: Include limits.h and intprops.h.
5863 (TIME_T_MIN, TIME_T_MAX): New macros.
5864 (time_overflow): Move earlier, to before first use.
5865 (hi_time, lo_time): New functions, for an accurate test for
5866 out-of-range times.
5867 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5868 (Fget_internal_run_time): Don't assume time_t fits in int.
5869 (make_time): Use list2 instead of Fcons twice.
5870 (Fdecode_time): More accurate test for out-of-range times.
5871 (check_tm_member): New function.
5872 (Fencode_time): Use it, to test for out-of-range times.
5873 (lisp_time_argument): Don't rely on undefined left-shift and
5874 right-shift behavior when checking for time stamp overflow.
5875
5876 * editfns.c (time_overflow): New function, refactoring common code.
5877 (Fformat_time_string, Fdecode_time, Fencode_time):
5878 (Fcurrent_time_string): Use it.
5879
5880 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5881 * dired.c (make_time): Move to ...
5882 * editfns.c (make_time): ... here.
5883 * systime.h: Note the move.
5884
5885 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5886
5887 * fringe.c (update_window_fringes): Remove unused variables.
5888
5889 * unexmacosx.c (copy_data_segment): Also copy __got section.
5890 (Bug#8223)
5891
5892 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5893
5894 * termcap.c [MSDOS]: Include "msdos.h".
5895 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5896 Constify `char *' arguments and their references according to
5897 prototypes in tparam.h.
5898
5899 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5900
5901 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5902 Adapt all references accordingly.
5903
5904 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5905
5906 2011-03-11 Tom Tromey <tromey@redhat.com>
5907
5908 * buffer.c (syms_of_buffer): Remove obsolete comment.
5909
5910 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5911
5912 * termhooks.h (encode_terminal_code): Declare prototype.
5913
5914 * msdos.c (encode_terminal_code): Don't declare prototype.
5915
5916 * term.c (encode_terminal_code): Now external again, used by
5917 w32console.c and msdos.c.
5918
5919 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5920 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5921
5922 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5923
5924 Fix some minor problems found by GCC 4.5.2's static checks.
5925
5926 * fringe.c (update_window_fringes): Mark locals as initialized
5927 (Bug#8227).
5928 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5929
5930 * alloc.c (mark_fringe_data): Move decl from here ...
5931 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5932 to check its interface.
5933 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5934
5935 * fontset.c (free_realized_fontset): Now static.
5936 (Fset_fontset_font): Rename local to avoid shadowing.
5937 (fontset_font): Mark local as initialized.
5938 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5939
5940 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5941
5942 * xselect.c (x_disown_buffer_selections): Remove; not used.
5943 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5944 (x_own_selection, Fx_disown_selection_internal): Rename locals
5945 to avoid shadowing.
5946 (x_handle_dnd_message): Remove local to avoid shadowing.
5947
5948 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5949 so that the caller can use some name other than gcpro1.
5950 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5951 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5952 (Fx_backspace_delete_keys_p):
5953 Use them to avoid shadowing, and rename vars to avoid shadowing.
5954 (x_decode_color, x_set_name, x_window): Now static.
5955 (Fx_create_frame): Add braces to silence GCC warning.
5956 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5957 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5958 Remove unused locals.
5959 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5960 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5961 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5962 macros.
5963
5964 * xterm.h (x_mouse_leave): New decl.
5965
5966 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5967 Remove unused functions.
5968 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5969 (x_calc_absolute_position): Now static.
5970 (XTread_socket): Don't define label "out" unless it's used.
5971 Don't declare local "event" unless it's used.
5972 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5973 unless they are used.
5974 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5975 (x_fatal_error_signal): Remove; not used.
5976 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5977 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5978 (x_error_catcher, x_connection_closed, x_error_handler):
5979 (x_error_quitter, xembed_send_message, x_iconify_frame):
5980 (my_log_handler): Rename locals to avoid shadowing.
5981 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5982 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5983
5984 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5985 Rename or move locals to avoid shadowing.
5986 (tty_defined_color, merge_face_heights): Now static.
5987 (free_realized_faces_for_fontset): Remove; not used.
5988 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5989 does not deduce is never used uninitialized.
5990 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5991 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5992
5993 * terminal.c (store_terminal_param): Now static.
5994
5995 * xmenu.c (menu_highlight_callback): Now static.
5996 (set_frame_menubar): Remove unused local.
5997 (xmenu_show): Rename parameter to avoid shadowing.
5998 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5999 since they might point to immutable storage.
6000 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6001 since it's unused otherwise.
6002
6003 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
6004 Add a FIXME, since the code still doesn't look right. (Bug#8215)
6005 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6006 avoids a gcc -Wuninitialized diagnostic.
6007 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
6008 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6009 does not deduce are never used uninitialized.
6010
6011 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6012
6013 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
6014 * window.c (window_loop, size_window):
6015 (run_window_configuration_change_hook, enlarge_window): Likewise.
6016
6017 * window.c (display_buffer): Now static.
6018 (size_window): Mark variables that gcc -Wuninitialized
6019 does not deduce are never used uninitialized.
6020 * window.h (check_all_windows): New decl, to forestall
6021 gcc -Wmissing-prototypes diagnostic.
6022 * dispextern.h (bidi_dump_cached_states): Likewise.
6023
6024 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6025 shadowing.
6026 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
6027 Include <limits.h>.
6028 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6029 and to avoid gcc -Wuninitialized warning.
6030 (load_charset_map): Mark variables that gcc -Wuninitialized
6031 does not deduce are never used uninitialized.
6032 (load_charset): Abort instead of using uninitialized var (Bug#8229).
6033
6034 * coding.c (coding_set_source, coding_set_destination):
6035 Use "else { /* comment */ }" rather than "else /* comment */;"
6036 for clarity, and to avoid gcc -Wempty-body warning.
6037 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6038 a block, when the outer 'i' will do.
6039 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6040 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6041 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6042 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6043 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6044 Rename locals to avoid shadowing.
6045 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6046 * coding.c (emacs_mule_char, encode_invocation_designation):
6047 Now static, since they're not used elsewhere.
6048 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6049 (decode_coding_object, encode_coding_object, detect_coding_system):
6050 (decode_coding_emacs_mule): Mark variables that gcc
6051 -Wuninitialized does not deduce are never used uninitialized.
6052 (detect_coding_iso_2022): Initialize a local variable that might
6053 be used uninitialized. Leave a FIXME because it's not clear that
6054 this initialization is needed. (Bug#8211)
6055 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6056 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6057 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6058 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6059 Remove unused macros.
6060
6061 * category.c (hash_get_category_set): Remove unused local var.
6062 (copy_category_table): Now static, since it's not used elsewhere.
6063 * character.c (string_count_byte8): Likewise.
6064
6065 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6066 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6067
6068 * chartab.c (copy_sub_char_table): Now static, since it's not used
6069 elsewhere.
6070 (sub_char_table_ref_and_range, char_table_ref_and_range):
6071 Rename locals to avoid shadowing.
6072 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6073
6074 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6075 (BIDI_BOB): Remove unused macro.
6076
6077 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6078 deduce are never used uninitialized.
6079 * term.c (encode_terminal_code): Likewise.
6080
6081 * term.c (encode_terminal_code): Now static. Remove unused local.
6082
6083 * tparam.h: New file.
6084 * term.c, tparam.h: Include it.
6085 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6086 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6087 Move these decls to tparam.h, and make them agree with what
6088 is actually in tparam.c. The previous trick of using incompatible
6089 decls in different modules does not conform to the C standard.
6090 All callers of tparam changed to use tparam's actual API.
6091 * tparam.c (tparam1, tparam, tgoto):
6092 Use const pointers where appropriate.
6093
6094 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6095 * cm.h (struct cm): Likewise.
6096 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6097 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6098 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6099 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6100 (turn_on_face, init_tty): Likewise.
6101 * termchar.h (struct tty_display_info): Likewise.
6102
6103 * term.c (term_mouse_position): Rename local to avoid shadowing.
6104
6105 * alloc.c (mark_ttys): Move decl from here ...
6106 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6107
6108 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6109
6110 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6111
6112 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6113
6114 * search.c (compile_pattern_1): Remove argument regp, unused since
6115 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6116 (compile_pattern): Don't pass it.
6117
6118 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6119
6120 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6121 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6122 for ! HAVE_GTK3.
6123 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6124
6125 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6126
6127 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6128 gdk_window_get_screen, gdk_window_get_geometry,
6129 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6130 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6131 (xg_get_pixbuf_from_pixmap): New function.
6132 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6133 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6134 Call xg_get_pixbuf_from_pixmap instead of
6135 gdk_pixbuf_get_from_drawable.
6136 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6137 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6138 (xg_check_special_colors): Use GtkStyleContext and its functions
6139 for HAVE_GTK3.
6140 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6141 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6142 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6143 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6144 Call gtk_widget_get_preferred_size.
6145 (xg_frame_resized): gdk_window_get_geometry only takes 5
6146 parameters.
6147 (xg_win_to_widget, xg_event_is_for_menubar):
6148 Call gdk_x11_window_lookup_for_display.
6149 (xg_set_widget_bg): New function.
6150 (delete_cb): New function.
6151 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6152 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6153 (xg_set_background_color): Call xg_set_widget_bg.
6154 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6155 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6156 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6157 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6158 if ! HAVE_GTK3.
6159 (update_frame_tool_bar): Call gtk_widget_hide.
6160 (xg_initialize): Use GDK_KEY_g.
6161
6162 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6163 if ! HAVE_GTK3
6164 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6165
6166 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6167 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6168 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6169
6170 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6171
6172 * w32xfns.c (select_palette): Check success of RealizePalette against
6173 GDI_ERROR, not zero.
6174
6175 See ChangeLog.11 for earlier changes.
6176
6177 ;; Local Variables:
6178 ;; coding: utf-8
6179 ;; End:
6180
6181 Copyright (C) 2011 Free Software Foundation, Inc.
6182
6183 This file is part of GNU Emacs.
6184
6185 GNU Emacs is free software: you can redistribute it and/or modify
6186 it under the terms of the GNU General Public License as published by
6187 the Free Software Foundation, either version 3 of the License, or
6188 (at your option) any later version.
6189
6190 GNU Emacs is distributed in the hope that it will be useful,
6191 but WITHOUT ANY WARRANTY; without even the implied warranty of
6192 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6193 GNU General Public License for more details.
6194
6195 You should have received a copy of the GNU General Public License
6196 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.