1 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3 * search.c: Integer overflow fixes
4 (Freplace_match): Use ptrdiff_t, not int, for indexes that can
5 exceed INT_MAX. Check that EMACS_INT value is in range before
6 assigning it to the (possibly-narrower) index.
7 (match_limit): Don't assume that a fixnum can fit in 'int'.
9 * print.c: Integer overflow fix.
10 (print_object): Use ptrdiff_t, not int, for index that can
13 * indent.c: Integer overflow fixes.
14 (position_indentation): Now takes ptrdiff_t, not int.
15 (Fvertical_motion): Don't wrap around LINES values that don't fit
16 in 'int'. Instead, treat them as extreme values. This is good
17 enough for windows, which can't have more than INT_MAX lines anyway.
19 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
21 * Require libxml/parser.h to avoid compilation warning.
23 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
25 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
26 since this reportedly can destroy thread storage.
28 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
30 * syntax.c (find_defun_start): Update all cache variables if
31 exiting early (Bug#9401).
33 2011-08-30 Eli Zaretskii <eliz@gnu.org>
35 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
37 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
38 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
39 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
41 * term.c (tty_append_glyph): New function.
42 (produce_stretch_glyph): Static function and its prototype deleted.
44 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
47 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
49 * image.c (parse_image_spec): Check for nonnegative, not for positive,
50 when checking :margin (Bug#9390).
51 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
52 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
53 so that the name doesn't mislead. All uses changed.
55 2011-08-28 Johan Bockgård <bojohan@gnu.org>
57 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
60 2011-08-27 Eli Zaretskii <eliz@gnu.org>
62 * xdisp.c (move_it_to): Don't bail out early when reaching
63 position beyond to_charpos, if we are scanning backwards.
64 (move_it_vertically_backward): When DY == 0, make sure we get to
65 the first character in the line after the newline.
67 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
69 * ccl.c: Improve and simplify overflow checking (Bug#9196).
70 (ccl_driver): Do not generate an out-of-range pointer.
71 (Fccl_execute_on_string): Remove unnecessary check for
72 integer overflow, noted by Stefan Monnier in
73 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
74 Remove a FIXME that didn't need fixing.
75 Simplify the newly-introduced buffer reallocation code.
77 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
79 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
81 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
83 Integer and memory overflow issues (Bug#9196).
85 * doc.c (get_doc_string): Rework so that
86 get_doc_string_buffer_size is the actual buffer size, rather than
87 being 1 less than the actual buffer size; this makes xpalloc more
90 * image.c (x_allocate_bitmap_record, cache_image):
91 * xselect.c (Fx_register_dnd_atom):
92 Simplify previous changes by using xpalloc.
94 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
95 since either will do and ptrdiff_t is convenient with xpalloc.
97 * charset.c (charset_table_size)
98 (struct charset_sort_data.priority): Now ptrdiff_t.
99 (charset_compare): Don't overflow if priorities differ greatly.
100 (Fsort_charsets): Don't assume list length fits in int.
101 Check for size-calculation overflow when allocating sort data.
102 (syms_of_charset): Allocate an initial charset table that is
103 just under 64 KiB, to avoid problems with glibc malloc and mmap.
105 * cmds.c (internal_self_insert): Check for size-calculation overflow.
107 * composite.h (struct composition.glyph_len): Now int, not unsigned.
108 The actual value is always <= INT_MAX, and leaving it unsigned made
109 overflow checking harder.
111 * dispextern.h (struct glyph_matrix.rows_allocated)
112 (struct face_cache.size): Now ptrdiff_t, for convenience in use
113 with xpalloc. The values are still always <= INT_MAX.
115 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
117 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
118 (SAFE_NALLOCA): New macro.
120 * region-cache.c (struct boundary.pos, find_cache_boundary)
121 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
122 (set_cache_region, invalidate_region_cache)
123 (revalidate_region_cache, know_region_cache, region_cache_forward)
124 (region_cache_backward, pp_cache):
125 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
126 so that ptrdiff_t * can be passed to xpalloc.
127 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
128 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
129 (pp_cache): Don't assume cache_len fits in int.
130 * region-cache.h: Adjust extern decls to match.
132 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
133 EMACS_INT, since either will do, for xpalloc.
135 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
136 (xnmalloc, xnrealloc, xpalloc): New functions.
138 * bidi.c (bidi_shelve_header_size): New constant.
139 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
140 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
142 * bidi.c (bidi_cache_shrink):
143 * buffer.c (overlays_at, overlays_in, record_overlay_string)
145 Don't update size of array until after memory allocation succeeds,
146 because xmalloc/xrealloc may not return.
147 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
148 now that we have proper integer overflow checking.
149 (record_overlay_string, overlay_strings): Catch overflows when
150 calculating size of overlay_str_buf.
152 * callproc.c (Fcall_process): Check for size overflow when
153 calculating size of args2.
154 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
155 Normally we prefer signed values, but sticking with ptrdiff_t would
156 require adding more-complicated checks.
158 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
159 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
160 Redo buffer-overflow calculations to avoid integer overflow.
161 Add a FIXME comment where memory seems to be over-allocated.
163 * character.c (Fstring): Check for size-calculation overflow.
165 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
166 unnecessary integer overflow. Check for size overflow.
167 (encode_coding_object): Don't update size until xmalloc succeeds.
169 * composite.c (get_composition_id): Check for overflow in glyph
172 Integer and memory overflow fixes for display code.
173 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
174 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
175 (scrolling_window): Check for overflow in size calculations.
176 (line_draw_cost, realloc_glyph_pool, add_row_entry):
177 Don't assume glyph table len fits in int.
178 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
179 (row_table_size): Now ptrdiff_t, not int.
180 (scrolling_window): Avoid overflow in size calculations.
181 Don't update size until allocation succeeds.
182 * fns.c (concat): Check for overflow in size calculations.
183 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
184 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
185 (NEXT_ALMOST_PRIME_LIMIT): New constant.
187 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
188 (get_doc_string): Check for size calculation overflow.
189 Don't update size until allocation succeeds.
190 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
191 EMACS_INT, where ptrdiff_t will do.
192 (Fsubstitute_command_keys): Check for string overflow.
194 * editfns.c (set_time_zone_rule): Don't assume environment length
196 (message_length): Now ptrdiff_t, not int.
197 (Fmessage_box): Don't update size until allocation succeeds.
198 Don't assume message length fits in int.
199 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
201 * emacs.c (main): Do not reallocate argv, since there is a null at
202 the end that can be overwritten, and this way there's no need to
203 worry about size-calculation overflow.
204 (sort_args): Check for size-calculation overflow.
206 * eval.c (init_eval_once, grow_specpdl): Don't update size until
208 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
210 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
211 (x_set_scroll_bar_width, x_figure_window_size):
212 Check for integer overflow.
213 (x_set_alpha): Do not assume XINT fits in int.
215 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
216 This is for the members text_lines, text_cols, total_lines, total_cols,
217 where the system imposes an 'int' limit.
219 * fringe.c (Fdefine_fringe_bitmap):
220 Don't update size until alloc works.
222 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
223 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
225 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
226 Check for size-calculation overflow.
227 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
228 do, as we prefer signed integers.
229 (id_to_widget.max_size, id_to_widget.used)
230 (xg_store_widget_in_map, xg_remove_widget_from_map)
231 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
232 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
233 Use and return ptrdiff_t, not int.
234 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
235 * gtkutil.h: Change prototypes to match the above.
237 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
238 are duplicate now that they've been promoted to lisp.h.
239 (x_allocate_bitmap_record, x_alloc_image_color)
240 (make_image_cache, cache_image, xpm_load):
241 Don't update size until alloc is done.
242 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
244 Check for size calculation overflow.
245 (ct_colors_allocated_max): New constant.
246 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
249 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
250 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
251 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
252 Use ptrdiff_t, not int, to count maps.
253 (read_char_minibuf_menu_prompt): Check for overflow in size
254 calculations. Don't update size until allocation succeeds. Redo
255 calculations to avoid overflow.
256 * keyboard.h: Change prototypes to match the above.
258 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
260 (current_minor_maps): Check for size calculation overflow.
261 * keymap.h: Change prototypes to match the above.
263 * lread.c (read1, init_obarray): Don't update size until alloc done.
265 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
266 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
268 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
269 Now ptrdiff_t, not int.
270 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
271 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
273 * process.c (Fnetwork_interface_list): Check for overflow
276 * region-cache.c (move_cache_gap): Check for size calculation overflow.
278 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
279 overflow. Don't bother calling xmalloc when xrealloc will do.
281 * search.c (Freplace_match): Check for size calculation overflow.
282 (Fset_match_data): Don't assume list lengths fit in 'int'.
284 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
285 for command line length. Do not attempt to address one before the
286 beginning of an array, as that's not portable.
288 * term.c (max_frame_lines): Remove; unused.
289 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
291 (encode_terminal_code, calculate_costs): Check for size
292 calculation overflow.
293 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
294 table lengths and related sizes. Don't update size until alloc
295 done. Redo calculations to avoid overflow.
296 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
298 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
299 subtracting pointers.
300 (gobble_line): Check for overflow more carefully. Don't update size
303 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
304 Don't update size until alloc done.
305 Redo size calculations to avoid overflow.
306 Check for size calculation overflow.
307 (main) [DEBUG]: Fix typo in invoking tparam1.
309 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
310 Use ptrdiff_t, not int, for sizes.
311 (store_mode_line_noprop_char): Don't update size until alloc done.
313 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
314 Use ptrdiff_t, not int, for sizes.
315 (Finternal_make_lisp_face, cache_face):
316 Check for size calculation overflow.
317 (cache_face): Treat size calculation overflows as if they were
318 memory exhaustion (the usual treatment), rather than aborting.
320 * xfns.c (x_encode_text, x_set_name_internal)
321 (Fx_change_window_property): Use ptrdiff_t, not int, to count
322 sizes, since they can exceed INT_MAX in size. Check for size
323 calculation overflow.
325 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
326 (xg_select): Check for size calculation overflow.
327 Don't update size until alloc done.
329 * xrdb.c (get_environ_db): Don't assume path length fits in int,
330 as sprintf is limited to int lengths.
332 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
333 (X_LONG_MIN): New macros.
334 Use them to make the following changes clearer.
335 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
336 This change doesn't affect the value now, but it may help remind
337 future maintainers not to raise the value too much later.
338 (SELECTION_QUANTUM): Remove, replacing with ...
339 (selection_quantum): ... new function, which avoids overflow.
341 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
342 assumption that selection length fits in 'int'.
343 (x_reply_selection_request, x_handle_selection_request)
344 (x_get_window_property, receive_incremental_selection)
345 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
346 (lisp_data_to_selection_data, clean_local_selection_data):
347 Use ptrdiff_t, not int, to record length of selection.
348 (x_reply_selection_request, x_get_window_property)
349 (receive_incremental_selection, x_property_data_to_lisp):
350 Redo calculations to avoid overflow.
351 (x_reply_selection_request): When sending hint, ceiling it at
352 X_LONG_MAX rather than relying on wraparound overflow to send
354 (x_get_window_property, receive_incremental_selection)
355 (lisp_data_to_selection_data, x_property_data_to_lisp):
356 Check for size-calculation overflow.
357 (x_get_window_property, receive_incremental_selection)
358 (lisp_data_to_selection_data, Fx_register_dnd_atom):
359 Don't store size until memory allocation succeeds.
360 (x_get_window_property): Plug memory leak on memory exhaustion.
361 Don't double-block input; malloc is safe here. Don't assume 2**34
362 - 4 fits in unsigned long. Add an xassert to check
363 XGetWindowProperty overflow. Be more careful about overflow
364 calculations, and distinguish size from memory overflow better.
365 (receive_incremental_selection): When tracing, don't assume
366 unsigned int is less than INT_MAX.
367 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
368 harmful) conversions of unsigned short to int.
369 (lisp_data_to_selection_data): Don't assume that integers
370 in the range -65535 through -1 fit in an X unsigned short.
371 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
372 result parameters unless successful. Rely on cons_to_unsigned
373 to report problems with elements; the old code wasn't right anyway.
374 (x_check_property_data): Check for int overflow; we cannot use
375 a wider type due to X limits.
376 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
378 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
380 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
381 (x_term_init): Check for size calculation overflow.
382 (x_color_cells): Don't store size until memory allocation succeeds.
383 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
384 Don't assume alloca size is less than MAX_ALLOCA.
385 (x_term_init): Don't assume length fits in int (sprintf is limited
388 Use ptrdiff_t for composition IDs.
389 * character.c (lisp_string_width):
390 * composite.c (composition_table_size, n_compositions)
391 (get_composition_id, composition_gstring_from_id):
392 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
393 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
394 * window.c (Frecenter):
395 Use ptrdiff_t, not int, for composition IDs.
396 * composite.c (get_composition_id): Check for integer overflow.
397 * composite.h: Adjust prototypes to match the above changes.
399 Use ptrdiff_t for hash table indexes.
400 * category.c (hash_get_category_set):
401 * ccl.c (ccl_driver):
402 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
403 * coding.c (coding_system_charset_list, detect_coding_system):
404 * coding.h (struct coding_system.id):
405 * composite.c (get_composition_id, gstring_lookup_cache):
406 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
407 * image.c (xpm_get_color_table_h):
408 * lisp.h (hash_lookup, hash_put):
409 * minibuf.c (Ftest_completion):
410 Use ptrdiff_t for hash table indexes, not int (which is too
411 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
412 32-bit --with-wide-int hosts).
414 * charset.c (Fdefine_charset_internal): Check for integer overflow.
415 Add a FIXME comment about memory leaks.
416 (syms_of_charset): Don't assume xmalloc returns.
418 Don't assume that stated character widths fit in int.
419 * character.c (Fchar_width, c_string_width, lisp_string_width):
420 * character.h (CHAR_WIDTH):
421 * indent.c (MULTIBYTE_BYTES_WIDTH):
422 Use sanitize_char_width to avoid undefined and/or bad behavior
423 with outlandish widths.
424 * character.h (sanitize_tab_width): Renamed from sanitize_width,
425 now that we have two such functions. All uses changed.
426 (sanitize_char_width): New inline function.
428 Don't assume that tab-width fits in int.
429 * character.h (sanitize_width): New inline function.
430 (SANE_TAB_WIDTH): New macro.
431 (ASCII_CHAR_WIDTH): Use it.
432 * indent.c (sane_tab_width): Remove. All uses replaced by
433 SANE_TAB_WIDTH (current_buffer).
434 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
436 * fileio.c: Integer overflow issues with file modes.
437 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
439 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
440 Remove unreachable code.
441 (read_hex, load_charset_map_from_file): Check for integer overflow.
443 * xterm.c: don't go over XClientMessageEvent limit
444 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
445 (x_send_scroll_bar_event): Likewise. Check that the size does not
446 exceed limits imposed by XClientMessageEvent, as well as the usual
447 ptrdiff_t and size_t limits.
449 * keyboard.c: Overflow, signedness and related fixes.
450 (make_lispy_movement): Use same integer type in forward decl
451 that is used in the definition.
452 (read_key_sequence, keyremap_step):
453 Change bufsize argument back to int, undoing my 2011-03-30 change.
454 We prefer signed types, and int is wide enough here.
455 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
456 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
457 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
458 length, not size_t. Use ptrdiff_t for index, not int.
459 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
460 possibility of integer overflow.
462 Overflow, signedness and related fixes for images.
464 * dispextern.h (struct it.stack[0].u.image.image_id)
465 (struct_it.image_id, struct image.id, struct image_cache.size)
466 (struct image_cache.used, struct image_cache.ref_count):
467 * gtkutil.c (update_frame_tool_bar):
468 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
469 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
470 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
471 * nsmenu.m (update_frame_tool_bar):
472 * xdisp.c (calc_pixel_width_or_height):
473 * xfns.c (image_cache_refcount):
474 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
475 on typical 64-bit hosts.
477 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
478 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
479 Omit unnecessary casts to int.
480 (parse_image_spec): Check that integers fall into 'int' range
481 when the callers expect that.
482 (image_ascent): Redo ascent calculation to avoid int overflow.
483 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
484 (lookup_image): Remove unnecessary tests.
485 (xbm_image_p): Locals are now of int, not EMACS_INT,
486 since parse_image_check makes sure they fit into int.
487 (png_load, gif_load, svg_load_image):
488 Prefer int to unsigned where either will do.
489 (tiff_handler): New function, combining the cores of the
490 old tiff_error_handler and tiff_warning_handler. This
491 function is rewritten to use vsnprintf and thereby avoid
492 stack buffer overflows. It uses only the features of vsnprintf
493 that are common to both POSIX and native Microsoft.
494 (tiff_error_handler, tiff_warning_handler): Use it.
495 (tiff_load, gif_load, imagemagick_load_image):
496 Don't assume :index value fits in 'int'.
497 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
498 (imagemagick_load_image): Check that crop parameters fit into
499 the integer types that MagickCropImage accepts. Don't assume
500 Vimagemagick_render_type has a nonnegative value. Don't assume
501 size_t fits in 'long'.
502 (gs_load): Use printmax_t to print the widest integers possible.
503 Check for integer overflow when computing image height and width.
505 2011-08-26 Eli Zaretskii <eliz@gnu.org>
507 * xdisp.c (redisplay_window): Don't force window start if point
508 will be invisible in the resulting window. (Bug#9324)
510 2011-08-25 Eli Zaretskii <eliz@gnu.org>
512 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
513 the display spec is of the form `(space ...)'.
514 (handle_display_spec): Return the value returned by
515 handle_single_display_spec, not just 1 or zero.
516 (handle_single_display_spec): If the display spec is of the form
517 `(space ...)', and specifies display in the text area, return 2
519 (try_cursor_movement): Check for the need to scroll more
520 accurately, and prefer exact match for point under bidi. Don't
521 advance `row' beyond the last row of the window.
523 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
524 into disp_prop; all users changed.
526 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
527 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
528 for the text covered by the display property.
530 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
532 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
533 Change return value to nil.
534 (Frecord_buffer): Delete unused function.
536 2011-08-24 Eli Zaretskii <eliz@gnu.org>
538 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
539 buffers, return left-to-right.
540 (set_cursor_from_row): Consider candidate row a win if its glyph
541 represents a newline and point is on that newline. Fixes cursor
542 positioning on the newline at EOL of R2L text within L2R
543 paragraph, and vice versa.
544 (try_cursor_movement): Check continued rows, in addition to
545 continuation rows. Fixes unwarranted scroll when point enters a
546 continued line of R2L text within an L2R paragraph, or vice versa.
547 (cursor_row_p): Consider the case of point being equal to
548 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
549 from the end of a short line to the beginning of a continued line
550 of R2L text within L2R paragraph.
551 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
554 * bidi.c (bidi_check_type): Use xassert.
555 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
558 2011-08-23 Eli Zaretskii <eliz@gnu.org>
560 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
563 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
565 * nsfont.m (ns_otf_to_script): Fix typo.
567 2011-08-22 Kenichi Handa <handa@m17n.org>
569 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
570 extra slot even if the purpose is char-code-property-table.
572 2011-08-23 Eli Zaretskii <eliz@gnu.org>
574 * xdisp.c (redisplay_window): When computing centering_position,
575 account for the height of the header line. (Bug#8874)
577 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
578 instead of CHAR_TO_BYTE. Fixes a crash when a completion
579 candidate is selected by the mouse, and that candidate has a
580 composed character under the mouse.
582 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
583 coordinates reported by pos-visible-in-window-p for a composed
584 character in column zero.
586 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
588 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
590 2011-08-22 Eli Zaretskii <eliz@gnu.org>
592 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
593 consider it a hit if to_charpos is anywhere in the range of the
594 composed buffer positions.
596 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
598 * image.c (gif_load): Don't assume that each subimage has the same
599 dimensions as the base image. Handle disposal method that is
600 "undefined" by the gif spec (Bug#9335).
602 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
604 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
605 (Fcondition_case): Document `debug' symbol in error handler.
607 2011-08-19 Eli Zaretskii <eliz@gnu.org>
609 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
610 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
611 from an Org mode buffer to a Speedbar frame.
613 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
614 a composition, take its buffer position from IT->cmp_it.charpos.
615 Fixes cursor positioning at the beginning of a line that begins
616 with a composed character.
618 2011-08-18 Eli Zaretskii <eliz@gnu.org>
620 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
621 character bidirectional type, use STRONG_L instead. Fixes crashes
622 in a buffer produced by `describe-categories'.
624 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
625 members before the level stack, so they would be saved and
626 restored when copying iterator state. Fixes incorrect reordering
627 around TABs covered by display properties.
629 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
631 * process.c (Fnetwork_interface_list): Correctly determine buffer
634 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
636 * eval.c (internal_condition_case, internal_condition_case_1)
637 (internal_condition_case_2, internal_condition_case_n):
638 Remove unnecessary aborts (Bug#9081).
640 2011-08-17 Eli Zaretskii <eliz@gnu.org>
642 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
643 has no `load' handler, try opening the file locally. (Bug#9311)
645 2011-08-16 Ken Brown <kbrown@cornell.edu>
647 * gmalloc.c: Expand comment.
649 2011-08-16 Eli Zaretskii <eliz@gnu.org>
651 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
652 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
654 2011-08-16 Ken Brown <kbrown@cornell.edu>
656 Fix memory allocation problems in Cygwin build (Bug#9273).
658 * unexcw.c ( __malloc_initialized): Declare external variable.
659 (fixup_executable): Force the dumped emacs to reinitialize malloc.
661 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
663 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
665 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
667 [CYGWIN] (special_realloc): New function.
668 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
669 requests to realloc storage in the static heap.
671 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
673 * bidi.c (bidi_initialize): Remove unused local.
675 2011-08-15 Eli Zaretskii <eliz@gnu.org>
677 * biditype.h: File removed.
679 * bidimirror.h: File removed.
681 * deps.mk (bidi.o): Remove biditype.h and
684 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
687 * dispextern.h: Fix a typo in the comment to bidi_type_t.
689 * chartab.c: Improve commentary for the uniprop_table API.
691 * bidi.c (bidi_paragraph_init): Support zero value of
692 bidi_ignore_explicit_marks_for_paragraph_level.
693 (bidi_initialize): Use uniprop_table instead of including
694 biditype.h and bidimirror.h.
696 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
697 coordinates of the iterator when restoring from ppos_it.
700 2011-08-14 Kenichi Handa <handa@m17n.org>
702 * process.c (create_process): Call setup_process_coding_systems
703 after the pid of the process is set to -1 (Bug#8162).
705 2011-08-14 Eli Zaretskii <eliz@gnu.org>
707 * xdisp.c (move_it_in_display_line_to): Don't invoke
708 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
709 ppos_it. Fixes vertical cursor motion when line beginning is
710 covered by an image. (Bug#9296)
712 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
714 * nsterm.h (ns_run_ascript): Declare.
715 (NSAPP_DATA2_RUNASSCRIPT): Define.
717 * nsfns.m (as_script, as_result, as_status): New static variables.
718 (ns_run_ascript): New function.
719 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
720 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
721 the event loop. Get status from as_status (Bug#7276).
723 * nsterm.m (sendEvent): If event is NSApplicationDefined and
724 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
725 the event loop (Bug#7276).
727 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
729 * gnutls.c (QCgnutls_bootprop_priority)
730 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
731 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
732 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
733 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
734 (QCgnutls_bootprop_verify_hostname_error)
735 (QCgnutls_bootprop_callbacks_verify): Rename from
736 Qgnutls_bootprop_..., all uses changed.
738 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
741 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
743 * xfaces.c (Qframe_set_background_mode): Now static.
744 * dispextern.h (Qframe_set_background_mode): Remove decl.
746 * process.c (Fnetwork_interface_info): Declare local only if needed.
748 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
750 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
751 (Fnetwork_interface_list): Allocate in increments of bytes instead
752 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
753 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
755 (struct ifflag_def): notrailers is smart on OSX.
756 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
757 Get hardware address with getifaddrs if available.
759 2011-08-12 Eli Zaretskii <eliz@gnu.org>
761 * xdisp.c (iterate_out_of_display_property): xassert that
762 IT->position is set to within IT->object's boundaries. Break from
763 the loop as soon as EOB is reached; avoids infloops in redisplay
764 when IT->position is set up wrongly due to some bug.
765 Set IT->current to match the bidi iterator unconditionally.
766 (push_display_prop): Allow GET_FROM_STRING as IT->method on
767 entry. Force push_it to save on the stack the current
768 buffer/string position, to be restored by pop_it. Fix flags in
769 the iterator structure wrt the object coming from a display
770 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
771 properties. (Bug#9284)
773 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
775 * fontset.c (fontset_get_font_group): Add proper type checks.
778 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
780 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
781 and LC_VERSION_MIN_MACOSX.
782 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
783 (dump_it) [LC_FUNCTION_STARTS]: Use it.
785 2011-08-08 Eli Zaretskii <eliz@gnu.org>
787 * xdisp.c (forward_to_next_line_start): Allow to use the
788 no-display-properties-and-no-overlays under bidi display.
789 Set disp_pos in the bidi iterator to avoid searches for display
790 properties and overlays.
792 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
794 * editfns.c (Fset_time_zone_rule): Document relationship with the
797 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
798 the font entity extracted from the cache (Bug#8109).
800 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
802 * composite.c (autocmp_chars): Don't reset point. That is done by
803 restore_point_unwind (Bug#5984).
805 2011-08-07 Juri Linkov <juri@jurta.org>
807 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
808 to show the arg `TIME' instead of `TIMEVAL'.
810 2011-08-06 Eli Zaretskii <eliz@gnu.org>
812 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
813 display property strides EOL and includes a newline, as in
814 longlines-mode. (Bug#9254)
815 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
816 word-wrap under bidirectional display. (Bug#9224)
818 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
819 is non-zero, even if the data buffer is NULL. Fixes a crash in
820 vertical-motion with longlines-mode. (Bug#9254)
822 2011-08-05 Eli Zaretskii <eliz@gnu.org>
824 * bidi.c <bidi_cache_total_alloc>: Now static.
825 (bidi_initialize): Initialize bidi_cache_total_alloc.
827 * xdisp.c (display_line): Release buffer allocated for shelved bidi
830 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
831 amount allocated this far in `bidi_cache_total_alloc'.
832 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
833 non-zero, only free the data buffer without restoring the cache
834 contents. All callers changed.
836 * dispextern.h (bidi_unshelve_cache): Update prototype.
838 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
839 (move_it_in_display_line, move_it_to)
840 (move_it_vertically_backward, move_it_by_lines): Replace the call
841 to xfree to an equivalent call to bidi_unshelve_cache.
842 (move_it_in_display_line_to): Fix logic of returning
843 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
845 2011-08-05 Eli Zaretskii <eliz@gnu.org>
847 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
848 came from a string character with a `cursor' property. (Bug#9229)
850 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
852 * Makefile.in (LIB_PTHREAD): New variable.
853 (LIBES): Add LIB_PTHREAD (Bug#9216).
855 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
856 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
858 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
860 * regex.c (re_iswctype): Remove some redundant boolean
863 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
865 * xterm.c (x_find_topmost_parent): New function.
866 (x_set_frame_alpha): Find topmost parent window with
867 x_find_topmost_parent and set the property there also (bug#9181).
868 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
870 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
872 * callproc.c (Fcall_process): Avoid vfork clobbering
873 the local vars buffer, coding_systems, current_dir.
875 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
877 * keymap.c (Fmake_composed_keymap): Move to subr.el.
879 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
881 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
882 so that it is not optimized away.
884 * xdisp.c (compute_display_string_pos): Remove unused local.
886 2011-08-02 Eli Zaretskii <eliz@gnu.org>
888 Fix slow cursor motion and scrolling in large buffers with
889 selective display, like Org Mode buffers. (Bug#9218)
891 * dispextern.h (struct bidi_it): New member disp_prop_p.
893 * xdisp.c: Remove one-slot cache of display string positions.
894 (compute_display_string_pos): Accept an additional argument
895 DISP_PROP_P; callers changed. Scan at most 5K characters forward
896 for a display string or property. If found, set DISP_PROP_P
899 * bidi.c (bidi_fetch_char): Accept an additional argument
900 DISP_PROP_P, and pass it to compute_display_string_pos.
901 Only handle text covered by a display string if DISP_PROP_P is returned
902 non-zero. All callers of bidi_fetch_char changed.
904 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
906 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
908 2010-12-03 Don March <don@ohspite.net>
910 * keymap.c (Fdefine_key): Fix non-prefix key error message when
911 last character M-[char] is translated to ESC [char] (bug#7541).
913 2011-08-02 Kenichi Handa <handa@m17n.org>
915 * lisp.h (uniprop_table): Extern it.
917 * chartab.c (uniprop_table): Make it non-static.
919 2011-08-01 Eli Zaretskii <eliz@gnu.org>
921 * xdisp.c (forward_to_next_line_start): Accept additional argument
922 BIDI_IT_PREV, and store into it the state of the bidi iterator had
924 (reseat_at_next_visible_line_start): Use the bidi iterator state
925 returned by forward_to_next_line_start to restore the state of
926 it->bidi_it after backing up to previous newline. (Bug#9212)
928 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
930 * regex.c (re_comp): Protoize.
931 (re_exec): Fix return type.
932 (regexec): Fix type of `ret'. (Bug#9203)
934 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
936 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
937 This is needed if max-image-size is a floating-point number.
939 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
941 * print.c (print_object): Print empty symbol as ##.
943 * lread.c (read1): Read ## as empty symbol.
945 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
947 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
948 setting frame foreground color (Bug#9175).
949 (x_set_background_color): Likewise.
951 * nsmenu.m (-setText): Size tooltip dimensions precisely to
953 (EmacsTooltip -init): Remove bezels and add shadows to
956 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
957 or scroll bar (Bug#8470).
959 * nsfont.m (nsfont_open): Remove assignment to voffset and
960 unnecessary vars hshink, expand, hd, full_height, min_height.
961 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
963 * nsterm.h (nsfont_info): Remove voffset field.
965 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
967 Implement strike-through and overline on NextStep (Bug#8863).
969 * nsfont.m (nsfont_open): Use underline position provided by font,
970 instead of hard-coded value of 2.
971 (nsfont_draw): Call ns_draw_text_decoration instead.
973 * nsterm.h: Add declaration for ns_draw_text_decoration.
975 * nsterm.m (ns_draw_text_decoration): New function for drawing
976 underline, overline, and strike-through.
977 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
978 ns_draw_text_decoration. Change treatment of cursor drawing to
979 accomodate underlining, etc.
981 2011-07-28 Eli Zaretskii <eliz@gnu.org>
983 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
986 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
988 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
989 Without this fix, if a signal arrives just after memory fills up,
990 'malloc' might be invoked reentrantly.
992 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
993 In other words, assume that every image size is allowed, on non-X
994 hosts. This assumption is probably wrong, but it lets Emacs compile.
996 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
998 * regex.c (re_iswctype): Convert return values to boolean.
1000 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1002 * xdisp.c (compute_display_string_pos): Don't use cached display
1003 string position if the buffer had its restriction changed.
1006 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1008 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1010 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1012 Integer signedness and overflow and related fixes. (Bug#9079)
1014 * bidi.c: Integer size and overflow fixes.
1015 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1016 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1017 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1018 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1019 (bidi_find_other_level_edge):
1020 Use ptrdiff_t instead of EMACS_INT where either will do.
1021 This works better on 32-bit hosts configured --with-wide-int.
1022 (bidi_cache_ensure_space): Check for size-calculation overflow.
1023 Use % rather than repeated addition, for better worst-case speed.
1024 Don't set bidi_cache_size until after xrealloc returns, because it
1026 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1027 (bidi_cache_ensure_space): Also check that the bidi cache size
1028 does not exceed that of the largest Lisp string or buffer. See Eli
1029 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1031 * alloc.c (__malloc_size_t): Remove.
1032 All uses replaced by size_t. See Andreas Schwab's note
1033 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1035 * image.c: Improve checking for integer overflow.
1036 (check_image_size): Assume that f is nonnull, since
1037 it is always nonnull in practice. This is one less thing to
1038 worry about when checking for integer overflow later.
1039 (x_check_image_size): New function, which checks for integer
1040 overflow issues inside X.
1041 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1042 This removes the need for a memory_full check.
1043 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1044 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1045 (xbm_read_bitmap_data): Change locals back to 'int', since
1046 their values must fit in 'int'.
1047 (xpm_load_image, png_load, tiff_load):
1048 Invoke x_create_x_image_and_pixmap earlier,
1049 to avoid much needless work if the image is too large.
1050 (tiff_load): Treat overly large images as if
1051 x_create_x_image_and_pixmap failed, not as malloc failures.
1052 (gs_load): Use x_check_image_size.
1054 * gtkutil.c: Omit integer casts.
1055 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1056 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1058 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1060 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1061 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1062 would wrongly return t on a 64-bit host.
1064 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1065 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1066 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1067 and therefore cause GCC to emit a bogus diagnostic in some cases.
1069 * image.c: Integer signedness and overflow and related fixes.
1070 This is not an exhaustive set of fixes, but it's time to
1071 record what I've got.
1072 (lookup_pixel_color, check_image_size): Remove redundant decls.
1073 (check_image_size): Don't assume that arbitrary EMACS_INT values
1074 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1075 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1076 (tiff_load, imagemagick_load_image):
1077 Check for overflow in size calculations.
1078 (x_create_x_image_and_pixmap): Remove unnecessary test for
1079 xmalloc returning NULL; that can't happen.
1080 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1081 (xpm_color_bucket): Use better integer hashing function.
1082 (xpm_cache_color): Don't possibly over-allocate memory.
1083 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1084 (gif_memory_source):
1085 Use ptrdiff_t, not int or size_t, to record sizes.
1086 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1087 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1088 either works, as we prefer signed integers.
1089 (tiff_read_from_memory, tiff_write_from_memory):
1090 Return tsize_t, not size_t, since that's what the TIFF API wants.
1091 (tiff_read_from_memory): Don't fail simply because the read would
1092 go past EOF; instead, return a short read.
1093 (tiff_load): Omit no-longer-needed casts.
1094 (Fimagemagick_types): Don't assume size fits into 'int'.
1096 Improve hashing quality when configured --with-wide-int.
1097 * fns.c (hash_string): New function, taken from sxhash_string.
1098 Do not discard information about ASCII character case; this
1099 discarding is no longer needed.
1100 (sxhash-string): Use it. Change sig to match it. Caller changed.
1101 * lisp.h: Declare it.
1102 * lread.c (hash_string): Remove, since we now use fns.c's version.
1103 The fns.c version returns a wider integer if --with-wide-int is
1104 specified, so this should help the quality of the hashing a bit.
1106 * emacs.c: Integer overflow minor fix.
1107 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1108 Define only if GNU_LINUX.
1109 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1111 * dispnew.c: Integer signedness and overflow fixes.
1112 Remove unnecessary forward decls, that were a maintenance hassle.
1113 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1115 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1116 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1117 (prepare_desired_row, line_draw_cost):
1118 Use int, not unsigned, where either works.
1119 (save_current_matrix, restore_current_matrix):
1120 Use ptrdiff_t, not size_t, where either works.
1121 (init_display): Check for overflow more accurately, and without
1122 relying on undefined behavior.
1124 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1125 Remove, replacing with the new symbols in lisp.h. All uses changed.
1126 * fileio.c (make_temp_name):
1127 * filelock.c (lock_file_1, lock_file):
1128 * xdisp.c (message_dolog):
1129 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1130 Use pMd etc. instead.
1131 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1132 replacing the pWIDE etc. symbols removed from editfns.c.
1134 * keyboard.h (num_input_events): Now uintmax_t.
1135 This is (very slightly) less likely to mess up due to wraparound.
1138 * buffer.c: Integer signedness fixes.
1139 (alloc_buffer_text, enlarge_buffer_text):
1140 Use ptrdiff_t rather than size_t when either will do, as we prefer
1143 * alloc.c: Integer signedness and overflow fixes.
1144 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1145 (__malloc_size_t): Default to size_t, not to int.
1146 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1147 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1148 Prefer ptrdiff_t to size_t when either would do, as we prefer
1150 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1151 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1152 Now const. Initialize with values that are in range even if char
1154 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1155 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1156 These functions do the right thing with sizes > 2**32.
1157 (check_depth): Now ptrdiff_t, not int.
1158 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1159 Adjust to new way of storing sizes. Check for size overflow bugs
1161 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1162 slightly wrong anyway, as it missed one instance of
1163 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1164 (refill_memory_reserve): Omit needless cast to size_t.
1165 (mark_object_loop_halt): Mark as externally visible.
1167 * xselect.c: Integer signedness and overflow fixes.
1168 (Fx_register_dnd_atom, x_handle_dnd_message):
1169 Use ptrdiff_t, not size_t, since we prefer signed.
1170 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1171 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1172 x_dnd_atoms_size and x_dnd_atoms_length.
1174 * doprnt.c: Prefer signed to unsigned when either works.
1176 * doprnt.c (doprnt):
1178 * xdisp.c (vmessage):
1179 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1180 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1181 prefer signed arithmetic to avoid comparison confusion.
1182 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1183 but is a bit tricky.
1185 Assume freestanding C89 headers, string.h, stdlib.h.
1186 * data.c, doprnt.c, floatfns.c, print.c:
1187 Include float.h unconditionally.
1188 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1189 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1190 * regex.c: Likewise for stddef.h, string.h.
1191 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1192 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1193 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1194 (STDC_HEADERS): Remove obsolete defines.
1195 * sysdep.c: Include limits.h unconditionally.
1197 Assume support for memcmp, memcpy, memmove, memset.
1198 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1199 * regex.c (memcmp, memcpy):
1200 Remove; we assume C89 now.
1202 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1203 (__malloc_safe_bcopy): Remove; no longer needed.
1205 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1206 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1207 well either way, and we prefer signed to unsigned.
1209 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1211 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1212 closes the connection while we're reading (bug#9182).
1214 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1216 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1217 are specified (Bug#9168).
1219 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1221 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1222 Found by GCC static checking and --with-wide-int on a 32-bit host.
1224 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1226 * xdisp.c (compute_display_string_pos): Fix logic of caching
1227 previous display string position. Initialize cached_prev_pos to
1228 -1. Fixes slow-down at the beginning of a buffer.
1230 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1232 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1233 for attrs[LFACE_FONTSET_INDEX].
1235 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1237 * xml.c (parse_region): Remove unused local
1238 that was recently introduced.
1240 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1242 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1243 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1245 * xdisp.c (move_it_in_display_line_to): Record the best matching
1246 position for TO_CHARPOS while scanning the line, and restore it on
1247 exit if none of the characters scanned was an exact match.
1248 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1249 when exact match is impossible due to invisible text, and the
1250 lines are truncated.
1252 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1254 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1257 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1259 Fix a significant slow-down of cursor motion with C-n, C-p,
1260 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1261 auto-repeat under bidi redisplay in fontified buffers.
1262 * xdisp.c (compute_stop_pos_backwards): New function.
1263 (next_element_from_buffer): Call compute_stop_pos_backwards to
1264 find a suitable prev_stop when we find ourselves before
1266 (reseat): Don't look for prev_stop, as that could mean a very long
1268 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1269 <cached_disp_overlay_modiff>: Cache for last found display string
1271 (compute_display_string_pos): Return the cached position if asked
1272 about the same buffer in the same area of character positions, and
1273 the buffer wasn't changed since the time the display string
1274 position was cached.
1276 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1278 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1279 is an integer, which is important for empty lines. (Bug#9149)
1281 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1283 * frame.c (Fmodify_frame_parameters): In tty case, update the
1284 default face if necessary (Bug#4238).
1286 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1288 * editfns.c (Fstring_to_char): No need to explain what a character
1289 is in the docstring (Bug#6576).
1291 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1293 * xml.c (parse_region): Make sure we always return a tree.
1295 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1297 * xml.c (parse_region): If a document contains only comments,
1300 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1302 * xml.c (make_dom): Return comments, too.
1304 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1307 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1308 and the surrounding thread.
1309 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1310 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1311 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1313 * s/openbsd.h (BROKEN_SIGIO): Define.
1314 * unexelf.c (unexec) [__OpenBSD__]:
1315 Don't update the .mdebug section of the Alpha COFF symbol table.
1317 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1319 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1322 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1324 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1325 This fixes some race conditions on the permissions of any newly
1328 * alloc.c (valid_pointer_p): Use pipe, not open.
1329 This fixes some permissions issues when debugging.
1331 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1332 If fchown fails to set both uid and gid, try to set just gid,
1333 as that is sometimes allowed. Adjust the file's mode to eliminate
1334 setuid or setgid bits that are inappropriate if fchown fails.
1336 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1338 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1339 to compare Lisp_Objects.
1340 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1341 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1342 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1344 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1346 * lread.c (read_integer): Unread even EOF character.
1347 (read1): Likewise. Properly record start position of symbol.
1349 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1350 symbol character follows.
1352 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1354 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1355 This works around a problem with the previous change to Fcopy_file.
1356 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1357 and without this change, GCC might complain about discarding
1358 fchown's return value.
1360 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1362 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1364 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1366 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1368 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1370 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1371 it's used from the C level.
1373 * process.c: Use the same condition for POLL_FOR_INPUT in both
1374 keyboard.c and process.c (bug#1858).
1376 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1378 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1379 (Fgnutls_boot): Use it.
1381 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1383 * doc.c (Fsubstitute_command_keys): Revert last change.
1385 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1387 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1388 quotes the next character, and doesn't affect other longer
1389 sequences (bug#8935).
1391 * lread.c (syms_of_lread): Clarify that is isn't only
1392 `eval-buffer' and `eval-defun' that's affected by
1393 `lexical-binding' (bug#8460).
1395 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1397 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1398 bidi redisplay when a line includes both an image and is
1401 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1403 Fix minor problems found by static checking.
1404 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1405 (elsz): Now a signed constant, not a size_t var. We prefer signed
1406 types to unsigned, to avoid integer comparison confusion. Without
1407 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1408 "cannot optimize loop, the loop counter may overflow", a symptom
1410 * indent.c (Fvertical_motion): Mark locals as initialized.
1411 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1413 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1415 * search.c (Fre_search_backward): Mention `case-fold-search' in
1416 all the re_search_* functions (bug#8138).
1418 * keyboard.c (Fopen_dribble_file): Document when the file is
1421 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1423 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1426 Support bidi reordering of display and overlay strings.
1427 * xdisp.c (compute_display_string_pos)
1428 (compute_display_string_end): Accept additional argument STRING.
1429 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1430 (reseat_to_string): Initialize bidi_it->string.s and
1431 bidi_it->string.schars.
1432 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1433 NULL (avoids a crash in bidi_paragraph_init).
1434 Initialize itb.string.lstring.
1435 (init_iterator): Call bidi_init_it only of a valid
1436 buffer position was specified. Initialize paragraph_embedding to
1438 (reseat_to_string): Initialize the bidi iterator.
1439 (display_string): If we need to ignore text properties of
1440 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1441 original value of -1 will not work with bidi.)
1442 (compute_display_string_pos): First arg is now struct
1443 `text_pos *'; all callers changed. Support display properties on
1445 (compute_display_string_end): Support display properties on Lisp
1447 (init_iterator, reseat_1, reseat_to_string): Initialize the
1448 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1449 when iterating on a string not from display properties).
1450 (compute_display_string_pos, compute_display_string_end):
1451 Fix calculation of the object to scan. Fixes an error when using
1453 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1454 base_level_stop; instead, set base_level_stop to BEGV.
1455 Fixes crashes in vertical-motion.
1456 (next_element_from_buffer): Improve commentary for when
1457 the iterator is before prev_stop.
1458 (init_iterator): Initialize bidi_p from the default value of
1459 bidi-display-reordering, not from buffer-local value. Use the
1460 buffer-local value only if initializing for buffer iteration.
1461 (handle_invisible_prop): Support invisible properties on strings
1462 that are being bidi-reordered.
1463 (set_iterator_to_next): Support bidi reordering of C strings and
1465 (next_element_from_string): Support bidi reordering of Lisp
1467 (handle_stop_backwards): Support Lisp strings as well.
1468 (display_string): Support display of R2L glyph rows.
1469 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1470 (init_iterator): Don't initialize it->bidi_p for strings
1472 (reseat_to_string): Initialize it->bidi_p for strings here.
1473 (next_element_from_string, next_element_from_c_string)
1474 (next_element_from_buffer): Add xassert's for correspondence
1475 between IT's object being iterated and it->bidi_it.string
1477 (face_before_or_after_it_pos): Support bidi iteration.
1478 (next_element_from_c_string): Handle the case of the first string
1479 character that is not the first one in the visual order.
1480 (get_visually_first_element): New function, refactored from common
1481 parts of next_element_from_buffer, next_element_from_string, and
1482 next_element_from_c_string.
1483 (tool_bar_lines_needed, redisplay_tool_bar)
1484 (display_menu_bar): Force left-to-right direction. Add a FIXME
1485 comment for making that be controlled by a user option.
1486 (push_it, pop_it): Save and restore the state of the
1487 bidi iterator. Save and restore the bidi_p flag.
1488 (pop_it): Iterate out of display property for string iteration as
1490 (iterate_out_of_display_property): Support iteration over strings.
1491 (handle_single_display_spec): Set up it->bidi_it for iteration
1492 over a display string, and call bidi_init_it.
1493 (handle_single_display_spec, next_overlay_string)
1494 (get_overlay_strings_1, push_display_prop): Set up the bidi
1495 iterator for displaying display or overlay strings.
1496 (forward_to_next_line_start): Don't use the shortcut if
1498 (back_to_previous_visible_line_start): If handle_display_prop
1499 pushed the iterator stack, restore the internal state of the bidi
1500 iterator by calling bidi_pop_it same number of times.
1501 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1502 and we are bidi-iterating, don't decrement the iterator position;
1503 instead, set the first_elt flag in the bidi iterator, to produce
1505 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1506 (push_display_prop): xassert that we are iterating a buffer.
1507 (push_it, pop_it): Save and restore paragraph_embedding member.
1508 (handle_single_display_spec, next_overlay_string)
1509 (get_overlay_strings_1, reseat_1, reseat_to_string)
1510 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1511 correctly. Don't assume unibyte strings are not bidi-reordered.
1512 (compute_display_string_pos)
1513 (compute_display_string_end): Fix handling the case of C string.
1514 (push_it, pop_it): Save and restore from_disp_prop_p.
1515 (handle_single_display_spec, push_display_prop): Set the
1516 from_disp_prop_p flag.
1517 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1518 (pop_it): Call iterate_out_of_display_property only if we are
1519 popping after iteration over a string that came from a display
1520 property. Fix a typo in popping stretch info. Add an assertion
1521 for verifying that the iterator position is in sync with the bidi
1523 (handle_single_display_spec, get_overlay_strings_1)
1524 (push_display_prop): Fix initialization of paragraph direction for
1525 string when that of the parent object is not yet determined.
1526 (reseat_1): Call bidi_init_it to resync the bidi
1527 iterator with IT's position. (Bug#7616)
1528 (find_row_edges): If ROW->start.pos gives position
1529 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1530 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1531 Reset the from_disp_prop_p flag.
1532 (SAVE_IT, RESTORE_IT): New macros.
1533 (pos_visible_p, face_before_or_after_it_pos)
1534 (back_to_previous_visible_line_start)
1535 (move_it_in_display_line_to, move_it_in_display_line)
1536 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1537 (try_scrolling, redisplay_window, display_line): Use them when
1538 saving a temporary copy of the iterator and restoring it back.
1539 (back_to_previous_visible_line_start, reseat_1)
1540 (init_iterator): Empty the bidi cache "stack".
1541 (move_it_in_display_line_to): If iterator ended up at
1542 EOL, but we never saw any buffer positions smaller than
1543 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1544 motion in bidi-reordered lines.
1545 (move_it_in_display_line_to): Record prev_method and prev_pos
1546 immediately before the call to set_iterator_to_next. Fixes cursor
1547 motion in bidi-reordered lines with stretch glyphs and strings
1548 displayed in margins. (Bug#8133) (Bug#8867)
1549 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1551 (pos_visible_p): Support positions in bidi-reordered lines.
1552 Save and restore bidi cache.
1554 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1555 (bidi_paragraph_info): Delete unused struct.
1556 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1557 (bidi_cache_start): New variable.
1558 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1560 (bidi_cache_fetch_state, bidi_cache_search)
1561 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1562 (bidi_cache_find, bidi_peek_at_next_level)
1563 (bidi_level_of_next_char, bidi_find_other_level_edge)
1564 (bidi_move_to_visually_next): Compare cache index with
1565 bidi_cache_start rather than with zero.
1566 (bidi_fetch_char): Accept new argument STRING; all callers
1567 changed. Support iteration over a string. Support strings with
1568 display properties. Support unibyte strings. Fix the type of
1569 `len' according to what STRING_CHAR_AND_LENGTH expects.
1570 (bidi_paragraph_init, bidi_resolve_explicit_1)
1571 (bidi_resolve_explicit, bidi_resolve_weak)
1572 (bidi_level_of_next_char, bidi_move_to_visually_next):
1573 Support iteration over a string.
1574 (bidi_set_sor_type, bidi_resolve_explicit_1)
1575 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1576 can now be zero (for strings); special values 0 and -1 were
1577 changed to -1 and -2, respectively.
1578 (bidi_char_at_pos): New function.
1579 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1580 Call it instead of FETCH_MULTIBYTE_CHAR.
1581 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1582 initialized to valid values.
1583 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1585 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1586 the test for valid cached positions. Fix the logic for looking up
1587 the sentinel state in the cache. GCPRO the Lisp string we are
1589 (bidi_push_it, bidi_pop_it): New functions.
1590 (bidi_initialize): Initialize the bidi cache start stack pointer.
1591 (bidi_cache_ensure_space): New function, refactored from part of
1592 bidi_cache_iterator_state. Don't assume the required size is just
1593 one BIDI_CACHE_CHUNK away.
1594 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1595 (bidi_count_bytes, bidi_char_at_pos): New functions.
1596 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1597 always valid if bidi_cache_idx is valid.
1598 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1599 is valid if it's going to be used.
1600 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1601 (bidi_cache_fetch_state, bidi_cache_search)
1602 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1603 (bidi_cache_iterator_state, bidi_cache_find)
1604 (bidi_find_other_level_edge, bidi_cache_start_stack):
1605 All variables related to cache indices are now EMACS_INT.
1607 * dispextern.h (struct bidi_string_data): New structure.
1608 (struct bidi_it): New member `string'. Make flag members be 1-bit
1609 fields, and put them last in the struct.
1610 (compute_display_string_pos, compute_display_string_end):
1612 (bidi_push_it, bidi_pop_it): Add prototypes.
1613 (struct iterator_stack_entry): New members bidi_p,
1614 paragraph_embedding, and from_disp_prop_p.
1615 (struct it): Member bidi_p is now a bit field 1 bit wide.
1616 (bidi_shelve_cache, bidi_unshelve_cache):
1619 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1620 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1621 and vector-like objects.
1623 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1624 cache around display iteration.
1626 * window.c (Fwindow_end, window_scroll_pixel_based)
1627 (displayed_window_lines, Frecenter): Save and restore the bidi
1628 cache around display iteration.
1630 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1632 * editfns.c (Fdelete_region): Clarify the use of the named
1633 parameters (bug#6788).
1635 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1637 * indent.c (Fvertical_motion): Set and restore w->pointm when
1638 saving and restoring the window's buffer (Bug#9006).
1640 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1642 * editfns.c (Fstring_to_char): Clarify just what is returned
1643 (bug#6576). Text by Eli Zaretskii.
1645 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1647 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1649 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1651 * buffer.c (mmap_find): Fix a typo.
1653 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1655 Fix execution of x selection hooks.
1656 * xselect.c (Qx_lost_selection_functions)
1657 (Qx_sent_selection_functions): New vars.
1658 (syms_of_xselect): DEFSYM them.
1659 (x_handle_selection_request): Pass Qx_sent_selection_functions
1660 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1661 (x_handle_selection_clear,x_clear_frame_selections):
1662 Pass Qx_lost_selection_functions rather than
1663 Vx_lost_selection_functions to Frun_hook_with_args.
1665 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1667 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1668 The old code sometimes used this field without initializing it.
1670 * alloc.c (gc_sweep): Don't read past end of array.
1671 In theory, the old code could also have corrupted Emacs internals,
1672 though it'd be very unlikely.
1674 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1676 * character.c (Fcharacterp): Don't advertise optional ignored
1677 argument. (Bug#4026)
1679 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1681 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1684 * window.c (Fset_window_start): Doc fix (bug#4199).
1685 (Fset_window_hscroll): Ditto.
1687 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1689 Fix minor new problems caught by GCC 4.6.1.
1690 * term.c (init_tty): Remove unused local.
1691 * xsettings.c (store_monospaced_changed): Define this function only
1692 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1695 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1697 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1699 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1701 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1702 are the mini-buffer and the echo area (bug#3320).
1704 * term.c (init_tty): Remove support for supdup, c10 and perq
1705 terminals, which are no longer supported (bug#1482).
1707 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1709 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1711 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1713 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1714 for non-popups (Bug#3642).
1716 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1718 * alloc.c (reset_malloc_hooks): Protoize.
1719 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1720 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1721 * cm.c (losecursor): Likewise.
1722 * data.c (fmod): Likewise.
1723 * dispnew.c (swap_glyphs_in_rows): Likewise.
1724 * emacs.c (memory_warning_signal): Likewise.
1725 * floatfns.c (float_error): Likewise.
1726 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1727 (otf_open, font_otf_capability, generate_otf_features)
1728 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1730 * image.c (pbm_read_file): Likewise.
1731 * indent.c (string_display_width): Likewise.
1732 * intervals.c (check_for_interval, search_for_interval)
1733 (inc_interval_count, count_intervals, root_interval)
1734 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1735 * lread.c (defalias): Likewise.
1736 * ralloc.c (r_alloc_check): Likewise.
1737 * regex.c (set_image_of_range_1, set_image_of_range)
1738 (regex_grow_registers): Likewise.
1739 * sysdep.c (strerror): Likewise.
1740 * termcap.c (valid_filename_p, tprint, main): Likewise.
1741 * tparam.c (main): Likewise.
1742 * unexhp9k800.c (run_time_remap, save_data_space)
1743 (update_file_ptrs, read_header, write_header, calculate_checksum)
1744 (copy_file, copy_rest, display_header): Likewise.
1745 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1747 * xdisp.c (check_it): Likewise.
1748 * xfaces.c (register_color, unregister_color, unregister_colors):
1750 * xfns.c (print_fontset_result): Likewise.
1751 * xrdb.c (member, fatal, main): Likewise.
1753 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1755 Fix minor problems found by static checking (Bug#9031).
1756 * chartab.c (char_table_set_range, map_sub_char_table):
1757 Remove unused locals.
1758 (uniprop_table): Now static.
1759 * composite.c (_work_char): Remove unused static var.
1761 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1763 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1765 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1767 * gtkutil.c (qttip_cb): Remove code without function.
1769 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1771 * w32.c (pthread_sigmask): New stub.
1773 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1775 Use pthread_sigmask, not sigprocmask (Bug#9010).
1776 sigprocmask is portable only for single-threaded applications, and
1777 Emacs can be multi-threaded when it uses GTK.
1778 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1780 * callproc.c (Fcall_process):
1781 * process.c (create_process):
1782 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1783 Use pthread_sigmask, not sigprocmask.
1785 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1787 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1788 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1791 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1793 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1794 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1795 (xg_hide_tooltip): Fix comment.
1797 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1798 in registerServicesMenuSendTypes.
1799 (validRequestorForSendType): Don't check ns_return_types.
1801 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1804 2011-07-08 Jason Rumney <jasonr@gnu.org>
1806 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1807 frame struct members of non-existent frames (Bug#6284).
1809 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1811 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1812 variable firstTime not needed on OSX >= 10.6.
1813 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1814 >= 10.5. Use setKnobProportion, setDoubleValue.
1816 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1817 (MAC_OS_X_VERSION_10_5): Define if not defined.
1818 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1819 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1820 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1822 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1823 cString and lossyCString on OSX >= 10.4
1825 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1826 sizeToFit on OSX >= 10.2.
1828 * nsimage.m (allocInitFromFile): Don't use deprecated method
1829 bestRepresentationForDevice on OSX >= 10.6.
1831 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1834 * emacs.c: Declare unexec_init_emacs_zone.
1836 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1838 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1840 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1841 on svcsMenu (Bug#8842).
1843 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1845 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1847 * nsterm.m (QUTF8_STRING): Declare.
1848 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1849 (validRequestorForSendType): Return type is (id).
1850 Change indexOfObjectIdenticalTo to indexOfObject.
1851 Check if we have local selection before returning self (Bug#8842).
1852 (writeSelectionToPasteboard): Put local selection into paste board
1853 if we have a local selection (Bug#8842).
1854 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1856 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1857 (ns_get_local_selection): Declare.
1859 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1861 * keymap.c (describe_map_tree): Don't insert a double newline at
1862 the end of the buffer (bug#1169) and return whether we inserted
1865 * callint.c (Fcall_interactively): Change "reading args" to
1866 "providing args" to try to clarify what it does (bug#1010).
1868 2011-07-07 Kenichi Handa <handa@m17n.org>
1870 * composite.c (composition_compute_stop_pos): Ignore a static
1871 composition starting before CHARPOS (Bug#8915).
1873 * xdisp.c (handle_composition_prop): Likewise.
1875 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1877 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1880 2011-07-07 Kenichi Handa <handa@m17n.org>
1882 * character.h (unicode_category_t): New enum type.
1884 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1885 (Qchar_code_property_table): New variable.
1886 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1887 (UNIPROP_COMPRESSED_FORM_P): New macros.
1888 (char_table_ascii): Uncompress the compressed values.
1889 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1890 Uncompress the compressed values.
1891 (sub_char_table_ref_and_range): Likewise.
1892 (char_table_ref_and_range): Uncompress the compressed values.
1893 (sub_char_table_set): New arg is_uniprop. Callers changed.
1894 Uncompress the compressed values.
1895 (sub_char_table_set_range): Args changed. Callers changed.
1896 (char_table_set_range): Adjuted for the above change.
1897 (map_sub_char_table): Delete args default_val and parent. Add arg
1898 top. Give decoded values to a Lisp function.
1899 (map_char_table): Adjust for the above change. Give decoded
1900 values to a Lisp function. Gcpro more variables.
1901 (uniprop_table_uncompress)
1902 (uniprop_decode_value_run_length): New functions.
1903 (uniprop_decoder, uniprop_decoder_count): New variables.
1904 (uniprop_get_decoder, uniprop_encode_value_character)
1905 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1907 (uniprop_encoder, uniprop_encoder_count): New variables.
1908 (uniprop_get_encoder, uniprop_table)
1909 (Funicode_property_table_internal, Fget_unicode_property_internal)
1910 (Fput_unicode_property_internal): New functions.
1911 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1912 Sunicode_property_table_internal, Sget_unicode_property_internal,
1913 and Sput_unicode_property_internal. Defvar_lisp
1914 char-code-property-alist.
1916 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1917 Vunicode_category_table.
1919 * font.c (font_range): Adjust for the change of
1920 Vunicode_category_table.
1922 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1924 * m/iris4d.h: Remove file, move contents ...
1925 * s/irix6-5.h: ... here.
1927 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1929 Remove unportable assumption about struct layout (Bug#8884).
1930 * alloc.c (mark_buffer):
1931 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1932 (clone_per_buffer_values): Don't assume that
1933 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1934 This isn't true in general, and it's particularly not true
1935 if Emacs is configured with --with-wide-int.
1936 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1937 New macros, used in the buffer.c change.
1939 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1941 * xsettings.c: Use both GConf and GSettings if both are available.
1942 (store_config_changed_event): Add comment.
1943 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1944 (store_tool_bar_style_changed): New functions.
1945 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1946 (struct xsettings): Move font inside HAVE_XFT.
1947 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1948 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1949 Move inside HAVE_XFT.
1950 (something_changed_gsettingsCB): Rename from something_changedCB.
1951 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1953 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1954 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1955 (something_changed_gconfCB): Rename from something_changedCB.
1956 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1957 (parse_settings): Move check for font inside HAVE_XFT.
1958 (read_settings, apply_xft_settings): Add comment.
1959 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1960 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1961 call store_font_name_changed.
1962 (xft_settings_event): Add comment.
1963 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1964 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1965 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1966 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1967 (xsettings_initialize): Call init_gsettings last.
1968 (xsettings_get_system_font, xsettings_get_system_normal_font):
1971 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1973 Random fixes. E.g., (random) never returned negative values.
1974 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1975 subseconds part to the entropy, as that's a bit more random.
1976 Prefer signed to unsigned, since the signedness doesn't matter and
1977 in general we prefer signed. When given a limit, use a
1978 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1979 latter isn't right if USE_2_TAGS_FOR_INTS.
1980 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1981 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1983 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1985 * textprop.c (text_property_stickiness):
1986 Obey Vtext_property_default_nonsticky.
1987 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1988 * w32fns.c (syms_of_w32fns):
1989 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1991 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1993 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1994 This is more efficient than Ffile_directory_p and avoids a minor race.
1996 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1998 * buffer.c (Foverlay_put): Say what the return value is
2001 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2002 is a directory before asking whether to use the file name
2004 (barf_or_query_if_file_exists): Make the "File is a directory"
2005 error be more correct.
2007 * fns.c (Frequire): Remove the mention of the .gz files, since
2008 that's installation-specific, but keep the mention of
2009 `get-load-suffixes'.
2011 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2013 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2014 Report string overflow if the output is too long.
2016 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2018 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2019 (syms_of_gnutls): Remove duplicate DEFSYM for
2020 Qgnutls_bootprop_verify_hostname_error, an error for
2021 Qgnutls_bootprop_verify_error (which is no longer used).
2023 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2024 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2025 Also (re)move comments that are misplaced or no longer relevant.
2027 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2029 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2031 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2033 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2034 and background color parameters if they have been changed.
2036 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2038 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2040 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2042 * xsettings.c (SYSTEM_FONT): Define only when used.
2043 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2045 * keymap.c (access_keymap_1): Now static.
2047 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2049 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2050 leave any prefix arg for the up event (Bug#1586).
2052 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2054 * lread.c (syms_of_lread): Mention single symbols defined by
2055 `defvar' or `defconst' (bug#7154).
2057 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2058 (Frequire): Mention get-load-suffixes.
2060 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2062 * window.h (window): Remove clone_number slot.
2063 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2065 (make_parent_window, make_window, saved_window)
2066 (Fset_window_configuration, save_window_save): Don't deal with
2068 * buffer.c (Qclone_number): Remove declaration.
2069 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2071 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2073 Add multiple inheritance to keymaps.
2074 * keymap.c (Fmake_composed_keymap): New function.
2075 (Fset_keymap_parent): Simplify.
2076 (fix_submap_inheritance): Remove.
2077 (access_keymap_1): New function extracted from access_keymap to handle
2078 embedded parents and handle lists of maps.
2079 (access_keymap): Use it.
2080 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2081 (Fcopy_keymap): Handle embedded parents.
2082 (Fcommand_remapping, define_as_prefix): Simplify.
2083 (Fkey_binding): Simplify.
2084 (syms_of_keymap): Move minibuffer-local-completion-map,
2085 minibuffer-local-filename-completion-map,
2086 minibuffer-local-must-match-map, and
2087 minibuffer-local-filename-must-match-map to Elisp.
2088 (syms_of_keymap): Defsubr make-composed-keymap.
2089 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2090 (parse_menu_item): Trivial simplification.
2092 2011-07-01 Glenn Morris <rgm@gnu.org>
2094 * Makefile.in (SETTINGS_LIBS): Fix typo.
2096 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2098 * coding.c (Fencode_coding_string): Record the last coding system
2099 used, as the function doc string says (bug#8738).
2101 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2103 * xsettings.c (store_monospaced_changed): Take new font as arg and
2104 check for change against current_mono_font.
2105 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2106 (emacs_settings_constructor, emacs_settings_get_property)
2107 (emacs_settings_set_property, emacs_settings_class_init)
2108 (emacs_settings_init, gsettings_obj): Remove.
2109 (something_changedCB): New function for HAVE_GSETTINGS.
2110 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2111 with value as argument.
2112 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2113 g_settings_new (Bug#8967). Do not create gsettings_obj.
2114 Remove calls to g_settings_bind. Connect something_changedCB to
2117 * xgselect.c: Add defined (HAVE_GSETTINGS).
2118 (xgselect_initialize): Ditto.
2120 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2121 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2124 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2126 * eval.c (struct backtrace): Simplify and port the data structure.
2127 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2128 signed bit field, as this assumption is not portable and it makes
2129 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2130 "char debug_on_exit : 1" as this is not portable either; instead,
2131 use the portable "unsigned int debug_on_exit : 1". Remove unused
2132 member evalargs. Remove obsolete comments about cc bombing out.
2134 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2136 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2137 Let HAVE_GSETTINGS override HAVE_GCONF.
2138 (store_monospaced_changed): New function.
2139 (EMACS_SETTINGS): A new type derived from GObject to handle
2140 GSettings notifications.
2141 (emacs_settings_constructor, emacs_settings_get_property)
2142 (emacs_settings_set_property, emacs_settings_class_init):
2144 (gsettings_client, gsettings_obj): New variables.
2145 (GSETTINGS_SCHEMA): New define.
2146 (something_changedCB): Call store_monospaced_changed.
2147 (init_gsettings): New function.
2148 (xsettings_initialize): Call init_gsettings.
2149 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2152 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2155 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2157 * window.c (resize_root_window, grow_mini_window)
2158 (shrink_mini_window): Rename Qresize_root_window to
2159 Qwindow_resize_root_window and Qresize_root_window_vertically to
2160 Qwindow_resize_root_window_vertically.
2162 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2164 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2166 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2168 * makefile.w32-in: Redesign dependencies so they reflect more
2169 clearly which files are directly included by each source file,
2170 and not through other includes.
2172 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2174 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2175 (sort_overlays, overlay_strings): When an overlay's clone number
2176 matches the window's clone number process the overlay even if
2177 the overlay's window property doesn't match the current window.
2179 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2180 (Fwindow_hchild): Rename to Fwindow_left_child.
2181 (Fwindow_next): Rename to Fwindow_next_sibling.
2182 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2183 (resize_window_check): Rename to window_resize_check.
2184 (resize_window_apply): Rename to window_resize_apply.
2185 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2186 (Fdelete_other_windows_internal, resize_frame_windows)
2187 (Fsplit_window_internal, Fdelete_window_internal)
2188 (grow_mini_window, shrink_mini_window)
2189 (Fresize_mini_window_internal): Fix callers accordingly.
2191 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2193 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2194 (emacs_fixed_set_min_size): Remove.
2195 (emacs_fixed_new): Take frame as argument.
2197 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2198 (_EmacsFixedPrivate): Remove minwidth/height.
2199 Add struct frame *f.
2200 (emacs_fixed_init): Initialize priv->f.
2201 (get_parent_class, emacs_fixed_set_min_size): Remove.
2202 (emacs_fixed_new): Set priv->f to argument.
2203 (emacs_fixed_get_preferred_width)
2204 (emacs_fixed_get_preferred_height): Use min_width/height from
2205 frames size_hint to set minimum and natural (Bug#8919).
2206 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2207 and use min_width/height from frames size_hint to set
2208 min_width/height (Bug#8919).
2210 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2211 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2214 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2216 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2217 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2220 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2222 * process.c (wait_reading_process_output): Bypass select if
2223 waiting for a cell while ignoring keyboard input, and input is
2224 pending. Suggested by Jan Djärv (Bug#8869).
2226 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2228 Use gnulib's dup2 module instead of rolling our own.
2229 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2231 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2233 * dispnew.c (scrolling_window): Before scrolling, turn off a
2234 mouse-highlight in the window being scrolled.
2236 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2238 Move DEFSYM to lisp.h and use everywhere.
2240 * character.h (DEFSYM): Move declaration...
2241 * lisp.h (DEFSYM): ...here.
2247 * w32select.c: Don't include character.h.
2249 * alloc.c (syms_of_alloc):
2250 * buffer.c (syms_of_buffer):
2251 * bytecode.c (syms_of_bytecode):
2252 * callint.c (syms_of_callint):
2253 * casefiddle.c (syms_of_casefiddle):
2254 * casetab.c (init_casetab_once):
2255 * category.c (init_category_once, syms_of_category):
2256 * ccl.c (syms_of_ccl):
2257 * cmds.c (syms_of_cmds):
2258 * composite.c (syms_of_composite):
2259 * dbusbind.c (syms_of_dbusbind):
2260 * dired.c (syms_of_dired):
2261 * dispnew.c (syms_of_display):
2262 * doc.c (syms_of_doc):
2263 * editfns.c (syms_of_editfns):
2264 * emacs.c (syms_of_emacs):
2265 * eval.c (syms_of_eval):
2266 * fileio.c (syms_of_fileio):
2267 * fns.c (syms_of_fns):
2268 * frame.c (syms_of_frame):
2269 * fringe.c (syms_of_fringe):
2270 * insdel.c (syms_of_insdel):
2271 * keymap.c (syms_of_keymap):
2272 * lread.c (init_obarray, syms_of_lread):
2273 * macros.c (syms_of_macros):
2274 * msdos.c (syms_of_msdos):
2275 * print.c (syms_of_print):
2276 * process.c (syms_of_process):
2277 * search.c (syms_of_search):
2278 * sound.c (syms_of_sound):
2279 * syntax.c (init_syntax_once, syms_of_syntax):
2280 * terminal.c (syms_of_terminal):
2281 * textprop.c (syms_of_textprop):
2282 * undo.c (syms_of_undo):
2283 * w32.c (globals_of_w32):
2284 * window.c (syms_of_window):
2285 * xdisp.c (syms_of_xdisp):
2286 * xfaces.c (syms_of_xfaces):
2287 * xfns.c (syms_of_xfns):
2288 * xmenu.c (syms_of_xmenu):
2289 * xsettings.c (syms_of_xsettings):
2290 * xterm.c (syms_of_xterm): Use DEFSYM.
2292 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2294 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2296 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2298 Integer and buffer overflow fixes (Bug#8873).
2300 * print.c (printchar, strout): Check for string overflow.
2301 (PRINTPREPARE, printchar, strout):
2302 Don't set size unless allocation succeeds.
2304 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2305 for sizes. Check for string overflow more accurately.
2306 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2308 * macros.c: Integer and buffer overflow fixes.
2309 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2310 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2311 Use ptrdiff_t, not int, for sizes.
2312 Don't increment bufsize until after realloc succeeds.
2313 Check for size-calculation overflow.
2314 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2316 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2318 * lread.c: Integer overflow fixes.
2319 (read_integer): Radix is now EMACS_INT, not int,
2320 to improve quality of diagnostics for out-of-range radices.
2321 Calculate buffer size correctly for out-of-range radices.
2322 (read1): Check for integer overflow in radices, and in
2323 read-circle numbers.
2324 (read_escape): Avoid int overflow.
2325 (Fload, openp, read_buffer_size, read1)
2326 (substitute_object_recurse, read_vector, read_list, map_obarray):
2327 Use ptrdiff_t, not int, for sizes.
2328 (read1): Use EMACS_INT, not int, for sizes.
2329 Check for size overflow.
2331 * image.c (cache_image): Check for size arithmetic overflow.
2333 * lread.c: Integer overflow issues.
2334 (saved_doc_string_size, saved_doc_string_length)
2335 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2336 Now ptrdiff_t, not int.
2337 (read1): Don't assume doc string length fits in int. Check for
2338 out-of-range doc string lengths.
2339 (read_list): Don't assume file position fits in int.
2340 (read_escape): Check for hex character overflow.
2342 2011-06-22 Leo Liu <sdl.web@gmail.com>
2344 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2345 Move to minibuffer.el.
2347 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2349 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2350 The following patches are for when GLYPH_DEBUG && !XASSERT.
2351 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2352 * dispnew.c (flush_stdout):
2353 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2354 Mark as externally visible.
2355 * dispnew.c (check_window_matrix_pointers): Now static.
2356 * dispnew.c (window_to_frame_vpos):
2357 * xfns.c (unwind_create_frame):
2358 * xterm.c (x_check_font): Remove unused local.
2359 * scroll.c (CHECK_BOUNDS):
2360 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2361 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2362 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2363 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2364 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2366 (debug_method_add): Use va_list and vsprintf rather than relying
2367 on undefined behavior with wrong number of arguments.
2368 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2369 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2370 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2371 since we're not interested in debugging glyphs with old libraries.
2372 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2373 GCC 4.6.0's static checking.
2375 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2377 Integer overflow and signedness fixes (Bug#8873).
2378 A few related buffer overrun fixes, too.
2380 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2382 * dispextern.h (struct face.stipple):
2383 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2384 (x_bitmap_mask, x_allocate_bitmap_record)
2385 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2386 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2387 (x_create_bitmap_from_xpm_data):
2388 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2389 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2391 * xfaces.c (load_pixmap):
2392 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2393 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2394 (.bitmaps_last, struct x_output.icon_bitmap):
2395 Use ptrdiff_t, not int, for bitmap indexes.
2396 (x_allocate_bitmap_record): Check for size overflow.
2397 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2399 Use ptrdiff_t, not int, for overlay counts.
2400 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2401 * editfns.c (overlays_around, get_pos_property):
2402 * textprop.c (get_char_property_and_overlay):
2403 * xdisp.c (next_overlay_change, note_mouse_highlight):
2404 * xfaces.c (face_at_buffer_position):
2405 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2406 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2407 (Fnext_overlay_change, Fprevious_overlay_change)
2408 (mouse_face_overlay_overlaps, Foverlays_in):
2409 Use ptrdiff_t, not int, for sizes.
2410 (overlays_at, overlays_in): Check for size-calculation overflow.
2412 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2414 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2415 (x_session_initialize): Do not assume string length fits in int.
2417 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2418 This is unlikely, but can occur if DPI is outlandish.
2420 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2421 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2423 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2424 * xrdb.c (magic_file_p, search_magic_path):
2425 Omit last arg SUFFIX; it was always 0. All callers changed.
2426 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2428 * xfont.c (xfont_match): Avoid need for strlen.
2430 * xfns.c: Don't assume strlen fits in int.
2431 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2433 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2434 not unsigned long, as we prefer signed integers. All callers changed.
2435 Detect integer overflow in repeat count.
2436 (message_dolog): Don't assume print length fits in 39 bytes.
2437 (display_mode_element): Don't assume strlen fits in int.
2439 * termcap.c: Don't assume sizes fit in int and never overflow.
2440 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2441 (gobble_line): Check for size-calculation overflow.
2443 * minibuf.c (Fread_buffer):
2444 * lread.c (intern, intern_c_string):
2445 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2446 Don't assume string length fits in int.
2448 * keyboard.c (parse_tool_bar_item):
2449 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2451 * font.c: Don't assume string length fits in int.
2452 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2453 Use ptrdiff_t, not int.
2454 (font_intern_prop): Don't assume string length fits in int.
2455 Don't assume integer property fits in fixnum.
2456 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2458 * filelock.c: Fix some buffer overrun and integer overflow issues.
2459 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2460 Reformulate so as not to need the command string.
2461 Invoke gzip -cd rather than gunzip, as it's more portable.
2462 (lock_info_type, lock_file_1, lock_file):
2463 Don't assume pid_t and time_t fit in unsigned long.
2464 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2465 (current_lock_owner): Prefer signed type for sizes.
2466 Use memcpy, not strncpy, where memcpy is what is really wanted.
2467 Don't assume (via atoi) that time_t and pid_t fit in int.
2468 Check for time_t and/or pid_t out of range, e.g., via a network share.
2469 Don't alloca where an auto var works fine.
2471 * fileio.c: Fix some integer overflow issues.
2472 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2473 Don't assume string length fits in int.
2474 (directory_file_name): Don't assume string length fits in long.
2475 (make_temp_name): Don't assume pid fits in int, or that its print
2476 length is less than 20.
2478 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2480 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2482 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2484 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2485 We prefer signed integers, even for size calculations.
2487 * emacs.c: Don't assume string length fits in 'int'.
2488 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2489 (main): Don't invoke strlen when not needed.
2491 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2492 (XD_DEBUG_MESSAGE): Don't waste a byte.
2494 * callproc.c (getenv_internal_1, getenv_internal)
2496 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2498 * lread.c (invalid_syntax): Omit length argument.
2499 All uses changed. This doesn't fix a bug, but it simplifies the
2500 code away from its former Hollerith-constant appearance, and it's
2501 one less 'int' to worry about when looking at integer-overflow issues.
2502 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2504 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2505 This didn't break anything, but it didn't help either.
2506 It's confusing to put a bogus integer in a place where the actual
2507 value does not matter.
2508 (LIST_END_P): Remove unused macro and its bogus comment.
2509 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2511 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2512 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2514 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2515 We prefer signed types, and the value cannot exceed the EMACS_INT
2516 range anyway (because otherwise the length would not be representable).
2517 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2518 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2519 This avoids a GCC warning when WIDE_EMACS_INT.
2521 * indent.c (sane_tab_width): New function.
2522 (current_column, scan_for_column, Findent_to, position_indentation)
2523 (compute_motion): Use it. This is just for clarity.
2524 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2526 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2528 * lisp.h (lint_assume): New macro.
2529 * composite.c (composition_gstring_put_cache):
2530 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2532 * editfns.c, insdel.c:
2533 Omit unnecessary forward decls, to simplify future changes.
2535 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2537 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2539 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2540 Use much-faster test for byte-length change.
2541 Don't assume string byte-length fits in 'int'.
2542 Check that character arg fits in 'int'.
2543 (mapcar1): Declare byte as byte, for clarity.
2545 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2547 * fns.c (concat): Catch string overflow earlier.
2548 Do not rely on integer wraparound.
2550 * dispextern.h (struct it.overlay_strings_charpos)
2551 (struct it.selective): Now EMACS_INT, not int.
2552 * xdisp.c (forward_to_next_line_start)
2553 (back_to_previous_visible_line_start)
2554 (reseat_at_next_visible_line_start, next_element_from_buffer):
2555 Don't arbitrarily truncate the value of 'selective' to int.
2557 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2559 * composite.c: Don't truncate sizes to 'int'.
2560 (composition_gstring_p, composition_reseat_it)
2561 (composition_adjust_point): Use EMACS_INT, not int.
2562 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2563 not EMACS_UINT, for indexes.
2565 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2567 * buffer.c: Include <verify.h>.
2568 (struct sortvec.priority, struct sortstr.priority):
2569 Now EMACS_INT, not int.
2570 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2571 (struct sortstr.size, record_overlay_string)
2572 (struct sortstrlist.size, struct sortlist.used):
2573 Don't truncate size to int.
2574 (record_overlay_string): Check for size-calculation overflow.
2575 (init_buffer_once): Check at compile-time, not run-time.
2577 2011-06-22 Jim Meyering <meyering@redhat.com>
2579 Don't leak an XBM-image-sized buffer
2580 * image.c (xbm_load): Free the image buffer after using it.
2582 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2585 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2586 that Sun C diagnosed.
2587 * fns.c (secure_hash): Fix pointer signedness issue.
2588 * intervals.c (static_offset_intervals): New function.
2589 (offset_intervals): Use it.
2591 2011-06-21 Leo Liu <sdl.web@gmail.com>
2594 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2597 * fns.c (secure_hash): Rename from crypto_hash_function and change
2598 the first arg to accept symbols.
2599 (Fsecure_hash): New primitive.
2600 (syms_of_fns): New symbols.
2602 2011-06-20 Deniz Dogan <deniz@dogan.se>
2604 * process.c (Fset_process_buffer): Clarify return value in
2607 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2609 * dispnew.c (add_window_display_history): Use BVAR.
2611 * xdisp.c (debug_method_add): Use BVAR.
2612 (check_window_end, dump_glyph_matrix, dump_glyph)
2613 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2615 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2618 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2619 check till after the cache is created in init_frame_faces.
2621 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2623 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2625 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2627 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2628 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2629 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2631 Improve buffer-overflow checking (Bug#8873).
2632 * fileio.c (Finsert_file_contents):
2633 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2634 Remove the old (too-loose) buffer overflow checks.
2635 They weren't needed, since make_gap checks for buffer overflow.
2636 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2637 The old code merely checked for Emacs fixnum overflow, and relied
2638 on undefined (wraparound) behavior. The new code avoids undefined
2639 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2641 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2642 Tune. Don't use wider integers than needed. Don't use alloca.
2643 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2645 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2647 * insdel.c, lisp.h (buffer_overflow): New function.
2648 (insert_from_buffer_1, replace_range, replace_range_2):
2649 * insdel.c (make_gap_larger):
2650 * editfns.c (Finsert_char):
2651 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2653 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2655 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2657 Integer overflow and signedness fixes (Bug#8873).
2659 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2660 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2662 * fileio.c: Don't assume EMACS_INT fits in off_t.
2663 (emacs_lseek): New static function.
2664 (Finsert_file_contents, Fwrite_region): Use it.
2665 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2667 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2669 * fns.c: Don't overflow int when computing a list length.
2670 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2671 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2672 truncation on 64-bit hosts. Check for QUIT every
2673 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2674 faster and is responsive enough.
2675 (Flength): Report an error instead of overflowing an integer.
2676 (Fsafe_length): Return a float if the value is not representable
2677 as a fixnum. This shouldn't happen except in contrived situations.
2678 (Fnthcdr, Fsort): Don't assume list length fits in int.
2679 (Fcopy_sequence): Don't assume vector length fits in int.
2681 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2682 (header_size, word_size): New constants.
2683 (allocate_vectorlike): Don't check size overflow here.
2684 (allocate_vector): Check it here instead, since this is the only
2685 caller of allocate_vectorlike that could cause overflow.
2686 Check that the new vector's length is representable as a fixnum.
2688 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2689 The previous code was bogus. For example, next_almost_prime (32)
2690 returned 39, which is undesirable as it is a multiple of 3; and
2691 next_almost_prime (24) returned 25, which is a multiple of 5 so
2692 why was the code bothering to check for multiples of 7?
2694 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2696 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2698 Variadic C functions now count arguments with ptrdiff_t.
2699 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2700 Back then I didn't know that the Emacs coding style prefers signed int.
2701 Also, in the meantime I found a few more instances where arguments
2702 were being counted with int, which may truncate counts on 64-bit
2703 machines, or EMACS_INT, which may be unnecessarily wide.
2704 * lisp.h (struct Lisp_Subr.function.aMANY)
2705 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2706 Arg counts are now ptrdiff_t, not size_t.
2707 All variadic functions and their callers changed accordingly.
2708 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2709 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2710 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2711 * callint.c (Fcall_interactively): Check arg count for overflow,
2712 to avoid potential buffer overrun. Use signed char, not 'int',
2713 for 'varies' array, so that we needn't bother to check its size
2714 calculation for overflow.
2715 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2716 * eval.c (apply_lambda):
2717 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2718 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2719 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2721 * callint.c (Fcall_interactively): Don't use index var as event count.
2723 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2724 * mem-limits.h (SIZE): Remove; no longer used.
2726 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2728 Remove unnecessary casts.
2729 * xterm.c (x_term_init):
2730 * xfns.c (x_set_border_pixel):
2731 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2732 These aren't needed now that we assume ANSI C.
2734 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2735 It's more likely to cause problems (due to unsigned overflow)
2738 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2740 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2742 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2744 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2746 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2748 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2750 GLYPH_CODE_FACE returns EMACS_INT, not int.
2751 * dispextern.h (merge_faces):
2752 * xfaces.c (merge_faces):
2753 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2754 Don't assume EMACS_INT fits in int.
2756 * character.h (CHAR_VALID_P): Remove unused parameter.
2757 * fontset.c, lisp.h, xdisp.c: All uses changed.
2759 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2761 * fns.c (concat): Minor tuning based on overflow analysis.
2762 This doesn't fix any bugs. Use int to hold character, instead
2763 of constantly refetching from Emacs object. Use XFASTINT, not
2764 XINT, for value known to be a character. Don't bother comparing
2765 a single byte to 0400, as it's always less.
2767 * floatfns.c (Fexpt):
2768 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2770 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2773 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2775 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2776 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2777 incorrectly succeed when S was a string, because 4294967386 was
2778 truncated before it was used.
2780 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2781 Otherwise, an out-of-range integer could cause undefined behavior
2784 * composite.c: Use int, not EMACS_INT, for characters.
2785 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2786 EMACS_INT, for values that are known to be in character range.
2787 This doesn't fix any bugs but is the usual style inside Emacs and
2788 may generate better code on 32-bit machines.
2790 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2791 This is for reasons similar to the recent CHAR_STRING fix.
2792 * charset.c (Fencode_char): Check that character arg is actually
2793 a character. Pass an int to ENCODE_CHAR.
2794 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2795 wider than 'int', as a compile-time check to prevent future regressions
2798 * character.c (char_string): Remove unnecessary casts.
2800 Make sure a 64-bit char is never passed to CHAR_STRING.
2801 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2802 by silently ignoring the top 32 bits, allowing some values
2803 that were far too large to be valid characters.
2804 * character.h: Include <verify.h>.
2805 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2806 arguments are no wider than unsigned, as a compile-time check
2807 to prevent future regressions in this area.
2809 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2810 (Fsubst_char_in_region):
2812 * xdisp.c (decode_mode_spec_coding):
2813 Adjust to CHAR_STRING's new requirement.
2814 * editfns.c (Finsert_char, Fsubst_char_in_region):
2815 * fns.c (concat): Check that character args are actually
2816 characters. Without this test, these functions did the wrong
2817 thing with wildly out-of-range values on 64-bit hosts.
2819 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2820 These casts should not be needed on 32-bit hosts, either.
2821 * keyboard.c (read_char):
2822 * lread.c (Fload): Remove casts to unsigned.
2824 * lisp.h (UNSIGNED_CMP): New macro.
2825 This fixes comparison bugs on 64-bit hosts.
2826 (ASCII_CHAR_P): Use it.
2827 * casefiddle.c (casify_object):
2828 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2829 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2830 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2831 * dispextern.h (FACE_FROM_ID):
2832 * keyboard.c (read_char): Use UNSIGNED_CMP.
2834 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2835 not to EMACS_INT, to avoid GCC warning.
2837 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2839 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2840 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2841 isn't needed on 32-bit machines.
2843 * buffer.c (Fgenerate_new_buffer_name):
2844 Use EMACS_INT for count, not int.
2845 (advance_to_char_boundary): Return EMACS_INT, not int.
2847 * data.c (Qcompiled_function): Now static.
2849 * window.c (window_body_lines): Now static.
2851 * image.c (gif_load): Rename local to avoid shadowing.
2853 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2854 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2855 * alloc.c (make_save_value): Integer argument is now of type
2857 (mark_object): Use ptrdiff_t, not int.
2858 * lisp.h (pD): New macro.
2859 * print.c (print_object): Use it.
2861 * alloc.c: Use EMACS_INT, not int, to count objects.
2862 (total_conses, total_markers, total_symbols, total_vector_size)
2863 (total_free_conses, total_free_markers, total_free_symbols)
2864 (total_free_floats, total_floats, total_free_intervals)
2865 (total_intervals, total_strings, total_free_strings):
2866 Now EMACS_INT, not int. All uses changed.
2867 (Fgarbage_collect): Compute overall total using a double, so that
2868 integer overflow is less likely to be a problem. Check for overflow
2869 when converting back to an integer.
2870 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2871 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2872 These were 'int' variables that could overflow on 64-bit hosts;
2873 they were never used, so remove them instead of repairing them.
2874 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2875 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2876 Previously, this ceilinged at INT_MAX, but that doesn't work on
2878 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2880 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2881 (allocate_vectorlike): Check for ptrdiff_t overflow.
2882 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2883 when a (possibly-narrower) signed value would do just as well.
2884 We prefer using signed arithmetic, to avoid comparison confusion.
2886 * alloc.c: Catch some string size overflows that we were missing.
2887 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2888 for convenience in STRING_BYTES_MAX.
2889 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2890 The definition here is exact; the one in lisp.h was approximate.
2891 (allocate_string_data): Check for string overflow. This catches
2892 some instances we weren't catching before. Also, it catches
2893 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2894 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2895 and ptrdiff_t and EMACS_INT are both 64 bits.
2897 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2898 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2899 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2901 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2903 * alloc.c (Fmake_string): Check for out-of-range init.
2905 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2907 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2909 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2911 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2912 xg_get_default_scrollbar_width.
2914 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2915 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2916 (style_changed_cb): Call update_theme_scrollbar_width and call
2917 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2918 all frames (Bug#8505).
2919 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2920 Call gtk_window_set_resizable if HAVE_GTK3.
2921 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2922 and height if HAVE_GTK3 (Bug#8505).
2923 (scroll_bar_width_for_theme): New variable.
2924 (update_theme_scrollbar_width): New function.
2925 (xg_get_default_scrollbar_width): Move code to
2926 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2927 (xg_initialize): Call update_theme_scrollbar_width.
2929 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2931 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2933 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2935 * frame.c (make_frame): Call other_buffer_safely instead of
2938 * window.c (temp_output_buffer_show): Call display_buffer with
2939 second argument Vtemp_buffer_show_specifiers and reset latter
2940 immediately after the call.
2941 (Vtemp_buffer_show_specifiers): New variable.
2942 (auto_window_vscroll_p, next_screen_context_lines)
2943 (Vscroll_preserve_screen_position): Remove leading asterisks from
2946 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2948 Fix minor problems found by GCC 4.6.0 static checking.
2949 * buffer.c (Qclone_number): Remove for now, as it's unused.
2950 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2951 (record_buffer): Remove unused local.
2952 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2953 (set_frame_buffer_list): Remove; unused.
2954 * frame.h (other_visible_frames): Remove decl.
2955 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2956 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2957 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2959 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2960 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2961 Define only if HAVE_GPM.
2962 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2963 (update_hints_inhibit): Remove; never set. All uses removed.
2964 * widgetprv.h (emacsFrameClassRec): Remove decl.
2965 * window.c (delete_deletable_window): Now returns void, since it
2966 wasn't returning anything.
2967 (compare_window_configurations): Remove unused locals.
2968 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2969 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2970 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2971 the same widths as pointers. This follows up on the 2011-05-06 patch.
2972 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2973 * xterm.h: Likewise.
2974 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2976 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2978 * makefile.w32-in: Update dependencies.
2979 (LISP_H): Add lib/intprops.h.
2981 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2983 * image.c (gif_load): Add animation frame delay to the metadata.
2984 (syms_of_image): Use DEFSYM. New symbol `delay'.
2986 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2988 * window.c (delete_deletable_window): Re-add.
2989 (Fset_window_configuration): Rewrite to handle dead buffers and
2990 consequently deletable windows.
2991 (window_tree, Fwindow_tree): Remove. Supply functionality in
2993 (compare_window_configurations): Simplify code.
2995 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2997 * image.c (imagemagick_load_image): Fix type mismatch.
2998 (Fimagemagick_types): Likewise.
3000 * window.h (replace_buffer_in_windows): Declare.
3002 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3004 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3005 Qclone_number. Remove external declaration of Qdelete_window.
3006 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3008 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3009 Run Qbuffer_list_update_hook if allowed.
3010 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3011 buffer list implementation.
3012 (other_buffer_safely): New function.
3013 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3014 calls to replace_buffer_in_windows and
3015 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3017 (record_buffer): Inhibit quitting and rewrite using quittable
3018 functions. Run Qbuffer_list_update_hook if allowed.
3019 (Frecord_buffer, Funrecord_buffer): New functions.
3020 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3021 Move switch-to-buffer to window.el.
3022 (bury-buffer): Move to window.el.
3023 (Vbuffer_list_update_hook): New variable.
3025 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3028 * window.h (resize_frame_windows): Move up in code.
3029 (Fwindow_frame): Remove EXFUN.
3030 (replace_buffer_in_all_windows): Remove prototype.
3031 (replace_buffer_in_windows_safely): Add prototype.
3033 * window.c: Declare Qdelete_window static again. Move down
3034 declaration of select_count.
3035 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3036 (Fother_window): Move to window.el.
3037 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3038 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3039 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3041 (replace_buffer_in_windows): Implement by calling
3042 Qreplace_buffer_in_windows.
3043 (replace_buffer_in_all_windows): Remove with some functionality
3044 moved into replace_buffer_in_windows_safely.
3045 (replace_buffer_in_windows_safely): New function.
3046 (select_window_norecord, select_frame_norecord): Move in front
3047 of run_window_configuration_change_hook. Remove now obsolete
3049 (Fset_window_buffer): Rewrite doc-string.
3050 Call Qrecord_window_buffer.
3051 (keys_of_window): Move binding for other-window to window.el.
3053 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3055 * dispextern.h (struct image): Replace data member, whose int_val
3056 and ptr_val fields were not used by anything, with a single
3059 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3060 (gif_clear_image, gif_load, imagemagick_load_image)
3061 (gs_clear_image, gs_load): Callers changed.
3063 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3065 * buffer.h: Include <time.h>, for time_t.
3066 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3068 Fix minor problems found by static checking.
3070 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3072 Make identifiers static if they are not used in other modules.
3073 * data.c (Qcompiled_function, Qframe, Qvector):
3074 * image.c (QimageMagick, Qsvg):
3075 * minibuf.c (Qmetadata):
3076 * window.c (resize_window_check, resize_root_window): Now static.
3077 * window.h (resize_window_check, resize_root_window): Remove decls.
3079 * window.c (window_deletion_count, delete_deletable_window):
3081 (window_body_lines): Now static.
3082 (Fdelete_other_windows_internal): Mark vars as initialized.
3083 Make sure 'resize_failed' is initialized.
3084 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3085 (resize_window_apply): Remove unused local.
3086 * window.h (delete_deletable_window): Remove decl.
3088 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3089 (imagemagick_load_image): Fix pointer signedness problem by changing
3090 last arg from unsigned char * to char *. All uses changed.
3091 Also, fix a local for similar reasons.
3092 Remove unused locals. Remove locals to avoid shadowing.
3093 (fn_rsvg_handle_free): Remove; unused.
3094 (svg_load, svg_load_image): Fix pointer signedness problem.
3095 (imagemagick_load_image): Don't use garbage pointer image_wand.
3097 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3099 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3101 * image.c (gif_load): Fix omitted cast error introduced by
3104 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3106 * window.h (resize_proportionally, orig_total_lines)
3107 (orig_top_line): Remove from window structure.
3108 (set_window_height, set_window_width, change_window_heights)
3109 (Fdelete_window): Remove prototypes.
3110 (resize_frame_windows): Remove duplicate declaration.
3112 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3114 * window.h (resize_frame_windows, resize_window_check)
3115 (delete_deletable_window, resize_root_window)
3116 (resize_frame_windows): Declare prototypes.
3118 * window.c (resize_window_apply): Make definition be "static" to
3119 match the prototype.
3121 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3123 * window.c: Remove declarations of Qwindow_size_fixed,
3124 window_min_size_1, window_min_size_2, window_min_size,
3125 size_window, window_fixed_size_p, enlarge_window, delete_window.
3126 Remove static from declaration of Qdelete_window, it's
3127 temporarily needed by Fbury_buffer.
3128 (replace_window): Don't assign orig_top_line and
3130 (Fdelete_window, delete_window): Remove. Window deletion is
3131 handled by window.el.
3132 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3133 Replace Fdelete_window calls with calls to Qdelete_window.
3134 (Fdelete_other_windows): Remove. Deleting other windows is
3135 handled by window.el.
3136 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3137 handled in window.el.
3138 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3139 Window minimum sizes are handled in window.el.
3140 (shrink_windows, size_window, set_window_height)
3141 (set_window_width, change_window_heights, window_height)
3142 (window_width, CURBEG, CURSIZE, enlarge_window)
3143 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3144 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3145 handled in window.el.
3146 (make_dummy_parent): Rename to make_parent_window and give it a
3147 second argument horflag.
3148 (make_window): Don't set resize_proportionally any more.
3149 (Fsplit_window): Remove. Windows are split in window.el.
3150 (save_restore_action, save_restore_orig_size)
3151 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3152 Resize mini windows in window.el.
3153 (grow_mini_window, shrink_mini_window): Implement by calling
3154 Qresize_root_window_vertically, resize_window_check and
3155 resize_window_apply.
3156 (saved_window, Fset_window_configuration, save_window_save):
3157 Do not handle orig_top_line, orig_total_lines, and
3158 resize_proportionally.
3159 (window_min_height, window_min_width): Move to window.el.
3160 (keys_of_window): Move bindings for delete-other-windows,
3161 split-window, delete-window and enlarge-window to window.el.
3163 * buffer.c: Temporarily extern Qdelete_window.
3164 (Fbury_buffer): Temporarily call Qdelete_window instead of
3165 Fdelete_window (Fbury_buffer will move to window.el soon).
3167 * frame.c (set_menu_bar_lines_1): Remove code handling
3168 orig_top_line and orig_total_lines.
3170 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3171 set_window_height but set heights directly.
3172 (change_frame_size_1): Use resize_frame_windows.
3174 * xdisp.c (init_xdisp): Don't use set_window_height but set
3177 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3178 Use resize_frame_windows instead of change_window_heights and run
3179 run_window_configuration_change_hook.
3181 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3182 instead of change_window_heights and run
3183 run_window_configuration_change_hook.
3185 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3187 * window.c (replace_window): Rename second argument REPLACEMENT to
3188 NEW. New third argument SETFLAG. Rewrite.
3189 (delete_window, make_dummy_parent): Call replace_window with
3191 (window_list_1): Move down in code.
3192 (run_window_configuration_change_hook): Move set_buffer part
3193 before select_frame_norecord part in order to unwind correctly.
3194 Rename count1 to count.
3195 (recombine_windows, delete_deletable_window, resize_root_window)
3196 (Fdelete_other_windows_internal)
3197 (Frun_window_configuration_change_hook, make_parent_window)
3198 (resize_window_check, resize_window_apply, Fresize_window_apply)
3199 (resize_frame_windows, Fsplit_window_internal)
3200 (Fdelete_window_internal, Fresize_mini_window_internal):
3202 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3204 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3206 * window.h (window): Add some new members to window structure -
3207 normal_lines, normal_cols, new_total, new_normal, clone_number,
3208 splits, nest, prev_buffers, next_buffers.
3209 (WINDOW_TOTAL_SIZE): Move here from window.c.
3210 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3212 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3214 (make_dummy_parent): Set new members of windows structure.
3215 (make_window): Move down in code. Handle new members of window
3217 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3218 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3219 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3220 (Fset_window_prev_buffers, Fwindow_next_buffers)
3221 (Fset_window_next_buffers, Fset_window_clone_number):
3223 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3224 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3226 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3227 Argument WINDOW can be now internal window too.
3228 (Fwindow_use_time): Move up in code.
3229 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3231 (Fset_window_configuration, saved_window)
3232 (Fcurrent_window_configuration, save_window_save): Handle new
3233 members of window structure.
3234 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3235 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3236 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3237 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3238 Qget_mru_window, Qresize_root_window,
3239 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3240 Qauto_buffer_name; staticpro them.
3242 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3244 * window.c (Fwindow_total_size, Fwindow_left_column)
3245 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3246 (Fwindow_list_1): New functions.
3247 (window_box_text_cols): Replace with window_body_cols.
3248 (Fwindow_width, Fscroll_left, Fscroll_right):
3249 Use window_body_cols instead of window_box_text_cols.
3250 (delete_window, Fset_window_configuration):
3251 Call delete_all_subwindows with window as argument.
3252 (delete_all_subwindows): Take a window as argument and not a
3254 (window_loop): Remove handling of GET_LRU_WINDOW and
3256 (Fget_lru_window, Fget_largest_window): Move to window.el.
3258 * window.h: Extern window_body_cols instead of
3259 window_box_text_cols. delete_all_subwindows now takes a
3260 Lisp_Object as argument.
3262 * indent.c (compute_motion, Fcompute_motion):
3263 Use window_body_cols instead of window_box_text_cols.
3265 * frame.c (delete_frame): Call delete_all_subwindows with root
3268 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3270 * fns.c (Fputhash): Document return value.
3272 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3274 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3276 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3278 Cons<->int and similar integer overflow fixes (Bug#8794).
3280 Check for overflow when converting integer to cons and back.
3281 * charset.c (Fdefine_charset_internal, Fdecode_char):
3282 Use cons_to_unsigned to catch overflow.
3283 (Fencode_char): Use INTEGER_TO_CONS.
3284 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3285 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3286 * data.c (long_to_cons, cons_to_long): Remove.
3287 (cons_to_unsigned, cons_to_signed): New functions.
3288 These signal an error for invalid or out-of-range values.
3289 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3290 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3291 * font.c (Ffont_variation_glyphs):
3292 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3293 * lisp.h: Include <intprops.h>.
3294 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3295 (cons_to_signed, cons_to_unsigned): New decls.
3296 (long_to_cons, cons_to_long): Remove decls.
3297 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3298 (Fprimitive_undo): Use CONS_TO_INTEGER.
3299 * xfns.c (Fx_window_property): Likewise.
3300 * xselect.c: Include <limits.h>.
3301 (x_own_selection, selection_data_to_lisp_data):
3302 Use INTEGER_TO_CONS.
3303 (x_handle_selection_request, x_handle_selection_clear)
3304 (x_get_foreign_selection, Fx_disown_selection_internal)
3305 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3306 (lisp_data_to_selection_data): Use cons_to_unsigned.
3307 (x_fill_property_data): Use cons_to_signed.
3308 Report values out of range.
3310 Check for buffer and string overflow more precisely.
3311 * buffer.h (BUF_BYTES_MAX): New macro.
3312 * lisp.h (STRING_BYTES_MAX): New macro.
3313 * alloc.c (Fmake_string):
3314 * character.c (string_escape_byte8):
3315 * coding.c (coding_alloc_by_realloc):
3316 * doprnt.c (doprnt):
3317 * editfns.c (Fformat):
3319 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3320 since they may not be the same number.
3321 * editfns.c (Finsert_char):
3322 * fileio.c (Finsert_file_contents):
3323 Likewise for BUF_BYTES_MAX.
3325 * image.c: Use ptrdiff_t, not int, for sizes.
3326 (slurp_file): Switch from int to ptrdiff_t.
3328 (slurp_file): Check that file size fits in both size_t (for
3329 malloc) and ptrdiff_t (for sanity and safety).
3331 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3332 if b->modtime has its maximal value.
3334 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3336 Don't assume time_t can fit into int.
3337 * buffer.h (struct buffer.modtime): Now time_t, not int.
3338 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3339 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3341 Minor fixes for signed vs unsigned integers.
3342 * character.h (MAYBE_UNIFY_CHAR):
3343 * charset.c (maybe_unify_char):
3344 * keyboard.c (read_char, reorder_modifiers):
3345 XINT -> XFASTINT, since the integer must be nonnegative.
3346 * ftfont.c (ftfont_spec_pattern):
3347 * keymap.c (access_keymap, silly_event_symbol_error):
3348 XUINT -> XFASTINT, since the integer must be nonnegative.
3349 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3350 since it makes no difference and we prefer signed.
3351 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3352 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3355 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3357 * window.h (Fwindow_frame): Declare.
3359 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3361 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3362 (SPARE_MEMORY): Always define.
3363 (LARGE_REQUEST): Remove.
3364 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3366 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3368 * lisp.h: Move EXFUNS for Fframe_root_window,
3369 Fframe_first_window and Fset_frame_selected_window to window.h.
3371 * window.h: Move EXFUNS for Fframe_root_window,
3372 Fframe_first_window and Fset_frame_selected_window here from
3375 * frame.c (Fwindow_frame, Fframe_first_window)
3376 (Fframe_root_window, Fframe_selected_window)
3377 (Fset_frame_selected_window): Move to window.c.
3378 (Factive_minibuffer_window): Move to minibuf.c.
3379 (Fother_visible_frames_p): New function.
3381 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3383 * window.c (decode_window, decode_any_window): Move up in code.
3384 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3385 (inhibit_frame_unsplittable): Remove unused variable.
3386 (Fwindow_buffer): Move up and rewrite doc-string.
3387 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3388 (Fwindow_prev): New functions.
3389 (Fwindow_frame): Move here from frame.c. Accept any window as
3391 (Fframe_root_window, Fframe_first_window)
3392 (Fframe_selected_window): Move here from frame.c. Accept frame
3393 or arbitrary window as argument. Update doc-strings.
3394 (Fminibuffer_window): Move up in code.
3395 (Fwindow_minibuffer_p): Move up in code and simplify.
3396 (Fset_frame_selected_window): Move here from frame.c.
3398 (Fselected_window, select_window, Fselect_window): Move up in
3399 code. Minor doc-string fixes.
3401 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3403 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3404 Do not assume that spare memory exists; that assumption is valid
3405 only if SYSTEM_MALLOC.
3406 (LARGE_REQUEST): New macro, so that the issue of large requests
3407 is separated from the issue of spare memory.
3409 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3411 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3414 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3416 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3419 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3421 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3423 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3425 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3426 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3428 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3430 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3432 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3434 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3435 (x_clipboard_manager_save): Add return value.
3436 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3438 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3439 Obey Vx_select_enable_clipboard_manager. Catch errors in
3440 x_clipboard_manager_save (Bug#8779).
3441 (Vx_select_enable_clipboard_manager): New variable.
3442 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3444 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3446 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3448 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3450 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3451 in the current matrix if keep_current_p is non-zero.
3453 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3455 * bidi.c (bidi_level_of_next_char): Fix last change.
3457 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3459 Support bidi reordering of text covered by display properties.
3461 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3462 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3463 (bidi_cache_search, bidi_cache_iterator_state)
3464 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3465 (bidi_level_of_next_char, bidi_move_to_visually_next):
3466 Support character positions inside a run of characters covered by a
3468 (bidi_paragraph_init, bidi_resolve_explicit_1)
3469 (bidi_level_of_next_char): Call bidi_fetch_char and
3470 bidi_fetch_char_advance instead of FETCH_CHAR and
3472 (bidi_init_it): Initialize new members.
3473 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3475 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3476 instead of using explicit *_CHAR codes.
3477 (bidi_resolve_explicit, bidi_resolve_weak):
3478 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3479 bidirectional text is supported only in multibyte buffers.
3480 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3481 it to initialize the frame_window_p member of struct bidi_it.
3482 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3483 (bidi_resolve_explicit, bidi_resolve_weak)
3484 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3485 bidi_it->nchars is non-positive.
3486 (bidi_level_of_next_char): Don't try to lookup the cache for the
3487 next/previous character if nothing is cached there yet, or if we
3488 were just reseat()'ed to a new position.
3490 * xdisp.c (set_cursor_from_row): Set start and stop points
3491 according to the row's direction when priming the loop that looks
3492 for the glyph on which to display cursor.
3493 (single_display_spec_intangible_p): Function deleted.
3494 (display_prop_intangible_p): Reimplement to call
3495 handle_display_spec instead of single_display_spec_intangible_p.
3496 Accept 3 additional arguments needed by handle_display_spec.
3497 This fixes incorrect cursor motion across display property with complex
3498 values: lists, `(when COND...)' forms, etc.
3499 (single_display_spec_string_p): Support property values that are
3500 lists with the argument STRING its top-level element.
3501 (display_prop_string_p): Fix the condition for processing a
3502 property that is a list to be consistent with handle_display_spec.
3503 (handle_display_spec): New function, refactored from the
3504 last portion of handle_display_prop.
3505 (compute_display_string_pos): Accept additional argument
3506 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3507 value of a `display' property is a "replacing spec".
3508 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3509 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3510 the display property, but just return a value indicating whether
3511 the display property will replace the characters it covers.
3512 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3513 frame_window_p members of struct bidi_it.
3514 (compute_display_string_pos, compute_display_string_end):
3516 (push_it): Accept second argument POSITION, where pop_it should
3517 jump to continue iteration.
3518 (reseat_1): Initialize bidi_it.disp_pos.
3520 * keyboard.c (adjust_point_for_property): Adjust the call to
3521 display_prop_intangible_p to its new signature.
3523 * dispextern.h (struct bidi_it): New member frame_window_p.
3524 (bidi_init_it): Update prototypes.
3525 (display_prop_intangible_p): Update prototype.
3526 (compute_display_string_pos, compute_display_string_end):
3528 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3531 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3533 Malloc failure behavior now depends on size of allocation.
3534 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3535 * lisp.h: Change signatures accordingly.
3536 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3537 All callers changed. (Bug#8762)
3539 * gnutls.c: Use Emacs's memory allocators.
3540 Without this change, the gnutls library would invoke malloc etc.
3541 directly, which causes problems on non-SYNC_INPUT hosts, and which
3542 runs afoul of improving memory_full behavior. (Bug#8761)
3543 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3544 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3545 xfree instead of the default malloc, realloc, free.
3546 (Fgnutls_boot): No need to check for memory allocation failure,
3547 since xmalloc does that for us.
3549 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3550 * category.c (hash_get_category_set):
3551 * ccl.c (ccl_driver):
3552 * charset.c (Fdefine_charset_internal):
3553 * charset.h (struct charset.hash_index):
3554 * composite.c (get_composition_id, gstring_lookup_cache)
3555 (composition_gstring_put_cache):
3556 * composite.h (struct composition.hash_index):
3557 * dispextern.h (struct image.hash):
3558 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3559 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3560 (hashfn_equal, hashfn_user_defined, make_hash_table)
3561 (maybe_resize_hash_table, hash_lookup, hash_put)
3562 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3563 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3564 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3565 * image.c (make_image, search_image_cache, lookup_image)
3566 (xpm_put_color_table_h):
3567 * lisp.h (struct Lisp_Hash_Table):
3568 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3569 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3570 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3571 * alloc.c (allocate_vectorlike):
3572 Check for overflow in vector size calculations.
3573 * ccl.c (ccl_driver):
3574 Check for overflow when converting EMACS_INT to int.
3575 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3576 need to be updated by these changes.
3577 * fns.c (make_hash_table, maybe_resize_hash_table):
3578 Check for integer overflow with large hash tables.
3579 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3580 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3581 (SXHASH_REDUCE): New macro.
3582 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3583 Use it instead of discarding useful hash info with large hash values.
3584 (sxhash_float): New function.
3585 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3586 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3587 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3588 Rewrite to use FIXNUM_BITS, as this simplifies things.
3589 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3590 Adjust signatures to match updated version of code.
3591 (consing_since_gc): Now EMACS_INT, since a single hash table can
3592 use more than INT_MAX bytes.
3594 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3596 Make it possible to build with GCC-4.6+ -O2 -flto.
3598 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3600 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3602 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3603 Call minibuffer-inactive-mode.
3605 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3607 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3608 Update dependencies.
3610 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3612 * data.c (init_data): Remove code for UTS, this system is not
3615 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3617 Don't force ./temacs to start in terminal mode.
3619 * frame.c (make_initial_frame): Initialize faces in all cases, not
3620 only when CANNOT_DUMP is defined.
3621 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3623 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3625 * dispnew.c (add_window_display_history): Use const for the string
3626 pointer. Remove declaration, not needed.
3628 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3630 Use 'inline', not 'INLINE'.
3631 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3632 * alloc.c, fontset.c (INLINE): Remove.
3633 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3634 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3635 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3636 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3637 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3639 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3641 Make it possible to run ./temacs.
3643 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3644 syms_of_callproc does the same thing. Remove test for
3645 "initialized", do it in the caller.
3646 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3648 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3650 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3651 (read_minibuf): Use get_minibuffer.
3652 (syms_of_minibuf): Use DEFSYM.
3653 (Qmetadata): New var.
3654 * data.c (Qbuffer): Don't make it static.
3655 (syms_of_data): Use DEFSYM.
3657 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3659 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3660 (CCL_CODE_MIN): New macro.
3662 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3664 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3666 * eval.c (Qdebug): Now static.
3667 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3668 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3669 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3671 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3673 * image.c: Various fixes to ImageMagick code comments.
3674 (Fimagemagick_types): Doc fix.
3676 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3678 Minor fixes prompted by GCC 4.6.0 warnings.
3680 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3682 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3683 (x_clipboard_manager_save_all): Move extern decl to ...
3684 * xterm.h: ... here, so that it can be checked for consistency.
3686 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3688 * xselect.c (x_clipboard_manager_save_frame)
3689 (x_clipboard_manager_save_all): New functions.
3690 (Fx_clipboard_manager_save): Lisp function deleted.
3692 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3693 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3695 * xterm.h: Update prototype.
3697 2011-05-28 William Xu <william.xwl@gmail.com>
3699 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3702 2011-05-28 Jim Meyering <meyering@redhat.com>
3704 Avoid a sign-extension bug in crypto_hash_function.
3705 * fns.c (to_uchar): Define.
3706 (crypto_hash_function): Use it to convert some newly-signed
3707 variables to unsigned, to avoid sign-extension bugs. For example,
3708 without this change, (md5 "truc") would evaluate to
3709 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3710 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3711 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3713 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3715 Integer overflow fixes.
3717 * dbusbind.c: Serial number integer overflow fixes.
3718 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3719 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3720 to hold a serial number that is too large for a fixnum.
3721 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3722 Check for serial numbers out of range. Decode any serial number
3723 that was so large that it became a float. (Bug#8722)
3725 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3726 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3727 Use XFASTINT rather than XUINT when numbers are nonnegative.
3728 (xd_append_arg, Fdbus_method_return_internal):
3729 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3730 arguments, check that Lisp number is nonnegative, rather than
3731 silently wrapping negative numbers around. (Bug#8722)
3732 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3735 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3737 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3739 ccl: add integer overflow checks
3740 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3741 (IN_INT_RANGE): New macros.
3742 (ccl_driver): Use them to check for integer overflow when
3743 decoding a CCL program. Many of the new checks are whether XINT (x)
3744 fits in int; it doesn't always, on 64-bit hosts. The new version
3745 doesn't catch all possible integer overflows, but it's an
3746 improvement. (Bug#8719)
3748 * alloc.c (make_event_array): Use XINT, not XUINT.
3749 There's no need for unsigned here.
3751 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3752 This follows up to the 2011-05-06 change that substituted uintptr_t
3753 for EMACS_INT. This case wasn't caught back then.
3755 Rework Fformat to avoid integer overflow issues.
3756 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3757 now (part of C89). Include <verify.h>.
3758 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3759 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3760 (Fformat): Avoid the prepass trying to compute sizes; it was only
3761 approximate and thus did not catch overflow reliably. Instead, walk
3762 through the format just once, formatting and computing sizes as we go,
3763 checking for integer overflow at every step, and allocating a larger
3764 buffer as needed. Keep track separately whether the format is
3765 multibyte. Keep only the most-recently calculated precision, rather
3766 than them all. Record whether each argument has been converted to
3767 string. Use EMACS_INT, not int, for byte and char and arg counts.
3768 Support field widths and precisions larger than INT_MAX. Avoid
3769 sprintf's undefined behavior with conversion specifications such as %#d
3770 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3771 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3772 formatting out-of-range floating point numbers with int
3775 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3777 * data.c: Avoid integer truncation in expressions involving floats.
3778 * data.c: Include <intprops.h>.
3779 (arith_driver): When there's an integer overflow in an expression
3780 involving floating point, convert the integers to floating point
3781 so that the resulting value does not suffer from catastrophic
3782 integer truncation. For example, on a 64-bit host (* 4
3783 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3784 Do not rely on undefined behavior after integer overflow.
3786 merge count_size_as_multibyte, parse_str_to_multibyte
3787 * character.c, character.h (count_size_as_multibyte):
3788 Rename from parse_str_to_multibyte; all uses changed.
3789 Check for integer overflow.
3790 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3791 since it's now a duplicate of the other. This is more of
3792 a character than a buffer op, so better that it's in character.c.
3793 * fns.c, print.c: Adjust to above changes.
3795 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3797 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3799 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3801 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3802 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3803 (x_clipboard_manager_save): Now static.
3804 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3806 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3807 (crypto_hash_function): Now static.
3808 Fix pointer signedness problems. Avoid unnecessary initializations.
3810 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3812 * termhooks.h (Vselection_alist): Make it terminal-local.
3814 * terminal.c (create_terminal): Initialize it.
3816 * xselect.c: Support for clipboard managers.
3817 (Vselection_alist): Move to termhooks.h as terminal-local var.
3818 (LOCAL_SELECTION): New macro.
3819 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3820 (symbol_to_x_atom): Remove gratuitous arg.
3821 (x_handle_selection_request, lisp_data_to_selection_data)
3822 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3823 (x_own_selection, x_get_local_selection, x_convert_selection):
3824 New arg, specifying work frame. Use terminal-local Vselection_alist.
3825 (some_frame_on_display): Delete unused function.
3826 (Fx_own_selection_internal, Fx_get_selection_internal)
3827 (Fx_disown_selection_internal, Fx_selection_owner_p)
3828 (Fx_selection_exists_p): New optional frame arg.
3829 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3830 (x_handle_selection_clear): Don't treat other terminals with the
3831 same keyboard specially. Use the terminal-local Vselection_alist.
3832 (x_clear_frame_selections): Use Frun_hook_with_args.
3834 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3836 * xterm.h: Add support for those atoms.
3838 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3840 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3841 (converted_selections, conversion_fail_tag): New global variables.
3842 (x_selection_request_lisp_error): Free the above.
3843 (x_get_local_selection): Remove unnecessary code.
3844 (x_reply_selection_request): Args changed; handle arbitrary array
3845 of converted selections stored in converted_selections.
3846 Separate the XChangeProperty and SelectionNotify steps.
3847 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3848 (x_convert_selection): New function.
3849 (x_handle_selection_event): Simplify.
3850 (x_get_foreign_selection): Don't ignore incoming requests while
3851 waiting for an answer; this will fail when we implement
3852 SAVE_TARGETS, and seems unnecessary anyway.
3853 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3854 (Vx_sent_selection_functions): Doc fix.
3856 2011-05-26 Leo Liu <sdl.web@gmail.com>
3858 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3860 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3862 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3864 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3865 for fringe update if it has periodic bitmap.
3866 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3867 and fringe_bitmap_periodic_p.
3869 * fringe.c (get_fringe_bitmap_data): New function.
3870 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3871 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3872 row. Mark glyph row for fringe update if periodicity changed.
3874 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3875 for fringe update unless it has periodic bitmap.
3877 2011-05-25 Kenichi Handa <handa@m17n.org>
3879 * xdisp.c (get_next_display_element): Set correct it->face_id for
3880 a static composition.
3882 2011-05-24 Leo Liu <sdl.web@gmail.com>
3885 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3887 * fns.c (crypto_hash_function, Fsha1): New function.
3888 (Fmd5): Use crypto_hash_function.
3889 (syms_of_fns): Add Ssha1.
3891 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3893 * gnutls.c: Remove unused macros.
3894 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3895 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3896 Remove macros that are defined and never used.
3897 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3899 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3901 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3902 (Fx_get_selection_internal): Minor cleanup.
3903 (Fx_own_selection_internal): Rename arguments for consistency with
3906 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3908 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3910 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3912 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3914 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3916 * dispnew.c (scrolling_window): Don't exclude the case that the
3917 last enabled row in the desired matrix touches the bottom boundary.
3919 2011-05-21 Glenn Morris <rgm@gnu.org>
3921 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3922 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3923 and add some more files.
3925 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3927 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3928 report_file_error introduced by the change from 2011-05-07.
3930 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3932 * systime.h (Time): Define only if emacs is defined.
3933 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3934 where the include path doesn't have X11/X.h by default. See
3935 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3937 2011-05-20 Kenichi Handa <handa@m17n.org>
3939 * composite.c (find_automatic_composition): Fix previous change.
3941 2011-05-20 Glenn Morris <rgm@gnu.org>
3943 * lisp.mk: New file, split from Makefile.in.
3944 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3945 (shortlisp): Remove.
3946 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3948 2011-05-19 Glenn Morris <rgm@gnu.org>
3950 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3951 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3952 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3953 (lisp): Set the order to that of loadup.el.
3954 (shortlisp): Make it a copy of $lisp.
3955 (SOME_MACHINE_LISP): Remove.
3956 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3957 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3959 2011-05-18 Kenichi Handa <handa@m17n.org>
3961 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3962 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3963 (find_automatic_composition): Mostly rewrite for efficiency.
3965 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3967 * makefile.w32-in: Update dependencies.
3969 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3971 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3972 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3974 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3976 Fix some integer overflow issues, such as string length overflow.
3978 * insdel.c (count_size_as_multibyte): Check for string overflow.
3980 * character.c (lisp_string_width): Check for string overflow.
3981 Use EMACS_INT, not int, for string indexes and lengths; in
3982 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3983 the resulting string length overflows an EMACS_INT; instead,
3984 report a string overflow if no precision given. When checking for
3985 precision exhaustion, use a check that cannot possibly have
3986 integer overflow. (Bug#8675)
3987 * character.h (lisp_string_width): Adjust to new signature.
3989 * alloc.c (string_overflow): New function.
3990 (Fmake_string): Use it. This doesn't change behavior, but saves
3991 a few bytes and will simplify future changes.
3992 * character.c (string_escape_byte8): Likewise.
3993 * lisp.h (string_overflow): New decl.
3995 Fixups, following up to the user-interface timestamp change.
3996 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3997 for UI timestamps, instead of unsigned long.
3998 * msdos.c (mouse_get_pos): Likewise.
3999 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4000 * w32gui.h (Time): Define by including "systime.h" rather than by
4001 declaring it ourselves. (Bug#8664)
4003 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4004 * image.c (clear_image_cache): Likewise.
4006 * term.c (term_mouse_position): Don't assume time_t wraparound.
4008 Be more systematic about user-interface timestamps.
4009 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4010 and sometimes 'EMACS_UINT', to represent these timestamps.
4011 This change causes it to use 'Time' uniformly, as that's what X uses.
4012 This makes the code easier to follow, and makes it easier to catch
4013 integer overflow bugs such as Bug#8664.
4014 * frame.c (Fmouse_position, Fmouse_pixel_position):
4015 Use Time, not unsigned long, for user-interface timestamps.
4016 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4017 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4018 * keyboard.h (last_event_timestamp): Likewise.
4019 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4020 * menu.h (xmenu_show): Likewise.
4021 * term.c (term_mouse_position): Likewise.
4022 * termhooks.h (struct input_event.timestamp): Likewise.
4023 (struct terminal.mouse_position_hook): Likewise.
4024 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4025 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4026 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4027 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4029 * menu.h, termhooks.h: Include "systime.h", for Time.
4031 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4032 Don't assume that the difference between two unsigned long values
4033 can fit into an integer. At this point, we know button_down_time
4034 <= event->timestamp, so the difference must be nonnegative, so
4035 there's no need to cast the result if double-click-time is
4036 nonnegative, as it should be; check that it's nonnegative, just in
4037 case. This bug is triggered when events are more than 2**31 ms
4038 apart (about 25 days). (Bug#8664)
4040 * xselect.c (last_event_timestamp): Remove duplicate decl.
4041 (x_own_selection): Remove needless cast to unsigned long.
4043 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4044 that always fit in int. Use a sentinel instead of a counter, to
4045 avoid a temp and to allay GCC's concerns about possible int overflow.
4046 * frame.h (struct frame): Use int for menu_bar_items_used
4047 instead of EMACS_INT, since it always fits in int.
4049 * menu.c (grow_menu_items): Check for int overflow.
4051 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4053 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4054 Before, the code was not consistent. These values cannot exceed
4055 2**31 - 1 so there's no need to make them unsigned.
4056 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4057 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4058 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4060 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4062 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4063 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4064 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4065 presumably because the widths might not match.
4067 * window.c (size_window): Avoid needless test at loop start.
4069 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4071 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4073 2011-05-12 Drew Adams <drew.adams@oracle.com>
4075 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4077 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4079 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4080 `width' to `bar_area_x' and `bar_area_width', respectively.
4081 (x_scroll_run): Take account of fringe background extension.
4083 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4084 Rename local vars `left' and `width' to `bar_area_x' and
4085 `bar_area_width', respectively.
4086 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4087 background extension.
4089 2011-05-10 Jim Meyering <meyering@redhat.com>
4091 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4093 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4095 * image.c (Finit_image_library): Return t for built-in image types,
4096 like pbm and xbm. (Bug#8640)
4098 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4100 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4102 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4104 * w32console.c (Fset_screen_color): Doc fix.
4105 (Fget_screen_color): New function.
4106 (syms_of_ntterm): Defsubr it.
4108 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4109 unlink the temporary file if Fcall_process didn't create it in the
4111 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4112 child process will be redirected to a file specified with `:file'.
4113 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4114 cue to call_process_cleanup not to close that handle.
4116 2011-05-07 Ben Key <bkey76@gmail.com>
4118 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4119 one of two shell specific rules, either bootstrap-temacs-CMD or
4120 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4121 to the previous implementation of the bootstrap-temacs rule.
4122 The bootstrap-temacs-CMD rule is similar to the previous
4123 implementation of the bootstrap-temacs rule except that it
4124 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4127 These changes, along with some changes to nt/configure.bat,
4128 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4129 earlier fix to add support for --cflags and --ldflags options
4130 that include quotes so that it works whether make uses cmd or
4133 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4135 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4136 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4138 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4139 a string. Handle both cases.
4140 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4141 (Fdbus_register_method): Use Qinvalid_function.
4143 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4145 * makefile.w32-in: Update dependencies.
4146 (LISP_H): Add inttypes.h and stdin.h.
4147 (PROCESS_H): Add unistd.h.
4149 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4151 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4152 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4154 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4156 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4158 * term.c (vfatal): Remove stray call to va_end.
4159 It's not needed and the C Standard doesn't allow it here anyway.
4161 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4162 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4164 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4167 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4169 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4171 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4173 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4175 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4177 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4178 * charset.c (Fdefine_charset_internal): Don't initialize
4179 charset.code_space[15]. The value was garbage, on hosts with
4180 32-bit int (Bug#8600).
4182 * lread.c (read_integer): Be more consistent with string-to-number.
4183 Use string_to_number to do the actual conversion; this avoids
4184 rounding errors and fixes some other screwups. Without this fix,
4185 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4186 (digit_to_number): Move earlier, for benefit of read_integer.
4187 Return -1 if the digit is out of range for the base, -2 if it is
4188 not a digit in any supported base. (Bug#8602)
4190 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4192 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4193 to match comment at start of function. This also removes a
4194 GCC warning about overflow in a 32+64-bit port.
4196 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4198 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4199 Reported by Stefan Monnier in
4200 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4201 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4202 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4204 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4205 (EMACS_UINTPTR): Likewise, with uintptr_t.
4207 * lisp.h: Prefer 64-bit EMACS_INT if available.
4208 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4209 on 32-bit hosts that have 64-bit int, so that they can access
4211 However, temporarily disable this change unless the temporary
4212 symbol WIDE_EMACS_INT is defined.
4214 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4216 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4217 This removes an assumption that EMACS_INT and long are the same
4218 width as pointers. The assumption is true for Emacs porting targets
4219 now, but we want to make other targets possible.
4220 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4221 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4222 In the rest of the code, change types of integers that hold casted
4223 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4224 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4225 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4226 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4227 No need to cast type when ORing.
4228 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4229 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4230 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4231 assume EMACS_INT is the same width as char *.
4232 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4233 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4234 Remove no-longer-needed casts.
4235 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4236 (xg_tool_bar_help_callback, xg_make_tool_item):
4237 Use EMACS_INTPTR to hold an integer
4238 that will be cast to void *; this can avoid a GCC warning
4239 if EMACS_INT is not the same width as void *.
4240 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4241 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4242 (current_message_1, set_message_1):
4243 Use a local to convert to proper width without a cast.
4244 * xmenu.c (dialog_selection_callback): Likewise.
4246 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4247 Also, don't assume VALBITS / RAND_BITS is less than 5,
4248 and don't rely on undefined behavior when shifting a 1 left into
4250 * lisp.h (get_random): Change signature to match.
4252 * lread.c (hash_string): Use size_t, not int, for hash computation.
4253 Normally we prefer signed values; but hashing is special, because
4254 it's better to use unsigned division on hash table sizes so that
4255 the remainder is nonnegative. Also, size_t is the natural width
4256 for hashing into memory. The previous code used 'int', which doesn't
4257 retain enough info to hash well into very large tables.
4258 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4260 * dbusbind.c: Don't possibly lose pointer info when converting.
4261 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4262 Use XPNTR rather than XHASH, so that the high-order bits of
4263 the pointer aren't lost when converting through void *.
4265 * eval.c (Fautoload): Don't double-shift a pointer.
4267 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4269 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4271 * gnutls.c (DEF_GNUTLS_FN):
4272 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4274 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4276 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4279 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4281 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4282 New version that can reserve upto 2GB of heap space.
4284 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4286 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4288 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4290 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4291 `gnutls_certificate_set_x509_key_file'.
4293 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4295 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4296 Update dependencies.
4298 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4300 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4301 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4302 Remove unused parameter `fildes'.
4303 * process.c (read_process_output, send_process): Don't pass it.
4305 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4307 Fix previous change: the library cache is defined in w32.c.
4308 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4309 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4311 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4313 Implement dynamic loading of GnuTLS on Windows.
4315 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4316 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4317 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4320 * gnutls.c (Qgnutls_dll): Define.
4321 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4322 (gnutls_*): Declare function pointers.
4323 (init_gnutls_functions): New function to initialize function pointers.
4324 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4325 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4326 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4327 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4328 (emacs_gnutls_write, emacs_gnutls_read)
4329 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4330 (Fgnutls_available_p): New function.
4331 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4332 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4333 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4335 * image.c: Include w32.h.
4336 (Vimage_type_cache): Delete.
4337 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4338 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4339 (w32_delayed_load): Move to w32.c.
4341 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4343 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4344 (w32_delayed_load): Move from image.c. When loading a library, record
4345 its filename in the :loaded-from property of the library id.
4346 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4347 Initialize and staticpro them.
4348 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4350 * process.c: Include lisp.h before w32.h, not after.
4351 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4352 instead of gnutls_record_check_pending.
4354 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4356 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4358 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4359 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4362 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4364 * xterm.c (x_set_frame_alpha): Do not set property on anything
4365 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4367 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4369 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4371 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4373 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4374 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4375 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4376 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4377 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4378 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4379 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4380 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4381 (Qgnutls_bootprop_callbacks_verify): Make static.
4383 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4385 * callproc.c: Indentation fixup.
4387 * sysdep.c (wait_for_termination_1): Make static.
4388 (wait_for_termination, interruptible_wait_for_termination):
4389 Move after wait_for_termination_1.
4391 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4393 * sysdep.c (interruptible_wait_for_termination): New function
4394 which is like wait_for_termination, but allows keyboard
4397 * callproc.c (Fcall_process): Add (:file "file") as an option for
4399 (Fcall_process_region): Ditto.
4401 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4403 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4404 rather than `XVECTOR (FOO)->size'.
4406 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4407 inttypes.h, as a gnulib replacement is used if it not available in
4410 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4412 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4413 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4414 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4416 * coding.c (coding_alloc_by_realloc): Error out if destination
4417 will grow beyond MOST_POSITIVE_FIXNUM.
4418 (decode_coding_emacs_mule): Abort if there isn't enough place in
4419 charbuf for the composition carryover bytes. Reserve an extra
4420 space for up to 2 characters produced in a loop.
4421 (decode_coding_iso_2022): Abort if there isn't enough place in
4422 charbuf for the composition carryover bytes.
4424 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4426 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4427 aborting when %lld or %lll format is passed.
4428 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4429 %llo or %llx format is passed. (Bug#8545)
4431 * window.c (window_scroll_line_based): Use a marker instead of
4432 simple variables to record original value of point. (Bug#7952)
4434 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4435 produced by %s or %c overflows available buffer space. (Bug#8545)
4437 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4439 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4440 (SIZE_MAX): Move defn after all includes, as they might #define it.
4442 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4444 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4446 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4448 * keyboard.c (Qdelayed_warnings_hook): Define.
4449 (command_loop_1): Run `delayed-warnings-hook'
4450 if Vdelayed_warnings_list is non-nil.
4451 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4452 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4454 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4456 * doprnt.c (doprnt): Don't return value smaller than the buffer
4457 size if the message was truncated. (Bug#8545).
4459 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4461 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4462 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4464 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4466 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4468 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4470 * makefile.w32-in: Update dependencies.
4472 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4474 Improve `doprnt' and its usage. (Bug#8545)
4475 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4476 `format_end'. Remove support for %l as a conversion specifier.
4477 Don't use xrealloc. Improve diagnostics when the %l size modifier
4478 is used. Update the commentary.
4480 * eval.c (verror): Simplify calculation of size_t.
4482 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4485 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4487 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4490 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4492 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4493 This makes this file independent of the recent pseudovector change.
4495 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4497 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4499 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4500 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4501 Remove unused local.
4502 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4504 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4505 GCC 4.6.0 optimizes based on type-based alias analysis.
4506 For example, if b is of type struct buffer * and v of type struct
4507 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4508 != &v->size, and therefore "v->size = 1; b->size = 2; return
4509 v->size;" must therefore return 1. This assumption is incorrect
4510 for Emacs, since it type-puns struct Lisp_Vector * with many other
4511 types. To fix this problem, this patch adds a new type struct
4512 vectorlike_header that documents the constraints on layout of vectors
4513 and pseudovectors, and helps optimizing compilers not get fooled
4514 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4515 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4516 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4518 (XSETPVECTYPE): Rewrite in terms of new macro.
4519 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4520 This is a bit clearer, and further avoids the possibility of
4521 undesirable aliasing.
4522 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4523 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4524 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4525 since Lisp_Subr is a special case (no "next" field).
4526 (ASIZE): Now uses header.size rather than size.
4527 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4528 to avoid the hassle of writing XVECTOR (foo)->header.size.
4529 (struct vectorlike_header): New type.
4530 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4531 object, to help avoid aliasing.
4532 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4533 (SUBRP): Likewise, since Lisp_Subr is a special case.
4534 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4535 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4536 (struct Lisp_Hash_Table): Combine first two members into a single
4537 struct vectorlike_header member. All uses of "size" and "next" members
4538 changed to be "header.size" and "header.next".
4539 * buffer.h (struct buffer): Likewise.
4540 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4541 * frame.h (struct frame): Likewise.
4542 * process.h (struct Lisp_Process): Likewise.
4543 * termhooks.h (struct terminal): Likewise.
4544 * window.c (struct save_window_data, struct saved_window): Likewise.
4545 * window.h (struct window): Likewise.
4546 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4547 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4548 * buffer.c (init_buffer_once): Likewise.
4549 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4551 * process.c (Fformat_network_address): Use local var for size,
4554 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4556 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4557 * data.c (atof): Remove decl; no longer used or needed.
4558 (digit_to_number): Move to lread.c.
4559 (Fstring_to_number): Use new string_to_number function, to be
4560 consistent with how the Lisp reader treats infinities and NaNs.
4561 Do not assume that floating-point numbers represent EMACS_INT
4562 without losing information; this is not true on most 64-bit hosts.
4563 Avoid double-rounding errors, by insisting on integers when
4564 parsing non-base-10 numbers, as the documentation specifies.
4565 * lisp.h (string_to_number): New decl, replacing ...
4566 (isfloat_string): Remove.
4567 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4568 (read1): Do not accept +. and -. as integers; this
4569 appears to have been a coding error. Similarly, do not accept
4570 strings like +-1e0 as floating point numbers. Do not report
4571 overflow for integer overflows unless the base is not 10 which
4572 means we have no simple and reliable way to continue.
4573 Break out the floating-point parsing into a new
4574 function string_to_number, so that Fstring_to_number parses
4575 floating point numbers consistently with the Lisp reader.
4576 (digit_to_number): Move here from data.c. Make it static inline.
4577 (E_CHAR, EXP_INT): Remove, replacing with ...
4578 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4579 (string_to_number): New function, replacing isfloat_string.
4580 This function checks for valid syntax and produces the resulting
4581 Lisp float number too. Rework it so that string-to-number
4582 no longer mishandles examples like "1.0e+". Use strtoumax,
4583 so that overflow for non-base-10 numbers is reported only when
4584 there's no portable and simple way to convert to floating point.
4586 * textprop.c (set_text_properties_1): Rewrite for clarity,
4587 and to avoid GCC warning about integer overflow.
4589 * intervals.h (struct interval): Use EMACS_INT for members
4590 where EMACS_UINT might cause problems. See
4591 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4592 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4593 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4595 (offset_intervals): Tell GCC not to worry about length overflow
4596 when negating a negative length.
4598 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4599 (overrun_check_free): Likewise.
4601 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4602 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4605 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4606 (gnutls_make_error): Rename local to avoid shadowing.
4607 (gnutls_emacs_global_deinit): ifdef out; not used.
4608 (Fgnutls_boot): Use const for pointer to readonly storage.
4609 Comment out unused local. Fix pointer signedness problems.
4611 * lread.c (openp): Don't stuff size_t into an 'int'.
4612 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4613 about possible signed overflow.
4615 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4616 (GDK_KEY_g): Don't define if already defined.
4617 (xg_prepare_tooltip): Avoid pointer signedness problem.
4618 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4620 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4621 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4623 * xfns.c (Fx_window_property): Simplify a bit,
4624 to make a bit faster and to avoid GCC 4.6.0 warning.
4625 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4627 * fns.c (internal_equal): Don't assume size_t fits in int.
4629 * alloc.c (compact_small_strings): Tighten assertion a little.
4631 Replace pEd with more-general pI, and fix some printf arg casts.
4632 * lisp.h (pI): New macro, generalizing old pEd macro to other
4633 conversion specifiers. For example, use "...%"pI"d..." rather
4634 than "...%"pEd"...".
4635 (pEd): Remove. All uses replaced with similar uses of pI.
4636 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4637 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4638 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4639 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4640 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4641 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4642 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4644 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4645 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4646 * print.c (safe_debug_print, print_object): Likewise.
4647 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4649 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4650 avoiding the 0 flag, which is not portable.
4651 * process.c (Fmake_network_process): Use pI to avoid cast.
4652 * region-cache.c (pp_cache): Likewise.
4653 * xdisp.c (decode_mode_spec): Likewise.
4654 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4655 behavior on 64-bit hosts with printf arg.
4656 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4657 (x_stop_queuing_selection_requests): Likewise.
4658 (x_get_window_property): Don't truncate byte count to an 'int'
4661 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4662 here, since it parses constructs like leading '-' and spaces,
4663 which are not wanted; and it overflows with large numbers.
4664 Instead, simply match F[0-9]+, which is what is wanted anyway.
4666 * alloc.c: Remove unportable assumptions about struct layout.
4667 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4668 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4669 (allocate_vectorlike, make_pure_vector): Use the new macros,
4670 plus offsetof, to remove unportable assumptions about struct layout.
4671 These assumptions hold on all porting targets that I know of, but
4672 they are not guaranteed, they're easy to remove, and removing them
4673 makes further changes easier.
4675 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4676 This doesn't fix a bug but makes the code clearer.
4677 (string_overrun_cookie): Now const. Use initializers that
4678 don't formally overflow signed char, to avoid warnings.
4679 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4680 can cause Emacs to crash when string overrun checking is enabled.
4681 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4682 multiple of sizeof (EMACS_INT); it need not be, if
4683 alignof(EMACS_INT) < sizeof (EMACS_INT).
4684 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4686 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4688 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4690 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4692 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4693 supposed to be handshaking. (Bug#8556)
4694 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4696 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4698 * lisp.h (Qdebug): List symbol.
4699 * eval.c (Qdebug): Restore global linkage.
4700 * keyboard.c (debug-on-event): New variable.
4701 (handle_user_signal): Break into debugger when debug-on-event
4702 matches the current signal symbol.
4704 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4706 * alloc.c (check_sblock, check_string_bytes)
4707 (check_string_free_list): Convert to standard C.
4709 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4711 * w32.c (emacs_gnutls_push): Fix typo.
4713 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4715 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4716 "cast to pointer from integer of different size".
4718 Improve doprnt and its use in verror. (Bug#8545)
4719 * doprnt.c (doprnt): Document the set of format control sequences
4720 supported by the function. Use SAFE_ALLOCA instead of always
4723 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4724 is one byte too soon. Don't use xrealloc; instead xfree and
4727 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4729 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4732 * gnutls.c: Renamed global_initialized to
4733 gnutls_global_initialized. Added internals for the
4734 :verify-hostname-error, :verify-error, and :verify-flags
4735 parameters of `gnutls-boot' and documented those parameters in the
4736 docstring. Start callback support.
4737 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4738 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4739 on error. Return error code.
4740 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4741 (emacs_gnutls_read): Likewise.
4742 (Fgnutls_boot): Return handshake error code.
4743 (emacs_gnutls_handle_error): New function.
4744 (wsaerror_to_errno): Likewise.
4746 * w32.h (emacs_gnutls_pull): Add prototype.
4747 (emacs_gnutls_push): Likewise.
4749 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4750 (emacs_gnutls_push): Likewise.
4752 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4754 * process.c (wait_reading_process_output): Check if GnuTLS
4755 buffered some data internally if no FDs are set for TLS
4758 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4759 (LIBS): Link to USER_LIBS.
4760 ($(BLD)/gnutls.$(0)): New target.
4762 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4764 * xdisp.c (handle_single_display_spec): Rename the
4765 display_replaced_before_p argument into display_replaced_p, to
4766 make it consistent with the commentary. Fix typos in the
4769 * textprop.c (syms_of_textprop): Remove dead code.
4770 (copy_text_properties): Delete obsolete commentary about an
4771 interface that was deleted long ago. Fix typos in the description
4774 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4775 to changes in oldXMenu/XMenu.h from 2011-04-16.
4776 <menu_help_message, prev_menu_help_message>: Constify.
4777 (IT_menu_make_room): menu->help_text is now `const char **';
4780 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4781 to changes in oldXMenu/XMenu.h from 2011-04-16.
4782 (struct XMenu): Declare `help_text' `const char **'.
4784 * xfaces.c <Qunspecified>: Make extern again.
4786 * syntax.c: Include sys/types.h before including regex.h, as
4789 * doc.c (get_doc_string): Improve the format passed to `error'.
4791 * doprnt.c (doprnt): Improve commentary.
4793 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4795 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4798 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4799 changes in globals.h immediately force recompilation.
4800 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4801 $(CURDIR)/s/ms-w32.h.
4802 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4804 * character.c (Fchar_direction): Function deleted.
4805 (syms_of_character): Don't defsubr it.
4806 <char-direction-table>: Deleted.
4808 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4810 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4811 * doprnt.c: Include limits.h.
4812 (SIZE_MAX): New macro.
4813 (doprnt): Return a size_t value. 2nd arg is now size_t.
4814 Many local variables are now size_t instead of int or unsigned.
4815 Improve overflow protection. Support `l' modifier for integer
4816 conversions. Support %l conversion. Don't assume an EMACS_INT
4817 argument for integer conversions and for %c.
4819 * lisp.h (doprnt): Restore prototype.
4821 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4824 * Makefile.in (base_obj): Add back doprnt.o.
4826 * deps.mk (doprnt.o): Add back prerequisites.
4827 (callint.o): Depend on character.h.
4829 * eval.c (internal_lisp_condition_case): Include the handler
4830 representation in the error message.
4831 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4832 when breaking from the loop.
4834 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4836 * callint.c (Fcall_interactively): When displaying error message
4837 about invalid control letter, pass the character's codepoint, not
4838 a pointer to its multibyte form. Improve display of the character
4839 in octal and display also its hex code.
4841 * character.c (char_string): Use %x to display the (unsigned)
4842 codepoint of an invalid character, to avoid displaying a bogus
4845 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4846 `error', not SYMBOL_NAME itself.
4848 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4849 character arguments to `error'.
4851 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4852 to `error' in error message about FINAL_CHAR argument. Make sure
4853 FINAL_CHAR is a character, and use %c when it is passed as
4854 argument to `error'.
4856 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4858 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4860 * w32.c: Include <time.h>.
4861 (sys_localtime): New function.
4863 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4865 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4867 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4869 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4871 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4874 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4876 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4877 gl_state.e_property when gl_state.object is Qt.
4879 * insdel.c (make_gap_larger): Remove limitation of buffer size
4882 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4884 * xdisp.c (lookup_glyphless_char_display)
4885 (produce_glyphless_glyph): Handle cons cell entry in
4886 glyphless-char-display.
4887 (Vglyphless_char_display): Document it.
4889 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4890 glyphless-char-display.
4892 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4894 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4896 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4898 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4899 definition for no-X builds.
4901 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4903 Static checks with GCC 4.6.0 and non-default toolkits.
4905 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4907 * process.c (keyboard_bit_set): Define only if SIGIO.
4908 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4909 (send_process): Repair possible setjmp clobbering.
4911 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4913 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4915 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4917 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4918 Define only if needed.
4920 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4921 by pacifying GCC about it. Maybe it's time to retire it?
4922 * xfaces.c (USG, __TIMEVAL__): Likewise.
4924 * dispextern.h (struct redisplay_interface): Rename param
4926 * termhooks.h (struct terminal): Likewise.
4927 * xterm.c (xembed_send_message): Likewise.
4929 * insdel.c (make_gap_smaller): Define only if
4930 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4932 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4935 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4936 so that we aren't warned about unused symbols.
4938 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4940 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4942 * xfns.c (x_real_positions): Mark locals as initialized.
4944 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4946 * xterm.c: Fix problems found by static analysis with other toolkits.
4947 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4948 (x_dispatch_event): Declare static if USE_GTK, and
4949 define if USE_GTK || USE_X_TOOLKIT.
4950 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4951 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4952 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4953 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4955 * xmenu.c (menu_help_callback): Pointer type fixes.
4956 Use const pointers when pointing at readonly data. Avoid pointer
4958 (FALSE): Remove unused macro.
4959 (update_frame_menubar): Remove unused decl.
4961 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4963 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4964 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4965 (single_menu_item): Rename local to avoid shadowing.
4967 * keyboard.c (make_lispy_event): Remove unused local var.
4969 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4970 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4972 * bitmaps: Change bitmaps from unsigned char back to the X11
4973 compatible char. Avoid the old compiler warnings about
4974 out-of-range initializers by using, for example, '\xab' rather
4977 * xgselect.c (xgselect_initialize): Check vs interface
4978 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4980 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4982 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4983 to read-only memory.
4985 * fns.c (vector): Remove; this old hack is no longer needed.
4987 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4989 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4991 * xrdb.c (x_load_resources): Omit unused local.
4993 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4994 (x_window): Rename locals to avoid shadowing.
4995 (USG): Use the kludged USG macro, to pacify gcc.
4997 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4998 (x_term_init): Remove local to avoid shadowing.
5000 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5002 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5003 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5005 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5007 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5009 Fix regex.c, syntax.c and friends for buffers > 2GB.
5010 * syntax.h (struct gl_state_s): Declare character position members
5013 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5015 * textprop.c (verify_interval_modification, interval_of):
5016 Declare arguments EMACS_INT.
5018 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5021 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5023 * indent.c (Fvertical_motion): Local variable it_start is now
5026 * regex.c (re_match, re_match_2, re_match_2_internal)
5027 (bcmp_translate, regcomp, regexec, print_double_string)
5028 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5029 (re_compile_pattern, re_exec): Declare arguments and local
5030 variables `size_t' and `ssize_t' and return values `regoff_t', as
5032 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5033 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5034 <compile_stack_type>: `size' and `avail' are now `size_t'.
5036 * regex.h <regoff_t>: Use ssize_t, not int.
5037 (re_search, re_search_2, re_match, re_match_2): Arguments that
5038 specify buffer/string position and length are now ssize_t and
5039 size_t. Return type is regoff_t.
5041 2011-04-16 Ben Key <bkey76@gmail.com>
5043 * nsfont.m: Fixed bugs in ns_get_family and
5044 ns_descriptor_to_entity that were caused by using free to
5045 deallocate memory blocks that were allocated by xmalloc (via
5046 xstrdup). This caused Emacs to crash when compiled with
5047 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5048 --enable-checking=xmallocoverrun). xfree is now used to
5049 deallocate these memory blocks.
5051 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5053 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5055 emacs_write: Accept and return EMACS_INT for sizes.
5056 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5058 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5059 Accept and return EMACS_INT.
5060 (emacs_gnutls_write): Return the number of bytes written on
5062 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5063 (emacs_read, emacs_write): Remove check for negative size, as the
5064 Emacs source code has been audited now.
5065 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5066 (emacs_read, emacs_write): Use it.
5067 * process.c (send_process): Adjust to the new signatures of
5068 emacs_write and emacs_gnutls_write. Do not attempt to store
5069 a byte offset into an 'int'; it might overflow.
5070 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5072 * sound.c: Don't assume sizes fit in 'int'.
5073 (struct sound_device.period_size, alsa_period_size):
5074 Return EMACS_INT, not int.
5075 (struct sound_device.write, vox_write, alsa_write):
5076 Accept EMACS_INT, not int.
5077 (wav_play, au_play): Use EMACS_INT to store sizes and to
5078 record read return values.
5080 2011-04-15 Ben Key <bkey76@gmail.com>
5082 * keyboard.c (Qundefined): Don't declare static since it is used
5084 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5085 static since they are used in nsfont.m.
5087 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5089 * process.c (Qprocessp): Don't declare static.
5090 * lisp.h (Qprocessp): Declare again.
5092 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5094 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5096 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5098 Improve C-level modularity by making more things 'static'.
5100 Don't publish debugger-only interfaces to other modules.
5101 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5102 (verify_bytepos, count_markers): Move decls to the only modules
5104 * region-cache.h (pp_cache): Likewise.
5105 * window.h (check_all_windows): Likewise.
5106 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5108 * sysdep.c (croak): Now static, if
5109 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5110 * syssignal.h (croak): Declare only if not static.
5112 * alloc.c (refill_memory_reserve): Now static if
5113 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5114 * lisp.h (refill_memory_reserve): Declare only if not static.
5116 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5117 Define only if USE_LUCID.
5119 * xrdb.c (x_customization_string, x_rm_string): Now static.
5121 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5122 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5124 * xdisp.c (draw_row_with_mouse_face): Now static.
5125 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5127 * window.h (check_all_windows): Mark externally visible.
5129 * window.c (window_deletion_count): Now static.
5131 * undo.c: Make symbols static if they're not exported.
5132 (last_undo_buffer, last_boundary_position, pending_boundary):
5135 * textprop.c (interval_insert_behind_hooks): Now static.
5136 (interval_insert_in_front_hooks): Likewise.
5138 * term.c: Make symbols static if they're not exported.
5139 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5140 (max_frame_lines, tty_set_terminal_modes):
5141 (tty_reset_terminal_modes, tty_turn_off_highlight):
5142 (get_tty_terminal): Now static.
5143 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5144 * termhooks.h (term_mouse_moveto): Do not declare if
5146 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5147 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5149 * sysdep.c: Make symbols static if they're not exported.
5150 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5152 (sigprocmask_set, full_mask): Remove; unused.
5153 (wait_debugging): Mark as visible.
5154 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5155 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5157 * syntax.c (syntax_temp): Define only if !__GNUC__.
5159 * sound.c (current_sound_device, current_sound): Now static.
5161 * search.c (searchbufs, searchbuf_head): Now static.
5163 * scroll.c (scroll_cost): Remove; unused.
5164 * dispextern.h (scroll_cost): Remove decl.
5166 * region-cache.h (pp_cache): Mark as externally visible.
5168 * process.c: Make symbols static if they're not exported.
5169 (process_tick, update_tick, create_process, chan_process):
5170 (Vprocess_alist, proc_buffered_char, datagram_access):
5171 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5172 (deactivate_process): Mark defn as static, as well as decl.
5173 * lisp.h (create_process): Remove decl.
5174 * process.h (chan_process, Vprocess_alist): Remove decls.
5176 * print.c: Make symbols static if they're not exported.
5177 (print_depth, new_backquote_output, being_printed, print_buffer):
5178 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5179 (print_interval, print_number_index, initial_stderr_stream):
5181 * lisp.h (Fprinc): Remove decl.
5182 (debug_output_compilation_hack): Mark as externally visible.
5184 * sysdep.c (croak): Move decl from here to syssignal.h.
5185 * syssignal.h (croak): Put it here, so the API can be checked when
5186 'croak' is called from dissociate_if_controlling_tty.
5188 * minibuf.c: Make symbols static if they're not exported.
5189 (minibuf_save_list, choose_minibuf_frame): Now static.
5190 * lisp.h (choose_minibuf_frame): Remove decl.
5192 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5194 * lread.c: Make symbols static if they're not exported.
5195 (read_objects, initial_obarray, oblookup_last_bucket_number):
5197 (make_symbol): Remove; unused.
5198 * lisp.h (initial_obarray, make_symbol): Remove decls.
5200 * keyboard.c: Make symbols static if they're not exported.
5201 (single_kboard, recent_keys_index, total_keys, recent_keys):
5202 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5203 (this_single_command_key_start, echoing, last_auto_save):
5204 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5205 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5206 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5207 (Vlispy_mouse_stem, double_click_count):
5209 (force_auto_save_soon): Define only if SIGDANGER.
5210 (ignore_mouse_drag_p): Now static if
5211 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5212 (print_help): Remove; unused.
5213 (stop_character, last_timer_event): Mark as externally visible.
5214 * keyboard.h (ignore_mouse_drag_p): Declare only if
5215 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5216 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5217 * lisp.h (echoing): Remove decl.
5218 (force_auto_save_soon): Declare only if SIGDANGER.
5219 * xdisp.c (redisplay_window): Simplify code, to make it more
5220 obvious that ignore_mouse_drag_p is not accessed if !defined
5221 USE_GTK && !defined HAVE_NS.
5223 * intervals.c: Make symbols static if they're not exported.
5224 (merge_properties_sticky, merge_interval_right, delete_interval):
5226 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5228 * insdel.c: Make symbols static if they're not exported.
5229 However, leave prepare_to_modify_buffer alone. It's never
5230 called from outside this function, but that appears to be a bug.
5231 (combine_after_change_list, combine_after_change_buffer):
5232 (adjust_after_replace, signal_before_change): Now static.
5233 (adjust_after_replace_noundo): Remove; unused.
5234 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5235 (signal_before_change): Remove decls.
5237 * indent.c (val_compute_motion, val_vmotion): Now static.
5239 * image.c: Make symbols static if they're not exported.
5240 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5242 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5243 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5245 * fringe.c (standard_bitmaps): Now static.
5246 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5248 * frame.c: Make symbols static if they're not exported.
5249 (x_report_frame_params, make_terminal_frame): Now static.
5250 (get_frame_param): Now static, unless HAVE_NS.
5251 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5252 (x_get_resource_string): Remove; not used.
5253 * frame.h (make_terminal_frame, x_report_frame_params):
5254 (x_get_resource_string); Remove decls.
5255 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5256 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5258 * font.c, fontset.c: Make symbols static if they're not exported.
5259 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5260 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5261 * font.c (font_close_object): Now static.
5262 * font.h (font_close_object): Remove.
5263 * fontset.c (FONTSET_OBJLIST): Remove.
5264 (free_realized_fontset) #if-0 the body, which does nothing.
5265 (face_suitable_for_char_p): #if-0, as it's never called.
5266 * fontset.h (face_suitable_for_char_p): Remove decl.
5267 * xfaces.c (face_at_string_position):
5268 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5269 since 0 is always ASCII.
5271 * fns.c (weak_hash_tables): Now static.
5273 * fileio.c: Make symbols static if they're not exported.
5274 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5275 (Vwrite_region_annotation_buffers): Now static.
5277 * eval.c: Make symbols static if they're not exported.
5278 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5279 * lisp.h (backtrace_list): Remove decl.
5281 * emacs.c: Make symbols static if they're not exported.
5282 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5283 (fatal_error_code, fatal_error_signal_hook, standard_args):
5285 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5286 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5287 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5288 * lisp.h (fatal_error_signal_hook): Remove decl.
5289 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5291 * editfns.c: Move a (normally-unused) function to its only use.
5292 * editfns.c, lisp.h (get_operating_system_release): Remove.
5293 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5294 worth the hassle of breaking this out.
5296 * xterm.c: Make symbols static if they're not exported.
5297 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5298 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5299 (x_destroy_window, x_delete_display):
5301 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5302 (x_mouse_leave): Remove; unused.
5303 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5304 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5305 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5307 (x_mouse_leave): Declare only if WINDOWSNT.
5308 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5309 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5312 * ftxfont.c: Make symbols static if they're not exported.
5313 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5315 * font.h (ftxfont_driver): Likewise.
5317 * xfns.c: Make symbols static if they're not exported.
5318 (x_last_font_name, x_display_info_for_name):
5319 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5320 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5321 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5322 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5323 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5324 (last_show_tip_args): Now static.
5325 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5326 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5327 (x_screen_planes): Remove; unused.
5328 * dispextern.h (x_screen_planes): Remove decl.
5330 * dispnew.c: Make symbols static if they're not exported.
5331 * dispextern.h (redraw_garbaged_frames, scrolling):
5332 (increment_row_positions): Remove.
5333 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5334 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5336 (redraw_garbaged_frames): Remove; unused.
5338 * xfaces.c: Make symbols static if they're not exported.
5339 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5341 * xterm.h (defined_color): Remove decls.
5342 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5343 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5344 (menu_face_changed_default, defined_color, free_realized_face):
5345 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5346 (ascii_face_of_lisp_face): Remove; unused.
5348 * xdisp.c: Make symbols static if they're not exported.
5349 * dispextern.h (scratch_glyph_row, window_box_edges):
5350 (glyph_to_pixel_coords, set_cursor_from_row):
5351 (get_next_display_element, set_iterator_to_next):
5352 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5353 (show_mouse_face): Remove decls
5354 * frame.h (message_buf_print): Likewise.
5355 * lisp.h (pop_message, set_message, check_point_in_composition):
5357 * xterm.h (set_vertical_scroll_bar): Likewise.
5358 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5359 (message_buf_print, scratch_glyph_row, displayed_buffer):
5360 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5361 (get_next_display_element, show_mouse_face, window_box_edges):
5362 (frame_to_window_pixel_xy, check_point_in_composition):
5363 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5364 (glyph_to_pixel_coords): Remove; unused.
5366 * dired.c (file_name_completion): Now static.
5368 * dbusbind.c (xd_in_read_queued_messages): Now static.
5370 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5371 * data.c (circular_list_error): Remove.
5373 * commands.h (last_point_position, last_point_position_buffer):
5374 (last_point_position_window): Remove decls.
5375 * keyboard.c: Make these variables static.
5377 * coding.h (coding, code_convert_region, encode_coding_gap):
5379 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5380 (iso_code_class, detect_coding, code_convert_region): Now static.
5381 (encode_coding_gap): Remove; unused.
5383 * chartab.c (chartab_chars, chartab_bits): Now static.
5385 * charset.h (charset_iso_8859_1): Remove decl.
5386 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5389 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5390 * ccl.c (Vccl_program_table): Now static.
5391 (check_ccl_update): Remove; unused.
5393 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5394 * category.h: ... from here.
5395 * category.c (check_category_table, set_category_set): Now static.
5397 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5398 * lisp.h: Remove these decls.
5400 * buffer.c (buffer_count): Remove unused var.
5402 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5403 so that it's not optimized away.
5404 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5405 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5406 exported only to the debugger.
5408 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5409 * atimer.h (run_all_atimers): Remove; not exported.
5411 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5412 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5413 was inaccessible from Lisp.
5414 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5415 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5417 alloc.c: Import and export fewer symbols, and remove unused items.
5418 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5420 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5421 it's not optimized away by whole-program optimization.
5422 (message_enable_multibyte, free_misc): Remove.
5423 (catchlist, handlerlist, mark_backtrace):
5424 Declare only if BYTE_MARK_STACK.
5425 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5426 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5427 (message_enable_multibyte): Remove decl.
5428 (free_misc, interval_free_list, float_block, float_block_index):
5429 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5430 (cons_free_list, last_marked_index):
5432 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5433 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5434 (mark_backtrace): Define only if BYTE_MARK_STACK.
5435 * xdisp.c (message_enable_multibyte): Now static.
5437 Declare Lisp_Object Q* variables to be 'static' if not exported.
5438 This makes it easier for human readers (and static analyzers)
5439 to see whether these variables are used from other modules.
5440 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5441 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5442 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5443 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5444 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5445 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5446 * xmenu.c, xselect.c:
5447 Declare Q* vars static if they are not used in other modules.
5448 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5449 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5450 Remove decls of unexported vars.
5451 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5453 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5455 Make Emacs functions such as Fatom 'static' by default.
5456 This makes it easier for human readers (and static analyzers)
5457 to see whether these functions can be called from other modules.
5458 DEFUN now defines a static function. To make the function external
5459 so that it can be used in other C modules, use the new macro DEFUE.
5460 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5461 (Finit_image_library):
5462 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5463 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5464 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5465 Remove decls, since these functions are now static.
5466 (Funintern, Fget_internal_run_time): New decls, since these functions
5467 were already external.
5469 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5470 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5471 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5472 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5473 * keyboard.c, keymap.c, lread.c:
5474 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5475 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5476 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5477 Mark functions with DEFUE instead of DEFUN,
5478 if they are used in other modules.
5479 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5480 decls for now-static functions.
5481 * buffer.h (Fdelete_overlay): Remove decl.
5482 * callproc.c (Fgetenv_internal): Mark as internal.
5483 * composite.c (Fremove_list_of_text_properties): Remove decl.
5484 (Fcomposition_get_gstring): New forward static decl.
5485 * composite.h (Fcomposite_get_gstring): Remove decl.
5486 * dired.c (Ffile_attributes): New forward static decl.
5487 * doc.c (Fdocumntation_property): New forward static decl.
5488 * eval.c (Ffetch_bytecode): New forward static decl.
5489 (Funintern): Remove extern decl; now in .h file where it belongs.
5490 * fileio.c (Fmake_symbolic_link): New forward static decl.
5491 * image.c (Finit_image_library): New forward static decl.
5492 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5493 * intervals.h (Fprevious_property_change):
5494 (Fremove_list_of_text_properties): Remove decls.
5495 * keyboard.c (Fthis_command_keys): Remove decl.
5496 (Fcommand_execute): New forward static decl.
5497 * keymap.c (Flookup_key): New forward static decl.
5498 (Fcopy_keymap): Now static.
5499 * keymap.h (Flookup_key): Remove decl.
5500 * process.c (Fget_process): New forward static decl.
5501 (Fprocess_datagram_address): Mark as internal.
5502 * syntax.c (Fsyntax_table_p): New forward static decl.
5503 (skip_chars): Remove duplicate decl.
5504 * textprop.c (Fprevious_property_change): New forward static decl.
5505 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5507 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5508 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5510 * editfns.c (Fformat): Remove unreachable code.
5512 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5514 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5517 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5519 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5520 when at ZV. (Bug#8487)
5522 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5524 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5526 * keyboard.c (parse_tool_bar_item): Likewise.
5527 * sound.c (sound_cleanup, alsa_close): Likewise.
5528 * termcap.c (tgetent): Likewise.
5529 * xfns.c (x_default_font_parameter): Likewise.
5530 * xsettings.c (read_and_apply_settings): Likewise.
5532 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5533 (overrun_check_free): Protoize.
5535 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5537 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5538 since callers should never pass a negative size.
5539 Change the signature to match that of plain 'read' and 'write'; see
5540 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5541 * lisp.h: Update prototypes of emacs_write and emacs_read.
5543 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5545 * xdisp.c (redisplay_window): Don't try to determine the character
5546 position of the scroll margin if the window start point w->startp
5547 is outside the buffer's accessible region. (Bug#8468)
5549 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5551 Fix write-region and its subroutines for buffers > 2GB.
5552 * fileio.c (a_write, e_write): Modify declaration of arguments and
5553 local variables to support buffers larger than 2GB.
5554 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5556 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5557 argument, local variables, and return value.
5559 * lisp.h: Update prototypes of emacs_write and emacs_read.
5561 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5563 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5565 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5567 Fix more problems found by GCC 4.6.0's static checks.
5569 * xdisp.c (vmessage): Use a better test for character truncation.
5571 * charset.c (load_charset_map): <, not <=, for optimization,
5572 and to avoid potential problems with integer overflow.
5573 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5574 * casetab.c (set_identity, shuffle): Likewise.
5575 * editfns.c (Fformat): Likewise.
5576 * syntax.c (skip_chars): Likewise.
5578 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5579 This also lets GCC 4.6.0 generate slightly better loop code.
5581 * callint.c (Fcall_interactively): <, not <=, for optimization.
5582 (Fcall_interactively): Count the number of arguments produced,
5583 not the number of arguments given. This is simpler and lets GCC
5584 4.6.0 generate slightly better code.
5586 * ftfont.c: Distingish more carefully between FcChar8 and char.
5587 The previous code passed unsigned char * to a functions like
5588 strlen and xstrcasecmp that expect char *, which does not
5589 conform to the C standard.
5590 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5591 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5592 char * when the C standard requires it.
5594 * keyboard.c (read_char): Remove unused var.
5596 * eval.c: Port to Windows vsnprintf (Bug#8435).
5598 (SIZE_MAX): Define if the headers do not.
5599 (verror): Do not give up if vsnprintf returns a negative count.
5600 Instead, grow the buffer. This ports to Windows vsnprintf, which
5601 does not conform to C99. Problem reported by Eli Zaretskii.
5602 Also, simplify the allocation scheme, by avoiding the need for
5603 calling realloc, and removing the ALLOCATED variable.
5605 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5607 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5608 But keep the doprint source code for now, as we might revamp it
5609 and use it again (Bug#8435).
5610 * lisp.h (doprnt): Remove.
5611 * Makefile.in (base_obj): Remove doprnt.o.
5612 * deps.mk (doprnt.o): Remove.
5614 error: Print 32- and 64-bit integers portably (Bug#8435).
5615 Without this change, on typical 64-bit hosts error ("...%d...", N)
5616 was used to print both 32- and 64-bit integers N, which relied on
5618 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5620 * lisp.h (error, verror): Mark as printf-like functions.
5621 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5622 Report overflow in size calculations when allocating printf buffer.
5623 Do not truncate output string at its first null byte.
5624 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5625 Truncate the output at a character boundary, since vsnprintf does not
5627 * charset.c (check_iso_charset_parameter): Convert internal
5628 character to string before calling 'error', since %c now has the
5630 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5631 overflow when computing char to be passed to 'error'. Do not
5632 pass Lisp_Object to 'error'; pass the integer instead.
5633 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5634 formatted with plain %d.
5636 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5638 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5640 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5642 * xterm.c (x_catch_errors): Remove duplicate declaration.
5644 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5646 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5648 2011-04-10 Jim Meyering <meyering@redhat.com>
5650 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5651 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5652 return ssize_t not "int", and use size_t as the buffer length.
5653 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5654 * gnutls.h: Update declarations.
5655 * process.c (read_process_output): Use ssize_t, to match.
5656 (send_process): Likewise.
5658 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5660 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5662 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5664 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5665 Use unsigned char, to match FcChar8 type definition.
5667 * xterm.c (handle_one_xevent):
5668 * xmenu.c (create_and_show_popup_menu):
5669 * xselect.c (x_decline_selection_request)
5670 (x_reply_selection_request): Avoid type-punned deref of X events.
5672 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5674 Fix some uses of `int' instead of EMACS_INT.
5675 * search.c (string_match_1, fast_string_match)
5676 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5677 (scan_buffer, find_next_newline_no_quit)
5678 (find_before_next_newline, search_command, Freplace_match)
5679 (Fmatch_data): Make some `int' variables be EMACS_INT.
5681 * xdisp.c (display_count_lines): 3rd argument and return value now
5682 EMACS_INT. All callers changed.
5683 (pint2hrstr): Last argument is now EMACS_INT.
5685 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5686 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5687 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5688 (decode_coding_utf_16, decode_coding_emacs_mule)
5689 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5690 (decode_coding_ccl, decode_coding_charset)
5691 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5692 (decode_coding_iso_2022, decode_coding_emacs_mule)
5693 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5694 <char_offset, last_offset>: Declare EMACS_INT.
5695 (encode_coding_utf_8, encode_coding_utf_16)
5696 (encode_coding_emacs_mule, encode_invocation_designation)
5697 (encode_designation_at_bol, encode_coding_iso_2022)
5698 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5699 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5701 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5702 (encode_invocation_designation): Last argument P_NCHARS is now
5704 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5705 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5707 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5710 * ccl.c (Fccl_execute_on_string): Declare some variables
5713 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5715 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5717 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5719 * process.c (Fformat_network_address): Doc fix.
5721 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5723 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5725 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5727 * keyboard.c (read_char): Call Lisp function help-form-show,
5728 instead of using internal_with_output_to_temp_buffer.
5729 (Qhelp_form_show): New var.
5730 (syms_of_keyboard): Use DEFSYM macro.
5732 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5734 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5736 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5738 * process.c (Flist_processes): Remove to Lisp.
5739 (list_processes_1): Delete.
5741 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5743 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5745 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5747 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5749 Fix more problems found by GCC 4.6.0's static checks.
5751 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5753 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5755 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5757 * xdisp.c (vmessage): Mark as a printf-like function.
5759 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5761 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5763 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5764 printf-like functions.
5765 (tiff_load): Add casts to remove these marks before passing them
5766 to system-supplied API.
5768 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5770 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5771 This avoids several warnings with gcc -Wstrict-overflow.
5772 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5773 directly, rather than having caller test rule sign. This avoids
5774 some unnecessary tests.
5775 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5776 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5777 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5779 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5780 (xfont_open): Avoid unnecessary tests.
5782 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5784 * composite.h, composite.c (composition_gstring_put_cache):
5785 Use EMACS_INT, not int, for length.
5787 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5788 breaking out part of COMPOSITION_DECODE_RULE.
5789 (COMPOSITION_DECODE_RULE): Use it.
5790 * composite.c (get_composition_id): Remove unused local vars,
5791 by using the new macro.
5793 * textprop.c (set_text_properties_1): Change while to do-while,
5794 since the condition is always true at first.
5796 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5797 (interval_deletion_adjustment): Return unsigned value.
5800 * process.c (list_processes_1, create_pty, read_process_output):
5801 (exec_sentinel): Remove vars that were set but not used.
5802 (create_pty): Remove unnecessary "volatile"s.
5803 (Fnetwork_interface_info): Avoid possibility of int overflow.
5804 (read_process_output): Do adaptive read buffering even if carryover.
5805 (read_process_output): Simplify nbytes computation if buffered.
5807 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5809 * syntax.c (scan_words): Remove var that was set but not used.
5810 (update_syntax_table): Use unsigned instead of int.
5812 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5813 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5814 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5816 * print.c (print_error_message): Avoid int overflow.
5818 * font.c (font_list_entities): Redo for clarity,
5819 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5821 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5822 (font_score): Avoid potential overflow in diff calculation.
5824 * fns.c (substring_both): Remove var that is set but not used.
5825 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5827 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5829 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5830 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5831 can always succeed if overflow has undefined behavior.
5833 * search.c (boyer_moore, wordify): Remove vars set but not used.
5834 (wordify): Omit three unnecessary tests.
5836 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5837 All callers changed. This avoids the need for an unused var.
5839 * casefiddle.c (casify_region): Remove var that is set but not used.
5841 * dired.c (file_name_completion): Remove var that is set but not used.
5843 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5845 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5846 (Finsert_file_contents): Remove unnecessary code checking fd.
5848 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5849 Check for integer overflow on size calculations.
5851 * buffer.c (Fprevious_overlay_change): Remove var that is set
5854 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5855 Remove vars that are set but not used.
5856 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5857 (timer_check_2): Mark vars as initialized.
5859 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5861 * image.c (lookup_image): Remove var that is set but not used.
5862 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5864 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5865 that are set but not used.
5867 * xfns.c (make_invisible_cursor): Don't return garbage
5868 if XCreateBitmapFromData fails (Bug#8410).
5870 * xselect.c (x_get_local_selection, x_handle_property_notify):
5871 Remove vars that are set but not used.
5873 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5874 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5876 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5877 Remove var that is set but not used.
5878 (scroll_bar_windows_size): Now size_t, not int.
5879 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5882 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5883 (map_tty_color) [!defined MSDOS]: Likewise.
5885 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5887 * coding.c: Remove vars that are set but not used.
5888 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5889 All callers changed.
5890 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5891 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5892 (decode_coding_charset): Remove vars that are set but not used.
5894 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5895 that is set but not used.
5897 * print.c (print_object): Remove var that is set but not used.
5899 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5900 The gnulib version avoids calling malloc in the usual case,
5901 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5902 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5903 * filelock.c (current_lock_owner): Likewise.
5904 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5905 * sysdep.c: Include allocator.h, careadlinkat.h.
5906 (emacs_no_realloc_allocator): New static constant.
5907 (emacs_readlink): New function.
5908 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5909 ../lib/careadlinkat.h.
5911 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5913 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5914 first non-nil return value).
5916 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5918 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5919 if not defined (Bug#8403).
5921 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5923 * xdisp.c (display_count_lines): Remove parameter `start',
5924 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5925 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5926 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5927 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5928 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5929 and thereabouts. All callers changed.
5930 (get_per_char_metric): Remove parameter `f', unused since
5931 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5933 2011-04-02 Jim Meyering <meyering@redhat.com>
5935 do not dereference NULL upon failed strdup
5936 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5937 (ns_get_family): Likewise.
5939 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5941 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5943 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5945 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5948 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5950 Add lexical binding.
5952 * window.c (Ftemp_output_buffer_show): New fun.
5953 (Fsave_window_excursion):
5954 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5956 * lread.c (lisp_file_lexically_bound_p): New function.
5957 (Fload): Bind Qlexical_binding.
5958 (readevalloop): Remove `evalfun' arg.
5959 Bind Qinternal_interpreter_environment.
5960 (Feval_buffer): Bind Qlexical_binding.
5961 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5963 (syms_of_lread): Declare `lexical-binding'.
5965 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5967 * keyboard.c (eval_dyn): New fun.
5968 (menu_item_eval_property): Use it.
5970 * image.c (parse_image_spec): Use Ffunctionp.
5972 * fns.c (concat, mapcar1): Accept byte-code-functions.
5974 * eval.c (Fsetq): Handle lexical vars.
5975 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5976 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5977 (FletX, Flet): Obey lexical binding.
5978 (Fcommandp): Handle closures.
5979 (Feval): New `lexical' arg.
5980 (eval_sub): New function extracted from Feval. Use it almost
5981 everywhere where Feval was used. Look up vars in lexical env.
5983 (Ffunctionp): Move from subr.el.
5984 (Ffuncall): Handle closures.
5985 (apply_lambda): Remove `eval_flags'.
5986 (funcall_lambda): Handle closures and new byte-code-functions.
5987 (Fspecial_variable_p): New function.
5988 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5989 but without exporting it to Lisp.
5991 * doc.c (Fdocumentation, store_function_docstring):
5992 * data.c (Finteractive_form): Handle closures.
5994 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5997 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5999 (exec_byte_code): New function extracted from Fbyte_code to handle new
6000 calling convention for byte-code-functions. Add new byte-codes.
6002 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6004 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6006 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6008 * xdisp.c (redisplay_internal): Fix prototype.
6010 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6012 * xdisp.c (SCROLL_LIMIT): New macro.
6013 (try_scrolling): Use it when setting scroll_limit.
6014 Limit scrolling to 100 screen lines.
6015 (redisplay_window): Even when falling back on "recentering",
6016 position point in the window according to scroll-conservatively,
6017 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6019 (try_scrolling): When point is above the window, allow searching
6020 as far as scroll_max, or one screenful, to compute vertical
6021 distance from PT to the scroll margin position. This prevents
6022 try_scrolling from unnecessarily failing when
6023 scroll-conservatively is set to a value slightly larger than the
6024 window height. Clean up the case of PT below the margin at bottom
6025 of window: scroll_max can no longer be INT_MAX. When aggressive
6026 scrolling is in use, don't let point enter the opposite scroll
6027 margin as result of the scroll.
6028 (syms_of_xdisp) <scroll-conservatively>: Document the
6029 threshold of 100 lines for never-recentering scrolling.
6031 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6033 * dispextern.h (move_it_by_lines):
6034 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6035 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6036 (message_log_check_duplicate): Remove parameters `prev_bol' and
6037 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6038 (redisplay_internal): Remove parameter `preserve_echo_area',
6039 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6041 * indent.c (Fvertical_motion):
6042 * window.c (window_scroll_pixel_based, Frecenter):
6043 Don't pass `need_y_p' to `move_it_by_lines'.
6045 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6047 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6048 steal a few bits to be more compact.
6049 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6050 Remove unneeded casts.
6052 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6054 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6056 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6057 binding" message (bug#7967).
6059 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6061 Fix more problems found by GCC 4.6.0's static checks.
6063 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6064 Remove unused local var.
6066 * editfns.c (Fmessage_box): Remove unused local var.
6068 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6069 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6070 Omit unused local vars.
6071 * window.c (shrink_windows): Omit unused local var.
6072 * menu.c (digest_single_submenu): Omit unused local var.
6073 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6074 Omit unused local var.
6076 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6077 Don't assume string length fits in int.
6078 (keyremap_step, read_key_sequence): Use size_t for sizes.
6079 (read_key_sequence): Don't check last_real_key_start redundantly.
6081 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6082 instead of alloca (Bug#8344).
6084 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6085 (Fbacktrace_frame): Don't assume nframes fits in int.
6087 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6089 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6092 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6094 * cm.c (calccost): Turn while-do into do-while, for clarity.
6096 * keyboard.c (syms_of_keyboard): Use the same style as later
6097 in this function when indexing through an array. This also
6098 works around GCC bug 48267.
6100 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6102 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6104 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6105 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6107 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6108 This avoids undefined behavior on integer overflow, and is a bit
6109 more convenient anyway since it is compared to a size_t variable.
6111 Variadic C functions now count arguments with size_t, not int.
6112 This avoids an unnecessary limitation on 64-bit machines, which
6113 caused (substring ...) to crash on large vectors (Bug#8344).
6114 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6115 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6116 All variadic functions and their callers changed accordingly.
6117 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6118 * data.c (arith_driver, float_arith_driver): Likewise.
6119 * editfns.c (general_insert_function): Likewise.
6120 * eval.c (struct backtrace.nargs, interactive_p)
6121 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6122 (funcall_lambda, mark_backtrace): Likewise.
6123 * fns.c (concat): Likewise.
6124 * frame.c (x_set_frame_parameters): Likewise.
6125 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6126 0 if not found, not -1. All callers changed.
6128 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6129 (stack_copy_size): Now size_t, not int.
6130 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6132 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6134 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6135 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6136 All callers changed.
6138 * lisp.h (multibyte_char_to_unibyte):
6139 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6140 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6141 * character.h (CHAR_TO_BYTE8):
6142 * cmds.c (internal_self_insert):
6143 * editfns.c (general_insert_function):
6144 * keymap.c (push_key_description):
6145 * search.c (Freplace_match):
6146 * xdisp.c (message_dolog, set_message_1): All callers changed.
6148 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6150 * keyboard.c (safe_run_hook_funcall): New function.
6151 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6152 don't set the hook to nil, but remove the offending function instead.
6153 (Qcommand_hook_internal): Remove, unused.
6154 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6155 Vcommand_hook_internal.
6157 * eval.c (enum run_hooks_condition): Remove.
6158 (funcall_nil, funcall_not): New functions.
6159 (run_hook_with_args): Call each function through a `funcall' argument.
6160 Remove `cond' argument, now redundant.
6161 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6162 (Frun_hook_with_args_until_failure): Adjust accordingly.
6163 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6165 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6167 * dispextern.h (string_buffer_position): Remove declaration.
6169 * print.c (strout): Remove parameter `multibyte', unused since
6170 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6172 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6173 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6174 All callers changed.
6176 * w32.c (_wsa_errlist): Use braces for struct initializers.
6178 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6179 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6180 All callers changed.
6181 (string_buffer_position): Likewise. Also, make static (it's never
6182 used outside xdisp.c).
6183 (cursor_row_p): Remove parameter `w', unused since
6184 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6185 (decode_mode_spec): Remove parameter `precision', introduced during
6186 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6187 All callers changed.
6189 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6191 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6193 2011-03-27 Anders Lindgren <andlind@gmail.com>
6195 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6196 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6197 (ns_update_auto_hide_menu_bar): New functions.
6198 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6199 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6200 ns_constrain_all_frames.
6201 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6202 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6204 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6206 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6208 2011-03-27 Glenn Morris <rgm@gnu.org>
6210 * syssignal.h: Replace RETSIGTYPE with void.
6211 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6212 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6213 Replace SIGTYPE with void everywhere.
6214 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6215 * s/template.h (SIGTYPE): Remove commented out definition.
6217 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6219 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6220 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6222 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6224 * w32.c (read_unc_volume): Use parameter `henum', instead of
6225 global variable `wget_enum_handle'.
6227 * keymap.c (describe_vector): Remove parameters `indices' and
6228 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6229 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6231 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6233 * keyboard.c (timer_check): Remove parameter `do_it_now',
6234 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6235 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6236 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6238 * keyboard.c (read_char):
6239 * w32menu.c (w32_menu_display_help):
6240 * xmenu.c (show_help_event, menu_help_callback):
6241 Adjust calls to `show_help_echo'.
6243 * gtkutil.c (xg_maybe_add_timer):
6244 * keyboard.c (readable_events):
6245 * process.c (wait_reading_process_output):
6246 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6248 * insdel.c (adjust_markers_gap_motion):
6249 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6250 (gap_left, gap_right): Don't call it.
6252 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6254 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6255 incurred during fontification.
6257 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6259 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6260 (DEFVAR_PER_BUFFER): Don't pass it.
6262 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6263 (scrolling_window): Don't pass it.
6265 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6267 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6269 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6271 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6272 of variables specific to SELinux and computation of `encoded_absname'.
6274 * image.c (XPutPixel): Remove unused variable `height'.
6276 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6278 * unexw32.c (get_section_info): Remove unused variable `section'.
6280 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6281 (system_process_attributes): Remove unused variable `sess'.
6282 (sys_read): Remove unused variable `err'.
6284 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6285 (w32_wnd_proc): Remove unused variable `isdead'.
6286 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6287 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6288 (x_create_tip_frame): Remove unused variable `tem'.
6290 * w32inevt.c (w32_console_read_socket):
6291 Remove unused variable `no_events'.
6293 * w32term.c (x_draw_composite_glyph_string_foreground):
6294 Remove unused variable `width'.
6296 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6298 * w32term.c (x_set_glyph_string_clipping):
6299 Don't pass uninitialized region to CombineRgn.
6301 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6303 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6304 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6305 (Fx_close_connection): Remove unused variable `i'.
6307 * w32font.c (w32font_draw): Return number of glyphs.
6308 (w32font_open_internal): Remove unused variable `i'.
6309 (w32font_driver): Add missing initializer.
6311 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6312 (fill_in_menu): Remove unused variable `items_added'.
6314 * w32term.c (last_mouse_press_frame): Remove static global variable.
6315 (w32_clip_to_row): Remove unused variable `f'.
6316 (x_delete_terminal): Remove unused variable `i'.
6318 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6319 (NOTHING): Remove unused static global variable.
6320 (uniscribe_check_otf): Remove unused variable `table'.
6321 (uniscribe_font_driver): Add missing initializers.
6323 2011-03-23 Julien Danjou <julien@danjou.info>
6325 * term.c (Fsuspend_tty, Fresume_tty):
6326 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6327 * window.c (temp_output_buffer_show):
6328 * insdel.c (signal_before_change):
6329 * frame.c (Fhandle_switch_frame):
6330 * fileio.c (Fdo_auto_save):
6331 * emacs.c (Fkill_emacs):
6332 * editfns.c (save_excursion_restore):
6333 * cmds.c (internal_self_insert):
6334 * callint.c (Fcall_interactively):
6335 * buffer.c (Fkill_all_local_variables):
6336 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6338 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6339 unconditionnaly since it does the check itself.
6341 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6343 Fix more problems found by GCC 4.5.2's static checks.
6345 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6346 the first time through the loop, since we know p0 < p1 then.
6347 This also avoids a gcc -Wstrict-overflow warning.
6349 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6350 leading to a memory leak, possible in functions like
6351 load_charset_map_from_file that can allocate an unbounded number
6352 of objects (Bug#8318).
6354 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6355 that could (at least in theory) be that large.
6357 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6358 This is less likely to overflow, and avoids undefined behavior if
6359 overflow does occur. All callers changed. Use strtoul to scan
6360 for the unsigned long integer.
6361 (pint2hrstr): Simplify and tune code slightly.
6362 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6364 * scroll.c (do_scrolling): Work around GCC bug 48228.
6365 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6367 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6368 This also avoids a warning with gcc -Wstrict-overflow.
6369 (validate_x_resource_name): Simplify count usage.
6370 This also avoids a warning with gcc -Wstrict-overflow.
6372 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6375 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6377 * process.c (Fmake_network_process): Use socklen_t, not int,
6378 where POSIX says socklen_t is required in portable programs.
6379 This fixes a porting bug on hosts like 64-bit HP-UX, where
6380 socklen_t is wider than int (Bug#8277).
6381 (Fmake_network_process, server_accept_connection):
6382 (wait_reading_process_output, read_process_output):
6385 * process.c: Rename or move locals to avoid shadowing.
6386 (list_processes_1, Fmake_network_process):
6387 (read_process_output_error_handler, exec_sentinel_error_handler):
6388 Rename or move locals.
6389 (Fmake_network_process): Define label "retry_connect" only if needed.
6390 (Fnetwork_interface_info): Fix pointer signedness.
6391 (process_send_signal): Add cast to avoid pointer signedness problem.
6392 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6393 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6395 Make tparam.h and terminfo.c consistent.
6396 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6397 Include tparam.h instead, since it declares them.
6398 * cm.h (PC): Remove extern decl; tparam.h now does this.
6399 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6400 * terminfo.c: Include tparam.h, to check interfaces.
6401 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6402 (tparam): Adjust signature to match interface in tparam.h;
6403 this removes some undefined behavior. Check that outstring and len
6404 are zero, which they always are with Emacs.
6405 * tparam.h (PC, BC, UP): New extern decls.
6407 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6408 (xftfont_open): Rename locals to avoid shadowing.
6410 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6411 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6412 (OTF_TAG_SYM): Omit macro if not needed.
6413 (ftfont_list): Remove unused local.
6414 (get_adstyle_property, ftfont_pattern_entity):
6415 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6416 Rename locals to avoid shadowing.
6418 * xfont.c (xfont_list_family): Mark var as initialized.
6420 * xml.c (make_dom): Now static.
6422 * composite.c (composition_compute_stop_pos): Rename local to
6424 (composition_reseat_it): Remove unused locals.
6425 (find_automatic_composition, composition_adjust_point): Likewise.
6426 (composition_update_it): Mark var as initialized.
6427 (find_automatic_composition): Mark vars as initialized,
6428 with a FIXME (Bug#8290).
6430 character.h: Rename locals to avoid shadowing.
6431 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6432 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6433 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6434 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6437 * textprop.c (property_change_between_p): Remove; unused.
6439 * intervals.c (interval_start_pos): Now static.
6441 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6443 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6444 Rename locals to avoid shadowing.
6446 * sound.c (wav_play, au_play, Fplay_sound_internal):
6447 Fix pointer signedness.
6448 (alsa_choose_format): Remove unused local var.
6449 (wav_play): Initialize a variable to 0, to prevent undefined
6450 behavior (Bug#8278).
6452 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6454 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6456 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6457 clobbering (Bug#8298).
6458 * sysdep.c (sys_subshell): Likewise.
6459 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6461 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6462 This should get cleaned up, so that child_setup has the
6463 same signature on all platforms.
6465 * callproc.c (call_process_cleanup): Now static.
6466 (relocate_fd): Rename locals to avoid shadowing.
6468 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6470 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6471 not to be necessary, and produces flickering.
6473 2011-03-20 Glenn Morris <rgm@gnu.org>
6475 * config.in: Remove file.
6477 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6479 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6480 are now in src/globals.h.
6481 (syms_of_minibuf): Remove spurious & from previous change.
6483 2011-03-20 Leo <sdl.web@gmail.com>
6485 * minibuf.c (completing-read-function): New variable.
6486 (completing-read-default): Rename from completing-read.
6487 (completing-read): Call completing-read-function.
6489 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6491 * xfaces.c (Fx_load_color_file):
6492 Read color file from absolute filename (bug#8250).
6494 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6496 * makefile.w32-in: Update dependencies.
6498 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6500 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6502 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6504 Fix more problems found by GCC 4.5.2's static checks.
6506 * process.c (make_serial_process_unwind, send_process_trap):
6507 (sigchld_handler): Now static.
6509 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6510 That way, the code declares only the vars that it needs.
6511 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6512 * s/cygwin.h (PTY_ITERATION): Likewise.
6513 * s/darwin.h (PTY_ITERATION): Likewise.
6514 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6516 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6517 * process.c (allocate_pty): Don't declare stb unless it's needed.
6519 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6520 (CONSTANTLIM): Remove; unused.
6521 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6522 Define only if needed.
6524 * unexelf.c (unexec): Name an expression,
6525 to avoid gcc -Wbad-function-cast warning.
6526 Use a different way to cause a compilation error if anyone uses
6527 n rather than nn, a way that does not involve shadowing.
6528 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6530 * deps.mk (unexalpha.o): Remove; unused.
6532 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6533 * unexec.h: New file.
6534 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6535 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6537 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6538 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6539 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6540 Change as necessary to match prototype in unexec.h.
6542 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6544 (back_comment, skip_chars): Mark vars as initialized.
6546 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6547 Rename locals to avoid shadowing.
6549 * lread.c (read1): Rewrite so as not to use empty "else".
6550 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6552 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6554 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6555 warning when compiling print.c.
6557 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6558 instead of using an uninitialized var.
6559 (font_sort_entities): Mark var as initialized.
6561 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6563 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6564 pointers to constants.
6565 (font_parse_fcname): Remove unused vars.
6566 (font_delete_unmatched): Now static.
6567 (font_get_spec): Remove; unused.
6568 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6569 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6570 Rename or move locals to avoid shadowing.
6572 * fns.c (require_nesting_list, require_unwind): Now static.
6573 (Ffillarray): Rename locals to avoid shadowing.
6575 * floatfns.c (domain_error2): Define only if needed.
6576 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6578 * alloc.c (mark_backtrace): Move decl from here ...
6579 * lisp.h: ... to here, so that it can be checked.
6581 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6582 (Fdefvar): Rewrite so as not to use empty "else".
6583 (lisp_indirect_variable): Name an expression,
6584 to avoid gcc -Wbad-function-cast warning.
6585 (Fdefvar): Rename locals to avoid shadowing.
6587 * callint.c (quotify_arg, quotify_args): Now static.
6588 (Fcall_interactively): Rename locals to avoid shadowing.
6589 Use const pointer when appropriate.
6591 * lisp.h (get_system_name, get_operating_system_release):
6592 Move decls here, to check interfaces.
6593 * process.c (get_operating_system_release): Move decl to lisp.h.
6594 * xrdb.c (get_system_name): Likewise.
6595 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6596 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6597 some of which prompt warnings from gcc -Wbad-function-cast.
6598 (Fformat_time_string, Fencode_time, Finsert_char):
6599 (Ftranslate_region_internal, Fformat):
6600 Rename or remove local vars to avoid shadowing.
6601 (Ftranslate_region_internal): Mark var as initialized.
6603 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6606 * lisp.h (eassert): Check that the argument compiles, even if
6607 ENABLE_CHECKING is not defined.
6609 * data.c (Findirect_variable): Name an expression, to avoid
6610 gcc -Wbad-function-cast warning.
6611 (default_value, arithcompare, arith_driver, arith_error): Now static.
6612 (store_symval_forwarding): Rename local to avoid shadowing.
6613 (Fmake_variable_buffer_local, Fmake_local_variable):
6614 Mark variables as initialized.
6615 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6617 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6618 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6619 Rename locals to avoid shadowing.
6620 (mark_stack): Move local variables into the #ifdef region where
6622 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6623 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6625 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6626 (GC_STRING_CHARS): Remove; not used.
6627 (Fmemory_limit): Cast sbrk's returned value to char *.
6629 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6630 avoids undefined behavior in theory.
6632 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6634 Use functions, not macros, for up- and down-casing (Bug#8254).
6635 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6636 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6637 to use the following functions instead of these macros.
6638 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6639 EMACS_INT, since callers assume the returned value fits in int.
6640 (upcase1): Likewise, for UPCASE_TABLE.
6641 (uppercasep, lowercasep, upcase): New static inline functions.
6642 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6643 the race-condition problem in the old DOWNCASE.
6645 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6646 Rename locals to avoid shadowing.
6647 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6648 (regex_compile, re_search_2, re_match_2_internal):
6649 Remove unused local vars.
6650 (FREE_VAR): Rewrite so as not to use empty "else",
6651 which gcc can warn about.
6652 (regex_compile, re_match_2_internal): Mark locals as initialized.
6653 (RETALLOC_IF): Define only if needed.
6654 (WORDCHAR_P): Likewise. This one is never needed, but is used
6655 only in a comment talking about a compiler bug, so put inside
6656 the #if 0 of that comment.
6657 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6658 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6661 * search.c (boyer_moore): Rename locals to avoid shadowing.
6662 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6663 (PREV_CHAR_BOUNDARY): Likewise.
6665 * search.c (simple_search): Remove unused var.
6667 * dired.c (compile_pattern): Move decl from here ...
6668 * lisp.h: ... to here, so that it can be checked.
6669 (struct re_registers): New forward decl.
6671 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6673 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6675 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6676 Rename locals to avoid shadowing.
6677 (Fvertical_motion): Mark locals as initialized.
6679 * casefiddle.c (casify_object, casify_region): Now static.
6680 (casify_region): Mark local as initialized.
6682 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6684 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6685 New macros, so that the caller can use some names other than
6686 gcpro1, gcpro2, etc.
6687 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6689 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6690 argument, for consistency with GCPRO2_VAR, etc: it is now the
6691 prefix of the variable, not the variable itself. All uses
6693 * dired.c (directory_files_internal, file_name_completion):
6694 Rename locals to avoid shadowing.
6696 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6697 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6698 dired.c's scmp function, had undefined behavior.
6699 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6700 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6701 * buffer.h: ... to here, because these macros use current_buffer,
6702 and the new implementation with inline functions needs to have
6703 current_buffer in scope now, rather than later when the macros
6705 (downcase, upcase1): New static inline functions.
6706 (DOWNCASE, UPCASE1): Reimplement using these functions.
6707 This avoids undefined behavior in expressions like
6708 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6709 from race conditions in accessing the global variables
6710 case_temp1 and case_temp2.
6711 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6712 * lisp.h (case_temp1, case_temp2): Remove their decls.
6713 * character.h (ASCII_CHAR_P): Move from here ...
6714 * lisp.h: ... to here, so that the inline functions mentioned
6717 * dired.c (directory_files_internal_unwind): Now static.
6719 * fileio.c (file_name_as_directory, directory_file_name):
6720 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6722 (file_name_as_directory): Use const pointers when appropriate.
6723 (Fexpand_file_name): Likewise. In particular, newdir might
6724 point at constant storage, so make it a const pointer.
6725 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6726 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6728 (Fset_file_times, Finsert_file_contents, auto_save_error):
6729 Rename locals to avoid shadowing.
6731 * minibuf.c (choose_minibuf_frame_1): Now static.
6732 (Ftry_completion, Fall_completions): Rename or remove locals
6735 * marker.c (bytepos_to_charpos): Remove; unused.
6737 * lisp.h (verify_bytepos, count_markers): New decls,
6738 so that gcc does not warn that these functions aren't declared.
6740 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6741 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6742 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6743 (copy_text): Remove unused local var.
6745 * filelock.c (within_one_second): Now static.
6746 (lock_file_1): Rename local to avoid shadowing.
6748 * buffer.c (fix_overlays_before): Mark locals as initialized.
6749 (fix_start_end_in_overlays): Likewise. This function should be
6750 simplified by using pointers-to-pointers, but that's a different
6752 (switch_to_buffer_1): Now static.
6753 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6754 (report_overlay_modification): Rename locals to avoid shadowing.
6756 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6757 Fix pointer signedness issue.
6758 (sys_subshell): Mark local as volatile if checking for lint,
6759 to suppress a gcc -Wclobbered warning that does not seem to be right.
6760 (MAXPATHLEN): Define only if needed.
6762 * process.c (serial_open, serial_configure): Move decls from here ...
6763 * systty.h: ... to here, so that they can be checked.
6765 * fns.c (get_random, seed_random): Move extern decls from here ...
6766 * lisp.h: ... to here, so that they can be checked.
6768 * sysdep.c (reset_io): Now static.
6769 (wait_for_termination_signal): Remove; unused.
6771 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6772 (copy_keymap_item, append_key, push_text_char_description):
6774 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6775 (DENSE_TABLE_SIZE): Remove; unused.
6776 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6777 (describe_map_tree):
6778 Rename locals to avoid shadowing.
6780 * keyboard.c: Declare functions static if they are not used elsewhere.
6781 (echo_char, echo_dash, cmd_error, top_level_2):
6782 (poll_for_input, handle_async_input): Now static.
6783 (read_char, kbd_buffer_get_event, make_lispy_position):
6784 (make_lispy_event, make_lispy_movement, apply_modifiers):
6785 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6786 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6787 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6788 (read_key_sequence, read_char): Mark locals as initialized.
6789 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6791 * keyboard.h (make_ctrl_char): New decl.
6792 (mark_kboards): Move decl here ...
6793 * alloc.c (mark_kboards): ... from here.
6795 * lisp.h (force_auto_save_soon): New decl.
6797 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6798 (DEFINE_DUMMY_FUNCTION): New macro.
6799 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6801 (main): Add casts to avoid warnings
6802 if GCC considers string literals to be constants.
6804 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6806 * dbusbind.c: Pointer signedness fixes.
6807 (xd_signature, xd_append_arg, xd_initialize):
6808 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6809 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6810 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6811 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6813 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6814 if GCC considers string literals to be constants.
6815 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6817 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6819 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6820 (print_preprocess, print_object): New macro to fix last change.
6822 * print.c (print_preprocess): Don't forget font objects.
6824 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6826 * emacs.c (USAGE3): Doc fixes.
6828 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6830 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6833 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6835 * lisp.h (VWindow_system, Qfile_name_history):
6836 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6837 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6838 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6840 * w32select.c: Don't #include "keyboard.h".
6841 (run_protected): Add extern declaration for waiting_for_input.
6843 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6844 * w32console.c (detect_input_pending, read_input_pending)
6845 (encode_terminal_code):
6846 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6847 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6848 (w32_system_caret_y, Qfile_name_history):
6849 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6850 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6851 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6852 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6853 * w32proc.c (Qlocal, report_file_error):
6854 * w32term.c (Vwindow_system, updating_frame):
6855 * w32uniscribe.c (initialized, uniscribe_font_driver):
6856 Remove unneeded extern declarations.
6858 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6860 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6862 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6864 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6865 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6866 These macros can no longer be used for assignment.
6868 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6869 Assign struct members directly, instead of using BUF_BEGV etc.
6870 (record_buffer_markers, fetch_buffer_markers): New functions for
6871 recording and fetching special buffer markers.
6872 (set_buffer_internal_1, set_buffer_temp): Use them.
6874 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6876 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6878 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6879 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6881 * xdisp.c (hscroll_window_tree):
6882 (reconsider_clip_changes): Use PT instead of BUF_PT.
6884 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6886 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6887 $(EMACS_ROOT)/lib/intprops.h.
6889 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6891 Fix more problems found by GCC 4.5.2's static checks.
6893 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6894 to unsigned char * to avoid compiler diagnostic.
6895 (xg_free_frame_widgets): Make it clear that a local variable is
6896 needed only if USE_GTK_TOOLTIP.
6897 (gdk_window_get_screen): Make it clear that this macro is needed
6898 only if USE_GTK_TOOLTIP.
6899 (int_gtk_range_get_value): New function, which avoids a diagnostic
6900 from gcc -Wbad-function-cast.
6901 (xg_set_toolkit_scroll_bar_thumb): Use it.
6902 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6903 diagnostic from gcc -Wbad-function-cast.
6904 (get_utf8_string, xg_get_file_with_chooser):
6905 Rename locals to avoid shadowing.
6906 (create_dialog): Move locals to avoid shadowing.
6908 * xgselect.c (xg_select): Remove unused var.
6910 * image.c (four_corners_best): Mark locals as initialized.
6911 (gif_load): Initialize transparent_p to zero (Bug#8238).
6912 Mark another local as initialized.
6913 (my_png_error, my_error_exit): Mark with NO_RETURN.
6915 * image.c (clear_image_cache): Now static.
6916 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6917 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6918 (x_edge_detection): Remove unnecessary cast that
6919 gcc -Wbad-function-cast diagnoses.
6920 (gif_load): Fix pointer signedness.
6921 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6922 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6924 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6926 Improve quality of tests for time stamp overflow.
6927 For example, without this patch (encode-time 0 0 0 1 1
6928 1152921504606846976) returns the obviously-bogus value (-948597
6929 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6930 reports time overflow. See
6931 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6932 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6933 * editfns.c: Include limits.h and intprops.h.
6934 (TIME_T_MIN, TIME_T_MAX): New macros.
6935 (time_overflow): Move earlier, to before first use.
6936 (hi_time, lo_time): New functions, for an accurate test for
6938 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6939 (Fget_internal_run_time): Don't assume time_t fits in int.
6940 (make_time): Use list2 instead of Fcons twice.
6941 (Fdecode_time): More accurate test for out-of-range times.
6942 (check_tm_member): New function.
6943 (Fencode_time): Use it, to test for out-of-range times.
6944 (lisp_time_argument): Don't rely on undefined left-shift and
6945 right-shift behavior when checking for time stamp overflow.
6947 * editfns.c (time_overflow): New function, refactoring common code.
6948 (Fformat_time_string, Fdecode_time, Fencode_time):
6949 (Fcurrent_time_string): Use it.
6951 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6952 * dired.c (make_time): Move to ...
6953 * editfns.c (make_time): ... here.
6954 * systime.h: Note the move.
6956 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6958 * fringe.c (update_window_fringes): Remove unused variables.
6960 * unexmacosx.c (copy_data_segment): Also copy __got section.
6963 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6965 * termcap.c [MSDOS]: Include "msdos.h".
6966 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6967 Constify `char *' arguments and their references according to
6968 prototypes in tparam.h.
6970 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6972 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6973 Adapt all references accordingly.
6975 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6977 2011-03-11 Tom Tromey <tromey@redhat.com>
6979 * buffer.c (syms_of_buffer): Remove obsolete comment.
6981 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6983 * termhooks.h (encode_terminal_code): Declare prototype.
6985 * msdos.c (encode_terminal_code): Don't declare prototype.
6987 * term.c (encode_terminal_code): Now external again, used by
6988 w32console.c and msdos.c.
6990 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6991 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6993 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6995 Fix some minor problems found by GCC 4.5.2's static checks.
6997 * fringe.c (update_window_fringes): Mark locals as initialized
6999 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7001 * alloc.c (mark_fringe_data): Move decl from here ...
7002 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7003 to check its interface.
7004 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7006 * fontset.c (free_realized_fontset): Now static.
7007 (Fset_fontset_font): Rename local to avoid shadowing.
7008 (fontset_font): Mark local as initialized.
7009 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7011 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7013 * xselect.c (x_disown_buffer_selections): Remove; not used.
7014 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7015 (x_own_selection, Fx_disown_selection_internal): Rename locals
7017 (x_handle_dnd_message): Remove local to avoid shadowing.
7019 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7020 so that the caller can use some name other than gcpro1.
7021 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7022 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7023 (Fx_backspace_delete_keys_p):
7024 Use them to avoid shadowing, and rename vars to avoid shadowing.
7025 (x_decode_color, x_set_name, x_window): Now static.
7026 (Fx_create_frame): Add braces to silence GCC warning.
7027 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7028 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7029 Remove unused locals.
7030 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7031 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7032 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7035 * xterm.h (x_mouse_leave): New decl.
7037 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7038 Remove unused functions.
7039 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7040 (x_calc_absolute_position): Now static.
7041 (XTread_socket): Don't define label "out" unless it's used.
7042 Don't declare local "event" unless it's used.
7043 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7044 unless they are used.
7045 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7046 (x_fatal_error_signal): Remove; not used.
7047 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7048 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7049 (x_error_catcher, x_connection_closed, x_error_handler):
7050 (x_error_quitter, xembed_send_message, x_iconify_frame):
7051 (my_log_handler): Rename locals to avoid shadowing.
7052 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7053 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7055 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7056 Rename or move locals to avoid shadowing.
7057 (tty_defined_color, merge_face_heights): Now static.
7058 (free_realized_faces_for_fontset): Remove; not used.
7059 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7060 does not deduce is never used uninitialized.
7061 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7062 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7064 * terminal.c (store_terminal_param): Now static.
7066 * xmenu.c (menu_highlight_callback): Now static.
7067 (set_frame_menubar): Remove unused local.
7068 (xmenu_show): Rename parameter to avoid shadowing.
7069 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7070 since they might point to immutable storage.
7071 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7072 since it's unused otherwise.
7074 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7075 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7076 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7077 avoids a gcc -Wuninitialized diagnostic.
7078 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7079 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7080 does not deduce are never used uninitialized.
7082 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7084 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7085 * window.c (window_loop, size_window):
7086 (run_window_configuration_change_hook, enlarge_window): Likewise.
7088 * window.c (display_buffer): Now static.
7089 (size_window): Mark variables that gcc -Wuninitialized
7090 does not deduce are never used uninitialized.
7091 * window.h (check_all_windows): New decl, to forestall
7092 gcc -Wmissing-prototypes diagnostic.
7093 * dispextern.h (bidi_dump_cached_states): Likewise.
7095 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7097 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7099 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7100 and to avoid gcc -Wuninitialized warning.
7101 (load_charset_map): Mark variables that gcc -Wuninitialized
7102 does not deduce are never used uninitialized.
7103 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7105 * coding.c (coding_set_source, coding_set_destination):
7106 Use "else { /* comment */ }" rather than "else /* comment */;"
7107 for clarity, and to avoid gcc -Wempty-body warning.
7108 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7109 a block, when the outer 'i' will do.
7110 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7111 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7112 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7113 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7114 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7115 Rename locals to avoid shadowing.
7116 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7117 * coding.c (emacs_mule_char, encode_invocation_designation):
7118 Now static, since they're not used elsewhere.
7119 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7120 (decode_coding_object, encode_coding_object, detect_coding_system):
7121 (decode_coding_emacs_mule): Mark variables that gcc
7122 -Wuninitialized does not deduce are never used uninitialized.
7123 (detect_coding_iso_2022): Initialize a local variable that might
7124 be used uninitialized. Leave a FIXME because it's not clear that
7125 this initialization is needed. (Bug#8211)
7126 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7127 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7128 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7129 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7130 Remove unused macros.
7132 * category.c (hash_get_category_set): Remove unused local var.
7133 (copy_category_table): Now static, since it's not used elsewhere.
7134 * character.c (string_count_byte8): Likewise.
7136 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7137 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7139 * chartab.c (copy_sub_char_table): Now static, since it's not used
7141 (sub_char_table_ref_and_range, char_table_ref_and_range):
7142 Rename locals to avoid shadowing.
7143 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7145 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7146 (BIDI_BOB): Remove unused macro.
7148 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7149 deduce are never used uninitialized.
7150 * term.c (encode_terminal_code): Likewise.
7152 * term.c (encode_terminal_code): Now static. Remove unused local.
7154 * tparam.h: New file.
7155 * term.c, tparam.h: Include it.
7156 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7157 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7158 Move these decls to tparam.h, and make them agree with what
7159 is actually in tparam.c. The previous trick of using incompatible
7160 decls in different modules does not conform to the C standard.
7161 All callers of tparam changed to use tparam's actual API.
7162 * tparam.c (tparam1, tparam, tgoto):
7163 Use const pointers where appropriate.
7165 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7166 * cm.h (struct cm): Likewise.
7167 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7168 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7169 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7170 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7171 (turn_on_face, init_tty): Likewise.
7172 * termchar.h (struct tty_display_info): Likewise.
7174 * term.c (term_mouse_position): Rename local to avoid shadowing.
7176 * alloc.c (mark_ttys): Move decl from here ...
7177 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7179 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7181 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7183 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7185 * search.c (compile_pattern_1): Remove argument regp, unused since
7186 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7187 (compile_pattern): Don't pass it.
7189 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7191 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7192 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7194 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7196 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7198 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7199 gdk_window_get_screen, gdk_window_get_geometry,
7200 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7201 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7202 (xg_get_pixbuf_from_pixmap): New function.
7203 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7204 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7205 Call xg_get_pixbuf_from_pixmap instead of
7206 gdk_pixbuf_get_from_drawable.
7207 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7208 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7209 (xg_check_special_colors): Use GtkStyleContext and its functions
7211 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7212 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7213 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7214 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7215 Call gtk_widget_get_preferred_size.
7216 (xg_frame_resized): gdk_window_get_geometry only takes 5
7218 (xg_win_to_widget, xg_event_is_for_menubar):
7219 Call gdk_x11_window_lookup_for_display.
7220 (xg_set_widget_bg): New function.
7221 (delete_cb): New function.
7222 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7223 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7224 (xg_set_background_color): Call xg_set_widget_bg.
7225 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7226 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7227 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7228 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7230 (update_frame_tool_bar): Call gtk_widget_hide.
7231 (xg_initialize): Use GDK_KEY_g.
7233 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7235 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7237 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7238 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7239 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7241 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7243 * w32xfns.c (select_palette): Check success of RealizePalette against
7244 GDI_ERROR, not zero.
7246 See ChangeLog.11 for earlier changes.
7252 Copyright (C) 2011 Free Software Foundation, Inc.
7254 This file is part of GNU Emacs.
7256 GNU Emacs is free software: you can redistribute it and/or modify
7257 it under the terms of the GNU General Public License as published by
7258 the Free Software Foundation, either version 3 of the License, or
7259 (at your option) any later version.
7261 GNU Emacs is distributed in the hope that it will be useful,
7262 but WITHOUT ANY WARRANTY; without even the implied warranty of
7263 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7264 GNU General Public License for more details.
7266 You should have received a copy of the GNU General Public License
7267 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.