Set members of the struct coding_system before accessing them (bug#9910,9911,9912).
[bpt/emacs.git] / src / ChangeLog
1 2011-11-07 Kenichi Handa <handa@m17n.org>
2
3 * coding.c (coding_set_destination): Check coding->src_pos only
4 when coding->src_object is a buffer (bug#9910).
5
6 * process.c (send_process): Set the member src_multibyte of coding
7 to 0 (bug#9911) when sending a unibyte text.
8
9 * callproc.c (Fcall_process): Set the member src_multibyte of
10 process_coding to 0 (bug#9912).
11
12 2011-11-03 Eli Zaretskii <eliz@gnu.org>
13
14 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
15
16 * w32fns.c (unwind_create_frame): If needed, free the glyph
17 matrices of the partially constructed frame. (Bug#9943)
18 * xfns.c (unwind_create_frame): Likewise.
19
20 2011-11-01 Eli Zaretskii <eliz@gnu.org>
21
22 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
23 Don't stop backward scan on the continuation glyph, even though
24 its CHARPOS is positive.
25 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
26 cover_string to disp_string.
27
28 2011-11-01 Martin Rudalics <rudalics@gmx.at>
29
30 * window.c (temp_output_buffer_show): Don't use
31 Vtemp_buffer_show_specifiers.
32 (Vtemp_buffer_show_specifiers): Remove unused variable.
33
34 2011-10-30 Eli Zaretskii <eliz@gnu.org>
35
36 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
37 past the beginning of the current glyph matrix.
38
39 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
40
41 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
42 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
43 HAVE_GTK3 (Bug#9869).
44
45 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
46 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
47
48 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
49
50 * xterm.c: Declare x_handle_net_wm_state to return int.
51 (handle_one_xevent): Check if we are iconified but don't have
52 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
53 (get_current_wm_state): Return non-zero if not hidden,
54 check for _NET_WM_STATE_HIDDEN (Bug#9893).
55 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
56 (x_handle_net_wm_state): Return what get_current_wm_state returns.
57 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
58
59 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
60
61 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
62 so that this new function doesn't get optimized away by a
63 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
64
65 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
66
67 * frame.h (MOUSE_HL_INFO): Remove excess parens.
68
69 2011-10-29 Eli Zaretskii <eliz@gnu.org>
70
71 Fix the `xbytecode' command.
72 * .gdbinit (xprintbytestr): New command.
73 (xwhichsymbols): Renamed from `which'; all callers changed.
74 (xbytecode): Print the byte-code string as well.
75
76 2011-10-29 Kim Storm <storm@cua.dk>
77
78 * alloc.c (which_symbols): New function.
79
80 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
81
82 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
83 line. (Bug#9903)
84
85 2011-10-29 Glenn Morris <rgm@gnu.org>
86
87 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
88 Not clear what it was for, and it causes various bugs. (Bug#9839)
89
90 2011-10-28 Eli Zaretskii <eliz@gnu.org>
91
92 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
93 possible random value that matches one of those tested as
94 condition to clear the mouse face.
95
96 2011-10-28 Chong Yidong <cyd@gnu.org>
97
98 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
99
100 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
101
102 * window.c (make_window): Initialize phys_cursor_on_p.
103
104 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
105
106 * lisp.h (struct Lisp_Symbol): Update comments.
107
108 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
109
110 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
111
112 2011-10-28 Eli Zaretskii <eliz@gnu.org>
113
114 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
115 <oslsachem@gmail.com> for helping to debug this.
116
117 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
118 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
119 (g_b_init_get_glyph_outline_w): New static variables.
120 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
121 (GetGlyphOutlineW_Proc): New typedefs.
122 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
123 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
124 New functions.
125 (w32font_open_internal, compute_metrics):
126 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
127 instead of calling the "wide" APIs directly.
128
129 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
130
131 * w32.h (syms_of_w32font): Add prototype.
132
133 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
134
135 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
136 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
137 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
138 (Fmove_to_window_line): Doc fix.
139
140 2011-10-27 Chong Yidong <cyd@gnu.org>
141
142 * process.c (make_process): Set gnutls_state to NULL.
143
144 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
145 non-NULL, regardless of GNUTLS_INITSTAGE.
146 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
147 an error. Set process slots as soon as we allocate them.
148
149 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
150
151 2011-10-27 Chong Yidong <cyd@gnu.org>
152
153 * gnutls.c (emacs_gnutls_deinit): New function.
154 Deallocate credentials structures as well as calling gnutls_deinit.
155 (Fgnutls_deinit, Fgnutls_boot): Use it.
156
157 * process.c (make_process): Initialize GnuTLS credentials to NULL.
158 (deactivate_process): Call emacs_gnutls_deinit.
159
160 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
161
162 * image.c (x_create_x_image_and_pixmap):
163 * w32.c (sys_rename, w32_delayed_load):
164 * w32font.c (fill_in_logfont):
165 * w32reg.c (x_get_string_resource): Silence compiler warnings.
166
167 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
168
169 * w32fns.c (w32_default_color_map): New function,
170 extracted from Fw32_default_color_map.
171 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
172
173 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
174
175 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
176
177 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
178
179 * keyboard.c (test_undefined): New function (bug#9751).
180 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
181
182 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
183
184 * sysdep.c (init_sys_modes): Fix the check for the controlling
185 terminal (Bug#6649).
186
187 2011-10-20 Eli Zaretskii <eliz@gnu.org>
188
189 * dispextern.h (struct bidi_it): New member next_en_type.
190
191 * bidi.c (bidi_line_init): Initialize the next_en_type member.
192 (bidi_resolve_explicit_1): When next_en_pos is valid for the
193 current character, check also for next_en_type being WEAK_EN.
194 (bidi_resolve_weak): Don't enter the expensive loop if the current
195 position is before next_en_pos. Record the bidi type of the first
196 non-ET, non-BN character we find, in addition to its position.
197 (bidi_level_of_next_char): Invalidate next_en_type when
198 next_en_pos is over-stepped.
199
200 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
201
202 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
203 * editfns.c: Rewrite current-time-zone so that it invokes
204 the equivalent of (format-time-string "%Z") to get the time zone name.
205 This fixes a bug when the time zone name contains characters that
206 need converting from the system time locale to Emacs internal format.
207 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
208 that patch fixed format-time-string to do the conversion, but
209 I forgot to fix current-time-zone.
210 (format_time_string): New function, containing most of
211 what Fformat_time_string used to contain.
212 (Fformat_time_string): Rewrite in terms of format_time_string.
213 This doesn't change this function's behavior.
214 (current-time-zone): Rewrite to use format_time_string.
215 This fixes the bug reported by Michael Schierl in
216 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
217 Jason Rumney's 2007-06-07 change worked around this bug, but
218 didn't fix it.
219 * systime.h (tzname, timezone): Remove no-longer-used declarations.
220
221 2011-10-19 Eli Zaretskii <eliz@gnu.org>
222
223 * xdisp.c (start_display): If the character at POS is displayed
224 via a display vector, reset IT->current.dpvec_index to zero.
225 (try_window_reusing_current_matrix): If a line ends in a display
226 vector or the next line starts in a display vector, continue
227 redrawing the window even though the character position of
228 start_row was reached.
229 (Bug#9771, part 2)
230
231 2011-10-18 Chong Yidong <cyd@gnu.org>
232
233 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
234 with nobreak-char-display too.
235
236 2011-10-18 Eli Zaretskii <eliz@gnu.org>
237
238 Fix part 3 of bug#9771.
239 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
240 (bidi_resolve_neutral): Don't enter the expensive loop looking for
241 non-neutral characters if the current character is a paragraph
242 separator (a.k.a. Newline). This avoids running the same
243 expensive loop twice, once when we consume the preceding newline
244 and the other time when the line actually needs to be displayed.
245 Avoid the loop when we see neutrals on the base embedding level
246 following a character whose directionality is the same as the
247 paragraph's. This avoids running the expensive loop when a line
248 ends in a long sequence of neutrals, like control characters.
249 Add assertion against STRONG_AL type. Slightly rearrange code
250 that determines the type of a neutral given the first non-neutral
251 that follows it.
252 (bidi_level_of_next_char): Set next_en_pos to zero when
253 invalidating its info.
254
255 2011-10-17 Eli Zaretskii <eliz@gnu.org>
256
257 * xdisp.c (push_display_prop): Determine whether to record string
258 or buffer position by IT->string, not by IT->method. Allow
259 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
260 (move_it_vertically_backward): Don't look for character position
261 immediately after the newline when in a continuation line.
262 (Bug#9771, part 1)
263
264 2011-10-15 Martin Rudalics <rudalics@gmx.at>
265
266 * window.c (coordinates_in_window): Rewrite and delabelize
267 vertical border check. (Bug#5357) (Bug#9618)
268
269 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
270
271 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
272 errors in XSetWindowBorder (bug#9310).
273
274 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
275
276 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
277 avoid crash when xmalloc overrun checking is enabled.
278
279 2011-10-13 Eli Zaretskii <eliz@gnu.org>
280
281 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
282 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
283 cursor motion with <left> and <right> arrow keys.
284
285 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
286 some callers set that themselves.
287
288 2011-10-12 Eli Zaretskii <eliz@gnu.org>
289
290 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
291 display string and the previous row comes from the same string and
292 is empty. (Bug#9739) (Bug#9738)
293
294 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
295
296 * doc.c (get_doc_string): Encode file name (bug#9735).
297
298 2011-10-12 Eli Zaretskii <eliz@gnu.org>
299
300 * bidi.c (bidi_level_of_next_char):
301 * xdisp.c (get_visually_first_element): Remove old incorrect
302 comments regarding the Unicode Line Separator character.
303
304 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
305
306 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
307
308 * alloc.c (Fgc_status): Do not access beyond zombies array
309 boundary if nzombies > MAX_ZOMBIES.
310 * alloc.c (dump_zombies): Add missing format specifier.
311
312 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
313
314 * xdisp.c (set_cursor_from_row): Simplify conditionals,
315 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
316
317 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
318 Some packages use them to denote characters with modifiers.
319
320 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
321
322 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
323 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
324 matching a pp-number. Rename parameter var to var1.
325
326 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
327
328 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
329
330 2011-10-08 Glenn Morris <rgm@gnu.org>
331
332 * callint.c (Fcall_interactively): Give a more explicit error for the
333 'c' case with a non-character input. (Bug#8479)
334
335 2011-10-08 Eli Zaretskii <eliz@gnu.org>
336
337 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
338 lines.
339 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
340 lines that are hscrolled on the left.
341
342 * dispnew.c (buffer_posn_from_coords): Account for a possible
343 presence of header-line. (Bug#4426)
344
345 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
346
347 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
348 Don't advertise functionality which we discourage or doesn't work.
349
350 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
351
352 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
353 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
354 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
355 this makes Emacs dump core during garbage collection on rare
356 occasions. sizeof is obviously inferior to offsetof here, so
357 stick with offsetof.
358 (GC_POINTER_ALIGNMENT): New macro.
359 (mark_memory): Omit 3rd (offset) arg; caller changed.
360 Don't assume EMACS_INT alignment is the same as pointer alignment.
361
362 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
363
364 * keyboard.c (read_key_sequence_remapped): New var.
365 (read_key_sequence): Compute remapping in the right buffer.
366 (command_loop_1): Use read_key_sequence's remapping directly.
367
368 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
369
370 * dired.c (file_name_completion): Don't expand file name.
371 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
372 before checking file name handler.
373
374 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
375 they've been requested explicitly (bug#9591).
376
377 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
378
379 * keymap.c (Fsingle_key_description): Use make_specified_string
380 instead of build_string to build string from push_key_description.
381 (Bug#5193)
382
383 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
384
385 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
386 This fixes a Y2038 bug on 64-bit hosts.
387 * buffer.c (reset_buffer):
388 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
389 (Fclear_buffer_auto_save_failure):
390 Use 0, not -1, to represent an unset failure time, since time_t
391 might not be signed.
392
393 Remove dependency on glibc malloc internals.
394 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
395 Move back here from lisp.h, but with their new implementations.
396 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
397 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
398 * charset.c (charset_table_init): New static var.
399 (syms_of_charset): Use it instead of xmalloc. This removes a
400 dependency on glibc malloc internals. See Eli Zaretskii's comment in
401 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
402 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
403 Move back to alloc.c.
404 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
405 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
406
407 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
408
409 * nsterm.m (windowDidResize): Call x_set_window_size only when
410 ns_in_resize is true. Otherwise set pixelwidth/height and
411 call change_frame_size (Bug#9628).
412
413 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
414
415 Port --enable-checking=all to Fedora 14 x86-64.
416 * charset.c (syms_of_charset): Also account for glibc malloc's
417 internal overhead when calculating the initial malloc maximum.
418
419 Port --enable-checking=all to Fedora 14 x86.
420 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
421 Move to lisp.h.
422 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
423 (overrun_check_realloc, overrun_check_free):
424 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
425 That way, xmalloc returns a properly-aligned pointer even if
426 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
427 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
428 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
429 into account when calculating the initial malloc maximum.
430 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
431 Move here from alloc.c, so that charset.c can use it too.
432 Properly align; the old code wasn't right for common 32-bit hosts
433 when configured with --enable-checking=all.
434 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
435 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
436
437 2011-09-29 Eli Zaretskii <eliz@gnu.org>
438
439 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
440 use EDOM.
441
442 2011-09-28 Eli Zaretskii <eliz@gnu.org>
443
444 * xdisp.c (compute_display_string_end): If there's no display
445 string at CHARPOS, return -1.
446
447 * bidi.c (bidi_fetch_char): When compute_display_string_end
448 returns a negative value, treat the character as a normal
449 character not covered by a display string. (Bug#9624)
450
451 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
452
453 * lread.c (Fread_from_string): Fix typo in docstring.
454
455 2011-09-27 Eli Zaretskii <eliz@gnu.org>
456
457 * xdisp.c (handle_invisible_prop): If invisible text ends on a
458 newline, reseat the iterator instead of bidi-iterating there one
459 character at a time. (Bug#9610)
460 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
461 TO_CHARPOS if the bidi iterator is at base embedding level.
462
463 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
464
465 * lread.c (readevalloop): Use correct code for NBSP.
466 (read1): Likewise. (Bug#9608)
467
468 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
469
470 * dbusbind.c (Fdbus_register_signal): When service is not
471 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
472
473 2011-09-25 Glenn Morris <rgm@gnu.org>
474
475 * buffer.c (truncate-lines): Doc fix.
476
477 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
478
479 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
480 (Fset_window_next_buffers): Doc fix.
481
482 2011-09-24 Glenn Morris <rgm@gnu.org>
483
484 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
485
486 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
487
488 Fix minor problems found by static checking.
489 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
490 * indent.c (Fvertical_motion): Fix == vs = typo.
491
492 2011-09-24 Eli Zaretskii <eliz@gnu.org>
493
494 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
495 Default value is now t. Doc fix.
496
497 * indent.c (Fvertical_motion): Compute and apply the overshoot
498 logic when moving up, not only when moving down. Fix the
499 confusing name and values of the it_overshoot_expected variable;
500 logic changes accordingly. (Bug#9254) (Bug#9549)
501
502 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
503 CHARPOS is covered by a display string which includes newlines.
504 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
505 is covered by a display string with embedded newlines.
506
507 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
508
509 * dbusbind.c (Fdbus_register_signal): Add match rule to
510 Vdbus_registered_objects_table. (Bug#9581)
511 (Fdbus_register_method, Vdbus_registered_objects_table):
512 Fix docstring.
513
514 2011-09-24 Jim Meyering <meyering@redhat.com>
515
516 do not ignore write error for any output size
517 The previous change was incomplete.
518 While it makes emacs --batch detect the vast majority of stdout
519 write failures, errors were still ignored whenever the output size is
520 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
521 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
522 && echo FAIL: ignored write error
523 FAIL: ignored write error
524 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
525 && echo FAIL: ignored write error
526 FAIL: ignored write error
527 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
528
529 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
530
531 * emacs.c (Fkill_emacs): In noninteractive mode exit
532 non-successfully if a write error occurred on stdout. (Bug#9574)
533
534 2011-09-21 Eli Zaretskii <eliz@gnu.org>
535
536 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
537 the xassert test.
538
539 * dispextern.h (struct it): Update the comment documenting what
540 can it->OBJECT be.
541
542 2011-09-20 Eli Zaretskii <eliz@gnu.org>
543
544 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
545 a display string, extend search for cursor position to end of row.
546 (find_row_edges): If the row ends in a newline from a display
547 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
548 Handle the case of a display string with multiple newlines.
549 (Fcurrent_bidi_paragraph_direction): Fix search for previous
550 non-empty line. Fixes confusing cursor motion with arrow keys at
551 the beginning of a line that starts with whitespace.
552
553 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
554
555 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
556 (bug#9493).
557
558 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
559
560 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
561 boolean (Bug#9154).
562
563 2011-09-18 Eli Zaretskii <eliz@gnu.org>
564
565 * xdisp.c (display_line): Record maximum and minimum buffer
566 positions even if no glyphs were produced (e.g., by a zero-width
567 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
568 buffer positions that will be removed from the glyph row because
569 they don't fit.
570 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
571 column is beyond frame width: don't subtract 1 "pixel" when
572 computing width of the stretch.
573 (reseat_at_next_visible_line_start): Undo the change made on
574 2011-09-17 that saved paragraph information and restored it after
575 the call to `reseat'. (Bug#9545)
576
577 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
578
579 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
580 and turn window cursor on if cleared (Bug#9415).
581
582 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
583
584 * search.c (boyer_moore): Take unibyte characters from pattern
585 literally. (Bug#9458)
586
587 2011-09-18 Eli Zaretskii <eliz@gnu.org>
588
589 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
590
591 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
592
593 Fix minor problem found by static checking.
594 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
595 initialized, to pacify gcc -Wuninitialized.
596
597 * fileio.c: Report proper errno when syscall falls.
598 (Finsert_file_contents): Save and restore errno,
599 so that report_file_error outputs the correct diagnostic.
600 (Fwrite_region) [CLASH_DETECTION]: Likewise.
601
602 2011-09-18 Eli Zaretskii <eliz@gnu.org>
603
604 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
605
606 2011-09-17 Eli Zaretskii <eliz@gnu.org>
607
608 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
609 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
610
611 2011-09-17 Eli Zaretskii <eliz@gnu.org>
612
613 * xdisp.c (reseat_at_next_visible_line_start): Keep information
614 about the current paragraph and restore it after the call to reseat.
615
616 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
617 (bidi_find_paragraph_start): Search back for paragraph beginning
618 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
619 (bidi_move_to_visually_next): Only trigger paragraph-related
620 computations when the last character is a newline or at EOB, not
621 just any NEUTRAL_B. (Bug#9470)
622
623 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
624 truncated lines if point is covered by a display string. (Bug#9524)
625
626 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
627
628 * xselect.c: Relax test for outgoing X longs (Bug#9498).
629 (cons_to_x_long): New function.
630 (lisp_data_to_selection_data): Use it. Correct the test for
631 short-versus-long data; it was negated. Break out of vector
632 loop, for efficiency, when a long datum is discovered.
633
634 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
635
636 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
637
638 2011-09-16 Eli Zaretskii <eliz@gnu.org>
639
640 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
641 GCC PR/17406) by declaring this function with external scope.
642
643 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
644
645 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
646 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
647
648 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
649
650 * editfns.c (Fformat): Correctly handle text properties on "%%".
651
652 2011-09-15 Eli Zaretskii <eliz@gnu.org>
653
654 * xterm.c (x_draw_composite_glyph_string_foreground):
655 * w32term.c (x_draw_composite_glyph_string_foreground):
656 * term.c (encode_terminal_code):
657 * composite.c (composition_update_it, get_composition_id):
658 * xdisp.c (get_next_display_element)
659 (fill_composite_glyph_string): Add comments about special meaning
660 of TAB characters in a composition.
661
662 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
663
664 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
665 This occurs when processing a multibyte format.
666 Problem reported by Wolfgang Jenker.
667
668 2011-09-15 Johan Bockgård <bojohan@gnu.org>
669
670 * xdisp.c (try_cursor_movement): Only check for exact match if
671 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
672
673 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
674
675 Remove unused external symbols.
676 * dispextern.h (calc_pixel_width_or_height): Remove decl.
677 * xdisp.c (calc_pixel_width_or_height): Now static.
678 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
679 * indent.c (check_display_width):
680 * w32term.c: Fix comment to match code.
681 * xterm.c, xterm.h (x_catching_errors): Remove.
682
683 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
684
685 * xselect.c: Use signed conversions more consistently (Bug#9498).
686 (selection_data_to_lisp_data): Assume incoming selection data are
687 signed integers, not unsigned. This is to be consistent with
688 outgoing selection data, which was modified to use signed integers
689 in as part of the fix to Bug#9196 in response to Jan D.'s comment
690 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
691 expects long, not unsigned long.
692
693 2011-09-14 Eli Zaretskii <eliz@gnu.org>
694
695 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
696 computation of loop end. Reported by Johan Bockgård
697 <bojohan@gnu.org>.
698
699 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
700
701 * frame.c (Fother_visible_frames_p): Function deleted.
702
703 2011-09-12 Eli Zaretskii <eliz@gnu.org>
704
705 * indent.c (compute_motion): Process display vector front to back
706 rather than the other way around. (Bug#2496)
707
708 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
709
710 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
711
712 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
713
714 * minibuf.c (Fread_from_minibuffer): Doc fix.
715
716 2011-09-11 Eli Zaretskii <eliz@gnu.org>
717
718 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
719 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
720
721 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
722
723 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
724 value for non-existent files.
725
726 2011-09-11 Eli Zaretskii <eliz@gnu.org>
727
728 * fileio.c (Finsert_file_contents): If the file cannot be opened,
729 set its "size" to -1. This will set the modtime_size field of
730 the corresponding buffer to -1, which is what
731 verify-visited-file-modtime expects for files that do not exist.
732 (Bug#9139)
733
734 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
735
736 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
737 here ...
738 * lisp.h: ... from here. push_key_description is no longer
739 defined in keyboard.c, so its declaration should not be in
740 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
741 logically belongs with push_key_description.
742
743 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
744
745 * buffer.h: Include <sys/types.h> instead of <time.h>.
746 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
747 Problem reported by Herbert J. Skuhra.
748
749 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
750
751 * xml.c (parse_region): Make the parsing work for
752 non-comment-starting XML files again (bug#9144).
753
754 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
755
756 * image.c (gif_load): Fix calculation of bottom and right corner.
757 (Bug#9468)
758
759 2011-09-10 Eli Zaretskii <eliz@gnu.org>
760
761 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
762 redisplay in small windows.
763
764 2011-09-09 Eli Zaretskii <eliz@gnu.org>
765
766 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
767
768 2011-09-08 Martin Rudalics <rudalics@gmx.at>
769
770 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
771 Operate on live windows only.
772
773 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
774
775 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
776
777 2011-09-07 Eli Zaretskii <eliz@gnu.org>
778
779 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
780 only under bidi iteration.
781
782 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
783
784 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
785
786 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
787
788 isnan: Fix porting problem to Solaris 10 with bundled gcc.
789 Without this fix, the command to link temacs failed due to an
790 undefined symbol __builtin_isnan. This is because
791 /usr/include/iso/math_c99.h #defines isnan(x) to
792 __builtin_isnan(x), but the bundled gcc, which identifies itself
793 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
794 a __builtin_isnan.
795 * floatfns.c (isnan): #undef, and then #define to a clone of
796 what's in data.c.
797 (Fisnan): Always define, since it's always available now.
798 (syms_of_floatfns): Always define isnan at the Lisp level.
799
800 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
801
802 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
803
804 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
805
806 * fileio.c: Fix bugs with large file offsets (Bug#9428).
807 The previous code assumed that file offsets (off_t values) fit in
808 EMACS_INT variables, which is not true on typical 32-bit hosts.
809 The code messed up by falsely reporting buffer overflow in cases
810 such as (insert-file-contents "big" nil 1 2) into an empty buffer
811 when "big" contains more than 2**29 bytes, even though this
812 inserts just one byte and does not overflow the buffer.
813 (Finsert_file_contents): Store file offsets as off_t
814 values, not as EMACS_INT values. Check for overflow when
815 converting between EMACS_INT and off_t. When checking for
816 buffer overflow or for overlap, take the offsets into account.
817 Don't use EMACS_INT for small values where int suffices.
818 When checking for overlap, fix a typo: ZV was used where
819 ZV_BYTE was intended.
820 (Fwrite_region): Don't assume off_t fits into 'long'.
821 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
822
823 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
824
825 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
826
827 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
828
829 sprintf-related integer and memory overflow issues (Bug#9412).
830
831 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
832 (esprintf, exprintf, evxprintf): New functions.
833 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
834 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
835 (modify_event_symbol): Do not assume that the length of
836 name_alist_or_stem is safe to alloca and fits in int.
837 (Fexecute_extended_command): Likewise for function name and binding.
838 (Frecursion_depth): Wrap around reliably on integer overflow.
839 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
840 since some callers pass EMACS_INT values.
841 (Fsingle_key_description): Don't crash if symbol name contains more
842 than MAX_ALLOCA bytes.
843 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
844 (get_minibuffer): Arg is now EMACS_INT, not int.
845 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
846 (esprintf, exprintf, evxprintf): New decls.
847 * window.h (command_loop_level, minibuf_level): Reflect API changes.
848
849 * dbusbind.c (signature_cat): New function.
850 (xd_signature, Fdbus_register_signal):
851 Do not overrun buffer; instead, report string overflow.
852
853 * dispnew.c (add_window_display_history): Don't overrun buffer.
854 Truncate instead; this is OK since it's just a log.
855
856 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
857 even if the time zone offset is outlandishly large.
858 Don't mishandle offset == INT_MIN.
859
860 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
861 when creating daemon; the previous buffer-overflow check was incorrect.
862
863 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
864 which has the guts of the old verror function.
865
866 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
867 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
868
869 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
870 (font_unparse_xlfd): Don't blindly alloca long strings.
871 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
872 fits in int, when using sprintf. Use single snprintf to count
873 length of string rather than counting it via multiple sprintfs;
874 that's simpler and more reliable.
875 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
876 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
877 sprintf, in case result does not fit in int.
878
879 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
880 (fontset_from_font): Print it.
881
882 * frame.c (tty_frame_count): Now printmax_t, not int.
883 (make_terminal_frame, set_term_frame_name): Print it.
884 (x_report_frame_params): In X, window IDs are unsigned long,
885 not signed long, so print them as unsigned.
886 (validate_x_resource_name): Check for implausibly long names,
887 and don't assume name length fits in 'int'.
888 (x_get_resource_string): Don't blindly alloca invocation name;
889 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
890 not fit in int.
891
892 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
893 (xg_check_special_colors, xg_set_geometry):
894 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
895
896 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
897 Use esprintf, not sprintf, in case result does not fit in int.
898
899 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
900 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
901 it as a large positive number.
902 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
903 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
904
905 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
906 in case result does not fit in int.
907
908 * print.c (float_to_string): Detect width overflow more reliably.
909 (print_object): Make sprintf buffer a bit bigger, to avoid potential
910 buffer overrun. Don't assume list length fits in 'int'. Treat
911 print length of 0 as 0, not as infinity; to be consistent with other
912 uses of print length in this function. Don't overflow print length
913 index. Don't assume hash table size fits in 'long', or that
914 vectorlike size fits in 'unsigned long'.
915
916 * process.c (make_process): Use printmax_t, not int, to format
917 process-name gensyms.
918
919 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
920
921 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
922 to avoid potential buffer overrun.
923
924 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
925 if X resource line is longer than 512 bytes.
926
927 * xfns.c (x_window): Make sprintf buffer a bit bigger
928 to avoid potential buffer overrun.
929
930 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
931
932 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
933
934 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
935
936 Integer overflow fixes for scrolling, etc.
937 Without these, Emacs silently mishandles large integers sometimes.
938 For example, "C-u 4294967297 M-x recenter" was treated as if
939 it were "C-u 1 M-x recenter" on a typical 64-bit host.
940
941 * xdisp.c (try_window_id): Check Emacs fixnum range before
942 converting to 'int'.
943
944 * window.c (window_scroll_line_based, Frecenter):
945 Check that an Emacs fixnum is in range before assigning it to 'int'.
946 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
947 values converted from Emacs fixnums.
948 (Frecenter): Don't wrap around a line count if it is out of 'int'
949 range; instead, treat it as an extreme value.
950 (Fset_window_configuration, compare_window_configurations):
951 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
952
953 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
954 that can exceed INT_MAX. Check that EMACS_INT value is in range
955 before assigning it to the (possibly-narrower) index.
956 (match_limit): Don't assume that a fixnum can fit in 'int'.
957
958 * print.c (print_object): Use ptrdiff_t, not int, for index that can
959 exceed INT_MAX.
960
961 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
962 (Fvertical_motion): Don't wrap around LINES values that don't fit
963 in 'int'. Instead, treat them as extreme values. This is good
964 enough for windows, which can't have more than INT_MAX lines anyway.
965
966 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
967
968 * Require libxml/parser.h to avoid compilation warning.
969
970 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
971
972 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
973 since this reportedly can destroy thread storage.
974
975 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
976
977 * syntax.c (find_defun_start): Update all cache variables if
978 exiting early (Bug#9401).
979
980 2011-08-30 Eli Zaretskii <eliz@gnu.org>
981
982 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
983
984 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
985 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
986 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
987
988 * term.c (tty_append_glyph): New function.
989 (produce_stretch_glyph): Static function and its prototype deleted.
990
991 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
992 Add prototypes.
993
994 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
995
996 * image.c (parse_image_spec): Check for nonnegative, not for positive,
997 when checking :margin (Bug#9390).
998 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
999 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1000 so that the name doesn't mislead. All uses changed.
1001
1002 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1003
1004 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1005 set_tty_hooks.
1006
1007 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1008
1009 * xdisp.c (move_it_to): Don't bail out early when reaching
1010 position beyond to_charpos, if we are scanning backwards.
1011 (move_it_vertically_backward): When DY == 0, make sure we get to
1012 the first character in the line after the newline.
1013
1014 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1015
1016 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1017 (ccl_driver): Do not generate an out-of-range pointer.
1018 (Fccl_execute_on_string): Remove unnecessary check for
1019 integer overflow, noted by Stefan Monnier in
1020 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1021 Remove a FIXME that didn't need fixing.
1022 Simplify the newly-introduced buffer reallocation code.
1023
1024 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1025
1026 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1027
1028 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1029
1030 Integer and memory overflow issues (Bug#9196).
1031
1032 * doc.c (get_doc_string): Rework so that
1033 get_doc_string_buffer_size is the actual buffer size, rather than
1034 being 1 less than the actual buffer size; this makes xpalloc more
1035 convenient.
1036
1037 * image.c (x_allocate_bitmap_record, cache_image):
1038 * xselect.c (Fx_register_dnd_atom):
1039 Simplify previous changes by using xpalloc.
1040
1041 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1042 since either will do and ptrdiff_t is convenient with xpalloc.
1043
1044 * charset.c (charset_table_size)
1045 (struct charset_sort_data.priority): Now ptrdiff_t.
1046 (charset_compare): Don't overflow if priorities differ greatly.
1047 (Fsort_charsets): Don't assume list length fits in int.
1048 Check for size-calculation overflow when allocating sort data.
1049 (syms_of_charset): Allocate an initial charset table that is
1050 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1051
1052 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1053
1054 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1055 The actual value is always <= INT_MAX, and leaving it unsigned made
1056 overflow checking harder.
1057
1058 * dispextern.h (struct glyph_matrix.rows_allocated)
1059 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1060 with xpalloc. The values are still always <= INT_MAX.
1061
1062 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1063
1064 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1065 (SAFE_NALLOCA): New macro.
1066
1067 * region-cache.c (struct boundary.pos, find_cache_boundary)
1068 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1069 (set_cache_region, invalidate_region_cache)
1070 (revalidate_region_cache, know_region_cache, region_cache_forward)
1071 (region_cache_backward, pp_cache):
1072 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1073 so that ptrdiff_t * can be passed to xpalloc.
1074 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1075 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1076 (pp_cache): Don't assume cache_len fits in int.
1077 * region-cache.h: Adjust extern decls to match.
1078
1079 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1080 EMACS_INT, since either will do, for xpalloc.
1081
1082 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1083 (xnmalloc, xnrealloc, xpalloc): New functions.
1084
1085 * bidi.c (bidi_shelve_header_size): New constant.
1086 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1087 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1088
1089 * bidi.c (bidi_cache_shrink):
1090 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1091 (overlay_strings):
1092 Don't update size of array until after memory allocation succeeds,
1093 because xmalloc/xrealloc may not return.
1094 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1095 now that we have proper integer overflow checking.
1096 (record_overlay_string, overlay_strings): Catch overflows when
1097 calculating size of overlay_str_buf.
1098
1099 * callproc.c (Fcall_process): Check for size overflow when
1100 calculating size of args2.
1101 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1102 Normally we prefer signed values, but sticking with ptrdiff_t would
1103 require adding more-complicated checks.
1104
1105 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1106 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1107 Redo buffer-overflow calculations to avoid integer overflow.
1108 Add a FIXME comment where memory seems to be over-allocated.
1109
1110 * character.c (Fstring): Check for size-calculation overflow.
1111
1112 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1113 unnecessary integer overflow. Check for size overflow.
1114 (encode_coding_object): Don't update size until xmalloc succeeds.
1115
1116 * composite.c (get_composition_id): Check for overflow in glyph
1117 length calculations.
1118
1119 Integer and memory overflow fixes for display code.
1120 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1121 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1122 (scrolling_window): Check for overflow in size calculations.
1123 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1124 Don't assume glyph table len fits in int.
1125 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1126 (row_table_size): Now ptrdiff_t, not int.
1127 (scrolling_window): Avoid overflow in size calculations.
1128 Don't update size until allocation succeeds.
1129 * fns.c (concat): Check for overflow in size calculations.
1130 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1131 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1132 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1133
1134 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1135 (get_doc_string): Check for size calculation overflow.
1136 Don't update size until allocation succeeds.
1137 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1138 EMACS_INT, where ptrdiff_t will do.
1139 (Fsubstitute_command_keys): Check for string overflow.
1140
1141 * editfns.c (set_time_zone_rule): Don't assume environment length
1142 fits in int.
1143 (message_length): Now ptrdiff_t, not int.
1144 (Fmessage_box): Don't update size until allocation succeeds.
1145 Don't assume message length fits in int.
1146 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1147
1148 * emacs.c (main): Do not reallocate argv, since there is a null at
1149 the end that can be overwritten, and this way there's no need to
1150 worry about size-calculation overflow.
1151 (sort_args): Check for size-calculation overflow.
1152
1153 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1154 alloc succeeds.
1155 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1156
1157 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1158 (x_set_scroll_bar_width, x_figure_window_size):
1159 Check for integer overflow.
1160 (x_set_alpha): Do not assume XINT fits in int.
1161
1162 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1163 This is for the members text_lines, text_cols, total_lines, total_cols,
1164 where the system imposes an 'int' limit.
1165
1166 * fringe.c (Fdefine_fringe_bitmap):
1167 Don't update size until alloc works.
1168
1169 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1170 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1171
1172 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1173 Check for size-calculation overflow.
1174 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1175 do, as we prefer signed integers.
1176 (id_to_widget.max_size, id_to_widget.used)
1177 (xg_store_widget_in_map, xg_remove_widget_from_map)
1178 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1179 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1180 Use and return ptrdiff_t, not int.
1181 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1182 * gtkutil.h: Change prototypes to match the above.
1183
1184 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1185 are duplicate now that they've been promoted to lisp.h.
1186 (x_allocate_bitmap_record, x_alloc_image_color)
1187 (make_image_cache, cache_image, xpm_load):
1188 Don't update size until alloc is done.
1189 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1190 (x_detect_edges):
1191 Check for size calculation overflow.
1192 (ct_colors_allocated_max): New constant.
1193 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1194 overflow.
1195
1196 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1197 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1198 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1199 Use ptrdiff_t, not int, to count maps.
1200 (read_char_minibuf_menu_prompt): Check for overflow in size
1201 calculations. Don't update size until allocation succeeds.
1202 Redo calculations to avoid overflow.
1203 * keyboard.h: Change prototypes to match the above.
1204
1205 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1206 to count maps.
1207 (current_minor_maps): Check for size calculation overflow.
1208 * keymap.h: Change prototypes to match the above.
1209
1210 * lread.c (read1, init_obarray): Don't update size until alloc done.
1211
1212 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1213 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1214
1215 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1216 Now ptrdiff_t, not int.
1217 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1218 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1219
1220 * process.c (Fnetwork_interface_list): Check for overflow
1221 in size calculation.
1222
1223 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1224
1225 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1226 overflow. Don't bother calling xmalloc when xrealloc will do.
1227
1228 * search.c (Freplace_match): Check for size calculation overflow.
1229 (Fset_match_data): Don't assume list lengths fit in 'int'.
1230
1231 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1232 for command line length. Do not attempt to address one before the
1233 beginning of an array, as that's not portable.
1234
1235 * term.c (max_frame_lines): Remove; unused.
1236 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1237 not int.
1238 (encode_terminal_code, calculate_costs): Check for size
1239 calculation overflow.
1240 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1241 table lengths and related sizes. Don't update size until alloc
1242 done. Redo calculations to avoid overflow.
1243 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1244
1245 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1246 subtracting pointers.
1247 (gobble_line): Check for overflow more carefully. Don't update size
1248 until alloc done.
1249
1250 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1251 Don't update size until alloc done.
1252 Redo size calculations to avoid overflow.
1253 Check for size calculation overflow.
1254 (main) [DEBUG]: Fix typo in invoking tparam1.
1255
1256 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1257 Use ptrdiff_t, not int, for sizes.
1258 (store_mode_line_noprop_char): Don't update size until alloc done.
1259
1260 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1261 Use ptrdiff_t, not int, for sizes.
1262 (Finternal_make_lisp_face, cache_face):
1263 Check for size calculation overflow.
1264 (cache_face): Treat size calculation overflows as if they were
1265 memory exhaustion (the usual treatment), rather than aborting.
1266
1267 * xfns.c (x_encode_text, x_set_name_internal)
1268 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1269 sizes, since they can exceed INT_MAX in size. Check for size
1270 calculation overflow.
1271
1272 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1273 (xg_select): Check for size calculation overflow.
1274 Don't update size until alloc done.
1275
1276 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1277 as sprintf is limited to int lengths.
1278
1279 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1280 (X_LONG_MIN): New macros.
1281 Use them to make the following changes clearer.
1282 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1283 This change doesn't affect the value now, but it may help remind
1284 future maintainers not to raise the value too much later.
1285 (SELECTION_QUANTUM): Remove, replacing with ...
1286 (selection_quantum): ... new function, which avoids overflow.
1287 All uses changed.
1288 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1289 assumption that selection length fits in 'int'.
1290 (x_reply_selection_request, x_handle_selection_request)
1291 (x_get_window_property, receive_incremental_selection)
1292 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1293 (lisp_data_to_selection_data, clean_local_selection_data):
1294 Use ptrdiff_t, not int, to record length of selection.
1295 (x_reply_selection_request, x_get_window_property)
1296 (receive_incremental_selection, x_property_data_to_lisp):
1297 Redo calculations to avoid overflow.
1298 (x_reply_selection_request): When sending hint, ceiling it at
1299 X_LONG_MAX rather than relying on wraparound overflow to send
1300 something.
1301 (x_get_window_property, receive_incremental_selection)
1302 (lisp_data_to_selection_data, x_property_data_to_lisp):
1303 Check for size-calculation overflow.
1304 (x_get_window_property, receive_incremental_selection)
1305 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1306 Don't store size until memory allocation succeeds.
1307 (x_get_window_property): Plug memory leak on memory exhaustion.
1308 Don't double-block input; malloc is safe here. Don't assume 2**34
1309 - 4 fits in unsigned long. Add an xassert to check
1310 XGetWindowProperty overflow. Be more careful about overflow
1311 calculations, and distinguish size from memory overflow better.
1312 (receive_incremental_selection): When tracing, don't assume
1313 unsigned int is less than INT_MAX.
1314 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1315 harmful) conversions of unsigned short to int.
1316 (lisp_data_to_selection_data): Don't assume that integers
1317 in the range -65535 through -1 fit in an X unsigned short.
1318 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1319 result parameters unless successful. Rely on cons_to_unsigned
1320 to report problems with elements; the old code wasn't right anyway.
1321 (x_check_property_data): Check for int overflow; we cannot use
1322 a wider type due to X limits.
1323 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1324
1325 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1326
1327 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1328 (x_term_init): Check for size calculation overflow.
1329 (x_color_cells): Don't store size until memory allocation succeeds.
1330 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1331 Don't assume alloca size is less than MAX_ALLOCA.
1332 (x_term_init): Don't assume length fits in int (sprintf is limited
1333 to int size).
1334
1335 Use ptrdiff_t for composition IDs.
1336 * character.c (lisp_string_width):
1337 * composite.c (composition_table_size, n_compositions)
1338 (get_composition_id, composition_gstring_from_id):
1339 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1340 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1341 * window.c (Frecenter):
1342 Use ptrdiff_t, not int, for composition IDs.
1343 * composite.c (get_composition_id): Check for integer overflow.
1344 * composite.h: Adjust prototypes to match the above changes.
1345
1346 Use ptrdiff_t for hash table indexes.
1347 * category.c (hash_get_category_set):
1348 * ccl.c (ccl_driver):
1349 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1350 * coding.c (coding_system_charset_list, detect_coding_system):
1351 * coding.h (struct coding_system.id):
1352 * composite.c (get_composition_id, gstring_lookup_cache):
1353 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1354 * image.c (xpm_get_color_table_h):
1355 * lisp.h (hash_lookup, hash_put):
1356 * minibuf.c (Ftest_completion):
1357 Use ptrdiff_t for hash table indexes, not int (which is too
1358 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1359 32-bit --with-wide-int hosts).
1360
1361 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1362 Add a FIXME comment about memory leaks.
1363 (syms_of_charset): Don't assume xmalloc returns.
1364
1365 Don't assume that stated character widths fit in int.
1366 * character.c (Fchar_width, c_string_width, lisp_string_width):
1367 * character.h (CHAR_WIDTH):
1368 * indent.c (MULTIBYTE_BYTES_WIDTH):
1369 Use sanitize_char_width to avoid undefined and/or bad behavior
1370 with outlandish widths.
1371 * character.h (sanitize_tab_width): Rename from sanitize_width,
1372 now that we have two such functions. All uses changed.
1373 (sanitize_char_width): New inline function.
1374
1375 Don't assume that tab-width fits in int.
1376 * character.h (sanitize_width): New inline function.
1377 (SANE_TAB_WIDTH): New macro.
1378 (ASCII_CHAR_WIDTH): Use it.
1379 * indent.c (sane_tab_width): Remove. All uses replaced by
1380 SANE_TAB_WIDTH (current_buffer).
1381 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1382
1383 * fileio.c: Integer overflow issues with file modes.
1384 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1385
1386 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1387 Remove unreachable code.
1388 (read_hex, load_charset_map_from_file): Check for integer overflow.
1389
1390 * xterm.c: don't go over XClientMessageEvent limit
1391 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1392 (x_send_scroll_bar_event): Likewise. Check that the size does not
1393 exceed limits imposed by XClientMessageEvent, as well as the usual
1394 ptrdiff_t and size_t limits.
1395
1396 * keyboard.c: Overflow, signedness and related fixes.
1397 (make_lispy_movement): Use same integer type in forward decl
1398 that is used in the definition.
1399 (read_key_sequence, keyremap_step):
1400 Change bufsize argument back to int, undoing my 2011-03-30 change.
1401 We prefer signed types, and int is wide enough here.
1402 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1403 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1404 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1405 length, not size_t. Use ptrdiff_t for index, not int.
1406 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1407 possibility of integer overflow.
1408
1409 Overflow, signedness and related fixes for images.
1410
1411 * dispextern.h (struct it.stack[0].u.image.image_id)
1412 (struct_it.image_id, struct image.id, struct image_cache.size)
1413 (struct image_cache.used, struct image_cache.ref_count):
1414 * gtkutil.c (update_frame_tool_bar):
1415 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1416 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1417 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1418 * nsmenu.m (update_frame_tool_bar):
1419 * xdisp.c (calc_pixel_width_or_height):
1420 * xfns.c (image_cache_refcount):
1421 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1422 on typical 64-bit hosts.
1423
1424 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1425 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1426 Omit unnecessary casts to int.
1427 (parse_image_spec): Check that integers fall into 'int' range
1428 when the callers expect that.
1429 (image_ascent): Redo ascent calculation to avoid int overflow.
1430 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1431 (lookup_image): Remove unnecessary tests.
1432 (xbm_image_p): Locals are now of int, not EMACS_INT,
1433 since parse_image_check makes sure they fit into int.
1434 (png_load, gif_load, svg_load_image):
1435 Prefer int to unsigned where either will do.
1436 (tiff_handler): New function, combining the cores of the
1437 old tiff_error_handler and tiff_warning_handler.
1438 This function is rewritten to use vsnprintf and thereby avoid
1439 stack buffer overflows. It uses only the features of vsnprintf
1440 that are common to both POSIX and native Microsoft.
1441 (tiff_error_handler, tiff_warning_handler): Use it.
1442 (tiff_load, gif_load, imagemagick_load_image):
1443 Don't assume :index value fits in 'int'.
1444 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1445 (imagemagick_load_image): Check that crop parameters fit into
1446 the integer types that MagickCropImage accepts. Don't assume
1447 Vimagemagick_render_type has a nonnegative value. Don't assume
1448 size_t fits in 'long'.
1449 (gs_load): Use printmax_t to print the widest integers possible.
1450 Check for integer overflow when computing image height and width.
1451
1452 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1453
1454 * xdisp.c (redisplay_window): Don't force window start if point
1455 will be invisible in the resulting window. (Bug#9324)
1456
1457 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1458
1459 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1460 the display spec is of the form `(space ...)'.
1461 (handle_display_spec): Return the value returned by
1462 handle_single_display_spec, not just 1 or zero.
1463 (handle_single_display_spec): If the display spec is of the form
1464 `(space ...)', and specifies display in the text area, return 2
1465 rather than 1.
1466 (try_cursor_movement): Check for the need to scroll more
1467 accurately, and prefer exact match for point under bidi.
1468 Don't advance `row' beyond the last row of the window.
1469
1470 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1471 into disp_prop; all users changed.
1472
1473 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1474 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1475 for the text covered by the display property.
1476
1477 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1478
1479 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1480 Change return value to nil.
1481 (Frecord_buffer): Delete unused function.
1482
1483 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1484
1485 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1486 buffers, return left-to-right.
1487 (set_cursor_from_row): Consider candidate row a win if its glyph
1488 represents a newline and point is on that newline. Fixes cursor
1489 positioning on the newline at EOL of R2L text within L2R
1490 paragraph, and vice versa.
1491 (try_cursor_movement): Check continued rows, in addition to
1492 continuation rows. Fixes unwarranted scroll when point enters a
1493 continued line of R2L text within an L2R paragraph, or vice versa.
1494 (cursor_row_p): Consider the case of point being equal to
1495 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1496 from the end of a short line to the beginning of a continued line
1497 of R2L text within L2R paragraph.
1498 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1499 composed characters.
1500
1501 * bidi.c (bidi_check_type): Use xassert.
1502 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1503 members.
1504
1505 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1506
1507 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1508 a character.
1509
1510 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1511
1512 * nsfont.m (ns_otf_to_script): Fix typo.
1513
1514 2011-08-22 Kenichi Handa <handa@m17n.org>
1515
1516 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1517 extra slot even if the purpose is char-code-property-table.
1518
1519 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1520
1521 * xdisp.c (redisplay_window): When computing centering_position,
1522 account for the height of the header line. (Bug#8874)
1523
1524 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1525 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1526 candidate is selected by the mouse, and that candidate has a
1527 composed character under the mouse.
1528
1529 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1530 coordinates reported by pos-visible-in-window-p for a composed
1531 character in column zero.
1532
1533 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1534
1535 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1536
1537 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1538
1539 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1540 consider it a hit if to_charpos is anywhere in the range of the
1541 composed buffer positions.
1542
1543 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1544
1545 * image.c (gif_load): Don't assume that each subimage has the same
1546 dimensions as the base image. Handle disposal method that is
1547 "undefined" by the gif spec (Bug#9335).
1548
1549 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1550
1551 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1552 (Fcondition_case): Document `debug' symbol in error handler.
1553
1554 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1555
1556 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1557 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1558 from an Org mode buffer to a Speedbar frame.
1559
1560 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1561 a composition, take its buffer position from IT->cmp_it.charpos.
1562 Fixes cursor positioning at the beginning of a line that begins
1563 with a composed character.
1564
1565 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1566
1567 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1568 character bidirectional type, use STRONG_L instead. Fixes crashes
1569 in a buffer produced by `describe-categories'.
1570
1571 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1572 members before the level stack, so they would be saved and
1573 restored when copying iterator state. Fixes incorrect reordering
1574 around TABs covered by display properties.
1575
1576 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1577
1578 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1579
1580 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1581
1582 * eval.c (internal_condition_case, internal_condition_case_1)
1583 (internal_condition_case_2, internal_condition_case_n):
1584 Remove unnecessary aborts (Bug#9081).
1585
1586 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1587
1588 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1589 has no `load' handler, try opening the file locally. (Bug#9311)
1590
1591 2011-08-16 Ken Brown <kbrown@cornell.edu>
1592
1593 * gmalloc.c: Expand comment.
1594
1595 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1596
1597 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1598 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1599
1600 2011-08-16 Ken Brown <kbrown@cornell.edu>
1601
1602 Fix memory allocation problems in Cygwin build (Bug#9273).
1603
1604 * unexcw.c ( __malloc_initialized): Declare external variable.
1605 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1606
1607 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1608 New variables.
1609 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1610 dumped emacs.
1611 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1612 in the static heap.
1613 [CYGWIN] (special_realloc): New function.
1614 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1615 requests to realloc storage in the static heap.
1616
1617 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1618
1619 * bidi.c (bidi_initialize): Remove unused local.
1620
1621 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1622
1623 * bidimirror.h:
1624 * biditype.h: Remove file.
1625 * makefile.w32-in ($(BLD)/bidi.$(O)):
1626 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1627
1628 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1629
1630 * chartab.c: Improve commentary for the uniprop_table API.
1631
1632 * bidi.c (bidi_paragraph_init): Support zero value of
1633 bidi_ignore_explicit_marks_for_paragraph_level.
1634 (bidi_initialize): Use uniprop_table instead of including
1635 biditype.h and bidimirror.h.
1636
1637 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1638 coordinates of the iterator when restoring from ppos_it.
1639 (Bug#9296)
1640
1641 2011-08-14 Kenichi Handa <handa@m17n.org>
1642
1643 * process.c (create_process): Call setup_process_coding_systems
1644 after the pid of the process is set to -1 (Bug#8162).
1645
1646 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1647
1648 * xdisp.c (move_it_in_display_line_to): Don't invoke
1649 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1650 ppos_it. Fixes vertical cursor motion when line beginning is
1651 covered by an image. (Bug#9296)
1652
1653 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1654
1655 * nsterm.h (ns_run_ascript): Declare.
1656 (NSAPP_DATA2_RUNASSCRIPT): Define.
1657
1658 * nsfns.m (as_script, as_result, as_status): New static variables.
1659 (ns_run_ascript): New function.
1660 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1661 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1662 the event loop. Get status from as_status (Bug#7276).
1663
1664 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1665 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1666 the event loop (Bug#7276).
1667
1668 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1669
1670 * gnutls.c (QCgnutls_bootprop_priority)
1671 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1672 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1673 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1674 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1675 (QCgnutls_bootprop_verify_hostname_error)
1676 (QCgnutls_bootprop_callbacks_verify): Rename from
1677 Qgnutls_bootprop_..., all uses changed.
1678
1679 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1680 uses changed.
1681
1682 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1683
1684 * xfaces.c (Qframe_set_background_mode): Now static.
1685 * dispextern.h (Qframe_set_background_mode): Remove decl.
1686
1687 * process.c (Fnetwork_interface_info): Declare local only if needed.
1688
1689 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1690
1691 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1692 (Fnetwork_interface_list): Allocate in increments of bytes instead
1693 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1694 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1695 sockaddr.
1696 (struct ifflag_def): notrailers is smart on OSX.
1697 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1698 Get hardware address with getifaddrs if available.
1699
1700 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1701
1702 * xdisp.c (iterate_out_of_display_property): xassert that
1703 IT->position is set to within IT->object's boundaries. Break from
1704 the loop as soon as EOB is reached; avoids infloops in redisplay
1705 when IT->position is set up wrongly due to some bug.
1706 Set IT->current to match the bidi iterator unconditionally.
1707 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1708 entry. Force push_it to save on the stack the current
1709 buffer/string position, to be restored by pop_it. Fix flags in
1710 the iterator structure wrt the object coming from a display
1711 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1712 properties. (Bug#9284)
1713
1714 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1715
1716 * fontset.c (fontset_get_font_group): Add proper type checks.
1717 (Bug#9172)
1718
1719 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1720
1721 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1722 and LC_VERSION_MIN_MACOSX.
1723 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1724 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1725
1726 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1727
1728 * xdisp.c (forward_to_next_line_start): Allow to use the
1729 no-display-properties-and-no-overlays under bidi display.
1730 Set disp_pos in the bidi iterator to avoid searches for display
1731 properties and overlays.
1732
1733 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1734
1735 * editfns.c (Fset_time_zone_rule): Document relationship with the
1736 setenv function.
1737
1738 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1739 the font entity extracted from the cache (Bug#8109).
1740
1741 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1742
1743 * composite.c (autocmp_chars): Don't reset point. That is done by
1744 restore_point_unwind (Bug#5984).
1745
1746 2011-08-07 Juri Linkov <juri@jurta.org>
1747
1748 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1749 to show the arg `TIME' instead of `TIMEVAL'.
1750
1751 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1752
1753 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1754 display property strides EOL and includes a newline, as in
1755 longlines-mode. (Bug#9254)
1756 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1757 word-wrap under bidirectional display. (Bug#9224)
1758
1759 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1760 is non-zero, even if the data buffer is NULL. Fixes a crash in
1761 vertical-motion with longlines-mode. (Bug#9254)
1762
1763 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1764
1765 * bidi.c <bidi_cache_total_alloc>: Now static.
1766 (bidi_initialize): Initialize bidi_cache_total_alloc.
1767
1768 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1769 cache. (Bug#9221)
1770
1771 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1772 amount allocated this far in `bidi_cache_total_alloc'.
1773 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1774 non-zero, only free the data buffer without restoring the cache
1775 contents. All callers changed.
1776
1777 * dispextern.h (bidi_unshelve_cache): Update prototype.
1778
1779 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1780 (move_it_in_display_line, move_it_to)
1781 (move_it_vertically_backward, move_it_by_lines): Replace the call
1782 to xfree to an equivalent call to bidi_unshelve_cache.
1783 (move_it_in_display_line_to): Fix logic of returning
1784 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1785
1786 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1787
1788 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1789 came from a string character with a `cursor' property. (Bug#9229)
1790
1791 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1792
1793 * Makefile.in (LIB_PTHREAD): New variable.
1794 (LIBES): Add LIB_PTHREAD (Bug#9216).
1795
1796 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1797 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1798
1799 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1800
1801 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1802
1803 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1804
1805 * xterm.c (x_find_topmost_parent): New function.
1806 (x_set_frame_alpha): Find topmost parent window with
1807 x_find_topmost_parent and set the property there also (bug#9181).
1808 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1809
1810 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 * callproc.c (Fcall_process): Avoid vfork clobbering
1813 the local vars buffer, coding_systems, current_dir.
1814
1815 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1816
1817 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1818
1819 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1820
1821 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1822 so that it is not optimized away.
1823
1824 * xdisp.c (compute_display_string_pos): Remove unused local.
1825
1826 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1827
1828 Fix slow cursor motion and scrolling in large buffers with
1829 selective display, like Org Mode buffers. (Bug#9218)
1830
1831 * dispextern.h (struct bidi_it): New member disp_prop_p.
1832
1833 * xdisp.c: Remove one-slot cache of display string positions.
1834 (compute_display_string_pos): Accept an additional argument
1835 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1836 for a display string or property. If found, set DISP_PROP_P
1837 non-zero.
1838
1839 * bidi.c (bidi_fetch_char): Accept an additional argument
1840 DISP_PROP_P, and pass it to compute_display_string_pos.
1841 Only handle text covered by a display string if DISP_PROP_P is returned
1842 non-zero. All callers of bidi_fetch_char changed.
1843
1844 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1845
1846 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1847
1848 2010-12-03 Don March <don@ohspite.net>
1849
1850 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1851 last character M-[char] is translated to ESC [char] (bug#7541).
1852
1853 2011-08-02 Kenichi Handa <handa@m17n.org>
1854
1855 * lisp.h (uniprop_table): Extern it.
1856
1857 * chartab.c (uniprop_table): Make it non-static.
1858
1859 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1860
1861 * xdisp.c (forward_to_next_line_start): Accept additional argument
1862 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1863 on the newline.
1864 (reseat_at_next_visible_line_start): Use the bidi iterator state
1865 returned by forward_to_next_line_start to restore the state of
1866 it->bidi_it after backing up to previous newline. (Bug#9212)
1867
1868 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1869
1870 * regex.c (re_comp): Protoize.
1871 (re_exec): Fix return type.
1872 (regexec): Fix type of `ret'. (Bug#9203)
1873
1874 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1875
1876 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1877 This is needed if max-image-size is a floating-point number.
1878
1879 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1880
1881 * print.c (print_object): Print empty symbol as ##.
1882
1883 * lread.c (read1): Read ## as empty symbol.
1884
1885 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1886
1887 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1888 setting frame foreground color (Bug#9175).
1889 (x_set_background_color): Likewise.
1890
1891 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1892 contents (Bug#9176).
1893 (EmacsTooltip -init): Remove bezels and add shadows to
1894 tooltip windows.
1895
1896 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1897 or scroll bar (Bug#8470).
1898
1899 * nsfont.m (nsfont_open): Remove assignment to voffset and
1900 unnecessary vars hshink, expand, hd, full_height, min_height.
1901 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1902
1903 * nsterm.h (nsfont_info): Remove voffset field.
1904
1905 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1906
1907 Implement strike-through and overline on NextStep (Bug#8863).
1908
1909 * nsfont.m (nsfont_open): Use underline position provided by font,
1910 instead of hard-coded value of 2.
1911 (nsfont_draw): Call ns_draw_text_decoration instead.
1912
1913 * nsterm.h: Add declaration for ns_draw_text_decoration.
1914
1915 * nsterm.m (ns_draw_text_decoration): New function for drawing
1916 underline, overline, and strike-through.
1917 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1918 ns_draw_text_decoration. Change treatment of cursor drawing to
1919 accommodate underlining, etc.
1920
1921 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1922
1923 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1924 default.
1925
1926 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1929 Without this fix, if a signal arrives just after memory fills up,
1930 'malloc' might be invoked reentrantly.
1931
1932 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1933 In other words, assume that every image size is allowed, on non-X
1934 hosts. This assumption is probably wrong, but it lets Emacs compile.
1935
1936 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1937
1938 * regex.c (re_iswctype): Convert return values to boolean.
1939
1940 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1941
1942 * xdisp.c (compute_display_string_pos): Don't use cached display
1943 string position if the buffer had its restriction changed.
1944 (Bug#9184)
1945
1946 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1947
1948 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1949
1950 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 Integer signedness and overflow and related fixes. (Bug#9079)
1953
1954 * bidi.c: Integer size and overflow fixes.
1955 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1956 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1957 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1958 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1959 (bidi_find_other_level_edge):
1960 Use ptrdiff_t instead of EMACS_INT where either will do.
1961 This works better on 32-bit hosts configured --with-wide-int.
1962 (bidi_cache_ensure_space): Check for size-calculation overflow.
1963 Use % rather than repeated addition, for better worst-case speed.
1964 Don't set bidi_cache_size until after xrealloc returns, because it
1965 might not return.
1966 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1967 (bidi_cache_ensure_space): Also check that the bidi cache size
1968 does not exceed that of the largest Lisp string or buffer. See Eli
1969 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1970
1971 * alloc.c (__malloc_size_t): Remove.
1972 All uses replaced by size_t. See Andreas Schwab's note
1973 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1974
1975 * image.c: Improve checking for integer overflow.
1976 (check_image_size): Assume that f is nonnull, since
1977 it is always nonnull in practice. This is one less thing to
1978 worry about when checking for integer overflow later.
1979 (x_check_image_size): New function, which checks for integer
1980 overflow issues inside X.
1981 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1982 This removes the need for a memory_full check.
1983 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1984 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1985 (xbm_read_bitmap_data): Change locals back to 'int', since
1986 their values must fit in 'int'.
1987 (xpm_load_image, png_load, tiff_load):
1988 Invoke x_create_x_image_and_pixmap earlier,
1989 to avoid much needless work if the image is too large.
1990 (tiff_load): Treat overly large images as if
1991 x_create_x_image_and_pixmap failed, not as malloc failures.
1992 (gs_load): Use x_check_image_size.
1993
1994 * gtkutil.c: Omit integer casts.
1995 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1996 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1997
1998 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1999
2000 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2001 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2002 would wrongly return t on a 64-bit host.
2003
2004 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2005 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2006 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2007 and therefore cause GCC to emit a bogus diagnostic in some cases.
2008
2009 * image.c: Integer signedness and overflow and related fixes.
2010 This is not an exhaustive set of fixes, but it's time to
2011 record what I've got.
2012 (lookup_pixel_color, check_image_size): Remove redundant decls.
2013 (check_image_size): Don't assume that arbitrary EMACS_INT values
2014 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2015 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2016 (tiff_load, imagemagick_load_image):
2017 Check for overflow in size calculations.
2018 (x_create_x_image_and_pixmap): Remove unnecessary test for
2019 xmalloc returning NULL; that can't happen.
2020 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2021 (xpm_color_bucket): Use better integer hashing function.
2022 (xpm_cache_color): Don't possibly over-allocate memory.
2023 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2024 (gif_memory_source):
2025 Use ptrdiff_t, not int or size_t, to record sizes.
2026 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2027 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2028 either works, as we prefer signed integers.
2029 (tiff_read_from_memory, tiff_write_from_memory):
2030 Return tsize_t, not size_t, since that's what the TIFF API wants.
2031 (tiff_read_from_memory): Don't fail simply because the read would
2032 go past EOF; instead, return a short read.
2033 (tiff_load): Omit no-longer-needed casts.
2034 (Fimagemagick_types): Don't assume size fits into 'int'.
2035
2036 Improve hashing quality when configured --with-wide-int.
2037 * fns.c (hash_string): New function, taken from sxhash_string.
2038 Do not discard information about ASCII character case; this
2039 discarding is no longer needed.
2040 (sxhash-string): Use it. Change sig to match it. Caller changed.
2041 * lisp.h: Declare it.
2042 * lread.c (hash_string): Remove, since we now use fns.c's version.
2043 The fns.c version returns a wider integer if --with-wide-int is
2044 specified, so this should help the quality of the hashing a bit.
2045
2046 * emacs.c: Integer overflow minor fix.
2047 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2048 Define only if GNU_LINUX.
2049 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2050
2051 * dispnew.c: Integer signedness and overflow fixes.
2052 Remove unnecessary forward decls, that were a maintenance hassle.
2053 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2054 All uses changed.
2055 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2056 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2057 (prepare_desired_row, line_draw_cost):
2058 Use int, not unsigned, where either works.
2059 (save_current_matrix, restore_current_matrix):
2060 Use ptrdiff_t, not size_t, where either works.
2061 (init_display): Check for overflow more accurately, and without
2062 relying on undefined behavior.
2063
2064 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2065 Remove, replacing with the new symbols in lisp.h. All uses changed.
2066 * fileio.c (make_temp_name):
2067 * filelock.c (lock_file_1, lock_file):
2068 * xdisp.c (message_dolog):
2069 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2070 Use pMd etc. instead.
2071 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2072 replacing the pWIDE etc. symbols removed from editfns.c.
2073
2074 * keyboard.h (num_input_events): Now uintmax_t.
2075 This is (very slightly) less likely to mess up due to wraparound.
2076 All uses changed.
2077
2078 * buffer.c: Integer signedness fixes.
2079 (alloc_buffer_text, enlarge_buffer_text):
2080 Use ptrdiff_t rather than size_t when either will do, as we prefer
2081 signed integers.
2082
2083 * alloc.c: Integer signedness and overflow fixes.
2084 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2085 (__malloc_size_t): Default to size_t, not to int.
2086 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2087 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2088 Prefer ptrdiff_t to size_t when either would do, as we prefer
2089 signed integers.
2090 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2091 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2092 Now const. Initialize with values that are in range even if char
2093 is signed.
2094 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2095 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2096 These functions do the right thing with sizes > 2**32.
2097 (check_depth): Now ptrdiff_t, not int.
2098 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2099 Adjust to new way of storing sizes. Check for size overflow bugs
2100 in rest of code.
2101 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2102 slightly wrong anyway, as it missed one instance of
2103 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2104 (refill_memory_reserve): Omit needless cast to size_t.
2105 (mark_object_loop_halt): Mark as externally visible.
2106
2107 * xselect.c: Integer signedness and overflow fixes.
2108 (Fx_register_dnd_atom, x_handle_dnd_message):
2109 Use ptrdiff_t, not size_t, since we prefer signed.
2110 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2111 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2112 x_dnd_atoms_size and x_dnd_atoms_length.
2113
2114 * doprnt.c: Prefer signed to unsigned when either works.
2115 * eval.c (verror):
2116 * doprnt.c (doprnt):
2117 * lisp.h (doprnt):
2118 * xdisp.c (vmessage):
2119 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2120 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2121 prefer signed arithmetic to avoid comparison confusion.
2122 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2123 but is a bit tricky.
2124
2125 Assume freestanding C89 headers, string.h, stdlib.h.
2126 * data.c, doprnt.c, floatfns.c, print.c:
2127 Include float.h unconditionally.
2128 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2129 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2130 * regex.c: Likewise for stddef.h, string.h.
2131 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2132 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2133 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2134 (STDC_HEADERS): Remove obsolete defines.
2135 * sysdep.c: Include limits.h unconditionally.
2136
2137 Assume support for memcmp, memcpy, memmove, memset.
2138 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2139 * regex.c (memcmp, memcpy):
2140 Remove; we assume C89 now.
2141
2142 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2143 (__malloc_safe_bcopy): Remove; no longer needed.
2144
2145 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2146 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2147 well either way, and we prefer signed to unsigned.
2148
2149 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2150
2151 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2152 closes the connection while we're reading (bug#9182).
2153
2154 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2155
2156 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2157 are specified (Bug#9168).
2158
2159 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2160
2161 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2162 Found by GCC static checking and --with-wide-int on a 32-bit host.
2163
2164 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2165
2166 * xdisp.c (compute_display_string_pos): Fix logic of caching
2167 previous display string position. Initialize cached_prev_pos to
2168 -1. Fixes slow-down at the beginning of a buffer.
2169
2170 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2171
2172 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2173 for attrs[LFACE_FONTSET_INDEX].
2174
2175 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2176
2177 * xml.c (parse_region): Remove unused local
2178 that was recently introduced.
2179
2180 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2181
2182 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2183 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2184
2185 * xdisp.c (move_it_in_display_line_to): Record the best matching
2186 position for TO_CHARPOS while scanning the line, and restore it on
2187 exit if none of the characters scanned was an exact match.
2188 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2189 when exact match is impossible due to invisible text, and the
2190 lines are truncated.
2191
2192 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2193
2194 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2195 for OSX >= 10.7.
2196
2197 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2198
2199 Fix a significant slow-down of cursor motion with C-n, C-p,
2200 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2201 auto-repeat under bidi redisplay in fontified buffers.
2202 * xdisp.c (compute_stop_pos_backwards): New function.
2203 (next_element_from_buffer): Call compute_stop_pos_backwards to
2204 find a suitable prev_stop when we find ourselves before
2205 base_level_stop.
2206 (reseat): Don't look for prev_stop, as that could mean a very long
2207 run.
2208 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2209 <cached_disp_overlay_modiff>: Cache for last found display string
2210 position.
2211 (compute_display_string_pos): Return the cached position if asked
2212 about the same buffer in the same area of character positions, and
2213 the buffer wasn't changed since the time the display string
2214 position was cached.
2215
2216 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2219 is an integer, which is important for empty lines. (Bug#9149)
2220
2221 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2222
2223 * frame.c (Fmodify_frame_parameters): In tty case, update the
2224 default face if necessary (Bug#4238).
2225
2226 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2227
2228 * editfns.c (Fstring_to_char): No need to explain what a character
2229 is in the docstring (Bug#6576).
2230
2231 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2232
2233 * xml.c (parse_region): Make sure we always return a tree.
2234
2235 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2236
2237 * xml.c (parse_region): If a document contains only comments,
2238 return that, too.
2239
2240 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2241
2242 * xml.c (make_dom): Return comments, too.
2243
2244 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2245
2246 Port to OpenBSD.
2247 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2248 and the surrounding thread.
2249 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2250 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2251 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2252 timer goes off.
2253 * s/openbsd.h (BROKEN_SIGIO): Define.
2254 * unexelf.c (unexec) [__OpenBSD__]:
2255 Don't update the .mdebug section of the Alpha COFF symbol table.
2256
2257 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2258
2259 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2260 (bug#8460).
2261
2262 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2263
2264 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2265 This fixes some race conditions on the permissions of any newly
2266 created file.
2267
2268 * alloc.c (valid_pointer_p): Use pipe, not open.
2269 This fixes some permissions issues when debugging.
2270
2271 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2272 If fchown fails to set both uid and gid, try to set just gid,
2273 as that is sometimes allowed. Adjust the file's mode to eliminate
2274 setuid or setgid bits that are inappropriate if fchown fails.
2275
2276 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2277
2278 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2279 to compare Lisp_Objects.
2280 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2281 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2282 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2283
2284 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2285
2286 * lread.c (read_integer): Unread even EOF character.
2287 (read1): Likewise. Properly record start position of symbol.
2288
2289 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2290 symbol character follows.
2291
2292 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2293
2294 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2295 This works around a problem with the previous change to Fcopy_file.
2296 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2297 and without this change, GCC might complain about discarding
2298 fchown's return value.
2299
2300 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2301
2302 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2303
2304 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2305
2306 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2307
2308 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2309
2310 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2311 it's used from the C level.
2312
2313 * process.c: Use the same condition for POLL_FOR_INPUT in both
2314 keyboard.c and process.c (bug#1858).
2315
2316 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2317
2318 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2319 (Fgnutls_boot): Use it.
2320
2321 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2322
2323 * doc.c (Fsubstitute_command_keys): Revert last change.
2324
2325 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2326
2327 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2328 quotes the next character, and doesn't affect other longer
2329 sequences (bug#8935).
2330
2331 * lread.c (syms_of_lread): Clarify that is isn't only
2332 `eval-buffer' and `eval-defun' that's affected by
2333 `lexical-binding' (bug#8460).
2334
2335 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2336
2337 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2338 bidi redisplay when a line includes both an image and is truncated.
2339
2340 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2341
2342 Fix minor problems found by static checking.
2343 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2344 (elsz): Now a signed constant, not a size_t var. We prefer signed
2345 types to unsigned, to avoid integer comparison confusion. Without
2346 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2347 "cannot optimize loop, the loop counter may overflow", a symptom
2348 of the confusion.
2349 * indent.c (Fvertical_motion): Mark locals as initialized.
2350 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2351
2352 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2353
2354 * search.c (Fre_search_backward): Mention `case-fold-search' in
2355 all the re_search_* functions (bug#8138).
2356
2357 * keyboard.c (Fopen_dribble_file): Document when the file is
2358 closed (bug#8056).
2359
2360 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2361
2362 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2363 bidi_cache_idx.
2364
2365 Support bidi reordering of display and overlay strings.
2366 * xdisp.c (compute_display_string_pos)
2367 (compute_display_string_end): Accept additional argument STRING.
2368 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2369 (reseat_to_string): Initialize bidi_it->string.s and
2370 bidi_it->string.schars.
2371 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2372 NULL (avoids a crash in bidi_paragraph_init).
2373 Initialize itb.string.lstring.
2374 (init_iterator): Call bidi_init_it only of a valid
2375 buffer position was specified. Initialize paragraph_embedding to
2376 L2R.
2377 (reseat_to_string): Initialize the bidi iterator.
2378 (display_string): If we need to ignore text properties of
2379 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2380 original value of -1 will not work with bidi.)
2381 (compute_display_string_pos): First arg is now struct
2382 `text_pos *'; all callers changed. Support display properties on
2383 Lisp strings.
2384 (compute_display_string_end): Support display properties on Lisp
2385 strings.
2386 (init_iterator, reseat_1, reseat_to_string): Initialize the
2387 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2388 when iterating on a string not from display properties).
2389 (compute_display_string_pos, compute_display_string_end):
2390 Fix calculation of the object to scan. Fixes an error when using
2391 arrow keys.
2392 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2393 base_level_stop; instead, set base_level_stop to BEGV.
2394 Fixes crashes in vertical-motion.
2395 (next_element_from_buffer): Improve commentary for when
2396 the iterator is before prev_stop.
2397 (init_iterator): Initialize bidi_p from the default value of
2398 bidi-display-reordering, not from buffer-local value. Use the
2399 buffer-local value only if initializing for buffer iteration.
2400 (handle_invisible_prop): Support invisible properties on strings
2401 that are being bidi-reordered.
2402 (set_iterator_to_next): Support bidi reordering of C strings and
2403 Lisp strings.
2404 (next_element_from_string): Support bidi reordering of Lisp
2405 strings.
2406 (handle_stop_backwards): Support Lisp strings as well.
2407 (display_string): Support display of R2L glyph rows.
2408 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2409 (init_iterator): Don't initialize it->bidi_p for strings
2410 here.
2411 (reseat_to_string): Initialize it->bidi_p for strings here.
2412 (next_element_from_string, next_element_from_c_string)
2413 (next_element_from_buffer): Add xassert's for correspondence
2414 between IT's object being iterated and it->bidi_it.string
2415 structure.
2416 (face_before_or_after_it_pos): Support bidi iteration.
2417 (next_element_from_c_string): Handle the case of the first string
2418 character that is not the first one in the visual order.
2419 (get_visually_first_element): New function, refactored from common
2420 parts of next_element_from_buffer, next_element_from_string, and
2421 next_element_from_c_string.
2422 (tool_bar_lines_needed, redisplay_tool_bar)
2423 (display_menu_bar): Force left-to-right direction. Add a FIXME
2424 comment for making that be controlled by a user option.
2425 (push_it, pop_it): Save and restore the state of the
2426 bidi iterator. Save and restore the bidi_p flag.
2427 (pop_it): Iterate out of display property for string iteration as
2428 well.
2429 (iterate_out_of_display_property): Support iteration over strings.
2430 (handle_single_display_spec): Set up it->bidi_it for iteration
2431 over a display string, and call bidi_init_it.
2432 (handle_single_display_spec, next_overlay_string)
2433 (get_overlay_strings_1, push_display_prop): Set up the bidi
2434 iterator for displaying display or overlay strings.
2435 (forward_to_next_line_start): Don't use the shortcut if
2436 bidi-iterating.
2437 (back_to_previous_visible_line_start): If handle_display_prop
2438 pushed the iterator stack, restore the internal state of the bidi
2439 iterator by calling bidi_pop_it same number of times.
2440 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2441 and we are bidi-iterating, don't decrement the iterator position;
2442 instead, set the first_elt flag in the bidi iterator, to produce
2443 the same effect.
2444 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2445 (push_display_prop): xassert that we are iterating a buffer.
2446 (push_it, pop_it): Save and restore paragraph_embedding member.
2447 (handle_single_display_spec, next_overlay_string)
2448 (get_overlay_strings_1, reseat_1, reseat_to_string)
2449 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2450 correctly. Don't assume unibyte strings are not bidi-reordered.
2451 (compute_display_string_pos)
2452 (compute_display_string_end): Fix handling the case of C string.
2453 (push_it, pop_it): Save and restore from_disp_prop_p.
2454 (handle_single_display_spec, push_display_prop): Set the
2455 from_disp_prop_p flag.
2456 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2457 (pop_it): Call iterate_out_of_display_property only if we are
2458 popping after iteration over a string that came from a display
2459 property. Fix a typo in popping stretch info. Add an assertion
2460 for verifying that the iterator position is in sync with the bidi
2461 iterator.
2462 (handle_single_display_spec, get_overlay_strings_1)
2463 (push_display_prop): Fix initialization of paragraph direction for
2464 string when that of the parent object is not yet determined.
2465 (reseat_1): Call bidi_init_it to resync the bidi
2466 iterator with IT's position. (Bug#7616)
2467 (find_row_edges): If ROW->start.pos gives position
2468 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2469 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2470 Reset the from_disp_prop_p flag.
2471 (SAVE_IT, RESTORE_IT): New macros.
2472 (pos_visible_p, face_before_or_after_it_pos)
2473 (back_to_previous_visible_line_start)
2474 (move_it_in_display_line_to, move_it_in_display_line)
2475 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2476 (try_scrolling, redisplay_window, display_line): Use them when
2477 saving a temporary copy of the iterator and restoring it back.
2478 (back_to_previous_visible_line_start, reseat_1)
2479 (init_iterator): Empty the bidi cache "stack".
2480 (move_it_in_display_line_to): If iterator ended up at
2481 EOL, but we never saw any buffer positions smaller than
2482 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2483 motion in bidi-reordered lines.
2484 (move_it_in_display_line_to): Record prev_method and prev_pos
2485 immediately before the call to set_iterator_to_next. Fixes cursor
2486 motion in bidi-reordered lines with stretch glyphs and strings
2487 displayed in margins. (Bug#8133) (Bug#8867)
2488 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2489 TO_CHARPOS.
2490 (pos_visible_p): Support positions in bidi-reordered lines.
2491 Save and restore bidi cache.
2492
2493 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2494 (bidi_paragraph_info): Delete unused struct.
2495 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2496 (bidi_cache_start): New variable.
2497 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2498 to zero.
2499 (bidi_cache_fetch_state, bidi_cache_search)
2500 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2501 (bidi_cache_find, bidi_peek_at_next_level)
2502 (bidi_level_of_next_char, bidi_find_other_level_edge)
2503 (bidi_move_to_visually_next): Compare cache index with
2504 bidi_cache_start rather than with zero.
2505 (bidi_fetch_char): Accept new argument STRING; all callers
2506 changed. Support iteration over a string. Support strings with
2507 display properties. Support unibyte strings. Fix the type of
2508 `len' according to what STRING_CHAR_AND_LENGTH expects.
2509 (bidi_paragraph_init, bidi_resolve_explicit_1)
2510 (bidi_resolve_explicit, bidi_resolve_weak)
2511 (bidi_level_of_next_char, bidi_move_to_visually_next):
2512 Support iteration over a string.
2513 (bidi_set_sor_type, bidi_resolve_explicit_1)
2514 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2515 can now be zero (for strings); special values 0 and -1 were
2516 changed to -1 and -2, respectively.
2517 (bidi_char_at_pos): New function.
2518 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2519 Call it instead of FETCH_MULTIBYTE_CHAR.
2520 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2521 initialized to valid values.
2522 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2523 values.
2524 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2525 the test for valid cached positions. Fix the logic for looking up
2526 the sentinel state in the cache. GCPRO the Lisp string we are
2527 iterating.
2528 (bidi_push_it, bidi_pop_it): New functions.
2529 (bidi_initialize): Initialize the bidi cache start stack pointer.
2530 (bidi_cache_ensure_space): New function, refactored from part of
2531 bidi_cache_iterator_state. Don't assume the required size is just
2532 one BIDI_CACHE_CHUNK away.
2533 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2534 (bidi_count_bytes, bidi_char_at_pos): New functions.
2535 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2536 always valid if bidi_cache_idx is valid.
2537 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2538 is valid if it's going to be used.
2539 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2540 (bidi_cache_fetch_state, bidi_cache_search)
2541 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2542 (bidi_cache_iterator_state, bidi_cache_find)
2543 (bidi_find_other_level_edge, bidi_cache_start_stack):
2544 All variables related to cache indices are now EMACS_INT.
2545
2546 * dispextern.h (struct bidi_string_data): New structure.
2547 (struct bidi_it): New member `string'. Make flag members be 1-bit
2548 fields, and put them last in the struct.
2549 (compute_display_string_pos, compute_display_string_end):
2550 Update prototypes.
2551 (bidi_push_it, bidi_pop_it): Add prototypes.
2552 (struct iterator_stack_entry): New members bidi_p,
2553 paragraph_embedding, and from_disp_prop_p.
2554 (struct it): Member bidi_p is now a bit field 1 bit wide.
2555 (bidi_shelve_cache, bidi_unshelve_cache):
2556 Declare prototypes.
2557
2558 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2559 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2560 and vector-like objects.
2561
2562 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2563 cache around display iteration.
2564
2565 * window.c (Fwindow_end, window_scroll_pixel_based)
2566 (displayed_window_lines, Frecenter): Save and restore the bidi
2567 cache around display iteration.
2568
2569 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2570
2571 * editfns.c (Fdelete_region): Clarify the use of the named
2572 parameters (bug#6788).
2573
2574 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2575
2576 * indent.c (Fvertical_motion): Set and restore w->pointm when
2577 saving and restoring the window's buffer (Bug#9006).
2578
2579 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2580
2581 * editfns.c (Fstring_to_char): Clarify just what is returned
2582 (bug#6576). Text by Eli Zaretskii.
2583
2584 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2585
2586 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2587
2588 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2589
2590 * buffer.c (mmap_find): Fix a typo.
2591
2592 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2593
2594 Fix execution of x selection hooks.
2595 * xselect.c (Qx_lost_selection_functions)
2596 (Qx_sent_selection_functions): New vars.
2597 (syms_of_xselect): DEFSYM them.
2598 (x_handle_selection_request): Pass Qx_sent_selection_functions
2599 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2600 (x_handle_selection_clear,x_clear_frame_selections):
2601 Pass Qx_lost_selection_functions rather than
2602 Vx_lost_selection_functions to Frun_hook_with_args.
2603
2604 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2605
2606 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2607 The old code sometimes used this field without initializing it.
2608
2609 * alloc.c (gc_sweep): Don't read past end of array.
2610 In theory, the old code could also have corrupted Emacs internals,
2611 though it'd be very unlikely.
2612
2613 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2614
2615 * character.c (Fcharacterp): Don't advertise optional ignored
2616 argument. (Bug#4026)
2617
2618 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2619
2620 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2621 key" (bug#4257).
2622
2623 * window.c (Fset_window_start): Doc fix (bug#4199).
2624 (Fset_window_hscroll): Ditto.
2625
2626 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2627
2628 Fix minor new problems caught by GCC 4.6.1.
2629 * term.c (init_tty): Remove unused local.
2630 * xsettings.c (store_monospaced_changed): Define this function only
2631 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2632 not used otherwise.
2633
2634 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2635
2636 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2637
2638 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2639
2640 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2641 are the mini-buffer and the echo area (bug#3320).
2642
2643 * term.c (init_tty): Remove support for supdup, c10 and perq
2644 terminals, which are no longer supported (bug#1482).
2645
2646 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2647
2648 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2649
2650 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2651
2652 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2653 for non-popups (Bug#3642).
2654
2655 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2656
2657 * alloc.c (reset_malloc_hooks): Protoize.
2658 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2659 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2660 * cm.c (losecursor): Likewise.
2661 * data.c (fmod): Likewise.
2662 * dispnew.c (swap_glyphs_in_rows): Likewise.
2663 * emacs.c (memory_warning_signal): Likewise.
2664 * floatfns.c (float_error): Likewise.
2665 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2666 (otf_open, font_otf_capability, generate_otf_features)
2667 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2668 Likewise.
2669 * image.c (pbm_read_file): Likewise.
2670 * indent.c (string_display_width): Likewise.
2671 * intervals.c (check_for_interval, search_for_interval)
2672 (inc_interval_count, count_intervals, root_interval)
2673 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2674 * lread.c (defalias): Likewise.
2675 * ralloc.c (r_alloc_check): Likewise.
2676 * regex.c (set_image_of_range_1, set_image_of_range)
2677 (regex_grow_registers): Likewise.
2678 * sysdep.c (strerror): Likewise.
2679 * termcap.c (valid_filename_p, tprint, main): Likewise.
2680 * tparam.c (main): Likewise.
2681 * unexhp9k800.c (run_time_remap, save_data_space)
2682 (update_file_ptrs, read_header, write_header, calculate_checksum)
2683 (copy_file, copy_rest, display_header): Likewise.
2684 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2685 Likewise.
2686 * xdisp.c (check_it): Likewise.
2687 * xfaces.c (register_color, unregister_color, unregister_colors):
2688 Likewise.
2689 * xfns.c (print_fontset_result): Likewise.
2690 * xrdb.c (member, fatal, main): Likewise.
2691
2692 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2693
2694 Fix minor problems found by static checking (Bug#9031).
2695 * chartab.c (char_table_set_range, map_sub_char_table):
2696 Remove unused locals.
2697 (uniprop_table): Now static.
2698 * composite.c (_work_char): Remove unused static var.
2699
2700 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2701
2702 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2703
2704 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2705
2706 * gtkutil.c (qttip_cb): Remove code without function.
2707
2708 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2709
2710 * w32.c (pthread_sigmask): New stub.
2711
2712 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2713
2714 Use pthread_sigmask, not sigprocmask (Bug#9010).
2715 sigprocmask is portable only for single-threaded applications, and
2716 Emacs can be multi-threaded when it uses GTK.
2717 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2718 (LIBES): Use it.
2719 * callproc.c (Fcall_process):
2720 * process.c (create_process):
2721 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2722 Use pthread_sigmask, not sigprocmask.
2723
2724 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2725
2726 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2727 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2728 wrong (Bug#8591).
2729
2730 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2731
2732 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2733 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2734 (xg_hide_tooltip): Fix comment.
2735
2736 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2737 in registerServicesMenuSendTypes.
2738 (validRequestorForSendType): Don't check ns_return_types.
2739
2740 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2741 ns_return_type.
2742
2743 2011-07-08 Jason Rumney <jasonr@gnu.org>
2744
2745 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2746 frame struct members of non-existent frames (Bug#6284).
2747
2748 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2749
2750 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2751 variable firstTime not needed on OSX >= 10.6.
2752 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2753 >= 10.5. Use setKnobProportion, setDoubleValue.
2754
2755 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2756 (MAC_OS_X_VERSION_10_5): Define if not defined.
2757 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2758 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2759 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2760
2761 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2762 cString and lossyCString on OSX >= 10.4
2763
2764 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2765 sizeToFit on OSX >= 10.2.
2766
2767 * nsimage.m (allocInitFromFile): Don't use deprecated method
2768 bestRepresentationForDevice on OSX >= 10.6.
2769
2770 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2771 to avoid warning.
2772
2773 * emacs.c: Declare unexec_init_emacs_zone.
2774
2775 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2776
2777 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2778
2779 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2780 on svcsMenu (Bug#8842).
2781
2782 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2783 ns_return_types.
2784 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2785
2786 * nsterm.m (QUTF8_STRING): Declare.
2787 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2788 (validRequestorForSendType): Return type is (id).
2789 Change indexOfObjectIdenticalTo to indexOfObject.
2790 Check if we have local selection before returning self (Bug#8842).
2791 (writeSelectionToPasteboard): Put local selection into paste board
2792 if we have a local selection (Bug#8842).
2793 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2794
2795 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2796 (ns_get_local_selection): Declare.
2797
2798 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2799
2800 * keymap.c (describe_map_tree): Don't insert a double newline at
2801 the end of the buffer (bug#1169) and return whether we inserted
2802 something.
2803
2804 * callint.c (Fcall_interactively): Change "reading args" to
2805 "providing args" to try to clarify what it does (bug#1010).
2806
2807 2011-07-07 Kenichi Handa <handa@m17n.org>
2808
2809 * composite.c (composition_compute_stop_pos): Ignore a static
2810 composition starting before CHARPOS (Bug#8915).
2811
2812 * xdisp.c (handle_composition_prop): Likewise.
2813
2814 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2815
2816 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2817 (Bug#9015)
2818
2819 2011-07-07 Kenichi Handa <handa@m17n.org>
2820
2821 * character.h (unicode_category_t): New enum type.
2822
2823 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2824 (Qchar_code_property_table): New variable.
2825 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2826 (UNIPROP_COMPRESSED_FORM_P): New macros.
2827 (char_table_ascii): Uncompress the compressed values.
2828 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2829 Uncompress the compressed values.
2830 (sub_char_table_ref_and_range): Likewise.
2831 (char_table_ref_and_range): Uncompress the compressed values.
2832 (sub_char_table_set): New arg is_uniprop. Callers changed.
2833 Uncompress the compressed values.
2834 (sub_char_table_set_range): Args changed. Callers changed.
2835 (char_table_set_range): Adjuted for the above change.
2836 (map_sub_char_table): Delete args default_val and parent. Add arg
2837 top. Give decoded values to a Lisp function.
2838 (map_char_table): Adjust for the above change. Give decoded
2839 values to a Lisp function. Gcpro more variables.
2840 (uniprop_table_uncompress)
2841 (uniprop_decode_value_run_length): New functions.
2842 (uniprop_decoder, uniprop_decoder_count): New variables.
2843 (uniprop_get_decoder, uniprop_encode_value_character)
2844 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2845 New functions.
2846 (uniprop_encoder, uniprop_encoder_count): New variables.
2847 (uniprop_get_encoder, uniprop_table)
2848 (Funicode_property_table_internal, Fget_unicode_property_internal)
2849 (Fput_unicode_property_internal): New functions.
2850 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2851 Sunicode_property_table_internal, Sget_unicode_property_internal,
2852 and Sput_unicode_property_internal. Defvar_lisp
2853 char-code-property-alist.
2854
2855 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2856 Vunicode_category_table.
2857
2858 * font.c (font_range): Adjust for the change of
2859 Vunicode_category_table.
2860
2861 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2862
2863 * m/iris4d.h: Remove file, move contents ...
2864 * s/irix6-5.h: ... here.
2865
2866 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2867
2868 Remove unportable assumption about struct layout (Bug#8884).
2869 * alloc.c (mark_buffer):
2870 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2871 (clone_per_buffer_values): Don't assume that
2872 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2873 This isn't true in general, and it's particularly not true
2874 if Emacs is configured with --with-wide-int.
2875 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2876 New macros, used in the buffer.c change.
2877
2878 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2879
2880 * xsettings.c: Use both GConf and GSettings if both are available.
2881 (store_config_changed_event): Add comment.
2882 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2883 (store_tool_bar_style_changed): New functions.
2884 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2885 (struct xsettings): Move font inside HAVE_XFT.
2886 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2887 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2888 Move inside HAVE_XFT.
2889 (something_changed_gsettingsCB): Rename from something_changedCB.
2890 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2891 also.
2892 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2893 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2894 (something_changed_gconfCB): Rename from something_changedCB.
2895 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2896 (parse_settings): Move check for font inside HAVE_XFT.
2897 (read_settings, apply_xft_settings): Add comment.
2898 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2899 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2900 call store_font_name_changed.
2901 (xft_settings_event): Add comment.
2902 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2903 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2904 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2905 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2906 (xsettings_initialize): Call init_gsettings last.
2907 (xsettings_get_system_font, xsettings_get_system_normal_font):
2908 Add comment.
2909
2910 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2911
2912 Random fixes. E.g., (random) never returned negative values.
2913 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2914 subseconds part to the entropy, as that's a bit more random.
2915 Prefer signed to unsigned, since the signedness doesn't matter and
2916 in general we prefer signed. When given a limit, use a
2917 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2918 latter isn't right if USE_2_TAGS_FOR_INTS.
2919 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2920 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2921
2922 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2923
2924 * textprop.c (text_property_stickiness):
2925 Obey Vtext_property_default_nonsticky.
2926 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2927 * w32fns.c (syms_of_w32fns):
2928 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2929
2930 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2931
2932 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2933 This is more efficient than Ffile_directory_p and avoids a minor race.
2934
2935 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2936
2937 * buffer.c (Foverlay_put): Say what the return value is
2938 (bug#7835).
2939
2940 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2941 is a directory before asking whether to use the file name
2942 (bug#7564).
2943 (barf_or_query_if_file_exists): Make the "File is a directory"
2944 error be more correct.
2945
2946 * fns.c (Frequire): Remove the mention of the .gz files, since
2947 that's installation-specific, but keep the mention of
2948 `get-load-suffixes'.
2949
2950 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2951
2952 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2953 Report string overflow if the output is too long.
2954
2955 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2956
2957 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2958 (syms_of_gnutls): Remove duplicate DEFSYM for
2959 Qgnutls_bootprop_verify_hostname_error, an error for
2960 Qgnutls_bootprop_verify_error (which is no longer used).
2961
2962 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2963 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2964 Also (re)move comments that are misplaced or no longer relevant.
2965
2966 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2967
2968 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2969
2970 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2971
2972 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2973 and background color parameters if they have been changed.
2974
2975 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2976
2977 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2978
2979 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2980
2981 * xsettings.c (SYSTEM_FONT): Define only when used.
2982 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2983
2984 * keymap.c (access_keymap_1): Now static.
2985
2986 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2987
2988 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2989 leave any prefix arg for the up event (Bug#1586).
2990
2991 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2992
2993 * lread.c (syms_of_lread): Mention single symbols defined by
2994 `defvar' or `defconst' (bug#7154).
2995
2996 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2997 (Frequire): Mention get-load-suffixes.
2998
2999 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3000
3001 * window.h (window): Remove clone_number slot.
3002 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3003 Remove.
3004 (make_parent_window, make_window, saved_window)
3005 (Fset_window_configuration, save_window_save): Don't deal with
3006 clone numbers.
3007 * buffer.c (Qclone_number): Remove declaration.
3008 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3009
3010 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3011
3012 Add multiple inheritance to keymaps.
3013 * keymap.c (Fmake_composed_keymap): New function.
3014 (Fset_keymap_parent): Simplify.
3015 (fix_submap_inheritance): Remove.
3016 (access_keymap_1): New function extracted from access_keymap to handle
3017 embedded parents and handle lists of maps.
3018 (access_keymap): Use it.
3019 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3020 (Fcopy_keymap): Handle embedded parents.
3021 (Fcommand_remapping, define_as_prefix): Simplify.
3022 (Fkey_binding): Simplify.
3023 (syms_of_keymap): Move minibuffer-local-completion-map,
3024 minibuffer-local-filename-completion-map,
3025 minibuffer-local-must-match-map, and
3026 minibuffer-local-filename-must-match-map to Elisp.
3027 (syms_of_keymap): Defsubr make-composed-keymap.
3028 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3029 (parse_menu_item): Trivial simplification.
3030
3031 2011-07-01 Glenn Morris <rgm@gnu.org>
3032
3033 * Makefile.in (SETTINGS_LIBS): Fix typo.
3034
3035 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3036
3037 * coding.c (Fencode_coding_string): Record the last coding system
3038 used, as the function doc string says (bug#8738).
3039
3040 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3041
3042 * xsettings.c (store_monospaced_changed): Take new font as arg and
3043 check for change against current_mono_font.
3044 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3045 (emacs_settings_constructor, emacs_settings_get_property)
3046 (emacs_settings_set_property, emacs_settings_class_init)
3047 (emacs_settings_init, gsettings_obj): Remove.
3048 (something_changedCB): New function for HAVE_GSETTINGS.
3049 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3050 with value as argument.
3051 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3052 g_settings_new (Bug#8967). Do not create gsettings_obj.
3053 Remove calls to g_settings_bind. Connect something_changedCB to
3054 "changed".
3055
3056 * xgselect.c: Add defined (HAVE_GSETTINGS).
3057 (xgselect_initialize): Ditto.
3058
3059 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3060 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3061 xg_select.
3062
3063 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3064
3065 * eval.c (struct backtrace): Simplify and port the data structure.
3066 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3067 signed bit field, as this assumption is not portable and it makes
3068 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3069 "char debug_on_exit : 1" as this is not portable either; instead,
3070 use the portable "unsigned int debug_on_exit : 1". Remove unused
3071 member evalargs. Remove obsolete comments about cc bombing out.
3072
3073 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3074
3075 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3076 Let HAVE_GSETTINGS override HAVE_GCONF.
3077 (store_monospaced_changed): New function.
3078 (EMACS_SETTINGS): A new type derived from GObject to handle
3079 GSettings notifications.
3080 (emacs_settings_constructor, emacs_settings_get_property)
3081 (emacs_settings_set_property, emacs_settings_class_init):
3082 New functions.
3083 (gsettings_client, gsettings_obj): New variables.
3084 (GSETTINGS_SCHEMA): New define.
3085 (something_changedCB): Call store_monospaced_changed.
3086 (init_gsettings): New function.
3087 (xsettings_initialize): Call init_gsettings.
3088 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3089 to NULL.
3090
3091 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3092 GCONF_CFLAGS/LIBS.
3093
3094 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3095
3096 * window.c (resize_root_window, grow_mini_window)
3097 (shrink_mini_window): Rename Qresize_root_window to
3098 Qwindow_resize_root_window and Qresize_root_window_vertically to
3099 Qwindow_resize_root_window_vertically.
3100
3101 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3102
3103 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3104
3105 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3106
3107 * makefile.w32-in: Redesign dependencies so they reflect more
3108 clearly which files are directly included by each source file,
3109 and not through other includes.
3110
3111 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3112
3113 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3114 (sort_overlays, overlay_strings): When an overlay's clone number
3115 matches the window's clone number process the overlay even if
3116 the overlay's window property doesn't match the current window.
3117
3118 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3119 (Fwindow_hchild): Rename to Fwindow_left_child.
3120 (Fwindow_next): Rename to Fwindow_next_sibling.
3121 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3122 (resize_window_check): Rename to window_resize_check.
3123 (resize_window_apply): Rename to window_resize_apply.
3124 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3125 (Fdelete_other_windows_internal, resize_frame_windows)
3126 (Fsplit_window_internal, Fdelete_window_internal)
3127 (grow_mini_window, shrink_mini_window)
3128 (Fresize_mini_window_internal): Fix callers accordingly.
3129
3130 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3131
3132 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3133 (emacs_fixed_set_min_size): Remove.
3134 (emacs_fixed_new): Take frame as argument.
3135
3136 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3137 (_EmacsFixedPrivate): Remove minwidth/height.
3138 Add struct frame *f.
3139 (emacs_fixed_init): Initialize priv->f.
3140 (get_parent_class, emacs_fixed_set_min_size): Remove.
3141 (emacs_fixed_new): Set priv->f to argument.
3142 (emacs_fixed_get_preferred_width)
3143 (emacs_fixed_get_preferred_height): Use min_width/height from
3144 frames size_hint to set minimum and natural (Bug#8919).
3145 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3146 and use min_width/height from frames size_hint to set
3147 min_width/height (Bug#8919).
3148
3149 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3150 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3151 Fix indentation.
3152
3153 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3154
3155 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3156 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3157 called at ZV.
3158
3159 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3160
3161 * process.c (wait_reading_process_output): Bypass select if
3162 waiting for a cell while ignoring keyboard input, and input is
3163 pending. Suggested by Jan Djärv (Bug#8869).
3164
3165 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3166
3167 Use gnulib's dup2 module instead of rolling our own.
3168 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3169
3170 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3171
3172 * dispnew.c (scrolling_window): Before scrolling, turn off a
3173 mouse-highlight in the window being scrolled.
3174
3175 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3176
3177 Move DEFSYM to lisp.h and use everywhere.
3178
3179 * character.h (DEFSYM): Move declaration...
3180 * lisp.h (DEFSYM): ...here.
3181
3182 * gnutls.c:
3183 * minibuf.c:
3184 * w32menu.c:
3185 * w32proc.c:
3186 * w32select.c: Don't include character.h.
3187
3188 * alloc.c (syms_of_alloc):
3189 * buffer.c (syms_of_buffer):
3190 * bytecode.c (syms_of_bytecode):
3191 * callint.c (syms_of_callint):
3192 * casefiddle.c (syms_of_casefiddle):
3193 * casetab.c (init_casetab_once):
3194 * category.c (init_category_once, syms_of_category):
3195 * ccl.c (syms_of_ccl):
3196 * cmds.c (syms_of_cmds):
3197 * composite.c (syms_of_composite):
3198 * dbusbind.c (syms_of_dbusbind):
3199 * dired.c (syms_of_dired):
3200 * dispnew.c (syms_of_display):
3201 * doc.c (syms_of_doc):
3202 * editfns.c (syms_of_editfns):
3203 * emacs.c (syms_of_emacs):
3204 * eval.c (syms_of_eval):
3205 * fileio.c (syms_of_fileio):
3206 * fns.c (syms_of_fns):
3207 * frame.c (syms_of_frame):
3208 * fringe.c (syms_of_fringe):
3209 * insdel.c (syms_of_insdel):
3210 * keymap.c (syms_of_keymap):
3211 * lread.c (init_obarray, syms_of_lread):
3212 * macros.c (syms_of_macros):
3213 * msdos.c (syms_of_msdos):
3214 * print.c (syms_of_print):
3215 * process.c (syms_of_process):
3216 * search.c (syms_of_search):
3217 * sound.c (syms_of_sound):
3218 * syntax.c (init_syntax_once, syms_of_syntax):
3219 * terminal.c (syms_of_terminal):
3220 * textprop.c (syms_of_textprop):
3221 * undo.c (syms_of_undo):
3222 * w32.c (globals_of_w32):
3223 * window.c (syms_of_window):
3224 * xdisp.c (syms_of_xdisp):
3225 * xfaces.c (syms_of_xfaces):
3226 * xfns.c (syms_of_xfns):
3227 * xmenu.c (syms_of_xmenu):
3228 * xsettings.c (syms_of_xsettings):
3229 * xterm.c (syms_of_xterm): Use DEFSYM.
3230
3231 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3232
3233 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3234
3235 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3236
3237 Integer and buffer overflow fixes (Bug#8873).
3238
3239 * print.c (printchar, strout): Check for string overflow.
3240 (PRINTPREPARE, printchar, strout):
3241 Don't set size unless allocation succeeds.
3242
3243 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3244 for sizes. Check for string overflow more accurately.
3245 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3246
3247 * macros.c: Integer and buffer overflow fixes.
3248 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3249 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3250 Use ptrdiff_t, not int, for sizes.
3251 Don't increment bufsize until after realloc succeeds.
3252 Check for size-calculation overflow.
3253 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3254
3255 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3256
3257 * lread.c: Integer overflow fixes.
3258 (read_integer): Radix is now EMACS_INT, not int,
3259 to improve quality of diagnostics for out-of-range radices.
3260 Calculate buffer size correctly for out-of-range radices.
3261 (read1): Check for integer overflow in radices, and in
3262 read-circle numbers.
3263 (read_escape): Avoid int overflow.
3264 (Fload, openp, read_buffer_size, read1)
3265 (substitute_object_recurse, read_vector, read_list, map_obarray):
3266 Use ptrdiff_t, not int, for sizes.
3267 (read1): Use EMACS_INT, not int, for sizes.
3268 Check for size overflow.
3269
3270 * image.c (cache_image): Check for size arithmetic overflow.
3271
3272 * lread.c: Integer overflow issues.
3273 (saved_doc_string_size, saved_doc_string_length)
3274 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3275 Now ptrdiff_t, not int.
3276 (read1): Don't assume doc string length fits in int. Check for
3277 out-of-range doc string lengths.
3278 (read_list): Don't assume file position fits in int.
3279 (read_escape): Check for hex character overflow.
3280
3281 2011-06-22 Leo Liu <sdl.web@gmail.com>
3282
3283 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3284 Move to minibuffer.el.
3285
3286 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3287
3288 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3289 The following patches are for when GLYPH_DEBUG && !XASSERT.
3290 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3291 * dispnew.c (flush_stdout):
3292 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3293 Mark as externally visible.
3294 * dispnew.c (check_window_matrix_pointers): Now static.
3295 * dispnew.c (window_to_frame_vpos):
3296 * xfns.c (unwind_create_frame):
3297 * xterm.c (x_check_font): Remove unused local.
3298 * scroll.c (CHECK_BOUNDS):
3299 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3300 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3301 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3302 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3303 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3304 Now static.
3305 (debug_method_add): Use va_list and vsprintf rather than relying
3306 on undefined behavior with wrong number of arguments.
3307 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3308 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3309 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3310 since we're not interested in debugging glyphs with old libraries.
3311 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3312 GCC 4.6.0's static checking.
3313
3314 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3315
3316 Integer overflow and signedness fixes (Bug#8873).
3317 A few related buffer overrun fixes, too.
3318
3319 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3320
3321 * dispextern.h (struct face.stipple):
3322 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3323 (x_bitmap_mask, x_allocate_bitmap_record)
3324 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3325 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3326 (x_create_bitmap_from_xpm_data):
3327 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3328 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3329 (.bitmaps_last):
3330 * xfaces.c (load_pixmap):
3331 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3332 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3333 (.bitmaps_last, struct x_output.icon_bitmap):
3334 Use ptrdiff_t, not int, for bitmap indexes.
3335 (x_allocate_bitmap_record): Check for size overflow.
3336 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3337
3338 Use ptrdiff_t, not int, for overlay counts.
3339 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3340 * editfns.c (overlays_around, get_pos_property):
3341 * textprop.c (get_char_property_and_overlay):
3342 * xdisp.c (next_overlay_change, note_mouse_highlight):
3343 * xfaces.c (face_at_buffer_position):
3344 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3345 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3346 (Fnext_overlay_change, Fprevious_overlay_change)
3347 (mouse_face_overlay_overlaps, Foverlays_in):
3348 Use ptrdiff_t, not int, for sizes.
3349 (overlays_at, overlays_in): Check for size-calculation overflow.
3350
3351 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3352
3353 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3354 (x_session_initialize): Do not assume string length fits in int.
3355
3356 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3357 This is unlikely, but can occur if DPI is outlandish.
3358
3359 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3360 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3361
3362 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3363 * xrdb.c (magic_file_p, search_magic_path):
3364 Omit last arg SUFFIX; it was always 0. All callers changed.
3365 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3366
3367 * xfont.c (xfont_match): Avoid need for strlen.
3368
3369 * xfns.c: Don't assume strlen fits in int.
3370 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3371
3372 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3373 not unsigned long, as we prefer signed integers. All callers changed.
3374 Detect integer overflow in repeat count.
3375 (message_dolog): Don't assume print length fits in 39 bytes.
3376 (display_mode_element): Don't assume strlen fits in int.
3377
3378 * termcap.c: Don't assume sizes fit in int and never overflow.
3379 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3380 (gobble_line): Check for size-calculation overflow.
3381
3382 * minibuf.c (Fread_buffer):
3383 * lread.c (intern, intern_c_string):
3384 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3385 Don't assume string length fits in int.
3386
3387 * keyboard.c (parse_tool_bar_item):
3388 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3389
3390 * font.c: Don't assume string length fits in int.
3391 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3392 Use ptrdiff_t, not int.
3393 (font_intern_prop): Don't assume string length fits in int.
3394 Don't assume integer property fits in fixnum.
3395 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3396
3397 * filelock.c: Fix some buffer overrun and integer overflow issues.
3398 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3399 Reformulate so as not to need the command string.
3400 Invoke gzip -cd rather than gunzip, as it's more portable.
3401 (lock_info_type, lock_file_1, lock_file):
3402 Don't assume pid_t and time_t fit in unsigned long.
3403 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3404 (current_lock_owner): Prefer signed type for sizes.
3405 Use memcpy, not strncpy, where memcpy is what is really wanted.
3406 Don't assume (via atoi) that time_t and pid_t fit in int.
3407 Check for time_t and/or pid_t out of range, e.g., via a network share.
3408 Don't alloca where an auto var works fine.
3409
3410 * fileio.c: Fix some integer overflow issues.
3411 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3412 Don't assume string length fits in int.
3413 (directory_file_name): Don't assume string length fits in long.
3414 (make_temp_name): Don't assume pid fits in int, or that its print
3415 length is less than 20.
3416
3417 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3418
3419 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3420
3421 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3422
3423 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3424 We prefer signed integers, even for size calculations.
3425
3426 * emacs.c: Don't assume string length fits in 'int'.
3427 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3428 (main): Don't invoke strlen when not needed.
3429
3430 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3431 (XD_DEBUG_MESSAGE): Don't waste a byte.
3432
3433 * callproc.c (getenv_internal_1, getenv_internal)
3434 (Fgetenv_internal):
3435 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3436
3437 * lread.c (invalid_syntax): Omit length argument.
3438 All uses changed. This doesn't fix a bug, but it simplifies the
3439 code away from its former Hollerith-constant appearance, and it's
3440 one less 'int' to worry about when looking at integer-overflow issues.
3441 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3442
3443 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3444 This didn't break anything, but it didn't help either.
3445 It's confusing to put a bogus integer in a place where the actual
3446 value does not matter.
3447 (LIST_END_P): Remove unused macro and its bogus comment.
3448 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3449
3450 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3451 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3452 implementation.
3453 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3454 We prefer signed types, and the value cannot exceed the EMACS_INT
3455 range anyway (because otherwise the length would not be representable).
3456 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3457 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3458 This avoids a GCC warning when WIDE_EMACS_INT.
3459
3460 * indent.c (sane_tab_width): New function.
3461 (current_column, scan_for_column, Findent_to, position_indentation)
3462 (compute_motion): Use it. This is just for clarity.
3463 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3464
3465 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3466
3467 * lisp.h (lint_assume): New macro.
3468 * composite.c (composition_gstring_put_cache):
3469 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3470
3471 * editfns.c, insdel.c:
3472 Omit unnecessary forward decls, to simplify future changes.
3473
3474 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3475
3476 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3477
3478 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3479 Use much-faster test for byte-length change.
3480 Don't assume string byte-length fits in 'int'.
3481 Check that character arg fits in 'int'.
3482 (mapcar1): Declare byte as byte, for clarity.
3483
3484 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3485
3486 * fns.c (concat): Catch string overflow earlier.
3487 Do not rely on integer wraparound.
3488
3489 * dispextern.h (struct it.overlay_strings_charpos)
3490 (struct it.selective): Now EMACS_INT, not int.
3491 * xdisp.c (forward_to_next_line_start)
3492 (back_to_previous_visible_line_start)
3493 (reseat_at_next_visible_line_start, next_element_from_buffer):
3494 Don't arbitrarily truncate the value of 'selective' to int.
3495
3496 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3497
3498 * composite.c: Don't truncate sizes to 'int'.
3499 (composition_gstring_p, composition_reseat_it)
3500 (composition_adjust_point): Use EMACS_INT, not int.
3501 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3502 not EMACS_UINT, for indexes.
3503
3504 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3505
3506 * buffer.c: Include <verify.h>.
3507 (struct sortvec.priority, struct sortstr.priority):
3508 Now EMACS_INT, not int.
3509 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3510 (struct sortstr.size, record_overlay_string)
3511 (struct sortstrlist.size, struct sortlist.used):
3512 Don't truncate size to int.
3513 (record_overlay_string): Check for size-calculation overflow.
3514 (init_buffer_once): Check at compile-time, not run-time.
3515
3516 2011-06-22 Jim Meyering <meyering@redhat.com>
3517
3518 Don't leak an XBM-image-sized buffer
3519 * image.c (xbm_load): Free the image buffer after using it.
3520
3521 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3522
3523 Port to Sun C.
3524 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3525 that Sun C diagnosed.
3526 * fns.c (secure_hash): Fix pointer signedness issue.
3527 * intervals.c (static_offset_intervals): New function.
3528 (offset_intervals): Use it.
3529
3530 2011-06-21 Leo Liu <sdl.web@gmail.com>
3531
3532 * deps.mk (fns.o):
3533 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3534 sha512.h.
3535
3536 * fns.c (secure_hash): Rename from crypto_hash_function and change
3537 the first arg to accept symbols.
3538 (Fsecure_hash): New primitive.
3539 (syms_of_fns): New symbols.
3540
3541 2011-06-20 Deniz Dogan <deniz@dogan.se>
3542
3543 * process.c (Fset_process_buffer): Clarify return value in
3544 docstring.
3545
3546 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3547
3548 * dispnew.c (add_window_display_history): Use BVAR.
3549
3550 * xdisp.c (debug_method_add): Use BVAR.
3551 (check_window_end, dump_glyph_matrix, dump_glyph)
3552 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3553
3554 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3555 Likewise.
3556
3557 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3558 check till after the cache is created in init_frame_faces.
3559
3560 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3561
3562 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3563
3564 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3565
3566 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3567 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3568 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3569
3570 Improve buffer-overflow checking (Bug#8873).
3571 * fileio.c (Finsert_file_contents):
3572 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3573 Remove the old (too-loose) buffer overflow checks.
3574 They weren't needed, since make_gap checks for buffer overflow.
3575 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3576 The old code merely checked for Emacs fixnum overflow, and relied
3577 on undefined (wraparound) behavior. The new code avoids undefined
3578 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3579
3580 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3581 Tune. Don't use wider integers than needed. Don't use alloca.
3582 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3583
3584 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3585
3586 * insdel.c, lisp.h (buffer_overflow): New function.
3587 (insert_from_buffer_1, replace_range, replace_range_2):
3588 * insdel.c (make_gap_larger):
3589 * editfns.c (Finsert_char):
3590 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3591
3592 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3593
3594 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3595
3596 Integer overflow and signedness fixes (Bug#8873).
3597
3598 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3599 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3600
3601 * fileio.c: Don't assume EMACS_INT fits in off_t.
3602 (emacs_lseek): New static function.
3603 (Finsert_file_contents, Fwrite_region): Use it.
3604 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3605
3606 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3607
3608 * fns.c: Don't overflow int when computing a list length.
3609 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3610 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3611 truncation on 64-bit hosts. Check for QUIT every
3612 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3613 faster and is responsive enough.
3614 (Flength): Report an error instead of overflowing an integer.
3615 (Fsafe_length): Return a float if the value is not representable
3616 as a fixnum. This shouldn't happen except in contrived situations.
3617 (Fnthcdr, Fsort): Don't assume list length fits in int.
3618 (Fcopy_sequence): Don't assume vector length fits in int.
3619
3620 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3621 (header_size, word_size): New constants.
3622 (allocate_vectorlike): Don't check size overflow here.
3623 (allocate_vector): Check it here instead, since this is the only
3624 caller of allocate_vectorlike that could cause overflow.
3625 Check that the new vector's length is representable as a fixnum.
3626
3627 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3628 The previous code was bogus. For example, next_almost_prime (32)
3629 returned 39, which is undesirable as it is a multiple of 3; and
3630 next_almost_prime (24) returned 25, which is a multiple of 5 so
3631 why was the code bothering to check for multiples of 7?
3632
3633 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3634
3635 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3636
3637 Variadic C functions now count arguments with ptrdiff_t.
3638 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3639 Back then I didn't know that the Emacs coding style prefers signed int.
3640 Also, in the meantime I found a few more instances where arguments
3641 were being counted with int, which may truncate counts on 64-bit
3642 machines, or EMACS_INT, which may be unnecessarily wide.
3643 * lisp.h (struct Lisp_Subr.function.aMANY)
3644 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3645 Arg counts are now ptrdiff_t, not size_t.
3646 All variadic functions and their callers changed accordingly.
3647 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3648 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3649 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3650 * callint.c (Fcall_interactively): Check arg count for overflow,
3651 to avoid potential buffer overrun. Use signed char, not 'int',
3652 for 'varies' array, so that we needn't bother to check its size
3653 calculation for overflow.
3654 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3655 * eval.c (apply_lambda):
3656 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3657 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3658 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3659
3660 * callint.c (Fcall_interactively): Don't use index var as event count.
3661
3662 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3663 * mem-limits.h (SIZE): Remove; no longer used.
3664
3665 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3666
3667 Remove unnecessary casts.
3668 * xterm.c (x_term_init):
3669 * xfns.c (x_set_border_pixel):
3670 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3671 These aren't needed now that we assume ANSI C.
3672
3673 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3674 It's more likely to cause problems (due to unsigned overflow)
3675 than to cure them.
3676
3677 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3678
3679 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3680
3681 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3682
3683 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3684
3685 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3686
3687 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3688
3689 GLYPH_CODE_FACE returns EMACS_INT, not int.
3690 * dispextern.h (merge_faces):
3691 * xfaces.c (merge_faces):
3692 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3693 Don't assume EMACS_INT fits in int.
3694
3695 * character.h (CHAR_VALID_P): Remove unused parameter.
3696 * fontset.c, lisp.h, xdisp.c: All uses changed.
3697
3698 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3699
3700 * fns.c (concat): Minor tuning based on overflow analysis.
3701 This doesn't fix any bugs. Use int to hold character, instead
3702 of constantly refetching from Emacs object. Use XFASTINT, not
3703 XINT, for value known to be a character. Don't bother comparing
3704 a single byte to 0400, as it's always less.
3705
3706 * floatfns.c (Fexpt):
3707 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3708
3709 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3710 for characters.
3711
3712 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3713
3714 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3715 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3716 incorrectly succeed when S was a string, because 4294967386 was
3717 truncated before it was used.
3718
3719 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3720 Otherwise, an out-of-range integer could cause undefined behavior
3721 on a 64-bit host.
3722
3723 * composite.c: Use int, not EMACS_INT, for characters.
3724 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3725 EMACS_INT, for values that are known to be in character range.
3726 This doesn't fix any bugs but is the usual style inside Emacs and
3727 may generate better code on 32-bit machines.
3728
3729 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3730 This is for reasons similar to the recent CHAR_STRING fix.
3731 * charset.c (Fencode_char): Check that character arg is actually
3732 a character. Pass an int to ENCODE_CHAR.
3733 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3734 wider than 'int', as a compile-time check to prevent future regressions
3735 in this area.
3736
3737 * character.c (char_string): Remove unnecessary casts.
3738
3739 Make sure a 64-bit char is never passed to CHAR_STRING.
3740 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3741 by silently ignoring the top 32 bits, allowing some values
3742 that were far too large to be valid characters.
3743 * character.h: Include <verify.h>.
3744 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3745 arguments are no wider than unsigned, as a compile-time check
3746 to prevent future regressions in this area.
3747 * data.c (Faset):
3748 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3749 (Fsubst_char_in_region):
3750 * fns.c (concat):
3751 * xdisp.c (decode_mode_spec_coding):
3752 Adjust to CHAR_STRING's new requirement.
3753 * editfns.c (Finsert_char, Fsubst_char_in_region):
3754 * fns.c (concat): Check that character args are actually
3755 characters. Without this test, these functions did the wrong
3756 thing with wildly out-of-range values on 64-bit hosts.
3757
3758 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3759 These casts should not be needed on 32-bit hosts, either.
3760 * keyboard.c (read_char):
3761 * lread.c (Fload): Remove casts to unsigned.
3762
3763 * lisp.h (UNSIGNED_CMP): New macro.
3764 This fixes comparison bugs on 64-bit hosts.
3765 (ASCII_CHAR_P): Use it.
3766 * casefiddle.c (casify_object):
3767 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3768 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3769 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3770 * dispextern.h (FACE_FROM_ID):
3771 * keyboard.c (read_char): Use UNSIGNED_CMP.
3772
3773 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3774 not to EMACS_INT, to avoid GCC warning.
3775
3776 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3777
3778 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3779 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3780 isn't needed on 32-bit machines.
3781
3782 * buffer.c (Fgenerate_new_buffer_name):
3783 Use EMACS_INT for count, not int.
3784 (advance_to_char_boundary): Return EMACS_INT, not int.
3785
3786 * data.c (Qcompiled_function): Now static.
3787
3788 * window.c (window_body_lines): Now static.
3789
3790 * image.c (gif_load): Rename local to avoid shadowing.
3791
3792 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3793 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3794 * alloc.c (make_save_value): Integer argument is now of type
3795 ptrdiff_t, not int.
3796 (mark_object): Use ptrdiff_t, not int.
3797 * lisp.h (pD): New macro.
3798 * print.c (print_object): Use it.
3799
3800 * alloc.c: Use EMACS_INT, not int, to count objects.
3801 (total_conses, total_markers, total_symbols, total_vector_size)
3802 (total_free_conses, total_free_markers, total_free_symbols)
3803 (total_free_floats, total_floats, total_free_intervals)
3804 (total_intervals, total_strings, total_free_strings):
3805 Now EMACS_INT, not int. All uses changed.
3806 (Fgarbage_collect): Compute overall total using a double, so that
3807 integer overflow is less likely to be a problem. Check for overflow
3808 when converting back to an integer.
3809 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3810 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3811 These were 'int' variables that could overflow on 64-bit hosts;
3812 they were never used, so remove them instead of repairing them.
3813 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3814 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3815 Previously, this ceilinged at INT_MAX, but that doesn't work on
3816 64-bit machines.
3817 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3818
3819 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3820 (allocate_vectorlike): Check for ptrdiff_t overflow.
3821 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3822 when a (possibly-narrower) signed value would do just as well.
3823 We prefer using signed arithmetic, to avoid comparison confusion.
3824
3825 * alloc.c: Catch some string size overflows that we were missing.
3826 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3827 for convenience in STRING_BYTES_MAX.
3828 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3829 The definition here is exact; the one in lisp.h was approximate.
3830 (allocate_string_data): Check for string overflow. This catches
3831 some instances we weren't catching before. Also, it catches
3832 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3833 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3834 and ptrdiff_t and EMACS_INT are both 64 bits.
3835
3836 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3837 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3838 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3839
3840 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3841
3842 * alloc.c (Fmake_string): Check for out-of-range init.
3843
3844 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3845
3846 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3847
3848 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3849
3850 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3851 xg_get_default_scrollbar_width.
3852
3853 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3854 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3855 (style_changed_cb): Call update_theme_scrollbar_width and call
3856 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3857 all frames (Bug#8505).
3858 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3859 Call gtk_window_set_resizable if HAVE_GTK3.
3860 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3861 and height if HAVE_GTK3 (Bug#8505).
3862 (scroll_bar_width_for_theme): New variable.
3863 (update_theme_scrollbar_width): New function.
3864 (xg_get_default_scrollbar_width): Move code to
3865 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3866 (xg_initialize): Call update_theme_scrollbar_width.
3867
3868 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3869
3870 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3871
3872 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3873
3874 * frame.c (make_frame): Call other_buffer_safely instead of
3875 other_buffer.
3876
3877 * window.c (temp_output_buffer_show): Call display_buffer with
3878 second argument Vtemp_buffer_show_specifiers and reset latter
3879 immediately after the call.
3880 (Vtemp_buffer_show_specifiers): New variable.
3881 (auto_window_vscroll_p, next_screen_context_lines)
3882 (Vscroll_preserve_screen_position): Remove leading asterisks from
3883 doc-strings.
3884
3885 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3886
3887 Fix minor problems found by GCC 4.6.0 static checking.
3888 * buffer.c (Qclone_number): Remove for now, as it's unused.
3889 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3890 (record_buffer): Remove unused local.
3891 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3892 (set_frame_buffer_list): Remove; unused.
3893 * frame.h (other_visible_frames): Remove decl.
3894 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3895 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3896 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3897 if HAVE_GPM.
3898 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3899 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3900 Define only if HAVE_GPM.
3901 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3902 (update_hints_inhibit): Remove; never set. All uses removed.
3903 * widgetprv.h (emacsFrameClassRec): Remove decl.
3904 * window.c (delete_deletable_window): Now returns void, since it
3905 wasn't returning anything.
3906 (compare_window_configurations): Remove unused locals.
3907 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3908 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3909 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3910 the same widths as pointers. This follows up on the 2011-05-06 patch.
3911 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3912 * xterm.h: Likewise.
3913 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3914
3915 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3916
3917 * makefile.w32-in: Update dependencies.
3918 (LISP_H): Add lib/intprops.h.
3919
3920 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3921
3922 * image.c (gif_load): Add animation frame delay to the metadata.
3923 (syms_of_image): Use DEFSYM. New symbol `delay'.
3924
3925 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3926
3927 * window.c (delete_deletable_window): Re-add.
3928 (Fset_window_configuration): Rewrite to handle dead buffers and
3929 consequently deletable windows.
3930 (window_tree, Fwindow_tree): Remove. Supply functionality in
3931 window.el.
3932 (compare_window_configurations): Simplify code.
3933
3934 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3935
3936 * image.c (imagemagick_load_image): Fix type mismatch.
3937 (Fimagemagick_types): Likewise.
3938
3939 * window.h (replace_buffer_in_windows): Declare.
3940
3941 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3942
3943 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3944 Qclone_number. Remove external declaration of Qdelete_window.
3945 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3946 code.
3947 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3948 Run Qbuffer_list_update_hook if allowed.
3949 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3950 buffer list implementation.
3951 (other_buffer_safely): New function.
3952 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3953 calls to replace_buffer_in_windows and
3954 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3955 if allowed.
3956 (record_buffer): Inhibit quitting and rewrite using quittable
3957 functions. Run Qbuffer_list_update_hook if allowed.
3958 (Frecord_buffer, Funrecord_buffer): New functions.
3959 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3960 Move switch-to-buffer to window.el.
3961 (bury-buffer): Move to window.el.
3962 (Vbuffer_list_update_hook): New variable.
3963
3964 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3965 section.
3966
3967 * window.h (resize_frame_windows): Move up in code.
3968 (Fwindow_frame): Remove EXFUN.
3969 (replace_buffer_in_all_windows): Remove prototype.
3970 (replace_buffer_in_windows_safely): Add prototype.
3971
3972 * window.c: Declare Qdelete_window static again. Move down
3973 declaration of select_count.
3974 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3975 (Fother_window): Move to window.el.
3976 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3977 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3978 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3979 window.el.
3980 (replace_buffer_in_windows): Implement by calling
3981 Qreplace_buffer_in_windows.
3982 (replace_buffer_in_all_windows): Remove with some functionality
3983 moved into replace_buffer_in_windows_safely.
3984 (replace_buffer_in_windows_safely): New function.
3985 (select_window_norecord, select_frame_norecord): Move in front
3986 of run_window_configuration_change_hook. Remove now obsolete
3987 declarations.
3988 (Fset_window_buffer): Rewrite doc-string.
3989 Call Qrecord_window_buffer.
3990 (keys_of_window): Move binding for other-window to window.el.
3991
3992 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3993
3994 * dispextern.h (struct image): Replace data member, whose int_val
3995 and ptr_val fields were not used by anything, with a single
3996 lisp_val object.
3997
3998 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3999 (gif_clear_image, gif_load, imagemagick_load_image)
4000 (gs_clear_image, gs_load): Callers changed.
4001
4002 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4003
4004 * buffer.h: Include <time.h>, for time_t.
4005 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4006
4007 Fix minor problems found by static checking.
4008
4009 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4010
4011 Make identifiers static if they are not used in other modules.
4012 * data.c (Qcompiled_function, Qframe, Qvector):
4013 * image.c (QimageMagick, Qsvg):
4014 * minibuf.c (Qmetadata):
4015 * window.c (resize_window_check, resize_root_window): Now static.
4016 * window.h (resize_window_check, resize_root_window): Remove decls.
4017
4018 * window.c (window_deletion_count, delete_deletable_window):
4019 Remove; unused.
4020 (window_body_lines): Now static.
4021 (Fdelete_other_windows_internal): Mark vars as initialized.
4022 Make sure 'resize_failed' is initialized.
4023 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4024 (resize_window_apply): Remove unused local.
4025 * window.h (delete_deletable_window): Remove decl.
4026
4027 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4028 (imagemagick_load_image): Fix pointer signedness problem by changing
4029 last arg from unsigned char * to char *. All uses changed.
4030 Also, fix a local for similar reasons.
4031 Remove unused locals. Remove locals to avoid shadowing.
4032 (fn_rsvg_handle_free): Remove; unused.
4033 (svg_load, svg_load_image): Fix pointer signedness problem.
4034 (imagemagick_load_image): Don't use garbage pointer image_wand.
4035
4036 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4037
4038 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4039
4040 * image.c (gif_load): Fix omitted cast error introduced by
4041 2011-06-06 change.
4042
4043 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4044
4045 * window.h (resize_proportionally, orig_total_lines)
4046 (orig_top_line): Remove from window structure.
4047 (set_window_height, set_window_width, change_window_heights)
4048 (Fdelete_window): Remove prototypes.
4049 (resize_frame_windows): Remove duplicate declaration.
4050
4051 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4052
4053 * window.h (resize_frame_windows, resize_window_check)
4054 (delete_deletable_window, resize_root_window)
4055 (resize_frame_windows): Declare prototypes.
4056
4057 * window.c (resize_window_apply): Make definition be "static" to
4058 match the prototype.
4059
4060 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4061
4062 * window.c: Remove declarations of Qwindow_size_fixed,
4063 window_min_size_1, window_min_size_2, window_min_size,
4064 size_window, window_fixed_size_p, enlarge_window, delete_window.
4065 Remove static from declaration of Qdelete_window, it's
4066 temporarily needed by Fbury_buffer.
4067 (replace_window): Don't assign orig_top_line and
4068 orig_total_lines.
4069 (Fdelete_window, delete_window): Remove. Window deletion is
4070 handled by window.el.
4071 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4072 Replace Fdelete_window calls with calls to Qdelete_window.
4073 (Fdelete_other_windows): Remove. Deleting other windows is
4074 handled by window.el.
4075 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4076 handled in window.el.
4077 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4078 Window minimum sizes are handled in window.el.
4079 (shrink_windows, size_window, set_window_height)
4080 (set_window_width, change_window_heights, window_height)
4081 (window_width, CURBEG, CURSIZE, enlarge_window)
4082 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4083 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4084 handled in window.el.
4085 (make_dummy_parent): Rename to make_parent_window and give it a
4086 second argument horflag.
4087 (make_window): Don't set resize_proportionally any more.
4088 (Fsplit_window): Remove. Windows are split in window.el.
4089 (save_restore_action, save_restore_orig_size)
4090 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4091 Resize mini windows in window.el.
4092 (grow_mini_window, shrink_mini_window): Implement by calling
4093 Qresize_root_window_vertically, resize_window_check and
4094 resize_window_apply.
4095 (saved_window, Fset_window_configuration, save_window_save):
4096 Do not handle orig_top_line, orig_total_lines, and
4097 resize_proportionally.
4098 (window_min_height, window_min_width): Move to window.el.
4099 (keys_of_window): Move bindings for delete-other-windows,
4100 split-window, delete-window and enlarge-window to window.el.
4101
4102 * buffer.c: Temporarily extern Qdelete_window.
4103 (Fbury_buffer): Temporarily call Qdelete_window instead of
4104 Fdelete_window (Fbury_buffer will move to window.el soon).
4105
4106 * frame.c (set_menu_bar_lines_1): Remove code handling
4107 orig_top_line and orig_total_lines.
4108
4109 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4110 set_window_height but set heights directly.
4111 (change_frame_size_1): Use resize_frame_windows.
4112
4113 * xdisp.c (init_xdisp): Don't use set_window_height but set
4114 heights directly.
4115
4116 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4117 Use resize_frame_windows instead of change_window_heights and run
4118 run_window_configuration_change_hook.
4119
4120 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4121 instead of change_window_heights and run
4122 run_window_configuration_change_hook.
4123
4124 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4125
4126 * window.c (replace_window): Rename second argument REPLACEMENT to
4127 NEW. New third argument SETFLAG. Rewrite.
4128 (delete_window, make_dummy_parent): Call replace_window with
4129 third argument 1.
4130 (window_list_1): Move down in code.
4131 (run_window_configuration_change_hook): Move set_buffer part
4132 before select_frame_norecord part in order to unwind correctly.
4133 Rename count1 to count.
4134 (recombine_windows, delete_deletable_window, resize_root_window)
4135 (Fdelete_other_windows_internal)
4136 (Frun_window_configuration_change_hook, make_parent_window)
4137 (resize_window_check, resize_window_apply, Fresize_window_apply)
4138 (resize_frame_windows, Fsplit_window_internal)
4139 (Fdelete_window_internal, Fresize_mini_window_internal):
4140 New functions.
4141 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4142
4143 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4144
4145 * window.h (window): Add some new members to window structure -
4146 normal_lines, normal_cols, new_total, new_normal, clone_number,
4147 splits, nest, prev_buffers, next_buffers.
4148 (WINDOW_TOTAL_SIZE): Move here from window.c.
4149 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4150
4151 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4152 Remove.
4153 (make_dummy_parent): Set new members of windows structure.
4154 (make_window): Move down in code. Handle new members of window
4155 structure.
4156 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4157 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4158 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4159 (Fset_window_prev_buffers, Fwindow_next_buffers)
4160 (Fset_window_next_buffers, Fset_window_clone_number):
4161 New functions.
4162 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4163 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4164 Doc-string fixes.
4165 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4166 Argument WINDOW can be now internal window too.
4167 (Fwindow_use_time): Move up in code.
4168 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4169 Rewrite doc-string.
4170 (Fset_window_configuration, saved_window)
4171 (Fcurrent_window_configuration, save_window_save): Handle new
4172 members of window structure.
4173 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4174 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4175 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4176 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4177 Qget_mru_window, Qresize_root_window,
4178 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4179 Qauto_buffer_name; staticpro them.
4180
4181 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4182
4183 * window.c (Fwindow_total_size, Fwindow_left_column)
4184 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4185 (Fwindow_list_1): New functions.
4186 (window_box_text_cols): Replace with window_body_cols.
4187 (Fwindow_width, Fscroll_left, Fscroll_right):
4188 Use window_body_cols instead of window_box_text_cols.
4189 (delete_window, Fset_window_configuration):
4190 Call delete_all_subwindows with window as argument.
4191 (delete_all_subwindows): Take a window as argument and not a
4192 structure. Rewrite.
4193 (window_loop): Remove handling of GET_LRU_WINDOW and
4194 GET_LARGEST_WINDOW.
4195 (Fget_lru_window, Fget_largest_window): Move to window.el.
4196
4197 * window.h: Extern window_body_cols instead of
4198 window_box_text_cols. delete_all_subwindows now takes a
4199 Lisp_Object as argument.
4200
4201 * indent.c (compute_motion, Fcompute_motion):
4202 Use window_body_cols instead of window_box_text_cols.
4203
4204 * frame.c (delete_frame): Call delete_all_subwindows with root
4205 window as argument.
4206
4207 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4208
4209 * fns.c (Fputhash): Document return value.
4210
4211 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4212
4213 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4214
4215 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4216
4217 Cons<->int and similar integer overflow fixes (Bug#8794).
4218
4219 Check for overflow when converting integer to cons and back.
4220 * charset.c (Fdefine_charset_internal, Fdecode_char):
4221 Use cons_to_unsigned to catch overflow.
4222 (Fencode_char): Use INTEGER_TO_CONS.
4223 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4224 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4225 * data.c (long_to_cons, cons_to_long): Remove.
4226 (cons_to_unsigned, cons_to_signed): New functions.
4227 These signal an error for invalid or out-of-range values.
4228 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4229 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4230 * font.c (Ffont_variation_glyphs):
4231 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4232 * lisp.h: Include <intprops.h>.
4233 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4234 (cons_to_signed, cons_to_unsigned): New decls.
4235 (long_to_cons, cons_to_long): Remove decls.
4236 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4237 (Fprimitive_undo): Use CONS_TO_INTEGER.
4238 * xfns.c (Fx_window_property): Likewise.
4239 * xselect.c: Include <limits.h>.
4240 (x_own_selection, selection_data_to_lisp_data):
4241 Use INTEGER_TO_CONS.
4242 (x_handle_selection_request, x_handle_selection_clear)
4243 (x_get_foreign_selection, Fx_disown_selection_internal)
4244 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4245 (lisp_data_to_selection_data): Use cons_to_unsigned.
4246 (x_fill_property_data): Use cons_to_signed.
4247 Report values out of range.
4248
4249 Check for buffer and string overflow more precisely.
4250 * buffer.h (BUF_BYTES_MAX): New macro.
4251 * lisp.h (STRING_BYTES_MAX): New macro.
4252 * alloc.c (Fmake_string):
4253 * character.c (string_escape_byte8):
4254 * coding.c (coding_alloc_by_realloc):
4255 * doprnt.c (doprnt):
4256 * editfns.c (Fformat):
4257 * eval.c (verror):
4258 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4259 since they may not be the same number.
4260 * editfns.c (Finsert_char):
4261 * fileio.c (Finsert_file_contents):
4262 Likewise for BUF_BYTES_MAX.
4263
4264 * image.c: Use ptrdiff_t, not int, for sizes.
4265 (slurp_file): Switch from int to ptrdiff_t.
4266 All uses changed.
4267 (slurp_file): Check that file size fits in both size_t (for
4268 malloc) and ptrdiff_t (for sanity and safety).
4269
4270 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4271 if b->modtime has its maximal value.
4272
4273 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4274
4275 Don't assume time_t can fit into int.
4276 * buffer.h (struct buffer.modtime): Now time_t, not int.
4277 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4278 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4279
4280 Minor fixes for signed vs unsigned integers.
4281 * character.h (MAYBE_UNIFY_CHAR):
4282 * charset.c (maybe_unify_char):
4283 * keyboard.c (read_char, reorder_modifiers):
4284 XINT -> XFASTINT, since the integer must be nonnegative.
4285 * ftfont.c (ftfont_spec_pattern):
4286 * keymap.c (access_keymap, silly_event_symbol_error):
4287 XUINT -> XFASTINT, since the integer must be nonnegative.
4288 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4289 since it makes no difference and we prefer signed.
4290 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4291 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4292 nonnegative.
4293
4294 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4295
4296 * window.h (Fwindow_frame): Declare.
4297
4298 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4299
4300 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4301 (SPARE_MEMORY): Always define.
4302 (LARGE_REQUEST): Remove.
4303 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4304
4305 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4306
4307 * lisp.h: Move EXFUNS for Fframe_root_window,
4308 Fframe_first_window and Fset_frame_selected_window to window.h.
4309
4310 * window.h: Move EXFUNS for Fframe_root_window,
4311 Fframe_first_window and Fset_frame_selected_window here from
4312 lisp.h.
4313
4314 * frame.c (Fwindow_frame, Fframe_first_window)
4315 (Fframe_root_window, Fframe_selected_window)
4316 (Fset_frame_selected_window): Move to window.c.
4317 (Factive_minibuffer_window): Move to minibuf.c.
4318 (Fother_visible_frames_p): New function.
4319
4320 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4321
4322 * window.c (decode_window, decode_any_window): Move up in code.
4323 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4324 (inhibit_frame_unsplittable): Remove unused variable.
4325 (Fwindow_buffer): Move up and rewrite doc-string.
4326 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4327 (Fwindow_prev): New functions.
4328 (Fwindow_frame): Move here from frame.c. Accept any window as
4329 argument.
4330 (Fframe_root_window, Fframe_first_window)
4331 (Fframe_selected_window): Move here from frame.c. Accept frame
4332 or arbitrary window as argument. Update doc-strings.
4333 (Fminibuffer_window): Move up in code.
4334 (Fwindow_minibuffer_p): Move up in code and simplify.
4335 (Fset_frame_selected_window): Move here from frame.c.
4336 Marginal rewrite.
4337 (Fselected_window, select_window, Fselect_window): Move up in
4338 code. Minor doc-string fixes.
4339
4340 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4341
4342 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4343 Do not assume that spare memory exists; that assumption is valid
4344 only if SYSTEM_MALLOC.
4345 (LARGE_REQUEST): New macro, so that the issue of large requests
4346 is separated from the issue of spare memory.
4347
4348 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4349
4350 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4351 format. (Bug#8806)
4352
4353 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4354
4355 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4356 before statements.
4357
4358 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4359
4360 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4361
4362 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4363
4364 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4365 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4366
4367 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4368
4369 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4370
4371 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4372
4373 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4374 (x_clipboard_manager_save): Add return value.
4375 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4376 New error handlers.
4377 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4378 Obey Vx_select_enable_clipboard_manager. Catch errors in
4379 x_clipboard_manager_save (Bug#8779).
4380 (Vx_select_enable_clipboard_manager): New variable.
4381 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4382
4383 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4384
4385 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4386
4387 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4388
4389 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4390 in the current matrix if keep_current_p is non-zero.
4391
4392 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4393
4394 * bidi.c (bidi_level_of_next_char): Fix last change.
4395
4396 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4397
4398 Support bidi reordering of text covered by display properties.
4399
4400 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4401 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4402 (bidi_cache_search, bidi_cache_iterator_state)
4403 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4404 (bidi_level_of_next_char, bidi_move_to_visually_next):
4405 Support character positions inside a run of characters covered by a
4406 display string.
4407 (bidi_paragraph_init, bidi_resolve_explicit_1)
4408 (bidi_level_of_next_char): Call bidi_fetch_char and
4409 bidi_fetch_char_advance instead of FETCH_CHAR and
4410 FETCH_CHAR_ADVANCE.
4411 (bidi_init_it): Initialize new members.
4412 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4413 definitions.
4414 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4415 instead of using explicit *_CHAR codes.
4416 (bidi_resolve_explicit, bidi_resolve_weak):
4417 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4418 bidirectional text is supported only in multibyte buffers.
4419 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4420 it to initialize the frame_window_p member of struct bidi_it.
4421 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4422 (bidi_resolve_explicit, bidi_resolve_weak)
4423 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4424 bidi_it->nchars is non-positive.
4425 (bidi_level_of_next_char): Don't try to lookup the cache for the
4426 next/previous character if nothing is cached there yet, or if we
4427 were just reseat()'ed to a new position.
4428
4429 * xdisp.c (set_cursor_from_row): Set start and stop points
4430 according to the row's direction when priming the loop that looks
4431 for the glyph on which to display cursor.
4432 (single_display_spec_intangible_p): Function deleted.
4433 (display_prop_intangible_p): Reimplement to call
4434 handle_display_spec instead of single_display_spec_intangible_p.
4435 Accept 3 additional arguments needed by handle_display_spec.
4436 This fixes incorrect cursor motion across display property with complex
4437 values: lists, `(when COND...)' forms, etc.
4438 (single_display_spec_string_p): Support property values that are
4439 lists with the argument STRING its top-level element.
4440 (display_prop_string_p): Fix the condition for processing a
4441 property that is a list to be consistent with handle_display_spec.
4442 (handle_display_spec): New function, refactored from the
4443 last portion of handle_display_prop.
4444 (compute_display_string_pos): Accept additional argument
4445 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4446 value of a `display' property is a "replacing spec".
4447 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4448 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4449 the display property, but just return a value indicating whether
4450 the display property will replace the characters it covers.
4451 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4452 frame_window_p members of struct bidi_it.
4453 (compute_display_string_pos, compute_display_string_end):
4454 New functions.
4455 (push_it): Accept second argument POSITION, where pop_it should
4456 jump to continue iteration.
4457 (reseat_1): Initialize bidi_it.disp_pos.
4458
4459 * keyboard.c (adjust_point_for_property): Adjust the call to
4460 display_prop_intangible_p to its new signature.
4461
4462 * dispextern.h (struct bidi_it): New member frame_window_p.
4463 (bidi_init_it): Update prototypes.
4464 (display_prop_intangible_p): Update prototype.
4465 (compute_display_string_pos, compute_display_string_end):
4466 Declare prototypes.
4467 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4468 EMACS_INT.
4469
4470 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4471
4472 Malloc failure behavior now depends on size of allocation.
4473 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4474 * lisp.h: Change signatures accordingly.
4475 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4476 All callers changed. (Bug#8762)
4477
4478 * gnutls.c: Use Emacs's memory allocators.
4479 Without this change, the gnutls library would invoke malloc etc.
4480 directly, which causes problems on non-SYNC_INPUT hosts, and which
4481 runs afoul of improving memory_full behavior. (Bug#8761)
4482 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4483 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4484 xfree instead of the default malloc, realloc, free.
4485 (Fgnutls_boot): No need to check for memory allocation failure,
4486 since xmalloc does that for us.
4487
4488 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4489 * category.c (hash_get_category_set):
4490 * ccl.c (ccl_driver):
4491 * charset.c (Fdefine_charset_internal):
4492 * charset.h (struct charset.hash_index):
4493 * composite.c (get_composition_id, gstring_lookup_cache)
4494 (composition_gstring_put_cache):
4495 * composite.h (struct composition.hash_index):
4496 * dispextern.h (struct image.hash):
4497 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4498 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4499 (hashfn_equal, hashfn_user_defined, make_hash_table)
4500 (maybe_resize_hash_table, hash_lookup, hash_put)
4501 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4502 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4503 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4504 * image.c (make_image, search_image_cache, lookup_image)
4505 (xpm_put_color_table_h):
4506 * lisp.h (struct Lisp_Hash_Table):
4507 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4508 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4509 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4510 * alloc.c (allocate_vectorlike):
4511 Check for overflow in vector size calculations.
4512 * ccl.c (ccl_driver):
4513 Check for overflow when converting EMACS_INT to int.
4514 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4515 need to be updated by these changes.
4516 * fns.c (make_hash_table, maybe_resize_hash_table):
4517 Check for integer overflow with large hash tables.
4518 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4519 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4520 (SXHASH_REDUCE): New macro.
4521 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4522 Use it instead of discarding useful hash info with large hash values.
4523 (sxhash_float): New function.
4524 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4525 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4526 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4527 Rewrite to use FIXNUM_BITS, as this simplifies things.
4528 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4529 Adjust signatures to match updated version of code.
4530 (consing_since_gc): Now EMACS_INT, since a single hash table can
4531 use more than INT_MAX bytes.
4532
4533 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4534
4535 Make it possible to build with GCC-4.6+ -O2 -flto.
4536
4537 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4538
4539 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4540
4541 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4542 Call minibuffer-inactive-mode.
4543
4544 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4545
4546 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4547 Update dependencies.
4548
4549 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4550
4551 * data.c (init_data): Remove code for UTS, this system is not
4552 supported anymore.
4553
4554 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4555
4556 Don't force ./temacs to start in terminal mode.
4557
4558 * frame.c (make_initial_frame): Initialize faces in all cases, not
4559 only when CANNOT_DUMP is defined.
4560 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4561
4562 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4563
4564 * dispnew.c (add_window_display_history): Use const for the string
4565 pointer. Remove declaration, not needed.
4566
4567 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4568
4569 Use 'inline', not 'INLINE'.
4570 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4571 * alloc.c, fontset.c (INLINE): Remove.
4572 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4573 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4574 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4575 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4576 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4577
4578 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4579
4580 Make it possible to run ./temacs.
4581
4582 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4583 syms_of_callproc does the same thing. Remove test for
4584 "initialized", do it in the caller.
4585 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4586
4587 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4588
4589 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4590 (read_minibuf): Use get_minibuffer.
4591 (syms_of_minibuf): Use DEFSYM.
4592 (Qmetadata): New var.
4593 * data.c (Qbuffer): Don't make it static.
4594 (syms_of_data): Use DEFSYM.
4595
4596 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4597
4598 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4599 (CCL_CODE_MIN): New macro.
4600
4601 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4602
4603 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4604
4605 * eval.c (Qdebug): Now static.
4606 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4607 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4608 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4609
4610 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4611
4612 * image.c: Various fixes to ImageMagick code comments.
4613 (Fimagemagick_types): Doc fix.
4614
4615 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4616
4617 Minor fixes prompted by GCC 4.6.0 warnings.
4618
4619 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4620
4621 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4622 (x_clipboard_manager_save_all): Move extern decl to ...
4623 * xterm.h: ... here, so that it can be checked for consistency.
4624
4625 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4626
4627 * xselect.c (x_clipboard_manager_save_frame)
4628 (x_clipboard_manager_save_all): New functions.
4629 (Fx_clipboard_manager_save): Lisp function deleted.
4630
4631 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4632 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4633
4634 * xterm.h: Update prototype.
4635
4636 2011-05-28 William Xu <william.xwl@gmail.com>
4637
4638 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4639 exiting (Bug#8239).
4640
4641 2011-05-28 Jim Meyering <meyering@redhat.com>
4642
4643 Avoid a sign-extension bug in crypto_hash_function.
4644 * fns.c (to_uchar): Define.
4645 (crypto_hash_function): Use it to convert some newly-signed
4646 variables to unsigned, to avoid sign-extension bugs. For example,
4647 without this change, (md5 "truc") would evaluate to
4648 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4649 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4650 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4651
4652 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4653
4654 Integer overflow fixes.
4655
4656 * dbusbind.c: Serial number integer overflow fixes.
4657 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4658 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4659 to hold a serial number that is too large for a fixnum.
4660 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4661 Check for serial numbers out of range. Decode any serial number
4662 that was so large that it became a float. (Bug#8722)
4663
4664 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4665 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4666 Use XFASTINT rather than XUINT when numbers are nonnegative.
4667 (xd_append_arg, Fdbus_method_return_internal):
4668 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4669 arguments, check that Lisp number is nonnegative, rather than
4670 silently wrapping negative numbers around. (Bug#8722)
4671 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4672 (Bug#8722)
4673
4674 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4675
4676 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4677
4678 ccl: add integer overflow checks
4679 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4680 (IN_INT_RANGE): New macros.
4681 (ccl_driver): Use them to check for integer overflow when
4682 decoding a CCL program. Many of the new checks are whether XINT (x)
4683 fits in int; it doesn't always, on 64-bit hosts. The new version
4684 doesn't catch all possible integer overflows, but it's an
4685 improvement. (Bug#8719)
4686
4687 * alloc.c (make_event_array): Use XINT, not XUINT.
4688 There's no need for unsigned here.
4689
4690 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4691 This follows up to the 2011-05-06 change that substituted uintptr_t
4692 for EMACS_INT. This case wasn't caught back then.
4693
4694 Rework Fformat to avoid integer overflow issues.
4695 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4696 now (part of C89). Include <verify.h>.
4697 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4698 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4699 (Fformat): Avoid the prepass trying to compute sizes; it was only
4700 approximate and thus did not catch overflow reliably. Instead, walk
4701 through the format just once, formatting and computing sizes as we go,
4702 checking for integer overflow at every step, and allocating a larger
4703 buffer as needed. Keep track separately whether the format is
4704 multibyte. Keep only the most-recently calculated precision, rather
4705 than them all. Record whether each argument has been converted to
4706 string. Use EMACS_INT, not int, for byte and char and arg counts.
4707 Support field widths and precisions larger than INT_MAX. Avoid
4708 sprintf's undefined behavior with conversion specifications such as %#d
4709 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4710 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4711 formatting out-of-range floating point numbers with int
4712 formats. (Bug#8668)
4713
4714 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4715
4716 * data.c: Avoid integer truncation in expressions involving floats.
4717 * data.c: Include <intprops.h>.
4718 (arith_driver): When there's an integer overflow in an expression
4719 involving floating point, convert the integers to floating point
4720 so that the resulting value does not suffer from catastrophic
4721 integer truncation. For example, on a 64-bit host (* 4
4722 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4723 Do not rely on undefined behavior after integer overflow.
4724
4725 merge count_size_as_multibyte, parse_str_to_multibyte
4726 * character.c, character.h (count_size_as_multibyte):
4727 Rename from parse_str_to_multibyte; all uses changed.
4728 Check for integer overflow.
4729 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4730 since it's now a duplicate of the other. This is more of
4731 a character than a buffer op, so better that it's in character.c.
4732 * fns.c, print.c: Adjust to above changes.
4733
4734 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4735
4736 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4737
4738 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4739
4740 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4741 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4742 (x_clipboard_manager_save): Now static.
4743 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4744
4745 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4746 (crypto_hash_function): Now static.
4747 Fix pointer signedness problems. Avoid unnecessary initializations.
4748
4749 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4750
4751 * termhooks.h (Vselection_alist): Make it terminal-local.
4752
4753 * terminal.c (create_terminal): Initialize it.
4754
4755 * xselect.c: Support for clipboard managers.
4756 (Vselection_alist): Move to termhooks.h as terminal-local var.
4757 (LOCAL_SELECTION): New macro.
4758 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4759 (symbol_to_x_atom): Remove gratuitous arg.
4760 (x_handle_selection_request, lisp_data_to_selection_data)
4761 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4762 (x_own_selection, x_get_local_selection, x_convert_selection):
4763 New arg, specifying work frame. Use terminal-local Vselection_alist.
4764 (some_frame_on_display): Delete unused function.
4765 (Fx_own_selection_internal, Fx_get_selection_internal)
4766 (Fx_disown_selection_internal, Fx_selection_owner_p)
4767 (Fx_selection_exists_p): New optional frame arg.
4768 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4769 (x_handle_selection_clear): Don't treat other terminals with the
4770 same keyboard specially. Use the terminal-local Vselection_alist.
4771 (x_clear_frame_selections): Use Frun_hook_with_args.
4772
4773 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4774
4775 * xterm.h: Add support for those atoms.
4776
4777 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4778
4779 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4780 (converted_selections, conversion_fail_tag): New global variables.
4781 (x_selection_request_lisp_error): Free the above.
4782 (x_get_local_selection): Remove unnecessary code.
4783 (x_reply_selection_request): Args changed; handle arbitrary array
4784 of converted selections stored in converted_selections.
4785 Separate the XChangeProperty and SelectionNotify steps.
4786 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4787 (x_convert_selection): New function.
4788 (x_handle_selection_event): Simplify.
4789 (x_get_foreign_selection): Don't ignore incoming requests while
4790 waiting for an answer; this will fail when we implement
4791 SAVE_TARGETS, and seems unnecessary anyway.
4792 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4793 (Vx_sent_selection_functions): Doc fix.
4794
4795 2011-05-26 Leo Liu <sdl.web@gmail.com>
4796
4797 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4798
4799 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4800
4801 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4802
4803 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4804 for fringe update if it has periodic bitmap.
4805 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4806 and fringe_bitmap_periodic_p.
4807
4808 * fringe.c (get_fringe_bitmap_data): New function.
4809 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4810 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4811 row. Mark glyph row for fringe update if periodicity changed.
4812
4813 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4814 for fringe update unless it has periodic bitmap.
4815
4816 2011-05-25 Kenichi Handa <handa@m17n.org>
4817
4818 * xdisp.c (get_next_display_element): Set correct it->face_id for
4819 a static composition.
4820
4821 2011-05-24 Leo Liu <sdl.web@gmail.com>
4822
4823 * deps.mk (fns.o):
4824 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4825
4826 * fns.c (crypto_hash_function, Fsha1): New function.
4827 (Fmd5): Use crypto_hash_function.
4828 (syms_of_fns): Add Ssha1.
4829
4830 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4831
4832 * gnutls.c: Remove unused macros.
4833 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4834 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4835 Remove macros that are defined and never used.
4836 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4837
4838 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4839
4840 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4841 (Fx_get_selection_internal): Minor cleanup.
4842 (Fx_own_selection_internal): Rename arguments for consistency with
4843 select.el.
4844
4845 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4846
4847 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4848
4849 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4850
4851 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4852
4853 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4854
4855 * dispnew.c (scrolling_window): Don't exclude the case that the
4856 last enabled row in the desired matrix touches the bottom boundary.
4857
4858 2011-05-21 Glenn Morris <rgm@gnu.org>
4859
4860 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4861 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4862 and add some more files.
4863
4864 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4865
4866 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4867 report_file_error introduced by the change from 2011-05-07.
4868
4869 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4870
4871 * systime.h (Time): Define only if emacs is defined.
4872 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4873 where the include path doesn't have X11/X.h by default. See
4874 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4875
4876 2011-05-20 Kenichi Handa <handa@m17n.org>
4877
4878 * composite.c (find_automatic_composition): Fix previous change.
4879
4880 2011-05-20 Glenn Morris <rgm@gnu.org>
4881
4882 * lisp.mk: New file, split from Makefile.in.
4883 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4884 (shortlisp): Remove.
4885 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4886
4887 2011-05-19 Glenn Morris <rgm@gnu.org>
4888
4889 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4890 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4891 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4892 (lisp): Set the order to that of loadup.el.
4893 (shortlisp): Make it a copy of $lisp.
4894 (SOME_MACHINE_LISP): Remove.
4895 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4896 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4897
4898 2011-05-18 Kenichi Handa <handa@m17n.org>
4899
4900 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4901 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4902 (find_automatic_composition): Mostly rewrite for efficiency.
4903
4904 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4905
4906 * makefile.w32-in: Update dependencies.
4907
4908 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4909
4910 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4911 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4912
4913 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4914
4915 Fix some integer overflow issues, such as string length overflow.
4916
4917 * insdel.c (count_size_as_multibyte): Check for string overflow.
4918
4919 * character.c (lisp_string_width): Check for string overflow.
4920 Use EMACS_INT, not int, for string indexes and lengths; in
4921 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4922 the resulting string length overflows an EMACS_INT; instead,
4923 report a string overflow if no precision given. When checking for
4924 precision exhaustion, use a check that cannot possibly have
4925 integer overflow. (Bug#8675)
4926 * character.h (lisp_string_width): Adjust to new signature.
4927
4928 * alloc.c (string_overflow): New function.
4929 (Fmake_string): Use it. This doesn't change behavior, but saves
4930 a few bytes and will simplify future changes.
4931 * character.c (string_escape_byte8): Likewise.
4932 * lisp.h (string_overflow): New decl.
4933
4934 Fixups, following up to the user-interface timestamp change.
4935 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4936 for UI timestamps, instead of unsigned long.
4937 * msdos.c (mouse_get_pos): Likewise.
4938 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4939 * w32gui.h (Time): Define by including "systime.h" rather than by
4940 declaring it ourselves. (Bug#8664)
4941
4942 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4943 * image.c (clear_image_cache): Likewise.
4944
4945 * term.c (term_mouse_position): Don't assume time_t wraparound.
4946
4947 Be more systematic about user-interface timestamps.
4948 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4949 and sometimes 'EMACS_UINT', to represent these timestamps.
4950 This change causes it to use 'Time' uniformly, as that's what X uses.
4951 This makes the code easier to follow, and makes it easier to catch
4952 integer overflow bugs such as Bug#8664.
4953 * frame.c (Fmouse_position, Fmouse_pixel_position):
4954 Use Time, not unsigned long, for user-interface timestamps.
4955 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4956 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4957 * keyboard.h (last_event_timestamp): Likewise.
4958 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4959 * menu.h (xmenu_show): Likewise.
4960 * term.c (term_mouse_position): Likewise.
4961 * termhooks.h (struct input_event.timestamp): Likewise.
4962 (struct terminal.mouse_position_hook): Likewise.
4963 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4964 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4965 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4966 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4967 what it was before.
4968 * menu.h, termhooks.h: Include "systime.h", for Time.
4969
4970 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4971 Don't assume that the difference between two unsigned long values
4972 can fit into an integer. At this point, we know button_down_time
4973 <= event->timestamp, so the difference must be nonnegative, so
4974 there's no need to cast the result if double-click-time is
4975 nonnegative, as it should be; check that it's nonnegative, just in
4976 case. This bug is triggered when events are more than 2**31 ms
4977 apart (about 25 days). (Bug#8664)
4978
4979 * xselect.c (last_event_timestamp): Remove duplicate decl.
4980 (x_own_selection): Remove needless cast to unsigned long.
4981
4982 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4983 that always fit in int. Use a sentinel instead of a counter, to
4984 avoid a temp and to allay GCC's concerns about possible int overflow.
4985 * frame.h (struct frame): Use int for menu_bar_items_used
4986 instead of EMACS_INT, since it always fits in int.
4987
4988 * menu.c (grow_menu_items): Check for int overflow.
4989
4990 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4991
4992 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4993 Before, the code was not consistent. These values cannot exceed
4994 2**31 - 1 so there's no need to make them unsigned.
4995 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4996 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4997 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4998 as modifiers.
4999 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5000
5001 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5002 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5003 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5004 presumably because the widths might not match.
5005
5006 * window.c (size_window): Avoid needless test at loop start.
5007
5008 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5009
5010 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5011
5012 2011-05-12 Drew Adams <drew.adams@oracle.com>
5013
5014 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5015
5016 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5017
5018 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5019 `width' to `bar_area_x' and `bar_area_width', respectively.
5020 (x_scroll_run): Take account of fringe background extension.
5021
5022 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5023 Rename local vars `left' and `width' to `bar_area_x' and
5024 `bar_area_width', respectively.
5025 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5026 background extension.
5027
5028 2011-05-10 Jim Meyering <meyering@redhat.com>
5029
5030 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5031
5032 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5033
5034 * image.c (Finit_image_library): Return t for built-in image types,
5035 like pbm and xbm. (Bug#8640)
5036
5037 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5038
5039 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5040
5041 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5042
5043 * w32console.c (Fset_screen_color): Doc fix.
5044 (Fget_screen_color): New function.
5045 (syms_of_ntterm): Defsubr it.
5046
5047 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5048 unlink the temporary file if Fcall_process didn't create it in the
5049 first place.
5050 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5051 child process will be redirected to a file specified with `:file'.
5052 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5053 cue to call_process_cleanup not to close that handle.
5054
5055 2011-05-07 Ben Key <bkey76@gmail.com>
5056
5057 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5058 one of two shell specific rules, either bootstrap-temacs-CMD or
5059 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5060 to the previous implementation of the bootstrap-temacs rule.
5061 The bootstrap-temacs-CMD rule is similar to the previous
5062 implementation of the bootstrap-temacs rule except that it
5063 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5064 variable.
5065
5066 These changes, along with some changes to nt/configure.bat,
5067 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5068 earlier fix to add support for --cflags and --ldflags options
5069 that include quotes so that it works whether make uses cmd or
5070 sh as the shell.
5071
5072 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5073
5074 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5075 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5076 is a constant.
5077 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5078 a string. Handle both cases.
5079 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5080 (Fdbus_register_method): Use Qinvalid_function.
5081
5082 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5083
5084 * makefile.w32-in: Update dependencies.
5085 (LISP_H): Add inttypes.h and stdin.h.
5086 (PROCESS_H): Add unistd.h.
5087
5088 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5089
5090 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5091 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5092
5093 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5094
5095 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5096
5097 * term.c (vfatal): Remove stray call to va_end.
5098 It's not needed and the C Standard doesn't allow it here anyway.
5099
5100 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5101 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5102
5103 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5104 bytes.
5105
5106 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5107
5108 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5109
5110 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5111
5112 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5113
5114 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5115
5116 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5117 * charset.c (Fdefine_charset_internal): Don't initialize
5118 charset.code_space[15]. The value was garbage, on hosts with
5119 32-bit int (Bug#8600).
5120
5121 * lread.c (read_integer): Be more consistent with string-to-number.
5122 Use string_to_number to do the actual conversion; this avoids
5123 rounding errors and fixes some other screwups. Without this fix,
5124 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5125 (digit_to_number): Move earlier, for benefit of read_integer.
5126 Return -1 if the digit is out of range for the base, -2 if it is
5127 not a digit in any supported base. (Bug#8602)
5128
5129 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5130
5131 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5132 to match comment at start of function. This also removes a
5133 GCC warning about overflow in a 32+64-bit port.
5134
5135 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5136
5137 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5138 Reported by Stefan Monnier in
5139 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5140 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5141 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5142
5143 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5144 (EMACS_UINTPTR): Likewise, with uintptr_t.
5145
5146 * lisp.h: Prefer 64-bit EMACS_INT if available.
5147 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5148 on 32-bit hosts that have 64-bit int, so that they can access
5149 large files.
5150 However, temporarily disable this change unless the temporary
5151 symbol WIDE_EMACS_INT is defined.
5152
5153 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5154
5155 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5156 This removes an assumption that EMACS_INT and long are the same
5157 width as pointers. The assumption is true for Emacs porting targets
5158 now, but we want to make other targets possible.
5159 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5160 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5161 In the rest of the code, change types of integers that hold casted
5162 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5163 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5164 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5165 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5166 No need to cast type when ORing.
5167 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5168 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5169 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5170 assume EMACS_INT is the same width as char *.
5171 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5172 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5173 Remove no-longer-needed casts.
5174 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5175 (xg_tool_bar_help_callback, xg_make_tool_item):
5176 Use EMACS_INTPTR to hold an integer
5177 that will be cast to void *; this can avoid a GCC warning
5178 if EMACS_INT is not the same width as void *.
5179 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5180 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5181 (current_message_1, set_message_1):
5182 Use a local to convert to proper width without a cast.
5183 * xmenu.c (dialog_selection_callback): Likewise.
5184
5185 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5186 Also, don't assume VALBITS / RAND_BITS is less than 5,
5187 and don't rely on undefined behavior when shifting a 1 left into
5188 the sign bit.
5189 * lisp.h (get_random): Change signature to match.
5190
5191 * lread.c (hash_string): Use size_t, not int, for hash computation.
5192 Normally we prefer signed values; but hashing is special, because
5193 it's better to use unsigned division on hash table sizes so that
5194 the remainder is nonnegative. Also, size_t is the natural width
5195 for hashing into memory. The previous code used 'int', which doesn't
5196 retain enough info to hash well into very large tables.
5197 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5198
5199 * dbusbind.c: Don't possibly lose pointer info when converting.
5200 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5201 Use XPNTR rather than XHASH, so that the high-order bits of
5202 the pointer aren't lost when converting through void *.
5203
5204 * eval.c (Fautoload): Don't double-shift a pointer.
5205
5206 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5207
5208 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5209
5210 * gnutls.c (DEF_GNUTLS_FN):
5211 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5212
5213 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5214
5215 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5216 marker. (Bug#8610)
5217
5218 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5219
5220 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5221 New version that can reserve upto 2GB of heap space.
5222
5223 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5224
5225 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5226
5227 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5228
5229 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5230 `gnutls_certificate_set_x509_key_file'.
5231
5232 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5233
5234 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5235 Update dependencies.
5236
5237 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5238
5239 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5240 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5241 Remove unused parameter `fildes'.
5242 * process.c (read_process_output, send_process): Don't pass it.
5243
5244 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5245
5246 Fix previous change: the library cache is defined in w32.c.
5247 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5248 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5249
5250 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5251
5252 Implement dynamic loading of GnuTLS on Windows.
5253
5254 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5255 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5256 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5257 Declare.
5258
5259 * gnutls.c (Qgnutls_dll): Define.
5260 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5261 (gnutls_*): Declare function pointers.
5262 (init_gnutls_functions): New function to initialize function pointers.
5263 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5264 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5265 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5266 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5267 (emacs_gnutls_write, emacs_gnutls_read)
5268 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5269 (Fgnutls_available_p): New function.
5270 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5271 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5272 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5273
5274 * image.c: Include w32.h.
5275 (Vimage_type_cache): Delete.
5276 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5277 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5278 (w32_delayed_load): Move to w32.c.
5279
5280 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5281
5282 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5283 (w32_delayed_load): Move from image.c. When loading a library, record
5284 its filename in the :loaded-from property of the library id.
5285 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5286 Initialize and staticpro them.
5287 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5288
5289 * process.c: Include lisp.h before w32.h, not after.
5290 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5291 instead of gnutls_record_check_pending.
5292
5293 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5294
5295 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5296
5297 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5298 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5299 as passed in.
5300
5301 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5302
5303 * xterm.c (x_set_frame_alpha): Do not set property on anything
5304 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5305
5306 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5307
5308 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5309
5310 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5311
5312 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5313 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5314 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5315 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5316 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5317 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5318 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5319 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5320 (Qgnutls_bootprop_callbacks_verify): Make static.
5321
5322 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5323
5324 * callproc.c: Indentation fixup.
5325
5326 * sysdep.c (wait_for_termination_1): Make static.
5327 (wait_for_termination, interruptible_wait_for_termination):
5328 Move after wait_for_termination_1.
5329
5330 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5331
5332 * sysdep.c (interruptible_wait_for_termination): New function
5333 which is like wait_for_termination, but allows keyboard
5334 interruptions.
5335
5336 * callproc.c (Fcall_process): Add (:file "file") as an option for
5337 the STDOUT buffer.
5338 (Fcall_process_region): Ditto.
5339
5340 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5341
5342 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5343 rather than `XVECTOR (FOO)->size'.
5344
5345 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5346 inttypes.h, as a gnulib replacement is used if it not available in
5347 system headers.
5348
5349 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5350
5351 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5352 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5353 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5354
5355 * coding.c (coding_alloc_by_realloc): Error out if destination
5356 will grow beyond MOST_POSITIVE_FIXNUM.
5357 (decode_coding_emacs_mule): Abort if there isn't enough place in
5358 charbuf for the composition carryover bytes. Reserve an extra
5359 space for up to 2 characters produced in a loop.
5360 (decode_coding_iso_2022): Abort if there isn't enough place in
5361 charbuf for the composition carryover bytes.
5362
5363 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5364
5365 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5366 aborting when %lld or %lll format is passed.
5367 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5368 %llo or %llx format is passed. (Bug#8545)
5369
5370 * window.c (window_scroll_line_based): Use a marker instead of
5371 simple variables to record original value of point. (Bug#7952)
5372
5373 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5374 produced by %s or %c overflows available buffer space. (Bug#8545)
5375
5376 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5377
5378 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5379 (SIZE_MAX): Move defn after all includes, as they might #define it.
5380
5381 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5382
5383 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5384
5385 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5386
5387 * keyboard.c (Qdelayed_warnings_hook): Define.
5388 (command_loop_1): Run `delayed-warnings-hook'
5389 if Vdelayed_warnings_list is non-nil.
5390 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5391 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5392
5393 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5394
5395 * doprnt.c (doprnt): Don't return value smaller than the buffer
5396 size if the message was truncated. (Bug#8545).
5397
5398 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5399
5400 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5401 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5402
5403 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5404
5405 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5406
5407 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5408
5409 * makefile.w32-in: Update dependencies.
5410
5411 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5412
5413 Improve `doprnt' and its usage. (Bug#8545)
5414 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5415 `format_end'. Remove support for %l as a conversion specifier.
5416 Don't use xrealloc. Improve diagnostics when the %l size modifier
5417 is used. Update the commentary.
5418
5419 * eval.c (verror): Simplify calculation of size_t.
5420
5421 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5422 messages.
5423
5424 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5425
5426 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5427 change.
5428
5429 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5430
5431 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5432 This makes this file independent of the recent pseudovector change.
5433
5434 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5435
5436 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5437
5438 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5439 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5440 Remove unused local.
5441 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5442
5443 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5444 GCC 4.6.0 optimizes based on type-based alias analysis.
5445 For example, if b is of type struct buffer * and v of type struct
5446 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5447 != &v->size, and therefore "v->size = 1; b->size = 2; return
5448 v->size;" must therefore return 1. This assumption is incorrect
5449 for Emacs, since it type-puns struct Lisp_Vector * with many other
5450 types. To fix this problem, this patch adds a new type struct
5451 vectorlike_header that documents the constraints on layout of vectors
5452 and pseudovectors, and helps optimizing compilers not get fooled
5453 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5454 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5455 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5456 the size member.
5457 (XSETPVECTYPE): Rewrite in terms of new macro.
5458 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5459 This is a bit clearer, and further avoids the possibility of
5460 undesirable aliasing.
5461 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5462 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5463 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5464 since Lisp_Subr is a special case (no "next" field).
5465 (ASIZE): Now uses header.size rather than size.
5466 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5467 to avoid the hassle of writing XVECTOR (foo)->header.size.
5468 (struct vectorlike_header): New type.
5469 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5470 object, to help avoid aliasing.
5471 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5472 (SUBRP): Likewise, since Lisp_Subr is a special case.
5473 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5474 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5475 (struct Lisp_Hash_Table): Combine first two members into a single
5476 struct vectorlike_header member. All uses of "size" and "next" members
5477 changed to be "header.size" and "header.next".
5478 * buffer.h (struct buffer): Likewise.
5479 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5480 * frame.h (struct frame): Likewise.
5481 * process.h (struct Lisp_Process): Likewise.
5482 * termhooks.h (struct terminal): Likewise.
5483 * window.c (struct save_window_data, struct saved_window): Likewise.
5484 * window.h (struct window): Likewise.
5485 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5486 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5487 * buffer.c (init_buffer_once): Likewise.
5488 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5489 special case.
5490 * process.c (Fformat_network_address): Use local var for size,
5491 for brevity.
5492
5493 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5494
5495 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5496 * data.c (atof): Remove decl; no longer used or needed.
5497 (digit_to_number): Move to lread.c.
5498 (Fstring_to_number): Use new string_to_number function, to be
5499 consistent with how the Lisp reader treats infinities and NaNs.
5500 Do not assume that floating-point numbers represent EMACS_INT
5501 without losing information; this is not true on most 64-bit hosts.
5502 Avoid double-rounding errors, by insisting on integers when
5503 parsing non-base-10 numbers, as the documentation specifies.
5504 * lisp.h (string_to_number): New decl, replacing ...
5505 (isfloat_string): Remove.
5506 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5507 (read1): Do not accept +. and -. as integers; this
5508 appears to have been a coding error. Similarly, do not accept
5509 strings like +-1e0 as floating point numbers. Do not report
5510 overflow for integer overflows unless the base is not 10 which
5511 means we have no simple and reliable way to continue.
5512 Break out the floating-point parsing into a new
5513 function string_to_number, so that Fstring_to_number parses
5514 floating point numbers consistently with the Lisp reader.
5515 (digit_to_number): Move here from data.c. Make it static inline.
5516 (E_CHAR, EXP_INT): Remove, replacing with ...
5517 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5518 (string_to_number): New function, replacing isfloat_string.
5519 This function checks for valid syntax and produces the resulting
5520 Lisp float number too. Rework it so that string-to-number
5521 no longer mishandles examples like "1.0e+". Use strtoumax,
5522 so that overflow for non-base-10 numbers is reported only when
5523 there's no portable and simple way to convert to floating point.
5524
5525 * textprop.c (set_text_properties_1): Rewrite for clarity,
5526 and to avoid GCC warning about integer overflow.
5527
5528 * intervals.h (struct interval): Use EMACS_INT for members
5529 where EMACS_UINT might cause problems. See
5530 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5531 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5532 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5533 All uses changed.
5534 (offset_intervals): Tell GCC not to worry about length overflow
5535 when negating a negative length.
5536
5537 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5538 (overrun_check_free): Likewise.
5539
5540 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5541 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5542 word size.
5543
5544 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5545 (gnutls_make_error): Rename local to avoid shadowing.
5546 (gnutls_emacs_global_deinit): ifdef out; not used.
5547 (Fgnutls_boot): Use const for pointer to readonly storage.
5548 Comment out unused local. Fix pointer signedness problems.
5549
5550 * lread.c (openp): Don't stuff size_t into an 'int'.
5551 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5552 about possible signed overflow.
5553
5554 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5555 (GDK_KEY_g): Don't define if already defined.
5556 (xg_prepare_tooltip): Avoid pointer signedness problem.
5557 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5558
5559 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5560 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5561
5562 * xfns.c (Fx_window_property): Simplify a bit,
5563 to make a bit faster and to avoid GCC 4.6.0 warning.
5564 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5565
5566 * fns.c (internal_equal): Don't assume size_t fits in int.
5567
5568 * alloc.c (compact_small_strings): Tighten assertion a little.
5569
5570 Replace pEd with more-general pI, and fix some printf arg casts.
5571 * lisp.h (pI): New macro, generalizing old pEd macro to other
5572 conversion specifiers. For example, use "...%"pI"d..." rather
5573 than "...%"pEd"...".
5574 (pEd): Remove. All uses replaced with similar uses of pI.
5575 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5576 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5577 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5578 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5579 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5580 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5581 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5582 64-bit hosts.
5583 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5584 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5585 * print.c (safe_debug_print, print_object): Likewise.
5586 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5587 to int.
5588 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5589 avoiding the 0 flag, which is not portable.
5590 * process.c (Fmake_network_process): Use pI to avoid cast.
5591 * region-cache.c (pp_cache): Likewise.
5592 * xdisp.c (decode_mode_spec): Likewise.
5593 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5594 behavior on 64-bit hosts with printf arg.
5595 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5596 (x_stop_queuing_selection_requests): Likewise.
5597 (x_get_window_property): Don't truncate byte count to an 'int'
5598 when tracing.
5599
5600 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5601 here, since it parses constructs like leading '-' and spaces,
5602 which are not wanted; and it overflows with large numbers.
5603 Instead, simply match F[0-9]+, which is what is wanted anyway.
5604
5605 * alloc.c: Remove unportable assumptions about struct layout.
5606 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5607 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5608 (allocate_vectorlike, make_pure_vector): Use the new macros,
5609 plus offsetof, to remove unportable assumptions about struct layout.
5610 These assumptions hold on all porting targets that I know of, but
5611 they are not guaranteed, they're easy to remove, and removing them
5612 makes further changes easier.
5613
5614 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5615 This doesn't fix a bug but makes the code clearer.
5616 (string_overrun_cookie): Now const. Use initializers that
5617 don't formally overflow signed char, to avoid warnings.
5618 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5619 can cause Emacs to crash when string overrun checking is enabled.
5620 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5621 multiple of sizeof (EMACS_INT); it need not be, if
5622 alignof(EMACS_INT) < sizeof (EMACS_INT).
5623 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5624
5625 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5626
5627 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5628
5629 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5630
5631 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5632 supposed to be handshaking. (Bug#8556)
5633 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5634
5635 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5636
5637 * lisp.h (Qdebug): List symbol.
5638 * eval.c (Qdebug): Restore global linkage.
5639 * keyboard.c (debug-on-event): New variable.
5640 (handle_user_signal): Break into debugger when debug-on-event
5641 matches the current signal symbol.
5642
5643 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5644
5645 * alloc.c (check_sblock, check_string_bytes)
5646 (check_string_free_list): Convert to standard C.
5647
5648 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5649
5650 * w32.c (emacs_gnutls_push): Fix typo.
5651
5652 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5653
5654 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5655 "cast to pointer from integer of different size".
5656
5657 Improve doprnt and its use in verror. (Bug#8545)
5658 * doprnt.c (doprnt): Document the set of format control sequences
5659 supported by the function. Use SAFE_ALLOCA instead of always
5660 using `alloca'.
5661
5662 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5663 is one byte too soon. Don't use xrealloc; instead xfree and
5664 xmalloc anew.
5665
5666 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5667
5668 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5669 callbacks stage.
5670
5671 * gnutls.c: Renamed global_initialized to
5672 gnutls_global_initialized. Added internals for the
5673 :verify-hostname-error, :verify-error, and :verify-flags
5674 parameters of `gnutls-boot' and documented those parameters in the
5675 docstring. Start callback support.
5676 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5677 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5678 on error. Return error code.
5679 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5680 (emacs_gnutls_read): Likewise.
5681 (Fgnutls_boot): Return handshake error code.
5682 (emacs_gnutls_handle_error): New function.
5683 (wsaerror_to_errno): Likewise.
5684
5685 * w32.h (emacs_gnutls_pull): Add prototype.
5686 (emacs_gnutls_push): Likewise.
5687
5688 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5689 (emacs_gnutls_push): Likewise.
5690
5691 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5692
5693 * process.c (wait_reading_process_output): Check if GnuTLS
5694 buffered some data internally if no FDs are set for TLS
5695 connections.
5696
5697 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5698 (LIBS): Link to USER_LIBS.
5699 ($(BLD)/gnutls.$(0)): New target.
5700
5701 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5702
5703 * xdisp.c (handle_single_display_spec): Rename the
5704 display_replaced_before_p argument into display_replaced_p, to
5705 make it consistent with the commentary. Fix typos in the
5706 commentary.
5707
5708 * textprop.c (syms_of_textprop): Remove dead code.
5709 (copy_text_properties): Delete obsolete commentary about an
5710 interface that was deleted long ago. Fix typos in the description
5711 of arguments.
5712
5713 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5714 to changes in oldXMenu/XMenu.h from 2011-04-16.
5715 <menu_help_message, prev_menu_help_message>: Constify.
5716 (IT_menu_make_room): menu->help_text is now `const char **';
5717 adjust.
5718
5719 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5720 to changes in oldXMenu/XMenu.h from 2011-04-16.
5721 (struct XMenu): Declare `help_text' `const char **'.
5722
5723 * xfaces.c <Qunspecified>: Make extern again.
5724
5725 * syntax.c: Include sys/types.h before including regex.h, as
5726 required by Posix.
5727
5728 * doc.c (get_doc_string): Improve the format passed to `error'.
5729
5730 * doprnt.c (doprnt): Improve commentary.
5731
5732 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5733
5734 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5735 them with etags.
5736
5737 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5738 changes in globals.h immediately force recompilation.
5739 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5740 $(CURDIR)/s/ms-w32.h.
5741 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5742
5743 * character.c (Fchar_direction): Function deleted.
5744 (syms_of_character): Don't defsubr it.
5745 <char-direction-table>: Deleted.
5746
5747 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5748
5749 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5750 * doprnt.c: Include limits.h.
5751 (SIZE_MAX): New macro.
5752 (doprnt): Return a size_t value. 2nd arg is now size_t.
5753 Many local variables are now size_t instead of int or unsigned.
5754 Improve overflow protection. Support `l' modifier for integer
5755 conversions. Support %l conversion. Don't assume an EMACS_INT
5756 argument for integer conversions and for %c.
5757
5758 * lisp.h (doprnt): Restore prototype.
5759
5760 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5761 $(SRC)/character.h.
5762
5763 * Makefile.in (base_obj): Add back doprnt.o.
5764
5765 * deps.mk (doprnt.o): Add back prerequisites.
5766 (callint.o): Depend on character.h.
5767
5768 * eval.c (internal_lisp_condition_case): Include the handler
5769 representation in the error message.
5770 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5771 when breaking from the loop.
5772
5773 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5774
5775 * callint.c (Fcall_interactively): When displaying error message
5776 about invalid control letter, pass the character's codepoint, not
5777 a pointer to its multibyte form. Improve display of the character
5778 in octal and display also its hex code.
5779
5780 * character.c (char_string): Use %x to display the (unsigned)
5781 codepoint of an invalid character, to avoid displaying a bogus
5782 negative value.
5783
5784 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5785 `error', not SYMBOL_NAME itself.
5786
5787 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5788 character arguments to `error'.
5789
5790 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5791 to `error' in error message about FINAL_CHAR argument. Make sure
5792 FINAL_CHAR is a character, and use %c when it is passed as
5793 argument to `error'.
5794
5795 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5796
5797 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5798
5799 * w32.c: Include <time.h>.
5800 (sys_localtime): New function.
5801
5802 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5803
5804 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5805
5806 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5807
5808 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5809
5810 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5811 zombies (Bug#8467).
5812
5813 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5814
5815 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5816 gl_state.e_property when gl_state.object is Qt.
5817
5818 * insdel.c (make_gap_larger): Remove limitation of buffer size
5819 to <= INT_MAX.
5820
5821 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5822
5823 * xdisp.c (lookup_glyphless_char_display)
5824 (produce_glyphless_glyph): Handle cons cell entry in
5825 glyphless-char-display.
5826 (Vglyphless_char_display): Document it.
5827
5828 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5829 glyphless-char-display.
5830
5831 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5832
5833 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5834
5835 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5836
5837 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5838 definition for no-X builds.
5839
5840 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5841
5842 Static checks with GCC 4.6.0 and non-default toolkits.
5843
5844 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5845
5846 * process.c (keyboard_bit_set): Define only if SIGIO.
5847 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5848 (send_process): Repair possible setjmp clobbering.
5849
5850 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5851
5852 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5853
5854 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5855
5856 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5857 Define only if needed.
5858
5859 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5860 by pacifying GCC about it. Maybe it's time to retire it?
5861 * xfaces.c (USG, __TIMEVAL__): Likewise.
5862
5863 * dispextern.h (struct redisplay_interface): Rename param
5864 to avoid shadowing.
5865 * termhooks.h (struct terminal): Likewise.
5866 * xterm.c (xembed_send_message): Likewise.
5867
5868 * insdel.c (make_gap_smaller): Define only if
5869 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5870
5871 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5872 it.
5873
5874 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5875 so that we aren't warned about unused symbols.
5876
5877 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5878
5879 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5880
5881 * xfns.c (x_real_positions): Mark locals as initialized.
5882
5883 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5884
5885 * xterm.c: Fix problems found by static analysis with other toolkits.
5886 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5887 (x_dispatch_event): Declare static if USE_GTK, and
5888 define if USE_GTK || USE_X_TOOLKIT.
5889 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5890 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5891 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5892 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5893
5894 * xmenu.c (menu_help_callback): Pointer type fixes.
5895 Use const pointers when pointing at readonly data. Avoid pointer
5896 signedness clashes.
5897 (FALSE): Remove unused macro.
5898 (update_frame_menubar): Remove unused decl.
5899
5900 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5901
5902 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5903 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5904 (single_menu_item): Rename local to avoid shadowing.
5905
5906 * keyboard.c (make_lispy_event): Remove unused local var.
5907
5908 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5909 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5910
5911 * bitmaps: Change bitmaps from unsigned char back to the X11
5912 compatible char. Avoid the old compiler warnings about
5913 out-of-range initializers by using, for example, '\xab' rather
5914 than 0xab.
5915
5916 * xgselect.c (xgselect_initialize): Check vs interface
5917 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5918
5919 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5920
5921 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5922 to read-only memory.
5923
5924 * fns.c (vector): Remove; this old hack is no longer needed.
5925
5926 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5927 Remove unused var.
5928 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5929
5930 * xrdb.c (x_load_resources): Omit unused local.
5931
5932 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5933 (x_window): Rename locals to avoid shadowing.
5934 (USG): Use the kludged USG macro, to pacify gcc.
5935
5936 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5937 (x_term_init): Remove local to avoid shadowing.
5938
5939 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5940
5941 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5942 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5943
5944 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5945
5946 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5947
5948 Fix regex.c, syntax.c and friends for buffers > 2GB.
5949 * syntax.h (struct gl_state_s): Declare character position members
5950 EMACS_INT.
5951
5952 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5953
5954 * textprop.c (verify_interval_modification, interval_of):
5955 Declare arguments EMACS_INT.
5956
5957 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5958 EMACS_INT.
5959
5960 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5961
5962 * indent.c (Fvertical_motion): Local variable it_start is now
5963 EMACS_INT.
5964
5965 * regex.c (re_match, re_match_2, re_match_2_internal)
5966 (bcmp_translate, regcomp, regexec, print_double_string)
5967 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5968 (re_compile_pattern, re_exec): Declare arguments and local
5969 variables `size_t' and `ssize_t' and return values `regoff_t', as
5970 appropriate.
5971 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5972 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5973 <compile_stack_type>: `size' and `avail' are now `size_t'.
5974
5975 * regex.h <regoff_t>: Use ssize_t, not int.
5976 (re_search, re_search_2, re_match, re_match_2): Arguments that
5977 specify buffer/string position and length are now ssize_t and
5978 size_t. Return type is regoff_t.
5979
5980 2011-04-16 Ben Key <bkey76@gmail.com>
5981
5982 * nsfont.m: Fixed bugs in ns_get_family and
5983 ns_descriptor_to_entity that were caused by using free to
5984 deallocate memory blocks that were allocated by xmalloc (via
5985 xstrdup). This caused Emacs to crash when compiled with
5986 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5987 --enable-checking=xmallocoverrun). xfree is now used to
5988 deallocate these memory blocks.
5989
5990 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5991
5992 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5993
5994 emacs_write: Accept and return EMACS_INT for sizes.
5995 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5996 et seq.
5997 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5998 Accept and return EMACS_INT.
5999 (emacs_gnutls_write): Return the number of bytes written on
6000 partial writes.
6001 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6002 (emacs_read, emacs_write): Remove check for negative size, as the
6003 Emacs source code has been audited now.
6004 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6005 (emacs_read, emacs_write): Use it.
6006 * process.c (send_process): Adjust to the new signatures of
6007 emacs_write and emacs_gnutls_write. Do not attempt to store
6008 a byte offset into an 'int'; it might overflow.
6009 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6010
6011 * sound.c: Don't assume sizes fit in 'int'.
6012 (struct sound_device.period_size, alsa_period_size):
6013 Return EMACS_INT, not int.
6014 (struct sound_device.write, vox_write, alsa_write):
6015 Accept EMACS_INT, not int.
6016 (wav_play, au_play): Use EMACS_INT to store sizes and to
6017 record read return values.
6018
6019 2011-04-15 Ben Key <bkey76@gmail.com>
6020
6021 * keyboard.c (Qundefined): Don't declare static since it is used
6022 in nsfns.m.
6023 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6024 static since they are used in nsfont.m.
6025
6026 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6027
6028 * process.c (Qprocessp): Don't declare static.
6029 * lisp.h (Qprocessp): Declare again.
6030
6031 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6032
6033 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6034
6035 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6036
6037 Improve C-level modularity by making more things 'static'.
6038
6039 Don't publish debugger-only interfaces to other modules.
6040 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6041 (verify_bytepos, count_markers): Move decls to the only modules
6042 that need them.
6043 * region-cache.h (pp_cache): Likewise.
6044 * window.h (check_all_windows): Likewise.
6045 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6046
6047 * sysdep.c (croak): Now static, if
6048 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6049 * syssignal.h (croak): Declare only if not static.
6050
6051 * alloc.c (refill_memory_reserve): Now static if
6052 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6053 * lisp.h (refill_memory_reserve): Declare only if not static.
6054
6055 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6056 Define only if USE_LUCID.
6057
6058 * xrdb.c (x_customization_string, x_rm_string): Now static.
6059
6060 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6061 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6062
6063 * xdisp.c (draw_row_with_mouse_face): Now static.
6064 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6065
6066 * window.h (check_all_windows): Mark externally visible.
6067
6068 * window.c (window_deletion_count): Now static.
6069
6070 * undo.c: Make symbols static if they're not exported.
6071 (last_undo_buffer, last_boundary_position, pending_boundary):
6072 Now static.
6073
6074 * textprop.c (interval_insert_behind_hooks): Now static.
6075 (interval_insert_in_front_hooks): Likewise.
6076
6077 * term.c: Make symbols static if they're not exported.
6078 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6079 (max_frame_lines, tty_set_terminal_modes):
6080 (tty_reset_terminal_modes, tty_turn_off_highlight):
6081 (get_tty_terminal): Now static.
6082 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6083 * termhooks.h (term_mouse_moveto): Do not declare if
6084 HAVE_WINDOW_SYSTEM.
6085 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6086 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6087
6088 * sysdep.c: Make symbols static if they're not exported.
6089 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6090 Now static.
6091 (sigprocmask_set, full_mask): Remove; unused.
6092 (wait_debugging): Mark as visible.
6093 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6094 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6095
6096 * syntax.c (syntax_temp): Define only if !__GNUC__.
6097
6098 * sound.c (current_sound_device, current_sound): Now static.
6099
6100 * search.c (searchbufs, searchbuf_head): Now static.
6101
6102 * scroll.c (scroll_cost): Remove; unused.
6103 * dispextern.h (scroll_cost): Remove decl.
6104
6105 * region-cache.h (pp_cache): Mark as externally visible.
6106
6107 * process.c: Make symbols static if they're not exported.
6108 (process_tick, update_tick, create_process, chan_process):
6109 (Vprocess_alist, proc_buffered_char, datagram_access):
6110 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6111 (deactivate_process): Mark defn as static, as well as decl.
6112 * lisp.h (create_process): Remove decl.
6113 * process.h (chan_process, Vprocess_alist): Remove decls.
6114
6115 * print.c: Make symbols static if they're not exported.
6116 (print_depth, new_backquote_output, being_printed, print_buffer):
6117 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6118 (print_interval, print_number_index, initial_stderr_stream):
6119 Now static.
6120 * lisp.h (Fprinc): Remove decl.
6121 (debug_output_compilation_hack): Mark as externally visible.
6122
6123 * sysdep.c (croak): Move decl from here to syssignal.h.
6124 * syssignal.h (croak): Put it here, so the API can be checked when
6125 'croak' is called from dissociate_if_controlling_tty.
6126
6127 * minibuf.c: Make symbols static if they're not exported.
6128 (minibuf_save_list, choose_minibuf_frame): Now static.
6129 * lisp.h (choose_minibuf_frame): Remove decl.
6130
6131 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6132
6133 * lread.c: Make symbols static if they're not exported.
6134 (read_objects, initial_obarray, oblookup_last_bucket_number):
6135 Now static.
6136 (make_symbol): Remove; unused.
6137 * lisp.h (initial_obarray, make_symbol): Remove decls.
6138
6139 * keyboard.c: Make symbols static if they're not exported.
6140 (single_kboard, recent_keys_index, total_keys, recent_keys):
6141 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6142 (this_single_command_key_start, echoing, last_auto_save):
6143 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6144 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6145 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6146 (Vlispy_mouse_stem, double_click_count):
6147 Now static.
6148 (force_auto_save_soon): Define only if SIGDANGER.
6149 (ignore_mouse_drag_p): Now static if
6150 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6151 (print_help): Remove; unused.
6152 (stop_character, last_timer_event): Mark as externally visible.
6153 * keyboard.h (ignore_mouse_drag_p): Declare only if
6154 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6155 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6156 * lisp.h (echoing): Remove decl.
6157 (force_auto_save_soon): Declare only if SIGDANGER.
6158 * xdisp.c (redisplay_window): Simplify code, to make it more
6159 obvious that ignore_mouse_drag_p is not accessed if !defined
6160 USE_GTK && !defined HAVE_NS.
6161
6162 * intervals.c: Make symbols static if they're not exported.
6163 (merge_properties_sticky, merge_interval_right, delete_interval):
6164 Now static.
6165 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6166
6167 * insdel.c: Make symbols static if they're not exported.
6168 However, leave prepare_to_modify_buffer alone. It's never
6169 called from outside this function, but that appears to be a bug.
6170 (combine_after_change_list, combine_after_change_buffer):
6171 (adjust_after_replace, signal_before_change): Now static.
6172 (adjust_after_replace_noundo): Remove; unused.
6173 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6174 (signal_before_change): Remove decls.
6175
6176 * indent.c (val_compute_motion, val_vmotion): Now static.
6177
6178 * image.c: Make symbols static if they're not exported.
6179 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6180 if USE_GTK.
6181 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6182 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6183
6184 * fringe.c (standard_bitmaps): Now static.
6185 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6186
6187 * frame.c: Make symbols static if they're not exported.
6188 (x_report_frame_params, make_terminal_frame): Now static.
6189 (get_frame_param): Now static, unless HAVE_NS.
6190 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6191 (x_get_resource_string): Remove; not used.
6192 * frame.h (make_terminal_frame, x_report_frame_params):
6193 (x_get_resource_string); Remove decls.
6194 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6195 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6196
6197 * font.c, fontset.c: Make symbols static if they're not exported.
6198 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6199 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6200 * font.c (font_close_object): Now static.
6201 * font.h (font_close_object): Remove.
6202 * fontset.c (FONTSET_OBJLIST): Remove.
6203 (free_realized_fontset) #if-0 the body, which does nothing.
6204 (face_suitable_for_char_p): #if-0, as it's never called.
6205 * fontset.h (face_suitable_for_char_p): Remove decl.
6206 * xfaces.c (face_at_string_position):
6207 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6208 since 0 is always ASCII.
6209
6210 * fns.c (weak_hash_tables): Now static.
6211
6212 * fileio.c: Make symbols static if they're not exported.
6213 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6214 (Vwrite_region_annotation_buffers): Now static.
6215
6216 * eval.c: Make symbols static if they're not exported.
6217 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6218 * lisp.h (backtrace_list): Remove decl.
6219
6220 * emacs.c: Make symbols static if they're not exported.
6221 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6222 (fatal_error_code, fatal_error_signal_hook, standard_args):
6223 Now static.
6224 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6225 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6226 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6227 * lisp.h (fatal_error_signal_hook): Remove decl.
6228 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6229
6230 * editfns.c: Move a (normally-unused) function to its only use.
6231 * editfns.c, lisp.h (get_operating_system_release): Remove.
6232 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6233 worth the hassle of breaking this out.
6234
6235 * xterm.c: Make symbols static if they're not exported.
6236 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6237 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6238 (x_destroy_window, x_delete_display):
6239 Now static.
6240 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6241 (x_mouse_leave): Remove; unused.
6242 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6243 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6244 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6245 Remove decls.
6246 (x_mouse_leave): Declare only if WINDOWSNT.
6247 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6248 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6249 USE_X_TOOLKIT.
6250
6251 * ftxfont.c: Make symbols static if they're not exported.
6252 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6253 HAVE_FREETYPE.
6254 * font.h (ftxfont_driver): Likewise.
6255
6256 * xfns.c: Make symbols static if they're not exported.
6257 (x_last_font_name, x_display_info_for_name):
6258 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6259 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6260 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6261 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6262 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6263 (last_show_tip_args): Now static.
6264 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6265 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6266 (x_screen_planes): Remove; unused.
6267 * dispextern.h (x_screen_planes): Remove decl.
6268
6269 * dispnew.c: Make symbols static if they're not exported.
6270 * dispextern.h (redraw_garbaged_frames, scrolling):
6271 (increment_row_positions): Remove.
6272 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6273 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6274 Now static.
6275 (redraw_garbaged_frames): Remove; unused.
6276
6277 * xfaces.c: Make symbols static if they're not exported.
6278 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6279 Remove decls.
6280 * xterm.h (defined_color): Remove decls.
6281 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6282 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6283 (menu_face_changed_default, defined_color, free_realized_face):
6284 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6285 (ascii_face_of_lisp_face): Remove; unused.
6286
6287 * xdisp.c: Make symbols static if they're not exported.
6288 * dispextern.h (scratch_glyph_row, window_box_edges):
6289 (glyph_to_pixel_coords, set_cursor_from_row):
6290 (get_next_display_element, set_iterator_to_next):
6291 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6292 (show_mouse_face): Remove decls
6293 * frame.h (message_buf_print): Likewise.
6294 * lisp.h (pop_message, set_message, check_point_in_composition):
6295 Likewise.
6296 * xterm.h (set_vertical_scroll_bar): Likewise.
6297 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6298 (message_buf_print, scratch_glyph_row, displayed_buffer):
6299 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6300 (get_next_display_element, show_mouse_face, window_box_edges):
6301 (frame_to_window_pixel_xy, check_point_in_composition):
6302 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6303 (glyph_to_pixel_coords): Remove; unused.
6304
6305 * dired.c (file_name_completion): Now static.
6306
6307 * dbusbind.c (xd_in_read_queued_messages): Now static.
6308
6309 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6310 * data.c (circular_list_error): Remove.
6311
6312 * commands.h (last_point_position, last_point_position_buffer):
6313 (last_point_position_window): Remove decls.
6314 * keyboard.c: Make these variables static.
6315
6316 * coding.h (coding, code_convert_region, encode_coding_gap):
6317 Remove decls.
6318 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6319 (iso_code_class, detect_coding, code_convert_region): Now static.
6320 (encode_coding_gap): Remove; unused.
6321
6322 * chartab.c (chartab_chars, chartab_bits): Now static.
6323
6324 * charset.h (charset_iso_8859_1): Remove decl.
6325 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6326 Now static.
6327
6328 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6329 * ccl.c (Vccl_program_table): Now static.
6330 (check_ccl_update): Remove; unused.
6331
6332 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6333 * category.h: ... from here.
6334 * category.c (check_category_table, set_category_set): Now static.
6335
6336 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6337 * lisp.h: Remove these decls.
6338
6339 * buffer.c (buffer_count): Remove unused var.
6340
6341 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6342 so that it's not optimized away.
6343 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6344 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6345 exported only to the debugger.
6346
6347 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6348 * atimer.h (run_all_atimers): Remove; not exported.
6349
6350 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6351 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6352 was inaccessible from Lisp.
6353 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6354 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6355
6356 alloc.c: Import and export fewer symbols, and remove unused items.
6357 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6358 is defined.
6359 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6360 it's not optimized away by whole-program optimization.
6361 (message_enable_multibyte, free_misc): Remove.
6362 (catchlist, handlerlist, mark_backtrace):
6363 Declare only if BYTE_MARK_STACK.
6364 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6365 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6366 (message_enable_multibyte): Remove decl.
6367 (free_misc, interval_free_list, float_block, float_block_index):
6368 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6369 (cons_free_list, last_marked_index):
6370 Now static.
6371 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6372 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6373 (mark_backtrace): Define only if BYTE_MARK_STACK.
6374 * xdisp.c (message_enable_multibyte): Now static.
6375
6376 Declare Lisp_Object Q* variables to be 'static' if not exported.
6377 This makes it easier for human readers (and static analyzers)
6378 to see whether these variables are used from other modules.
6379 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6380 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6381 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6382 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6383 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6384 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6385 * xmenu.c, xselect.c:
6386 Declare Q* vars static if they are not used in other modules.
6387 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6388 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6389 Remove decls of unexported vars.
6390 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6391
6392 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6393
6394 Make Emacs functions such as Fatom 'static' by default.
6395 This makes it easier for human readers (and static analyzers)
6396 to see whether these functions can be called from other modules.
6397 DEFUN now defines a static function. To make the function external
6398 so that it can be used in other C modules, use the new macro DEFUE.
6399 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6400 (Finit_image_library):
6401 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6402 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6403 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6404 Remove decls, since these functions are now static.
6405 (Funintern, Fget_internal_run_time): New decls, since these functions
6406 were already external.
6407
6408 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6409 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6410 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6411 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6412 * keyboard.c, keymap.c, lread.c:
6413 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6414 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6415 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6416 Mark functions with DEFUE instead of DEFUN,
6417 if they are used in other modules.
6418 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6419 decls for now-static functions.
6420 * buffer.h (Fdelete_overlay): Remove decl.
6421 * callproc.c (Fgetenv_internal): Mark as internal.
6422 * composite.c (Fremove_list_of_text_properties): Remove decl.
6423 (Fcomposition_get_gstring): New forward static decl.
6424 * composite.h (Fcomposite_get_gstring): Remove decl.
6425 * dired.c (Ffile_attributes): New forward static decl.
6426 * doc.c (Fdocumntation_property): New forward static decl.
6427 * eval.c (Ffetch_bytecode): New forward static decl.
6428 (Funintern): Remove extern decl; now in .h file where it belongs.
6429 * fileio.c (Fmake_symbolic_link): New forward static decl.
6430 * image.c (Finit_image_library): New forward static decl.
6431 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6432 * intervals.h (Fprevious_property_change):
6433 (Fremove_list_of_text_properties): Remove decls.
6434 * keyboard.c (Fthis_command_keys): Remove decl.
6435 (Fcommand_execute): New forward static decl.
6436 * keymap.c (Flookup_key): New forward static decl.
6437 (Fcopy_keymap): Now static.
6438 * keymap.h (Flookup_key): Remove decl.
6439 * process.c (Fget_process): New forward static decl.
6440 (Fprocess_datagram_address): Mark as internal.
6441 * syntax.c (Fsyntax_table_p): New forward static decl.
6442 (skip_chars): Remove duplicate decl.
6443 * textprop.c (Fprevious_property_change): New forward static decl.
6444 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6445 Now internal.
6446 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6447 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6448
6449 * editfns.c (Fformat): Remove unreachable code.
6450
6451 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6452
6453 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6454 change. (Bug#8496)
6455
6456 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6457
6458 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6459 when at ZV. (Bug#8487)
6460
6461 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6462
6463 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6464 (Bug#8437)
6465 * keyboard.c (parse_tool_bar_item): Likewise.
6466 * sound.c (sound_cleanup, alsa_close): Likewise.
6467 * termcap.c (tgetent): Likewise.
6468 * xfns.c (x_default_font_parameter): Likewise.
6469 * xsettings.c (read_and_apply_settings): Likewise.
6470
6471 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6472 (overrun_check_free): Protoize.
6473
6474 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6475
6476 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6477 since callers should never pass a negative size.
6478 Change the signature to match that of plain 'read' and 'write'; see
6479 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6480 * lisp.h: Update prototypes of emacs_write and emacs_read.
6481
6482 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6483
6484 * xdisp.c (redisplay_window): Don't try to determine the character
6485 position of the scroll margin if the window start point w->startp
6486 is outside the buffer's accessible region. (Bug#8468)
6487
6488 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6489
6490 Fix write-region and its subroutines for buffers > 2GB.
6491 * fileio.c (a_write, e_write): Modify declaration of arguments and
6492 local variables to support buffers larger than 2GB.
6493 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6494
6495 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6496 argument, local variables, and return value.
6497
6498 * lisp.h: Update prototypes of emacs_write and emacs_read.
6499
6500 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6501
6502 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6503
6504 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6505
6506 Fix more problems found by GCC 4.6.0's static checks.
6507
6508 * xdisp.c (vmessage): Use a better test for character truncation.
6509
6510 * charset.c (load_charset_map): <, not <=, for optimization,
6511 and to avoid potential problems with integer overflow.
6512 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6513 * casetab.c (set_identity, shuffle): Likewise.
6514 * editfns.c (Fformat): Likewise.
6515 * syntax.c (skip_chars): Likewise.
6516
6517 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6518 This also lets GCC 4.6.0 generate slightly better loop code.
6519
6520 * callint.c (Fcall_interactively): <, not <=, for optimization.
6521 (Fcall_interactively): Count the number of arguments produced,
6522 not the number of arguments given. This is simpler and lets GCC
6523 4.6.0 generate slightly better code.
6524
6525 * ftfont.c: Distingish more carefully between FcChar8 and char.
6526 The previous code passed unsigned char * to a functions like
6527 strlen and xstrcasecmp that expect char *, which does not
6528 conform to the C standard.
6529 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6530 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6531 char * when the C standard requires it.
6532
6533 * keyboard.c (read_char): Remove unused var.
6534
6535 * eval.c: Port to Windows vsnprintf (Bug#8435).
6536 Include <limits.h>.
6537 (SIZE_MAX): Define if the headers do not.
6538 (verror): Do not give up if vsnprintf returns a negative count.
6539 Instead, grow the buffer. This ports to Windows vsnprintf, which
6540 does not conform to C99. Problem reported by Eli Zaretskii.
6541 Also, simplify the allocation scheme, by avoiding the need for
6542 calling realloc, and removing the ALLOCATED variable.
6543
6544 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6545
6546 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6547 But keep the doprint source code for now, as we might revamp it
6548 and use it again (Bug#8435).
6549 * lisp.h (doprnt): Remove.
6550 * Makefile.in (base_obj): Remove doprnt.o.
6551 * deps.mk (doprnt.o): Remove.
6552
6553 error: Print 32- and 64-bit integers portably (Bug#8435).
6554 Without this change, on typical 64-bit hosts error ("...%d...", N)
6555 was used to print both 32- and 64-bit integers N, which relied on
6556 undefined behavior.
6557 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6558 New macro.
6559 * lisp.h (error, verror): Mark as printf-like functions.
6560 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6561 Report overflow in size calculations when allocating printf buffer.
6562 Do not truncate output string at its first null byte.
6563 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6564 Truncate the output at a character boundary, since vsnprintf does not
6565 do that.
6566 * charset.c (check_iso_charset_parameter): Convert internal
6567 character to string before calling 'error', since %c now has the
6568 printf meaning.
6569 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6570 overflow when computing char to be passed to 'error'. Do not
6571 pass Lisp_Object to 'error'; pass the integer instead.
6572 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6573 formatted with plain %d.
6574
6575 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6576
6577 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6578
6579 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6580
6581 * xterm.c (x_catch_errors): Remove duplicate declaration.
6582
6583 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6584
6585 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6586
6587 2011-04-10 Jim Meyering <meyering@redhat.com>
6588
6589 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6590 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6591 return ssize_t not "int", and use size_t as the buffer length.
6592 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6593 * gnutls.h: Update declarations.
6594 * process.c (read_process_output): Use ssize_t, to match.
6595 (send_process): Likewise.
6596
6597 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6598
6599 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6600
6601 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6602
6603 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6604 Use unsigned char, to match FcChar8 type definition.
6605
6606 * xterm.c (handle_one_xevent):
6607 * xmenu.c (create_and_show_popup_menu):
6608 * xselect.c (x_decline_selection_request)
6609 (x_reply_selection_request): Avoid type-punned deref of X events.
6610
6611 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6612
6613 Fix some uses of `int' instead of EMACS_INT.
6614 * search.c (string_match_1, fast_string_match)
6615 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6616 (scan_buffer, find_next_newline_no_quit)
6617 (find_before_next_newline, search_command, Freplace_match)
6618 (Fmatch_data): Make some `int' variables be EMACS_INT.
6619
6620 * xdisp.c (display_count_lines): 3rd argument and return value now
6621 EMACS_INT. All callers changed.
6622 (pint2hrstr): Last argument is now EMACS_INT.
6623
6624 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6625 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6626 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6627 (decode_coding_utf_16, decode_coding_emacs_mule)
6628 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6629 (decode_coding_ccl, decode_coding_charset)
6630 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6631 (decode_coding_iso_2022, decode_coding_emacs_mule)
6632 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6633 <char_offset, last_offset>: Declare EMACS_INT.
6634 (encode_coding_utf_8, encode_coding_utf_16)
6635 (encode_coding_emacs_mule, encode_invocation_designation)
6636 (encode_designation_at_bol, encode_coding_iso_2022)
6637 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6638 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6639 Declare EMACS_INT.
6640 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6641 (encode_invocation_designation): Last argument P_NCHARS is now
6642 EMACS_INT.
6643 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6644 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6645
6646 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6647 All users changed.
6648
6649 * ccl.c (Fccl_execute_on_string): Declare some variables
6650 EMACS_INT.
6651
6652 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6653
6654 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6655
6656 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6657
6658 * process.c (Fformat_network_address): Doc fix.
6659
6660 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6661
6662 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6663
6664 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6665
6666 * keyboard.c (read_char): Call Lisp function help-form-show,
6667 instead of using internal_with_output_to_temp_buffer.
6668 (Qhelp_form_show): New var.
6669 (syms_of_keyboard): Use DEFSYM macro.
6670
6671 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6672
6673 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6674
6675 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6676
6677 * process.c (Flist_processes): Remove to Lisp.
6678 (list_processes_1): Delete.
6679
6680 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6681
6682 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6683
6684 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6685
6686 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6687
6688 Fix more problems found by GCC 4.6.0's static checks.
6689
6690 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6691
6692 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6693
6694 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6695
6696 * xdisp.c (vmessage): Mark as a printf-like function.
6697
6698 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6699
6700 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6701
6702 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6703 printf-like functions.
6704 (tiff_load): Add casts to remove these marks before passing them
6705 to system-supplied API.
6706
6707 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6708
6709 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6710 This avoids several warnings with gcc -Wstrict-overflow.
6711 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6712 directly, rather than having caller test rule sign. This avoids
6713 some unnecessary tests.
6714 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6715 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6716 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6717
6718 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6719 (xfont_open): Avoid unnecessary tests.
6720
6721 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6722
6723 * composite.h, composite.c (composition_gstring_put_cache):
6724 Use EMACS_INT, not int, for length.
6725
6726 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6727 breaking out part of COMPOSITION_DECODE_RULE.
6728 (COMPOSITION_DECODE_RULE): Use it.
6729 * composite.c (get_composition_id): Remove unused local vars,
6730 by using the new macro.
6731
6732 * textprop.c (set_text_properties_1): Change while to do-while,
6733 since the condition is always true at first.
6734
6735 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6736 (interval_deletion_adjustment): Return unsigned value.
6737 All uses changed.
6738
6739 * process.c (list_processes_1, create_pty, read_process_output):
6740 (exec_sentinel): Remove vars that were set but not used.
6741 (create_pty): Remove unnecessary "volatile"s.
6742 (Fnetwork_interface_info): Avoid possibility of int overflow.
6743 (read_process_output): Do adaptive read buffering even if carryover.
6744 (read_process_output): Simplify nbytes computation if buffered.
6745
6746 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6747
6748 * syntax.c (scan_words): Remove var that was set but not used.
6749 (update_syntax_table): Use unsigned instead of int.
6750
6751 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6752 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6753 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6754
6755 * print.c (print_error_message): Avoid int overflow.
6756
6757 * font.c (font_list_entities): Redo for clarity,
6758 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6759
6760 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6761 (font_score): Avoid potential overflow in diff calculation.
6762
6763 * fns.c (substring_both): Remove var that is set but not used.
6764 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6765
6766 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6767
6768 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6769 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6770 can always succeed if overflow has undefined behavior.
6771
6772 * search.c (boyer_moore, wordify): Remove vars set but not used.
6773 (wordify): Omit three unnecessary tests.
6774
6775 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6776 All callers changed. This avoids the need for an unused var.
6777
6778 * casefiddle.c (casify_region): Remove var that is set but not used.
6779
6780 * dired.c (file_name_completion): Remove var that is set but not used.
6781
6782 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6783
6784 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6785 (Finsert_file_contents): Remove unnecessary code checking fd.
6786
6787 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6788 Check for integer overflow on size calculations.
6789
6790 * buffer.c (Fprevious_overlay_change): Remove var that is set
6791 but not used.
6792
6793 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6794 Remove vars that are set but not used.
6795 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6796 (timer_check_2): Mark vars as initialized.
6797
6798 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6799
6800 * image.c (lookup_image): Remove var that is set but not used.
6801 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6802
6803 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6804 that are set but not used.
6805
6806 * xfns.c (make_invisible_cursor): Don't return garbage
6807 if XCreateBitmapFromData fails (Bug#8410).
6808
6809 * xselect.c (x_get_local_selection, x_handle_property_notify):
6810 Remove vars that are set but not used.
6811
6812 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6813 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6814
6815 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6816 Remove var that is set but not used.
6817 (scroll_bar_windows_size): Now size_t, not int.
6818 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6819 Check for overflow.
6820
6821 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6822 (map_tty_color) [!defined MSDOS]: Likewise.
6823
6824 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6825
6826 * coding.c: Remove vars that are set but not used.
6827 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6828 All callers changed.
6829 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6830 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6831 (decode_coding_charset): Remove vars that are set but not used.
6832
6833 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6834 that is set but not used.
6835
6836 * print.c (print_object): Remove var that is set but not used.
6837
6838 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6839 The gnulib version avoids calling malloc in the usual case,
6840 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6841 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6842 * filelock.c (current_lock_owner): Likewise.
6843 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6844 * sysdep.c: Include allocator.h, careadlinkat.h.
6845 (emacs_no_realloc_allocator): New static constant.
6846 (emacs_readlink): New function.
6847 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6848 ../lib/careadlinkat.h.
6849
6850 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6851
6852 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6853 first non-nil return value).
6854
6855 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6856
6857 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6858 if not defined (Bug#8403).
6859
6860 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6861
6862 * xdisp.c (display_count_lines): Remove parameter `start',
6863 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6864 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6865 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6866 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6867 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6868 and thereabouts. All callers changed.
6869 (get_per_char_metric): Remove parameter `f', unused since
6870 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6871
6872 2011-04-02 Jim Meyering <meyering@redhat.com>
6873
6874 do not dereference NULL upon failed strdup
6875 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6876 (ns_get_family): Likewise.
6877
6878 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6879
6880 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6881
6882 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6883
6884 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6885 later (Bug#8403).
6886
6887 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6888
6889 Add lexical binding.
6890
6891 * window.c (Ftemp_output_buffer_show): New fun.
6892 (Fsave_window_excursion):
6893 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6894
6895 * lread.c (lisp_file_lexically_bound_p): New function.
6896 (Fload): Bind Qlexical_binding.
6897 (readevalloop): Remove `evalfun' arg.
6898 Bind Qinternal_interpreter_environment.
6899 (Feval_buffer): Bind Qlexical_binding.
6900 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6901 Mark as dynamic.
6902 (syms_of_lread): Declare `lexical-binding'.
6903
6904 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6905
6906 * keyboard.c (eval_dyn): New fun.
6907 (menu_item_eval_property): Use it.
6908
6909 * image.c (parse_image_spec): Use Ffunctionp.
6910
6911 * fns.c (concat, mapcar1): Accept byte-code-functions.
6912
6913 * eval.c (Fsetq): Handle lexical vars.
6914 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6915 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6916 (FletX, Flet): Obey lexical binding.
6917 (Fcommandp): Handle closures.
6918 (Feval): New `lexical' arg.
6919 (eval_sub): New function extracted from Feval. Use it almost
6920 everywhere where Feval was used. Look up vars in lexical env.
6921 Handle closures.
6922 (Ffunctionp): Move from subr.el.
6923 (Ffuncall): Handle closures.
6924 (apply_lambda): Remove `eval_flags'.
6925 (funcall_lambda): Handle closures and new byte-code-functions.
6926 (Fspecial_variable_p): New function.
6927 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6928 but without exporting it to Lisp.
6929
6930 * doc.c (Fdocumentation, store_function_docstring):
6931 * data.c (Finteractive_form): Handle closures.
6932
6933 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6934 interactive spec.
6935
6936 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6937 New byte-codes.
6938 (exec_byte_code): New function extracted from Fbyte_code to handle new
6939 calling convention for byte-code-functions. Add new byte-codes.
6940
6941 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6942
6943 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6944
6945 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6946
6947 * xdisp.c (redisplay_internal): Fix prototype.
6948
6949 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6950
6951 * xdisp.c (SCROLL_LIMIT): New macro.
6952 (try_scrolling): Use it when setting scroll_limit.
6953 Limit scrolling to 100 screen lines.
6954 (redisplay_window): Even when falling back on "recentering",
6955 position point in the window according to scroll-conservatively,
6956 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6957
6958 (try_scrolling): When point is above the window, allow searching
6959 as far as scroll_max, or one screenful, to compute vertical
6960 distance from PT to the scroll margin position. This prevents
6961 try_scrolling from unnecessarily failing when
6962 scroll-conservatively is set to a value slightly larger than the
6963 window height. Clean up the case of PT below the margin at bottom
6964 of window: scroll_max can no longer be INT_MAX. When aggressive
6965 scrolling is in use, don't let point enter the opposite scroll
6966 margin as result of the scroll.
6967 (syms_of_xdisp) <scroll-conservatively>: Document the
6968 threshold of 100 lines for never-recentering scrolling.
6969
6970 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6971
6972 * dispextern.h (move_it_by_lines):
6973 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6974 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6975 (message_log_check_duplicate): Remove parameters `prev_bol' and
6976 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6977 (redisplay_internal): Remove parameter `preserve_echo_area',
6978 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6979
6980 * indent.c (Fvertical_motion):
6981 * window.c (window_scroll_pixel_based, Frecenter):
6982 Don't pass `need_y_p' to `move_it_by_lines'.
6983
6984 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6985
6986 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6987 steal a few bits to be more compact.
6988 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6989 Remove unneeded casts.
6990
6991 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6992
6993 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6994
6995 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6996 binding" message (bug#7967).
6997
6998 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6999
7000 Fix more problems found by GCC 4.6.0's static checks.
7001
7002 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7003 Remove unused local var.
7004
7005 * editfns.c (Fmessage_box): Remove unused local var.
7006
7007 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7008 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7009 Omit unused local vars.
7010 * window.c (shrink_windows): Omit unused local var.
7011 * menu.c (digest_single_submenu): Omit unused local var.
7012 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7013 Omit unused local var.
7014
7015 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7016 Don't assume string length fits in int.
7017 (keyremap_step, read_key_sequence): Use size_t for sizes.
7018 (read_key_sequence): Don't check last_real_key_start redundantly.
7019
7020 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7021 instead of alloca (Bug#8344).
7022
7023 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7024 (Fbacktrace_frame): Don't assume nframes fits in int.
7025
7026 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7027
7028 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7029 concerns.
7030
7031 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7032
7033 * cm.c (calccost): Turn while-do into do-while, for clarity.
7034
7035 * keyboard.c (syms_of_keyboard): Use the same style as later
7036 in this function when indexing through an array. This also
7037 works around GCC bug 48267.
7038
7039 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7040
7041 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7042
7043 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7044 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7045
7046 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7047 This avoids undefined behavior on integer overflow, and is a bit
7048 more convenient anyway since it is compared to a size_t variable.
7049
7050 Variadic C functions now count arguments with size_t, not int.
7051 This avoids an unnecessary limitation on 64-bit machines, which
7052 caused (substring ...) to crash on large vectors (Bug#8344).
7053 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7054 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7055 All variadic functions and their callers changed accordingly.
7056 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7057 * data.c (arith_driver, float_arith_driver): Likewise.
7058 * editfns.c (general_insert_function): Likewise.
7059 * eval.c (struct backtrace.nargs, interactive_p)
7060 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7061 (funcall_lambda, mark_backtrace): Likewise.
7062 * fns.c (concat): Likewise.
7063 * frame.c (x_set_frame_parameters): Likewise.
7064 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7065 0 if not found, not -1. All callers changed.
7066
7067 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7068 (stack_copy_size): Now size_t, not int.
7069 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7070
7071 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7072
7073 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7074 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7075 All callers changed.
7076
7077 * lisp.h (multibyte_char_to_unibyte):
7078 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7079 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7080 * character.h (CHAR_TO_BYTE8):
7081 * cmds.c (internal_self_insert):
7082 * editfns.c (general_insert_function):
7083 * keymap.c (push_key_description):
7084 * search.c (Freplace_match):
7085 * xdisp.c (message_dolog, set_message_1): All callers changed.
7086
7087 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7088
7089 * keyboard.c (safe_run_hook_funcall): New function.
7090 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7091 don't set the hook to nil, but remove the offending function instead.
7092 (Qcommand_hook_internal): Remove, unused.
7093 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7094 Vcommand_hook_internal.
7095
7096 * eval.c (enum run_hooks_condition): Remove.
7097 (funcall_nil, funcall_not): New functions.
7098 (run_hook_with_args): Call each function through a `funcall' argument.
7099 Remove `cond' argument, now redundant.
7100 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7101 (Frun_hook_with_args_until_failure): Adjust accordingly.
7102 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7103
7104 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7105
7106 * dispextern.h (string_buffer_position): Remove declaration.
7107
7108 * print.c (strout): Remove parameter `multibyte', unused since
7109 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7110
7111 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7112 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7113 All callers changed.
7114
7115 * w32.c (_wsa_errlist): Use braces for struct initializers.
7116
7117 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7118 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7119 All callers changed.
7120 (string_buffer_position): Likewise. Also, make static (it's never
7121 used outside xdisp.c).
7122 (cursor_row_p): Remove parameter `w', unused since
7123 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7124 (decode_mode_spec): Remove parameter `precision', introduced during
7125 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7126 All callers changed.
7127
7128 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7129
7130 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7131
7132 2011-03-27 Anders Lindgren <andlind@gmail.com>
7133
7134 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7135 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7136 (ns_update_auto_hide_menu_bar): New functions.
7137 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7138 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7139 ns_constrain_all_frames.
7140 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7141 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7142
7143 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7144
7145 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7146
7147 2011-03-27 Glenn Morris <rgm@gnu.org>
7148
7149 * syssignal.h: Replace RETSIGTYPE with void.
7150 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7151 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7152 Replace SIGTYPE with void everywhere.
7153 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7154 * s/template.h (SIGTYPE): Remove commented out definition.
7155
7156 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7157
7158 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7159 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7160
7161 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7162
7163 * w32.c (read_unc_volume): Use parameter `henum', instead of
7164 global variable `wget_enum_handle'.
7165
7166 * keymap.c (describe_vector): Remove parameters `indices' and
7167 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7168 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7169
7170 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7171
7172 * keyboard.c (timer_check): Remove parameter `do_it_now',
7173 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7174 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7175 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7176
7177 * keyboard.c (read_char):
7178 * w32menu.c (w32_menu_display_help):
7179 * xmenu.c (show_help_event, menu_help_callback):
7180 Adjust calls to `show_help_echo'.
7181
7182 * gtkutil.c (xg_maybe_add_timer):
7183 * keyboard.c (readable_events):
7184 * process.c (wait_reading_process_output):
7185 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7186
7187 * insdel.c (adjust_markers_gap_motion):
7188 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7189 (gap_left, gap_right): Don't call it.
7190
7191 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7192
7193 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7194 incurred during fontification.
7195
7196 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7197
7198 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7199 (DEFVAR_PER_BUFFER): Don't pass it.
7200
7201 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7202 (scrolling_window): Don't pass it.
7203
7204 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7205
7206 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7207
7208 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7209 and `suffix'.
7210 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7211 of variables specific to SELinux and computation of `encoded_absname'.
7212
7213 * image.c (XPutPixel): Remove unused variable `height'.
7214
7215 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7216
7217 * unexw32.c (get_section_info): Remove unused variable `section'.
7218
7219 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7220 (system_process_attributes): Remove unused variable `sess'.
7221 (sys_read): Remove unused variable `err'.
7222
7223 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7224 (w32_wnd_proc): Remove unused variable `isdead'.
7225 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7226 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7227 (x_create_tip_frame): Remove unused variable `tem'.
7228
7229 * w32inevt.c (w32_console_read_socket):
7230 Remove unused variable `no_events'.
7231
7232 * w32term.c (x_draw_composite_glyph_string_foreground):
7233 Remove unused variable `width'.
7234
7235 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7236
7237 * w32term.c (x_set_glyph_string_clipping):
7238 Don't pass uninitialized region to CombineRgn.
7239
7240 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7241
7242 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7243 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7244 (Fx_close_connection): Remove unused variable `i'.
7245
7246 * w32font.c (w32font_draw): Return number of glyphs.
7247 (w32font_open_internal): Remove unused variable `i'.
7248 (w32font_driver): Add missing initializer.
7249
7250 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7251 (fill_in_menu): Remove unused variable `items_added'.
7252
7253 * w32term.c (last_mouse_press_frame): Remove static global variable.
7254 (w32_clip_to_row): Remove unused variable `f'.
7255 (x_delete_terminal): Remove unused variable `i'.
7256
7257 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7258 (NOTHING): Remove unused static global variable.
7259 (uniscribe_check_otf): Remove unused variable `table'.
7260 (uniscribe_font_driver): Add missing initializers.
7261
7262 2011-03-23 Julien Danjou <julien@danjou.info>
7263
7264 * term.c (Fsuspend_tty, Fresume_tty):
7265 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7266 * window.c (temp_output_buffer_show):
7267 * insdel.c (signal_before_change):
7268 * frame.c (Fhandle_switch_frame):
7269 * fileio.c (Fdo_auto_save):
7270 * emacs.c (Fkill_emacs):
7271 * editfns.c (save_excursion_restore):
7272 * cmds.c (internal_self_insert):
7273 * callint.c (Fcall_interactively):
7274 * buffer.c (Fkill_all_local_variables):
7275 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7276 Use Frun_hooks.
7277 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7278 unconditionnaly since it does the check itself.
7279
7280 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7281
7282 Fix more problems found by GCC 4.5.2's static checks.
7283
7284 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7285 the first time through the loop, since we know p0 < p1 then.
7286 This also avoids a gcc -Wstrict-overflow warning.
7287
7288 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7289 leading to a memory leak, possible in functions like
7290 load_charset_map_from_file that can allocate an unbounded number
7291 of objects (Bug#8318).
7292
7293 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7294 that could (at least in theory) be that large.
7295
7296 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7297 This is less likely to overflow, and avoids undefined behavior if
7298 overflow does occur. All callers changed. Use strtoul to scan
7299 for the unsigned long integer.
7300 (pint2hrstr): Simplify and tune code slightly.
7301 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7302
7303 * scroll.c (do_scrolling): Work around GCC bug 48228.
7304 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7305
7306 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7307 This also avoids a warning with gcc -Wstrict-overflow.
7308 (validate_x_resource_name): Simplify count usage.
7309 This also avoids a warning with gcc -Wstrict-overflow.
7310
7311 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7312 fail (Bug#8306).
7313
7314 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7315
7316 * process.c (Fmake_network_process): Use socklen_t, not int,
7317 where POSIX says socklen_t is required in portable programs.
7318 This fixes a porting bug on hosts like 64-bit HP-UX, where
7319 socklen_t is wider than int (Bug#8277).
7320 (Fmake_network_process, server_accept_connection):
7321 (wait_reading_process_output, read_process_output):
7322 Likewise.
7323
7324 * process.c: Rename or move locals to avoid shadowing.
7325 (list_processes_1, Fmake_network_process):
7326 (read_process_output_error_handler, exec_sentinel_error_handler):
7327 Rename or move locals.
7328 (Fmake_network_process): Define label "retry_connect" only if needed.
7329 (Fnetwork_interface_info): Fix pointer signedness.
7330 (process_send_signal): Add cast to avoid pointer signedness problem.
7331 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7332 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7333
7334 Make tparam.h and terminfo.c consistent.
7335 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7336 Include tparam.h instead, since it declares them.
7337 * cm.h (PC): Remove extern decl; tparam.h now does this.
7338 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7339 * terminfo.c: Include tparam.h, to check interfaces.
7340 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7341 (tparam): Adjust signature to match interface in tparam.h;
7342 this removes some undefined behavior. Check that outstring and len
7343 are zero, which they always are with Emacs.
7344 * tparam.h (PC, BC, UP): New extern decls.
7345
7346 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7347 (xftfont_open): Rename locals to avoid shadowing.
7348
7349 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7350 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7351 (OTF_TAG_SYM): Omit macro if not needed.
7352 (ftfont_list): Remove unused local.
7353 (get_adstyle_property, ftfont_pattern_entity):
7354 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7355 Rename locals to avoid shadowing.
7356
7357 * xfont.c (xfont_list_family): Mark var as initialized.
7358
7359 * xml.c (make_dom): Now static.
7360
7361 * composite.c (composition_compute_stop_pos): Rename local to
7362 avoid shadowing.
7363 (composition_reseat_it): Remove unused locals.
7364 (find_automatic_composition, composition_adjust_point): Likewise.
7365 (composition_update_it): Mark var as initialized.
7366 (find_automatic_composition): Mark vars as initialized,
7367 with a FIXME (Bug#8290).
7368
7369 character.h: Rename locals to avoid shadowing.
7370 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7371 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7372 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7373 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7374 to avoid shadowing.
7375
7376 * textprop.c (property_change_between_p): Remove; unused.
7377
7378 * intervals.c (interval_start_pos): Now static.
7379
7380 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7381
7382 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7383 Rename locals to avoid shadowing.
7384
7385 * sound.c (wav_play, au_play, Fplay_sound_internal):
7386 Fix pointer signedness.
7387 (alsa_choose_format): Remove unused local var.
7388 (wav_play): Initialize a variable to 0, to prevent undefined
7389 behavior (Bug#8278).
7390
7391 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7392
7393 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7394
7395 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7396 clobbering (Bug#8298).
7397 * sysdep.c (sys_subshell): Likewise.
7398 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7399
7400 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7401 This should get cleaned up, so that child_setup has the
7402 same signature on all platforms.
7403
7404 * callproc.c (call_process_cleanup): Now static.
7405 (relocate_fd): Rename locals to avoid shadowing.
7406
7407 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7408
7409 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7410 not to be necessary, and produces flickering.
7411
7412 2011-03-20 Glenn Morris <rgm@gnu.org>
7413
7414 * config.in: Remove file.
7415
7416 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7417
7418 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7419 are now in src/globals.h.
7420 (syms_of_minibuf): Remove spurious & from previous change.
7421
7422 2011-03-20 Leo <sdl.web@gmail.com>
7423
7424 * minibuf.c (completing-read-function): New variable.
7425 (completing-read-default): Rename from completing-read.
7426 (completing-read): Call completing-read-function.
7427
7428 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7429
7430 * xfaces.c (Fx_load_color_file):
7431 Read color file from absolute filename (bug#8250).
7432
7433 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7434
7435 * makefile.w32-in: Update dependencies.
7436
7437 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7438
7439 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7440
7441 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7442
7443 Fix more problems found by GCC 4.5.2's static checks.
7444
7445 * process.c (make_serial_process_unwind, send_process_trap):
7446 (sigchld_handler): Now static.
7447
7448 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7449 That way, the code declares only the vars that it needs.
7450 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7451 * s/cygwin.h (PTY_ITERATION): Likewise.
7452 * s/darwin.h (PTY_ITERATION): Likewise.
7453 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7454
7455 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7456 * process.c (allocate_pty): Don't declare stb unless it's needed.
7457
7458 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7459 (CONSTANTLIM): Remove; unused.
7460 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7461 Define only if needed.
7462
7463 * unexelf.c (unexec): Name an expression,
7464 to avoid gcc -Wbad-function-cast warning.
7465 Use a different way to cause a compilation error if anyone uses
7466 n rather than nn, a way that does not involve shadowing.
7467 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7468
7469 * deps.mk (unexalpha.o): Remove; unused.
7470
7471 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7472 * unexec.h: New file.
7473 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7474 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7475 Depend on unexec.h.
7476 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7477 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7478 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7479 Change as necessary to match prototype in unexec.h.
7480
7481 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7482 shadowing.
7483 (back_comment, skip_chars): Mark vars as initialized.
7484
7485 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7486 Rename locals to avoid shadowing.
7487
7488 * lread.c (read1): Rewrite so as not to use empty "else".
7489 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7490
7491 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7492
7493 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7494 warning when compiling print.c.
7495
7496 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7497 instead of using an uninitialized var.
7498 (font_sort_entities): Mark var as initialized.
7499
7500 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7501
7502 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7503 pointers to constants.
7504 (font_parse_fcname): Remove unused vars.
7505 (font_delete_unmatched): Now static.
7506 (font_get_spec): Remove; unused.
7507 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7508 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7509 Rename or move locals to avoid shadowing.
7510
7511 * fns.c (require_nesting_list, require_unwind): Now static.
7512 (Ffillarray): Rename locals to avoid shadowing.
7513
7514 * floatfns.c (domain_error2): Define only if needed.
7515 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7516
7517 * alloc.c (mark_backtrace): Move decl from here ...
7518 * lisp.h: ... to here, so that it can be checked.
7519
7520 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7521 (Fdefvar): Rewrite so as not to use empty "else".
7522 (lisp_indirect_variable): Name an expression,
7523 to avoid gcc -Wbad-function-cast warning.
7524 (Fdefvar): Rename locals to avoid shadowing.
7525
7526 * callint.c (quotify_arg, quotify_args): Now static.
7527 (Fcall_interactively): Rename locals to avoid shadowing.
7528 Use const pointer when appropriate.
7529
7530 * lisp.h (get_system_name, get_operating_system_release):
7531 Move decls here, to check interfaces.
7532 * process.c (get_operating_system_release): Move decl to lisp.h.
7533 * xrdb.c (get_system_name): Likewise.
7534 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7535 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7536 some of which prompt warnings from gcc -Wbad-function-cast.
7537 (Fformat_time_string, Fencode_time, Finsert_char):
7538 (Ftranslate_region_internal, Fformat):
7539 Rename or remove local vars to avoid shadowing.
7540 (Ftranslate_region_internal): Mark var as initialized.
7541
7542 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7543 avoid shadowing.
7544
7545 * lisp.h (eassert): Check that the argument compiles, even if
7546 ENABLE_CHECKING is not defined.
7547
7548 * data.c (Findirect_variable): Name an expression, to avoid
7549 gcc -Wbad-function-cast warning.
7550 (default_value, arithcompare, arith_driver, arith_error): Now static.
7551 (store_symval_forwarding): Rename local to avoid shadowing.
7552 (Fmake_variable_buffer_local, Fmake_local_variable):
7553 Mark variables as initialized.
7554 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7555
7556 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7557 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7558 Rename locals to avoid shadowing.
7559 (mark_stack): Move local variables into the #ifdef region where
7560 they're used.
7561 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7562 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7563 needed otherwise.
7564 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7565 (GC_STRING_CHARS): Remove; not used.
7566 (Fmemory_limit): Cast sbrk's returned value to char *.
7567
7568 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7569 avoids undefined behavior in theory.
7570
7571 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7572
7573 Use functions, not macros, for up- and down-casing (Bug#8254).
7574 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7575 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7576 to use the following functions instead of these macros.
7577 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7578 EMACS_INT, since callers assume the returned value fits in int.
7579 (upcase1): Likewise, for UPCASE_TABLE.
7580 (uppercasep, lowercasep, upcase): New static inline functions.
7581 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7582 the race-condition problem in the old DOWNCASE.
7583
7584 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7585 Rename locals to avoid shadowing.
7586 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7587 (regex_compile, re_search_2, re_match_2_internal):
7588 Remove unused local vars.
7589 (FREE_VAR): Rewrite so as not to use empty "else",
7590 which gcc can warn about.
7591 (regex_compile, re_match_2_internal): Mark locals as initialized.
7592 (RETALLOC_IF): Define only if needed.
7593 (WORDCHAR_P): Likewise. This one is never needed, but is used
7594 only in a comment talking about a compiler bug, so put inside
7595 the #if 0 of that comment.
7596 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7597 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7598 Remove; unused.
7599
7600 * search.c (boyer_moore): Rename locals to avoid shadowing.
7601 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7602 (PREV_CHAR_BOUNDARY): Likewise.
7603
7604 * search.c (simple_search): Remove unused var.
7605
7606 * dired.c (compile_pattern): Move decl from here ...
7607 * lisp.h: ... to here, so that it can be checked.
7608 (struct re_registers): New forward decl.
7609
7610 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7611
7612 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7613 All uses changed.
7614 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7615 Rename locals to avoid shadowing.
7616 (Fvertical_motion): Mark locals as initialized.
7617
7618 * casefiddle.c (casify_object, casify_region): Now static.
7619 (casify_region): Mark local as initialized.
7620
7621 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7622
7623 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7624 New macros, so that the caller can use some names other than
7625 gcpro1, gcpro2, etc.
7626 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7627 of the new macros.
7628 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7629 argument, for consistency with GCPRO2_VAR, etc: it is now the
7630 prefix of the variable, not the variable itself. All uses
7631 changed.
7632 * dired.c (directory_files_internal, file_name_completion):
7633 Rename locals to avoid shadowing.
7634
7635 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7636 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7637 dired.c's scmp function, had undefined behavior.
7638 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7639 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7640 * buffer.h: ... to here, because these macros use current_buffer,
7641 and the new implementation with inline functions needs to have
7642 current_buffer in scope now, rather than later when the macros
7643 are used.
7644 (downcase, upcase1): New static inline functions.
7645 (DOWNCASE, UPCASE1): Reimplement using these functions.
7646 This avoids undefined behavior in expressions like
7647 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7648 from race conditions in accessing the global variables
7649 case_temp1 and case_temp2.
7650 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7651 * lisp.h (case_temp1, case_temp2): Remove their decls.
7652 * character.h (ASCII_CHAR_P): Move from here ...
7653 * lisp.h: ... to here, so that the inline functions mentioned
7654 above can use them.
7655
7656 * dired.c (directory_files_internal_unwind): Now static.
7657
7658 * fileio.c (file_name_as_directory, directory_file_name):
7659 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7660 Now static.
7661 (file_name_as_directory): Use const pointers when appropriate.
7662 (Fexpand_file_name): Likewise. In particular, newdir might
7663 point at constant storage, so make it a const pointer.
7664 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7665 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7666 signedness issues.
7667 (Fset_file_times, Finsert_file_contents, auto_save_error):
7668 Rename locals to avoid shadowing.
7669
7670 * minibuf.c (choose_minibuf_frame_1): Now static.
7671 (Ftry_completion, Fall_completions): Rename or remove locals
7672 to avoid shadowing.
7673
7674 * marker.c (bytepos_to_charpos): Remove; unused.
7675
7676 * lisp.h (verify_bytepos, count_markers): New decls,
7677 so that gcc does not warn that these functions aren't declared.
7678
7679 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7680 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7681 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7682 (copy_text): Remove unused local var.
7683
7684 * filelock.c (within_one_second): Now static.
7685 (lock_file_1): Rename local to avoid shadowing.
7686
7687 * buffer.c (fix_overlays_before): Mark locals as initialized.
7688 (fix_start_end_in_overlays): Likewise. This function should be
7689 simplified by using pointers-to-pointers, but that's a different
7690 matter.
7691 (switch_to_buffer_1): Now static.
7692 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7693 (report_overlay_modification): Rename locals to avoid shadowing.
7694
7695 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7696 Fix pointer signedness issue.
7697 (sys_subshell): Mark local as volatile if checking for lint,
7698 to suppress a gcc -Wclobbered warning that does not seem to be right.
7699 (MAXPATHLEN): Define only if needed.
7700
7701 * process.c (serial_open, serial_configure): Move decls from here ...
7702 * systty.h: ... to here, so that they can be checked.
7703
7704 * fns.c (get_random, seed_random): Move extern decls from here ...
7705 * lisp.h: ... to here, so that they can be checked.
7706
7707 * sysdep.c (reset_io): Now static.
7708 (wait_for_termination_signal): Remove; unused.
7709
7710 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7711 (copy_keymap_item, append_key, push_text_char_description):
7712 Now static.
7713 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7714 (DENSE_TABLE_SIZE): Remove; unused.
7715 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7716 (describe_map_tree):
7717 Rename locals to avoid shadowing.
7718
7719 * keyboard.c: Declare functions static if they are not used elsewhere.
7720 (echo_char, echo_dash, cmd_error, top_level_2):
7721 (poll_for_input, handle_async_input): Now static.
7722 (read_char, kbd_buffer_get_event, make_lispy_position):
7723 (make_lispy_event, make_lispy_movement, apply_modifiers):
7724 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7725 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7726 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7727 (read_key_sequence, read_char): Mark locals as initialized.
7728 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7729
7730 * keyboard.h (make_ctrl_char): New decl.
7731 (mark_kboards): Move decl here ...
7732 * alloc.c (mark_kboards): ... from here.
7733
7734 * lisp.h (force_auto_save_soon): New decl.
7735
7736 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7737 (DEFINE_DUMMY_FUNCTION): New macro.
7738 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7739 Use it.
7740 (main): Add casts to avoid warnings
7741 if GCC considers string literals to be constants.
7742
7743 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7744
7745 * dbusbind.c: Pointer signedness fixes.
7746 (xd_signature, xd_append_arg, xd_initialize):
7747 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7748 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7749 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7750 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7751
7752 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7753 if GCC considers string literals to be constants.
7754 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7755
7756 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7757
7758 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7759 (print_preprocess, print_object): New macro to fix last change.
7760
7761 * print.c (print_preprocess): Don't forget font objects.
7762
7763 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7764
7765 * emacs.c (USAGE3): Doc fixes.
7766
7767 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7768
7769 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7770 structure.
7771
7772 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7773
7774 * lisp.h (VWindow_system, Qfile_name_history):
7775 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7776 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7777 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7778
7779 * w32select.c: Don't #include "keyboard.h".
7780 (run_protected): Add extern declaration for waiting_for_input.
7781
7782 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7783 * w32console.c (detect_input_pending, read_input_pending)
7784 (encode_terminal_code):
7785 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7786 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7787 (w32_system_caret_y, Qfile_name_history):
7788 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7789 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7790 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7791 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7792 * w32proc.c (Qlocal, report_file_error):
7793 * w32term.c (Vwindow_system, updating_frame):
7794 * w32uniscribe.c (initialized, uniscribe_font_driver):
7795 Remove unneeded extern declarations.
7796
7797 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7798
7799 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7800
7801 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7802
7803 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7804 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7805 These macros can no longer be used for assignment.
7806
7807 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7808 Assign struct members directly, instead of using BUF_BEGV etc.
7809 (record_buffer_markers, fetch_buffer_markers): New functions for
7810 recording and fetching special buffer markers.
7811 (set_buffer_internal_1, set_buffer_temp): Use them.
7812
7813 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7814
7815 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7816
7817 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7818 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7819
7820 * xdisp.c (hscroll_window_tree):
7821 (reconsider_clip_changes): Use PT instead of BUF_PT.
7822
7823 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7824
7825 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7826 $(EMACS_ROOT)/lib/intprops.h.
7827
7828 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7829
7830 Fix more problems found by GCC 4.5.2's static checks.
7831
7832 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7833 to unsigned char * to avoid compiler diagnostic.
7834 (xg_free_frame_widgets): Make it clear that a local variable is
7835 needed only if USE_GTK_TOOLTIP.
7836 (gdk_window_get_screen): Make it clear that this macro is needed
7837 only if USE_GTK_TOOLTIP.
7838 (int_gtk_range_get_value): New function, which avoids a diagnostic
7839 from gcc -Wbad-function-cast.
7840 (xg_set_toolkit_scroll_bar_thumb): Use it.
7841 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7842 diagnostic from gcc -Wbad-function-cast.
7843 (get_utf8_string, xg_get_file_with_chooser):
7844 Rename locals to avoid shadowing.
7845 (create_dialog): Move locals to avoid shadowing.
7846
7847 * xgselect.c (xg_select): Remove unused var.
7848
7849 * image.c (four_corners_best): Mark locals as initialized.
7850 (gif_load): Initialize transparent_p to zero (Bug#8238).
7851 Mark another local as initialized.
7852 (my_png_error, my_error_exit): Mark with NO_RETURN.
7853
7854 * image.c (clear_image_cache): Now static.
7855 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7856 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7857 (x_edge_detection): Remove unnecessary cast that
7858 gcc -Wbad-function-cast diagnoses.
7859 (gif_load): Fix pointer signedness.
7860 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7861 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7862
7863 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7864
7865 Improve quality of tests for time stamp overflow.
7866 For example, without this patch (encode-time 0 0 0 1 1
7867 1152921504606846976) returns the obviously-bogus value (-948597
7868 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7869 reports time overflow. See
7870 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7871 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7872 * editfns.c: Include limits.h and intprops.h.
7873 (TIME_T_MIN, TIME_T_MAX): New macros.
7874 (time_overflow): Move earlier, to before first use.
7875 (hi_time, lo_time): New functions, for an accurate test for
7876 out-of-range times.
7877 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7878 (Fget_internal_run_time): Don't assume time_t fits in int.
7879 (make_time): Use list2 instead of Fcons twice.
7880 (Fdecode_time): More accurate test for out-of-range times.
7881 (check_tm_member): New function.
7882 (Fencode_time): Use it, to test for out-of-range times.
7883 (lisp_time_argument): Don't rely on undefined left-shift and
7884 right-shift behavior when checking for time stamp overflow.
7885
7886 * editfns.c (time_overflow): New function, refactoring common code.
7887 (Fformat_time_string, Fdecode_time, Fencode_time):
7888 (Fcurrent_time_string): Use it.
7889
7890 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7891 * dired.c (make_time): Move to ...
7892 * editfns.c (make_time): ... here.
7893 * systime.h: Note the move.
7894
7895 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7896
7897 * fringe.c (update_window_fringes): Remove unused variables.
7898
7899 * unexmacosx.c (copy_data_segment): Also copy __got section.
7900 (Bug#8223)
7901
7902 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7903
7904 * termcap.c [MSDOS]: Include "msdos.h".
7905 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7906 Constify `char *' arguments and their references according to
7907 prototypes in tparam.h.
7908
7909 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7910
7911 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7912 Adapt all references accordingly.
7913
7914 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7915
7916 2011-03-11 Tom Tromey <tromey@redhat.com>
7917
7918 * buffer.c (syms_of_buffer): Remove obsolete comment.
7919
7920 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7921
7922 * termhooks.h (encode_terminal_code): Declare prototype.
7923
7924 * msdos.c (encode_terminal_code): Don't declare prototype.
7925
7926 * term.c (encode_terminal_code): Now external again, used by
7927 w32console.c and msdos.c.
7928
7929 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7930 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7931
7932 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7933
7934 Fix some minor problems found by GCC 4.5.2's static checks.
7935
7936 * fringe.c (update_window_fringes): Mark locals as initialized
7937 (Bug#8227).
7938 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7939
7940 * alloc.c (mark_fringe_data): Move decl from here ...
7941 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7942 to check its interface.
7943 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7944
7945 * fontset.c (free_realized_fontset): Now static.
7946 (Fset_fontset_font): Rename local to avoid shadowing.
7947 (fontset_font): Mark local as initialized.
7948 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7949
7950 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7951
7952 * xselect.c (x_disown_buffer_selections): Remove; not used.
7953 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7954 (x_own_selection, Fx_disown_selection_internal): Rename locals
7955 to avoid shadowing.
7956 (x_handle_dnd_message): Remove local to avoid shadowing.
7957
7958 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7959 so that the caller can use some name other than gcpro1.
7960 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7961 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7962 (Fx_backspace_delete_keys_p):
7963 Use them to avoid shadowing, and rename vars to avoid shadowing.
7964 (x_decode_color, x_set_name, x_window): Now static.
7965 (Fx_create_frame): Add braces to silence GCC warning.
7966 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7967 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7968 Remove unused locals.
7969 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7970 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7971 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7972 macros.
7973
7974 * xterm.h (x_mouse_leave): New decl.
7975
7976 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7977 Remove unused functions.
7978 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7979 (x_calc_absolute_position): Now static.
7980 (XTread_socket): Don't define label "out" unless it's used.
7981 Don't declare local "event" unless it's used.
7982 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7983 unless they are used.
7984 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7985 (x_fatal_error_signal): Remove; not used.
7986 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7987 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7988 (x_error_catcher, x_connection_closed, x_error_handler):
7989 (x_error_quitter, xembed_send_message, x_iconify_frame):
7990 (my_log_handler): Rename locals to avoid shadowing.
7991 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7992 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7993
7994 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7995 Rename or move locals to avoid shadowing.
7996 (tty_defined_color, merge_face_heights): Now static.
7997 (free_realized_faces_for_fontset): Remove; not used.
7998 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7999 does not deduce is never used uninitialized.
8000 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8001 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8002
8003 * terminal.c (store_terminal_param): Now static.
8004
8005 * xmenu.c (menu_highlight_callback): Now static.
8006 (set_frame_menubar): Remove unused local.
8007 (xmenu_show): Rename parameter to avoid shadowing.
8008 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8009 since they might point to immutable storage.
8010 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8011 since it's unused otherwise.
8012
8013 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8014 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8015 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8016 avoids a gcc -Wuninitialized diagnostic.
8017 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8018 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8019 does not deduce are never used uninitialized.
8020
8021 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8022
8023 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8024 * window.c (window_loop, size_window):
8025 (run_window_configuration_change_hook, enlarge_window): Likewise.
8026
8027 * window.c (display_buffer): Now static.
8028 (size_window): Mark variables that gcc -Wuninitialized
8029 does not deduce are never used uninitialized.
8030 * window.h (check_all_windows): New decl, to forestall
8031 gcc -Wmissing-prototypes diagnostic.
8032 * dispextern.h (bidi_dump_cached_states): Likewise.
8033
8034 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8035 shadowing.
8036 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8037 Include <limits.h>.
8038 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8039 and to avoid gcc -Wuninitialized warning.
8040 (load_charset_map): Mark variables that gcc -Wuninitialized
8041 does not deduce are never used uninitialized.
8042 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8043
8044 * coding.c (coding_set_source, coding_set_destination):
8045 Use "else { /* comment */ }" rather than "else /* comment */;"
8046 for clarity, and to avoid gcc -Wempty-body warning.
8047 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8048 a block, when the outer 'i' will do.
8049 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8050 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8051 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8052 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8053 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8054 Rename locals to avoid shadowing.
8055 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8056 * coding.c (emacs_mule_char, encode_invocation_designation):
8057 Now static, since they're not used elsewhere.
8058 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8059 (decode_coding_object, encode_coding_object, detect_coding_system):
8060 (decode_coding_emacs_mule): Mark variables that gcc
8061 -Wuninitialized does not deduce are never used uninitialized.
8062 (detect_coding_iso_2022): Initialize a local variable that might
8063 be used uninitialized. Leave a FIXME because it's not clear that
8064 this initialization is needed. (Bug#8211)
8065 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8066 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8067 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8068 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8069 Remove unused macros.
8070
8071 * category.c (hash_get_category_set): Remove unused local var.
8072 (copy_category_table): Now static, since it's not used elsewhere.
8073 * character.c (string_count_byte8): Likewise.
8074
8075 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8076 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8077
8078 * chartab.c (copy_sub_char_table): Now static, since it's not used
8079 elsewhere.
8080 (sub_char_table_ref_and_range, char_table_ref_and_range):
8081 Rename locals to avoid shadowing.
8082 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8083
8084 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8085 (BIDI_BOB): Remove unused macro.
8086
8087 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8088 deduce are never used uninitialized.
8089 * term.c (encode_terminal_code): Likewise.
8090
8091 * term.c (encode_terminal_code): Now static. Remove unused local.
8092
8093 * tparam.h: New file.
8094 * term.c, tparam.h: Include it.
8095 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8096 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8097 Move these decls to tparam.h, and make them agree with what
8098 is actually in tparam.c. The previous trick of using incompatible
8099 decls in different modules does not conform to the C standard.
8100 All callers of tparam changed to use tparam's actual API.
8101 * tparam.c (tparam1, tparam, tgoto):
8102 Use const pointers where appropriate.
8103
8104 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8105 * cm.h (struct cm): Likewise.
8106 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8107 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8108 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8109 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8110 (turn_on_face, init_tty): Likewise.
8111 * termchar.h (struct tty_display_info): Likewise.
8112
8113 * term.c (term_mouse_position): Rename local to avoid shadowing.
8114
8115 * alloc.c (mark_ttys): Move decl from here ...
8116 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8117
8118 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8119
8120 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8121
8122 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8123
8124 * search.c (compile_pattern_1): Remove argument regp, unused since
8125 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8126 (compile_pattern): Don't pass it.
8127
8128 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8129
8130 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8131 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8132 for ! HAVE_GTK3.
8133 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8134
8135 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8136
8137 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8138 gdk_window_get_screen, gdk_window_get_geometry,
8139 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8140 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8141 (xg_get_pixbuf_from_pixmap): New function.
8142 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8143 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8144 Call xg_get_pixbuf_from_pixmap instead of
8145 gdk_pixbuf_get_from_drawable.
8146 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8147 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8148 (xg_check_special_colors): Use GtkStyleContext and its functions
8149 for HAVE_GTK3.
8150 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8151 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8152 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8153 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8154 Call gtk_widget_get_preferred_size.
8155 (xg_frame_resized): gdk_window_get_geometry only takes 5
8156 parameters.
8157 (xg_win_to_widget, xg_event_is_for_menubar):
8158 Call gdk_x11_window_lookup_for_display.
8159 (xg_set_widget_bg): New function.
8160 (delete_cb): New function.
8161 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8162 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8163 (xg_set_background_color): Call xg_set_widget_bg.
8164 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8165 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8166 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8167 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8168 if ! HAVE_GTK3.
8169 (update_frame_tool_bar): Call gtk_widget_hide.
8170 (xg_initialize): Use GDK_KEY_g.
8171
8172 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8173 if ! HAVE_GTK3
8174 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8175
8176 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8177 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8178 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8179
8180 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8181
8182 * w32xfns.c (select_palette): Check success of RealizePalette against
8183 GDI_ERROR, not zero.
8184
8185 See ChangeLog.11 for earlier changes.
8186
8187 ;; Local Variables:
8188 ;; coding: utf-8
8189 ;; End:
8190
8191 Copyright (C) 2011 Free Software Foundation, Inc.
8192
8193 This file is part of GNU Emacs.
8194
8195 GNU Emacs is free software: you can redistribute it and/or modify
8196 it under the terms of the GNU General Public License as published by
8197 the Free Software Foundation, either version 3 of the License, or
8198 (at your option) any later version.
8199
8200 GNU Emacs is distributed in the hope that it will be useful,
8201 but WITHOUT ANY WARRANTY; without even the implied warranty of
8202 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8203 GNU General Public License for more details.
8204
8205 You should have received a copy of the GNU General Public License
8206 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.